gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
   4         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
   5         defines.
   6
   7 2019-07-17  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-winsource.h (tui_erase_source_content)
  10         (tui_clear_source_content): Remove "display_prompt" parameter.
  11         * tui/tui-winsource.c (tui_update_source_window_as_is)
  12         (tui_update_source_windows_with_addr): Update.
  13         (tui_clear_source_content): Remove "display_prompt" parameter.
  14         (tui_erase_source_content): Likewise.  Simplify.
  15         (tui_show_source_content): Update.
  16         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  17         * tui/tui-stack.c (tui_show_frame_info): Update.
  18         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
  19         Remove defines.
  20
  21 2019-07-17  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  24         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
  25         parameter.
  26         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
  27         parameter.
  28
  29 2019-07-17  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-winsource.c (tui_clear_source_content)
  32         (tui_show_source_content, tui_show_exec_info_content)
  33         (tui_clear_exec_info_content): Update.
  34         * tui/tui-stack.c (tui_show_locator_content): Update.
  35         (tui_show_frame_info): Update.
  36         * tui/tui-source.h (tui_source_window): Don't declare.
  37         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
  38         from tui_source_is_displayed.
  39         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
  40         Remove field.
  41         (struct tui_source_window_base) <content_in_use>: New field.  Now
  42         bool.
  43         (struct tui_source_window) <showing_source_p>: New method.
  44         (TUI_SRC_WIN): Change cast.
  45         * tui/tui-data.c (tui_initialize_static_data): Update.
  46
  47 2019-07-17  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
  50         location_matches_p.
  51         * tui/tui-source.c (tui_source_window::location_matches_p): New
  52         method.
  53         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
  54         method.
  55         * tui/tui-data.h (struct tui_source_window_base)
  56         <location_matches_p>: New method.
  57         (struct tui_source_window, struct tui_disasm_window)
  58         <location_matches_p>: Likewise.
  59
  60 2019-07-17  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-win.c (tui_set_win_height_command): Rename from
  63         tui_set_win_height.
  64         (tui_set_win_height_command): Remove.
  65
  66 2019-07-17  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-source.c (tui_source_window): New constructor.  Add
  69         observer.
  70         (~tui_source_window): New destructor.
  71         (tui_source_window::style_changed): New method.
  72         * tui/tui-hooks.c (tui_redisplay_source): Remove.
  73         (tui_attach_detach_observers): Update.
  74         * tui/tui-data.h (struct tui_source_window): Make constructor not
  75         inline.  Add destructor.
  76         (struct tui_source_window) <style_changed>: New method.
  77         <m_observable>: New member.
  78
  79 2019-07-17  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
  82         * tui/tui-win.c (tui_resize_all): Fix typo.
  83
  84 2019-07-17  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-wingeneral.h (tui_refresh_all): Update.
  87         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
  88         (tui_refresh_all): Remove "list" parameter.  Use foreach.
  89         * tui/tui-win.c (window_name_completer): Use foreach.
  90         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
  91         (update_tab_width): Likewise.
  92         * tui/tui-layout.c (show_layout): Update.
  93         * tui/tui-data.h (class tui_window_iterator): New.
  94         (struct all_tui_windows): New.
  95         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
  96
  97 2019-07-17  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 100         parameter.  Don't reference globals.
 101         (tui_reg_command): Update.
 102
 103 2019-07-17  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-regs.c (tui_show_registers): Simplify.
 106
 107 2019-07-17  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-regs.c (tui_show_registers): Update.
 110         (tui_show_register_group): Add win_info parameter.
 111
 112 2019-07-17  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 115         Rename from tui_display_reg_element_at_line.
 116         (tui_data_window::display_registers_from_line): Update.
 117         * tui/tui-data.h (struct tui_data_window)
 118         <display_reg_element_at_line>: New method.
 119
 120 2019-07-17  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-regs.h (tui_display_registers_from)
 123         (tui_display_registers_from_line): Don't declare.
 124         * tui/tui-windata.c (tui_data_window::display_all_data)
 125         (tui_data_window::refresh_all)
 126         (tui_data_window::do_scroll_vertical): Update.
 127         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 128         from tui_display_registers_from.
 129         (tui_display_reg_element_at_line): Update.
 130         (tui_data_window::display_registers_from_line): Rename from
 131         tui_display_registers_from_line.
 132         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 133         display_registers_from_line>: New methods.
 134
 135 2019-07-17  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 138         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 139         from tui_erase_data_content.
 140         (tui_data_window::display_all_data)
 141         (tui_data_window::refresh_all)
 142         (tui_data_window::do_scroll_vertical): Update.
 143         * tui/tui-regs.c (tui_show_registers): Update.
 144         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 145         New method.
 146
 147 2019-07-17  Tom Tromey  <tom@tromey.com>
 148
 149         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 150         declare.
 151         * tui/tui-windata.c
 152         (tui_data_window::delete_data_content_windows): Rename from
 153         tui_delete_data_content_windows.
 154         (tui_data_window::display_all_data)
 155         (tui_data_window::do_scroll_vertical): Update.
 156         * tui/tui-data.h (struct tui_data_window)
 157         <delete_data_content_windows>: New method.
 158
 159 2019-07-17  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 162         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 163
 164 2019-07-17  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 167         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 168         from tui_display_all_data.
 169         * tui/tui-win.c
 170         (tui_data_window::do_make_visible_with_new_height): Update.
 171         * tui/tui-regs.c (tui_show_registers): Update.
 172         * tui/tui-layout.c (tui_set_layout): Update.
 173         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 174         method.
 175
 176 2019-07-17  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 179         * tui/tui-windata.c (tui_display_data_from): Remove.
 180         (tui_data_window::refresh_all): Update.
 181
 182 2019-07-17  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 185         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 186         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 187         tui_display_registers_from_line.
 188         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 189         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 190         "force_display" parameter.
 191
 192 2019-07-17  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 195         declare.
 196         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 197         Rename from tui_first_reg_element_no_inline.
 198         (tui_display_reg_element_at_line)
 199         (tui_display_registers_from_line): Update.
 200         * tui/tui-data.h (struct tui_data_window)
 201         <first_reg_element_no_inline>: New method.
 202
 203 2019-07-17  Tom Tromey  <tom@tromey.com>
 204
 205         * tui/tui-windata.c (tui_display_data_from)
 206         (tui_data_window::do_scroll_vertical): Update.
 207         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 208         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 209         Rename from tui_line_from_reg_element_no.
 210         (tui_display_registers_from_line): Update.
 211         * tui/tui-data.h (struct tui_data_window)
 212         <line_from_reg_element_no>: New method.
 213
 214 2019-07-17  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 217         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 218         tui_last_regs_line_no.
 219         (tui_display_reg_element_at_line)
 220         (tui_display_registers_from_line): Update.
 221         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 222         method.
 223
 224 2019-07-17  Tom Tromey  <tom@tromey.com>
 225
 226         PR tui/24722:
 227         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 228         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 229         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 230         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 231         (tui_update_breakpoint_info): Likewise.
 232         * tui/tui-hooks.c (tui_event_create_breakpoint)
 233         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 234         Update.
 235
 236 2019-07-17  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 239
 240 2019-07-17  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-winsource.c (tui_update_source_window_as_is)
 243         (tui_update_source_windows_with_addr): Update.
 244         * tui/tui-source.h (tui_set_source_content)
 245         (tui_show_symtab_source): Add "win_info" parameter.
 246         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 247         parameter.
 248         (tui_show_symtab_source): Likewise.
 249
 250 2019-07-17  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-wingeneral.c
 253         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 254
 255 2019-07-17  Tom Tromey  <tom@tromey.com>
 256
 257         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 258         (struct tui_cmd_window) <can_scroll>: New method.
 259         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 260         method.
 261
 262 2019-07-17  Tom Tromey  <tromey@adacore.com>
 263
 264         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 265         do_field_signed>: Rename.  Change type of "value".
 266         * ui-out.c (ui_out::field_signed): Rename from field_int.
 267         Change type of "value".
 268         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 269         type of "value".
 270         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 271         do_field_int.  Change type of "value".
 272         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 273         do_field_int.  Change type of "value".
 274         * tracepoint.c (trace_status_mi, tfind_1)
 275         (print_one_static_tracepoint_marker): Update.
 276         * thread.c (print_thread_info_1, print_selected_thread_frame):
 277         Update.
 278         * stack.c (print_frame, print_frame_info): Update.
 279         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 280         Update.
 281         * source.c (print_source_lines_base): Update.
 282         * skip.c (info_skip_command): Update.
 283         * record-btrace.c (btrace_ui_out_decode_error)
 284         (btrace_call_history_src_line): Update.
 285         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 286         Update.
 287         * progspace.c (print_program_space): Update.
 288         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 289         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 290         do_field_int.  Change type of "value".
 291         * mi/mi-out.c (mi_ui_out::do_table_begin)
 292         (mi_ui_out::do_table_header): Update.
 293         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 294         type of "value".
 295         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 296         (mi_cmd_data_list_changed_registers, output_register)
 297         (mi_cmd_data_read_memory, mi_load_progress)
 298         (mi_cmd_trace_frame_collected): Update.
 299         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 300         Update.
 301         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 302         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 303         (mi_cmd_var_list_children, varobj_update_one): Update.
 304         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 305         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 306         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 307         * inferior.c (print_inferior): Update.
 308         * gdb_bfd.c (print_one_bfd): Update.
 309         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 310         Update.
 311         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 312         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 313         do_field_int.  Change type of "value".
 314         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 315         do_field_int.  Change type of "value".
 316         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 317         (print_one_breakpoint_location, print_it_catch_fork)
 318         (print_one_catch_fork, print_it_catch_vfork)
 319         (print_one_catch_vfork, print_it_catch_solib)
 320         (print_it_catch_exec, print_it_ranged_breakpoint)
 321         (print_mention_watchpoint, print_mention_masked_watchpoint)
 322         (bkpt_print_it, update_static_tracepoint): Update.
 323         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 324         * break-catch-syscall.c (print_it_catch_syscall): Update.
 325         * ada-tasks.c (print_ada_task_info): Update.
 326         * ada-lang.c (print_it_exception, print_mention_exception):
 327         Update.
 328
 329 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 330
 331         PR breakpoints/24541
 332         * gdbarch.c: Regenerate.
 333         * gdbarch.h: Regenerate.
 334         * gdbarch.sh: Adjust return type and parameter types for
 335         'stap_adjust_register'.
 336         (i386_stap_adjust_register): Adjust signature and return new
 337         register name.
 338         * stap-probe.c (stap_parse_register_operand): Adjust use of
 339         'gdbarch_stap_adjust_register'.
 340
 341 2019-07-17  Tom Tromey  <tromey@adacore.com>
 342
 343         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 344         declare VEC.
 345         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 346         std::vector.
 347         (struct s390_process_info): Add initializers.
 348         (s390_add_process): Use new.
 349         (s390_linux_nat_target::low_forget_process): Use delete.
 350         (s390_linux_nat_target::low_new_fork)
 351         (s390_linux_nat_target::stopped_by_watchpoint)
 352         (s390_linux_nat_target::low_prepare_to_resume)
 353         (s390_linux_nat_target::insert_watchpoint)
 354         (s390_linux_nat_target::insert_hw_breakpoint)
 355         (s390_linux_nat_target::remove_watchpoint)
 356         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 357
 358 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 359
 360         * aarch64-fbsd-nat.c: Include regcache.h.
 361         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 362         argument.
 363         (aarch64_fbsd_nat_target::fetch_registers)
 364         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 365         variable.
 366         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 367
 368 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 369
 370         * fbsd-nat.c: Include gdbarch.h.
 371
 372 2019-07-15  Tom Tromey  <tromey@adacore.com>
 373
 374         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 375
 376 2019-07-15  Tom Tromey  <tromey@adacore.com>
 377
 378         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 379         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 380         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 381         * cli-out.c (cli_ui_out::do_field_int): New method.
 382         * ui-out.c (ui_out::field_unsigned): New method.
 383         * symfile.c (generic_load): Use field_unsigned.
 384         (print_transfer_performance): Likewise.
 385         * record-btrace.c (ui_out_field_uint): Remove.
 386         (btrace_call_history_insn_range, btrace_call_history): Use
 387         field_unsigned.
 388         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 389         field_unsigned.
 390         * ui-out.h (class ui_out) <field_unsigned>: New method.
 391         <do_field_unsigned>: Likewise.
 392
 393 2019-07-15  Tom Tromey  <tromey@adacore.com>
 394
 395         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 396         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 397         * target.c (flash_erase_command): Use field_string.
 398         * infrun.c (print_signal_received_reason): Use field_string.
 399         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 400         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 401         field_string.
 402         * ada-tasks.c (print_ada_task_info): Use field_string.
 403
 404 2019-07-15  Tom Tromey  <tromey@adacore.com>
 405
 406         * target.c (flash_erase_command): Use field_core_addr.
 407         * symfile.c (generic_load): Use field_core_addr.
 408         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 409         Use field_core_addr.
 410         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 411         field_core_addr.
 412
 413 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 414
 415         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 416         value if its desired type is smaller than a CORE_ADDR and signed.
 417
 418 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 419
 420         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 421         of changes to field names, and use new is_reference field to
 422         decide if a property is a reference or not.
 423         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 424         field.
 425         (struct dwarf2_property_baton): Update header comment, rename
 426         'referenced_type' to 'property_type' and update comments.
 427         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 428         default property type, store in property baton, update to take
 429         accound of renamed field.
 430         (read_func_scope): Update call to attr_to_dynamic_prop.
 431         (read_array_type): Likewise.
 432         (dwarf2_per_cu_addr_sized_int_type): New function.
 433         (read_subrange_index_type): Move type finding code to
 434         dwarf2_per_cu_addr_sized_int_type.
 435         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 436         (dwarf2_per_cu_addr_type): New function.
 437         (set_die_type): Update calls to attr_to_dynamic_prop.
 438
 439 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 440
 441         * dwarf2read.c (read_subrange_index_type): New function.
 442         (read_subrange_type): Move code into new function and call it.
 443         * gdbtypes.c (create_range_type): Add some asserts.
 444
 445 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 446
 447         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 448         update return statements.
 449         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 450         declaration, and update comment to match.
 451         * gdbtypes.c (resolve_dynamic_array): Update call to
 452         dwarf2_evaluate_property to match new return type.
 453
 454 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 455
 456         * valarith.c (value_subscripted_rvalue): Change lowerbound
 457         parameter type from int to LONGEST.
 458         * value.h (value_subscripted_rvalue): Likewise in declaration.
 459
 460 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 461
 462         * cli/cli-utils.c (info_print_command_completer): New function.
 463         * cli/cli-utils.h: Add 'completer.h' include, and forward
 464         declaration for 'struct cmd_list_element'.
 465         (info_print_command_completer): Declare.
 466         * stack.c (_initialize_stack): Add completer for 'info locals' and
 467         'info args'.
 468         * symtab.c (_initialize_symtab): Add completer for 'info
 469         variables' and 'info functions'.
 470         * NEWS: Mention completion for additional info commands.
 471
 472 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 473
 474         * cli/cli-utils.c (extract_info_print_args): Delete.
 475         (extract_arg_maybe_quoted): Delete.
 476         (info_print_options_defs): New variable.
 477         (make_info_print_options_def_group): New function.
 478         (extract_info_print_options): Define new function.
 479         * cli/cli-utils.h (extract_info_print_args): Delete.
 480         (struct info_print_options): New structure.
 481         (extract_info_print_options): Declare new function.
 482         * stack.c (info_locals_command): Update to use new
 483         extract_info_print_options, also add a header comment.
 484         (info_args_command): Likewise.
 485         * symtab.c (info_variables_command): Likewise.
 486         (info_functions_command): Likewise.
 487
 488 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 489
 490         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 491         to extract string arguments.
 492         * common/common-utils.c (extract_string_maybe_quoted): New function.
 493         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 494
 495 2019-07-11  Tom Tromey  <tromey@adacore.com>
 496
 497         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 498         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 499         * top.h (gdbinit): Don't declare.
 500         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 501         into...
 502         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 503         * top.c (gdb_init): Don't call init_cli_cmds.
 504         (gdbinit): Remove.
 505         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 506
 507 2019-07-11  Tom Tromey  <tromey@adacore.com>
 508
 509         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 510         after it has been moved.
 511
 512 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 513
 514         * valops.c (value_must_coerce_to_target): Change return type to
 515         bool.
 516         * value.h (value_must_coerce_to_target): Likewise.
 517
 518 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 519
 520         * breakpoint.c (is_hardware_watchpoint): Remove
 521         forward-declaration.
 522         (is_masked_watchpoint): Change return type to bool.
 523         (is_tracepoint): Likewise.
 524         (is_breakpoint): Likewise.
 525         (is_hardware_watchpoint): Likewise.
 526         (is_watchpoint): Likewise.
 527         (is_no_memory_software_watchpoint): Likewise.
 528         (is_catchpoint): Likewise.
 529         (breakpoint_1): Make FILTER parameter's return type bool.
 530         is_masked_watchpoint): Change return type to bool.
 531         (save_breakpoints): Make FILTER parameter's return type bool.
 532         * breakpoint.h (is_breakpoint): Change return type to bool.
 533         (is_watchpoint): Likewise.
 534         (is_catchpoint): Likewise.
 535         (is_tracepoint): Likewise.
 536
 537 2019-07-10  Tom Tromey  <tom@tromey.com>
 538
 539         * defs.h: Don't include gdbarch.h.
 540         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 541         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 542         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 543         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 544         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 545         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 546         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 547         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 548         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 549         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 550         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 551         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 552         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 553         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 554         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 555         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 556         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 557         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 558         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 559         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 560         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 561         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 562         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 563         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 564         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 565         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 566         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 567
 568 2019-07-10  Tom Tromey  <tromey@adacore.com>
 569
 570         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 571         * breakpoint.c (init_ada_exception_breakpoint): Register as
 572         bp_catchpoint.
 573         (print_one_breakpoint_location, print_one_breakpoint): Use
 574         is_ada_exception_catchpoint.
 575         * ada-lang.c (class ada_catchpoint_location): Pass
 576         bp_loc_software_breakpoint to bp_location constructor.
 577         (is_ada_exception_catchpoint): New function.
 578
 579 2019-07-10  Tom Tromey  <tromey@adacore.com>
 580
 581         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 582         VEC.
 583         (struct arm_exidx_entry): New method operator<.
 584         (struct arm_exidx_data) <section_maps>: Change type.
 585         (arm_exidx_data_free): Remove.
 586         (arm_exidx_data_key): Change type.  Move lower.
 587         (arm_exidx_new_objfile): Update.
 588         (arm_compare_exidx_entries): Remove.
 589         (arm_find_exidx_entry, _initialize_arm_tdep)
 590
 591 2019-07-10  Tom Tromey  <tromey@adacore.com>
 592
 593         * solib-spu.c (ocl_program_data_key): Change type.
 594         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 595         Update.
 596
 597 2019-07-10  Tom Tromey  <tromey@adacore.com>
 598
 599         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 600         (struct solib_aix_inferior_data) <library_list>: Change type.
 601         (solib_aix_inferior_data_handle): Change type.
 602         (get_solib_aix_inferior_data): Update.
 603         (solib_aix_free_library_list): Remove.
 604         (library_list_start_library): Update.
 605         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 606         return type.
 607         (solib_aix_get_library_list)
 608         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 609         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 610
 611 2019-07-10  Tom Tromey  <tromey@adacore.com>
 612
 613         * solib-dsbt.c (struct dsbt_info): Add initializers.
 614         (solib_dsbt_pspace_data): Change type.
 615         (dsbt_pspace_data_cleanup): Remove.
 616         (get_dsbt_info, _initialize_dsbt_solib): Update.
 617
 618 2019-07-10  Tom Tromey  <tromey@adacore.com>
 619
 620         * spu-tdep.c (spu_overlay_data): Change type.
 621         (spu_get_overlay_table, spu_overlay_new_objfile)
 622         (_initialize_spu_tdep): Update.
 623
 624 2019-07-10  Tom Tromey  <tromey@adacore.com>
 625
 626         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 627         destructor.
 628         (dbx_objfile_data_key): Change type and declare later.
 629         (DBX_SYMFILE_INFO): Rewrite.
 630         * dbxread.c (dbx_objfile_data_key): Change type.
 631         (dbx_symfile_init): Update.
 632         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 633         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 634         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 635
 636 2019-07-10  Tom Tromey  <tromey@adacore.com>
 637
 638         * jit.c (jit_program_space_key): Change type.  Move lower.
 639         (get_jit_program_space_data): Update.
 640         (jit_program_space_data_cleanup): Remove.
 641         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 642         Update.
 643         (struct jit_program_space_data): Add initializers.
 644
 645 2019-07-10  Tom Tromey  <tromey@adacore.com>
 646
 647         * solib-darwin.c (struct darwin_info): Add initializers.
 648         (solib_darwin_pspace_data): Change type.
 649         (darwin_pspace_data_cleanup): Remove.
 650         (get_darwin_info, _initialize_darwin_solib): Update.
 651
 652 2019-07-10  Tom Tromey  <tromey@adacore.com>
 653
 654         * remote-sim.c (struct sim_inferior_data): Add initializers,
 655         constructor, and destructor.
 656         (sim_inferior_data_key): Change type.  Move lower.
 657         (check_for_duplicate_sim_descriptor): Update.
 658         (get_sim_inferior_data): Use new.  Update.
 659         (~sim_inferior_data_cleanup): Rename from
 660         sim_inferior_data_cleanup.  Simplify.
 661         (gdbsim_close_inferior, simulator_command)
 662         (sim_command_completer, _initialize_remote_sim): Update.
 663         (next_pid, INITIAL_PID): Move earlier.
 664
 665 2019-07-10  Tom Tromey  <tromey@adacore.com>
 666
 667         * python/python-internal.h (create_thread_object): Return
 668         gdbpy_ref.
 669         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 670         * python/py-inferior.c (struct threadlist_entry): Add
 671         constructor.
 672         <thread_obj>: Now a gdbpy_ref.
 673         (thread_to_thread_object): Update.
 674         (add_thread_object): Use new.
 675         (delete_thread_object): Use delete.
 676         (infpy_threads): Update.
 677         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 678         GIL.
 679
 680 2019-07-10  Tom Tromey  <tromey@adacore.com>
 681
 682         * valops.c (value_cast): Specialize error message for Ada.
 683
 684 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 685
 686         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 687
 688 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 689
 690         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 691         bpstat_should_step): Return bool, adjust comments.
 692         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 693         bpstat_should_step): Likewise.
 694
 695 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 696
 697         * features/Makefile: Use feature target descriptions for Arm.
 698         * features/arm/arm-core.c: Generate new file.
 699         * features/arm/arm-fpa.c: Likewise.
 700         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 701         * features/arm/arm-m-profile.c: Likewise.
 702         * features/arm/arm-vfpv2.c: Likewise.
 703         * features/arm/arm-vfpv3.c: Likewise.
 704         * features/arm/xscale-iwmmxt.c: Likewise.
 705         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 706
 707 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 708
 709         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 710         ptrace earlier.
 711
 712 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 713
 714         * features/aarch64-pauth.c: Regenerate.
 715
 716 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 717
 718         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 719         bool.
 720         (bpstat_what): Use false instead of 0.
 721
 722 2019-07-09  Pedro Alves  <palves@redhat.com>
 723
 724         * break-catch-throw.c (is_exception_catchpoint): New.
 725         * breakpoint.c (print_one_breakpoint_location): New parameter
 726         'raw_loc'.  Handle it.  Use
 727         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 728         looking at the breakpoint's type.
 729         (print_one_breakpoint): If handling "maint info breakpoints", also
 730         print locations of exception catchpoints.
 731         * breakpoint.h (is_exception_catchpoint): Declare.
 732
 733 2019-07-09  Pedro Alves  <palves@redhat.com>
 734
 735         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 736         "addr" field.
 737         (allocate_location_exception_catchpoint): New.
 738         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 739         (initialize_throw_catchpoint_ops): Install
 740         allocate_location_exception_catchpoint as allocate_location
 741         method.
 742         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 743         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 744         bp_loc_other.
 745         (breakpoint_address_is_meaningful): Delete.
 746         (bl_address_is_meaningful): New.
 747         (breakpoint_locations_match): Adjust comment.
 748         (bp_location_from_bp_type): New, factored out of...
 749         (bp_location::bp_location(breakpoint *)): ... this.
 750         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 751         factored out of...
 752         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 753         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 754         breakpoint_address_is_meaningful.
 755         (bp_locations_compare): Adjust comment.
 756         (update_global_location_list): Use bl_address_is_meaningful
 757         instead of breakpoint_address_is_meaningful.
 758         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 759         explicit.
 760         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 761         * python/py-breakpoint.c (bppy_get_location): No longer check
 762         whether location is null.
 763
 764 2019-07-09  Pedro Alves  <palves@redhat.com>
 765
 766         PR c++/15468
 767         * breakpoint.c (print_one_breakpoint_location): Remove
 768         single-location assert.
 769
 770 2019-07-09  Tom Tromey  <tom@tromey.com>
 771
 772         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 773         * configure: Rebuild.
 774         * configure.ac: Change common to gdbsupport.
 775         * gdbsupport: Rename from common.
 776         * acinclude.m4: Change common to gdbsupport.
 777         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 778         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 779         gdbsupport.
 780         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 781         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 782         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 783         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 784         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 785         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 786         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 787         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 788         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 789         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 790         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 791         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 792         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 793         coff-pe-read.c, command.h, compile/compile-c-support.c,
 794         compile/compile-c.h, compile/compile-cplus-symbols.c,
 795         compile/compile-cplus-types.c, compile/compile-cplus.h,
 796         compile/compile-loc2c.c, compile/compile.c, completer.c,
 797         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 798         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 799         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 800         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 801         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 802         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 803         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 804         features/aarch64-core.c, features/aarch64-fpu.c,
 805         features/aarch64-pauth.c, features/aarch64-sve.c,
 806         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 807         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 808         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 809         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 810         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 811         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 812         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 813         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 814         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 815         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 816         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 817         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 818         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 819         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 820         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 821         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 822         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 823         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 824         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 825         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 826         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 827         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 828         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 829         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 830         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 831         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 832         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 833         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 834         minsyms.c, mips-linux-tdep.c, namespace.h,
 835         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 836         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 837         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 838         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 839         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 840         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 841         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 842         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 843         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 844         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 845         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 846         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 847         procfs.c, producer.c, progspace.h, psymtab.h,
 848         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 849         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 850         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 851         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 852         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 853         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 854         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 855         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 856         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 857         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 858         target-memory.c, target.c, target.h, target/waitstatus.c,
 859         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 860         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 861         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 862         unittests/array-view-selftests.c,
 863         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 864         unittests/common-utils-selftests.c,
 865         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 866         unittests/format_pieces-selftests.c,
 867         unittests/function-view-selftests.c,
 868         unittests/lookup_name_info-selftests.c,
 869         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 870         unittests/mkdir-recursive-selftests.c,
 871         unittests/observable-selftests.c,
 872         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 873         unittests/parse-connection-spec-selftests.c,
 874         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 875         unittests/scoped_fd-selftests.c,
 876         unittests/scoped_mmap-selftests.c,
 877         unittests/scoped_restore-selftests.c,
 878         unittests/string_view-selftests.c, unittests/style-selftests.c,
 879         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 880         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 881         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 882         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 883         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 884         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 885
 886 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 887
 888         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 889         bool value.
 890         (decode_digits_ordinary): Set explicit_line field in sal.
 891         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 892         symtab_and_line that was set on an explicit line number in
 893         assembler code.  Do always update the recorded symtab and line if
 894         we do skip the prologue.
 895
 896 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 897
 898         * breakpoint.c (set_breakpoint_location_function): Remove
 899         explicit_loc parameter.
 900         (momentary_breakpoint_from_master): Update call to
 901         set_breakpoint_location_function.
 902         (add_location_to_breakpoint): Likewise.
 903
 904 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 905
 906         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 907         required features based on default bfd type when no specific bfd
 908         is present.
 909
 910 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 911
 912         * NEWS: Mention that GDB printf and eval commands can now print
 913         C-style and Ada-style convenience var strings without
 914         calling the inferior.
 915         * printcmd.c (printf_c_string): Locally print GDB internal var
 916         instead of transiting via the inferior.
 917         (printf_wide_c_string): Likewise.
 918
 919 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 920
 921         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 922
 923 2019-07-04  Tom Tromey  <tom@tromey.com>
 924
 925         PR tui/24724:
 926         * tui/tui-winsource.c (tui_clear_source_content): Update.
 927         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 928         (tui_update_breakpoint_info): Update.
 929         (tui_set_exec_info_content): Update.
 930         * tui/tui-source.c (tui_set_source_content_nil): Update.
 931         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 932         has_break.
 933         * tui/tui-data.h (enum tui_bp_flag): New.
 934         (tui_bp_flags): New enum flags type.
 935         (struct tui_source_element) <break_mode>: Change type.  Rename
 936         from has_break.
 937         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 938         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 939         constants.
 940         * tui/tui-winsource.h: Fix comment.
 941
 942 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 943
 944         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 945         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 946         (store_fpregs_to_thread)
 947         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 948         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 949         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 950         (IWMMXT_REGS_SIZE): Add define.
 951         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 952         (fetch_vfp_regs, store_vfp_regs)
 953         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 954         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 955
 956 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 957
 958         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 959         defines.
 960         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 961         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 962         (ARM_INT_REGISTER_SIZE): ...to this.
 963         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 964         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 965         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 966         (arm_linux_collect_gregset, supply_nwfpe_register)
 967         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 968         defines.
 969         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 970         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 971         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 972         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 973         (arm_return_in_memory, arm_store_return_value)
 974         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 975         (arm_record_ld_st_multiple): Likewise.
 976         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 977         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 978
 979 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 980
 981         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 982         AARCH64_DISPLACED_MODIFIED_INSNS.
 983         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 984         (aarch64_displaced_step_copy_insn): Likewise.
 985         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 986         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 987         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 988         ARM_DISPLACED_MODIFIED_INSNS.
 989         * arm-tdep.c (arm_gdbarch_init): Likewise.
 990         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 991         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 992         (struct arm_displaced_step_closure): Use
 993         ARM_DISPLACED_MODIFIED_INSNS.
 994
 995 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 996
 997         * features/Makefile: Remove unused xml files.
 998         * features/aarch64.xml: Remove.
 999         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1000         * features/i386/amd64-avx-avx512.xml: Remove.
1001         * features/i386/amd64-avx-linux.xml: Remove.
1002         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1003         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1004         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1005         * features/i386/amd64-avx-mpx.xml: Remove.
1006         * features/i386/amd64-avx.xml: Remove.
1007         * features/i386/amd64-linux.xml: Remove.
1008         * features/i386/amd64-mpx-linux.xml: Remove.
1009         * features/i386/amd64-mpx.xml: Remove.
1010         * features/i386/amd64.xml: Remove.
1011         * features/i386/i386-avx-avx512-linux.xml: Remove.
1012         * features/i386/i386-avx-avx512.xml: Remove.
1013         * features/i386/i386-avx-linux.xml: Remove.
1014         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1015         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1016         * features/i386/i386-avx-mpx-linux.xml: Remove.
1017         * features/i386/i386-avx-mpx.xml: Remove.
1018         * features/i386/i386-avx.xml: Remove.
1019         * features/i386/i386-linux.xml: Remove.
1020         * features/i386/i386-mmx-linux.xml: Remove.
1021         * features/i386/i386-mmx.xml: Remove.
1022         * features/i386/i386-mpx-linux.xml: Remove.
1023         * features/i386/i386-mpx.xml: Remove.
1024         * features/i386/i386.xml: Remove.
1025         * features/i386/x32-avx-avx512-linux.xml: Remove.
1026         * features/i386/x32-avx-linux.xml: Remove.
1027         * features/i386/x32-linux.xml: Remove.
1028
1029 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1030
1031         * regformats/aarch64.dat: Remove.
1032         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1033         * regformats/i386/amd64-avx-linux.dat: Remove.
1034         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1035         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1036         * regformats/i386/amd64-linux.dat: Remove.
1037         * regformats/i386/amd64-mpx-linux.dat: Remove.
1038         * regformats/i386/amd64.dat: Remove.
1039         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1040         * regformats/i386/i386-avx-linux.dat: Remove.
1041         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1042         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1043         * regformats/i386/i386-linux.dat: Remove.
1044         * regformats/i386/i386-mmx-linux.dat: Remove.
1045         * regformats/i386/i386-mpx-linux.dat: Remove.
1046         * regformats/i386/i386.dat: Remove.
1047         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1048         * regformats/i386/x32-avx-linux.dat: Remove.
1049         * regformats/i386/x32-linux.dat: Remove.
1050
1051 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1052
1053         * aarch64-tdep.c: Remove xml self tests.
1054         * amd64-linux-tdep.c: Likewise.
1055         * amd64-tdep.c: Likewise.
1056         * i386-linux-tdep.c: Likewise.
1057         * i386-tdep.c: Likewise.
1058
1059 2019-07-03  Pedro Alves  <palves@redhat.com>
1060
1061         PR cli/24732
1062         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1063         (pipe_cmd_option_defs): New.
1064         (make_pipe_cmd_options_def_group): New.
1065         (pipe_command): Use gdb::option::process_options.
1066         (pipe_command_completer): New function.
1067         (_initialize_cli_cmds): Install completer for "pipe" command.
1068
1069 2019-07-03  Pedro Alves  <palves@redhat.com>
1070
1071         * cli/cli-option.c (union option_value) <string>: New field.
1072         (struct option_def_and_value): Add ctor, move ctor, dtor and
1073         use DISABLE_COPY_AND_ASSIGN.
1074         (option_def_and_value::clear_value): New.
1075         (parse_option, save_option_value_in_ctx, get_val_type_str)
1076         (add_setshow_cmds_for_options): Handle var_string.
1077         * cli-option.h (union option_def::var_address) <string>: New
1078         field.
1079         (struct string_option_def): New.
1080         * maint-test-options.c (struct test_options_opts): Add default
1081         ctor and use DISABLE_COPY_AND_ASSIGN.
1082         <string_opt>: New field.
1083         (test_options_opts::~test_options_opts): New.
1084         (test_options_opts::dump): Also dump "-string".
1085         (test_options_option_defs): Install "string.
1086
1087 2019-07-03  Pedro Alves  <palves@redhat.com>
1088
1089         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1090         option_value with a null enumeration.
1091         (complete_options): Save the option values in the context.
1092         (save_option_value_in_ctx): New, factored out from ...
1093         (process_options): ... here.
1094         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1095         of the function.
1096         * maint-test-options.c (test_options_opts::dump): New, factored
1097         out from ...
1098         (maintenance_test_options_command_mode): ... here.
1099         (maintenance_test_options_command_completion_result): Delete.
1100         (maintenance_test_options_command_completion_text): Update
1101         comment.
1102         (maintenance_show_test_options_completion_result): Change
1103         prototype.  Just print
1104         maintenance_test_options_command_completion_text.
1105         (save_completion_result): New.
1106         (maintenance_test_options_completer_mode): Pass options context to
1107         complete_options, and then save a dump.
1108         (_initialize_maint_test_options): Use add_cmd to install "maint
1109         show test-options-completion-result".
1110
1111 2019-07-03  Pedro Alves  <palves@redhat.com>
1112
1113         * NEWS (New commands): Mention "with" and "maint with".
1114         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1115         (with_command, with_command_completer): New.
1116         (pipe_command): Adjust to new repeat_previous
1117         interface.
1118         (_initialize_cli_cmds): Install the "with" command and its "w"
1119         alias.
1120         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1121         declarations.
1122         * cli/cli-setshow.c (parse_cli_var_uinteger)
1123         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1124         argument strings for all var_types.
1125         (get_setshow_command_value_string): New, factored out from ...
1126         (do_show_command): ... this.
1127         * cli/cli-setshow.h: Include <string>.
1128         (get_setshow_command_value_string): Declare.
1129         * command.h (repeat_previous): Now returns const char *.  Adjust
1130         comment.
1131         * maint.c: Include "cli/cli-cmds.h".
1132         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1133         (_initialize_maint_cmds): Register the "maintenance with" command.
1134         * top.c (repeat_previous): Move bits from pipe_command here:
1135         Return the saved command line, if any; error out if there's no
1136         command to relaunch.
1137
1138 2019-07-03  Pedro Alves  <palves@redhat.com>
1139
1140         * NEWS (New commands): Mention "maint set/show test-settings"
1141         instead of "maint test-settings".
1142         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1143         (maintenance_test_settings_set_list): Rename to ...
1144         (maintenance_set_test_settings_list): ... this.
1145         (maintenance_test_settings_show_list): Rename to  ...
1146         (maintenance_show_test_settings_list): ... this.
1147         (maintenance_test_settings_cmd): Delete.
1148         (maintenance_test_settings_set_cmd): ...
1149         (maintenance_set_test_settings_cmd): ... this.
1150         (maintenance_test_settings_show_cmd): ...
1151         (maintenance_show_test_settings_cmd): ... this.
1152         (maintenance_test_settings_show_value_cmd):
1153         (maintenance_show_test_settings_value_cmd): ... this.
1154         (_initialize_maint_test_settings): No longer install the "maint
1155         test-settings" prefix command.  Rename "maint test-settings set"
1156         to "maint set test-settings", and "maint test-settings show" to
1157         "maint show test-settings".  Adjust all subcommands.
1158
1159 2019-07-03  Pedro Alves  <palves@redhat.com>
1160
1161         * maint-test-settings.c: Fix file's intro comment.  Replace all
1162         references to "test-options" with references to "test-settings",
1163         in comments.
1164
1165 2019-07-03  Pedro Alves  <palves@redhat.com>
1166
1167         * maint-test-settings.c (maintenance_test_settings_xxx)
1168         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1169         New.
1170         (maintenance_test_settings_enums): Use them.
1171         (maintenance_test_settings_enum): Default to
1172         maintenance_test_settings_xxx.
1173         (_initialize_maint_test_settings): Initialize
1174         MAINTENANCE_TEST_SETTINGS_FILENAME.
1175
1176 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1177
1178         * breakpoint.h (remove_breakpoints_inf): Change return type to
1179         void, move function documentation here.
1180         * breakpoint.c (remove_breakpoints_inf): Change return type to
1181         void, move function documentation to header.
1182
1183 2019-07-02  Pedro Alves  <palves@redhat.com>
1184
1185         * NEWS (Completion improvements): Mention "info threads".
1186         * thread.c (struct info_threads_opts, info_threads_option_defs)
1187         (make_info_threads_options_def_group): New.
1188         (info_threads_command): Use gdb::option::process_options.
1189         (info_threads_command_completer): New.
1190         (_initialize_thread): Use gdb::option::build_help to build the
1191         help text for "info threads".
1192
1193 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1194
1195         * defs.h (generic_load): Move from here...
1196         * symfile.h (generic_load): ... to here.  Rename name parameter
1197         to args.
1198         * symfile.c (generic_load): Add comment.
1199
1200 2019-07-01  Tom Tromey  <tromey@adacore.com>
1201
1202         * dwarf2read.c
1203         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1204         declaration of without_params.  Fix formatting.
1205
1206 2019-07-01  Tom Tromey  <tromey@adacore.com>
1207
1208         * ada-exp.y (find_primitive_type): Update.
1209         * ada-lang.h (ada_lookup_symbol): Update.
1210         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1211         parameter.
1212         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1213
1214 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1215
1216         PR breakpoints/24541
1217         * gdbarch.c: Regenerate.
1218         * gdbarch.h: Regenerate.
1219         * gdbarch.sh: Add 'stap_adjust_register'.
1220         * i386-tdep.c: Include '<unordered_set>'.
1221         (i386_stap_adjust_register): New function.
1222         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1223         * stap-probe.c (stap_parse_register_operand): Call
1224         'gdbarch_stap_adjust_register'.
1225
1226 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1227
1228         PR python/24742
1229         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1230         * python/python.c (do_start_initialization): Use 'xmalloc'
1231         instead of 'PyMem_Malloc'.
1232
1233 2019-06-28  Tom Tromey  <tromey@adacore.com>
1234
1235         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1236         for Ada.
1237
1238 2019-06-27  Tom Tromey  <tromey@adacore.com>
1239
1240         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1241         objfile_key.
1242         (arm_find_mapping_symbol, arm_record_special_symbol)
1243         (_initialize_arm_tdep): Update.
1244         (arm_objfile_data_free): Remove.
1245
1246 2019-06-27  Tom Tromey  <tromey@adacore.com>
1247
1248         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1249         to cp_print_static_field.
1250
1251 2019-06-26  Tom Tromey  <tromey@adacore.com>
1252
1253         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1254         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1255         declare.
1256
1257 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1258
1259         * features/aarch64-core.c (create_feature_aarch64_core):
1260         Regenerate.
1261         * features/aarch64-core.xml: Add cpsr flags.
1262
1263 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1264
1265         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1266         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1267
1268 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1269
1270         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1271         field.
1272         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1273         use.
1274         (arm_record_special_symbol): Don't insert new symbol in sorted
1275         position, push it at the end.
1276
1277 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1278
1279         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1280         (arm_mapping_symbol_s): Remove.
1281         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1282         (arm_mapping_symbol_vec): New typedef.
1283         (struct arm_per_objfile): Add constructor.
1284         <section_maps>: Change type to
1285         std::unique_ptr<arm_mapping_symbol_vec[]>.
1286         (arm_compare_mapping_symbols): Remove.
1287         (arm_find_mapping_symbol): Adjust to section_maps type change.
1288         (arm_objfile_data_free): Call delete on arm_per_objfile.
1289         (arm_record_special_symbol): Adjust to section_maps type change.
1290         Allocate arm_per_objfile with new.
1291
1292 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1293
1294         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1295         with the command prefix.
1296
1297 2019-06-25  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1300         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1301
1302 2019-06-25  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1305         type.
1306         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1307         protected.
1308
1309 2019-06-25  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-winsource.c
1312         (tui_source_window_base::set_is_exec_point_at): Add check against
1313         LOA_ADDRESS.
1314
1315 2019-06-25  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-source.c (tui_set_source_content): Don't check before
1318         xfree.
1319         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1320
1321 2019-06-25  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-winsource.h (tui_update_source_window_as_is)
1324         (tui_alloc_source_buffer, tui_line_is_displayed)
1325         (tui_addr_is_displayed): Change type of win_info.
1326         * tui/tui-winsource.c (tui_update_source_window_as_is)
1327         (tui_clear_source_content, tui_show_source_line)
1328         (tui_show_source_content, tui_source_window_base::refill)
1329         (tui_source_window_base::set_is_exec_point_at)
1330         (tui_source_window_base::set_is_exec_point_at)
1331         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1332         (tui_alloc_source_buffer, tui_line_is_displayed)
1333         (tui_addr_is_displayed): Change type of win_info.  Update.
1334         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1335         (tui_source_window_base::do_make_visible_with_new_height):
1336         Update.
1337         * tui/tui-source.c (tui_set_source_content)
1338         (tui_set_source_content_nil)
1339         (tui_source_window::do_scroll_vertical): Update.
1340         * tui/tui-layout.c (show_layout): Update.
1341         * tui/tui-disasm.c (tui_set_disassem_content)
1342         (tui_disasm_window::do_scroll_vertical): Update.
1343         * tui/tui-data.h (tui_win_content): Remove.
1344         (struct tui_gen_win_info) <content, content_size>: Remove.
1345         (struct tui_source_element): Add initializers and destructor.
1346         (union tui_which_element, struct tui_win_element): Remove.
1347         (struct tui_source_window_base) <content>: New field.
1348         (struct tui_data_window): Remove destructor.
1349         (tui_alloc_content, tui_free_win_content)
1350         (tui_free_all_source_wins_content): Don't declare.
1351         * tui/tui-data.c (tui_initialize_static_data): Update.
1352         (init_content_element, tui_alloc_content): Remove.
1353         (~tui_gen_win_info): Update.
1354         (~tui_data_window, tui_free_all_source_wins_content)
1355         (tui_free_win_content, free_content, free_content_elements):
1356         Remove.
1357
1358 2019-06-25  Tom Tromey  <tom@tromey.com>
1359
1360         * tui/tui-winsource.h (tui_clear_source_content)
1361         (tui_erase_source_content, tui_show_source_content): Change type
1362         of win_info.
1363         * tui/tui-winsource.c (tui_clear_source_content)
1364         (tui_erase_source_content, tui_show_source_content): Change type
1365         of win_info.
1366         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1367         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1368         win_info.
1369         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1370         win_info.
1371         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1372
1373 2019-06-25  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-winsource.c (tui_clear_source_content)
1376         (tui_source_window_base::set_is_exec_point_at): Update.
1377         * tui/tui-source.c (tui_set_source_content_nil): Update.
1378         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1379         a bool.
1380         * tui/tui-data.c (init_content_element): Update.
1381
1382 2019-06-25  Tom Tromey  <tom@tromey.com>
1383
1384         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1385         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1386         * tui/tui-layout.c (init_and_make_win): Update.
1387         * tui/tui.h (enum tui_win_type): Update.
1388         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1389         tui_win_is_auxillary.
1390         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1391         tui_win_is_auxillary.
1392
1393 2019-06-25  Tom Tromey  <tom@tromey.com>
1394
1395         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1396         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1397         (tui_delete_data_content_windows, tui_display_all_data)
1398         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1399         Update.
1400         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1401         * tui/tui-regs.c (tui_last_regs_line_no)
1402         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1403         (tui_show_registers): Update.
1404         (tui_show_register_group): Return void.  Update.
1405         (tui_display_registers_from, tui_display_reg_element_at_line)
1406         (tui_display_registers_from_line, tui_check_register_values):
1407         Update.
1408         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1409         member.
1410         (struct tui_data_window) <regs_content>: Now a std::vector.
1411         <regs_content_count>: Remove.
1412         (tui_add_content_elements, tui_free_data_content): Don't declare.
1413         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1414         (init_content_element): Remove DATA_WIN case.  Add assert.
1415         (tui_add_content_elements): Remove.
1416         (tui_data_window): Update.
1417         (tui_free_data_content): Remove.
1418         (free_content_elements): Remove DATA_WIN case.
1419
1420 2019-06-25  Tom Tromey  <tom@tromey.com>
1421
1422         * tui/tui-data.c (tui_data_item_window): Update.
1423         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1424         * tui/tui-windata.c (tui_display_all_data)
1425         (tui_display_data_from_line): Update.
1426         (tui_check_data_values): Remove.
1427         * tui/tui-regs.c (tui_show_register_group)
1428         (tui_display_reg_element_at_line): Update.
1429         * tui/tui-hooks.c (tui_register_changed)
1430         (tui_refresh_frame_and_register_information): Call
1431         tui_check_register_values.
1432         * tui/tui-data.h (struct tui_data_window) <data_content,
1433         data_content_count, data_type>: Remove.
1434         (enum tui_data_type): Remove.
1435
1436         * tui/tui-data.c (tui_data_window::clear_detail)
1437         (~tui_data_window): Update.
1438
1439 2019-06-25  Tom Tromey  <tom@tromey.com>
1440
1441         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1442         declare.
1443         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1444         Rename from tui_first_data_item_displayed.  Update.
1445         (tui_data_window::refresh_all)
1446         (tui_data_window::do_scroll_vertical): Update.
1447         * tui/tui-data.h (struct tui_data_window)
1448         <first_data_item_displayed>: Declare new method.
1449
1450 2019-06-25  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1453         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1454         contents...
1455         (tui_initialize_static_data): ...here.
1456
1457 2019-06-25  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1460         (tui_display_registers_from, tui_check_register_values): Update.
1461         (tui_display_register): Remove win_info parameter; update.
1462         (tui_get_register): Change type of parameters.
1463         * tui/tui-data.h (struct tui_data_element): Remove.
1464         (union tui_which_element) <data>: Remove.
1465         <data_window>: Change type.
1466         (struct tui_data_item_window): New.
1467         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1468         case.  Add assert.
1469         (~tui_data_item_window): New destructor.
1470         (free_content_elements): Remove DATA_ITEM_WIN case.
1471
1472 2019-06-25  Tom Tromey  <tom@tromey.com>
1473
1474         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1475         Remove.
1476
1477 2019-06-25  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui-data.h (struct tui_command_element): Remove.
1480         (union tui_which_element) <command>: Remove.
1481         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1482         assert.
1483         (free_content_elements): Remove CMD_WIN case.
1484
1485 2019-06-25  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-layout.c (tui_set_layout): Update.
1488         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1489         * tui/tui-data.c (layout_def): Update.
1490
1491 2019-06-25  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1494         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1495         (tui_source_window_base::set_new_height): Update.
1496         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1497         Update.
1498         (tui_set_locator_fullname, tui_set_locator_info)
1499         (tui_show_frame_info): Update.
1500         * tui/tui-source.c (tui_set_source_content)
1501         (tui_source_is_displayed): Update.
1502         * tui/tui-layout.c (show_source_disasm_command, show_data)
1503         (show_source_or_disasm_and_command): Update.
1504         * tui/tui-disasm.c (tui_set_disassem_content)
1505         (tui_get_begin_asm_address): Update.
1506         * tui/tui-data.h (struct tui_locator_element): Remove.
1507         (union tui_which_element) <locator>: Remove.
1508         (struct tui_locator_window): New.
1509         (tui_locator_win_info_ptr): Change return type.
1510         * tui/tui-data.c (_locator): Change type.
1511         (tui_locator_win_info_ptr): Change return type.
1512         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1513         (tui_alloc_content): Add assert.
1514
1515 2019-06-25  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-winsource.c
1518         (tui_exec_info_window::maybe_allocate_content): New method.
1519         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1520         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1521         (make_source_or_disasm_window): Add cast.
1522         * tui/tui-data.h (union tui_which_element) <simple_string>:
1523         Remove.
1524         (struct tui_source_info): New.
1525         (struct tui_source_window_base) <execution_info>: Change type.
1526         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1527         case, and add assert.
1528         (tui_alloc_content): Add assert.
1529
1530 2019-06-25  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1533         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1534         * tui/tui-data.c (tui_alloc_win_info): Remove.
1535
1536 2019-06-25  Tom Tromey  <tom@tromey.com>
1537
1538         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1539         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1540         can_highlight.
1541
1542 2019-06-25  Tom Tromey  <tom@tromey.com>
1543
1544         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1545         make_visible_with_new_height method.
1546         (tui_win_info::make_visible_with_new_height): New method.
1547         (tui_source_window_base::do_make_visible_with_new_height)
1548         (tui_data_window::do_make_visible_with_new_height)
1549         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1550         (make_visible_with_new_height): Remove.
1551         (tui_resize_all, tui_adjust_win_heights): Use
1552         make_visible_with_new_height method.
1553         * tui/tui-data.h (struct tui_win_info)
1554         <do_make_visible_with_new_height, make_visible_with_new_height>:
1555         New methods.
1556         (struct tui_source_window_base, struct tui_data_window)
1557         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1558         methods.
1559
1560 2019-06-25  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1563         method.
1564         (update_tab_width): Call update_tab_width method.
1565         * tui/tui-data.h (struct tui_win_info)
1566         (struct tui_source_window_base) <update_tab_width>: New methods.
1567
1568 2019-06-25  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1571         parameter.
1572         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1573         parameter.
1574         (tui_gen_win_info::make_visible): Update.
1575         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1576         parameter.
1577         * tui/tui-data.h (enum tui_box): New enum.
1578         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1579
1580 2019-06-25  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1583         init_and_make_win for EXEC_INFO_WIN.
1584         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1585         longer inline.
1586         (struct tui_win_info) <~tui_win_info>: Inline.
1587         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1588         Don't declare.
1589         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1590         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1591         Remove.
1592         (tui_initialize_static_data): Update.
1593         (~tui_gen_win_info): Handle more cleanup here.
1594         (~tui_source_window_base): Delete "execution_info".
1595         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1596
1597 2019-06-25  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-layout.c (make_command_window): Don't set
1600         can_highlight.
1601         (show_source_disasm_command): Call the reset method.
1602         (show_data): Don't set can_highlight.  Call the reset method.
1603         (tui_gen_win_info::reset): Rename from init_gen_win_info
1604         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1605         (show_source_or_disasm_and_command): Call the reset method.
1606         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1607         (struct tui_cmd_window): Set can_highlight.
1608
1609 2019-06-25  Tom Tromey  <tom@tromey.com>
1610
1611         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1612         from make_visible.
1613         (tui_make_visible, tui_make_invisible): Rewrite.
1614         (tui_win_info::make_visible): Remove.
1615         (tui_source_window_base::make_visible): Update.
1616         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1617         method.  Moved from...
1618         (struct tui_win_info) <make_visible>: ...here.
1619
1620 2019-06-25  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-winsource.c
1623         (tui_source_window_base::do_scroll_horizontal): Remove direction
1624         parameter.
1625         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1626         direction parameter.
1627         * tui/tui-win.c (tui_win_info::forward_scroll)
1628         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1629         (tui_win_info::right_scroll): Update.
1630         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1631         direction parameter.
1632         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1633         direction parameter.
1634         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1635         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1636         Remove direction parameter.
1637         (struct tui_source_window_base, struct tui_source_window)
1638         (struct tui_disasm_window, struct tui_data_window)
1639         (struct tui_cmd_window): Update.
1640
1641 2019-06-25  Tom Tromey  <tom@tromey.com>
1642
1643         * tui/tui-winsource.h (tui_set_exec_info_content)
1644         (tui_show_exec_info_content, tui_erase_exec_info_content)
1645         (tui_clear_exec_info_content, tui_update_exec_info): Change
1646         argument to tui_source_window_base.
1647         * tui/tui-winsource.c (tui_set_exec_info_content)
1648         (tui_show_exec_info_content, tui_erase_exec_info_content)
1649         (tui_clear_exec_info_content, tui_update_exec_info): Change
1650         argument to tui_source_window_base.
1651
1652 2019-06-25  Tom Tromey  <tom@tromey.com>
1653
1654         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1655         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1656
1657 2019-06-25  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1660         check.
1661
1662 2019-06-25  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1665         type to void.
1666         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1667         type to void.
1668         * tui/tui-source.c (tui_set_source_content): Update.
1669         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1670
1671 2019-06-25  Tom Tromey  <tom@tromey.com>
1672
1673         * tui/tui-win.c (window_name_completer, tui_set_focus)
1674         (tui_all_windows_info): Use name method.
1675         * tui/tui-data.h (struct tui_gen_win_info)
1676         (struct tui_source_window, struct tui_disasm_window)
1677         (struct tui_data_window, struct tui_cmd_window) <name>: New
1678         method.
1679         (tui_win_name): Don't declare.
1680         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1681         (tui_win_name): Remove.
1682
1683 2019-06-25  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-winsource.h (tui_update_source_window)
1686         (tui_update_source_window_as_is): Change parameter type.
1687         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1688         to be a tui_source_window_base.
1689         (tui_update_source_window_as_is): Likewise.
1690         * tui/tui-win.c (make_visible_with_new_height): Update.
1691
1692 2019-06-25  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-winsource.c (tui_erase_source_content)
1695         (tui_show_source_content, tui_show_exec_info_content)
1696         (tui_erase_exec_info_content): Use refresh_window method.
1697         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1698         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1699         from tui_refresh_win.
1700         (tui_data_window::refresh_window): New method.
1701         (tui_win_info::refresh, tui_source_window_base::refresh)
1702         (tui_refresh_all): Use refresh_window method.
1703         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1704         method.
1705         * tui/tui-regs.c (tui_display_register): Call refresh_window
1706         method.
1707         * tui/tui-layout.c (show_source_disasm_command)
1708         (show_source_or_disasm_and_command): Call refresh_window method.
1709         * tui/tui-data.h (struct tui_gen_win_info)
1710         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1711         New method.
1712
1713 2019-06-25  Tom Tromey  <tom@tromey.com>
1714
1715         * tui/tui.c (tui_rl_other_window, tui_enable)
1716         (tui_is_window_visible, tui_get_command_dimension): Update.
1717         * tui/tui-winsource.c (tui_update_source_window_as_is)
1718         (tui_clear_source_content, tui_erase_source_content)
1719         (tui_show_source_line, tui_source_window_base::refill)
1720         (tui_source_window_base::do_scroll_horizontal)
1721         (tui_source_window_base::set_is_exec_point_at)
1722         (tui_update_breakpoint_info, tui_set_exec_info_content)
1723         (tui_alloc_source_buffer, tui_line_is_displayed)
1724         (tui_addr_is_displayed): Update.
1725         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1726         (tui_check_and_display_highlight_if_needed)
1727         (tui_win_info::make_visible, tui_win_info::refresh)
1728         (tui_refresh_all): Update.
1729         * tui/tui-windata.c (tui_first_data_item_displayed)
1730         (tui_delete_data_content_windows, tui_erase_data_content)
1731         (tui_display_all_data, tui_data_window::refresh_all)
1732         (tui_check_data_values): Update.
1733         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1734         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1735         (tui_win_info::backward_scroll, tui_refresh_all_win)
1736         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1737         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1738         (tui_source_window_base::set_new_height)
1739         (tui_data_window::set_new_height)
1740         (make_invisible_and_set_new_height)
1741         (make_visible_with_new_height, new_height_ok)
1742         (parse_scrolling_args): Update.
1743         * tui/tui-stack.c (tui_show_frame_info): Update.
1744         * tui/tui-source.c (tui_set_source_content)
1745         (tui_set_source_content_nil, tui_source_is_displayed)
1746         (tui_source_window::do_scroll_vertical): Update.
1747         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1748         (tui_display_registers_from, tui_display_reg_element_at_line)
1749         (tui_check_register_values, tui_reg_command): Update.
1750         * tui/tui-layout.c (tui_default_win_height)
1751         (show_source_disasm_command, show_data, init_and_make_win)
1752         (show_source_or_disasm_and_command): Update.
1753         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1754         (tui_redisplay_readline, tui_mld_flush)
1755         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1756         (tui_getc): Update.
1757         * tui/tui-disasm.c (tui_set_disassem_content)
1758         (tui_disasm_window::do_scroll_vertical): Update.
1759         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1760         Now virtual.
1761         (struct tui_win_info): Derive from tui_gen_win_info.
1762         <~tui_win_info>: Mark as override.
1763         <generic>: Remove member.
1764         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1765         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1766         (~tui_data_window, ~tui_win_info)
1767         (tui_free_all_source_wins_content): Update.
1768         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1769
1770 2019-06-25  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-layout.c (init_and_make_win): Use new.
1773         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1774         destructor, initializers.
1775         (tui_alloc_generic_win_info): Don't declare.
1776         * tui/tui-data.c (_locator): Add argument to constructor.
1777         (source_win, disasm_win): New globals.
1778         (exec_info): Remove.
1779         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1780         Update.
1781         (tui_alloc_generic_win_info): Remove.
1782         (init_content_element): Use new.
1783         (tui_win_info::tui_win_info): Update.
1784         (free_content_elements) <case DATA_WIN>: Use delete.
1785
1786 2019-06-25  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1789         * tui/tui-windata.c (tui_first_data_item_displayed)
1790         (tui_delete_data_content_windows): Update.
1791         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1792         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1793         (tui_display_registers_from, tui_check_register_values): Update.
1794         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1795         pointer.
1796         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1797         window.
1798         (tui_free_data_content): Update.
1799         (free_content_elements) <case DATA_WIN>: Free the window.
1800
1801 2019-06-25  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1804         Update.
1805         * tui/tui-layout.c (make_command_window)
1806         (show_source_disasm_command, show_data, init_and_make_win)
1807         (show_source_or_disasm_and_command): Update.
1808         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1809         method.
1810         <can_highight, is_highlighted>: Now bool.
1811         (tui_set_win_highlight): Don't declare.
1812         * tui/tui-data.c (tui_set_win_highlight): Remove.
1813
1814 2019-06-25  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-wingeneral.c (make_visible): Remove check of window
1817         type.
1818
1819 2019-06-25  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-win.c (tui_win_info::max_height)
1822         (tui_cmd_window::max_height): New methods.
1823         (new_height_ok): Call max_height.
1824         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1825         <max_height>: New method.
1826
1827 2019-06-25  Tom Tromey  <tom@tromey.com>
1828
1829         * tui/tui-win.c (tui_source_window_base::set_new_height)
1830         (tui_data_window::set_new_height): New methods.
1831         (make_invisible_and_set_new_height): Call set_new_height method.
1832         * tui/tui-data.h (struct tui_win_info)
1833         (struct tui_source_window_base, struct tui_data_window)
1834         <set_new_height>: New method.
1835
1836 2019-06-25  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1839         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1840         tui_refresh_data_win.
1841         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1842         method.
1843         (tui_refresh_all_win): Call the refresh_all method.
1844         (tui_set_focus): Likewise.
1845         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1846         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1847         Likewise.
1848
1849 2019-06-25  Tom Tromey  <tom@tromey.com>
1850
1851         * tui/tui-winsource.h (tui_refill_source_window)
1852         (tui_set_is_exec_point_at): Don't declare.
1853         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1854         (tui_source_window_base::refill): Rename from
1855         tui_refill_source_window.
1856         (tui_source_window_base::do_scroll_horizontal): Update.
1857         (tui_source_window_base::set_is_exec_point_at): Rename from
1858         tui_set_is_exec_point_at.
1859         (tui_update_all_breakpoint_info): Update.
1860         * tui/tui-stack.c (tui_show_frame_info): Update.
1861         * tui/tui-layout.c (show_data): Add cast.
1862         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1863         * tui/tui-data.h (struct tui_source_window_base) <refill,
1864         set_is_exec_point_at>: New methods.
1865         (tui_source_windows, tui_add_to_source_windows): Update types.
1866         (tui_add_to_source_windows): Remove redundant declaration.
1867         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1868         (tui_source_windows): Change return type.
1869         (tui_clear_source_windows_detail): Update.
1870         (tui_add_to_source_windows): Change type of parameter.
1871         (tui_free_all_source_wins_content): Update.
1872
1873 2019-06-25  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-wingeneral.c (tui_win_info::refresh)
1876         (tui_source_window_base::refresh): New methods.
1877         (tui_refresh_all): Call the refresh method.
1878         * tui/tui-data.h (struct tui_win_info)
1879         (struct tui_source_window_base) <refresh>: New method.
1880
1881 2019-06-25  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui.h (tui_is_window_visible): Return bool.
1884         * tui/tui.c (tui_is_window_visible): Return bool.
1885         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1886         (tui_make_visible, tui_make_invisible)
1887         (tui_win_info::make_visible)
1888         (tui_source_window_base::make_visible, make_all_visible)
1889         (tui_make_all_visible, tui_make_all_invisible): Update.
1890         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1891         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1892         bool.
1893         (struct tui_win_info, struct tui_source_window_base)
1894         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1895         * tui/tui-data.c (tui_init_generic_part): Update.
1896
1897 2019-06-25  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1900         (tui_source_window_base::make_visible): New methods.
1901         (make_all_visible): Make method call.
1902         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1903         (struct tui_source_window_base, struct tui_cmd_window): Override
1904         make_visible.
1905         (tui_win_is_source_type): Don't declare.
1906         * tui/tui-data.c (tui_win_is_source_type): Remove.
1907
1908 2019-06-25  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1911         NULL check.
1912
1913 2019-06-25  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1916         Inline constructor.  Add initializers for members.
1917         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1918         constructors; now inline in class.
1919
1920 2019-06-25  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-regs.c (tui_show_registers): Update.
1923         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1924         bool.
1925         * tui/tui-data.c (tui_data_window::clear_detail)
1926         (tui_data_window): Update.
1927
1928 2019-06-25  Tom Tromey  <tom@tromey.com>
1929
1930         * tui/tui-windata.c (tui_display_all_data)
1931         (tui_display_data_from_line, tui_display_data_from)
1932         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1933         Update.
1934         * tui/tui-regs.c (tui_last_regs_line_no)
1935         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1936         (tui_show_registers, tui_show_register_group)
1937         (tui_display_registers_from, tui_display_reg_element_at_line)
1938         (tui_display_registers_from_line, tui_check_register_values)
1939         (tui_reg_next, tui_reg_prev): Update.
1940         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1941         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1942         tui_data_window.
1943         (struct tui_win_info) <detail>: Remove.  Add new fields from
1944         tui_data_info.
1945         (TUI_DATA_WIN): Add cast.
1946         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1947         (~tui_data_window): Simplify.
1948
1949 2019-06-25  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-layout.c (show_source_disasm_command)
1952         (show_source_or_disasm_and_command): Update.
1953         * tui/tui-io.c (update_cmdwin_start_line)
1954         (tui_redisplay_readline): Update.
1955         * tui/tui-data.h (struct tui_command_info): Remove.
1956         (struct tui_win_info) <detail>: Remove command_info member.
1957         (struct tui_data_window) <start_line>: New member, from
1958         tui_command_info.
1959         (TUI_CMD_WIN): Add casts.
1960
1961 2019-06-25  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-winsource.c (tui_update_source_window)
1964         (tui_refill_source_window)
1965         (tui_source_window_base::do_scroll_horizontal)
1966         (tui_update_breakpoint_info, tui_set_exec_info_content)
1967         (tui_show_exec_info_content, tui_erase_exec_info_content)
1968         (tui_clear_exec_info_content): Update.
1969         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1970         Update.
1971         * tui/tui-win.c (make_invisible_and_set_new_height)
1972         (make_visible_with_new_height): Update.
1973         * tui/tui-source.c (tui_set_source_content)
1974         (tui_show_symtab_source): Update.
1975         * tui/tui-layout.c (extract_display_start_addr)
1976         (show_source_disasm_command, show_data)
1977         (make_source_or_disasm_window)
1978         (show_source_or_disasm_and_command): Update.
1979         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1980         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1981         "gdbarch".
1982         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1983         to tui_source_window_base.
1984         (struct tui_win_info) <detail>: Remove source_info member.
1985         (struct tui_source_window_base) <has_locator>: Inline.
1986         Move contents from tui_source_info; rename has_locator member to
1987         m_has_locator.
1988         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1989         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1990         header file.
1991         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1992         Simplify.
1993         (tui_free_all_source_wins_content): Cast to
1994         tui_source_window_base.
1995
1996 2019-06-25  Tom Tromey  <tom@tromey.com>
1997
1998         * tui/tui-win.c (make_invisible_and_set_new_height)
1999         (make_visible_with_new_height): Call has_locator method.
2000         * tui/tui-layout.c (show_source_disasm_command, show_data)
2001         (show_source_or_disasm_and_command): Update for bool change.
2002         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2003         (tui_win_info) <has_locator>: New method.
2004         (struct tui_source_window_base) <has_locator>: New method.
2005         (tui_win_has_locator): Don't declare.
2006         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2007         from tui_win_has_locator.
2008         (tui_source_window_base): Use false, not FALSE.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2013         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2014         clear_detail method directly.
2015         (tui_clear_win_detail): Remove.
2016
2017 2019-06-25  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2020         "this", not TUI_DISASM_WIN.
2021
2022 2019-06-25  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2025         declare.
2026         * tui/tui-winsource.c
2027         (tui_source_window_base::do_scroll_horizontal): Rename from
2028         tui_horizontal_source_scroll.
2029         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2030         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2031         from tui_vertical_data_scroll.
2032         * tui/tui-win.h (tui_scroll): Don't declare.
2033         * tui/tui-win.c (tui_win_info::forward_scroll)
2034         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2035         (tui_win_info::right_scroll): Rename and update.
2036         (tui_scroll_forward_command, tui_scroll_backward_command)
2037         (tui_scroll_left_command, tui_scroll_right_command): Update.
2038         (tui_scroll): Remove.
2039         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2040         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2041         from tui_vertical_source_scroll.
2042         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2043         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2044         from tui_vertical_disassem_scroll.
2045         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2046         do_scroll_horizontal>: New methods.
2047         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2048         Likewise.
2049         (struct tui_source_window_base): Add do_scroll_horizontal.
2050         (struct tui_source_window, struct tui_disasm_window): Add
2051         do_scroll_vertical.
2052         (struct tui_data_window, struct tui_cmd_window): Add
2053         do_scroll_horizontal and do_scroll_vertical.
2054         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2055
2056 2019-06-25  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui-data.h (struct tui_source_window_base): New struct.
2059         (struct tui_source_window): Derive from tui_source_window_base.
2060         (struct tui_disasm_window): New struct.
2061         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2062         from tui_source_window::clear_detail.
2063         (tui_source_window_base): Rename from tui_source_window.
2064         (~tui_source_window_base): Rename from ~tui_source_window.
2065         (tui_alloc_win_info): Create a tui_disasm_window.
2066
2067 2019-06-25  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-data.h (struct tui_source_window)
2070         (struct tui_data_window): Declare destructors.
2071         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2072         destructors.
2073         (tui_win_info): Simplify.
2074
2075 2019-06-25  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-winsource.c (tui_display_main)
2078         (tui_update_source_windows_with_addr)
2079         (tui_update_all_breakpoint_info): Update.
2080         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2081         (new_height_ok, parse_scrolling_args): Update.
2082         * tui/tui-stack.c (tui_show_frame_info): Update.
2083         * tui/tui-data.h (struct tui_list): Remove.
2084         (tui_source_windows): Return a reference to a std::vector.
2085         * tui/tui-data.c (source_windows): Now a std::vector.
2086         (tui_source_windows): Change return type.
2087         (tui_clear_source_windows): Rewrite.
2088         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2089         (tui_free_all_source_wins_content): Rewrite.
2090
2091 2019-06-25  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2094         (struct tui_data_window, struct tui_cmd_window): Declare
2095         clear_detail method.
2096         * tui/tui-data.c (tui_source_window::clear_detail)
2097         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2098         methods.
2099         (tui_clear_win_detail): Simplify.
2100
2101 2019-06-25  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-layout.c (make_source_window, make_disasm_window)
2104         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2105         Return the new window.
2106         (show_source_disasm_command, show_data)
2107         (show_source_or_disasm_and_command): Update.
2108
2109 2019-06-25  Tom Tromey  <tom@tromey.com>
2110
2111         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2112         parameter.  Return the new window.
2113         (show_source_disasm_command): Update and remove NULL check.
2114         (show_source_or_disasm_and_command): Update.
2115
2116 2019-06-25  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2119
2120 2019-06-25  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-data.h (struct tui_win_info): Make constructor
2123         protected.  Make destructor virtual.  Add initializers.
2124         (tui_source_window, tui_data_window, tui_cmd_window): New
2125         classes.
2126         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2127         constructor.  Add "type" parameter.
2128         (tui_source_window, tui_data_window, tui_cmd_window): New
2129         constructors.
2130         (tui_alloc_win_info): Instantiate the appropriate subclass.
2131
2132 2019-06-25  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-win.c (tui_resize_all): Use delete.
2135         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2136         destructor.
2137         (tui_free_window): Don't declare.
2138         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2139         Update.
2140
2141 2019-06-25  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-data.h (struct tui_win_info): Add constructor.
2144         * tui/tui-data.c (tui_alloc_win_info): Use new.
2145         (tui_free_window): Use delete.
2146
2147 2019-06-22  Tom Tromey  <tom@tromey.com>
2148
2149         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2150         declare.
2151         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2152
2153 2019-06-22  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2156         declare.
2157         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2158
2159 2019-06-22  Tom de Vries  <tdevries@suse.de>
2160
2161         * dwarf2read.c (create_addrmap_from_aranges)
2162         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2163         instead of '%zu'.
2164
2165 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2166
2167         * dwarf2read.h (dwarf2_section_info_def): Remove.
2168         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2169         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2170         std::vector<dwarf2_section_info>.
2171         (struct dwo_file) <~dwo_file>: Remove.
2172         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2173         types field.
2174         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2175         (dwarf2_read_debug_names): Likewise.
2176         (create_debug_types_hash_table): Change parameter type to
2177         array_view, adjust code accordingly.
2178         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2179         (partial_die_info::fixup): Likewise.
2180         (determine_prefix): Likewise.
2181         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2182
2183 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2184
2185         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2186         gdb_bfd_ref_ptr.
2187         <~dwo_file>: Remove call to gdb_bfd_unref.
2188         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2189         gdb_bfd_ref_ptr::get.
2190
2191 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2192
2193         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2194         type to htab_up.
2195         * dwarf2read.c (struct dwo_file): Initialize fields.
2196         <~dwo_file>: New.
2197         (free_dwo_file): Remove, move content to ~dwo_file.
2198         (struct dwo_file_deleter): Remove.
2199         (dwo_file_up>: Remove custom deleter.
2200         (free_dwo_files): Remove.
2201         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2202         dwo_files.
2203         (process_skeletonless_type_units): Call unique_ptr::get.
2204         (allocate_dwo_file_hash_table): Add deleter to created hash
2205         table.  Change return type to htab_up.
2206         (lookup_dwo_file_slot): Don't memset dwo_file, call
2207         unique_ptr::get.
2208         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2209         (create_dwo_unit_in_dwp_v2): Likewise.
2210         (open_and_init_dwo_file): Likewise.
2211         (free_dwo_file_from_slot): Remove.
2212
2213 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2214
2215         * dwarf2read.h (struct dwarf2_section_info) <readin,
2216         is_virtual>: Change type to bool.
2217         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2218         true instead of 1.
2219
2220 2019-06-19  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-data.h (tui_init_content_element): Don't declare.
2223
2224 2019-06-19  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-data.h (tui_init_win_info): Don't declare.
2227
2228 2019-06-19  Tom de Vries  <tdevries@suse.de>
2229
2230         * dwarf2read.h (abstract_to_concrete): Change type to
2231         std::unordered_map<sect_offset, std::vector<sect_offset>,
2232         gdb::hash_enum<sect_offset>>.
2233
2234 2019-06-19  Tom Tromey  <tromey@adacore.com>
2235
2236         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2237         EVAL_AVOID_SIDE_EFFECTS specially.
2238
2239 2019-06-19  Tom Tromey  <tromey@adacore.com>
2240
2241         * source-cache.c (highlighter): New global.
2242         (source_cache::get_source_lines): Create a highlighter on demand.
2243
2244 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2245
2246         * defs.h (deprecated_interactive_hook): Delete declaration.
2247         * interps.c (clear_interpreter_hooks): Remove use of
2248         deprecated_interactive_hook.
2249         * top.c (deprecated_interactive_hook): Delete definition.
2250         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2251
2252 2019-06-18  Tom de Vries  <tdevries@suse.de>
2253
2254         PR gdb/24515
2255         * dwarf2read.h (abstract_to_concrete): Change type from
2256         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2257         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2258         * dwarf2read.c (read_variable): Update.
2259         (dwarf2_fetch_die_loc_sect_off): Update.
2260
2261 2019-06-17  Tom de Vries  <tdevries@suse.de>
2262
2263         PR gdb/24617
2264         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2265         accessing parent[parent_len - 1].
2266
2267 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2268
2269         PR gdb/24364
2270         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2271         call dtrace_process_dof with NULL dof.
2272
2273 2019-06-16  Tom de Vries  <tdevries@suse.de>
2274
2275         PR gdb/24445
2276         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2277
2278 2019-06-16  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2281         (make_all_visible): Use address of member.
2282
2283 2019-06-16  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2286         (tui_free_window, free_content, free_content_elements): Remove
2287         unnecessary cast.
2288         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2289         cast.
2290         * tui/tui-regs.c (tui_show_register_group)
2291         (tui_display_registers_from, tui_display_reg_element_at_line):
2292         Remove unnecessary cast.
2293
2294 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2295
2296         * linux-nat.c (normal_mask): Delete.
2297         (_initialize_linux_nat): Don't initialise normal_mask.
2298
2299 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2300
2301         PR gdb/24445
2302         * dwarf-index-write.h (write_psymtabs_to_index): Add
2303         dwz_basename parameter.
2304         * dwarf-index-write.c (write_gdbindex): Move file writing to
2305         write_gdbindex_1.  Change return type void.
2306         (assert_file_size): Move up, remove filename parameter.
2307         (write_gdbindex_1): New function.
2308         (write_debug_names): Change return type to void, call
2309         assert_file_size.
2310         (struct index_wip_file): New struct.
2311         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2312         file logic to index_wip_file.  Write index for dwz file if
2313         needed.
2314         (save_gdb_index_command): Pass basename of dwz file, if present.
2315         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2316         build-id of dwz file, if present.
2317         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2318         (dwarf2_get_dwz_file): Likewise.
2319         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2320         (dwarf2_get_dwz_file): Likewise.
2321
2322 2019-06-16  Tom Tromey  <tom@tromey.com>
2323
2324         * coffread.c (process_coff_symbol): Use xstrdup.
2325         * value.c (create_internalvar): Use xstrdup.
2326
2327 2019-06-16  Tom Tromey  <tom@tromey.com>
2328
2329         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2330         * breakpoint.c (stopin_command, stopat_command)
2331         (until_break_command, decode_location_default): Remove unnecessary
2332         cast.
2333         * utils.c (subset_compare): Remove unnecessary cast.
2334         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2335         cast.
2336         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2337         cast.
2338         * infcmd.c (path_command): Remove unnecessary cast.
2339         * coffread.c (decode_type): Remove unnecessary cast.
2340         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2341         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2342         * tui/tui-stack.c (tui_show_locator_content)
2343         (tui_show_frame_info): Remove unnecessary cast.
2344         * tui/tui-win.c (tui_scroll_forward_command)
2345         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2346         (parse_scrolling_args): Remove unnecessary cast.
2347         * tui/tui-data.c (init_win_info, tui_del_window)
2348         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2349         (free_content_elements): Remove unnecessary cast.
2350         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2351         unnecessary cast.
2352         * tui/tui-source.c (tui_set_source_content)
2353         (tui_vertical_source_scroll): Remove unnecessary cast.
2354         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2355         cast.
2356         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2357         * tui/tui-regs.c (tui_display_registers_from)
2358         (tui_display_register): Remove unnecessary cast.
2359         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2360         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2361         (make_visible): Remove unnecessary cast.
2362         * tui/tui-winsource.c (tui_erase_source_content)
2363         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2364         unnecessary cast.
2365         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2366         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2367         * stabsread.c (read_type, read_array_type, read_range_type):
2368         Remove unnecessary cast.
2369         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2370         (parse_symbol, parse_type, upgrade_type, parse_external)
2371         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2372         unnecessary cast.
2373         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2374
2375 2019-06-16  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-data.c (tui_alloc_generic_win_info)
2378         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2379         checks.
2380
2381 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2382             Andrew Burgess  <andrew.burgess@embecosm.com>
2383
2384         * f-typeprint.c (f_print_type): Don't return early for not
2385         associated or not allocated types.
2386         (f_type_print_varspec_suffix): Add print_rank parameter and print
2387         ranks of array types in case they dangling.
2388         (f_type_print_base): Add print_rank parameter.
2389
2390 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         * NEWS: Mention new MI commands.
2393         * break-catch-throw.c (enum exception_event_kind): Move to
2394         breakpoint.h.
2395         (print_mention_exception_catchpoint): Output text as a single
2396         message.
2397         (catch_exception_command_1): Rename to...
2398         (catch_exception_event): ...this, make non-static, update header
2399         command, and change some parameter types.
2400         (catch_catch_command): Update for changes to
2401         catch_exception_command_1.
2402         (catch_throw_command): Likewise.
2403         (catch_rethrow_command): Likewise.
2404         * breakpoint.c (enum exception_event_kind): Delete.
2405         * breakpoint.h (enum exception_event_kind): Moved here from
2406         break-catch-throw.c.
2407         (catch_exception_event): Declare.
2408         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2409         (mi_cmd_catch_throw): New function.
2410         (mi_cmd_catch_rethrow): New function.
2411         (mi_cmd_catch_catch): New function.
2412         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2413         'catch-catch' entries.
2414         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2415         (mi_cmd_catch_rethrow): Declare.
2416         (mi_cmd_catch_catch): Declare.
2417
2418 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2419
2420         * annotate.c (annotate_source_line): Change return type to void,
2421         update implementation to match.
2422         * annotate.h (annotate_source_line): Change return type to void,
2423         update header comment.
2424         * stack.c (print_frame_info): Don't change what frame information
2425         is printed based on whether annotations are on or not.
2426
2427 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2428
2429         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2430         (annotate_source): Make static.
2431         (annotate_source_line): Moved from source.c and renamed from
2432         identify_source_line.  Update the return type.
2433         * annotate.h (annotate_source): Delete declaration.
2434         (annotate_source_line): Declaration moved from source.h, and
2435         renamed from identify_source_line.  Return type updated.
2436         * source.c (identify_source_line): Moved to annotate.c and renamed
2437         to annotate_source_line.
2438         (info_line_command): Remove check of annotation_level.
2439         * source.h (identify_source_line): Move declaration to annotate.h
2440         and rename to annotate_source_line.
2441         * stack.c: Add 'annotate.h' include.
2442         (print_frame_info): Remove check of annotation_level before
2443         calling annotate_source_line.
2444
2445 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2446
2447         * source-cache.c (source_cache::get_plain_source_lines): Use
2448         open_source_file_with_line_charpos instead of just
2449         open_source_file, remove call to find_source_lines.
2450         (source_cache::get_source_lines): Likewise.
2451         * source.c (find_source_lines): Make static.
2452         (get_filename_and_charpos): Renamed into...
2453         (open_source_file_with_line_charpos): ..this along with changes to
2454         return a scoped_fd, and some other minor clean ups.
2455         (identify_source_line): Use open_source_file_with_line_charpos.
2456         (search_command_helper): Use open_source_file_with_line_charpos
2457         instead of just open_source_file, remove call to
2458         find_source_lines.
2459         * source.h (open_source_file_with_line_charpos): Declare new
2460         function.
2461         (find_source_lines): Delete declaration.
2462
2463 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2464
2465         * source.c (get_filename_and_charpos): Remove fullname
2466         parameter.
2467         (identify_source_line): Update call to get_filename_and_charpos.
2468
2469 2019-06-14  Tom Tromey  <tromey@adacore.com>
2470
2471         PR gdb/24502:
2472         * ui-style.h (skip_ansi_escape): Update comment.
2473         * ui-file.h (class no_terminal_escape_file): New class.
2474         * ui-file.c (no_terminal_escape_file::write)
2475         (no_terminal_escape_file::puts): New methods.
2476         * cli/cli-logging.c (handle_redirections): Use
2477         no_terminal_escape_file.
2478
2479 2019-06-14  Tom Tromey  <tromey@adacore.com>
2480
2481         * NEWS: Move convenience variable news above Python news.
2482
2483 2019-06-14  Tom Tromey  <tom@tromey.com>
2484
2485         * gnulib: Move directory to top-level.
2486         * configure.ac: Don't configure gnulib.
2487         * configure: Rebuild.
2488         * common/common-defs.h: Use new path to gnulib.
2489         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2490         (GNULIB_H): Remove.
2491         (INCGNU): Look in new gnulib location.
2492         (HFILES_NO_SRCDIR): Remove gnulib files.
2493         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2494         (generated_files): Remove GNULIB_H.
2495         ($(LIBGNU), all-lib): Remove targets.
2496         (distclean): Don't mention GNULIB_BUILDDIR.
2497         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2498
2499 2019-06-14  Tom Tromey  <tromey@adacore.com>
2500
2501         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2502         Warn if symbol file does not provide any symbols.
2503
2504 2019-06-14  Tom Tromey  <tromey@adacore.com>
2505
2506         * source.c (find_and_open_source): Respect basenames_may_differ.
2507
2508 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2509
2510         * annotate.c (annotate_breakpoints_invalid): Make use of
2511         scoped_restore_terminal_state.
2512         (annotate_frames_invalid): Likewise.
2513
2514 2019-06-14  Tom Tromey  <tromey@adacore.com>
2515
2516         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2517         allow assignment to an internalvar.
2518
2519 2019-06-14  Tom Tromey  <tromey@adacore.com>
2520
2521         * ada-lex.l: Allow "_" in attribute names.
2522
2523 2019-06-14  Tom Tromey  <tromey@adacore.com>
2524
2525         PR gdb/24653:
2526         * regcache.c (registers_changed): Don't call alloca.
2527         * top.c (execute_command): Don't call alloca.
2528
2529 2019-06-13  Pedro Alves  <palves@redhat.com>
2530
2531         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2532         'expression'.  When parsing an expression, error out if there's
2533         junk after "unlimited".
2534         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2535         (do_set_command): Adjust calls to is_unlimited_literal.
2536
2537 2019-06-13  Pedro Alves  <palves@redhat.com>
2538
2539         * compile/compile.c (make_compile_options_def_group): Add braces
2540         around array_view initializer.
2541         * thread.c (make_thread_apply_all_options_def_group)
2542         (make_thread_apply_all_options_def_group): Likewise.
2543
2544 2019-06-13  Pedro Alves  <palves@redhat.com>
2545
2546         * NEWS (New commands): Mention "maint test-options
2547         require-delimiter", "maint test-options unknown-is-error", "maint
2548         test-options unknown-is-operand" and "maint show
2549         test-options-completion-result".
2550         (New command options, command completion): New section.
2551         (Completion improvements): New section.
2552         Mention that you can abbreviate "unlimited".
2553
2554 2019-06-13  Pedro Alves  <palves@redhat.com>
2555
2556         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2557         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2558         * unittests/cli-utils-selftests.c (test_parse_flags)
2559         (test_parse_flags_qcs): Delete.
2560         (test_cli_utils): Don't call deleted functions.
2561
2562 2019-06-13  Pedro Alves  <palves@redhat.com>
2563
2564         * thread.c: Include "cli/cli-option.h".
2565         (tp_array_compar_ascending): Global.
2566         (tp_array_compar): Delete function.
2567         (tp_array_compar_ascending, tp_array_compar_descending): New
2568         functions.
2569         (ascending_option_def, qcs_flag_option_def)
2570         (thr_qcs_flags_option_defs)
2571         (make_thread_apply_all_options_def_group)
2572         (make_thread_apply_options_def_group): New.
2573         (thread_apply_all_command): Use gdb::option::process_options.
2574         (thread_apply_command_completer)
2575         (thread_apply_all_command_completer): New.
2576         (thread_apply_command): Use gdb::option::process_options.
2577         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2578         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2579         to generate help text of "thread apply".  Adjust "taas"'s help.
2580         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2581         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2582
2583 2019-06-13  Pedro Alves  <palves@redhat.com>
2584
2585         * thread.c (thread_apply_command): Check for invalid TID with
2586         isdigit instead of !isalpha.
2587
2588 2019-06-13  Pedro Alves  <palves@redhat.com>
2589
2590         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2591         (validate_flags_qcs): New.
2592         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2593         (validate_flags_qcs): Declare.
2594         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2595         (make_frame_apply_options_def_group): New.
2596         (frame_apply_command_count): Process options with
2597         gdb::option::process_options.
2598         (frame_apply_completer): New.
2599         (frame_apply_level_completer, frame_apply_all_completer)
2600         (frame_apply_completer): New.
2601         (_initialize_stack): Update help of "frame apply", "frame apply
2602         level", "frame apply all" and "faas" to mention supported options
2603         and install command completers.
2604         * stack.h (frame_apply_all_completer): Declare.
2605         * thread.c: Include "stack.h".
2606         (tfaas_command): Add "--".
2607         (_initialize_thread): Update help "tfaas" to mention supported
2608         options and install command completer.
2609
2610 2019-06-13  Pedro Alves  <palves@redhat.com>
2611
2612         * completer.c (complete_nested_command_line): New.
2613         (gdb_completion_word_break_characters_throw): Add assertion.
2614         * completer.h (complete_nested_command_line): Declare.
2615
2616 2019-06-13  Pedro Alves  <palves@redhat.com>
2617
2618         * stack.c (parse_backtrace_qualifiers): New.
2619         (backtrace_command): Use it.
2620         (backtrace_command_completer): Complete on qualifiers.
2621
2622 2019-06-13  Pedro Alves  <palves@redhat.com>
2623
2624         * frame.c: Include "cli/cli-option.h.
2625         (user_set_backtrace_options): New.
2626         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2627         Delete.
2628         (get_prev_frame): Adjust.
2629         (boolean_option_def, uinteger_option_def)
2630         (set_backtrace_option_defs): New.
2631         (_initialize_frame): Adjust and use
2632         gdb::option::add_setshow_cmds_for_options to install "set
2633         backtrace past-main" and "set backtrace past-entry".
2634         * frame.h: Include "cli/cli-option.h".
2635         (struct frame_print_options): Forward declare.
2636         (print_frame_arguments_all, print_frame_arguments_scalars)
2637         (print_frame_arguments_none): Declare.
2638         (print_entry_values): Delete declaration.
2639         (struct frame_print_options, user_frame_print_options): New.
2640         (struct set_backtrace_options): New.
2641         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2642         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2643         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2644         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2645         (list_args_or_locals): Add frame_print_options parameter.
2646         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2647         * python/py-framefilter.c (enumerate_args): Pass down
2648         USER_FRAME_PRINT_OPTIONS.
2649         * stack.c: Include "cli/cli-option.h".
2650         (print_frame_arguments_all, print_frame_arguments_scalars)
2651         (print_frame_arguments_none): Declare.
2652         (print_raw_frame_arguments, print_entry_values): Delete.
2653         (user_frame_print_options): New.
2654         (boolean_option_def, enum_option_def, frame_print_option_defs):
2655         New.
2656         (struct backtrace_cmd_options): New.
2657         (bt_flag_option_def): New.
2658         (backtrace_command_option_defs): New.
2659         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2660         (print_frame_arg, read_frame_arg, print_frame_args)
2661         (print_frame_info, print_frame): Add frame_print_options parameter
2662         and use it.
2663         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2664         (backtrace_command_1): Add frame_print_options and
2665         backtrace_cmd_options parameters and use them.
2666         (make_backtrace_options_def_group): New.
2667         (backtrace_command): Process command options with
2668         gdb::option::process_options.
2669         (backtrace_command_completer): New.
2670         (_initialize_stack): Extend "backtrace"'s help to mention
2671         supported options.  Install completer for "backtrace".
2672         Install some settings commands with add_setshow_cmds_for_options.
2673
2674 2019-06-13  Pedro Alves  <palves@redhat.com>
2675
2676         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2677         and that "set/show print raw frame-arguments" are now deprecated.
2678
2679         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2680         command.
2681         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2682         * stack.c (_initialize_stack): Install "set/show print
2683         raw-frame-arguments", and deprecate "set/show print raw
2684         frame-arguments".
2685         * valprint.c (_initialize_valprint): Deprecate "set/show print
2686         raw".
2687
2688 2019-06-13  Pedro Alves  <palves@redhat.com>
2689
2690         * compile/compile.c (struct compile_options): New.
2691         (compile_flag_option_def, compile_command_option_defs)
2692         (make_compile_options_def_group): New.
2693         (compile_file_command): Handle options with
2694         gdb::option::process_options.
2695         (compile_file_command_completer): New function.
2696         (compile_code_command): Handle options with
2697         gdb::option::process_options.
2698         (compile_code_command_completer): New function.
2699         (_initialize_compiler): Install completers for "compile code" and
2700         "compile file".  Mention available options in "compile code" and
2701         "compile code"'s help.
2702         * completer.c (advance_to_completion_word): New, factored out from
2703         ...
2704         (advance_to_expression_complete_word_point): ... this.
2705         (advance_to_filename_complete_word_point): New.
2706         * completer.h (advance_to_filename_complete_word_point): New
2707         declaration.
2708
2709 2019-06-13  Pedro Alves  <palves@redhat.com>
2710
2711         * compile/compile.c: Include "cli/cli-option.h".
2712         (compile_print_value): Scope data pointer is now a
2713         value_print_options pointer; adjust.
2714         (compile_print_command): Process options.  Scope data pointer is
2715         now a value_print_options pointer; adjust.
2716         (_initialize_compile): Update "compile print"'s help to include
2717         supported options.  Install a completer for "compile print".
2718         * cp-valprint.c (show_vtblprint, show_objectprint)
2719         (show_static_field_print): Delete.
2720         (_initialize_cp_valprint): Don't install "set print
2721         static-members", "set print vtbl", "set print object" here.
2722         * printcmd.c: Include "cli/cli-option.h" and
2723         "common/gdb_optional.h".
2724         (print_command_parse_format): Rework to fill in a
2725         value_print_options instead of a format_data.
2726         (print_value): Change parameter type from format_data pointer to
2727         value_print_options reference.  Adjust.
2728         (print_command_1): Process options.  Adjust to pass down a
2729         value_print_options.
2730         (print_command_completer): New.
2731         (_initialize_printcmd): Install print_command_completer as
2732         handle_brkchars completer for the "print" command.  Update
2733         "print"'s help to include supported options.
2734         * valprint.c: Include "cli/cli-option.h".
2735         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2736         here from cp-valprint.c.
2737         (boolean_option_def, uinteger_option_def)
2738         (value_print_option_defs, make_value_print_options_def_group):
2739         New.  Use gdb::option::add_setshow_cmds_for_options to install
2740         "set print elements", "set print null-stop", "set print repeats",
2741         "set print pretty", "set print union", "set print array", "set
2742         print address", "set print symbol", "set print array-indexes".
2743         * valprint.h: Include <string> and "cli/cli-option.h".
2744         (make_value_print_options_def_group): Declare.
2745         (print_value): Change parameter type from format_data pointer to
2746         value_print_options reference.
2747         (print_command_completer): Declare.
2748
2749 2019-06-13  Pedro Alves  <palves@redhat.com>
2750
2751         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2752         (COMMON_SFILES): Add maint-test-settings.c.
2753         * cli/cli-decode.c (boolean_enums): New global, factored out from
2754         ...
2755         (add_setshow_boolean_cmd): ... here.
2756         * cli/cli-decode.h (boolean_enums): Declare.
2757         * cli/cli-option.c: New file.
2758         * cli/cli-option.h: New file.
2759         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2760         factored out from ...
2761         (parse_cli_boolean_value(const char *)): ... this.
2762         (is_unlimited_literal): Change parameter type to pointer to
2763         pointer.  Adjust and advance ARG pointer.
2764         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2765         (parse_cli_var_enum): New, factored out from ...
2766         (do_set_command): ... this.  Adjust.
2767         * cli/cli-setshow.h (parse_cli_boolean_value)
2768         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2769         (parse_cli_var_enum): Declare.
2770         * cli/cli-utils.c: Include "cli/cli-option.h".
2771         (get_ulongest): New.
2772         * cli/cli-utils.h (get_ulongest): Declare.
2773         (check_for_argument): New overloads.
2774         * maint-test-options.c: New file.
2775
2776 2019-06-13  Pedro Alves  <palves@redhat.com>
2777
2778         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2779         parse a range if "-" is at the end of the string.
2780
2781 2019-06-13  Pedro Alves  <palves@redhat.com>
2782
2783         * cli/cli-setshow.c (parse_auto_binary_operation)
2784         (parse_cli_boolean_value): Don't allow "o".
2785
2786 2019-06-13  Pedro Alves  <palves@redhat.com>
2787
2788         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2789         * NEWS: Mention maint test-settings KIND.
2790         * maint-test-settings.c: New file.
2791
2792 2019-06-13  Pedro Alves  <palves@redhat.com>
2793
2794         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2795         completer.
2796         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2797         "set" completers.
2798
2799 2019-06-13  Pedro Alves  <palves@redhat.com>
2800
2801         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2802         after item.
2803
2804 2019-06-13  Pedro Alves  <palves@redhat.com>
2805
2806         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2807
2808 2019-06-13  Pedro Alves <palves@redhat.com>
2809
2810         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2811         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2812         call.
2813         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2814         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2815         calls.
2816         (check_for_argument): Skip spaces after argument.
2817
2818 2019-06-13  Pedro Alves  <palves@redhat.com>
2819
2820         * thread.c (thread_apply_command): Adjust TID parsing.
2821         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2822         detected before end of string.
2823         (tid_is_in_list): Error out if LIST is invalid.
2824
2825 2019-06-13  Pedro Alves  <palves@redhat.com>
2826
2827         * completer.c (complete_line_internal_1): Rewind completion word
2828         point.
2829         (completion_tracker::advance_custom_word_point_by): Change
2830         parameter type to int.
2831         * completer.h (completion_tracker::advance_custom_word_point_by):
2832         Likewise.
2833
2834 2019-06-13  Pedro Alves  <palves@redhat.com>
2835
2836         * completer.c (advance_to_completion_word): Handle delimiters.
2837
2838 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2839
2840         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2841
2842 2019-06-11  Tom Tromey  <tom@tromey.com>
2843
2844         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2845         (xmalloc_failed): Move to alloc.c.
2846         * alloc.c: New file.
2847         * Makefile.in (COMMON_SFILES): Add alloc.c.
2848
2849 2019-06-11  Tom Tromey  <tom@tromey.com>
2850
2851         * nat/linux-waitpid.c: Don't include server.h.
2852         (linux_debug): Remove.
2853         (my_waitpid): Update.
2854
2855 2019-06-11  Tom Tromey  <tromey@adacore.com>
2856
2857         * infcall.c (_initialize_infcall): Remove trailing newline from
2858         help.
2859         * user-regs.c (_initialize_user_regs): Remove trailing newline
2860         from help.
2861         * typeprint.c (_initialize_typeprint): Remove trailing newline
2862         from help.
2863         * reverse.c (_initialize_reverse): Remove trailing newlines from
2864         help.
2865         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2866         from help.
2867         * language.c (add_set_language_command): Remove trailing newline
2868         from help.
2869         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2870         help.
2871         * disasm.c (_initialize_disasm): Remove trailing newline from
2872         help.
2873         * top.c (init_main): Remove trailing newline from help.
2874         * interps.c (_initialize_interpreter): Remove trailing newline
2875         from help.
2876         * btrace.c (_initialize_btrace): Remove trailing newlines from
2877         help.
2878         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2879         from help.
2880         * python/python.c (_initialize_python): Remove trailing newline
2881         from help.
2882         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2883         help.
2884         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2885         from help.  Reformat some text.
2886         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2887         from help.
2888         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2889         newline from help.
2890
2891 2019-06-11  Tom Tromey  <tromey@adacore.com>
2892
2893         * darwin-nat.c (darwin_decode_exception_message)
2894         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2895
2896 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2897
2898         * valops.c (value_slice): Check for not allocated or not
2899         associated values.
2900
2901 2019-06-10  Tom de Vries  <tdevries@suse.de>
2902
2903         PR gdb/24618
2904         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2905         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2906         invalid.
2907
2908 2019-06-10  Tom de Vries  <tdevries@suse.de>
2909
2910         PR gdb/24611
2911         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2912         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2913
2914 2019-06-10  Tom de Vries  <tdevries@suse.de>
2915
2916         PR symtab/24545
2917         * symtab.c (struct demangled_name_entry): Add language field.
2918         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2919         static minimal symbol".  Set and use language field.
2920
2921 2019-06-10  Tom Tromey  <tromey@adacore.com>
2922
2923         * ada-lang.c (_initialize_ada_language): Update help text.
2924
2925 2019-06-10  Tom Tromey  <tromey@adacore.com>
2926
2927         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2928         with a newline.
2929         * guile/guile.c (handle_boot_error): Don't end warning with a
2930         newline.
2931         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2932         warning with a newline.
2933         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2934         newline.
2935         (s12z_frame_cache): Likewise.
2936         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2937         a newline.
2938         * solib-svr4.c (disable_probes_interface): Don't end warning with
2939         a newline.
2940         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2941         newline.
2942         * python/python.c (do_finish_initialization): Don't end warning
2943         with a newline.
2944
2945 2019-06-10  Tom Tromey  <tom@tromey.com>
2946
2947         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2948         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2949         gdbpy_enter.
2950
2951 2019-06-10  Tom Tromey  <tromey@adacore.com>
2952
2953         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2954         data.
2955         (elf_new_init): Don't call stabsread_new_init.
2956         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2957         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2958         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2959
2960 2019-06-10  Tom de Vries  <tdevries@suse.de>
2961
2962         PR symtab/16264
2963         PR symtab/24517
2964         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2965
2966 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2967
2968         * source.c (find_and_open_source): Also rewrite relative file
2969         names.
2970
2971 2019-04-26  Amos Bird  <amosbird@gmail.com>
2972
2973         * annotate.c (annotate_thread_exited): Add "thread-exited"
2974         annotation.
2975
2976 2019-06-06  Tom Tromey  <tromey@adacore.com>
2977
2978         * maint.h (class scoped_command_stats): Use
2979         DISABLE_COPY_AND_ASSIGN.
2980         <print_time>: New method.
2981         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2982         print_time.
2983         (scoped_command_stats::print_time): New method.
2984
2985 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2986
2987         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2988         instructions of lengths 6 or 8 bytes.
2989
2990 2019-06-04  Pedro Alves  <palves@redhat.com>
2991
2992         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2993
2994         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2995         * breakpoint.c (condition_completer): Likewise.
2996         * cli/cli-dump.c (scan_expression): Likewise.
2997         * common/filestuff.c (mkdir_recursive): Likewise.
2998         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2999         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3000         (gdb_abspath): Likewise.
3001         * compile/compile-cplus-types.c
3002         (compile_cplus_instance::decl_name): Likewise.
3003         * completer.c (complete_explicit_location):
3004         (signal_completer, reg_or_group_completer_1): Likewise.
3005         * cp-support.c (cp_remove_params_if_any): Likewise.
3006         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3007         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3008         * infcmd.c (strip_bg_char): Likewise.
3009         * linespec.c (copy_token_string): Likewise.
3010         * mi/mi-main.c (output_cores): Likewise.
3011         * psymtab.c (psymtab_search_name):
3012         * symfile.c (test_set_ext_lang_command): Likewise.
3013         * target.c (target_fileio_read_stralloc): Likewise.
3014         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3015         * value.c (complete_internalvar): Likewise.
3016
3017 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3018
3019         Add objfile property to gdb.Type.
3020         * NEWS: Mention Python API addition.
3021         * python/py-type.c (typy_get_objfile): New method.
3022
3023 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3024
3025         * NEWS: Mention the new set|show style [title|highlight].
3026         Mention changes to "show style", "help" and "apropos".
3027
3028 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3029
3030         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3031         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3032         instead of print_help_for_command.
3033         (print_doc_of_command): New function.
3034         (help_list): Add 'apropos -v word' suggestion.
3035         (print_help_for_command): Style the command name using title style.
3036         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3037         (_initialize_cli_cmds): Describe -v in apropos_command help.
3038
3039 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3040
3041         * cli/cli-style.h (cli_style_option): Add name in constructor,
3042         add m_name class member, add constructor with intensity,
3043         add name class function.
3044         (cli_style_option::add_setshow_commands): Remove name argument.
3045         (highlight_style, title_style): New styles.
3046         * cli/cli-style.c (do_show): New function that shows a style
3047         characteristic styling the style name with itself.
3048         (set_style_name): New function.
3049         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3050         Update all callers according to the changes in cli/cli-style.h.
3051         * utils.h (fputs_highlighted): New function.
3052         * utils.c (fputs_highlighted): Likewise.
3053
3054 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3055
3056         * NEWS: Mention new pipe command and new convenience variables.
3057
3058 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3059
3060         * cli/cli-cmds.c (pipe_command): New function.
3061         (_initialize_cli_cmds): Call add_com for pipe_command.
3062         Define | as an alias for pipe.
3063         (exit_status_set_internal_vars): New function.
3064         (shell_escape): Call exit_status_set_internal_vars.
3065         cli/cli-decode.c (find_command_name_length): Recognize | as
3066         a single character command.
3067
3068 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3069
3070         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3071         top.c (execute_command_to_ui_file): New function, mostly a copy
3072         of execute_command_to_string.
3073         (execute_command_to_string): Implement by calling
3074         execute_command_to_ui_file.
3075
3076 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3077
3078         * top.h (saved_command_line): Remove declaration.
3079         * top.c (previous_saved_command_line, previous_repeat_arguments):
3080         New variables.
3081         (saved_command_line): Make static, define together with other
3082         'repeat variables'.
3083         (dont_repeat): Clear repeat_arguments.
3084         (repeat_previous, get_saved_command_line, save_command_line):
3085         New functions.
3086         (gdb_init): Initialize saved_command_line
3087         and previous_saved_command_line.
3088         * main.c (captured_main_1): Remove saved_command_line initialization.
3089         * event-top.c (handle_line_of_input): Update to use
3090         the new 'repeat' related functions instead of direct access to
3091         saved_command_line.
3092         * command.h (repeat_previous, get_saved_command_line,
3093         save_command_line): New declarations.
3094         (dont_repeat): Add comment.
3095
3096 2019-05-30  Tom Tromey  <tromey@adacore.com>
3097
3098         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3099         Fix comment.
3100         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3101
3102 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3103
3104         PR cli/24587
3105         * completer.c (complete): Initialize variable word.
3106
3107 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3108
3109         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3110         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3111         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3112         'body' is NULL to the outter 'if', protecting the '!is_define'
3113         situation as well.
3114
3115 2019-05-29  Tom Tromey  <tromey@adacore.com>
3116
3117         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3118         (dwarf_unknown): New function.
3119         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3120         (dwarf_type_encoding_name): Use dwarf_unknown.
3121
3122 2019-05-29  Tom Tromey  <tromey@adacore.com>
3123
3124         PR c++/20020:
3125         * cp-valprint.c (cp_print_value_fields): Call
3126         cp_print_static_field inside "try".
3127
3128 2019-05-29  Tom Tromey  <tromey@adacore.com>
3129
3130         * inflow.c (struct terminal_info): Add default operator=.
3131         * configure: Rebuild.
3132         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3133         -Wdeprecated-copy-dtor, -Wredundant-move.
3134
3135 2019-05-29  Tom Tromey  <tromey@adacore.com>
3136
3137         * NEWS: Add entry.
3138         * infcmd.c (print_return_value_1): Handle finish_print
3139         option.
3140         (show_print_finish): New function.
3141         (_initialize_infcmd): Add "set/show print finish" commands.
3142         * valprint.c (user_print_options): Initialize new member.
3143         * valprint.h (struct value_print_options) <finish_print>: New
3144         member.
3145
3146 2019-05-28  Tom Tromey  <tromey@adacore.com>
3147
3148         * ada-lang.c (ada_remove_Xbn_suffix)
3149         (find_old_style_renaming_symbol)
3150         (parse_old_style_renaming): Remove.
3151         (ada_find_renaming_symbol): Don't call
3152         find_old_style_renaming_symbol.
3153         (ada_is_renaming_symbol): Rename from
3154         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3155         bool.  Now static.
3156         (ada_read_var_value): Update and simplify.
3157         * ada-exp.y (write_var_or_type): Remove old code.
3158
3159 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3160
3161         * event-top.c: Remove include comment.
3162         * inflow.c (class scoped_ignore_sigttou): Move from here...
3163         * inflow.h (class scoped_ignore_sigttou): ...to here.
3164         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3165         * top.c:  Remove include comment.
3166
3167 2019-05-27  Tom Tromey  <tom@tromey.com>
3168
3169         * NEWS: Fix typo.
3170
3171 2019-05-22  Tom Tromey  <tromey@adacore.com>
3172
3173         * target.c (target_follow_exec): Constify parameter.
3174         * target-delegates.c: Rebuild.
3175         * remote.c (remote_target::follow_exec): Constify parameter.
3176         * infrun.c (follow_exec): Constify parameter.
3177         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3178         (target_follow_exec): Likewise.
3179
3180 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3181
3182         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3183         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3184
3185 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3186
3187         * NEWS: Add debugredirect and testsuite sections.
3188
3189 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3190
3191         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3192         target descriptions using exclusively floating point register name
3193         aliases.
3194
3195 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3196
3197         PR gdb/18644:
3198         * f-lang.c (build_fortran_types): Handle the case where
3199         gdbarch_floatformat_for_type returns a nullptr.
3200
3201 2019-05-21  Tom de Vries  <tdevries@suse.de>
3202
3203         PR cli/24587
3204         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3205
3206 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3207
3208         PR gdb/18644:
3209         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3210         16-byte floats.
3211         * i386-tdep.c (i386_floatformat_for_type): Use
3212         floatformats_ia64_quad for the 16-byte floating point component
3213         within a fortran 32-byte complex number.
3214
3215 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3216
3217         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3218         delete default constructor.
3219         (find_partial_die): Update to return const struct.
3220         (partial_die_parent_scope): Move variable declaration into scope
3221         of its use and change its type to auto.
3222         (guess_partial_die_structure_name): Likewise.
3223         (partial_die_info::fixup): Likewise.
3224
3225 2019-05-17  Tom Tromey  <tromey@adacore.com>
3226
3227         * source.c (find_and_open_source): Remove cast.
3228
3229 2019-05-17  Tom Tromey  <tromey@adacore.com>
3230
3231         * annotate.c (annotate_source): Make "filename" const.
3232         * annotate.h (annotate_source): Use const.
3233
3234 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3235
3236         * disasm.c (set_disassembler_options): Send errors to stderr.
3237
3238 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3239
3240         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3241         (cli_interp_base::set_logging): Check debug_redirect.
3242         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3243         * cli/cli-logging.c (debug_redirect): Add static variable.
3244         (pop_output_files): Add default param.
3245         (handle_redirections): Print debug setting.
3246         (show_logging_command): Likewise.
3247         (_initialize_cli_logging): Add debugredirect command.
3248         * interps.c (current_interp_set_logging): Add debug_redirect
3249         parameter.
3250         * interps.h (set_logging): Add debug_redirect parameter.
3251         (current_interp_set_logging): Likewise.
3252         * mi/mi-common.h: Likewise.
3253         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3254
3255 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3256             Tom Tromey  <tromey@adacore.com>
3257
3258         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3259         directly.
3260         * cli/cli-interp.h (make_logging_output): Remove declaration.
3261         * cli/cli-logging.c (make_logging_output): Remove function.
3262         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3263         directly.
3264         * ui-file.c (tee_file::tee_file): Remove bools.
3265         (tee_file::~tee_file): Remove deletes.
3266         * ui-file.h (tee_file): Remove bools.
3267
3268 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3269
3270         * mi/mi-cmds.h (mi_cmd_complete): New function.
3271         * mi/mi-main.c (mi_cmd_complete): Likewise.
3272         * mi/mi-cmds.c: Define new MI command -complete.
3273         * NEWS: Mention new -complete command.
3274
3275 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3276
3277         * completer.h (complete): New function.
3278         * completer.c (complete): Likewise.
3279         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3280         function defined in completer.h.
3281
3282 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3283
3284         * MAINTAINERS (Write After Approval): Add myself.
3285
3286 2019-05-17  Tom de Vries  <tdevries@suse.de>
3287
3288         PR gdb/24094
3289         * dwarf2read.c (struct cu_partial_die_info): New struct.
3290         (find_partial_die): Return cu_partial_die_info.
3291         (partial_die_parent_scope, guess_partial_die_structure_name)
3292         (partial_die_info::fixup): Handle new return type of find_partial_die.
3293
3294 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3295
3296         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3297         "std::string", simplifying the algorithm.
3298
3299 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3300
3301         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3302         (stap_static_probe_ops::get_probes): Likewise.
3303
3304 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3305
3306         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3307         '-')" and "else if".
3308         (stap_parse_single_operand): Join checks for
3309         "gdbarch_stap_parse_special_token_p" and
3310         "gdbarch_stap_parse_special_token" in the same "if" statement.
3311         Invert check when verifying for operation on register
3312         displacement.
3313
3314 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3315
3316         * stap-probe.c (stap_get_opcode): Update comment.
3317         (stap_get_expected_argument_type): Likewise.
3318         (handle_stap_probe): Likewise.
3319
3320 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3321
3322         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3323         return type to 'bool'.  Adjust comment.  Use 'bool' when
3324         appropriate.
3325         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3326         * stap-probe.c (stap_parse_argument_1): Likewise.
3327         (stap_is_operator): Likewise.
3328         (stap_is_generic_prefix): Likewise.
3329         (stap_is_register_prefix): Likewise.
3330         (stap_is_register_indirection_prefix): Likewise.
3331         (stap_is_integer_prefix): Likewise.
3332         (stap_generic_check_suffix): Likewise.
3333         (stap_check_integer_suffix): Likewise.
3334         (stap_check_register_suffix): Likewise.
3335         (stap_check_register_indirection_suffix): Likewise.
3336         (stap_parse_register_operand): Likewise.
3337         (stap_parse_single_operand): Likewise.
3338         (stap_parse_argument_1): Likewise.
3339         (stap_probe::get_argument_count): Likewise.
3340         (stap_is_operator): Likewise.
3341
3342 2019-05-16  Tom Tromey  <tromey@adacore.com>
3343
3344         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3345         keyword to foreach.
3346
3347 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3348
3349         * linux-thread-db.c (try_thread_db_load_1): Change return type
3350         to bool.
3351         (try_thread_db_load): Likewise.
3352         (try_thread_db_load_from_pdir_1): Likewise.
3353         (try_thread_db_load_from_pdir): Likewise.
3354         (try_thread_db_load_from_sdir): Likewise.
3355         (try_thread_db_load_from_dir): Likewise.
3356         (thread_db_load_search): Likewise.
3357         (has_libpthread): Likewise.
3358         (thread_db_load): Likewise.
3359
3360 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3361
3362         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3363         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3364         NULL, and complain/return if that's the case.
3365
3366 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3367
3368         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3369         (advance, posn, abstract_read_memory): New functions.
3370         [struct mem_read_abstraction]: New struct.
3371         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3372
3373 2019-05-14  Tom Tromey  <tromey@adacore.com>
3374
3375         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3376         value is not lval_memory.
3377
3378 2019-05-14  Tom Tromey  <tromey@adacore.com>
3379
3380         * solib.c (info_sharedlibrary_command): Style the file name.
3381
3382 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3383
3384         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3385         (aarch64_vnv_type): Likewise.
3386         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3387         * common/tdesc.c: Likewise.
3388         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3389         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3390         * features/aarch64-fpu.xml: Add ieee half view.
3391         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3392         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3393         * gdbtypes.h (struct builtin_type): Likewise.
3394         (struct objfile_type): Likewise.
3395
3396 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3397
3398         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3399         typo.
3400         * location.h (string_to_event_location): Likewise.
3401
3402 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3403
3404         GDB 8.3 released.
3405
3406 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3407
3408         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3409         New variable declaration.
3410         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3411         New variable.
3412         (print_one_breakpoint): Use ui_out::test_flags and new global
3413         variable to compute use_fixed_output.
3414         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3415         Remove.
3416         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3417         (mi_multi_location_breakpoint_output_fixed): Remove.
3418         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3419         new variable.
3420         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3421         fix_multi_location_breakpoint_output flag if version >= 3.
3422         * ui-out.h (enum ui_out_flag)
3423         <fix_multi_location_breakpoint_output>: New enumerator.
3424
3425 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3426
3427         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3428
3429 2019-05-10  Tom Tromey  <tromey@adacore.com>
3430
3431         * ada-lang.c (catch_ada_completer): New function.
3432         (_initialize_ada_language): Use it.
3433
3434 2019-05-10  Tom Tromey  <tromey@adacore.com>
3435
3436         * thread.c (print_thread_info): Make "requested_threads" const.
3437         * gdbthread.h (print_thread_info): Make "requested_threads"
3438         const.
3439         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3440         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3441
3442 2019-05-08  Tom Tromey  <tom@tromey.com>
3443
3444         * gdbtypes.c (objfile_type_data): Change type.
3445         (objfile_type, _initialize_gdbtypes): Update.
3446
3447 2019-05-08  Tom Tromey  <tom@tromey.com>
3448
3449         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3450         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3451         (_initialize_dwarf2_frame): Update.
3452
3453 2019-05-08  Tom Tromey  <tom@tromey.com>
3454
3455         * objc-lang.c (objc_objfile_data): Change type.
3456         (find_methods): Update.
3457         (_initialize_objc_lang): Remove.
3458
3459 2019-05-08  Tom Tromey  <tom@tromey.com>
3460
3461         * stabsread.c (rs6000_builtin_type_data): Change type.
3462         (rs6000_builtin_type, _initialize_stabsread): Update.
3463
3464 2019-05-08  Tom Tromey  <tom@tromey.com>
3465
3466         * mips-tdep.c (mips_pdr_data): Remove.
3467         (_initialize_mips_tdep): Update.
3468
3469 2019-05-08  Tom Tromey  <tom@tromey.com>
3470
3471         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3472         (hppa_init_objfile_priv_data, read_unwind_info)
3473         (find_unwind_entry, _initialize_hppa_tdep): Update.
3474
3475 2019-05-08  Tom Tromey  <tom@tromey.com>
3476
3477         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3478         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3479         on obstack.
3480         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3481
3482 2019-05-08  Tom Tromey  <tom@tromey.com>
3483
3484         * mdebugread.c (basic_type_data): Change type.
3485         (basic_type, _initialize_mdebugread): Update.
3486
3487 2019-05-08  Tom Tromey  <tom@tromey.com>
3488
3489         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3490
3491 2019-05-08  Tom Tromey  <tom@tromey.com>
3492
3493         * nto-tdep.c (nto_inferior_data_reg): Change type.
3494         (nto_inferior_data): Update.
3495         (nto_inferior_data_cleanup, nto_new_inferior_data)
3496         (_initialize_nto_tdep): Remove.
3497         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3498
3499 2019-05-08  Tom Tromey  <tom@tromey.com>
3500
3501         * ada-lang.c (struct ada_inferior_data): Add initializers.
3502         (ada_inferior_data): Change type.
3503         (ada_inferior_data_cleanup): Remove.
3504         (get_ada_inferior_data, ada_inferior_exit)
3505         (struct ada_pspace_data): Add initializers, destructor.
3506         (ada_pspace_data_handle): Change type.
3507         (get_ada_pspace_data): Update.
3508         (ada_pspace_data_cleanup): Remove.
3509
3510 2019-05-08  Tom Tromey  <tom@tromey.com>
3511
3512         * coffread.c (struct coff_symfile_info): Add initializers.
3513         (coff_objfile_data_key): Move lower.  Change type.
3514         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3515         Update.
3516         (coff_free_info): Remove.
3517
3518 2019-05-08  Tom Tromey  <tom@tromey.com>
3519
3520         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3521         (fbsd_pspace_data_handle): Move lower.  Change type.
3522         (get_fbsd_pspace_data): Update.
3523         (fbsd_pspace_data_cleanup): Remove.
3524         (_initialize_fbsd_tdep): Update.
3525
3526 2019-05-08  Tom Tromey  <tom@tromey.com>
3527
3528         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3529         (get_ada_tasks_pspace_data): Update.
3530         (ada_tasks_pspace_data_cleanup): Remove.
3531         (_initialize_tasks): Update.
3532         (ada_tasks_inferior_data_handle): Change type.
3533         (get_ada_tasks_inferior_data): Update.
3534         (ada_tasks_inferior_data_cleanup): Remove.
3535         (struct ada_tasks_pspace_data): Add initializers.
3536
3537 2019-05-08  Tom Tromey  <tom@tromey.com>
3538
3539         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3540         * symfile-debug.c (debug_sym_get_probes): Change type.
3541         * stap-probe.c (handle_stap_probe):
3542         (stap_static_probe_ops::get_probes): Change type.
3543         * probe.h (class static_probe_ops) <get_probes>: Change type.
3544         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3545         (parse_probes_in_pspace): Update.
3546         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3547         Update.
3548         (any_static_probe_ops::get_probes): Change type.
3549         * elfread.c (elfread_data): New typedef.
3550         (probe_key): Change type.
3551         (elf_get_probes): Likewise.  Update.
3552         (probe_key_free): Remove.
3553         (_initialize_elfread): Update.
3554         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3555         Change type.
3556         (dtrace_process_dof_probe, dtrace_process_dof)
3557         (dtrace_static_probe_ops::get_probe): Change type.
3558
3559 2019-05-08  Tom Tromey  <tom@tromey.com>
3560
3561         * xcoffread.c (struct xcoff_symfile_info): Rename from
3562         coff_symfile_info.  Add initializers.
3563         (xcoff_objfile_data_key): Move lower.  Change type.
3564         (XCOFF_DATA): Rewrite.
3565         (xcoff_free_info): Remove.
3566         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3567         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3568         (xcoff_initial_scan): Update.
3569
3570 2019-05-08  Tom Tromey  <tom@tromey.com>
3571
3572         * solib-svr4.c (struct svr4_info): Add initializers and
3573         destructor.
3574         <probes_table>: Now an htab_up.
3575         (solib_svr4_pspace_data): Change type.
3576         (free_probes_table): Simplify.
3577         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3578         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3579         (probes_table_remove_objfile_probes, register_solib_event_probe)
3580         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3581         (_initialize_svr4_solib): Update.
3582
3583 2019-05-08  Tom Tromey  <tom@tromey.com>
3584
3585         * remote.c (remote_pspace_data): Change type.
3586         (remote_pspace_data_cleanup): Remove.
3587         (get_remote_exec_file, set_pspace_remote_exec_file)
3588         (_initialize_remote): Update.
3589
3590 2019-05-08  Tom Tromey  <tom@tromey.com>
3591
3592         * breakpoint.c (breakpoint_objfile_key): Change type.
3593         (get_breakpoint_objfile_data): Update.
3594         (free_breakpoint_objfile_data): Remove.
3595         (_initialize_breakpoint): Update.
3596
3597 2019-05-08  Tom Tromey  <tom@tromey.com>
3598
3599         * linux-tdep.c (struct linux_info): Add initializers.
3600         (linux_inferior_data): Move.  Change type.
3601         (invalidate_linux_cache_inf): Update.
3602         (linux_inferior_data_cleanup): Remove.
3603         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3604
3605 2019-05-08  Tom Tromey  <tom@tromey.com>
3606
3607         * auxv.c (auxv_inferior_data): Move.  Change type.
3608         (auxv_inferior_data_cleanup): Remove.
3609         (invalidate_auxv_cache_inf): Rewrite.
3610         (get_auxv_inferior_data, _initialize_auxv): Update.
3611
3612 2019-05-08  Tom Tromey  <tom@tromey.com>
3613
3614         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3615         (symfile_debug_objfile_data_key): Change type.
3616         (symfile_debug_installed, debug_qf_has_symbols)
3617         (debug_qf_find_last_source_symtab)
3618         (debug_qf_forget_cached_source_info)
3619         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3620         (debug_qf_print_stats, debug_qf_dump)
3621         (debug_qf_expand_symtabs_for_function)
3622         (debug_qf_expand_all_symtabs)
3623         (debug_qf_expand_symtabs_with_fullname)
3624         (debug_qf_map_matching_symbols)
3625         (debug_qf_expand_symtabs_matching)
3626         (debug_qf_find_pc_sect_compunit_symtab)
3627         (debug_qf_map_symbol_filenames)
3628         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3629         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3630         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3631         (debug_sym_read_linetable, debug_sym_relocate): Update.
3632         (symfile_debug_free_objfile): Remove.
3633         (install_symfile_debug_logging, _initialize_symfile_debug):
3634         Update.
3635
3636 2019-05-08  Tom Tromey  <tom@tromey.com>
3637
3638         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3639         allocate_on_obstack.
3640         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3641         (get_dwarf2_per_objfile): Update.
3642         (set_dwarf2_per_objfile): Remove.
3643         (dwarf2_has_info, dwarf2_get_section_info): Update.
3644         (dwarf2_free_objfile): Remove.
3645         (_initialize_dwarf2_read): Update.
3646
3647 2019-05-08  Tom Tromey  <tom@tromey.com>
3648
3649         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3650         initializers.
3651         <unsupported_script_warning_printed,
3652         script_not_found_warning_printed>: Now bool.
3653         (auto_load_pspace_data): Change type.
3654         (~auto_load_pspace_info): Rename from
3655         auto_load_pspace_data_cleanup.
3656         (get_auto_load_pspace_data, init_loaded_scripts_info)
3657         (clear_section_scripts, maybe_print_unsupported_script_warning)
3658         (maybe_print_script_not_found_warning, _initialize_auto_load):
3659         Update.
3660
3661 2019-05-08  Tom Tromey  <tom@tromey.com>
3662
3663         * objfiles.c (objfile_pspace_info): Add destructor and
3664         initializers.
3665         (objfiles_pspace_data): Change type.
3666         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3667         (get_objfile_pspace_data): Update.
3668         (objfiles_bfd_data): Change type.
3669         (get_objfile_bfd_data): Update.
3670         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3671
3672 2019-05-08  Tom Tromey  <tom@tromey.com>
3673
3674         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3675         Change type.
3676         (get_catch_syscall_inferior_data): Update.
3677         (catch_syscall_inferior_data_cleanup): Remove.
3678         (_initialize_break_catch_syscall): Update.
3679
3680 2019-05-08  Tom Tromey  <tom@tromey.com>
3681
3682         * inflow.c (struct terminal_info): Add destructor and
3683         initializers.
3684         (inflow_inferior_data): Change type.
3685         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3686         (get_inflow_inferior_data, inflow_inferior_exit)
3687         (swap_terminal_info, _initialize_inflow): Update.
3688
3689 2019-05-08  Tom Tromey  <tom@tromey.com>
3690
3691         * target-dcache.c (target_dcache_cleanup): Remove.
3692         (target_dcache_aspace_key): Change type.
3693         (target_dcache_init_p, target_dcache_invalidate)
3694         (target_dcache_get, target_dcache_get_or_init)
3695         (_initialize_target_dcache): Update.
3696         * dcache.h (struct dcache_deleter): New.
3697
3698 2019-05-08  Tom Tromey  <tom@tromey.com>
3699
3700         * symtab.c (struct symbol_cache): Add destructor and
3701         initializers.
3702         (symbol_cache_key): Move.  Change type.
3703         (make_symbol_cache, free_symbol_cache): Remove.
3704         (get_symbol_cache): Update.
3705         (symbol_cache_cleanup): Remove.
3706         (ALL_PSPACES, symbol_cache_flush)
3707         (maintenance_print_symbol_cache)
3708         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3709         Update.
3710
3711 2019-05-08  Tom Tromey  <tom@tromey.com>
3712
3713         * symtab.c (struct main_info): Add destructor and initializers.
3714         (main_progspace_key): Move.  Change type.
3715         (get_main_info): Update.
3716         (main_info_cleanup): Remove.
3717         (_initialize_symtab): Update.
3718
3719 2019-05-08  Tom Tromey  <tom@tromey.com>
3720
3721         * registry.h (DECLARE_REGISTRY): Define the _key class.
3722
3723 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3724
3725         * NEWS: Merge two 'New commands' sections.
3726
3727 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3728
3729         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3730         parameter and use Ada language definition instead.
3731         (ada_val_print_ptr): Remove unused language parameter.
3732         (ada_val_print_num): Remove language parameter and use Ada language
3733         definition instead.
3734         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3735         parameter.
3736         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3737         parameter and use Ada language definition instead.
3738         (ada_val_print_1): Update all ada_val_print_xxx calls.
3739         Remove language parameter.
3740         (ada_val_print): Update ada_val_print_1 call.
3741
3742 2019-05-08  Tom Tromey  <tromey@adacore.com>
3743
3744         * remote.c (remote_hw_watchpoint_limit)
3745         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3746         Now static.
3747
3748 2019-05-08  Tom Tromey  <tromey@adacore.com>
3749
3750         * maint.c (_initialize_maint_cmds): Move initialization code to
3751         remote.c.
3752         (watchdog, show_watchdog): Move to remote.c.
3753         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3754         "watchdog" static.
3755         (_initialize_remote): Move initialization code from maint.c.
3756         * defs.h (watchdog): Don't declare.
3757
3758 2019-05-08  Tom Tromey  <tromey@adacore.com>
3759
3760         * tui/tui-interp.c: Include main.h.
3761         * interps.c: Include main.h.
3762         * main.h (interpreter_p): Declare.
3763         * defs.h (interpreter_p): Don't declare.
3764
3765 2019-05-08  Tom Tromey  <tromey@adacore.com>
3766
3767         * dwarf2loc.c: Include dwarf2read.h.
3768         * defs.h (read_unsigned_leb128): Don't declare.
3769         * dwarf2read.h (read_unsigned_leb128): Declare.
3770
3771 2019-05-08  Tom Tromey  <tromey@adacore.com>
3772
3773         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3774         method.
3775
3776 2019-05-08  Tom Tromey  <tromey@adacore.com>
3777
3778         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3779         when no wrap column is set.
3780
3781 2019-05-08  Tom Tromey  <tromey@adacore.com>
3782
3783         * c-lang.c (c_get_string): Handle non-C-style arrays.
3784
3785 2019-05-08  Tom Tromey  <tromey@adacore.com>
3786
3787         * typeprint.c (print_offset_data::update): Print the bit offset,
3788         not the number of bits remaining.
3789
3790 2019-05-08  Tom Tromey  <tromey@adacore.com>
3791
3792         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3793         padding at end of comment.
3794
3795 2019-05-08  Tom Tromey  <tromey@adacore.com>
3796
3797         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3798         Compare main types.
3799
3800 2019-05-06  Tom Tromey  <tom@tromey.com>
3801
3802         * common/scoped_mmap.c: Include common-defs.h.
3803         * common/scoped_mmap.h: Don't include config.h.
3804
3805 2019-05-04  Tom Tromey  <tom@tromey.com>
3806
3807         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3808         (struct aarch64_call_info): Add initializers.
3809         <si>: Now a std::vector.
3810         (pass_on_stack, aarch64_push_dummy_call): Update.
3811
3812 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3813             Tom Tromey  <tom@tromey.com>
3814
3815         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3816         (ppc_threads): Now a std::vector.  Now static.
3817         (hwdebug_find_thread_points_by_tid)
3818         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3819         Update.
3820
3821 2019-05-04  Tom Tromey  <tom@tromey.com>
3822
3823         * arc-tdep.c (arc_tdesc_init): Return bool.
3824
3825 2019-05-04  Tom Tromey  <tom@tromey.com>
3826
3827         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3828         Use gdb_assert_not_reached.
3829
3830 2019-05-04  Tom Tromey  <tom@tromey.com>
3831
3832         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3833         "false".
3834
3835 2019-05-04  Tom Tromey  <tom@tromey.com>
3836
3837         * arc-tdep.c (arc_tdesc_init): Use bool.
3838
3839 2019-05-04  Tom Tromey  <tom@tromey.com>
3840
3841         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3842
3843 2019-05-04  Tom Tromey  <tom@tromey.com>
3844
3845         * cli/cli-cmds.c (valid_command_p): Return bool.
3846
3847 2019-05-04  Tom Tromey  <tom@tromey.com>
3848
3849         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3850         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3851
3852 2019-05-04  Raul Tambre  <raul@tambre.ee>
3853
3854         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3855         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3856         operator for comparison.
3857
3858 2019-05-04  Tom Tromey  <tom@tromey.com>
3859
3860         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3861         (lookup_partial_symbol, print_partial_symbols)
3862         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3863         (psymbol_compare): Update.
3864         (add_psymbol_to_bcache): Clear the entire psymbol.
3865         (maintenance_check_psymtabs): Update.
3866         * psympriv.h (struct partial_symbol): Don't derive from
3867         general_symbol_info.
3868         <obj_section, unrelocated_address, address,
3869         set_unrelocated_address>: Update.
3870         <ginfo>: New member.
3871         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3872         (debug_names::write_psymbols): Update.
3873
3874 2019-05-04  Tom de Vries  <tdevries@suse.de>
3875
3876         * contrib/cc-with-tweaks.sh: Support -n arg.
3877
3878 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3879
3880         * corelow.c (core_target::detach): Ensure frame cache and
3881         register caches are cleared.
3882         inferior.c (exit_inferior_1): Likewise.
3883
3884 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3885             Tom Tromey  <tom@tromey.com>
3886
3887         * dictionary.c (collate_pending_symbols_by_language): Remove
3888         "struct" from foreach.
3889         * symtab.c (lookup_global_symbol_from_objfile)
3890         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3891         foreach.
3892         * ser-tcp.c (net_open): Remove "struct" from foreach.
3893         * objfiles.c (objfile_relocate, objfile_rebase)
3894         (objfile_has_symbols): Remove "struct" from foreach.
3895         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3896         from foreach.
3897         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3898         foreach.
3899         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3900         "struct" from foreach.
3901         * ada-lang.c (create_excep_cond_exprs)
3902         (ada_exception_catchpoint_cond_string): Remove "struct" from
3903         foreach.
3904
3905 2019-05-03  Tom Tromey  <tromey@adacore.com>
3906
3907         * ada-exp.y (convert_char_literal): Check suffix of each
3908         enumerator.
3909
3910 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3911
3912         PR ada/21406:
3913         * ada-exp.y (yywrap): Don't define.
3914         * ada-lex.l (%option): Add noyywrap
3915         (yywrap): Remove.
3916
3917 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3918
3919         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3920         _WIN32_WINNT to the XP level, unless already defined to a higher
3921         level.
3922
3923         * unittests/parse-connection-spec-selftests.c:
3924         * ser-tcp.c:
3925         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3926         override.
3927
3928         * symfile.c (find_separate_debug_file): Remove colon from the
3929         drive spec of DOS/Windows file names of the target, so that the
3930         file name produced from DEBUGDIR and the target's directory will
3931         be valid on DOS/Windows systems.
3932
3933 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3934
3935         * rust-lang.c (val_print_struct): Handle printing structures
3936         containing strings.
3937
3938 2019-05-02  Tom Tromey  <tromey@adacore.com>
3939
3940         * valarith.c (_initialize_valarith): Remove.
3941
3942 2019-05-01  Tom Tromey  <tromey@adacore.com>
3943
3944         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3945         bitfields.
3946
3947 2019-05-01  Tom Tromey  <tromey@adacore.com>
3948
3949         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3950         for big-endian copies.
3951
3952 2019-04-30  Ali Tamur  <tamur@google.com>
3953         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3954         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3955         (read_3_bytes): New function.
3956
3957 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3958
3959         * windows-nat.c (main_thread_id): Delete.
3960         (handle_output_debug_string): Replace main_thread_id by
3961         current_event.dwThreadId.
3962         (fake_create_process): Likewise.
3963         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3964         Do not set main_thread_id.
3965         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3966         current_event.dwThreadId.
3967         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3968
3969 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3970
3971         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3972         Use current_event.dwThreadId instead of main_thread_id.
3973
3974 2019-04-30  Tom Tromey  <tromey@adacore.com>
3975
3976         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3977         (create_excep_cond_exprs): Iterate over program spaces.
3978         (ada_exception_catchpoint_cond_string): Examine all minimal
3979         symbols for exception types.
3980
3981 2019-04-30  Tom Tromey  <tromey@adacore.com>
3982
3983         PR c++/24470:
3984         * dwarf2read.c (process_structure_scope): Handle case where type
3985         has template parameters but no symbol was created.
3986
3987 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3988             Chris January  <chris.january@arm.com>
3989
3990         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3991         qualifier.
3992         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3993
3994 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3995
3996         * f-typeprint.c (f_print_type): Update rules for printing
3997         whitespace.
3998         (f_type_print_varspec_suffix): Likewise.
3999
4000 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4001             Chris January  <chris.january@arm.com>
4002
4003         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4004         function arguments.
4005
4006 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4007
4008         * f-lang.c (build_fortran_types): Change name of void type to
4009         lower case.
4010         * f-typeprint.c (f_type_print_base): Print the name of the void
4011         type, rather than a fixed string.
4012         * f-valprint.c (f_decorations): Use lower case void string.
4013
4014 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4015             Chris January  <chris.january@arm.com>
4016
4017         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4018         types for Fortran.
4019
4020 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4021             Chris January  <chris.january@arm.com>
4022             David Lecomber  <david.lecomber@arm.com>
4023
4024         * f-exp.y (BINOP_INTRINSIC): New token.
4025         (exp): New parser rule handling BINOP_INTRINSIC.
4026         (f77_keywords): Add new builtin procedures.
4027         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4028         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4029         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4030         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4031         (print_unop_subexp_f): New function.
4032         (print_binop_subexp_f): New function.
4033         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4034         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4035         (dump_subexp_body_f): Likewise.
4036         (operator_check_f): Likewise.
4037         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4038         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4039
4040 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4041
4042         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4043         UNOP_KIND.
4044         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4045         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4046         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4047         (operator_length_f): New fuction.
4048         (print_subexp_f): New function.
4049         (op_name_f): New function.
4050         (dump_subexp_body_f): New function.
4051         (operator_check_f): New function.
4052         (exp_descriptor_f): Replace standard expression handling functions
4053         with new functions.
4054         * gdb/fortran-operator.def: New file.
4055         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4056         * gdb/std-operator.def: Remove UNOP_KIND.
4057
4058 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4059
4060         * std-operator.def: Remove unbalanced, stray double quote
4061         character.
4062
4063 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4064             Chris January  <chris.january@arm.com>
4065             Daniel Everett  <daniel.everett@arm.com>
4066             Nick Forrington  <nick.forrington@arm.com>
4067             Richard Bunt  <richard.bunt@arm.com>
4068
4069         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4070         of depth when printing anonymous structs or unions.
4071         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4072         Don't print either the top-level value, or the children if the
4073         max-depth is exceeded.
4074         (ppscm_print_children): When printing the key of a map, allow one
4075         extra level of depth.
4076         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4077         print either the top-level value, or the children if the max-depth
4078         is exceeded.
4079         (print_children): When printing the key of a map, allow one extra
4080         level of depth.
4081         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4082         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4083         (user_print_options): Initialise max_depth field.
4084         (val_print_scalar_or_string_type_p): New function.
4085         (val_print): Check to see if the max depth has been reached.
4086         (val_print_check_max_depth): Define new function.
4087         (show_print_max_depth): New function.
4088         (_initialize_valprint): Add 'print max-depth' option.
4089         * valprint.h (struct value_print_options) <max_depth>: New field.
4090         (val_print_check_max_depth): Declare new function.
4091         * NEWS: Document new feature.
4092
4093 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4094
4095         * ada-lang.c (ada_language_defn): Initialise new field.
4096         * c-lang.c (c_is_string_type_p): New function.
4097         (c_language_defn): Initialise new field.
4098         (cplus_language_defn): Initialise new field.
4099         (asm_language_defn): Initialise new field.
4100         (minimal_language_defn): Initialise new field.
4101         * c-lang.h (c_is_string_type_p): Declare new function.
4102         * d-lang.c (d_language_defn): Initialise new field.
4103         * f-lang.c (f_is_string_type_p): New function.
4104         (f_language_defn): Initialise new field.
4105         * go-lang.c (go_is_string_type_p): New function.
4106         (go_language_defn): Initialise new field.
4107         * language.c (default_is_string_type_p): New function.
4108         (unknown_language_defn): Initialise new field.
4109         (auto_language_defn): Initialise new field.
4110         * language.h (struct language_defn) <la_is_string_type_p>: New
4111         member variable.
4112         (default_is_string_type_p): Declare new function.
4113         * m2-lang.c (m2_language_defn): Initialise new field.
4114         * objc-lang.c (objc_language_defn): Initialise new field.
4115         * opencl-lang.c (opencl_language_defn): Initialise new field.
4116         * p-lang.c (pascal_is_string_type_p): New function.
4117         (pascal_language_defn): Initialise new field.
4118         * rust-lang.c (rust_is_string_type_p): New function.
4119         (rust_language_defn): Initialise new field.
4120
4121 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4122
4123         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4124         New field.
4125         * ada-lang.c (ada_language_defn): Initialise new field.
4126         * c-lang.c (c_language_defn): Likewise.
4127         (cplus_language_defn): Likewise.
4128         (asm_language_defn): Likewise.
4129         (minimal_language_defn): Likewise.
4130         * d-lang.c (d_language_defn): Likewise.
4131         * f-lang.c (f_language_defn): Likewise.
4132         * go-lang.c (go_language_defn): Likewise.
4133         * language.c (unknown_language_defn): Likewise.
4134         (auto_language_defn): Likewise.
4135         * m2-lang.c (m2_language_defn): Likewise.
4136         * objc-lang.c (objc_language_defn): Likewise.
4137         * opencl-lang.c (opencl_language_defn): Likewise.
4138         * p-lang.c (pascal_language_defn): Likewise.
4139         * rust-lang.c (rust_language_defn): Likewise.
4140
4141 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4142
4143         * ada-lang.c (ada_is_character_type): Change return type to bool.
4144         (ada_is_string_type): Likewise.
4145         * ada-lang.h (ada_is_character_type): Update declaration
4146         (ada_is_string_type): Likewise.
4147
4148 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4149
4150         Support style in 'frame|thread apply'
4151
4152         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4153         * record.c (record_start, record_stop): Update callers of
4154         execute_command_to_string with false.
4155         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4156         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4157         methods.
4158         (class string_file): New constructor with term_out parameter.
4159         Override methods term_out and can_emit_style_escape.  New member
4160         term_out.
4161         (class stdio_file): Override can_emit_style_escape.
4162         (class tee_file): Override term_out and can_emit_style_escape.
4163         * utils.h (can_emit_style_escape): Remove.
4164         * utils.c (can_emit_style_escape): Likewise.
4165         Update all callers of can_emit_style_escape (SOMESTREAM) to
4166         SOMESTREAM->can_emit_style_escape.
4167         * source-cache.c (source_cache::get_source_lines): Likewise.
4168         * stack.c (frame_apply_command_count): Call execute_command_to_string
4169         passing the term_out characteristic of the current gdb_stdout.
4170         * thread.c (thr_try_catch_cmd): Likewise.
4171         * top.c (execute_command_to_string): pass term_out parameter
4172         to construct the string_file for the command output.
4173         * ui-file.c (term_cli_styling): New function (most code moved
4174         from utils.c can_emit_style_escape).
4175         (string_file::string_file, string_file::can_emit_style_escape,
4176         stdio_file::can_emit_style_escape, tee_file::term_out,
4177         tee_file::can_emit_style_escape): New functions.
4178
4179 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4180
4181         * NEWS: Mention the new set|show may-call-functions.
4182         * infcall.c (may_call_functions_p): New variable.
4183         (show_may_call_functions_p): New function.
4184         (call_function_by_hand_dummy): Throws an error if not
4185         may-call-functions.
4186         (_initialize_infcall): Call add_setshow_boolean_cmd for
4187         may-call-functions.
4188
4189 2019-04-25  Keith Seitz  <keiths@redhat.com>
4190
4191         PR c++/24367
4192         * cp-support.c (inspect_type): Don't attempt substitutions
4193         of symbol with the same name.
4194
4195 2019-04-25  Tom Tromey  <tromey@adacore.com>
4196
4197         PR gdb/24475:
4198         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4199         static.
4200
4201 2019-04-25  Tom Tromey  <tromey@adacore.com>
4202
4203         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4204         rvalue reference.
4205         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4206         (gdb_xml_parser::parse): Use std::move.
4207         * python/python-internal.h (gdbpy_convert_exception): Take a const
4208         reference.
4209         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4210         std::move.
4211         * python/py-utils.c (gdbpy_convert_exception): Take a const
4212         reference.
4213         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4214         Use std::move.
4215         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4216         Use std::move.
4217         * mi/mi-main.c (mi_print_exception): Take a const reference.
4218         * main.c (handle_command_errors): Take a const reference.
4219         * linespec.c (parse_linespec): Use std::move.
4220         * infcall.c (run_inferior_call): Use std::move.
4221         (call_function_by_hand_dummy): Use std::move.
4222         * exec.c (try_open_exec_file): Use std::move.
4223         * exceptions.h (exception_print, exception_fprintf)
4224         (exception_print_same): Update.
4225         * exceptions.c (print_exception, exception_print)
4226         (exception_fprintf, exception_print_same): Change parameters to
4227         const reference.
4228         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4229         * common/new-op.c: Use std::move.
4230         * common/common-exceptions.h (struct gdb_exception): Add move
4231         constructor.
4232         (struct gdb_exception_error, struct gdb_exception_quit, struct
4233         gdb_quit_bad_alloc): Change constructor to move constructor.
4234         (throw_exception): Change parameter to rvalue reference.
4235         * common/common-exceptions.c (throw_exception): Take rvalue
4236         reference.
4237         * cli/cli-interp.c (safe_execute_command): Use std::move.
4238         * breakpoint.c (insert_bp_location, location_to_sals): Use
4239         std::move.
4240
4241 2019-04-25  Tom Tromey  <tromey@adacore.com>
4242
4243         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4244         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4245         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4246         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4247         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4248         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4249         guile/scm-value.c: Use unpack.
4250         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4251         gdbscm_gdb_exception.
4252         (gdbscm_throw_gdb_exception): Likewise.
4253         (struct gdbscm_gdb_exception): New.
4254         (unpack): New function.
4255         (gdbscm_wrap): Use unpack.
4256
4257 2019-04-25  Tom Tromey  <tromey@adacore.com>
4258
4259         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4260         (gdb_rl_callback_handler): Use std::move.
4261         * common/common-exceptions.h (struct gdb_exception): Add move
4262         assignment operator.
4263         (throw_exception_sjlj): Change "exception" to const reference.
4264         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4265         (throw_exception_sjlj): Change "exception" to const reference.
4266
4267 2019-04-25  Tom Tromey  <tromey@adacore.com>
4268
4269         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4270         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4271         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4272         Update.
4273         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4274         Update.
4275         * mi/mi-interp.c (mi_interp::exec): Update.
4276         * linespec.c (parse_linespec): Update.
4277         * infcall.c (run_inferior_call): Update.
4278         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4279         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4280         (gdbscm_lookup_global_symbol): Update.
4281         * guile/scm-param.c (gdbscm_parameter_value): Update.
4282         * guile/scm-frame.c (gdbscm_frame_read_register)
4283         (gdbscm_frame_read_var): Update.
4284         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4285         * exec.c (try_open_exec_file): Update.
4286         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4287         (gdb_rl_callback_handler): Update.
4288         * common/common-exceptions.h (exception_none): Don't declare.
4289         * common/common-exceptions.c (exception_none): Don't define.
4290         (struct catcher) <exception>: Update.
4291         * cli/cli-interp.c (safe_execute_command): Update.
4292         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4293
4294 2019-04-25  Ali Tamur  <tamur@google.com>
4295
4296         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4297         (read_attribute_value): Likewise.
4298         (dwarf2_read_addr_index): Update comment.
4299         (read_str_index): Add DW_FORM_strx.
4300         (dwarf2_string_attr): Likewise.
4301         (dwarf2_const_value_attr): Likewise.
4302         (dump_die_shallow): Likewise.
4303         (dwarf2_fetch_constant_bytes): Likewise.
4304         (skip_form_bytes): Likewise.
4305         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4306
4307 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4308
4309         PR corefiles/11608
4310         PR corefiles/18187
4311         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4312         OFFSET.  Verify if current mapping contains an ELF header.
4313         (linux_find_memory_regions_full): Adjust call to
4314         dump_mapping_p.
4315
4316 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4317             Kang Li <kanglictf@gmail.com>
4318
4319         PR gdb/21600
4320
4321         * dwarf2-frame.c (read_initial_length): Be consistent about using
4322         unsigned representation of length.
4323         (decode_frame_entry_1): Likewise.  Check for wraparound of
4324         end pointer as well as buffer overflow.
4325
4326 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4327
4328         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4329         "vq".
4330
4331 2019-04-24  Tom Tromey  <tromey@adacore.com>
4332
4333         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4334
4335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4336
4337         * s12z-tdep.c (s12z_unwind_pc): Delete.
4338         (s12z_unwind_sp): Delete.
4339         (s12z_gdbarch_init): Don't register deleted functions with
4340         gdbarch.
4341
4342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4343
4344         * rl78-tdep.c (rl78_unwind_sp): Delete.
4345         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4346
4347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4348
4349         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4350         (xstormy16_unwind_pc): Delete.
4351         (xstormy16_dummy_id): Delete.
4352         (xstormy16_gdbarch_init): Don't register deleted functions with
4353         gdbarch.
4354
4355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * vax-tdep.c (vax_unwind_pc): Delete.
4358         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4359
4360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4361
4362         * v850-tdep.c (v850_unwind_sp): Delete.
4363         (v850_unwind_pc): Delete.
4364         (v850_dummy_id): Delete.
4365         (v850_gdbarch_init): Don't register deleted functions with
4366         gdbarch.
4367
4368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4369
4370         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4371         (tilegx_unwind_pc): Delete.
4372         (tilegx_unwind_dummy_id): Delete.
4373         (tilegx_gdbarch_init): Don't register deleted functions with
4374         gdbarch.
4375
4376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4377
4378         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4379         (tic6x_dummy_id): Delete.
4380         (tic6x_gdbarch_init): Don't register deleted functions with
4381         gdbarch.
4382
4383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4384
4385         * sparc-tdep.c (sparc_unwind_pc): Delete.
4386         (sparc32_gdbarch_init): Don't register deleted function with
4387         gdbarch.
4388
4389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4390
4391         * sh-tdep.c (sh_unwind_sp): Delete.
4392         (sh_unwind_pc): Delete.
4393         (sh_dummy_id): Delete.
4394         (sh_gdbarch_init): Don't register deleted functions with
4395         gdbarch.
4396
4397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4398
4399         * score-tdep.c (score_unwind_sp): Delete.
4400         (score_unwind_pc): Delete.
4401         (score_dummy_id): Delete.
4402         (score_gdbarch_init): Don't register deleted functions with
4403         gdbarch.
4404
4405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4406
4407         * rx-tdep.c (rx_unwind_pc): Delete.
4408         (rx_unwind_sp): Delete.
4409         (rx_dummy_id): Delete.
4410         (rx_gdbarch_init): Don't register deleted functions with
4411         gdbarch.  Update comment.
4412
4413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4414
4415         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4416         (rs6000_dummy_id): Delete.
4417         (rs6000_gdbarch_init): Don't register deleted functions with
4418         gdbarch.
4419
4420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4421
4422         * or1k-tdep.c (or1k_dummy_id): Delete.
4423         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4424
4425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4426
4427         * nios2-tdep.c (nios2_dummy_id): Delete.
4428         (nios2_unwind_sp): Delete.
4429         (nios2_gdbarch_init): Don't register deleted functions with
4430         gdbarch.
4431
4432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4433
4434         * nds32-tdep.c (nds32_dummy_id): Delete.
4435         (nds32_unwind_pc): Delete.
4436         (nds32_unwind_sp): Delete.
4437         (nds32_gdbarch_init): Don't register deleted functions with
4438         gdbarch.
4439
4440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4441
4442         * msp430-tdep.c (msp430_unwind_pc): Delete.
4443         (msp430_unwind_sp): Delete.
4444         (msp430_dummy_id): Delete.
4445         (msp430_gdbarch_init): Don't register deleted functions with
4446         gdbarch.
4447
4448 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4449
4450         * moxie-tdep.c (moxie_unwind_sp): Delete.
4451         (moxie_unwind_pc): Delete.
4452         (moxie_dummy_id): Delete.
4453         (moxie_gdbarch_init): Don't register deleted functions with
4454         gdbarch.
4455
4456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4457
4458         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4459         (mn10300_unwind_pc): Delete.
4460         (mn10300_unwind_sp): Delete.
4461         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4462         mn10300_unwind_sp.
4463         (mn10300_frame_unwind_init): Don't register deleted functions with
4464         gdbarch.
4465
4466 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4467
4468         * mep-tdep.c (mep_unwind_pc): Delete.
4469         (mep_unwind_sp): Delete.
4470         (mep_dummy_id): Delete.
4471         (mep_gdbarch_init): Don't register deleted functions with
4472         gdbarch.
4473
4474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4475
4476         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4477         (m68hc11_unwind_sp): Delete.
4478         (m68hc11_gdbarch_init): Don't register deleted functions with
4479         gdbarch.
4480
4481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4482
4483         * m32r-tdep.c (m32r_unwind_sp): Delete.
4484         (m32r_unwind_pc): Delete.
4485         (m32r_dummy_id): Delete.
4486         (m32r_gdbarch_init): Don't register deleted functions with
4487         gdbarch.
4488
4489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4490
4491         * m32c-tdep.c (m32c_unwind_pc): Delete.
4492         (m32c_unwind_sp): Delete.
4493         (m32c_dummy_id): Delete.
4494         (m32c_gdbarch_init): Don't register deleted functions with
4495         gdbarch.
4496
4497 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4498
4499         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4500         (lm32_unwind_pc): Delete.
4501         (lm32_dummy_id): Delete.
4502         (lm32_gdbarch_init): Don't register deleted functions with
4503         gdbarch.
4504
4505 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4506
4507         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4508         (iq2000_unwind_pc): Delete.
4509         (iq2000_dummy_id): Delete.
4510         (iq2000_gdbarch_init): Don't register deleted functions with
4511         gdbarch.
4512
4513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4514
4515         * nds32-tdep.c (nds32_type_align): Delete.
4516         (nds32_push_dummy_call): Use type_align instead.
4517
4518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4519
4520         * arm-tdep.c (arm_type_align): Only handle vector override case.
4521         (arm_push_dummy_call): Use type_align.
4522         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4523
4524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4525
4526         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4527         case.
4528         (pass_on_stack): Use type_align.
4529         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4530         function.
4531
4532 2019-04-23  Tom Tromey  <tromey@adacore.com>
4533
4534         * dwarf2read.c (line_header::file_name_at): Remove unused
4535         overload.
4536
4537 2019-04-23  Tom de Vries  <tdevries@suse.de>
4538
4539         PR gdb/24438
4540         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4541         invocation.
4542
4543
4544 2019-03-27  Ali Tamur  <tamur@google.com>
4545
4546         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4547         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4548         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4549         (dwarf_expr_context::get_addr_index): Likewise
4550         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4551         (symbol_needs_eval_context::get_addr_index): Likewise
4552         (disassemble_dwarf_expression): Add DW_OP_addrx
4553         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4554         (read_cutu_die_from_dwo): Update comment
4555         (skip_one_die): Add DW_FORM_addrx
4556         (read_attribute_value): Likewise
4557         (var_decode_location): Add DW_OP_addrx
4558         (dwarf2_const_value_attr): Add DW_FORM_addrx
4559         (dump_die_shallow): Likewise
4560         (dwarf2_fetch_constant_bytes): Likewise
4561         (decode_locdesc): Add DW_OP_addrx
4562         (skip_form_bytes): Add DW_FORM_addrx
4563
4564 2019-04-22  Ali Tamur  <tamur@google.com>
4565
4566         * MAINTAINERS (Write After Approval): Add self.
4567
4568 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4569
4570         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4571         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4572         (open_symbol_file_object): Likewise.
4573         (svr4_default_sos): Add info parameter.
4574         (svr4_read_so_list): Likewise.
4575         (svr4_current_sos_direct): Adjust functions calls to pass down
4576         info.
4577         (svr4_current_sos_1): Add info parameter.
4578         (svr4_current_sos): Call get_svr4_info, pass info down to
4579         svr4_current_sos_1.
4580         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4581         get_svr4_info.
4582         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4583         get_svr4_info.
4584         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4585         to get_svr4_info.
4586         (probes_table_remove_objfile_probes): Likewise.
4587         (register_solib_event_probe): Add info parameter.
4588         (solist_update_incremental): Pass info parameter down to
4589         svr4_read_so_list.
4590         (disable_probes_interface): Add info parameter.
4591         (svr4_handle_solib_event): Pass current_program_space to
4592         get_svr4_info.  Adjust disable_probes_interface cleanup.
4593         (svr4_create_probe_breakpoints): Add info parameter, pass it
4594         down to register_solib_event_probe.
4595         (svr4_create_solib_event_breakpoints): Add info parameter,
4596         pass it down to svr4_create_probe_breakpoints.
4597         (enable_break): Pass info down to
4598         svr4_create_solib_event_breakpoints.
4599         (svr4_solib_create_inferior_hook): Pass current_program_space to
4600         get_svr4_info.
4601         (svr4_clear_solib): Likewise.
4602
4603 2019-04-22  Pedro Alves  <palves@redhat.com>
4604
4605         * solib-svr4.c (svr4_free_objfile_observer): New.
4606         (probe_and_action::objfile): New field.
4607         (probes_table_htab_remove_objfile_probes)
4608         (probes_table_remove_objfile_probes): New functions.
4609         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4610         in the new probe_and_action.  Don't store the probe in 'lookup'.
4611         (svr4_create_probe_breakpoints): Pass objfile to
4612         register_solib_event_probe.
4613         (_initialize_svr4_solib): Register a free_objfile observer.
4614
4615 2019-04-19  Tom Tromey  <tom@tromey.com>
4616
4617         * common/queue.h: Remove.
4618
4619 2019-04-19  Tom Tromey  <tom@tromey.com>
4620
4621         * event-loop.c: Don't include "common/queue.h".
4622
4623 2019-04-19  Tom Tromey  <tom@tromey.com>
4624
4625         * remote.c (remote_target): Use delete.
4626         * remote-notif.h: Include <list>, not "common/queue.h".
4627         (notif_client_p): Remove typedef.
4628         (remote_notif_state): Add constructor, destructor, initializer.
4629         <notif_queue>: Now a std::list.
4630         (remote_notif_state_xfree): Don't declare.
4631         * remote-notif.c (remote_notif_process, handle_notification)
4632         (remote_notif_state_allocate): Update.
4633         (~remote_notif_state): Rename from remote_notif_state_xfree.
4634
4635 2019-04-19  Tom Tromey  <tom@tromey.com>
4636
4637         * symfile.c (reread_symbols): Update.
4638         * objfiles.c (objfile_register_static_link)
4639         (objfile_lookup_static_link): Update
4640         (~objfile) Don't delete static_links.
4641         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4642
4643 2019-04-19  Tom Tromey  <tom@tromey.com>
4644
4645         * type-stack.h (struct type_stack) <insert>: Constify string.
4646         * type-stack.c (type_stack::insert): Constify string.
4647         * gdbtypes.h (lookup_template_type): Update.
4648         (address_space_name_to_int): Update.
4649         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4650         const.
4651         (lookup_template_type): Make name const.
4652         * c-exp.y: Update rules.
4653         (lex_one_token, classify_name, classify_inner_name)
4654         (c_print_token): Update.
4655         * p-exp.y: Update rules.
4656         (yylex): Update.
4657         * f-exp.y: Update rules.
4658         (yylex): Update.
4659         * d-exp.y: Update rules.
4660         (lex_one_token, classify_name, classify_inner_name): Update.
4661         * parse.c (write_dollar_variable, copy_name): Return std::string.
4662         * parser-defs.h (copy_name): Change return type.
4663         * m2-exp.y: Update rules.
4664         (yylex): Update.
4665         * go-exp.y (lex_one_token): Update.
4666         Update rules.
4667         (classify_unsafe_function, classify_packaged_name)
4668         (classify_name, yylex): Update.
4669
4670 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4671
4672         * configure.ac: add --enable-source-highlight switch.
4673         * configure: Regenerate.
4674         * top.c (print_gdb_version): plumb --enable-source-highlight
4675         status to "show configuration".
4676
4677 2019-04-19  Tom Tromey  <tromey@adacore.com>
4678
4679         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4680         Check ADA_TYPE_P.
4681         (empty_record, ada_template_to_fixed_record_type_1)
4682         (template_to_static_fixed_type)
4683         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4684         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4685         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4686         macros.
4687
4688 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4689
4690         PR symtab/24423:
4691         * source.c (print_source_lines_base): Advance "iter" when a
4692         control character is seen.
4693
4694 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4695
4696         * inferior.h (struct infcall_suspend_state_deleter):
4697         Catch exception in destructor to avoid crash.
4698
4699 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4700
4701         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4702         close to the add_com "shell".
4703
4704 2019-04-18  Tom Tromey  <tromey@adacore.com>
4705
4706         * process-stratum-target.h (class process_stratum_target)
4707         <stratum>: Add "final".
4708
4709 2019-04-17  Tom Tromey  <tromey@adacore.com>
4710
4711         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4712         against nullptr before use.
4713
4714 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4715
4716         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4717
4718 2019-04-17  Jim Wilson  <jimw@sifive.com>
4719             Andrew Burgess  <andrew.burgess@embecosm.com>
4720
4721         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4722         code read might fail, assume 4-byte breakpoint in that case.
4723
4724 2019-04-15  Leszek Swirski  <leszeks@google.com>
4725
4726         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4727         rather than a hand-rolled POD check when checking for forced MEMORY
4728         classification.
4729
4730 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4731
4732         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4733         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4734         function.
4735         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4736         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4737         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4738         declaration.
4739
4740 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4741
4742         * aarch64-linux-nat.c
4743         (aarch64_linux_nat_target::thread_architecture): Add override.
4744         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4745         each VQ.
4746
4747 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4748
4749         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4750
4751 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4752
4753         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4754         target types of size 96-bits, add some additional comments, and
4755         check that the builtin type we found was the correct size.
4756
4757 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4758
4759         * utils.c (prompt_for_continue): Don't restore the styling at the
4760         end, as applied_style has the wrong value.  This fixes styling in
4761         long lists of file names that are interrupted by the "Continue?"
4762         prompt.
4763
4764 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4765
4766         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4767         * c-lang.c (c_language_defn): Likewise.
4768         (cplus_language_defn): Likewise.
4769         (asm_language_defn): Likewise.
4770         (minimal_language_defn): Likewise.
4771         * d-lang.c (d_language_defn): Likewise.
4772         * f-lang.c (f_language_defn): Likewise.
4773         * go-lang.c (go_language_defn): Likewise.
4774         * language.c (unknown_language_defn): Likewise.
4775         (auto_language_defn): Likewise.
4776         * language.h (struct language_defn): Remove la_magic field.
4777         (LANG_MAGIC): Delete.
4778         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4779         * objc-lang.c (objc_language_defn): Likewise.
4780         * opencl-lang.c (opencl_language_defn): Likewise.
4781         * p-lang.c (pascal_language_defn): Likewise.
4782         * rust-lang.c (rust_language_defn): Likewise.
4783
4784 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4785
4786         * riscv-tdep.c (riscv_type_align): New function.
4787         (riscv_type_alignment): Delete.
4788         (riscv_arg_location): Use 'type_align'.
4789         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4790
4791 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4792
4793         * gdbtypes.c (type_align): A struct with no non-static fields also
4794         has alignment of 1.
4795
4796 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4797
4798         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4799         component to 0.
4800         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4801         member.
4802         (riscv_struct_info::analyse): New implementation using new
4803         analyse_inner member function.
4804         (riscv_struct_info::field_offset): New member function.
4805         (riscv_struct_info::m_offsets): New member variable.
4806         (riscv_struct_info::analyse_inner): New private member function,
4807         takes the old implementation of riscv_struct_info::analyse but
4808         extended to track field offsets.
4809         (riscv_call_arg_struct): Update the struct folding special cases
4810         to handle cases where empty C++ structs, which are non-zero
4811         length, are found.
4812         (riscv_arg_location): Initialise the length of each location, a
4813         non-zero length now indicates the location is in use.
4814         (riscv_push_dummy_call): Allow for the first location having a
4815         non-zero offset when setting up arguments.
4816         (riscv_return_value): Likewise, but for return values.
4817
4818 2019-04-11  Tom Tromey  <tromey@adacore.com>
4819
4820         * utils.c (internal_vproblem): Make "msg" const.
4821
4822 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4823
4824         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4825         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4826         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4827         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4828
4829 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4830
4831         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4832         function.
4833         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4834         of amd64_collect_native_gregset.
4835         (amd64_linux_nat_target::store_registers): Likewise.
4836
4837 2019-04-10  Tom Tromey  <tom@tromey.com>
4838
4839         * symtab.c (lookup_global_symbol_from_objfile)
4840         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4841         * objfiles.h (class separate_debug_iterator): New.
4842         (class separate_debug_range): New.
4843         (struct objfile) <separate_debug_objfiles>: New method.
4844         (objfile_separate_debug_iterate): Don't declare.
4845         * objfiles.c (separate_debug_iterator::operator++): Rename from
4846         objfile_separate_debug_iterate.
4847         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4848         iterator.
4849         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4850         iterator.
4851
4852 2019-04-10  Tom Tromey  <tom@tromey.com>
4853
4854         * symfile.c (reread_symbols): Remove old comment.
4855         * objfiles.c (free_all_objfiles): Fix a typo.
4856
4857 2019-04-10  Tom Tromey  <tom@tromey.com>
4858
4859         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4860         * minsyms.c (lookup_minimal_symbol): Use foreach.
4861         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4862         (lookup_minimal_symbol_solib_trampoline): Likewise.
4863         * symfile.c (reread_symbols): Use foreach.
4864
4865 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4866             Tom Tromey  <tromey@adacore.com>
4867
4868         PR rust/24414:
4869         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4870         (rust_lex_int_test): Change "value" to be LONGEST.
4871         (rust_lex_tests): Add test for long integer literal.
4872
4873 2019-04-09  Tom Tromey  <tromey@adacore.com>
4874
4875         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4876         to bool.
4877         (extended_remote_target::attach): Update.
4878         (remote_target::remote_notice_new_inferior): Update.
4879         (remote_target::add_current_inferior_and_thread): Update.
4880         * inferior.c (exit_inferior_1): Use "false".
4881         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4882
4883 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4884
4885         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4886         the "start" command.
4887
4888 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4889
4890         * python/py-inferior.c (infpy_thread_from_thread_handle):
4891         Adjust comments to reflect renaming of thread_from_thread_handle
4892         to thread_from_handle.  Adjust keywords.  Fix type error message.
4893         (inferior_object_methods): Add thread_from_handle.  Retain
4894         thread_from_thread_handle, but mark it as deprecated.
4895
4896 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4897
4898         * gdbthread.h (find_thread_by_handle): Revise declaration.
4899         * thread.c (find_thread_by_handle): Likewise.  Adjust
4900         implementation too.
4901         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4902         support for buffer objects as handles.
4903
4904 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4905
4906         * python/py-infthread.c (thpy_thread_handle): New function.
4907         (thread_object_methods): Register thpy_thread_handle.
4908
4909 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4910
4911         * gdbthread.h (thread_to_thread_handle): Declare.
4912         * thread.c (gdbtypes.h): Include.
4913         (thread_to_thread_handle): New function.
4914
4915         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4916         (target_thread_info_to_thread_handle): Declare.
4917         * target.c (target_thread_info_to_thread_handle): New function.
4918         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4919         * target-delegates.c: Regenerate.
4920
4921         * linux-thread-db.c (class thread_db_target): Add method
4922         thread_info_to_thread_handle.
4923         (thread_db_target::thread_info_to_thread_handle): Define.
4924         * remote.c (class remote_target): Add new method
4925         thread_info_to_thread_handle.
4926         (remote_target::thread_info_to_thread_handle): Define.
4927
4928 2019-04-08  Pedro Alves  <palves@redhat.com>
4929
4930         * common/common-exceptions.c (throw_exception): Don't create
4931         named object to throw; throw directly.
4932         (throw_it): Likewise.  Don't initialize gdb_exception::message
4933         here, with new; pass FMT and AP to the ctor instead.
4934         * common/common-exceptions.h: Include <string>.
4935         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4936         const char *, va_list)): New ctor.  Use std::make_shared.
4937         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4938         errors)): Delete.
4939         (gdb_exception_error::gdb_exception_error(enum errors, const char
4940         *, va_list)): New.
4941         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4942         Add assertion.
4943         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4944         errors)): Delete.
4945         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4946         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4947         Add assertion.
4948
4949 2019-04-08  Tom Tromey  <tom@tromey.com>
4950
4951         * valops.c (value_rtti_indirect_type): Replace throw_exception
4952         with throw.
4953         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4954         with throw.
4955         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4956         throw.
4957         * target.c (target_translate_tls_address): Replace throw_exception
4958         with throw.
4959         * stack.c (frame_apply_command_count): Replace throw_exception
4960         with throw.
4961         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4962         throw.
4963         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4964         with throw.
4965         * rs6000-tdep.c (rs6000_frame_cache)
4966         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4967         * remote.c: Replace throw_exception with throw.
4968         * record-full.c (record_full_message, record_full_wait_1)
4969         (record_full_restore): Replace throw_exception with throw.
4970         * record-btrace.c:
4971         (get_thread_current_frame_id, record_btrace_start_replaying)
4972         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4973         (cmd_record_btrace_start): Replace throw_exception with throw.
4974         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4975         throw.
4976         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4977         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4978         * linespec.c:
4979         (find_linespec_symbols): Replace throw_exception with throw.
4980         * infrun.c (displaced_step_prepare, resume): Replace
4981         throw_exception with throw.
4982         * infcmd.c (post_create_inferior): Replace throw_exception with
4983         throw.
4984         * inf-loop.c (inferior_event_handler): Replace throw_exception
4985         with throw.
4986         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4987         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4988         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4989         (get_prev_frame_always, get_frame_pc_if_available)
4990         (get_frame_address_in_block_if_available, get_frame_language):
4991         Replace throw_exception with throw.
4992         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4993         throw_exception with throw.
4994         * eval.c (fetch_subexp_value, evaluate_var_value)
4995         (evaluate_funcall, evaluate_subexp_standard): Replace
4996         throw_exception with throw.
4997         * dwarf2loc.c (call_site_find_chain)
4998         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4999         Replace throw_exception with throw.
5000         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5001         with throw.
5002         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5003         throw.
5004         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5005         * completer.c (complete_line_internal): Replace throw_exception
5006         with throw.
5007         * compile/compile-object-run.c (compile_object_run): Replace
5008         throw_exception with throw.
5009         * cli/cli-script.c (process_next_line): Replace throw_exception
5010         with throw.
5011         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5012         (btrace_enable, btrace_maint_update_pt_packets): Replace
5013         throw_exception with throw.
5014         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5015         throw_exception with throw.
5016         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5017         throw_exception with throw.
5018         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5019         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5020         * aarch64-tdep.c (aarch64_make_prologue_cache)
5021         (aarch64_make_stub_cache): Replace throw_exception with throw.
5022
5023 2019-04-08  Tom Tromey  <tom@tromey.com>
5024
5025         * common/common-exceptions.c (throw_exception): Rename from
5026         throw_exception_cxx.  Remove old copy.  Make argument const.
5027         (throw_it): Create and throw exception objects directly.
5028         * common/common-exceptions.h (throw_exception): Make argument
5029         const.
5030         (struct gdb_exception_error): Add constructor.
5031         (struct gdb_exception_quit): Add constructor.
5032
5033 2019-04-08  Tom Tromey  <tom@tromey.com>
5034
5035         * common/common-exceptions.h (exception_rethrow): Don't declare.
5036         (TRY_SJLJ): Update comment.
5037         (TRY, CATCH, END_CATCH): Remove.
5038         * common/common-exceptions.c (exception_rethrow): Remove.
5039
5040 2019-04-08  Tom Tromey  <tom@tromey.com>
5041
5042         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5043         Remove.
5044         (gdb_exception_error): Rename from
5045         gdb_exception_RETURN_MASK_ERROR.
5046         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5047         (gdb_quit_bad_alloc): Update.
5048         * aarch64-tdep.c: Update.
5049         * ada-lang.c: Update.
5050         * ada-typeprint.c: Update.
5051         * ada-valprint.c: Update.
5052         * amd64-tdep.c: Update.
5053         * arch-utils.c: Update.
5054         * break-catch-throw.c: Update.
5055         * breakpoint.c: Update.
5056         * btrace.c: Update.
5057         * c-varobj.c: Update.
5058         * cli/cli-cmds.c: Update.
5059         * cli/cli-interp.c: Update.
5060         * cli/cli-script.c: Update.
5061         * common/common-exceptions.c: Update.
5062         * common/new-op.c: Update.
5063         * common/selftest.c: Update.
5064         * compile/compile-c-symbols.c: Update.
5065         * compile/compile-cplus-symbols.c: Update.
5066         * compile/compile-object-load.c: Update.
5067         * compile/compile-object-run.c: Update.
5068         * completer.c: Update.
5069         * corelow.c: Update.
5070         * cp-abi.c: Update.
5071         * cp-support.c: Update.
5072         * cp-valprint.c: Update.
5073         * darwin-nat.c: Update.
5074         * disasm-selftests.c: Update.
5075         * dtrace-probe.c: Update.
5076         * dwarf-index-cache.c: Update.
5077         * dwarf-index-write.c: Update.
5078         * dwarf2-frame-tailcall.c: Update.
5079         * dwarf2-frame.c: Update.
5080         * dwarf2loc.c: Update.
5081         * dwarf2read.c: Update.
5082         * eval.c: Update.
5083         * event-loop.c: Update.
5084         * event-top.c: Update.
5085         * exec.c: Update.
5086         * f-valprint.c: Update.
5087         * fbsd-tdep.c: Update.
5088         * frame-unwind.c: Update.
5089         * frame.c: Update.
5090         * gdbtypes.c: Update.
5091         * gnu-v3-abi.c: Update.
5092         * guile/guile-internal.h: Update.
5093         * guile/scm-block.c: Update.
5094         * guile/scm-breakpoint.c: Update.
5095         * guile/scm-cmd.c: Update.
5096         * guile/scm-disasm.c: Update.
5097         * guile/scm-frame.c: Update.
5098         * guile/scm-lazy-string.c: Update.
5099         * guile/scm-math.c: Update.
5100         * guile/scm-param.c: Update.
5101         * guile/scm-ports.c: Update.
5102         * guile/scm-pretty-print.c: Update.
5103         * guile/scm-symbol.c: Update.
5104         * guile/scm-symtab.c: Update.
5105         * guile/scm-type.c: Update.
5106         * guile/scm-value.c: Update.
5107         * i386-linux-tdep.c: Update.
5108         * i386-tdep.c: Update.
5109         * inf-loop.c: Update.
5110         * infcall.c: Update.
5111         * infcmd.c: Update.
5112         * infrun.c: Update.
5113         * jit.c: Update.
5114         * language.c: Update.
5115         * linespec.c: Update.
5116         * linux-fork.c: Update.
5117         * linux-nat.c: Update.
5118         * linux-tdep.c: Update.
5119         * linux-thread-db.c: Update.
5120         * main.c: Update.
5121         * mi/mi-cmd-break.c: Update.
5122         * mi/mi-cmd-stack.c: Update.
5123         * mi/mi-interp.c: Update.
5124         * mi/mi-main.c: Update.
5125         * objc-lang.c: Update.
5126         * p-valprint.c: Update.
5127         * parse.c: Update.
5128         * ppc-linux-tdep.c: Update.
5129         * printcmd.c: Update.
5130         * python/py-arch.c: Update.
5131         * python/py-breakpoint.c: Update.
5132         * python/py-cmd.c: Update.
5133         * python/py-finishbreakpoint.c: Update.
5134         * python/py-frame.c: Update.
5135         * python/py-framefilter.c: Update.
5136         * python/py-gdb-readline.c: Update.
5137         * python/py-inferior.c: Update.
5138         * python/py-infthread.c: Update.
5139         * python/py-lazy-string.c: Update.
5140         * python/py-linetable.c: Update.
5141         * python/py-objfile.c: Update.
5142         * python/py-param.c: Update.
5143         * python/py-prettyprint.c: Update.
5144         * python/py-progspace.c: Update.
5145         * python/py-record-btrace.c: Update.
5146         * python/py-record.c: Update.
5147         * python/py-symbol.c: Update.
5148         * python/py-type.c: Update.
5149         * python/py-unwind.c: Update.
5150         * python/py-utils.c: Update.
5151         * python/py-value.c: Update.
5152         * python/python.c: Update.
5153         * record-btrace.c: Update.
5154         * record-full.c: Update.
5155         * remote-fileio.c: Update.
5156         * remote.c: Update.
5157         * riscv-tdep.c: Update.
5158         * rs6000-aix-tdep.c: Update.
5159         * rs6000-tdep.c: Update.
5160         * rust-exp.y: Update.
5161         * rust-lang.c: Update.
5162         * s390-tdep.c: Update.
5163         * selftest-arch.c: Update.
5164         * solib-dsbt.c: Update.
5165         * solib-frv.c: Update.
5166         * solib-spu.c: Update.
5167         * solib-svr4.c: Update.
5168         * solib.c: Update.
5169         * sparc64-linux-tdep.c: Update.
5170         * stack.c: Update.
5171         * symfile-mem.c: Update.
5172         * symmisc.c: Update.
5173         * target.c: Update.
5174         * thread.c: Update.
5175         * top.c: Update.
5176         * tracefile-tfile.c: Update.
5177         * tui/tui.c: Update.
5178         * typeprint.c: Update.
5179         * unittests/cli-utils-selftests.c: Update.
5180         * unittests/parse-connection-spec-selftests.c: Update.
5181         * valops.c: Update.
5182         * valprint.c: Update.
5183         * value.c: Update.
5184         * varobj.c: Update.
5185         * windows-nat.c: Update.
5186         * x86-linux-nat.c: Update.
5187         * xml-support.c: Update.
5188
5189 2019-04-08  Tom Tromey  <tom@tromey.com>
5190
5191         * xml-support.c: Use C++ exception handling.
5192         * x86-linux-nat.c: Use C++ exception handling.
5193         * windows-nat.c: Use C++ exception handling.
5194         * varobj.c: Use C++ exception handling.
5195         * value.c: Use C++ exception handling.
5196         * valprint.c: Use C++ exception handling.
5197         * valops.c: Use C++ exception handling.
5198         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5199         handling.
5200         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5201         * typeprint.c: Use C++ exception handling.
5202         * tui/tui.c: Use C++ exception handling.
5203         * tracefile-tfile.c: Use C++ exception handling.
5204         * top.c: Use C++ exception handling.
5205         * thread.c: Use C++ exception handling.
5206         * target.c: Use C++ exception handling.
5207         * symmisc.c: Use C++ exception handling.
5208         * symfile-mem.c: Use C++ exception handling.
5209         * stack.c: Use C++ exception handling.
5210         * sparc64-linux-tdep.c: Use C++ exception handling.
5211         * solib.c: Use C++ exception handling.
5212         * solib-svr4.c: Use C++ exception handling.
5213         * solib-spu.c: Use C++ exception handling.
5214         * solib-frv.c: Use C++ exception handling.
5215         * solib-dsbt.c: Use C++ exception handling.
5216         * selftest-arch.c: Use C++ exception handling.
5217         * s390-tdep.c: Use C++ exception handling.
5218         * rust-lang.c: Use C++ exception handling.
5219         * rust-exp.y: Use C++ exception handling.
5220         * rs6000-tdep.c: Use C++ exception handling.
5221         * rs6000-aix-tdep.c: Use C++ exception handling.
5222         * riscv-tdep.c: Use C++ exception handling.
5223         * remote.c: Use C++ exception handling.
5224         * remote-fileio.c: Use C++ exception handling.
5225         * record-full.c: Use C++ exception handling.
5226         * record-btrace.c: Use C++ exception handling.
5227         * python/python.c: Use C++ exception handling.
5228         * python/py-value.c: Use C++ exception handling.
5229         * python/py-utils.c: Use C++ exception handling.
5230         * python/py-unwind.c: Use C++ exception handling.
5231         * python/py-type.c: Use C++ exception handling.
5232         * python/py-symbol.c: Use C++ exception handling.
5233         * python/py-record.c: Use C++ exception handling.
5234         * python/py-record-btrace.c: Use C++ exception handling.
5235         * python/py-progspace.c: Use C++ exception handling.
5236         * python/py-prettyprint.c: Use C++ exception handling.
5237         * python/py-param.c: Use C++ exception handling.
5238         * python/py-objfile.c: Use C++ exception handling.
5239         * python/py-linetable.c: Use C++ exception handling.
5240         * python/py-lazy-string.c: Use C++ exception handling.
5241         * python/py-infthread.c: Use C++ exception handling.
5242         * python/py-inferior.c: Use C++ exception handling.
5243         * python/py-gdb-readline.c: Use C++ exception handling.
5244         * python/py-framefilter.c: Use C++ exception handling.
5245         * python/py-frame.c: Use C++ exception handling.
5246         * python/py-finishbreakpoint.c: Use C++ exception handling.
5247         * python/py-cmd.c: Use C++ exception handling.
5248         * python/py-breakpoint.c: Use C++ exception handling.
5249         * python/py-arch.c: Use C++ exception handling.
5250         * printcmd.c: Use C++ exception handling.
5251         * ppc-linux-tdep.c: Use C++ exception handling.
5252         * parse.c: Use C++ exception handling.
5253         * p-valprint.c: Use C++ exception handling.
5254         * objc-lang.c: Use C++ exception handling.
5255         * mi/mi-main.c: Use C++ exception handling.
5256         * mi/mi-interp.c: Use C++ exception handling.
5257         * mi/mi-cmd-stack.c: Use C++ exception handling.
5258         * mi/mi-cmd-break.c: Use C++ exception handling.
5259         * main.c: Use C++ exception handling.
5260         * linux-thread-db.c: Use C++ exception handling.
5261         * linux-tdep.c: Use C++ exception handling.
5262         * linux-nat.c: Use C++ exception handling.
5263         * linux-fork.c: Use C++ exception handling.
5264         * linespec.c: Use C++ exception handling.
5265         * language.c: Use C++ exception handling.
5266         * jit.c: Use C++ exception handling.
5267         * infrun.c: Use C++ exception handling.
5268         * infcmd.c: Use C++ exception handling.
5269         * infcall.c: Use C++ exception handling.
5270         * inf-loop.c: Use C++ exception handling.
5271         * i386-tdep.c: Use C++ exception handling.
5272         * i386-linux-tdep.c: Use C++ exception handling.
5273         * guile/scm-value.c: Use C++ exception handling.
5274         * guile/scm-type.c: Use C++ exception handling.
5275         * guile/scm-symtab.c: Use C++ exception handling.
5276         * guile/scm-symbol.c: Use C++ exception handling.
5277         * guile/scm-pretty-print.c: Use C++ exception handling.
5278         * guile/scm-ports.c: Use C++ exception handling.
5279         * guile/scm-param.c: Use C++ exception handling.
5280         * guile/scm-math.c: Use C++ exception handling.
5281         * guile/scm-lazy-string.c: Use C++ exception handling.
5282         * guile/scm-frame.c: Use C++ exception handling.
5283         * guile/scm-disasm.c: Use C++ exception handling.
5284         * guile/scm-cmd.c: Use C++ exception handling.
5285         * guile/scm-breakpoint.c: Use C++ exception handling.
5286         * guile/scm-block.c: Use C++ exception handling.
5287         * guile/guile-internal.h: Use C++ exception handling.
5288         * gnu-v3-abi.c: Use C++ exception handling.
5289         * gdbtypes.c: Use C++ exception handling.
5290         * frame.c: Use C++ exception handling.
5291         * frame-unwind.c: Use C++ exception handling.
5292         * fbsd-tdep.c: Use C++ exception handling.
5293         * f-valprint.c: Use C++ exception handling.
5294         * exec.c: Use C++ exception handling.
5295         * event-top.c: Use C++ exception handling.
5296         * event-loop.c: Use C++ exception handling.
5297         * eval.c: Use C++ exception handling.
5298         * dwarf2read.c: Use C++ exception handling.
5299         * dwarf2loc.c: Use C++ exception handling.
5300         * dwarf2-frame.c: Use C++ exception handling.
5301         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5302         * dwarf-index-write.c: Use C++ exception handling.
5303         * dwarf-index-cache.c: Use C++ exception handling.
5304         * dtrace-probe.c: Use C++ exception handling.
5305         * disasm-selftests.c: Use C++ exception handling.
5306         * darwin-nat.c: Use C++ exception handling.
5307         * cp-valprint.c: Use C++ exception handling.
5308         * cp-support.c: Use C++ exception handling.
5309         * cp-abi.c: Use C++ exception handling.
5310         * corelow.c: Use C++ exception handling.
5311         * completer.c: Use C++ exception handling.
5312         * compile/compile-object-run.c: Use C++ exception handling.
5313         * compile/compile-object-load.c: Use C++ exception handling.
5314         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5315         * compile/compile-c-symbols.c: Use C++ exception handling.
5316         * common/selftest.c: Use C++ exception handling.
5317         * common/new-op.c: Use C++ exception handling.
5318         * cli/cli-script.c: Use C++ exception handling.
5319         * cli/cli-interp.c: Use C++ exception handling.
5320         * cli/cli-cmds.c: Use C++ exception handling.
5321         * c-varobj.c: Use C++ exception handling.
5322         * btrace.c: Use C++ exception handling.
5323         * breakpoint.c: Use C++ exception handling.
5324         * break-catch-throw.c: Use C++ exception handling.
5325         * arch-utils.c: Use C++ exception handling.
5326         * amd64-tdep.c: Use C++ exception handling.
5327         * ada-valprint.c: Use C++ exception handling.
5328         * ada-typeprint.c: Use C++ exception handling.
5329         * ada-lang.c: Use C++ exception handling.
5330         * aarch64-tdep.c: Use C++ exception handling.
5331
5332 2019-04-08  Tom Tromey  <tom@tromey.com>
5333
5334         * xml-support.c (gdb_xml_parser::parse): Update.
5335         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5336         * value.c (show_convenience): Update.
5337         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5338         (test_parse_flags_qcs): Update.
5339         * thread.c (thr_try_catch_cmd): Update.
5340         * target.c (target_translate_tls_address): Update.
5341         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5342         (info_frame_command_core, frame_apply_command_count): Update.
5343         * rust-exp.y (rust_lex_exception_test): Update.
5344         * riscv-tdep.c (riscv_print_one_register_info): Update.
5345         * remote.c (remote_target::enable_btrace): Update.
5346         * record-btrace.c (record_btrace_enable_warn): Update.
5347         * python/py-utils.c (gdbpy_convert_exception): Update.
5348         * printcmd.c (do_one_display, print_variable_and_value): Update.
5349         * mi/mi-main.c (mi_print_exception): Update.
5350         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5351         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5352         * linux-nat.c (linux_nat_target::attach): Update.
5353         * linux-fork.c (class scoped_switch_fork_info): Update.
5354         * infrun.c (displaced_step_prepare): Update.
5355         * infcall.c (call_function_by_hand_dummy): Update.
5356         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5357         * gnu-v3-abi.c (print_one_vtable): Update.
5358         * frame.c (get_prev_frame_always): Update.
5359         * f-valprint.c (info_common_command_for_block): Update.
5360         * exec.c (try_open_exec_file): Update.
5361         * exceptions.c (print_exception, exception_print)
5362         (exception_fprintf, exception_print_same): Update.
5363         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5364         * dwarf-index-cache.c (index_cache::store)
5365         (index_cache::lookup_gdb_index): Update.
5366         * darwin-nat.c (maybe_cache_shell): Update.
5367         * cp-valprint.c (cp_print_value_fields): Update.
5368         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5369         (gcc_cplus_symbol_address): Update.
5370         * compile/compile-c-symbols.c (gcc_convert_symbol)
5371         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5372         * common/selftest.c: Update.
5373         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5374         a std::string.
5375         (exception_try_scope_entry, exception_try_scope_exit): Don't
5376         declare.
5377         (struct exception_try_scope): Remove.
5378         (TRY): Don't use exception_try_scope.
5379         (struct gdb_exception): Add constructor, operator=.
5380         <what>: New method.
5381         (struct gdb_exception_RETURN_MASK_ALL)
5382         (struct gdb_exception_RETURN_MASK_ERROR)
5383         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5384         (struct gdb_quit_bad_alloc): Update.
5385         * common/common-exceptions.c (exception_none): Change
5386         initializer.
5387         (struct catcher) <state, exception>: Initialize inline.
5388         <prev>: Remove member.
5389         (current_catcher): Remove.
5390         (catchers): New global.
5391         (exceptions_state_mc_init): Simplify.
5392         (catcher_pop): Remove.
5393         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5394         (try_scope_depth, exception_try_scope_entry)
5395         (exception_try_scope_exit): Remove.
5396         (throw_exception_sjlj): Update.
5397         (exception_messages, exception_messages_size): Remove.
5398         (throw_it): Simplify.
5399         (gdb_exception_sliced_copy): Remove.
5400         (throw_exception_cxx): Update.
5401         * cli/cli-script.c (script_from_file): Update.
5402         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5403         Update.
5404         * ada-valprint.c (ada_val_print): Update.
5405         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5406         (create_excep_cond_exprs): Update.
5407
5408 2019-04-08  Tom Tromey  <tom@tromey.com>
5409
5410         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5411         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5412         (TRY, CATCH, END_CATCH): Remove some definitions.
5413         * common/common-exceptions.c: Don't use GDB_XCPT.
5414         (catcher_list_size): Remove.
5415         (throw_exception, throw_it): Simplify.
5416
5417 2019-04-05  Tom Tromey  <tom@tromey.com>
5418
5419         Revert the header-sorting patch.
5420         * ft32-tdep.c: Revert.
5421         * frv-tdep.c: Revert.
5422         * frv-linux-tdep.c: Revert.
5423         * frame.c: Revert.
5424         * frame-unwind.c: Revert.
5425         * frame-base.c: Revert.
5426         * fork-child.c: Revert.
5427         * findvar.c: Revert.
5428         * findcmd.c: Revert.
5429         * filesystem.c: Revert.
5430         * filename-seen-cache.h: Revert.
5431         * filename-seen-cache.c: Revert.
5432         * fbsd-tdep.c: Revert.
5433         * fbsd-nat.h: Revert.
5434         * fbsd-nat.c: Revert.
5435         * f-valprint.c: Revert.
5436         * f-typeprint.c: Revert.
5437         * f-lang.c: Revert.
5438         * extension.h: Revert.
5439         * extension.c: Revert.
5440         * extension-priv.h: Revert.
5441         * expprint.c: Revert.
5442         * exec.h: Revert.
5443         * exec.c: Revert.
5444         * exceptions.c: Revert.
5445         * event-top.c: Revert.
5446         * event-loop.c: Revert.
5447         * eval.c: Revert.
5448         * elfread.c: Revert.
5449         * dwarf2read.h: Revert.
5450         * dwarf2read.c: Revert.
5451         * dwarf2loc.c: Revert.
5452         * dwarf2expr.h: Revert.
5453         * dwarf2expr.c: Revert.
5454         * dwarf2-frame.c: Revert.
5455         * dwarf2-frame-tailcall.c: Revert.
5456         * dwarf-index-write.h: Revert.
5457         * dwarf-index-write.c: Revert.
5458         * dwarf-index-common.c: Revert.
5459         * dwarf-index-cache.h: Revert.
5460         * dwarf-index-cache.c: Revert.
5461         * dummy-frame.c: Revert.
5462         * dtrace-probe.c: Revert.
5463         * disasm.h: Revert.
5464         * disasm.c: Revert.
5465         * disasm-selftests.c: Revert.
5466         * dictionary.c: Revert.
5467         * dicos-tdep.c: Revert.
5468         * demangle.c: Revert.
5469         * dcache.h: Revert.
5470         * dcache.c: Revert.
5471         * darwin-nat.h: Revert.
5472         * darwin-nat.c: Revert.
5473         * darwin-nat-info.c: Revert.
5474         * d-valprint.c: Revert.
5475         * d-namespace.c: Revert.
5476         * d-lang.c: Revert.
5477         * ctf.c: Revert.
5478         * csky-tdep.c: Revert.
5479         * csky-linux-tdep.c: Revert.
5480         * cris-tdep.c: Revert.
5481         * cris-linux-tdep.c: Revert.
5482         * cp-valprint.c: Revert.
5483         * cp-support.c: Revert.
5484         * cp-namespace.c: Revert.
5485         * cp-abi.c: Revert.
5486         * corelow.c: Revert.
5487         * corefile.c: Revert.
5488         * continuations.c: Revert.
5489         * completer.h: Revert.
5490         * completer.c: Revert.
5491         * complaints.c: Revert.
5492         * coffread.c: Revert.
5493         * coff-pe-read.c: Revert.
5494         * cli-out.h: Revert.
5495         * cli-out.c: Revert.
5496         * charset.c: Revert.
5497         * c-varobj.c: Revert.
5498         * c-valprint.c: Revert.
5499         * c-typeprint.c: Revert.
5500         * c-lang.c: Revert.
5501         * buildsym.c: Revert.
5502         * buildsym-legacy.c: Revert.
5503         * build-id.h: Revert.
5504         * build-id.c: Revert.
5505         * btrace.c: Revert.
5506         * bsd-uthread.c: Revert.
5507         * breakpoint.h: Revert.
5508         * breakpoint.c: Revert.
5509         * break-catch-throw.c: Revert.
5510         * break-catch-syscall.c: Revert.
5511         * break-catch-sig.c: Revert.
5512         * blockframe.c: Revert.
5513         * block.c: Revert.
5514         * bfin-tdep.c: Revert.
5515         * bfin-linux-tdep.c: Revert.
5516         * bfd-target.c: Revert.
5517         * bcache.c: Revert.
5518         * ax-general.c: Revert.
5519         * ax-gdb.h: Revert.
5520         * ax-gdb.c: Revert.
5521         * avr-tdep.c: Revert.
5522         * auxv.c: Revert.
5523         * auto-load.c: Revert.
5524         * arm-wince-tdep.c: Revert.
5525         * arm-tdep.c: Revert.
5526         * arm-symbian-tdep.c: Revert.
5527         * arm-pikeos-tdep.c: Revert.
5528         * arm-obsd-tdep.c: Revert.
5529         * arm-nbsd-tdep.c: Revert.
5530         * arm-nbsd-nat.c: Revert.
5531         * arm-linux-tdep.c: Revert.
5532         * arm-linux-nat.c: Revert.
5533         * arm-fbsd-tdep.c: Revert.
5534         * arm-fbsd-nat.c: Revert.
5535         * arm-bsd-tdep.c: Revert.
5536         * arch-utils.c: Revert.
5537         * arc-tdep.c: Revert.
5538         * arc-newlib-tdep.c: Revert.
5539         * annotate.h: Revert.
5540         * annotate.c: Revert.
5541         * amd64-windows-tdep.c: Revert.
5542         * amd64-windows-nat.c: Revert.
5543         * amd64-tdep.c: Revert.
5544         * amd64-sol2-tdep.c: Revert.
5545         * amd64-obsd-tdep.c: Revert.
5546         * amd64-obsd-nat.c: Revert.
5547         * amd64-nbsd-tdep.c: Revert.
5548         * amd64-nbsd-nat.c: Revert.
5549         * amd64-nat.c: Revert.
5550         * amd64-linux-tdep.c: Revert.
5551         * amd64-linux-nat.c: Revert.
5552         * amd64-fbsd-tdep.c: Revert.
5553         * amd64-fbsd-nat.c: Revert.
5554         * amd64-dicos-tdep.c: Revert.
5555         * amd64-darwin-tdep.c: Revert.
5556         * amd64-bsd-nat.c: Revert.
5557         * alpha-tdep.c: Revert.
5558         * alpha-obsd-tdep.c: Revert.
5559         * alpha-nbsd-tdep.c: Revert.
5560         * alpha-mdebug-tdep.c: Revert.
5561         * alpha-linux-tdep.c: Revert.
5562         * alpha-linux-nat.c: Revert.
5563         * alpha-bsd-tdep.c: Revert.
5564         * alpha-bsd-nat.c: Revert.
5565         * aix-thread.c: Revert.
5566         * agent.c: Revert.
5567         * addrmap.c: Revert.
5568         * ada-varobj.c: Revert.
5569         * ada-valprint.c: Revert.
5570         * ada-typeprint.c: Revert.
5571         * ada-tasks.c: Revert.
5572         * ada-lang.c: Revert.
5573         * aarch64-tdep.c: Revert.
5574         * aarch64-ravenscar-thread.c: Revert.
5575         * aarch64-newlib-tdep.c: Revert.
5576         * aarch64-linux-tdep.c: Revert.
5577         * aarch64-linux-nat.c: Revert.
5578         * aarch64-fbsd-tdep.c: Revert.
5579         * aarch64-fbsd-nat.c: Revert.
5580         * aarch32-linux-nat.c: Revert.
5581
5582 2019-04-05  Tom Tromey  <tom@tromey.com>
5583
5584         * ft32-tdep.c: Sort headers.
5585         * frv-tdep.c: Sort headers.
5586         * frv-linux-tdep.c: Sort headers.
5587         * frame.c: Sort headers.
5588         * frame-unwind.c: Sort headers.
5589         * frame-base.c: Sort headers.
5590         * fork-child.c: Sort headers.
5591         * findvar.c: Sort headers.
5592         * findcmd.c: Sort headers.
5593         * filesystem.c: Sort headers.
5594         * filename-seen-cache.h: Sort headers.
5595         * filename-seen-cache.c: Sort headers.
5596         * fbsd-tdep.c: Sort headers.
5597         * fbsd-nat.h: Sort headers.
5598         * fbsd-nat.c: Sort headers.
5599         * f-valprint.c: Sort headers.
5600         * f-typeprint.c: Sort headers.
5601         * f-lang.c: Sort headers.
5602         * extension.h: Sort headers.
5603         * extension.c: Sort headers.
5604         * extension-priv.h: Sort headers.
5605         * expprint.c: Sort headers.
5606         * exec.h: Sort headers.
5607         * exec.c: Sort headers.
5608         * exceptions.c: Sort headers.
5609         * event-top.c: Sort headers.
5610         * event-loop.c: Sort headers.
5611         * eval.c: Sort headers.
5612         * elfread.c: Sort headers.
5613         * dwarf2read.h: Sort headers.
5614         * dwarf2read.c: Sort headers.
5615         * dwarf2loc.c: Sort headers.
5616         * dwarf2expr.h: Sort headers.
5617         * dwarf2expr.c: Sort headers.
5618         * dwarf2-frame.c: Sort headers.
5619         * dwarf2-frame-tailcall.c: Sort headers.
5620         * dwarf-index-write.h: Sort headers.
5621         * dwarf-index-write.c: Sort headers.
5622         * dwarf-index-common.c: Sort headers.
5623         * dwarf-index-cache.h: Sort headers.
5624         * dwarf-index-cache.c: Sort headers.
5625         * dummy-frame.c: Sort headers.
5626         * dtrace-probe.c: Sort headers.
5627         * disasm.h: Sort headers.
5628         * disasm.c: Sort headers.
5629         * disasm-selftests.c: Sort headers.
5630         * dictionary.c: Sort headers.
5631         * dicos-tdep.c: Sort headers.
5632         * demangle.c: Sort headers.
5633         * dcache.h: Sort headers.
5634         * dcache.c: Sort headers.
5635         * darwin-nat.h: Sort headers.
5636         * darwin-nat.c: Sort headers.
5637         * darwin-nat-info.c: Sort headers.
5638         * d-valprint.c: Sort headers.
5639         * d-namespace.c: Sort headers.
5640         * d-lang.c: Sort headers.
5641         * ctf.c: Sort headers.
5642         * csky-tdep.c: Sort headers.
5643         * csky-linux-tdep.c: Sort headers.
5644         * cris-tdep.c: Sort headers.
5645         * cris-linux-tdep.c: Sort headers.
5646         * cp-valprint.c: Sort headers.
5647         * cp-support.c: Sort headers.
5648         * cp-namespace.c: Sort headers.
5649         * cp-abi.c: Sort headers.
5650         * corelow.c: Sort headers.
5651         * corefile.c: Sort headers.
5652         * continuations.c: Sort headers.
5653         * completer.h: Sort headers.
5654         * completer.c: Sort headers.
5655         * complaints.c: Sort headers.
5656         * coffread.c: Sort headers.
5657         * coff-pe-read.c: Sort headers.
5658         * cli-out.h: Sort headers.
5659         * cli-out.c: Sort headers.
5660         * charset.c: Sort headers.
5661         * c-varobj.c: Sort headers.
5662         * c-valprint.c: Sort headers.
5663         * c-typeprint.c: Sort headers.
5664         * c-lang.c: Sort headers.
5665         * buildsym.c: Sort headers.
5666         * buildsym-legacy.c: Sort headers.
5667         * build-id.h: Sort headers.
5668         * build-id.c: Sort headers.
5669         * btrace.c: Sort headers.
5670         * bsd-uthread.c: Sort headers.
5671         * breakpoint.h: Sort headers.
5672         * breakpoint.c: Sort headers.
5673         * break-catch-throw.c: Sort headers.
5674         * break-catch-syscall.c: Sort headers.
5675         * break-catch-sig.c: Sort headers.
5676         * blockframe.c: Sort headers.
5677         * block.c: Sort headers.
5678         * bfin-tdep.c: Sort headers.
5679         * bfin-linux-tdep.c: Sort headers.
5680         * bfd-target.c: Sort headers.
5681         * bcache.c: Sort headers.
5682         * ax-general.c: Sort headers.
5683         * ax-gdb.h: Sort headers.
5684         * ax-gdb.c: Sort headers.
5685         * avr-tdep.c: Sort headers.
5686         * auxv.c: Sort headers.
5687         * auto-load.c: Sort headers.
5688         * arm-wince-tdep.c: Sort headers.
5689         * arm-tdep.c: Sort headers.
5690         * arm-symbian-tdep.c: Sort headers.
5691         * arm-pikeos-tdep.c: Sort headers.
5692         * arm-obsd-tdep.c: Sort headers.
5693         * arm-nbsd-tdep.c: Sort headers.
5694         * arm-nbsd-nat.c: Sort headers.
5695         * arm-linux-tdep.c: Sort headers.
5696         * arm-linux-nat.c: Sort headers.
5697         * arm-fbsd-tdep.c: Sort headers.
5698         * arm-fbsd-nat.c: Sort headers.
5699         * arm-bsd-tdep.c: Sort headers.
5700         * arch-utils.c: Sort headers.
5701         * arc-tdep.c: Sort headers.
5702         * arc-newlib-tdep.c: Sort headers.
5703         * annotate.h: Sort headers.
5704         * annotate.c: Sort headers.
5705         * amd64-windows-tdep.c: Sort headers.
5706         * amd64-windows-nat.c: Sort headers.
5707         * amd64-tdep.c: Sort headers.
5708         * amd64-sol2-tdep.c: Sort headers.
5709         * amd64-obsd-tdep.c: Sort headers.
5710         * amd64-obsd-nat.c: Sort headers.
5711         * amd64-nbsd-tdep.c: Sort headers.
5712         * amd64-nbsd-nat.c: Sort headers.
5713         * amd64-nat.c: Sort headers.
5714         * amd64-linux-tdep.c: Sort headers.
5715         * amd64-linux-nat.c: Sort headers.
5716         * amd64-fbsd-tdep.c: Sort headers.
5717         * amd64-fbsd-nat.c: Sort headers.
5718         * amd64-dicos-tdep.c: Sort headers.
5719         * amd64-darwin-tdep.c: Sort headers.
5720         * amd64-bsd-nat.c: Sort headers.
5721         * alpha-tdep.c: Sort headers.
5722         * alpha-obsd-tdep.c: Sort headers.
5723         * alpha-nbsd-tdep.c: Sort headers.
5724         * alpha-mdebug-tdep.c: Sort headers.
5725         * alpha-linux-tdep.c: Sort headers.
5726         * alpha-linux-nat.c: Sort headers.
5727         * alpha-bsd-tdep.c: Sort headers.
5728         * alpha-bsd-nat.c: Sort headers.
5729         * aix-thread.c: Sort headers.
5730         * agent.c: Sort headers.
5731         * addrmap.c: Sort headers.
5732         * ada-varobj.c: Sort headers.
5733         * ada-valprint.c: Sort headers.
5734         * ada-typeprint.c: Sort headers.
5735         * ada-tasks.c: Sort headers.
5736         * ada-lang.c: Sort headers.
5737         * aarch64-tdep.c: Sort headers.
5738         * aarch64-ravenscar-thread.c: Sort headers.
5739         * aarch64-newlib-tdep.c: Sort headers.
5740         * aarch64-linux-tdep.c: Sort headers.
5741         * aarch64-linux-nat.c: Sort headers.
5742         * aarch64-fbsd-tdep.c: Sort headers.
5743         * aarch64-fbsd-nat.c: Sort headers.
5744         * aarch32-linux-nat.c: Sort headers.
5745
5746 2019-04-04  Tom Tromey  <tom@tromey.com>
5747
5748         * varobj.c (varobj_create): Update.
5749         * rust-exp.y (struct rust_parser) <update_innermost_block,
5750         lookup_symbol>: New methods.
5751         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5752         Rename.
5753         (rust_parser::rust_lookup_type)
5754         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5755         * printcmd.c (display_command, do_one_display): Update.
5756         * parser-defs.h (struct parser_state) <parser_state>: Add
5757         "tracker" parameter.
5758         (block_tracker): New member.
5759         (class innermost_block_tracker) <innermost_block_tracker>: Add
5760         "types" parameter.
5761         <reset>: Remove method.
5762         (innermost_block): Don't declare.
5763         (null_post_parser): Update.
5764         * parse.c (innermost_block): Remove global.
5765         (write_dollar_variable): Update.
5766         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5767         Remove "tracker_types" parameter.
5768         (parse_expression): Add "tracker" parameter.
5769         (parse_expression_for_completion): Update.
5770         (null_post_parser): Add "tracker" parameter.
5771         * p-exp.y: Update rules.
5772         * m2-exp.y: Update rules.
5773         * language.h (struct language_defn) <la_post_parser>: Add
5774         "tracker" parameter.
5775         * go-exp.y: Update rules.
5776         * f-exp.y: Update rules.
5777         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5778         parameter.
5779         * d-exp.y: Update rules.
5780         * c-exp.y: Update rules.
5781         * breakpoint.c (set_breakpoint_condition): Create an
5782         innermost_block_tracker.
5783         (watch_command_1): Likewise.
5784         * ada-lang.c (resolve): Add "tracker" parameter.
5785         (resolve_subexp): Likewise.
5786         * ada-exp.y (write_var_from_sym): Update.
5787
5788 2019-04-04  Tom Tromey  <tom@tromey.com>
5789
5790         * type-stack.h: New file.
5791         * type-stack.c: New file.
5792         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5793         type-stack.h.
5794         (insert_into_type_stack, insert_type, push_type, push_type_int)
5795         (insert_type_address_space, pop_type, pop_type_int)
5796         (pop_typelist, pop_type_stack, append_type_stack)
5797         (push_type_stack, get_type_stack, push_typelist)
5798         (follow_type_instance_flags, follow_types): Don't declare.
5799         * parse.c (type_stack): Remove global.
5800         (parse_exp_in_context): Update.
5801         (insert_into_type_stack, insert_type, push_type, push_type_int)
5802         (insert_type_address_space, pop_type, pop_type_int)
5803         (pop_typelist, pop_type_stack, append_type_stack)
5804         (push_type_stack, get_type_stack, push_typelist)
5805         (follow_type_instance_flags, follow_types): Remove (moved to
5806         type-stack.c).
5807         * f-exp.y (type_stack): New global.
5808         Update rules.
5809         (push_kind_type, f_parse): Update.
5810         * d-exp.y (type_stack): New global.
5811         Update rules.
5812         (d_parse): Update.
5813         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5814         Update rules.
5815         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5816         (HFILES_NO_SRCDIR): Add type-stack.h.
5817
5818 2019-04-04  Tom Tromey  <tom@tromey.com>
5819
5820         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5821         (rust_parser::convert_ast_to_expression, rust_parse)
5822         (rust_lex_test_completion, rust_lex_tests): Update.
5823         * parser-defs.h (struct expr_completion_state): New.
5824         (struct parser_state) <parser_state>: Add completion parameter.
5825         <mark_struct_expression, mark_completion_tag>: New methods.
5826         <parse_completion, m_completion_state>: New members.
5827         (prefixify_expression, null_post_parser): Update.
5828         (mark_struct_expression, mark_completion_tag): Don't declare.
5829         * parse.c (parse_completion, expout_last_struct)
5830         (expout_tag_completion_type, expout_completion_name): Remove
5831         globals.
5832         (parser_state::mark_struct_expression)
5833         (parser_state::mark_completion_tag): Now methods.
5834         (prefixify_expression): Add last_struct parameter.
5835         (prefixify_subexp): Likewise.
5836         (parse_exp_1): Update.
5837         (parse_exp_in_context): Add cstate parameter.  Update.
5838         (parse_expression_for_completion): Create an
5839         expr_completion_state.
5840         (null_post_parser): Add "completion" parameter.
5841         * p-exp.y: Update rules.
5842         (yylex): Update.
5843         * language.h (struct language_defn) <la_post_parser>: Add
5844         "completing" parameter.
5845         * go-exp.y: Update rules.
5846         (lex_one_token): Update.
5847         * expression.h (parse_completion): Don't declare.
5848         * d-exp.y: Update rules.
5849         (lex_one_token): Update rules.
5850         * c-exp.y: Update rules.
5851         (lex_one_token): Update.
5852         * ada-lang.c (resolve): Add "parse_completion" parameter.
5853         (resolve_subexp): Likewise.
5854         (ada_resolve_function): Likewise.
5855
5856 2019-04-04  Tom Tromey  <tom@tromey.com>
5857
5858         * parser-defs.h (struct parser_state) <start_arglist,
5859         end_arglist>: New methods.
5860         <arglist_len, m_funcall_chain>: New members.
5861         (arglist_len, start_arglist, end_arglist): Don't declare.
5862         * parse.c (arglist_len, funcall_chain): Remove global.
5863         (start_arglist, end_arglist): Remove functions.
5864         (parse_exp_in_context): Update.
5865         * p-exp.y: Update rules.
5866         * m2-exp.y: Update rules.
5867         * go-exp.y: Update rules.
5868         * f-exp.y: Update rules.
5869         * d-exp.y: Update rules.
5870         * c-exp.y: Update rules.
5871
5872 2019-04-04  Tom Tromey  <tom@tromey.com>
5873
5874         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5875         lex_operator, push_back>: New methods.
5876         Update all rules.
5877         (rust_parser::lex_hex, lex_escape): Rename and update.
5878         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5879         (rust_parser::lex_operator): Rename and update.
5880         (rust_parser::lex_number, rustyylex, rustyyerror)
5881         (rust_lex_test_init, rust_lex_test_sequence)
5882         (rust_lex_test_push_back, rust_lex_tests): Update.
5883         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5884         parameter.
5885         <lexptr, prev_lexptr>: New members.
5886         (lexptr, prev_lexptr): Don't declare.
5887         * parse.c (lexptr, prev_lexptr): Remove globals.
5888         (parse_exp_in_context): Update.
5889         * p-exp.y (yylex, yyerror): Update.
5890         * m2-exp.y (parse_number, yylex, yyerror): Update.
5891         * go-exp.y (lex_one_token, yyerror): Update.
5892         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5893         * d-exp.y (lex_one_token, yyerror): Update.
5894         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5895         (lex_one_token, yyerror): Update.
5896         * ada-lex.l (YY_INPUT): Update.
5897         (rewind_to_char): Update.
5898         * ada-exp.y (yyerror): Update.
5899
5900 2019-04-04  Tom Tromey  <tom@tromey.com>
5901
5902         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5903         * parser-defs.h (struct parser_state) <parser_state>: Add new
5904         parameter.
5905         <comma_terminates>: New member.
5906         (comma_terminates): Don't declare global.
5907         * parse.c (comma_terminates): Remove global.
5908         (parse_exp_in_context): Update.
5909         * p-exp.y (yylex): Update.
5910         * m2-exp.y (yylex): Update.
5911         * go-exp.y (lex_one_token): Update.
5912         * f-exp.y (yylex): Update.
5913         * d-exp.y (lex_one_token): Update.
5914         * c-exp.y (lex_one_token): Update.
5915         * ada-lex.l: Update.
5916
5917 2019-04-04  Tom Tromey  <tom@tromey.com>
5918
5919         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5920         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5921         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5922         * parser-defs.h (paren_depth): Don't declare.
5923         * parse.c (paren_depth): Remove global.
5924         (parse_exp_in_context): Update.
5925         * p-exp.y (paren_depth): New global.
5926         (pascal_parse): Initialize it.
5927         * m2-exp.y (paren_depth): New global.
5928         (m2_parse): Initialize it.
5929         * go-exp.y (paren_depth): New global.
5930         (go_parse): Initialize it.
5931         * f-exp.y (paren_depth): New global.
5932         (f_parse): Initialize it.
5933         * d-exp.y (paren_depth): New global.
5934         (d_parse): Initialize it.
5935         * c-exp.y (paren_depth): New global.
5936         (c_parse): Initialize it.
5937         * ada-lex.l (paren_depth): New global.
5938         (lexer_init): Initialize it.
5939
5940 2019-04-04  Tom Tromey  <tom@tromey.com>
5941
5942         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5943         (rust_parser::convert_ast_to_type)
5944         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5945         * parser-defs.h (struct parser_state) <parser_state>: Add
5946         parameters.  Initialize new members.
5947         <expression_context_block, expression_context_pc>: New members.
5948         * parse.c (expression_context_block, expression_context_pc):
5949         Remove globals.
5950         (parse_exp_in_context): Update.
5951         * p-exp.y: Update all rules.
5952         (yylex): Update.
5953         * m2-exp.y: Update all rules.
5954         (yylex): Update.
5955         * go-exp.y (yylex): Update.
5956         * f-exp.y (yylex): Update.
5957         * d-exp.y: Update all rules.
5958         (yylex): Update.
5959         * c-exp.y: Update all rules.
5960         (lex_one_token, classify_name, yylex, c_parse): Update.
5961         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5962
5963 2019-04-04  Tom Tromey  <tom@tromey.com>
5964
5965         * gdbarch.h, gdbarch.c: Rebuild.
5966         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5967         * stap-probe.h:
5968         (struct stap_parse_info): Replace "parser_state" with
5969         "expr_builder".
5970         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5971         (parser_state): New class.
5972         * parse.c (expr_builder): Rename.
5973         (expr_builder::release): Rename.
5974         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5975         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5976         (write_exp_elt_longcst, write_exp_elt_floatcst)
5977         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5978         (write_exp_string_vector, write_exp_bitstring)
5979         (write_exp_msymbol, mark_struct_expression)
5980         (write_dollar_variable)
5981         (insert_type_address_space, increase_expout_size): Replace
5982         "parser_state" with "expr_builder".
5983         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5984         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5985         "parser_state" with "expr_builder".
5986
5987 2019-04-04  Tom Tromey  <tom@tromey.com>
5988
5989         * rust-exp.y: Replace "parse_language" with method call.
5990         * p-exp.y:
5991         (yylex): Replace "parse_language" with method call.
5992         * m2-exp.y:
5993         (yylex): Replace "parse_language" with method call.
5994         * go-exp.y (classify_name): Replace "parse_language" with method
5995         call.
5996         * f-exp.y (yylex): Replace "parse_language" with method call.
5997         * d-exp.y (lex_one_token): Replace "parse_language" with method
5998         call.
5999         * c-exp.y:
6000         (lex_one_token, classify_name, yylex): Replace "parse_language"
6001         with method call.
6002         * ada-exp.y (find_primitive_type, type_char)
6003         (type_system_address): Replace "parse_language" with method call.
6004
6005 2019-04-04  Tom Tromey  <tom@tromey.com>
6006
6007         * rust-exp.y: Replace "parse_gdbarch" with method call.
6008         * parse.c (write_dollar_variable, insert_type_address_space):
6009         Replace "parse_gdbarch" with method call.
6010         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6011         call.
6012         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6013         call.
6014         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6015         "parse_gdbarch" with method call.
6016         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6017         with method call.
6018         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6019         "parse_gdbarch" with method call.
6020         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6021         "parse_gdbarch" with method call.
6022         * c-exp.y (parse_type, parse_number, classify_name): Replace
6023         "parse_gdbarch" with method call.
6024         * ada-lex.l: Replace "parse_gdbarch" with method call.
6025         * ada-exp.y (parse_type, find_primitive_type, type_char)
6026         (type_system_address): Replace "parse_gdbarch" with method call.
6027
6028 2019-04-04  Tom Tromey  <tom@tromey.com>
6029
6030         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6031         * stap-probe.c (stap_parse_argument): Update.
6032         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6033         initial_size parameter.
6034         * rust-exp.y (rust_lex_tests): Update.
6035         * parse.c (parser_state): Update.
6036         (parse_exp_in_context): Update.
6037         * parser-defs.h (struct parser_state) <parser_state>: Remove
6038         "initial_size" parameter.
6039
6040 2019-04-04  Tom Tromey  <tom@tromey.com>
6041
6042         * parser-defs.h (increase_expout_size): Don't declare.
6043         * parse.c (increase_expout_size): Now static.
6044
6045 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6046
6047         * gnu-nat.c (gnu_nat_target::wait): Fix
6048         target_waitstatus_to_string call.
6049
6050 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6051
6052         * eval.c (evaluate_subexp_standard): Handle internal functions
6053         during Fortran function call handling.
6054
6055 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * NEWS: Mention new internal functions.
6058         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6059         (read_base_type): Use dwarf2_init_complex_target_type.
6060         * value.c (creal_internal_fn): New function.
6061         (cimag_internal_fn): New function.
6062         (_initialize_values): Register new internal functions.
6063
6064 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6065
6066         * infrun.c (stop_all_threads): If debug_infrun, always
6067         trace the wait status after wait_one, using
6068         target_waitstatus_to_string and target_pid_to_str.
6069         (handle_inferior_event): Replace various trace of
6070         wait status kind by a single trace.
6071         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6072         wait status kind image by target_waitstatus_to_string.
6073         * target/waitstatus.c (target_waitstatus_to_string): Fix
6074         obsolete comment.
6075
6076 2019-04-01  Tom Tromey  <tromey@adacore.com>
6077
6078         PR symtab/23331:
6079         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6080
6081 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6082             Pedro Alves  <palves@redhat.com>
6083
6084         * top.c (quit_force): Call 'finalize_values'.
6085         * value.c (finalize_values): New function.
6086         * value.h (finalize_values): Declare.
6087
6088 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6089
6090         * NEWS: Announce $_gdb_major and $_gdb_minor.
6091
6092         * top.c (init_gdb_version_vars): New function.
6093         (gdb_init): Call init_gdb_version_vars.
6094
6095 2019-03-29  Tom Tromey  <tromey@adacore.com>
6096
6097         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6098         help text.  Remove dead code.
6099
6100 2019-03-29  Keith Seitz  <keiths@redhat.com>
6101
6102         From Siddhesh Poyarekar:
6103         * f-lang.h (f77_get_upperbound): Return LONGEST.
6104         (f77_get_lowerbound): Likewise.
6105         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6106         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6107         print them.
6108         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6109         plongest to format print it.
6110         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6111         (f77_get_upperbound): Likewise.
6112         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6113         LOWER_BOUND to LONGEST.
6114         (f77_create_arrayprint_offset_tbl): Likewise.
6115
6116 2019-03-29  Keith Seitz  <keiths@redhat.com>
6117
6118         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6119         %s/pulongest for TYPE_LENGTH instead of %d in format
6120         strings.
6121         * ada-typerint.c (ada_print_type): Likewise.
6122         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6123         * compile/compile-c-support.c (generate_register_struct): Likewise.
6124         * gdbtypes.c (recursive_dump_type): Likewise.
6125         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6126         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6127         instead of %d in format strings.
6128         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6129         to std::min to ULONGEST.
6130         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6131         instead of %d in format strings.
6132         * tracepoint.c (info_scope_command): Likewise.
6133         * typeprint.c (print_offset_data::update)
6134         (print_offset_data::finish): Likewise.
6135         * xtensa-tdep.c (xtensa_store_return_value)
6136         (xtensa_push_dummy_call): Likewise.
6137
6138 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6139
6140         * windows-nat.c (display_selector): Fixed format specifications
6141         for 64-bit Cygwin.
6142
6143 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6144
6145         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6146
6147 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6148
6149         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6150         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6151         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6152         (nios2_linux_init_abi): Install it.
6153
6154 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6155
6156         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6157
6158 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6159
6160         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6161
6162 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6163             Tom Tromey  <tromey@adacore.com>
6164
6165         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6166
6167 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6168
6169         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6170         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6171         method to compute the bounds of range types. Also print "[evaluated]"
6172         if the bounds' values come from a dynamic evaluation.
6173
6174 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6175
6176         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6177         whitespace when pretty printing is on.
6178
6179 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6180
6181         * ppc-linux-nat.c: Add include.
6182
6183 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6184
6185         * NEWS: Mention AArch64 Pointer Authentication.
6186
6187 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6188
6189         * arm-linux-nat.c: Add include.
6190
6191 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6192
6193         * source-cache.c (source_cache::get_source_lines): Re-read
6194         fullname after calling open_source_file.
6195
6196 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6197
6198         * NEWS: Mention TLS support for FreeBSD.
6199
6200 2019-03-25  Tom Tromey  <tromey@adacore.com>
6201
6202         * minsyms.c (BUNCH_SIZE): Update comment.
6203         (~minimal_symbol_reader): Remove old comment.
6204         (compact_minimal_symbols): Update comment.
6205         (minimal_symbol_reader::install): Remove old comment.  Update
6206         other comments.
6207
6208 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6209
6210         * s390-linux-nat.c: Add include.
6211
6212 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6213
6214         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6215         Call linux_get_hwcap.
6216         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6217         Likewise.
6218         (aarch64_linux_get_hwcap): Remove function.
6219         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6220         declaration.
6221         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6222         linux_get_hwcap.
6223         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6224         * linux-tdep.c (linux_get_hwcap): Add function.
6225         (linux_get_hwcap2): Likewise.
6226         * linux-tdep.h (linux_get_hwcap): Add declaration.
6227         (linux_get_hwcap2): Likewise.
6228         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6229         (ppc_linux_get_hwcap2): Likewise.
6230         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6231         linux_get_hwcap.
6232         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6233         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6234         (ppc_linux_nat_target::read_description): Likewise.
6235         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6236         * s390-linux-nat.c: Likewise.
6237         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6238
6239 2019-03-24  Tom Tromey  <tom@tromey.com>
6240
6241         * ada-lang.c (standard_lookup): Simplify initialization.
6242         (ada_lookup_symbol_nonlocal): Simplify return.
6243         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6244         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6245         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6246         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6247         initialization.
6248         * solib.c (solib_global_lookup): Simplify.
6249         * symtab.c (null_block_symbol): Remove.
6250         (symbol_cache_lookup): Simplify returns.
6251         (lookup_language_this): Simplify returns.
6252         (lookup_symbol_aux): Simplify return.
6253         (lookup_local_symbol): Simplify returns.
6254         (lookup_global_symbol_from_objfile): Simplify return.
6255         (lookup_symbol_in_objfile_symtabs)
6256         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6257         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6258         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6259         * cp-namespace.c (cp_lookup_bare_symbol)
6260         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6261         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6262         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6263         (cp_lookup_symbol_via_imports): Simplify initialization.
6264         (find_symbol_in_baseclass): Likewise.
6265         * symtab.h (null_block_symbol): Remove.
6266         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6267         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6268         (d_lookup_symbol_module): Likewise.
6269         (find_symbol_in_baseclass): Simplify initialization.
6270
6271 2019-03-24  Tom Tromey  <tom@tromey.com>
6272
6273         * expression.h: Don't include symtab.h.
6274         (struct block): Forward declare.
6275
6276 2019-03-24  Tom Tromey  <tom@tromey.com>
6277
6278         * c-exp.y (typebase): Remove casts.
6279         * gdbtypes.c (lookup_unsigned_typename, )
6280         (lookup_signed_typename): Remove cast.
6281         * eval.c (parse_to_comma_and_eval): Remove cast.
6282         * parse.c (write_dollar_variable): Remove cast.
6283         * block.h (struct block) <superblock>: Now const.
6284         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6285         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6286         (map_block): Make "block" const.
6287         * symfile.h (struct quick_symbol_functions)
6288         <map_matching_symbols>: Constify block argument to "callback".
6289         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6290         const.
6291         (find_pc_sect_compunit_symtab): Make "b" const.
6292         (find_symbol_at_address): Likewise.
6293         (search_symbols): Likewise.
6294         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6295         (dw2_debug_names_lookup_symbol): Likewise.
6296         (dw2_map_matching_symbols): Update.
6297         * p-valprint.c (pascal_val_print): Remove "block".
6298         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6299         (aux_add_nonlocal_symbols): Make "block" const.
6300         (resolve_subexp): Remove cast.
6301         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6302         const.
6303         (iterate_over_file_blocks): Likewise.
6304         * f-exp.y (%union) <bval>: Remove.
6305         * coffread.c (patch_opaque_types): Make "b" const.
6306         * spu-tdep.c (spu_catch_start): Make "block" const.
6307         * c-valprint.c (print_unpacked_pointer): Remove "block".
6308         * symmisc.c (dump_symtab_1): Make "b" const.
6309         (block_depth): Make "block" const.
6310         * d-exp.y (%union) <bval>: Remove.
6311         * cp-support.h (cp_lookup_rtti_type): Update.
6312         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6313         * psymtab.c (psym_lookup_symbol): Make "block" const.
6314         (maintenance_check_psymtabs): Make "b" const.
6315         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6316         (enumerate_locals, enumerate_args): Update.
6317         * python/py-symtab.c (stpy_global_block): Make "block" const.
6318         (stpy_static_block): Likewise.
6319         * inline-frame.c (block_starting_point_at): Make "new_block"
6320         const.
6321         * block.c (find_block_in_blockvector): Make return type const.
6322         (blockvector_for_pc_sect): Make "b" const.
6323         (find_block_in_blockvector): Make "b" const.
6324
6325 2019-03-23  Tom Tromey  <tom@tromey.com>
6326
6327         * varobj.c (varobj_create): Update.
6328         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6329         * printcmd.c (display_command, do_one_display): Don't reset
6330         innermost_block.
6331         * parser-defs.h (enum innermost_block_tracker_type): Move to
6332         expression.h.
6333         (innermost_block): Update comment.
6334         * parse.c (parse_exp_1): Add tracker_types parameter.
6335         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6336         tracker_types parameter.  Reset innermost_block.
6337         (parse_exp_in_context): Remove.
6338         (parse_expression_for_completion): Update.
6339         * objfiles.c (~objfile): Don't reset expression_context_block or
6340         innermost_block.
6341         * expression.h (enum innermost_block_tracker_type): Move from
6342         parser-defs.h.
6343         (parse_exp_1): Add tracker_types parameter.
6344         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6345         reset innermost_block.
6346
6347 2019-03-23  Tom Tromey  <tom@tromey.com>
6348
6349         * objfiles.h: Include bcache.h.
6350
6351 2019-03-23  Tom Tromey  <tom@tromey.com>
6352
6353         * linespec.c (get_current_search_block): Use
6354         scoped_restore_current_language.
6355         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6356
6357 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6358             Jiong Wang  <jiong.wang@arm.com>
6359
6360         * aarch64-linux-tdep.c
6361         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6362         section.
6363         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6364
6365 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6366             Jiong Wang  <jiong.wang@arm.com>
6367
6368         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6369         instructions.
6370         (aarch64_analyze_prologue_test): Add PACIASP test.
6371         (aarch64_prologue_prev_register): Unmask PC value.
6372
6373 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6374             Jiong Wang  <jiong.wang@arm.com>
6375
6376         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6377         (aarch64_dwarf2_prev_register): Unmask PC value.
6378         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6379         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6380         DW_CFA_AARCH64_negate_ra_state.
6381         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6382
6383 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6384             Jiong Wang  <jiong.wang@arm.com>
6385
6386         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6387         registers.
6388         (aarch64_pseudo_register_name): Likewise.
6389         (aarch64_pseudo_register_type): Likewise.
6390         (aarch64_pseudo_register_reggroup_p): Likewise.
6391         (aarch64_gdbarch_init): Add pauth registers.
6392         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6393         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6394         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6395         (struct gdbarch_tdep): Add regnum for ra_state.
6396
6397 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6398             Jiong Wang  <jiong.wang@arm.com>
6399
6400         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6401
6402 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6403             Jiong Wang  <jiong.wang@arm.com>
6404
6405         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6406         function.
6407         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6408         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6409         (aarch64_gdbarch_init): Add puth registers.
6410         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6411         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6412         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6413
6414 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6415             Jiong Wang  <jiong.wang@arm.com>
6416
6417         * aarch64-linux-nat.c
6418         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6419         * aarch64-linux-tdep.c
6420         (aarch64_linux_core_read_description): Likewise.
6421         (aarch64_linux_get_hwcap): New function.
6422         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6423         (aarch64_linux_get_hwcap): New declaration.
6424
6425 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6426             Jiong Wang  <jiong.wang@arm.com>
6427
6428         * aarch64-linux-nat.c
6429         (aarch64_linux_nat_target::read_description): Add pauth param.
6430         * aarch64-linux-tdep.c
6431         (aarch64_linux_core_read_description): Likewise.
6432         * aarch64-tdep.c (struct target_desc): Add in pauth.
6433         (aarch64_read_description): Add pauth param.
6434         (aarch64_gdbarch_init): Likewise.
6435         * aarch64-tdep.h (aarch64_read_description): Likewise.
6436         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6437         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6438         * features/Makefile: Add new files.
6439         * features/aarch64-pauth.c: New file.
6440         * features/aarch64-pauth.xml: New file.
6441
6442 2019-03-20  Tom Tromey  <tromey@adacore.com>
6443
6444         * infrun.c (handle_inferior_event): Rename from
6445         handle_inferior_event_1.  Create a scoped_value_mark.
6446         (handle_inferior_event): Remove.
6447
6448 2019-03-19  Tom Tromey  <tromey@adacore.com>
6449
6450         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6451         * infrun.h (print_stop_event): Add "displays" parameter.
6452         * infrun.c (print_stop_event): Add "displays" parameter.
6453
6454 2019-03-19  Pedro Alves  <palves@redhat.com>
6455
6456         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6457         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6458         to -1.  Fix TABs vs spaces.
6459         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6460         * tui/tui-out.h (tui_ui_out) Add intro comments.
6461         <m_line, m_start_of_line>: In-class initialize, and add describing
6462         comment.
6463
6464 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6465
6466         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6467         variable names.
6468         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6469
6470 2019-03-18  Pedro Alves  <palves@redhat.com>
6471             Eli Zaretskii <eliz@gnu.org>
6472
6473         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6474         m_line and m_start_of_line.
6475
6476 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6477
6478         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6479         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6480         it returns a newline.  This fixes a regression in TU mode, whereby
6481         the next line is output on the same screen line as the user input.
6482
6483 2019-03-18  Tom Tromey  <tromey@adacore.com>
6484
6485         * minsyms.c (minimal_symbol_reader::install): Remove call to
6486         obstack_blank.
6487
6488 2019-03-18  Pedro Alves  <palves@redhat.com>
6489
6490         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6491         New globals.
6492         (apply_style): New, factored out from ...
6493         (apply_ansi_escape): ... this.  Handle reverse video mode.
6494         (tui_set_reverse_mode): New function.
6495         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6496         * tui/tui-winsource.c (tui_show_source_line): Use
6497         tui_set_reverse_mode instead of setting A_STANDOUT.
6498         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6499         New setter methods.
6500
6501 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6502
6503         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6504         Handle tabs.
6505
6506 2019-03-18  Tom Tromey  <tromey@adacore.com>
6507
6508         * ada-lang.c (empty_array): Add "high" parameter.
6509         (ada_evaluate_subexp): Update.
6510
6511 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6512
6513         * unittests/string_view-selftests.c: Define
6514         _initialize_string_view_selftests unconditionally.
6515
6516 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6517
6518         PR gdb/24350
6519         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6520
6521 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6522
6523         PR gdb/24351
6524         * windows-nat.c (display_selector): Fix format specifiers.
6525
6526 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6527
6528         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6529         tui_refill_source_window instead of tui_refresh_win, to update the
6530         current execution line.  This fixes redisplay of the current line
6531         when stepping through the code with "next" or "step".
6532
6533 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6534
6535         * source-cache.c (source_cache::get_source_lines): Call
6536         find_source_lines to initialize s->nlines.  This fixes vertical
6537         scrolling of TUI source window when the DOWN arrow is pressed.
6538
6539 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6540
6541         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6542         linux-thread-db.c (_initialize_thread_db): Likewise.
6543
6544 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6545
6546         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6547         wclrtoeol in tui_show_source_line".  This reverts changes made in
6548         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6549
6550 2019-03-15  Tom Tromey  <tom@tromey.com>
6551
6552         * symtab.h (struct minimal_symbol): Derive from
6553         general_symbol_info.
6554         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6555         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6556         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6557         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6558         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6559         (MSYMBOL_SEARCH_NAME): Update.
6560         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6561         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6562         * minsyms.c (minimal_symbol_reader::record_full): Update.
6563
6564 2019-03-15  Tom Tromey  <tom@tromey.com>
6565
6566         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6567
6568 2019-03-15  Tom Tromey  <tom@tromey.com>
6569
6570         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6571         unique_xmalloc_ptr.
6572         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6573         Update.
6574         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6575         (build_minimal_symbol_hash_tables)
6576         (minimal_symbol_reader::install): Update.
6577
6578 2019-03-15  Tom Tromey  <tom@tromey.com>
6579
6580         * symtab.c (create_demangled_names_hash): Update.
6581         (symbol_set_names): Update.
6582         * objfiles.h (struct objfile_per_bfd_storage)
6583         <demangled_names_hash>: Now an htab_up.
6584         * objfiles.c (objfile_per_bfd_storage): Simplify.
6585
6586 2019-03-15  Tom Tromey  <tom@tromey.com>
6587
6588         * objfiles.h (struct objfile_per_bfd_storage): Declare
6589         destructor.
6590         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6591         New.
6592         (get_objfile_bfd_data): Use new.  Don't initialize
6593         language_of_main.
6594         (free_objfile_per_bfd_storage): Remove.
6595         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6596
6597 2019-03-15  Tom Tromey  <tom@tromey.com>
6598
6599         * symfile.c (reread_symbols): Update.
6600         * objfiles.c (objfile::objfile): Update.
6601         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6602         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6603         comment.
6604         (minimal_symbol_reader::install): Update.
6605         (terminate_minimal_symbol_table): Remove.
6606         * jit.c (jit_object_close_impl): Update.
6607
6608 2019-03-15  Tom Tromey  <tom@tromey.com>
6609
6610         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6611         initializations.
6612
6613 2019-03-15  Tom Tromey  <tom@tromey.com>
6614
6615         * objfiles.h (struct objfile_per_bfd_storage)
6616         <demangled_hash_languages>: Now a bitset.
6617         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6618         (lookup_minimal_symbol): Update.
6619
6620 2019-03-15  Tom Tromey  <tom@tromey.com>
6621
6622         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6623         Don't return the symbol.
6624         * coffread.c (record_minimal_symbol): Use record_full.
6625
6626 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6627
6628         The MS-Windows port of ncurses fails to switch to a color pair if
6629         one or both of the colors are the implicit default colors.  This
6630         change records the default colors when TUI is initialized, and
6631         then specifies them explicitly when a color pair uses the default
6632         colors.  This allows color styling in TUI mode on MS-Windows.
6633
6634         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6635         ncurses_norm_attr.
6636         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6637         colors in ncurses_norm_attr.
6638         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6639         "none", replace it with the default color recorded in
6640         ncurses_norm_attr.
6641
6642 2019-03-14  Tom Tromey  <tromey@adacore.com>
6643
6644         * source-cache.h (class source_cache) <get_source_lines>: Return
6645         std::string.
6646         * source-cache.c (source_cache::extract_lines): Handle case where
6647         first_pos==npos.  Return std::string.
6648         (source_cache::get_source_lines): Update.
6649
6650 2019-03-14  Tom Tromey  <tromey@adacore.com>
6651
6652         * NEWS: Add item for "style sources" commands.
6653         * source-cache.c (source_cache::get_source_lines): Check
6654         source_styling.
6655         * cli/cli-style.c (source_styling): New global.
6656         (_initialize_cli_style): Add "style sources" commands.
6657         (show_style_sources): New function.
6658         * cli/cli-style.h (source_styling): Declare.
6659
6660 2019-03-14  Pedro Alves  <palves@redhat.com>
6661             Tom Tromey  <tromey@adacore.com>
6662
6663         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6664         * tui/tui-winsource.c (tui_refill_source_window): New function,
6665         from...
6666         (tui_horizontal_source_scroll): ... here.  Move some logic.
6667         * cli/cli-style.c (set_style_enabled): Notify new observable.
6668         * tui/tui-hooks.c (tui_redisplay_source): New function.
6669         (tui_attach_detach_observers): Attach or detach
6670         tui_redisplay_source.
6671         * observable.h (source_styling_changed): New observable.
6672         * observable.c: Define source_styling_changed observable.
6673
6674 2019-03-13  Tom Tromey  <tromey@adacore.com>
6675
6676         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6677         (i386_gnu_nat_target::store_registers): Update.
6678         * target-debug.h (target_debug_print_std_string): New macro.
6679         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6680         * windows-tdep.c (display_one_tib): Update.
6681         * tui/tui-stack.c (tui_make_status_line): Update.
6682         * top.c (print_inferior_quit_action): Update.
6683         * thread.c (thr_try_catch_cmd): Update.
6684         (add_thread_with_info): Update.
6685         (thread_target_id_str): Update.
6686         (thr_try_catch_cmd): Update.
6687         (thread_command): Update.
6688         (thread_find_command): Update.
6689         * record-btrace.c (record_btrace_target::info_record)
6690         (record_btrace_resume_thread, record_btrace_target::resume)
6691         (record_btrace_cancel_resume, record_btrace_step_thread)
6692         (record_btrace_target::wait, record_btrace_target::wait)
6693         (record_btrace_target::wait, record_btrace_target::stop): Update.
6694         * progspace.c (print_program_space): Update.
6695         * process-stratum-target.c
6696         (process_stratum_target::thread_address_space): Update.
6697         * linux-fork.c (linux_fork_mourn_inferior)
6698         (detach_checkpoint_command, info_checkpoints_command)
6699         (linux_fork_context): Update.
6700         (linux_fork_detach): Update.
6701         (class scoped_switch_fork_info): Update.
6702         (delete_checkpoint_command): Update.
6703         * infrun.c (follow_fork_inferior): Update.
6704         (follow_fork_inferior): Update.
6705         (proceed_after_vfork_done): Update.
6706         (handle_vfork_child_exec_or_exit): Update.
6707         (follow_exec): Update.
6708         (displaced_step_prepare_throw): Update.
6709         (displaced_step_restore): Update.
6710         (start_step_over): Update.
6711         (resume_1): Update.
6712         (clear_proceed_status_thread): Update.
6713         (proceed): Update.
6714         (print_target_wait_results): Update.
6715         (do_target_wait): Update.
6716         (context_switch): Update.
6717         (stop_all_threads): Update.
6718         (restart_threads): Update.
6719         (finish_step_over): Update.
6720         (handle_signal_stop): Update.
6721         (switch_back_to_stepped_thread): Update.
6722         (keep_going_pass_signal): Update.
6723         (print_exited_reason): Update.
6724         (normal_stop): Update.
6725         * inferior.c (inferior_pid_to_str): Change return type.
6726         (print_selected_inferior): Update.
6727         (add_inferior): Update.
6728         (detach_inferior): Update.
6729         * dummy-frame.c (fprint_dummy_frames): Update.
6730         * dcache.c (dcache_info_1): Update.
6731         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6732         (btrace_fetch, btrace_clear): Update.
6733         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6734         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6735         type.
6736         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6737         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6738         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6739         * gdbarch.c, gdbarch.h: Rebuild.
6740         * gdbarch.sh (core_pid_to_str): Change return type.
6741         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6742         return type.
6743         (windows_nat_target::pid_to_str): Change return type.
6744         (windows_delete_thread): Update.
6745         (windows_nat_target::attach): Update.
6746         (windows_nat_target::files_info): Update.
6747         * target-delegates.c: Rebuild.
6748         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6749         return type.
6750         (sol_thread_target::pid_to_str): Change return type.
6751         * remote.c (class remote_target) <pid_to_str>: Change return
6752         type.
6753         (remote_target::pid_to_str): Change return type.
6754         (extended_remote_target::attach, remote_target::remote_stop_ns)
6755         (remote_target::remote_notif_remove_queued_reply)
6756         (remote_target::push_stop_reply, remote_target::disable_btrace):
6757         Update.
6758         (extended_remote_target::attach): Update.
6759         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6760         type.
6761         (gdbsim_target::pid_to_str): Change return type.
6762         * ravenscar-thread.c (struct ravenscar_thread_target)
6763         <pid_to_str>: Change return type.
6764         (ravenscar_thread_target::pid_to_str): Change return type.
6765         * procfs.c (class procfs_target) <pid_to_str>: Change return
6766         type.
6767         (procfs_target::pid_to_str): Change return type.
6768         (procfs_target::attach): Update.
6769         (procfs_target::detach): Update.
6770         (procfs_target::fetch_registers): Update.
6771         (procfs_target::store_registers): Update.
6772         (procfs_target::wait): Update.
6773         (procfs_target::files_info): Update.
6774         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6775         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6776         return type.
6777         (nto_procfs_target::pid_to_str): Change return type.
6778         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6779         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6780         return type.
6781         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6782         (exit_lwp): Update.
6783         (attach_proc_task_lwp_callback, get_detach_signal)
6784         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6785         (linux_nat_target::resume, wait_lwp, stop_callback)
6786         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6787         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6788         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6789         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6790         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6791         type.
6792         (inf_ptrace_target::attach): Update.
6793         (inf_ptrace_target::files_info): Update.
6794         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6795         type.
6796         (go32_nat_target::pid_to_str): Change return type.
6797         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6798         (gnu_nat_target::wait): Update.
6799         (gnu_nat_target::wait): Update.
6800         (gnu_nat_target::resume): Update.
6801         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6802         (fbsd_nat_target::wait): Update.
6803         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6804         type.
6805         (darwin_nat_target::attach): Update.
6806         * corelow.c (class core_target) <pid_to_str>: Change return type.
6807         (core_target::pid_to_str): Change return type.
6808         * target.c (normal_pid_to_str): Change return type.
6809         (default_pid_to_str): Likewise.
6810         (target_pid_to_str): Change return type.
6811         (target_translate_tls_address): Update.
6812         (target_announce_detach): Update.
6813         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6814         return type.
6815         (bsd_uthread_target::pid_to_str): Change return type.
6816         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6817         type.
6818         (bsd_kvm_target::pid_to_str): Change return type.
6819         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6820         return type.
6821         (aix_thread_target::pid_to_str): Change return type.
6822         * target.h (struct target_ops) <pid_to_str>: Change return type.
6823         (target_pid_to_str, normal_pid_to_str): Likewise.
6824         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6825         type.
6826         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6827         type.
6828         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6829         return type.
6830         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6831         type.
6832         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6833         type.
6834         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6835         return type.
6836
6837 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6838
6839         * NEWS: Mention that the new default MI version is 3.  Mention
6840         changes to the output of commands and events that deal with
6841         multi-location breakpoints.
6842         * breakpoint.c: Include "mi/mi-out.h".
6843         (print_one_breakpoint): Change output syntax if using MI version
6844         >= 3.
6845         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6846         New.
6847         (mi_multi_location_breakpoint_output_fixed): New.
6848         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6849         (mi_cmd_fix_multi_location_breakpoint_output): New.
6850         (mi_multi_location_breakpoint_output_fixed): New.
6851         * mi/mi-cmds.c (mi_cmds): Register command
6852         -fix-multi-location-breakpoint-output.
6853         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6854         interpreter "mi".
6855
6856 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6857
6858         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6859         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6860         instantiate mi_ui_out based on interpreter name.
6861         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6862         * mi/mi-main.c (mi_load_progress): Likewise.
6863
6864 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6865
6866         * NEWS: Combine separate "New targets" sections for 8.3.
6867
6868 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6869
6870         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6871         (ppcfbsd_init_abi): Install gdbarch
6872         "fetch_tls_load_module_address" and "get_thread_local_address"
6873         methods.
6874
6875 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6876
6877         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6878         (riscv_fbsd_init_abi): Install gdbarch
6879         "fetch_tls_load_module_address" and "get_thread_local_address"
6880         methods.
6881
6882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6883
6884         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6885         (i386fbsd_init_abi): Install gdbarch
6886         "fetch_tls_load_module_address" and "get_thread_local_address"
6887         methods.
6888
6889 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6890
6891         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6892         (amd64fbsd_init_abi): Install gdbarch
6893         "fetch_tls_load_module_address" and "get_thread_local_address"
6894         methods.
6895
6896 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6897
6898         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6899         (struct fbsd_pspace_data): New type.
6900         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6901         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6902         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6903         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6904         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6905
6906 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6907
6908         * gdbtypes.c (lookup_struct_elt): New function.
6909         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6910         * gdbtypes.h (struct struct_elt): New type.
6911         (lookup_struct_elt): New prototype.
6912
6913 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6914
6915         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6916         remove disabled code block.
6917
6918 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6919
6920         * gdbarch.sh (get_thread_local_address): New method.
6921         * gdbarch.h, gdbarch.c: Regenerate.
6922         * target.c (target_translate_tls_address): Use
6923         gdbarch_get_thread_local_address if present instead of
6924         target::get_thread_local_address.
6925
6926 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6927
6928         * target.h (target::get_thread_local_address): Update comment.
6929
6930 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6931
6932         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6933         objfile->separate_debug_objfile_backlink if not NULL.
6934
6935 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6936
6937         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6938         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6939         (amd64bsd_store_inferior_registers): Likewise.
6940         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6941         Enable segment base registers.
6942         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6943         PT_GETFSBASE and PT_GETGSBASE.
6944         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6945         PT_SETGSBASE.
6946         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6947         segment base registers.
6948         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6949
6950 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6951
6952         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6953         Update calls to i386_target_description to add 'segments'
6954         parameter.
6955         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6956         add segment base registers.
6957         * arch/i386.c (i386_create_target_description): Add 'segments'
6958         parameter to enable segment base registers.
6959         * arch/i386.h (i386_create_target_description): Likewise.
6960         * features/i386/32bit-segments.xml: New file.
6961         * features/i386/32bit-segments.c: Generate.
6962         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6963         call to i386_target_description to add 'segments' parameter.
6964         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6965         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6966         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6967         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6968         if feature is present.
6969         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6970         Add 'segments' parameter to call to i386_target_description.
6971         (i386_target_description): Add 'segments' parameter to enable
6972         segment base registers.
6973         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6974         to call to i386_target_description.
6975         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6976         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6977         Define I386_NUM_REGS.
6978         (i386_target_description): Add 'segments' parameter to enable
6979         segment base registers.
6980
6981 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6982
6983         PR/24325
6984         * source-cache.c: #undef open and close, to avoid unresolved
6985         externals during linking.
6986
6987 2019-03-12  Tom Tromey  <tromey@adacore.com>
6988
6989         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6990         const.  Add initializers.
6991         (_initialize_remote): Don't initialize ptid globals.
6992
6993 2019-03-12  Pedro Alves  <palves@redhat.com>
6994
6995         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6996
6997 2019-03-12  Pedro Alves  <palves@redhat.com>
6998
6999         * cp-name-parser.y (main): Remove unused 'len' variable.
7000
7001 2019-03-12  Tom Tromey  <tromey@adacore.com>
7002
7003         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7004         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7005
7006 2019-03-12  Tom Tromey  <tromey@adacore.com>
7007
7008         * linux-nat.c (iterate_over_lwps): Update.
7009         (stop_callback): Remove parameter.
7010         (stop_wait_callback, detach_callback, resume_set_callback)
7011         (select_singlestep_lwp_callback, set_ignore_sigint)
7012         (status_callback, resumed_callback, resume_clear_callback)
7013         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7014         data parameter.
7015         (linux_nat_target::detach, linux_nat_target::resume)
7016         (linux_stop_and_wait_all_lwps, select_event_lwp)
7017         (linux_nat_filter_event, linux_nat_wait_1)
7018         (linux_nat_target::kill, linux_nat_target::stop)
7019         (linux_nat_target::stop): Update.
7020         (linux_nat_resume_callback): Change type.
7021         (resume_stopped_resumed_lwps, count_events_callback)
7022         (select_event_lwp_callback): Likewise.
7023         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7024         * arm-linux-nat.c (struct update_registers_data): Remove.
7025         (update_registers_callback): Change type.
7026         (arm_linux_insert_hw_breakpoint1): Update.
7027         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7028         parameter.
7029         (x86_linux_dr_set_addr): Update.
7030         (x86_linux_dr_set_control): Update.
7031         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7032         (iterate_over_lwps): Use gdb::function_view.
7033         * nat/aarch64-linux-hw-point.c (struct
7034         aarch64_dr_update_callback_param): Remove.
7035         (debug_reg_change_callback): Change type.
7036         (aarch64_notify_debug_reg_change): Update.
7037         * s390-linux-nat.c (s390_refresh_per_info): Update.
7038
7039 2019-03-11  Tom Tromey  <tromey@adacore.com>
7040
7041         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7042         redundant assignment to "this_cu".
7043
7044 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7045
7046         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7047
7048 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7049
7050         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7051         from...
7052         (rank_one_type): ... this.
7053
7054 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7055
7056         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7057         from...
7058         (rank_one_type): ... this.
7059
7060 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7061
7062         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7063         from...
7064         (rank_one_type): ... this.
7065
7066 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7067
7068         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7069         from...
7070         (rank_one_type): ... this.
7071
7072 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7073
7074         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7075         from...
7076         (rank_one_type): ... this.
7077
7078 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7079
7080         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7081         from...
7082         (rank_one_type): ... this.
7083
7084 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7085
7086         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7087         from...
7088         (rank_one_type): ... this.
7089
7090 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7091
7092         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7093         from...
7094         (rank_one_type): ... this.
7095
7096 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7097
7098         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7099         from...
7100         (rank_one_type): ... this.
7101
7102 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7103
7104         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7105         from...
7106         (rank_one_type): ... this.
7107
7108 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7109
7110         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7111         from...
7112         (rank_one_type): ... this.
7113
7114 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7115
7116         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7117         from...
7118         (rank_one_type): ... this.
7119
7120 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7121
7122         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7123         inferior-events' shows the example events.
7124
7125 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7126
7127         Support styling on native MS-Windows console
7128
7129         PR/24315
7130         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7131         on MS-Windows if $TERM is not defined.
7132
7133         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7134
7135         * posix-hdep.c (gdb_console_fputs):
7136         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7137         functions.
7138         * ui-file.h (gdb_console_fputs): Add prototype.
7139
7140         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7141         back to fputs only if the former returns zero.
7142
7143 2019-03-07  Tom Tromey  <tom@tromey.com>
7144
7145         * symmisc.c (print_symbol_bcache_statistics): Update.
7146         (print_objfile_statistics): Update.
7147         * symfile.c (allocate_symtab): Update.
7148         * stabsread.c: Don't include bcache.h.
7149         * psymtab.h (struct psymbol_bcache): Don't declare.
7150         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7151         (psymbol_bcache_init, psymbol_bcache_free)
7152         (psymbol_bcache_get_bcache): Don't declare.
7153         * psymtab.c (struct psymbol_bcache): Remove.
7154         (psymtab_storage::psymtab_storage): Update.
7155         (psymtab_storage::~psymtab_storage): Update.
7156         (psymbol_bcache_init, psymbol_bcache_free)
7157         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7158         (add_psymbol_to_bcache): Update.
7159         (allocate_psymtab): Update.
7160         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7161         macro_cache>: No longer pointers.
7162         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7163         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7164         * macrotab.c (macro_bcache): Update.
7165         * macroexp.c: Don't include bcache.h.
7166         * gdbtypes.c (check_types_worklist): Update.
7167         (types_deeply_equal): Remove TRY/CATCH.  Update.
7168         * elfread.c (elf_symtab_read): Update.
7169         * dwarf2read.c: Don't include bcache.h.
7170         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7171         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7172         (print_bcache_statistics, bcache_memory_used): Don't declare.
7173         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7174         methods.  Rename all data members.
7175         * bcache.c (struct bcache): Move to bcache.h.
7176         (bcache::expand_hash_table): Rename from expand_hash_table.
7177         (bcache): Remove.
7178         (bcache::insert): Rename from bcache_full.
7179         (bcache::compare): Rename from bcache_compare.
7180         (bcache_xmalloc): Remove.
7181         (bcache::~bcache): Rename from bcache_xfree.
7182         (bcache::print_statistics): Rename from print_bcache_statistics.
7183         (bcache::memory_used): Rename from bcache_memory_used.
7184
7185 2019-03-07  Pedro Alves  <palves@redhat.com>
7186
7187         * infrun.c (normal_stop): Also check for
7188         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7189
7190 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7191
7192         * f-lang.c (value_from_host_double): Moved to...
7193         * value.c (value_from_host_double): ...here.
7194         * value.h (value_from_host_double): Declare.
7195         * guile/scm-math.c (vlscm_convert_typed_number): Use
7196         value_from_host_double.
7197         (vlscm_convert_number): Likewise.
7198         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7199         * python/py-value.c (convert_value_from_python): Likewise.
7200
7201 2019-03-06  Tom Tromey  <tom@tromey.com>
7202
7203         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7204
7205 2019-03-06  Tom Tromey  <tom@tromey.com>
7206
7207         * utils.h (free_current_contents): Don't declare.
7208         * utils.c (free_current_contents): Remove.
7209
7210 2019-03-06  Tom Tromey  <tom@tromey.com>
7211
7212         * top.c (quit_force): Update.
7213         * main.c (captured_command_loop): Update.
7214         * common/new-op.c (operator new): Update.
7215         * common/common-exceptions.c (struct catcher)
7216         <save_cleanup_chain>: Remove member.
7217         (exceptions_state_mc_init): Update.
7218         (exception_try_scope_entry): Return nullptr.
7219         (exception_try_scope_exit, exception_rethrow)
7220         (throw_exception_sjlj, throw_exception_cxx): Update.
7221         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7222         (all_cleanups, do_cleanups, discard_cleanups)
7223         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7224         (restore_cleanups, restore_final_cleanups): Don't declare.
7225         (do_final_cleanups): Remove parameter.
7226         * common/cleanups.c (cleanup_chain, make_cleanup)
7227         (make_cleanup_dtor, all_cleanups, do_cleanups)
7228         (discard_my_cleanups, discard_cleanups)
7229         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7230         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7231         (null_cleanup): Remove.
7232         (do_final_cleanups): Remove parameter.
7233
7234 2019-03-06  Tom Tromey  <tom@tromey.com>
7235
7236         * remote.c (remote_target::remote_parse_stop_reply): Use
7237         unique_xmalloc_ptr.
7238
7239 2019-03-06  Tom Tromey  <tom@tromey.com>
7240
7241         * stabsread.c (struct stabs_field_info): Rename from field_info.
7242         <list, fnlist>: Add initializers.
7243         <obstack>: New member.
7244         (read_member_functions, read_struct_fields, read_baseclasses):
7245         Allocate on obstack.  Don't use cleanups.
7246         (read_one_struct_field, read_member_functions, read_struct_fields)
7247         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7248         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7249         (read_struct_type): Update.
7250
7251 2019-03-06  Tom Tromey  <tom@tromey.com>
7252
7253         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7254         * common/filestuff.h (make_cleanup_close): Don't declare.
7255         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7256         Remove.
7257
7258 2019-03-06  Tom Tromey  <tom@tromey.com>
7259
7260         * solib-aix.c: Use make_scope_exit.
7261
7262 2019-03-06  Tom Tromey  <tom@tromey.com>
7263
7264         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7265         Use make_scope_exit.
7266
7267 2019-03-06  Tom Tromey  <tom@tromey.com>
7268
7269         * solib-svr4.c (disable_probes_interface): Remove parameter.
7270         (svr4_handle_solib_event): Use make_scope_exit.
7271
7272 2019-03-06  Tom Tromey  <tom@tromey.com>
7273
7274         * remote.c (struct stop_reply_deleter): Remove.
7275         (stop_reply_up): Update.
7276         (struct stop_reply): Derive from notif_event.  Don't typedef.
7277         <regcache>: Now a std::vector.
7278         (stop_reply_xfree): Remove.
7279         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7280         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7281         (remote_target::discard_pending_stop_replies): Use delete.
7282         (remote_target::remote_parse_stop_reply): Update.
7283         (remote_target::process_stop_reply): Update.
7284         * remote-notif.h (struct notif_event): Add virtual destructor.
7285         Remove "dtr" member.
7286         (struct notif_client) <alloc_event>: Return a unique_ptr.
7287         (notif_event_xfree): Don't declare.
7288         (notif_event_up): New typedef.
7289         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7290         (notif_event_xfree, do_notif_event_xfree): Remove.
7291         (remote_notif_state_xfree): Update.
7292
7293 2019-03-06  Tom Tromey  <tom@tromey.com>
7294
7295         * infrun.c (displaced_step_clear_cleanup): Now a
7296         forward_scope_exit type.
7297         (displaced_step_prepare_throw): Update.
7298         (displaced_step_fixup): Update.
7299
7300 2019-03-06  Tom Tromey  <tom@tromey.com>
7301
7302         * inferior.h (class inferior): Update comment.
7303         * gdbthread.h (class thread_info): Update comment.
7304
7305 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7306             Tom Tromey  <tom@tromey.com>
7307
7308         * stabsread.h (struct stab_section_list): Remove.
7309         (coffstab_build_psymtabs): Update.
7310         * dbxread.c (symbuf_sections): Now a std::vector.
7311         (sect_idx): New global.
7312         (fill_symbuf): Update.
7313         (coffstab_build_psymtabs): Change type of stabsects parameter.
7314         Update.
7315         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7316         std::vector.
7317         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7318         (coff_locate_sections): Update.
7319         (coff_symfile_read): Remove cleanups.  Update.
7320         (init_stringtab): Add storage parameter.
7321         (free_stringtab, free_stringtab_cleanup): Remove.
7322         (init_lineno): Add storage parameter.
7323         (free_linetab, free_linetab_cleanup): Remove.
7324
7325 2019-03-06  Pedro Alves  <palves@redhat.com>
7326
7327         * linux-fork.c (fork_info::clobber_regs): Delete.
7328         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7329         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7330         comment.  Adjust.
7331         (scoped_switch_fork_info::scoped_switch_fork_info)
7332         (checkpoint_command, linux_fork_context): Adjust
7333         fork_save_infrun_state calls.
7334
7335 2019-03-06  Pedro Alves  <palves@redhat.com>
7336
7337         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7338         (inf_has_multiple_threads): Return 'bool' and rewrite using
7339         inferior_info::threads().
7340
7341 2019-03-06  Pedro Alves  <palves@redhat.com>
7342
7343         * linux-fork.c: Include <list>.
7344         (fork_list): Now a std::list instance.
7345         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7346         (forks_exist_p, find_last_fork): Adjust.
7347         (new_fork): Delete.
7348         (one_fork_p): New.
7349         (add_fork): Adjust.
7350         (free_fork): Delete, folded into fork_info::~fork_info().
7351         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7352         Adjust.
7353         (init_fork_list): Delete.
7354         (linux_fork_killall, linux_fork_mourn_inferior)
7355         (linux_fork_detach, info_checkpoints_command): Adjust.
7356         (_initialize_linux_fork): No longer call init_fork_list.
7357
7358 2019-03-06  Pedro Alves  <palves@redhat.com>
7359
7360         * linux-fork.c (new_fork): New, split out of ...
7361         (add_fork): ... this.  Return void.  Move "first fork" special
7362         case from here, to ...
7363         (checkpoint_command): ... here.
7364         * linux-linux.h (add_fork): Return void.
7365
7366 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7367
7368         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7369
7370 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7371             Chris January  <chris.january@arm.com>
7372             David Lecomber  <david.lecomber@arm.com>
7373
7374         * f-exp.y: New token, UNOP_INTRINSIC.
7375         (exp): New pattern using UNOP_INTRINSIC token.
7376         (f77_keywords): Add 'abs' keyword.
7377         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7378         (value_from_host_double): New function.
7379         (evaluate_subexp_f): Support UNOP_ABS.
7380
7381 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7382
7383         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7384         types.
7385
7386 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7387
7388         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7389         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7390         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7391
7392 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7393
7394         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7395
7396 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7397             Chris January  <chris.january@arm.com>
7398
7399         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7400         * f-exp.y: Define 'KIND' token.
7401         (exp): New pattern for KIND expressions.
7402         (ptype): Handle types with a kind extension.
7403         (direct_abs_decl): Extend to spot kind extensions.
7404         (f77_keywords): Add 'kind' to the list.
7405         (push_kind_type): New function.
7406         (convert_to_kind_type): New function.
7407         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7408         * parse.c (operator_length_standard): Likewise.
7409         * parser-defs.h (enum type_pieces): Add tp_kind.
7410         * std-operator.def: Add UNOP_KIND.
7411
7412 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7413
7414         * f-exp.y (f_parse): Set yydebug.
7415
7416 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7417
7418         * f-lang.c (evaluate_subexp_f): New function.
7419         (exp_descriptor_f): New global.
7420         (f_language_defn): Use exp_descriptor_f instead of
7421         exp_descriptor_standard.
7422
7423 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7424
7425         * f-exp.y (struct token): Add comments.
7426         (dot_ops): Remove uppercase versions and the end marker.
7427         (f77_keywords): Likewise.
7428         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7429         entries in the dot_ops array are case insensitive, and use
7430         strncasecmp to compare strings.  Also some whitespace cleanup in
7431         this area.  Similar for the f77_keywords array, except entries in
7432         this list might be case sensitive.
7433
7434 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7435
7436         * f-exp.y (struct f77_boolean_val): Add comments.
7437         (boolean_values): Remove uppercase versions, and end marker.
7438         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7439         and use strncasecmp to achieve case insensitivity.  Additionally,
7440         perform whitespace cleanup around this code.
7441
7442 2019-03-06  Tom Tromey  <tromey@adacore.com>
7443
7444         * remote-sim.c (gdbsim_target_open): Use result of
7445         gdb_argv::release.
7446
7447 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7448         Dirk Schubert  <dirk.schubert@arm.com>
7449         Chris January  <chris.january@arm.com>
7450
7451         * eval.c (evaluate_subexp_standard): Call Fortran argument
7452         wrapping logic.
7453         * f-lang.c (struct value): A value which can be passed into a
7454         Fortran function call.
7455         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7456         where appropriate.
7457         (struct type): Value ready for a Fortran function call.
7458         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7459         is needed.
7460         * f-lang.h (fortran_argument_convert): Declaration.
7461         (fortran_preserve_arg_pointer): Declaration.
7462         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7463
7464 2019-03-05  Tom Tromey  <tromey@adacore.com>
7465
7466         * python/py-prettyprint.c (print_string_repr): Remove #if.
7467         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7468
7469 2019-03-05  Tom Tromey  <tromey@adacore.com>
7470
7471         * target.c (the_dummy_target): Move later.  Change type to
7472         "dummy_target".
7473         (initialize_targets): Don't initialize the_dummy_target.
7474
7475 2019-03-05  Tom Tromey  <tromey@adacore.com>
7476
7477         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7478         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7479
7480 2019-03-05  Tom Tromey  <tromey@adacore.com>
7481
7482         * windows-nat.c (windows_nat_target::attach)
7483         (windows_nat_target::detach): Don't call gdb_flush.
7484         * valprint.c (generic_val_print, val_print, val_print_string):
7485         Don't call gdb_flush.
7486         * utils.c (defaulted_query): Don't call gdb_flush.
7487         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7488         * target.c (target_announce_detach): Don't call gdb_flush.
7489         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7490         * remote.c (extended_remote_target::attach): Don't call
7491         gdb_flush.
7492         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7493         * printcmd.c (do_examine): Don't call gdb_flush.
7494         (info_display_command): Don't call gdb_flush.
7495         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7496         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7497         * memattr.c (info_mem_command): Don't call gdb_flush.
7498         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7499         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7500         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7501         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7502         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7503         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7504         (gnu_nat_target::detach): Don't call gdb_flush.
7505         * f-valprint.c (f_val_print): Don't call gdb_flush.
7506         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7507         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7508         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7509         gdb_flush.
7510         * c-valprint.c (c_val_print): Don't call gdb_flush.
7511         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7512
7513 2019-03-05  Tom Tromey  <tromey@adacore.com>
7514
7515         * varobj.c (update_dynamic_varobj_children): Update.
7516         (install_default_visualizer): Use reset, not release.
7517         * value.c (set_internalvar): Update.
7518         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7519         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7520         ATTRIBUTE_UNUSED_RESULT.
7521
7522 2019-03-05  Tom Tromey  <tromey@adacore.com>
7523
7524         * remote.c (class scoped_remote_fd) <release>: Add
7525         ATTRIBUTE_UNUSED_RESULT.
7526
7527 2019-03-05  Tom Tromey  <tromey@adacore.com>
7528
7529         * macroexp.c (struct macro_buffer) <release>: Add
7530         ATTRIBUTE_UNUSED_RESULT.
7531
7532 2019-03-05  Tom Tromey  <tromey@adacore.com>
7533
7534         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7535         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7536         ATTRIBUTE_UNUSED_RESULT.
7537
7538 2019-03-05  Tom Tromey  <tromey@adacore.com>
7539
7540         * common/scoped_fd.h (class scoped_fd) <release>: Add
7541         ATTRIBUTE_UNUSED_RESULT.
7542
7543 2019-03-05  Tom Tromey  <tromey@adacore.com>
7544
7545         * parser-defs.h (struct parser_state) <release>: Add
7546         ATTRIBUTE_UNUSED_RESULT.
7547
7548 2019-03-05  Tom Tromey  <tromey@adacore.com>
7549
7550         * utils.h (class gdb_argv) <release>: Add
7551         ATTRIBUTE_UNUSED_RESULT.
7552         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7553
7554 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7555
7556         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7557         for-loop range, to avoid compiler warnings.
7558
7559         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7560         avoid compiler warnings about unused variables.
7561
7562         * NEWS: Mention end of support for native debugging on MS-Windows
7563         before XP.
7564
7565         PR gdb/24292
7566         * common/netstuff.c:
7567         * gdbserver/gdbreplay.c
7568         * gdbserver/remote-utils.c:
7569         * ser-tcp.c:
7570         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7571         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7572         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7573         'getaddrinfo' and 'freeaddrinfo' were not available before
7574         Windows XP, and mingw.org's MinGW headers by default define
7575         _WIN32_WINNT to 0x500.
7576
7577 2019-03-01  Gary Benson <gbenson@redhat.com>
7578
7579         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7580
7581 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7582             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7583
7584         PR gdb/8527
7585         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7586         set_sigint_trap, clear_sigint_trap.
7587
7588 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7589
7590         * target.c (target_detach): Clear the regcache and the
7591         frame cache.
7592
7593 2019-02-27  Pedro Alves  <palves@redhat.com>
7594
7595         * utils.c (set_screen_size): When we cap the height/width sizes,
7596         tweak the corresponding command variable to show "unlimited":
7597
7598 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7599             Pedro Alves  <palves@redhat.com>
7600
7601         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7602         before calling rl_set_screen_size.
7603
7604 2019-02-27  Tom Tromey  <tromey@adacore.com>
7605
7606         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7607         define.
7608         * python/py-value.c: Remove Python 2.4 workaround.
7609         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7610         workaround.
7611         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7612         Python 2.4 workaround.
7613         * python/python-internal.h: Remove Python 2.4 comment.
7614         (Py_ssize_t): Don't define.
7615         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7616         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7617         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7618         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7619         * python/python.c (do_start_initialization): Remove Python 2.4
7620         workaround.
7621         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7622         (print_children): Remove Python 2.4 workaround.
7623         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7624         workaround.
7625         (CHARBUFFERPROC_NAME): Remove.
7626         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7627         Python 2.4 workaround.
7628
7629 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7630
7631         * NEWS: Note minimum Python version.
7632
7633 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7634
7635         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7636         code from these functions.  Remove corresponding ifdefs.  Use
7637         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7638         Remove gotos and target of gotos.
7639         (infpy_search_memory): Likewise.
7640
7641 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7642
7643         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7644         (hppa_gdbarch_init): Don't register deleted functions with
7645         gdbarch.
7646
7647 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7648
7649         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7650         (h8300_unwind_sp): Delete.
7651         (h8300_dummy_id): Delete.
7652         (h8300_gdbarch_init): Don't register deleted functions with
7653         gdbarch.
7654
7655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7656
7657         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7658         (ft32_unwind_pc): Delete.
7659         (ft32_unwind_sp): Delete.
7660         (ft32_gdbarch_init): Don't register deleted functions with
7661         gdbarch.
7662
7663 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7664
7665         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7666         (frv_unwind_pc): Delete.
7667         (frv_unwind_sp): Delete.
7668         (frv_gdbarch_init): Don't register deleted functions with
7669         gdbarch.
7670
7671 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7672
7673         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7674         (riscv_unwind_pc): Delete.
7675         (riscv_unwind_sp): Delete.
7676         (riscv_gdbarch_init): Don't register deleted functions with
7677         gdbarch.
7678
7679 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7680
7681         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7682         (csky_unwind_pc): Delete.
7683         (csky_unwind_sp): Delete.
7684         (csky_gdbarch_init): Don't register deleted functions with
7685         gdbarch.
7686
7687 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7688
7689         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7690         (cris_unwind_pc): Delete.
7691         (cris_unwind_sp): Delete.
7692         (cris_gdbarch_init): Don't register deleted functions with
7693         gdbarch.
7694
7695 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7696
7697         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7698         (bfin_unwind_pc): Delete.
7699         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7700
7701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7702
7703         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7704         (arm_unwind_pc): Delete.
7705         (arm_unwind_sp): Delete.
7706         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7707
7708 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7709
7710         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7711         (arc_unwind_pc): Delete.
7712         (arc_unwind_sp): Delete.
7713         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7714
7715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7716
7717         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7718         (alpha_unwind_pc): Delete.
7719         (alpha_gdbarch_init): Don't register deleted functions with
7720         gdbarch.
7721
7722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7723
7724         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7725         (aarch64_unwind_pc): Delete.
7726         (aarch64_unwind_sp): Delete.
7727         (aarch64_gdbarch_init): Don't register deleted functions with
7728         gdbarch.
7729
7730 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7731
7732         * gdbtypes.c (type_align): Don't consider static members when
7733         computing structure alignment.
7734
7735 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7736
7737         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7738         return 0 for other types.
7739         * arch-utils.c (default_type_align): Always return 0.
7740         * gdbarch.h: Regenerate.
7741         * gdbarch.sh (type_align): Extend comment.
7742         * gdbtypes.c (type_align): Add additional comments, always call
7743         gdbarch_type_align before applying the default rules.
7744         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7745         generic code will then apply a suitable default.
7746         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7747         types, return 0 for other types.
7748
7749 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7750
7751         * NEWS: Create a new section for the next release branch.
7752         Rename the section of the current branch, now that it has
7753         been cut.
7754
7755 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7756
7757         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7758         * version.in: Bump version to 8.3.50.DATE-git.
7759
7760 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7761
7762         * aix-thread.c (ptid_cmp): Remove unused variable.
7763         (get_signaled_thread): Likewise.
7764         (store_regs_user_thread): Likewise.
7765         (store_regs_kernel_thread): Likewise.
7766         (fetch_regs_kernel_thread): Remove shadowed variable.
7767
7768 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7769
7770         * features/riscv/32bit-cpu.xml: Add register numbers.
7771         * features/riscv/32bit-fpu.c: Regenerate.
7772         * features/riscv/32bit-fpu.xml: Add register numbers.
7773         * features/riscv/64bit-cpu.xml: Add register numbers.
7774         * features/riscv/64bit-fpu.c: Regenerate.
7775         * features/riscv/64bit-fpu.xml: Add register numbers.
7776
7777 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7778
7779         * NEWS: Mention two argument form of gdb.Value constructor.
7780         * python/py-value.c (convert_buffer_and_type_to_value): New
7781         function.
7782         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7783         Add support for handling an optional second argument.  Call
7784         convert_buffer_and_type_to_value as appropriate.
7785         * python/python-internal.h (Py_buffer_deleter): New struct.
7786         (Py_buffer_up): New typedef.
7787
7788 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7789
7790         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7791         instead of releasing ownership.
7792
7793 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7794
7795         * dwarf2read.c (open_and_init_dwp_file): Call
7796         elf_numsections instead of bfd_count_sections to initialize
7797         dwp_file->num_sections.
7798
7799 2019-02-25  Tom Tromey  <tromey@adacore.com>
7800
7801         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7802
7803 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7804
7805         * gcore.in: Add '--readnever' option when invoking GDB.
7806
7807 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7808
7809         * MAINTAINERS: Update my email address.
7810
7811 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7812
7813         * build-id.c (build_id_to_debug_bfd_1): New function.
7814         (build_id_to_debug_bfd): Look for separate debug file in
7815         sysroot.
7816
7817 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7818
7819         * gdbarch.sh: Update the copyright year range that is placed into
7820         generated files.
7821
7822 2019-02-22  Keith Seitz  <keiths@redhat.com>
7823
7824         PR symtab/23853
7825         * linespec.c (create_sals_line_offset): Search for the default
7826         symtab's filename instead of its fullname.
7827
7828 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7829
7830         * NEWS: Update style defaults.
7831
7832 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7833
7834         * main.c (captured_main_1): Disable styling in batch mode.
7835
7836 2019-02-20  Tom Tromey  <tom@tromey.com>
7837
7838         * symtab.c (symtab_symbol_info): Fix typos.
7839
7840 2019-02-20  Tom Tromey  <tromey@adacore.com>
7841
7842         * findcmd.c (_initialize_mem_search): Use upper case for
7843         metasyntactic variables.
7844
7845 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7846
7847         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7848         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7849
7850 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7851
7852         * top.h (source_file_name): Change to std::string.
7853         * top.c (source_file_name): Likewise.
7854         (command_line_input): Adjust.
7855         * cli/cli-script.c (script_from_file): Adjust.
7856
7857 2019-02-19  Tom Tromey  <tromey@adacore.com>
7858
7859         * ravenscar-thread.c
7860         (ravenscar_thread_target::update_thread_list): Don't call
7861         ada_build_task_list.
7862         * ada-lang.h (ada_build_task_list): Don't declare.
7863         * ada-tasks.c (struct ada_tasks_inferior_data)
7864         <task_list_valid_p>: Now bool.
7865         (read_known_tasks, ada_task_list_changed)
7866         (ada_tasks_invalidate_inferior_data): Update.
7867         (read_known_tasks_array): Return bool.
7868         (read_known_tasks_list): Likewise.
7869         (read_known_tasks): Return void.
7870         (ada_build_task_list): Now static.
7871
7872 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7873
7874         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7875         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7876
7877 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7878
7879         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7880         variant for ada_tasks_pspace_data_handle and
7881         ada_tasks_inferior_data_handle.
7882         (ada_tasks_pspace_data_cleanup): New function.
7883         (ada_tasks_inferior_data_cleanup): New function.
7884
7885 2019-02-17  Tom Tromey  <tom@tromey.com>
7886
7887         * macrotab.h (macro_source_fullname): Return a std::string.
7888         * macrotab.c (macro_include, check_for_redefinition)
7889         (macro_undef, macro_lookup_definition, foreach_macro)
7890         (foreach_macro_in_scope): Update.
7891         (macro_source_fullname): Return a std::string.
7892         * macrocmd.c (show_pp_source_pos): Update.
7893
7894 2019-02-17  Tom Tromey  <tom@tromey.com>
7895
7896         * macrocmd.c (show_pp_source_pos): Style the file names.
7897
7898 2019-02-17  Tom Tromey  <tom@tromey.com>
7899
7900         PR tui/24197:
7901         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7902
7903 2019-02-17  Tom Tromey  <tom@tromey.com>
7904
7905         * ada-lang.c (user_select_syms): Use filtered printing.
7906         * utils.c (wrap_style): New global.
7907         (desired_style): Remove.
7908         (emit_style_escape): Add stream parameter.
7909         (set_output_style, reset_terminal_style, prompt_for_continue):
7910         Update.
7911         (flush_wrap_buffer): Only flush gdb_stdout.
7912         (wrap_here): Set wrap_style.
7913         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7914         treat escape sequences as a character.  Change when wrap buffer is
7915         flushed.
7916         (fputs_styled): Do not set the output style when the default is
7917         requested.
7918         * ui-style.h (struct ui_file_style) <is_default>: New method.
7919         * source.c (print_source_lines_base): Emit escape sequences in one
7920         piece.
7921
7922 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7923
7924         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7925         integers and enumeration types.
7926
7927 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7928
7929         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7930         instead of lookup_symbol_in_language
7931         (do_exact_match): New function.
7932         (ada_get_symbol_name_matcher): Return do_exact_match when
7933         doing a verbatim match.
7934
7935 2019-02-15  Tom Tromey  <tromey@adacore.com>
7936
7937         * ravenscar-thread.c (ravenscar_thread_target::resume)
7938         (ravenscar_thread_target::wait): Special case wildcard requests.
7939
7940 2019-02-15  Tom Tromey  <tromey@adacore.com>
7941
7942         * ravenscar-thread.c (base_ptid): Remove.
7943         (struct ravenscar_thread_target) <close>: New method.
7944         <m_base_ptid>: New member.
7945         <update_inferior_ptid, active_task, task_is_currently_active,
7946         runtime_initialized>: Declare methods.
7947         <ravenscar_thread_target>: Add constructor.
7948         (ravenscar_thread_target::task_is_currently_active)
7949         (ravenscar_thread_target::update_inferior_ptid)
7950         (ravenscar_runtime_initialized): Rename.  Now methods.
7951         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7952         (ravenscar_thread_target::update_thread_list): Update.
7953         (ravenscar_thread_target::active_task): Now method.
7954         (ravenscar_thread_target::store_registers)
7955         (ravenscar_thread_target::prepare_to_store)
7956         (ravenscar_thread_target::prepare_to_store)
7957         (ravenscar_thread_target::mourn_inferior): Update.
7958         (ravenscar_inferior_created): Use "new" to create target.
7959         (ravenscar_thread_target::get_ada_task_ptid): Update.
7960         (_initialize_ravenscar): Don't initialize base_ptid.
7961         (ravenscar_ops): Remove global.
7962
7963 2019-02-15  Tom Tromey  <tromey@adacore.com>
7964
7965         * target.h (push_target): Declare new overload.
7966         * target.c (push_target): New overload, taking an rvalue reference.
7967         * remote.c (remote_target::open_1): Use push_target overload.
7968         * corelow.c (core_target_open): Use push_target overload.
7969
7970 2019-02-15  Tom Tromey  <tromey@adacore.com>
7971
7972         * ravenscar-thread.c (is_ravenscar_task)
7973         (ravenscar_task_is_currently_active): Return bool.
7974         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7975         (_initialize_ravenscar): Remove "(void)".
7976         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7977         Return bool.
7978
7979 2019-02-15  Tom Tromey  <tromey@adacore.com>
7980
7981         * ravenscar-thread.c (ravenscar_runtime_initializer)
7982         (has_ravenscar_runtime, get_running_thread_id)
7983         (ravenscar_thread_target::resume): Fix indentation.
7984
7985 2019-02-15  Tom Tromey  <tromey@adacore.com>
7986
7987         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7988         from ravenscar_arch_ops.
7989         (sparc_ravenscar_ops::fetch_registers)
7990         (sparc_ravenscar_ops::store_registers): Now methods.
7991         (sparc_ravenscar_prepare_to_store): Remove.
7992         (sparc_ravenscar_ops): Redefine.
7993         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7994         methods and destructor.  Remove members.
7995         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7996         (ravenscar_thread_target::store_registers)
7997         (ravenscar_thread_target::prepare_to_store): Update.
7998         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7999         Remove.
8000         (struct ppc_ravenscar_powerpc_ops): Derive from
8001         ravenscar_arch_ops.
8002         (ppc_ravenscar_powerpc_ops::fetch_registers)
8003         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8004         (ppc_ravenscar_powerpc_ops): Redefine.
8005         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8006         (ppc_ravenscar_e500_ops::fetch_registers)
8007         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8008         (ppc_ravenscar_e500_ops): Redefine.
8009         * aarch64-ravenscar-thread.c
8010         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8011         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8012         (aarch64_ravenscar_fetch_registers)
8013         (aarch64_ravenscar_store_registers): Now methods.
8014         (aarch64_ravenscar_ops): Redefine.
8015
8016 2019-02-15  Tom Tromey  <tromey@adacore.com>
8017
8018         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8019         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8020         (ravenscar_thread_target::stopped_by_watchpoint)
8021         (ravenscar_thread_target::stopped_data_address)
8022         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8023
8024 2019-02-15  Tom Tromey  <tromey@adacore.com>
8025
8026         * ravenscar-thread.c: Fix some typos.
8027
8028 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8029             Tom Tromey  <tromey@adacore.com>
8030
8031         * ada-lang.c (ada_exception_sal): Change addr_string to a
8032         std::string.
8033         (create_ada_exception_catchpoint): Update.
8034
8035 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8036             Tom Tromey  <tromey@adacore.com>
8037
8038         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8039         (bp_location_ops): Remove.
8040         (base_breakpoint_allocate_location): Update.
8041         (free_bp_location): Update.
8042         * ada-lang.c (class ada_catchpoint_location)
8043         <ada_catchpoint_location>: Remove ops parameter.
8044         (ada_catchpoint_location_dtor): Remove.
8045         (ada_catchpoint_location_ops): Remove.
8046         (allocate_location_exception): Update.
8047         * breakpoint.h (struct bp_location_ops): Remove.
8048         (class bp_location) <bp_location>: Remove bp_location_ops
8049         parameter.
8050         <~bp_location>: Add destructor.
8051         <ops>: Remove.
8052
8053 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8054             Pedro Alves  <palves@redhat.com>
8055
8056         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8057         'PATH_MAX'.
8058
8059 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8060             Samuel Thibault  <samuel.thibault@gnu.org>
8061             Thomas Schwinge  <thomas@codesourcery.com>
8062
8063         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8064         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8065
8066 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8067
8068         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8069         (check_empty): Use "const char *".
8070
8071         * gnu-nat.c (gnu_nat_target::detach): Instead of
8072         'detach_inferior (pid)' call
8073         'detach_inferior (find_inferior_pid (pid))'.
8074
8075         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8076         'nat/fork-inferior.o'.
8077         * gnu-nat.c: #include "nat/fork-inferior.h".
8078
8079         * gnu-nat.c (gnu_nat_target::detach): Instead of
8080         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8081         * gnu-nat.h: #include "inf-child.h".
8082         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8083         'i386_gnu_nat_target::fetch_registers'.
8084         (gnu_store_registers): Rename/move to
8085         'i386_gnu_nat_target::store_registers'.
8086
8087         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8088         * gnu-nat.h (mach_thread_info): New function.
8089         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8090
8091         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8092
8093 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8094
8095         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8096
8097 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8098
8099         * windows-nat.c (windows_add_thread): Add new parameter
8100         "main_thread_p" with default value set to false.  Update
8101         function documentation as well as all callers.
8102         (windows_delete_thread): Likewise.
8103         (fake_create_process): Update call to windows_add_thread.
8104         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8105         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8106         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8107         call to windows_delete_thread.
8108
8109 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8110
8111         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8112
8113 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8114
8115         * symfile.c (find_separate_debug_file): Use canonical path of
8116         sysroot with child_path instead of gdb_sysroot if it is valid.
8117
8118 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8119
8120         * symfile.c (find_separate_debug_file): Use child_path to
8121         determine if an object file is under a sysroot.
8122
8123 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8124
8125         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8126         unittests/child-path-selftests.c.
8127         * common/pathstuff.c (child_path): New function.
8128         * common/pathstuff.h (child_path): New prototype.
8129         * unittests/child-path-selftests.c: New file.
8130
8131 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8132
8133         * symfile.c (find_separate_debug_file): Look for separate debug
8134         files in debug directories under the sysroot.
8135
8136 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8137
8138         * symtab.h (struct minimal_symbol data_p): New const method.
8139         (struct minimal_symbol text_p): Likewise.
8140         * symtab.c (output_source_filename): Use file name style
8141         to print file name.
8142         (print_symbol_info): Likewise.
8143         (print_msymbol_info): Use address style to print addresses.
8144         Use function name style to print executable text symbols.
8145         (expand_symtab_containing_pc): Use data_p.
8146         (find_pc_sect_compunit_symtab): Likewise.
8147
8148 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8149
8150         * breakpoint.c (describe_other_breakpoints): Use address style
8151         to print addresses.
8152         (say_where): Likewise.
8153
8154 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8155
8156         * ada-typeprint.c (print_func_type): Print function name
8157         style to print function name.
8158         * c-typeprint.c (c_print_type_1): Likewise.
8159
8160 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8161
8162         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8163         for execve.
8164
8165 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8166
8167         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8168         type_stack.
8169
8170 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8171
8172         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8173         TYPE_CODE_REF types.
8174
8175 2019-02-08  Jim Wilson  <jimw@sifive.com>
8176
8177         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8178         (riscv_linux_fregset): New.
8179         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8180
8181 2019-02-07  Tom Tromey  <tom@tromey.com>
8182
8183         * thread.c (thread_cancel_execution_command): Update.
8184         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8185         methods.
8186         (struct thread_fsm_ops): Remove.
8187         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8188         (thread_fsm_should_stop, thread_fsm_return_value)
8189         (thread_fsm_set_finished, thread_fsm_finished_p)
8190         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8191         Don't declare.
8192         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8193         * infrun.c (clear_proceed_status_thread)
8194         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8195         (print_stop_event): Update.
8196         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8197         Add constructor.
8198         (step_command_fsm_ops): Remove.
8199         (new_step_command_fsm): Remove.
8200         (step_1): Update.
8201         (step_command_fsm::should_stop): Rename from
8202         step_command_fsm_should_stop.
8203         (step_command_fsm::clean_up): Rename from
8204         step_command_fsm_clean_up.
8205         (step_command_fsm::do_async_reply_reason): Rename from
8206         step_command_fsm_async_reply_reason.
8207         (struct until_next_fsm): Inherit from thread_fsm.  Add
8208         constructor.
8209         (until_next_fsm_ops): Remove.
8210         (new_until_next_fsm): Remove.
8211         (until_next_fsm::should_stop): Rename from
8212         until_next_fsm_should_stop.
8213         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8214         (until_next_fsm::do_async_reply_reason): Rename from
8215         until_next_fsm_async_reply_reason.
8216         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8217         constructor.  Change type of breakpoint.
8218         (finish_command_fsm_ops): Remove.
8219         (new_finish_command_fsm): Remove.
8220         (finish_command_fsm::should_stop): Rename from
8221         finish_command_fsm_should_stop.
8222         (finish_command_fsm::clean_up): Rename from
8223         finish_command_fsm_clean_up.
8224         (finish_command_fsm::return_value): Rename from
8225         finish_command_fsm_return_value.
8226         (finish_command_fsm::do_async_reply_reason): Rename from
8227         finish_command_fsm_async_reply_reason.
8228         (finish_command): Update.
8229         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8230         Add constructor.
8231         (call_thread_fsm_ops): Remove.
8232         (call_thread_fsm::call_thread_fsm): Rename from
8233         new_call_thread_fsm.
8234         (call_thread_fsm::should_stop): Rename from
8235         call_thread_fsm_should_stop.
8236         (call_thread_fsm::should_notify_stop): Rename from
8237         call_thread_fsm_should_notify_stop.
8238         (run_inferior_call, call_function_by_hand_dummy): Update.
8239         * cli/cli-interp.c (should_print_stop_to_console): Update.
8240         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8241         Add constructor.  Change type of location_breakpoint,
8242         caller_breakpoint.
8243         (until_break_fsm_ops): Remove.
8244         (new_until_break_fsm): Remove.
8245         (until_break_fsm::should_stop): Rename from
8246         until_break_fsm_should_stop.
8247         (until_break_fsm::clean_up): Rename from
8248         until_break_fsm_clean_up.
8249         (until_break_fsm::do_async_reply_reason): Rename from
8250         until_break_fsm_async_reply_reason.
8251         (until_break_command): Update.
8252         * thread-fsm.c: Remove.
8253         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8254
8255 2019-02-07  Tom Tromey  <tom@tromey.com>
8256
8257         * yy-remap.h: Add include guard.
8258         * xtensa-tdep.h: Add include guard.
8259         * xcoffread.h: Rename include guard.
8260         * varobj-iter.h: Add include guard.
8261         * tui/tui.h: Rename include guard.
8262         * tui/tui-winsource.h: Rename include guard.
8263         * tui/tui-wingeneral.h: Rename include guard.
8264         * tui/tui-windata.h: Rename include guard.
8265         * tui/tui-win.h: Rename include guard.
8266         * tui/tui-stack.h: Rename include guard.
8267         * tui/tui-source.h: Rename include guard.
8268         * tui/tui-regs.h: Rename include guard.
8269         * tui/tui-out.h: Rename include guard.
8270         * tui/tui-layout.h: Rename include guard.
8271         * tui/tui-io.h: Rename include guard.
8272         * tui/tui-hooks.h: Rename include guard.
8273         * tui/tui-file.h: Rename include guard.
8274         * tui/tui-disasm.h: Rename include guard.
8275         * tui/tui-data.h: Rename include guard.
8276         * tui/tui-command.h: Rename include guard.
8277         * tic6x-tdep.h: Add include guard.
8278         * target/waitstatus.h: Rename include guard.
8279         * target/wait.h: Rename include guard.
8280         * target/target.h: Rename include guard.
8281         * target/resume.h: Rename include guard.
8282         * target-float.h: Rename include guard.
8283         * stabsread.h: Add include guard.
8284         * rs6000-tdep.h: Add include guard.
8285         * riscv-fbsd-tdep.h: Add include guard.
8286         * regformats/regdef.h: Rename include guard.
8287         * record.h: Rename include guard.
8288         * python/python.h: Rename include guard.
8289         * python/python-internal.h: Rename include guard.
8290         * python/py-stopevent.h: Rename include guard.
8291         * python/py-ref.h: Rename include guard.
8292         * python/py-record.h: Rename include guard.
8293         * python/py-record-full.h: Rename include guard.
8294         * python/py-record-btrace.h: Rename include guard.
8295         * python/py-instruction.h: Rename include guard.
8296         * python/py-events.h: Rename include guard.
8297         * python/py-event.h: Rename include guard.
8298         * procfs.h: Add include guard.
8299         * proc-utils.h: Add include guard.
8300         * p-lang.h: Add include guard.
8301         * or1k-tdep.h: Rename include guard.
8302         * observable.h: Rename include guard.
8303         * nto-tdep.h: Rename include guard.
8304         * nat/x86-linux.h: Rename include guard.
8305         * nat/x86-linux-dregs.h: Rename include guard.
8306         * nat/x86-gcc-cpuid.h: Add include guard.
8307         * nat/x86-dregs.h: Rename include guard.
8308         * nat/x86-cpuid.h: Rename include guard.
8309         * nat/ppc-linux.h: Rename include guard.
8310         * nat/mips-linux-watch.h: Rename include guard.
8311         * nat/linux-waitpid.h: Rename include guard.
8312         * nat/linux-ptrace.h: Rename include guard.
8313         * nat/linux-procfs.h: Rename include guard.
8314         * nat/linux-osdata.h: Rename include guard.
8315         * nat/linux-nat.h: Rename include guard.
8316         * nat/linux-namespaces.h: Rename include guard.
8317         * nat/linux-btrace.h: Rename include guard.
8318         * nat/glibc_thread_db.h: Rename include guard.
8319         * nat/gdb_thread_db.h: Rename include guard.
8320         * nat/gdb_ptrace.h: Rename include guard.
8321         * nat/fork-inferior.h: Rename include guard.
8322         * nat/amd64-linux-siginfo.h: Rename include guard.
8323         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8324         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8325         * nat/aarch64-linux.h: Rename include guard.
8326         * nat/aarch64-linux-hw-point.h: Rename include guard.
8327         * mn10300-tdep.h: Add include guard.
8328         * mips-linux-tdep.h: Add include guard.
8329         * mi/mi-parse.h: Rename include guard.
8330         * mi/mi-out.h: Rename include guard.
8331         * mi/mi-main.h: Rename include guard.
8332         * mi/mi-interp.h: Rename include guard.
8333         * mi/mi-getopt.h: Rename include guard.
8334         * mi/mi-console.h: Rename include guard.
8335         * mi/mi-common.h: Rename include guard.
8336         * mi/mi-cmds.h: Rename include guard.
8337         * mi/mi-cmd-break.h: Rename include guard.
8338         * m2-lang.h: Add include guard.
8339         * location.h: Rename include guard.
8340         * linux-record.h: Rename include guard.
8341         * linux-nat.h: Add include guard.
8342         * linux-fork.h: Add include guard.
8343         * i386-darwin-tdep.h: Rename include guard.
8344         * hppa-linux-offsets.h: Add include guard.
8345         * guile/guile.h: Rename include guard.
8346         * guile/guile-internal.h: Rename include guard.
8347         * gnu-nat.h: Rename include guard.
8348         * gdb-stabs.h: Rename include guard.
8349         * frv-tdep.h: Add include guard.
8350         * f-lang.h: Add include guard.
8351         * event-loop.h: Add include guard.
8352         * darwin-nat.h: Rename include guard.
8353         * cp-abi.h: Rename include guard.
8354         * config/sparc/nm-sol2.h: Rename include guard.
8355         * config/nm-nto.h: Rename include guard.
8356         * config/nm-linux.h: Add include guard.
8357         * config/i386/nm-i386gnu.h: Rename include guard.
8358         * config/djgpp/nl_types.h: Rename include guard.
8359         * config/djgpp/langinfo.h: Rename include guard.
8360         * compile/gcc-cp-plugin.h: Add include guard.
8361         * compile/gcc-c-plugin.h: Add include guard.
8362         * compile/compile.h: Rename include guard.
8363         * compile/compile-object-run.h: Rename include guard.
8364         * compile/compile-object-load.h: Rename include guard.
8365         * compile/compile-internal.h: Rename include guard.
8366         * compile/compile-cplus.h: Rename include guard.
8367         * compile/compile-c.h: Rename include guard.
8368         * common/xml-utils.h: Rename include guard.
8369         * common/x86-xstate.h: Rename include guard.
8370         * common/version.h: Rename include guard.
8371         * common/vec.h: Rename include guard.
8372         * common/tdesc.h: Rename include guard.
8373         * common/selftest.h: Rename include guard.
8374         * common/scoped_restore.h: Rename include guard.
8375         * common/scoped_mmap.h: Rename include guard.
8376         * common/scoped_fd.h: Rename include guard.
8377         * common/safe-iterator.h: Rename include guard.
8378         * common/run-time-clock.h: Rename include guard.
8379         * common/refcounted-object.h: Rename include guard.
8380         * common/queue.h: Rename include guard.
8381         * common/ptid.h: Rename include guard.
8382         * common/print-utils.h: Rename include guard.
8383         * common/preprocessor.h: Rename include guard.
8384         * common/pathstuff.h: Rename include guard.
8385         * common/observable.h: Rename include guard.
8386         * common/netstuff.h: Rename include guard.
8387         * common/job-control.h: Rename include guard.
8388         * common/host-defs.h: Rename include guard.
8389         * common/gdb_wait.h: Rename include guard.
8390         * common/gdb_vecs.h: Rename include guard.
8391         * common/gdb_unlinker.h: Rename include guard.
8392         * common/gdb_unique_ptr.h: Rename include guard.
8393         * common/gdb_tilde_expand.h: Rename include guard.
8394         * common/gdb_sys_time.h: Rename include guard.
8395         * common/gdb_string_view.h: Rename include guard.
8396         * common/gdb_splay_tree.h: Rename include guard.
8397         * common/gdb_setjmp.h: Rename include guard.
8398         * common/gdb_ref_ptr.h: Rename include guard.
8399         * common/gdb_optional.h: Rename include guard.
8400         * common/gdb_locale.h: Rename include guard.
8401         * common/gdb_assert.h: Rename include guard.
8402         * common/filtered-iterator.h: Rename include guard.
8403         * common/filestuff.h: Rename include guard.
8404         * common/fileio.h: Rename include guard.
8405         * common/environ.h: Rename include guard.
8406         * common/common-utils.h: Rename include guard.
8407         * common/common-types.h: Rename include guard.
8408         * common/common-regcache.h: Rename include guard.
8409         * common/common-inferior.h: Rename include guard.
8410         * common/common-gdbthread.h: Rename include guard.
8411         * common/common-exceptions.h: Rename include guard.
8412         * common/common-defs.h: Rename include guard.
8413         * common/common-debug.h: Rename include guard.
8414         * common/cleanups.h: Rename include guard.
8415         * common/buffer.h: Rename include guard.
8416         * common/btrace-common.h: Rename include guard.
8417         * common/break-common.h: Rename include guard.
8418         * cli/cli-utils.h: Rename include guard.
8419         * cli/cli-style.h: Rename include guard.
8420         * cli/cli-setshow.h: Rename include guard.
8421         * cli/cli-script.h: Rename include guard.
8422         * cli/cli-interp.h: Rename include guard.
8423         * cli/cli-decode.h: Rename include guard.
8424         * cli/cli-cmds.h: Rename include guard.
8425         * charset-list.h: Add include guard.
8426         * buildsym-legacy.h: Rename include guard.
8427         * bfin-tdep.h: Add include guard.
8428         * ax.h: Rename include guard.
8429         * arm-linux-tdep.h: Add include guard.
8430         * arm-fbsd-tdep.h: Add include guard.
8431         * arch/xtensa.h: Rename include guard.
8432         * arch/tic6x.h: Add include guard.
8433         * arch/i386.h: Add include guard.
8434         * arch/arm.h: Rename include guard.
8435         * arch/arm-linux.h: Rename include guard.
8436         * arch/arm-get-next-pcs.h: Rename include guard.
8437         * arch/amd64.h: Add include guard.
8438         * arch/aarch64-insn.h: Rename include guard.
8439         * arch-utils.h: Rename include guard.
8440         * annotate.h: Add include guard.
8441         * amd64-darwin-tdep.h: Rename include guard.
8442         * aarch64-linux-tdep.h: Add include guard.
8443         * aarch64-fbsd-tdep.h: Add include guard.
8444         * aarch32-linux-nat.h: Add include guard.
8445
8446 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8447
8448         * macrotab.c (macro_define_internal): New function that
8449         factorizes macro_define_object_internal and macro_define_function
8450         code.
8451         (macro_define_object_internal): Use macro_define_internal.
8452         (macro_define_function): Likewise.
8453
8454 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8455
8456         * macrocmd.c (extract_identifier): Return
8457         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8458         callers.
8459
8460 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8461
8462         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8463
8464 2019-02-05  Tom Tromey  <tom@tromey.com>
8465
8466         * target.c (target_stack::unpush): Move assertion earlier.
8467
8468 2019-01-30  Tom Tromey  <tom@tromey.com>
8469
8470         PR python/23615:
8471         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8472         (gdbpy_parse_and_eval): Likewise.
8473         * python/python-internal.h (gdbpy_allow_threads): New class.
8474
8475 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8476
8477         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8478         (aarch64_fbsd_fpregmap): Move earlier.
8479         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8480         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8481         instead of individual calls to trad_frame_set_reg_addr.
8482         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8483         earlier.
8484         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8485         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8486         instead of individual calls to trad_frame_set_reg_addr.
8487
8488 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8489
8490         * CONTRIBUTE: Replace contribution list with wiki link.
8491
8492 2019-01-25  Tom Tromey  <tom@tromey.com>
8493
8494         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8495
8496 2019-01-25  Tom Tromey  <tom@tromey.com>
8497
8498         * xtensa-linux-nat.c: Fix common/ includes.
8499         * xml-support.h: Fix common/ includes.
8500         * xml-support.c: Fix common/ includes.
8501         * x86-linux-nat.c: Fix common/ includes.
8502         * windows-nat.c: Fix common/ includes.
8503         * varobj.h: Fix common/ includes.
8504         * varobj.c: Fix common/ includes.
8505         * value.c: Fix common/ includes.
8506         * valops.c: Fix common/ includes.
8507         * utils.c: Fix common/ includes.
8508         * unittests/xml-utils-selftests.c: Fix common/ includes.
8509         * unittests/utils-selftests.c: Fix common/ includes.
8510         * unittests/unpack-selftests.c: Fix common/ includes.
8511         * unittests/tracepoint-selftests.c: Fix common/ includes.
8512         * unittests/style-selftests.c: Fix common/ includes.
8513         * unittests/string_view-selftests.c: Fix common/ includes.
8514         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8515         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8516         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8517         * unittests/rsp-low-selftests.c: Fix common/ includes.
8518         * unittests/parse-connection-spec-selftests.c: Fix common/
8519         includes.
8520         * unittests/optional-selftests.c: Fix common/ includes.
8521         * unittests/offset-type-selftests.c: Fix common/ includes.
8522         * unittests/observable-selftests.c: Fix common/ includes.
8523         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8524         * unittests/memrange-selftests.c: Fix common/ includes.
8525         * unittests/memory-map-selftests.c: Fix common/ includes.
8526         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8527         * unittests/function-view-selftests.c: Fix common/ includes.
8528         * unittests/environ-selftests.c: Fix common/ includes.
8529         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8530         * unittests/common-utils-selftests.c: Fix common/ includes.
8531         * unittests/cli-utils-selftests.c: Fix common/ includes.
8532         * unittests/array-view-selftests.c: Fix common/ includes.
8533         * ui-file.c: Fix common/ includes.
8534         * tui/tui-io.c: Fix common/ includes.
8535         * tracepoint.h: Fix common/ includes.
8536         * tracepoint.c: Fix common/ includes.
8537         * tracefile-tfile.c: Fix common/ includes.
8538         * top.h: Fix common/ includes.
8539         * top.c: Fix common/ includes.
8540         * thread.c: Fix common/ includes.
8541         * target/waitstatus.h: Fix common/ includes.
8542         * target/waitstatus.c: Fix common/ includes.
8543         * target.h: Fix common/ includes.
8544         * target.c: Fix common/ includes.
8545         * target-memory.c: Fix common/ includes.
8546         * target-descriptions.c: Fix common/ includes.
8547         * symtab.h: Fix common/ includes.
8548         * symfile.c: Fix common/ includes.
8549         * stap-probe.c: Fix common/ includes.
8550         * spu-linux-nat.c: Fix common/ includes.
8551         * sparc-nat.c: Fix common/ includes.
8552         * source.c: Fix common/ includes.
8553         * solib.c: Fix common/ includes.
8554         * solib-target.c: Fix common/ includes.
8555         * ser-unix.c: Fix common/ includes.
8556         * ser-tcp.c: Fix common/ includes.
8557         * ser-pipe.c: Fix common/ includes.
8558         * ser-base.c: Fix common/ includes.
8559         * selftest-arch.c: Fix common/ includes.
8560         * s12z-tdep.c: Fix common/ includes.
8561         * rust-exp.y: Fix common/ includes.
8562         * rs6000-aix-tdep.c: Fix common/ includes.
8563         * riscv-tdep.c: Fix common/ includes.
8564         * remote.c: Fix common/ includes.
8565         * remote-notif.h: Fix common/ includes.
8566         * remote-fileio.h: Fix common/ includes.
8567         * remote-fileio.c: Fix common/ includes.
8568         * regcache.h: Fix common/ includes.
8569         * regcache.c: Fix common/ includes.
8570         * record-btrace.c: Fix common/ includes.
8571         * python/python.c: Fix common/ includes.
8572         * python/py-type.c: Fix common/ includes.
8573         * python/py-inferior.c: Fix common/ includes.
8574         * progspace.h: Fix common/ includes.
8575         * producer.c: Fix common/ includes.
8576         * procfs.c: Fix common/ includes.
8577         * proc-api.c: Fix common/ includes.
8578         * printcmd.c: Fix common/ includes.
8579         * ppc-linux-nat.c: Fix common/ includes.
8580         * parser-defs.h: Fix common/ includes.
8581         * osdata.c: Fix common/ includes.
8582         * obsd-nat.c: Fix common/ includes.
8583         * nat/x86-linux.c: Fix common/ includes.
8584         * nat/x86-linux-dregs.c: Fix common/ includes.
8585         * nat/x86-dregs.h: Fix common/ includes.
8586         * nat/x86-dregs.c: Fix common/ includes.
8587         * nat/ppc-linux.c: Fix common/ includes.
8588         * nat/mips-linux-watch.h: Fix common/ includes.
8589         * nat/mips-linux-watch.c: Fix common/ includes.
8590         * nat/linux-waitpid.c: Fix common/ includes.
8591         * nat/linux-ptrace.h: Fix common/ includes.
8592         * nat/linux-ptrace.c: Fix common/ includes.
8593         * nat/linux-procfs.c: Fix common/ includes.
8594         * nat/linux-personality.c: Fix common/ includes.
8595         * nat/linux-osdata.c: Fix common/ includes.
8596         * nat/linux-namespaces.c: Fix common/ includes.
8597         * nat/linux-btrace.h: Fix common/ includes.
8598         * nat/linux-btrace.c: Fix common/ includes.
8599         * nat/fork-inferior.c: Fix common/ includes.
8600         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8601         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8602         * nat/aarch64-linux.c: Fix common/ includes.
8603         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8604         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8605         * namespace.h: Fix common/ includes.
8606         * mips-linux-tdep.c: Fix common/ includes.
8607         * minsyms.c: Fix common/ includes.
8608         * mi/mi-parse.h: Fix common/ includes.
8609         * mi/mi-main.c: Fix common/ includes.
8610         * mi/mi-cmd-env.c: Fix common/ includes.
8611         * memrange.h: Fix common/ includes.
8612         * memattr.c: Fix common/ includes.
8613         * maint.h: Fix common/ includes.
8614         * maint.c: Fix common/ includes.
8615         * main.c: Fix common/ includes.
8616         * machoread.c: Fix common/ includes.
8617         * location.c: Fix common/ includes.
8618         * linux-thread-db.c: Fix common/ includes.
8619         * linux-nat.c: Fix common/ includes.
8620         * linux-fork.c: Fix common/ includes.
8621         * inline-frame.c: Fix common/ includes.
8622         * infrun.c: Fix common/ includes.
8623         * inflow.c: Fix common/ includes.
8624         * inferior.h: Fix common/ includes.
8625         * inferior.c: Fix common/ includes.
8626         * infcmd.c: Fix common/ includes.
8627         * inf-ptrace.c: Fix common/ includes.
8628         * inf-child.c: Fix common/ includes.
8629         * ia64-linux-nat.c: Fix common/ includes.
8630         * i387-tdep.c: Fix common/ includes.
8631         * i386-tdep.c: Fix common/ includes.
8632         * i386-linux-tdep.c: Fix common/ includes.
8633         * i386-linux-nat.c: Fix common/ includes.
8634         * i386-go32-tdep.c: Fix common/ includes.
8635         * i386-fbsd-tdep.c: Fix common/ includes.
8636         * i386-fbsd-nat.c: Fix common/ includes.
8637         * guile/scm-type.c: Fix common/ includes.
8638         * guile/guile.c: Fix common/ includes.
8639         * go32-nat.c: Fix common/ includes.
8640         * gnu-nat.c: Fix common/ includes.
8641         * gdbthread.h: Fix common/ includes.
8642         * gdbarch-selftests.c: Fix common/ includes.
8643         * gdb_usleep.c: Fix common/ includes.
8644         * gdb_select.h: Fix common/ includes.
8645         * gdb_bfd.c: Fix common/ includes.
8646         * gcore.c: Fix common/ includes.
8647         * fork-child.c: Fix common/ includes.
8648         * findvar.c: Fix common/ includes.
8649         * fbsd-nat.c: Fix common/ includes.
8650         * event-top.c: Fix common/ includes.
8651         * event-loop.c: Fix common/ includes.
8652         * dwarf2read.c: Fix common/ includes.
8653         * dwarf2loc.c: Fix common/ includes.
8654         * dwarf2-frame.c: Fix common/ includes.
8655         * dwarf-index-cache.c: Fix common/ includes.
8656         * dtrace-probe.c: Fix common/ includes.
8657         * disasm-selftests.c: Fix common/ includes.
8658         * defs.h: Fix common/ includes.
8659         * csky-tdep.c: Fix common/ includes.
8660         * cp-valprint.c: Fix common/ includes.
8661         * cp-support.h: Fix common/ includes.
8662         * cp-support.c: Fix common/ includes.
8663         * corelow.c: Fix common/ includes.
8664         * completer.h: Fix common/ includes.
8665         * completer.c: Fix common/ includes.
8666         * compile/compile.c: Fix common/ includes.
8667         * compile/compile-loc2c.c: Fix common/ includes.
8668         * compile/compile-cplus-types.c: Fix common/ includes.
8669         * compile/compile-cplus-symbols.c: Fix common/ includes.
8670         * command.h: Fix common/ includes.
8671         * cli/cli-dump.c: Fix common/ includes.
8672         * cli/cli-cmds.c: Fix common/ includes.
8673         * charset.c: Fix common/ includes.
8674         * build-id.c: Fix common/ includes.
8675         * btrace.h: Fix common/ includes.
8676         * btrace.c: Fix common/ includes.
8677         * breakpoint.h: Fix common/ includes.
8678         * breakpoint.c: Fix common/ includes.
8679         * ax.h:
8680         (enum agent_op): Fix common/ includes.
8681         * ax-general.c (struct aop_map): Fix common/ includes.
8682         * ax-gdb.c: Fix common/ includes.
8683         * auxv.c: Fix common/ includes.
8684         * auto-load.c: Fix common/ includes.
8685         * arm-tdep.c: Fix common/ includes.
8686         * arch/riscv.c: Fix common/ includes.
8687         * arch/ppc-linux-common.c: Fix common/ includes.
8688         * arch/i386.c: Fix common/ includes.
8689         * arch/arm.c: Fix common/ includes.
8690         * arch/arm-linux.c: Fix common/ includes.
8691         * arch/arm-get-next-pcs.c: Fix common/ includes.
8692         * arch/amd64.c: Fix common/ includes.
8693         * arch/aarch64.c: Fix common/ includes.
8694         * arch/aarch64-insn.c: Fix common/ includes.
8695         * arch-utils.c: Fix common/ includes.
8696         * amd64-windows-tdep.c: Fix common/ includes.
8697         * amd64-tdep.c: Fix common/ includes.
8698         * amd64-sol2-tdep.c: Fix common/ includes.
8699         * amd64-obsd-tdep.c: Fix common/ includes.
8700         * amd64-nbsd-tdep.c: Fix common/ includes.
8701         * amd64-linux-tdep.c: Fix common/ includes.
8702         * amd64-linux-nat.c: Fix common/ includes.
8703         * amd64-fbsd-tdep.c: Fix common/ includes.
8704         * amd64-fbsd-nat.c: Fix common/ includes.
8705         * amd64-dicos-tdep.c: Fix common/ includes.
8706         * amd64-darwin-tdep.c: Fix common/ includes.
8707         * agent.c: Fix common/ includes.
8708         * ada-lang.h: Fix common/ includes.
8709         * ada-lang.c: Fix common/ includes.
8710         * aarch64-tdep.c: Fix common/ includes.
8711
8712 2019-01-25  Tom Tromey  <tom@tromey.com>
8713
8714         * common/create-version.sh: Use common/version.h.
8715
8716 2019-01-24  Pedro Alves  <palves@redhat.com>
8717
8718         * infrun.c (signal_stop, signal_print, signal_program)
8719         (signal_catch, signal_pass): Now arrays instead of pointers.
8720         (update_signals_program_target, do_target_resume)
8721         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8722         * linux-nat.c (linux_nat_target::pass_signals)
8723         (linux_nat_target::create_inferior, linux_nat_target::attach):
8724         Adjust.
8725         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8726         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8727         * procfs.c (procfs_target::pass_signals): Adjust.
8728         * record-full.c (record_full_target::resume): Adjust.
8729         * remote.c (remote_target::pass_signals)
8730         (remote_target::program_signals): Adjust.
8731         * target-debug.h (target_debug_print_signals): Now takes a
8732         gdb::array_view as parameter.  Adjust.
8733         * target.h (target_ops) <pass_signals, program_signals>: Replace
8734         pointer and length parameters with gdb::array_view.
8735         (target_pass_signals, target_program_signals): Likewise.
8736         * target-delegates.c: Regenerate.
8737
8738 2019-01-24  Pedro Alves  <palves@redhat.com>
8739
8740         * common/forward-scope-exit.h
8741         (forward_scope_exit::forward_scope_exit): Pass arguments to
8742         m_bind_function directly, instead of creating a std::bind and
8743         copying that.
8744
8745 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8746
8747         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8748         for static members.
8749         (pass_in_v_vfp_candidate): Likewise.
8750
8751 2019-01-23  Tom Tromey  <tom@tromey.com>
8752             Pedro Alves  <palves@redhat.com>
8753
8754         * regcache.c (class regcache_invalidator): Remove.
8755         (regcache::raw_write): Use make_scope_exit.
8756
8757 2019-01-23  Tom Tromey  <tom@tromey.com>
8758
8759         * ui-out.h (class ui_out_emit_type): Update comment.
8760
8761 2019-01-23  Tom Tromey  <tom@tromey.com>
8762
8763         * infrun.c (fetch_inferior_event): Update comment.
8764
8765 2019-01-23  Tom Tromey  <tom@tromey.com>
8766             Pedro Alves  <palves@redhat.com>
8767
8768         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8769         parameter.
8770         (fetch_inferior_event): Use SCOPE_EXIT.
8771
8772
8773 2019-01-23  Tom Tromey  <tom@tromey.com>
8774             Pedro Alves  <palves@redhat.com>
8775
8776         * infrun.c (disable_thread_events): Delete.
8777         (stop_all_threads): Use SCOPE_EXIT.
8778
8779 2019-01-23  Tom Tromey  <tom@tromey.com>
8780             Pedro Alves  <palves@redhat.com>
8781
8782         * symfile.c: Include forward-scope-exit.h.
8783         (clear_symtab_users_cleanup): Replace forward declaration with
8784         a FORWARD_SCOPE_EXIT.
8785         (syms_from_objfile_1): Use the forward_scope_exit and
8786         gdb::optional instead of cleanup_function.
8787         (reread_symbols): Use the forward_scope_exit instead of
8788         cleanup_function.
8789         (clear_symtab_users_cleanup): Remove function.
8790
8791 2019-01-23  Tom Tromey  <tom@tromey.com>
8792             Pedro Alves  <palves@redhat.com>
8793
8794         * linux-nat.c: Include scope-exit.h.
8795         (cleanup_target_stop): Remove.
8796         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8797         SCOPE_EXIT.
8798
8799 2019-01-23  Tom Tromey  <tom@tromey.com>
8800             Pedro Alves  <palves@redhat.com>
8801
8802         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8803         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8804
8805 2019-01-23  Tom Tromey  <tom@tromey.com>
8806             Andrew Burgess  <andrew.burgess@embecosm.com>
8807             Pedro Alves  <palves@redhat.com>
8808
8809         * infrun.c (fetch_inferior_event): Use scope_exit.
8810         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8811         * top.c (execute_command): Use scope_exit.
8812         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8813         * utils.c (do_bpstat_clear_actions_cleanup)
8814         (make_bpstat_clear_actions_cleanup): Remove.
8815
8816 2019-01-23  Tom Tromey  <tom@tromey.com>
8817             Pedro Alves  <palves@redhat.com>
8818
8819         * infrun.c: Include "common/scope-exit.h"
8820         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8821         (wait_for_inferior): Use SCOPE_EXIT.
8822         (fetch_inferior_event): Use scope_exit.
8823
8824 2019-01-23  Tom Tromey  <tom@tromey.com>
8825             Pedro Alves  <palves@redhat.com>
8826
8827         * breakpoint.c (create_breakpoint): Remove cleanup.
8828
8829 2019-01-23  Tom Tromey  <tom@tromey.com>
8830             Andrew Burgess  <andrew.burgess@embecosm.com>
8831             Pedro Alves  <palves@redhat.com>
8832
8833 2019-01-23  Pedro Alves  <palves@redhat.com>
8834
8835         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8836
8837 2019-01-23  Pedro Alves  <palves@redhat.com>
8838             Andrew Burgess  <andrew.burgess@embecosm.com>
8839
8840         * gdbthread.h: Include "common/forward-scope-exit.h".
8841         (scoped_finish_thread_state): Redefine custom class in terms of
8842         forward_scope_exit.
8843
8844 2019-01-23  Pedro Alves  <palves@redhat.com>
8845             Andrew Burgess  <andrew.burgess@embecosm.com>
8846
8847         * common/forward-scope-exit.h: New file.
8848
8849 2019-01-23  Pedro Alves  <palves@redhat.com>
8850             Andrew Burgess  <andrew.burgess@embecosm.com>
8851             Tom Tromey  <tom@tromey.com>
8852
8853         * common/scope-exit.h: New file.
8854
8855 2019-01-23  Pedro Alves  <palves@redhat.com>
8856
8857         * common/preprocessor.h (ESC): Rename to ...
8858         (ESC_PARENS): ... this.
8859         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8860         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8861
8862 2019-01-23  Tom Tromey  <tom@tromey.com>
8863
8864         * language.h (class scoped_switch_to_sym_language_if_auto):
8865         Initialize m_lang in both cases.
8866
8867 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8868
8869         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8870         with XCNEW.
8871
8872 2019-01-22  Tom Tromey  <tom@tromey.com>
8873
8874         * corelow.c: Do not include sys/file.h.
8875
8876 2019-01-22  Tom Tromey  <tom@tromey.com>
8877
8878         * tui/tui-wingeneral.h: Include gdb_curses.h.
8879
8880 2019-01-22  Tom Tromey  <tom@tromey.com>
8881
8882         * source-cache.h (class source_cache) <get_source_lines,
8883         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8884
8885 2019-01-22  Tom Tromey  <tom@tromey.com>
8886
8887         * remote-fileio.h (struct remote_target): Declare.
8888
8889 2019-01-22  Tom Tromey  <tom@tromey.com>
8890
8891         * python/py-arch.c: Do not include py-ref.h.
8892         * python/py-bpevent.c: Do not include py-ref.h.
8893         * python/py-cmd.c: Do not include py-ref.h.
8894         * python/py-continueevent.c: Do not include py-ref.h.
8895         * python/py-event.h: Do not include py-ref.h.
8896         * python/py-evtregistry.c: Do not include py-ref.h.
8897         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8898         * python/py-frame.c: Do not include py-ref.h.
8899         * python/py-framefilter.c: Do not include py-ref.h.
8900         * python/py-function.c: Do not include py-ref.h.
8901         * python/py-infevents.c: Do not include py-ref.h.
8902         * python/py-linetable.c: Do not include py-ref.h.
8903         * python/py-objfile.c: Do not include py-ref.h.
8904         * python/py-param.c: Do not include py-ref.h.
8905         * python/py-prettyprint.c: Do not include py-ref.h.
8906         * python/py-progspace.c: Do not include py-ref.h.
8907         * python/py-symbol.c: Do not include py-ref.h.
8908         * python/py-symtab.c: Do not include py-ref.h.
8909         * python/py-type.c: Do not include py-ref.h.
8910         * python/py-unwind.c: Do not include py-ref.h.
8911         * python/py-utils.c: Do not include py-ref.h.
8912         * python/py-value.c: Do not include py-ref.h.
8913         * python/py-varobj.c: Do not include py-ref.h.
8914         * python/py-xmethods.c: Do not include py-ref.h.
8915         * python/python.c: Do not include py-ref.h.
8916         * varobj.c: Do not include py-ref.h.
8917
8918 2019-01-22  Tom Tromey  <tom@tromey.com>
8919
8920         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8921         keyword for bcache.
8922
8923 2019-01-22  Tom Tromey  <tom@tromey.com>
8924
8925         * compile/compile-cplus-types.c: Remove a comment by #include.
8926
8927 2019-01-22  Tom Tromey  <tom@tromey.com>
8928
8929         * compile/gcc-c-plugin.h: Include compile-internal.h.
8930
8931 2019-01-22  Tom Tromey  <tom@tromey.com>
8932
8933         * stabsread.c (EXTERN): Do not define.
8934         (symnum, next_symbol_text_func, processing_gcc_compilation)
8935         (within_function, global_sym_chain, global_stabs)
8936         (previous_stab_code, this_object_header_files)
8937         (n_this_object_header_files)
8938         (n_allocated_this_object_header_files): Define.
8939         * stabsread.h (EXTERN): Never define.  Use "extern".
8940
8941 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8942
8943         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8944         history_value.
8945
8946 2019-01-21  Tom Tromey  <tom@tromey.com>
8947
8948         * ui-out.c: Fix includes.
8949         * tui/tui-source.c: Fix includes.
8950         * target.c: Fix includes.
8951         * remote.c: Fix includes.
8952         * regcache.c: Fix includes.
8953         * python/py-block.c: Fix includes.
8954         * printcmd.c: Fix includes.
8955         * or1k-tdep.c: Fix includes.
8956         * mi/mi-main.c: Fix includes.
8957         * m32r-tdep.c: Fix includes.
8958         * csky-tdep.c: Fix includes.
8959         * compile/compile-cplus-types.c: Fix includes.
8960         * cli/cli-interp.c: Fix includes.
8961
8962 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8963
8964         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8965         for padding.
8966
8967 2019-01-16  Tom Tromey  <tom@tromey.com>
8968
8969         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8970         earlier.
8971         (struct objfile) <msymbols_range>: Move from top level.
8972         <msymbols>: New method.
8973         (class objfile_msymbols): Remove.
8974         * symtab.c (default_collect_symbol_completion_matches_break_on):
8975         Update.
8976         * symmisc.c (dump_msymbols): Update.
8977         * stabsread.c (scan_file_globals): Update.
8978         * objc-lang.c (info_selectors_command, info_classes_command)
8979         (find_methods): Update.
8980         * minsyms.c (find_solib_trampoline_target): Update.
8981         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8982         * coffread.c (coff_symfile_read): Update.
8983         * ada-lang.c (ada_lookup_simple_minsym)
8984         (ada_collect_symbol_completion_matches): Update.
8985
8986 2019-01-16  Tom Tromey  <tom@tromey.com>
8987
8988         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8989         type.  Remove no-argument constructor.
8990         <iterator::operator++>: Simplify.
8991         <begin>: Update.
8992         <end>: Use minimal_symbol_count.
8993
8994 2019-01-16  Tom Tromey  <tom@tromey.com>
8995
8996         * objfiles.h (struct objfile) <psymtabs>: New method.
8997         (class objfile_psymtabs): Remove.
8998         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8999         typedef.
9000         <range>: New method.
9001         (require_partial_symbols): Change return type.
9002         * psymtab.c (require_partial_symbols)
9003         (psym_expand_symtabs_matching): Update.
9004         * mdebugread.c (parse_partial_symbols): Update.
9005         * dbxread.c (dbx_end_psymtab): Update.
9006
9007 2019-01-15  Tom Tromey  <tom@tromey.com>
9008
9009         * symtab.c (lookup_objfile_from_block)
9010         (lookup_symbol_in_objfile_symtabs)
9011         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9012         (find_line_symtab, info_sources_command)
9013         (default_collect_symbol_completion_matches_break_on)
9014         (make_source_files_completion_list): Update.
9015         * symmisc.c (print_objfile_statistics, dump_objfile)
9016         (maintenance_print_symbols, maintenance_info_symtabs)
9017         (maintenance_check_symtabs, maintenance_info_line_tables):
9018         Update.
9019         * source.c (select_source_symtab)
9020         (forget_cached_source_info_for_objfile): Update.
9021         * objfiles.h (class objfile_compunits): Remove.
9022         (struct objfile) <compunits_range>: New typedef.
9023         (compunits): New method.
9024         * objfiles.c (objfile_relocate1): Update.
9025         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9026         * maint.c (count_symtabs_and_blocks): Update.
9027         * linespec.c (iterate_over_all_matching_symtabs): Update.
9028         * cp-support.c (add_symbol_overload_list_qualified): Update.
9029         * coffread.c (coff_symtab_read): Update.
9030         * ada-lang.c (add_nonlocal_symbols)
9031         (ada_collect_symbol_completion_matches)
9032         (ada_add_global_exceptions): Update.
9033
9034 2019-01-15  Tom Tromey  <tom@tromey.com>
9035
9036         * progspace.h (program_space) <objfiles_safe_range>: New
9037         typedef.
9038         <objfiles_safe>: New method.
9039         * objfiles.h (class all_objfiles_safe): Remove.
9040         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9041         * jit.c (jit_inferior_exit_hook): Update.
9042
9043 2019-01-17  Tom Tromey  <tom@tromey.com>
9044
9045         * progspace.h (program_space) <objfiles_range>: New typedef.
9046         <objfiles>: New method.
9047         <objfiles_head>: Rename from objfiles.
9048         (object_files): Update.
9049         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9050         * guile/scm-pretty-print.c
9051         (ppscm_find_pretty_printer_from_objfiles): Update.
9052         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9053         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9054         Update.
9055         * python/py-progspace.c (pspy_get_objfiles): Update.
9056         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9057         Update.
9058         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9059         (objfpy_lookup_objfile_by_build_id): Update.
9060         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9061         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9062         Update.
9063         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9064         (expand_symtab_containing_pc, lookup_objfile_from_block)
9065         (lookup_static_symbol, basic_lookup_transparent_type)
9066         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9067         (find_line_symtab, info_sources_command)
9068         (default_collect_symbol_completion_matches_break_on)
9069         (make_source_files_completion_list, find_main_name): Update.
9070         * symmisc.c (print_symbol_bcache_statistics)
9071         (print_objfile_statistics, maintenance_print_symbols)
9072         (maintenance_print_msymbols, maintenance_print_objfiles)
9073         (maintenance_info_symtabs, maintenance_check_symtabs)
9074         (maintenance_expand_symtabs, maintenance_info_line_tables):
9075         Update.
9076         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9077         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9078         (map_overlay_command, unmap_overlay_command)
9079         (simple_overlay_update, expand_symtabs_matching)
9080         (map_symbol_filenames): Update.
9081         * symfile-debug.c (set_debug_symfile): Update.
9082         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9083         Update.
9084         * source.c (select_source_symtab, forget_cached_source_info):
9085         Update.
9086         * solib.c (solib_read_symbols): Update.
9087         * solib-spu.c (append_ocl_sos): Update.
9088         * psymtab.c (maintenance_print_psymbols)
9089         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9090         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9091         * printcmd.c (info_symbol_command): Update.
9092         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9093         Update.
9094         * objfiles.h (class all_objfiles): Remove.
9095         * objfiles.c (have_partial_symbols, have_full_symbols)
9096         (have_minimal_symbols, qsort_cmp, update_section_map)
9097         (shared_objfile_contains_address_p)
9098         (default_iterate_over_objfiles_in_search_order): Update.
9099         * objc-lang.c (info_selectors_command, info_classes_command)
9100         (find_methods): Update.
9101         * minsyms.c (find_solib_trampoline_target): Update.
9102         * maint.c (maintenance_info_sections)
9103         (maintenance_translate_address, count_symtabs_and_blocks):
9104         Update.
9105         * main.c (captured_main_1): Update.
9106         * linux-thread-db.c (try_thread_db_load_from_pdir)
9107         (has_libpthread): Update.
9108         * linespec.c (iterate_over_all_matching_symtabs)
9109         (search_minsyms_for_name): Update.
9110         * jit.c (jit_find_objf_with_entry_addr): Update.
9111         * hppa-tdep.c (find_unwind_entry)
9112         (hppa_lookup_stub_minimal_symbol): Update.
9113         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9114         Update.
9115         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9116         (elf_gnu_ifunc_resolve_by_got): Update.
9117         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9118         * dwarf-index-write.c (save_gdb_index_command): Update.
9119         * cp-support.c (add_symbol_overload_list_qualified): Update.
9120         * breakpoint.c (create_overlay_event_breakpoint)
9121         (create_longjmp_master_breakpoint)
9122         (create_std_terminate_master_breakpoint)
9123         (create_exception_master_breakpoint): Update.
9124         * blockframe.c (find_pc_partial_function): Update.
9125         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9126         (ada_collect_symbol_completion_matches)
9127         (ada_add_global_exceptions): Update.
9128
9129 2019-01-17  Tom Tromey  <tom@tromey.com>
9130
9131         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9132         declare VEC.
9133         (solib_target_parse_libraries): Change return type.
9134         (library_list_start_segment, library_list_start_section)
9135         (library_list_end_library, library_list_start_library); Update.
9136         (solib_target_free_library_list): Remove.
9137         (solib_target_parse_libraries): Remove cleanup.  Change return
9138         type.
9139         (solib_target_current_sos): Update.
9140
9141 2019-01-17  Tom Tromey  <tromey@bapiya>
9142
9143         * valprint.c: Replace "the the" with "the".
9144         * symtab.c: Replace "the the" with "the".
9145         * solib.c: Replace "the the" with "the".
9146         * solib-dsbt.c: Replace "the the" with "the".
9147         * linespec.c: Replace "the the" with "the".
9148         * dwarf2loc.h: Replace "the the" with "the".
9149         * amd64-windows-tdep.c: Replace "the the" with "the".
9150         * aarch64-tdep.c: Replace "the the" with "the".
9151
9152 2019-01-16  Keith Seitz  <keiths@redhat.com>
9153
9154         PR gdb/23773
9155         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9156         <builder>: Rename to ..
9157         <m_builder>: ... this and make private.
9158         (dwarf2_cu::get_builder): New method.  Change all users of
9159         `builder' to use this method.
9160         (dwarf2_start_symtab): Move to ...
9161         (dwarf2_cu::start_symtab): ... here.  Update all callers
9162         (setup_type_unit_groups): Move to ...
9163         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9164         callers.
9165         (dwarf2_cu::reset_builder): New method.
9166         (process_full_compunit, process_full_type_unit): Use
9167         dwarf2_cu::reset_builder.
9168         (follow_die_offset): Record the ancestor CU if it is different
9169         from the followed DIE's CU.
9170         (follow_die_sig_1): Likewise.
9171
9172 2019-01-15  Tom Tromey  <tom@tromey.com>
9173
9174         * remote.c (class remote_state) <buf>: Now a char_vector.
9175         <buf_size>: Remove.
9176         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9177         parameter.
9178         (remote_target::getpkt_or_notif_sane_1)
9179         (remote_target::getpkt_sane)
9180         (remote_target::getpkt_or_notif_sane): Likewise.
9181         (class remote_target) <putpkt>: New overload.
9182         (remote_target::read_frame): Change type of "buf_p".  Remove
9183         sizeof_p parameter.
9184         (packet_ok): New overload.
9185         (packet_check_result): New overload.
9186         Update all uses.
9187
9188 2019-01-14  Tom Tromey  <tom@tromey.com>
9189
9190         * remote-notif.c (handle_notification, remote_notif_ack)
9191         (remote_notif_parse): Make "buf" const.
9192         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9193         const.
9194         (remote_notif_parse, remote_notif_ack, handle_notification):
9195         Likewise.
9196         * remote.c (remote_notif_stop_parse): Make "buf" const.
9197         (remote_target::remote_parse_stop_reply): Make "buf" const.
9198         (remote_notif_stop_ack): Make "buf" const.
9199
9200 2019-01-14  Tom Tromey  <tom@tromey.com>
9201
9202         * remote.c (remote_console_output): Make parameter const.
9203
9204 2019-01-14  Tom Tromey  <tom@tromey.com>
9205
9206         * target-debug.h (target_debug_print_signals): Constify.
9207         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9208         * procfs.c (procfs_target::pass_signals): Update.
9209         * linux-nat.c (linux_nat_target::pass_signals): Update.
9210         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9211         * target-delegates.c: Rebuild.
9212         * remote.c (remote_target::program_signals): Update.
9213         (remote_target::pass_signals): Update.
9214         * target.c (target_pass_signals): Constify argument.
9215         (target_program_signals): Likewise.
9216         * target.h (struct target_ops) <pass_signals, program_signals>:
9217         Constify argument.
9218         (target_pass_signals, target_program_signals): Constify argument.
9219
9220 2019-01-14  Tom Tromey  <tom@tromey.com>
9221
9222         PR tui/28819:
9223         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9224
9225 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9226
9227         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9228         field.
9229         * rs6000-tdep.c: Include reggroups.h.
9230         (IS_V_ALIAS_PSEUDOREG): Define.
9231         (rs6000_register_name): Return names for the "vX" aliases.
9232         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9233         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9234         aliases.  Call default_register_reggroup_p for all other
9235         pseudo-registers.
9236         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9237         New functions.
9238         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9239         Handle "vX" aliases.
9240         (v_alias_pseudo_register_collect): New function.
9241         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9242         (rs6000_gdbarch_init): Initialize "vX" aliases as
9243         pseudo-registers.  Restore registration of
9244         rs6000_pseudo_register_reggroup_p with
9245         set_tdesc_pseudo_register_reggroup_p.
9246
9247 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9248
9249         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9250         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9251         set_gdbarch_num_pseudo_regs.
9252
9253 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9254
9255         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9256         Remove arg prefixname, add do_set and do_show.
9257         Add member functions set_list and show_list.
9258         * cli/cli-style.c (class cli_style_option): Update accordingly.
9259         (style_set_list): Move to file scope.
9260         (style_show_list): Likewise.
9261         (set_style): Call help_list.
9262         (show_style): Call cmd_show_list.
9263         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9264         Update to use the new macro.
9265
9266 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9267
9268         * ada-lang.c (_initialize_ada_language): Expand the help text
9269         for the "catch exception" command.
9270
9271 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9272
9273         * symtab.c (matching_obj_sections): Initialize obj,
9274         declare it closer to its usage.
9275
9276 2019-01-10  Tom Tromey  <tom@tromey.com>
9277
9278         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9279         (basic_inf_threads_range): Remove.
9280         (inf_threads_range, inf_non_exited_threads_range)
9281         (safe_inf_threads_range): Use next_adapter.
9282
9283 2019-01-10  Keith Seitz  <keiths@redhat.com>
9284
9285         PR gdb/23712
9286         PR symtab/23010
9287         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9288         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9289
9290 2019-01-10  Keith Seitz  <keiths@redhat.com>
9291
9292         PR gdb/23712
9293         PR symtab/23010
9294         * dictionary.c (pending_to_vector): Remove.
9295         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9296         Remove _1 suffix, replacing functions of the same name.  Update
9297         all callers.
9298         (dict_create_hashed, dict_create_hashed_expandable)
9299         (dict_create_linear, dict_create_linear_expandable, dict_free)
9300         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9301         Make functions static.
9302
9303 2019-01-10  Keith Seitz  <keiths@redhat.com>
9304
9305         PR gdb/23712
9306         PR symtab/23010
9307         * dictionary.h (struct dictionary): Replace declaration with
9308         multidictionary.
9309         (dict_create_hashed, dict_create_hashed_expandable)
9310         (dict_create_linear, dict_create_linear_expandable)
9311         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9312         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9313         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9314         taking multidictionary argument.
9315         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9316         * block.h (struct block) <dict>: Change to multidictionary
9317         and rename `multidict'.
9318         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9319         symmisc.c: Update all dictionary references to multidictionary.
9320
9321 2019-01-10  Keith Seitz  <keiths@redhat.com>
9322
9323         PR gdb/23712
9324         PR symtab/23010
9325         * dictionary.c: Include unordered_map.
9326         (pending_to_vector): New function.
9327         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9328         Rewrite the non-"_1" functions to take vector instead
9329         of linked list.
9330         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9331         "new" _1 versions of the same name.
9332         (multidictionary): Define.
9333         (std::hash<enum language): New definition.
9334         (collate_pending_symbols_by_language, mdict_create_hashed)
9335         (mdict_create_hashed_expandable, mdict_create_linear)
9336         (mdict_create_linear_expandable, mdict_free)
9337         (find_language_dictionary, create_new_language_dictionary)
9338         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9339         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9340         (mdict_size, mdict_empty): New functions.
9341         * dictionary.h (mdict_iterator): Define.
9342
9343 2019-01-10  Pedro Alves  <palves@redhat.com>
9344
9345         * breakpoint.c (read_uploaded_action)
9346         (create_tracepoint_from_upload): Adjust to use
9347         gdb::unique_xmalloc_ptr.
9348         * ctf.c (ctf_write_uploaded_tp):
9349         (SET_ARRAY_FIELD): Use emplace_back.
9350         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9351         * tracefile-tfile.c (tfile_write_uploaded_tp):
9352         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9353         gdb::unique_xmalloc_ptr.
9354         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9355         at_string, cond_string, cmd_strings>: Replace char pointers
9356         with gdb::unique_xmalloc_ptr.
9357
9358 2019-01-10  Pedro Alves  <palves@redhat.com>
9359
9360         * solib-target.c (library_list_start_library): Don't xstrdup name.
9361
9362 2019-01-10  Pedro Alves  <palves@redhat.com>
9363
9364         * mdebugread.c (parse_partial_symbols): Use
9365         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9366
9367 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9368
9369         * linux-fork.c (scoped_switch_fork_info)
9370         <~scoped_switch_fork_info>: Fix incorrect variable name.
9371
9372 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9373
9374         * linux-fork.c (scoped_switch_fork_info)
9375         <scoped_switch_fork_info>: Make explicit.
9376         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9377
9378 2019-01-10  Tom Tromey  <tom@tromey.com>
9379
9380         * objfiles.h (objfile::reset_psymtabs): Update.
9381         * objfiles.c (objfile::objfile): Update.
9382         * psymtab.h (psymtab_storage::obstack): Update.
9383         (psymtab_storage::m_obstack): Use gdb::optional.
9384         (class psymtab_storage): Update comment.  Remove objfile
9385         parameter.
9386         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9387
9388 2019-01-10  Tom Tromey  <tom@tromey.com>
9389
9390         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9391         <free_psymtabs>: Now private.
9392         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9393         (allocate_psymtab): Use new method.
9394
9395 2019-01-10  Tom Tromey  <tom@tromey.com>
9396
9397         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9398         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9399         * mdebugread.c (parse_partial_symbols): Use
9400         allocate_dependencies.
9401         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9402         allocate_dependencies.
9403         (process_psymtab_comp_unit_reader)
9404         (build_type_psymtab_dependencies): Likewise.
9405         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9406
9407 2019-01-10  Tom Tromey  <tom@tromey.com>
9408
9409         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9410         PSYMBOL_SET_LANGUAGE.
9411         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9412
9413 2019-01-10  Tom Tromey  <tom@tromey.com>
9414
9415         * psymtab.h (psymtab_storage::obstack): New method.
9416         <m_obstack>: Rename from obstack; now private.
9417         * psymtab.c (psymtab_storage): Update.
9418         * dwarf2read.c (create_addrmap_from_index)
9419         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9420         Update.
9421
9422 2019-01-10  Tom Tromey  <tom@tromey.com>
9423
9424         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9425         * objfiles.h (objfile::reset_psymtabs): New method.
9426
9427 2019-01-10  Tom Tromey  <tom@tromey.com>
9428
9429         * symmisc.c (print_symbol_bcache_statistics): Update.
9430         (print_objfile_statistics): Update.
9431         * symfile.c (reread_symbols): Update.
9432         * psymtab.h (class psymtab_storage): New.
9433         * psymtab.c (psymtab_storage): New constructor.
9434         (~psymtab_storage): New destructor.
9435         (require_partial_symbols): Update.
9436         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9437         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9438         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9439         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9440         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9441         (start_psymtab_common, end_psymtab_common)
9442         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9443         (allocate_psymtab): Update.
9444         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9445         Update.
9446         (dump_psymtab_addrmap, maintenance_print_psymbols)
9447         (maintenance_check_psymtabs): Update.
9448         (class objfile_psymtabs): Move to objfiles.h.
9449         * psympriv.h (discard_psymtab): Now inline.
9450         (psymtab_discarder::psymtab_discarder): Update.
9451         (psymtab_discarder::~psymtab_discarder): Update.
9452         (ALL_OBJFILE_PSYMTABS): Rewrite.
9453         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9454         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9455         Remove fields.
9456         <partial_symtabs>: New field.
9457         (class objfile_psymtabs): Move from psymtab.h.  Update.
9458         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9459         psymbol_cache.
9460         (objfile::~objfile): Don't destroy psymbol_cache.
9461         * mdebugread.c (parse_partial_symbols): Update.
9462         * dwarf2read.c (create_addrmap_from_index)
9463         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9464         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9465         (add_partial_subprogram, dwarf2_ranges_read): Update.
9466         * dwarf-index-write.c (write_address_map)
9467         (write_one_signatured_type, recursively_write_psymbols)
9468         (class debug_names, class debug_names, write_psymtabs_to_index):
9469         Update.
9470
9471 2019-01-10  Tom Tromey  <tom@tromey.com>
9472
9473         * symtab.h (SYMBOL_SET_NAMES): Update.
9474         (symbol_set_names): Update.
9475         (MSYMBOL_SET_NAMES): Update.
9476         * symtab.c (symbol_set_names): Change argument to be an
9477         objfile_per_bfd_storage.
9478         * psymtab.c (add_psymbol_to_bcache): Update.
9479         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9480
9481 2019-01-10  Tom Tromey  <tom@tromey.com>
9482
9483         * symtab.c (create_demangled_names_hash): Change argument to be an
9484         objfile_per_bfd_storage.
9485         (symbol_set_names): Update.
9486
9487 2019-01-10  Tom Tromey  <tom@tromey.com>
9488
9489         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9490         init_psymbol_list.
9491         * psymtab.c (init_psymbol_list): Do nothing if already called.
9492         * psympriv.h (init_psymbol_list): Add comment.
9493         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9494         init_psymbol_list.
9495         * dbxread.c (dbx_symfile_read): Unconditionally call
9496         init_psymbol_list.
9497
9498 2019-01-10  Tom Tromey  <tom@tromey.com>
9499
9500         * xcoffread.c (scan_xcoff_symtab): Update.
9501         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9502         "where".
9503         * mdebugread.c (parse_partial_symbols)
9504         (handle_psymbol_enumerators): Update.
9505         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9506         * dbxread.c (read_dbx_symtab): Update.
9507         * psympriv.h (psymbol_placement): New enum.
9508         (add_psymbol_to_list): Update.
9509
9510 2019-01-10  Tom Tromey  <tom@tromey.com>
9511
9512         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9513         static_psymbols parameters.
9514         (scan_xcoff_symtab): Update.
9515         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9516         static_psymbols parameters.
9517         * psympriv.h (start_psymtab_common): Update.
9518         * mdebugread.c (parse_partial_symbols): Update.
9519         * dwarf2read.c (create_partial_symtab): Update.
9520         * dbxread.c (read_dbx_symtab): Update.
9521         (start_psymtab): Remove global_psymbols and static_psymbols
9522         parameters.
9523
9524 2019-01-10  Tom Tromey  <tom@tromey.com>
9525
9526         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9527         * psymtab.c (allocate_psymtab): Add comment.
9528         * psympriv.h (allocate_psymtab): Add comment.
9529         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9530         initializations.
9531         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9532
9533 2019-01-10  Tom Tromey  <tom@tromey.com>
9534
9535         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9536         Don't declare.
9537         * mipsread.c: Include mdebugread.h.
9538         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9539         Declare.
9540         * elfread.c: Include mdebugread.h.
9541
9542 2019-01-09  Tom Tromey  <tom@tromey.com>
9543
9544         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9545         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9546         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9547         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9548         (psym_lookup_symbol, psym_find_last_source_symtab)
9549         (psym_forget_cached_source_info, psym_print_stats)
9550         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9551         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9552         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9553         (psym_find_compunit_symtab_by_address)
9554         (maintenance_print_psymbols, maintenance_info_psymtabs)
9555         (maintenance_check_psymtabs): Use ranged for.
9556         * psymtab.h (class objfile_psymtabs): New.
9557         (require_partial_symbols): Return objfile_psymtabs.
9558         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9559
9560 2019-01-09  Tom Tromey  <tom@tromey.com>
9561
9562         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9563         (find_pc_mapped_section, list_overlays_command)
9564         (map_overlay_command, unmap_overlay_command)
9565         (simple_overlay_update): Use all_objfiles.
9566         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9567         * printcmd.c (info_symbol_command): Use all_objfiles.
9568         * objfiles.h (ALL_OBJSECTIONS): Remove.
9569         * maint.c (maintenance_translate_address): Use all_objfiles.
9570         * gcore.c (gcore_create_callback): Use all_objfiles.
9571         (objfile_find_memory_regions): Likewise.
9572
9573 2019-01-09  Tom Tromey  <tom@tromey.com>
9574
9575         * symtab.c (find_line_symtab, info_sources_command)
9576         (make_source_files_completion_list): Use objfile_compunits.
9577         * source.c (select_source_symtab): Use objfile_compunits.
9578         * objfiles.h (struct objfile): Update comment.
9579         (ALL_OBJFILES): Remove.
9580         (ALL_FILETABS): Remove.
9581         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9582         objfile_compunits.
9583
9584 2019-01-09  Tom Tromey  <tom@tromey.com>
9585
9586         * symmisc.c (print_objfile_statistics, dump_objfile)
9587         (maintenance_print_symbols): Use compunit_filetabs.
9588         * source.c (forget_cached_source_info_for_objfile): Use
9589         compunit_filetabs.
9590         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9591         (ALL_FILETABS): Use compunit_filetabs.
9592         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9593         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9594
9595 2019-01-09  Tom Tromey  <tom@tromey.com>
9596
9597         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9598         (compunit_filetabs): New.
9599         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9600         compunit_filetabs.
9601         (info_sources_command, make_source_files_completion_list): Remove
9602         declaration.
9603         * symmisc.c (print_objfile_statistics, dump_objfile)
9604         (maintenance_print_symbols): Remove declaration.
9605         (maintenance_info_symtabs): Use compunit_filetabs.
9606         (maintenance_info_line_tables): Likewise.
9607         * source.c (select_source_symtab): Change local variable name.
9608         (forget_cached_source_info_for_objfile): Remove declaration.
9609         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9610         * objfiles.c (objfile_relocate1): Remove declaration.
9611         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9612         declaration.
9613         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9614         * coffread.c (coff_symtab_read): Remove declaration.
9615         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9616         compunit_filetabs.
9617
9618 2019-01-09  Tom Tromey  <tom@tromey.com>
9619
9620         * symtab.c (lookup_objfile_from_block)
9621         (find_pc_sect_compunit_symtab, search_symbols)
9622         (default_collect_symbol_completion_matches_break_on): Use
9623         objfile_compunits.
9624         * objfiles.h (ALL_COMPUNITS): Remove.
9625         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9626         * cp-support.c (add_symbol_overload_list_qualified): Use
9627         objfile_compunits.
9628         * ada-lang.c (ada_collect_symbol_completion_matches)
9629         (ada_add_global_exceptions): Use objfile_compunits.
9630
9631 2019-01-09  Tom Tromey  <tom@tromey.com>
9632
9633         * source.c (select_source_symtab)
9634         (forget_cached_source_info_for_objfile): Remove declaration.
9635         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9636         declaration.
9637         * maint.c (count_symtabs_and_blocks): Remove declaration.
9638         * cp-support.c (add_symbol_overload_list_qualified): Remove
9639         declaration.
9640         * coffread.c (coff_symtab_read): Remove declaration.
9641         * symtab.c (lookup_symbol_in_objfile_symtabs)
9642         (basic_lookup_transparent_type_1): Use objfile_compunits.
9643         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9644         (info_sources_command, search_symbols)
9645         (default_collect_symbol_completion_matches_break_on)
9646         (make_source_files_completion_list): Remove declaration.
9647         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9648         (ada_collect_symbol_completion_matches)
9649         (ada_add_global_exceptions): Remove declaration.
9650         * linespec.c (iterate_over_all_matching_symtabs): Use
9651         objfile_compunits.
9652         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9653         (class objfile_compunits): New.
9654         (ALL_COMPUNITS): Use objfile_compunits.
9655         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9656         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9657         objfile_compunits.
9658         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9659
9660 2019-01-09  Tom Tromey  <tom@tromey.com>
9661
9662         * symtab.c (search_symbols)
9663         (default_collect_symbol_completion_matches_break_on): Use
9664         objfile_msymbols.
9665         * ada-lang.c (ada_lookup_simple_minsym)
9666         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9667         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9668         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9669         objfile_msymbols.
9670         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9671         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9672         * objc-lang.c (find_methods): Use objfile_msymbols.
9673         (info_selectors_command, info_classes_command): Likewise.
9674         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9675         * objfiles.h (class objfile_msymbols): New.
9676         (ALL_OBJFILE_MSYMBOLS): Remove.
9677         (ALL_MSYMBOLS): Remove.
9678
9679 2019-01-09  Tom Tromey  <tom@tromey.com>
9680
9681         * common/next-iterator.h (next_adapter): Add Iterator template
9682         parameter.
9683         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9684         (class all_objfiles_safe): New.
9685         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9686         * objfiles.c (put_objfile_before): Update comment.
9687         (add_separate_debug_objfile): Likewise.
9688         (free_all_objfiles): Use all_objfiles_safe.
9689         (objfile_purge_solibs): Likewise.
9690
9691 2019-01-09  Tom Tromey  <tom@tromey.com>
9692
9693         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9694         (expand_symtab_containing_pc, lookup_static_symbol)
9695         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9696         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9697         all_objfiles.
9698         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9699         * breakpoint.c (create_overlay_event_breakpoint)
9700         (create_longjmp_master_breakpoint)
9701         (create_std_terminate_master_breakpoint)
9702         (create_exception_master_breakpoint): Use all_objfiles.
9703         * linux-thread-db.c (try_thread_db_load_from_pdir)
9704         (has_libpthread): Use all_objfiles.
9705         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9706         * linespec.c (iterate_over_all_matching_symtabs)
9707         (search_minsyms_for_name): Use all_objfiles.
9708         * maint.c (maintenance_info_sections): Use all_objfiles.
9709         * main.c (captured_main_1): Use all_objfiles.
9710         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9711         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9712         * guile/scm-pretty-print.c
9713         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9714         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9715         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9716         (maintenance_print_msymbols): Use all_objfiles.
9717         * source.c (select_source_symtab): Use all_objfiles.
9718         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9719         * symfile.c (remove_symbol_file_command)
9720         (expand_symtabs_matching, map_symbol_filenames): Use
9721         all_objfiles.
9722         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9723         all_objfiles.
9724         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9725         * objc-lang.c (find_methods): Use all_objfiles.
9726         * objfiles.c (have_partial_symbols, have_full_symbols)
9727         (have_minimal_symbols, qsort_cmp)
9728         (default_iterate_over_objfiles_in_search_order): Use
9729         all_objfiles.
9730         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9731         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9732         (maintenance_check_psymtabs): Use all_objfiles.
9733         (ALL_PSYMTABS): Remove.
9734         * compile/compile-object-run.c (do_module_cleanup): Use
9735         all_objfiles.
9736         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9737         * cp-support.c (add_symbol_overload_list_qualified): Use
9738         all_objfiles.
9739         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9740         Use all_objfiles.
9741         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9742         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9743         all_objfiles.
9744         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9745         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9746         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9747         Uses all_objfiles.
9748         * solib.c (solib_read_symbols): Use all_objfiles
9749
9750 2019-01-09  Tom Tromey  <tom@tromey.com>
9751
9752         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9753         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9754         all_objfiles.
9755         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9756         * symmisc.c (print_symbol_bcache_statistics)
9757         (print_objfile_statistics, maintenance_print_objfiles)
9758         (maintenance_info_symtabs, maintenance_check_symtabs)
9759         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9760         all_objfiles.
9761         * source.c (forget_cached_source_info): Use all_objfiles.
9762         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9763         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9764         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9765         * objfiles.c (update_section_map): Use all_objfiles.
9766         (shared_objfile_contains_address_p): Likewise.
9767         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9768         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9769
9770 2019-01-09  Tom Tromey  <tom@tromey.com>
9771
9772         * common/next-iterator.h: New file.
9773         * objfiles.h (class all_objfiles): New.
9774         (struct objfile_iterator): New.
9775
9776 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9777
9778         * NEWS: Move the description of the changed "frame", "select-frame",
9779          and "info frame" commands to the Changed commands section.
9780
9781 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9782
9783         * gdbtypes.c (check_stub_method_group): Remove handling of old
9784         mangling schemes.
9785         * linespec.c (find_methods): Likewise.
9786         * stabsread.c (read_member_functions): Likewise.
9787         * valops.c (search_struct_method): Likewise.
9788         (value_struct_elt_for_reference): Likewise.
9789         * NEWS: Mention this change.
9790
9791 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9792
9793         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9794         print_source_lines.
9795         * source.c (print_source_lines_base): Update line number check.
9796         (print_source_lines): New function.
9797         (source_lines_range::source_lines_range): New function.
9798         * source.h (class source_lines_range): New class.
9799         (print_source_lines): New declaration.
9800
9801 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9802
9803         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9804
9805 2019-01-08  Tom Tromey  <tom@tromey.com>
9806             Simon Marchi  <simon.marchi@ericsson.com>
9807
9808         PR gdb/24060
9809         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9810         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9811         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9812         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9813         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9814         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9815
9816 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9817
9818         * source.c (select_source_symtab): Move header comment to
9819         declaration in source.h.
9820         (forget_cached_source_info_for_objfile): Likewise.
9821         (forget_cached_source_info): Likewise.
9822         (identify_source_line): Likewise.
9823         * source.h (identify_source_line): Move declaration from symtab.h
9824         and add comment from source.c
9825         (print_source_lines): Likewise.
9826         (forget_cached_source_info_for_objfile): Likewise.
9827         (forget_cached_source_info): Likewise.
9828         (select_source_symtab): Likewise.
9829         (enum print_source_lines_flag): Move definition from symtab.h.
9830         * symtab.h (identify_source_line): Move declaration to source.h.
9831         (print_source_lines): Likewise.
9832         (forget_cached_source_info_for_objfile): Likewise.
9833         (forget_cached_source_info): Likewise.
9834         (select_source_symtab): Likewise.
9835         (enum print_source_lines_flag): Move definition to source.h.
9836         * tui/tui-hooks.c: Add 'source.h' include.
9837
9838 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9839
9840         * source.c (print_source_lines_base): Handle requests to print
9841         reverse line number sequences, and guard against empty lines
9842         string.
9843
9844 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9845
9846         * source.c (print_source_lines_base): Fix skip of '\r' if next
9847         character is '\n'.
9848
9849 2019-01-06  Tom Tromey  <tom@tromey.com>
9850
9851         * c-exp.y (struct c_parse_state) <macro_original_text,
9852         expansion_obstack>: New member.
9853         (macro_original_text, expansion_obstack): Remove globals.
9854         (scan_macro_expansion, scanning_macro_expansion)
9855         (finished_macro_expansion): Update.
9856         (scan_macro_cleanup): Remove.
9857         (yylex, c_parse): Update.
9858
9859 2019-01-06  Tom Tromey  <tom@tromey.com>
9860
9861         * c-exp.y (struct c_parse_state) <strings>: New member.
9862         (operator_stoken): Update.
9863
9864 2019-01-06  Tom Tromey  <tom@tromey.com>
9865
9866         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9867         (union type_stack_elt) <typelist_val>: Now a pointer to
9868         std::vector.
9869         (type_stack_cleanup): Don't declare.
9870         (push_typelist): Update.
9871         * parse.c (pop_typelist): Return a std::vector.
9872         (push_typelist): Take a std::vector.
9873         (follow_types): Update.  Do not free args.
9874         (type_stack_cleanup): Remove.
9875         * c-exp.y (struct c_parse_state): New.
9876         (cpstate): New global.
9877         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9878         (nonempty_typelist): Update.
9879         (func_mod): Create a new vector.
9880         (c_parse): Create a c_parse_state.
9881         (check_parameter_typelist): Do not delete params.
9882         (function_method): Update.  Do not delete type_list.
9883
9884 2019-01-06  Tom Tromey  <tom@tromey.com>
9885
9886         PR gdb/28155:
9887         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9888         check_typedef.
9889         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9890         (print_return_value): Likewise.
9891
9892 2019-01-05  Tom Tromey  <tom@tromey.com>
9893
9894         * contrib/cleanup_check.py: Remove.
9895         * contrib/gcc-with-excheck: Remove.
9896         * contrib/exsummary.py: Remove.
9897         * contrib/excheck.py: Remove.
9898
9899 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9900
9901         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9902         NULL. Initialize tpprev to NULL instead of assigning it
9903         to NULL on the next statement.
9904         * windows-nat.c (windows_delete_thread): Remove check for
9905         main_thread_id before printing thread exit notifications.
9906         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9907         Remove thread ID check against main_thread_id.
9908         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9909         windows_delete_thread.
9910         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9911
9912 2019-01-04  Tom Tromey  <tom@tromey.com>
9913
9914         * compile/compile.c (_initialize_compile): Use upper case for
9915         metasyntactic variables.
9916         * symmisc.c (_initialize_symmisc): Use upper case for
9917         metasyntactic variables.
9918         * psymtab.c (_initialize_psymtab): Use upper case for
9919         metasyntactic variables.
9920         * demangle.c (demangle_command): Use upper case for metasyntactic
9921         variables.
9922         (_initialize_demangler): Likewise.
9923         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9924         variables.
9925
9926 2019-01-03  Tom Tromey  <tom@tromey.com>
9927
9928         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9929
9930 2019-01-03  Tom Tromey  <tom@tromey.com>
9931
9932         * python/py-symtab.c (salpy_str): Update.
9933         (struct salpy_sal_object) <symtab>: Now a PyObject.
9934         (salpy_dealloc): Update.
9935         (del_objfile_sal): Use gdbpy_ref.
9936
9937 2019-01-03  Tom Tromey  <tom@tromey.com>
9938
9939         * python/py-type.c (convert_field): Use new_reference.  Return
9940         gdbpy_ref.
9941         (make_fielditem): Return gdbpy_ref.
9942         (typy_fields): Update.
9943         (typy_getitem): Update.
9944         (field_name): Return gdbpy_ref.  Use new_reference.
9945         (typy_iterator_iternext): Update.
9946
9947 2019-01-03  Tom Tromey  <tom@tromey.com>
9948
9949         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9950
9951 2019-01-03  Tom Tromey  <tom@tromey.com>
9952
9953         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9954         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9955         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9956         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9957         (pspy_set_type_printers): Likewise.
9958         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9959         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9960         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9961         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9962         (objfpy_set_type_printers): Likewise.
9963
9964 2019-01-03  Tom Tromey  <tom@tromey.com>
9965
9966         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9967         (gdbpy_print_stack): Use gdbpy_err_fetch.
9968         * python/python-internal.h (class gdbpy_err_fetch): New class.
9969         (class gdbpy_enter) <m_error_type, m_error_value,
9970         m_error_traceback>: Remove.
9971         <m_error>: New member.
9972         (gdbpy_exception_to_string): Don't declare.
9973         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9974         * python/py-value.c (convert_value_from_python): Use
9975         gdbpy_err_fetch.
9976         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9977         gdbpy_exception_to_string.
9978         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9979         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9980         gdbpy_err_fetch.
9981
9982 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9983
9984         * linux-nat.c (delete_lwp_cleanup): Delete.
9985         (struct lwp_deleter): New struct.
9986         (lwp_info_up): New typedef.
9987         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9988         lwp_info_up.
9989
9990 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9991
9992         * linux-fork.c (class scoped_switch_fork_info): New class.
9993         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9994
9995 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9996
9997         * valops.c (find_overload_match): Remove use of null_cleanup, and
9998         calls to do_cleanups.
9999
10000 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10001
10002         * compile/compile-cplus-types.c
10003         (compile_cplus_instance::decl_name): Handle changes to
10004         cp_func_name.
10005         * cp-support.c (cp_func_name): Update header comment, update
10006         return type.
10007         * cp-support.h (cp_func_name): Update return type in declaration.
10008         * valops.c (find_overload_match): Move temp_func local to top
10009         level of function and change its type.  Use temp_func to hold and
10010         delete temporary string obtained from cp_func_name.
10011
10012 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10013
10014         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10015         gdb::char_vector, remove cleanup, and update uses of `msg`.
10016
10017 2019-01-03  Jim Wilson  <jimw@sifive.com>
10018
10019         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10020
10021 2019-01-02  Tom Tromey  <tom@tromey.com>
10022
10023         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10024         (tdesc_parse_xml): Remove cleanups.
10025         * target-descriptions.h (make_cleanup_free_target_description):
10026         Don't declare.
10027         (target_desc_deleter): New struct.
10028         (target_desc_up): New typedef.
10029         * target-descriptions.c (target_desc_deleter::operator()): Rename
10030         from free_target_description.
10031         (make_cleanup_free_target_description): Remove.
10032
10033 2019-01-02  Tom Tromey  <tom@tromey.com>
10034
10035         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10036         constructor, destructor.
10037         (linespec_parser): Remove typedef.
10038         (~linespec_parser): Rename from linespec_parser_delete.
10039         (linespec_lex_to_end, linespec_complete_label)
10040         (linespec_complete): Update.
10041         (decode_line_full): Remove cleanups.
10042         (decode_line_1): Update.
10043
10044 2019-01-02  Tom Tromey  <tom@tromey.com>
10045
10046         * python/python-internal.h (inferior_to_inferior_object): Change
10047         return type.
10048         * python/py-exitedevent.c (create_exited_event_object): Update.
10049         * python/py-inferior.c (inferior_to_inferior_object): Return
10050         gdbpy_ref.
10051         (python_new_inferior, python_inferior_deleted)
10052         (thread_to_thread_object, delete_thread_object)
10053         (build_inferior_list, gdbpy_selected_inferior): Update.
10054         * python/py-infthread.c (create_thread_object): Update.  Also fail
10055         if inferior_to_inferior_object fails.
10056
10057 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10058
10059         * inferior.h (class inferior) <displaced_step_state>: New field.
10060         * infrun.h (struct displaced_step_state): Move here from
10061         infrun.c.  Initialize fields, add constructor.
10062         <inf>: Remove field.
10063         <reset>: New method.
10064         * infrun.c (struct displaced_step_inferior_state): Move to
10065         infrun.h.
10066         (displaced_step_inferior_states): Remove.
10067         (get_displaced_stepping_state): Adust.
10068         (displaced_step_in_progress_any_inferior): Adjust.
10069         (displaced_step_in_progress_thread): Adjust.
10070         (displaced_step_in_progress): Adjust.
10071         (add_displaced_stepping_state): Remove.
10072         (get_displaced_step_closure_by_addr): Adjust.
10073         (remove_displaced_stepping_state): Remove.
10074         (infrun_inferior_exit): Call displaced_step_state.reset.
10075         (use_displaced_stepping): Don't check for NULL.
10076         (displaced_step_prepare_throw): Call
10077         get_displaced_stepping_state.
10078         (displaced_step_fixup): Don't check for NULL.
10079         (prepare_for_detach): Don't check for NULL.
10080
10081 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10082
10083         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10084          in case of call that did not complete.
10085
10086 2019-01-02  Andrey Utkin  <autkin@undo.io>
10087
10088         * symfile.c (find_separate_debug_file): Fix search of debug files for
10089         remote debuggee.
10090
10091 2019-01-02  Tom Tromey  <tom@tromey.com>
10092
10093         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10094         indentation.
10095         * python/py-frame.c (frapy_older): Remove cast.
10096         (frapy_newer): Likewise.
10097         * python/py-breakpoint.c (local_setattro): Remove cast.
10098         * python/py-arch.c (archpy_name): Remove local variable.
10099         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10100
10101 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10102
10103         * unittests/basic_string_view/element_access/char/empty.cc:
10104         Fix year range in copyright header.
10105
10106 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10107
10108         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10109         Delete.
10110         <operator==>: Update with for removed field.
10111         <hash>: Likewise.
10112         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10113         <isa_features>: ...this.
10114         <abi_features>: New field.
10115         (riscv_isa_flen): Update comment.
10116         (riscv_abi_xlen): New declaration.
10117         (riscv_abi_flen): New declaration.
10118         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10119         isa_features.
10120         (riscv_abi_xlen): New function.
10121         (riscv_isa_flen): Update to get answer from isa_features.
10122         (riscv_abi_flen): New function.
10123         (riscv_has_fp_abi): Update to get answer from abi_features.
10124         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10125         xlen and flen.
10126         (riscv_call_info) <xlen, flen>: Update comment.
10127         (riscv_call_arg_struct): Remove invalid assertions
10128         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10129         is removed.
10130         (riscv_gdbarch_init): Gather isa features and abi features
10131         separately, ensure both match on the gdbarch when reusing an old
10132         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10133         a target with 64-bit float hardware.
10134
10135 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10136
10137         * source.c (search_command_helper): Stop reverse search
10138         when line 1 has been searched.
10139
10140 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10141
10142         * record-full.c (record_full_base_target::close): Rewrite
10143         record_full_core_buf_list free logic.
10144
10145 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10146
10147         * break-catch-syscall.c (print_one_catch_syscall): xfree
10148         the last text.
10149
10150 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10151
10152         * top.c (print_gdb_version): Update Copyright year in version
10153         message.
10154
10155 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10156
10157         Update copyright year range in all GDB files.
10158
10159 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10160
10161         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10162
10163 For older changes see ChangeLog-2018.
10164 \f
10165 Local Variables:
10166 mode: change-log
10167 left-margin: 8
10168 fill-column: 74
10169 version-control: never
10170 coding: utf-8
10171 End:
10172