gdb/ChangeLog

   1 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
   4         Remove arg prefixname, add do_set and do_show.
   5         Add member functions set_list and show_list.
   6         * cli/cli-style.c (class cli_style_option): Update accordingly.
   7         (style_set_list): Move to file scope.
   8         (style_show_list): Likewise.
   9         (set_style): Call help_list.
  10         (show_style): Call cmd_show_list.
  11         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
  12         Update to use the new macro.
  13
  14 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
  15
  16         * ada-lang.c (_initialize_ada_language): Expand the help text
  17         for the "catch exception" command.
  18
  19 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  20
  21         * symtab.c (matching_obj_sections): Initialize obj,
  22         declare it closer to its usage.
  23
  24 2019-01-10  Tom Tromey  <tom@tromey.com>
  25
  26         * thread-iter.h (inf_threads_iterator): Use next_iterator.
  27         (basic_inf_threads_range): Remove.
  28         (inf_threads_range, inf_non_exited_threads_range)
  29         (safe_inf_threads_range): Use next_adapter.
  30
  31 2019-01-10  Keith Seitz  <keiths@redhat.com>
  32
  33         PR gdb/23712
  34         PR symtab/23010
  35         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
  36         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
  37
  38 2019-01-10  Keith Seitz  <keiths@redhat.com>
  39
  40         PR gdb/23712
  41         PR symtab/23010
  42         * dictionary.c (pending_to_vector): Remove.
  43         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
  44         Remove _1 suffix, replacing functions of the same name.  Update
  45         all callers.
  46         (dict_create_hashed, dict_create_hashed_expandable)
  47         (dict_create_linear, dict_create_linear_expandable, dict_free)
  48         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
  49         Make functions static.
  50
  51 2019-01-10  Keith Seitz  <keiths@redhat.com>
  52
  53         PR gdb/23712
  54         PR symtab/23010
  55         * dictionary.h (struct dictionary): Replace declaration with
  56         multidictionary.
  57         (dict_create_hashed, dict_create_hashed_expandable)
  58         (dict_create_linear, dict_create_linear_expandable)
  59         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
  60         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
  61         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
  62         taking multidictionary argument.
  63         [ALL_DICT_SYMBOLS]: Update for multidictionary.
  64         * block.h (struct block) <dict>: Change to multidictionary
  65         and rename `multidict'.
  66         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
  67         symmisc.c: Update all dictionary references to multidictionary.
  68
  69 2019-01-10  Keith Seitz  <keiths@redhat.com>
  70
  71         PR gdb/23712
  72         PR symtab/23010
  73         * dictionary.c: Include unordered_map.
  74         (pending_to_vector): New function.
  75         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
  76         Rewrite the non-"_1" functions to take vector instead
  77         of linked list.
  78         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
  79         "new" _1 versions of the same name.
  80         (multidictionary): Define.
  81         (std::hash<enum language): New definition.
  82         (collate_pending_symbols_by_language, mdict_create_hashed)
  83         (mdict_create_hashed_expandable, mdict_create_linear)
  84         (mdict_create_linear_expandable, mdict_free)
  85         (find_language_dictionary, create_new_language_dictionary)
  86         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
  87         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
  88         (mdict_size, mdict_empty): New functions.
  89         * dictionary.h (mdict_iterator): Define.
  90
  91 2019-01-10  Pedro Alves  <palves@redhat.com>
  92
  93         * breakpoint.c (read_uploaded_action)
  94         (create_tracepoint_from_upload): Adjust to use
  95         gdb::unique_xmalloc_ptr.
  96         * ctf.c (ctf_write_uploaded_tp):
  97         (SET_ARRAY_FIELD): Use emplace_back.
  98         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
  99         * tracefile-tfile.c (tfile_write_uploaded_tp):
 100         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 101         gdb::unique_xmalloc_ptr.
 102         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 103         at_string, cond_string, cmd_strings>: Replace char pointers
 104         with gdb::unique_xmalloc_ptr.
 105
 106 2019-01-10  Pedro Alves  <palves@redhat.com>
 107
 108         * solib-target.c (library_list_start_library): Don't xstrdup name.
 109
 110 2019-01-10  Pedro Alves  <palves@redhat.com>
 111
 112         * mdebugread.c (parse_partial_symbols): Use
 113         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 114
 115 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 116
 117         * linux-fork.c (scoped_switch_fork_info)
 118         <~scoped_switch_fork_info>: Fix incorrect variable name.
 119
 120 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 121
 122         * linux-fork.c (scoped_switch_fork_info)
 123         <scoped_switch_fork_info>: Make explicit.
 124         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 125
 126 2019-01-10  Tom Tromey  <tom@tromey.com>
 127
 128         * objfiles.h (objfile::reset_psymtabs): Update.
 129         * objfiles.c (objfile::objfile): Update.
 130         * psymtab.h (psymtab_storage::obstack): Update.
 131         (psymtab_storage::m_obstack): Use gdb::optional.
 132         (class psymtab_storage): Update comment.  Remove objfile
 133         parameter.
 134         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 135
 136 2019-01-10  Tom Tromey  <tom@tromey.com>
 137
 138         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 139         <free_psymtabs>: Now private.
 140         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 141         (allocate_psymtab): Use new method.
 142
 143 2019-01-10  Tom Tromey  <tom@tromey.com>
 144
 145         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 146         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 147         * mdebugread.c (parse_partial_symbols): Use
 148         allocate_dependencies.
 149         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 150         allocate_dependencies.
 151         (process_psymtab_comp_unit_reader)
 152         (build_type_psymtab_dependencies): Likewise.
 153         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 154
 155 2019-01-10  Tom Tromey  <tom@tromey.com>
 156
 157         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 158         PSYMBOL_SET_LANGUAGE.
 159         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 160
 161 2019-01-10  Tom Tromey  <tom@tromey.com>
 162
 163         * psymtab.h (psymtab_storage::obstack): New method.
 164         <m_obstack>: Rename from obstack; now private.
 165         * psymtab.c (psymtab_storage): Update.
 166         * dwarf2read.c (create_addrmap_from_index)
 167         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 168         Update.
 169
 170 2019-01-10  Tom Tromey  <tom@tromey.com>
 171
 172         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 173         * objfiles.h (objfile::reset_psymtabs): New method.
 174
 175 2019-01-10  Tom Tromey  <tom@tromey.com>
 176
 177         * symmisc.c (print_symbol_bcache_statistics): Update.
 178         (print_objfile_statistics): Update.
 179         * symfile.c (reread_symbols): Update.
 180         * psymtab.h (class psymtab_storage): New.
 181         * psymtab.c (psymtab_storage): New constructor.
 182         (~psymtab_storage): New destructor.
 183         (require_partial_symbols): Update.
 184         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 185         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 186         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 187         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 188         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 189         (start_psymtab_common, end_psymtab_common)
 190         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 191         (allocate_psymtab): Update.
 192         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 193         Update.
 194         (dump_psymtab_addrmap, maintenance_print_psymbols)
 195         (maintenance_check_psymtabs): Update.
 196         (class objfile_psymtabs): Move to objfiles.h.
 197         * psympriv.h (discard_psymtab): Now inline.
 198         (psymtab_discarder::psymtab_discarder): Update.
 199         (psymtab_discarder::~psymtab_discarder): Update.
 200         (ALL_OBJFILE_PSYMTABS): Rewrite.
 201         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 202         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 203         Remove fields.
 204         <partial_symtabs>: New field.
 205         (class objfile_psymtabs): Move from psymtab.h.  Update.
 206         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 207         psymbol_cache.
 208         (objfile::~objfile): Don't destroy psymbol_cache.
 209         * mdebugread.c (parse_partial_symbols): Update.
 210         * dwarf2read.c (create_addrmap_from_index)
 211         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 212         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 213         (add_partial_subprogram, dwarf2_ranges_read): Update.
 214         * dwarf-index-write.c (write_address_map)
 215         (write_one_signatured_type, recursively_write_psymbols)
 216         (class debug_names, class debug_names, write_psymtabs_to_index):
 217         Update.
 218
 219 2019-01-10  Tom Tromey  <tom@tromey.com>
 220
 221         * symtab.h (SYMBOL_SET_NAMES): Update.
 222         (symbol_set_names): Update.
 223         (MSYMBOL_SET_NAMES): Update.
 224         * symtab.c (symbol_set_names): Change argument to be an
 225         objfile_per_bfd_storage.
 226         * psymtab.c (add_psymbol_to_bcache): Update.
 227         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 228
 229 2019-01-10  Tom Tromey  <tom@tromey.com>
 230
 231         * symtab.c (create_demangled_names_hash): Change argument to be an
 232         objfile_per_bfd_storage.
 233         (symbol_set_names): Update.
 234
 235 2019-01-10  Tom Tromey  <tom@tromey.com>
 236
 237         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 238         init_psymbol_list.
 239         * psymtab.c (init_psymbol_list): Do nothing if already called.
 240         * psympriv.h (init_psymbol_list): Add comment.
 241         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 242         init_psymbol_list.
 243         * dbxread.c (dbx_symfile_read): Unconditionally call
 244         init_psymbol_list.
 245
 246 2019-01-10  Tom Tromey  <tom@tromey.com>
 247
 248         * xcoffread.c (scan_xcoff_symtab): Update.
 249         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 250         "where".
 251         * mdebugread.c (parse_partial_symbols)
 252         (handle_psymbol_enumerators): Update.
 253         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 254         * dbxread.c (read_dbx_symtab): Update.
 255         * psympriv.h (psymbol_placement): New enum.
 256         (add_psymbol_to_list): Update.
 257
 258 2019-01-10  Tom Tromey  <tom@tromey.com>
 259
 260         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 261         static_psymbols parameters.
 262         (scan_xcoff_symtab): Update.
 263         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 264         static_psymbols parameters.
 265         * psympriv.h (start_psymtab_common): Update.
 266         * mdebugread.c (parse_partial_symbols): Update.
 267         * dwarf2read.c (create_partial_symtab): Update.
 268         * dbxread.c (read_dbx_symtab): Update.
 269         (start_psymtab): Remove global_psymbols and static_psymbols
 270         parameters.
 271
 272 2019-01-10  Tom Tromey  <tom@tromey.com>
 273
 274         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 275         * psymtab.c (allocate_psymtab): Add comment.
 276         * psympriv.h (allocate_psymtab): Add comment.
 277         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 278         initializations.
 279         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 280
 281 2019-01-10  Tom Tromey  <tom@tromey.com>
 282
 283         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 284         Don't declare.
 285         * mipsread.c: Include mdebugread.h.
 286         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 287         Declare.
 288         * elfread.c: Include mdebugread.h.
 289
 290 2019-01-09  Tom Tromey  <tom@tromey.com>
 291
 292         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 293         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 294         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 295         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 296         (psym_lookup_symbol, psym_find_last_source_symtab)
 297         (psym_forget_cached_source_info, psym_print_stats)
 298         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 299         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 300         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 301         (psym_find_compunit_symtab_by_address)
 302         (maintenance_print_psymbols, maintenance_info_psymtabs)
 303         (maintenance_check_psymtabs): Use ranged for.
 304         * psymtab.h (class objfile_psymtabs): New.
 305         (require_partial_symbols): Return objfile_psymtabs.
 306         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 307
 308 2019-01-09  Tom Tromey  <tom@tromey.com>
 309
 310         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 311         (find_pc_mapped_section, list_overlays_command)
 312         (map_overlay_command, unmap_overlay_command)
 313         (simple_overlay_update): Use all_objfiles.
 314         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 315         * printcmd.c (info_symbol_command): Use all_objfiles.
 316         * objfiles.h (ALL_OBJSECTIONS): Remove.
 317         * maint.c (maintenance_translate_address): Use all_objfiles.
 318         * gcore.c (gcore_create_callback): Use all_objfiles.
 319         (objfile_find_memory_regions): Likewise.
 320
 321 2019-01-09  Tom Tromey  <tom@tromey.com>
 322
 323         * symtab.c (find_line_symtab, info_sources_command)
 324         (make_source_files_completion_list): Use objfile_compunits.
 325         * source.c (select_source_symtab): Use objfile_compunits.
 326         * objfiles.h (struct objfile): Update comment.
 327         (ALL_OBJFILES): Remove.
 328         (ALL_FILETABS): Remove.
 329         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 330         objfile_compunits.
 331
 332 2019-01-09  Tom Tromey  <tom@tromey.com>
 333
 334         * symmisc.c (print_objfile_statistics, dump_objfile)
 335         (maintenance_print_symbols): Use compunit_filetabs.
 336         * source.c (forget_cached_source_info_for_objfile): Use
 337         compunit_filetabs.
 338         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 339         (ALL_FILETABS): Use compunit_filetabs.
 340         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 341         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 342
 343 2019-01-09  Tom Tromey  <tom@tromey.com>
 344
 345         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 346         (compunit_filetabs): New.
 347         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 348         compunit_filetabs.
 349         (info_sources_command, make_source_files_completion_list): Remove
 350         declaration.
 351         * symmisc.c (print_objfile_statistics, dump_objfile)
 352         (maintenance_print_symbols): Remove declaration.
 353         (maintenance_info_symtabs): Use compunit_filetabs.
 354         (maintenance_info_line_tables): Likewise.
 355         * source.c (select_source_symtab): Change local variable name.
 356         (forget_cached_source_info_for_objfile): Remove declaration.
 357         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 358         * objfiles.c (objfile_relocate1): Remove declaration.
 359         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 360         declaration.
 361         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 362         * coffread.c (coff_symtab_read): Remove declaration.
 363         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 364         compunit_filetabs.
 365
 366 2019-01-09  Tom Tromey  <tom@tromey.com>
 367
 368         * symtab.c (lookup_objfile_from_block)
 369         (find_pc_sect_compunit_symtab, search_symbols)
 370         (default_collect_symbol_completion_matches_break_on): Use
 371         objfile_compunits.
 372         * objfiles.h (ALL_COMPUNITS): Remove.
 373         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 374         * cp-support.c (add_symbol_overload_list_qualified): Use
 375         objfile_compunits.
 376         * ada-lang.c (ada_collect_symbol_completion_matches)
 377         (ada_add_global_exceptions): Use objfile_compunits.
 378
 379 2019-01-09  Tom Tromey  <tom@tromey.com>
 380
 381         * source.c (select_source_symtab)
 382         (forget_cached_source_info_for_objfile): Remove declaration.
 383         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 384         declaration.
 385         * maint.c (count_symtabs_and_blocks): Remove declaration.
 386         * cp-support.c (add_symbol_overload_list_qualified): Remove
 387         declaration.
 388         * coffread.c (coff_symtab_read): Remove declaration.
 389         * symtab.c (lookup_symbol_in_objfile_symtabs)
 390         (basic_lookup_transparent_type_1): Use objfile_compunits.
 391         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 392         (info_sources_command, search_symbols)
 393         (default_collect_symbol_completion_matches_break_on)
 394         (make_source_files_completion_list): Remove declaration.
 395         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 396         (ada_collect_symbol_completion_matches)
 397         (ada_add_global_exceptions): Remove declaration.
 398         * linespec.c (iterate_over_all_matching_symtabs): Use
 399         objfile_compunits.
 400         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 401         (class objfile_compunits): New.
 402         (ALL_COMPUNITS): Use objfile_compunits.
 403         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 404         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 405         objfile_compunits.
 406         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 407
 408 2019-01-09  Tom Tromey  <tom@tromey.com>
 409
 410         * symtab.c (search_symbols)
 411         (default_collect_symbol_completion_matches_break_on): Use
 412         objfile_msymbols.
 413         * ada-lang.c (ada_lookup_simple_minsym)
 414         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 415         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 416         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 417         objfile_msymbols.
 418         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 419         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 420         * objc-lang.c (find_methods): Use objfile_msymbols.
 421         (info_selectors_command, info_classes_command): Likewise.
 422         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 423         * objfiles.h (class objfile_msymbols): New.
 424         (ALL_OBJFILE_MSYMBOLS): Remove.
 425         (ALL_MSYMBOLS): Remove.
 426
 427 2019-01-09  Tom Tromey  <tom@tromey.com>
 428
 429         * common/next-iterator.h (next_adapter): Add Iterator template
 430         parameter.
 431         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 432         (class all_objfiles_safe): New.
 433         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 434         * objfiles.c (put_objfile_before): Update comment.
 435         (add_separate_debug_objfile): Likewise.
 436         (free_all_objfiles): Use all_objfiles_safe.
 437         (objfile_purge_solibs): Likewise.
 438
 439 2019-01-09  Tom Tromey  <tom@tromey.com>
 440
 441         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 442         (expand_symtab_containing_pc, lookup_static_symbol)
 443         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 444         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 445         all_objfiles.
 446         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 447         * breakpoint.c (create_overlay_event_breakpoint)
 448         (create_longjmp_master_breakpoint)
 449         (create_std_terminate_master_breakpoint)
 450         (create_exception_master_breakpoint): Use all_objfiles.
 451         * linux-thread-db.c (try_thread_db_load_from_pdir)
 452         (has_libpthread): Use all_objfiles.
 453         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 454         * linespec.c (iterate_over_all_matching_symtabs)
 455         (search_minsyms_for_name): Use all_objfiles.
 456         * maint.c (maintenance_info_sections): Use all_objfiles.
 457         * main.c (captured_main_1): Use all_objfiles.
 458         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 459         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 460         * guile/scm-pretty-print.c
 461         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 462         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 463         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 464         (maintenance_print_msymbols): Use all_objfiles.
 465         * source.c (select_source_symtab): Use all_objfiles.
 466         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 467         * symfile.c (remove_symbol_file_command)
 468         (expand_symtabs_matching, map_symbol_filenames): Use
 469         all_objfiles.
 470         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 471         all_objfiles.
 472         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 473         * objc-lang.c (find_methods): Use all_objfiles.
 474         * objfiles.c (have_partial_symbols, have_full_symbols)
 475         (have_minimal_symbols, qsort_cmp)
 476         (default_iterate_over_objfiles_in_search_order): Use
 477         all_objfiles.
 478         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 479         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 480         (maintenance_check_psymtabs): Use all_objfiles.
 481         (ALL_PSYMTABS): Remove.
 482         * compile/compile-object-run.c (do_module_cleanup): Use
 483         all_objfiles.
 484         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 485         * cp-support.c (add_symbol_overload_list_qualified): Use
 486         all_objfiles.
 487         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 488         Use all_objfiles.
 489         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 490         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 491         all_objfiles.
 492         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 493         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 494         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 495         Uses all_objfiles.
 496         * solib.c (solib_read_symbols): Use all_objfiles
 497
 498 2019-01-09  Tom Tromey  <tom@tromey.com>
 499
 500         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 501         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 502         all_objfiles.
 503         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 504         * symmisc.c (print_symbol_bcache_statistics)
 505         (print_objfile_statistics, maintenance_print_objfiles)
 506         (maintenance_info_symtabs, maintenance_check_symtabs)
 507         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 508         all_objfiles.
 509         * source.c (forget_cached_source_info): Use all_objfiles.
 510         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 511         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 512         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 513         * objfiles.c (update_section_map): Use all_objfiles.
 514         (shared_objfile_contains_address_p): Likewise.
 515         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 516         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 517
 518 2019-01-09  Tom Tromey  <tom@tromey.com>
 519
 520         * common/next-iterator.h: New file.
 521         * objfiles.h (class all_objfiles): New.
 522         (struct objfile_iterator): New.
 523
 524 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 525
 526         * NEWS: Move the description of the changed "frame", "select-frame",
 527          and "info frame" commands to the Changed commands section.
 528
 529 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 530
 531         * gdbtypes.c (check_stub_method_group): Remove handling of old
 532         mangling schemes.
 533         * linespec.c (find_methods): Likewise.
 534         * stabsread.c (read_member_functions): Likewise.
 535         * valops.c (search_struct_method): Likewise.
 536         (value_struct_elt_for_reference): Likewise.
 537         * NEWS: Mention this change.
 538
 539 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 540
 541         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 542         print_source_lines.
 543         * source.c (print_source_lines_base): Update line number check.
 544         (print_source_lines): New function.
 545         (source_lines_range::source_lines_range): New function.
 546         * source.h (class source_lines_range): New class.
 547         (print_source_lines): New declaration.
 548
 549 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 550
 551         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 552
 553 2019-01-08  Tom Tromey  <tom@tromey.com>
 554             Simon Marchi  <simon.marchi@ericsson.com>
 555
 556         PR gdb/24060
 557         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 558         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 559         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 560         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 561         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 562         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 563
 564 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 565
 566         * source.c (select_source_symtab): Move header comment to
 567         declaration in source.h.
 568         (forget_cached_source_info_for_objfile): Likewise.
 569         (forget_cached_source_info): Likewise.
 570         (identify_source_line): Likewise.
 571         * source.h (identify_source_line): Move declaration from symtab.h
 572         and add comment from source.c
 573         (print_source_lines): Likewise.
 574         (forget_cached_source_info_for_objfile): Likewise.
 575         (forget_cached_source_info): Likewise.
 576         (select_source_symtab): Likewise.
 577         (enum print_source_lines_flag): Move definition from symtab.h.
 578         * symtab.h (identify_source_line): Move declaration to source.h.
 579         (print_source_lines): Likewise.
 580         (forget_cached_source_info_for_objfile): Likewise.
 581         (forget_cached_source_info): Likewise.
 582         (select_source_symtab): Likewise.
 583         (enum print_source_lines_flag): Move definition to source.h.
 584         * tui/tui-hooks.c: Add 'source.h' include.
 585
 586 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 587
 588         * source.c (print_source_lines_base): Handle requests to print
 589         reverse line number sequences, and guard against empty lines
 590         string.
 591
 592 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 593
 594         * source.c (print_source_lines_base): Fix skip of '\r' if next
 595         character is '\n'.
 596
 597 2019-01-06  Tom Tromey  <tom@tromey.com>
 598
 599         * c-exp.y (struct c_parse_state) <macro_original_text,
 600         expansion_obstack>: New member.
 601         (macro_original_text, expansion_obstack): Remove globals.
 602         (scan_macro_expansion, scanning_macro_expansion)
 603         (finished_macro_expansion): Update.
 604         (scan_macro_cleanup): Remove.
 605         (yylex, c_parse): Update.
 606
 607 2019-01-06  Tom Tromey  <tom@tromey.com>
 608
 609         * c-exp.y (struct c_parse_state) <strings>: New member.
 610         (operator_stoken): Update.
 611
 612 2019-01-06  Tom Tromey  <tom@tromey.com>
 613
 614         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 615         (union type_stack_elt) <typelist_val>: Now a pointer to
 616         std::vector.
 617         (type_stack_cleanup): Don't declare.
 618         (push_typelist): Update.
 619         * parse.c (pop_typelist): Return a std::vector.
 620         (push_typelist): Take a std::vector.
 621         (follow_types): Update.  Do not free args.
 622         (type_stack_cleanup): Remove.
 623         * c-exp.y (struct c_parse_state): New.
 624         (cpstate): New global.
 625         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 626         (nonempty_typelist): Update.
 627         (func_mod): Create a new vector.
 628         (c_parse): Create a c_parse_state.
 629         (check_parameter_typelist): Do not delete params.
 630         (function_method): Update.  Do not delete type_list.
 631
 632 2019-01-06  Tom Tromey  <tom@tromey.com>
 633
 634         PR gdb/28155:
 635         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 636         check_typedef.
 637         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 638         (print_return_value): Likewise.
 639
 640 2019-01-05  Tom Tromey  <tom@tromey.com>
 641
 642         * contrib/cleanup_check.py: Remove.
 643         * contrib/gcc-with-excheck: Remove.
 644         * contrib/exsummary.py: Remove.
 645         * contrib/excheck.py: Remove.
 646
 647 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 648
 649         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 650         NULL. Initialize tpprev to NULL instead of assigning it
 651         to NULL on the next statement.
 652         * windows-nat.c (windows_delete_thread): Remove check for
 653         main_thread_id before printing thread exit notifications.
 654         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 655         Remove thread ID check against main_thread_id.
 656         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 657         windows_delete_thread.
 658         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 659
 660 2019-01-04  Tom Tromey  <tom@tromey.com>
 661
 662         * compile/compile.c (_initialize_compile): Use upper case for
 663         metasyntactic variables.
 664         * symmisc.c (_initialize_symmisc): Use upper case for
 665         metasyntactic variables.
 666         * psymtab.c (_initialize_psymtab): Use upper case for
 667         metasyntactic variables.
 668         * demangle.c (demangle_command): Use upper case for metasyntactic
 669         variables.
 670         (_initialize_demangler): Likewise.
 671         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 672         variables.
 673
 674 2019-01-03  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 677
 678 2019-01-03  Tom Tromey  <tom@tromey.com>
 679
 680         * python/py-symtab.c (salpy_str): Update.
 681         (struct salpy_sal_object) <symtab>: Now a PyObject.
 682         (salpy_dealloc): Update.
 683         (del_objfile_sal): Use gdbpy_ref.
 684
 685 2019-01-03  Tom Tromey  <tom@tromey.com>
 686
 687         * python/py-type.c (convert_field): Use new_reference.  Return
 688         gdbpy_ref.
 689         (make_fielditem): Return gdbpy_ref.
 690         (typy_fields): Update.
 691         (typy_getitem): Update.
 692         (field_name): Return gdbpy_ref.  Use new_reference.
 693         (typy_iterator_iternext): Update.
 694
 695 2019-01-03  Tom Tromey  <tom@tromey.com>
 696
 697         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 698
 699 2019-01-03  Tom Tromey  <tom@tromey.com>
 700
 701         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 702         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 703         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 704         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 705         (pspy_set_type_printers): Likewise.
 706         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 707         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 708         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 709         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 710         (objfpy_set_type_printers): Likewise.
 711
 712 2019-01-03  Tom Tromey  <tom@tromey.com>
 713
 714         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
 715         (gdbpy_print_stack): Use gdbpy_err_fetch.
 716         * python/python-internal.h (class gdbpy_err_fetch): New class.
 717         (class gdbpy_enter) <m_error_type, m_error_value,
 718         m_error_traceback>: Remove.
 719         <m_error>: New member.
 720         (gdbpy_exception_to_string): Don't declare.
 721         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
 722         * python/py-value.c (convert_value_from_python): Use
 723         gdbpy_err_fetch.
 724         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
 725         gdbpy_exception_to_string.
 726         (gdbpy_handle_exception): Use gdbpy_err_fetch.
 727         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 728         gdbpy_err_fetch.
 729
 730 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 731
 732         * linux-nat.c (delete_lwp_cleanup): Delete.
 733         (struct lwp_deleter): New struct.
 734         (lwp_info_up): New typedef.
 735         (linux_nat_target::follow_fork): Delete cleanup, and make use of
 736         lwp_info_up.
 737
 738 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 739
 740         * linux-fork.c (class scoped_switch_fork_info): New class.
 741         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
 742
 743 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 744
 745         * valops.c (find_overload_match): Remove use of null_cleanup, and
 746         calls to do_cleanups.
 747
 748 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 749
 750         * compile/compile-cplus-types.c
 751         (compile_cplus_instance::decl_name): Handle changes to
 752         cp_func_name.
 753         * cp-support.c (cp_func_name): Update header comment, update
 754         return type.
 755         * cp-support.h (cp_func_name): Update return type in declaration.
 756         * valops.c (find_overload_match): Move temp_func local to top
 757         level of function and change its type.  Use temp_func to hold and
 758         delete temporary string obtained from cp_func_name.
 759
 760 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 761
 762         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
 763         gdb::char_vector, remove cleanup, and update uses of `msg`.
 764
 765 2019-01-03  Jim Wilson  <jimw@sifive.com>
 766
 767         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
 768
 769 2019-01-02  Tom Tromey  <tom@tromey.com>
 770
 771         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
 772         (tdesc_parse_xml): Remove cleanups.
 773         * target-descriptions.h (make_cleanup_free_target_description):
 774         Don't declare.
 775         (target_desc_deleter): New struct.
 776         (target_desc_up): New typedef.
 777         * target-descriptions.c (target_desc_deleter::operator()): Rename
 778         from free_target_description.
 779         (make_cleanup_free_target_description): Remove.
 780
 781 2019-01-02  Tom Tromey  <tom@tromey.com>
 782
 783         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
 784         constructor, destructor.
 785         (linespec_parser): Remove typedef.
 786         (~linespec_parser): Rename from linespec_parser_delete.
 787         (linespec_lex_to_end, linespec_complete_label)
 788         (linespec_complete): Update.
 789         (decode_line_full): Remove cleanups.
 790         (decode_line_1): Update.
 791
 792 2019-01-02  Tom Tromey  <tom@tromey.com>
 793
 794         * python/python-internal.h (inferior_to_inferior_object): Change
 795         return type.
 796         * python/py-exitedevent.c (create_exited_event_object): Update.
 797         * python/py-inferior.c (inferior_to_inferior_object): Return
 798         gdbpy_ref.
 799         (python_new_inferior, python_inferior_deleted)
 800         (thread_to_thread_object, delete_thread_object)
 801         (build_inferior_list, gdbpy_selected_inferior): Update.
 802         * python/py-infthread.c (create_thread_object): Update.  Also fail
 803         if inferior_to_inferior_object fails.
 804
 805 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
 806
 807         * inferior.h (class inferior) <displaced_step_state>: New field.
 808         * infrun.h (struct displaced_step_state): Move here from
 809         infrun.c.  Initialize fields, add constructor.
 810         <inf>: Remove field.
 811         <reset>: New method.
 812         * infrun.c (struct displaced_step_inferior_state): Move to
 813         infrun.h.
 814         (displaced_step_inferior_states): Remove.
 815         (get_displaced_stepping_state): Adust.
 816         (displaced_step_in_progress_any_inferior): Adjust.
 817         (displaced_step_in_progress_thread): Adjust.
 818         (displaced_step_in_progress): Adjust.
 819         (add_displaced_stepping_state): Remove.
 820         (get_displaced_step_closure_by_addr): Adjust.
 821         (remove_displaced_stepping_state): Remove.
 822         (infrun_inferior_exit): Call displaced_step_state.reset.
 823         (use_displaced_stepping): Don't check for NULL.
 824         (displaced_step_prepare_throw): Call
 825         get_displaced_stepping_state.
 826         (displaced_step_fixup): Don't check for NULL.
 827         (prepare_for_detach): Don't check for NULL.
 828
 829 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 830
 831         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
 832          in case of call that did not complete.
 833
 834 2019-01-02  Andrey Utkin  <autkin@undo.io>
 835
 836         * symfile.c (find_separate_debug_file): Fix search of debug files for
 837         remote debuggee.
 838
 839 2019-01-02  Tom Tromey  <tom@tromey.com>
 840
 841         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
 842         indentation.
 843         * python/py-frame.c (frapy_older): Remove cast.
 844         (frapy_newer): Likewise.
 845         * python/py-breakpoint.c (local_setattro): Remove cast.
 846         * python/py-arch.c (archpy_name): Remove local variable.
 847         * python/py-type.c (gdbpy_lookup_type): Remove cast.
 848
 849 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
 850
 851         * unittests/basic_string_view/element_access/char/empty.cc:
 852         Fix year range in copyright header.
 853
 854 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 855
 856         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
 857         Delete.
 858         <operator==>: Update with for removed field.
 859         <hash>: Likewise.
 860         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
 861         <isa_features>: ...this.
 862         <abi_features>: New field.
 863         (riscv_isa_flen): Update comment.
 864         (riscv_abi_xlen): New declaration.
 865         (riscv_abi_flen): New declaration.
 866         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
 867         isa_features.
 868         (riscv_abi_xlen): New function.
 869         (riscv_isa_flen): Update to get answer from isa_features.
 870         (riscv_abi_flen): New function.
 871         (riscv_has_fp_abi): Update to get answer from abi_features.
 872         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
 873         xlen and flen.
 874         (riscv_call_info) <xlen, flen>: Update comment.
 875         (riscv_call_arg_struct): Remove invalid assertions
 876         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
 877         is removed.
 878         (riscv_gdbarch_init): Gather isa features and abi features
 879         separately, ensure both match on the gdbarch when reusing an old
 880         gdbarch.  Relax an error check to allow 32-bit abi float to run on
 881         a target with 64-bit float hardware.
 882
 883 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 884
 885         * source.c (search_command_helper): Stop reverse search
 886         when line 1 has been searched.
 887
 888 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 889
 890         * record-full.c (record_full_base_target::close): Rewrite
 891         record_full_core_buf_list free logic.
 892
 893 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 894
 895         * break-catch-syscall.c (print_one_catch_syscall): xfree
 896         the last text.
 897
 898 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 899
 900         * top.c (print_gdb_version): Update Copyright year in version
 901         message.
 902
 903 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 904
 905         Update copyright year range in all GDB files.
 906
 907 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 908
 909         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
 910
 911 For older changes see ChangeLog-2018.
 912 \f
 913 Local Variables:
 914 mode: change-log
 915 left-margin: 8
 916 fill-column: 74
 917 version-control: never
 918 coding: utf-8
 919 End:
 920