gdb/ChangeLog

   1 2019-03-15  Tom Tromey  <tom@tromey.com>
   2
   3         * objfiles.h (struct objfile_per_bfd_storage): Declare
   4         destructor.
   5         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
   6         New.
   7         (get_objfile_bfd_data): Use new.  Don't initialize
   8         language_of_main.
   9         (free_objfile_per_bfd_storage): Remove.
  10         (objfile_bfd_data_free, objfile::~objfile): Use delete.
  11
  12 2019-03-15  Tom Tromey  <tom@tromey.com>
  13
  14         * symfile.c (reread_symbols): Update.
  15         * objfiles.c (objfile::objfile): Update.
  16         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
  17         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
  18         comment.
  19         (minimal_symbol_reader::install): Update.
  20         (terminate_minimal_symbol_table): Remove.
  21         * jit.c (jit_object_close_impl): Update.
  22
  23 2019-03-15  Tom Tromey  <tom@tromey.com>
  24
  25         * minsyms.c (minimal_symbol_reader::record_full): Remove some
  26         initializations.
  27
  28 2019-03-15  Tom Tromey  <tom@tromey.com>
  29
  30         * objfiles.h (struct objfile_per_bfd_storage)
  31         <demangled_hash_languages>: Now a bitset.
  32         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
  33         (lookup_minimal_symbol): Update.
  34
  35 2019-03-15  Tom Tromey  <tom@tromey.com>
  36
  37         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
  38         Don't return the symbol.
  39         * coffread.c (record_minimal_symbol): Use record_full.
  40
  41 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  42
  43         The MS-Windows port of ncurses fails to switch to a color pair if
  44         one or both of the colors are the implicit default colors.  This
  45         change records the default colors when TUI is initialized, and
  46         then specifies them explicitly when a color pair uses the default
  47         colors.  This allows color styling in TUI mode on MS-Windows.
  48
  49         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  50         ncurses_norm_attr.
  51         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  52         colors in ncurses_norm_attr.
  53         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  54         "none", replace it with the default color recorded in
  55         ncurses_norm_attr.
  56
  57 2019-03-14  Tom Tromey  <tromey@adacore.com>
  58
  59         * source-cache.h (class source_cache) <get_source_lines>: Return
  60         std::string.
  61         * source-cache.c (source_cache::extract_lines): Handle case where
  62         first_pos==npos.  Return std::string.
  63         (source_cache::get_source_lines): Update.
  64
  65 2019-03-14  Tom Tromey  <tromey@adacore.com>
  66
  67         * NEWS: Add item for "style sources" commands.
  68         * source-cache.c (source_cache::get_source_lines): Check
  69         source_styling.
  70         * cli/cli-style.c (source_styling): New global.
  71         (_initialize_cli_style): Add "style sources" commands.
  72         (show_style_sources): New function.
  73         * cli/cli-style.h (source_styling): Declare.
  74
  75 2019-03-14  Pedro Alves  <palves@redhat.com>
  76             Tom Tromey  <tromey@adacore.com>
  77
  78         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  79         * tui/tui-winsource.c (tui_refill_source_window): New function,
  80         from...
  81         (tui_horizontal_source_scroll): ... here.  Move some logic.
  82         * cli/cli-style.c (set_style_enabled): Notify new observable.
  83         * tui/tui-hooks.c (tui_redisplay_source): New function.
  84         (tui_attach_detach_observers): Attach or detach
  85         tui_redisplay_source.
  86         * observable.h (source_styling_changed): New observable.
  87         * observable.c: Define source_styling_changed observable.
  88
  89 2019-03-13  Tom Tromey  <tromey@adacore.com>
  90
  91         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
  92         (i386_gnu_nat_target::store_registers): Update.
  93         * target-debug.h (target_debug_print_std_string): New macro.
  94         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
  95         * windows-tdep.c (display_one_tib): Update.
  96         * tui/tui-stack.c (tui_make_status_line): Update.
  97         * top.c (print_inferior_quit_action): Update.
  98         * thread.c (thr_try_catch_cmd): Update.
  99         (add_thread_with_info): Update.
 100         (thread_target_id_str): Update.
 101         (thr_try_catch_cmd): Update.
 102         (thread_command): Update.
 103         (thread_find_command): Update.
 104         * record-btrace.c (record_btrace_target::info_record)
 105         (record_btrace_resume_thread, record_btrace_target::resume)
 106         (record_btrace_cancel_resume, record_btrace_step_thread)
 107         (record_btrace_target::wait, record_btrace_target::wait)
 108         (record_btrace_target::wait, record_btrace_target::stop): Update.
 109         * progspace.c (print_program_space): Update.
 110         * process-stratum-target.c
 111         (process_stratum_target::thread_address_space): Update.
 112         * linux-fork.c (linux_fork_mourn_inferior)
 113         (detach_checkpoint_command, info_checkpoints_command)
 114         (linux_fork_context): Update.
 115         (linux_fork_detach): Update.
 116         (class scoped_switch_fork_info): Update.
 117         (delete_checkpoint_command): Update.
 118         * infrun.c (follow_fork_inferior): Update.
 119         (follow_fork_inferior): Update.
 120         (proceed_after_vfork_done): Update.
 121         (handle_vfork_child_exec_or_exit): Update.
 122         (follow_exec): Update.
 123         (displaced_step_prepare_throw): Update.
 124         (displaced_step_restore): Update.
 125         (start_step_over): Update.
 126         (resume_1): Update.
 127         (clear_proceed_status_thread): Update.
 128         (proceed): Update.
 129         (print_target_wait_results): Update.
 130         (do_target_wait): Update.
 131         (context_switch): Update.
 132         (stop_all_threads): Update.
 133         (restart_threads): Update.
 134         (finish_step_over): Update.
 135         (handle_signal_stop): Update.
 136         (switch_back_to_stepped_thread): Update.
 137         (keep_going_pass_signal): Update.
 138         (print_exited_reason): Update.
 139         (normal_stop): Update.
 140         * inferior.c (inferior_pid_to_str): Change return type.
 141         (print_selected_inferior): Update.
 142         (add_inferior): Update.
 143         (detach_inferior): Update.
 144         * dummy-frame.c (fprint_dummy_frames): Update.
 145         * dcache.c (dcache_info_1): Update.
 146         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 147         (btrace_fetch, btrace_clear): Update.
 148         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 149         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 150         type.
 151         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 152         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 153         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 154         * gdbarch.c, gdbarch.h: Rebuild.
 155         * gdbarch.sh (core_pid_to_str): Change return type.
 156         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 157         return type.
 158         (windows_nat_target::pid_to_str): Change return type.
 159         (windows_delete_thread): Update.
 160         (windows_nat_target::attach): Update.
 161         (windows_nat_target::files_info): Update.
 162         * target-delegates.c: Rebuild.
 163         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 164         return type.
 165         (sol_thread_target::pid_to_str): Change return type.
 166         * remote.c (class remote_target) <pid_to_str>: Change return
 167         type.
 168         (remote_target::pid_to_str): Change return type.
 169         (extended_remote_target::attach, remote_target::remote_stop_ns)
 170         (remote_target::remote_notif_remove_queued_reply)
 171         (remote_target::push_stop_reply, remote_target::disable_btrace):
 172         Update.
 173         (extended_remote_target::attach): Update.
 174         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 175         type.
 176         (gdbsim_target::pid_to_str): Change return type.
 177         * ravenscar-thread.c (struct ravenscar_thread_target)
 178         <pid_to_str>: Change return type.
 179         (ravenscar_thread_target::pid_to_str): Change return type.
 180         * procfs.c (class procfs_target) <pid_to_str>: Change return
 181         type.
 182         (procfs_target::pid_to_str): Change return type.
 183         (procfs_target::attach): Update.
 184         (procfs_target::detach): Update.
 185         (procfs_target::fetch_registers): Update.
 186         (procfs_target::store_registers): Update.
 187         (procfs_target::wait): Update.
 188         (procfs_target::files_info): Update.
 189         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 190         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 191         return type.
 192         (nto_procfs_target::pid_to_str): Change return type.
 193         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 194         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 195         return type.
 196         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 197         (exit_lwp): Update.
 198         (attach_proc_task_lwp_callback, get_detach_signal)
 199         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 200         (linux_nat_target::resume, wait_lwp, stop_callback)
 201         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 202         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 203         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 204         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 205         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 206         type.
 207         (inf_ptrace_target::attach): Update.
 208         (inf_ptrace_target::files_info): Update.
 209         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 210         type.
 211         (go32_nat_target::pid_to_str): Change return type.
 212         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 213         (gnu_nat_target::wait): Update.
 214         (gnu_nat_target::wait): Update.
 215         (gnu_nat_target::resume): Update.
 216         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 217         (fbsd_nat_target::wait): Update.
 218         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 219         type.
 220         (darwin_nat_target::attach): Update.
 221         * corelow.c (class core_target) <pid_to_str>: Change return type.
 222         (core_target::pid_to_str): Change return type.
 223         * target.c (normal_pid_to_str): Change return type.
 224         (default_pid_to_str): Likewise.
 225         (target_pid_to_str): Change return type.
 226         (target_translate_tls_address): Update.
 227         (target_announce_detach): Update.
 228         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 229         return type.
 230         (bsd_uthread_target::pid_to_str): Change return type.
 231         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 232         type.
 233         (bsd_kvm_target::pid_to_str): Change return type.
 234         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 235         return type.
 236         (aix_thread_target::pid_to_str): Change return type.
 237         * target.h (struct target_ops) <pid_to_str>: Change return type.
 238         (target_pid_to_str, normal_pid_to_str): Likewise.
 239         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 240         type.
 241         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 242         type.
 243         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 244         return type.
 245         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 246         type.
 247         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 248         type.
 249         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 250         return type.
 251
 252 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 253
 254         * NEWS: Mention that the new default MI version is 3.  Mention
 255         changes to the output of commands and events that deal with
 256         multi-location breakpoints.
 257         * breakpoint.c: Include "mi/mi-out.h".
 258         (print_one_breakpoint): Change output syntax if using MI version
 259         >= 3.
 260         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 261         New.
 262         (mi_multi_location_breakpoint_output_fixed): New.
 263         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 264         (mi_cmd_fix_multi_location_breakpoint_output): New.
 265         (mi_multi_location_breakpoint_output_fixed): New.
 266         * mi/mi-cmds.c (mi_cmds): Register command
 267         -fix-multi-location-breakpoint-output.
 268         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 269         interpreter "mi".
 270
 271 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 272
 273         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 274         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 275         instantiate mi_ui_out based on interpreter name.
 276         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 277         * mi/mi-main.c (mi_load_progress): Likewise.
 278
 279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 280
 281         * NEWS: Combine separate "New targets" sections for 8.3.
 282
 283 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 284
 285         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 286         (ppcfbsd_init_abi): Install gdbarch
 287         "fetch_tls_load_module_address" and "get_thread_local_address"
 288         methods.
 289
 290 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 291
 292         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 293         (riscv_fbsd_init_abi): Install gdbarch
 294         "fetch_tls_load_module_address" and "get_thread_local_address"
 295         methods.
 296
 297 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 298
 299         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 300         (i386fbsd_init_abi): Install gdbarch
 301         "fetch_tls_load_module_address" and "get_thread_local_address"
 302         methods.
 303
 304 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 305
 306         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 307         (amd64fbsd_init_abi): Install gdbarch
 308         "fetch_tls_load_module_address" and "get_thread_local_address"
 309         methods.
 310
 311 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 312
 313         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 314         (struct fbsd_pspace_data): New type.
 315         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 316         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 317         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 318         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 319         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 320
 321 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 322
 323         * gdbtypes.c (lookup_struct_elt): New function.
 324         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 325         * gdbtypes.h (struct struct_elt): New type.
 326         (lookup_struct_elt): New prototype.
 327
 328 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 329
 330         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 331         remove disabled code block.
 332
 333 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 334
 335         * gdbarch.sh (get_thread_local_address): New method.
 336         * gdbarch.h, gdbarch.c: Regenerate.
 337         * target.c (target_translate_tls_address): Use
 338         gdbarch_get_thread_local_address if present instead of
 339         target::get_thread_local_address.
 340
 341 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 342
 343         * target.h (target::get_thread_local_address): Update comment.
 344
 345 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 346
 347         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 348         objfile->separate_debug_objfile_backlink if not NULL.
 349
 350 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 351
 352         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 353         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 354         (amd64bsd_store_inferior_registers): Likewise.
 355         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 356         Enable segment base registers.
 357         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 358         PT_GETFSBASE and PT_GETGSBASE.
 359         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 360         PT_SETGSBASE.
 361         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 362         segment base registers.
 363         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 364
 365 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 366
 367         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 368         Update calls to i386_target_description to add 'segments'
 369         parameter.
 370         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 371         add segment base registers.
 372         * arch/i386.c (i386_create_target_description): Add 'segments'
 373         parameter to enable segment base registers.
 374         * arch/i386.h (i386_create_target_description): Likewise.
 375         * features/i386/32bit-segments.xml: New file.
 376         * features/i386/32bit-segments.c: Generate.
 377         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 378         call to i386_target_description to add 'segments' parameter.
 379         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 380         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 381         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 382         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 383         if feature is present.
 384         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 385         Add 'segments' parameter to call to i386_target_description.
 386         (i386_target_description): Add 'segments' parameter to enable
 387         segment base registers.
 388         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 389         to call to i386_target_description.
 390         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 391         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 392         Define I386_NUM_REGS.
 393         (i386_target_description): Add 'segments' parameter to enable
 394         segment base registers.
 395
 396 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 397
 398         PR/24325
 399         * source-cache.c: #undef open and close, to avoid unresolved
 400         externals during linking.
 401
 402 2019-03-12  Tom Tromey  <tromey@adacore.com>
 403
 404         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 405         const.  Add initializers.
 406         (_initialize_remote): Don't initialize ptid globals.
 407
 408 2019-03-12  Pedro Alves  <palves@redhat.com>
 409
 410         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 411
 412 2019-03-12  Pedro Alves  <palves@redhat.com>
 413
 414         * cp-name-parser.y (main): Remove unused 'len' variable.
 415
 416 2019-03-12  Tom Tromey  <tromey@adacore.com>
 417
 418         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 419         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 420
 421 2019-03-12  Tom Tromey  <tromey@adacore.com>
 422
 423         * linux-nat.c (iterate_over_lwps): Update.
 424         (stop_callback): Remove parameter.
 425         (stop_wait_callback, detach_callback, resume_set_callback)
 426         (select_singlestep_lwp_callback, set_ignore_sigint)
 427         (status_callback, resumed_callback, resume_clear_callback)
 428         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 429         data parameter.
 430         (linux_nat_target::detach, linux_nat_target::resume)
 431         (linux_stop_and_wait_all_lwps, select_event_lwp)
 432         (linux_nat_filter_event, linux_nat_wait_1)
 433         (linux_nat_target::kill, linux_nat_target::stop)
 434         (linux_nat_target::stop): Update.
 435         (linux_nat_resume_callback): Change type.
 436         (resume_stopped_resumed_lwps, count_events_callback)
 437         (select_event_lwp_callback): Likewise.
 438         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 439         * arm-linux-nat.c (struct update_registers_data): Remove.
 440         (update_registers_callback): Change type.
 441         (arm_linux_insert_hw_breakpoint1): Update.
 442         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 443         parameter.
 444         (x86_linux_dr_set_addr): Update.
 445         (x86_linux_dr_set_control): Update.
 446         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 447         (iterate_over_lwps): Use gdb::function_view.
 448         * nat/aarch64-linux-hw-point.c (struct
 449         aarch64_dr_update_callback_param): Remove.
 450         (debug_reg_change_callback): Change type.
 451         (aarch64_notify_debug_reg_change): Update.
 452         * s390-linux-nat.c (s390_refresh_per_info): Update.
 453
 454 2019-03-11  Tom Tromey  <tromey@adacore.com>
 455
 456         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 457         redundant assignment to "this_cu".
 458
 459 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 460
 461         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 462
 463 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 464
 465         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 466         from...
 467         (rank_one_type): ... this.
 468
 469 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 470
 471         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 472         from...
 473         (rank_one_type): ... this.
 474
 475 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 476
 477         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 478         from...
 479         (rank_one_type): ... this.
 480
 481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 482
 483         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 484         from...
 485         (rank_one_type): ... this.
 486
 487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 488
 489         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 490         from...
 491         (rank_one_type): ... this.
 492
 493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 494
 495         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 496         from...
 497         (rank_one_type): ... this.
 498
 499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 500
 501         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 502         from...
 503         (rank_one_type): ... this.
 504
 505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 506
 507         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 508         from...
 509         (rank_one_type): ... this.
 510
 511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 512
 513         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 514         from...
 515         (rank_one_type): ... this.
 516
 517 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 518
 519         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 520         from...
 521         (rank_one_type): ... this.
 522
 523 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 524
 525         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 526         from...
 527         (rank_one_type): ... this.
 528
 529 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 530
 531         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 532         from...
 533         (rank_one_type): ... this.
 534
 535 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 536
 537         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 538         inferior-events' shows the example events.
 539
 540 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 541
 542         Support styling on native MS-Windows console
 543
 544         PR/24315
 545         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 546         on MS-Windows if $TERM is not defined.
 547
 548         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 549
 550         * posix-hdep.c (gdb_console_fputs):
 551         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 552         functions.
 553         * ui-file.h (gdb_console_fputs): Add prototype.
 554
 555         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 556         back to fputs only if the former returns zero.
 557
 558 2019-03-07  Tom Tromey  <tom@tromey.com>
 559
 560         * symmisc.c (print_symbol_bcache_statistics): Update.
 561         (print_objfile_statistics): Update.
 562         * symfile.c (allocate_symtab): Update.
 563         * stabsread.c: Don't include bcache.h.
 564         * psymtab.h (struct psymbol_bcache): Don't declare.
 565         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 566         (psymbol_bcache_init, psymbol_bcache_free)
 567         (psymbol_bcache_get_bcache): Don't declare.
 568         * psymtab.c (struct psymbol_bcache): Remove.
 569         (psymtab_storage::psymtab_storage): Update.
 570         (psymtab_storage::~psymtab_storage): Update.
 571         (psymbol_bcache_init, psymbol_bcache_free)
 572         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 573         (add_psymbol_to_bcache): Update.
 574         (allocate_psymtab): Update.
 575         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 576         macro_cache>: No longer pointers.
 577         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 578         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 579         * macrotab.c (macro_bcache): Update.
 580         * macroexp.c: Don't include bcache.h.
 581         * gdbtypes.c (check_types_worklist): Update.
 582         (types_deeply_equal): Remove TRY/CATCH.  Update.
 583         * elfread.c (elf_symtab_read): Update.
 584         * dwarf2read.c: Don't include bcache.h.
 585         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 586         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 587         (print_bcache_statistics, bcache_memory_used): Don't declare.
 588         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 589         methods.  Rename all data members.
 590         * bcache.c (struct bcache): Move to bcache.h.
 591         (bcache::expand_hash_table): Rename from expand_hash_table.
 592         (bcache): Remove.
 593         (bcache::insert): Rename from bcache_full.
 594         (bcache::compare): Rename from bcache_compare.
 595         (bcache_xmalloc): Remove.
 596         (bcache::~bcache): Rename from bcache_xfree.
 597         (bcache::print_statistics): Rename from print_bcache_statistics.
 598         (bcache::memory_used): Rename from bcache_memory_used.
 599
 600 2019-03-07  Pedro Alves  <palves@redhat.com>
 601
 602         * infrun.c (normal_stop): Also check for
 603         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 604
 605 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 606
 607         * f-lang.c (value_from_host_double): Moved to...
 608         * value.c (value_from_host_double): ...here.
 609         * value.h (value_from_host_double): Declare.
 610         * guile/scm-math.c (vlscm_convert_typed_number): Use
 611         value_from_host_double.
 612         (vlscm_convert_number): Likewise.
 613         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 614         * python/py-value.c (convert_value_from_python): Likewise.
 615
 616 2019-03-06  Tom Tromey  <tom@tromey.com>
 617
 618         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 619
 620 2019-03-06  Tom Tromey  <tom@tromey.com>
 621
 622         * utils.h (free_current_contents): Don't declare.
 623         * utils.c (free_current_contents): Remove.
 624
 625 2019-03-06  Tom Tromey  <tom@tromey.com>
 626
 627         * top.c (quit_force): Update.
 628         * main.c (captured_command_loop): Update.
 629         * common/new-op.c (operator new): Update.
 630         * common/common-exceptions.c (struct catcher)
 631         <save_cleanup_chain>: Remove member.
 632         (exceptions_state_mc_init): Update.
 633         (exception_try_scope_entry): Return nullptr.
 634         (exception_try_scope_exit, exception_rethrow)
 635         (throw_exception_sjlj, throw_exception_cxx): Update.
 636         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 637         (all_cleanups, do_cleanups, discard_cleanups)
 638         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 639         (restore_cleanups, restore_final_cleanups): Don't declare.
 640         (do_final_cleanups): Remove parameter.
 641         * common/cleanups.c (cleanup_chain, make_cleanup)
 642         (make_cleanup_dtor, all_cleanups, do_cleanups)
 643         (discard_my_cleanups, discard_cleanups)
 644         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 645         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 646         (null_cleanup): Remove.
 647         (do_final_cleanups): Remove parameter.
 648
 649 2019-03-06  Tom Tromey  <tom@tromey.com>
 650
 651         * remote.c (remote_target::remote_parse_stop_reply): Use
 652         unique_xmalloc_ptr.
 653
 654 2019-03-06  Tom Tromey  <tom@tromey.com>
 655
 656         * stabsread.c (struct stabs_field_info): Rename from field_info.
 657         <list, fnlist>: Add initializers.
 658         <obstack>: New member.
 659         (read_member_functions, read_struct_fields, read_baseclasses):
 660         Allocate on obstack.  Don't use cleanups.
 661         (read_one_struct_field, read_member_functions, read_struct_fields)
 662         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 663         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 664         (read_struct_type): Update.
 665
 666 2019-03-06  Tom Tromey  <tom@tromey.com>
 667
 668         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 669         * common/filestuff.h (make_cleanup_close): Don't declare.
 670         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 671         Remove.
 672
 673 2019-03-06  Tom Tromey  <tom@tromey.com>
 674
 675         * solib-aix.c: Use make_scope_exit.
 676
 677 2019-03-06  Tom Tromey  <tom@tromey.com>
 678
 679         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 680         Use make_scope_exit.
 681
 682 2019-03-06  Tom Tromey  <tom@tromey.com>
 683
 684         * solib-svr4.c (disable_probes_interface): Remove parameter.
 685         (svr4_handle_solib_event): Use make_scope_exit.
 686
 687 2019-03-06  Tom Tromey  <tom@tromey.com>
 688
 689         * remote.c (struct stop_reply_deleter): Remove.
 690         (stop_reply_up): Update.
 691         (struct stop_reply): Derive from notif_event.  Don't typedef.
 692         <regcache>: Now a std::vector.
 693         (stop_reply_xfree): Remove.
 694         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 695         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 696         (remote_target::discard_pending_stop_replies): Use delete.
 697         (remote_target::remote_parse_stop_reply): Update.
 698         (remote_target::process_stop_reply): Update.
 699         * remote-notif.h (struct notif_event): Add virtual destructor.
 700         Remove "dtr" member.
 701         (struct notif_client) <alloc_event>: Return a unique_ptr.
 702         (notif_event_xfree): Don't declare.
 703         (notif_event_up): New typedef.
 704         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 705         (notif_event_xfree, do_notif_event_xfree): Remove.
 706         (remote_notif_state_xfree): Update.
 707
 708 2019-03-06  Tom Tromey  <tom@tromey.com>
 709
 710         * infrun.c (displaced_step_clear_cleanup): Now a
 711         forward_scope_exit type.
 712         (displaced_step_prepare_throw): Update.
 713         (displaced_step_fixup): Update.
 714
 715 2019-03-06  Tom Tromey  <tom@tromey.com>
 716
 717         * inferior.h (class inferior): Update comment.
 718         * gdbthread.h (class thread_info): Update comment.
 719
 720 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 721             Tom Tromey  <tom@tromey.com>
 722
 723         * stabsread.h (struct stab_section_list): Remove.
 724         (coffstab_build_psymtabs): Update.
 725         * dbxread.c (symbuf_sections): Now a std::vector.
 726         (sect_idx): New global.
 727         (fill_symbuf): Update.
 728         (coffstab_build_psymtabs): Change type of stabsects parameter.
 729         Update.
 730         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 731         std::vector.
 732         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 733         (coff_locate_sections): Update.
 734         (coff_symfile_read): Remove cleanups.  Update.
 735         (init_stringtab): Add storage parameter.
 736         (free_stringtab, free_stringtab_cleanup): Remove.
 737         (init_lineno): Add storage parameter.
 738         (free_linetab, free_linetab_cleanup): Remove.
 739
 740 2019-03-06  Pedro Alves  <palves@redhat.com>
 741
 742         * linux-fork.c (fork_info::clobber_regs): Delete.
 743         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 744         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 745         comment.  Adjust.
 746         (scoped_switch_fork_info::scoped_switch_fork_info)
 747         (checkpoint_command, linux_fork_context): Adjust
 748         fork_save_infrun_state calls.
 749
 750 2019-03-06  Pedro Alves  <palves@redhat.com>
 751
 752         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 753         (inf_has_multiple_threads): Return 'bool' and rewrite using
 754         inferior_info::threads().
 755
 756 2019-03-06  Pedro Alves  <palves@redhat.com>
 757
 758         * linux-fork.c: Include <list>.
 759         (fork_list): Now a std::list instance.
 760         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 761         (forks_exist_p, find_last_fork): Adjust.
 762         (new_fork): Delete.
 763         (one_fork_p): New.
 764         (add_fork): Adjust.
 765         (free_fork): Delete, folded into fork_info::~fork_info().
 766         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 767         Adjust.
 768         (init_fork_list): Delete.
 769         (linux_fork_killall, linux_fork_mourn_inferior)
 770         (linux_fork_detach, info_checkpoints_command): Adjust.
 771         (_initialize_linux_fork): No longer call init_fork_list.
 772
 773 2019-03-06  Pedro Alves  <palves@redhat.com>
 774
 775         * linux-fork.c (new_fork): New, split out of ...
 776         (add_fork): ... this.  Return void.  Move "first fork" special
 777         case from here, to ...
 778         (checkpoint_command): ... here.
 779         * linux-linux.h (add_fork): Return void.
 780
 781 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 782
 783         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 784
 785 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 786             Chris January  <chris.january@arm.com>
 787             David Lecomber  <david.lecomber@arm.com>
 788
 789         * f-exp.y: New token, UNOP_INTRINSIC.
 790         (exp): New pattern using UNOP_INTRINSIC token.
 791         (f77_keywords): Add 'abs' keyword.
 792         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 793         (value_from_host_double): New function.
 794         (evaluate_subexp_f): Support UNOP_ABS.
 795
 796 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 797
 798         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 799         types.
 800
 801 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 802
 803         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 804         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 805         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 806
 807 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 808
 809         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 810
 811 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 812             Chris January  <chris.january@arm.com>
 813
 814         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 815         * f-exp.y: Define 'KIND' token.
 816         (exp): New pattern for KIND expressions.
 817         (ptype): Handle types with a kind extension.
 818         (direct_abs_decl): Extend to spot kind extensions.
 819         (f77_keywords): Add 'kind' to the list.
 820         (push_kind_type): New function.
 821         (convert_to_kind_type): New function.
 822         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 823         * parse.c (operator_length_standard): Likewise.
 824         * parser-defs.h (enum type_pieces): Add tp_kind.
 825         * std-operator.def: Add UNOP_KIND.
 826
 827 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * f-exp.y (f_parse): Set yydebug.
 830
 831 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 832
 833         * f-lang.c (evaluate_subexp_f): New function.
 834         (exp_descriptor_f): New global.
 835         (f_language_defn): Use exp_descriptor_f instead of
 836         exp_descriptor_standard.
 837
 838 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * f-exp.y (struct token): Add comments.
 841         (dot_ops): Remove uppercase versions and the end marker.
 842         (f77_keywords): Likewise.
 843         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 844         entries in the dot_ops array are case insensitive, and use
 845         strncasecmp to compare strings.  Also some whitespace cleanup in
 846         this area.  Similar for the f77_keywords array, except entries in
 847         this list might be case sensitive.
 848
 849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 850
 851         * f-exp.y (struct f77_boolean_val): Add comments.
 852         (boolean_values): Remove uppercase versions, and end marker.
 853         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 854         and use strncasecmp to achieve case insensitivity.  Additionally,
 855         perform whitespace cleanup around this code.
 856
 857 2019-03-06  Tom Tromey  <tromey@adacore.com>
 858
 859         * remote-sim.c (gdbsim_target_open): Use result of
 860         gdb_argv::release.
 861
 862 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 863         Dirk Schubert  <dirk.schubert@arm.com>
 864         Chris January  <chris.january@arm.com>
 865
 866         * eval.c (evaluate_subexp_standard): Call Fortran argument
 867         wrapping logic.
 868         * f-lang.c (struct value): A value which can be passed into a
 869         Fortran function call.
 870         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 871         where appropriate.
 872         (struct type): Value ready for a Fortran function call.
 873         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 874         is needed.
 875         * f-lang.h (fortran_argument_convert): Declaration.
 876         (fortran_preserve_arg_pointer): Declaration.
 877         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 878
 879 2019-03-05  Tom Tromey  <tromey@adacore.com>
 880
 881         * python/py-prettyprint.c (print_string_repr): Remove #if.
 882         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 883
 884 2019-03-05  Tom Tromey  <tromey@adacore.com>
 885
 886         * target.c (the_dummy_target): Move later.  Change type to
 887         "dummy_target".
 888         (initialize_targets): Don't initialize the_dummy_target.
 889
 890 2019-03-05  Tom Tromey  <tromey@adacore.com>
 891
 892         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 893         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 894
 895 2019-03-05  Tom Tromey  <tromey@adacore.com>
 896
 897         * windows-nat.c (windows_nat_target::attach)
 898         (windows_nat_target::detach): Don't call gdb_flush.
 899         * valprint.c (generic_val_print, val_print, val_print_string):
 900         Don't call gdb_flush.
 901         * utils.c (defaulted_query): Don't call gdb_flush.
 902         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 903         * target.c (target_announce_detach): Don't call gdb_flush.
 904         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 905         * remote.c (extended_remote_target::attach): Don't call
 906         gdb_flush.
 907         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 908         * printcmd.c (do_examine): Don't call gdb_flush.
 909         (info_display_command): Don't call gdb_flush.
 910         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 911         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 912         * memattr.c (info_mem_command): Don't call gdb_flush.
 913         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 914         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 915         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 916         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 917         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 918         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 919         (gnu_nat_target::detach): Don't call gdb_flush.
 920         * f-valprint.c (f_val_print): Don't call gdb_flush.
 921         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 922         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 923         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 924         gdb_flush.
 925         * c-valprint.c (c_val_print): Don't call gdb_flush.
 926         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 927
 928 2019-03-05  Tom Tromey  <tromey@adacore.com>
 929
 930         * varobj.c (update_dynamic_varobj_children): Update.
 931         (install_default_visualizer): Use reset, not release.
 932         * value.c (set_internalvar): Update.
 933         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 934         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 935         ATTRIBUTE_UNUSED_RESULT.
 936
 937 2019-03-05  Tom Tromey  <tromey@adacore.com>
 938
 939         * remote.c (class scoped_remote_fd) <release>: Add
 940         ATTRIBUTE_UNUSED_RESULT.
 941
 942 2019-03-05  Tom Tromey  <tromey@adacore.com>
 943
 944         * macroexp.c (struct macro_buffer) <release>: Add
 945         ATTRIBUTE_UNUSED_RESULT.
 946
 947 2019-03-05  Tom Tromey  <tromey@adacore.com>
 948
 949         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 950         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 951         ATTRIBUTE_UNUSED_RESULT.
 952
 953 2019-03-05  Tom Tromey  <tromey@adacore.com>
 954
 955         * common/scoped_fd.h (class scoped_fd) <release>: Add
 956         ATTRIBUTE_UNUSED_RESULT.
 957
 958 2019-03-05  Tom Tromey  <tromey@adacore.com>
 959
 960         * parser-defs.h (struct parser_state) <release>: Add
 961         ATTRIBUTE_UNUSED_RESULT.
 962
 963 2019-03-05  Tom Tromey  <tromey@adacore.com>
 964
 965         * utils.h (class gdb_argv) <release>: Add
 966         ATTRIBUTE_UNUSED_RESULT.
 967         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 968
 969 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 970
 971         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 972         for-loop range, to avoid compiler warnings.
 973
 974         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 975         avoid compiler warnings about unused variables.
 976
 977         * NEWS: Mention end of support for native debugging on MS-Windows
 978         before XP.
 979
 980         PR gdb/24292
 981         * common/netstuff.c:
 982         * gdbserver/gdbreplay.c
 983         * gdbserver/remote-utils.c:
 984         * ser-tcp.c:
 985         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 986         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 987         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 988         'getaddrinfo' and 'freeaddrinfo' were not available before
 989         Windows XP, and mingw.org's MinGW headers by default define
 990         _WIN32_WINNT to 0x500.
 991
 992 2019-03-01  Gary Benson <gbenson@redhat.com>
 993
 994         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 995
 996 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 997             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 998
 999         PR gdb/8527
1000         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1001         set_sigint_trap, clear_sigint_trap.
1002
1003 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1004
1005         * target.c (target_detach): Clear the regcache and the
1006         frame cache.
1007
1008 2019-02-27  Pedro Alves  <palves@redhat.com>
1009
1010         * utils.c (set_screen_size): When we cap the height/width sizes,
1011         tweak the corresponding command variable to show "unlimited":
1012
1013 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1014             Pedro Alves  <palves@redhat.com>
1015
1016         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1017         before calling rl_set_screen_size.
1018
1019 2019-02-27  Tom Tromey  <tromey@adacore.com>
1020
1021         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1022         define.
1023         * python/py-value.c: Remove Python 2.4 workaround.
1024         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1025         workaround.
1026         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1027         Python 2.4 workaround.
1028         * python/python-internal.h: Remove Python 2.4 comment.
1029         (Py_ssize_t): Don't define.
1030         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1031         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1032         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1033         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1034         * python/python.c (do_start_initialization): Remove Python 2.4
1035         workaround.
1036         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1037         (print_children): Remove Python 2.4 workaround.
1038         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1039         workaround.
1040         (CHARBUFFERPROC_NAME): Remove.
1041         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1042         Python 2.4 workaround.
1043
1044 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1045
1046         * NEWS: Note minimum Python version.
1047
1048 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1049
1050         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1051         code from these functions.  Remove corresponding ifdefs.  Use
1052         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1053         Remove gotos and target of gotos.
1054         (infpy_search_memory): Likewise.
1055
1056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1059         (hppa_gdbarch_init): Don't register deleted functions with
1060         gdbarch.
1061
1062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1063
1064         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1065         (h8300_unwind_sp): Delete.
1066         (h8300_dummy_id): Delete.
1067         (h8300_gdbarch_init): Don't register deleted functions with
1068         gdbarch.
1069
1070 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1073         (ft32_unwind_pc): Delete.
1074         (ft32_unwind_sp): Delete.
1075         (ft32_gdbarch_init): Don't register deleted functions with
1076         gdbarch.
1077
1078 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1081         (frv_unwind_pc): Delete.
1082         (frv_unwind_sp): Delete.
1083         (frv_gdbarch_init): Don't register deleted functions with
1084         gdbarch.
1085
1086 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1089         (riscv_unwind_pc): Delete.
1090         (riscv_unwind_sp): Delete.
1091         (riscv_gdbarch_init): Don't register deleted functions with
1092         gdbarch.
1093
1094 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1097         (csky_unwind_pc): Delete.
1098         (csky_unwind_sp): Delete.
1099         (csky_gdbarch_init): Don't register deleted functions with
1100         gdbarch.
1101
1102 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1103
1104         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1105         (cris_unwind_pc): Delete.
1106         (cris_unwind_sp): Delete.
1107         (cris_gdbarch_init): Don't register deleted functions with
1108         gdbarch.
1109
1110 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1113         (bfin_unwind_pc): Delete.
1114         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1115
1116 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1119         (arm_unwind_pc): Delete.
1120         (arm_unwind_sp): Delete.
1121         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1122
1123 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1124
1125         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1126         (arc_unwind_pc): Delete.
1127         (arc_unwind_sp): Delete.
1128         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1129
1130 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1131
1132         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1133         (alpha_unwind_pc): Delete.
1134         (alpha_gdbarch_init): Don't register deleted functions with
1135         gdbarch.
1136
1137 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1138
1139         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1140         (aarch64_unwind_pc): Delete.
1141         (aarch64_unwind_sp): Delete.
1142         (aarch64_gdbarch_init): Don't register deleted functions with
1143         gdbarch.
1144
1145 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1146
1147         * gdbtypes.c (type_align): Don't consider static members when
1148         computing structure alignment.
1149
1150 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1151
1152         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1153         return 0 for other types.
1154         * arch-utils.c (default_type_align): Always return 0.
1155         * gdbarch.h: Regenerate.
1156         * gdbarch.sh (type_align): Extend comment.
1157         * gdbtypes.c (type_align): Add additional comments, always call
1158         gdbarch_type_align before applying the default rules.
1159         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1160         generic code will then apply a suitable default.
1161         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1162         types, return 0 for other types.
1163
1164 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1165
1166         * NEWS: Create a new section for the next release branch.
1167         Rename the section of the current branch, now that it has
1168         been cut.
1169
1170 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1171
1172         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1173         * version.in: Bump version to 8.3.50.DATE-git.
1174
1175 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1176
1177         * aix-thread.c (ptid_cmp): Remove unused variable.
1178         (get_signaled_thread): Likewise.
1179         (store_regs_user_thread): Likewise.
1180         (store_regs_kernel_thread): Likewise.
1181         (fetch_regs_kernel_thread): Remove shadowed variable.
1182
1183 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1184
1185         * features/riscv/32bit-cpu.xml: Add register numbers.
1186         * features/riscv/32bit-fpu.c: Regenerate.
1187         * features/riscv/32bit-fpu.xml: Add register numbers.
1188         * features/riscv/64bit-cpu.xml: Add register numbers.
1189         * features/riscv/64bit-fpu.c: Regenerate.
1190         * features/riscv/64bit-fpu.xml: Add register numbers.
1191
1192 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1193
1194         * NEWS: Mention two argument form of gdb.Value constructor.
1195         * python/py-value.c (convert_buffer_and_type_to_value): New
1196         function.
1197         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1198         Add support for handling an optional second argument.  Call
1199         convert_buffer_and_type_to_value as appropriate.
1200         * python/python-internal.h (Py_buffer_deleter): New struct.
1201         (Py_buffer_up): New typedef.
1202
1203 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1204
1205         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1206         instead of releasing ownership.
1207
1208 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1209
1210         * dwarf2read.c (open_and_init_dwp_file): Call
1211         elf_numsections instead of bfd_count_sections to initialize
1212         dwp_file->num_sections.
1213
1214 2019-02-25  Tom Tromey  <tromey@adacore.com>
1215
1216         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1217
1218 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1219
1220         * gcore.in: Add '--readnever' option when invoking GDB.
1221
1222 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1223
1224         * MAINTAINERS: Update my email address.
1225
1226 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1227
1228         * build-id.c (build_id_to_debug_bfd_1): New function.
1229         (build_id_to_debug_bfd): Look for separate debug file in
1230         sysroot.
1231
1232 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1233
1234         * gdbarch.sh: Update the copyright year range that is placed into
1235         generated files.
1236
1237 2019-02-22  Keith Seitz  <keiths@redhat.com>
1238
1239         PR symtab/23853
1240         * linespec.c (create_sals_line_offset): Search for the default
1241         symtab's filename instead of its fullname.
1242
1243 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1244
1245         * NEWS: Update style defaults.
1246
1247 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1248
1249         * main.c (captured_main_1): Disable styling in batch mode.
1250
1251 2019-02-20  Tom Tromey  <tom@tromey.com>
1252
1253         * symtab.c (symtab_symbol_info): Fix typos.
1254
1255 2019-02-20  Tom Tromey  <tromey@adacore.com>
1256
1257         * findcmd.c (_initialize_mem_search): Use upper case for
1258         metasyntactic variables.
1259
1260 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1261
1262         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1263         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1264
1265 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1266
1267         * top.h (source_file_name): Change to std::string.
1268         * top.c (source_file_name): Likewise.
1269         (command_line_input): Adjust.
1270         * cli/cli-script.c (script_from_file): Adjust.
1271
1272 2019-02-19  Tom Tromey  <tromey@adacore.com>
1273
1274         * ravenscar-thread.c
1275         (ravenscar_thread_target::update_thread_list): Don't call
1276         ada_build_task_list.
1277         * ada-lang.h (ada_build_task_list): Don't declare.
1278         * ada-tasks.c (struct ada_tasks_inferior_data)
1279         <task_list_valid_p>: Now bool.
1280         (read_known_tasks, ada_task_list_changed)
1281         (ada_tasks_invalidate_inferior_data): Update.
1282         (read_known_tasks_array): Return bool.
1283         (read_known_tasks_list): Likewise.
1284         (read_known_tasks): Return void.
1285         (ada_build_task_list): Now static.
1286
1287 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1290         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1291
1292 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1293
1294         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1295         variant for ada_tasks_pspace_data_handle and
1296         ada_tasks_inferior_data_handle.
1297         (ada_tasks_pspace_data_cleanup): New function.
1298         (ada_tasks_inferior_data_cleanup): New function.
1299
1300 2019-02-17  Tom Tromey  <tom@tromey.com>
1301
1302         * macrotab.h (macro_source_fullname): Return a std::string.
1303         * macrotab.c (macro_include, check_for_redefinition)
1304         (macro_undef, macro_lookup_definition, foreach_macro)
1305         (foreach_macro_in_scope): Update.
1306         (macro_source_fullname): Return a std::string.
1307         * macrocmd.c (show_pp_source_pos): Update.
1308
1309 2019-02-17  Tom Tromey  <tom@tromey.com>
1310
1311         * macrocmd.c (show_pp_source_pos): Style the file names.
1312
1313 2019-02-17  Tom Tromey  <tom@tromey.com>
1314
1315         PR tui/24197:
1316         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1317
1318 2019-02-17  Tom Tromey  <tom@tromey.com>
1319
1320         * ada-lang.c (user_select_syms): Use filtered printing.
1321         * utils.c (wrap_style): New global.
1322         (desired_style): Remove.
1323         (emit_style_escape): Add stream parameter.
1324         (set_output_style, reset_terminal_style, prompt_for_continue):
1325         Update.
1326         (flush_wrap_buffer): Only flush gdb_stdout.
1327         (wrap_here): Set wrap_style.
1328         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1329         treat escape sequences as a character.  Change when wrap buffer is
1330         flushed.
1331         (fputs_styled): Do not set the output style when the default is
1332         requested.
1333         * ui-style.h (struct ui_file_style) <is_default>: New method.
1334         * source.c (print_source_lines_base): Emit escape sequences in one
1335         piece.
1336
1337 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1338
1339         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1340         integers and enumeration types.
1341
1342 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1343
1344         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1345         instead of lookup_symbol_in_language
1346         (do_exact_match): New function.
1347         (ada_get_symbol_name_matcher): Return do_exact_match when
1348         doing a verbatim match.
1349
1350 2019-02-15  Tom Tromey  <tromey@adacore.com>
1351
1352         * ravenscar-thread.c (ravenscar_thread_target::resume)
1353         (ravenscar_thread_target::wait): Special case wildcard requests.
1354
1355 2019-02-15  Tom Tromey  <tromey@adacore.com>
1356
1357         * ravenscar-thread.c (base_ptid): Remove.
1358         (struct ravenscar_thread_target) <close>: New method.
1359         <m_base_ptid>: New member.
1360         <update_inferior_ptid, active_task, task_is_currently_active,
1361         runtime_initialized>: Declare methods.
1362         <ravenscar_thread_target>: Add constructor.
1363         (ravenscar_thread_target::task_is_currently_active)
1364         (ravenscar_thread_target::update_inferior_ptid)
1365         (ravenscar_runtime_initialized): Rename.  Now methods.
1366         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1367         (ravenscar_thread_target::update_thread_list): Update.
1368         (ravenscar_thread_target::active_task): Now method.
1369         (ravenscar_thread_target::store_registers)
1370         (ravenscar_thread_target::prepare_to_store)
1371         (ravenscar_thread_target::prepare_to_store)
1372         (ravenscar_thread_target::mourn_inferior): Update.
1373         (ravenscar_inferior_created): Use "new" to create target.
1374         (ravenscar_thread_target::get_ada_task_ptid): Update.
1375         (_initialize_ravenscar): Don't initialize base_ptid.
1376         (ravenscar_ops): Remove global.
1377
1378 2019-02-15  Tom Tromey  <tromey@adacore.com>
1379
1380         * target.h (push_target): Declare new overload.
1381         * target.c (push_target): New overload, taking an rvalue reference.
1382         * remote.c (remote_target::open_1): Use push_target overload.
1383         * corelow.c (core_target_open): Use push_target overload.
1384
1385 2019-02-15  Tom Tromey  <tromey@adacore.com>
1386
1387         * ravenscar-thread.c (is_ravenscar_task)
1388         (ravenscar_task_is_currently_active): Return bool.
1389         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1390         (_initialize_ravenscar): Remove "(void)".
1391         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1392         Return bool.
1393
1394 2019-02-15  Tom Tromey  <tromey@adacore.com>
1395
1396         * ravenscar-thread.c (ravenscar_runtime_initializer)
1397         (has_ravenscar_runtime, get_running_thread_id)
1398         (ravenscar_thread_target::resume): Fix indentation.
1399
1400 2019-02-15  Tom Tromey  <tromey@adacore.com>
1401
1402         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1403         from ravenscar_arch_ops.
1404         (sparc_ravenscar_ops::fetch_registers)
1405         (sparc_ravenscar_ops::store_registers): Now methods.
1406         (sparc_ravenscar_prepare_to_store): Remove.
1407         (sparc_ravenscar_ops): Redefine.
1408         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1409         methods and destructor.  Remove members.
1410         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1411         (ravenscar_thread_target::store_registers)
1412         (ravenscar_thread_target::prepare_to_store): Update.
1413         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1414         Remove.
1415         (struct ppc_ravenscar_powerpc_ops): Derive from
1416         ravenscar_arch_ops.
1417         (ppc_ravenscar_powerpc_ops::fetch_registers)
1418         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1419         (ppc_ravenscar_powerpc_ops): Redefine.
1420         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1421         (ppc_ravenscar_e500_ops::fetch_registers)
1422         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1423         (ppc_ravenscar_e500_ops): Redefine.
1424         * aarch64-ravenscar-thread.c
1425         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1426         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1427         (aarch64_ravenscar_fetch_registers)
1428         (aarch64_ravenscar_store_registers): Now methods.
1429         (aarch64_ravenscar_ops): Redefine.
1430
1431 2019-02-15  Tom Tromey  <tromey@adacore.com>
1432
1433         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1434         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1435         (ravenscar_thread_target::stopped_by_watchpoint)
1436         (ravenscar_thread_target::stopped_data_address)
1437         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1438
1439 2019-02-15  Tom Tromey  <tromey@adacore.com>
1440
1441         * ravenscar-thread.c: Fix some typos.
1442
1443 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1444             Tom Tromey  <tromey@adacore.com>
1445
1446         * ada-lang.c (ada_exception_sal): Change addr_string to a
1447         std::string.
1448         (create_ada_exception_catchpoint): Update.
1449
1450 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1451             Tom Tromey  <tromey@adacore.com>
1452
1453         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1454         (bp_location_ops): Remove.
1455         (base_breakpoint_allocate_location): Update.
1456         (free_bp_location): Update.
1457         * ada-lang.c (class ada_catchpoint_location)
1458         <ada_catchpoint_location>: Remove ops parameter.
1459         (ada_catchpoint_location_dtor): Remove.
1460         (ada_catchpoint_location_ops): Remove.
1461         (allocate_location_exception): Update.
1462         * breakpoint.h (struct bp_location_ops): Remove.
1463         (class bp_location) <bp_location>: Remove bp_location_ops
1464         parameter.
1465         <~bp_location>: Add destructor.
1466         <ops>: Remove.
1467
1468 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1469             Pedro Alves  <palves@redhat.com>
1470
1471         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1472         'PATH_MAX'.
1473
1474 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1475             Samuel Thibault  <samuel.thibault@gnu.org>
1476             Thomas Schwinge  <thomas@codesourcery.com>
1477
1478         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1479         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1480
1481 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1482
1483         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1484         (check_empty): Use "const char *".
1485
1486         * gnu-nat.c (gnu_nat_target::detach): Instead of
1487         'detach_inferior (pid)' call
1488         'detach_inferior (find_inferior_pid (pid))'.
1489
1490         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1491         'nat/fork-inferior.o'.
1492         * gnu-nat.c: #include "nat/fork-inferior.h".
1493
1494         * gnu-nat.c (gnu_nat_target::detach): Instead of
1495         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1496         * gnu-nat.h: #include "inf-child.h".
1497         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1498         'i386_gnu_nat_target::fetch_registers'.
1499         (gnu_store_registers): Rename/move to
1500         'i386_gnu_nat_target::store_registers'.
1501
1502         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1503         * gnu-nat.h (mach_thread_info): New function.
1504         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1505
1506         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1507
1508 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1509
1510         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1511
1512 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1513
1514         * windows-nat.c (windows_add_thread): Add new parameter
1515         "main_thread_p" with default value set to false.  Update
1516         function documentation as well as all callers.
1517         (windows_delete_thread): Likewise.
1518         (fake_create_process): Update call to windows_add_thread.
1519         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1520         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1521         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1522         call to windows_delete_thread.
1523
1524 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1525
1526         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1527
1528 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1529
1530         * symfile.c (find_separate_debug_file): Use canonical path of
1531         sysroot with child_path instead of gdb_sysroot if it is valid.
1532
1533 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1534
1535         * symfile.c (find_separate_debug_file): Use child_path to
1536         determine if an object file is under a sysroot.
1537
1538 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1539
1540         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1541         unittests/child-path-selftests.c.
1542         * common/pathstuff.c (child_path): New function.
1543         * common/pathstuff.h (child_path): New prototype.
1544         * unittests/child-path-selftests.c: New file.
1545
1546 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1547
1548         * symfile.c (find_separate_debug_file): Look for separate debug
1549         files in debug directories under the sysroot.
1550
1551 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1552
1553         * symtab.h (struct minimal_symbol data_p): New const method.
1554         (struct minimal_symbol text_p): Likewise.
1555         * symtab.c (output_source_filename): Use file name style
1556         to print file name.
1557         (print_symbol_info): Likewise.
1558         (print_msymbol_info): Use address style to print addresses.
1559         Use function name style to print executable text symbols.
1560         (expand_symtab_containing_pc): Use data_p.
1561         (find_pc_sect_compunit_symtab): Likewise.
1562
1563 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1564
1565         * breakpoint.c (describe_other_breakpoints): Use address style
1566         to print addresses.
1567         (say_where): Likewise.
1568
1569 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1570
1571         * ada-typeprint.c (print_func_type): Print function name
1572         style to print function name.
1573         * c-typeprint.c (c_print_type_1): Likewise.
1574
1575 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1576
1577         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1578         for execve.
1579
1580 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1581
1582         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1583         type_stack.
1584
1585 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1586
1587         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1588         TYPE_CODE_REF types.
1589
1590 2019-02-08  Jim Wilson  <jimw@sifive.com>
1591
1592         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1593         (riscv_linux_fregset): New.
1594         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1595
1596 2019-02-07  Tom Tromey  <tom@tromey.com>
1597
1598         * thread.c (thread_cancel_execution_command): Update.
1599         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1600         methods.
1601         (struct thread_fsm_ops): Remove.
1602         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1603         (thread_fsm_should_stop, thread_fsm_return_value)
1604         (thread_fsm_set_finished, thread_fsm_finished_p)
1605         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1606         Don't declare.
1607         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1608         * infrun.c (clear_proceed_status_thread)
1609         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1610         (print_stop_event): Update.
1611         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1612         Add constructor.
1613         (step_command_fsm_ops): Remove.
1614         (new_step_command_fsm): Remove.
1615         (step_1): Update.
1616         (step_command_fsm::should_stop): Rename from
1617         step_command_fsm_should_stop.
1618         (step_command_fsm::clean_up): Rename from
1619         step_command_fsm_clean_up.
1620         (step_command_fsm::do_async_reply_reason): Rename from
1621         step_command_fsm_async_reply_reason.
1622         (struct until_next_fsm): Inherit from thread_fsm.  Add
1623         constructor.
1624         (until_next_fsm_ops): Remove.
1625         (new_until_next_fsm): Remove.
1626         (until_next_fsm::should_stop): Rename from
1627         until_next_fsm_should_stop.
1628         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1629         (until_next_fsm::do_async_reply_reason): Rename from
1630         until_next_fsm_async_reply_reason.
1631         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1632         constructor.  Change type of breakpoint.
1633         (finish_command_fsm_ops): Remove.
1634         (new_finish_command_fsm): Remove.
1635         (finish_command_fsm::should_stop): Rename from
1636         finish_command_fsm_should_stop.
1637         (finish_command_fsm::clean_up): Rename from
1638         finish_command_fsm_clean_up.
1639         (finish_command_fsm::return_value): Rename from
1640         finish_command_fsm_return_value.
1641         (finish_command_fsm::do_async_reply_reason): Rename from
1642         finish_command_fsm_async_reply_reason.
1643         (finish_command): Update.
1644         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1645         Add constructor.
1646         (call_thread_fsm_ops): Remove.
1647         (call_thread_fsm::call_thread_fsm): Rename from
1648         new_call_thread_fsm.
1649         (call_thread_fsm::should_stop): Rename from
1650         call_thread_fsm_should_stop.
1651         (call_thread_fsm::should_notify_stop): Rename from
1652         call_thread_fsm_should_notify_stop.
1653         (run_inferior_call, call_function_by_hand_dummy): Update.
1654         * cli/cli-interp.c (should_print_stop_to_console): Update.
1655         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1656         Add constructor.  Change type of location_breakpoint,
1657         caller_breakpoint.
1658         (until_break_fsm_ops): Remove.
1659         (new_until_break_fsm): Remove.
1660         (until_break_fsm::should_stop): Rename from
1661         until_break_fsm_should_stop.
1662         (until_break_fsm::clean_up): Rename from
1663         until_break_fsm_clean_up.
1664         (until_break_fsm::do_async_reply_reason): Rename from
1665         until_break_fsm_async_reply_reason.
1666         (until_break_command): Update.
1667         * thread-fsm.c: Remove.
1668         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1669
1670 2019-02-07  Tom Tromey  <tom@tromey.com>
1671
1672         * yy-remap.h: Add include guard.
1673         * xtensa-tdep.h: Add include guard.
1674         * xcoffread.h: Rename include guard.
1675         * varobj-iter.h: Add include guard.
1676         * tui/tui.h: Rename include guard.
1677         * tui/tui-winsource.h: Rename include guard.
1678         * tui/tui-wingeneral.h: Rename include guard.
1679         * tui/tui-windata.h: Rename include guard.
1680         * tui/tui-win.h: Rename include guard.
1681         * tui/tui-stack.h: Rename include guard.
1682         * tui/tui-source.h: Rename include guard.
1683         * tui/tui-regs.h: Rename include guard.
1684         * tui/tui-out.h: Rename include guard.
1685         * tui/tui-layout.h: Rename include guard.
1686         * tui/tui-io.h: Rename include guard.
1687         * tui/tui-hooks.h: Rename include guard.
1688         * tui/tui-file.h: Rename include guard.
1689         * tui/tui-disasm.h: Rename include guard.
1690         * tui/tui-data.h: Rename include guard.
1691         * tui/tui-command.h: Rename include guard.
1692         * tic6x-tdep.h: Add include guard.
1693         * target/waitstatus.h: Rename include guard.
1694         * target/wait.h: Rename include guard.
1695         * target/target.h: Rename include guard.
1696         * target/resume.h: Rename include guard.
1697         * target-float.h: Rename include guard.
1698         * stabsread.h: Add include guard.
1699         * rs6000-tdep.h: Add include guard.
1700         * riscv-fbsd-tdep.h: Add include guard.
1701         * regformats/regdef.h: Rename include guard.
1702         * record.h: Rename include guard.
1703         * python/python.h: Rename include guard.
1704         * python/python-internal.h: Rename include guard.
1705         * python/py-stopevent.h: Rename include guard.
1706         * python/py-ref.h: Rename include guard.
1707         * python/py-record.h: Rename include guard.
1708         * python/py-record-full.h: Rename include guard.
1709         * python/py-record-btrace.h: Rename include guard.
1710         * python/py-instruction.h: Rename include guard.
1711         * python/py-events.h: Rename include guard.
1712         * python/py-event.h: Rename include guard.
1713         * procfs.h: Add include guard.
1714         * proc-utils.h: Add include guard.
1715         * p-lang.h: Add include guard.
1716         * or1k-tdep.h: Rename include guard.
1717         * observable.h: Rename include guard.
1718         * nto-tdep.h: Rename include guard.
1719         * nat/x86-linux.h: Rename include guard.
1720         * nat/x86-linux-dregs.h: Rename include guard.
1721         * nat/x86-gcc-cpuid.h: Add include guard.
1722         * nat/x86-dregs.h: Rename include guard.
1723         * nat/x86-cpuid.h: Rename include guard.
1724         * nat/ppc-linux.h: Rename include guard.
1725         * nat/mips-linux-watch.h: Rename include guard.
1726         * nat/linux-waitpid.h: Rename include guard.
1727         * nat/linux-ptrace.h: Rename include guard.
1728         * nat/linux-procfs.h: Rename include guard.
1729         * nat/linux-osdata.h: Rename include guard.
1730         * nat/linux-nat.h: Rename include guard.
1731         * nat/linux-namespaces.h: Rename include guard.
1732         * nat/linux-btrace.h: Rename include guard.
1733         * nat/glibc_thread_db.h: Rename include guard.
1734         * nat/gdb_thread_db.h: Rename include guard.
1735         * nat/gdb_ptrace.h: Rename include guard.
1736         * nat/fork-inferior.h: Rename include guard.
1737         * nat/amd64-linux-siginfo.h: Rename include guard.
1738         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1739         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1740         * nat/aarch64-linux.h: Rename include guard.
1741         * nat/aarch64-linux-hw-point.h: Rename include guard.
1742         * mn10300-tdep.h: Add include guard.
1743         * mips-linux-tdep.h: Add include guard.
1744         * mi/mi-parse.h: Rename include guard.
1745         * mi/mi-out.h: Rename include guard.
1746         * mi/mi-main.h: Rename include guard.
1747         * mi/mi-interp.h: Rename include guard.
1748         * mi/mi-getopt.h: Rename include guard.
1749         * mi/mi-console.h: Rename include guard.
1750         * mi/mi-common.h: Rename include guard.
1751         * mi/mi-cmds.h: Rename include guard.
1752         * mi/mi-cmd-break.h: Rename include guard.
1753         * m2-lang.h: Add include guard.
1754         * location.h: Rename include guard.
1755         * linux-record.h: Rename include guard.
1756         * linux-nat.h: Add include guard.
1757         * linux-fork.h: Add include guard.
1758         * i386-darwin-tdep.h: Rename include guard.
1759         * hppa-linux-offsets.h: Add include guard.
1760         * guile/guile.h: Rename include guard.
1761         * guile/guile-internal.h: Rename include guard.
1762         * gnu-nat.h: Rename include guard.
1763         * gdb-stabs.h: Rename include guard.
1764         * frv-tdep.h: Add include guard.
1765         * f-lang.h: Add include guard.
1766         * event-loop.h: Add include guard.
1767         * darwin-nat.h: Rename include guard.
1768         * cp-abi.h: Rename include guard.
1769         * config/sparc/nm-sol2.h: Rename include guard.
1770         * config/nm-nto.h: Rename include guard.
1771         * config/nm-linux.h: Add include guard.
1772         * config/i386/nm-i386gnu.h: Rename include guard.
1773         * config/djgpp/nl_types.h: Rename include guard.
1774         * config/djgpp/langinfo.h: Rename include guard.
1775         * compile/gcc-cp-plugin.h: Add include guard.
1776         * compile/gcc-c-plugin.h: Add include guard.
1777         * compile/compile.h: Rename include guard.
1778         * compile/compile-object-run.h: Rename include guard.
1779         * compile/compile-object-load.h: Rename include guard.
1780         * compile/compile-internal.h: Rename include guard.
1781         * compile/compile-cplus.h: Rename include guard.
1782         * compile/compile-c.h: Rename include guard.
1783         * common/xml-utils.h: Rename include guard.
1784         * common/x86-xstate.h: Rename include guard.
1785         * common/version.h: Rename include guard.
1786         * common/vec.h: Rename include guard.
1787         * common/tdesc.h: Rename include guard.
1788         * common/selftest.h: Rename include guard.
1789         * common/scoped_restore.h: Rename include guard.
1790         * common/scoped_mmap.h: Rename include guard.
1791         * common/scoped_fd.h: Rename include guard.
1792         * common/safe-iterator.h: Rename include guard.
1793         * common/run-time-clock.h: Rename include guard.
1794         * common/refcounted-object.h: Rename include guard.
1795         * common/queue.h: Rename include guard.
1796         * common/ptid.h: Rename include guard.
1797         * common/print-utils.h: Rename include guard.
1798         * common/preprocessor.h: Rename include guard.
1799         * common/pathstuff.h: Rename include guard.
1800         * common/observable.h: Rename include guard.
1801         * common/netstuff.h: Rename include guard.
1802         * common/job-control.h: Rename include guard.
1803         * common/host-defs.h: Rename include guard.
1804         * common/gdb_wait.h: Rename include guard.
1805         * common/gdb_vecs.h: Rename include guard.
1806         * common/gdb_unlinker.h: Rename include guard.
1807         * common/gdb_unique_ptr.h: Rename include guard.
1808         * common/gdb_tilde_expand.h: Rename include guard.
1809         * common/gdb_sys_time.h: Rename include guard.
1810         * common/gdb_string_view.h: Rename include guard.
1811         * common/gdb_splay_tree.h: Rename include guard.
1812         * common/gdb_setjmp.h: Rename include guard.
1813         * common/gdb_ref_ptr.h: Rename include guard.
1814         * common/gdb_optional.h: Rename include guard.
1815         * common/gdb_locale.h: Rename include guard.
1816         * common/gdb_assert.h: Rename include guard.
1817         * common/filtered-iterator.h: Rename include guard.
1818         * common/filestuff.h: Rename include guard.
1819         * common/fileio.h: Rename include guard.
1820         * common/environ.h: Rename include guard.
1821         * common/common-utils.h: Rename include guard.
1822         * common/common-types.h: Rename include guard.
1823         * common/common-regcache.h: Rename include guard.
1824         * common/common-inferior.h: Rename include guard.
1825         * common/common-gdbthread.h: Rename include guard.
1826         * common/common-exceptions.h: Rename include guard.
1827         * common/common-defs.h: Rename include guard.
1828         * common/common-debug.h: Rename include guard.
1829         * common/cleanups.h: Rename include guard.
1830         * common/buffer.h: Rename include guard.
1831         * common/btrace-common.h: Rename include guard.
1832         * common/break-common.h: Rename include guard.
1833         * cli/cli-utils.h: Rename include guard.
1834         * cli/cli-style.h: Rename include guard.
1835         * cli/cli-setshow.h: Rename include guard.
1836         * cli/cli-script.h: Rename include guard.
1837         * cli/cli-interp.h: Rename include guard.
1838         * cli/cli-decode.h: Rename include guard.
1839         * cli/cli-cmds.h: Rename include guard.
1840         * charset-list.h: Add include guard.
1841         * buildsym-legacy.h: Rename include guard.
1842         * bfin-tdep.h: Add include guard.
1843         * ax.h: Rename include guard.
1844         * arm-linux-tdep.h: Add include guard.
1845         * arm-fbsd-tdep.h: Add include guard.
1846         * arch/xtensa.h: Rename include guard.
1847         * arch/tic6x.h: Add include guard.
1848         * arch/i386.h: Add include guard.
1849         * arch/arm.h: Rename include guard.
1850         * arch/arm-linux.h: Rename include guard.
1851         * arch/arm-get-next-pcs.h: Rename include guard.
1852         * arch/amd64.h: Add include guard.
1853         * arch/aarch64-insn.h: Rename include guard.
1854         * arch-utils.h: Rename include guard.
1855         * annotate.h: Add include guard.
1856         * amd64-darwin-tdep.h: Rename include guard.
1857         * aarch64-linux-tdep.h: Add include guard.
1858         * aarch64-fbsd-tdep.h: Add include guard.
1859         * aarch32-linux-nat.h: Add include guard.
1860
1861 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1862
1863         * macrotab.c (macro_define_internal): New function that
1864         factorizes macro_define_object_internal and macro_define_function
1865         code.
1866         (macro_define_object_internal): Use macro_define_internal.
1867         (macro_define_function): Likewise.
1868
1869 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1870
1871         * macrocmd.c (extract_identifier): Return
1872         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1873         callers.
1874
1875 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1876
1877         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1878
1879 2019-02-05  Tom Tromey  <tom@tromey.com>
1880
1881         * target.c (target_stack::unpush): Move assertion earlier.
1882
1883 2019-01-30  Tom Tromey  <tom@tromey.com>
1884
1885         PR python/23615:
1886         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1887         (gdbpy_parse_and_eval): Likewise.
1888         * python/python-internal.h (gdbpy_allow_threads): New class.
1889
1890 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1891
1892         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1893         (aarch64_fbsd_fpregmap): Move earlier.
1894         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1895         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1896         instead of individual calls to trad_frame_set_reg_addr.
1897         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1898         earlier.
1899         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1900         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1901         instead of individual calls to trad_frame_set_reg_addr.
1902
1903 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1904
1905         * CONTRIBUTE: Replace contribution list with wiki link.
1906
1907 2019-01-25  Tom Tromey  <tom@tromey.com>
1908
1909         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1910
1911 2019-01-25  Tom Tromey  <tom@tromey.com>
1912
1913         * xtensa-linux-nat.c: Fix common/ includes.
1914         * xml-support.h: Fix common/ includes.
1915         * xml-support.c: Fix common/ includes.
1916         * x86-linux-nat.c: Fix common/ includes.
1917         * windows-nat.c: Fix common/ includes.
1918         * varobj.h: Fix common/ includes.
1919         * varobj.c: Fix common/ includes.
1920         * value.c: Fix common/ includes.
1921         * valops.c: Fix common/ includes.
1922         * utils.c: Fix common/ includes.
1923         * unittests/xml-utils-selftests.c: Fix common/ includes.
1924         * unittests/utils-selftests.c: Fix common/ includes.
1925         * unittests/unpack-selftests.c: Fix common/ includes.
1926         * unittests/tracepoint-selftests.c: Fix common/ includes.
1927         * unittests/style-selftests.c: Fix common/ includes.
1928         * unittests/string_view-selftests.c: Fix common/ includes.
1929         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1930         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1931         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1932         * unittests/rsp-low-selftests.c: Fix common/ includes.
1933         * unittests/parse-connection-spec-selftests.c: Fix common/
1934         includes.
1935         * unittests/optional-selftests.c: Fix common/ includes.
1936         * unittests/offset-type-selftests.c: Fix common/ includes.
1937         * unittests/observable-selftests.c: Fix common/ includes.
1938         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1939         * unittests/memrange-selftests.c: Fix common/ includes.
1940         * unittests/memory-map-selftests.c: Fix common/ includes.
1941         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1942         * unittests/function-view-selftests.c: Fix common/ includes.
1943         * unittests/environ-selftests.c: Fix common/ includes.
1944         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1945         * unittests/common-utils-selftests.c: Fix common/ includes.
1946         * unittests/cli-utils-selftests.c: Fix common/ includes.
1947         * unittests/array-view-selftests.c: Fix common/ includes.
1948         * ui-file.c: Fix common/ includes.
1949         * tui/tui-io.c: Fix common/ includes.
1950         * tracepoint.h: Fix common/ includes.
1951         * tracepoint.c: Fix common/ includes.
1952         * tracefile-tfile.c: Fix common/ includes.
1953         * top.h: Fix common/ includes.
1954         * top.c: Fix common/ includes.
1955         * thread.c: Fix common/ includes.
1956         * target/waitstatus.h: Fix common/ includes.
1957         * target/waitstatus.c: Fix common/ includes.
1958         * target.h: Fix common/ includes.
1959         * target.c: Fix common/ includes.
1960         * target-memory.c: Fix common/ includes.
1961         * target-descriptions.c: Fix common/ includes.
1962         * symtab.h: Fix common/ includes.
1963         * symfile.c: Fix common/ includes.
1964         * stap-probe.c: Fix common/ includes.
1965         * spu-linux-nat.c: Fix common/ includes.
1966         * sparc-nat.c: Fix common/ includes.
1967         * source.c: Fix common/ includes.
1968         * solib.c: Fix common/ includes.
1969         * solib-target.c: Fix common/ includes.
1970         * ser-unix.c: Fix common/ includes.
1971         * ser-tcp.c: Fix common/ includes.
1972         * ser-pipe.c: Fix common/ includes.
1973         * ser-base.c: Fix common/ includes.
1974         * selftest-arch.c: Fix common/ includes.
1975         * s12z-tdep.c: Fix common/ includes.
1976         * rust-exp.y: Fix common/ includes.
1977         * rs6000-aix-tdep.c: Fix common/ includes.
1978         * riscv-tdep.c: Fix common/ includes.
1979         * remote.c: Fix common/ includes.
1980         * remote-notif.h: Fix common/ includes.
1981         * remote-fileio.h: Fix common/ includes.
1982         * remote-fileio.c: Fix common/ includes.
1983         * regcache.h: Fix common/ includes.
1984         * regcache.c: Fix common/ includes.
1985         * record-btrace.c: Fix common/ includes.
1986         * python/python.c: Fix common/ includes.
1987         * python/py-type.c: Fix common/ includes.
1988         * python/py-inferior.c: Fix common/ includes.
1989         * progspace.h: Fix common/ includes.
1990         * producer.c: Fix common/ includes.
1991         * procfs.c: Fix common/ includes.
1992         * proc-api.c: Fix common/ includes.
1993         * printcmd.c: Fix common/ includes.
1994         * ppc-linux-nat.c: Fix common/ includes.
1995         * parser-defs.h: Fix common/ includes.
1996         * osdata.c: Fix common/ includes.
1997         * obsd-nat.c: Fix common/ includes.
1998         * nat/x86-linux.c: Fix common/ includes.
1999         * nat/x86-linux-dregs.c: Fix common/ includes.
2000         * nat/x86-dregs.h: Fix common/ includes.
2001         * nat/x86-dregs.c: Fix common/ includes.
2002         * nat/ppc-linux.c: Fix common/ includes.
2003         * nat/mips-linux-watch.h: Fix common/ includes.
2004         * nat/mips-linux-watch.c: Fix common/ includes.
2005         * nat/linux-waitpid.c: Fix common/ includes.
2006         * nat/linux-ptrace.h: Fix common/ includes.
2007         * nat/linux-ptrace.c: Fix common/ includes.
2008         * nat/linux-procfs.c: Fix common/ includes.
2009         * nat/linux-personality.c: Fix common/ includes.
2010         * nat/linux-osdata.c: Fix common/ includes.
2011         * nat/linux-namespaces.c: Fix common/ includes.
2012         * nat/linux-btrace.h: Fix common/ includes.
2013         * nat/linux-btrace.c: Fix common/ includes.
2014         * nat/fork-inferior.c: Fix common/ includes.
2015         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2016         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2017         * nat/aarch64-linux.c: Fix common/ includes.
2018         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2019         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2020         * namespace.h: Fix common/ includes.
2021         * mips-linux-tdep.c: Fix common/ includes.
2022         * minsyms.c: Fix common/ includes.
2023         * mi/mi-parse.h: Fix common/ includes.
2024         * mi/mi-main.c: Fix common/ includes.
2025         * mi/mi-cmd-env.c: Fix common/ includes.
2026         * memrange.h: Fix common/ includes.
2027         * memattr.c: Fix common/ includes.
2028         * maint.h: Fix common/ includes.
2029         * maint.c: Fix common/ includes.
2030         * main.c: Fix common/ includes.
2031         * machoread.c: Fix common/ includes.
2032         * location.c: Fix common/ includes.
2033         * linux-thread-db.c: Fix common/ includes.
2034         * linux-nat.c: Fix common/ includes.
2035         * linux-fork.c: Fix common/ includes.
2036         * inline-frame.c: Fix common/ includes.
2037         * infrun.c: Fix common/ includes.
2038         * inflow.c: Fix common/ includes.
2039         * inferior.h: Fix common/ includes.
2040         * inferior.c: Fix common/ includes.
2041         * infcmd.c: Fix common/ includes.
2042         * inf-ptrace.c: Fix common/ includes.
2043         * inf-child.c: Fix common/ includes.
2044         * ia64-linux-nat.c: Fix common/ includes.
2045         * i387-tdep.c: Fix common/ includes.
2046         * i386-tdep.c: Fix common/ includes.
2047         * i386-linux-tdep.c: Fix common/ includes.
2048         * i386-linux-nat.c: Fix common/ includes.
2049         * i386-go32-tdep.c: Fix common/ includes.
2050         * i386-fbsd-tdep.c: Fix common/ includes.
2051         * i386-fbsd-nat.c: Fix common/ includes.
2052         * guile/scm-type.c: Fix common/ includes.
2053         * guile/guile.c: Fix common/ includes.
2054         * go32-nat.c: Fix common/ includes.
2055         * gnu-nat.c: Fix common/ includes.
2056         * gdbthread.h: Fix common/ includes.
2057         * gdbarch-selftests.c: Fix common/ includes.
2058         * gdb_usleep.c: Fix common/ includes.
2059         * gdb_select.h: Fix common/ includes.
2060         * gdb_bfd.c: Fix common/ includes.
2061         * gcore.c: Fix common/ includes.
2062         * fork-child.c: Fix common/ includes.
2063         * findvar.c: Fix common/ includes.
2064         * fbsd-nat.c: Fix common/ includes.
2065         * event-top.c: Fix common/ includes.
2066         * event-loop.c: Fix common/ includes.
2067         * dwarf2read.c: Fix common/ includes.
2068         * dwarf2loc.c: Fix common/ includes.
2069         * dwarf2-frame.c: Fix common/ includes.
2070         * dwarf-index-cache.c: Fix common/ includes.
2071         * dtrace-probe.c: Fix common/ includes.
2072         * disasm-selftests.c: Fix common/ includes.
2073         * defs.h: Fix common/ includes.
2074         * csky-tdep.c: Fix common/ includes.
2075         * cp-valprint.c: Fix common/ includes.
2076         * cp-support.h: Fix common/ includes.
2077         * cp-support.c: Fix common/ includes.
2078         * corelow.c: Fix common/ includes.
2079         * completer.h: Fix common/ includes.
2080         * completer.c: Fix common/ includes.
2081         * compile/compile.c: Fix common/ includes.
2082         * compile/compile-loc2c.c: Fix common/ includes.
2083         * compile/compile-cplus-types.c: Fix common/ includes.
2084         * compile/compile-cplus-symbols.c: Fix common/ includes.
2085         * command.h: Fix common/ includes.
2086         * cli/cli-dump.c: Fix common/ includes.
2087         * cli/cli-cmds.c: Fix common/ includes.
2088         * charset.c: Fix common/ includes.
2089         * build-id.c: Fix common/ includes.
2090         * btrace.h: Fix common/ includes.
2091         * btrace.c: Fix common/ includes.
2092         * breakpoint.h: Fix common/ includes.
2093         * breakpoint.c: Fix common/ includes.
2094         * ax.h:
2095         (enum agent_op): Fix common/ includes.
2096         * ax-general.c (struct aop_map): Fix common/ includes.
2097         * ax-gdb.c: Fix common/ includes.
2098         * auxv.c: Fix common/ includes.
2099         * auto-load.c: Fix common/ includes.
2100         * arm-tdep.c: Fix common/ includes.
2101         * arch/riscv.c: Fix common/ includes.
2102         * arch/ppc-linux-common.c: Fix common/ includes.
2103         * arch/i386.c: Fix common/ includes.
2104         * arch/arm.c: Fix common/ includes.
2105         * arch/arm-linux.c: Fix common/ includes.
2106         * arch/arm-get-next-pcs.c: Fix common/ includes.
2107         * arch/amd64.c: Fix common/ includes.
2108         * arch/aarch64.c: Fix common/ includes.
2109         * arch/aarch64-insn.c: Fix common/ includes.
2110         * arch-utils.c: Fix common/ includes.
2111         * amd64-windows-tdep.c: Fix common/ includes.
2112         * amd64-tdep.c: Fix common/ includes.
2113         * amd64-sol2-tdep.c: Fix common/ includes.
2114         * amd64-obsd-tdep.c: Fix common/ includes.
2115         * amd64-nbsd-tdep.c: Fix common/ includes.
2116         * amd64-linux-tdep.c: Fix common/ includes.
2117         * amd64-linux-nat.c: Fix common/ includes.
2118         * amd64-fbsd-tdep.c: Fix common/ includes.
2119         * amd64-fbsd-nat.c: Fix common/ includes.
2120         * amd64-dicos-tdep.c: Fix common/ includes.
2121         * amd64-darwin-tdep.c: Fix common/ includes.
2122         * agent.c: Fix common/ includes.
2123         * ada-lang.h: Fix common/ includes.
2124         * ada-lang.c: Fix common/ includes.
2125         * aarch64-tdep.c: Fix common/ includes.
2126
2127 2019-01-25  Tom Tromey  <tom@tromey.com>
2128
2129         * common/create-version.sh: Use common/version.h.
2130
2131 2019-01-24  Pedro Alves  <palves@redhat.com>
2132
2133         * infrun.c (signal_stop, signal_print, signal_program)
2134         (signal_catch, signal_pass): Now arrays instead of pointers.
2135         (update_signals_program_target, do_target_resume)
2136         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2137         * linux-nat.c (linux_nat_target::pass_signals)
2138         (linux_nat_target::create_inferior, linux_nat_target::attach):
2139         Adjust.
2140         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2141         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2142         * procfs.c (procfs_target::pass_signals): Adjust.
2143         * record-full.c (record_full_target::resume): Adjust.
2144         * remote.c (remote_target::pass_signals)
2145         (remote_target::program_signals): Adjust.
2146         * target-debug.h (target_debug_print_signals): Now takes a
2147         gdb::array_view as parameter.  Adjust.
2148         * target.h (target_ops) <pass_signals, program_signals>: Replace
2149         pointer and length parameters with gdb::array_view.
2150         (target_pass_signals, target_program_signals): Likewise.
2151         * target-delegates.c: Regenerate.
2152
2153 2019-01-24  Pedro Alves  <palves@redhat.com>
2154
2155         * common/forward-scope-exit.h
2156         (forward_scope_exit::forward_scope_exit): Pass arguments to
2157         m_bind_function directly, instead of creating a std::bind and
2158         copying that.
2159
2160 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2161
2162         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2163         for static members.
2164         (pass_in_v_vfp_candidate): Likewise.
2165
2166 2019-01-23  Tom Tromey  <tom@tromey.com>
2167             Pedro Alves  <palves@redhat.com>
2168
2169         * regcache.c (class regcache_invalidator): Remove.
2170         (regcache::raw_write): Use make_scope_exit.
2171
2172 2019-01-23  Tom Tromey  <tom@tromey.com>
2173
2174         * ui-out.h (class ui_out_emit_type): Update comment.
2175
2176 2019-01-23  Tom Tromey  <tom@tromey.com>
2177
2178         * infrun.c (fetch_inferior_event): Update comment.
2179
2180 2019-01-23  Tom Tromey  <tom@tromey.com>
2181             Pedro Alves  <palves@redhat.com>
2182
2183         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2184         parameter.
2185         (fetch_inferior_event): Use SCOPE_EXIT.
2186
2187
2188 2019-01-23  Tom Tromey  <tom@tromey.com>
2189             Pedro Alves  <palves@redhat.com>
2190
2191         * infrun.c (disable_thread_events): Delete.
2192         (stop_all_threads): Use SCOPE_EXIT.
2193
2194 2019-01-23  Tom Tromey  <tom@tromey.com>
2195             Pedro Alves  <palves@redhat.com>
2196
2197         * symfile.c: Include forward-scope-exit.h.
2198         (clear_symtab_users_cleanup): Replace forward declaration with
2199         a FORWARD_SCOPE_EXIT.
2200         (syms_from_objfile_1): Use the forward_scope_exit and
2201         gdb::optional instead of cleanup_function.
2202         (reread_symbols): Use the forward_scope_exit instead of
2203         cleanup_function.
2204         (clear_symtab_users_cleanup): Remove function.
2205
2206 2019-01-23  Tom Tromey  <tom@tromey.com>
2207             Pedro Alves  <palves@redhat.com>
2208
2209         * linux-nat.c: Include scope-exit.h.
2210         (cleanup_target_stop): Remove.
2211         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2212         SCOPE_EXIT.
2213
2214 2019-01-23  Tom Tromey  <tom@tromey.com>
2215             Pedro Alves  <palves@redhat.com>
2216
2217         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2218         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2219
2220 2019-01-23  Tom Tromey  <tom@tromey.com>
2221             Andrew Burgess  <andrew.burgess@embecosm.com>
2222             Pedro Alves  <palves@redhat.com>
2223
2224         * infrun.c (fetch_inferior_event): Use scope_exit.
2225         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2226         * top.c (execute_command): Use scope_exit.
2227         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2228         * utils.c (do_bpstat_clear_actions_cleanup)
2229         (make_bpstat_clear_actions_cleanup): Remove.
2230
2231 2019-01-23  Tom Tromey  <tom@tromey.com>
2232             Pedro Alves  <palves@redhat.com>
2233
2234         * infrun.c: Include "common/scope-exit.h"
2235         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2236         (wait_for_inferior): Use SCOPE_EXIT.
2237         (fetch_inferior_event): Use scope_exit.
2238
2239 2019-01-23  Tom Tromey  <tom@tromey.com>
2240             Pedro Alves  <palves@redhat.com>
2241
2242         * breakpoint.c (create_breakpoint): Remove cleanup.
2243
2244 2019-01-23  Tom Tromey  <tom@tromey.com>
2245             Andrew Burgess  <andrew.burgess@embecosm.com>
2246             Pedro Alves  <palves@redhat.com>
2247
2248 2019-01-23  Pedro Alves  <palves@redhat.com>
2249
2250         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2251
2252 2019-01-23  Pedro Alves  <palves@redhat.com>
2253             Andrew Burgess  <andrew.burgess@embecosm.com>
2254
2255         * gdbthread.h: Include "common/forward-scope-exit.h".
2256         (scoped_finish_thread_state): Redefine custom class in terms of
2257         forward_scope_exit.
2258
2259 2019-01-23  Pedro Alves  <palves@redhat.com>
2260             Andrew Burgess  <andrew.burgess@embecosm.com>
2261
2262         * common/forward-scope-exit.h: New file.
2263
2264 2019-01-23  Pedro Alves  <palves@redhat.com>
2265             Andrew Burgess  <andrew.burgess@embecosm.com>
2266             Tom Tromey  <tom@tromey.com>
2267
2268         * common/scope-exit.h: New file.
2269
2270 2019-01-23  Pedro Alves  <palves@redhat.com>
2271
2272         * common/preprocessor.h (ESC): Rename to ...
2273         (ESC_PARENS): ... this.
2274         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2275         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2276
2277 2019-01-23  Tom Tromey  <tom@tromey.com>
2278
2279         * language.h (class scoped_switch_to_sym_language_if_auto):
2280         Initialize m_lang in both cases.
2281
2282 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2283
2284         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2285         with XCNEW.
2286
2287 2019-01-22  Tom Tromey  <tom@tromey.com>
2288
2289         * corelow.c: Do not include sys/file.h.
2290
2291 2019-01-22  Tom Tromey  <tom@tromey.com>
2292
2293         * tui/tui-wingeneral.h: Include gdb_curses.h.
2294
2295 2019-01-22  Tom Tromey  <tom@tromey.com>
2296
2297         * source-cache.h (class source_cache) <get_source_lines,
2298         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2299
2300 2019-01-22  Tom Tromey  <tom@tromey.com>
2301
2302         * remote-fileio.h (struct remote_target): Declare.
2303
2304 2019-01-22  Tom Tromey  <tom@tromey.com>
2305
2306         * python/py-arch.c: Do not include py-ref.h.
2307         * python/py-bpevent.c: Do not include py-ref.h.
2308         * python/py-cmd.c: Do not include py-ref.h.
2309         * python/py-continueevent.c: Do not include py-ref.h.
2310         * python/py-event.h: Do not include py-ref.h.
2311         * python/py-evtregistry.c: Do not include py-ref.h.
2312         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2313         * python/py-frame.c: Do not include py-ref.h.
2314         * python/py-framefilter.c: Do not include py-ref.h.
2315         * python/py-function.c: Do not include py-ref.h.
2316         * python/py-infevents.c: Do not include py-ref.h.
2317         * python/py-linetable.c: Do not include py-ref.h.
2318         * python/py-objfile.c: Do not include py-ref.h.
2319         * python/py-param.c: Do not include py-ref.h.
2320         * python/py-prettyprint.c: Do not include py-ref.h.
2321         * python/py-progspace.c: Do not include py-ref.h.
2322         * python/py-symbol.c: Do not include py-ref.h.
2323         * python/py-symtab.c: Do not include py-ref.h.
2324         * python/py-type.c: Do not include py-ref.h.
2325         * python/py-unwind.c: Do not include py-ref.h.
2326         * python/py-utils.c: Do not include py-ref.h.
2327         * python/py-value.c: Do not include py-ref.h.
2328         * python/py-varobj.c: Do not include py-ref.h.
2329         * python/py-xmethods.c: Do not include py-ref.h.
2330         * python/python.c: Do not include py-ref.h.
2331         * varobj.c: Do not include py-ref.h.
2332
2333 2019-01-22  Tom Tromey  <tom@tromey.com>
2334
2335         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2336         keyword for bcache.
2337
2338 2019-01-22  Tom Tromey  <tom@tromey.com>
2339
2340         * compile/compile-cplus-types.c: Remove a comment by #include.
2341
2342 2019-01-22  Tom Tromey  <tom@tromey.com>
2343
2344         * compile/gcc-c-plugin.h: Include compile-internal.h.
2345
2346 2019-01-22  Tom Tromey  <tom@tromey.com>
2347
2348         * stabsread.c (EXTERN): Do not define.
2349         (symnum, next_symbol_text_func, processing_gcc_compilation)
2350         (within_function, global_sym_chain, global_stabs)
2351         (previous_stab_code, this_object_header_files)
2352         (n_this_object_header_files)
2353         (n_allocated_this_object_header_files): Define.
2354         * stabsread.h (EXTERN): Never define.  Use "extern".
2355
2356 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2357
2358         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2359         history_value.
2360
2361 2019-01-21  Tom Tromey  <tom@tromey.com>
2362
2363         * ui-out.c: Fix includes.
2364         * tui/tui-source.c: Fix includes.
2365         * target.c: Fix includes.
2366         * remote.c: Fix includes.
2367         * regcache.c: Fix includes.
2368         * python/py-block.c: Fix includes.
2369         * printcmd.c: Fix includes.
2370         * or1k-tdep.c: Fix includes.
2371         * mi/mi-main.c: Fix includes.
2372         * m32r-tdep.c: Fix includes.
2373         * csky-tdep.c: Fix includes.
2374         * compile/compile-cplus-types.c: Fix includes.
2375         * cli/cli-interp.c: Fix includes.
2376
2377 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2378
2379         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2380         for padding.
2381
2382 2019-01-16  Tom Tromey  <tom@tromey.com>
2383
2384         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2385         earlier.
2386         (struct objfile) <msymbols_range>: Move from top level.
2387         <msymbols>: New method.
2388         (class objfile_msymbols): Remove.
2389         * symtab.c (default_collect_symbol_completion_matches_break_on):
2390         Update.
2391         * symmisc.c (dump_msymbols): Update.
2392         * stabsread.c (scan_file_globals): Update.
2393         * objc-lang.c (info_selectors_command, info_classes_command)
2394         (find_methods): Update.
2395         * minsyms.c (find_solib_trampoline_target): Update.
2396         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2397         * coffread.c (coff_symfile_read): Update.
2398         * ada-lang.c (ada_lookup_simple_minsym)
2399         (ada_collect_symbol_completion_matches): Update.
2400
2401 2019-01-16  Tom Tromey  <tom@tromey.com>
2402
2403         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2404         type.  Remove no-argument constructor.
2405         <iterator::operator++>: Simplify.
2406         <begin>: Update.
2407         <end>: Use minimal_symbol_count.
2408
2409 2019-01-16  Tom Tromey  <tom@tromey.com>
2410
2411         * objfiles.h (struct objfile) <psymtabs>: New method.
2412         (class objfile_psymtabs): Remove.
2413         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2414         typedef.
2415         <range>: New method.
2416         (require_partial_symbols): Change return type.
2417         * psymtab.c (require_partial_symbols)
2418         (psym_expand_symtabs_matching): Update.
2419         * mdebugread.c (parse_partial_symbols): Update.
2420         * dbxread.c (dbx_end_psymtab): Update.
2421
2422 2019-01-15  Tom Tromey  <tom@tromey.com>
2423
2424         * symtab.c (lookup_objfile_from_block)
2425         (lookup_symbol_in_objfile_symtabs)
2426         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2427         (find_line_symtab, info_sources_command)
2428         (default_collect_symbol_completion_matches_break_on)
2429         (make_source_files_completion_list): Update.
2430         * symmisc.c (print_objfile_statistics, dump_objfile)
2431         (maintenance_print_symbols, maintenance_info_symtabs)
2432         (maintenance_check_symtabs, maintenance_info_line_tables):
2433         Update.
2434         * source.c (select_source_symtab)
2435         (forget_cached_source_info_for_objfile): Update.
2436         * objfiles.h (class objfile_compunits): Remove.
2437         (struct objfile) <compunits_range>: New typedef.
2438         (compunits): New method.
2439         * objfiles.c (objfile_relocate1): Update.
2440         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2441         * maint.c (count_symtabs_and_blocks): Update.
2442         * linespec.c (iterate_over_all_matching_symtabs): Update.
2443         * cp-support.c (add_symbol_overload_list_qualified): Update.
2444         * coffread.c (coff_symtab_read): Update.
2445         * ada-lang.c (add_nonlocal_symbols)
2446         (ada_collect_symbol_completion_matches)
2447         (ada_add_global_exceptions): Update.
2448
2449 2019-01-15  Tom Tromey  <tom@tromey.com>
2450
2451         * progspace.h (program_space) <objfiles_safe_range>: New
2452         typedef.
2453         <objfiles_safe>: New method.
2454         * objfiles.h (class all_objfiles_safe): Remove.
2455         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2456         * jit.c (jit_inferior_exit_hook): Update.
2457
2458 2019-01-17  Tom Tromey  <tom@tromey.com>
2459
2460         * progspace.h (program_space) <objfiles_range>: New typedef.
2461         <objfiles>: New method.
2462         <objfiles_head>: Rename from objfiles.
2463         (object_files): Update.
2464         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2465         * guile/scm-pretty-print.c
2466         (ppscm_find_pretty_printer_from_objfiles): Update.
2467         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2468         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2469         Update.
2470         * python/py-progspace.c (pspy_get_objfiles): Update.
2471         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2472         Update.
2473         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2474         (objfpy_lookup_objfile_by_build_id): Update.
2475         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2476         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2477         Update.
2478         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2479         (expand_symtab_containing_pc, lookup_objfile_from_block)
2480         (lookup_static_symbol, basic_lookup_transparent_type)
2481         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2482         (find_line_symtab, info_sources_command)
2483         (default_collect_symbol_completion_matches_break_on)
2484         (make_source_files_completion_list, find_main_name): Update.
2485         * symmisc.c (print_symbol_bcache_statistics)
2486         (print_objfile_statistics, maintenance_print_symbols)
2487         (maintenance_print_msymbols, maintenance_print_objfiles)
2488         (maintenance_info_symtabs, maintenance_check_symtabs)
2489         (maintenance_expand_symtabs, maintenance_info_line_tables):
2490         Update.
2491         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2492         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2493         (map_overlay_command, unmap_overlay_command)
2494         (simple_overlay_update, expand_symtabs_matching)
2495         (map_symbol_filenames): Update.
2496         * symfile-debug.c (set_debug_symfile): Update.
2497         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2498         Update.
2499         * source.c (select_source_symtab, forget_cached_source_info):
2500         Update.
2501         * solib.c (solib_read_symbols): Update.
2502         * solib-spu.c (append_ocl_sos): Update.
2503         * psymtab.c (maintenance_print_psymbols)
2504         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2505         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2506         * printcmd.c (info_symbol_command): Update.
2507         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2508         Update.
2509         * objfiles.h (class all_objfiles): Remove.
2510         * objfiles.c (have_partial_symbols, have_full_symbols)
2511         (have_minimal_symbols, qsort_cmp, update_section_map)
2512         (shared_objfile_contains_address_p)
2513         (default_iterate_over_objfiles_in_search_order): Update.
2514         * objc-lang.c (info_selectors_command, info_classes_command)
2515         (find_methods): Update.
2516         * minsyms.c (find_solib_trampoline_target): Update.
2517         * maint.c (maintenance_info_sections)
2518         (maintenance_translate_address, count_symtabs_and_blocks):
2519         Update.
2520         * main.c (captured_main_1): Update.
2521         * linux-thread-db.c (try_thread_db_load_from_pdir)
2522         (has_libpthread): Update.
2523         * linespec.c (iterate_over_all_matching_symtabs)
2524         (search_minsyms_for_name): Update.
2525         * jit.c (jit_find_objf_with_entry_addr): Update.
2526         * hppa-tdep.c (find_unwind_entry)
2527         (hppa_lookup_stub_minimal_symbol): Update.
2528         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2529         Update.
2530         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2531         (elf_gnu_ifunc_resolve_by_got): Update.
2532         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2533         * dwarf-index-write.c (save_gdb_index_command): Update.
2534         * cp-support.c (add_symbol_overload_list_qualified): Update.
2535         * breakpoint.c (create_overlay_event_breakpoint)
2536         (create_longjmp_master_breakpoint)
2537         (create_std_terminate_master_breakpoint)
2538         (create_exception_master_breakpoint): Update.
2539         * blockframe.c (find_pc_partial_function): Update.
2540         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2541         (ada_collect_symbol_completion_matches)
2542         (ada_add_global_exceptions): Update.
2543
2544 2019-01-17  Tom Tromey  <tom@tromey.com>
2545
2546         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2547         declare VEC.
2548         (solib_target_parse_libraries): Change return type.
2549         (library_list_start_segment, library_list_start_section)
2550         (library_list_end_library, library_list_start_library); Update.
2551         (solib_target_free_library_list): Remove.
2552         (solib_target_parse_libraries): Remove cleanup.  Change return
2553         type.
2554         (solib_target_current_sos): Update.
2555
2556 2019-01-17  Tom Tromey  <tromey@bapiya>
2557
2558         * valprint.c: Replace "the the" with "the".
2559         * symtab.c: Replace "the the" with "the".
2560         * solib.c: Replace "the the" with "the".
2561         * solib-dsbt.c: Replace "the the" with "the".
2562         * linespec.c: Replace "the the" with "the".
2563         * dwarf2loc.h: Replace "the the" with "the".
2564         * amd64-windows-tdep.c: Replace "the the" with "the".
2565         * aarch64-tdep.c: Replace "the the" with "the".
2566
2567 2019-01-16  Keith Seitz  <keiths@redhat.com>
2568
2569         PR gdb/23773
2570         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2571         <builder>: Rename to ..
2572         <m_builder>: ... this and make private.
2573         (dwarf2_cu::get_builder): New method.  Change all users of
2574         `builder' to use this method.
2575         (dwarf2_start_symtab): Move to ...
2576         (dwarf2_cu::start_symtab): ... here.  Update all callers
2577         (setup_type_unit_groups): Move to ...
2578         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2579         callers.
2580         (dwarf2_cu::reset_builder): New method.
2581         (process_full_compunit, process_full_type_unit): Use
2582         dwarf2_cu::reset_builder.
2583         (follow_die_offset): Record the ancestor CU if it is different
2584         from the followed DIE's CU.
2585         (follow_die_sig_1): Likewise.
2586
2587 2019-01-15  Tom Tromey  <tom@tromey.com>
2588
2589         * remote.c (class remote_state) <buf>: Now a char_vector.
2590         <buf_size>: Remove.
2591         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2592         parameter.
2593         (remote_target::getpkt_or_notif_sane_1)
2594         (remote_target::getpkt_sane)
2595         (remote_target::getpkt_or_notif_sane): Likewise.
2596         (class remote_target) <putpkt>: New overload.
2597         (remote_target::read_frame): Change type of "buf_p".  Remove
2598         sizeof_p parameter.
2599         (packet_ok): New overload.
2600         (packet_check_result): New overload.
2601         Update all uses.
2602
2603 2019-01-14  Tom Tromey  <tom@tromey.com>
2604
2605         * remote-notif.c (handle_notification, remote_notif_ack)
2606         (remote_notif_parse): Make "buf" const.
2607         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2608         const.
2609         (remote_notif_parse, remote_notif_ack, handle_notification):
2610         Likewise.
2611         * remote.c (remote_notif_stop_parse): Make "buf" const.
2612         (remote_target::remote_parse_stop_reply): Make "buf" const.
2613         (remote_notif_stop_ack): Make "buf" const.
2614
2615 2019-01-14  Tom Tromey  <tom@tromey.com>
2616
2617         * remote.c (remote_console_output): Make parameter const.
2618
2619 2019-01-14  Tom Tromey  <tom@tromey.com>
2620
2621         * target-debug.h (target_debug_print_signals): Constify.
2622         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2623         * procfs.c (procfs_target::pass_signals): Update.
2624         * linux-nat.c (linux_nat_target::pass_signals): Update.
2625         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2626         * target-delegates.c: Rebuild.
2627         * remote.c (remote_target::program_signals): Update.
2628         (remote_target::pass_signals): Update.
2629         * target.c (target_pass_signals): Constify argument.
2630         (target_program_signals): Likewise.
2631         * target.h (struct target_ops) <pass_signals, program_signals>:
2632         Constify argument.
2633         (target_pass_signals, target_program_signals): Constify argument.
2634
2635 2019-01-14  Tom Tromey  <tom@tromey.com>
2636
2637         PR tui/28819:
2638         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2639
2640 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2641
2642         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2643         field.
2644         * rs6000-tdep.c: Include reggroups.h.
2645         (IS_V_ALIAS_PSEUDOREG): Define.
2646         (rs6000_register_name): Return names for the "vX" aliases.
2647         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2648         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2649         aliases.  Call default_register_reggroup_p for all other
2650         pseudo-registers.
2651         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2652         New functions.
2653         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2654         Handle "vX" aliases.
2655         (v_alias_pseudo_register_collect): New function.
2656         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2657         (rs6000_gdbarch_init): Initialize "vX" aliases as
2658         pseudo-registers.  Restore registration of
2659         rs6000_pseudo_register_reggroup_p with
2660         set_tdesc_pseudo_register_reggroup_p.
2661
2662 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2663
2664         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2665         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2666         set_gdbarch_num_pseudo_regs.
2667
2668 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2669
2670         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2671         Remove arg prefixname, add do_set and do_show.
2672         Add member functions set_list and show_list.
2673         * cli/cli-style.c (class cli_style_option): Update accordingly.
2674         (style_set_list): Move to file scope.
2675         (style_show_list): Likewise.
2676         (set_style): Call help_list.
2677         (show_style): Call cmd_show_list.
2678         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2679         Update to use the new macro.
2680
2681 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2682
2683         * ada-lang.c (_initialize_ada_language): Expand the help text
2684         for the "catch exception" command.
2685
2686 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2687
2688         * symtab.c (matching_obj_sections): Initialize obj,
2689         declare it closer to its usage.
2690
2691 2019-01-10  Tom Tromey  <tom@tromey.com>
2692
2693         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2694         (basic_inf_threads_range): Remove.
2695         (inf_threads_range, inf_non_exited_threads_range)
2696         (safe_inf_threads_range): Use next_adapter.
2697
2698 2019-01-10  Keith Seitz  <keiths@redhat.com>
2699
2700         PR gdb/23712
2701         PR symtab/23010
2702         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2703         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2704
2705 2019-01-10  Keith Seitz  <keiths@redhat.com>
2706
2707         PR gdb/23712
2708         PR symtab/23010
2709         * dictionary.c (pending_to_vector): Remove.
2710         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2711         Remove _1 suffix, replacing functions of the same name.  Update
2712         all callers.
2713         (dict_create_hashed, dict_create_hashed_expandable)
2714         (dict_create_linear, dict_create_linear_expandable, dict_free)
2715         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2716         Make functions static.
2717
2718 2019-01-10  Keith Seitz  <keiths@redhat.com>
2719
2720         PR gdb/23712
2721         PR symtab/23010
2722         * dictionary.h (struct dictionary): Replace declaration with
2723         multidictionary.
2724         (dict_create_hashed, dict_create_hashed_expandable)
2725         (dict_create_linear, dict_create_linear_expandable)
2726         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2727         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2728         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2729         taking multidictionary argument.
2730         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2731         * block.h (struct block) <dict>: Change to multidictionary
2732         and rename `multidict'.
2733         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2734         symmisc.c: Update all dictionary references to multidictionary.
2735
2736 2019-01-10  Keith Seitz  <keiths@redhat.com>
2737
2738         PR gdb/23712
2739         PR symtab/23010
2740         * dictionary.c: Include unordered_map.
2741         (pending_to_vector): New function.
2742         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2743         Rewrite the non-"_1" functions to take vector instead
2744         of linked list.
2745         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2746         "new" _1 versions of the same name.
2747         (multidictionary): Define.
2748         (std::hash<enum language): New definition.
2749         (collate_pending_symbols_by_language, mdict_create_hashed)
2750         (mdict_create_hashed_expandable, mdict_create_linear)
2751         (mdict_create_linear_expandable, mdict_free)
2752         (find_language_dictionary, create_new_language_dictionary)
2753         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2754         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2755         (mdict_size, mdict_empty): New functions.
2756         * dictionary.h (mdict_iterator): Define.
2757
2758 2019-01-10  Pedro Alves  <palves@redhat.com>
2759
2760         * breakpoint.c (read_uploaded_action)
2761         (create_tracepoint_from_upload): Adjust to use
2762         gdb::unique_xmalloc_ptr.
2763         * ctf.c (ctf_write_uploaded_tp):
2764         (SET_ARRAY_FIELD): Use emplace_back.
2765         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2766         * tracefile-tfile.c (tfile_write_uploaded_tp):
2767         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2768         gdb::unique_xmalloc_ptr.
2769         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2770         at_string, cond_string, cmd_strings>: Replace char pointers
2771         with gdb::unique_xmalloc_ptr.
2772
2773 2019-01-10  Pedro Alves  <palves@redhat.com>
2774
2775         * solib-target.c (library_list_start_library): Don't xstrdup name.
2776
2777 2019-01-10  Pedro Alves  <palves@redhat.com>
2778
2779         * mdebugread.c (parse_partial_symbols): Use
2780         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2781
2782 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2783
2784         * linux-fork.c (scoped_switch_fork_info)
2785         <~scoped_switch_fork_info>: Fix incorrect variable name.
2786
2787 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2788
2789         * linux-fork.c (scoped_switch_fork_info)
2790         <scoped_switch_fork_info>: Make explicit.
2791         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2792
2793 2019-01-10  Tom Tromey  <tom@tromey.com>
2794
2795         * objfiles.h (objfile::reset_psymtabs): Update.
2796         * objfiles.c (objfile::objfile): Update.
2797         * psymtab.h (psymtab_storage::obstack): Update.
2798         (psymtab_storage::m_obstack): Use gdb::optional.
2799         (class psymtab_storage): Update comment.  Remove objfile
2800         parameter.
2801         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2802
2803 2019-01-10  Tom Tromey  <tom@tromey.com>
2804
2805         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2806         <free_psymtabs>: Now private.
2807         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2808         (allocate_psymtab): Use new method.
2809
2810 2019-01-10  Tom Tromey  <tom@tromey.com>
2811
2812         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2813         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2814         * mdebugread.c (parse_partial_symbols): Use
2815         allocate_dependencies.
2816         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2817         allocate_dependencies.
2818         (process_psymtab_comp_unit_reader)
2819         (build_type_psymtab_dependencies): Likewise.
2820         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2821
2822 2019-01-10  Tom Tromey  <tom@tromey.com>
2823
2824         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2825         PSYMBOL_SET_LANGUAGE.
2826         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2827
2828 2019-01-10  Tom Tromey  <tom@tromey.com>
2829
2830         * psymtab.h (psymtab_storage::obstack): New method.
2831         <m_obstack>: Rename from obstack; now private.
2832         * psymtab.c (psymtab_storage): Update.
2833         * dwarf2read.c (create_addrmap_from_index)
2834         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2835         Update.
2836
2837 2019-01-10  Tom Tromey  <tom@tromey.com>
2838
2839         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2840         * objfiles.h (objfile::reset_psymtabs): New method.
2841
2842 2019-01-10  Tom Tromey  <tom@tromey.com>
2843
2844         * symmisc.c (print_symbol_bcache_statistics): Update.
2845         (print_objfile_statistics): Update.
2846         * symfile.c (reread_symbols): Update.
2847         * psymtab.h (class psymtab_storage): New.
2848         * psymtab.c (psymtab_storage): New constructor.
2849         (~psymtab_storage): New destructor.
2850         (require_partial_symbols): Update.
2851         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2852         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2853         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2854         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2855         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2856         (start_psymtab_common, end_psymtab_common)
2857         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2858         (allocate_psymtab): Update.
2859         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2860         Update.
2861         (dump_psymtab_addrmap, maintenance_print_psymbols)
2862         (maintenance_check_psymtabs): Update.
2863         (class objfile_psymtabs): Move to objfiles.h.
2864         * psympriv.h (discard_psymtab): Now inline.
2865         (psymtab_discarder::psymtab_discarder): Update.
2866         (psymtab_discarder::~psymtab_discarder): Update.
2867         (ALL_OBJFILE_PSYMTABS): Rewrite.
2868         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2869         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2870         Remove fields.
2871         <partial_symtabs>: New field.
2872         (class objfile_psymtabs): Move from psymtab.h.  Update.
2873         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2874         psymbol_cache.
2875         (objfile::~objfile): Don't destroy psymbol_cache.
2876         * mdebugread.c (parse_partial_symbols): Update.
2877         * dwarf2read.c (create_addrmap_from_index)
2878         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2879         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2880         (add_partial_subprogram, dwarf2_ranges_read): Update.
2881         * dwarf-index-write.c (write_address_map)
2882         (write_one_signatured_type, recursively_write_psymbols)
2883         (class debug_names, class debug_names, write_psymtabs_to_index):
2884         Update.
2885
2886 2019-01-10  Tom Tromey  <tom@tromey.com>
2887
2888         * symtab.h (SYMBOL_SET_NAMES): Update.
2889         (symbol_set_names): Update.
2890         (MSYMBOL_SET_NAMES): Update.
2891         * symtab.c (symbol_set_names): Change argument to be an
2892         objfile_per_bfd_storage.
2893         * psymtab.c (add_psymbol_to_bcache): Update.
2894         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2895
2896 2019-01-10  Tom Tromey  <tom@tromey.com>
2897
2898         * symtab.c (create_demangled_names_hash): Change argument to be an
2899         objfile_per_bfd_storage.
2900         (symbol_set_names): Update.
2901
2902 2019-01-10  Tom Tromey  <tom@tromey.com>
2903
2904         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2905         init_psymbol_list.
2906         * psymtab.c (init_psymbol_list): Do nothing if already called.
2907         * psympriv.h (init_psymbol_list): Add comment.
2908         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2909         init_psymbol_list.
2910         * dbxread.c (dbx_symfile_read): Unconditionally call
2911         init_psymbol_list.
2912
2913 2019-01-10  Tom Tromey  <tom@tromey.com>
2914
2915         * xcoffread.c (scan_xcoff_symtab): Update.
2916         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2917         "where".
2918         * mdebugread.c (parse_partial_symbols)
2919         (handle_psymbol_enumerators): Update.
2920         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2921         * dbxread.c (read_dbx_symtab): Update.
2922         * psympriv.h (psymbol_placement): New enum.
2923         (add_psymbol_to_list): Update.
2924
2925 2019-01-10  Tom Tromey  <tom@tromey.com>
2926
2927         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2928         static_psymbols parameters.
2929         (scan_xcoff_symtab): Update.
2930         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2931         static_psymbols parameters.
2932         * psympriv.h (start_psymtab_common): Update.
2933         * mdebugread.c (parse_partial_symbols): Update.
2934         * dwarf2read.c (create_partial_symtab): Update.
2935         * dbxread.c (read_dbx_symtab): Update.
2936         (start_psymtab): Remove global_psymbols and static_psymbols
2937         parameters.
2938
2939 2019-01-10  Tom Tromey  <tom@tromey.com>
2940
2941         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2942         * psymtab.c (allocate_psymtab): Add comment.
2943         * psympriv.h (allocate_psymtab): Add comment.
2944         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2945         initializations.
2946         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2947
2948 2019-01-10  Tom Tromey  <tom@tromey.com>
2949
2950         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2951         Don't declare.
2952         * mipsread.c: Include mdebugread.h.
2953         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2954         Declare.
2955         * elfread.c: Include mdebugread.h.
2956
2957 2019-01-09  Tom Tromey  <tom@tromey.com>
2958
2959         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2960         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2961         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2962         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2963         (psym_lookup_symbol, psym_find_last_source_symtab)
2964         (psym_forget_cached_source_info, psym_print_stats)
2965         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2966         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2967         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2968         (psym_find_compunit_symtab_by_address)
2969         (maintenance_print_psymbols, maintenance_info_psymtabs)
2970         (maintenance_check_psymtabs): Use ranged for.
2971         * psymtab.h (class objfile_psymtabs): New.
2972         (require_partial_symbols): Return objfile_psymtabs.
2973         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2974
2975 2019-01-09  Tom Tromey  <tom@tromey.com>
2976
2977         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2978         (find_pc_mapped_section, list_overlays_command)
2979         (map_overlay_command, unmap_overlay_command)
2980         (simple_overlay_update): Use all_objfiles.
2981         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2982         * printcmd.c (info_symbol_command): Use all_objfiles.
2983         * objfiles.h (ALL_OBJSECTIONS): Remove.
2984         * maint.c (maintenance_translate_address): Use all_objfiles.
2985         * gcore.c (gcore_create_callback): Use all_objfiles.
2986         (objfile_find_memory_regions): Likewise.
2987
2988 2019-01-09  Tom Tromey  <tom@tromey.com>
2989
2990         * symtab.c (find_line_symtab, info_sources_command)
2991         (make_source_files_completion_list): Use objfile_compunits.
2992         * source.c (select_source_symtab): Use objfile_compunits.
2993         * objfiles.h (struct objfile): Update comment.
2994         (ALL_OBJFILES): Remove.
2995         (ALL_FILETABS): Remove.
2996         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2997         objfile_compunits.
2998
2999 2019-01-09  Tom Tromey  <tom@tromey.com>
3000
3001         * symmisc.c (print_objfile_statistics, dump_objfile)
3002         (maintenance_print_symbols): Use compunit_filetabs.
3003         * source.c (forget_cached_source_info_for_objfile): Use
3004         compunit_filetabs.
3005         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3006         (ALL_FILETABS): Use compunit_filetabs.
3007         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3008         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3009
3010 2019-01-09  Tom Tromey  <tom@tromey.com>
3011
3012         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3013         (compunit_filetabs): New.
3014         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3015         compunit_filetabs.
3016         (info_sources_command, make_source_files_completion_list): Remove
3017         declaration.
3018         * symmisc.c (print_objfile_statistics, dump_objfile)
3019         (maintenance_print_symbols): Remove declaration.
3020         (maintenance_info_symtabs): Use compunit_filetabs.
3021         (maintenance_info_line_tables): Likewise.
3022         * source.c (select_source_symtab): Change local variable name.
3023         (forget_cached_source_info_for_objfile): Remove declaration.
3024         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3025         * objfiles.c (objfile_relocate1): Remove declaration.
3026         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3027         declaration.
3028         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3029         * coffread.c (coff_symtab_read): Remove declaration.
3030         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3031         compunit_filetabs.
3032
3033 2019-01-09  Tom Tromey  <tom@tromey.com>
3034
3035         * symtab.c (lookup_objfile_from_block)
3036         (find_pc_sect_compunit_symtab, search_symbols)
3037         (default_collect_symbol_completion_matches_break_on): Use
3038         objfile_compunits.
3039         * objfiles.h (ALL_COMPUNITS): Remove.
3040         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3041         * cp-support.c (add_symbol_overload_list_qualified): Use
3042         objfile_compunits.
3043         * ada-lang.c (ada_collect_symbol_completion_matches)
3044         (ada_add_global_exceptions): Use objfile_compunits.
3045
3046 2019-01-09  Tom Tromey  <tom@tromey.com>
3047
3048         * source.c (select_source_symtab)
3049         (forget_cached_source_info_for_objfile): Remove declaration.
3050         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3051         declaration.
3052         * maint.c (count_symtabs_and_blocks): Remove declaration.
3053         * cp-support.c (add_symbol_overload_list_qualified): Remove
3054         declaration.
3055         * coffread.c (coff_symtab_read): Remove declaration.
3056         * symtab.c (lookup_symbol_in_objfile_symtabs)
3057         (basic_lookup_transparent_type_1): Use objfile_compunits.
3058         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3059         (info_sources_command, search_symbols)
3060         (default_collect_symbol_completion_matches_break_on)
3061         (make_source_files_completion_list): Remove declaration.
3062         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3063         (ada_collect_symbol_completion_matches)
3064         (ada_add_global_exceptions): Remove declaration.
3065         * linespec.c (iterate_over_all_matching_symtabs): Use
3066         objfile_compunits.
3067         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3068         (class objfile_compunits): New.
3069         (ALL_COMPUNITS): Use objfile_compunits.
3070         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3071         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3072         objfile_compunits.
3073         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3074
3075 2019-01-09  Tom Tromey  <tom@tromey.com>
3076
3077         * symtab.c (search_symbols)
3078         (default_collect_symbol_completion_matches_break_on): Use
3079         objfile_msymbols.
3080         * ada-lang.c (ada_lookup_simple_minsym)
3081         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3082         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3083         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3084         objfile_msymbols.
3085         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3086         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3087         * objc-lang.c (find_methods): Use objfile_msymbols.
3088         (info_selectors_command, info_classes_command): Likewise.
3089         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3090         * objfiles.h (class objfile_msymbols): New.
3091         (ALL_OBJFILE_MSYMBOLS): Remove.
3092         (ALL_MSYMBOLS): Remove.
3093
3094 2019-01-09  Tom Tromey  <tom@tromey.com>
3095
3096         * common/next-iterator.h (next_adapter): Add Iterator template
3097         parameter.
3098         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3099         (class all_objfiles_safe): New.
3100         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3101         * objfiles.c (put_objfile_before): Update comment.
3102         (add_separate_debug_objfile): Likewise.
3103         (free_all_objfiles): Use all_objfiles_safe.
3104         (objfile_purge_solibs): Likewise.
3105
3106 2019-01-09  Tom Tromey  <tom@tromey.com>
3107
3108         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3109         (expand_symtab_containing_pc, lookup_static_symbol)
3110         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3111         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3112         all_objfiles.
3113         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3114         * breakpoint.c (create_overlay_event_breakpoint)
3115         (create_longjmp_master_breakpoint)
3116         (create_std_terminate_master_breakpoint)
3117         (create_exception_master_breakpoint): Use all_objfiles.
3118         * linux-thread-db.c (try_thread_db_load_from_pdir)
3119         (has_libpthread): Use all_objfiles.
3120         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3121         * linespec.c (iterate_over_all_matching_symtabs)
3122         (search_minsyms_for_name): Use all_objfiles.
3123         * maint.c (maintenance_info_sections): Use all_objfiles.
3124         * main.c (captured_main_1): Use all_objfiles.
3125         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3126         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3127         * guile/scm-pretty-print.c
3128         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3129         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3130         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3131         (maintenance_print_msymbols): Use all_objfiles.
3132         * source.c (select_source_symtab): Use all_objfiles.
3133         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3134         * symfile.c (remove_symbol_file_command)
3135         (expand_symtabs_matching, map_symbol_filenames): Use
3136         all_objfiles.
3137         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3138         all_objfiles.
3139         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3140         * objc-lang.c (find_methods): Use all_objfiles.
3141         * objfiles.c (have_partial_symbols, have_full_symbols)
3142         (have_minimal_symbols, qsort_cmp)
3143         (default_iterate_over_objfiles_in_search_order): Use
3144         all_objfiles.
3145         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3146         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3147         (maintenance_check_psymtabs): Use all_objfiles.
3148         (ALL_PSYMTABS): Remove.
3149         * compile/compile-object-run.c (do_module_cleanup): Use
3150         all_objfiles.
3151         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3152         * cp-support.c (add_symbol_overload_list_qualified): Use
3153         all_objfiles.
3154         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3155         Use all_objfiles.
3156         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3157         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3158         all_objfiles.
3159         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3160         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3161         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3162         Uses all_objfiles.
3163         * solib.c (solib_read_symbols): Use all_objfiles
3164
3165 2019-01-09  Tom Tromey  <tom@tromey.com>
3166
3167         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3168         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3169         all_objfiles.
3170         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3171         * symmisc.c (print_symbol_bcache_statistics)
3172         (print_objfile_statistics, maintenance_print_objfiles)
3173         (maintenance_info_symtabs, maintenance_check_symtabs)
3174         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3175         all_objfiles.
3176         * source.c (forget_cached_source_info): Use all_objfiles.
3177         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3178         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3179         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3180         * objfiles.c (update_section_map): Use all_objfiles.
3181         (shared_objfile_contains_address_p): Likewise.
3182         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3183         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3184
3185 2019-01-09  Tom Tromey  <tom@tromey.com>
3186
3187         * common/next-iterator.h: New file.
3188         * objfiles.h (class all_objfiles): New.
3189         (struct objfile_iterator): New.
3190
3191 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3192
3193         * NEWS: Move the description of the changed "frame", "select-frame",
3194          and "info frame" commands to the Changed commands section.
3195
3196 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3197
3198         * gdbtypes.c (check_stub_method_group): Remove handling of old
3199         mangling schemes.
3200         * linespec.c (find_methods): Likewise.
3201         * stabsread.c (read_member_functions): Likewise.
3202         * valops.c (search_struct_method): Likewise.
3203         (value_struct_elt_for_reference): Likewise.
3204         * NEWS: Mention this change.
3205
3206 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3207
3208         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3209         print_source_lines.
3210         * source.c (print_source_lines_base): Update line number check.
3211         (print_source_lines): New function.
3212         (source_lines_range::source_lines_range): New function.
3213         * source.h (class source_lines_range): New class.
3214         (print_source_lines): New declaration.
3215
3216 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3217
3218         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3219
3220 2019-01-08  Tom Tromey  <tom@tromey.com>
3221             Simon Marchi  <simon.marchi@ericsson.com>
3222
3223         PR gdb/24060
3224         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3225         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3226         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3227         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3228         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3229         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3230
3231 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3232
3233         * source.c (select_source_symtab): Move header comment to
3234         declaration in source.h.
3235         (forget_cached_source_info_for_objfile): Likewise.
3236         (forget_cached_source_info): Likewise.
3237         (identify_source_line): Likewise.
3238         * source.h (identify_source_line): Move declaration from symtab.h
3239         and add comment from source.c
3240         (print_source_lines): Likewise.
3241         (forget_cached_source_info_for_objfile): Likewise.
3242         (forget_cached_source_info): Likewise.
3243         (select_source_symtab): Likewise.
3244         (enum print_source_lines_flag): Move definition from symtab.h.
3245         * symtab.h (identify_source_line): Move declaration to source.h.
3246         (print_source_lines): Likewise.
3247         (forget_cached_source_info_for_objfile): Likewise.
3248         (forget_cached_source_info): Likewise.
3249         (select_source_symtab): Likewise.
3250         (enum print_source_lines_flag): Move definition to source.h.
3251         * tui/tui-hooks.c: Add 'source.h' include.
3252
3253 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3254
3255         * source.c (print_source_lines_base): Handle requests to print
3256         reverse line number sequences, and guard against empty lines
3257         string.
3258
3259 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3260
3261         * source.c (print_source_lines_base): Fix skip of '\r' if next
3262         character is '\n'.
3263
3264 2019-01-06  Tom Tromey  <tom@tromey.com>
3265
3266         * c-exp.y (struct c_parse_state) <macro_original_text,
3267         expansion_obstack>: New member.
3268         (macro_original_text, expansion_obstack): Remove globals.
3269         (scan_macro_expansion, scanning_macro_expansion)
3270         (finished_macro_expansion): Update.
3271         (scan_macro_cleanup): Remove.
3272         (yylex, c_parse): Update.
3273
3274 2019-01-06  Tom Tromey  <tom@tromey.com>
3275
3276         * c-exp.y (struct c_parse_state) <strings>: New member.
3277         (operator_stoken): Update.
3278
3279 2019-01-06  Tom Tromey  <tom@tromey.com>
3280
3281         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3282         (union type_stack_elt) <typelist_val>: Now a pointer to
3283         std::vector.
3284         (type_stack_cleanup): Don't declare.
3285         (push_typelist): Update.
3286         * parse.c (pop_typelist): Return a std::vector.
3287         (push_typelist): Take a std::vector.
3288         (follow_types): Update.  Do not free args.
3289         (type_stack_cleanup): Remove.
3290         * c-exp.y (struct c_parse_state): New.
3291         (cpstate): New global.
3292         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3293         (nonempty_typelist): Update.
3294         (func_mod): Create a new vector.
3295         (c_parse): Create a c_parse_state.
3296         (check_parameter_typelist): Do not delete params.
3297         (function_method): Update.  Do not delete type_list.
3298
3299 2019-01-06  Tom Tromey  <tom@tromey.com>
3300
3301         PR gdb/28155:
3302         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3303         check_typedef.
3304         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3305         (print_return_value): Likewise.
3306
3307 2019-01-05  Tom Tromey  <tom@tromey.com>
3308
3309         * contrib/cleanup_check.py: Remove.
3310         * contrib/gcc-with-excheck: Remove.
3311         * contrib/exsummary.py: Remove.
3312         * contrib/excheck.py: Remove.
3313
3314 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3315
3316         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3317         NULL. Initialize tpprev to NULL instead of assigning it
3318         to NULL on the next statement.
3319         * windows-nat.c (windows_delete_thread): Remove check for
3320         main_thread_id before printing thread exit notifications.
3321         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3322         Remove thread ID check against main_thread_id.
3323         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3324         windows_delete_thread.
3325         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3326
3327 2019-01-04  Tom Tromey  <tom@tromey.com>
3328
3329         * compile/compile.c (_initialize_compile): Use upper case for
3330         metasyntactic variables.
3331         * symmisc.c (_initialize_symmisc): Use upper case for
3332         metasyntactic variables.
3333         * psymtab.c (_initialize_psymtab): Use upper case for
3334         metasyntactic variables.
3335         * demangle.c (demangle_command): Use upper case for metasyntactic
3336         variables.
3337         (_initialize_demangler): Likewise.
3338         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3339         variables.
3340
3341 2019-01-03  Tom Tromey  <tom@tromey.com>
3342
3343         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3344
3345 2019-01-03  Tom Tromey  <tom@tromey.com>
3346
3347         * python/py-symtab.c (salpy_str): Update.
3348         (struct salpy_sal_object) <symtab>: Now a PyObject.
3349         (salpy_dealloc): Update.
3350         (del_objfile_sal): Use gdbpy_ref.
3351
3352 2019-01-03  Tom Tromey  <tom@tromey.com>
3353
3354         * python/py-type.c (convert_field): Use new_reference.  Return
3355         gdbpy_ref.
3356         (make_fielditem): Return gdbpy_ref.
3357         (typy_fields): Update.
3358         (typy_getitem): Update.
3359         (field_name): Return gdbpy_ref.  Use new_reference.
3360         (typy_iterator_iternext): Update.
3361
3362 2019-01-03  Tom Tromey  <tom@tromey.com>
3363
3364         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3365
3366 2019-01-03  Tom Tromey  <tom@tromey.com>
3367
3368         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3369         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3370         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3371         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3372         (pspy_set_type_printers): Likewise.
3373         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3374         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3375         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3376         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3377         (objfpy_set_type_printers): Likewise.
3378
3379 2019-01-03  Tom Tromey  <tom@tromey.com>
3380
3381         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3382         (gdbpy_print_stack): Use gdbpy_err_fetch.
3383         * python/python-internal.h (class gdbpy_err_fetch): New class.
3384         (class gdbpy_enter) <m_error_type, m_error_value,
3385         m_error_traceback>: Remove.
3386         <m_error>: New member.
3387         (gdbpy_exception_to_string): Don't declare.
3388         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3389         * python/py-value.c (convert_value_from_python): Use
3390         gdbpy_err_fetch.
3391         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3392         gdbpy_exception_to_string.
3393         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3394         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3395         gdbpy_err_fetch.
3396
3397 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3398
3399         * linux-nat.c (delete_lwp_cleanup): Delete.
3400         (struct lwp_deleter): New struct.
3401         (lwp_info_up): New typedef.
3402         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3403         lwp_info_up.
3404
3405 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3406
3407         * linux-fork.c (class scoped_switch_fork_info): New class.
3408         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3409
3410 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3411
3412         * valops.c (find_overload_match): Remove use of null_cleanup, and
3413         calls to do_cleanups.
3414
3415 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3416
3417         * compile/compile-cplus-types.c
3418         (compile_cplus_instance::decl_name): Handle changes to
3419         cp_func_name.
3420         * cp-support.c (cp_func_name): Update header comment, update
3421         return type.
3422         * cp-support.h (cp_func_name): Update return type in declaration.
3423         * valops.c (find_overload_match): Move temp_func local to top
3424         level of function and change its type.  Use temp_func to hold and
3425         delete temporary string obtained from cp_func_name.
3426
3427 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3428
3429         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3430         gdb::char_vector, remove cleanup, and update uses of `msg`.
3431
3432 2019-01-03  Jim Wilson  <jimw@sifive.com>
3433
3434         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3435
3436 2019-01-02  Tom Tromey  <tom@tromey.com>
3437
3438         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3439         (tdesc_parse_xml): Remove cleanups.
3440         * target-descriptions.h (make_cleanup_free_target_description):
3441         Don't declare.
3442         (target_desc_deleter): New struct.
3443         (target_desc_up): New typedef.
3444         * target-descriptions.c (target_desc_deleter::operator()): Rename
3445         from free_target_description.
3446         (make_cleanup_free_target_description): Remove.
3447
3448 2019-01-02  Tom Tromey  <tom@tromey.com>
3449
3450         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3451         constructor, destructor.
3452         (linespec_parser): Remove typedef.
3453         (~linespec_parser): Rename from linespec_parser_delete.
3454         (linespec_lex_to_end, linespec_complete_label)
3455         (linespec_complete): Update.
3456         (decode_line_full): Remove cleanups.
3457         (decode_line_1): Update.
3458
3459 2019-01-02  Tom Tromey  <tom@tromey.com>
3460
3461         * python/python-internal.h (inferior_to_inferior_object): Change
3462         return type.
3463         * python/py-exitedevent.c (create_exited_event_object): Update.
3464         * python/py-inferior.c (inferior_to_inferior_object): Return
3465         gdbpy_ref.
3466         (python_new_inferior, python_inferior_deleted)
3467         (thread_to_thread_object, delete_thread_object)
3468         (build_inferior_list, gdbpy_selected_inferior): Update.
3469         * python/py-infthread.c (create_thread_object): Update.  Also fail
3470         if inferior_to_inferior_object fails.
3471
3472 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3473
3474         * inferior.h (class inferior) <displaced_step_state>: New field.
3475         * infrun.h (struct displaced_step_state): Move here from
3476         infrun.c.  Initialize fields, add constructor.
3477         <inf>: Remove field.
3478         <reset>: New method.
3479         * infrun.c (struct displaced_step_inferior_state): Move to
3480         infrun.h.
3481         (displaced_step_inferior_states): Remove.
3482         (get_displaced_stepping_state): Adust.
3483         (displaced_step_in_progress_any_inferior): Adjust.
3484         (displaced_step_in_progress_thread): Adjust.
3485         (displaced_step_in_progress): Adjust.
3486         (add_displaced_stepping_state): Remove.
3487         (get_displaced_step_closure_by_addr): Adjust.
3488         (remove_displaced_stepping_state): Remove.
3489         (infrun_inferior_exit): Call displaced_step_state.reset.
3490         (use_displaced_stepping): Don't check for NULL.
3491         (displaced_step_prepare_throw): Call
3492         get_displaced_stepping_state.
3493         (displaced_step_fixup): Don't check for NULL.
3494         (prepare_for_detach): Don't check for NULL.
3495
3496 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3497
3498         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3499          in case of call that did not complete.
3500
3501 2019-01-02  Andrey Utkin  <autkin@undo.io>
3502
3503         * symfile.c (find_separate_debug_file): Fix search of debug files for
3504         remote debuggee.
3505
3506 2019-01-02  Tom Tromey  <tom@tromey.com>
3507
3508         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3509         indentation.
3510         * python/py-frame.c (frapy_older): Remove cast.
3511         (frapy_newer): Likewise.
3512         * python/py-breakpoint.c (local_setattro): Remove cast.
3513         * python/py-arch.c (archpy_name): Remove local variable.
3514         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3515
3516 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3517
3518         * unittests/basic_string_view/element_access/char/empty.cc:
3519         Fix year range in copyright header.
3520
3521 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3522
3523         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3524         Delete.
3525         <operator==>: Update with for removed field.
3526         <hash>: Likewise.
3527         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3528         <isa_features>: ...this.
3529         <abi_features>: New field.
3530         (riscv_isa_flen): Update comment.
3531         (riscv_abi_xlen): New declaration.
3532         (riscv_abi_flen): New declaration.
3533         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3534         isa_features.
3535         (riscv_abi_xlen): New function.
3536         (riscv_isa_flen): Update to get answer from isa_features.
3537         (riscv_abi_flen): New function.
3538         (riscv_has_fp_abi): Update to get answer from abi_features.
3539         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3540         xlen and flen.
3541         (riscv_call_info) <xlen, flen>: Update comment.
3542         (riscv_call_arg_struct): Remove invalid assertions
3543         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3544         is removed.
3545         (riscv_gdbarch_init): Gather isa features and abi features
3546         separately, ensure both match on the gdbarch when reusing an old
3547         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3548         a target with 64-bit float hardware.
3549
3550 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3551
3552         * source.c (search_command_helper): Stop reverse search
3553         when line 1 has been searched.
3554
3555 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3556
3557         * record-full.c (record_full_base_target::close): Rewrite
3558         record_full_core_buf_list free logic.
3559
3560 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3561
3562         * break-catch-syscall.c (print_one_catch_syscall): xfree
3563         the last text.
3564
3565 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3566
3567         * top.c (print_gdb_version): Update Copyright year in version
3568         message.
3569
3570 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3571
3572         Update copyright year range in all GDB files.
3573
3574 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3575
3576         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3577
3578 For older changes see ChangeLog-2018.
3579 \f
3580 Local Variables:
3581 mode: change-log
3582 left-margin: 8
3583 fill-column: 74
3584 version-control: never
3585 coding: utf-8
3586 End:
3587