gdb/ChangeLog

   1 2019-01-22  Tom Tromey  <tom@tromey.com>
   2
   3         * stabsread.c (EXTERN): Do not define.
   4         (symnum, next_symbol_text_func, processing_gcc_compilation)
   5         (within_function, global_sym_chain, global_stabs)
   6         (previous_stab_code, this_object_header_files)
   7         (n_this_object_header_files)
   8         (n_allocated_this_object_header_files): Define.
   9         * stabsread.h (EXTERN): Never define.  Use "extern".
  10
  11 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  12
  13         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
  14         history_value.
  15
  16 2019-01-21  Tom Tromey  <tom@tromey.com>
  17
  18         * ui-out.c: Fix includes.
  19         * tui/tui-source.c: Fix includes.
  20         * target.c: Fix includes.
  21         * remote.c: Fix includes.
  22         * regcache.c: Fix includes.
  23         * python/py-block.c: Fix includes.
  24         * printcmd.c: Fix includes.
  25         * or1k-tdep.c: Fix includes.
  26         * mi/mi-main.c: Fix includes.
  27         * m32r-tdep.c: Fix includes.
  28         * csky-tdep.c: Fix includes.
  29         * compile/compile-cplus-types.c: Fix includes.
  30         * cli/cli-interp.c: Fix includes.
  31
  32 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
  33
  34         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  35         for padding.
  36
  37 2019-01-16  Tom Tromey  <tom@tromey.com>
  38
  39         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
  40         earlier.
  41         (struct objfile) <msymbols_range>: Move from top level.
  42         <msymbols>: New method.
  43         (class objfile_msymbols): Remove.
  44         * symtab.c (default_collect_symbol_completion_matches_break_on):
  45         Update.
  46         * symmisc.c (dump_msymbols): Update.
  47         * stabsread.c (scan_file_globals): Update.
  48         * objc-lang.c (info_selectors_command, info_classes_command)
  49         (find_methods): Update.
  50         * minsyms.c (find_solib_trampoline_target): Update.
  51         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
  52         * coffread.c (coff_symfile_read): Update.
  53         * ada-lang.c (ada_lookup_simple_minsym)
  54         (ada_collect_symbol_completion_matches): Update.
  55
  56 2019-01-16  Tom Tromey  <tom@tromey.com>
  57
  58         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
  59         type.  Remove no-argument constructor.
  60         <iterator::operator++>: Simplify.
  61         <begin>: Update.
  62         <end>: Use minimal_symbol_count.
  63
  64 2019-01-16  Tom Tromey  <tom@tromey.com>
  65
  66         * objfiles.h (struct objfile) <psymtabs>: New method.
  67         (class objfile_psymtabs): Remove.
  68         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
  69         typedef.
  70         <range>: New method.
  71         (require_partial_symbols): Change return type.
  72         * psymtab.c (require_partial_symbols)
  73         (psym_expand_symtabs_matching): Update.
  74         * mdebugread.c (parse_partial_symbols): Update.
  75         * dbxread.c (dbx_end_psymtab): Update.
  76
  77 2019-01-15  Tom Tromey  <tom@tromey.com>
  78
  79         * symtab.c (lookup_objfile_from_block)
  80         (lookup_symbol_in_objfile_symtabs)
  81         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
  82         (find_line_symtab, info_sources_command)
  83         (default_collect_symbol_completion_matches_break_on)
  84         (make_source_files_completion_list): Update.
  85         * symmisc.c (print_objfile_statistics, dump_objfile)
  86         (maintenance_print_symbols, maintenance_info_symtabs)
  87         (maintenance_check_symtabs, maintenance_info_line_tables):
  88         Update.
  89         * source.c (select_source_symtab)
  90         (forget_cached_source_info_for_objfile): Update.
  91         * objfiles.h (class objfile_compunits): Remove.
  92         (struct objfile) <compunits_range>: New typedef.
  93         (compunits): New method.
  94         * objfiles.c (objfile_relocate1): Update.
  95         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
  96         * maint.c (count_symtabs_and_blocks): Update.
  97         * linespec.c (iterate_over_all_matching_symtabs): Update.
  98         * cp-support.c (add_symbol_overload_list_qualified): Update.
  99         * coffread.c (coff_symtab_read): Update.
 100         * ada-lang.c (add_nonlocal_symbols)
 101         (ada_collect_symbol_completion_matches)
 102         (ada_add_global_exceptions): Update.
 103
 104 2019-01-15  Tom Tromey  <tom@tromey.com>
 105
 106         * progspace.h (program_space) <objfiles_safe_range>: New
 107         typedef.
 108         <objfiles_safe>: New method.
 109         * objfiles.h (class all_objfiles_safe): Remove.
 110         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 111         * jit.c (jit_inferior_exit_hook): Update.
 112
 113 2019-01-17  Tom Tromey  <tom@tromey.com>
 114
 115         * progspace.h (program_space) <objfiles_range>: New typedef.
 116         <objfiles>: New method.
 117         <objfiles_head>: Rename from objfiles.
 118         (object_files): Update.
 119         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 120         * guile/scm-pretty-print.c
 121         (ppscm_find_pretty_printer_from_objfiles): Update.
 122         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 123         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 124         Update.
 125         * python/py-progspace.c (pspy_get_objfiles): Update.
 126         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 127         Update.
 128         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 129         (objfpy_lookup_objfile_by_build_id): Update.
 130         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 131         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 132         Update.
 133         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 134         (expand_symtab_containing_pc, lookup_objfile_from_block)
 135         (lookup_static_symbol, basic_lookup_transparent_type)
 136         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 137         (find_line_symtab, info_sources_command)
 138         (default_collect_symbol_completion_matches_break_on)
 139         (make_source_files_completion_list, find_main_name): Update.
 140         * symmisc.c (print_symbol_bcache_statistics)
 141         (print_objfile_statistics, maintenance_print_symbols)
 142         (maintenance_print_msymbols, maintenance_print_objfiles)
 143         (maintenance_info_symtabs, maintenance_check_symtabs)
 144         (maintenance_expand_symtabs, maintenance_info_line_tables):
 145         Update.
 146         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 147         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 148         (map_overlay_command, unmap_overlay_command)
 149         (simple_overlay_update, expand_symtabs_matching)
 150         (map_symbol_filenames): Update.
 151         * symfile-debug.c (set_debug_symfile): Update.
 152         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 153         Update.
 154         * source.c (select_source_symtab, forget_cached_source_info):
 155         Update.
 156         * solib.c (solib_read_symbols): Update.
 157         * solib-spu.c (append_ocl_sos): Update.
 158         * psymtab.c (maintenance_print_psymbols)
 159         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 160         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 161         * printcmd.c (info_symbol_command): Update.
 162         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 163         Update.
 164         * objfiles.h (class all_objfiles): Remove.
 165         * objfiles.c (have_partial_symbols, have_full_symbols)
 166         (have_minimal_symbols, qsort_cmp, update_section_map)
 167         (shared_objfile_contains_address_p)
 168         (default_iterate_over_objfiles_in_search_order): Update.
 169         * objc-lang.c (info_selectors_command, info_classes_command)
 170         (find_methods): Update.
 171         * minsyms.c (find_solib_trampoline_target): Update.
 172         * maint.c (maintenance_info_sections)
 173         (maintenance_translate_address, count_symtabs_and_blocks):
 174         Update.
 175         * main.c (captured_main_1): Update.
 176         * linux-thread-db.c (try_thread_db_load_from_pdir)
 177         (has_libpthread): Update.
 178         * linespec.c (iterate_over_all_matching_symtabs)
 179         (search_minsyms_for_name): Update.
 180         * jit.c (jit_find_objf_with_entry_addr): Update.
 181         * hppa-tdep.c (find_unwind_entry)
 182         (hppa_lookup_stub_minimal_symbol): Update.
 183         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 184         Update.
 185         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 186         (elf_gnu_ifunc_resolve_by_got): Update.
 187         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 188         * dwarf-index-write.c (save_gdb_index_command): Update.
 189         * cp-support.c (add_symbol_overload_list_qualified): Update.
 190         * breakpoint.c (create_overlay_event_breakpoint)
 191         (create_longjmp_master_breakpoint)
 192         (create_std_terminate_master_breakpoint)
 193         (create_exception_master_breakpoint): Update.
 194         * blockframe.c (find_pc_partial_function): Update.
 195         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 196         (ada_collect_symbol_completion_matches)
 197         (ada_add_global_exceptions): Update.
 198
 199 2019-01-17  Tom Tromey  <tom@tromey.com>
 200
 201         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 202         declare VEC.
 203         (solib_target_parse_libraries): Change return type.
 204         (library_list_start_segment, library_list_start_section)
 205         (library_list_end_library, library_list_start_library); Update.
 206         (solib_target_free_library_list): Remove.
 207         (solib_target_parse_libraries): Remove cleanup.  Change return
 208         type.
 209         (solib_target_current_sos): Update.
 210
 211 2019-01-17  Tom Tromey  <tromey@bapiya>
 212
 213         * valprint.c: Replace "the the" with "the".
 214         * symtab.c: Replace "the the" with "the".
 215         * solib.c: Replace "the the" with "the".
 216         * solib-dsbt.c: Replace "the the" with "the".
 217         * linespec.c: Replace "the the" with "the".
 218         * dwarf2loc.h: Replace "the the" with "the".
 219         * amd64-windows-tdep.c: Replace "the the" with "the".
 220         * aarch64-tdep.c: Replace "the the" with "the".
 221
 222 2019-01-16  Keith Seitz  <keiths@redhat.com>
 223
 224         PR gdb/23773
 225         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 226         <builder>: Rename to ..
 227         <m_builder>: ... this and make private.
 228         (dwarf2_cu::get_builder): New method.  Change all users of
 229         `builder' to use this method.
 230         (dwarf2_start_symtab): Move to ...
 231         (dwarf2_cu::start_symtab): ... here.  Update all callers
 232         (setup_type_unit_groups): Move to ...
 233         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 234         callers.
 235         (dwarf2_cu::reset_builder): New method.
 236         (process_full_compunit, process_full_type_unit): Use
 237         dwarf2_cu::reset_builder.
 238         (follow_die_offset): Record the ancestor CU if it is different
 239         from the followed DIE's CU.
 240         (follow_die_sig_1): Likewise.
 241
 242 2019-01-15  Tom Tromey  <tom@tromey.com>
 243
 244         * remote.c (class remote_state) <buf>: Now a char_vector.
 245         <buf_size>: Remove.
 246         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 247         parameter.
 248         (remote_target::getpkt_or_notif_sane_1)
 249         (remote_target::getpkt_sane)
 250         (remote_target::getpkt_or_notif_sane): Likewise.
 251         (class remote_target) <putpkt>: New overload.
 252         (remote_target::read_frame): Change type of "buf_p".  Remove
 253         sizeof_p parameter.
 254         (packet_ok): New overload.
 255         (packet_check_result): New overload.
 256         Update all uses.
 257
 258 2019-01-14  Tom Tromey  <tom@tromey.com>
 259
 260         * remote-notif.c (handle_notification, remote_notif_ack)
 261         (remote_notif_parse): Make "buf" const.
 262         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 263         const.
 264         (remote_notif_parse, remote_notif_ack, handle_notification):
 265         Likewise.
 266         * remote.c (remote_notif_stop_parse): Make "buf" const.
 267         (remote_target::remote_parse_stop_reply): Make "buf" const.
 268         (remote_notif_stop_ack): Make "buf" const.
 269
 270 2019-01-14  Tom Tromey  <tom@tromey.com>
 271
 272         * remote.c (remote_console_output): Make parameter const.
 273
 274 2019-01-14  Tom Tromey  <tom@tromey.com>
 275
 276         * target-debug.h (target_debug_print_signals): Constify.
 277         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 278         * procfs.c (procfs_target::pass_signals): Update.
 279         * linux-nat.c (linux_nat_target::pass_signals): Update.
 280         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 281         * target-delegates.c: Rebuild.
 282         * remote.c (remote_target::program_signals): Update.
 283         (remote_target::pass_signals): Update.
 284         * target.c (target_pass_signals): Constify argument.
 285         (target_program_signals): Likewise.
 286         * target.h (struct target_ops) <pass_signals, program_signals>:
 287         Constify argument.
 288         (target_pass_signals, target_program_signals): Constify argument.
 289
 290 2019-01-14  Tom Tromey  <tom@tromey.com>
 291
 292         PR tui/28819:
 293         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 294
 295 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 296
 297         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 298         field.
 299         * rs6000-tdep.c: Include reggroups.h.
 300         (IS_V_ALIAS_PSEUDOREG): Define.
 301         (rs6000_register_name): Return names for the "vX" aliases.
 302         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 303         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 304         aliases.  Call default_register_reggroup_p for all other
 305         pseudo-registers.
 306         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 307         New functions.
 308         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 309         Handle "vX" aliases.
 310         (v_alias_pseudo_register_collect): New function.
 311         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 312         (rs6000_gdbarch_init): Initialize "vX" aliases as
 313         pseudo-registers.  Restore registration of
 314         rs6000_pseudo_register_reggroup_p with
 315         set_tdesc_pseudo_register_reggroup_p.
 316
 317 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 318
 319         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 320         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 321         set_gdbarch_num_pseudo_regs.
 322
 323 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 324
 325         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 326         Remove arg prefixname, add do_set and do_show.
 327         Add member functions set_list and show_list.
 328         * cli/cli-style.c (class cli_style_option): Update accordingly.
 329         (style_set_list): Move to file scope.
 330         (style_show_list): Likewise.
 331         (set_style): Call help_list.
 332         (show_style): Call cmd_show_list.
 333         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 334         Update to use the new macro.
 335
 336 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 337
 338         * ada-lang.c (_initialize_ada_language): Expand the help text
 339         for the "catch exception" command.
 340
 341 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 342
 343         * symtab.c (matching_obj_sections): Initialize obj,
 344         declare it closer to its usage.
 345
 346 2019-01-10  Tom Tromey  <tom@tromey.com>
 347
 348         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 349         (basic_inf_threads_range): Remove.
 350         (inf_threads_range, inf_non_exited_threads_range)
 351         (safe_inf_threads_range): Use next_adapter.
 352
 353 2019-01-10  Keith Seitz  <keiths@redhat.com>
 354
 355         PR gdb/23712
 356         PR symtab/23010
 357         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 358         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 359
 360 2019-01-10  Keith Seitz  <keiths@redhat.com>
 361
 362         PR gdb/23712
 363         PR symtab/23010
 364         * dictionary.c (pending_to_vector): Remove.
 365         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 366         Remove _1 suffix, replacing functions of the same name.  Update
 367         all callers.
 368         (dict_create_hashed, dict_create_hashed_expandable)
 369         (dict_create_linear, dict_create_linear_expandable, dict_free)
 370         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 371         Make functions static.
 372
 373 2019-01-10  Keith Seitz  <keiths@redhat.com>
 374
 375         PR gdb/23712
 376         PR symtab/23010
 377         * dictionary.h (struct dictionary): Replace declaration with
 378         multidictionary.
 379         (dict_create_hashed, dict_create_hashed_expandable)
 380         (dict_create_linear, dict_create_linear_expandable)
 381         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 382         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 383         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 384         taking multidictionary argument.
 385         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 386         * block.h (struct block) <dict>: Change to multidictionary
 387         and rename `multidict'.
 388         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 389         symmisc.c: Update all dictionary references to multidictionary.
 390
 391 2019-01-10  Keith Seitz  <keiths@redhat.com>
 392
 393         PR gdb/23712
 394         PR symtab/23010
 395         * dictionary.c: Include unordered_map.
 396         (pending_to_vector): New function.
 397         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 398         Rewrite the non-"_1" functions to take vector instead
 399         of linked list.
 400         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 401         "new" _1 versions of the same name.
 402         (multidictionary): Define.
 403         (std::hash<enum language): New definition.
 404         (collate_pending_symbols_by_language, mdict_create_hashed)
 405         (mdict_create_hashed_expandable, mdict_create_linear)
 406         (mdict_create_linear_expandable, mdict_free)
 407         (find_language_dictionary, create_new_language_dictionary)
 408         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 409         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 410         (mdict_size, mdict_empty): New functions.
 411         * dictionary.h (mdict_iterator): Define.
 412
 413 2019-01-10  Pedro Alves  <palves@redhat.com>
 414
 415         * breakpoint.c (read_uploaded_action)
 416         (create_tracepoint_from_upload): Adjust to use
 417         gdb::unique_xmalloc_ptr.
 418         * ctf.c (ctf_write_uploaded_tp):
 419         (SET_ARRAY_FIELD): Use emplace_back.
 420         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 421         * tracefile-tfile.c (tfile_write_uploaded_tp):
 422         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 423         gdb::unique_xmalloc_ptr.
 424         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 425         at_string, cond_string, cmd_strings>: Replace char pointers
 426         with gdb::unique_xmalloc_ptr.
 427
 428 2019-01-10  Pedro Alves  <palves@redhat.com>
 429
 430         * solib-target.c (library_list_start_library): Don't xstrdup name.
 431
 432 2019-01-10  Pedro Alves  <palves@redhat.com>
 433
 434         * mdebugread.c (parse_partial_symbols): Use
 435         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 436
 437 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 438
 439         * linux-fork.c (scoped_switch_fork_info)
 440         <~scoped_switch_fork_info>: Fix incorrect variable name.
 441
 442 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 443
 444         * linux-fork.c (scoped_switch_fork_info)
 445         <scoped_switch_fork_info>: Make explicit.
 446         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 447
 448 2019-01-10  Tom Tromey  <tom@tromey.com>
 449
 450         * objfiles.h (objfile::reset_psymtabs): Update.
 451         * objfiles.c (objfile::objfile): Update.
 452         * psymtab.h (psymtab_storage::obstack): Update.
 453         (psymtab_storage::m_obstack): Use gdb::optional.
 454         (class psymtab_storage): Update comment.  Remove objfile
 455         parameter.
 456         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 457
 458 2019-01-10  Tom Tromey  <tom@tromey.com>
 459
 460         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 461         <free_psymtabs>: Now private.
 462         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 463         (allocate_psymtab): Use new method.
 464
 465 2019-01-10  Tom Tromey  <tom@tromey.com>
 466
 467         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 468         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 469         * mdebugread.c (parse_partial_symbols): Use
 470         allocate_dependencies.
 471         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 472         allocate_dependencies.
 473         (process_psymtab_comp_unit_reader)
 474         (build_type_psymtab_dependencies): Likewise.
 475         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 476
 477 2019-01-10  Tom Tromey  <tom@tromey.com>
 478
 479         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 480         PSYMBOL_SET_LANGUAGE.
 481         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 482
 483 2019-01-10  Tom Tromey  <tom@tromey.com>
 484
 485         * psymtab.h (psymtab_storage::obstack): New method.
 486         <m_obstack>: Rename from obstack; now private.
 487         * psymtab.c (psymtab_storage): Update.
 488         * dwarf2read.c (create_addrmap_from_index)
 489         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 490         Update.
 491
 492 2019-01-10  Tom Tromey  <tom@tromey.com>
 493
 494         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 495         * objfiles.h (objfile::reset_psymtabs): New method.
 496
 497 2019-01-10  Tom Tromey  <tom@tromey.com>
 498
 499         * symmisc.c (print_symbol_bcache_statistics): Update.
 500         (print_objfile_statistics): Update.
 501         * symfile.c (reread_symbols): Update.
 502         * psymtab.h (class psymtab_storage): New.
 503         * psymtab.c (psymtab_storage): New constructor.
 504         (~psymtab_storage): New destructor.
 505         (require_partial_symbols): Update.
 506         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 507         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 508         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 509         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 510         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 511         (start_psymtab_common, end_psymtab_common)
 512         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 513         (allocate_psymtab): Update.
 514         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 515         Update.
 516         (dump_psymtab_addrmap, maintenance_print_psymbols)
 517         (maintenance_check_psymtabs): Update.
 518         (class objfile_psymtabs): Move to objfiles.h.
 519         * psympriv.h (discard_psymtab): Now inline.
 520         (psymtab_discarder::psymtab_discarder): Update.
 521         (psymtab_discarder::~psymtab_discarder): Update.
 522         (ALL_OBJFILE_PSYMTABS): Rewrite.
 523         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 524         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 525         Remove fields.
 526         <partial_symtabs>: New field.
 527         (class objfile_psymtabs): Move from psymtab.h.  Update.
 528         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 529         psymbol_cache.
 530         (objfile::~objfile): Don't destroy psymbol_cache.
 531         * mdebugread.c (parse_partial_symbols): Update.
 532         * dwarf2read.c (create_addrmap_from_index)
 533         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 534         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 535         (add_partial_subprogram, dwarf2_ranges_read): Update.
 536         * dwarf-index-write.c (write_address_map)
 537         (write_one_signatured_type, recursively_write_psymbols)
 538         (class debug_names, class debug_names, write_psymtabs_to_index):
 539         Update.
 540
 541 2019-01-10  Tom Tromey  <tom@tromey.com>
 542
 543         * symtab.h (SYMBOL_SET_NAMES): Update.
 544         (symbol_set_names): Update.
 545         (MSYMBOL_SET_NAMES): Update.
 546         * symtab.c (symbol_set_names): Change argument to be an
 547         objfile_per_bfd_storage.
 548         * psymtab.c (add_psymbol_to_bcache): Update.
 549         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 550
 551 2019-01-10  Tom Tromey  <tom@tromey.com>
 552
 553         * symtab.c (create_demangled_names_hash): Change argument to be an
 554         objfile_per_bfd_storage.
 555         (symbol_set_names): Update.
 556
 557 2019-01-10  Tom Tromey  <tom@tromey.com>
 558
 559         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 560         init_psymbol_list.
 561         * psymtab.c (init_psymbol_list): Do nothing if already called.
 562         * psympriv.h (init_psymbol_list): Add comment.
 563         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 564         init_psymbol_list.
 565         * dbxread.c (dbx_symfile_read): Unconditionally call
 566         init_psymbol_list.
 567
 568 2019-01-10  Tom Tromey  <tom@tromey.com>
 569
 570         * xcoffread.c (scan_xcoff_symtab): Update.
 571         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 572         "where".
 573         * mdebugread.c (parse_partial_symbols)
 574         (handle_psymbol_enumerators): Update.
 575         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 576         * dbxread.c (read_dbx_symtab): Update.
 577         * psympriv.h (psymbol_placement): New enum.
 578         (add_psymbol_to_list): Update.
 579
 580 2019-01-10  Tom Tromey  <tom@tromey.com>
 581
 582         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 583         static_psymbols parameters.
 584         (scan_xcoff_symtab): Update.
 585         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 586         static_psymbols parameters.
 587         * psympriv.h (start_psymtab_common): Update.
 588         * mdebugread.c (parse_partial_symbols): Update.
 589         * dwarf2read.c (create_partial_symtab): Update.
 590         * dbxread.c (read_dbx_symtab): Update.
 591         (start_psymtab): Remove global_psymbols and static_psymbols
 592         parameters.
 593
 594 2019-01-10  Tom Tromey  <tom@tromey.com>
 595
 596         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 597         * psymtab.c (allocate_psymtab): Add comment.
 598         * psympriv.h (allocate_psymtab): Add comment.
 599         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 600         initializations.
 601         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 602
 603 2019-01-10  Tom Tromey  <tom@tromey.com>
 604
 605         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 606         Don't declare.
 607         * mipsread.c: Include mdebugread.h.
 608         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 609         Declare.
 610         * elfread.c: Include mdebugread.h.
 611
 612 2019-01-09  Tom Tromey  <tom@tromey.com>
 613
 614         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 615         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 616         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 617         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 618         (psym_lookup_symbol, psym_find_last_source_symtab)
 619         (psym_forget_cached_source_info, psym_print_stats)
 620         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 621         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 622         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 623         (psym_find_compunit_symtab_by_address)
 624         (maintenance_print_psymbols, maintenance_info_psymtabs)
 625         (maintenance_check_psymtabs): Use ranged for.
 626         * psymtab.h (class objfile_psymtabs): New.
 627         (require_partial_symbols): Return objfile_psymtabs.
 628         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 629
 630 2019-01-09  Tom Tromey  <tom@tromey.com>
 631
 632         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 633         (find_pc_mapped_section, list_overlays_command)
 634         (map_overlay_command, unmap_overlay_command)
 635         (simple_overlay_update): Use all_objfiles.
 636         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 637         * printcmd.c (info_symbol_command): Use all_objfiles.
 638         * objfiles.h (ALL_OBJSECTIONS): Remove.
 639         * maint.c (maintenance_translate_address): Use all_objfiles.
 640         * gcore.c (gcore_create_callback): Use all_objfiles.
 641         (objfile_find_memory_regions): Likewise.
 642
 643 2019-01-09  Tom Tromey  <tom@tromey.com>
 644
 645         * symtab.c (find_line_symtab, info_sources_command)
 646         (make_source_files_completion_list): Use objfile_compunits.
 647         * source.c (select_source_symtab): Use objfile_compunits.
 648         * objfiles.h (struct objfile): Update comment.
 649         (ALL_OBJFILES): Remove.
 650         (ALL_FILETABS): Remove.
 651         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 652         objfile_compunits.
 653
 654 2019-01-09  Tom Tromey  <tom@tromey.com>
 655
 656         * symmisc.c (print_objfile_statistics, dump_objfile)
 657         (maintenance_print_symbols): Use compunit_filetabs.
 658         * source.c (forget_cached_source_info_for_objfile): Use
 659         compunit_filetabs.
 660         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 661         (ALL_FILETABS): Use compunit_filetabs.
 662         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 663         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 664
 665 2019-01-09  Tom Tromey  <tom@tromey.com>
 666
 667         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 668         (compunit_filetabs): New.
 669         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 670         compunit_filetabs.
 671         (info_sources_command, make_source_files_completion_list): Remove
 672         declaration.
 673         * symmisc.c (print_objfile_statistics, dump_objfile)
 674         (maintenance_print_symbols): Remove declaration.
 675         (maintenance_info_symtabs): Use compunit_filetabs.
 676         (maintenance_info_line_tables): Likewise.
 677         * source.c (select_source_symtab): Change local variable name.
 678         (forget_cached_source_info_for_objfile): Remove declaration.
 679         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 680         * objfiles.c (objfile_relocate1): Remove declaration.
 681         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 682         declaration.
 683         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 684         * coffread.c (coff_symtab_read): Remove declaration.
 685         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 686         compunit_filetabs.
 687
 688 2019-01-09  Tom Tromey  <tom@tromey.com>
 689
 690         * symtab.c (lookup_objfile_from_block)
 691         (find_pc_sect_compunit_symtab, search_symbols)
 692         (default_collect_symbol_completion_matches_break_on): Use
 693         objfile_compunits.
 694         * objfiles.h (ALL_COMPUNITS): Remove.
 695         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 696         * cp-support.c (add_symbol_overload_list_qualified): Use
 697         objfile_compunits.
 698         * ada-lang.c (ada_collect_symbol_completion_matches)
 699         (ada_add_global_exceptions): Use objfile_compunits.
 700
 701 2019-01-09  Tom Tromey  <tom@tromey.com>
 702
 703         * source.c (select_source_symtab)
 704         (forget_cached_source_info_for_objfile): Remove declaration.
 705         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 706         declaration.
 707         * maint.c (count_symtabs_and_blocks): Remove declaration.
 708         * cp-support.c (add_symbol_overload_list_qualified): Remove
 709         declaration.
 710         * coffread.c (coff_symtab_read): Remove declaration.
 711         * symtab.c (lookup_symbol_in_objfile_symtabs)
 712         (basic_lookup_transparent_type_1): Use objfile_compunits.
 713         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 714         (info_sources_command, search_symbols)
 715         (default_collect_symbol_completion_matches_break_on)
 716         (make_source_files_completion_list): Remove declaration.
 717         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 718         (ada_collect_symbol_completion_matches)
 719         (ada_add_global_exceptions): Remove declaration.
 720         * linespec.c (iterate_over_all_matching_symtabs): Use
 721         objfile_compunits.
 722         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 723         (class objfile_compunits): New.
 724         (ALL_COMPUNITS): Use objfile_compunits.
 725         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 726         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 727         objfile_compunits.
 728         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 729
 730 2019-01-09  Tom Tromey  <tom@tromey.com>
 731
 732         * symtab.c (search_symbols)
 733         (default_collect_symbol_completion_matches_break_on): Use
 734         objfile_msymbols.
 735         * ada-lang.c (ada_lookup_simple_minsym)
 736         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 737         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 738         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 739         objfile_msymbols.
 740         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 741         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 742         * objc-lang.c (find_methods): Use objfile_msymbols.
 743         (info_selectors_command, info_classes_command): Likewise.
 744         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 745         * objfiles.h (class objfile_msymbols): New.
 746         (ALL_OBJFILE_MSYMBOLS): Remove.
 747         (ALL_MSYMBOLS): Remove.
 748
 749 2019-01-09  Tom Tromey  <tom@tromey.com>
 750
 751         * common/next-iterator.h (next_adapter): Add Iterator template
 752         parameter.
 753         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 754         (class all_objfiles_safe): New.
 755         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 756         * objfiles.c (put_objfile_before): Update comment.
 757         (add_separate_debug_objfile): Likewise.
 758         (free_all_objfiles): Use all_objfiles_safe.
 759         (objfile_purge_solibs): Likewise.
 760
 761 2019-01-09  Tom Tromey  <tom@tromey.com>
 762
 763         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 764         (expand_symtab_containing_pc, lookup_static_symbol)
 765         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 766         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 767         all_objfiles.
 768         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 769         * breakpoint.c (create_overlay_event_breakpoint)
 770         (create_longjmp_master_breakpoint)
 771         (create_std_terminate_master_breakpoint)
 772         (create_exception_master_breakpoint): Use all_objfiles.
 773         * linux-thread-db.c (try_thread_db_load_from_pdir)
 774         (has_libpthread): Use all_objfiles.
 775         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 776         * linespec.c (iterate_over_all_matching_symtabs)
 777         (search_minsyms_for_name): Use all_objfiles.
 778         * maint.c (maintenance_info_sections): Use all_objfiles.
 779         * main.c (captured_main_1): Use all_objfiles.
 780         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 781         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 782         * guile/scm-pretty-print.c
 783         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 784         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 785         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 786         (maintenance_print_msymbols): Use all_objfiles.
 787         * source.c (select_source_symtab): Use all_objfiles.
 788         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 789         * symfile.c (remove_symbol_file_command)
 790         (expand_symtabs_matching, map_symbol_filenames): Use
 791         all_objfiles.
 792         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 793         all_objfiles.
 794         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 795         * objc-lang.c (find_methods): Use all_objfiles.
 796         * objfiles.c (have_partial_symbols, have_full_symbols)
 797         (have_minimal_symbols, qsort_cmp)
 798         (default_iterate_over_objfiles_in_search_order): Use
 799         all_objfiles.
 800         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 801         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 802         (maintenance_check_psymtabs): Use all_objfiles.
 803         (ALL_PSYMTABS): Remove.
 804         * compile/compile-object-run.c (do_module_cleanup): Use
 805         all_objfiles.
 806         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 807         * cp-support.c (add_symbol_overload_list_qualified): Use
 808         all_objfiles.
 809         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 810         Use all_objfiles.
 811         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 812         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 813         all_objfiles.
 814         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 815         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 816         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 817         Uses all_objfiles.
 818         * solib.c (solib_read_symbols): Use all_objfiles
 819
 820 2019-01-09  Tom Tromey  <tom@tromey.com>
 821
 822         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 823         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 824         all_objfiles.
 825         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 826         * symmisc.c (print_symbol_bcache_statistics)
 827         (print_objfile_statistics, maintenance_print_objfiles)
 828         (maintenance_info_symtabs, maintenance_check_symtabs)
 829         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 830         all_objfiles.
 831         * source.c (forget_cached_source_info): Use all_objfiles.
 832         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 833         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 834         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 835         * objfiles.c (update_section_map): Use all_objfiles.
 836         (shared_objfile_contains_address_p): Likewise.
 837         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 838         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 839
 840 2019-01-09  Tom Tromey  <tom@tromey.com>
 841
 842         * common/next-iterator.h: New file.
 843         * objfiles.h (class all_objfiles): New.
 844         (struct objfile_iterator): New.
 845
 846 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 847
 848         * NEWS: Move the description of the changed "frame", "select-frame",
 849          and "info frame" commands to the Changed commands section.
 850
 851 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 852
 853         * gdbtypes.c (check_stub_method_group): Remove handling of old
 854         mangling schemes.
 855         * linespec.c (find_methods): Likewise.
 856         * stabsread.c (read_member_functions): Likewise.
 857         * valops.c (search_struct_method): Likewise.
 858         (value_struct_elt_for_reference): Likewise.
 859         * NEWS: Mention this change.
 860
 861 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 862
 863         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 864         print_source_lines.
 865         * source.c (print_source_lines_base): Update line number check.
 866         (print_source_lines): New function.
 867         (source_lines_range::source_lines_range): New function.
 868         * source.h (class source_lines_range): New class.
 869         (print_source_lines): New declaration.
 870
 871 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 872
 873         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 874
 875 2019-01-08  Tom Tromey  <tom@tromey.com>
 876             Simon Marchi  <simon.marchi@ericsson.com>
 877
 878         PR gdb/24060
 879         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 880         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 881         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 882         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 883         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 884         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 885
 886 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 887
 888         * source.c (select_source_symtab): Move header comment to
 889         declaration in source.h.
 890         (forget_cached_source_info_for_objfile): Likewise.
 891         (forget_cached_source_info): Likewise.
 892         (identify_source_line): Likewise.
 893         * source.h (identify_source_line): Move declaration from symtab.h
 894         and add comment from source.c
 895         (print_source_lines): Likewise.
 896         (forget_cached_source_info_for_objfile): Likewise.
 897         (forget_cached_source_info): Likewise.
 898         (select_source_symtab): Likewise.
 899         (enum print_source_lines_flag): Move definition from symtab.h.
 900         * symtab.h (identify_source_line): Move declaration to source.h.
 901         (print_source_lines): Likewise.
 902         (forget_cached_source_info_for_objfile): Likewise.
 903         (forget_cached_source_info): Likewise.
 904         (select_source_symtab): Likewise.
 905         (enum print_source_lines_flag): Move definition to source.h.
 906         * tui/tui-hooks.c: Add 'source.h' include.
 907
 908 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         * source.c (print_source_lines_base): Handle requests to print
 911         reverse line number sequences, and guard against empty lines
 912         string.
 913
 914 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 915
 916         * source.c (print_source_lines_base): Fix skip of '\r' if next
 917         character is '\n'.
 918
 919 2019-01-06  Tom Tromey  <tom@tromey.com>
 920
 921         * c-exp.y (struct c_parse_state) <macro_original_text,
 922         expansion_obstack>: New member.
 923         (macro_original_text, expansion_obstack): Remove globals.
 924         (scan_macro_expansion, scanning_macro_expansion)
 925         (finished_macro_expansion): Update.
 926         (scan_macro_cleanup): Remove.
 927         (yylex, c_parse): Update.
 928
 929 2019-01-06  Tom Tromey  <tom@tromey.com>
 930
 931         * c-exp.y (struct c_parse_state) <strings>: New member.
 932         (operator_stoken): Update.
 933
 934 2019-01-06  Tom Tromey  <tom@tromey.com>
 935
 936         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 937         (union type_stack_elt) <typelist_val>: Now a pointer to
 938         std::vector.
 939         (type_stack_cleanup): Don't declare.
 940         (push_typelist): Update.
 941         * parse.c (pop_typelist): Return a std::vector.
 942         (push_typelist): Take a std::vector.
 943         (follow_types): Update.  Do not free args.
 944         (type_stack_cleanup): Remove.
 945         * c-exp.y (struct c_parse_state): New.
 946         (cpstate): New global.
 947         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 948         (nonempty_typelist): Update.
 949         (func_mod): Create a new vector.
 950         (c_parse): Create a c_parse_state.
 951         (check_parameter_typelist): Do not delete params.
 952         (function_method): Update.  Do not delete type_list.
 953
 954 2019-01-06  Tom Tromey  <tom@tromey.com>
 955
 956         PR gdb/28155:
 957         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 958         check_typedef.
 959         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 960         (print_return_value): Likewise.
 961
 962 2019-01-05  Tom Tromey  <tom@tromey.com>
 963
 964         * contrib/cleanup_check.py: Remove.
 965         * contrib/gcc-with-excheck: Remove.
 966         * contrib/exsummary.py: Remove.
 967         * contrib/excheck.py: Remove.
 968
 969 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 970
 971         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 972         NULL. Initialize tpprev to NULL instead of assigning it
 973         to NULL on the next statement.
 974         * windows-nat.c (windows_delete_thread): Remove check for
 975         main_thread_id before printing thread exit notifications.
 976         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 977         Remove thread ID check against main_thread_id.
 978         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 979         windows_delete_thread.
 980         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 981
 982 2019-01-04  Tom Tromey  <tom@tromey.com>
 983
 984         * compile/compile.c (_initialize_compile): Use upper case for
 985         metasyntactic variables.
 986         * symmisc.c (_initialize_symmisc): Use upper case for
 987         metasyntactic variables.
 988         * psymtab.c (_initialize_psymtab): Use upper case for
 989         metasyntactic variables.
 990         * demangle.c (demangle_command): Use upper case for metasyntactic
 991         variables.
 992         (_initialize_demangler): Likewise.
 993         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 994         variables.
 995
 996 2019-01-03  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 999
1000 2019-01-03  Tom Tromey  <tom@tromey.com>
1001
1002         * python/py-symtab.c (salpy_str): Update.
1003         (struct salpy_sal_object) <symtab>: Now a PyObject.
1004         (salpy_dealloc): Update.
1005         (del_objfile_sal): Use gdbpy_ref.
1006
1007 2019-01-03  Tom Tromey  <tom@tromey.com>
1008
1009         * python/py-type.c (convert_field): Use new_reference.  Return
1010         gdbpy_ref.
1011         (make_fielditem): Return gdbpy_ref.
1012         (typy_fields): Update.
1013         (typy_getitem): Update.
1014         (field_name): Return gdbpy_ref.  Use new_reference.
1015         (typy_iterator_iternext): Update.
1016
1017 2019-01-03  Tom Tromey  <tom@tromey.com>
1018
1019         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1020
1021 2019-01-03  Tom Tromey  <tom@tromey.com>
1022
1023         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1024         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1025         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1026         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1027         (pspy_set_type_printers): Likewise.
1028         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1029         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1030         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1031         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1032         (objfpy_set_type_printers): Likewise.
1033
1034 2019-01-03  Tom Tromey  <tom@tromey.com>
1035
1036         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1037         (gdbpy_print_stack): Use gdbpy_err_fetch.
1038         * python/python-internal.h (class gdbpy_err_fetch): New class.
1039         (class gdbpy_enter) <m_error_type, m_error_value,
1040         m_error_traceback>: Remove.
1041         <m_error>: New member.
1042         (gdbpy_exception_to_string): Don't declare.
1043         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1044         * python/py-value.c (convert_value_from_python): Use
1045         gdbpy_err_fetch.
1046         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1047         gdbpy_exception_to_string.
1048         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1049         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1050         gdbpy_err_fetch.
1051
1052 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1053
1054         * linux-nat.c (delete_lwp_cleanup): Delete.
1055         (struct lwp_deleter): New struct.
1056         (lwp_info_up): New typedef.
1057         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1058         lwp_info_up.
1059
1060 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1061
1062         * linux-fork.c (class scoped_switch_fork_info): New class.
1063         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1064
1065 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1066
1067         * valops.c (find_overload_match): Remove use of null_cleanup, and
1068         calls to do_cleanups.
1069
1070 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * compile/compile-cplus-types.c
1073         (compile_cplus_instance::decl_name): Handle changes to
1074         cp_func_name.
1075         * cp-support.c (cp_func_name): Update header comment, update
1076         return type.
1077         * cp-support.h (cp_func_name): Update return type in declaration.
1078         * valops.c (find_overload_match): Move temp_func local to top
1079         level of function and change its type.  Use temp_func to hold and
1080         delete temporary string obtained from cp_func_name.
1081
1082 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1083
1084         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1085         gdb::char_vector, remove cleanup, and update uses of `msg`.
1086
1087 2019-01-03  Jim Wilson  <jimw@sifive.com>
1088
1089         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1090
1091 2019-01-02  Tom Tromey  <tom@tromey.com>
1092
1093         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1094         (tdesc_parse_xml): Remove cleanups.
1095         * target-descriptions.h (make_cleanup_free_target_description):
1096         Don't declare.
1097         (target_desc_deleter): New struct.
1098         (target_desc_up): New typedef.
1099         * target-descriptions.c (target_desc_deleter::operator()): Rename
1100         from free_target_description.
1101         (make_cleanup_free_target_description): Remove.
1102
1103 2019-01-02  Tom Tromey  <tom@tromey.com>
1104
1105         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1106         constructor, destructor.
1107         (linespec_parser): Remove typedef.
1108         (~linespec_parser): Rename from linespec_parser_delete.
1109         (linespec_lex_to_end, linespec_complete_label)
1110         (linespec_complete): Update.
1111         (decode_line_full): Remove cleanups.
1112         (decode_line_1): Update.
1113
1114 2019-01-02  Tom Tromey  <tom@tromey.com>
1115
1116         * python/python-internal.h (inferior_to_inferior_object): Change
1117         return type.
1118         * python/py-exitedevent.c (create_exited_event_object): Update.
1119         * python/py-inferior.c (inferior_to_inferior_object): Return
1120         gdbpy_ref.
1121         (python_new_inferior, python_inferior_deleted)
1122         (thread_to_thread_object, delete_thread_object)
1123         (build_inferior_list, gdbpy_selected_inferior): Update.
1124         * python/py-infthread.c (create_thread_object): Update.  Also fail
1125         if inferior_to_inferior_object fails.
1126
1127 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1128
1129         * inferior.h (class inferior) <displaced_step_state>: New field.
1130         * infrun.h (struct displaced_step_state): Move here from
1131         infrun.c.  Initialize fields, add constructor.
1132         <inf>: Remove field.
1133         <reset>: New method.
1134         * infrun.c (struct displaced_step_inferior_state): Move to
1135         infrun.h.
1136         (displaced_step_inferior_states): Remove.
1137         (get_displaced_stepping_state): Adust.
1138         (displaced_step_in_progress_any_inferior): Adjust.
1139         (displaced_step_in_progress_thread): Adjust.
1140         (displaced_step_in_progress): Adjust.
1141         (add_displaced_stepping_state): Remove.
1142         (get_displaced_step_closure_by_addr): Adjust.
1143         (remove_displaced_stepping_state): Remove.
1144         (infrun_inferior_exit): Call displaced_step_state.reset.
1145         (use_displaced_stepping): Don't check for NULL.
1146         (displaced_step_prepare_throw): Call
1147         get_displaced_stepping_state.
1148         (displaced_step_fixup): Don't check for NULL.
1149         (prepare_for_detach): Don't check for NULL.
1150
1151 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1152
1153         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1154          in case of call that did not complete.
1155
1156 2019-01-02  Andrey Utkin  <autkin@undo.io>
1157
1158         * symfile.c (find_separate_debug_file): Fix search of debug files for
1159         remote debuggee.
1160
1161 2019-01-02  Tom Tromey  <tom@tromey.com>
1162
1163         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1164         indentation.
1165         * python/py-frame.c (frapy_older): Remove cast.
1166         (frapy_newer): Likewise.
1167         * python/py-breakpoint.c (local_setattro): Remove cast.
1168         * python/py-arch.c (archpy_name): Remove local variable.
1169         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1170
1171 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1172
1173         * unittests/basic_string_view/element_access/char/empty.cc:
1174         Fix year range in copyright header.
1175
1176 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1177
1178         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1179         Delete.
1180         <operator==>: Update with for removed field.
1181         <hash>: Likewise.
1182         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1183         <isa_features>: ...this.
1184         <abi_features>: New field.
1185         (riscv_isa_flen): Update comment.
1186         (riscv_abi_xlen): New declaration.
1187         (riscv_abi_flen): New declaration.
1188         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1189         isa_features.
1190         (riscv_abi_xlen): New function.
1191         (riscv_isa_flen): Update to get answer from isa_features.
1192         (riscv_abi_flen): New function.
1193         (riscv_has_fp_abi): Update to get answer from abi_features.
1194         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1195         xlen and flen.
1196         (riscv_call_info) <xlen, flen>: Update comment.
1197         (riscv_call_arg_struct): Remove invalid assertions
1198         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1199         is removed.
1200         (riscv_gdbarch_init): Gather isa features and abi features
1201         separately, ensure both match on the gdbarch when reusing an old
1202         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1203         a target with 64-bit float hardware.
1204
1205 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1206
1207         * source.c (search_command_helper): Stop reverse search
1208         when line 1 has been searched.
1209
1210 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1211
1212         * record-full.c (record_full_base_target::close): Rewrite
1213         record_full_core_buf_list free logic.
1214
1215 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1216
1217         * break-catch-syscall.c (print_one_catch_syscall): xfree
1218         the last text.
1219
1220 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1221
1222         * top.c (print_gdb_version): Update Copyright year in version
1223         message.
1224
1225 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1226
1227         Update copyright year range in all GDB files.
1228
1229 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1230
1231         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1232
1233 For older changes see ChangeLog-2018.
1234 \f
1235 Local Variables:
1236 mode: change-log
1237 left-margin: 8
1238 fill-column: 74
1239 version-control: never
1240 coding: utf-8
1241 End:
1242