OBVIOUS move add_comm_alias "!" <=> "shell" near the add_com "shell"
[external/binutils.git] / gdb / ChangeLog
1 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2
3         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4         close to the add_com "shell".
5
6 2019-04-18  Tom Tromey  <tromey@adacore.com>
7
8         * process-stratum-target.h (class process_stratum_target)
9         <stratum>: Add "final".
10
11 2019-04-17  Tom Tromey  <tromey@adacore.com>
12
13         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
14         against nullptr before use.
15
16 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
17
18         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
19
20 2019-04-17  Jim Wilson  <jimw@sifive.com>
21             Andrew Burgess  <andrew.burgess@embecosm.com>
22
23         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
24         code read might fail, assume 4-byte breakpoint in that case.
25
26 2019-04-15  Leszek Swirski  <leszeks@google.com>
27
28         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
29         rather than a hand-rolled POD check when checking for forced MEMORY
30         classification.
31
32 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
33
34         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
35         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
36         function.
37         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
38         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
39         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
40         declaration.
41
42 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
43
44         * aarch64-linux-nat.c
45         (aarch64_linux_nat_target::thread_architecture): Add override.
46         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
47         each VQ.
48
49 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
50
51         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
52
53 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
54
55         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
56         target types of size 96-bits, add some additional comments, and
57         check that the builtin type we found was the correct size.
58
59 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
60
61         * utils.c (prompt_for_continue): Don't restore the styling at the
62         end, as applied_style has the wrong value.  This fixes styling in
63         long lists of file names that are interrupted by the "Continue?"
64         prompt.
65
66 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
67
68         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
69         * c-lang.c (c_language_defn): Likewise.
70         (cplus_language_defn): Likewise.
71         (asm_language_defn): Likewise.
72         (minimal_language_defn): Likewise.
73         * d-lang.c (d_language_defn): Likewise.
74         * f-lang.c (f_language_defn): Likewise.
75         * go-lang.c (go_language_defn): Likewise.
76         * language.c (unknown_language_defn): Likewise.
77         (auto_language_defn): Likewise.
78         * language.h (struct language_defn): Remove la_magic field.
79         (LANG_MAGIC): Delete.
80         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
81         * objc-lang.c (objc_language_defn): Likewise.
82         * opencl-lang.c (opencl_language_defn): Likewise.
83         * p-lang.c (pascal_language_defn): Likewise.
84         * rust-lang.c (rust_language_defn): Likewise.
85
86 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
87
88         * riscv-tdep.c (riscv_type_align): New function.
89         (riscv_type_alignment): Delete.
90         (riscv_arg_location): Use 'type_align'.
91         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
92
93 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
94
95         * gdbtypes.c (type_align): A struct with no non-static fields also
96         has alignment of 1.
97
98 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
99
100         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
101         component to 0.
102         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
103         member.
104         (riscv_struct_info::analyse): New implementation using new
105         analyse_inner member function.
106         (riscv_struct_info::field_offset): New member function.
107         (riscv_struct_info::m_offsets): New member variable.
108         (riscv_struct_info::analyse_inner): New private member function,
109         takes the old implementation of riscv_struct_info::analyse but
110         extended to track field offsets.
111         (riscv_call_arg_struct): Update the struct folding special cases
112         to handle cases where empty C++ structs, which are non-zero
113         length, are found.
114         (riscv_arg_location): Initialise the length of each location, a
115         non-zero length now indicates the location is in use.
116         (riscv_push_dummy_call): Allow for the first location having a
117         non-zero offset when setting up arguments.
118         (riscv_return_value): Likewise, but for return values.
119
120 2019-04-11  Tom Tromey  <tromey@adacore.com>
121
122         * utils.c (internal_vproblem): Make "msg" const.
123
124 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
125
126         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
127         * trad-frame.c (trad_frame_reset_saved_regs): New function.
128         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
129         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
130
131 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
132
133         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
134         function.
135         (fill_gregset): Call amd64_linux_collect_native_gregset instead
136         of amd64_collect_native_gregset.
137         (amd64_linux_nat_target::store_registers): Likewise.
138
139 2019-04-10  Tom Tromey  <tom@tromey.com>
140
141         * symtab.c (lookup_global_symbol_from_objfile)
142         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
143         * objfiles.h (class separate_debug_iterator): New.
144         (class separate_debug_range): New.
145         (struct objfile) <separate_debug_objfiles>: New method.
146         (objfile_separate_debug_iterate): Don't declare.
147         * objfiles.c (separate_debug_iterator::operator++): Rename from
148         objfile_separate_debug_iterate.
149         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
150         iterator.
151         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
152         iterator.
153
154 2019-04-10  Tom Tromey  <tom@tromey.com>
155
156         * symfile.c (reread_symbols): Remove old comment.
157         * objfiles.c (free_all_objfiles): Fix a typo.
158
159 2019-04-10  Tom Tromey  <tom@tromey.com>
160
161         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
162         * minsyms.c (lookup_minimal_symbol): Use foreach.
163         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
164         (lookup_minimal_symbol_solib_trampoline): Likewise.
165         * symfile.c (reread_symbols): Use foreach.
166
167 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
168             Tom Tromey  <tromey@adacore.com>
169
170         PR rust/24414:
171         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
172         (rust_lex_int_test): Change "value" to be LONGEST.
173         (rust_lex_tests): Add test for long integer literal.
174
175 2019-04-09  Tom Tromey  <tromey@adacore.com>
176
177         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
178         to bool.
179         (extended_remote_target::attach): Update.
180         (remote_target::remote_notice_new_inferior): Update.
181         (remote_target::add_current_inferior_and_thread): Update.
182         * inferior.c (exit_inferior_1): Use "false".
183         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
184
185 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
186
187         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
188         the "start" command.
189
190 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
191
192         * python/py-inferior.c (infpy_thread_from_thread_handle):
193         Adjust comments to reflect renaming of thread_from_thread_handle
194         to thread_from_handle.  Adjust keywords.  Fix type error message.
195         (inferior_object_methods): Add thread_from_handle.  Retain
196         thread_from_thread_handle, but mark it as deprecated.
197
198 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
199
200         * gdbthread.h (find_thread_by_handle): Revise declaration.
201         * thread.c (find_thread_by_handle): Likewise.  Adjust
202         implementation too.
203         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
204         support for buffer objects as handles.
205
206 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
207
208         * python/py-infthread.c (thpy_thread_handle): New function.
209         (thread_object_methods): Register thpy_thread_handle.
210
211 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
212
213         * gdbthread.h (thread_to_thread_handle): Declare.
214         * thread.c (gdbtypes.h): Include.
215         (thread_to_thread_handle): New function.
216
217         * target.h (struct target_ops): Add thread_info_to_thread_handle.
218         (target_thread_info_to_thread_handle): Declare.
219         * target.c (target_thread_info_to_thread_handle): New function.
220         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
221         * target-delegates.c: Regenerate.
222
223         * linux-thread-db.c (class thread_db_target): Add method
224         thread_info_to_thread_handle.
225         (thread_db_target::thread_info_to_thread_handle): Define.
226         * remote.c (class remote_target): Add new method
227         thread_info_to_thread_handle.
228         (remote_target::thread_info_to_thread_handle): Define.
229
230 2019-04-08  Pedro Alves  <palves@redhat.com>
231
232         * common/common-exceptions.c (throw_exception): Don't create
233         named object to throw; throw directly.
234         (throw_it): Likewise.  Don't initialize gdb_exception::message
235         here, with new; pass FMT and AP to the ctor instead.
236         * common/common-exceptions.h: Include <string>.
237         (gdb_exception::gdb_exception(enum return_reason, enum errors,
238         const char *, va_list)): New ctor.  Use std::make_shared.
239         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
240         errors)): Delete.
241         (gdb_exception_error::gdb_exception_error(enum errors, const char
242         *, va_list)): New.
243         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
244         Add assertion.
245         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
246         errors)): Delete.
247         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
248         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
249         Add assertion.
250
251 2019-04-08  Tom Tromey  <tom@tromey.com>
252
253         * valops.c (value_rtti_indirect_type): Replace throw_exception
254         with throw.
255         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
256         with throw.
257         * thread.c (thr_try_catch_cmd): Replace throw_exception with
258         throw.
259         * target.c (target_translate_tls_address): Replace throw_exception
260         with throw.
261         * stack.c (frame_apply_command_count): Replace throw_exception
262         with throw.
263         * solib-spu.c (append_ocl_sos): Replace throw_exception with
264         throw.
265         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
266         with throw.
267         * rs6000-tdep.c (rs6000_frame_cache)
268         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
269         * remote.c: Replace throw_exception with throw.
270         * record-full.c (record_full_message, record_full_wait_1)
271         (record_full_restore): Replace throw_exception with throw.
272         * record-btrace.c:
273         (get_thread_current_frame_id, record_btrace_start_replaying)
274         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
275         (cmd_record_btrace_start): Replace throw_exception with throw.
276         * parse.c (parse_exp_in_context_1): Replace throw_exception with
277         throw.
278         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
279         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
280         * linespec.c:
281         (find_linespec_symbols): Replace throw_exception with throw.
282         * infrun.c (displaced_step_prepare, resume): Replace
283         throw_exception with throw.
284         * infcmd.c (post_create_inferior): Replace throw_exception with
285         throw.
286         * inf-loop.c (inferior_event_handler): Replace throw_exception
287         with throw.
288         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
289         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
290         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
291         (get_prev_frame_always, get_frame_pc_if_available)
292         (get_frame_address_in_block_if_available, get_frame_language):
293         Replace throw_exception with throw.
294         * frame-unwind.c (frame_unwind_try_unwinder): Replace
295         throw_exception with throw.
296         * eval.c (fetch_subexp_value, evaluate_var_value)
297         (evaluate_funcall, evaluate_subexp_standard): Replace
298         throw_exception with throw.
299         * dwarf2loc.c (call_site_find_chain)
300         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
301         Replace throw_exception with throw.
302         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
303         with throw.
304         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
305         throw.
306         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
307         * completer.c (complete_line_internal): Replace throw_exception
308         with throw.
309         * compile/compile-object-run.c (compile_object_run): Replace
310         throw_exception with throw.
311         * cli/cli-script.c (process_next_line): Replace throw_exception
312         with throw.
313         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
314         (btrace_enable, btrace_maint_update_pt_packets): Replace
315         throw_exception with throw.
316         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
317         throw_exception with throw.
318         * break-catch-throw.c (re_set_exception_catchpoint): Replace
319         throw_exception with throw.
320         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
321         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
322         * aarch64-tdep.c (aarch64_make_prologue_cache)
323         (aarch64_make_stub_cache): Replace throw_exception with throw.
324
325 2019-04-08  Tom Tromey  <tom@tromey.com>
326
327         * common/common-exceptions.c (throw_exception): Rename from
328         throw_exception_cxx.  Remove old copy.  Make argument const.
329         (throw_it): Create and throw exception objects directly.
330         * common/common-exceptions.h (throw_exception): Make argument
331         const.
332         (struct gdb_exception_error): Add constructor.
333         (struct gdb_exception_quit): Add constructor.
334
335 2019-04-08  Tom Tromey  <tom@tromey.com>
336
337         * common/common-exceptions.h (exception_rethrow): Don't declare.
338         (TRY_SJLJ): Update comment.
339         (TRY, CATCH, END_CATCH): Remove.
340         * common/common-exceptions.c (exception_rethrow): Remove.
341
342 2019-04-08  Tom Tromey  <tom@tromey.com>
343
344         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
345         Remove.
346         (gdb_exception_error): Rename from
347         gdb_exception_RETURN_MASK_ERROR.
348         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
349         (gdb_quit_bad_alloc): Update.
350         * aarch64-tdep.c: Update.
351         * ada-lang.c: Update.
352         * ada-typeprint.c: Update.
353         * ada-valprint.c: Update.
354         * amd64-tdep.c: Update.
355         * arch-utils.c: Update.
356         * break-catch-throw.c: Update.
357         * breakpoint.c: Update.
358         * btrace.c: Update.
359         * c-varobj.c: Update.
360         * cli/cli-cmds.c: Update.
361         * cli/cli-interp.c: Update.
362         * cli/cli-script.c: Update.
363         * common/common-exceptions.c: Update.
364         * common/new-op.c: Update.
365         * common/selftest.c: Update.
366         * compile/compile-c-symbols.c: Update.
367         * compile/compile-cplus-symbols.c: Update.
368         * compile/compile-object-load.c: Update.
369         * compile/compile-object-run.c: Update.
370         * completer.c: Update.
371         * corelow.c: Update.
372         * cp-abi.c: Update.
373         * cp-support.c: Update.
374         * cp-valprint.c: Update.
375         * darwin-nat.c: Update.
376         * disasm-selftests.c: Update.
377         * dtrace-probe.c: Update.
378         * dwarf-index-cache.c: Update.
379         * dwarf-index-write.c: Update.
380         * dwarf2-frame-tailcall.c: Update.
381         * dwarf2-frame.c: Update.
382         * dwarf2loc.c: Update.
383         * dwarf2read.c: Update.
384         * eval.c: Update.
385         * event-loop.c: Update.
386         * event-top.c: Update.
387         * exec.c: Update.
388         * f-valprint.c: Update.
389         * fbsd-tdep.c: Update.
390         * frame-unwind.c: Update.
391         * frame.c: Update.
392         * gdbtypes.c: Update.
393         * gnu-v3-abi.c: Update.
394         * guile/guile-internal.h: Update.
395         * guile/scm-block.c: Update.
396         * guile/scm-breakpoint.c: Update.
397         * guile/scm-cmd.c: Update.
398         * guile/scm-disasm.c: Update.
399         * guile/scm-frame.c: Update.
400         * guile/scm-lazy-string.c: Update.
401         * guile/scm-math.c: Update.
402         * guile/scm-param.c: Update.
403         * guile/scm-ports.c: Update.
404         * guile/scm-pretty-print.c: Update.
405         * guile/scm-symbol.c: Update.
406         * guile/scm-symtab.c: Update.
407         * guile/scm-type.c: Update.
408         * guile/scm-value.c: Update.
409         * i386-linux-tdep.c: Update.
410         * i386-tdep.c: Update.
411         * inf-loop.c: Update.
412         * infcall.c: Update.
413         * infcmd.c: Update.
414         * infrun.c: Update.
415         * jit.c: Update.
416         * language.c: Update.
417         * linespec.c: Update.
418         * linux-fork.c: Update.
419         * linux-nat.c: Update.
420         * linux-tdep.c: Update.
421         * linux-thread-db.c: Update.
422         * main.c: Update.
423         * mi/mi-cmd-break.c: Update.
424         * mi/mi-cmd-stack.c: Update.
425         * mi/mi-interp.c: Update.
426         * mi/mi-main.c: Update.
427         * objc-lang.c: Update.
428         * p-valprint.c: Update.
429         * parse.c: Update.
430         * ppc-linux-tdep.c: Update.
431         * printcmd.c: Update.
432         * python/py-arch.c: Update.
433         * python/py-breakpoint.c: Update.
434         * python/py-cmd.c: Update.
435         * python/py-finishbreakpoint.c: Update.
436         * python/py-frame.c: Update.
437         * python/py-framefilter.c: Update.
438         * python/py-gdb-readline.c: Update.
439         * python/py-inferior.c: Update.
440         * python/py-infthread.c: Update.
441         * python/py-lazy-string.c: Update.
442         * python/py-linetable.c: Update.
443         * python/py-objfile.c: Update.
444         * python/py-param.c: Update.
445         * python/py-prettyprint.c: Update.
446         * python/py-progspace.c: Update.
447         * python/py-record-btrace.c: Update.
448         * python/py-record.c: Update.
449         * python/py-symbol.c: Update.
450         * python/py-type.c: Update.
451         * python/py-unwind.c: Update.
452         * python/py-utils.c: Update.
453         * python/py-value.c: Update.
454         * python/python.c: Update.
455         * record-btrace.c: Update.
456         * record-full.c: Update.
457         * remote-fileio.c: Update.
458         * remote.c: Update.
459         * riscv-tdep.c: Update.
460         * rs6000-aix-tdep.c: Update.
461         * rs6000-tdep.c: Update.
462         * rust-exp.y: Update.
463         * rust-lang.c: Update.
464         * s390-tdep.c: Update.
465         * selftest-arch.c: Update.
466         * solib-dsbt.c: Update.
467         * solib-frv.c: Update.
468         * solib-spu.c: Update.
469         * solib-svr4.c: Update.
470         * solib.c: Update.
471         * sparc64-linux-tdep.c: Update.
472         * stack.c: Update.
473         * symfile-mem.c: Update.
474         * symmisc.c: Update.
475         * target.c: Update.
476         * thread.c: Update.
477         * top.c: Update.
478         * tracefile-tfile.c: Update.
479         * tui/tui.c: Update.
480         * typeprint.c: Update.
481         * unittests/cli-utils-selftests.c: Update.
482         * unittests/parse-connection-spec-selftests.c: Update.
483         * valops.c: Update.
484         * valprint.c: Update.
485         * value.c: Update.
486         * varobj.c: Update.
487         * windows-nat.c: Update.
488         * x86-linux-nat.c: Update.
489         * xml-support.c: Update.
490
491 2019-04-08  Tom Tromey  <tom@tromey.com>
492
493         * xml-support.c: Use C++ exception handling.
494         * x86-linux-nat.c: Use C++ exception handling.
495         * windows-nat.c: Use C++ exception handling.
496         * varobj.c: Use C++ exception handling.
497         * value.c: Use C++ exception handling.
498         * valprint.c: Use C++ exception handling.
499         * valops.c: Use C++ exception handling.
500         * unittests/parse-connection-spec-selftests.c: Use C++ exception
501         handling.
502         * unittests/cli-utils-selftests.c: Use C++ exception handling.
503         * typeprint.c: Use C++ exception handling.
504         * tui/tui.c: Use C++ exception handling.
505         * tracefile-tfile.c: Use C++ exception handling.
506         * top.c: Use C++ exception handling.
507         * thread.c: Use C++ exception handling.
508         * target.c: Use C++ exception handling.
509         * symmisc.c: Use C++ exception handling.
510         * symfile-mem.c: Use C++ exception handling.
511         * stack.c: Use C++ exception handling.
512         * sparc64-linux-tdep.c: Use C++ exception handling.
513         * solib.c: Use C++ exception handling.
514         * solib-svr4.c: Use C++ exception handling.
515         * solib-spu.c: Use C++ exception handling.
516         * solib-frv.c: Use C++ exception handling.
517         * solib-dsbt.c: Use C++ exception handling.
518         * selftest-arch.c: Use C++ exception handling.
519         * s390-tdep.c: Use C++ exception handling.
520         * rust-lang.c: Use C++ exception handling.
521         * rust-exp.y: Use C++ exception handling.
522         * rs6000-tdep.c: Use C++ exception handling.
523         * rs6000-aix-tdep.c: Use C++ exception handling.
524         * riscv-tdep.c: Use C++ exception handling.
525         * remote.c: Use C++ exception handling.
526         * remote-fileio.c: Use C++ exception handling.
527         * record-full.c: Use C++ exception handling.
528         * record-btrace.c: Use C++ exception handling.
529         * python/python.c: Use C++ exception handling.
530         * python/py-value.c: Use C++ exception handling.
531         * python/py-utils.c: Use C++ exception handling.
532         * python/py-unwind.c: Use C++ exception handling.
533         * python/py-type.c: Use C++ exception handling.
534         * python/py-symbol.c: Use C++ exception handling.
535         * python/py-record.c: Use C++ exception handling.
536         * python/py-record-btrace.c: Use C++ exception handling.
537         * python/py-progspace.c: Use C++ exception handling.
538         * python/py-prettyprint.c: Use C++ exception handling.
539         * python/py-param.c: Use C++ exception handling.
540         * python/py-objfile.c: Use C++ exception handling.
541         * python/py-linetable.c: Use C++ exception handling.
542         * python/py-lazy-string.c: Use C++ exception handling.
543         * python/py-infthread.c: Use C++ exception handling.
544         * python/py-inferior.c: Use C++ exception handling.
545         * python/py-gdb-readline.c: Use C++ exception handling.
546         * python/py-framefilter.c: Use C++ exception handling.
547         * python/py-frame.c: Use C++ exception handling.
548         * python/py-finishbreakpoint.c: Use C++ exception handling.
549         * python/py-cmd.c: Use C++ exception handling.
550         * python/py-breakpoint.c: Use C++ exception handling.
551         * python/py-arch.c: Use C++ exception handling.
552         * printcmd.c: Use C++ exception handling.
553         * ppc-linux-tdep.c: Use C++ exception handling.
554         * parse.c: Use C++ exception handling.
555         * p-valprint.c: Use C++ exception handling.
556         * objc-lang.c: Use C++ exception handling.
557         * mi/mi-main.c: Use C++ exception handling.
558         * mi/mi-interp.c: Use C++ exception handling.
559         * mi/mi-cmd-stack.c: Use C++ exception handling.
560         * mi/mi-cmd-break.c: Use C++ exception handling.
561         * main.c: Use C++ exception handling.
562         * linux-thread-db.c: Use C++ exception handling.
563         * linux-tdep.c: Use C++ exception handling.
564         * linux-nat.c: Use C++ exception handling.
565         * linux-fork.c: Use C++ exception handling.
566         * linespec.c: Use C++ exception handling.
567         * language.c: Use C++ exception handling.
568         * jit.c: Use C++ exception handling.
569         * infrun.c: Use C++ exception handling.
570         * infcmd.c: Use C++ exception handling.
571         * infcall.c: Use C++ exception handling.
572         * inf-loop.c: Use C++ exception handling.
573         * i386-tdep.c: Use C++ exception handling.
574         * i386-linux-tdep.c: Use C++ exception handling.
575         * guile/scm-value.c: Use C++ exception handling.
576         * guile/scm-type.c: Use C++ exception handling.
577         * guile/scm-symtab.c: Use C++ exception handling.
578         * guile/scm-symbol.c: Use C++ exception handling.
579         * guile/scm-pretty-print.c: Use C++ exception handling.
580         * guile/scm-ports.c: Use C++ exception handling.
581         * guile/scm-param.c: Use C++ exception handling.
582         * guile/scm-math.c: Use C++ exception handling.
583         * guile/scm-lazy-string.c: Use C++ exception handling.
584         * guile/scm-frame.c: Use C++ exception handling.
585         * guile/scm-disasm.c: Use C++ exception handling.
586         * guile/scm-cmd.c: Use C++ exception handling.
587         * guile/scm-breakpoint.c: Use C++ exception handling.
588         * guile/scm-block.c: Use C++ exception handling.
589         * guile/guile-internal.h: Use C++ exception handling.
590         * gnu-v3-abi.c: Use C++ exception handling.
591         * gdbtypes.c: Use C++ exception handling.
592         * frame.c: Use C++ exception handling.
593         * frame-unwind.c: Use C++ exception handling.
594         * fbsd-tdep.c: Use C++ exception handling.
595         * f-valprint.c: Use C++ exception handling.
596         * exec.c: Use C++ exception handling.
597         * event-top.c: Use C++ exception handling.
598         * event-loop.c: Use C++ exception handling.
599         * eval.c: Use C++ exception handling.
600         * dwarf2read.c: Use C++ exception handling.
601         * dwarf2loc.c: Use C++ exception handling.
602         * dwarf2-frame.c: Use C++ exception handling.
603         * dwarf2-frame-tailcall.c: Use C++ exception handling.
604         * dwarf-index-write.c: Use C++ exception handling.
605         * dwarf-index-cache.c: Use C++ exception handling.
606         * dtrace-probe.c: Use C++ exception handling.
607         * disasm-selftests.c: Use C++ exception handling.
608         * darwin-nat.c: Use C++ exception handling.
609         * cp-valprint.c: Use C++ exception handling.
610         * cp-support.c: Use C++ exception handling.
611         * cp-abi.c: Use C++ exception handling.
612         * corelow.c: Use C++ exception handling.
613         * completer.c: Use C++ exception handling.
614         * compile/compile-object-run.c: Use C++ exception handling.
615         * compile/compile-object-load.c: Use C++ exception handling.
616         * compile/compile-cplus-symbols.c: Use C++ exception handling.
617         * compile/compile-c-symbols.c: Use C++ exception handling.
618         * common/selftest.c: Use C++ exception handling.
619         * common/new-op.c: Use C++ exception handling.
620         * cli/cli-script.c: Use C++ exception handling.
621         * cli/cli-interp.c: Use C++ exception handling.
622         * cli/cli-cmds.c: Use C++ exception handling.
623         * c-varobj.c: Use C++ exception handling.
624         * btrace.c: Use C++ exception handling.
625         * breakpoint.c: Use C++ exception handling.
626         * break-catch-throw.c: Use C++ exception handling.
627         * arch-utils.c: Use C++ exception handling.
628         * amd64-tdep.c: Use C++ exception handling.
629         * ada-valprint.c: Use C++ exception handling.
630         * ada-typeprint.c: Use C++ exception handling.
631         * ada-lang.c: Use C++ exception handling.
632         * aarch64-tdep.c: Use C++ exception handling.
633
634 2019-04-08  Tom Tromey  <tom@tromey.com>
635
636         * xml-support.c (gdb_xml_parser::parse): Update.
637         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
638         * value.c (show_convenience): Update.
639         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
640         (test_parse_flags_qcs): Update.
641         * thread.c (thr_try_catch_cmd): Update.
642         * target.c (target_translate_tls_address): Update.
643         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
644         (info_frame_command_core, frame_apply_command_count): Update.
645         * rust-exp.y (rust_lex_exception_test): Update.
646         * riscv-tdep.c (riscv_print_one_register_info): Update.
647         * remote.c (remote_target::enable_btrace): Update.
648         * record-btrace.c (record_btrace_enable_warn): Update.
649         * python/py-utils.c (gdbpy_convert_exception): Update.
650         * printcmd.c (do_one_display, print_variable_and_value): Update.
651         * mi/mi-main.c (mi_print_exception): Update.
652         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
653         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
654         * linux-nat.c (linux_nat_target::attach): Update.
655         * linux-fork.c (class scoped_switch_fork_info): Update.
656         * infrun.c (displaced_step_prepare): Update.
657         * infcall.c (call_function_by_hand_dummy): Update.
658         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
659         * gnu-v3-abi.c (print_one_vtable): Update.
660         * frame.c (get_prev_frame_always): Update.
661         * f-valprint.c (info_common_command_for_block): Update.
662         * exec.c (try_open_exec_file): Update.
663         * exceptions.c (print_exception, exception_print)
664         (exception_fprintf, exception_print_same): Update.
665         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
666         * dwarf-index-cache.c (index_cache::store)
667         (index_cache::lookup_gdb_index): Update.
668         * darwin-nat.c (maybe_cache_shell): Update.
669         * cp-valprint.c (cp_print_value_fields): Update.
670         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
671         (gcc_cplus_symbol_address): Update.
672         * compile/compile-c-symbols.c (gcc_convert_symbol)
673         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
674         * common/selftest.c: Update.
675         * common/common-exceptions.h (struct gdb_exception) <message>: Now
676         a std::string.
677         (exception_try_scope_entry, exception_try_scope_exit): Don't
678         declare.
679         (struct exception_try_scope): Remove.
680         (TRY): Don't use exception_try_scope.
681         (struct gdb_exception): Add constructor, operator=.
682         <what>: New method.
683         (struct gdb_exception_RETURN_MASK_ALL)
684         (struct gdb_exception_RETURN_MASK_ERROR)
685         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
686         (struct gdb_quit_bad_alloc): Update.
687         * common/common-exceptions.c (exception_none): Change
688         initializer.
689         (struct catcher) <state, exception>: Initialize inline.
690         <prev>: Remove member.
691         (current_catcher): Remove.
692         (catchers): New global.
693         (exceptions_state_mc_init): Simplify.
694         (catcher_pop): Remove.
695         (exceptions_state_mc, exceptions_state_mc_catch): Update.
696         (try_scope_depth, exception_try_scope_entry)
697         (exception_try_scope_exit): Remove.
698         (throw_exception_sjlj): Update.
699         (exception_messages, exception_messages_size): Remove.
700         (throw_it): Simplify.
701         (gdb_exception_sliced_copy): Remove.
702         (throw_exception_cxx): Update.
703         * cli/cli-script.c (script_from_file): Update.
704         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
705         Update.
706         * ada-valprint.c (ada_val_print): Update.
707         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
708         (create_excep_cond_exprs): Update.
709
710 2019-04-08  Tom Tromey  <tom@tromey.com>
711
712         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
713         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
714         (TRY, CATCH, END_CATCH): Remove some definitions.
715         * common/common-exceptions.c: Don't use GDB_XCPT.
716         (catcher_list_size): Remove.
717         (throw_exception, throw_it): Simplify.
718
719 2019-04-05  Tom Tromey  <tom@tromey.com>
720
721         Revert the header-sorting patch.
722         * ft32-tdep.c: Revert.
723         * frv-tdep.c: Revert.
724         * frv-linux-tdep.c: Revert.
725         * frame.c: Revert.
726         * frame-unwind.c: Revert.
727         * frame-base.c: Revert.
728         * fork-child.c: Revert.
729         * findvar.c: Revert.
730         * findcmd.c: Revert.
731         * filesystem.c: Revert.
732         * filename-seen-cache.h: Revert.
733         * filename-seen-cache.c: Revert.
734         * fbsd-tdep.c: Revert.
735         * fbsd-nat.h: Revert.
736         * fbsd-nat.c: Revert.
737         * f-valprint.c: Revert.
738         * f-typeprint.c: Revert.
739         * f-lang.c: Revert.
740         * extension.h: Revert.
741         * extension.c: Revert.
742         * extension-priv.h: Revert.
743         * expprint.c: Revert.
744         * exec.h: Revert.
745         * exec.c: Revert.
746         * exceptions.c: Revert.
747         * event-top.c: Revert.
748         * event-loop.c: Revert.
749         * eval.c: Revert.
750         * elfread.c: Revert.
751         * dwarf2read.h: Revert.
752         * dwarf2read.c: Revert.
753         * dwarf2loc.c: Revert.
754         * dwarf2expr.h: Revert.
755         * dwarf2expr.c: Revert.
756         * dwarf2-frame.c: Revert.
757         * dwarf2-frame-tailcall.c: Revert.
758         * dwarf-index-write.h: Revert.
759         * dwarf-index-write.c: Revert.
760         * dwarf-index-common.c: Revert.
761         * dwarf-index-cache.h: Revert.
762         * dwarf-index-cache.c: Revert.
763         * dummy-frame.c: Revert.
764         * dtrace-probe.c: Revert.
765         * disasm.h: Revert.
766         * disasm.c: Revert.
767         * disasm-selftests.c: Revert.
768         * dictionary.c: Revert.
769         * dicos-tdep.c: Revert.
770         * demangle.c: Revert.
771         * dcache.h: Revert.
772         * dcache.c: Revert.
773         * darwin-nat.h: Revert.
774         * darwin-nat.c: Revert.
775         * darwin-nat-info.c: Revert.
776         * d-valprint.c: Revert.
777         * d-namespace.c: Revert.
778         * d-lang.c: Revert.
779         * ctf.c: Revert.
780         * csky-tdep.c: Revert.
781         * csky-linux-tdep.c: Revert.
782         * cris-tdep.c: Revert.
783         * cris-linux-tdep.c: Revert.
784         * cp-valprint.c: Revert.
785         * cp-support.c: Revert.
786         * cp-namespace.c: Revert.
787         * cp-abi.c: Revert.
788         * corelow.c: Revert.
789         * corefile.c: Revert.
790         * continuations.c: Revert.
791         * completer.h: Revert.
792         * completer.c: Revert.
793         * complaints.c: Revert.
794         * coffread.c: Revert.
795         * coff-pe-read.c: Revert.
796         * cli-out.h: Revert.
797         * cli-out.c: Revert.
798         * charset.c: Revert.
799         * c-varobj.c: Revert.
800         * c-valprint.c: Revert.
801         * c-typeprint.c: Revert.
802         * c-lang.c: Revert.
803         * buildsym.c: Revert.
804         * buildsym-legacy.c: Revert.
805         * build-id.h: Revert.
806         * build-id.c: Revert.
807         * btrace.c: Revert.
808         * bsd-uthread.c: Revert.
809         * breakpoint.h: Revert.
810         * breakpoint.c: Revert.
811         * break-catch-throw.c: Revert.
812         * break-catch-syscall.c: Revert.
813         * break-catch-sig.c: Revert.
814         * blockframe.c: Revert.
815         * block.c: Revert.
816         * bfin-tdep.c: Revert.
817         * bfin-linux-tdep.c: Revert.
818         * bfd-target.c: Revert.
819         * bcache.c: Revert.
820         * ax-general.c: Revert.
821         * ax-gdb.h: Revert.
822         * ax-gdb.c: Revert.
823         * avr-tdep.c: Revert.
824         * auxv.c: Revert.
825         * auto-load.c: Revert.
826         * arm-wince-tdep.c: Revert.
827         * arm-tdep.c: Revert.
828         * arm-symbian-tdep.c: Revert.
829         * arm-pikeos-tdep.c: Revert.
830         * arm-obsd-tdep.c: Revert.
831         * arm-nbsd-tdep.c: Revert.
832         * arm-nbsd-nat.c: Revert.
833         * arm-linux-tdep.c: Revert.
834         * arm-linux-nat.c: Revert.
835         * arm-fbsd-tdep.c: Revert.
836         * arm-fbsd-nat.c: Revert.
837         * arm-bsd-tdep.c: Revert.
838         * arch-utils.c: Revert.
839         * arc-tdep.c: Revert.
840         * arc-newlib-tdep.c: Revert.
841         * annotate.h: Revert.
842         * annotate.c: Revert.
843         * amd64-windows-tdep.c: Revert.
844         * amd64-windows-nat.c: Revert.
845         * amd64-tdep.c: Revert.
846         * amd64-sol2-tdep.c: Revert.
847         * amd64-obsd-tdep.c: Revert.
848         * amd64-obsd-nat.c: Revert.
849         * amd64-nbsd-tdep.c: Revert.
850         * amd64-nbsd-nat.c: Revert.
851         * amd64-nat.c: Revert.
852         * amd64-linux-tdep.c: Revert.
853         * amd64-linux-nat.c: Revert.
854         * amd64-fbsd-tdep.c: Revert.
855         * amd64-fbsd-nat.c: Revert.
856         * amd64-dicos-tdep.c: Revert.
857         * amd64-darwin-tdep.c: Revert.
858         * amd64-bsd-nat.c: Revert.
859         * alpha-tdep.c: Revert.
860         * alpha-obsd-tdep.c: Revert.
861         * alpha-nbsd-tdep.c: Revert.
862         * alpha-mdebug-tdep.c: Revert.
863         * alpha-linux-tdep.c: Revert.
864         * alpha-linux-nat.c: Revert.
865         * alpha-bsd-tdep.c: Revert.
866         * alpha-bsd-nat.c: Revert.
867         * aix-thread.c: Revert.
868         * agent.c: Revert.
869         * addrmap.c: Revert.
870         * ada-varobj.c: Revert.
871         * ada-valprint.c: Revert.
872         * ada-typeprint.c: Revert.
873         * ada-tasks.c: Revert.
874         * ada-lang.c: Revert.
875         * aarch64-tdep.c: Revert.
876         * aarch64-ravenscar-thread.c: Revert.
877         * aarch64-newlib-tdep.c: Revert.
878         * aarch64-linux-tdep.c: Revert.
879         * aarch64-linux-nat.c: Revert.
880         * aarch64-fbsd-tdep.c: Revert.
881         * aarch64-fbsd-nat.c: Revert.
882         * aarch32-linux-nat.c: Revert.
883
884 2019-04-05  Tom Tromey  <tom@tromey.com>
885
886         * ft32-tdep.c: Sort headers.
887         * frv-tdep.c: Sort headers.
888         * frv-linux-tdep.c: Sort headers.
889         * frame.c: Sort headers.
890         * frame-unwind.c: Sort headers.
891         * frame-base.c: Sort headers.
892         * fork-child.c: Sort headers.
893         * findvar.c: Sort headers.
894         * findcmd.c: Sort headers.
895         * filesystem.c: Sort headers.
896         * filename-seen-cache.h: Sort headers.
897         * filename-seen-cache.c: Sort headers.
898         * fbsd-tdep.c: Sort headers.
899         * fbsd-nat.h: Sort headers.
900         * fbsd-nat.c: Sort headers.
901         * f-valprint.c: Sort headers.
902         * f-typeprint.c: Sort headers.
903         * f-lang.c: Sort headers.
904         * extension.h: Sort headers.
905         * extension.c: Sort headers.
906         * extension-priv.h: Sort headers.
907         * expprint.c: Sort headers.
908         * exec.h: Sort headers.
909         * exec.c: Sort headers.
910         * exceptions.c: Sort headers.
911         * event-top.c: Sort headers.
912         * event-loop.c: Sort headers.
913         * eval.c: Sort headers.
914         * elfread.c: Sort headers.
915         * dwarf2read.h: Sort headers.
916         * dwarf2read.c: Sort headers.
917         * dwarf2loc.c: Sort headers.
918         * dwarf2expr.h: Sort headers.
919         * dwarf2expr.c: Sort headers.
920         * dwarf2-frame.c: Sort headers.
921         * dwarf2-frame-tailcall.c: Sort headers.
922         * dwarf-index-write.h: Sort headers.
923         * dwarf-index-write.c: Sort headers.
924         * dwarf-index-common.c: Sort headers.
925         * dwarf-index-cache.h: Sort headers.
926         * dwarf-index-cache.c: Sort headers.
927         * dummy-frame.c: Sort headers.
928         * dtrace-probe.c: Sort headers.
929         * disasm.h: Sort headers.
930         * disasm.c: Sort headers.
931         * disasm-selftests.c: Sort headers.
932         * dictionary.c: Sort headers.
933         * dicos-tdep.c: Sort headers.
934         * demangle.c: Sort headers.
935         * dcache.h: Sort headers.
936         * dcache.c: Sort headers.
937         * darwin-nat.h: Sort headers.
938         * darwin-nat.c: Sort headers.
939         * darwin-nat-info.c: Sort headers.
940         * d-valprint.c: Sort headers.
941         * d-namespace.c: Sort headers.
942         * d-lang.c: Sort headers.
943         * ctf.c: Sort headers.
944         * csky-tdep.c: Sort headers.
945         * csky-linux-tdep.c: Sort headers.
946         * cris-tdep.c: Sort headers.
947         * cris-linux-tdep.c: Sort headers.
948         * cp-valprint.c: Sort headers.
949         * cp-support.c: Sort headers.
950         * cp-namespace.c: Sort headers.
951         * cp-abi.c: Sort headers.
952         * corelow.c: Sort headers.
953         * corefile.c: Sort headers.
954         * continuations.c: Sort headers.
955         * completer.h: Sort headers.
956         * completer.c: Sort headers.
957         * complaints.c: Sort headers.
958         * coffread.c: Sort headers.
959         * coff-pe-read.c: Sort headers.
960         * cli-out.h: Sort headers.
961         * cli-out.c: Sort headers.
962         * charset.c: Sort headers.
963         * c-varobj.c: Sort headers.
964         * c-valprint.c: Sort headers.
965         * c-typeprint.c: Sort headers.
966         * c-lang.c: Sort headers.
967         * buildsym.c: Sort headers.
968         * buildsym-legacy.c: Sort headers.
969         * build-id.h: Sort headers.
970         * build-id.c: Sort headers.
971         * btrace.c: Sort headers.
972         * bsd-uthread.c: Sort headers.
973         * breakpoint.h: Sort headers.
974         * breakpoint.c: Sort headers.
975         * break-catch-throw.c: Sort headers.
976         * break-catch-syscall.c: Sort headers.
977         * break-catch-sig.c: Sort headers.
978         * blockframe.c: Sort headers.
979         * block.c: Sort headers.
980         * bfin-tdep.c: Sort headers.
981         * bfin-linux-tdep.c: Sort headers.
982         * bfd-target.c: Sort headers.
983         * bcache.c: Sort headers.
984         * ax-general.c: Sort headers.
985         * ax-gdb.h: Sort headers.
986         * ax-gdb.c: Sort headers.
987         * avr-tdep.c: Sort headers.
988         * auxv.c: Sort headers.
989         * auto-load.c: Sort headers.
990         * arm-wince-tdep.c: Sort headers.
991         * arm-tdep.c: Sort headers.
992         * arm-symbian-tdep.c: Sort headers.
993         * arm-pikeos-tdep.c: Sort headers.
994         * arm-obsd-tdep.c: Sort headers.
995         * arm-nbsd-tdep.c: Sort headers.
996         * arm-nbsd-nat.c: Sort headers.
997         * arm-linux-tdep.c: Sort headers.
998         * arm-linux-nat.c: Sort headers.
999         * arm-fbsd-tdep.c: Sort headers.
1000         * arm-fbsd-nat.c: Sort headers.
1001         * arm-bsd-tdep.c: Sort headers.
1002         * arch-utils.c: Sort headers.
1003         * arc-tdep.c: Sort headers.
1004         * arc-newlib-tdep.c: Sort headers.
1005         * annotate.h: Sort headers.
1006         * annotate.c: Sort headers.
1007         * amd64-windows-tdep.c: Sort headers.
1008         * amd64-windows-nat.c: Sort headers.
1009         * amd64-tdep.c: Sort headers.
1010         * amd64-sol2-tdep.c: Sort headers.
1011         * amd64-obsd-tdep.c: Sort headers.
1012         * amd64-obsd-nat.c: Sort headers.
1013         * amd64-nbsd-tdep.c: Sort headers.
1014         * amd64-nbsd-nat.c: Sort headers.
1015         * amd64-nat.c: Sort headers.
1016         * amd64-linux-tdep.c: Sort headers.
1017         * amd64-linux-nat.c: Sort headers.
1018         * amd64-fbsd-tdep.c: Sort headers.
1019         * amd64-fbsd-nat.c: Sort headers.
1020         * amd64-dicos-tdep.c: Sort headers.
1021         * amd64-darwin-tdep.c: Sort headers.
1022         * amd64-bsd-nat.c: Sort headers.
1023         * alpha-tdep.c: Sort headers.
1024         * alpha-obsd-tdep.c: Sort headers.
1025         * alpha-nbsd-tdep.c: Sort headers.
1026         * alpha-mdebug-tdep.c: Sort headers.
1027         * alpha-linux-tdep.c: Sort headers.
1028         * alpha-linux-nat.c: Sort headers.
1029         * alpha-bsd-tdep.c: Sort headers.
1030         * alpha-bsd-nat.c: Sort headers.
1031         * aix-thread.c: Sort headers.
1032         * agent.c: Sort headers.
1033         * addrmap.c: Sort headers.
1034         * ada-varobj.c: Sort headers.
1035         * ada-valprint.c: Sort headers.
1036         * ada-typeprint.c: Sort headers.
1037         * ada-tasks.c: Sort headers.
1038         * ada-lang.c: Sort headers.
1039         * aarch64-tdep.c: Sort headers.
1040         * aarch64-ravenscar-thread.c: Sort headers.
1041         * aarch64-newlib-tdep.c: Sort headers.
1042         * aarch64-linux-tdep.c: Sort headers.
1043         * aarch64-linux-nat.c: Sort headers.
1044         * aarch64-fbsd-tdep.c: Sort headers.
1045         * aarch64-fbsd-nat.c: Sort headers.
1046         * aarch32-linux-nat.c: Sort headers.
1047
1048 2019-04-04  Tom Tromey  <tom@tromey.com>
1049
1050         * varobj.c (varobj_create): Update.
1051         * rust-exp.y (struct rust_parser) <update_innermost_block,
1052         lookup_symbol>: New methods.
1053         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1054         Rename.
1055         (rust_parser::rust_lookup_type)
1056         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1057         * printcmd.c (display_command, do_one_display): Update.
1058         * parser-defs.h (struct parser_state) <parser_state>: Add
1059         "tracker" parameter.
1060         (block_tracker): New member.
1061         (class innermost_block_tracker) <innermost_block_tracker>: Add
1062         "types" parameter.
1063         <reset>: Remove method.
1064         (innermost_block): Don't declare.
1065         (null_post_parser): Update.
1066         * parse.c (innermost_block): Remove global.
1067         (write_dollar_variable): Update.
1068         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1069         Remove "tracker_types" parameter.
1070         (parse_expression): Add "tracker" parameter.
1071         (parse_expression_for_completion): Update.
1072         (null_post_parser): Add "tracker" parameter.
1073         * p-exp.y: Update rules.
1074         * m2-exp.y: Update rules.
1075         * language.h (struct language_defn) <la_post_parser>: Add
1076         "tracker" parameter.
1077         * go-exp.y: Update rules.
1078         * f-exp.y: Update rules.
1079         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1080         parameter.
1081         * d-exp.y: Update rules.
1082         * c-exp.y: Update rules.
1083         * breakpoint.c (set_breakpoint_condition): Create an
1084         innermost_block_tracker.
1085         (watch_command_1): Likewise.
1086         * ada-lang.c (resolve): Add "tracker" parameter.
1087         (resolve_subexp): Likewise.
1088         * ada-exp.y (write_var_from_sym): Update.
1089
1090 2019-04-04  Tom Tromey  <tom@tromey.com>
1091
1092         * type-stack.h: New file.
1093         * type-stack.c: New file.
1094         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1095         type-stack.h.
1096         (insert_into_type_stack, insert_type, push_type, push_type_int)
1097         (insert_type_address_space, pop_type, pop_type_int)
1098         (pop_typelist, pop_type_stack, append_type_stack)
1099         (push_type_stack, get_type_stack, push_typelist)
1100         (follow_type_instance_flags, follow_types): Don't declare.
1101         * parse.c (type_stack): Remove global.
1102         (parse_exp_in_context): Update.
1103         (insert_into_type_stack, insert_type, push_type, push_type_int)
1104         (insert_type_address_space, pop_type, pop_type_int)
1105         (pop_typelist, pop_type_stack, append_type_stack)
1106         (push_type_stack, get_type_stack, push_typelist)
1107         (follow_type_instance_flags, follow_types): Remove (moved to
1108         type-stack.c).
1109         * f-exp.y (type_stack): New global.
1110         Update rules.
1111         (push_kind_type, f_parse): Update.
1112         * d-exp.y (type_stack): New global.
1113         Update rules.
1114         (d_parse): Update.
1115         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1116         Update rules.
1117         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1118         (HFILES_NO_SRCDIR): Add type-stack.h.
1119
1120 2019-04-04  Tom Tromey  <tom@tromey.com>
1121
1122         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1123         (rust_parser::convert_ast_to_expression, rust_parse)
1124         (rust_lex_test_completion, rust_lex_tests): Update.
1125         * parser-defs.h (struct expr_completion_state): New.
1126         (struct parser_state) <parser_state>: Add completion parameter.
1127         <mark_struct_expression, mark_completion_tag>: New methods.
1128         <parse_completion, m_completion_state>: New members.
1129         (prefixify_expression, null_post_parser): Update.
1130         (mark_struct_expression, mark_completion_tag): Don't declare.
1131         * parse.c (parse_completion, expout_last_struct)
1132         (expout_tag_completion_type, expout_completion_name): Remove
1133         globals.
1134         (parser_state::mark_struct_expression)
1135         (parser_state::mark_completion_tag): Now methods.
1136         (prefixify_expression): Add last_struct parameter.
1137         (prefixify_subexp): Likewise.
1138         (parse_exp_1): Update.
1139         (parse_exp_in_context): Add cstate parameter.  Update.
1140         (parse_expression_for_completion): Create an
1141         expr_completion_state.
1142         (null_post_parser): Add "completion" parameter.
1143         * p-exp.y: Update rules.
1144         (yylex): Update.
1145         * language.h (struct language_defn) <la_post_parser>: Add
1146         "completing" parameter.
1147         * go-exp.y: Update rules.
1148         (lex_one_token): Update.
1149         * expression.h (parse_completion): Don't declare.
1150         * d-exp.y: Update rules.
1151         (lex_one_token): Update rules.
1152         * c-exp.y: Update rules.
1153         (lex_one_token): Update.
1154         * ada-lang.c (resolve): Add "parse_completion" parameter.
1155         (resolve_subexp): Likewise.
1156         (ada_resolve_function): Likewise.
1157
1158 2019-04-04  Tom Tromey  <tom@tromey.com>
1159
1160         * parser-defs.h (struct parser_state) <start_arglist,
1161         end_arglist>: New methods.
1162         <arglist_len, m_funcall_chain>: New members.
1163         (arglist_len, start_arglist, end_arglist): Don't declare.
1164         * parse.c (arglist_len, funcall_chain): Remove global.
1165         (start_arglist, end_arglist): Remove functions.
1166         (parse_exp_in_context): Update.
1167         * p-exp.y: Update rules.
1168         * m2-exp.y: Update rules.
1169         * go-exp.y: Update rules.
1170         * f-exp.y: Update rules.
1171         * d-exp.y: Update rules.
1172         * c-exp.y: Update rules.
1173
1174 2019-04-04  Tom Tromey  <tom@tromey.com>
1175
1176         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1177         lex_operator, push_back>: New methods.
1178         Update all rules.
1179         (rust_parser::lex_hex, lex_escape): Rename and update.
1180         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1181         (rust_parser::lex_operator): Rename and update.
1182         (rust_parser::lex_number, rustyylex, rustyyerror)
1183         (rust_lex_test_init, rust_lex_test_sequence)
1184         (rust_lex_test_push_back, rust_lex_tests): Update.
1185         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1186         parameter.
1187         <lexptr, prev_lexptr>: New members.
1188         (lexptr, prev_lexptr): Don't declare.
1189         * parse.c (lexptr, prev_lexptr): Remove globals.
1190         (parse_exp_in_context): Update.
1191         * p-exp.y (yylex, yyerror): Update.
1192         * m2-exp.y (parse_number, yylex, yyerror): Update.
1193         * go-exp.y (lex_one_token, yyerror): Update.
1194         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1195         * d-exp.y (lex_one_token, yyerror): Update.
1196         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1197         (lex_one_token, yyerror): Update.
1198         * ada-lex.l (YY_INPUT): Update.
1199         (rewind_to_char): Update.
1200         * ada-exp.y (yyerror): Update.
1201
1202 2019-04-04  Tom Tromey  <tom@tromey.com>
1203
1204         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1205         * parser-defs.h (struct parser_state) <parser_state>: Add new
1206         parameter.
1207         <comma_terminates>: New member.
1208         (comma_terminates): Don't declare global.
1209         * parse.c (comma_terminates): Remove global.
1210         (parse_exp_in_context): Update.
1211         * p-exp.y (yylex): Update.
1212         * m2-exp.y (yylex): Update.
1213         * go-exp.y (lex_one_token): Update.
1214         * f-exp.y (yylex): Update.
1215         * d-exp.y (lex_one_token): Update.
1216         * c-exp.y (lex_one_token): Update.
1217         * ada-lex.l: Update.
1218
1219 2019-04-04  Tom Tromey  <tom@tromey.com>
1220
1221         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1222         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1223         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1224         * parser-defs.h (paren_depth): Don't declare.
1225         * parse.c (paren_depth): Remove global.
1226         (parse_exp_in_context): Update.
1227         * p-exp.y (paren_depth): New global.
1228         (pascal_parse): Initialize it.
1229         * m2-exp.y (paren_depth): New global.
1230         (m2_parse): Initialize it.
1231         * go-exp.y (paren_depth): New global.
1232         (go_parse): Initialize it.
1233         * f-exp.y (paren_depth): New global.
1234         (f_parse): Initialize it.
1235         * d-exp.y (paren_depth): New global.
1236         (d_parse): Initialize it.
1237         * c-exp.y (paren_depth): New global.
1238         (c_parse): Initialize it.
1239         * ada-lex.l (paren_depth): New global.
1240         (lexer_init): Initialize it.
1241
1242 2019-04-04  Tom Tromey  <tom@tromey.com>
1243
1244         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1245         (rust_parser::convert_ast_to_type)
1246         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1247         * parser-defs.h (struct parser_state) <parser_state>: Add
1248         parameters.  Initialize new members.
1249         <expression_context_block, expression_context_pc>: New members.
1250         * parse.c (expression_context_block, expression_context_pc):
1251         Remove globals.
1252         (parse_exp_in_context): Update.
1253         * p-exp.y: Update all rules.
1254         (yylex): Update.
1255         * m2-exp.y: Update all rules.
1256         (yylex): Update.
1257         * go-exp.y (yylex): Update.
1258         * f-exp.y (yylex): Update.
1259         * d-exp.y: Update all rules.
1260         (yylex): Update.
1261         * c-exp.y: Update all rules.
1262         (lex_one_token, classify_name, yylex, c_parse): Update.
1263         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1264
1265 2019-04-04  Tom Tromey  <tom@tromey.com>
1266
1267         * gdbarch.h, gdbarch.c: Rebuild.
1268         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1269         * stap-probe.h: 
1270         (struct stap_parse_info): Replace "parser_state" with
1271         "expr_builder".
1272         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1273         (parser_state): New class.
1274         * parse.c (expr_builder): Rename.
1275         (expr_builder::release): Rename.
1276         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1277         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1278         (write_exp_elt_longcst, write_exp_elt_floatcst)
1279         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1280         (write_exp_string_vector, write_exp_bitstring)
1281         (write_exp_msymbol, mark_struct_expression)
1282         (write_dollar_variable)
1283         (insert_type_address_space, increase_expout_size): Replace
1284         "parser_state" with "expr_builder".
1285         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1286         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1287         "parser_state" with "expr_builder".
1288
1289 2019-04-04  Tom Tromey  <tom@tromey.com>
1290
1291         * rust-exp.y: Replace "parse_language" with method call.
1292         * p-exp.y: 
1293         (yylex): Replace "parse_language" with method call.
1294         * m2-exp.y: 
1295         (yylex): Replace "parse_language" with method call.
1296         * go-exp.y (classify_name): Replace "parse_language" with method
1297         call.
1298         * f-exp.y (yylex): Replace "parse_language" with method call.
1299         * d-exp.y (lex_one_token): Replace "parse_language" with method
1300         call.
1301         * c-exp.y: 
1302         (lex_one_token, classify_name, yylex): Replace "parse_language"
1303         with method call.
1304         * ada-exp.y (find_primitive_type, type_char)
1305         (type_system_address): Replace "parse_language" with method call.
1306
1307 2019-04-04  Tom Tromey  <tom@tromey.com>
1308
1309         * rust-exp.y: Replace "parse_gdbarch" with method call.
1310         * parse.c (write_dollar_variable, insert_type_address_space):
1311         Replace "parse_gdbarch" with method call.
1312         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1313         call.
1314         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1315         call.
1316         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1317         "parse_gdbarch" with method call.
1318         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1319         with method call.
1320         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1321         "parse_gdbarch" with method call.
1322         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1323         "parse_gdbarch" with method call.
1324         * c-exp.y (parse_type, parse_number, classify_name): Replace
1325         "parse_gdbarch" with method call.
1326         * ada-lex.l: Replace "parse_gdbarch" with method call.
1327         * ada-exp.y (parse_type, find_primitive_type, type_char)
1328         (type_system_address): Replace "parse_gdbarch" with method call.
1329
1330 2019-04-04  Tom Tromey  <tom@tromey.com>
1331
1332         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1333         * stap-probe.c (stap_parse_argument): Update.
1334         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1335         initial_size parameter.
1336         * rust-exp.y (rust_lex_tests): Update.
1337         * parse.c (parser_state): Update.
1338         (parse_exp_in_context): Update.
1339         * parser-defs.h (struct parser_state) <parser_state>: Remove
1340         "initial_size" parameter.
1341
1342 2019-04-04  Tom Tromey  <tom@tromey.com>
1343
1344         * parser-defs.h (increase_expout_size): Don't declare.
1345         * parse.c (increase_expout_size): Now static.
1346
1347 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1348
1349         * gnu-nat.c (gnu_nat_target::wait): Fix
1350         target_waitstatus_to_string call.
1351
1352 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1353
1354         * eval.c (evaluate_subexp_standard): Handle internal functions
1355         during Fortran function call handling.
1356
1357 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1358
1359         * NEWS: Mention new internal functions.
1360         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1361         (read_base_type): Use dwarf2_init_complex_target_type.
1362         * value.c (creal_internal_fn): New function.
1363         (cimag_internal_fn): New function.
1364         (_initialize_values): Register new internal functions.
1365
1366 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1367
1368         * infrun.c (stop_all_threads): If debug_infrun, always
1369         trace the wait status after wait_one, using
1370         target_waitstatus_to_string and target_pid_to_str.
1371         (handle_inferior_event): Replace various trace of
1372         wait status kind by a single trace.
1373         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1374         wait status kind image by target_waitstatus_to_string.
1375         * target/waitstatus.c (target_waitstatus_to_string): Fix
1376         obsolete comment.
1377
1378 2019-04-01  Tom Tromey  <tromey@adacore.com>
1379
1380         PR symtab/23331:
1381         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1382
1383 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1384             Pedro Alves  <palves@redhat.com>
1385
1386         * top.c (quit_force): Call 'finalize_values'.
1387         * value.c (finalize_values): New function.
1388         * value.h (finalize_values): Declare.
1389
1390 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1391
1392         * NEWS: Announce $_gdb_major and $_gdb_minor.
1393
1394         * top.c (init_gdb_version_vars): New function.
1395         (gdb_init): Call init_gdb_version_vars.
1396
1397 2019-03-29  Tom Tromey  <tromey@adacore.com>
1398
1399         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1400         help text.  Remove dead code.
1401
1402 2019-03-29  Keith Seitz  <keiths@redhat.com>
1403
1404         From Siddhesh Poyarekar:
1405         * f-lang.h (f77_get_upperbound): Return LONGEST.
1406         (f77_get_lowerbound): Likewise.
1407         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1408         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1409         print them.
1410         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1411         plongest to format print it.
1412         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1413         (f77_get_upperbound): Likewise.
1414         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1415         LOWER_BOUND to LONGEST.
1416         (f77_create_arrayprint_offset_tbl): Likewise.
1417
1418 2019-03-29  Keith Seitz  <keiths@redhat.com>
1419
1420         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1421         %s/pulongest for TYPE_LENGTH instead of %d in format
1422         strings.
1423         * ada-typerint.c (ada_print_type): Likewise.
1424         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1425         * compile/compile-c-support.c (generate_register_struct): Likewise.
1426         * gdbtypes.c (recursive_dump_type): Likewise.
1427         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1428         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1429         instead of %d in format strings.
1430         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1431         to std::min to ULONGEST.
1432         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1433         instead of %d in format strings.
1434         * tracepoint.c (info_scope_command): Likewise.
1435         * typeprint.c (print_offset_data::update)
1436         (print_offset_data::finish): Likewise.
1437         * xtensa-tdep.c (xtensa_store_return_value)
1438         (xtensa_push_dummy_call): Likewise.
1439
1440 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1441
1442         * windows-nat.c (display_selector): Fixed format specifications
1443         for 64-bit Cygwin.
1444
1445 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1446
1447         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1448
1449 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1450
1451         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1452         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1453         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1454         (nios2_linux_init_abi): Install it.
1455
1456 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1457
1458         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1459
1460 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1461
1462         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1463
1464 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1465             Tom Tromey  <tromey@adacore.com>
1466
1467         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1468
1469 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1470
1471         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1472         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1473         method to compute the bounds of range types. Also print "[evaluated]"
1474         if the bounds' values come from a dynamic evaluation.
1475
1476 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1477
1478         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1479         whitespace when pretty printing is on.
1480
1481 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1482
1483         * ppc-linux-nat.c: Add include.
1484
1485 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1486
1487         * NEWS: Mention AArch64 Pointer Authentication.
1488
1489 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1490
1491         * arm-linux-nat.c: Add include.
1492
1493 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1494
1495         * source-cache.c (source_cache::get_source_lines): Re-read
1496         fullname after calling open_source_file.
1497
1498 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1499
1500         * NEWS: Mention TLS support for FreeBSD.
1501
1502 2019-03-25  Tom Tromey  <tromey@adacore.com>
1503
1504         * minsyms.c (BUNCH_SIZE): Update comment.
1505         (~minimal_symbol_reader): Remove old comment.
1506         (compact_minimal_symbols): Update comment.
1507         (minimal_symbol_reader::install): Remove old comment.  Update
1508         other comments.
1509
1510 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1511
1512         * s390-linux-nat.c: Add include.
1513
1514 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1515
1516         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1517         Call linux_get_hwcap.
1518         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1519         Likewise.
1520         (aarch64_linux_get_hwcap): Remove function.
1521         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1522         declaration.
1523         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1524         linux_get_hwcap.
1525         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1526         * linux-tdep.c (linux_get_hwcap): Add function.
1527         (linux_get_hwcap2): Likewise.
1528         * linux-tdep.h (linux_get_hwcap): Add declaration.
1529         (linux_get_hwcap2): Likewise.
1530         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1531         (ppc_linux_get_hwcap2): Likewise.
1532         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1533         linux_get_hwcap.
1534         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1535         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1536         (ppc_linux_nat_target::read_description): Likewise.
1537         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1538         * s390-linux-nat.c: Likewise.
1539         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1540
1541 2019-03-24  Tom Tromey  <tom@tromey.com>
1542
1543         * ada-lang.c (standard_lookup): Simplify initialization.
1544         (ada_lookup_symbol_nonlocal): Simplify return.
1545         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1546         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1547         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1548         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1549         initialization.
1550         * solib.c (solib_global_lookup): Simplify.
1551         * symtab.c (null_block_symbol): Remove.
1552         (symbol_cache_lookup): Simplify returns.
1553         (lookup_language_this): Simplify returns.
1554         (lookup_symbol_aux): Simplify return.
1555         (lookup_local_symbol): Simplify returns.
1556         (lookup_global_symbol_from_objfile): Simplify return.
1557         (lookup_symbol_in_objfile_symtabs)
1558         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1559         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1560         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1561         * cp-namespace.c (cp_lookup_bare_symbol)
1562         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1563         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1564         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1565         (cp_lookup_symbol_via_imports): Simplify initialization.
1566         (find_symbol_in_baseclass): Likewise.
1567         * symtab.h (null_block_symbol): Remove.
1568         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1569         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1570         (d_lookup_symbol_module): Likewise.
1571         (find_symbol_in_baseclass): Simplify initialization.
1572
1573 2019-03-24  Tom Tromey  <tom@tromey.com>
1574
1575         * expression.h: Don't include symtab.h.
1576         (struct block): Forward declare.
1577
1578 2019-03-24  Tom Tromey  <tom@tromey.com>
1579
1580         * c-exp.y (typebase): Remove casts.
1581         * gdbtypes.c (lookup_unsigned_typename, )
1582         (lookup_signed_typename): Remove cast.
1583         * eval.c (parse_to_comma_and_eval): Remove cast.
1584         * parse.c (write_dollar_variable): Remove cast.
1585         * block.h (struct block) <superblock>: Now const.
1586         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1587         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1588         (map_block): Make "block" const.
1589         * symfile.h (struct quick_symbol_functions)
1590         <map_matching_symbols>: Constify block argument to "callback".
1591         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1592         const.
1593         (find_pc_sect_compunit_symtab): Make "b" const.
1594         (find_symbol_at_address): Likewise.
1595         (search_symbols): Likewise.
1596         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1597         (dw2_debug_names_lookup_symbol): Likewise.
1598         (dw2_map_matching_symbols): Update.
1599         * p-valprint.c (pascal_val_print): Remove "block".
1600         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1601         (aux_add_nonlocal_symbols): Make "block" const.
1602         (resolve_subexp): Remove cast.
1603         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1604         const.
1605         (iterate_over_file_blocks): Likewise.
1606         * f-exp.y (%union) <bval>: Remove.
1607         * coffread.c (patch_opaque_types): Make "b" const.
1608         * spu-tdep.c (spu_catch_start): Make "block" const.
1609         * c-valprint.c (print_unpacked_pointer): Remove "block".
1610         * symmisc.c (dump_symtab_1): Make "b" const.
1611         (block_depth): Make "block" const.
1612         * d-exp.y (%union) <bval>: Remove.
1613         * cp-support.h (cp_lookup_rtti_type): Update.
1614         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1615         * psymtab.c (psym_lookup_symbol): Make "block" const.
1616         (maintenance_check_psymtabs): Make "b" const.
1617         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1618         (enumerate_locals, enumerate_args): Update.
1619         * python/py-symtab.c (stpy_global_block): Make "block" const.
1620         (stpy_static_block): Likewise.
1621         * inline-frame.c (block_starting_point_at): Make "new_block"
1622         const.
1623         * block.c (find_block_in_blockvector): Make return type const.
1624         (blockvector_for_pc_sect): Make "b" const.
1625         (find_block_in_blockvector): Make "b" const.
1626
1627 2019-03-23  Tom Tromey  <tom@tromey.com>
1628
1629         * varobj.c (varobj_create): Update.
1630         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1631         * printcmd.c (display_command, do_one_display): Don't reset
1632         innermost_block.
1633         * parser-defs.h (enum innermost_block_tracker_type): Move to
1634         expression.h.
1635         (innermost_block): Update comment.
1636         * parse.c (parse_exp_1): Add tracker_types parameter.
1637         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1638         tracker_types parameter.  Reset innermost_block.
1639         (parse_exp_in_context): Remove.
1640         (parse_expression_for_completion): Update.
1641         * objfiles.c (~objfile): Don't reset expression_context_block or
1642         innermost_block.
1643         * expression.h (enum innermost_block_tracker_type): Move from
1644         parser-defs.h.
1645         (parse_exp_1): Add tracker_types parameter.
1646         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1647         reset innermost_block.
1648
1649 2019-03-23  Tom Tromey  <tom@tromey.com>
1650
1651         * objfiles.h: Include bcache.h.
1652
1653 2019-03-23  Tom Tromey  <tom@tromey.com>
1654
1655         * linespec.c (get_current_search_block): Use
1656         scoped_restore_current_language.
1657         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1658
1659 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1660             Jiong Wang  <jiong.wang@arm.com>
1661
1662         * aarch64-linux-tdep.c
1663         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1664         section.
1665         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1666
1667 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1668             Jiong Wang  <jiong.wang@arm.com>
1669
1670         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1671         instructions.
1672         (aarch64_analyze_prologue_test): Add PACIASP test.
1673         (aarch64_prologue_prev_register): Unmask PC value.
1674
1675 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1676             Jiong Wang  <jiong.wang@arm.com>
1677
1678         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1679         (aarch64_dwarf2_prev_register): Unmask PC value.
1680         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1681         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1682         DW_CFA_AARCH64_negate_ra_state.
1683         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1684
1685 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1686             Jiong Wang  <jiong.wang@arm.com>
1687
1688         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1689         registers.
1690         (aarch64_pseudo_register_name): Likewise.
1691         (aarch64_pseudo_register_type): Likewise.
1692         (aarch64_pseudo_register_reggroup_p): Likewise.
1693         (aarch64_gdbarch_init): Add pauth registers.
1694         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1695         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1696         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1697         (struct gdbarch_tdep): Add regnum for ra_state.
1698
1699 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1700             Jiong Wang  <jiong.wang@arm.com>
1701
1702         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1703
1704 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1705             Jiong Wang  <jiong.wang@arm.com>
1706
1707         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1708         function.
1709         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1710         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1711         (aarch64_gdbarch_init): Add puth registers.
1712         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1713         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1714         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1715
1716 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1717             Jiong Wang  <jiong.wang@arm.com>
1718
1719         * aarch64-linux-nat.c
1720         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1721         * aarch64-linux-tdep.c
1722         (aarch64_linux_core_read_description): Likewise.
1723         (aarch64_linux_get_hwcap): New function.
1724         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1725         (aarch64_linux_get_hwcap): New declaration.
1726
1727 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1728             Jiong Wang  <jiong.wang@arm.com>
1729
1730         * aarch64-linux-nat.c
1731         (aarch64_linux_nat_target::read_description): Add pauth param.
1732         * aarch64-linux-tdep.c
1733         (aarch64_linux_core_read_description): Likewise.
1734         * aarch64-tdep.c (struct target_desc): Add in pauth.
1735         (aarch64_read_description): Add pauth param.
1736         (aarch64_gdbarch_init): Likewise.
1737         * aarch64-tdep.h (aarch64_read_description): Likewise.
1738         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1739         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1740         * features/Makefile: Add new files.
1741         * features/aarch64-pauth.c: New file.
1742         * features/aarch64-pauth.xml: New file.
1743
1744 2019-03-20  Tom Tromey  <tromey@adacore.com>
1745
1746         * infrun.c (handle_inferior_event): Rename from
1747         handle_inferior_event_1.  Create a scoped_value_mark.
1748         (handle_inferior_event): Remove.
1749
1750 2019-03-19  Tom Tromey  <tromey@adacore.com>
1751
1752         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1753         * infrun.h (print_stop_event): Add "displays" parameter.
1754         * infrun.c (print_stop_event): Add "displays" parameter.
1755
1756 2019-03-19  Pedro Alves  <palves@redhat.com>
1757
1758         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1759         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1760         to -1.  Fix TABs vs spaces.
1761         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1762         * tui/tui-out.h (tui_ui_out) Add intro comments.
1763         <m_line, m_start_of_line>: In-class initialize, and add describing
1764         comment.
1765
1766 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1767
1768         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1769         variable names.
1770         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1771
1772 2019-03-18  Pedro Alves  <palves@redhat.com>
1773             Eli Zaretskii <eliz@gnu.org>
1774
1775         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1776         m_line and m_start_of_line.
1777
1778 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1779
1780         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1781         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1782         it returns a newline.  This fixes a regression in TU mode, whereby
1783         the next line is output on the same screen line as the user input.
1784
1785 2019-03-18  Tom Tromey  <tromey@adacore.com>
1786
1787         * minsyms.c (minimal_symbol_reader::install): Remove call to
1788         obstack_blank.
1789
1790 2019-03-18  Pedro Alves  <palves@redhat.com>
1791
1792         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1793         New globals.
1794         (apply_style): New, factored out from ...
1795         (apply_ansi_escape): ... this.  Handle reverse video mode.
1796         (tui_set_reverse_mode): New function.
1797         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1798         * tui/tui-winsource.c (tui_show_source_line): Use
1799         tui_set_reverse_mode instead of setting A_STANDOUT.
1800         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1801         New setter methods.
1802
1803 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1804
1805         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1806         Handle tabs.
1807
1808 2019-03-18  Tom Tromey  <tromey@adacore.com>
1809
1810         * ada-lang.c (empty_array): Add "high" parameter.
1811         (ada_evaluate_subexp): Update.
1812
1813 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1814
1815         * unittests/string_view-selftests.c: Define
1816         _initialize_string_view_selftests unconditionally.
1817
1818 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1819
1820         PR gdb/24350
1821         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1822
1823 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1824
1825         PR gdb/24351
1826         * windows-nat.c (display_selector): Fix format specifiers.
1827
1828 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1829
1830         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1831         tui_refill_source_window instead of tui_refresh_win, to update the
1832         current execution line.  This fixes redisplay of the current line
1833         when stepping through the code with "next" or "step".
1834
1835 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1836
1837         * source-cache.c (source_cache::get_source_lines): Call
1838         find_source_lines to initialize s->nlines.  This fixes vertical
1839         scrolling of TUI source window when the DOWN arrow is pressed.
1840
1841 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1842
1843         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1844         linux-thread-db.c (_initialize_thread_db): Likewise.
1845
1846 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1847
1848         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1849         wclrtoeol in tui_show_source_line".  This reverts changes made in
1850         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1851
1852 2019-03-15  Tom Tromey  <tom@tromey.com>
1853
1854         * symtab.h (struct minimal_symbol): Derive from
1855         general_symbol_info.
1856         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1857         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1858         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1859         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1860         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1861         (MSYMBOL_SEARCH_NAME): Update.
1862         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1863         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1864         * minsyms.c (minimal_symbol_reader::record_full): Update.
1865
1866 2019-03-15  Tom Tromey  <tom@tromey.com>
1867
1868         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1869
1870 2019-03-15  Tom Tromey  <tom@tromey.com>
1871
1872         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1873         unique_xmalloc_ptr.
1874         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1875         Update.
1876         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1877         (build_minimal_symbol_hash_tables)
1878         (minimal_symbol_reader::install): Update.
1879
1880 2019-03-15  Tom Tromey  <tom@tromey.com>
1881
1882         * symtab.c (create_demangled_names_hash): Update.
1883         (symbol_set_names): Update.
1884         * objfiles.h (struct objfile_per_bfd_storage)
1885         <demangled_names_hash>: Now an htab_up.
1886         * objfiles.c (objfile_per_bfd_storage): Simplify.
1887
1888 2019-03-15  Tom Tromey  <tom@tromey.com>
1889
1890         * objfiles.h (struct objfile_per_bfd_storage): Declare
1891         destructor.
1892         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1893         New.
1894         (get_objfile_bfd_data): Use new.  Don't initialize
1895         language_of_main.
1896         (free_objfile_per_bfd_storage): Remove.
1897         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1898
1899 2019-03-15  Tom Tromey  <tom@tromey.com>
1900
1901         * symfile.c (reread_symbols): Update.
1902         * objfiles.c (objfile::objfile): Update.
1903         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1904         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1905         comment.
1906         (minimal_symbol_reader::install): Update.
1907         (terminate_minimal_symbol_table): Remove.
1908         * jit.c (jit_object_close_impl): Update.
1909
1910 2019-03-15  Tom Tromey  <tom@tromey.com>
1911
1912         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1913         initializations.
1914
1915 2019-03-15  Tom Tromey  <tom@tromey.com>
1916
1917         * objfiles.h (struct objfile_per_bfd_storage)
1918         <demangled_hash_languages>: Now a bitset.
1919         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1920         (lookup_minimal_symbol): Update.
1921
1922 2019-03-15  Tom Tromey  <tom@tromey.com>
1923
1924         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1925         Don't return the symbol.
1926         * coffread.c (record_minimal_symbol): Use record_full.
1927
1928 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1929
1930         The MS-Windows port of ncurses fails to switch to a color pair if
1931         one or both of the colors are the implicit default colors.  This
1932         change records the default colors when TUI is initialized, and
1933         then specifies them explicitly when a color pair uses the default
1934         colors.  This allows color styling in TUI mode on MS-Windows.
1935
1936         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1937         ncurses_norm_attr.
1938         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1939         colors in ncurses_norm_attr.
1940         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1941         "none", replace it with the default color recorded in
1942         ncurses_norm_attr.
1943
1944 2019-03-14  Tom Tromey  <tromey@adacore.com>
1945
1946         * source-cache.h (class source_cache) <get_source_lines>: Return
1947         std::string.
1948         * source-cache.c (source_cache::extract_lines): Handle case where
1949         first_pos==npos.  Return std::string.
1950         (source_cache::get_source_lines): Update.
1951
1952 2019-03-14  Tom Tromey  <tromey@adacore.com>
1953
1954         * NEWS: Add item for "style sources" commands.
1955         * source-cache.c (source_cache::get_source_lines): Check
1956         source_styling.
1957         * cli/cli-style.c (source_styling): New global.
1958         (_initialize_cli_style): Add "style sources" commands.
1959         (show_style_sources): New function.
1960         * cli/cli-style.h (source_styling): Declare.
1961
1962 2019-03-14  Pedro Alves  <palves@redhat.com>
1963             Tom Tromey  <tromey@adacore.com>
1964
1965         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1966         * tui/tui-winsource.c (tui_refill_source_window): New function,
1967         from...
1968         (tui_horizontal_source_scroll): ... here.  Move some logic.
1969         * cli/cli-style.c (set_style_enabled): Notify new observable.
1970         * tui/tui-hooks.c (tui_redisplay_source): New function.
1971         (tui_attach_detach_observers): Attach or detach
1972         tui_redisplay_source.
1973         * observable.h (source_styling_changed): New observable.
1974         * observable.c: Define source_styling_changed observable.
1975
1976 2019-03-13  Tom Tromey  <tromey@adacore.com>
1977
1978         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1979         (i386_gnu_nat_target::store_registers): Update.
1980         * target-debug.h (target_debug_print_std_string): New macro.
1981         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1982         * windows-tdep.c (display_one_tib): Update.
1983         * tui/tui-stack.c (tui_make_status_line): Update.
1984         * top.c (print_inferior_quit_action): Update.
1985         * thread.c (thr_try_catch_cmd): Update.
1986         (add_thread_with_info): Update.
1987         (thread_target_id_str): Update.
1988         (thr_try_catch_cmd): Update.
1989         (thread_command): Update.
1990         (thread_find_command): Update.
1991         * record-btrace.c (record_btrace_target::info_record)
1992         (record_btrace_resume_thread, record_btrace_target::resume)
1993         (record_btrace_cancel_resume, record_btrace_step_thread)
1994         (record_btrace_target::wait, record_btrace_target::wait)
1995         (record_btrace_target::wait, record_btrace_target::stop): Update.
1996         * progspace.c (print_program_space): Update.
1997         * process-stratum-target.c
1998         (process_stratum_target::thread_address_space): Update.
1999         * linux-fork.c (linux_fork_mourn_inferior)
2000         (detach_checkpoint_command, info_checkpoints_command)
2001         (linux_fork_context): Update.
2002         (linux_fork_detach): Update.
2003         (class scoped_switch_fork_info): Update.
2004         (delete_checkpoint_command): Update.
2005         * infrun.c (follow_fork_inferior): Update.
2006         (follow_fork_inferior): Update.
2007         (proceed_after_vfork_done): Update.
2008         (handle_vfork_child_exec_or_exit): Update.
2009         (follow_exec): Update.
2010         (displaced_step_prepare_throw): Update.
2011         (displaced_step_restore): Update.
2012         (start_step_over): Update.
2013         (resume_1): Update.
2014         (clear_proceed_status_thread): Update.
2015         (proceed): Update.
2016         (print_target_wait_results): Update.
2017         (do_target_wait): Update.
2018         (context_switch): Update.
2019         (stop_all_threads): Update.
2020         (restart_threads): Update.
2021         (finish_step_over): Update.
2022         (handle_signal_stop): Update.
2023         (switch_back_to_stepped_thread): Update.
2024         (keep_going_pass_signal): Update.
2025         (print_exited_reason): Update.
2026         (normal_stop): Update.
2027         * inferior.c (inferior_pid_to_str): Change return type.
2028         (print_selected_inferior): Update.
2029         (add_inferior): Update.
2030         (detach_inferior): Update.
2031         * dummy-frame.c (fprint_dummy_frames): Update.
2032         * dcache.c (dcache_info_1): Update.
2033         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2034         (btrace_fetch, btrace_clear): Update.
2035         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2036         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2037         type.
2038         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2039         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2040         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2041         * gdbarch.c, gdbarch.h: Rebuild.
2042         * gdbarch.sh (core_pid_to_str): Change return type.
2043         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2044         return type.
2045         (windows_nat_target::pid_to_str): Change return type.
2046         (windows_delete_thread): Update.
2047         (windows_nat_target::attach): Update.
2048         (windows_nat_target::files_info): Update.
2049         * target-delegates.c: Rebuild.
2050         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2051         return type.
2052         (sol_thread_target::pid_to_str): Change return type.
2053         * remote.c (class remote_target) <pid_to_str>: Change return
2054         type.
2055         (remote_target::pid_to_str): Change return type.
2056         (extended_remote_target::attach, remote_target::remote_stop_ns)
2057         (remote_target::remote_notif_remove_queued_reply)
2058         (remote_target::push_stop_reply, remote_target::disable_btrace):
2059         Update.
2060         (extended_remote_target::attach): Update.
2061         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2062         type.
2063         (gdbsim_target::pid_to_str): Change return type.
2064         * ravenscar-thread.c (struct ravenscar_thread_target)
2065         <pid_to_str>: Change return type.
2066         (ravenscar_thread_target::pid_to_str): Change return type.
2067         * procfs.c (class procfs_target) <pid_to_str>: Change return
2068         type.
2069         (procfs_target::pid_to_str): Change return type.
2070         (procfs_target::attach): Update.
2071         (procfs_target::detach): Update.
2072         (procfs_target::fetch_registers): Update.
2073         (procfs_target::store_registers): Update.
2074         (procfs_target::wait): Update.
2075         (procfs_target::files_info): Update.
2076         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2077         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2078         return type.
2079         (nto_procfs_target::pid_to_str): Change return type.
2080         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2081         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2082         return type.
2083         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2084         (exit_lwp): Update.
2085         (attach_proc_task_lwp_callback, get_detach_signal)
2086         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2087         (linux_nat_target::resume, wait_lwp, stop_callback)
2088         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2089         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2090         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2091         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2092         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2093         type.
2094         (inf_ptrace_target::attach): Update.
2095         (inf_ptrace_target::files_info): Update.
2096         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2097         type.
2098         (go32_nat_target::pid_to_str): Change return type.
2099         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2100         (gnu_nat_target::wait): Update.
2101         (gnu_nat_target::wait): Update.
2102         (gnu_nat_target::resume): Update.
2103         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2104         (fbsd_nat_target::wait): Update.
2105         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2106         type.
2107         (darwin_nat_target::attach): Update.
2108         * corelow.c (class core_target) <pid_to_str>: Change return type.
2109         (core_target::pid_to_str): Change return type.
2110         * target.c (normal_pid_to_str): Change return type.
2111         (default_pid_to_str): Likewise.
2112         (target_pid_to_str): Change return type.
2113         (target_translate_tls_address): Update.
2114         (target_announce_detach): Update.
2115         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2116         return type.
2117         (bsd_uthread_target::pid_to_str): Change return type.
2118         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2119         type.
2120         (bsd_kvm_target::pid_to_str): Change return type.
2121         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2122         return type.
2123         (aix_thread_target::pid_to_str): Change return type.
2124         * target.h (struct target_ops) <pid_to_str>: Change return type.
2125         (target_pid_to_str, normal_pid_to_str): Likewise.
2126         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2127         type.
2128         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2129         type.
2130         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2131         return type.
2132         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2133         type.
2134         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2135         type.
2136         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2137         return type.
2138
2139 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2140
2141         * NEWS: Mention that the new default MI version is 3.  Mention
2142         changes to the output of commands and events that deal with
2143         multi-location breakpoints.
2144         * breakpoint.c: Include "mi/mi-out.h".
2145         (print_one_breakpoint): Change output syntax if using MI version
2146         >= 3.
2147         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2148         New.
2149         (mi_multi_location_breakpoint_output_fixed): New.
2150         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2151         (mi_cmd_fix_multi_location_breakpoint_output): New.
2152         (mi_multi_location_breakpoint_output_fixed): New.
2153         * mi/mi-cmds.c (mi_cmds): Register command
2154         -fix-multi-location-breakpoint-output.
2155         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2156         interpreter "mi".
2157
2158 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2159
2160         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2161         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2162         instantiate mi_ui_out based on interpreter name.
2163         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2164         * mi/mi-main.c (mi_load_progress): Likewise.
2165
2166 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2167
2168         * NEWS: Combine separate "New targets" sections for 8.3.
2169
2170 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2171
2172         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2173         (ppcfbsd_init_abi): Install gdbarch
2174         "fetch_tls_load_module_address" and "get_thread_local_address"
2175         methods.
2176
2177 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2178
2179         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2180         (riscv_fbsd_init_abi): Install gdbarch
2181         "fetch_tls_load_module_address" and "get_thread_local_address"
2182         methods.
2183
2184 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2185
2186         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2187         (i386fbsd_init_abi): Install gdbarch
2188         "fetch_tls_load_module_address" and "get_thread_local_address"
2189         methods.
2190
2191 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2192
2193         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2194         (amd64fbsd_init_abi): Install gdbarch
2195         "fetch_tls_load_module_address" and "get_thread_local_address"
2196         methods.
2197
2198 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2199
2200         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2201         (struct fbsd_pspace_data): New type.
2202         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2203         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2204         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2205         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2206         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2207
2208 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2209
2210         * gdbtypes.c (lookup_struct_elt): New function.
2211         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2212         * gdbtypes.h (struct struct_elt): New type.
2213         (lookup_struct_elt): New prototype.
2214
2215 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2216
2217         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2218         remove disabled code block.
2219
2220 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2221
2222         * gdbarch.sh (get_thread_local_address): New method.
2223         * gdbarch.h, gdbarch.c: Regenerate.
2224         * target.c (target_translate_tls_address): Use
2225         gdbarch_get_thread_local_address if present instead of
2226         target::get_thread_local_address.
2227
2228 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2229
2230         * target.h (target::get_thread_local_address): Update comment.
2231
2232 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2233
2234         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2235         objfile->separate_debug_objfile_backlink if not NULL.
2236
2237 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2238
2239         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2240         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2241         (amd64bsd_store_inferior_registers): Likewise.
2242         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2243         Enable segment base registers.
2244         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2245         PT_GETFSBASE and PT_GETGSBASE.
2246         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2247         PT_SETGSBASE.
2248         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2249         segment base registers.
2250         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2251
2252 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2253
2254         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2255         Update calls to i386_target_description to add 'segments'
2256         parameter.
2257         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2258         add segment base registers.
2259         * arch/i386.c (i386_create_target_description): Add 'segments'
2260         parameter to enable segment base registers.
2261         * arch/i386.h (i386_create_target_description): Likewise.
2262         * features/i386/32bit-segments.xml: New file.
2263         * features/i386/32bit-segments.c: Generate.
2264         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2265         call to i386_target_description to add 'segments' parameter.
2266         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2267         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2268         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2269         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2270         if feature is present.
2271         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2272         Add 'segments' parameter to call to i386_target_description.
2273         (i386_target_description): Add 'segments' parameter to enable
2274         segment base registers.
2275         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2276         to call to i386_target_description.
2277         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2278         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2279         Define I386_NUM_REGS.
2280         (i386_target_description): Add 'segments' parameter to enable
2281         segment base registers.
2282
2283 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2284
2285         PR/24325
2286         * source-cache.c: #undef open and close, to avoid unresolved
2287         externals during linking.
2288
2289 2019-03-12  Tom Tromey  <tromey@adacore.com>
2290
2291         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2292         const.  Add initializers.
2293         (_initialize_remote): Don't initialize ptid globals.
2294
2295 2019-03-12  Pedro Alves  <palves@redhat.com>
2296
2297         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2298
2299 2019-03-12  Pedro Alves  <palves@redhat.com>
2300
2301         * cp-name-parser.y (main): Remove unused 'len' variable.
2302
2303 2019-03-12  Tom Tromey  <tromey@adacore.com>
2304
2305         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2306         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2307
2308 2019-03-12  Tom Tromey  <tromey@adacore.com>
2309
2310         * linux-nat.c (iterate_over_lwps): Update.
2311         (stop_callback): Remove parameter.
2312         (stop_wait_callback, detach_callback, resume_set_callback)
2313         (select_singlestep_lwp_callback, set_ignore_sigint)
2314         (status_callback, resumed_callback, resume_clear_callback)
2315         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2316         data parameter.
2317         (linux_nat_target::detach, linux_nat_target::resume)
2318         (linux_stop_and_wait_all_lwps, select_event_lwp)
2319         (linux_nat_filter_event, linux_nat_wait_1)
2320         (linux_nat_target::kill, linux_nat_target::stop)
2321         (linux_nat_target::stop): Update.
2322         (linux_nat_resume_callback): Change type.
2323         (resume_stopped_resumed_lwps, count_events_callback)
2324         (select_event_lwp_callback): Likewise.
2325         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2326         * arm-linux-nat.c (struct update_registers_data): Remove.
2327         (update_registers_callback): Change type.
2328         (arm_linux_insert_hw_breakpoint1): Update.
2329         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2330         parameter.
2331         (x86_linux_dr_set_addr): Update.
2332         (x86_linux_dr_set_control): Update.
2333         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2334         (iterate_over_lwps): Use gdb::function_view.
2335         * nat/aarch64-linux-hw-point.c (struct
2336         aarch64_dr_update_callback_param): Remove.
2337         (debug_reg_change_callback): Change type.
2338         (aarch64_notify_debug_reg_change): Update.
2339         * s390-linux-nat.c (s390_refresh_per_info): Update.
2340
2341 2019-03-11  Tom Tromey  <tromey@adacore.com>
2342
2343         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2344         redundant assignment to "this_cu".
2345
2346 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2347
2348         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2349
2350 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2351
2352         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2353         from...
2354         (rank_one_type): ... this.
2355
2356 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2357
2358         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2359         from...
2360         (rank_one_type): ... this.
2361
2362 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2363
2364         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2365         from...
2366         (rank_one_type): ... this.
2367
2368 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2369
2370         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2371         from...
2372         (rank_one_type): ... this.
2373
2374 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2375
2376         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2377         from...
2378         (rank_one_type): ... this.
2379
2380 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2381
2382         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2383         from...
2384         (rank_one_type): ... this.
2385
2386 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2387
2388         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2389         from...
2390         (rank_one_type): ... this.
2391
2392 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2393
2394         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2395         from...
2396         (rank_one_type): ... this.
2397
2398 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2399
2400         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2401         from...
2402         (rank_one_type): ... this.
2403
2404 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2405
2406         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2407         from...
2408         (rank_one_type): ... this.
2409
2410 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2411
2412         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2413         from...
2414         (rank_one_type): ... this.
2415
2416 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2417
2418         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2419         from...
2420         (rank_one_type): ... this.
2421
2422 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2423
2424         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2425         inferior-events' shows the example events.
2426
2427 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2428
2429         Support styling on native MS-Windows console
2430
2431         PR/24315
2432         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2433         on MS-Windows if $TERM is not defined.
2434
2435         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2436
2437         * posix-hdep.c (gdb_console_fputs):
2438         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2439         functions.
2440         * ui-file.h (gdb_console_fputs): Add prototype.
2441
2442         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2443         back to fputs only if the former returns zero.
2444
2445 2019-03-07  Tom Tromey  <tom@tromey.com>
2446
2447         * symmisc.c (print_symbol_bcache_statistics): Update.
2448         (print_objfile_statistics): Update.
2449         * symfile.c (allocate_symtab): Update.
2450         * stabsread.c: Don't include bcache.h.
2451         * psymtab.h (struct psymbol_bcache): Don't declare.
2452         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2453         (psymbol_bcache_init, psymbol_bcache_free)
2454         (psymbol_bcache_get_bcache): Don't declare.
2455         * psymtab.c (struct psymbol_bcache): Remove.
2456         (psymtab_storage::psymtab_storage): Update.
2457         (psymtab_storage::~psymtab_storage): Update.
2458         (psymbol_bcache_init, psymbol_bcache_free)
2459         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2460         (add_psymbol_to_bcache): Update.
2461         (allocate_psymtab): Update.
2462         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2463         macro_cache>: No longer pointers.
2464         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2465         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2466         * macrotab.c (macro_bcache): Update.
2467         * macroexp.c: Don't include bcache.h.
2468         * gdbtypes.c (check_types_worklist): Update.
2469         (types_deeply_equal): Remove TRY/CATCH.  Update.
2470         * elfread.c (elf_symtab_read): Update.
2471         * dwarf2read.c: Don't include bcache.h.
2472         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2473         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2474         (print_bcache_statistics, bcache_memory_used): Don't declare.
2475         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2476         methods.  Rename all data members.
2477         * bcache.c (struct bcache): Move to bcache.h.
2478         (bcache::expand_hash_table): Rename from expand_hash_table.
2479         (bcache): Remove.
2480         (bcache::insert): Rename from bcache_full.
2481         (bcache::compare): Rename from bcache_compare.
2482         (bcache_xmalloc): Remove.
2483         (bcache::~bcache): Rename from bcache_xfree.
2484         (bcache::print_statistics): Rename from print_bcache_statistics.
2485         (bcache::memory_used): Rename from bcache_memory_used.
2486
2487 2019-03-07  Pedro Alves  <palves@redhat.com>
2488
2489         * infrun.c (normal_stop): Also check for
2490         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2491
2492 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2493
2494         * f-lang.c (value_from_host_double): Moved to...
2495         * value.c (value_from_host_double): ...here.
2496         * value.h (value_from_host_double): Declare.
2497         * guile/scm-math.c (vlscm_convert_typed_number): Use
2498         value_from_host_double.
2499         (vlscm_convert_number): Likewise.
2500         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2501         * python/py-value.c (convert_value_from_python): Likewise.
2502
2503 2019-03-06  Tom Tromey  <tom@tromey.com>
2504
2505         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2506
2507 2019-03-06  Tom Tromey  <tom@tromey.com>
2508
2509         * utils.h (free_current_contents): Don't declare.
2510         * utils.c (free_current_contents): Remove.
2511
2512 2019-03-06  Tom Tromey  <tom@tromey.com>
2513
2514         * top.c (quit_force): Update.
2515         * main.c (captured_command_loop): Update.
2516         * common/new-op.c (operator new): Update.
2517         * common/common-exceptions.c (struct catcher)
2518         <save_cleanup_chain>: Remove member.
2519         (exceptions_state_mc_init): Update.
2520         (exception_try_scope_entry): Return nullptr.
2521         (exception_try_scope_exit, exception_rethrow)
2522         (throw_exception_sjlj, throw_exception_cxx): Update.
2523         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2524         (all_cleanups, do_cleanups, discard_cleanups)
2525         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2526         (restore_cleanups, restore_final_cleanups): Don't declare.
2527         (do_final_cleanups): Remove parameter.
2528         * common/cleanups.c (cleanup_chain, make_cleanup)
2529         (make_cleanup_dtor, all_cleanups, do_cleanups)
2530         (discard_my_cleanups, discard_cleanups)
2531         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2532         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2533         (null_cleanup): Remove.
2534         (do_final_cleanups): Remove parameter.
2535
2536 2019-03-06  Tom Tromey  <tom@tromey.com>
2537
2538         * remote.c (remote_target::remote_parse_stop_reply): Use
2539         unique_xmalloc_ptr.
2540
2541 2019-03-06  Tom Tromey  <tom@tromey.com>
2542
2543         * stabsread.c (struct stabs_field_info): Rename from field_info.
2544         <list, fnlist>: Add initializers.
2545         <obstack>: New member.
2546         (read_member_functions, read_struct_fields, read_baseclasses):
2547         Allocate on obstack.  Don't use cleanups.
2548         (read_one_struct_field, read_member_functions, read_struct_fields)
2549         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2550         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2551         (read_struct_type): Update.
2552
2553 2019-03-06  Tom Tromey  <tom@tromey.com>
2554
2555         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2556         * common/filestuff.h (make_cleanup_close): Don't declare.
2557         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2558         Remove.
2559
2560 2019-03-06  Tom Tromey  <tom@tromey.com>
2561
2562         * solib-aix.c: Use make_scope_exit.
2563
2564 2019-03-06  Tom Tromey  <tom@tromey.com>
2565
2566         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2567         Use make_scope_exit.
2568
2569 2019-03-06  Tom Tromey  <tom@tromey.com>
2570
2571         * solib-svr4.c (disable_probes_interface): Remove parameter.
2572         (svr4_handle_solib_event): Use make_scope_exit.
2573
2574 2019-03-06  Tom Tromey  <tom@tromey.com>
2575
2576         * remote.c (struct stop_reply_deleter): Remove.
2577         (stop_reply_up): Update.
2578         (struct stop_reply): Derive from notif_event.  Don't typedef.
2579         <regcache>: Now a std::vector.
2580         (stop_reply_xfree): Remove.
2581         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2582         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2583         (remote_target::discard_pending_stop_replies): Use delete.
2584         (remote_target::remote_parse_stop_reply): Update.
2585         (remote_target::process_stop_reply): Update.
2586         * remote-notif.h (struct notif_event): Add virtual destructor.
2587         Remove "dtr" member.
2588         (struct notif_client) <alloc_event>: Return a unique_ptr.
2589         (notif_event_xfree): Don't declare.
2590         (notif_event_up): New typedef.
2591         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2592         (notif_event_xfree, do_notif_event_xfree): Remove.
2593         (remote_notif_state_xfree): Update.
2594
2595 2019-03-06  Tom Tromey  <tom@tromey.com>
2596
2597         * infrun.c (displaced_step_clear_cleanup): Now a
2598         forward_scope_exit type.
2599         (displaced_step_prepare_throw): Update.
2600         (displaced_step_fixup): Update.
2601
2602 2019-03-06  Tom Tromey  <tom@tromey.com>
2603
2604         * inferior.h (class inferior): Update comment.
2605         * gdbthread.h (class thread_info): Update comment.
2606
2607 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2608             Tom Tromey  <tom@tromey.com>
2609
2610         * stabsread.h (struct stab_section_list): Remove.
2611         (coffstab_build_psymtabs): Update.
2612         * dbxread.c (symbuf_sections): Now a std::vector.
2613         (sect_idx): New global.
2614         (fill_symbuf): Update.
2615         (coffstab_build_psymtabs): Change type of stabsects parameter.
2616         Update.
2617         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2618         std::vector.
2619         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2620         (coff_locate_sections): Update.
2621         (coff_symfile_read): Remove cleanups.  Update.
2622         (init_stringtab): Add storage parameter.
2623         (free_stringtab, free_stringtab_cleanup): Remove.
2624         (init_lineno): Add storage parameter.
2625         (free_linetab, free_linetab_cleanup): Remove.
2626
2627 2019-03-06  Pedro Alves  <palves@redhat.com>
2628
2629         * linux-fork.c (fork_info::clobber_regs): Delete.
2630         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2631         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2632         comment.  Adjust.
2633         (scoped_switch_fork_info::scoped_switch_fork_info)
2634         (checkpoint_command, linux_fork_context): Adjust
2635         fork_save_infrun_state calls.
2636
2637 2019-03-06  Pedro Alves  <palves@redhat.com>
2638
2639         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2640         (inf_has_multiple_threads): Return 'bool' and rewrite using
2641         inferior_info::threads().
2642
2643 2019-03-06  Pedro Alves  <palves@redhat.com>
2644
2645         * linux-fork.c: Include <list>.
2646         (fork_list): Now a std::list instance.
2647         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2648         (forks_exist_p, find_last_fork): Adjust.
2649         (new_fork): Delete.
2650         (one_fork_p): New.
2651         (add_fork): Adjust.
2652         (free_fork): Delete, folded into fork_info::~fork_info().
2653         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2654         Adjust.
2655         (init_fork_list): Delete.
2656         (linux_fork_killall, linux_fork_mourn_inferior)
2657         (linux_fork_detach, info_checkpoints_command): Adjust.
2658         (_initialize_linux_fork): No longer call init_fork_list.
2659
2660 2019-03-06  Pedro Alves  <palves@redhat.com>
2661
2662         * linux-fork.c (new_fork): New, split out of ...
2663         (add_fork): ... this.  Return void.  Move "first fork" special
2664         case from here, to ...
2665         (checkpoint_command): ... here.
2666         * linux-linux.h (add_fork): Return void.
2667
2668 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2669
2670         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2671
2672 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2673             Chris January  <chris.january@arm.com>
2674             David Lecomber  <david.lecomber@arm.com>
2675
2676         * f-exp.y: New token, UNOP_INTRINSIC.
2677         (exp): New pattern using UNOP_INTRINSIC token.
2678         (f77_keywords): Add 'abs' keyword.
2679         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2680         (value_from_host_double): New function.
2681         (evaluate_subexp_f): Support UNOP_ABS.
2682
2683 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2686         types.
2687
2688 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2689
2690         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2691         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2692         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2693
2694 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2695
2696         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2697
2698 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2699             Chris January  <chris.january@arm.com>
2700
2701         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2702         * f-exp.y: Define 'KIND' token.
2703         (exp): New pattern for KIND expressions.
2704         (ptype): Handle types with a kind extension.
2705         (direct_abs_decl): Extend to spot kind extensions.
2706         (f77_keywords): Add 'kind' to the list.
2707         (push_kind_type): New function.
2708         (convert_to_kind_type): New function.
2709         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2710         * parse.c (operator_length_standard): Likewise.
2711         * parser-defs.h (enum type_pieces): Add tp_kind.
2712         * std-operator.def: Add UNOP_KIND.
2713
2714 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2715
2716         * f-exp.y (f_parse): Set yydebug.
2717
2718 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2719
2720         * f-lang.c (evaluate_subexp_f): New function.
2721         (exp_descriptor_f): New global.
2722         (f_language_defn): Use exp_descriptor_f instead of
2723         exp_descriptor_standard.
2724
2725 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2726
2727         * f-exp.y (struct token): Add comments.
2728         (dot_ops): Remove uppercase versions and the end marker.
2729         (f77_keywords): Likewise.
2730         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2731         entries in the dot_ops array are case insensitive, and use
2732         strncasecmp to compare strings.  Also some whitespace cleanup in
2733         this area.  Similar for the f77_keywords array, except entries in
2734         this list might be case sensitive.
2735
2736 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2737
2738         * f-exp.y (struct f77_boolean_val): Add comments.
2739         (boolean_values): Remove uppercase versions, and end marker.
2740         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2741         and use strncasecmp to achieve case insensitivity.  Additionally,
2742         perform whitespace cleanup around this code.
2743
2744 2019-03-06  Tom Tromey  <tromey@adacore.com>
2745
2746         * remote-sim.c (gdbsim_target_open): Use result of
2747         gdb_argv::release.
2748
2749 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2750         Dirk Schubert  <dirk.schubert@arm.com>
2751         Chris January  <chris.january@arm.com>
2752
2753         * eval.c (evaluate_subexp_standard): Call Fortran argument
2754         wrapping logic.
2755         * f-lang.c (struct value): A value which can be passed into a
2756         Fortran function call.
2757         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2758         where appropriate.
2759         (struct type): Value ready for a Fortran function call.
2760         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2761         is needed.
2762         * f-lang.h (fortran_argument_convert): Declaration.
2763         (fortran_preserve_arg_pointer): Declaration.
2764         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2765
2766 2019-03-05  Tom Tromey  <tromey@adacore.com>
2767
2768         * python/py-prettyprint.c (print_string_repr): Remove #if.
2769         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2770
2771 2019-03-05  Tom Tromey  <tromey@adacore.com>
2772
2773         * target.c (the_dummy_target): Move later.  Change type to
2774         "dummy_target".
2775         (initialize_targets): Don't initialize the_dummy_target.
2776
2777 2019-03-05  Tom Tromey  <tromey@adacore.com>
2778
2779         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2780         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2781
2782 2019-03-05  Tom Tromey  <tromey@adacore.com>
2783
2784         * windows-nat.c (windows_nat_target::attach)
2785         (windows_nat_target::detach): Don't call gdb_flush.
2786         * valprint.c (generic_val_print, val_print, val_print_string):
2787         Don't call gdb_flush.
2788         * utils.c (defaulted_query): Don't call gdb_flush.
2789         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2790         * target.c (target_announce_detach): Don't call gdb_flush.
2791         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2792         * remote.c (extended_remote_target::attach): Don't call
2793         gdb_flush.
2794         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2795         * printcmd.c (do_examine): Don't call gdb_flush.
2796         (info_display_command): Don't call gdb_flush.
2797         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2798         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2799         * memattr.c (info_mem_command): Don't call gdb_flush.
2800         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2801         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2802         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2803         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2804         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2805         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2806         (gnu_nat_target::detach): Don't call gdb_flush.
2807         * f-valprint.c (f_val_print): Don't call gdb_flush.
2808         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2809         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2810         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2811         gdb_flush.
2812         * c-valprint.c (c_val_print): Don't call gdb_flush.
2813         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2814
2815 2019-03-05  Tom Tromey  <tromey@adacore.com>
2816
2817         * varobj.c (update_dynamic_varobj_children): Update.
2818         (install_default_visualizer): Use reset, not release.
2819         * value.c (set_internalvar): Update.
2820         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2821         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2822         ATTRIBUTE_UNUSED_RESULT.
2823
2824 2019-03-05  Tom Tromey  <tromey@adacore.com>
2825
2826         * remote.c (class scoped_remote_fd) <release>: Add
2827         ATTRIBUTE_UNUSED_RESULT.
2828
2829 2019-03-05  Tom Tromey  <tromey@adacore.com>
2830
2831         * macroexp.c (struct macro_buffer) <release>: Add
2832         ATTRIBUTE_UNUSED_RESULT.
2833
2834 2019-03-05  Tom Tromey  <tromey@adacore.com>
2835
2836         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2837         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2838         ATTRIBUTE_UNUSED_RESULT.
2839
2840 2019-03-05  Tom Tromey  <tromey@adacore.com>
2841
2842         * common/scoped_fd.h (class scoped_fd) <release>: Add
2843         ATTRIBUTE_UNUSED_RESULT.
2844
2845 2019-03-05  Tom Tromey  <tromey@adacore.com>
2846
2847         * parser-defs.h (struct parser_state) <release>: Add
2848         ATTRIBUTE_UNUSED_RESULT.
2849
2850 2019-03-05  Tom Tromey  <tromey@adacore.com>
2851
2852         * utils.h (class gdb_argv) <release>: Add
2853         ATTRIBUTE_UNUSED_RESULT.
2854         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2855
2856 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2857
2858         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2859         for-loop range, to avoid compiler warnings.
2860
2861         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2862         avoid compiler warnings about unused variables.
2863
2864         * NEWS: Mention end of support for native debugging on MS-Windows
2865         before XP.
2866
2867         PR gdb/24292
2868         * common/netstuff.c:
2869         * gdbserver/gdbreplay.c
2870         * gdbserver/remote-utils.c:
2871         * ser-tcp.c:
2872         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2873         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2874         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2875         'getaddrinfo' and 'freeaddrinfo' were not available before
2876         Windows XP, and mingw.org's MinGW headers by default define
2877         _WIN32_WINNT to 0x500.
2878
2879 2019-03-01  Gary Benson <gbenson@redhat.com>
2880
2881         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2882
2883 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2884             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2885
2886         PR gdb/8527
2887         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2888         set_sigint_trap, clear_sigint_trap.
2889
2890 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2891
2892         * target.c (target_detach): Clear the regcache and the
2893         frame cache.
2894
2895 2019-02-27  Pedro Alves  <palves@redhat.com>
2896
2897         * utils.c (set_screen_size): When we cap the height/width sizes,
2898         tweak the corresponding command variable to show "unlimited":
2899
2900 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2901             Pedro Alves  <palves@redhat.com>
2902
2903         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2904         before calling rl_set_screen_size.
2905
2906 2019-02-27  Tom Tromey  <tromey@adacore.com>
2907
2908         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2909         define.
2910         * python/py-value.c: Remove Python 2.4 workaround.
2911         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2912         workaround.
2913         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2914         Python 2.4 workaround.
2915         * python/python-internal.h: Remove Python 2.4 comment.
2916         (Py_ssize_t): Don't define.
2917         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2918         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2919         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2920         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2921         * python/python.c (do_start_initialization): Remove Python 2.4
2922         workaround.
2923         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2924         (print_children): Remove Python 2.4 workaround.
2925         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2926         workaround.
2927         (CHARBUFFERPROC_NAME): Remove.
2928         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2929         Python 2.4 workaround.
2930
2931 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2932
2933         * NEWS: Note minimum Python version.
2934
2935 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2936
2937         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2938         code from these functions.  Remove corresponding ifdefs.  Use
2939         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2940         Remove gotos and target of gotos.
2941         (infpy_search_memory): Likewise.
2942
2943 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2944
2945         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2946         (hppa_gdbarch_init): Don't register deleted functions with
2947         gdbarch.
2948
2949 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2950
2951         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2952         (h8300_unwind_sp): Delete.
2953         (h8300_dummy_id): Delete.
2954         (h8300_gdbarch_init): Don't register deleted functions with
2955         gdbarch.
2956
2957 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2958
2959         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2960         (ft32_unwind_pc): Delete.
2961         (ft32_unwind_sp): Delete.
2962         (ft32_gdbarch_init): Don't register deleted functions with
2963         gdbarch.
2964
2965 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2966
2967         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2968         (frv_unwind_pc): Delete.
2969         (frv_unwind_sp): Delete.
2970         (frv_gdbarch_init): Don't register deleted functions with
2971         gdbarch.
2972
2973 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2974
2975         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2976         (riscv_unwind_pc): Delete.
2977         (riscv_unwind_sp): Delete.
2978         (riscv_gdbarch_init): Don't register deleted functions with
2979         gdbarch.
2980
2981 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2982
2983         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2984         (csky_unwind_pc): Delete.
2985         (csky_unwind_sp): Delete.
2986         (csky_gdbarch_init): Don't register deleted functions with
2987         gdbarch.
2988
2989 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2990
2991         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2992         (cris_unwind_pc): Delete.
2993         (cris_unwind_sp): Delete.
2994         (cris_gdbarch_init): Don't register deleted functions with
2995         gdbarch.
2996
2997 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2998
2999         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3000         (bfin_unwind_pc): Delete.
3001         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3002
3003 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3004
3005         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3006         (arm_unwind_pc): Delete.
3007         (arm_unwind_sp): Delete.
3008         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3009
3010 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3011
3012         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3013         (arc_unwind_pc): Delete.
3014         (arc_unwind_sp): Delete.
3015         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3016
3017 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3018
3019         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3020         (alpha_unwind_pc): Delete.
3021         (alpha_gdbarch_init): Don't register deleted functions with
3022         gdbarch.
3023
3024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3025
3026         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3027         (aarch64_unwind_pc): Delete.
3028         (aarch64_unwind_sp): Delete.
3029         (aarch64_gdbarch_init): Don't register deleted functions with
3030         gdbarch.
3031
3032 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3033
3034         * gdbtypes.c (type_align): Don't consider static members when
3035         computing structure alignment.
3036
3037 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3038
3039         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3040         return 0 for other types.
3041         * arch-utils.c (default_type_align): Always return 0.
3042         * gdbarch.h: Regenerate.
3043         * gdbarch.sh (type_align): Extend comment.
3044         * gdbtypes.c (type_align): Add additional comments, always call
3045         gdbarch_type_align before applying the default rules.
3046         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3047         generic code will then apply a suitable default.
3048         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3049         types, return 0 for other types.
3050
3051 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3052
3053         * NEWS: Create a new section for the next release branch.
3054         Rename the section of the current branch, now that it has
3055         been cut.
3056
3057 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3058
3059         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3060         * version.in: Bump version to 8.3.50.DATE-git.
3061
3062 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3063
3064         * aix-thread.c (ptid_cmp): Remove unused variable.
3065         (get_signaled_thread): Likewise.
3066         (store_regs_user_thread): Likewise.
3067         (store_regs_kernel_thread): Likewise.
3068         (fetch_regs_kernel_thread): Remove shadowed variable.
3069
3070 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3071
3072         * features/riscv/32bit-cpu.xml: Add register numbers.
3073         * features/riscv/32bit-fpu.c: Regenerate.
3074         * features/riscv/32bit-fpu.xml: Add register numbers.
3075         * features/riscv/64bit-cpu.xml: Add register numbers.
3076         * features/riscv/64bit-fpu.c: Regenerate.
3077         * features/riscv/64bit-fpu.xml: Add register numbers.
3078
3079 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3080
3081         * NEWS: Mention two argument form of gdb.Value constructor.
3082         * python/py-value.c (convert_buffer_and_type_to_value): New
3083         function.
3084         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3085         Add support for handling an optional second argument.  Call
3086         convert_buffer_and_type_to_value as appropriate.
3087         * python/python-internal.h (Py_buffer_deleter): New struct.
3088         (Py_buffer_up): New typedef.
3089
3090 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3091
3092         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3093         instead of releasing ownership.
3094
3095 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3096
3097         * dwarf2read.c (open_and_init_dwp_file): Call
3098         elf_numsections instead of bfd_count_sections to initialize
3099         dwp_file->num_sections.
3100
3101 2019-02-25  Tom Tromey  <tromey@adacore.com>
3102
3103         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3104
3105 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3106
3107         * gcore.in: Add '--readnever' option when invoking GDB.
3108
3109 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3110
3111         * MAINTAINERS: Update my email address.
3112
3113 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3114
3115         * build-id.c (build_id_to_debug_bfd_1): New function.
3116         (build_id_to_debug_bfd): Look for separate debug file in
3117         sysroot.
3118
3119 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3120
3121         * gdbarch.sh: Update the copyright year range that is placed into
3122         generated files.
3123
3124 2019-02-22  Keith Seitz  <keiths@redhat.com>
3125
3126         PR symtab/23853
3127         * linespec.c (create_sals_line_offset): Search for the default
3128         symtab's filename instead of its fullname.
3129
3130 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3131
3132         * NEWS: Update style defaults.
3133
3134 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3135
3136         * main.c (captured_main_1): Disable styling in batch mode.
3137
3138 2019-02-20  Tom Tromey  <tom@tromey.com>
3139
3140         * symtab.c (symtab_symbol_info): Fix typos.
3141
3142 2019-02-20  Tom Tromey  <tromey@adacore.com>
3143
3144         * findcmd.c (_initialize_mem_search): Use upper case for
3145         metasyntactic variables.
3146
3147 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3148
3149         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3150         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3151
3152 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3153
3154         * top.h (source_file_name): Change to std::string.
3155         * top.c (source_file_name): Likewise.
3156         (command_line_input): Adjust.
3157         * cli/cli-script.c (script_from_file): Adjust.
3158
3159 2019-02-19  Tom Tromey  <tromey@adacore.com>
3160
3161         * ravenscar-thread.c
3162         (ravenscar_thread_target::update_thread_list): Don't call
3163         ada_build_task_list.
3164         * ada-lang.h (ada_build_task_list): Don't declare.
3165         * ada-tasks.c (struct ada_tasks_inferior_data)
3166         <task_list_valid_p>: Now bool.
3167         (read_known_tasks, ada_task_list_changed)
3168         (ada_tasks_invalidate_inferior_data): Update.
3169         (read_known_tasks_array): Return bool.
3170         (read_known_tasks_list): Likewise.
3171         (read_known_tasks): Return void.
3172         (ada_build_task_list): Now static.
3173
3174 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3175
3176         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3177         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3178
3179 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3180
3181         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3182         variant for ada_tasks_pspace_data_handle and
3183         ada_tasks_inferior_data_handle.
3184         (ada_tasks_pspace_data_cleanup): New function.
3185         (ada_tasks_inferior_data_cleanup): New function.
3186
3187 2019-02-17  Tom Tromey  <tom@tromey.com>
3188
3189         * macrotab.h (macro_source_fullname): Return a std::string.
3190         * macrotab.c (macro_include, check_for_redefinition)
3191         (macro_undef, macro_lookup_definition, foreach_macro)
3192         (foreach_macro_in_scope): Update.
3193         (macro_source_fullname): Return a std::string.
3194         * macrocmd.c (show_pp_source_pos): Update.
3195
3196 2019-02-17  Tom Tromey  <tom@tromey.com>
3197
3198         * macrocmd.c (show_pp_source_pos): Style the file names.
3199
3200 2019-02-17  Tom Tromey  <tom@tromey.com>
3201
3202         PR tui/24197:
3203         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3204
3205 2019-02-17  Tom Tromey  <tom@tromey.com>
3206
3207         * ada-lang.c (user_select_syms): Use filtered printing.
3208         * utils.c (wrap_style): New global.
3209         (desired_style): Remove.
3210         (emit_style_escape): Add stream parameter.
3211         (set_output_style, reset_terminal_style, prompt_for_continue):
3212         Update.
3213         (flush_wrap_buffer): Only flush gdb_stdout.
3214         (wrap_here): Set wrap_style.
3215         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3216         treat escape sequences as a character.  Change when wrap buffer is
3217         flushed.
3218         (fputs_styled): Do not set the output style when the default is
3219         requested.
3220         * ui-style.h (struct ui_file_style) <is_default>: New method.
3221         * source.c (print_source_lines_base): Emit escape sequences in one
3222         piece.
3223
3224 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3225
3226         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3227         integers and enumeration types.
3228
3229 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3230
3231         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3232         instead of lookup_symbol_in_language
3233         (do_exact_match): New function.
3234         (ada_get_symbol_name_matcher): Return do_exact_match when
3235         doing a verbatim match.
3236
3237 2019-02-15  Tom Tromey  <tromey@adacore.com>
3238
3239         * ravenscar-thread.c (ravenscar_thread_target::resume)
3240         (ravenscar_thread_target::wait): Special case wildcard requests.
3241
3242 2019-02-15  Tom Tromey  <tromey@adacore.com>
3243
3244         * ravenscar-thread.c (base_ptid): Remove.
3245         (struct ravenscar_thread_target) <close>: New method.
3246         <m_base_ptid>: New member.
3247         <update_inferior_ptid, active_task, task_is_currently_active,
3248         runtime_initialized>: Declare methods.
3249         <ravenscar_thread_target>: Add constructor.
3250         (ravenscar_thread_target::task_is_currently_active)
3251         (ravenscar_thread_target::update_inferior_ptid)
3252         (ravenscar_runtime_initialized): Rename.  Now methods.
3253         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3254         (ravenscar_thread_target::update_thread_list): Update.
3255         (ravenscar_thread_target::active_task): Now method.
3256         (ravenscar_thread_target::store_registers)
3257         (ravenscar_thread_target::prepare_to_store)
3258         (ravenscar_thread_target::prepare_to_store)
3259         (ravenscar_thread_target::mourn_inferior): Update.
3260         (ravenscar_inferior_created): Use "new" to create target.
3261         (ravenscar_thread_target::get_ada_task_ptid): Update.
3262         (_initialize_ravenscar): Don't initialize base_ptid.
3263         (ravenscar_ops): Remove global.
3264
3265 2019-02-15  Tom Tromey  <tromey@adacore.com>
3266
3267         * target.h (push_target): Declare new overload.
3268         * target.c (push_target): New overload, taking an rvalue reference.
3269         * remote.c (remote_target::open_1): Use push_target overload.
3270         * corelow.c (core_target_open): Use push_target overload.
3271
3272 2019-02-15  Tom Tromey  <tromey@adacore.com>
3273
3274         * ravenscar-thread.c (is_ravenscar_task)
3275         (ravenscar_task_is_currently_active): Return bool.
3276         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3277         (_initialize_ravenscar): Remove "(void)".
3278         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3279         Return bool.
3280
3281 2019-02-15  Tom Tromey  <tromey@adacore.com>
3282
3283         * ravenscar-thread.c (ravenscar_runtime_initializer)
3284         (has_ravenscar_runtime, get_running_thread_id)
3285         (ravenscar_thread_target::resume): Fix indentation.
3286
3287 2019-02-15  Tom Tromey  <tromey@adacore.com>
3288
3289         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3290         from ravenscar_arch_ops.
3291         (sparc_ravenscar_ops::fetch_registers)
3292         (sparc_ravenscar_ops::store_registers): Now methods.
3293         (sparc_ravenscar_prepare_to_store): Remove.
3294         (sparc_ravenscar_ops): Redefine.
3295         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3296         methods and destructor.  Remove members.
3297         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3298         (ravenscar_thread_target::store_registers)
3299         (ravenscar_thread_target::prepare_to_store): Update.
3300         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3301         Remove.
3302         (struct ppc_ravenscar_powerpc_ops): Derive from
3303         ravenscar_arch_ops.
3304         (ppc_ravenscar_powerpc_ops::fetch_registers)
3305         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3306         (ppc_ravenscar_powerpc_ops): Redefine.
3307         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3308         (ppc_ravenscar_e500_ops::fetch_registers)
3309         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3310         (ppc_ravenscar_e500_ops): Redefine.
3311         * aarch64-ravenscar-thread.c
3312         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3313         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3314         (aarch64_ravenscar_fetch_registers)
3315         (aarch64_ravenscar_store_registers): Now methods.
3316         (aarch64_ravenscar_ops): Redefine.
3317
3318 2019-02-15  Tom Tromey  <tromey@adacore.com>
3319
3320         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3321         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3322         (ravenscar_thread_target::stopped_by_watchpoint)
3323         (ravenscar_thread_target::stopped_data_address)
3324         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3325
3326 2019-02-15  Tom Tromey  <tromey@adacore.com>
3327
3328         * ravenscar-thread.c: Fix some typos.
3329
3330 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3331             Tom Tromey  <tromey@adacore.com>
3332
3333         * ada-lang.c (ada_exception_sal): Change addr_string to a
3334         std::string.
3335         (create_ada_exception_catchpoint): Update.
3336
3337 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3338             Tom Tromey  <tromey@adacore.com>
3339
3340         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3341         (bp_location_ops): Remove.
3342         (base_breakpoint_allocate_location): Update.
3343         (free_bp_location): Update.
3344         * ada-lang.c (class ada_catchpoint_location)
3345         <ada_catchpoint_location>: Remove ops parameter.
3346         (ada_catchpoint_location_dtor): Remove.
3347         (ada_catchpoint_location_ops): Remove.
3348         (allocate_location_exception): Update.
3349         * breakpoint.h (struct bp_location_ops): Remove.
3350         (class bp_location) <bp_location>: Remove bp_location_ops
3351         parameter.
3352         <~bp_location>: Add destructor.
3353         <ops>: Remove.
3354
3355 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3356             Pedro Alves  <palves@redhat.com>
3357
3358         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3359         'PATH_MAX'.
3360
3361 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3362             Samuel Thibault  <samuel.thibault@gnu.org>
3363             Thomas Schwinge  <thomas@codesourcery.com>
3364
3365         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3366         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3367
3368 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3369
3370         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3371         (check_empty): Use "const char *".
3372
3373         * gnu-nat.c (gnu_nat_target::detach): Instead of
3374         'detach_inferior (pid)' call
3375         'detach_inferior (find_inferior_pid (pid))'.
3376
3377         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3378         'nat/fork-inferior.o'.
3379         * gnu-nat.c: #include "nat/fork-inferior.h".
3380
3381         * gnu-nat.c (gnu_nat_target::detach): Instead of
3382         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3383         * gnu-nat.h: #include "inf-child.h".
3384         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3385         'i386_gnu_nat_target::fetch_registers'.
3386         (gnu_store_registers): Rename/move to
3387         'i386_gnu_nat_target::store_registers'.
3388
3389         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3390         * gnu-nat.h (mach_thread_info): New function.
3391         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3392
3393         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3394
3395 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3396
3397         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3398
3399 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3400
3401         * windows-nat.c (windows_add_thread): Add new parameter
3402         "main_thread_p" with default value set to false.  Update
3403         function documentation as well as all callers.
3404         (windows_delete_thread): Likewise.
3405         (fake_create_process): Update call to windows_add_thread.
3406         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3407         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3408         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3409         call to windows_delete_thread.
3410
3411 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3412
3413         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3414
3415 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3416
3417         * symfile.c (find_separate_debug_file): Use canonical path of
3418         sysroot with child_path instead of gdb_sysroot if it is valid.
3419
3420 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3421
3422         * symfile.c (find_separate_debug_file): Use child_path to
3423         determine if an object file is under a sysroot.
3424
3425 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3426
3427         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3428         unittests/child-path-selftests.c.
3429         * common/pathstuff.c (child_path): New function.
3430         * common/pathstuff.h (child_path): New prototype.
3431         * unittests/child-path-selftests.c: New file.
3432
3433 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3434
3435         * symfile.c (find_separate_debug_file): Look for separate debug
3436         files in debug directories under the sysroot.
3437
3438 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3439
3440         * symtab.h (struct minimal_symbol data_p): New const method.
3441         (struct minimal_symbol text_p): Likewise.
3442         * symtab.c (output_source_filename): Use file name style
3443         to print file name.
3444         (print_symbol_info): Likewise.
3445         (print_msymbol_info): Use address style to print addresses.
3446         Use function name style to print executable text symbols.
3447         (expand_symtab_containing_pc): Use data_p.
3448         (find_pc_sect_compunit_symtab): Likewise.
3449
3450 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3451
3452         * breakpoint.c (describe_other_breakpoints): Use address style
3453         to print addresses.
3454         (say_where): Likewise.
3455
3456 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3457
3458         * ada-typeprint.c (print_func_type): Print function name
3459         style to print function name.
3460         * c-typeprint.c (c_print_type_1): Likewise.
3461
3462 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3463
3464         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3465         for execve.
3466
3467 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3468
3469         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3470         type_stack.
3471
3472 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3473
3474         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3475         TYPE_CODE_REF types.
3476
3477 2019-02-08  Jim Wilson  <jimw@sifive.com>
3478
3479         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3480         (riscv_linux_fregset): New.
3481         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3482
3483 2019-02-07  Tom Tromey  <tom@tromey.com>
3484
3485         * thread.c (thread_cancel_execution_command): Update.
3486         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3487         methods.
3488         (struct thread_fsm_ops): Remove.
3489         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3490         (thread_fsm_should_stop, thread_fsm_return_value)
3491         (thread_fsm_set_finished, thread_fsm_finished_p)
3492         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3493         Don't declare.
3494         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3495         * infrun.c (clear_proceed_status_thread)
3496         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3497         (print_stop_event): Update.
3498         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3499         Add constructor.
3500         (step_command_fsm_ops): Remove.
3501         (new_step_command_fsm): Remove.
3502         (step_1): Update.
3503         (step_command_fsm::should_stop): Rename from
3504         step_command_fsm_should_stop.
3505         (step_command_fsm::clean_up): Rename from
3506         step_command_fsm_clean_up.
3507         (step_command_fsm::do_async_reply_reason): Rename from
3508         step_command_fsm_async_reply_reason.
3509         (struct until_next_fsm): Inherit from thread_fsm.  Add
3510         constructor.
3511         (until_next_fsm_ops): Remove.
3512         (new_until_next_fsm): Remove.
3513         (until_next_fsm::should_stop): Rename from
3514         until_next_fsm_should_stop.
3515         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3516         (until_next_fsm::do_async_reply_reason): Rename from
3517         until_next_fsm_async_reply_reason.
3518         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3519         constructor.  Change type of breakpoint.
3520         (finish_command_fsm_ops): Remove.
3521         (new_finish_command_fsm): Remove.
3522         (finish_command_fsm::should_stop): Rename from
3523         finish_command_fsm_should_stop.
3524         (finish_command_fsm::clean_up): Rename from
3525         finish_command_fsm_clean_up.
3526         (finish_command_fsm::return_value): Rename from
3527         finish_command_fsm_return_value.
3528         (finish_command_fsm::do_async_reply_reason): Rename from
3529         finish_command_fsm_async_reply_reason.
3530         (finish_command): Update.
3531         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3532         Add constructor.
3533         (call_thread_fsm_ops): Remove.
3534         (call_thread_fsm::call_thread_fsm): Rename from
3535         new_call_thread_fsm.
3536         (call_thread_fsm::should_stop): Rename from
3537         call_thread_fsm_should_stop.
3538         (call_thread_fsm::should_notify_stop): Rename from
3539         call_thread_fsm_should_notify_stop.
3540         (run_inferior_call, call_function_by_hand_dummy): Update.
3541         * cli/cli-interp.c (should_print_stop_to_console): Update.
3542         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3543         Add constructor.  Change type of location_breakpoint,
3544         caller_breakpoint.
3545         (until_break_fsm_ops): Remove.
3546         (new_until_break_fsm): Remove.
3547         (until_break_fsm::should_stop): Rename from
3548         until_break_fsm_should_stop.
3549         (until_break_fsm::clean_up): Rename from
3550         until_break_fsm_clean_up.
3551         (until_break_fsm::do_async_reply_reason): Rename from
3552         until_break_fsm_async_reply_reason.
3553         (until_break_command): Update.
3554         * thread-fsm.c: Remove.
3555         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3556
3557 2019-02-07  Tom Tromey  <tom@tromey.com>
3558
3559         * yy-remap.h: Add include guard.
3560         * xtensa-tdep.h: Add include guard.
3561         * xcoffread.h: Rename include guard.
3562         * varobj-iter.h: Add include guard.
3563         * tui/tui.h: Rename include guard.
3564         * tui/tui-winsource.h: Rename include guard.
3565         * tui/tui-wingeneral.h: Rename include guard.
3566         * tui/tui-windata.h: Rename include guard.
3567         * tui/tui-win.h: Rename include guard.
3568         * tui/tui-stack.h: Rename include guard.
3569         * tui/tui-source.h: Rename include guard.
3570         * tui/tui-regs.h: Rename include guard.
3571         * tui/tui-out.h: Rename include guard.
3572         * tui/tui-layout.h: Rename include guard.
3573         * tui/tui-io.h: Rename include guard.
3574         * tui/tui-hooks.h: Rename include guard.
3575         * tui/tui-file.h: Rename include guard.
3576         * tui/tui-disasm.h: Rename include guard.
3577         * tui/tui-data.h: Rename include guard.
3578         * tui/tui-command.h: Rename include guard.
3579         * tic6x-tdep.h: Add include guard.
3580         * target/waitstatus.h: Rename include guard.
3581         * target/wait.h: Rename include guard.
3582         * target/target.h: Rename include guard.
3583         * target/resume.h: Rename include guard.
3584         * target-float.h: Rename include guard.
3585         * stabsread.h: Add include guard.
3586         * rs6000-tdep.h: Add include guard.
3587         * riscv-fbsd-tdep.h: Add include guard.
3588         * regformats/regdef.h: Rename include guard.
3589         * record.h: Rename include guard.
3590         * python/python.h: Rename include guard.
3591         * python/python-internal.h: Rename include guard.
3592         * python/py-stopevent.h: Rename include guard.
3593         * python/py-ref.h: Rename include guard.
3594         * python/py-record.h: Rename include guard.
3595         * python/py-record-full.h: Rename include guard.
3596         * python/py-record-btrace.h: Rename include guard.
3597         * python/py-instruction.h: Rename include guard.
3598         * python/py-events.h: Rename include guard.
3599         * python/py-event.h: Rename include guard.
3600         * procfs.h: Add include guard.
3601         * proc-utils.h: Add include guard.
3602         * p-lang.h: Add include guard.
3603         * or1k-tdep.h: Rename include guard.
3604         * observable.h: Rename include guard.
3605         * nto-tdep.h: Rename include guard.
3606         * nat/x86-linux.h: Rename include guard.
3607         * nat/x86-linux-dregs.h: Rename include guard.
3608         * nat/x86-gcc-cpuid.h: Add include guard.
3609         * nat/x86-dregs.h: Rename include guard.
3610         * nat/x86-cpuid.h: Rename include guard.
3611         * nat/ppc-linux.h: Rename include guard.
3612         * nat/mips-linux-watch.h: Rename include guard.
3613         * nat/linux-waitpid.h: Rename include guard.
3614         * nat/linux-ptrace.h: Rename include guard.
3615         * nat/linux-procfs.h: Rename include guard.
3616         * nat/linux-osdata.h: Rename include guard.
3617         * nat/linux-nat.h: Rename include guard.
3618         * nat/linux-namespaces.h: Rename include guard.
3619         * nat/linux-btrace.h: Rename include guard.
3620         * nat/glibc_thread_db.h: Rename include guard.
3621         * nat/gdb_thread_db.h: Rename include guard.
3622         * nat/gdb_ptrace.h: Rename include guard.
3623         * nat/fork-inferior.h: Rename include guard.
3624         * nat/amd64-linux-siginfo.h: Rename include guard.
3625         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3626         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3627         * nat/aarch64-linux.h: Rename include guard.
3628         * nat/aarch64-linux-hw-point.h: Rename include guard.
3629         * mn10300-tdep.h: Add include guard.
3630         * mips-linux-tdep.h: Add include guard.
3631         * mi/mi-parse.h: Rename include guard.
3632         * mi/mi-out.h: Rename include guard.
3633         * mi/mi-main.h: Rename include guard.
3634         * mi/mi-interp.h: Rename include guard.
3635         * mi/mi-getopt.h: Rename include guard.
3636         * mi/mi-console.h: Rename include guard.
3637         * mi/mi-common.h: Rename include guard.
3638         * mi/mi-cmds.h: Rename include guard.
3639         * mi/mi-cmd-break.h: Rename include guard.
3640         * m2-lang.h: Add include guard.
3641         * location.h: Rename include guard.
3642         * linux-record.h: Rename include guard.
3643         * linux-nat.h: Add include guard.
3644         * linux-fork.h: Add include guard.
3645         * i386-darwin-tdep.h: Rename include guard.
3646         * hppa-linux-offsets.h: Add include guard.
3647         * guile/guile.h: Rename include guard.
3648         * guile/guile-internal.h: Rename include guard.
3649         * gnu-nat.h: Rename include guard.
3650         * gdb-stabs.h: Rename include guard.
3651         * frv-tdep.h: Add include guard.
3652         * f-lang.h: Add include guard.
3653         * event-loop.h: Add include guard.
3654         * darwin-nat.h: Rename include guard.
3655         * cp-abi.h: Rename include guard.
3656         * config/sparc/nm-sol2.h: Rename include guard.
3657         * config/nm-nto.h: Rename include guard.
3658         * config/nm-linux.h: Add include guard.
3659         * config/i386/nm-i386gnu.h: Rename include guard.
3660         * config/djgpp/nl_types.h: Rename include guard.
3661         * config/djgpp/langinfo.h: Rename include guard.
3662         * compile/gcc-cp-plugin.h: Add include guard.
3663         * compile/gcc-c-plugin.h: Add include guard.
3664         * compile/compile.h: Rename include guard.
3665         * compile/compile-object-run.h: Rename include guard.
3666         * compile/compile-object-load.h: Rename include guard.
3667         * compile/compile-internal.h: Rename include guard.
3668         * compile/compile-cplus.h: Rename include guard.
3669         * compile/compile-c.h: Rename include guard.
3670         * common/xml-utils.h: Rename include guard.
3671         * common/x86-xstate.h: Rename include guard.
3672         * common/version.h: Rename include guard.
3673         * common/vec.h: Rename include guard.
3674         * common/tdesc.h: Rename include guard.
3675         * common/selftest.h: Rename include guard.
3676         * common/scoped_restore.h: Rename include guard.
3677         * common/scoped_mmap.h: Rename include guard.
3678         * common/scoped_fd.h: Rename include guard.
3679         * common/safe-iterator.h: Rename include guard.
3680         * common/run-time-clock.h: Rename include guard.
3681         * common/refcounted-object.h: Rename include guard.
3682         * common/queue.h: Rename include guard.
3683         * common/ptid.h: Rename include guard.
3684         * common/print-utils.h: Rename include guard.
3685         * common/preprocessor.h: Rename include guard.
3686         * common/pathstuff.h: Rename include guard.
3687         * common/observable.h: Rename include guard.
3688         * common/netstuff.h: Rename include guard.
3689         * common/job-control.h: Rename include guard.
3690         * common/host-defs.h: Rename include guard.
3691         * common/gdb_wait.h: Rename include guard.
3692         * common/gdb_vecs.h: Rename include guard.
3693         * common/gdb_unlinker.h: Rename include guard.
3694         * common/gdb_unique_ptr.h: Rename include guard.
3695         * common/gdb_tilde_expand.h: Rename include guard.
3696         * common/gdb_sys_time.h: Rename include guard.
3697         * common/gdb_string_view.h: Rename include guard.
3698         * common/gdb_splay_tree.h: Rename include guard.
3699         * common/gdb_setjmp.h: Rename include guard.
3700         * common/gdb_ref_ptr.h: Rename include guard.
3701         * common/gdb_optional.h: Rename include guard.
3702         * common/gdb_locale.h: Rename include guard.
3703         * common/gdb_assert.h: Rename include guard.
3704         * common/filtered-iterator.h: Rename include guard.
3705         * common/filestuff.h: Rename include guard.
3706         * common/fileio.h: Rename include guard.
3707         * common/environ.h: Rename include guard.
3708         * common/common-utils.h: Rename include guard.
3709         * common/common-types.h: Rename include guard.
3710         * common/common-regcache.h: Rename include guard.
3711         * common/common-inferior.h: Rename include guard.
3712         * common/common-gdbthread.h: Rename include guard.
3713         * common/common-exceptions.h: Rename include guard.
3714         * common/common-defs.h: Rename include guard.
3715         * common/common-debug.h: Rename include guard.
3716         * common/cleanups.h: Rename include guard.
3717         * common/buffer.h: Rename include guard.
3718         * common/btrace-common.h: Rename include guard.
3719         * common/break-common.h: Rename include guard.
3720         * cli/cli-utils.h: Rename include guard.
3721         * cli/cli-style.h: Rename include guard.
3722         * cli/cli-setshow.h: Rename include guard.
3723         * cli/cli-script.h: Rename include guard.
3724         * cli/cli-interp.h: Rename include guard.
3725         * cli/cli-decode.h: Rename include guard.
3726         * cli/cli-cmds.h: Rename include guard.
3727         * charset-list.h: Add include guard.
3728         * buildsym-legacy.h: Rename include guard.
3729         * bfin-tdep.h: Add include guard.
3730         * ax.h: Rename include guard.
3731         * arm-linux-tdep.h: Add include guard.
3732         * arm-fbsd-tdep.h: Add include guard.
3733         * arch/xtensa.h: Rename include guard.
3734         * arch/tic6x.h: Add include guard.
3735         * arch/i386.h: Add include guard.
3736         * arch/arm.h: Rename include guard.
3737         * arch/arm-linux.h: Rename include guard.
3738         * arch/arm-get-next-pcs.h: Rename include guard.
3739         * arch/amd64.h: Add include guard.
3740         * arch/aarch64-insn.h: Rename include guard.
3741         * arch-utils.h: Rename include guard.
3742         * annotate.h: Add include guard.
3743         * amd64-darwin-tdep.h: Rename include guard.
3744         * aarch64-linux-tdep.h: Add include guard.
3745         * aarch64-fbsd-tdep.h: Add include guard.
3746         * aarch32-linux-nat.h: Add include guard.
3747
3748 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3749
3750         * macrotab.c (macro_define_internal): New function that
3751         factorizes macro_define_object_internal and macro_define_function
3752         code.
3753         (macro_define_object_internal): Use macro_define_internal.
3754         (macro_define_function): Likewise.
3755
3756 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3757
3758         * macrocmd.c (extract_identifier): Return
3759         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3760         callers.
3761
3762 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3763
3764         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3765
3766 2019-02-05  Tom Tromey  <tom@tromey.com>
3767
3768         * target.c (target_stack::unpush): Move assertion earlier.
3769
3770 2019-01-30  Tom Tromey  <tom@tromey.com>
3771
3772         PR python/23615:
3773         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3774         (gdbpy_parse_and_eval): Likewise.
3775         * python/python-internal.h (gdbpy_allow_threads): New class.
3776
3777 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3778
3779         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3780         (aarch64_fbsd_fpregmap): Move earlier.
3781         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3782         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3783         instead of individual calls to trad_frame_set_reg_addr.
3784         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3785         earlier.
3786         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3787         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3788         instead of individual calls to trad_frame_set_reg_addr.
3789
3790 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3791
3792         * CONTRIBUTE: Replace contribution list with wiki link.
3793
3794 2019-01-25  Tom Tromey  <tom@tromey.com>
3795
3796         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3797
3798 2019-01-25  Tom Tromey  <tom@tromey.com>
3799
3800         * xtensa-linux-nat.c: Fix common/ includes.
3801         * xml-support.h: Fix common/ includes.
3802         * xml-support.c: Fix common/ includes.
3803         * x86-linux-nat.c: Fix common/ includes.
3804         * windows-nat.c: Fix common/ includes.
3805         * varobj.h: Fix common/ includes.
3806         * varobj.c: Fix common/ includes.
3807         * value.c: Fix common/ includes.
3808         * valops.c: Fix common/ includes.
3809         * utils.c: Fix common/ includes.
3810         * unittests/xml-utils-selftests.c: Fix common/ includes.
3811         * unittests/utils-selftests.c: Fix common/ includes.
3812         * unittests/unpack-selftests.c: Fix common/ includes.
3813         * unittests/tracepoint-selftests.c: Fix common/ includes.
3814         * unittests/style-selftests.c: Fix common/ includes.
3815         * unittests/string_view-selftests.c: Fix common/ includes.
3816         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3817         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3818         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3819         * unittests/rsp-low-selftests.c: Fix common/ includes.
3820         * unittests/parse-connection-spec-selftests.c: Fix common/
3821         includes.
3822         * unittests/optional-selftests.c: Fix common/ includes.
3823         * unittests/offset-type-selftests.c: Fix common/ includes.
3824         * unittests/observable-selftests.c: Fix common/ includes.
3825         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3826         * unittests/memrange-selftests.c: Fix common/ includes.
3827         * unittests/memory-map-selftests.c: Fix common/ includes.
3828         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3829         * unittests/function-view-selftests.c: Fix common/ includes.
3830         * unittests/environ-selftests.c: Fix common/ includes.
3831         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3832         * unittests/common-utils-selftests.c: Fix common/ includes.
3833         * unittests/cli-utils-selftests.c: Fix common/ includes.
3834         * unittests/array-view-selftests.c: Fix common/ includes.
3835         * ui-file.c: Fix common/ includes.
3836         * tui/tui-io.c: Fix common/ includes.
3837         * tracepoint.h: Fix common/ includes.
3838         * tracepoint.c: Fix common/ includes.
3839         * tracefile-tfile.c: Fix common/ includes.
3840         * top.h: Fix common/ includes.
3841         * top.c: Fix common/ includes.
3842         * thread.c: Fix common/ includes.
3843         * target/waitstatus.h: Fix common/ includes.
3844         * target/waitstatus.c: Fix common/ includes.
3845         * target.h: Fix common/ includes.
3846         * target.c: Fix common/ includes.
3847         * target-memory.c: Fix common/ includes.
3848         * target-descriptions.c: Fix common/ includes.
3849         * symtab.h: Fix common/ includes.
3850         * symfile.c: Fix common/ includes.
3851         * stap-probe.c: Fix common/ includes.
3852         * spu-linux-nat.c: Fix common/ includes.
3853         * sparc-nat.c: Fix common/ includes.
3854         * source.c: Fix common/ includes.
3855         * solib.c: Fix common/ includes.
3856         * solib-target.c: Fix common/ includes.
3857         * ser-unix.c: Fix common/ includes.
3858         * ser-tcp.c: Fix common/ includes.
3859         * ser-pipe.c: Fix common/ includes.
3860         * ser-base.c: Fix common/ includes.
3861         * selftest-arch.c: Fix common/ includes.
3862         * s12z-tdep.c: Fix common/ includes.
3863         * rust-exp.y: Fix common/ includes.
3864         * rs6000-aix-tdep.c: Fix common/ includes.
3865         * riscv-tdep.c: Fix common/ includes.
3866         * remote.c: Fix common/ includes.
3867         * remote-notif.h: Fix common/ includes.
3868         * remote-fileio.h: Fix common/ includes.
3869         * remote-fileio.c: Fix common/ includes.
3870         * regcache.h: Fix common/ includes.
3871         * regcache.c: Fix common/ includes.
3872         * record-btrace.c: Fix common/ includes.
3873         * python/python.c: Fix common/ includes.
3874         * python/py-type.c: Fix common/ includes.
3875         * python/py-inferior.c: Fix common/ includes.
3876         * progspace.h: Fix common/ includes.
3877         * producer.c: Fix common/ includes.
3878         * procfs.c: Fix common/ includes.
3879         * proc-api.c: Fix common/ includes.
3880         * printcmd.c: Fix common/ includes.
3881         * ppc-linux-nat.c: Fix common/ includes.
3882         * parser-defs.h: Fix common/ includes.
3883         * osdata.c: Fix common/ includes.
3884         * obsd-nat.c: Fix common/ includes.
3885         * nat/x86-linux.c: Fix common/ includes.
3886         * nat/x86-linux-dregs.c: Fix common/ includes.
3887         * nat/x86-dregs.h: Fix common/ includes.
3888         * nat/x86-dregs.c: Fix common/ includes.
3889         * nat/ppc-linux.c: Fix common/ includes.
3890         * nat/mips-linux-watch.h: Fix common/ includes.
3891         * nat/mips-linux-watch.c: Fix common/ includes.
3892         * nat/linux-waitpid.c: Fix common/ includes.
3893         * nat/linux-ptrace.h: Fix common/ includes.
3894         * nat/linux-ptrace.c: Fix common/ includes.
3895         * nat/linux-procfs.c: Fix common/ includes.
3896         * nat/linux-personality.c: Fix common/ includes.
3897         * nat/linux-osdata.c: Fix common/ includes.
3898         * nat/linux-namespaces.c: Fix common/ includes.
3899         * nat/linux-btrace.h: Fix common/ includes.
3900         * nat/linux-btrace.c: Fix common/ includes.
3901         * nat/fork-inferior.c: Fix common/ includes.
3902         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3903         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3904         * nat/aarch64-linux.c: Fix common/ includes.
3905         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3906         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3907         * namespace.h: Fix common/ includes.
3908         * mips-linux-tdep.c: Fix common/ includes.
3909         * minsyms.c: Fix common/ includes.
3910         * mi/mi-parse.h: Fix common/ includes.
3911         * mi/mi-main.c: Fix common/ includes.
3912         * mi/mi-cmd-env.c: Fix common/ includes.
3913         * memrange.h: Fix common/ includes.
3914         * memattr.c: Fix common/ includes.
3915         * maint.h: Fix common/ includes.
3916         * maint.c: Fix common/ includes.
3917         * main.c: Fix common/ includes.
3918         * machoread.c: Fix common/ includes.
3919         * location.c: Fix common/ includes.
3920         * linux-thread-db.c: Fix common/ includes.
3921         * linux-nat.c: Fix common/ includes.
3922         * linux-fork.c: Fix common/ includes.
3923         * inline-frame.c: Fix common/ includes.
3924         * infrun.c: Fix common/ includes.
3925         * inflow.c: Fix common/ includes.
3926         * inferior.h: Fix common/ includes.
3927         * inferior.c: Fix common/ includes.
3928         * infcmd.c: Fix common/ includes.
3929         * inf-ptrace.c: Fix common/ includes.
3930         * inf-child.c: Fix common/ includes.
3931         * ia64-linux-nat.c: Fix common/ includes.
3932         * i387-tdep.c: Fix common/ includes.
3933         * i386-tdep.c: Fix common/ includes.
3934         * i386-linux-tdep.c: Fix common/ includes.
3935         * i386-linux-nat.c: Fix common/ includes.
3936         * i386-go32-tdep.c: Fix common/ includes.
3937         * i386-fbsd-tdep.c: Fix common/ includes.
3938         * i386-fbsd-nat.c: Fix common/ includes.
3939         * guile/scm-type.c: Fix common/ includes.
3940         * guile/guile.c: Fix common/ includes.
3941         * go32-nat.c: Fix common/ includes.
3942         * gnu-nat.c: Fix common/ includes.
3943         * gdbthread.h: Fix common/ includes.
3944         * gdbarch-selftests.c: Fix common/ includes.
3945         * gdb_usleep.c: Fix common/ includes.
3946         * gdb_select.h: Fix common/ includes.
3947         * gdb_bfd.c: Fix common/ includes.
3948         * gcore.c: Fix common/ includes.
3949         * fork-child.c: Fix common/ includes.
3950         * findvar.c: Fix common/ includes.
3951         * fbsd-nat.c: Fix common/ includes.
3952         * event-top.c: Fix common/ includes.
3953         * event-loop.c: Fix common/ includes.
3954         * dwarf2read.c: Fix common/ includes.
3955         * dwarf2loc.c: Fix common/ includes.
3956         * dwarf2-frame.c: Fix common/ includes.
3957         * dwarf-index-cache.c: Fix common/ includes.
3958         * dtrace-probe.c: Fix common/ includes.
3959         * disasm-selftests.c: Fix common/ includes.
3960         * defs.h: Fix common/ includes.
3961         * csky-tdep.c: Fix common/ includes.
3962         * cp-valprint.c: Fix common/ includes.
3963         * cp-support.h: Fix common/ includes.
3964         * cp-support.c: Fix common/ includes.
3965         * corelow.c: Fix common/ includes.
3966         * completer.h: Fix common/ includes.
3967         * completer.c: Fix common/ includes.
3968         * compile/compile.c: Fix common/ includes.
3969         * compile/compile-loc2c.c: Fix common/ includes.
3970         * compile/compile-cplus-types.c: Fix common/ includes.
3971         * compile/compile-cplus-symbols.c: Fix common/ includes.
3972         * command.h: Fix common/ includes.
3973         * cli/cli-dump.c: Fix common/ includes.
3974         * cli/cli-cmds.c: Fix common/ includes.
3975         * charset.c: Fix common/ includes.
3976         * build-id.c: Fix common/ includes.
3977         * btrace.h: Fix common/ includes.
3978         * btrace.c: Fix common/ includes.
3979         * breakpoint.h: Fix common/ includes.
3980         * breakpoint.c: Fix common/ includes.
3981         * ax.h: 
3982         (enum agent_op): Fix common/ includes.
3983         * ax-general.c (struct aop_map): Fix common/ includes.
3984         * ax-gdb.c: Fix common/ includes.
3985         * auxv.c: Fix common/ includes.
3986         * auto-load.c: Fix common/ includes.
3987         * arm-tdep.c: Fix common/ includes.
3988         * arch/riscv.c: Fix common/ includes.
3989         * arch/ppc-linux-common.c: Fix common/ includes.
3990         * arch/i386.c: Fix common/ includes.
3991         * arch/arm.c: Fix common/ includes.
3992         * arch/arm-linux.c: Fix common/ includes.
3993         * arch/arm-get-next-pcs.c: Fix common/ includes.
3994         * arch/amd64.c: Fix common/ includes.
3995         * arch/aarch64.c: Fix common/ includes.
3996         * arch/aarch64-insn.c: Fix common/ includes.
3997         * arch-utils.c: Fix common/ includes.
3998         * amd64-windows-tdep.c: Fix common/ includes.
3999         * amd64-tdep.c: Fix common/ includes.
4000         * amd64-sol2-tdep.c: Fix common/ includes.
4001         * amd64-obsd-tdep.c: Fix common/ includes.
4002         * amd64-nbsd-tdep.c: Fix common/ includes.
4003         * amd64-linux-tdep.c: Fix common/ includes.
4004         * amd64-linux-nat.c: Fix common/ includes.
4005         * amd64-fbsd-tdep.c: Fix common/ includes.
4006         * amd64-fbsd-nat.c: Fix common/ includes.
4007         * amd64-dicos-tdep.c: Fix common/ includes.
4008         * amd64-darwin-tdep.c: Fix common/ includes.
4009         * agent.c: Fix common/ includes.
4010         * ada-lang.h: Fix common/ includes.
4011         * ada-lang.c: Fix common/ includes.
4012         * aarch64-tdep.c: Fix common/ includes.
4013
4014 2019-01-25  Tom Tromey  <tom@tromey.com>
4015
4016         * common/create-version.sh: Use common/version.h.
4017
4018 2019-01-24  Pedro Alves  <palves@redhat.com>
4019
4020         * infrun.c (signal_stop, signal_print, signal_program)
4021         (signal_catch, signal_pass): Now arrays instead of pointers.
4022         (update_signals_program_target, do_target_resume)
4023         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4024         * linux-nat.c (linux_nat_target::pass_signals)
4025         (linux_nat_target::create_inferior, linux_nat_target::attach):
4026         Adjust.
4027         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4028         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4029         * procfs.c (procfs_target::pass_signals): Adjust.
4030         * record-full.c (record_full_target::resume): Adjust.
4031         * remote.c (remote_target::pass_signals)
4032         (remote_target::program_signals): Adjust.
4033         * target-debug.h (target_debug_print_signals): Now takes a
4034         gdb::array_view as parameter.  Adjust.
4035         * target.h (target_ops) <pass_signals, program_signals>: Replace
4036         pointer and length parameters with gdb::array_view.
4037         (target_pass_signals, target_program_signals): Likewise.
4038         * target-delegates.c: Regenerate.
4039
4040 2019-01-24  Pedro Alves  <palves@redhat.com>
4041
4042         * common/forward-scope-exit.h
4043         (forward_scope_exit::forward_scope_exit): Pass arguments to
4044         m_bind_function directly, instead of creating a std::bind and
4045         copying that.
4046
4047 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4048
4049         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4050         for static members.
4051         (pass_in_v_vfp_candidate): Likewise.
4052
4053 2019-01-23  Tom Tromey  <tom@tromey.com>
4054             Pedro Alves  <palves@redhat.com>
4055
4056         * regcache.c (class regcache_invalidator): Remove.
4057         (regcache::raw_write): Use make_scope_exit.
4058
4059 2019-01-23  Tom Tromey  <tom@tromey.com>
4060
4061         * ui-out.h (class ui_out_emit_type): Update comment.
4062
4063 2019-01-23  Tom Tromey  <tom@tromey.com>
4064
4065         * infrun.c (fetch_inferior_event): Update comment.
4066
4067 2019-01-23  Tom Tromey  <tom@tromey.com>
4068             Pedro Alves  <palves@redhat.com>
4069
4070         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4071         parameter.
4072         (fetch_inferior_event): Use SCOPE_EXIT.
4073
4074
4075 2019-01-23  Tom Tromey  <tom@tromey.com>
4076             Pedro Alves  <palves@redhat.com>
4077
4078         * infrun.c (disable_thread_events): Delete.
4079         (stop_all_threads): Use SCOPE_EXIT.
4080
4081 2019-01-23  Tom Tromey  <tom@tromey.com>
4082             Pedro Alves  <palves@redhat.com>
4083
4084         * symfile.c: Include forward-scope-exit.h.
4085         (clear_symtab_users_cleanup): Replace forward declaration with
4086         a FORWARD_SCOPE_EXIT.
4087         (syms_from_objfile_1): Use the forward_scope_exit and
4088         gdb::optional instead of cleanup_function.
4089         (reread_symbols): Use the forward_scope_exit instead of
4090         cleanup_function.
4091         (clear_symtab_users_cleanup): Remove function.
4092
4093 2019-01-23  Tom Tromey  <tom@tromey.com>
4094             Pedro Alves  <palves@redhat.com>
4095
4096         * linux-nat.c: Include scope-exit.h.
4097         (cleanup_target_stop): Remove.
4098         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4099         SCOPE_EXIT.
4100
4101 2019-01-23  Tom Tromey  <tom@tromey.com>
4102             Pedro Alves  <palves@redhat.com>
4103
4104         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4105         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4106
4107 2019-01-23  Tom Tromey  <tom@tromey.com>
4108             Andrew Burgess  <andrew.burgess@embecosm.com>
4109             Pedro Alves  <palves@redhat.com>
4110
4111         * infrun.c (fetch_inferior_event): Use scope_exit.
4112         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4113         * top.c (execute_command): Use scope_exit.
4114         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4115         * utils.c (do_bpstat_clear_actions_cleanup)
4116         (make_bpstat_clear_actions_cleanup): Remove.
4117
4118 2019-01-23  Tom Tromey  <tom@tromey.com>
4119             Pedro Alves  <palves@redhat.com>
4120
4121         * infrun.c: Include "common/scope-exit.h"
4122         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4123         (wait_for_inferior): Use SCOPE_EXIT.
4124         (fetch_inferior_event): Use scope_exit.
4125
4126 2019-01-23  Tom Tromey  <tom@tromey.com>
4127             Pedro Alves  <palves@redhat.com>
4128
4129         * breakpoint.c (create_breakpoint): Remove cleanup.
4130
4131 2019-01-23  Tom Tromey  <tom@tromey.com>
4132             Andrew Burgess  <andrew.burgess@embecosm.com>
4133             Pedro Alves  <palves@redhat.com>
4134
4135 2019-01-23  Pedro Alves  <palves@redhat.com>
4136
4137         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4138
4139 2019-01-23  Pedro Alves  <palves@redhat.com>
4140             Andrew Burgess  <andrew.burgess@embecosm.com>
4141
4142         * gdbthread.h: Include "common/forward-scope-exit.h".
4143         (scoped_finish_thread_state): Redefine custom class in terms of
4144         forward_scope_exit.
4145
4146 2019-01-23  Pedro Alves  <palves@redhat.com>
4147             Andrew Burgess  <andrew.burgess@embecosm.com>
4148
4149         * common/forward-scope-exit.h: New file.
4150
4151 2019-01-23  Pedro Alves  <palves@redhat.com>
4152             Andrew Burgess  <andrew.burgess@embecosm.com>
4153             Tom Tromey  <tom@tromey.com>
4154
4155         * common/scope-exit.h: New file.
4156
4157 2019-01-23  Pedro Alves  <palves@redhat.com>
4158
4159         * common/preprocessor.h (ESC): Rename to ...
4160         (ESC_PARENS): ... this.
4161         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4162         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4163
4164 2019-01-23  Tom Tromey  <tom@tromey.com>
4165
4166         * language.h (class scoped_switch_to_sym_language_if_auto):
4167         Initialize m_lang in both cases.
4168
4169 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4170
4171         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4172         with XCNEW.
4173
4174 2019-01-22  Tom Tromey  <tom@tromey.com>
4175
4176         * corelow.c: Do not include sys/file.h.
4177
4178 2019-01-22  Tom Tromey  <tom@tromey.com>
4179
4180         * tui/tui-wingeneral.h: Include gdb_curses.h.
4181
4182 2019-01-22  Tom Tromey  <tom@tromey.com>
4183
4184         * source-cache.h (class source_cache) <get_source_lines,
4185         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4186
4187 2019-01-22  Tom Tromey  <tom@tromey.com>
4188
4189         * remote-fileio.h (struct remote_target): Declare.
4190
4191 2019-01-22  Tom Tromey  <tom@tromey.com>
4192
4193         * python/py-arch.c: Do not include py-ref.h.
4194         * python/py-bpevent.c: Do not include py-ref.h.
4195         * python/py-cmd.c: Do not include py-ref.h.
4196         * python/py-continueevent.c: Do not include py-ref.h.
4197         * python/py-event.h: Do not include py-ref.h.
4198         * python/py-evtregistry.c: Do not include py-ref.h.
4199         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4200         * python/py-frame.c: Do not include py-ref.h.
4201         * python/py-framefilter.c: Do not include py-ref.h.
4202         * python/py-function.c: Do not include py-ref.h.
4203         * python/py-infevents.c: Do not include py-ref.h.
4204         * python/py-linetable.c: Do not include py-ref.h.
4205         * python/py-objfile.c: Do not include py-ref.h.
4206         * python/py-param.c: Do not include py-ref.h.
4207         * python/py-prettyprint.c: Do not include py-ref.h.
4208         * python/py-progspace.c: Do not include py-ref.h.
4209         * python/py-symbol.c: Do not include py-ref.h.
4210         * python/py-symtab.c: Do not include py-ref.h.
4211         * python/py-type.c: Do not include py-ref.h.
4212         * python/py-unwind.c: Do not include py-ref.h.
4213         * python/py-utils.c: Do not include py-ref.h.
4214         * python/py-value.c: Do not include py-ref.h.
4215         * python/py-varobj.c: Do not include py-ref.h.
4216         * python/py-xmethods.c: Do not include py-ref.h.
4217         * python/python.c: Do not include py-ref.h.
4218         * varobj.c: Do not include py-ref.h.
4219
4220 2019-01-22  Tom Tromey  <tom@tromey.com>
4221
4222         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4223         keyword for bcache.
4224
4225 2019-01-22  Tom Tromey  <tom@tromey.com>
4226
4227         * compile/compile-cplus-types.c: Remove a comment by #include.
4228
4229 2019-01-22  Tom Tromey  <tom@tromey.com>
4230
4231         * compile/gcc-c-plugin.h: Include compile-internal.h.
4232
4233 2019-01-22  Tom Tromey  <tom@tromey.com>
4234
4235         * stabsread.c (EXTERN): Do not define.
4236         (symnum, next_symbol_text_func, processing_gcc_compilation)
4237         (within_function, global_sym_chain, global_stabs)
4238         (previous_stab_code, this_object_header_files)
4239         (n_this_object_header_files)
4240         (n_allocated_this_object_header_files): Define.
4241         * stabsread.h (EXTERN): Never define.  Use "extern".
4242
4243 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4244
4245         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4246         history_value.
4247
4248 2019-01-21  Tom Tromey  <tom@tromey.com>
4249
4250         * ui-out.c: Fix includes.
4251         * tui/tui-source.c: Fix includes.
4252         * target.c: Fix includes.
4253         * remote.c: Fix includes.
4254         * regcache.c: Fix includes.
4255         * python/py-block.c: Fix includes.
4256         * printcmd.c: Fix includes.
4257         * or1k-tdep.c: Fix includes.
4258         * mi/mi-main.c: Fix includes.
4259         * m32r-tdep.c: Fix includes.
4260         * csky-tdep.c: Fix includes.
4261         * compile/compile-cplus-types.c: Fix includes.
4262         * cli/cli-interp.c: Fix includes.
4263
4264 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4265
4266         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4267         for padding.
4268
4269 2019-01-16  Tom Tromey  <tom@tromey.com>
4270
4271         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4272         earlier.
4273         (struct objfile) <msymbols_range>: Move from top level.
4274         <msymbols>: New method.
4275         (class objfile_msymbols): Remove.
4276         * symtab.c (default_collect_symbol_completion_matches_break_on):
4277         Update.
4278         * symmisc.c (dump_msymbols): Update.
4279         * stabsread.c (scan_file_globals): Update.
4280         * objc-lang.c (info_selectors_command, info_classes_command)
4281         (find_methods): Update.
4282         * minsyms.c (find_solib_trampoline_target): Update.
4283         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4284         * coffread.c (coff_symfile_read): Update.
4285         * ada-lang.c (ada_lookup_simple_minsym)
4286         (ada_collect_symbol_completion_matches): Update.
4287
4288 2019-01-16  Tom Tromey  <tom@tromey.com>
4289
4290         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4291         type.  Remove no-argument constructor.
4292         <iterator::operator++>: Simplify.
4293         <begin>: Update.
4294         <end>: Use minimal_symbol_count.
4295
4296 2019-01-16  Tom Tromey  <tom@tromey.com>
4297
4298         * objfiles.h (struct objfile) <psymtabs>: New method.
4299         (class objfile_psymtabs): Remove.
4300         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4301         typedef.
4302         <range>: New method.
4303         (require_partial_symbols): Change return type.
4304         * psymtab.c (require_partial_symbols)
4305         (psym_expand_symtabs_matching): Update.
4306         * mdebugread.c (parse_partial_symbols): Update.
4307         * dbxread.c (dbx_end_psymtab): Update.
4308
4309 2019-01-15  Tom Tromey  <tom@tromey.com>
4310
4311         * symtab.c (lookup_objfile_from_block)
4312         (lookup_symbol_in_objfile_symtabs)
4313         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4314         (find_line_symtab, info_sources_command)
4315         (default_collect_symbol_completion_matches_break_on)
4316         (make_source_files_completion_list): Update.
4317         * symmisc.c (print_objfile_statistics, dump_objfile)
4318         (maintenance_print_symbols, maintenance_info_symtabs)
4319         (maintenance_check_symtabs, maintenance_info_line_tables):
4320         Update.
4321         * source.c (select_source_symtab)
4322         (forget_cached_source_info_for_objfile): Update.
4323         * objfiles.h (class objfile_compunits): Remove.
4324         (struct objfile) <compunits_range>: New typedef.
4325         (compunits): New method.
4326         * objfiles.c (objfile_relocate1): Update.
4327         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4328         * maint.c (count_symtabs_and_blocks): Update.
4329         * linespec.c (iterate_over_all_matching_symtabs): Update.
4330         * cp-support.c (add_symbol_overload_list_qualified): Update.
4331         * coffread.c (coff_symtab_read): Update.
4332         * ada-lang.c (add_nonlocal_symbols)
4333         (ada_collect_symbol_completion_matches)
4334         (ada_add_global_exceptions): Update.
4335
4336 2019-01-15  Tom Tromey  <tom@tromey.com>
4337
4338         * progspace.h (program_space) <objfiles_safe_range>: New
4339         typedef.
4340         <objfiles_safe>: New method.
4341         * objfiles.h (class all_objfiles_safe): Remove.
4342         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4343         * jit.c (jit_inferior_exit_hook): Update.
4344
4345 2019-01-17  Tom Tromey  <tom@tromey.com>
4346
4347         * progspace.h (program_space) <objfiles_range>: New typedef.
4348         <objfiles>: New method.
4349         <objfiles_head>: Rename from objfiles.
4350         (object_files): Update.
4351         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4352         * guile/scm-pretty-print.c
4353         (ppscm_find_pretty_printer_from_objfiles): Update.
4354         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4355         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4356         Update.
4357         * python/py-progspace.c (pspy_get_objfiles): Update.
4358         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4359         Update.
4360         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4361         (objfpy_lookup_objfile_by_build_id): Update.
4362         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4363         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4364         Update.
4365         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4366         (expand_symtab_containing_pc, lookup_objfile_from_block)
4367         (lookup_static_symbol, basic_lookup_transparent_type)
4368         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4369         (find_line_symtab, info_sources_command)
4370         (default_collect_symbol_completion_matches_break_on)
4371         (make_source_files_completion_list, find_main_name): Update.
4372         * symmisc.c (print_symbol_bcache_statistics)
4373         (print_objfile_statistics, maintenance_print_symbols)
4374         (maintenance_print_msymbols, maintenance_print_objfiles)
4375         (maintenance_info_symtabs, maintenance_check_symtabs)
4376         (maintenance_expand_symtabs, maintenance_info_line_tables):
4377         Update.
4378         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4379         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4380         (map_overlay_command, unmap_overlay_command)
4381         (simple_overlay_update, expand_symtabs_matching)
4382         (map_symbol_filenames): Update.
4383         * symfile-debug.c (set_debug_symfile): Update.
4384         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4385         Update.
4386         * source.c (select_source_symtab, forget_cached_source_info):
4387         Update.
4388         * solib.c (solib_read_symbols): Update.
4389         * solib-spu.c (append_ocl_sos): Update.
4390         * psymtab.c (maintenance_print_psymbols)
4391         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4392         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4393         * printcmd.c (info_symbol_command): Update.
4394         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4395         Update.
4396         * objfiles.h (class all_objfiles): Remove.
4397         * objfiles.c (have_partial_symbols, have_full_symbols)
4398         (have_minimal_symbols, qsort_cmp, update_section_map)
4399         (shared_objfile_contains_address_p)
4400         (default_iterate_over_objfiles_in_search_order): Update.
4401         * objc-lang.c (info_selectors_command, info_classes_command)
4402         (find_methods): Update.
4403         * minsyms.c (find_solib_trampoline_target): Update.
4404         * maint.c (maintenance_info_sections)
4405         (maintenance_translate_address, count_symtabs_and_blocks):
4406         Update.
4407         * main.c (captured_main_1): Update.
4408         * linux-thread-db.c (try_thread_db_load_from_pdir)
4409         (has_libpthread): Update.
4410         * linespec.c (iterate_over_all_matching_symtabs)
4411         (search_minsyms_for_name): Update.
4412         * jit.c (jit_find_objf_with_entry_addr): Update.
4413         * hppa-tdep.c (find_unwind_entry)
4414         (hppa_lookup_stub_minimal_symbol): Update.
4415         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4416         Update.
4417         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4418         (elf_gnu_ifunc_resolve_by_got): Update.
4419         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4420         * dwarf-index-write.c (save_gdb_index_command): Update.
4421         * cp-support.c (add_symbol_overload_list_qualified): Update.
4422         * breakpoint.c (create_overlay_event_breakpoint)
4423         (create_longjmp_master_breakpoint)
4424         (create_std_terminate_master_breakpoint)
4425         (create_exception_master_breakpoint): Update.
4426         * blockframe.c (find_pc_partial_function): Update.
4427         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4428         (ada_collect_symbol_completion_matches)
4429         (ada_add_global_exceptions): Update.
4430
4431 2019-01-17  Tom Tromey  <tom@tromey.com>
4432
4433         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4434         declare VEC.
4435         (solib_target_parse_libraries): Change return type.
4436         (library_list_start_segment, library_list_start_section)
4437         (library_list_end_library, library_list_start_library); Update.
4438         (solib_target_free_library_list): Remove.
4439         (solib_target_parse_libraries): Remove cleanup.  Change return
4440         type.
4441         (solib_target_current_sos): Update.
4442
4443 2019-01-17  Tom Tromey  <tromey@bapiya>
4444
4445         * valprint.c: Replace "the the" with "the".
4446         * symtab.c: Replace "the the" with "the".
4447         * solib.c: Replace "the the" with "the".
4448         * solib-dsbt.c: Replace "the the" with "the".
4449         * linespec.c: Replace "the the" with "the".
4450         * dwarf2loc.h: Replace "the the" with "the".
4451         * amd64-windows-tdep.c: Replace "the the" with "the".
4452         * aarch64-tdep.c: Replace "the the" with "the".
4453
4454 2019-01-16  Keith Seitz  <keiths@redhat.com>
4455
4456         PR gdb/23773
4457         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4458         <builder>: Rename to ..
4459         <m_builder>: ... this and make private.
4460         (dwarf2_cu::get_builder): New method.  Change all users of
4461         `builder' to use this method.
4462         (dwarf2_start_symtab): Move to ...
4463         (dwarf2_cu::start_symtab): ... here.  Update all callers
4464         (setup_type_unit_groups): Move to ...
4465         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4466         callers.
4467         (dwarf2_cu::reset_builder): New method.
4468         (process_full_compunit, process_full_type_unit): Use
4469         dwarf2_cu::reset_builder.
4470         (follow_die_offset): Record the ancestor CU if it is different
4471         from the followed DIE's CU.
4472         (follow_die_sig_1): Likewise.
4473
4474 2019-01-15  Tom Tromey  <tom@tromey.com>
4475
4476         * remote.c (class remote_state) <buf>: Now a char_vector.
4477         <buf_size>: Remove.
4478         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4479         parameter.
4480         (remote_target::getpkt_or_notif_sane_1)
4481         (remote_target::getpkt_sane)
4482         (remote_target::getpkt_or_notif_sane): Likewise.
4483         (class remote_target) <putpkt>: New overload.
4484         (remote_target::read_frame): Change type of "buf_p".  Remove
4485         sizeof_p parameter.
4486         (packet_ok): New overload.
4487         (packet_check_result): New overload.
4488         Update all uses.
4489
4490 2019-01-14  Tom Tromey  <tom@tromey.com>
4491
4492         * remote-notif.c (handle_notification, remote_notif_ack)
4493         (remote_notif_parse): Make "buf" const.
4494         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4495         const.
4496         (remote_notif_parse, remote_notif_ack, handle_notification):
4497         Likewise.
4498         * remote.c (remote_notif_stop_parse): Make "buf" const.
4499         (remote_target::remote_parse_stop_reply): Make "buf" const.
4500         (remote_notif_stop_ack): Make "buf" const.
4501
4502 2019-01-14  Tom Tromey  <tom@tromey.com>
4503
4504         * remote.c (remote_console_output): Make parameter const.
4505
4506 2019-01-14  Tom Tromey  <tom@tromey.com>
4507
4508         * target-debug.h (target_debug_print_signals): Constify.
4509         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4510         * procfs.c (procfs_target::pass_signals): Update.
4511         * linux-nat.c (linux_nat_target::pass_signals): Update.
4512         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4513         * target-delegates.c: Rebuild.
4514         * remote.c (remote_target::program_signals): Update.
4515         (remote_target::pass_signals): Update.
4516         * target.c (target_pass_signals): Constify argument.
4517         (target_program_signals): Likewise.
4518         * target.h (struct target_ops) <pass_signals, program_signals>:
4519         Constify argument.
4520         (target_pass_signals, target_program_signals): Constify argument.
4521
4522 2019-01-14  Tom Tromey  <tom@tromey.com>
4523
4524         PR tui/28819:
4525         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4526
4527 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4528
4529         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4530         field.
4531         * rs6000-tdep.c: Include reggroups.h.
4532         (IS_V_ALIAS_PSEUDOREG): Define.
4533         (rs6000_register_name): Return names for the "vX" aliases.
4534         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4535         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4536         aliases.  Call default_register_reggroup_p for all other
4537         pseudo-registers.
4538         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4539         New functions.
4540         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4541         Handle "vX" aliases.
4542         (v_alias_pseudo_register_collect): New function.
4543         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4544         (rs6000_gdbarch_init): Initialize "vX" aliases as
4545         pseudo-registers.  Restore registration of
4546         rs6000_pseudo_register_reggroup_p with
4547         set_tdesc_pseudo_register_reggroup_p.
4548
4549 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4550
4551         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4552         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4553         set_gdbarch_num_pseudo_regs.
4554
4555 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4556
4557         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4558         Remove arg prefixname, add do_set and do_show.
4559         Add member functions set_list and show_list.
4560         * cli/cli-style.c (class cli_style_option): Update accordingly.
4561         (style_set_list): Move to file scope.
4562         (style_show_list): Likewise.
4563         (set_style): Call help_list.
4564         (show_style): Call cmd_show_list.
4565         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4566         Update to use the new macro.
4567
4568 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4569
4570         * ada-lang.c (_initialize_ada_language): Expand the help text
4571         for the "catch exception" command.
4572
4573 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4574
4575         * symtab.c (matching_obj_sections): Initialize obj,
4576         declare it closer to its usage.
4577
4578 2019-01-10  Tom Tromey  <tom@tromey.com>
4579
4580         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4581         (basic_inf_threads_range): Remove.
4582         (inf_threads_range, inf_non_exited_threads_range)
4583         (safe_inf_threads_range): Use next_adapter.
4584
4585 2019-01-10  Keith Seitz  <keiths@redhat.com>
4586
4587         PR gdb/23712
4588         PR symtab/23010
4589         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4590         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4591
4592 2019-01-10  Keith Seitz  <keiths@redhat.com>
4593
4594         PR gdb/23712
4595         PR symtab/23010
4596         * dictionary.c (pending_to_vector): Remove.
4597         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4598         Remove _1 suffix, replacing functions of the same name.  Update
4599         all callers.
4600         (dict_create_hashed, dict_create_hashed_expandable)
4601         (dict_create_linear, dict_create_linear_expandable, dict_free)
4602         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4603         Make functions static.
4604
4605 2019-01-10  Keith Seitz  <keiths@redhat.com>
4606
4607         PR gdb/23712
4608         PR symtab/23010
4609         * dictionary.h (struct dictionary): Replace declaration with
4610         multidictionary.
4611         (dict_create_hashed, dict_create_hashed_expandable)
4612         (dict_create_linear, dict_create_linear_expandable)
4613         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4614         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4615         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4616         taking multidictionary argument.
4617         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4618         * block.h (struct block) <dict>: Change to multidictionary
4619         and rename `multidict'.
4620         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4621         symmisc.c: Update all dictionary references to multidictionary.
4622
4623 2019-01-10  Keith Seitz  <keiths@redhat.com>
4624
4625         PR gdb/23712
4626         PR symtab/23010
4627         * dictionary.c: Include unordered_map.
4628         (pending_to_vector): New function.
4629         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4630         Rewrite the non-"_1" functions to take vector instead
4631         of linked list.
4632         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4633         "new" _1 versions of the same name.
4634         (multidictionary): Define.
4635         (std::hash<enum language): New definition.
4636         (collate_pending_symbols_by_language, mdict_create_hashed)
4637         (mdict_create_hashed_expandable, mdict_create_linear)
4638         (mdict_create_linear_expandable, mdict_free)
4639         (find_language_dictionary, create_new_language_dictionary)
4640         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4641         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4642         (mdict_size, mdict_empty): New functions.
4643         * dictionary.h (mdict_iterator): Define.
4644
4645 2019-01-10  Pedro Alves  <palves@redhat.com>
4646
4647         * breakpoint.c (read_uploaded_action)
4648         (create_tracepoint_from_upload): Adjust to use
4649         gdb::unique_xmalloc_ptr.
4650         * ctf.c (ctf_write_uploaded_tp):
4651         (SET_ARRAY_FIELD): Use emplace_back.
4652         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4653         * tracefile-tfile.c (tfile_write_uploaded_tp):
4654         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4655         gdb::unique_xmalloc_ptr.
4656         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4657         at_string, cond_string, cmd_strings>: Replace char pointers
4658         with gdb::unique_xmalloc_ptr.
4659
4660 2019-01-10  Pedro Alves  <palves@redhat.com>
4661
4662         * solib-target.c (library_list_start_library): Don't xstrdup name.
4663
4664 2019-01-10  Pedro Alves  <palves@redhat.com>
4665
4666         * mdebugread.c (parse_partial_symbols): Use
4667         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4668
4669 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4670
4671         * linux-fork.c (scoped_switch_fork_info)
4672         <~scoped_switch_fork_info>: Fix incorrect variable name.
4673
4674 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4675
4676         * linux-fork.c (scoped_switch_fork_info)
4677         <scoped_switch_fork_info>: Make explicit.
4678         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4679
4680 2019-01-10  Tom Tromey  <tom@tromey.com>
4681
4682         * objfiles.h (objfile::reset_psymtabs): Update.
4683         * objfiles.c (objfile::objfile): Update.
4684         * psymtab.h (psymtab_storage::obstack): Update.
4685         (psymtab_storage::m_obstack): Use gdb::optional.
4686         (class psymtab_storage): Update comment.  Remove objfile
4687         parameter.
4688         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4689
4690 2019-01-10  Tom Tromey  <tom@tromey.com>
4691
4692         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4693         <free_psymtabs>: Now private.
4694         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4695         (allocate_psymtab): Use new method.
4696
4697 2019-01-10  Tom Tromey  <tom@tromey.com>
4698
4699         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4700         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4701         * mdebugread.c (parse_partial_symbols): Use
4702         allocate_dependencies.
4703         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4704         allocate_dependencies.
4705         (process_psymtab_comp_unit_reader)
4706         (build_type_psymtab_dependencies): Likewise.
4707         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4708
4709 2019-01-10  Tom Tromey  <tom@tromey.com>
4710
4711         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4712         PSYMBOL_SET_LANGUAGE.
4713         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4714
4715 2019-01-10  Tom Tromey  <tom@tromey.com>
4716
4717         * psymtab.h (psymtab_storage::obstack): New method.
4718         <m_obstack>: Rename from obstack; now private.
4719         * psymtab.c (psymtab_storage): Update.
4720         * dwarf2read.c (create_addrmap_from_index)
4721         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4722         Update.
4723
4724 2019-01-10  Tom Tromey  <tom@tromey.com>
4725
4726         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4727         * objfiles.h (objfile::reset_psymtabs): New method.
4728
4729 2019-01-10  Tom Tromey  <tom@tromey.com>
4730
4731         * symmisc.c (print_symbol_bcache_statistics): Update.
4732         (print_objfile_statistics): Update.
4733         * symfile.c (reread_symbols): Update.
4734         * psymtab.h (class psymtab_storage): New.
4735         * psymtab.c (psymtab_storage): New constructor.
4736         (~psymtab_storage): New destructor.
4737         (require_partial_symbols): Update.
4738         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4739         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4740         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4741         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4742         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4743         (start_psymtab_common, end_psymtab_common)
4744         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4745         (allocate_psymtab): Update.
4746         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4747         Update.
4748         (dump_psymtab_addrmap, maintenance_print_psymbols)
4749         (maintenance_check_psymtabs): Update.
4750         (class objfile_psymtabs): Move to objfiles.h.
4751         * psympriv.h (discard_psymtab): Now inline.
4752         (psymtab_discarder::psymtab_discarder): Update.
4753         (psymtab_discarder::~psymtab_discarder): Update.
4754         (ALL_OBJFILE_PSYMTABS): Rewrite.
4755         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4756         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4757         Remove fields.
4758         <partial_symtabs>: New field.
4759         (class objfile_psymtabs): Move from psymtab.h.  Update.
4760         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4761         psymbol_cache.
4762         (objfile::~objfile): Don't destroy psymbol_cache.
4763         * mdebugread.c (parse_partial_symbols): Update.
4764         * dwarf2read.c (create_addrmap_from_index)
4765         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4766         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4767         (add_partial_subprogram, dwarf2_ranges_read): Update.
4768         * dwarf-index-write.c (write_address_map)
4769         (write_one_signatured_type, recursively_write_psymbols)
4770         (class debug_names, class debug_names, write_psymtabs_to_index):
4771         Update.
4772
4773 2019-01-10  Tom Tromey  <tom@tromey.com>
4774
4775         * symtab.h (SYMBOL_SET_NAMES): Update.
4776         (symbol_set_names): Update.
4777         (MSYMBOL_SET_NAMES): Update.
4778         * symtab.c (symbol_set_names): Change argument to be an
4779         objfile_per_bfd_storage.
4780         * psymtab.c (add_psymbol_to_bcache): Update.
4781         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4782
4783 2019-01-10  Tom Tromey  <tom@tromey.com>
4784
4785         * symtab.c (create_demangled_names_hash): Change argument to be an
4786         objfile_per_bfd_storage.
4787         (symbol_set_names): Update.
4788
4789 2019-01-10  Tom Tromey  <tom@tromey.com>
4790
4791         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4792         init_psymbol_list.
4793         * psymtab.c (init_psymbol_list): Do nothing if already called.
4794         * psympriv.h (init_psymbol_list): Add comment.
4795         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4796         init_psymbol_list.
4797         * dbxread.c (dbx_symfile_read): Unconditionally call
4798         init_psymbol_list.
4799
4800 2019-01-10  Tom Tromey  <tom@tromey.com>
4801
4802         * xcoffread.c (scan_xcoff_symtab): Update.
4803         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4804         "where".
4805         * mdebugread.c (parse_partial_symbols)
4806         (handle_psymbol_enumerators): Update.
4807         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4808         * dbxread.c (read_dbx_symtab): Update.
4809         * psympriv.h (psymbol_placement): New enum.
4810         (add_psymbol_to_list): Update.
4811
4812 2019-01-10  Tom Tromey  <tom@tromey.com>
4813
4814         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4815         static_psymbols parameters.
4816         (scan_xcoff_symtab): Update.
4817         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4818         static_psymbols parameters.
4819         * psympriv.h (start_psymtab_common): Update.
4820         * mdebugread.c (parse_partial_symbols): Update.
4821         * dwarf2read.c (create_partial_symtab): Update.
4822         * dbxread.c (read_dbx_symtab): Update.
4823         (start_psymtab): Remove global_psymbols and static_psymbols
4824         parameters.
4825
4826 2019-01-10  Tom Tromey  <tom@tromey.com>
4827
4828         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4829         * psymtab.c (allocate_psymtab): Add comment.
4830         * psympriv.h (allocate_psymtab): Add comment.
4831         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4832         initializations.
4833         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4834
4835 2019-01-10  Tom Tromey  <tom@tromey.com>
4836
4837         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4838         Don't declare.
4839         * mipsread.c: Include mdebugread.h.
4840         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4841         Declare.
4842         * elfread.c: Include mdebugread.h.
4843
4844 2019-01-09  Tom Tromey  <tom@tromey.com>
4845
4846         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4847         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4848         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4849         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4850         (psym_lookup_symbol, psym_find_last_source_symtab)
4851         (psym_forget_cached_source_info, psym_print_stats)
4852         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4853         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4854         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4855         (psym_find_compunit_symtab_by_address)
4856         (maintenance_print_psymbols, maintenance_info_psymtabs)
4857         (maintenance_check_psymtabs): Use ranged for.
4858         * psymtab.h (class objfile_psymtabs): New.
4859         (require_partial_symbols): Return objfile_psymtabs.
4860         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4861
4862 2019-01-09  Tom Tromey  <tom@tromey.com>
4863
4864         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4865         (find_pc_mapped_section, list_overlays_command)
4866         (map_overlay_command, unmap_overlay_command)
4867         (simple_overlay_update): Use all_objfiles.
4868         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4869         * printcmd.c (info_symbol_command): Use all_objfiles.
4870         * objfiles.h (ALL_OBJSECTIONS): Remove.
4871         * maint.c (maintenance_translate_address): Use all_objfiles.
4872         * gcore.c (gcore_create_callback): Use all_objfiles.
4873         (objfile_find_memory_regions): Likewise.
4874
4875 2019-01-09  Tom Tromey  <tom@tromey.com>
4876
4877         * symtab.c (find_line_symtab, info_sources_command)
4878         (make_source_files_completion_list): Use objfile_compunits.
4879         * source.c (select_source_symtab): Use objfile_compunits.
4880         * objfiles.h (struct objfile): Update comment.
4881         (ALL_OBJFILES): Remove.
4882         (ALL_FILETABS): Remove.
4883         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4884         objfile_compunits.
4885
4886 2019-01-09  Tom Tromey  <tom@tromey.com>
4887
4888         * symmisc.c (print_objfile_statistics, dump_objfile)
4889         (maintenance_print_symbols): Use compunit_filetabs.
4890         * source.c (forget_cached_source_info_for_objfile): Use
4891         compunit_filetabs.
4892         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4893         (ALL_FILETABS): Use compunit_filetabs.
4894         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4895         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4896
4897 2019-01-09  Tom Tromey  <tom@tromey.com>
4898
4899         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4900         (compunit_filetabs): New.
4901         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4902         compunit_filetabs.
4903         (info_sources_command, make_source_files_completion_list): Remove
4904         declaration.
4905         * symmisc.c (print_objfile_statistics, dump_objfile)
4906         (maintenance_print_symbols): Remove declaration.
4907         (maintenance_info_symtabs): Use compunit_filetabs.
4908         (maintenance_info_line_tables): Likewise.
4909         * source.c (select_source_symtab): Change local variable name.
4910         (forget_cached_source_info_for_objfile): Remove declaration.
4911         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4912         * objfiles.c (objfile_relocate1): Remove declaration.
4913         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4914         declaration.
4915         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4916         * coffread.c (coff_symtab_read): Remove declaration.
4917         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4918         compunit_filetabs.
4919
4920 2019-01-09  Tom Tromey  <tom@tromey.com>
4921
4922         * symtab.c (lookup_objfile_from_block)
4923         (find_pc_sect_compunit_symtab, search_symbols)
4924         (default_collect_symbol_completion_matches_break_on): Use
4925         objfile_compunits.
4926         * objfiles.h (ALL_COMPUNITS): Remove.
4927         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4928         * cp-support.c (add_symbol_overload_list_qualified): Use
4929         objfile_compunits.
4930         * ada-lang.c (ada_collect_symbol_completion_matches)
4931         (ada_add_global_exceptions): Use objfile_compunits.
4932
4933 2019-01-09  Tom Tromey  <tom@tromey.com>
4934
4935         * source.c (select_source_symtab)
4936         (forget_cached_source_info_for_objfile): Remove declaration.
4937         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4938         declaration.
4939         * maint.c (count_symtabs_and_blocks): Remove declaration.
4940         * cp-support.c (add_symbol_overload_list_qualified): Remove
4941         declaration.
4942         * coffread.c (coff_symtab_read): Remove declaration.
4943         * symtab.c (lookup_symbol_in_objfile_symtabs)
4944         (basic_lookup_transparent_type_1): Use objfile_compunits.
4945         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4946         (info_sources_command, search_symbols)
4947         (default_collect_symbol_completion_matches_break_on)
4948         (make_source_files_completion_list): Remove declaration.
4949         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4950         (ada_collect_symbol_completion_matches)
4951         (ada_add_global_exceptions): Remove declaration.
4952         * linespec.c (iterate_over_all_matching_symtabs): Use
4953         objfile_compunits.
4954         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4955         (class objfile_compunits): New.
4956         (ALL_COMPUNITS): Use objfile_compunits.
4957         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4958         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4959         objfile_compunits.
4960         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4961
4962 2019-01-09  Tom Tromey  <tom@tromey.com>
4963
4964         * symtab.c (search_symbols)
4965         (default_collect_symbol_completion_matches_break_on): Use
4966         objfile_msymbols.
4967         * ada-lang.c (ada_lookup_simple_minsym)
4968         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4969         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4970         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4971         objfile_msymbols.
4972         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4973         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4974         * objc-lang.c (find_methods): Use objfile_msymbols.
4975         (info_selectors_command, info_classes_command): Likewise.
4976         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4977         * objfiles.h (class objfile_msymbols): New.
4978         (ALL_OBJFILE_MSYMBOLS): Remove.
4979         (ALL_MSYMBOLS): Remove.
4980
4981 2019-01-09  Tom Tromey  <tom@tromey.com>
4982
4983         * common/next-iterator.h (next_adapter): Add Iterator template
4984         parameter.
4985         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4986         (class all_objfiles_safe): New.
4987         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4988         * objfiles.c (put_objfile_before): Update comment.
4989         (add_separate_debug_objfile): Likewise.
4990         (free_all_objfiles): Use all_objfiles_safe.
4991         (objfile_purge_solibs): Likewise.
4992
4993 2019-01-09  Tom Tromey  <tom@tromey.com>
4994
4995         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4996         (expand_symtab_containing_pc, lookup_static_symbol)
4997         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4998         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4999         all_objfiles.
5000         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5001         * breakpoint.c (create_overlay_event_breakpoint)
5002         (create_longjmp_master_breakpoint)
5003         (create_std_terminate_master_breakpoint)
5004         (create_exception_master_breakpoint): Use all_objfiles.
5005         * linux-thread-db.c (try_thread_db_load_from_pdir)
5006         (has_libpthread): Use all_objfiles.
5007         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5008         * linespec.c (iterate_over_all_matching_symtabs)
5009         (search_minsyms_for_name): Use all_objfiles.
5010         * maint.c (maintenance_info_sections): Use all_objfiles.
5011         * main.c (captured_main_1): Use all_objfiles.
5012         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5013         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5014         * guile/scm-pretty-print.c
5015         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5016         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5017         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5018         (maintenance_print_msymbols): Use all_objfiles.
5019         * source.c (select_source_symtab): Use all_objfiles.
5020         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5021         * symfile.c (remove_symbol_file_command)
5022         (expand_symtabs_matching, map_symbol_filenames): Use
5023         all_objfiles.
5024         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5025         all_objfiles.
5026         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5027         * objc-lang.c (find_methods): Use all_objfiles.
5028         * objfiles.c (have_partial_symbols, have_full_symbols)
5029         (have_minimal_symbols, qsort_cmp)
5030         (default_iterate_over_objfiles_in_search_order): Use
5031         all_objfiles.
5032         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5033         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5034         (maintenance_check_psymtabs): Use all_objfiles.
5035         (ALL_PSYMTABS): Remove.
5036         * compile/compile-object-run.c (do_module_cleanup): Use
5037         all_objfiles.
5038         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5039         * cp-support.c (add_symbol_overload_list_qualified): Use
5040         all_objfiles.
5041         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5042         Use all_objfiles.
5043         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5044         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5045         all_objfiles.
5046         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5047         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5048         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5049         Uses all_objfiles.
5050         * solib.c (solib_read_symbols): Use all_objfiles
5051
5052 2019-01-09  Tom Tromey  <tom@tromey.com>
5053
5054         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5055         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5056         all_objfiles.
5057         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5058         * symmisc.c (print_symbol_bcache_statistics)
5059         (print_objfile_statistics, maintenance_print_objfiles)
5060         (maintenance_info_symtabs, maintenance_check_symtabs)
5061         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5062         all_objfiles.
5063         * source.c (forget_cached_source_info): Use all_objfiles.
5064         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5065         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5066         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5067         * objfiles.c (update_section_map): Use all_objfiles.
5068         (shared_objfile_contains_address_p): Likewise.
5069         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5070         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5071
5072 2019-01-09  Tom Tromey  <tom@tromey.com>
5073
5074         * common/next-iterator.h: New file.
5075         * objfiles.h (class all_objfiles): New.
5076         (struct objfile_iterator): New.
5077
5078 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5079
5080         * NEWS: Move the description of the changed "frame", "select-frame",
5081          and "info frame" commands to the Changed commands section.
5082
5083 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5084
5085         * gdbtypes.c (check_stub_method_group): Remove handling of old
5086         mangling schemes.
5087         * linespec.c (find_methods): Likewise.
5088         * stabsread.c (read_member_functions): Likewise.
5089         * valops.c (search_struct_method): Likewise.
5090         (value_struct_elt_for_reference): Likewise.
5091         * NEWS: Mention this change.
5092
5093 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5094
5095         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5096         print_source_lines.
5097         * source.c (print_source_lines_base): Update line number check.
5098         (print_source_lines): New function.
5099         (source_lines_range::source_lines_range): New function.
5100         * source.h (class source_lines_range): New class.
5101         (print_source_lines): New declaration.
5102
5103 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5104
5105         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5106
5107 2019-01-08  Tom Tromey  <tom@tromey.com>
5108             Simon Marchi  <simon.marchi@ericsson.com>
5109
5110         PR gdb/24060
5111         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5112         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5113         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5114         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5115         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5116         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5117
5118 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5119
5120         * source.c (select_source_symtab): Move header comment to
5121         declaration in source.h.
5122         (forget_cached_source_info_for_objfile): Likewise.
5123         (forget_cached_source_info): Likewise.
5124         (identify_source_line): Likewise.
5125         * source.h (identify_source_line): Move declaration from symtab.h
5126         and add comment from source.c
5127         (print_source_lines): Likewise.
5128         (forget_cached_source_info_for_objfile): Likewise.
5129         (forget_cached_source_info): Likewise.
5130         (select_source_symtab): Likewise.
5131         (enum print_source_lines_flag): Move definition from symtab.h.
5132         * symtab.h (identify_source_line): Move declaration to source.h.
5133         (print_source_lines): Likewise.
5134         (forget_cached_source_info_for_objfile): Likewise.
5135         (forget_cached_source_info): Likewise.
5136         (select_source_symtab): Likewise.
5137         (enum print_source_lines_flag): Move definition to source.h.
5138         * tui/tui-hooks.c: Add 'source.h' include.
5139
5140 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5141
5142         * source.c (print_source_lines_base): Handle requests to print
5143         reverse line number sequences, and guard against empty lines
5144         string.
5145
5146 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5147
5148         * source.c (print_source_lines_base): Fix skip of '\r' if next
5149         character is '\n'.
5150
5151 2019-01-06  Tom Tromey  <tom@tromey.com>
5152
5153         * c-exp.y (struct c_parse_state) <macro_original_text,
5154         expansion_obstack>: New member.
5155         (macro_original_text, expansion_obstack): Remove globals.
5156         (scan_macro_expansion, scanning_macro_expansion)
5157         (finished_macro_expansion): Update.
5158         (scan_macro_cleanup): Remove.
5159         (yylex, c_parse): Update.
5160
5161 2019-01-06  Tom Tromey  <tom@tromey.com>
5162
5163         * c-exp.y (struct c_parse_state) <strings>: New member.
5164         (operator_stoken): Update.
5165
5166 2019-01-06  Tom Tromey  <tom@tromey.com>
5167
5168         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5169         (union type_stack_elt) <typelist_val>: Now a pointer to
5170         std::vector.
5171         (type_stack_cleanup): Don't declare.
5172         (push_typelist): Update.
5173         * parse.c (pop_typelist): Return a std::vector.
5174         (push_typelist): Take a std::vector.
5175         (follow_types): Update.  Do not free args.
5176         (type_stack_cleanup): Remove.
5177         * c-exp.y (struct c_parse_state): New.
5178         (cpstate): New global.
5179         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5180         (nonempty_typelist): Update.
5181         (func_mod): Create a new vector.
5182         (c_parse): Create a c_parse_state.
5183         (check_parameter_typelist): Do not delete params.
5184         (function_method): Update.  Do not delete type_list.
5185
5186 2019-01-06  Tom Tromey  <tom@tromey.com>
5187
5188         PR gdb/28155:
5189         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5190         check_typedef.
5191         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5192         (print_return_value): Likewise.
5193
5194 2019-01-05  Tom Tromey  <tom@tromey.com>
5195
5196         * contrib/cleanup_check.py: Remove.
5197         * contrib/gcc-with-excheck: Remove.
5198         * contrib/exsummary.py: Remove.
5199         * contrib/excheck.py: Remove.
5200
5201 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5202
5203         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5204         NULL. Initialize tpprev to NULL instead of assigning it
5205         to NULL on the next statement.
5206         * windows-nat.c (windows_delete_thread): Remove check for
5207         main_thread_id before printing thread exit notifications.
5208         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5209         Remove thread ID check against main_thread_id.
5210         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5211         windows_delete_thread.
5212         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5213
5214 2019-01-04  Tom Tromey  <tom@tromey.com>
5215
5216         * compile/compile.c (_initialize_compile): Use upper case for
5217         metasyntactic variables.
5218         * symmisc.c (_initialize_symmisc): Use upper case for
5219         metasyntactic variables.
5220         * psymtab.c (_initialize_psymtab): Use upper case for
5221         metasyntactic variables.
5222         * demangle.c (demangle_command): Use upper case for metasyntactic
5223         variables.
5224         (_initialize_demangler): Likewise.
5225         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5226         variables.
5227
5228 2019-01-03  Tom Tromey  <tom@tromey.com>
5229
5230         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5231
5232 2019-01-03  Tom Tromey  <tom@tromey.com>
5233
5234         * python/py-symtab.c (salpy_str): Update.
5235         (struct salpy_sal_object) <symtab>: Now a PyObject.
5236         (salpy_dealloc): Update.
5237         (del_objfile_sal): Use gdbpy_ref.
5238
5239 2019-01-03  Tom Tromey  <tom@tromey.com>
5240
5241         * python/py-type.c (convert_field): Use new_reference.  Return
5242         gdbpy_ref.
5243         (make_fielditem): Return gdbpy_ref.
5244         (typy_fields): Update.
5245         (typy_getitem): Update.
5246         (field_name): Return gdbpy_ref.  Use new_reference.
5247         (typy_iterator_iternext): Update.
5248
5249 2019-01-03  Tom Tromey  <tom@tromey.com>
5250
5251         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5252
5253 2019-01-03  Tom Tromey  <tom@tromey.com>
5254
5255         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5256         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5257         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5258         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5259         (pspy_set_type_printers): Likewise.
5260         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5261         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5262         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5263         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5264         (objfpy_set_type_printers): Likewise.
5265
5266 2019-01-03  Tom Tromey  <tom@tromey.com>
5267
5268         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5269         (gdbpy_print_stack): Use gdbpy_err_fetch.
5270         * python/python-internal.h (class gdbpy_err_fetch): New class.
5271         (class gdbpy_enter) <m_error_type, m_error_value,
5272         m_error_traceback>: Remove.
5273         <m_error>: New member.
5274         (gdbpy_exception_to_string): Don't declare.
5275         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5276         * python/py-value.c (convert_value_from_python): Use
5277         gdbpy_err_fetch.
5278         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5279         gdbpy_exception_to_string.
5280         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5281         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5282         gdbpy_err_fetch.
5283
5284 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5285
5286         * linux-nat.c (delete_lwp_cleanup): Delete.
5287         (struct lwp_deleter): New struct.
5288         (lwp_info_up): New typedef.
5289         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5290         lwp_info_up.
5291
5292 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5293
5294         * linux-fork.c (class scoped_switch_fork_info): New class.
5295         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5296
5297 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5298
5299         * valops.c (find_overload_match): Remove use of null_cleanup, and
5300         calls to do_cleanups.
5301
5302 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5303
5304         * compile/compile-cplus-types.c
5305         (compile_cplus_instance::decl_name): Handle changes to
5306         cp_func_name.
5307         * cp-support.c (cp_func_name): Update header comment, update
5308         return type.
5309         * cp-support.h (cp_func_name): Update return type in declaration.
5310         * valops.c (find_overload_match): Move temp_func local to top
5311         level of function and change its type.  Use temp_func to hold and
5312         delete temporary string obtained from cp_func_name.
5313
5314 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5315
5316         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5317         gdb::char_vector, remove cleanup, and update uses of `msg`.
5318
5319 2019-01-03  Jim Wilson  <jimw@sifive.com>
5320
5321         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5322
5323 2019-01-02  Tom Tromey  <tom@tromey.com>
5324
5325         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5326         (tdesc_parse_xml): Remove cleanups.
5327         * target-descriptions.h (make_cleanup_free_target_description):
5328         Don't declare.
5329         (target_desc_deleter): New struct.
5330         (target_desc_up): New typedef.
5331         * target-descriptions.c (target_desc_deleter::operator()): Rename
5332         from free_target_description.
5333         (make_cleanup_free_target_description): Remove.
5334
5335 2019-01-02  Tom Tromey  <tom@tromey.com>
5336
5337         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5338         constructor, destructor.
5339         (linespec_parser): Remove typedef.
5340         (~linespec_parser): Rename from linespec_parser_delete.
5341         (linespec_lex_to_end, linespec_complete_label)
5342         (linespec_complete): Update.
5343         (decode_line_full): Remove cleanups.
5344         (decode_line_1): Update.
5345
5346 2019-01-02  Tom Tromey  <tom@tromey.com>
5347
5348         * python/python-internal.h (inferior_to_inferior_object): Change
5349         return type.
5350         * python/py-exitedevent.c (create_exited_event_object): Update.
5351         * python/py-inferior.c (inferior_to_inferior_object): Return
5352         gdbpy_ref.
5353         (python_new_inferior, python_inferior_deleted)
5354         (thread_to_thread_object, delete_thread_object)
5355         (build_inferior_list, gdbpy_selected_inferior): Update.
5356         * python/py-infthread.c (create_thread_object): Update.  Also fail
5357         if inferior_to_inferior_object fails.
5358
5359 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5360
5361         * inferior.h (class inferior) <displaced_step_state>: New field.
5362         * infrun.h (struct displaced_step_state): Move here from
5363         infrun.c.  Initialize fields, add constructor.
5364         <inf>: Remove field.
5365         <reset>: New method.
5366         * infrun.c (struct displaced_step_inferior_state): Move to
5367         infrun.h.
5368         (displaced_step_inferior_states): Remove.
5369         (get_displaced_stepping_state): Adust.
5370         (displaced_step_in_progress_any_inferior): Adjust.
5371         (displaced_step_in_progress_thread): Adjust.
5372         (displaced_step_in_progress): Adjust.
5373         (add_displaced_stepping_state): Remove.
5374         (get_displaced_step_closure_by_addr): Adjust.
5375         (remove_displaced_stepping_state): Remove.
5376         (infrun_inferior_exit): Call displaced_step_state.reset.
5377         (use_displaced_stepping): Don't check for NULL.
5378         (displaced_step_prepare_throw): Call
5379         get_displaced_stepping_state.
5380         (displaced_step_fixup): Don't check for NULL.
5381         (prepare_for_detach): Don't check for NULL.
5382
5383 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5384
5385         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5386          in case of call that did not complete.
5387
5388 2019-01-02  Andrey Utkin  <autkin@undo.io>
5389
5390         * symfile.c (find_separate_debug_file): Fix search of debug files for
5391         remote debuggee.
5392
5393 2019-01-02  Tom Tromey  <tom@tromey.com>
5394
5395         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5396         indentation.
5397         * python/py-frame.c (frapy_older): Remove cast.
5398         (frapy_newer): Likewise.
5399         * python/py-breakpoint.c (local_setattro): Remove cast.
5400         * python/py-arch.c (archpy_name): Remove local variable.
5401         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5402
5403 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5404
5405         * unittests/basic_string_view/element_access/char/empty.cc:
5406         Fix year range in copyright header.
5407
5408 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5409
5410         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5411         Delete.
5412         <operator==>: Update with for removed field.
5413         <hash>: Likewise.
5414         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5415         <isa_features>: ...this.
5416         <abi_features>: New field.
5417         (riscv_isa_flen): Update comment.
5418         (riscv_abi_xlen): New declaration.
5419         (riscv_abi_flen): New declaration.
5420         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5421         isa_features.
5422         (riscv_abi_xlen): New function.
5423         (riscv_isa_flen): Update to get answer from isa_features.
5424         (riscv_abi_flen): New function.
5425         (riscv_has_fp_abi): Update to get answer from abi_features.
5426         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5427         xlen and flen.
5428         (riscv_call_info) <xlen, flen>: Update comment.
5429         (riscv_call_arg_struct): Remove invalid assertions
5430         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5431         is removed.
5432         (riscv_gdbarch_init): Gather isa features and abi features
5433         separately, ensure both match on the gdbarch when reusing an old
5434         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5435         a target with 64-bit float hardware.
5436
5437 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5438
5439         * source.c (search_command_helper): Stop reverse search
5440         when line 1 has been searched.
5441
5442 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5443
5444         * record-full.c (record_full_base_target::close): Rewrite
5445         record_full_core_buf_list free logic.
5446
5447 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5448
5449         * break-catch-syscall.c (print_one_catch_syscall): xfree
5450         the last text.
5451
5452 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5453
5454         * top.c (print_gdb_version): Update Copyright year in version
5455         message.
5456
5457 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5458
5459         Update copyright year range in all GDB files.
5460
5461 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5462
5463         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5464
5465 For older changes see ChangeLog-2018.
5466 \f
5467 Local Variables:
5468 mode: change-log
5469 left-margin: 8
5470 fill-column: 74
5471 version-control: never
5472 coding: utf-8
5473 End:
5474