Sort includes for files gdb/[a-f]*.[chyl].
[external/binutils.git] / gdb / ChangeLog
1 2019-04-05  Tom Tromey  <tom@tromey.com>
2
3         * ft32-tdep.c: Sort headers.
4         * frv-tdep.c: Sort headers.
5         * frv-linux-tdep.c: Sort headers.
6         * frame.c: Sort headers.
7         * frame-unwind.c: Sort headers.
8         * frame-base.c: Sort headers.
9         * fork-child.c: Sort headers.
10         * findvar.c: Sort headers.
11         * findcmd.c: Sort headers.
12         * filesystem.c: Sort headers.
13         * filename-seen-cache.h: Sort headers.
14         * filename-seen-cache.c: Sort headers.
15         * fbsd-tdep.c: Sort headers.
16         * fbsd-nat.h: Sort headers.
17         * fbsd-nat.c: Sort headers.
18         * f-valprint.c: Sort headers.
19         * f-typeprint.c: Sort headers.
20         * f-lang.c: Sort headers.
21         * extension.h: Sort headers.
22         * extension.c: Sort headers.
23         * extension-priv.h: Sort headers.
24         * expprint.c: Sort headers.
25         * exec.h: Sort headers.
26         * exec.c: Sort headers.
27         * exceptions.c: Sort headers.
28         * event-top.c: Sort headers.
29         * event-loop.c: Sort headers.
30         * eval.c: Sort headers.
31         * elfread.c: Sort headers.
32         * dwarf2read.h: Sort headers.
33         * dwarf2read.c: Sort headers.
34         * dwarf2loc.c: Sort headers.
35         * dwarf2expr.h: Sort headers.
36         * dwarf2expr.c: Sort headers.
37         * dwarf2-frame.c: Sort headers.
38         * dwarf2-frame-tailcall.c: Sort headers.
39         * dwarf-index-write.h: Sort headers.
40         * dwarf-index-write.c: Sort headers.
41         * dwarf-index-common.c: Sort headers.
42         * dwarf-index-cache.h: Sort headers.
43         * dwarf-index-cache.c: Sort headers.
44         * dummy-frame.c: Sort headers.
45         * dtrace-probe.c: Sort headers.
46         * disasm.h: Sort headers.
47         * disasm.c: Sort headers.
48         * disasm-selftests.c: Sort headers.
49         * dictionary.c: Sort headers.
50         * dicos-tdep.c: Sort headers.
51         * demangle.c: Sort headers.
52         * dcache.h: Sort headers.
53         * dcache.c: Sort headers.
54         * darwin-nat.h: Sort headers.
55         * darwin-nat.c: Sort headers.
56         * darwin-nat-info.c: Sort headers.
57         * d-valprint.c: Sort headers.
58         * d-namespace.c: Sort headers.
59         * d-lang.c: Sort headers.
60         * ctf.c: Sort headers.
61         * csky-tdep.c: Sort headers.
62         * csky-linux-tdep.c: Sort headers.
63         * cris-tdep.c: Sort headers.
64         * cris-linux-tdep.c: Sort headers.
65         * cp-valprint.c: Sort headers.
66         * cp-support.c: Sort headers.
67         * cp-namespace.c: Sort headers.
68         * cp-abi.c: Sort headers.
69         * corelow.c: Sort headers.
70         * corefile.c: Sort headers.
71         * continuations.c: Sort headers.
72         * completer.h: Sort headers.
73         * completer.c: Sort headers.
74         * complaints.c: Sort headers.
75         * coffread.c: Sort headers.
76         * coff-pe-read.c: Sort headers.
77         * cli-out.h: Sort headers.
78         * cli-out.c: Sort headers.
79         * charset.c: Sort headers.
80         * c-varobj.c: Sort headers.
81         * c-valprint.c: Sort headers.
82         * c-typeprint.c: Sort headers.
83         * c-lang.c: Sort headers.
84         * buildsym.c: Sort headers.
85         * buildsym-legacy.c: Sort headers.
86         * build-id.h: Sort headers.
87         * build-id.c: Sort headers.
88         * btrace.c: Sort headers.
89         * bsd-uthread.c: Sort headers.
90         * breakpoint.h: Sort headers.
91         * breakpoint.c: Sort headers.
92         * break-catch-throw.c: Sort headers.
93         * break-catch-syscall.c: Sort headers.
94         * break-catch-sig.c: Sort headers.
95         * blockframe.c: Sort headers.
96         * block.c: Sort headers.
97         * bfin-tdep.c: Sort headers.
98         * bfin-linux-tdep.c: Sort headers.
99         * bfd-target.c: Sort headers.
100         * bcache.c: Sort headers.
101         * ax-general.c: Sort headers.
102         * ax-gdb.h: Sort headers.
103         * ax-gdb.c: Sort headers.
104         * avr-tdep.c: Sort headers.
105         * auxv.c: Sort headers.
106         * auto-load.c: Sort headers.
107         * arm-wince-tdep.c: Sort headers.
108         * arm-tdep.c: Sort headers.
109         * arm-symbian-tdep.c: Sort headers.
110         * arm-pikeos-tdep.c: Sort headers.
111         * arm-obsd-tdep.c: Sort headers.
112         * arm-nbsd-tdep.c: Sort headers.
113         * arm-nbsd-nat.c: Sort headers.
114         * arm-linux-tdep.c: Sort headers.
115         * arm-linux-nat.c: Sort headers.
116         * arm-fbsd-tdep.c: Sort headers.
117         * arm-fbsd-nat.c: Sort headers.
118         * arm-bsd-tdep.c: Sort headers.
119         * arch-utils.c: Sort headers.
120         * arc-tdep.c: Sort headers.
121         * arc-newlib-tdep.c: Sort headers.
122         * annotate.h: Sort headers.
123         * annotate.c: Sort headers.
124         * amd64-windows-tdep.c: Sort headers.
125         * amd64-windows-nat.c: Sort headers.
126         * amd64-tdep.c: Sort headers.
127         * amd64-sol2-tdep.c: Sort headers.
128         * amd64-obsd-tdep.c: Sort headers.
129         * amd64-obsd-nat.c: Sort headers.
130         * amd64-nbsd-tdep.c: Sort headers.
131         * amd64-nbsd-nat.c: Sort headers.
132         * amd64-nat.c: Sort headers.
133         * amd64-linux-tdep.c: Sort headers.
134         * amd64-linux-nat.c: Sort headers.
135         * amd64-fbsd-tdep.c: Sort headers.
136         * amd64-fbsd-nat.c: Sort headers.
137         * amd64-dicos-tdep.c: Sort headers.
138         * amd64-darwin-tdep.c: Sort headers.
139         * amd64-bsd-nat.c: Sort headers.
140         * alpha-tdep.c: Sort headers.
141         * alpha-obsd-tdep.c: Sort headers.
142         * alpha-nbsd-tdep.c: Sort headers.
143         * alpha-mdebug-tdep.c: Sort headers.
144         * alpha-linux-tdep.c: Sort headers.
145         * alpha-linux-nat.c: Sort headers.
146         * alpha-bsd-tdep.c: Sort headers.
147         * alpha-bsd-nat.c: Sort headers.
148         * aix-thread.c: Sort headers.
149         * agent.c: Sort headers.
150         * addrmap.c: Sort headers.
151         * ada-varobj.c: Sort headers.
152         * ada-valprint.c: Sort headers.
153         * ada-typeprint.c: Sort headers.
154         * ada-tasks.c: Sort headers.
155         * ada-lang.c: Sort headers.
156         * aarch64-tdep.c: Sort headers.
157         * aarch64-ravenscar-thread.c: Sort headers.
158         * aarch64-newlib-tdep.c: Sort headers.
159         * aarch64-linux-tdep.c: Sort headers.
160         * aarch64-linux-nat.c: Sort headers.
161         * aarch64-fbsd-tdep.c: Sort headers.
162         * aarch64-fbsd-nat.c: Sort headers.
163         * aarch32-linux-nat.c: Sort headers.
164
165 2019-04-04  Tom Tromey  <tom@tromey.com>
166
167         * varobj.c (varobj_create): Update.
168         * rust-exp.y (struct rust_parser) <update_innermost_block,
169         lookup_symbol>: New methods.
170         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
171         Rename.
172         (rust_parser::rust_lookup_type)
173         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
174         * printcmd.c (display_command, do_one_display): Update.
175         * parser-defs.h (struct parser_state) <parser_state>: Add
176         "tracker" parameter.
177         (block_tracker): New member.
178         (class innermost_block_tracker) <innermost_block_tracker>: Add
179         "types" parameter.
180         <reset>: Remove method.
181         (innermost_block): Don't declare.
182         (null_post_parser): Update.
183         * parse.c (innermost_block): Remove global.
184         (write_dollar_variable): Update.
185         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
186         Remove "tracker_types" parameter.
187         (parse_expression): Add "tracker" parameter.
188         (parse_expression_for_completion): Update.
189         (null_post_parser): Add "tracker" parameter.
190         * p-exp.y: Update rules.
191         * m2-exp.y: Update rules.
192         * language.h (struct language_defn) <la_post_parser>: Add
193         "tracker" parameter.
194         * go-exp.y: Update rules.
195         * f-exp.y: Update rules.
196         * expression.h (parse_expression, parse_exp_1): Add "tracker"
197         parameter.
198         * d-exp.y: Update rules.
199         * c-exp.y: Update rules.
200         * breakpoint.c (set_breakpoint_condition): Create an
201         innermost_block_tracker.
202         (watch_command_1): Likewise.
203         * ada-lang.c (resolve): Add "tracker" parameter.
204         (resolve_subexp): Likewise.
205         * ada-exp.y (write_var_from_sym): Update.
206
207 2019-04-04  Tom Tromey  <tom@tromey.com>
208
209         * type-stack.h: New file.
210         * type-stack.c: New file.
211         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
212         type-stack.h.
213         (insert_into_type_stack, insert_type, push_type, push_type_int)
214         (insert_type_address_space, pop_type, pop_type_int)
215         (pop_typelist, pop_type_stack, append_type_stack)
216         (push_type_stack, get_type_stack, push_typelist)
217         (follow_type_instance_flags, follow_types): Don't declare.
218         * parse.c (type_stack): Remove global.
219         (parse_exp_in_context): Update.
220         (insert_into_type_stack, insert_type, push_type, push_type_int)
221         (insert_type_address_space, pop_type, pop_type_int)
222         (pop_typelist, pop_type_stack, append_type_stack)
223         (push_type_stack, get_type_stack, push_typelist)
224         (follow_type_instance_flags, follow_types): Remove (moved to
225         type-stack.c).
226         * f-exp.y (type_stack): New global.
227         Update rules.
228         (push_kind_type, f_parse): Update.
229         * d-exp.y (type_stack): New global.
230         Update rules.
231         (d_parse): Update.
232         * c-exp.y (struct c_parse_state) <type_stack>: New member.
233         Update rules.
234         * Makefile.in (COMMON_SFILES): Add type-stack.c.
235         (HFILES_NO_SRCDIR): Add type-stack.h.
236
237 2019-04-04  Tom Tromey  <tom@tromey.com>
238
239         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
240         (rust_parser::convert_ast_to_expression, rust_parse)
241         (rust_lex_test_completion, rust_lex_tests): Update.
242         * parser-defs.h (struct expr_completion_state): New.
243         (struct parser_state) <parser_state>: Add completion parameter.
244         <mark_struct_expression, mark_completion_tag>: New methods.
245         <parse_completion, m_completion_state>: New members.
246         (prefixify_expression, null_post_parser): Update.
247         (mark_struct_expression, mark_completion_tag): Don't declare.
248         * parse.c (parse_completion, expout_last_struct)
249         (expout_tag_completion_type, expout_completion_name): Remove
250         globals.
251         (parser_state::mark_struct_expression)
252         (parser_state::mark_completion_tag): Now methods.
253         (prefixify_expression): Add last_struct parameter.
254         (prefixify_subexp): Likewise.
255         (parse_exp_1): Update.
256         (parse_exp_in_context): Add cstate parameter.  Update.
257         (parse_expression_for_completion): Create an
258         expr_completion_state.
259         (null_post_parser): Add "completion" parameter.
260         * p-exp.y: Update rules.
261         (yylex): Update.
262         * language.h (struct language_defn) <la_post_parser>: Add
263         "completing" parameter.
264         * go-exp.y: Update rules.
265         (lex_one_token): Update.
266         * expression.h (parse_completion): Don't declare.
267         * d-exp.y: Update rules.
268         (lex_one_token): Update rules.
269         * c-exp.y: Update rules.
270         (lex_one_token): Update.
271         * ada-lang.c (resolve): Add "parse_completion" parameter.
272         (resolve_subexp): Likewise.
273         (ada_resolve_function): Likewise.
274
275 2019-04-04  Tom Tromey  <tom@tromey.com>
276
277         * parser-defs.h (struct parser_state) <start_arglist,
278         end_arglist>: New methods.
279         <arglist_len, m_funcall_chain>: New members.
280         (arglist_len, start_arglist, end_arglist): Don't declare.
281         * parse.c (arglist_len, funcall_chain): Remove global.
282         (start_arglist, end_arglist): Remove functions.
283         (parse_exp_in_context): Update.
284         * p-exp.y: Update rules.
285         * m2-exp.y: Update rules.
286         * go-exp.y: Update rules.
287         * f-exp.y: Update rules.
288         * d-exp.y: Update rules.
289         * c-exp.y: Update rules.
290
291 2019-04-04  Tom Tromey  <tom@tromey.com>
292
293         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
294         lex_operator, push_back>: New methods.
295         Update all rules.
296         (rust_parser::lex_hex, lex_escape): Rename and update.
297         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
298         (rust_parser::lex_operator): Rename and update.
299         (rust_parser::lex_number, rustyylex, rustyyerror)
300         (rust_lex_test_init, rust_lex_test_sequence)
301         (rust_lex_test_push_back, rust_lex_tests): Update.
302         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
303         parameter.
304         <lexptr, prev_lexptr>: New members.
305         (lexptr, prev_lexptr): Don't declare.
306         * parse.c (lexptr, prev_lexptr): Remove globals.
307         (parse_exp_in_context): Update.
308         * p-exp.y (yylex, yyerror): Update.
309         * m2-exp.y (parse_number, yylex, yyerror): Update.
310         * go-exp.y (lex_one_token, yyerror): Update.
311         * f-exp.y (match_string_literal, yylex, yyerror): Update.
312         * d-exp.y (lex_one_token, yyerror): Update.
313         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
314         (lex_one_token, yyerror): Update.
315         * ada-lex.l (YY_INPUT): Update.
316         (rewind_to_char): Update.
317         * ada-exp.y (yyerror): Update.
318
319 2019-04-04  Tom Tromey  <tom@tromey.com>
320
321         * rust-exp.y (rustyylex, rust_lex_tests): Update.
322         * parser-defs.h (struct parser_state) <parser_state>: Add new
323         parameter.
324         <comma_terminates>: New member.
325         (comma_terminates): Don't declare global.
326         * parse.c (comma_terminates): Remove global.
327         (parse_exp_in_context): Update.
328         * p-exp.y (yylex): Update.
329         * m2-exp.y (yylex): Update.
330         * go-exp.y (lex_one_token): Update.
331         * f-exp.y (yylex): Update.
332         * d-exp.y (lex_one_token): Update.
333         * c-exp.y (lex_one_token): Update.
334         * ada-lex.l: Update.
335
336 2019-04-04  Tom Tromey  <tom@tromey.com>
337
338         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
339         (rustyylex, rust_lex_test_init, rust_lex_test_one)
340         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
341         * parser-defs.h (paren_depth): Don't declare.
342         * parse.c (paren_depth): Remove global.
343         (parse_exp_in_context): Update.
344         * p-exp.y (paren_depth): New global.
345         (pascal_parse): Initialize it.
346         * m2-exp.y (paren_depth): New global.
347         (m2_parse): Initialize it.
348         * go-exp.y (paren_depth): New global.
349         (go_parse): Initialize it.
350         * f-exp.y (paren_depth): New global.
351         (f_parse): Initialize it.
352         * d-exp.y (paren_depth): New global.
353         (d_parse): Initialize it.
354         * c-exp.y (paren_depth): New global.
355         (c_parse): Initialize it.
356         * ada-lex.l (paren_depth): New global.
357         (lexer_init): Initialize it.
358
359 2019-04-04  Tom Tromey  <tom@tromey.com>
360
361         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
362         (rust_parser::convert_ast_to_type)
363         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
364         * parser-defs.h (struct parser_state) <parser_state>: Add
365         parameters.  Initialize new members.
366         <expression_context_block, expression_context_pc>: New members.
367         * parse.c (expression_context_block, expression_context_pc):
368         Remove globals.
369         (parse_exp_in_context): Update.
370         * p-exp.y: Update all rules.
371         (yylex): Update.
372         * m2-exp.y: Update all rules.
373         (yylex): Update.
374         * go-exp.y (yylex): Update.
375         * f-exp.y (yylex): Update.
376         * d-exp.y: Update all rules.
377         (yylex): Update.
378         * c-exp.y: Update all rules.
379         (lex_one_token, classify_name, yylex, c_parse): Update.
380         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
381
382 2019-04-04  Tom Tromey  <tom@tromey.com>
383
384         * gdbarch.h, gdbarch.c: Rebuild.
385         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
386         * stap-probe.h: 
387         (struct stap_parse_info): Replace "parser_state" with
388         "expr_builder".
389         * parser-defs.h (struct expr_builder): Rename from "parser_state".
390         (parser_state): New class.
391         * parse.c (expr_builder): Rename.
392         (expr_builder::release): Rename.
393         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
394         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
395         (write_exp_elt_longcst, write_exp_elt_floatcst)
396         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
397         (write_exp_string_vector, write_exp_bitstring)
398         (write_exp_msymbol, mark_struct_expression)
399         (write_dollar_variable)
400         (insert_type_address_space, increase_expout_size): Replace
401         "parser_state" with "expr_builder".
402         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
403         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
404         "parser_state" with "expr_builder".
405
406 2019-04-04  Tom Tromey  <tom@tromey.com>
407
408         * rust-exp.y: Replace "parse_language" with method call.
409         * p-exp.y: 
410         (yylex): Replace "parse_language" with method call.
411         * m2-exp.y: 
412         (yylex): Replace "parse_language" with method call.
413         * go-exp.y (classify_name): Replace "parse_language" with method
414         call.
415         * f-exp.y (yylex): Replace "parse_language" with method call.
416         * d-exp.y (lex_one_token): Replace "parse_language" with method
417         call.
418         * c-exp.y: 
419         (lex_one_token, classify_name, yylex): Replace "parse_language"
420         with method call.
421         * ada-exp.y (find_primitive_type, type_char)
422         (type_system_address): Replace "parse_language" with method call.
423
424 2019-04-04  Tom Tromey  <tom@tromey.com>
425
426         * rust-exp.y: Replace "parse_gdbarch" with method call.
427         * parse.c (write_dollar_variable, insert_type_address_space):
428         Replace "parse_gdbarch" with method call.
429         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
430         call.
431         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
432         call.
433         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
434         "parse_gdbarch" with method call.
435         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
436         with method call.
437         * f-exp.y (parse_type, parse_f_type, yylex): Replace
438         "parse_gdbarch" with method call.
439         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
440         "parse_gdbarch" with method call.
441         * c-exp.y (parse_type, parse_number, classify_name): Replace
442         "parse_gdbarch" with method call.
443         * ada-lex.l: Replace "parse_gdbarch" with method call.
444         * ada-exp.y (parse_type, find_primitive_type, type_char)
445         (type_system_address): Replace "parse_gdbarch" with method call.
446
447 2019-04-04  Tom Tromey  <tom@tromey.com>
448
449         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
450         * stap-probe.c (stap_parse_argument): Update.
451         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
452         initial_size parameter.
453         * rust-exp.y (rust_lex_tests): Update.
454         * parse.c (parser_state): Update.
455         (parse_exp_in_context): Update.
456         * parser-defs.h (struct parser_state) <parser_state>: Remove
457         "initial_size" parameter.
458
459 2019-04-04  Tom Tromey  <tom@tromey.com>
460
461         * parser-defs.h (increase_expout_size): Don't declare.
462         * parse.c (increase_expout_size): Now static.
463
464 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
465
466         * gnu-nat.c (gnu_nat_target::wait): Fix
467         target_waitstatus_to_string call.
468
469 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
470
471         * eval.c (evaluate_subexp_standard): Handle internal functions
472         during Fortran function call handling.
473
474 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
475
476         * NEWS: Mention new internal functions.
477         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
478         (read_base_type): Use dwarf2_init_complex_target_type.
479         * value.c (creal_internal_fn): New function.
480         (cimag_internal_fn): New function.
481         (_initialize_values): Register new internal functions.
482
483 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
484
485         * infrun.c (stop_all_threads): If debug_infrun, always
486         trace the wait status after wait_one, using
487         target_waitstatus_to_string and target_pid_to_str.
488         (handle_inferior_event): Replace various trace of
489         wait status kind by a single trace.
490         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
491         wait status kind image by target_waitstatus_to_string.
492         * target/waitstatus.c (target_waitstatus_to_string): Fix
493         obsolete comment.
494
495 2019-04-01  Tom Tromey  <tromey@adacore.com>
496
497         PR symtab/23331:
498         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
499
500 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
501             Pedro Alves  <palves@redhat.com>
502
503         * top.c (quit_force): Call 'finalize_values'.
504         * value.c (finalize_values): New function.
505         * value.h (finalize_values): Declare.
506
507 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
508
509         * NEWS: Announce $_gdb_major and $_gdb_minor.
510
511         * top.c (init_gdb_version_vars): New function.
512         (gdb_init): Call init_gdb_version_vars.
513
514 2019-03-29  Tom Tromey  <tromey@adacore.com>
515
516         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
517         help text.  Remove dead code.
518
519 2019-03-29  Keith Seitz  <keiths@redhat.com>
520
521         From Siddhesh Poyarekar:
522         * f-lang.h (f77_get_upperbound): Return LONGEST.
523         (f77_get_lowerbound): Likewise.
524         * f-typeprint.c (f_type_print_varspec_suffix): Expand
525         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
526         print them.
527         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
528         plongest to format print it.
529         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
530         (f77_get_upperbound): Likewise.
531         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
532         LOWER_BOUND to LONGEST.
533         (f77_create_arrayprint_offset_tbl): Likewise.
534
535 2019-03-29  Keith Seitz  <keiths@redhat.com>
536
537         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
538         %s/pulongest for TYPE_LENGTH instead of %d in format
539         strings.
540         * ada-typerint.c (ada_print_type): Likewise.
541         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
542         * compile/compile-c-support.c (generate_register_struct): Likewise.
543         * gdbtypes.c (recursive_dump_type): Likewise.
544         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
545         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
546         instead of %d in format strings.
547         * riscv-tdep.c (riscv_type_alignment): Cast second argument
548         to std::min to ULONGEST.
549         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
550         instead of %d in format strings.
551         * tracepoint.c (info_scope_command): Likewise.
552         * typeprint.c (print_offset_data::update)
553         (print_offset_data::finish): Likewise.
554         * xtensa-tdep.c (xtensa_store_return_value)
555         (xtensa_push_dummy_call): Likewise.
556
557 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
558
559         * windows-nat.c (display_selector): Fixed format specifications
560         for 64-bit Cygwin.
561
562 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
563
564         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
565
566 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
567
568         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
569         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
570         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
571         (nios2_linux_init_abi): Install it.
572
573 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
574
575         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
576
577 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
578
579         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
580
581 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
582             Tom Tromey  <tromey@adacore.com>
583
584         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
585
586 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
587
588         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
589         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
590         method to compute the bounds of range types. Also print "[evaluated]"
591         if the bounds' values come from a dynamic evaluation.
592
593 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
594
595         * cp-valprint.c (cp_print_value_fields): Don't print trailing
596         whitespace when pretty printing is on.
597
598 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
599
600         * ppc-linux-nat.c: Add include.
601
602 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
603
604         * NEWS: Mention AArch64 Pointer Authentication.
605
606 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
607
608         * arm-linux-nat.c: Add include.
609
610 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
611
612         * source-cache.c (source_cache::get_source_lines): Re-read
613         fullname after calling open_source_file.
614
615 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
616
617         * NEWS: Mention TLS support for FreeBSD.
618
619 2019-03-25  Tom Tromey  <tromey@adacore.com>
620
621         * minsyms.c (BUNCH_SIZE): Update comment.
622         (~minimal_symbol_reader): Remove old comment.
623         (compact_minimal_symbols): Update comment.
624         (minimal_symbol_reader::install): Remove old comment.  Update
625         other comments.
626
627 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
628
629         * s390-linux-nat.c: Add include.
630
631 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
632
633         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
634         Call linux_get_hwcap.
635         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
636         Likewise.
637         (aarch64_linux_get_hwcap): Remove function.
638         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
639         declaration.
640         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
641         linux_get_hwcap.
642         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
643         * linux-tdep.c (linux_get_hwcap): Add function.
644         (linux_get_hwcap2): Likewise.
645         * linux-tdep.h (linux_get_hwcap): Add declaration.
646         (linux_get_hwcap2): Likewise.
647         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
648         (ppc_linux_get_hwcap2): Likewise.
649         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
650         linux_get_hwcap.
651         (ppc_linux_nat_target::insert_watchpoint): Likewise.
652         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
653         (ppc_linux_nat_target::read_description): Likewise.
654         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
655         * s390-linux-nat.c: Likewise.
656         * s390-linux-tdep.c (s390_core_read_description): Likewise.
657
658 2019-03-24  Tom Tromey  <tom@tromey.com>
659
660         * ada-lang.c (standard_lookup): Simplify initialization.
661         (ada_lookup_symbol_nonlocal): Simplify return.
662         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
663         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
664         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
665         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
666         initialization.
667         * solib.c (solib_global_lookup): Simplify.
668         * symtab.c (null_block_symbol): Remove.
669         (symbol_cache_lookup): Simplify returns.
670         (lookup_language_this): Simplify returns.
671         (lookup_symbol_aux): Simplify return.
672         (lookup_local_symbol): Simplify returns.
673         (lookup_global_symbol_from_objfile): Simplify return.
674         (lookup_symbol_in_objfile_symtabs)
675         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
676         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
677         (lookup_static_symbol, lookup_global_symbol): Simplify return.
678         * cp-namespace.c (cp_lookup_bare_symbol)
679         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
680         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
681         (cp_lookup_nested_symbol): Don't use null_block_symbol.
682         (cp_lookup_symbol_via_imports): Simplify initialization.
683         (find_symbol_in_baseclass): Likewise.
684         * symtab.h (null_block_symbol): Remove.
685         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
686         (d_lookup_nested_symbol, d_lookup_symbol_imports)
687         (d_lookup_symbol_module): Likewise.
688         (find_symbol_in_baseclass): Simplify initialization.
689
690 2019-03-24  Tom Tromey  <tom@tromey.com>
691
692         * expression.h: Don't include symtab.h.
693         (struct block): Forward declare.
694
695 2019-03-24  Tom Tromey  <tom@tromey.com>
696
697         * c-exp.y (typebase): Remove casts.
698         * gdbtypes.c (lookup_unsigned_typename, )
699         (lookup_signed_typename): Remove cast.
700         * eval.c (parse_to_comma_and_eval): Remove cast.
701         * parse.c (write_dollar_variable): Remove cast.
702         * block.h (struct block) <superblock>: Now const.
703         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
704         * psymtab.c (psym_map_matching_symbols): Make "block" const.
705         (map_block): Make "block" const.
706         * symfile.h (struct quick_symbol_functions)
707         <map_matching_symbols>: Constify block argument to "callback".
708         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
709         const.
710         (find_pc_sect_compunit_symtab): Make "b" const.
711         (find_symbol_at_address): Likewise.
712         (search_symbols): Likewise.
713         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
714         (dw2_debug_names_lookup_symbol): Likewise.
715         (dw2_map_matching_symbols): Update.
716         * p-valprint.c (pascal_val_print): Remove "block".
717         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
718         (aux_add_nonlocal_symbols): Make "block" const.
719         (resolve_subexp): Remove cast.
720         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
721         const.
722         (iterate_over_file_blocks): Likewise.
723         * f-exp.y (%union) <bval>: Remove.
724         * coffread.c (patch_opaque_types): Make "b" const.
725         * spu-tdep.c (spu_catch_start): Make "block" const.
726         * c-valprint.c (print_unpacked_pointer): Remove "block".
727         * symmisc.c (dump_symtab_1): Make "b" const.
728         (block_depth): Make "block" const.
729         * d-exp.y (%union) <bval>: Remove.
730         * cp-support.h (cp_lookup_rtti_type): Update.
731         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
732         * psymtab.c (psym_lookup_symbol): Make "block" const.
733         (maintenance_check_psymtabs): Make "b" const.
734         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
735         (enumerate_locals, enumerate_args): Update.
736         * python/py-symtab.c (stpy_global_block): Make "block" const.
737         (stpy_static_block): Likewise.
738         * inline-frame.c (block_starting_point_at): Make "new_block"
739         const.
740         * block.c (find_block_in_blockvector): Make return type const.
741         (blockvector_for_pc_sect): Make "b" const.
742         (find_block_in_blockvector): Make "b" const.
743
744 2019-03-23  Tom Tromey  <tom@tromey.com>
745
746         * varobj.c (varobj_create): Update.
747         * symfile.c (clear_symtab_users): Don't reset innermost_block.
748         * printcmd.c (display_command, do_one_display): Don't reset
749         innermost_block.
750         * parser-defs.h (enum innermost_block_tracker_type): Move to
751         expression.h.
752         (innermost_block): Update comment.
753         * parse.c (parse_exp_1): Add tracker_types parameter.
754         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
755         tracker_types parameter.  Reset innermost_block.
756         (parse_exp_in_context): Remove.
757         (parse_expression_for_completion): Update.
758         * objfiles.c (~objfile): Don't reset expression_context_block or
759         innermost_block.
760         * expression.h (enum innermost_block_tracker_type): Move from
761         parser-defs.h.
762         (parse_exp_1): Add tracker_types parameter.
763         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
764         reset innermost_block.
765
766 2019-03-23  Tom Tromey  <tom@tromey.com>
767
768         * objfiles.h: Include bcache.h.
769
770 2019-03-23  Tom Tromey  <tom@tromey.com>
771
772         * linespec.c (get_current_search_block): Use
773         scoped_restore_current_language.
774         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
775
776 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
777             Jiong Wang  <jiong.wang@arm.com>
778
779         * aarch64-linux-tdep.c
780         (aarch64_linux_iterate_over_regset_sections): Check for pauth
781         section.
782         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
783
784 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
785             Jiong Wang  <jiong.wang@arm.com>
786
787         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
788         instructions.
789         (aarch64_analyze_prologue_test): Add PACIASP test.
790         (aarch64_prologue_prev_register): Unmask PC value.
791
792 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
793             Jiong Wang  <jiong.wang@arm.com>
794
795         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
796         (aarch64_dwarf2_prev_register): Unmask PC value.
797         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
798         (aarch64_execute_dwarf_cfa_vendor_op): Check for
799         DW_CFA_AARCH64_negate_ra_state.
800         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
801
802 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
803             Jiong Wang  <jiong.wang@arm.com>
804
805         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
806         registers.
807         (aarch64_pseudo_register_name): Likewise.
808         (aarch64_pseudo_register_type): Likewise.
809         (aarch64_pseudo_register_reggroup_p): Likewise.
810         (aarch64_gdbarch_init): Add pauth registers.
811         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
812         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
813         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
814         (struct gdbarch_tdep): Add regnum for ra_state.
815
816 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
817             Jiong Wang  <jiong.wang@arm.com>
818
819         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
820
821 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
822             Jiong Wang  <jiong.wang@arm.com>
823
824         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
825         function.
826         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
827         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
828         (aarch64_gdbarch_init): Add puth registers.
829         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
830         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
831         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
832
833 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
834             Jiong Wang  <jiong.wang@arm.com>
835
836         * aarch64-linux-nat.c
837         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
838         * aarch64-linux-tdep.c
839         (aarch64_linux_core_read_description): Likewise.
840         (aarch64_linux_get_hwcap): New function.
841         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
842         (aarch64_linux_get_hwcap): New declaration.
843
844 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
845             Jiong Wang  <jiong.wang@arm.com>
846
847         * aarch64-linux-nat.c
848         (aarch64_linux_nat_target::read_description): Add pauth param.
849         * aarch64-linux-tdep.c
850         (aarch64_linux_core_read_description): Likewise.
851         * aarch64-tdep.c (struct target_desc): Add in pauth.
852         (aarch64_read_description): Add pauth param.
853         (aarch64_gdbarch_init): Likewise.
854         * aarch64-tdep.h (aarch64_read_description): Likewise.
855         * arch/aarch64.c (aarch64_create_target_description): Likewise.
856         * arch/aarch64.h (aarch64_create_target_description): Likewise.
857         * features/Makefile: Add new files.
858         * features/aarch64-pauth.c: New file.
859         * features/aarch64-pauth.xml: New file.
860
861 2019-03-20  Tom Tromey  <tromey@adacore.com>
862
863         * infrun.c (handle_inferior_event): Rename from
864         handle_inferior_event_1.  Create a scoped_value_mark.
865         (handle_inferior_event): Remove.
866
867 2019-03-19  Tom Tromey  <tromey@adacore.com>
868
869         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
870         * infrun.h (print_stop_event): Add "displays" parameter.
871         * infrun.c (print_stop_event): Add "displays" parameter.
872
873 2019-03-19  Pedro Alves  <palves@redhat.com>
874
875         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
876         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
877         to -1.  Fix TABs vs spaces.
878         (tui_ui_out::tui_ui_out): Don't initialize fields here.
879         * tui/tui-out.h (tui_ui_out) Add intro comments.
880         <m_line, m_start_of_line>: In-class initialize, and add describing
881         comment.
882
883 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
884
885         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
886         variable names.
887         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
888
889 2019-03-18  Pedro Alves  <palves@redhat.com>
890             Eli Zaretskii <eliz@gnu.org>
891
892         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
893         m_line and m_start_of_line.
894
895 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
896
897         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
898         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
899         it returns a newline.  This fixes a regression in TU mode, whereby
900         the next line is output on the same screen line as the user input.
901
902 2019-03-18  Tom Tromey  <tromey@adacore.com>
903
904         * minsyms.c (minimal_symbol_reader::install): Remove call to
905         obstack_blank.
906
907 2019-03-18  Pedro Alves  <palves@redhat.com>
908
909         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
910         New globals.
911         (apply_style): New, factored out from ...
912         (apply_ansi_escape): ... this.  Handle reverse video mode.
913         (tui_set_reverse_mode): New function.
914         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
915         * tui/tui-winsource.c (tui_show_source_line): Use
916         tui_set_reverse_mode instead of setting A_STANDOUT.
917         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
918         New setter methods.
919
920 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
921
922         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
923         Handle tabs.
924
925 2019-03-18  Tom Tromey  <tromey@adacore.com>
926
927         * ada-lang.c (empty_array): Add "high" parameter.
928         (ada_evaluate_subexp): Update.
929
930 2019-03-17  Sergei Trofimovich <siarheit@google.com>
931
932         * unittests/string_view-selftests.c: Define
933         _initialize_string_view_selftests unconditionally.
934
935 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
936
937         PR gdb/24350
938         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
939
940 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
941
942         PR gdb/24351
943         * windows-nat.c (display_selector): Fix format specifiers.
944
945 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
946
947         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
948         tui_refill_source_window instead of tui_refresh_win, to update the
949         current execution line.  This fixes redisplay of the current line
950         when stepping through the code with "next" or "step".
951
952 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
953
954         * source-cache.c (source_cache::get_source_lines): Call
955         find_source_lines to initialize s->nlines.  This fixes vertical
956         scrolling of TUI source window when the DOWN arrow is pressed.
957
958 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
959
960         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
961         linux-thread-db.c (_initialize_thread_db): Likewise.
962
963 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
964
965         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
966         wclrtoeol in tui_show_source_line".  This reverts changes made in
967         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
968
969 2019-03-15  Tom Tromey  <tom@tromey.com>
970
971         * symtab.h (struct minimal_symbol): Derive from
972         general_symbol_info.
973         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
974         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
975         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
976         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
977         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
978         (MSYMBOL_SEARCH_NAME): Update.
979         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
980         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
981         * minsyms.c (minimal_symbol_reader::record_full): Update.
982
983 2019-03-15  Tom Tromey  <tom@tromey.com>
984
985         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
986
987 2019-03-15  Tom Tromey  <tom@tromey.com>
988
989         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
990         unique_xmalloc_ptr.
991         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
992         Update.
993         * minsyms.c (lookup_minimal_symbol_by_pc_section)
994         (build_minimal_symbol_hash_tables)
995         (minimal_symbol_reader::install): Update.
996
997 2019-03-15  Tom Tromey  <tom@tromey.com>
998
999         * symtab.c (create_demangled_names_hash): Update.
1000         (symbol_set_names): Update.
1001         * objfiles.h (struct objfile_per_bfd_storage)
1002         <demangled_names_hash>: Now an htab_up.
1003         * objfiles.c (objfile_per_bfd_storage): Simplify.
1004
1005 2019-03-15  Tom Tromey  <tom@tromey.com>
1006
1007         * objfiles.h (struct objfile_per_bfd_storage): Declare
1008         destructor.
1009         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1010         New.
1011         (get_objfile_bfd_data): Use new.  Don't initialize
1012         language_of_main.
1013         (free_objfile_per_bfd_storage): Remove.
1014         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1015
1016 2019-03-15  Tom Tromey  <tom@tromey.com>
1017
1018         * symfile.c (reread_symbols): Update.
1019         * objfiles.c (objfile::objfile): Update.
1020         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1021         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1022         comment.
1023         (minimal_symbol_reader::install): Update.
1024         (terminate_minimal_symbol_table): Remove.
1025         * jit.c (jit_object_close_impl): Update.
1026
1027 2019-03-15  Tom Tromey  <tom@tromey.com>
1028
1029         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1030         initializations.
1031
1032 2019-03-15  Tom Tromey  <tom@tromey.com>
1033
1034         * objfiles.h (struct objfile_per_bfd_storage)
1035         <demangled_hash_languages>: Now a bitset.
1036         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1037         (lookup_minimal_symbol): Update.
1038
1039 2019-03-15  Tom Tromey  <tom@tromey.com>
1040
1041         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1042         Don't return the symbol.
1043         * coffread.c (record_minimal_symbol): Use record_full.
1044
1045 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1046
1047         The MS-Windows port of ncurses fails to switch to a color pair if
1048         one or both of the colors are the implicit default colors.  This
1049         change records the default colors when TUI is initialized, and
1050         then specifies them explicitly when a color pair uses the default
1051         colors.  This allows color styling in TUI mode on MS-Windows.
1052
1053         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1054         ncurses_norm_attr.
1055         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1056         colors in ncurses_norm_attr.
1057         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1058         "none", replace it with the default color recorded in
1059         ncurses_norm_attr.
1060
1061 2019-03-14  Tom Tromey  <tromey@adacore.com>
1062
1063         * source-cache.h (class source_cache) <get_source_lines>: Return
1064         std::string.
1065         * source-cache.c (source_cache::extract_lines): Handle case where
1066         first_pos==npos.  Return std::string.
1067         (source_cache::get_source_lines): Update.
1068
1069 2019-03-14  Tom Tromey  <tromey@adacore.com>
1070
1071         * NEWS: Add item for "style sources" commands.
1072         * source-cache.c (source_cache::get_source_lines): Check
1073         source_styling.
1074         * cli/cli-style.c (source_styling): New global.
1075         (_initialize_cli_style): Add "style sources" commands.
1076         (show_style_sources): New function.
1077         * cli/cli-style.h (source_styling): Declare.
1078
1079 2019-03-14  Pedro Alves  <palves@redhat.com>
1080             Tom Tromey  <tromey@adacore.com>
1081
1082         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1083         * tui/tui-winsource.c (tui_refill_source_window): New function,
1084         from...
1085         (tui_horizontal_source_scroll): ... here.  Move some logic.
1086         * cli/cli-style.c (set_style_enabled): Notify new observable.
1087         * tui/tui-hooks.c (tui_redisplay_source): New function.
1088         (tui_attach_detach_observers): Attach or detach
1089         tui_redisplay_source.
1090         * observable.h (source_styling_changed): New observable.
1091         * observable.c: Define source_styling_changed observable.
1092
1093 2019-03-13  Tom Tromey  <tromey@adacore.com>
1094
1095         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1096         (i386_gnu_nat_target::store_registers): Update.
1097         * target-debug.h (target_debug_print_std_string): New macro.
1098         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1099         * windows-tdep.c (display_one_tib): Update.
1100         * tui/tui-stack.c (tui_make_status_line): Update.
1101         * top.c (print_inferior_quit_action): Update.
1102         * thread.c (thr_try_catch_cmd): Update.
1103         (add_thread_with_info): Update.
1104         (thread_target_id_str): Update.
1105         (thr_try_catch_cmd): Update.
1106         (thread_command): Update.
1107         (thread_find_command): Update.
1108         * record-btrace.c (record_btrace_target::info_record)
1109         (record_btrace_resume_thread, record_btrace_target::resume)
1110         (record_btrace_cancel_resume, record_btrace_step_thread)
1111         (record_btrace_target::wait, record_btrace_target::wait)
1112         (record_btrace_target::wait, record_btrace_target::stop): Update.
1113         * progspace.c (print_program_space): Update.
1114         * process-stratum-target.c
1115         (process_stratum_target::thread_address_space): Update.
1116         * linux-fork.c (linux_fork_mourn_inferior)
1117         (detach_checkpoint_command, info_checkpoints_command)
1118         (linux_fork_context): Update.
1119         (linux_fork_detach): Update.
1120         (class scoped_switch_fork_info): Update.
1121         (delete_checkpoint_command): Update.
1122         * infrun.c (follow_fork_inferior): Update.
1123         (follow_fork_inferior): Update.
1124         (proceed_after_vfork_done): Update.
1125         (handle_vfork_child_exec_or_exit): Update.
1126         (follow_exec): Update.
1127         (displaced_step_prepare_throw): Update.
1128         (displaced_step_restore): Update.
1129         (start_step_over): Update.
1130         (resume_1): Update.
1131         (clear_proceed_status_thread): Update.
1132         (proceed): Update.
1133         (print_target_wait_results): Update.
1134         (do_target_wait): Update.
1135         (context_switch): Update.
1136         (stop_all_threads): Update.
1137         (restart_threads): Update.
1138         (finish_step_over): Update.
1139         (handle_signal_stop): Update.
1140         (switch_back_to_stepped_thread): Update.
1141         (keep_going_pass_signal): Update.
1142         (print_exited_reason): Update.
1143         (normal_stop): Update.
1144         * inferior.c (inferior_pid_to_str): Change return type.
1145         (print_selected_inferior): Update.
1146         (add_inferior): Update.
1147         (detach_inferior): Update.
1148         * dummy-frame.c (fprint_dummy_frames): Update.
1149         * dcache.c (dcache_info_1): Update.
1150         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1151         (btrace_fetch, btrace_clear): Update.
1152         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1153         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1154         type.
1155         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1156         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1157         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1158         * gdbarch.c, gdbarch.h: Rebuild.
1159         * gdbarch.sh (core_pid_to_str): Change return type.
1160         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1161         return type.
1162         (windows_nat_target::pid_to_str): Change return type.
1163         (windows_delete_thread): Update.
1164         (windows_nat_target::attach): Update.
1165         (windows_nat_target::files_info): Update.
1166         * target-delegates.c: Rebuild.
1167         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1168         return type.
1169         (sol_thread_target::pid_to_str): Change return type.
1170         * remote.c (class remote_target) <pid_to_str>: Change return
1171         type.
1172         (remote_target::pid_to_str): Change return type.
1173         (extended_remote_target::attach, remote_target::remote_stop_ns)
1174         (remote_target::remote_notif_remove_queued_reply)
1175         (remote_target::push_stop_reply, remote_target::disable_btrace):
1176         Update.
1177         (extended_remote_target::attach): Update.
1178         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1179         type.
1180         (gdbsim_target::pid_to_str): Change return type.
1181         * ravenscar-thread.c (struct ravenscar_thread_target)
1182         <pid_to_str>: Change return type.
1183         (ravenscar_thread_target::pid_to_str): Change return type.
1184         * procfs.c (class procfs_target) <pid_to_str>: Change return
1185         type.
1186         (procfs_target::pid_to_str): Change return type.
1187         (procfs_target::attach): Update.
1188         (procfs_target::detach): Update.
1189         (procfs_target::fetch_registers): Update.
1190         (procfs_target::store_registers): Update.
1191         (procfs_target::wait): Update.
1192         (procfs_target::files_info): Update.
1193         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1194         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1195         return type.
1196         (nto_procfs_target::pid_to_str): Change return type.
1197         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1198         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1199         return type.
1200         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1201         (exit_lwp): Update.
1202         (attach_proc_task_lwp_callback, get_detach_signal)
1203         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1204         (linux_nat_target::resume, wait_lwp, stop_callback)
1205         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1206         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1207         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1208         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1209         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1210         type.
1211         (inf_ptrace_target::attach): Update.
1212         (inf_ptrace_target::files_info): Update.
1213         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1214         type.
1215         (go32_nat_target::pid_to_str): Change return type.
1216         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1217         (gnu_nat_target::wait): Update.
1218         (gnu_nat_target::wait): Update.
1219         (gnu_nat_target::resume): Update.
1220         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1221         (fbsd_nat_target::wait): Update.
1222         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1223         type.
1224         (darwin_nat_target::attach): Update.
1225         * corelow.c (class core_target) <pid_to_str>: Change return type.
1226         (core_target::pid_to_str): Change return type.
1227         * target.c (normal_pid_to_str): Change return type.
1228         (default_pid_to_str): Likewise.
1229         (target_pid_to_str): Change return type.
1230         (target_translate_tls_address): Update.
1231         (target_announce_detach): Update.
1232         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1233         return type.
1234         (bsd_uthread_target::pid_to_str): Change return type.
1235         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1236         type.
1237         (bsd_kvm_target::pid_to_str): Change return type.
1238         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1239         return type.
1240         (aix_thread_target::pid_to_str): Change return type.
1241         * target.h (struct target_ops) <pid_to_str>: Change return type.
1242         (target_pid_to_str, normal_pid_to_str): Likewise.
1243         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1244         type.
1245         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1246         type.
1247         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1248         return type.
1249         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1250         type.
1251         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1252         type.
1253         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1254         return type.
1255
1256 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1257
1258         * NEWS: Mention that the new default MI version is 3.  Mention
1259         changes to the output of commands and events that deal with
1260         multi-location breakpoints.
1261         * breakpoint.c: Include "mi/mi-out.h".
1262         (print_one_breakpoint): Change output syntax if using MI version
1263         >= 3.
1264         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1265         New.
1266         (mi_multi_location_breakpoint_output_fixed): New.
1267         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1268         (mi_cmd_fix_multi_location_breakpoint_output): New.
1269         (mi_multi_location_breakpoint_output_fixed): New.
1270         * mi/mi-cmds.c (mi_cmds): Register command
1271         -fix-multi-location-breakpoint-output.
1272         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1273         interpreter "mi".
1274
1275 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1276
1277         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1278         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1279         instantiate mi_ui_out based on interpreter name.
1280         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1281         * mi/mi-main.c (mi_load_progress): Likewise.
1282
1283 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1284
1285         * NEWS: Combine separate "New targets" sections for 8.3.
1286
1287 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1288
1289         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1290         (ppcfbsd_init_abi): Install gdbarch
1291         "fetch_tls_load_module_address" and "get_thread_local_address"
1292         methods.
1293
1294 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1295
1296         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1297         (riscv_fbsd_init_abi): Install gdbarch
1298         "fetch_tls_load_module_address" and "get_thread_local_address"
1299         methods.
1300
1301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1302
1303         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1304         (i386fbsd_init_abi): Install gdbarch
1305         "fetch_tls_load_module_address" and "get_thread_local_address"
1306         methods.
1307
1308 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1309
1310         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1311         (amd64fbsd_init_abi): Install gdbarch
1312         "fetch_tls_load_module_address" and "get_thread_local_address"
1313         methods.
1314
1315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1316
1317         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1318         (struct fbsd_pspace_data): New type.
1319         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1320         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1321         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1322         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1323         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1324
1325 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1326
1327         * gdbtypes.c (lookup_struct_elt): New function.
1328         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1329         * gdbtypes.h (struct struct_elt): New type.
1330         (lookup_struct_elt): New prototype.
1331
1332 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1333
1334         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1335         remove disabled code block.
1336
1337 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1338
1339         * gdbarch.sh (get_thread_local_address): New method.
1340         * gdbarch.h, gdbarch.c: Regenerate.
1341         * target.c (target_translate_tls_address): Use
1342         gdbarch_get_thread_local_address if present instead of
1343         target::get_thread_local_address.
1344
1345 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1346
1347         * target.h (target::get_thread_local_address): Update comment.
1348
1349 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1350
1351         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1352         objfile->separate_debug_objfile_backlink if not NULL.
1353
1354 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1355
1356         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1357         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1358         (amd64bsd_store_inferior_registers): Likewise.
1359         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1360         Enable segment base registers.
1361         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1362         PT_GETFSBASE and PT_GETGSBASE.
1363         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1364         PT_SETGSBASE.
1365         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1366         segment base registers.
1367         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1368
1369 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1370
1371         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1372         Update calls to i386_target_description to add 'segments'
1373         parameter.
1374         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1375         add segment base registers.
1376         * arch/i386.c (i386_create_target_description): Add 'segments'
1377         parameter to enable segment base registers.
1378         * arch/i386.h (i386_create_target_description): Likewise.
1379         * features/i386/32bit-segments.xml: New file.
1380         * features/i386/32bit-segments.c: Generate.
1381         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1382         call to i386_target_description to add 'segments' parameter.
1383         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1384         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1385         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1386         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1387         if feature is present.
1388         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1389         Add 'segments' parameter to call to i386_target_description.
1390         (i386_target_description): Add 'segments' parameter to enable
1391         segment base registers.
1392         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1393         to call to i386_target_description.
1394         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1395         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1396         Define I386_NUM_REGS.
1397         (i386_target_description): Add 'segments' parameter to enable
1398         segment base registers.
1399
1400 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1401
1402         PR/24325
1403         * source-cache.c: #undef open and close, to avoid unresolved
1404         externals during linking.
1405
1406 2019-03-12  Tom Tromey  <tromey@adacore.com>
1407
1408         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1409         const.  Add initializers.
1410         (_initialize_remote): Don't initialize ptid globals.
1411
1412 2019-03-12  Pedro Alves  <palves@redhat.com>
1413
1414         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1415
1416 2019-03-12  Pedro Alves  <palves@redhat.com>
1417
1418         * cp-name-parser.y (main): Remove unused 'len' variable.
1419
1420 2019-03-12  Tom Tromey  <tromey@adacore.com>
1421
1422         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1423         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1424
1425 2019-03-12  Tom Tromey  <tromey@adacore.com>
1426
1427         * linux-nat.c (iterate_over_lwps): Update.
1428         (stop_callback): Remove parameter.
1429         (stop_wait_callback, detach_callback, resume_set_callback)
1430         (select_singlestep_lwp_callback, set_ignore_sigint)
1431         (status_callback, resumed_callback, resume_clear_callback)
1432         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1433         data parameter.
1434         (linux_nat_target::detach, linux_nat_target::resume)
1435         (linux_stop_and_wait_all_lwps, select_event_lwp)
1436         (linux_nat_filter_event, linux_nat_wait_1)
1437         (linux_nat_target::kill, linux_nat_target::stop)
1438         (linux_nat_target::stop): Update.
1439         (linux_nat_resume_callback): Change type.
1440         (resume_stopped_resumed_lwps, count_events_callback)
1441         (select_event_lwp_callback): Likewise.
1442         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1443         * arm-linux-nat.c (struct update_registers_data): Remove.
1444         (update_registers_callback): Change type.
1445         (arm_linux_insert_hw_breakpoint1): Update.
1446         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1447         parameter.
1448         (x86_linux_dr_set_addr): Update.
1449         (x86_linux_dr_set_control): Update.
1450         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1451         (iterate_over_lwps): Use gdb::function_view.
1452         * nat/aarch64-linux-hw-point.c (struct
1453         aarch64_dr_update_callback_param): Remove.
1454         (debug_reg_change_callback): Change type.
1455         (aarch64_notify_debug_reg_change): Update.
1456         * s390-linux-nat.c (s390_refresh_per_info): Update.
1457
1458 2019-03-11  Tom Tromey  <tromey@adacore.com>
1459
1460         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1461         redundant assignment to "this_cu".
1462
1463 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1464
1465         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1466
1467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1468
1469         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1470         from...
1471         (rank_one_type): ... this.
1472
1473 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1474
1475         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1476         from...
1477         (rank_one_type): ... this.
1478
1479 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1480
1481         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1482         from...
1483         (rank_one_type): ... this.
1484
1485 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1486
1487         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1488         from...
1489         (rank_one_type): ... this.
1490
1491 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1492
1493         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1494         from...
1495         (rank_one_type): ... this.
1496
1497 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1498
1499         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1500         from...
1501         (rank_one_type): ... this.
1502
1503 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1504
1505         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1506         from...
1507         (rank_one_type): ... this.
1508
1509 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1510
1511         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1512         from...
1513         (rank_one_type): ... this.
1514
1515 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1516
1517         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1518         from...
1519         (rank_one_type): ... this.
1520
1521 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1522
1523         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1524         from...
1525         (rank_one_type): ... this.
1526
1527 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1528
1529         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1530         from...
1531         (rank_one_type): ... this.
1532
1533 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1534
1535         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1536         from...
1537         (rank_one_type): ... this.
1538
1539 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1540
1541         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1542         inferior-events' shows the example events.
1543
1544 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1545
1546         Support styling on native MS-Windows console
1547
1548         PR/24315
1549         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1550         on MS-Windows if $TERM is not defined.
1551
1552         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1553
1554         * posix-hdep.c (gdb_console_fputs):
1555         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1556         functions.
1557         * ui-file.h (gdb_console_fputs): Add prototype.
1558
1559         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1560         back to fputs only if the former returns zero.
1561
1562 2019-03-07  Tom Tromey  <tom@tromey.com>
1563
1564         * symmisc.c (print_symbol_bcache_statistics): Update.
1565         (print_objfile_statistics): Update.
1566         * symfile.c (allocate_symtab): Update.
1567         * stabsread.c: Don't include bcache.h.
1568         * psymtab.h (struct psymbol_bcache): Don't declare.
1569         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1570         (psymbol_bcache_init, psymbol_bcache_free)
1571         (psymbol_bcache_get_bcache): Don't declare.
1572         * psymtab.c (struct psymbol_bcache): Remove.
1573         (psymtab_storage::psymtab_storage): Update.
1574         (psymtab_storage::~psymtab_storage): Update.
1575         (psymbol_bcache_init, psymbol_bcache_free)
1576         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1577         (add_psymbol_to_bcache): Update.
1578         (allocate_psymtab): Update.
1579         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1580         macro_cache>: No longer pointers.
1581         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1582         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1583         * macrotab.c (macro_bcache): Update.
1584         * macroexp.c: Don't include bcache.h.
1585         * gdbtypes.c (check_types_worklist): Update.
1586         (types_deeply_equal): Remove TRY/CATCH.  Update.
1587         * elfread.c (elf_symtab_read): Update.
1588         * dwarf2read.c: Don't include bcache.h.
1589         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1590         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1591         (print_bcache_statistics, bcache_memory_used): Don't declare.
1592         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1593         methods.  Rename all data members.
1594         * bcache.c (struct bcache): Move to bcache.h.
1595         (bcache::expand_hash_table): Rename from expand_hash_table.
1596         (bcache): Remove.
1597         (bcache::insert): Rename from bcache_full.
1598         (bcache::compare): Rename from bcache_compare.
1599         (bcache_xmalloc): Remove.
1600         (bcache::~bcache): Rename from bcache_xfree.
1601         (bcache::print_statistics): Rename from print_bcache_statistics.
1602         (bcache::memory_used): Rename from bcache_memory_used.
1603
1604 2019-03-07  Pedro Alves  <palves@redhat.com>
1605
1606         * infrun.c (normal_stop): Also check for
1607         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1608
1609 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1610
1611         * f-lang.c (value_from_host_double): Moved to...
1612         * value.c (value_from_host_double): ...here.
1613         * value.h (value_from_host_double): Declare.
1614         * guile/scm-math.c (vlscm_convert_typed_number): Use
1615         value_from_host_double.
1616         (vlscm_convert_number): Likewise.
1617         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1618         * python/py-value.c (convert_value_from_python): Likewise.
1619
1620 2019-03-06  Tom Tromey  <tom@tromey.com>
1621
1622         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1623
1624 2019-03-06  Tom Tromey  <tom@tromey.com>
1625
1626         * utils.h (free_current_contents): Don't declare.
1627         * utils.c (free_current_contents): Remove.
1628
1629 2019-03-06  Tom Tromey  <tom@tromey.com>
1630
1631         * top.c (quit_force): Update.
1632         * main.c (captured_command_loop): Update.
1633         * common/new-op.c (operator new): Update.
1634         * common/common-exceptions.c (struct catcher)
1635         <save_cleanup_chain>: Remove member.
1636         (exceptions_state_mc_init): Update.
1637         (exception_try_scope_entry): Return nullptr.
1638         (exception_try_scope_exit, exception_rethrow)
1639         (throw_exception_sjlj, throw_exception_cxx): Update.
1640         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1641         (all_cleanups, do_cleanups, discard_cleanups)
1642         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1643         (restore_cleanups, restore_final_cleanups): Don't declare.
1644         (do_final_cleanups): Remove parameter.
1645         * common/cleanups.c (cleanup_chain, make_cleanup)
1646         (make_cleanup_dtor, all_cleanups, do_cleanups)
1647         (discard_my_cleanups, discard_cleanups)
1648         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1649         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1650         (null_cleanup): Remove.
1651         (do_final_cleanups): Remove parameter.
1652
1653 2019-03-06  Tom Tromey  <tom@tromey.com>
1654
1655         * remote.c (remote_target::remote_parse_stop_reply): Use
1656         unique_xmalloc_ptr.
1657
1658 2019-03-06  Tom Tromey  <tom@tromey.com>
1659
1660         * stabsread.c (struct stabs_field_info): Rename from field_info.
1661         <list, fnlist>: Add initializers.
1662         <obstack>: New member.
1663         (read_member_functions, read_struct_fields, read_baseclasses):
1664         Allocate on obstack.  Don't use cleanups.
1665         (read_one_struct_field, read_member_functions, read_struct_fields)
1666         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1667         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1668         (read_struct_type): Update.
1669
1670 2019-03-06  Tom Tromey  <tom@tromey.com>
1671
1672         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1673         * common/filestuff.h (make_cleanup_close): Don't declare.
1674         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1675         Remove.
1676
1677 2019-03-06  Tom Tromey  <tom@tromey.com>
1678
1679         * solib-aix.c: Use make_scope_exit.
1680
1681 2019-03-06  Tom Tromey  <tom@tromey.com>
1682
1683         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1684         Use make_scope_exit.
1685
1686 2019-03-06  Tom Tromey  <tom@tromey.com>
1687
1688         * solib-svr4.c (disable_probes_interface): Remove parameter.
1689         (svr4_handle_solib_event): Use make_scope_exit.
1690
1691 2019-03-06  Tom Tromey  <tom@tromey.com>
1692
1693         * remote.c (struct stop_reply_deleter): Remove.
1694         (stop_reply_up): Update.
1695         (struct stop_reply): Derive from notif_event.  Don't typedef.
1696         <regcache>: Now a std::vector.
1697         (stop_reply_xfree): Remove.
1698         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1699         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1700         (remote_target::discard_pending_stop_replies): Use delete.
1701         (remote_target::remote_parse_stop_reply): Update.
1702         (remote_target::process_stop_reply): Update.
1703         * remote-notif.h (struct notif_event): Add virtual destructor.
1704         Remove "dtr" member.
1705         (struct notif_client) <alloc_event>: Return a unique_ptr.
1706         (notif_event_xfree): Don't declare.
1707         (notif_event_up): New typedef.
1708         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1709         (notif_event_xfree, do_notif_event_xfree): Remove.
1710         (remote_notif_state_xfree): Update.
1711
1712 2019-03-06  Tom Tromey  <tom@tromey.com>
1713
1714         * infrun.c (displaced_step_clear_cleanup): Now a
1715         forward_scope_exit type.
1716         (displaced_step_prepare_throw): Update.
1717         (displaced_step_fixup): Update.
1718
1719 2019-03-06  Tom Tromey  <tom@tromey.com>
1720
1721         * inferior.h (class inferior): Update comment.
1722         * gdbthread.h (class thread_info): Update comment.
1723
1724 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1725             Tom Tromey  <tom@tromey.com>
1726
1727         * stabsread.h (struct stab_section_list): Remove.
1728         (coffstab_build_psymtabs): Update.
1729         * dbxread.c (symbuf_sections): Now a std::vector.
1730         (sect_idx): New global.
1731         (fill_symbuf): Update.
1732         (coffstab_build_psymtabs): Change type of stabsects parameter.
1733         Update.
1734         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1735         std::vector.
1736         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1737         (coff_locate_sections): Update.
1738         (coff_symfile_read): Remove cleanups.  Update.
1739         (init_stringtab): Add storage parameter.
1740         (free_stringtab, free_stringtab_cleanup): Remove.
1741         (init_lineno): Add storage parameter.
1742         (free_linetab, free_linetab_cleanup): Remove.
1743
1744 2019-03-06  Pedro Alves  <palves@redhat.com>
1745
1746         * linux-fork.c (fork_info::clobber_regs): Delete.
1747         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1748         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1749         comment.  Adjust.
1750         (scoped_switch_fork_info::scoped_switch_fork_info)
1751         (checkpoint_command, linux_fork_context): Adjust
1752         fork_save_infrun_state calls.
1753
1754 2019-03-06  Pedro Alves  <palves@redhat.com>
1755
1756         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1757         (inf_has_multiple_threads): Return 'bool' and rewrite using
1758         inferior_info::threads().
1759
1760 2019-03-06  Pedro Alves  <palves@redhat.com>
1761
1762         * linux-fork.c: Include <list>.
1763         (fork_list): Now a std::list instance.
1764         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1765         (forks_exist_p, find_last_fork): Adjust.
1766         (new_fork): Delete.
1767         (one_fork_p): New.
1768         (add_fork): Adjust.
1769         (free_fork): Delete, folded into fork_info::~fork_info().
1770         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1771         Adjust.
1772         (init_fork_list): Delete.
1773         (linux_fork_killall, linux_fork_mourn_inferior)
1774         (linux_fork_detach, info_checkpoints_command): Adjust.
1775         (_initialize_linux_fork): No longer call init_fork_list.
1776
1777 2019-03-06  Pedro Alves  <palves@redhat.com>
1778
1779         * linux-fork.c (new_fork): New, split out of ...
1780         (add_fork): ... this.  Return void.  Move "first fork" special
1781         case from here, to ...
1782         (checkpoint_command): ... here.
1783         * linux-linux.h (add_fork): Return void.
1784
1785 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1786
1787         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1788
1789 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1790             Chris January  <chris.january@arm.com>
1791             David Lecomber  <david.lecomber@arm.com>
1792
1793         * f-exp.y: New token, UNOP_INTRINSIC.
1794         (exp): New pattern using UNOP_INTRINSIC token.
1795         (f77_keywords): Add 'abs' keyword.
1796         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1797         (value_from_host_double): New function.
1798         (evaluate_subexp_f): Support UNOP_ABS.
1799
1800 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1801
1802         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1803         types.
1804
1805 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1806
1807         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1808         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1809         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1810
1811 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1812
1813         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1814
1815 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1816             Chris January  <chris.january@arm.com>
1817
1818         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1819         * f-exp.y: Define 'KIND' token.
1820         (exp): New pattern for KIND expressions.
1821         (ptype): Handle types with a kind extension.
1822         (direct_abs_decl): Extend to spot kind extensions.
1823         (f77_keywords): Add 'kind' to the list.
1824         (push_kind_type): New function.
1825         (convert_to_kind_type): New function.
1826         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1827         * parse.c (operator_length_standard): Likewise.
1828         * parser-defs.h (enum type_pieces): Add tp_kind.
1829         * std-operator.def: Add UNOP_KIND.
1830
1831 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1832
1833         * f-exp.y (f_parse): Set yydebug.
1834
1835 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1836
1837         * f-lang.c (evaluate_subexp_f): New function.
1838         (exp_descriptor_f): New global.
1839         (f_language_defn): Use exp_descriptor_f instead of
1840         exp_descriptor_standard.
1841
1842 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1843
1844         * f-exp.y (struct token): Add comments.
1845         (dot_ops): Remove uppercase versions and the end marker.
1846         (f77_keywords): Likewise.
1847         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1848         entries in the dot_ops array are case insensitive, and use
1849         strncasecmp to compare strings.  Also some whitespace cleanup in
1850         this area.  Similar for the f77_keywords array, except entries in
1851         this list might be case sensitive.
1852
1853 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * f-exp.y (struct f77_boolean_val): Add comments.
1856         (boolean_values): Remove uppercase versions, and end marker.
1857         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1858         and use strncasecmp to achieve case insensitivity.  Additionally,
1859         perform whitespace cleanup around this code.
1860
1861 2019-03-06  Tom Tromey  <tromey@adacore.com>
1862
1863         * remote-sim.c (gdbsim_target_open): Use result of
1864         gdb_argv::release.
1865
1866 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1867         Dirk Schubert  <dirk.schubert@arm.com>
1868         Chris January  <chris.january@arm.com>
1869
1870         * eval.c (evaluate_subexp_standard): Call Fortran argument
1871         wrapping logic.
1872         * f-lang.c (struct value): A value which can be passed into a
1873         Fortran function call.
1874         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1875         where appropriate.
1876         (struct type): Value ready for a Fortran function call.
1877         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1878         is needed.
1879         * f-lang.h (fortran_argument_convert): Declaration.
1880         (fortran_preserve_arg_pointer): Declaration.
1881         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1882
1883 2019-03-05  Tom Tromey  <tromey@adacore.com>
1884
1885         * python/py-prettyprint.c (print_string_repr): Remove #if.
1886         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1887
1888 2019-03-05  Tom Tromey  <tromey@adacore.com>
1889
1890         * target.c (the_dummy_target): Move later.  Change type to
1891         "dummy_target".
1892         (initialize_targets): Don't initialize the_dummy_target.
1893
1894 2019-03-05  Tom Tromey  <tromey@adacore.com>
1895
1896         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1897         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1898
1899 2019-03-05  Tom Tromey  <tromey@adacore.com>
1900
1901         * windows-nat.c (windows_nat_target::attach)
1902         (windows_nat_target::detach): Don't call gdb_flush.
1903         * valprint.c (generic_val_print, val_print, val_print_string):
1904         Don't call gdb_flush.
1905         * utils.c (defaulted_query): Don't call gdb_flush.
1906         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1907         * target.c (target_announce_detach): Don't call gdb_flush.
1908         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1909         * remote.c (extended_remote_target::attach): Don't call
1910         gdb_flush.
1911         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1912         * printcmd.c (do_examine): Don't call gdb_flush.
1913         (info_display_command): Don't call gdb_flush.
1914         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1915         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1916         * memattr.c (info_mem_command): Don't call gdb_flush.
1917         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1918         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1919         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1920         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1921         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1922         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1923         (gnu_nat_target::detach): Don't call gdb_flush.
1924         * f-valprint.c (f_val_print): Don't call gdb_flush.
1925         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1926         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1927         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1928         gdb_flush.
1929         * c-valprint.c (c_val_print): Don't call gdb_flush.
1930         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1931
1932 2019-03-05  Tom Tromey  <tromey@adacore.com>
1933
1934         * varobj.c (update_dynamic_varobj_children): Update.
1935         (install_default_visualizer): Use reset, not release.
1936         * value.c (set_internalvar): Update.
1937         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1938         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1939         ATTRIBUTE_UNUSED_RESULT.
1940
1941 2019-03-05  Tom Tromey  <tromey@adacore.com>
1942
1943         * remote.c (class scoped_remote_fd) <release>: Add
1944         ATTRIBUTE_UNUSED_RESULT.
1945
1946 2019-03-05  Tom Tromey  <tromey@adacore.com>
1947
1948         * macroexp.c (struct macro_buffer) <release>: Add
1949         ATTRIBUTE_UNUSED_RESULT.
1950
1951 2019-03-05  Tom Tromey  <tromey@adacore.com>
1952
1953         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1954         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1955         ATTRIBUTE_UNUSED_RESULT.
1956
1957 2019-03-05  Tom Tromey  <tromey@adacore.com>
1958
1959         * common/scoped_fd.h (class scoped_fd) <release>: Add
1960         ATTRIBUTE_UNUSED_RESULT.
1961
1962 2019-03-05  Tom Tromey  <tromey@adacore.com>
1963
1964         * parser-defs.h (struct parser_state) <release>: Add
1965         ATTRIBUTE_UNUSED_RESULT.
1966
1967 2019-03-05  Tom Tromey  <tromey@adacore.com>
1968
1969         * utils.h (class gdb_argv) <release>: Add
1970         ATTRIBUTE_UNUSED_RESULT.
1971         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1972
1973 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1974
1975         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1976         for-loop range, to avoid compiler warnings.
1977
1978         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1979         avoid compiler warnings about unused variables.
1980
1981         * NEWS: Mention end of support for native debugging on MS-Windows
1982         before XP.
1983
1984         PR gdb/24292
1985         * common/netstuff.c:
1986         * gdbserver/gdbreplay.c
1987         * gdbserver/remote-utils.c:
1988         * ser-tcp.c:
1989         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1990         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1991         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1992         'getaddrinfo' and 'freeaddrinfo' were not available before
1993         Windows XP, and mingw.org's MinGW headers by default define
1994         _WIN32_WINNT to 0x500.
1995
1996 2019-03-01  Gary Benson <gbenson@redhat.com>
1997
1998         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1999
2000 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2001             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2002
2003         PR gdb/8527
2004         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2005         set_sigint_trap, clear_sigint_trap.
2006
2007 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2008
2009         * target.c (target_detach): Clear the regcache and the
2010         frame cache.
2011
2012 2019-02-27  Pedro Alves  <palves@redhat.com>
2013
2014         * utils.c (set_screen_size): When we cap the height/width sizes,
2015         tweak the corresponding command variable to show "unlimited":
2016
2017 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2018             Pedro Alves  <palves@redhat.com>
2019
2020         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2021         before calling rl_set_screen_size.
2022
2023 2019-02-27  Tom Tromey  <tromey@adacore.com>
2024
2025         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2026         define.
2027         * python/py-value.c: Remove Python 2.4 workaround.
2028         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2029         workaround.
2030         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2031         Python 2.4 workaround.
2032         * python/python-internal.h: Remove Python 2.4 comment.
2033         (Py_ssize_t): Don't define.
2034         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2035         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2036         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2037         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2038         * python/python.c (do_start_initialization): Remove Python 2.4
2039         workaround.
2040         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2041         (print_children): Remove Python 2.4 workaround.
2042         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2043         workaround.
2044         (CHARBUFFERPROC_NAME): Remove.
2045         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2046         Python 2.4 workaround.
2047
2048 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2049
2050         * NEWS: Note minimum Python version.
2051
2052 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2053
2054         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2055         code from these functions.  Remove corresponding ifdefs.  Use
2056         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2057         Remove gotos and target of gotos.
2058         (infpy_search_memory): Likewise.
2059
2060 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2061
2062         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2063         (hppa_gdbarch_init): Don't register deleted functions with
2064         gdbarch.
2065
2066 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2067
2068         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2069         (h8300_unwind_sp): Delete.
2070         (h8300_dummy_id): Delete.
2071         (h8300_gdbarch_init): Don't register deleted functions with
2072         gdbarch.
2073
2074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2075
2076         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2077         (ft32_unwind_pc): Delete.
2078         (ft32_unwind_sp): Delete.
2079         (ft32_gdbarch_init): Don't register deleted functions with
2080         gdbarch.
2081
2082 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2083
2084         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2085         (frv_unwind_pc): Delete.
2086         (frv_unwind_sp): Delete.
2087         (frv_gdbarch_init): Don't register deleted functions with
2088         gdbarch.
2089
2090 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2091
2092         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2093         (riscv_unwind_pc): Delete.
2094         (riscv_unwind_sp): Delete.
2095         (riscv_gdbarch_init): Don't register deleted functions with
2096         gdbarch.
2097
2098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2099
2100         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2101         (csky_unwind_pc): Delete.
2102         (csky_unwind_sp): Delete.
2103         (csky_gdbarch_init): Don't register deleted functions with
2104         gdbarch.
2105
2106 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2107
2108         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2109         (cris_unwind_pc): Delete.
2110         (cris_unwind_sp): Delete.
2111         (cris_gdbarch_init): Don't register deleted functions with
2112         gdbarch.
2113
2114 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2115
2116         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2117         (bfin_unwind_pc): Delete.
2118         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2119
2120 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2121
2122         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2123         (arm_unwind_pc): Delete.
2124         (arm_unwind_sp): Delete.
2125         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2126
2127 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2128
2129         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2130         (arc_unwind_pc): Delete.
2131         (arc_unwind_sp): Delete.
2132         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2133
2134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2135
2136         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2137         (alpha_unwind_pc): Delete.
2138         (alpha_gdbarch_init): Don't register deleted functions with
2139         gdbarch.
2140
2141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2142
2143         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2144         (aarch64_unwind_pc): Delete.
2145         (aarch64_unwind_sp): Delete.
2146         (aarch64_gdbarch_init): Don't register deleted functions with
2147         gdbarch.
2148
2149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2150
2151         * gdbtypes.c (type_align): Don't consider static members when
2152         computing structure alignment.
2153
2154 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2155
2156         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2157         return 0 for other types.
2158         * arch-utils.c (default_type_align): Always return 0.
2159         * gdbarch.h: Regenerate.
2160         * gdbarch.sh (type_align): Extend comment.
2161         * gdbtypes.c (type_align): Add additional comments, always call
2162         gdbarch_type_align before applying the default rules.
2163         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2164         generic code will then apply a suitable default.
2165         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2166         types, return 0 for other types.
2167
2168 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2169
2170         * NEWS: Create a new section for the next release branch.
2171         Rename the section of the current branch, now that it has
2172         been cut.
2173
2174 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2175
2176         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2177         * version.in: Bump version to 8.3.50.DATE-git.
2178
2179 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2180
2181         * aix-thread.c (ptid_cmp): Remove unused variable.
2182         (get_signaled_thread): Likewise.
2183         (store_regs_user_thread): Likewise.
2184         (store_regs_kernel_thread): Likewise.
2185         (fetch_regs_kernel_thread): Remove shadowed variable.
2186
2187 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2188
2189         * features/riscv/32bit-cpu.xml: Add register numbers.
2190         * features/riscv/32bit-fpu.c: Regenerate.
2191         * features/riscv/32bit-fpu.xml: Add register numbers.
2192         * features/riscv/64bit-cpu.xml: Add register numbers.
2193         * features/riscv/64bit-fpu.c: Regenerate.
2194         * features/riscv/64bit-fpu.xml: Add register numbers.
2195
2196 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2197
2198         * NEWS: Mention two argument form of gdb.Value constructor.
2199         * python/py-value.c (convert_buffer_and_type_to_value): New
2200         function.
2201         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2202         Add support for handling an optional second argument.  Call
2203         convert_buffer_and_type_to_value as appropriate.
2204         * python/python-internal.h (Py_buffer_deleter): New struct.
2205         (Py_buffer_up): New typedef.
2206
2207 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2208
2209         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2210         instead of releasing ownership.
2211
2212 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2213
2214         * dwarf2read.c (open_and_init_dwp_file): Call
2215         elf_numsections instead of bfd_count_sections to initialize
2216         dwp_file->num_sections.
2217
2218 2019-02-25  Tom Tromey  <tromey@adacore.com>
2219
2220         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2221
2222 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2223
2224         * gcore.in: Add '--readnever' option when invoking GDB.
2225
2226 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2227
2228         * MAINTAINERS: Update my email address.
2229
2230 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2231
2232         * build-id.c (build_id_to_debug_bfd_1): New function.
2233         (build_id_to_debug_bfd): Look for separate debug file in
2234         sysroot.
2235
2236 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * gdbarch.sh: Update the copyright year range that is placed into
2239         generated files.
2240
2241 2019-02-22  Keith Seitz  <keiths@redhat.com>
2242
2243         PR symtab/23853
2244         * linespec.c (create_sals_line_offset): Search for the default
2245         symtab's filename instead of its fullname.
2246
2247 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2248
2249         * NEWS: Update style defaults.
2250
2251 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2252
2253         * main.c (captured_main_1): Disable styling in batch mode.
2254
2255 2019-02-20  Tom Tromey  <tom@tromey.com>
2256
2257         * symtab.c (symtab_symbol_info): Fix typos.
2258
2259 2019-02-20  Tom Tromey  <tromey@adacore.com>
2260
2261         * findcmd.c (_initialize_mem_search): Use upper case for
2262         metasyntactic variables.
2263
2264 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2265
2266         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2267         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2268
2269 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2270
2271         * top.h (source_file_name): Change to std::string.
2272         * top.c (source_file_name): Likewise.
2273         (command_line_input): Adjust.
2274         * cli/cli-script.c (script_from_file): Adjust.
2275
2276 2019-02-19  Tom Tromey  <tromey@adacore.com>
2277
2278         * ravenscar-thread.c
2279         (ravenscar_thread_target::update_thread_list): Don't call
2280         ada_build_task_list.
2281         * ada-lang.h (ada_build_task_list): Don't declare.
2282         * ada-tasks.c (struct ada_tasks_inferior_data)
2283         <task_list_valid_p>: Now bool.
2284         (read_known_tasks, ada_task_list_changed)
2285         (ada_tasks_invalidate_inferior_data): Update.
2286         (read_known_tasks_array): Return bool.
2287         (read_known_tasks_list): Likewise.
2288         (read_known_tasks): Return void.
2289         (ada_build_task_list): Now static.
2290
2291 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2292
2293         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2294         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2295
2296 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2297
2298         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2299         variant for ada_tasks_pspace_data_handle and
2300         ada_tasks_inferior_data_handle.
2301         (ada_tasks_pspace_data_cleanup): New function.
2302         (ada_tasks_inferior_data_cleanup): New function.
2303
2304 2019-02-17  Tom Tromey  <tom@tromey.com>
2305
2306         * macrotab.h (macro_source_fullname): Return a std::string.
2307         * macrotab.c (macro_include, check_for_redefinition)
2308         (macro_undef, macro_lookup_definition, foreach_macro)
2309         (foreach_macro_in_scope): Update.
2310         (macro_source_fullname): Return a std::string.
2311         * macrocmd.c (show_pp_source_pos): Update.
2312
2313 2019-02-17  Tom Tromey  <tom@tromey.com>
2314
2315         * macrocmd.c (show_pp_source_pos): Style the file names.
2316
2317 2019-02-17  Tom Tromey  <tom@tromey.com>
2318
2319         PR tui/24197:
2320         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2321
2322 2019-02-17  Tom Tromey  <tom@tromey.com>
2323
2324         * ada-lang.c (user_select_syms): Use filtered printing.
2325         * utils.c (wrap_style): New global.
2326         (desired_style): Remove.
2327         (emit_style_escape): Add stream parameter.
2328         (set_output_style, reset_terminal_style, prompt_for_continue):
2329         Update.
2330         (flush_wrap_buffer): Only flush gdb_stdout.
2331         (wrap_here): Set wrap_style.
2332         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2333         treat escape sequences as a character.  Change when wrap buffer is
2334         flushed.
2335         (fputs_styled): Do not set the output style when the default is
2336         requested.
2337         * ui-style.h (struct ui_file_style) <is_default>: New method.
2338         * source.c (print_source_lines_base): Emit escape sequences in one
2339         piece.
2340
2341 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2342
2343         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2344         integers and enumeration types.
2345
2346 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2347
2348         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2349         instead of lookup_symbol_in_language
2350         (do_exact_match): New function.
2351         (ada_get_symbol_name_matcher): Return do_exact_match when
2352         doing a verbatim match.
2353
2354 2019-02-15  Tom Tromey  <tromey@adacore.com>
2355
2356         * ravenscar-thread.c (ravenscar_thread_target::resume)
2357         (ravenscar_thread_target::wait): Special case wildcard requests.
2358
2359 2019-02-15  Tom Tromey  <tromey@adacore.com>
2360
2361         * ravenscar-thread.c (base_ptid): Remove.
2362         (struct ravenscar_thread_target) <close>: New method.
2363         <m_base_ptid>: New member.
2364         <update_inferior_ptid, active_task, task_is_currently_active,
2365         runtime_initialized>: Declare methods.
2366         <ravenscar_thread_target>: Add constructor.
2367         (ravenscar_thread_target::task_is_currently_active)
2368         (ravenscar_thread_target::update_inferior_ptid)
2369         (ravenscar_runtime_initialized): Rename.  Now methods.
2370         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2371         (ravenscar_thread_target::update_thread_list): Update.
2372         (ravenscar_thread_target::active_task): Now method.
2373         (ravenscar_thread_target::store_registers)
2374         (ravenscar_thread_target::prepare_to_store)
2375         (ravenscar_thread_target::prepare_to_store)
2376         (ravenscar_thread_target::mourn_inferior): Update.
2377         (ravenscar_inferior_created): Use "new" to create target.
2378         (ravenscar_thread_target::get_ada_task_ptid): Update.
2379         (_initialize_ravenscar): Don't initialize base_ptid.
2380         (ravenscar_ops): Remove global.
2381
2382 2019-02-15  Tom Tromey  <tromey@adacore.com>
2383
2384         * target.h (push_target): Declare new overload.
2385         * target.c (push_target): New overload, taking an rvalue reference.
2386         * remote.c (remote_target::open_1): Use push_target overload.
2387         * corelow.c (core_target_open): Use push_target overload.
2388
2389 2019-02-15  Tom Tromey  <tromey@adacore.com>
2390
2391         * ravenscar-thread.c (is_ravenscar_task)
2392         (ravenscar_task_is_currently_active): Return bool.
2393         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2394         (_initialize_ravenscar): Remove "(void)".
2395         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2396         Return bool.
2397
2398 2019-02-15  Tom Tromey  <tromey@adacore.com>
2399
2400         * ravenscar-thread.c (ravenscar_runtime_initializer)
2401         (has_ravenscar_runtime, get_running_thread_id)
2402         (ravenscar_thread_target::resume): Fix indentation.
2403
2404 2019-02-15  Tom Tromey  <tromey@adacore.com>
2405
2406         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2407         from ravenscar_arch_ops.
2408         (sparc_ravenscar_ops::fetch_registers)
2409         (sparc_ravenscar_ops::store_registers): Now methods.
2410         (sparc_ravenscar_prepare_to_store): Remove.
2411         (sparc_ravenscar_ops): Redefine.
2412         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2413         methods and destructor.  Remove members.
2414         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2415         (ravenscar_thread_target::store_registers)
2416         (ravenscar_thread_target::prepare_to_store): Update.
2417         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2418         Remove.
2419         (struct ppc_ravenscar_powerpc_ops): Derive from
2420         ravenscar_arch_ops.
2421         (ppc_ravenscar_powerpc_ops::fetch_registers)
2422         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2423         (ppc_ravenscar_powerpc_ops): Redefine.
2424         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2425         (ppc_ravenscar_e500_ops::fetch_registers)
2426         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2427         (ppc_ravenscar_e500_ops): Redefine.
2428         * aarch64-ravenscar-thread.c
2429         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2430         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2431         (aarch64_ravenscar_fetch_registers)
2432         (aarch64_ravenscar_store_registers): Now methods.
2433         (aarch64_ravenscar_ops): Redefine.
2434
2435 2019-02-15  Tom Tromey  <tromey@adacore.com>
2436
2437         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2438         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2439         (ravenscar_thread_target::stopped_by_watchpoint)
2440         (ravenscar_thread_target::stopped_data_address)
2441         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2442
2443 2019-02-15  Tom Tromey  <tromey@adacore.com>
2444
2445         * ravenscar-thread.c: Fix some typos.
2446
2447 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2448             Tom Tromey  <tromey@adacore.com>
2449
2450         * ada-lang.c (ada_exception_sal): Change addr_string to a
2451         std::string.
2452         (create_ada_exception_catchpoint): Update.
2453
2454 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2455             Tom Tromey  <tromey@adacore.com>
2456
2457         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2458         (bp_location_ops): Remove.
2459         (base_breakpoint_allocate_location): Update.
2460         (free_bp_location): Update.
2461         * ada-lang.c (class ada_catchpoint_location)
2462         <ada_catchpoint_location>: Remove ops parameter.
2463         (ada_catchpoint_location_dtor): Remove.
2464         (ada_catchpoint_location_ops): Remove.
2465         (allocate_location_exception): Update.
2466         * breakpoint.h (struct bp_location_ops): Remove.
2467         (class bp_location) <bp_location>: Remove bp_location_ops
2468         parameter.
2469         <~bp_location>: Add destructor.
2470         <ops>: Remove.
2471
2472 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2473             Pedro Alves  <palves@redhat.com>
2474
2475         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2476         'PATH_MAX'.
2477
2478 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2479             Samuel Thibault  <samuel.thibault@gnu.org>
2480             Thomas Schwinge  <thomas@codesourcery.com>
2481
2482         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2483         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2484
2485 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2486
2487         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2488         (check_empty): Use "const char *".
2489
2490         * gnu-nat.c (gnu_nat_target::detach): Instead of
2491         'detach_inferior (pid)' call
2492         'detach_inferior (find_inferior_pid (pid))'.
2493
2494         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2495         'nat/fork-inferior.o'.
2496         * gnu-nat.c: #include "nat/fork-inferior.h".
2497
2498         * gnu-nat.c (gnu_nat_target::detach): Instead of
2499         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2500         * gnu-nat.h: #include "inf-child.h".
2501         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2502         'i386_gnu_nat_target::fetch_registers'.
2503         (gnu_store_registers): Rename/move to
2504         'i386_gnu_nat_target::store_registers'.
2505
2506         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2507         * gnu-nat.h (mach_thread_info): New function.
2508         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2509
2510         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2511
2512 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2513
2514         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2515
2516 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2517
2518         * windows-nat.c (windows_add_thread): Add new parameter
2519         "main_thread_p" with default value set to false.  Update
2520         function documentation as well as all callers.
2521         (windows_delete_thread): Likewise.
2522         (fake_create_process): Update call to windows_add_thread.
2523         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2524         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2525         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2526         call to windows_delete_thread.
2527
2528 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2529
2530         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2531
2532 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2533
2534         * symfile.c (find_separate_debug_file): Use canonical path of
2535         sysroot with child_path instead of gdb_sysroot if it is valid.
2536
2537 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2538
2539         * symfile.c (find_separate_debug_file): Use child_path to
2540         determine if an object file is under a sysroot.
2541
2542 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2543
2544         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2545         unittests/child-path-selftests.c.
2546         * common/pathstuff.c (child_path): New function.
2547         * common/pathstuff.h (child_path): New prototype.
2548         * unittests/child-path-selftests.c: New file.
2549
2550 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2551
2552         * symfile.c (find_separate_debug_file): Look for separate debug
2553         files in debug directories under the sysroot.
2554
2555 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2556
2557         * symtab.h (struct minimal_symbol data_p): New const method.
2558         (struct minimal_symbol text_p): Likewise.
2559         * symtab.c (output_source_filename): Use file name style
2560         to print file name.
2561         (print_symbol_info): Likewise.
2562         (print_msymbol_info): Use address style to print addresses.
2563         Use function name style to print executable text symbols.
2564         (expand_symtab_containing_pc): Use data_p.
2565         (find_pc_sect_compunit_symtab): Likewise.
2566
2567 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2568
2569         * breakpoint.c (describe_other_breakpoints): Use address style
2570         to print addresses.
2571         (say_where): Likewise.
2572
2573 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2574
2575         * ada-typeprint.c (print_func_type): Print function name
2576         style to print function name.
2577         * c-typeprint.c (c_print_type_1): Likewise.
2578
2579 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2580
2581         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2582         for execve.
2583
2584 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2585
2586         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2587         type_stack.
2588
2589 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2590
2591         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2592         TYPE_CODE_REF types.
2593
2594 2019-02-08  Jim Wilson  <jimw@sifive.com>
2595
2596         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2597         (riscv_linux_fregset): New.
2598         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2599
2600 2019-02-07  Tom Tromey  <tom@tromey.com>
2601
2602         * thread.c (thread_cancel_execution_command): Update.
2603         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2604         methods.
2605         (struct thread_fsm_ops): Remove.
2606         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2607         (thread_fsm_should_stop, thread_fsm_return_value)
2608         (thread_fsm_set_finished, thread_fsm_finished_p)
2609         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2610         Don't declare.
2611         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2612         * infrun.c (clear_proceed_status_thread)
2613         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2614         (print_stop_event): Update.
2615         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2616         Add constructor.
2617         (step_command_fsm_ops): Remove.
2618         (new_step_command_fsm): Remove.
2619         (step_1): Update.
2620         (step_command_fsm::should_stop): Rename from
2621         step_command_fsm_should_stop.
2622         (step_command_fsm::clean_up): Rename from
2623         step_command_fsm_clean_up.
2624         (step_command_fsm::do_async_reply_reason): Rename from
2625         step_command_fsm_async_reply_reason.
2626         (struct until_next_fsm): Inherit from thread_fsm.  Add
2627         constructor.
2628         (until_next_fsm_ops): Remove.
2629         (new_until_next_fsm): Remove.
2630         (until_next_fsm::should_stop): Rename from
2631         until_next_fsm_should_stop.
2632         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2633         (until_next_fsm::do_async_reply_reason): Rename from
2634         until_next_fsm_async_reply_reason.
2635         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2636         constructor.  Change type of breakpoint.
2637         (finish_command_fsm_ops): Remove.
2638         (new_finish_command_fsm): Remove.
2639         (finish_command_fsm::should_stop): Rename from
2640         finish_command_fsm_should_stop.
2641         (finish_command_fsm::clean_up): Rename from
2642         finish_command_fsm_clean_up.
2643         (finish_command_fsm::return_value): Rename from
2644         finish_command_fsm_return_value.
2645         (finish_command_fsm::do_async_reply_reason): Rename from
2646         finish_command_fsm_async_reply_reason.
2647         (finish_command): Update.
2648         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2649         Add constructor.
2650         (call_thread_fsm_ops): Remove.
2651         (call_thread_fsm::call_thread_fsm): Rename from
2652         new_call_thread_fsm.
2653         (call_thread_fsm::should_stop): Rename from
2654         call_thread_fsm_should_stop.
2655         (call_thread_fsm::should_notify_stop): Rename from
2656         call_thread_fsm_should_notify_stop.
2657         (run_inferior_call, call_function_by_hand_dummy): Update.
2658         * cli/cli-interp.c (should_print_stop_to_console): Update.
2659         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2660         Add constructor.  Change type of location_breakpoint,
2661         caller_breakpoint.
2662         (until_break_fsm_ops): Remove.
2663         (new_until_break_fsm): Remove.
2664         (until_break_fsm::should_stop): Rename from
2665         until_break_fsm_should_stop.
2666         (until_break_fsm::clean_up): Rename from
2667         until_break_fsm_clean_up.
2668         (until_break_fsm::do_async_reply_reason): Rename from
2669         until_break_fsm_async_reply_reason.
2670         (until_break_command): Update.
2671         * thread-fsm.c: Remove.
2672         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2673
2674 2019-02-07  Tom Tromey  <tom@tromey.com>
2675
2676         * yy-remap.h: Add include guard.
2677         * xtensa-tdep.h: Add include guard.
2678         * xcoffread.h: Rename include guard.
2679         * varobj-iter.h: Add include guard.
2680         * tui/tui.h: Rename include guard.
2681         * tui/tui-winsource.h: Rename include guard.
2682         * tui/tui-wingeneral.h: Rename include guard.
2683         * tui/tui-windata.h: Rename include guard.
2684         * tui/tui-win.h: Rename include guard.
2685         * tui/tui-stack.h: Rename include guard.
2686         * tui/tui-source.h: Rename include guard.
2687         * tui/tui-regs.h: Rename include guard.
2688         * tui/tui-out.h: Rename include guard.
2689         * tui/tui-layout.h: Rename include guard.
2690         * tui/tui-io.h: Rename include guard.
2691         * tui/tui-hooks.h: Rename include guard.
2692         * tui/tui-file.h: Rename include guard.
2693         * tui/tui-disasm.h: Rename include guard.
2694         * tui/tui-data.h: Rename include guard.
2695         * tui/tui-command.h: Rename include guard.
2696         * tic6x-tdep.h: Add include guard.
2697         * target/waitstatus.h: Rename include guard.
2698         * target/wait.h: Rename include guard.
2699         * target/target.h: Rename include guard.
2700         * target/resume.h: Rename include guard.
2701         * target-float.h: Rename include guard.
2702         * stabsread.h: Add include guard.
2703         * rs6000-tdep.h: Add include guard.
2704         * riscv-fbsd-tdep.h: Add include guard.
2705         * regformats/regdef.h: Rename include guard.
2706         * record.h: Rename include guard.
2707         * python/python.h: Rename include guard.
2708         * python/python-internal.h: Rename include guard.
2709         * python/py-stopevent.h: Rename include guard.
2710         * python/py-ref.h: Rename include guard.
2711         * python/py-record.h: Rename include guard.
2712         * python/py-record-full.h: Rename include guard.
2713         * python/py-record-btrace.h: Rename include guard.
2714         * python/py-instruction.h: Rename include guard.
2715         * python/py-events.h: Rename include guard.
2716         * python/py-event.h: Rename include guard.
2717         * procfs.h: Add include guard.
2718         * proc-utils.h: Add include guard.
2719         * p-lang.h: Add include guard.
2720         * or1k-tdep.h: Rename include guard.
2721         * observable.h: Rename include guard.
2722         * nto-tdep.h: Rename include guard.
2723         * nat/x86-linux.h: Rename include guard.
2724         * nat/x86-linux-dregs.h: Rename include guard.
2725         * nat/x86-gcc-cpuid.h: Add include guard.
2726         * nat/x86-dregs.h: Rename include guard.
2727         * nat/x86-cpuid.h: Rename include guard.
2728         * nat/ppc-linux.h: Rename include guard.
2729         * nat/mips-linux-watch.h: Rename include guard.
2730         * nat/linux-waitpid.h: Rename include guard.
2731         * nat/linux-ptrace.h: Rename include guard.
2732         * nat/linux-procfs.h: Rename include guard.
2733         * nat/linux-osdata.h: Rename include guard.
2734         * nat/linux-nat.h: Rename include guard.
2735         * nat/linux-namespaces.h: Rename include guard.
2736         * nat/linux-btrace.h: Rename include guard.
2737         * nat/glibc_thread_db.h: Rename include guard.
2738         * nat/gdb_thread_db.h: Rename include guard.
2739         * nat/gdb_ptrace.h: Rename include guard.
2740         * nat/fork-inferior.h: Rename include guard.
2741         * nat/amd64-linux-siginfo.h: Rename include guard.
2742         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2743         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2744         * nat/aarch64-linux.h: Rename include guard.
2745         * nat/aarch64-linux-hw-point.h: Rename include guard.
2746         * mn10300-tdep.h: Add include guard.
2747         * mips-linux-tdep.h: Add include guard.
2748         * mi/mi-parse.h: Rename include guard.
2749         * mi/mi-out.h: Rename include guard.
2750         * mi/mi-main.h: Rename include guard.
2751         * mi/mi-interp.h: Rename include guard.
2752         * mi/mi-getopt.h: Rename include guard.
2753         * mi/mi-console.h: Rename include guard.
2754         * mi/mi-common.h: Rename include guard.
2755         * mi/mi-cmds.h: Rename include guard.
2756         * mi/mi-cmd-break.h: Rename include guard.
2757         * m2-lang.h: Add include guard.
2758         * location.h: Rename include guard.
2759         * linux-record.h: Rename include guard.
2760         * linux-nat.h: Add include guard.
2761         * linux-fork.h: Add include guard.
2762         * i386-darwin-tdep.h: Rename include guard.
2763         * hppa-linux-offsets.h: Add include guard.
2764         * guile/guile.h: Rename include guard.
2765         * guile/guile-internal.h: Rename include guard.
2766         * gnu-nat.h: Rename include guard.
2767         * gdb-stabs.h: Rename include guard.
2768         * frv-tdep.h: Add include guard.
2769         * f-lang.h: Add include guard.
2770         * event-loop.h: Add include guard.
2771         * darwin-nat.h: Rename include guard.
2772         * cp-abi.h: Rename include guard.
2773         * config/sparc/nm-sol2.h: Rename include guard.
2774         * config/nm-nto.h: Rename include guard.
2775         * config/nm-linux.h: Add include guard.
2776         * config/i386/nm-i386gnu.h: Rename include guard.
2777         * config/djgpp/nl_types.h: Rename include guard.
2778         * config/djgpp/langinfo.h: Rename include guard.
2779         * compile/gcc-cp-plugin.h: Add include guard.
2780         * compile/gcc-c-plugin.h: Add include guard.
2781         * compile/compile.h: Rename include guard.
2782         * compile/compile-object-run.h: Rename include guard.
2783         * compile/compile-object-load.h: Rename include guard.
2784         * compile/compile-internal.h: Rename include guard.
2785         * compile/compile-cplus.h: Rename include guard.
2786         * compile/compile-c.h: Rename include guard.
2787         * common/xml-utils.h: Rename include guard.
2788         * common/x86-xstate.h: Rename include guard.
2789         * common/version.h: Rename include guard.
2790         * common/vec.h: Rename include guard.
2791         * common/tdesc.h: Rename include guard.
2792         * common/selftest.h: Rename include guard.
2793         * common/scoped_restore.h: Rename include guard.
2794         * common/scoped_mmap.h: Rename include guard.
2795         * common/scoped_fd.h: Rename include guard.
2796         * common/safe-iterator.h: Rename include guard.
2797         * common/run-time-clock.h: Rename include guard.
2798         * common/refcounted-object.h: Rename include guard.
2799         * common/queue.h: Rename include guard.
2800         * common/ptid.h: Rename include guard.
2801         * common/print-utils.h: Rename include guard.
2802         * common/preprocessor.h: Rename include guard.
2803         * common/pathstuff.h: Rename include guard.
2804         * common/observable.h: Rename include guard.
2805         * common/netstuff.h: Rename include guard.
2806         * common/job-control.h: Rename include guard.
2807         * common/host-defs.h: Rename include guard.
2808         * common/gdb_wait.h: Rename include guard.
2809         * common/gdb_vecs.h: Rename include guard.
2810         * common/gdb_unlinker.h: Rename include guard.
2811         * common/gdb_unique_ptr.h: Rename include guard.
2812         * common/gdb_tilde_expand.h: Rename include guard.
2813         * common/gdb_sys_time.h: Rename include guard.
2814         * common/gdb_string_view.h: Rename include guard.
2815         * common/gdb_splay_tree.h: Rename include guard.
2816         * common/gdb_setjmp.h: Rename include guard.
2817         * common/gdb_ref_ptr.h: Rename include guard.
2818         * common/gdb_optional.h: Rename include guard.
2819         * common/gdb_locale.h: Rename include guard.
2820         * common/gdb_assert.h: Rename include guard.
2821         * common/filtered-iterator.h: Rename include guard.
2822         * common/filestuff.h: Rename include guard.
2823         * common/fileio.h: Rename include guard.
2824         * common/environ.h: Rename include guard.
2825         * common/common-utils.h: Rename include guard.
2826         * common/common-types.h: Rename include guard.
2827         * common/common-regcache.h: Rename include guard.
2828         * common/common-inferior.h: Rename include guard.
2829         * common/common-gdbthread.h: Rename include guard.
2830         * common/common-exceptions.h: Rename include guard.
2831         * common/common-defs.h: Rename include guard.
2832         * common/common-debug.h: Rename include guard.
2833         * common/cleanups.h: Rename include guard.
2834         * common/buffer.h: Rename include guard.
2835         * common/btrace-common.h: Rename include guard.
2836         * common/break-common.h: Rename include guard.
2837         * cli/cli-utils.h: Rename include guard.
2838         * cli/cli-style.h: Rename include guard.
2839         * cli/cli-setshow.h: Rename include guard.
2840         * cli/cli-script.h: Rename include guard.
2841         * cli/cli-interp.h: Rename include guard.
2842         * cli/cli-decode.h: Rename include guard.
2843         * cli/cli-cmds.h: Rename include guard.
2844         * charset-list.h: Add include guard.
2845         * buildsym-legacy.h: Rename include guard.
2846         * bfin-tdep.h: Add include guard.
2847         * ax.h: Rename include guard.
2848         * arm-linux-tdep.h: Add include guard.
2849         * arm-fbsd-tdep.h: Add include guard.
2850         * arch/xtensa.h: Rename include guard.
2851         * arch/tic6x.h: Add include guard.
2852         * arch/i386.h: Add include guard.
2853         * arch/arm.h: Rename include guard.
2854         * arch/arm-linux.h: Rename include guard.
2855         * arch/arm-get-next-pcs.h: Rename include guard.
2856         * arch/amd64.h: Add include guard.
2857         * arch/aarch64-insn.h: Rename include guard.
2858         * arch-utils.h: Rename include guard.
2859         * annotate.h: Add include guard.
2860         * amd64-darwin-tdep.h: Rename include guard.
2861         * aarch64-linux-tdep.h: Add include guard.
2862         * aarch64-fbsd-tdep.h: Add include guard.
2863         * aarch32-linux-nat.h: Add include guard.
2864
2865 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2866
2867         * macrotab.c (macro_define_internal): New function that
2868         factorizes macro_define_object_internal and macro_define_function
2869         code.
2870         (macro_define_object_internal): Use macro_define_internal.
2871         (macro_define_function): Likewise.
2872
2873 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2874
2875         * macrocmd.c (extract_identifier): Return
2876         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2877         callers.
2878
2879 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2880
2881         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2882
2883 2019-02-05  Tom Tromey  <tom@tromey.com>
2884
2885         * target.c (target_stack::unpush): Move assertion earlier.
2886
2887 2019-01-30  Tom Tromey  <tom@tromey.com>
2888
2889         PR python/23615:
2890         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2891         (gdbpy_parse_and_eval): Likewise.
2892         * python/python-internal.h (gdbpy_allow_threads): New class.
2893
2894 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2895
2896         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2897         (aarch64_fbsd_fpregmap): Move earlier.
2898         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2899         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2900         instead of individual calls to trad_frame_set_reg_addr.
2901         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2902         earlier.
2903         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2904         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2905         instead of individual calls to trad_frame_set_reg_addr.
2906
2907 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2908
2909         * CONTRIBUTE: Replace contribution list with wiki link.
2910
2911 2019-01-25  Tom Tromey  <tom@tromey.com>
2912
2913         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2914
2915 2019-01-25  Tom Tromey  <tom@tromey.com>
2916
2917         * xtensa-linux-nat.c: Fix common/ includes.
2918         * xml-support.h: Fix common/ includes.
2919         * xml-support.c: Fix common/ includes.
2920         * x86-linux-nat.c: Fix common/ includes.
2921         * windows-nat.c: Fix common/ includes.
2922         * varobj.h: Fix common/ includes.
2923         * varobj.c: Fix common/ includes.
2924         * value.c: Fix common/ includes.
2925         * valops.c: Fix common/ includes.
2926         * utils.c: Fix common/ includes.
2927         * unittests/xml-utils-selftests.c: Fix common/ includes.
2928         * unittests/utils-selftests.c: Fix common/ includes.
2929         * unittests/unpack-selftests.c: Fix common/ includes.
2930         * unittests/tracepoint-selftests.c: Fix common/ includes.
2931         * unittests/style-selftests.c: Fix common/ includes.
2932         * unittests/string_view-selftests.c: Fix common/ includes.
2933         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2934         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2935         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2936         * unittests/rsp-low-selftests.c: Fix common/ includes.
2937         * unittests/parse-connection-spec-selftests.c: Fix common/
2938         includes.
2939         * unittests/optional-selftests.c: Fix common/ includes.
2940         * unittests/offset-type-selftests.c: Fix common/ includes.
2941         * unittests/observable-selftests.c: Fix common/ includes.
2942         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2943         * unittests/memrange-selftests.c: Fix common/ includes.
2944         * unittests/memory-map-selftests.c: Fix common/ includes.
2945         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2946         * unittests/function-view-selftests.c: Fix common/ includes.
2947         * unittests/environ-selftests.c: Fix common/ includes.
2948         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2949         * unittests/common-utils-selftests.c: Fix common/ includes.
2950         * unittests/cli-utils-selftests.c: Fix common/ includes.
2951         * unittests/array-view-selftests.c: Fix common/ includes.
2952         * ui-file.c: Fix common/ includes.
2953         * tui/tui-io.c: Fix common/ includes.
2954         * tracepoint.h: Fix common/ includes.
2955         * tracepoint.c: Fix common/ includes.
2956         * tracefile-tfile.c: Fix common/ includes.
2957         * top.h: Fix common/ includes.
2958         * top.c: Fix common/ includes.
2959         * thread.c: Fix common/ includes.
2960         * target/waitstatus.h: Fix common/ includes.
2961         * target/waitstatus.c: Fix common/ includes.
2962         * target.h: Fix common/ includes.
2963         * target.c: Fix common/ includes.
2964         * target-memory.c: Fix common/ includes.
2965         * target-descriptions.c: Fix common/ includes.
2966         * symtab.h: Fix common/ includes.
2967         * symfile.c: Fix common/ includes.
2968         * stap-probe.c: Fix common/ includes.
2969         * spu-linux-nat.c: Fix common/ includes.
2970         * sparc-nat.c: Fix common/ includes.
2971         * source.c: Fix common/ includes.
2972         * solib.c: Fix common/ includes.
2973         * solib-target.c: Fix common/ includes.
2974         * ser-unix.c: Fix common/ includes.
2975         * ser-tcp.c: Fix common/ includes.
2976         * ser-pipe.c: Fix common/ includes.
2977         * ser-base.c: Fix common/ includes.
2978         * selftest-arch.c: Fix common/ includes.
2979         * s12z-tdep.c: Fix common/ includes.
2980         * rust-exp.y: Fix common/ includes.
2981         * rs6000-aix-tdep.c: Fix common/ includes.
2982         * riscv-tdep.c: Fix common/ includes.
2983         * remote.c: Fix common/ includes.
2984         * remote-notif.h: Fix common/ includes.
2985         * remote-fileio.h: Fix common/ includes.
2986         * remote-fileio.c: Fix common/ includes.
2987         * regcache.h: Fix common/ includes.
2988         * regcache.c: Fix common/ includes.
2989         * record-btrace.c: Fix common/ includes.
2990         * python/python.c: Fix common/ includes.
2991         * python/py-type.c: Fix common/ includes.
2992         * python/py-inferior.c: Fix common/ includes.
2993         * progspace.h: Fix common/ includes.
2994         * producer.c: Fix common/ includes.
2995         * procfs.c: Fix common/ includes.
2996         * proc-api.c: Fix common/ includes.
2997         * printcmd.c: Fix common/ includes.
2998         * ppc-linux-nat.c: Fix common/ includes.
2999         * parser-defs.h: Fix common/ includes.
3000         * osdata.c: Fix common/ includes.
3001         * obsd-nat.c: Fix common/ includes.
3002         * nat/x86-linux.c: Fix common/ includes.
3003         * nat/x86-linux-dregs.c: Fix common/ includes.
3004         * nat/x86-dregs.h: Fix common/ includes.
3005         * nat/x86-dregs.c: Fix common/ includes.
3006         * nat/ppc-linux.c: Fix common/ includes.
3007         * nat/mips-linux-watch.h: Fix common/ includes.
3008         * nat/mips-linux-watch.c: Fix common/ includes.
3009         * nat/linux-waitpid.c: Fix common/ includes.
3010         * nat/linux-ptrace.h: Fix common/ includes.
3011         * nat/linux-ptrace.c: Fix common/ includes.
3012         * nat/linux-procfs.c: Fix common/ includes.
3013         * nat/linux-personality.c: Fix common/ includes.
3014         * nat/linux-osdata.c: Fix common/ includes.
3015         * nat/linux-namespaces.c: Fix common/ includes.
3016         * nat/linux-btrace.h: Fix common/ includes.
3017         * nat/linux-btrace.c: Fix common/ includes.
3018         * nat/fork-inferior.c: Fix common/ includes.
3019         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3020         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3021         * nat/aarch64-linux.c: Fix common/ includes.
3022         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3023         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3024         * namespace.h: Fix common/ includes.
3025         * mips-linux-tdep.c: Fix common/ includes.
3026         * minsyms.c: Fix common/ includes.
3027         * mi/mi-parse.h: Fix common/ includes.
3028         * mi/mi-main.c: Fix common/ includes.
3029         * mi/mi-cmd-env.c: Fix common/ includes.
3030         * memrange.h: Fix common/ includes.
3031         * memattr.c: Fix common/ includes.
3032         * maint.h: Fix common/ includes.
3033         * maint.c: Fix common/ includes.
3034         * main.c: Fix common/ includes.
3035         * machoread.c: Fix common/ includes.
3036         * location.c: Fix common/ includes.
3037         * linux-thread-db.c: Fix common/ includes.
3038         * linux-nat.c: Fix common/ includes.
3039         * linux-fork.c: Fix common/ includes.
3040         * inline-frame.c: Fix common/ includes.
3041         * infrun.c: Fix common/ includes.
3042         * inflow.c: Fix common/ includes.
3043         * inferior.h: Fix common/ includes.
3044         * inferior.c: Fix common/ includes.
3045         * infcmd.c: Fix common/ includes.
3046         * inf-ptrace.c: Fix common/ includes.
3047         * inf-child.c: Fix common/ includes.
3048         * ia64-linux-nat.c: Fix common/ includes.
3049         * i387-tdep.c: Fix common/ includes.
3050         * i386-tdep.c: Fix common/ includes.
3051         * i386-linux-tdep.c: Fix common/ includes.
3052         * i386-linux-nat.c: Fix common/ includes.
3053         * i386-go32-tdep.c: Fix common/ includes.
3054         * i386-fbsd-tdep.c: Fix common/ includes.
3055         * i386-fbsd-nat.c: Fix common/ includes.
3056         * guile/scm-type.c: Fix common/ includes.
3057         * guile/guile.c: Fix common/ includes.
3058         * go32-nat.c: Fix common/ includes.
3059         * gnu-nat.c: Fix common/ includes.
3060         * gdbthread.h: Fix common/ includes.
3061         * gdbarch-selftests.c: Fix common/ includes.
3062         * gdb_usleep.c: Fix common/ includes.
3063         * gdb_select.h: Fix common/ includes.
3064         * gdb_bfd.c: Fix common/ includes.
3065         * gcore.c: Fix common/ includes.
3066         * fork-child.c: Fix common/ includes.
3067         * findvar.c: Fix common/ includes.
3068         * fbsd-nat.c: Fix common/ includes.
3069         * event-top.c: Fix common/ includes.
3070         * event-loop.c: Fix common/ includes.
3071         * dwarf2read.c: Fix common/ includes.
3072         * dwarf2loc.c: Fix common/ includes.
3073         * dwarf2-frame.c: Fix common/ includes.
3074         * dwarf-index-cache.c: Fix common/ includes.
3075         * dtrace-probe.c: Fix common/ includes.
3076         * disasm-selftests.c: Fix common/ includes.
3077         * defs.h: Fix common/ includes.
3078         * csky-tdep.c: Fix common/ includes.
3079         * cp-valprint.c: Fix common/ includes.
3080         * cp-support.h: Fix common/ includes.
3081         * cp-support.c: Fix common/ includes.
3082         * corelow.c: Fix common/ includes.
3083         * completer.h: Fix common/ includes.
3084         * completer.c: Fix common/ includes.
3085         * compile/compile.c: Fix common/ includes.
3086         * compile/compile-loc2c.c: Fix common/ includes.
3087         * compile/compile-cplus-types.c: Fix common/ includes.
3088         * compile/compile-cplus-symbols.c: Fix common/ includes.
3089         * command.h: Fix common/ includes.
3090         * cli/cli-dump.c: Fix common/ includes.
3091         * cli/cli-cmds.c: Fix common/ includes.
3092         * charset.c: Fix common/ includes.
3093         * build-id.c: Fix common/ includes.
3094         * btrace.h: Fix common/ includes.
3095         * btrace.c: Fix common/ includes.
3096         * breakpoint.h: Fix common/ includes.
3097         * breakpoint.c: Fix common/ includes.
3098         * ax.h: 
3099         (enum agent_op): Fix common/ includes.
3100         * ax-general.c (struct aop_map): Fix common/ includes.
3101         * ax-gdb.c: Fix common/ includes.
3102         * auxv.c: Fix common/ includes.
3103         * auto-load.c: Fix common/ includes.
3104         * arm-tdep.c: Fix common/ includes.
3105         * arch/riscv.c: Fix common/ includes.
3106         * arch/ppc-linux-common.c: Fix common/ includes.
3107         * arch/i386.c: Fix common/ includes.
3108         * arch/arm.c: Fix common/ includes.
3109         * arch/arm-linux.c: Fix common/ includes.
3110         * arch/arm-get-next-pcs.c: Fix common/ includes.
3111         * arch/amd64.c: Fix common/ includes.
3112         * arch/aarch64.c: Fix common/ includes.
3113         * arch/aarch64-insn.c: Fix common/ includes.
3114         * arch-utils.c: Fix common/ includes.
3115         * amd64-windows-tdep.c: Fix common/ includes.
3116         * amd64-tdep.c: Fix common/ includes.
3117         * amd64-sol2-tdep.c: Fix common/ includes.
3118         * amd64-obsd-tdep.c: Fix common/ includes.
3119         * amd64-nbsd-tdep.c: Fix common/ includes.
3120         * amd64-linux-tdep.c: Fix common/ includes.
3121         * amd64-linux-nat.c: Fix common/ includes.
3122         * amd64-fbsd-tdep.c: Fix common/ includes.
3123         * amd64-fbsd-nat.c: Fix common/ includes.
3124         * amd64-dicos-tdep.c: Fix common/ includes.
3125         * amd64-darwin-tdep.c: Fix common/ includes.
3126         * agent.c: Fix common/ includes.
3127         * ada-lang.h: Fix common/ includes.
3128         * ada-lang.c: Fix common/ includes.
3129         * aarch64-tdep.c: Fix common/ includes.
3130
3131 2019-01-25  Tom Tromey  <tom@tromey.com>
3132
3133         * common/create-version.sh: Use common/version.h.
3134
3135 2019-01-24  Pedro Alves  <palves@redhat.com>
3136
3137         * infrun.c (signal_stop, signal_print, signal_program)
3138         (signal_catch, signal_pass): Now arrays instead of pointers.
3139         (update_signals_program_target, do_target_resume)
3140         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3141         * linux-nat.c (linux_nat_target::pass_signals)
3142         (linux_nat_target::create_inferior, linux_nat_target::attach):
3143         Adjust.
3144         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3145         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3146         * procfs.c (procfs_target::pass_signals): Adjust.
3147         * record-full.c (record_full_target::resume): Adjust.
3148         * remote.c (remote_target::pass_signals)
3149         (remote_target::program_signals): Adjust.
3150         * target-debug.h (target_debug_print_signals): Now takes a
3151         gdb::array_view as parameter.  Adjust.
3152         * target.h (target_ops) <pass_signals, program_signals>: Replace
3153         pointer and length parameters with gdb::array_view.
3154         (target_pass_signals, target_program_signals): Likewise.
3155         * target-delegates.c: Regenerate.
3156
3157 2019-01-24  Pedro Alves  <palves@redhat.com>
3158
3159         * common/forward-scope-exit.h
3160         (forward_scope_exit::forward_scope_exit): Pass arguments to
3161         m_bind_function directly, instead of creating a std::bind and
3162         copying that.
3163
3164 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3165
3166         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3167         for static members.
3168         (pass_in_v_vfp_candidate): Likewise.
3169
3170 2019-01-23  Tom Tromey  <tom@tromey.com>
3171             Pedro Alves  <palves@redhat.com>
3172
3173         * regcache.c (class regcache_invalidator): Remove.
3174         (regcache::raw_write): Use make_scope_exit.
3175
3176 2019-01-23  Tom Tromey  <tom@tromey.com>
3177
3178         * ui-out.h (class ui_out_emit_type): Update comment.
3179
3180 2019-01-23  Tom Tromey  <tom@tromey.com>
3181
3182         * infrun.c (fetch_inferior_event): Update comment.
3183
3184 2019-01-23  Tom Tromey  <tom@tromey.com>
3185             Pedro Alves  <palves@redhat.com>
3186
3187         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3188         parameter.
3189         (fetch_inferior_event): Use SCOPE_EXIT.
3190
3191
3192 2019-01-23  Tom Tromey  <tom@tromey.com>
3193             Pedro Alves  <palves@redhat.com>
3194
3195         * infrun.c (disable_thread_events): Delete.
3196         (stop_all_threads): Use SCOPE_EXIT.
3197
3198 2019-01-23  Tom Tromey  <tom@tromey.com>
3199             Pedro Alves  <palves@redhat.com>
3200
3201         * symfile.c: Include forward-scope-exit.h.
3202         (clear_symtab_users_cleanup): Replace forward declaration with
3203         a FORWARD_SCOPE_EXIT.
3204         (syms_from_objfile_1): Use the forward_scope_exit and
3205         gdb::optional instead of cleanup_function.
3206         (reread_symbols): Use the forward_scope_exit instead of
3207         cleanup_function.
3208         (clear_symtab_users_cleanup): Remove function.
3209
3210 2019-01-23  Tom Tromey  <tom@tromey.com>
3211             Pedro Alves  <palves@redhat.com>
3212
3213         * linux-nat.c: Include scope-exit.h.
3214         (cleanup_target_stop): Remove.
3215         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3216         SCOPE_EXIT.
3217
3218 2019-01-23  Tom Tromey  <tom@tromey.com>
3219             Pedro Alves  <palves@redhat.com>
3220
3221         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3222         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3223
3224 2019-01-23  Tom Tromey  <tom@tromey.com>
3225             Andrew Burgess  <andrew.burgess@embecosm.com>
3226             Pedro Alves  <palves@redhat.com>
3227
3228         * infrun.c (fetch_inferior_event): Use scope_exit.
3229         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3230         * top.c (execute_command): Use scope_exit.
3231         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3232         * utils.c (do_bpstat_clear_actions_cleanup)
3233         (make_bpstat_clear_actions_cleanup): Remove.
3234
3235 2019-01-23  Tom Tromey  <tom@tromey.com>
3236             Pedro Alves  <palves@redhat.com>
3237
3238         * infrun.c: Include "common/scope-exit.h"
3239         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3240         (wait_for_inferior): Use SCOPE_EXIT.
3241         (fetch_inferior_event): Use scope_exit.
3242
3243 2019-01-23  Tom Tromey  <tom@tromey.com>
3244             Pedro Alves  <palves@redhat.com>
3245
3246         * breakpoint.c (create_breakpoint): Remove cleanup.
3247
3248 2019-01-23  Tom Tromey  <tom@tromey.com>
3249             Andrew Burgess  <andrew.burgess@embecosm.com>
3250             Pedro Alves  <palves@redhat.com>
3251
3252 2019-01-23  Pedro Alves  <palves@redhat.com>
3253
3254         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3255
3256 2019-01-23  Pedro Alves  <palves@redhat.com>
3257             Andrew Burgess  <andrew.burgess@embecosm.com>
3258
3259         * gdbthread.h: Include "common/forward-scope-exit.h".
3260         (scoped_finish_thread_state): Redefine custom class in terms of
3261         forward_scope_exit.
3262
3263 2019-01-23  Pedro Alves  <palves@redhat.com>
3264             Andrew Burgess  <andrew.burgess@embecosm.com>
3265
3266         * common/forward-scope-exit.h: New file.
3267
3268 2019-01-23  Pedro Alves  <palves@redhat.com>
3269             Andrew Burgess  <andrew.burgess@embecosm.com>
3270             Tom Tromey  <tom@tromey.com>
3271
3272         * common/scope-exit.h: New file.
3273
3274 2019-01-23  Pedro Alves  <palves@redhat.com>
3275
3276         * common/preprocessor.h (ESC): Rename to ...
3277         (ESC_PARENS): ... this.
3278         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3279         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3280
3281 2019-01-23  Tom Tromey  <tom@tromey.com>
3282
3283         * language.h (class scoped_switch_to_sym_language_if_auto):
3284         Initialize m_lang in both cases.
3285
3286 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3287
3288         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3289         with XCNEW.
3290
3291 2019-01-22  Tom Tromey  <tom@tromey.com>
3292
3293         * corelow.c: Do not include sys/file.h.
3294
3295 2019-01-22  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-wingeneral.h: Include gdb_curses.h.
3298
3299 2019-01-22  Tom Tromey  <tom@tromey.com>
3300
3301         * source-cache.h (class source_cache) <get_source_lines,
3302         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3303
3304 2019-01-22  Tom Tromey  <tom@tromey.com>
3305
3306         * remote-fileio.h (struct remote_target): Declare.
3307
3308 2019-01-22  Tom Tromey  <tom@tromey.com>
3309
3310         * python/py-arch.c: Do not include py-ref.h.
3311         * python/py-bpevent.c: Do not include py-ref.h.
3312         * python/py-cmd.c: Do not include py-ref.h.
3313         * python/py-continueevent.c: Do not include py-ref.h.
3314         * python/py-event.h: Do not include py-ref.h.
3315         * python/py-evtregistry.c: Do not include py-ref.h.
3316         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3317         * python/py-frame.c: Do not include py-ref.h.
3318         * python/py-framefilter.c: Do not include py-ref.h.
3319         * python/py-function.c: Do not include py-ref.h.
3320         * python/py-infevents.c: Do not include py-ref.h.
3321         * python/py-linetable.c: Do not include py-ref.h.
3322         * python/py-objfile.c: Do not include py-ref.h.
3323         * python/py-param.c: Do not include py-ref.h.
3324         * python/py-prettyprint.c: Do not include py-ref.h.
3325         * python/py-progspace.c: Do not include py-ref.h.
3326         * python/py-symbol.c: Do not include py-ref.h.
3327         * python/py-symtab.c: Do not include py-ref.h.
3328         * python/py-type.c: Do not include py-ref.h.
3329         * python/py-unwind.c: Do not include py-ref.h.
3330         * python/py-utils.c: Do not include py-ref.h.
3331         * python/py-value.c: Do not include py-ref.h.
3332         * python/py-varobj.c: Do not include py-ref.h.
3333         * python/py-xmethods.c: Do not include py-ref.h.
3334         * python/python.c: Do not include py-ref.h.
3335         * varobj.c: Do not include py-ref.h.
3336
3337 2019-01-22  Tom Tromey  <tom@tromey.com>
3338
3339         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3340         keyword for bcache.
3341
3342 2019-01-22  Tom Tromey  <tom@tromey.com>
3343
3344         * compile/compile-cplus-types.c: Remove a comment by #include.
3345
3346 2019-01-22  Tom Tromey  <tom@tromey.com>
3347
3348         * compile/gcc-c-plugin.h: Include compile-internal.h.
3349
3350 2019-01-22  Tom Tromey  <tom@tromey.com>
3351
3352         * stabsread.c (EXTERN): Do not define.
3353         (symnum, next_symbol_text_func, processing_gcc_compilation)
3354         (within_function, global_sym_chain, global_stabs)
3355         (previous_stab_code, this_object_header_files)
3356         (n_this_object_header_files)
3357         (n_allocated_this_object_header_files): Define.
3358         * stabsread.h (EXTERN): Never define.  Use "extern".
3359
3360 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3361
3362         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3363         history_value.
3364
3365 2019-01-21  Tom Tromey  <tom@tromey.com>
3366
3367         * ui-out.c: Fix includes.
3368         * tui/tui-source.c: Fix includes.
3369         * target.c: Fix includes.
3370         * remote.c: Fix includes.
3371         * regcache.c: Fix includes.
3372         * python/py-block.c: Fix includes.
3373         * printcmd.c: Fix includes.
3374         * or1k-tdep.c: Fix includes.
3375         * mi/mi-main.c: Fix includes.
3376         * m32r-tdep.c: Fix includes.
3377         * csky-tdep.c: Fix includes.
3378         * compile/compile-cplus-types.c: Fix includes.
3379         * cli/cli-interp.c: Fix includes.
3380
3381 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3382
3383         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3384         for padding.
3385
3386 2019-01-16  Tom Tromey  <tom@tromey.com>
3387
3388         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3389         earlier.
3390         (struct objfile) <msymbols_range>: Move from top level.
3391         <msymbols>: New method.
3392         (class objfile_msymbols): Remove.
3393         * symtab.c (default_collect_symbol_completion_matches_break_on):
3394         Update.
3395         * symmisc.c (dump_msymbols): Update.
3396         * stabsread.c (scan_file_globals): Update.
3397         * objc-lang.c (info_selectors_command, info_classes_command)
3398         (find_methods): Update.
3399         * minsyms.c (find_solib_trampoline_target): Update.
3400         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3401         * coffread.c (coff_symfile_read): Update.
3402         * ada-lang.c (ada_lookup_simple_minsym)
3403         (ada_collect_symbol_completion_matches): Update.
3404
3405 2019-01-16  Tom Tromey  <tom@tromey.com>
3406
3407         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3408         type.  Remove no-argument constructor.
3409         <iterator::operator++>: Simplify.
3410         <begin>: Update.
3411         <end>: Use minimal_symbol_count.
3412
3413 2019-01-16  Tom Tromey  <tom@tromey.com>
3414
3415         * objfiles.h (struct objfile) <psymtabs>: New method.
3416         (class objfile_psymtabs): Remove.
3417         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3418         typedef.
3419         <range>: New method.
3420         (require_partial_symbols): Change return type.
3421         * psymtab.c (require_partial_symbols)
3422         (psym_expand_symtabs_matching): Update.
3423         * mdebugread.c (parse_partial_symbols): Update.
3424         * dbxread.c (dbx_end_psymtab): Update.
3425
3426 2019-01-15  Tom Tromey  <tom@tromey.com>
3427
3428         * symtab.c (lookup_objfile_from_block)
3429         (lookup_symbol_in_objfile_symtabs)
3430         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3431         (find_line_symtab, info_sources_command)
3432         (default_collect_symbol_completion_matches_break_on)
3433         (make_source_files_completion_list): Update.
3434         * symmisc.c (print_objfile_statistics, dump_objfile)
3435         (maintenance_print_symbols, maintenance_info_symtabs)
3436         (maintenance_check_symtabs, maintenance_info_line_tables):
3437         Update.
3438         * source.c (select_source_symtab)
3439         (forget_cached_source_info_for_objfile): Update.
3440         * objfiles.h (class objfile_compunits): Remove.
3441         (struct objfile) <compunits_range>: New typedef.
3442         (compunits): New method.
3443         * objfiles.c (objfile_relocate1): Update.
3444         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3445         * maint.c (count_symtabs_and_blocks): Update.
3446         * linespec.c (iterate_over_all_matching_symtabs): Update.
3447         * cp-support.c (add_symbol_overload_list_qualified): Update.
3448         * coffread.c (coff_symtab_read): Update.
3449         * ada-lang.c (add_nonlocal_symbols)
3450         (ada_collect_symbol_completion_matches)
3451         (ada_add_global_exceptions): Update.
3452
3453 2019-01-15  Tom Tromey  <tom@tromey.com>
3454
3455         * progspace.h (program_space) <objfiles_safe_range>: New
3456         typedef.
3457         <objfiles_safe>: New method.
3458         * objfiles.h (class all_objfiles_safe): Remove.
3459         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3460         * jit.c (jit_inferior_exit_hook): Update.
3461
3462 2019-01-17  Tom Tromey  <tom@tromey.com>
3463
3464         * progspace.h (program_space) <objfiles_range>: New typedef.
3465         <objfiles>: New method.
3466         <objfiles_head>: Rename from objfiles.
3467         (object_files): Update.
3468         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3469         * guile/scm-pretty-print.c
3470         (ppscm_find_pretty_printer_from_objfiles): Update.
3471         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3472         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3473         Update.
3474         * python/py-progspace.c (pspy_get_objfiles): Update.
3475         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3476         Update.
3477         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3478         (objfpy_lookup_objfile_by_build_id): Update.
3479         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3480         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3481         Update.
3482         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3483         (expand_symtab_containing_pc, lookup_objfile_from_block)
3484         (lookup_static_symbol, basic_lookup_transparent_type)
3485         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3486         (find_line_symtab, info_sources_command)
3487         (default_collect_symbol_completion_matches_break_on)
3488         (make_source_files_completion_list, find_main_name): Update.
3489         * symmisc.c (print_symbol_bcache_statistics)
3490         (print_objfile_statistics, maintenance_print_symbols)
3491         (maintenance_print_msymbols, maintenance_print_objfiles)
3492         (maintenance_info_symtabs, maintenance_check_symtabs)
3493         (maintenance_expand_symtabs, maintenance_info_line_tables):
3494         Update.
3495         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3496         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3497         (map_overlay_command, unmap_overlay_command)
3498         (simple_overlay_update, expand_symtabs_matching)
3499         (map_symbol_filenames): Update.
3500         * symfile-debug.c (set_debug_symfile): Update.
3501         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3502         Update.
3503         * source.c (select_source_symtab, forget_cached_source_info):
3504         Update.
3505         * solib.c (solib_read_symbols): Update.
3506         * solib-spu.c (append_ocl_sos): Update.
3507         * psymtab.c (maintenance_print_psymbols)
3508         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3509         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3510         * printcmd.c (info_symbol_command): Update.
3511         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3512         Update.
3513         * objfiles.h (class all_objfiles): Remove.
3514         * objfiles.c (have_partial_symbols, have_full_symbols)
3515         (have_minimal_symbols, qsort_cmp, update_section_map)
3516         (shared_objfile_contains_address_p)
3517         (default_iterate_over_objfiles_in_search_order): Update.
3518         * objc-lang.c (info_selectors_command, info_classes_command)
3519         (find_methods): Update.
3520         * minsyms.c (find_solib_trampoline_target): Update.
3521         * maint.c (maintenance_info_sections)
3522         (maintenance_translate_address, count_symtabs_and_blocks):
3523         Update.
3524         * main.c (captured_main_1): Update.
3525         * linux-thread-db.c (try_thread_db_load_from_pdir)
3526         (has_libpthread): Update.
3527         * linespec.c (iterate_over_all_matching_symtabs)
3528         (search_minsyms_for_name): Update.
3529         * jit.c (jit_find_objf_with_entry_addr): Update.
3530         * hppa-tdep.c (find_unwind_entry)
3531         (hppa_lookup_stub_minimal_symbol): Update.
3532         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3533         Update.
3534         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3535         (elf_gnu_ifunc_resolve_by_got): Update.
3536         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3537         * dwarf-index-write.c (save_gdb_index_command): Update.
3538         * cp-support.c (add_symbol_overload_list_qualified): Update.
3539         * breakpoint.c (create_overlay_event_breakpoint)
3540         (create_longjmp_master_breakpoint)
3541         (create_std_terminate_master_breakpoint)
3542         (create_exception_master_breakpoint): Update.
3543         * blockframe.c (find_pc_partial_function): Update.
3544         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3545         (ada_collect_symbol_completion_matches)
3546         (ada_add_global_exceptions): Update.
3547
3548 2019-01-17  Tom Tromey  <tom@tromey.com>
3549
3550         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3551         declare VEC.
3552         (solib_target_parse_libraries): Change return type.
3553         (library_list_start_segment, library_list_start_section)
3554         (library_list_end_library, library_list_start_library); Update.
3555         (solib_target_free_library_list): Remove.
3556         (solib_target_parse_libraries): Remove cleanup.  Change return
3557         type.
3558         (solib_target_current_sos): Update.
3559
3560 2019-01-17  Tom Tromey  <tromey@bapiya>
3561
3562         * valprint.c: Replace "the the" with "the".
3563         * symtab.c: Replace "the the" with "the".
3564         * solib.c: Replace "the the" with "the".
3565         * solib-dsbt.c: Replace "the the" with "the".
3566         * linespec.c: Replace "the the" with "the".
3567         * dwarf2loc.h: Replace "the the" with "the".
3568         * amd64-windows-tdep.c: Replace "the the" with "the".
3569         * aarch64-tdep.c: Replace "the the" with "the".
3570
3571 2019-01-16  Keith Seitz  <keiths@redhat.com>
3572
3573         PR gdb/23773
3574         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3575         <builder>: Rename to ..
3576         <m_builder>: ... this and make private.
3577         (dwarf2_cu::get_builder): New method.  Change all users of
3578         `builder' to use this method.
3579         (dwarf2_start_symtab): Move to ...
3580         (dwarf2_cu::start_symtab): ... here.  Update all callers
3581         (setup_type_unit_groups): Move to ...
3582         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3583         callers.
3584         (dwarf2_cu::reset_builder): New method.
3585         (process_full_compunit, process_full_type_unit): Use
3586         dwarf2_cu::reset_builder.
3587         (follow_die_offset): Record the ancestor CU if it is different
3588         from the followed DIE's CU.
3589         (follow_die_sig_1): Likewise.
3590
3591 2019-01-15  Tom Tromey  <tom@tromey.com>
3592
3593         * remote.c (class remote_state) <buf>: Now a char_vector.
3594         <buf_size>: Remove.
3595         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3596         parameter.
3597         (remote_target::getpkt_or_notif_sane_1)
3598         (remote_target::getpkt_sane)
3599         (remote_target::getpkt_or_notif_sane): Likewise.
3600         (class remote_target) <putpkt>: New overload.
3601         (remote_target::read_frame): Change type of "buf_p".  Remove
3602         sizeof_p parameter.
3603         (packet_ok): New overload.
3604         (packet_check_result): New overload.
3605         Update all uses.
3606
3607 2019-01-14  Tom Tromey  <tom@tromey.com>
3608
3609         * remote-notif.c (handle_notification, remote_notif_ack)
3610         (remote_notif_parse): Make "buf" const.
3611         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3612         const.
3613         (remote_notif_parse, remote_notif_ack, handle_notification):
3614         Likewise.
3615         * remote.c (remote_notif_stop_parse): Make "buf" const.
3616         (remote_target::remote_parse_stop_reply): Make "buf" const.
3617         (remote_notif_stop_ack): Make "buf" const.
3618
3619 2019-01-14  Tom Tromey  <tom@tromey.com>
3620
3621         * remote.c (remote_console_output): Make parameter const.
3622
3623 2019-01-14  Tom Tromey  <tom@tromey.com>
3624
3625         * target-debug.h (target_debug_print_signals): Constify.
3626         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3627         * procfs.c (procfs_target::pass_signals): Update.
3628         * linux-nat.c (linux_nat_target::pass_signals): Update.
3629         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3630         * target-delegates.c: Rebuild.
3631         * remote.c (remote_target::program_signals): Update.
3632         (remote_target::pass_signals): Update.
3633         * target.c (target_pass_signals): Constify argument.
3634         (target_program_signals): Likewise.
3635         * target.h (struct target_ops) <pass_signals, program_signals>:
3636         Constify argument.
3637         (target_pass_signals, target_program_signals): Constify argument.
3638
3639 2019-01-14  Tom Tromey  <tom@tromey.com>
3640
3641         PR tui/28819:
3642         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3643
3644 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3645
3646         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3647         field.
3648         * rs6000-tdep.c: Include reggroups.h.
3649         (IS_V_ALIAS_PSEUDOREG): Define.
3650         (rs6000_register_name): Return names for the "vX" aliases.
3651         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3652         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3653         aliases.  Call default_register_reggroup_p for all other
3654         pseudo-registers.
3655         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3656         New functions.
3657         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3658         Handle "vX" aliases.
3659         (v_alias_pseudo_register_collect): New function.
3660         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3661         (rs6000_gdbarch_init): Initialize "vX" aliases as
3662         pseudo-registers.  Restore registration of
3663         rs6000_pseudo_register_reggroup_p with
3664         set_tdesc_pseudo_register_reggroup_p.
3665
3666 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3667
3668         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3669         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3670         set_gdbarch_num_pseudo_regs.
3671
3672 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3673
3674         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3675         Remove arg prefixname, add do_set and do_show.
3676         Add member functions set_list and show_list.
3677         * cli/cli-style.c (class cli_style_option): Update accordingly.
3678         (style_set_list): Move to file scope.
3679         (style_show_list): Likewise.
3680         (set_style): Call help_list.
3681         (show_style): Call cmd_show_list.
3682         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3683         Update to use the new macro.
3684
3685 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3686
3687         * ada-lang.c (_initialize_ada_language): Expand the help text
3688         for the "catch exception" command.
3689
3690 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3691
3692         * symtab.c (matching_obj_sections): Initialize obj,
3693         declare it closer to its usage.
3694
3695 2019-01-10  Tom Tromey  <tom@tromey.com>
3696
3697         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3698         (basic_inf_threads_range): Remove.
3699         (inf_threads_range, inf_non_exited_threads_range)
3700         (safe_inf_threads_range): Use next_adapter.
3701
3702 2019-01-10  Keith Seitz  <keiths@redhat.com>
3703
3704         PR gdb/23712
3705         PR symtab/23010
3706         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3707         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3708
3709 2019-01-10  Keith Seitz  <keiths@redhat.com>
3710
3711         PR gdb/23712
3712         PR symtab/23010
3713         * dictionary.c (pending_to_vector): Remove.
3714         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3715         Remove _1 suffix, replacing functions of the same name.  Update
3716         all callers.
3717         (dict_create_hashed, dict_create_hashed_expandable)
3718         (dict_create_linear, dict_create_linear_expandable, dict_free)
3719         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3720         Make functions static.
3721
3722 2019-01-10  Keith Seitz  <keiths@redhat.com>
3723
3724         PR gdb/23712
3725         PR symtab/23010
3726         * dictionary.h (struct dictionary): Replace declaration with
3727         multidictionary.
3728         (dict_create_hashed, dict_create_hashed_expandable)
3729         (dict_create_linear, dict_create_linear_expandable)
3730         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3731         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3732         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3733         taking multidictionary argument.
3734         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3735         * block.h (struct block) <dict>: Change to multidictionary
3736         and rename `multidict'.
3737         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3738         symmisc.c: Update all dictionary references to multidictionary.
3739
3740 2019-01-10  Keith Seitz  <keiths@redhat.com>
3741
3742         PR gdb/23712
3743         PR symtab/23010
3744         * dictionary.c: Include unordered_map.
3745         (pending_to_vector): New function.
3746         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3747         Rewrite the non-"_1" functions to take vector instead
3748         of linked list.
3749         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3750         "new" _1 versions of the same name.
3751         (multidictionary): Define.
3752         (std::hash<enum language): New definition.
3753         (collate_pending_symbols_by_language, mdict_create_hashed)
3754         (mdict_create_hashed_expandable, mdict_create_linear)
3755         (mdict_create_linear_expandable, mdict_free)
3756         (find_language_dictionary, create_new_language_dictionary)
3757         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3758         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3759         (mdict_size, mdict_empty): New functions.
3760         * dictionary.h (mdict_iterator): Define.
3761
3762 2019-01-10  Pedro Alves  <palves@redhat.com>
3763
3764         * breakpoint.c (read_uploaded_action)
3765         (create_tracepoint_from_upload): Adjust to use
3766         gdb::unique_xmalloc_ptr.
3767         * ctf.c (ctf_write_uploaded_tp):
3768         (SET_ARRAY_FIELD): Use emplace_back.
3769         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3770         * tracefile-tfile.c (tfile_write_uploaded_tp):
3771         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3772         gdb::unique_xmalloc_ptr.
3773         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3774         at_string, cond_string, cmd_strings>: Replace char pointers
3775         with gdb::unique_xmalloc_ptr.
3776
3777 2019-01-10  Pedro Alves  <palves@redhat.com>
3778
3779         * solib-target.c (library_list_start_library): Don't xstrdup name.
3780
3781 2019-01-10  Pedro Alves  <palves@redhat.com>
3782
3783         * mdebugread.c (parse_partial_symbols): Use
3784         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3785
3786 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3787
3788         * linux-fork.c (scoped_switch_fork_info)
3789         <~scoped_switch_fork_info>: Fix incorrect variable name.
3790
3791 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3792
3793         * linux-fork.c (scoped_switch_fork_info)
3794         <scoped_switch_fork_info>: Make explicit.
3795         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3796
3797 2019-01-10  Tom Tromey  <tom@tromey.com>
3798
3799         * objfiles.h (objfile::reset_psymtabs): Update.
3800         * objfiles.c (objfile::objfile): Update.
3801         * psymtab.h (psymtab_storage::obstack): Update.
3802         (psymtab_storage::m_obstack): Use gdb::optional.
3803         (class psymtab_storage): Update comment.  Remove objfile
3804         parameter.
3805         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3806
3807 2019-01-10  Tom Tromey  <tom@tromey.com>
3808
3809         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3810         <free_psymtabs>: Now private.
3811         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3812         (allocate_psymtab): Use new method.
3813
3814 2019-01-10  Tom Tromey  <tom@tromey.com>
3815
3816         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3817         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3818         * mdebugread.c (parse_partial_symbols): Use
3819         allocate_dependencies.
3820         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3821         allocate_dependencies.
3822         (process_psymtab_comp_unit_reader)
3823         (build_type_psymtab_dependencies): Likewise.
3824         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3825
3826 2019-01-10  Tom Tromey  <tom@tromey.com>
3827
3828         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3829         PSYMBOL_SET_LANGUAGE.
3830         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3831
3832 2019-01-10  Tom Tromey  <tom@tromey.com>
3833
3834         * psymtab.h (psymtab_storage::obstack): New method.
3835         <m_obstack>: Rename from obstack; now private.
3836         * psymtab.c (psymtab_storage): Update.
3837         * dwarf2read.c (create_addrmap_from_index)
3838         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3839         Update.
3840
3841 2019-01-10  Tom Tromey  <tom@tromey.com>
3842
3843         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3844         * objfiles.h (objfile::reset_psymtabs): New method.
3845
3846 2019-01-10  Tom Tromey  <tom@tromey.com>
3847
3848         * symmisc.c (print_symbol_bcache_statistics): Update.
3849         (print_objfile_statistics): Update.
3850         * symfile.c (reread_symbols): Update.
3851         * psymtab.h (class psymtab_storage): New.
3852         * psymtab.c (psymtab_storage): New constructor.
3853         (~psymtab_storage): New destructor.
3854         (require_partial_symbols): Update.
3855         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3856         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3857         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3858         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3859         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3860         (start_psymtab_common, end_psymtab_common)
3861         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3862         (allocate_psymtab): Update.
3863         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3864         Update.
3865         (dump_psymtab_addrmap, maintenance_print_psymbols)
3866         (maintenance_check_psymtabs): Update.
3867         (class objfile_psymtabs): Move to objfiles.h.
3868         * psympriv.h (discard_psymtab): Now inline.
3869         (psymtab_discarder::psymtab_discarder): Update.
3870         (psymtab_discarder::~psymtab_discarder): Update.
3871         (ALL_OBJFILE_PSYMTABS): Rewrite.
3872         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3873         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3874         Remove fields.
3875         <partial_symtabs>: New field.
3876         (class objfile_psymtabs): Move from psymtab.h.  Update.
3877         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3878         psymbol_cache.
3879         (objfile::~objfile): Don't destroy psymbol_cache.
3880         * mdebugread.c (parse_partial_symbols): Update.
3881         * dwarf2read.c (create_addrmap_from_index)
3882         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3883         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3884         (add_partial_subprogram, dwarf2_ranges_read): Update.
3885         * dwarf-index-write.c (write_address_map)
3886         (write_one_signatured_type, recursively_write_psymbols)
3887         (class debug_names, class debug_names, write_psymtabs_to_index):
3888         Update.
3889
3890 2019-01-10  Tom Tromey  <tom@tromey.com>
3891
3892         * symtab.h (SYMBOL_SET_NAMES): Update.
3893         (symbol_set_names): Update.
3894         (MSYMBOL_SET_NAMES): Update.
3895         * symtab.c (symbol_set_names): Change argument to be an
3896         objfile_per_bfd_storage.
3897         * psymtab.c (add_psymbol_to_bcache): Update.
3898         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3899
3900 2019-01-10  Tom Tromey  <tom@tromey.com>
3901
3902         * symtab.c (create_demangled_names_hash): Change argument to be an
3903         objfile_per_bfd_storage.
3904         (symbol_set_names): Update.
3905
3906 2019-01-10  Tom Tromey  <tom@tromey.com>
3907
3908         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3909         init_psymbol_list.
3910         * psymtab.c (init_psymbol_list): Do nothing if already called.
3911         * psympriv.h (init_psymbol_list): Add comment.
3912         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3913         init_psymbol_list.
3914         * dbxread.c (dbx_symfile_read): Unconditionally call
3915         init_psymbol_list.
3916
3917 2019-01-10  Tom Tromey  <tom@tromey.com>
3918
3919         * xcoffread.c (scan_xcoff_symtab): Update.
3920         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3921         "where".
3922         * mdebugread.c (parse_partial_symbols)
3923         (handle_psymbol_enumerators): Update.
3924         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3925         * dbxread.c (read_dbx_symtab): Update.
3926         * psympriv.h (psymbol_placement): New enum.
3927         (add_psymbol_to_list): Update.
3928
3929 2019-01-10  Tom Tromey  <tom@tromey.com>
3930
3931         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3932         static_psymbols parameters.
3933         (scan_xcoff_symtab): Update.
3934         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3935         static_psymbols parameters.
3936         * psympriv.h (start_psymtab_common): Update.
3937         * mdebugread.c (parse_partial_symbols): Update.
3938         * dwarf2read.c (create_partial_symtab): Update.
3939         * dbxread.c (read_dbx_symtab): Update.
3940         (start_psymtab): Remove global_psymbols and static_psymbols
3941         parameters.
3942
3943 2019-01-10  Tom Tromey  <tom@tromey.com>
3944
3945         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3946         * psymtab.c (allocate_psymtab): Add comment.
3947         * psympriv.h (allocate_psymtab): Add comment.
3948         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3949         initializations.
3950         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3951
3952 2019-01-10  Tom Tromey  <tom@tromey.com>
3953
3954         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3955         Don't declare.
3956         * mipsread.c: Include mdebugread.h.
3957         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3958         Declare.
3959         * elfread.c: Include mdebugread.h.
3960
3961 2019-01-09  Tom Tromey  <tom@tromey.com>
3962
3963         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3964         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3965         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3966         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3967         (psym_lookup_symbol, psym_find_last_source_symtab)
3968         (psym_forget_cached_source_info, psym_print_stats)
3969         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3970         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3971         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3972         (psym_find_compunit_symtab_by_address)
3973         (maintenance_print_psymbols, maintenance_info_psymtabs)
3974         (maintenance_check_psymtabs): Use ranged for.
3975         * psymtab.h (class objfile_psymtabs): New.
3976         (require_partial_symbols): Return objfile_psymtabs.
3977         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3978
3979 2019-01-09  Tom Tromey  <tom@tromey.com>
3980
3981         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3982         (find_pc_mapped_section, list_overlays_command)
3983         (map_overlay_command, unmap_overlay_command)
3984         (simple_overlay_update): Use all_objfiles.
3985         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3986         * printcmd.c (info_symbol_command): Use all_objfiles.
3987         * objfiles.h (ALL_OBJSECTIONS): Remove.
3988         * maint.c (maintenance_translate_address): Use all_objfiles.
3989         * gcore.c (gcore_create_callback): Use all_objfiles.
3990         (objfile_find_memory_regions): Likewise.
3991
3992 2019-01-09  Tom Tromey  <tom@tromey.com>
3993
3994         * symtab.c (find_line_symtab, info_sources_command)
3995         (make_source_files_completion_list): Use objfile_compunits.
3996         * source.c (select_source_symtab): Use objfile_compunits.
3997         * objfiles.h (struct objfile): Update comment.
3998         (ALL_OBJFILES): Remove.
3999         (ALL_FILETABS): Remove.
4000         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4001         objfile_compunits.
4002
4003 2019-01-09  Tom Tromey  <tom@tromey.com>
4004
4005         * symmisc.c (print_objfile_statistics, dump_objfile)
4006         (maintenance_print_symbols): Use compunit_filetabs.
4007         * source.c (forget_cached_source_info_for_objfile): Use
4008         compunit_filetabs.
4009         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4010         (ALL_FILETABS): Use compunit_filetabs.
4011         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4012         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4013
4014 2019-01-09  Tom Tromey  <tom@tromey.com>
4015
4016         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4017         (compunit_filetabs): New.
4018         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4019         compunit_filetabs.
4020         (info_sources_command, make_source_files_completion_list): Remove
4021         declaration.
4022         * symmisc.c (print_objfile_statistics, dump_objfile)
4023         (maintenance_print_symbols): Remove declaration.
4024         (maintenance_info_symtabs): Use compunit_filetabs.
4025         (maintenance_info_line_tables): Likewise.
4026         * source.c (select_source_symtab): Change local variable name.
4027         (forget_cached_source_info_for_objfile): Remove declaration.
4028         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4029         * objfiles.c (objfile_relocate1): Remove declaration.
4030         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4031         declaration.
4032         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4033         * coffread.c (coff_symtab_read): Remove declaration.
4034         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4035         compunit_filetabs.
4036
4037 2019-01-09  Tom Tromey  <tom@tromey.com>
4038
4039         * symtab.c (lookup_objfile_from_block)
4040         (find_pc_sect_compunit_symtab, search_symbols)
4041         (default_collect_symbol_completion_matches_break_on): Use
4042         objfile_compunits.
4043         * objfiles.h (ALL_COMPUNITS): Remove.
4044         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4045         * cp-support.c (add_symbol_overload_list_qualified): Use
4046         objfile_compunits.
4047         * ada-lang.c (ada_collect_symbol_completion_matches)
4048         (ada_add_global_exceptions): Use objfile_compunits.
4049
4050 2019-01-09  Tom Tromey  <tom@tromey.com>
4051
4052         * source.c (select_source_symtab)
4053         (forget_cached_source_info_for_objfile): Remove declaration.
4054         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4055         declaration.
4056         * maint.c (count_symtabs_and_blocks): Remove declaration.
4057         * cp-support.c (add_symbol_overload_list_qualified): Remove
4058         declaration.
4059         * coffread.c (coff_symtab_read): Remove declaration.
4060         * symtab.c (lookup_symbol_in_objfile_symtabs)
4061         (basic_lookup_transparent_type_1): Use objfile_compunits.
4062         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4063         (info_sources_command, search_symbols)
4064         (default_collect_symbol_completion_matches_break_on)
4065         (make_source_files_completion_list): Remove declaration.
4066         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4067         (ada_collect_symbol_completion_matches)
4068         (ada_add_global_exceptions): Remove declaration.
4069         * linespec.c (iterate_over_all_matching_symtabs): Use
4070         objfile_compunits.
4071         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4072         (class objfile_compunits): New.
4073         (ALL_COMPUNITS): Use objfile_compunits.
4074         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4075         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4076         objfile_compunits.
4077         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4078
4079 2019-01-09  Tom Tromey  <tom@tromey.com>
4080
4081         * symtab.c (search_symbols)
4082         (default_collect_symbol_completion_matches_break_on): Use
4083         objfile_msymbols.
4084         * ada-lang.c (ada_lookup_simple_minsym)
4085         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4086         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4087         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4088         objfile_msymbols.
4089         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4090         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4091         * objc-lang.c (find_methods): Use objfile_msymbols.
4092         (info_selectors_command, info_classes_command): Likewise.
4093         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4094         * objfiles.h (class objfile_msymbols): New.
4095         (ALL_OBJFILE_MSYMBOLS): Remove.
4096         (ALL_MSYMBOLS): Remove.
4097
4098 2019-01-09  Tom Tromey  <tom@tromey.com>
4099
4100         * common/next-iterator.h (next_adapter): Add Iterator template
4101         parameter.
4102         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4103         (class all_objfiles_safe): New.
4104         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4105         * objfiles.c (put_objfile_before): Update comment.
4106         (add_separate_debug_objfile): Likewise.
4107         (free_all_objfiles): Use all_objfiles_safe.
4108         (objfile_purge_solibs): Likewise.
4109
4110 2019-01-09  Tom Tromey  <tom@tromey.com>
4111
4112         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4113         (expand_symtab_containing_pc, lookup_static_symbol)
4114         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4115         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4116         all_objfiles.
4117         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4118         * breakpoint.c (create_overlay_event_breakpoint)
4119         (create_longjmp_master_breakpoint)
4120         (create_std_terminate_master_breakpoint)
4121         (create_exception_master_breakpoint): Use all_objfiles.
4122         * linux-thread-db.c (try_thread_db_load_from_pdir)
4123         (has_libpthread): Use all_objfiles.
4124         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4125         * linespec.c (iterate_over_all_matching_symtabs)
4126         (search_minsyms_for_name): Use all_objfiles.
4127         * maint.c (maintenance_info_sections): Use all_objfiles.
4128         * main.c (captured_main_1): Use all_objfiles.
4129         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4130         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4131         * guile/scm-pretty-print.c
4132         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4133         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4134         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4135         (maintenance_print_msymbols): Use all_objfiles.
4136         * source.c (select_source_symtab): Use all_objfiles.
4137         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4138         * symfile.c (remove_symbol_file_command)
4139         (expand_symtabs_matching, map_symbol_filenames): Use
4140         all_objfiles.
4141         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4142         all_objfiles.
4143         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4144         * objc-lang.c (find_methods): Use all_objfiles.
4145         * objfiles.c (have_partial_symbols, have_full_symbols)
4146         (have_minimal_symbols, qsort_cmp)
4147         (default_iterate_over_objfiles_in_search_order): Use
4148         all_objfiles.
4149         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4150         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4151         (maintenance_check_psymtabs): Use all_objfiles.
4152         (ALL_PSYMTABS): Remove.
4153         * compile/compile-object-run.c (do_module_cleanup): Use
4154         all_objfiles.
4155         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4156         * cp-support.c (add_symbol_overload_list_qualified): Use
4157         all_objfiles.
4158         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4159         Use all_objfiles.
4160         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4161         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4162         all_objfiles.
4163         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4164         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4165         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4166         Uses all_objfiles.
4167         * solib.c (solib_read_symbols): Use all_objfiles
4168
4169 2019-01-09  Tom Tromey  <tom@tromey.com>
4170
4171         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4172         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4173         all_objfiles.
4174         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4175         * symmisc.c (print_symbol_bcache_statistics)
4176         (print_objfile_statistics, maintenance_print_objfiles)
4177         (maintenance_info_symtabs, maintenance_check_symtabs)
4178         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4179         all_objfiles.
4180         * source.c (forget_cached_source_info): Use all_objfiles.
4181         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4182         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4183         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4184         * objfiles.c (update_section_map): Use all_objfiles.
4185         (shared_objfile_contains_address_p): Likewise.
4186         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4187         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4188
4189 2019-01-09  Tom Tromey  <tom@tromey.com>
4190
4191         * common/next-iterator.h: New file.
4192         * objfiles.h (class all_objfiles): New.
4193         (struct objfile_iterator): New.
4194
4195 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4196
4197         * NEWS: Move the description of the changed "frame", "select-frame",
4198          and "info frame" commands to the Changed commands section.
4199
4200 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4201
4202         * gdbtypes.c (check_stub_method_group): Remove handling of old
4203         mangling schemes.
4204         * linespec.c (find_methods): Likewise.
4205         * stabsread.c (read_member_functions): Likewise.
4206         * valops.c (search_struct_method): Likewise.
4207         (value_struct_elt_for_reference): Likewise.
4208         * NEWS: Mention this change.
4209
4210 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4211
4212         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4213         print_source_lines.
4214         * source.c (print_source_lines_base): Update line number check.
4215         (print_source_lines): New function.
4216         (source_lines_range::source_lines_range): New function.
4217         * source.h (class source_lines_range): New class.
4218         (print_source_lines): New declaration.
4219
4220 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4221
4222         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4223
4224 2019-01-08  Tom Tromey  <tom@tromey.com>
4225             Simon Marchi  <simon.marchi@ericsson.com>
4226
4227         PR gdb/24060
4228         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4229         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4230         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4231         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4232         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4233         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4234
4235 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4236
4237         * source.c (select_source_symtab): Move header comment to
4238         declaration in source.h.
4239         (forget_cached_source_info_for_objfile): Likewise.
4240         (forget_cached_source_info): Likewise.
4241         (identify_source_line): Likewise.
4242         * source.h (identify_source_line): Move declaration from symtab.h
4243         and add comment from source.c
4244         (print_source_lines): Likewise.
4245         (forget_cached_source_info_for_objfile): Likewise.
4246         (forget_cached_source_info): Likewise.
4247         (select_source_symtab): Likewise.
4248         (enum print_source_lines_flag): Move definition from symtab.h.
4249         * symtab.h (identify_source_line): Move declaration to source.h.
4250         (print_source_lines): Likewise.
4251         (forget_cached_source_info_for_objfile): Likewise.
4252         (forget_cached_source_info): Likewise.
4253         (select_source_symtab): Likewise.
4254         (enum print_source_lines_flag): Move definition to source.h.
4255         * tui/tui-hooks.c: Add 'source.h' include.
4256
4257 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * source.c (print_source_lines_base): Handle requests to print
4260         reverse line number sequences, and guard against empty lines
4261         string.
4262
4263 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4264
4265         * source.c (print_source_lines_base): Fix skip of '\r' if next
4266         character is '\n'.
4267
4268 2019-01-06  Tom Tromey  <tom@tromey.com>
4269
4270         * c-exp.y (struct c_parse_state) <macro_original_text,
4271         expansion_obstack>: New member.
4272         (macro_original_text, expansion_obstack): Remove globals.
4273         (scan_macro_expansion, scanning_macro_expansion)
4274         (finished_macro_expansion): Update.
4275         (scan_macro_cleanup): Remove.
4276         (yylex, c_parse): Update.
4277
4278 2019-01-06  Tom Tromey  <tom@tromey.com>
4279
4280         * c-exp.y (struct c_parse_state) <strings>: New member.
4281         (operator_stoken): Update.
4282
4283 2019-01-06  Tom Tromey  <tom@tromey.com>
4284
4285         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4286         (union type_stack_elt) <typelist_val>: Now a pointer to
4287         std::vector.
4288         (type_stack_cleanup): Don't declare.
4289         (push_typelist): Update.
4290         * parse.c (pop_typelist): Return a std::vector.
4291         (push_typelist): Take a std::vector.
4292         (follow_types): Update.  Do not free args.
4293         (type_stack_cleanup): Remove.
4294         * c-exp.y (struct c_parse_state): New.
4295         (cpstate): New global.
4296         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4297         (nonempty_typelist): Update.
4298         (func_mod): Create a new vector.
4299         (c_parse): Create a c_parse_state.
4300         (check_parameter_typelist): Do not delete params.
4301         (function_method): Update.  Do not delete type_list.
4302
4303 2019-01-06  Tom Tromey  <tom@tromey.com>
4304
4305         PR gdb/28155:
4306         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4307         check_typedef.
4308         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4309         (print_return_value): Likewise.
4310
4311 2019-01-05  Tom Tromey  <tom@tromey.com>
4312
4313         * contrib/cleanup_check.py: Remove.
4314         * contrib/gcc-with-excheck: Remove.
4315         * contrib/exsummary.py: Remove.
4316         * contrib/excheck.py: Remove.
4317
4318 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4319
4320         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4321         NULL. Initialize tpprev to NULL instead of assigning it
4322         to NULL on the next statement.
4323         * windows-nat.c (windows_delete_thread): Remove check for
4324         main_thread_id before printing thread exit notifications.
4325         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4326         Remove thread ID check against main_thread_id.
4327         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4328         windows_delete_thread.
4329         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4330
4331 2019-01-04  Tom Tromey  <tom@tromey.com>
4332
4333         * compile/compile.c (_initialize_compile): Use upper case for
4334         metasyntactic variables.
4335         * symmisc.c (_initialize_symmisc): Use upper case for
4336         metasyntactic variables.
4337         * psymtab.c (_initialize_psymtab): Use upper case for
4338         metasyntactic variables.
4339         * demangle.c (demangle_command): Use upper case for metasyntactic
4340         variables.
4341         (_initialize_demangler): Likewise.
4342         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4343         variables.
4344
4345 2019-01-03  Tom Tromey  <tom@tromey.com>
4346
4347         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4348
4349 2019-01-03  Tom Tromey  <tom@tromey.com>
4350
4351         * python/py-symtab.c (salpy_str): Update.
4352         (struct salpy_sal_object) <symtab>: Now a PyObject.
4353         (salpy_dealloc): Update.
4354         (del_objfile_sal): Use gdbpy_ref.
4355
4356 2019-01-03  Tom Tromey  <tom@tromey.com>
4357
4358         * python/py-type.c (convert_field): Use new_reference.  Return
4359         gdbpy_ref.
4360         (make_fielditem): Return gdbpy_ref.
4361         (typy_fields): Update.
4362         (typy_getitem): Update.
4363         (field_name): Return gdbpy_ref.  Use new_reference.
4364         (typy_iterator_iternext): Update.
4365
4366 2019-01-03  Tom Tromey  <tom@tromey.com>
4367
4368         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4369
4370 2019-01-03  Tom Tromey  <tom@tromey.com>
4371
4372         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4373         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4374         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4375         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4376         (pspy_set_type_printers): Likewise.
4377         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4378         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4379         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4380         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4381         (objfpy_set_type_printers): Likewise.
4382
4383 2019-01-03  Tom Tromey  <tom@tromey.com>
4384
4385         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4386         (gdbpy_print_stack): Use gdbpy_err_fetch.
4387         * python/python-internal.h (class gdbpy_err_fetch): New class.
4388         (class gdbpy_enter) <m_error_type, m_error_value,
4389         m_error_traceback>: Remove.
4390         <m_error>: New member.
4391         (gdbpy_exception_to_string): Don't declare.
4392         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4393         * python/py-value.c (convert_value_from_python): Use
4394         gdbpy_err_fetch.
4395         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4396         gdbpy_exception_to_string.
4397         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4398         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4399         gdbpy_err_fetch.
4400
4401 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4402
4403         * linux-nat.c (delete_lwp_cleanup): Delete.
4404         (struct lwp_deleter): New struct.
4405         (lwp_info_up): New typedef.
4406         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4407         lwp_info_up.
4408
4409 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4410
4411         * linux-fork.c (class scoped_switch_fork_info): New class.
4412         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4413
4414 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4415
4416         * valops.c (find_overload_match): Remove use of null_cleanup, and
4417         calls to do_cleanups.
4418
4419 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4420
4421         * compile/compile-cplus-types.c
4422         (compile_cplus_instance::decl_name): Handle changes to
4423         cp_func_name.
4424         * cp-support.c (cp_func_name): Update header comment, update
4425         return type.
4426         * cp-support.h (cp_func_name): Update return type in declaration.
4427         * valops.c (find_overload_match): Move temp_func local to top
4428         level of function and change its type.  Use temp_func to hold and
4429         delete temporary string obtained from cp_func_name.
4430
4431 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4432
4433         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4434         gdb::char_vector, remove cleanup, and update uses of `msg`.
4435
4436 2019-01-03  Jim Wilson  <jimw@sifive.com>
4437
4438         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4439
4440 2019-01-02  Tom Tromey  <tom@tromey.com>
4441
4442         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4443         (tdesc_parse_xml): Remove cleanups.
4444         * target-descriptions.h (make_cleanup_free_target_description):
4445         Don't declare.
4446         (target_desc_deleter): New struct.
4447         (target_desc_up): New typedef.
4448         * target-descriptions.c (target_desc_deleter::operator()): Rename
4449         from free_target_description.
4450         (make_cleanup_free_target_description): Remove.
4451
4452 2019-01-02  Tom Tromey  <tom@tromey.com>
4453
4454         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4455         constructor, destructor.
4456         (linespec_parser): Remove typedef.
4457         (~linespec_parser): Rename from linespec_parser_delete.
4458         (linespec_lex_to_end, linespec_complete_label)
4459         (linespec_complete): Update.
4460         (decode_line_full): Remove cleanups.
4461         (decode_line_1): Update.
4462
4463 2019-01-02  Tom Tromey  <tom@tromey.com>
4464
4465         * python/python-internal.h (inferior_to_inferior_object): Change
4466         return type.
4467         * python/py-exitedevent.c (create_exited_event_object): Update.
4468         * python/py-inferior.c (inferior_to_inferior_object): Return
4469         gdbpy_ref.
4470         (python_new_inferior, python_inferior_deleted)
4471         (thread_to_thread_object, delete_thread_object)
4472         (build_inferior_list, gdbpy_selected_inferior): Update.
4473         * python/py-infthread.c (create_thread_object): Update.  Also fail
4474         if inferior_to_inferior_object fails.
4475
4476 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4477
4478         * inferior.h (class inferior) <displaced_step_state>: New field.
4479         * infrun.h (struct displaced_step_state): Move here from
4480         infrun.c.  Initialize fields, add constructor.
4481         <inf>: Remove field.
4482         <reset>: New method.
4483         * infrun.c (struct displaced_step_inferior_state): Move to
4484         infrun.h.
4485         (displaced_step_inferior_states): Remove.
4486         (get_displaced_stepping_state): Adust.
4487         (displaced_step_in_progress_any_inferior): Adjust.
4488         (displaced_step_in_progress_thread): Adjust.
4489         (displaced_step_in_progress): Adjust.
4490         (add_displaced_stepping_state): Remove.
4491         (get_displaced_step_closure_by_addr): Adjust.
4492         (remove_displaced_stepping_state): Remove.
4493         (infrun_inferior_exit): Call displaced_step_state.reset.
4494         (use_displaced_stepping): Don't check for NULL.
4495         (displaced_step_prepare_throw): Call
4496         get_displaced_stepping_state.
4497         (displaced_step_fixup): Don't check for NULL.
4498         (prepare_for_detach): Don't check for NULL.
4499
4500 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4501
4502         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4503          in case of call that did not complete.
4504
4505 2019-01-02  Andrey Utkin  <autkin@undo.io>
4506
4507         * symfile.c (find_separate_debug_file): Fix search of debug files for
4508         remote debuggee.
4509
4510 2019-01-02  Tom Tromey  <tom@tromey.com>
4511
4512         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4513         indentation.
4514         * python/py-frame.c (frapy_older): Remove cast.
4515         (frapy_newer): Likewise.
4516         * python/py-breakpoint.c (local_setattro): Remove cast.
4517         * python/py-arch.c (archpy_name): Remove local variable.
4518         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4519
4520 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4521
4522         * unittests/basic_string_view/element_access/char/empty.cc:
4523         Fix year range in copyright header.
4524
4525 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4526
4527         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4528         Delete.
4529         <operator==>: Update with for removed field.
4530         <hash>: Likewise.
4531         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4532         <isa_features>: ...this.
4533         <abi_features>: New field.
4534         (riscv_isa_flen): Update comment.
4535         (riscv_abi_xlen): New declaration.
4536         (riscv_abi_flen): New declaration.
4537         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4538         isa_features.
4539         (riscv_abi_xlen): New function.
4540         (riscv_isa_flen): Update to get answer from isa_features.
4541         (riscv_abi_flen): New function.
4542         (riscv_has_fp_abi): Update to get answer from abi_features.
4543         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4544         xlen and flen.
4545         (riscv_call_info) <xlen, flen>: Update comment.
4546         (riscv_call_arg_struct): Remove invalid assertions
4547         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4548         is removed.
4549         (riscv_gdbarch_init): Gather isa features and abi features
4550         separately, ensure both match on the gdbarch when reusing an old
4551         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4552         a target with 64-bit float hardware.
4553
4554 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4555
4556         * source.c (search_command_helper): Stop reverse search
4557         when line 1 has been searched.
4558
4559 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4560
4561         * record-full.c (record_full_base_target::close): Rewrite
4562         record_full_core_buf_list free logic.
4563
4564 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4565
4566         * break-catch-syscall.c (print_one_catch_syscall): xfree
4567         the last text.
4568
4569 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4570
4571         * top.c (print_gdb_version): Update Copyright year in version
4572         message.
4573
4574 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4575
4576         Update copyright year range in all GDB files.
4577
4578 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4579
4580         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4581
4582 For older changes see ChangeLog-2018.
4583 \f
4584 Local Variables:
4585 mode: change-log
4586 left-margin: 8
4587 fill-column: 74
4588 version-control: never
4589 coding: utf-8
4590 End:
4591