gdb/ChangeLog

   1 2018-05-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui.c (tui_enable): Update.
   4         * mi/mi-interp.c (mi_interp::init): Update.
   5         * interps.h (class interp) <name>: New method.
   6         <m_name>: Rename from name.
   7         (~scoped_restore_interp): Update.
   8         * interps.c (interp::interp): Update.
   9         (interp_add, interp_set, interp_lookup_existing)
  10         (current_interp_named_p): Update.
  11
  12 2018-05-25  Tom Tromey  <tom@tromey.com>
  13
  14         * interps.c (interp_name): Remove.
  15         * mi/mi-interp.c (mi_interp::init): Update.
  16         * interps.h (interp_name): Remove.
  17         (~scoped_restore_interp): Update.
  18         * tui/tui.c (tui_enable): Update.
  19
  20 2018-05-25  Tom Tromey  <tom@tromey.com>
  21
  22         * utils.c (fputs_maybe_filtered): Update.
  23         * linespec.c (decode_line_full): Update.
  24         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
  25         (mi_print_breakpoint_for_event, mi_solib_loaded)
  26         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
  27         (mi_user_selected_context_changed): Update.
  28         * mi/mi-main.c (mi_execute_command): Update.
  29         * cli/cli-script.c (execute_control_command): Update.
  30         * python/python.c (execute_gdb_command): Update.
  31         * solib.c (info_sharedlibrary_command): Update.
  32         * interps.c (interp_ui_out): Remove.
  33         * interps.h (interp_ui_out): Remove.
  34
  35 2018-05-25  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
  38         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
  39         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
  40
  41 2018-05-25  Tom Tromey  <tom@tromey.com>
  42
  43         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
  44         * interps.c (interp_exec): Use scoped_restore.
  45
  46 2018-05-25  Tom Tromey  <tom@tromey.com>
  47
  48         * remote.c (remote_target::remote_file_get): Use
  49         gdb::byte_vector.
  50         (remote_target::remote_file_put): Likewise.
  51
  52 2018-05-25  Tom Tromey  <tom@tromey.com>
  53
  54         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
  55         a std::string.
  56         (get_pe_section_index, add_pe_exported_sym): Update.
  57         (read_pe_exported_syms): Use gdb::def_vector.
  58
  59 2018-05-25  Tom Tromey  <tom@tromey.com>
  60
  61         * frame.c (remove_prev_frame): Remove.
  62         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
  63
  64 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
  65
  66         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
  67         Remove prototypes.
  68         * mips-linux-nat.c (supply_fpregset): Always call
  69         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
  70         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
  71         `mips_fill_fpregset'.
  72         * mips-linux-tdep.c (mips_supply_fpregset)
  73         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
  74         (mips_fill_fpregset_wrapper): Remove functions.
  75         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
  76         (mips_linux_fpregset): Remove variable.
  77         (mips_linux_iterate_over_regset_sections): Use
  78         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
  79         (mips_linux_o32_sigframe_init): Remove comment.
  80
  81 2018-05-25  Pedro Alves  <palves@redhat.com>
  82
  83         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
  84         (struct readahead_cache, struct packet_reg, struct
  85         remote_arch_state, class remote_state): Move higher up in the
  86         file.
  87         (remote_target::m_remote_state): Now an object instead of a pointer.
  88         (remote_target::get_remote_state): Adjust.
  89
  90 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
  91
  92         * stack.c (select_and_print_frame): Delete.
  93         (struct function_bounds): Move struct within function.
  94         (func_command): Most content moved into new function
  95         find_frame_for_function, use new function, print result, add
  96         function comment.
  97         (find_frame_for_function): New function, now returns a result.
  98
  99 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 100
 101         * stack.c (iterate_over_block_arg_vars): Fix comment.
 102         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
 103
 104 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 105
 106         PR gdb/23203
 107         * frame.c
 108         (scoped_restore_selected_frame::scoped_restore_selected_frame):
 109         Define.
 110         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
 111         Define.
 112         * frame.h (class scoped_restore_selected_frame): New class.
 113         * stack.c (print_frame_local_vars): Remove catching and rethrowing
 114         of any exception, use scoped_restore_selected_frame to restore the
 115         frame instead.
 116
 117 2018-05-24  Pedro Alves  <palves@redhat.com>
 118
 119         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
 120         override.
 121
 122 2018-05-23  Tom Tromey  <tom@tromey.com>
 123
 124         * complaints.c (struct complaints): Remove.
 125         (symfile_complaint_book): Remove.
 126         (series): New global.
 127         (complaint_internal): Update.
 128         (clear_complaints): Update.
 129
 130 2018-05-23  Tom Tromey  <tom@tromey.com>
 131
 132         * complaints.c (counters): New global.
 133         (struct complain): Remove.
 134         (struct complaints) <root>: Remove.
 135         (complaint_sentinel): Remove.
 136         (symfile_complaint_book): Update.
 137         (find_complaint) Remove.
 138         (complaint_internal, clear_complaints): Update.
 139
 140 2018-05-23  Tom Tromey  <tom@tromey.com>
 141
 142         * complaints.c (struct complain) <file, line>: Remove.
 143         (find_complaint): Remove file, line parameters.
 144         (complaint_internal): Update.
 145
 146 2018-05-23  Tom Tromey  <tom@tromey.com>
 147
 148         * complaints.c (vcomplaint): Remove.
 149         (complaint_internal) Merge in contents of vcomplaint.
 150
 151 2018-05-23  Tom Tromey  <tom@tromey.com>
 152
 153         * complaints.c (struct complaints) <explanation>: Remove.
 154         (symfile_explanations): Remove.
 155         (symfile_complaint_book): Update.
 156         (vcomplaint): Update.
 157         (struct explanation): Remove.
 158
 159 2018-05-23  Tom Tromey  <tom@tromey.com>
 160
 161         * complaints.c (symfile_complaints): Remove.
 162         (complaint_internal): Remove "complaints" parameter.
 163         (clear_complaints, vcomplaint): Remove "c" parameter.
 164         (get_complaints): Remove.
 165         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
 166         (dwarf2_debug_line_missing_file_complaint)
 167         (dwarf2_debug_line_missing_end_sequence_complaint)
 168         (dwarf2_complex_location_expr_complaint)
 169         (dwarf2_const_value_length_mismatch_complaint)
 170         (dwarf2_section_buffer_overflow_complaint)
 171         (dwarf2_macro_malformed_definition_complaint)
 172         (dwarf2_invalid_attrib_class_complaint)
 173         (create_addrmap_from_index, dw2_symtab_iter_next)
 174         (dw2_expand_marked_cus)
 175         (dw2_debug_names_iterator::find_vec_in_debug_names)
 176         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
 177         (create_debug_type_hash_table, init_cutu_and_read_dies)
 178         (partial_die_parent_scope, add_partial_enumeration)
 179         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
 180         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
 181         (read_import_statement, read_file_scope, create_dwo_cu_reader)
 182         (create_cus_hash_table, create_dwp_hash_table)
 183         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
 184         (dwarf2_rnglists_process, dwarf2_ranges_process)
 185         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
 186         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
 187         (handle_struct_member_die, process_structure_scope)
 188         (read_array_type, read_common_block, read_module_type)
 189         (read_tag_pointer_type, read_typedef, read_base_type)
 190         (read_subrange_type, load_partial_dies, partial_die_info::read)
 191         (partial_die_info::read, partial_die_info::read)
 192         (partial_die_info::read, read_checked_initial_length_and_offset)
 193         (dwarf2_string_attr, read_formatted_entries)
 194         (dwarf_decode_line_header)
 195         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
 196         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
 197         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
 198         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
 199         (get_signatured_type, get_DW_AT_signature_type)
 200         (decode_locdesc, file_file_name, consume_improper_spaces)
 201         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
 202         (dwarf_decode_macro_bytes, dwarf_decode_macros)
 203         (dwarf2_symbol_mark_computed, set_die_type)
 204         (read_attribute_value): Update.
 205         * stap-probe.c (handle_stap_probe, get_stap_base_address):
 206         Update.
 207         * dbxread.c (unknown_symtype_complaint)
 208         (lbrac_mismatch_complaint, repeated_header_complaint)
 209         (set_namestring, function_outside_compilation_unit_complaint)
 210         (read_dbx_symtab, process_one_symbol): Update.
 211         * gdbtypes.c (stub_noname_complaint): Update.
 212         * windows-nat.c (handle_unload_dll): Update.
 213         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
 214         (decode_base_type): Update.
 215         * xcoffread.c (bf_notfound_complaint, ef_complaint)
 216         (eb_complaint, record_include_begin, record_include_end)
 217         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
 218         (process_xcoff_symbol, read_symbol)
 219         (function_outside_compilation_unit_complaint)
 220         (scan_xcoff_symtab): Update.
 221         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
 222         * buildsym.c (finish_block_internal, make_blockvector)
 223         (end_symtab_get_static_block, augment_type_symtab): Update.
 224         * dtrace-probe.c (dtrace_process_dof)
 225         (dtrace_static_probe_ops::get_probes): Update.
 226         * complaints.h (struct complaint): Don't declare.
 227         (symfile_complaints): Remove.
 228         (complaint_internal): Remove "complaints" parameter.
 229         (complaint): Likewise.
 230         (clear_complaints): Likewise.
 231         * symfile.c (syms_from_objfile_1, finish_new_objfile)
 232         (reread_symbols): Update.
 233         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
 234         (dwarf2_frame_cache, decode_frame_entry): Update.
 235         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
 236         * objc-lang.c (lookup_objc_class, lookup_child_selector)
 237         (info_selectors_command): Update.
 238         * macrotab.c (macro_include, check_for_redefinition)
 239         (macro_undef): Update.
 240         * objfiles.c (filter_overlapping_sections): Update.
 241         * stabsread.c (invalid_cpp_abbrev_complaint)
 242         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
 243         (define_symbol, error_type, read_type, rs6000_builtin_type)
 244         (stabs_method_name_from_physname, read_member_functions)
 245         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
 246         (attach_fields_to_type, complain_about_struct_wipeout)
 247         (read_range_type, read_args, common_block_start)
 248         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
 249         Update.
 250         * mdebugread.c (index_complaint, unknown_ext_complaint)
 251         (basic_type_complaint, bad_tag_guess_complaint)
 252         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
 253         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
 254         (parse_procedure, parse_lines)
 255         (function_outside_compilation_unit_complaint)
 256         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
 257         (bad_tag_guess_complaint, reg_value_complaint): Update.
 258         * cp-support.c (demangled_name_complaint): Update.
 259         * macroscope.c (sal_macro_scope): Update.
 260         * dwarf-index-write.c (class debug_names): Update.
 261
 262 2018-05-23  Tom Tromey  <tom@tromey.com>
 263
 264         * complaints.c (clear_complaints): Remove "noisy" parameter.
 265         * complaints.h (clear_complaints): Update.
 266         * symfile.c (syms_from_objfile_1, finish_new_objfile)
 267         (reread_symbols): Update.
 268
 269 2018-05-23  Tom Tromey  <tom@tromey.com>
 270
 271         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
 272         SUBSEQUENT_MESSAGE.
 273         (vcomplaint, clear_complaints): Update.
 274         (symfile_explanations): Remove some messages.
 275
 276 2018-05-23  Tom Tromey  <tom@tromey.com>
 277
 278         * complaints.c (internal_complaint): Remove.
 279         * complaints.h (internal_complaint): Remove.
 280
 281 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
 282
 283         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
 284
 285 2018-05-22  Pedro Alves  <palves@redhat.com>
 286
 287         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
 288         (remote_fileio_badfd, remote_fileio_return_errno)
 289         (remote_fileio_return_success, remote_fileio_func_open)
 290         (remote_fileio_func_open, remote_fileio_func_close)
 291         (remote_fileio_func_read, remote_fileio_func_write)
 292         (remote_fileio_func_lseek, remote_fileio_func_rename)
 293         (remote_fileio_func_unlink, remote_fileio_func_stat)
 294         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
 295         (remote_fileio_func_isatty, remote_fileio_func_system): Add
 296         remote_target parameter.
 297         (remote_fio_func_map) <func>: Add remote_target parameter.
 298         (do_remote_fileio_request, remote_fileio_request):
 299         * remote-fileio.h (remote_fileio_request):
 300         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
 301         remote_target parameter.
 302         (remote_notif_process, handle_notification): Adjust to pass down
 303         the remote.
 304         (remote_notif_state_allocate): Add remote_target parameter.  Save
 305         it.
 306         * remote-notif.h (struct remote_target): Forward declare.
 307         (struct notif_client) <parse, ack, can_get_pending_events>: Add
 308         remote_target parameter.
 309         (struct remote_notif_state) <remote>: New field.
 310         (remote_notif_ack, remote_notif_parse): Add remote_target
 311         parameter.
 312         (remote_notif_state_allocate, remote_notif_state_allocate): Add
 313         remote_target parameter.
 314         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
 315         (threads_listing_context, rmt_thread_action, protocol_feature)
 316         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
 317         (packet_result, struct threads_listing_context, remote_state):
 318         Move definitions and declarations higher up.
 319         (remote_target) <~remote_target>: Declare.
 320         (remote_download_command_source, remote_file_put, remote_file_get)
 321         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
 322         (remote_hostio_pread_vFile, remote_hostio_send_command)
 323         (remote_hostio_set_filesystem, remote_hostio_open)
 324         (remote_hostio_close, remote_hostio_unlink, remote_state)
 325         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
 326         (get_memory_write_packet_size, get_memory_read_packet_size)
 327         (append_pending_thread_resumptions, remote_detach_1)
 328         (append_resumption, remote_resume_with_vcont)
 329         (add_current_inferior_and_thread, wait_ns, wait_as)
 330         (process_stop_reply, remote_notice_new_inferior)
 331         (process_initial_stop_replies, remote_add_thread)
 332         (btrace_sync_conf, remote_btrace_maybe_reopen)
 333         (remove_new_fork_children, kill_new_fork_children)
 334         (discard_pending_stop_replies, stop_reply_queue_length)
 335         (check_pending_events_prevent_wildcard_vcont)
 336         (discard_pending_stop_replies_in_queue, stop_reply)
 337         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
 338         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
 339         (remote_interrupt_as, remote_interrupt_ns)
 340         (remote_get_noisy_reply, remote_query_attached)
 341         (remote_add_inferior, remote_current_thread, get_current_thread)
 342         (set_thread, set_general_thread, set_continue_thread)
 343         (set_general_process, write_ptid)
 344         (remote_unpack_thread_info_response, remote_get_threadinfo)
 345         (parse_threadlist_response, remote_get_threadlist)
 346         (remote_threadlist_iterator, remote_get_threads_with_ql)
 347         (remote_get_threads_with_qxfer)
 348         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
 349         (get_offsets, remote_check_symbols, remote_supported_packet)
 350         (remote_query_supported, remote_packet_size)
 351         (remote_serial_quit_handler, remote_detach_pid)
 352         (remote_vcont_probe, remote_resume_with_hc)
 353         (send_interrupt_sequence, interrupt_query)
 354         (remote_notif_get_pending_events, fetch_register_using_p)
 355         (send_g_packet, process_g_packet, fetch_registers_using_g)
 356         (store_register_using_P, store_registers_using_G)
 357         (set_remote_traceframe, check_binary_download)
 358         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
 359         (remote_xfer_live_readonly_partial, remote_read_bytes)
 360         (remote_send_printf, remote_flash_write, readchar)
 361         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
 362         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
 363         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
 364         (extended_remote_disable_randomization, extended_remote_run)
 365         (send_environment_packet, extended_remote_environment_support)
 366         (extended_remote_set_inferior_cwd, remote_write_qxfer)
 367         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
 368         (packet_command): Now methods of ...
 369         (remote_target): ... this class.
 370         (m_remote_state) <remote_target>: New field.
 371         (struct remote_state) <stop_reply_queue,
 372         remote_async_inferior_event_token, wait_forever_enabled_p>: New
 373         fields.
 374         (remote_state::remote_state): Allocate stop_reply_queue.
 375         (remote_state): Delete global.
 376         (get_remote_state_raw): Delete.
 377         (remote_target::get_remote_state): Allocate m_remote_state on
 378         demand.
 379         (get_current_remote_target): New.
 380         (remote_ops, extended_remote_ops): Delete.
 381         (wait_forever_enabled_p, remote_async_inferior_event_token):
 382         Delete, moved to struct remote_state.
 383         (remote_target::close): Delete self.  Destruction bits split to
 384         ...
 385         (remote_target::~remote_target): ... this.
 386         (show_memory_packet_size): Adjust to use
 387         get_current_remote_target.
 388         (struct protocol_feature) <func>: Add remote_target parameter.
 389         All callers adjusted.
 390         (curr_quit_handler_target): New.
 391         (remote_serial_quit_handler): Reimplement.
 392         (remote_target::open_1): Adjust to use get_current_remote_target.
 393         Heap-allocate remote_target/extended_remote_target instances.
 394         (vcont_builder::vcont_builder): Add remote_target parameter, and
 395         save it in m_remote.  All callers adjusted.
 396         (vcont_builder::m_remote): New field.
 397         (vcont_builder::restart, vcont_builder::flush)
 398         (vcont_builder::push_action): Use it.
 399         (remote_target::commit_resume): Use it.
 400         (struct queue_iter_param) <remote>: New field.
 401         (remote_target::remove_new_fork_children): Fill in 'remote' field.
 402         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
 403         (check_pending_event_prevents_wildcard_vcont_callback)
 404         (remote_target::check_pending_events_prevent_wildcard_vcont)
 405         (remote_target::discard_pending_stop_replies)
 406         (remote_target::discard_pending_stop_replies_in_queue)
 407         (remote_target::remote_notif_remove_queued_reply): Fill in
 408         'remote' field.
 409         (remote_notif_get_pending_events): New.
 410         (remote_target::readchar, remote_target::remote_serial_write):
 411         Save/restore curr_quit_handler_target.
 412         (putpkt): New.
 413         (kill_new_fork_children): Fill in 'remote' field.
 414         (packet_command): Use get_current_remote_target, defer to
 415         remote_target method of same name.
 416         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
 417         parameter, and save it in m_remote.  All callers adjusted.
 418         (scoped_remote_fd::release): Use m_remote.
 419         (scoped_remote_fd::m_remote): New field.
 420         (remote_file_put, remote_file_get, remote_file_delete): Use
 421         get_current_remote_target, defer to remote_target method of same
 422         name.
 423         (remote_btrace_reset): Add remote_state paremeter.  Update all
 424         callers.
 425         (remote_async_inferior_event_handler). Pass down 'data'.
 426         (remote_new_objfile): Use get_current_remote_target.
 427         (remote_target::vcont_r_supported): New.
 428         (set_range_stepping): Use get_current_remote_target and
 429         remote_target::vcont_r_supported.
 430         (_initialize_remote): Don't allocate 'remote_state' and
 431         'stop_reply_queue' globals.
 432         * remote.h (struct remote_target): Forward declare.
 433         (getpkt, putpkt, remote_notif_get_pending_events): Add
 434         'remote_target' parameter.
 435
 436 2018-05-22  Pedro Alves  <palves@redhat.com>
 437
 438         * remote.c (vcont_builder): Now a class.  Make all data members
 439         private.
 440         (vcont_builder) <vcont_builder, restart, flush, push_action>:
 441         Declare methods.
 442         (vcont_builder_restart): Rename to ...
 443         (vcont_builder::restart): ... this.
 444         (vcont_builder_flush): Rename to ...
 445         (vcont_builder::flush): ... this.
 446         (vcont_builder_push_action): Rename to ...
 447         (vcont_builder::push_action): ... this.
 448         (remote_target::commit_resume): Adjust.
 449
 450 2018-05-22  Pedro Alves  <palves@redhat.com>
 451
 452         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
 453         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
 454         (get_fixed_memory_packet_size): New.
 455         (get_memory_packet_size): Use it.
 456         (set_memory_packet_size): Don't override the config size with
 457         DEFAULT_MAX_MEMORY_PACKET_SIZE.
 458         (show_memory_packet_size): Use get_fixed_memory_packet_size.
 459         Don't refer to get_memory_packet_size if not connected to a remote
 460         target.  Show "(default)" if configured size is 0.
 461
 462 2018-05-22  Pedro Alves  <palves@redhat.com>
 463
 464         * remote.c (remote_target::mourn_inferior): Move
 465         discard_pending_stop_replies call here from ...
 466         (_initialize_remote): ... here.
 467
 468 2018-05-22  Pedro Alves  <palves@redhat.com>
 469
 470         * remote.c (compare_section_command): Remove set_general_process
 471         call.
 472
 473 2018-05-22  Pedro Alves  <palves@redhat.com>
 474
 475         * remote.c (struct packet_reg, struct remote_arch_state):
 476         Move higher up in the file.
 477         (remote_state) <m_arch_states>: Store remote_arch_state values
 478         instead of remote_arch_state pointers.
 479         (remote_state::get_remote_arch_state): Adjust.
 480
 481 2018-05-22  Pedro Alves  <palves@redhat.com>
 482
 483         * remote.c: Include <unordered_map>.
 484         (remote_state): Now a class.
 485         (remote_state) <get_remote_arch_state>: Declare method.
 486         <get_remote_arch_state>: New field.
 487         (remote_arch_state) <remote_arch_state>: Declare ctor.
 488         <regs>: Now a unique_ptr.
 489         (remote_gdbarch_data_handle): Delete.
 490         (get_remote_arch_state): Delete.
 491         (remote_state::get_remote_arch_state): New.
 492         (get_remote_state): Adjust to call remote_state's
 493         get_remote_arch_state method.
 494         (init_remote_state): Delete, bits factored out to ...
 495         (remote_arch_state::remote_arch_state): ... this new method.
 496         (get_remote_packet_size, get_memory_packet_size)
 497         (process_g_packet, remote_target::fetch_registers)
 498         (remote_target::prepare_to_store, store_registers_using_G)
 499         (remote_target::store_registers, remote_target::get_trace_status):
 500         Adjust to call remote_state's method.
 501         (_initialize_remote): Remove reference to
 502         remote_gdbarch_data_handle.
 503
 504 2018-05-22  Pedro Alves  <palves@redhat.com>
 505
 506         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
 507         pread>: New method declarations.
 508         (remote_target::open_1): Adjust.
 509         (readahead_cache_invalidate): Rename to ...
 510         (readahead_cache::invalidate): ... this, and adjust to be a class
 511         method.
 512         (readahead_cache_invalidate_fd): Rename to ...
 513         (readahead_cache::invalidate_fd): ... this, and adjust to be a
 514         class method.
 515         (remote_hostio_pwrite): Adjust.
 516         (remote_hostio_pread_from_cache): Rename to ...
 517         (readahead_cache::pread): ... this, and adjust to be a class
 518         method.
 519         (remote_hostio_close): Adjust.
 520
 521 2018-05-22  Pedro Alves  <palves@redhat.com>
 522
 523         * remote.c (remote_hostio_close_cleanup): Delete.
 524         (class scoped_remote_fd): New.
 525         (remote_file_put, remote_file_get): Use it.
 526
 527 2018-05-22  Pedro Alves  <palves@redhat.com>
 528
 529         (struct vCont_action_support): Use bool and initialize all fields.
 530         (struct readahead_cache): Initialize all fields.
 531         (remote_state): Use bool and initialize all fields.
 532         (remote_state::remote_state, remote_state::~remote_state): New.
 533         (new_remote_state): Delete.
 534         (_initialize_remote): Use new to allocate remote_state.
 535
 536 2018-05-22  Pedro Alves  <palves@redhat.com>
 537             張俊芝  <zjz@zjz.name>
 538
 539         PR gdb/22973
 540         * c-exp.y: Include "c-support.h".
 541         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
 542         of tolower.  Use c_ident_is_alpha to scan names.
 543         * c-lang.c: Include "c-support.h".
 544         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
 545         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
 546         * c-support.h: New file, with bits factored out from ...
 547         * cp-name-parser.y: ... this file.
 548         Include "c-support.h".
 549         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
 550         c-support.h and renamed.
 551         (symbol_end, yylex): Adjust.
 552
 553 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 554
 555         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
 556         parameter type to CORE_ADDR.
 557         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
 558         parameter type in declaration to CORE_ADDR.
 559         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
 560         target_auxv_search to get AT_HWCAP and use the result to get the
 561         target description.
 562         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
 563         to CORE_ADDR. Remove the cast of the return value to unsigned
 564         long. Fix error predicate of target_auxv_search.
 565         (ppc_linux_nat_target::read_description): Change the type of the
 566         hwcap variable to CORE_ADDR.
 567
 568 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 569
 570         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
 571         if the size of fpscr is larger than 32 bits.
 572
 573 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 574
 575         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
 576         (ppc32_linux_vsxregmap): New global.
 577         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
 578         regcache_supply_regset, and regcache_collect_regset.
 579         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
 580         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
 581         (fetch_vsx_register, store_vsx_register): Remove.
 582         (fetch_vsx_registers): Add regno parameter. Get regset using
 583         ppc_linux_vsxregset. Use regset to supply registers.
 584         (store_vsx_registers): Add regno parameter. Get regset using
 585         ppc_linux_vsxregset. Use regset to collect registers.
 586         (fetch_register): Call fetch_vsx_registers instead of
 587         fetch_vsx_register.
 588         (store_register): Call store_vsx_registers instead of
 589         store_vsx_register.
 590         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
 591         new regno parameter.
 592         (store_ppc_registers): Call store_vsx_registers with -1 for the
 593         new regno parameter.
 594         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
 595         (ppc_collect_vsxregset): Remove.
 596
 597 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 598
 599         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
 600         offset fields.
 601         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
 602         for vector register offset fields.
 603         (ppc64_fbsd_reg_offsets): Likewise.
 604         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
 605         to vector register offset fields.
 606         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
 607         to vector register offset fields.
 608         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
 609         vector register offset fields.
 610         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
 611         initializers for vector register offset fields.
 612         (rs6000_aix64_reg_offsets): Likewise.
 613         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
 614         (ppc_supply_vrregset): Remove.
 615         (ppc_collect_vrregset): Remove.
 616         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
 617         (ppc_linux_vrregset) : New function.
 618         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
 619         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
 620         (ppc32_linux_vrregset): Remove.
 621         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
 622         and use result instead of ppc32_linux_vrregset.
 623         (ppc32_linux_reg_offsets): Remove initializers for vector register
 624         offset fields.
 625         (ppc64_linux_reg_offsets): Likewise.
 626         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
 627         * ppc-linux-nat.c: Include regset.h.
 628         (gdb_vrregset_t): Adjust comment to account for little-endian
 629         mode.
 630         (supply_vrregset, fill_vrregset): Remove.
 631         (fetch_altivec_register, store_altivec_register): Remove.
 632         (fetch_altivec_registers): Add regno parameter. Get regset using
 633         ppc_linux_vrregset. Use regset to supply registers.
 634         (store_altivec_registers): Add regno parameter. Get regset using
 635         ppc_linux_vrregset. Use regset to collect registers.
 636         (fetch_register): Call fetch_altivec_registers instead of
 637         fetch_altivec_register.
 638         (store_register): Call store_altivec_registers instead of
 639         store_altivec_register.
 640         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
 641         the new regno parameter.
 642         (store_ppc_registers): Call store_altivec_registers with -1 for
 643         the new regno parameter.
 644
 645 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 646
 647         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
 648         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
 649         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
 650         (gdb_vrregset_t): Change array type size to
 651         PPC_LINUX_SIZEOF_VRREGSET.
 652         (gdb_vsxregset_t): Change array type size to
 653         PPC_LINUX_SIZEOF_VSXREGSET.
 654         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
 655         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
 656         PPC_LINUX_SIZEOF_VSXREGSET.
 657
 658 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 659
 660         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
 661         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
 662         nat/ppc-linux.c.
 663         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
 664         ppc_linux_target_wordsize with tid.
 665         (ppc_linux_nat_target::read_description): Call ppc_linux_target
 666         wordsize with tid.
 667         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
 668         (ppc64_64bit_inferior_p): Add static and inline specifiers.
 669         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
 670         tid parameter. Remove static specifier.
 671         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
 672         (ppc_linux_target_wordsize): New declaration.
 673
 674 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 675
 676         * arch/ppc-linux-common.c: New file.
 677         * arch/ppc-linux-common.h: New file.
 678         * arch/ppc-linux-tdesc.h: New file.
 679         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
 680         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
 681         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
 682         arch/ppc-linux-tdesc.h.
 683         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
 684         arch/ppc-linux-tdesc.h.
 685         (ppc_linux_nat_target::read_description): Remove target
 686         description matching code. Fill a ppc_linux_features struct and
 687         call ppc_linux_match_description with it. Move comment about ISA
 688         2.05 to ppc-linux-common.c.
 689         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
 690         arch/ppc-linux-tdesc.h.
 691         (ppc_linux_core_read_description): Remove target description
 692         matching code. Fill a ppc_linux_features struct and call
 693         ppc_linux_match_description with it.
 694         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
 695         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
 696         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
 697         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
 698         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
 699         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
 700         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
 701         (tdesc_powerpc_e500l): Remove.
 702
 703 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
 704
 705         * ada-lang.c (catch_assert_command): Pass empty string instead
 706         of NULL for excep_string argument.
 707
 708 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
 709
 710         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
 711         the width of the requested register exceeds the width of the
 712         `ptrace' data type.
 713
 714 2018-05-21  Tom Tromey  <tom@tromey.com>
 715
 716         * printcmd.c (output_command): Remove.
 717         (output_command_const): Rename to output_command.
 718         * valprint.h (output_command): Rename from output_command_const.
 719         * tracepoint.c (trace_dump_actions): Call output_command.
 720
 721 2018-05-21  Tom Tromey  <tom@tromey.com>
 722
 723         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
 724         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
 725         * ada-lang.h (create_ada_exception_catchpoint): Update.
 726         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
 727         std::string.
 728         (create_excep_cond_exprs, ~ada_catchpoint)
 729         (should_stop_exception, print_one_exception)
 730         (print_mention_exception, print_recreate_exception): Update.
 731         (ada_get_next_arg): Remove.
 732         (catch_ada_exception_command_split): Use std::string.  Change type
 733         of "excep_string", "cond_string".
 734         (catch_ada_exception_command): Update.
 735         (create_ada_exception_catchpoint): Change type of excep_string.
 736         (ada_exception_sal): Remove excep_string parameter.
 737         (~ada_catchpoint): Remove.
 738
 739 2018-05-21  Tom Tromey  <tom@tromey.com>
 740
 741         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
 742         cleanup.
 743
 744 2018-05-21  Tom Tromey  <tom@tromey.com>
 745
 746         * ada-lang.c (ada_exception_message_1, ada_exception_message):
 747         Return unique_xmalloc_ptr.
 748         (print_it_exception): Update.
 749
 750 2018-05-21  Tom Tromey  <tom@tromey.com>
 751
 752         * tracepoint.c (trace_dump_actions): Use std::string.
 753
 754 2018-05-21  Tom Tromey  <tom@tromey.com>
 755
 756         * symfile.c (reread_symbols): Use std::string for original_name.
 757
 758 2018-05-21  Tom Tromey  <tom@tromey.com>
 759
 760         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
 761         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
 762         constructor.
 763
 764 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
 765
 766         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
 767         instance to...
 768         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
 769         * objfiles.c (get_objfile_bfd_data): Allocate
 770         objfile_per_bfd_storage with obstack_new when allocating on
 771         obstack.
 772
 773 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
 774
 775         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
 776         OBSTACK_ZALLOC.
 777         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
 778         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
 779         * mdebugread.c (mdebug_build_psymtabs): Likewise.
 780         (add_pending): Likewise.
 781         (parse_symbol): Likewise.
 782         (parse_partial_symbols): Likewise.
 783         (psymtab_to_symtab_1): Likewise.
 784         (new_psymtab): Likewise.
 785         (elfmdebug_build_psymtabs): Likewise.
 786         * minsyms.c (terminate_minimal_symbol_table): Likewise.
 787         * objfiles.c (get_objfile_bfd_data): Likewise.
 788         (objfile_register_static_link): Likewise.
 789         * psymtab.c (allocate_psymtab): Likewise.
 790         * stabsread.c (read_member_functions): Likewise.
 791         * xcoffread.c (xcoff_end_psymtab): Likewise.
 792
 793 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
 794
 795         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
 796         compiler supports std::is_trivially_constructible.
 797         * common/poison.h: Include obstack.h.
 798         (IsMallocable): Define to is_trivially_constructible if the
 799         compiler supports it, define to true_type otherwise.
 800         (xobnew): New.
 801         (XOBNEW): Redefine.
 802         (xobnewvec): New.
 803         (XOBNEWVEC): Redefine.
 804         * gdb_obstack.h (obstack_zalloc): New.
 805         (OBSTACK_ZALLOC): Redefine.
 806         (obstack_calloc): New.
 807         (OBSTACK_CALLOC): Redefine.
 808         (obstack_new): New.
 809         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
 810         (gdbarch_obstack): New declaration in gdbarch.h, definition in
 811         gdbarch.c.
 812         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
 813         obstack_calloc/obstack_zalloc.
 814         (gdbarch_obstack_zalloc): Remove.
 815         * target-descriptions.c (tdesc_data_init): Use obstack_new.
 816
 817 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 818
 819         * stack.c (backtrace_command_1): Remove useless variable int i.
 820
 821 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 822
 823         * stack.c (print_frame_info): Fix comment.
 824
 825 2018-05-18  Tom Tromey  <tom@tromey.com>
 826
 827         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
 828         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
 829         (~dwarf2_per_objfile): Update
 830         (dwarf2_get_dwz_file): Use new.
 831         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
 832         unique_ptr.
 833
 834 2018-05-18  Tom Tromey  <tom@tromey.com>
 835
 836         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
 837         unique_ptr.
 838         * dwarf2read.c (struct dwp_file): Add constructor and
 839         initializers.
 840         (open_and_init_dwp_file): Return a unique_ptr.
 841         (dwarf2_per_objfile, create_dwp_hash_table)
 842         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
 843         (lookup_dwo_unit_in_dwp): Update.
 844         (open_and_init_dwp_file, get_dwp_file): Update.
 845
 846 2018-05-18  Tom Tromey  <tom@tromey.com>
 847
 848         * dwarf2read.c (dwarf2_per_objfile): Update.
 849         (struct mapped_index): Add initializers.
 850         (dwarf2_read_index): Use new.
 851         (dw2_symtab_iter_init): Update.
 852         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
 853         unique_ptr.
 854
 855 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
 856
 857         * dwarf2read.c (mapped_index) <total_size>: Remove.
 858
 859 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
 860
 861         * unittests/format_pieces-selftests.c (test_format_specifier):
 862         Add ARI comments.
 863
 864 2018-05-18  Tom Tromey  <tom@tromey.com>
 865
 866         * c-typeprint.c (maybe_print_hole): New function.
 867         (c_print_type_struct_field_offset): Update.
 868         (c_type_print_base_struct_union): Call maybe_print_hole.
 869
 870 2018-05-17  Keith Seitz  <keiths@redhat.com>
 871
 872         * breakpoint.c (build_bpstat_chain): New function, moved from
 873         bpstat_stop_status.
 874         (bpstat_stop_status): Add optional parameter, `stop_chain'.
 875         If no stop chain is passed, call build_bpstat_chain to build it.
 876         * breakpoint.h (build_bpstat_chain): Declare.
 877         (bpstat_stop_status): Move documentation here from breakpoint.c.
 878         * infrun.c (handle_signal_stop): Before eliding inlined frames,
 879         build the stop chain and pass it to skip_inline_frames.
 880         Pass this stop chain to bpstat_stop_status.
 881         * inline-frame.c: Include breakpoint.h.
 882         (stopped_by_user_bp_inline_frame): New function.
 883         (skip_inline_frames): Add parameter `stop_chain'.
 884         Move documention to inline-frame.h.
 885         If non-NULL, use stopped_by_user_bp_inline_frame to determine
 886         whether the frame should be elided.
 887         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
 888         Add moved documentation and update for new parameter.
 889
 890 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
 891
 892         PR cli/14975
 893         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 894         unittests/format_pieces-selftests.c.
 895         * common/format.h (format_piece) <operator==>: New.
 896         (format_pieces) <operator[]>: Remove.
 897         * common/format.c (format_pieces::format_pieces): Handle \e.
 898         * unittests/format_pieces-selftests.c: New.
 899
 900 2018-05-17  Tom Tromey  <tom@tromey.com>
 901
 902         PR symtab/23010:
 903         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
 904         (dw2_instantiate_symtab): Add skip_partial parameter.
 905         (dw2_find_last_source_symtab, dw2_map_expand_apply)
 906         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
 907         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
 908         (dw2_expand_symtabs_matching_one)
 909         (dw2_find_pc_sect_compunit_symtab)
 910         (dw2_debug_names_lookup_symbol)
 911         (dw2_debug_names_expand_symtabs_for_function): Update.
 912         (init_cutu_and_read_dies): Add skip_partial parameter.
 913         (process_psymtab_comp_unit, build_type_psymtabs_1)
 914         (process_skeletonless_type_unit, load_partial_comp_unit)
 915         (psymtab_to_symtab_1): Update.
 916         (load_full_comp_unit): Add skip_partial parameter.
 917         (process_imported_unit_die, dwarf2_read_addr_index)
 918         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
 919         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
 920         (read_signatured_type): Update.
 921
 922 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
 923
 924         * value.c (release_value): Remove unused variable.
 925         (record_latest_value): Likewise.
 926         (access_value_history): Likewise.
 927         (preserve_values): Likewise.
 928
 929 2018-05-17  Tom Tromey  <tom@tromey.com>
 930
 931         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
 932         Initialize.
 933
 934 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
 935
 936         PR gdb/22286
 937         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
 938         Also handle registers whose width is not a multiple of
 939         PTRACE_TYPE_RET.
 940         (linux_nat_trad_target::store_register): Likewise.
 941
 942 2018-05-16  Tom Tromey  <tom@tromey.com>
 943
 944         * gdbcore.h (core_bfd): Redefine.
 945         * corelow.c (core_target::close): Update.
 946         (core_target_open): Update.
 947         * progspace.h (struct program_space) <cbfd>: Now a
 948         gdb_bfd_ref_ptr.
 949
 950 2018-05-16  Tom Tromey  <tom@tromey.com>
 951
 952         PR cli/19551:
 953         * symfile-add-flags.h (enum symfile_add_flags)
 954         <SYMFILE_NOT_FILENAME>: New constant.
 955         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
 956         objfile name from BFD.
 957         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
 958         * minidebug.c (find_separate_debug_file_in_section): Put
 959         ".gnu_debugdata" into BFD's file name.
 960
 961 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
 962
 963         * regcache.c (regcache_read_ftype, regcache_write_ftype):
 964         Remove.
 965
 966 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
 967
 968         PR binutils/21446
 969         * aarch64-tdep.c (aarch64_analyze_prologue,
 970         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
 971         Indicate not interested in errors.
 972
 973 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
 974
 975         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
 976         Supply the MIPS_ZERO_REGNUM register.
 977
 978 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
 979
 980         * mips-tdep.c (mask_address_var): Make variable static.
 981
 982 2018-05-14  Tom Tromey  <tom@tromey.com>
 983
 984         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
 985
 986 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 987
 988         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
 989         FXSAVE_ADDR for the mxcsr register.
 990
 991 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
 992
 993         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
 994
 995 2018-05-11  Pedro Alves  <palves@redhat.com>
 996
 997         * corelow.c (core_target) <core_target>: No longer inline.
 998         Initialize m_core_gdbarch, m_core_vec and build the section table
 999         here.
1000         <~core_target>: New.
1001         <core_gdbarch, get_core_register_section>: New methods.
1002         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
1003         factored out from ...
1004         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
1005         (core_ops): Delete.
1006         (sniff_core_bfd): Add gdbarch parameter.
1007         (core_close): Delete, merged into ...
1008         (core_target::close): ... here.  Delete self.
1009         (core_close_cleanup): Delete.
1010         (core_target_open): Allocate a core_target on the heap.  Use a
1011         unique_ptr instead of a cleanup.  Bits moved into the core_target
1012         ctor.  Adjust to use core_target methods instead of globals.
1013         (get_core_register_section): Rename to ...
1014         (core_target::get_core_register_section): ... this and adjust.
1015         (struct get_core_registers_cb_data): New.
1016         (get_core_registers_cb): Use it.  Use bool.
1017         (core_target::fetch_registers, core_target::files_info)
1018         (core_target::xfer_partial, core_target::read_description)
1019         (core_target::pid_to, core_target::thread_name): Adjust to
1020         reference class fields instead of globals.
1021         * target.h (struct target_ops_deleter, target_ops_up): New.
1022
1023 2018-05-11  Pedro Alves  <palves@redhat.com>
1024
1025         * corefile.c (core_file_command): Move to corelow.c.
1026         * corelow.c (the_core_target): Delete.
1027         (core_file_command): Moved from corefile.c.  Check exec_bfd
1028         instead of the_core_target.  Use target_detach instead of calling
1029         into the_core_target directly.
1030         (maybe_say_no_core_file_now): New.
1031         (core_target::detach): Use it.
1032         (_initialize_corelow): Remove references to the_core_target.
1033         * gdbcore.h (the_core_target): Delete.
1034
1035 2018-05-11  Tom Tromey  <tromey@redhat.com>
1036             Pedro Alves  <palves@redhat.com>
1037
1038         * corefile.c (core_bfd): Remove.
1039         * gdbcore.h (core_bfd): Now a macro.
1040         * progspace.h (struct program_space) <cbfd>: New field.
1041
1042 2018-05-11  Tom Tromey  <tom@tromey.com>
1043
1044         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
1045         gdb::def_vector.
1046
1047 2018-05-10  Tom Tromey  <tom@tromey.com>
1048
1049         * configure: Rebuild.
1050         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
1051
1052 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
1053
1054         PR server/23158:
1055         * regformats/regdat.sh: Adjust script, following the addition
1056         of the new expedite_regs parameter to init_target_desc.
1057
1058 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
1059
1060         PR gdb/23127
1061         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
1062         set_gdbarch_significant_addr_bit.
1063         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
1064         set_gdbarch_significant_addr_bit.
1065         * utils.c (address_significant): Update to sign extend addr.
1066
1067 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
1068
1069         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
1070         (xtensa_linux_init_abi): Limit tdep->num_regs by
1071         tdep->num_nopriv_regs.
1072         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
1073         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
1074         not initialized.
1075
1076 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
1077
1078         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
1079
1080 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1081
1082         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
1083         (I387_MXCSR_INIT_VAL): New constant.
1084         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
1085         buffer if it was supplied by the inferior.
1086         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
1087         (i387_xsave_get_clear_bv): New function.
1088         (i387_supply_xsave): Only read x87 control registers from the
1089         xsave buffer if the feature is enabled, and the state will have
1090         been written, otherwise, provide a suitable default.
1091         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
1092         including x87 control registers.  Update control registers if they
1093         have changed from the default value, and mark features as enabled
1094         as required.
1095         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
1096
1097 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
1098
1099         * spu-tdep.c (info_spu_event_command): Fix output formatting.
1100
1101 2018-05-07  Tom Tromey  <tom@tromey.com>
1102
1103         * configure: Rebuild.
1104         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
1105
1106 2018-05-07  Tom Tromey  <tom@tromey.com>
1107
1108         PR tdep/20362:
1109         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
1110         bit.  Use correct value for VDIV.
1111
1112 2018-05-04  Tom Tromey  <tom@tromey.com>
1113
1114         * configure: Rebuild.
1115         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
1116
1117 2018-05-04  Tom Tromey  <tom@tromey.com>
1118
1119         * linux-record.c (record_linux_system_call) <case
1120         RECORD_SYS_RECVFROM>: Add "break".
1121
1122 2018-05-04  Tom Tromey  <tom@tromey.com>
1123
1124         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
1125         Add missing "break".
1126         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
1127         Add missing "break".
1128
1129 2018-05-04  Tom Tromey  <tom@tromey.com>
1130
1131         * rs6000-tdep.c (ppc_process_record_op4)
1132         (ppc_process_record_op63): Add fall-through comment.
1133
1134 2018-05-04  Tom Tromey  <tom@tromey.com>
1135
1136         * i386-tdep.c (i386_process_record): Add fall-through comment.
1137
1138 2018-05-04  Tom Tromey  <tom@tromey.com>
1139
1140         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
1141         comment.
1142
1143 2018-05-04  Tom Tromey  <tom@tromey.com>
1144
1145         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
1146         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
1147         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
1148         comment.
1149         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
1150         comment.
1151         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
1152         comment.
1153
1154 2018-05-04  Tom Tromey  <tom@tromey.com>
1155
1156         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
1157
1158 2018-05-04  Tom Tromey  <tom@tromey.com>
1159
1160         * s390-tdep.c (s390_process_record): Fix fall-through comments.
1161         * xcoffread.c (scan_xcoff_symtab): Move comment later.
1162         * symfile.c (section_is_mapped): Fix fall-through comment.
1163         * stabsread.c (define_symbol, read_member_functions): Fix
1164         fall-through comment.
1165         * s390-linux-tdep.c (s390_process_record): Fix fall-through
1166         comment.
1167         * remote.c (remote_wait_as): Fix fall-through comment.
1168         * p-exp.y (yylex): Fix fall-through comment.
1169         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
1170         comment.
1171         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
1172         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
1173         * jv-exp.y (yylex): Fix fall-through comment.
1174         * go-exp.y (lex_one_token): Fix fall-through comment.
1175         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
1176         fall-through comment.
1177         * f-exp.y (yylex): Fix fall-through comment.
1178         * dwarf2read.c (process_die): Fix fall-through comments.
1179         * dbxread.c (process_one_symbol): Fix fall-through comment.
1180         * d-exp.y (lex_one_token): Fix fall-through comment.
1181         * cp-name-parser.y (yylex): Fix fall-through comment.
1182         * coffread.c (coff_symtab_read): Fix fall-through comment.
1183         * c-exp.y (lex_one_token): Fix fall-through comment.
1184         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
1185         comment.
1186         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
1187         comment.
1188
1189 2018-05-04  Tom Tromey  <tom@tromey.com>
1190
1191         PR python/22730:
1192         * NEWS: Mention gdb.execute change.
1193         * gdbcmd.h (execute_control_command): Don't declare.
1194         * python/python.c (execute_gdb_command): Use read_command_lines_1,
1195         execute_control_commands, execute_control_commands_to_string.
1196         * cli/cli-script.h (execute_control_commands)
1197         (execute_control_commands_to_string): Declare.
1198         (execute_control_command): Add from_tty parameter.
1199         * cli/cli-script.c (execute_control_commands)
1200         (execute_control_commands_to_string): New functions.
1201         (execute_user_command): Use execute_control_commands.
1202         (execute_control_command_1): Add "from_tty" parameter.  Update.
1203         (execute_control_command): Likewise.
1204
1205 2018-05-04  Tom Tromey  <tom@tromey.com>
1206
1207         PR python/22731:
1208         * NEWS: Mention that breakpoint commands are writable.
1209         * python/py-breakpoint.c (bppy_set_commands): New function.
1210         (breakpoint_object_getset) <"commands">: Use it.
1211
1212 2018-05-04  Tom Tromey  <tom@tromey.com>
1213
1214         * tracepoint.c (actions_command): Update.
1215         * mi/mi-cmd-break.c (mi_command_line_array)
1216         (mi_command_line_array_cnt, mi_command_line_array_ptr)
1217         (mi_read_next_line): Remove.
1218         (mi_cmd_break_commands): Update.
1219         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
1220         function_view.
1221         * cli/cli-script.c (get_command_line): Update.
1222         (process_next_line): Use function_view.  Constify.
1223         (recurse_read_control_structure, read_command_lines)
1224         (read_command_lines_1): Change argument types to function_view.
1225         (do_define_command, document_command): Update.
1226         * breakpoint.h (check_tracepoint_command): Don't declare.
1227         * breakpoint.c (check_tracepoint_command): Remove.
1228         (commands_command_1, create_tracepoint_from_upload): Update.
1229
1230 2018-05-04  Tom Tromey  <tom@tromey.com>
1231
1232         PR gdb/11750:
1233         * cli/cli-script.h (enum command_control_type) <define_control>:
1234         New constant.
1235         * cli/cli-script.c (multi_line_command_p): Handle define_control.
1236         (build_command_line, execute_control_command_1)
1237         (process_next_line): Likewise.
1238         (do_define_command): New function, extracted from define_command.
1239         (define_command): Use it.
1240
1241 2018-05-04  Tom Tromey  <tom@tromey.com>
1242
1243         * tracepoint.c (actions_command): Update.
1244         * cli/cli-script.h (read_command_lines): Update.
1245         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
1246         (MAX_TMPBUF): Remove define.
1247         (define_command): Use string_printf.
1248         (document_command): Likewise.
1249         * breakpoint.c (commands_command_1): Update.
1250
1251 2018-05-04  Tom Tromey  <tom@tromey.com>
1252
1253         * top.c (execute_command): Update.
1254         * cli/cli-script.h (print_command_lines): Now varargs.
1255         * cli/cli-script.c (print_command_lines): Now varargs.
1256         (execute_control_command_1) <case while_control, case if_control>:
1257         Update.
1258
1259 2018-05-04  Tom Tromey  <tom@tromey.com>
1260
1261         * tracepoint.c (all_tracepoint_actions): Rename from
1262         all_tracepoint_actions_and_cleanup.  Change return type.
1263         (actions_command, encode_actions_1, encode_actions)
1264         (trace_dump_actions, tdump_command): Update.
1265         * remote.c (remote_download_command_source): Update.
1266         * python/python.c (gdbpy_eval_from_control_command)
1267         (python_command, python_interactive_command): Update.
1268         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
1269         * guile/guile.c (guile_command)
1270         (gdbscm_eval_from_control_command, guile_command): Update.
1271         * compile/compile.c (compile_code_command)
1272         (compile_print_command, compile_to_object): Update.
1273         * cli/cli-script.h (struct command_lines_deleter): New.
1274         (counted_command_line): New typedef.
1275         (struct command_line): Add constructor, destructor.
1276         <body_list>: Remove.
1277         <body_list_0, body_list_1>: New members.
1278         (command_line_up): Remove typedef.
1279         (read_command_lines, read_command_lines_1, get_command_line):
1280         Update.
1281         (copy_command_lines): Don't declare.
1282         * cli/cli-script.c (build_command_line): Use "new".
1283         (get_command_line): Return counted_command_line.
1284         (print_command_lines, execute_user_command)
1285         (execute_control_command_1, while_command, if_command): Update.
1286         (realloc_body_list): Remove.
1287         (process_next_line, recurse_read_control_structure): Update.
1288         (read_command_lines, read_command_lines_1): Return counted_command_line.
1289         (free_command_lines): Use "delete".
1290         (copy_command_lines): Remove.
1291         (define_command, document_command, show_user_1): Update.
1292         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
1293         a counted_command_line.
1294         * breakpoint.h (counted_command_line): Remove typedef.
1295         (breakpoint_set_commands): Update.
1296         * breakpoint.c (check_no_tracepoint_commands)
1297         (validate_commands_for_breakpoint): Update.
1298         (breakpoint_set_commands): Change commands to be a
1299         counted_command_line.
1300         (commands_command_1, update_dprintf_command_list)
1301         (create_tracepoint_from_upload): Update.
1302
1303 2018-05-04  Tom Tromey  <tom@tromey.com>
1304
1305         * cli/cli-decode.h (cmd_list_element): New constructor.
1306         (~cmd_list_element): New destructor.
1307         (struct cmd_list_element): Add initializers.
1308         * cli/cli-decode.c (do_add_cmd): Use "new".
1309         (delete_cmd): Use "delete".
1310
1311 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
1312             Pedro Alves <palves@redhat.com>
1313
1314         PR breakpoints/19806 and support for PR external/20207.
1315         * NEWS: Mention Aarch64 watchpoint improvements.
1316         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
1317         watchpoints and PR external/20207 watchpoints.
1318         * nat/aarch64-linux-hw-point.c
1319         (kernel_supports_any_contiguous_range): New.
1320         (aarch64_watchpoint_offset): New.
1321         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
1322         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
1323         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
1324         (aarch64_align_watchpoint): New parameters aligned_offset_p and
1325         next_addr_orig_p.  Support PR external/20207 watchpoints.
1326         (aarch64_downgrade_regs): New.
1327         (aarch64_dr_state_insert_one_point): New parameters offset and
1328         addr_orig.
1329         (aarch64_dr_state_remove_one_point): Likewise.
1330         (aarch64_handle_breakpoint): Update caller.
1331         (aarch64_handle_aligned_watchpoint): Likewise.
1332         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
1333         aligned_offset.
1334         (aarch64_linux_set_debug_regs): Remove const from state.  Call
1335         aarch64_downgrade_regs.
1336         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
1337         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
1338         (DR_CONTROL_MASK): ... this.
1339         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
1340         (unsigned int aarch64_watchpoint_offset): New prototype.
1341         (aarch64_linux_set_debug_regs): Remove const from state.
1342         * utils.c (align_up, align_down): Move to ...
1343         * common/common-utils.c (align_up, align_down): ... here.
1344         * utils.h (align_up, align_down): Move to ...
1345         * common/common-utils.h (align_up, align_down): ... here.
1346
1347 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
1348
1349         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
1350         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
1351         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
1352         Re-implement to match the ABI as summarized in GCC's
1353         gcc/config/sparc/sparc.c.  All callers updated.
1354         (sparc32_store_arguments): Remove assertion.
1355
1356 2018-05-04  Tom Tromey  <tom@tromey.com>
1357
1358         * printcmd.c: Don't include tui.h.
1359         (decode_format): Use skip_spaces.
1360
1361 2018-05-04  Tom Tromey  <tom@tromey.com>
1362
1363         PR gdb/22619:
1364         * printcmd.c (last_count): New global.
1365         (x_command): Use saved count when repeating.
1366
1367 2018-05-04  Tom Tromey  <tom@tromey.com>
1368
1369         * nto-procfs.c (do_closedir_cleanup): Remove.
1370         (procfs_pidlist): Use gdb_dir_up.
1371         * procfs.c (do_closedir_cleanup): Remove.
1372         (proc_update_threads): Use gdb_dir_up.
1373         * common/filestuff.h (struct gdb_dir_deleter): New.
1374         (gdb_dir_up): New typedef.
1375
1376 2018-05-04  Tom Tromey  <tom@tromey.com>
1377
1378         * ada-lang.c (print_mention_exception): Use std::string.
1379
1380 2018-05-04  Tom Tromey  <tom@tromey.com>
1381
1382         * ada-lang.c (create_excep_cond_exprs): Update.
1383         (ada_exception_catchpoint_cond_string): Use std::string.
1384
1385 2018-05-04  Tom Tromey  <tom@tromey.com>
1386
1387         * ada-lang.c (xget_renaming_scope): Return std::string.
1388         (old_renaming_is_invisible): Update.
1389
1390 2018-05-04  Tom Tromey  <tom@tromey.com>
1391
1392         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
1393         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
1394
1395 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
1396
1397         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
1398
1399 2018-05-04  Tom Tromey  <tom@tromey.com>
1400
1401         * remote.c (remote_query_supported_append): Change type.
1402         (remote_check_symbols): Update.
1403
1404 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
1405
1406         PR gdb/11420
1407         * configure.ac: Prepend libpython.
1408         * python/python-config.py: Likewise.
1409         * configure: Regenerate.
1410
1411 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
1412
1413         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
1414
1415 2018-05-03  Pedro Alves  <palves@redhat.com>
1416
1417         * s390-linux-nat.c
1418         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
1419         override.  Write 'true' instead of '1'.
1420         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
1421         declaration.
1422
1423 2018-05-02  Pedro Alves  <palves@redhat.com>
1424
1425         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
1426         add_inf_child_target.
1427         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
1428         add_inf_child_target.
1429         * aix-thread.c (aix_thread_target_info): New.
1430         (aix_thread_target) <shortname, longname, doc>: Delete.
1431         <info>: New.
1432         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
1433         add_inf_child_target.
1434         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
1435         add_inf_child_target.
1436         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
1437         add_inf_child_target.
1438         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
1439         add_inf_child_target.
1440         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
1441         add_inf_child_target.
1442         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
1443         add_inf_child_target.
1444         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
1445         add_inf_child_target.
1446         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
1447         add_inf_child_target.
1448         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
1449         add_inf_child_target.
1450         * bfd-target.c (target_bfd_target_info): New.
1451         (target_bfd) <shortname, longname, doc>: Delete.
1452         <info>: New.
1453         * bsd-kvm.c (bsd_kvm_target_info): New.
1454         (bsd_kvm_target) <shortname, longname, doc>: Delete.
1455         <info>: New.
1456         (bsd_kvm_target::open): Rename to ...
1457         (bsd_kvm_target_open): ... this.  Adjust.
1458         * bsd-uthread.c (bsd_uthread_target_info): New.
1459         (bsd_uthread_target) <shortname, longname, doc>: Delete.
1460         <info>: New.
1461         * corefile.c (core_file_command): Adjust.
1462         * corelow.c (core_target_info): New.
1463         (core_target) <shortname, longname, doc>: Delete.
1464         <info>: New.
1465         (core_target::open): Rename to ...
1466         (core_target_open): ... this.  Adjust.
1467         * ctf.c (ctf_target_info): New.
1468         (ctf_target) <shortname, longname, doc>: Delete.
1469         <info>: New.
1470         (ctf_target::open): Rename to ...
1471         (ctf_target_open): ... this.
1472         (_initialize_ctf): Adjust.
1473         * exec.c (exec_target_info): New.
1474         (exec_target) <shortname, longname, doc>: Delete.
1475         <info>: New.
1476         (exec_target::open): Rename to ...
1477         (exec_target_open): ... this.
1478         * gdbcore.h (core_target_open): Declare.
1479         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
1480         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
1481         add_inf_child_target.
1482         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
1483         add_inf_child_target.
1484         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
1485         add_inf_child_target.
1486         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
1487         add_inf_child_target.
1488         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
1489         add_inf_child_target.
1490         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
1491         add_inf_child_target.
1492         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
1493         add_inf_child_target.
1494         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
1495         add_inf_child_target.
1496         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
1497         add_inf_child_target.
1498         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
1499         add_inf_child_target.
1500         * inf-child.c (inf_child_target_info): New.
1501         (inf_child_target::info): New.
1502         (inf_child_open_target): Remove 'target' parameter.  Use
1503         get_native_target instead.
1504         (inf_child_target::open): Delete.
1505         (add_inf_child_target): New.
1506         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
1507         Delete.
1508         <info>: New.
1509         (add_inf_child_target): Declare.
1510         (inf_child_open_target): Declare.
1511         * linux-thread-db.c (thread_db_target_info): New.
1512         (thread_db_target) <shortname, longname, doc>: Delete.
1513         <info>: New.
1514         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
1515         add_inf_child_target.
1516         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
1517         add_inf_child_target.
1518         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
1519         add_inf_child_target.
1520         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
1521         add_inf_child_target.
1522         * make-target-delegates (print_class): Adjust.
1523         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
1524         add_inf_child_target.
1525         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
1526         add_inf_child_target.
1527         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
1528         add_inf_child_target.
1529         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
1530         add_inf_child_target.
1531         * nto-procfs.c (nto_native_target_info): New.
1532         (nto_procfs_target_native) <shortname, longname, doc>:
1533         Delete.
1534         <info>: New.
1535         (nto_procfs_target_info): New.
1536         (nto_procfs_target_procfs) <shortname, longname, doc>:
1537         Delete.
1538         <info>: New.
1539         (init_procfs_targets): Adjust.
1540         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
1541         add_inf_child_target.
1542         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
1543         add_inf_child_target.
1544         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
1545         add_inf_child_target.
1546         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
1547         add_inf_child_target.
1548         * ravenscar-thread.c (ravenscar_target_info): New.
1549         (ravenscar_thread_target) <shortname, longname, doc>:
1550         Delete.
1551         <info>: New.
1552         * record-btrace.c (record_btrace_target_info):
1553         (record_btrace_target) <shortname, longname, doc>: Delete.
1554         <info>: New.
1555         (record_btrace_target::open): Rename to ...
1556         (record_btrace_target_open): ... this.  Adjust.
1557         * record-full.c (record_longname, record_doc): New.
1558         (record_full_base_target) <shortname, longname, doc>: Delete.
1559         <info>: New.
1560         (record_full_target_info): New.
1561         (record_full_target): <shortname>: Delete.
1562         <info>: New.
1563         (record_full_core_open_1, record_full_open_1): Update comments.
1564         (record_full_base_target::open): Rename to ...
1565         (record_full_open): ... this.
1566         (cmd_record_full_restore): Update.
1567         (_initialize_record_full): Update.
1568         * remote-sim.c (remote_sim_target_info): New.
1569         (gdbsim_target) <shortname, longname, doc>: Delete.
1570         <info>: New.
1571         (gdbsim_target::open): Rename to ...
1572         (gdbsim_target_open): ... this.
1573         (_initialize_remote_sim): Adjust.
1574         * remote.c (remote_doc): New.
1575         (remote_target_info): New.
1576         (remote_target) <shortname, longname, doc>: Delete.
1577         <info>: New.
1578         (extended_remote_target_info): New.
1579         (extended_remote_target) <shortname, longname, doc>: Delete.
1580         <info>: New.
1581         (remote_target::open_1): Make static.  Adjust.
1582         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
1583         * s390-linux-nat.c (_initialize_s390_nat): Use
1584         add_inf_child_target.
1585         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
1586         add_inf_child_target.
1587         * sol-thread.c (thread_db_target_info): New.
1588         (sol_thread_target) <shortname, longname, doc>: Delete.
1589         <info>: New.
1590         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
1591         add_inf_child_target.
1592         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
1593         add_inf_child_target.
1594         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
1595         add_inf_child_target.
1596         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
1597         add_inf_child_target.
1598         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
1599         add_inf_child_target.
1600         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
1601         add_inf_child_target.
1602         * spu-linux-nat.c (_initialize_spu_nat): Use
1603         add_inf_child_target.
1604         * spu-multiarch.c (spu_multiarch_target_info): New.
1605         (spu_multiarch_target) <shortname, longname, doc>: Delete.
1606         <info>: New.
1607         * target-delegates.c: Regenerate.
1608         * target.c: Include <unordered_map>.
1609         (target_ops_p): Delete.
1610         (DEF_VEC_P(target_ops_p)): Delete.
1611         (target_factories): New.
1612         (test_target_info): New.
1613         (test_target_ops::info): New.
1614         (open_target): Adjust to use target_factories.
1615         (add_target_with_completer): Rename to ...
1616         (add_target): ... this.  Change prototype.  Register target_info
1617         and open callback in target_factories.  Register target_info in
1618         command context instead of target_ops.
1619         (add_target): Delete old implementation.
1620         (add_deprecated_target_alias): Change prototype.  Adjust.
1621         (the_native_target): New.
1622         (set_native_target, get_native_target): New.
1623         (find_default_run_target): Use the_native_target.
1624         (find_attach_target, find_run_target): Simplify.
1625         (target_ops::open): Delete.
1626         (dummy_target_info): New.
1627         (dummy_target::shortname, dummy_target::longname)
1628         (dummy_target::doc): Delete.
1629         (dummy_target::info): New.
1630         (debug_target::shortname, debug_target::longname)
1631         (debug_target::doc): Delete.
1632         (debug_target::info): New.
1633         * target.h (struct target_info): New.
1634         (target_ops::~target_ops): Add comment.
1635         (target_ops::info): New.
1636         (target_ops::shortname, target_ops::longname, target_ops::doc): No
1637         longer virtual.  Implement in terms of target_info.
1638         (set_native_target, get_native_target): Declare.
1639         (target_open_ftype): New.
1640         (add_target, add_target_with_completer)
1641         (add_deprecated_target_alias): Change prototype.
1642         (test_target) <shortname, longname, doc>: Delete.
1643         <info>: New.
1644         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
1645         add_inf_child_target.
1646         * tracefile-tfile.c (tfile_target_info): New.
1647         (tfile_target) <shortname, longname, doc>: Delete.
1648         <info>: New.
1649         (tfile_target::open): Rename to ...
1650         (tfile_target_open): ... this.
1651         (_initialize_tracefile_tfile): Adjust.
1652         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
1653         add_inf_child_target.
1654         * windows-nat.c (_initialize_windows_nat): Use
1655         add_inf_child_target.
1656         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
1657         add_inf_child_target.
1658
1659 2018-05-02  Pedro Alves  <palves@redhat.com>
1660
1661         * linux-nat.h (linux_nat_target) <low_new_thread,
1662         low_delete_thread, low_new_fork, low_forget_process,
1663         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
1664         New virtual methods.
1665         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1666         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
1667         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
1668         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1669         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
1670         Delete.
1671         * linux-fork.c (delete_fork): Adjust to call low method.
1672         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
1673         (linux_nat_new_fork, linux_nat_forget_process_hook)
1674         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
1675         (linux_nat_status_is_event):
1676         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
1677         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
1678         to call low method.
1679         (sigtrap_is_event): Rename to ...
1680         (linux_nat_target::low_status_is_event): ... this.
1681         (linux_nat_set_status_is_event): Delete.
1682         (save_stop_reason, linux_nat_wait_1)
1683         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
1684         low methods.
1685         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1686         (linux_nat_set_new_fork, linux_nat_set_forget_process)
1687         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1688         (linux_nat_set_prepare_to_resume): Delete.
1689         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
1690         low virtual methods.
1691         * amd64-linux-nat.c: Likewise.
1692         * arm-linux-nat.c: Likewise.
1693         * i386-linux-nat.c: Likewise.
1694         * ia64-linux-nat.c: Likewise.
1695         * mips-linux-nat.c: Likewise.
1696         * ppc-linux-nat.c: Likewise.
1697         * s390-linux-nat.c: Likewise.
1698         * sparc64-linux-nat.c: Likewise.
1699         * x86-linux-nat.c: Likewise.
1700         * x86-linux-nat.h: Include "nat/x86-linux.h".
1701         (x86_linux_nat_target) <low_new_fork, low_forget_process,
1702         low_prepare_to_resume, low_new_thread, low_delete_thread>:
1703         Override methods.
1704
1705 2018-05-02  Pedro Alves  <palves@redhat.com>
1706
1707         * target.h (target_ops)
1708         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
1709         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
1710         stopped_by_watchpoint, have_continuable_watchpoint,
1711         stopped_data_address, watchpoint_addr_within_range,
1712         can_accel_watchpoint_condition, can_run, thread_alive,
1713         has_all_memory, has_memory, has_stack, has_registers,
1714         has_execution, can_async_p, is_async_p, supports_non_stop,
1715         always_non_stop_p, can_execute_reverse, supports_multi_process,
1716         supports_enable_disable_tracepoint,
1717         supports_disable_randomization, supports_string_tracing,
1718         supports_evaluation_of_breakpoint_conditions,
1719         can_run_breakpoint_commands, filesystem_is_local,
1720         can_download_tracepoint, get_trace_state_variable_value,
1721         set_trace_notes, get_tib_address, use_agent, can_use_agent,
1722         record_is_replaying, record_will_replay,
1723         augmented_libraries_svr4_read>: Adjust to return bool.
1724         * aarch64-linux-nat.c: All implementations adjusted.
1725         * aix-thread.c: All implementations adjusted.
1726         * arm-linux-nat.c: All implementations adjusted.
1727         * breakpoint.c: All implementations adjusted.
1728         * bsd-kvm.c: All implementations adjusted.
1729         * bsd-uthread.c: All implementations adjusted.
1730         * corelow.c: All implementations adjusted.
1731         * ctf.c: All implementations adjusted.
1732         * darwin-nat.c: All implementations adjusted.
1733         * darwin-nat.h: All implementations adjusted.
1734         * exec.c: All implementations adjusted.
1735         * fbsd-nat.c: All implementations adjusted.
1736         * fbsd-nat.h: All implementations adjusted.
1737         * gnu-nat.c: All implementations adjusted.
1738         * gnu-nat.h: All implementations adjusted.
1739         * go32-nat.c: All implementations adjusted.
1740         * ia64-linux-nat.c: All implementations adjusted.
1741         * inf-child.c: All implementations adjusted.
1742         * inf-child.h: All implementations adjusted.
1743         * inf-ptrace.c: All implementations adjusted.
1744         * inf-ptrace.h: All implementations adjusted.
1745         * linux-nat.c: All implementations adjusted.
1746         * linux-nat.h: All implementations adjusted.
1747         * mips-linux-nat.c: All implementations adjusted.
1748         * nto-procfs.c: All implementations adjusted.
1749         * ppc-linux-nat.c: All implementations adjusted.
1750         * procfs.c: All implementations adjusted.
1751         * ravenscar-thread.c: All implementations adjusted.
1752         * record-btrace.c: All implementations adjusted.
1753         * record-full.c: All implementations adjusted.
1754         * remote-sim.c: All implementations adjusted.
1755         * remote.c: All implementations adjusted.
1756         * s390-linux-nat.c: All implementations adjusted.
1757         * sol-thread.c: All implementations adjusted.
1758         * spu-multiarch.c: All implementations adjusted.
1759         * target-delegates.c: All implementations adjusted.
1760         * target.c: All implementations adjusted.
1761         * target.h: All implementations adjusted.
1762         * tracefile-tfile.c: All implementations adjusted.
1763         * tracefile.c: All implementations adjusted.
1764         * tracefile.h: All implementations adjusted.
1765         * windows-nat.c: All implementations adjusted.
1766         * x86-linux-nat.h: All implementations adjusted.
1767         * x86-nat.h: All implementations adjusted.
1768
1769 2018-05-02  Pedro Alves  <palves@redhat.com>
1770
1771         * make-target-delegates (scan_target_h): Don't trim lines here.
1772         Replace sequences of tabs and/or whitespace with a single
1773         whitespace.
1774         (top level, parsing methods): Trim each line before processing it
1775         here.
1776
1777 2018-05-02  Pedro Alves  <palves@redhat.com>
1778             John Baldwin  <jhb@freebsd.org>
1779
1780         * target.h (enum strata) <debug_stratum>: New.
1781         (struct target_ops) <all delegation methods>: Replace by C++
1782         virtual methods, and drop "to_" prefix.  All references updated
1783         throughout.
1784         <to_shortname, to_longname, to_doc, to_data,
1785         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
1786         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
1787         virtual methods.  All references updated throughout.
1788         <can_attach, supports_terminal_ours, can_create_inferior,
1789         get_thread_control_capabilities, attach_no_wait>: New
1790         virtual methods.
1791         <insert_breakpoint, remove_breakpoint>: Now
1792         TARGET_DEFAULT_NORETURN methods.
1793         <info_proc>: Now returns bool.
1794         <to_magic>: Delete.
1795         (OPS_MAGIC): Delete.
1796         (current_target): Delete.  All references replaced by references
1797         to ...
1798         (target_stack): ... this.  New.
1799         (target_shortname, target_longname): Adjust.
1800         (target_can_run): Now a function declaration.
1801         (default_child_has_all_memory, default_child_has_memory)
1802         (default_child_has_stack, default_child_has_registers)
1803         (default_child_has_execution): Remove target_ops parameter.
1804         (complete_target_initialization): Delete.
1805         (memory_breakpoint_target): New template class.
1806         (test_target_ops): Refactor as a C++ class with virtual methods.
1807         * make-target-delegates (NAME_PART): Tighten.
1808         (POINTER_PART, CP_SYMBOL): New.
1809         (SIMPLE_RETURN_PART): Reimplement.
1810         (VEC_RETURN_PART): Expect less.
1811         (RETURN_PART, VIRTUAL_PART): New.
1812         (METHOD): Adjust to C++ virtual methods.
1813         (scan_target_h): Remove reference to C99.
1814         (dname): Output "target_ops::" prefix.
1815         (write_function_header): Adjust to output a C++ class method.
1816         (write_declaration): New.
1817         (write_delegator): Adjust to output a C++ class method.
1818         (tdname): Output "dummy_target::" prefix.
1819         (write_tdefault, write_debugmethod): Adjust to output a C++ class
1820         method.
1821         (tdefault_names, debug_names): Delete.
1822         (return_types, tdefaults, styles, argtypes_array): New.
1823         (top level): All methods are delegators.
1824         (print_class): New.
1825         (top level): Print dummy_target and debug_target classes.
1826         * target-delegates.c: Regenerate.
1827         * target-debug.h (target_debug_print_enum_info_proc_what)
1828         (target_debug_print_thread_control_capabilities)
1829         (target_debug_print_thread_info_p): New.
1830         * target.c (dummy_target): Delete.
1831         (the_dummy_target, the_debug_target): New.
1832         (target_stack): Now extern.
1833         (set_targetdebug): Push/unpush debug target.
1834         (default_child_has_all_memory, default_child_has_memory)
1835         (default_child_has_stack, default_child_has_registers)
1836         (default_child_has_execution): Remove target_ops parameter.
1837         (complete_target_initialization): Delete.
1838         (add_target_with_completer): No longer call
1839         complete_target_initialization.
1840         (target_supports_terminal_ours): Use regular delegation.
1841         (update_current_target): Delete.
1842         (push_target): No longer check magic number.  Don't call
1843         update_current_target.
1844         (unpush_target): Don't call update_current_target.
1845         (target_is_pushed): No longer check magic number.
1846         (target_require_runnable): Skip for all stratums over
1847         process_stratum.
1848         (target_ops::info_proc): New.
1849         (target_info_proc): Use find_target_at and
1850         find_default_run_target.
1851         (target_supports_disable_randomization): Use regular delegation.
1852         (target_get_osdata): Use find_target_at.
1853         (target_ops::open, target_ops::close, target_ops::can_attach)
1854         (target_ops::attach, target_ops::can_create_inferior)
1855         (target_ops::create_inferior, target_ops::can_run)
1856         (target_can_run): New.
1857         (default_fileio_target): Use regular delegation.
1858         (target_ops::fileio_open, target_ops::fileio_pwrite)
1859         (target_ops::fileio_pread, target_ops::fileio_fstat)
1860         (target_ops::fileio_close, target_ops::fileio_unlink)
1861         (target_ops::fileio_readlink): New.
1862         (target_fileio_open_1, target_fileio_unlink)
1863         (target_fileio_readlink): Always call the target method.  Handle
1864         FILEIO_ENOSYS.
1865         (return_zero, return_zero_has_execution): Delete.
1866         (init_dummy_target): Delete.
1867         (dummy_target::dummy_target, dummy_target::shortname)
1868         (dummy_target::longname, dummy_target::doc)
1869         (debug_target::debug_target, debug_target::shortname)
1870         (debug_target::longname, debug_target::doc): New.
1871         (target_supports_delete_record): Use regular delegation.
1872         (setup_target_debug): Delete.
1873         (maintenance_print_target_stack): Skip debug_stratum.
1874         (initialize_targets): Instantiate the_dummy_target and
1875         the_debug_target.
1876         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
1877         use target_stack.
1878         (target_auxv_search, fprint_target_auxv): Adjust.
1879         (info_auxv_command): Adjust to use target_stack.
1880         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
1881         * exceptions.c (print_flush): Handle a NULL target_stack.
1882         * regcache.c (target_ops_no_register): Refactor as class with
1883         virtual methods.
1884
1885         * exec.c (exec_target): New class.
1886         (exec_ops): Now an exec_target.
1887         (exec_open, exec_close_1, exec_get_section_table)
1888         (exec_xfer_partial, exec_files_info, exec_has_memory)
1889         (exec_make_note_section): Refactor as exec_target methods.
1890         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
1891         Delete.
1892         (exec_target::find_memory_regions): New.
1893         (_initialize_exec): Don't call init_exec_ops.
1894         * gdbcore.h (exec_file_clear): Delete.
1895
1896         * corefile.c (core_target): Delete.
1897         (core_file_command): Adjust.
1898         * corelow.c (core_target): New class.
1899         (the_core_target): New.
1900         (core_close): Remove target_ops parameter.
1901         (core_close_cleanup): Adjust.
1902         (core_target::close): New.
1903         (core_open, core_detach, get_core_registers, core_files_info)
1904         (core_xfer_partial, core_thread_alive, core_read_description)
1905         (core_pid_to_str, core_thread_name, core_has_memory)
1906         (core_has_stack, core_has_registers, core_info_proc): Rework as
1907         core_target methods.
1908         (ignore, core_remove_breakpoint, init_core_ops): Delete.
1909         (_initialize_corelow): Initialize the_core_target.
1910         * gdbcore.h (core_target): Delete.
1911         (the_core_target): New.
1912
1913         * ctf.c: (ctf_target): New class.
1914         (ctf_ops): Now a ctf_target.
1915         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
1916         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
1917         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
1918         methods.
1919         (init_ctf_ops): Delete.
1920         (_initialize_ctf): Don't call it.
1921         * tracefile-tfile.c (tfile_target): New class.
1922         (tfile_ops): Now a tfile_target.
1923         (tfile_open, tfile_close, tfile_files_info)
1924         (tfile_get_tracepoint_status, tfile_trace_find)
1925         (tfile_fetch_registers, tfile_xfer_partial)
1926         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
1927         Refactor as tfile_target methods.
1928         (tfile_xfer_partial_features): Remove target_ops parameter.
1929         (init_tfile_ops): Delete.
1930         (_initialize_tracefile_tfile): Don't call it.
1931         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
1932         (tracefile_has_stack, tracefile_has_registers)
1933         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
1934         tracefile_target methods.
1935         (init_tracefile_ops): Delete.
1936         (tracefile_target::tracefile_target): New.
1937         * tracefile.h: Include "target.h".
1938         (tracefile_target): New class.
1939         (init_tracefile_ops): Delete.
1940
1941         * spu-multiarch.c (spu_multiarch_target): New class.
1942         (spu_ops): Now a spu_multiarch_target.
1943         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
1944         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
1945         (spu_search_memory, spu_mourn_inferior): Refactor as
1946         spu_multiarch_target methods.
1947         (init_spu_ops): Delete.
1948         (_initialize_spu_multiarch): Remove references to init_spu_ops,
1949         complete_target_initialization.
1950
1951         * ravenscar-thread.c (ravenscar_thread_target): New class.
1952         (ravenscar_ops): Now a ravenscar_thread_target.
1953         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
1954         (ravenscar_thread_alive, ravenscar_pid_to_str)
1955         (ravenscar_fetch_registers, ravenscar_store_registers)
1956         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
1957         (ravenscar_stopped_by_hw_breakpoint)
1958         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
1959         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
1960         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
1961         methods.
1962         (init_ravenscar_thread_ops): Delete.
1963         (_initialize_ravenscar): Remove references to
1964         init_ravenscar_thread_ops and complete_target_initialization.
1965
1966         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
1967         (bsd_uthread_target): New class.
1968         (bsd_uthread_ops): Now a bsd_uthread_target.
1969         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
1970         (bsd_uthread_close, bsd_uthread_mourn_inferior)
1971         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
1972         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
1973         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
1974         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
1975         (bsd_uthread_target): Delete function.
1976         (_initialize_bsd_uthread): Remove reference to
1977         complete_target_initialization.
1978
1979         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
1980         (target_bfd): ... this new class.
1981         (target_bfd_xfer_partial, target_bfd_get_section_table)
1982         (target_bfd_close): Refactor as target_bfd methods.
1983         (target_bfd::~target_bfd): New.
1984         (target_bfd_reopen): Adjust.
1985         (target_bfd::close): New.
1986
1987         * record-btrace.c (record_btrace_target): New class.
1988         (record_btrace_ops): Now a record_btrace_target.
1989         (record_btrace_open, record_btrace_stop_recording)
1990         (record_btrace_disconnect, record_btrace_close)
1991         (record_btrace_async, record_btrace_info)
1992         (record_btrace_insn_history, record_btrace_insn_history_range)
1993         (record_btrace_insn_history_from, record_btrace_call_history)
1994         (record_btrace_call_history_range)
1995         (record_btrace_call_history_from, record_btrace_record_method)
1996         (record_btrace_is_replaying, record_btrace_will_replay)
1997         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
1998         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
1999         (record_btrace_store_registers, record_btrace_prepare_to_store)
2000         (record_btrace_to_get_unwinder)
2001         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
2002         (record_btrace_commit_resume, record_btrace_wait)
2003         (record_btrace_stop, record_btrace_can_execute_reverse)
2004         (record_btrace_stopped_by_sw_breakpoint)
2005         (record_btrace_supports_stopped_by_sw_breakpoint)
2006         (record_btrace_stopped_by_hw_breakpoint)
2007         (record_btrace_supports_stopped_by_hw_breakpoint)
2008         (record_btrace_update_thread_list, record_btrace_thread_alive)
2009         (record_btrace_goto_begin, record_btrace_goto_end)
2010         (record_btrace_goto, record_btrace_stop_replaying_all)
2011         (record_btrace_execution_direction)
2012         (record_btrace_prepare_to_generate_core)
2013         (record_btrace_done_generating_core): Refactor as
2014         record_btrace_target methods.
2015         (init_record_btrace_ops): Delete.
2016         (_initialize_record_btrace): Remove reference to
2017         init_record_btrace_ops.
2018         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
2019         the execution_direction global.
2020         (record_full_base_target, record_full_target)
2021         (record_full_core_target): New classes.
2022         (record_full_ops): Now a record_full_target.
2023         (record_full_core_ops): Now a record_full_core_target.
2024         (record_full_target::detach, record_full_target::disconnect)
2025         (record_full_core_target::disconnect)
2026         (record_full_target::mourn_inferior, record_full_target::kill):
2027         New.
2028         (record_full_open, record_full_close, record_full_async): Refactor
2029         as methods of the record_full_base_target class.
2030         (record_full_resume, record_full_commit_resume): Refactor
2031         as methods of the record_full_target class.
2032         (record_full_wait, record_full_stopped_by_watchpoint)
2033         (record_full_stopped_data_address)
2034         (record_full_stopped_by_sw_breakpoint)
2035         (record_full_supports_stopped_by_sw_breakpoint)
2036         (record_full_stopped_by_hw_breakpoint)
2037         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
2038         methods of the record_full_base_target class.
2039         (record_full_store_registers, record_full_xfer_partial)
2040         (record_full_insert_breakpoint, record_full_remove_breakpoint):
2041         Refactor as methods of the record_full_target class.
2042         (record_full_can_execute_reverse, record_full_get_bookmark)
2043         (record_full_goto_bookmark, record_full_execution_direction)
2044         (record_full_record_method, record_full_info, record_full_delete)
2045         (record_full_is_replaying, record_full_will_replay)
2046         (record_full_goto_begin, record_full_goto_end, record_full_goto)
2047         (record_full_stop_replaying): Refactor as methods of the
2048         record_full_base_target class.
2049         (record_full_core_resume, record_full_core_kill)
2050         (record_full_core_fetch_registers)
2051         (record_full_core_prepare_to_store)
2052         (record_full_core_store_registers, record_full_core_xfer_partial)
2053         (record_full_core_insert_breakpoint)
2054         (record_full_core_remove_breakpoint)
2055         (record_full_core_has_execution): Refactor
2056         as methods of the record_full_core_target class.
2057         (record_full_base_target::supports_delete_record): New.
2058         (init_record_full_ops): Delete.
2059         (init_record_full_core_ops): Delete.
2060         (record_full_save): Refactor as method of the
2061         record_full_base_target class.
2062         (_initialize_record_full): Remove references to
2063         init_record_full_ops and init_record_full_core_ops.
2064
2065         * remote.c (remote_target, extended_remote_target): New classes.
2066         (remote_ops): Now a remote_target.
2067         (extended_remote_ops): Now an extended_remote_target.
2068         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
2069         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
2070         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
2071         (remote_pass_signals, remote_set_syscall_catchpoint)
2072         (remote_program_signals, )
2073         (remote_thread_always_alive): Remove target_ops parameter.
2074         (remote_thread_alive, remote_thread_name)
2075         (remote_update_thread_list, remote_threads_extra_info)
2076         (remote_static_tracepoint_marker_at)
2077         (remote_static_tracepoint_markers_by_strid)
2078         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
2079         (remote_open): Refactor as methods of remote_target.
2080         (extended_remote_open, extended_remote_detach)
2081         (extended_remote_attach, extended_remote_post_attach):
2082         (extended_remote_supports_disable_randomization)
2083         (extended_remote_create_inferior): : Refactor as method of
2084         extended_remote_target.
2085         (remote_set_permissions, remote_open_1, remote_detach)
2086         (remote_follow_fork, remote_follow_exec, remote_disconnect)
2087         (remote_resume, remote_commit_resume, remote_stop)
2088         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
2089         (remote_terminal_ours, remote_wait, remote_fetch_registers)
2090         (remote_prepare_to_store, remote_store_registers)
2091         (remote_flash_erase, remote_flash_done, remote_files_info)
2092         (remote_kill, remote_mourn, remote_insert_breakpoint)
2093         (remote_remove_breakpoint, remote_insert_watchpoint)
2094         (remote_watchpoint_addr_within_range)
2095         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
2096         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
2097         (remote_supports_stopped_by_sw_breakpoint)
2098         (remote_stopped_by_hw_breakpoint)
2099         (remote_supports_stopped_by_hw_breakpoint)
2100         (remote_stopped_by_watchpoint, remote_stopped_data_address)
2101         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
2102         (remote_verify_memory): Refactor as methods of remote_target.
2103         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
2104         parameter.
2105         (remote_xfer_partial, remote_get_memory_xfer_limit)
2106         (remote_search_memory, remote_rcmd, remote_memory_map)
2107         (remote_pid_to_str, remote_get_thread_local_address)
2108         (remote_get_tib_address, remote_read_description): Refactor as
2109         methods of remote_target.
2110         (remote_target::fileio_open, remote_target::fileio_pwrite)
2111         (remote_target::fileio_pread, remote_target::fileio_close): New.
2112         (remote_hostio_readlink, remote_hostio_fstat)
2113         (remote_filesystem_is_local, remote_can_execute_reverse)
2114         (remote_supports_non_stop, remote_supports_disable_randomization)
2115         (remote_supports_multi_process, remote_supports_cond_breakpoints)
2116         (remote_supports_enable_disable_tracepoint)
2117         (remote_supports_string_tracing)
2118         (remote_can_run_breakpoint_commands, remote_trace_init)
2119         (remote_download_tracepoint, remote_can_download_tracepoint)
2120         (remote_download_trace_state_variable, remote_enable_tracepoint)
2121         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
2122         (remote_trace_start, remote_get_trace_status)
2123         (remote_get_tracepoint_status, remote_trace_stop)
2124         (remote_trace_find, remote_get_trace_state_variable_value)
2125         (remote_save_trace_data, remote_get_raw_trace_data)
2126         (remote_set_disconnected_tracing, remote_core_of_thread)
2127         (remote_set_circular_trace_buffer, remote_traceframe_info)
2128         (remote_get_min_fast_tracepoint_insn_len)
2129         (remote_set_trace_buffer_size, remote_set_trace_notes)
2130         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
2131         (remote_disable_btrace, remote_teardown_btrace)
2132         (remote_read_btrace, remote_btrace_conf)
2133         (remote_augmented_libraries_svr4_read, remote_load)
2134         (remote_pid_to_exec_file, remote_can_do_single_step)
2135         (remote_execution_direction, remote_thread_handle_to_thread_info):
2136         Refactor as methods of remote_target.
2137         (init_remote_ops, init_extended_remote_ops): Delete.
2138         (remote_can_async_p, remote_is_async_p, remote_async)
2139         (remote_thread_events, remote_upload_tracepoints)
2140         (remote_upload_trace_state_variables): Refactor as methods of
2141         remote_target.
2142         (_initialize_remote): Remove references to init_remote_ops and
2143         init_extended_remote_ops.
2144
2145         * remote-sim.c (gdbsim_target): New class.
2146         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
2147         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
2148         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
2149         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
2150         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
2151         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
2152         Refactor as methods of gdbsim_target.
2153         (gdbsim_ops): Now a gdbsim_target.
2154         (init_gdbsim_ops): Delete.
2155         (gdbsim_cntrl_c): Adjust.
2156         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
2157
2158         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
2159         (the_amd64_linux_nat_target): New.
2160         (amd64_linux_fetch_inferior_registers)
2161         (amd64_linux_store_inferior_registers): Refactor as methods of
2162         amd64_linux_nat_target.
2163         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
2164         * i386-linux-nat.c: Don't include "linux-nat.h".
2165         (i386_linux_nat_target): New class.
2166         (the_i386_linux_nat_target): New.
2167         (i386_linux_fetch_inferior_registers)
2168         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
2169         as methods of i386_linux_nat_target.
2170         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
2171         * inf-child.c (inf_child_ops): Delete.
2172         (inf_child_fetch_inferior_registers)
2173         (inf_child_store_inferior_registers): Delete.
2174         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
2175         methods of inf_child_target.
2176         (inf_child_target::supports_terminal_ours)
2177         (inf_child_target::terminal_init)
2178         (inf_child_target::terminal_inferior)
2179         (inf_child_target::terminal_ours_for_output)
2180         (inf_child_target::terminal_ours, inf_child_target::interrupt)
2181         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
2182         New.
2183         (inf_child_open, inf_child_disconnect, inf_child_close)
2184         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
2185         (inf_child_post_startup_inferior, inf_child_can_run)
2186         (inf_child_pid_to_exec_file): Refactor as methods of
2187         inf_child_target.
2188         (inf_child_follow_fork): Delete.
2189         (inf_child_target::can_create_inferior)
2190         (inf_child_target::can_attach): New.
2191         (inf_child_target::has_all_memory, inf_child_target::has_memory)
2192         (inf_child_target::has_stack, inf_child_target::has_registers)
2193         (inf_child_target::has_execution): New.
2194         (inf_child_fileio_open, inf_child_fileio_pwrite)
2195         (inf_child_fileio_pread, inf_child_fileio_fstat)
2196         (inf_child_fileio_close, inf_child_fileio_unlink)
2197         (inf_child_fileio_readlink, inf_child_use_agent)
2198         (inf_child_can_use_agent): Refactor as methods of
2199         inf_child_target.
2200         (return_zero, inf_child_target): Delete.
2201         (inf_child_target::inf_child_target): New.
2202         * inf-child.h: Include "target.h".
2203         (inf_child_target): Delete function prototype.
2204         (inf_child_target): New class.
2205         (inf_child_open_target, inf_child_mourn_inferior)
2206         (inf_child_maybe_unpush_target): Delete.
2207         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
2208         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
2209         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
2210         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
2211         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
2212         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
2213         (inf_ptrace_wait, inf_ptrace_xfer_partial)
2214         (inf_ptrace_thread_alive, inf_ptrace_files_info)
2215         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
2216         methods of inf_ptrace_target.
2217         (inf_ptrace_target): Delete function.
2218         * inf-ptrace.h: Include "inf-child.h".
2219         (inf_ptrace_target): Delete function declaration.
2220         (inf_ptrace_target): New class.
2221         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
2222         * linux-nat.c (linux_target): New.
2223         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
2224         (linux_nat_target::~linux_nat_target): New.
2225         (linux_child_post_attach, linux_child_post_startup_inferior)
2226         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
2227         (linux_child_remove_fork_catchpoint)
2228         (linux_child_insert_vfork_catchpoint)
2229         (linux_child_remove_vfork_catchpoint)
2230         (linux_child_insert_exec_catchpoint)
2231         (linux_child_remove_exec_catchpoint)
2232         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
2233         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
2234         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
2235         (linux_nat_stopped_data_address)
2236         (linux_nat_stopped_by_sw_breakpoint)
2237         (linux_nat_supports_stopped_by_sw_breakpoint)
2238         (linux_nat_stopped_by_hw_breakpoint)
2239         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
2240         (linux_nat_kill, linux_nat_mourn_inferior)
2241         (linux_nat_xfer_partial, linux_nat_thread_alive)
2242         (linux_nat_update_thread_list, linux_nat_pid_to_str)
2243         (linux_nat_thread_name, linux_child_pid_to_exec_file)
2244         (linux_child_static_tracepoint_markers_by_strid)
2245         (linux_nat_is_async_p, linux_nat_can_async_p)
2246         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
2247         (linux_nat_supports_multi_process)
2248         (linux_nat_supports_disable_randomization, linux_nat_async)
2249         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
2250         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
2251         (linux_nat_fileio_open, linux_nat_fileio_readlink)
2252         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
2253         methods of linux_nat_target.
2254         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
2255         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
2256         parameter.
2257         (check_stopped_by_watchpoint): Adjust.
2258         (linux_xfer_partial): Delete.
2259         (linux_target_install_ops, linux_target, linux_nat_add_target):
2260         Delete.
2261         (linux_nat_target::linux_nat_target): New.
2262         * linux-nat.h: Include "inf-ptrace.h".
2263         (linux_nat_target): New.
2264         (linux_target, linux_target_install_ops, linux_nat_add_target):
2265         Delete function declarations.
2266         (linux_target): Declare global.
2267         * linux-thread-db.c (thread_db_target): New.
2268         (thread_db_target::thread_db_target): New.
2269         (thread_db_ops): Delete.
2270         (the_thread_db_target): New.
2271         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
2272         (thread_db_update_thread_list, thread_db_pid_to_str)
2273         (thread_db_extra_thread_info)
2274         (thread_db_thread_handle_to_thread_info)
2275         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
2276         (thread_db_resume): Refactor as methods of thread_db_target.
2277         (init_thread_db_ops): Delete.
2278         (_initialize_thread_db): Remove reference to init_thread_db_ops.
2279         * x86-linux-nat.c: Don't include "linux-nat.h".
2280         (super_post_startup_inferior): Delete.
2281         (x86_linux_nat_target::~x86_linux_nat_target): New.
2282         (x86_linux_child_post_startup_inferior)
2283         (x86_linux_read_description, x86_linux_enable_btrace)
2284         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
2285         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
2286         methods of x86_linux_nat_target.
2287         (x86_linux_create_target): Delete.  Bits folded ...
2288         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
2289         pointer.
2290         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
2291         (x86_linux_nat_target): New class.
2292         (x86_linux_create_target): Delete.
2293         (x86_linux_add_target): Now takes a linux_nat_target pointer.
2294         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
2295         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
2296         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
2297         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
2298         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
2299         make extern.
2300         (x86_use_watchpoints): Delete.
2301         * x86-nat.h: Include "breakpoint.h" and "target.h".
2302         (x86_use_watchpoints): Delete.
2303         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
2304         (x86_stopped_by_watchpoint, x86_stopped_data_address)
2305         (x86_insert_watchpoint, x86_remove_watchpoint)
2306         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
2307         (x86_stopped_by_hw_breakpoint): New declarations.
2308         (x86_nat_target): New template class.
2309
2310         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
2311         (the_ppc_linux_nat_target): New.
2312         (ppc_linux_fetch_inferior_registers)
2313         (ppc_linux_can_use_hw_breakpoint)
2314         (ppc_linux_region_ok_for_hw_watchpoint)
2315         (ppc_linux_ranged_break_num_registers)
2316         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
2317         (ppc_linux_insert_mask_watchpoint)
2318         (ppc_linux_remove_mask_watchpoint)
2319         (ppc_linux_can_accel_watchpoint_condition)
2320         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
2321         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
2322         (ppc_linux_watchpoint_addr_within_range)
2323         (ppc_linux_masked_watch_num_registers)
2324         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
2325         (ppc_linux_read_description): Refactor as methods of
2326         ppc_linux_nat_target.
2327         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
2328
2329         * procfs.c (procfs_xfer_partial): Delete forward declaration.
2330         (procfs_target): New class.
2331         (the_procfs_target): New.
2332         (procfs_target): Delete function.
2333         (procfs_auxv_parse, procfs_attach, procfs_detach)
2334         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
2335         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
2336         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
2337         (procfs_create_inferior, procfs_update_thread_list)
2338         (procfs_thread_alive, procfs_pid_to_str)
2339         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
2340         (procfs_stopped_data_address, procfs_insert_watchpoint)
2341         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
2342         (proc_find_memory_regions, procfs_info_proc)
2343         (procfs_make_note_section): Refactor as methods of procfs_target.
2344         (_initialize_procfs): Adjust.
2345         * sol-thread.c (sol_thread_target): New class.
2346         (sol_thread_ops): Now a sol_thread_target.
2347         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
2348         (sol_thread_fetch_registers, sol_thread_store_registers)
2349         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
2350         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
2351         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
2352         (init_sol_thread_ops): Delete.
2353         (_initialize_sol_thread): Adjust.  Remove references to
2354         init_sol_thread_ops and complete_target_initialization.
2355
2356         * windows-nat.c (windows_nat_target): New class.
2357         (windows_fetch_inferior_registers)
2358         (windows_store_inferior_registers, windows_resume, windows_wait)
2359         (windows_attach, windows_detach, windows_pid_to_exec_file)
2360         (windows_files_info, windows_create_inferior)
2361         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
2362         (windows_close, windows_pid_to_str, windows_xfer_partial)
2363         (windows_get_tib_address, windows_get_ada_task_ptid)
2364         (windows_thread_name, windows_thread_alive): Refactor as
2365         windows_nat_target methods.
2366         (do_initial_windows_stuff): Adjust.
2367         (windows_target): Delete function.
2368         (_initialize_windows_nat): Adjust.
2369
2370         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
2371         (darwin_mourn_inferior, darwin_kill_inferior)
2372         (darwin_create_inferior, darwin_attach, darwin_detach)
2373         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
2374         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
2375         (darwin_supports_multi_process): Refactor as darwin_nat_target
2376         methods.
2377         (darwin_resume_to, darwin_files_info): Delete.
2378         (_initialize_darwin_inferior): Rename to ...
2379         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
2380         * darwin-nat.h: Include "inf-child.h".
2381         (darwin_nat_target): New class.
2382         (darwin_complete_target): Delete.
2383         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
2384         (darwin_target): New.
2385         (i386_darwin_fetch_inferior_registers)
2386         (i386_darwin_store_inferior_registers): Refactor as methods of
2387         darwin_nat_target.
2388         (darwin_complete_target): Delete, with ...
2389         (_initialize_i386_darwin_nat): ... bits factored out here.
2390
2391         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
2392         (the_alpha_linux_nat_target): New.
2393         (alpha_linux_register_u_offset): Refactor as
2394         alpha_linux_nat_target method.
2395         (_initialize_alpha_linux_nat): Adjust.
2396         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
2397         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2398         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
2399         methods of linux_nat_trad_target.
2400         (linux_trad_target): Delete.
2401         * linux-nat-trad.h (linux_trad_target): Delete function.
2402         (linux_nat_trad_target): New class.
2403         * mips-linux-nat.c (mips_linux_nat_target): New class.
2404         (super_fetch_registers, super_store_registers, super_close):
2405         Delete.
2406         (the_mips_linux_nat_target): New.
2407         (mips64_linux_regsets_fetch_registers)
2408         (mips64_linux_regsets_store_registers)
2409         (mips64_linux_fetch_registers, mips64_linux_store_registers)
2410         (mips_linux_register_u_offset, mips_linux_read_description)
2411         (mips_linux_can_use_hw_breakpoint)
2412         (mips_linux_stopped_by_watchpoint)
2413         (mips_linux_stopped_data_address)
2414         (mips_linux_region_ok_for_hw_watchpoint)
2415         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
2416         (mips_linux_close): Refactor as methods of mips_linux_nat.
2417         (_initialize_mips_linux_nat): Adjust to C++ification.
2418
2419         * aix-thread.c (aix_thread_target): New class.
2420         (aix_thread_ops): Now an aix_thread_target.
2421         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
2422         (aix_thread_fetch_registers, aix_thread_store_registers)
2423         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
2424         (aix_thread_thread_alive, aix_thread_pid_to_str)
2425         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
2426         Refactor as methods of aix_thread_target.
2427         (init_aix_thread_ops): Delete.
2428         (_initialize_aix_thread): Remove references to init_aix_thread_ops
2429         and complete_target_initialization.
2430         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
2431         (rs6000_nat_target): New class.
2432         (the_rs6000_nat_target): New.
2433         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
2434         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
2435         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
2436         (super_create_inferior): Delete.
2437         (_initialize_rs6000_nat): Adjust to C++ification.
2438
2439         * arm-linux-nat.c (arm_linux_nat_target): New class.
2440         (the_arm_linux_nat_target): New.
2441         (arm_linux_fetch_inferior_registers)
2442         (arm_linux_store_inferior_registers, arm_linux_read_description)
2443         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
2444         (arm_linux_remove_hw_breakpoint)
2445         (arm_linux_region_ok_for_hw_watchpoint)
2446         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
2447         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
2448         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
2449         arm_linux_nat_target.
2450         (_initialize_arm_linux_nat): Adjust to C++ification.
2451
2452         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
2453         (the_aarch64_linux_nat_target): New.
2454         (aarch64_linux_fetch_inferior_registers)
2455         (aarch64_linux_store_inferior_registers)
2456         (aarch64_linux_child_post_startup_inferior)
2457         (aarch64_linux_read_description)
2458         (aarch64_linux_can_use_hw_breakpoint)
2459         (aarch64_linux_insert_hw_breakpoint)
2460         (aarch64_linux_remove_hw_breakpoint)
2461         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
2462         (aarch64_linux_region_ok_for_hw_watchpoint)
2463         (aarch64_linux_stopped_data_address)
2464         (aarch64_linux_stopped_by_watchpoint)
2465         (aarch64_linux_watchpoint_addr_within_range)
2466         (aarch64_linux_can_do_single_step): Refactor as methods of
2467         aarch64_linux_nat_target.
2468         (super_post_startup_inferior): Delete.
2469         (_initialize_aarch64_linux_nat): Adjust to C++ification.
2470
2471         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
2472         (the_hppa_linux_nat_target): New.
2473         (hppa_linux_fetch_inferior_registers)
2474         (hppa_linux_store_inferior_registers): Refactor as methods of
2475         hppa_linux_nat_target.
2476         (_initialize_hppa_linux_nat): Adjust to C++ification.
2477
2478         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
2479         (the_ia64_linux_nat_target): New.
2480         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
2481         (ia64_linux_stopped_data_address)
2482         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
2483         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
2484         ia64_linux_nat_target methods.
2485         (super_xfer_partial): Delete.
2486         (_initialize_ia64_linux_nat): Adjust to C++ification.
2487
2488         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
2489         (the_m32r_linux_nat_target): New.
2490         (m32r_linux_fetch_inferior_registers)
2491         (m32r_linux_store_inferior_registers): Refactor as
2492         m32r_linux_nat_target methods.
2493         (_initialize_m32r_linux_nat): Adjust to C++ification.
2494
2495         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
2496         (the_m68k_linux_nat_target): New.
2497         (m68k_linux_fetch_inferior_registers)
2498         (m68k_linux_store_inferior_registers): Refactor as
2499         m68k_linux_nat_target methods.
2500         (_initialize_m68k_linux_nat): Adjust to C++ification.
2501
2502         * s390-linux-nat.c (s390_linux_nat_target): New class.
2503         (the_s390_linux_nat_target): New.
2504         (s390_linux_fetch_inferior_registers)
2505         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
2506         (s390_insert_watchpoint, s390_remove_watchpoint)
2507         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
2508         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
2509         (s390_auxv_parse, s390_read_description): Refactor as methods of
2510         s390_linux_nat_target.
2511         (_initialize_s390_nat): Adjust to C++ification.
2512
2513         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
2514         (the_sparc_linux_nat_target): New.
2515         (_initialize_sparc_linux_nat): Adjust to C++ification.
2516         * sparc-nat.c (sparc_fetch_inferior_registers)
2517         (sparc_store_inferior_registers): Remove target_ops parameter.
2518         * sparc-nat.h (sparc_fetch_inferior_registers)
2519         (sparc_store_inferior_registers): Remove target_ops parameter.
2520         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
2521         (the_sparc64_linux_nat_target): New.
2522         (_initialize_sparc64_linux_nat): Adjust to C++ification.
2523
2524         * spu-linux-nat.c (spu_linux_nat_target): New class.
2525         (the_spu_linux_nat_target): New.
2526         (spu_child_post_startup_inferior, spu_child_post_attach)
2527         (spu_child_wait, spu_fetch_inferior_registers)
2528         (spu_store_inferior_registers, spu_xfer_partial)
2529         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
2530         methods.
2531         (_initialize_spu_nat): Adjust to C++ification.
2532
2533         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
2534         (the_tilegx_linux_nat_target): New.
2535         (fetch_inferior_registers, store_inferior_registers):
2536         Refactor as methods.
2537         (_initialize_tile_linux_nat): Adjust to C++ification.
2538
2539         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
2540         (the_xtensa_linux_nat_target): New.
2541         (xtensa_linux_fetch_inferior_registers)
2542         (xtensa_linux_store_inferior_registers): Refactor as
2543         xtensa_linux_nat_target methods.
2544         (_initialize_xtensa_linux_nat): Adjust to C++ification.
2545
2546         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
2547         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
2548         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
2549         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
2550         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
2551         (fbsd_stopped_by_sw_breakpoint)
2552         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
2553         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
2554         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
2555         (fbsd_post_startup_inferior, fbsd_post_attach)
2556         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
2557         (fbsd_set_syscall_catchpoint)
2558         (super_xfer_partial, super_resume, super_wait)
2559         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
2560         (fbsd_handle_debug_trap): Remove target_ops parameter.
2561         (fbsd_nat_add_target): Delete.
2562         * fbsd-nat.h: Include "inf-ptrace.h".
2563         (fbsd_nat_add_target): Delete.
2564         (USE_SIGTRAP_SIGINFO): Define.
2565         (fbsd_nat_target): New class.
2566
2567         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
2568         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
2569         (amd64bsd_target): Delete.
2570         * amd64-bsd-nat.h: New file.
2571         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
2572         "x86-bsd-nat.h".
2573         (amd64_fbsd_nat_target): New class.
2574         (the_amd64_fbsd_nat_target): New.
2575         (amd64fbsd_read_description): Refactor as method of
2576         amd64_fbsd_nat_target.
2577         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2578         (_initialize_amd64fbsd_nat): Adjust to C++ification.
2579         * amd64-nat.h (amd64bsd_target): Delete function declaration.
2580         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
2581         (i386bsd_store_inferior_registers): Remove target_ops parameter.
2582         (i386bsd_target): Delete.
2583         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
2584         (i386bsd_fetch_inferior_registers)
2585         (i386bsd_store_inferior_registers): Declare.
2586         (i386_bsd_nat_target): New class.
2587         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
2588         (the_i386_fbsd_nat_target): New.
2589         (i386fbsd_resume, i386fbsd_read_description): Refactor as
2590         i386_fbsd_nat_target methods.
2591         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2592         (_initialize_i386fbsd_nat): Adjust to C++ification.
2593         * x86-bsd-nat.c (super_mourn_inferior): Delete.
2594         (x86bsd_mourn_inferior, x86bsd_target): Delete.
2595         (_initialize_x86_bsd_nat): Adjust to C++ification.
2596         * x86-bsd-nat.h: Include "x86-nat.h".
2597         (x86bsd_target): Delete declaration.
2598         (x86bsd_nat_target): New class.
2599
2600         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
2601         (the_aarch64_fbsd_nat_target): New.
2602         (aarch64_fbsd_fetch_inferior_registers)
2603         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
2604         aarch64_fbsd_nat_target.
2605         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
2606         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
2607         (the_alpha_bsd_nat_target): New.
2608         (alphabsd_fetch_inferior_registers)
2609         (alphabsd_store_inferior_registers): Refactor as
2610         alpha_bsd_nat_target methods.
2611         (_initialize_alphabsd_nat): Refactor as methods of
2612         alpha_bsd_nat_target.
2613         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
2614         (the_amd64_nbsd_nat_target): New.
2615         (_initialize_amd64nbsd_nat): Adjust to C++ification.
2616         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
2617         (the_amd64_obsd_nat_target): New.
2618         (_initialize_amd64obsd_nat): Adjust to C++ification.
2619         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
2620         (the_arm_fbsd_nat_target): New.
2621         (arm_fbsd_fetch_inferior_registers)
2622         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
2623         (_initialize_arm_fbsd_nat): Refactor as methods of
2624         arm_fbsd_nat_target.
2625         (_initialize_arm_fbsd_nat): Adjust to C++ification.
2626         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
2627         (the_arm_netbsd_nat_target): New.
2628         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
2629         arm_netbsd_nat_target.
2630         (_initialize_arm_netbsd_nat): Adjust to C++ification.
2631         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
2632         (the_hppa_nbsd_nat_target): New.
2633         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
2634         hppa_nbsd_nat_target methods.
2635         (_initialize_hppanbsd_nat): Adjust to C++ification.
2636         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
2637         (the_hppa_obsd_nat_target): New.
2638         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
2639         methods of hppa_obsd_nat_target.
2640         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
2641         add_target.
2642         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
2643         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
2644         add_target.
2645         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
2646         (_initialize_i386obsd_nat): Use add_target.
2647         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
2648         (the_m68k_bsd_nat_target): New.
2649         (m68kbsd_fetch_inferior_registers)
2650         (m68kbsd_store_inferior_registers): Refactor as methods of
2651         m68k_bsd_nat_target.
2652         (_initialize_m68kbsd_nat): Adjust to C++ification.
2653         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
2654         (the_mips_fbsd_nat_target): New.
2655         (mips_fbsd_fetch_inferior_registers)
2656         (mips_fbsd_store_inferior_registers): Refactor as methods of
2657         mips_fbsd_nat_target.
2658         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
2659         add_target.
2660         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
2661         (the_mips_nbsd_nat_target): New.
2662         (mipsnbsd_fetch_inferior_registers)
2663         (mipsnbsd_store_inferior_registers): Refactor as methods of
2664         mips_nbsd_nat_target.
2665         (_initialize_mipsnbsd_nat): Adjust to C++ification.
2666         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
2667         (the_mips64_obsd_nat_target): New.
2668         (mips64obsd_fetch_inferior_registers)
2669         (mips64obsd_store_inferior_registers): Refactor as methods of
2670         mips64_obsd_nat_target.
2671         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
2672         add_target.
2673         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
2674         nbsd_nat_target.
2675         * nbsd-nat.h: Include "inf-ptrace.h".
2676         (nbsd_nat_target): New class.
2677         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
2678         (obsd_wait): Refactor as methods of obsd_nat_target.
2679         (obsd_add_target): Delete.
2680         * obsd-nat.h: Include "inf-ptrace.h".
2681         (obsd_nat_target): New class.
2682         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
2683         (the_ppc_fbsd_nat_target): New.
2684         (ppcfbsd_fetch_inferior_registers)
2685         (ppcfbsd_store_inferior_registers): Refactor as methods of
2686         ppc_fbsd_nat_target.
2687         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
2688         add_target.
2689         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
2690         (the_ppc_nbsd_nat_target): New.
2691         (ppcnbsd_fetch_inferior_registers)
2692         (ppcnbsd_store_inferior_registers): Refactor as methods of
2693         ppc_nbsd_nat_target.
2694         (_initialize_ppcnbsd_nat): Adjust to C++ification.
2695         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
2696         (the_ppc_obsd_nat_target): New.
2697         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
2698         methods of ppc_obsd_nat_target.
2699         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
2700         add_target.
2701         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
2702         (the_sh_nbsd_nat_target): New.
2703         (shnbsd_fetch_inferior_registers)
2704         (shnbsd_store_inferior_registers): Refactor as methods of
2705         sh_nbsd_nat_target.
2706         (_initialize_shnbsd_nat): Adjust to C++ification.
2707         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
2708         (inf_ptrace_xfer_partial): Delete.
2709         (sparc_xfer_partial, sparc_target): Delete.
2710         * sparc-nat.h (sparc_fetch_inferior_registers)
2711         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
2712         (sparc_target): Delete function declaration.
2713         (sparc_target): New template class.
2714         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
2715         (_initialize_sparcnbsd_nat): Adjust to C++ification.
2716         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
2717         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
2718         add_target.
2719         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
2720         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
2721         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
2722         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
2723         add_target.
2724         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
2725         (the_vax_bsd_nat_target): New.
2726         (vaxbsd_fetch_inferior_registers)
2727         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
2728         methods.
2729         (_initialize_vaxbsd_nat): Adjust to C++ification.
2730
2731         * bsd-kvm.c (bsd_kvm_target): New class.
2732         (bsd_kvm_ops): Now a bsd_kvm_target.
2733         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
2734         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
2735         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
2736         bsd_kvm_target.
2737         (bsd_kvm_return_one): Delete.
2738         (bsd_kvm_add_target): Adjust to C++ification.
2739
2740         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
2741         (nto_procfs_target_procfs): New classes.
2742         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
2743         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
2744         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
2745         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
2746         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
2747         (procfs_remove_hw_breakpoint, procfs_resume)
2748         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
2749         (procfs_kill_inferior, procfs_store_registers)
2750         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
2751         as methods of nto_procfs_target.
2752         (nto_procfs_ops): Now an nto_procfs_target_procfs.
2753         (nto_native_ops): Delete.
2754         (procfs_open, procfs_native_open): Delete.
2755         (nto_native_ops): Now an nto_procfs_target_native.
2756         (init_procfs_targets): Adjust to C++ification.
2757         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
2758         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
2759         Refactor as methods of nto_procfs_target.
2760
2761         * go32-nat.c (go32_nat_target): New class.
2762         (the_go32_nat_target): New.
2763         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
2764         (go32_store_registers, go32_xfer_partial, go32_files_info)
2765         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
2766         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
2767         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
2768         (go32_pid_to_str): Refactor as methods of go32_nat_target.
2769         (go32_target): Delete.
2770         (_initialize_go32_nat): Adjust to C++ification.
2771
2772         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
2773         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
2774         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
2775         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
2776         gnu_nat_target.
2777         (gnu_target): Delete.
2778         * gnu-nat.h (gnu_target): Delete.
2779         (gnu_nat_target): New class.
2780         * i386-gnu-nat.c (gnu_base_target): New.
2781         (i386_gnu_nat_target): New class.
2782         (the_i386_gnu_nat_target): New.
2783         (_initialize_i386gnu_nat): Adjust to C++ification.
2784
2785 2018-05-02  Pedro Alves  <palves@redhat.com>
2786
2787         * bfd-target.c (target_bfd_xclose): Rename to ...
2788         (target_bfd_close): ... this.
2789         (target_bfd_reopen): Adjust.
2790         * target.c (target_close): Remove references to to_xclose.
2791         * target.h (target_ops::to_xclose): Delete.
2792         (target_ops::to_close): Update comments.
2793
2794 2018-05-02  Pedro Alves  <palves@redhat.com>
2795
2796         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
2797         "linux-nat.h".
2798         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
2799         * inf-ptrace.c (inf_ptrace_register_u_offset)
2800         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2801         (inf_ptrace_store_register, inf_ptrace_store_registers)
2802         (inf_ptrace_trad_target): Move to ...
2803         * linux-nat-trad.c: ... this new file.
2804         * linux-nat-trad.h: New file.
2805         * linux-nat.c (linux_target_install_ops): Make extern.
2806         (linux_trad_target): Delete.
2807         * linux-nat.h (linux_trad_target): Delete declaration.
2808         (linux_target_install_ops): Declare.
2809         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
2810         "linux-nat.h".
2811
2812 2018-05-02  Pedro Alves  <palves@redhat.com>
2813
2814         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2815         procfs_target/add_target here.
2816         * procfs.c (procfs_target): Make static.
2817         (_initialize_procfs): Call add_target here.
2818         * procfs.h (struct target_ops): Remove forward declaration.
2819         (procfs_target): Remove declaration.
2820         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
2821
2822 2018-05-02  Pedro Alves  <palves@redhat.com>
2823
2824         * procfs.c (procfs_stopped_by_watchpoint)
2825         (procfs_insert_watchpoint, procfs_remove_watchpoint)
2826         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
2827         Forward declare.
2828         (procfs_use_watchpoints): Delete, move contents...
2829         (procfs_target): ... here.
2830         * procfs.h (procfs_use_watchpoints): Delete declaration.
2831         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2832         procfs_use_watchpoints.
2833         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
2834         procfs_use_watchpoints.
2835
2836 2018-05-02  Tom Tromey  <tom@tromey.com>
2837
2838         PR python/20084:
2839         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
2840         and var_zuinteger_unlimited.
2841         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
2842         and PARAM_ZUINTEGER_UNLIMITED.
2843         (set_parameter_value): Handle var_zuinteger and
2844         var_zuinteger_unlimited.
2845         (add_setshow_generic): Likewise.
2846         (parmpy_init): Likewise.
2847
2848 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
2849
2850         PR rust/23124
2851         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
2852         pointer is not null before dereferencing it.
2853
2854 2018-04-30  Tom Tromey  <tom@tromey.com>
2855
2856         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
2857         is_mi_like_p.
2858
2859 2018-04-30  Tom Tromey  <tom@tromey.com>
2860
2861         * breakpoint.c (mention): Remove use of is_mi_like_p.
2862         (print_mention_ranged_breakpoint): Likewise.
2863         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
2864         of is_mi_like_p.
2865
2866 2018-04-30  Tom Tromey  <tom@tromey.com>
2867
2868         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
2869
2870 2018-04-30  Tom Tromey  <tom@tromey.com>
2871
2872         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
2873         (info_spu_event_command): Remove some uses of is_mi_like_p.
2874
2875 2018-04-30  Tom Tromey  <tom@tromey.com>
2876
2877         * python/py-framefilter.c (py_print_single_arg)
2878         (enumerate_locals, py_print_args, py_print_frame): Remove some
2879         uses of is_mi_like_p.
2880
2881 2018-04-30  Tom Tromey  <tom@tromey.com>
2882
2883         * ui-out.c: Update.
2884         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
2885         * ui-out.h (ui_out::is_mi_like_p): Now const.
2886         (ui_out::do_is_mi_like_p): Now const.
2887         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
2888
2889 2018-04-30  Tom Tromey  <tom@tromey.com>
2890
2891         * varobj.c (varobj_set_visualizer): Use new_reference.
2892         * python/python.c (gdbpy_decode_line): Use new_reference.
2893         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
2894         new_reference.
2895
2896 2018-04-30  Tom Tromey  <tom@tromey.com>
2897
2898         * varobj.c (install_new_value): Use new_reference.
2899         * value.h (value_incref): Return void.  Swap intro comment with
2900         value_decref.
2901         * value.c (set_value_parent): Use new_reference.
2902         (value_incref): Return void.  Update intro comment.
2903         (release_value): Use new_reference.
2904         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
2905
2906 2018-04-30  Tom Tromey  <tom@tromey.com>
2907
2908         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
2909         * gdb_bfd.h (new_bfd_ref): Remove.
2910         (gdb_bfd_open): Update comment.
2911         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
2912         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
2913         (gdb_bfd_fdopenr): Use new_reference.
2914         * exec.c (exec_file_attach): Use new_reference.
2915
2916 2018-04-30  Tom Tromey  <tom@tromey.com>
2917
2918         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
2919         method.
2920
2921 2018-04-30  Tom Tromey  <tom@tromey.com>
2922
2923         * jit.c (jit_read_code_entry): Use type_align.
2924         * i386-tdep.c (i386_gdbarch_init): Don't call
2925         set_gdbarch_long_long_align_bit.
2926         * gdbarch.sh: Remove long_long_align_bit.
2927         * gdbarch.c, gdbarch.h: Rebuild.
2928         * arc-tdep.c (arc_type_align): New function.
2929         (arc_gdbarch_init): Use arc_type_align.  Don't call
2930         set_gdbarch_long_long_align_bit.
2931
2932 2018-04-30  Tom Tromey  <tom@tromey.com>
2933
2934         * rust-lang.c (rust_type_alignment): Remove.
2935         (rust_composite_type): Use type_align.
2936
2937 2018-04-30  Tom Tromey  <tom@tromey.com>
2938
2939         * NEWS: Mention Type.align.
2940         * python/py-type.c (typy_get_alignof): New function.
2941         (type_object_getset): Add "alignof".
2942
2943 2018-04-30  Tom Tromey  <tom@tromey.com>
2944
2945         PR exp/17095:
2946         * NEWS: Update.
2947         * std-operator.def (UNOP_ALIGNOF): New operator.
2948         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
2949         New.
2950         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
2951         * c-lang.c (c_op_print_tab): Add alignof.
2952         * c-exp.y (ALIGNOF): New token.
2953         (exp): Add "ALIGNOF" production.
2954         (ident_tokens): Add _Alignof and alignof.
2955
2956 2018-04-30  Tom Tromey  <tom@tromey.com>
2957
2958         * i386-tdep.c (i386_type_align): New function.
2959         (i386_gdbarch_init): Update.
2960         * gdbarch.sh (type_align): New method.
2961         * gdbarch.c, gdbarch.h: Rebuild.
2962         * arch-utils.h (default_type_align): Declare.
2963         * arch-utils.c (default_type_align): New function.
2964         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
2965         (struct type) <align_log2>: New field.
2966         <instance_flags>: Now a bitfield.
2967         (TYPE_RAW_ALIGN): New macro.
2968         (type_align, type_raw_align, set_type_align): Declare.
2969         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
2970         functions.
2971         * dwarf2read.c (quirk_rust_enum): Set type alignment.
2972         (get_alignment, maybe_set_alignment): New functions.
2973         (read_structure_type, read_enumeration_type, read_array_type)
2974         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
2975         (read_subrange_type, read_base_type): Set type alignment.
2976
2977 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
2978
2979         * dwarf2read.c (read_index_from_section): Use bool.
2980
2981 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
2982
2983         PR gdb/22950
2984         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
2985         with #ifdef.
2986
2987 2018-04-29  John Reiser  <jreiser@BitWagon.com>
2988
2989         PR build/22873
2990         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
2991         last step, and do it atomically.
2992
2993 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
2994
2995         * compile/compile-c-types.c (convert_int, convert_float):
2996         Update for C FE v1.
2997
2998 2018-04-27  Tom Tromey  <tom@tromey.com>
2999
3000         PR rust/22545:
3001         * rust-lang.c (rust_inclusive_range_type_p): New function.
3002         (rust_range): Handle inclusive ranges.
3003         (rust_compute_range): Likewise.
3004         * rust-exp.y (struct rust_op) <inclusive>: New field.
3005         (DOTDOTEQ): New constant.
3006         (range_expr): Add "..=" productions.
3007         (operator_tokens): Add "..=" token.
3008         (ast_range): Add "inclusive" parameter.
3009         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
3010         ranges.
3011         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
3012         bounds values.
3013         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
3014         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
3015         Update comments.
3016         * expprint.c (print_subexp_standard): Handle new bounds values.
3017         (dump_subexp_body_standard): Likewise.
3018
3019 2018-04-27  Tom Tromey  <tom@tromey.com>
3020
3021         * configure: Rebuild.
3022         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
3023         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
3024         "OVERRIDE".
3025         (class symbol_needs_eval_context): Likewise.
3026         * dwarf2read.c (mock_mapped_index::symbol_name_count)
3027         (mock_mapped_index::symbol_name_at): Use "override".  Remove
3028         "virtual".
3029         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
3030         "override".
3031         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
3032         * aarch64-tdep.c (instruction_reader::read): Use "override".
3033         (instruction_reader_test::read): Likewise.
3034         * arm-tdep.c (instruction_reader::read): Use "override".
3035         (instruction_reader_thumb::read): Likewise.
3036
3037 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
3038
3039         PR remote/9665
3040         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
3041         instead of remote_send.
3042         (remote_send): Remove.
3043
3044 2018-04-26  Pedro Alves  <palves@redhat.com>
3045
3046         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
3047         find_function_start_sal instead of find_pc_line.
3048
3049 2018-04-26  Pedro Alves  <palves@redhat.com>
3050
3051         * breakpoint.c (set_breakpoint_location_function): Handle
3052         mst_data_gnu_ifunc.
3053         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
3054         * elfread.c (elf_symtab_read): Give data symbols with
3055         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
3056         (elf_rel_plt_read): Update comment.
3057         * linespec.c (convert_linespec_to_sals): Handle
3058         mst_data_gnu_ifunc.
3059         (minsym_found): Handle mst_data_gnu_ifunc.
3060         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
3061         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
3062         * parse.c (find_minsym_type_and_address): Handle
3063         mst_data_gnu_ifunc.
3064         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
3065         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
3066         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
3067         comment.
3068         <mst_data_gnu_ifunc>: New enumerator.
3069
3070 2018-04-26  Pedro Alves  <palves@redhat.com>
3071
3072         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
3073         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
3074         'want_trampoline' parameter by a lookup_msym_prefer parameter.
3075         Handle it.
3076         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
3077         (lookup_minimal_symbol_by_pc): Adjust.
3078         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
3079         (lookup_solib_trampoline_symbol_by_pc): Adjust.
3080         * minsyms.h (lookup_msym_prefer): New enum.
3081         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3082         parameter by a lookup_msym_prefer parameter.
3083
3084 2018-04-26  Pedro Alves  <palves@redhat.com>
3085
3086         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
3087         ends in "@plt" instead of looking at the symbol's section.
3088
3089 2018-04-26  Pedro Alves  <palves@redhat.com>
3090
3091         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
3092         all references.
3093         (find_pc_partial_function_gnu_ifunc): Rename to ...
3094         (find_pc_partial_function): ... this, and remove references to
3095         'is_gnu_ifunc_p'.
3096         (find_pc_partial_function): Delete old implementation.
3097         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
3098
3099 2018-04-26  Pedro Alves  <palves@redhat.com>
3100
3101         * linespec.c (struct bound_minimal_symbol_search_key): New.
3102         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
3103         skip first line if we found a GNU ifunc minimal symbol by name.
3104         (compare_msymbols): Change parameters to work with a destructured
3105         lhs minsym.
3106         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
3107         functions.
3108
3109 2018-04-26  Pedro Alves  <palves@redhat.com>
3110
3111         * breakpoint.c (set_breakpoint_location_function): Don't resolve
3112         ifunc targets here.  Instead, if we have an ifunc minsym, use its
3113         address/name.
3114         (add_location_to_breakpoint): Store the minsym and the objfile in
3115         the breakpoint location.
3116         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
3117         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
3118         Record the minsym in the sal.
3119         * symtab.h (symtab_and_line) <msymbol>: New field.
3120
3121 2018-04-26  Pedro Alves  <palves@redhat.com>
3122
3123         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
3124         unless we actually resolved the ifunc.
3125
3126 2018-04-26  Pedro Alves  <palves@redhat.com>
3127
3128         * c-exp.y (variable production): Prefer ifunc minsyms over
3129         regular function symbols.
3130         * symtab.c (find_gnu_ifunc): New function.
3131         * minsyms.h (lookup_msym_prefer): New enum.
3132         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3133         parameter by a lookup_msym_prefer parameter.
3134         * symtab.h (find_gnu_ifunc): New declaration.
3135
3136 2018-04-26  Pedro Alves  <palves@redhat.com>
3137
3138         * blockframe.c (find_gnu_ifunc_target_type): New function.
3139         (find_function_type): New.
3140         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
3141         return a value with a memory address.
3142         (eval_call): For calls to GNU ifunc functions, try to find the
3143         type of the target function from the type that the resolver
3144         returns.
3145         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
3146         symbols.
3147         * infcall.c (find_function_return_type): Delete.
3148         (find_function_addr): Add 'function_type' parameter.  For calls to
3149         GNU ifunc functions, try to find the type of the target function
3150         from the type that the resolver returns, and return it via
3151         FUNCTION_TYPE.
3152         (call_function_by_hand_dummy): Adjust to use the function type
3153         returned by find_function_addr.
3154         (find_function_addr): Add 'function_type' parameter and move
3155         description here.
3156         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
3157         declarations.
3158
3159 2018-04-26  Pedro Alves  <palves@redhat.com>
3160
3161         * c-exp.y (variable production): Skip finding an alias for ifunc
3162         symbols.
3163
3164 2018-04-26  Pedro Alves  <palves@redhat.com>
3165
3166         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
3167
3168 2018-04-25  Pedro Alves  <palves@redhat.com>
3169
3170         * infcmd.c (kill_command): Print the pid as string, not the whole
3171         thread's ptid.  Add comment.  s/has been killed/killed/ in output
3172         message.
3173         * remote.c (remote_detach_1): Print the pid as string, not the
3174         whole thread's ptid.
3175
3176 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
3177             Sergio Durigan Junior  <sergiodj@redhat.com>
3178             Pedro Alves  <palves@redhat.com>
3179
3180         * infcmd.c (kill_command): Print message when inferior has
3181         been killed.
3182         * inferior.c (print_inferior_events): Remove 'static'.  Set as
3183         '1'.
3184         (add_inferior): Improve message printed when
3185         'print_inferior_events' is on.
3186         (exit_inferior): Remove message printed when
3187         'print_inferior_events' is on.
3188         (detach_inferior): Improve message printed when
3189         'print_inferior_events' is on.
3190         (initialize_inferiors): Use 'add_inferior_silent' to set
3191         'current_inferior_'.
3192         * inferior.h (print_inferior_events): Declare here as
3193         'extern'.
3194         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
3195         '[Detaching...]' messages when 'print_inferior_events' is on.
3196         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
3197         as prefix/suffix for messages.  Remove periods.  Fix erroneous
3198         'Detaching after fork from child...', replace it by '... from
3199         parent...'.
3200         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
3201         prefix/suffix when printing 'Detaching...' messages.  Print
3202         them when 'print_inferior_events' is on.
3203         * remote.c (remote_detach_1): Print message when detaching
3204         from inferior and '!is_fork_parent'.
3205
3206 2018-04-24  Tom Tromey  <tom@tromey.com>
3207
3208         * cli-out.h: Reindent.
3209
3210 2018-04-24  Tom Tromey  <tom@tromey.com>
3211
3212         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
3213         (cli_ui_out::do_field_string): Use fputs_filtered.
3214         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
3215
3216 2018-04-23  Tom Tromey  <tom@tromey.com>
3217
3218         * guile/scm-frame.c (gdbscm_frame_read_var): Use
3219         gdb::unique_xmalloc_ptr.
3220
3221 2018-04-23  Tom Tromey  <tom@tromey.com>
3222
3223         * configure: Rebuild.
3224
3225 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
3226
3227         PR gdb/23095
3228         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
3229         prepare_for_testing.  Set normal_bp to r_debug_state if target
3230         is bsd.
3231
3232 2018-04-21  Pedro Alves  <palves@redhat.com>
3233             Rajendra SY  <rajendra.sy@gmail.com>
3234
3235         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
3236         * remote.c (extended_remote_attach): In all-stop mode, mark the
3237         thread as executing.
3238
3239 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3240
3241         * thread.c (thread_apply_all_command): Fix comment.
3242         (thread_command): Fix comment.
3243
3244 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
3245
3246         * common/tdesc.h (tdesc_create_feature): Remove xml filename
3247         parameter.
3248         * features/aarch64-core.c (create_feature_aarch64_core):
3249         Regenerate.
3250         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
3251         Likewise.
3252         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
3253         Likewise.
3254         * features/i386/32bit-avx512.c
3255         (create_feature_i386_32bit_avx512): Likewise.
3256         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
3257         Likewise.
3258         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
3259         Likewise.
3260         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
3261         Likewise.
3262         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
3263         Likewise.
3264         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
3265         Likewise.
3266         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
3267         Likewise.
3268         * features/i386/64bit-avx512.c
3269         (create_feature_i386_64bit_avx512): Likewise.
3270         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
3271         Likewise.
3272         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
3273         Likewise.
3274         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
3275         Likewise.
3276         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
3277         Likewise.
3278         * features/i386/64bit-segments.c
3279         (create_feature_i386_64bit_segments): Likewise.
3280         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
3281         Likewise.
3282         * features/i386/x32-core.c
3283         (create_feature_i386_x32_core): Likewise.
3284         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
3285         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
3286         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
3287         * target-descriptions.c: In generated code, don't pass xml
3288         filename.
3289
3290 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3291
3292         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
3293         (print_xml_feature::visit_post): Likewise.
3294         (print_xml_feature::visit): Likewise.
3295         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
3296         (print_xml_feature): Add new class.
3297         * regformats/regdat.sh: Null xmltarget on feature targets.
3298         * target-descriptions.c (struct target_desc): Add xmltarget.
3299         (maintenance_check_tdesc_xml_convert): Add unittest function.
3300         (tdesc_get_features_xml): Add function to get xml.
3301         (maintenance_check_xml_descriptions): Test xml generation.
3302         * xml-tdesc.c (string_read_description_xml): Add function.
3303         * xml-tdesc.h (string_read_description_xml): Add declaration.
3304
3305 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3306
3307         * features/Makefile: Add feature marker to targets with new style
3308         target descriptions.
3309         * regformats/aarch64.dat: Regenerate.
3310         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
3311         * regformats/i386/amd64-avx-linux.dat: Likewise.
3312         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
3313         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
3314         * regformats/i386/amd64-linux.dat: Likewise.
3315         * regformats/i386/amd64-mpx-linux.dat: Likewise.
3316         * regformats/i386/amd64.dat: Likewise.
3317         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
3318         * regformats/i386/i386-avx-linux.dat: Likewise.
3319         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
3320         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
3321         * regformats/i386/i386-linux.dat: Likewise.
3322         * regformats/i386/i386-mmx-linux.dat: Likewise.
3323         * regformats/i386/i386-mpx-linux.dat: Likewise.
3324         * regformats/i386/i386.dat: Likewise.
3325         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
3326         * regformats/i386/x32-avx-linux.dat: Likewise.
3327         * regformats/i386/x32-linux.dat: Likewise.
3328         * regformats/tic6x-c62x-linux.dat: Likewise.
3329         * regformats/tic6x-c64x-linux.dat: Likewise.
3330         * regformats/tic6x-c64xp-linux.dat: Likewise.
3331         * regformats/regdat.sh: Parse feature marker.
3332
3333 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3334
3335         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
3336         (tdesc_osabi_name): Likewise.
3337         * target-descriptions.c (tdesc_architecture_name): Add new
3338         function.
3339         (tdesc_osabi_name): Likewise.
3340
3341 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3342
3343         * common/tdesc.c (tdesc_predefined_type): Move to here.
3344         (tdesc_named_type): Likewise.
3345         (tdesc_create_vector): Likewise.
3346         (tdesc_create_struct): Likewise.
3347         (tdesc_set_struct_size): Likewise.
3348         (tdesc_create_union): Likewise.
3349         (tdesc_create_flags): Likewise.
3350         (tdesc_create_enum): Likewise.
3351         (tdesc_add_field): Likewise.
3352         (tdesc_add_typed_bitfield): Likewise.
3353         (tdesc_add_bitfield): Likewise.
3354         (tdesc_add_flag): Likewise.
3355         (tdesc_add_enum_value): Likewise.
3356         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
3357         (struct tdesc_type_vector): Likewise.
3358         (struct tdesc_type_field): Likewise.
3359         (struct tdesc_type_with_fields): Likewise.
3360         (tdesc_create_enum): Add declaration.
3361         (tdesc_add_typed_bitfield): Likewise.
3362         (tdesc_add_enum_value): Likewise.
3363         * target-descriptions.c (tdesc_type_field): Move from here.
3364         (tdesc_type_builtin): Likewise.
3365         (tdesc_type_vector): Likewise.
3366         (tdesc_type_with_fields): Likewise.
3367         (tdesc_predefined_types): Likewise.
3368         (tdesc_named_type): Likewise.
3369         (tdesc_create_vector): Likewise.
3370         (tdesc_create_struct): Likewise.
3371         (tdesc_set_struct_size): Likewise.
3372         (tdesc_create_union): Likewise.
3373         (tdesc_create_flags): Likewise.
3374         (tdesc_create_enum): Likewise.
3375         (tdesc_add_field): Likewise.
3376         (tdesc_add_typed_bitfield): Likewise.
3377         (tdesc_add_bitfield): Likewise.
3378         (tdesc_add_flag): Likewise.
3379         (tdesc_add_enum_value): Likewise.
3380         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
3381         (tdesc_add_typed_bitfield): Likewise.
3382         (tdesc_add_enum_value): Likewise.
3383
3384 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3385
3386         * common/tdesc.c (tdesc_feature::accept): Move to here.
3387         (tdesc_feature::operator==): Likewise.
3388         (tdesc_create_reg): Likewise.
3389         * common/tdesc.h (tdesc_type_kind): Likewise.
3390         (struct tdesc_type): Likewise.
3391         (struct tdesc_feature): Likewise.
3392         * regformats/regdat.sh: Create a feature.
3393         * target-descriptions.c (tdesc_type_kind): Move from here.
3394         (tdesc_type): Likewise.
3395         (tdesc_type_up): Likewise.
3396         (tdesc_feature): Likewise.
3397         (tdesc_create_reg): Likewise.
3398
3399 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3400
3401         * Makefile.in: Add arch/tdesc.c
3402         * common/tdesc.c: New file.
3403         * common/tdesc.h (tdesc_element_visitor): Move to here.
3404         (tdesc_element): Likewise.
3405         (tdesc_reg): Likewise.
3406         (tdesc_reg_up): Likewise.
3407         * regformats/regdef.h (reg): Add offset to constructors.
3408         * target-descriptions.c (tdesc_element_visitor): Move from here.
3409         (tdesc_element): Likewise.
3410         (tdesc_reg): Likewise.
3411         (tdesc_reg_up): Likewise.
3412
3413 2018-04-17  Tom Tromey  <tom@tromey.com>
3414
3415         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
3416         discriminant field.
3417
3418 2018-04-17  Tom Tromey  <tom@tromey.com>
3419
3420         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
3421
3422 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3423
3424         * symtab.c (print_symbol_info): Skip printing filename and line
3425         number when `last' is NULL.
3426         (symtab_symbol_info): Use empty string instead of NULL for first
3427         invocation of print_symbol_info.
3428         (rbreak_command): Pass NULL to `last' parameter of
3429         print_symbol_info.
3430
3431 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
3432
3433         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
3434         instead of nullptr.
3435
3436 2018-04-16  Pedro Alves  <palves@redhat.com>
3437
3438         * MAINTAINERS (sh): Remove.
3439         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
3440         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
3441         (ALLDEPFILES): Remove sh64-tdep.c.
3442         * NEWS: Mentions that support for SH-5/SH64 is removed.
3443         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
3444         (sh*-*-openbsd*): Ditto.
3445         (sh64-*-elf*): Remove.
3446         (sh*): Remove.
3447         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
3448         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
3449         * sh-tdep.c: No longer include "sh64-tdep.h".
3450         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
3451         * sh64-tdep.c, sh64-tdep.h: Remove files.
3452
3453 2018-04-16  Pedro Alves  <palves@redhat.com>
3454
3455         * MAINTAINERS: Remove m88k.
3456         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
3457         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
3458         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
3459         * NEWS: Mention that support for m88k was removed.
3460         * configure.host (m88*-*-*): Remove support.
3461         * configure.nat (m88k-*-*): Remove support.
3462         * configure.tgt (m88*-*-openbsd*): Remove.
3463         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
3464
3465 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
3466
3467         * configure.tgt (x86_tobjs): New variable.
3468         (amd64_tobjs, i386_tobjs): Use it.
3469
3470 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3471
3472         * symtab.c (print_symbol_info): Precede the symbol definition by
3473         the line number when available.
3474         * NEWS: Advertise this enhancement.
3475
3476 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3477
3478         * NEWS (New options): announce set/show record btrace cpu.
3479         * btrace.c: Include record-btrace.h.
3480         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
3481         the vendor is unknown.
3482         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
3483         Maybe overwrite the btrace configuration's cpu.
3484         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
3485         (btrace_fetch): Add cpu parameter.  Update callers.
3486         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
3487         Maybe overwrite the btrace configuration's cpu.  Skip enabling
3488         errata workarounds if the vendor is unknown.
3489         * python/py-record-btrace.c: Include record-btrace.h.
3490         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
3491         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
3492         * record-btrace.c (record_btrace_cpu_state_kind): New.
3493         (record_btrace_cpu): New.
3494         (set_record_btrace_cpu_cmdlist): New.
3495         (record_btrace_get_cpu): New.
3496         (require_btrace_thread, record_btrace_info)
3497         (record_btrace_resume_thread): Call record_btrace_get_cpu.
3498         (cmd_set_record_btrace_cpu_none): New.
3499         (cmd_set_record_btrace_cpu_auto): New.
3500         (cmd_set_record_btrace_cpu): New.
3501         (cmd_show_record_btrace_cpu): New.
3502         (_initialize_record_btrace): Initialize set/show record btrace cpu
3503         commands.
3504         * record-btrace.h (record_btrace_get_cpu): New.
3505
3506 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3507
3508         * record.c (set_record_command): Fix typo in message.
3509
3510 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3511
3512         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
3513
3514 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3515
3516         * infrun.c (process_event_stop_test): Call
3517         gdbarch_in_indirect_branch_thunk.
3518         * gdbarch.sh (in_indirect_branch_thunk): New.
3519         * gdbarch.c: Regenerated.
3520         * gdbarch.h: Regenerated.
3521         * x86-tdep.h: New.
3522         * x86-tdep.c: New.
3523         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
3524         (HFILES_NO_SRCDIR): Add x86-tdep.h.
3525         (ALLDEPFILES): Add x86-tdep.c.
3526         * arch-utils.h (default_in_indirect_branch_thunk): New.
3527         * arch-utils.c (default_in_indirect_branch_thunk): New.
3528         * i386-tdep: Include x86-tdep.h.
3529         (i386_in_indirect_branch_thunk): New.
3530         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
3531         function.
3532         * amd64-tdep: Include x86-tdep.h.
3533         (amd64_in_indirect_branch_thunk): New.
3534         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
3535
3536 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
3537
3538         PR gdb/23053
3539         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
3540         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
3541         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
3542         regression.
3543
3544 2018-04-12  Tom Tromey  <tom@tromey.com>
3545
3546         * rust-lang.c (rust_print_struct_def): Remove univariant code.
3547         (rust_evaluate_subexp): Likewise.
3548
3549 2018-04-12  Pedro Alves  <palves@redhat.com>
3550
3551         * procfs.c (procfs_detach): Make forward declaration's prototype
3552         match definition's protototype.
3553         (proc_get_LDT_entry): Remove stale do_cleanups call.
3554
3555 2018-04-12  Pedro Alves  <palves@redhat.com>
3556
3557         * target.h (target_ops::to_has_exited): Delete.
3558         (target_has_exited): Delete.
3559         * target-delegates.c: Regenerate.
3560
3561 2018-04-11  Pedro Alves  <palves@redhat.com>
3562
3563         * target.c (fileio_fh_t::t): Add comment.
3564         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3565         (target_fileio_close): Handle a NULL target.
3566         (invalidate_fileio_fh): New.
3567         (target_close): Call it.
3568         * remote.c (remote_hostio_send_command): No longer check whether
3569         remote_desc is open.
3570
3571 2018-04-11  Pedro Alves  <palves@redhat.com>
3572
3573         * target.c (fileio_fh_t): Make it a named struct instead of a
3574         typedef.
3575         (fileio_fh_t::is_closed): New method.
3576         (DEF_VEC_O (fileio_fh_t)): Remove.
3577         (fileio_fhandles): Now a std::vector.
3578         (is_closed_fileio_fh): Delete.
3579         (acquire_fileio_fd): Adjust.  Rename parameters.
3580         (release_fileio_fd): Adjust.
3581         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
3582         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3583         (target_fileio_close): Adjust.
3584
3585 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
3586
3587         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
3588         index.
3589
3590 2018-04-10  Pedro Alves  <palves@redhat.com>
3591
3592         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
3593         (scoped_finish_thread_state): New class.
3594         * infcmd.c (run_command_1): Use it instead of finish_thread_state
3595         cleanup.
3596         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
3597         (fetch_inferior_event, normal_stop): Likewise.
3598         * thread.c (finish_thread_state_cleanup): Delete.
3599
3600 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3601             Pedro Alves  <palves@redhat.com>
3602
3603         * value.c: Include "selftest.h" and "common/array-view.h".
3604         (struct range) <operator ==>: New.
3605         (test_ranges_contain): New.
3606         (check_ranges_vector): New.
3607         (test_insert_into_bit_range_vector): New.
3608         (_initialize_values): Register selftests.
3609         * common/array-view.h (operator==, operator!=): New.
3610
3611 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3612
3613         * common/gdb_vecs.h (unordered_remove): Add overload that takes
3614         an iterator.
3615         * inline-frame.c: Include <algorithm>.
3616         (struct inline_state): Add constructor.
3617         (inline_state_s): Remove.
3618         (DEF_VEC_O(inline_state_s)): Remove.
3619         (inline_states): Change type to std::vector.
3620         (find_inline_frame_state): Adjust to std::vector.
3621         (allocate_inline_frame_state): Remove.
3622         (clear_inline_frame_state): Adjust to std::vector.
3623         (skip_inline_frames): Adjust to std::vector.
3624
3625 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3626
3627         * tracepoint.h (struct trace_state_variable): Add constructor.
3628         <name>: Change type to std::string.
3629         * tracepoint.c (tsv_s): Remove.
3630         (DEF_VEC_O(tsv_s)): Remove.
3631         (tvariables): Change to std::vector.
3632         (create_trace_state_variable): Adjust to std::vector.
3633         (find_trace_state_variable): Likewise.
3634         (find_trace_state_variable_by_number): Likewise.
3635         (delete_trace_state_variable): Likewise.
3636         (trace_variable_command): Adjust to std::string.
3637         (delete_trace_variable_command): Likewise.
3638         (tvariables_info_1): Adjust to std::vector.
3639         (save_trace_state_variables): Likewise.
3640         (start_tracing): Likewise.
3641         (merge_uploaded_trace_state_variables): Adjust to std::vector
3642         and std::string.
3643         * target.h (struct target_ops)
3644         <to_download_trace_state_variable>: Pass reference to
3645         trace_state_variable.
3646         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
3647         * target-delegates.c: Re-generate.
3648         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
3649         (mi_tsv_deleted): Likewise.
3650         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
3651         * remote.c (remote_download_trace_state_variable): Change
3652         pointer to reference and adjust.
3653         * make-target-delegates (parse_argtypes): Handle references.
3654         (write_function_header): Likewise.
3655         (munge_type): Likewise.
3656
3657 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3658
3659         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3660         string_view-selftests.c.
3661         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
3662         testsuite.
3663         * unittests/basic_string_view/cons/char/1.cc: Likewise.
3664         * unittests/basic_string_view/cons/char/2.cc: Likewise.
3665         * unittests/basic_string_view/cons/char/3.cc: Likewise.
3666         * unittests/basic_string_view/element_access/char/1.cc:
3667         Likewise.
3668         * unittests/basic_string_view/element_access/char/empty.cc:
3669         Likewise.
3670         * unittests/basic_string_view/element_access/char/front_back.cc:
3671         Likewise.
3672         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
3673         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
3674         Likewise.
3675         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
3676         Likewise.
3677         * unittests/basic_string_view/modifiers/swap/char/1.cc:
3678         Likewise.
3679         * unittests/basic_string_view/operations/compare/char/1.cc:
3680         Likewise.
3681         * unittests/basic_string_view/operations/compare/char/13650.cc:
3682         Likewise.
3683         * unittests/basic_string_view/operations/copy/char/1.cc:
3684         Likewise.
3685         * unittests/basic_string_view/operations/data/char/1.cc:
3686         Likewise.
3687         * unittests/basic_string_view/operations/find/char/1.cc:
3688         Likewise.
3689         * unittests/basic_string_view/operations/find/char/2.cc:
3690         Likewise.
3691         * unittests/basic_string_view/operations/find/char/3.cc:
3692         Likewise.
3693         * unittests/basic_string_view/operations/find/char/4.cc:
3694         Likewise.
3695         * unittests/basic_string_view/operations/rfind/char/1.cc:
3696         Likewise.
3697         * unittests/basic_string_view/operations/rfind/char/2.cc:
3698         Likewise.
3699         * unittests/basic_string_view/operations/rfind/char/3.cc:
3700         Likewise.
3701         * unittests/basic_string_view/operations/substr/char/1.cc:
3702         Likewise.
3703         * unittests/basic_string_view/operators/char/2.cc: Likewise.
3704         * unittests/string_view-selftests.c: New file.
3705
3706 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3707
3708         * unittests/basic_string_view/capacity/1.cc: New file.
3709         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
3710         * unittests/basic_string_view/cons/char/1.cc: New file.
3711         * unittests/basic_string_view/cons/char/2.cc: New file.
3712         * unittests/basic_string_view/cons/char/3.cc: New file.
3713         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
3714         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
3715         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
3716         * unittests/basic_string_view/element_access/char/1.cc: New file.
3717         * unittests/basic_string_view/element_access/char/2.cc: New file.
3718         * unittests/basic_string_view/element_access/char/empty.cc: New file.
3719         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
3720         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
3721         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
3722         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
3723         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
3724         * unittests/basic_string_view/include.cc: New file.
3725         * unittests/basic_string_view/inserters/char/1.cc: New file.
3726         * unittests/basic_string_view/inserters/char/2.cc: New file.
3727         * unittests/basic_string_view/inserters/char/3.cc: New file.
3728         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
3729         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
3730         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
3731         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
3732         * unittests/basic_string_view/literals/types.cc: New file.
3733         * unittests/basic_string_view/literals/values.cc: New file.
3734         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
3735         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
3736         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
3737         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
3738         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
3739         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
3740         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
3741         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
3742         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
3743         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
3744         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
3745         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
3746         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
3747         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
3748         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
3749         * unittests/basic_string_view/operations/data/char/1.cc: New file.
3750         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
3751         * unittests/basic_string_view/operations/find/char/1.cc: New file.
3752         * unittests/basic_string_view/operations/find/char/2.cc: New file.
3753         * unittests/basic_string_view/operations/find/char/3.cc: New file.
3754         * unittests/basic_string_view/operations/find/char/4.cc: New file.
3755         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
3756         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
3757         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
3758         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
3759         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
3760         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
3761         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
3762         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
3763         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
3764         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
3765         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
3766         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
3767         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
3768         * unittests/basic_string_view/operators/char/2.cc: New file.
3769         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
3770         * unittests/basic_string_view/range_access/char/1.cc: New file.
3771         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
3772         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
3773         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
3774         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
3775         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
3776         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
3777         * unittests/basic_string_view/requirements/typedefs.cc: New file.
3778         * unittests/basic_string_view/typedefs.cc: New file.
3779         * unittests/basic_string_view/types/1.cc: New file.
3780
3781 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3782
3783         * common/gdb_string_view.h: Remove libstdc++ implementation
3784         details, adjust to gdb reality.
3785         * common/gdb_string_view.tcc: Likewise.
3786         * cli/cli-script.c (struct string_view): Remove.
3787         (user_args) <m_args>: Change element type to gdb::string_view.
3788         (user_args::insert_args): Adjust.
3789
3790 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3791
3792         * common/gdb_string_view.h: New file.
3793         * common/gdb_string_view.tcc: New file.
3794
3795 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3796
3797         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
3798         * configure: Re-generate.
3799
3800 2018-04-09  Pedro Alves  <palves@redhat.com>
3801
3802         * gdbarch.sh: Include "observable.h" instead of "observer.h".
3803         (set_target_gdbarch): Call
3804         gdb::observers::architecture_changed.notify instead of
3805         observer_notify_architecture_changed.
3806
3807 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3808
3809         * tracepoint.c (struct current_traceframe_cleanup): Remove.
3810         (do_restore_current_traceframe_cleanup): Remove.
3811         (restore_current_traceframe_cleanup_dtor): Remove.
3812         (make_cleanup_restore_current_traceframe): Remove.
3813         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
3814         New.
3815         * tracepoint.h (struct scoped_restore_current_traceframe): New.
3816         * infrun.c (fetch_inferior_event): Use
3817         scoped_restore_current_traceframe.
3818
3819 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3820
3821         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
3822         Remove.
3823         <n_allocated_type_units>: Remove.
3824         <all_type_units>: Change to std::vector.
3825         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3826         to std::vector change.
3827         (dwarf2_per_objfile::get_cutu): Likewise.
3828         (dwarf2_per_objfile::get_tu): Likewise.
3829         (create_signatured_type_table_from_index): Likewise.
3830         (create_signatured_type_table_from_debug_names): Likewise.
3831         (dw2_symtab_iter_next): Likewise.
3832         (dw2_print_stats): Likewise.
3833         (dw2_expand_all_symtabs): Likewise.
3834         (dw2_expand_marked_cus): Likewise.
3835         (dw2_debug_names_iterator::next): Likewise.
3836         (dwarf2_initialize_objfile): Likewise.
3837         (add_signatured_type_cu_to_table): Likewise.
3838         (create_all_type_units): Likewise.
3839         (add_type_unit): Likewise.
3840         (struct tu_abbrev_offset): Add constructor.
3841         (build_type_psymtabs_1): Adjust to std::vector change.
3842         (print_tu_stats): Likewise.
3843         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3844         (write_debug_names): Likewise.
3845
3846 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3847
3848         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
3849         Make an std::vector.
3850         <n_comp_units>: Remove.
3851         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3852         to std::vector change.
3853         (dwarf2_per_objfile::get_cutu): Likewise.
3854         (dwarf2_per_objfile::get_cu): Likewise.
3855         (create_cus_from_index): Likewise.
3856         (create_addrmap_from_index): Likewise.
3857         (create_addrmap_from_aranges): Likewise.
3858         (dwarf2_read_index): Likewise.
3859         (dw2_find_last_source_symtab): Likewise.
3860         (dw2_map_symtabs_matching_filename): Likewise.
3861         (dw2_symtab_iter_next): Likewise.
3862         (dw2_print_stats): Likewise.
3863         (dw2_expand_all_symtabs): Likewise.
3864         (dw2_expand_symtabs_with_fullname): Likewise.
3865         (dw2_expand_marked_cus): Likewise.
3866         (dw2_map_symbol_filenames): Likewise.
3867         (create_cus_from_debug_names): Likewise.
3868         (dwarf2_read_debug_names): Likewise.
3869         (dw2_debug_names_iterator::next): Likewise.
3870         (dwarf2_initialize_objfile): Likewise.
3871         (set_partial_user): Likewise.
3872         (dwarf2_build_psymtabs_hard): Likewise.
3873         (read_comp_units_from_section): Remove arguments, adjust to
3874         std::vector change.
3875         (create_all_comp_units): Adjust to std::vector and
3876         read_comp_units_from_section changes.
3877         (dwarf2_find_containing_comp_unit): Adjust to std::vector
3878         change.
3879         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3880         (psyms_seen_size): Likewise.
3881         (write_gdbindex): Likewise.
3882         (write_debug_names): Likewise.
3883
3884 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3885
3886         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
3887         with dwarf2_per_objfile.
3888         (create_cus_from_index): Likewise.
3889         (create_signatured_type_table_from_index): Likewise.
3890         (dwarf2_read_index): Likewise.
3891         (dwarf2_initialize_objfile): Likewise.
3892         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
3893         per_cu rather than get_dwarf2_per_objfile.
3894
3895 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3896
3897         * dwarf2read.h (struct signatured_type): Forward declare.
3898         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
3899         New methods.
3900         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
3901         (dw2_get_cutu): ...this.
3902         (dwarf2_per_objfile::get_cu): Rename from...
3903         (dw2_get_cu): ...this.
3904         (dwarf2_per_objfile::get_tu): New.
3905         (create_addrmap_from_index): Adjust.
3906         (create_addrmap_from_aranges): Adjust.
3907         (dw2_find_last_source_symtab): Adjust.
3908         (dw2_map_symtabs_matching_filename): Adjust.
3909         (dw2_symtab_iter_next): Adjust.
3910         (dw2_print_stats): Adjust.
3911         (dw2_expand_all_symtabs): Adjust.
3912         (dw2_expand_symtabs_with_fullname): Adjust.
3913         (dw2_expand_marked_cus): Adjust.
3914         (dw_expand_symtabs_matching_file_matcher): Adjust.
3915         (dw2_map_symbol_filenames): Adjust.
3916         (dw2_debug_names_iterator::next): Adjust.
3917         (dwarf2_initialize_objfile): Adjust.
3918         (set_partial_user): Adjust.
3919         (dwarf2_build_psymtabs_hard): Adjust.
3920
3921 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3922
3923         * dwarf2read.c (create_signatured_type_table_from_debug_names):
3924         Remove unused variables.
3925         (dw2_map_symtabs_matching_filename): Likewise.
3926         (dwarf2_record_block_ranges): Likewise.
3927         (dwarf2_read_addr_index): Likewise.
3928         (follow_die_offset): Likewise.
3929
3930 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3931
3932         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
3933         to symbol_file_add_main.
3934
3935 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3936
3937         PR mi/22299
3938         * mi/mi-console.c (do_fputc_async_safe): New.
3939         (mi_console_file::write_async_safe): New.
3940         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
3941         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
3942         New.
3943         * ui-file.c (ui_file::putstrn): Adjust call to
3944         fputstrn_unfiltered.
3945         * utils.c (printchar): Replace do_fputs and do_fprintf
3946         parameters by do_fputc.
3947         (fputstr_filtered): Adjust call to printchar.
3948         (fputstr_unfiltered): Likewise.
3949         (fputstrn_filtered): Likewise.
3950         (fputstrn_unfiltered): Add do_fputc parameter, pass to
3951         printchar.
3952         * utils.h (do_fputc_ftype): New typedef.
3953         (fputstrn_unfiltered): Add do_fputc parameter.
3954
3955 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3956
3957         * regformats/i386/i386-avx.dat: Remove.
3958
3959 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3960
3961         PR gdb/22979
3962         * amd64-tdep.c (amd64_none_init_abi): New function.
3963         (amd64_x32_none_init_abi): New function.
3964         (_initialize_amd64_tdep): Register handlers for x86-64 and
3965         x64_32 with GDB_OSABI_NONE.
3966         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
3967         GDB_OSABI_NONE osabi.
3968
3969 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3970
3971         PR gdb/22980
3972         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
3973         GDB_OSABI_NONE.
3974         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
3975         * osabi.c (gdb_osabi_names): Add "unknown" entry.
3976
3977 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3978
3979         * common/byte-vector.h (char_vector): New type.
3980         * target.h (target_read_alloc): Return
3981         gdb::optional<byte_vector>.
3982         (target_read_stralloc): Return gdb::optional<char_vector>.
3983         (target_get_osdata): Return gdb::optional<char_vector>.
3984         * target.c (target_read_alloc_1): Templatize.  Replacement
3985         manual memory management with vector.
3986         (target_read_alloc): Change return type, adjust.
3987         (target_read_stralloc): Change return type, adjust.
3988         (target_get_osdata): Change return type, adjust.
3989         * auxv.c (struct auxv_info) <length>: Remove.
3990         <data>: Change type to gdb::optional<byte_vector>.
3991         (auxv_inferior_data_cleanup): Free auxv_info with delete.
3992         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
3993         (target_auxv_search): Adjust.
3994         (fprint_target_auxv): Adjust.
3995         * avr-tdep.c (avr_io_reg_read_command): Adjust.
3996         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
3997         (linux_make_corefile_notes): Adjust.
3998         * osdata.c (get_osdata): Adjust.
3999         * remote.c (remote_get_threads_with_qxfer): Adjust.
4000         (remote_memory_map): Adjust.
4001         (remote_traceframe_info): Adjust.
4002         (btrace_read_config): Adjust.
4003         (remote_read_btrace): Adjust.
4004         (remote_pid_to_exec_file): Adjust.
4005         * solib-aix.c (solib_aix_get_library_list): Adjust.
4006         * solib-dsbt.c (decode_loadmap): Don't free buf.
4007         (dsbt_get_initial_loadmaps): Adjust.
4008         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
4009         * solib-target.c (solib_target_current_sos): Adjust.
4010         * tracepoint.c (sdata_make_value): Adjust.
4011         * xml-support.c (xinclude_start_include): Adjust.
4012         (xml_fetch_content_from_file): Adjust.
4013         * xml-support.h (xml_fetch_another): Change return type.
4014         (xml_fetch_content_from_file): Change return type.
4015         * xml-syscall.c (xml_init_syscalls_info): Adjust.
4016         * xml-tdesc.c (file_read_description_xml): Adjust.
4017         (fetch_available_features_from_target): Change return type.
4018         (target_fetch_description_xml): Adjust.
4019         (target_read_description_xml): Adjust.
4020
4021 2018-04-06  Tom Tromey  <tom@tromey.com>
4022
4023         * value.c (~value): Update.
4024         (struct value) <contents>: Now unique_xmalloc_ptr.
4025         (value_contents_bits_eq, allocate_value_contents)
4026         (value_contents_raw, value_contents_all_raw)
4027         (value_contents_for_printing, value_contents_for_printing_const)
4028         (set_value_enclosing_type): Update.
4029
4030 2018-04-06  Tom Tromey  <tom@tromey.com>
4031
4032         * value.c (range_s): Remove typedef, VEC.
4033         (struct range): Add operator<.
4034         (range_lessthan): Remove.
4035         (ranges_contain): Change type.
4036         (~value): Update.
4037         (struct value) <unavailable, optimized_out>: Now std::vector.
4038         (value_entirely_available)
4039         (value_entirely_covered_by_range_vector)
4040         (value_entirely_unavailable, value_entirely_optimized_out):
4041         Update.
4042         (insert_into_bit_range_vector): Change argument type.
4043         (find_first_range_overlap): Likewise.
4044         (struct ranges_and_idx, value_contents_bits_eq)
4045         (require_not_optimized_out, require_available): Update.
4046         (ranges_copy_adjusted): Change argument types.
4047         (value_optimized_out, value_copy, value_fetch_lazy): Update.
4048
4049 2018-04-06  Tom Tromey  <tom@tromey.com>
4050
4051         * value.c (~value): Update.
4052         (struct value) <parent>: Now a value_ref_ptr.
4053         (value_parent, set_value_parent, value_address, value_copy):
4054         Update.
4055
4056 2018-04-06  Tom Tromey  <tom@tromey.com>
4057
4058         * value.c (struct value): Add constructor, destructor, and member
4059         initializers.
4060         (allocate_value_lazy, value_decref): Update.
4061
4062 2018-04-06  Tom Tromey  <tom@tromey.com>
4063
4064         * value.c (struct value) <released, next>: Remove.
4065         (all_values): Now a std::vector.
4066         (allocate_value_lazy): Update.
4067         (value_next): Remove.
4068         (value_mark, value_free_to_mark, release_value)
4069         (value_release_to_mark): Update.
4070
4071 2018-04-06  Tom Tromey  <tom@tromey.com>
4072
4073         * value.h (fetch_subexp_value, value_release_to_mark): Update.
4074         (free_value_chain): Remove.
4075         * value.c (free_value_chain): Remove.
4076         (value_release_to_mark): Return a std::vector.
4077         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
4078         std::vector.
4079         (check_condition): Update.
4080         * eval.c (fetch_subexp_value): Change "val_chain" to a
4081         std::vector.
4082         * breakpoint.c (update_watchpoint): Update.
4083         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
4084
4085 2018-04-06  Tom Tromey  <tom@tromey.com>
4086
4087         * value.h (free_all_values): Remove.
4088         * value.c (free_all_values): Remove.
4089
4090 2018-04-06  Tom Tromey  <tom@tromey.com>
4091
4092         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
4093         (value_history_chain, value_history_count): Remove.
4094         (value_history): New global.
4095         (record_latest_value, access_value_history, show_values)
4096         (preserve_values): Update.
4097
4098 2018-04-06  Tom Tromey  <tom@tromey.com>
4099
4100         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
4101         * varobj.c (varobj_set_display_format, varobj_set_value)
4102         (install_default_visualizer, construct_visualizer)
4103         (install_new_value, ~varobj, varobj_get_value_type)
4104         (my_value_of_variable, varobj_editable_p): Update.
4105         * c-varobj.c (c_describe_child, c_value_of_variable)
4106         (cplus_number_of_children, cplus_describe_child): Update.
4107         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
4108         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
4109         (ada_value_of_variable, ada_value_is_changeable_p): Update.
4110
4111 2018-04-06  Tom Tromey  <tom@tromey.com>
4112
4113         * printcmd.c (last_examine_address): Change type to
4114         value_ref_ptr.
4115         (do_examine, x_command): Update.
4116
4117 2018-04-06  Tom Tromey  <tom@tromey.com>
4118
4119         * value.c (release_value): Update.
4120         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
4121         (struct bpstats) <val>: Now a value_ref_ptr.
4122         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4123         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4124         (~watchpoint, print_it_watchpoint, watch_command_1)
4125         (invalidate_bp_value_on_memory_change): Update.
4126
4127 2018-04-06  Tom Tromey  <tom@tromey.com>
4128
4129         * varobj.c (varobj_clear_saved_item)
4130         (update_dynamic_varobj_children, install_new_value, ~varobj):
4131         Update.
4132         * value.h (value_incref): Move declaration earlier.
4133         (value_decref): Rename from value_free.
4134         (struct value_ref_policy): New.
4135         (value_ref_ptr): New typedef.
4136         (struct value_deleter): Remove.
4137         (gdb_value_up): Remove typedef.
4138         (release_value): Change return type.
4139         (release_value_or_incref): Remove.
4140         * value.c (set_value_parent): Update.
4141         (value_incref): Change return type.
4142         (value_decref): Rename from value_free.
4143         (value_free_to_mark, free_all_values, free_value_chain): Update.
4144         (release_value): Return value_ref_ptr.
4145         (release_value_or_incref): Remove.
4146         (record_latest_value, set_internalvar, clear_internalvar):
4147         Update.
4148         * stack.c (info_frame_command): Don't call value_free.
4149         * python/py-value.c (valpy_dealloc, valpy_new)
4150         (value_to_value_object): Update.
4151         * printcmd.c (do_examine): Update.
4152         * opencl-lang.c (lval_func_free_closure): Update.
4153         * mi/mi-main.c (register_changed_p): Don't call value_free.
4154         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
4155         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
4156         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
4157         value_free.
4158         * guile/scm-value.c (vlscm_free_value_smob)
4159         (vlscm_scm_from_value): Update.
4160         * frame.c (frame_register_unwind, frame_unwind_register_signed)
4161         (frame_unwind_register_unsigned, get_frame_register_bytes)
4162         (put_frame_register_bytes): Don't call value_free.
4163         * findvar.c (address_from_register): Don't call value_free.
4164         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
4165         * dwarf2loc.c (entry_data_value_free_closure)
4166         (value_of_dwarf_reg_entry, free_pieced_value_closure)
4167         (dwarf2_evaluate_loc_desc_full): Update.
4168         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4169         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4170         (~watchpoint, watch_command_1)
4171         (invalidate_bp_value_on_memory_change): Update.
4172         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
4173
4174 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
4175
4176         PR gdb/23022
4177         * warning.m4: Add -Wno-error=deprecated-register.
4178         * configure: Re-generate.
4179
4180 2018-04-05  Tom Tromey  <tom@tromey.com>
4181
4182         * linespec.h: Remove include of "vec.h".
4183
4184 2018-04-05  Tom Tromey  <tom@tromey.com>
4185
4186         * linespec.c (typep): Remove typedef.
4187         (find_methods, find_superclass_methods): Take a std::vector.
4188         (find_method): Use std::vector.
4189
4190 2018-04-05  Tom Tromey  <tom@tromey.com>
4191
4192         * utils.c (compare_strings): Remove.
4193         * utils.h (compare_strings): Remove.
4194         * objc-lang.h (find_imps): Update.
4195         * objc-lang.c (find_methods): Take a std::vector.
4196         (uniquify_strings, find_imps): Likewise.
4197         * linespec.c (find_methods): Take a std::vector.
4198         (decode_objc): Use std::vector.
4199         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
4200         a std::vector.
4201         (find_method, find_function_symbols): Use std::vector.
4202
4203 2018-04-05  Tom Tromey  <tom@tromey.com>
4204
4205         * completer.c (completion_tracker::completion_tracker): Remove
4206         cast.
4207         (completion_tracker::discard_completions): Likewise.
4208         * breakpoint.c (ambiguous_names_p): Remove cast.
4209         * ada-lang.c (_initialize_ada_language): Remove cast.
4210         * utils.h (streq): Update.
4211         (streq_hash): Add new declaration.
4212         * utils.c (streq): Return bool.
4213         (streq_hash): New function.
4214
4215 2018-04-05  Tom Tromey  <tom@tromey.com>
4216
4217         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
4218         Remove a string copy.
4219
4220 2018-04-05  Tom Tromey  <tom@tromey.com>
4221
4222         * linespec.c (filter_results): Use std::vector.
4223         (decode_line_2, decode_line_full): Update.
4224
4225 2018-04-05  Tom Tromey  <tom@tromey.com>
4226
4227         * linespec.c (canonical_to_fullform): Return std::string.
4228         (filter_results): Update.
4229         (struct decode_line_2_item): Add constructor.
4230         <fullform, displayform>: Now std::string.
4231         (decode_line_2_compare_items): Now a std::sort comparator.
4232         (decode_line_2): Update.
4233
4234 2018-04-05  Tom Tromey  <tom@tromey.com>
4235
4236         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
4237         (unexpected_linespec_error): Update.
4238         (linespec_parse_basic, parse_linespec): Update.
4239
4240 2018-04-05  Tom Tromey  <tom@tromey.com>
4241
4242         * linespec.c (linespec_parse_basic): Reindent.
4243
4244 2018-04-05  Tom Tromey  <tom@tromey.com>
4245
4246         * minsyms.h (iterate_over_minimal_symbols): Update.
4247         * minsyms.c (iterate_over_minimal_symbols): Take a
4248         gdb::function_view.
4249         * linespec.c (struct collect_minsyms): Remove.
4250         (compare_msyms): Now a std::sort comparator.
4251         (add_minsym): Add parameters.
4252         (search_minsyms_for_name): Update.  Use std::vector.
4253
4254 2018-04-03  Tom Tromey  <tom@tromey.com>
4255
4256         * mipsread.c (read_alphacoff_dynamic_symtab): Use
4257         gdb::byte_vector.
4258
4259 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4260
4261         * MAINTAINERS (Write After Approval): Add Weimin Pan.
4262
4263 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4264
4265         PR gdb/16959
4266         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when
4267         printing static type.
4268
4269 2018-04-01  Tom Tromey  <tom@tromey.com>
4270
4271         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
4272         (rs6000_xfer_shared_libraries): Update.
4273
4274 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4275
4276         * common/gdb_vecs.h (char_ptr): Remove.
4277         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
4278
4279 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4280
4281         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
4282         with std::vector.
4283         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
4284
4285 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4286
4287         * tracepoint.h (struct uploaded_tp): Initialize fields.
4288         <actions, step_actions, cmd_strings>: Change type to
4289         std::vector<char *>.
4290         * tracepoint.c (get_uploaded_tp): Allocate with new.
4291         (free_uploaded_tps): Free with delete.
4292         (parse_tracepoint_definition): Adjust to std::vector change.
4293         * breakpoint.c (read_uploaded_action): Likewise.
4294         (create_tracepoint_from_upload): Likewise.
4295         * ctf.c (ctf_write_uploaded_tp): Likewise.
4296         (SET_ARRAY_FIELD): Likewise.
4297         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
4298
4299 2018-03-30  Tom Tromey  <tom@tromey.com>
4300
4301         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
4302         std::unique_ptr.
4303         (svr4_keep_data_in_core): Update.
4304         (svr4_read_so_list): Update.
4305
4306 2018-03-30  Tom Tromey  <tom@tromey.com>
4307
4308         * windows-nat.c (handle_output_debug_string, handle_exception):
4309         Update.
4310         * target.h (target_read_string): Update.
4311         * target.c (target_read_string): Change "string" to
4312         unique_xmalloc_ptr.
4313         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
4314         Update.
4315         * solib-frv.c (frv_current_sos): Update.
4316         * solib-dsbt.c (dsbt_current_sos): Update.
4317         * solib-darwin.c (darwin_current_sos): Update.
4318         * linux-thread-db.c (inferior_has_bug): Update.
4319         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
4320         Update.  Remove alloca.
4321         * ada-lang.c (ada_main_name): Update.
4322
4323 2018-03-30  Tom Tromey  <tom@tromey.com>
4324
4325         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
4326         (struct dwo_file_deleter): New.
4327         (dwo_file_up): New typedef.
4328         (open_and_init_dwo_file): Use dwo_file_up.
4329         (free_dwo_file_cleanup): Remove.
4330
4331 2018-03-30  Tom Tromey  <tom@tromey.com>
4332
4333         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
4334         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
4335
4336 2018-03-30  Tom Tromey  <tom@tromey.com>
4337
4338         * dwarf2read.c (class free_cached_comp_units): New class.
4339         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
4340         (free_cached_comp_units): Remove function.
4341
4342 2018-03-30  Tom Tromey  <tom@tromey.com>
4343
4344         * utils.h (make_cleanup_unpush_target): Remove.
4345         * inf-ptrace.c (struct target_unpusher): New.
4346         (target_unpush_up) New typedef.
4347         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
4348         target_unpush_up.
4349         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
4350
4351 2018-03-27  Tom Tromey  <tom@tromey.com>
4352
4353         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
4354
4355 2018-03-27  Pedro Alves  <palves@redhat.com>
4356             Tom Tromey  <tom@tromey.com>
4357
4358         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
4359         destructor.  Now a class.
4360         (gdb_readline_wrapper_cleanup): Remove function.
4361         (gdb_readline_wrapper): Remove cleanups.
4362
4363 2018-03-27  Tom Tromey  <tom@tromey.com>
4364
4365         * typeprint.h (struct type_print_options) <local_typedefs,
4366         global_typedefs>: Remove "struct" keyword.
4367         (class typedef_hash_table): New class.
4368         (recursively_update_typedef_hash, add_template_parameters)
4369         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
4370         (find_typedef_in_hash): Don't declare.
4371         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
4372         (typedef_hash_table::recursively_update): Rename from
4373         recursively_update_typedef_hash.  Now a member.
4374         (typedef_hash_table::add_template_parameters): Rename from
4375         add_template_parameters.  Now a member.
4376         (typedef_hash_table::typedef_hash_table): Now a constructor;
4377         rename from create_typedef_hash.
4378         (typedef_hash_table::~typedef_hash_table): Now a destructor;
4379         rename from free_typedef_hash.
4380         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
4381         (do_free_global_table): Remove.
4382         (typedef_hash_table::typedef_hash_table): New constructor; renamed
4383         from copy_type_recursive.
4384         (create_global_typedef_table): Remove.
4385         (typedef_hash_table::find_global_typedef): Now a member of
4386         typedef_hash_table.
4387         (typedef_hash_table::find_typedef): Rename from
4388         find_typedef_in_hash; now a member.
4389         (whatis_exp): Update.
4390         * extension.h (struct ext_lang_type_printers): Add constructor and
4391         destructor.
4392         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
4393         declare.
4394         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
4395         Now a constructor; rename from start_ext_lang_type_printers.
4396         (ext_lang_type_printers): Now a destructor; rename from
4397         free_ext_lang_type_printers.
4398         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
4399         Update.
4400         (c_type_print_base_struct_union): Update.  Remove cleanups.
4401
4402 2018-03-27  Tom Tromey  <tom@tromey.com>
4403
4404         * dwarf-index-write.c: Include <cmath>.
4405
4406 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4407
4408         * NEWS: Add entry describing new "set|show varsize-limit" command.
4409         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
4410         command.
4411         * printcmd.c (_initialize_printcmd): Add "set var" alias of
4412         "set variable".
4413
4414 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
4415
4416         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
4417         dwarf-index-write.c
4418         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
4419         * dwarf-index-common.c: New file.
4420         * dwarf-index-common.h: New file.
4421         * dwarf-index-write.c: New file.
4422         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
4423         (struct dwarf2_section_info): Move from here.
4424         (dwarf2_section_info_def): Likewise.
4425         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
4426         (offset_type): Likewise.
4427         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
4428         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
4429         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
4430         (byte_swap): Likewise.
4431         (MAYBE_SWAP): Likewise.
4432         (dwarf2_per_cu_ptr): Likewise.
4433         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
4434         (struct tu_stats): Likewise.
4435         (struct dwarf2_per_objfile): Likewise.
4436         (struct dwarf2_per_cu_data): Likewise.
4437         (struct signatured_type): Likewise.
4438         (sig_type_ptr): Likewise.
4439         (DEF_VEC_P (sig_type_ptr)): Likewise.
4440         (INDEX4_SUFFIX): Likewise.
4441         (INDEX5_SUFFIX): Likewise.
4442         (DEBUG_STR_SUFFIX): Likewise.
4443         (dwarf2_read_section): Make non-static.
4444         (mapped_index_string_hash): Move from here.
4445         (dwarf5_djb_hash): Likewise.
4446         (file_write): Likewise.
4447         (class data_buf): Likewise.
4448         (struct symtab_index_entry): Likewise.
4449         (struct mapped_symtab): Likewise.
4450         (find_slot): Likewise.
4451         (hash_expand): Likewise.
4452         (add_index_entry): Likewise.
4453         (uniquify_cu_indices): Likewise.
4454         (class c_str_view): Likewise.
4455         (class c_str_view_hasher): Likewise.
4456         (class vector_hasher): Likewise.
4457         (write_hash_table): Likewise.
4458         (psym_index_map): Likewise.
4459         (struct addrmap_index_data): Likewise.
4460         (add_address_entry): Likewise.
4461         (add_address_entry_worker): Likewise.
4462         (write_address_map): Likewise.
4463         (symbol_kind): Likewise.
4464         (write_psymbols): Likewise.
4465         (struct signatured_type_index_data): Likewise.
4466         (write_one_signatured_type): Likewise.
4467         (recursively_count_psymbols): Likewise.
4468         (recursively_write_psymbols): Likewise.
4469         (class debug_names): Likewise.
4470         (check_dwarf64_offsets): Likewise.
4471         (psyms_seen_size): Likewise.
4472         (write_gdbindex): Likewise.
4473         (write_debug_names): Likewise.
4474         (assert_file_size): Likewise.
4475         (write_psymtabs_to_index): Likewise.
4476         (save_gdb_index_command): Likewise.
4477         (_initialize_dwarf2_read): Don't register the "save gdb-index"
4478         command.
4479         * dwarf2read.h: New file.
4480
4481 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4482
4483         PR gdb/22670
4484         * dwarf2read.c (dwarf2_physname): Do not return the demangled
4485         symbol name if the CU's language stores symbol names in linkage
4486         format.
4487         * language.h (struct language_defn)
4488         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
4489         all instances of this struct.
4490
4491 2018-03-26  Tom Tromey  <tom@tromey.com>
4492
4493         * stack.c (backtrace_command_1): Remove verbose code.
4494
4495 2018-03-26  Tom Tromey  <tom@tromey.com>
4496
4497         * python/py-framefilter.c (py_print_type): Don't catch
4498         exceptions.  Return void.
4499         (py_print_value): Likewise.
4500         (py_print_single_arg): Likewise.
4501         (enumerate_args): Don't catch exceptions.
4502         (py_print_args): Likewise.
4503         (py_print_frame): Likewise.
4504         (gdbpy_apply_frame_filter): Catch exceptions here.
4505
4506 2018-03-26  Tom Tromey  <tom@tromey.com>
4507
4508         * stack.c (_initialize_stack): Remove trailing newlines from help
4509         text.  Add "Usage" line to "backtrace" help.
4510
4511 2018-03-26  Tom Tromey  <tom@tromey.com>
4512
4513         PR python/16486:
4514         * python/py-framefilter.c (py_print_args): Call wrap_hint.
4515
4516 2018-03-26  Tom Tromey  <tom@tromey.com>
4517
4518         * python/py-framefilter.c (py_print_single_arg): Return
4519         EXT_LANG_BT_ERROR from catch.
4520
4521 2018-03-26  Tom Tromey  <tom@tromey.com>
4522
4523         PR backtrace/15584:
4524         * stack.c (backtrace_command_1): Move some code into no-filters
4525         "if".
4526
4527 2018-03-26  Tom Tromey  <tom@tromey.com>
4528
4529         * python/py-framefilter.c (throw_quit_or_print_exception): New
4530         function.
4531         (gdbpy_apply_frame_filter): Use it.
4532
4533 2018-03-26  Tom Tromey  <tom@tromey.com>
4534
4535         PR cli/17716:
4536         * python/py-framefilter.c (py_print_type, py_print_value)
4537         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
4538         RETURN_MASK_ERROR.
4539
4540 2018-03-26  Tom Tromey  <tom@tromey.com>
4541
4542         * python/py-framefilter.c (enumerate_args): Use
4543         gdb::unique_xmalloc_ptr.
4544
4545 2018-03-26  Tom Tromey  <tom@tromey.com>
4546
4547         * python/py-framefilter.c (py_print_frame): Return
4548         EXT_LANG_BT_OK.
4549         (gdbpy_apply_frame_filter): Update comment.
4550         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
4551         Remove.
4552         <EXT_LANG_BT_NO_FILTERS>: Change value.
4553
4554 2018-03-26  Tom Tromey  <tom@tromey.com>
4555
4556         PR backtrace/15582:
4557         * stack.c (backtrace_command): Parse "hide" argument.
4558         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
4559         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
4560         constant.
4561
4562 2018-03-26  Tom Tromey  <tom@tromey.com>
4563
4564         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
4565         add "flags".
4566         (backtrace_command): Remove "fulltrace", add "flags".
4567
4568 2018-03-26  Tom Tromey  <tom@tromey.com>
4569
4570         * stack.c (backtrace_command): Rewrite command line parsing.
4571
4572 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4573
4574         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
4575
4576 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4577
4578         * filename-seen-cache.h: Add include guard.
4579
4580 2018-03-26  Keith Seitz  <keiths@redhat.com>
4581
4582         * symfile.c (place_section): Remove "struct" from section_addr_info
4583         in comment.
4584         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
4585         "struct" keyword from section_addr_info.
4586
4587 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
4588
4589         * regformats/regdef.h (reg): Add constructors.
4590
4591 2018-03-25  Pedro Alves  <palves@redhat.com>
4592
4593         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
4594         if then/else bodies in var_func_name extraction.
4595
4596 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
4597
4598         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
4599         lookup_minimal_symbol() to find symbol entry.
4600         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
4601
4602 2018-03-23  Keith Seitz  <keiths@redhat.com>
4603
4604         PR c++/22968
4605         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
4606         nested type definitions for C++, too.
4607
4608 2018-03-23  Tom Tromey  <tom@tromey.com>
4609
4610         * machoread.c (struct oso_el): Add a constructor.  Don't define as
4611         a typedef.
4612         (macho_register_oso): Remove.
4613         (macho_symtab_read): Take a std::vector.
4614         (oso_el_compare_name): Now a std::sort comparator.
4615         (macho_symfile_read_all_oso): Take a std::vector.
4616         (macho_symfile_read): Use std::vector.  Remove cleanups.
4617
4618 2018-03-22  Tom Tromey  <tom@tromey.com>
4619
4620         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
4621         (record_full_goto_bookmark): Use std::string.
4622
4623 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4624
4625         PR tdep/18295
4626         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
4627         a single mask.
4628
4629 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4630
4631         * rs6000-tdep.c (store_insn_p): New function.
4632         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
4633         and cr_reg to their unshifted values. Use store_insn_p to
4634         match LR saves using either R1 or fdata->alloca_reg. Use
4635         store_insn_p to match CR saves. Set alloca_reg_offset
4636         when alloca_reg and framep are set. Remove lr_reg shift
4637         when assigning to fdata->lr_register.
4638
4639 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4640
4641         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
4642         command line args instead of emitting a warning.
4643
4644 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4645
4646         * tracepoint.h (struct static_tracepoint_marker): Initialize
4647         fields, define default constructor, move constructor and move
4648         assignment, disable the rest.
4649         <str_id, extra>: Make std::string.
4650         (release_static_tracepoint_marker): Remove.
4651         (free_current_marker): Remove.
4652         * tracepoint.c (free_current_marker): Remove.
4653         (parse_static_tracepoint_marker_definition): Adjust to
4654         std::string, use new hex2str overload.
4655         (release_static_tracepoint_marker): Remove.
4656         (print_one_static_tracepoint_marker): Get marker by reference
4657         and adjust to std::string.
4658         (info_static_tracepoint_markers_command): Adjust to std::vector
4659         changes
4660         * target.h (static_tracepoint_marker_p): Remove typedef.
4661         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
4662         (struct target_ops) <to_static_tracepoint_marker_at>: Return
4663         bool.
4664         <to_static_tracepoint_markers_by_strid>: Return std::vector.
4665         * target-debug.h
4666         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
4667         (target_debug_print_std_vector_static_tracepoint_marker): New.
4668         (target_debug_print_struct_static_tracepoint_marker_p): Rename
4669         to...
4670         (target_debug_print_static_tracepoint_marker_p): ... this.
4671         * target-delegates.c: Re-generate.
4672         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
4673         Make std::string.
4674         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
4675         (decode_static_tracepoint_spec): Adjust to std::vector.
4676         (tracepoint_print_one_detail): Adjust to std::string.
4677         (strace_marker_decode_location): Adjust to std::string.
4678         (update_static_tracepoint): Adjust to std::string, remove call
4679         to release_static_tracepoint_marker.
4680         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
4681         Adjust to std::vector.
4682         * remote.c (remote_static_tracepoint_marker_at): Return bool.
4683         (remote_static_tracepoint_markers_by_strid): Adjust to
4684         std::vector.
4685         * common/rsp-low.h (hex2str): New overload with explicit count
4686         of bytes.
4687         * common/rsp-low.c (hex2str): New overload with explicit count
4688         of bytes.
4689         * unittests/rsp-low-selftests.c (test_hex2str): New function.
4690         (_initialize_rsp_low_selftests): Add test_hex2str test.
4691         * unittests/tracepoint-selftests.c
4692         (test_parse_static_tracepoint_marker_definition): Adjust to
4693         std::string.
4694
4695 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4696
4697         * tracepoint.c (parse_static_tracepoint_marker_definition):
4698         Consider case where the definition is followed by more
4699         definitions.
4700         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4701         tracepoint-selftests.c.
4702         * unittests/tracepoint-selftests.c: New.
4703
4704 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4705
4706         * MAINTAINERS (Write After Approval): Add Pedro Franco de
4707         Carvalho.
4708
4709 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4710
4711         * symtab.c (find_pc_sect_line): fixed indentation.
4712
4713 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4714
4715         * symtab.c (find_pc_sect_line): now uses binary search.
4716
4717 2018-03-19  Tom Tromey  <tom@tromey.com>
4718
4719         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
4720         "IDENT" production.
4721
4722 2018-03-19  Pedro Alves  <palves@redhat.com>
4723             Tom Tromey  <tom@tromey.com>
4724
4725         * unittests/observable-selftests.c: New file.
4726         * common/observable.h: New file.
4727         * observable.h: New file.
4728         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
4729         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
4730         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
4731         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
4732         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
4733         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
4734         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
4735         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
4736         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
4737         python/py-breakpoint.c, python/py-finishbreakpoint.c,
4738         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
4739         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
4740         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
4741         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
4742         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
4743         tui/tui-interp.c, valops.c: Update all users.
4744         * tui/tui-hooks.c (tui_bp_created_observer)
4745         (tui_bp_deleted_observer, tui_bp_modified_observer)
4746         (tui_inferior_exit_observer, tui_before_prompt_observer)
4747         (tui_normal_stop_observer, tui_register_changed_observer):
4748         Remove.
4749         (tui_observers_token): New global.
4750         (attach_or_detach, tui_attach_detach_observers): New functions.
4751         (tui_install_hooks, tui_remove_hooks): Use
4752         tui_attach_detach_observers.
4753         * record-btrace.c (record_btrace_thread_observer): Remove.
4754         (record_btrace_thread_observer_token): New global.
4755         * observer.sh: Remove.
4756         * observer.c: Rename to observable.c.
4757         * observable.c (namespace gdb_observers): Define new objects.
4758         (observer_debug): Move into gdb_observers namespace.
4759         (struct observer, struct observer_list, xalloc_observer_list_node)
4760         (xfree_observer_list_node, generic_observer_attach)
4761         (generic_observer_detach, generic_observer_notify): Remove.
4762         (_initialize_observer): Update.
4763         Don't include observer.inc.
4764         * Makefile.in (generated_files): Remove observer.h, observer.inc.
4765         (clean mostlyclean): Likewise.
4766         (observer.h, observer.inc): Remove targets.
4767         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
4768         (COMMON_SFILES): Use observable.c, not observer.c.
4769         * .gitignore: Remove observer.h.
4770
4771 2018-03-18  Tom Tromey  <tom@tromey.com>
4772
4773         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
4774         gdb::def_vector.
4775         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
4776
4777 2018-03-17  Tom Tromey  <tom@tromey.com>
4778
4779         * auto-load.c (auto_load_objfile_script_1): Use std::string.
4780
4781 2018-03-17  Tom Tromey  <tom@tromey.com>
4782
4783         * target.c (class scoped_target_fd): New.
4784         (target_fileio_close_cleanup): Remove.
4785         (target_fileio_read_alloc_1): Use scoped_target_fd.
4786
4787 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
4788
4789         * silent-rules.mk: New.
4790         * Makefile.in: Include silent-rules.mk
4791         (srcdir, VPATH, top_srcdir): Move up.
4792         (COMPILE): Add ECHO_CXX.
4793         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
4794         (init.c): Add ECHO_INIT_C.
4795         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
4796         (version.c): Add ECHO_GEN.
4797         (printcmd.o): Add ECHO_CXX.
4798         (target-float.o): Add ECHO_CXX.
4799         (ada-exp.o): Add ECHO_CXX.
4800         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
4801         (insight$(EXEEXT)): Add ECHO_CXXLD.
4802         * gnulib/configure.ac: Add AM_SILENT_RULES.
4803         * gnulib/aclocal.m4: Re-generate.
4804         * gnulib/configure: Re-generate.
4805         * gnulib/import/Makefile.in: Re-generate.
4806
4807 2018-03-16  Tom Tromey  <tom@tromey.com>
4808
4809         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
4810         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
4811         * utils.c (do_free_section_addr_info)
4812         (make_cleanup_free_section_addr_info): Remove.
4813         * symfile.h (struct other_sections): Add constructor.
4814         (struct section_addr_info): Remove.
4815         (section_addr_info): New typedef.
4816         (struct sym_fns) <sym_offsets>: Change type of parameter.
4817         (build_section_addr_info_from_objfile)
4818         (relative_addr_info_to_section_offsets, addr_info_make_relative)
4819         (default_symfile_offsets, symbol_file_add)
4820         (symbol_file_add_from_bfd)
4821         (build_section_addr_info_from_section_table): Update.
4822         (alloc_section_addr_info, free_section_addr_info): Don't declare.
4823         * symfile.c (alloc_section_addr_info): Remove.
4824         (build_section_addr_info_from_section_table): Change return type.
4825         Update.
4826         (build_section_addr_info_from_bfd)
4827         (build_section_addr_info_from_objfile): Likewise.
4828         (free_section_addr_info): Remove.
4829         (relative_addr_info_to_section_offsets): Change type of "addrs".
4830         (addrs_section_compar): Now a std::sort comparator.
4831         (addrs_section_sort): Change return type.
4832         (addr_info_make_relative): Change type of "addrs".  Update.
4833         (default_symfile_offsets, syms_from_objfile_1)
4834         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
4835         (symbol_file_add_separate): Update.
4836         (symbol_file_add): Change type of "addrs".  Update.
4837         (add_symbol_file_command): Update.  Remove cleanups.
4838         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
4839         cleanups.
4840         * symfile-debug.c (debug_sym_offsets): Change type of "info".
4841         * solib.c (solib_read_symbols): Update.
4842         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
4843         * machoread.c (macho_symfile_offsets): Update.
4844         * jit.c (jit_bfd_try_read_symtab): Update.
4845
4846 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
4847
4848         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4849         unittests/utils-selftests.c.
4850         * unittests/utils-selftests.c: New file.
4851
4852 2018-03-14  Tom Tromey  <tom@tromey.com>
4853
4854         PR cli/14977:
4855         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
4856         for NULL.
4857
4858 2018-03-14  Tom Tromey  <tom@tromey.com>
4859
4860         PR cli/19918:
4861         * printcmd.c (printf_pointer): Allow "-" in format.
4862
4863 2018-03-14  Tom Tromey  <tom@tromey.com>
4864
4865         * printcmd.c (_initialize_printcmd): Add usage to printf.
4866
4867 2018-03-14  Yao Qi  <qiyao@sourceware.org>
4868
4869         * MAINTAINERS: Update my email address.
4870
4871 2018-03-13  Tom Tromey  <tom@tromey.com>
4872
4873         * machoread.c (macho_check_dsym): Change filenamep to a
4874         std::string*.
4875         (macho_symfile_read): Update.
4876         * symfile.c (load_command): Use std::string.
4877
4878 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4879
4880         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
4881         to error message string.
4882         (riscv_register_name): Use xsnprintf instead of sprintf.
4883         (riscv_insn::fetch_instruction): Use gdb_assert instead of
4884         internal_error.
4885         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
4886         error.
4887         (riscv_push_dummy_call): Likewise.
4888
4889 2018-03-12  Tom Tromey  <tom@tromey.com>
4890
4891         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
4892         Use gdb::byte_vector.
4893         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
4894
4895 2018-03-12  Yao Qi  <yao.qi@linaro.org>
4896
4897         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
4898         parameter type to readable_regcache.
4899         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
4900         the declaration.
4901
4902 2018-03-11  Tom Tromey  <tom@tromey.com>
4903
4904         * dwarf2read.c (struct nextfield): Add initializers.
4905         (struct nextfnfield): Remove.
4906         (struct fnfieldlist): Add initializers.  Remove "length" and
4907         "head", use std::vector.
4908         (struct decl_field_list): Remove.
4909         (struct field_info): Add initializers.
4910         <fields, baseclasses>: Now std::vector.
4911         <nbaseclasses, nfnfields, typedef_field_list_count,
4912         nested_types_list_count>: Remove.
4913         (dwarf2_add_field, dwarf2_add_type_defn)
4914         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
4915         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
4916         (process_structure_scope): Update.
4917
4918 2018-03-11  Tom Tromey  <tom@tromey.com>
4919
4920         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
4921         for use by std::sort.
4922         (build_type_psymtabs_1): Use std::vector.
4923
4924 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
4925
4926         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
4927         and LIBMPFR in the printed configuration.
4928
4929 2018-03-08  Tom Tromey  <tom@tromey.com>
4930
4931         * source.c (get_filename_and_charpos): Use scoped_fd.
4932         * nto-procfs.c (procfs_open_1): Use scoped_fd.
4933         (procfs_pidlist): Likewise.
4934         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
4935         (iterate_over_mappings): Likewise.
4936
4937 2018-03-08  Tom Tromey  <tom@tromey.com>
4938
4939         * infcall.c (struct call_return_meta_info)
4940         <stack_temporaries_enabled>: Remove.
4941         (get_call_return_value, call_function_by_hand_dummy): Update.
4942         * thread.c (disable_thread_stack_temporaries): Remove.
4943         (enable_thread_stack_temporaries): Remove.
4944         (thread_stack_temporaries_enabled_p): Return bool.
4945         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
4946         (get_last_thread_stack_temporary): Update.
4947         * eval.c (evaluate_subexp): Update.
4948         * gdbthread.h (class enable_thread_stack_temporaries): Now a
4949         class, not a function.
4950         (value_ptr, value_vec): Remove typedefs.
4951         (class thread_info) <stack_temporaries_enabled>: Now bool.
4952         <stack_temporaries>: Now a std::vector.
4953         (thread_stack_temporaries_enabled_p)
4954         (value_in_thread_stack_temporaries): Return bool.
4955
4956 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
4957
4958         * remote.c (putpkt_binary): Fix omitted bytes reporting.
4959         (getpkt_or_notif_sane_1): Likewise.
4960
4961 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4962
4963         * build-id.c (build_id_to_debug_bfd): Use std::string.
4964
4965 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4966
4967         * build-id.c (find_separate_debug_file_by_buildid): Return
4968         std::string.
4969         * build-id.h (find_separate_debug_file_by_buildid): Return
4970         std::string.
4971         * coffread.c (coff_symfile_read): Adjust to std::string.
4972         * elfread.c (elf_symfile_read): Adjust to std::string.
4973         * symfile.c (separate_debug_file_exists): Change parameter to
4974         std::string.
4975         (find_separate_debug_file): Return std::string.
4976         (find_separate_debug_file_by_debuglink): Return std::string.
4977         * symfile.h (find_separate_debug_file_by_debuglink): Return
4978         std::string.
4979
4980 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4981
4982         * common/xml-utils.c (xml_escape_text): Move code to...
4983         (xml_escape_text_append): ... this new function.
4984         * common/xml-utils.h (xml_escape_text_append): New declaration.
4985         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
4986         New function.
4987         (_initialize_xml_utils): register test_xml_escape_text_append as
4988         a selftest.
4989
4990 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
4991
4992         * defs.h: Remove MAX_REGISTER_SIZE.
4993         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
4994         asserts.
4995         * python/py-unwind.c (pyuw_sniffer): Likewise.
4996
4997 2018-03-07  Tom Tromey  <tom@tromey.com>
4998
4999         * linux-tdep.c (linux_info_proc): Update.
5000         * target.h (struct target_ops) <to_fileio_readlink>: Return
5001         optional<string>.
5002         (target_fileio_readlink): Return optional<string>.
5003         * remote.c (remote_hostio_readlink): Return optional<string>.
5004         * inf-child.c (inf_child_fileio_readlink): Return
5005         optional<string>.
5006         * target.c (target_fileio_readlink): Return optional<string>.
5007
5008 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5009
5010         * regcache.c (cooked_read_test): Add riscv to the list of
5011         architectures that have a save_reggroup.
5012
5013 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5014
5015         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
5016         value is not a dynamic class object.
5017
5018 2018-03-06  Tom Tromey  <tom@tromey.com>
5019
5020         * rust-exp.y: Formatting fixes.
5021
5022 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5023
5024         * riscv-tdep.c (riscv_register_name): Remove target description
5025         support.
5026         (riscv_gdbarch_init): Remove target description check.
5027
5028 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5029
5030         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
5031         comment.
5032         * riscv-tdep.h: Likewise.
5033
5034 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5035
5036         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
5037         (riscv_pseudo_register_write): Delete.
5038         (riscv_gdbarch_init): Remove all use of pseudo registers.
5039
5040 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5041
5042         * record-btrace.c (btrace_print_lines): Replace cleanup
5043         parameter with RAII equivalents.
5044         (btrace_insn_history): Replace cleanup with RAII equivalents.
5045         * ui-out.h (make_cleanup_ui_out_list_begin_end,
5046         make_cleanup_ui_out_tuple_begin_end): Remove.
5047         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
5048         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
5049         make_cleanup_ui_out_list_begin_end): Remove.
5050
5051 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5052
5053         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
5054         parameter types to std::vector.  Use bool.
5055         (record_btrace_wait): Replace VEC(tp_t) with
5056         std::vector<thread_info *>.
5057         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
5058
5059 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5060
5061         * record-btrace.c (record_btrace_disable_callback): Remove.
5062         (struct scoped_btrace_disable): New.
5063         (record_btrace_open): Use scoped_btrace_disable.
5064
5065 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5066
5067         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
5068         reading values from registers.
5069
5070 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5071
5072         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
5073         where appropriate.
5074
5075 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5076
5077         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
5078         change parameter type.  Use GDB's print functions, and use
5079         core_addr_to_string where appropriate.
5080         (riscv_push_dummy_call): Use core_addr_to_string where
5081         appropriate, update call to riscv_print_arg_location, and reindent
5082         a few lines.
5083         (riscv_return_value): Update call to riscv_print_arg_location.
5084
5085 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5086             Tim Newsome <tim@sifive.com>
5087             Albert Ou <a0u@eecs.berkeley.edu>
5088             Darius Rad <darius@bluespec.com>
5089
5090         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
5091         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
5092         (ALLDEPFILES): Add riscv-tdep.c
5093         * configure.tgt: Add riscv support.
5094         * riscv-tdep.c: New file.
5095         * riscv-tdep.h: New file.
5096         * NEWS: Mention new target.
5097         * MAINTAINERS: Add entry for riscv.
5098
5099 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5100
5101         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
5102         fields within aggregates.
5103
5104 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
5105
5106         * record-btrace.c (btrace_print_lines): Change type of flags to
5107         gdb_disassembly_flags.
5108
5109 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5110
5111         * fbsd-nat.c: Include "inf-ptrace.h".
5112         (USE_SIGTRAP_SIGINFO): Conditionally define.
5113         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
5114         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
5115         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
5116         function.
5117         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
5118         Likewise.
5119         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
5120         Likewise.
5121         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
5122         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
5123         "supports_stopped_by_hw_breakpoint" target methods.
5124
5125 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5126
5127         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
5128         * fbsd-nat.c (debug_fbsd_nat): New variable.
5129         (show_fbsd_nat_debug): New function.
5130         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
5131         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
5132
5133 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5134
5135         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
5136         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
5137         prototype.
5138         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
5139         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
5140         method.
5141
5142 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5143
5144         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
5145         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
5146
5147 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5148
5149         * charset.c (struct charset_vector): New.
5150         (charsets): Change type to charset_vector.
5151         (find_charset_names): Adjust.
5152         (add_one): Adjust.
5153         (_initialize_charset): Adjust.
5154
5155 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5156
5157         * progspace.h (struct program_space) <deleted_solibs>: Change
5158         type to std::vector<std::string>.
5159         * progspace.c (clear_program_space_solib_cache): Adjust.
5160         * breakpoint.c (print_solib_event): Adjust.
5161         (check_status_catch_solib): Adjust.
5162         * solib.c (update_solib_list): Adjust.
5163         * ui-out.h (class ui_out) <field_string>: New overload.
5164         * ui-out.c (ui_out::field_string): New overload.
5165
5166 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5167
5168         * progspace.h (struct program_space): Add constructor and
5169         destructor, initialize fields.
5170         (add_program_space): Remove.
5171         * progspace.c (add_program_space): Rename to...
5172         (program_space::program_space): ... this.
5173         (release_program_space): Rename to...
5174         (program_space::~program_space): ... this.
5175         (delete_program_space): Use delete to delete program_space.
5176         (initialize_progspace): Use new to allocate program_space.
5177         * inferior.c (add_inferior_with_spaces): Likewise.
5178         (clone_inferior_command): Likewise.
5179         * infrun.c (follow_fork_inferior): Likewise.
5180         (handle_vfork_child_exec_or_exit): Likewise.
5181
5182 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5183
5184         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
5185         (delim_string_to_char_ptr_vec): Return std::vector of
5186         gdb::unique_xmalloc_ptr.
5187         (dirnames_to_char_ptr_vec_append): Take std::vector of
5188         gdb::unique_xmalloc_ptr.
5189         (dirnames_to_char_ptr_vec): Return std::vector of
5190         gdb::unique_xmalloc_ptr.
5191         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
5192         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
5193         (delim_string_to_char_ptr_vec): Return an std::vector of
5194         gdb::unique_xmalloc_ptr, adjust the code.
5195         (dirnames_to_char_ptr_vec_append): Take an std::vector of
5196         gdb::unique_xmalloc_ptr, adjust the code.
5197         (dirnames_to_char_ptr_vec): Return an std::vector of
5198         gdb::unique_xmalloc_ptr, adjust the code.
5199         * auto-load.c (auto_load_safe_path_vec): Change type to
5200         std::vector of gdb::unique_xmalloc_ptr.
5201         (auto_load_expand_dir_vars): Return an std::vector of
5202         gdb::unique_xmalloc_ptr, adjust the code.
5203         (auto_load_safe_path_vec_update): Adjust.
5204         (filename_is_in_auto_load_safe_path_vec): Adjust.
5205         (auto_load_objfile_script_1): Adjust.
5206         * build-id.c (build_id_to_debug_bfd): Adjust.
5207         * linux-thread-db.c (thread_db_load_search): Adjust.
5208         * source.c (add_path): Adjust.
5209         (openp): Adjust.
5210         * symfile.c (find_separate_debug_file): Adjust.
5211         * utils.c (do_free_char_ptr_vec): Remove.
5212         (make_cleanup_free_char_ptr_vec): Remove.
5213
5214 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5215
5216         PR gdb/22907
5217         * common/pathstuff.c: Conditionally include "<windows.h>".
5218
5219 2018-03-01  Georg Sauthoff  <mail@georg.so>
5220
5221         PR gdb/22888
5222         * gcore.in: Quote variables and switch interpreter to bash.
5223
5224 2018-03-01  Tom Tromey  <tom@tromey.com>
5225
5226         * dwarf2read.c (alloc_discriminant_info): Fix default_index
5227         assertion.  Add assertion for discriminant_index.
5228         (quirk_rust_enum): Use correct base type name in univariant case.
5229
5230 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
5231
5232         * record.c (get_call_history_modifiers): Return a
5233         record_print_flags.
5234         (cmd_record_call_history): Adjust.
5235         * record-btrace.c (record_btrace_call_history): Adjust.
5236         (record_btrace_call_history_range): Adjust.
5237         (record_btrace_call_history_from): Adjust.
5238         * target-debug.h (target_debug_print_record_print_flags): New.
5239         * target-delegates.c: Re-generate.
5240         * target.c (target_call_history): Change flags type.
5241         (target_call_history_from): Likewise.
5242         (target_call_history_range): Likewise.
5243         * target.h (struct target_ops) <target_call_history>: Likewise.
5244         (target_call_history_from): Likewise.
5245         (target_call_history_range): Likewise.
5246
5247 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5248             Simon Marchi  <simon.marchi@polymtl.ca>
5249
5250         * common/common-utils.c: Include "sys/stat.h".
5251         (is_regular_file): Move here from "source.c"; change return
5252         type to "bool".
5253         * common/common-utils.h (is_regular_file): New prototype.
5254         * common/pathstuff.c (contains_dir_separator): New function.
5255         * common/pathstuff.h (contains_dir_separator): New prototype.
5256         * source.c: Don't include "sys/stat.h".
5257         (is_regular_file): Move to "common/common-utils.c".
5258
5259 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5260
5261         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
5262         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
5263         * auto-load.c: Include "common/pathstuff.h".
5264         * common/common-def.h (current_directory): Move here.
5265         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
5266         function.
5267         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
5268         prototype.
5269         * common/pathstuff.c: New file.
5270         * common/pathstuff.h: New file.
5271         * compile/compile.c: Include "common/pathstuff.h".
5272         * defs.h (current_directory): Move to "common/common-defs.h".
5273         * dwarf2read.c: Include "common/pathstuff.h".
5274         * exec.c: Likewise.
5275         * guile/scm-safe-call.c: Likewise.
5276         * linux-thread-db.c: Likewise.
5277         * main.c: Likewise.
5278         * nto-tdep.c: Likewise.
5279         * objfiles.c: Likewise.
5280         * source.c: Likewise.
5281         * symtab.c: Likewise.
5282         * utils.c: Include "common/pathstuff.h".
5283         (gdb_realpath): Move to "common/pathstuff.c".
5284         (gdb_realpath_keepfile): Likewise.
5285         (gdb_abspath): Likewise.
5286         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
5287         (gdb_realpath_keepfile): Likewise.
5288         (gdb_abspath): Likewise.
5289
5290 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
5291
5292         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
5293         wildcard process pid for super_resume for kernels with a
5294         specific bug.
5295
5296 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
5297
5298         * compile/compile.c (get_args): Add additional comments
5299         explaining function.
5300
5301 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
5302             Tom Tromey  <tom@tromey.com>
5303
5304         * target.h (memory_write_request_s): Remove typedef.  Don't define
5305         VEC.
5306         (target_write_memory_blocks): Change argument to std::vector.
5307         (struct memory_write_request): Add constructor.
5308         * target-memory.c (compare_block_starting_address): Return bool.
5309         Change argument types.
5310         (claim_memory): Change arguments to use std::vector.
5311         (split_regular_and_flash_blocks, blocks_to_erase)
5312         (compute_garbled_blocks): Likewise.
5313         (cleanup_request_data, cleanup_write_requests_vector): Remove.
5314         (target_write_memory_blocks): Change argument to std::vector.
5315         * symfile.c (struct load_section_data): Add constructor and
5316         destructor.  Use std::vector for "requests".
5317         (struct load_progress_data): Add initializers.
5318         (load_section_callback): Update.  Use "new".
5319         (clear_memory_write_data): Remove.
5320         (generic_load): Update.
5321
5322 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
5323
5324         * arch/aarch64.h: Use common/tdesc.h.
5325
5326 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5327
5328         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
5329         architecture with a 64-bit ABI.
5330
5331 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5332
5333         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
5334         ahead of target description loading.
5335
5336 2018-02-26  Tom Tromey  <tom@tromey.com>
5337
5338         * stack.c (backtrace_command_1): Update.
5339         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
5340         of "flags".
5341         * python/py-framefilter.c (py_print_frame)
5342         (gdbpy_apply_frame_filter): Change type of "flags".
5343         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
5344         of "flags".
5345         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
5346         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
5347         * extension.h (enum frame_filter_flag): Rename from
5348         frame_filter_flags.
5349         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
5350         (apply_ext_lang_frame_filter): Change type of "flags".
5351         * extension.c (apply_ext_lang_frame_filter): Change type of
5352         "flags".
5353         * extension-priv.h (struct extension_language_ops)
5354         <apply_frame_filter>: Change type of "flags".
5355
5356 2018-02-26  Tom Tromey  <tom@tromey.com>
5357
5358         PR python/16497:
5359         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
5360         off-by-one in py_end computation.
5361         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
5362         PRINT_MORE_FRAMES.
5363         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
5364         constant.
5365
5366 2018-02-26  Tom Tromey  <tom@tromey.com>
5367
5368         * dwarf2read.c (struct variant_field): New.
5369         (struct nextfield) <variant>: New field.
5370         (dwarf2_add_field): Handle DW_TAG_variant_part.
5371         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
5372         discriminated union.
5373         (read_structure_type): Handle DW_TAG_variant_part.
5374         (handle_struct_member_die): New function, extracted from
5375         process_structure_scope.  Handle DW_TAG_variant.
5376         (process_structure_scope): Handle discriminated unions.  Call
5377         handle_struct_member_die.
5378
5379 2018-02-26  Tom Tromey  <tom@tromey.com>
5380
5381         * rust-lang.h (rust_last_path_segment): Declare.
5382         * rust-lang.c (rust_last_path_segment): Now public.  Change
5383         contract.
5384         (struct disr_info): Remove.
5385         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
5386         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
5387         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
5388         (rust_enum_p, rust_enum_variant): New function.
5389         (rust_underscore_fields): Remove "offset" parameter.
5390         (rust_print_enum): New function.
5391         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
5392         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
5393         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
5394         enums.
5395         (rust_internal_print_type): New function, from rust_print_type.
5396         Remove enum code.
5397         (rust_print_type): Call rust_internal_print_type.
5398         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
5399         Update enum handling.
5400         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
5401         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
5402         (rust_union_quirks): New functions.
5403         (process_full_comp_unit, process_full_type_unit): Call
5404         rust_union_quirks.
5405         (process_structure_scope): Update rust_unions if necessary.
5406
5407 2018-02-26  Tom Tromey  <tom@tromey.com>
5408
5409         * value.h (value_union_variant): Declare.
5410         * valops.c (value_union_variant): New function.
5411         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
5412         (struct discriminant_info): New.
5413         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
5414         enumerator.
5415         (struct main_type) <flag_discriminated_union>: New field.
5416
5417 2018-02-26  Tom Tromey  <tom@tromey.com>
5418
5419         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5420         unittests/unpack-selftests.c.
5421         * unittests/unpack-selftests.c: New file.
5422         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
5423
5424 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5425
5426         * dwarf2read.c (struct partial_die_info) <read>: New method.
5427         (read_partial_die): Remove the declaration.
5428         (load_partial_dies): Update.
5429         (partial_die_info::partial_die_info):
5430         (read_partial_die): Change it to partial_die_info::read.
5431
5432 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5433
5434         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
5435         (fixup_partial_die): Remove declaration.
5436         (scan_partial_symbols): Update.
5437         (partial_die_parent_scope): Likewise.
5438         (partial_die_full_name): Likewise.
5439         (fixup_partial_die): Change it to partial_die_info::fixup.
5440
5441 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5442
5443         * dwarf2read.c (read_partial_die): Update the declaration.
5444         (load_partial_dies): Caller update.
5445         (read_partial_die): Remove one argument abbrev_len.
5446
5447 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5448
5449         * dwarf2read.c (struct partial_die_info): Add ctor, delete
5450         assignment operator.
5451         (load_partial_dies): Use ctor and copy ctor.
5452         (read_partial_die): Update.
5453         (dwarf2_cu::find_partial_die): Use ctor.
5454
5455 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5456
5457         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
5458         (find_partial_die_in_comp_unit): Change it to
5459         dwarf2_cu::find_partial_die.
5460         (find_partial_die): Update.
5461
5462 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5463
5464         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
5465         is NULL.
5466
5467 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5468
5469         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
5470
5471 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
5472
5473         * arch/amd64.h: Use common/tdesc.h.
5474         * arch/i386.c: Likewise.
5475         * arch/i386.h: Likewise.
5476         * arch/tic6x.c: Likewise.
5477         * arch/tdesc.h: Move file from here...
5478         * common/tdesc.h: ...to here.
5479         * features/aarch64-core.c: Regenerate.
5480         * features/aarch64-fpu.c: Regenerate.
5481         * features/i386/32bit-avx.c: Regenerate.
5482         * features/i386/32bit-avx512.c: Regenerate.
5483         * features/i386/32bit-core.c: Regenerate.
5484         * features/i386/32bit-linux.c: Regenerate.
5485         * features/i386/32bit-mpx.c: Regenerate.
5486         * features/i386/32bit-pkeys.c: Regenerate.
5487         * features/i386/32bit-sse.c: Regenerate.
5488         * features/i386/64bit-avx.c: Regenerate.
5489         * features/i386/64bit-avx512.c: Regenerate.
5490         * features/i386/64bit-core.c: Regenerate.
5491         * features/i386/64bit-linux.c: Regenerate.
5492         * features/i386/64bit-mpx.c: Regenerate.
5493         * features/i386/64bit-pkeys.c: Regenerate.
5494         * features/i386/64bit-segments.c: Regenerate.
5495         * features/i386/64bit-sse.c: Regenerate.
5496         * features/i386/x32-core.c: Regenerate.
5497         * features/tic6x-c6xp.c: Regenerate.
5498         * features/tic6x-core.c: Regenerate.
5499         * features/tic6x-gp.c: Regenerate.
5500         * target-descriptions.c: Use common/tdesc.h.
5501         * target-descriptions.h: Likewise.
5502
5503 2018-02-24  Tom Tromey  <tom@tromey.com>
5504
5505         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
5506         (try_thread_db_load_from_dir, thread_db_load_search): Use
5507         std::string.
5508         (info_auto_load_libthread_db_compare): Return bool.  Change
5509         argument types.
5510         (info_auto_load_libthread_db): Use std::vector, std::string.
5511         Remove cleanups.
5512
5513 2018-02-24  Tom Tromey  <tom@tromey.com>
5514
5515         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
5516         std::string.
5517         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
5518         std::string*.
5519         * gdbarch.c: Rebuild.
5520         * gdbarch.h: Rebuild.
5521         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
5522         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
5523         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
5524         std::string*.
5525
5526 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
5527
5528         * gdbtypes.h (sect_offset): Change type to uint64_t.
5529         (sect_offset_str): New function.
5530         * dwarf2read.c (create_addrmap_from_aranges): Use
5531         sect_offset_str.
5532         (error_check_comp_unit_head): Likewise.
5533         (create_debug_type_hash_table): Likewise.
5534         (read_cutu_die_from_dwo): Likewise.
5535         (init_cutu_and_read_dies): Likewise.
5536         (init_cutu_and_read_dies_no_follow): Likewise.
5537         (process_psymtab_comp_unit_reader): Likewise.
5538         (partial_die_parent_scope): Likewise.
5539         (peek_die_abbrev): Likewise.
5540         (process_queue): Likewise.
5541         (dwarf2_physname): Likewise.
5542         (read_namespace_alias): Likewise.
5543         (read_import_statement): Likewise.
5544         (create_dwo_cu_reader): Likewise.
5545         (create_cus_hash_table): Likewise.
5546         (lookup_dwo_cutu): Likewise.
5547         (inherit_abstract_dies): Likewise.
5548         (read_func_scope): Likewise.
5549         (read_call_site_scope): Likewise.
5550         (dwarf2_add_member_fn): Likewise.
5551         (read_common_block): Likewise.
5552         (read_module_type): Likewise.
5553         (read_typedef): Likewise.
5554         (read_subrange_type): Likewise.
5555         (load_partial_dies): Likewise.
5556         (read_partial_die): Likewise.
5557         (find_partial_die): Likewise.
5558         (read_str_index): Likewise.
5559         (dwarf2_string_attr): Likewise.
5560         (build_error_marker_type): Likewise.
5561         (lookup_die_type): Likewise.
5562         (dump_die_shallow): Likewise.
5563         (follow_die_ref): Likewise.
5564         (dwarf2_fetch_die_loc_sect_off): Likewise.
5565         (dwarf2_fetch_constant_bytes): Likewise.
5566         (follow_die_sig): Likewise.
5567         (get_signatured_type): Likewise.
5568         (get_DW_AT_signature_type): Likewise.
5569         (dwarf2_find_containing_comp_unit): Likewise.
5570         (set_die_type): Likewise.
5571
5572 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
5573
5574         * arch/aarch64.c: Include "common-defs.h".
5575         * arch/amd64.c: Likewise.
5576         * arch/i386.c: Likewise.
5577
5578 2018-02-21  Tom Tromey  <tom@tromey.com>
5579
5580         * value.h: (extract_field_op): Update.
5581         * eval.c (extract_field_op): Return a const char *.
5582         * expression.h (parse_expression_for_completion): Update.
5583         * completer.c (complete_expression): Update.
5584         (add_struct_fields): Make fieldname const.
5585         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
5586         (mark_completion_tag, parse_exp_in_context_1): Update.
5587         (parse_expression_for_completion): Change "name" to
5588         unique_xmalloc_ptr*.
5589
5590 2018-02-21  Tom Tromey  <tom@tromey.com>
5591
5592         * infcall.c (call_function_by_hand_dummy): Use std::vector.
5593
5594 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5595
5596         * avr-tdep.c (avr_read_pc): Change parameter type to
5597         readable_regcache.
5598         * gdbarch.sh (read_pc): Likewise.
5599         * gdbarch.c: Re-generated.
5600         * gdbarch.h: Re-generated.
5601         * hppa-tdep.c (hppa_read_pc): Change parameter type to
5602         readable_regcache.
5603         * ia64-tdep.c (ia64_read_pc): Likewise.
5604         * mips-tdep.c (mips_read_pc): Likewise.
5605         * spu-tdep.c (spu_read_pc): Likewise.
5606
5607 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5608
5609         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
5610         * regcache-dump.c: New file.
5611         * regcache.c: Move register_dump to regcache-dump.c.
5612         (maintenance_print_registers): Likewise.
5613         (maintenance_print_raw_registers): Likewise.
5614         (maintenance_print_cooked_registers): Likewise.
5615         (maintenance_print_register_groups): Likewise.
5616         (maintenance_print_remote_registers): Likewise.
5617         (_initialize_regcache): Likewise.
5618         * regcache.h (register_dump): Moved from regcache.c.
5619
5620 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5621
5622         * regcache.c (regcache::regcache): Update.
5623         (regcache::invalidate): Move it to detached_regcache::invalidate.
5624         (get_thread_arch_aspace_regcache): Update.
5625         (regcache::raw_update): Update.
5626         (regcache::cooked_read): Remove some code.
5627         (regcache::cooked_read_value): Likewise.
5628         (regcache::raw_write): Remove assert on m_readonly_p.
5629         (regcache::raw_supply_integer): Move it to
5630         detached_regcache::raw_supply_integer.
5631         (regcache::raw_supply_zeroed): Likewise.
5632         * regcache.h (detached_regcache) <raw_supply_integer>: New
5633         declaration.
5634         <raw_supply_zeroed, invalidate>: Likewise.
5635         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
5636         <invalidate>: Likewise.
5637         <m_readonly_p>: Removed.
5638
5639 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5640
5641         * infcmd.c (get_return_value): Let stop_regs point to
5642         get_current_regcache.
5643         * regcache.c (regcache::regcache): Remove.
5644         (register_dump_reg_buffer): New class.
5645         (regcache_print): Adjust.
5646         * regcache.h (regcache): Remove constructors.
5647
5648 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5649
5650         * regcache.c (class register_dump): New class.
5651         (register_dump_regcache, register_dump_none): New class.
5652         (register_dump_remote, register_dump_groups): New class.
5653         (regcache_print): Update.
5654         * regcache.h (regcache_dump_what): Move it to regcache.c.
5655         (regcache) <dump>: Remove.
5656
5657 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5658
5659         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
5660          reg_buffer_rw *.
5661         (jit_unwind_reg_set_impl): Call raw_supply.
5662         (jit_frame_sniffer): Use reg_buffer_rw.
5663         * record-full.c (record_full_core_regbuf): Change its type.
5664         (record_full_core_open_1): Use reg_buffer_rw.
5665         (record_full_close): Likewise.
5666         (record_full_core_fetch_registers): Use regcache->raw_supply.
5667         (record_full_core_store_registers): Likewise.
5668         * regcache.c (regcache::get_register_status): Move it to
5669         reg_buffer.
5670         (regcache_raw_set_cached_value): Remove.
5671         (regcache::raw_set_cached_value): Remove.
5672         (regcache::raw_write): Call raw_supply.
5673         (regcache::raw_supply): Move it to reg_buffer_rw.
5674         * regcache.h (regcache_raw_set_cached_value): Remove.
5675         (reg_buffer_rw): New class.
5676
5677 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5678
5679         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
5680         readonly_detached_regcache.
5681         (dummy_frame_prev_register): Use regcache->cooked_read.
5682         * frame.c (frame_save_as_regcache): Change return type.
5683         (frame_pop): Update.
5684         * frame.h (frame_save_as_regcache): Update declaration.
5685         * inferior.h (get_infcall_suspend_state_regcache): Update
5686         declaration.
5687         * infrun.c (infcall_suspend_state) <registers>: use
5688         readonly_detached_regcache.
5689         (save_infcall_suspend_state): Don't use regcache_dup.
5690         (get_infcall_suspend_state_regcache): Change return type.
5691         * linux-fork.c (struct fork_info) <savedregs>: Change to
5692         readonly_detached_regcache.
5693         <pc>: New field.
5694         (fork_save_infrun_state): Don't use regcache_dup.
5695         (info_checkpoints_command): Adjust.
5696         * mi/mi-main.c (register_changed_p): Update declaration.
5697         (mi_cmd_data_list_changed_registers): Use
5698         readonly_detached_regcache.
5699         (register_changed_p): Change parameter type to
5700         readonly_detached_regcache.
5701         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
5702         readonly_detached_regcache.
5703         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
5704         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
5705         New.
5706         (regcache::save): Move it to reg_buffer.
5707         (regcache::restore): Change parameter type.
5708         (regcache_dup): Remove.
5709         * regcache.h (reg_buffer) <save>: New method.
5710         (readonly_detached_regcache): New class.
5711         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
5712         readonly_detached_regcache.
5713         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
5714
5715 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5716
5717         * frame.c (frame_save_as_regcache): Use regcache method save.
5718         (frame_pop): Use regcache method restore.
5719         * infrun.c (restore_infcall_suspend_state): Likewise.
5720         * linux-fork.c (fork_load_infrun_state): Likewise.
5721         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
5722         save.
5723         * regcache.c (regcache_save): Remove.
5724         (regcache::restore): More asserts.
5725         (regcache_cpy): Remove.
5726         * regcache.h (regcache_save): Remove the declaration.
5727         (regcache::restore): Move from private to public.
5728         Remove the friend declaration of regcache_cpy.
5729         (regcache_cpy): Remove declaration.
5730
5731 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5732
5733         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
5734         parameter type to 'readable_regcache *'.
5735         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5736         * arm-tdep.c (arm_neon_quad_read): Likewise.
5737         (arm_pseudo_read): Likewise.
5738         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5739         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5740         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5741         * gdbarch.c: Re-generated.
5742         * gdbarch.h: Re-generated.
5743         * gdbarch.sh (pseudo_register_read): Change parameter type to
5744         'readable_regcache *'.
5745         (pseudo_register_read_value): Likewise.
5746         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
5747         (h8300_pseudo_register_read): Likewise.
5748         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
5749         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5750         (i386_pseudo_register_read_into_value): Likewise.
5751         (i386_pseudo_register_read_value): Likewise.
5752         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
5753         declaration.
5754         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
5755         * m32c-tdep.c (m32c_raw_read): Likewise.
5756         (m32c_read_flg): Likewise.
5757         (m32c_banked_register): Likewise.
5758         (m32c_banked_read): Likewise.
5759         (m32c_sb_read): Likewise.
5760         (m32c_part_read): Likewise.
5761         (m32c_cat_read): Likewise.
5762         (m32c_r3r2r1r0_read): Likewise.
5763         (m32c_pseudo_register_read): Likewise.
5764         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5765         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5766         (mep_pseudo_cr64_read): Likewise.
5767         (mep_pseudo_register_read): Likewise.
5768         * mips-tdep.c (mips_pseudo_register_read): Likewise.
5769         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5770         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5771         * regcache.c (regcache::raw_read): Move it to readable_regcache.
5772         (regcache::cooked_read): Likewise.
5773         (regcache::cooked_read_value): Likewise.
5774         (regcache_cooked_read_signed):
5775         (regcache::cooked_read): Likewise.
5776         * regcache.h (readable_regcache): New class.
5777         (regcache): Inherit readable_regcache.  Move some methods to
5778         readable_regcache.
5779         * rl78-tdep.c (rl78_pseudo_register_read): Change
5780         parameter type to 'readable_regcache *'.
5781         * rs6000-tdep.c (do_regcache_raw_read): Remove.
5782         (e500_pseudo_register_read): Change parameter type to
5783         'readable_regcache *'.
5784         (dfp_pseudo_register_read): Likewise.
5785         (vsx_pseudo_register_read): Likewise.
5786         (efpr_pseudo_register_read): Likewise.
5787         * s390-tdep.c (s390_pseudo_register_read): Likewise.
5788         * sh-tdep.c (sh_pseudo_register_read): Likewise.
5789         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
5790         (sh64_pseudo_register_read): Likewise.
5791         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
5792         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
5793         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
5794         (spu_pseudo_register_read): Likewise.
5795         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
5796         (xtensa_pseudo_register_read): Likewise.
5797
5798 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5799
5800         * regcache.c (regcache::regcache): Call reg_buffer ctor.
5801         (regcache::arch): Move it to reg_buffer::arch.
5802         (regcache::register_buffer): Likewise.
5803         (regcache::assert_regnum): Likewise.
5804         (regcache::num_raw_registers): Likewise.
5805         * regcache.h (reg_buffer): New class.
5806         (regcache): Inherit reg_buffer.
5807
5808 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
5809
5810         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
5811         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
5812
5813 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
5814
5815         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
5816
5817 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
5818
5819         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
5820         (SFILES): Remove common/*.c files.
5821         (COMMON_OBS): Remove some *.o files built from common/*.c files.
5822         * common/common.host: Add common reference.
5823         * configure.ac: Likewise.
5824         * configure: Regenerate.
5825
5826 2018-02-16  Yao Qi  <yao.qi@linaro.org>
5827
5828         * block.c (block_namespace_info): Inherit allocate_on_obstack.
5829         (block_initialize_namespace): Use new.
5830         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
5831         (dwarf2_free_objfile): Use delete.
5832         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
5833         (copy_type_recursive): Use new.
5834         * gdb_obstack.h (allocate_on_obstack): New.
5835
5836 2018-02-15  Yao Qi  <yao.qi@linaro.org>
5837
5838         PR gdb/22849
5839         * inferior.c (exit_inferior_1): Reset inf->control.
5840
5841 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
5842
5843         * ada-lang.c (ada_to_fixed_value_create): Delete advance
5844         declaration.
5845
5846 2018-02-14  Pedro Alves  <palves@redhat.com>
5847
5848         * frame-unwind.c (frame_unwind_try_unwinder): Always call
5849         frame_cleanup_after_sniffer on exception.
5850
5851 2018-02-14  Tom Tromey  <tom@tromey.com>
5852
5853         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
5854         const.
5855         (solib_bfd_open): Make pathname const.
5856         * solib.c (solib_bfd_open): Make pathname const.
5857         * solib-spu.c (spu_bfd_fopen): Make name const.
5858         (spu_bfd_open): Make pathname const.
5859         * solib-darwin.c (darwin_bfd_open): Make pathname const.
5860         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
5861
5862 2018-02-14  Tom Tromey  <tom@tromey.com>
5863
5864         * symfile.c (symfile_bfd_open): Update.
5865         * source.h (openp, source_full_path_of, find_and_open_source):
5866         Change argument type to unique_xmalloc_ptr.
5867         * source.c (openp): Take a unique_xmalloc_ptr.
5868         (source_full_path_of, find_and_open_source): Likewise.
5869         (open_source_file, symtab_to_fullname): Update.
5870         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
5871         unique_xmalloc_ptr.
5872         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
5873         (exec_file_find): Update.
5874         * psymtab.c (psymtab_to_fullname): Update.
5875         * nto-tdep.h (nto_find_and_open_solib): Update.
5876         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
5877         unique_xmalloc_ptr.
5878         * exec.c (exec_file_attach): Update.
5879         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
5880         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
5881
5882 2018-02-14  Tom Tromey  <tom@tromey.com>
5883
5884         * solib.c: Include source.h.
5885         * nto-tdep.c: Include source.h.
5886         * mi/mi-cmd-env.c: Include source.h.
5887         * infcmd.c: Include source.h.
5888         * exec.c: Include source.h.
5889         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
5890         (add_path, directory_switch, source_path, init_source_path): Move
5891         declarations...
5892         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
5893         (add_path, directory_switch, source_path, init_source_path):
5894         ...here.
5895
5896 2018-02-14  Tom Tromey  <tom@tromey.com>
5897
5898         * solist.h (exec_file_find, solib_find): Return
5899         unique_xmalloc_ptr.
5900         (solib_bfd_fopen): Take a const char *.
5901         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
5902         (exec_file_find, solib_find): Likewise.
5903         (solib_bfd_fopen): Do not take ownership of "pathname".
5904         (solib_bfd_open): Use unique_xmalloc_ptr.
5905         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
5906         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
5907         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
5908         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
5909
5910 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
5911
5912         * ada-lang.c (name_match_type_from_name): Remove reference to
5913         ada_name_for_lookup in function's documentation.
5914         * ada-lang.h (ada_name_for_lookup): Delete declaration.
5915
5916 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5917
5918         * defs.h (enum openp_flags): New enum.
5919         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
5920         Move to enum openp_flags.
5921         (openp_flags): New enum flags.
5922         (openp): Change parameter type to openp_flags.
5923         * source.c (openp): Change parameter type to openp_flags.
5924         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
5925         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
5926
5927 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5928
5929         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
5930         per-command.
5931
5932 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5933
5934         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
5935         into...
5936         (class dwarf2_queue_guard): ...the destructor of this new class.
5937         (dw2_do_instantiate_symtab): Create instance of the new class
5938         dwarf2_queue_guard, remove cleanup.
5939
5940 2018-02-09  Tom Tromey  <tom@tromey.com>
5941
5942         * source.c (find_source_lines): Don't reference past the end of
5943         the vector.
5944
5945 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5946
5947         * remote.c (remote_btrace_maybe_reopen): Change error message.
5948         * btrace.c (btrace_enable): Likewise.
5949         (parse_xml_btrace): Likewise.
5950         (parse_xml_btrace_conf): Likewise.
5951
5952 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5953
5954         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
5955         (linux_enable_pt, linux_enable_bts): Call
5956         diagnose_perf_event_open_fail.
5957
5958 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5959
5960         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
5961         Remove parameter and change return type.  Update callers.  Move it.
5962         (linux_enable_bts, linux_enable_pt): Improve error message.
5963         (linux_enable_pt): Remove zero buffer size check.
5964         (linux_enable_btrace): Improve error messages.  Remove NULL return
5965         check.
5966
5967 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5968
5969         * btrace.c (btrace_enable): Remove target_supports_btrace call.
5970         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
5971         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
5972         (linux_supports_pt, linux_supports_btrace): Remove.
5973         (linux_enable_bts): Call cpu_supports_bts.
5974         * nat/linux-btrace.h (linux_supports_btrace): Remove.
5975         * remote.c (remote_supports_btrace): Remove.
5976         (init_remote_ops): Remove remote_supports_btrace.
5977         * target-delegates.c: Regenerated.
5978         * target.c (target_supports_btrace): Remove.
5979         * target.h (target_ops) <to_supports_btrace>: Remove
5980         (target_supports_btrace): Remove.
5981         * x86-linux-nat.c (x86_linux_create_target): Remove
5982         linux_supports_btrace.
5983
5984 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5985
5986         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
5987         btrace failed.
5988         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
5989         exception and use message in own exception.
5990
5991 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5992
5993         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
5994         (perf_event_pt_event_type): Use gdb_file_up.
5995         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
5996         scoped_fd, and scoped_mmap.
5997
5998 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5999
6000         * common/scoped_mmap.h: New.
6001         * unittests/scoped_mmap-selftest.c: New.
6002         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6003         unittests/scoped_mmap-selftest.c.
6004
6005 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6006
6007         * common/scoped_fd.h: New.
6008         * unittests/scoped_fd-selftest.c: New.
6009         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6010         unittests/scoped_fd-selftest.c.
6011
6012 2018-02-09  Tom Tromey  <tom@tromey.com>
6013
6014         * auto-load.c (auto_load_section_scripts): Use
6015         gdb::unique_xmalloc_ptr.
6016
6017 2018-02-09  Tom Tromey  <tom@tromey.com>
6018
6019         * auto-load.c (execute_script_contents): Use std::string.
6020
6021 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
6022
6023         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
6024         Python function, rather than a new command.
6025
6026 2018-02-08  Tom Tromey  <tom@tromey.com>
6027
6028         * solib.c (solib_find_1): Use std::string.
6029         (solib_bfd_fopen): Use unique_xmalloc_ptr.
6030
6031 2018-02-08  Tom Tromey  <tom@tromey.com>
6032
6033         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
6034
6035 2018-02-08  Tom Tromey  <tom@tromey.com>
6036
6037         * source.c (find_source_lines): Use gdb::def_vector.
6038
6039 2018-02-08  Tom Tromey  <tom@tromey.com>
6040
6041         * macrocmd.c (struct temporary_macro_definition): New.
6042         (macro_define_command): Use temporary_macro_definition.  Remove
6043         cleanups.
6044         (free_macro_definition_ptr): Remove.
6045
6046 2018-02-08  Tom Tromey  <tom@tromey.com>
6047
6048         * macroexp.c (maybe_expand): Use std::string.
6049
6050 2018-02-08  Tom Tromey  <tom@tromey.com>
6051
6052         * macroexp.c (struct macro_buffer): Add initializers for some
6053         members.
6054         (init_buffer, init_shared_buffer, free_buffer)
6055         (free_buffer_return_text): Remove.
6056         (macro_buffer): New constructors.
6057         (~macro_buffer): New destructor.
6058         (macro_buffer::set_shared): New method.
6059         (macro_buffer::resize_buffer, macro_buffer::appendc)
6060         (macro_buffer::appendmem): Now methods, not free functions.
6061         (set_token, append_tokens_without_splicing, stringify)
6062         (macro_stringify): Update.
6063         (gather_arguments): Change return type.  Remove argc_p argument,
6064         add args_ptr argument.  Use std::vector.
6065         (substitute_args): Remove argc argument.  Accept std::vector.
6066         (expand): Update.  Use std::vector.
6067         (scan, macro_expand, macro_expand_next): Update.
6068
6069 2018-02-08  Tom Tromey  <tom@tromey.com>
6070
6071         * symtab.c (default_collect_symbol_completion_matches_break_on):
6072         Use unique_xmalloc_ptr.
6073         * macroscope.h: (sal_macro_scope, user_macro_scope)
6074         (default_macro_scope): Return unique_xmalloc_ptr.
6075         * macroscope.c (sal_macro_scope, user_macro_scope)
6076         (default_macro_scope): Return unique_xmalloc_ptr.
6077         * macroexp.h (macro_expand, macro_expand_once): Return
6078         unique_xmalloc_ptr.
6079         * macroexp.c (macro_expand, macro_expand_once): Return
6080         unique_xmalloc_ptr.
6081         * macrocmd.c (macro_expand_command, macro_expand_once_command)
6082         (info_macro_command, info_macros_command): Use
6083         unique_xmalloc_ptr.
6084         * compile/compile-c-support.c (write_macro_definitions): Use
6085         unique_xmalloc_ptr.
6086         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
6087
6088 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
6089
6090         * value.c (value_static_field): Assign field type instead of
6091         containing type when returning an optimized out value.
6092
6093 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6094
6095         * ft32-tdep.c (ft32_read_pc): Remove.
6096         (ft32_write_pc): Remove.
6097         (ft32_gdbarch_init): Update.
6098         * m32r-tdep.c (m32r_read_pc): Remove.
6099         (m32r_gdbarch_init): Update.
6100         * mep-tdep.c (mep_read_pc): Remove.
6101         (mep_gdbarch_init): Update.
6102         * microblaze-tdep.c (microblaze_write_pc): Remove.
6103         (microblaze_gdbarch_init): Update.
6104         * mn10300-tdep.c (mn10300_read_pc): Remove.
6105         (mn10300_write_pc): Remove.
6106         (mn10300_gdbarch_init): Update.
6107         * moxie-tdep.c (moxie_read_pc): Remove.
6108         (moxie_write_pc): Remove.
6109         (moxie_gdbarch_init): Update.
6110
6111 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6112
6113         * expprint.c (print_subexp_standard): Handle
6114         OP_F77_UNDETERMINED_ARGLIST.
6115         (dump_subexp_body_standard): Likewise.
6116
6117 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
6118
6119         * target-descriptions.c (tdesc_element_visitor) Add empty
6120         implementations.
6121         (tdesc_type): Move make_gdb_type from here.
6122         (tdesc_type_builtin): Likewise.
6123         (tdesc_type_vector): Likewise.
6124         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
6125         (make_gdb_type_struct): Move from tdesc_type_with_fields.
6126         (make_gdb_type_union): Likewise.
6127         (make_gdb_type_flags): Likewise.
6128         (make_gdb_type_enum): Likewise.
6129         (make_gdb_type): New function.
6130         (tdesc_register_type): Use static make_gdb_type.
6131
6132 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
6133
6134         * infcmd.c (default_print_one_register_info): Align natural-format
6135         column values consistently one under another.
6136         (pad_to_column): New function.
6137
6138 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
6139
6140         * dwarf2read.c (dwarf2_physname): Move commment.
6141
6142 2018-02-01  Leszek Swirski  <leszeks@google.com>
6143
6144         * varobj.c (varobj_formatted_print_options): Allow recursive
6145         pretty printing if pretty printing is enabled.
6146
6147 2018-02-01  Leszek Swirski  <leszeks@google.com>
6148
6149         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
6150         names after a structop as a filename.
6151
6152 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6153
6154         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
6155         (arm_record_coproc_data_proc): Likewise.
6156
6157 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6158
6159         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
6160
6161 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
6162
6163         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
6164         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
6165
6166 2018-01-31  Pedro Alves  <palves@redhat.com>
6167
6168         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
6169         * inflow.c (child_terminal_save_inferior): Wrap reference to
6170         tcgetpgrp in HAVE_TERMIOS_H.
6171         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
6172         _WIN32.
6173         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
6174         always iterate over all inferiors.
6175         (gdbsim_cntrl_c): Adjust.
6176         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
6177
6178 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6179
6180         * gdbtypes.c (lookup_array_range_type): Make sure the array's
6181         index type is objfile-owned if the element type is as well.
6182
6183 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6184
6185         GDB 8.1 released.
6186
6187 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6188
6189         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
6190         "features/s390x-linux64.c".
6191         (_initialize_s390_linux_tdep): Remove initialization of tdescs
6192         s390_linux32 and s390x_linux64.
6193         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
6194         default tdesc.
6195         * s390-tdep.c: Include "features/s390-linux32.c" and
6196         "features/s390x-linux64.c".
6197         (s390_tdesc_valid): Add check for tdesc_has_registers.
6198         (s390_gdbarch_init): Make sure there is always a valid tdesc.
6199         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
6200         tdesc_s390x_linux64.
6201         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
6202         tdesc_s390x_linux64 to...
6203         * s390-tdep.h: ...here.
6204
6205 2018-01-30  Pedro Alves  <palves@redhat.com>
6206
6207         PR gdb/13211
6208         * config.in, configure: Regenerate.
6209         * configure.ac: Check for getpgid.
6210         * go32-nat.c (go32_pass_ctrlc): New.
6211         (go32_target): Install it.
6212         * inf-child.c (inf_child_target): Install
6213         child_terminal_save_inferior, child_pass_ctrlc and
6214         child_interrupt.
6215         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
6216         (inf_ptrace_target): No longer install it.
6217         * infcmd.c (interrupt_target_1): Adjust.
6218         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
6219         (child_interrupt): Declare.
6220         (inferior::terminal_state): New.
6221         * inflow.c (struct terminal_info): Update comments.
6222         (inferior_process_group): Delete.
6223         (terminal_is_ours): Delete.
6224         (gdb_tty_state): New.
6225         (child_terminal_init): Adjust.
6226         (is_gdb_terminal, sharing_input_terminal_1)
6227         (sharing_input_terminal): New functions.
6228         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
6229         Set the process's actual process group in the foreground if
6230         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
6231         mark terminal as the inferior's if not sharing GDB's terminal.
6232         Don't check attach_flag.
6233         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
6234         pass down a target_terminal_state.
6235         (child_terminal_save_inferior): New, factored out from ...
6236         (child_terminal_ours_1): ... this.  Handle
6237         target_terminal_state::is_ours_for_output.
6238         (child_interrupt, child_pass_ctrlc): New.
6239         (inflow_inferior_exit): Clear the inferior's terminal_state.
6240         (copy_terminal_info): Copy the inferior's terminal state.
6241         (_initialize_inflow): Remove reference to terminal_is_ours.
6242         * inflow.h (inferior_process_group): Delete.
6243         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
6244         * procfs.c (procfs_target): Don't install procfs_interrupt.
6245         (procfs_interrupt): Delete.
6246         * remote.c (remote_serial_quit_handler): Adjust.
6247         (remote_interrupt): Remove ptid parameter.  Adjust.
6248         * target-delegates.c: Regenerate.
6249         * target.c: Include "terminal.h".
6250         (target_terminal::terminal_state): Rename to ...
6251         (target_terminal::m_terminal_state): ... this.
6252         (target_terminal::init): Adjust.
6253         (target_terminal::inferior): Adjust to per-inferior
6254         terminal_state.
6255         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
6256         (target_terminal::ours, target_terminal::ours_for_output): Use
6257         target_terminal_is_ours_kind.
6258         (target_interrupt): Remove ptid parameter.  Adjust.
6259         (default_target_pass_ctrlc): Adjust.
6260         * target.h (target_ops::to_terminal_save_inferior): New field.
6261         (target_ops::to_interrupt): Remove ptid_t parameter.
6262         (target_interrupt): Remove ptid_t parameter.  Update comment.
6263         (target_pass_ctrlc): Update comment.
6264         * target/target.h (target_terminal_state): New scoped enum,
6265         factored out of ...
6266         (target_terminal::terminal_state): ... here.
6267         (target_terminal::inferior): Update comments.
6268         (target_terminal::restore_inferior): New.
6269         (target_terminal::is_inferior, target_terminal::is_ours)
6270         (target_terminal::is_ours_for_output): Adjust.
6271         (target_terminal::scoped_restore_terminal_state): Adjust to
6272         rename, and call restore_inferior() instead of inferior().
6273         (target_terminal::scoped_restore_terminal_state::m_state): Change
6274         type.
6275         (target_terminal::terminal_state): Rename to ...
6276         (target_terminal::m_terminal_state): ... this and change type.
6277
6278 2018-01-30  Pedro Alves  <palves@redhat.com>
6279
6280         * linux-nat.c (wait_for_signal): New function.
6281         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
6282         directly.
6283         (async_terminal_is_ours)
6284         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
6285         (linux_nat_add_target): Don't override
6286         to_terminal_inferior/to_terminal_ours.
6287
6288 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6289
6290         * remote.c (remote_follow_fork): Don't call "detach_inferior".
6291
6292 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
6293
6294         * dwarf2read.c (free_dwo_files): Add forward-declaration.
6295         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
6296         dwarf2_per_objfile_free here.
6297         (dwarf2_per_objfile_free): Remove.
6298         (_initialize_dwarf2_read): Don't register
6299         dwarf2_per_objfile_free as a registry cleanup.
6300
6301 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
6302
6303         Avoid compilation errors in MinGW native builds
6304
6305         The error is triggered by including python-internal.h, and the
6306         error message is:
6307
6308              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
6309                       from build-gnulib/import/math.h:27,
6310                       from d:/usr/Python26/include/pyport.h:235,
6311                       from d:/usr/Python26/include/Python.h:58,
6312                       from python/python-internal.h:94,
6313                       from python/py-arch.c:24:
6314              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
6315         using ::hypot;
6316                 ^~~~~
6317
6318         This happens because Python headers define 'hypot' to expand t
6319         '_hypot' in the Windows builds.
6320         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
6321         'hypoth'.  This avoids a compilation error.
6322
6323 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6324
6325         * MAINTAINERS (Write After Approval): Fix ordering.
6326
6327 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6328
6329         * MAINTAINERS (Write After Approval): Add Alan Hayward.
6330
6331 2018-01-26  Alan Modra  <amodra@gmail.com>
6332
6333         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
6334         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
6335         Remove nop.  Make const.  Comment.
6336         (powerpc32_plt_stub_so_2): New.
6337         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
6338         Correct count.  Update uses.
6339         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
6340         Move common code reading PLT entry word.  Correct
6341         powerpc32_plt_stub PLT address calculation.
6342         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
6343         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
6344         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
6345         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
6346         (ppc64_standard_linkage8): Likewise.
6347         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
6348         Correct insns description.
6349         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
6350
6351 2018-01-24  Pedro Alves  <palves@redhat.com>
6352
6353         GCC PR libstdc++/83906
6354         * gdbtypes.c (operator==(const dynamic_prop &,
6355         const dynamic_prop &)): New.
6356         (operator==(const range_bounds &, const range_bounds &)): New.
6357         (check_types_equal): Use them instead of memcmp.
6358         * gdbtypes.h (operator==(const dynamic_prop &,
6359         const dynamic_prop &)): Declare.
6360         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
6361         (operator==(const range_bounds &, const range_bounds &)): Declare.
6362         (operator!=(const range_bounds &, const range_bounds &)): Declare.
6363
6364 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6365
6366         * s390-linux-tdep.c (s390_record_address_mask)
6367         (s390_record_calc_disp_common, s390_record_calc_disp)
6368         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6369         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6370         (s390_process_record): Move to s390-tdep.c.
6371         (s390_linux_init_abi_any): Adjust.
6372         * s390-tdep.c (s390_record_address_mask)
6373         (s390_record_calc_disp_common, s390_record_calc_disp)
6374         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6375         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6376         (s390_process_record): Moved from s390-linux-tdep.c
6377         (s390_gdbarch_init): Adjust.
6378
6379 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6380
6381         * s390-linux-nat.c (s390-tdep.h): New include.
6382         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
6383         (HFILES_NO_SRCDIR): Add s390-tdep.h.
6384         (ALLDEPFILES): Add s390-tdep.c.
6385         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
6386         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
6387         * s390-tdep.h: ...this.  New file.
6388         * s390-linux-tdep.c (s390-tdep.h): New include.
6389         (_initialize_s390_tdep): Rename to...
6390         (_initialize_s390_linux_tdep): ...this and adjust.
6391         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
6392         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
6393         s390-tdep.h.
6394         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
6395         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
6396         (s390_is_partial_instruction, s390_software_single_step)
6397         (is_non_branch_ril, s390_displaced_step_copy_insn)
6398         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
6399         (s390_prologue_data, s390_addr, s390_store, s390_load)
6400         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
6401         (s390_register_call_saved, s390_guess_tracepoint_registers)
6402         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
6403         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
6404         (s390_pseudo_register_name, s390_pseudo_register_type)
6405         (s390_pseudo_register_read, s390_pseudo_register_write)
6406         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
6407         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
6408         (s390_addr_bits_remove, s390_address_class_type_flags)
6409         (s390_address_class_type_flags_to_name)
6410         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
6411         (s390_function_arg_float, s390_function_arg_vector)
6412         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
6413         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
6414         (s390_frame_align, s390_register_return_value, s390_return_value)
6415         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
6416         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
6417         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
6418         (s390_trad_frame_prev_register, s390_unwind_cache)
6419         (s390_prologue_frame_unwind_cache)
6420         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
6421         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
6422         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
6423         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
6424         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
6425         (s390_frame_base_address, s390_local_base_address)
6426         (s390_frame_base, s390_gcc_target_options)
6427         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
6428         (s390_validate_reg_range, s390_tdesc_valid)
6429         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
6430         * s390-tdep.c: ...this.  New file.
6431
6432 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6433
6434         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
6435         (s390_process_record, s390_gdbarch_tdep_alloc)
6436         (s390_linux_init_abi_any): Use/set new hook.
6437
6438 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6439
6440         * s390-linux-tdep.c (osabi.h): New include.
6441         (s390_linux_init_abi_31, s390_linux_init_abi_64)
6442         (s390_linux_init_abi_any): New functions.
6443         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
6444
6445 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6446
6447         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
6448         tdesc_has_registers check
6449
6450 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6451
6452         * s390-linux-tdep.c (s390_tdesc_valid): New function.
6453         (s390_validate_reg_range): New macro.
6454         (s390_gdbarch_init): Adjust.
6455
6456 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6457
6458         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
6459         (s390_gdbarch_tdep_alloc): Adjust.
6460         (s390_gdbarch_init): Adjust.
6461
6462 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6463
6464         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
6465         <have_tdb>: Change type to bool.
6466         (s390_gdbarch_tdep_alloc): Adjust.
6467         (s390_gdbarch_init): Adjust.
6468
6469 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6470
6471         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
6472         (gdbarch_tdep) <have_upper, have_vx>: New fields.
6473         (s390_gdbarch_tdep_alloc): New function.
6474         (s390_gdbarch_init): Allocate tdep at start and use its fields
6475         instead of separate variables.
6476
6477 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6478
6479         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
6480         when looking for cached gdbarch and add comment for remaining.
6481
6482 2018-01-22  Pedro Alves  <palves@redhat.com>
6483             Sergio Durigan Junior  <sergiodj@redhat.com>
6484
6485         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
6486         case.
6487
6488 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
6489
6490         * MAINTAINERS: Update my company e-mail address.
6491
6492 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6493
6494         * regcache.c (cooked_write_test): New function.
6495         (_initialize_regcache): Register the test.
6496
6497 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6498
6499         * ia64-tdep.c (ia64_pseudo_register_read): Call
6500         regcache->cooked_read instead of regcache_cooked_read_unsigned.
6501         * m32c-tdep.c (m32c_cat_read): Likewise.
6502         (m32c_r3r2r1r0_read): Likewise.
6503         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6504         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6505
6506 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6507
6508         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
6509         method raw_read instead of regcache_raw_read.
6510         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6511         * arm-tdep.c (arm_neon_quad_read): Likewise.
6512         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6513         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6514         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6515         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
6516         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6517         (i386_pseudo_register_read_into_value): Likewise.
6518         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6519         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6520         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6521         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
6522         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
6523         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
6524         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6525         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
6526         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
6527
6528 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6529
6530         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
6531         * configure.tgt: Remove target mt.
6532         * mt-tdep.c: Remove.
6533         * regcache.c (cooked_read_test): Remove the check for mt.
6534
6535 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6536
6537         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
6538         instead of gdbarch_pseudo_register_read_value.
6539
6540 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6541
6542         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
6543         language is Ada.
6544
6545 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6546
6547         * linespec.c (create_sals_line_offset): Remove code that preserved
6548         the symtab_and_line's line number.
6549
6550 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6551
6552         * varobj.c (varobj_create): Don't set valid_block when creating a
6553         floating varobj.
6554
6555 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6556
6557         * varobj.c (varobj_create): Remove out of date comment.
6558
6559 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6560
6561         PR mi/20395
6562         * ada-exp.y (write_var_from_sym): Pass extra parameter when
6563         updating innermost block.
6564         * parse.c (innermost_block_tracker::update): Take extra type
6565         parameter, and check types match before updating innermost block.
6566         (write_dollar_variable): Update innermost block for registers.
6567         * parser-defs.h (enum innermost_block_tracker_type): New enum.
6568         (innermost_block_tracker::innermost_block_tracker): Initialise
6569         m_types member.
6570         (innermost_block_tracker::reset): Take type parameter.
6571         (innermost_block_tracker::update): Take type parameter, and pass
6572         type through as needed.
6573         (innermost_block_tracker::m_types): New member.
6574         * varobj.c (varobj_create): Pass type when reseting innermost
6575         block.
6576
6577 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6578
6579         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
6580         * ada-lang.c (resolve_subexp): Likewise.
6581         * breakpoint.c (set_breakpoint_condition) Likewise.
6582         (watch_command_1) Likewise.
6583         * c-exp.y (variable): Likewise.
6584         * d-exp.y (PrimaryExpression): Likewise.
6585         * f-exp.y (variable): Likewise.
6586         * go-exp.y (variable): Likewise.
6587         * m2-exp.y (variable): Likewise.
6588         * objfiles.c (objfile::~objfile): Likewise.
6589         * p-exp.y (variable): Likewise.
6590         * parse.c (innermost_block): Change type.
6591         * parser-defs.h (class innermost_block_tracker): New.
6592         (innermost_block): Change to innermost_block_tracker.
6593         * printcmd.c (display_command): Switch to innermost_block API.
6594         (do_one_display): Likewise.
6595         * rust-exp.y (do_one_display): Likewise.
6596         * symfile.c (clear_symtab_users): Likewise.
6597         * varobj.c (varobj_create): Switch to innermost_block API, replace
6598         use of innermost_block with block stored on varobj object.
6599
6600 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6601
6602         * expression.h (innermost_block): Remove declaration.
6603         * varobj.c: Add 'parser-defs.h' include.
6604
6605 2018-01-19  Tom Tromey  <tom@tromey.com>
6606
6607         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
6608         symbols in the static and global blocks.
6609
6610 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
6611
6612         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
6613         gdb_ptrace.h, and move including gdb_wait.h ...
6614         * nat/linux-ptrace.h: ... to here.
6615
6616 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6617
6618         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
6619         inf_ptrace_detach_success.
6620         (inf_ptrace_detach_success): Add inferior parameter, use it
6621         instead of inferior_ptid, pass it to detach_inferior.
6622         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
6623         parameter.
6624         * inferior.c (detach_inferior): Add overload that takes an
6625         inferior object.
6626         * inferior.h (detach_inferior): Likewise.
6627         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
6628         use inferior_ptid, adjust call to inf_ptrace_detach_success.
6629         * linux-thread-db.c (thread_db_detach): Use inf parameter.
6630
6631 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6632
6633         * target.h (struct target_ops) <to_detach>: Add inferior
6634         parameter.
6635         (target_detach): Likewise.
6636         * target.c (dispose_inferior): Pass inferior down.
6637         (target_detach): Pass inferior down.  Assert that it is equal to
6638         the current inferior.
6639         * aix-thread.c (aix_thread_detach): Pass inferior down.
6640         * corefile.c (core_file_command): Pass current_inferior() down.
6641         * corelow.c (core_detach): Add inferior parameter.
6642         * darwin-nat.c (darwin_detach): Likewise.
6643         * gnu-nat.c (gnu_detach): Likewise.
6644         * inf-ptrace.c (inf_ptrace_detach): Likewise.
6645         * infcmd.c (detach_command): Pass current_inferior() down to
6646         target_detach.
6647         * infrun.c (follow_fork_inferior): Pass parent_inf to
6648         target_detach.
6649         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
6650         target_detach.
6651         * linux-nat.c (linux_nat_detach): Add inferior parameter.
6652         * linux-thread-db.c (thread_db_detach): Likewise.
6653         * nto-procfs.c (procfs_detach): Likewise.
6654         * procfs.c (procfs_detach): Likewise.
6655         * record.c (record_detach): Likewise.
6656         * record.h (struct inferior): Forward-declare.
6657         (record_detach): Add inferior parameter.
6658         * remote-sim.c (gdbsim_detach): Likewise.
6659         * remote.c (remote_detach_1): Likewise.
6660         (remote_detach): Likewise.
6661         (extended_remote_detach): Likewise.
6662         * sol-thread.c (sol_thread_detach): Likewise.
6663         * target-debug.h (target_debug_print_inferior_p): New macro.
6664         * target-delegates.c: Re-generate.
6665         * top.c (kill_or_detach): Pass inferior down to target_detach.
6666         * windows-nat.c (windows_detach): Add inferior parameter.
6667
6668 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6669
6670         * target.h (struct target_ops) <to_detach>: Remove args
6671         parameter.
6672         (target_detach): Likewise.
6673         * target.c (dispose_inferior): Adjust.
6674         (target_detach): Remove args parameter, adjust.
6675         * aix-thread.c (aix_thread_detach): Adjust.
6676         * corefile.c (core_file_command): Adjust.
6677         * corelow.c (core_detach): Adjust.
6678         * darwin-nat.c (darwin_detach): Adjust.
6679         * gnu-nat.c (gnu_detach): Adjust.
6680         * inf-ptrace.c (inf_ptrace_detach): Adjust.
6681         * infcmd.c (detach_command): Adjust
6682         * infrun.c (follow_fork_inferior): Adjust.
6683         (handle_vfork_child_exec_or_exit): Adjust.
6684         * linux-fork.c (linux_fork_detach): Remove args parameter.
6685         * linux-fork.h (linux_fork_detach): Likewise.
6686         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
6687         * linux-thread-db.c (thread_db_detach): Likewise.
6688         * nto-procfs.c (procfs_detach): Likewise.
6689         * procfs.c (procfs_detach): Likewise.
6690         (do_detach): Remove signo parameter.
6691         * record.c (record_detach): Remove args parameter.
6692         * record.h (record_detach): Likewise.
6693         * remote-sim.c (gdbsim_detach): Likewise.
6694         * remote.c (remote_detach_1): Likewise.
6695         (remote_detach): Likewise.
6696         (extended_remote_detach): Likewise.
6697         * sol-thread.c (sol_thread_detach): Likewise.
6698         * target-delegates.c: Re-generate.
6699         * top.c (struct qt_args) <args>: Remove field.
6700         (kill_or_detach): Don't pass args.
6701         (quit_force): Don't set args.
6702         * windows-nat.c (windows_detach): Remove args parameter.
6703
6704 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6705
6706         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
6707         (arm_linux_init_abi): Install it.
6708
6709 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6710
6711         * osabi.c (gdb_osabi_names): Extend the regexp for
6712         arm-linux-gnueabihf.
6713
6714 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6715
6716         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
6717         m_abbrevs.
6718         (abbrev_table::add_abbrev): Update.
6719         (abbrev_table::lookup_abbrev): Update.
6720
6721 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6722
6723         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
6724
6725 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
6726
6727         * compile/compile.c (compile_to_object): Convert "triplet_rx"
6728         to "std::string".
6729
6730 2018-01-17  Tom Tromey  <tom@tromey.com>
6731
6732         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
6733
6734 2018-01-17  Tom Tromey  <tom@tromey.com>
6735
6736         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
6737         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
6738         (create_array_type_with_stride): Update.
6739         * dwarf2read.c (set_die_type): Update.
6740
6741 2018-01-17  Tom Tromey  <tom@tromey.com>
6742
6743         * dwarf2read.c (delayed_method_info): Remove typedef.
6744         (dwarf2_cu::method_info): Now a std::vector.
6745         (add_to_method_list): Update.
6746         (free_delayed_list): Remove.
6747         (compute_delayed_physnames): Update.
6748         (process_full_comp_unit, process_full_type_unit): Clear the method
6749         list.  Remove cleanups.
6750         (psymtab_include_file_name): Add name_holder parameter.  Use
6751         unique_xmalloc_ptr.
6752         (dwarf_decode_lines): Update.
6753
6754 2018-01-17  Tom Tromey  <tom@tromey.com>
6755             Simon Marchi  <simon.marchi@ericsson.com>
6756
6757         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
6758         (dwarf2_per_objfile::free_cached_comp_units)
6759         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6760         (init_cutu_and_read_dies_no_follow): Update.
6761         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
6762         (dwarf2_cu::~dwarf2_cu): New.
6763         (free_heap_comp_unit, free_stack_comp_unit): Remove.
6764         (age_cached_comp_units, free_one_cached_comp_unit): Update.
6765
6766 2018-01-17  Tom Tromey  <tom@tromey.com>
6767             Simon Marchi  <simon.marchi@ericsson.com>
6768
6769         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
6770         (struct die_reader_specs) <abbrev_table>: New member.
6771         (struct abbrev_table): Add constructor.
6772         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
6773         <abbrev_obstack>: Now an auto_obstack.
6774         (abbrev_table_up): New typedef.
6775         (init_cu_die_reader): Add abbrev_table parameter.
6776         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
6777         Add result_dwo_abbrev_table.
6778         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6779         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
6780         Update.
6781         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
6782         parameter.
6783         (skip_children): Update.
6784         (abbrev_table::alloc_abbrev): Rename from
6785         abbrev_table_alloc_abbrev.
6786         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
6787         (abbrev_table::lookup_abbrev): Rename from
6788         abbrev_table_lookup_abbrev.
6789         (abbrev_table_read_table): Return abbrev_table_up.
6790         (abbrev_table_free, abbrev_table_free_cleanup)
6791         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
6792         (load_partial_dies): Update.
6793
6794 2018-01-17  Tom Tromey  <tom@tromey.com>
6795
6796         * dwarf2read.c (dwarf2_compute_name): Update comment.
6797         (read_func_scope, read_variable): Update.
6798         (new_symbol): Remove.
6799         (new_symbol_full): Rename to new_symbol.
6800
6801 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
6802
6803         PR gdb/16577
6804         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
6805         a warning instead of throwing an error, set section size to 0 and return
6806         NULL.
6807         * gdb_bfd.h (gdb_bfd_map_section): Update description.
6808
6809 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6810
6811         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
6812         std::string.
6813         (linux_ptrace_attach_fail_reason_string): Likewise.
6814         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
6815         Likewise.
6816         (linux_ptrace_attach_fail_reason_string): Likewise.
6817         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
6818
6819 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6820
6821         * linux-nat.c (linux_nat_attach): Remove xstrdup.
6822
6823 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
6824
6825         PR gdb/21559
6826         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
6827         checking for fs_base/gs_base fields in struct user_regs_struct.
6828         * configure: Regenerate.
6829
6830 2018-01-17  Yao Qi  <yao.qi@linaro.org>
6831
6832         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
6833         function.
6834         (aarch64_linux_init_abi): Install it to gdbarch hook
6835         gcc_target_options.
6836
6837 2018-01-15  Pedro Alves  <palves@redhat.com>
6838
6839         * common/signals-state-save-restore.c
6840         (save_original_signals_state): Fix typos.
6841
6842 2017-01-12  Tom Tromey  <tom@tromey.com>
6843             Sergio Durigan Junior  <sergiodj@redhat.com>
6844
6845         * Makefile.in (install-only): Install gdb-add-index.
6846
6847 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
6848
6849         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
6850
6851 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
6852
6853         * infrun.c (keep_going_pass_signal): Clear step-over info when
6854         insert_breakpoints fails.
6855
6856 2018-01-11  Pedro Alves  <palves@redhat.com>
6857
6858         PR gdb/22583
6859         * infrun.c (resume): Rename to ...
6860         (resume_1): ... this.
6861         (resume): Reimplement as wrapper around resume_1.
6862
6863 2018-01-11  Pedro Alves  <palves@redhat.com>
6864
6865         PR remote/22597
6866         * remote.c (remote_parse_stop_reply): Default to the last-set
6867         general thread instead of to 'magic_null_ptid'.
6868
6869 2018-01-10  Pedro Alves  <palves@redhat.com>
6870
6871         * language.h (language_get_symbol_name_matcher): Rename ...
6872         (get_symbol_name_matcher): ... this.
6873         * language.c (language_get_symbol_name_matcher): Ditto.
6874         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
6875         callers adjusted.
6876
6877 2018-01-10  Pedro Alves  <palves@redhat.com>
6878
6879         PR gdb/22670
6880         * dwarf2read.c
6881         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
6882         Adjust to use language_get_symbol_name_matcher instead of
6883         language_defn::la_get_symbol_name_matcher.
6884         * language.c (language_get_symbol_name_matcher): If in Ada mode
6885         and the lookup name is a verbatim match, return Ada's matcher.
6886         * language.h (language_get_symbol_name_matcher): Adjust comment.
6887         (ada_lookup_name_info::verbatim_p):: New method.
6888
6889 2018-01-10  Pedro Alves  <palves@redhat.com>
6890
6891         PR gdb/22670
6892         * ada-lang.c (ada_collect_symbol_completion_matches): If the
6893         minsym's language is language_auto or language_cplus, pass down
6894         language_ada instead.
6895         * symtab.c (compare_symbol_name): Don't frob symbol language here.
6896
6897 2018-01-10  Pedro Alves  <palves@redhat.com>
6898
6899         PR gdb/22670
6900         * minsyms.c (linkage_name_str): New function.
6901         (iterate_over_minimal_symbols): Use it.
6902
6903 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6904
6905         * NEWS: Document that 'info proc' now works on FreeBSD.
6906
6907 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6908
6909         * configure.ac: Check for kinfo_getfile in libutil.
6910         * configure: Regenerate.
6911         * config.in: Regenerate.
6912         * fbsd-nat.c: Include "fbsd-tdep.h".
6913         (fbsd_fetch_cmdline): New.
6914         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
6915         rather than calling error.
6916         (fbsd_info_proc): New.
6917         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
6918         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
6919         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
6920
6921 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6922
6923         * fbsd-nat.c (struct free_deleter): Remove.
6924         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
6925
6926 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6927
6928         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
6929         NULL for an empty pathname.
6930
6931 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6932
6933         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
6934         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
6935         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
6936         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
6937         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
6938         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
6939         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
6940         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
6941         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
6942         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
6943         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
6944         (fbsd_core_fetch_timeval, fbsd_print_sigset)
6945         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
6946         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
6947         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
6948
6949 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
6950
6951         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
6952         (gnu_xfer_auxv): New function.
6953         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
6954         TARGET_OBJECT_AUXV.
6955
6956 2018-01-08  Yao Qi  <yao.qi@linaro.org>
6957             Simon Marchi  <simon.marchi@ericsson.com>
6958
6959         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
6960         common/selftest.c.
6961         (COMMON_OBS): Remove selftest.o.
6962         * configure.ac: Append selftest-arch.c and common/selftest.c to
6963         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
6964         * configure: Re-generated.
6965         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
6966         GDB_SELF_TEST.
6967         (maintenance_info_selftests): Likewise.
6968
6969 2018-01-08  Xavier Roirand  <roirand@adacore.com>
6970
6971         * ada-valprint.c (val_print_packed_array_elements): Use
6972         proper number of elements when printing an array indexed
6973         by an enumeration type.
6974
6975 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6976
6977         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
6978         (dw2_get_file_names_reader): Adjust.
6979         (lookup_dwo_signatured_type): Adjust.
6980         (lookup_dwp_signatured_type): Adjust.
6981         (lookup_signatured_type): Adjust.
6982         (create_type_unit_group): Adjust.
6983         (get_type_unit_group): Adjust.
6984         (process_psymtab_comp_unit_reader): Adjust.
6985         (build_type_psymtabs_reader): Adjust.
6986         (scan_partial_symbols): Adjust.
6987         (add_partial_symbol): Adjust.
6988         (add_partial_subprogram): Adjust.
6989         (peek_die_abbrev): Adjust.
6990         (fixup_go_packaging): Adjust.
6991         (process_imported_unit_die): Adjust.
6992         (dwarf2_compute_name): Adjust.
6993         (dwarf2_physname): Adjust.
6994         (read_import_statement): Adjust.
6995         (handle_DW_AT_stmt_list): Adjust.
6996         (read_file_scope): Adjust.
6997         (read_func_scope): Adjust.
6998         (read_lexical_block_scope): Adjust.
6999         (read_call_site_scope): Adjust.
7000         (read_variable): Adjust.
7001         (dwarf2_rnglists_process): Adjust.
7002         (dwarf2_ranges_process): Adjust.
7003         (dwarf2_ranges_read): Adjust.
7004         (dwarf2_get_pc_bounds): Adjust.
7005         (dwarf2_record_block_ranges): Adjust.
7006         (dwarf2_add_field): Adjust.
7007         (dwarf2_add_member_fn): Adjust.
7008         (read_structure_type): Adjust.
7009         (process_structure_scope): Adjust.
7010         (read_enumeration_type): Adjust.
7011         (read_array_type): Adjust.
7012         (mark_common_block_symbol_computed): Adjust.
7013         (read_common_block): Adjust.
7014         (read_namespace_type): Adjust.
7015         (read_namespace): Adjust.
7016         (read_module_type): Adjust.
7017         (read_tag_pointer_type): Adjust.
7018         (read_tag_ptr_to_member_type): Adjust.
7019         (read_tag_string_type): Adjust.
7020         (read_subroutine_type): Adjust.
7021         (read_typedef): Adjust.
7022         (read_base_type): Adjust.
7023         (attr_to_dynamic_prop): Adjust.
7024         (read_subrange_type): Adjust.
7025         (read_unspecified_type): Adjust.
7026         (dwarf2_read_abbrevs): Adjust.
7027         (load_partial_dies): Adjust.
7028         (read_partial_die): Adjust.
7029         (find_partial_die): Adjust.
7030         (guess_partial_die_structure_name): Adjust.
7031         (fixup_partial_die): Adjust.
7032         (read_attribute_value): Adjust.
7033         (read_addr_index): Adjust.
7034         (read_addr_index_from_leb128): Adjust.
7035         (read_str_index): Adjust.
7036         (dwarf2_string_attr): Adjust.
7037         (get_debug_line_section): Adjust.
7038         (dwarf_decode_line_header): Adjust.
7039         (lnp_state_machine::check_line_address): Adjust.
7040         (dwarf_decode_lines_1): Adjust.
7041         (dwarf_decode_lines): Adjust.
7042         (dwarf2_start_symtab): Adjust.
7043         (var_decode_location): Adjust.
7044         (new_symbol_full): Adjust.
7045         (dwarf2_const_value_data): Adjust.
7046         (dwarf2_const_value_attr): Adjust.
7047         (dwarf2_const_value): Adjust.
7048         (die_type): Adjust.
7049         (die_containing_type): Adjust.
7050         (build_error_marker_type): Adjust.
7051         (lookup_die_type): Adjust.
7052         (guess_full_die_structure_name): Adjust.
7053         (anonymous_struct_prefix): Adjust.
7054         (determine_prefix): Adjust.
7055         (dwarf2_name): Adjust.
7056         (follow_die_ref_or_sig): Adjust.
7057         (follow_die_offset): Adjust.
7058         (follow_die_ref): Adjust.
7059         (follow_die_sig_1): Adjust.
7060         (follow_die_sig): Adjust.
7061         (get_signatured_type): Adjust.
7062         (get_DW_AT_signature_type): Adjust.
7063         (decode_locdesc): Adjust.
7064         (dwarf_decode_macros): Adjust.
7065         (cu_debug_loc_section): Adjust.
7066         (fill_in_loclist_baton): Adjust.
7067         (dwarf2_symbol_mark_computed): Adjust.
7068         (init_one_comp_unit): Don't assign
7069         dwarf2_cu::dwarf2_per_objfile.
7070         (set_die_type): Adjust.
7071
7072 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7073
7074         * dwarf2read.c (struct mapped_debug_names): Add constructor.
7075         <dwarf2_per_objfile>: New field.
7076         (dwarf2_per_objfile): Remove global.
7077         (get_dwarf2_per_objfile): New function.
7078         (set_dwarf2_per_objfile): New function.
7079         (dwarf2_build_psymtabs_hard): Change objfile parameter to
7080         dwarf2_per_objfile.
7081         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7082         (read_abbrev_offset): Likewise.
7083         (read_indirect_string): Likewise.
7084         (read_indirect_line_string): Likewise.
7085         (read_indirect_string_at_offset): Likewise.
7086         (read_indirect_string_from_dwz): Likewise.
7087         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7088         dwarf2_per_objfile.
7089         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7090         (create_all_comp_units): Change objfile parameter to
7091         dwarf2_per_objfile.
7092         (create_all_type_units): Likewise.
7093         (process_queue): Add dwarf2_per_objfile parameter.
7094         (read_and_check_comp_unit_head): Likewise.
7095         (lookup_dwo_unit_in_dwp): Likewise.
7096         (get_dwp_file): Likewise.
7097         (process_cu_includes): Likewise.
7098         (struct free_dwo_file_cleanup_data): New struct.
7099         (dwarf2_has_info): Use get_dwarf2_per_objfile and
7100         set_dwarf2_per_objfile.
7101         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
7102         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
7103         context, adjust calls.
7104         (dw2_instantiate_symtab): Likewise.
7105         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
7106         (dw2_get_cu): Likewise.
7107         (create_cu_from_index_list): Change objfile parameter to
7108         dwarf2_per_objfile.
7109         (create_cus_from_index_list): Get dwarf2_per_objfile from
7110         context, adjust calls.
7111         (create_cus_from_index): Likewise.
7112         (create_signatured_type_table_from_index): Change objfile
7113         parameter to dwarf2_per_objfile.
7114         (create_signatured_type_table_from_debug_names): Change objfile
7115         parameter to dwarf2_per_objfile.
7116         (create_addrmap_from_index): Likewise.
7117         (create_addrmap_from_aranges): Likewise.
7118         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
7119         (dw2_setup): Remove.
7120         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
7121         context.
7122         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
7123         get_dwarf2_per_objfile.
7124         (dw2_forget_cached_source_info): Likewise.
7125         (dw2_map_symtabs_matching_filename): Likewise.
7126         (struct dw2_symtab_iterator) <index>: Remove.
7127         <dwarf2_per_objfile>: New field.
7128         (dw2_symtab_iter_init): Replace index parameter with
7129         dwarf2_per_objfile.
7130         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
7131         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
7132         (dw2_print_stats): Likewise.
7133         (dw2_dump): Likewise.
7134         (dw2_expand_symtabs_for_function): Likewise.
7135         (dw2_expand_all_symtabs): Likewise.
7136         (dw2_expand_symtabs_with_fullname): Likewise.
7137         (dw2_expand_marked_cus): Replace index and objfile parameters
7138         with dwarf2_per_objfile.
7139         (dw_expand_symtabs_matching_file_matcher): Add
7140         dwarf2_per_objfile parameter and adjust calls.
7141         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
7142         adjust calls.
7143         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
7144         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
7145         adjust calls.
7146         (create_cus_from_debug_names_list): Replace objfile parameter
7147         with dwarf2_per_objfile and adjust calls.
7148         (create_cus_from_debug_names): Likewise.
7149         (dwarf2_read_debug_names): Likewise.
7150         (mapped_debug_names::namei_to_name): Adjust call.
7151         (dw2_debug_names_iterator::next): Likewise.
7152         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
7153         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
7154         (dw2_debug_names_dump): Likewise.
7155         (dw2_debug_names_expand_symtabs_for_function): Likewise.
7156         (dw2_debug_names_expand_symtabs_matching): Likewise.
7157         (dwarf2_initialize_objfile): Likewise.
7158         (dwarf2_build_psymtabs): Likewise.
7159         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
7160         this_cu.
7161         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
7162         (read_and_check_comp_unit_head): Likewise.
7163         (read_abbrev_offset): Likewise.
7164         (create_debug_type_hash_table): Likewise.
7165         (create_debug_types_hash_table): Likewise.
7166         (create_all_type_units): Replace objfile parameter with
7167         dwarf2_per_objfile.
7168         (add_type_unit): Add dwarf2_per_objfile parameter.
7169         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
7170         with dwarf2_per_objfile.
7171         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
7172         (lookup_dwp_signatured_type): Likewise.
7173         (lookup_signatured_type): Likewise.
7174         (read_cutu_die_from_dwo): Likewise.
7175         (init_tu_and_read_dwo_dies): Likewise.
7176         (init_cutu_and_read_dies): Likewise.
7177         (init_cutu_and_read_dies_no_follow): Likewise.
7178         (allocate_type_unit_groups_table): Add objfile parameter.
7179         (create_type_unit_group): Use dwarf2_per_objfile from cu.
7180         (get_type_unit_group): Likewise.
7181         (process_psymtab_comp_unit): Update call.
7182         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
7183         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
7184         (print_tu_stats): Likewise.
7185         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
7186         in void* parameter.
7187         (build_type_psymtabs): Change objfile parameter to
7188         dwarf2_per_objfile.
7189         (process_skeletonless_type_unit): Use dwarf2_per_objfile
7190         passed in void* parameter.
7191         (process_skeletonless_type_units): Change objfile parameter to
7192         dwarf2_per_objfile.
7193         (set_partial_user): Likewise.
7194         (dwarf2_build_psymtabs_hard): Likewise.
7195         (read_comp_units_from_section): Likewise.
7196         (create_all_comp_units): Likewise.
7197         (scan_partial_symbols): Update calls.
7198         (add_partial_symbol): Likewise.
7199         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
7200         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
7201         (process_queue): Add dwarf2_per_objfile parameter.
7202         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
7203         (compute_compunit_symtab_includes): Likewise.
7204         (process_cu_includes): Add dwarf2_per_objfile parameter.
7205         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
7206         (process_full_type_unit): Likewise.
7207         (process_imported_unit_die): Update call.
7208         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
7209         (read_file_scope): Likewise.
7210         (allocate_dwo_file_hash_table): Add objfile parameter.
7211         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
7212         (create_cus_hash_table): Likewise.
7213         (create_dwp_hash_table): Likewise.
7214         (create_dwo_unit_in_dwp_v1): Likewise.
7215         (create_dwp_v2_section): Likewise.
7216         (create_dwo_unit_in_dwp_v2): Likewise.
7217         (lookup_dwo_unit_in_dwp): Likewise.
7218         (try_open_dwop_file): Likewise.
7219         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
7220         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
7221         cleanup to include a reference to dwarf2_per_objfile.
7222         (open_dwp_file): Add dwarf2_per_objfile parameter.
7223         (open_and_init_dwp_file): Likewise.
7224         (get_dwp_file): Likewise.
7225         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
7226         (queue_and_load_all_dwo_tus): Update call.
7227         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
7228         data.
7229         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
7230         (dwarf2_ranges_process): Likewise.
7231         (dwarf2_get_pc_bounds): Likewise.
7232         (mark_common_block_symbol_computed): Likewise.
7233         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7234         (dwarf2_read_abbrevs): Update call.
7235         (read_partial_die): Use dwarf2_per_objfile from cu.
7236         (find_partial_die): Likewise.
7237         (fixup_partial_die): Likewise.
7238         (read_attribute_value): Likewise.
7239         (read_indirect_string_at_offset_from): Add objfile parameter.
7240         (read_indirect_string_at_offset): Add dwarf2_per_objfile
7241         parameter.
7242         (read_indirect_string_from_dwz): Add objfile parameter.
7243         (read_indirect_string): Add objfile parameter.
7244         (read_addr_index_1): Add dwarf2_per_objfile parameter.
7245         (read_addr_index): Use dwarf2_per_objfile from cu.
7246         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
7247         call dw2_setup.
7248         (read_str_index): Use dwarf2_per_objfile from cu.
7249         (get_debug_line_section): Likewise.
7250         (read_formatted_entries): Add dwarf2_per_objfile parameter.
7251         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
7252         (new_symbol_full): Use dwarf2_per_objfile from cu.
7253         (build_error_marker_type): Likewise.
7254         (lookup_die_type): Likewise.
7255         (determine_prefix): Likewise.
7256         (follow_die_offset): Likewise.
7257         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
7258         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
7259         (dwarf2_fetch_die_type_sect_off): Likewise.
7260         (dwarf2_get_die_type): Likewise.
7261         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
7262         (get_signatured_type): Likewise.
7263         (get_DW_AT_signature_type): Likewise.
7264         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
7265         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
7266         (cu_debug_loc_section): Likewise.
7267         (fill_in_loclist_baton): Likewise.
7268         (dwarf2_symbol_mark_computed): Likewise.
7269         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7270         dwarf2_per_objfile.
7271         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
7272         parameter.
7273         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7274         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
7275         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
7276         (set_die_type): Use dwarf2_free_objfile from cu.
7277         (get_die_type_at_offset): Likewise.
7278         (dwarf2_per_objfile_free): Don't assign global variable.
7279         (debug_names) <constructor>: Add dwarf2_per_objfile
7280         parameter, update m_debugstrlookup construction.
7281         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
7282         parameter.
7283         <m_dwarf2_per_objfile>: New field.
7284         <lookup>: Use m_dwarf2_per_objfile.
7285         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
7286         (psyms_seen_size): Likewise.
7287         (write_gdbindex): Replace objfile parameter with
7288         dwarf2_per_objfile.
7289         (write_debug_names): Likewise.
7290         (write_psymtabs_to_index): Likewise.
7291         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
7292         calls.
7293
7294 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7295
7296         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
7297         <dwarf2_per_objfile>: New field.
7298         (struct dwarf2_per_cu_data) <objfile>: Remove.
7299         <dwarf2_per_objfile>: New field.
7300         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
7301         of objfile.
7302         (create_signatured_type_table_from_index): Likewise.
7303         (create_debug_type_hash_table): Likewise.
7304         (fill_in_sig_entry_from_dwo_entry): Likewise.
7305         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
7306         (create_type_unit_group): Assign dwarf2_per_objfile instead of
7307         objfile.
7308         (create_partial_symtab): Access objfile through
7309         dwarf2_per_objfile.
7310         (process_psymtab_comp_unit_reader): Likewise.
7311         (read_comp_units_from_section): Likewise.
7312         (scan_partial_symbols): Likewise.
7313         (add_partial_symbol): Likewise.
7314         (add_partial_subprogram): Likewise.
7315         (peek_die_abbrev): Likewise.
7316         (fixup_go_packaging): Likewise.
7317         (process_full_comp_unit): Likewise.
7318         (process_full_type_unit): Likewise.
7319         (process_imported_unit_die): Likewise.
7320         (dwarf2_compute_name): Likewise.
7321         (dwarf2_physname): Likewise.
7322         (read_import_statement): Likewise.
7323         (create_cus_hash_table): Assign dwarf2_physname instead of
7324         objfile.
7325         (read_func_scope): Access objfile through dwarf2_per_objfile.
7326         (read_lexical_block_scope): Likewise.
7327         (read_call_site_scope): Likewise.
7328         (read_variable): Likewise.
7329         (dwarf2_rnglists_process): Likewise.
7330         (dwarf2_ranges_process): Likewise.
7331         (dwarf2_ranges_read): Likewise.
7332         (dwarf2_record_block_ranges): Likewise.
7333         (dwarf2_add_field): Likewise.
7334         (dwarf2_add_member_fn): Likewise.
7335         (read_structure_type): Likewise.
7336         (process_structure_scope): Likewise.
7337         (read_enumeration_type): Likewise.
7338         (read_array_type): Likewise.
7339         (read_common_block): Likewise.
7340         (read_namespace_type): Likewise.
7341         (read_namespace): Likewise.
7342         (read_module_type): Likewise.
7343         (read_tag_pointer_type): Likewise.
7344         (read_tag_ptr_to_member_type): Likewise.
7345         (read_tag_string_type): Likewise.
7346         (read_subroutine_type): Likewise.
7347         (read_typedef): Likewise.
7348         (read_base_type): Likewise.
7349         (attr_to_dynamic_prop): Likewise.
7350         (read_subrange_type): Likewise.
7351         (read_unspecified_type): Likewise.
7352         (load_partial_dies): Likewise.
7353         (read_partial_die): Likewise.
7354         (find_partial_die): Likewise.
7355         (guess_partial_die_structure_name): Likewise.
7356         (fixup_partial_die): Likewise.
7357         (read_attribute_value): Likewise.
7358         (read_addr_index_from_leb128): Likewise.
7359         (dwarf2_read_addr_index): Likewise.
7360         (dwarf2_string_attr): Likewise.
7361         (lnp_state_machine::check_line_address): Likewise.
7362         (dwarf_decode_lines_1): Likewise.
7363         (dwarf_decode_lines): Likewise.
7364         (dwarf2_start_symtab): Likewise.
7365         (var_decode_location): Likewise.
7366         (new_symbol_full): Likewise.
7367         (dwarf2_const_value_data): Likewise.
7368         (dwarf2_const_value_attr): Likewise.
7369         (dwarf2_const_value): Likewise.
7370         (die_type): Likewise.
7371         (die_containing_type): Likewise.
7372         (lookup_die_type): Likewise.
7373         (guess_full_die_structure_name): Likewise.
7374         (anonymous_struct_prefix): Likewise.
7375         (dwarf2_name): Likewise.
7376         (follow_die_ref_or_sig): Likewise.
7377         (follow_die_offset): Likewise.
7378         (follow_die_ref): Likewise.
7379         (dwarf2_fetch_die_loc_sect_off): Likewise.
7380         (dwarf2_fetch_constant_bytes): Likewise.
7381         (dwarf2_fetch_die_type_sect_off): Likewise.
7382         (dwarf2_get_die_type): Likewise.
7383         (follow_die_sig): Likewise.
7384         (decode_locdesc): Likewise.
7385         (dwarf2_per_cu_objfile): Likewise.
7386         (dwarf2_per_cu_text_offset): Likewise.
7387         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
7388         objfile.
7389         (set_die_type): Access objfile through
7390         dwarf2_per_objfile.
7391
7392 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7393
7394         * valprint.c (converted_character_d): Remove typedef.
7395         (DEF_VEC_O (converted_character_d)): Remove.
7396         (count_next_character): Use std::vector.
7397         (print_converted_chars_to_obstack): Likewise.
7398         (generic_printstr): Likewise.
7399
7400 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7401
7402         * xml-support.h (struct gdb_xml_value): Add constructor.
7403         <value>: Change type to unique_xmalloc_ptr.
7404         (gdb_xml_value_s): Remove typedef.
7405         (DEF_VEC_O (gdb_xml_value_s)): Remove.
7406         (gdb_xml_element_start_handler): Change parameter type to
7407         std::vector.
7408         (xml_find_attribute): Likewise.
7409         * xml-support.c (xml_find_attribute): Change parameter type to
7410         std::vector and adjust.
7411         (gdb_xml_values_cleanup): Remove.
7412         (gdb_xml_parser::start_element): Adjust to std::vector.
7413         (xinclude_start_include): Change paraeter type to std::vector
7414         and adjust.
7415         * btrace.c (check_xml_btrace_version): Likewise.
7416         (parse_xml_btrace_block): Likewise.
7417         (parse_xml_btrace_pt_config_cpu): Likewise.
7418         (parse_xml_btrace_pt): Likewise.
7419         (parse_xml_btrace_conf_bts): Likewise.
7420         (parse_xml_btrace_conf_pt): Likewise.
7421         * memory-map.c (memory_map_start_memory): Likewise.
7422         (memory_map_start_property): Likewise.
7423         * osdata.c (osdata_start_osdata): Likewise.
7424         (osdata_start_item): Likewise.
7425         (osdata_start_column): Likewise.
7426         * remote.c (start_thread): Likewise.
7427         * solib-aix.c (library_list_start_library): Likewise.
7428         (library_list_start_list): Likewise.
7429         * solib-svr4.c (library_list_start_library): Likewise.
7430         (svr4_library_list_start_list): Likewise.
7431         * solib-target.c (library_list_start_segment): Likewise.
7432         (library_list_start_section): Likewise.
7433         (library_list_start_library): Likewise.
7434         (library_list_start_list): Likewise.
7435         * tracepoint.c (traceframe_info_start_memory): Likewise.
7436         (traceframe_info_start_tvar): Likewise.
7437         * xml-syscall.c (syscall_start_syscall): Likewise.
7438         * xml-tdesc.c (tdesc_start_target): Likewise.
7439         (tdesc_start_feature): Likewise.
7440         (tdesc_start_reg): Likewise.
7441         (tdesc_start_union): Likewise.
7442         (tdesc_start_struct): Likewise.
7443         (tdesc_start_flags): Likewise.
7444         (tdesc_start_enum): Likewise.
7445         (tdesc_start_field): Likewise.
7446         (tdesc_start_enum_value): Likewise.
7447         (tdesc_start_vector): Likewise.
7448
7449 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7450
7451         * extension.h (struct xmethod_worker) <clone>: Remove.
7452         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
7453         Remove.
7454         (python_xmethod_worker::clone): Remove.
7455         * valops.c (find_overload_match): Use std::move instead of
7456         clone.
7457
7458 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7459
7460         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
7461         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
7462         <free_xmethod_worker_data>: Remove.
7463         <get_matching_xmethod_workers>: Chance VEC to std::vector.
7464         <get_xmethod_arg_types>: Remove.
7465         <get_xmethod_result_type>: Remove.
7466         <invoke_xmethod>: Remove.
7467         * extension.c (new_xmethod_worker): Remove.
7468         (clone_xmethod_worker): Remove.
7469         (get_matching_xmethod_workers): Return void, pass std::vector by
7470         pointer.
7471         (get_xmethod_arg_types): Rename to...
7472         (xmethod_worker::get_arg_types): ... this, and adjust.
7473         (get_xmethod_result_type): Rename to...
7474         (xmethod_worker::get_result_type): ... this, and adjust.
7475         (invoke_xmethod): Remove.
7476         (free_xmethod_worker): Remove.
7477         (free_xmethod_worker_vec): Remove.
7478         * extension.h (enum ext_lang_rc): Move here from
7479         extension-priv.h.
7480         (struct xmethod_worker): Add constructor and destructor.
7481         <data>: Remove.
7482         <value>: Remove.
7483         <invoke, clone, do_get_result_type, do_get_arg_types>: New
7484         virtual pure methods.
7485         <get_arg_types, get_result_type>: New methods.
7486         (xmethod_worker_ptr): Remove typedef.
7487         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
7488         (xmethod_worker_vec): Remove typedef.
7489         (xmethod_worker_up): New typedef.
7490         (invoke_xmethod): Remove.
7491         (clone_xmethod_worker): Remove.
7492         (free_xmethod_worker): Remove.
7493         (free_xmethod_worker_vec): Remove.
7494         (get_xmethod_arg_types): Remove.
7495         (get_xmethod_result_type): Remove.
7496         * valops.c (find_method_list): Use std::vector, don't use
7497         intermediate vector.
7498         (value_find_oload_method_list): Use std::vector.
7499         (find_overload_match): Use std::vector.
7500         (find_oload_champ): Use std::vector.
7501         * value.c (value_free): Use operator delete.
7502         (value_of_xmethod): Rename to...
7503         (value_from_xmethod): ... this.  Don't assign
7504         xmethod_worker::value, take rvalue-reference.
7505         (result_type_of_xmethod): Adjust.
7506         (call_xmethod): Adjust.
7507         * value.h: Include extension.h.
7508         (struct xmethod_worker): Don't forward-declare.
7509         (value_of_xmethod): Rename to...
7510         (value_from_xmethod): ... this, take rvalue-reference.
7511         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
7512         (struct python_xmethod_worker): ... this, add constructor and
7513         destructor.
7514         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
7515         (gdbpy_free_xmethod_worker_data): Rename to...
7516         (python_xmethod_worker::~python_xmethod_worker): ... this and
7517         adjust.
7518         (gdbpy_clone_xmethod_worker_data): Rename to...
7519         (python_xmethod_worker::clone): ... this and adjust.
7520         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
7521         temporary vector.
7522         (gdbpy_get_xmethod_arg_types): Rename to...
7523         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
7524         (gdbpy_get_xmethod_result_type): Rename to...
7525         (python_xmethod_worker::do_get_result_type): ... this and
7526         adjust.
7527         (gdbpy_invoke_xmethod): Rename to...
7528         (python_xmethod_worker::invoke): ... this and adjust.
7529         (new_python_xmethod_worker): Rename to...
7530         (python_xmethod_worker::python_xmethod_worker): ... this and
7531         adjust.
7532         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
7533         Remove.
7534         (gdbpy_free_xmethod_worker_data): Remove.
7535         (gdbpy_get_matching_xmethod_workers): Use std::vector.
7536         (gdbpy_get_xmethod_arg_types): Remove.
7537         (gdbpy_get_xmethod_result_type): Remove.
7538         (gdbpy_invoke_xmethod): Remove.
7539         * python/python.c (python_extension_ops): Remove obsolete
7540         callbacks.
7541
7542 2018-01-05  Pedro Alves  <palves@redhat.com>
7543
7544         PR gdb/18653
7545         * common/signals-state-save-restore.c
7546         (save_original_signals_state): New parameter 'quiet'.  Warn if we
7547         find a custom handler preinstalled, instead of internal erroring.
7548         But only warn if !quiet.
7549         * common/signals-state-save-restore.h
7550         (save_original_signals_state): New parameter 'quiet'.
7551         * main.c (captured_main_1): Move save_original_signals_state call
7552         after option handling, and pass QUIET.
7553
7554 2018-01-05  Pedro Alves  <palves@redhat.com>
7555
7556         * spu-tdep.c (spu_catch_start): Pass
7557         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
7558
7559 2018-01-05  Pedro Alves  <palves@redhat.com>
7560
7561         PR gdb/22670
7562         * ada-lang.c (literal_symbol_name_matcher): New function.
7563         (ada_get_symbol_name_matcher): Use it for
7564         symbol_name_match_type::SEARCH_NAME.
7565         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
7566         it down instead of assuming symbol_name_match_type::FULL.
7567         * block.h (block_lookup_symbol): New parameter 'match_type'.
7568         * c-valprint.c (print_unpacked_pointer): Use
7569         lookup_symbol_search_name instead of lookup_symbol.
7570         * compile/compile-object-load.c (get_out_value_type): Pass down
7571         symbol_name_match_type::SEARCH_NAME.
7572         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
7573         symbol_name_match_type::FULL.
7574         * cp-support.c (cp_get_symbol_name_matcher): Handle
7575         symbol_name_match_type::SEARCH_NAME.
7576         * infrun.c (insert_exception_resume_breakpoint): Use
7577         lookup_symbol_search_name.
7578         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
7579         * psymtab.c (maintenance_check_psymtabs): Use
7580         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
7581         * stack.c (print_frame_args): Use lookup_symbol_search_name and
7582         SYMBOL_SEARCH_NAME.
7583         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
7584         if symbol_name_match_type::SEARCH_NAME.
7585         (lookup_symbol_in_language): Pass down
7586         symbol_name_match_type::FULL.
7587         (lookup_symbol_search_name): New.
7588         (lookup_language_this): Pass down
7589         symbol_name_match_type::SEARCH_NAME.
7590         (lookup_symbol_aux, lookup_local_symbol): New parameter
7591         'match_type'.  Pass it down.
7592         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
7593         (lookup_symbol_search_name): New declaration.
7594         (lookup_symbol_in_block): New 'match_type' parameter.
7595
7596 2018-01-05  Pedro Alves  <palves@redhat.com>
7597
7598         PR gdb/22670
7599         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
7600         ada_lookup_symbol.
7601         (ada_lookup_symbol): Reimplement in terms of
7602         ada_lookup_symbol_list, bits factored out from
7603         ada_lookup_encoded_symbol.
7604
7605 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7606
7607         * ada-exp.y (write_object_renaming): When subscripting an array
7608         using a symbol as the index, pass the block in call to
7609         ada_lookup_encoded_symbol when looking that symbol up.
7610
7611 2018-01-05  Jerome Guitton  <guitton@adacore.com>
7612
7613         * ada-lang.c (ada_array_length): Use ada_index_type instead of
7614         TYPE_INDEX_TYPE.
7615
7616 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7617
7618         * ada-lang.c (ada_to_fixed_value_create): Add handling of
7619         the case where VALUE_LVAL (val0) is not lval_memory.
7620
7621 2018-01-05  Xavier Roirand  <roirand@adacore.com>
7622
7623         * ada-valprint.c (print_optional_low_bound): Handle
7624         character-indexed array printing like boolean-indexed array
7625         printing.
7626
7627 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7628
7629         * NEWS: Create a new section for the next release branch.
7630         Rename the section of the current branch, now that it has
7631         been cut.
7632
7633 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7634
7635         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
7636         * version.in: Bump version to 8.1.50.DATE-git.
7637
7638 2018-01-03  Xavier Roirand  <roirand@adacore.com>
7639
7640         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
7641         Add field.
7642         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
7643         Add field.
7644         (default_exception_support_info) <catch_handlers_sym>: Add field.
7645         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
7646         (ada_exception_name_addr_1): Add "catch handlers" handling.
7647         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
7648         Update all callers.
7649         (create_excep_cond_exprs) <ex>: Add parameter.
7650         (re_set_exception): Update create_excep_cond_exprs call.
7651         (print_it_exception, print_one_exception, print_mention_exception)
7652         (print_recreate_exception): Add "catch handler" handling.
7653         (allocate_location_catch_handlers, re_set_catch_handlers)
7654         (check_status_catch_handlers, print_it_catch_handlers)
7655         (print_one_catch_handlers, print_mention_catch_handlers)
7656         (print_recreate_catch_handlers): New function.
7657         (catch_handlers_breakpoint_ops): New variable.
7658         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
7659         Add parameter.  Add "catch handler" handling.
7660         (ada_exception_sym_name, ada_exception_breakpoint_ops):
7661         Add "catch handler" handling.
7662         (ada_exception_catchpoint_cond_string): Add "catch handler"
7663         handling.
7664         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
7665         call.
7666         (catch_ada_handlers_command): New function.
7667         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
7668         operations structure.
7669         (_initialize_ada_language): Add "catch handlers" command entry.
7670         * NEWS: Document "catch handlers" feature.
7671
7672 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7673
7674         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
7675         account when creating the array type of the slice.
7676         (ada_value_slice): Likewise.
7677
7678 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7679
7680         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
7681         New enum value.
7682         (create_array_type_with_stride): Add byte_stride_prop parameter.
7683         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
7684         New parameter.  Update all callers in this file.
7685         (array_type_has_dynamic_stride): New function.
7686         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
7687         of arrays with dynamic byte strides.
7688         * dwarf2read.c (read_array_type): Add support for dynamic
7689         DW_AT_byte_stride attributes.
7690
7691 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7692
7693         * dwarf2read.c (read_unspecified_type): Treat
7694         DW_TAG_enumeration_type DIEs from Ada units as stubs.
7695
7696 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7697
7698         Update copyright year range in all GDB files.
7699
7700 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7701
7702         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
7703         and gdb/testsuite/gdb.base/step-line.c.
7704
7705 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7706
7707         * copyright.py (main): Dump the contents of
7708         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
7709         even if BY_HAND is empty.
7710
7711 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7712
7713         * top.c (print_gdb_version): Update Copyright year in version
7714         message.
7715
7716 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7717
7718         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
7719
7720 For older changes see ChangeLog-2017.
7721 \f
7722 Local Variables:
7723 mode: change-log
7724 left-margin: 8
7725 fill-column: 74
7726 version-control: never
7727 coding: utf-8
7728 End: