Set GDB version number to 8.2.91.
[external/binutils.git] / gdb / ChangeLog
1 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2
3         * version.in: Set GDB version number to 8.2.91.
4
5 2019-03-20  Tom Tromey  <tromey@adacore.com>
6
7         PR gdb/24391
8         * infrun.c (handle_inferior_event): Rename from
9         handle_inferior_event_1.  Create a scoped_value_mark.
10         (handle_inferior_event): Remove.
11
12 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13
14         * source-cache.c (source_cache::get_source_lines): Re-read
15         fullname after calling open_source_file.
16
17 2019-03-18  Pedro Alves  <palves@redhat.com>
18             Eli Zaretskii <eliz@gnu.org>
19
20         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
21         m_line and m_start_of_line.
22
23 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
24
25         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
26         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
27         it returns a newline.  This fixes a regression in TU mode, whereby
28         the next line is output on the same screen line as the user input.
29
30 2019-03-18  Pedro Alves  <palves@redhat.com>
31
32         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
33         New globals.
34         (apply_style): New, factored out from ...
35         (apply_ansi_escape): ... this.  Handle reverse video mode.
36         (tui_set_reverse_mode): New function.
37         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
38         * tui/tui-winsource.c (tui_show_source_line): Use
39         tui_set_reverse_mode instead of setting A_STANDOUT.
40         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
41         New setter methods.
42
43 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
44
45         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
46         Handle tabs.
47
48 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
49
50         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
51         tui_refill_source_window instead of tui_refresh_win, to update the
52         current execution line.  This fixes redisplay of the current line
53         when stepping through the code with "next" or "step".
54
55 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
56
57         * source-cache.c (source_cache::get_source_lines): Call
58         find_source_lines to initialize s->nlines.  This fixes vertical
59         scrolling of TUI source window when the DOWN arrow is pressed.
60
61 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
62
63         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
64         wclrtoeol in tui_show_source_line".  This reverts changes made in
65         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
66
67 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
68
69         * NEWS: Combine separate "New targets" sections for 8.3.
70
71 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
72
73         The MS-Windows port of ncurses fails to switch to a color pair if
74         one or both of the colors are the implicit default colors.  This
75         change records the default colors when TUI is initialized, and
76         then specifies them explicitly when a color pair uses the default
77         colors.  This allows color styling in TUI mode on MS-Windows.
78
79         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
80         ncurses_norm_attr.
81         (tui_initialize_io) [__MINGW32__]: Record the default terminal
82         colors in ncurses_norm_attr.
83         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
84         "none", replace it with the default color recorded in
85         ncurses_norm_attr.
86
87 2019-03-14  Tom Tromey  <tromey@adacore.com>
88
89         * source-cache.h (class source_cache) <get_source_lines>: Return
90         std::string.
91         * source-cache.c (source_cache::extract_lines): Handle case where
92         first_pos==npos.  Return std::string.
93         (source_cache::get_source_lines): Update.
94
95 2019-03-14  Tom Tromey  <tromey@adacore.com>
96
97         * NEWS: Add item for "style sources" commands.
98         * source-cache.c (source_cache::get_source_lines): Check
99         source_styling.
100         * cli/cli-style.c (source_styling): New global.
101         (_initialize_cli_style): Add "style sources" commands.
102         (show_style_sources): New function.
103         * cli/cli-style.h (source_styling): Declare.
104
105 2019-03-14  Pedro Alves  <palves@redhat.com>
106             Tom Tromey  <tromey@adacore.com>
107
108         * tui/tui-winsource.h (tui_refill_source_window): Declare.
109         * tui/tui-winsource.c (tui_refill_source_window): New function,
110         from...
111         (tui_horizontal_source_scroll): ... here.  Move some logic.
112         * cli/cli-style.c (set_style_enabled): Notify new observable.
113         * tui/tui-hooks.c (tui_redisplay_source): New function.
114         (tui_attach_detach_observers): Attach or detach
115         tui_redisplay_source.
116         * observable.h (source_styling_changed): New observable.
117         * observable.c: Define source_styling_changed observable.
118
119 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
120
121         PR/24325
122         * source-cache.c: #undef open and close, to avoid unresolved
123         externals during linking.
124
125 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
126
127         Support styling on native MS-Windows console
128
129         PR/24315
130         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
131         on MS-Windows if $TERM is not defined.
132
133         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
134
135         * posix-hdep.c (gdb_console_fputs):
136         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
137         functions.
138         * ui-file.h (gdb_console_fputs): Add prototype.
139
140         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
141         back to fputs only if the former returns zero.
142
143 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
144             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
145
146         PR gdb/8527
147         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
148         set_sigint_trap, clear_sigint_trap.
149
150 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
151
152         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
153         for-loop range, to avoid compiler warnings.
154
155         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
156         avoid compiler warnings about unused variables.
157
158 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
159
160         * NEWS: Mention end of support for native debugging on MS-Windows
161         before XP.
162
163 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
164
165         PR gdb/24292
166         * common/netstuff.c:
167         * gdbserver/gdbreplay.c
168         * gdbserver/remote-utils.c:
169         * ser-tcp.c:
170         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
171         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
172         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
173         'getaddrinfo' and 'freeaddrinfo' were not available before
174         Windows XP, and mingw.org's MinGW headers by default define
175         _WIN32_WINNT to 0x500.
176
177 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
178     
179         * NEWS: Note minimum Python version.
180
181 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
182
183         * version.in: Set GDB version number to 8.2.90.DATE-git.
184
185 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
186
187         GDB 8.2.90 released.
188
189 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
190
191         * version.in: Set GDB version number to 8.2.90.
192
193 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
194
195         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
196
197 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
198
199         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
200         * version.in: Bump version to 8.2.90.DATE-git.
201
202 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
203
204         * aix-thread.c (ptid_cmp): Remove unused variable.
205         (get_signaled_thread): Likewise.
206         (store_regs_user_thread): Likewise.
207         (store_regs_kernel_thread): Likewise.
208         (fetch_regs_kernel_thread): Remove shadowed variable.
209
210 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
211
212         * features/riscv/32bit-cpu.xml: Add register numbers.
213         * features/riscv/32bit-fpu.c: Regenerate.
214         * features/riscv/32bit-fpu.xml: Add register numbers.
215         * features/riscv/64bit-cpu.xml: Add register numbers.
216         * features/riscv/64bit-fpu.c: Regenerate.
217         * features/riscv/64bit-fpu.xml: Add register numbers.
218
219 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
220
221         * NEWS: Mention two argument form of gdb.Value constructor.
222         * python/py-value.c (convert_buffer_and_type_to_value): New
223         function.
224         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
225         Add support for handling an optional second argument.  Call
226         convert_buffer_and_type_to_value as appropriate.
227         * python/python-internal.h (Py_buffer_deleter): New struct.
228         (Py_buffer_up): New typedef.
229
230 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
231
232         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
233         instead of releasing ownership.
234
235 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
236
237         * dwarf2read.c (open_and_init_dwp_file): Call
238         elf_numsections instead of bfd_count_sections to initialize
239         dwp_file->num_sections.
240
241 2019-02-25  Tom Tromey  <tromey@adacore.com>
242
243         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
244
245 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
246
247         * gcore.in: Add '--readnever' option when invoking GDB.
248
249 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
250
251         * MAINTAINERS: Update my email address.
252
253 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
254
255         * build-id.c (build_id_to_debug_bfd_1): New function.
256         (build_id_to_debug_bfd): Look for separate debug file in
257         sysroot.
258
259 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
260
261         * gdbarch.sh: Update the copyright year range that is placed into
262         generated files.
263
264 2019-02-22  Keith Seitz  <keiths@redhat.com>
265
266         PR symtab/23853
267         * linespec.c (create_sals_line_offset): Search for the default
268         symtab's filename instead of its fullname.
269
270 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
271
272         * NEWS: Update style defaults.
273
274 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
275
276         * main.c (captured_main_1): Disable styling in batch mode.
277
278 2019-02-20  Tom Tromey  <tom@tromey.com>
279
280         * symtab.c (symtab_symbol_info): Fix typos.
281
282 2019-02-20  Tom Tromey  <tromey@adacore.com>
283
284         * findcmd.c (_initialize_mem_search): Use upper case for
285         metasyntactic variables.
286
287 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
288
289         * aarch64-tdep.c (aarch64_add_reggroups): New function.
290         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
291
292 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
293
294         * top.h (source_file_name): Change to std::string.
295         * top.c (source_file_name): Likewise.
296         (command_line_input): Adjust.
297         * cli/cli-script.c (script_from_file): Adjust.
298
299 2019-02-19  Tom Tromey  <tromey@adacore.com>
300
301         * ravenscar-thread.c
302         (ravenscar_thread_target::update_thread_list): Don't call
303         ada_build_task_list.
304         * ada-lang.h (ada_build_task_list): Don't declare.
305         * ada-tasks.c (struct ada_tasks_inferior_data)
306         <task_list_valid_p>: Now bool.
307         (read_known_tasks, ada_task_list_changed)
308         (ada_tasks_invalidate_inferior_data): Update.
309         (read_known_tasks_array): Return bool.
310         (read_known_tasks_list): Likewise.
311         (read_known_tasks): Return void.
312         (ada_build_task_list): Now static.
313
314 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
315
316         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
317         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
318
319 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
320
321         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
322         variant for ada_tasks_pspace_data_handle and
323         ada_tasks_inferior_data_handle.
324         (ada_tasks_pspace_data_cleanup): New function.
325         (ada_tasks_inferior_data_cleanup): New function.
326
327 2019-02-17  Tom Tromey  <tom@tromey.com>
328
329         * macrotab.h (macro_source_fullname): Return a std::string.
330         * macrotab.c (macro_include, check_for_redefinition)
331         (macro_undef, macro_lookup_definition, foreach_macro)
332         (foreach_macro_in_scope): Update.
333         (macro_source_fullname): Return a std::string.
334         * macrocmd.c (show_pp_source_pos): Update.
335
336 2019-02-17  Tom Tromey  <tom@tromey.com>
337
338         * macrocmd.c (show_pp_source_pos): Style the file names.
339
340 2019-02-17  Tom Tromey  <tom@tromey.com>
341
342         PR tui/24197:
343         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
344
345 2019-02-17  Tom Tromey  <tom@tromey.com>
346
347         * ada-lang.c (user_select_syms): Use filtered printing.
348         * utils.c (wrap_style): New global.
349         (desired_style): Remove.
350         (emit_style_escape): Add stream parameter.
351         (set_output_style, reset_terminal_style, prompt_for_continue):
352         Update.
353         (flush_wrap_buffer): Only flush gdb_stdout.
354         (wrap_here): Set wrap_style.
355         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
356         treat escape sequences as a character.  Change when wrap buffer is
357         flushed.
358         (fputs_styled): Do not set the output style when the default is
359         requested.
360         * ui-style.h (struct ui_file_style) <is_default>: New method.
361         * source.c (print_source_lines_base): Emit escape sequences in one
362         piece.
363
364 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
365
366         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
367         integers and enumeration types.
368
369 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
370
371         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
372         instead of lookup_symbol_in_language
373         (do_exact_match): New function.
374         (ada_get_symbol_name_matcher): Return do_exact_match when
375         doing a verbatim match.
376
377 2019-02-15  Tom Tromey  <tromey@adacore.com>
378
379         * ravenscar-thread.c (ravenscar_thread_target::resume)
380         (ravenscar_thread_target::wait): Special case wildcard requests.
381
382 2019-02-15  Tom Tromey  <tromey@adacore.com>
383
384         * ravenscar-thread.c (base_ptid): Remove.
385         (struct ravenscar_thread_target) <close>: New method.
386         <m_base_ptid>: New member.
387         <update_inferior_ptid, active_task, task_is_currently_active,
388         runtime_initialized>: Declare methods.
389         <ravenscar_thread_target>: Add constructor.
390         (ravenscar_thread_target::task_is_currently_active)
391         (ravenscar_thread_target::update_inferior_ptid)
392         (ravenscar_runtime_initialized): Rename.  Now methods.
393         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
394         (ravenscar_thread_target::update_thread_list): Update.
395         (ravenscar_thread_target::active_task): Now method.
396         (ravenscar_thread_target::store_registers)
397         (ravenscar_thread_target::prepare_to_store)
398         (ravenscar_thread_target::prepare_to_store)
399         (ravenscar_thread_target::mourn_inferior): Update.
400         (ravenscar_inferior_created): Use "new" to create target.
401         (ravenscar_thread_target::get_ada_task_ptid): Update.
402         (_initialize_ravenscar): Don't initialize base_ptid.
403         (ravenscar_ops): Remove global.
404
405 2019-02-15  Tom Tromey  <tromey@adacore.com>
406
407         * target.h (push_target): Declare new overload.
408         * target.c (push_target): New overload, taking an rvalue reference.
409         * remote.c (remote_target::open_1): Use push_target overload.
410         * corelow.c (core_target_open): Use push_target overload.
411
412 2019-02-15  Tom Tromey  <tromey@adacore.com>
413
414         * ravenscar-thread.c (is_ravenscar_task)
415         (ravenscar_task_is_currently_active): Return bool.
416         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
417         (_initialize_ravenscar): Remove "(void)".
418         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
419         Return bool.
420
421 2019-02-15  Tom Tromey  <tromey@adacore.com>
422
423         * ravenscar-thread.c (ravenscar_runtime_initializer)
424         (has_ravenscar_runtime, get_running_thread_id)
425         (ravenscar_thread_target::resume): Fix indentation.
426
427 2019-02-15  Tom Tromey  <tromey@adacore.com>
428
429         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
430         from ravenscar_arch_ops.
431         (sparc_ravenscar_ops::fetch_registers)
432         (sparc_ravenscar_ops::store_registers): Now methods.
433         (sparc_ravenscar_prepare_to_store): Remove.
434         (sparc_ravenscar_ops): Redefine.
435         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
436         methods and destructor.  Remove members.
437         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
438         (ravenscar_thread_target::store_registers)
439         (ravenscar_thread_target::prepare_to_store): Update.
440         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
441         Remove.
442         (struct ppc_ravenscar_powerpc_ops): Derive from
443         ravenscar_arch_ops.
444         (ppc_ravenscar_powerpc_ops::fetch_registers)
445         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
446         (ppc_ravenscar_powerpc_ops): Redefine.
447         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
448         (ppc_ravenscar_e500_ops::fetch_registers)
449         (ppc_ravenscar_e500_ops::store_registers): Now methods.
450         (ppc_ravenscar_e500_ops): Redefine.
451         * aarch64-ravenscar-thread.c
452         (aarch64_ravenscar_generic_prepare_to_store): Remove.
453         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
454         (aarch64_ravenscar_fetch_registers)
455         (aarch64_ravenscar_store_registers): Now methods.
456         (aarch64_ravenscar_ops): Redefine.
457
458 2019-02-15  Tom Tromey  <tromey@adacore.com>
459
460         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
461         (ravenscar_thread_target::stopped_by_hw_breakpoint)
462         (ravenscar_thread_target::stopped_by_watchpoint)
463         (ravenscar_thread_target::stopped_data_address)
464         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
465
466 2019-02-15  Tom Tromey  <tromey@adacore.com>
467
468         * ravenscar-thread.c: Fix some typos.
469
470 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
471             Tom Tromey  <tromey@adacore.com>
472
473         * ada-lang.c (ada_exception_sal): Change addr_string to a
474         std::string.
475         (create_ada_exception_catchpoint): Update.
476
477 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
478             Tom Tromey  <tromey@adacore.com>
479
480         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
481         (bp_location_ops): Remove.
482         (base_breakpoint_allocate_location): Update.
483         (free_bp_location): Update.
484         * ada-lang.c (class ada_catchpoint_location)
485         <ada_catchpoint_location>: Remove ops parameter.
486         (ada_catchpoint_location_dtor): Remove.
487         (ada_catchpoint_location_ops): Remove.
488         (allocate_location_exception): Update.
489         * breakpoint.h (struct bp_location_ops): Remove.
490         (class bp_location) <bp_location>: Remove bp_location_ops
491         parameter.
492         <~bp_location>: Add destructor.
493         <ops>: Remove.
494
495 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
496             Pedro Alves  <palves@redhat.com>
497
498         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
499         'PATH_MAX'.
500
501 2019-02-14  David Michael  <fedora.dm0@gmail.com>
502             Samuel Thibault  <samuel.thibault@gnu.org>
503             Thomas Schwinge  <thomas@codesourcery.com>
504
505         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
506         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
507
508 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
509
510         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
511         (check_empty): Use "const char *".
512
513         * gnu-nat.c (gnu_nat_target::detach): Instead of
514         'detach_inferior (pid)' call
515         'detach_inferior (find_inferior_pid (pid))'.
516
517         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
518         'nat/fork-inferior.o'.
519         * gnu-nat.c: #include "nat/fork-inferior.h".
520
521         * gnu-nat.c (gnu_nat_target::detach): Instead of
522         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
523         * gnu-nat.h: #include "inf-child.h".
524         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
525         'i386_gnu_nat_target::fetch_registers'.
526         (gnu_store_registers): Rename/move to
527         'i386_gnu_nat_target::store_registers'.
528
529         * config/i386/nm-i386gnu.h: Don't "#include" any files.
530         * gnu-nat.h (mach_thread_info): New function.
531         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
532
533         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
534
535 2019-02-14  Frederic Konrad  <konrad@adacore.com>
536
537         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
538
539 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
540
541         * windows-nat.c (windows_add_thread): Add new parameter
542         "main_thread_p" with default value set to false.  Update
543         function documentation as well as all callers.
544         (windows_delete_thread): Likewise.
545         (fake_create_process): Update call to windows_add_thread.
546         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
547         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
548         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
549         call to windows_delete_thread.
550
551 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
552
553         * MAINTAINERS: Add Andrew Burgess as global maintainer.
554
555 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
556
557         * symfile.c (find_separate_debug_file): Use canonical path of
558         sysroot with child_path instead of gdb_sysroot if it is valid.
559
560 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
561
562         * symfile.c (find_separate_debug_file): Use child_path to
563         determine if an object file is under a sysroot.
564
565 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
566
567         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
568         unittests/child-path-selftests.c.
569         * common/pathstuff.c (child_path): New function.
570         * common/pathstuff.h (child_path): New prototype.
571         * unittests/child-path-selftests.c: New file.
572
573 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
574
575         * symfile.c (find_separate_debug_file): Look for separate debug
576         files in debug directories under the sysroot.
577
578 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
579
580         * symtab.h (struct minimal_symbol data_p): New const method.
581         (struct minimal_symbol text_p): Likewise.
582         * symtab.c (output_source_filename): Use file name style
583         to print file name.
584         (print_symbol_info): Likewise.
585         (print_msymbol_info): Use address style to print addresses.
586         Use function name style to print executable text symbols.
587         (expand_symtab_containing_pc): Use data_p.
588         (find_pc_sect_compunit_symtab): Likewise.
589
590 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
591
592         * breakpoint.c (describe_other_breakpoints): Use address style
593         to print addresses.
594         (say_where): Likewise.
595
596 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
597
598         * ada-typeprint.c (print_func_type): Print function name
599         style to print function name.
600         * c-typeprint.c (c_print_type_1): Likewise.
601
602 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
603
604         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
605         for execve.
606
607 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
608
609         * c-exp.y (direct_abs_decl): Use emplace_back to record the
610         type_stack.
611
612 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
613
614         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
615         TYPE_CODE_REF types.
616
617 2019-02-08  Jim Wilson  <jimw@sifive.com>
618
619         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
620         (riscv_linux_fregset): New.
621         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
622
623 2019-02-07  Tom Tromey  <tom@tromey.com>
624
625         * thread.c (thread_cancel_execution_command): Update.
626         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
627         methods.
628         (struct thread_fsm_ops): Remove.
629         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
630         (thread_fsm_should_stop, thread_fsm_return_value)
631         (thread_fsm_set_finished, thread_fsm_finished_p)
632         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
633         Don't declare.
634         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
635         * infrun.c (clear_proceed_status_thread)
636         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
637         (print_stop_event): Update.
638         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
639         Add constructor.
640         (step_command_fsm_ops): Remove.
641         (new_step_command_fsm): Remove.
642         (step_1): Update.
643         (step_command_fsm::should_stop): Rename from
644         step_command_fsm_should_stop.
645         (step_command_fsm::clean_up): Rename from
646         step_command_fsm_clean_up.
647         (step_command_fsm::do_async_reply_reason): Rename from
648         step_command_fsm_async_reply_reason.
649         (struct until_next_fsm): Inherit from thread_fsm.  Add
650         constructor.
651         (until_next_fsm_ops): Remove.
652         (new_until_next_fsm): Remove.
653         (until_next_fsm::should_stop): Rename from
654         until_next_fsm_should_stop.
655         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
656         (until_next_fsm::do_async_reply_reason): Rename from
657         until_next_fsm_async_reply_reason.
658         (struct finish_command_fsm): Inherit from thread_fsm.  Add
659         constructor.  Change type of breakpoint.
660         (finish_command_fsm_ops): Remove.
661         (new_finish_command_fsm): Remove.
662         (finish_command_fsm::should_stop): Rename from
663         finish_command_fsm_should_stop.
664         (finish_command_fsm::clean_up): Rename from
665         finish_command_fsm_clean_up.
666         (finish_command_fsm::return_value): Rename from
667         finish_command_fsm_return_value.
668         (finish_command_fsm::do_async_reply_reason): Rename from
669         finish_command_fsm_async_reply_reason.
670         (finish_command): Update.
671         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
672         Add constructor.
673         (call_thread_fsm_ops): Remove.
674         (call_thread_fsm::call_thread_fsm): Rename from
675         new_call_thread_fsm.
676         (call_thread_fsm::should_stop): Rename from
677         call_thread_fsm_should_stop.
678         (call_thread_fsm::should_notify_stop): Rename from
679         call_thread_fsm_should_notify_stop.
680         (run_inferior_call, call_function_by_hand_dummy): Update.
681         * cli/cli-interp.c (should_print_stop_to_console): Update.
682         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
683         Add constructor.  Change type of location_breakpoint,
684         caller_breakpoint.
685         (until_break_fsm_ops): Remove.
686         (new_until_break_fsm): Remove.
687         (until_break_fsm::should_stop): Rename from
688         until_break_fsm_should_stop.
689         (until_break_fsm::clean_up): Rename from
690         until_break_fsm_clean_up.
691         (until_break_fsm::do_async_reply_reason): Rename from
692         until_break_fsm_async_reply_reason.
693         (until_break_command): Update.
694         * thread-fsm.c: Remove.
695         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
696
697 2019-02-07  Tom Tromey  <tom@tromey.com>
698
699         * yy-remap.h: Add include guard.
700         * xtensa-tdep.h: Add include guard.
701         * xcoffread.h: Rename include guard.
702         * varobj-iter.h: Add include guard.
703         * tui/tui.h: Rename include guard.
704         * tui/tui-winsource.h: Rename include guard.
705         * tui/tui-wingeneral.h: Rename include guard.
706         * tui/tui-windata.h: Rename include guard.
707         * tui/tui-win.h: Rename include guard.
708         * tui/tui-stack.h: Rename include guard.
709         * tui/tui-source.h: Rename include guard.
710         * tui/tui-regs.h: Rename include guard.
711         * tui/tui-out.h: Rename include guard.
712         * tui/tui-layout.h: Rename include guard.
713         * tui/tui-io.h: Rename include guard.
714         * tui/tui-hooks.h: Rename include guard.
715         * tui/tui-file.h: Rename include guard.
716         * tui/tui-disasm.h: Rename include guard.
717         * tui/tui-data.h: Rename include guard.
718         * tui/tui-command.h: Rename include guard.
719         * tic6x-tdep.h: Add include guard.
720         * target/waitstatus.h: Rename include guard.
721         * target/wait.h: Rename include guard.
722         * target/target.h: Rename include guard.
723         * target/resume.h: Rename include guard.
724         * target-float.h: Rename include guard.
725         * stabsread.h: Add include guard.
726         * rs6000-tdep.h: Add include guard.
727         * riscv-fbsd-tdep.h: Add include guard.
728         * regformats/regdef.h: Rename include guard.
729         * record.h: Rename include guard.
730         * python/python.h: Rename include guard.
731         * python/python-internal.h: Rename include guard.
732         * python/py-stopevent.h: Rename include guard.
733         * python/py-ref.h: Rename include guard.
734         * python/py-record.h: Rename include guard.
735         * python/py-record-full.h: Rename include guard.
736         * python/py-record-btrace.h: Rename include guard.
737         * python/py-instruction.h: Rename include guard.
738         * python/py-events.h: Rename include guard.
739         * python/py-event.h: Rename include guard.
740         * procfs.h: Add include guard.
741         * proc-utils.h: Add include guard.
742         * p-lang.h: Add include guard.
743         * or1k-tdep.h: Rename include guard.
744         * observable.h: Rename include guard.
745         * nto-tdep.h: Rename include guard.
746         * nat/x86-linux.h: Rename include guard.
747         * nat/x86-linux-dregs.h: Rename include guard.
748         * nat/x86-gcc-cpuid.h: Add include guard.
749         * nat/x86-dregs.h: Rename include guard.
750         * nat/x86-cpuid.h: Rename include guard.
751         * nat/ppc-linux.h: Rename include guard.
752         * nat/mips-linux-watch.h: Rename include guard.
753         * nat/linux-waitpid.h: Rename include guard.
754         * nat/linux-ptrace.h: Rename include guard.
755         * nat/linux-procfs.h: Rename include guard.
756         * nat/linux-osdata.h: Rename include guard.
757         * nat/linux-nat.h: Rename include guard.
758         * nat/linux-namespaces.h: Rename include guard.
759         * nat/linux-btrace.h: Rename include guard.
760         * nat/glibc_thread_db.h: Rename include guard.
761         * nat/gdb_thread_db.h: Rename include guard.
762         * nat/gdb_ptrace.h: Rename include guard.
763         * nat/fork-inferior.h: Rename include guard.
764         * nat/amd64-linux-siginfo.h: Rename include guard.
765         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
766         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
767         * nat/aarch64-linux.h: Rename include guard.
768         * nat/aarch64-linux-hw-point.h: Rename include guard.
769         * mn10300-tdep.h: Add include guard.
770         * mips-linux-tdep.h: Add include guard.
771         * mi/mi-parse.h: Rename include guard.
772         * mi/mi-out.h: Rename include guard.
773         * mi/mi-main.h: Rename include guard.
774         * mi/mi-interp.h: Rename include guard.
775         * mi/mi-getopt.h: Rename include guard.
776         * mi/mi-console.h: Rename include guard.
777         * mi/mi-common.h: Rename include guard.
778         * mi/mi-cmds.h: Rename include guard.
779         * mi/mi-cmd-break.h: Rename include guard.
780         * m2-lang.h: Add include guard.
781         * location.h: Rename include guard.
782         * linux-record.h: Rename include guard.
783         * linux-nat.h: Add include guard.
784         * linux-fork.h: Add include guard.
785         * i386-darwin-tdep.h: Rename include guard.
786         * hppa-linux-offsets.h: Add include guard.
787         * guile/guile.h: Rename include guard.
788         * guile/guile-internal.h: Rename include guard.
789         * gnu-nat.h: Rename include guard.
790         * gdb-stabs.h: Rename include guard.
791         * frv-tdep.h: Add include guard.
792         * f-lang.h: Add include guard.
793         * event-loop.h: Add include guard.
794         * darwin-nat.h: Rename include guard.
795         * cp-abi.h: Rename include guard.
796         * config/sparc/nm-sol2.h: Rename include guard.
797         * config/nm-nto.h: Rename include guard.
798         * config/nm-linux.h: Add include guard.
799         * config/i386/nm-i386gnu.h: Rename include guard.
800         * config/djgpp/nl_types.h: Rename include guard.
801         * config/djgpp/langinfo.h: Rename include guard.
802         * compile/gcc-cp-plugin.h: Add include guard.
803         * compile/gcc-c-plugin.h: Add include guard.
804         * compile/compile.h: Rename include guard.
805         * compile/compile-object-run.h: Rename include guard.
806         * compile/compile-object-load.h: Rename include guard.
807         * compile/compile-internal.h: Rename include guard.
808         * compile/compile-cplus.h: Rename include guard.
809         * compile/compile-c.h: Rename include guard.
810         * common/xml-utils.h: Rename include guard.
811         * common/x86-xstate.h: Rename include guard.
812         * common/version.h: Rename include guard.
813         * common/vec.h: Rename include guard.
814         * common/tdesc.h: Rename include guard.
815         * common/selftest.h: Rename include guard.
816         * common/scoped_restore.h: Rename include guard.
817         * common/scoped_mmap.h: Rename include guard.
818         * common/scoped_fd.h: Rename include guard.
819         * common/safe-iterator.h: Rename include guard.
820         * common/run-time-clock.h: Rename include guard.
821         * common/refcounted-object.h: Rename include guard.
822         * common/queue.h: Rename include guard.
823         * common/ptid.h: Rename include guard.
824         * common/print-utils.h: Rename include guard.
825         * common/preprocessor.h: Rename include guard.
826         * common/pathstuff.h: Rename include guard.
827         * common/observable.h: Rename include guard.
828         * common/netstuff.h: Rename include guard.
829         * common/job-control.h: Rename include guard.
830         * common/host-defs.h: Rename include guard.
831         * common/gdb_wait.h: Rename include guard.
832         * common/gdb_vecs.h: Rename include guard.
833         * common/gdb_unlinker.h: Rename include guard.
834         * common/gdb_unique_ptr.h: Rename include guard.
835         * common/gdb_tilde_expand.h: Rename include guard.
836         * common/gdb_sys_time.h: Rename include guard.
837         * common/gdb_string_view.h: Rename include guard.
838         * common/gdb_splay_tree.h: Rename include guard.
839         * common/gdb_setjmp.h: Rename include guard.
840         * common/gdb_ref_ptr.h: Rename include guard.
841         * common/gdb_optional.h: Rename include guard.
842         * common/gdb_locale.h: Rename include guard.
843         * common/gdb_assert.h: Rename include guard.
844         * common/filtered-iterator.h: Rename include guard.
845         * common/filestuff.h: Rename include guard.
846         * common/fileio.h: Rename include guard.
847         * common/environ.h: Rename include guard.
848         * common/common-utils.h: Rename include guard.
849         * common/common-types.h: Rename include guard.
850         * common/common-regcache.h: Rename include guard.
851         * common/common-inferior.h: Rename include guard.
852         * common/common-gdbthread.h: Rename include guard.
853         * common/common-exceptions.h: Rename include guard.
854         * common/common-defs.h: Rename include guard.
855         * common/common-debug.h: Rename include guard.
856         * common/cleanups.h: Rename include guard.
857         * common/buffer.h: Rename include guard.
858         * common/btrace-common.h: Rename include guard.
859         * common/break-common.h: Rename include guard.
860         * cli/cli-utils.h: Rename include guard.
861         * cli/cli-style.h: Rename include guard.
862         * cli/cli-setshow.h: Rename include guard.
863         * cli/cli-script.h: Rename include guard.
864         * cli/cli-interp.h: Rename include guard.
865         * cli/cli-decode.h: Rename include guard.
866         * cli/cli-cmds.h: Rename include guard.
867         * charset-list.h: Add include guard.
868         * buildsym-legacy.h: Rename include guard.
869         * bfin-tdep.h: Add include guard.
870         * ax.h: Rename include guard.
871         * arm-linux-tdep.h: Add include guard.
872         * arm-fbsd-tdep.h: Add include guard.
873         * arch/xtensa.h: Rename include guard.
874         * arch/tic6x.h: Add include guard.
875         * arch/i386.h: Add include guard.
876         * arch/arm.h: Rename include guard.
877         * arch/arm-linux.h: Rename include guard.
878         * arch/arm-get-next-pcs.h: Rename include guard.
879         * arch/amd64.h: Add include guard.
880         * arch/aarch64-insn.h: Rename include guard.
881         * arch-utils.h: Rename include guard.
882         * annotate.h: Add include guard.
883         * amd64-darwin-tdep.h: Rename include guard.
884         * aarch64-linux-tdep.h: Add include guard.
885         * aarch64-fbsd-tdep.h: Add include guard.
886         * aarch32-linux-nat.h: Add include guard.
887
888 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
889
890         * macrotab.c (macro_define_internal): New function that
891         factorizes macro_define_object_internal and macro_define_function
892         code.
893         (macro_define_object_internal): Use macro_define_internal.
894         (macro_define_function): Likewise.
895
896 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
897
898         * macrocmd.c (extract_identifier): Return
899         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
900         callers.
901
902 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
903
904         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
905
906 2019-02-05  Tom Tromey  <tom@tromey.com>
907
908         * target.c (target_stack::unpush): Move assertion earlier.
909
910 2019-01-30  Tom Tromey  <tom@tromey.com>
911
912         PR python/23615:
913         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
914         (gdbpy_parse_and_eval): Likewise.
915         * python/python-internal.h (gdbpy_allow_threads): New class.
916
917 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
918
919         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
920         (aarch64_fbsd_fpregmap): Move earlier.
921         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
922         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
923         instead of individual calls to trad_frame_set_reg_addr.
924         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
925         earlier.
926         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
927         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
928         instead of individual calls to trad_frame_set_reg_addr.
929
930 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
931
932         * CONTRIBUTE: Replace contribution list with wiki link.
933
934 2019-01-25  Tom Tromey  <tom@tromey.com>
935
936         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
937
938 2019-01-25  Tom Tromey  <tom@tromey.com>
939
940         * xtensa-linux-nat.c: Fix common/ includes.
941         * xml-support.h: Fix common/ includes.
942         * xml-support.c: Fix common/ includes.
943         * x86-linux-nat.c: Fix common/ includes.
944         * windows-nat.c: Fix common/ includes.
945         * varobj.h: Fix common/ includes.
946         * varobj.c: Fix common/ includes.
947         * value.c: Fix common/ includes.
948         * valops.c: Fix common/ includes.
949         * utils.c: Fix common/ includes.
950         * unittests/xml-utils-selftests.c: Fix common/ includes.
951         * unittests/utils-selftests.c: Fix common/ includes.
952         * unittests/unpack-selftests.c: Fix common/ includes.
953         * unittests/tracepoint-selftests.c: Fix common/ includes.
954         * unittests/style-selftests.c: Fix common/ includes.
955         * unittests/string_view-selftests.c: Fix common/ includes.
956         * unittests/scoped_restore-selftests.c: Fix common/ includes.
957         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
958         * unittests/scoped_fd-selftests.c: Fix common/ includes.
959         * unittests/rsp-low-selftests.c: Fix common/ includes.
960         * unittests/parse-connection-spec-selftests.c: Fix common/
961         includes.
962         * unittests/optional-selftests.c: Fix common/ includes.
963         * unittests/offset-type-selftests.c: Fix common/ includes.
964         * unittests/observable-selftests.c: Fix common/ includes.
965         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
966         * unittests/memrange-selftests.c: Fix common/ includes.
967         * unittests/memory-map-selftests.c: Fix common/ includes.
968         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
969         * unittests/function-view-selftests.c: Fix common/ includes.
970         * unittests/environ-selftests.c: Fix common/ includes.
971         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
972         * unittests/common-utils-selftests.c: Fix common/ includes.
973         * unittests/cli-utils-selftests.c: Fix common/ includes.
974         * unittests/array-view-selftests.c: Fix common/ includes.
975         * ui-file.c: Fix common/ includes.
976         * tui/tui-io.c: Fix common/ includes.
977         * tracepoint.h: Fix common/ includes.
978         * tracepoint.c: Fix common/ includes.
979         * tracefile-tfile.c: Fix common/ includes.
980         * top.h: Fix common/ includes.
981         * top.c: Fix common/ includes.
982         * thread.c: Fix common/ includes.
983         * target/waitstatus.h: Fix common/ includes.
984         * target/waitstatus.c: Fix common/ includes.
985         * target.h: Fix common/ includes.
986         * target.c: Fix common/ includes.
987         * target-memory.c: Fix common/ includes.
988         * target-descriptions.c: Fix common/ includes.
989         * symtab.h: Fix common/ includes.
990         * symfile.c: Fix common/ includes.
991         * stap-probe.c: Fix common/ includes.
992         * spu-linux-nat.c: Fix common/ includes.
993         * sparc-nat.c: Fix common/ includes.
994         * source.c: Fix common/ includes.
995         * solib.c: Fix common/ includes.
996         * solib-target.c: Fix common/ includes.
997         * ser-unix.c: Fix common/ includes.
998         * ser-tcp.c: Fix common/ includes.
999         * ser-pipe.c: Fix common/ includes.
1000         * ser-base.c: Fix common/ includes.
1001         * selftest-arch.c: Fix common/ includes.
1002         * s12z-tdep.c: Fix common/ includes.
1003         * rust-exp.y: Fix common/ includes.
1004         * rs6000-aix-tdep.c: Fix common/ includes.
1005         * riscv-tdep.c: Fix common/ includes.
1006         * remote.c: Fix common/ includes.
1007         * remote-notif.h: Fix common/ includes.
1008         * remote-fileio.h: Fix common/ includes.
1009         * remote-fileio.c: Fix common/ includes.
1010         * regcache.h: Fix common/ includes.
1011         * regcache.c: Fix common/ includes.
1012         * record-btrace.c: Fix common/ includes.
1013         * python/python.c: Fix common/ includes.
1014         * python/py-type.c: Fix common/ includes.
1015         * python/py-inferior.c: Fix common/ includes.
1016         * progspace.h: Fix common/ includes.
1017         * producer.c: Fix common/ includes.
1018         * procfs.c: Fix common/ includes.
1019         * proc-api.c: Fix common/ includes.
1020         * printcmd.c: Fix common/ includes.
1021         * ppc-linux-nat.c: Fix common/ includes.
1022         * parser-defs.h: Fix common/ includes.
1023         * osdata.c: Fix common/ includes.
1024         * obsd-nat.c: Fix common/ includes.
1025         * nat/x86-linux.c: Fix common/ includes.
1026         * nat/x86-linux-dregs.c: Fix common/ includes.
1027         * nat/x86-dregs.h: Fix common/ includes.
1028         * nat/x86-dregs.c: Fix common/ includes.
1029         * nat/ppc-linux.c: Fix common/ includes.
1030         * nat/mips-linux-watch.h: Fix common/ includes.
1031         * nat/mips-linux-watch.c: Fix common/ includes.
1032         * nat/linux-waitpid.c: Fix common/ includes.
1033         * nat/linux-ptrace.h: Fix common/ includes.
1034         * nat/linux-ptrace.c: Fix common/ includes.
1035         * nat/linux-procfs.c: Fix common/ includes.
1036         * nat/linux-personality.c: Fix common/ includes.
1037         * nat/linux-osdata.c: Fix common/ includes.
1038         * nat/linux-namespaces.c: Fix common/ includes.
1039         * nat/linux-btrace.h: Fix common/ includes.
1040         * nat/linux-btrace.c: Fix common/ includes.
1041         * nat/fork-inferior.c: Fix common/ includes.
1042         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1043         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1044         * nat/aarch64-linux.c: Fix common/ includes.
1045         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1046         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1047         * namespace.h: Fix common/ includes.
1048         * mips-linux-tdep.c: Fix common/ includes.
1049         * minsyms.c: Fix common/ includes.
1050         * mi/mi-parse.h: Fix common/ includes.
1051         * mi/mi-main.c: Fix common/ includes.
1052         * mi/mi-cmd-env.c: Fix common/ includes.
1053         * memrange.h: Fix common/ includes.
1054         * memattr.c: Fix common/ includes.
1055         * maint.h: Fix common/ includes.
1056         * maint.c: Fix common/ includes.
1057         * main.c: Fix common/ includes.
1058         * machoread.c: Fix common/ includes.
1059         * location.c: Fix common/ includes.
1060         * linux-thread-db.c: Fix common/ includes.
1061         * linux-nat.c: Fix common/ includes.
1062         * linux-fork.c: Fix common/ includes.
1063         * inline-frame.c: Fix common/ includes.
1064         * infrun.c: Fix common/ includes.
1065         * inflow.c: Fix common/ includes.
1066         * inferior.h: Fix common/ includes.
1067         * inferior.c: Fix common/ includes.
1068         * infcmd.c: Fix common/ includes.
1069         * inf-ptrace.c: Fix common/ includes.
1070         * inf-child.c: Fix common/ includes.
1071         * ia64-linux-nat.c: Fix common/ includes.
1072         * i387-tdep.c: Fix common/ includes.
1073         * i386-tdep.c: Fix common/ includes.
1074         * i386-linux-tdep.c: Fix common/ includes.
1075         * i386-linux-nat.c: Fix common/ includes.
1076         * i386-go32-tdep.c: Fix common/ includes.
1077         * i386-fbsd-tdep.c: Fix common/ includes.
1078         * i386-fbsd-nat.c: Fix common/ includes.
1079         * guile/scm-type.c: Fix common/ includes.
1080         * guile/guile.c: Fix common/ includes.
1081         * go32-nat.c: Fix common/ includes.
1082         * gnu-nat.c: Fix common/ includes.
1083         * gdbthread.h: Fix common/ includes.
1084         * gdbarch-selftests.c: Fix common/ includes.
1085         * gdb_usleep.c: Fix common/ includes.
1086         * gdb_select.h: Fix common/ includes.
1087         * gdb_bfd.c: Fix common/ includes.
1088         * gcore.c: Fix common/ includes.
1089         * fork-child.c: Fix common/ includes.
1090         * findvar.c: Fix common/ includes.
1091         * fbsd-nat.c: Fix common/ includes.
1092         * event-top.c: Fix common/ includes.
1093         * event-loop.c: Fix common/ includes.
1094         * dwarf2read.c: Fix common/ includes.
1095         * dwarf2loc.c: Fix common/ includes.
1096         * dwarf2-frame.c: Fix common/ includes.
1097         * dwarf-index-cache.c: Fix common/ includes.
1098         * dtrace-probe.c: Fix common/ includes.
1099         * disasm-selftests.c: Fix common/ includes.
1100         * defs.h: Fix common/ includes.
1101         * csky-tdep.c: Fix common/ includes.
1102         * cp-valprint.c: Fix common/ includes.
1103         * cp-support.h: Fix common/ includes.
1104         * cp-support.c: Fix common/ includes.
1105         * corelow.c: Fix common/ includes.
1106         * completer.h: Fix common/ includes.
1107         * completer.c: Fix common/ includes.
1108         * compile/compile.c: Fix common/ includes.
1109         * compile/compile-loc2c.c: Fix common/ includes.
1110         * compile/compile-cplus-types.c: Fix common/ includes.
1111         * compile/compile-cplus-symbols.c: Fix common/ includes.
1112         * command.h: Fix common/ includes.
1113         * cli/cli-dump.c: Fix common/ includes.
1114         * cli/cli-cmds.c: Fix common/ includes.
1115         * charset.c: Fix common/ includes.
1116         * build-id.c: Fix common/ includes.
1117         * btrace.h: Fix common/ includes.
1118         * btrace.c: Fix common/ includes.
1119         * breakpoint.h: Fix common/ includes.
1120         * breakpoint.c: Fix common/ includes.
1121         * ax.h: 
1122         (enum agent_op): Fix common/ includes.
1123         * ax-general.c (struct aop_map): Fix common/ includes.
1124         * ax-gdb.c: Fix common/ includes.
1125         * auxv.c: Fix common/ includes.
1126         * auto-load.c: Fix common/ includes.
1127         * arm-tdep.c: Fix common/ includes.
1128         * arch/riscv.c: Fix common/ includes.
1129         * arch/ppc-linux-common.c: Fix common/ includes.
1130         * arch/i386.c: Fix common/ includes.
1131         * arch/arm.c: Fix common/ includes.
1132         * arch/arm-linux.c: Fix common/ includes.
1133         * arch/arm-get-next-pcs.c: Fix common/ includes.
1134         * arch/amd64.c: Fix common/ includes.
1135         * arch/aarch64.c: Fix common/ includes.
1136         * arch/aarch64-insn.c: Fix common/ includes.
1137         * arch-utils.c: Fix common/ includes.
1138         * amd64-windows-tdep.c: Fix common/ includes.
1139         * amd64-tdep.c: Fix common/ includes.
1140         * amd64-sol2-tdep.c: Fix common/ includes.
1141         * amd64-obsd-tdep.c: Fix common/ includes.
1142         * amd64-nbsd-tdep.c: Fix common/ includes.
1143         * amd64-linux-tdep.c: Fix common/ includes.
1144         * amd64-linux-nat.c: Fix common/ includes.
1145         * amd64-fbsd-tdep.c: Fix common/ includes.
1146         * amd64-fbsd-nat.c: Fix common/ includes.
1147         * amd64-dicos-tdep.c: Fix common/ includes.
1148         * amd64-darwin-tdep.c: Fix common/ includes.
1149         * agent.c: Fix common/ includes.
1150         * ada-lang.h: Fix common/ includes.
1151         * ada-lang.c: Fix common/ includes.
1152         * aarch64-tdep.c: Fix common/ includes.
1153
1154 2019-01-25  Tom Tromey  <tom@tromey.com>
1155
1156         * common/create-version.sh: Use common/version.h.
1157
1158 2019-01-24  Pedro Alves  <palves@redhat.com>
1159
1160         * infrun.c (signal_stop, signal_print, signal_program)
1161         (signal_catch, signal_pass): Now arrays instead of pointers.
1162         (update_signals_program_target, do_target_resume)
1163         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1164         * linux-nat.c (linux_nat_target::pass_signals)
1165         (linux_nat_target::create_inferior, linux_nat_target::attach):
1166         Adjust.
1167         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1168         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1169         * procfs.c (procfs_target::pass_signals): Adjust.
1170         * record-full.c (record_full_target::resume): Adjust.
1171         * remote.c (remote_target::pass_signals)
1172         (remote_target::program_signals): Adjust.
1173         * target-debug.h (target_debug_print_signals): Now takes a
1174         gdb::array_view as parameter.  Adjust.
1175         * target.h (target_ops) <pass_signals, program_signals>: Replace
1176         pointer and length parameters with gdb::array_view.
1177         (target_pass_signals, target_program_signals): Likewise.
1178         * target-delegates.c: Regenerate.
1179
1180 2019-01-24  Pedro Alves  <palves@redhat.com>
1181
1182         * common/forward-scope-exit.h
1183         (forward_scope_exit::forward_scope_exit): Pass arguments to
1184         m_bind_function directly, instead of creating a std::bind and
1185         copying that.
1186
1187 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1188
1189         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1190         for static members.
1191         (pass_in_v_vfp_candidate): Likewise.
1192
1193 2019-01-23  Tom Tromey  <tom@tromey.com>
1194             Pedro Alves  <palves@redhat.com>
1195
1196         * regcache.c (class regcache_invalidator): Remove.
1197         (regcache::raw_write): Use make_scope_exit.
1198
1199 2019-01-23  Tom Tromey  <tom@tromey.com>
1200
1201         * ui-out.h (class ui_out_emit_type): Update comment.
1202
1203 2019-01-23  Tom Tromey  <tom@tromey.com>
1204
1205         * infrun.c (fetch_inferior_event): Update comment.
1206
1207 2019-01-23  Tom Tromey  <tom@tromey.com>
1208             Pedro Alves  <palves@redhat.com>
1209
1210         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1211         parameter.
1212         (fetch_inferior_event): Use SCOPE_EXIT.
1213
1214
1215 2019-01-23  Tom Tromey  <tom@tromey.com>
1216             Pedro Alves  <palves@redhat.com>
1217
1218         * infrun.c (disable_thread_events): Delete.
1219         (stop_all_threads): Use SCOPE_EXIT.
1220
1221 2019-01-23  Tom Tromey  <tom@tromey.com>
1222             Pedro Alves  <palves@redhat.com>
1223
1224         * symfile.c: Include forward-scope-exit.h.
1225         (clear_symtab_users_cleanup): Replace forward declaration with
1226         a FORWARD_SCOPE_EXIT.
1227         (syms_from_objfile_1): Use the forward_scope_exit and
1228         gdb::optional instead of cleanup_function.
1229         (reread_symbols): Use the forward_scope_exit instead of
1230         cleanup_function.
1231         (clear_symtab_users_cleanup): Remove function.
1232
1233 2019-01-23  Tom Tromey  <tom@tromey.com>
1234             Pedro Alves  <palves@redhat.com>
1235
1236         * linux-nat.c: Include scope-exit.h.
1237         (cleanup_target_stop): Remove.
1238         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1239         SCOPE_EXIT.
1240
1241 2019-01-23  Tom Tromey  <tom@tromey.com>
1242             Pedro Alves  <palves@redhat.com>
1243
1244         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1245         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1246
1247 2019-01-23  Tom Tromey  <tom@tromey.com>
1248             Andrew Burgess  <andrew.burgess@embecosm.com>
1249             Pedro Alves  <palves@redhat.com>
1250
1251         * infrun.c (fetch_inferior_event): Use scope_exit.
1252         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1253         * top.c (execute_command): Use scope_exit.
1254         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1255         * utils.c (do_bpstat_clear_actions_cleanup)
1256         (make_bpstat_clear_actions_cleanup): Remove.
1257
1258 2019-01-23  Tom Tromey  <tom@tromey.com>
1259             Pedro Alves  <palves@redhat.com>
1260
1261         * infrun.c: Include "common/scope-exit.h"
1262         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1263         (wait_for_inferior): Use SCOPE_EXIT.
1264         (fetch_inferior_event): Use scope_exit.
1265
1266 2019-01-23  Tom Tromey  <tom@tromey.com>
1267             Pedro Alves  <palves@redhat.com>
1268
1269         * breakpoint.c (create_breakpoint): Remove cleanup.
1270
1271 2019-01-23  Tom Tromey  <tom@tromey.com>
1272             Andrew Burgess  <andrew.burgess@embecosm.com>
1273             Pedro Alves  <palves@redhat.com>
1274
1275 2019-01-23  Pedro Alves  <palves@redhat.com>
1276
1277         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1278
1279 2019-01-23  Pedro Alves  <palves@redhat.com>
1280             Andrew Burgess  <andrew.burgess@embecosm.com>
1281
1282         * gdbthread.h: Include "common/forward-scope-exit.h".
1283         (scoped_finish_thread_state): Redefine custom class in terms of
1284         forward_scope_exit.
1285
1286 2019-01-23  Pedro Alves  <palves@redhat.com>
1287             Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * common/forward-scope-exit.h: New file.
1290
1291 2019-01-23  Pedro Alves  <palves@redhat.com>
1292             Andrew Burgess  <andrew.burgess@embecosm.com>
1293             Tom Tromey  <tom@tromey.com>
1294
1295         * common/scope-exit.h: New file.
1296
1297 2019-01-23  Pedro Alves  <palves@redhat.com>
1298
1299         * common/preprocessor.h (ESC): Rename to ...
1300         (ESC_PARENS): ... this.
1301         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1302         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1303
1304 2019-01-23  Tom Tromey  <tom@tromey.com>
1305
1306         * language.h (class scoped_switch_to_sym_language_if_auto):
1307         Initialize m_lang in both cases.
1308
1309 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1310
1311         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1312         with XCNEW.
1313
1314 2019-01-22  Tom Tromey  <tom@tromey.com>
1315
1316         * corelow.c: Do not include sys/file.h.
1317
1318 2019-01-22  Tom Tromey  <tom@tromey.com>
1319
1320         * tui/tui-wingeneral.h: Include gdb_curses.h.
1321
1322 2019-01-22  Tom Tromey  <tom@tromey.com>
1323
1324         * source-cache.h (class source_cache) <get_source_lines,
1325         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1326
1327 2019-01-22  Tom Tromey  <tom@tromey.com>
1328
1329         * remote-fileio.h (struct remote_target): Declare.
1330
1331 2019-01-22  Tom Tromey  <tom@tromey.com>
1332
1333         * python/py-arch.c: Do not include py-ref.h.
1334         * python/py-bpevent.c: Do not include py-ref.h.
1335         * python/py-cmd.c: Do not include py-ref.h.
1336         * python/py-continueevent.c: Do not include py-ref.h.
1337         * python/py-event.h: Do not include py-ref.h.
1338         * python/py-evtregistry.c: Do not include py-ref.h.
1339         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1340         * python/py-frame.c: Do not include py-ref.h.
1341         * python/py-framefilter.c: Do not include py-ref.h.
1342         * python/py-function.c: Do not include py-ref.h.
1343         * python/py-infevents.c: Do not include py-ref.h.
1344         * python/py-linetable.c: Do not include py-ref.h.
1345         * python/py-objfile.c: Do not include py-ref.h.
1346         * python/py-param.c: Do not include py-ref.h.
1347         * python/py-prettyprint.c: Do not include py-ref.h.
1348         * python/py-progspace.c: Do not include py-ref.h.
1349         * python/py-symbol.c: Do not include py-ref.h.
1350         * python/py-symtab.c: Do not include py-ref.h.
1351         * python/py-type.c: Do not include py-ref.h.
1352         * python/py-unwind.c: Do not include py-ref.h.
1353         * python/py-utils.c: Do not include py-ref.h.
1354         * python/py-value.c: Do not include py-ref.h.
1355         * python/py-varobj.c: Do not include py-ref.h.
1356         * python/py-xmethods.c: Do not include py-ref.h.
1357         * python/python.c: Do not include py-ref.h.
1358         * varobj.c: Do not include py-ref.h.
1359
1360 2019-01-22  Tom Tromey  <tom@tromey.com>
1361
1362         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1363         keyword for bcache.
1364
1365 2019-01-22  Tom Tromey  <tom@tromey.com>
1366
1367         * compile/compile-cplus-types.c: Remove a comment by #include.
1368
1369 2019-01-22  Tom Tromey  <tom@tromey.com>
1370
1371         * compile/gcc-c-plugin.h: Include compile-internal.h.
1372
1373 2019-01-22  Tom Tromey  <tom@tromey.com>
1374
1375         * stabsread.c (EXTERN): Do not define.
1376         (symnum, next_symbol_text_func, processing_gcc_compilation)
1377         (within_function, global_sym_chain, global_stabs)
1378         (previous_stab_code, this_object_header_files)
1379         (n_this_object_header_files)
1380         (n_allocated_this_object_header_files): Define.
1381         * stabsread.h (EXTERN): Never define.  Use "extern".
1382
1383 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1384
1385         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1386         history_value.
1387
1388 2019-01-21  Tom Tromey  <tom@tromey.com>
1389
1390         * ui-out.c: Fix includes.
1391         * tui/tui-source.c: Fix includes.
1392         * target.c: Fix includes.
1393         * remote.c: Fix includes.
1394         * regcache.c: Fix includes.
1395         * python/py-block.c: Fix includes.
1396         * printcmd.c: Fix includes.
1397         * or1k-tdep.c: Fix includes.
1398         * mi/mi-main.c: Fix includes.
1399         * m32r-tdep.c: Fix includes.
1400         * csky-tdep.c: Fix includes.
1401         * compile/compile-cplus-types.c: Fix includes.
1402         * cli/cli-interp.c: Fix includes.
1403
1404 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1405
1406         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1407         for padding.
1408
1409 2019-01-16  Tom Tromey  <tom@tromey.com>
1410
1411         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1412         earlier.
1413         (struct objfile) <msymbols_range>: Move from top level.
1414         <msymbols>: New method.
1415         (class objfile_msymbols): Remove.
1416         * symtab.c (default_collect_symbol_completion_matches_break_on):
1417         Update.
1418         * symmisc.c (dump_msymbols): Update.
1419         * stabsread.c (scan_file_globals): Update.
1420         * objc-lang.c (info_selectors_command, info_classes_command)
1421         (find_methods): Update.
1422         * minsyms.c (find_solib_trampoline_target): Update.
1423         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1424         * coffread.c (coff_symfile_read): Update.
1425         * ada-lang.c (ada_lookup_simple_minsym)
1426         (ada_collect_symbol_completion_matches): Update.
1427
1428 2019-01-16  Tom Tromey  <tom@tromey.com>
1429
1430         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1431         type.  Remove no-argument constructor.
1432         <iterator::operator++>: Simplify.
1433         <begin>: Update.
1434         <end>: Use minimal_symbol_count.
1435
1436 2019-01-16  Tom Tromey  <tom@tromey.com>
1437
1438         * objfiles.h (struct objfile) <psymtabs>: New method.
1439         (class objfile_psymtabs): Remove.
1440         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1441         typedef.
1442         <range>: New method.
1443         (require_partial_symbols): Change return type.
1444         * psymtab.c (require_partial_symbols)
1445         (psym_expand_symtabs_matching): Update.
1446         * mdebugread.c (parse_partial_symbols): Update.
1447         * dbxread.c (dbx_end_psymtab): Update.
1448
1449 2019-01-15  Tom Tromey  <tom@tromey.com>
1450
1451         * symtab.c (lookup_objfile_from_block)
1452         (lookup_symbol_in_objfile_symtabs)
1453         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1454         (find_line_symtab, info_sources_command)
1455         (default_collect_symbol_completion_matches_break_on)
1456         (make_source_files_completion_list): Update.
1457         * symmisc.c (print_objfile_statistics, dump_objfile)
1458         (maintenance_print_symbols, maintenance_info_symtabs)
1459         (maintenance_check_symtabs, maintenance_info_line_tables):
1460         Update.
1461         * source.c (select_source_symtab)
1462         (forget_cached_source_info_for_objfile): Update.
1463         * objfiles.h (class objfile_compunits): Remove.
1464         (struct objfile) <compunits_range>: New typedef.
1465         (compunits): New method.
1466         * objfiles.c (objfile_relocate1): Update.
1467         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1468         * maint.c (count_symtabs_and_blocks): Update.
1469         * linespec.c (iterate_over_all_matching_symtabs): Update.
1470         * cp-support.c (add_symbol_overload_list_qualified): Update.
1471         * coffread.c (coff_symtab_read): Update.
1472         * ada-lang.c (add_nonlocal_symbols)
1473         (ada_collect_symbol_completion_matches)
1474         (ada_add_global_exceptions): Update.
1475
1476 2019-01-15  Tom Tromey  <tom@tromey.com>
1477
1478         * progspace.h (program_space) <objfiles_safe_range>: New
1479         typedef.
1480         <objfiles_safe>: New method.
1481         * objfiles.h (class all_objfiles_safe): Remove.
1482         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1483         * jit.c (jit_inferior_exit_hook): Update.
1484
1485 2019-01-17  Tom Tromey  <tom@tromey.com>
1486
1487         * progspace.h (program_space) <objfiles_range>: New typedef.
1488         <objfiles>: New method.
1489         <objfiles_head>: Rename from objfiles.
1490         (object_files): Update.
1491         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1492         * guile/scm-pretty-print.c
1493         (ppscm_find_pretty_printer_from_objfiles): Update.
1494         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1495         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1496         Update.
1497         * python/py-progspace.c (pspy_get_objfiles): Update.
1498         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1499         Update.
1500         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1501         (objfpy_lookup_objfile_by_build_id): Update.
1502         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1503         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1504         Update.
1505         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1506         (expand_symtab_containing_pc, lookup_objfile_from_block)
1507         (lookup_static_symbol, basic_lookup_transparent_type)
1508         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1509         (find_line_symtab, info_sources_command)
1510         (default_collect_symbol_completion_matches_break_on)
1511         (make_source_files_completion_list, find_main_name): Update.
1512         * symmisc.c (print_symbol_bcache_statistics)
1513         (print_objfile_statistics, maintenance_print_symbols)
1514         (maintenance_print_msymbols, maintenance_print_objfiles)
1515         (maintenance_info_symtabs, maintenance_check_symtabs)
1516         (maintenance_expand_symtabs, maintenance_info_line_tables):
1517         Update.
1518         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1519         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1520         (map_overlay_command, unmap_overlay_command)
1521         (simple_overlay_update, expand_symtabs_matching)
1522         (map_symbol_filenames): Update.
1523         * symfile-debug.c (set_debug_symfile): Update.
1524         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1525         Update.
1526         * source.c (select_source_symtab, forget_cached_source_info):
1527         Update.
1528         * solib.c (solib_read_symbols): Update.
1529         * solib-spu.c (append_ocl_sos): Update.
1530         * psymtab.c (maintenance_print_psymbols)
1531         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1532         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1533         * printcmd.c (info_symbol_command): Update.
1534         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1535         Update.
1536         * objfiles.h (class all_objfiles): Remove.
1537         * objfiles.c (have_partial_symbols, have_full_symbols)
1538         (have_minimal_symbols, qsort_cmp, update_section_map)
1539         (shared_objfile_contains_address_p)
1540         (default_iterate_over_objfiles_in_search_order): Update.
1541         * objc-lang.c (info_selectors_command, info_classes_command)
1542         (find_methods): Update.
1543         * minsyms.c (find_solib_trampoline_target): Update.
1544         * maint.c (maintenance_info_sections)
1545         (maintenance_translate_address, count_symtabs_and_blocks):
1546         Update.
1547         * main.c (captured_main_1): Update.
1548         * linux-thread-db.c (try_thread_db_load_from_pdir)
1549         (has_libpthread): Update.
1550         * linespec.c (iterate_over_all_matching_symtabs)
1551         (search_minsyms_for_name): Update.
1552         * jit.c (jit_find_objf_with_entry_addr): Update.
1553         * hppa-tdep.c (find_unwind_entry)
1554         (hppa_lookup_stub_minimal_symbol): Update.
1555         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1556         Update.
1557         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1558         (elf_gnu_ifunc_resolve_by_got): Update.
1559         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1560         * dwarf-index-write.c (save_gdb_index_command): Update.
1561         * cp-support.c (add_symbol_overload_list_qualified): Update.
1562         * breakpoint.c (create_overlay_event_breakpoint)
1563         (create_longjmp_master_breakpoint)
1564         (create_std_terminate_master_breakpoint)
1565         (create_exception_master_breakpoint): Update.
1566         * blockframe.c (find_pc_partial_function): Update.
1567         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1568         (ada_collect_symbol_completion_matches)
1569         (ada_add_global_exceptions): Update.
1570
1571 2019-01-17  Tom Tromey  <tom@tromey.com>
1572
1573         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1574         declare VEC.
1575         (solib_target_parse_libraries): Change return type.
1576         (library_list_start_segment, library_list_start_section)
1577         (library_list_end_library, library_list_start_library); Update.
1578         (solib_target_free_library_list): Remove.
1579         (solib_target_parse_libraries): Remove cleanup.  Change return
1580         type.
1581         (solib_target_current_sos): Update.
1582
1583 2019-01-17  Tom Tromey  <tromey@bapiya>
1584
1585         * valprint.c: Replace "the the" with "the".
1586         * symtab.c: Replace "the the" with "the".
1587         * solib.c: Replace "the the" with "the".
1588         * solib-dsbt.c: Replace "the the" with "the".
1589         * linespec.c: Replace "the the" with "the".
1590         * dwarf2loc.h: Replace "the the" with "the".
1591         * amd64-windows-tdep.c: Replace "the the" with "the".
1592         * aarch64-tdep.c: Replace "the the" with "the".
1593
1594 2019-01-16  Keith Seitz  <keiths@redhat.com>
1595
1596         PR gdb/23773
1597         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1598         <builder>: Rename to ..
1599         <m_builder>: ... this and make private.
1600         (dwarf2_cu::get_builder): New method.  Change all users of
1601         `builder' to use this method.
1602         (dwarf2_start_symtab): Move to ...
1603         (dwarf2_cu::start_symtab): ... here.  Update all callers
1604         (setup_type_unit_groups): Move to ...
1605         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1606         callers.
1607         (dwarf2_cu::reset_builder): New method.
1608         (process_full_compunit, process_full_type_unit): Use
1609         dwarf2_cu::reset_builder.
1610         (follow_die_offset): Record the ancestor CU if it is different
1611         from the followed DIE's CU.
1612         (follow_die_sig_1): Likewise.
1613
1614 2019-01-15  Tom Tromey  <tom@tromey.com>
1615
1616         * remote.c (class remote_state) <buf>: Now a char_vector.
1617         <buf_size>: Remove.
1618         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1619         parameter.
1620         (remote_target::getpkt_or_notif_sane_1)
1621         (remote_target::getpkt_sane)
1622         (remote_target::getpkt_or_notif_sane): Likewise.
1623         (class remote_target) <putpkt>: New overload.
1624         (remote_target::read_frame): Change type of "buf_p".  Remove
1625         sizeof_p parameter.
1626         (packet_ok): New overload.
1627         (packet_check_result): New overload.
1628         Update all uses.
1629
1630 2019-01-14  Tom Tromey  <tom@tromey.com>
1631
1632         * remote-notif.c (handle_notification, remote_notif_ack)
1633         (remote_notif_parse): Make "buf" const.
1634         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1635         const.
1636         (remote_notif_parse, remote_notif_ack, handle_notification):
1637         Likewise.
1638         * remote.c (remote_notif_stop_parse): Make "buf" const.
1639         (remote_target::remote_parse_stop_reply): Make "buf" const.
1640         (remote_notif_stop_ack): Make "buf" const.
1641
1642 2019-01-14  Tom Tromey  <tom@tromey.com>
1643
1644         * remote.c (remote_console_output): Make parameter const.
1645
1646 2019-01-14  Tom Tromey  <tom@tromey.com>
1647
1648         * target-debug.h (target_debug_print_signals): Constify.
1649         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1650         * procfs.c (procfs_target::pass_signals): Update.
1651         * linux-nat.c (linux_nat_target::pass_signals): Update.
1652         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1653         * target-delegates.c: Rebuild.
1654         * remote.c (remote_target::program_signals): Update.
1655         (remote_target::pass_signals): Update.
1656         * target.c (target_pass_signals): Constify argument.
1657         (target_program_signals): Likewise.
1658         * target.h (struct target_ops) <pass_signals, program_signals>:
1659         Constify argument.
1660         (target_pass_signals, target_program_signals): Constify argument.
1661
1662 2019-01-14  Tom Tromey  <tom@tromey.com>
1663
1664         PR tui/28819:
1665         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1666
1667 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1668
1669         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1670         field.
1671         * rs6000-tdep.c: Include reggroups.h.
1672         (IS_V_ALIAS_PSEUDOREG): Define.
1673         (rs6000_register_name): Return names for the "vX" aliases.
1674         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1675         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1676         aliases.  Call default_register_reggroup_p for all other
1677         pseudo-registers.
1678         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1679         New functions.
1680         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1681         Handle "vX" aliases.
1682         (v_alias_pseudo_register_collect): New function.
1683         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1684         (rs6000_gdbarch_init): Initialize "vX" aliases as
1685         pseudo-registers.  Restore registration of
1686         rs6000_pseudo_register_reggroup_p with
1687         set_tdesc_pseudo_register_reggroup_p.
1688
1689 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1690
1691         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1692         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1693         set_gdbarch_num_pseudo_regs.
1694
1695 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1696
1697         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1698         Remove arg prefixname, add do_set and do_show.
1699         Add member functions set_list and show_list.
1700         * cli/cli-style.c (class cli_style_option): Update accordingly.
1701         (style_set_list): Move to file scope.
1702         (style_show_list): Likewise.
1703         (set_style): Call help_list.
1704         (show_style): Call cmd_show_list.
1705         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1706         Update to use the new macro.
1707
1708 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1709
1710         * ada-lang.c (_initialize_ada_language): Expand the help text
1711         for the "catch exception" command.
1712
1713 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1714
1715         * symtab.c (matching_obj_sections): Initialize obj,
1716         declare it closer to its usage.
1717
1718 2019-01-10  Tom Tromey  <tom@tromey.com>
1719
1720         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1721         (basic_inf_threads_range): Remove.
1722         (inf_threads_range, inf_non_exited_threads_range)
1723         (safe_inf_threads_range): Use next_adapter.
1724
1725 2019-01-10  Keith Seitz  <keiths@redhat.com>
1726
1727         PR gdb/23712
1728         PR symtab/23010
1729         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1730         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1731
1732 2019-01-10  Keith Seitz  <keiths@redhat.com>
1733
1734         PR gdb/23712
1735         PR symtab/23010
1736         * dictionary.c (pending_to_vector): Remove.
1737         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1738         Remove _1 suffix, replacing functions of the same name.  Update
1739         all callers.
1740         (dict_create_hashed, dict_create_hashed_expandable)
1741         (dict_create_linear, dict_create_linear_expandable, dict_free)
1742         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1743         Make functions static.
1744
1745 2019-01-10  Keith Seitz  <keiths@redhat.com>
1746
1747         PR gdb/23712
1748         PR symtab/23010
1749         * dictionary.h (struct dictionary): Replace declaration with
1750         multidictionary.
1751         (dict_create_hashed, dict_create_hashed_expandable)
1752         (dict_create_linear, dict_create_linear_expandable)
1753         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1754         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1755         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1756         taking multidictionary argument.
1757         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1758         * block.h (struct block) <dict>: Change to multidictionary
1759         and rename `multidict'.
1760         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1761         symmisc.c: Update all dictionary references to multidictionary.
1762
1763 2019-01-10  Keith Seitz  <keiths@redhat.com>
1764
1765         PR gdb/23712
1766         PR symtab/23010
1767         * dictionary.c: Include unordered_map.
1768         (pending_to_vector): New function.
1769         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1770         Rewrite the non-"_1" functions to take vector instead
1771         of linked list.
1772         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1773         "new" _1 versions of the same name.
1774         (multidictionary): Define.
1775         (std::hash<enum language): New definition.
1776         (collate_pending_symbols_by_language, mdict_create_hashed)
1777         (mdict_create_hashed_expandable, mdict_create_linear)
1778         (mdict_create_linear_expandable, mdict_free)
1779         (find_language_dictionary, create_new_language_dictionary)
1780         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1781         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1782         (mdict_size, mdict_empty): New functions.
1783         * dictionary.h (mdict_iterator): Define.
1784
1785 2019-01-10  Pedro Alves  <palves@redhat.com>
1786
1787         * breakpoint.c (read_uploaded_action)
1788         (create_tracepoint_from_upload): Adjust to use
1789         gdb::unique_xmalloc_ptr.
1790         * ctf.c (ctf_write_uploaded_tp):
1791         (SET_ARRAY_FIELD): Use emplace_back.
1792         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1793         * tracefile-tfile.c (tfile_write_uploaded_tp):
1794         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1795         gdb::unique_xmalloc_ptr.
1796         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1797         at_string, cond_string, cmd_strings>: Replace char pointers
1798         with gdb::unique_xmalloc_ptr.
1799
1800 2019-01-10  Pedro Alves  <palves@redhat.com>
1801
1802         * solib-target.c (library_list_start_library): Don't xstrdup name.
1803
1804 2019-01-10  Pedro Alves  <palves@redhat.com>
1805
1806         * mdebugread.c (parse_partial_symbols): Use
1807         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1808
1809 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1810
1811         * linux-fork.c (scoped_switch_fork_info)
1812         <~scoped_switch_fork_info>: Fix incorrect variable name.
1813
1814 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1815
1816         * linux-fork.c (scoped_switch_fork_info)
1817         <scoped_switch_fork_info>: Make explicit.
1818         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1819
1820 2019-01-10  Tom Tromey  <tom@tromey.com>
1821
1822         * objfiles.h (objfile::reset_psymtabs): Update.
1823         * objfiles.c (objfile::objfile): Update.
1824         * psymtab.h (psymtab_storage::obstack): Update.
1825         (psymtab_storage::m_obstack): Use gdb::optional.
1826         (class psymtab_storage): Update comment.  Remove objfile
1827         parameter.
1828         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1829
1830 2019-01-10  Tom Tromey  <tom@tromey.com>
1831
1832         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1833         <free_psymtabs>: Now private.
1834         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1835         (allocate_psymtab): Use new method.
1836
1837 2019-01-10  Tom Tromey  <tom@tromey.com>
1838
1839         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1840         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1841         * mdebugread.c (parse_partial_symbols): Use
1842         allocate_dependencies.
1843         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1844         allocate_dependencies.
1845         (process_psymtab_comp_unit_reader)
1846         (build_type_psymtab_dependencies): Likewise.
1847         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1848
1849 2019-01-10  Tom Tromey  <tom@tromey.com>
1850
1851         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1852         PSYMBOL_SET_LANGUAGE.
1853         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1854
1855 2019-01-10  Tom Tromey  <tom@tromey.com>
1856
1857         * psymtab.h (psymtab_storage::obstack): New method.
1858         <m_obstack>: Rename from obstack; now private.
1859         * psymtab.c (psymtab_storage): Update.
1860         * dwarf2read.c (create_addrmap_from_index)
1861         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1862         Update.
1863
1864 2019-01-10  Tom Tromey  <tom@tromey.com>
1865
1866         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1867         * objfiles.h (objfile::reset_psymtabs): New method.
1868
1869 2019-01-10  Tom Tromey  <tom@tromey.com>
1870
1871         * symmisc.c (print_symbol_bcache_statistics): Update.
1872         (print_objfile_statistics): Update.
1873         * symfile.c (reread_symbols): Update.
1874         * psymtab.h (class psymtab_storage): New.
1875         * psymtab.c (psymtab_storage): New constructor.
1876         (~psymtab_storage): New destructor.
1877         (require_partial_symbols): Update.
1878         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1879         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1880         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1881         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1882         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1883         (start_psymtab_common, end_psymtab_common)
1884         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1885         (allocate_psymtab): Update.
1886         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1887         Update.
1888         (dump_psymtab_addrmap, maintenance_print_psymbols)
1889         (maintenance_check_psymtabs): Update.
1890         (class objfile_psymtabs): Move to objfiles.h.
1891         * psympriv.h (discard_psymtab): Now inline.
1892         (psymtab_discarder::psymtab_discarder): Update.
1893         (psymtab_discarder::~psymtab_discarder): Update.
1894         (ALL_OBJFILE_PSYMTABS): Rewrite.
1895         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1896         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1897         Remove fields.
1898         <partial_symtabs>: New field.
1899         (class objfile_psymtabs): Move from psymtab.h.  Update.
1900         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1901         psymbol_cache.
1902         (objfile::~objfile): Don't destroy psymbol_cache.
1903         * mdebugread.c (parse_partial_symbols): Update.
1904         * dwarf2read.c (create_addrmap_from_index)
1905         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1906         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1907         (add_partial_subprogram, dwarf2_ranges_read): Update.
1908         * dwarf-index-write.c (write_address_map)
1909         (write_one_signatured_type, recursively_write_psymbols)
1910         (class debug_names, class debug_names, write_psymtabs_to_index):
1911         Update.
1912
1913 2019-01-10  Tom Tromey  <tom@tromey.com>
1914
1915         * symtab.h (SYMBOL_SET_NAMES): Update.
1916         (symbol_set_names): Update.
1917         (MSYMBOL_SET_NAMES): Update.
1918         * symtab.c (symbol_set_names): Change argument to be an
1919         objfile_per_bfd_storage.
1920         * psymtab.c (add_psymbol_to_bcache): Update.
1921         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1922
1923 2019-01-10  Tom Tromey  <tom@tromey.com>
1924
1925         * symtab.c (create_demangled_names_hash): Change argument to be an
1926         objfile_per_bfd_storage.
1927         (symbol_set_names): Update.
1928
1929 2019-01-10  Tom Tromey  <tom@tromey.com>
1930
1931         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1932         init_psymbol_list.
1933         * psymtab.c (init_psymbol_list): Do nothing if already called.
1934         * psympriv.h (init_psymbol_list): Add comment.
1935         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1936         init_psymbol_list.
1937         * dbxread.c (dbx_symfile_read): Unconditionally call
1938         init_psymbol_list.
1939
1940 2019-01-10  Tom Tromey  <tom@tromey.com>
1941
1942         * xcoffread.c (scan_xcoff_symtab): Update.
1943         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1944         "where".
1945         * mdebugread.c (parse_partial_symbols)
1946         (handle_psymbol_enumerators): Update.
1947         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1948         * dbxread.c (read_dbx_symtab): Update.
1949         * psympriv.h (psymbol_placement): New enum.
1950         (add_psymbol_to_list): Update.
1951
1952 2019-01-10  Tom Tromey  <tom@tromey.com>
1953
1954         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1955         static_psymbols parameters.
1956         (scan_xcoff_symtab): Update.
1957         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1958         static_psymbols parameters.
1959         * psympriv.h (start_psymtab_common): Update.
1960         * mdebugread.c (parse_partial_symbols): Update.
1961         * dwarf2read.c (create_partial_symtab): Update.
1962         * dbxread.c (read_dbx_symtab): Update.
1963         (start_psymtab): Remove global_psymbols and static_psymbols
1964         parameters.
1965
1966 2019-01-10  Tom Tromey  <tom@tromey.com>
1967
1968         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1969         * psymtab.c (allocate_psymtab): Add comment.
1970         * psympriv.h (allocate_psymtab): Add comment.
1971         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1972         initializations.
1973         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1974
1975 2019-01-10  Tom Tromey  <tom@tromey.com>
1976
1977         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1978         Don't declare.
1979         * mipsread.c: Include mdebugread.h.
1980         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1981         Declare.
1982         * elfread.c: Include mdebugread.h.
1983
1984 2019-01-09  Tom Tromey  <tom@tromey.com>
1985
1986         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1987         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1988         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1989         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1990         (psym_lookup_symbol, psym_find_last_source_symtab)
1991         (psym_forget_cached_source_info, psym_print_stats)
1992         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1993         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1994         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1995         (psym_find_compunit_symtab_by_address)
1996         (maintenance_print_psymbols, maintenance_info_psymtabs)
1997         (maintenance_check_psymtabs): Use ranged for.
1998         * psymtab.h (class objfile_psymtabs): New.
1999         (require_partial_symbols): Return objfile_psymtabs.
2000         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2001
2002 2019-01-09  Tom Tromey  <tom@tromey.com>
2003
2004         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2005         (find_pc_mapped_section, list_overlays_command)
2006         (map_overlay_command, unmap_overlay_command)
2007         (simple_overlay_update): Use all_objfiles.
2008         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2009         * printcmd.c (info_symbol_command): Use all_objfiles.
2010         * objfiles.h (ALL_OBJSECTIONS): Remove.
2011         * maint.c (maintenance_translate_address): Use all_objfiles.
2012         * gcore.c (gcore_create_callback): Use all_objfiles.
2013         (objfile_find_memory_regions): Likewise.
2014
2015 2019-01-09  Tom Tromey  <tom@tromey.com>
2016
2017         * symtab.c (find_line_symtab, info_sources_command)
2018         (make_source_files_completion_list): Use objfile_compunits.
2019         * source.c (select_source_symtab): Use objfile_compunits.
2020         * objfiles.h (struct objfile): Update comment.
2021         (ALL_OBJFILES): Remove.
2022         (ALL_FILETABS): Remove.
2023         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2024         objfile_compunits.
2025
2026 2019-01-09  Tom Tromey  <tom@tromey.com>
2027
2028         * symmisc.c (print_objfile_statistics, dump_objfile)
2029         (maintenance_print_symbols): Use compunit_filetabs.
2030         * source.c (forget_cached_source_info_for_objfile): Use
2031         compunit_filetabs.
2032         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2033         (ALL_FILETABS): Use compunit_filetabs.
2034         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2035         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2036
2037 2019-01-09  Tom Tromey  <tom@tromey.com>
2038
2039         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2040         (compunit_filetabs): New.
2041         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2042         compunit_filetabs.
2043         (info_sources_command, make_source_files_completion_list): Remove
2044         declaration.
2045         * symmisc.c (print_objfile_statistics, dump_objfile)
2046         (maintenance_print_symbols): Remove declaration.
2047         (maintenance_info_symtabs): Use compunit_filetabs.
2048         (maintenance_info_line_tables): Likewise.
2049         * source.c (select_source_symtab): Change local variable name.
2050         (forget_cached_source_info_for_objfile): Remove declaration.
2051         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2052         * objfiles.c (objfile_relocate1): Remove declaration.
2053         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2054         declaration.
2055         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2056         * coffread.c (coff_symtab_read): Remove declaration.
2057         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2058         compunit_filetabs.
2059
2060 2019-01-09  Tom Tromey  <tom@tromey.com>
2061
2062         * symtab.c (lookup_objfile_from_block)
2063         (find_pc_sect_compunit_symtab, search_symbols)
2064         (default_collect_symbol_completion_matches_break_on): Use
2065         objfile_compunits.
2066         * objfiles.h (ALL_COMPUNITS): Remove.
2067         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2068         * cp-support.c (add_symbol_overload_list_qualified): Use
2069         objfile_compunits.
2070         * ada-lang.c (ada_collect_symbol_completion_matches)
2071         (ada_add_global_exceptions): Use objfile_compunits.
2072
2073 2019-01-09  Tom Tromey  <tom@tromey.com>
2074
2075         * source.c (select_source_symtab)
2076         (forget_cached_source_info_for_objfile): Remove declaration.
2077         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2078         declaration.
2079         * maint.c (count_symtabs_and_blocks): Remove declaration.
2080         * cp-support.c (add_symbol_overload_list_qualified): Remove
2081         declaration.
2082         * coffread.c (coff_symtab_read): Remove declaration.
2083         * symtab.c (lookup_symbol_in_objfile_symtabs)
2084         (basic_lookup_transparent_type_1): Use objfile_compunits.
2085         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2086         (info_sources_command, search_symbols)
2087         (default_collect_symbol_completion_matches_break_on)
2088         (make_source_files_completion_list): Remove declaration.
2089         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2090         (ada_collect_symbol_completion_matches)
2091         (ada_add_global_exceptions): Remove declaration.
2092         * linespec.c (iterate_over_all_matching_symtabs): Use
2093         objfile_compunits.
2094         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2095         (class objfile_compunits): New.
2096         (ALL_COMPUNITS): Use objfile_compunits.
2097         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2098         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2099         objfile_compunits.
2100         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2101
2102 2019-01-09  Tom Tromey  <tom@tromey.com>
2103
2104         * symtab.c (search_symbols)
2105         (default_collect_symbol_completion_matches_break_on): Use
2106         objfile_msymbols.
2107         * ada-lang.c (ada_lookup_simple_minsym)
2108         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2109         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2110         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2111         objfile_msymbols.
2112         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2113         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2114         * objc-lang.c (find_methods): Use objfile_msymbols.
2115         (info_selectors_command, info_classes_command): Likewise.
2116         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2117         * objfiles.h (class objfile_msymbols): New.
2118         (ALL_OBJFILE_MSYMBOLS): Remove.
2119         (ALL_MSYMBOLS): Remove.
2120
2121 2019-01-09  Tom Tromey  <tom@tromey.com>
2122
2123         * common/next-iterator.h (next_adapter): Add Iterator template
2124         parameter.
2125         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2126         (class all_objfiles_safe): New.
2127         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2128         * objfiles.c (put_objfile_before): Update comment.
2129         (add_separate_debug_objfile): Likewise.
2130         (free_all_objfiles): Use all_objfiles_safe.
2131         (objfile_purge_solibs): Likewise.
2132
2133 2019-01-09  Tom Tromey  <tom@tromey.com>
2134
2135         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2136         (expand_symtab_containing_pc, lookup_static_symbol)
2137         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2138         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2139         all_objfiles.
2140         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2141         * breakpoint.c (create_overlay_event_breakpoint)
2142         (create_longjmp_master_breakpoint)
2143         (create_std_terminate_master_breakpoint)
2144         (create_exception_master_breakpoint): Use all_objfiles.
2145         * linux-thread-db.c (try_thread_db_load_from_pdir)
2146         (has_libpthread): Use all_objfiles.
2147         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2148         * linespec.c (iterate_over_all_matching_symtabs)
2149         (search_minsyms_for_name): Use all_objfiles.
2150         * maint.c (maintenance_info_sections): Use all_objfiles.
2151         * main.c (captured_main_1): Use all_objfiles.
2152         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2153         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2154         * guile/scm-pretty-print.c
2155         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2156         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2157         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2158         (maintenance_print_msymbols): Use all_objfiles.
2159         * source.c (select_source_symtab): Use all_objfiles.
2160         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2161         * symfile.c (remove_symbol_file_command)
2162         (expand_symtabs_matching, map_symbol_filenames): Use
2163         all_objfiles.
2164         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2165         all_objfiles.
2166         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2167         * objc-lang.c (find_methods): Use all_objfiles.
2168         * objfiles.c (have_partial_symbols, have_full_symbols)
2169         (have_minimal_symbols, qsort_cmp)
2170         (default_iterate_over_objfiles_in_search_order): Use
2171         all_objfiles.
2172         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2173         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2174         (maintenance_check_psymtabs): Use all_objfiles.
2175         (ALL_PSYMTABS): Remove.
2176         * compile/compile-object-run.c (do_module_cleanup): Use
2177         all_objfiles.
2178         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2179         * cp-support.c (add_symbol_overload_list_qualified): Use
2180         all_objfiles.
2181         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2182         Use all_objfiles.
2183         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2184         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2185         all_objfiles.
2186         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2187         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2188         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2189         Uses all_objfiles.
2190         * solib.c (solib_read_symbols): Use all_objfiles
2191
2192 2019-01-09  Tom Tromey  <tom@tromey.com>
2193
2194         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2195         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2196         all_objfiles.
2197         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2198         * symmisc.c (print_symbol_bcache_statistics)
2199         (print_objfile_statistics, maintenance_print_objfiles)
2200         (maintenance_info_symtabs, maintenance_check_symtabs)
2201         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2202         all_objfiles.
2203         * source.c (forget_cached_source_info): Use all_objfiles.
2204         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2205         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2206         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2207         * objfiles.c (update_section_map): Use all_objfiles.
2208         (shared_objfile_contains_address_p): Likewise.
2209         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2210         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2211
2212 2019-01-09  Tom Tromey  <tom@tromey.com>
2213
2214         * common/next-iterator.h: New file.
2215         * objfiles.h (class all_objfiles): New.
2216         (struct objfile_iterator): New.
2217
2218 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2219
2220         * NEWS: Move the description of the changed "frame", "select-frame",
2221          and "info frame" commands to the Changed commands section.
2222
2223 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2224
2225         * gdbtypes.c (check_stub_method_group): Remove handling of old
2226         mangling schemes.
2227         * linespec.c (find_methods): Likewise.
2228         * stabsread.c (read_member_functions): Likewise.
2229         * valops.c (search_struct_method): Likewise.
2230         (value_struct_elt_for_reference): Likewise.
2231         * NEWS: Mention this change.
2232
2233 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2234
2235         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2236         print_source_lines.
2237         * source.c (print_source_lines_base): Update line number check.
2238         (print_source_lines): New function.
2239         (source_lines_range::source_lines_range): New function.
2240         * source.h (class source_lines_range): New class.
2241         (print_source_lines): New declaration.
2242
2243 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2244
2245         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2246
2247 2019-01-08  Tom Tromey  <tom@tromey.com>
2248             Simon Marchi  <simon.marchi@ericsson.com>
2249
2250         PR gdb/24060
2251         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2252         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2253         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2254         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2255         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2256         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2257
2258 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2259
2260         * source.c (select_source_symtab): Move header comment to
2261         declaration in source.h.
2262         (forget_cached_source_info_for_objfile): Likewise.
2263         (forget_cached_source_info): Likewise.
2264         (identify_source_line): Likewise.
2265         * source.h (identify_source_line): Move declaration from symtab.h
2266         and add comment from source.c
2267         (print_source_lines): Likewise.
2268         (forget_cached_source_info_for_objfile): Likewise.
2269         (forget_cached_source_info): Likewise.
2270         (select_source_symtab): Likewise.
2271         (enum print_source_lines_flag): Move definition from symtab.h.
2272         * symtab.h (identify_source_line): Move declaration to source.h.
2273         (print_source_lines): Likewise.
2274         (forget_cached_source_info_for_objfile): Likewise.
2275         (forget_cached_source_info): Likewise.
2276         (select_source_symtab): Likewise.
2277         (enum print_source_lines_flag): Move definition to source.h.
2278         * tui/tui-hooks.c: Add 'source.h' include.
2279
2280 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * source.c (print_source_lines_base): Handle requests to print
2283         reverse line number sequences, and guard against empty lines
2284         string.
2285
2286 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * source.c (print_source_lines_base): Fix skip of '\r' if next
2289         character is '\n'.
2290
2291 2019-01-06  Tom Tromey  <tom@tromey.com>
2292
2293         * c-exp.y (struct c_parse_state) <macro_original_text,
2294         expansion_obstack>: New member.
2295         (macro_original_text, expansion_obstack): Remove globals.
2296         (scan_macro_expansion, scanning_macro_expansion)
2297         (finished_macro_expansion): Update.
2298         (scan_macro_cleanup): Remove.
2299         (yylex, c_parse): Update.
2300
2301 2019-01-06  Tom Tromey  <tom@tromey.com>
2302
2303         * c-exp.y (struct c_parse_state) <strings>: New member.
2304         (operator_stoken): Update.
2305
2306 2019-01-06  Tom Tromey  <tom@tromey.com>
2307
2308         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2309         (union type_stack_elt) <typelist_val>: Now a pointer to
2310         std::vector.
2311         (type_stack_cleanup): Don't declare.
2312         (push_typelist): Update.
2313         * parse.c (pop_typelist): Return a std::vector.
2314         (push_typelist): Take a std::vector.
2315         (follow_types): Update.  Do not free args.
2316         (type_stack_cleanup): Remove.
2317         * c-exp.y (struct c_parse_state): New.
2318         (cpstate): New global.
2319         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2320         (nonempty_typelist): Update.
2321         (func_mod): Create a new vector.
2322         (c_parse): Create a c_parse_state.
2323         (check_parameter_typelist): Do not delete params.
2324         (function_method): Update.  Do not delete type_list.
2325
2326 2019-01-06  Tom Tromey  <tom@tromey.com>
2327
2328         PR gdb/28155:
2329         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2330         check_typedef.
2331         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2332         (print_return_value): Likewise.
2333
2334 2019-01-05  Tom Tromey  <tom@tromey.com>
2335
2336         * contrib/cleanup_check.py: Remove.
2337         * contrib/gcc-with-excheck: Remove.
2338         * contrib/exsummary.py: Remove.
2339         * contrib/excheck.py: Remove.
2340
2341 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2342
2343         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2344         NULL. Initialize tpprev to NULL instead of assigning it
2345         to NULL on the next statement.
2346         * windows-nat.c (windows_delete_thread): Remove check for
2347         main_thread_id before printing thread exit notifications.
2348         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2349         Remove thread ID check against main_thread_id.
2350         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2351         windows_delete_thread.
2352         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2353
2354 2019-01-04  Tom Tromey  <tom@tromey.com>
2355
2356         * compile/compile.c (_initialize_compile): Use upper case for
2357         metasyntactic variables.
2358         * symmisc.c (_initialize_symmisc): Use upper case for
2359         metasyntactic variables.
2360         * psymtab.c (_initialize_psymtab): Use upper case for
2361         metasyntactic variables.
2362         * demangle.c (demangle_command): Use upper case for metasyntactic
2363         variables.
2364         (_initialize_demangler): Likewise.
2365         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2366         variables.
2367
2368 2019-01-03  Tom Tromey  <tom@tromey.com>
2369
2370         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2371
2372 2019-01-03  Tom Tromey  <tom@tromey.com>
2373
2374         * python/py-symtab.c (salpy_str): Update.
2375         (struct salpy_sal_object) <symtab>: Now a PyObject.
2376         (salpy_dealloc): Update.
2377         (del_objfile_sal): Use gdbpy_ref.
2378
2379 2019-01-03  Tom Tromey  <tom@tromey.com>
2380
2381         * python/py-type.c (convert_field): Use new_reference.  Return
2382         gdbpy_ref.
2383         (make_fielditem): Return gdbpy_ref.
2384         (typy_fields): Update.
2385         (typy_getitem): Update.
2386         (field_name): Return gdbpy_ref.  Use new_reference.
2387         (typy_iterator_iternext): Update.
2388
2389 2019-01-03  Tom Tromey  <tom@tromey.com>
2390
2391         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2392
2393 2019-01-03  Tom Tromey  <tom@tromey.com>
2394
2395         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2396         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2397         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2398         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2399         (pspy_set_type_printers): Likewise.
2400         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2401         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2402         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2403         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2404         (objfpy_set_type_printers): Likewise.
2405
2406 2019-01-03  Tom Tromey  <tom@tromey.com>
2407
2408         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2409         (gdbpy_print_stack): Use gdbpy_err_fetch.
2410         * python/python-internal.h (class gdbpy_err_fetch): New class.
2411         (class gdbpy_enter) <m_error_type, m_error_value,
2412         m_error_traceback>: Remove.
2413         <m_error>: New member.
2414         (gdbpy_exception_to_string): Don't declare.
2415         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2416         * python/py-value.c (convert_value_from_python): Use
2417         gdbpy_err_fetch.
2418         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2419         gdbpy_exception_to_string.
2420         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2421         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2422         gdbpy_err_fetch.
2423
2424 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2425
2426         * linux-nat.c (delete_lwp_cleanup): Delete.
2427         (struct lwp_deleter): New struct.
2428         (lwp_info_up): New typedef.
2429         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2430         lwp_info_up.
2431
2432 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2433
2434         * linux-fork.c (class scoped_switch_fork_info): New class.
2435         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2436
2437 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2438
2439         * valops.c (find_overload_match): Remove use of null_cleanup, and
2440         calls to do_cleanups.
2441
2442 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2443
2444         * compile/compile-cplus-types.c
2445         (compile_cplus_instance::decl_name): Handle changes to
2446         cp_func_name.
2447         * cp-support.c (cp_func_name): Update header comment, update
2448         return type.
2449         * cp-support.h (cp_func_name): Update return type in declaration.
2450         * valops.c (find_overload_match): Move temp_func local to top
2451         level of function and change its type.  Use temp_func to hold and
2452         delete temporary string obtained from cp_func_name.
2453
2454 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2455
2456         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2457         gdb::char_vector, remove cleanup, and update uses of `msg`.
2458
2459 2019-01-03  Jim Wilson  <jimw@sifive.com>
2460
2461         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2462
2463 2019-01-02  Tom Tromey  <tom@tromey.com>
2464
2465         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2466         (tdesc_parse_xml): Remove cleanups.
2467         * target-descriptions.h (make_cleanup_free_target_description):
2468         Don't declare.
2469         (target_desc_deleter): New struct.
2470         (target_desc_up): New typedef.
2471         * target-descriptions.c (target_desc_deleter::operator()): Rename
2472         from free_target_description.
2473         (make_cleanup_free_target_description): Remove.
2474
2475 2019-01-02  Tom Tromey  <tom@tromey.com>
2476
2477         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2478         constructor, destructor.
2479         (linespec_parser): Remove typedef.
2480         (~linespec_parser): Rename from linespec_parser_delete.
2481         (linespec_lex_to_end, linespec_complete_label)
2482         (linespec_complete): Update.
2483         (decode_line_full): Remove cleanups.
2484         (decode_line_1): Update.
2485
2486 2019-01-02  Tom Tromey  <tom@tromey.com>
2487
2488         * python/python-internal.h (inferior_to_inferior_object): Change
2489         return type.
2490         * python/py-exitedevent.c (create_exited_event_object): Update.
2491         * python/py-inferior.c (inferior_to_inferior_object): Return
2492         gdbpy_ref.
2493         (python_new_inferior, python_inferior_deleted)
2494         (thread_to_thread_object, delete_thread_object)
2495         (build_inferior_list, gdbpy_selected_inferior): Update.
2496         * python/py-infthread.c (create_thread_object): Update.  Also fail
2497         if inferior_to_inferior_object fails.
2498
2499 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2500
2501         * inferior.h (class inferior) <displaced_step_state>: New field.
2502         * infrun.h (struct displaced_step_state): Move here from
2503         infrun.c.  Initialize fields, add constructor.
2504         <inf>: Remove field.
2505         <reset>: New method.
2506         * infrun.c (struct displaced_step_inferior_state): Move to
2507         infrun.h.
2508         (displaced_step_inferior_states): Remove.
2509         (get_displaced_stepping_state): Adust.
2510         (displaced_step_in_progress_any_inferior): Adjust.
2511         (displaced_step_in_progress_thread): Adjust.
2512         (displaced_step_in_progress): Adjust.
2513         (add_displaced_stepping_state): Remove.
2514         (get_displaced_step_closure_by_addr): Adjust.
2515         (remove_displaced_stepping_state): Remove.
2516         (infrun_inferior_exit): Call displaced_step_state.reset.
2517         (use_displaced_stepping): Don't check for NULL.
2518         (displaced_step_prepare_throw): Call
2519         get_displaced_stepping_state.
2520         (displaced_step_fixup): Don't check for NULL.
2521         (prepare_for_detach): Don't check for NULL.
2522
2523 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2524
2525         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2526          in case of call that did not complete.
2527
2528 2019-01-02  Andrey Utkin  <autkin@undo.io>
2529
2530         * symfile.c (find_separate_debug_file): Fix search of debug files for
2531         remote debuggee.
2532
2533 2019-01-02  Tom Tromey  <tom@tromey.com>
2534
2535         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2536         indentation.
2537         * python/py-frame.c (frapy_older): Remove cast.
2538         (frapy_newer): Likewise.
2539         * python/py-breakpoint.c (local_setattro): Remove cast.
2540         * python/py-arch.c (archpy_name): Remove local variable.
2541         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2542
2543 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2544
2545         * unittests/basic_string_view/element_access/char/empty.cc:
2546         Fix year range in copyright header.
2547
2548 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2549
2550         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2551         Delete.
2552         <operator==>: Update with for removed field.
2553         <hash>: Likewise.
2554         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2555         <isa_features>: ...this.
2556         <abi_features>: New field.
2557         (riscv_isa_flen): Update comment.
2558         (riscv_abi_xlen): New declaration.
2559         (riscv_abi_flen): New declaration.
2560         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2561         isa_features.
2562         (riscv_abi_xlen): New function.
2563         (riscv_isa_flen): Update to get answer from isa_features.
2564         (riscv_abi_flen): New function.
2565         (riscv_has_fp_abi): Update to get answer from abi_features.
2566         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2567         xlen and flen.
2568         (riscv_call_info) <xlen, flen>: Update comment.
2569         (riscv_call_arg_struct): Remove invalid assertions
2570         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2571         is removed.
2572         (riscv_gdbarch_init): Gather isa features and abi features
2573         separately, ensure both match on the gdbarch when reusing an old
2574         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2575         a target with 64-bit float hardware.
2576
2577 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2578
2579         * source.c (search_command_helper): Stop reverse search
2580         when line 1 has been searched.
2581
2582 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2583
2584         * record-full.c (record_full_base_target::close): Rewrite
2585         record_full_core_buf_list free logic.
2586
2587 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2588
2589         * break-catch-syscall.c (print_one_catch_syscall): xfree
2590         the last text.
2591
2592 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2593
2594         * top.c (print_gdb_version): Update Copyright year in version
2595         message.
2596
2597 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2598
2599         Update copyright year range in all GDB files.
2600
2601 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2602
2603         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2604
2605 For older changes see ChangeLog-2018.
2606 \f
2607 Local Variables:
2608 mode: change-log
2609 left-margin: 8
2610 fill-column: 74
2611 version-control: never
2612 coding: utf-8
2613 End:
2614