gdb/ChangeLog

   1 2019-01-10  Tom Tromey  <tom@tromey.com>
   2
   3         * symmisc.c (print_symbol_bcache_statistics): Update.
   4         (print_objfile_statistics): Update.
   5         * symfile.c (reread_symbols): Update.
   6         * psymtab.h (class psymtab_storage): New.
   7         * psymtab.c (psymtab_storage): New constructor.
   8         (~psymtab_storage): New destructor.
   9         (require_partial_symbols): Update.
  10         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
  11         (find_pc_sect_psymtab, find_pc_sect_psymbol)
  12         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
  13         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
  14         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
  15         (start_psymtab_common, end_psymtab_common)
  16         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
  17         (allocate_psymtab): Update.
  18         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
  19         Update.
  20         (dump_psymtab_addrmap, maintenance_print_psymbols)
  21         (maintenance_check_psymtabs): Update.
  22         (class objfile_psymtabs): Move to objfiles.h.
  23         * psympriv.h (discard_psymtab): Now inline.
  24         (psymtab_discarder::psymtab_discarder): Update.
  25         (psymtab_discarder::~psymtab_discarder): Update.
  26         (ALL_OBJFILE_PSYMTABS): Rewrite.
  27         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
  28         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
  29         Remove fields.
  30         <partial_symtabs>: New field.
  31         (class objfile_psymtabs): Move from psymtab.h.  Update.
  32         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
  33         psymbol_cache.
  34         (objfile::~objfile): Don't destroy psymbol_cache.
  35         * mdebugread.c (parse_partial_symbols): Update.
  36         * dwarf2read.c (create_addrmap_from_index)
  37         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
  38         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
  39         (add_partial_subprogram, dwarf2_ranges_read): Update.
  40         * dwarf-index-write.c (write_address_map)
  41         (write_one_signatured_type, recursively_write_psymbols)
  42         (class debug_names, class debug_names, write_psymtabs_to_index):
  43         Update.
  44
  45 2019-01-10  Tom Tromey  <tom@tromey.com>
  46
  47         * symtab.h (SYMBOL_SET_NAMES): Update.
  48         (symbol_set_names): Update.
  49         (MSYMBOL_SET_NAMES): Update.
  50         * symtab.c (symbol_set_names): Change argument to be an
  51         objfile_per_bfd_storage.
  52         * psymtab.c (add_psymbol_to_bcache): Update.
  53         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
  54
  55 2019-01-10  Tom Tromey  <tom@tromey.com>
  56
  57         * symtab.c (create_demangled_names_hash): Change argument to be an
  58         objfile_per_bfd_storage.
  59         (symbol_set_names): Update.
  60
  61 2019-01-10  Tom Tromey  <tom@tromey.com>
  62
  63         * xcoffread.c (xcoff_initial_scan): Unconditionally call
  64         init_psymbol_list.
  65         * psymtab.c (init_psymbol_list): Do nothing if already called.
  66         * psympriv.h (init_psymbol_list): Add comment.
  67         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
  68         init_psymbol_list.
  69         * dbxread.c (dbx_symfile_read): Unconditionally call
  70         init_psymbol_list.
  71
  72 2019-01-10  Tom Tromey  <tom@tromey.com>
  73
  74         * xcoffread.c (scan_xcoff_symtab): Update.
  75         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
  76         "where".
  77         * mdebugread.c (parse_partial_symbols)
  78         (handle_psymbol_enumerators): Update.
  79         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
  80         * dbxread.c (read_dbx_symtab): Update.
  81         * psympriv.h (psymbol_placement): New enum.
  82         (add_psymbol_to_list): Update.
  83
  84 2019-01-10  Tom Tromey  <tom@tromey.com>
  85
  86         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
  87         static_psymbols parameters.
  88         (scan_xcoff_symtab): Update.
  89         * psymtab.c (start_psymtab_common): Remove global_psymbols and
  90         static_psymbols parameters.
  91         * psympriv.h (start_psymtab_common): Update.
  92         * mdebugread.c (parse_partial_symbols): Update.
  93         * dwarf2read.c (create_partial_symtab): Update.
  94         * dbxread.c (read_dbx_symtab): Update.
  95         (start_psymtab): Remove global_psymbols and static_psymbols
  96         parameters.
  97
  98 2019-01-10  Tom Tromey  <tom@tromey.com>
  99
 100         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 101         * psymtab.c (allocate_psymtab): Add comment.
 102         * psympriv.h (allocate_psymtab): Add comment.
 103         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 104         initializations.
 105         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 106
 107 2019-01-10  Tom Tromey  <tom@tromey.com>
 108
 109         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 110         Don't declare.
 111         * mipsread.c: Include mdebugread.h.
 112         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 113         Declare.
 114         * elfread.c: Include mdebugread.h.
 115
 116 2019-01-09  Tom Tromey  <tom@tromey.com>
 117
 118         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 119         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 120         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 121         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 122         (psym_lookup_symbol, psym_find_last_source_symtab)
 123         (psym_forget_cached_source_info, psym_print_stats)
 124         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 125         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 126         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 127         (psym_find_compunit_symtab_by_address)
 128         (maintenance_print_psymbols, maintenance_info_psymtabs)
 129         (maintenance_check_psymtabs): Use ranged for.
 130         * psymtab.h (class objfile_psymtabs): New.
 131         (require_partial_symbols): Return objfile_psymtabs.
 132         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 133
 134 2019-01-09  Tom Tromey  <tom@tromey.com>
 135
 136         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 137         (find_pc_mapped_section, list_overlays_command)
 138         (map_overlay_command, unmap_overlay_command)
 139         (simple_overlay_update): Use all_objfiles.
 140         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 141         * printcmd.c (info_symbol_command): Use all_objfiles.
 142         * objfiles.h (ALL_OBJSECTIONS): Remove.
 143         * maint.c (maintenance_translate_address): Use all_objfiles.
 144         * gcore.c (gcore_create_callback): Use all_objfiles.
 145         (objfile_find_memory_regions): Likewise.
 146
 147 2019-01-09  Tom Tromey  <tom@tromey.com>
 148
 149         * symtab.c (find_line_symtab, info_sources_command)
 150         (make_source_files_completion_list): Use objfile_compunits.
 151         * source.c (select_source_symtab): Use objfile_compunits.
 152         * objfiles.h (struct objfile): Update comment.
 153         (ALL_OBJFILES): Remove.
 154         (ALL_FILETABS): Remove.
 155         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 156         objfile_compunits.
 157
 158 2019-01-09  Tom Tromey  <tom@tromey.com>
 159
 160         * symmisc.c (print_objfile_statistics, dump_objfile)
 161         (maintenance_print_symbols): Use compunit_filetabs.
 162         * source.c (forget_cached_source_info_for_objfile): Use
 163         compunit_filetabs.
 164         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 165         (ALL_FILETABS): Use compunit_filetabs.
 166         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 167         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 168
 169 2019-01-09  Tom Tromey  <tom@tromey.com>
 170
 171         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 172         (compunit_filetabs): New.
 173         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 174         compunit_filetabs.
 175         (info_sources_command, make_source_files_completion_list): Remove
 176         declaration.
 177         * symmisc.c (print_objfile_statistics, dump_objfile)
 178         (maintenance_print_symbols): Remove declaration.
 179         (maintenance_info_symtabs): Use compunit_filetabs.
 180         (maintenance_info_line_tables): Likewise.
 181         * source.c (select_source_symtab): Change local variable name.
 182         (forget_cached_source_info_for_objfile): Remove declaration.
 183         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 184         * objfiles.c (objfile_relocate1): Remove declaration.
 185         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 186         declaration.
 187         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 188         * coffread.c (coff_symtab_read): Remove declaration.
 189         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 190         compunit_filetabs.
 191
 192 2019-01-09  Tom Tromey  <tom@tromey.com>
 193
 194         * symtab.c (lookup_objfile_from_block)
 195         (find_pc_sect_compunit_symtab, search_symbols)
 196         (default_collect_symbol_completion_matches_break_on): Use
 197         objfile_compunits.
 198         * objfiles.h (ALL_COMPUNITS): Remove.
 199         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 200         * cp-support.c (add_symbol_overload_list_qualified): Use
 201         objfile_compunits.
 202         * ada-lang.c (ada_collect_symbol_completion_matches)
 203         (ada_add_global_exceptions): Use objfile_compunits.
 204
 205 2019-01-09  Tom Tromey  <tom@tromey.com>
 206
 207         * source.c (select_source_symtab)
 208         (forget_cached_source_info_for_objfile): Remove declaration.
 209         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 210         declaration.
 211         * maint.c (count_symtabs_and_blocks): Remove declaration.
 212         * cp-support.c (add_symbol_overload_list_qualified): Remove
 213         declaration.
 214         * coffread.c (coff_symtab_read): Remove declaration.
 215         * symtab.c (lookup_symbol_in_objfile_symtabs)
 216         (basic_lookup_transparent_type_1): Use objfile_compunits.
 217         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 218         (info_sources_command, search_symbols)
 219         (default_collect_symbol_completion_matches_break_on)
 220         (make_source_files_completion_list): Remove declaration.
 221         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 222         (ada_collect_symbol_completion_matches)
 223         (ada_add_global_exceptions): Remove declaration.
 224         * linespec.c (iterate_over_all_matching_symtabs): Use
 225         objfile_compunits.
 226         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 227         (class objfile_compunits): New.
 228         (ALL_COMPUNITS): Use objfile_compunits.
 229         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 230         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 231         objfile_compunits.
 232         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 233
 234 2019-01-09  Tom Tromey  <tom@tromey.com>
 235
 236         * symtab.c (search_symbols)
 237         (default_collect_symbol_completion_matches_break_on): Use
 238         objfile_msymbols.
 239         * ada-lang.c (ada_lookup_simple_minsym)
 240         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 241         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 242         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 243         objfile_msymbols.
 244         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 245         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 246         * objc-lang.c (find_methods): Use objfile_msymbols.
 247         (info_selectors_command, info_classes_command): Likewise.
 248         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 249         * objfiles.h (class objfile_msymbols): New.
 250         (ALL_OBJFILE_MSYMBOLS): Remove.
 251         (ALL_MSYMBOLS): Remove.
 252
 253 2019-01-09  Tom Tromey  <tom@tromey.com>
 254
 255         * common/next-iterator.h (next_adapter): Add Iterator template
 256         parameter.
 257         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 258         (class all_objfiles_safe): New.
 259         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 260         * objfiles.c (put_objfile_before): Update comment.
 261         (add_separate_debug_objfile): Likewise.
 262         (free_all_objfiles): Use all_objfiles_safe.
 263         (objfile_purge_solibs): Likewise.
 264
 265 2019-01-09  Tom Tromey  <tom@tromey.com>
 266
 267         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 268         (expand_symtab_containing_pc, lookup_static_symbol)
 269         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 270         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 271         all_objfiles.
 272         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 273         * breakpoint.c (create_overlay_event_breakpoint)
 274         (create_longjmp_master_breakpoint)
 275         (create_std_terminate_master_breakpoint)
 276         (create_exception_master_breakpoint): Use all_objfiles.
 277         * linux-thread-db.c (try_thread_db_load_from_pdir)
 278         (has_libpthread): Use all_objfiles.
 279         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 280         * linespec.c (iterate_over_all_matching_symtabs)
 281         (search_minsyms_for_name): Use all_objfiles.
 282         * maint.c (maintenance_info_sections): Use all_objfiles.
 283         * main.c (captured_main_1): Use all_objfiles.
 284         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 285         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 286         * guile/scm-pretty-print.c
 287         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 288         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 289         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 290         (maintenance_print_msymbols): Use all_objfiles.
 291         * source.c (select_source_symtab): Use all_objfiles.
 292         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 293         * symfile.c (remove_symbol_file_command)
 294         (expand_symtabs_matching, map_symbol_filenames): Use
 295         all_objfiles.
 296         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 297         all_objfiles.
 298         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 299         * objc-lang.c (find_methods): Use all_objfiles.
 300         * objfiles.c (have_partial_symbols, have_full_symbols)
 301         (have_minimal_symbols, qsort_cmp)
 302         (default_iterate_over_objfiles_in_search_order): Use
 303         all_objfiles.
 304         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 305         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 306         (maintenance_check_psymtabs): Use all_objfiles.
 307         (ALL_PSYMTABS): Remove.
 308         * compile/compile-object-run.c (do_module_cleanup): Use
 309         all_objfiles.
 310         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 311         * cp-support.c (add_symbol_overload_list_qualified): Use
 312         all_objfiles.
 313         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 314         Use all_objfiles.
 315         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 316         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 317         all_objfiles.
 318         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 319         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 320         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 321         Uses all_objfiles.
 322         * solib.c (solib_read_symbols): Use all_objfiles
 323
 324 2019-01-09  Tom Tromey  <tom@tromey.com>
 325
 326         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 327         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 328         all_objfiles.
 329         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 330         * symmisc.c (print_symbol_bcache_statistics)
 331         (print_objfile_statistics, maintenance_print_objfiles)
 332         (maintenance_info_symtabs, maintenance_check_symtabs)
 333         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 334         all_objfiles.
 335         * source.c (forget_cached_source_info): Use all_objfiles.
 336         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 337         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 338         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 339         * objfiles.c (update_section_map): Use all_objfiles.
 340         (shared_objfile_contains_address_p): Likewise.
 341         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 342         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 343
 344 2019-01-09  Tom Tromey  <tom@tromey.com>
 345
 346         * common/next-iterator.h: New file.
 347         * objfiles.h (class all_objfiles): New.
 348         (struct objfile_iterator): New.
 349
 350 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 351
 352         * NEWS: Move the description of the changed "frame", "select-frame",
 353          and "info frame" commands to the Changed commands section.
 354
 355 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 356
 357         * gdbtypes.c (check_stub_method_group): Remove handling of old
 358         mangling schemes.
 359         * linespec.c (find_methods): Likewise.
 360         * stabsread.c (read_member_functions): Likewise.
 361         * valops.c (search_struct_method): Likewise.
 362         (value_struct_elt_for_reference): Likewise.
 363         * NEWS: Mention this change.
 364
 365 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 366
 367         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 368         print_source_lines.
 369         * source.c (print_source_lines_base): Update line number check.
 370         (print_source_lines): New function.
 371         (source_lines_range::source_lines_range): New function.
 372         * source.h (class source_lines_range): New class.
 373         (print_source_lines): New declaration.
 374
 375 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 376
 377         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 378
 379 2019-01-08  Tom Tromey  <tom@tromey.com>
 380             Simon Marchi  <simon.marchi@ericsson.com>
 381
 382         PR gdb/24060
 383         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 384         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 385         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 386         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 387         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 388         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 389
 390 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 391
 392         * source.c (select_source_symtab): Move header comment to
 393         declaration in source.h.
 394         (forget_cached_source_info_for_objfile): Likewise.
 395         (forget_cached_source_info): Likewise.
 396         (identify_source_line): Likewise.
 397         * source.h (identify_source_line): Move declaration from symtab.h
 398         and add comment from source.c
 399         (print_source_lines): Likewise.
 400         (forget_cached_source_info_for_objfile): Likewise.
 401         (forget_cached_source_info): Likewise.
 402         (select_source_symtab): Likewise.
 403         (enum print_source_lines_flag): Move definition from symtab.h.
 404         * symtab.h (identify_source_line): Move declaration to source.h.
 405         (print_source_lines): Likewise.
 406         (forget_cached_source_info_for_objfile): Likewise.
 407         (forget_cached_source_info): Likewise.
 408         (select_source_symtab): Likewise.
 409         (enum print_source_lines_flag): Move definition to source.h.
 410         * tui/tui-hooks.c: Add 'source.h' include.
 411
 412 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 413
 414         * source.c (print_source_lines_base): Handle requests to print
 415         reverse line number sequences, and guard against empty lines
 416         string.
 417
 418 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 419
 420         * source.c (print_source_lines_base): Fix skip of '\r' if next
 421         character is '\n'.
 422
 423 2019-01-06  Tom Tromey  <tom@tromey.com>
 424
 425         * c-exp.y (struct c_parse_state) <macro_original_text,
 426         expansion_obstack>: New member.
 427         (macro_original_text, expansion_obstack): Remove globals.
 428         (scan_macro_expansion, scanning_macro_expansion)
 429         (finished_macro_expansion): Update.
 430         (scan_macro_cleanup): Remove.
 431         (yylex, c_parse): Update.
 432
 433 2019-01-06  Tom Tromey  <tom@tromey.com>
 434
 435         * c-exp.y (struct c_parse_state) <strings>: New member.
 436         (operator_stoken): Update.
 437
 438 2019-01-06  Tom Tromey  <tom@tromey.com>
 439
 440         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 441         (union type_stack_elt) <typelist_val>: Now a pointer to
 442         std::vector.
 443         (type_stack_cleanup): Don't declare.
 444         (push_typelist): Update.
 445         * parse.c (pop_typelist): Return a std::vector.
 446         (push_typelist): Take a std::vector.
 447         (follow_types): Update.  Do not free args.
 448         (type_stack_cleanup): Remove.
 449         * c-exp.y (struct c_parse_state): New.
 450         (cpstate): New global.
 451         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 452         (nonempty_typelist): Update.
 453         (func_mod): Create a new vector.
 454         (c_parse): Create a c_parse_state.
 455         (check_parameter_typelist): Do not delete params.
 456         (function_method): Update.  Do not delete type_list.
 457
 458 2019-01-06  Tom Tromey  <tom@tromey.com>
 459
 460         PR gdb/28155:
 461         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 462         check_typedef.
 463         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 464         (print_return_value): Likewise.
 465
 466 2019-01-05  Tom Tromey  <tom@tromey.com>
 467
 468         * contrib/cleanup_check.py: Remove.
 469         * contrib/gcc-with-excheck: Remove.
 470         * contrib/exsummary.py: Remove.
 471         * contrib/excheck.py: Remove.
 472
 473 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 474
 475         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 476         NULL. Initialize tpprev to NULL instead of assigning it
 477         to NULL on the next statement.
 478         * windows-nat.c (windows_delete_thread): Remove check for
 479         main_thread_id before printing thread exit notifications.
 480         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 481         Remove thread ID check against main_thread_id.
 482         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 483         windows_delete_thread.
 484         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 485
 486 2019-01-04  Tom Tromey  <tom@tromey.com>
 487
 488         * compile/compile.c (_initialize_compile): Use upper case for
 489         metasyntactic variables.
 490         * symmisc.c (_initialize_symmisc): Use upper case for
 491         metasyntactic variables.
 492         * psymtab.c (_initialize_psymtab): Use upper case for
 493         metasyntactic variables.
 494         * demangle.c (demangle_command): Use upper case for metasyntactic
 495         variables.
 496         (_initialize_demangler): Likewise.
 497         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 498         variables.
 499
 500 2019-01-03  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 503
 504 2019-01-03  Tom Tromey  <tom@tromey.com>
 505
 506         * python/py-symtab.c (salpy_str): Update.
 507         (struct salpy_sal_object) <symtab>: Now a PyObject.
 508         (salpy_dealloc): Update.
 509         (del_objfile_sal): Use gdbpy_ref.
 510
 511 2019-01-03  Tom Tromey  <tom@tromey.com>
 512
 513         * python/py-type.c (convert_field): Use new_reference.  Return
 514         gdbpy_ref.
 515         (make_fielditem): Return gdbpy_ref.
 516         (typy_fields): Update.
 517         (typy_getitem): Update.
 518         (field_name): Return gdbpy_ref.  Use new_reference.
 519         (typy_iterator_iternext): Update.
 520
 521 2019-01-03  Tom Tromey  <tom@tromey.com>
 522
 523         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 524
 525 2019-01-03  Tom Tromey  <tom@tromey.com>
 526
 527         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 528         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 529         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 530         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 531         (pspy_set_type_printers): Likewise.
 532         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 533         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 534         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 535         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 536         (objfpy_set_type_printers): Likewise.
 537
 538 2019-01-03  Tom Tromey  <tom@tromey.com>
 539
 540         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
 541         (gdbpy_print_stack): Use gdbpy_err_fetch.
 542         * python/python-internal.h (class gdbpy_err_fetch): New class.
 543         (class gdbpy_enter) <m_error_type, m_error_value,
 544         m_error_traceback>: Remove.
 545         <m_error>: New member.
 546         (gdbpy_exception_to_string): Don't declare.
 547         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
 548         * python/py-value.c (convert_value_from_python): Use
 549         gdbpy_err_fetch.
 550         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
 551         gdbpy_exception_to_string.
 552         (gdbpy_handle_exception): Use gdbpy_err_fetch.
 553         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 554         gdbpy_err_fetch.
 555
 556 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 557
 558         * linux-nat.c (delete_lwp_cleanup): Delete.
 559         (struct lwp_deleter): New struct.
 560         (lwp_info_up): New typedef.
 561         (linux_nat_target::follow_fork): Delete cleanup, and make use of
 562         lwp_info_up.
 563
 564 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 565
 566         * linux-fork.c (class scoped_switch_fork_info): New class.
 567         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
 568
 569 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 570
 571         * valops.c (find_overload_match): Remove use of null_cleanup, and
 572         calls to do_cleanups.
 573
 574 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 575
 576         * compile/compile-cplus-types.c
 577         (compile_cplus_instance::decl_name): Handle changes to
 578         cp_func_name.
 579         * cp-support.c (cp_func_name): Update header comment, update
 580         return type.
 581         * cp-support.h (cp_func_name): Update return type in declaration.
 582         * valops.c (find_overload_match): Move temp_func local to top
 583         level of function and change its type.  Use temp_func to hold and
 584         delete temporary string obtained from cp_func_name.
 585
 586 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 587
 588         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
 589         gdb::char_vector, remove cleanup, and update uses of `msg`.
 590
 591 2019-01-03  Jim Wilson  <jimw@sifive.com>
 592
 593         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
 594
 595 2019-01-02  Tom Tromey  <tom@tromey.com>
 596
 597         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
 598         (tdesc_parse_xml): Remove cleanups.
 599         * target-descriptions.h (make_cleanup_free_target_description):
 600         Don't declare.
 601         (target_desc_deleter): New struct.
 602         (target_desc_up): New typedef.
 603         * target-descriptions.c (target_desc_deleter::operator()): Rename
 604         from free_target_description.
 605         (make_cleanup_free_target_description): Remove.
 606
 607 2019-01-02  Tom Tromey  <tom@tromey.com>
 608
 609         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
 610         constructor, destructor.
 611         (linespec_parser): Remove typedef.
 612         (~linespec_parser): Rename from linespec_parser_delete.
 613         (linespec_lex_to_end, linespec_complete_label)
 614         (linespec_complete): Update.
 615         (decode_line_full): Remove cleanups.
 616         (decode_line_1): Update.
 617
 618 2019-01-02  Tom Tromey  <tom@tromey.com>
 619
 620         * python/python-internal.h (inferior_to_inferior_object): Change
 621         return type.
 622         * python/py-exitedevent.c (create_exited_event_object): Update.
 623         * python/py-inferior.c (inferior_to_inferior_object): Return
 624         gdbpy_ref.
 625         (python_new_inferior, python_inferior_deleted)
 626         (thread_to_thread_object, delete_thread_object)
 627         (build_inferior_list, gdbpy_selected_inferior): Update.
 628         * python/py-infthread.c (create_thread_object): Update.  Also fail
 629         if inferior_to_inferior_object fails.
 630
 631 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
 632
 633         * inferior.h (class inferior) <displaced_step_state>: New field.
 634         * infrun.h (struct displaced_step_state): Move here from
 635         infrun.c.  Initialize fields, add constructor.
 636         <inf>: Remove field.
 637         <reset>: New method.
 638         * infrun.c (struct displaced_step_inferior_state): Move to
 639         infrun.h.
 640         (displaced_step_inferior_states): Remove.
 641         (get_displaced_stepping_state): Adust.
 642         (displaced_step_in_progress_any_inferior): Adjust.
 643         (displaced_step_in_progress_thread): Adjust.
 644         (displaced_step_in_progress): Adjust.
 645         (add_displaced_stepping_state): Remove.
 646         (get_displaced_step_closure_by_addr): Adjust.
 647         (remove_displaced_stepping_state): Remove.
 648         (infrun_inferior_exit): Call displaced_step_state.reset.
 649         (use_displaced_stepping): Don't check for NULL.
 650         (displaced_step_prepare_throw): Call
 651         get_displaced_stepping_state.
 652         (displaced_step_fixup): Don't check for NULL.
 653         (prepare_for_detach): Don't check for NULL.
 654
 655 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 656
 657         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
 658          in case of call that did not complete.
 659
 660 2019-01-02  Andrey Utkin  <autkin@undo.io>
 661
 662         * symfile.c (find_separate_debug_file): Fix search of debug files for
 663         remote debuggee.
 664
 665 2019-01-02  Tom Tromey  <tom@tromey.com>
 666
 667         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
 668         indentation.
 669         * python/py-frame.c (frapy_older): Remove cast.
 670         (frapy_newer): Likewise.
 671         * python/py-breakpoint.c (local_setattro): Remove cast.
 672         * python/py-arch.c (archpy_name): Remove local variable.
 673         * python/py-type.c (gdbpy_lookup_type): Remove cast.
 674
 675 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
 676
 677         * unittests/basic_string_view/element_access/char/empty.cc:
 678         Fix year range in copyright header.
 679
 680 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 681
 682         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
 683         Delete.
 684         <operator==>: Update with for removed field.
 685         <hash>: Likewise.
 686         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
 687         <isa_features>: ...this.
 688         <abi_features>: New field.
 689         (riscv_isa_flen): Update comment.
 690         (riscv_abi_xlen): New declaration.
 691         (riscv_abi_flen): New declaration.
 692         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
 693         isa_features.
 694         (riscv_abi_xlen): New function.
 695         (riscv_isa_flen): Update to get answer from isa_features.
 696         (riscv_abi_flen): New function.
 697         (riscv_has_fp_abi): Update to get answer from abi_features.
 698         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
 699         xlen and flen.
 700         (riscv_call_info) <xlen, flen>: Update comment.
 701         (riscv_call_arg_struct): Remove invalid assertions
 702         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
 703         is removed.
 704         (riscv_gdbarch_init): Gather isa features and abi features
 705         separately, ensure both match on the gdbarch when reusing an old
 706         gdbarch.  Relax an error check to allow 32-bit abi float to run on
 707         a target with 64-bit float hardware.
 708
 709 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 710
 711         * source.c (search_command_helper): Stop reverse search
 712         when line 1 has been searched.
 713
 714 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 715
 716         * record-full.c (record_full_base_target::close): Rewrite
 717         record_full_core_buf_list free logic.
 718
 719 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 720
 721         * break-catch-syscall.c (print_one_catch_syscall): xfree
 722         the last text.
 723
 724 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 725
 726         * top.c (print_gdb_version): Update Copyright year in version
 727         message.
 728
 729 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 730
 731         Update copyright year range in all GDB files.
 732
 733 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 734
 735         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
 736
 737 For older changes see ChangeLog-2018.
 738 \f
 739 Local Variables:
 740 mode: change-log
 741 left-margin: 8
 742 fill-column: 74
 743 version-control: never
 744 coding: utf-8
 745 End:
 746