Remove some now-dead exception code
[external/binutils.git] / gdb / ChangeLog
1 2019-04-08  Tom Tromey  <tom@tromey.com>
2
3         * common/common-exceptions.h (exception_rethrow): Don't declare.
4         (TRY_SJLJ): Update comment.
5         (TRY, CATCH, END_CATCH): Remove.
6         * common/common-exceptions.c (exception_rethrow): Remove.
7
8 2019-04-08  Tom Tromey  <tom@tromey.com>
9
10         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11         Remove.
12         (gdb_exception_error): Rename from
13         gdb_exception_RETURN_MASK_ERROR.
14         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
15         (gdb_quit_bad_alloc): Update.
16         * aarch64-tdep.c: Update.
17         * ada-lang.c: Update.
18         * ada-typeprint.c: Update.
19         * ada-valprint.c: Update.
20         * amd64-tdep.c: Update.
21         * arch-utils.c: Update.
22         * break-catch-throw.c: Update.
23         * breakpoint.c: Update.
24         * btrace.c: Update.
25         * c-varobj.c: Update.
26         * cli/cli-cmds.c: Update.
27         * cli/cli-interp.c: Update.
28         * cli/cli-script.c: Update.
29         * common/common-exceptions.c: Update.
30         * common/new-op.c: Update.
31         * common/selftest.c: Update.
32         * compile/compile-c-symbols.c: Update.
33         * compile/compile-cplus-symbols.c: Update.
34         * compile/compile-object-load.c: Update.
35         * compile/compile-object-run.c: Update.
36         * completer.c: Update.
37         * corelow.c: Update.
38         * cp-abi.c: Update.
39         * cp-support.c: Update.
40         * cp-valprint.c: Update.
41         * darwin-nat.c: Update.
42         * disasm-selftests.c: Update.
43         * dtrace-probe.c: Update.
44         * dwarf-index-cache.c: Update.
45         * dwarf-index-write.c: Update.
46         * dwarf2-frame-tailcall.c: Update.
47         * dwarf2-frame.c: Update.
48         * dwarf2loc.c: Update.
49         * dwarf2read.c: Update.
50         * eval.c: Update.
51         * event-loop.c: Update.
52         * event-top.c: Update.
53         * exec.c: Update.
54         * f-valprint.c: Update.
55         * fbsd-tdep.c: Update.
56         * frame-unwind.c: Update.
57         * frame.c: Update.
58         * gdbtypes.c: Update.
59         * gnu-v3-abi.c: Update.
60         * guile/guile-internal.h: Update.
61         * guile/scm-block.c: Update.
62         * guile/scm-breakpoint.c: Update.
63         * guile/scm-cmd.c: Update.
64         * guile/scm-disasm.c: Update.
65         * guile/scm-frame.c: Update.
66         * guile/scm-lazy-string.c: Update.
67         * guile/scm-math.c: Update.
68         * guile/scm-param.c: Update.
69         * guile/scm-ports.c: Update.
70         * guile/scm-pretty-print.c: Update.
71         * guile/scm-symbol.c: Update.
72         * guile/scm-symtab.c: Update.
73         * guile/scm-type.c: Update.
74         * guile/scm-value.c: Update.
75         * i386-linux-tdep.c: Update.
76         * i386-tdep.c: Update.
77         * inf-loop.c: Update.
78         * infcall.c: Update.
79         * infcmd.c: Update.
80         * infrun.c: Update.
81         * jit.c: Update.
82         * language.c: Update.
83         * linespec.c: Update.
84         * linux-fork.c: Update.
85         * linux-nat.c: Update.
86         * linux-tdep.c: Update.
87         * linux-thread-db.c: Update.
88         * main.c: Update.
89         * mi/mi-cmd-break.c: Update.
90         * mi/mi-cmd-stack.c: Update.
91         * mi/mi-interp.c: Update.
92         * mi/mi-main.c: Update.
93         * objc-lang.c: Update.
94         * p-valprint.c: Update.
95         * parse.c: Update.
96         * ppc-linux-tdep.c: Update.
97         * printcmd.c: Update.
98         * python/py-arch.c: Update.
99         * python/py-breakpoint.c: Update.
100         * python/py-cmd.c: Update.
101         * python/py-finishbreakpoint.c: Update.
102         * python/py-frame.c: Update.
103         * python/py-framefilter.c: Update.
104         * python/py-gdb-readline.c: Update.
105         * python/py-inferior.c: Update.
106         * python/py-infthread.c: Update.
107         * python/py-lazy-string.c: Update.
108         * python/py-linetable.c: Update.
109         * python/py-objfile.c: Update.
110         * python/py-param.c: Update.
111         * python/py-prettyprint.c: Update.
112         * python/py-progspace.c: Update.
113         * python/py-record-btrace.c: Update.
114         * python/py-record.c: Update.
115         * python/py-symbol.c: Update.
116         * python/py-type.c: Update.
117         * python/py-unwind.c: Update.
118         * python/py-utils.c: Update.
119         * python/py-value.c: Update.
120         * python/python.c: Update.
121         * record-btrace.c: Update.
122         * record-full.c: Update.
123         * remote-fileio.c: Update.
124         * remote.c: Update.
125         * riscv-tdep.c: Update.
126         * rs6000-aix-tdep.c: Update.
127         * rs6000-tdep.c: Update.
128         * rust-exp.y: Update.
129         * rust-lang.c: Update.
130         * s390-tdep.c: Update.
131         * selftest-arch.c: Update.
132         * solib-dsbt.c: Update.
133         * solib-frv.c: Update.
134         * solib-spu.c: Update.
135         * solib-svr4.c: Update.
136         * solib.c: Update.
137         * sparc64-linux-tdep.c: Update.
138         * stack.c: Update.
139         * symfile-mem.c: Update.
140         * symmisc.c: Update.
141         * target.c: Update.
142         * thread.c: Update.
143         * top.c: Update.
144         * tracefile-tfile.c: Update.
145         * tui/tui.c: Update.
146         * typeprint.c: Update.
147         * unittests/cli-utils-selftests.c: Update.
148         * unittests/parse-connection-spec-selftests.c: Update.
149         * valops.c: Update.
150         * valprint.c: Update.
151         * value.c: Update.
152         * varobj.c: Update.
153         * windows-nat.c: Update.
154         * x86-linux-nat.c: Update.
155         * xml-support.c: Update.
156
157 2019-04-08  Tom Tromey  <tom@tromey.com>
158
159         * xml-support.c: Use C++ exception handling.
160         * x86-linux-nat.c: Use C++ exception handling.
161         * windows-nat.c: Use C++ exception handling.
162         * varobj.c: Use C++ exception handling.
163         * value.c: Use C++ exception handling.
164         * valprint.c: Use C++ exception handling.
165         * valops.c: Use C++ exception handling.
166         * unittests/parse-connection-spec-selftests.c: Use C++ exception
167         handling.
168         * unittests/cli-utils-selftests.c: Use C++ exception handling.
169         * typeprint.c: Use C++ exception handling.
170         * tui/tui.c: Use C++ exception handling.
171         * tracefile-tfile.c: Use C++ exception handling.
172         * top.c: Use C++ exception handling.
173         * thread.c: Use C++ exception handling.
174         * target.c: Use C++ exception handling.
175         * symmisc.c: Use C++ exception handling.
176         * symfile-mem.c: Use C++ exception handling.
177         * stack.c: Use C++ exception handling.
178         * sparc64-linux-tdep.c: Use C++ exception handling.
179         * solib.c: Use C++ exception handling.
180         * solib-svr4.c: Use C++ exception handling.
181         * solib-spu.c: Use C++ exception handling.
182         * solib-frv.c: Use C++ exception handling.
183         * solib-dsbt.c: Use C++ exception handling.
184         * selftest-arch.c: Use C++ exception handling.
185         * s390-tdep.c: Use C++ exception handling.
186         * rust-lang.c: Use C++ exception handling.
187         * rust-exp.y: Use C++ exception handling.
188         * rs6000-tdep.c: Use C++ exception handling.
189         * rs6000-aix-tdep.c: Use C++ exception handling.
190         * riscv-tdep.c: Use C++ exception handling.
191         * remote.c: Use C++ exception handling.
192         * remote-fileio.c: Use C++ exception handling.
193         * record-full.c: Use C++ exception handling.
194         * record-btrace.c: Use C++ exception handling.
195         * python/python.c: Use C++ exception handling.
196         * python/py-value.c: Use C++ exception handling.
197         * python/py-utils.c: Use C++ exception handling.
198         * python/py-unwind.c: Use C++ exception handling.
199         * python/py-type.c: Use C++ exception handling.
200         * python/py-symbol.c: Use C++ exception handling.
201         * python/py-record.c: Use C++ exception handling.
202         * python/py-record-btrace.c: Use C++ exception handling.
203         * python/py-progspace.c: Use C++ exception handling.
204         * python/py-prettyprint.c: Use C++ exception handling.
205         * python/py-param.c: Use C++ exception handling.
206         * python/py-objfile.c: Use C++ exception handling.
207         * python/py-linetable.c: Use C++ exception handling.
208         * python/py-lazy-string.c: Use C++ exception handling.
209         * python/py-infthread.c: Use C++ exception handling.
210         * python/py-inferior.c: Use C++ exception handling.
211         * python/py-gdb-readline.c: Use C++ exception handling.
212         * python/py-framefilter.c: Use C++ exception handling.
213         * python/py-frame.c: Use C++ exception handling.
214         * python/py-finishbreakpoint.c: Use C++ exception handling.
215         * python/py-cmd.c: Use C++ exception handling.
216         * python/py-breakpoint.c: Use C++ exception handling.
217         * python/py-arch.c: Use C++ exception handling.
218         * printcmd.c: Use C++ exception handling.
219         * ppc-linux-tdep.c: Use C++ exception handling.
220         * parse.c: Use C++ exception handling.
221         * p-valprint.c: Use C++ exception handling.
222         * objc-lang.c: Use C++ exception handling.
223         * mi/mi-main.c: Use C++ exception handling.
224         * mi/mi-interp.c: Use C++ exception handling.
225         * mi/mi-cmd-stack.c: Use C++ exception handling.
226         * mi/mi-cmd-break.c: Use C++ exception handling.
227         * main.c: Use C++ exception handling.
228         * linux-thread-db.c: Use C++ exception handling.
229         * linux-tdep.c: Use C++ exception handling.
230         * linux-nat.c: Use C++ exception handling.
231         * linux-fork.c: Use C++ exception handling.
232         * linespec.c: Use C++ exception handling.
233         * language.c: Use C++ exception handling.
234         * jit.c: Use C++ exception handling.
235         * infrun.c: Use C++ exception handling.
236         * infcmd.c: Use C++ exception handling.
237         * infcall.c: Use C++ exception handling.
238         * inf-loop.c: Use C++ exception handling.
239         * i386-tdep.c: Use C++ exception handling.
240         * i386-linux-tdep.c: Use C++ exception handling.
241         * guile/scm-value.c: Use C++ exception handling.
242         * guile/scm-type.c: Use C++ exception handling.
243         * guile/scm-symtab.c: Use C++ exception handling.
244         * guile/scm-symbol.c: Use C++ exception handling.
245         * guile/scm-pretty-print.c: Use C++ exception handling.
246         * guile/scm-ports.c: Use C++ exception handling.
247         * guile/scm-param.c: Use C++ exception handling.
248         * guile/scm-math.c: Use C++ exception handling.
249         * guile/scm-lazy-string.c: Use C++ exception handling.
250         * guile/scm-frame.c: Use C++ exception handling.
251         * guile/scm-disasm.c: Use C++ exception handling.
252         * guile/scm-cmd.c: Use C++ exception handling.
253         * guile/scm-breakpoint.c: Use C++ exception handling.
254         * guile/scm-block.c: Use C++ exception handling.
255         * guile/guile-internal.h: Use C++ exception handling.
256         * gnu-v3-abi.c: Use C++ exception handling.
257         * gdbtypes.c: Use C++ exception handling.
258         * frame.c: Use C++ exception handling.
259         * frame-unwind.c: Use C++ exception handling.
260         * fbsd-tdep.c: Use C++ exception handling.
261         * f-valprint.c: Use C++ exception handling.
262         * exec.c: Use C++ exception handling.
263         * event-top.c: Use C++ exception handling.
264         * event-loop.c: Use C++ exception handling.
265         * eval.c: Use C++ exception handling.
266         * dwarf2read.c: Use C++ exception handling.
267         * dwarf2loc.c: Use C++ exception handling.
268         * dwarf2-frame.c: Use C++ exception handling.
269         * dwarf2-frame-tailcall.c: Use C++ exception handling.
270         * dwarf-index-write.c: Use C++ exception handling.
271         * dwarf-index-cache.c: Use C++ exception handling.
272         * dtrace-probe.c: Use C++ exception handling.
273         * disasm-selftests.c: Use C++ exception handling.
274         * darwin-nat.c: Use C++ exception handling.
275         * cp-valprint.c: Use C++ exception handling.
276         * cp-support.c: Use C++ exception handling.
277         * cp-abi.c: Use C++ exception handling.
278         * corelow.c: Use C++ exception handling.
279         * completer.c: Use C++ exception handling.
280         * compile/compile-object-run.c: Use C++ exception handling.
281         * compile/compile-object-load.c: Use C++ exception handling.
282         * compile/compile-cplus-symbols.c: Use C++ exception handling.
283         * compile/compile-c-symbols.c: Use C++ exception handling.
284         * common/selftest.c: Use C++ exception handling.
285         * common/new-op.c: Use C++ exception handling.
286         * cli/cli-script.c: Use C++ exception handling.
287         * cli/cli-interp.c: Use C++ exception handling.
288         * cli/cli-cmds.c: Use C++ exception handling.
289         * c-varobj.c: Use C++ exception handling.
290         * btrace.c: Use C++ exception handling.
291         * breakpoint.c: Use C++ exception handling.
292         * break-catch-throw.c: Use C++ exception handling.
293         * arch-utils.c: Use C++ exception handling.
294         * amd64-tdep.c: Use C++ exception handling.
295         * ada-valprint.c: Use C++ exception handling.
296         * ada-typeprint.c: Use C++ exception handling.
297         * ada-lang.c: Use C++ exception handling.
298         * aarch64-tdep.c: Use C++ exception handling.
299
300 2019-04-08  Tom Tromey  <tom@tromey.com>
301
302         * xml-support.c (gdb_xml_parser::parse): Update.
303         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
304         * value.c (show_convenience): Update.
305         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
306         (test_parse_flags_qcs): Update.
307         * thread.c (thr_try_catch_cmd): Update.
308         * target.c (target_translate_tls_address): Update.
309         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
310         (info_frame_command_core, frame_apply_command_count): Update.
311         * rust-exp.y (rust_lex_exception_test): Update.
312         * riscv-tdep.c (riscv_print_one_register_info): Update.
313         * remote.c (remote_target::enable_btrace): Update.
314         * record-btrace.c (record_btrace_enable_warn): Update.
315         * python/py-utils.c (gdbpy_convert_exception): Update.
316         * printcmd.c (do_one_display, print_variable_and_value): Update.
317         * mi/mi-main.c (mi_print_exception): Update.
318         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
319         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
320         * linux-nat.c (linux_nat_target::attach): Update.
321         * linux-fork.c (class scoped_switch_fork_info): Update.
322         * infrun.c (displaced_step_prepare): Update.
323         * infcall.c (call_function_by_hand_dummy): Update.
324         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
325         * gnu-v3-abi.c (print_one_vtable): Update.
326         * frame.c (get_prev_frame_always): Update.
327         * f-valprint.c (info_common_command_for_block): Update.
328         * exec.c (try_open_exec_file): Update.
329         * exceptions.c (print_exception, exception_print)
330         (exception_fprintf, exception_print_same): Update.
331         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
332         * dwarf-index-cache.c (index_cache::store)
333         (index_cache::lookup_gdb_index): Update.
334         * darwin-nat.c (maybe_cache_shell): Update.
335         * cp-valprint.c (cp_print_value_fields): Update.
336         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
337         (gcc_cplus_symbol_address): Update.
338         * compile/compile-c-symbols.c (gcc_convert_symbol)
339         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
340         * common/selftest.c: Update.
341         * common/common-exceptions.h (struct gdb_exception) <message>: Now
342         a std::string.
343         (exception_try_scope_entry, exception_try_scope_exit): Don't
344         declare.
345         (struct exception_try_scope): Remove.
346         (TRY): Don't use exception_try_scope.
347         (struct gdb_exception): Add constructor, operator=.
348         <what>: New method.
349         (struct gdb_exception_RETURN_MASK_ALL)
350         (struct gdb_exception_RETURN_MASK_ERROR)
351         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
352         (struct gdb_quit_bad_alloc): Update.
353         * common/common-exceptions.c (exception_none): Change
354         initializer.
355         (struct catcher) <state, exception>: Initialize inline.
356         <prev>: Remove member.
357         (current_catcher): Remove.
358         (catchers): New global.
359         (exceptions_state_mc_init): Simplify.
360         (catcher_pop): Remove.
361         (exceptions_state_mc, exceptions_state_mc_catch): Update.
362         (try_scope_depth, exception_try_scope_entry)
363         (exception_try_scope_exit): Remove.
364         (throw_exception_sjlj): Update.
365         (exception_messages, exception_messages_size): Remove.
366         (throw_it): Simplify.
367         (gdb_exception_sliced_copy): Remove.
368         (throw_exception_cxx): Update.
369         * cli/cli-script.c (script_from_file): Update.
370         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
371         Update.
372         * ada-valprint.c (ada_val_print): Update.
373         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
374         (create_excep_cond_exprs): Update.
375
376 2019-04-08  Tom Tromey  <tom@tromey.com>
377
378         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
379         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
380         (TRY, CATCH, END_CATCH): Remove some definitions.
381         * common/common-exceptions.c: Don't use GDB_XCPT.
382         (catcher_list_size): Remove.
383         (throw_exception, throw_it): Simplify.
384
385 2019-04-05  Tom Tromey  <tom@tromey.com>
386
387         Revert the header-sorting patch.
388         * ft32-tdep.c: Revert.
389         * frv-tdep.c: Revert.
390         * frv-linux-tdep.c: Revert.
391         * frame.c: Revert.
392         * frame-unwind.c: Revert.
393         * frame-base.c: Revert.
394         * fork-child.c: Revert.
395         * findvar.c: Revert.
396         * findcmd.c: Revert.
397         * filesystem.c: Revert.
398         * filename-seen-cache.h: Revert.
399         * filename-seen-cache.c: Revert.
400         * fbsd-tdep.c: Revert.
401         * fbsd-nat.h: Revert.
402         * fbsd-nat.c: Revert.
403         * f-valprint.c: Revert.
404         * f-typeprint.c: Revert.
405         * f-lang.c: Revert.
406         * extension.h: Revert.
407         * extension.c: Revert.
408         * extension-priv.h: Revert.
409         * expprint.c: Revert.
410         * exec.h: Revert.
411         * exec.c: Revert.
412         * exceptions.c: Revert.
413         * event-top.c: Revert.
414         * event-loop.c: Revert.
415         * eval.c: Revert.
416         * elfread.c: Revert.
417         * dwarf2read.h: Revert.
418         * dwarf2read.c: Revert.
419         * dwarf2loc.c: Revert.
420         * dwarf2expr.h: Revert.
421         * dwarf2expr.c: Revert.
422         * dwarf2-frame.c: Revert.
423         * dwarf2-frame-tailcall.c: Revert.
424         * dwarf-index-write.h: Revert.
425         * dwarf-index-write.c: Revert.
426         * dwarf-index-common.c: Revert.
427         * dwarf-index-cache.h: Revert.
428         * dwarf-index-cache.c: Revert.
429         * dummy-frame.c: Revert.
430         * dtrace-probe.c: Revert.
431         * disasm.h: Revert.
432         * disasm.c: Revert.
433         * disasm-selftests.c: Revert.
434         * dictionary.c: Revert.
435         * dicos-tdep.c: Revert.
436         * demangle.c: Revert.
437         * dcache.h: Revert.
438         * dcache.c: Revert.
439         * darwin-nat.h: Revert.
440         * darwin-nat.c: Revert.
441         * darwin-nat-info.c: Revert.
442         * d-valprint.c: Revert.
443         * d-namespace.c: Revert.
444         * d-lang.c: Revert.
445         * ctf.c: Revert.
446         * csky-tdep.c: Revert.
447         * csky-linux-tdep.c: Revert.
448         * cris-tdep.c: Revert.
449         * cris-linux-tdep.c: Revert.
450         * cp-valprint.c: Revert.
451         * cp-support.c: Revert.
452         * cp-namespace.c: Revert.
453         * cp-abi.c: Revert.
454         * corelow.c: Revert.
455         * corefile.c: Revert.
456         * continuations.c: Revert.
457         * completer.h: Revert.
458         * completer.c: Revert.
459         * complaints.c: Revert.
460         * coffread.c: Revert.
461         * coff-pe-read.c: Revert.
462         * cli-out.h: Revert.
463         * cli-out.c: Revert.
464         * charset.c: Revert.
465         * c-varobj.c: Revert.
466         * c-valprint.c: Revert.
467         * c-typeprint.c: Revert.
468         * c-lang.c: Revert.
469         * buildsym.c: Revert.
470         * buildsym-legacy.c: Revert.
471         * build-id.h: Revert.
472         * build-id.c: Revert.
473         * btrace.c: Revert.
474         * bsd-uthread.c: Revert.
475         * breakpoint.h: Revert.
476         * breakpoint.c: Revert.
477         * break-catch-throw.c: Revert.
478         * break-catch-syscall.c: Revert.
479         * break-catch-sig.c: Revert.
480         * blockframe.c: Revert.
481         * block.c: Revert.
482         * bfin-tdep.c: Revert.
483         * bfin-linux-tdep.c: Revert.
484         * bfd-target.c: Revert.
485         * bcache.c: Revert.
486         * ax-general.c: Revert.
487         * ax-gdb.h: Revert.
488         * ax-gdb.c: Revert.
489         * avr-tdep.c: Revert.
490         * auxv.c: Revert.
491         * auto-load.c: Revert.
492         * arm-wince-tdep.c: Revert.
493         * arm-tdep.c: Revert.
494         * arm-symbian-tdep.c: Revert.
495         * arm-pikeos-tdep.c: Revert.
496         * arm-obsd-tdep.c: Revert.
497         * arm-nbsd-tdep.c: Revert.
498         * arm-nbsd-nat.c: Revert.
499         * arm-linux-tdep.c: Revert.
500         * arm-linux-nat.c: Revert.
501         * arm-fbsd-tdep.c: Revert.
502         * arm-fbsd-nat.c: Revert.
503         * arm-bsd-tdep.c: Revert.
504         * arch-utils.c: Revert.
505         * arc-tdep.c: Revert.
506         * arc-newlib-tdep.c: Revert.
507         * annotate.h: Revert.
508         * annotate.c: Revert.
509         * amd64-windows-tdep.c: Revert.
510         * amd64-windows-nat.c: Revert.
511         * amd64-tdep.c: Revert.
512         * amd64-sol2-tdep.c: Revert.
513         * amd64-obsd-tdep.c: Revert.
514         * amd64-obsd-nat.c: Revert.
515         * amd64-nbsd-tdep.c: Revert.
516         * amd64-nbsd-nat.c: Revert.
517         * amd64-nat.c: Revert.
518         * amd64-linux-tdep.c: Revert.
519         * amd64-linux-nat.c: Revert.
520         * amd64-fbsd-tdep.c: Revert.
521         * amd64-fbsd-nat.c: Revert.
522         * amd64-dicos-tdep.c: Revert.
523         * amd64-darwin-tdep.c: Revert.
524         * amd64-bsd-nat.c: Revert.
525         * alpha-tdep.c: Revert.
526         * alpha-obsd-tdep.c: Revert.
527         * alpha-nbsd-tdep.c: Revert.
528         * alpha-mdebug-tdep.c: Revert.
529         * alpha-linux-tdep.c: Revert.
530         * alpha-linux-nat.c: Revert.
531         * alpha-bsd-tdep.c: Revert.
532         * alpha-bsd-nat.c: Revert.
533         * aix-thread.c: Revert.
534         * agent.c: Revert.
535         * addrmap.c: Revert.
536         * ada-varobj.c: Revert.
537         * ada-valprint.c: Revert.
538         * ada-typeprint.c: Revert.
539         * ada-tasks.c: Revert.
540         * ada-lang.c: Revert.
541         * aarch64-tdep.c: Revert.
542         * aarch64-ravenscar-thread.c: Revert.
543         * aarch64-newlib-tdep.c: Revert.
544         * aarch64-linux-tdep.c: Revert.
545         * aarch64-linux-nat.c: Revert.
546         * aarch64-fbsd-tdep.c: Revert.
547         * aarch64-fbsd-nat.c: Revert.
548         * aarch32-linux-nat.c: Revert.
549
550 2019-04-05  Tom Tromey  <tom@tromey.com>
551
552         * ft32-tdep.c: Sort headers.
553         * frv-tdep.c: Sort headers.
554         * frv-linux-tdep.c: Sort headers.
555         * frame.c: Sort headers.
556         * frame-unwind.c: Sort headers.
557         * frame-base.c: Sort headers.
558         * fork-child.c: Sort headers.
559         * findvar.c: Sort headers.
560         * findcmd.c: Sort headers.
561         * filesystem.c: Sort headers.
562         * filename-seen-cache.h: Sort headers.
563         * filename-seen-cache.c: Sort headers.
564         * fbsd-tdep.c: Sort headers.
565         * fbsd-nat.h: Sort headers.
566         * fbsd-nat.c: Sort headers.
567         * f-valprint.c: Sort headers.
568         * f-typeprint.c: Sort headers.
569         * f-lang.c: Sort headers.
570         * extension.h: Sort headers.
571         * extension.c: Sort headers.
572         * extension-priv.h: Sort headers.
573         * expprint.c: Sort headers.
574         * exec.h: Sort headers.
575         * exec.c: Sort headers.
576         * exceptions.c: Sort headers.
577         * event-top.c: Sort headers.
578         * event-loop.c: Sort headers.
579         * eval.c: Sort headers.
580         * elfread.c: Sort headers.
581         * dwarf2read.h: Sort headers.
582         * dwarf2read.c: Sort headers.
583         * dwarf2loc.c: Sort headers.
584         * dwarf2expr.h: Sort headers.
585         * dwarf2expr.c: Sort headers.
586         * dwarf2-frame.c: Sort headers.
587         * dwarf2-frame-tailcall.c: Sort headers.
588         * dwarf-index-write.h: Sort headers.
589         * dwarf-index-write.c: Sort headers.
590         * dwarf-index-common.c: Sort headers.
591         * dwarf-index-cache.h: Sort headers.
592         * dwarf-index-cache.c: Sort headers.
593         * dummy-frame.c: Sort headers.
594         * dtrace-probe.c: Sort headers.
595         * disasm.h: Sort headers.
596         * disasm.c: Sort headers.
597         * disasm-selftests.c: Sort headers.
598         * dictionary.c: Sort headers.
599         * dicos-tdep.c: Sort headers.
600         * demangle.c: Sort headers.
601         * dcache.h: Sort headers.
602         * dcache.c: Sort headers.
603         * darwin-nat.h: Sort headers.
604         * darwin-nat.c: Sort headers.
605         * darwin-nat-info.c: Sort headers.
606         * d-valprint.c: Sort headers.
607         * d-namespace.c: Sort headers.
608         * d-lang.c: Sort headers.
609         * ctf.c: Sort headers.
610         * csky-tdep.c: Sort headers.
611         * csky-linux-tdep.c: Sort headers.
612         * cris-tdep.c: Sort headers.
613         * cris-linux-tdep.c: Sort headers.
614         * cp-valprint.c: Sort headers.
615         * cp-support.c: Sort headers.
616         * cp-namespace.c: Sort headers.
617         * cp-abi.c: Sort headers.
618         * corelow.c: Sort headers.
619         * corefile.c: Sort headers.
620         * continuations.c: Sort headers.
621         * completer.h: Sort headers.
622         * completer.c: Sort headers.
623         * complaints.c: Sort headers.
624         * coffread.c: Sort headers.
625         * coff-pe-read.c: Sort headers.
626         * cli-out.h: Sort headers.
627         * cli-out.c: Sort headers.
628         * charset.c: Sort headers.
629         * c-varobj.c: Sort headers.
630         * c-valprint.c: Sort headers.
631         * c-typeprint.c: Sort headers.
632         * c-lang.c: Sort headers.
633         * buildsym.c: Sort headers.
634         * buildsym-legacy.c: Sort headers.
635         * build-id.h: Sort headers.
636         * build-id.c: Sort headers.
637         * btrace.c: Sort headers.
638         * bsd-uthread.c: Sort headers.
639         * breakpoint.h: Sort headers.
640         * breakpoint.c: Sort headers.
641         * break-catch-throw.c: Sort headers.
642         * break-catch-syscall.c: Sort headers.
643         * break-catch-sig.c: Sort headers.
644         * blockframe.c: Sort headers.
645         * block.c: Sort headers.
646         * bfin-tdep.c: Sort headers.
647         * bfin-linux-tdep.c: Sort headers.
648         * bfd-target.c: Sort headers.
649         * bcache.c: Sort headers.
650         * ax-general.c: Sort headers.
651         * ax-gdb.h: Sort headers.
652         * ax-gdb.c: Sort headers.
653         * avr-tdep.c: Sort headers.
654         * auxv.c: Sort headers.
655         * auto-load.c: Sort headers.
656         * arm-wince-tdep.c: Sort headers.
657         * arm-tdep.c: Sort headers.
658         * arm-symbian-tdep.c: Sort headers.
659         * arm-pikeos-tdep.c: Sort headers.
660         * arm-obsd-tdep.c: Sort headers.
661         * arm-nbsd-tdep.c: Sort headers.
662         * arm-nbsd-nat.c: Sort headers.
663         * arm-linux-tdep.c: Sort headers.
664         * arm-linux-nat.c: Sort headers.
665         * arm-fbsd-tdep.c: Sort headers.
666         * arm-fbsd-nat.c: Sort headers.
667         * arm-bsd-tdep.c: Sort headers.
668         * arch-utils.c: Sort headers.
669         * arc-tdep.c: Sort headers.
670         * arc-newlib-tdep.c: Sort headers.
671         * annotate.h: Sort headers.
672         * annotate.c: Sort headers.
673         * amd64-windows-tdep.c: Sort headers.
674         * amd64-windows-nat.c: Sort headers.
675         * amd64-tdep.c: Sort headers.
676         * amd64-sol2-tdep.c: Sort headers.
677         * amd64-obsd-tdep.c: Sort headers.
678         * amd64-obsd-nat.c: Sort headers.
679         * amd64-nbsd-tdep.c: Sort headers.
680         * amd64-nbsd-nat.c: Sort headers.
681         * amd64-nat.c: Sort headers.
682         * amd64-linux-tdep.c: Sort headers.
683         * amd64-linux-nat.c: Sort headers.
684         * amd64-fbsd-tdep.c: Sort headers.
685         * amd64-fbsd-nat.c: Sort headers.
686         * amd64-dicos-tdep.c: Sort headers.
687         * amd64-darwin-tdep.c: Sort headers.
688         * amd64-bsd-nat.c: Sort headers.
689         * alpha-tdep.c: Sort headers.
690         * alpha-obsd-tdep.c: Sort headers.
691         * alpha-nbsd-tdep.c: Sort headers.
692         * alpha-mdebug-tdep.c: Sort headers.
693         * alpha-linux-tdep.c: Sort headers.
694         * alpha-linux-nat.c: Sort headers.
695         * alpha-bsd-tdep.c: Sort headers.
696         * alpha-bsd-nat.c: Sort headers.
697         * aix-thread.c: Sort headers.
698         * agent.c: Sort headers.
699         * addrmap.c: Sort headers.
700         * ada-varobj.c: Sort headers.
701         * ada-valprint.c: Sort headers.
702         * ada-typeprint.c: Sort headers.
703         * ada-tasks.c: Sort headers.
704         * ada-lang.c: Sort headers.
705         * aarch64-tdep.c: Sort headers.
706         * aarch64-ravenscar-thread.c: Sort headers.
707         * aarch64-newlib-tdep.c: Sort headers.
708         * aarch64-linux-tdep.c: Sort headers.
709         * aarch64-linux-nat.c: Sort headers.
710         * aarch64-fbsd-tdep.c: Sort headers.
711         * aarch64-fbsd-nat.c: Sort headers.
712         * aarch32-linux-nat.c: Sort headers.
713
714 2019-04-04  Tom Tromey  <tom@tromey.com>
715
716         * varobj.c (varobj_create): Update.
717         * rust-exp.y (struct rust_parser) <update_innermost_block,
718         lookup_symbol>: New methods.
719         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
720         Rename.
721         (rust_parser::rust_lookup_type)
722         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
723         * printcmd.c (display_command, do_one_display): Update.
724         * parser-defs.h (struct parser_state) <parser_state>: Add
725         "tracker" parameter.
726         (block_tracker): New member.
727         (class innermost_block_tracker) <innermost_block_tracker>: Add
728         "types" parameter.
729         <reset>: Remove method.
730         (innermost_block): Don't declare.
731         (null_post_parser): Update.
732         * parse.c (innermost_block): Remove global.
733         (write_dollar_variable): Update.
734         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
735         Remove "tracker_types" parameter.
736         (parse_expression): Add "tracker" parameter.
737         (parse_expression_for_completion): Update.
738         (null_post_parser): Add "tracker" parameter.
739         * p-exp.y: Update rules.
740         * m2-exp.y: Update rules.
741         * language.h (struct language_defn) <la_post_parser>: Add
742         "tracker" parameter.
743         * go-exp.y: Update rules.
744         * f-exp.y: Update rules.
745         * expression.h (parse_expression, parse_exp_1): Add "tracker"
746         parameter.
747         * d-exp.y: Update rules.
748         * c-exp.y: Update rules.
749         * breakpoint.c (set_breakpoint_condition): Create an
750         innermost_block_tracker.
751         (watch_command_1): Likewise.
752         * ada-lang.c (resolve): Add "tracker" parameter.
753         (resolve_subexp): Likewise.
754         * ada-exp.y (write_var_from_sym): Update.
755
756 2019-04-04  Tom Tromey  <tom@tromey.com>
757
758         * type-stack.h: New file.
759         * type-stack.c: New file.
760         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
761         type-stack.h.
762         (insert_into_type_stack, insert_type, push_type, push_type_int)
763         (insert_type_address_space, pop_type, pop_type_int)
764         (pop_typelist, pop_type_stack, append_type_stack)
765         (push_type_stack, get_type_stack, push_typelist)
766         (follow_type_instance_flags, follow_types): Don't declare.
767         * parse.c (type_stack): Remove global.
768         (parse_exp_in_context): Update.
769         (insert_into_type_stack, insert_type, push_type, push_type_int)
770         (insert_type_address_space, pop_type, pop_type_int)
771         (pop_typelist, pop_type_stack, append_type_stack)
772         (push_type_stack, get_type_stack, push_typelist)
773         (follow_type_instance_flags, follow_types): Remove (moved to
774         type-stack.c).
775         * f-exp.y (type_stack): New global.
776         Update rules.
777         (push_kind_type, f_parse): Update.
778         * d-exp.y (type_stack): New global.
779         Update rules.
780         (d_parse): Update.
781         * c-exp.y (struct c_parse_state) <type_stack>: New member.
782         Update rules.
783         * Makefile.in (COMMON_SFILES): Add type-stack.c.
784         (HFILES_NO_SRCDIR): Add type-stack.h.
785
786 2019-04-04  Tom Tromey  <tom@tromey.com>
787
788         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
789         (rust_parser::convert_ast_to_expression, rust_parse)
790         (rust_lex_test_completion, rust_lex_tests): Update.
791         * parser-defs.h (struct expr_completion_state): New.
792         (struct parser_state) <parser_state>: Add completion parameter.
793         <mark_struct_expression, mark_completion_tag>: New methods.
794         <parse_completion, m_completion_state>: New members.
795         (prefixify_expression, null_post_parser): Update.
796         (mark_struct_expression, mark_completion_tag): Don't declare.
797         * parse.c (parse_completion, expout_last_struct)
798         (expout_tag_completion_type, expout_completion_name): Remove
799         globals.
800         (parser_state::mark_struct_expression)
801         (parser_state::mark_completion_tag): Now methods.
802         (prefixify_expression): Add last_struct parameter.
803         (prefixify_subexp): Likewise.
804         (parse_exp_1): Update.
805         (parse_exp_in_context): Add cstate parameter.  Update.
806         (parse_expression_for_completion): Create an
807         expr_completion_state.
808         (null_post_parser): Add "completion" parameter.
809         * p-exp.y: Update rules.
810         (yylex): Update.
811         * language.h (struct language_defn) <la_post_parser>: Add
812         "completing" parameter.
813         * go-exp.y: Update rules.
814         (lex_one_token): Update.
815         * expression.h (parse_completion): Don't declare.
816         * d-exp.y: Update rules.
817         (lex_one_token): Update rules.
818         * c-exp.y: Update rules.
819         (lex_one_token): Update.
820         * ada-lang.c (resolve): Add "parse_completion" parameter.
821         (resolve_subexp): Likewise.
822         (ada_resolve_function): Likewise.
823
824 2019-04-04  Tom Tromey  <tom@tromey.com>
825
826         * parser-defs.h (struct parser_state) <start_arglist,
827         end_arglist>: New methods.
828         <arglist_len, m_funcall_chain>: New members.
829         (arglist_len, start_arglist, end_arglist): Don't declare.
830         * parse.c (arglist_len, funcall_chain): Remove global.
831         (start_arglist, end_arglist): Remove functions.
832         (parse_exp_in_context): Update.
833         * p-exp.y: Update rules.
834         * m2-exp.y: Update rules.
835         * go-exp.y: Update rules.
836         * f-exp.y: Update rules.
837         * d-exp.y: Update rules.
838         * c-exp.y: Update rules.
839
840 2019-04-04  Tom Tromey  <tom@tromey.com>
841
842         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
843         lex_operator, push_back>: New methods.
844         Update all rules.
845         (rust_parser::lex_hex, lex_escape): Rename and update.
846         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
847         (rust_parser::lex_operator): Rename and update.
848         (rust_parser::lex_number, rustyylex, rustyyerror)
849         (rust_lex_test_init, rust_lex_test_sequence)
850         (rust_lex_test_push_back, rust_lex_tests): Update.
851         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
852         parameter.
853         <lexptr, prev_lexptr>: New members.
854         (lexptr, prev_lexptr): Don't declare.
855         * parse.c (lexptr, prev_lexptr): Remove globals.
856         (parse_exp_in_context): Update.
857         * p-exp.y (yylex, yyerror): Update.
858         * m2-exp.y (parse_number, yylex, yyerror): Update.
859         * go-exp.y (lex_one_token, yyerror): Update.
860         * f-exp.y (match_string_literal, yylex, yyerror): Update.
861         * d-exp.y (lex_one_token, yyerror): Update.
862         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
863         (lex_one_token, yyerror): Update.
864         * ada-lex.l (YY_INPUT): Update.
865         (rewind_to_char): Update.
866         * ada-exp.y (yyerror): Update.
867
868 2019-04-04  Tom Tromey  <tom@tromey.com>
869
870         * rust-exp.y (rustyylex, rust_lex_tests): Update.
871         * parser-defs.h (struct parser_state) <parser_state>: Add new
872         parameter.
873         <comma_terminates>: New member.
874         (comma_terminates): Don't declare global.
875         * parse.c (comma_terminates): Remove global.
876         (parse_exp_in_context): Update.
877         * p-exp.y (yylex): Update.
878         * m2-exp.y (yylex): Update.
879         * go-exp.y (lex_one_token): Update.
880         * f-exp.y (yylex): Update.
881         * d-exp.y (lex_one_token): Update.
882         * c-exp.y (lex_one_token): Update.
883         * ada-lex.l: Update.
884
885 2019-04-04  Tom Tromey  <tom@tromey.com>
886
887         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
888         (rustyylex, rust_lex_test_init, rust_lex_test_one)
889         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
890         * parser-defs.h (paren_depth): Don't declare.
891         * parse.c (paren_depth): Remove global.
892         (parse_exp_in_context): Update.
893         * p-exp.y (paren_depth): New global.
894         (pascal_parse): Initialize it.
895         * m2-exp.y (paren_depth): New global.
896         (m2_parse): Initialize it.
897         * go-exp.y (paren_depth): New global.
898         (go_parse): Initialize it.
899         * f-exp.y (paren_depth): New global.
900         (f_parse): Initialize it.
901         * d-exp.y (paren_depth): New global.
902         (d_parse): Initialize it.
903         * c-exp.y (paren_depth): New global.
904         (c_parse): Initialize it.
905         * ada-lex.l (paren_depth): New global.
906         (lexer_init): Initialize it.
907
908 2019-04-04  Tom Tromey  <tom@tromey.com>
909
910         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
911         (rust_parser::convert_ast_to_type)
912         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
913         * parser-defs.h (struct parser_state) <parser_state>: Add
914         parameters.  Initialize new members.
915         <expression_context_block, expression_context_pc>: New members.
916         * parse.c (expression_context_block, expression_context_pc):
917         Remove globals.
918         (parse_exp_in_context): Update.
919         * p-exp.y: Update all rules.
920         (yylex): Update.
921         * m2-exp.y: Update all rules.
922         (yylex): Update.
923         * go-exp.y (yylex): Update.
924         * f-exp.y (yylex): Update.
925         * d-exp.y: Update all rules.
926         (yylex): Update.
927         * c-exp.y: Update all rules.
928         (lex_one_token, classify_name, yylex, c_parse): Update.
929         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
930
931 2019-04-04  Tom Tromey  <tom@tromey.com>
932
933         * gdbarch.h, gdbarch.c: Rebuild.
934         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
935         * stap-probe.h: 
936         (struct stap_parse_info): Replace "parser_state" with
937         "expr_builder".
938         * parser-defs.h (struct expr_builder): Rename from "parser_state".
939         (parser_state): New class.
940         * parse.c (expr_builder): Rename.
941         (expr_builder::release): Rename.
942         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
943         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
944         (write_exp_elt_longcst, write_exp_elt_floatcst)
945         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
946         (write_exp_string_vector, write_exp_bitstring)
947         (write_exp_msymbol, mark_struct_expression)
948         (write_dollar_variable)
949         (insert_type_address_space, increase_expout_size): Replace
950         "parser_state" with "expr_builder".
951         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
952         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
953         "parser_state" with "expr_builder".
954
955 2019-04-04  Tom Tromey  <tom@tromey.com>
956
957         * rust-exp.y: Replace "parse_language" with method call.
958         * p-exp.y: 
959         (yylex): Replace "parse_language" with method call.
960         * m2-exp.y: 
961         (yylex): Replace "parse_language" with method call.
962         * go-exp.y (classify_name): Replace "parse_language" with method
963         call.
964         * f-exp.y (yylex): Replace "parse_language" with method call.
965         * d-exp.y (lex_one_token): Replace "parse_language" with method
966         call.
967         * c-exp.y: 
968         (lex_one_token, classify_name, yylex): Replace "parse_language"
969         with method call.
970         * ada-exp.y (find_primitive_type, type_char)
971         (type_system_address): Replace "parse_language" with method call.
972
973 2019-04-04  Tom Tromey  <tom@tromey.com>
974
975         * rust-exp.y: Replace "parse_gdbarch" with method call.
976         * parse.c (write_dollar_variable, insert_type_address_space):
977         Replace "parse_gdbarch" with method call.
978         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
979         call.
980         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
981         call.
982         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
983         "parse_gdbarch" with method call.
984         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
985         with method call.
986         * f-exp.y (parse_type, parse_f_type, yylex): Replace
987         "parse_gdbarch" with method call.
988         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
989         "parse_gdbarch" with method call.
990         * c-exp.y (parse_type, parse_number, classify_name): Replace
991         "parse_gdbarch" with method call.
992         * ada-lex.l: Replace "parse_gdbarch" with method call.
993         * ada-exp.y (parse_type, find_primitive_type, type_char)
994         (type_system_address): Replace "parse_gdbarch" with method call.
995
996 2019-04-04  Tom Tromey  <tom@tromey.com>
997
998         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
999         * stap-probe.c (stap_parse_argument): Update.
1000         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1001         initial_size parameter.
1002         * rust-exp.y (rust_lex_tests): Update.
1003         * parse.c (parser_state): Update.
1004         (parse_exp_in_context): Update.
1005         * parser-defs.h (struct parser_state) <parser_state>: Remove
1006         "initial_size" parameter.
1007
1008 2019-04-04  Tom Tromey  <tom@tromey.com>
1009
1010         * parser-defs.h (increase_expout_size): Don't declare.
1011         * parse.c (increase_expout_size): Now static.
1012
1013 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1014
1015         * gnu-nat.c (gnu_nat_target::wait): Fix
1016         target_waitstatus_to_string call.
1017
1018 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1019
1020         * eval.c (evaluate_subexp_standard): Handle internal functions
1021         during Fortran function call handling.
1022
1023 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1024
1025         * NEWS: Mention new internal functions.
1026         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1027         (read_base_type): Use dwarf2_init_complex_target_type.
1028         * value.c (creal_internal_fn): New function.
1029         (cimag_internal_fn): New function.
1030         (_initialize_values): Register new internal functions.
1031
1032 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1033
1034         * infrun.c (stop_all_threads): If debug_infrun, always
1035         trace the wait status after wait_one, using
1036         target_waitstatus_to_string and target_pid_to_str.
1037         (handle_inferior_event): Replace various trace of
1038         wait status kind by a single trace.
1039         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1040         wait status kind image by target_waitstatus_to_string.
1041         * target/waitstatus.c (target_waitstatus_to_string): Fix
1042         obsolete comment.
1043
1044 2019-04-01  Tom Tromey  <tromey@adacore.com>
1045
1046         PR symtab/23331:
1047         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1048
1049 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1050             Pedro Alves  <palves@redhat.com>
1051
1052         * top.c (quit_force): Call 'finalize_values'.
1053         * value.c (finalize_values): New function.
1054         * value.h (finalize_values): Declare.
1055
1056 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1057
1058         * NEWS: Announce $_gdb_major and $_gdb_minor.
1059
1060         * top.c (init_gdb_version_vars): New function.
1061         (gdb_init): Call init_gdb_version_vars.
1062
1063 2019-03-29  Tom Tromey  <tromey@adacore.com>
1064
1065         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1066         help text.  Remove dead code.
1067
1068 2019-03-29  Keith Seitz  <keiths@redhat.com>
1069
1070         From Siddhesh Poyarekar:
1071         * f-lang.h (f77_get_upperbound): Return LONGEST.
1072         (f77_get_lowerbound): Likewise.
1073         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1074         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1075         print them.
1076         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1077         plongest to format print it.
1078         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1079         (f77_get_upperbound): Likewise.
1080         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1081         LOWER_BOUND to LONGEST.
1082         (f77_create_arrayprint_offset_tbl): Likewise.
1083
1084 2019-03-29  Keith Seitz  <keiths@redhat.com>
1085
1086         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1087         %s/pulongest for TYPE_LENGTH instead of %d in format
1088         strings.
1089         * ada-typerint.c (ada_print_type): Likewise.
1090         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1091         * compile/compile-c-support.c (generate_register_struct): Likewise.
1092         * gdbtypes.c (recursive_dump_type): Likewise.
1093         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1094         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1095         instead of %d in format strings.
1096         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1097         to std::min to ULONGEST.
1098         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1099         instead of %d in format strings.
1100         * tracepoint.c (info_scope_command): Likewise.
1101         * typeprint.c (print_offset_data::update)
1102         (print_offset_data::finish): Likewise.
1103         * xtensa-tdep.c (xtensa_store_return_value)
1104         (xtensa_push_dummy_call): Likewise.
1105
1106 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1107
1108         * windows-nat.c (display_selector): Fixed format specifications
1109         for 64-bit Cygwin.
1110
1111 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1112
1113         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1114
1115 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1116
1117         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1118         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1119         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1120         (nios2_linux_init_abi): Install it.
1121
1122 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1123
1124         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1125
1126 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1127
1128         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1129
1130 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1131             Tom Tromey  <tromey@adacore.com>
1132
1133         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1134
1135 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1136
1137         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1138         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1139         method to compute the bounds of range types. Also print "[evaluated]"
1140         if the bounds' values come from a dynamic evaluation.
1141
1142 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1143
1144         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1145         whitespace when pretty printing is on.
1146
1147 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1148
1149         * ppc-linux-nat.c: Add include.
1150
1151 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1152
1153         * NEWS: Mention AArch64 Pointer Authentication.
1154
1155 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1156
1157         * arm-linux-nat.c: Add include.
1158
1159 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1160
1161         * source-cache.c (source_cache::get_source_lines): Re-read
1162         fullname after calling open_source_file.
1163
1164 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1165
1166         * NEWS: Mention TLS support for FreeBSD.
1167
1168 2019-03-25  Tom Tromey  <tromey@adacore.com>
1169
1170         * minsyms.c (BUNCH_SIZE): Update comment.
1171         (~minimal_symbol_reader): Remove old comment.
1172         (compact_minimal_symbols): Update comment.
1173         (minimal_symbol_reader::install): Remove old comment.  Update
1174         other comments.
1175
1176 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1177
1178         * s390-linux-nat.c: Add include.
1179
1180 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1181
1182         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1183         Call linux_get_hwcap.
1184         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1185         Likewise.
1186         (aarch64_linux_get_hwcap): Remove function.
1187         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1188         declaration.
1189         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1190         linux_get_hwcap.
1191         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1192         * linux-tdep.c (linux_get_hwcap): Add function.
1193         (linux_get_hwcap2): Likewise.
1194         * linux-tdep.h (linux_get_hwcap): Add declaration.
1195         (linux_get_hwcap2): Likewise.
1196         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1197         (ppc_linux_get_hwcap2): Likewise.
1198         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1199         linux_get_hwcap.
1200         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1201         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1202         (ppc_linux_nat_target::read_description): Likewise.
1203         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1204         * s390-linux-nat.c: Likewise.
1205         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1206
1207 2019-03-24  Tom Tromey  <tom@tromey.com>
1208
1209         * ada-lang.c (standard_lookup): Simplify initialization.
1210         (ada_lookup_symbol_nonlocal): Simplify return.
1211         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1212         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1213         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1214         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1215         initialization.
1216         * solib.c (solib_global_lookup): Simplify.
1217         * symtab.c (null_block_symbol): Remove.
1218         (symbol_cache_lookup): Simplify returns.
1219         (lookup_language_this): Simplify returns.
1220         (lookup_symbol_aux): Simplify return.
1221         (lookup_local_symbol): Simplify returns.
1222         (lookup_global_symbol_from_objfile): Simplify return.
1223         (lookup_symbol_in_objfile_symtabs)
1224         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1225         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1226         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1227         * cp-namespace.c (cp_lookup_bare_symbol)
1228         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1229         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1230         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1231         (cp_lookup_symbol_via_imports): Simplify initialization.
1232         (find_symbol_in_baseclass): Likewise.
1233         * symtab.h (null_block_symbol): Remove.
1234         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1235         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1236         (d_lookup_symbol_module): Likewise.
1237         (find_symbol_in_baseclass): Simplify initialization.
1238
1239 2019-03-24  Tom Tromey  <tom@tromey.com>
1240
1241         * expression.h: Don't include symtab.h.
1242         (struct block): Forward declare.
1243
1244 2019-03-24  Tom Tromey  <tom@tromey.com>
1245
1246         * c-exp.y (typebase): Remove casts.
1247         * gdbtypes.c (lookup_unsigned_typename, )
1248         (lookup_signed_typename): Remove cast.
1249         * eval.c (parse_to_comma_and_eval): Remove cast.
1250         * parse.c (write_dollar_variable): Remove cast.
1251         * block.h (struct block) <superblock>: Now const.
1252         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1253         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1254         (map_block): Make "block" const.
1255         * symfile.h (struct quick_symbol_functions)
1256         <map_matching_symbols>: Constify block argument to "callback".
1257         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1258         const.
1259         (find_pc_sect_compunit_symtab): Make "b" const.
1260         (find_symbol_at_address): Likewise.
1261         (search_symbols): Likewise.
1262         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1263         (dw2_debug_names_lookup_symbol): Likewise.
1264         (dw2_map_matching_symbols): Update.
1265         * p-valprint.c (pascal_val_print): Remove "block".
1266         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1267         (aux_add_nonlocal_symbols): Make "block" const.
1268         (resolve_subexp): Remove cast.
1269         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1270         const.
1271         (iterate_over_file_blocks): Likewise.
1272         * f-exp.y (%union) <bval>: Remove.
1273         * coffread.c (patch_opaque_types): Make "b" const.
1274         * spu-tdep.c (spu_catch_start): Make "block" const.
1275         * c-valprint.c (print_unpacked_pointer): Remove "block".
1276         * symmisc.c (dump_symtab_1): Make "b" const.
1277         (block_depth): Make "block" const.
1278         * d-exp.y (%union) <bval>: Remove.
1279         * cp-support.h (cp_lookup_rtti_type): Update.
1280         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1281         * psymtab.c (psym_lookup_symbol): Make "block" const.
1282         (maintenance_check_psymtabs): Make "b" const.
1283         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1284         (enumerate_locals, enumerate_args): Update.
1285         * python/py-symtab.c (stpy_global_block): Make "block" const.
1286         (stpy_static_block): Likewise.
1287         * inline-frame.c (block_starting_point_at): Make "new_block"
1288         const.
1289         * block.c (find_block_in_blockvector): Make return type const.
1290         (blockvector_for_pc_sect): Make "b" const.
1291         (find_block_in_blockvector): Make "b" const.
1292
1293 2019-03-23  Tom Tromey  <tom@tromey.com>
1294
1295         * varobj.c (varobj_create): Update.
1296         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1297         * printcmd.c (display_command, do_one_display): Don't reset
1298         innermost_block.
1299         * parser-defs.h (enum innermost_block_tracker_type): Move to
1300         expression.h.
1301         (innermost_block): Update comment.
1302         * parse.c (parse_exp_1): Add tracker_types parameter.
1303         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1304         tracker_types parameter.  Reset innermost_block.
1305         (parse_exp_in_context): Remove.
1306         (parse_expression_for_completion): Update.
1307         * objfiles.c (~objfile): Don't reset expression_context_block or
1308         innermost_block.
1309         * expression.h (enum innermost_block_tracker_type): Move from
1310         parser-defs.h.
1311         (parse_exp_1): Add tracker_types parameter.
1312         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1313         reset innermost_block.
1314
1315 2019-03-23  Tom Tromey  <tom@tromey.com>
1316
1317         * objfiles.h: Include bcache.h.
1318
1319 2019-03-23  Tom Tromey  <tom@tromey.com>
1320
1321         * linespec.c (get_current_search_block): Use
1322         scoped_restore_current_language.
1323         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1324
1325 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1326             Jiong Wang  <jiong.wang@arm.com>
1327
1328         * aarch64-linux-tdep.c
1329         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1330         section.
1331         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1332
1333 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1334             Jiong Wang  <jiong.wang@arm.com>
1335
1336         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1337         instructions.
1338         (aarch64_analyze_prologue_test): Add PACIASP test.
1339         (aarch64_prologue_prev_register): Unmask PC value.
1340
1341 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1342             Jiong Wang  <jiong.wang@arm.com>
1343
1344         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1345         (aarch64_dwarf2_prev_register): Unmask PC value.
1346         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1347         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1348         DW_CFA_AARCH64_negate_ra_state.
1349         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1350
1351 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1352             Jiong Wang  <jiong.wang@arm.com>
1353
1354         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1355         registers.
1356         (aarch64_pseudo_register_name): Likewise.
1357         (aarch64_pseudo_register_type): Likewise.
1358         (aarch64_pseudo_register_reggroup_p): Likewise.
1359         (aarch64_gdbarch_init): Add pauth registers.
1360         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1361         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1362         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1363         (struct gdbarch_tdep): Add regnum for ra_state.
1364
1365 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1366             Jiong Wang  <jiong.wang@arm.com>
1367
1368         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1369
1370 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1371             Jiong Wang  <jiong.wang@arm.com>
1372
1373         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1374         function.
1375         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1376         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1377         (aarch64_gdbarch_init): Add puth registers.
1378         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1379         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1380         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1381
1382 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1383             Jiong Wang  <jiong.wang@arm.com>
1384
1385         * aarch64-linux-nat.c
1386         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1387         * aarch64-linux-tdep.c
1388         (aarch64_linux_core_read_description): Likewise.
1389         (aarch64_linux_get_hwcap): New function.
1390         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1391         (aarch64_linux_get_hwcap): New declaration.
1392
1393 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1394             Jiong Wang  <jiong.wang@arm.com>
1395
1396         * aarch64-linux-nat.c
1397         (aarch64_linux_nat_target::read_description): Add pauth param.
1398         * aarch64-linux-tdep.c
1399         (aarch64_linux_core_read_description): Likewise.
1400         * aarch64-tdep.c (struct target_desc): Add in pauth.
1401         (aarch64_read_description): Add pauth param.
1402         (aarch64_gdbarch_init): Likewise.
1403         * aarch64-tdep.h (aarch64_read_description): Likewise.
1404         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1405         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1406         * features/Makefile: Add new files.
1407         * features/aarch64-pauth.c: New file.
1408         * features/aarch64-pauth.xml: New file.
1409
1410 2019-03-20  Tom Tromey  <tromey@adacore.com>
1411
1412         * infrun.c (handle_inferior_event): Rename from
1413         handle_inferior_event_1.  Create a scoped_value_mark.
1414         (handle_inferior_event): Remove.
1415
1416 2019-03-19  Tom Tromey  <tromey@adacore.com>
1417
1418         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1419         * infrun.h (print_stop_event): Add "displays" parameter.
1420         * infrun.c (print_stop_event): Add "displays" parameter.
1421
1422 2019-03-19  Pedro Alves  <palves@redhat.com>
1423
1424         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1425         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1426         to -1.  Fix TABs vs spaces.
1427         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1428         * tui/tui-out.h (tui_ui_out) Add intro comments.
1429         <m_line, m_start_of_line>: In-class initialize, and add describing
1430         comment.
1431
1432 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1433
1434         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1435         variable names.
1436         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1437
1438 2019-03-18  Pedro Alves  <palves@redhat.com>
1439             Eli Zaretskii <eliz@gnu.org>
1440
1441         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1442         m_line and m_start_of_line.
1443
1444 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1445
1446         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1447         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1448         it returns a newline.  This fixes a regression in TU mode, whereby
1449         the next line is output on the same screen line as the user input.
1450
1451 2019-03-18  Tom Tromey  <tromey@adacore.com>
1452
1453         * minsyms.c (minimal_symbol_reader::install): Remove call to
1454         obstack_blank.
1455
1456 2019-03-18  Pedro Alves  <palves@redhat.com>
1457
1458         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1459         New globals.
1460         (apply_style): New, factored out from ...
1461         (apply_ansi_escape): ... this.  Handle reverse video mode.
1462         (tui_set_reverse_mode): New function.
1463         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1464         * tui/tui-winsource.c (tui_show_source_line): Use
1465         tui_set_reverse_mode instead of setting A_STANDOUT.
1466         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1467         New setter methods.
1468
1469 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1470
1471         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1472         Handle tabs.
1473
1474 2019-03-18  Tom Tromey  <tromey@adacore.com>
1475
1476         * ada-lang.c (empty_array): Add "high" parameter.
1477         (ada_evaluate_subexp): Update.
1478
1479 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1480
1481         * unittests/string_view-selftests.c: Define
1482         _initialize_string_view_selftests unconditionally.
1483
1484 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1485
1486         PR gdb/24350
1487         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1488
1489 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1490
1491         PR gdb/24351
1492         * windows-nat.c (display_selector): Fix format specifiers.
1493
1494 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1495
1496         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1497         tui_refill_source_window instead of tui_refresh_win, to update the
1498         current execution line.  This fixes redisplay of the current line
1499         when stepping through the code with "next" or "step".
1500
1501 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1502
1503         * source-cache.c (source_cache::get_source_lines): Call
1504         find_source_lines to initialize s->nlines.  This fixes vertical
1505         scrolling of TUI source window when the DOWN arrow is pressed.
1506
1507 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1508
1509         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1510         linux-thread-db.c (_initialize_thread_db): Likewise.
1511
1512 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1513
1514         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1515         wclrtoeol in tui_show_source_line".  This reverts changes made in
1516         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1517
1518 2019-03-15  Tom Tromey  <tom@tromey.com>
1519
1520         * symtab.h (struct minimal_symbol): Derive from
1521         general_symbol_info.
1522         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1523         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1524         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1525         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1526         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1527         (MSYMBOL_SEARCH_NAME): Update.
1528         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1529         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1530         * minsyms.c (minimal_symbol_reader::record_full): Update.
1531
1532 2019-03-15  Tom Tromey  <tom@tromey.com>
1533
1534         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1535
1536 2019-03-15  Tom Tromey  <tom@tromey.com>
1537
1538         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1539         unique_xmalloc_ptr.
1540         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1541         Update.
1542         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1543         (build_minimal_symbol_hash_tables)
1544         (minimal_symbol_reader::install): Update.
1545
1546 2019-03-15  Tom Tromey  <tom@tromey.com>
1547
1548         * symtab.c (create_demangled_names_hash): Update.
1549         (symbol_set_names): Update.
1550         * objfiles.h (struct objfile_per_bfd_storage)
1551         <demangled_names_hash>: Now an htab_up.
1552         * objfiles.c (objfile_per_bfd_storage): Simplify.
1553
1554 2019-03-15  Tom Tromey  <tom@tromey.com>
1555
1556         * objfiles.h (struct objfile_per_bfd_storage): Declare
1557         destructor.
1558         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1559         New.
1560         (get_objfile_bfd_data): Use new.  Don't initialize
1561         language_of_main.
1562         (free_objfile_per_bfd_storage): Remove.
1563         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1564
1565 2019-03-15  Tom Tromey  <tom@tromey.com>
1566
1567         * symfile.c (reread_symbols): Update.
1568         * objfiles.c (objfile::objfile): Update.
1569         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1570         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1571         comment.
1572         (minimal_symbol_reader::install): Update.
1573         (terminate_minimal_symbol_table): Remove.
1574         * jit.c (jit_object_close_impl): Update.
1575
1576 2019-03-15  Tom Tromey  <tom@tromey.com>
1577
1578         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1579         initializations.
1580
1581 2019-03-15  Tom Tromey  <tom@tromey.com>
1582
1583         * objfiles.h (struct objfile_per_bfd_storage)
1584         <demangled_hash_languages>: Now a bitset.
1585         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1586         (lookup_minimal_symbol): Update.
1587
1588 2019-03-15  Tom Tromey  <tom@tromey.com>
1589
1590         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1591         Don't return the symbol.
1592         * coffread.c (record_minimal_symbol): Use record_full.
1593
1594 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1595
1596         The MS-Windows port of ncurses fails to switch to a color pair if
1597         one or both of the colors are the implicit default colors.  This
1598         change records the default colors when TUI is initialized, and
1599         then specifies them explicitly when a color pair uses the default
1600         colors.  This allows color styling in TUI mode on MS-Windows.
1601
1602         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1603         ncurses_norm_attr.
1604         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1605         colors in ncurses_norm_attr.
1606         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1607         "none", replace it with the default color recorded in
1608         ncurses_norm_attr.
1609
1610 2019-03-14  Tom Tromey  <tromey@adacore.com>
1611
1612         * source-cache.h (class source_cache) <get_source_lines>: Return
1613         std::string.
1614         * source-cache.c (source_cache::extract_lines): Handle case where
1615         first_pos==npos.  Return std::string.
1616         (source_cache::get_source_lines): Update.
1617
1618 2019-03-14  Tom Tromey  <tromey@adacore.com>
1619
1620         * NEWS: Add item for "style sources" commands.
1621         * source-cache.c (source_cache::get_source_lines): Check
1622         source_styling.
1623         * cli/cli-style.c (source_styling): New global.
1624         (_initialize_cli_style): Add "style sources" commands.
1625         (show_style_sources): New function.
1626         * cli/cli-style.h (source_styling): Declare.
1627
1628 2019-03-14  Pedro Alves  <palves@redhat.com>
1629             Tom Tromey  <tromey@adacore.com>
1630
1631         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1632         * tui/tui-winsource.c (tui_refill_source_window): New function,
1633         from...
1634         (tui_horizontal_source_scroll): ... here.  Move some logic.
1635         * cli/cli-style.c (set_style_enabled): Notify new observable.
1636         * tui/tui-hooks.c (tui_redisplay_source): New function.
1637         (tui_attach_detach_observers): Attach or detach
1638         tui_redisplay_source.
1639         * observable.h (source_styling_changed): New observable.
1640         * observable.c: Define source_styling_changed observable.
1641
1642 2019-03-13  Tom Tromey  <tromey@adacore.com>
1643
1644         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1645         (i386_gnu_nat_target::store_registers): Update.
1646         * target-debug.h (target_debug_print_std_string): New macro.
1647         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1648         * windows-tdep.c (display_one_tib): Update.
1649         * tui/tui-stack.c (tui_make_status_line): Update.
1650         * top.c (print_inferior_quit_action): Update.
1651         * thread.c (thr_try_catch_cmd): Update.
1652         (add_thread_with_info): Update.
1653         (thread_target_id_str): Update.
1654         (thr_try_catch_cmd): Update.
1655         (thread_command): Update.
1656         (thread_find_command): Update.
1657         * record-btrace.c (record_btrace_target::info_record)
1658         (record_btrace_resume_thread, record_btrace_target::resume)
1659         (record_btrace_cancel_resume, record_btrace_step_thread)
1660         (record_btrace_target::wait, record_btrace_target::wait)
1661         (record_btrace_target::wait, record_btrace_target::stop): Update.
1662         * progspace.c (print_program_space): Update.
1663         * process-stratum-target.c
1664         (process_stratum_target::thread_address_space): Update.
1665         * linux-fork.c (linux_fork_mourn_inferior)
1666         (detach_checkpoint_command, info_checkpoints_command)
1667         (linux_fork_context): Update.
1668         (linux_fork_detach): Update.
1669         (class scoped_switch_fork_info): Update.
1670         (delete_checkpoint_command): Update.
1671         * infrun.c (follow_fork_inferior): Update.
1672         (follow_fork_inferior): Update.
1673         (proceed_after_vfork_done): Update.
1674         (handle_vfork_child_exec_or_exit): Update.
1675         (follow_exec): Update.
1676         (displaced_step_prepare_throw): Update.
1677         (displaced_step_restore): Update.
1678         (start_step_over): Update.
1679         (resume_1): Update.
1680         (clear_proceed_status_thread): Update.
1681         (proceed): Update.
1682         (print_target_wait_results): Update.
1683         (do_target_wait): Update.
1684         (context_switch): Update.
1685         (stop_all_threads): Update.
1686         (restart_threads): Update.
1687         (finish_step_over): Update.
1688         (handle_signal_stop): Update.
1689         (switch_back_to_stepped_thread): Update.
1690         (keep_going_pass_signal): Update.
1691         (print_exited_reason): Update.
1692         (normal_stop): Update.
1693         * inferior.c (inferior_pid_to_str): Change return type.
1694         (print_selected_inferior): Update.
1695         (add_inferior): Update.
1696         (detach_inferior): Update.
1697         * dummy-frame.c (fprint_dummy_frames): Update.
1698         * dcache.c (dcache_info_1): Update.
1699         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1700         (btrace_fetch, btrace_clear): Update.
1701         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1702         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1703         type.
1704         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1705         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1706         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1707         * gdbarch.c, gdbarch.h: Rebuild.
1708         * gdbarch.sh (core_pid_to_str): Change return type.
1709         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1710         return type.
1711         (windows_nat_target::pid_to_str): Change return type.
1712         (windows_delete_thread): Update.
1713         (windows_nat_target::attach): Update.
1714         (windows_nat_target::files_info): Update.
1715         * target-delegates.c: Rebuild.
1716         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1717         return type.
1718         (sol_thread_target::pid_to_str): Change return type.
1719         * remote.c (class remote_target) <pid_to_str>: Change return
1720         type.
1721         (remote_target::pid_to_str): Change return type.
1722         (extended_remote_target::attach, remote_target::remote_stop_ns)
1723         (remote_target::remote_notif_remove_queued_reply)
1724         (remote_target::push_stop_reply, remote_target::disable_btrace):
1725         Update.
1726         (extended_remote_target::attach): Update.
1727         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1728         type.
1729         (gdbsim_target::pid_to_str): Change return type.
1730         * ravenscar-thread.c (struct ravenscar_thread_target)
1731         <pid_to_str>: Change return type.
1732         (ravenscar_thread_target::pid_to_str): Change return type.
1733         * procfs.c (class procfs_target) <pid_to_str>: Change return
1734         type.
1735         (procfs_target::pid_to_str): Change return type.
1736         (procfs_target::attach): Update.
1737         (procfs_target::detach): Update.
1738         (procfs_target::fetch_registers): Update.
1739         (procfs_target::store_registers): Update.
1740         (procfs_target::wait): Update.
1741         (procfs_target::files_info): Update.
1742         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1743         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1744         return type.
1745         (nto_procfs_target::pid_to_str): Change return type.
1746         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1747         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1748         return type.
1749         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1750         (exit_lwp): Update.
1751         (attach_proc_task_lwp_callback, get_detach_signal)
1752         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1753         (linux_nat_target::resume, wait_lwp, stop_callback)
1754         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1755         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1756         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1757         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1758         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1759         type.
1760         (inf_ptrace_target::attach): Update.
1761         (inf_ptrace_target::files_info): Update.
1762         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1763         type.
1764         (go32_nat_target::pid_to_str): Change return type.
1765         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1766         (gnu_nat_target::wait): Update.
1767         (gnu_nat_target::wait): Update.
1768         (gnu_nat_target::resume): Update.
1769         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1770         (fbsd_nat_target::wait): Update.
1771         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1772         type.
1773         (darwin_nat_target::attach): Update.
1774         * corelow.c (class core_target) <pid_to_str>: Change return type.
1775         (core_target::pid_to_str): Change return type.
1776         * target.c (normal_pid_to_str): Change return type.
1777         (default_pid_to_str): Likewise.
1778         (target_pid_to_str): Change return type.
1779         (target_translate_tls_address): Update.
1780         (target_announce_detach): Update.
1781         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1782         return type.
1783         (bsd_uthread_target::pid_to_str): Change return type.
1784         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1785         type.
1786         (bsd_kvm_target::pid_to_str): Change return type.
1787         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1788         return type.
1789         (aix_thread_target::pid_to_str): Change return type.
1790         * target.h (struct target_ops) <pid_to_str>: Change return type.
1791         (target_pid_to_str, normal_pid_to_str): Likewise.
1792         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1793         type.
1794         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1795         type.
1796         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1797         return type.
1798         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1799         type.
1800         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1801         type.
1802         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1803         return type.
1804
1805 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1806
1807         * NEWS: Mention that the new default MI version is 3.  Mention
1808         changes to the output of commands and events that deal with
1809         multi-location breakpoints.
1810         * breakpoint.c: Include "mi/mi-out.h".
1811         (print_one_breakpoint): Change output syntax if using MI version
1812         >= 3.
1813         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1814         New.
1815         (mi_multi_location_breakpoint_output_fixed): New.
1816         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1817         (mi_cmd_fix_multi_location_breakpoint_output): New.
1818         (mi_multi_location_breakpoint_output_fixed): New.
1819         * mi/mi-cmds.c (mi_cmds): Register command
1820         -fix-multi-location-breakpoint-output.
1821         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1822         interpreter "mi".
1823
1824 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1825
1826         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1827         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1828         instantiate mi_ui_out based on interpreter name.
1829         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1830         * mi/mi-main.c (mi_load_progress): Likewise.
1831
1832 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1833
1834         * NEWS: Combine separate "New targets" sections for 8.3.
1835
1836 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1837
1838         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1839         (ppcfbsd_init_abi): Install gdbarch
1840         "fetch_tls_load_module_address" and "get_thread_local_address"
1841         methods.
1842
1843 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1844
1845         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1846         (riscv_fbsd_init_abi): Install gdbarch
1847         "fetch_tls_load_module_address" and "get_thread_local_address"
1848         methods.
1849
1850 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1851
1852         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1853         (i386fbsd_init_abi): Install gdbarch
1854         "fetch_tls_load_module_address" and "get_thread_local_address"
1855         methods.
1856
1857 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1858
1859         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1860         (amd64fbsd_init_abi): Install gdbarch
1861         "fetch_tls_load_module_address" and "get_thread_local_address"
1862         methods.
1863
1864 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1865
1866         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1867         (struct fbsd_pspace_data): New type.
1868         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1869         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1870         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1871         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1872         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1873
1874 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1875
1876         * gdbtypes.c (lookup_struct_elt): New function.
1877         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1878         * gdbtypes.h (struct struct_elt): New type.
1879         (lookup_struct_elt): New prototype.
1880
1881 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1882
1883         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1884         remove disabled code block.
1885
1886 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1887
1888         * gdbarch.sh (get_thread_local_address): New method.
1889         * gdbarch.h, gdbarch.c: Regenerate.
1890         * target.c (target_translate_tls_address): Use
1891         gdbarch_get_thread_local_address if present instead of
1892         target::get_thread_local_address.
1893
1894 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1895
1896         * target.h (target::get_thread_local_address): Update comment.
1897
1898 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1899
1900         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1901         objfile->separate_debug_objfile_backlink if not NULL.
1902
1903 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1904
1905         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1906         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1907         (amd64bsd_store_inferior_registers): Likewise.
1908         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1909         Enable segment base registers.
1910         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1911         PT_GETFSBASE and PT_GETGSBASE.
1912         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1913         PT_SETGSBASE.
1914         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1915         segment base registers.
1916         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1917
1918 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1919
1920         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1921         Update calls to i386_target_description to add 'segments'
1922         parameter.
1923         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1924         add segment base registers.
1925         * arch/i386.c (i386_create_target_description): Add 'segments'
1926         parameter to enable segment base registers.
1927         * arch/i386.h (i386_create_target_description): Likewise.
1928         * features/i386/32bit-segments.xml: New file.
1929         * features/i386/32bit-segments.c: Generate.
1930         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1931         call to i386_target_description to add 'segments' parameter.
1932         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1933         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1934         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1935         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1936         if feature is present.
1937         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1938         Add 'segments' parameter to call to i386_target_description.
1939         (i386_target_description): Add 'segments' parameter to enable
1940         segment base registers.
1941         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1942         to call to i386_target_description.
1943         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1944         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1945         Define I386_NUM_REGS.
1946         (i386_target_description): Add 'segments' parameter to enable
1947         segment base registers.
1948
1949 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1950
1951         PR/24325
1952         * source-cache.c: #undef open and close, to avoid unresolved
1953         externals during linking.
1954
1955 2019-03-12  Tom Tromey  <tromey@adacore.com>
1956
1957         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1958         const.  Add initializers.
1959         (_initialize_remote): Don't initialize ptid globals.
1960
1961 2019-03-12  Pedro Alves  <palves@redhat.com>
1962
1963         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1964
1965 2019-03-12  Pedro Alves  <palves@redhat.com>
1966
1967         * cp-name-parser.y (main): Remove unused 'len' variable.
1968
1969 2019-03-12  Tom Tromey  <tromey@adacore.com>
1970
1971         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1972         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1973
1974 2019-03-12  Tom Tromey  <tromey@adacore.com>
1975
1976         * linux-nat.c (iterate_over_lwps): Update.
1977         (stop_callback): Remove parameter.
1978         (stop_wait_callback, detach_callback, resume_set_callback)
1979         (select_singlestep_lwp_callback, set_ignore_sigint)
1980         (status_callback, resumed_callback, resume_clear_callback)
1981         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1982         data parameter.
1983         (linux_nat_target::detach, linux_nat_target::resume)
1984         (linux_stop_and_wait_all_lwps, select_event_lwp)
1985         (linux_nat_filter_event, linux_nat_wait_1)
1986         (linux_nat_target::kill, linux_nat_target::stop)
1987         (linux_nat_target::stop): Update.
1988         (linux_nat_resume_callback): Change type.
1989         (resume_stopped_resumed_lwps, count_events_callback)
1990         (select_event_lwp_callback): Likewise.
1991         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1992         * arm-linux-nat.c (struct update_registers_data): Remove.
1993         (update_registers_callback): Change type.
1994         (arm_linux_insert_hw_breakpoint1): Update.
1995         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1996         parameter.
1997         (x86_linux_dr_set_addr): Update.
1998         (x86_linux_dr_set_control): Update.
1999         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2000         (iterate_over_lwps): Use gdb::function_view.
2001         * nat/aarch64-linux-hw-point.c (struct
2002         aarch64_dr_update_callback_param): Remove.
2003         (debug_reg_change_callback): Change type.
2004         (aarch64_notify_debug_reg_change): Update.
2005         * s390-linux-nat.c (s390_refresh_per_info): Update.
2006
2007 2019-03-11  Tom Tromey  <tromey@adacore.com>
2008
2009         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2010         redundant assignment to "this_cu".
2011
2012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2013
2014         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2015
2016 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2017
2018         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2019         from...
2020         (rank_one_type): ... this.
2021
2022 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2023
2024         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2025         from...
2026         (rank_one_type): ... this.
2027
2028 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2029
2030         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2031         from...
2032         (rank_one_type): ... this.
2033
2034 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2035
2036         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2037         from...
2038         (rank_one_type): ... this.
2039
2040 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2041
2042         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2043         from...
2044         (rank_one_type): ... this.
2045
2046 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2047
2048         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2049         from...
2050         (rank_one_type): ... this.
2051
2052 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2053
2054         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2055         from...
2056         (rank_one_type): ... this.
2057
2058 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2059
2060         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2061         from...
2062         (rank_one_type): ... this.
2063
2064 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2065
2066         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2067         from...
2068         (rank_one_type): ... this.
2069
2070 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2071
2072         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2073         from...
2074         (rank_one_type): ... this.
2075
2076 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2077
2078         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2079         from...
2080         (rank_one_type): ... this.
2081
2082 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2083
2084         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2085         from...
2086         (rank_one_type): ... this.
2087
2088 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2089
2090         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2091         inferior-events' shows the example events.
2092
2093 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2094
2095         Support styling on native MS-Windows console
2096
2097         PR/24315
2098         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2099         on MS-Windows if $TERM is not defined.
2100
2101         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2102
2103         * posix-hdep.c (gdb_console_fputs):
2104         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2105         functions.
2106         * ui-file.h (gdb_console_fputs): Add prototype.
2107
2108         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2109         back to fputs only if the former returns zero.
2110
2111 2019-03-07  Tom Tromey  <tom@tromey.com>
2112
2113         * symmisc.c (print_symbol_bcache_statistics): Update.
2114         (print_objfile_statistics): Update.
2115         * symfile.c (allocate_symtab): Update.
2116         * stabsread.c: Don't include bcache.h.
2117         * psymtab.h (struct psymbol_bcache): Don't declare.
2118         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2119         (psymbol_bcache_init, psymbol_bcache_free)
2120         (psymbol_bcache_get_bcache): Don't declare.
2121         * psymtab.c (struct psymbol_bcache): Remove.
2122         (psymtab_storage::psymtab_storage): Update.
2123         (psymtab_storage::~psymtab_storage): Update.
2124         (psymbol_bcache_init, psymbol_bcache_free)
2125         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2126         (add_psymbol_to_bcache): Update.
2127         (allocate_psymtab): Update.
2128         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2129         macro_cache>: No longer pointers.
2130         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2131         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2132         * macrotab.c (macro_bcache): Update.
2133         * macroexp.c: Don't include bcache.h.
2134         * gdbtypes.c (check_types_worklist): Update.
2135         (types_deeply_equal): Remove TRY/CATCH.  Update.
2136         * elfread.c (elf_symtab_read): Update.
2137         * dwarf2read.c: Don't include bcache.h.
2138         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2139         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2140         (print_bcache_statistics, bcache_memory_used): Don't declare.
2141         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2142         methods.  Rename all data members.
2143         * bcache.c (struct bcache): Move to bcache.h.
2144         (bcache::expand_hash_table): Rename from expand_hash_table.
2145         (bcache): Remove.
2146         (bcache::insert): Rename from bcache_full.
2147         (bcache::compare): Rename from bcache_compare.
2148         (bcache_xmalloc): Remove.
2149         (bcache::~bcache): Rename from bcache_xfree.
2150         (bcache::print_statistics): Rename from print_bcache_statistics.
2151         (bcache::memory_used): Rename from bcache_memory_used.
2152
2153 2019-03-07  Pedro Alves  <palves@redhat.com>
2154
2155         * infrun.c (normal_stop): Also check for
2156         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2157
2158 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2159
2160         * f-lang.c (value_from_host_double): Moved to...
2161         * value.c (value_from_host_double): ...here.
2162         * value.h (value_from_host_double): Declare.
2163         * guile/scm-math.c (vlscm_convert_typed_number): Use
2164         value_from_host_double.
2165         (vlscm_convert_number): Likewise.
2166         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2167         * python/py-value.c (convert_value_from_python): Likewise.
2168
2169 2019-03-06  Tom Tromey  <tom@tromey.com>
2170
2171         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2172
2173 2019-03-06  Tom Tromey  <tom@tromey.com>
2174
2175         * utils.h (free_current_contents): Don't declare.
2176         * utils.c (free_current_contents): Remove.
2177
2178 2019-03-06  Tom Tromey  <tom@tromey.com>
2179
2180         * top.c (quit_force): Update.
2181         * main.c (captured_command_loop): Update.
2182         * common/new-op.c (operator new): Update.
2183         * common/common-exceptions.c (struct catcher)
2184         <save_cleanup_chain>: Remove member.
2185         (exceptions_state_mc_init): Update.
2186         (exception_try_scope_entry): Return nullptr.
2187         (exception_try_scope_exit, exception_rethrow)
2188         (throw_exception_sjlj, throw_exception_cxx): Update.
2189         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2190         (all_cleanups, do_cleanups, discard_cleanups)
2191         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2192         (restore_cleanups, restore_final_cleanups): Don't declare.
2193         (do_final_cleanups): Remove parameter.
2194         * common/cleanups.c (cleanup_chain, make_cleanup)
2195         (make_cleanup_dtor, all_cleanups, do_cleanups)
2196         (discard_my_cleanups, discard_cleanups)
2197         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2198         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2199         (null_cleanup): Remove.
2200         (do_final_cleanups): Remove parameter.
2201
2202 2019-03-06  Tom Tromey  <tom@tromey.com>
2203
2204         * remote.c (remote_target::remote_parse_stop_reply): Use
2205         unique_xmalloc_ptr.
2206
2207 2019-03-06  Tom Tromey  <tom@tromey.com>
2208
2209         * stabsread.c (struct stabs_field_info): Rename from field_info.
2210         <list, fnlist>: Add initializers.
2211         <obstack>: New member.
2212         (read_member_functions, read_struct_fields, read_baseclasses):
2213         Allocate on obstack.  Don't use cleanups.
2214         (read_one_struct_field, read_member_functions, read_struct_fields)
2215         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2216         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2217         (read_struct_type): Update.
2218
2219 2019-03-06  Tom Tromey  <tom@tromey.com>
2220
2221         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2222         * common/filestuff.h (make_cleanup_close): Don't declare.
2223         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2224         Remove.
2225
2226 2019-03-06  Tom Tromey  <tom@tromey.com>
2227
2228         * solib-aix.c: Use make_scope_exit.
2229
2230 2019-03-06  Tom Tromey  <tom@tromey.com>
2231
2232         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2233         Use make_scope_exit.
2234
2235 2019-03-06  Tom Tromey  <tom@tromey.com>
2236
2237         * solib-svr4.c (disable_probes_interface): Remove parameter.
2238         (svr4_handle_solib_event): Use make_scope_exit.
2239
2240 2019-03-06  Tom Tromey  <tom@tromey.com>
2241
2242         * remote.c (struct stop_reply_deleter): Remove.
2243         (stop_reply_up): Update.
2244         (struct stop_reply): Derive from notif_event.  Don't typedef.
2245         <regcache>: Now a std::vector.
2246         (stop_reply_xfree): Remove.
2247         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2248         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2249         (remote_target::discard_pending_stop_replies): Use delete.
2250         (remote_target::remote_parse_stop_reply): Update.
2251         (remote_target::process_stop_reply): Update.
2252         * remote-notif.h (struct notif_event): Add virtual destructor.
2253         Remove "dtr" member.
2254         (struct notif_client) <alloc_event>: Return a unique_ptr.
2255         (notif_event_xfree): Don't declare.
2256         (notif_event_up): New typedef.
2257         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2258         (notif_event_xfree, do_notif_event_xfree): Remove.
2259         (remote_notif_state_xfree): Update.
2260
2261 2019-03-06  Tom Tromey  <tom@tromey.com>
2262
2263         * infrun.c (displaced_step_clear_cleanup): Now a
2264         forward_scope_exit type.
2265         (displaced_step_prepare_throw): Update.
2266         (displaced_step_fixup): Update.
2267
2268 2019-03-06  Tom Tromey  <tom@tromey.com>
2269
2270         * inferior.h (class inferior): Update comment.
2271         * gdbthread.h (class thread_info): Update comment.
2272
2273 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2274             Tom Tromey  <tom@tromey.com>
2275
2276         * stabsread.h (struct stab_section_list): Remove.
2277         (coffstab_build_psymtabs): Update.
2278         * dbxread.c (symbuf_sections): Now a std::vector.
2279         (sect_idx): New global.
2280         (fill_symbuf): Update.
2281         (coffstab_build_psymtabs): Change type of stabsects parameter.
2282         Update.
2283         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2284         std::vector.
2285         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2286         (coff_locate_sections): Update.
2287         (coff_symfile_read): Remove cleanups.  Update.
2288         (init_stringtab): Add storage parameter.
2289         (free_stringtab, free_stringtab_cleanup): Remove.
2290         (init_lineno): Add storage parameter.
2291         (free_linetab, free_linetab_cleanup): Remove.
2292
2293 2019-03-06  Pedro Alves  <palves@redhat.com>
2294
2295         * linux-fork.c (fork_info::clobber_regs): Delete.
2296         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2297         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2298         comment.  Adjust.
2299         (scoped_switch_fork_info::scoped_switch_fork_info)
2300         (checkpoint_command, linux_fork_context): Adjust
2301         fork_save_infrun_state calls.
2302
2303 2019-03-06  Pedro Alves  <palves@redhat.com>
2304
2305         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2306         (inf_has_multiple_threads): Return 'bool' and rewrite using
2307         inferior_info::threads().
2308
2309 2019-03-06  Pedro Alves  <palves@redhat.com>
2310
2311         * linux-fork.c: Include <list>.
2312         (fork_list): Now a std::list instance.
2313         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2314         (forks_exist_p, find_last_fork): Adjust.
2315         (new_fork): Delete.
2316         (one_fork_p): New.
2317         (add_fork): Adjust.
2318         (free_fork): Delete, folded into fork_info::~fork_info().
2319         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2320         Adjust.
2321         (init_fork_list): Delete.
2322         (linux_fork_killall, linux_fork_mourn_inferior)
2323         (linux_fork_detach, info_checkpoints_command): Adjust.
2324         (_initialize_linux_fork): No longer call init_fork_list.
2325
2326 2019-03-06  Pedro Alves  <palves@redhat.com>
2327
2328         * linux-fork.c (new_fork): New, split out of ...
2329         (add_fork): ... this.  Return void.  Move "first fork" special
2330         case from here, to ...
2331         (checkpoint_command): ... here.
2332         * linux-linux.h (add_fork): Return void.
2333
2334 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2335
2336         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2337
2338 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2339             Chris January  <chris.january@arm.com>
2340             David Lecomber  <david.lecomber@arm.com>
2341
2342         * f-exp.y: New token, UNOP_INTRINSIC.
2343         (exp): New pattern using UNOP_INTRINSIC token.
2344         (f77_keywords): Add 'abs' keyword.
2345         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2346         (value_from_host_double): New function.
2347         (evaluate_subexp_f): Support UNOP_ABS.
2348
2349 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2350
2351         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2352         types.
2353
2354 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2355
2356         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2357         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2358         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2359
2360 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2361
2362         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2363
2364 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2365             Chris January  <chris.january@arm.com>
2366
2367         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2368         * f-exp.y: Define 'KIND' token.
2369         (exp): New pattern for KIND expressions.
2370         (ptype): Handle types with a kind extension.
2371         (direct_abs_decl): Extend to spot kind extensions.
2372         (f77_keywords): Add 'kind' to the list.
2373         (push_kind_type): New function.
2374         (convert_to_kind_type): New function.
2375         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2376         * parse.c (operator_length_standard): Likewise.
2377         * parser-defs.h (enum type_pieces): Add tp_kind.
2378         * std-operator.def: Add UNOP_KIND.
2379
2380 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2381
2382         * f-exp.y (f_parse): Set yydebug.
2383
2384 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2385
2386         * f-lang.c (evaluate_subexp_f): New function.
2387         (exp_descriptor_f): New global.
2388         (f_language_defn): Use exp_descriptor_f instead of
2389         exp_descriptor_standard.
2390
2391 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2392
2393         * f-exp.y (struct token): Add comments.
2394         (dot_ops): Remove uppercase versions and the end marker.
2395         (f77_keywords): Likewise.
2396         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2397         entries in the dot_ops array are case insensitive, and use
2398         strncasecmp to compare strings.  Also some whitespace cleanup in
2399         this area.  Similar for the f77_keywords array, except entries in
2400         this list might be case sensitive.
2401
2402 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2403
2404         * f-exp.y (struct f77_boolean_val): Add comments.
2405         (boolean_values): Remove uppercase versions, and end marker.
2406         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2407         and use strncasecmp to achieve case insensitivity.  Additionally,
2408         perform whitespace cleanup around this code.
2409
2410 2019-03-06  Tom Tromey  <tromey@adacore.com>
2411
2412         * remote-sim.c (gdbsim_target_open): Use result of
2413         gdb_argv::release.
2414
2415 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2416         Dirk Schubert  <dirk.schubert@arm.com>
2417         Chris January  <chris.january@arm.com>
2418
2419         * eval.c (evaluate_subexp_standard): Call Fortran argument
2420         wrapping logic.
2421         * f-lang.c (struct value): A value which can be passed into a
2422         Fortran function call.
2423         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2424         where appropriate.
2425         (struct type): Value ready for a Fortran function call.
2426         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2427         is needed.
2428         * f-lang.h (fortran_argument_convert): Declaration.
2429         (fortran_preserve_arg_pointer): Declaration.
2430         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2431
2432 2019-03-05  Tom Tromey  <tromey@adacore.com>
2433
2434         * python/py-prettyprint.c (print_string_repr): Remove #if.
2435         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2436
2437 2019-03-05  Tom Tromey  <tromey@adacore.com>
2438
2439         * target.c (the_dummy_target): Move later.  Change type to
2440         "dummy_target".
2441         (initialize_targets): Don't initialize the_dummy_target.
2442
2443 2019-03-05  Tom Tromey  <tromey@adacore.com>
2444
2445         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2446         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2447
2448 2019-03-05  Tom Tromey  <tromey@adacore.com>
2449
2450         * windows-nat.c (windows_nat_target::attach)
2451         (windows_nat_target::detach): Don't call gdb_flush.
2452         * valprint.c (generic_val_print, val_print, val_print_string):
2453         Don't call gdb_flush.
2454         * utils.c (defaulted_query): Don't call gdb_flush.
2455         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2456         * target.c (target_announce_detach): Don't call gdb_flush.
2457         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2458         * remote.c (extended_remote_target::attach): Don't call
2459         gdb_flush.
2460         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2461         * printcmd.c (do_examine): Don't call gdb_flush.
2462         (info_display_command): Don't call gdb_flush.
2463         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2464         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2465         * memattr.c (info_mem_command): Don't call gdb_flush.
2466         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2467         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2468         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2469         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2470         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2471         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2472         (gnu_nat_target::detach): Don't call gdb_flush.
2473         * f-valprint.c (f_val_print): Don't call gdb_flush.
2474         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2475         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2476         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2477         gdb_flush.
2478         * c-valprint.c (c_val_print): Don't call gdb_flush.
2479         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2480
2481 2019-03-05  Tom Tromey  <tromey@adacore.com>
2482
2483         * varobj.c (update_dynamic_varobj_children): Update.
2484         (install_default_visualizer): Use reset, not release.
2485         * value.c (set_internalvar): Update.
2486         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2487         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2488         ATTRIBUTE_UNUSED_RESULT.
2489
2490 2019-03-05  Tom Tromey  <tromey@adacore.com>
2491
2492         * remote.c (class scoped_remote_fd) <release>: Add
2493         ATTRIBUTE_UNUSED_RESULT.
2494
2495 2019-03-05  Tom Tromey  <tromey@adacore.com>
2496
2497         * macroexp.c (struct macro_buffer) <release>: Add
2498         ATTRIBUTE_UNUSED_RESULT.
2499
2500 2019-03-05  Tom Tromey  <tromey@adacore.com>
2501
2502         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2503         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2504         ATTRIBUTE_UNUSED_RESULT.
2505
2506 2019-03-05  Tom Tromey  <tromey@adacore.com>
2507
2508         * common/scoped_fd.h (class scoped_fd) <release>: Add
2509         ATTRIBUTE_UNUSED_RESULT.
2510
2511 2019-03-05  Tom Tromey  <tromey@adacore.com>
2512
2513         * parser-defs.h (struct parser_state) <release>: Add
2514         ATTRIBUTE_UNUSED_RESULT.
2515
2516 2019-03-05  Tom Tromey  <tromey@adacore.com>
2517
2518         * utils.h (class gdb_argv) <release>: Add
2519         ATTRIBUTE_UNUSED_RESULT.
2520         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2521
2522 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2523
2524         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2525         for-loop range, to avoid compiler warnings.
2526
2527         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2528         avoid compiler warnings about unused variables.
2529
2530         * NEWS: Mention end of support for native debugging on MS-Windows
2531         before XP.
2532
2533         PR gdb/24292
2534         * common/netstuff.c:
2535         * gdbserver/gdbreplay.c
2536         * gdbserver/remote-utils.c:
2537         * ser-tcp.c:
2538         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2539         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2540         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2541         'getaddrinfo' and 'freeaddrinfo' were not available before
2542         Windows XP, and mingw.org's MinGW headers by default define
2543         _WIN32_WINNT to 0x500.
2544
2545 2019-03-01  Gary Benson <gbenson@redhat.com>
2546
2547         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2548
2549 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2550             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2551
2552         PR gdb/8527
2553         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2554         set_sigint_trap, clear_sigint_trap.
2555
2556 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2557
2558         * target.c (target_detach): Clear the regcache and the
2559         frame cache.
2560
2561 2019-02-27  Pedro Alves  <palves@redhat.com>
2562
2563         * utils.c (set_screen_size): When we cap the height/width sizes,
2564         tweak the corresponding command variable to show "unlimited":
2565
2566 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2567             Pedro Alves  <palves@redhat.com>
2568
2569         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2570         before calling rl_set_screen_size.
2571
2572 2019-02-27  Tom Tromey  <tromey@adacore.com>
2573
2574         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2575         define.
2576         * python/py-value.c: Remove Python 2.4 workaround.
2577         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2578         workaround.
2579         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2580         Python 2.4 workaround.
2581         * python/python-internal.h: Remove Python 2.4 comment.
2582         (Py_ssize_t): Don't define.
2583         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2584         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2585         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2586         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2587         * python/python.c (do_start_initialization): Remove Python 2.4
2588         workaround.
2589         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2590         (print_children): Remove Python 2.4 workaround.
2591         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2592         workaround.
2593         (CHARBUFFERPROC_NAME): Remove.
2594         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2595         Python 2.4 workaround.
2596
2597 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2598
2599         * NEWS: Note minimum Python version.
2600
2601 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2602
2603         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2604         code from these functions.  Remove corresponding ifdefs.  Use
2605         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2606         Remove gotos and target of gotos.
2607         (infpy_search_memory): Likewise.
2608
2609 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2610
2611         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2612         (hppa_gdbarch_init): Don't register deleted functions with
2613         gdbarch.
2614
2615 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2616
2617         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2618         (h8300_unwind_sp): Delete.
2619         (h8300_dummy_id): Delete.
2620         (h8300_gdbarch_init): Don't register deleted functions with
2621         gdbarch.
2622
2623 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2624
2625         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2626         (ft32_unwind_pc): Delete.
2627         (ft32_unwind_sp): Delete.
2628         (ft32_gdbarch_init): Don't register deleted functions with
2629         gdbarch.
2630
2631 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2632
2633         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2634         (frv_unwind_pc): Delete.
2635         (frv_unwind_sp): Delete.
2636         (frv_gdbarch_init): Don't register deleted functions with
2637         gdbarch.
2638
2639 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2640
2641         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2642         (riscv_unwind_pc): Delete.
2643         (riscv_unwind_sp): Delete.
2644         (riscv_gdbarch_init): Don't register deleted functions with
2645         gdbarch.
2646
2647 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2648
2649         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2650         (csky_unwind_pc): Delete.
2651         (csky_unwind_sp): Delete.
2652         (csky_gdbarch_init): Don't register deleted functions with
2653         gdbarch.
2654
2655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2656
2657         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2658         (cris_unwind_pc): Delete.
2659         (cris_unwind_sp): Delete.
2660         (cris_gdbarch_init): Don't register deleted functions with
2661         gdbarch.
2662
2663 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2664
2665         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2666         (bfin_unwind_pc): Delete.
2667         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2668
2669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2670
2671         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2672         (arm_unwind_pc): Delete.
2673         (arm_unwind_sp): Delete.
2674         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2675
2676 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2677
2678         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2679         (arc_unwind_pc): Delete.
2680         (arc_unwind_sp): Delete.
2681         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2682
2683 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2686         (alpha_unwind_pc): Delete.
2687         (alpha_gdbarch_init): Don't register deleted functions with
2688         gdbarch.
2689
2690 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2691
2692         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2693         (aarch64_unwind_pc): Delete.
2694         (aarch64_unwind_sp): Delete.
2695         (aarch64_gdbarch_init): Don't register deleted functions with
2696         gdbarch.
2697
2698 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2699
2700         * gdbtypes.c (type_align): Don't consider static members when
2701         computing structure alignment.
2702
2703 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2704
2705         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2706         return 0 for other types.
2707         * arch-utils.c (default_type_align): Always return 0.
2708         * gdbarch.h: Regenerate.
2709         * gdbarch.sh (type_align): Extend comment.
2710         * gdbtypes.c (type_align): Add additional comments, always call
2711         gdbarch_type_align before applying the default rules.
2712         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2713         generic code will then apply a suitable default.
2714         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2715         types, return 0 for other types.
2716
2717 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2718
2719         * NEWS: Create a new section for the next release branch.
2720         Rename the section of the current branch, now that it has
2721         been cut.
2722
2723 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2724
2725         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2726         * version.in: Bump version to 8.3.50.DATE-git.
2727
2728 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2729
2730         * aix-thread.c (ptid_cmp): Remove unused variable.
2731         (get_signaled_thread): Likewise.
2732         (store_regs_user_thread): Likewise.
2733         (store_regs_kernel_thread): Likewise.
2734         (fetch_regs_kernel_thread): Remove shadowed variable.
2735
2736 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2737
2738         * features/riscv/32bit-cpu.xml: Add register numbers.
2739         * features/riscv/32bit-fpu.c: Regenerate.
2740         * features/riscv/32bit-fpu.xml: Add register numbers.
2741         * features/riscv/64bit-cpu.xml: Add register numbers.
2742         * features/riscv/64bit-fpu.c: Regenerate.
2743         * features/riscv/64bit-fpu.xml: Add register numbers.
2744
2745 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2746
2747         * NEWS: Mention two argument form of gdb.Value constructor.
2748         * python/py-value.c (convert_buffer_and_type_to_value): New
2749         function.
2750         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2751         Add support for handling an optional second argument.  Call
2752         convert_buffer_and_type_to_value as appropriate.
2753         * python/python-internal.h (Py_buffer_deleter): New struct.
2754         (Py_buffer_up): New typedef.
2755
2756 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2757
2758         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2759         instead of releasing ownership.
2760
2761 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2762
2763         * dwarf2read.c (open_and_init_dwp_file): Call
2764         elf_numsections instead of bfd_count_sections to initialize
2765         dwp_file->num_sections.
2766
2767 2019-02-25  Tom Tromey  <tromey@adacore.com>
2768
2769         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2770
2771 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2772
2773         * gcore.in: Add '--readnever' option when invoking GDB.
2774
2775 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2776
2777         * MAINTAINERS: Update my email address.
2778
2779 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2780
2781         * build-id.c (build_id_to_debug_bfd_1): New function.
2782         (build_id_to_debug_bfd): Look for separate debug file in
2783         sysroot.
2784
2785 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2786
2787         * gdbarch.sh: Update the copyright year range that is placed into
2788         generated files.
2789
2790 2019-02-22  Keith Seitz  <keiths@redhat.com>
2791
2792         PR symtab/23853
2793         * linespec.c (create_sals_line_offset): Search for the default
2794         symtab's filename instead of its fullname.
2795
2796 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2797
2798         * NEWS: Update style defaults.
2799
2800 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2801
2802         * main.c (captured_main_1): Disable styling in batch mode.
2803
2804 2019-02-20  Tom Tromey  <tom@tromey.com>
2805
2806         * symtab.c (symtab_symbol_info): Fix typos.
2807
2808 2019-02-20  Tom Tromey  <tromey@adacore.com>
2809
2810         * findcmd.c (_initialize_mem_search): Use upper case for
2811         metasyntactic variables.
2812
2813 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2814
2815         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2816         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2817
2818 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2819
2820         * top.h (source_file_name): Change to std::string.
2821         * top.c (source_file_name): Likewise.
2822         (command_line_input): Adjust.
2823         * cli/cli-script.c (script_from_file): Adjust.
2824
2825 2019-02-19  Tom Tromey  <tromey@adacore.com>
2826
2827         * ravenscar-thread.c
2828         (ravenscar_thread_target::update_thread_list): Don't call
2829         ada_build_task_list.
2830         * ada-lang.h (ada_build_task_list): Don't declare.
2831         * ada-tasks.c (struct ada_tasks_inferior_data)
2832         <task_list_valid_p>: Now bool.
2833         (read_known_tasks, ada_task_list_changed)
2834         (ada_tasks_invalidate_inferior_data): Update.
2835         (read_known_tasks_array): Return bool.
2836         (read_known_tasks_list): Likewise.
2837         (read_known_tasks): Return void.
2838         (ada_build_task_list): Now static.
2839
2840 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2841
2842         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2843         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2844
2845 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2846
2847         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2848         variant for ada_tasks_pspace_data_handle and
2849         ada_tasks_inferior_data_handle.
2850         (ada_tasks_pspace_data_cleanup): New function.
2851         (ada_tasks_inferior_data_cleanup): New function.
2852
2853 2019-02-17  Tom Tromey  <tom@tromey.com>
2854
2855         * macrotab.h (macro_source_fullname): Return a std::string.
2856         * macrotab.c (macro_include, check_for_redefinition)
2857         (macro_undef, macro_lookup_definition, foreach_macro)
2858         (foreach_macro_in_scope): Update.
2859         (macro_source_fullname): Return a std::string.
2860         * macrocmd.c (show_pp_source_pos): Update.
2861
2862 2019-02-17  Tom Tromey  <tom@tromey.com>
2863
2864         * macrocmd.c (show_pp_source_pos): Style the file names.
2865
2866 2019-02-17  Tom Tromey  <tom@tromey.com>
2867
2868         PR tui/24197:
2869         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2870
2871 2019-02-17  Tom Tromey  <tom@tromey.com>
2872
2873         * ada-lang.c (user_select_syms): Use filtered printing.
2874         * utils.c (wrap_style): New global.
2875         (desired_style): Remove.
2876         (emit_style_escape): Add stream parameter.
2877         (set_output_style, reset_terminal_style, prompt_for_continue):
2878         Update.
2879         (flush_wrap_buffer): Only flush gdb_stdout.
2880         (wrap_here): Set wrap_style.
2881         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2882         treat escape sequences as a character.  Change when wrap buffer is
2883         flushed.
2884         (fputs_styled): Do not set the output style when the default is
2885         requested.
2886         * ui-style.h (struct ui_file_style) <is_default>: New method.
2887         * source.c (print_source_lines_base): Emit escape sequences in one
2888         piece.
2889
2890 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2891
2892         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2893         integers and enumeration types.
2894
2895 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2896
2897         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2898         instead of lookup_symbol_in_language
2899         (do_exact_match): New function.
2900         (ada_get_symbol_name_matcher): Return do_exact_match when
2901         doing a verbatim match.
2902
2903 2019-02-15  Tom Tromey  <tromey@adacore.com>
2904
2905         * ravenscar-thread.c (ravenscar_thread_target::resume)
2906         (ravenscar_thread_target::wait): Special case wildcard requests.
2907
2908 2019-02-15  Tom Tromey  <tromey@adacore.com>
2909
2910         * ravenscar-thread.c (base_ptid): Remove.
2911         (struct ravenscar_thread_target) <close>: New method.
2912         <m_base_ptid>: New member.
2913         <update_inferior_ptid, active_task, task_is_currently_active,
2914         runtime_initialized>: Declare methods.
2915         <ravenscar_thread_target>: Add constructor.
2916         (ravenscar_thread_target::task_is_currently_active)
2917         (ravenscar_thread_target::update_inferior_ptid)
2918         (ravenscar_runtime_initialized): Rename.  Now methods.
2919         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2920         (ravenscar_thread_target::update_thread_list): Update.
2921         (ravenscar_thread_target::active_task): Now method.
2922         (ravenscar_thread_target::store_registers)
2923         (ravenscar_thread_target::prepare_to_store)
2924         (ravenscar_thread_target::prepare_to_store)
2925         (ravenscar_thread_target::mourn_inferior): Update.
2926         (ravenscar_inferior_created): Use "new" to create target.
2927         (ravenscar_thread_target::get_ada_task_ptid): Update.
2928         (_initialize_ravenscar): Don't initialize base_ptid.
2929         (ravenscar_ops): Remove global.
2930
2931 2019-02-15  Tom Tromey  <tromey@adacore.com>
2932
2933         * target.h (push_target): Declare new overload.
2934         * target.c (push_target): New overload, taking an rvalue reference.
2935         * remote.c (remote_target::open_1): Use push_target overload.
2936         * corelow.c (core_target_open): Use push_target overload.
2937
2938 2019-02-15  Tom Tromey  <tromey@adacore.com>
2939
2940         * ravenscar-thread.c (is_ravenscar_task)
2941         (ravenscar_task_is_currently_active): Return bool.
2942         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2943         (_initialize_ravenscar): Remove "(void)".
2944         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2945         Return bool.
2946
2947 2019-02-15  Tom Tromey  <tromey@adacore.com>
2948
2949         * ravenscar-thread.c (ravenscar_runtime_initializer)
2950         (has_ravenscar_runtime, get_running_thread_id)
2951         (ravenscar_thread_target::resume): Fix indentation.
2952
2953 2019-02-15  Tom Tromey  <tromey@adacore.com>
2954
2955         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2956         from ravenscar_arch_ops.
2957         (sparc_ravenscar_ops::fetch_registers)
2958         (sparc_ravenscar_ops::store_registers): Now methods.
2959         (sparc_ravenscar_prepare_to_store): Remove.
2960         (sparc_ravenscar_ops): Redefine.
2961         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2962         methods and destructor.  Remove members.
2963         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2964         (ravenscar_thread_target::store_registers)
2965         (ravenscar_thread_target::prepare_to_store): Update.
2966         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2967         Remove.
2968         (struct ppc_ravenscar_powerpc_ops): Derive from
2969         ravenscar_arch_ops.
2970         (ppc_ravenscar_powerpc_ops::fetch_registers)
2971         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2972         (ppc_ravenscar_powerpc_ops): Redefine.
2973         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2974         (ppc_ravenscar_e500_ops::fetch_registers)
2975         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2976         (ppc_ravenscar_e500_ops): Redefine.
2977         * aarch64-ravenscar-thread.c
2978         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2979         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2980         (aarch64_ravenscar_fetch_registers)
2981         (aarch64_ravenscar_store_registers): Now methods.
2982         (aarch64_ravenscar_ops): Redefine.
2983
2984 2019-02-15  Tom Tromey  <tromey@adacore.com>
2985
2986         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2987         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2988         (ravenscar_thread_target::stopped_by_watchpoint)
2989         (ravenscar_thread_target::stopped_data_address)
2990         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2991
2992 2019-02-15  Tom Tromey  <tromey@adacore.com>
2993
2994         * ravenscar-thread.c: Fix some typos.
2995
2996 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2997             Tom Tromey  <tromey@adacore.com>
2998
2999         * ada-lang.c (ada_exception_sal): Change addr_string to a
3000         std::string.
3001         (create_ada_exception_catchpoint): Update.
3002
3003 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3004             Tom Tromey  <tromey@adacore.com>
3005
3006         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3007         (bp_location_ops): Remove.
3008         (base_breakpoint_allocate_location): Update.
3009         (free_bp_location): Update.
3010         * ada-lang.c (class ada_catchpoint_location)
3011         <ada_catchpoint_location>: Remove ops parameter.
3012         (ada_catchpoint_location_dtor): Remove.
3013         (ada_catchpoint_location_ops): Remove.
3014         (allocate_location_exception): Update.
3015         * breakpoint.h (struct bp_location_ops): Remove.
3016         (class bp_location) <bp_location>: Remove bp_location_ops
3017         parameter.
3018         <~bp_location>: Add destructor.
3019         <ops>: Remove.
3020
3021 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3022             Pedro Alves  <palves@redhat.com>
3023
3024         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3025         'PATH_MAX'.
3026
3027 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3028             Samuel Thibault  <samuel.thibault@gnu.org>
3029             Thomas Schwinge  <thomas@codesourcery.com>
3030
3031         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3032         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3033
3034 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3035
3036         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3037         (check_empty): Use "const char *".
3038
3039         * gnu-nat.c (gnu_nat_target::detach): Instead of
3040         'detach_inferior (pid)' call
3041         'detach_inferior (find_inferior_pid (pid))'.
3042
3043         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3044         'nat/fork-inferior.o'.
3045         * gnu-nat.c: #include "nat/fork-inferior.h".
3046
3047         * gnu-nat.c (gnu_nat_target::detach): Instead of
3048         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3049         * gnu-nat.h: #include "inf-child.h".
3050         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3051         'i386_gnu_nat_target::fetch_registers'.
3052         (gnu_store_registers): Rename/move to
3053         'i386_gnu_nat_target::store_registers'.
3054
3055         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3056         * gnu-nat.h (mach_thread_info): New function.
3057         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3058
3059         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3060
3061 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3062
3063         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3064
3065 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3066
3067         * windows-nat.c (windows_add_thread): Add new parameter
3068         "main_thread_p" with default value set to false.  Update
3069         function documentation as well as all callers.
3070         (windows_delete_thread): Likewise.
3071         (fake_create_process): Update call to windows_add_thread.
3072         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3073         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3074         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3075         call to windows_delete_thread.
3076
3077 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3078
3079         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3080
3081 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3082
3083         * symfile.c (find_separate_debug_file): Use canonical path of
3084         sysroot with child_path instead of gdb_sysroot if it is valid.
3085
3086 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3087
3088         * symfile.c (find_separate_debug_file): Use child_path to
3089         determine if an object file is under a sysroot.
3090
3091 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3092
3093         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3094         unittests/child-path-selftests.c.
3095         * common/pathstuff.c (child_path): New function.
3096         * common/pathstuff.h (child_path): New prototype.
3097         * unittests/child-path-selftests.c: New file.
3098
3099 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3100
3101         * symfile.c (find_separate_debug_file): Look for separate debug
3102         files in debug directories under the sysroot.
3103
3104 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3105
3106         * symtab.h (struct minimal_symbol data_p): New const method.
3107         (struct minimal_symbol text_p): Likewise.
3108         * symtab.c (output_source_filename): Use file name style
3109         to print file name.
3110         (print_symbol_info): Likewise.
3111         (print_msymbol_info): Use address style to print addresses.
3112         Use function name style to print executable text symbols.
3113         (expand_symtab_containing_pc): Use data_p.
3114         (find_pc_sect_compunit_symtab): Likewise.
3115
3116 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3117
3118         * breakpoint.c (describe_other_breakpoints): Use address style
3119         to print addresses.
3120         (say_where): Likewise.
3121
3122 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3123
3124         * ada-typeprint.c (print_func_type): Print function name
3125         style to print function name.
3126         * c-typeprint.c (c_print_type_1): Likewise.
3127
3128 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3129
3130         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3131         for execve.
3132
3133 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3134
3135         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3136         type_stack.
3137
3138 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3139
3140         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3141         TYPE_CODE_REF types.
3142
3143 2019-02-08  Jim Wilson  <jimw@sifive.com>
3144
3145         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3146         (riscv_linux_fregset): New.
3147         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3148
3149 2019-02-07  Tom Tromey  <tom@tromey.com>
3150
3151         * thread.c (thread_cancel_execution_command): Update.
3152         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3153         methods.
3154         (struct thread_fsm_ops): Remove.
3155         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3156         (thread_fsm_should_stop, thread_fsm_return_value)
3157         (thread_fsm_set_finished, thread_fsm_finished_p)
3158         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3159         Don't declare.
3160         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3161         * infrun.c (clear_proceed_status_thread)
3162         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3163         (print_stop_event): Update.
3164         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3165         Add constructor.
3166         (step_command_fsm_ops): Remove.
3167         (new_step_command_fsm): Remove.
3168         (step_1): Update.
3169         (step_command_fsm::should_stop): Rename from
3170         step_command_fsm_should_stop.
3171         (step_command_fsm::clean_up): Rename from
3172         step_command_fsm_clean_up.
3173         (step_command_fsm::do_async_reply_reason): Rename from
3174         step_command_fsm_async_reply_reason.
3175         (struct until_next_fsm): Inherit from thread_fsm.  Add
3176         constructor.
3177         (until_next_fsm_ops): Remove.
3178         (new_until_next_fsm): Remove.
3179         (until_next_fsm::should_stop): Rename from
3180         until_next_fsm_should_stop.
3181         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3182         (until_next_fsm::do_async_reply_reason): Rename from
3183         until_next_fsm_async_reply_reason.
3184         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3185         constructor.  Change type of breakpoint.
3186         (finish_command_fsm_ops): Remove.
3187         (new_finish_command_fsm): Remove.
3188         (finish_command_fsm::should_stop): Rename from
3189         finish_command_fsm_should_stop.
3190         (finish_command_fsm::clean_up): Rename from
3191         finish_command_fsm_clean_up.
3192         (finish_command_fsm::return_value): Rename from
3193         finish_command_fsm_return_value.
3194         (finish_command_fsm::do_async_reply_reason): Rename from
3195         finish_command_fsm_async_reply_reason.
3196         (finish_command): Update.
3197         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3198         Add constructor.
3199         (call_thread_fsm_ops): Remove.
3200         (call_thread_fsm::call_thread_fsm): Rename from
3201         new_call_thread_fsm.
3202         (call_thread_fsm::should_stop): Rename from
3203         call_thread_fsm_should_stop.
3204         (call_thread_fsm::should_notify_stop): Rename from
3205         call_thread_fsm_should_notify_stop.
3206         (run_inferior_call, call_function_by_hand_dummy): Update.
3207         * cli/cli-interp.c (should_print_stop_to_console): Update.
3208         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3209         Add constructor.  Change type of location_breakpoint,
3210         caller_breakpoint.
3211         (until_break_fsm_ops): Remove.
3212         (new_until_break_fsm): Remove.
3213         (until_break_fsm::should_stop): Rename from
3214         until_break_fsm_should_stop.
3215         (until_break_fsm::clean_up): Rename from
3216         until_break_fsm_clean_up.
3217         (until_break_fsm::do_async_reply_reason): Rename from
3218         until_break_fsm_async_reply_reason.
3219         (until_break_command): Update.
3220         * thread-fsm.c: Remove.
3221         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3222
3223 2019-02-07  Tom Tromey  <tom@tromey.com>
3224
3225         * yy-remap.h: Add include guard.
3226         * xtensa-tdep.h: Add include guard.
3227         * xcoffread.h: Rename include guard.
3228         * varobj-iter.h: Add include guard.
3229         * tui/tui.h: Rename include guard.
3230         * tui/tui-winsource.h: Rename include guard.
3231         * tui/tui-wingeneral.h: Rename include guard.
3232         * tui/tui-windata.h: Rename include guard.
3233         * tui/tui-win.h: Rename include guard.
3234         * tui/tui-stack.h: Rename include guard.
3235         * tui/tui-source.h: Rename include guard.
3236         * tui/tui-regs.h: Rename include guard.
3237         * tui/tui-out.h: Rename include guard.
3238         * tui/tui-layout.h: Rename include guard.
3239         * tui/tui-io.h: Rename include guard.
3240         * tui/tui-hooks.h: Rename include guard.
3241         * tui/tui-file.h: Rename include guard.
3242         * tui/tui-disasm.h: Rename include guard.
3243         * tui/tui-data.h: Rename include guard.
3244         * tui/tui-command.h: Rename include guard.
3245         * tic6x-tdep.h: Add include guard.
3246         * target/waitstatus.h: Rename include guard.
3247         * target/wait.h: Rename include guard.
3248         * target/target.h: Rename include guard.
3249         * target/resume.h: Rename include guard.
3250         * target-float.h: Rename include guard.
3251         * stabsread.h: Add include guard.
3252         * rs6000-tdep.h: Add include guard.
3253         * riscv-fbsd-tdep.h: Add include guard.
3254         * regformats/regdef.h: Rename include guard.
3255         * record.h: Rename include guard.
3256         * python/python.h: Rename include guard.
3257         * python/python-internal.h: Rename include guard.
3258         * python/py-stopevent.h: Rename include guard.
3259         * python/py-ref.h: Rename include guard.
3260         * python/py-record.h: Rename include guard.
3261         * python/py-record-full.h: Rename include guard.
3262         * python/py-record-btrace.h: Rename include guard.
3263         * python/py-instruction.h: Rename include guard.
3264         * python/py-events.h: Rename include guard.
3265         * python/py-event.h: Rename include guard.
3266         * procfs.h: Add include guard.
3267         * proc-utils.h: Add include guard.
3268         * p-lang.h: Add include guard.
3269         * or1k-tdep.h: Rename include guard.
3270         * observable.h: Rename include guard.
3271         * nto-tdep.h: Rename include guard.
3272         * nat/x86-linux.h: Rename include guard.
3273         * nat/x86-linux-dregs.h: Rename include guard.
3274         * nat/x86-gcc-cpuid.h: Add include guard.
3275         * nat/x86-dregs.h: Rename include guard.
3276         * nat/x86-cpuid.h: Rename include guard.
3277         * nat/ppc-linux.h: Rename include guard.
3278         * nat/mips-linux-watch.h: Rename include guard.
3279         * nat/linux-waitpid.h: Rename include guard.
3280         * nat/linux-ptrace.h: Rename include guard.
3281         * nat/linux-procfs.h: Rename include guard.
3282         * nat/linux-osdata.h: Rename include guard.
3283         * nat/linux-nat.h: Rename include guard.
3284         * nat/linux-namespaces.h: Rename include guard.
3285         * nat/linux-btrace.h: Rename include guard.
3286         * nat/glibc_thread_db.h: Rename include guard.
3287         * nat/gdb_thread_db.h: Rename include guard.
3288         * nat/gdb_ptrace.h: Rename include guard.
3289         * nat/fork-inferior.h: Rename include guard.
3290         * nat/amd64-linux-siginfo.h: Rename include guard.
3291         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3292         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3293         * nat/aarch64-linux.h: Rename include guard.
3294         * nat/aarch64-linux-hw-point.h: Rename include guard.
3295         * mn10300-tdep.h: Add include guard.
3296         * mips-linux-tdep.h: Add include guard.
3297         * mi/mi-parse.h: Rename include guard.
3298         * mi/mi-out.h: Rename include guard.
3299         * mi/mi-main.h: Rename include guard.
3300         * mi/mi-interp.h: Rename include guard.
3301         * mi/mi-getopt.h: Rename include guard.
3302         * mi/mi-console.h: Rename include guard.
3303         * mi/mi-common.h: Rename include guard.
3304         * mi/mi-cmds.h: Rename include guard.
3305         * mi/mi-cmd-break.h: Rename include guard.
3306         * m2-lang.h: Add include guard.
3307         * location.h: Rename include guard.
3308         * linux-record.h: Rename include guard.
3309         * linux-nat.h: Add include guard.
3310         * linux-fork.h: Add include guard.
3311         * i386-darwin-tdep.h: Rename include guard.
3312         * hppa-linux-offsets.h: Add include guard.
3313         * guile/guile.h: Rename include guard.
3314         * guile/guile-internal.h: Rename include guard.
3315         * gnu-nat.h: Rename include guard.
3316         * gdb-stabs.h: Rename include guard.
3317         * frv-tdep.h: Add include guard.
3318         * f-lang.h: Add include guard.
3319         * event-loop.h: Add include guard.
3320         * darwin-nat.h: Rename include guard.
3321         * cp-abi.h: Rename include guard.
3322         * config/sparc/nm-sol2.h: Rename include guard.
3323         * config/nm-nto.h: Rename include guard.
3324         * config/nm-linux.h: Add include guard.
3325         * config/i386/nm-i386gnu.h: Rename include guard.
3326         * config/djgpp/nl_types.h: Rename include guard.
3327         * config/djgpp/langinfo.h: Rename include guard.
3328         * compile/gcc-cp-plugin.h: Add include guard.
3329         * compile/gcc-c-plugin.h: Add include guard.
3330         * compile/compile.h: Rename include guard.
3331         * compile/compile-object-run.h: Rename include guard.
3332         * compile/compile-object-load.h: Rename include guard.
3333         * compile/compile-internal.h: Rename include guard.
3334         * compile/compile-cplus.h: Rename include guard.
3335         * compile/compile-c.h: Rename include guard.
3336         * common/xml-utils.h: Rename include guard.
3337         * common/x86-xstate.h: Rename include guard.
3338         * common/version.h: Rename include guard.
3339         * common/vec.h: Rename include guard.
3340         * common/tdesc.h: Rename include guard.
3341         * common/selftest.h: Rename include guard.
3342         * common/scoped_restore.h: Rename include guard.
3343         * common/scoped_mmap.h: Rename include guard.
3344         * common/scoped_fd.h: Rename include guard.
3345         * common/safe-iterator.h: Rename include guard.
3346         * common/run-time-clock.h: Rename include guard.
3347         * common/refcounted-object.h: Rename include guard.
3348         * common/queue.h: Rename include guard.
3349         * common/ptid.h: Rename include guard.
3350         * common/print-utils.h: Rename include guard.
3351         * common/preprocessor.h: Rename include guard.
3352         * common/pathstuff.h: Rename include guard.
3353         * common/observable.h: Rename include guard.
3354         * common/netstuff.h: Rename include guard.
3355         * common/job-control.h: Rename include guard.
3356         * common/host-defs.h: Rename include guard.
3357         * common/gdb_wait.h: Rename include guard.
3358         * common/gdb_vecs.h: Rename include guard.
3359         * common/gdb_unlinker.h: Rename include guard.
3360         * common/gdb_unique_ptr.h: Rename include guard.
3361         * common/gdb_tilde_expand.h: Rename include guard.
3362         * common/gdb_sys_time.h: Rename include guard.
3363         * common/gdb_string_view.h: Rename include guard.
3364         * common/gdb_splay_tree.h: Rename include guard.
3365         * common/gdb_setjmp.h: Rename include guard.
3366         * common/gdb_ref_ptr.h: Rename include guard.
3367         * common/gdb_optional.h: Rename include guard.
3368         * common/gdb_locale.h: Rename include guard.
3369         * common/gdb_assert.h: Rename include guard.
3370         * common/filtered-iterator.h: Rename include guard.
3371         * common/filestuff.h: Rename include guard.
3372         * common/fileio.h: Rename include guard.
3373         * common/environ.h: Rename include guard.
3374         * common/common-utils.h: Rename include guard.
3375         * common/common-types.h: Rename include guard.
3376         * common/common-regcache.h: Rename include guard.
3377         * common/common-inferior.h: Rename include guard.
3378         * common/common-gdbthread.h: Rename include guard.
3379         * common/common-exceptions.h: Rename include guard.
3380         * common/common-defs.h: Rename include guard.
3381         * common/common-debug.h: Rename include guard.
3382         * common/cleanups.h: Rename include guard.
3383         * common/buffer.h: Rename include guard.
3384         * common/btrace-common.h: Rename include guard.
3385         * common/break-common.h: Rename include guard.
3386         * cli/cli-utils.h: Rename include guard.
3387         * cli/cli-style.h: Rename include guard.
3388         * cli/cli-setshow.h: Rename include guard.
3389         * cli/cli-script.h: Rename include guard.
3390         * cli/cli-interp.h: Rename include guard.
3391         * cli/cli-decode.h: Rename include guard.
3392         * cli/cli-cmds.h: Rename include guard.
3393         * charset-list.h: Add include guard.
3394         * buildsym-legacy.h: Rename include guard.
3395         * bfin-tdep.h: Add include guard.
3396         * ax.h: Rename include guard.
3397         * arm-linux-tdep.h: Add include guard.
3398         * arm-fbsd-tdep.h: Add include guard.
3399         * arch/xtensa.h: Rename include guard.
3400         * arch/tic6x.h: Add include guard.
3401         * arch/i386.h: Add include guard.
3402         * arch/arm.h: Rename include guard.
3403         * arch/arm-linux.h: Rename include guard.
3404         * arch/arm-get-next-pcs.h: Rename include guard.
3405         * arch/amd64.h: Add include guard.
3406         * arch/aarch64-insn.h: Rename include guard.
3407         * arch-utils.h: Rename include guard.
3408         * annotate.h: Add include guard.
3409         * amd64-darwin-tdep.h: Rename include guard.
3410         * aarch64-linux-tdep.h: Add include guard.
3411         * aarch64-fbsd-tdep.h: Add include guard.
3412         * aarch32-linux-nat.h: Add include guard.
3413
3414 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3415
3416         * macrotab.c (macro_define_internal): New function that
3417         factorizes macro_define_object_internal and macro_define_function
3418         code.
3419         (macro_define_object_internal): Use macro_define_internal.
3420         (macro_define_function): Likewise.
3421
3422 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3423
3424         * macrocmd.c (extract_identifier): Return
3425         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3426         callers.
3427
3428 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3429
3430         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3431
3432 2019-02-05  Tom Tromey  <tom@tromey.com>
3433
3434         * target.c (target_stack::unpush): Move assertion earlier.
3435
3436 2019-01-30  Tom Tromey  <tom@tromey.com>
3437
3438         PR python/23615:
3439         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3440         (gdbpy_parse_and_eval): Likewise.
3441         * python/python-internal.h (gdbpy_allow_threads): New class.
3442
3443 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3444
3445         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3446         (aarch64_fbsd_fpregmap): Move earlier.
3447         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3448         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3449         instead of individual calls to trad_frame_set_reg_addr.
3450         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3451         earlier.
3452         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3453         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3454         instead of individual calls to trad_frame_set_reg_addr.
3455
3456 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3457
3458         * CONTRIBUTE: Replace contribution list with wiki link.
3459
3460 2019-01-25  Tom Tromey  <tom@tromey.com>
3461
3462         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3463
3464 2019-01-25  Tom Tromey  <tom@tromey.com>
3465
3466         * xtensa-linux-nat.c: Fix common/ includes.
3467         * xml-support.h: Fix common/ includes.
3468         * xml-support.c: Fix common/ includes.
3469         * x86-linux-nat.c: Fix common/ includes.
3470         * windows-nat.c: Fix common/ includes.
3471         * varobj.h: Fix common/ includes.
3472         * varobj.c: Fix common/ includes.
3473         * value.c: Fix common/ includes.
3474         * valops.c: Fix common/ includes.
3475         * utils.c: Fix common/ includes.
3476         * unittests/xml-utils-selftests.c: Fix common/ includes.
3477         * unittests/utils-selftests.c: Fix common/ includes.
3478         * unittests/unpack-selftests.c: Fix common/ includes.
3479         * unittests/tracepoint-selftests.c: Fix common/ includes.
3480         * unittests/style-selftests.c: Fix common/ includes.
3481         * unittests/string_view-selftests.c: Fix common/ includes.
3482         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3483         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3484         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3485         * unittests/rsp-low-selftests.c: Fix common/ includes.
3486         * unittests/parse-connection-spec-selftests.c: Fix common/
3487         includes.
3488         * unittests/optional-selftests.c: Fix common/ includes.
3489         * unittests/offset-type-selftests.c: Fix common/ includes.
3490         * unittests/observable-selftests.c: Fix common/ includes.
3491         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3492         * unittests/memrange-selftests.c: Fix common/ includes.
3493         * unittests/memory-map-selftests.c: Fix common/ includes.
3494         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3495         * unittests/function-view-selftests.c: Fix common/ includes.
3496         * unittests/environ-selftests.c: Fix common/ includes.
3497         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3498         * unittests/common-utils-selftests.c: Fix common/ includes.
3499         * unittests/cli-utils-selftests.c: Fix common/ includes.
3500         * unittests/array-view-selftests.c: Fix common/ includes.
3501         * ui-file.c: Fix common/ includes.
3502         * tui/tui-io.c: Fix common/ includes.
3503         * tracepoint.h: Fix common/ includes.
3504         * tracepoint.c: Fix common/ includes.
3505         * tracefile-tfile.c: Fix common/ includes.
3506         * top.h: Fix common/ includes.
3507         * top.c: Fix common/ includes.
3508         * thread.c: Fix common/ includes.
3509         * target/waitstatus.h: Fix common/ includes.
3510         * target/waitstatus.c: Fix common/ includes.
3511         * target.h: Fix common/ includes.
3512         * target.c: Fix common/ includes.
3513         * target-memory.c: Fix common/ includes.
3514         * target-descriptions.c: Fix common/ includes.
3515         * symtab.h: Fix common/ includes.
3516         * symfile.c: Fix common/ includes.
3517         * stap-probe.c: Fix common/ includes.
3518         * spu-linux-nat.c: Fix common/ includes.
3519         * sparc-nat.c: Fix common/ includes.
3520         * source.c: Fix common/ includes.
3521         * solib.c: Fix common/ includes.
3522         * solib-target.c: Fix common/ includes.
3523         * ser-unix.c: Fix common/ includes.
3524         * ser-tcp.c: Fix common/ includes.
3525         * ser-pipe.c: Fix common/ includes.
3526         * ser-base.c: Fix common/ includes.
3527         * selftest-arch.c: Fix common/ includes.
3528         * s12z-tdep.c: Fix common/ includes.
3529         * rust-exp.y: Fix common/ includes.
3530         * rs6000-aix-tdep.c: Fix common/ includes.
3531         * riscv-tdep.c: Fix common/ includes.
3532         * remote.c: Fix common/ includes.
3533         * remote-notif.h: Fix common/ includes.
3534         * remote-fileio.h: Fix common/ includes.
3535         * remote-fileio.c: Fix common/ includes.
3536         * regcache.h: Fix common/ includes.
3537         * regcache.c: Fix common/ includes.
3538         * record-btrace.c: Fix common/ includes.
3539         * python/python.c: Fix common/ includes.
3540         * python/py-type.c: Fix common/ includes.
3541         * python/py-inferior.c: Fix common/ includes.
3542         * progspace.h: Fix common/ includes.
3543         * producer.c: Fix common/ includes.
3544         * procfs.c: Fix common/ includes.
3545         * proc-api.c: Fix common/ includes.
3546         * printcmd.c: Fix common/ includes.
3547         * ppc-linux-nat.c: Fix common/ includes.
3548         * parser-defs.h: Fix common/ includes.
3549         * osdata.c: Fix common/ includes.
3550         * obsd-nat.c: Fix common/ includes.
3551         * nat/x86-linux.c: Fix common/ includes.
3552         * nat/x86-linux-dregs.c: Fix common/ includes.
3553         * nat/x86-dregs.h: Fix common/ includes.
3554         * nat/x86-dregs.c: Fix common/ includes.
3555         * nat/ppc-linux.c: Fix common/ includes.
3556         * nat/mips-linux-watch.h: Fix common/ includes.
3557         * nat/mips-linux-watch.c: Fix common/ includes.
3558         * nat/linux-waitpid.c: Fix common/ includes.
3559         * nat/linux-ptrace.h: Fix common/ includes.
3560         * nat/linux-ptrace.c: Fix common/ includes.
3561         * nat/linux-procfs.c: Fix common/ includes.
3562         * nat/linux-personality.c: Fix common/ includes.
3563         * nat/linux-osdata.c: Fix common/ includes.
3564         * nat/linux-namespaces.c: Fix common/ includes.
3565         * nat/linux-btrace.h: Fix common/ includes.
3566         * nat/linux-btrace.c: Fix common/ includes.
3567         * nat/fork-inferior.c: Fix common/ includes.
3568         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3569         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3570         * nat/aarch64-linux.c: Fix common/ includes.
3571         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3572         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3573         * namespace.h: Fix common/ includes.
3574         * mips-linux-tdep.c: Fix common/ includes.
3575         * minsyms.c: Fix common/ includes.
3576         * mi/mi-parse.h: Fix common/ includes.
3577         * mi/mi-main.c: Fix common/ includes.
3578         * mi/mi-cmd-env.c: Fix common/ includes.
3579         * memrange.h: Fix common/ includes.
3580         * memattr.c: Fix common/ includes.
3581         * maint.h: Fix common/ includes.
3582         * maint.c: Fix common/ includes.
3583         * main.c: Fix common/ includes.
3584         * machoread.c: Fix common/ includes.
3585         * location.c: Fix common/ includes.
3586         * linux-thread-db.c: Fix common/ includes.
3587         * linux-nat.c: Fix common/ includes.
3588         * linux-fork.c: Fix common/ includes.
3589         * inline-frame.c: Fix common/ includes.
3590         * infrun.c: Fix common/ includes.
3591         * inflow.c: Fix common/ includes.
3592         * inferior.h: Fix common/ includes.
3593         * inferior.c: Fix common/ includes.
3594         * infcmd.c: Fix common/ includes.
3595         * inf-ptrace.c: Fix common/ includes.
3596         * inf-child.c: Fix common/ includes.
3597         * ia64-linux-nat.c: Fix common/ includes.
3598         * i387-tdep.c: Fix common/ includes.
3599         * i386-tdep.c: Fix common/ includes.
3600         * i386-linux-tdep.c: Fix common/ includes.
3601         * i386-linux-nat.c: Fix common/ includes.
3602         * i386-go32-tdep.c: Fix common/ includes.
3603         * i386-fbsd-tdep.c: Fix common/ includes.
3604         * i386-fbsd-nat.c: Fix common/ includes.
3605         * guile/scm-type.c: Fix common/ includes.
3606         * guile/guile.c: Fix common/ includes.
3607         * go32-nat.c: Fix common/ includes.
3608         * gnu-nat.c: Fix common/ includes.
3609         * gdbthread.h: Fix common/ includes.
3610         * gdbarch-selftests.c: Fix common/ includes.
3611         * gdb_usleep.c: Fix common/ includes.
3612         * gdb_select.h: Fix common/ includes.
3613         * gdb_bfd.c: Fix common/ includes.
3614         * gcore.c: Fix common/ includes.
3615         * fork-child.c: Fix common/ includes.
3616         * findvar.c: Fix common/ includes.
3617         * fbsd-nat.c: Fix common/ includes.
3618         * event-top.c: Fix common/ includes.
3619         * event-loop.c: Fix common/ includes.
3620         * dwarf2read.c: Fix common/ includes.
3621         * dwarf2loc.c: Fix common/ includes.
3622         * dwarf2-frame.c: Fix common/ includes.
3623         * dwarf-index-cache.c: Fix common/ includes.
3624         * dtrace-probe.c: Fix common/ includes.
3625         * disasm-selftests.c: Fix common/ includes.
3626         * defs.h: Fix common/ includes.
3627         * csky-tdep.c: Fix common/ includes.
3628         * cp-valprint.c: Fix common/ includes.
3629         * cp-support.h: Fix common/ includes.
3630         * cp-support.c: Fix common/ includes.
3631         * corelow.c: Fix common/ includes.
3632         * completer.h: Fix common/ includes.
3633         * completer.c: Fix common/ includes.
3634         * compile/compile.c: Fix common/ includes.
3635         * compile/compile-loc2c.c: Fix common/ includes.
3636         * compile/compile-cplus-types.c: Fix common/ includes.
3637         * compile/compile-cplus-symbols.c: Fix common/ includes.
3638         * command.h: Fix common/ includes.
3639         * cli/cli-dump.c: Fix common/ includes.
3640         * cli/cli-cmds.c: Fix common/ includes.
3641         * charset.c: Fix common/ includes.
3642         * build-id.c: Fix common/ includes.
3643         * btrace.h: Fix common/ includes.
3644         * btrace.c: Fix common/ includes.
3645         * breakpoint.h: Fix common/ includes.
3646         * breakpoint.c: Fix common/ includes.
3647         * ax.h: 
3648         (enum agent_op): Fix common/ includes.
3649         * ax-general.c (struct aop_map): Fix common/ includes.
3650         * ax-gdb.c: Fix common/ includes.
3651         * auxv.c: Fix common/ includes.
3652         * auto-load.c: Fix common/ includes.
3653         * arm-tdep.c: Fix common/ includes.
3654         * arch/riscv.c: Fix common/ includes.
3655         * arch/ppc-linux-common.c: Fix common/ includes.
3656         * arch/i386.c: Fix common/ includes.
3657         * arch/arm.c: Fix common/ includes.
3658         * arch/arm-linux.c: Fix common/ includes.
3659         * arch/arm-get-next-pcs.c: Fix common/ includes.
3660         * arch/amd64.c: Fix common/ includes.
3661         * arch/aarch64.c: Fix common/ includes.
3662         * arch/aarch64-insn.c: Fix common/ includes.
3663         * arch-utils.c: Fix common/ includes.
3664         * amd64-windows-tdep.c: Fix common/ includes.
3665         * amd64-tdep.c: Fix common/ includes.
3666         * amd64-sol2-tdep.c: Fix common/ includes.
3667         * amd64-obsd-tdep.c: Fix common/ includes.
3668         * amd64-nbsd-tdep.c: Fix common/ includes.
3669         * amd64-linux-tdep.c: Fix common/ includes.
3670         * amd64-linux-nat.c: Fix common/ includes.
3671         * amd64-fbsd-tdep.c: Fix common/ includes.
3672         * amd64-fbsd-nat.c: Fix common/ includes.
3673         * amd64-dicos-tdep.c: Fix common/ includes.
3674         * amd64-darwin-tdep.c: Fix common/ includes.
3675         * agent.c: Fix common/ includes.
3676         * ada-lang.h: Fix common/ includes.
3677         * ada-lang.c: Fix common/ includes.
3678         * aarch64-tdep.c: Fix common/ includes.
3679
3680 2019-01-25  Tom Tromey  <tom@tromey.com>
3681
3682         * common/create-version.sh: Use common/version.h.
3683
3684 2019-01-24  Pedro Alves  <palves@redhat.com>
3685
3686         * infrun.c (signal_stop, signal_print, signal_program)
3687         (signal_catch, signal_pass): Now arrays instead of pointers.
3688         (update_signals_program_target, do_target_resume)
3689         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3690         * linux-nat.c (linux_nat_target::pass_signals)
3691         (linux_nat_target::create_inferior, linux_nat_target::attach):
3692         Adjust.
3693         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3694         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3695         * procfs.c (procfs_target::pass_signals): Adjust.
3696         * record-full.c (record_full_target::resume): Adjust.
3697         * remote.c (remote_target::pass_signals)
3698         (remote_target::program_signals): Adjust.
3699         * target-debug.h (target_debug_print_signals): Now takes a
3700         gdb::array_view as parameter.  Adjust.
3701         * target.h (target_ops) <pass_signals, program_signals>: Replace
3702         pointer and length parameters with gdb::array_view.
3703         (target_pass_signals, target_program_signals): Likewise.
3704         * target-delegates.c: Regenerate.
3705
3706 2019-01-24  Pedro Alves  <palves@redhat.com>
3707
3708         * common/forward-scope-exit.h
3709         (forward_scope_exit::forward_scope_exit): Pass arguments to
3710         m_bind_function directly, instead of creating a std::bind and
3711         copying that.
3712
3713 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3714
3715         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3716         for static members.
3717         (pass_in_v_vfp_candidate): Likewise.
3718
3719 2019-01-23  Tom Tromey  <tom@tromey.com>
3720             Pedro Alves  <palves@redhat.com>
3721
3722         * regcache.c (class regcache_invalidator): Remove.
3723         (regcache::raw_write): Use make_scope_exit.
3724
3725 2019-01-23  Tom Tromey  <tom@tromey.com>
3726
3727         * ui-out.h (class ui_out_emit_type): Update comment.
3728
3729 2019-01-23  Tom Tromey  <tom@tromey.com>
3730
3731         * infrun.c (fetch_inferior_event): Update comment.
3732
3733 2019-01-23  Tom Tromey  <tom@tromey.com>
3734             Pedro Alves  <palves@redhat.com>
3735
3736         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3737         parameter.
3738         (fetch_inferior_event): Use SCOPE_EXIT.
3739
3740
3741 2019-01-23  Tom Tromey  <tom@tromey.com>
3742             Pedro Alves  <palves@redhat.com>
3743
3744         * infrun.c (disable_thread_events): Delete.
3745         (stop_all_threads): Use SCOPE_EXIT.
3746
3747 2019-01-23  Tom Tromey  <tom@tromey.com>
3748             Pedro Alves  <palves@redhat.com>
3749
3750         * symfile.c: Include forward-scope-exit.h.
3751         (clear_symtab_users_cleanup): Replace forward declaration with
3752         a FORWARD_SCOPE_EXIT.
3753         (syms_from_objfile_1): Use the forward_scope_exit and
3754         gdb::optional instead of cleanup_function.
3755         (reread_symbols): Use the forward_scope_exit instead of
3756         cleanup_function.
3757         (clear_symtab_users_cleanup): Remove function.
3758
3759 2019-01-23  Tom Tromey  <tom@tromey.com>
3760             Pedro Alves  <palves@redhat.com>
3761
3762         * linux-nat.c: Include scope-exit.h.
3763         (cleanup_target_stop): Remove.
3764         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3765         SCOPE_EXIT.
3766
3767 2019-01-23  Tom Tromey  <tom@tromey.com>
3768             Pedro Alves  <palves@redhat.com>
3769
3770         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3771         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3772
3773 2019-01-23  Tom Tromey  <tom@tromey.com>
3774             Andrew Burgess  <andrew.burgess@embecosm.com>
3775             Pedro Alves  <palves@redhat.com>
3776
3777         * infrun.c (fetch_inferior_event): Use scope_exit.
3778         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3779         * top.c (execute_command): Use scope_exit.
3780         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3781         * utils.c (do_bpstat_clear_actions_cleanup)
3782         (make_bpstat_clear_actions_cleanup): Remove.
3783
3784 2019-01-23  Tom Tromey  <tom@tromey.com>
3785             Pedro Alves  <palves@redhat.com>
3786
3787         * infrun.c: Include "common/scope-exit.h"
3788         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3789         (wait_for_inferior): Use SCOPE_EXIT.
3790         (fetch_inferior_event): Use scope_exit.
3791
3792 2019-01-23  Tom Tromey  <tom@tromey.com>
3793             Pedro Alves  <palves@redhat.com>
3794
3795         * breakpoint.c (create_breakpoint): Remove cleanup.
3796
3797 2019-01-23  Tom Tromey  <tom@tromey.com>
3798             Andrew Burgess  <andrew.burgess@embecosm.com>
3799             Pedro Alves  <palves@redhat.com>
3800
3801 2019-01-23  Pedro Alves  <palves@redhat.com>
3802
3803         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3804
3805 2019-01-23  Pedro Alves  <palves@redhat.com>
3806             Andrew Burgess  <andrew.burgess@embecosm.com>
3807
3808         * gdbthread.h: Include "common/forward-scope-exit.h".
3809         (scoped_finish_thread_state): Redefine custom class in terms of
3810         forward_scope_exit.
3811
3812 2019-01-23  Pedro Alves  <palves@redhat.com>
3813             Andrew Burgess  <andrew.burgess@embecosm.com>
3814
3815         * common/forward-scope-exit.h: New file.
3816
3817 2019-01-23  Pedro Alves  <palves@redhat.com>
3818             Andrew Burgess  <andrew.burgess@embecosm.com>
3819             Tom Tromey  <tom@tromey.com>
3820
3821         * common/scope-exit.h: New file.
3822
3823 2019-01-23  Pedro Alves  <palves@redhat.com>
3824
3825         * common/preprocessor.h (ESC): Rename to ...
3826         (ESC_PARENS): ... this.
3827         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3828         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3829
3830 2019-01-23  Tom Tromey  <tom@tromey.com>
3831
3832         * language.h (class scoped_switch_to_sym_language_if_auto):
3833         Initialize m_lang in both cases.
3834
3835 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3836
3837         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3838         with XCNEW.
3839
3840 2019-01-22  Tom Tromey  <tom@tromey.com>
3841
3842         * corelow.c: Do not include sys/file.h.
3843
3844 2019-01-22  Tom Tromey  <tom@tromey.com>
3845
3846         * tui/tui-wingeneral.h: Include gdb_curses.h.
3847
3848 2019-01-22  Tom Tromey  <tom@tromey.com>
3849
3850         * source-cache.h (class source_cache) <get_source_lines,
3851         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3852
3853 2019-01-22  Tom Tromey  <tom@tromey.com>
3854
3855         * remote-fileio.h (struct remote_target): Declare.
3856
3857 2019-01-22  Tom Tromey  <tom@tromey.com>
3858
3859         * python/py-arch.c: Do not include py-ref.h.
3860         * python/py-bpevent.c: Do not include py-ref.h.
3861         * python/py-cmd.c: Do not include py-ref.h.
3862         * python/py-continueevent.c: Do not include py-ref.h.
3863         * python/py-event.h: Do not include py-ref.h.
3864         * python/py-evtregistry.c: Do not include py-ref.h.
3865         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3866         * python/py-frame.c: Do not include py-ref.h.
3867         * python/py-framefilter.c: Do not include py-ref.h.
3868         * python/py-function.c: Do not include py-ref.h.
3869         * python/py-infevents.c: Do not include py-ref.h.
3870         * python/py-linetable.c: Do not include py-ref.h.
3871         * python/py-objfile.c: Do not include py-ref.h.
3872         * python/py-param.c: Do not include py-ref.h.
3873         * python/py-prettyprint.c: Do not include py-ref.h.
3874         * python/py-progspace.c: Do not include py-ref.h.
3875         * python/py-symbol.c: Do not include py-ref.h.
3876         * python/py-symtab.c: Do not include py-ref.h.
3877         * python/py-type.c: Do not include py-ref.h.
3878         * python/py-unwind.c: Do not include py-ref.h.
3879         * python/py-utils.c: Do not include py-ref.h.
3880         * python/py-value.c: Do not include py-ref.h.
3881         * python/py-varobj.c: Do not include py-ref.h.
3882         * python/py-xmethods.c: Do not include py-ref.h.
3883         * python/python.c: Do not include py-ref.h.
3884         * varobj.c: Do not include py-ref.h.
3885
3886 2019-01-22  Tom Tromey  <tom@tromey.com>
3887
3888         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3889         keyword for bcache.
3890
3891 2019-01-22  Tom Tromey  <tom@tromey.com>
3892
3893         * compile/compile-cplus-types.c: Remove a comment by #include.
3894
3895 2019-01-22  Tom Tromey  <tom@tromey.com>
3896
3897         * compile/gcc-c-plugin.h: Include compile-internal.h.
3898
3899 2019-01-22  Tom Tromey  <tom@tromey.com>
3900
3901         * stabsread.c (EXTERN): Do not define.
3902         (symnum, next_symbol_text_func, processing_gcc_compilation)
3903         (within_function, global_sym_chain, global_stabs)
3904         (previous_stab_code, this_object_header_files)
3905         (n_this_object_header_files)
3906         (n_allocated_this_object_header_files): Define.
3907         * stabsread.h (EXTERN): Never define.  Use "extern".
3908
3909 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3910
3911         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3912         history_value.
3913
3914 2019-01-21  Tom Tromey  <tom@tromey.com>
3915
3916         * ui-out.c: Fix includes.
3917         * tui/tui-source.c: Fix includes.
3918         * target.c: Fix includes.
3919         * remote.c: Fix includes.
3920         * regcache.c: Fix includes.
3921         * python/py-block.c: Fix includes.
3922         * printcmd.c: Fix includes.
3923         * or1k-tdep.c: Fix includes.
3924         * mi/mi-main.c: Fix includes.
3925         * m32r-tdep.c: Fix includes.
3926         * csky-tdep.c: Fix includes.
3927         * compile/compile-cplus-types.c: Fix includes.
3928         * cli/cli-interp.c: Fix includes.
3929
3930 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3931
3932         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3933         for padding.
3934
3935 2019-01-16  Tom Tromey  <tom@tromey.com>
3936
3937         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3938         earlier.
3939         (struct objfile) <msymbols_range>: Move from top level.
3940         <msymbols>: New method.
3941         (class objfile_msymbols): Remove.
3942         * symtab.c (default_collect_symbol_completion_matches_break_on):
3943         Update.
3944         * symmisc.c (dump_msymbols): Update.
3945         * stabsread.c (scan_file_globals): Update.
3946         * objc-lang.c (info_selectors_command, info_classes_command)
3947         (find_methods): Update.
3948         * minsyms.c (find_solib_trampoline_target): Update.
3949         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3950         * coffread.c (coff_symfile_read): Update.
3951         * ada-lang.c (ada_lookup_simple_minsym)
3952         (ada_collect_symbol_completion_matches): Update.
3953
3954 2019-01-16  Tom Tromey  <tom@tromey.com>
3955
3956         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3957         type.  Remove no-argument constructor.
3958         <iterator::operator++>: Simplify.
3959         <begin>: Update.
3960         <end>: Use minimal_symbol_count.
3961
3962 2019-01-16  Tom Tromey  <tom@tromey.com>
3963
3964         * objfiles.h (struct objfile) <psymtabs>: New method.
3965         (class objfile_psymtabs): Remove.
3966         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3967         typedef.
3968         <range>: New method.
3969         (require_partial_symbols): Change return type.
3970         * psymtab.c (require_partial_symbols)
3971         (psym_expand_symtabs_matching): Update.
3972         * mdebugread.c (parse_partial_symbols): Update.
3973         * dbxread.c (dbx_end_psymtab): Update.
3974
3975 2019-01-15  Tom Tromey  <tom@tromey.com>
3976
3977         * symtab.c (lookup_objfile_from_block)
3978         (lookup_symbol_in_objfile_symtabs)
3979         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3980         (find_line_symtab, info_sources_command)
3981         (default_collect_symbol_completion_matches_break_on)
3982         (make_source_files_completion_list): Update.
3983         * symmisc.c (print_objfile_statistics, dump_objfile)
3984         (maintenance_print_symbols, maintenance_info_symtabs)
3985         (maintenance_check_symtabs, maintenance_info_line_tables):
3986         Update.
3987         * source.c (select_source_symtab)
3988         (forget_cached_source_info_for_objfile): Update.
3989         * objfiles.h (class objfile_compunits): Remove.
3990         (struct objfile) <compunits_range>: New typedef.
3991         (compunits): New method.
3992         * objfiles.c (objfile_relocate1): Update.
3993         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3994         * maint.c (count_symtabs_and_blocks): Update.
3995         * linespec.c (iterate_over_all_matching_symtabs): Update.
3996         * cp-support.c (add_symbol_overload_list_qualified): Update.
3997         * coffread.c (coff_symtab_read): Update.
3998         * ada-lang.c (add_nonlocal_symbols)
3999         (ada_collect_symbol_completion_matches)
4000         (ada_add_global_exceptions): Update.
4001
4002 2019-01-15  Tom Tromey  <tom@tromey.com>
4003
4004         * progspace.h (program_space) <objfiles_safe_range>: New
4005         typedef.
4006         <objfiles_safe>: New method.
4007         * objfiles.h (class all_objfiles_safe): Remove.
4008         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4009         * jit.c (jit_inferior_exit_hook): Update.
4010
4011 2019-01-17  Tom Tromey  <tom@tromey.com>
4012
4013         * progspace.h (program_space) <objfiles_range>: New typedef.
4014         <objfiles>: New method.
4015         <objfiles_head>: Rename from objfiles.
4016         (object_files): Update.
4017         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4018         * guile/scm-pretty-print.c
4019         (ppscm_find_pretty_printer_from_objfiles): Update.
4020         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4021         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4022         Update.
4023         * python/py-progspace.c (pspy_get_objfiles): Update.
4024         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4025         Update.
4026         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4027         (objfpy_lookup_objfile_by_build_id): Update.
4028         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4029         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4030         Update.
4031         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4032         (expand_symtab_containing_pc, lookup_objfile_from_block)
4033         (lookup_static_symbol, basic_lookup_transparent_type)
4034         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4035         (find_line_symtab, info_sources_command)
4036         (default_collect_symbol_completion_matches_break_on)
4037         (make_source_files_completion_list, find_main_name): Update.
4038         * symmisc.c (print_symbol_bcache_statistics)
4039         (print_objfile_statistics, maintenance_print_symbols)
4040         (maintenance_print_msymbols, maintenance_print_objfiles)
4041         (maintenance_info_symtabs, maintenance_check_symtabs)
4042         (maintenance_expand_symtabs, maintenance_info_line_tables):
4043         Update.
4044         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4045         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4046         (map_overlay_command, unmap_overlay_command)
4047         (simple_overlay_update, expand_symtabs_matching)
4048         (map_symbol_filenames): Update.
4049         * symfile-debug.c (set_debug_symfile): Update.
4050         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4051         Update.
4052         * source.c (select_source_symtab, forget_cached_source_info):
4053         Update.
4054         * solib.c (solib_read_symbols): Update.
4055         * solib-spu.c (append_ocl_sos): Update.
4056         * psymtab.c (maintenance_print_psymbols)
4057         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4058         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4059         * printcmd.c (info_symbol_command): Update.
4060         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4061         Update.
4062         * objfiles.h (class all_objfiles): Remove.
4063         * objfiles.c (have_partial_symbols, have_full_symbols)
4064         (have_minimal_symbols, qsort_cmp, update_section_map)
4065         (shared_objfile_contains_address_p)
4066         (default_iterate_over_objfiles_in_search_order): Update.
4067         * objc-lang.c (info_selectors_command, info_classes_command)
4068         (find_methods): Update.
4069         * minsyms.c (find_solib_trampoline_target): Update.
4070         * maint.c (maintenance_info_sections)
4071         (maintenance_translate_address, count_symtabs_and_blocks):
4072         Update.
4073         * main.c (captured_main_1): Update.
4074         * linux-thread-db.c (try_thread_db_load_from_pdir)
4075         (has_libpthread): Update.
4076         * linespec.c (iterate_over_all_matching_symtabs)
4077         (search_minsyms_for_name): Update.
4078         * jit.c (jit_find_objf_with_entry_addr): Update.
4079         * hppa-tdep.c (find_unwind_entry)
4080         (hppa_lookup_stub_minimal_symbol): Update.
4081         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4082         Update.
4083         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4084         (elf_gnu_ifunc_resolve_by_got): Update.
4085         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4086         * dwarf-index-write.c (save_gdb_index_command): Update.
4087         * cp-support.c (add_symbol_overload_list_qualified): Update.
4088         * breakpoint.c (create_overlay_event_breakpoint)
4089         (create_longjmp_master_breakpoint)
4090         (create_std_terminate_master_breakpoint)
4091         (create_exception_master_breakpoint): Update.
4092         * blockframe.c (find_pc_partial_function): Update.
4093         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4094         (ada_collect_symbol_completion_matches)
4095         (ada_add_global_exceptions): Update.
4096
4097 2019-01-17  Tom Tromey  <tom@tromey.com>
4098
4099         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4100         declare VEC.
4101         (solib_target_parse_libraries): Change return type.
4102         (library_list_start_segment, library_list_start_section)
4103         (library_list_end_library, library_list_start_library); Update.
4104         (solib_target_free_library_list): Remove.
4105         (solib_target_parse_libraries): Remove cleanup.  Change return
4106         type.
4107         (solib_target_current_sos): Update.
4108
4109 2019-01-17  Tom Tromey  <tromey@bapiya>
4110
4111         * valprint.c: Replace "the the" with "the".
4112         * symtab.c: Replace "the the" with "the".
4113         * solib.c: Replace "the the" with "the".
4114         * solib-dsbt.c: Replace "the the" with "the".
4115         * linespec.c: Replace "the the" with "the".
4116         * dwarf2loc.h: Replace "the the" with "the".
4117         * amd64-windows-tdep.c: Replace "the the" with "the".
4118         * aarch64-tdep.c: Replace "the the" with "the".
4119
4120 2019-01-16  Keith Seitz  <keiths@redhat.com>
4121
4122         PR gdb/23773
4123         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4124         <builder>: Rename to ..
4125         <m_builder>: ... this and make private.
4126         (dwarf2_cu::get_builder): New method.  Change all users of
4127         `builder' to use this method.
4128         (dwarf2_start_symtab): Move to ...
4129         (dwarf2_cu::start_symtab): ... here.  Update all callers
4130         (setup_type_unit_groups): Move to ...
4131         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4132         callers.
4133         (dwarf2_cu::reset_builder): New method.
4134         (process_full_compunit, process_full_type_unit): Use
4135         dwarf2_cu::reset_builder.
4136         (follow_die_offset): Record the ancestor CU if it is different
4137         from the followed DIE's CU.
4138         (follow_die_sig_1): Likewise.
4139
4140 2019-01-15  Tom Tromey  <tom@tromey.com>
4141
4142         * remote.c (class remote_state) <buf>: Now a char_vector.
4143         <buf_size>: Remove.
4144         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4145         parameter.
4146         (remote_target::getpkt_or_notif_sane_1)
4147         (remote_target::getpkt_sane)
4148         (remote_target::getpkt_or_notif_sane): Likewise.
4149         (class remote_target) <putpkt>: New overload.
4150         (remote_target::read_frame): Change type of "buf_p".  Remove
4151         sizeof_p parameter.
4152         (packet_ok): New overload.
4153         (packet_check_result): New overload.
4154         Update all uses.
4155
4156 2019-01-14  Tom Tromey  <tom@tromey.com>
4157
4158         * remote-notif.c (handle_notification, remote_notif_ack)
4159         (remote_notif_parse): Make "buf" const.
4160         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4161         const.
4162         (remote_notif_parse, remote_notif_ack, handle_notification):
4163         Likewise.
4164         * remote.c (remote_notif_stop_parse): Make "buf" const.
4165         (remote_target::remote_parse_stop_reply): Make "buf" const.
4166         (remote_notif_stop_ack): Make "buf" const.
4167
4168 2019-01-14  Tom Tromey  <tom@tromey.com>
4169
4170         * remote.c (remote_console_output): Make parameter const.
4171
4172 2019-01-14  Tom Tromey  <tom@tromey.com>
4173
4174         * target-debug.h (target_debug_print_signals): Constify.
4175         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4176         * procfs.c (procfs_target::pass_signals): Update.
4177         * linux-nat.c (linux_nat_target::pass_signals): Update.
4178         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4179         * target-delegates.c: Rebuild.
4180         * remote.c (remote_target::program_signals): Update.
4181         (remote_target::pass_signals): Update.
4182         * target.c (target_pass_signals): Constify argument.
4183         (target_program_signals): Likewise.
4184         * target.h (struct target_ops) <pass_signals, program_signals>:
4185         Constify argument.
4186         (target_pass_signals, target_program_signals): Constify argument.
4187
4188 2019-01-14  Tom Tromey  <tom@tromey.com>
4189
4190         PR tui/28819:
4191         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4192
4193 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4194
4195         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4196         field.
4197         * rs6000-tdep.c: Include reggroups.h.
4198         (IS_V_ALIAS_PSEUDOREG): Define.
4199         (rs6000_register_name): Return names for the "vX" aliases.
4200         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4201         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4202         aliases.  Call default_register_reggroup_p for all other
4203         pseudo-registers.
4204         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4205         New functions.
4206         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4207         Handle "vX" aliases.
4208         (v_alias_pseudo_register_collect): New function.
4209         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4210         (rs6000_gdbarch_init): Initialize "vX" aliases as
4211         pseudo-registers.  Restore registration of
4212         rs6000_pseudo_register_reggroup_p with
4213         set_tdesc_pseudo_register_reggroup_p.
4214
4215 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4216
4217         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4218         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4219         set_gdbarch_num_pseudo_regs.
4220
4221 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4222
4223         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4224         Remove arg prefixname, add do_set and do_show.
4225         Add member functions set_list and show_list.
4226         * cli/cli-style.c (class cli_style_option): Update accordingly.
4227         (style_set_list): Move to file scope.
4228         (style_show_list): Likewise.
4229         (set_style): Call help_list.
4230         (show_style): Call cmd_show_list.
4231         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4232         Update to use the new macro.
4233
4234 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4235
4236         * ada-lang.c (_initialize_ada_language): Expand the help text
4237         for the "catch exception" command.
4238
4239 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4240
4241         * symtab.c (matching_obj_sections): Initialize obj,
4242         declare it closer to its usage.
4243
4244 2019-01-10  Tom Tromey  <tom@tromey.com>
4245
4246         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4247         (basic_inf_threads_range): Remove.
4248         (inf_threads_range, inf_non_exited_threads_range)
4249         (safe_inf_threads_range): Use next_adapter.
4250
4251 2019-01-10  Keith Seitz  <keiths@redhat.com>
4252
4253         PR gdb/23712
4254         PR symtab/23010
4255         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4256         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4257
4258 2019-01-10  Keith Seitz  <keiths@redhat.com>
4259
4260         PR gdb/23712
4261         PR symtab/23010
4262         * dictionary.c (pending_to_vector): Remove.
4263         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4264         Remove _1 suffix, replacing functions of the same name.  Update
4265         all callers.
4266         (dict_create_hashed, dict_create_hashed_expandable)
4267         (dict_create_linear, dict_create_linear_expandable, dict_free)
4268         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4269         Make functions static.
4270
4271 2019-01-10  Keith Seitz  <keiths@redhat.com>
4272
4273         PR gdb/23712
4274         PR symtab/23010
4275         * dictionary.h (struct dictionary): Replace declaration with
4276         multidictionary.
4277         (dict_create_hashed, dict_create_hashed_expandable)
4278         (dict_create_linear, dict_create_linear_expandable)
4279         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4280         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4281         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4282         taking multidictionary argument.
4283         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4284         * block.h (struct block) <dict>: Change to multidictionary
4285         and rename `multidict'.
4286         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4287         symmisc.c: Update all dictionary references to multidictionary.
4288
4289 2019-01-10  Keith Seitz  <keiths@redhat.com>
4290
4291         PR gdb/23712
4292         PR symtab/23010
4293         * dictionary.c: Include unordered_map.
4294         (pending_to_vector): New function.
4295         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4296         Rewrite the non-"_1" functions to take vector instead
4297         of linked list.
4298         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4299         "new" _1 versions of the same name.
4300         (multidictionary): Define.
4301         (std::hash<enum language): New definition.
4302         (collate_pending_symbols_by_language, mdict_create_hashed)
4303         (mdict_create_hashed_expandable, mdict_create_linear)
4304         (mdict_create_linear_expandable, mdict_free)
4305         (find_language_dictionary, create_new_language_dictionary)
4306         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4307         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4308         (mdict_size, mdict_empty): New functions.
4309         * dictionary.h (mdict_iterator): Define.
4310
4311 2019-01-10  Pedro Alves  <palves@redhat.com>
4312
4313         * breakpoint.c (read_uploaded_action)
4314         (create_tracepoint_from_upload): Adjust to use
4315         gdb::unique_xmalloc_ptr.
4316         * ctf.c (ctf_write_uploaded_tp):
4317         (SET_ARRAY_FIELD): Use emplace_back.
4318         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4319         * tracefile-tfile.c (tfile_write_uploaded_tp):
4320         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4321         gdb::unique_xmalloc_ptr.
4322         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4323         at_string, cond_string, cmd_strings>: Replace char pointers
4324         with gdb::unique_xmalloc_ptr.
4325
4326 2019-01-10  Pedro Alves  <palves@redhat.com>
4327
4328         * solib-target.c (library_list_start_library): Don't xstrdup name.
4329
4330 2019-01-10  Pedro Alves  <palves@redhat.com>
4331
4332         * mdebugread.c (parse_partial_symbols): Use
4333         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4334
4335 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4336
4337         * linux-fork.c (scoped_switch_fork_info)
4338         <~scoped_switch_fork_info>: Fix incorrect variable name.
4339
4340 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4341
4342         * linux-fork.c (scoped_switch_fork_info)
4343         <scoped_switch_fork_info>: Make explicit.
4344         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4345
4346 2019-01-10  Tom Tromey  <tom@tromey.com>
4347
4348         * objfiles.h (objfile::reset_psymtabs): Update.
4349         * objfiles.c (objfile::objfile): Update.
4350         * psymtab.h (psymtab_storage::obstack): Update.
4351         (psymtab_storage::m_obstack): Use gdb::optional.
4352         (class psymtab_storage): Update comment.  Remove objfile
4353         parameter.
4354         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4355
4356 2019-01-10  Tom Tromey  <tom@tromey.com>
4357
4358         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4359         <free_psymtabs>: Now private.
4360         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4361         (allocate_psymtab): Use new method.
4362
4363 2019-01-10  Tom Tromey  <tom@tromey.com>
4364
4365         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4366         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4367         * mdebugread.c (parse_partial_symbols): Use
4368         allocate_dependencies.
4369         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4370         allocate_dependencies.
4371         (process_psymtab_comp_unit_reader)
4372         (build_type_psymtab_dependencies): Likewise.
4373         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4374
4375 2019-01-10  Tom Tromey  <tom@tromey.com>
4376
4377         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4378         PSYMBOL_SET_LANGUAGE.
4379         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4380
4381 2019-01-10  Tom Tromey  <tom@tromey.com>
4382
4383         * psymtab.h (psymtab_storage::obstack): New method.
4384         <m_obstack>: Rename from obstack; now private.
4385         * psymtab.c (psymtab_storage): Update.
4386         * dwarf2read.c (create_addrmap_from_index)
4387         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4388         Update.
4389
4390 2019-01-10  Tom Tromey  <tom@tromey.com>
4391
4392         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4393         * objfiles.h (objfile::reset_psymtabs): New method.
4394
4395 2019-01-10  Tom Tromey  <tom@tromey.com>
4396
4397         * symmisc.c (print_symbol_bcache_statistics): Update.
4398         (print_objfile_statistics): Update.
4399         * symfile.c (reread_symbols): Update.
4400         * psymtab.h (class psymtab_storage): New.
4401         * psymtab.c (psymtab_storage): New constructor.
4402         (~psymtab_storage): New destructor.
4403         (require_partial_symbols): Update.
4404         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4405         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4406         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4407         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4408         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4409         (start_psymtab_common, end_psymtab_common)
4410         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4411         (allocate_psymtab): Update.
4412         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4413         Update.
4414         (dump_psymtab_addrmap, maintenance_print_psymbols)
4415         (maintenance_check_psymtabs): Update.
4416         (class objfile_psymtabs): Move to objfiles.h.
4417         * psympriv.h (discard_psymtab): Now inline.
4418         (psymtab_discarder::psymtab_discarder): Update.
4419         (psymtab_discarder::~psymtab_discarder): Update.
4420         (ALL_OBJFILE_PSYMTABS): Rewrite.
4421         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4422         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4423         Remove fields.
4424         <partial_symtabs>: New field.
4425         (class objfile_psymtabs): Move from psymtab.h.  Update.
4426         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4427         psymbol_cache.
4428         (objfile::~objfile): Don't destroy psymbol_cache.
4429         * mdebugread.c (parse_partial_symbols): Update.
4430         * dwarf2read.c (create_addrmap_from_index)
4431         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4432         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4433         (add_partial_subprogram, dwarf2_ranges_read): Update.
4434         * dwarf-index-write.c (write_address_map)
4435         (write_one_signatured_type, recursively_write_psymbols)
4436         (class debug_names, class debug_names, write_psymtabs_to_index):
4437         Update.
4438
4439 2019-01-10  Tom Tromey  <tom@tromey.com>
4440
4441         * symtab.h (SYMBOL_SET_NAMES): Update.
4442         (symbol_set_names): Update.
4443         (MSYMBOL_SET_NAMES): Update.
4444         * symtab.c (symbol_set_names): Change argument to be an
4445         objfile_per_bfd_storage.
4446         * psymtab.c (add_psymbol_to_bcache): Update.
4447         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4448
4449 2019-01-10  Tom Tromey  <tom@tromey.com>
4450
4451         * symtab.c (create_demangled_names_hash): Change argument to be an
4452         objfile_per_bfd_storage.
4453         (symbol_set_names): Update.
4454
4455 2019-01-10  Tom Tromey  <tom@tromey.com>
4456
4457         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4458         init_psymbol_list.
4459         * psymtab.c (init_psymbol_list): Do nothing if already called.
4460         * psympriv.h (init_psymbol_list): Add comment.
4461         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4462         init_psymbol_list.
4463         * dbxread.c (dbx_symfile_read): Unconditionally call
4464         init_psymbol_list.
4465
4466 2019-01-10  Tom Tromey  <tom@tromey.com>
4467
4468         * xcoffread.c (scan_xcoff_symtab): Update.
4469         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4470         "where".
4471         * mdebugread.c (parse_partial_symbols)
4472         (handle_psymbol_enumerators): Update.
4473         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4474         * dbxread.c (read_dbx_symtab): Update.
4475         * psympriv.h (psymbol_placement): New enum.
4476         (add_psymbol_to_list): Update.
4477
4478 2019-01-10  Tom Tromey  <tom@tromey.com>
4479
4480         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4481         static_psymbols parameters.
4482         (scan_xcoff_symtab): Update.
4483         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4484         static_psymbols parameters.
4485         * psympriv.h (start_psymtab_common): Update.
4486         * mdebugread.c (parse_partial_symbols): Update.
4487         * dwarf2read.c (create_partial_symtab): Update.
4488         * dbxread.c (read_dbx_symtab): Update.
4489         (start_psymtab): Remove global_psymbols and static_psymbols
4490         parameters.
4491
4492 2019-01-10  Tom Tromey  <tom@tromey.com>
4493
4494         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4495         * psymtab.c (allocate_psymtab): Add comment.
4496         * psympriv.h (allocate_psymtab): Add comment.
4497         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4498         initializations.
4499         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4500
4501 2019-01-10  Tom Tromey  <tom@tromey.com>
4502
4503         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4504         Don't declare.
4505         * mipsread.c: Include mdebugread.h.
4506         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4507         Declare.
4508         * elfread.c: Include mdebugread.h.
4509
4510 2019-01-09  Tom Tromey  <tom@tromey.com>
4511
4512         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4513         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4514         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4515         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4516         (psym_lookup_symbol, psym_find_last_source_symtab)
4517         (psym_forget_cached_source_info, psym_print_stats)
4518         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4519         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4520         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4521         (psym_find_compunit_symtab_by_address)
4522         (maintenance_print_psymbols, maintenance_info_psymtabs)
4523         (maintenance_check_psymtabs): Use ranged for.
4524         * psymtab.h (class objfile_psymtabs): New.
4525         (require_partial_symbols): Return objfile_psymtabs.
4526         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4527
4528 2019-01-09  Tom Tromey  <tom@tromey.com>
4529
4530         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4531         (find_pc_mapped_section, list_overlays_command)
4532         (map_overlay_command, unmap_overlay_command)
4533         (simple_overlay_update): Use all_objfiles.
4534         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4535         * printcmd.c (info_symbol_command): Use all_objfiles.
4536         * objfiles.h (ALL_OBJSECTIONS): Remove.
4537         * maint.c (maintenance_translate_address): Use all_objfiles.
4538         * gcore.c (gcore_create_callback): Use all_objfiles.
4539         (objfile_find_memory_regions): Likewise.
4540
4541 2019-01-09  Tom Tromey  <tom@tromey.com>
4542
4543         * symtab.c (find_line_symtab, info_sources_command)
4544         (make_source_files_completion_list): Use objfile_compunits.
4545         * source.c (select_source_symtab): Use objfile_compunits.
4546         * objfiles.h (struct objfile): Update comment.
4547         (ALL_OBJFILES): Remove.
4548         (ALL_FILETABS): Remove.
4549         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4550         objfile_compunits.
4551
4552 2019-01-09  Tom Tromey  <tom@tromey.com>
4553
4554         * symmisc.c (print_objfile_statistics, dump_objfile)
4555         (maintenance_print_symbols): Use compunit_filetabs.
4556         * source.c (forget_cached_source_info_for_objfile): Use
4557         compunit_filetabs.
4558         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4559         (ALL_FILETABS): Use compunit_filetabs.
4560         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4561         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4562
4563 2019-01-09  Tom Tromey  <tom@tromey.com>
4564
4565         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4566         (compunit_filetabs): New.
4567         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4568         compunit_filetabs.
4569         (info_sources_command, make_source_files_completion_list): Remove
4570         declaration.
4571         * symmisc.c (print_objfile_statistics, dump_objfile)
4572         (maintenance_print_symbols): Remove declaration.
4573         (maintenance_info_symtabs): Use compunit_filetabs.
4574         (maintenance_info_line_tables): Likewise.
4575         * source.c (select_source_symtab): Change local variable name.
4576         (forget_cached_source_info_for_objfile): Remove declaration.
4577         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4578         * objfiles.c (objfile_relocate1): Remove declaration.
4579         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4580         declaration.
4581         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4582         * coffread.c (coff_symtab_read): Remove declaration.
4583         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4584         compunit_filetabs.
4585
4586 2019-01-09  Tom Tromey  <tom@tromey.com>
4587
4588         * symtab.c (lookup_objfile_from_block)
4589         (find_pc_sect_compunit_symtab, search_symbols)
4590         (default_collect_symbol_completion_matches_break_on): Use
4591         objfile_compunits.
4592         * objfiles.h (ALL_COMPUNITS): Remove.
4593         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4594         * cp-support.c (add_symbol_overload_list_qualified): Use
4595         objfile_compunits.
4596         * ada-lang.c (ada_collect_symbol_completion_matches)
4597         (ada_add_global_exceptions): Use objfile_compunits.
4598
4599 2019-01-09  Tom Tromey  <tom@tromey.com>
4600
4601         * source.c (select_source_symtab)
4602         (forget_cached_source_info_for_objfile): Remove declaration.
4603         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4604         declaration.
4605         * maint.c (count_symtabs_and_blocks): Remove declaration.
4606         * cp-support.c (add_symbol_overload_list_qualified): Remove
4607         declaration.
4608         * coffread.c (coff_symtab_read): Remove declaration.
4609         * symtab.c (lookup_symbol_in_objfile_symtabs)
4610         (basic_lookup_transparent_type_1): Use objfile_compunits.
4611         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4612         (info_sources_command, search_symbols)
4613         (default_collect_symbol_completion_matches_break_on)
4614         (make_source_files_completion_list): Remove declaration.
4615         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4616         (ada_collect_symbol_completion_matches)
4617         (ada_add_global_exceptions): Remove declaration.
4618         * linespec.c (iterate_over_all_matching_symtabs): Use
4619         objfile_compunits.
4620         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4621         (class objfile_compunits): New.
4622         (ALL_COMPUNITS): Use objfile_compunits.
4623         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4624         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4625         objfile_compunits.
4626         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4627
4628 2019-01-09  Tom Tromey  <tom@tromey.com>
4629
4630         * symtab.c (search_symbols)
4631         (default_collect_symbol_completion_matches_break_on): Use
4632         objfile_msymbols.
4633         * ada-lang.c (ada_lookup_simple_minsym)
4634         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4635         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4636         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4637         objfile_msymbols.
4638         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4639         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4640         * objc-lang.c (find_methods): Use objfile_msymbols.
4641         (info_selectors_command, info_classes_command): Likewise.
4642         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4643         * objfiles.h (class objfile_msymbols): New.
4644         (ALL_OBJFILE_MSYMBOLS): Remove.
4645         (ALL_MSYMBOLS): Remove.
4646
4647 2019-01-09  Tom Tromey  <tom@tromey.com>
4648
4649         * common/next-iterator.h (next_adapter): Add Iterator template
4650         parameter.
4651         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4652         (class all_objfiles_safe): New.
4653         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4654         * objfiles.c (put_objfile_before): Update comment.
4655         (add_separate_debug_objfile): Likewise.
4656         (free_all_objfiles): Use all_objfiles_safe.
4657         (objfile_purge_solibs): Likewise.
4658
4659 2019-01-09  Tom Tromey  <tom@tromey.com>
4660
4661         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4662         (expand_symtab_containing_pc, lookup_static_symbol)
4663         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4664         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4665         all_objfiles.
4666         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4667         * breakpoint.c (create_overlay_event_breakpoint)
4668         (create_longjmp_master_breakpoint)
4669         (create_std_terminate_master_breakpoint)
4670         (create_exception_master_breakpoint): Use all_objfiles.
4671         * linux-thread-db.c (try_thread_db_load_from_pdir)
4672         (has_libpthread): Use all_objfiles.
4673         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4674         * linespec.c (iterate_over_all_matching_symtabs)
4675         (search_minsyms_for_name): Use all_objfiles.
4676         * maint.c (maintenance_info_sections): Use all_objfiles.
4677         * main.c (captured_main_1): Use all_objfiles.
4678         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4679         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4680         * guile/scm-pretty-print.c
4681         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4682         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4683         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4684         (maintenance_print_msymbols): Use all_objfiles.
4685         * source.c (select_source_symtab): Use all_objfiles.
4686         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4687         * symfile.c (remove_symbol_file_command)
4688         (expand_symtabs_matching, map_symbol_filenames): Use
4689         all_objfiles.
4690         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4691         all_objfiles.
4692         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4693         * objc-lang.c (find_methods): Use all_objfiles.
4694         * objfiles.c (have_partial_symbols, have_full_symbols)
4695         (have_minimal_symbols, qsort_cmp)
4696         (default_iterate_over_objfiles_in_search_order): Use
4697         all_objfiles.
4698         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4699         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4700         (maintenance_check_psymtabs): Use all_objfiles.
4701         (ALL_PSYMTABS): Remove.
4702         * compile/compile-object-run.c (do_module_cleanup): Use
4703         all_objfiles.
4704         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4705         * cp-support.c (add_symbol_overload_list_qualified): Use
4706         all_objfiles.
4707         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4708         Use all_objfiles.
4709         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4710         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4711         all_objfiles.
4712         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4713         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4714         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4715         Uses all_objfiles.
4716         * solib.c (solib_read_symbols): Use all_objfiles
4717
4718 2019-01-09  Tom Tromey  <tom@tromey.com>
4719
4720         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4721         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4722         all_objfiles.
4723         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4724         * symmisc.c (print_symbol_bcache_statistics)
4725         (print_objfile_statistics, maintenance_print_objfiles)
4726         (maintenance_info_symtabs, maintenance_check_symtabs)
4727         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4728         all_objfiles.
4729         * source.c (forget_cached_source_info): Use all_objfiles.
4730         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4731         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4732         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4733         * objfiles.c (update_section_map): Use all_objfiles.
4734         (shared_objfile_contains_address_p): Likewise.
4735         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4736         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4737
4738 2019-01-09  Tom Tromey  <tom@tromey.com>
4739
4740         * common/next-iterator.h: New file.
4741         * objfiles.h (class all_objfiles): New.
4742         (struct objfile_iterator): New.
4743
4744 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4745
4746         * NEWS: Move the description of the changed "frame", "select-frame",
4747          and "info frame" commands to the Changed commands section.
4748
4749 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4750
4751         * gdbtypes.c (check_stub_method_group): Remove handling of old
4752         mangling schemes.
4753         * linespec.c (find_methods): Likewise.
4754         * stabsread.c (read_member_functions): Likewise.
4755         * valops.c (search_struct_method): Likewise.
4756         (value_struct_elt_for_reference): Likewise.
4757         * NEWS: Mention this change.
4758
4759 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4760
4761         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4762         print_source_lines.
4763         * source.c (print_source_lines_base): Update line number check.
4764         (print_source_lines): New function.
4765         (source_lines_range::source_lines_range): New function.
4766         * source.h (class source_lines_range): New class.
4767         (print_source_lines): New declaration.
4768
4769 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4770
4771         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4772
4773 2019-01-08  Tom Tromey  <tom@tromey.com>
4774             Simon Marchi  <simon.marchi@ericsson.com>
4775
4776         PR gdb/24060
4777         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4778         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4779         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4780         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4781         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4782         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4783
4784 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4785
4786         * source.c (select_source_symtab): Move header comment to
4787         declaration in source.h.
4788         (forget_cached_source_info_for_objfile): Likewise.
4789         (forget_cached_source_info): Likewise.
4790         (identify_source_line): Likewise.
4791         * source.h (identify_source_line): Move declaration from symtab.h
4792         and add comment from source.c
4793         (print_source_lines): Likewise.
4794         (forget_cached_source_info_for_objfile): Likewise.
4795         (forget_cached_source_info): Likewise.
4796         (select_source_symtab): Likewise.
4797         (enum print_source_lines_flag): Move definition from symtab.h.
4798         * symtab.h (identify_source_line): Move declaration to source.h.
4799         (print_source_lines): Likewise.
4800         (forget_cached_source_info_for_objfile): Likewise.
4801         (forget_cached_source_info): Likewise.
4802         (select_source_symtab): Likewise.
4803         (enum print_source_lines_flag): Move definition to source.h.
4804         * tui/tui-hooks.c: Add 'source.h' include.
4805
4806 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4807
4808         * source.c (print_source_lines_base): Handle requests to print
4809         reverse line number sequences, and guard against empty lines
4810         string.
4811
4812 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4813
4814         * source.c (print_source_lines_base): Fix skip of '\r' if next
4815         character is '\n'.
4816
4817 2019-01-06  Tom Tromey  <tom@tromey.com>
4818
4819         * c-exp.y (struct c_parse_state) <macro_original_text,
4820         expansion_obstack>: New member.
4821         (macro_original_text, expansion_obstack): Remove globals.
4822         (scan_macro_expansion, scanning_macro_expansion)
4823         (finished_macro_expansion): Update.
4824         (scan_macro_cleanup): Remove.
4825         (yylex, c_parse): Update.
4826
4827 2019-01-06  Tom Tromey  <tom@tromey.com>
4828
4829         * c-exp.y (struct c_parse_state) <strings>: New member.
4830         (operator_stoken): Update.
4831
4832 2019-01-06  Tom Tromey  <tom@tromey.com>
4833
4834         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4835         (union type_stack_elt) <typelist_val>: Now a pointer to
4836         std::vector.
4837         (type_stack_cleanup): Don't declare.
4838         (push_typelist): Update.
4839         * parse.c (pop_typelist): Return a std::vector.
4840         (push_typelist): Take a std::vector.
4841         (follow_types): Update.  Do not free args.
4842         (type_stack_cleanup): Remove.
4843         * c-exp.y (struct c_parse_state): New.
4844         (cpstate): New global.
4845         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4846         (nonempty_typelist): Update.
4847         (func_mod): Create a new vector.
4848         (c_parse): Create a c_parse_state.
4849         (check_parameter_typelist): Do not delete params.
4850         (function_method): Update.  Do not delete type_list.
4851
4852 2019-01-06  Tom Tromey  <tom@tromey.com>
4853
4854         PR gdb/28155:
4855         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4856         check_typedef.
4857         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4858         (print_return_value): Likewise.
4859
4860 2019-01-05  Tom Tromey  <tom@tromey.com>
4861
4862         * contrib/cleanup_check.py: Remove.
4863         * contrib/gcc-with-excheck: Remove.
4864         * contrib/exsummary.py: Remove.
4865         * contrib/excheck.py: Remove.
4866
4867 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4868
4869         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4870         NULL. Initialize tpprev to NULL instead of assigning it
4871         to NULL on the next statement.
4872         * windows-nat.c (windows_delete_thread): Remove check for
4873         main_thread_id before printing thread exit notifications.
4874         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4875         Remove thread ID check against main_thread_id.
4876         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4877         windows_delete_thread.
4878         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4879
4880 2019-01-04  Tom Tromey  <tom@tromey.com>
4881
4882         * compile/compile.c (_initialize_compile): Use upper case for
4883         metasyntactic variables.
4884         * symmisc.c (_initialize_symmisc): Use upper case for
4885         metasyntactic variables.
4886         * psymtab.c (_initialize_psymtab): Use upper case for
4887         metasyntactic variables.
4888         * demangle.c (demangle_command): Use upper case for metasyntactic
4889         variables.
4890         (_initialize_demangler): Likewise.
4891         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4892         variables.
4893
4894 2019-01-03  Tom Tromey  <tom@tromey.com>
4895
4896         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4897
4898 2019-01-03  Tom Tromey  <tom@tromey.com>
4899
4900         * python/py-symtab.c (salpy_str): Update.
4901         (struct salpy_sal_object) <symtab>: Now a PyObject.
4902         (salpy_dealloc): Update.
4903         (del_objfile_sal): Use gdbpy_ref.
4904
4905 2019-01-03  Tom Tromey  <tom@tromey.com>
4906
4907         * python/py-type.c (convert_field): Use new_reference.  Return
4908         gdbpy_ref.
4909         (make_fielditem): Return gdbpy_ref.
4910         (typy_fields): Update.
4911         (typy_getitem): Update.
4912         (field_name): Return gdbpy_ref.  Use new_reference.
4913         (typy_iterator_iternext): Update.
4914
4915 2019-01-03  Tom Tromey  <tom@tromey.com>
4916
4917         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4918
4919 2019-01-03  Tom Tromey  <tom@tromey.com>
4920
4921         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4922         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4923         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4924         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4925         (pspy_set_type_printers): Likewise.
4926         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4927         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4928         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4929         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4930         (objfpy_set_type_printers): Likewise.
4931
4932 2019-01-03  Tom Tromey  <tom@tromey.com>
4933
4934         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4935         (gdbpy_print_stack): Use gdbpy_err_fetch.
4936         * python/python-internal.h (class gdbpy_err_fetch): New class.
4937         (class gdbpy_enter) <m_error_type, m_error_value,
4938         m_error_traceback>: Remove.
4939         <m_error>: New member.
4940         (gdbpy_exception_to_string): Don't declare.
4941         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4942         * python/py-value.c (convert_value_from_python): Use
4943         gdbpy_err_fetch.
4944         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4945         gdbpy_exception_to_string.
4946         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4947         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4948         gdbpy_err_fetch.
4949
4950 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4951
4952         * linux-nat.c (delete_lwp_cleanup): Delete.
4953         (struct lwp_deleter): New struct.
4954         (lwp_info_up): New typedef.
4955         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4956         lwp_info_up.
4957
4958 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4959
4960         * linux-fork.c (class scoped_switch_fork_info): New class.
4961         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4962
4963 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4964
4965         * valops.c (find_overload_match): Remove use of null_cleanup, and
4966         calls to do_cleanups.
4967
4968 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * compile/compile-cplus-types.c
4971         (compile_cplus_instance::decl_name): Handle changes to
4972         cp_func_name.
4973         * cp-support.c (cp_func_name): Update header comment, update
4974         return type.
4975         * cp-support.h (cp_func_name): Update return type in declaration.
4976         * valops.c (find_overload_match): Move temp_func local to top
4977         level of function and change its type.  Use temp_func to hold and
4978         delete temporary string obtained from cp_func_name.
4979
4980 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4981
4982         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4983         gdb::char_vector, remove cleanup, and update uses of `msg`.
4984
4985 2019-01-03  Jim Wilson  <jimw@sifive.com>
4986
4987         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4988
4989 2019-01-02  Tom Tromey  <tom@tromey.com>
4990
4991         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4992         (tdesc_parse_xml): Remove cleanups.
4993         * target-descriptions.h (make_cleanup_free_target_description):
4994         Don't declare.
4995         (target_desc_deleter): New struct.
4996         (target_desc_up): New typedef.
4997         * target-descriptions.c (target_desc_deleter::operator()): Rename
4998         from free_target_description.
4999         (make_cleanup_free_target_description): Remove.
5000
5001 2019-01-02  Tom Tromey  <tom@tromey.com>
5002
5003         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5004         constructor, destructor.
5005         (linespec_parser): Remove typedef.
5006         (~linespec_parser): Rename from linespec_parser_delete.
5007         (linespec_lex_to_end, linespec_complete_label)
5008         (linespec_complete): Update.
5009         (decode_line_full): Remove cleanups.
5010         (decode_line_1): Update.
5011
5012 2019-01-02  Tom Tromey  <tom@tromey.com>
5013
5014         * python/python-internal.h (inferior_to_inferior_object): Change
5015         return type.
5016         * python/py-exitedevent.c (create_exited_event_object): Update.
5017         * python/py-inferior.c (inferior_to_inferior_object): Return
5018         gdbpy_ref.
5019         (python_new_inferior, python_inferior_deleted)
5020         (thread_to_thread_object, delete_thread_object)
5021         (build_inferior_list, gdbpy_selected_inferior): Update.
5022         * python/py-infthread.c (create_thread_object): Update.  Also fail
5023         if inferior_to_inferior_object fails.
5024
5025 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5026
5027         * inferior.h (class inferior) <displaced_step_state>: New field.
5028         * infrun.h (struct displaced_step_state): Move here from
5029         infrun.c.  Initialize fields, add constructor.
5030         <inf>: Remove field.
5031         <reset>: New method.
5032         * infrun.c (struct displaced_step_inferior_state): Move to
5033         infrun.h.
5034         (displaced_step_inferior_states): Remove.
5035         (get_displaced_stepping_state): Adust.
5036         (displaced_step_in_progress_any_inferior): Adjust.
5037         (displaced_step_in_progress_thread): Adjust.
5038         (displaced_step_in_progress): Adjust.
5039         (add_displaced_stepping_state): Remove.
5040         (get_displaced_step_closure_by_addr): Adjust.
5041         (remove_displaced_stepping_state): Remove.
5042         (infrun_inferior_exit): Call displaced_step_state.reset.
5043         (use_displaced_stepping): Don't check for NULL.
5044         (displaced_step_prepare_throw): Call
5045         get_displaced_stepping_state.
5046         (displaced_step_fixup): Don't check for NULL.
5047         (prepare_for_detach): Don't check for NULL.
5048
5049 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5050
5051         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5052          in case of call that did not complete.
5053
5054 2019-01-02  Andrey Utkin  <autkin@undo.io>
5055
5056         * symfile.c (find_separate_debug_file): Fix search of debug files for
5057         remote debuggee.
5058
5059 2019-01-02  Tom Tromey  <tom@tromey.com>
5060
5061         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5062         indentation.
5063         * python/py-frame.c (frapy_older): Remove cast.
5064         (frapy_newer): Likewise.
5065         * python/py-breakpoint.c (local_setattro): Remove cast.
5066         * python/py-arch.c (archpy_name): Remove local variable.
5067         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5068
5069 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5070
5071         * unittests/basic_string_view/element_access/char/empty.cc:
5072         Fix year range in copyright header.
5073
5074 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5075
5076         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5077         Delete.
5078         <operator==>: Update with for removed field.
5079         <hash>: Likewise.
5080         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5081         <isa_features>: ...this.
5082         <abi_features>: New field.
5083         (riscv_isa_flen): Update comment.
5084         (riscv_abi_xlen): New declaration.
5085         (riscv_abi_flen): New declaration.
5086         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5087         isa_features.
5088         (riscv_abi_xlen): New function.
5089         (riscv_isa_flen): Update to get answer from isa_features.
5090         (riscv_abi_flen): New function.
5091         (riscv_has_fp_abi): Update to get answer from abi_features.
5092         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5093         xlen and flen.
5094         (riscv_call_info) <xlen, flen>: Update comment.
5095         (riscv_call_arg_struct): Remove invalid assertions
5096         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5097         is removed.
5098         (riscv_gdbarch_init): Gather isa features and abi features
5099         separately, ensure both match on the gdbarch when reusing an old
5100         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5101         a target with 64-bit float hardware.
5102
5103 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5104
5105         * source.c (search_command_helper): Stop reverse search
5106         when line 1 has been searched.
5107
5108 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5109
5110         * record-full.c (record_full_base_target::close): Rewrite
5111         record_full_core_buf_list free logic.
5112
5113 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5114
5115         * break-catch-syscall.c (print_one_catch_syscall): xfree
5116         the last text.
5117
5118 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5119
5120         * top.c (print_gdb_version): Update Copyright year in version
5121         message.
5122
5123 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5124
5125         Update copyright year range in all GDB files.
5126
5127 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5128
5129         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5130
5131 For older changes see ChangeLog-2018.
5132 \f
5133 Local Variables:
5134 mode: change-log
5135 left-margin: 8
5136 fill-column: 74
5137 version-control: never
5138 coding: utf-8
5139 End:
5140