Bump GDB version number to 8.2.91.DATE-git.
[external/binutils.git] / gdb / ChangeLog
1 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2
3         * version.in: Set GDB version number to 8.2.91.DATE-git.
4
5 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6
7         GDB 8.2.91 released.
8
9 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10
11         * version.in: Set GDB version number to 8.2.91.
12
13 2019-03-20  Tom Tromey  <tromey@adacore.com>
14
15         PR gdb/24391
16         * infrun.c (handle_inferior_event): Rename from
17         handle_inferior_event_1.  Create a scoped_value_mark.
18         (handle_inferior_event): Remove.
19
20 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
21
22         * source-cache.c (source_cache::get_source_lines): Re-read
23         fullname after calling open_source_file.
24
25 2019-03-18  Pedro Alves  <palves@redhat.com>
26             Eli Zaretskii <eliz@gnu.org>
27
28         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
29         m_line and m_start_of_line.
30
31 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
32
33         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
34         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
35         it returns a newline.  This fixes a regression in TU mode, whereby
36         the next line is output on the same screen line as the user input.
37
38 2019-03-18  Pedro Alves  <palves@redhat.com>
39
40         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
41         New globals.
42         (apply_style): New, factored out from ...
43         (apply_ansi_escape): ... this.  Handle reverse video mode.
44         (tui_set_reverse_mode): New function.
45         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
46         * tui/tui-winsource.c (tui_show_source_line): Use
47         tui_set_reverse_mode instead of setting A_STANDOUT.
48         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
49         New setter methods.
50
51 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
52
53         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
54         Handle tabs.
55
56 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
57
58         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
59         tui_refill_source_window instead of tui_refresh_win, to update the
60         current execution line.  This fixes redisplay of the current line
61         when stepping through the code with "next" or "step".
62
63 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
64
65         * source-cache.c (source_cache::get_source_lines): Call
66         find_source_lines to initialize s->nlines.  This fixes vertical
67         scrolling of TUI source window when the DOWN arrow is pressed.
68
69 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
70
71         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
72         wclrtoeol in tui_show_source_line".  This reverts changes made in
73         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
74
75 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
76
77         * NEWS: Combine separate "New targets" sections for 8.3.
78
79 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
80
81         The MS-Windows port of ncurses fails to switch to a color pair if
82         one or both of the colors are the implicit default colors.  This
83         change records the default colors when TUI is initialized, and
84         then specifies them explicitly when a color pair uses the default
85         colors.  This allows color styling in TUI mode on MS-Windows.
86
87         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
88         ncurses_norm_attr.
89         (tui_initialize_io) [__MINGW32__]: Record the default terminal
90         colors in ncurses_norm_attr.
91         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
92         "none", replace it with the default color recorded in
93         ncurses_norm_attr.
94
95 2019-03-14  Tom Tromey  <tromey@adacore.com>
96
97         * source-cache.h (class source_cache) <get_source_lines>: Return
98         std::string.
99         * source-cache.c (source_cache::extract_lines): Handle case where
100         first_pos==npos.  Return std::string.
101         (source_cache::get_source_lines): Update.
102
103 2019-03-14  Tom Tromey  <tromey@adacore.com>
104
105         * NEWS: Add item for "style sources" commands.
106         * source-cache.c (source_cache::get_source_lines): Check
107         source_styling.
108         * cli/cli-style.c (source_styling): New global.
109         (_initialize_cli_style): Add "style sources" commands.
110         (show_style_sources): New function.
111         * cli/cli-style.h (source_styling): Declare.
112
113 2019-03-14  Pedro Alves  <palves@redhat.com>
114             Tom Tromey  <tromey@adacore.com>
115
116         * tui/tui-winsource.h (tui_refill_source_window): Declare.
117         * tui/tui-winsource.c (tui_refill_source_window): New function,
118         from...
119         (tui_horizontal_source_scroll): ... here.  Move some logic.
120         * cli/cli-style.c (set_style_enabled): Notify new observable.
121         * tui/tui-hooks.c (tui_redisplay_source): New function.
122         (tui_attach_detach_observers): Attach or detach
123         tui_redisplay_source.
124         * observable.h (source_styling_changed): New observable.
125         * observable.c: Define source_styling_changed observable.
126
127 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
128
129         PR/24325
130         * source-cache.c: #undef open and close, to avoid unresolved
131         externals during linking.
132
133 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
134
135         Support styling on native MS-Windows console
136
137         PR/24315
138         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
139         on MS-Windows if $TERM is not defined.
140
141         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
142
143         * posix-hdep.c (gdb_console_fputs):
144         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
145         functions.
146         * ui-file.h (gdb_console_fputs): Add prototype.
147
148         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
149         back to fputs only if the former returns zero.
150
151 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
152             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
153
154         PR gdb/8527
155         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
156         set_sigint_trap, clear_sigint_trap.
157
158 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
159
160         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
161         for-loop range, to avoid compiler warnings.
162
163         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
164         avoid compiler warnings about unused variables.
165
166 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
167
168         * NEWS: Mention end of support for native debugging on MS-Windows
169         before XP.
170
171 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
172
173         PR gdb/24292
174         * common/netstuff.c:
175         * gdbserver/gdbreplay.c
176         * gdbserver/remote-utils.c:
177         * ser-tcp.c:
178         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
179         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
180         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
181         'getaddrinfo' and 'freeaddrinfo' were not available before
182         Windows XP, and mingw.org's MinGW headers by default define
183         _WIN32_WINNT to 0x500.
184
185 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
186     
187         * NEWS: Note minimum Python version.
188
189 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
190
191         * version.in: Set GDB version number to 8.2.90.DATE-git.
192
193 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
194
195         GDB 8.2.90 released.
196
197 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
198
199         * version.in: Set GDB version number to 8.2.90.
200
201 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
202
203         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
204
205 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
206
207         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
208         * version.in: Bump version to 8.2.90.DATE-git.
209
210 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
211
212         * aix-thread.c (ptid_cmp): Remove unused variable.
213         (get_signaled_thread): Likewise.
214         (store_regs_user_thread): Likewise.
215         (store_regs_kernel_thread): Likewise.
216         (fetch_regs_kernel_thread): Remove shadowed variable.
217
218 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
219
220         * features/riscv/32bit-cpu.xml: Add register numbers.
221         * features/riscv/32bit-fpu.c: Regenerate.
222         * features/riscv/32bit-fpu.xml: Add register numbers.
223         * features/riscv/64bit-cpu.xml: Add register numbers.
224         * features/riscv/64bit-fpu.c: Regenerate.
225         * features/riscv/64bit-fpu.xml: Add register numbers.
226
227 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
228
229         * NEWS: Mention two argument form of gdb.Value constructor.
230         * python/py-value.c (convert_buffer_and_type_to_value): New
231         function.
232         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
233         Add support for handling an optional second argument.  Call
234         convert_buffer_and_type_to_value as appropriate.
235         * python/python-internal.h (Py_buffer_deleter): New struct.
236         (Py_buffer_up): New typedef.
237
238 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
239
240         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
241         instead of releasing ownership.
242
243 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
244
245         * dwarf2read.c (open_and_init_dwp_file): Call
246         elf_numsections instead of bfd_count_sections to initialize
247         dwp_file->num_sections.
248
249 2019-02-25  Tom Tromey  <tromey@adacore.com>
250
251         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
252
253 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
254
255         * gcore.in: Add '--readnever' option when invoking GDB.
256
257 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
258
259         * MAINTAINERS: Update my email address.
260
261 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
262
263         * build-id.c (build_id_to_debug_bfd_1): New function.
264         (build_id_to_debug_bfd): Look for separate debug file in
265         sysroot.
266
267 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
268
269         * gdbarch.sh: Update the copyright year range that is placed into
270         generated files.
271
272 2019-02-22  Keith Seitz  <keiths@redhat.com>
273
274         PR symtab/23853
275         * linespec.c (create_sals_line_offset): Search for the default
276         symtab's filename instead of its fullname.
277
278 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
279
280         * NEWS: Update style defaults.
281
282 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
283
284         * main.c (captured_main_1): Disable styling in batch mode.
285
286 2019-02-20  Tom Tromey  <tom@tromey.com>
287
288         * symtab.c (symtab_symbol_info): Fix typos.
289
290 2019-02-20  Tom Tromey  <tromey@adacore.com>
291
292         * findcmd.c (_initialize_mem_search): Use upper case for
293         metasyntactic variables.
294
295 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
296
297         * aarch64-tdep.c (aarch64_add_reggroups): New function.
298         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
299
300 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
301
302         * top.h (source_file_name): Change to std::string.
303         * top.c (source_file_name): Likewise.
304         (command_line_input): Adjust.
305         * cli/cli-script.c (script_from_file): Adjust.
306
307 2019-02-19  Tom Tromey  <tromey@adacore.com>
308
309         * ravenscar-thread.c
310         (ravenscar_thread_target::update_thread_list): Don't call
311         ada_build_task_list.
312         * ada-lang.h (ada_build_task_list): Don't declare.
313         * ada-tasks.c (struct ada_tasks_inferior_data)
314         <task_list_valid_p>: Now bool.
315         (read_known_tasks, ada_task_list_changed)
316         (ada_tasks_invalidate_inferior_data): Update.
317         (read_known_tasks_array): Return bool.
318         (read_known_tasks_list): Likewise.
319         (read_known_tasks): Return void.
320         (ada_build_task_list): Now static.
321
322 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
323
324         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
325         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
326
327 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
328
329         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
330         variant for ada_tasks_pspace_data_handle and
331         ada_tasks_inferior_data_handle.
332         (ada_tasks_pspace_data_cleanup): New function.
333         (ada_tasks_inferior_data_cleanup): New function.
334
335 2019-02-17  Tom Tromey  <tom@tromey.com>
336
337         * macrotab.h (macro_source_fullname): Return a std::string.
338         * macrotab.c (macro_include, check_for_redefinition)
339         (macro_undef, macro_lookup_definition, foreach_macro)
340         (foreach_macro_in_scope): Update.
341         (macro_source_fullname): Return a std::string.
342         * macrocmd.c (show_pp_source_pos): Update.
343
344 2019-02-17  Tom Tromey  <tom@tromey.com>
345
346         * macrocmd.c (show_pp_source_pos): Style the file names.
347
348 2019-02-17  Tom Tromey  <tom@tromey.com>
349
350         PR tui/24197:
351         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
352
353 2019-02-17  Tom Tromey  <tom@tromey.com>
354
355         * ada-lang.c (user_select_syms): Use filtered printing.
356         * utils.c (wrap_style): New global.
357         (desired_style): Remove.
358         (emit_style_escape): Add stream parameter.
359         (set_output_style, reset_terminal_style, prompt_for_continue):
360         Update.
361         (flush_wrap_buffer): Only flush gdb_stdout.
362         (wrap_here): Set wrap_style.
363         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
364         treat escape sequences as a character.  Change when wrap buffer is
365         flushed.
366         (fputs_styled): Do not set the output style when the default is
367         requested.
368         * ui-style.h (struct ui_file_style) <is_default>: New method.
369         * source.c (print_source_lines_base): Emit escape sequences in one
370         piece.
371
372 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
373
374         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
375         integers and enumeration types.
376
377 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
378
379         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
380         instead of lookup_symbol_in_language
381         (do_exact_match): New function.
382         (ada_get_symbol_name_matcher): Return do_exact_match when
383         doing a verbatim match.
384
385 2019-02-15  Tom Tromey  <tromey@adacore.com>
386
387         * ravenscar-thread.c (ravenscar_thread_target::resume)
388         (ravenscar_thread_target::wait): Special case wildcard requests.
389
390 2019-02-15  Tom Tromey  <tromey@adacore.com>
391
392         * ravenscar-thread.c (base_ptid): Remove.
393         (struct ravenscar_thread_target) <close>: New method.
394         <m_base_ptid>: New member.
395         <update_inferior_ptid, active_task, task_is_currently_active,
396         runtime_initialized>: Declare methods.
397         <ravenscar_thread_target>: Add constructor.
398         (ravenscar_thread_target::task_is_currently_active)
399         (ravenscar_thread_target::update_inferior_ptid)
400         (ravenscar_runtime_initialized): Rename.  Now methods.
401         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
402         (ravenscar_thread_target::update_thread_list): Update.
403         (ravenscar_thread_target::active_task): Now method.
404         (ravenscar_thread_target::store_registers)
405         (ravenscar_thread_target::prepare_to_store)
406         (ravenscar_thread_target::prepare_to_store)
407         (ravenscar_thread_target::mourn_inferior): Update.
408         (ravenscar_inferior_created): Use "new" to create target.
409         (ravenscar_thread_target::get_ada_task_ptid): Update.
410         (_initialize_ravenscar): Don't initialize base_ptid.
411         (ravenscar_ops): Remove global.
412
413 2019-02-15  Tom Tromey  <tromey@adacore.com>
414
415         * target.h (push_target): Declare new overload.
416         * target.c (push_target): New overload, taking an rvalue reference.
417         * remote.c (remote_target::open_1): Use push_target overload.
418         * corelow.c (core_target_open): Use push_target overload.
419
420 2019-02-15  Tom Tromey  <tromey@adacore.com>
421
422         * ravenscar-thread.c (is_ravenscar_task)
423         (ravenscar_task_is_currently_active): Return bool.
424         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
425         (_initialize_ravenscar): Remove "(void)".
426         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
427         Return bool.
428
429 2019-02-15  Tom Tromey  <tromey@adacore.com>
430
431         * ravenscar-thread.c (ravenscar_runtime_initializer)
432         (has_ravenscar_runtime, get_running_thread_id)
433         (ravenscar_thread_target::resume): Fix indentation.
434
435 2019-02-15  Tom Tromey  <tromey@adacore.com>
436
437         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
438         from ravenscar_arch_ops.
439         (sparc_ravenscar_ops::fetch_registers)
440         (sparc_ravenscar_ops::store_registers): Now methods.
441         (sparc_ravenscar_prepare_to_store): Remove.
442         (sparc_ravenscar_ops): Redefine.
443         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
444         methods and destructor.  Remove members.
445         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
446         (ravenscar_thread_target::store_registers)
447         (ravenscar_thread_target::prepare_to_store): Update.
448         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
449         Remove.
450         (struct ppc_ravenscar_powerpc_ops): Derive from
451         ravenscar_arch_ops.
452         (ppc_ravenscar_powerpc_ops::fetch_registers)
453         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
454         (ppc_ravenscar_powerpc_ops): Redefine.
455         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
456         (ppc_ravenscar_e500_ops::fetch_registers)
457         (ppc_ravenscar_e500_ops::store_registers): Now methods.
458         (ppc_ravenscar_e500_ops): Redefine.
459         * aarch64-ravenscar-thread.c
460         (aarch64_ravenscar_generic_prepare_to_store): Remove.
461         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
462         (aarch64_ravenscar_fetch_registers)
463         (aarch64_ravenscar_store_registers): Now methods.
464         (aarch64_ravenscar_ops): Redefine.
465
466 2019-02-15  Tom Tromey  <tromey@adacore.com>
467
468         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
469         (ravenscar_thread_target::stopped_by_hw_breakpoint)
470         (ravenscar_thread_target::stopped_by_watchpoint)
471         (ravenscar_thread_target::stopped_data_address)
472         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
473
474 2019-02-15  Tom Tromey  <tromey@adacore.com>
475
476         * ravenscar-thread.c: Fix some typos.
477
478 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
479             Tom Tromey  <tromey@adacore.com>
480
481         * ada-lang.c (ada_exception_sal): Change addr_string to a
482         std::string.
483         (create_ada_exception_catchpoint): Update.
484
485 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
486             Tom Tromey  <tromey@adacore.com>
487
488         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
489         (bp_location_ops): Remove.
490         (base_breakpoint_allocate_location): Update.
491         (free_bp_location): Update.
492         * ada-lang.c (class ada_catchpoint_location)
493         <ada_catchpoint_location>: Remove ops parameter.
494         (ada_catchpoint_location_dtor): Remove.
495         (ada_catchpoint_location_ops): Remove.
496         (allocate_location_exception): Update.
497         * breakpoint.h (struct bp_location_ops): Remove.
498         (class bp_location) <bp_location>: Remove bp_location_ops
499         parameter.
500         <~bp_location>: Add destructor.
501         <ops>: Remove.
502
503 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
504             Pedro Alves  <palves@redhat.com>
505
506         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
507         'PATH_MAX'.
508
509 2019-02-14  David Michael  <fedora.dm0@gmail.com>
510             Samuel Thibault  <samuel.thibault@gnu.org>
511             Thomas Schwinge  <thomas@codesourcery.com>
512
513         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
514         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
515
516 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
517
518         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
519         (check_empty): Use "const char *".
520
521         * gnu-nat.c (gnu_nat_target::detach): Instead of
522         'detach_inferior (pid)' call
523         'detach_inferior (find_inferior_pid (pid))'.
524
525         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
526         'nat/fork-inferior.o'.
527         * gnu-nat.c: #include "nat/fork-inferior.h".
528
529         * gnu-nat.c (gnu_nat_target::detach): Instead of
530         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
531         * gnu-nat.h: #include "inf-child.h".
532         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
533         'i386_gnu_nat_target::fetch_registers'.
534         (gnu_store_registers): Rename/move to
535         'i386_gnu_nat_target::store_registers'.
536
537         * config/i386/nm-i386gnu.h: Don't "#include" any files.
538         * gnu-nat.h (mach_thread_info): New function.
539         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
540
541         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
542
543 2019-02-14  Frederic Konrad  <konrad@adacore.com>
544
545         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
546
547 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
548
549         * windows-nat.c (windows_add_thread): Add new parameter
550         "main_thread_p" with default value set to false.  Update
551         function documentation as well as all callers.
552         (windows_delete_thread): Likewise.
553         (fake_create_process): Update call to windows_add_thread.
554         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
555         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
556         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
557         call to windows_delete_thread.
558
559 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
560
561         * MAINTAINERS: Add Andrew Burgess as global maintainer.
562
563 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
564
565         * symfile.c (find_separate_debug_file): Use canonical path of
566         sysroot with child_path instead of gdb_sysroot if it is valid.
567
568 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
569
570         * symfile.c (find_separate_debug_file): Use child_path to
571         determine if an object file is under a sysroot.
572
573 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
574
575         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
576         unittests/child-path-selftests.c.
577         * common/pathstuff.c (child_path): New function.
578         * common/pathstuff.h (child_path): New prototype.
579         * unittests/child-path-selftests.c: New file.
580
581 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
582
583         * symfile.c (find_separate_debug_file): Look for separate debug
584         files in debug directories under the sysroot.
585
586 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
587
588         * symtab.h (struct minimal_symbol data_p): New const method.
589         (struct minimal_symbol text_p): Likewise.
590         * symtab.c (output_source_filename): Use file name style
591         to print file name.
592         (print_symbol_info): Likewise.
593         (print_msymbol_info): Use address style to print addresses.
594         Use function name style to print executable text symbols.
595         (expand_symtab_containing_pc): Use data_p.
596         (find_pc_sect_compunit_symtab): Likewise.
597
598 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
599
600         * breakpoint.c (describe_other_breakpoints): Use address style
601         to print addresses.
602         (say_where): Likewise.
603
604 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
605
606         * ada-typeprint.c (print_func_type): Print function name
607         style to print function name.
608         * c-typeprint.c (c_print_type_1): Likewise.
609
610 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
611
612         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
613         for execve.
614
615 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
616
617         * c-exp.y (direct_abs_decl): Use emplace_back to record the
618         type_stack.
619
620 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
621
622         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
623         TYPE_CODE_REF types.
624
625 2019-02-08  Jim Wilson  <jimw@sifive.com>
626
627         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
628         (riscv_linux_fregset): New.
629         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
630
631 2019-02-07  Tom Tromey  <tom@tromey.com>
632
633         * thread.c (thread_cancel_execution_command): Update.
634         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
635         methods.
636         (struct thread_fsm_ops): Remove.
637         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
638         (thread_fsm_should_stop, thread_fsm_return_value)
639         (thread_fsm_set_finished, thread_fsm_finished_p)
640         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
641         Don't declare.
642         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
643         * infrun.c (clear_proceed_status_thread)
644         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
645         (print_stop_event): Update.
646         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
647         Add constructor.
648         (step_command_fsm_ops): Remove.
649         (new_step_command_fsm): Remove.
650         (step_1): Update.
651         (step_command_fsm::should_stop): Rename from
652         step_command_fsm_should_stop.
653         (step_command_fsm::clean_up): Rename from
654         step_command_fsm_clean_up.
655         (step_command_fsm::do_async_reply_reason): Rename from
656         step_command_fsm_async_reply_reason.
657         (struct until_next_fsm): Inherit from thread_fsm.  Add
658         constructor.
659         (until_next_fsm_ops): Remove.
660         (new_until_next_fsm): Remove.
661         (until_next_fsm::should_stop): Rename from
662         until_next_fsm_should_stop.
663         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
664         (until_next_fsm::do_async_reply_reason): Rename from
665         until_next_fsm_async_reply_reason.
666         (struct finish_command_fsm): Inherit from thread_fsm.  Add
667         constructor.  Change type of breakpoint.
668         (finish_command_fsm_ops): Remove.
669         (new_finish_command_fsm): Remove.
670         (finish_command_fsm::should_stop): Rename from
671         finish_command_fsm_should_stop.
672         (finish_command_fsm::clean_up): Rename from
673         finish_command_fsm_clean_up.
674         (finish_command_fsm::return_value): Rename from
675         finish_command_fsm_return_value.
676         (finish_command_fsm::do_async_reply_reason): Rename from
677         finish_command_fsm_async_reply_reason.
678         (finish_command): Update.
679         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
680         Add constructor.
681         (call_thread_fsm_ops): Remove.
682         (call_thread_fsm::call_thread_fsm): Rename from
683         new_call_thread_fsm.
684         (call_thread_fsm::should_stop): Rename from
685         call_thread_fsm_should_stop.
686         (call_thread_fsm::should_notify_stop): Rename from
687         call_thread_fsm_should_notify_stop.
688         (run_inferior_call, call_function_by_hand_dummy): Update.
689         * cli/cli-interp.c (should_print_stop_to_console): Update.
690         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
691         Add constructor.  Change type of location_breakpoint,
692         caller_breakpoint.
693         (until_break_fsm_ops): Remove.
694         (new_until_break_fsm): Remove.
695         (until_break_fsm::should_stop): Rename from
696         until_break_fsm_should_stop.
697         (until_break_fsm::clean_up): Rename from
698         until_break_fsm_clean_up.
699         (until_break_fsm::do_async_reply_reason): Rename from
700         until_break_fsm_async_reply_reason.
701         (until_break_command): Update.
702         * thread-fsm.c: Remove.
703         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
704
705 2019-02-07  Tom Tromey  <tom@tromey.com>
706
707         * yy-remap.h: Add include guard.
708         * xtensa-tdep.h: Add include guard.
709         * xcoffread.h: Rename include guard.
710         * varobj-iter.h: Add include guard.
711         * tui/tui.h: Rename include guard.
712         * tui/tui-winsource.h: Rename include guard.
713         * tui/tui-wingeneral.h: Rename include guard.
714         * tui/tui-windata.h: Rename include guard.
715         * tui/tui-win.h: Rename include guard.
716         * tui/tui-stack.h: Rename include guard.
717         * tui/tui-source.h: Rename include guard.
718         * tui/tui-regs.h: Rename include guard.
719         * tui/tui-out.h: Rename include guard.
720         * tui/tui-layout.h: Rename include guard.
721         * tui/tui-io.h: Rename include guard.
722         * tui/tui-hooks.h: Rename include guard.
723         * tui/tui-file.h: Rename include guard.
724         * tui/tui-disasm.h: Rename include guard.
725         * tui/tui-data.h: Rename include guard.
726         * tui/tui-command.h: Rename include guard.
727         * tic6x-tdep.h: Add include guard.
728         * target/waitstatus.h: Rename include guard.
729         * target/wait.h: Rename include guard.
730         * target/target.h: Rename include guard.
731         * target/resume.h: Rename include guard.
732         * target-float.h: Rename include guard.
733         * stabsread.h: Add include guard.
734         * rs6000-tdep.h: Add include guard.
735         * riscv-fbsd-tdep.h: Add include guard.
736         * regformats/regdef.h: Rename include guard.
737         * record.h: Rename include guard.
738         * python/python.h: Rename include guard.
739         * python/python-internal.h: Rename include guard.
740         * python/py-stopevent.h: Rename include guard.
741         * python/py-ref.h: Rename include guard.
742         * python/py-record.h: Rename include guard.
743         * python/py-record-full.h: Rename include guard.
744         * python/py-record-btrace.h: Rename include guard.
745         * python/py-instruction.h: Rename include guard.
746         * python/py-events.h: Rename include guard.
747         * python/py-event.h: Rename include guard.
748         * procfs.h: Add include guard.
749         * proc-utils.h: Add include guard.
750         * p-lang.h: Add include guard.
751         * or1k-tdep.h: Rename include guard.
752         * observable.h: Rename include guard.
753         * nto-tdep.h: Rename include guard.
754         * nat/x86-linux.h: Rename include guard.
755         * nat/x86-linux-dregs.h: Rename include guard.
756         * nat/x86-gcc-cpuid.h: Add include guard.
757         * nat/x86-dregs.h: Rename include guard.
758         * nat/x86-cpuid.h: Rename include guard.
759         * nat/ppc-linux.h: Rename include guard.
760         * nat/mips-linux-watch.h: Rename include guard.
761         * nat/linux-waitpid.h: Rename include guard.
762         * nat/linux-ptrace.h: Rename include guard.
763         * nat/linux-procfs.h: Rename include guard.
764         * nat/linux-osdata.h: Rename include guard.
765         * nat/linux-nat.h: Rename include guard.
766         * nat/linux-namespaces.h: Rename include guard.
767         * nat/linux-btrace.h: Rename include guard.
768         * nat/glibc_thread_db.h: Rename include guard.
769         * nat/gdb_thread_db.h: Rename include guard.
770         * nat/gdb_ptrace.h: Rename include guard.
771         * nat/fork-inferior.h: Rename include guard.
772         * nat/amd64-linux-siginfo.h: Rename include guard.
773         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
774         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
775         * nat/aarch64-linux.h: Rename include guard.
776         * nat/aarch64-linux-hw-point.h: Rename include guard.
777         * mn10300-tdep.h: Add include guard.
778         * mips-linux-tdep.h: Add include guard.
779         * mi/mi-parse.h: Rename include guard.
780         * mi/mi-out.h: Rename include guard.
781         * mi/mi-main.h: Rename include guard.
782         * mi/mi-interp.h: Rename include guard.
783         * mi/mi-getopt.h: Rename include guard.
784         * mi/mi-console.h: Rename include guard.
785         * mi/mi-common.h: Rename include guard.
786         * mi/mi-cmds.h: Rename include guard.
787         * mi/mi-cmd-break.h: Rename include guard.
788         * m2-lang.h: Add include guard.
789         * location.h: Rename include guard.
790         * linux-record.h: Rename include guard.
791         * linux-nat.h: Add include guard.
792         * linux-fork.h: Add include guard.
793         * i386-darwin-tdep.h: Rename include guard.
794         * hppa-linux-offsets.h: Add include guard.
795         * guile/guile.h: Rename include guard.
796         * guile/guile-internal.h: Rename include guard.
797         * gnu-nat.h: Rename include guard.
798         * gdb-stabs.h: Rename include guard.
799         * frv-tdep.h: Add include guard.
800         * f-lang.h: Add include guard.
801         * event-loop.h: Add include guard.
802         * darwin-nat.h: Rename include guard.
803         * cp-abi.h: Rename include guard.
804         * config/sparc/nm-sol2.h: Rename include guard.
805         * config/nm-nto.h: Rename include guard.
806         * config/nm-linux.h: Add include guard.
807         * config/i386/nm-i386gnu.h: Rename include guard.
808         * config/djgpp/nl_types.h: Rename include guard.
809         * config/djgpp/langinfo.h: Rename include guard.
810         * compile/gcc-cp-plugin.h: Add include guard.
811         * compile/gcc-c-plugin.h: Add include guard.
812         * compile/compile.h: Rename include guard.
813         * compile/compile-object-run.h: Rename include guard.
814         * compile/compile-object-load.h: Rename include guard.
815         * compile/compile-internal.h: Rename include guard.
816         * compile/compile-cplus.h: Rename include guard.
817         * compile/compile-c.h: Rename include guard.
818         * common/xml-utils.h: Rename include guard.
819         * common/x86-xstate.h: Rename include guard.
820         * common/version.h: Rename include guard.
821         * common/vec.h: Rename include guard.
822         * common/tdesc.h: Rename include guard.
823         * common/selftest.h: Rename include guard.
824         * common/scoped_restore.h: Rename include guard.
825         * common/scoped_mmap.h: Rename include guard.
826         * common/scoped_fd.h: Rename include guard.
827         * common/safe-iterator.h: Rename include guard.
828         * common/run-time-clock.h: Rename include guard.
829         * common/refcounted-object.h: Rename include guard.
830         * common/queue.h: Rename include guard.
831         * common/ptid.h: Rename include guard.
832         * common/print-utils.h: Rename include guard.
833         * common/preprocessor.h: Rename include guard.
834         * common/pathstuff.h: Rename include guard.
835         * common/observable.h: Rename include guard.
836         * common/netstuff.h: Rename include guard.
837         * common/job-control.h: Rename include guard.
838         * common/host-defs.h: Rename include guard.
839         * common/gdb_wait.h: Rename include guard.
840         * common/gdb_vecs.h: Rename include guard.
841         * common/gdb_unlinker.h: Rename include guard.
842         * common/gdb_unique_ptr.h: Rename include guard.
843         * common/gdb_tilde_expand.h: Rename include guard.
844         * common/gdb_sys_time.h: Rename include guard.
845         * common/gdb_string_view.h: Rename include guard.
846         * common/gdb_splay_tree.h: Rename include guard.
847         * common/gdb_setjmp.h: Rename include guard.
848         * common/gdb_ref_ptr.h: Rename include guard.
849         * common/gdb_optional.h: Rename include guard.
850         * common/gdb_locale.h: Rename include guard.
851         * common/gdb_assert.h: Rename include guard.
852         * common/filtered-iterator.h: Rename include guard.
853         * common/filestuff.h: Rename include guard.
854         * common/fileio.h: Rename include guard.
855         * common/environ.h: Rename include guard.
856         * common/common-utils.h: Rename include guard.
857         * common/common-types.h: Rename include guard.
858         * common/common-regcache.h: Rename include guard.
859         * common/common-inferior.h: Rename include guard.
860         * common/common-gdbthread.h: Rename include guard.
861         * common/common-exceptions.h: Rename include guard.
862         * common/common-defs.h: Rename include guard.
863         * common/common-debug.h: Rename include guard.
864         * common/cleanups.h: Rename include guard.
865         * common/buffer.h: Rename include guard.
866         * common/btrace-common.h: Rename include guard.
867         * common/break-common.h: Rename include guard.
868         * cli/cli-utils.h: Rename include guard.
869         * cli/cli-style.h: Rename include guard.
870         * cli/cli-setshow.h: Rename include guard.
871         * cli/cli-script.h: Rename include guard.
872         * cli/cli-interp.h: Rename include guard.
873         * cli/cli-decode.h: Rename include guard.
874         * cli/cli-cmds.h: Rename include guard.
875         * charset-list.h: Add include guard.
876         * buildsym-legacy.h: Rename include guard.
877         * bfin-tdep.h: Add include guard.
878         * ax.h: Rename include guard.
879         * arm-linux-tdep.h: Add include guard.
880         * arm-fbsd-tdep.h: Add include guard.
881         * arch/xtensa.h: Rename include guard.
882         * arch/tic6x.h: Add include guard.
883         * arch/i386.h: Add include guard.
884         * arch/arm.h: Rename include guard.
885         * arch/arm-linux.h: Rename include guard.
886         * arch/arm-get-next-pcs.h: Rename include guard.
887         * arch/amd64.h: Add include guard.
888         * arch/aarch64-insn.h: Rename include guard.
889         * arch-utils.h: Rename include guard.
890         * annotate.h: Add include guard.
891         * amd64-darwin-tdep.h: Rename include guard.
892         * aarch64-linux-tdep.h: Add include guard.
893         * aarch64-fbsd-tdep.h: Add include guard.
894         * aarch32-linux-nat.h: Add include guard.
895
896 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
897
898         * macrotab.c (macro_define_internal): New function that
899         factorizes macro_define_object_internal and macro_define_function
900         code.
901         (macro_define_object_internal): Use macro_define_internal.
902         (macro_define_function): Likewise.
903
904 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
905
906         * macrocmd.c (extract_identifier): Return
907         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
908         callers.
909
910 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
911
912         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
913
914 2019-02-05  Tom Tromey  <tom@tromey.com>
915
916         * target.c (target_stack::unpush): Move assertion earlier.
917
918 2019-01-30  Tom Tromey  <tom@tromey.com>
919
920         PR python/23615:
921         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
922         (gdbpy_parse_and_eval): Likewise.
923         * python/python-internal.h (gdbpy_allow_threads): New class.
924
925 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
926
927         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
928         (aarch64_fbsd_fpregmap): Move earlier.
929         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
930         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
931         instead of individual calls to trad_frame_set_reg_addr.
932         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
933         earlier.
934         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
935         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
936         instead of individual calls to trad_frame_set_reg_addr.
937
938 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
939
940         * CONTRIBUTE: Replace contribution list with wiki link.
941
942 2019-01-25  Tom Tromey  <tom@tromey.com>
943
944         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
945
946 2019-01-25  Tom Tromey  <tom@tromey.com>
947
948         * xtensa-linux-nat.c: Fix common/ includes.
949         * xml-support.h: Fix common/ includes.
950         * xml-support.c: Fix common/ includes.
951         * x86-linux-nat.c: Fix common/ includes.
952         * windows-nat.c: Fix common/ includes.
953         * varobj.h: Fix common/ includes.
954         * varobj.c: Fix common/ includes.
955         * value.c: Fix common/ includes.
956         * valops.c: Fix common/ includes.
957         * utils.c: Fix common/ includes.
958         * unittests/xml-utils-selftests.c: Fix common/ includes.
959         * unittests/utils-selftests.c: Fix common/ includes.
960         * unittests/unpack-selftests.c: Fix common/ includes.
961         * unittests/tracepoint-selftests.c: Fix common/ includes.
962         * unittests/style-selftests.c: Fix common/ includes.
963         * unittests/string_view-selftests.c: Fix common/ includes.
964         * unittests/scoped_restore-selftests.c: Fix common/ includes.
965         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
966         * unittests/scoped_fd-selftests.c: Fix common/ includes.
967         * unittests/rsp-low-selftests.c: Fix common/ includes.
968         * unittests/parse-connection-spec-selftests.c: Fix common/
969         includes.
970         * unittests/optional-selftests.c: Fix common/ includes.
971         * unittests/offset-type-selftests.c: Fix common/ includes.
972         * unittests/observable-selftests.c: Fix common/ includes.
973         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
974         * unittests/memrange-selftests.c: Fix common/ includes.
975         * unittests/memory-map-selftests.c: Fix common/ includes.
976         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
977         * unittests/function-view-selftests.c: Fix common/ includes.
978         * unittests/environ-selftests.c: Fix common/ includes.
979         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
980         * unittests/common-utils-selftests.c: Fix common/ includes.
981         * unittests/cli-utils-selftests.c: Fix common/ includes.
982         * unittests/array-view-selftests.c: Fix common/ includes.
983         * ui-file.c: Fix common/ includes.
984         * tui/tui-io.c: Fix common/ includes.
985         * tracepoint.h: Fix common/ includes.
986         * tracepoint.c: Fix common/ includes.
987         * tracefile-tfile.c: Fix common/ includes.
988         * top.h: Fix common/ includes.
989         * top.c: Fix common/ includes.
990         * thread.c: Fix common/ includes.
991         * target/waitstatus.h: Fix common/ includes.
992         * target/waitstatus.c: Fix common/ includes.
993         * target.h: Fix common/ includes.
994         * target.c: Fix common/ includes.
995         * target-memory.c: Fix common/ includes.
996         * target-descriptions.c: Fix common/ includes.
997         * symtab.h: Fix common/ includes.
998         * symfile.c: Fix common/ includes.
999         * stap-probe.c: Fix common/ includes.
1000         * spu-linux-nat.c: Fix common/ includes.
1001         * sparc-nat.c: Fix common/ includes.
1002         * source.c: Fix common/ includes.
1003         * solib.c: Fix common/ includes.
1004         * solib-target.c: Fix common/ includes.
1005         * ser-unix.c: Fix common/ includes.
1006         * ser-tcp.c: Fix common/ includes.
1007         * ser-pipe.c: Fix common/ includes.
1008         * ser-base.c: Fix common/ includes.
1009         * selftest-arch.c: Fix common/ includes.
1010         * s12z-tdep.c: Fix common/ includes.
1011         * rust-exp.y: Fix common/ includes.
1012         * rs6000-aix-tdep.c: Fix common/ includes.
1013         * riscv-tdep.c: Fix common/ includes.
1014         * remote.c: Fix common/ includes.
1015         * remote-notif.h: Fix common/ includes.
1016         * remote-fileio.h: Fix common/ includes.
1017         * remote-fileio.c: Fix common/ includes.
1018         * regcache.h: Fix common/ includes.
1019         * regcache.c: Fix common/ includes.
1020         * record-btrace.c: Fix common/ includes.
1021         * python/python.c: Fix common/ includes.
1022         * python/py-type.c: Fix common/ includes.
1023         * python/py-inferior.c: Fix common/ includes.
1024         * progspace.h: Fix common/ includes.
1025         * producer.c: Fix common/ includes.
1026         * procfs.c: Fix common/ includes.
1027         * proc-api.c: Fix common/ includes.
1028         * printcmd.c: Fix common/ includes.
1029         * ppc-linux-nat.c: Fix common/ includes.
1030         * parser-defs.h: Fix common/ includes.
1031         * osdata.c: Fix common/ includes.
1032         * obsd-nat.c: Fix common/ includes.
1033         * nat/x86-linux.c: Fix common/ includes.
1034         * nat/x86-linux-dregs.c: Fix common/ includes.
1035         * nat/x86-dregs.h: Fix common/ includes.
1036         * nat/x86-dregs.c: Fix common/ includes.
1037         * nat/ppc-linux.c: Fix common/ includes.
1038         * nat/mips-linux-watch.h: Fix common/ includes.
1039         * nat/mips-linux-watch.c: Fix common/ includes.
1040         * nat/linux-waitpid.c: Fix common/ includes.
1041         * nat/linux-ptrace.h: Fix common/ includes.
1042         * nat/linux-ptrace.c: Fix common/ includes.
1043         * nat/linux-procfs.c: Fix common/ includes.
1044         * nat/linux-personality.c: Fix common/ includes.
1045         * nat/linux-osdata.c: Fix common/ includes.
1046         * nat/linux-namespaces.c: Fix common/ includes.
1047         * nat/linux-btrace.h: Fix common/ includes.
1048         * nat/linux-btrace.c: Fix common/ includes.
1049         * nat/fork-inferior.c: Fix common/ includes.
1050         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1051         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1052         * nat/aarch64-linux.c: Fix common/ includes.
1053         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1054         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1055         * namespace.h: Fix common/ includes.
1056         * mips-linux-tdep.c: Fix common/ includes.
1057         * minsyms.c: Fix common/ includes.
1058         * mi/mi-parse.h: Fix common/ includes.
1059         * mi/mi-main.c: Fix common/ includes.
1060         * mi/mi-cmd-env.c: Fix common/ includes.
1061         * memrange.h: Fix common/ includes.
1062         * memattr.c: Fix common/ includes.
1063         * maint.h: Fix common/ includes.
1064         * maint.c: Fix common/ includes.
1065         * main.c: Fix common/ includes.
1066         * machoread.c: Fix common/ includes.
1067         * location.c: Fix common/ includes.
1068         * linux-thread-db.c: Fix common/ includes.
1069         * linux-nat.c: Fix common/ includes.
1070         * linux-fork.c: Fix common/ includes.
1071         * inline-frame.c: Fix common/ includes.
1072         * infrun.c: Fix common/ includes.
1073         * inflow.c: Fix common/ includes.
1074         * inferior.h: Fix common/ includes.
1075         * inferior.c: Fix common/ includes.
1076         * infcmd.c: Fix common/ includes.
1077         * inf-ptrace.c: Fix common/ includes.
1078         * inf-child.c: Fix common/ includes.
1079         * ia64-linux-nat.c: Fix common/ includes.
1080         * i387-tdep.c: Fix common/ includes.
1081         * i386-tdep.c: Fix common/ includes.
1082         * i386-linux-tdep.c: Fix common/ includes.
1083         * i386-linux-nat.c: Fix common/ includes.
1084         * i386-go32-tdep.c: Fix common/ includes.
1085         * i386-fbsd-tdep.c: Fix common/ includes.
1086         * i386-fbsd-nat.c: Fix common/ includes.
1087         * guile/scm-type.c: Fix common/ includes.
1088         * guile/guile.c: Fix common/ includes.
1089         * go32-nat.c: Fix common/ includes.
1090         * gnu-nat.c: Fix common/ includes.
1091         * gdbthread.h: Fix common/ includes.
1092         * gdbarch-selftests.c: Fix common/ includes.
1093         * gdb_usleep.c: Fix common/ includes.
1094         * gdb_select.h: Fix common/ includes.
1095         * gdb_bfd.c: Fix common/ includes.
1096         * gcore.c: Fix common/ includes.
1097         * fork-child.c: Fix common/ includes.
1098         * findvar.c: Fix common/ includes.
1099         * fbsd-nat.c: Fix common/ includes.
1100         * event-top.c: Fix common/ includes.
1101         * event-loop.c: Fix common/ includes.
1102         * dwarf2read.c: Fix common/ includes.
1103         * dwarf2loc.c: Fix common/ includes.
1104         * dwarf2-frame.c: Fix common/ includes.
1105         * dwarf-index-cache.c: Fix common/ includes.
1106         * dtrace-probe.c: Fix common/ includes.
1107         * disasm-selftests.c: Fix common/ includes.
1108         * defs.h: Fix common/ includes.
1109         * csky-tdep.c: Fix common/ includes.
1110         * cp-valprint.c: Fix common/ includes.
1111         * cp-support.h: Fix common/ includes.
1112         * cp-support.c: Fix common/ includes.
1113         * corelow.c: Fix common/ includes.
1114         * completer.h: Fix common/ includes.
1115         * completer.c: Fix common/ includes.
1116         * compile/compile.c: Fix common/ includes.
1117         * compile/compile-loc2c.c: Fix common/ includes.
1118         * compile/compile-cplus-types.c: Fix common/ includes.
1119         * compile/compile-cplus-symbols.c: Fix common/ includes.
1120         * command.h: Fix common/ includes.
1121         * cli/cli-dump.c: Fix common/ includes.
1122         * cli/cli-cmds.c: Fix common/ includes.
1123         * charset.c: Fix common/ includes.
1124         * build-id.c: Fix common/ includes.
1125         * btrace.h: Fix common/ includes.
1126         * btrace.c: Fix common/ includes.
1127         * breakpoint.h: Fix common/ includes.
1128         * breakpoint.c: Fix common/ includes.
1129         * ax.h: 
1130         (enum agent_op): Fix common/ includes.
1131         * ax-general.c (struct aop_map): Fix common/ includes.
1132         * ax-gdb.c: Fix common/ includes.
1133         * auxv.c: Fix common/ includes.
1134         * auto-load.c: Fix common/ includes.
1135         * arm-tdep.c: Fix common/ includes.
1136         * arch/riscv.c: Fix common/ includes.
1137         * arch/ppc-linux-common.c: Fix common/ includes.
1138         * arch/i386.c: Fix common/ includes.
1139         * arch/arm.c: Fix common/ includes.
1140         * arch/arm-linux.c: Fix common/ includes.
1141         * arch/arm-get-next-pcs.c: Fix common/ includes.
1142         * arch/amd64.c: Fix common/ includes.
1143         * arch/aarch64.c: Fix common/ includes.
1144         * arch/aarch64-insn.c: Fix common/ includes.
1145         * arch-utils.c: Fix common/ includes.
1146         * amd64-windows-tdep.c: Fix common/ includes.
1147         * amd64-tdep.c: Fix common/ includes.
1148         * amd64-sol2-tdep.c: Fix common/ includes.
1149         * amd64-obsd-tdep.c: Fix common/ includes.
1150         * amd64-nbsd-tdep.c: Fix common/ includes.
1151         * amd64-linux-tdep.c: Fix common/ includes.
1152         * amd64-linux-nat.c: Fix common/ includes.
1153         * amd64-fbsd-tdep.c: Fix common/ includes.
1154         * amd64-fbsd-nat.c: Fix common/ includes.
1155         * amd64-dicos-tdep.c: Fix common/ includes.
1156         * amd64-darwin-tdep.c: Fix common/ includes.
1157         * agent.c: Fix common/ includes.
1158         * ada-lang.h: Fix common/ includes.
1159         * ada-lang.c: Fix common/ includes.
1160         * aarch64-tdep.c: Fix common/ includes.
1161
1162 2019-01-25  Tom Tromey  <tom@tromey.com>
1163
1164         * common/create-version.sh: Use common/version.h.
1165
1166 2019-01-24  Pedro Alves  <palves@redhat.com>
1167
1168         * infrun.c (signal_stop, signal_print, signal_program)
1169         (signal_catch, signal_pass): Now arrays instead of pointers.
1170         (update_signals_program_target, do_target_resume)
1171         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1172         * linux-nat.c (linux_nat_target::pass_signals)
1173         (linux_nat_target::create_inferior, linux_nat_target::attach):
1174         Adjust.
1175         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1176         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1177         * procfs.c (procfs_target::pass_signals): Adjust.
1178         * record-full.c (record_full_target::resume): Adjust.
1179         * remote.c (remote_target::pass_signals)
1180         (remote_target::program_signals): Adjust.
1181         * target-debug.h (target_debug_print_signals): Now takes a
1182         gdb::array_view as parameter.  Adjust.
1183         * target.h (target_ops) <pass_signals, program_signals>: Replace
1184         pointer and length parameters with gdb::array_view.
1185         (target_pass_signals, target_program_signals): Likewise.
1186         * target-delegates.c: Regenerate.
1187
1188 2019-01-24  Pedro Alves  <palves@redhat.com>
1189
1190         * common/forward-scope-exit.h
1191         (forward_scope_exit::forward_scope_exit): Pass arguments to
1192         m_bind_function directly, instead of creating a std::bind and
1193         copying that.
1194
1195 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1196
1197         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1198         for static members.
1199         (pass_in_v_vfp_candidate): Likewise.
1200
1201 2019-01-23  Tom Tromey  <tom@tromey.com>
1202             Pedro Alves  <palves@redhat.com>
1203
1204         * regcache.c (class regcache_invalidator): Remove.
1205         (regcache::raw_write): Use make_scope_exit.
1206
1207 2019-01-23  Tom Tromey  <tom@tromey.com>
1208
1209         * ui-out.h (class ui_out_emit_type): Update comment.
1210
1211 2019-01-23  Tom Tromey  <tom@tromey.com>
1212
1213         * infrun.c (fetch_inferior_event): Update comment.
1214
1215 2019-01-23  Tom Tromey  <tom@tromey.com>
1216             Pedro Alves  <palves@redhat.com>
1217
1218         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1219         parameter.
1220         (fetch_inferior_event): Use SCOPE_EXIT.
1221
1222
1223 2019-01-23  Tom Tromey  <tom@tromey.com>
1224             Pedro Alves  <palves@redhat.com>
1225
1226         * infrun.c (disable_thread_events): Delete.
1227         (stop_all_threads): Use SCOPE_EXIT.
1228
1229 2019-01-23  Tom Tromey  <tom@tromey.com>
1230             Pedro Alves  <palves@redhat.com>
1231
1232         * symfile.c: Include forward-scope-exit.h.
1233         (clear_symtab_users_cleanup): Replace forward declaration with
1234         a FORWARD_SCOPE_EXIT.
1235         (syms_from_objfile_1): Use the forward_scope_exit and
1236         gdb::optional instead of cleanup_function.
1237         (reread_symbols): Use the forward_scope_exit instead of
1238         cleanup_function.
1239         (clear_symtab_users_cleanup): Remove function.
1240
1241 2019-01-23  Tom Tromey  <tom@tromey.com>
1242             Pedro Alves  <palves@redhat.com>
1243
1244         * linux-nat.c: Include scope-exit.h.
1245         (cleanup_target_stop): Remove.
1246         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1247         SCOPE_EXIT.
1248
1249 2019-01-23  Tom Tromey  <tom@tromey.com>
1250             Pedro Alves  <palves@redhat.com>
1251
1252         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1253         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1254
1255 2019-01-23  Tom Tromey  <tom@tromey.com>
1256             Andrew Burgess  <andrew.burgess@embecosm.com>
1257             Pedro Alves  <palves@redhat.com>
1258
1259         * infrun.c (fetch_inferior_event): Use scope_exit.
1260         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1261         * top.c (execute_command): Use scope_exit.
1262         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1263         * utils.c (do_bpstat_clear_actions_cleanup)
1264         (make_bpstat_clear_actions_cleanup): Remove.
1265
1266 2019-01-23  Tom Tromey  <tom@tromey.com>
1267             Pedro Alves  <palves@redhat.com>
1268
1269         * infrun.c: Include "common/scope-exit.h"
1270         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1271         (wait_for_inferior): Use SCOPE_EXIT.
1272         (fetch_inferior_event): Use scope_exit.
1273
1274 2019-01-23  Tom Tromey  <tom@tromey.com>
1275             Pedro Alves  <palves@redhat.com>
1276
1277         * breakpoint.c (create_breakpoint): Remove cleanup.
1278
1279 2019-01-23  Tom Tromey  <tom@tromey.com>
1280             Andrew Burgess  <andrew.burgess@embecosm.com>
1281             Pedro Alves  <palves@redhat.com>
1282
1283 2019-01-23  Pedro Alves  <palves@redhat.com>
1284
1285         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1286
1287 2019-01-23  Pedro Alves  <palves@redhat.com>
1288             Andrew Burgess  <andrew.burgess@embecosm.com>
1289
1290         * gdbthread.h: Include "common/forward-scope-exit.h".
1291         (scoped_finish_thread_state): Redefine custom class in terms of
1292         forward_scope_exit.
1293
1294 2019-01-23  Pedro Alves  <palves@redhat.com>
1295             Andrew Burgess  <andrew.burgess@embecosm.com>
1296
1297         * common/forward-scope-exit.h: New file.
1298
1299 2019-01-23  Pedro Alves  <palves@redhat.com>
1300             Andrew Burgess  <andrew.burgess@embecosm.com>
1301             Tom Tromey  <tom@tromey.com>
1302
1303         * common/scope-exit.h: New file.
1304
1305 2019-01-23  Pedro Alves  <palves@redhat.com>
1306
1307         * common/preprocessor.h (ESC): Rename to ...
1308         (ESC_PARENS): ... this.
1309         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1310         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1311
1312 2019-01-23  Tom Tromey  <tom@tromey.com>
1313
1314         * language.h (class scoped_switch_to_sym_language_if_auto):
1315         Initialize m_lang in both cases.
1316
1317 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1318
1319         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1320         with XCNEW.
1321
1322 2019-01-22  Tom Tromey  <tom@tromey.com>
1323
1324         * corelow.c: Do not include sys/file.h.
1325
1326 2019-01-22  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-wingeneral.h: Include gdb_curses.h.
1329
1330 2019-01-22  Tom Tromey  <tom@tromey.com>
1331
1332         * source-cache.h (class source_cache) <get_source_lines,
1333         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1334
1335 2019-01-22  Tom Tromey  <tom@tromey.com>
1336
1337         * remote-fileio.h (struct remote_target): Declare.
1338
1339 2019-01-22  Tom Tromey  <tom@tromey.com>
1340
1341         * python/py-arch.c: Do not include py-ref.h.
1342         * python/py-bpevent.c: Do not include py-ref.h.
1343         * python/py-cmd.c: Do not include py-ref.h.
1344         * python/py-continueevent.c: Do not include py-ref.h.
1345         * python/py-event.h: Do not include py-ref.h.
1346         * python/py-evtregistry.c: Do not include py-ref.h.
1347         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1348         * python/py-frame.c: Do not include py-ref.h.
1349         * python/py-framefilter.c: Do not include py-ref.h.
1350         * python/py-function.c: Do not include py-ref.h.
1351         * python/py-infevents.c: Do not include py-ref.h.
1352         * python/py-linetable.c: Do not include py-ref.h.
1353         * python/py-objfile.c: Do not include py-ref.h.
1354         * python/py-param.c: Do not include py-ref.h.
1355         * python/py-prettyprint.c: Do not include py-ref.h.
1356         * python/py-progspace.c: Do not include py-ref.h.
1357         * python/py-symbol.c: Do not include py-ref.h.
1358         * python/py-symtab.c: Do not include py-ref.h.
1359         * python/py-type.c: Do not include py-ref.h.
1360         * python/py-unwind.c: Do not include py-ref.h.
1361         * python/py-utils.c: Do not include py-ref.h.
1362         * python/py-value.c: Do not include py-ref.h.
1363         * python/py-varobj.c: Do not include py-ref.h.
1364         * python/py-xmethods.c: Do not include py-ref.h.
1365         * python/python.c: Do not include py-ref.h.
1366         * varobj.c: Do not include py-ref.h.
1367
1368 2019-01-22  Tom Tromey  <tom@tromey.com>
1369
1370         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1371         keyword for bcache.
1372
1373 2019-01-22  Tom Tromey  <tom@tromey.com>
1374
1375         * compile/compile-cplus-types.c: Remove a comment by #include.
1376
1377 2019-01-22  Tom Tromey  <tom@tromey.com>
1378
1379         * compile/gcc-c-plugin.h: Include compile-internal.h.
1380
1381 2019-01-22  Tom Tromey  <tom@tromey.com>
1382
1383         * stabsread.c (EXTERN): Do not define.
1384         (symnum, next_symbol_text_func, processing_gcc_compilation)
1385         (within_function, global_sym_chain, global_stabs)
1386         (previous_stab_code, this_object_header_files)
1387         (n_this_object_header_files)
1388         (n_allocated_this_object_header_files): Define.
1389         * stabsread.h (EXTERN): Never define.  Use "extern".
1390
1391 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1392
1393         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1394         history_value.
1395
1396 2019-01-21  Tom Tromey  <tom@tromey.com>
1397
1398         * ui-out.c: Fix includes.
1399         * tui/tui-source.c: Fix includes.
1400         * target.c: Fix includes.
1401         * remote.c: Fix includes.
1402         * regcache.c: Fix includes.
1403         * python/py-block.c: Fix includes.
1404         * printcmd.c: Fix includes.
1405         * or1k-tdep.c: Fix includes.
1406         * mi/mi-main.c: Fix includes.
1407         * m32r-tdep.c: Fix includes.
1408         * csky-tdep.c: Fix includes.
1409         * compile/compile-cplus-types.c: Fix includes.
1410         * cli/cli-interp.c: Fix includes.
1411
1412 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1413
1414         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1415         for padding.
1416
1417 2019-01-16  Tom Tromey  <tom@tromey.com>
1418
1419         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1420         earlier.
1421         (struct objfile) <msymbols_range>: Move from top level.
1422         <msymbols>: New method.
1423         (class objfile_msymbols): Remove.
1424         * symtab.c (default_collect_symbol_completion_matches_break_on):
1425         Update.
1426         * symmisc.c (dump_msymbols): Update.
1427         * stabsread.c (scan_file_globals): Update.
1428         * objc-lang.c (info_selectors_command, info_classes_command)
1429         (find_methods): Update.
1430         * minsyms.c (find_solib_trampoline_target): Update.
1431         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1432         * coffread.c (coff_symfile_read): Update.
1433         * ada-lang.c (ada_lookup_simple_minsym)
1434         (ada_collect_symbol_completion_matches): Update.
1435
1436 2019-01-16  Tom Tromey  <tom@tromey.com>
1437
1438         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1439         type.  Remove no-argument constructor.
1440         <iterator::operator++>: Simplify.
1441         <begin>: Update.
1442         <end>: Use minimal_symbol_count.
1443
1444 2019-01-16  Tom Tromey  <tom@tromey.com>
1445
1446         * objfiles.h (struct objfile) <psymtabs>: New method.
1447         (class objfile_psymtabs): Remove.
1448         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1449         typedef.
1450         <range>: New method.
1451         (require_partial_symbols): Change return type.
1452         * psymtab.c (require_partial_symbols)
1453         (psym_expand_symtabs_matching): Update.
1454         * mdebugread.c (parse_partial_symbols): Update.
1455         * dbxread.c (dbx_end_psymtab): Update.
1456
1457 2019-01-15  Tom Tromey  <tom@tromey.com>
1458
1459         * symtab.c (lookup_objfile_from_block)
1460         (lookup_symbol_in_objfile_symtabs)
1461         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1462         (find_line_symtab, info_sources_command)
1463         (default_collect_symbol_completion_matches_break_on)
1464         (make_source_files_completion_list): Update.
1465         * symmisc.c (print_objfile_statistics, dump_objfile)
1466         (maintenance_print_symbols, maintenance_info_symtabs)
1467         (maintenance_check_symtabs, maintenance_info_line_tables):
1468         Update.
1469         * source.c (select_source_symtab)
1470         (forget_cached_source_info_for_objfile): Update.
1471         * objfiles.h (class objfile_compunits): Remove.
1472         (struct objfile) <compunits_range>: New typedef.
1473         (compunits): New method.
1474         * objfiles.c (objfile_relocate1): Update.
1475         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1476         * maint.c (count_symtabs_and_blocks): Update.
1477         * linespec.c (iterate_over_all_matching_symtabs): Update.
1478         * cp-support.c (add_symbol_overload_list_qualified): Update.
1479         * coffread.c (coff_symtab_read): Update.
1480         * ada-lang.c (add_nonlocal_symbols)
1481         (ada_collect_symbol_completion_matches)
1482         (ada_add_global_exceptions): Update.
1483
1484 2019-01-15  Tom Tromey  <tom@tromey.com>
1485
1486         * progspace.h (program_space) <objfiles_safe_range>: New
1487         typedef.
1488         <objfiles_safe>: New method.
1489         * objfiles.h (class all_objfiles_safe): Remove.
1490         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1491         * jit.c (jit_inferior_exit_hook): Update.
1492
1493 2019-01-17  Tom Tromey  <tom@tromey.com>
1494
1495         * progspace.h (program_space) <objfiles_range>: New typedef.
1496         <objfiles>: New method.
1497         <objfiles_head>: Rename from objfiles.
1498         (object_files): Update.
1499         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1500         * guile/scm-pretty-print.c
1501         (ppscm_find_pretty_printer_from_objfiles): Update.
1502         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1503         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1504         Update.
1505         * python/py-progspace.c (pspy_get_objfiles): Update.
1506         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1507         Update.
1508         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1509         (objfpy_lookup_objfile_by_build_id): Update.
1510         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1511         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1512         Update.
1513         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1514         (expand_symtab_containing_pc, lookup_objfile_from_block)
1515         (lookup_static_symbol, basic_lookup_transparent_type)
1516         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1517         (find_line_symtab, info_sources_command)
1518         (default_collect_symbol_completion_matches_break_on)
1519         (make_source_files_completion_list, find_main_name): Update.
1520         * symmisc.c (print_symbol_bcache_statistics)
1521         (print_objfile_statistics, maintenance_print_symbols)
1522         (maintenance_print_msymbols, maintenance_print_objfiles)
1523         (maintenance_info_symtabs, maintenance_check_symtabs)
1524         (maintenance_expand_symtabs, maintenance_info_line_tables):
1525         Update.
1526         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1527         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1528         (map_overlay_command, unmap_overlay_command)
1529         (simple_overlay_update, expand_symtabs_matching)
1530         (map_symbol_filenames): Update.
1531         * symfile-debug.c (set_debug_symfile): Update.
1532         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1533         Update.
1534         * source.c (select_source_symtab, forget_cached_source_info):
1535         Update.
1536         * solib.c (solib_read_symbols): Update.
1537         * solib-spu.c (append_ocl_sos): Update.
1538         * psymtab.c (maintenance_print_psymbols)
1539         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1540         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1541         * printcmd.c (info_symbol_command): Update.
1542         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1543         Update.
1544         * objfiles.h (class all_objfiles): Remove.
1545         * objfiles.c (have_partial_symbols, have_full_symbols)
1546         (have_minimal_symbols, qsort_cmp, update_section_map)
1547         (shared_objfile_contains_address_p)
1548         (default_iterate_over_objfiles_in_search_order): Update.
1549         * objc-lang.c (info_selectors_command, info_classes_command)
1550         (find_methods): Update.
1551         * minsyms.c (find_solib_trampoline_target): Update.
1552         * maint.c (maintenance_info_sections)
1553         (maintenance_translate_address, count_symtabs_and_blocks):
1554         Update.
1555         * main.c (captured_main_1): Update.
1556         * linux-thread-db.c (try_thread_db_load_from_pdir)
1557         (has_libpthread): Update.
1558         * linespec.c (iterate_over_all_matching_symtabs)
1559         (search_minsyms_for_name): Update.
1560         * jit.c (jit_find_objf_with_entry_addr): Update.
1561         * hppa-tdep.c (find_unwind_entry)
1562         (hppa_lookup_stub_minimal_symbol): Update.
1563         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1564         Update.
1565         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1566         (elf_gnu_ifunc_resolve_by_got): Update.
1567         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1568         * dwarf-index-write.c (save_gdb_index_command): Update.
1569         * cp-support.c (add_symbol_overload_list_qualified): Update.
1570         * breakpoint.c (create_overlay_event_breakpoint)
1571         (create_longjmp_master_breakpoint)
1572         (create_std_terminate_master_breakpoint)
1573         (create_exception_master_breakpoint): Update.
1574         * blockframe.c (find_pc_partial_function): Update.
1575         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1576         (ada_collect_symbol_completion_matches)
1577         (ada_add_global_exceptions): Update.
1578
1579 2019-01-17  Tom Tromey  <tom@tromey.com>
1580
1581         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1582         declare VEC.
1583         (solib_target_parse_libraries): Change return type.
1584         (library_list_start_segment, library_list_start_section)
1585         (library_list_end_library, library_list_start_library); Update.
1586         (solib_target_free_library_list): Remove.
1587         (solib_target_parse_libraries): Remove cleanup.  Change return
1588         type.
1589         (solib_target_current_sos): Update.
1590
1591 2019-01-17  Tom Tromey  <tromey@bapiya>
1592
1593         * valprint.c: Replace "the the" with "the".
1594         * symtab.c: Replace "the the" with "the".
1595         * solib.c: Replace "the the" with "the".
1596         * solib-dsbt.c: Replace "the the" with "the".
1597         * linespec.c: Replace "the the" with "the".
1598         * dwarf2loc.h: Replace "the the" with "the".
1599         * amd64-windows-tdep.c: Replace "the the" with "the".
1600         * aarch64-tdep.c: Replace "the the" with "the".
1601
1602 2019-01-16  Keith Seitz  <keiths@redhat.com>
1603
1604         PR gdb/23773
1605         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1606         <builder>: Rename to ..
1607         <m_builder>: ... this and make private.
1608         (dwarf2_cu::get_builder): New method.  Change all users of
1609         `builder' to use this method.
1610         (dwarf2_start_symtab): Move to ...
1611         (dwarf2_cu::start_symtab): ... here.  Update all callers
1612         (setup_type_unit_groups): Move to ...
1613         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1614         callers.
1615         (dwarf2_cu::reset_builder): New method.
1616         (process_full_compunit, process_full_type_unit): Use
1617         dwarf2_cu::reset_builder.
1618         (follow_die_offset): Record the ancestor CU if it is different
1619         from the followed DIE's CU.
1620         (follow_die_sig_1): Likewise.
1621
1622 2019-01-15  Tom Tromey  <tom@tromey.com>
1623
1624         * remote.c (class remote_state) <buf>: Now a char_vector.
1625         <buf_size>: Remove.
1626         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1627         parameter.
1628         (remote_target::getpkt_or_notif_sane_1)
1629         (remote_target::getpkt_sane)
1630         (remote_target::getpkt_or_notif_sane): Likewise.
1631         (class remote_target) <putpkt>: New overload.
1632         (remote_target::read_frame): Change type of "buf_p".  Remove
1633         sizeof_p parameter.
1634         (packet_ok): New overload.
1635         (packet_check_result): New overload.
1636         Update all uses.
1637
1638 2019-01-14  Tom Tromey  <tom@tromey.com>
1639
1640         * remote-notif.c (handle_notification, remote_notif_ack)
1641         (remote_notif_parse): Make "buf" const.
1642         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1643         const.
1644         (remote_notif_parse, remote_notif_ack, handle_notification):
1645         Likewise.
1646         * remote.c (remote_notif_stop_parse): Make "buf" const.
1647         (remote_target::remote_parse_stop_reply): Make "buf" const.
1648         (remote_notif_stop_ack): Make "buf" const.
1649
1650 2019-01-14  Tom Tromey  <tom@tromey.com>
1651
1652         * remote.c (remote_console_output): Make parameter const.
1653
1654 2019-01-14  Tom Tromey  <tom@tromey.com>
1655
1656         * target-debug.h (target_debug_print_signals): Constify.
1657         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1658         * procfs.c (procfs_target::pass_signals): Update.
1659         * linux-nat.c (linux_nat_target::pass_signals): Update.
1660         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1661         * target-delegates.c: Rebuild.
1662         * remote.c (remote_target::program_signals): Update.
1663         (remote_target::pass_signals): Update.
1664         * target.c (target_pass_signals): Constify argument.
1665         (target_program_signals): Likewise.
1666         * target.h (struct target_ops) <pass_signals, program_signals>:
1667         Constify argument.
1668         (target_pass_signals, target_program_signals): Constify argument.
1669
1670 2019-01-14  Tom Tromey  <tom@tromey.com>
1671
1672         PR tui/28819:
1673         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1674
1675 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1676
1677         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1678         field.
1679         * rs6000-tdep.c: Include reggroups.h.
1680         (IS_V_ALIAS_PSEUDOREG): Define.
1681         (rs6000_register_name): Return names for the "vX" aliases.
1682         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1683         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1684         aliases.  Call default_register_reggroup_p for all other
1685         pseudo-registers.
1686         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1687         New functions.
1688         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1689         Handle "vX" aliases.
1690         (v_alias_pseudo_register_collect): New function.
1691         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1692         (rs6000_gdbarch_init): Initialize "vX" aliases as
1693         pseudo-registers.  Restore registration of
1694         rs6000_pseudo_register_reggroup_p with
1695         set_tdesc_pseudo_register_reggroup_p.
1696
1697 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1698
1699         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1700         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1701         set_gdbarch_num_pseudo_regs.
1702
1703 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1704
1705         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1706         Remove arg prefixname, add do_set and do_show.
1707         Add member functions set_list and show_list.
1708         * cli/cli-style.c (class cli_style_option): Update accordingly.
1709         (style_set_list): Move to file scope.
1710         (style_show_list): Likewise.
1711         (set_style): Call help_list.
1712         (show_style): Call cmd_show_list.
1713         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1714         Update to use the new macro.
1715
1716 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1717
1718         * ada-lang.c (_initialize_ada_language): Expand the help text
1719         for the "catch exception" command.
1720
1721 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1722
1723         * symtab.c (matching_obj_sections): Initialize obj,
1724         declare it closer to its usage.
1725
1726 2019-01-10  Tom Tromey  <tom@tromey.com>
1727
1728         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1729         (basic_inf_threads_range): Remove.
1730         (inf_threads_range, inf_non_exited_threads_range)
1731         (safe_inf_threads_range): Use next_adapter.
1732
1733 2019-01-10  Keith Seitz  <keiths@redhat.com>
1734
1735         PR gdb/23712
1736         PR symtab/23010
1737         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1738         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1739
1740 2019-01-10  Keith Seitz  <keiths@redhat.com>
1741
1742         PR gdb/23712
1743         PR symtab/23010
1744         * dictionary.c (pending_to_vector): Remove.
1745         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1746         Remove _1 suffix, replacing functions of the same name.  Update
1747         all callers.
1748         (dict_create_hashed, dict_create_hashed_expandable)
1749         (dict_create_linear, dict_create_linear_expandable, dict_free)
1750         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1751         Make functions static.
1752
1753 2019-01-10  Keith Seitz  <keiths@redhat.com>
1754
1755         PR gdb/23712
1756         PR symtab/23010
1757         * dictionary.h (struct dictionary): Replace declaration with
1758         multidictionary.
1759         (dict_create_hashed, dict_create_hashed_expandable)
1760         (dict_create_linear, dict_create_linear_expandable)
1761         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1762         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1763         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1764         taking multidictionary argument.
1765         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1766         * block.h (struct block) <dict>: Change to multidictionary
1767         and rename `multidict'.
1768         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1769         symmisc.c: Update all dictionary references to multidictionary.
1770
1771 2019-01-10  Keith Seitz  <keiths@redhat.com>
1772
1773         PR gdb/23712
1774         PR symtab/23010
1775         * dictionary.c: Include unordered_map.
1776         (pending_to_vector): New function.
1777         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1778         Rewrite the non-"_1" functions to take vector instead
1779         of linked list.
1780         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1781         "new" _1 versions of the same name.
1782         (multidictionary): Define.
1783         (std::hash<enum language): New definition.
1784         (collate_pending_symbols_by_language, mdict_create_hashed)
1785         (mdict_create_hashed_expandable, mdict_create_linear)
1786         (mdict_create_linear_expandable, mdict_free)
1787         (find_language_dictionary, create_new_language_dictionary)
1788         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1789         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1790         (mdict_size, mdict_empty): New functions.
1791         * dictionary.h (mdict_iterator): Define.
1792
1793 2019-01-10  Pedro Alves  <palves@redhat.com>
1794
1795         * breakpoint.c (read_uploaded_action)
1796         (create_tracepoint_from_upload): Adjust to use
1797         gdb::unique_xmalloc_ptr.
1798         * ctf.c (ctf_write_uploaded_tp):
1799         (SET_ARRAY_FIELD): Use emplace_back.
1800         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1801         * tracefile-tfile.c (tfile_write_uploaded_tp):
1802         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1803         gdb::unique_xmalloc_ptr.
1804         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1805         at_string, cond_string, cmd_strings>: Replace char pointers
1806         with gdb::unique_xmalloc_ptr.
1807
1808 2019-01-10  Pedro Alves  <palves@redhat.com>
1809
1810         * solib-target.c (library_list_start_library): Don't xstrdup name.
1811
1812 2019-01-10  Pedro Alves  <palves@redhat.com>
1813
1814         * mdebugread.c (parse_partial_symbols): Use
1815         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1816
1817 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1818
1819         * linux-fork.c (scoped_switch_fork_info)
1820         <~scoped_switch_fork_info>: Fix incorrect variable name.
1821
1822 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1823
1824         * linux-fork.c (scoped_switch_fork_info)
1825         <scoped_switch_fork_info>: Make explicit.
1826         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1827
1828 2019-01-10  Tom Tromey  <tom@tromey.com>
1829
1830         * objfiles.h (objfile::reset_psymtabs): Update.
1831         * objfiles.c (objfile::objfile): Update.
1832         * psymtab.h (psymtab_storage::obstack): Update.
1833         (psymtab_storage::m_obstack): Use gdb::optional.
1834         (class psymtab_storage): Update comment.  Remove objfile
1835         parameter.
1836         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1837
1838 2019-01-10  Tom Tromey  <tom@tromey.com>
1839
1840         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1841         <free_psymtabs>: Now private.
1842         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1843         (allocate_psymtab): Use new method.
1844
1845 2019-01-10  Tom Tromey  <tom@tromey.com>
1846
1847         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1848         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1849         * mdebugread.c (parse_partial_symbols): Use
1850         allocate_dependencies.
1851         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1852         allocate_dependencies.
1853         (process_psymtab_comp_unit_reader)
1854         (build_type_psymtab_dependencies): Likewise.
1855         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1856
1857 2019-01-10  Tom Tromey  <tom@tromey.com>
1858
1859         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1860         PSYMBOL_SET_LANGUAGE.
1861         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1862
1863 2019-01-10  Tom Tromey  <tom@tromey.com>
1864
1865         * psymtab.h (psymtab_storage::obstack): New method.
1866         <m_obstack>: Rename from obstack; now private.
1867         * psymtab.c (psymtab_storage): Update.
1868         * dwarf2read.c (create_addrmap_from_index)
1869         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1870         Update.
1871
1872 2019-01-10  Tom Tromey  <tom@tromey.com>
1873
1874         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1875         * objfiles.h (objfile::reset_psymtabs): New method.
1876
1877 2019-01-10  Tom Tromey  <tom@tromey.com>
1878
1879         * symmisc.c (print_symbol_bcache_statistics): Update.
1880         (print_objfile_statistics): Update.
1881         * symfile.c (reread_symbols): Update.
1882         * psymtab.h (class psymtab_storage): New.
1883         * psymtab.c (psymtab_storage): New constructor.
1884         (~psymtab_storage): New destructor.
1885         (require_partial_symbols): Update.
1886         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1887         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1888         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1889         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1890         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1891         (start_psymtab_common, end_psymtab_common)
1892         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1893         (allocate_psymtab): Update.
1894         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1895         Update.
1896         (dump_psymtab_addrmap, maintenance_print_psymbols)
1897         (maintenance_check_psymtabs): Update.
1898         (class objfile_psymtabs): Move to objfiles.h.
1899         * psympriv.h (discard_psymtab): Now inline.
1900         (psymtab_discarder::psymtab_discarder): Update.
1901         (psymtab_discarder::~psymtab_discarder): Update.
1902         (ALL_OBJFILE_PSYMTABS): Rewrite.
1903         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1904         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1905         Remove fields.
1906         <partial_symtabs>: New field.
1907         (class objfile_psymtabs): Move from psymtab.h.  Update.
1908         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1909         psymbol_cache.
1910         (objfile::~objfile): Don't destroy psymbol_cache.
1911         * mdebugread.c (parse_partial_symbols): Update.
1912         * dwarf2read.c (create_addrmap_from_index)
1913         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1914         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1915         (add_partial_subprogram, dwarf2_ranges_read): Update.
1916         * dwarf-index-write.c (write_address_map)
1917         (write_one_signatured_type, recursively_write_psymbols)
1918         (class debug_names, class debug_names, write_psymtabs_to_index):
1919         Update.
1920
1921 2019-01-10  Tom Tromey  <tom@tromey.com>
1922
1923         * symtab.h (SYMBOL_SET_NAMES): Update.
1924         (symbol_set_names): Update.
1925         (MSYMBOL_SET_NAMES): Update.
1926         * symtab.c (symbol_set_names): Change argument to be an
1927         objfile_per_bfd_storage.
1928         * psymtab.c (add_psymbol_to_bcache): Update.
1929         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1930
1931 2019-01-10  Tom Tromey  <tom@tromey.com>
1932
1933         * symtab.c (create_demangled_names_hash): Change argument to be an
1934         objfile_per_bfd_storage.
1935         (symbol_set_names): Update.
1936
1937 2019-01-10  Tom Tromey  <tom@tromey.com>
1938
1939         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1940         init_psymbol_list.
1941         * psymtab.c (init_psymbol_list): Do nothing if already called.
1942         * psympriv.h (init_psymbol_list): Add comment.
1943         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1944         init_psymbol_list.
1945         * dbxread.c (dbx_symfile_read): Unconditionally call
1946         init_psymbol_list.
1947
1948 2019-01-10  Tom Tromey  <tom@tromey.com>
1949
1950         * xcoffread.c (scan_xcoff_symtab): Update.
1951         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1952         "where".
1953         * mdebugread.c (parse_partial_symbols)
1954         (handle_psymbol_enumerators): Update.
1955         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1956         * dbxread.c (read_dbx_symtab): Update.
1957         * psympriv.h (psymbol_placement): New enum.
1958         (add_psymbol_to_list): Update.
1959
1960 2019-01-10  Tom Tromey  <tom@tromey.com>
1961
1962         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1963         static_psymbols parameters.
1964         (scan_xcoff_symtab): Update.
1965         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1966         static_psymbols parameters.
1967         * psympriv.h (start_psymtab_common): Update.
1968         * mdebugread.c (parse_partial_symbols): Update.
1969         * dwarf2read.c (create_partial_symtab): Update.
1970         * dbxread.c (read_dbx_symtab): Update.
1971         (start_psymtab): Remove global_psymbols and static_psymbols
1972         parameters.
1973
1974 2019-01-10  Tom Tromey  <tom@tromey.com>
1975
1976         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1977         * psymtab.c (allocate_psymtab): Add comment.
1978         * psympriv.h (allocate_psymtab): Add comment.
1979         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1980         initializations.
1981         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1982
1983 2019-01-10  Tom Tromey  <tom@tromey.com>
1984
1985         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1986         Don't declare.
1987         * mipsread.c: Include mdebugread.h.
1988         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1989         Declare.
1990         * elfread.c: Include mdebugread.h.
1991
1992 2019-01-09  Tom Tromey  <tom@tromey.com>
1993
1994         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1995         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1996         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1997         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1998         (psym_lookup_symbol, psym_find_last_source_symtab)
1999         (psym_forget_cached_source_info, psym_print_stats)
2000         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2001         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2002         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2003         (psym_find_compunit_symtab_by_address)
2004         (maintenance_print_psymbols, maintenance_info_psymtabs)
2005         (maintenance_check_psymtabs): Use ranged for.
2006         * psymtab.h (class objfile_psymtabs): New.
2007         (require_partial_symbols): Return objfile_psymtabs.
2008         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2009
2010 2019-01-09  Tom Tromey  <tom@tromey.com>
2011
2012         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2013         (find_pc_mapped_section, list_overlays_command)
2014         (map_overlay_command, unmap_overlay_command)
2015         (simple_overlay_update): Use all_objfiles.
2016         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2017         * printcmd.c (info_symbol_command): Use all_objfiles.
2018         * objfiles.h (ALL_OBJSECTIONS): Remove.
2019         * maint.c (maintenance_translate_address): Use all_objfiles.
2020         * gcore.c (gcore_create_callback): Use all_objfiles.
2021         (objfile_find_memory_regions): Likewise.
2022
2023 2019-01-09  Tom Tromey  <tom@tromey.com>
2024
2025         * symtab.c (find_line_symtab, info_sources_command)
2026         (make_source_files_completion_list): Use objfile_compunits.
2027         * source.c (select_source_symtab): Use objfile_compunits.
2028         * objfiles.h (struct objfile): Update comment.
2029         (ALL_OBJFILES): Remove.
2030         (ALL_FILETABS): Remove.
2031         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2032         objfile_compunits.
2033
2034 2019-01-09  Tom Tromey  <tom@tromey.com>
2035
2036         * symmisc.c (print_objfile_statistics, dump_objfile)
2037         (maintenance_print_symbols): Use compunit_filetabs.
2038         * source.c (forget_cached_source_info_for_objfile): Use
2039         compunit_filetabs.
2040         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2041         (ALL_FILETABS): Use compunit_filetabs.
2042         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2043         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2044
2045 2019-01-09  Tom Tromey  <tom@tromey.com>
2046
2047         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2048         (compunit_filetabs): New.
2049         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2050         compunit_filetabs.
2051         (info_sources_command, make_source_files_completion_list): Remove
2052         declaration.
2053         * symmisc.c (print_objfile_statistics, dump_objfile)
2054         (maintenance_print_symbols): Remove declaration.
2055         (maintenance_info_symtabs): Use compunit_filetabs.
2056         (maintenance_info_line_tables): Likewise.
2057         * source.c (select_source_symtab): Change local variable name.
2058         (forget_cached_source_info_for_objfile): Remove declaration.
2059         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2060         * objfiles.c (objfile_relocate1): Remove declaration.
2061         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2062         declaration.
2063         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2064         * coffread.c (coff_symtab_read): Remove declaration.
2065         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2066         compunit_filetabs.
2067
2068 2019-01-09  Tom Tromey  <tom@tromey.com>
2069
2070         * symtab.c (lookup_objfile_from_block)
2071         (find_pc_sect_compunit_symtab, search_symbols)
2072         (default_collect_symbol_completion_matches_break_on): Use
2073         objfile_compunits.
2074         * objfiles.h (ALL_COMPUNITS): Remove.
2075         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2076         * cp-support.c (add_symbol_overload_list_qualified): Use
2077         objfile_compunits.
2078         * ada-lang.c (ada_collect_symbol_completion_matches)
2079         (ada_add_global_exceptions): Use objfile_compunits.
2080
2081 2019-01-09  Tom Tromey  <tom@tromey.com>
2082
2083         * source.c (select_source_symtab)
2084         (forget_cached_source_info_for_objfile): Remove declaration.
2085         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2086         declaration.
2087         * maint.c (count_symtabs_and_blocks): Remove declaration.
2088         * cp-support.c (add_symbol_overload_list_qualified): Remove
2089         declaration.
2090         * coffread.c (coff_symtab_read): Remove declaration.
2091         * symtab.c (lookup_symbol_in_objfile_symtabs)
2092         (basic_lookup_transparent_type_1): Use objfile_compunits.
2093         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2094         (info_sources_command, search_symbols)
2095         (default_collect_symbol_completion_matches_break_on)
2096         (make_source_files_completion_list): Remove declaration.
2097         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2098         (ada_collect_symbol_completion_matches)
2099         (ada_add_global_exceptions): Remove declaration.
2100         * linespec.c (iterate_over_all_matching_symtabs): Use
2101         objfile_compunits.
2102         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2103         (class objfile_compunits): New.
2104         (ALL_COMPUNITS): Use objfile_compunits.
2105         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2106         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2107         objfile_compunits.
2108         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2109
2110 2019-01-09  Tom Tromey  <tom@tromey.com>
2111
2112         * symtab.c (search_symbols)
2113         (default_collect_symbol_completion_matches_break_on): Use
2114         objfile_msymbols.
2115         * ada-lang.c (ada_lookup_simple_minsym)
2116         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2117         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2118         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2119         objfile_msymbols.
2120         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2121         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2122         * objc-lang.c (find_methods): Use objfile_msymbols.
2123         (info_selectors_command, info_classes_command): Likewise.
2124         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2125         * objfiles.h (class objfile_msymbols): New.
2126         (ALL_OBJFILE_MSYMBOLS): Remove.
2127         (ALL_MSYMBOLS): Remove.
2128
2129 2019-01-09  Tom Tromey  <tom@tromey.com>
2130
2131         * common/next-iterator.h (next_adapter): Add Iterator template
2132         parameter.
2133         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2134         (class all_objfiles_safe): New.
2135         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2136         * objfiles.c (put_objfile_before): Update comment.
2137         (add_separate_debug_objfile): Likewise.
2138         (free_all_objfiles): Use all_objfiles_safe.
2139         (objfile_purge_solibs): Likewise.
2140
2141 2019-01-09  Tom Tromey  <tom@tromey.com>
2142
2143         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2144         (expand_symtab_containing_pc, lookup_static_symbol)
2145         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2146         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2147         all_objfiles.
2148         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2149         * breakpoint.c (create_overlay_event_breakpoint)
2150         (create_longjmp_master_breakpoint)
2151         (create_std_terminate_master_breakpoint)
2152         (create_exception_master_breakpoint): Use all_objfiles.
2153         * linux-thread-db.c (try_thread_db_load_from_pdir)
2154         (has_libpthread): Use all_objfiles.
2155         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2156         * linespec.c (iterate_over_all_matching_symtabs)
2157         (search_minsyms_for_name): Use all_objfiles.
2158         * maint.c (maintenance_info_sections): Use all_objfiles.
2159         * main.c (captured_main_1): Use all_objfiles.
2160         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2161         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2162         * guile/scm-pretty-print.c
2163         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2164         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2165         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2166         (maintenance_print_msymbols): Use all_objfiles.
2167         * source.c (select_source_symtab): Use all_objfiles.
2168         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2169         * symfile.c (remove_symbol_file_command)
2170         (expand_symtabs_matching, map_symbol_filenames): Use
2171         all_objfiles.
2172         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2173         all_objfiles.
2174         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2175         * objc-lang.c (find_methods): Use all_objfiles.
2176         * objfiles.c (have_partial_symbols, have_full_symbols)
2177         (have_minimal_symbols, qsort_cmp)
2178         (default_iterate_over_objfiles_in_search_order): Use
2179         all_objfiles.
2180         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2181         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2182         (maintenance_check_psymtabs): Use all_objfiles.
2183         (ALL_PSYMTABS): Remove.
2184         * compile/compile-object-run.c (do_module_cleanup): Use
2185         all_objfiles.
2186         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2187         * cp-support.c (add_symbol_overload_list_qualified): Use
2188         all_objfiles.
2189         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2190         Use all_objfiles.
2191         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2192         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2193         all_objfiles.
2194         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2195         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2196         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2197         Uses all_objfiles.
2198         * solib.c (solib_read_symbols): Use all_objfiles
2199
2200 2019-01-09  Tom Tromey  <tom@tromey.com>
2201
2202         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2203         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2204         all_objfiles.
2205         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2206         * symmisc.c (print_symbol_bcache_statistics)
2207         (print_objfile_statistics, maintenance_print_objfiles)
2208         (maintenance_info_symtabs, maintenance_check_symtabs)
2209         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2210         all_objfiles.
2211         * source.c (forget_cached_source_info): Use all_objfiles.
2212         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2213         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2214         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2215         * objfiles.c (update_section_map): Use all_objfiles.
2216         (shared_objfile_contains_address_p): Likewise.
2217         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2218         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2219
2220 2019-01-09  Tom Tromey  <tom@tromey.com>
2221
2222         * common/next-iterator.h: New file.
2223         * objfiles.h (class all_objfiles): New.
2224         (struct objfile_iterator): New.
2225
2226 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2227
2228         * NEWS: Move the description of the changed "frame", "select-frame",
2229          and "info frame" commands to the Changed commands section.
2230
2231 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2232
2233         * gdbtypes.c (check_stub_method_group): Remove handling of old
2234         mangling schemes.
2235         * linespec.c (find_methods): Likewise.
2236         * stabsread.c (read_member_functions): Likewise.
2237         * valops.c (search_struct_method): Likewise.
2238         (value_struct_elt_for_reference): Likewise.
2239         * NEWS: Mention this change.
2240
2241 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2242
2243         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2244         print_source_lines.
2245         * source.c (print_source_lines_base): Update line number check.
2246         (print_source_lines): New function.
2247         (source_lines_range::source_lines_range): New function.
2248         * source.h (class source_lines_range): New class.
2249         (print_source_lines): New declaration.
2250
2251 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2252
2253         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2254
2255 2019-01-08  Tom Tromey  <tom@tromey.com>
2256             Simon Marchi  <simon.marchi@ericsson.com>
2257
2258         PR gdb/24060
2259         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2260         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2261         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2262         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2263         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2264         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2265
2266 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * source.c (select_source_symtab): Move header comment to
2269         declaration in source.h.
2270         (forget_cached_source_info_for_objfile): Likewise.
2271         (forget_cached_source_info): Likewise.
2272         (identify_source_line): Likewise.
2273         * source.h (identify_source_line): Move declaration from symtab.h
2274         and add comment from source.c
2275         (print_source_lines): Likewise.
2276         (forget_cached_source_info_for_objfile): Likewise.
2277         (forget_cached_source_info): Likewise.
2278         (select_source_symtab): Likewise.
2279         (enum print_source_lines_flag): Move definition from symtab.h.
2280         * symtab.h (identify_source_line): Move declaration to source.h.
2281         (print_source_lines): Likewise.
2282         (forget_cached_source_info_for_objfile): Likewise.
2283         (forget_cached_source_info): Likewise.
2284         (select_source_symtab): Likewise.
2285         (enum print_source_lines_flag): Move definition to source.h.
2286         * tui/tui-hooks.c: Add 'source.h' include.
2287
2288 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * source.c (print_source_lines_base): Handle requests to print
2291         reverse line number sequences, and guard against empty lines
2292         string.
2293
2294 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2295
2296         * source.c (print_source_lines_base): Fix skip of '\r' if next
2297         character is '\n'.
2298
2299 2019-01-06  Tom Tromey  <tom@tromey.com>
2300
2301         * c-exp.y (struct c_parse_state) <macro_original_text,
2302         expansion_obstack>: New member.
2303         (macro_original_text, expansion_obstack): Remove globals.
2304         (scan_macro_expansion, scanning_macro_expansion)
2305         (finished_macro_expansion): Update.
2306         (scan_macro_cleanup): Remove.
2307         (yylex, c_parse): Update.
2308
2309 2019-01-06  Tom Tromey  <tom@tromey.com>
2310
2311         * c-exp.y (struct c_parse_state) <strings>: New member.
2312         (operator_stoken): Update.
2313
2314 2019-01-06  Tom Tromey  <tom@tromey.com>
2315
2316         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2317         (union type_stack_elt) <typelist_val>: Now a pointer to
2318         std::vector.
2319         (type_stack_cleanup): Don't declare.
2320         (push_typelist): Update.
2321         * parse.c (pop_typelist): Return a std::vector.
2322         (push_typelist): Take a std::vector.
2323         (follow_types): Update.  Do not free args.
2324         (type_stack_cleanup): Remove.
2325         * c-exp.y (struct c_parse_state): New.
2326         (cpstate): New global.
2327         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2328         (nonempty_typelist): Update.
2329         (func_mod): Create a new vector.
2330         (c_parse): Create a c_parse_state.
2331         (check_parameter_typelist): Do not delete params.
2332         (function_method): Update.  Do not delete type_list.
2333
2334 2019-01-06  Tom Tromey  <tom@tromey.com>
2335
2336         PR gdb/28155:
2337         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2338         check_typedef.
2339         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2340         (print_return_value): Likewise.
2341
2342 2019-01-05  Tom Tromey  <tom@tromey.com>
2343
2344         * contrib/cleanup_check.py: Remove.
2345         * contrib/gcc-with-excheck: Remove.
2346         * contrib/exsummary.py: Remove.
2347         * contrib/excheck.py: Remove.
2348
2349 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2350
2351         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2352         NULL. Initialize tpprev to NULL instead of assigning it
2353         to NULL on the next statement.
2354         * windows-nat.c (windows_delete_thread): Remove check for
2355         main_thread_id before printing thread exit notifications.
2356         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2357         Remove thread ID check against main_thread_id.
2358         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2359         windows_delete_thread.
2360         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2361
2362 2019-01-04  Tom Tromey  <tom@tromey.com>
2363
2364         * compile/compile.c (_initialize_compile): Use upper case for
2365         metasyntactic variables.
2366         * symmisc.c (_initialize_symmisc): Use upper case for
2367         metasyntactic variables.
2368         * psymtab.c (_initialize_psymtab): Use upper case for
2369         metasyntactic variables.
2370         * demangle.c (demangle_command): Use upper case for metasyntactic
2371         variables.
2372         (_initialize_demangler): Likewise.
2373         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2374         variables.
2375
2376 2019-01-03  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2379
2380 2019-01-03  Tom Tromey  <tom@tromey.com>
2381
2382         * python/py-symtab.c (salpy_str): Update.
2383         (struct salpy_sal_object) <symtab>: Now a PyObject.
2384         (salpy_dealloc): Update.
2385         (del_objfile_sal): Use gdbpy_ref.
2386
2387 2019-01-03  Tom Tromey  <tom@tromey.com>
2388
2389         * python/py-type.c (convert_field): Use new_reference.  Return
2390         gdbpy_ref.
2391         (make_fielditem): Return gdbpy_ref.
2392         (typy_fields): Update.
2393         (typy_getitem): Update.
2394         (field_name): Return gdbpy_ref.  Use new_reference.
2395         (typy_iterator_iternext): Update.
2396
2397 2019-01-03  Tom Tromey  <tom@tromey.com>
2398
2399         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2400
2401 2019-01-03  Tom Tromey  <tom@tromey.com>
2402
2403         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2404         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2405         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2406         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2407         (pspy_set_type_printers): Likewise.
2408         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2409         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2410         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2411         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2412         (objfpy_set_type_printers): Likewise.
2413
2414 2019-01-03  Tom Tromey  <tom@tromey.com>
2415
2416         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2417         (gdbpy_print_stack): Use gdbpy_err_fetch.
2418         * python/python-internal.h (class gdbpy_err_fetch): New class.
2419         (class gdbpy_enter) <m_error_type, m_error_value,
2420         m_error_traceback>: Remove.
2421         <m_error>: New member.
2422         (gdbpy_exception_to_string): Don't declare.
2423         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2424         * python/py-value.c (convert_value_from_python): Use
2425         gdbpy_err_fetch.
2426         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2427         gdbpy_exception_to_string.
2428         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2429         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2430         gdbpy_err_fetch.
2431
2432 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2433
2434         * linux-nat.c (delete_lwp_cleanup): Delete.
2435         (struct lwp_deleter): New struct.
2436         (lwp_info_up): New typedef.
2437         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2438         lwp_info_up.
2439
2440 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2441
2442         * linux-fork.c (class scoped_switch_fork_info): New class.
2443         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2444
2445 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2446
2447         * valops.c (find_overload_match): Remove use of null_cleanup, and
2448         calls to do_cleanups.
2449
2450 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2451
2452         * compile/compile-cplus-types.c
2453         (compile_cplus_instance::decl_name): Handle changes to
2454         cp_func_name.
2455         * cp-support.c (cp_func_name): Update header comment, update
2456         return type.
2457         * cp-support.h (cp_func_name): Update return type in declaration.
2458         * valops.c (find_overload_match): Move temp_func local to top
2459         level of function and change its type.  Use temp_func to hold and
2460         delete temporary string obtained from cp_func_name.
2461
2462 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2463
2464         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2465         gdb::char_vector, remove cleanup, and update uses of `msg`.
2466
2467 2019-01-03  Jim Wilson  <jimw@sifive.com>
2468
2469         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2470
2471 2019-01-02  Tom Tromey  <tom@tromey.com>
2472
2473         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2474         (tdesc_parse_xml): Remove cleanups.
2475         * target-descriptions.h (make_cleanup_free_target_description):
2476         Don't declare.
2477         (target_desc_deleter): New struct.
2478         (target_desc_up): New typedef.
2479         * target-descriptions.c (target_desc_deleter::operator()): Rename
2480         from free_target_description.
2481         (make_cleanup_free_target_description): Remove.
2482
2483 2019-01-02  Tom Tromey  <tom@tromey.com>
2484
2485         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2486         constructor, destructor.
2487         (linespec_parser): Remove typedef.
2488         (~linespec_parser): Rename from linespec_parser_delete.
2489         (linespec_lex_to_end, linespec_complete_label)
2490         (linespec_complete): Update.
2491         (decode_line_full): Remove cleanups.
2492         (decode_line_1): Update.
2493
2494 2019-01-02  Tom Tromey  <tom@tromey.com>
2495
2496         * python/python-internal.h (inferior_to_inferior_object): Change
2497         return type.
2498         * python/py-exitedevent.c (create_exited_event_object): Update.
2499         * python/py-inferior.c (inferior_to_inferior_object): Return
2500         gdbpy_ref.
2501         (python_new_inferior, python_inferior_deleted)
2502         (thread_to_thread_object, delete_thread_object)
2503         (build_inferior_list, gdbpy_selected_inferior): Update.
2504         * python/py-infthread.c (create_thread_object): Update.  Also fail
2505         if inferior_to_inferior_object fails.
2506
2507 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2508
2509         * inferior.h (class inferior) <displaced_step_state>: New field.
2510         * infrun.h (struct displaced_step_state): Move here from
2511         infrun.c.  Initialize fields, add constructor.
2512         <inf>: Remove field.
2513         <reset>: New method.
2514         * infrun.c (struct displaced_step_inferior_state): Move to
2515         infrun.h.
2516         (displaced_step_inferior_states): Remove.
2517         (get_displaced_stepping_state): Adust.
2518         (displaced_step_in_progress_any_inferior): Adjust.
2519         (displaced_step_in_progress_thread): Adjust.
2520         (displaced_step_in_progress): Adjust.
2521         (add_displaced_stepping_state): Remove.
2522         (get_displaced_step_closure_by_addr): Adjust.
2523         (remove_displaced_stepping_state): Remove.
2524         (infrun_inferior_exit): Call displaced_step_state.reset.
2525         (use_displaced_stepping): Don't check for NULL.
2526         (displaced_step_prepare_throw): Call
2527         get_displaced_stepping_state.
2528         (displaced_step_fixup): Don't check for NULL.
2529         (prepare_for_detach): Don't check for NULL.
2530
2531 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2532
2533         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2534          in case of call that did not complete.
2535
2536 2019-01-02  Andrey Utkin  <autkin@undo.io>
2537
2538         * symfile.c (find_separate_debug_file): Fix search of debug files for
2539         remote debuggee.
2540
2541 2019-01-02  Tom Tromey  <tom@tromey.com>
2542
2543         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2544         indentation.
2545         * python/py-frame.c (frapy_older): Remove cast.
2546         (frapy_newer): Likewise.
2547         * python/py-breakpoint.c (local_setattro): Remove cast.
2548         * python/py-arch.c (archpy_name): Remove local variable.
2549         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2550
2551 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2552
2553         * unittests/basic_string_view/element_access/char/empty.cc:
2554         Fix year range in copyright header.
2555
2556 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2557
2558         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2559         Delete.
2560         <operator==>: Update with for removed field.
2561         <hash>: Likewise.
2562         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2563         <isa_features>: ...this.
2564         <abi_features>: New field.
2565         (riscv_isa_flen): Update comment.
2566         (riscv_abi_xlen): New declaration.
2567         (riscv_abi_flen): New declaration.
2568         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2569         isa_features.
2570         (riscv_abi_xlen): New function.
2571         (riscv_isa_flen): Update to get answer from isa_features.
2572         (riscv_abi_flen): New function.
2573         (riscv_has_fp_abi): Update to get answer from abi_features.
2574         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2575         xlen and flen.
2576         (riscv_call_info) <xlen, flen>: Update comment.
2577         (riscv_call_arg_struct): Remove invalid assertions
2578         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2579         is removed.
2580         (riscv_gdbarch_init): Gather isa features and abi features
2581         separately, ensure both match on the gdbarch when reusing an old
2582         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2583         a target with 64-bit float hardware.
2584
2585 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2586
2587         * source.c (search_command_helper): Stop reverse search
2588         when line 1 has been searched.
2589
2590 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2591
2592         * record-full.c (record_full_base_target::close): Rewrite
2593         record_full_core_buf_list free logic.
2594
2595 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2596
2597         * break-catch-syscall.c (print_one_catch_syscall): xfree
2598         the last text.
2599
2600 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2601
2602         * top.c (print_gdb_version): Update Copyright year in version
2603         message.
2604
2605 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2606
2607         Update copyright year range in all GDB files.
2608
2609 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2610
2611         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2612
2613 For older changes see ChangeLog-2018.
2614 \f
2615 Local Variables:
2616 mode: change-log
2617 left-margin: 8
2618 fill-column: 74
2619 version-control: never
2620 coding: utf-8
2621 End:
2622