gdb/ChangeLog

   1 2019-03-14  Tom Tromey  <tromey@adacore.com>
   2
   3         * NEWS: Add item for "style sources" commands.
   4         * source-cache.c (source_cache::get_source_lines): Check
   5         source_styling.
   6         * cli/cli-style.c (source_styling): New global.
   7         (_initialize_cli_style): Add "style sources" commands.
   8         (show_style_sources): New function.
   9         * cli/cli-style.h (source_styling): Declare.
  10
  11 2019-03-14  Pedro Alves  <palves@redhat.com>
  12             Tom Tromey  <tromey@adacore.com>
  13
  14         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  15         * tui/tui-winsource.c (tui_refill_source_window): New function,
  16         from...
  17         (tui_horizontal_source_scroll): ... here.  Move some logic.
  18         * cli/cli-style.c (set_style_enabled): Notify new observable.
  19         * tui/tui-hooks.c (tui_redisplay_source): New function.
  20         (tui_attach_detach_observers): Attach or detach
  21         tui_redisplay_source.
  22         * observable.h (source_styling_changed): New observable.
  23         * observable.c: Define source_styling_changed observable.
  24
  25 2019-03-13  Tom Tromey  <tromey@adacore.com>
  26
  27         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
  28         (i386_gnu_nat_target::store_registers): Update.
  29         * target-debug.h (target_debug_print_std_string): New macro.
  30         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
  31         * windows-tdep.c (display_one_tib): Update.
  32         * tui/tui-stack.c (tui_make_status_line): Update.
  33         * top.c (print_inferior_quit_action): Update.
  34         * thread.c (thr_try_catch_cmd): Update.
  35         (add_thread_with_info): Update.
  36         (thread_target_id_str): Update.
  37         (thr_try_catch_cmd): Update.
  38         (thread_command): Update.
  39         (thread_find_command): Update.
  40         * record-btrace.c (record_btrace_target::info_record)
  41         (record_btrace_resume_thread, record_btrace_target::resume)
  42         (record_btrace_cancel_resume, record_btrace_step_thread)
  43         (record_btrace_target::wait, record_btrace_target::wait)
  44         (record_btrace_target::wait, record_btrace_target::stop): Update.
  45         * progspace.c (print_program_space): Update.
  46         * process-stratum-target.c
  47         (process_stratum_target::thread_address_space): Update.
  48         * linux-fork.c (linux_fork_mourn_inferior)
  49         (detach_checkpoint_command, info_checkpoints_command)
  50         (linux_fork_context): Update.
  51         (linux_fork_detach): Update.
  52         (class scoped_switch_fork_info): Update.
  53         (delete_checkpoint_command): Update.
  54         * infrun.c (follow_fork_inferior): Update.
  55         (follow_fork_inferior): Update.
  56         (proceed_after_vfork_done): Update.
  57         (handle_vfork_child_exec_or_exit): Update.
  58         (follow_exec): Update.
  59         (displaced_step_prepare_throw): Update.
  60         (displaced_step_restore): Update.
  61         (start_step_over): Update.
  62         (resume_1): Update.
  63         (clear_proceed_status_thread): Update.
  64         (proceed): Update.
  65         (print_target_wait_results): Update.
  66         (do_target_wait): Update.
  67         (context_switch): Update.
  68         (stop_all_threads): Update.
  69         (restart_threads): Update.
  70         (finish_step_over): Update.
  71         (handle_signal_stop): Update.
  72         (switch_back_to_stepped_thread): Update.
  73         (keep_going_pass_signal): Update.
  74         (print_exited_reason): Update.
  75         (normal_stop): Update.
  76         * inferior.c (inferior_pid_to_str): Change return type.
  77         (print_selected_inferior): Update.
  78         (add_inferior): Update.
  79         (detach_inferior): Update.
  80         * dummy-frame.c (fprint_dummy_frames): Update.
  81         * dcache.c (dcache_info_1): Update.
  82         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
  83         (btrace_fetch, btrace_clear): Update.
  84         * linux-tdep.c (linux_core_pid_to_str): Change return type.
  85         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
  86         type.
  87         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
  88         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
  89         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
  90         * gdbarch.c, gdbarch.h: Rebuild.
  91         * gdbarch.sh (core_pid_to_str): Change return type.
  92         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
  93         return type.
  94         (windows_nat_target::pid_to_str): Change return type.
  95         (windows_delete_thread): Update.
  96         (windows_nat_target::attach): Update.
  97         (windows_nat_target::files_info): Update.
  98         * target-delegates.c: Rebuild.
  99         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 100         return type.
 101         (sol_thread_target::pid_to_str): Change return type.
 102         * remote.c (class remote_target) <pid_to_str>: Change return
 103         type.
 104         (remote_target::pid_to_str): Change return type.
 105         (extended_remote_target::attach, remote_target::remote_stop_ns)
 106         (remote_target::remote_notif_remove_queued_reply)
 107         (remote_target::push_stop_reply, remote_target::disable_btrace):
 108         Update.
 109         (extended_remote_target::attach): Update.
 110         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 111         type.
 112         (gdbsim_target::pid_to_str): Change return type.
 113         * ravenscar-thread.c (struct ravenscar_thread_target)
 114         <pid_to_str>: Change return type.
 115         (ravenscar_thread_target::pid_to_str): Change return type.
 116         * procfs.c (class procfs_target) <pid_to_str>: Change return
 117         type.
 118         (procfs_target::pid_to_str): Change return type.
 119         (procfs_target::attach): Update.
 120         (procfs_target::detach): Update.
 121         (procfs_target::fetch_registers): Update.
 122         (procfs_target::store_registers): Update.
 123         (procfs_target::wait): Update.
 124         (procfs_target::files_info): Update.
 125         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 126         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 127         return type.
 128         (nto_procfs_target::pid_to_str): Change return type.
 129         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 130         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 131         return type.
 132         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 133         (exit_lwp): Update.
 134         (attach_proc_task_lwp_callback, get_detach_signal)
 135         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 136         (linux_nat_target::resume, wait_lwp, stop_callback)
 137         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 138         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 139         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 140         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 141         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 142         type.
 143         (inf_ptrace_target::attach): Update.
 144         (inf_ptrace_target::files_info): Update.
 145         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 146         type.
 147         (go32_nat_target::pid_to_str): Change return type.
 148         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 149         (gnu_nat_target::wait): Update.
 150         (gnu_nat_target::wait): Update.
 151         (gnu_nat_target::resume): Update.
 152         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 153         (fbsd_nat_target::wait): Update.
 154         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 155         type.
 156         (darwin_nat_target::attach): Update.
 157         * corelow.c (class core_target) <pid_to_str>: Change return type.
 158         (core_target::pid_to_str): Change return type.
 159         * target.c (normal_pid_to_str): Change return type.
 160         (default_pid_to_str): Likewise.
 161         (target_pid_to_str): Change return type.
 162         (target_translate_tls_address): Update.
 163         (target_announce_detach): Update.
 164         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 165         return type.
 166         (bsd_uthread_target::pid_to_str): Change return type.
 167         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 168         type.
 169         (bsd_kvm_target::pid_to_str): Change return type.
 170         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 171         return type.
 172         (aix_thread_target::pid_to_str): Change return type.
 173         * target.h (struct target_ops) <pid_to_str>: Change return type.
 174         (target_pid_to_str, normal_pid_to_str): Likewise.
 175         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 176         type.
 177         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 178         type.
 179         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 180         return type.
 181         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 182         type.
 183         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 184         type.
 185         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 186         return type.
 187
 188 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 189
 190         * NEWS: Mention that the new default MI version is 3.  Mention
 191         changes to the output of commands and events that deal with
 192         multi-location breakpoints.
 193         * breakpoint.c: Include "mi/mi-out.h".
 194         (print_one_breakpoint): Change output syntax if using MI version
 195         >= 3.
 196         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 197         New.
 198         (mi_multi_location_breakpoint_output_fixed): New.
 199         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 200         (mi_cmd_fix_multi_location_breakpoint_output): New.
 201         (mi_multi_location_breakpoint_output_fixed): New.
 202         * mi/mi-cmds.c (mi_cmds): Register command
 203         -fix-multi-location-breakpoint-output.
 204         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 205         interpreter "mi".
 206
 207 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 208
 209         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 210         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 211         instantiate mi_ui_out based on interpreter name.
 212         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 213         * mi/mi-main.c (mi_load_progress): Likewise.
 214
 215 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 216
 217         * NEWS: Combine separate "New targets" sections for 8.3.
 218
 219 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 220
 221         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 222         (ppcfbsd_init_abi): Install gdbarch
 223         "fetch_tls_load_module_address" and "get_thread_local_address"
 224         methods.
 225
 226 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 227
 228         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 229         (riscv_fbsd_init_abi): Install gdbarch
 230         "fetch_tls_load_module_address" and "get_thread_local_address"
 231         methods.
 232
 233 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 234
 235         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 236         (i386fbsd_init_abi): Install gdbarch
 237         "fetch_tls_load_module_address" and "get_thread_local_address"
 238         methods.
 239
 240 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 241
 242         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 243         (amd64fbsd_init_abi): Install gdbarch
 244         "fetch_tls_load_module_address" and "get_thread_local_address"
 245         methods.
 246
 247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 248
 249         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 250         (struct fbsd_pspace_data): New type.
 251         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 252         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 253         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 254         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 255         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 256
 257 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 258
 259         * gdbtypes.c (lookup_struct_elt): New function.
 260         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 261         * gdbtypes.h (struct struct_elt): New type.
 262         (lookup_struct_elt): New prototype.
 263
 264 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 265
 266         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 267         remove disabled code block.
 268
 269 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 270
 271         * gdbarch.sh (get_thread_local_address): New method.
 272         * gdbarch.h, gdbarch.c: Regenerate.
 273         * target.c (target_translate_tls_address): Use
 274         gdbarch_get_thread_local_address if present instead of
 275         target::get_thread_local_address.
 276
 277 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 278
 279         * target.h (target::get_thread_local_address): Update comment.
 280
 281 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 282
 283         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 284         objfile->separate_debug_objfile_backlink if not NULL.
 285
 286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 287
 288         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 289         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 290         (amd64bsd_store_inferior_registers): Likewise.
 291         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 292         Enable segment base registers.
 293         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 294         PT_GETFSBASE and PT_GETGSBASE.
 295         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 296         PT_SETGSBASE.
 297         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 298         segment base registers.
 299         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 300
 301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 302
 303         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 304         Update calls to i386_target_description to add 'segments'
 305         parameter.
 306         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 307         add segment base registers.
 308         * arch/i386.c (i386_create_target_description): Add 'segments'
 309         parameter to enable segment base registers.
 310         * arch/i386.h (i386_create_target_description): Likewise.
 311         * features/i386/32bit-segments.xml: New file.
 312         * features/i386/32bit-segments.c: Generate.
 313         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 314         call to i386_target_description to add 'segments' parameter.
 315         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 316         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 317         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 318         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 319         if feature is present.
 320         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 321         Add 'segments' parameter to call to i386_target_description.
 322         (i386_target_description): Add 'segments' parameter to enable
 323         segment base registers.
 324         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 325         to call to i386_target_description.
 326         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 327         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 328         Define I386_NUM_REGS.
 329         (i386_target_description): Add 'segments' parameter to enable
 330         segment base registers.
 331
 332 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 333
 334         PR/24325
 335         * source-cache.c: #undef open and close, to avoid unresolved
 336         externals during linking.
 337
 338 2019-03-12  Tom Tromey  <tromey@adacore.com>
 339
 340         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 341         const.  Add initializers.
 342         (_initialize_remote): Don't initialize ptid globals.
 343
 344 2019-03-12  Pedro Alves  <palves@redhat.com>
 345
 346         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 347
 348 2019-03-12  Pedro Alves  <palves@redhat.com>
 349
 350         * cp-name-parser.y (main): Remove unused 'len' variable.
 351
 352 2019-03-12  Tom Tromey  <tromey@adacore.com>
 353
 354         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 355         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 356
 357 2019-03-12  Tom Tromey  <tromey@adacore.com>
 358
 359         * linux-nat.c (iterate_over_lwps): Update.
 360         (stop_callback): Remove parameter.
 361         (stop_wait_callback, detach_callback, resume_set_callback)
 362         (select_singlestep_lwp_callback, set_ignore_sigint)
 363         (status_callback, resumed_callback, resume_clear_callback)
 364         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 365         data parameter.
 366         (linux_nat_target::detach, linux_nat_target::resume)
 367         (linux_stop_and_wait_all_lwps, select_event_lwp)
 368         (linux_nat_filter_event, linux_nat_wait_1)
 369         (linux_nat_target::kill, linux_nat_target::stop)
 370         (linux_nat_target::stop): Update.
 371         (linux_nat_resume_callback): Change type.
 372         (resume_stopped_resumed_lwps, count_events_callback)
 373         (select_event_lwp_callback): Likewise.
 374         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 375         * arm-linux-nat.c (struct update_registers_data): Remove.
 376         (update_registers_callback): Change type.
 377         (arm_linux_insert_hw_breakpoint1): Update.
 378         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 379         parameter.
 380         (x86_linux_dr_set_addr): Update.
 381         (x86_linux_dr_set_control): Update.
 382         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 383         (iterate_over_lwps): Use gdb::function_view.
 384         * nat/aarch64-linux-hw-point.c (struct
 385         aarch64_dr_update_callback_param): Remove.
 386         (debug_reg_change_callback): Change type.
 387         (aarch64_notify_debug_reg_change): Update.
 388         * s390-linux-nat.c (s390_refresh_per_info): Update.
 389
 390 2019-03-11  Tom Tromey  <tromey@adacore.com>
 391
 392         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 393         redundant assignment to "this_cu".
 394
 395 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 396
 397         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 398
 399 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 400
 401         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 402         from...
 403         (rank_one_type): ... this.
 404
 405 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 406
 407         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 408         from...
 409         (rank_one_type): ... this.
 410
 411 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 412
 413         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 414         from...
 415         (rank_one_type): ... this.
 416
 417 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 418
 419         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 420         from...
 421         (rank_one_type): ... this.
 422
 423 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 424
 425         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 426         from...
 427         (rank_one_type): ... this.
 428
 429 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 430
 431         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 432         from...
 433         (rank_one_type): ... this.
 434
 435 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 436
 437         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 438         from...
 439         (rank_one_type): ... this.
 440
 441 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 442
 443         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 444         from...
 445         (rank_one_type): ... this.
 446
 447 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 448
 449         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 450         from...
 451         (rank_one_type): ... this.
 452
 453 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 454
 455         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 456         from...
 457         (rank_one_type): ... this.
 458
 459 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 460
 461         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 462         from...
 463         (rank_one_type): ... this.
 464
 465 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 466
 467         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 468         from...
 469         (rank_one_type): ... this.
 470
 471 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 472
 473         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 474         inferior-events' shows the example events.
 475
 476 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 477
 478         Support styling on native MS-Windows console
 479
 480         PR/24315
 481         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 482         on MS-Windows if $TERM is not defined.
 483
 484         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 485
 486         * posix-hdep.c (gdb_console_fputs):
 487         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 488         functions.
 489         * ui-file.h (gdb_console_fputs): Add prototype.
 490
 491         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 492         back to fputs only if the former returns zero.
 493
 494 2019-03-07  Tom Tromey  <tom@tromey.com>
 495
 496         * symmisc.c (print_symbol_bcache_statistics): Update.
 497         (print_objfile_statistics): Update.
 498         * symfile.c (allocate_symtab): Update.
 499         * stabsread.c: Don't include bcache.h.
 500         * psymtab.h (struct psymbol_bcache): Don't declare.
 501         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 502         (psymbol_bcache_init, psymbol_bcache_free)
 503         (psymbol_bcache_get_bcache): Don't declare.
 504         * psymtab.c (struct psymbol_bcache): Remove.
 505         (psymtab_storage::psymtab_storage): Update.
 506         (psymtab_storage::~psymtab_storage): Update.
 507         (psymbol_bcache_init, psymbol_bcache_free)
 508         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 509         (add_psymbol_to_bcache): Update.
 510         (allocate_psymtab): Update.
 511         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 512         macro_cache>: No longer pointers.
 513         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 514         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 515         * macrotab.c (macro_bcache): Update.
 516         * macroexp.c: Don't include bcache.h.
 517         * gdbtypes.c (check_types_worklist): Update.
 518         (types_deeply_equal): Remove TRY/CATCH.  Update.
 519         * elfread.c (elf_symtab_read): Update.
 520         * dwarf2read.c: Don't include bcache.h.
 521         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 522         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 523         (print_bcache_statistics, bcache_memory_used): Don't declare.
 524         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 525         methods.  Rename all data members.
 526         * bcache.c (struct bcache): Move to bcache.h.
 527         (bcache::expand_hash_table): Rename from expand_hash_table.
 528         (bcache): Remove.
 529         (bcache::insert): Rename from bcache_full.
 530         (bcache::compare): Rename from bcache_compare.
 531         (bcache_xmalloc): Remove.
 532         (bcache::~bcache): Rename from bcache_xfree.
 533         (bcache::print_statistics): Rename from print_bcache_statistics.
 534         (bcache::memory_used): Rename from bcache_memory_used.
 535
 536 2019-03-07  Pedro Alves  <palves@redhat.com>
 537
 538         * infrun.c (normal_stop): Also check for
 539         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 540
 541 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 542
 543         * f-lang.c (value_from_host_double): Moved to...
 544         * value.c (value_from_host_double): ...here.
 545         * value.h (value_from_host_double): Declare.
 546         * guile/scm-math.c (vlscm_convert_typed_number): Use
 547         value_from_host_double.
 548         (vlscm_convert_number): Likewise.
 549         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 550         * python/py-value.c (convert_value_from_python): Likewise.
 551
 552 2019-03-06  Tom Tromey  <tom@tromey.com>
 553
 554         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 555
 556 2019-03-06  Tom Tromey  <tom@tromey.com>
 557
 558         * utils.h (free_current_contents): Don't declare.
 559         * utils.c (free_current_contents): Remove.
 560
 561 2019-03-06  Tom Tromey  <tom@tromey.com>
 562
 563         * top.c (quit_force): Update.
 564         * main.c (captured_command_loop): Update.
 565         * common/new-op.c (operator new): Update.
 566         * common/common-exceptions.c (struct catcher)
 567         <save_cleanup_chain>: Remove member.
 568         (exceptions_state_mc_init): Update.
 569         (exception_try_scope_entry): Return nullptr.
 570         (exception_try_scope_exit, exception_rethrow)
 571         (throw_exception_sjlj, throw_exception_cxx): Update.
 572         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 573         (all_cleanups, do_cleanups, discard_cleanups)
 574         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 575         (restore_cleanups, restore_final_cleanups): Don't declare.
 576         (do_final_cleanups): Remove parameter.
 577         * common/cleanups.c (cleanup_chain, make_cleanup)
 578         (make_cleanup_dtor, all_cleanups, do_cleanups)
 579         (discard_my_cleanups, discard_cleanups)
 580         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 581         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 582         (null_cleanup): Remove.
 583         (do_final_cleanups): Remove parameter.
 584
 585 2019-03-06  Tom Tromey  <tom@tromey.com>
 586
 587         * remote.c (remote_target::remote_parse_stop_reply): Use
 588         unique_xmalloc_ptr.
 589
 590 2019-03-06  Tom Tromey  <tom@tromey.com>
 591
 592         * stabsread.c (struct stabs_field_info): Rename from field_info.
 593         <list, fnlist>: Add initializers.
 594         <obstack>: New member.
 595         (read_member_functions, read_struct_fields, read_baseclasses):
 596         Allocate on obstack.  Don't use cleanups.
 597         (read_one_struct_field, read_member_functions, read_struct_fields)
 598         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 599         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 600         (read_struct_type): Update.
 601
 602 2019-03-06  Tom Tromey  <tom@tromey.com>
 603
 604         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 605         * common/filestuff.h (make_cleanup_close): Don't declare.
 606         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 607         Remove.
 608
 609 2019-03-06  Tom Tromey  <tom@tromey.com>
 610
 611         * solib-aix.c: Use make_scope_exit.
 612
 613 2019-03-06  Tom Tromey  <tom@tromey.com>
 614
 615         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 616         Use make_scope_exit.
 617
 618 2019-03-06  Tom Tromey  <tom@tromey.com>
 619
 620         * solib-svr4.c (disable_probes_interface): Remove parameter.
 621         (svr4_handle_solib_event): Use make_scope_exit.
 622
 623 2019-03-06  Tom Tromey  <tom@tromey.com>
 624
 625         * remote.c (struct stop_reply_deleter): Remove.
 626         (stop_reply_up): Update.
 627         (struct stop_reply): Derive from notif_event.  Don't typedef.
 628         <regcache>: Now a std::vector.
 629         (stop_reply_xfree): Remove.
 630         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 631         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 632         (remote_target::discard_pending_stop_replies): Use delete.
 633         (remote_target::remote_parse_stop_reply): Update.
 634         (remote_target::process_stop_reply): Update.
 635         * remote-notif.h (struct notif_event): Add virtual destructor.
 636         Remove "dtr" member.
 637         (struct notif_client) <alloc_event>: Return a unique_ptr.
 638         (notif_event_xfree): Don't declare.
 639         (notif_event_up): New typedef.
 640         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 641         (notif_event_xfree, do_notif_event_xfree): Remove.
 642         (remote_notif_state_xfree): Update.
 643
 644 2019-03-06  Tom Tromey  <tom@tromey.com>
 645
 646         * infrun.c (displaced_step_clear_cleanup): Now a
 647         forward_scope_exit type.
 648         (displaced_step_prepare_throw): Update.
 649         (displaced_step_fixup): Update.
 650
 651 2019-03-06  Tom Tromey  <tom@tromey.com>
 652
 653         * inferior.h (class inferior): Update comment.
 654         * gdbthread.h (class thread_info): Update comment.
 655
 656 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 657             Tom Tromey  <tom@tromey.com>
 658
 659         * stabsread.h (struct stab_section_list): Remove.
 660         (coffstab_build_psymtabs): Update.
 661         * dbxread.c (symbuf_sections): Now a std::vector.
 662         (sect_idx): New global.
 663         (fill_symbuf): Update.
 664         (coffstab_build_psymtabs): Change type of stabsects parameter.
 665         Update.
 666         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 667         std::vector.
 668         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 669         (coff_locate_sections): Update.
 670         (coff_symfile_read): Remove cleanups.  Update.
 671         (init_stringtab): Add storage parameter.
 672         (free_stringtab, free_stringtab_cleanup): Remove.
 673         (init_lineno): Add storage parameter.
 674         (free_linetab, free_linetab_cleanup): Remove.
 675
 676 2019-03-06  Pedro Alves  <palves@redhat.com>
 677
 678         * linux-fork.c (fork_info::clobber_regs): Delete.
 679         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 680         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 681         comment.  Adjust.
 682         (scoped_switch_fork_info::scoped_switch_fork_info)
 683         (checkpoint_command, linux_fork_context): Adjust
 684         fork_save_infrun_state calls.
 685
 686 2019-03-06  Pedro Alves  <palves@redhat.com>
 687
 688         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 689         (inf_has_multiple_threads): Return 'bool' and rewrite using
 690         inferior_info::threads().
 691
 692 2019-03-06  Pedro Alves  <palves@redhat.com>
 693
 694         * linux-fork.c: Include <list>.
 695         (fork_list): Now a std::list instance.
 696         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 697         (forks_exist_p, find_last_fork): Adjust.
 698         (new_fork): Delete.
 699         (one_fork_p): New.
 700         (add_fork): Adjust.
 701         (free_fork): Delete, folded into fork_info::~fork_info().
 702         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 703         Adjust.
 704         (init_fork_list): Delete.
 705         (linux_fork_killall, linux_fork_mourn_inferior)
 706         (linux_fork_detach, info_checkpoints_command): Adjust.
 707         (_initialize_linux_fork): No longer call init_fork_list.
 708
 709 2019-03-06  Pedro Alves  <palves@redhat.com>
 710
 711         * linux-fork.c (new_fork): New, split out of ...
 712         (add_fork): ... this.  Return void.  Move "first fork" special
 713         case from here, to ...
 714         (checkpoint_command): ... here.
 715         * linux-linux.h (add_fork): Return void.
 716
 717 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 718
 719         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 720
 721 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 722             Chris January  <chris.january@arm.com>
 723             David Lecomber  <david.lecomber@arm.com>
 724
 725         * f-exp.y: New token, UNOP_INTRINSIC.
 726         (exp): New pattern using UNOP_INTRINSIC token.
 727         (f77_keywords): Add 'abs' keyword.
 728         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 729         (value_from_host_double): New function.
 730         (evaluate_subexp_f): Support UNOP_ABS.
 731
 732 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 733
 734         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 735         types.
 736
 737 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 738
 739         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 740         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 741         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 742
 743 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 744
 745         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 746
 747 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 748             Chris January  <chris.january@arm.com>
 749
 750         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 751         * f-exp.y: Define 'KIND' token.
 752         (exp): New pattern for KIND expressions.
 753         (ptype): Handle types with a kind extension.
 754         (direct_abs_decl): Extend to spot kind extensions.
 755         (f77_keywords): Add 'kind' to the list.
 756         (push_kind_type): New function.
 757         (convert_to_kind_type): New function.
 758         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 759         * parse.c (operator_length_standard): Likewise.
 760         * parser-defs.h (enum type_pieces): Add tp_kind.
 761         * std-operator.def: Add UNOP_KIND.
 762
 763 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 764
 765         * f-exp.y (f_parse): Set yydebug.
 766
 767 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 768
 769         * f-lang.c (evaluate_subexp_f): New function.
 770         (exp_descriptor_f): New global.
 771         (f_language_defn): Use exp_descriptor_f instead of
 772         exp_descriptor_standard.
 773
 774 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 775
 776         * f-exp.y (struct token): Add comments.
 777         (dot_ops): Remove uppercase versions and the end marker.
 778         (f77_keywords): Likewise.
 779         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 780         entries in the dot_ops array are case insensitive, and use
 781         strncasecmp to compare strings.  Also some whitespace cleanup in
 782         this area.  Similar for the f77_keywords array, except entries in
 783         this list might be case sensitive.
 784
 785 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 786
 787         * f-exp.y (struct f77_boolean_val): Add comments.
 788         (boolean_values): Remove uppercase versions, and end marker.
 789         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 790         and use strncasecmp to achieve case insensitivity.  Additionally,
 791         perform whitespace cleanup around this code.
 792
 793 2019-03-06  Tom Tromey  <tromey@adacore.com>
 794
 795         * remote-sim.c (gdbsim_target_open): Use result of
 796         gdb_argv::release.
 797
 798 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 799         Dirk Schubert  <dirk.schubert@arm.com>
 800         Chris January  <chris.january@arm.com>
 801
 802         * eval.c (evaluate_subexp_standard): Call Fortran argument
 803         wrapping logic.
 804         * f-lang.c (struct value): A value which can be passed into a
 805         Fortran function call.
 806         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 807         where appropriate.
 808         (struct type): Value ready for a Fortran function call.
 809         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 810         is needed.
 811         * f-lang.h (fortran_argument_convert): Declaration.
 812         (fortran_preserve_arg_pointer): Declaration.
 813         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 814
 815 2019-03-05  Tom Tromey  <tromey@adacore.com>
 816
 817         * python/py-prettyprint.c (print_string_repr): Remove #if.
 818         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 819
 820 2019-03-05  Tom Tromey  <tromey@adacore.com>
 821
 822         * target.c (the_dummy_target): Move later.  Change type to
 823         "dummy_target".
 824         (initialize_targets): Don't initialize the_dummy_target.
 825
 826 2019-03-05  Tom Tromey  <tromey@adacore.com>
 827
 828         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 829         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 830
 831 2019-03-05  Tom Tromey  <tromey@adacore.com>
 832
 833         * windows-nat.c (windows_nat_target::attach)
 834         (windows_nat_target::detach): Don't call gdb_flush.
 835         * valprint.c (generic_val_print, val_print, val_print_string):
 836         Don't call gdb_flush.
 837         * utils.c (defaulted_query): Don't call gdb_flush.
 838         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 839         * target.c (target_announce_detach): Don't call gdb_flush.
 840         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 841         * remote.c (extended_remote_target::attach): Don't call
 842         gdb_flush.
 843         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 844         * printcmd.c (do_examine): Don't call gdb_flush.
 845         (info_display_command): Don't call gdb_flush.
 846         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 847         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 848         * memattr.c (info_mem_command): Don't call gdb_flush.
 849         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 850         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 851         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 852         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 853         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 854         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 855         (gnu_nat_target::detach): Don't call gdb_flush.
 856         * f-valprint.c (f_val_print): Don't call gdb_flush.
 857         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 858         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 859         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 860         gdb_flush.
 861         * c-valprint.c (c_val_print): Don't call gdb_flush.
 862         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 863
 864 2019-03-05  Tom Tromey  <tromey@adacore.com>
 865
 866         * varobj.c (update_dynamic_varobj_children): Update.
 867         (install_default_visualizer): Use reset, not release.
 868         * value.c (set_internalvar): Update.
 869         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 870         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 871         ATTRIBUTE_UNUSED_RESULT.
 872
 873 2019-03-05  Tom Tromey  <tromey@adacore.com>
 874
 875         * remote.c (class scoped_remote_fd) <release>: Add
 876         ATTRIBUTE_UNUSED_RESULT.
 877
 878 2019-03-05  Tom Tromey  <tromey@adacore.com>
 879
 880         * macroexp.c (struct macro_buffer) <release>: Add
 881         ATTRIBUTE_UNUSED_RESULT.
 882
 883 2019-03-05  Tom Tromey  <tromey@adacore.com>
 884
 885         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 886         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 887         ATTRIBUTE_UNUSED_RESULT.
 888
 889 2019-03-05  Tom Tromey  <tromey@adacore.com>
 890
 891         * common/scoped_fd.h (class scoped_fd) <release>: Add
 892         ATTRIBUTE_UNUSED_RESULT.
 893
 894 2019-03-05  Tom Tromey  <tromey@adacore.com>
 895
 896         * parser-defs.h (struct parser_state) <release>: Add
 897         ATTRIBUTE_UNUSED_RESULT.
 898
 899 2019-03-05  Tom Tromey  <tromey@adacore.com>
 900
 901         * utils.h (class gdb_argv) <release>: Add
 902         ATTRIBUTE_UNUSED_RESULT.
 903         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 904
 905 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 906
 907         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 908         for-loop range, to avoid compiler warnings.
 909
 910         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 911         avoid compiler warnings about unused variables.
 912
 913         * NEWS: Mention end of support for native debugging on MS-Windows
 914         before XP.
 915
 916         PR gdb/24292
 917         * common/netstuff.c:
 918         * gdbserver/gdbreplay.c
 919         * gdbserver/remote-utils.c:
 920         * ser-tcp.c:
 921         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 922         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 923         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 924         'getaddrinfo' and 'freeaddrinfo' were not available before
 925         Windows XP, and mingw.org's MinGW headers by default define
 926         _WIN32_WINNT to 0x500.
 927
 928 2019-03-01  Gary Benson <gbenson@redhat.com>
 929
 930         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 931
 932 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 933             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 934
 935         PR gdb/8527
 936         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 937         set_sigint_trap, clear_sigint_trap.
 938
 939 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 940
 941         * target.c (target_detach): Clear the regcache and the
 942         frame cache.
 943
 944 2019-02-27  Pedro Alves  <palves@redhat.com>
 945
 946         * utils.c (set_screen_size): When we cap the height/width sizes,
 947         tweak the corresponding command variable to show "unlimited":
 948
 949 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 950             Pedro Alves  <palves@redhat.com>
 951
 952         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 953         before calling rl_set_screen_size.
 954
 955 2019-02-27  Tom Tromey  <tromey@adacore.com>
 956
 957         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 958         define.
 959         * python/py-value.c: Remove Python 2.4 workaround.
 960         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 961         workaround.
 962         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 963         Python 2.4 workaround.
 964         * python/python-internal.h: Remove Python 2.4 comment.
 965         (Py_ssize_t): Don't define.
 966         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 967         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 968         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 969         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 970         * python/python.c (do_start_initialization): Remove Python 2.4
 971         workaround.
 972         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 973         (print_children): Remove Python 2.4 workaround.
 974         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 975         workaround.
 976         (CHARBUFFERPROC_NAME): Remove.
 977         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 978         Python 2.4 workaround.
 979
 980 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 981
 982         * NEWS: Note minimum Python version.
 983
 984 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 985
 986         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 987         code from these functions.  Remove corresponding ifdefs.  Use
 988         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 989         Remove gotos and target of gotos.
 990         (infpy_search_memory): Likewise.
 991
 992 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 993
 994         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 995         (hppa_gdbarch_init): Don't register deleted functions with
 996         gdbarch.
 997
 998 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 999
1000         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1001         (h8300_unwind_sp): Delete.
1002         (h8300_dummy_id): Delete.
1003         (h8300_gdbarch_init): Don't register deleted functions with
1004         gdbarch.
1005
1006 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1007
1008         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1009         (ft32_unwind_pc): Delete.
1010         (ft32_unwind_sp): Delete.
1011         (ft32_gdbarch_init): Don't register deleted functions with
1012         gdbarch.
1013
1014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1015
1016         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1017         (frv_unwind_pc): Delete.
1018         (frv_unwind_sp): Delete.
1019         (frv_gdbarch_init): Don't register deleted functions with
1020         gdbarch.
1021
1022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1023
1024         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1025         (riscv_unwind_pc): Delete.
1026         (riscv_unwind_sp): Delete.
1027         (riscv_gdbarch_init): Don't register deleted functions with
1028         gdbarch.
1029
1030 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1031
1032         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1033         (csky_unwind_pc): Delete.
1034         (csky_unwind_sp): Delete.
1035         (csky_gdbarch_init): Don't register deleted functions with
1036         gdbarch.
1037
1038 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1039
1040         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1041         (cris_unwind_pc): Delete.
1042         (cris_unwind_sp): Delete.
1043         (cris_gdbarch_init): Don't register deleted functions with
1044         gdbarch.
1045
1046 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1049         (bfin_unwind_pc): Delete.
1050         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1051
1052 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1053
1054         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1055         (arm_unwind_pc): Delete.
1056         (arm_unwind_sp): Delete.
1057         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1058
1059 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1060
1061         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1062         (arc_unwind_pc): Delete.
1063         (arc_unwind_sp): Delete.
1064         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1065
1066 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1067
1068         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1069         (alpha_unwind_pc): Delete.
1070         (alpha_gdbarch_init): Don't register deleted functions with
1071         gdbarch.
1072
1073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1076         (aarch64_unwind_pc): Delete.
1077         (aarch64_unwind_sp): Delete.
1078         (aarch64_gdbarch_init): Don't register deleted functions with
1079         gdbarch.
1080
1081 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1082
1083         * gdbtypes.c (type_align): Don't consider static members when
1084         computing structure alignment.
1085
1086 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1089         return 0 for other types.
1090         * arch-utils.c (default_type_align): Always return 0.
1091         * gdbarch.h: Regenerate.
1092         * gdbarch.sh (type_align): Extend comment.
1093         * gdbtypes.c (type_align): Add additional comments, always call
1094         gdbarch_type_align before applying the default rules.
1095         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1096         generic code will then apply a suitable default.
1097         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1098         types, return 0 for other types.
1099
1100 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1101
1102         * NEWS: Create a new section for the next release branch.
1103         Rename the section of the current branch, now that it has
1104         been cut.
1105
1106 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1107
1108         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1109         * version.in: Bump version to 8.3.50.DATE-git.
1110
1111 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1112
1113         * aix-thread.c (ptid_cmp): Remove unused variable.
1114         (get_signaled_thread): Likewise.
1115         (store_regs_user_thread): Likewise.
1116         (store_regs_kernel_thread): Likewise.
1117         (fetch_regs_kernel_thread): Remove shadowed variable.
1118
1119 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1120
1121         * features/riscv/32bit-cpu.xml: Add register numbers.
1122         * features/riscv/32bit-fpu.c: Regenerate.
1123         * features/riscv/32bit-fpu.xml: Add register numbers.
1124         * features/riscv/64bit-cpu.xml: Add register numbers.
1125         * features/riscv/64bit-fpu.c: Regenerate.
1126         * features/riscv/64bit-fpu.xml: Add register numbers.
1127
1128 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1129
1130         * NEWS: Mention two argument form of gdb.Value constructor.
1131         * python/py-value.c (convert_buffer_and_type_to_value): New
1132         function.
1133         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1134         Add support for handling an optional second argument.  Call
1135         convert_buffer_and_type_to_value as appropriate.
1136         * python/python-internal.h (Py_buffer_deleter): New struct.
1137         (Py_buffer_up): New typedef.
1138
1139 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1140
1141         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1142         instead of releasing ownership.
1143
1144 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1145
1146         * dwarf2read.c (open_and_init_dwp_file): Call
1147         elf_numsections instead of bfd_count_sections to initialize
1148         dwp_file->num_sections.
1149
1150 2019-02-25  Tom Tromey  <tromey@adacore.com>
1151
1152         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1153
1154 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1155
1156         * gcore.in: Add '--readnever' option when invoking GDB.
1157
1158 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1159
1160         * MAINTAINERS: Update my email address.
1161
1162 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1163
1164         * build-id.c (build_id_to_debug_bfd_1): New function.
1165         (build_id_to_debug_bfd): Look for separate debug file in
1166         sysroot.
1167
1168 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1169
1170         * gdbarch.sh: Update the copyright year range that is placed into
1171         generated files.
1172
1173 2019-02-22  Keith Seitz  <keiths@redhat.com>
1174
1175         PR symtab/23853
1176         * linespec.c (create_sals_line_offset): Search for the default
1177         symtab's filename instead of its fullname.
1178
1179 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1180
1181         * NEWS: Update style defaults.
1182
1183 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1184
1185         * main.c (captured_main_1): Disable styling in batch mode.
1186
1187 2019-02-20  Tom Tromey  <tom@tromey.com>
1188
1189         * symtab.c (symtab_symbol_info): Fix typos.
1190
1191 2019-02-20  Tom Tromey  <tromey@adacore.com>
1192
1193         * findcmd.c (_initialize_mem_search): Use upper case for
1194         metasyntactic variables.
1195
1196 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1197
1198         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1199         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1200
1201 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1202
1203         * top.h (source_file_name): Change to std::string.
1204         * top.c (source_file_name): Likewise.
1205         (command_line_input): Adjust.
1206         * cli/cli-script.c (script_from_file): Adjust.
1207
1208 2019-02-19  Tom Tromey  <tromey@adacore.com>
1209
1210         * ravenscar-thread.c
1211         (ravenscar_thread_target::update_thread_list): Don't call
1212         ada_build_task_list.
1213         * ada-lang.h (ada_build_task_list): Don't declare.
1214         * ada-tasks.c (struct ada_tasks_inferior_data)
1215         <task_list_valid_p>: Now bool.
1216         (read_known_tasks, ada_task_list_changed)
1217         (ada_tasks_invalidate_inferior_data): Update.
1218         (read_known_tasks_array): Return bool.
1219         (read_known_tasks_list): Likewise.
1220         (read_known_tasks): Return void.
1221         (ada_build_task_list): Now static.
1222
1223 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1224
1225         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1226         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1227
1228 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1229
1230         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1231         variant for ada_tasks_pspace_data_handle and
1232         ada_tasks_inferior_data_handle.
1233         (ada_tasks_pspace_data_cleanup): New function.
1234         (ada_tasks_inferior_data_cleanup): New function.
1235
1236 2019-02-17  Tom Tromey  <tom@tromey.com>
1237
1238         * macrotab.h (macro_source_fullname): Return a std::string.
1239         * macrotab.c (macro_include, check_for_redefinition)
1240         (macro_undef, macro_lookup_definition, foreach_macro)
1241         (foreach_macro_in_scope): Update.
1242         (macro_source_fullname): Return a std::string.
1243         * macrocmd.c (show_pp_source_pos): Update.
1244
1245 2019-02-17  Tom Tromey  <tom@tromey.com>
1246
1247         * macrocmd.c (show_pp_source_pos): Style the file names.
1248
1249 2019-02-17  Tom Tromey  <tom@tromey.com>
1250
1251         PR tui/24197:
1252         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1253
1254 2019-02-17  Tom Tromey  <tom@tromey.com>
1255
1256         * ada-lang.c (user_select_syms): Use filtered printing.
1257         * utils.c (wrap_style): New global.
1258         (desired_style): Remove.
1259         (emit_style_escape): Add stream parameter.
1260         (set_output_style, reset_terminal_style, prompt_for_continue):
1261         Update.
1262         (flush_wrap_buffer): Only flush gdb_stdout.
1263         (wrap_here): Set wrap_style.
1264         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1265         treat escape sequences as a character.  Change when wrap buffer is
1266         flushed.
1267         (fputs_styled): Do not set the output style when the default is
1268         requested.
1269         * ui-style.h (struct ui_file_style) <is_default>: New method.
1270         * source.c (print_source_lines_base): Emit escape sequences in one
1271         piece.
1272
1273 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1274
1275         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1276         integers and enumeration types.
1277
1278 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1279
1280         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1281         instead of lookup_symbol_in_language
1282         (do_exact_match): New function.
1283         (ada_get_symbol_name_matcher): Return do_exact_match when
1284         doing a verbatim match.
1285
1286 2019-02-15  Tom Tromey  <tromey@adacore.com>
1287
1288         * ravenscar-thread.c (ravenscar_thread_target::resume)
1289         (ravenscar_thread_target::wait): Special case wildcard requests.
1290
1291 2019-02-15  Tom Tromey  <tromey@adacore.com>
1292
1293         * ravenscar-thread.c (base_ptid): Remove.
1294         (struct ravenscar_thread_target) <close>: New method.
1295         <m_base_ptid>: New member.
1296         <update_inferior_ptid, active_task, task_is_currently_active,
1297         runtime_initialized>: Declare methods.
1298         <ravenscar_thread_target>: Add constructor.
1299         (ravenscar_thread_target::task_is_currently_active)
1300         (ravenscar_thread_target::update_inferior_ptid)
1301         (ravenscar_runtime_initialized): Rename.  Now methods.
1302         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1303         (ravenscar_thread_target::update_thread_list): Update.
1304         (ravenscar_thread_target::active_task): Now method.
1305         (ravenscar_thread_target::store_registers)
1306         (ravenscar_thread_target::prepare_to_store)
1307         (ravenscar_thread_target::prepare_to_store)
1308         (ravenscar_thread_target::mourn_inferior): Update.
1309         (ravenscar_inferior_created): Use "new" to create target.
1310         (ravenscar_thread_target::get_ada_task_ptid): Update.
1311         (_initialize_ravenscar): Don't initialize base_ptid.
1312         (ravenscar_ops): Remove global.
1313
1314 2019-02-15  Tom Tromey  <tromey@adacore.com>
1315
1316         * target.h (push_target): Declare new overload.
1317         * target.c (push_target): New overload, taking an rvalue reference.
1318         * remote.c (remote_target::open_1): Use push_target overload.
1319         * corelow.c (core_target_open): Use push_target overload.
1320
1321 2019-02-15  Tom Tromey  <tromey@adacore.com>
1322
1323         * ravenscar-thread.c (is_ravenscar_task)
1324         (ravenscar_task_is_currently_active): Return bool.
1325         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1326         (_initialize_ravenscar): Remove "(void)".
1327         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1328         Return bool.
1329
1330 2019-02-15  Tom Tromey  <tromey@adacore.com>
1331
1332         * ravenscar-thread.c (ravenscar_runtime_initializer)
1333         (has_ravenscar_runtime, get_running_thread_id)
1334         (ravenscar_thread_target::resume): Fix indentation.
1335
1336 2019-02-15  Tom Tromey  <tromey@adacore.com>
1337
1338         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1339         from ravenscar_arch_ops.
1340         (sparc_ravenscar_ops::fetch_registers)
1341         (sparc_ravenscar_ops::store_registers): Now methods.
1342         (sparc_ravenscar_prepare_to_store): Remove.
1343         (sparc_ravenscar_ops): Redefine.
1344         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1345         methods and destructor.  Remove members.
1346         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1347         (ravenscar_thread_target::store_registers)
1348         (ravenscar_thread_target::prepare_to_store): Update.
1349         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1350         Remove.
1351         (struct ppc_ravenscar_powerpc_ops): Derive from
1352         ravenscar_arch_ops.
1353         (ppc_ravenscar_powerpc_ops::fetch_registers)
1354         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1355         (ppc_ravenscar_powerpc_ops): Redefine.
1356         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1357         (ppc_ravenscar_e500_ops::fetch_registers)
1358         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1359         (ppc_ravenscar_e500_ops): Redefine.
1360         * aarch64-ravenscar-thread.c
1361         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1362         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1363         (aarch64_ravenscar_fetch_registers)
1364         (aarch64_ravenscar_store_registers): Now methods.
1365         (aarch64_ravenscar_ops): Redefine.
1366
1367 2019-02-15  Tom Tromey  <tromey@adacore.com>
1368
1369         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1370         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1371         (ravenscar_thread_target::stopped_by_watchpoint)
1372         (ravenscar_thread_target::stopped_data_address)
1373         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1374
1375 2019-02-15  Tom Tromey  <tromey@adacore.com>
1376
1377         * ravenscar-thread.c: Fix some typos.
1378
1379 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1380             Tom Tromey  <tromey@adacore.com>
1381
1382         * ada-lang.c (ada_exception_sal): Change addr_string to a
1383         std::string.
1384         (create_ada_exception_catchpoint): Update.
1385
1386 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1387             Tom Tromey  <tromey@adacore.com>
1388
1389         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1390         (bp_location_ops): Remove.
1391         (base_breakpoint_allocate_location): Update.
1392         (free_bp_location): Update.
1393         * ada-lang.c (class ada_catchpoint_location)
1394         <ada_catchpoint_location>: Remove ops parameter.
1395         (ada_catchpoint_location_dtor): Remove.
1396         (ada_catchpoint_location_ops): Remove.
1397         (allocate_location_exception): Update.
1398         * breakpoint.h (struct bp_location_ops): Remove.
1399         (class bp_location) <bp_location>: Remove bp_location_ops
1400         parameter.
1401         <~bp_location>: Add destructor.
1402         <ops>: Remove.
1403
1404 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1405             Pedro Alves  <palves@redhat.com>
1406
1407         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1408         'PATH_MAX'.
1409
1410 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1411             Samuel Thibault  <samuel.thibault@gnu.org>
1412             Thomas Schwinge  <thomas@codesourcery.com>
1413
1414         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1415         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1416
1417 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1418
1419         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1420         (check_empty): Use "const char *".
1421
1422         * gnu-nat.c (gnu_nat_target::detach): Instead of
1423         'detach_inferior (pid)' call
1424         'detach_inferior (find_inferior_pid (pid))'.
1425
1426         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1427         'nat/fork-inferior.o'.
1428         * gnu-nat.c: #include "nat/fork-inferior.h".
1429
1430         * gnu-nat.c (gnu_nat_target::detach): Instead of
1431         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1432         * gnu-nat.h: #include "inf-child.h".
1433         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1434         'i386_gnu_nat_target::fetch_registers'.
1435         (gnu_store_registers): Rename/move to
1436         'i386_gnu_nat_target::store_registers'.
1437
1438         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1439         * gnu-nat.h (mach_thread_info): New function.
1440         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1441
1442         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1443
1444 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1445
1446         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1447
1448 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1449
1450         * windows-nat.c (windows_add_thread): Add new parameter
1451         "main_thread_p" with default value set to false.  Update
1452         function documentation as well as all callers.
1453         (windows_delete_thread): Likewise.
1454         (fake_create_process): Update call to windows_add_thread.
1455         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1456         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1457         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1458         call to windows_delete_thread.
1459
1460 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1461
1462         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1463
1464 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1465
1466         * symfile.c (find_separate_debug_file): Use canonical path of
1467         sysroot with child_path instead of gdb_sysroot if it is valid.
1468
1469 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1470
1471         * symfile.c (find_separate_debug_file): Use child_path to
1472         determine if an object file is under a sysroot.
1473
1474 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1475
1476         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1477         unittests/child-path-selftests.c.
1478         * common/pathstuff.c (child_path): New function.
1479         * common/pathstuff.h (child_path): New prototype.
1480         * unittests/child-path-selftests.c: New file.
1481
1482 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1483
1484         * symfile.c (find_separate_debug_file): Look for separate debug
1485         files in debug directories under the sysroot.
1486
1487 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1488
1489         * symtab.h (struct minimal_symbol data_p): New const method.
1490         (struct minimal_symbol text_p): Likewise.
1491         * symtab.c (output_source_filename): Use file name style
1492         to print file name.
1493         (print_symbol_info): Likewise.
1494         (print_msymbol_info): Use address style to print addresses.
1495         Use function name style to print executable text symbols.
1496         (expand_symtab_containing_pc): Use data_p.
1497         (find_pc_sect_compunit_symtab): Likewise.
1498
1499 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1500
1501         * breakpoint.c (describe_other_breakpoints): Use address style
1502         to print addresses.
1503         (say_where): Likewise.
1504
1505 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1506
1507         * ada-typeprint.c (print_func_type): Print function name
1508         style to print function name.
1509         * c-typeprint.c (c_print_type_1): Likewise.
1510
1511 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1512
1513         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1514         for execve.
1515
1516 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1517
1518         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1519         type_stack.
1520
1521 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1522
1523         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1524         TYPE_CODE_REF types.
1525
1526 2019-02-08  Jim Wilson  <jimw@sifive.com>
1527
1528         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1529         (riscv_linux_fregset): New.
1530         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1531
1532 2019-02-07  Tom Tromey  <tom@tromey.com>
1533
1534         * thread.c (thread_cancel_execution_command): Update.
1535         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1536         methods.
1537         (struct thread_fsm_ops): Remove.
1538         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1539         (thread_fsm_should_stop, thread_fsm_return_value)
1540         (thread_fsm_set_finished, thread_fsm_finished_p)
1541         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1542         Don't declare.
1543         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1544         * infrun.c (clear_proceed_status_thread)
1545         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1546         (print_stop_event): Update.
1547         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1548         Add constructor.
1549         (step_command_fsm_ops): Remove.
1550         (new_step_command_fsm): Remove.
1551         (step_1): Update.
1552         (step_command_fsm::should_stop): Rename from
1553         step_command_fsm_should_stop.
1554         (step_command_fsm::clean_up): Rename from
1555         step_command_fsm_clean_up.
1556         (step_command_fsm::do_async_reply_reason): Rename from
1557         step_command_fsm_async_reply_reason.
1558         (struct until_next_fsm): Inherit from thread_fsm.  Add
1559         constructor.
1560         (until_next_fsm_ops): Remove.
1561         (new_until_next_fsm): Remove.
1562         (until_next_fsm::should_stop): Rename from
1563         until_next_fsm_should_stop.
1564         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1565         (until_next_fsm::do_async_reply_reason): Rename from
1566         until_next_fsm_async_reply_reason.
1567         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1568         constructor.  Change type of breakpoint.
1569         (finish_command_fsm_ops): Remove.
1570         (new_finish_command_fsm): Remove.
1571         (finish_command_fsm::should_stop): Rename from
1572         finish_command_fsm_should_stop.
1573         (finish_command_fsm::clean_up): Rename from
1574         finish_command_fsm_clean_up.
1575         (finish_command_fsm::return_value): Rename from
1576         finish_command_fsm_return_value.
1577         (finish_command_fsm::do_async_reply_reason): Rename from
1578         finish_command_fsm_async_reply_reason.
1579         (finish_command): Update.
1580         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1581         Add constructor.
1582         (call_thread_fsm_ops): Remove.
1583         (call_thread_fsm::call_thread_fsm): Rename from
1584         new_call_thread_fsm.
1585         (call_thread_fsm::should_stop): Rename from
1586         call_thread_fsm_should_stop.
1587         (call_thread_fsm::should_notify_stop): Rename from
1588         call_thread_fsm_should_notify_stop.
1589         (run_inferior_call, call_function_by_hand_dummy): Update.
1590         * cli/cli-interp.c (should_print_stop_to_console): Update.
1591         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1592         Add constructor.  Change type of location_breakpoint,
1593         caller_breakpoint.
1594         (until_break_fsm_ops): Remove.
1595         (new_until_break_fsm): Remove.
1596         (until_break_fsm::should_stop): Rename from
1597         until_break_fsm_should_stop.
1598         (until_break_fsm::clean_up): Rename from
1599         until_break_fsm_clean_up.
1600         (until_break_fsm::do_async_reply_reason): Rename from
1601         until_break_fsm_async_reply_reason.
1602         (until_break_command): Update.
1603         * thread-fsm.c: Remove.
1604         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1605
1606 2019-02-07  Tom Tromey  <tom@tromey.com>
1607
1608         * yy-remap.h: Add include guard.
1609         * xtensa-tdep.h: Add include guard.
1610         * xcoffread.h: Rename include guard.
1611         * varobj-iter.h: Add include guard.
1612         * tui/tui.h: Rename include guard.
1613         * tui/tui-winsource.h: Rename include guard.
1614         * tui/tui-wingeneral.h: Rename include guard.
1615         * tui/tui-windata.h: Rename include guard.
1616         * tui/tui-win.h: Rename include guard.
1617         * tui/tui-stack.h: Rename include guard.
1618         * tui/tui-source.h: Rename include guard.
1619         * tui/tui-regs.h: Rename include guard.
1620         * tui/tui-out.h: Rename include guard.
1621         * tui/tui-layout.h: Rename include guard.
1622         * tui/tui-io.h: Rename include guard.
1623         * tui/tui-hooks.h: Rename include guard.
1624         * tui/tui-file.h: Rename include guard.
1625         * tui/tui-disasm.h: Rename include guard.
1626         * tui/tui-data.h: Rename include guard.
1627         * tui/tui-command.h: Rename include guard.
1628         * tic6x-tdep.h: Add include guard.
1629         * target/waitstatus.h: Rename include guard.
1630         * target/wait.h: Rename include guard.
1631         * target/target.h: Rename include guard.
1632         * target/resume.h: Rename include guard.
1633         * target-float.h: Rename include guard.
1634         * stabsread.h: Add include guard.
1635         * rs6000-tdep.h: Add include guard.
1636         * riscv-fbsd-tdep.h: Add include guard.
1637         * regformats/regdef.h: Rename include guard.
1638         * record.h: Rename include guard.
1639         * python/python.h: Rename include guard.
1640         * python/python-internal.h: Rename include guard.
1641         * python/py-stopevent.h: Rename include guard.
1642         * python/py-ref.h: Rename include guard.
1643         * python/py-record.h: Rename include guard.
1644         * python/py-record-full.h: Rename include guard.
1645         * python/py-record-btrace.h: Rename include guard.
1646         * python/py-instruction.h: Rename include guard.
1647         * python/py-events.h: Rename include guard.
1648         * python/py-event.h: Rename include guard.
1649         * procfs.h: Add include guard.
1650         * proc-utils.h: Add include guard.
1651         * p-lang.h: Add include guard.
1652         * or1k-tdep.h: Rename include guard.
1653         * observable.h: Rename include guard.
1654         * nto-tdep.h: Rename include guard.
1655         * nat/x86-linux.h: Rename include guard.
1656         * nat/x86-linux-dregs.h: Rename include guard.
1657         * nat/x86-gcc-cpuid.h: Add include guard.
1658         * nat/x86-dregs.h: Rename include guard.
1659         * nat/x86-cpuid.h: Rename include guard.
1660         * nat/ppc-linux.h: Rename include guard.
1661         * nat/mips-linux-watch.h: Rename include guard.
1662         * nat/linux-waitpid.h: Rename include guard.
1663         * nat/linux-ptrace.h: Rename include guard.
1664         * nat/linux-procfs.h: Rename include guard.
1665         * nat/linux-osdata.h: Rename include guard.
1666         * nat/linux-nat.h: Rename include guard.
1667         * nat/linux-namespaces.h: Rename include guard.
1668         * nat/linux-btrace.h: Rename include guard.
1669         * nat/glibc_thread_db.h: Rename include guard.
1670         * nat/gdb_thread_db.h: Rename include guard.
1671         * nat/gdb_ptrace.h: Rename include guard.
1672         * nat/fork-inferior.h: Rename include guard.
1673         * nat/amd64-linux-siginfo.h: Rename include guard.
1674         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1675         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1676         * nat/aarch64-linux.h: Rename include guard.
1677         * nat/aarch64-linux-hw-point.h: Rename include guard.
1678         * mn10300-tdep.h: Add include guard.
1679         * mips-linux-tdep.h: Add include guard.
1680         * mi/mi-parse.h: Rename include guard.
1681         * mi/mi-out.h: Rename include guard.
1682         * mi/mi-main.h: Rename include guard.
1683         * mi/mi-interp.h: Rename include guard.
1684         * mi/mi-getopt.h: Rename include guard.
1685         * mi/mi-console.h: Rename include guard.
1686         * mi/mi-common.h: Rename include guard.
1687         * mi/mi-cmds.h: Rename include guard.
1688         * mi/mi-cmd-break.h: Rename include guard.
1689         * m2-lang.h: Add include guard.
1690         * location.h: Rename include guard.
1691         * linux-record.h: Rename include guard.
1692         * linux-nat.h: Add include guard.
1693         * linux-fork.h: Add include guard.
1694         * i386-darwin-tdep.h: Rename include guard.
1695         * hppa-linux-offsets.h: Add include guard.
1696         * guile/guile.h: Rename include guard.
1697         * guile/guile-internal.h: Rename include guard.
1698         * gnu-nat.h: Rename include guard.
1699         * gdb-stabs.h: Rename include guard.
1700         * frv-tdep.h: Add include guard.
1701         * f-lang.h: Add include guard.
1702         * event-loop.h: Add include guard.
1703         * darwin-nat.h: Rename include guard.
1704         * cp-abi.h: Rename include guard.
1705         * config/sparc/nm-sol2.h: Rename include guard.
1706         * config/nm-nto.h: Rename include guard.
1707         * config/nm-linux.h: Add include guard.
1708         * config/i386/nm-i386gnu.h: Rename include guard.
1709         * config/djgpp/nl_types.h: Rename include guard.
1710         * config/djgpp/langinfo.h: Rename include guard.
1711         * compile/gcc-cp-plugin.h: Add include guard.
1712         * compile/gcc-c-plugin.h: Add include guard.
1713         * compile/compile.h: Rename include guard.
1714         * compile/compile-object-run.h: Rename include guard.
1715         * compile/compile-object-load.h: Rename include guard.
1716         * compile/compile-internal.h: Rename include guard.
1717         * compile/compile-cplus.h: Rename include guard.
1718         * compile/compile-c.h: Rename include guard.
1719         * common/xml-utils.h: Rename include guard.
1720         * common/x86-xstate.h: Rename include guard.
1721         * common/version.h: Rename include guard.
1722         * common/vec.h: Rename include guard.
1723         * common/tdesc.h: Rename include guard.
1724         * common/selftest.h: Rename include guard.
1725         * common/scoped_restore.h: Rename include guard.
1726         * common/scoped_mmap.h: Rename include guard.
1727         * common/scoped_fd.h: Rename include guard.
1728         * common/safe-iterator.h: Rename include guard.
1729         * common/run-time-clock.h: Rename include guard.
1730         * common/refcounted-object.h: Rename include guard.
1731         * common/queue.h: Rename include guard.
1732         * common/ptid.h: Rename include guard.
1733         * common/print-utils.h: Rename include guard.
1734         * common/preprocessor.h: Rename include guard.
1735         * common/pathstuff.h: Rename include guard.
1736         * common/observable.h: Rename include guard.
1737         * common/netstuff.h: Rename include guard.
1738         * common/job-control.h: Rename include guard.
1739         * common/host-defs.h: Rename include guard.
1740         * common/gdb_wait.h: Rename include guard.
1741         * common/gdb_vecs.h: Rename include guard.
1742         * common/gdb_unlinker.h: Rename include guard.
1743         * common/gdb_unique_ptr.h: Rename include guard.
1744         * common/gdb_tilde_expand.h: Rename include guard.
1745         * common/gdb_sys_time.h: Rename include guard.
1746         * common/gdb_string_view.h: Rename include guard.
1747         * common/gdb_splay_tree.h: Rename include guard.
1748         * common/gdb_setjmp.h: Rename include guard.
1749         * common/gdb_ref_ptr.h: Rename include guard.
1750         * common/gdb_optional.h: Rename include guard.
1751         * common/gdb_locale.h: Rename include guard.
1752         * common/gdb_assert.h: Rename include guard.
1753         * common/filtered-iterator.h: Rename include guard.
1754         * common/filestuff.h: Rename include guard.
1755         * common/fileio.h: Rename include guard.
1756         * common/environ.h: Rename include guard.
1757         * common/common-utils.h: Rename include guard.
1758         * common/common-types.h: Rename include guard.
1759         * common/common-regcache.h: Rename include guard.
1760         * common/common-inferior.h: Rename include guard.
1761         * common/common-gdbthread.h: Rename include guard.
1762         * common/common-exceptions.h: Rename include guard.
1763         * common/common-defs.h: Rename include guard.
1764         * common/common-debug.h: Rename include guard.
1765         * common/cleanups.h: Rename include guard.
1766         * common/buffer.h: Rename include guard.
1767         * common/btrace-common.h: Rename include guard.
1768         * common/break-common.h: Rename include guard.
1769         * cli/cli-utils.h: Rename include guard.
1770         * cli/cli-style.h: Rename include guard.
1771         * cli/cli-setshow.h: Rename include guard.
1772         * cli/cli-script.h: Rename include guard.
1773         * cli/cli-interp.h: Rename include guard.
1774         * cli/cli-decode.h: Rename include guard.
1775         * cli/cli-cmds.h: Rename include guard.
1776         * charset-list.h: Add include guard.
1777         * buildsym-legacy.h: Rename include guard.
1778         * bfin-tdep.h: Add include guard.
1779         * ax.h: Rename include guard.
1780         * arm-linux-tdep.h: Add include guard.
1781         * arm-fbsd-tdep.h: Add include guard.
1782         * arch/xtensa.h: Rename include guard.
1783         * arch/tic6x.h: Add include guard.
1784         * arch/i386.h: Add include guard.
1785         * arch/arm.h: Rename include guard.
1786         * arch/arm-linux.h: Rename include guard.
1787         * arch/arm-get-next-pcs.h: Rename include guard.
1788         * arch/amd64.h: Add include guard.
1789         * arch/aarch64-insn.h: Rename include guard.
1790         * arch-utils.h: Rename include guard.
1791         * annotate.h: Add include guard.
1792         * amd64-darwin-tdep.h: Rename include guard.
1793         * aarch64-linux-tdep.h: Add include guard.
1794         * aarch64-fbsd-tdep.h: Add include guard.
1795         * aarch32-linux-nat.h: Add include guard.
1796
1797 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1798
1799         * macrotab.c (macro_define_internal): New function that
1800         factorizes macro_define_object_internal and macro_define_function
1801         code.
1802         (macro_define_object_internal): Use macro_define_internal.
1803         (macro_define_function): Likewise.
1804
1805 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1806
1807         * macrocmd.c (extract_identifier): Return
1808         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1809         callers.
1810
1811 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1812
1813         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1814
1815 2019-02-05  Tom Tromey  <tom@tromey.com>
1816
1817         * target.c (target_stack::unpush): Move assertion earlier.
1818
1819 2019-01-30  Tom Tromey  <tom@tromey.com>
1820
1821         PR python/23615:
1822         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1823         (gdbpy_parse_and_eval): Likewise.
1824         * python/python-internal.h (gdbpy_allow_threads): New class.
1825
1826 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1827
1828         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1829         (aarch64_fbsd_fpregmap): Move earlier.
1830         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1831         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1832         instead of individual calls to trad_frame_set_reg_addr.
1833         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1834         earlier.
1835         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1836         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1837         instead of individual calls to trad_frame_set_reg_addr.
1838
1839 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1840
1841         * CONTRIBUTE: Replace contribution list with wiki link.
1842
1843 2019-01-25  Tom Tromey  <tom@tromey.com>
1844
1845         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1846
1847 2019-01-25  Tom Tromey  <tom@tromey.com>
1848
1849         * xtensa-linux-nat.c: Fix common/ includes.
1850         * xml-support.h: Fix common/ includes.
1851         * xml-support.c: Fix common/ includes.
1852         * x86-linux-nat.c: Fix common/ includes.
1853         * windows-nat.c: Fix common/ includes.
1854         * varobj.h: Fix common/ includes.
1855         * varobj.c: Fix common/ includes.
1856         * value.c: Fix common/ includes.
1857         * valops.c: Fix common/ includes.
1858         * utils.c: Fix common/ includes.
1859         * unittests/xml-utils-selftests.c: Fix common/ includes.
1860         * unittests/utils-selftests.c: Fix common/ includes.
1861         * unittests/unpack-selftests.c: Fix common/ includes.
1862         * unittests/tracepoint-selftests.c: Fix common/ includes.
1863         * unittests/style-selftests.c: Fix common/ includes.
1864         * unittests/string_view-selftests.c: Fix common/ includes.
1865         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1866         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1867         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1868         * unittests/rsp-low-selftests.c: Fix common/ includes.
1869         * unittests/parse-connection-spec-selftests.c: Fix common/
1870         includes.
1871         * unittests/optional-selftests.c: Fix common/ includes.
1872         * unittests/offset-type-selftests.c: Fix common/ includes.
1873         * unittests/observable-selftests.c: Fix common/ includes.
1874         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1875         * unittests/memrange-selftests.c: Fix common/ includes.
1876         * unittests/memory-map-selftests.c: Fix common/ includes.
1877         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1878         * unittests/function-view-selftests.c: Fix common/ includes.
1879         * unittests/environ-selftests.c: Fix common/ includes.
1880         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1881         * unittests/common-utils-selftests.c: Fix common/ includes.
1882         * unittests/cli-utils-selftests.c: Fix common/ includes.
1883         * unittests/array-view-selftests.c: Fix common/ includes.
1884         * ui-file.c: Fix common/ includes.
1885         * tui/tui-io.c: Fix common/ includes.
1886         * tracepoint.h: Fix common/ includes.
1887         * tracepoint.c: Fix common/ includes.
1888         * tracefile-tfile.c: Fix common/ includes.
1889         * top.h: Fix common/ includes.
1890         * top.c: Fix common/ includes.
1891         * thread.c: Fix common/ includes.
1892         * target/waitstatus.h: Fix common/ includes.
1893         * target/waitstatus.c: Fix common/ includes.
1894         * target.h: Fix common/ includes.
1895         * target.c: Fix common/ includes.
1896         * target-memory.c: Fix common/ includes.
1897         * target-descriptions.c: Fix common/ includes.
1898         * symtab.h: Fix common/ includes.
1899         * symfile.c: Fix common/ includes.
1900         * stap-probe.c: Fix common/ includes.
1901         * spu-linux-nat.c: Fix common/ includes.
1902         * sparc-nat.c: Fix common/ includes.
1903         * source.c: Fix common/ includes.
1904         * solib.c: Fix common/ includes.
1905         * solib-target.c: Fix common/ includes.
1906         * ser-unix.c: Fix common/ includes.
1907         * ser-tcp.c: Fix common/ includes.
1908         * ser-pipe.c: Fix common/ includes.
1909         * ser-base.c: Fix common/ includes.
1910         * selftest-arch.c: Fix common/ includes.
1911         * s12z-tdep.c: Fix common/ includes.
1912         * rust-exp.y: Fix common/ includes.
1913         * rs6000-aix-tdep.c: Fix common/ includes.
1914         * riscv-tdep.c: Fix common/ includes.
1915         * remote.c: Fix common/ includes.
1916         * remote-notif.h: Fix common/ includes.
1917         * remote-fileio.h: Fix common/ includes.
1918         * remote-fileio.c: Fix common/ includes.
1919         * regcache.h: Fix common/ includes.
1920         * regcache.c: Fix common/ includes.
1921         * record-btrace.c: Fix common/ includes.
1922         * python/python.c: Fix common/ includes.
1923         * python/py-type.c: Fix common/ includes.
1924         * python/py-inferior.c: Fix common/ includes.
1925         * progspace.h: Fix common/ includes.
1926         * producer.c: Fix common/ includes.
1927         * procfs.c: Fix common/ includes.
1928         * proc-api.c: Fix common/ includes.
1929         * printcmd.c: Fix common/ includes.
1930         * ppc-linux-nat.c: Fix common/ includes.
1931         * parser-defs.h: Fix common/ includes.
1932         * osdata.c: Fix common/ includes.
1933         * obsd-nat.c: Fix common/ includes.
1934         * nat/x86-linux.c: Fix common/ includes.
1935         * nat/x86-linux-dregs.c: Fix common/ includes.
1936         * nat/x86-dregs.h: Fix common/ includes.
1937         * nat/x86-dregs.c: Fix common/ includes.
1938         * nat/ppc-linux.c: Fix common/ includes.
1939         * nat/mips-linux-watch.h: Fix common/ includes.
1940         * nat/mips-linux-watch.c: Fix common/ includes.
1941         * nat/linux-waitpid.c: Fix common/ includes.
1942         * nat/linux-ptrace.h: Fix common/ includes.
1943         * nat/linux-ptrace.c: Fix common/ includes.
1944         * nat/linux-procfs.c: Fix common/ includes.
1945         * nat/linux-personality.c: Fix common/ includes.
1946         * nat/linux-osdata.c: Fix common/ includes.
1947         * nat/linux-namespaces.c: Fix common/ includes.
1948         * nat/linux-btrace.h: Fix common/ includes.
1949         * nat/linux-btrace.c: Fix common/ includes.
1950         * nat/fork-inferior.c: Fix common/ includes.
1951         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1952         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1953         * nat/aarch64-linux.c: Fix common/ includes.
1954         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1955         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1956         * namespace.h: Fix common/ includes.
1957         * mips-linux-tdep.c: Fix common/ includes.
1958         * minsyms.c: Fix common/ includes.
1959         * mi/mi-parse.h: Fix common/ includes.
1960         * mi/mi-main.c: Fix common/ includes.
1961         * mi/mi-cmd-env.c: Fix common/ includes.
1962         * memrange.h: Fix common/ includes.
1963         * memattr.c: Fix common/ includes.
1964         * maint.h: Fix common/ includes.
1965         * maint.c: Fix common/ includes.
1966         * main.c: Fix common/ includes.
1967         * machoread.c: Fix common/ includes.
1968         * location.c: Fix common/ includes.
1969         * linux-thread-db.c: Fix common/ includes.
1970         * linux-nat.c: Fix common/ includes.
1971         * linux-fork.c: Fix common/ includes.
1972         * inline-frame.c: Fix common/ includes.
1973         * infrun.c: Fix common/ includes.
1974         * inflow.c: Fix common/ includes.
1975         * inferior.h: Fix common/ includes.
1976         * inferior.c: Fix common/ includes.
1977         * infcmd.c: Fix common/ includes.
1978         * inf-ptrace.c: Fix common/ includes.
1979         * inf-child.c: Fix common/ includes.
1980         * ia64-linux-nat.c: Fix common/ includes.
1981         * i387-tdep.c: Fix common/ includes.
1982         * i386-tdep.c: Fix common/ includes.
1983         * i386-linux-tdep.c: Fix common/ includes.
1984         * i386-linux-nat.c: Fix common/ includes.
1985         * i386-go32-tdep.c: Fix common/ includes.
1986         * i386-fbsd-tdep.c: Fix common/ includes.
1987         * i386-fbsd-nat.c: Fix common/ includes.
1988         * guile/scm-type.c: Fix common/ includes.
1989         * guile/guile.c: Fix common/ includes.
1990         * go32-nat.c: Fix common/ includes.
1991         * gnu-nat.c: Fix common/ includes.
1992         * gdbthread.h: Fix common/ includes.
1993         * gdbarch-selftests.c: Fix common/ includes.
1994         * gdb_usleep.c: Fix common/ includes.
1995         * gdb_select.h: Fix common/ includes.
1996         * gdb_bfd.c: Fix common/ includes.
1997         * gcore.c: Fix common/ includes.
1998         * fork-child.c: Fix common/ includes.
1999         * findvar.c: Fix common/ includes.
2000         * fbsd-nat.c: Fix common/ includes.
2001         * event-top.c: Fix common/ includes.
2002         * event-loop.c: Fix common/ includes.
2003         * dwarf2read.c: Fix common/ includes.
2004         * dwarf2loc.c: Fix common/ includes.
2005         * dwarf2-frame.c: Fix common/ includes.
2006         * dwarf-index-cache.c: Fix common/ includes.
2007         * dtrace-probe.c: Fix common/ includes.
2008         * disasm-selftests.c: Fix common/ includes.
2009         * defs.h: Fix common/ includes.
2010         * csky-tdep.c: Fix common/ includes.
2011         * cp-valprint.c: Fix common/ includes.
2012         * cp-support.h: Fix common/ includes.
2013         * cp-support.c: Fix common/ includes.
2014         * corelow.c: Fix common/ includes.
2015         * completer.h: Fix common/ includes.
2016         * completer.c: Fix common/ includes.
2017         * compile/compile.c: Fix common/ includes.
2018         * compile/compile-loc2c.c: Fix common/ includes.
2019         * compile/compile-cplus-types.c: Fix common/ includes.
2020         * compile/compile-cplus-symbols.c: Fix common/ includes.
2021         * command.h: Fix common/ includes.
2022         * cli/cli-dump.c: Fix common/ includes.
2023         * cli/cli-cmds.c: Fix common/ includes.
2024         * charset.c: Fix common/ includes.
2025         * build-id.c: Fix common/ includes.
2026         * btrace.h: Fix common/ includes.
2027         * btrace.c: Fix common/ includes.
2028         * breakpoint.h: Fix common/ includes.
2029         * breakpoint.c: Fix common/ includes.
2030         * ax.h:
2031         (enum agent_op): Fix common/ includes.
2032         * ax-general.c (struct aop_map): Fix common/ includes.
2033         * ax-gdb.c: Fix common/ includes.
2034         * auxv.c: Fix common/ includes.
2035         * auto-load.c: Fix common/ includes.
2036         * arm-tdep.c: Fix common/ includes.
2037         * arch/riscv.c: Fix common/ includes.
2038         * arch/ppc-linux-common.c: Fix common/ includes.
2039         * arch/i386.c: Fix common/ includes.
2040         * arch/arm.c: Fix common/ includes.
2041         * arch/arm-linux.c: Fix common/ includes.
2042         * arch/arm-get-next-pcs.c: Fix common/ includes.
2043         * arch/amd64.c: Fix common/ includes.
2044         * arch/aarch64.c: Fix common/ includes.
2045         * arch/aarch64-insn.c: Fix common/ includes.
2046         * arch-utils.c: Fix common/ includes.
2047         * amd64-windows-tdep.c: Fix common/ includes.
2048         * amd64-tdep.c: Fix common/ includes.
2049         * amd64-sol2-tdep.c: Fix common/ includes.
2050         * amd64-obsd-tdep.c: Fix common/ includes.
2051         * amd64-nbsd-tdep.c: Fix common/ includes.
2052         * amd64-linux-tdep.c: Fix common/ includes.
2053         * amd64-linux-nat.c: Fix common/ includes.
2054         * amd64-fbsd-tdep.c: Fix common/ includes.
2055         * amd64-fbsd-nat.c: Fix common/ includes.
2056         * amd64-dicos-tdep.c: Fix common/ includes.
2057         * amd64-darwin-tdep.c: Fix common/ includes.
2058         * agent.c: Fix common/ includes.
2059         * ada-lang.h: Fix common/ includes.
2060         * ada-lang.c: Fix common/ includes.
2061         * aarch64-tdep.c: Fix common/ includes.
2062
2063 2019-01-25  Tom Tromey  <tom@tromey.com>
2064
2065         * common/create-version.sh: Use common/version.h.
2066
2067 2019-01-24  Pedro Alves  <palves@redhat.com>
2068
2069         * infrun.c (signal_stop, signal_print, signal_program)
2070         (signal_catch, signal_pass): Now arrays instead of pointers.
2071         (update_signals_program_target, do_target_resume)
2072         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2073         * linux-nat.c (linux_nat_target::pass_signals)
2074         (linux_nat_target::create_inferior, linux_nat_target::attach):
2075         Adjust.
2076         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2077         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2078         * procfs.c (procfs_target::pass_signals): Adjust.
2079         * record-full.c (record_full_target::resume): Adjust.
2080         * remote.c (remote_target::pass_signals)
2081         (remote_target::program_signals): Adjust.
2082         * target-debug.h (target_debug_print_signals): Now takes a
2083         gdb::array_view as parameter.  Adjust.
2084         * target.h (target_ops) <pass_signals, program_signals>: Replace
2085         pointer and length parameters with gdb::array_view.
2086         (target_pass_signals, target_program_signals): Likewise.
2087         * target-delegates.c: Regenerate.
2088
2089 2019-01-24  Pedro Alves  <palves@redhat.com>
2090
2091         * common/forward-scope-exit.h
2092         (forward_scope_exit::forward_scope_exit): Pass arguments to
2093         m_bind_function directly, instead of creating a std::bind and
2094         copying that.
2095
2096 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2097
2098         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2099         for static members.
2100         (pass_in_v_vfp_candidate): Likewise.
2101
2102 2019-01-23  Tom Tromey  <tom@tromey.com>
2103             Pedro Alves  <palves@redhat.com>
2104
2105         * regcache.c (class regcache_invalidator): Remove.
2106         (regcache::raw_write): Use make_scope_exit.
2107
2108 2019-01-23  Tom Tromey  <tom@tromey.com>
2109
2110         * ui-out.h (class ui_out_emit_type): Update comment.
2111
2112 2019-01-23  Tom Tromey  <tom@tromey.com>
2113
2114         * infrun.c (fetch_inferior_event): Update comment.
2115
2116 2019-01-23  Tom Tromey  <tom@tromey.com>
2117             Pedro Alves  <palves@redhat.com>
2118
2119         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2120         parameter.
2121         (fetch_inferior_event): Use SCOPE_EXIT.
2122
2123
2124 2019-01-23  Tom Tromey  <tom@tromey.com>
2125             Pedro Alves  <palves@redhat.com>
2126
2127         * infrun.c (disable_thread_events): Delete.
2128         (stop_all_threads): Use SCOPE_EXIT.
2129
2130 2019-01-23  Tom Tromey  <tom@tromey.com>
2131             Pedro Alves  <palves@redhat.com>
2132
2133         * symfile.c: Include forward-scope-exit.h.
2134         (clear_symtab_users_cleanup): Replace forward declaration with
2135         a FORWARD_SCOPE_EXIT.
2136         (syms_from_objfile_1): Use the forward_scope_exit and
2137         gdb::optional instead of cleanup_function.
2138         (reread_symbols): Use the forward_scope_exit instead of
2139         cleanup_function.
2140         (clear_symtab_users_cleanup): Remove function.
2141
2142 2019-01-23  Tom Tromey  <tom@tromey.com>
2143             Pedro Alves  <palves@redhat.com>
2144
2145         * linux-nat.c: Include scope-exit.h.
2146         (cleanup_target_stop): Remove.
2147         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2148         SCOPE_EXIT.
2149
2150 2019-01-23  Tom Tromey  <tom@tromey.com>
2151             Pedro Alves  <palves@redhat.com>
2152
2153         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2154         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2155
2156 2019-01-23  Tom Tromey  <tom@tromey.com>
2157             Andrew Burgess  <andrew.burgess@embecosm.com>
2158             Pedro Alves  <palves@redhat.com>
2159
2160         * infrun.c (fetch_inferior_event): Use scope_exit.
2161         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2162         * top.c (execute_command): Use scope_exit.
2163         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2164         * utils.c (do_bpstat_clear_actions_cleanup)
2165         (make_bpstat_clear_actions_cleanup): Remove.
2166
2167 2019-01-23  Tom Tromey  <tom@tromey.com>
2168             Pedro Alves  <palves@redhat.com>
2169
2170         * infrun.c: Include "common/scope-exit.h"
2171         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2172         (wait_for_inferior): Use SCOPE_EXIT.
2173         (fetch_inferior_event): Use scope_exit.
2174
2175 2019-01-23  Tom Tromey  <tom@tromey.com>
2176             Pedro Alves  <palves@redhat.com>
2177
2178         * breakpoint.c (create_breakpoint): Remove cleanup.
2179
2180 2019-01-23  Tom Tromey  <tom@tromey.com>
2181             Andrew Burgess  <andrew.burgess@embecosm.com>
2182             Pedro Alves  <palves@redhat.com>
2183
2184 2019-01-23  Pedro Alves  <palves@redhat.com>
2185
2186         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2187
2188 2019-01-23  Pedro Alves  <palves@redhat.com>
2189             Andrew Burgess  <andrew.burgess@embecosm.com>
2190
2191         * gdbthread.h: Include "common/forward-scope-exit.h".
2192         (scoped_finish_thread_state): Redefine custom class in terms of
2193         forward_scope_exit.
2194
2195 2019-01-23  Pedro Alves  <palves@redhat.com>
2196             Andrew Burgess  <andrew.burgess@embecosm.com>
2197
2198         * common/forward-scope-exit.h: New file.
2199
2200 2019-01-23  Pedro Alves  <palves@redhat.com>
2201             Andrew Burgess  <andrew.burgess@embecosm.com>
2202             Tom Tromey  <tom@tromey.com>
2203
2204         * common/scope-exit.h: New file.
2205
2206 2019-01-23  Pedro Alves  <palves@redhat.com>
2207
2208         * common/preprocessor.h (ESC): Rename to ...
2209         (ESC_PARENS): ... this.
2210         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2211         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2212
2213 2019-01-23  Tom Tromey  <tom@tromey.com>
2214
2215         * language.h (class scoped_switch_to_sym_language_if_auto):
2216         Initialize m_lang in both cases.
2217
2218 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2219
2220         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2221         with XCNEW.
2222
2223 2019-01-22  Tom Tromey  <tom@tromey.com>
2224
2225         * corelow.c: Do not include sys/file.h.
2226
2227 2019-01-22  Tom Tromey  <tom@tromey.com>
2228
2229         * tui/tui-wingeneral.h: Include gdb_curses.h.
2230
2231 2019-01-22  Tom Tromey  <tom@tromey.com>
2232
2233         * source-cache.h (class source_cache) <get_source_lines,
2234         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2235
2236 2019-01-22  Tom Tromey  <tom@tromey.com>
2237
2238         * remote-fileio.h (struct remote_target): Declare.
2239
2240 2019-01-22  Tom Tromey  <tom@tromey.com>
2241
2242         * python/py-arch.c: Do not include py-ref.h.
2243         * python/py-bpevent.c: Do not include py-ref.h.
2244         * python/py-cmd.c: Do not include py-ref.h.
2245         * python/py-continueevent.c: Do not include py-ref.h.
2246         * python/py-event.h: Do not include py-ref.h.
2247         * python/py-evtregistry.c: Do not include py-ref.h.
2248         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2249         * python/py-frame.c: Do not include py-ref.h.
2250         * python/py-framefilter.c: Do not include py-ref.h.
2251         * python/py-function.c: Do not include py-ref.h.
2252         * python/py-infevents.c: Do not include py-ref.h.
2253         * python/py-linetable.c: Do not include py-ref.h.
2254         * python/py-objfile.c: Do not include py-ref.h.
2255         * python/py-param.c: Do not include py-ref.h.
2256         * python/py-prettyprint.c: Do not include py-ref.h.
2257         * python/py-progspace.c: Do not include py-ref.h.
2258         * python/py-symbol.c: Do not include py-ref.h.
2259         * python/py-symtab.c: Do not include py-ref.h.
2260         * python/py-type.c: Do not include py-ref.h.
2261         * python/py-unwind.c: Do not include py-ref.h.
2262         * python/py-utils.c: Do not include py-ref.h.
2263         * python/py-value.c: Do not include py-ref.h.
2264         * python/py-varobj.c: Do not include py-ref.h.
2265         * python/py-xmethods.c: Do not include py-ref.h.
2266         * python/python.c: Do not include py-ref.h.
2267         * varobj.c: Do not include py-ref.h.
2268
2269 2019-01-22  Tom Tromey  <tom@tromey.com>
2270
2271         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2272         keyword for bcache.
2273
2274 2019-01-22  Tom Tromey  <tom@tromey.com>
2275
2276         * compile/compile-cplus-types.c: Remove a comment by #include.
2277
2278 2019-01-22  Tom Tromey  <tom@tromey.com>
2279
2280         * compile/gcc-c-plugin.h: Include compile-internal.h.
2281
2282 2019-01-22  Tom Tromey  <tom@tromey.com>
2283
2284         * stabsread.c (EXTERN): Do not define.
2285         (symnum, next_symbol_text_func, processing_gcc_compilation)
2286         (within_function, global_sym_chain, global_stabs)
2287         (previous_stab_code, this_object_header_files)
2288         (n_this_object_header_files)
2289         (n_allocated_this_object_header_files): Define.
2290         * stabsread.h (EXTERN): Never define.  Use "extern".
2291
2292 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2293
2294         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2295         history_value.
2296
2297 2019-01-21  Tom Tromey  <tom@tromey.com>
2298
2299         * ui-out.c: Fix includes.
2300         * tui/tui-source.c: Fix includes.
2301         * target.c: Fix includes.
2302         * remote.c: Fix includes.
2303         * regcache.c: Fix includes.
2304         * python/py-block.c: Fix includes.
2305         * printcmd.c: Fix includes.
2306         * or1k-tdep.c: Fix includes.
2307         * mi/mi-main.c: Fix includes.
2308         * m32r-tdep.c: Fix includes.
2309         * csky-tdep.c: Fix includes.
2310         * compile/compile-cplus-types.c: Fix includes.
2311         * cli/cli-interp.c: Fix includes.
2312
2313 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2314
2315         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2316         for padding.
2317
2318 2019-01-16  Tom Tromey  <tom@tromey.com>
2319
2320         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2321         earlier.
2322         (struct objfile) <msymbols_range>: Move from top level.
2323         <msymbols>: New method.
2324         (class objfile_msymbols): Remove.
2325         * symtab.c (default_collect_symbol_completion_matches_break_on):
2326         Update.
2327         * symmisc.c (dump_msymbols): Update.
2328         * stabsread.c (scan_file_globals): Update.
2329         * objc-lang.c (info_selectors_command, info_classes_command)
2330         (find_methods): Update.
2331         * minsyms.c (find_solib_trampoline_target): Update.
2332         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2333         * coffread.c (coff_symfile_read): Update.
2334         * ada-lang.c (ada_lookup_simple_minsym)
2335         (ada_collect_symbol_completion_matches): Update.
2336
2337 2019-01-16  Tom Tromey  <tom@tromey.com>
2338
2339         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2340         type.  Remove no-argument constructor.
2341         <iterator::operator++>: Simplify.
2342         <begin>: Update.
2343         <end>: Use minimal_symbol_count.
2344
2345 2019-01-16  Tom Tromey  <tom@tromey.com>
2346
2347         * objfiles.h (struct objfile) <psymtabs>: New method.
2348         (class objfile_psymtabs): Remove.
2349         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2350         typedef.
2351         <range>: New method.
2352         (require_partial_symbols): Change return type.
2353         * psymtab.c (require_partial_symbols)
2354         (psym_expand_symtabs_matching): Update.
2355         * mdebugread.c (parse_partial_symbols): Update.
2356         * dbxread.c (dbx_end_psymtab): Update.
2357
2358 2019-01-15  Tom Tromey  <tom@tromey.com>
2359
2360         * symtab.c (lookup_objfile_from_block)
2361         (lookup_symbol_in_objfile_symtabs)
2362         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2363         (find_line_symtab, info_sources_command)
2364         (default_collect_symbol_completion_matches_break_on)
2365         (make_source_files_completion_list): Update.
2366         * symmisc.c (print_objfile_statistics, dump_objfile)
2367         (maintenance_print_symbols, maintenance_info_symtabs)
2368         (maintenance_check_symtabs, maintenance_info_line_tables):
2369         Update.
2370         * source.c (select_source_symtab)
2371         (forget_cached_source_info_for_objfile): Update.
2372         * objfiles.h (class objfile_compunits): Remove.
2373         (struct objfile) <compunits_range>: New typedef.
2374         (compunits): New method.
2375         * objfiles.c (objfile_relocate1): Update.
2376         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2377         * maint.c (count_symtabs_and_blocks): Update.
2378         * linespec.c (iterate_over_all_matching_symtabs): Update.
2379         * cp-support.c (add_symbol_overload_list_qualified): Update.
2380         * coffread.c (coff_symtab_read): Update.
2381         * ada-lang.c (add_nonlocal_symbols)
2382         (ada_collect_symbol_completion_matches)
2383         (ada_add_global_exceptions): Update.
2384
2385 2019-01-15  Tom Tromey  <tom@tromey.com>
2386
2387         * progspace.h (program_space) <objfiles_safe_range>: New
2388         typedef.
2389         <objfiles_safe>: New method.
2390         * objfiles.h (class all_objfiles_safe): Remove.
2391         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2392         * jit.c (jit_inferior_exit_hook): Update.
2393
2394 2019-01-17  Tom Tromey  <tom@tromey.com>
2395
2396         * progspace.h (program_space) <objfiles_range>: New typedef.
2397         <objfiles>: New method.
2398         <objfiles_head>: Rename from objfiles.
2399         (object_files): Update.
2400         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2401         * guile/scm-pretty-print.c
2402         (ppscm_find_pretty_printer_from_objfiles): Update.
2403         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2404         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2405         Update.
2406         * python/py-progspace.c (pspy_get_objfiles): Update.
2407         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2408         Update.
2409         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2410         (objfpy_lookup_objfile_by_build_id): Update.
2411         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2412         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2413         Update.
2414         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2415         (expand_symtab_containing_pc, lookup_objfile_from_block)
2416         (lookup_static_symbol, basic_lookup_transparent_type)
2417         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2418         (find_line_symtab, info_sources_command)
2419         (default_collect_symbol_completion_matches_break_on)
2420         (make_source_files_completion_list, find_main_name): Update.
2421         * symmisc.c (print_symbol_bcache_statistics)
2422         (print_objfile_statistics, maintenance_print_symbols)
2423         (maintenance_print_msymbols, maintenance_print_objfiles)
2424         (maintenance_info_symtabs, maintenance_check_symtabs)
2425         (maintenance_expand_symtabs, maintenance_info_line_tables):
2426         Update.
2427         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2428         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2429         (map_overlay_command, unmap_overlay_command)
2430         (simple_overlay_update, expand_symtabs_matching)
2431         (map_symbol_filenames): Update.
2432         * symfile-debug.c (set_debug_symfile): Update.
2433         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2434         Update.
2435         * source.c (select_source_symtab, forget_cached_source_info):
2436         Update.
2437         * solib.c (solib_read_symbols): Update.
2438         * solib-spu.c (append_ocl_sos): Update.
2439         * psymtab.c (maintenance_print_psymbols)
2440         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2441         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2442         * printcmd.c (info_symbol_command): Update.
2443         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2444         Update.
2445         * objfiles.h (class all_objfiles): Remove.
2446         * objfiles.c (have_partial_symbols, have_full_symbols)
2447         (have_minimal_symbols, qsort_cmp, update_section_map)
2448         (shared_objfile_contains_address_p)
2449         (default_iterate_over_objfiles_in_search_order): Update.
2450         * objc-lang.c (info_selectors_command, info_classes_command)
2451         (find_methods): Update.
2452         * minsyms.c (find_solib_trampoline_target): Update.
2453         * maint.c (maintenance_info_sections)
2454         (maintenance_translate_address, count_symtabs_and_blocks):
2455         Update.
2456         * main.c (captured_main_1): Update.
2457         * linux-thread-db.c (try_thread_db_load_from_pdir)
2458         (has_libpthread): Update.
2459         * linespec.c (iterate_over_all_matching_symtabs)
2460         (search_minsyms_for_name): Update.
2461         * jit.c (jit_find_objf_with_entry_addr): Update.
2462         * hppa-tdep.c (find_unwind_entry)
2463         (hppa_lookup_stub_minimal_symbol): Update.
2464         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2465         Update.
2466         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2467         (elf_gnu_ifunc_resolve_by_got): Update.
2468         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2469         * dwarf-index-write.c (save_gdb_index_command): Update.
2470         * cp-support.c (add_symbol_overload_list_qualified): Update.
2471         * breakpoint.c (create_overlay_event_breakpoint)
2472         (create_longjmp_master_breakpoint)
2473         (create_std_terminate_master_breakpoint)
2474         (create_exception_master_breakpoint): Update.
2475         * blockframe.c (find_pc_partial_function): Update.
2476         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2477         (ada_collect_symbol_completion_matches)
2478         (ada_add_global_exceptions): Update.
2479
2480 2019-01-17  Tom Tromey  <tom@tromey.com>
2481
2482         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2483         declare VEC.
2484         (solib_target_parse_libraries): Change return type.
2485         (library_list_start_segment, library_list_start_section)
2486         (library_list_end_library, library_list_start_library); Update.
2487         (solib_target_free_library_list): Remove.
2488         (solib_target_parse_libraries): Remove cleanup.  Change return
2489         type.
2490         (solib_target_current_sos): Update.
2491
2492 2019-01-17  Tom Tromey  <tromey@bapiya>
2493
2494         * valprint.c: Replace "the the" with "the".
2495         * symtab.c: Replace "the the" with "the".
2496         * solib.c: Replace "the the" with "the".
2497         * solib-dsbt.c: Replace "the the" with "the".
2498         * linespec.c: Replace "the the" with "the".
2499         * dwarf2loc.h: Replace "the the" with "the".
2500         * amd64-windows-tdep.c: Replace "the the" with "the".
2501         * aarch64-tdep.c: Replace "the the" with "the".
2502
2503 2019-01-16  Keith Seitz  <keiths@redhat.com>
2504
2505         PR gdb/23773
2506         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2507         <builder>: Rename to ..
2508         <m_builder>: ... this and make private.
2509         (dwarf2_cu::get_builder): New method.  Change all users of
2510         `builder' to use this method.
2511         (dwarf2_start_symtab): Move to ...
2512         (dwarf2_cu::start_symtab): ... here.  Update all callers
2513         (setup_type_unit_groups): Move to ...
2514         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2515         callers.
2516         (dwarf2_cu::reset_builder): New method.
2517         (process_full_compunit, process_full_type_unit): Use
2518         dwarf2_cu::reset_builder.
2519         (follow_die_offset): Record the ancestor CU if it is different
2520         from the followed DIE's CU.
2521         (follow_die_sig_1): Likewise.
2522
2523 2019-01-15  Tom Tromey  <tom@tromey.com>
2524
2525         * remote.c (class remote_state) <buf>: Now a char_vector.
2526         <buf_size>: Remove.
2527         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2528         parameter.
2529         (remote_target::getpkt_or_notif_sane_1)
2530         (remote_target::getpkt_sane)
2531         (remote_target::getpkt_or_notif_sane): Likewise.
2532         (class remote_target) <putpkt>: New overload.
2533         (remote_target::read_frame): Change type of "buf_p".  Remove
2534         sizeof_p parameter.
2535         (packet_ok): New overload.
2536         (packet_check_result): New overload.
2537         Update all uses.
2538
2539 2019-01-14  Tom Tromey  <tom@tromey.com>
2540
2541         * remote-notif.c (handle_notification, remote_notif_ack)
2542         (remote_notif_parse): Make "buf" const.
2543         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2544         const.
2545         (remote_notif_parse, remote_notif_ack, handle_notification):
2546         Likewise.
2547         * remote.c (remote_notif_stop_parse): Make "buf" const.
2548         (remote_target::remote_parse_stop_reply): Make "buf" const.
2549         (remote_notif_stop_ack): Make "buf" const.
2550
2551 2019-01-14  Tom Tromey  <tom@tromey.com>
2552
2553         * remote.c (remote_console_output): Make parameter const.
2554
2555 2019-01-14  Tom Tromey  <tom@tromey.com>
2556
2557         * target-debug.h (target_debug_print_signals): Constify.
2558         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2559         * procfs.c (procfs_target::pass_signals): Update.
2560         * linux-nat.c (linux_nat_target::pass_signals): Update.
2561         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2562         * target-delegates.c: Rebuild.
2563         * remote.c (remote_target::program_signals): Update.
2564         (remote_target::pass_signals): Update.
2565         * target.c (target_pass_signals): Constify argument.
2566         (target_program_signals): Likewise.
2567         * target.h (struct target_ops) <pass_signals, program_signals>:
2568         Constify argument.
2569         (target_pass_signals, target_program_signals): Constify argument.
2570
2571 2019-01-14  Tom Tromey  <tom@tromey.com>
2572
2573         PR tui/28819:
2574         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2575
2576 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2577
2578         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2579         field.
2580         * rs6000-tdep.c: Include reggroups.h.
2581         (IS_V_ALIAS_PSEUDOREG): Define.
2582         (rs6000_register_name): Return names for the "vX" aliases.
2583         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2584         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2585         aliases.  Call default_register_reggroup_p for all other
2586         pseudo-registers.
2587         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2588         New functions.
2589         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2590         Handle "vX" aliases.
2591         (v_alias_pseudo_register_collect): New function.
2592         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2593         (rs6000_gdbarch_init): Initialize "vX" aliases as
2594         pseudo-registers.  Restore registration of
2595         rs6000_pseudo_register_reggroup_p with
2596         set_tdesc_pseudo_register_reggroup_p.
2597
2598 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2599
2600         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2601         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2602         set_gdbarch_num_pseudo_regs.
2603
2604 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2605
2606         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2607         Remove arg prefixname, add do_set and do_show.
2608         Add member functions set_list and show_list.
2609         * cli/cli-style.c (class cli_style_option): Update accordingly.
2610         (style_set_list): Move to file scope.
2611         (style_show_list): Likewise.
2612         (set_style): Call help_list.
2613         (show_style): Call cmd_show_list.
2614         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2615         Update to use the new macro.
2616
2617 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2618
2619         * ada-lang.c (_initialize_ada_language): Expand the help text
2620         for the "catch exception" command.
2621
2622 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2623
2624         * symtab.c (matching_obj_sections): Initialize obj,
2625         declare it closer to its usage.
2626
2627 2019-01-10  Tom Tromey  <tom@tromey.com>
2628
2629         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2630         (basic_inf_threads_range): Remove.
2631         (inf_threads_range, inf_non_exited_threads_range)
2632         (safe_inf_threads_range): Use next_adapter.
2633
2634 2019-01-10  Keith Seitz  <keiths@redhat.com>
2635
2636         PR gdb/23712
2637         PR symtab/23010
2638         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2639         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2640
2641 2019-01-10  Keith Seitz  <keiths@redhat.com>
2642
2643         PR gdb/23712
2644         PR symtab/23010
2645         * dictionary.c (pending_to_vector): Remove.
2646         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2647         Remove _1 suffix, replacing functions of the same name.  Update
2648         all callers.
2649         (dict_create_hashed, dict_create_hashed_expandable)
2650         (dict_create_linear, dict_create_linear_expandable, dict_free)
2651         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2652         Make functions static.
2653
2654 2019-01-10  Keith Seitz  <keiths@redhat.com>
2655
2656         PR gdb/23712
2657         PR symtab/23010
2658         * dictionary.h (struct dictionary): Replace declaration with
2659         multidictionary.
2660         (dict_create_hashed, dict_create_hashed_expandable)
2661         (dict_create_linear, dict_create_linear_expandable)
2662         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2663         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2664         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2665         taking multidictionary argument.
2666         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2667         * block.h (struct block) <dict>: Change to multidictionary
2668         and rename `multidict'.
2669         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2670         symmisc.c: Update all dictionary references to multidictionary.
2671
2672 2019-01-10  Keith Seitz  <keiths@redhat.com>
2673
2674         PR gdb/23712
2675         PR symtab/23010
2676         * dictionary.c: Include unordered_map.
2677         (pending_to_vector): New function.
2678         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2679         Rewrite the non-"_1" functions to take vector instead
2680         of linked list.
2681         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2682         "new" _1 versions of the same name.
2683         (multidictionary): Define.
2684         (std::hash<enum language): New definition.
2685         (collate_pending_symbols_by_language, mdict_create_hashed)
2686         (mdict_create_hashed_expandable, mdict_create_linear)
2687         (mdict_create_linear_expandable, mdict_free)
2688         (find_language_dictionary, create_new_language_dictionary)
2689         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2690         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2691         (mdict_size, mdict_empty): New functions.
2692         * dictionary.h (mdict_iterator): Define.
2693
2694 2019-01-10  Pedro Alves  <palves@redhat.com>
2695
2696         * breakpoint.c (read_uploaded_action)
2697         (create_tracepoint_from_upload): Adjust to use
2698         gdb::unique_xmalloc_ptr.
2699         * ctf.c (ctf_write_uploaded_tp):
2700         (SET_ARRAY_FIELD): Use emplace_back.
2701         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2702         * tracefile-tfile.c (tfile_write_uploaded_tp):
2703         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2704         gdb::unique_xmalloc_ptr.
2705         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2706         at_string, cond_string, cmd_strings>: Replace char pointers
2707         with gdb::unique_xmalloc_ptr.
2708
2709 2019-01-10  Pedro Alves  <palves@redhat.com>
2710
2711         * solib-target.c (library_list_start_library): Don't xstrdup name.
2712
2713 2019-01-10  Pedro Alves  <palves@redhat.com>
2714
2715         * mdebugread.c (parse_partial_symbols): Use
2716         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2717
2718 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2719
2720         * linux-fork.c (scoped_switch_fork_info)
2721         <~scoped_switch_fork_info>: Fix incorrect variable name.
2722
2723 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2724
2725         * linux-fork.c (scoped_switch_fork_info)
2726         <scoped_switch_fork_info>: Make explicit.
2727         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2728
2729 2019-01-10  Tom Tromey  <tom@tromey.com>
2730
2731         * objfiles.h (objfile::reset_psymtabs): Update.
2732         * objfiles.c (objfile::objfile): Update.
2733         * psymtab.h (psymtab_storage::obstack): Update.
2734         (psymtab_storage::m_obstack): Use gdb::optional.
2735         (class psymtab_storage): Update comment.  Remove objfile
2736         parameter.
2737         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2738
2739 2019-01-10  Tom Tromey  <tom@tromey.com>
2740
2741         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2742         <free_psymtabs>: Now private.
2743         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2744         (allocate_psymtab): Use new method.
2745
2746 2019-01-10  Tom Tromey  <tom@tromey.com>
2747
2748         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2749         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2750         * mdebugread.c (parse_partial_symbols): Use
2751         allocate_dependencies.
2752         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2753         allocate_dependencies.
2754         (process_psymtab_comp_unit_reader)
2755         (build_type_psymtab_dependencies): Likewise.
2756         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2757
2758 2019-01-10  Tom Tromey  <tom@tromey.com>
2759
2760         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2761         PSYMBOL_SET_LANGUAGE.
2762         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2763
2764 2019-01-10  Tom Tromey  <tom@tromey.com>
2765
2766         * psymtab.h (psymtab_storage::obstack): New method.
2767         <m_obstack>: Rename from obstack; now private.
2768         * psymtab.c (psymtab_storage): Update.
2769         * dwarf2read.c (create_addrmap_from_index)
2770         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2771         Update.
2772
2773 2019-01-10  Tom Tromey  <tom@tromey.com>
2774
2775         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2776         * objfiles.h (objfile::reset_psymtabs): New method.
2777
2778 2019-01-10  Tom Tromey  <tom@tromey.com>
2779
2780         * symmisc.c (print_symbol_bcache_statistics): Update.
2781         (print_objfile_statistics): Update.
2782         * symfile.c (reread_symbols): Update.
2783         * psymtab.h (class psymtab_storage): New.
2784         * psymtab.c (psymtab_storage): New constructor.
2785         (~psymtab_storage): New destructor.
2786         (require_partial_symbols): Update.
2787         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2788         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2789         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2790         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2791         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2792         (start_psymtab_common, end_psymtab_common)
2793         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2794         (allocate_psymtab): Update.
2795         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2796         Update.
2797         (dump_psymtab_addrmap, maintenance_print_psymbols)
2798         (maintenance_check_psymtabs): Update.
2799         (class objfile_psymtabs): Move to objfiles.h.
2800         * psympriv.h (discard_psymtab): Now inline.
2801         (psymtab_discarder::psymtab_discarder): Update.
2802         (psymtab_discarder::~psymtab_discarder): Update.
2803         (ALL_OBJFILE_PSYMTABS): Rewrite.
2804         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2805         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2806         Remove fields.
2807         <partial_symtabs>: New field.
2808         (class objfile_psymtabs): Move from psymtab.h.  Update.
2809         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2810         psymbol_cache.
2811         (objfile::~objfile): Don't destroy psymbol_cache.
2812         * mdebugread.c (parse_partial_symbols): Update.
2813         * dwarf2read.c (create_addrmap_from_index)
2814         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2815         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2816         (add_partial_subprogram, dwarf2_ranges_read): Update.
2817         * dwarf-index-write.c (write_address_map)
2818         (write_one_signatured_type, recursively_write_psymbols)
2819         (class debug_names, class debug_names, write_psymtabs_to_index):
2820         Update.
2821
2822 2019-01-10  Tom Tromey  <tom@tromey.com>
2823
2824         * symtab.h (SYMBOL_SET_NAMES): Update.
2825         (symbol_set_names): Update.
2826         (MSYMBOL_SET_NAMES): Update.
2827         * symtab.c (symbol_set_names): Change argument to be an
2828         objfile_per_bfd_storage.
2829         * psymtab.c (add_psymbol_to_bcache): Update.
2830         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2831
2832 2019-01-10  Tom Tromey  <tom@tromey.com>
2833
2834         * symtab.c (create_demangled_names_hash): Change argument to be an
2835         objfile_per_bfd_storage.
2836         (symbol_set_names): Update.
2837
2838 2019-01-10  Tom Tromey  <tom@tromey.com>
2839
2840         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2841         init_psymbol_list.
2842         * psymtab.c (init_psymbol_list): Do nothing if already called.
2843         * psympriv.h (init_psymbol_list): Add comment.
2844         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2845         init_psymbol_list.
2846         * dbxread.c (dbx_symfile_read): Unconditionally call
2847         init_psymbol_list.
2848
2849 2019-01-10  Tom Tromey  <tom@tromey.com>
2850
2851         * xcoffread.c (scan_xcoff_symtab): Update.
2852         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2853         "where".
2854         * mdebugread.c (parse_partial_symbols)
2855         (handle_psymbol_enumerators): Update.
2856         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2857         * dbxread.c (read_dbx_symtab): Update.
2858         * psympriv.h (psymbol_placement): New enum.
2859         (add_psymbol_to_list): Update.
2860
2861 2019-01-10  Tom Tromey  <tom@tromey.com>
2862
2863         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2864         static_psymbols parameters.
2865         (scan_xcoff_symtab): Update.
2866         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2867         static_psymbols parameters.
2868         * psympriv.h (start_psymtab_common): Update.
2869         * mdebugread.c (parse_partial_symbols): Update.
2870         * dwarf2read.c (create_partial_symtab): Update.
2871         * dbxread.c (read_dbx_symtab): Update.
2872         (start_psymtab): Remove global_psymbols and static_psymbols
2873         parameters.
2874
2875 2019-01-10  Tom Tromey  <tom@tromey.com>
2876
2877         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2878         * psymtab.c (allocate_psymtab): Add comment.
2879         * psympriv.h (allocate_psymtab): Add comment.
2880         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2881         initializations.
2882         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2883
2884 2019-01-10  Tom Tromey  <tom@tromey.com>
2885
2886         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2887         Don't declare.
2888         * mipsread.c: Include mdebugread.h.
2889         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2890         Declare.
2891         * elfread.c: Include mdebugread.h.
2892
2893 2019-01-09  Tom Tromey  <tom@tromey.com>
2894
2895         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2896         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2897         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2898         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2899         (psym_lookup_symbol, psym_find_last_source_symtab)
2900         (psym_forget_cached_source_info, psym_print_stats)
2901         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2902         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2903         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2904         (psym_find_compunit_symtab_by_address)
2905         (maintenance_print_psymbols, maintenance_info_psymtabs)
2906         (maintenance_check_psymtabs): Use ranged for.
2907         * psymtab.h (class objfile_psymtabs): New.
2908         (require_partial_symbols): Return objfile_psymtabs.
2909         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2910
2911 2019-01-09  Tom Tromey  <tom@tromey.com>
2912
2913         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2914         (find_pc_mapped_section, list_overlays_command)
2915         (map_overlay_command, unmap_overlay_command)
2916         (simple_overlay_update): Use all_objfiles.
2917         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2918         * printcmd.c (info_symbol_command): Use all_objfiles.
2919         * objfiles.h (ALL_OBJSECTIONS): Remove.
2920         * maint.c (maintenance_translate_address): Use all_objfiles.
2921         * gcore.c (gcore_create_callback): Use all_objfiles.
2922         (objfile_find_memory_regions): Likewise.
2923
2924 2019-01-09  Tom Tromey  <tom@tromey.com>
2925
2926         * symtab.c (find_line_symtab, info_sources_command)
2927         (make_source_files_completion_list): Use objfile_compunits.
2928         * source.c (select_source_symtab): Use objfile_compunits.
2929         * objfiles.h (struct objfile): Update comment.
2930         (ALL_OBJFILES): Remove.
2931         (ALL_FILETABS): Remove.
2932         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2933         objfile_compunits.
2934
2935 2019-01-09  Tom Tromey  <tom@tromey.com>
2936
2937         * symmisc.c (print_objfile_statistics, dump_objfile)
2938         (maintenance_print_symbols): Use compunit_filetabs.
2939         * source.c (forget_cached_source_info_for_objfile): Use
2940         compunit_filetabs.
2941         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2942         (ALL_FILETABS): Use compunit_filetabs.
2943         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2944         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2945
2946 2019-01-09  Tom Tromey  <tom@tromey.com>
2947
2948         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2949         (compunit_filetabs): New.
2950         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2951         compunit_filetabs.
2952         (info_sources_command, make_source_files_completion_list): Remove
2953         declaration.
2954         * symmisc.c (print_objfile_statistics, dump_objfile)
2955         (maintenance_print_symbols): Remove declaration.
2956         (maintenance_info_symtabs): Use compunit_filetabs.
2957         (maintenance_info_line_tables): Likewise.
2958         * source.c (select_source_symtab): Change local variable name.
2959         (forget_cached_source_info_for_objfile): Remove declaration.
2960         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2961         * objfiles.c (objfile_relocate1): Remove declaration.
2962         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2963         declaration.
2964         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2965         * coffread.c (coff_symtab_read): Remove declaration.
2966         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2967         compunit_filetabs.
2968
2969 2019-01-09  Tom Tromey  <tom@tromey.com>
2970
2971         * symtab.c (lookup_objfile_from_block)
2972         (find_pc_sect_compunit_symtab, search_symbols)
2973         (default_collect_symbol_completion_matches_break_on): Use
2974         objfile_compunits.
2975         * objfiles.h (ALL_COMPUNITS): Remove.
2976         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2977         * cp-support.c (add_symbol_overload_list_qualified): Use
2978         objfile_compunits.
2979         * ada-lang.c (ada_collect_symbol_completion_matches)
2980         (ada_add_global_exceptions): Use objfile_compunits.
2981
2982 2019-01-09  Tom Tromey  <tom@tromey.com>
2983
2984         * source.c (select_source_symtab)
2985         (forget_cached_source_info_for_objfile): Remove declaration.
2986         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2987         declaration.
2988         * maint.c (count_symtabs_and_blocks): Remove declaration.
2989         * cp-support.c (add_symbol_overload_list_qualified): Remove
2990         declaration.
2991         * coffread.c (coff_symtab_read): Remove declaration.
2992         * symtab.c (lookup_symbol_in_objfile_symtabs)
2993         (basic_lookup_transparent_type_1): Use objfile_compunits.
2994         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2995         (info_sources_command, search_symbols)
2996         (default_collect_symbol_completion_matches_break_on)
2997         (make_source_files_completion_list): Remove declaration.
2998         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2999         (ada_collect_symbol_completion_matches)
3000         (ada_add_global_exceptions): Remove declaration.
3001         * linespec.c (iterate_over_all_matching_symtabs): Use
3002         objfile_compunits.
3003         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3004         (class objfile_compunits): New.
3005         (ALL_COMPUNITS): Use objfile_compunits.
3006         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3007         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3008         objfile_compunits.
3009         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3010
3011 2019-01-09  Tom Tromey  <tom@tromey.com>
3012
3013         * symtab.c (search_symbols)
3014         (default_collect_symbol_completion_matches_break_on): Use
3015         objfile_msymbols.
3016         * ada-lang.c (ada_lookup_simple_minsym)
3017         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3018         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3019         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3020         objfile_msymbols.
3021         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3022         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3023         * objc-lang.c (find_methods): Use objfile_msymbols.
3024         (info_selectors_command, info_classes_command): Likewise.
3025         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3026         * objfiles.h (class objfile_msymbols): New.
3027         (ALL_OBJFILE_MSYMBOLS): Remove.
3028         (ALL_MSYMBOLS): Remove.
3029
3030 2019-01-09  Tom Tromey  <tom@tromey.com>
3031
3032         * common/next-iterator.h (next_adapter): Add Iterator template
3033         parameter.
3034         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3035         (class all_objfiles_safe): New.
3036         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3037         * objfiles.c (put_objfile_before): Update comment.
3038         (add_separate_debug_objfile): Likewise.
3039         (free_all_objfiles): Use all_objfiles_safe.
3040         (objfile_purge_solibs): Likewise.
3041
3042 2019-01-09  Tom Tromey  <tom@tromey.com>
3043
3044         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3045         (expand_symtab_containing_pc, lookup_static_symbol)
3046         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3047         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3048         all_objfiles.
3049         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3050         * breakpoint.c (create_overlay_event_breakpoint)
3051         (create_longjmp_master_breakpoint)
3052         (create_std_terminate_master_breakpoint)
3053         (create_exception_master_breakpoint): Use all_objfiles.
3054         * linux-thread-db.c (try_thread_db_load_from_pdir)
3055         (has_libpthread): Use all_objfiles.
3056         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3057         * linespec.c (iterate_over_all_matching_symtabs)
3058         (search_minsyms_for_name): Use all_objfiles.
3059         * maint.c (maintenance_info_sections): Use all_objfiles.
3060         * main.c (captured_main_1): Use all_objfiles.
3061         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3062         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3063         * guile/scm-pretty-print.c
3064         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3065         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3066         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3067         (maintenance_print_msymbols): Use all_objfiles.
3068         * source.c (select_source_symtab): Use all_objfiles.
3069         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3070         * symfile.c (remove_symbol_file_command)
3071         (expand_symtabs_matching, map_symbol_filenames): Use
3072         all_objfiles.
3073         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3074         all_objfiles.
3075         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3076         * objc-lang.c (find_methods): Use all_objfiles.
3077         * objfiles.c (have_partial_symbols, have_full_symbols)
3078         (have_minimal_symbols, qsort_cmp)
3079         (default_iterate_over_objfiles_in_search_order): Use
3080         all_objfiles.
3081         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3082         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3083         (maintenance_check_psymtabs): Use all_objfiles.
3084         (ALL_PSYMTABS): Remove.
3085         * compile/compile-object-run.c (do_module_cleanup): Use
3086         all_objfiles.
3087         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3088         * cp-support.c (add_symbol_overload_list_qualified): Use
3089         all_objfiles.
3090         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3091         Use all_objfiles.
3092         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3093         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3094         all_objfiles.
3095         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3096         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3097         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3098         Uses all_objfiles.
3099         * solib.c (solib_read_symbols): Use all_objfiles
3100
3101 2019-01-09  Tom Tromey  <tom@tromey.com>
3102
3103         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3104         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3105         all_objfiles.
3106         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3107         * symmisc.c (print_symbol_bcache_statistics)
3108         (print_objfile_statistics, maintenance_print_objfiles)
3109         (maintenance_info_symtabs, maintenance_check_symtabs)
3110         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3111         all_objfiles.
3112         * source.c (forget_cached_source_info): Use all_objfiles.
3113         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3114         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3115         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3116         * objfiles.c (update_section_map): Use all_objfiles.
3117         (shared_objfile_contains_address_p): Likewise.
3118         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3119         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3120
3121 2019-01-09  Tom Tromey  <tom@tromey.com>
3122
3123         * common/next-iterator.h: New file.
3124         * objfiles.h (class all_objfiles): New.
3125         (struct objfile_iterator): New.
3126
3127 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3128
3129         * NEWS: Move the description of the changed "frame", "select-frame",
3130          and "info frame" commands to the Changed commands section.
3131
3132 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3133
3134         * gdbtypes.c (check_stub_method_group): Remove handling of old
3135         mangling schemes.
3136         * linespec.c (find_methods): Likewise.
3137         * stabsread.c (read_member_functions): Likewise.
3138         * valops.c (search_struct_method): Likewise.
3139         (value_struct_elt_for_reference): Likewise.
3140         * NEWS: Mention this change.
3141
3142 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3143
3144         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3145         print_source_lines.
3146         * source.c (print_source_lines_base): Update line number check.
3147         (print_source_lines): New function.
3148         (source_lines_range::source_lines_range): New function.
3149         * source.h (class source_lines_range): New class.
3150         (print_source_lines): New declaration.
3151
3152 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3153
3154         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3155
3156 2019-01-08  Tom Tromey  <tom@tromey.com>
3157             Simon Marchi  <simon.marchi@ericsson.com>
3158
3159         PR gdb/24060
3160         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3161         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3162         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3163         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3164         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3165         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3166
3167 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3168
3169         * source.c (select_source_symtab): Move header comment to
3170         declaration in source.h.
3171         (forget_cached_source_info_for_objfile): Likewise.
3172         (forget_cached_source_info): Likewise.
3173         (identify_source_line): Likewise.
3174         * source.h (identify_source_line): Move declaration from symtab.h
3175         and add comment from source.c
3176         (print_source_lines): Likewise.
3177         (forget_cached_source_info_for_objfile): Likewise.
3178         (forget_cached_source_info): Likewise.
3179         (select_source_symtab): Likewise.
3180         (enum print_source_lines_flag): Move definition from symtab.h.
3181         * symtab.h (identify_source_line): Move declaration to source.h.
3182         (print_source_lines): Likewise.
3183         (forget_cached_source_info_for_objfile): Likewise.
3184         (forget_cached_source_info): Likewise.
3185         (select_source_symtab): Likewise.
3186         (enum print_source_lines_flag): Move definition to source.h.
3187         * tui/tui-hooks.c: Add 'source.h' include.
3188
3189 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3190
3191         * source.c (print_source_lines_base): Handle requests to print
3192         reverse line number sequences, and guard against empty lines
3193         string.
3194
3195 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3196
3197         * source.c (print_source_lines_base): Fix skip of '\r' if next
3198         character is '\n'.
3199
3200 2019-01-06  Tom Tromey  <tom@tromey.com>
3201
3202         * c-exp.y (struct c_parse_state) <macro_original_text,
3203         expansion_obstack>: New member.
3204         (macro_original_text, expansion_obstack): Remove globals.
3205         (scan_macro_expansion, scanning_macro_expansion)
3206         (finished_macro_expansion): Update.
3207         (scan_macro_cleanup): Remove.
3208         (yylex, c_parse): Update.
3209
3210 2019-01-06  Tom Tromey  <tom@tromey.com>
3211
3212         * c-exp.y (struct c_parse_state) <strings>: New member.
3213         (operator_stoken): Update.
3214
3215 2019-01-06  Tom Tromey  <tom@tromey.com>
3216
3217         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3218         (union type_stack_elt) <typelist_val>: Now a pointer to
3219         std::vector.
3220         (type_stack_cleanup): Don't declare.
3221         (push_typelist): Update.
3222         * parse.c (pop_typelist): Return a std::vector.
3223         (push_typelist): Take a std::vector.
3224         (follow_types): Update.  Do not free args.
3225         (type_stack_cleanup): Remove.
3226         * c-exp.y (struct c_parse_state): New.
3227         (cpstate): New global.
3228         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3229         (nonempty_typelist): Update.
3230         (func_mod): Create a new vector.
3231         (c_parse): Create a c_parse_state.
3232         (check_parameter_typelist): Do not delete params.
3233         (function_method): Update.  Do not delete type_list.
3234
3235 2019-01-06  Tom Tromey  <tom@tromey.com>
3236
3237         PR gdb/28155:
3238         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3239         check_typedef.
3240         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3241         (print_return_value): Likewise.
3242
3243 2019-01-05  Tom Tromey  <tom@tromey.com>
3244
3245         * contrib/cleanup_check.py: Remove.
3246         * contrib/gcc-with-excheck: Remove.
3247         * contrib/exsummary.py: Remove.
3248         * contrib/excheck.py: Remove.
3249
3250 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3251
3252         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3253         NULL. Initialize tpprev to NULL instead of assigning it
3254         to NULL on the next statement.
3255         * windows-nat.c (windows_delete_thread): Remove check for
3256         main_thread_id before printing thread exit notifications.
3257         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3258         Remove thread ID check against main_thread_id.
3259         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3260         windows_delete_thread.
3261         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3262
3263 2019-01-04  Tom Tromey  <tom@tromey.com>
3264
3265         * compile/compile.c (_initialize_compile): Use upper case for
3266         metasyntactic variables.
3267         * symmisc.c (_initialize_symmisc): Use upper case for
3268         metasyntactic variables.
3269         * psymtab.c (_initialize_psymtab): Use upper case for
3270         metasyntactic variables.
3271         * demangle.c (demangle_command): Use upper case for metasyntactic
3272         variables.
3273         (_initialize_demangler): Likewise.
3274         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3275         variables.
3276
3277 2019-01-03  Tom Tromey  <tom@tromey.com>
3278
3279         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3280
3281 2019-01-03  Tom Tromey  <tom@tromey.com>
3282
3283         * python/py-symtab.c (salpy_str): Update.
3284         (struct salpy_sal_object) <symtab>: Now a PyObject.
3285         (salpy_dealloc): Update.
3286         (del_objfile_sal): Use gdbpy_ref.
3287
3288 2019-01-03  Tom Tromey  <tom@tromey.com>
3289
3290         * python/py-type.c (convert_field): Use new_reference.  Return
3291         gdbpy_ref.
3292         (make_fielditem): Return gdbpy_ref.
3293         (typy_fields): Update.
3294         (typy_getitem): Update.
3295         (field_name): Return gdbpy_ref.  Use new_reference.
3296         (typy_iterator_iternext): Update.
3297
3298 2019-01-03  Tom Tromey  <tom@tromey.com>
3299
3300         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3301
3302 2019-01-03  Tom Tromey  <tom@tromey.com>
3303
3304         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3305         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3306         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3307         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3308         (pspy_set_type_printers): Likewise.
3309         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3310         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3311         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3312         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3313         (objfpy_set_type_printers): Likewise.
3314
3315 2019-01-03  Tom Tromey  <tom@tromey.com>
3316
3317         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3318         (gdbpy_print_stack): Use gdbpy_err_fetch.
3319         * python/python-internal.h (class gdbpy_err_fetch): New class.
3320         (class gdbpy_enter) <m_error_type, m_error_value,
3321         m_error_traceback>: Remove.
3322         <m_error>: New member.
3323         (gdbpy_exception_to_string): Don't declare.
3324         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3325         * python/py-value.c (convert_value_from_python): Use
3326         gdbpy_err_fetch.
3327         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3328         gdbpy_exception_to_string.
3329         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3330         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3331         gdbpy_err_fetch.
3332
3333 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3334
3335         * linux-nat.c (delete_lwp_cleanup): Delete.
3336         (struct lwp_deleter): New struct.
3337         (lwp_info_up): New typedef.
3338         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3339         lwp_info_up.
3340
3341 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3342
3343         * linux-fork.c (class scoped_switch_fork_info): New class.
3344         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3345
3346 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3347
3348         * valops.c (find_overload_match): Remove use of null_cleanup, and
3349         calls to do_cleanups.
3350
3351 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3352
3353         * compile/compile-cplus-types.c
3354         (compile_cplus_instance::decl_name): Handle changes to
3355         cp_func_name.
3356         * cp-support.c (cp_func_name): Update header comment, update
3357         return type.
3358         * cp-support.h (cp_func_name): Update return type in declaration.
3359         * valops.c (find_overload_match): Move temp_func local to top
3360         level of function and change its type.  Use temp_func to hold and
3361         delete temporary string obtained from cp_func_name.
3362
3363 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3364
3365         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3366         gdb::char_vector, remove cleanup, and update uses of `msg`.
3367
3368 2019-01-03  Jim Wilson  <jimw@sifive.com>
3369
3370         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3371
3372 2019-01-02  Tom Tromey  <tom@tromey.com>
3373
3374         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3375         (tdesc_parse_xml): Remove cleanups.
3376         * target-descriptions.h (make_cleanup_free_target_description):
3377         Don't declare.
3378         (target_desc_deleter): New struct.
3379         (target_desc_up): New typedef.
3380         * target-descriptions.c (target_desc_deleter::operator()): Rename
3381         from free_target_description.
3382         (make_cleanup_free_target_description): Remove.
3383
3384 2019-01-02  Tom Tromey  <tom@tromey.com>
3385
3386         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3387         constructor, destructor.
3388         (linespec_parser): Remove typedef.
3389         (~linespec_parser): Rename from linespec_parser_delete.
3390         (linespec_lex_to_end, linespec_complete_label)
3391         (linespec_complete): Update.
3392         (decode_line_full): Remove cleanups.
3393         (decode_line_1): Update.
3394
3395 2019-01-02  Tom Tromey  <tom@tromey.com>
3396
3397         * python/python-internal.h (inferior_to_inferior_object): Change
3398         return type.
3399         * python/py-exitedevent.c (create_exited_event_object): Update.
3400         * python/py-inferior.c (inferior_to_inferior_object): Return
3401         gdbpy_ref.
3402         (python_new_inferior, python_inferior_deleted)
3403         (thread_to_thread_object, delete_thread_object)
3404         (build_inferior_list, gdbpy_selected_inferior): Update.
3405         * python/py-infthread.c (create_thread_object): Update.  Also fail
3406         if inferior_to_inferior_object fails.
3407
3408 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3409
3410         * inferior.h (class inferior) <displaced_step_state>: New field.
3411         * infrun.h (struct displaced_step_state): Move here from
3412         infrun.c.  Initialize fields, add constructor.
3413         <inf>: Remove field.
3414         <reset>: New method.
3415         * infrun.c (struct displaced_step_inferior_state): Move to
3416         infrun.h.
3417         (displaced_step_inferior_states): Remove.
3418         (get_displaced_stepping_state): Adust.
3419         (displaced_step_in_progress_any_inferior): Adjust.
3420         (displaced_step_in_progress_thread): Adjust.
3421         (displaced_step_in_progress): Adjust.
3422         (add_displaced_stepping_state): Remove.
3423         (get_displaced_step_closure_by_addr): Adjust.
3424         (remove_displaced_stepping_state): Remove.
3425         (infrun_inferior_exit): Call displaced_step_state.reset.
3426         (use_displaced_stepping): Don't check for NULL.
3427         (displaced_step_prepare_throw): Call
3428         get_displaced_stepping_state.
3429         (displaced_step_fixup): Don't check for NULL.
3430         (prepare_for_detach): Don't check for NULL.
3431
3432 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3433
3434         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3435          in case of call that did not complete.
3436
3437 2019-01-02  Andrey Utkin  <autkin@undo.io>
3438
3439         * symfile.c (find_separate_debug_file): Fix search of debug files for
3440         remote debuggee.
3441
3442 2019-01-02  Tom Tromey  <tom@tromey.com>
3443
3444         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3445         indentation.
3446         * python/py-frame.c (frapy_older): Remove cast.
3447         (frapy_newer): Likewise.
3448         * python/py-breakpoint.c (local_setattro): Remove cast.
3449         * python/py-arch.c (archpy_name): Remove local variable.
3450         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3451
3452 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3453
3454         * unittests/basic_string_view/element_access/char/empty.cc:
3455         Fix year range in copyright header.
3456
3457 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3458
3459         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3460         Delete.
3461         <operator==>: Update with for removed field.
3462         <hash>: Likewise.
3463         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3464         <isa_features>: ...this.
3465         <abi_features>: New field.
3466         (riscv_isa_flen): Update comment.
3467         (riscv_abi_xlen): New declaration.
3468         (riscv_abi_flen): New declaration.
3469         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3470         isa_features.
3471         (riscv_abi_xlen): New function.
3472         (riscv_isa_flen): Update to get answer from isa_features.
3473         (riscv_abi_flen): New function.
3474         (riscv_has_fp_abi): Update to get answer from abi_features.
3475         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3476         xlen and flen.
3477         (riscv_call_info) <xlen, flen>: Update comment.
3478         (riscv_call_arg_struct): Remove invalid assertions
3479         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3480         is removed.
3481         (riscv_gdbarch_init): Gather isa features and abi features
3482         separately, ensure both match on the gdbarch when reusing an old
3483         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3484         a target with 64-bit float hardware.
3485
3486 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3487
3488         * source.c (search_command_helper): Stop reverse search
3489         when line 1 has been searched.
3490
3491 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3492
3493         * record-full.c (record_full_base_target::close): Rewrite
3494         record_full_core_buf_list free logic.
3495
3496 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3497
3498         * break-catch-syscall.c (print_one_catch_syscall): xfree
3499         the last text.
3500
3501 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3502
3503         * top.c (print_gdb_version): Update Copyright year in version
3504         message.
3505
3506 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3507
3508         Update copyright year range in all GDB files.
3509
3510 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3511
3512         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3513
3514 For older changes see ChangeLog-2018.
3515 \f
3516 Local Variables:
3517 mode: change-log
3518 left-margin: 8
3519 fill-column: 74
3520 version-control: never
3521 coding: utf-8
3522 End:
3523