gdb/ChangeLog

   1 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
   4
   5 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
   6
   7         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
   8         * version.in: Bump version to 8.2.90.DATE-git.
   9
  10 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
  11
  12         * aix-thread.c (ptid_cmp): Remove unused variable.
  13         (get_signaled_thread): Likewise.
  14         (store_regs_user_thread): Likewise.
  15         (store_regs_kernel_thread): Likewise.
  16         (fetch_regs_kernel_thread): Remove shadowed variable.
  17
  18 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  19
  20         * features/riscv/32bit-cpu.xml: Add register numbers.
  21         * features/riscv/32bit-fpu.c: Regenerate.
  22         * features/riscv/32bit-fpu.xml: Add register numbers.
  23         * features/riscv/64bit-cpu.xml: Add register numbers.
  24         * features/riscv/64bit-fpu.c: Regenerate.
  25         * features/riscv/64bit-fpu.xml: Add register numbers.
  26
  27 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
  28
  29         * NEWS: Mention two argument form of gdb.Value constructor.
  30         * python/py-value.c (convert_buffer_and_type_to_value): New
  31         function.
  32         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
  33         Add support for handling an optional second argument.  Call
  34         convert_buffer_and_type_to_value as appropriate.
  35         * python/python-internal.h (Py_buffer_deleter): New struct.
  36         (Py_buffer_up): New typedef.
  37
  38 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
  39
  40         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
  41         instead of releasing ownership.
  42
  43 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
  44
  45         * dwarf2read.c (open_and_init_dwp_file): Call
  46         elf_numsections instead of bfd_count_sections to initialize
  47         dwp_file->num_sections.
  48
  49 2019-02-25  Tom Tromey  <tromey@adacore.com>
  50
  51         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
  52
  53 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  54
  55         * gcore.in: Add '--readnever' option when invoking GDB.
  56
  57 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  58
  59         * MAINTAINERS: Update my email address.
  60
  61 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  62
  63         * build-id.c (build_id_to_debug_bfd_1): New function.
  64         (build_id_to_debug_bfd): Look for separate debug file in
  65         sysroot.
  66
  67 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  68
  69         * gdbarch.sh: Update the copyright year range that is placed into
  70         generated files.
  71
  72 2019-02-22  Keith Seitz  <keiths@redhat.com>
  73
  74         PR symtab/23853
  75         * linespec.c (create_sals_line_offset): Search for the default
  76         symtab's filename instead of its fullname.
  77
  78 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  79
  80         * NEWS: Update style defaults.
  81
  82 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  83
  84         * main.c (captured_main_1): Disable styling in batch mode.
  85
  86 2019-02-20  Tom Tromey  <tom@tromey.com>
  87
  88         * symtab.c (symtab_symbol_info): Fix typos.
  89
  90 2019-02-20  Tom Tromey  <tromey@adacore.com>
  91
  92         * findcmd.c (_initialize_mem_search): Use upper case for
  93         metasyntactic variables.
  94
  95 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  96
  97         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  98         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  99
 100 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 101
 102         * top.h (source_file_name): Change to std::string.
 103         * top.c (source_file_name): Likewise.
 104         (command_line_input): Adjust.
 105         * cli/cli-script.c (script_from_file): Adjust.
 106
 107 2019-02-19  Tom Tromey  <tromey@adacore.com>
 108
 109         * ravenscar-thread.c
 110         (ravenscar_thread_target::update_thread_list): Don't call
 111         ada_build_task_list.
 112         * ada-lang.h (ada_build_task_list): Don't declare.
 113         * ada-tasks.c (struct ada_tasks_inferior_data)
 114         <task_list_valid_p>: Now bool.
 115         (read_known_tasks, ada_task_list_changed)
 116         (ada_tasks_invalidate_inferior_data): Update.
 117         (read_known_tasks_array): Return bool.
 118         (read_known_tasks_list): Likewise.
 119         (read_known_tasks): Return void.
 120         (ada_build_task_list): Now static.
 121
 122 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 123
 124         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 125         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 126
 127 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 128
 129         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 130         variant for ada_tasks_pspace_data_handle and
 131         ada_tasks_inferior_data_handle.
 132         (ada_tasks_pspace_data_cleanup): New function.
 133         (ada_tasks_inferior_data_cleanup): New function.
 134
 135 2019-02-17  Tom Tromey  <tom@tromey.com>
 136
 137         * macrotab.h (macro_source_fullname): Return a std::string.
 138         * macrotab.c (macro_include, check_for_redefinition)
 139         (macro_undef, macro_lookup_definition, foreach_macro)
 140         (foreach_macro_in_scope): Update.
 141         (macro_source_fullname): Return a std::string.
 142         * macrocmd.c (show_pp_source_pos): Update.
 143
 144 2019-02-17  Tom Tromey  <tom@tromey.com>
 145
 146         * macrocmd.c (show_pp_source_pos): Style the file names.
 147
 148 2019-02-17  Tom Tromey  <tom@tromey.com>
 149
 150         PR tui/24197:
 151         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 152
 153 2019-02-17  Tom Tromey  <tom@tromey.com>
 154
 155         * ada-lang.c (user_select_syms): Use filtered printing.
 156         * utils.c (wrap_style): New global.
 157         (desired_style): Remove.
 158         (emit_style_escape): Add stream parameter.
 159         (set_output_style, reset_terminal_style, prompt_for_continue):
 160         Update.
 161         (flush_wrap_buffer): Only flush gdb_stdout.
 162         (wrap_here): Set wrap_style.
 163         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 164         treat escape sequences as a character.  Change when wrap buffer is
 165         flushed.
 166         (fputs_styled): Do not set the output style when the default is
 167         requested.
 168         * ui-style.h (struct ui_file_style) <is_default>: New method.
 169         * source.c (print_source_lines_base): Emit escape sequences in one
 170         piece.
 171
 172 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 173
 174         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 175         integers and enumeration types.
 176
 177 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 178
 179         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 180         instead of lookup_symbol_in_language
 181         (do_exact_match): New function.
 182         (ada_get_symbol_name_matcher): Return do_exact_match when
 183         doing a verbatim match.
 184
 185 2019-02-15  Tom Tromey  <tromey@adacore.com>
 186
 187         * ravenscar-thread.c (ravenscar_thread_target::resume)
 188         (ravenscar_thread_target::wait): Special case wildcard requests.
 189
 190 2019-02-15  Tom Tromey  <tromey@adacore.com>
 191
 192         * ravenscar-thread.c (base_ptid): Remove.
 193         (struct ravenscar_thread_target) <close>: New method.
 194         <m_base_ptid>: New member.
 195         <update_inferior_ptid, active_task, task_is_currently_active,
 196         runtime_initialized>: Declare methods.
 197         <ravenscar_thread_target>: Add constructor.
 198         (ravenscar_thread_target::task_is_currently_active)
 199         (ravenscar_thread_target::update_inferior_ptid)
 200         (ravenscar_runtime_initialized): Rename.  Now methods.
 201         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 202         (ravenscar_thread_target::update_thread_list): Update.
 203         (ravenscar_thread_target::active_task): Now method.
 204         (ravenscar_thread_target::store_registers)
 205         (ravenscar_thread_target::prepare_to_store)
 206         (ravenscar_thread_target::prepare_to_store)
 207         (ravenscar_thread_target::mourn_inferior): Update.
 208         (ravenscar_inferior_created): Use "new" to create target.
 209         (ravenscar_thread_target::get_ada_task_ptid): Update.
 210         (_initialize_ravenscar): Don't initialize base_ptid.
 211         (ravenscar_ops): Remove global.
 212
 213 2019-02-15  Tom Tromey  <tromey@adacore.com>
 214
 215         * target.h (push_target): Declare new overload.
 216         * target.c (push_target): New overload, taking an rvalue reference.
 217         * remote.c (remote_target::open_1): Use push_target overload.
 218         * corelow.c (core_target_open): Use push_target overload.
 219
 220 2019-02-15  Tom Tromey  <tromey@adacore.com>
 221
 222         * ravenscar-thread.c (is_ravenscar_task)
 223         (ravenscar_task_is_currently_active): Return bool.
 224         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 225         (_initialize_ravenscar): Remove "(void)".
 226         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 227         Return bool.
 228
 229 2019-02-15  Tom Tromey  <tromey@adacore.com>
 230
 231         * ravenscar-thread.c (ravenscar_runtime_initializer)
 232         (has_ravenscar_runtime, get_running_thread_id)
 233         (ravenscar_thread_target::resume): Fix indentation.
 234
 235 2019-02-15  Tom Tromey  <tromey@adacore.com>
 236
 237         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 238         from ravenscar_arch_ops.
 239         (sparc_ravenscar_ops::fetch_registers)
 240         (sparc_ravenscar_ops::store_registers): Now methods.
 241         (sparc_ravenscar_prepare_to_store): Remove.
 242         (sparc_ravenscar_ops): Redefine.
 243         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 244         methods and destructor.  Remove members.
 245         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 246         (ravenscar_thread_target::store_registers)
 247         (ravenscar_thread_target::prepare_to_store): Update.
 248         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 249         Remove.
 250         (struct ppc_ravenscar_powerpc_ops): Derive from
 251         ravenscar_arch_ops.
 252         (ppc_ravenscar_powerpc_ops::fetch_registers)
 253         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 254         (ppc_ravenscar_powerpc_ops): Redefine.
 255         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 256         (ppc_ravenscar_e500_ops::fetch_registers)
 257         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 258         (ppc_ravenscar_e500_ops): Redefine.
 259         * aarch64-ravenscar-thread.c
 260         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 261         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 262         (aarch64_ravenscar_fetch_registers)
 263         (aarch64_ravenscar_store_registers): Now methods.
 264         (aarch64_ravenscar_ops): Redefine.
 265
 266 2019-02-15  Tom Tromey  <tromey@adacore.com>
 267
 268         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 269         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 270         (ravenscar_thread_target::stopped_by_watchpoint)
 271         (ravenscar_thread_target::stopped_data_address)
 272         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 273
 274 2019-02-15  Tom Tromey  <tromey@adacore.com>
 275
 276         * ravenscar-thread.c: Fix some typos.
 277
 278 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 279             Tom Tromey  <tromey@adacore.com>
 280
 281         * ada-lang.c (ada_exception_sal): Change addr_string to a
 282         std::string.
 283         (create_ada_exception_catchpoint): Update.
 284
 285 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 286             Tom Tromey  <tromey@adacore.com>
 287
 288         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 289         (bp_location_ops): Remove.
 290         (base_breakpoint_allocate_location): Update.
 291         (free_bp_location): Update.
 292         * ada-lang.c (class ada_catchpoint_location)
 293         <ada_catchpoint_location>: Remove ops parameter.
 294         (ada_catchpoint_location_dtor): Remove.
 295         (ada_catchpoint_location_ops): Remove.
 296         (allocate_location_exception): Update.
 297         * breakpoint.h (struct bp_location_ops): Remove.
 298         (class bp_location) <bp_location>: Remove bp_location_ops
 299         parameter.
 300         <~bp_location>: Add destructor.
 301         <ops>: Remove.
 302
 303 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 304             Pedro Alves  <palves@redhat.com>
 305
 306         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 307         'PATH_MAX'.
 308
 309 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 310             Samuel Thibault  <samuel.thibault@gnu.org>
 311             Thomas Schwinge  <thomas@codesourcery.com>
 312
 313         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 314         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 315
 316 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 317
 318         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 319         (check_empty): Use "const char *".
 320
 321         * gnu-nat.c (gnu_nat_target::detach): Instead of
 322         'detach_inferior (pid)' call
 323         'detach_inferior (find_inferior_pid (pid))'.
 324
 325         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 326         'nat/fork-inferior.o'.
 327         * gnu-nat.c: #include "nat/fork-inferior.h".
 328
 329         * gnu-nat.c (gnu_nat_target::detach): Instead of
 330         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 331         * gnu-nat.h: #include "inf-child.h".
 332         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 333         'i386_gnu_nat_target::fetch_registers'.
 334         (gnu_store_registers): Rename/move to
 335         'i386_gnu_nat_target::store_registers'.
 336
 337         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 338         * gnu-nat.h (mach_thread_info): New function.
 339         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 340
 341         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 342
 343 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 344
 345         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 346
 347 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 348
 349         * windows-nat.c (windows_add_thread): Add new parameter
 350         "main_thread_p" with default value set to false.  Update
 351         function documentation as well as all callers.
 352         (windows_delete_thread): Likewise.
 353         (fake_create_process): Update call to windows_add_thread.
 354         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 355         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 356         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 357         call to windows_delete_thread.
 358
 359 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 360
 361         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 362
 363 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 364
 365         * symfile.c (find_separate_debug_file): Use canonical path of
 366         sysroot with child_path instead of gdb_sysroot if it is valid.
 367
 368 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 369
 370         * symfile.c (find_separate_debug_file): Use child_path to
 371         determine if an object file is under a sysroot.
 372
 373 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 374
 375         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 376         unittests/child-path-selftests.c.
 377         * common/pathstuff.c (child_path): New function.
 378         * common/pathstuff.h (child_path): New prototype.
 379         * unittests/child-path-selftests.c: New file.
 380
 381 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 382
 383         * symfile.c (find_separate_debug_file): Look for separate debug
 384         files in debug directories under the sysroot.
 385
 386 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 387
 388         * symtab.h (struct minimal_symbol data_p): New const method.
 389         (struct minimal_symbol text_p): Likewise.
 390         * symtab.c (output_source_filename): Use file name style
 391         to print file name.
 392         (print_symbol_info): Likewise.
 393         (print_msymbol_info): Use address style to print addresses.
 394         Use function name style to print executable text symbols.
 395         (expand_symtab_containing_pc): Use data_p.
 396         (find_pc_sect_compunit_symtab): Likewise.
 397
 398 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 399
 400         * breakpoint.c (describe_other_breakpoints): Use address style
 401         to print addresses.
 402         (say_where): Likewise.
 403
 404 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 405
 406         * ada-typeprint.c (print_func_type): Print function name
 407         style to print function name.
 408         * c-typeprint.c (c_print_type_1): Likewise.
 409
 410 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 411
 412         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 413         for execve.
 414
 415 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 416
 417         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 418         type_stack.
 419
 420 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 421
 422         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 423         TYPE_CODE_REF types.
 424
 425 2019-02-08  Jim Wilson  <jimw@sifive.com>
 426
 427         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 428         (riscv_linux_fregset): New.
 429         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 430
 431 2019-02-07  Tom Tromey  <tom@tromey.com>
 432
 433         * thread.c (thread_cancel_execution_command): Update.
 434         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 435         methods.
 436         (struct thread_fsm_ops): Remove.
 437         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 438         (thread_fsm_should_stop, thread_fsm_return_value)
 439         (thread_fsm_set_finished, thread_fsm_finished_p)
 440         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 441         Don't declare.
 442         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 443         * infrun.c (clear_proceed_status_thread)
 444         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 445         (print_stop_event): Update.
 446         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 447         Add constructor.
 448         (step_command_fsm_ops): Remove.
 449         (new_step_command_fsm): Remove.
 450         (step_1): Update.
 451         (step_command_fsm::should_stop): Rename from
 452         step_command_fsm_should_stop.
 453         (step_command_fsm::clean_up): Rename from
 454         step_command_fsm_clean_up.
 455         (step_command_fsm::do_async_reply_reason): Rename from
 456         step_command_fsm_async_reply_reason.
 457         (struct until_next_fsm): Inherit from thread_fsm.  Add
 458         constructor.
 459         (until_next_fsm_ops): Remove.
 460         (new_until_next_fsm): Remove.
 461         (until_next_fsm::should_stop): Rename from
 462         until_next_fsm_should_stop.
 463         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 464         (until_next_fsm::do_async_reply_reason): Rename from
 465         until_next_fsm_async_reply_reason.
 466         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 467         constructor.  Change type of breakpoint.
 468         (finish_command_fsm_ops): Remove.
 469         (new_finish_command_fsm): Remove.
 470         (finish_command_fsm::should_stop): Rename from
 471         finish_command_fsm_should_stop.
 472         (finish_command_fsm::clean_up): Rename from
 473         finish_command_fsm_clean_up.
 474         (finish_command_fsm::return_value): Rename from
 475         finish_command_fsm_return_value.
 476         (finish_command_fsm::do_async_reply_reason): Rename from
 477         finish_command_fsm_async_reply_reason.
 478         (finish_command): Update.
 479         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 480         Add constructor.
 481         (call_thread_fsm_ops): Remove.
 482         (call_thread_fsm::call_thread_fsm): Rename from
 483         new_call_thread_fsm.
 484         (call_thread_fsm::should_stop): Rename from
 485         call_thread_fsm_should_stop.
 486         (call_thread_fsm::should_notify_stop): Rename from
 487         call_thread_fsm_should_notify_stop.
 488         (run_inferior_call, call_function_by_hand_dummy): Update.
 489         * cli/cli-interp.c (should_print_stop_to_console): Update.
 490         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 491         Add constructor.  Change type of location_breakpoint,
 492         caller_breakpoint.
 493         (until_break_fsm_ops): Remove.
 494         (new_until_break_fsm): Remove.
 495         (until_break_fsm::should_stop): Rename from
 496         until_break_fsm_should_stop.
 497         (until_break_fsm::clean_up): Rename from
 498         until_break_fsm_clean_up.
 499         (until_break_fsm::do_async_reply_reason): Rename from
 500         until_break_fsm_async_reply_reason.
 501         (until_break_command): Update.
 502         * thread-fsm.c: Remove.
 503         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 504
 505 2019-02-07  Tom Tromey  <tom@tromey.com>
 506
 507         * yy-remap.h: Add include guard.
 508         * xtensa-tdep.h: Add include guard.
 509         * xcoffread.h: Rename include guard.
 510         * varobj-iter.h: Add include guard.
 511         * tui/tui.h: Rename include guard.
 512         * tui/tui-winsource.h: Rename include guard.
 513         * tui/tui-wingeneral.h: Rename include guard.
 514         * tui/tui-windata.h: Rename include guard.
 515         * tui/tui-win.h: Rename include guard.
 516         * tui/tui-stack.h: Rename include guard.
 517         * tui/tui-source.h: Rename include guard.
 518         * tui/tui-regs.h: Rename include guard.
 519         * tui/tui-out.h: Rename include guard.
 520         * tui/tui-layout.h: Rename include guard.
 521         * tui/tui-io.h: Rename include guard.
 522         * tui/tui-hooks.h: Rename include guard.
 523         * tui/tui-file.h: Rename include guard.
 524         * tui/tui-disasm.h: Rename include guard.
 525         * tui/tui-data.h: Rename include guard.
 526         * tui/tui-command.h: Rename include guard.
 527         * tic6x-tdep.h: Add include guard.
 528         * target/waitstatus.h: Rename include guard.
 529         * target/wait.h: Rename include guard.
 530         * target/target.h: Rename include guard.
 531         * target/resume.h: Rename include guard.
 532         * target-float.h: Rename include guard.
 533         * stabsread.h: Add include guard.
 534         * rs6000-tdep.h: Add include guard.
 535         * riscv-fbsd-tdep.h: Add include guard.
 536         * regformats/regdef.h: Rename include guard.
 537         * record.h: Rename include guard.
 538         * python/python.h: Rename include guard.
 539         * python/python-internal.h: Rename include guard.
 540         * python/py-stopevent.h: Rename include guard.
 541         * python/py-ref.h: Rename include guard.
 542         * python/py-record.h: Rename include guard.
 543         * python/py-record-full.h: Rename include guard.
 544         * python/py-record-btrace.h: Rename include guard.
 545         * python/py-instruction.h: Rename include guard.
 546         * python/py-events.h: Rename include guard.
 547         * python/py-event.h: Rename include guard.
 548         * procfs.h: Add include guard.
 549         * proc-utils.h: Add include guard.
 550         * p-lang.h: Add include guard.
 551         * or1k-tdep.h: Rename include guard.
 552         * observable.h: Rename include guard.
 553         * nto-tdep.h: Rename include guard.
 554         * nat/x86-linux.h: Rename include guard.
 555         * nat/x86-linux-dregs.h: Rename include guard.
 556         * nat/x86-gcc-cpuid.h: Add include guard.
 557         * nat/x86-dregs.h: Rename include guard.
 558         * nat/x86-cpuid.h: Rename include guard.
 559         * nat/ppc-linux.h: Rename include guard.
 560         * nat/mips-linux-watch.h: Rename include guard.
 561         * nat/linux-waitpid.h: Rename include guard.
 562         * nat/linux-ptrace.h: Rename include guard.
 563         * nat/linux-procfs.h: Rename include guard.
 564         * nat/linux-osdata.h: Rename include guard.
 565         * nat/linux-nat.h: Rename include guard.
 566         * nat/linux-namespaces.h: Rename include guard.
 567         * nat/linux-btrace.h: Rename include guard.
 568         * nat/glibc_thread_db.h: Rename include guard.
 569         * nat/gdb_thread_db.h: Rename include guard.
 570         * nat/gdb_ptrace.h: Rename include guard.
 571         * nat/fork-inferior.h: Rename include guard.
 572         * nat/amd64-linux-siginfo.h: Rename include guard.
 573         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 574         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 575         * nat/aarch64-linux.h: Rename include guard.
 576         * nat/aarch64-linux-hw-point.h: Rename include guard.
 577         * mn10300-tdep.h: Add include guard.
 578         * mips-linux-tdep.h: Add include guard.
 579         * mi/mi-parse.h: Rename include guard.
 580         * mi/mi-out.h: Rename include guard.
 581         * mi/mi-main.h: Rename include guard.
 582         * mi/mi-interp.h: Rename include guard.
 583         * mi/mi-getopt.h: Rename include guard.
 584         * mi/mi-console.h: Rename include guard.
 585         * mi/mi-common.h: Rename include guard.
 586         * mi/mi-cmds.h: Rename include guard.
 587         * mi/mi-cmd-break.h: Rename include guard.
 588         * m2-lang.h: Add include guard.
 589         * location.h: Rename include guard.
 590         * linux-record.h: Rename include guard.
 591         * linux-nat.h: Add include guard.
 592         * linux-fork.h: Add include guard.
 593         * i386-darwin-tdep.h: Rename include guard.
 594         * hppa-linux-offsets.h: Add include guard.
 595         * guile/guile.h: Rename include guard.
 596         * guile/guile-internal.h: Rename include guard.
 597         * gnu-nat.h: Rename include guard.
 598         * gdb-stabs.h: Rename include guard.
 599         * frv-tdep.h: Add include guard.
 600         * f-lang.h: Add include guard.
 601         * event-loop.h: Add include guard.
 602         * darwin-nat.h: Rename include guard.
 603         * cp-abi.h: Rename include guard.
 604         * config/sparc/nm-sol2.h: Rename include guard.
 605         * config/nm-nto.h: Rename include guard.
 606         * config/nm-linux.h: Add include guard.
 607         * config/i386/nm-i386gnu.h: Rename include guard.
 608         * config/djgpp/nl_types.h: Rename include guard.
 609         * config/djgpp/langinfo.h: Rename include guard.
 610         * compile/gcc-cp-plugin.h: Add include guard.
 611         * compile/gcc-c-plugin.h: Add include guard.
 612         * compile/compile.h: Rename include guard.
 613         * compile/compile-object-run.h: Rename include guard.
 614         * compile/compile-object-load.h: Rename include guard.
 615         * compile/compile-internal.h: Rename include guard.
 616         * compile/compile-cplus.h: Rename include guard.
 617         * compile/compile-c.h: Rename include guard.
 618         * common/xml-utils.h: Rename include guard.
 619         * common/x86-xstate.h: Rename include guard.
 620         * common/version.h: Rename include guard.
 621         * common/vec.h: Rename include guard.
 622         * common/tdesc.h: Rename include guard.
 623         * common/selftest.h: Rename include guard.
 624         * common/scoped_restore.h: Rename include guard.
 625         * common/scoped_mmap.h: Rename include guard.
 626         * common/scoped_fd.h: Rename include guard.
 627         * common/safe-iterator.h: Rename include guard.
 628         * common/run-time-clock.h: Rename include guard.
 629         * common/refcounted-object.h: Rename include guard.
 630         * common/queue.h: Rename include guard.
 631         * common/ptid.h: Rename include guard.
 632         * common/print-utils.h: Rename include guard.
 633         * common/preprocessor.h: Rename include guard.
 634         * common/pathstuff.h: Rename include guard.
 635         * common/observable.h: Rename include guard.
 636         * common/netstuff.h: Rename include guard.
 637         * common/job-control.h: Rename include guard.
 638         * common/host-defs.h: Rename include guard.
 639         * common/gdb_wait.h: Rename include guard.
 640         * common/gdb_vecs.h: Rename include guard.
 641         * common/gdb_unlinker.h: Rename include guard.
 642         * common/gdb_unique_ptr.h: Rename include guard.
 643         * common/gdb_tilde_expand.h: Rename include guard.
 644         * common/gdb_sys_time.h: Rename include guard.
 645         * common/gdb_string_view.h: Rename include guard.
 646         * common/gdb_splay_tree.h: Rename include guard.
 647         * common/gdb_setjmp.h: Rename include guard.
 648         * common/gdb_ref_ptr.h: Rename include guard.
 649         * common/gdb_optional.h: Rename include guard.
 650         * common/gdb_locale.h: Rename include guard.
 651         * common/gdb_assert.h: Rename include guard.
 652         * common/filtered-iterator.h: Rename include guard.
 653         * common/filestuff.h: Rename include guard.
 654         * common/fileio.h: Rename include guard.
 655         * common/environ.h: Rename include guard.
 656         * common/common-utils.h: Rename include guard.
 657         * common/common-types.h: Rename include guard.
 658         * common/common-regcache.h: Rename include guard.
 659         * common/common-inferior.h: Rename include guard.
 660         * common/common-gdbthread.h: Rename include guard.
 661         * common/common-exceptions.h: Rename include guard.
 662         * common/common-defs.h: Rename include guard.
 663         * common/common-debug.h: Rename include guard.
 664         * common/cleanups.h: Rename include guard.
 665         * common/buffer.h: Rename include guard.
 666         * common/btrace-common.h: Rename include guard.
 667         * common/break-common.h: Rename include guard.
 668         * cli/cli-utils.h: Rename include guard.
 669         * cli/cli-style.h: Rename include guard.
 670         * cli/cli-setshow.h: Rename include guard.
 671         * cli/cli-script.h: Rename include guard.
 672         * cli/cli-interp.h: Rename include guard.
 673         * cli/cli-decode.h: Rename include guard.
 674         * cli/cli-cmds.h: Rename include guard.
 675         * charset-list.h: Add include guard.
 676         * buildsym-legacy.h: Rename include guard.
 677         * bfin-tdep.h: Add include guard.
 678         * ax.h: Rename include guard.
 679         * arm-linux-tdep.h: Add include guard.
 680         * arm-fbsd-tdep.h: Add include guard.
 681         * arch/xtensa.h: Rename include guard.
 682         * arch/tic6x.h: Add include guard.
 683         * arch/i386.h: Add include guard.
 684         * arch/arm.h: Rename include guard.
 685         * arch/arm-linux.h: Rename include guard.
 686         * arch/arm-get-next-pcs.h: Rename include guard.
 687         * arch/amd64.h: Add include guard.
 688         * arch/aarch64-insn.h: Rename include guard.
 689         * arch-utils.h: Rename include guard.
 690         * annotate.h: Add include guard.
 691         * amd64-darwin-tdep.h: Rename include guard.
 692         * aarch64-linux-tdep.h: Add include guard.
 693         * aarch64-fbsd-tdep.h: Add include guard.
 694         * aarch32-linux-nat.h: Add include guard.
 695
 696 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 697
 698         * macrotab.c (macro_define_internal): New function that
 699         factorizes macro_define_object_internal and macro_define_function
 700         code.
 701         (macro_define_object_internal): Use macro_define_internal.
 702         (macro_define_function): Likewise.
 703
 704 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 705
 706         * macrocmd.c (extract_identifier): Return
 707         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 708         callers.
 709
 710 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 711
 712         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 713
 714 2019-02-05  Tom Tromey  <tom@tromey.com>
 715
 716         * target.c (target_stack::unpush): Move assertion earlier.
 717
 718 2019-01-30  Tom Tromey  <tom@tromey.com>
 719
 720         PR python/23615:
 721         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 722         (gdbpy_parse_and_eval): Likewise.
 723         * python/python-internal.h (gdbpy_allow_threads): New class.
 724
 725 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 726
 727         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 728         (aarch64_fbsd_fpregmap): Move earlier.
 729         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 730         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 731         instead of individual calls to trad_frame_set_reg_addr.
 732         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 733         earlier.
 734         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 735         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 736         instead of individual calls to trad_frame_set_reg_addr.
 737
 738 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 739
 740         * CONTRIBUTE: Replace contribution list with wiki link.
 741
 742 2019-01-25  Tom Tromey  <tom@tromey.com>
 743
 744         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 745
 746 2019-01-25  Tom Tromey  <tom@tromey.com>
 747
 748         * xtensa-linux-nat.c: Fix common/ includes.
 749         * xml-support.h: Fix common/ includes.
 750         * xml-support.c: Fix common/ includes.
 751         * x86-linux-nat.c: Fix common/ includes.
 752         * windows-nat.c: Fix common/ includes.
 753         * varobj.h: Fix common/ includes.
 754         * varobj.c: Fix common/ includes.
 755         * value.c: Fix common/ includes.
 756         * valops.c: Fix common/ includes.
 757         * utils.c: Fix common/ includes.
 758         * unittests/xml-utils-selftests.c: Fix common/ includes.
 759         * unittests/utils-selftests.c: Fix common/ includes.
 760         * unittests/unpack-selftests.c: Fix common/ includes.
 761         * unittests/tracepoint-selftests.c: Fix common/ includes.
 762         * unittests/style-selftests.c: Fix common/ includes.
 763         * unittests/string_view-selftests.c: Fix common/ includes.
 764         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 765         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 766         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 767         * unittests/rsp-low-selftests.c: Fix common/ includes.
 768         * unittests/parse-connection-spec-selftests.c: Fix common/
 769         includes.
 770         * unittests/optional-selftests.c: Fix common/ includes.
 771         * unittests/offset-type-selftests.c: Fix common/ includes.
 772         * unittests/observable-selftests.c: Fix common/ includes.
 773         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 774         * unittests/memrange-selftests.c: Fix common/ includes.
 775         * unittests/memory-map-selftests.c: Fix common/ includes.
 776         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 777         * unittests/function-view-selftests.c: Fix common/ includes.
 778         * unittests/environ-selftests.c: Fix common/ includes.
 779         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 780         * unittests/common-utils-selftests.c: Fix common/ includes.
 781         * unittests/cli-utils-selftests.c: Fix common/ includes.
 782         * unittests/array-view-selftests.c: Fix common/ includes.
 783         * ui-file.c: Fix common/ includes.
 784         * tui/tui-io.c: Fix common/ includes.
 785         * tracepoint.h: Fix common/ includes.
 786         * tracepoint.c: Fix common/ includes.
 787         * tracefile-tfile.c: Fix common/ includes.
 788         * top.h: Fix common/ includes.
 789         * top.c: Fix common/ includes.
 790         * thread.c: Fix common/ includes.
 791         * target/waitstatus.h: Fix common/ includes.
 792         * target/waitstatus.c: Fix common/ includes.
 793         * target.h: Fix common/ includes.
 794         * target.c: Fix common/ includes.
 795         * target-memory.c: Fix common/ includes.
 796         * target-descriptions.c: Fix common/ includes.
 797         * symtab.h: Fix common/ includes.
 798         * symfile.c: Fix common/ includes.
 799         * stap-probe.c: Fix common/ includes.
 800         * spu-linux-nat.c: Fix common/ includes.
 801         * sparc-nat.c: Fix common/ includes.
 802         * source.c: Fix common/ includes.
 803         * solib.c: Fix common/ includes.
 804         * solib-target.c: Fix common/ includes.
 805         * ser-unix.c: Fix common/ includes.
 806         * ser-tcp.c: Fix common/ includes.
 807         * ser-pipe.c: Fix common/ includes.
 808         * ser-base.c: Fix common/ includes.
 809         * selftest-arch.c: Fix common/ includes.
 810         * s12z-tdep.c: Fix common/ includes.
 811         * rust-exp.y: Fix common/ includes.
 812         * rs6000-aix-tdep.c: Fix common/ includes.
 813         * riscv-tdep.c: Fix common/ includes.
 814         * remote.c: Fix common/ includes.
 815         * remote-notif.h: Fix common/ includes.
 816         * remote-fileio.h: Fix common/ includes.
 817         * remote-fileio.c: Fix common/ includes.
 818         * regcache.h: Fix common/ includes.
 819         * regcache.c: Fix common/ includes.
 820         * record-btrace.c: Fix common/ includes.
 821         * python/python.c: Fix common/ includes.
 822         * python/py-type.c: Fix common/ includes.
 823         * python/py-inferior.c: Fix common/ includes.
 824         * progspace.h: Fix common/ includes.
 825         * producer.c: Fix common/ includes.
 826         * procfs.c: Fix common/ includes.
 827         * proc-api.c: Fix common/ includes.
 828         * printcmd.c: Fix common/ includes.
 829         * ppc-linux-nat.c: Fix common/ includes.
 830         * parser-defs.h: Fix common/ includes.
 831         * osdata.c: Fix common/ includes.
 832         * obsd-nat.c: Fix common/ includes.
 833         * nat/x86-linux.c: Fix common/ includes.
 834         * nat/x86-linux-dregs.c: Fix common/ includes.
 835         * nat/x86-dregs.h: Fix common/ includes.
 836         * nat/x86-dregs.c: Fix common/ includes.
 837         * nat/ppc-linux.c: Fix common/ includes.
 838         * nat/mips-linux-watch.h: Fix common/ includes.
 839         * nat/mips-linux-watch.c: Fix common/ includes.
 840         * nat/linux-waitpid.c: Fix common/ includes.
 841         * nat/linux-ptrace.h: Fix common/ includes.
 842         * nat/linux-ptrace.c: Fix common/ includes.
 843         * nat/linux-procfs.c: Fix common/ includes.
 844         * nat/linux-personality.c: Fix common/ includes.
 845         * nat/linux-osdata.c: Fix common/ includes.
 846         * nat/linux-namespaces.c: Fix common/ includes.
 847         * nat/linux-btrace.h: Fix common/ includes.
 848         * nat/linux-btrace.c: Fix common/ includes.
 849         * nat/fork-inferior.c: Fix common/ includes.
 850         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 851         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 852         * nat/aarch64-linux.c: Fix common/ includes.
 853         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 854         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 855         * namespace.h: Fix common/ includes.
 856         * mips-linux-tdep.c: Fix common/ includes.
 857         * minsyms.c: Fix common/ includes.
 858         * mi/mi-parse.h: Fix common/ includes.
 859         * mi/mi-main.c: Fix common/ includes.
 860         * mi/mi-cmd-env.c: Fix common/ includes.
 861         * memrange.h: Fix common/ includes.
 862         * memattr.c: Fix common/ includes.
 863         * maint.h: Fix common/ includes.
 864         * maint.c: Fix common/ includes.
 865         * main.c: Fix common/ includes.
 866         * machoread.c: Fix common/ includes.
 867         * location.c: Fix common/ includes.
 868         * linux-thread-db.c: Fix common/ includes.
 869         * linux-nat.c: Fix common/ includes.
 870         * linux-fork.c: Fix common/ includes.
 871         * inline-frame.c: Fix common/ includes.
 872         * infrun.c: Fix common/ includes.
 873         * inflow.c: Fix common/ includes.
 874         * inferior.h: Fix common/ includes.
 875         * inferior.c: Fix common/ includes.
 876         * infcmd.c: Fix common/ includes.
 877         * inf-ptrace.c: Fix common/ includes.
 878         * inf-child.c: Fix common/ includes.
 879         * ia64-linux-nat.c: Fix common/ includes.
 880         * i387-tdep.c: Fix common/ includes.
 881         * i386-tdep.c: Fix common/ includes.
 882         * i386-linux-tdep.c: Fix common/ includes.
 883         * i386-linux-nat.c: Fix common/ includes.
 884         * i386-go32-tdep.c: Fix common/ includes.
 885         * i386-fbsd-tdep.c: Fix common/ includes.
 886         * i386-fbsd-nat.c: Fix common/ includes.
 887         * guile/scm-type.c: Fix common/ includes.
 888         * guile/guile.c: Fix common/ includes.
 889         * go32-nat.c: Fix common/ includes.
 890         * gnu-nat.c: Fix common/ includes.
 891         * gdbthread.h: Fix common/ includes.
 892         * gdbarch-selftests.c: Fix common/ includes.
 893         * gdb_usleep.c: Fix common/ includes.
 894         * gdb_select.h: Fix common/ includes.
 895         * gdb_bfd.c: Fix common/ includes.
 896         * gcore.c: Fix common/ includes.
 897         * fork-child.c: Fix common/ includes.
 898         * findvar.c: Fix common/ includes.
 899         * fbsd-nat.c: Fix common/ includes.
 900         * event-top.c: Fix common/ includes.
 901         * event-loop.c: Fix common/ includes.
 902         * dwarf2read.c: Fix common/ includes.
 903         * dwarf2loc.c: Fix common/ includes.
 904         * dwarf2-frame.c: Fix common/ includes.
 905         * dwarf-index-cache.c: Fix common/ includes.
 906         * dtrace-probe.c: Fix common/ includes.
 907         * disasm-selftests.c: Fix common/ includes.
 908         * defs.h: Fix common/ includes.
 909         * csky-tdep.c: Fix common/ includes.
 910         * cp-valprint.c: Fix common/ includes.
 911         * cp-support.h: Fix common/ includes.
 912         * cp-support.c: Fix common/ includes.
 913         * corelow.c: Fix common/ includes.
 914         * completer.h: Fix common/ includes.
 915         * completer.c: Fix common/ includes.
 916         * compile/compile.c: Fix common/ includes.
 917         * compile/compile-loc2c.c: Fix common/ includes.
 918         * compile/compile-cplus-types.c: Fix common/ includes.
 919         * compile/compile-cplus-symbols.c: Fix common/ includes.
 920         * command.h: Fix common/ includes.
 921         * cli/cli-dump.c: Fix common/ includes.
 922         * cli/cli-cmds.c: Fix common/ includes.
 923         * charset.c: Fix common/ includes.
 924         * build-id.c: Fix common/ includes.
 925         * btrace.h: Fix common/ includes.
 926         * btrace.c: Fix common/ includes.
 927         * breakpoint.h: Fix common/ includes.
 928         * breakpoint.c: Fix common/ includes.
 929         * ax.h:
 930         (enum agent_op): Fix common/ includes.
 931         * ax-general.c (struct aop_map): Fix common/ includes.
 932         * ax-gdb.c: Fix common/ includes.
 933         * auxv.c: Fix common/ includes.
 934         * auto-load.c: Fix common/ includes.
 935         * arm-tdep.c: Fix common/ includes.
 936         * arch/riscv.c: Fix common/ includes.
 937         * arch/ppc-linux-common.c: Fix common/ includes.
 938         * arch/i386.c: Fix common/ includes.
 939         * arch/arm.c: Fix common/ includes.
 940         * arch/arm-linux.c: Fix common/ includes.
 941         * arch/arm-get-next-pcs.c: Fix common/ includes.
 942         * arch/amd64.c: Fix common/ includes.
 943         * arch/aarch64.c: Fix common/ includes.
 944         * arch/aarch64-insn.c: Fix common/ includes.
 945         * arch-utils.c: Fix common/ includes.
 946         * amd64-windows-tdep.c: Fix common/ includes.
 947         * amd64-tdep.c: Fix common/ includes.
 948         * amd64-sol2-tdep.c: Fix common/ includes.
 949         * amd64-obsd-tdep.c: Fix common/ includes.
 950         * amd64-nbsd-tdep.c: Fix common/ includes.
 951         * amd64-linux-tdep.c: Fix common/ includes.
 952         * amd64-linux-nat.c: Fix common/ includes.
 953         * amd64-fbsd-tdep.c: Fix common/ includes.
 954         * amd64-fbsd-nat.c: Fix common/ includes.
 955         * amd64-dicos-tdep.c: Fix common/ includes.
 956         * amd64-darwin-tdep.c: Fix common/ includes.
 957         * agent.c: Fix common/ includes.
 958         * ada-lang.h: Fix common/ includes.
 959         * ada-lang.c: Fix common/ includes.
 960         * aarch64-tdep.c: Fix common/ includes.
 961
 962 2019-01-25  Tom Tromey  <tom@tromey.com>
 963
 964         * common/create-version.sh: Use common/version.h.
 965
 966 2019-01-24  Pedro Alves  <palves@redhat.com>
 967
 968         * infrun.c (signal_stop, signal_print, signal_program)
 969         (signal_catch, signal_pass): Now arrays instead of pointers.
 970         (update_signals_program_target, do_target_resume)
 971         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 972         * linux-nat.c (linux_nat_target::pass_signals)
 973         (linux_nat_target::create_inferior, linux_nat_target::attach):
 974         Adjust.
 975         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 976         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 977         * procfs.c (procfs_target::pass_signals): Adjust.
 978         * record-full.c (record_full_target::resume): Adjust.
 979         * remote.c (remote_target::pass_signals)
 980         (remote_target::program_signals): Adjust.
 981         * target-debug.h (target_debug_print_signals): Now takes a
 982         gdb::array_view as parameter.  Adjust.
 983         * target.h (target_ops) <pass_signals, program_signals>: Replace
 984         pointer and length parameters with gdb::array_view.
 985         (target_pass_signals, target_program_signals): Likewise.
 986         * target-delegates.c: Regenerate.
 987
 988 2019-01-24  Pedro Alves  <palves@redhat.com>
 989
 990         * common/forward-scope-exit.h
 991         (forward_scope_exit::forward_scope_exit): Pass arguments to
 992         m_bind_function directly, instead of creating a std::bind and
 993         copying that.
 994
 995 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 996
 997         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 998         for static members.
 999         (pass_in_v_vfp_candidate): Likewise.
1000
1001 2019-01-23  Tom Tromey  <tom@tromey.com>
1002             Pedro Alves  <palves@redhat.com>
1003
1004         * regcache.c (class regcache_invalidator): Remove.
1005         (regcache::raw_write): Use make_scope_exit.
1006
1007 2019-01-23  Tom Tromey  <tom@tromey.com>
1008
1009         * ui-out.h (class ui_out_emit_type): Update comment.
1010
1011 2019-01-23  Tom Tromey  <tom@tromey.com>
1012
1013         * infrun.c (fetch_inferior_event): Update comment.
1014
1015 2019-01-23  Tom Tromey  <tom@tromey.com>
1016             Pedro Alves  <palves@redhat.com>
1017
1018         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1019         parameter.
1020         (fetch_inferior_event): Use SCOPE_EXIT.
1021
1022
1023 2019-01-23  Tom Tromey  <tom@tromey.com>
1024             Pedro Alves  <palves@redhat.com>
1025
1026         * infrun.c (disable_thread_events): Delete.
1027         (stop_all_threads): Use SCOPE_EXIT.
1028
1029 2019-01-23  Tom Tromey  <tom@tromey.com>
1030             Pedro Alves  <palves@redhat.com>
1031
1032         * symfile.c: Include forward-scope-exit.h.
1033         (clear_symtab_users_cleanup): Replace forward declaration with
1034         a FORWARD_SCOPE_EXIT.
1035         (syms_from_objfile_1): Use the forward_scope_exit and
1036         gdb::optional instead of cleanup_function.
1037         (reread_symbols): Use the forward_scope_exit instead of
1038         cleanup_function.
1039         (clear_symtab_users_cleanup): Remove function.
1040
1041 2019-01-23  Tom Tromey  <tom@tromey.com>
1042             Pedro Alves  <palves@redhat.com>
1043
1044         * linux-nat.c: Include scope-exit.h.
1045         (cleanup_target_stop): Remove.
1046         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1047         SCOPE_EXIT.
1048
1049 2019-01-23  Tom Tromey  <tom@tromey.com>
1050             Pedro Alves  <palves@redhat.com>
1051
1052         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1053         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1054
1055 2019-01-23  Tom Tromey  <tom@tromey.com>
1056             Andrew Burgess  <andrew.burgess@embecosm.com>
1057             Pedro Alves  <palves@redhat.com>
1058
1059         * infrun.c (fetch_inferior_event): Use scope_exit.
1060         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1061         * top.c (execute_command): Use scope_exit.
1062         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1063         * utils.c (do_bpstat_clear_actions_cleanup)
1064         (make_bpstat_clear_actions_cleanup): Remove.
1065
1066 2019-01-23  Tom Tromey  <tom@tromey.com>
1067             Pedro Alves  <palves@redhat.com>
1068
1069         * infrun.c: Include "common/scope-exit.h"
1070         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1071         (wait_for_inferior): Use SCOPE_EXIT.
1072         (fetch_inferior_event): Use scope_exit.
1073
1074 2019-01-23  Tom Tromey  <tom@tromey.com>
1075             Pedro Alves  <palves@redhat.com>
1076
1077         * breakpoint.c (create_breakpoint): Remove cleanup.
1078
1079 2019-01-23  Tom Tromey  <tom@tromey.com>
1080             Andrew Burgess  <andrew.burgess@embecosm.com>
1081             Pedro Alves  <palves@redhat.com>
1082
1083 2019-01-23  Pedro Alves  <palves@redhat.com>
1084
1085         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1086
1087 2019-01-23  Pedro Alves  <palves@redhat.com>
1088             Andrew Burgess  <andrew.burgess@embecosm.com>
1089
1090         * gdbthread.h: Include "common/forward-scope-exit.h".
1091         (scoped_finish_thread_state): Redefine custom class in terms of
1092         forward_scope_exit.
1093
1094 2019-01-23  Pedro Alves  <palves@redhat.com>
1095             Andrew Burgess  <andrew.burgess@embecosm.com>
1096
1097         * common/forward-scope-exit.h: New file.
1098
1099 2019-01-23  Pedro Alves  <palves@redhat.com>
1100             Andrew Burgess  <andrew.burgess@embecosm.com>
1101             Tom Tromey  <tom@tromey.com>
1102
1103         * common/scope-exit.h: New file.
1104
1105 2019-01-23  Pedro Alves  <palves@redhat.com>
1106
1107         * common/preprocessor.h (ESC): Rename to ...
1108         (ESC_PARENS): ... this.
1109         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1110         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1111
1112 2019-01-23  Tom Tromey  <tom@tromey.com>
1113
1114         * language.h (class scoped_switch_to_sym_language_if_auto):
1115         Initialize m_lang in both cases.
1116
1117 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1118
1119         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1120         with XCNEW.
1121
1122 2019-01-22  Tom Tromey  <tom@tromey.com>
1123
1124         * corelow.c: Do not include sys/file.h.
1125
1126 2019-01-22  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-wingeneral.h: Include gdb_curses.h.
1129
1130 2019-01-22  Tom Tromey  <tom@tromey.com>
1131
1132         * source-cache.h (class source_cache) <get_source_lines,
1133         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1134
1135 2019-01-22  Tom Tromey  <tom@tromey.com>
1136
1137         * remote-fileio.h (struct remote_target): Declare.
1138
1139 2019-01-22  Tom Tromey  <tom@tromey.com>
1140
1141         * python/py-arch.c: Do not include py-ref.h.
1142         * python/py-bpevent.c: Do not include py-ref.h.
1143         * python/py-cmd.c: Do not include py-ref.h.
1144         * python/py-continueevent.c: Do not include py-ref.h.
1145         * python/py-event.h: Do not include py-ref.h.
1146         * python/py-evtregistry.c: Do not include py-ref.h.
1147         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1148         * python/py-frame.c: Do not include py-ref.h.
1149         * python/py-framefilter.c: Do not include py-ref.h.
1150         * python/py-function.c: Do not include py-ref.h.
1151         * python/py-infevents.c: Do not include py-ref.h.
1152         * python/py-linetable.c: Do not include py-ref.h.
1153         * python/py-objfile.c: Do not include py-ref.h.
1154         * python/py-param.c: Do not include py-ref.h.
1155         * python/py-prettyprint.c: Do not include py-ref.h.
1156         * python/py-progspace.c: Do not include py-ref.h.
1157         * python/py-symbol.c: Do not include py-ref.h.
1158         * python/py-symtab.c: Do not include py-ref.h.
1159         * python/py-type.c: Do not include py-ref.h.
1160         * python/py-unwind.c: Do not include py-ref.h.
1161         * python/py-utils.c: Do not include py-ref.h.
1162         * python/py-value.c: Do not include py-ref.h.
1163         * python/py-varobj.c: Do not include py-ref.h.
1164         * python/py-xmethods.c: Do not include py-ref.h.
1165         * python/python.c: Do not include py-ref.h.
1166         * varobj.c: Do not include py-ref.h.
1167
1168 2019-01-22  Tom Tromey  <tom@tromey.com>
1169
1170         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1171         keyword for bcache.
1172
1173 2019-01-22  Tom Tromey  <tom@tromey.com>
1174
1175         * compile/compile-cplus-types.c: Remove a comment by #include.
1176
1177 2019-01-22  Tom Tromey  <tom@tromey.com>
1178
1179         * compile/gcc-c-plugin.h: Include compile-internal.h.
1180
1181 2019-01-22  Tom Tromey  <tom@tromey.com>
1182
1183         * stabsread.c (EXTERN): Do not define.
1184         (symnum, next_symbol_text_func, processing_gcc_compilation)
1185         (within_function, global_sym_chain, global_stabs)
1186         (previous_stab_code, this_object_header_files)
1187         (n_this_object_header_files)
1188         (n_allocated_this_object_header_files): Define.
1189         * stabsread.h (EXTERN): Never define.  Use "extern".
1190
1191 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1192
1193         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1194         history_value.
1195
1196 2019-01-21  Tom Tromey  <tom@tromey.com>
1197
1198         * ui-out.c: Fix includes.
1199         * tui/tui-source.c: Fix includes.
1200         * target.c: Fix includes.
1201         * remote.c: Fix includes.
1202         * regcache.c: Fix includes.
1203         * python/py-block.c: Fix includes.
1204         * printcmd.c: Fix includes.
1205         * or1k-tdep.c: Fix includes.
1206         * mi/mi-main.c: Fix includes.
1207         * m32r-tdep.c: Fix includes.
1208         * csky-tdep.c: Fix includes.
1209         * compile/compile-cplus-types.c: Fix includes.
1210         * cli/cli-interp.c: Fix includes.
1211
1212 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1213
1214         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1215         for padding.
1216
1217 2019-01-16  Tom Tromey  <tom@tromey.com>
1218
1219         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1220         earlier.
1221         (struct objfile) <msymbols_range>: Move from top level.
1222         <msymbols>: New method.
1223         (class objfile_msymbols): Remove.
1224         * symtab.c (default_collect_symbol_completion_matches_break_on):
1225         Update.
1226         * symmisc.c (dump_msymbols): Update.
1227         * stabsread.c (scan_file_globals): Update.
1228         * objc-lang.c (info_selectors_command, info_classes_command)
1229         (find_methods): Update.
1230         * minsyms.c (find_solib_trampoline_target): Update.
1231         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1232         * coffread.c (coff_symfile_read): Update.
1233         * ada-lang.c (ada_lookup_simple_minsym)
1234         (ada_collect_symbol_completion_matches): Update.
1235
1236 2019-01-16  Tom Tromey  <tom@tromey.com>
1237
1238         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1239         type.  Remove no-argument constructor.
1240         <iterator::operator++>: Simplify.
1241         <begin>: Update.
1242         <end>: Use minimal_symbol_count.
1243
1244 2019-01-16  Tom Tromey  <tom@tromey.com>
1245
1246         * objfiles.h (struct objfile) <psymtabs>: New method.
1247         (class objfile_psymtabs): Remove.
1248         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1249         typedef.
1250         <range>: New method.
1251         (require_partial_symbols): Change return type.
1252         * psymtab.c (require_partial_symbols)
1253         (psym_expand_symtabs_matching): Update.
1254         * mdebugread.c (parse_partial_symbols): Update.
1255         * dbxread.c (dbx_end_psymtab): Update.
1256
1257 2019-01-15  Tom Tromey  <tom@tromey.com>
1258
1259         * symtab.c (lookup_objfile_from_block)
1260         (lookup_symbol_in_objfile_symtabs)
1261         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1262         (find_line_symtab, info_sources_command)
1263         (default_collect_symbol_completion_matches_break_on)
1264         (make_source_files_completion_list): Update.
1265         * symmisc.c (print_objfile_statistics, dump_objfile)
1266         (maintenance_print_symbols, maintenance_info_symtabs)
1267         (maintenance_check_symtabs, maintenance_info_line_tables):
1268         Update.
1269         * source.c (select_source_symtab)
1270         (forget_cached_source_info_for_objfile): Update.
1271         * objfiles.h (class objfile_compunits): Remove.
1272         (struct objfile) <compunits_range>: New typedef.
1273         (compunits): New method.
1274         * objfiles.c (objfile_relocate1): Update.
1275         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1276         * maint.c (count_symtabs_and_blocks): Update.
1277         * linespec.c (iterate_over_all_matching_symtabs): Update.
1278         * cp-support.c (add_symbol_overload_list_qualified): Update.
1279         * coffread.c (coff_symtab_read): Update.
1280         * ada-lang.c (add_nonlocal_symbols)
1281         (ada_collect_symbol_completion_matches)
1282         (ada_add_global_exceptions): Update.
1283
1284 2019-01-15  Tom Tromey  <tom@tromey.com>
1285
1286         * progspace.h (program_space) <objfiles_safe_range>: New
1287         typedef.
1288         <objfiles_safe>: New method.
1289         * objfiles.h (class all_objfiles_safe): Remove.
1290         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1291         * jit.c (jit_inferior_exit_hook): Update.
1292
1293 2019-01-17  Tom Tromey  <tom@tromey.com>
1294
1295         * progspace.h (program_space) <objfiles_range>: New typedef.
1296         <objfiles>: New method.
1297         <objfiles_head>: Rename from objfiles.
1298         (object_files): Update.
1299         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1300         * guile/scm-pretty-print.c
1301         (ppscm_find_pretty_printer_from_objfiles): Update.
1302         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1303         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1304         Update.
1305         * python/py-progspace.c (pspy_get_objfiles): Update.
1306         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1307         Update.
1308         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1309         (objfpy_lookup_objfile_by_build_id): Update.
1310         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1311         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1312         Update.
1313         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1314         (expand_symtab_containing_pc, lookup_objfile_from_block)
1315         (lookup_static_symbol, basic_lookup_transparent_type)
1316         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1317         (find_line_symtab, info_sources_command)
1318         (default_collect_symbol_completion_matches_break_on)
1319         (make_source_files_completion_list, find_main_name): Update.
1320         * symmisc.c (print_symbol_bcache_statistics)
1321         (print_objfile_statistics, maintenance_print_symbols)
1322         (maintenance_print_msymbols, maintenance_print_objfiles)
1323         (maintenance_info_symtabs, maintenance_check_symtabs)
1324         (maintenance_expand_symtabs, maintenance_info_line_tables):
1325         Update.
1326         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1327         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1328         (map_overlay_command, unmap_overlay_command)
1329         (simple_overlay_update, expand_symtabs_matching)
1330         (map_symbol_filenames): Update.
1331         * symfile-debug.c (set_debug_symfile): Update.
1332         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1333         Update.
1334         * source.c (select_source_symtab, forget_cached_source_info):
1335         Update.
1336         * solib.c (solib_read_symbols): Update.
1337         * solib-spu.c (append_ocl_sos): Update.
1338         * psymtab.c (maintenance_print_psymbols)
1339         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1340         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1341         * printcmd.c (info_symbol_command): Update.
1342         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1343         Update.
1344         * objfiles.h (class all_objfiles): Remove.
1345         * objfiles.c (have_partial_symbols, have_full_symbols)
1346         (have_minimal_symbols, qsort_cmp, update_section_map)
1347         (shared_objfile_contains_address_p)
1348         (default_iterate_over_objfiles_in_search_order): Update.
1349         * objc-lang.c (info_selectors_command, info_classes_command)
1350         (find_methods): Update.
1351         * minsyms.c (find_solib_trampoline_target): Update.
1352         * maint.c (maintenance_info_sections)
1353         (maintenance_translate_address, count_symtabs_and_blocks):
1354         Update.
1355         * main.c (captured_main_1): Update.
1356         * linux-thread-db.c (try_thread_db_load_from_pdir)
1357         (has_libpthread): Update.
1358         * linespec.c (iterate_over_all_matching_symtabs)
1359         (search_minsyms_for_name): Update.
1360         * jit.c (jit_find_objf_with_entry_addr): Update.
1361         * hppa-tdep.c (find_unwind_entry)
1362         (hppa_lookup_stub_minimal_symbol): Update.
1363         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1364         Update.
1365         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1366         (elf_gnu_ifunc_resolve_by_got): Update.
1367         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1368         * dwarf-index-write.c (save_gdb_index_command): Update.
1369         * cp-support.c (add_symbol_overload_list_qualified): Update.
1370         * breakpoint.c (create_overlay_event_breakpoint)
1371         (create_longjmp_master_breakpoint)
1372         (create_std_terminate_master_breakpoint)
1373         (create_exception_master_breakpoint): Update.
1374         * blockframe.c (find_pc_partial_function): Update.
1375         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1376         (ada_collect_symbol_completion_matches)
1377         (ada_add_global_exceptions): Update.
1378
1379 2019-01-17  Tom Tromey  <tom@tromey.com>
1380
1381         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1382         declare VEC.
1383         (solib_target_parse_libraries): Change return type.
1384         (library_list_start_segment, library_list_start_section)
1385         (library_list_end_library, library_list_start_library); Update.
1386         (solib_target_free_library_list): Remove.
1387         (solib_target_parse_libraries): Remove cleanup.  Change return
1388         type.
1389         (solib_target_current_sos): Update.
1390
1391 2019-01-17  Tom Tromey  <tromey@bapiya>
1392
1393         * valprint.c: Replace "the the" with "the".
1394         * symtab.c: Replace "the the" with "the".
1395         * solib.c: Replace "the the" with "the".
1396         * solib-dsbt.c: Replace "the the" with "the".
1397         * linespec.c: Replace "the the" with "the".
1398         * dwarf2loc.h: Replace "the the" with "the".
1399         * amd64-windows-tdep.c: Replace "the the" with "the".
1400         * aarch64-tdep.c: Replace "the the" with "the".
1401
1402 2019-01-16  Keith Seitz  <keiths@redhat.com>
1403
1404         PR gdb/23773
1405         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1406         <builder>: Rename to ..
1407         <m_builder>: ... this and make private.
1408         (dwarf2_cu::get_builder): New method.  Change all users of
1409         `builder' to use this method.
1410         (dwarf2_start_symtab): Move to ...
1411         (dwarf2_cu::start_symtab): ... here.  Update all callers
1412         (setup_type_unit_groups): Move to ...
1413         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1414         callers.
1415         (dwarf2_cu::reset_builder): New method.
1416         (process_full_compunit, process_full_type_unit): Use
1417         dwarf2_cu::reset_builder.
1418         (follow_die_offset): Record the ancestor CU if it is different
1419         from the followed DIE's CU.
1420         (follow_die_sig_1): Likewise.
1421
1422 2019-01-15  Tom Tromey  <tom@tromey.com>
1423
1424         * remote.c (class remote_state) <buf>: Now a char_vector.
1425         <buf_size>: Remove.
1426         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1427         parameter.
1428         (remote_target::getpkt_or_notif_sane_1)
1429         (remote_target::getpkt_sane)
1430         (remote_target::getpkt_or_notif_sane): Likewise.
1431         (class remote_target) <putpkt>: New overload.
1432         (remote_target::read_frame): Change type of "buf_p".  Remove
1433         sizeof_p parameter.
1434         (packet_ok): New overload.
1435         (packet_check_result): New overload.
1436         Update all uses.
1437
1438 2019-01-14  Tom Tromey  <tom@tromey.com>
1439
1440         * remote-notif.c (handle_notification, remote_notif_ack)
1441         (remote_notif_parse): Make "buf" const.
1442         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1443         const.
1444         (remote_notif_parse, remote_notif_ack, handle_notification):
1445         Likewise.
1446         * remote.c (remote_notif_stop_parse): Make "buf" const.
1447         (remote_target::remote_parse_stop_reply): Make "buf" const.
1448         (remote_notif_stop_ack): Make "buf" const.
1449
1450 2019-01-14  Tom Tromey  <tom@tromey.com>
1451
1452         * remote.c (remote_console_output): Make parameter const.
1453
1454 2019-01-14  Tom Tromey  <tom@tromey.com>
1455
1456         * target-debug.h (target_debug_print_signals): Constify.
1457         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1458         * procfs.c (procfs_target::pass_signals): Update.
1459         * linux-nat.c (linux_nat_target::pass_signals): Update.
1460         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1461         * target-delegates.c: Rebuild.
1462         * remote.c (remote_target::program_signals): Update.
1463         (remote_target::pass_signals): Update.
1464         * target.c (target_pass_signals): Constify argument.
1465         (target_program_signals): Likewise.
1466         * target.h (struct target_ops) <pass_signals, program_signals>:
1467         Constify argument.
1468         (target_pass_signals, target_program_signals): Constify argument.
1469
1470 2019-01-14  Tom Tromey  <tom@tromey.com>
1471
1472         PR tui/28819:
1473         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1474
1475 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1476
1477         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1478         field.
1479         * rs6000-tdep.c: Include reggroups.h.
1480         (IS_V_ALIAS_PSEUDOREG): Define.
1481         (rs6000_register_name): Return names for the "vX" aliases.
1482         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1483         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1484         aliases.  Call default_register_reggroup_p for all other
1485         pseudo-registers.
1486         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1487         New functions.
1488         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1489         Handle "vX" aliases.
1490         (v_alias_pseudo_register_collect): New function.
1491         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1492         (rs6000_gdbarch_init): Initialize "vX" aliases as
1493         pseudo-registers.  Restore registration of
1494         rs6000_pseudo_register_reggroup_p with
1495         set_tdesc_pseudo_register_reggroup_p.
1496
1497 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1498
1499         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1500         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1501         set_gdbarch_num_pseudo_regs.
1502
1503 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1504
1505         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1506         Remove arg prefixname, add do_set and do_show.
1507         Add member functions set_list and show_list.
1508         * cli/cli-style.c (class cli_style_option): Update accordingly.
1509         (style_set_list): Move to file scope.
1510         (style_show_list): Likewise.
1511         (set_style): Call help_list.
1512         (show_style): Call cmd_show_list.
1513         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1514         Update to use the new macro.
1515
1516 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1517
1518         * ada-lang.c (_initialize_ada_language): Expand the help text
1519         for the "catch exception" command.
1520
1521 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1522
1523         * symtab.c (matching_obj_sections): Initialize obj,
1524         declare it closer to its usage.
1525
1526 2019-01-10  Tom Tromey  <tom@tromey.com>
1527
1528         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1529         (basic_inf_threads_range): Remove.
1530         (inf_threads_range, inf_non_exited_threads_range)
1531         (safe_inf_threads_range): Use next_adapter.
1532
1533 2019-01-10  Keith Seitz  <keiths@redhat.com>
1534
1535         PR gdb/23712
1536         PR symtab/23010
1537         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1538         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1539
1540 2019-01-10  Keith Seitz  <keiths@redhat.com>
1541
1542         PR gdb/23712
1543         PR symtab/23010
1544         * dictionary.c (pending_to_vector): Remove.
1545         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1546         Remove _1 suffix, replacing functions of the same name.  Update
1547         all callers.
1548         (dict_create_hashed, dict_create_hashed_expandable)
1549         (dict_create_linear, dict_create_linear_expandable, dict_free)
1550         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1551         Make functions static.
1552
1553 2019-01-10  Keith Seitz  <keiths@redhat.com>
1554
1555         PR gdb/23712
1556         PR symtab/23010
1557         * dictionary.h (struct dictionary): Replace declaration with
1558         multidictionary.
1559         (dict_create_hashed, dict_create_hashed_expandable)
1560         (dict_create_linear, dict_create_linear_expandable)
1561         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1562         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1563         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1564         taking multidictionary argument.
1565         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1566         * block.h (struct block) <dict>: Change to multidictionary
1567         and rename `multidict'.
1568         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1569         symmisc.c: Update all dictionary references to multidictionary.
1570
1571 2019-01-10  Keith Seitz  <keiths@redhat.com>
1572
1573         PR gdb/23712
1574         PR symtab/23010
1575         * dictionary.c: Include unordered_map.
1576         (pending_to_vector): New function.
1577         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1578         Rewrite the non-"_1" functions to take vector instead
1579         of linked list.
1580         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1581         "new" _1 versions of the same name.
1582         (multidictionary): Define.
1583         (std::hash<enum language): New definition.
1584         (collate_pending_symbols_by_language, mdict_create_hashed)
1585         (mdict_create_hashed_expandable, mdict_create_linear)
1586         (mdict_create_linear_expandable, mdict_free)
1587         (find_language_dictionary, create_new_language_dictionary)
1588         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1589         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1590         (mdict_size, mdict_empty): New functions.
1591         * dictionary.h (mdict_iterator): Define.
1592
1593 2019-01-10  Pedro Alves  <palves@redhat.com>
1594
1595         * breakpoint.c (read_uploaded_action)
1596         (create_tracepoint_from_upload): Adjust to use
1597         gdb::unique_xmalloc_ptr.
1598         * ctf.c (ctf_write_uploaded_tp):
1599         (SET_ARRAY_FIELD): Use emplace_back.
1600         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1601         * tracefile-tfile.c (tfile_write_uploaded_tp):
1602         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1603         gdb::unique_xmalloc_ptr.
1604         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1605         at_string, cond_string, cmd_strings>: Replace char pointers
1606         with gdb::unique_xmalloc_ptr.
1607
1608 2019-01-10  Pedro Alves  <palves@redhat.com>
1609
1610         * solib-target.c (library_list_start_library): Don't xstrdup name.
1611
1612 2019-01-10  Pedro Alves  <palves@redhat.com>
1613
1614         * mdebugread.c (parse_partial_symbols): Use
1615         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1616
1617 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1618
1619         * linux-fork.c (scoped_switch_fork_info)
1620         <~scoped_switch_fork_info>: Fix incorrect variable name.
1621
1622 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1623
1624         * linux-fork.c (scoped_switch_fork_info)
1625         <scoped_switch_fork_info>: Make explicit.
1626         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1627
1628 2019-01-10  Tom Tromey  <tom@tromey.com>
1629
1630         * objfiles.h (objfile::reset_psymtabs): Update.
1631         * objfiles.c (objfile::objfile): Update.
1632         * psymtab.h (psymtab_storage::obstack): Update.
1633         (psymtab_storage::m_obstack): Use gdb::optional.
1634         (class psymtab_storage): Update comment.  Remove objfile
1635         parameter.
1636         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1637
1638 2019-01-10  Tom Tromey  <tom@tromey.com>
1639
1640         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1641         <free_psymtabs>: Now private.
1642         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1643         (allocate_psymtab): Use new method.
1644
1645 2019-01-10  Tom Tromey  <tom@tromey.com>
1646
1647         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1648         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1649         * mdebugread.c (parse_partial_symbols): Use
1650         allocate_dependencies.
1651         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1652         allocate_dependencies.
1653         (process_psymtab_comp_unit_reader)
1654         (build_type_psymtab_dependencies): Likewise.
1655         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1656
1657 2019-01-10  Tom Tromey  <tom@tromey.com>
1658
1659         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1660         PSYMBOL_SET_LANGUAGE.
1661         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1662
1663 2019-01-10  Tom Tromey  <tom@tromey.com>
1664
1665         * psymtab.h (psymtab_storage::obstack): New method.
1666         <m_obstack>: Rename from obstack; now private.
1667         * psymtab.c (psymtab_storage): Update.
1668         * dwarf2read.c (create_addrmap_from_index)
1669         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1670         Update.
1671
1672 2019-01-10  Tom Tromey  <tom@tromey.com>
1673
1674         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1675         * objfiles.h (objfile::reset_psymtabs): New method.
1676
1677 2019-01-10  Tom Tromey  <tom@tromey.com>
1678
1679         * symmisc.c (print_symbol_bcache_statistics): Update.
1680         (print_objfile_statistics): Update.
1681         * symfile.c (reread_symbols): Update.
1682         * psymtab.h (class psymtab_storage): New.
1683         * psymtab.c (psymtab_storage): New constructor.
1684         (~psymtab_storage): New destructor.
1685         (require_partial_symbols): Update.
1686         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1687         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1688         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1689         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1690         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1691         (start_psymtab_common, end_psymtab_common)
1692         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1693         (allocate_psymtab): Update.
1694         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1695         Update.
1696         (dump_psymtab_addrmap, maintenance_print_psymbols)
1697         (maintenance_check_psymtabs): Update.
1698         (class objfile_psymtabs): Move to objfiles.h.
1699         * psympriv.h (discard_psymtab): Now inline.
1700         (psymtab_discarder::psymtab_discarder): Update.
1701         (psymtab_discarder::~psymtab_discarder): Update.
1702         (ALL_OBJFILE_PSYMTABS): Rewrite.
1703         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1704         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1705         Remove fields.
1706         <partial_symtabs>: New field.
1707         (class objfile_psymtabs): Move from psymtab.h.  Update.
1708         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1709         psymbol_cache.
1710         (objfile::~objfile): Don't destroy psymbol_cache.
1711         * mdebugread.c (parse_partial_symbols): Update.
1712         * dwarf2read.c (create_addrmap_from_index)
1713         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1714         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1715         (add_partial_subprogram, dwarf2_ranges_read): Update.
1716         * dwarf-index-write.c (write_address_map)
1717         (write_one_signatured_type, recursively_write_psymbols)
1718         (class debug_names, class debug_names, write_psymtabs_to_index):
1719         Update.
1720
1721 2019-01-10  Tom Tromey  <tom@tromey.com>
1722
1723         * symtab.h (SYMBOL_SET_NAMES): Update.
1724         (symbol_set_names): Update.
1725         (MSYMBOL_SET_NAMES): Update.
1726         * symtab.c (symbol_set_names): Change argument to be an
1727         objfile_per_bfd_storage.
1728         * psymtab.c (add_psymbol_to_bcache): Update.
1729         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1730
1731 2019-01-10  Tom Tromey  <tom@tromey.com>
1732
1733         * symtab.c (create_demangled_names_hash): Change argument to be an
1734         objfile_per_bfd_storage.
1735         (symbol_set_names): Update.
1736
1737 2019-01-10  Tom Tromey  <tom@tromey.com>
1738
1739         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1740         init_psymbol_list.
1741         * psymtab.c (init_psymbol_list): Do nothing if already called.
1742         * psympriv.h (init_psymbol_list): Add comment.
1743         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1744         init_psymbol_list.
1745         * dbxread.c (dbx_symfile_read): Unconditionally call
1746         init_psymbol_list.
1747
1748 2019-01-10  Tom Tromey  <tom@tromey.com>
1749
1750         * xcoffread.c (scan_xcoff_symtab): Update.
1751         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1752         "where".
1753         * mdebugread.c (parse_partial_symbols)
1754         (handle_psymbol_enumerators): Update.
1755         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1756         * dbxread.c (read_dbx_symtab): Update.
1757         * psympriv.h (psymbol_placement): New enum.
1758         (add_psymbol_to_list): Update.
1759
1760 2019-01-10  Tom Tromey  <tom@tromey.com>
1761
1762         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1763         static_psymbols parameters.
1764         (scan_xcoff_symtab): Update.
1765         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1766         static_psymbols parameters.
1767         * psympriv.h (start_psymtab_common): Update.
1768         * mdebugread.c (parse_partial_symbols): Update.
1769         * dwarf2read.c (create_partial_symtab): Update.
1770         * dbxread.c (read_dbx_symtab): Update.
1771         (start_psymtab): Remove global_psymbols and static_psymbols
1772         parameters.
1773
1774 2019-01-10  Tom Tromey  <tom@tromey.com>
1775
1776         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1777         * psymtab.c (allocate_psymtab): Add comment.
1778         * psympriv.h (allocate_psymtab): Add comment.
1779         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1780         initializations.
1781         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1782
1783 2019-01-10  Tom Tromey  <tom@tromey.com>
1784
1785         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1786         Don't declare.
1787         * mipsread.c: Include mdebugread.h.
1788         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1789         Declare.
1790         * elfread.c: Include mdebugread.h.
1791
1792 2019-01-09  Tom Tromey  <tom@tromey.com>
1793
1794         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1795         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1796         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1797         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1798         (psym_lookup_symbol, psym_find_last_source_symtab)
1799         (psym_forget_cached_source_info, psym_print_stats)
1800         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1801         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1802         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1803         (psym_find_compunit_symtab_by_address)
1804         (maintenance_print_psymbols, maintenance_info_psymtabs)
1805         (maintenance_check_psymtabs): Use ranged for.
1806         * psymtab.h (class objfile_psymtabs): New.
1807         (require_partial_symbols): Return objfile_psymtabs.
1808         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1809
1810 2019-01-09  Tom Tromey  <tom@tromey.com>
1811
1812         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1813         (find_pc_mapped_section, list_overlays_command)
1814         (map_overlay_command, unmap_overlay_command)
1815         (simple_overlay_update): Use all_objfiles.
1816         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1817         * printcmd.c (info_symbol_command): Use all_objfiles.
1818         * objfiles.h (ALL_OBJSECTIONS): Remove.
1819         * maint.c (maintenance_translate_address): Use all_objfiles.
1820         * gcore.c (gcore_create_callback): Use all_objfiles.
1821         (objfile_find_memory_regions): Likewise.
1822
1823 2019-01-09  Tom Tromey  <tom@tromey.com>
1824
1825         * symtab.c (find_line_symtab, info_sources_command)
1826         (make_source_files_completion_list): Use objfile_compunits.
1827         * source.c (select_source_symtab): Use objfile_compunits.
1828         * objfiles.h (struct objfile): Update comment.
1829         (ALL_OBJFILES): Remove.
1830         (ALL_FILETABS): Remove.
1831         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1832         objfile_compunits.
1833
1834 2019-01-09  Tom Tromey  <tom@tromey.com>
1835
1836         * symmisc.c (print_objfile_statistics, dump_objfile)
1837         (maintenance_print_symbols): Use compunit_filetabs.
1838         * source.c (forget_cached_source_info_for_objfile): Use
1839         compunit_filetabs.
1840         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1841         (ALL_FILETABS): Use compunit_filetabs.
1842         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1843         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1844
1845 2019-01-09  Tom Tromey  <tom@tromey.com>
1846
1847         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1848         (compunit_filetabs): New.
1849         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1850         compunit_filetabs.
1851         (info_sources_command, make_source_files_completion_list): Remove
1852         declaration.
1853         * symmisc.c (print_objfile_statistics, dump_objfile)
1854         (maintenance_print_symbols): Remove declaration.
1855         (maintenance_info_symtabs): Use compunit_filetabs.
1856         (maintenance_info_line_tables): Likewise.
1857         * source.c (select_source_symtab): Change local variable name.
1858         (forget_cached_source_info_for_objfile): Remove declaration.
1859         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1860         * objfiles.c (objfile_relocate1): Remove declaration.
1861         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1862         declaration.
1863         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1864         * coffread.c (coff_symtab_read): Remove declaration.
1865         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1866         compunit_filetabs.
1867
1868 2019-01-09  Tom Tromey  <tom@tromey.com>
1869
1870         * symtab.c (lookup_objfile_from_block)
1871         (find_pc_sect_compunit_symtab, search_symbols)
1872         (default_collect_symbol_completion_matches_break_on): Use
1873         objfile_compunits.
1874         * objfiles.h (ALL_COMPUNITS): Remove.
1875         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1876         * cp-support.c (add_symbol_overload_list_qualified): Use
1877         objfile_compunits.
1878         * ada-lang.c (ada_collect_symbol_completion_matches)
1879         (ada_add_global_exceptions): Use objfile_compunits.
1880
1881 2019-01-09  Tom Tromey  <tom@tromey.com>
1882
1883         * source.c (select_source_symtab)
1884         (forget_cached_source_info_for_objfile): Remove declaration.
1885         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1886         declaration.
1887         * maint.c (count_symtabs_and_blocks): Remove declaration.
1888         * cp-support.c (add_symbol_overload_list_qualified): Remove
1889         declaration.
1890         * coffread.c (coff_symtab_read): Remove declaration.
1891         * symtab.c (lookup_symbol_in_objfile_symtabs)
1892         (basic_lookup_transparent_type_1): Use objfile_compunits.
1893         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1894         (info_sources_command, search_symbols)
1895         (default_collect_symbol_completion_matches_break_on)
1896         (make_source_files_completion_list): Remove declaration.
1897         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1898         (ada_collect_symbol_completion_matches)
1899         (ada_add_global_exceptions): Remove declaration.
1900         * linespec.c (iterate_over_all_matching_symtabs): Use
1901         objfile_compunits.
1902         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1903         (class objfile_compunits): New.
1904         (ALL_COMPUNITS): Use objfile_compunits.
1905         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1906         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1907         objfile_compunits.
1908         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1909
1910 2019-01-09  Tom Tromey  <tom@tromey.com>
1911
1912         * symtab.c (search_symbols)
1913         (default_collect_symbol_completion_matches_break_on): Use
1914         objfile_msymbols.
1915         * ada-lang.c (ada_lookup_simple_minsym)
1916         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1917         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1918         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1919         objfile_msymbols.
1920         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1921         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1922         * objc-lang.c (find_methods): Use objfile_msymbols.
1923         (info_selectors_command, info_classes_command): Likewise.
1924         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1925         * objfiles.h (class objfile_msymbols): New.
1926         (ALL_OBJFILE_MSYMBOLS): Remove.
1927         (ALL_MSYMBOLS): Remove.
1928
1929 2019-01-09  Tom Tromey  <tom@tromey.com>
1930
1931         * common/next-iterator.h (next_adapter): Add Iterator template
1932         parameter.
1933         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1934         (class all_objfiles_safe): New.
1935         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1936         * objfiles.c (put_objfile_before): Update comment.
1937         (add_separate_debug_objfile): Likewise.
1938         (free_all_objfiles): Use all_objfiles_safe.
1939         (objfile_purge_solibs): Likewise.
1940
1941 2019-01-09  Tom Tromey  <tom@tromey.com>
1942
1943         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1944         (expand_symtab_containing_pc, lookup_static_symbol)
1945         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1946         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1947         all_objfiles.
1948         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1949         * breakpoint.c (create_overlay_event_breakpoint)
1950         (create_longjmp_master_breakpoint)
1951         (create_std_terminate_master_breakpoint)
1952         (create_exception_master_breakpoint): Use all_objfiles.
1953         * linux-thread-db.c (try_thread_db_load_from_pdir)
1954         (has_libpthread): Use all_objfiles.
1955         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1956         * linespec.c (iterate_over_all_matching_symtabs)
1957         (search_minsyms_for_name): Use all_objfiles.
1958         * maint.c (maintenance_info_sections): Use all_objfiles.
1959         * main.c (captured_main_1): Use all_objfiles.
1960         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1961         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1962         * guile/scm-pretty-print.c
1963         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1964         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1965         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1966         (maintenance_print_msymbols): Use all_objfiles.
1967         * source.c (select_source_symtab): Use all_objfiles.
1968         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1969         * symfile.c (remove_symbol_file_command)
1970         (expand_symtabs_matching, map_symbol_filenames): Use
1971         all_objfiles.
1972         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1973         all_objfiles.
1974         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1975         * objc-lang.c (find_methods): Use all_objfiles.
1976         * objfiles.c (have_partial_symbols, have_full_symbols)
1977         (have_minimal_symbols, qsort_cmp)
1978         (default_iterate_over_objfiles_in_search_order): Use
1979         all_objfiles.
1980         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1981         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1982         (maintenance_check_psymtabs): Use all_objfiles.
1983         (ALL_PSYMTABS): Remove.
1984         * compile/compile-object-run.c (do_module_cleanup): Use
1985         all_objfiles.
1986         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1987         * cp-support.c (add_symbol_overload_list_qualified): Use
1988         all_objfiles.
1989         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1990         Use all_objfiles.
1991         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1992         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1993         all_objfiles.
1994         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1995         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1996         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1997         Uses all_objfiles.
1998         * solib.c (solib_read_symbols): Use all_objfiles
1999
2000 2019-01-09  Tom Tromey  <tom@tromey.com>
2001
2002         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2003         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2004         all_objfiles.
2005         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2006         * symmisc.c (print_symbol_bcache_statistics)
2007         (print_objfile_statistics, maintenance_print_objfiles)
2008         (maintenance_info_symtabs, maintenance_check_symtabs)
2009         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2010         all_objfiles.
2011         * source.c (forget_cached_source_info): Use all_objfiles.
2012         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2013         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2014         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2015         * objfiles.c (update_section_map): Use all_objfiles.
2016         (shared_objfile_contains_address_p): Likewise.
2017         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2018         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2019
2020 2019-01-09  Tom Tromey  <tom@tromey.com>
2021
2022         * common/next-iterator.h: New file.
2023         * objfiles.h (class all_objfiles): New.
2024         (struct objfile_iterator): New.
2025
2026 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2027
2028         * NEWS: Move the description of the changed "frame", "select-frame",
2029          and "info frame" commands to the Changed commands section.
2030
2031 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2032
2033         * gdbtypes.c (check_stub_method_group): Remove handling of old
2034         mangling schemes.
2035         * linespec.c (find_methods): Likewise.
2036         * stabsread.c (read_member_functions): Likewise.
2037         * valops.c (search_struct_method): Likewise.
2038         (value_struct_elt_for_reference): Likewise.
2039         * NEWS: Mention this change.
2040
2041 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2042
2043         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2044         print_source_lines.
2045         * source.c (print_source_lines_base): Update line number check.
2046         (print_source_lines): New function.
2047         (source_lines_range::source_lines_range): New function.
2048         * source.h (class source_lines_range): New class.
2049         (print_source_lines): New declaration.
2050
2051 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2052
2053         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2054
2055 2019-01-08  Tom Tromey  <tom@tromey.com>
2056             Simon Marchi  <simon.marchi@ericsson.com>
2057
2058         PR gdb/24060
2059         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2060         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2061         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2062         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2063         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2064         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2065
2066 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2067
2068         * source.c (select_source_symtab): Move header comment to
2069         declaration in source.h.
2070         (forget_cached_source_info_for_objfile): Likewise.
2071         (forget_cached_source_info): Likewise.
2072         (identify_source_line): Likewise.
2073         * source.h (identify_source_line): Move declaration from symtab.h
2074         and add comment from source.c
2075         (print_source_lines): Likewise.
2076         (forget_cached_source_info_for_objfile): Likewise.
2077         (forget_cached_source_info): Likewise.
2078         (select_source_symtab): Likewise.
2079         (enum print_source_lines_flag): Move definition from symtab.h.
2080         * symtab.h (identify_source_line): Move declaration to source.h.
2081         (print_source_lines): Likewise.
2082         (forget_cached_source_info_for_objfile): Likewise.
2083         (forget_cached_source_info): Likewise.
2084         (select_source_symtab): Likewise.
2085         (enum print_source_lines_flag): Move definition to source.h.
2086         * tui/tui-hooks.c: Add 'source.h' include.
2087
2088 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2089
2090         * source.c (print_source_lines_base): Handle requests to print
2091         reverse line number sequences, and guard against empty lines
2092         string.
2093
2094 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2095
2096         * source.c (print_source_lines_base): Fix skip of '\r' if next
2097         character is '\n'.
2098
2099 2019-01-06  Tom Tromey  <tom@tromey.com>
2100
2101         * c-exp.y (struct c_parse_state) <macro_original_text,
2102         expansion_obstack>: New member.
2103         (macro_original_text, expansion_obstack): Remove globals.
2104         (scan_macro_expansion, scanning_macro_expansion)
2105         (finished_macro_expansion): Update.
2106         (scan_macro_cleanup): Remove.
2107         (yylex, c_parse): Update.
2108
2109 2019-01-06  Tom Tromey  <tom@tromey.com>
2110
2111         * c-exp.y (struct c_parse_state) <strings>: New member.
2112         (operator_stoken): Update.
2113
2114 2019-01-06  Tom Tromey  <tom@tromey.com>
2115
2116         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2117         (union type_stack_elt) <typelist_val>: Now a pointer to
2118         std::vector.
2119         (type_stack_cleanup): Don't declare.
2120         (push_typelist): Update.
2121         * parse.c (pop_typelist): Return a std::vector.
2122         (push_typelist): Take a std::vector.
2123         (follow_types): Update.  Do not free args.
2124         (type_stack_cleanup): Remove.
2125         * c-exp.y (struct c_parse_state): New.
2126         (cpstate): New global.
2127         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2128         (nonempty_typelist): Update.
2129         (func_mod): Create a new vector.
2130         (c_parse): Create a c_parse_state.
2131         (check_parameter_typelist): Do not delete params.
2132         (function_method): Update.  Do not delete type_list.
2133
2134 2019-01-06  Tom Tromey  <tom@tromey.com>
2135
2136         PR gdb/28155:
2137         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2138         check_typedef.
2139         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2140         (print_return_value): Likewise.
2141
2142 2019-01-05  Tom Tromey  <tom@tromey.com>
2143
2144         * contrib/cleanup_check.py: Remove.
2145         * contrib/gcc-with-excheck: Remove.
2146         * contrib/exsummary.py: Remove.
2147         * contrib/excheck.py: Remove.
2148
2149 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2150
2151         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2152         NULL. Initialize tpprev to NULL instead of assigning it
2153         to NULL on the next statement.
2154         * windows-nat.c (windows_delete_thread): Remove check for
2155         main_thread_id before printing thread exit notifications.
2156         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2157         Remove thread ID check against main_thread_id.
2158         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2159         windows_delete_thread.
2160         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2161
2162 2019-01-04  Tom Tromey  <tom@tromey.com>
2163
2164         * compile/compile.c (_initialize_compile): Use upper case for
2165         metasyntactic variables.
2166         * symmisc.c (_initialize_symmisc): Use upper case for
2167         metasyntactic variables.
2168         * psymtab.c (_initialize_psymtab): Use upper case for
2169         metasyntactic variables.
2170         * demangle.c (demangle_command): Use upper case for metasyntactic
2171         variables.
2172         (_initialize_demangler): Likewise.
2173         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2174         variables.
2175
2176 2019-01-03  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2179
2180 2019-01-03  Tom Tromey  <tom@tromey.com>
2181
2182         * python/py-symtab.c (salpy_str): Update.
2183         (struct salpy_sal_object) <symtab>: Now a PyObject.
2184         (salpy_dealloc): Update.
2185         (del_objfile_sal): Use gdbpy_ref.
2186
2187 2019-01-03  Tom Tromey  <tom@tromey.com>
2188
2189         * python/py-type.c (convert_field): Use new_reference.  Return
2190         gdbpy_ref.
2191         (make_fielditem): Return gdbpy_ref.
2192         (typy_fields): Update.
2193         (typy_getitem): Update.
2194         (field_name): Return gdbpy_ref.  Use new_reference.
2195         (typy_iterator_iternext): Update.
2196
2197 2019-01-03  Tom Tromey  <tom@tromey.com>
2198
2199         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2200
2201 2019-01-03  Tom Tromey  <tom@tromey.com>
2202
2203         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2204         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2205         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2206         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2207         (pspy_set_type_printers): Likewise.
2208         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2209         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2210         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2211         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2212         (objfpy_set_type_printers): Likewise.
2213
2214 2019-01-03  Tom Tromey  <tom@tromey.com>
2215
2216         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2217         (gdbpy_print_stack): Use gdbpy_err_fetch.
2218         * python/python-internal.h (class gdbpy_err_fetch): New class.
2219         (class gdbpy_enter) <m_error_type, m_error_value,
2220         m_error_traceback>: Remove.
2221         <m_error>: New member.
2222         (gdbpy_exception_to_string): Don't declare.
2223         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2224         * python/py-value.c (convert_value_from_python): Use
2225         gdbpy_err_fetch.
2226         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2227         gdbpy_exception_to_string.
2228         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2229         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2230         gdbpy_err_fetch.
2231
2232 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2233
2234         * linux-nat.c (delete_lwp_cleanup): Delete.
2235         (struct lwp_deleter): New struct.
2236         (lwp_info_up): New typedef.
2237         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2238         lwp_info_up.
2239
2240 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2241
2242         * linux-fork.c (class scoped_switch_fork_info): New class.
2243         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2244
2245 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2246
2247         * valops.c (find_overload_match): Remove use of null_cleanup, and
2248         calls to do_cleanups.
2249
2250 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2251
2252         * compile/compile-cplus-types.c
2253         (compile_cplus_instance::decl_name): Handle changes to
2254         cp_func_name.
2255         * cp-support.c (cp_func_name): Update header comment, update
2256         return type.
2257         * cp-support.h (cp_func_name): Update return type in declaration.
2258         * valops.c (find_overload_match): Move temp_func local to top
2259         level of function and change its type.  Use temp_func to hold and
2260         delete temporary string obtained from cp_func_name.
2261
2262 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2263
2264         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2265         gdb::char_vector, remove cleanup, and update uses of `msg`.
2266
2267 2019-01-03  Jim Wilson  <jimw@sifive.com>
2268
2269         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2270
2271 2019-01-02  Tom Tromey  <tom@tromey.com>
2272
2273         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2274         (tdesc_parse_xml): Remove cleanups.
2275         * target-descriptions.h (make_cleanup_free_target_description):
2276         Don't declare.
2277         (target_desc_deleter): New struct.
2278         (target_desc_up): New typedef.
2279         * target-descriptions.c (target_desc_deleter::operator()): Rename
2280         from free_target_description.
2281         (make_cleanup_free_target_description): Remove.
2282
2283 2019-01-02  Tom Tromey  <tom@tromey.com>
2284
2285         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2286         constructor, destructor.
2287         (linespec_parser): Remove typedef.
2288         (~linespec_parser): Rename from linespec_parser_delete.
2289         (linespec_lex_to_end, linespec_complete_label)
2290         (linespec_complete): Update.
2291         (decode_line_full): Remove cleanups.
2292         (decode_line_1): Update.
2293
2294 2019-01-02  Tom Tromey  <tom@tromey.com>
2295
2296         * python/python-internal.h (inferior_to_inferior_object): Change
2297         return type.
2298         * python/py-exitedevent.c (create_exited_event_object): Update.
2299         * python/py-inferior.c (inferior_to_inferior_object): Return
2300         gdbpy_ref.
2301         (python_new_inferior, python_inferior_deleted)
2302         (thread_to_thread_object, delete_thread_object)
2303         (build_inferior_list, gdbpy_selected_inferior): Update.
2304         * python/py-infthread.c (create_thread_object): Update.  Also fail
2305         if inferior_to_inferior_object fails.
2306
2307 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2308
2309         * inferior.h (class inferior) <displaced_step_state>: New field.
2310         * infrun.h (struct displaced_step_state): Move here from
2311         infrun.c.  Initialize fields, add constructor.
2312         <inf>: Remove field.
2313         <reset>: New method.
2314         * infrun.c (struct displaced_step_inferior_state): Move to
2315         infrun.h.
2316         (displaced_step_inferior_states): Remove.
2317         (get_displaced_stepping_state): Adust.
2318         (displaced_step_in_progress_any_inferior): Adjust.
2319         (displaced_step_in_progress_thread): Adjust.
2320         (displaced_step_in_progress): Adjust.
2321         (add_displaced_stepping_state): Remove.
2322         (get_displaced_step_closure_by_addr): Adjust.
2323         (remove_displaced_stepping_state): Remove.
2324         (infrun_inferior_exit): Call displaced_step_state.reset.
2325         (use_displaced_stepping): Don't check for NULL.
2326         (displaced_step_prepare_throw): Call
2327         get_displaced_stepping_state.
2328         (displaced_step_fixup): Don't check for NULL.
2329         (prepare_for_detach): Don't check for NULL.
2330
2331 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2332
2333         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2334          in case of call that did not complete.
2335
2336 2019-01-02  Andrey Utkin  <autkin@undo.io>
2337
2338         * symfile.c (find_separate_debug_file): Fix search of debug files for
2339         remote debuggee.
2340
2341 2019-01-02  Tom Tromey  <tom@tromey.com>
2342
2343         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2344         indentation.
2345         * python/py-frame.c (frapy_older): Remove cast.
2346         (frapy_newer): Likewise.
2347         * python/py-breakpoint.c (local_setattro): Remove cast.
2348         * python/py-arch.c (archpy_name): Remove local variable.
2349         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2350
2351 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2352
2353         * unittests/basic_string_view/element_access/char/empty.cc:
2354         Fix year range in copyright header.
2355
2356 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2357
2358         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2359         Delete.
2360         <operator==>: Update with for removed field.
2361         <hash>: Likewise.
2362         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2363         <isa_features>: ...this.
2364         <abi_features>: New field.
2365         (riscv_isa_flen): Update comment.
2366         (riscv_abi_xlen): New declaration.
2367         (riscv_abi_flen): New declaration.
2368         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2369         isa_features.
2370         (riscv_abi_xlen): New function.
2371         (riscv_isa_flen): Update to get answer from isa_features.
2372         (riscv_abi_flen): New function.
2373         (riscv_has_fp_abi): Update to get answer from abi_features.
2374         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2375         xlen and flen.
2376         (riscv_call_info) <xlen, flen>: Update comment.
2377         (riscv_call_arg_struct): Remove invalid assertions
2378         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2379         is removed.
2380         (riscv_gdbarch_init): Gather isa features and abi features
2381         separately, ensure both match on the gdbarch when reusing an old
2382         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2383         a target with 64-bit float hardware.
2384
2385 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2386
2387         * source.c (search_command_helper): Stop reverse search
2388         when line 1 has been searched.
2389
2390 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2391
2392         * record-full.c (record_full_base_target::close): Rewrite
2393         record_full_core_buf_list free logic.
2394
2395 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2396
2397         * break-catch-syscall.c (print_one_catch_syscall): xfree
2398         the last text.
2399
2400 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2401
2402         * top.c (print_gdb_version): Update Copyright year in version
2403         message.
2404
2405 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2406
2407         Update copyright year range in all GDB files.
2408
2409 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2410
2411         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2412
2413 For older changes see ChangeLog-2018.
2414 \f
2415 Local Variables:
2416 mode: change-log
2417 left-margin: 8
2418 fill-column: 74
2419 version-control: never
2420 coding: utf-8
2421 End:
2422