gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui.c (tui_rl_other_window): Update.
   4         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
   5         superclass method first.  Always iterate over regs_content.
   6         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
   7         method.
   8         * tui/tui-win.c (tui_set_focus_command): Update.
   9
  10 2019-07-17  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-win.c (tui_set_focus_command): Rename from
  13         tui_set_focus.  Call tui_enable.
  14         (tui_set_focus_command): Remove.
  15
  16 2019-07-17  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
  19         refresh_window.
  20         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
  21         touchwin.
  22         (tui_data_window::refresh_window): Call refresh_window on data
  23         items.  Always call superclass refresh_window.
  24         (tui_win_info::refresh): Remove.
  25         (tui_source_window_base::refresh_window): Update.
  26         (tui_refresh_all): Update.
  27         * tui/tui-layout.c (show_source_disasm_command): Remove call to
  28         refresh_window.
  29         (show_source_or_disasm_and_command): Likewise.
  30         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
  31         (struct tui_source_window_base) <refresh>: Likewise.
  32
  33 2019-07-17  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-winsource.c (tui_clear_source_content)
  36         (tui_show_source_content): Update.
  37         * tui/tui-source.c (tui_source_window::showing_source_p): Check
  38         whether content is empty.
  39         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
  40         Remove.
  41
  42 2019-07-17  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-winsource.c (tui_erase_source_content): Clear the
  45         window's contents.
  46         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
  47         * tui/tui-source.c (tui_set_source_content_nil): Remove.
  48
  49 2019-07-17  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
  52         (struct tui_data_item_window): Update.
  53
  54 2019-07-17  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
  57         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
  58         defines.
  59
  60 2019-07-17  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-winsource.h (tui_erase_source_content)
  63         (tui_clear_source_content): Remove "display_prompt" parameter.
  64         * tui/tui-winsource.c (tui_update_source_window_as_is)
  65         (tui_update_source_windows_with_addr): Update.
  66         (tui_clear_source_content): Remove "display_prompt" parameter.
  67         (tui_erase_source_content): Likewise.  Simplify.
  68         (tui_show_source_content): Update.
  69         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  70         * tui/tui-stack.c (tui_show_frame_info): Update.
  71         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
  72         Remove defines.
  73
  74 2019-07-17  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  77         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
  78         parameter.
  79         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
  80         parameter.
  81
  82 2019-07-17  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-winsource.c (tui_clear_source_content)
  85         (tui_show_source_content, tui_show_exec_info_content)
  86         (tui_clear_exec_info_content): Update.
  87         * tui/tui-stack.c (tui_show_locator_content): Update.
  88         (tui_show_frame_info): Update.
  89         * tui/tui-source.h (tui_source_window): Don't declare.
  90         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
  91         from tui_source_is_displayed.
  92         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
  93         Remove field.
  94         (struct tui_source_window_base) <content_in_use>: New field.  Now
  95         bool.
  96         (struct tui_source_window) <showing_source_p>: New method.
  97         (TUI_SRC_WIN): Change cast.
  98         * tui/tui-data.c (tui_initialize_static_data): Update.
  99
 100 2019-07-17  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 103         location_matches_p.
 104         * tui/tui-source.c (tui_source_window::location_matches_p): New
 105         method.
 106         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 107         method.
 108         * tui/tui-data.h (struct tui_source_window_base)
 109         <location_matches_p>: New method.
 110         (struct tui_source_window, struct tui_disasm_window)
 111         <location_matches_p>: Likewise.
 112
 113 2019-07-17  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-win.c (tui_set_win_height_command): Rename from
 116         tui_set_win_height.
 117         (tui_set_win_height_command): Remove.
 118
 119 2019-07-17  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-source.c (tui_source_window): New constructor.  Add
 122         observer.
 123         (~tui_source_window): New destructor.
 124         (tui_source_window::style_changed): New method.
 125         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 126         (tui_attach_detach_observers): Update.
 127         * tui/tui-data.h (struct tui_source_window): Make constructor not
 128         inline.  Add destructor.
 129         (struct tui_source_window) <style_changed>: New method.
 130         <m_observable>: New member.
 131
 132 2019-07-17  Tom Tromey  <tom@tromey.com>
 133
 134         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 135         * tui/tui-win.c (tui_resize_all): Fix typo.
 136
 137 2019-07-17  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 140         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 141         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 142         * tui/tui-win.c (window_name_completer): Use foreach.
 143         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 144         (update_tab_width): Likewise.
 145         * tui/tui-layout.c (show_layout): Update.
 146         * tui/tui-data.h (class tui_window_iterator): New.
 147         (struct all_tui_windows): New.
 148         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 149
 150 2019-07-17  Tom Tromey  <tom@tromey.com>
 151
 152         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 153         parameter.  Don't reference globals.
 154         (tui_reg_command): Update.
 155
 156 2019-07-17  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-regs.c (tui_show_registers): Simplify.
 159
 160 2019-07-17  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-regs.c (tui_show_registers): Update.
 163         (tui_show_register_group): Add win_info parameter.
 164
 165 2019-07-17  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 168         Rename from tui_display_reg_element_at_line.
 169         (tui_data_window::display_registers_from_line): Update.
 170         * tui/tui-data.h (struct tui_data_window)
 171         <display_reg_element_at_line>: New method.
 172
 173 2019-07-17  Tom Tromey  <tom@tromey.com>
 174
 175         * tui/tui-regs.h (tui_display_registers_from)
 176         (tui_display_registers_from_line): Don't declare.
 177         * tui/tui-windata.c (tui_data_window::display_all_data)
 178         (tui_data_window::refresh_all)
 179         (tui_data_window::do_scroll_vertical): Update.
 180         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 181         from tui_display_registers_from.
 182         (tui_display_reg_element_at_line): Update.
 183         (tui_data_window::display_registers_from_line): Rename from
 184         tui_display_registers_from_line.
 185         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 186         display_registers_from_line>: New methods.
 187
 188 2019-07-17  Tom Tromey  <tom@tromey.com>
 189
 190         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 191         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 192         from tui_erase_data_content.
 193         (tui_data_window::display_all_data)
 194         (tui_data_window::refresh_all)
 195         (tui_data_window::do_scroll_vertical): Update.
 196         * tui/tui-regs.c (tui_show_registers): Update.
 197         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 198         New method.
 199
 200 2019-07-17  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 203         declare.
 204         * tui/tui-windata.c
 205         (tui_data_window::delete_data_content_windows): Rename from
 206         tui_delete_data_content_windows.
 207         (tui_data_window::display_all_data)
 208         (tui_data_window::do_scroll_vertical): Update.
 209         * tui/tui-data.h (struct tui_data_window)
 210         <delete_data_content_windows>: New method.
 211
 212 2019-07-17  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 215         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 216
 217 2019-07-17  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 220         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 221         from tui_display_all_data.
 222         * tui/tui-win.c
 223         (tui_data_window::do_make_visible_with_new_height): Update.
 224         * tui/tui-regs.c (tui_show_registers): Update.
 225         * tui/tui-layout.c (tui_set_layout): Update.
 226         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 227         method.
 228
 229 2019-07-17  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 232         * tui/tui-windata.c (tui_display_data_from): Remove.
 233         (tui_data_window::refresh_all): Update.
 234
 235 2019-07-17  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 238         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 239         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 240         tui_display_registers_from_line.
 241         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 242         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 243         "force_display" parameter.
 244
 245 2019-07-17  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 248         declare.
 249         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 250         Rename from tui_first_reg_element_no_inline.
 251         (tui_display_reg_element_at_line)
 252         (tui_display_registers_from_line): Update.
 253         * tui/tui-data.h (struct tui_data_window)
 254         <first_reg_element_no_inline>: New method.
 255
 256 2019-07-17  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-windata.c (tui_display_data_from)
 259         (tui_data_window::do_scroll_vertical): Update.
 260         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 261         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 262         Rename from tui_line_from_reg_element_no.
 263         (tui_display_registers_from_line): Update.
 264         * tui/tui-data.h (struct tui_data_window)
 265         <line_from_reg_element_no>: New method.
 266
 267 2019-07-17  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 270         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 271         tui_last_regs_line_no.
 272         (tui_display_reg_element_at_line)
 273         (tui_display_registers_from_line): Update.
 274         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 275         method.
 276
 277 2019-07-17  Tom Tromey  <tom@tromey.com>
 278
 279         PR tui/24722:
 280         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 281         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 282         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 283         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 284         (tui_update_breakpoint_info): Likewise.
 285         * tui/tui-hooks.c (tui_event_create_breakpoint)
 286         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 287         Update.
 288
 289 2019-07-17  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 292
 293 2019-07-17  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-winsource.c (tui_update_source_window_as_is)
 296         (tui_update_source_windows_with_addr): Update.
 297         * tui/tui-source.h (tui_set_source_content)
 298         (tui_show_symtab_source): Add "win_info" parameter.
 299         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 300         parameter.
 301         (tui_show_symtab_source): Likewise.
 302
 303 2019-07-17  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-wingeneral.c
 306         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 307
 308 2019-07-17  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 311         (struct tui_cmd_window) <can_scroll>: New method.
 312         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 313         method.
 314
 315 2019-07-17  Tom Tromey  <tromey@adacore.com>
 316
 317         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 318         do_field_signed>: Rename.  Change type of "value".
 319         * ui-out.c (ui_out::field_signed): Rename from field_int.
 320         Change type of "value".
 321         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 322         type of "value".
 323         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 324         do_field_int.  Change type of "value".
 325         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 326         do_field_int.  Change type of "value".
 327         * tracepoint.c (trace_status_mi, tfind_1)
 328         (print_one_static_tracepoint_marker): Update.
 329         * thread.c (print_thread_info_1, print_selected_thread_frame):
 330         Update.
 331         * stack.c (print_frame, print_frame_info): Update.
 332         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 333         Update.
 334         * source.c (print_source_lines_base): Update.
 335         * skip.c (info_skip_command): Update.
 336         * record-btrace.c (btrace_ui_out_decode_error)
 337         (btrace_call_history_src_line): Update.
 338         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 339         Update.
 340         * progspace.c (print_program_space): Update.
 341         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 342         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 343         do_field_int.  Change type of "value".
 344         * mi/mi-out.c (mi_ui_out::do_table_begin)
 345         (mi_ui_out::do_table_header): Update.
 346         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 347         type of "value".
 348         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 349         (mi_cmd_data_list_changed_registers, output_register)
 350         (mi_cmd_data_read_memory, mi_load_progress)
 351         (mi_cmd_trace_frame_collected): Update.
 352         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 353         Update.
 354         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 355         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 356         (mi_cmd_var_list_children, varobj_update_one): Update.
 357         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 358         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 359         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 360         * inferior.c (print_inferior): Update.
 361         * gdb_bfd.c (print_one_bfd): Update.
 362         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 363         Update.
 364         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 365         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 366         do_field_int.  Change type of "value".
 367         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 368         do_field_int.  Change type of "value".
 369         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 370         (print_one_breakpoint_location, print_it_catch_fork)
 371         (print_one_catch_fork, print_it_catch_vfork)
 372         (print_one_catch_vfork, print_it_catch_solib)
 373         (print_it_catch_exec, print_it_ranged_breakpoint)
 374         (print_mention_watchpoint, print_mention_masked_watchpoint)
 375         (bkpt_print_it, update_static_tracepoint): Update.
 376         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 377         * break-catch-syscall.c (print_it_catch_syscall): Update.
 378         * ada-tasks.c (print_ada_task_info): Update.
 379         * ada-lang.c (print_it_exception, print_mention_exception):
 380         Update.
 381
 382 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 383
 384         PR breakpoints/24541
 385         * gdbarch.c: Regenerate.
 386         * gdbarch.h: Regenerate.
 387         * gdbarch.sh: Adjust return type and parameter types for
 388         'stap_adjust_register'.
 389         (i386_stap_adjust_register): Adjust signature and return new
 390         register name.
 391         * stap-probe.c (stap_parse_register_operand): Adjust use of
 392         'gdbarch_stap_adjust_register'.
 393
 394 2019-07-17  Tom Tromey  <tromey@adacore.com>
 395
 396         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 397         declare VEC.
 398         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 399         std::vector.
 400         (struct s390_process_info): Add initializers.
 401         (s390_add_process): Use new.
 402         (s390_linux_nat_target::low_forget_process): Use delete.
 403         (s390_linux_nat_target::low_new_fork)
 404         (s390_linux_nat_target::stopped_by_watchpoint)
 405         (s390_linux_nat_target::low_prepare_to_resume)
 406         (s390_linux_nat_target::insert_watchpoint)
 407         (s390_linux_nat_target::insert_hw_breakpoint)
 408         (s390_linux_nat_target::remove_watchpoint)
 409         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 410
 411 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 412
 413         * aarch64-fbsd-nat.c: Include regcache.h.
 414         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 415         argument.
 416         (aarch64_fbsd_nat_target::fetch_registers)
 417         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 418         variable.
 419         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 420
 421 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 422
 423         * fbsd-nat.c: Include gdbarch.h.
 424
 425 2019-07-15  Tom Tromey  <tromey@adacore.com>
 426
 427         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 428
 429 2019-07-15  Tom Tromey  <tromey@adacore.com>
 430
 431         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 432         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 433         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 434         * cli-out.c (cli_ui_out::do_field_int): New method.
 435         * ui-out.c (ui_out::field_unsigned): New method.
 436         * symfile.c (generic_load): Use field_unsigned.
 437         (print_transfer_performance): Likewise.
 438         * record-btrace.c (ui_out_field_uint): Remove.
 439         (btrace_call_history_insn_range, btrace_call_history): Use
 440         field_unsigned.
 441         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 442         field_unsigned.
 443         * ui-out.h (class ui_out) <field_unsigned>: New method.
 444         <do_field_unsigned>: Likewise.
 445
 446 2019-07-15  Tom Tromey  <tromey@adacore.com>
 447
 448         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 449         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 450         * target.c (flash_erase_command): Use field_string.
 451         * infrun.c (print_signal_received_reason): Use field_string.
 452         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 453         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 454         field_string.
 455         * ada-tasks.c (print_ada_task_info): Use field_string.
 456
 457 2019-07-15  Tom Tromey  <tromey@adacore.com>
 458
 459         * target.c (flash_erase_command): Use field_core_addr.
 460         * symfile.c (generic_load): Use field_core_addr.
 461         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 462         Use field_core_addr.
 463         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 464         field_core_addr.
 465
 466 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 467
 468         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 469         value if its desired type is smaller than a CORE_ADDR and signed.
 470
 471 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 472
 473         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 474         of changes to field names, and use new is_reference field to
 475         decide if a property is a reference or not.
 476         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 477         field.
 478         (struct dwarf2_property_baton): Update header comment, rename
 479         'referenced_type' to 'property_type' and update comments.
 480         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 481         default property type, store in property baton, update to take
 482         accound of renamed field.
 483         (read_func_scope): Update call to attr_to_dynamic_prop.
 484         (read_array_type): Likewise.
 485         (dwarf2_per_cu_addr_sized_int_type): New function.
 486         (read_subrange_index_type): Move type finding code to
 487         dwarf2_per_cu_addr_sized_int_type.
 488         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 489         (dwarf2_per_cu_addr_type): New function.
 490         (set_die_type): Update calls to attr_to_dynamic_prop.
 491
 492 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 493
 494         * dwarf2read.c (read_subrange_index_type): New function.
 495         (read_subrange_type): Move code into new function and call it.
 496         * gdbtypes.c (create_range_type): Add some asserts.
 497
 498 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 499
 500         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 501         update return statements.
 502         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 503         declaration, and update comment to match.
 504         * gdbtypes.c (resolve_dynamic_array): Update call to
 505         dwarf2_evaluate_property to match new return type.
 506
 507 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 508
 509         * valarith.c (value_subscripted_rvalue): Change lowerbound
 510         parameter type from int to LONGEST.
 511         * value.h (value_subscripted_rvalue): Likewise in declaration.
 512
 513 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 514
 515         * cli/cli-utils.c (info_print_command_completer): New function.
 516         * cli/cli-utils.h: Add 'completer.h' include, and forward
 517         declaration for 'struct cmd_list_element'.
 518         (info_print_command_completer): Declare.
 519         * stack.c (_initialize_stack): Add completer for 'info locals' and
 520         'info args'.
 521         * symtab.c (_initialize_symtab): Add completer for 'info
 522         variables' and 'info functions'.
 523         * NEWS: Mention completion for additional info commands.
 524
 525 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 526
 527         * cli/cli-utils.c (extract_info_print_args): Delete.
 528         (extract_arg_maybe_quoted): Delete.
 529         (info_print_options_defs): New variable.
 530         (make_info_print_options_def_group): New function.
 531         (extract_info_print_options): Define new function.
 532         * cli/cli-utils.h (extract_info_print_args): Delete.
 533         (struct info_print_options): New structure.
 534         (extract_info_print_options): Declare new function.
 535         * stack.c (info_locals_command): Update to use new
 536         extract_info_print_options, also add a header comment.
 537         (info_args_command): Likewise.
 538         * symtab.c (info_variables_command): Likewise.
 539         (info_functions_command): Likewise.
 540
 541 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 542
 543         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 544         to extract string arguments.
 545         * common/common-utils.c (extract_string_maybe_quoted): New function.
 546         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 547
 548 2019-07-11  Tom Tromey  <tromey@adacore.com>
 549
 550         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 551         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 552         * top.h (gdbinit): Don't declare.
 553         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 554         into...
 555         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 556         * top.c (gdb_init): Don't call init_cli_cmds.
 557         (gdbinit): Remove.
 558         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 559
 560 2019-07-11  Tom Tromey  <tromey@adacore.com>
 561
 562         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 563         after it has been moved.
 564
 565 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 566
 567         * valops.c (value_must_coerce_to_target): Change return type to
 568         bool.
 569         * value.h (value_must_coerce_to_target): Likewise.
 570
 571 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 572
 573         * breakpoint.c (is_hardware_watchpoint): Remove
 574         forward-declaration.
 575         (is_masked_watchpoint): Change return type to bool.
 576         (is_tracepoint): Likewise.
 577         (is_breakpoint): Likewise.
 578         (is_hardware_watchpoint): Likewise.
 579         (is_watchpoint): Likewise.
 580         (is_no_memory_software_watchpoint): Likewise.
 581         (is_catchpoint): Likewise.
 582         (breakpoint_1): Make FILTER parameter's return type bool.
 583         is_masked_watchpoint): Change return type to bool.
 584         (save_breakpoints): Make FILTER parameter's return type bool.
 585         * breakpoint.h (is_breakpoint): Change return type to bool.
 586         (is_watchpoint): Likewise.
 587         (is_catchpoint): Likewise.
 588         (is_tracepoint): Likewise.
 589
 590 2019-07-10  Tom Tromey  <tom@tromey.com>
 591
 592         * defs.h: Don't include gdbarch.h.
 593         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 594         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 595         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 596         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 597         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 598         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 599         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 600         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 601         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 602         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 603         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 604         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 605         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 606         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 607         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 608         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 609         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 610         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 611         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 612         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 613         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 614         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 615         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 616         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 617         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 618         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 619         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 620
 621 2019-07-10  Tom Tromey  <tromey@adacore.com>
 622
 623         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 624         * breakpoint.c (init_ada_exception_breakpoint): Register as
 625         bp_catchpoint.
 626         (print_one_breakpoint_location, print_one_breakpoint): Use
 627         is_ada_exception_catchpoint.
 628         * ada-lang.c (class ada_catchpoint_location): Pass
 629         bp_loc_software_breakpoint to bp_location constructor.
 630         (is_ada_exception_catchpoint): New function.
 631
 632 2019-07-10  Tom Tromey  <tromey@adacore.com>
 633
 634         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 635         VEC.
 636         (struct arm_exidx_entry): New method operator<.
 637         (struct arm_exidx_data) <section_maps>: Change type.
 638         (arm_exidx_data_free): Remove.
 639         (arm_exidx_data_key): Change type.  Move lower.
 640         (arm_exidx_new_objfile): Update.
 641         (arm_compare_exidx_entries): Remove.
 642         (arm_find_exidx_entry, _initialize_arm_tdep)
 643
 644 2019-07-10  Tom Tromey  <tromey@adacore.com>
 645
 646         * solib-spu.c (ocl_program_data_key): Change type.
 647         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 648         Update.
 649
 650 2019-07-10  Tom Tromey  <tromey@adacore.com>
 651
 652         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 653         (struct solib_aix_inferior_data) <library_list>: Change type.
 654         (solib_aix_inferior_data_handle): Change type.
 655         (get_solib_aix_inferior_data): Update.
 656         (solib_aix_free_library_list): Remove.
 657         (library_list_start_library): Update.
 658         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 659         return type.
 660         (solib_aix_get_library_list)
 661         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 662         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 663
 664 2019-07-10  Tom Tromey  <tromey@adacore.com>
 665
 666         * solib-dsbt.c (struct dsbt_info): Add initializers.
 667         (solib_dsbt_pspace_data): Change type.
 668         (dsbt_pspace_data_cleanup): Remove.
 669         (get_dsbt_info, _initialize_dsbt_solib): Update.
 670
 671 2019-07-10  Tom Tromey  <tromey@adacore.com>
 672
 673         * spu-tdep.c (spu_overlay_data): Change type.
 674         (spu_get_overlay_table, spu_overlay_new_objfile)
 675         (_initialize_spu_tdep): Update.
 676
 677 2019-07-10  Tom Tromey  <tromey@adacore.com>
 678
 679         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 680         destructor.
 681         (dbx_objfile_data_key): Change type and declare later.
 682         (DBX_SYMFILE_INFO): Rewrite.
 683         * dbxread.c (dbx_objfile_data_key): Change type.
 684         (dbx_symfile_init): Update.
 685         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 686         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 687         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 688
 689 2019-07-10  Tom Tromey  <tromey@adacore.com>
 690
 691         * jit.c (jit_program_space_key): Change type.  Move lower.
 692         (get_jit_program_space_data): Update.
 693         (jit_program_space_data_cleanup): Remove.
 694         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 695         Update.
 696         (struct jit_program_space_data): Add initializers.
 697
 698 2019-07-10  Tom Tromey  <tromey@adacore.com>
 699
 700         * solib-darwin.c (struct darwin_info): Add initializers.
 701         (solib_darwin_pspace_data): Change type.
 702         (darwin_pspace_data_cleanup): Remove.
 703         (get_darwin_info, _initialize_darwin_solib): Update.
 704
 705 2019-07-10  Tom Tromey  <tromey@adacore.com>
 706
 707         * remote-sim.c (struct sim_inferior_data): Add initializers,
 708         constructor, and destructor.
 709         (sim_inferior_data_key): Change type.  Move lower.
 710         (check_for_duplicate_sim_descriptor): Update.
 711         (get_sim_inferior_data): Use new.  Update.
 712         (~sim_inferior_data_cleanup): Rename from
 713         sim_inferior_data_cleanup.  Simplify.
 714         (gdbsim_close_inferior, simulator_command)
 715         (sim_command_completer, _initialize_remote_sim): Update.
 716         (next_pid, INITIAL_PID): Move earlier.
 717
 718 2019-07-10  Tom Tromey  <tromey@adacore.com>
 719
 720         * python/python-internal.h (create_thread_object): Return
 721         gdbpy_ref.
 722         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 723         * python/py-inferior.c (struct threadlist_entry): Add
 724         constructor.
 725         <thread_obj>: Now a gdbpy_ref.
 726         (thread_to_thread_object): Update.
 727         (add_thread_object): Use new.
 728         (delete_thread_object): Use delete.
 729         (infpy_threads): Update.
 730         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 731         GIL.
 732
 733 2019-07-10  Tom Tromey  <tromey@adacore.com>
 734
 735         * valops.c (value_cast): Specialize error message for Ada.
 736
 737 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 738
 739         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 740
 741 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 742
 743         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 744         bpstat_should_step): Return bool, adjust comments.
 745         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 746         bpstat_should_step): Likewise.
 747
 748 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 749
 750         * features/Makefile: Use feature target descriptions for Arm.
 751         * features/arm/arm-core.c: Generate new file.
 752         * features/arm/arm-fpa.c: Likewise.
 753         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 754         * features/arm/arm-m-profile.c: Likewise.
 755         * features/arm/arm-vfpv2.c: Likewise.
 756         * features/arm/arm-vfpv3.c: Likewise.
 757         * features/arm/xscale-iwmmxt.c: Likewise.
 758         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 759
 760 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 761
 762         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 763         ptrace earlier.
 764
 765 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 766
 767         * features/aarch64-pauth.c: Regenerate.
 768
 769 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 770
 771         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 772         bool.
 773         (bpstat_what): Use false instead of 0.
 774
 775 2019-07-09  Pedro Alves  <palves@redhat.com>
 776
 777         * break-catch-throw.c (is_exception_catchpoint): New.
 778         * breakpoint.c (print_one_breakpoint_location): New parameter
 779         'raw_loc'.  Handle it.  Use
 780         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 781         looking at the breakpoint's type.
 782         (print_one_breakpoint): If handling "maint info breakpoints", also
 783         print locations of exception catchpoints.
 784         * breakpoint.h (is_exception_catchpoint): Declare.
 785
 786 2019-07-09  Pedro Alves  <palves@redhat.com>
 787
 788         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 789         "addr" field.
 790         (allocate_location_exception_catchpoint): New.
 791         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 792         (initialize_throw_catchpoint_ops): Install
 793         allocate_location_exception_catchpoint as allocate_location
 794         method.
 795         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 796         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 797         bp_loc_other.
 798         (breakpoint_address_is_meaningful): Delete.
 799         (bl_address_is_meaningful): New.
 800         (breakpoint_locations_match): Adjust comment.
 801         (bp_location_from_bp_type): New, factored out of...
 802         (bp_location::bp_location(breakpoint *)): ... this.
 803         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 804         factored out of...
 805         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 806         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 807         breakpoint_address_is_meaningful.
 808         (bp_locations_compare): Adjust comment.
 809         (update_global_location_list): Use bl_address_is_meaningful
 810         instead of breakpoint_address_is_meaningful.
 811         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 812         explicit.
 813         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 814         * python/py-breakpoint.c (bppy_get_location): No longer check
 815         whether location is null.
 816
 817 2019-07-09  Pedro Alves  <palves@redhat.com>
 818
 819         PR c++/15468
 820         * breakpoint.c (print_one_breakpoint_location): Remove
 821         single-location assert.
 822
 823 2019-07-09  Tom Tromey  <tom@tromey.com>
 824
 825         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 826         * configure: Rebuild.
 827         * configure.ac: Change common to gdbsupport.
 828         * gdbsupport: Rename from common.
 829         * acinclude.m4: Change common to gdbsupport.
 830         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 831         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 832         gdbsupport.
 833         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 834         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 835         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 836         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 837         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 838         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 839         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 840         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 841         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 842         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 843         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 844         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 845         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 846         coff-pe-read.c, command.h, compile/compile-c-support.c,
 847         compile/compile-c.h, compile/compile-cplus-symbols.c,
 848         compile/compile-cplus-types.c, compile/compile-cplus.h,
 849         compile/compile-loc2c.c, compile/compile.c, completer.c,
 850         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 851         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 852         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 853         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 854         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 855         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 856         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 857         features/aarch64-core.c, features/aarch64-fpu.c,
 858         features/aarch64-pauth.c, features/aarch64-sve.c,
 859         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 860         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 861         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 862         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 863         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 864         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 865         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 866         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 867         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 868         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 869         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 870         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 871         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 872         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 873         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 874         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 875         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 876         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 877         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 878         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 879         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 880         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 881         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 882         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 883         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 884         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 885         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 886         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 887         minsyms.c, mips-linux-tdep.c, namespace.h,
 888         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 889         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 890         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 891         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 892         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 893         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 894         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 895         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 896         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 897         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 898         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 899         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 900         procfs.c, producer.c, progspace.h, psymtab.h,
 901         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 902         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 903         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 904         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 905         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 906         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 907         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 908         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 909         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 910         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 911         target-memory.c, target.c, target.h, target/waitstatus.c,
 912         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 913         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 914         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 915         unittests/array-view-selftests.c,
 916         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 917         unittests/common-utils-selftests.c,
 918         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 919         unittests/format_pieces-selftests.c,
 920         unittests/function-view-selftests.c,
 921         unittests/lookup_name_info-selftests.c,
 922         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 923         unittests/mkdir-recursive-selftests.c,
 924         unittests/observable-selftests.c,
 925         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 926         unittests/parse-connection-spec-selftests.c,
 927         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 928         unittests/scoped_fd-selftests.c,
 929         unittests/scoped_mmap-selftests.c,
 930         unittests/scoped_restore-selftests.c,
 931         unittests/string_view-selftests.c, unittests/style-selftests.c,
 932         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 933         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 934         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 935         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 936         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 937         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 938
 939 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 942         bool value.
 943         (decode_digits_ordinary): Set explicit_line field in sal.
 944         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 945         symtab_and_line that was set on an explicit line number in
 946         assembler code.  Do always update the recorded symtab and line if
 947         we do skip the prologue.
 948
 949 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 950
 951         * breakpoint.c (set_breakpoint_location_function): Remove
 952         explicit_loc parameter.
 953         (momentary_breakpoint_from_master): Update call to
 954         set_breakpoint_location_function.
 955         (add_location_to_breakpoint): Likewise.
 956
 957 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 958
 959         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 960         required features based on default bfd type when no specific bfd
 961         is present.
 962
 963 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 964
 965         * NEWS: Mention that GDB printf and eval commands can now print
 966         C-style and Ada-style convenience var strings without
 967         calling the inferior.
 968         * printcmd.c (printf_c_string): Locally print GDB internal var
 969         instead of transiting via the inferior.
 970         (printf_wide_c_string): Likewise.
 971
 972 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 973
 974         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 975
 976 2019-07-04  Tom Tromey  <tom@tromey.com>
 977
 978         PR tui/24724:
 979         * tui/tui-winsource.c (tui_clear_source_content): Update.
 980         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 981         (tui_update_breakpoint_info): Update.
 982         (tui_set_exec_info_content): Update.
 983         * tui/tui-source.c (tui_set_source_content_nil): Update.
 984         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 985         has_break.
 986         * tui/tui-data.h (enum tui_bp_flag): New.
 987         (tui_bp_flags): New enum flags type.
 988         (struct tui_source_element) <break_mode>: Change type.  Rename
 989         from has_break.
 990         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 991         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 992         constants.
 993         * tui/tui-winsource.h: Fix comment.
 994
 995 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 996
 997         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 998         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 999         (store_fpregs_to_thread)
1000         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1001         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1002         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1003         (IWMMXT_REGS_SIZE): Add define.
1004         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1005         (fetch_vfp_regs, store_vfp_regs)
1006         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1007         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1008
1009 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1010
1011         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1012         defines.
1013         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1014         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1015         (ARM_INT_REGISTER_SIZE): ...to this.
1016         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1017         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1018         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1019         (arm_linux_collect_gregset, supply_nwfpe_register)
1020         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1021         defines.
1022         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1023         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1024         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1025         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1026         (arm_return_in_memory, arm_store_return_value)
1027         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1028         (arm_record_ld_st_multiple): Likewise.
1029         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1030         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1031
1032 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1033
1034         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1035         AARCH64_DISPLACED_MODIFIED_INSNS.
1036         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1037         (aarch64_displaced_step_copy_insn): Likewise.
1038         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1039         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1040         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1041         ARM_DISPLACED_MODIFIED_INSNS.
1042         * arm-tdep.c (arm_gdbarch_init): Likewise.
1043         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1044         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1045         (struct arm_displaced_step_closure): Use
1046         ARM_DISPLACED_MODIFIED_INSNS.
1047
1048 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1049
1050         * features/Makefile: Remove unused xml files.
1051         * features/aarch64.xml: Remove.
1052         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1053         * features/i386/amd64-avx-avx512.xml: Remove.
1054         * features/i386/amd64-avx-linux.xml: Remove.
1055         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1056         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1057         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1058         * features/i386/amd64-avx-mpx.xml: Remove.
1059         * features/i386/amd64-avx.xml: Remove.
1060         * features/i386/amd64-linux.xml: Remove.
1061         * features/i386/amd64-mpx-linux.xml: Remove.
1062         * features/i386/amd64-mpx.xml: Remove.
1063         * features/i386/amd64.xml: Remove.
1064         * features/i386/i386-avx-avx512-linux.xml: Remove.
1065         * features/i386/i386-avx-avx512.xml: Remove.
1066         * features/i386/i386-avx-linux.xml: Remove.
1067         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1068         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1069         * features/i386/i386-avx-mpx-linux.xml: Remove.
1070         * features/i386/i386-avx-mpx.xml: Remove.
1071         * features/i386/i386-avx.xml: Remove.
1072         * features/i386/i386-linux.xml: Remove.
1073         * features/i386/i386-mmx-linux.xml: Remove.
1074         * features/i386/i386-mmx.xml: Remove.
1075         * features/i386/i386-mpx-linux.xml: Remove.
1076         * features/i386/i386-mpx.xml: Remove.
1077         * features/i386/i386.xml: Remove.
1078         * features/i386/x32-avx-avx512-linux.xml: Remove.
1079         * features/i386/x32-avx-linux.xml: Remove.
1080         * features/i386/x32-linux.xml: Remove.
1081
1082 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1083
1084         * regformats/aarch64.dat: Remove.
1085         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1086         * regformats/i386/amd64-avx-linux.dat: Remove.
1087         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1088         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1089         * regformats/i386/amd64-linux.dat: Remove.
1090         * regformats/i386/amd64-mpx-linux.dat: Remove.
1091         * regformats/i386/amd64.dat: Remove.
1092         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1093         * regformats/i386/i386-avx-linux.dat: Remove.
1094         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1095         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1096         * regformats/i386/i386-linux.dat: Remove.
1097         * regformats/i386/i386-mmx-linux.dat: Remove.
1098         * regformats/i386/i386-mpx-linux.dat: Remove.
1099         * regformats/i386/i386.dat: Remove.
1100         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1101         * regformats/i386/x32-avx-linux.dat: Remove.
1102         * regformats/i386/x32-linux.dat: Remove.
1103
1104 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1105
1106         * aarch64-tdep.c: Remove xml self tests.
1107         * amd64-linux-tdep.c: Likewise.
1108         * amd64-tdep.c: Likewise.
1109         * i386-linux-tdep.c: Likewise.
1110         * i386-tdep.c: Likewise.
1111
1112 2019-07-03  Pedro Alves  <palves@redhat.com>
1113
1114         PR cli/24732
1115         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1116         (pipe_cmd_option_defs): New.
1117         (make_pipe_cmd_options_def_group): New.
1118         (pipe_command): Use gdb::option::process_options.
1119         (pipe_command_completer): New function.
1120         (_initialize_cli_cmds): Install completer for "pipe" command.
1121
1122 2019-07-03  Pedro Alves  <palves@redhat.com>
1123
1124         * cli/cli-option.c (union option_value) <string>: New field.
1125         (struct option_def_and_value): Add ctor, move ctor, dtor and
1126         use DISABLE_COPY_AND_ASSIGN.
1127         (option_def_and_value::clear_value): New.
1128         (parse_option, save_option_value_in_ctx, get_val_type_str)
1129         (add_setshow_cmds_for_options): Handle var_string.
1130         * cli-option.h (union option_def::var_address) <string>: New
1131         field.
1132         (struct string_option_def): New.
1133         * maint-test-options.c (struct test_options_opts): Add default
1134         ctor and use DISABLE_COPY_AND_ASSIGN.
1135         <string_opt>: New field.
1136         (test_options_opts::~test_options_opts): New.
1137         (test_options_opts::dump): Also dump "-string".
1138         (test_options_option_defs): Install "string.
1139
1140 2019-07-03  Pedro Alves  <palves@redhat.com>
1141
1142         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1143         option_value with a null enumeration.
1144         (complete_options): Save the option values in the context.
1145         (save_option_value_in_ctx): New, factored out from ...
1146         (process_options): ... here.
1147         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1148         of the function.
1149         * maint-test-options.c (test_options_opts::dump): New, factored
1150         out from ...
1151         (maintenance_test_options_command_mode): ... here.
1152         (maintenance_test_options_command_completion_result): Delete.
1153         (maintenance_test_options_command_completion_text): Update
1154         comment.
1155         (maintenance_show_test_options_completion_result): Change
1156         prototype.  Just print
1157         maintenance_test_options_command_completion_text.
1158         (save_completion_result): New.
1159         (maintenance_test_options_completer_mode): Pass options context to
1160         complete_options, and then save a dump.
1161         (_initialize_maint_test_options): Use add_cmd to install "maint
1162         show test-options-completion-result".
1163
1164 2019-07-03  Pedro Alves  <palves@redhat.com>
1165
1166         * NEWS (New commands): Mention "with" and "maint with".
1167         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1168         (with_command, with_command_completer): New.
1169         (pipe_command): Adjust to new repeat_previous
1170         interface.
1171         (_initialize_cli_cmds): Install the "with" command and its "w"
1172         alias.
1173         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1174         declarations.
1175         * cli/cli-setshow.c (parse_cli_var_uinteger)
1176         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1177         argument strings for all var_types.
1178         (get_setshow_command_value_string): New, factored out from ...
1179         (do_show_command): ... this.
1180         * cli/cli-setshow.h: Include <string>.
1181         (get_setshow_command_value_string): Declare.
1182         * command.h (repeat_previous): Now returns const char *.  Adjust
1183         comment.
1184         * maint.c: Include "cli/cli-cmds.h".
1185         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1186         (_initialize_maint_cmds): Register the "maintenance with" command.
1187         * top.c (repeat_previous): Move bits from pipe_command here:
1188         Return the saved command line, if any; error out if there's no
1189         command to relaunch.
1190
1191 2019-07-03  Pedro Alves  <palves@redhat.com>
1192
1193         * NEWS (New commands): Mention "maint set/show test-settings"
1194         instead of "maint test-settings".
1195         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1196         (maintenance_test_settings_set_list): Rename to ...
1197         (maintenance_set_test_settings_list): ... this.
1198         (maintenance_test_settings_show_list): Rename to  ...
1199         (maintenance_show_test_settings_list): ... this.
1200         (maintenance_test_settings_cmd): Delete.
1201         (maintenance_test_settings_set_cmd): ...
1202         (maintenance_set_test_settings_cmd): ... this.
1203         (maintenance_test_settings_show_cmd): ...
1204         (maintenance_show_test_settings_cmd): ... this.
1205         (maintenance_test_settings_show_value_cmd):
1206         (maintenance_show_test_settings_value_cmd): ... this.
1207         (_initialize_maint_test_settings): No longer install the "maint
1208         test-settings" prefix command.  Rename "maint test-settings set"
1209         to "maint set test-settings", and "maint test-settings show" to
1210         "maint show test-settings".  Adjust all subcommands.
1211
1212 2019-07-03  Pedro Alves  <palves@redhat.com>
1213
1214         * maint-test-settings.c: Fix file's intro comment.  Replace all
1215         references to "test-options" with references to "test-settings",
1216         in comments.
1217
1218 2019-07-03  Pedro Alves  <palves@redhat.com>
1219
1220         * maint-test-settings.c (maintenance_test_settings_xxx)
1221         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1222         New.
1223         (maintenance_test_settings_enums): Use them.
1224         (maintenance_test_settings_enum): Default to
1225         maintenance_test_settings_xxx.
1226         (_initialize_maint_test_settings): Initialize
1227         MAINTENANCE_TEST_SETTINGS_FILENAME.
1228
1229 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1230
1231         * breakpoint.h (remove_breakpoints_inf): Change return type to
1232         void, move function documentation here.
1233         * breakpoint.c (remove_breakpoints_inf): Change return type to
1234         void, move function documentation to header.
1235
1236 2019-07-02  Pedro Alves  <palves@redhat.com>
1237
1238         * NEWS (Completion improvements): Mention "info threads".
1239         * thread.c (struct info_threads_opts, info_threads_option_defs)
1240         (make_info_threads_options_def_group): New.
1241         (info_threads_command): Use gdb::option::process_options.
1242         (info_threads_command_completer): New.
1243         (_initialize_thread): Use gdb::option::build_help to build the
1244         help text for "info threads".
1245
1246 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1247
1248         * defs.h (generic_load): Move from here...
1249         * symfile.h (generic_load): ... to here.  Rename name parameter
1250         to args.
1251         * symfile.c (generic_load): Add comment.
1252
1253 2019-07-01  Tom Tromey  <tromey@adacore.com>
1254
1255         * dwarf2read.c
1256         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1257         declaration of without_params.  Fix formatting.
1258
1259 2019-07-01  Tom Tromey  <tromey@adacore.com>
1260
1261         * ada-exp.y (find_primitive_type): Update.
1262         * ada-lang.h (ada_lookup_symbol): Update.
1263         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1264         parameter.
1265         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1266
1267 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1268
1269         PR breakpoints/24541
1270         * gdbarch.c: Regenerate.
1271         * gdbarch.h: Regenerate.
1272         * gdbarch.sh: Add 'stap_adjust_register'.
1273         * i386-tdep.c: Include '<unordered_set>'.
1274         (i386_stap_adjust_register): New function.
1275         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1276         * stap-probe.c (stap_parse_register_operand): Call
1277         'gdbarch_stap_adjust_register'.
1278
1279 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1280
1281         PR python/24742
1282         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1283         * python/python.c (do_start_initialization): Use 'xmalloc'
1284         instead of 'PyMem_Malloc'.
1285
1286 2019-06-28  Tom Tromey  <tromey@adacore.com>
1287
1288         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1289         for Ada.
1290
1291 2019-06-27  Tom Tromey  <tromey@adacore.com>
1292
1293         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1294         objfile_key.
1295         (arm_find_mapping_symbol, arm_record_special_symbol)
1296         (_initialize_arm_tdep): Update.
1297         (arm_objfile_data_free): Remove.
1298
1299 2019-06-27  Tom Tromey  <tromey@adacore.com>
1300
1301         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1302         to cp_print_static_field.
1303
1304 2019-06-26  Tom Tromey  <tromey@adacore.com>
1305
1306         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1307         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1308         declare.
1309
1310 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1311
1312         * features/aarch64-core.c (create_feature_aarch64_core):
1313         Regenerate.
1314         * features/aarch64-core.xml: Add cpsr flags.
1315
1316 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1317
1318         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1319         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1320
1321 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1322
1323         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1324         field.
1325         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1326         use.
1327         (arm_record_special_symbol): Don't insert new symbol in sorted
1328         position, push it at the end.
1329
1330 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1331
1332         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1333         (arm_mapping_symbol_s): Remove.
1334         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1335         (arm_mapping_symbol_vec): New typedef.
1336         (struct arm_per_objfile): Add constructor.
1337         <section_maps>: Change type to
1338         std::unique_ptr<arm_mapping_symbol_vec[]>.
1339         (arm_compare_mapping_symbols): Remove.
1340         (arm_find_mapping_symbol): Adjust to section_maps type change.
1341         (arm_objfile_data_free): Call delete on arm_per_objfile.
1342         (arm_record_special_symbol): Adjust to section_maps type change.
1343         Allocate arm_per_objfile with new.
1344
1345 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1346
1347         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1348         with the command prefix.
1349
1350 2019-06-25  Tom Tromey  <tom@tromey.com>
1351
1352         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1353         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1354
1355 2019-06-25  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1358         type.
1359         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1360         protected.
1361
1362 2019-06-25  Tom Tromey  <tom@tromey.com>
1363
1364         * tui/tui-winsource.c
1365         (tui_source_window_base::set_is_exec_point_at): Add check against
1366         LOA_ADDRESS.
1367
1368 2019-06-25  Tom Tromey  <tom@tromey.com>
1369
1370         * tui/tui-source.c (tui_set_source_content): Don't check before
1371         xfree.
1372         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1373
1374 2019-06-25  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-winsource.h (tui_update_source_window_as_is)
1377         (tui_alloc_source_buffer, tui_line_is_displayed)
1378         (tui_addr_is_displayed): Change type of win_info.
1379         * tui/tui-winsource.c (tui_update_source_window_as_is)
1380         (tui_clear_source_content, tui_show_source_line)
1381         (tui_show_source_content, tui_source_window_base::refill)
1382         (tui_source_window_base::set_is_exec_point_at)
1383         (tui_source_window_base::set_is_exec_point_at)
1384         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1385         (tui_alloc_source_buffer, tui_line_is_displayed)
1386         (tui_addr_is_displayed): Change type of win_info.  Update.
1387         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1388         (tui_source_window_base::do_make_visible_with_new_height):
1389         Update.
1390         * tui/tui-source.c (tui_set_source_content)
1391         (tui_set_source_content_nil)
1392         (tui_source_window::do_scroll_vertical): Update.
1393         * tui/tui-layout.c (show_layout): Update.
1394         * tui/tui-disasm.c (tui_set_disassem_content)
1395         (tui_disasm_window::do_scroll_vertical): Update.
1396         * tui/tui-data.h (tui_win_content): Remove.
1397         (struct tui_gen_win_info) <content, content_size>: Remove.
1398         (struct tui_source_element): Add initializers and destructor.
1399         (union tui_which_element, struct tui_win_element): Remove.
1400         (struct tui_source_window_base) <content>: New field.
1401         (struct tui_data_window): Remove destructor.
1402         (tui_alloc_content, tui_free_win_content)
1403         (tui_free_all_source_wins_content): Don't declare.
1404         * tui/tui-data.c (tui_initialize_static_data): Update.
1405         (init_content_element, tui_alloc_content): Remove.
1406         (~tui_gen_win_info): Update.
1407         (~tui_data_window, tui_free_all_source_wins_content)
1408         (tui_free_win_content, free_content, free_content_elements):
1409         Remove.
1410
1411 2019-06-25  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-winsource.h (tui_clear_source_content)
1414         (tui_erase_source_content, tui_show_source_content): Change type
1415         of win_info.
1416         * tui/tui-winsource.c (tui_clear_source_content)
1417         (tui_erase_source_content, tui_show_source_content): Change type
1418         of win_info.
1419         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1420         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1421         win_info.
1422         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1423         win_info.
1424         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-winsource.c (tui_clear_source_content)
1429         (tui_source_window_base::set_is_exec_point_at): Update.
1430         * tui/tui-source.c (tui_set_source_content_nil): Update.
1431         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1432         a bool.
1433         * tui/tui-data.c (init_content_element): Update.
1434
1435 2019-06-25  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1438         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1439         * tui/tui-layout.c (init_and_make_win): Update.
1440         * tui/tui.h (enum tui_win_type): Update.
1441         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1442         tui_win_is_auxillary.
1443         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1444         tui_win_is_auxillary.
1445
1446 2019-06-25  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1449         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1450         (tui_delete_data_content_windows, tui_display_all_data)
1451         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1452         Update.
1453         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1454         * tui/tui-regs.c (tui_last_regs_line_no)
1455         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1456         (tui_show_registers): Update.
1457         (tui_show_register_group): Return void.  Update.
1458         (tui_display_registers_from, tui_display_reg_element_at_line)
1459         (tui_display_registers_from_line, tui_check_register_values):
1460         Update.
1461         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1462         member.
1463         (struct tui_data_window) <regs_content>: Now a std::vector.
1464         <regs_content_count>: Remove.
1465         (tui_add_content_elements, tui_free_data_content): Don't declare.
1466         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1467         (init_content_element): Remove DATA_WIN case.  Add assert.
1468         (tui_add_content_elements): Remove.
1469         (tui_data_window): Update.
1470         (tui_free_data_content): Remove.
1471         (free_content_elements): Remove DATA_WIN case.
1472
1473 2019-06-25  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-data.c (tui_data_item_window): Update.
1476         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1477         * tui/tui-windata.c (tui_display_all_data)
1478         (tui_display_data_from_line): Update.
1479         (tui_check_data_values): Remove.
1480         * tui/tui-regs.c (tui_show_register_group)
1481         (tui_display_reg_element_at_line): Update.
1482         * tui/tui-hooks.c (tui_register_changed)
1483         (tui_refresh_frame_and_register_information): Call
1484         tui_check_register_values.
1485         * tui/tui-data.h (struct tui_data_window) <data_content,
1486         data_content_count, data_type>: Remove.
1487         (enum tui_data_type): Remove.
1488
1489         * tui/tui-data.c (tui_data_window::clear_detail)
1490         (~tui_data_window): Update.
1491
1492 2019-06-25  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1495         declare.
1496         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1497         Rename from tui_first_data_item_displayed.  Update.
1498         (tui_data_window::refresh_all)
1499         (tui_data_window::do_scroll_vertical): Update.
1500         * tui/tui-data.h (struct tui_data_window)
1501         <first_data_item_displayed>: Declare new method.
1502
1503 2019-06-25  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1506         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1507         contents...
1508         (tui_initialize_static_data): ...here.
1509
1510 2019-06-25  Tom Tromey  <tom@tromey.com>
1511
1512         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1513         (tui_display_registers_from, tui_check_register_values): Update.
1514         (tui_display_register): Remove win_info parameter; update.
1515         (tui_get_register): Change type of parameters.
1516         * tui/tui-data.h (struct tui_data_element): Remove.
1517         (union tui_which_element) <data>: Remove.
1518         <data_window>: Change type.
1519         (struct tui_data_item_window): New.
1520         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1521         case.  Add assert.
1522         (~tui_data_item_window): New destructor.
1523         (free_content_elements): Remove DATA_ITEM_WIN case.
1524
1525 2019-06-25  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1528         Remove.
1529
1530 2019-06-25  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-data.h (struct tui_command_element): Remove.
1533         (union tui_which_element) <command>: Remove.
1534         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1535         assert.
1536         (free_content_elements): Remove CMD_WIN case.
1537
1538 2019-06-25  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-layout.c (tui_set_layout): Update.
1541         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1542         * tui/tui-data.c (layout_def): Update.
1543
1544 2019-06-25  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1547         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1548         (tui_source_window_base::set_new_height): Update.
1549         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1550         Update.
1551         (tui_set_locator_fullname, tui_set_locator_info)
1552         (tui_show_frame_info): Update.
1553         * tui/tui-source.c (tui_set_source_content)
1554         (tui_source_is_displayed): Update.
1555         * tui/tui-layout.c (show_source_disasm_command, show_data)
1556         (show_source_or_disasm_and_command): Update.
1557         * tui/tui-disasm.c (tui_set_disassem_content)
1558         (tui_get_begin_asm_address): Update.
1559         * tui/tui-data.h (struct tui_locator_element): Remove.
1560         (union tui_which_element) <locator>: Remove.
1561         (struct tui_locator_window): New.
1562         (tui_locator_win_info_ptr): Change return type.
1563         * tui/tui-data.c (_locator): Change type.
1564         (tui_locator_win_info_ptr): Change return type.
1565         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1566         (tui_alloc_content): Add assert.
1567
1568 2019-06-25  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-winsource.c
1571         (tui_exec_info_window::maybe_allocate_content): New method.
1572         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1573         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1574         (make_source_or_disasm_window): Add cast.
1575         * tui/tui-data.h (union tui_which_element) <simple_string>:
1576         Remove.
1577         (struct tui_source_info): New.
1578         (struct tui_source_window_base) <execution_info>: Change type.
1579         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1580         case, and add assert.
1581         (tui_alloc_content): Add assert.
1582
1583 2019-06-25  Tom Tromey  <tom@tromey.com>
1584
1585         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1586         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1587         * tui/tui-data.c (tui_alloc_win_info): Remove.
1588
1589 2019-06-25  Tom Tromey  <tom@tromey.com>
1590
1591         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1592         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1593         can_highlight.
1594
1595 2019-06-25  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1598         make_visible_with_new_height method.
1599         (tui_win_info::make_visible_with_new_height): New method.
1600         (tui_source_window_base::do_make_visible_with_new_height)
1601         (tui_data_window::do_make_visible_with_new_height)
1602         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1603         (make_visible_with_new_height): Remove.
1604         (tui_resize_all, tui_adjust_win_heights): Use
1605         make_visible_with_new_height method.
1606         * tui/tui-data.h (struct tui_win_info)
1607         <do_make_visible_with_new_height, make_visible_with_new_height>:
1608         New methods.
1609         (struct tui_source_window_base, struct tui_data_window)
1610         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1611         methods.
1612
1613 2019-06-25  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1616         method.
1617         (update_tab_width): Call update_tab_width method.
1618         * tui/tui-data.h (struct tui_win_info)
1619         (struct tui_source_window_base) <update_tab_width>: New methods.
1620
1621 2019-06-25  Tom Tromey  <tom@tromey.com>
1622
1623         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1624         parameter.
1625         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1626         parameter.
1627         (tui_gen_win_info::make_visible): Update.
1628         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1629         parameter.
1630         * tui/tui-data.h (enum tui_box): New enum.
1631         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1632
1633 2019-06-25  Tom Tromey  <tom@tromey.com>
1634
1635         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1636         init_and_make_win for EXEC_INFO_WIN.
1637         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1638         longer inline.
1639         (struct tui_win_info) <~tui_win_info>: Inline.
1640         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1641         Don't declare.
1642         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1643         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1644         Remove.
1645         (tui_initialize_static_data): Update.
1646         (~tui_gen_win_info): Handle more cleanup here.
1647         (~tui_source_window_base): Delete "execution_info".
1648         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1649
1650 2019-06-25  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-layout.c (make_command_window): Don't set
1653         can_highlight.
1654         (show_source_disasm_command): Call the reset method.
1655         (show_data): Don't set can_highlight.  Call the reset method.
1656         (tui_gen_win_info::reset): Rename from init_gen_win_info
1657         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1658         (show_source_or_disasm_and_command): Call the reset method.
1659         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1660         (struct tui_cmd_window): Set can_highlight.
1661
1662 2019-06-25  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1665         from make_visible.
1666         (tui_make_visible, tui_make_invisible): Rewrite.
1667         (tui_win_info::make_visible): Remove.
1668         (tui_source_window_base::make_visible): Update.
1669         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1670         method.  Moved from...
1671         (struct tui_win_info) <make_visible>: ...here.
1672
1673 2019-06-25  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui-winsource.c
1676         (tui_source_window_base::do_scroll_horizontal): Remove direction
1677         parameter.
1678         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1679         direction parameter.
1680         * tui/tui-win.c (tui_win_info::forward_scroll)
1681         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1682         (tui_win_info::right_scroll): Update.
1683         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1684         direction parameter.
1685         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1686         direction parameter.
1687         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1688         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1689         Remove direction parameter.
1690         (struct tui_source_window_base, struct tui_source_window)
1691         (struct tui_disasm_window, struct tui_data_window)
1692         (struct tui_cmd_window): Update.
1693
1694 2019-06-25  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-winsource.h (tui_set_exec_info_content)
1697         (tui_show_exec_info_content, tui_erase_exec_info_content)
1698         (tui_clear_exec_info_content, tui_update_exec_info): Change
1699         argument to tui_source_window_base.
1700         * tui/tui-winsource.c (tui_set_exec_info_content)
1701         (tui_show_exec_info_content, tui_erase_exec_info_content)
1702         (tui_clear_exec_info_content, tui_update_exec_info): Change
1703         argument to tui_source_window_base.
1704
1705 2019-06-25  Tom Tromey  <tom@tromey.com>
1706
1707         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1708         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1709
1710 2019-06-25  Tom Tromey  <tom@tromey.com>
1711
1712         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1713         check.
1714
1715 2019-06-25  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1718         type to void.
1719         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1720         type to void.
1721         * tui/tui-source.c (tui_set_source_content): Update.
1722         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1723
1724 2019-06-25  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-win.c (window_name_completer, tui_set_focus)
1727         (tui_all_windows_info): Use name method.
1728         * tui/tui-data.h (struct tui_gen_win_info)
1729         (struct tui_source_window, struct tui_disasm_window)
1730         (struct tui_data_window, struct tui_cmd_window) <name>: New
1731         method.
1732         (tui_win_name): Don't declare.
1733         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1734         (tui_win_name): Remove.
1735
1736 2019-06-25  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-winsource.h (tui_update_source_window)
1739         (tui_update_source_window_as_is): Change parameter type.
1740         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1741         to be a tui_source_window_base.
1742         (tui_update_source_window_as_is): Likewise.
1743         * tui/tui-win.c (make_visible_with_new_height): Update.
1744
1745 2019-06-25  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-winsource.c (tui_erase_source_content)
1748         (tui_show_source_content, tui_show_exec_info_content)
1749         (tui_erase_exec_info_content): Use refresh_window method.
1750         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1751         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1752         from tui_refresh_win.
1753         (tui_data_window::refresh_window): New method.
1754         (tui_win_info::refresh, tui_source_window_base::refresh)
1755         (tui_refresh_all): Use refresh_window method.
1756         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1757         method.
1758         * tui/tui-regs.c (tui_display_register): Call refresh_window
1759         method.
1760         * tui/tui-layout.c (show_source_disasm_command)
1761         (show_source_or_disasm_and_command): Call refresh_window method.
1762         * tui/tui-data.h (struct tui_gen_win_info)
1763         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1764         New method.
1765
1766 2019-06-25  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui.c (tui_rl_other_window, tui_enable)
1769         (tui_is_window_visible, tui_get_command_dimension): Update.
1770         * tui/tui-winsource.c (tui_update_source_window_as_is)
1771         (tui_clear_source_content, tui_erase_source_content)
1772         (tui_show_source_line, tui_source_window_base::refill)
1773         (tui_source_window_base::do_scroll_horizontal)
1774         (tui_source_window_base::set_is_exec_point_at)
1775         (tui_update_breakpoint_info, tui_set_exec_info_content)
1776         (tui_alloc_source_buffer, tui_line_is_displayed)
1777         (tui_addr_is_displayed): Update.
1778         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1779         (tui_check_and_display_highlight_if_needed)
1780         (tui_win_info::make_visible, tui_win_info::refresh)
1781         (tui_refresh_all): Update.
1782         * tui/tui-windata.c (tui_first_data_item_displayed)
1783         (tui_delete_data_content_windows, tui_erase_data_content)
1784         (tui_display_all_data, tui_data_window::refresh_all)
1785         (tui_check_data_values): Update.
1786         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1787         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1788         (tui_win_info::backward_scroll, tui_refresh_all_win)
1789         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1790         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1791         (tui_source_window_base::set_new_height)
1792         (tui_data_window::set_new_height)
1793         (make_invisible_and_set_new_height)
1794         (make_visible_with_new_height, new_height_ok)
1795         (parse_scrolling_args): Update.
1796         * tui/tui-stack.c (tui_show_frame_info): Update.
1797         * tui/tui-source.c (tui_set_source_content)
1798         (tui_set_source_content_nil, tui_source_is_displayed)
1799         (tui_source_window::do_scroll_vertical): Update.
1800         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1801         (tui_display_registers_from, tui_display_reg_element_at_line)
1802         (tui_check_register_values, tui_reg_command): Update.
1803         * tui/tui-layout.c (tui_default_win_height)
1804         (show_source_disasm_command, show_data, init_and_make_win)
1805         (show_source_or_disasm_and_command): Update.
1806         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1807         (tui_redisplay_readline, tui_mld_flush)
1808         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1809         (tui_getc): Update.
1810         * tui/tui-disasm.c (tui_set_disassem_content)
1811         (tui_disasm_window::do_scroll_vertical): Update.
1812         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1813         Now virtual.
1814         (struct tui_win_info): Derive from tui_gen_win_info.
1815         <~tui_win_info>: Mark as override.
1816         <generic>: Remove member.
1817         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1818         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1819         (~tui_data_window, ~tui_win_info)
1820         (tui_free_all_source_wins_content): Update.
1821         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1822
1823 2019-06-25  Tom Tromey  <tom@tromey.com>
1824
1825         * tui/tui-layout.c (init_and_make_win): Use new.
1826         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1827         destructor, initializers.
1828         (tui_alloc_generic_win_info): Don't declare.
1829         * tui/tui-data.c (_locator): Add argument to constructor.
1830         (source_win, disasm_win): New globals.
1831         (exec_info): Remove.
1832         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1833         Update.
1834         (tui_alloc_generic_win_info): Remove.
1835         (init_content_element): Use new.
1836         (tui_win_info::tui_win_info): Update.
1837         (free_content_elements) <case DATA_WIN>: Use delete.
1838
1839 2019-06-25  Tom Tromey  <tom@tromey.com>
1840
1841         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1842         * tui/tui-windata.c (tui_first_data_item_displayed)
1843         (tui_delete_data_content_windows): Update.
1844         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1845         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1846         (tui_display_registers_from, tui_check_register_values): Update.
1847         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1848         pointer.
1849         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1850         window.
1851         (tui_free_data_content): Update.
1852         (free_content_elements) <case DATA_WIN>: Free the window.
1853
1854 2019-06-25  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1857         Update.
1858         * tui/tui-layout.c (make_command_window)
1859         (show_source_disasm_command, show_data, init_and_make_win)
1860         (show_source_or_disasm_and_command): Update.
1861         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1862         method.
1863         <can_highight, is_highlighted>: Now bool.
1864         (tui_set_win_highlight): Don't declare.
1865         * tui/tui-data.c (tui_set_win_highlight): Remove.
1866
1867 2019-06-25  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui-wingeneral.c (make_visible): Remove check of window
1870         type.
1871
1872 2019-06-25  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-win.c (tui_win_info::max_height)
1875         (tui_cmd_window::max_height): New methods.
1876         (new_height_ok): Call max_height.
1877         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1878         <max_height>: New method.
1879
1880 2019-06-25  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-win.c (tui_source_window_base::set_new_height)
1883         (tui_data_window::set_new_height): New methods.
1884         (make_invisible_and_set_new_height): Call set_new_height method.
1885         * tui/tui-data.h (struct tui_win_info)
1886         (struct tui_source_window_base, struct tui_data_window)
1887         <set_new_height>: New method.
1888
1889 2019-06-25  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1892         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1893         tui_refresh_data_win.
1894         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1895         method.
1896         (tui_refresh_all_win): Call the refresh_all method.
1897         (tui_set_focus): Likewise.
1898         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1899         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1900         Likewise.
1901
1902 2019-06-25  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-winsource.h (tui_refill_source_window)
1905         (tui_set_is_exec_point_at): Don't declare.
1906         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1907         (tui_source_window_base::refill): Rename from
1908         tui_refill_source_window.
1909         (tui_source_window_base::do_scroll_horizontal): Update.
1910         (tui_source_window_base::set_is_exec_point_at): Rename from
1911         tui_set_is_exec_point_at.
1912         (tui_update_all_breakpoint_info): Update.
1913         * tui/tui-stack.c (tui_show_frame_info): Update.
1914         * tui/tui-layout.c (show_data): Add cast.
1915         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1916         * tui/tui-data.h (struct tui_source_window_base) <refill,
1917         set_is_exec_point_at>: New methods.
1918         (tui_source_windows, tui_add_to_source_windows): Update types.
1919         (tui_add_to_source_windows): Remove redundant declaration.
1920         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1921         (tui_source_windows): Change return type.
1922         (tui_clear_source_windows_detail): Update.
1923         (tui_add_to_source_windows): Change type of parameter.
1924         (tui_free_all_source_wins_content): Update.
1925
1926 2019-06-25  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-wingeneral.c (tui_win_info::refresh)
1929         (tui_source_window_base::refresh): New methods.
1930         (tui_refresh_all): Call the refresh method.
1931         * tui/tui-data.h (struct tui_win_info)
1932         (struct tui_source_window_base) <refresh>: New method.
1933
1934 2019-06-25  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui.h (tui_is_window_visible): Return bool.
1937         * tui/tui.c (tui_is_window_visible): Return bool.
1938         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1939         (tui_make_visible, tui_make_invisible)
1940         (tui_win_info::make_visible)
1941         (tui_source_window_base::make_visible, make_all_visible)
1942         (tui_make_all_visible, tui_make_all_invisible): Update.
1943         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1944         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1945         bool.
1946         (struct tui_win_info, struct tui_source_window_base)
1947         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1948         * tui/tui-data.c (tui_init_generic_part): Update.
1949
1950 2019-06-25  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1953         (tui_source_window_base::make_visible): New methods.
1954         (make_all_visible): Make method call.
1955         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1956         (struct tui_source_window_base, struct tui_cmd_window): Override
1957         make_visible.
1958         (tui_win_is_source_type): Don't declare.
1959         * tui/tui-data.c (tui_win_is_source_type): Remove.
1960
1961 2019-06-25  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1964         NULL check.
1965
1966 2019-06-25  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1969         Inline constructor.  Add initializers for members.
1970         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1971         constructors; now inline in class.
1972
1973 2019-06-25  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-regs.c (tui_show_registers): Update.
1976         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1977         bool.
1978         * tui/tui-data.c (tui_data_window::clear_detail)
1979         (tui_data_window): Update.
1980
1981 2019-06-25  Tom Tromey  <tom@tromey.com>
1982
1983         * tui/tui-windata.c (tui_display_all_data)
1984         (tui_display_data_from_line, tui_display_data_from)
1985         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1986         Update.
1987         * tui/tui-regs.c (tui_last_regs_line_no)
1988         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1989         (tui_show_registers, tui_show_register_group)
1990         (tui_display_registers_from, tui_display_reg_element_at_line)
1991         (tui_display_registers_from_line, tui_check_register_values)
1992         (tui_reg_next, tui_reg_prev): Update.
1993         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1994         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1995         tui_data_window.
1996         (struct tui_win_info) <detail>: Remove.  Add new fields from
1997         tui_data_info.
1998         (TUI_DATA_WIN): Add cast.
1999         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2000         (~tui_data_window): Simplify.
2001
2002 2019-06-25  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-layout.c (show_source_disasm_command)
2005         (show_source_or_disasm_and_command): Update.
2006         * tui/tui-io.c (update_cmdwin_start_line)
2007         (tui_redisplay_readline): Update.
2008         * tui/tui-data.h (struct tui_command_info): Remove.
2009         (struct tui_win_info) <detail>: Remove command_info member.
2010         (struct tui_data_window) <start_line>: New member, from
2011         tui_command_info.
2012         (TUI_CMD_WIN): Add casts.
2013
2014 2019-06-25  Tom Tromey  <tom@tromey.com>
2015
2016         * tui/tui-winsource.c (tui_update_source_window)
2017         (tui_refill_source_window)
2018         (tui_source_window_base::do_scroll_horizontal)
2019         (tui_update_breakpoint_info, tui_set_exec_info_content)
2020         (tui_show_exec_info_content, tui_erase_exec_info_content)
2021         (tui_clear_exec_info_content): Update.
2022         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2023         Update.
2024         * tui/tui-win.c (make_invisible_and_set_new_height)
2025         (make_visible_with_new_height): Update.
2026         * tui/tui-source.c (tui_set_source_content)
2027         (tui_show_symtab_source): Update.
2028         * tui/tui-layout.c (extract_display_start_addr)
2029         (show_source_disasm_command, show_data)
2030         (make_source_or_disasm_window)
2031         (show_source_or_disasm_and_command): Update.
2032         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2033         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2034         "gdbarch".
2035         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2036         to tui_source_window_base.
2037         (struct tui_win_info) <detail>: Remove source_info member.
2038         (struct tui_source_window_base) <has_locator>: Inline.
2039         Move contents from tui_source_info; rename has_locator member to
2040         m_has_locator.
2041         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2042         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2043         header file.
2044         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2045         Simplify.
2046         (tui_free_all_source_wins_content): Cast to
2047         tui_source_window_base.
2048
2049 2019-06-25  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-win.c (make_invisible_and_set_new_height)
2052         (make_visible_with_new_height): Call has_locator method.
2053         * tui/tui-layout.c (show_source_disasm_command, show_data)
2054         (show_source_or_disasm_and_command): Update for bool change.
2055         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2056         (tui_win_info) <has_locator>: New method.
2057         (struct tui_source_window_base) <has_locator>: New method.
2058         (tui_win_has_locator): Don't declare.
2059         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2060         from tui_win_has_locator.
2061         (tui_source_window_base): Use false, not FALSE.
2062
2063 2019-06-25  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2066         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2067         clear_detail method directly.
2068         (tui_clear_win_detail): Remove.
2069
2070 2019-06-25  Tom Tromey  <tom@tromey.com>
2071
2072         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2073         "this", not TUI_DISASM_WIN.
2074
2075 2019-06-25  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2078         declare.
2079         * tui/tui-winsource.c
2080         (tui_source_window_base::do_scroll_horizontal): Rename from
2081         tui_horizontal_source_scroll.
2082         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2083         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2084         from tui_vertical_data_scroll.
2085         * tui/tui-win.h (tui_scroll): Don't declare.
2086         * tui/tui-win.c (tui_win_info::forward_scroll)
2087         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2088         (tui_win_info::right_scroll): Rename and update.
2089         (tui_scroll_forward_command, tui_scroll_backward_command)
2090         (tui_scroll_left_command, tui_scroll_right_command): Update.
2091         (tui_scroll): Remove.
2092         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2093         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2094         from tui_vertical_source_scroll.
2095         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2096         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2097         from tui_vertical_disassem_scroll.
2098         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2099         do_scroll_horizontal>: New methods.
2100         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2101         Likewise.
2102         (struct tui_source_window_base): Add do_scroll_horizontal.
2103         (struct tui_source_window, struct tui_disasm_window): Add
2104         do_scroll_vertical.
2105         (struct tui_data_window, struct tui_cmd_window): Add
2106         do_scroll_horizontal and do_scroll_vertical.
2107         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2108
2109 2019-06-25  Tom Tromey  <tom@tromey.com>
2110
2111         * tui/tui-data.h (struct tui_source_window_base): New struct.
2112         (struct tui_source_window): Derive from tui_source_window_base.
2113         (struct tui_disasm_window): New struct.
2114         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2115         from tui_source_window::clear_detail.
2116         (tui_source_window_base): Rename from tui_source_window.
2117         (~tui_source_window_base): Rename from ~tui_source_window.
2118         (tui_alloc_win_info): Create a tui_disasm_window.
2119
2120 2019-06-25  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-data.h (struct tui_source_window)
2123         (struct tui_data_window): Declare destructors.
2124         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2125         destructors.
2126         (tui_win_info): Simplify.
2127
2128 2019-06-25  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-winsource.c (tui_display_main)
2131         (tui_update_source_windows_with_addr)
2132         (tui_update_all_breakpoint_info): Update.
2133         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2134         (new_height_ok, parse_scrolling_args): Update.
2135         * tui/tui-stack.c (tui_show_frame_info): Update.
2136         * tui/tui-data.h (struct tui_list): Remove.
2137         (tui_source_windows): Return a reference to a std::vector.
2138         * tui/tui-data.c (source_windows): Now a std::vector.
2139         (tui_source_windows): Change return type.
2140         (tui_clear_source_windows): Rewrite.
2141         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2142         (tui_free_all_source_wins_content): Rewrite.
2143
2144 2019-06-25  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2147         (struct tui_data_window, struct tui_cmd_window): Declare
2148         clear_detail method.
2149         * tui/tui-data.c (tui_source_window::clear_detail)
2150         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2151         methods.
2152         (tui_clear_win_detail): Simplify.
2153
2154 2019-06-25  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-layout.c (make_source_window, make_disasm_window)
2157         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2158         Return the new window.
2159         (show_source_disasm_command, show_data)
2160         (show_source_or_disasm_and_command): Update.
2161
2162 2019-06-25  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2165         parameter.  Return the new window.
2166         (show_source_disasm_command): Update and remove NULL check.
2167         (show_source_or_disasm_and_command): Update.
2168
2169 2019-06-25  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2172
2173 2019-06-25  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui-data.h (struct tui_win_info): Make constructor
2176         protected.  Make destructor virtual.  Add initializers.
2177         (tui_source_window, tui_data_window, tui_cmd_window): New
2178         classes.
2179         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2180         constructor.  Add "type" parameter.
2181         (tui_source_window, tui_data_window, tui_cmd_window): New
2182         constructors.
2183         (tui_alloc_win_info): Instantiate the appropriate subclass.
2184
2185 2019-06-25  Tom Tromey  <tom@tromey.com>
2186
2187         * tui/tui-win.c (tui_resize_all): Use delete.
2188         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2189         destructor.
2190         (tui_free_window): Don't declare.
2191         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2192         Update.
2193
2194 2019-06-25  Tom Tromey  <tom@tromey.com>
2195
2196         * tui/tui-data.h (struct tui_win_info): Add constructor.
2197         * tui/tui-data.c (tui_alloc_win_info): Use new.
2198         (tui_free_window): Use delete.
2199
2200 2019-06-22  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2203         declare.
2204         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2205
2206 2019-06-22  Tom Tromey  <tom@tromey.com>
2207
2208         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2209         declare.
2210         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2211
2212 2019-06-22  Tom de Vries  <tdevries@suse.de>
2213
2214         * dwarf2read.c (create_addrmap_from_aranges)
2215         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2216         instead of '%zu'.
2217
2218 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2219
2220         * dwarf2read.h (dwarf2_section_info_def): Remove.
2221         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2222         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2223         std::vector<dwarf2_section_info>.
2224         (struct dwo_file) <~dwo_file>: Remove.
2225         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2226         types field.
2227         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2228         (dwarf2_read_debug_names): Likewise.
2229         (create_debug_types_hash_table): Change parameter type to
2230         array_view, adjust code accordingly.
2231         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2232         (partial_die_info::fixup): Likewise.
2233         (determine_prefix): Likewise.
2234         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2235
2236 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2237
2238         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2239         gdb_bfd_ref_ptr.
2240         <~dwo_file>: Remove call to gdb_bfd_unref.
2241         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2242         gdb_bfd_ref_ptr::get.
2243
2244 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2245
2246         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2247         type to htab_up.
2248         * dwarf2read.c (struct dwo_file): Initialize fields.
2249         <~dwo_file>: New.
2250         (free_dwo_file): Remove, move content to ~dwo_file.
2251         (struct dwo_file_deleter): Remove.
2252         (dwo_file_up>: Remove custom deleter.
2253         (free_dwo_files): Remove.
2254         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2255         dwo_files.
2256         (process_skeletonless_type_units): Call unique_ptr::get.
2257         (allocate_dwo_file_hash_table): Add deleter to created hash
2258         table.  Change return type to htab_up.
2259         (lookup_dwo_file_slot): Don't memset dwo_file, call
2260         unique_ptr::get.
2261         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2262         (create_dwo_unit_in_dwp_v2): Likewise.
2263         (open_and_init_dwo_file): Likewise.
2264         (free_dwo_file_from_slot): Remove.
2265
2266 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2267
2268         * dwarf2read.h (struct dwarf2_section_info) <readin,
2269         is_virtual>: Change type to bool.
2270         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2271         true instead of 1.
2272
2273 2019-06-19  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-data.h (tui_init_content_element): Don't declare.
2276
2277 2019-06-19  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-data.h (tui_init_win_info): Don't declare.
2280
2281 2019-06-19  Tom de Vries  <tdevries@suse.de>
2282
2283         * dwarf2read.h (abstract_to_concrete): Change type to
2284         std::unordered_map<sect_offset, std::vector<sect_offset>,
2285         gdb::hash_enum<sect_offset>>.
2286
2287 2019-06-19  Tom Tromey  <tromey@adacore.com>
2288
2289         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2290         EVAL_AVOID_SIDE_EFFECTS specially.
2291
2292 2019-06-19  Tom Tromey  <tromey@adacore.com>
2293
2294         * source-cache.c (highlighter): New global.
2295         (source_cache::get_source_lines): Create a highlighter on demand.
2296
2297 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2298
2299         * defs.h (deprecated_interactive_hook): Delete declaration.
2300         * interps.c (clear_interpreter_hooks): Remove use of
2301         deprecated_interactive_hook.
2302         * top.c (deprecated_interactive_hook): Delete definition.
2303         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2304
2305 2019-06-18  Tom de Vries  <tdevries@suse.de>
2306
2307         PR gdb/24515
2308         * dwarf2read.h (abstract_to_concrete): Change type from
2309         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2310         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2311         * dwarf2read.c (read_variable): Update.
2312         (dwarf2_fetch_die_loc_sect_off): Update.
2313
2314 2019-06-17  Tom de Vries  <tdevries@suse.de>
2315
2316         PR gdb/24617
2317         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2318         accessing parent[parent_len - 1].
2319
2320 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2321
2322         PR gdb/24364
2323         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2324         call dtrace_process_dof with NULL dof.
2325
2326 2019-06-16  Tom de Vries  <tdevries@suse.de>
2327
2328         PR gdb/24445
2329         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2330
2331 2019-06-16  Tom Tromey  <tom@tromey.com>
2332
2333         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2334         (make_all_visible): Use address of member.
2335
2336 2019-06-16  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2339         (tui_free_window, free_content, free_content_elements): Remove
2340         unnecessary cast.
2341         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2342         cast.
2343         * tui/tui-regs.c (tui_show_register_group)
2344         (tui_display_registers_from, tui_display_reg_element_at_line):
2345         Remove unnecessary cast.
2346
2347 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2348
2349         * linux-nat.c (normal_mask): Delete.
2350         (_initialize_linux_nat): Don't initialise normal_mask.
2351
2352 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2353
2354         PR gdb/24445
2355         * dwarf-index-write.h (write_psymtabs_to_index): Add
2356         dwz_basename parameter.
2357         * dwarf-index-write.c (write_gdbindex): Move file writing to
2358         write_gdbindex_1.  Change return type void.
2359         (assert_file_size): Move up, remove filename parameter.
2360         (write_gdbindex_1): New function.
2361         (write_debug_names): Change return type to void, call
2362         assert_file_size.
2363         (struct index_wip_file): New struct.
2364         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2365         file logic to index_wip_file.  Write index for dwz file if
2366         needed.
2367         (save_gdb_index_command): Pass basename of dwz file, if present.
2368         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2369         build-id of dwz file, if present.
2370         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2371         (dwarf2_get_dwz_file): Likewise.
2372         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2373         (dwarf2_get_dwz_file): Likewise.
2374
2375 2019-06-16  Tom Tromey  <tom@tromey.com>
2376
2377         * coffread.c (process_coff_symbol): Use xstrdup.
2378         * value.c (create_internalvar): Use xstrdup.
2379
2380 2019-06-16  Tom Tromey  <tom@tromey.com>
2381
2382         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2383         * breakpoint.c (stopin_command, stopat_command)
2384         (until_break_command, decode_location_default): Remove unnecessary
2385         cast.
2386         * utils.c (subset_compare): Remove unnecessary cast.
2387         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2388         cast.
2389         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2390         cast.
2391         * infcmd.c (path_command): Remove unnecessary cast.
2392         * coffread.c (decode_type): Remove unnecessary cast.
2393         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2394         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2395         * tui/tui-stack.c (tui_show_locator_content)
2396         (tui_show_frame_info): Remove unnecessary cast.
2397         * tui/tui-win.c (tui_scroll_forward_command)
2398         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2399         (parse_scrolling_args): Remove unnecessary cast.
2400         * tui/tui-data.c (init_win_info, tui_del_window)
2401         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2402         (free_content_elements): Remove unnecessary cast.
2403         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2404         unnecessary cast.
2405         * tui/tui-source.c (tui_set_source_content)
2406         (tui_vertical_source_scroll): Remove unnecessary cast.
2407         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2408         cast.
2409         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2410         * tui/tui-regs.c (tui_display_registers_from)
2411         (tui_display_register): Remove unnecessary cast.
2412         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2413         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2414         (make_visible): Remove unnecessary cast.
2415         * tui/tui-winsource.c (tui_erase_source_content)
2416         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2417         unnecessary cast.
2418         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2419         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2420         * stabsread.c (read_type, read_array_type, read_range_type):
2421         Remove unnecessary cast.
2422         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2423         (parse_symbol, parse_type, upgrade_type, parse_external)
2424         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2425         unnecessary cast.
2426         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2427
2428 2019-06-16  Tom Tromey  <tom@tromey.com>
2429
2430         * tui/tui-data.c (tui_alloc_generic_win_info)
2431         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2432         checks.
2433
2434 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2435             Andrew Burgess  <andrew.burgess@embecosm.com>
2436
2437         * f-typeprint.c (f_print_type): Don't return early for not
2438         associated or not allocated types.
2439         (f_type_print_varspec_suffix): Add print_rank parameter and print
2440         ranks of array types in case they dangling.
2441         (f_type_print_base): Add print_rank parameter.
2442
2443 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2444
2445         * NEWS: Mention new MI commands.
2446         * break-catch-throw.c (enum exception_event_kind): Move to
2447         breakpoint.h.
2448         (print_mention_exception_catchpoint): Output text as a single
2449         message.
2450         (catch_exception_command_1): Rename to...
2451         (catch_exception_event): ...this, make non-static, update header
2452         command, and change some parameter types.
2453         (catch_catch_command): Update for changes to
2454         catch_exception_command_1.
2455         (catch_throw_command): Likewise.
2456         (catch_rethrow_command): Likewise.
2457         * breakpoint.c (enum exception_event_kind): Delete.
2458         * breakpoint.h (enum exception_event_kind): Moved here from
2459         break-catch-throw.c.
2460         (catch_exception_event): Declare.
2461         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2462         (mi_cmd_catch_throw): New function.
2463         (mi_cmd_catch_rethrow): New function.
2464         (mi_cmd_catch_catch): New function.
2465         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2466         'catch-catch' entries.
2467         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2468         (mi_cmd_catch_rethrow): Declare.
2469         (mi_cmd_catch_catch): Declare.
2470
2471 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2472
2473         * annotate.c (annotate_source_line): Change return type to void,
2474         update implementation to match.
2475         * annotate.h (annotate_source_line): Change return type to void,
2476         update header comment.
2477         * stack.c (print_frame_info): Don't change what frame information
2478         is printed based on whether annotations are on or not.
2479
2480 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2481
2482         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2483         (annotate_source): Make static.
2484         (annotate_source_line): Moved from source.c and renamed from
2485         identify_source_line.  Update the return type.
2486         * annotate.h (annotate_source): Delete declaration.
2487         (annotate_source_line): Declaration moved from source.h, and
2488         renamed from identify_source_line.  Return type updated.
2489         * source.c (identify_source_line): Moved to annotate.c and renamed
2490         to annotate_source_line.
2491         (info_line_command): Remove check of annotation_level.
2492         * source.h (identify_source_line): Move declaration to annotate.h
2493         and rename to annotate_source_line.
2494         * stack.c: Add 'annotate.h' include.
2495         (print_frame_info): Remove check of annotation_level before
2496         calling annotate_source_line.
2497
2498 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2499
2500         * source-cache.c (source_cache::get_plain_source_lines): Use
2501         open_source_file_with_line_charpos instead of just
2502         open_source_file, remove call to find_source_lines.
2503         (source_cache::get_source_lines): Likewise.
2504         * source.c (find_source_lines): Make static.
2505         (get_filename_and_charpos): Renamed into...
2506         (open_source_file_with_line_charpos): ..this along with changes to
2507         return a scoped_fd, and some other minor clean ups.
2508         (identify_source_line): Use open_source_file_with_line_charpos.
2509         (search_command_helper): Use open_source_file_with_line_charpos
2510         instead of just open_source_file, remove call to
2511         find_source_lines.
2512         * source.h (open_source_file_with_line_charpos): Declare new
2513         function.
2514         (find_source_lines): Delete declaration.
2515
2516 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2517
2518         * source.c (get_filename_and_charpos): Remove fullname
2519         parameter.
2520         (identify_source_line): Update call to get_filename_and_charpos.
2521
2522 2019-06-14  Tom Tromey  <tromey@adacore.com>
2523
2524         PR gdb/24502:
2525         * ui-style.h (skip_ansi_escape): Update comment.
2526         * ui-file.h (class no_terminal_escape_file): New class.
2527         * ui-file.c (no_terminal_escape_file::write)
2528         (no_terminal_escape_file::puts): New methods.
2529         * cli/cli-logging.c (handle_redirections): Use
2530         no_terminal_escape_file.
2531
2532 2019-06-14  Tom Tromey  <tromey@adacore.com>
2533
2534         * NEWS: Move convenience variable news above Python news.
2535
2536 2019-06-14  Tom Tromey  <tom@tromey.com>
2537
2538         * gnulib: Move directory to top-level.
2539         * configure.ac: Don't configure gnulib.
2540         * configure: Rebuild.
2541         * common/common-defs.h: Use new path to gnulib.
2542         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2543         (GNULIB_H): Remove.
2544         (INCGNU): Look in new gnulib location.
2545         (HFILES_NO_SRCDIR): Remove gnulib files.
2546         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2547         (generated_files): Remove GNULIB_H.
2548         ($(LIBGNU), all-lib): Remove targets.
2549         (distclean): Don't mention GNULIB_BUILDDIR.
2550         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2551
2552 2019-06-14  Tom Tromey  <tromey@adacore.com>
2553
2554         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2555         Warn if symbol file does not provide any symbols.
2556
2557 2019-06-14  Tom Tromey  <tromey@adacore.com>
2558
2559         * source.c (find_and_open_source): Respect basenames_may_differ.
2560
2561 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2562
2563         * annotate.c (annotate_breakpoints_invalid): Make use of
2564         scoped_restore_terminal_state.
2565         (annotate_frames_invalid): Likewise.
2566
2567 2019-06-14  Tom Tromey  <tromey@adacore.com>
2568
2569         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2570         allow assignment to an internalvar.
2571
2572 2019-06-14  Tom Tromey  <tromey@adacore.com>
2573
2574         * ada-lex.l: Allow "_" in attribute names.
2575
2576 2019-06-14  Tom Tromey  <tromey@adacore.com>
2577
2578         PR gdb/24653:
2579         * regcache.c (registers_changed): Don't call alloca.
2580         * top.c (execute_command): Don't call alloca.
2581
2582 2019-06-13  Pedro Alves  <palves@redhat.com>
2583
2584         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2585         'expression'.  When parsing an expression, error out if there's
2586         junk after "unlimited".
2587         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2588         (do_set_command): Adjust calls to is_unlimited_literal.
2589
2590 2019-06-13  Pedro Alves  <palves@redhat.com>
2591
2592         * compile/compile.c (make_compile_options_def_group): Add braces
2593         around array_view initializer.
2594         * thread.c (make_thread_apply_all_options_def_group)
2595         (make_thread_apply_all_options_def_group): Likewise.
2596
2597 2019-06-13  Pedro Alves  <palves@redhat.com>
2598
2599         * NEWS (New commands): Mention "maint test-options
2600         require-delimiter", "maint test-options unknown-is-error", "maint
2601         test-options unknown-is-operand" and "maint show
2602         test-options-completion-result".
2603         (New command options, command completion): New section.
2604         (Completion improvements): New section.
2605         Mention that you can abbreviate "unlimited".
2606
2607 2019-06-13  Pedro Alves  <palves@redhat.com>
2608
2609         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2610         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2611         * unittests/cli-utils-selftests.c (test_parse_flags)
2612         (test_parse_flags_qcs): Delete.
2613         (test_cli_utils): Don't call deleted functions.
2614
2615 2019-06-13  Pedro Alves  <palves@redhat.com>
2616
2617         * thread.c: Include "cli/cli-option.h".
2618         (tp_array_compar_ascending): Global.
2619         (tp_array_compar): Delete function.
2620         (tp_array_compar_ascending, tp_array_compar_descending): New
2621         functions.
2622         (ascending_option_def, qcs_flag_option_def)
2623         (thr_qcs_flags_option_defs)
2624         (make_thread_apply_all_options_def_group)
2625         (make_thread_apply_options_def_group): New.
2626         (thread_apply_all_command): Use gdb::option::process_options.
2627         (thread_apply_command_completer)
2628         (thread_apply_all_command_completer): New.
2629         (thread_apply_command): Use gdb::option::process_options.
2630         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2631         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2632         to generate help text of "thread apply".  Adjust "taas"'s help.
2633         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2634         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2635
2636 2019-06-13  Pedro Alves  <palves@redhat.com>
2637
2638         * thread.c (thread_apply_command): Check for invalid TID with
2639         isdigit instead of !isalpha.
2640
2641 2019-06-13  Pedro Alves  <palves@redhat.com>
2642
2643         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2644         (validate_flags_qcs): New.
2645         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2646         (validate_flags_qcs): Declare.
2647         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2648         (make_frame_apply_options_def_group): New.
2649         (frame_apply_command_count): Process options with
2650         gdb::option::process_options.
2651         (frame_apply_completer): New.
2652         (frame_apply_level_completer, frame_apply_all_completer)
2653         (frame_apply_completer): New.
2654         (_initialize_stack): Update help of "frame apply", "frame apply
2655         level", "frame apply all" and "faas" to mention supported options
2656         and install command completers.
2657         * stack.h (frame_apply_all_completer): Declare.
2658         * thread.c: Include "stack.h".
2659         (tfaas_command): Add "--".
2660         (_initialize_thread): Update help "tfaas" to mention supported
2661         options and install command completer.
2662
2663 2019-06-13  Pedro Alves  <palves@redhat.com>
2664
2665         * completer.c (complete_nested_command_line): New.
2666         (gdb_completion_word_break_characters_throw): Add assertion.
2667         * completer.h (complete_nested_command_line): Declare.
2668
2669 2019-06-13  Pedro Alves  <palves@redhat.com>
2670
2671         * stack.c (parse_backtrace_qualifiers): New.
2672         (backtrace_command): Use it.
2673         (backtrace_command_completer): Complete on qualifiers.
2674
2675 2019-06-13  Pedro Alves  <palves@redhat.com>
2676
2677         * frame.c: Include "cli/cli-option.h.
2678         (user_set_backtrace_options): New.
2679         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2680         Delete.
2681         (get_prev_frame): Adjust.
2682         (boolean_option_def, uinteger_option_def)
2683         (set_backtrace_option_defs): New.
2684         (_initialize_frame): Adjust and use
2685         gdb::option::add_setshow_cmds_for_options to install "set
2686         backtrace past-main" and "set backtrace past-entry".
2687         * frame.h: Include "cli/cli-option.h".
2688         (struct frame_print_options): Forward declare.
2689         (print_frame_arguments_all, print_frame_arguments_scalars)
2690         (print_frame_arguments_none): Declare.
2691         (print_entry_values): Delete declaration.
2692         (struct frame_print_options, user_frame_print_options): New.
2693         (struct set_backtrace_options): New.
2694         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2695         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2696         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2697         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2698         (list_args_or_locals): Add frame_print_options parameter.
2699         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2700         * python/py-framefilter.c (enumerate_args): Pass down
2701         USER_FRAME_PRINT_OPTIONS.
2702         * stack.c: Include "cli/cli-option.h".
2703         (print_frame_arguments_all, print_frame_arguments_scalars)
2704         (print_frame_arguments_none): Declare.
2705         (print_raw_frame_arguments, print_entry_values): Delete.
2706         (user_frame_print_options): New.
2707         (boolean_option_def, enum_option_def, frame_print_option_defs):
2708         New.
2709         (struct backtrace_cmd_options): New.
2710         (bt_flag_option_def): New.
2711         (backtrace_command_option_defs): New.
2712         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2713         (print_frame_arg, read_frame_arg, print_frame_args)
2714         (print_frame_info, print_frame): Add frame_print_options parameter
2715         and use it.
2716         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2717         (backtrace_command_1): Add frame_print_options and
2718         backtrace_cmd_options parameters and use them.
2719         (make_backtrace_options_def_group): New.
2720         (backtrace_command): Process command options with
2721         gdb::option::process_options.
2722         (backtrace_command_completer): New.
2723         (_initialize_stack): Extend "backtrace"'s help to mention
2724         supported options.  Install completer for "backtrace".
2725         Install some settings commands with add_setshow_cmds_for_options.
2726
2727 2019-06-13  Pedro Alves  <palves@redhat.com>
2728
2729         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2730         and that "set/show print raw frame-arguments" are now deprecated.
2731
2732         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2733         command.
2734         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2735         * stack.c (_initialize_stack): Install "set/show print
2736         raw-frame-arguments", and deprecate "set/show print raw
2737         frame-arguments".
2738         * valprint.c (_initialize_valprint): Deprecate "set/show print
2739         raw".
2740
2741 2019-06-13  Pedro Alves  <palves@redhat.com>
2742
2743         * compile/compile.c (struct compile_options): New.
2744         (compile_flag_option_def, compile_command_option_defs)
2745         (make_compile_options_def_group): New.
2746         (compile_file_command): Handle options with
2747         gdb::option::process_options.
2748         (compile_file_command_completer): New function.
2749         (compile_code_command): Handle options with
2750         gdb::option::process_options.
2751         (compile_code_command_completer): New function.
2752         (_initialize_compiler): Install completers for "compile code" and
2753         "compile file".  Mention available options in "compile code" and
2754         "compile code"'s help.
2755         * completer.c (advance_to_completion_word): New, factored out from
2756         ...
2757         (advance_to_expression_complete_word_point): ... this.
2758         (advance_to_filename_complete_word_point): New.
2759         * completer.h (advance_to_filename_complete_word_point): New
2760         declaration.
2761
2762 2019-06-13  Pedro Alves  <palves@redhat.com>
2763
2764         * compile/compile.c: Include "cli/cli-option.h".
2765         (compile_print_value): Scope data pointer is now a
2766         value_print_options pointer; adjust.
2767         (compile_print_command): Process options.  Scope data pointer is
2768         now a value_print_options pointer; adjust.
2769         (_initialize_compile): Update "compile print"'s help to include
2770         supported options.  Install a completer for "compile print".
2771         * cp-valprint.c (show_vtblprint, show_objectprint)
2772         (show_static_field_print): Delete.
2773         (_initialize_cp_valprint): Don't install "set print
2774         static-members", "set print vtbl", "set print object" here.
2775         * printcmd.c: Include "cli/cli-option.h" and
2776         "common/gdb_optional.h".
2777         (print_command_parse_format): Rework to fill in a
2778         value_print_options instead of a format_data.
2779         (print_value): Change parameter type from format_data pointer to
2780         value_print_options reference.  Adjust.
2781         (print_command_1): Process options.  Adjust to pass down a
2782         value_print_options.
2783         (print_command_completer): New.
2784         (_initialize_printcmd): Install print_command_completer as
2785         handle_brkchars completer for the "print" command.  Update
2786         "print"'s help to include supported options.
2787         * valprint.c: Include "cli/cli-option.h".
2788         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2789         here from cp-valprint.c.
2790         (boolean_option_def, uinteger_option_def)
2791         (value_print_option_defs, make_value_print_options_def_group):
2792         New.  Use gdb::option::add_setshow_cmds_for_options to install
2793         "set print elements", "set print null-stop", "set print repeats",
2794         "set print pretty", "set print union", "set print array", "set
2795         print address", "set print symbol", "set print array-indexes".
2796         * valprint.h: Include <string> and "cli/cli-option.h".
2797         (make_value_print_options_def_group): Declare.
2798         (print_value): Change parameter type from format_data pointer to
2799         value_print_options reference.
2800         (print_command_completer): Declare.
2801
2802 2019-06-13  Pedro Alves  <palves@redhat.com>
2803
2804         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2805         (COMMON_SFILES): Add maint-test-settings.c.
2806         * cli/cli-decode.c (boolean_enums): New global, factored out from
2807         ...
2808         (add_setshow_boolean_cmd): ... here.
2809         * cli/cli-decode.h (boolean_enums): Declare.
2810         * cli/cli-option.c: New file.
2811         * cli/cli-option.h: New file.
2812         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2813         factored out from ...
2814         (parse_cli_boolean_value(const char *)): ... this.
2815         (is_unlimited_literal): Change parameter type to pointer to
2816         pointer.  Adjust and advance ARG pointer.
2817         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2818         (parse_cli_var_enum): New, factored out from ...
2819         (do_set_command): ... this.  Adjust.
2820         * cli/cli-setshow.h (parse_cli_boolean_value)
2821         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2822         (parse_cli_var_enum): Declare.
2823         * cli/cli-utils.c: Include "cli/cli-option.h".
2824         (get_ulongest): New.
2825         * cli/cli-utils.h (get_ulongest): Declare.
2826         (check_for_argument): New overloads.
2827         * maint-test-options.c: New file.
2828
2829 2019-06-13  Pedro Alves  <palves@redhat.com>
2830
2831         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2832         parse a range if "-" is at the end of the string.
2833
2834 2019-06-13  Pedro Alves  <palves@redhat.com>
2835
2836         * cli/cli-setshow.c (parse_auto_binary_operation)
2837         (parse_cli_boolean_value): Don't allow "o".
2838
2839 2019-06-13  Pedro Alves  <palves@redhat.com>
2840
2841         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2842         * NEWS: Mention maint test-settings KIND.
2843         * maint-test-settings.c: New file.
2844
2845 2019-06-13  Pedro Alves  <palves@redhat.com>
2846
2847         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2848         completer.
2849         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2850         "set" completers.
2851
2852 2019-06-13  Pedro Alves  <palves@redhat.com>
2853
2854         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2855         after item.
2856
2857 2019-06-13  Pedro Alves  <palves@redhat.com>
2858
2859         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2860
2861 2019-06-13  Pedro Alves <palves@redhat.com>
2862
2863         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2864         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2865         call.
2866         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2867         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2868         calls.
2869         (check_for_argument): Skip spaces after argument.
2870
2871 2019-06-13  Pedro Alves  <palves@redhat.com>
2872
2873         * thread.c (thread_apply_command): Adjust TID parsing.
2874         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2875         detected before end of string.
2876         (tid_is_in_list): Error out if LIST is invalid.
2877
2878 2019-06-13  Pedro Alves  <palves@redhat.com>
2879
2880         * completer.c (complete_line_internal_1): Rewind completion word
2881         point.
2882         (completion_tracker::advance_custom_word_point_by): Change
2883         parameter type to int.
2884         * completer.h (completion_tracker::advance_custom_word_point_by):
2885         Likewise.
2886
2887 2019-06-13  Pedro Alves  <palves@redhat.com>
2888
2889         * completer.c (advance_to_completion_word): Handle delimiters.
2890
2891 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2892
2893         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2894
2895 2019-06-11  Tom Tromey  <tom@tromey.com>
2896
2897         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2898         (xmalloc_failed): Move to alloc.c.
2899         * alloc.c: New file.
2900         * Makefile.in (COMMON_SFILES): Add alloc.c.
2901
2902 2019-06-11  Tom Tromey  <tom@tromey.com>
2903
2904         * nat/linux-waitpid.c: Don't include server.h.
2905         (linux_debug): Remove.
2906         (my_waitpid): Update.
2907
2908 2019-06-11  Tom Tromey  <tromey@adacore.com>
2909
2910         * infcall.c (_initialize_infcall): Remove trailing newline from
2911         help.
2912         * user-regs.c (_initialize_user_regs): Remove trailing newline
2913         from help.
2914         * typeprint.c (_initialize_typeprint): Remove trailing newline
2915         from help.
2916         * reverse.c (_initialize_reverse): Remove trailing newlines from
2917         help.
2918         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2919         from help.
2920         * language.c (add_set_language_command): Remove trailing newline
2921         from help.
2922         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2923         help.
2924         * disasm.c (_initialize_disasm): Remove trailing newline from
2925         help.
2926         * top.c (init_main): Remove trailing newline from help.
2927         * interps.c (_initialize_interpreter): Remove trailing newline
2928         from help.
2929         * btrace.c (_initialize_btrace): Remove trailing newlines from
2930         help.
2931         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2932         from help.
2933         * python/python.c (_initialize_python): Remove trailing newline
2934         from help.
2935         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2936         help.
2937         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2938         from help.  Reformat some text.
2939         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2940         from help.
2941         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2942         newline from help.
2943
2944 2019-06-11  Tom Tromey  <tromey@adacore.com>
2945
2946         * darwin-nat.c (darwin_decode_exception_message)
2947         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2948
2949 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2950
2951         * valops.c (value_slice): Check for not allocated or not
2952         associated values.
2953
2954 2019-06-10  Tom de Vries  <tdevries@suse.de>
2955
2956         PR gdb/24618
2957         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2958         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2959         invalid.
2960
2961 2019-06-10  Tom de Vries  <tdevries@suse.de>
2962
2963         PR gdb/24611
2964         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2965         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2966
2967 2019-06-10  Tom de Vries  <tdevries@suse.de>
2968
2969         PR symtab/24545
2970         * symtab.c (struct demangled_name_entry): Add language field.
2971         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2972         static minimal symbol".  Set and use language field.
2973
2974 2019-06-10  Tom Tromey  <tromey@adacore.com>
2975
2976         * ada-lang.c (_initialize_ada_language): Update help text.
2977
2978 2019-06-10  Tom Tromey  <tromey@adacore.com>
2979
2980         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2981         with a newline.
2982         * guile/guile.c (handle_boot_error): Don't end warning with a
2983         newline.
2984         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2985         warning with a newline.
2986         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2987         newline.
2988         (s12z_frame_cache): Likewise.
2989         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2990         a newline.
2991         * solib-svr4.c (disable_probes_interface): Don't end warning with
2992         a newline.
2993         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2994         newline.
2995         * python/python.c (do_finish_initialization): Don't end warning
2996         with a newline.
2997
2998 2019-06-10  Tom Tromey  <tom@tromey.com>
2999
3000         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3001         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3002         gdbpy_enter.
3003
3004 2019-06-10  Tom Tromey  <tromey@adacore.com>
3005
3006         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3007         data.
3008         (elf_new_init): Don't call stabsread_new_init.
3009         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3010         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3011         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3012
3013 2019-06-10  Tom de Vries  <tdevries@suse.de>
3014
3015         PR symtab/16264
3016         PR symtab/24517
3017         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3018
3019 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3020
3021         * source.c (find_and_open_source): Also rewrite relative file
3022         names.
3023
3024 2019-04-26  Amos Bird  <amosbird@gmail.com>
3025
3026         * annotate.c (annotate_thread_exited): Add "thread-exited"
3027         annotation.
3028
3029 2019-06-06  Tom Tromey  <tromey@adacore.com>
3030
3031         * maint.h (class scoped_command_stats): Use
3032         DISABLE_COPY_AND_ASSIGN.
3033         <print_time>: New method.
3034         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3035         print_time.
3036         (scoped_command_stats::print_time): New method.
3037
3038 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3039
3040         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3041         instructions of lengths 6 or 8 bytes.
3042
3043 2019-06-04  Pedro Alves  <palves@redhat.com>
3044
3045         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3046
3047         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3048         * breakpoint.c (condition_completer): Likewise.
3049         * cli/cli-dump.c (scan_expression): Likewise.
3050         * common/filestuff.c (mkdir_recursive): Likewise.
3051         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3052         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3053         (gdb_abspath): Likewise.
3054         * compile/compile-cplus-types.c
3055         (compile_cplus_instance::decl_name): Likewise.
3056         * completer.c (complete_explicit_location):
3057         (signal_completer, reg_or_group_completer_1): Likewise.
3058         * cp-support.c (cp_remove_params_if_any): Likewise.
3059         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3060         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3061         * infcmd.c (strip_bg_char): Likewise.
3062         * linespec.c (copy_token_string): Likewise.
3063         * mi/mi-main.c (output_cores): Likewise.
3064         * psymtab.c (psymtab_search_name):
3065         * symfile.c (test_set_ext_lang_command): Likewise.
3066         * target.c (target_fileio_read_stralloc): Likewise.
3067         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3068         * value.c (complete_internalvar): Likewise.
3069
3070 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3071
3072         Add objfile property to gdb.Type.
3073         * NEWS: Mention Python API addition.
3074         * python/py-type.c (typy_get_objfile): New method.
3075
3076 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3077
3078         * NEWS: Mention the new set|show style [title|highlight].
3079         Mention changes to "show style", "help" and "apropos".
3080
3081 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3082
3083         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3084         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3085         instead of print_help_for_command.
3086         (print_doc_of_command): New function.
3087         (help_list): Add 'apropos -v word' suggestion.
3088         (print_help_for_command): Style the command name using title style.
3089         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3090         (_initialize_cli_cmds): Describe -v in apropos_command help.
3091
3092 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3093
3094         * cli/cli-style.h (cli_style_option): Add name in constructor,
3095         add m_name class member, add constructor with intensity,
3096         add name class function.
3097         (cli_style_option::add_setshow_commands): Remove name argument.
3098         (highlight_style, title_style): New styles.
3099         * cli/cli-style.c (do_show): New function that shows a style
3100         characteristic styling the style name with itself.
3101         (set_style_name): New function.
3102         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3103         Update all callers according to the changes in cli/cli-style.h.
3104         * utils.h (fputs_highlighted): New function.
3105         * utils.c (fputs_highlighted): Likewise.
3106
3107 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3108
3109         * NEWS: Mention new pipe command and new convenience variables.
3110
3111 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3112
3113         * cli/cli-cmds.c (pipe_command): New function.
3114         (_initialize_cli_cmds): Call add_com for pipe_command.
3115         Define | as an alias for pipe.
3116         (exit_status_set_internal_vars): New function.
3117         (shell_escape): Call exit_status_set_internal_vars.
3118         cli/cli-decode.c (find_command_name_length): Recognize | as
3119         a single character command.
3120
3121 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3122
3123         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3124         top.c (execute_command_to_ui_file): New function, mostly a copy
3125         of execute_command_to_string.
3126         (execute_command_to_string): Implement by calling
3127         execute_command_to_ui_file.
3128
3129 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3130
3131         * top.h (saved_command_line): Remove declaration.
3132         * top.c (previous_saved_command_line, previous_repeat_arguments):
3133         New variables.
3134         (saved_command_line): Make static, define together with other
3135         'repeat variables'.
3136         (dont_repeat): Clear repeat_arguments.
3137         (repeat_previous, get_saved_command_line, save_command_line):
3138         New functions.
3139         (gdb_init): Initialize saved_command_line
3140         and previous_saved_command_line.
3141         * main.c (captured_main_1): Remove saved_command_line initialization.
3142         * event-top.c (handle_line_of_input): Update to use
3143         the new 'repeat' related functions instead of direct access to
3144         saved_command_line.
3145         * command.h (repeat_previous, get_saved_command_line,
3146         save_command_line): New declarations.
3147         (dont_repeat): Add comment.
3148
3149 2019-05-30  Tom Tromey  <tromey@adacore.com>
3150
3151         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3152         Fix comment.
3153         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3154
3155 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3156
3157         PR cli/24587
3158         * completer.c (complete): Initialize variable word.
3159
3160 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3161
3162         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3163         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3164         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3165         'body' is NULL to the outter 'if', protecting the '!is_define'
3166         situation as well.
3167
3168 2019-05-29  Tom Tromey  <tromey@adacore.com>
3169
3170         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3171         (dwarf_unknown): New function.
3172         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3173         (dwarf_type_encoding_name): Use dwarf_unknown.
3174
3175 2019-05-29  Tom Tromey  <tromey@adacore.com>
3176
3177         PR c++/20020:
3178         * cp-valprint.c (cp_print_value_fields): Call
3179         cp_print_static_field inside "try".
3180
3181 2019-05-29  Tom Tromey  <tromey@adacore.com>
3182
3183         * inflow.c (struct terminal_info): Add default operator=.
3184         * configure: Rebuild.
3185         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3186         -Wdeprecated-copy-dtor, -Wredundant-move.
3187
3188 2019-05-29  Tom Tromey  <tromey@adacore.com>
3189
3190         * NEWS: Add entry.
3191         * infcmd.c (print_return_value_1): Handle finish_print
3192         option.
3193         (show_print_finish): New function.
3194         (_initialize_infcmd): Add "set/show print finish" commands.
3195         * valprint.c (user_print_options): Initialize new member.
3196         * valprint.h (struct value_print_options) <finish_print>: New
3197         member.
3198
3199 2019-05-28  Tom Tromey  <tromey@adacore.com>
3200
3201         * ada-lang.c (ada_remove_Xbn_suffix)
3202         (find_old_style_renaming_symbol)
3203         (parse_old_style_renaming): Remove.
3204         (ada_find_renaming_symbol): Don't call
3205         find_old_style_renaming_symbol.
3206         (ada_is_renaming_symbol): Rename from
3207         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3208         bool.  Now static.
3209         (ada_read_var_value): Update and simplify.
3210         * ada-exp.y (write_var_or_type): Remove old code.
3211
3212 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3213
3214         * event-top.c: Remove include comment.
3215         * inflow.c (class scoped_ignore_sigttou): Move from here...
3216         * inflow.h (class scoped_ignore_sigttou): ...to here.
3217         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3218         * top.c:  Remove include comment.
3219
3220 2019-05-27  Tom Tromey  <tom@tromey.com>
3221
3222         * NEWS: Fix typo.
3223
3224 2019-05-22  Tom Tromey  <tromey@adacore.com>
3225
3226         * target.c (target_follow_exec): Constify parameter.
3227         * target-delegates.c: Rebuild.
3228         * remote.c (remote_target::follow_exec): Constify parameter.
3229         * infrun.c (follow_exec): Constify parameter.
3230         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3231         (target_follow_exec): Likewise.
3232
3233 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3234
3235         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3236         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3237
3238 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3239
3240         * NEWS: Add debugredirect and testsuite sections.
3241
3242 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3243
3244         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3245         target descriptions using exclusively floating point register name
3246         aliases.
3247
3248 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3249
3250         PR gdb/18644:
3251         * f-lang.c (build_fortran_types): Handle the case where
3252         gdbarch_floatformat_for_type returns a nullptr.
3253
3254 2019-05-21  Tom de Vries  <tdevries@suse.de>
3255
3256         PR cli/24587
3257         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3258
3259 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3260
3261         PR gdb/18644:
3262         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3263         16-byte floats.
3264         * i386-tdep.c (i386_floatformat_for_type): Use
3265         floatformats_ia64_quad for the 16-byte floating point component
3266         within a fortran 32-byte complex number.
3267
3268 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3269
3270         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3271         delete default constructor.
3272         (find_partial_die): Update to return const struct.
3273         (partial_die_parent_scope): Move variable declaration into scope
3274         of its use and change its type to auto.
3275         (guess_partial_die_structure_name): Likewise.
3276         (partial_die_info::fixup): Likewise.
3277
3278 2019-05-17  Tom Tromey  <tromey@adacore.com>
3279
3280         * source.c (find_and_open_source): Remove cast.
3281
3282 2019-05-17  Tom Tromey  <tromey@adacore.com>
3283
3284         * annotate.c (annotate_source): Make "filename" const.
3285         * annotate.h (annotate_source): Use const.
3286
3287 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3288
3289         * disasm.c (set_disassembler_options): Send errors to stderr.
3290
3291 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3292
3293         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3294         (cli_interp_base::set_logging): Check debug_redirect.
3295         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3296         * cli/cli-logging.c (debug_redirect): Add static variable.
3297         (pop_output_files): Add default param.
3298         (handle_redirections): Print debug setting.
3299         (show_logging_command): Likewise.
3300         (_initialize_cli_logging): Add debugredirect command.
3301         * interps.c (current_interp_set_logging): Add debug_redirect
3302         parameter.
3303         * interps.h (set_logging): Add debug_redirect parameter.
3304         (current_interp_set_logging): Likewise.
3305         * mi/mi-common.h: Likewise.
3306         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3307
3308 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3309             Tom Tromey  <tromey@adacore.com>
3310
3311         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3312         directly.
3313         * cli/cli-interp.h (make_logging_output): Remove declaration.
3314         * cli/cli-logging.c (make_logging_output): Remove function.
3315         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3316         directly.
3317         * ui-file.c (tee_file::tee_file): Remove bools.
3318         (tee_file::~tee_file): Remove deletes.
3319         * ui-file.h (tee_file): Remove bools.
3320
3321 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3322
3323         * mi/mi-cmds.h (mi_cmd_complete): New function.
3324         * mi/mi-main.c (mi_cmd_complete): Likewise.
3325         * mi/mi-cmds.c: Define new MI command -complete.
3326         * NEWS: Mention new -complete command.
3327
3328 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3329
3330         * completer.h (complete): New function.
3331         * completer.c (complete): Likewise.
3332         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3333         function defined in completer.h.
3334
3335 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3336
3337         * MAINTAINERS (Write After Approval): Add myself.
3338
3339 2019-05-17  Tom de Vries  <tdevries@suse.de>
3340
3341         PR gdb/24094
3342         * dwarf2read.c (struct cu_partial_die_info): New struct.
3343         (find_partial_die): Return cu_partial_die_info.
3344         (partial_die_parent_scope, guess_partial_die_structure_name)
3345         (partial_die_info::fixup): Handle new return type of find_partial_die.
3346
3347 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3348
3349         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3350         "std::string", simplifying the algorithm.
3351
3352 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3353
3354         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3355         (stap_static_probe_ops::get_probes): Likewise.
3356
3357 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3358
3359         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3360         '-')" and "else if".
3361         (stap_parse_single_operand): Join checks for
3362         "gdbarch_stap_parse_special_token_p" and
3363         "gdbarch_stap_parse_special_token" in the same "if" statement.
3364         Invert check when verifying for operation on register
3365         displacement.
3366
3367 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3368
3369         * stap-probe.c (stap_get_opcode): Update comment.
3370         (stap_get_expected_argument_type): Likewise.
3371         (handle_stap_probe): Likewise.
3372
3373 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3374
3375         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3376         return type to 'bool'.  Adjust comment.  Use 'bool' when
3377         appropriate.
3378         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3379         * stap-probe.c (stap_parse_argument_1): Likewise.
3380         (stap_is_operator): Likewise.
3381         (stap_is_generic_prefix): Likewise.
3382         (stap_is_register_prefix): Likewise.
3383         (stap_is_register_indirection_prefix): Likewise.
3384         (stap_is_integer_prefix): Likewise.
3385         (stap_generic_check_suffix): Likewise.
3386         (stap_check_integer_suffix): Likewise.
3387         (stap_check_register_suffix): Likewise.
3388         (stap_check_register_indirection_suffix): Likewise.
3389         (stap_parse_register_operand): Likewise.
3390         (stap_parse_single_operand): Likewise.
3391         (stap_parse_argument_1): Likewise.
3392         (stap_probe::get_argument_count): Likewise.
3393         (stap_is_operator): Likewise.
3394
3395 2019-05-16  Tom Tromey  <tromey@adacore.com>
3396
3397         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3398         keyword to foreach.
3399
3400 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3401
3402         * linux-thread-db.c (try_thread_db_load_1): Change return type
3403         to bool.
3404         (try_thread_db_load): Likewise.
3405         (try_thread_db_load_from_pdir_1): Likewise.
3406         (try_thread_db_load_from_pdir): Likewise.
3407         (try_thread_db_load_from_sdir): Likewise.
3408         (try_thread_db_load_from_dir): Likewise.
3409         (thread_db_load_search): Likewise.
3410         (has_libpthread): Likewise.
3411         (thread_db_load): Likewise.
3412
3413 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3414
3415         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3416         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3417         NULL, and complain/return if that's the case.
3418
3419 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3420
3421         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3422         (advance, posn, abstract_read_memory): New functions.
3423         [struct mem_read_abstraction]: New struct.
3424         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3425
3426 2019-05-14  Tom Tromey  <tromey@adacore.com>
3427
3428         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3429         value is not lval_memory.
3430
3431 2019-05-14  Tom Tromey  <tromey@adacore.com>
3432
3433         * solib.c (info_sharedlibrary_command): Style the file name.
3434
3435 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3436
3437         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3438         (aarch64_vnv_type): Likewise.
3439         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3440         * common/tdesc.c: Likewise.
3441         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3442         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3443         * features/aarch64-fpu.xml: Add ieee half view.
3444         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3445         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3446         * gdbtypes.h (struct builtin_type): Likewise.
3447         (struct objfile_type): Likewise.
3448
3449 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3450
3451         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3452         typo.
3453         * location.h (string_to_event_location): Likewise.
3454
3455 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3456
3457         GDB 8.3 released.
3458
3459 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3460
3461         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3462         New variable declaration.
3463         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3464         New variable.
3465         (print_one_breakpoint): Use ui_out::test_flags and new global
3466         variable to compute use_fixed_output.
3467         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3468         Remove.
3469         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3470         (mi_multi_location_breakpoint_output_fixed): Remove.
3471         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3472         new variable.
3473         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3474         fix_multi_location_breakpoint_output flag if version >= 3.
3475         * ui-out.h (enum ui_out_flag)
3476         <fix_multi_location_breakpoint_output>: New enumerator.
3477
3478 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3479
3480         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3481
3482 2019-05-10  Tom Tromey  <tromey@adacore.com>
3483
3484         * ada-lang.c (catch_ada_completer): New function.
3485         (_initialize_ada_language): Use it.
3486
3487 2019-05-10  Tom Tromey  <tromey@adacore.com>
3488
3489         * thread.c (print_thread_info): Make "requested_threads" const.
3490         * gdbthread.h (print_thread_info): Make "requested_threads"
3491         const.
3492         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3493         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3494
3495 2019-05-08  Tom Tromey  <tom@tromey.com>
3496
3497         * gdbtypes.c (objfile_type_data): Change type.
3498         (objfile_type, _initialize_gdbtypes): Update.
3499
3500 2019-05-08  Tom Tromey  <tom@tromey.com>
3501
3502         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3503         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3504         (_initialize_dwarf2_frame): Update.
3505
3506 2019-05-08  Tom Tromey  <tom@tromey.com>
3507
3508         * objc-lang.c (objc_objfile_data): Change type.
3509         (find_methods): Update.
3510         (_initialize_objc_lang): Remove.
3511
3512 2019-05-08  Tom Tromey  <tom@tromey.com>
3513
3514         * stabsread.c (rs6000_builtin_type_data): Change type.
3515         (rs6000_builtin_type, _initialize_stabsread): Update.
3516
3517 2019-05-08  Tom Tromey  <tom@tromey.com>
3518
3519         * mips-tdep.c (mips_pdr_data): Remove.
3520         (_initialize_mips_tdep): Update.
3521
3522 2019-05-08  Tom Tromey  <tom@tromey.com>
3523
3524         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3525         (hppa_init_objfile_priv_data, read_unwind_info)
3526         (find_unwind_entry, _initialize_hppa_tdep): Update.
3527
3528 2019-05-08  Tom Tromey  <tom@tromey.com>
3529
3530         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3531         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3532         on obstack.
3533         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3534
3535 2019-05-08  Tom Tromey  <tom@tromey.com>
3536
3537         * mdebugread.c (basic_type_data): Change type.
3538         (basic_type, _initialize_mdebugread): Update.
3539
3540 2019-05-08  Tom Tromey  <tom@tromey.com>
3541
3542         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3543
3544 2019-05-08  Tom Tromey  <tom@tromey.com>
3545
3546         * nto-tdep.c (nto_inferior_data_reg): Change type.
3547         (nto_inferior_data): Update.
3548         (nto_inferior_data_cleanup, nto_new_inferior_data)
3549         (_initialize_nto_tdep): Remove.
3550         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3551
3552 2019-05-08  Tom Tromey  <tom@tromey.com>
3553
3554         * ada-lang.c (struct ada_inferior_data): Add initializers.
3555         (ada_inferior_data): Change type.
3556         (ada_inferior_data_cleanup): Remove.
3557         (get_ada_inferior_data, ada_inferior_exit)
3558         (struct ada_pspace_data): Add initializers, destructor.
3559         (ada_pspace_data_handle): Change type.
3560         (get_ada_pspace_data): Update.
3561         (ada_pspace_data_cleanup): Remove.
3562
3563 2019-05-08  Tom Tromey  <tom@tromey.com>
3564
3565         * coffread.c (struct coff_symfile_info): Add initializers.
3566         (coff_objfile_data_key): Move lower.  Change type.
3567         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3568         Update.
3569         (coff_free_info): Remove.
3570
3571 2019-05-08  Tom Tromey  <tom@tromey.com>
3572
3573         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3574         (fbsd_pspace_data_handle): Move lower.  Change type.
3575         (get_fbsd_pspace_data): Update.
3576         (fbsd_pspace_data_cleanup): Remove.
3577         (_initialize_fbsd_tdep): Update.
3578
3579 2019-05-08  Tom Tromey  <tom@tromey.com>
3580
3581         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3582         (get_ada_tasks_pspace_data): Update.
3583         (ada_tasks_pspace_data_cleanup): Remove.
3584         (_initialize_tasks): Update.
3585         (ada_tasks_inferior_data_handle): Change type.
3586         (get_ada_tasks_inferior_data): Update.
3587         (ada_tasks_inferior_data_cleanup): Remove.
3588         (struct ada_tasks_pspace_data): Add initializers.
3589
3590 2019-05-08  Tom Tromey  <tom@tromey.com>
3591
3592         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3593         * symfile-debug.c (debug_sym_get_probes): Change type.
3594         * stap-probe.c (handle_stap_probe):
3595         (stap_static_probe_ops::get_probes): Change type.
3596         * probe.h (class static_probe_ops) <get_probes>: Change type.
3597         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3598         (parse_probes_in_pspace): Update.
3599         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3600         Update.
3601         (any_static_probe_ops::get_probes): Change type.
3602         * elfread.c (elfread_data): New typedef.
3603         (probe_key): Change type.
3604         (elf_get_probes): Likewise.  Update.
3605         (probe_key_free): Remove.
3606         (_initialize_elfread): Update.
3607         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3608         Change type.
3609         (dtrace_process_dof_probe, dtrace_process_dof)
3610         (dtrace_static_probe_ops::get_probe): Change type.
3611
3612 2019-05-08  Tom Tromey  <tom@tromey.com>
3613
3614         * xcoffread.c (struct xcoff_symfile_info): Rename from
3615         coff_symfile_info.  Add initializers.
3616         (xcoff_objfile_data_key): Move lower.  Change type.
3617         (XCOFF_DATA): Rewrite.
3618         (xcoff_free_info): Remove.
3619         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3620         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3621         (xcoff_initial_scan): Update.
3622
3623 2019-05-08  Tom Tromey  <tom@tromey.com>
3624
3625         * solib-svr4.c (struct svr4_info): Add initializers and
3626         destructor.
3627         <probes_table>: Now an htab_up.
3628         (solib_svr4_pspace_data): Change type.
3629         (free_probes_table): Simplify.
3630         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3631         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3632         (probes_table_remove_objfile_probes, register_solib_event_probe)
3633         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3634         (_initialize_svr4_solib): Update.
3635
3636 2019-05-08  Tom Tromey  <tom@tromey.com>
3637
3638         * remote.c (remote_pspace_data): Change type.
3639         (remote_pspace_data_cleanup): Remove.
3640         (get_remote_exec_file, set_pspace_remote_exec_file)
3641         (_initialize_remote): Update.
3642
3643 2019-05-08  Tom Tromey  <tom@tromey.com>
3644
3645         * breakpoint.c (breakpoint_objfile_key): Change type.
3646         (get_breakpoint_objfile_data): Update.
3647         (free_breakpoint_objfile_data): Remove.
3648         (_initialize_breakpoint): Update.
3649
3650 2019-05-08  Tom Tromey  <tom@tromey.com>
3651
3652         * linux-tdep.c (struct linux_info): Add initializers.
3653         (linux_inferior_data): Move.  Change type.
3654         (invalidate_linux_cache_inf): Update.
3655         (linux_inferior_data_cleanup): Remove.
3656         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3657
3658 2019-05-08  Tom Tromey  <tom@tromey.com>
3659
3660         * auxv.c (auxv_inferior_data): Move.  Change type.
3661         (auxv_inferior_data_cleanup): Remove.
3662         (invalidate_auxv_cache_inf): Rewrite.
3663         (get_auxv_inferior_data, _initialize_auxv): Update.
3664
3665 2019-05-08  Tom Tromey  <tom@tromey.com>
3666
3667         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3668         (symfile_debug_objfile_data_key): Change type.
3669         (symfile_debug_installed, debug_qf_has_symbols)
3670         (debug_qf_find_last_source_symtab)
3671         (debug_qf_forget_cached_source_info)
3672         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3673         (debug_qf_print_stats, debug_qf_dump)
3674         (debug_qf_expand_symtabs_for_function)
3675         (debug_qf_expand_all_symtabs)
3676         (debug_qf_expand_symtabs_with_fullname)
3677         (debug_qf_map_matching_symbols)
3678         (debug_qf_expand_symtabs_matching)
3679         (debug_qf_find_pc_sect_compunit_symtab)
3680         (debug_qf_map_symbol_filenames)
3681         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3682         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3683         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3684         (debug_sym_read_linetable, debug_sym_relocate): Update.
3685         (symfile_debug_free_objfile): Remove.
3686         (install_symfile_debug_logging, _initialize_symfile_debug):
3687         Update.
3688
3689 2019-05-08  Tom Tromey  <tom@tromey.com>
3690
3691         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3692         allocate_on_obstack.
3693         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3694         (get_dwarf2_per_objfile): Update.
3695         (set_dwarf2_per_objfile): Remove.
3696         (dwarf2_has_info, dwarf2_get_section_info): Update.
3697         (dwarf2_free_objfile): Remove.
3698         (_initialize_dwarf2_read): Update.
3699
3700 2019-05-08  Tom Tromey  <tom@tromey.com>
3701
3702         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3703         initializers.
3704         <unsupported_script_warning_printed,
3705         script_not_found_warning_printed>: Now bool.
3706         (auto_load_pspace_data): Change type.
3707         (~auto_load_pspace_info): Rename from
3708         auto_load_pspace_data_cleanup.
3709         (get_auto_load_pspace_data, init_loaded_scripts_info)
3710         (clear_section_scripts, maybe_print_unsupported_script_warning)
3711         (maybe_print_script_not_found_warning, _initialize_auto_load):
3712         Update.
3713
3714 2019-05-08  Tom Tromey  <tom@tromey.com>
3715
3716         * objfiles.c (objfile_pspace_info): Add destructor and
3717         initializers.
3718         (objfiles_pspace_data): Change type.
3719         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3720         (get_objfile_pspace_data): Update.
3721         (objfiles_bfd_data): Change type.
3722         (get_objfile_bfd_data): Update.
3723         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3724
3725 2019-05-08  Tom Tromey  <tom@tromey.com>
3726
3727         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3728         Change type.
3729         (get_catch_syscall_inferior_data): Update.
3730         (catch_syscall_inferior_data_cleanup): Remove.
3731         (_initialize_break_catch_syscall): Update.
3732
3733 2019-05-08  Tom Tromey  <tom@tromey.com>
3734
3735         * inflow.c (struct terminal_info): Add destructor and
3736         initializers.
3737         (inflow_inferior_data): Change type.
3738         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3739         (get_inflow_inferior_data, inflow_inferior_exit)
3740         (swap_terminal_info, _initialize_inflow): Update.
3741
3742 2019-05-08  Tom Tromey  <tom@tromey.com>
3743
3744         * target-dcache.c (target_dcache_cleanup): Remove.
3745         (target_dcache_aspace_key): Change type.
3746         (target_dcache_init_p, target_dcache_invalidate)
3747         (target_dcache_get, target_dcache_get_or_init)
3748         (_initialize_target_dcache): Update.
3749         * dcache.h (struct dcache_deleter): New.
3750
3751 2019-05-08  Tom Tromey  <tom@tromey.com>
3752
3753         * symtab.c (struct symbol_cache): Add destructor and
3754         initializers.
3755         (symbol_cache_key): Move.  Change type.
3756         (make_symbol_cache, free_symbol_cache): Remove.
3757         (get_symbol_cache): Update.
3758         (symbol_cache_cleanup): Remove.
3759         (ALL_PSPACES, symbol_cache_flush)
3760         (maintenance_print_symbol_cache)
3761         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3762         Update.
3763
3764 2019-05-08  Tom Tromey  <tom@tromey.com>
3765
3766         * symtab.c (struct main_info): Add destructor and initializers.
3767         (main_progspace_key): Move.  Change type.
3768         (get_main_info): Update.
3769         (main_info_cleanup): Remove.
3770         (_initialize_symtab): Update.
3771
3772 2019-05-08  Tom Tromey  <tom@tromey.com>
3773
3774         * registry.h (DECLARE_REGISTRY): Define the _key class.
3775
3776 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3777
3778         * NEWS: Merge two 'New commands' sections.
3779
3780 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3781
3782         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3783         parameter and use Ada language definition instead.
3784         (ada_val_print_ptr): Remove unused language parameter.
3785         (ada_val_print_num): Remove language parameter and use Ada language
3786         definition instead.
3787         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3788         parameter.
3789         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3790         parameter and use Ada language definition instead.
3791         (ada_val_print_1): Update all ada_val_print_xxx calls.
3792         Remove language parameter.
3793         (ada_val_print): Update ada_val_print_1 call.
3794
3795 2019-05-08  Tom Tromey  <tromey@adacore.com>
3796
3797         * remote.c (remote_hw_watchpoint_limit)
3798         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3799         Now static.
3800
3801 2019-05-08  Tom Tromey  <tromey@adacore.com>
3802
3803         * maint.c (_initialize_maint_cmds): Move initialization code to
3804         remote.c.
3805         (watchdog, show_watchdog): Move to remote.c.
3806         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3807         "watchdog" static.
3808         (_initialize_remote): Move initialization code from maint.c.
3809         * defs.h (watchdog): Don't declare.
3810
3811 2019-05-08  Tom Tromey  <tromey@adacore.com>
3812
3813         * tui/tui-interp.c: Include main.h.
3814         * interps.c: Include main.h.
3815         * main.h (interpreter_p): Declare.
3816         * defs.h (interpreter_p): Don't declare.
3817
3818 2019-05-08  Tom Tromey  <tromey@adacore.com>
3819
3820         * dwarf2loc.c: Include dwarf2read.h.
3821         * defs.h (read_unsigned_leb128): Don't declare.
3822         * dwarf2read.h (read_unsigned_leb128): Declare.
3823
3824 2019-05-08  Tom Tromey  <tromey@adacore.com>
3825
3826         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3827         method.
3828
3829 2019-05-08  Tom Tromey  <tromey@adacore.com>
3830
3831         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3832         when no wrap column is set.
3833
3834 2019-05-08  Tom Tromey  <tromey@adacore.com>
3835
3836         * c-lang.c (c_get_string): Handle non-C-style arrays.
3837
3838 2019-05-08  Tom Tromey  <tromey@adacore.com>
3839
3840         * typeprint.c (print_offset_data::update): Print the bit offset,
3841         not the number of bits remaining.
3842
3843 2019-05-08  Tom Tromey  <tromey@adacore.com>
3844
3845         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3846         padding at end of comment.
3847
3848 2019-05-08  Tom Tromey  <tromey@adacore.com>
3849
3850         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3851         Compare main types.
3852
3853 2019-05-06  Tom Tromey  <tom@tromey.com>
3854
3855         * common/scoped_mmap.c: Include common-defs.h.
3856         * common/scoped_mmap.h: Don't include config.h.
3857
3858 2019-05-04  Tom Tromey  <tom@tromey.com>
3859
3860         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3861         (struct aarch64_call_info): Add initializers.
3862         <si>: Now a std::vector.
3863         (pass_on_stack, aarch64_push_dummy_call): Update.
3864
3865 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3866             Tom Tromey  <tom@tromey.com>
3867
3868         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3869         (ppc_threads): Now a std::vector.  Now static.
3870         (hwdebug_find_thread_points_by_tid)
3871         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3872         Update.
3873
3874 2019-05-04  Tom Tromey  <tom@tromey.com>
3875
3876         * arc-tdep.c (arc_tdesc_init): Return bool.
3877
3878 2019-05-04  Tom Tromey  <tom@tromey.com>
3879
3880         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3881         Use gdb_assert_not_reached.
3882
3883 2019-05-04  Tom Tromey  <tom@tromey.com>
3884
3885         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3886         "false".
3887
3888 2019-05-04  Tom Tromey  <tom@tromey.com>
3889
3890         * arc-tdep.c (arc_tdesc_init): Use bool.
3891
3892 2019-05-04  Tom Tromey  <tom@tromey.com>
3893
3894         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3895
3896 2019-05-04  Tom Tromey  <tom@tromey.com>
3897
3898         * cli/cli-cmds.c (valid_command_p): Return bool.
3899
3900 2019-05-04  Tom Tromey  <tom@tromey.com>
3901
3902         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3903         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3904
3905 2019-05-04  Raul Tambre  <raul@tambre.ee>
3906
3907         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3908         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3909         operator for comparison.
3910
3911 2019-05-04  Tom Tromey  <tom@tromey.com>
3912
3913         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3914         (lookup_partial_symbol, print_partial_symbols)
3915         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3916         (psymbol_compare): Update.
3917         (add_psymbol_to_bcache): Clear the entire psymbol.
3918         (maintenance_check_psymtabs): Update.
3919         * psympriv.h (struct partial_symbol): Don't derive from
3920         general_symbol_info.
3921         <obj_section, unrelocated_address, address,
3922         set_unrelocated_address>: Update.
3923         <ginfo>: New member.
3924         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3925         (debug_names::write_psymbols): Update.
3926
3927 2019-05-04  Tom de Vries  <tdevries@suse.de>
3928
3929         * contrib/cc-with-tweaks.sh: Support -n arg.
3930
3931 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3932
3933         * corelow.c (core_target::detach): Ensure frame cache and
3934         register caches are cleared.
3935         inferior.c (exit_inferior_1): Likewise.
3936
3937 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3938             Tom Tromey  <tom@tromey.com>
3939
3940         * dictionary.c (collate_pending_symbols_by_language): Remove
3941         "struct" from foreach.
3942         * symtab.c (lookup_global_symbol_from_objfile)
3943         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3944         foreach.
3945         * ser-tcp.c (net_open): Remove "struct" from foreach.
3946         * objfiles.c (objfile_relocate, objfile_rebase)
3947         (objfile_has_symbols): Remove "struct" from foreach.
3948         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3949         from foreach.
3950         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3951         foreach.
3952         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3953         "struct" from foreach.
3954         * ada-lang.c (create_excep_cond_exprs)
3955         (ada_exception_catchpoint_cond_string): Remove "struct" from
3956         foreach.
3957
3958 2019-05-03  Tom Tromey  <tromey@adacore.com>
3959
3960         * ada-exp.y (convert_char_literal): Check suffix of each
3961         enumerator.
3962
3963 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3964
3965         PR ada/21406:
3966         * ada-exp.y (yywrap): Don't define.
3967         * ada-lex.l (%option): Add noyywrap
3968         (yywrap): Remove.
3969
3970 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3971
3972         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3973         _WIN32_WINNT to the XP level, unless already defined to a higher
3974         level.
3975
3976         * unittests/parse-connection-spec-selftests.c:
3977         * ser-tcp.c:
3978         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3979         override.
3980
3981         * symfile.c (find_separate_debug_file): Remove colon from the
3982         drive spec of DOS/Windows file names of the target, so that the
3983         file name produced from DEBUGDIR and the target's directory will
3984         be valid on DOS/Windows systems.
3985
3986 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3987
3988         * rust-lang.c (val_print_struct): Handle printing structures
3989         containing strings.
3990
3991 2019-05-02  Tom Tromey  <tromey@adacore.com>
3992
3993         * valarith.c (_initialize_valarith): Remove.
3994
3995 2019-05-01  Tom Tromey  <tromey@adacore.com>
3996
3997         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3998         bitfields.
3999
4000 2019-05-01  Tom Tromey  <tromey@adacore.com>
4001
4002         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4003         for big-endian copies.
4004
4005 2019-04-30  Ali Tamur  <tamur@google.com>
4006         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4007         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4008         (read_3_bytes): New function.
4009
4010 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4011
4012         * windows-nat.c (main_thread_id): Delete.
4013         (handle_output_debug_string): Replace main_thread_id by
4014         current_event.dwThreadId.
4015         (fake_create_process): Likewise.
4016         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4017         Do not set main_thread_id.
4018         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4019         current_event.dwThreadId.
4020         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4021
4022 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4023
4024         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4025         Use current_event.dwThreadId instead of main_thread_id.
4026
4027 2019-04-30  Tom Tromey  <tromey@adacore.com>
4028
4029         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4030         (create_excep_cond_exprs): Iterate over program spaces.
4031         (ada_exception_catchpoint_cond_string): Examine all minimal
4032         symbols for exception types.
4033
4034 2019-04-30  Tom Tromey  <tromey@adacore.com>
4035
4036         PR c++/24470:
4037         * dwarf2read.c (process_structure_scope): Handle case where type
4038         has template parameters but no symbol was created.
4039
4040 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4041             Chris January  <chris.january@arm.com>
4042
4043         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4044         qualifier.
4045         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4046
4047 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4048
4049         * f-typeprint.c (f_print_type): Update rules for printing
4050         whitespace.
4051         (f_type_print_varspec_suffix): Likewise.
4052
4053 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4054             Chris January  <chris.january@arm.com>
4055
4056         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4057         function arguments.
4058
4059 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4060
4061         * f-lang.c (build_fortran_types): Change name of void type to
4062         lower case.
4063         * f-typeprint.c (f_type_print_base): Print the name of the void
4064         type, rather than a fixed string.
4065         * f-valprint.c (f_decorations): Use lower case void string.
4066
4067 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4068             Chris January  <chris.january@arm.com>
4069
4070         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4071         types for Fortran.
4072
4073 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4074             Chris January  <chris.january@arm.com>
4075             David Lecomber  <david.lecomber@arm.com>
4076
4077         * f-exp.y (BINOP_INTRINSIC): New token.
4078         (exp): New parser rule handling BINOP_INTRINSIC.
4079         (f77_keywords): Add new builtin procedures.
4080         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4081         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4082         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4083         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4084         (print_unop_subexp_f): New function.
4085         (print_binop_subexp_f): New function.
4086         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4087         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4088         (dump_subexp_body_f): Likewise.
4089         (operator_check_f): Likewise.
4090         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4091         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4092
4093 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4094
4095         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4096         UNOP_KIND.
4097         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4098         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4099         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4100         (operator_length_f): New fuction.
4101         (print_subexp_f): New function.
4102         (op_name_f): New function.
4103         (dump_subexp_body_f): New function.
4104         (operator_check_f): New function.
4105         (exp_descriptor_f): Replace standard expression handling functions
4106         with new functions.
4107         * gdb/fortran-operator.def: New file.
4108         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4109         * gdb/std-operator.def: Remove UNOP_KIND.
4110
4111 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4112
4113         * std-operator.def: Remove unbalanced, stray double quote
4114         character.
4115
4116 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4117             Chris January  <chris.january@arm.com>
4118             Daniel Everett  <daniel.everett@arm.com>
4119             Nick Forrington  <nick.forrington@arm.com>
4120             Richard Bunt  <richard.bunt@arm.com>
4121
4122         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4123         of depth when printing anonymous structs or unions.
4124         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4125         Don't print either the top-level value, or the children if the
4126         max-depth is exceeded.
4127         (ppscm_print_children): When printing the key of a map, allow one
4128         extra level of depth.
4129         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4130         print either the top-level value, or the children if the max-depth
4131         is exceeded.
4132         (print_children): When printing the key of a map, allow one extra
4133         level of depth.
4134         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4135         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4136         (user_print_options): Initialise max_depth field.
4137         (val_print_scalar_or_string_type_p): New function.
4138         (val_print): Check to see if the max depth has been reached.
4139         (val_print_check_max_depth): Define new function.
4140         (show_print_max_depth): New function.
4141         (_initialize_valprint): Add 'print max-depth' option.
4142         * valprint.h (struct value_print_options) <max_depth>: New field.
4143         (val_print_check_max_depth): Declare new function.
4144         * NEWS: Document new feature.
4145
4146 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * ada-lang.c (ada_language_defn): Initialise new field.
4149         * c-lang.c (c_is_string_type_p): New function.
4150         (c_language_defn): Initialise new field.
4151         (cplus_language_defn): Initialise new field.
4152         (asm_language_defn): Initialise new field.
4153         (minimal_language_defn): Initialise new field.
4154         * c-lang.h (c_is_string_type_p): Declare new function.
4155         * d-lang.c (d_language_defn): Initialise new field.
4156         * f-lang.c (f_is_string_type_p): New function.
4157         (f_language_defn): Initialise new field.
4158         * go-lang.c (go_is_string_type_p): New function.
4159         (go_language_defn): Initialise new field.
4160         * language.c (default_is_string_type_p): New function.
4161         (unknown_language_defn): Initialise new field.
4162         (auto_language_defn): Initialise new field.
4163         * language.h (struct language_defn) <la_is_string_type_p>: New
4164         member variable.
4165         (default_is_string_type_p): Declare new function.
4166         * m2-lang.c (m2_language_defn): Initialise new field.
4167         * objc-lang.c (objc_language_defn): Initialise new field.
4168         * opencl-lang.c (opencl_language_defn): Initialise new field.
4169         * p-lang.c (pascal_is_string_type_p): New function.
4170         (pascal_language_defn): Initialise new field.
4171         * rust-lang.c (rust_is_string_type_p): New function.
4172         (rust_language_defn): Initialise new field.
4173
4174 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4175
4176         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4177         New field.
4178         * ada-lang.c (ada_language_defn): Initialise new field.
4179         * c-lang.c (c_language_defn): Likewise.
4180         (cplus_language_defn): Likewise.
4181         (asm_language_defn): Likewise.
4182         (minimal_language_defn): Likewise.
4183         * d-lang.c (d_language_defn): Likewise.
4184         * f-lang.c (f_language_defn): Likewise.
4185         * go-lang.c (go_language_defn): Likewise.
4186         * language.c (unknown_language_defn): Likewise.
4187         (auto_language_defn): Likewise.
4188         * m2-lang.c (m2_language_defn): Likewise.
4189         * objc-lang.c (objc_language_defn): Likewise.
4190         * opencl-lang.c (opencl_language_defn): Likewise.
4191         * p-lang.c (pascal_language_defn): Likewise.
4192         * rust-lang.c (rust_language_defn): Likewise.
4193
4194 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4195
4196         * ada-lang.c (ada_is_character_type): Change return type to bool.
4197         (ada_is_string_type): Likewise.
4198         * ada-lang.h (ada_is_character_type): Update declaration
4199         (ada_is_string_type): Likewise.
4200
4201 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4202
4203         Support style in 'frame|thread apply'
4204
4205         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4206         * record.c (record_start, record_stop): Update callers of
4207         execute_command_to_string with false.
4208         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4209         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4210         methods.
4211         (class string_file): New constructor with term_out parameter.
4212         Override methods term_out and can_emit_style_escape.  New member
4213         term_out.
4214         (class stdio_file): Override can_emit_style_escape.
4215         (class tee_file): Override term_out and can_emit_style_escape.
4216         * utils.h (can_emit_style_escape): Remove.
4217         * utils.c (can_emit_style_escape): Likewise.
4218         Update all callers of can_emit_style_escape (SOMESTREAM) to
4219         SOMESTREAM->can_emit_style_escape.
4220         * source-cache.c (source_cache::get_source_lines): Likewise.
4221         * stack.c (frame_apply_command_count): Call execute_command_to_string
4222         passing the term_out characteristic of the current gdb_stdout.
4223         * thread.c (thr_try_catch_cmd): Likewise.
4224         * top.c (execute_command_to_string): pass term_out parameter
4225         to construct the string_file for the command output.
4226         * ui-file.c (term_cli_styling): New function (most code moved
4227         from utils.c can_emit_style_escape).
4228         (string_file::string_file, string_file::can_emit_style_escape,
4229         stdio_file::can_emit_style_escape, tee_file::term_out,
4230         tee_file::can_emit_style_escape): New functions.
4231
4232 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4233
4234         * NEWS: Mention the new set|show may-call-functions.
4235         * infcall.c (may_call_functions_p): New variable.
4236         (show_may_call_functions_p): New function.
4237         (call_function_by_hand_dummy): Throws an error if not
4238         may-call-functions.
4239         (_initialize_infcall): Call add_setshow_boolean_cmd for
4240         may-call-functions.
4241
4242 2019-04-25  Keith Seitz  <keiths@redhat.com>
4243
4244         PR c++/24367
4245         * cp-support.c (inspect_type): Don't attempt substitutions
4246         of symbol with the same name.
4247
4248 2019-04-25  Tom Tromey  <tromey@adacore.com>
4249
4250         PR gdb/24475:
4251         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4252         static.
4253
4254 2019-04-25  Tom Tromey  <tromey@adacore.com>
4255
4256         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4257         rvalue reference.
4258         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4259         (gdb_xml_parser::parse): Use std::move.
4260         * python/python-internal.h (gdbpy_convert_exception): Take a const
4261         reference.
4262         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4263         std::move.
4264         * python/py-utils.c (gdbpy_convert_exception): Take a const
4265         reference.
4266         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4267         Use std::move.
4268         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4269         Use std::move.
4270         * mi/mi-main.c (mi_print_exception): Take a const reference.
4271         * main.c (handle_command_errors): Take a const reference.
4272         * linespec.c (parse_linespec): Use std::move.
4273         * infcall.c (run_inferior_call): Use std::move.
4274         (call_function_by_hand_dummy): Use std::move.
4275         * exec.c (try_open_exec_file): Use std::move.
4276         * exceptions.h (exception_print, exception_fprintf)
4277         (exception_print_same): Update.
4278         * exceptions.c (print_exception, exception_print)
4279         (exception_fprintf, exception_print_same): Change parameters to
4280         const reference.
4281         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4282         * common/new-op.c: Use std::move.
4283         * common/common-exceptions.h (struct gdb_exception): Add move
4284         constructor.
4285         (struct gdb_exception_error, struct gdb_exception_quit, struct
4286         gdb_quit_bad_alloc): Change constructor to move constructor.
4287         (throw_exception): Change parameter to rvalue reference.
4288         * common/common-exceptions.c (throw_exception): Take rvalue
4289         reference.
4290         * cli/cli-interp.c (safe_execute_command): Use std::move.
4291         * breakpoint.c (insert_bp_location, location_to_sals): Use
4292         std::move.
4293
4294 2019-04-25  Tom Tromey  <tromey@adacore.com>
4295
4296         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4297         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4298         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4299         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4300         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4301         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4302         guile/scm-value.c: Use unpack.
4303         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4304         gdbscm_gdb_exception.
4305         (gdbscm_throw_gdb_exception): Likewise.
4306         (struct gdbscm_gdb_exception): New.
4307         (unpack): New function.
4308         (gdbscm_wrap): Use unpack.
4309
4310 2019-04-25  Tom Tromey  <tromey@adacore.com>
4311
4312         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4313         (gdb_rl_callback_handler): Use std::move.
4314         * common/common-exceptions.h (struct gdb_exception): Add move
4315         assignment operator.
4316         (throw_exception_sjlj): Change "exception" to const reference.
4317         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4318         (throw_exception_sjlj): Change "exception" to const reference.
4319
4320 2019-04-25  Tom Tromey  <tromey@adacore.com>
4321
4322         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4323         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4324         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4325         Update.
4326         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4327         Update.
4328         * mi/mi-interp.c (mi_interp::exec): Update.
4329         * linespec.c (parse_linespec): Update.
4330         * infcall.c (run_inferior_call): Update.
4331         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4332         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4333         (gdbscm_lookup_global_symbol): Update.
4334         * guile/scm-param.c (gdbscm_parameter_value): Update.
4335         * guile/scm-frame.c (gdbscm_frame_read_register)
4336         (gdbscm_frame_read_var): Update.
4337         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4338         * exec.c (try_open_exec_file): Update.
4339         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4340         (gdb_rl_callback_handler): Update.
4341         * common/common-exceptions.h (exception_none): Don't declare.
4342         * common/common-exceptions.c (exception_none): Don't define.
4343         (struct catcher) <exception>: Update.
4344         * cli/cli-interp.c (safe_execute_command): Update.
4345         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4346
4347 2019-04-25  Ali Tamur  <tamur@google.com>
4348
4349         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4350         (read_attribute_value): Likewise.
4351         (dwarf2_read_addr_index): Update comment.
4352         (read_str_index): Add DW_FORM_strx.
4353         (dwarf2_string_attr): Likewise.
4354         (dwarf2_const_value_attr): Likewise.
4355         (dump_die_shallow): Likewise.
4356         (dwarf2_fetch_constant_bytes): Likewise.
4357         (skip_form_bytes): Likewise.
4358         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4359
4360 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4361
4362         PR corefiles/11608
4363         PR corefiles/18187
4364         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4365         OFFSET.  Verify if current mapping contains an ELF header.
4366         (linux_find_memory_regions_full): Adjust call to
4367         dump_mapping_p.
4368
4369 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4370             Kang Li <kanglictf@gmail.com>
4371
4372         PR gdb/21600
4373
4374         * dwarf2-frame.c (read_initial_length): Be consistent about using
4375         unsigned representation of length.
4376         (decode_frame_entry_1): Likewise.  Check for wraparound of
4377         end pointer as well as buffer overflow.
4378
4379 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4380
4381         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4382         "vq".
4383
4384 2019-04-24  Tom Tromey  <tromey@adacore.com>
4385
4386         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4387
4388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4389
4390         * s12z-tdep.c (s12z_unwind_pc): Delete.
4391         (s12z_unwind_sp): Delete.
4392         (s12z_gdbarch_init): Don't register deleted functions with
4393         gdbarch.
4394
4395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4396
4397         * rl78-tdep.c (rl78_unwind_sp): Delete.
4398         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4399
4400 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4401
4402         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4403         (xstormy16_unwind_pc): Delete.
4404         (xstormy16_dummy_id): Delete.
4405         (xstormy16_gdbarch_init): Don't register deleted functions with
4406         gdbarch.
4407
4408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4409
4410         * vax-tdep.c (vax_unwind_pc): Delete.
4411         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4412
4413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4414
4415         * v850-tdep.c (v850_unwind_sp): Delete.
4416         (v850_unwind_pc): Delete.
4417         (v850_dummy_id): Delete.
4418         (v850_gdbarch_init): Don't register deleted functions with
4419         gdbarch.
4420
4421 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4422
4423         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4424         (tilegx_unwind_pc): Delete.
4425         (tilegx_unwind_dummy_id): Delete.
4426         (tilegx_gdbarch_init): Don't register deleted functions with
4427         gdbarch.
4428
4429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4430
4431         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4432         (tic6x_dummy_id): Delete.
4433         (tic6x_gdbarch_init): Don't register deleted functions with
4434         gdbarch.
4435
4436 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4437
4438         * sparc-tdep.c (sparc_unwind_pc): Delete.
4439         (sparc32_gdbarch_init): Don't register deleted function with
4440         gdbarch.
4441
4442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4443
4444         * sh-tdep.c (sh_unwind_sp): Delete.
4445         (sh_unwind_pc): Delete.
4446         (sh_dummy_id): Delete.
4447         (sh_gdbarch_init): Don't register deleted functions with
4448         gdbarch.
4449
4450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4451
4452         * score-tdep.c (score_unwind_sp): Delete.
4453         (score_unwind_pc): Delete.
4454         (score_dummy_id): Delete.
4455         (score_gdbarch_init): Don't register deleted functions with
4456         gdbarch.
4457
4458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4459
4460         * rx-tdep.c (rx_unwind_pc): Delete.
4461         (rx_unwind_sp): Delete.
4462         (rx_dummy_id): Delete.
4463         (rx_gdbarch_init): Don't register deleted functions with
4464         gdbarch.  Update comment.
4465
4466 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4467
4468         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4469         (rs6000_dummy_id): Delete.
4470         (rs6000_gdbarch_init): Don't register deleted functions with
4471         gdbarch.
4472
4473 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4474
4475         * or1k-tdep.c (or1k_dummy_id): Delete.
4476         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4477
4478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4479
4480         * nios2-tdep.c (nios2_dummy_id): Delete.
4481         (nios2_unwind_sp): Delete.
4482         (nios2_gdbarch_init): Don't register deleted functions with
4483         gdbarch.
4484
4485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4486
4487         * nds32-tdep.c (nds32_dummy_id): Delete.
4488         (nds32_unwind_pc): Delete.
4489         (nds32_unwind_sp): Delete.
4490         (nds32_gdbarch_init): Don't register deleted functions with
4491         gdbarch.
4492
4493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4494
4495         * msp430-tdep.c (msp430_unwind_pc): Delete.
4496         (msp430_unwind_sp): Delete.
4497         (msp430_dummy_id): Delete.
4498         (msp430_gdbarch_init): Don't register deleted functions with
4499         gdbarch.
4500
4501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4502
4503         * moxie-tdep.c (moxie_unwind_sp): Delete.
4504         (moxie_unwind_pc): Delete.
4505         (moxie_dummy_id): Delete.
4506         (moxie_gdbarch_init): Don't register deleted functions with
4507         gdbarch.
4508
4509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4510
4511         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4512         (mn10300_unwind_pc): Delete.
4513         (mn10300_unwind_sp): Delete.
4514         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4515         mn10300_unwind_sp.
4516         (mn10300_frame_unwind_init): Don't register deleted functions with
4517         gdbarch.
4518
4519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4520
4521         * mep-tdep.c (mep_unwind_pc): Delete.
4522         (mep_unwind_sp): Delete.
4523         (mep_dummy_id): Delete.
4524         (mep_gdbarch_init): Don't register deleted functions with
4525         gdbarch.
4526
4527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4528
4529         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4530         (m68hc11_unwind_sp): Delete.
4531         (m68hc11_gdbarch_init): Don't register deleted functions with
4532         gdbarch.
4533
4534 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4535
4536         * m32r-tdep.c (m32r_unwind_sp): Delete.
4537         (m32r_unwind_pc): Delete.
4538         (m32r_dummy_id): Delete.
4539         (m32r_gdbarch_init): Don't register deleted functions with
4540         gdbarch.
4541
4542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4543
4544         * m32c-tdep.c (m32c_unwind_pc): Delete.
4545         (m32c_unwind_sp): Delete.
4546         (m32c_dummy_id): Delete.
4547         (m32c_gdbarch_init): Don't register deleted functions with
4548         gdbarch.
4549
4550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4551
4552         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4553         (lm32_unwind_pc): Delete.
4554         (lm32_dummy_id): Delete.
4555         (lm32_gdbarch_init): Don't register deleted functions with
4556         gdbarch.
4557
4558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4559
4560         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4561         (iq2000_unwind_pc): Delete.
4562         (iq2000_dummy_id): Delete.
4563         (iq2000_gdbarch_init): Don't register deleted functions with
4564         gdbarch.
4565
4566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * nds32-tdep.c (nds32_type_align): Delete.
4569         (nds32_push_dummy_call): Use type_align instead.
4570
4571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4572
4573         * arm-tdep.c (arm_type_align): Only handle vector override case.
4574         (arm_push_dummy_call): Use type_align.
4575         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4576
4577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4580         case.
4581         (pass_on_stack): Use type_align.
4582         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4583         function.
4584
4585 2019-04-23  Tom Tromey  <tromey@adacore.com>
4586
4587         * dwarf2read.c (line_header::file_name_at): Remove unused
4588         overload.
4589
4590 2019-04-23  Tom de Vries  <tdevries@suse.de>
4591
4592         PR gdb/24438
4593         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4594         invocation.
4595
4596
4597 2019-03-27  Ali Tamur  <tamur@google.com>
4598
4599         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4600         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4601         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4602         (dwarf_expr_context::get_addr_index): Likewise
4603         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4604         (symbol_needs_eval_context::get_addr_index): Likewise
4605         (disassemble_dwarf_expression): Add DW_OP_addrx
4606         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4607         (read_cutu_die_from_dwo): Update comment
4608         (skip_one_die): Add DW_FORM_addrx
4609         (read_attribute_value): Likewise
4610         (var_decode_location): Add DW_OP_addrx
4611         (dwarf2_const_value_attr): Add DW_FORM_addrx
4612         (dump_die_shallow): Likewise
4613         (dwarf2_fetch_constant_bytes): Likewise
4614         (decode_locdesc): Add DW_OP_addrx
4615         (skip_form_bytes): Add DW_FORM_addrx
4616
4617 2019-04-22  Ali Tamur  <tamur@google.com>
4618
4619         * MAINTAINERS (Write After Approval): Add self.
4620
4621 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4622
4623         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4624         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4625         (open_symbol_file_object): Likewise.
4626         (svr4_default_sos): Add info parameter.
4627         (svr4_read_so_list): Likewise.
4628         (svr4_current_sos_direct): Adjust functions calls to pass down
4629         info.
4630         (svr4_current_sos_1): Add info parameter.
4631         (svr4_current_sos): Call get_svr4_info, pass info down to
4632         svr4_current_sos_1.
4633         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4634         get_svr4_info.
4635         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4636         get_svr4_info.
4637         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4638         to get_svr4_info.
4639         (probes_table_remove_objfile_probes): Likewise.
4640         (register_solib_event_probe): Add info parameter.
4641         (solist_update_incremental): Pass info parameter down to
4642         svr4_read_so_list.
4643         (disable_probes_interface): Add info parameter.
4644         (svr4_handle_solib_event): Pass current_program_space to
4645         get_svr4_info.  Adjust disable_probes_interface cleanup.
4646         (svr4_create_probe_breakpoints): Add info parameter, pass it
4647         down to register_solib_event_probe.
4648         (svr4_create_solib_event_breakpoints): Add info parameter,
4649         pass it down to svr4_create_probe_breakpoints.
4650         (enable_break): Pass info down to
4651         svr4_create_solib_event_breakpoints.
4652         (svr4_solib_create_inferior_hook): Pass current_program_space to
4653         get_svr4_info.
4654         (svr4_clear_solib): Likewise.
4655
4656 2019-04-22  Pedro Alves  <palves@redhat.com>
4657
4658         * solib-svr4.c (svr4_free_objfile_observer): New.
4659         (probe_and_action::objfile): New field.
4660         (probes_table_htab_remove_objfile_probes)
4661         (probes_table_remove_objfile_probes): New functions.
4662         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4663         in the new probe_and_action.  Don't store the probe in 'lookup'.
4664         (svr4_create_probe_breakpoints): Pass objfile to
4665         register_solib_event_probe.
4666         (_initialize_svr4_solib): Register a free_objfile observer.
4667
4668 2019-04-19  Tom Tromey  <tom@tromey.com>
4669
4670         * common/queue.h: Remove.
4671
4672 2019-04-19  Tom Tromey  <tom@tromey.com>
4673
4674         * event-loop.c: Don't include "common/queue.h".
4675
4676 2019-04-19  Tom Tromey  <tom@tromey.com>
4677
4678         * remote.c (remote_target): Use delete.
4679         * remote-notif.h: Include <list>, not "common/queue.h".
4680         (notif_client_p): Remove typedef.
4681         (remote_notif_state): Add constructor, destructor, initializer.
4682         <notif_queue>: Now a std::list.
4683         (remote_notif_state_xfree): Don't declare.
4684         * remote-notif.c (remote_notif_process, handle_notification)
4685         (remote_notif_state_allocate): Update.
4686         (~remote_notif_state): Rename from remote_notif_state_xfree.
4687
4688 2019-04-19  Tom Tromey  <tom@tromey.com>
4689
4690         * symfile.c (reread_symbols): Update.
4691         * objfiles.c (objfile_register_static_link)
4692         (objfile_lookup_static_link): Update
4693         (~objfile) Don't delete static_links.
4694         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4695
4696 2019-04-19  Tom Tromey  <tom@tromey.com>
4697
4698         * type-stack.h (struct type_stack) <insert>: Constify string.
4699         * type-stack.c (type_stack::insert): Constify string.
4700         * gdbtypes.h (lookup_template_type): Update.
4701         (address_space_name_to_int): Update.
4702         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4703         const.
4704         (lookup_template_type): Make name const.
4705         * c-exp.y: Update rules.
4706         (lex_one_token, classify_name, classify_inner_name)
4707         (c_print_token): Update.
4708         * p-exp.y: Update rules.
4709         (yylex): Update.
4710         * f-exp.y: Update rules.
4711         (yylex): Update.
4712         * d-exp.y: Update rules.
4713         (lex_one_token, classify_name, classify_inner_name): Update.
4714         * parse.c (write_dollar_variable, copy_name): Return std::string.
4715         * parser-defs.h (copy_name): Change return type.
4716         * m2-exp.y: Update rules.
4717         (yylex): Update.
4718         * go-exp.y (lex_one_token): Update.
4719         Update rules.
4720         (classify_unsafe_function, classify_packaged_name)
4721         (classify_name, yylex): Update.
4722
4723 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4724
4725         * configure.ac: add --enable-source-highlight switch.
4726         * configure: Regenerate.
4727         * top.c (print_gdb_version): plumb --enable-source-highlight
4728         status to "show configuration".
4729
4730 2019-04-19  Tom Tromey  <tromey@adacore.com>
4731
4732         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4733         Check ADA_TYPE_P.
4734         (empty_record, ada_template_to_fixed_record_type_1)
4735         (template_to_static_fixed_type)
4736         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4737         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4738         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4739         macros.
4740
4741 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4742
4743         PR symtab/24423:
4744         * source.c (print_source_lines_base): Advance "iter" when a
4745         control character is seen.
4746
4747 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4748
4749         * inferior.h (struct infcall_suspend_state_deleter):
4750         Catch exception in destructor to avoid crash.
4751
4752 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4753
4754         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4755         close to the add_com "shell".
4756
4757 2019-04-18  Tom Tromey  <tromey@adacore.com>
4758
4759         * process-stratum-target.h (class process_stratum_target)
4760         <stratum>: Add "final".
4761
4762 2019-04-17  Tom Tromey  <tromey@adacore.com>
4763
4764         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4765         against nullptr before use.
4766
4767 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4768
4769         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4770
4771 2019-04-17  Jim Wilson  <jimw@sifive.com>
4772             Andrew Burgess  <andrew.burgess@embecosm.com>
4773
4774         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4775         code read might fail, assume 4-byte breakpoint in that case.
4776
4777 2019-04-15  Leszek Swirski  <leszeks@google.com>
4778
4779         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4780         rather than a hand-rolled POD check when checking for forced MEMORY
4781         classification.
4782
4783 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4784
4785         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4786         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4787         function.
4788         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4789         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4790         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4791         declaration.
4792
4793 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4794
4795         * aarch64-linux-nat.c
4796         (aarch64_linux_nat_target::thread_architecture): Add override.
4797         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4798         each VQ.
4799
4800 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4801
4802         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4803
4804 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4805
4806         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4807         target types of size 96-bits, add some additional comments, and
4808         check that the builtin type we found was the correct size.
4809
4810 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4811
4812         * utils.c (prompt_for_continue): Don't restore the styling at the
4813         end, as applied_style has the wrong value.  This fixes styling in
4814         long lists of file names that are interrupted by the "Continue?"
4815         prompt.
4816
4817 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4820         * c-lang.c (c_language_defn): Likewise.
4821         (cplus_language_defn): Likewise.
4822         (asm_language_defn): Likewise.
4823         (minimal_language_defn): Likewise.
4824         * d-lang.c (d_language_defn): Likewise.
4825         * f-lang.c (f_language_defn): Likewise.
4826         * go-lang.c (go_language_defn): Likewise.
4827         * language.c (unknown_language_defn): Likewise.
4828         (auto_language_defn): Likewise.
4829         * language.h (struct language_defn): Remove la_magic field.
4830         (LANG_MAGIC): Delete.
4831         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4832         * objc-lang.c (objc_language_defn): Likewise.
4833         * opencl-lang.c (opencl_language_defn): Likewise.
4834         * p-lang.c (pascal_language_defn): Likewise.
4835         * rust-lang.c (rust_language_defn): Likewise.
4836
4837 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4838
4839         * riscv-tdep.c (riscv_type_align): New function.
4840         (riscv_type_alignment): Delete.
4841         (riscv_arg_location): Use 'type_align'.
4842         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4843
4844 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4845
4846         * gdbtypes.c (type_align): A struct with no non-static fields also
4847         has alignment of 1.
4848
4849 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4850
4851         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4852         component to 0.
4853         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4854         member.
4855         (riscv_struct_info::analyse): New implementation using new
4856         analyse_inner member function.
4857         (riscv_struct_info::field_offset): New member function.
4858         (riscv_struct_info::m_offsets): New member variable.
4859         (riscv_struct_info::analyse_inner): New private member function,
4860         takes the old implementation of riscv_struct_info::analyse but
4861         extended to track field offsets.
4862         (riscv_call_arg_struct): Update the struct folding special cases
4863         to handle cases where empty C++ structs, which are non-zero
4864         length, are found.
4865         (riscv_arg_location): Initialise the length of each location, a
4866         non-zero length now indicates the location is in use.
4867         (riscv_push_dummy_call): Allow for the first location having a
4868         non-zero offset when setting up arguments.
4869         (riscv_return_value): Likewise, but for return values.
4870
4871 2019-04-11  Tom Tromey  <tromey@adacore.com>
4872
4873         * utils.c (internal_vproblem): Make "msg" const.
4874
4875 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4876
4877         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4878         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4879         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4880         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4881
4882 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4883
4884         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4885         function.
4886         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4887         of amd64_collect_native_gregset.
4888         (amd64_linux_nat_target::store_registers): Likewise.
4889
4890 2019-04-10  Tom Tromey  <tom@tromey.com>
4891
4892         * symtab.c (lookup_global_symbol_from_objfile)
4893         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4894         * objfiles.h (class separate_debug_iterator): New.
4895         (class separate_debug_range): New.
4896         (struct objfile) <separate_debug_objfiles>: New method.
4897         (objfile_separate_debug_iterate): Don't declare.
4898         * objfiles.c (separate_debug_iterator::operator++): Rename from
4899         objfile_separate_debug_iterate.
4900         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4901         iterator.
4902         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4903         iterator.
4904
4905 2019-04-10  Tom Tromey  <tom@tromey.com>
4906
4907         * symfile.c (reread_symbols): Remove old comment.
4908         * objfiles.c (free_all_objfiles): Fix a typo.
4909
4910 2019-04-10  Tom Tromey  <tom@tromey.com>
4911
4912         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4913         * minsyms.c (lookup_minimal_symbol): Use foreach.
4914         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4915         (lookup_minimal_symbol_solib_trampoline): Likewise.
4916         * symfile.c (reread_symbols): Use foreach.
4917
4918 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4919             Tom Tromey  <tromey@adacore.com>
4920
4921         PR rust/24414:
4922         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4923         (rust_lex_int_test): Change "value" to be LONGEST.
4924         (rust_lex_tests): Add test for long integer literal.
4925
4926 2019-04-09  Tom Tromey  <tromey@adacore.com>
4927
4928         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4929         to bool.
4930         (extended_remote_target::attach): Update.
4931         (remote_target::remote_notice_new_inferior): Update.
4932         (remote_target::add_current_inferior_and_thread): Update.
4933         * inferior.c (exit_inferior_1): Use "false".
4934         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4935
4936 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4937
4938         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4939         the "start" command.
4940
4941 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4942
4943         * python/py-inferior.c (infpy_thread_from_thread_handle):
4944         Adjust comments to reflect renaming of thread_from_thread_handle
4945         to thread_from_handle.  Adjust keywords.  Fix type error message.
4946         (inferior_object_methods): Add thread_from_handle.  Retain
4947         thread_from_thread_handle, but mark it as deprecated.
4948
4949 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4950
4951         * gdbthread.h (find_thread_by_handle): Revise declaration.
4952         * thread.c (find_thread_by_handle): Likewise.  Adjust
4953         implementation too.
4954         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4955         support for buffer objects as handles.
4956
4957 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4958
4959         * python/py-infthread.c (thpy_thread_handle): New function.
4960         (thread_object_methods): Register thpy_thread_handle.
4961
4962 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4963
4964         * gdbthread.h (thread_to_thread_handle): Declare.
4965         * thread.c (gdbtypes.h): Include.
4966         (thread_to_thread_handle): New function.
4967
4968         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4969         (target_thread_info_to_thread_handle): Declare.
4970         * target.c (target_thread_info_to_thread_handle): New function.
4971         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4972         * target-delegates.c: Regenerate.
4973
4974         * linux-thread-db.c (class thread_db_target): Add method
4975         thread_info_to_thread_handle.
4976         (thread_db_target::thread_info_to_thread_handle): Define.
4977         * remote.c (class remote_target): Add new method
4978         thread_info_to_thread_handle.
4979         (remote_target::thread_info_to_thread_handle): Define.
4980
4981 2019-04-08  Pedro Alves  <palves@redhat.com>
4982
4983         * common/common-exceptions.c (throw_exception): Don't create
4984         named object to throw; throw directly.
4985         (throw_it): Likewise.  Don't initialize gdb_exception::message
4986         here, with new; pass FMT and AP to the ctor instead.
4987         * common/common-exceptions.h: Include <string>.
4988         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4989         const char *, va_list)): New ctor.  Use std::make_shared.
4990         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4991         errors)): Delete.
4992         (gdb_exception_error::gdb_exception_error(enum errors, const char
4993         *, va_list)): New.
4994         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4995         Add assertion.
4996         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4997         errors)): Delete.
4998         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4999         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5000         Add assertion.
5001
5002 2019-04-08  Tom Tromey  <tom@tromey.com>
5003
5004         * valops.c (value_rtti_indirect_type): Replace throw_exception
5005         with throw.
5006         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5007         with throw.
5008         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5009         throw.
5010         * target.c (target_translate_tls_address): Replace throw_exception
5011         with throw.
5012         * stack.c (frame_apply_command_count): Replace throw_exception
5013         with throw.
5014         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5015         throw.
5016         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5017         with throw.
5018         * rs6000-tdep.c (rs6000_frame_cache)
5019         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5020         * remote.c: Replace throw_exception with throw.
5021         * record-full.c (record_full_message, record_full_wait_1)
5022         (record_full_restore): Replace throw_exception with throw.
5023         * record-btrace.c:
5024         (get_thread_current_frame_id, record_btrace_start_replaying)
5025         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5026         (cmd_record_btrace_start): Replace throw_exception with throw.
5027         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5028         throw.
5029         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5030         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5031         * linespec.c:
5032         (find_linespec_symbols): Replace throw_exception with throw.
5033         * infrun.c (displaced_step_prepare, resume): Replace
5034         throw_exception with throw.
5035         * infcmd.c (post_create_inferior): Replace throw_exception with
5036         throw.
5037         * inf-loop.c (inferior_event_handler): Replace throw_exception
5038         with throw.
5039         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5040         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5041         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5042         (get_prev_frame_always, get_frame_pc_if_available)
5043         (get_frame_address_in_block_if_available, get_frame_language):
5044         Replace throw_exception with throw.
5045         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5046         throw_exception with throw.
5047         * eval.c (fetch_subexp_value, evaluate_var_value)
5048         (evaluate_funcall, evaluate_subexp_standard): Replace
5049         throw_exception with throw.
5050         * dwarf2loc.c (call_site_find_chain)
5051         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5052         Replace throw_exception with throw.
5053         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5054         with throw.
5055         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5056         throw.
5057         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5058         * completer.c (complete_line_internal): Replace throw_exception
5059         with throw.
5060         * compile/compile-object-run.c (compile_object_run): Replace
5061         throw_exception with throw.
5062         * cli/cli-script.c (process_next_line): Replace throw_exception
5063         with throw.
5064         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5065         (btrace_enable, btrace_maint_update_pt_packets): Replace
5066         throw_exception with throw.
5067         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5068         throw_exception with throw.
5069         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5070         throw_exception with throw.
5071         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5072         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5073         * aarch64-tdep.c (aarch64_make_prologue_cache)
5074         (aarch64_make_stub_cache): Replace throw_exception with throw.
5075
5076 2019-04-08  Tom Tromey  <tom@tromey.com>
5077
5078         * common/common-exceptions.c (throw_exception): Rename from
5079         throw_exception_cxx.  Remove old copy.  Make argument const.
5080         (throw_it): Create and throw exception objects directly.
5081         * common/common-exceptions.h (throw_exception): Make argument
5082         const.
5083         (struct gdb_exception_error): Add constructor.
5084         (struct gdb_exception_quit): Add constructor.
5085
5086 2019-04-08  Tom Tromey  <tom@tromey.com>
5087
5088         * common/common-exceptions.h (exception_rethrow): Don't declare.
5089         (TRY_SJLJ): Update comment.
5090         (TRY, CATCH, END_CATCH): Remove.
5091         * common/common-exceptions.c (exception_rethrow): Remove.
5092
5093 2019-04-08  Tom Tromey  <tom@tromey.com>
5094
5095         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5096         Remove.
5097         (gdb_exception_error): Rename from
5098         gdb_exception_RETURN_MASK_ERROR.
5099         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5100         (gdb_quit_bad_alloc): Update.
5101         * aarch64-tdep.c: Update.
5102         * ada-lang.c: Update.
5103         * ada-typeprint.c: Update.
5104         * ada-valprint.c: Update.
5105         * amd64-tdep.c: Update.
5106         * arch-utils.c: Update.
5107         * break-catch-throw.c: Update.
5108         * breakpoint.c: Update.
5109         * btrace.c: Update.
5110         * c-varobj.c: Update.
5111         * cli/cli-cmds.c: Update.
5112         * cli/cli-interp.c: Update.
5113         * cli/cli-script.c: Update.
5114         * common/common-exceptions.c: Update.
5115         * common/new-op.c: Update.
5116         * common/selftest.c: Update.
5117         * compile/compile-c-symbols.c: Update.
5118         * compile/compile-cplus-symbols.c: Update.
5119         * compile/compile-object-load.c: Update.
5120         * compile/compile-object-run.c: Update.
5121         * completer.c: Update.
5122         * corelow.c: Update.
5123         * cp-abi.c: Update.
5124         * cp-support.c: Update.
5125         * cp-valprint.c: Update.
5126         * darwin-nat.c: Update.
5127         * disasm-selftests.c: Update.
5128         * dtrace-probe.c: Update.
5129         * dwarf-index-cache.c: Update.
5130         * dwarf-index-write.c: Update.
5131         * dwarf2-frame-tailcall.c: Update.
5132         * dwarf2-frame.c: Update.
5133         * dwarf2loc.c: Update.
5134         * dwarf2read.c: Update.
5135         * eval.c: Update.
5136         * event-loop.c: Update.
5137         * event-top.c: Update.
5138         * exec.c: Update.
5139         * f-valprint.c: Update.
5140         * fbsd-tdep.c: Update.
5141         * frame-unwind.c: Update.
5142         * frame.c: Update.
5143         * gdbtypes.c: Update.
5144         * gnu-v3-abi.c: Update.
5145         * guile/guile-internal.h: Update.
5146         * guile/scm-block.c: Update.
5147         * guile/scm-breakpoint.c: Update.
5148         * guile/scm-cmd.c: Update.
5149         * guile/scm-disasm.c: Update.
5150         * guile/scm-frame.c: Update.
5151         * guile/scm-lazy-string.c: Update.
5152         * guile/scm-math.c: Update.
5153         * guile/scm-param.c: Update.
5154         * guile/scm-ports.c: Update.
5155         * guile/scm-pretty-print.c: Update.
5156         * guile/scm-symbol.c: Update.
5157         * guile/scm-symtab.c: Update.
5158         * guile/scm-type.c: Update.
5159         * guile/scm-value.c: Update.
5160         * i386-linux-tdep.c: Update.
5161         * i386-tdep.c: Update.
5162         * inf-loop.c: Update.
5163         * infcall.c: Update.
5164         * infcmd.c: Update.
5165         * infrun.c: Update.
5166         * jit.c: Update.
5167         * language.c: Update.
5168         * linespec.c: Update.
5169         * linux-fork.c: Update.
5170         * linux-nat.c: Update.
5171         * linux-tdep.c: Update.
5172         * linux-thread-db.c: Update.
5173         * main.c: Update.
5174         * mi/mi-cmd-break.c: Update.
5175         * mi/mi-cmd-stack.c: Update.
5176         * mi/mi-interp.c: Update.
5177         * mi/mi-main.c: Update.
5178         * objc-lang.c: Update.
5179         * p-valprint.c: Update.
5180         * parse.c: Update.
5181         * ppc-linux-tdep.c: Update.
5182         * printcmd.c: Update.
5183         * python/py-arch.c: Update.
5184         * python/py-breakpoint.c: Update.
5185         * python/py-cmd.c: Update.
5186         * python/py-finishbreakpoint.c: Update.
5187         * python/py-frame.c: Update.
5188         * python/py-framefilter.c: Update.
5189         * python/py-gdb-readline.c: Update.
5190         * python/py-inferior.c: Update.
5191         * python/py-infthread.c: Update.
5192         * python/py-lazy-string.c: Update.
5193         * python/py-linetable.c: Update.
5194         * python/py-objfile.c: Update.
5195         * python/py-param.c: Update.
5196         * python/py-prettyprint.c: Update.
5197         * python/py-progspace.c: Update.
5198         * python/py-record-btrace.c: Update.
5199         * python/py-record.c: Update.
5200         * python/py-symbol.c: Update.
5201         * python/py-type.c: Update.
5202         * python/py-unwind.c: Update.
5203         * python/py-utils.c: Update.
5204         * python/py-value.c: Update.
5205         * python/python.c: Update.
5206         * record-btrace.c: Update.
5207         * record-full.c: Update.
5208         * remote-fileio.c: Update.
5209         * remote.c: Update.
5210         * riscv-tdep.c: Update.
5211         * rs6000-aix-tdep.c: Update.
5212         * rs6000-tdep.c: Update.
5213         * rust-exp.y: Update.
5214         * rust-lang.c: Update.
5215         * s390-tdep.c: Update.
5216         * selftest-arch.c: Update.
5217         * solib-dsbt.c: Update.
5218         * solib-frv.c: Update.
5219         * solib-spu.c: Update.
5220         * solib-svr4.c: Update.
5221         * solib.c: Update.
5222         * sparc64-linux-tdep.c: Update.
5223         * stack.c: Update.
5224         * symfile-mem.c: Update.
5225         * symmisc.c: Update.
5226         * target.c: Update.
5227         * thread.c: Update.
5228         * top.c: Update.
5229         * tracefile-tfile.c: Update.
5230         * tui/tui.c: Update.
5231         * typeprint.c: Update.
5232         * unittests/cli-utils-selftests.c: Update.
5233         * unittests/parse-connection-spec-selftests.c: Update.
5234         * valops.c: Update.
5235         * valprint.c: Update.
5236         * value.c: Update.
5237         * varobj.c: Update.
5238         * windows-nat.c: Update.
5239         * x86-linux-nat.c: Update.
5240         * xml-support.c: Update.
5241
5242 2019-04-08  Tom Tromey  <tom@tromey.com>
5243
5244         * xml-support.c: Use C++ exception handling.
5245         * x86-linux-nat.c: Use C++ exception handling.
5246         * windows-nat.c: Use C++ exception handling.
5247         * varobj.c: Use C++ exception handling.
5248         * value.c: Use C++ exception handling.
5249         * valprint.c: Use C++ exception handling.
5250         * valops.c: Use C++ exception handling.
5251         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5252         handling.
5253         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5254         * typeprint.c: Use C++ exception handling.
5255         * tui/tui.c: Use C++ exception handling.
5256         * tracefile-tfile.c: Use C++ exception handling.
5257         * top.c: Use C++ exception handling.
5258         * thread.c: Use C++ exception handling.
5259         * target.c: Use C++ exception handling.
5260         * symmisc.c: Use C++ exception handling.
5261         * symfile-mem.c: Use C++ exception handling.
5262         * stack.c: Use C++ exception handling.
5263         * sparc64-linux-tdep.c: Use C++ exception handling.
5264         * solib.c: Use C++ exception handling.
5265         * solib-svr4.c: Use C++ exception handling.
5266         * solib-spu.c: Use C++ exception handling.
5267         * solib-frv.c: Use C++ exception handling.
5268         * solib-dsbt.c: Use C++ exception handling.
5269         * selftest-arch.c: Use C++ exception handling.
5270         * s390-tdep.c: Use C++ exception handling.
5271         * rust-lang.c: Use C++ exception handling.
5272         * rust-exp.y: Use C++ exception handling.
5273         * rs6000-tdep.c: Use C++ exception handling.
5274         * rs6000-aix-tdep.c: Use C++ exception handling.
5275         * riscv-tdep.c: Use C++ exception handling.
5276         * remote.c: Use C++ exception handling.
5277         * remote-fileio.c: Use C++ exception handling.
5278         * record-full.c: Use C++ exception handling.
5279         * record-btrace.c: Use C++ exception handling.
5280         * python/python.c: Use C++ exception handling.
5281         * python/py-value.c: Use C++ exception handling.
5282         * python/py-utils.c: Use C++ exception handling.
5283         * python/py-unwind.c: Use C++ exception handling.
5284         * python/py-type.c: Use C++ exception handling.
5285         * python/py-symbol.c: Use C++ exception handling.
5286         * python/py-record.c: Use C++ exception handling.
5287         * python/py-record-btrace.c: Use C++ exception handling.
5288         * python/py-progspace.c: Use C++ exception handling.
5289         * python/py-prettyprint.c: Use C++ exception handling.
5290         * python/py-param.c: Use C++ exception handling.
5291         * python/py-objfile.c: Use C++ exception handling.
5292         * python/py-linetable.c: Use C++ exception handling.
5293         * python/py-lazy-string.c: Use C++ exception handling.
5294         * python/py-infthread.c: Use C++ exception handling.
5295         * python/py-inferior.c: Use C++ exception handling.
5296         * python/py-gdb-readline.c: Use C++ exception handling.
5297         * python/py-framefilter.c: Use C++ exception handling.
5298         * python/py-frame.c: Use C++ exception handling.
5299         * python/py-finishbreakpoint.c: Use C++ exception handling.
5300         * python/py-cmd.c: Use C++ exception handling.
5301         * python/py-breakpoint.c: Use C++ exception handling.
5302         * python/py-arch.c: Use C++ exception handling.
5303         * printcmd.c: Use C++ exception handling.
5304         * ppc-linux-tdep.c: Use C++ exception handling.
5305         * parse.c: Use C++ exception handling.
5306         * p-valprint.c: Use C++ exception handling.
5307         * objc-lang.c: Use C++ exception handling.
5308         * mi/mi-main.c: Use C++ exception handling.
5309         * mi/mi-interp.c: Use C++ exception handling.
5310         * mi/mi-cmd-stack.c: Use C++ exception handling.
5311         * mi/mi-cmd-break.c: Use C++ exception handling.
5312         * main.c: Use C++ exception handling.
5313         * linux-thread-db.c: Use C++ exception handling.
5314         * linux-tdep.c: Use C++ exception handling.
5315         * linux-nat.c: Use C++ exception handling.
5316         * linux-fork.c: Use C++ exception handling.
5317         * linespec.c: Use C++ exception handling.
5318         * language.c: Use C++ exception handling.
5319         * jit.c: Use C++ exception handling.
5320         * infrun.c: Use C++ exception handling.
5321         * infcmd.c: Use C++ exception handling.
5322         * infcall.c: Use C++ exception handling.
5323         * inf-loop.c: Use C++ exception handling.
5324         * i386-tdep.c: Use C++ exception handling.
5325         * i386-linux-tdep.c: Use C++ exception handling.
5326         * guile/scm-value.c: Use C++ exception handling.
5327         * guile/scm-type.c: Use C++ exception handling.
5328         * guile/scm-symtab.c: Use C++ exception handling.
5329         * guile/scm-symbol.c: Use C++ exception handling.
5330         * guile/scm-pretty-print.c: Use C++ exception handling.
5331         * guile/scm-ports.c: Use C++ exception handling.
5332         * guile/scm-param.c: Use C++ exception handling.
5333         * guile/scm-math.c: Use C++ exception handling.
5334         * guile/scm-lazy-string.c: Use C++ exception handling.
5335         * guile/scm-frame.c: Use C++ exception handling.
5336         * guile/scm-disasm.c: Use C++ exception handling.
5337         * guile/scm-cmd.c: Use C++ exception handling.
5338         * guile/scm-breakpoint.c: Use C++ exception handling.
5339         * guile/scm-block.c: Use C++ exception handling.
5340         * guile/guile-internal.h: Use C++ exception handling.
5341         * gnu-v3-abi.c: Use C++ exception handling.
5342         * gdbtypes.c: Use C++ exception handling.
5343         * frame.c: Use C++ exception handling.
5344         * frame-unwind.c: Use C++ exception handling.
5345         * fbsd-tdep.c: Use C++ exception handling.
5346         * f-valprint.c: Use C++ exception handling.
5347         * exec.c: Use C++ exception handling.
5348         * event-top.c: Use C++ exception handling.
5349         * event-loop.c: Use C++ exception handling.
5350         * eval.c: Use C++ exception handling.
5351         * dwarf2read.c: Use C++ exception handling.
5352         * dwarf2loc.c: Use C++ exception handling.
5353         * dwarf2-frame.c: Use C++ exception handling.
5354         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5355         * dwarf-index-write.c: Use C++ exception handling.
5356         * dwarf-index-cache.c: Use C++ exception handling.
5357         * dtrace-probe.c: Use C++ exception handling.
5358         * disasm-selftests.c: Use C++ exception handling.
5359         * darwin-nat.c: Use C++ exception handling.
5360         * cp-valprint.c: Use C++ exception handling.
5361         * cp-support.c: Use C++ exception handling.
5362         * cp-abi.c: Use C++ exception handling.
5363         * corelow.c: Use C++ exception handling.
5364         * completer.c: Use C++ exception handling.
5365         * compile/compile-object-run.c: Use C++ exception handling.
5366         * compile/compile-object-load.c: Use C++ exception handling.
5367         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5368         * compile/compile-c-symbols.c: Use C++ exception handling.
5369         * common/selftest.c: Use C++ exception handling.
5370         * common/new-op.c: Use C++ exception handling.
5371         * cli/cli-script.c: Use C++ exception handling.
5372         * cli/cli-interp.c: Use C++ exception handling.
5373         * cli/cli-cmds.c: Use C++ exception handling.
5374         * c-varobj.c: Use C++ exception handling.
5375         * btrace.c: Use C++ exception handling.
5376         * breakpoint.c: Use C++ exception handling.
5377         * break-catch-throw.c: Use C++ exception handling.
5378         * arch-utils.c: Use C++ exception handling.
5379         * amd64-tdep.c: Use C++ exception handling.
5380         * ada-valprint.c: Use C++ exception handling.
5381         * ada-typeprint.c: Use C++ exception handling.
5382         * ada-lang.c: Use C++ exception handling.
5383         * aarch64-tdep.c: Use C++ exception handling.
5384
5385 2019-04-08  Tom Tromey  <tom@tromey.com>
5386
5387         * xml-support.c (gdb_xml_parser::parse): Update.
5388         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5389         * value.c (show_convenience): Update.
5390         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5391         (test_parse_flags_qcs): Update.
5392         * thread.c (thr_try_catch_cmd): Update.
5393         * target.c (target_translate_tls_address): Update.
5394         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5395         (info_frame_command_core, frame_apply_command_count): Update.
5396         * rust-exp.y (rust_lex_exception_test): Update.
5397         * riscv-tdep.c (riscv_print_one_register_info): Update.
5398         * remote.c (remote_target::enable_btrace): Update.
5399         * record-btrace.c (record_btrace_enable_warn): Update.
5400         * python/py-utils.c (gdbpy_convert_exception): Update.
5401         * printcmd.c (do_one_display, print_variable_and_value): Update.
5402         * mi/mi-main.c (mi_print_exception): Update.
5403         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5404         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5405         * linux-nat.c (linux_nat_target::attach): Update.
5406         * linux-fork.c (class scoped_switch_fork_info): Update.
5407         * infrun.c (displaced_step_prepare): Update.
5408         * infcall.c (call_function_by_hand_dummy): Update.
5409         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5410         * gnu-v3-abi.c (print_one_vtable): Update.
5411         * frame.c (get_prev_frame_always): Update.
5412         * f-valprint.c (info_common_command_for_block): Update.
5413         * exec.c (try_open_exec_file): Update.
5414         * exceptions.c (print_exception, exception_print)
5415         (exception_fprintf, exception_print_same): Update.
5416         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5417         * dwarf-index-cache.c (index_cache::store)
5418         (index_cache::lookup_gdb_index): Update.
5419         * darwin-nat.c (maybe_cache_shell): Update.
5420         * cp-valprint.c (cp_print_value_fields): Update.
5421         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5422         (gcc_cplus_symbol_address): Update.
5423         * compile/compile-c-symbols.c (gcc_convert_symbol)
5424         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5425         * common/selftest.c: Update.
5426         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5427         a std::string.
5428         (exception_try_scope_entry, exception_try_scope_exit): Don't
5429         declare.
5430         (struct exception_try_scope): Remove.
5431         (TRY): Don't use exception_try_scope.
5432         (struct gdb_exception): Add constructor, operator=.
5433         <what>: New method.
5434         (struct gdb_exception_RETURN_MASK_ALL)
5435         (struct gdb_exception_RETURN_MASK_ERROR)
5436         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5437         (struct gdb_quit_bad_alloc): Update.
5438         * common/common-exceptions.c (exception_none): Change
5439         initializer.
5440         (struct catcher) <state, exception>: Initialize inline.
5441         <prev>: Remove member.
5442         (current_catcher): Remove.
5443         (catchers): New global.
5444         (exceptions_state_mc_init): Simplify.
5445         (catcher_pop): Remove.
5446         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5447         (try_scope_depth, exception_try_scope_entry)
5448         (exception_try_scope_exit): Remove.
5449         (throw_exception_sjlj): Update.
5450         (exception_messages, exception_messages_size): Remove.
5451         (throw_it): Simplify.
5452         (gdb_exception_sliced_copy): Remove.
5453         (throw_exception_cxx): Update.
5454         * cli/cli-script.c (script_from_file): Update.
5455         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5456         Update.
5457         * ada-valprint.c (ada_val_print): Update.
5458         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5459         (create_excep_cond_exprs): Update.
5460
5461 2019-04-08  Tom Tromey  <tom@tromey.com>
5462
5463         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5464         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5465         (TRY, CATCH, END_CATCH): Remove some definitions.
5466         * common/common-exceptions.c: Don't use GDB_XCPT.
5467         (catcher_list_size): Remove.
5468         (throw_exception, throw_it): Simplify.
5469
5470 2019-04-05  Tom Tromey  <tom@tromey.com>
5471
5472         Revert the header-sorting patch.
5473         * ft32-tdep.c: Revert.
5474         * frv-tdep.c: Revert.
5475         * frv-linux-tdep.c: Revert.
5476         * frame.c: Revert.
5477         * frame-unwind.c: Revert.
5478         * frame-base.c: Revert.
5479         * fork-child.c: Revert.
5480         * findvar.c: Revert.
5481         * findcmd.c: Revert.
5482         * filesystem.c: Revert.
5483         * filename-seen-cache.h: Revert.
5484         * filename-seen-cache.c: Revert.
5485         * fbsd-tdep.c: Revert.
5486         * fbsd-nat.h: Revert.
5487         * fbsd-nat.c: Revert.
5488         * f-valprint.c: Revert.
5489         * f-typeprint.c: Revert.
5490         * f-lang.c: Revert.
5491         * extension.h: Revert.
5492         * extension.c: Revert.
5493         * extension-priv.h: Revert.
5494         * expprint.c: Revert.
5495         * exec.h: Revert.
5496         * exec.c: Revert.
5497         * exceptions.c: Revert.
5498         * event-top.c: Revert.
5499         * event-loop.c: Revert.
5500         * eval.c: Revert.
5501         * elfread.c: Revert.
5502         * dwarf2read.h: Revert.
5503         * dwarf2read.c: Revert.
5504         * dwarf2loc.c: Revert.
5505         * dwarf2expr.h: Revert.
5506         * dwarf2expr.c: Revert.
5507         * dwarf2-frame.c: Revert.
5508         * dwarf2-frame-tailcall.c: Revert.
5509         * dwarf-index-write.h: Revert.
5510         * dwarf-index-write.c: Revert.
5511         * dwarf-index-common.c: Revert.
5512         * dwarf-index-cache.h: Revert.
5513         * dwarf-index-cache.c: Revert.
5514         * dummy-frame.c: Revert.
5515         * dtrace-probe.c: Revert.
5516         * disasm.h: Revert.
5517         * disasm.c: Revert.
5518         * disasm-selftests.c: Revert.
5519         * dictionary.c: Revert.
5520         * dicos-tdep.c: Revert.
5521         * demangle.c: Revert.
5522         * dcache.h: Revert.
5523         * dcache.c: Revert.
5524         * darwin-nat.h: Revert.
5525         * darwin-nat.c: Revert.
5526         * darwin-nat-info.c: Revert.
5527         * d-valprint.c: Revert.
5528         * d-namespace.c: Revert.
5529         * d-lang.c: Revert.
5530         * ctf.c: Revert.
5531         * csky-tdep.c: Revert.
5532         * csky-linux-tdep.c: Revert.
5533         * cris-tdep.c: Revert.
5534         * cris-linux-tdep.c: Revert.
5535         * cp-valprint.c: Revert.
5536         * cp-support.c: Revert.
5537         * cp-namespace.c: Revert.
5538         * cp-abi.c: Revert.
5539         * corelow.c: Revert.
5540         * corefile.c: Revert.
5541         * continuations.c: Revert.
5542         * completer.h: Revert.
5543         * completer.c: Revert.
5544         * complaints.c: Revert.
5545         * coffread.c: Revert.
5546         * coff-pe-read.c: Revert.
5547         * cli-out.h: Revert.
5548         * cli-out.c: Revert.
5549         * charset.c: Revert.
5550         * c-varobj.c: Revert.
5551         * c-valprint.c: Revert.
5552         * c-typeprint.c: Revert.
5553         * c-lang.c: Revert.
5554         * buildsym.c: Revert.
5555         * buildsym-legacy.c: Revert.
5556         * build-id.h: Revert.
5557         * build-id.c: Revert.
5558         * btrace.c: Revert.
5559         * bsd-uthread.c: Revert.
5560         * breakpoint.h: Revert.
5561         * breakpoint.c: Revert.
5562         * break-catch-throw.c: Revert.
5563         * break-catch-syscall.c: Revert.
5564         * break-catch-sig.c: Revert.
5565         * blockframe.c: Revert.
5566         * block.c: Revert.
5567         * bfin-tdep.c: Revert.
5568         * bfin-linux-tdep.c: Revert.
5569         * bfd-target.c: Revert.
5570         * bcache.c: Revert.
5571         * ax-general.c: Revert.
5572         * ax-gdb.h: Revert.
5573         * ax-gdb.c: Revert.
5574         * avr-tdep.c: Revert.
5575         * auxv.c: Revert.
5576         * auto-load.c: Revert.
5577         * arm-wince-tdep.c: Revert.
5578         * arm-tdep.c: Revert.
5579         * arm-symbian-tdep.c: Revert.
5580         * arm-pikeos-tdep.c: Revert.
5581         * arm-obsd-tdep.c: Revert.
5582         * arm-nbsd-tdep.c: Revert.
5583         * arm-nbsd-nat.c: Revert.
5584         * arm-linux-tdep.c: Revert.
5585         * arm-linux-nat.c: Revert.
5586         * arm-fbsd-tdep.c: Revert.
5587         * arm-fbsd-nat.c: Revert.
5588         * arm-bsd-tdep.c: Revert.
5589         * arch-utils.c: Revert.
5590         * arc-tdep.c: Revert.
5591         * arc-newlib-tdep.c: Revert.
5592         * annotate.h: Revert.
5593         * annotate.c: Revert.
5594         * amd64-windows-tdep.c: Revert.
5595         * amd64-windows-nat.c: Revert.
5596         * amd64-tdep.c: Revert.
5597         * amd64-sol2-tdep.c: Revert.
5598         * amd64-obsd-tdep.c: Revert.
5599         * amd64-obsd-nat.c: Revert.
5600         * amd64-nbsd-tdep.c: Revert.
5601         * amd64-nbsd-nat.c: Revert.
5602         * amd64-nat.c: Revert.
5603         * amd64-linux-tdep.c: Revert.
5604         * amd64-linux-nat.c: Revert.
5605         * amd64-fbsd-tdep.c: Revert.
5606         * amd64-fbsd-nat.c: Revert.
5607         * amd64-dicos-tdep.c: Revert.
5608         * amd64-darwin-tdep.c: Revert.
5609         * amd64-bsd-nat.c: Revert.
5610         * alpha-tdep.c: Revert.
5611         * alpha-obsd-tdep.c: Revert.
5612         * alpha-nbsd-tdep.c: Revert.
5613         * alpha-mdebug-tdep.c: Revert.
5614         * alpha-linux-tdep.c: Revert.
5615         * alpha-linux-nat.c: Revert.
5616         * alpha-bsd-tdep.c: Revert.
5617         * alpha-bsd-nat.c: Revert.
5618         * aix-thread.c: Revert.
5619         * agent.c: Revert.
5620         * addrmap.c: Revert.
5621         * ada-varobj.c: Revert.
5622         * ada-valprint.c: Revert.
5623         * ada-typeprint.c: Revert.
5624         * ada-tasks.c: Revert.
5625         * ada-lang.c: Revert.
5626         * aarch64-tdep.c: Revert.
5627         * aarch64-ravenscar-thread.c: Revert.
5628         * aarch64-newlib-tdep.c: Revert.
5629         * aarch64-linux-tdep.c: Revert.
5630         * aarch64-linux-nat.c: Revert.
5631         * aarch64-fbsd-tdep.c: Revert.
5632         * aarch64-fbsd-nat.c: Revert.
5633         * aarch32-linux-nat.c: Revert.
5634
5635 2019-04-05  Tom Tromey  <tom@tromey.com>
5636
5637         * ft32-tdep.c: Sort headers.
5638         * frv-tdep.c: Sort headers.
5639         * frv-linux-tdep.c: Sort headers.
5640         * frame.c: Sort headers.
5641         * frame-unwind.c: Sort headers.
5642         * frame-base.c: Sort headers.
5643         * fork-child.c: Sort headers.
5644         * findvar.c: Sort headers.
5645         * findcmd.c: Sort headers.
5646         * filesystem.c: Sort headers.
5647         * filename-seen-cache.h: Sort headers.
5648         * filename-seen-cache.c: Sort headers.
5649         * fbsd-tdep.c: Sort headers.
5650         * fbsd-nat.h: Sort headers.
5651         * fbsd-nat.c: Sort headers.
5652         * f-valprint.c: Sort headers.
5653         * f-typeprint.c: Sort headers.
5654         * f-lang.c: Sort headers.
5655         * extension.h: Sort headers.
5656         * extension.c: Sort headers.
5657         * extension-priv.h: Sort headers.
5658         * expprint.c: Sort headers.
5659         * exec.h: Sort headers.
5660         * exec.c: Sort headers.
5661         * exceptions.c: Sort headers.
5662         * event-top.c: Sort headers.
5663         * event-loop.c: Sort headers.
5664         * eval.c: Sort headers.
5665         * elfread.c: Sort headers.
5666         * dwarf2read.h: Sort headers.
5667         * dwarf2read.c: Sort headers.
5668         * dwarf2loc.c: Sort headers.
5669         * dwarf2expr.h: Sort headers.
5670         * dwarf2expr.c: Sort headers.
5671         * dwarf2-frame.c: Sort headers.
5672         * dwarf2-frame-tailcall.c: Sort headers.
5673         * dwarf-index-write.h: Sort headers.
5674         * dwarf-index-write.c: Sort headers.
5675         * dwarf-index-common.c: Sort headers.
5676         * dwarf-index-cache.h: Sort headers.
5677         * dwarf-index-cache.c: Sort headers.
5678         * dummy-frame.c: Sort headers.
5679         * dtrace-probe.c: Sort headers.
5680         * disasm.h: Sort headers.
5681         * disasm.c: Sort headers.
5682         * disasm-selftests.c: Sort headers.
5683         * dictionary.c: Sort headers.
5684         * dicos-tdep.c: Sort headers.
5685         * demangle.c: Sort headers.
5686         * dcache.h: Sort headers.
5687         * dcache.c: Sort headers.
5688         * darwin-nat.h: Sort headers.
5689         * darwin-nat.c: Sort headers.
5690         * darwin-nat-info.c: Sort headers.
5691         * d-valprint.c: Sort headers.
5692         * d-namespace.c: Sort headers.
5693         * d-lang.c: Sort headers.
5694         * ctf.c: Sort headers.
5695         * csky-tdep.c: Sort headers.
5696         * csky-linux-tdep.c: Sort headers.
5697         * cris-tdep.c: Sort headers.
5698         * cris-linux-tdep.c: Sort headers.
5699         * cp-valprint.c: Sort headers.
5700         * cp-support.c: Sort headers.
5701         * cp-namespace.c: Sort headers.
5702         * cp-abi.c: Sort headers.
5703         * corelow.c: Sort headers.
5704         * corefile.c: Sort headers.
5705         * continuations.c: Sort headers.
5706         * completer.h: Sort headers.
5707         * completer.c: Sort headers.
5708         * complaints.c: Sort headers.
5709         * coffread.c: Sort headers.
5710         * coff-pe-read.c: Sort headers.
5711         * cli-out.h: Sort headers.
5712         * cli-out.c: Sort headers.
5713         * charset.c: Sort headers.
5714         * c-varobj.c: Sort headers.
5715         * c-valprint.c: Sort headers.
5716         * c-typeprint.c: Sort headers.
5717         * c-lang.c: Sort headers.
5718         * buildsym.c: Sort headers.
5719         * buildsym-legacy.c: Sort headers.
5720         * build-id.h: Sort headers.
5721         * build-id.c: Sort headers.
5722         * btrace.c: Sort headers.
5723         * bsd-uthread.c: Sort headers.
5724         * breakpoint.h: Sort headers.
5725         * breakpoint.c: Sort headers.
5726         * break-catch-throw.c: Sort headers.
5727         * break-catch-syscall.c: Sort headers.
5728         * break-catch-sig.c: Sort headers.
5729         * blockframe.c: Sort headers.
5730         * block.c: Sort headers.
5731         * bfin-tdep.c: Sort headers.
5732         * bfin-linux-tdep.c: Sort headers.
5733         * bfd-target.c: Sort headers.
5734         * bcache.c: Sort headers.
5735         * ax-general.c: Sort headers.
5736         * ax-gdb.h: Sort headers.
5737         * ax-gdb.c: Sort headers.
5738         * avr-tdep.c: Sort headers.
5739         * auxv.c: Sort headers.
5740         * auto-load.c: Sort headers.
5741         * arm-wince-tdep.c: Sort headers.
5742         * arm-tdep.c: Sort headers.
5743         * arm-symbian-tdep.c: Sort headers.
5744         * arm-pikeos-tdep.c: Sort headers.
5745         * arm-obsd-tdep.c: Sort headers.
5746         * arm-nbsd-tdep.c: Sort headers.
5747         * arm-nbsd-nat.c: Sort headers.
5748         * arm-linux-tdep.c: Sort headers.
5749         * arm-linux-nat.c: Sort headers.
5750         * arm-fbsd-tdep.c: Sort headers.
5751         * arm-fbsd-nat.c: Sort headers.
5752         * arm-bsd-tdep.c: Sort headers.
5753         * arch-utils.c: Sort headers.
5754         * arc-tdep.c: Sort headers.
5755         * arc-newlib-tdep.c: Sort headers.
5756         * annotate.h: Sort headers.
5757         * annotate.c: Sort headers.
5758         * amd64-windows-tdep.c: Sort headers.
5759         * amd64-windows-nat.c: Sort headers.
5760         * amd64-tdep.c: Sort headers.
5761         * amd64-sol2-tdep.c: Sort headers.
5762         * amd64-obsd-tdep.c: Sort headers.
5763         * amd64-obsd-nat.c: Sort headers.
5764         * amd64-nbsd-tdep.c: Sort headers.
5765         * amd64-nbsd-nat.c: Sort headers.
5766         * amd64-nat.c: Sort headers.
5767         * amd64-linux-tdep.c: Sort headers.
5768         * amd64-linux-nat.c: Sort headers.
5769         * amd64-fbsd-tdep.c: Sort headers.
5770         * amd64-fbsd-nat.c: Sort headers.
5771         * amd64-dicos-tdep.c: Sort headers.
5772         * amd64-darwin-tdep.c: Sort headers.
5773         * amd64-bsd-nat.c: Sort headers.
5774         * alpha-tdep.c: Sort headers.
5775         * alpha-obsd-tdep.c: Sort headers.
5776         * alpha-nbsd-tdep.c: Sort headers.
5777         * alpha-mdebug-tdep.c: Sort headers.
5778         * alpha-linux-tdep.c: Sort headers.
5779         * alpha-linux-nat.c: Sort headers.
5780         * alpha-bsd-tdep.c: Sort headers.
5781         * alpha-bsd-nat.c: Sort headers.
5782         * aix-thread.c: Sort headers.
5783         * agent.c: Sort headers.
5784         * addrmap.c: Sort headers.
5785         * ada-varobj.c: Sort headers.
5786         * ada-valprint.c: Sort headers.
5787         * ada-typeprint.c: Sort headers.
5788         * ada-tasks.c: Sort headers.
5789         * ada-lang.c: Sort headers.
5790         * aarch64-tdep.c: Sort headers.
5791         * aarch64-ravenscar-thread.c: Sort headers.
5792         * aarch64-newlib-tdep.c: Sort headers.
5793         * aarch64-linux-tdep.c: Sort headers.
5794         * aarch64-linux-nat.c: Sort headers.
5795         * aarch64-fbsd-tdep.c: Sort headers.
5796         * aarch64-fbsd-nat.c: Sort headers.
5797         * aarch32-linux-nat.c: Sort headers.
5798
5799 2019-04-04  Tom Tromey  <tom@tromey.com>
5800
5801         * varobj.c (varobj_create): Update.
5802         * rust-exp.y (struct rust_parser) <update_innermost_block,
5803         lookup_symbol>: New methods.
5804         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5805         Rename.
5806         (rust_parser::rust_lookup_type)
5807         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5808         * printcmd.c (display_command, do_one_display): Update.
5809         * parser-defs.h (struct parser_state) <parser_state>: Add
5810         "tracker" parameter.
5811         (block_tracker): New member.
5812         (class innermost_block_tracker) <innermost_block_tracker>: Add
5813         "types" parameter.
5814         <reset>: Remove method.
5815         (innermost_block): Don't declare.
5816         (null_post_parser): Update.
5817         * parse.c (innermost_block): Remove global.
5818         (write_dollar_variable): Update.
5819         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5820         Remove "tracker_types" parameter.
5821         (parse_expression): Add "tracker" parameter.
5822         (parse_expression_for_completion): Update.
5823         (null_post_parser): Add "tracker" parameter.
5824         * p-exp.y: Update rules.
5825         * m2-exp.y: Update rules.
5826         * language.h (struct language_defn) <la_post_parser>: Add
5827         "tracker" parameter.
5828         * go-exp.y: Update rules.
5829         * f-exp.y: Update rules.
5830         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5831         parameter.
5832         * d-exp.y: Update rules.
5833         * c-exp.y: Update rules.
5834         * breakpoint.c (set_breakpoint_condition): Create an
5835         innermost_block_tracker.
5836         (watch_command_1): Likewise.
5837         * ada-lang.c (resolve): Add "tracker" parameter.
5838         (resolve_subexp): Likewise.
5839         * ada-exp.y (write_var_from_sym): Update.
5840
5841 2019-04-04  Tom Tromey  <tom@tromey.com>
5842
5843         * type-stack.h: New file.
5844         * type-stack.c: New file.
5845         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5846         type-stack.h.
5847         (insert_into_type_stack, insert_type, push_type, push_type_int)
5848         (insert_type_address_space, pop_type, pop_type_int)
5849         (pop_typelist, pop_type_stack, append_type_stack)
5850         (push_type_stack, get_type_stack, push_typelist)
5851         (follow_type_instance_flags, follow_types): Don't declare.
5852         * parse.c (type_stack): Remove global.
5853         (parse_exp_in_context): Update.
5854         (insert_into_type_stack, insert_type, push_type, push_type_int)
5855         (insert_type_address_space, pop_type, pop_type_int)
5856         (pop_typelist, pop_type_stack, append_type_stack)
5857         (push_type_stack, get_type_stack, push_typelist)
5858         (follow_type_instance_flags, follow_types): Remove (moved to
5859         type-stack.c).
5860         * f-exp.y (type_stack): New global.
5861         Update rules.
5862         (push_kind_type, f_parse): Update.
5863         * d-exp.y (type_stack): New global.
5864         Update rules.
5865         (d_parse): Update.
5866         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5867         Update rules.
5868         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5869         (HFILES_NO_SRCDIR): Add type-stack.h.
5870
5871 2019-04-04  Tom Tromey  <tom@tromey.com>
5872
5873         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5874         (rust_parser::convert_ast_to_expression, rust_parse)
5875         (rust_lex_test_completion, rust_lex_tests): Update.
5876         * parser-defs.h (struct expr_completion_state): New.
5877         (struct parser_state) <parser_state>: Add completion parameter.
5878         <mark_struct_expression, mark_completion_tag>: New methods.
5879         <parse_completion, m_completion_state>: New members.
5880         (prefixify_expression, null_post_parser): Update.
5881         (mark_struct_expression, mark_completion_tag): Don't declare.
5882         * parse.c (parse_completion, expout_last_struct)
5883         (expout_tag_completion_type, expout_completion_name): Remove
5884         globals.
5885         (parser_state::mark_struct_expression)
5886         (parser_state::mark_completion_tag): Now methods.
5887         (prefixify_expression): Add last_struct parameter.
5888         (prefixify_subexp): Likewise.
5889         (parse_exp_1): Update.
5890         (parse_exp_in_context): Add cstate parameter.  Update.
5891         (parse_expression_for_completion): Create an
5892         expr_completion_state.
5893         (null_post_parser): Add "completion" parameter.
5894         * p-exp.y: Update rules.
5895         (yylex): Update.
5896         * language.h (struct language_defn) <la_post_parser>: Add
5897         "completing" parameter.
5898         * go-exp.y: Update rules.
5899         (lex_one_token): Update.
5900         * expression.h (parse_completion): Don't declare.
5901         * d-exp.y: Update rules.
5902         (lex_one_token): Update rules.
5903         * c-exp.y: Update rules.
5904         (lex_one_token): Update.
5905         * ada-lang.c (resolve): Add "parse_completion" parameter.
5906         (resolve_subexp): Likewise.
5907         (ada_resolve_function): Likewise.
5908
5909 2019-04-04  Tom Tromey  <tom@tromey.com>
5910
5911         * parser-defs.h (struct parser_state) <start_arglist,
5912         end_arglist>: New methods.
5913         <arglist_len, m_funcall_chain>: New members.
5914         (arglist_len, start_arglist, end_arglist): Don't declare.
5915         * parse.c (arglist_len, funcall_chain): Remove global.
5916         (start_arglist, end_arglist): Remove functions.
5917         (parse_exp_in_context): Update.
5918         * p-exp.y: Update rules.
5919         * m2-exp.y: Update rules.
5920         * go-exp.y: Update rules.
5921         * f-exp.y: Update rules.
5922         * d-exp.y: Update rules.
5923         * c-exp.y: Update rules.
5924
5925 2019-04-04  Tom Tromey  <tom@tromey.com>
5926
5927         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5928         lex_operator, push_back>: New methods.
5929         Update all rules.
5930         (rust_parser::lex_hex, lex_escape): Rename and update.
5931         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5932         (rust_parser::lex_operator): Rename and update.
5933         (rust_parser::lex_number, rustyylex, rustyyerror)
5934         (rust_lex_test_init, rust_lex_test_sequence)
5935         (rust_lex_test_push_back, rust_lex_tests): Update.
5936         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5937         parameter.
5938         <lexptr, prev_lexptr>: New members.
5939         (lexptr, prev_lexptr): Don't declare.
5940         * parse.c (lexptr, prev_lexptr): Remove globals.
5941         (parse_exp_in_context): Update.
5942         * p-exp.y (yylex, yyerror): Update.
5943         * m2-exp.y (parse_number, yylex, yyerror): Update.
5944         * go-exp.y (lex_one_token, yyerror): Update.
5945         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5946         * d-exp.y (lex_one_token, yyerror): Update.
5947         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5948         (lex_one_token, yyerror): Update.
5949         * ada-lex.l (YY_INPUT): Update.
5950         (rewind_to_char): Update.
5951         * ada-exp.y (yyerror): Update.
5952
5953 2019-04-04  Tom Tromey  <tom@tromey.com>
5954
5955         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5956         * parser-defs.h (struct parser_state) <parser_state>: Add new
5957         parameter.
5958         <comma_terminates>: New member.
5959         (comma_terminates): Don't declare global.
5960         * parse.c (comma_terminates): Remove global.
5961         (parse_exp_in_context): Update.
5962         * p-exp.y (yylex): Update.
5963         * m2-exp.y (yylex): Update.
5964         * go-exp.y (lex_one_token): Update.
5965         * f-exp.y (yylex): Update.
5966         * d-exp.y (lex_one_token): Update.
5967         * c-exp.y (lex_one_token): Update.
5968         * ada-lex.l: Update.
5969
5970 2019-04-04  Tom Tromey  <tom@tromey.com>
5971
5972         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5973         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5974         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5975         * parser-defs.h (paren_depth): Don't declare.
5976         * parse.c (paren_depth): Remove global.
5977         (parse_exp_in_context): Update.
5978         * p-exp.y (paren_depth): New global.
5979         (pascal_parse): Initialize it.
5980         * m2-exp.y (paren_depth): New global.
5981         (m2_parse): Initialize it.
5982         * go-exp.y (paren_depth): New global.
5983         (go_parse): Initialize it.
5984         * f-exp.y (paren_depth): New global.
5985         (f_parse): Initialize it.
5986         * d-exp.y (paren_depth): New global.
5987         (d_parse): Initialize it.
5988         * c-exp.y (paren_depth): New global.
5989         (c_parse): Initialize it.
5990         * ada-lex.l (paren_depth): New global.
5991         (lexer_init): Initialize it.
5992
5993 2019-04-04  Tom Tromey  <tom@tromey.com>
5994
5995         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5996         (rust_parser::convert_ast_to_type)
5997         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5998         * parser-defs.h (struct parser_state) <parser_state>: Add
5999         parameters.  Initialize new members.
6000         <expression_context_block, expression_context_pc>: New members.
6001         * parse.c (expression_context_block, expression_context_pc):
6002         Remove globals.
6003         (parse_exp_in_context): Update.
6004         * p-exp.y: Update all rules.
6005         (yylex): Update.
6006         * m2-exp.y: Update all rules.
6007         (yylex): Update.
6008         * go-exp.y (yylex): Update.
6009         * f-exp.y (yylex): Update.
6010         * d-exp.y: Update all rules.
6011         (yylex): Update.
6012         * c-exp.y: Update all rules.
6013         (lex_one_token, classify_name, yylex, c_parse): Update.
6014         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6015
6016 2019-04-04  Tom Tromey  <tom@tromey.com>
6017
6018         * gdbarch.h, gdbarch.c: Rebuild.
6019         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6020         * stap-probe.h:
6021         (struct stap_parse_info): Replace "parser_state" with
6022         "expr_builder".
6023         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6024         (parser_state): New class.
6025         * parse.c (expr_builder): Rename.
6026         (expr_builder::release): Rename.
6027         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6028         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6029         (write_exp_elt_longcst, write_exp_elt_floatcst)
6030         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6031         (write_exp_string_vector, write_exp_bitstring)
6032         (write_exp_msymbol, mark_struct_expression)
6033         (write_dollar_variable)
6034         (insert_type_address_space, increase_expout_size): Replace
6035         "parser_state" with "expr_builder".
6036         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6037         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6038         "parser_state" with "expr_builder".
6039
6040 2019-04-04  Tom Tromey  <tom@tromey.com>
6041
6042         * rust-exp.y: Replace "parse_language" with method call.
6043         * p-exp.y:
6044         (yylex): Replace "parse_language" with method call.
6045         * m2-exp.y:
6046         (yylex): Replace "parse_language" with method call.
6047         * go-exp.y (classify_name): Replace "parse_language" with method
6048         call.
6049         * f-exp.y (yylex): Replace "parse_language" with method call.
6050         * d-exp.y (lex_one_token): Replace "parse_language" with method
6051         call.
6052         * c-exp.y:
6053         (lex_one_token, classify_name, yylex): Replace "parse_language"
6054         with method call.
6055         * ada-exp.y (find_primitive_type, type_char)
6056         (type_system_address): Replace "parse_language" with method call.
6057
6058 2019-04-04  Tom Tromey  <tom@tromey.com>
6059
6060         * rust-exp.y: Replace "parse_gdbarch" with method call.
6061         * parse.c (write_dollar_variable, insert_type_address_space):
6062         Replace "parse_gdbarch" with method call.
6063         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6064         call.
6065         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6066         call.
6067         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6068         "parse_gdbarch" with method call.
6069         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6070         with method call.
6071         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6072         "parse_gdbarch" with method call.
6073         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6074         "parse_gdbarch" with method call.
6075         * c-exp.y (parse_type, parse_number, classify_name): Replace
6076         "parse_gdbarch" with method call.
6077         * ada-lex.l: Replace "parse_gdbarch" with method call.
6078         * ada-exp.y (parse_type, find_primitive_type, type_char)
6079         (type_system_address): Replace "parse_gdbarch" with method call.
6080
6081 2019-04-04  Tom Tromey  <tom@tromey.com>
6082
6083         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6084         * stap-probe.c (stap_parse_argument): Update.
6085         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6086         initial_size parameter.
6087         * rust-exp.y (rust_lex_tests): Update.
6088         * parse.c (parser_state): Update.
6089         (parse_exp_in_context): Update.
6090         * parser-defs.h (struct parser_state) <parser_state>: Remove
6091         "initial_size" parameter.
6092
6093 2019-04-04  Tom Tromey  <tom@tromey.com>
6094
6095         * parser-defs.h (increase_expout_size): Don't declare.
6096         * parse.c (increase_expout_size): Now static.
6097
6098 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6099
6100         * gnu-nat.c (gnu_nat_target::wait): Fix
6101         target_waitstatus_to_string call.
6102
6103 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6104
6105         * eval.c (evaluate_subexp_standard): Handle internal functions
6106         during Fortran function call handling.
6107
6108 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6109
6110         * NEWS: Mention new internal functions.
6111         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6112         (read_base_type): Use dwarf2_init_complex_target_type.
6113         * value.c (creal_internal_fn): New function.
6114         (cimag_internal_fn): New function.
6115         (_initialize_values): Register new internal functions.
6116
6117 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6118
6119         * infrun.c (stop_all_threads): If debug_infrun, always
6120         trace the wait status after wait_one, using
6121         target_waitstatus_to_string and target_pid_to_str.
6122         (handle_inferior_event): Replace various trace of
6123         wait status kind by a single trace.
6124         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6125         wait status kind image by target_waitstatus_to_string.
6126         * target/waitstatus.c (target_waitstatus_to_string): Fix
6127         obsolete comment.
6128
6129 2019-04-01  Tom Tromey  <tromey@adacore.com>
6130
6131         PR symtab/23331:
6132         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6133
6134 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6135             Pedro Alves  <palves@redhat.com>
6136
6137         * top.c (quit_force): Call 'finalize_values'.
6138         * value.c (finalize_values): New function.
6139         * value.h (finalize_values): Declare.
6140
6141 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6142
6143         * NEWS: Announce $_gdb_major and $_gdb_minor.
6144
6145         * top.c (init_gdb_version_vars): New function.
6146         (gdb_init): Call init_gdb_version_vars.
6147
6148 2019-03-29  Tom Tromey  <tromey@adacore.com>
6149
6150         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6151         help text.  Remove dead code.
6152
6153 2019-03-29  Keith Seitz  <keiths@redhat.com>
6154
6155         From Siddhesh Poyarekar:
6156         * f-lang.h (f77_get_upperbound): Return LONGEST.
6157         (f77_get_lowerbound): Likewise.
6158         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6159         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6160         print them.
6161         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6162         plongest to format print it.
6163         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6164         (f77_get_upperbound): Likewise.
6165         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6166         LOWER_BOUND to LONGEST.
6167         (f77_create_arrayprint_offset_tbl): Likewise.
6168
6169 2019-03-29  Keith Seitz  <keiths@redhat.com>
6170
6171         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6172         %s/pulongest for TYPE_LENGTH instead of %d in format
6173         strings.
6174         * ada-typerint.c (ada_print_type): Likewise.
6175         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6176         * compile/compile-c-support.c (generate_register_struct): Likewise.
6177         * gdbtypes.c (recursive_dump_type): Likewise.
6178         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6179         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6180         instead of %d in format strings.
6181         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6182         to std::min to ULONGEST.
6183         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6184         instead of %d in format strings.
6185         * tracepoint.c (info_scope_command): Likewise.
6186         * typeprint.c (print_offset_data::update)
6187         (print_offset_data::finish): Likewise.
6188         * xtensa-tdep.c (xtensa_store_return_value)
6189         (xtensa_push_dummy_call): Likewise.
6190
6191 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6192
6193         * windows-nat.c (display_selector): Fixed format specifications
6194         for 64-bit Cygwin.
6195
6196 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6197
6198         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6199
6200 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6201
6202         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6203         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6204         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6205         (nios2_linux_init_abi): Install it.
6206
6207 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6208
6209         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6210
6211 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6212
6213         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6214
6215 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6216             Tom Tromey  <tromey@adacore.com>
6217
6218         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6219
6220 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6221
6222         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6223         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6224         method to compute the bounds of range types. Also print "[evaluated]"
6225         if the bounds' values come from a dynamic evaluation.
6226
6227 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6228
6229         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6230         whitespace when pretty printing is on.
6231
6232 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6233
6234         * ppc-linux-nat.c: Add include.
6235
6236 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6237
6238         * NEWS: Mention AArch64 Pointer Authentication.
6239
6240 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6241
6242         * arm-linux-nat.c: Add include.
6243
6244 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6245
6246         * source-cache.c (source_cache::get_source_lines): Re-read
6247         fullname after calling open_source_file.
6248
6249 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6250
6251         * NEWS: Mention TLS support for FreeBSD.
6252
6253 2019-03-25  Tom Tromey  <tromey@adacore.com>
6254
6255         * minsyms.c (BUNCH_SIZE): Update comment.
6256         (~minimal_symbol_reader): Remove old comment.
6257         (compact_minimal_symbols): Update comment.
6258         (minimal_symbol_reader::install): Remove old comment.  Update
6259         other comments.
6260
6261 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6262
6263         * s390-linux-nat.c: Add include.
6264
6265 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6266
6267         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6268         Call linux_get_hwcap.
6269         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6270         Likewise.
6271         (aarch64_linux_get_hwcap): Remove function.
6272         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6273         declaration.
6274         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6275         linux_get_hwcap.
6276         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6277         * linux-tdep.c (linux_get_hwcap): Add function.
6278         (linux_get_hwcap2): Likewise.
6279         * linux-tdep.h (linux_get_hwcap): Add declaration.
6280         (linux_get_hwcap2): Likewise.
6281         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6282         (ppc_linux_get_hwcap2): Likewise.
6283         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6284         linux_get_hwcap.
6285         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6286         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6287         (ppc_linux_nat_target::read_description): Likewise.
6288         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6289         * s390-linux-nat.c: Likewise.
6290         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6291
6292 2019-03-24  Tom Tromey  <tom@tromey.com>
6293
6294         * ada-lang.c (standard_lookup): Simplify initialization.
6295         (ada_lookup_symbol_nonlocal): Simplify return.
6296         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6297         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6298         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6299         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6300         initialization.
6301         * solib.c (solib_global_lookup): Simplify.
6302         * symtab.c (null_block_symbol): Remove.
6303         (symbol_cache_lookup): Simplify returns.
6304         (lookup_language_this): Simplify returns.
6305         (lookup_symbol_aux): Simplify return.
6306         (lookup_local_symbol): Simplify returns.
6307         (lookup_global_symbol_from_objfile): Simplify return.
6308         (lookup_symbol_in_objfile_symtabs)
6309         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6310         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6311         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6312         * cp-namespace.c (cp_lookup_bare_symbol)
6313         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6314         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6315         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6316         (cp_lookup_symbol_via_imports): Simplify initialization.
6317         (find_symbol_in_baseclass): Likewise.
6318         * symtab.h (null_block_symbol): Remove.
6319         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6320         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6321         (d_lookup_symbol_module): Likewise.
6322         (find_symbol_in_baseclass): Simplify initialization.
6323
6324 2019-03-24  Tom Tromey  <tom@tromey.com>
6325
6326         * expression.h: Don't include symtab.h.
6327         (struct block): Forward declare.
6328
6329 2019-03-24  Tom Tromey  <tom@tromey.com>
6330
6331         * c-exp.y (typebase): Remove casts.
6332         * gdbtypes.c (lookup_unsigned_typename, )
6333         (lookup_signed_typename): Remove cast.
6334         * eval.c (parse_to_comma_and_eval): Remove cast.
6335         * parse.c (write_dollar_variable): Remove cast.
6336         * block.h (struct block) <superblock>: Now const.
6337         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6338         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6339         (map_block): Make "block" const.
6340         * symfile.h (struct quick_symbol_functions)
6341         <map_matching_symbols>: Constify block argument to "callback".
6342         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6343         const.
6344         (find_pc_sect_compunit_symtab): Make "b" const.
6345         (find_symbol_at_address): Likewise.
6346         (search_symbols): Likewise.
6347         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6348         (dw2_debug_names_lookup_symbol): Likewise.
6349         (dw2_map_matching_symbols): Update.
6350         * p-valprint.c (pascal_val_print): Remove "block".
6351         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6352         (aux_add_nonlocal_symbols): Make "block" const.
6353         (resolve_subexp): Remove cast.
6354         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6355         const.
6356         (iterate_over_file_blocks): Likewise.
6357         * f-exp.y (%union) <bval>: Remove.
6358         * coffread.c (patch_opaque_types): Make "b" const.
6359         * spu-tdep.c (spu_catch_start): Make "block" const.
6360         * c-valprint.c (print_unpacked_pointer): Remove "block".
6361         * symmisc.c (dump_symtab_1): Make "b" const.
6362         (block_depth): Make "block" const.
6363         * d-exp.y (%union) <bval>: Remove.
6364         * cp-support.h (cp_lookup_rtti_type): Update.
6365         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6366         * psymtab.c (psym_lookup_symbol): Make "block" const.
6367         (maintenance_check_psymtabs): Make "b" const.
6368         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6369         (enumerate_locals, enumerate_args): Update.
6370         * python/py-symtab.c (stpy_global_block): Make "block" const.
6371         (stpy_static_block): Likewise.
6372         * inline-frame.c (block_starting_point_at): Make "new_block"
6373         const.
6374         * block.c (find_block_in_blockvector): Make return type const.
6375         (blockvector_for_pc_sect): Make "b" const.
6376         (find_block_in_blockvector): Make "b" const.
6377
6378 2019-03-23  Tom Tromey  <tom@tromey.com>
6379
6380         * varobj.c (varobj_create): Update.
6381         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6382         * printcmd.c (display_command, do_one_display): Don't reset
6383         innermost_block.
6384         * parser-defs.h (enum innermost_block_tracker_type): Move to
6385         expression.h.
6386         (innermost_block): Update comment.
6387         * parse.c (parse_exp_1): Add tracker_types parameter.
6388         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6389         tracker_types parameter.  Reset innermost_block.
6390         (parse_exp_in_context): Remove.
6391         (parse_expression_for_completion): Update.
6392         * objfiles.c (~objfile): Don't reset expression_context_block or
6393         innermost_block.
6394         * expression.h (enum innermost_block_tracker_type): Move from
6395         parser-defs.h.
6396         (parse_exp_1): Add tracker_types parameter.
6397         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6398         reset innermost_block.
6399
6400 2019-03-23  Tom Tromey  <tom@tromey.com>
6401
6402         * objfiles.h: Include bcache.h.
6403
6404 2019-03-23  Tom Tromey  <tom@tromey.com>
6405
6406         * linespec.c (get_current_search_block): Use
6407         scoped_restore_current_language.
6408         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6409
6410 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6411             Jiong Wang  <jiong.wang@arm.com>
6412
6413         * aarch64-linux-tdep.c
6414         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6415         section.
6416         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6417
6418 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6419             Jiong Wang  <jiong.wang@arm.com>
6420
6421         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6422         instructions.
6423         (aarch64_analyze_prologue_test): Add PACIASP test.
6424         (aarch64_prologue_prev_register): Unmask PC value.
6425
6426 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6427             Jiong Wang  <jiong.wang@arm.com>
6428
6429         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6430         (aarch64_dwarf2_prev_register): Unmask PC value.
6431         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6432         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6433         DW_CFA_AARCH64_negate_ra_state.
6434         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6435
6436 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6437             Jiong Wang  <jiong.wang@arm.com>
6438
6439         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6440         registers.
6441         (aarch64_pseudo_register_name): Likewise.
6442         (aarch64_pseudo_register_type): Likewise.
6443         (aarch64_pseudo_register_reggroup_p): Likewise.
6444         (aarch64_gdbarch_init): Add pauth registers.
6445         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6446         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6447         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6448         (struct gdbarch_tdep): Add regnum for ra_state.
6449
6450 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6451             Jiong Wang  <jiong.wang@arm.com>
6452
6453         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6454
6455 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6456             Jiong Wang  <jiong.wang@arm.com>
6457
6458         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6459         function.
6460         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6461         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6462         (aarch64_gdbarch_init): Add puth registers.
6463         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6464         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6465         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6466
6467 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6468             Jiong Wang  <jiong.wang@arm.com>
6469
6470         * aarch64-linux-nat.c
6471         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6472         * aarch64-linux-tdep.c
6473         (aarch64_linux_core_read_description): Likewise.
6474         (aarch64_linux_get_hwcap): New function.
6475         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6476         (aarch64_linux_get_hwcap): New declaration.
6477
6478 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6479             Jiong Wang  <jiong.wang@arm.com>
6480
6481         * aarch64-linux-nat.c
6482         (aarch64_linux_nat_target::read_description): Add pauth param.
6483         * aarch64-linux-tdep.c
6484         (aarch64_linux_core_read_description): Likewise.
6485         * aarch64-tdep.c (struct target_desc): Add in pauth.
6486         (aarch64_read_description): Add pauth param.
6487         (aarch64_gdbarch_init): Likewise.
6488         * aarch64-tdep.h (aarch64_read_description): Likewise.
6489         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6490         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6491         * features/Makefile: Add new files.
6492         * features/aarch64-pauth.c: New file.
6493         * features/aarch64-pauth.xml: New file.
6494
6495 2019-03-20  Tom Tromey  <tromey@adacore.com>
6496
6497         * infrun.c (handle_inferior_event): Rename from
6498         handle_inferior_event_1.  Create a scoped_value_mark.
6499         (handle_inferior_event): Remove.
6500
6501 2019-03-19  Tom Tromey  <tromey@adacore.com>
6502
6503         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6504         * infrun.h (print_stop_event): Add "displays" parameter.
6505         * infrun.c (print_stop_event): Add "displays" parameter.
6506
6507 2019-03-19  Pedro Alves  <palves@redhat.com>
6508
6509         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6510         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6511         to -1.  Fix TABs vs spaces.
6512         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6513         * tui/tui-out.h (tui_ui_out) Add intro comments.
6514         <m_line, m_start_of_line>: In-class initialize, and add describing
6515         comment.
6516
6517 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6518
6519         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6520         variable names.
6521         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6522
6523 2019-03-18  Pedro Alves  <palves@redhat.com>
6524             Eli Zaretskii <eliz@gnu.org>
6525
6526         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6527         m_line and m_start_of_line.
6528
6529 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6530
6531         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6532         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6533         it returns a newline.  This fixes a regression in TU mode, whereby
6534         the next line is output on the same screen line as the user input.
6535
6536 2019-03-18  Tom Tromey  <tromey@adacore.com>
6537
6538         * minsyms.c (minimal_symbol_reader::install): Remove call to
6539         obstack_blank.
6540
6541 2019-03-18  Pedro Alves  <palves@redhat.com>
6542
6543         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6544         New globals.
6545         (apply_style): New, factored out from ...
6546         (apply_ansi_escape): ... this.  Handle reverse video mode.
6547         (tui_set_reverse_mode): New function.
6548         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6549         * tui/tui-winsource.c (tui_show_source_line): Use
6550         tui_set_reverse_mode instead of setting A_STANDOUT.
6551         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6552         New setter methods.
6553
6554 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6555
6556         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6557         Handle tabs.
6558
6559 2019-03-18  Tom Tromey  <tromey@adacore.com>
6560
6561         * ada-lang.c (empty_array): Add "high" parameter.
6562         (ada_evaluate_subexp): Update.
6563
6564 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6565
6566         * unittests/string_view-selftests.c: Define
6567         _initialize_string_view_selftests unconditionally.
6568
6569 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6570
6571         PR gdb/24350
6572         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6573
6574 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6575
6576         PR gdb/24351
6577         * windows-nat.c (display_selector): Fix format specifiers.
6578
6579 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6580
6581         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6582         tui_refill_source_window instead of tui_refresh_win, to update the
6583         current execution line.  This fixes redisplay of the current line
6584         when stepping through the code with "next" or "step".
6585
6586 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6587
6588         * source-cache.c (source_cache::get_source_lines): Call
6589         find_source_lines to initialize s->nlines.  This fixes vertical
6590         scrolling of TUI source window when the DOWN arrow is pressed.
6591
6592 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6593
6594         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6595         linux-thread-db.c (_initialize_thread_db): Likewise.
6596
6597 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6598
6599         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6600         wclrtoeol in tui_show_source_line".  This reverts changes made in
6601         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6602
6603 2019-03-15  Tom Tromey  <tom@tromey.com>
6604
6605         * symtab.h (struct minimal_symbol): Derive from
6606         general_symbol_info.
6607         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6608         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6609         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6610         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6611         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6612         (MSYMBOL_SEARCH_NAME): Update.
6613         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6614         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6615         * minsyms.c (minimal_symbol_reader::record_full): Update.
6616
6617 2019-03-15  Tom Tromey  <tom@tromey.com>
6618
6619         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6620
6621 2019-03-15  Tom Tromey  <tom@tromey.com>
6622
6623         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6624         unique_xmalloc_ptr.
6625         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6626         Update.
6627         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6628         (build_minimal_symbol_hash_tables)
6629         (minimal_symbol_reader::install): Update.
6630
6631 2019-03-15  Tom Tromey  <tom@tromey.com>
6632
6633         * symtab.c (create_demangled_names_hash): Update.
6634         (symbol_set_names): Update.
6635         * objfiles.h (struct objfile_per_bfd_storage)
6636         <demangled_names_hash>: Now an htab_up.
6637         * objfiles.c (objfile_per_bfd_storage): Simplify.
6638
6639 2019-03-15  Tom Tromey  <tom@tromey.com>
6640
6641         * objfiles.h (struct objfile_per_bfd_storage): Declare
6642         destructor.
6643         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6644         New.
6645         (get_objfile_bfd_data): Use new.  Don't initialize
6646         language_of_main.
6647         (free_objfile_per_bfd_storage): Remove.
6648         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6649
6650 2019-03-15  Tom Tromey  <tom@tromey.com>
6651
6652         * symfile.c (reread_symbols): Update.
6653         * objfiles.c (objfile::objfile): Update.
6654         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6655         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6656         comment.
6657         (minimal_symbol_reader::install): Update.
6658         (terminate_minimal_symbol_table): Remove.
6659         * jit.c (jit_object_close_impl): Update.
6660
6661 2019-03-15  Tom Tromey  <tom@tromey.com>
6662
6663         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6664         initializations.
6665
6666 2019-03-15  Tom Tromey  <tom@tromey.com>
6667
6668         * objfiles.h (struct objfile_per_bfd_storage)
6669         <demangled_hash_languages>: Now a bitset.
6670         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6671         (lookup_minimal_symbol): Update.
6672
6673 2019-03-15  Tom Tromey  <tom@tromey.com>
6674
6675         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6676         Don't return the symbol.
6677         * coffread.c (record_minimal_symbol): Use record_full.
6678
6679 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6680
6681         The MS-Windows port of ncurses fails to switch to a color pair if
6682         one or both of the colors are the implicit default colors.  This
6683         change records the default colors when TUI is initialized, and
6684         then specifies them explicitly when a color pair uses the default
6685         colors.  This allows color styling in TUI mode on MS-Windows.
6686
6687         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6688         ncurses_norm_attr.
6689         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6690         colors in ncurses_norm_attr.
6691         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6692         "none", replace it with the default color recorded in
6693         ncurses_norm_attr.
6694
6695 2019-03-14  Tom Tromey  <tromey@adacore.com>
6696
6697         * source-cache.h (class source_cache) <get_source_lines>: Return
6698         std::string.
6699         * source-cache.c (source_cache::extract_lines): Handle case where
6700         first_pos==npos.  Return std::string.
6701         (source_cache::get_source_lines): Update.
6702
6703 2019-03-14  Tom Tromey  <tromey@adacore.com>
6704
6705         * NEWS: Add item for "style sources" commands.
6706         * source-cache.c (source_cache::get_source_lines): Check
6707         source_styling.
6708         * cli/cli-style.c (source_styling): New global.
6709         (_initialize_cli_style): Add "style sources" commands.
6710         (show_style_sources): New function.
6711         * cli/cli-style.h (source_styling): Declare.
6712
6713 2019-03-14  Pedro Alves  <palves@redhat.com>
6714             Tom Tromey  <tromey@adacore.com>
6715
6716         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6717         * tui/tui-winsource.c (tui_refill_source_window): New function,
6718         from...
6719         (tui_horizontal_source_scroll): ... here.  Move some logic.
6720         * cli/cli-style.c (set_style_enabled): Notify new observable.
6721         * tui/tui-hooks.c (tui_redisplay_source): New function.
6722         (tui_attach_detach_observers): Attach or detach
6723         tui_redisplay_source.
6724         * observable.h (source_styling_changed): New observable.
6725         * observable.c: Define source_styling_changed observable.
6726
6727 2019-03-13  Tom Tromey  <tromey@adacore.com>
6728
6729         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6730         (i386_gnu_nat_target::store_registers): Update.
6731         * target-debug.h (target_debug_print_std_string): New macro.
6732         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6733         * windows-tdep.c (display_one_tib): Update.
6734         * tui/tui-stack.c (tui_make_status_line): Update.
6735         * top.c (print_inferior_quit_action): Update.
6736         * thread.c (thr_try_catch_cmd): Update.
6737         (add_thread_with_info): Update.
6738         (thread_target_id_str): Update.
6739         (thr_try_catch_cmd): Update.
6740         (thread_command): Update.
6741         (thread_find_command): Update.
6742         * record-btrace.c (record_btrace_target::info_record)
6743         (record_btrace_resume_thread, record_btrace_target::resume)
6744         (record_btrace_cancel_resume, record_btrace_step_thread)
6745         (record_btrace_target::wait, record_btrace_target::wait)
6746         (record_btrace_target::wait, record_btrace_target::stop): Update.
6747         * progspace.c (print_program_space): Update.
6748         * process-stratum-target.c
6749         (process_stratum_target::thread_address_space): Update.
6750         * linux-fork.c (linux_fork_mourn_inferior)
6751         (detach_checkpoint_command, info_checkpoints_command)
6752         (linux_fork_context): Update.
6753         (linux_fork_detach): Update.
6754         (class scoped_switch_fork_info): Update.
6755         (delete_checkpoint_command): Update.
6756         * infrun.c (follow_fork_inferior): Update.
6757         (follow_fork_inferior): Update.
6758         (proceed_after_vfork_done): Update.
6759         (handle_vfork_child_exec_or_exit): Update.
6760         (follow_exec): Update.
6761         (displaced_step_prepare_throw): Update.
6762         (displaced_step_restore): Update.
6763         (start_step_over): Update.
6764         (resume_1): Update.
6765         (clear_proceed_status_thread): Update.
6766         (proceed): Update.
6767         (print_target_wait_results): Update.
6768         (do_target_wait): Update.
6769         (context_switch): Update.
6770         (stop_all_threads): Update.
6771         (restart_threads): Update.
6772         (finish_step_over): Update.
6773         (handle_signal_stop): Update.
6774         (switch_back_to_stepped_thread): Update.
6775         (keep_going_pass_signal): Update.
6776         (print_exited_reason): Update.
6777         (normal_stop): Update.
6778         * inferior.c (inferior_pid_to_str): Change return type.
6779         (print_selected_inferior): Update.
6780         (add_inferior): Update.
6781         (detach_inferior): Update.
6782         * dummy-frame.c (fprint_dummy_frames): Update.
6783         * dcache.c (dcache_info_1): Update.
6784         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6785         (btrace_fetch, btrace_clear): Update.
6786         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6787         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6788         type.
6789         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6790         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6791         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6792         * gdbarch.c, gdbarch.h: Rebuild.
6793         * gdbarch.sh (core_pid_to_str): Change return type.
6794         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6795         return type.
6796         (windows_nat_target::pid_to_str): Change return type.
6797         (windows_delete_thread): Update.
6798         (windows_nat_target::attach): Update.
6799         (windows_nat_target::files_info): Update.
6800         * target-delegates.c: Rebuild.
6801         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6802         return type.
6803         (sol_thread_target::pid_to_str): Change return type.
6804         * remote.c (class remote_target) <pid_to_str>: Change return
6805         type.
6806         (remote_target::pid_to_str): Change return type.
6807         (extended_remote_target::attach, remote_target::remote_stop_ns)
6808         (remote_target::remote_notif_remove_queued_reply)
6809         (remote_target::push_stop_reply, remote_target::disable_btrace):
6810         Update.
6811         (extended_remote_target::attach): Update.
6812         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6813         type.
6814         (gdbsim_target::pid_to_str): Change return type.
6815         * ravenscar-thread.c (struct ravenscar_thread_target)
6816         <pid_to_str>: Change return type.
6817         (ravenscar_thread_target::pid_to_str): Change return type.
6818         * procfs.c (class procfs_target) <pid_to_str>: Change return
6819         type.
6820         (procfs_target::pid_to_str): Change return type.
6821         (procfs_target::attach): Update.
6822         (procfs_target::detach): Update.
6823         (procfs_target::fetch_registers): Update.
6824         (procfs_target::store_registers): Update.
6825         (procfs_target::wait): Update.
6826         (procfs_target::files_info): Update.
6827         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6828         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6829         return type.
6830         (nto_procfs_target::pid_to_str): Change return type.
6831         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6832         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6833         return type.
6834         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6835         (exit_lwp): Update.
6836         (attach_proc_task_lwp_callback, get_detach_signal)
6837         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6838         (linux_nat_target::resume, wait_lwp, stop_callback)
6839         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6840         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6841         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6842         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6843         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6844         type.
6845         (inf_ptrace_target::attach): Update.
6846         (inf_ptrace_target::files_info): Update.
6847         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6848         type.
6849         (go32_nat_target::pid_to_str): Change return type.
6850         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6851         (gnu_nat_target::wait): Update.
6852         (gnu_nat_target::wait): Update.
6853         (gnu_nat_target::resume): Update.
6854         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6855         (fbsd_nat_target::wait): Update.
6856         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6857         type.
6858         (darwin_nat_target::attach): Update.
6859         * corelow.c (class core_target) <pid_to_str>: Change return type.
6860         (core_target::pid_to_str): Change return type.
6861         * target.c (normal_pid_to_str): Change return type.
6862         (default_pid_to_str): Likewise.
6863         (target_pid_to_str): Change return type.
6864         (target_translate_tls_address): Update.
6865         (target_announce_detach): Update.
6866         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6867         return type.
6868         (bsd_uthread_target::pid_to_str): Change return type.
6869         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6870         type.
6871         (bsd_kvm_target::pid_to_str): Change return type.
6872         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6873         return type.
6874         (aix_thread_target::pid_to_str): Change return type.
6875         * target.h (struct target_ops) <pid_to_str>: Change return type.
6876         (target_pid_to_str, normal_pid_to_str): Likewise.
6877         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6878         type.
6879         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6880         type.
6881         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6882         return type.
6883         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6884         type.
6885         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6886         type.
6887         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6888         return type.
6889
6890 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6891
6892         * NEWS: Mention that the new default MI version is 3.  Mention
6893         changes to the output of commands and events that deal with
6894         multi-location breakpoints.
6895         * breakpoint.c: Include "mi/mi-out.h".
6896         (print_one_breakpoint): Change output syntax if using MI version
6897         >= 3.
6898         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6899         New.
6900         (mi_multi_location_breakpoint_output_fixed): New.
6901         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6902         (mi_cmd_fix_multi_location_breakpoint_output): New.
6903         (mi_multi_location_breakpoint_output_fixed): New.
6904         * mi/mi-cmds.c (mi_cmds): Register command
6905         -fix-multi-location-breakpoint-output.
6906         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6907         interpreter "mi".
6908
6909 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6910
6911         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6912         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6913         instantiate mi_ui_out based on interpreter name.
6914         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6915         * mi/mi-main.c (mi_load_progress): Likewise.
6916
6917 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6918
6919         * NEWS: Combine separate "New targets" sections for 8.3.
6920
6921 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6922
6923         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6924         (ppcfbsd_init_abi): Install gdbarch
6925         "fetch_tls_load_module_address" and "get_thread_local_address"
6926         methods.
6927
6928 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6929
6930         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6931         (riscv_fbsd_init_abi): Install gdbarch
6932         "fetch_tls_load_module_address" and "get_thread_local_address"
6933         methods.
6934
6935 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6936
6937         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6938         (i386fbsd_init_abi): Install gdbarch
6939         "fetch_tls_load_module_address" and "get_thread_local_address"
6940         methods.
6941
6942 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6943
6944         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6945         (amd64fbsd_init_abi): Install gdbarch
6946         "fetch_tls_load_module_address" and "get_thread_local_address"
6947         methods.
6948
6949 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6950
6951         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6952         (struct fbsd_pspace_data): New type.
6953         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6954         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6955         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6956         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6957         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6958
6959 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6960
6961         * gdbtypes.c (lookup_struct_elt): New function.
6962         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6963         * gdbtypes.h (struct struct_elt): New type.
6964         (lookup_struct_elt): New prototype.
6965
6966 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6967
6968         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6969         remove disabled code block.
6970
6971 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6972
6973         * gdbarch.sh (get_thread_local_address): New method.
6974         * gdbarch.h, gdbarch.c: Regenerate.
6975         * target.c (target_translate_tls_address): Use
6976         gdbarch_get_thread_local_address if present instead of
6977         target::get_thread_local_address.
6978
6979 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6980
6981         * target.h (target::get_thread_local_address): Update comment.
6982
6983 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6984
6985         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6986         objfile->separate_debug_objfile_backlink if not NULL.
6987
6988 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6989
6990         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6991         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6992         (amd64bsd_store_inferior_registers): Likewise.
6993         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6994         Enable segment base registers.
6995         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6996         PT_GETFSBASE and PT_GETGSBASE.
6997         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6998         PT_SETGSBASE.
6999         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7000         segment base registers.
7001         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7002
7003 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7004
7005         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7006         Update calls to i386_target_description to add 'segments'
7007         parameter.
7008         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7009         add segment base registers.
7010         * arch/i386.c (i386_create_target_description): Add 'segments'
7011         parameter to enable segment base registers.
7012         * arch/i386.h (i386_create_target_description): Likewise.
7013         * features/i386/32bit-segments.xml: New file.
7014         * features/i386/32bit-segments.c: Generate.
7015         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7016         call to i386_target_description to add 'segments' parameter.
7017         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7018         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7019         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7020         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7021         if feature is present.
7022         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7023         Add 'segments' parameter to call to i386_target_description.
7024         (i386_target_description): Add 'segments' parameter to enable
7025         segment base registers.
7026         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7027         to call to i386_target_description.
7028         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7029         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7030         Define I386_NUM_REGS.
7031         (i386_target_description): Add 'segments' parameter to enable
7032         segment base registers.
7033
7034 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7035
7036         PR/24325
7037         * source-cache.c: #undef open and close, to avoid unresolved
7038         externals during linking.
7039
7040 2019-03-12  Tom Tromey  <tromey@adacore.com>
7041
7042         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7043         const.  Add initializers.
7044         (_initialize_remote): Don't initialize ptid globals.
7045
7046 2019-03-12  Pedro Alves  <palves@redhat.com>
7047
7048         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7049
7050 2019-03-12  Pedro Alves  <palves@redhat.com>
7051
7052         * cp-name-parser.y (main): Remove unused 'len' variable.
7053
7054 2019-03-12  Tom Tromey  <tromey@adacore.com>
7055
7056         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7057         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7058
7059 2019-03-12  Tom Tromey  <tromey@adacore.com>
7060
7061         * linux-nat.c (iterate_over_lwps): Update.
7062         (stop_callback): Remove parameter.
7063         (stop_wait_callback, detach_callback, resume_set_callback)
7064         (select_singlestep_lwp_callback, set_ignore_sigint)
7065         (status_callback, resumed_callback, resume_clear_callback)
7066         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7067         data parameter.
7068         (linux_nat_target::detach, linux_nat_target::resume)
7069         (linux_stop_and_wait_all_lwps, select_event_lwp)
7070         (linux_nat_filter_event, linux_nat_wait_1)
7071         (linux_nat_target::kill, linux_nat_target::stop)
7072         (linux_nat_target::stop): Update.
7073         (linux_nat_resume_callback): Change type.
7074         (resume_stopped_resumed_lwps, count_events_callback)
7075         (select_event_lwp_callback): Likewise.
7076         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7077         * arm-linux-nat.c (struct update_registers_data): Remove.
7078         (update_registers_callback): Change type.
7079         (arm_linux_insert_hw_breakpoint1): Update.
7080         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7081         parameter.
7082         (x86_linux_dr_set_addr): Update.
7083         (x86_linux_dr_set_control): Update.
7084         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7085         (iterate_over_lwps): Use gdb::function_view.
7086         * nat/aarch64-linux-hw-point.c (struct
7087         aarch64_dr_update_callback_param): Remove.
7088         (debug_reg_change_callback): Change type.
7089         (aarch64_notify_debug_reg_change): Update.
7090         * s390-linux-nat.c (s390_refresh_per_info): Update.
7091
7092 2019-03-11  Tom Tromey  <tromey@adacore.com>
7093
7094         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7095         redundant assignment to "this_cu".
7096
7097 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7098
7099         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7100
7101 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7102
7103         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7104         from...
7105         (rank_one_type): ... this.
7106
7107 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7108
7109         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7110         from...
7111         (rank_one_type): ... this.
7112
7113 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7114
7115         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7116         from...
7117         (rank_one_type): ... this.
7118
7119 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7120
7121         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7122         from...
7123         (rank_one_type): ... this.
7124
7125 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7126
7127         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7128         from...
7129         (rank_one_type): ... this.
7130
7131 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7132
7133         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7134         from...
7135         (rank_one_type): ... this.
7136
7137 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7138
7139         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7140         from...
7141         (rank_one_type): ... this.
7142
7143 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7144
7145         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7146         from...
7147         (rank_one_type): ... this.
7148
7149 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7150
7151         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7152         from...
7153         (rank_one_type): ... this.
7154
7155 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7156
7157         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7158         from...
7159         (rank_one_type): ... this.
7160
7161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7162
7163         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7164         from...
7165         (rank_one_type): ... this.
7166
7167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7168
7169         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7170         from...
7171         (rank_one_type): ... this.
7172
7173 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7174
7175         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7176         inferior-events' shows the example events.
7177
7178 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7179
7180         Support styling on native MS-Windows console
7181
7182         PR/24315
7183         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7184         on MS-Windows if $TERM is not defined.
7185
7186         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7187
7188         * posix-hdep.c (gdb_console_fputs):
7189         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7190         functions.
7191         * ui-file.h (gdb_console_fputs): Add prototype.
7192
7193         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7194         back to fputs only if the former returns zero.
7195
7196 2019-03-07  Tom Tromey  <tom@tromey.com>
7197
7198         * symmisc.c (print_symbol_bcache_statistics): Update.
7199         (print_objfile_statistics): Update.
7200         * symfile.c (allocate_symtab): Update.
7201         * stabsread.c: Don't include bcache.h.
7202         * psymtab.h (struct psymbol_bcache): Don't declare.
7203         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7204         (psymbol_bcache_init, psymbol_bcache_free)
7205         (psymbol_bcache_get_bcache): Don't declare.
7206         * psymtab.c (struct psymbol_bcache): Remove.
7207         (psymtab_storage::psymtab_storage): Update.
7208         (psymtab_storage::~psymtab_storage): Update.
7209         (psymbol_bcache_init, psymbol_bcache_free)
7210         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7211         (add_psymbol_to_bcache): Update.
7212         (allocate_psymtab): Update.
7213         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7214         macro_cache>: No longer pointers.
7215         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7216         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7217         * macrotab.c (macro_bcache): Update.
7218         * macroexp.c: Don't include bcache.h.
7219         * gdbtypes.c (check_types_worklist): Update.
7220         (types_deeply_equal): Remove TRY/CATCH.  Update.
7221         * elfread.c (elf_symtab_read): Update.
7222         * dwarf2read.c: Don't include bcache.h.
7223         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7224         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7225         (print_bcache_statistics, bcache_memory_used): Don't declare.
7226         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7227         methods.  Rename all data members.
7228         * bcache.c (struct bcache): Move to bcache.h.
7229         (bcache::expand_hash_table): Rename from expand_hash_table.
7230         (bcache): Remove.
7231         (bcache::insert): Rename from bcache_full.
7232         (bcache::compare): Rename from bcache_compare.
7233         (bcache_xmalloc): Remove.
7234         (bcache::~bcache): Rename from bcache_xfree.
7235         (bcache::print_statistics): Rename from print_bcache_statistics.
7236         (bcache::memory_used): Rename from bcache_memory_used.
7237
7238 2019-03-07  Pedro Alves  <palves@redhat.com>
7239
7240         * infrun.c (normal_stop): Also check for
7241         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7242
7243 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7244
7245         * f-lang.c (value_from_host_double): Moved to...
7246         * value.c (value_from_host_double): ...here.
7247         * value.h (value_from_host_double): Declare.
7248         * guile/scm-math.c (vlscm_convert_typed_number): Use
7249         value_from_host_double.
7250         (vlscm_convert_number): Likewise.
7251         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7252         * python/py-value.c (convert_value_from_python): Likewise.
7253
7254 2019-03-06  Tom Tromey  <tom@tromey.com>
7255
7256         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7257
7258 2019-03-06  Tom Tromey  <tom@tromey.com>
7259
7260         * utils.h (free_current_contents): Don't declare.
7261         * utils.c (free_current_contents): Remove.
7262
7263 2019-03-06  Tom Tromey  <tom@tromey.com>
7264
7265         * top.c (quit_force): Update.
7266         * main.c (captured_command_loop): Update.
7267         * common/new-op.c (operator new): Update.
7268         * common/common-exceptions.c (struct catcher)
7269         <save_cleanup_chain>: Remove member.
7270         (exceptions_state_mc_init): Update.
7271         (exception_try_scope_entry): Return nullptr.
7272         (exception_try_scope_exit, exception_rethrow)
7273         (throw_exception_sjlj, throw_exception_cxx): Update.
7274         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7275         (all_cleanups, do_cleanups, discard_cleanups)
7276         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7277         (restore_cleanups, restore_final_cleanups): Don't declare.
7278         (do_final_cleanups): Remove parameter.
7279         * common/cleanups.c (cleanup_chain, make_cleanup)
7280         (make_cleanup_dtor, all_cleanups, do_cleanups)
7281         (discard_my_cleanups, discard_cleanups)
7282         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7283         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7284         (null_cleanup): Remove.
7285         (do_final_cleanups): Remove parameter.
7286
7287 2019-03-06  Tom Tromey  <tom@tromey.com>
7288
7289         * remote.c (remote_target::remote_parse_stop_reply): Use
7290         unique_xmalloc_ptr.
7291
7292 2019-03-06  Tom Tromey  <tom@tromey.com>
7293
7294         * stabsread.c (struct stabs_field_info): Rename from field_info.
7295         <list, fnlist>: Add initializers.
7296         <obstack>: New member.
7297         (read_member_functions, read_struct_fields, read_baseclasses):
7298         Allocate on obstack.  Don't use cleanups.
7299         (read_one_struct_field, read_member_functions, read_struct_fields)
7300         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7301         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7302         (read_struct_type): Update.
7303
7304 2019-03-06  Tom Tromey  <tom@tromey.com>
7305
7306         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7307         * common/filestuff.h (make_cleanup_close): Don't declare.
7308         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7309         Remove.
7310
7311 2019-03-06  Tom Tromey  <tom@tromey.com>
7312
7313         * solib-aix.c: Use make_scope_exit.
7314
7315 2019-03-06  Tom Tromey  <tom@tromey.com>
7316
7317         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7318         Use make_scope_exit.
7319
7320 2019-03-06  Tom Tromey  <tom@tromey.com>
7321
7322         * solib-svr4.c (disable_probes_interface): Remove parameter.
7323         (svr4_handle_solib_event): Use make_scope_exit.
7324
7325 2019-03-06  Tom Tromey  <tom@tromey.com>
7326
7327         * remote.c (struct stop_reply_deleter): Remove.
7328         (stop_reply_up): Update.
7329         (struct stop_reply): Derive from notif_event.  Don't typedef.
7330         <regcache>: Now a std::vector.
7331         (stop_reply_xfree): Remove.
7332         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7333         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7334         (remote_target::discard_pending_stop_replies): Use delete.
7335         (remote_target::remote_parse_stop_reply): Update.
7336         (remote_target::process_stop_reply): Update.
7337         * remote-notif.h (struct notif_event): Add virtual destructor.
7338         Remove "dtr" member.
7339         (struct notif_client) <alloc_event>: Return a unique_ptr.
7340         (notif_event_xfree): Don't declare.
7341         (notif_event_up): New typedef.
7342         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7343         (notif_event_xfree, do_notif_event_xfree): Remove.
7344         (remote_notif_state_xfree): Update.
7345
7346 2019-03-06  Tom Tromey  <tom@tromey.com>
7347
7348         * infrun.c (displaced_step_clear_cleanup): Now a
7349         forward_scope_exit type.
7350         (displaced_step_prepare_throw): Update.
7351         (displaced_step_fixup): Update.
7352
7353 2019-03-06  Tom Tromey  <tom@tromey.com>
7354
7355         * inferior.h (class inferior): Update comment.
7356         * gdbthread.h (class thread_info): Update comment.
7357
7358 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7359             Tom Tromey  <tom@tromey.com>
7360
7361         * stabsread.h (struct stab_section_list): Remove.
7362         (coffstab_build_psymtabs): Update.
7363         * dbxread.c (symbuf_sections): Now a std::vector.
7364         (sect_idx): New global.
7365         (fill_symbuf): Update.
7366         (coffstab_build_psymtabs): Change type of stabsects parameter.
7367         Update.
7368         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7369         std::vector.
7370         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7371         (coff_locate_sections): Update.
7372         (coff_symfile_read): Remove cleanups.  Update.
7373         (init_stringtab): Add storage parameter.
7374         (free_stringtab, free_stringtab_cleanup): Remove.
7375         (init_lineno): Add storage parameter.
7376         (free_linetab, free_linetab_cleanup): Remove.
7377
7378 2019-03-06  Pedro Alves  <palves@redhat.com>
7379
7380         * linux-fork.c (fork_info::clobber_regs): Delete.
7381         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7382         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7383         comment.  Adjust.
7384         (scoped_switch_fork_info::scoped_switch_fork_info)
7385         (checkpoint_command, linux_fork_context): Adjust
7386         fork_save_infrun_state calls.
7387
7388 2019-03-06  Pedro Alves  <palves@redhat.com>
7389
7390         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7391         (inf_has_multiple_threads): Return 'bool' and rewrite using
7392         inferior_info::threads().
7393
7394 2019-03-06  Pedro Alves  <palves@redhat.com>
7395
7396         * linux-fork.c: Include <list>.
7397         (fork_list): Now a std::list instance.
7398         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7399         (forks_exist_p, find_last_fork): Adjust.
7400         (new_fork): Delete.
7401         (one_fork_p): New.
7402         (add_fork): Adjust.
7403         (free_fork): Delete, folded into fork_info::~fork_info().
7404         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7405         Adjust.
7406         (init_fork_list): Delete.
7407         (linux_fork_killall, linux_fork_mourn_inferior)
7408         (linux_fork_detach, info_checkpoints_command): Adjust.
7409         (_initialize_linux_fork): No longer call init_fork_list.
7410
7411 2019-03-06  Pedro Alves  <palves@redhat.com>
7412
7413         * linux-fork.c (new_fork): New, split out of ...
7414         (add_fork): ... this.  Return void.  Move "first fork" special
7415         case from here, to ...
7416         (checkpoint_command): ... here.
7417         * linux-linux.h (add_fork): Return void.
7418
7419 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7420
7421         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7422
7423 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7424             Chris January  <chris.january@arm.com>
7425             David Lecomber  <david.lecomber@arm.com>
7426
7427         * f-exp.y: New token, UNOP_INTRINSIC.
7428         (exp): New pattern using UNOP_INTRINSIC token.
7429         (f77_keywords): Add 'abs' keyword.
7430         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7431         (value_from_host_double): New function.
7432         (evaluate_subexp_f): Support UNOP_ABS.
7433
7434 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7435
7436         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7437         types.
7438
7439 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7440
7441         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7442         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7443         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7444
7445 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7446
7447         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7448
7449 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7450             Chris January  <chris.january@arm.com>
7451
7452         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7453         * f-exp.y: Define 'KIND' token.
7454         (exp): New pattern for KIND expressions.
7455         (ptype): Handle types with a kind extension.
7456         (direct_abs_decl): Extend to spot kind extensions.
7457         (f77_keywords): Add 'kind' to the list.
7458         (push_kind_type): New function.
7459         (convert_to_kind_type): New function.
7460         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7461         * parse.c (operator_length_standard): Likewise.
7462         * parser-defs.h (enum type_pieces): Add tp_kind.
7463         * std-operator.def: Add UNOP_KIND.
7464
7465 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7466
7467         * f-exp.y (f_parse): Set yydebug.
7468
7469 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7470
7471         * f-lang.c (evaluate_subexp_f): New function.
7472         (exp_descriptor_f): New global.
7473         (f_language_defn): Use exp_descriptor_f instead of
7474         exp_descriptor_standard.
7475
7476 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7477
7478         * f-exp.y (struct token): Add comments.
7479         (dot_ops): Remove uppercase versions and the end marker.
7480         (f77_keywords): Likewise.
7481         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7482         entries in the dot_ops array are case insensitive, and use
7483         strncasecmp to compare strings.  Also some whitespace cleanup in
7484         this area.  Similar for the f77_keywords array, except entries in
7485         this list might be case sensitive.
7486
7487 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7488
7489         * f-exp.y (struct f77_boolean_val): Add comments.
7490         (boolean_values): Remove uppercase versions, and end marker.
7491         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7492         and use strncasecmp to achieve case insensitivity.  Additionally,
7493         perform whitespace cleanup around this code.
7494
7495 2019-03-06  Tom Tromey  <tromey@adacore.com>
7496
7497         * remote-sim.c (gdbsim_target_open): Use result of
7498         gdb_argv::release.
7499
7500 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7501         Dirk Schubert  <dirk.schubert@arm.com>
7502         Chris January  <chris.january@arm.com>
7503
7504         * eval.c (evaluate_subexp_standard): Call Fortran argument
7505         wrapping logic.
7506         * f-lang.c (struct value): A value which can be passed into a
7507         Fortran function call.
7508         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7509         where appropriate.
7510         (struct type): Value ready for a Fortran function call.
7511         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7512         is needed.
7513         * f-lang.h (fortran_argument_convert): Declaration.
7514         (fortran_preserve_arg_pointer): Declaration.
7515         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7516
7517 2019-03-05  Tom Tromey  <tromey@adacore.com>
7518
7519         * python/py-prettyprint.c (print_string_repr): Remove #if.
7520         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7521
7522 2019-03-05  Tom Tromey  <tromey@adacore.com>
7523
7524         * target.c (the_dummy_target): Move later.  Change type to
7525         "dummy_target".
7526         (initialize_targets): Don't initialize the_dummy_target.
7527
7528 2019-03-05  Tom Tromey  <tromey@adacore.com>
7529
7530         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7531         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7532
7533 2019-03-05  Tom Tromey  <tromey@adacore.com>
7534
7535         * windows-nat.c (windows_nat_target::attach)
7536         (windows_nat_target::detach): Don't call gdb_flush.
7537         * valprint.c (generic_val_print, val_print, val_print_string):
7538         Don't call gdb_flush.
7539         * utils.c (defaulted_query): Don't call gdb_flush.
7540         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7541         * target.c (target_announce_detach): Don't call gdb_flush.
7542         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7543         * remote.c (extended_remote_target::attach): Don't call
7544         gdb_flush.
7545         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7546         * printcmd.c (do_examine): Don't call gdb_flush.
7547         (info_display_command): Don't call gdb_flush.
7548         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7549         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7550         * memattr.c (info_mem_command): Don't call gdb_flush.
7551         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7552         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7553         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7554         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7555         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7556         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7557         (gnu_nat_target::detach): Don't call gdb_flush.
7558         * f-valprint.c (f_val_print): Don't call gdb_flush.
7559         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7560         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7561         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7562         gdb_flush.
7563         * c-valprint.c (c_val_print): Don't call gdb_flush.
7564         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7565
7566 2019-03-05  Tom Tromey  <tromey@adacore.com>
7567
7568         * varobj.c (update_dynamic_varobj_children): Update.
7569         (install_default_visualizer): Use reset, not release.
7570         * value.c (set_internalvar): Update.
7571         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7572         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7573         ATTRIBUTE_UNUSED_RESULT.
7574
7575 2019-03-05  Tom Tromey  <tromey@adacore.com>
7576
7577         * remote.c (class scoped_remote_fd) <release>: Add
7578         ATTRIBUTE_UNUSED_RESULT.
7579
7580 2019-03-05  Tom Tromey  <tromey@adacore.com>
7581
7582         * macroexp.c (struct macro_buffer) <release>: Add
7583         ATTRIBUTE_UNUSED_RESULT.
7584
7585 2019-03-05  Tom Tromey  <tromey@adacore.com>
7586
7587         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7588         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7589         ATTRIBUTE_UNUSED_RESULT.
7590
7591 2019-03-05  Tom Tromey  <tromey@adacore.com>
7592
7593         * common/scoped_fd.h (class scoped_fd) <release>: Add
7594         ATTRIBUTE_UNUSED_RESULT.
7595
7596 2019-03-05  Tom Tromey  <tromey@adacore.com>
7597
7598         * parser-defs.h (struct parser_state) <release>: Add
7599         ATTRIBUTE_UNUSED_RESULT.
7600
7601 2019-03-05  Tom Tromey  <tromey@adacore.com>
7602
7603         * utils.h (class gdb_argv) <release>: Add
7604         ATTRIBUTE_UNUSED_RESULT.
7605         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7606
7607 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7608
7609         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7610         for-loop range, to avoid compiler warnings.
7611
7612         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7613         avoid compiler warnings about unused variables.
7614
7615         * NEWS: Mention end of support for native debugging on MS-Windows
7616         before XP.
7617
7618         PR gdb/24292
7619         * common/netstuff.c:
7620         * gdbserver/gdbreplay.c
7621         * gdbserver/remote-utils.c:
7622         * ser-tcp.c:
7623         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7624         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7625         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7626         'getaddrinfo' and 'freeaddrinfo' were not available before
7627         Windows XP, and mingw.org's MinGW headers by default define
7628         _WIN32_WINNT to 0x500.
7629
7630 2019-03-01  Gary Benson <gbenson@redhat.com>
7631
7632         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7633
7634 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7635             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7636
7637         PR gdb/8527
7638         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7639         set_sigint_trap, clear_sigint_trap.
7640
7641 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7642
7643         * target.c (target_detach): Clear the regcache and the
7644         frame cache.
7645
7646 2019-02-27  Pedro Alves  <palves@redhat.com>
7647
7648         * utils.c (set_screen_size): When we cap the height/width sizes,
7649         tweak the corresponding command variable to show "unlimited":
7650
7651 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7652             Pedro Alves  <palves@redhat.com>
7653
7654         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7655         before calling rl_set_screen_size.
7656
7657 2019-02-27  Tom Tromey  <tromey@adacore.com>
7658
7659         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7660         define.
7661         * python/py-value.c: Remove Python 2.4 workaround.
7662         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7663         workaround.
7664         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7665         Python 2.4 workaround.
7666         * python/python-internal.h: Remove Python 2.4 comment.
7667         (Py_ssize_t): Don't define.
7668         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7669         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7670         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7671         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7672         * python/python.c (do_start_initialization): Remove Python 2.4
7673         workaround.
7674         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7675         (print_children): Remove Python 2.4 workaround.
7676         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7677         workaround.
7678         (CHARBUFFERPROC_NAME): Remove.
7679         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7680         Python 2.4 workaround.
7681
7682 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7683
7684         * NEWS: Note minimum Python version.
7685
7686 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7687
7688         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7689         code from these functions.  Remove corresponding ifdefs.  Use
7690         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7691         Remove gotos and target of gotos.
7692         (infpy_search_memory): Likewise.
7693
7694 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7695
7696         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7697         (hppa_gdbarch_init): Don't register deleted functions with
7698         gdbarch.
7699
7700 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7701
7702         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7703         (h8300_unwind_sp): Delete.
7704         (h8300_dummy_id): Delete.
7705         (h8300_gdbarch_init): Don't register deleted functions with
7706         gdbarch.
7707
7708 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7709
7710         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7711         (ft32_unwind_pc): Delete.
7712         (ft32_unwind_sp): Delete.
7713         (ft32_gdbarch_init): Don't register deleted functions with
7714         gdbarch.
7715
7716 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7717
7718         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7719         (frv_unwind_pc): Delete.
7720         (frv_unwind_sp): Delete.
7721         (frv_gdbarch_init): Don't register deleted functions with
7722         gdbarch.
7723
7724 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7725
7726         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7727         (riscv_unwind_pc): Delete.
7728         (riscv_unwind_sp): Delete.
7729         (riscv_gdbarch_init): Don't register deleted functions with
7730         gdbarch.
7731
7732 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7733
7734         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7735         (csky_unwind_pc): Delete.
7736         (csky_unwind_sp): Delete.
7737         (csky_gdbarch_init): Don't register deleted functions with
7738         gdbarch.
7739
7740 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7741
7742         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7743         (cris_unwind_pc): Delete.
7744         (cris_unwind_sp): Delete.
7745         (cris_gdbarch_init): Don't register deleted functions with
7746         gdbarch.
7747
7748 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7749
7750         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7751         (bfin_unwind_pc): Delete.
7752         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7753
7754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7755
7756         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7757         (arm_unwind_pc): Delete.
7758         (arm_unwind_sp): Delete.
7759         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7760
7761 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7762
7763         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7764         (arc_unwind_pc): Delete.
7765         (arc_unwind_sp): Delete.
7766         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7767
7768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7769
7770         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7771         (alpha_unwind_pc): Delete.
7772         (alpha_gdbarch_init): Don't register deleted functions with
7773         gdbarch.
7774
7775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7776
7777         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7778         (aarch64_unwind_pc): Delete.
7779         (aarch64_unwind_sp): Delete.
7780         (aarch64_gdbarch_init): Don't register deleted functions with
7781         gdbarch.
7782
7783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7784
7785         * gdbtypes.c (type_align): Don't consider static members when
7786         computing structure alignment.
7787
7788 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7789
7790         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7791         return 0 for other types.
7792         * arch-utils.c (default_type_align): Always return 0.
7793         * gdbarch.h: Regenerate.
7794         * gdbarch.sh (type_align): Extend comment.
7795         * gdbtypes.c (type_align): Add additional comments, always call
7796         gdbarch_type_align before applying the default rules.
7797         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7798         generic code will then apply a suitable default.
7799         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7800         types, return 0 for other types.
7801
7802 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7803
7804         * NEWS: Create a new section for the next release branch.
7805         Rename the section of the current branch, now that it has
7806         been cut.
7807
7808 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7809
7810         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7811         * version.in: Bump version to 8.3.50.DATE-git.
7812
7813 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7814
7815         * aix-thread.c (ptid_cmp): Remove unused variable.
7816         (get_signaled_thread): Likewise.
7817         (store_regs_user_thread): Likewise.
7818         (store_regs_kernel_thread): Likewise.
7819         (fetch_regs_kernel_thread): Remove shadowed variable.
7820
7821 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7822
7823         * features/riscv/32bit-cpu.xml: Add register numbers.
7824         * features/riscv/32bit-fpu.c: Regenerate.
7825         * features/riscv/32bit-fpu.xml: Add register numbers.
7826         * features/riscv/64bit-cpu.xml: Add register numbers.
7827         * features/riscv/64bit-fpu.c: Regenerate.
7828         * features/riscv/64bit-fpu.xml: Add register numbers.
7829
7830 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7831
7832         * NEWS: Mention two argument form of gdb.Value constructor.
7833         * python/py-value.c (convert_buffer_and_type_to_value): New
7834         function.
7835         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7836         Add support for handling an optional second argument.  Call
7837         convert_buffer_and_type_to_value as appropriate.
7838         * python/python-internal.h (Py_buffer_deleter): New struct.
7839         (Py_buffer_up): New typedef.
7840
7841 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7842
7843         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7844         instead of releasing ownership.
7845
7846 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7847
7848         * dwarf2read.c (open_and_init_dwp_file): Call
7849         elf_numsections instead of bfd_count_sections to initialize
7850         dwp_file->num_sections.
7851
7852 2019-02-25  Tom Tromey  <tromey@adacore.com>
7853
7854         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7855
7856 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7857
7858         * gcore.in: Add '--readnever' option when invoking GDB.
7859
7860 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7861
7862         * MAINTAINERS: Update my email address.
7863
7864 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7865
7866         * build-id.c (build_id_to_debug_bfd_1): New function.
7867         (build_id_to_debug_bfd): Look for separate debug file in
7868         sysroot.
7869
7870 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7871
7872         * gdbarch.sh: Update the copyright year range that is placed into
7873         generated files.
7874
7875 2019-02-22  Keith Seitz  <keiths@redhat.com>
7876
7877         PR symtab/23853
7878         * linespec.c (create_sals_line_offset): Search for the default
7879         symtab's filename instead of its fullname.
7880
7881 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7882
7883         * NEWS: Update style defaults.
7884
7885 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7886
7887         * main.c (captured_main_1): Disable styling in batch mode.
7888
7889 2019-02-20  Tom Tromey  <tom@tromey.com>
7890
7891         * symtab.c (symtab_symbol_info): Fix typos.
7892
7893 2019-02-20  Tom Tromey  <tromey@adacore.com>
7894
7895         * findcmd.c (_initialize_mem_search): Use upper case for
7896         metasyntactic variables.
7897
7898 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7899
7900         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7901         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7902
7903 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7904
7905         * top.h (source_file_name): Change to std::string.
7906         * top.c (source_file_name): Likewise.
7907         (command_line_input): Adjust.
7908         * cli/cli-script.c (script_from_file): Adjust.
7909
7910 2019-02-19  Tom Tromey  <tromey@adacore.com>
7911
7912         * ravenscar-thread.c
7913         (ravenscar_thread_target::update_thread_list): Don't call
7914         ada_build_task_list.
7915         * ada-lang.h (ada_build_task_list): Don't declare.
7916         * ada-tasks.c (struct ada_tasks_inferior_data)
7917         <task_list_valid_p>: Now bool.
7918         (read_known_tasks, ada_task_list_changed)
7919         (ada_tasks_invalidate_inferior_data): Update.
7920         (read_known_tasks_array): Return bool.
7921         (read_known_tasks_list): Likewise.
7922         (read_known_tasks): Return void.
7923         (ada_build_task_list): Now static.
7924
7925 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7926
7927         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7928         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7929
7930 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7931
7932         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7933         variant for ada_tasks_pspace_data_handle and
7934         ada_tasks_inferior_data_handle.
7935         (ada_tasks_pspace_data_cleanup): New function.
7936         (ada_tasks_inferior_data_cleanup): New function.
7937
7938 2019-02-17  Tom Tromey  <tom@tromey.com>
7939
7940         * macrotab.h (macro_source_fullname): Return a std::string.
7941         * macrotab.c (macro_include, check_for_redefinition)
7942         (macro_undef, macro_lookup_definition, foreach_macro)
7943         (foreach_macro_in_scope): Update.
7944         (macro_source_fullname): Return a std::string.
7945         * macrocmd.c (show_pp_source_pos): Update.
7946
7947 2019-02-17  Tom Tromey  <tom@tromey.com>
7948
7949         * macrocmd.c (show_pp_source_pos): Style the file names.
7950
7951 2019-02-17  Tom Tromey  <tom@tromey.com>
7952
7953         PR tui/24197:
7954         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7955
7956 2019-02-17  Tom Tromey  <tom@tromey.com>
7957
7958         * ada-lang.c (user_select_syms): Use filtered printing.
7959         * utils.c (wrap_style): New global.
7960         (desired_style): Remove.
7961         (emit_style_escape): Add stream parameter.
7962         (set_output_style, reset_terminal_style, prompt_for_continue):
7963         Update.
7964         (flush_wrap_buffer): Only flush gdb_stdout.
7965         (wrap_here): Set wrap_style.
7966         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7967         treat escape sequences as a character.  Change when wrap buffer is
7968         flushed.
7969         (fputs_styled): Do not set the output style when the default is
7970         requested.
7971         * ui-style.h (struct ui_file_style) <is_default>: New method.
7972         * source.c (print_source_lines_base): Emit escape sequences in one
7973         piece.
7974
7975 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7976
7977         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7978         integers and enumeration types.
7979
7980 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7981
7982         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7983         instead of lookup_symbol_in_language
7984         (do_exact_match): New function.
7985         (ada_get_symbol_name_matcher): Return do_exact_match when
7986         doing a verbatim match.
7987
7988 2019-02-15  Tom Tromey  <tromey@adacore.com>
7989
7990         * ravenscar-thread.c (ravenscar_thread_target::resume)
7991         (ravenscar_thread_target::wait): Special case wildcard requests.
7992
7993 2019-02-15  Tom Tromey  <tromey@adacore.com>
7994
7995         * ravenscar-thread.c (base_ptid): Remove.
7996         (struct ravenscar_thread_target) <close>: New method.
7997         <m_base_ptid>: New member.
7998         <update_inferior_ptid, active_task, task_is_currently_active,
7999         runtime_initialized>: Declare methods.
8000         <ravenscar_thread_target>: Add constructor.
8001         (ravenscar_thread_target::task_is_currently_active)
8002         (ravenscar_thread_target::update_inferior_ptid)
8003         (ravenscar_runtime_initialized): Rename.  Now methods.
8004         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8005         (ravenscar_thread_target::update_thread_list): Update.
8006         (ravenscar_thread_target::active_task): Now method.
8007         (ravenscar_thread_target::store_registers)
8008         (ravenscar_thread_target::prepare_to_store)
8009         (ravenscar_thread_target::prepare_to_store)
8010         (ravenscar_thread_target::mourn_inferior): Update.
8011         (ravenscar_inferior_created): Use "new" to create target.
8012         (ravenscar_thread_target::get_ada_task_ptid): Update.
8013         (_initialize_ravenscar): Don't initialize base_ptid.
8014         (ravenscar_ops): Remove global.
8015
8016 2019-02-15  Tom Tromey  <tromey@adacore.com>
8017
8018         * target.h (push_target): Declare new overload.
8019         * target.c (push_target): New overload, taking an rvalue reference.
8020         * remote.c (remote_target::open_1): Use push_target overload.
8021         * corelow.c (core_target_open): Use push_target overload.
8022
8023 2019-02-15  Tom Tromey  <tromey@adacore.com>
8024
8025         * ravenscar-thread.c (is_ravenscar_task)
8026         (ravenscar_task_is_currently_active): Return bool.
8027         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8028         (_initialize_ravenscar): Remove "(void)".
8029         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8030         Return bool.
8031
8032 2019-02-15  Tom Tromey  <tromey@adacore.com>
8033
8034         * ravenscar-thread.c (ravenscar_runtime_initializer)
8035         (has_ravenscar_runtime, get_running_thread_id)
8036         (ravenscar_thread_target::resume): Fix indentation.
8037
8038 2019-02-15  Tom Tromey  <tromey@adacore.com>
8039
8040         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8041         from ravenscar_arch_ops.
8042         (sparc_ravenscar_ops::fetch_registers)
8043         (sparc_ravenscar_ops::store_registers): Now methods.
8044         (sparc_ravenscar_prepare_to_store): Remove.
8045         (sparc_ravenscar_ops): Redefine.
8046         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8047         methods and destructor.  Remove members.
8048         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8049         (ravenscar_thread_target::store_registers)
8050         (ravenscar_thread_target::prepare_to_store): Update.
8051         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8052         Remove.
8053         (struct ppc_ravenscar_powerpc_ops): Derive from
8054         ravenscar_arch_ops.
8055         (ppc_ravenscar_powerpc_ops::fetch_registers)
8056         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8057         (ppc_ravenscar_powerpc_ops): Redefine.
8058         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8059         (ppc_ravenscar_e500_ops::fetch_registers)
8060         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8061         (ppc_ravenscar_e500_ops): Redefine.
8062         * aarch64-ravenscar-thread.c
8063         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8064         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8065         (aarch64_ravenscar_fetch_registers)
8066         (aarch64_ravenscar_store_registers): Now methods.
8067         (aarch64_ravenscar_ops): Redefine.
8068
8069 2019-02-15  Tom Tromey  <tromey@adacore.com>
8070
8071         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8072         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8073         (ravenscar_thread_target::stopped_by_watchpoint)
8074         (ravenscar_thread_target::stopped_data_address)
8075         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8076
8077 2019-02-15  Tom Tromey  <tromey@adacore.com>
8078
8079         * ravenscar-thread.c: Fix some typos.
8080
8081 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8082             Tom Tromey  <tromey@adacore.com>
8083
8084         * ada-lang.c (ada_exception_sal): Change addr_string to a
8085         std::string.
8086         (create_ada_exception_catchpoint): Update.
8087
8088 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8089             Tom Tromey  <tromey@adacore.com>
8090
8091         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8092         (bp_location_ops): Remove.
8093         (base_breakpoint_allocate_location): Update.
8094         (free_bp_location): Update.
8095         * ada-lang.c (class ada_catchpoint_location)
8096         <ada_catchpoint_location>: Remove ops parameter.
8097         (ada_catchpoint_location_dtor): Remove.
8098         (ada_catchpoint_location_ops): Remove.
8099         (allocate_location_exception): Update.
8100         * breakpoint.h (struct bp_location_ops): Remove.
8101         (class bp_location) <bp_location>: Remove bp_location_ops
8102         parameter.
8103         <~bp_location>: Add destructor.
8104         <ops>: Remove.
8105
8106 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8107             Pedro Alves  <palves@redhat.com>
8108
8109         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8110         'PATH_MAX'.
8111
8112 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8113             Samuel Thibault  <samuel.thibault@gnu.org>
8114             Thomas Schwinge  <thomas@codesourcery.com>
8115
8116         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8117         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8118
8119 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8120
8121         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8122         (check_empty): Use "const char *".
8123
8124         * gnu-nat.c (gnu_nat_target::detach): Instead of
8125         'detach_inferior (pid)' call
8126         'detach_inferior (find_inferior_pid (pid))'.
8127
8128         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8129         'nat/fork-inferior.o'.
8130         * gnu-nat.c: #include "nat/fork-inferior.h".
8131
8132         * gnu-nat.c (gnu_nat_target::detach): Instead of
8133         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8134         * gnu-nat.h: #include "inf-child.h".
8135         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8136         'i386_gnu_nat_target::fetch_registers'.
8137         (gnu_store_registers): Rename/move to
8138         'i386_gnu_nat_target::store_registers'.
8139
8140         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8141         * gnu-nat.h (mach_thread_info): New function.
8142         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8143
8144         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8145
8146 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8147
8148         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8149
8150 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8151
8152         * windows-nat.c (windows_add_thread): Add new parameter
8153         "main_thread_p" with default value set to false.  Update
8154         function documentation as well as all callers.
8155         (windows_delete_thread): Likewise.
8156         (fake_create_process): Update call to windows_add_thread.
8157         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8158         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8159         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8160         call to windows_delete_thread.
8161
8162 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8163
8164         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8165
8166 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8167
8168         * symfile.c (find_separate_debug_file): Use canonical path of
8169         sysroot with child_path instead of gdb_sysroot if it is valid.
8170
8171 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8172
8173         * symfile.c (find_separate_debug_file): Use child_path to
8174         determine if an object file is under a sysroot.
8175
8176 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8177
8178         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8179         unittests/child-path-selftests.c.
8180         * common/pathstuff.c (child_path): New function.
8181         * common/pathstuff.h (child_path): New prototype.
8182         * unittests/child-path-selftests.c: New file.
8183
8184 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8185
8186         * symfile.c (find_separate_debug_file): Look for separate debug
8187         files in debug directories under the sysroot.
8188
8189 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8190
8191         * symtab.h (struct minimal_symbol data_p): New const method.
8192         (struct minimal_symbol text_p): Likewise.
8193         * symtab.c (output_source_filename): Use file name style
8194         to print file name.
8195         (print_symbol_info): Likewise.
8196         (print_msymbol_info): Use address style to print addresses.
8197         Use function name style to print executable text symbols.
8198         (expand_symtab_containing_pc): Use data_p.
8199         (find_pc_sect_compunit_symtab): Likewise.
8200
8201 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8202
8203         * breakpoint.c (describe_other_breakpoints): Use address style
8204         to print addresses.
8205         (say_where): Likewise.
8206
8207 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8208
8209         * ada-typeprint.c (print_func_type): Print function name
8210         style to print function name.
8211         * c-typeprint.c (c_print_type_1): Likewise.
8212
8213 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8214
8215         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8216         for execve.
8217
8218 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8219
8220         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8221         type_stack.
8222
8223 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8224
8225         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8226         TYPE_CODE_REF types.
8227
8228 2019-02-08  Jim Wilson  <jimw@sifive.com>
8229
8230         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8231         (riscv_linux_fregset): New.
8232         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8233
8234 2019-02-07  Tom Tromey  <tom@tromey.com>
8235
8236         * thread.c (thread_cancel_execution_command): Update.
8237         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8238         methods.
8239         (struct thread_fsm_ops): Remove.
8240         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8241         (thread_fsm_should_stop, thread_fsm_return_value)
8242         (thread_fsm_set_finished, thread_fsm_finished_p)
8243         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8244         Don't declare.
8245         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8246         * infrun.c (clear_proceed_status_thread)
8247         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8248         (print_stop_event): Update.
8249         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8250         Add constructor.
8251         (step_command_fsm_ops): Remove.
8252         (new_step_command_fsm): Remove.
8253         (step_1): Update.
8254         (step_command_fsm::should_stop): Rename from
8255         step_command_fsm_should_stop.
8256         (step_command_fsm::clean_up): Rename from
8257         step_command_fsm_clean_up.
8258         (step_command_fsm::do_async_reply_reason): Rename from
8259         step_command_fsm_async_reply_reason.
8260         (struct until_next_fsm): Inherit from thread_fsm.  Add
8261         constructor.
8262         (until_next_fsm_ops): Remove.
8263         (new_until_next_fsm): Remove.
8264         (until_next_fsm::should_stop): Rename from
8265         until_next_fsm_should_stop.
8266         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8267         (until_next_fsm::do_async_reply_reason): Rename from
8268         until_next_fsm_async_reply_reason.
8269         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8270         constructor.  Change type of breakpoint.
8271         (finish_command_fsm_ops): Remove.
8272         (new_finish_command_fsm): Remove.
8273         (finish_command_fsm::should_stop): Rename from
8274         finish_command_fsm_should_stop.
8275         (finish_command_fsm::clean_up): Rename from
8276         finish_command_fsm_clean_up.
8277         (finish_command_fsm::return_value): Rename from
8278         finish_command_fsm_return_value.
8279         (finish_command_fsm::do_async_reply_reason): Rename from
8280         finish_command_fsm_async_reply_reason.
8281         (finish_command): Update.
8282         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8283         Add constructor.
8284         (call_thread_fsm_ops): Remove.
8285         (call_thread_fsm::call_thread_fsm): Rename from
8286         new_call_thread_fsm.
8287         (call_thread_fsm::should_stop): Rename from
8288         call_thread_fsm_should_stop.
8289         (call_thread_fsm::should_notify_stop): Rename from
8290         call_thread_fsm_should_notify_stop.
8291         (run_inferior_call, call_function_by_hand_dummy): Update.
8292         * cli/cli-interp.c (should_print_stop_to_console): Update.
8293         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8294         Add constructor.  Change type of location_breakpoint,
8295         caller_breakpoint.
8296         (until_break_fsm_ops): Remove.
8297         (new_until_break_fsm): Remove.
8298         (until_break_fsm::should_stop): Rename from
8299         until_break_fsm_should_stop.
8300         (until_break_fsm::clean_up): Rename from
8301         until_break_fsm_clean_up.
8302         (until_break_fsm::do_async_reply_reason): Rename from
8303         until_break_fsm_async_reply_reason.
8304         (until_break_command): Update.
8305         * thread-fsm.c: Remove.
8306         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8307
8308 2019-02-07  Tom Tromey  <tom@tromey.com>
8309
8310         * yy-remap.h: Add include guard.
8311         * xtensa-tdep.h: Add include guard.
8312         * xcoffread.h: Rename include guard.
8313         * varobj-iter.h: Add include guard.
8314         * tui/tui.h: Rename include guard.
8315         * tui/tui-winsource.h: Rename include guard.
8316         * tui/tui-wingeneral.h: Rename include guard.
8317         * tui/tui-windata.h: Rename include guard.
8318         * tui/tui-win.h: Rename include guard.
8319         * tui/tui-stack.h: Rename include guard.
8320         * tui/tui-source.h: Rename include guard.
8321         * tui/tui-regs.h: Rename include guard.
8322         * tui/tui-out.h: Rename include guard.
8323         * tui/tui-layout.h: Rename include guard.
8324         * tui/tui-io.h: Rename include guard.
8325         * tui/tui-hooks.h: Rename include guard.
8326         * tui/tui-file.h: Rename include guard.
8327         * tui/tui-disasm.h: Rename include guard.
8328         * tui/tui-data.h: Rename include guard.
8329         * tui/tui-command.h: Rename include guard.
8330         * tic6x-tdep.h: Add include guard.
8331         * target/waitstatus.h: Rename include guard.
8332         * target/wait.h: Rename include guard.
8333         * target/target.h: Rename include guard.
8334         * target/resume.h: Rename include guard.
8335         * target-float.h: Rename include guard.
8336         * stabsread.h: Add include guard.
8337         * rs6000-tdep.h: Add include guard.
8338         * riscv-fbsd-tdep.h: Add include guard.
8339         * regformats/regdef.h: Rename include guard.
8340         * record.h: Rename include guard.
8341         * python/python.h: Rename include guard.
8342         * python/python-internal.h: Rename include guard.
8343         * python/py-stopevent.h: Rename include guard.
8344         * python/py-ref.h: Rename include guard.
8345         * python/py-record.h: Rename include guard.
8346         * python/py-record-full.h: Rename include guard.
8347         * python/py-record-btrace.h: Rename include guard.
8348         * python/py-instruction.h: Rename include guard.
8349         * python/py-events.h: Rename include guard.
8350         * python/py-event.h: Rename include guard.
8351         * procfs.h: Add include guard.
8352         * proc-utils.h: Add include guard.
8353         * p-lang.h: Add include guard.
8354         * or1k-tdep.h: Rename include guard.
8355         * observable.h: Rename include guard.
8356         * nto-tdep.h: Rename include guard.
8357         * nat/x86-linux.h: Rename include guard.
8358         * nat/x86-linux-dregs.h: Rename include guard.
8359         * nat/x86-gcc-cpuid.h: Add include guard.
8360         * nat/x86-dregs.h: Rename include guard.
8361         * nat/x86-cpuid.h: Rename include guard.
8362         * nat/ppc-linux.h: Rename include guard.
8363         * nat/mips-linux-watch.h: Rename include guard.
8364         * nat/linux-waitpid.h: Rename include guard.
8365         * nat/linux-ptrace.h: Rename include guard.
8366         * nat/linux-procfs.h: Rename include guard.
8367         * nat/linux-osdata.h: Rename include guard.
8368         * nat/linux-nat.h: Rename include guard.
8369         * nat/linux-namespaces.h: Rename include guard.
8370         * nat/linux-btrace.h: Rename include guard.
8371         * nat/glibc_thread_db.h: Rename include guard.
8372         * nat/gdb_thread_db.h: Rename include guard.
8373         * nat/gdb_ptrace.h: Rename include guard.
8374         * nat/fork-inferior.h: Rename include guard.
8375         * nat/amd64-linux-siginfo.h: Rename include guard.
8376         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8377         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8378         * nat/aarch64-linux.h: Rename include guard.
8379         * nat/aarch64-linux-hw-point.h: Rename include guard.
8380         * mn10300-tdep.h: Add include guard.
8381         * mips-linux-tdep.h: Add include guard.
8382         * mi/mi-parse.h: Rename include guard.
8383         * mi/mi-out.h: Rename include guard.
8384         * mi/mi-main.h: Rename include guard.
8385         * mi/mi-interp.h: Rename include guard.
8386         * mi/mi-getopt.h: Rename include guard.
8387         * mi/mi-console.h: Rename include guard.
8388         * mi/mi-common.h: Rename include guard.
8389         * mi/mi-cmds.h: Rename include guard.
8390         * mi/mi-cmd-break.h: Rename include guard.
8391         * m2-lang.h: Add include guard.
8392         * location.h: Rename include guard.
8393         * linux-record.h: Rename include guard.
8394         * linux-nat.h: Add include guard.
8395         * linux-fork.h: Add include guard.
8396         * i386-darwin-tdep.h: Rename include guard.
8397         * hppa-linux-offsets.h: Add include guard.
8398         * guile/guile.h: Rename include guard.
8399         * guile/guile-internal.h: Rename include guard.
8400         * gnu-nat.h: Rename include guard.
8401         * gdb-stabs.h: Rename include guard.
8402         * frv-tdep.h: Add include guard.
8403         * f-lang.h: Add include guard.
8404         * event-loop.h: Add include guard.
8405         * darwin-nat.h: Rename include guard.
8406         * cp-abi.h: Rename include guard.
8407         * config/sparc/nm-sol2.h: Rename include guard.
8408         * config/nm-nto.h: Rename include guard.
8409         * config/nm-linux.h: Add include guard.
8410         * config/i386/nm-i386gnu.h: Rename include guard.
8411         * config/djgpp/nl_types.h: Rename include guard.
8412         * config/djgpp/langinfo.h: Rename include guard.
8413         * compile/gcc-cp-plugin.h: Add include guard.
8414         * compile/gcc-c-plugin.h: Add include guard.
8415         * compile/compile.h: Rename include guard.
8416         * compile/compile-object-run.h: Rename include guard.
8417         * compile/compile-object-load.h: Rename include guard.
8418         * compile/compile-internal.h: Rename include guard.
8419         * compile/compile-cplus.h: Rename include guard.
8420         * compile/compile-c.h: Rename include guard.
8421         * common/xml-utils.h: Rename include guard.
8422         * common/x86-xstate.h: Rename include guard.
8423         * common/version.h: Rename include guard.
8424         * common/vec.h: Rename include guard.
8425         * common/tdesc.h: Rename include guard.
8426         * common/selftest.h: Rename include guard.
8427         * common/scoped_restore.h: Rename include guard.
8428         * common/scoped_mmap.h: Rename include guard.
8429         * common/scoped_fd.h: Rename include guard.
8430         * common/safe-iterator.h: Rename include guard.
8431         * common/run-time-clock.h: Rename include guard.
8432         * common/refcounted-object.h: Rename include guard.
8433         * common/queue.h: Rename include guard.
8434         * common/ptid.h: Rename include guard.
8435         * common/print-utils.h: Rename include guard.
8436         * common/preprocessor.h: Rename include guard.
8437         * common/pathstuff.h: Rename include guard.
8438         * common/observable.h: Rename include guard.
8439         * common/netstuff.h: Rename include guard.
8440         * common/job-control.h: Rename include guard.
8441         * common/host-defs.h: Rename include guard.
8442         * common/gdb_wait.h: Rename include guard.
8443         * common/gdb_vecs.h: Rename include guard.
8444         * common/gdb_unlinker.h: Rename include guard.
8445         * common/gdb_unique_ptr.h: Rename include guard.
8446         * common/gdb_tilde_expand.h: Rename include guard.
8447         * common/gdb_sys_time.h: Rename include guard.
8448         * common/gdb_string_view.h: Rename include guard.
8449         * common/gdb_splay_tree.h: Rename include guard.
8450         * common/gdb_setjmp.h: Rename include guard.
8451         * common/gdb_ref_ptr.h: Rename include guard.
8452         * common/gdb_optional.h: Rename include guard.
8453         * common/gdb_locale.h: Rename include guard.
8454         * common/gdb_assert.h: Rename include guard.
8455         * common/filtered-iterator.h: Rename include guard.
8456         * common/filestuff.h: Rename include guard.
8457         * common/fileio.h: Rename include guard.
8458         * common/environ.h: Rename include guard.
8459         * common/common-utils.h: Rename include guard.
8460         * common/common-types.h: Rename include guard.
8461         * common/common-regcache.h: Rename include guard.
8462         * common/common-inferior.h: Rename include guard.
8463         * common/common-gdbthread.h: Rename include guard.
8464         * common/common-exceptions.h: Rename include guard.
8465         * common/common-defs.h: Rename include guard.
8466         * common/common-debug.h: Rename include guard.
8467         * common/cleanups.h: Rename include guard.
8468         * common/buffer.h: Rename include guard.
8469         * common/btrace-common.h: Rename include guard.
8470         * common/break-common.h: Rename include guard.
8471         * cli/cli-utils.h: Rename include guard.
8472         * cli/cli-style.h: Rename include guard.
8473         * cli/cli-setshow.h: Rename include guard.
8474         * cli/cli-script.h: Rename include guard.
8475         * cli/cli-interp.h: Rename include guard.
8476         * cli/cli-decode.h: Rename include guard.
8477         * cli/cli-cmds.h: Rename include guard.
8478         * charset-list.h: Add include guard.
8479         * buildsym-legacy.h: Rename include guard.
8480         * bfin-tdep.h: Add include guard.
8481         * ax.h: Rename include guard.
8482         * arm-linux-tdep.h: Add include guard.
8483         * arm-fbsd-tdep.h: Add include guard.
8484         * arch/xtensa.h: Rename include guard.
8485         * arch/tic6x.h: Add include guard.
8486         * arch/i386.h: Add include guard.
8487         * arch/arm.h: Rename include guard.
8488         * arch/arm-linux.h: Rename include guard.
8489         * arch/arm-get-next-pcs.h: Rename include guard.
8490         * arch/amd64.h: Add include guard.
8491         * arch/aarch64-insn.h: Rename include guard.
8492         * arch-utils.h: Rename include guard.
8493         * annotate.h: Add include guard.
8494         * amd64-darwin-tdep.h: Rename include guard.
8495         * aarch64-linux-tdep.h: Add include guard.
8496         * aarch64-fbsd-tdep.h: Add include guard.
8497         * aarch32-linux-nat.h: Add include guard.
8498
8499 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8500
8501         * macrotab.c (macro_define_internal): New function that
8502         factorizes macro_define_object_internal and macro_define_function
8503         code.
8504         (macro_define_object_internal): Use macro_define_internal.
8505         (macro_define_function): Likewise.
8506
8507 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8508
8509         * macrocmd.c (extract_identifier): Return
8510         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8511         callers.
8512
8513 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8514
8515         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8516
8517 2019-02-05  Tom Tromey  <tom@tromey.com>
8518
8519         * target.c (target_stack::unpush): Move assertion earlier.
8520
8521 2019-01-30  Tom Tromey  <tom@tromey.com>
8522
8523         PR python/23615:
8524         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8525         (gdbpy_parse_and_eval): Likewise.
8526         * python/python-internal.h (gdbpy_allow_threads): New class.
8527
8528 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8529
8530         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8531         (aarch64_fbsd_fpregmap): Move earlier.
8532         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8533         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8534         instead of individual calls to trad_frame_set_reg_addr.
8535         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8536         earlier.
8537         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8538         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8539         instead of individual calls to trad_frame_set_reg_addr.
8540
8541 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8542
8543         * CONTRIBUTE: Replace contribution list with wiki link.
8544
8545 2019-01-25  Tom Tromey  <tom@tromey.com>
8546
8547         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8548
8549 2019-01-25  Tom Tromey  <tom@tromey.com>
8550
8551         * xtensa-linux-nat.c: Fix common/ includes.
8552         * xml-support.h: Fix common/ includes.
8553         * xml-support.c: Fix common/ includes.
8554         * x86-linux-nat.c: Fix common/ includes.
8555         * windows-nat.c: Fix common/ includes.
8556         * varobj.h: Fix common/ includes.
8557         * varobj.c: Fix common/ includes.
8558         * value.c: Fix common/ includes.
8559         * valops.c: Fix common/ includes.
8560         * utils.c: Fix common/ includes.
8561         * unittests/xml-utils-selftests.c: Fix common/ includes.
8562         * unittests/utils-selftests.c: Fix common/ includes.
8563         * unittests/unpack-selftests.c: Fix common/ includes.
8564         * unittests/tracepoint-selftests.c: Fix common/ includes.
8565         * unittests/style-selftests.c: Fix common/ includes.
8566         * unittests/string_view-selftests.c: Fix common/ includes.
8567         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8568         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8569         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8570         * unittests/rsp-low-selftests.c: Fix common/ includes.
8571         * unittests/parse-connection-spec-selftests.c: Fix common/
8572         includes.
8573         * unittests/optional-selftests.c: Fix common/ includes.
8574         * unittests/offset-type-selftests.c: Fix common/ includes.
8575         * unittests/observable-selftests.c: Fix common/ includes.
8576         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8577         * unittests/memrange-selftests.c: Fix common/ includes.
8578         * unittests/memory-map-selftests.c: Fix common/ includes.
8579         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8580         * unittests/function-view-selftests.c: Fix common/ includes.
8581         * unittests/environ-selftests.c: Fix common/ includes.
8582         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8583         * unittests/common-utils-selftests.c: Fix common/ includes.
8584         * unittests/cli-utils-selftests.c: Fix common/ includes.
8585         * unittests/array-view-selftests.c: Fix common/ includes.
8586         * ui-file.c: Fix common/ includes.
8587         * tui/tui-io.c: Fix common/ includes.
8588         * tracepoint.h: Fix common/ includes.
8589         * tracepoint.c: Fix common/ includes.
8590         * tracefile-tfile.c: Fix common/ includes.
8591         * top.h: Fix common/ includes.
8592         * top.c: Fix common/ includes.
8593         * thread.c: Fix common/ includes.
8594         * target/waitstatus.h: Fix common/ includes.
8595         * target/waitstatus.c: Fix common/ includes.
8596         * target.h: Fix common/ includes.
8597         * target.c: Fix common/ includes.
8598         * target-memory.c: Fix common/ includes.
8599         * target-descriptions.c: Fix common/ includes.
8600         * symtab.h: Fix common/ includes.
8601         * symfile.c: Fix common/ includes.
8602         * stap-probe.c: Fix common/ includes.
8603         * spu-linux-nat.c: Fix common/ includes.
8604         * sparc-nat.c: Fix common/ includes.
8605         * source.c: Fix common/ includes.
8606         * solib.c: Fix common/ includes.
8607         * solib-target.c: Fix common/ includes.
8608         * ser-unix.c: Fix common/ includes.
8609         * ser-tcp.c: Fix common/ includes.
8610         * ser-pipe.c: Fix common/ includes.
8611         * ser-base.c: Fix common/ includes.
8612         * selftest-arch.c: Fix common/ includes.
8613         * s12z-tdep.c: Fix common/ includes.
8614         * rust-exp.y: Fix common/ includes.
8615         * rs6000-aix-tdep.c: Fix common/ includes.
8616         * riscv-tdep.c: Fix common/ includes.
8617         * remote.c: Fix common/ includes.
8618         * remote-notif.h: Fix common/ includes.
8619         * remote-fileio.h: Fix common/ includes.
8620         * remote-fileio.c: Fix common/ includes.
8621         * regcache.h: Fix common/ includes.
8622         * regcache.c: Fix common/ includes.
8623         * record-btrace.c: Fix common/ includes.
8624         * python/python.c: Fix common/ includes.
8625         * python/py-type.c: Fix common/ includes.
8626         * python/py-inferior.c: Fix common/ includes.
8627         * progspace.h: Fix common/ includes.
8628         * producer.c: Fix common/ includes.
8629         * procfs.c: Fix common/ includes.
8630         * proc-api.c: Fix common/ includes.
8631         * printcmd.c: Fix common/ includes.
8632         * ppc-linux-nat.c: Fix common/ includes.
8633         * parser-defs.h: Fix common/ includes.
8634         * osdata.c: Fix common/ includes.
8635         * obsd-nat.c: Fix common/ includes.
8636         * nat/x86-linux.c: Fix common/ includes.
8637         * nat/x86-linux-dregs.c: Fix common/ includes.
8638         * nat/x86-dregs.h: Fix common/ includes.
8639         * nat/x86-dregs.c: Fix common/ includes.
8640         * nat/ppc-linux.c: Fix common/ includes.
8641         * nat/mips-linux-watch.h: Fix common/ includes.
8642         * nat/mips-linux-watch.c: Fix common/ includes.
8643         * nat/linux-waitpid.c: Fix common/ includes.
8644         * nat/linux-ptrace.h: Fix common/ includes.
8645         * nat/linux-ptrace.c: Fix common/ includes.
8646         * nat/linux-procfs.c: Fix common/ includes.
8647         * nat/linux-personality.c: Fix common/ includes.
8648         * nat/linux-osdata.c: Fix common/ includes.
8649         * nat/linux-namespaces.c: Fix common/ includes.
8650         * nat/linux-btrace.h: Fix common/ includes.
8651         * nat/linux-btrace.c: Fix common/ includes.
8652         * nat/fork-inferior.c: Fix common/ includes.
8653         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8654         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8655         * nat/aarch64-linux.c: Fix common/ includes.
8656         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8657         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8658         * namespace.h: Fix common/ includes.
8659         * mips-linux-tdep.c: Fix common/ includes.
8660         * minsyms.c: Fix common/ includes.
8661         * mi/mi-parse.h: Fix common/ includes.
8662         * mi/mi-main.c: Fix common/ includes.
8663         * mi/mi-cmd-env.c: Fix common/ includes.
8664         * memrange.h: Fix common/ includes.
8665         * memattr.c: Fix common/ includes.
8666         * maint.h: Fix common/ includes.
8667         * maint.c: Fix common/ includes.
8668         * main.c: Fix common/ includes.
8669         * machoread.c: Fix common/ includes.
8670         * location.c: Fix common/ includes.
8671         * linux-thread-db.c: Fix common/ includes.
8672         * linux-nat.c: Fix common/ includes.
8673         * linux-fork.c: Fix common/ includes.
8674         * inline-frame.c: Fix common/ includes.
8675         * infrun.c: Fix common/ includes.
8676         * inflow.c: Fix common/ includes.
8677         * inferior.h: Fix common/ includes.
8678         * inferior.c: Fix common/ includes.
8679         * infcmd.c: Fix common/ includes.
8680         * inf-ptrace.c: Fix common/ includes.
8681         * inf-child.c: Fix common/ includes.
8682         * ia64-linux-nat.c: Fix common/ includes.
8683         * i387-tdep.c: Fix common/ includes.
8684         * i386-tdep.c: Fix common/ includes.
8685         * i386-linux-tdep.c: Fix common/ includes.
8686         * i386-linux-nat.c: Fix common/ includes.
8687         * i386-go32-tdep.c: Fix common/ includes.
8688         * i386-fbsd-tdep.c: Fix common/ includes.
8689         * i386-fbsd-nat.c: Fix common/ includes.
8690         * guile/scm-type.c: Fix common/ includes.
8691         * guile/guile.c: Fix common/ includes.
8692         * go32-nat.c: Fix common/ includes.
8693         * gnu-nat.c: Fix common/ includes.
8694         * gdbthread.h: Fix common/ includes.
8695         * gdbarch-selftests.c: Fix common/ includes.
8696         * gdb_usleep.c: Fix common/ includes.
8697         * gdb_select.h: Fix common/ includes.
8698         * gdb_bfd.c: Fix common/ includes.
8699         * gcore.c: Fix common/ includes.
8700         * fork-child.c: Fix common/ includes.
8701         * findvar.c: Fix common/ includes.
8702         * fbsd-nat.c: Fix common/ includes.
8703         * event-top.c: Fix common/ includes.
8704         * event-loop.c: Fix common/ includes.
8705         * dwarf2read.c: Fix common/ includes.
8706         * dwarf2loc.c: Fix common/ includes.
8707         * dwarf2-frame.c: Fix common/ includes.
8708         * dwarf-index-cache.c: Fix common/ includes.
8709         * dtrace-probe.c: Fix common/ includes.
8710         * disasm-selftests.c: Fix common/ includes.
8711         * defs.h: Fix common/ includes.
8712         * csky-tdep.c: Fix common/ includes.
8713         * cp-valprint.c: Fix common/ includes.
8714         * cp-support.h: Fix common/ includes.
8715         * cp-support.c: Fix common/ includes.
8716         * corelow.c: Fix common/ includes.
8717         * completer.h: Fix common/ includes.
8718         * completer.c: Fix common/ includes.
8719         * compile/compile.c: Fix common/ includes.
8720         * compile/compile-loc2c.c: Fix common/ includes.
8721         * compile/compile-cplus-types.c: Fix common/ includes.
8722         * compile/compile-cplus-symbols.c: Fix common/ includes.
8723         * command.h: Fix common/ includes.
8724         * cli/cli-dump.c: Fix common/ includes.
8725         * cli/cli-cmds.c: Fix common/ includes.
8726         * charset.c: Fix common/ includes.
8727         * build-id.c: Fix common/ includes.
8728         * btrace.h: Fix common/ includes.
8729         * btrace.c: Fix common/ includes.
8730         * breakpoint.h: Fix common/ includes.
8731         * breakpoint.c: Fix common/ includes.
8732         * ax.h:
8733         (enum agent_op): Fix common/ includes.
8734         * ax-general.c (struct aop_map): Fix common/ includes.
8735         * ax-gdb.c: Fix common/ includes.
8736         * auxv.c: Fix common/ includes.
8737         * auto-load.c: Fix common/ includes.
8738         * arm-tdep.c: Fix common/ includes.
8739         * arch/riscv.c: Fix common/ includes.
8740         * arch/ppc-linux-common.c: Fix common/ includes.
8741         * arch/i386.c: Fix common/ includes.
8742         * arch/arm.c: Fix common/ includes.
8743         * arch/arm-linux.c: Fix common/ includes.
8744         * arch/arm-get-next-pcs.c: Fix common/ includes.
8745         * arch/amd64.c: Fix common/ includes.
8746         * arch/aarch64.c: Fix common/ includes.
8747         * arch/aarch64-insn.c: Fix common/ includes.
8748         * arch-utils.c: Fix common/ includes.
8749         * amd64-windows-tdep.c: Fix common/ includes.
8750         * amd64-tdep.c: Fix common/ includes.
8751         * amd64-sol2-tdep.c: Fix common/ includes.
8752         * amd64-obsd-tdep.c: Fix common/ includes.
8753         * amd64-nbsd-tdep.c: Fix common/ includes.
8754         * amd64-linux-tdep.c: Fix common/ includes.
8755         * amd64-linux-nat.c: Fix common/ includes.
8756         * amd64-fbsd-tdep.c: Fix common/ includes.
8757         * amd64-fbsd-nat.c: Fix common/ includes.
8758         * amd64-dicos-tdep.c: Fix common/ includes.
8759         * amd64-darwin-tdep.c: Fix common/ includes.
8760         * agent.c: Fix common/ includes.
8761         * ada-lang.h: Fix common/ includes.
8762         * ada-lang.c: Fix common/ includes.
8763         * aarch64-tdep.c: Fix common/ includes.
8764
8765 2019-01-25  Tom Tromey  <tom@tromey.com>
8766
8767         * common/create-version.sh: Use common/version.h.
8768
8769 2019-01-24  Pedro Alves  <palves@redhat.com>
8770
8771         * infrun.c (signal_stop, signal_print, signal_program)
8772         (signal_catch, signal_pass): Now arrays instead of pointers.
8773         (update_signals_program_target, do_target_resume)
8774         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8775         * linux-nat.c (linux_nat_target::pass_signals)
8776         (linux_nat_target::create_inferior, linux_nat_target::attach):
8777         Adjust.
8778         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8779         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8780         * procfs.c (procfs_target::pass_signals): Adjust.
8781         * record-full.c (record_full_target::resume): Adjust.
8782         * remote.c (remote_target::pass_signals)
8783         (remote_target::program_signals): Adjust.
8784         * target-debug.h (target_debug_print_signals): Now takes a
8785         gdb::array_view as parameter.  Adjust.
8786         * target.h (target_ops) <pass_signals, program_signals>: Replace
8787         pointer and length parameters with gdb::array_view.
8788         (target_pass_signals, target_program_signals): Likewise.
8789         * target-delegates.c: Regenerate.
8790
8791 2019-01-24  Pedro Alves  <palves@redhat.com>
8792
8793         * common/forward-scope-exit.h
8794         (forward_scope_exit::forward_scope_exit): Pass arguments to
8795         m_bind_function directly, instead of creating a std::bind and
8796         copying that.
8797
8798 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8799
8800         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8801         for static members.
8802         (pass_in_v_vfp_candidate): Likewise.
8803
8804 2019-01-23  Tom Tromey  <tom@tromey.com>
8805             Pedro Alves  <palves@redhat.com>
8806
8807         * regcache.c (class regcache_invalidator): Remove.
8808         (regcache::raw_write): Use make_scope_exit.
8809
8810 2019-01-23  Tom Tromey  <tom@tromey.com>
8811
8812         * ui-out.h (class ui_out_emit_type): Update comment.
8813
8814 2019-01-23  Tom Tromey  <tom@tromey.com>
8815
8816         * infrun.c (fetch_inferior_event): Update comment.
8817
8818 2019-01-23  Tom Tromey  <tom@tromey.com>
8819             Pedro Alves  <palves@redhat.com>
8820
8821         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8822         parameter.
8823         (fetch_inferior_event): Use SCOPE_EXIT.
8824
8825
8826 2019-01-23  Tom Tromey  <tom@tromey.com>
8827             Pedro Alves  <palves@redhat.com>
8828
8829         * infrun.c (disable_thread_events): Delete.
8830         (stop_all_threads): Use SCOPE_EXIT.
8831
8832 2019-01-23  Tom Tromey  <tom@tromey.com>
8833             Pedro Alves  <palves@redhat.com>
8834
8835         * symfile.c: Include forward-scope-exit.h.
8836         (clear_symtab_users_cleanup): Replace forward declaration with
8837         a FORWARD_SCOPE_EXIT.
8838         (syms_from_objfile_1): Use the forward_scope_exit and
8839         gdb::optional instead of cleanup_function.
8840         (reread_symbols): Use the forward_scope_exit instead of
8841         cleanup_function.
8842         (clear_symtab_users_cleanup): Remove function.
8843
8844 2019-01-23  Tom Tromey  <tom@tromey.com>
8845             Pedro Alves  <palves@redhat.com>
8846
8847         * linux-nat.c: Include scope-exit.h.
8848         (cleanup_target_stop): Remove.
8849         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8850         SCOPE_EXIT.
8851
8852 2019-01-23  Tom Tromey  <tom@tromey.com>
8853             Pedro Alves  <palves@redhat.com>
8854
8855         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8856         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8857
8858 2019-01-23  Tom Tromey  <tom@tromey.com>
8859             Andrew Burgess  <andrew.burgess@embecosm.com>
8860             Pedro Alves  <palves@redhat.com>
8861
8862         * infrun.c (fetch_inferior_event): Use scope_exit.
8863         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8864         * top.c (execute_command): Use scope_exit.
8865         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8866         * utils.c (do_bpstat_clear_actions_cleanup)
8867         (make_bpstat_clear_actions_cleanup): Remove.
8868
8869 2019-01-23  Tom Tromey  <tom@tromey.com>
8870             Pedro Alves  <palves@redhat.com>
8871
8872         * infrun.c: Include "common/scope-exit.h"
8873         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8874         (wait_for_inferior): Use SCOPE_EXIT.
8875         (fetch_inferior_event): Use scope_exit.
8876
8877 2019-01-23  Tom Tromey  <tom@tromey.com>
8878             Pedro Alves  <palves@redhat.com>
8879
8880         * breakpoint.c (create_breakpoint): Remove cleanup.
8881
8882 2019-01-23  Tom Tromey  <tom@tromey.com>
8883             Andrew Burgess  <andrew.burgess@embecosm.com>
8884             Pedro Alves  <palves@redhat.com>
8885
8886 2019-01-23  Pedro Alves  <palves@redhat.com>
8887
8888         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8889
8890 2019-01-23  Pedro Alves  <palves@redhat.com>
8891             Andrew Burgess  <andrew.burgess@embecosm.com>
8892
8893         * gdbthread.h: Include "common/forward-scope-exit.h".
8894         (scoped_finish_thread_state): Redefine custom class in terms of
8895         forward_scope_exit.
8896
8897 2019-01-23  Pedro Alves  <palves@redhat.com>
8898             Andrew Burgess  <andrew.burgess@embecosm.com>
8899
8900         * common/forward-scope-exit.h: New file.
8901
8902 2019-01-23  Pedro Alves  <palves@redhat.com>
8903             Andrew Burgess  <andrew.burgess@embecosm.com>
8904             Tom Tromey  <tom@tromey.com>
8905
8906         * common/scope-exit.h: New file.
8907
8908 2019-01-23  Pedro Alves  <palves@redhat.com>
8909
8910         * common/preprocessor.h (ESC): Rename to ...
8911         (ESC_PARENS): ... this.
8912         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8913         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8914
8915 2019-01-23  Tom Tromey  <tom@tromey.com>
8916
8917         * language.h (class scoped_switch_to_sym_language_if_auto):
8918         Initialize m_lang in both cases.
8919
8920 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8921
8922         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8923         with XCNEW.
8924
8925 2019-01-22  Tom Tromey  <tom@tromey.com>
8926
8927         * corelow.c: Do not include sys/file.h.
8928
8929 2019-01-22  Tom Tromey  <tom@tromey.com>
8930
8931         * tui/tui-wingeneral.h: Include gdb_curses.h.
8932
8933 2019-01-22  Tom Tromey  <tom@tromey.com>
8934
8935         * source-cache.h (class source_cache) <get_source_lines,
8936         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8937
8938 2019-01-22  Tom Tromey  <tom@tromey.com>
8939
8940         * remote-fileio.h (struct remote_target): Declare.
8941
8942 2019-01-22  Tom Tromey  <tom@tromey.com>
8943
8944         * python/py-arch.c: Do not include py-ref.h.
8945         * python/py-bpevent.c: Do not include py-ref.h.
8946         * python/py-cmd.c: Do not include py-ref.h.
8947         * python/py-continueevent.c: Do not include py-ref.h.
8948         * python/py-event.h: Do not include py-ref.h.
8949         * python/py-evtregistry.c: Do not include py-ref.h.
8950         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8951         * python/py-frame.c: Do not include py-ref.h.
8952         * python/py-framefilter.c: Do not include py-ref.h.
8953         * python/py-function.c: Do not include py-ref.h.
8954         * python/py-infevents.c: Do not include py-ref.h.
8955         * python/py-linetable.c: Do not include py-ref.h.
8956         * python/py-objfile.c: Do not include py-ref.h.
8957         * python/py-param.c: Do not include py-ref.h.
8958         * python/py-prettyprint.c: Do not include py-ref.h.
8959         * python/py-progspace.c: Do not include py-ref.h.
8960         * python/py-symbol.c: Do not include py-ref.h.
8961         * python/py-symtab.c: Do not include py-ref.h.
8962         * python/py-type.c: Do not include py-ref.h.
8963         * python/py-unwind.c: Do not include py-ref.h.
8964         * python/py-utils.c: Do not include py-ref.h.
8965         * python/py-value.c: Do not include py-ref.h.
8966         * python/py-varobj.c: Do not include py-ref.h.
8967         * python/py-xmethods.c: Do not include py-ref.h.
8968         * python/python.c: Do not include py-ref.h.
8969         * varobj.c: Do not include py-ref.h.
8970
8971 2019-01-22  Tom Tromey  <tom@tromey.com>
8972
8973         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8974         keyword for bcache.
8975
8976 2019-01-22  Tom Tromey  <tom@tromey.com>
8977
8978         * compile/compile-cplus-types.c: Remove a comment by #include.
8979
8980 2019-01-22  Tom Tromey  <tom@tromey.com>
8981
8982         * compile/gcc-c-plugin.h: Include compile-internal.h.
8983
8984 2019-01-22  Tom Tromey  <tom@tromey.com>
8985
8986         * stabsread.c (EXTERN): Do not define.
8987         (symnum, next_symbol_text_func, processing_gcc_compilation)
8988         (within_function, global_sym_chain, global_stabs)
8989         (previous_stab_code, this_object_header_files)
8990         (n_this_object_header_files)
8991         (n_allocated_this_object_header_files): Define.
8992         * stabsread.h (EXTERN): Never define.  Use "extern".
8993
8994 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8995
8996         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8997         history_value.
8998
8999 2019-01-21  Tom Tromey  <tom@tromey.com>
9000
9001         * ui-out.c: Fix includes.
9002         * tui/tui-source.c: Fix includes.
9003         * target.c: Fix includes.
9004         * remote.c: Fix includes.
9005         * regcache.c: Fix includes.
9006         * python/py-block.c: Fix includes.
9007         * printcmd.c: Fix includes.
9008         * or1k-tdep.c: Fix includes.
9009         * mi/mi-main.c: Fix includes.
9010         * m32r-tdep.c: Fix includes.
9011         * csky-tdep.c: Fix includes.
9012         * compile/compile-cplus-types.c: Fix includes.
9013         * cli/cli-interp.c: Fix includes.
9014
9015 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9016
9017         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9018         for padding.
9019
9020 2019-01-16  Tom Tromey  <tom@tromey.com>
9021
9022         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9023         earlier.
9024         (struct objfile) <msymbols_range>: Move from top level.
9025         <msymbols>: New method.
9026         (class objfile_msymbols): Remove.
9027         * symtab.c (default_collect_symbol_completion_matches_break_on):
9028         Update.
9029         * symmisc.c (dump_msymbols): Update.
9030         * stabsread.c (scan_file_globals): Update.
9031         * objc-lang.c (info_selectors_command, info_classes_command)
9032         (find_methods): Update.
9033         * minsyms.c (find_solib_trampoline_target): Update.
9034         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9035         * coffread.c (coff_symfile_read): Update.
9036         * ada-lang.c (ada_lookup_simple_minsym)
9037         (ada_collect_symbol_completion_matches): Update.
9038
9039 2019-01-16  Tom Tromey  <tom@tromey.com>
9040
9041         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9042         type.  Remove no-argument constructor.
9043         <iterator::operator++>: Simplify.
9044         <begin>: Update.
9045         <end>: Use minimal_symbol_count.
9046
9047 2019-01-16  Tom Tromey  <tom@tromey.com>
9048
9049         * objfiles.h (struct objfile) <psymtabs>: New method.
9050         (class objfile_psymtabs): Remove.
9051         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9052         typedef.
9053         <range>: New method.
9054         (require_partial_symbols): Change return type.
9055         * psymtab.c (require_partial_symbols)
9056         (psym_expand_symtabs_matching): Update.
9057         * mdebugread.c (parse_partial_symbols): Update.
9058         * dbxread.c (dbx_end_psymtab): Update.
9059
9060 2019-01-15  Tom Tromey  <tom@tromey.com>
9061
9062         * symtab.c (lookup_objfile_from_block)
9063         (lookup_symbol_in_objfile_symtabs)
9064         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9065         (find_line_symtab, info_sources_command)
9066         (default_collect_symbol_completion_matches_break_on)
9067         (make_source_files_completion_list): Update.
9068         * symmisc.c (print_objfile_statistics, dump_objfile)
9069         (maintenance_print_symbols, maintenance_info_symtabs)
9070         (maintenance_check_symtabs, maintenance_info_line_tables):
9071         Update.
9072         * source.c (select_source_symtab)
9073         (forget_cached_source_info_for_objfile): Update.
9074         * objfiles.h (class objfile_compunits): Remove.
9075         (struct objfile) <compunits_range>: New typedef.
9076         (compunits): New method.
9077         * objfiles.c (objfile_relocate1): Update.
9078         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9079         * maint.c (count_symtabs_and_blocks): Update.
9080         * linespec.c (iterate_over_all_matching_symtabs): Update.
9081         * cp-support.c (add_symbol_overload_list_qualified): Update.
9082         * coffread.c (coff_symtab_read): Update.
9083         * ada-lang.c (add_nonlocal_symbols)
9084         (ada_collect_symbol_completion_matches)
9085         (ada_add_global_exceptions): Update.
9086
9087 2019-01-15  Tom Tromey  <tom@tromey.com>
9088
9089         * progspace.h (program_space) <objfiles_safe_range>: New
9090         typedef.
9091         <objfiles_safe>: New method.
9092         * objfiles.h (class all_objfiles_safe): Remove.
9093         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9094         * jit.c (jit_inferior_exit_hook): Update.
9095
9096 2019-01-17  Tom Tromey  <tom@tromey.com>
9097
9098         * progspace.h (program_space) <objfiles_range>: New typedef.
9099         <objfiles>: New method.
9100         <objfiles_head>: Rename from objfiles.
9101         (object_files): Update.
9102         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9103         * guile/scm-pretty-print.c
9104         (ppscm_find_pretty_printer_from_objfiles): Update.
9105         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9106         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9107         Update.
9108         * python/py-progspace.c (pspy_get_objfiles): Update.
9109         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9110         Update.
9111         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9112         (objfpy_lookup_objfile_by_build_id): Update.
9113         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9114         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9115         Update.
9116         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9117         (expand_symtab_containing_pc, lookup_objfile_from_block)
9118         (lookup_static_symbol, basic_lookup_transparent_type)
9119         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9120         (find_line_symtab, info_sources_command)
9121         (default_collect_symbol_completion_matches_break_on)
9122         (make_source_files_completion_list, find_main_name): Update.
9123         * symmisc.c (print_symbol_bcache_statistics)
9124         (print_objfile_statistics, maintenance_print_symbols)
9125         (maintenance_print_msymbols, maintenance_print_objfiles)
9126         (maintenance_info_symtabs, maintenance_check_symtabs)
9127         (maintenance_expand_symtabs, maintenance_info_line_tables):
9128         Update.
9129         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9130         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9131         (map_overlay_command, unmap_overlay_command)
9132         (simple_overlay_update, expand_symtabs_matching)
9133         (map_symbol_filenames): Update.
9134         * symfile-debug.c (set_debug_symfile): Update.
9135         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9136         Update.
9137         * source.c (select_source_symtab, forget_cached_source_info):
9138         Update.
9139         * solib.c (solib_read_symbols): Update.
9140         * solib-spu.c (append_ocl_sos): Update.
9141         * psymtab.c (maintenance_print_psymbols)
9142         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9143         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9144         * printcmd.c (info_symbol_command): Update.
9145         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9146         Update.
9147         * objfiles.h (class all_objfiles): Remove.
9148         * objfiles.c (have_partial_symbols, have_full_symbols)
9149         (have_minimal_symbols, qsort_cmp, update_section_map)
9150         (shared_objfile_contains_address_p)
9151         (default_iterate_over_objfiles_in_search_order): Update.
9152         * objc-lang.c (info_selectors_command, info_classes_command)
9153         (find_methods): Update.
9154         * minsyms.c (find_solib_trampoline_target): Update.
9155         * maint.c (maintenance_info_sections)
9156         (maintenance_translate_address, count_symtabs_and_blocks):
9157         Update.
9158         * main.c (captured_main_1): Update.
9159         * linux-thread-db.c (try_thread_db_load_from_pdir)
9160         (has_libpthread): Update.
9161         * linespec.c (iterate_over_all_matching_symtabs)
9162         (search_minsyms_for_name): Update.
9163         * jit.c (jit_find_objf_with_entry_addr): Update.
9164         * hppa-tdep.c (find_unwind_entry)
9165         (hppa_lookup_stub_minimal_symbol): Update.
9166         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9167         Update.
9168         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9169         (elf_gnu_ifunc_resolve_by_got): Update.
9170         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9171         * dwarf-index-write.c (save_gdb_index_command): Update.
9172         * cp-support.c (add_symbol_overload_list_qualified): Update.
9173         * breakpoint.c (create_overlay_event_breakpoint)
9174         (create_longjmp_master_breakpoint)
9175         (create_std_terminate_master_breakpoint)
9176         (create_exception_master_breakpoint): Update.
9177         * blockframe.c (find_pc_partial_function): Update.
9178         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9179         (ada_collect_symbol_completion_matches)
9180         (ada_add_global_exceptions): Update.
9181
9182 2019-01-17  Tom Tromey  <tom@tromey.com>
9183
9184         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9185         declare VEC.
9186         (solib_target_parse_libraries): Change return type.
9187         (library_list_start_segment, library_list_start_section)
9188         (library_list_end_library, library_list_start_library); Update.
9189         (solib_target_free_library_list): Remove.
9190         (solib_target_parse_libraries): Remove cleanup.  Change return
9191         type.
9192         (solib_target_current_sos): Update.
9193
9194 2019-01-17  Tom Tromey  <tromey@bapiya>
9195
9196         * valprint.c: Replace "the the" with "the".
9197         * symtab.c: Replace "the the" with "the".
9198         * solib.c: Replace "the the" with "the".
9199         * solib-dsbt.c: Replace "the the" with "the".
9200         * linespec.c: Replace "the the" with "the".
9201         * dwarf2loc.h: Replace "the the" with "the".
9202         * amd64-windows-tdep.c: Replace "the the" with "the".
9203         * aarch64-tdep.c: Replace "the the" with "the".
9204
9205 2019-01-16  Keith Seitz  <keiths@redhat.com>
9206
9207         PR gdb/23773
9208         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9209         <builder>: Rename to ..
9210         <m_builder>: ... this and make private.
9211         (dwarf2_cu::get_builder): New method.  Change all users of
9212         `builder' to use this method.
9213         (dwarf2_start_symtab): Move to ...
9214         (dwarf2_cu::start_symtab): ... here.  Update all callers
9215         (setup_type_unit_groups): Move to ...
9216         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9217         callers.
9218         (dwarf2_cu::reset_builder): New method.
9219         (process_full_compunit, process_full_type_unit): Use
9220         dwarf2_cu::reset_builder.
9221         (follow_die_offset): Record the ancestor CU if it is different
9222         from the followed DIE's CU.
9223         (follow_die_sig_1): Likewise.
9224
9225 2019-01-15  Tom Tromey  <tom@tromey.com>
9226
9227         * remote.c (class remote_state) <buf>: Now a char_vector.
9228         <buf_size>: Remove.
9229         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9230         parameter.
9231         (remote_target::getpkt_or_notif_sane_1)
9232         (remote_target::getpkt_sane)
9233         (remote_target::getpkt_or_notif_sane): Likewise.
9234         (class remote_target) <putpkt>: New overload.
9235         (remote_target::read_frame): Change type of "buf_p".  Remove
9236         sizeof_p parameter.
9237         (packet_ok): New overload.
9238         (packet_check_result): New overload.
9239         Update all uses.
9240
9241 2019-01-14  Tom Tromey  <tom@tromey.com>
9242
9243         * remote-notif.c (handle_notification, remote_notif_ack)
9244         (remote_notif_parse): Make "buf" const.
9245         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9246         const.
9247         (remote_notif_parse, remote_notif_ack, handle_notification):
9248         Likewise.
9249         * remote.c (remote_notif_stop_parse): Make "buf" const.
9250         (remote_target::remote_parse_stop_reply): Make "buf" const.
9251         (remote_notif_stop_ack): Make "buf" const.
9252
9253 2019-01-14  Tom Tromey  <tom@tromey.com>
9254
9255         * remote.c (remote_console_output): Make parameter const.
9256
9257 2019-01-14  Tom Tromey  <tom@tromey.com>
9258
9259         * target-debug.h (target_debug_print_signals): Constify.
9260         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9261         * procfs.c (procfs_target::pass_signals): Update.
9262         * linux-nat.c (linux_nat_target::pass_signals): Update.
9263         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9264         * target-delegates.c: Rebuild.
9265         * remote.c (remote_target::program_signals): Update.
9266         (remote_target::pass_signals): Update.
9267         * target.c (target_pass_signals): Constify argument.
9268         (target_program_signals): Likewise.
9269         * target.h (struct target_ops) <pass_signals, program_signals>:
9270         Constify argument.
9271         (target_pass_signals, target_program_signals): Constify argument.
9272
9273 2019-01-14  Tom Tromey  <tom@tromey.com>
9274
9275         PR tui/28819:
9276         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9277
9278 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9279
9280         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9281         field.
9282         * rs6000-tdep.c: Include reggroups.h.
9283         (IS_V_ALIAS_PSEUDOREG): Define.
9284         (rs6000_register_name): Return names for the "vX" aliases.
9285         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9286         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9287         aliases.  Call default_register_reggroup_p for all other
9288         pseudo-registers.
9289         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9290         New functions.
9291         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9292         Handle "vX" aliases.
9293         (v_alias_pseudo_register_collect): New function.
9294         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9295         (rs6000_gdbarch_init): Initialize "vX" aliases as
9296         pseudo-registers.  Restore registration of
9297         rs6000_pseudo_register_reggroup_p with
9298         set_tdesc_pseudo_register_reggroup_p.
9299
9300 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9301
9302         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9303         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9304         set_gdbarch_num_pseudo_regs.
9305
9306 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9307
9308         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9309         Remove arg prefixname, add do_set and do_show.
9310         Add member functions set_list and show_list.
9311         * cli/cli-style.c (class cli_style_option): Update accordingly.
9312         (style_set_list): Move to file scope.
9313         (style_show_list): Likewise.
9314         (set_style): Call help_list.
9315         (show_style): Call cmd_show_list.
9316         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9317         Update to use the new macro.
9318
9319 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9320
9321         * ada-lang.c (_initialize_ada_language): Expand the help text
9322         for the "catch exception" command.
9323
9324 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9325
9326         * symtab.c (matching_obj_sections): Initialize obj,
9327         declare it closer to its usage.
9328
9329 2019-01-10  Tom Tromey  <tom@tromey.com>
9330
9331         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9332         (basic_inf_threads_range): Remove.
9333         (inf_threads_range, inf_non_exited_threads_range)
9334         (safe_inf_threads_range): Use next_adapter.
9335
9336 2019-01-10  Keith Seitz  <keiths@redhat.com>
9337
9338         PR gdb/23712
9339         PR symtab/23010
9340         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9341         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9342
9343 2019-01-10  Keith Seitz  <keiths@redhat.com>
9344
9345         PR gdb/23712
9346         PR symtab/23010
9347         * dictionary.c (pending_to_vector): Remove.
9348         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9349         Remove _1 suffix, replacing functions of the same name.  Update
9350         all callers.
9351         (dict_create_hashed, dict_create_hashed_expandable)
9352         (dict_create_linear, dict_create_linear_expandable, dict_free)
9353         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9354         Make functions static.
9355
9356 2019-01-10  Keith Seitz  <keiths@redhat.com>
9357
9358         PR gdb/23712
9359         PR symtab/23010
9360         * dictionary.h (struct dictionary): Replace declaration with
9361         multidictionary.
9362         (dict_create_hashed, dict_create_hashed_expandable)
9363         (dict_create_linear, dict_create_linear_expandable)
9364         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9365         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9366         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9367         taking multidictionary argument.
9368         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9369         * block.h (struct block) <dict>: Change to multidictionary
9370         and rename `multidict'.
9371         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9372         symmisc.c: Update all dictionary references to multidictionary.
9373
9374 2019-01-10  Keith Seitz  <keiths@redhat.com>
9375
9376         PR gdb/23712
9377         PR symtab/23010
9378         * dictionary.c: Include unordered_map.
9379         (pending_to_vector): New function.
9380         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9381         Rewrite the non-"_1" functions to take vector instead
9382         of linked list.
9383         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9384         "new" _1 versions of the same name.
9385         (multidictionary): Define.
9386         (std::hash<enum language): New definition.
9387         (collate_pending_symbols_by_language, mdict_create_hashed)
9388         (mdict_create_hashed_expandable, mdict_create_linear)
9389         (mdict_create_linear_expandable, mdict_free)
9390         (find_language_dictionary, create_new_language_dictionary)
9391         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9392         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9393         (mdict_size, mdict_empty): New functions.
9394         * dictionary.h (mdict_iterator): Define.
9395
9396 2019-01-10  Pedro Alves  <palves@redhat.com>
9397
9398         * breakpoint.c (read_uploaded_action)
9399         (create_tracepoint_from_upload): Adjust to use
9400         gdb::unique_xmalloc_ptr.
9401         * ctf.c (ctf_write_uploaded_tp):
9402         (SET_ARRAY_FIELD): Use emplace_back.
9403         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9404         * tracefile-tfile.c (tfile_write_uploaded_tp):
9405         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9406         gdb::unique_xmalloc_ptr.
9407         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9408         at_string, cond_string, cmd_strings>: Replace char pointers
9409         with gdb::unique_xmalloc_ptr.
9410
9411 2019-01-10  Pedro Alves  <palves@redhat.com>
9412
9413         * solib-target.c (library_list_start_library): Don't xstrdup name.
9414
9415 2019-01-10  Pedro Alves  <palves@redhat.com>
9416
9417         * mdebugread.c (parse_partial_symbols): Use
9418         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9419
9420 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9421
9422         * linux-fork.c (scoped_switch_fork_info)
9423         <~scoped_switch_fork_info>: Fix incorrect variable name.
9424
9425 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9426
9427         * linux-fork.c (scoped_switch_fork_info)
9428         <scoped_switch_fork_info>: Make explicit.
9429         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9430
9431 2019-01-10  Tom Tromey  <tom@tromey.com>
9432
9433         * objfiles.h (objfile::reset_psymtabs): Update.
9434         * objfiles.c (objfile::objfile): Update.
9435         * psymtab.h (psymtab_storage::obstack): Update.
9436         (psymtab_storage::m_obstack): Use gdb::optional.
9437         (class psymtab_storage): Update comment.  Remove objfile
9438         parameter.
9439         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9440
9441 2019-01-10  Tom Tromey  <tom@tromey.com>
9442
9443         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9444         <free_psymtabs>: Now private.
9445         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9446         (allocate_psymtab): Use new method.
9447
9448 2019-01-10  Tom Tromey  <tom@tromey.com>
9449
9450         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9451         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9452         * mdebugread.c (parse_partial_symbols): Use
9453         allocate_dependencies.
9454         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9455         allocate_dependencies.
9456         (process_psymtab_comp_unit_reader)
9457         (build_type_psymtab_dependencies): Likewise.
9458         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9459
9460 2019-01-10  Tom Tromey  <tom@tromey.com>
9461
9462         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9463         PSYMBOL_SET_LANGUAGE.
9464         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9465
9466 2019-01-10  Tom Tromey  <tom@tromey.com>
9467
9468         * psymtab.h (psymtab_storage::obstack): New method.
9469         <m_obstack>: Rename from obstack; now private.
9470         * psymtab.c (psymtab_storage): Update.
9471         * dwarf2read.c (create_addrmap_from_index)
9472         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9473         Update.
9474
9475 2019-01-10  Tom Tromey  <tom@tromey.com>
9476
9477         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9478         * objfiles.h (objfile::reset_psymtabs): New method.
9479
9480 2019-01-10  Tom Tromey  <tom@tromey.com>
9481
9482         * symmisc.c (print_symbol_bcache_statistics): Update.
9483         (print_objfile_statistics): Update.
9484         * symfile.c (reread_symbols): Update.
9485         * psymtab.h (class psymtab_storage): New.
9486         * psymtab.c (psymtab_storage): New constructor.
9487         (~psymtab_storage): New destructor.
9488         (require_partial_symbols): Update.
9489         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9490         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9491         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9492         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9493         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9494         (start_psymtab_common, end_psymtab_common)
9495         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9496         (allocate_psymtab): Update.
9497         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9498         Update.
9499         (dump_psymtab_addrmap, maintenance_print_psymbols)
9500         (maintenance_check_psymtabs): Update.
9501         (class objfile_psymtabs): Move to objfiles.h.
9502         * psympriv.h (discard_psymtab): Now inline.
9503         (psymtab_discarder::psymtab_discarder): Update.
9504         (psymtab_discarder::~psymtab_discarder): Update.
9505         (ALL_OBJFILE_PSYMTABS): Rewrite.
9506         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9507         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9508         Remove fields.
9509         <partial_symtabs>: New field.
9510         (class objfile_psymtabs): Move from psymtab.h.  Update.
9511         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9512         psymbol_cache.
9513         (objfile::~objfile): Don't destroy psymbol_cache.
9514         * mdebugread.c (parse_partial_symbols): Update.
9515         * dwarf2read.c (create_addrmap_from_index)
9516         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9517         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9518         (add_partial_subprogram, dwarf2_ranges_read): Update.
9519         * dwarf-index-write.c (write_address_map)
9520         (write_one_signatured_type, recursively_write_psymbols)
9521         (class debug_names, class debug_names, write_psymtabs_to_index):
9522         Update.
9523
9524 2019-01-10  Tom Tromey  <tom@tromey.com>
9525
9526         * symtab.h (SYMBOL_SET_NAMES): Update.
9527         (symbol_set_names): Update.
9528         (MSYMBOL_SET_NAMES): Update.
9529         * symtab.c (symbol_set_names): Change argument to be an
9530         objfile_per_bfd_storage.
9531         * psymtab.c (add_psymbol_to_bcache): Update.
9532         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9533
9534 2019-01-10  Tom Tromey  <tom@tromey.com>
9535
9536         * symtab.c (create_demangled_names_hash): Change argument to be an
9537         objfile_per_bfd_storage.
9538         (symbol_set_names): Update.
9539
9540 2019-01-10  Tom Tromey  <tom@tromey.com>
9541
9542         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9543         init_psymbol_list.
9544         * psymtab.c (init_psymbol_list): Do nothing if already called.
9545         * psympriv.h (init_psymbol_list): Add comment.
9546         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9547         init_psymbol_list.
9548         * dbxread.c (dbx_symfile_read): Unconditionally call
9549         init_psymbol_list.
9550
9551 2019-01-10  Tom Tromey  <tom@tromey.com>
9552
9553         * xcoffread.c (scan_xcoff_symtab): Update.
9554         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9555         "where".
9556         * mdebugread.c (parse_partial_symbols)
9557         (handle_psymbol_enumerators): Update.
9558         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9559         * dbxread.c (read_dbx_symtab): Update.
9560         * psympriv.h (psymbol_placement): New enum.
9561         (add_psymbol_to_list): Update.
9562
9563 2019-01-10  Tom Tromey  <tom@tromey.com>
9564
9565         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9566         static_psymbols parameters.
9567         (scan_xcoff_symtab): Update.
9568         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9569         static_psymbols parameters.
9570         * psympriv.h (start_psymtab_common): Update.
9571         * mdebugread.c (parse_partial_symbols): Update.
9572         * dwarf2read.c (create_partial_symtab): Update.
9573         * dbxread.c (read_dbx_symtab): Update.
9574         (start_psymtab): Remove global_psymbols and static_psymbols
9575         parameters.
9576
9577 2019-01-10  Tom Tromey  <tom@tromey.com>
9578
9579         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9580         * psymtab.c (allocate_psymtab): Add comment.
9581         * psympriv.h (allocate_psymtab): Add comment.
9582         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9583         initializations.
9584         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9585
9586 2019-01-10  Tom Tromey  <tom@tromey.com>
9587
9588         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9589         Don't declare.
9590         * mipsread.c: Include mdebugread.h.
9591         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9592         Declare.
9593         * elfread.c: Include mdebugread.h.
9594
9595 2019-01-09  Tom Tromey  <tom@tromey.com>
9596
9597         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9598         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9599         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9600         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9601         (psym_lookup_symbol, psym_find_last_source_symtab)
9602         (psym_forget_cached_source_info, psym_print_stats)
9603         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9604         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9605         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9606         (psym_find_compunit_symtab_by_address)
9607         (maintenance_print_psymbols, maintenance_info_psymtabs)
9608         (maintenance_check_psymtabs): Use ranged for.
9609         * psymtab.h (class objfile_psymtabs): New.
9610         (require_partial_symbols): Return objfile_psymtabs.
9611         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9612
9613 2019-01-09  Tom Tromey  <tom@tromey.com>
9614
9615         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9616         (find_pc_mapped_section, list_overlays_command)
9617         (map_overlay_command, unmap_overlay_command)
9618         (simple_overlay_update): Use all_objfiles.
9619         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9620         * printcmd.c (info_symbol_command): Use all_objfiles.
9621         * objfiles.h (ALL_OBJSECTIONS): Remove.
9622         * maint.c (maintenance_translate_address): Use all_objfiles.
9623         * gcore.c (gcore_create_callback): Use all_objfiles.
9624         (objfile_find_memory_regions): Likewise.
9625
9626 2019-01-09  Tom Tromey  <tom@tromey.com>
9627
9628         * symtab.c (find_line_symtab, info_sources_command)
9629         (make_source_files_completion_list): Use objfile_compunits.
9630         * source.c (select_source_symtab): Use objfile_compunits.
9631         * objfiles.h (struct objfile): Update comment.
9632         (ALL_OBJFILES): Remove.
9633         (ALL_FILETABS): Remove.
9634         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9635         objfile_compunits.
9636
9637 2019-01-09  Tom Tromey  <tom@tromey.com>
9638
9639         * symmisc.c (print_objfile_statistics, dump_objfile)
9640         (maintenance_print_symbols): Use compunit_filetabs.
9641         * source.c (forget_cached_source_info_for_objfile): Use
9642         compunit_filetabs.
9643         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9644         (ALL_FILETABS): Use compunit_filetabs.
9645         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9646         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9647
9648 2019-01-09  Tom Tromey  <tom@tromey.com>
9649
9650         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9651         (compunit_filetabs): New.
9652         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9653         compunit_filetabs.
9654         (info_sources_command, make_source_files_completion_list): Remove
9655         declaration.
9656         * symmisc.c (print_objfile_statistics, dump_objfile)
9657         (maintenance_print_symbols): Remove declaration.
9658         (maintenance_info_symtabs): Use compunit_filetabs.
9659         (maintenance_info_line_tables): Likewise.
9660         * source.c (select_source_symtab): Change local variable name.
9661         (forget_cached_source_info_for_objfile): Remove declaration.
9662         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9663         * objfiles.c (objfile_relocate1): Remove declaration.
9664         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9665         declaration.
9666         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9667         * coffread.c (coff_symtab_read): Remove declaration.
9668         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9669         compunit_filetabs.
9670
9671 2019-01-09  Tom Tromey  <tom@tromey.com>
9672
9673         * symtab.c (lookup_objfile_from_block)
9674         (find_pc_sect_compunit_symtab, search_symbols)
9675         (default_collect_symbol_completion_matches_break_on): Use
9676         objfile_compunits.
9677         * objfiles.h (ALL_COMPUNITS): Remove.
9678         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9679         * cp-support.c (add_symbol_overload_list_qualified): Use
9680         objfile_compunits.
9681         * ada-lang.c (ada_collect_symbol_completion_matches)
9682         (ada_add_global_exceptions): Use objfile_compunits.
9683
9684 2019-01-09  Tom Tromey  <tom@tromey.com>
9685
9686         * source.c (select_source_symtab)
9687         (forget_cached_source_info_for_objfile): Remove declaration.
9688         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9689         declaration.
9690         * maint.c (count_symtabs_and_blocks): Remove declaration.
9691         * cp-support.c (add_symbol_overload_list_qualified): Remove
9692         declaration.
9693         * coffread.c (coff_symtab_read): Remove declaration.
9694         * symtab.c (lookup_symbol_in_objfile_symtabs)
9695         (basic_lookup_transparent_type_1): Use objfile_compunits.
9696         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9697         (info_sources_command, search_symbols)
9698         (default_collect_symbol_completion_matches_break_on)
9699         (make_source_files_completion_list): Remove declaration.
9700         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9701         (ada_collect_symbol_completion_matches)
9702         (ada_add_global_exceptions): Remove declaration.
9703         * linespec.c (iterate_over_all_matching_symtabs): Use
9704         objfile_compunits.
9705         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9706         (class objfile_compunits): New.
9707         (ALL_COMPUNITS): Use objfile_compunits.
9708         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9709         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9710         objfile_compunits.
9711         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9712
9713 2019-01-09  Tom Tromey  <tom@tromey.com>
9714
9715         * symtab.c (search_symbols)
9716         (default_collect_symbol_completion_matches_break_on): Use
9717         objfile_msymbols.
9718         * ada-lang.c (ada_lookup_simple_minsym)
9719         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9720         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9721         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9722         objfile_msymbols.
9723         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9724         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9725         * objc-lang.c (find_methods): Use objfile_msymbols.
9726         (info_selectors_command, info_classes_command): Likewise.
9727         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9728         * objfiles.h (class objfile_msymbols): New.
9729         (ALL_OBJFILE_MSYMBOLS): Remove.
9730         (ALL_MSYMBOLS): Remove.
9731
9732 2019-01-09  Tom Tromey  <tom@tromey.com>
9733
9734         * common/next-iterator.h (next_adapter): Add Iterator template
9735         parameter.
9736         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9737         (class all_objfiles_safe): New.
9738         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9739         * objfiles.c (put_objfile_before): Update comment.
9740         (add_separate_debug_objfile): Likewise.
9741         (free_all_objfiles): Use all_objfiles_safe.
9742         (objfile_purge_solibs): Likewise.
9743
9744 2019-01-09  Tom Tromey  <tom@tromey.com>
9745
9746         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9747         (expand_symtab_containing_pc, lookup_static_symbol)
9748         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9749         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9750         all_objfiles.
9751         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9752         * breakpoint.c (create_overlay_event_breakpoint)
9753         (create_longjmp_master_breakpoint)
9754         (create_std_terminate_master_breakpoint)
9755         (create_exception_master_breakpoint): Use all_objfiles.
9756         * linux-thread-db.c (try_thread_db_load_from_pdir)
9757         (has_libpthread): Use all_objfiles.
9758         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9759         * linespec.c (iterate_over_all_matching_symtabs)
9760         (search_minsyms_for_name): Use all_objfiles.
9761         * maint.c (maintenance_info_sections): Use all_objfiles.
9762         * main.c (captured_main_1): Use all_objfiles.
9763         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9764         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9765         * guile/scm-pretty-print.c
9766         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9767         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9768         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9769         (maintenance_print_msymbols): Use all_objfiles.
9770         * source.c (select_source_symtab): Use all_objfiles.
9771         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9772         * symfile.c (remove_symbol_file_command)
9773         (expand_symtabs_matching, map_symbol_filenames): Use
9774         all_objfiles.
9775         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9776         all_objfiles.
9777         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9778         * objc-lang.c (find_methods): Use all_objfiles.
9779         * objfiles.c (have_partial_symbols, have_full_symbols)
9780         (have_minimal_symbols, qsort_cmp)
9781         (default_iterate_over_objfiles_in_search_order): Use
9782         all_objfiles.
9783         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9784         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9785         (maintenance_check_psymtabs): Use all_objfiles.
9786         (ALL_PSYMTABS): Remove.
9787         * compile/compile-object-run.c (do_module_cleanup): Use
9788         all_objfiles.
9789         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9790         * cp-support.c (add_symbol_overload_list_qualified): Use
9791         all_objfiles.
9792         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9793         Use all_objfiles.
9794         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9795         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9796         all_objfiles.
9797         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9798         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9799         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9800         Uses all_objfiles.
9801         * solib.c (solib_read_symbols): Use all_objfiles
9802
9803 2019-01-09  Tom Tromey  <tom@tromey.com>
9804
9805         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9806         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9807         all_objfiles.
9808         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9809         * symmisc.c (print_symbol_bcache_statistics)
9810         (print_objfile_statistics, maintenance_print_objfiles)
9811         (maintenance_info_symtabs, maintenance_check_symtabs)
9812         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9813         all_objfiles.
9814         * source.c (forget_cached_source_info): Use all_objfiles.
9815         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9816         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9817         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9818         * objfiles.c (update_section_map): Use all_objfiles.
9819         (shared_objfile_contains_address_p): Likewise.
9820         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9821         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9822
9823 2019-01-09  Tom Tromey  <tom@tromey.com>
9824
9825         * common/next-iterator.h: New file.
9826         * objfiles.h (class all_objfiles): New.
9827         (struct objfile_iterator): New.
9828
9829 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9830
9831         * NEWS: Move the description of the changed "frame", "select-frame",
9832          and "info frame" commands to the Changed commands section.
9833
9834 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9835
9836         * gdbtypes.c (check_stub_method_group): Remove handling of old
9837         mangling schemes.
9838         * linespec.c (find_methods): Likewise.
9839         * stabsread.c (read_member_functions): Likewise.
9840         * valops.c (search_struct_method): Likewise.
9841         (value_struct_elt_for_reference): Likewise.
9842         * NEWS: Mention this change.
9843
9844 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9845
9846         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9847         print_source_lines.
9848         * source.c (print_source_lines_base): Update line number check.
9849         (print_source_lines): New function.
9850         (source_lines_range::source_lines_range): New function.
9851         * source.h (class source_lines_range): New class.
9852         (print_source_lines): New declaration.
9853
9854 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9855
9856         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9857
9858 2019-01-08  Tom Tromey  <tom@tromey.com>
9859             Simon Marchi  <simon.marchi@ericsson.com>
9860
9861         PR gdb/24060
9862         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9863         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9864         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9865         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9866         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9867         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9868
9869 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9870
9871         * source.c (select_source_symtab): Move header comment to
9872         declaration in source.h.
9873         (forget_cached_source_info_for_objfile): Likewise.
9874         (forget_cached_source_info): Likewise.
9875         (identify_source_line): Likewise.
9876         * source.h (identify_source_line): Move declaration from symtab.h
9877         and add comment from source.c
9878         (print_source_lines): Likewise.
9879         (forget_cached_source_info_for_objfile): Likewise.
9880         (forget_cached_source_info): Likewise.
9881         (select_source_symtab): Likewise.
9882         (enum print_source_lines_flag): Move definition from symtab.h.
9883         * symtab.h (identify_source_line): Move declaration to source.h.
9884         (print_source_lines): Likewise.
9885         (forget_cached_source_info_for_objfile): Likewise.
9886         (forget_cached_source_info): Likewise.
9887         (select_source_symtab): Likewise.
9888         (enum print_source_lines_flag): Move definition to source.h.
9889         * tui/tui-hooks.c: Add 'source.h' include.
9890
9891 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9892
9893         * source.c (print_source_lines_base): Handle requests to print
9894         reverse line number sequences, and guard against empty lines
9895         string.
9896
9897 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9898
9899         * source.c (print_source_lines_base): Fix skip of '\r' if next
9900         character is '\n'.
9901
9902 2019-01-06  Tom Tromey  <tom@tromey.com>
9903
9904         * c-exp.y (struct c_parse_state) <macro_original_text,
9905         expansion_obstack>: New member.
9906         (macro_original_text, expansion_obstack): Remove globals.
9907         (scan_macro_expansion, scanning_macro_expansion)
9908         (finished_macro_expansion): Update.
9909         (scan_macro_cleanup): Remove.
9910         (yylex, c_parse): Update.
9911
9912 2019-01-06  Tom Tromey  <tom@tromey.com>
9913
9914         * c-exp.y (struct c_parse_state) <strings>: New member.
9915         (operator_stoken): Update.
9916
9917 2019-01-06  Tom Tromey  <tom@tromey.com>
9918
9919         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9920         (union type_stack_elt) <typelist_val>: Now a pointer to
9921         std::vector.
9922         (type_stack_cleanup): Don't declare.
9923         (push_typelist): Update.
9924         * parse.c (pop_typelist): Return a std::vector.
9925         (push_typelist): Take a std::vector.
9926         (follow_types): Update.  Do not free args.
9927         (type_stack_cleanup): Remove.
9928         * c-exp.y (struct c_parse_state): New.
9929         (cpstate): New global.
9930         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9931         (nonempty_typelist): Update.
9932         (func_mod): Create a new vector.
9933         (c_parse): Create a c_parse_state.
9934         (check_parameter_typelist): Do not delete params.
9935         (function_method): Update.  Do not delete type_list.
9936
9937 2019-01-06  Tom Tromey  <tom@tromey.com>
9938
9939         PR gdb/28155:
9940         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9941         check_typedef.
9942         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9943         (print_return_value): Likewise.
9944
9945 2019-01-05  Tom Tromey  <tom@tromey.com>
9946
9947         * contrib/cleanup_check.py: Remove.
9948         * contrib/gcc-with-excheck: Remove.
9949         * contrib/exsummary.py: Remove.
9950         * contrib/excheck.py: Remove.
9951
9952 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9953
9954         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9955         NULL. Initialize tpprev to NULL instead of assigning it
9956         to NULL on the next statement.
9957         * windows-nat.c (windows_delete_thread): Remove check for
9958         main_thread_id before printing thread exit notifications.
9959         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9960         Remove thread ID check against main_thread_id.
9961         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9962         windows_delete_thread.
9963         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9964
9965 2019-01-04  Tom Tromey  <tom@tromey.com>
9966
9967         * compile/compile.c (_initialize_compile): Use upper case for
9968         metasyntactic variables.
9969         * symmisc.c (_initialize_symmisc): Use upper case for
9970         metasyntactic variables.
9971         * psymtab.c (_initialize_psymtab): Use upper case for
9972         metasyntactic variables.
9973         * demangle.c (demangle_command): Use upper case for metasyntactic
9974         variables.
9975         (_initialize_demangler): Likewise.
9976         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9977         variables.
9978
9979 2019-01-03  Tom Tromey  <tom@tromey.com>
9980
9981         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9982
9983 2019-01-03  Tom Tromey  <tom@tromey.com>
9984
9985         * python/py-symtab.c (salpy_str): Update.
9986         (struct salpy_sal_object) <symtab>: Now a PyObject.
9987         (salpy_dealloc): Update.
9988         (del_objfile_sal): Use gdbpy_ref.
9989
9990 2019-01-03  Tom Tromey  <tom@tromey.com>
9991
9992         * python/py-type.c (convert_field): Use new_reference.  Return
9993         gdbpy_ref.
9994         (make_fielditem): Return gdbpy_ref.
9995         (typy_fields): Update.
9996         (typy_getitem): Update.
9997         (field_name): Return gdbpy_ref.  Use new_reference.
9998         (typy_iterator_iternext): Update.
9999
10000 2019-01-03  Tom Tromey  <tom@tromey.com>
10001
10002         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10003
10004 2019-01-03  Tom Tromey  <tom@tromey.com>
10005
10006         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10007         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10008         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10009         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10010         (pspy_set_type_printers): Likewise.
10011         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10012         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10013         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10014         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10015         (objfpy_set_type_printers): Likewise.
10016
10017 2019-01-03  Tom Tromey  <tom@tromey.com>
10018
10019         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10020         (gdbpy_print_stack): Use gdbpy_err_fetch.
10021         * python/python-internal.h (class gdbpy_err_fetch): New class.
10022         (class gdbpy_enter) <m_error_type, m_error_value,
10023         m_error_traceback>: Remove.
10024         <m_error>: New member.
10025         (gdbpy_exception_to_string): Don't declare.
10026         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10027         * python/py-value.c (convert_value_from_python): Use
10028         gdbpy_err_fetch.
10029         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10030         gdbpy_exception_to_string.
10031         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10032         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10033         gdbpy_err_fetch.
10034
10035 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10036
10037         * linux-nat.c (delete_lwp_cleanup): Delete.
10038         (struct lwp_deleter): New struct.
10039         (lwp_info_up): New typedef.
10040         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10041         lwp_info_up.
10042
10043 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10044
10045         * linux-fork.c (class scoped_switch_fork_info): New class.
10046         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10047
10048 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10049
10050         * valops.c (find_overload_match): Remove use of null_cleanup, and
10051         calls to do_cleanups.
10052
10053 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10054
10055         * compile/compile-cplus-types.c
10056         (compile_cplus_instance::decl_name): Handle changes to
10057         cp_func_name.
10058         * cp-support.c (cp_func_name): Update header comment, update
10059         return type.
10060         * cp-support.h (cp_func_name): Update return type in declaration.
10061         * valops.c (find_overload_match): Move temp_func local to top
10062         level of function and change its type.  Use temp_func to hold and
10063         delete temporary string obtained from cp_func_name.
10064
10065 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10066
10067         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10068         gdb::char_vector, remove cleanup, and update uses of `msg`.
10069
10070 2019-01-03  Jim Wilson  <jimw@sifive.com>
10071
10072         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10073
10074 2019-01-02  Tom Tromey  <tom@tromey.com>
10075
10076         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10077         (tdesc_parse_xml): Remove cleanups.
10078         * target-descriptions.h (make_cleanup_free_target_description):
10079         Don't declare.
10080         (target_desc_deleter): New struct.
10081         (target_desc_up): New typedef.
10082         * target-descriptions.c (target_desc_deleter::operator()): Rename
10083         from free_target_description.
10084         (make_cleanup_free_target_description): Remove.
10085
10086 2019-01-02  Tom Tromey  <tom@tromey.com>
10087
10088         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10089         constructor, destructor.
10090         (linespec_parser): Remove typedef.
10091         (~linespec_parser): Rename from linespec_parser_delete.
10092         (linespec_lex_to_end, linespec_complete_label)
10093         (linespec_complete): Update.
10094         (decode_line_full): Remove cleanups.
10095         (decode_line_1): Update.
10096
10097 2019-01-02  Tom Tromey  <tom@tromey.com>
10098
10099         * python/python-internal.h (inferior_to_inferior_object): Change
10100         return type.
10101         * python/py-exitedevent.c (create_exited_event_object): Update.
10102         * python/py-inferior.c (inferior_to_inferior_object): Return
10103         gdbpy_ref.
10104         (python_new_inferior, python_inferior_deleted)
10105         (thread_to_thread_object, delete_thread_object)
10106         (build_inferior_list, gdbpy_selected_inferior): Update.
10107         * python/py-infthread.c (create_thread_object): Update.  Also fail
10108         if inferior_to_inferior_object fails.
10109
10110 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10111
10112         * inferior.h (class inferior) <displaced_step_state>: New field.
10113         * infrun.h (struct displaced_step_state): Move here from
10114         infrun.c.  Initialize fields, add constructor.
10115         <inf>: Remove field.
10116         <reset>: New method.
10117         * infrun.c (struct displaced_step_inferior_state): Move to
10118         infrun.h.
10119         (displaced_step_inferior_states): Remove.
10120         (get_displaced_stepping_state): Adust.
10121         (displaced_step_in_progress_any_inferior): Adjust.
10122         (displaced_step_in_progress_thread): Adjust.
10123         (displaced_step_in_progress): Adjust.
10124         (add_displaced_stepping_state): Remove.
10125         (get_displaced_step_closure_by_addr): Adjust.
10126         (remove_displaced_stepping_state): Remove.
10127         (infrun_inferior_exit): Call displaced_step_state.reset.
10128         (use_displaced_stepping): Don't check for NULL.
10129         (displaced_step_prepare_throw): Call
10130         get_displaced_stepping_state.
10131         (displaced_step_fixup): Don't check for NULL.
10132         (prepare_for_detach): Don't check for NULL.
10133
10134 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10135
10136         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10137          in case of call that did not complete.
10138
10139 2019-01-02  Andrey Utkin  <autkin@undo.io>
10140
10141         * symfile.c (find_separate_debug_file): Fix search of debug files for
10142         remote debuggee.
10143
10144 2019-01-02  Tom Tromey  <tom@tromey.com>
10145
10146         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10147         indentation.
10148         * python/py-frame.c (frapy_older): Remove cast.
10149         (frapy_newer): Likewise.
10150         * python/py-breakpoint.c (local_setattro): Remove cast.
10151         * python/py-arch.c (archpy_name): Remove local variable.
10152         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10153
10154 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10155
10156         * unittests/basic_string_view/element_access/char/empty.cc:
10157         Fix year range in copyright header.
10158
10159 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10160
10161         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10162         Delete.
10163         <operator==>: Update with for removed field.
10164         <hash>: Likewise.
10165         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10166         <isa_features>: ...this.
10167         <abi_features>: New field.
10168         (riscv_isa_flen): Update comment.
10169         (riscv_abi_xlen): New declaration.
10170         (riscv_abi_flen): New declaration.
10171         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10172         isa_features.
10173         (riscv_abi_xlen): New function.
10174         (riscv_isa_flen): Update to get answer from isa_features.
10175         (riscv_abi_flen): New function.
10176         (riscv_has_fp_abi): Update to get answer from abi_features.
10177         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10178         xlen and flen.
10179         (riscv_call_info) <xlen, flen>: Update comment.
10180         (riscv_call_arg_struct): Remove invalid assertions
10181         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10182         is removed.
10183         (riscv_gdbarch_init): Gather isa features and abi features
10184         separately, ensure both match on the gdbarch when reusing an old
10185         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10186         a target with 64-bit float hardware.
10187
10188 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10189
10190         * source.c (search_command_helper): Stop reverse search
10191         when line 1 has been searched.
10192
10193 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10194
10195         * record-full.c (record_full_base_target::close): Rewrite
10196         record_full_core_buf_list free logic.
10197
10198 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10199
10200         * break-catch-syscall.c (print_one_catch_syscall): xfree
10201         the last text.
10202
10203 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10204
10205         * top.c (print_gdb_version): Update Copyright year in version
10206         message.
10207
10208 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10209
10210         Update copyright year range in all GDB files.
10211
10212 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10213
10214         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10215
10216 For older changes see ChangeLog-2018.
10217 \f
10218 Local Variables:
10219 mode: change-log
10220 left-margin: 8
10221 fill-column: 74
10222 version-control: never
10223 coding: utf-8
10224 End:
10225