gdb/ChangeLog

   1 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
   2
   3         * python/py-infthread.c (thpy_thread_handle): New function.
   4         (thread_object_methods): Register thpy_thread_handle.
   5
   6 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
   7
   8         * gdbthread.h (thread_to_thread_handle): Declare.
   9         * thread.c (gdbtypes.h): Include.
  10         (thread_to_thread_handle): New function.
  11
  12         * target.h (struct target_ops): Add thread_info_to_thread_handle.
  13         (target_thread_info_to_thread_handle): Declare.
  14         * target.c (target_thread_info_to_thread_handle): New function.
  15         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
  16         * target-delegates.c: Regenerate.
  17
  18         * linux-thread-db.c (class thread_db_target): Add method
  19         thread_info_to_thread_handle.
  20         (thread_db_target::thread_info_to_thread_handle): Define.
  21         * remote.c (class remote_target): Add new method
  22         thread_info_to_thread_handle.
  23         (remote_target::thread_info_to_thread_handle): Define.
  24
  25 2019-04-08  Pedro Alves  <palves@redhat.com>
  26
  27         * common/common-exceptions.c (throw_exception): Don't create
  28         named object to throw; throw directly.
  29         (throw_it): Likewise.  Don't initialize gdb_exception::message
  30         here, with new; pass FMT and AP to the ctor instead.
  31         * common/common-exceptions.h: Include <string>.
  32         (gdb_exception::gdb_exception(enum return_reason, enum errors,
  33         const char *, va_list)): New ctor.  Use std::make_shared.
  34         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
  35         errors)): Delete.
  36         (gdb_exception_error::gdb_exception_error(enum errors, const char
  37         *, va_list)): New.
  38         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
  39         Add assertion.
  40         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
  41         errors)): Delete.
  42         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
  43         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
  44         Add assertion.
  45
  46 2019-04-08  Tom Tromey  <tom@tromey.com>
  47
  48         * valops.c (value_rtti_indirect_type): Replace throw_exception
  49         with throw.
  50         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
  51         with throw.
  52         * thread.c (thr_try_catch_cmd): Replace throw_exception with
  53         throw.
  54         * target.c (target_translate_tls_address): Replace throw_exception
  55         with throw.
  56         * stack.c (frame_apply_command_count): Replace throw_exception
  57         with throw.
  58         * solib-spu.c (append_ocl_sos): Replace throw_exception with
  59         throw.
  60         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
  61         with throw.
  62         * rs6000-tdep.c (rs6000_frame_cache)
  63         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
  64         * remote.c: Replace throw_exception with throw.
  65         * record-full.c (record_full_message, record_full_wait_1)
  66         (record_full_restore): Replace throw_exception with throw.
  67         * record-btrace.c:
  68         (get_thread_current_frame_id, record_btrace_start_replaying)
  69         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
  70         (cmd_record_btrace_start): Replace throw_exception with throw.
  71         * parse.c (parse_exp_in_context_1): Replace throw_exception with
  72         throw.
  73         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
  74         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
  75         * linespec.c:
  76         (find_linespec_symbols): Replace throw_exception with throw.
  77         * infrun.c (displaced_step_prepare, resume): Replace
  78         throw_exception with throw.
  79         * infcmd.c (post_create_inferior): Replace throw_exception with
  80         throw.
  81         * inf-loop.c (inferior_event_handler): Replace throw_exception
  82         with throw.
  83         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
  84         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
  85         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
  86         (get_prev_frame_always, get_frame_pc_if_available)
  87         (get_frame_address_in_block_if_available, get_frame_language):
  88         Replace throw_exception with throw.
  89         * frame-unwind.c (frame_unwind_try_unwinder): Replace
  90         throw_exception with throw.
  91         * eval.c (fetch_subexp_value, evaluate_var_value)
  92         (evaluate_funcall, evaluate_subexp_standard): Replace
  93         throw_exception with throw.
  94         * dwarf2loc.c (call_site_find_chain)
  95         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
  96         Replace throw_exception with throw.
  97         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
  98         with throw.
  99         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
 100         throw.
 101         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
 102         * completer.c (complete_line_internal): Replace throw_exception
 103         with throw.
 104         * compile/compile-object-run.c (compile_object_run): Replace
 105         throw_exception with throw.
 106         * cli/cli-script.c (process_next_line): Replace throw_exception
 107         with throw.
 108         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
 109         (btrace_enable, btrace_maint_update_pt_packets): Replace
 110         throw_exception with throw.
 111         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
 112         throw_exception with throw.
 113         * break-catch-throw.c (re_set_exception_catchpoint): Replace
 114         throw_exception with throw.
 115         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
 116         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
 117         * aarch64-tdep.c (aarch64_make_prologue_cache)
 118         (aarch64_make_stub_cache): Replace throw_exception with throw.
 119
 120 2019-04-08  Tom Tromey  <tom@tromey.com>
 121
 122         * common/common-exceptions.c (throw_exception): Rename from
 123         throw_exception_cxx.  Remove old copy.  Make argument const.
 124         (throw_it): Create and throw exception objects directly.
 125         * common/common-exceptions.h (throw_exception): Make argument
 126         const.
 127         (struct gdb_exception_error): Add constructor.
 128         (struct gdb_exception_quit): Add constructor.
 129
 130 2019-04-08  Tom Tromey  <tom@tromey.com>
 131
 132         * common/common-exceptions.h (exception_rethrow): Don't declare.
 133         (TRY_SJLJ): Update comment.
 134         (TRY, CATCH, END_CATCH): Remove.
 135         * common/common-exceptions.c (exception_rethrow): Remove.
 136
 137 2019-04-08  Tom Tromey  <tom@tromey.com>
 138
 139         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
 140         Remove.
 141         (gdb_exception_error): Rename from
 142         gdb_exception_RETURN_MASK_ERROR.
 143         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
 144         (gdb_quit_bad_alloc): Update.
 145         * aarch64-tdep.c: Update.
 146         * ada-lang.c: Update.
 147         * ada-typeprint.c: Update.
 148         * ada-valprint.c: Update.
 149         * amd64-tdep.c: Update.
 150         * arch-utils.c: Update.
 151         * break-catch-throw.c: Update.
 152         * breakpoint.c: Update.
 153         * btrace.c: Update.
 154         * c-varobj.c: Update.
 155         * cli/cli-cmds.c: Update.
 156         * cli/cli-interp.c: Update.
 157         * cli/cli-script.c: Update.
 158         * common/common-exceptions.c: Update.
 159         * common/new-op.c: Update.
 160         * common/selftest.c: Update.
 161         * compile/compile-c-symbols.c: Update.
 162         * compile/compile-cplus-symbols.c: Update.
 163         * compile/compile-object-load.c: Update.
 164         * compile/compile-object-run.c: Update.
 165         * completer.c: Update.
 166         * corelow.c: Update.
 167         * cp-abi.c: Update.
 168         * cp-support.c: Update.
 169         * cp-valprint.c: Update.
 170         * darwin-nat.c: Update.
 171         * disasm-selftests.c: Update.
 172         * dtrace-probe.c: Update.
 173         * dwarf-index-cache.c: Update.
 174         * dwarf-index-write.c: Update.
 175         * dwarf2-frame-tailcall.c: Update.
 176         * dwarf2-frame.c: Update.
 177         * dwarf2loc.c: Update.
 178         * dwarf2read.c: Update.
 179         * eval.c: Update.
 180         * event-loop.c: Update.
 181         * event-top.c: Update.
 182         * exec.c: Update.
 183         * f-valprint.c: Update.
 184         * fbsd-tdep.c: Update.
 185         * frame-unwind.c: Update.
 186         * frame.c: Update.
 187         * gdbtypes.c: Update.
 188         * gnu-v3-abi.c: Update.
 189         * guile/guile-internal.h: Update.
 190         * guile/scm-block.c: Update.
 191         * guile/scm-breakpoint.c: Update.
 192         * guile/scm-cmd.c: Update.
 193         * guile/scm-disasm.c: Update.
 194         * guile/scm-frame.c: Update.
 195         * guile/scm-lazy-string.c: Update.
 196         * guile/scm-math.c: Update.
 197         * guile/scm-param.c: Update.
 198         * guile/scm-ports.c: Update.
 199         * guile/scm-pretty-print.c: Update.
 200         * guile/scm-symbol.c: Update.
 201         * guile/scm-symtab.c: Update.
 202         * guile/scm-type.c: Update.
 203         * guile/scm-value.c: Update.
 204         * i386-linux-tdep.c: Update.
 205         * i386-tdep.c: Update.
 206         * inf-loop.c: Update.
 207         * infcall.c: Update.
 208         * infcmd.c: Update.
 209         * infrun.c: Update.
 210         * jit.c: Update.
 211         * language.c: Update.
 212         * linespec.c: Update.
 213         * linux-fork.c: Update.
 214         * linux-nat.c: Update.
 215         * linux-tdep.c: Update.
 216         * linux-thread-db.c: Update.
 217         * main.c: Update.
 218         * mi/mi-cmd-break.c: Update.
 219         * mi/mi-cmd-stack.c: Update.
 220         * mi/mi-interp.c: Update.
 221         * mi/mi-main.c: Update.
 222         * objc-lang.c: Update.
 223         * p-valprint.c: Update.
 224         * parse.c: Update.
 225         * ppc-linux-tdep.c: Update.
 226         * printcmd.c: Update.
 227         * python/py-arch.c: Update.
 228         * python/py-breakpoint.c: Update.
 229         * python/py-cmd.c: Update.
 230         * python/py-finishbreakpoint.c: Update.
 231         * python/py-frame.c: Update.
 232         * python/py-framefilter.c: Update.
 233         * python/py-gdb-readline.c: Update.
 234         * python/py-inferior.c: Update.
 235         * python/py-infthread.c: Update.
 236         * python/py-lazy-string.c: Update.
 237         * python/py-linetable.c: Update.
 238         * python/py-objfile.c: Update.
 239         * python/py-param.c: Update.
 240         * python/py-prettyprint.c: Update.
 241         * python/py-progspace.c: Update.
 242         * python/py-record-btrace.c: Update.
 243         * python/py-record.c: Update.
 244         * python/py-symbol.c: Update.
 245         * python/py-type.c: Update.
 246         * python/py-unwind.c: Update.
 247         * python/py-utils.c: Update.
 248         * python/py-value.c: Update.
 249         * python/python.c: Update.
 250         * record-btrace.c: Update.
 251         * record-full.c: Update.
 252         * remote-fileio.c: Update.
 253         * remote.c: Update.
 254         * riscv-tdep.c: Update.
 255         * rs6000-aix-tdep.c: Update.
 256         * rs6000-tdep.c: Update.
 257         * rust-exp.y: Update.
 258         * rust-lang.c: Update.
 259         * s390-tdep.c: Update.
 260         * selftest-arch.c: Update.
 261         * solib-dsbt.c: Update.
 262         * solib-frv.c: Update.
 263         * solib-spu.c: Update.
 264         * solib-svr4.c: Update.
 265         * solib.c: Update.
 266         * sparc64-linux-tdep.c: Update.
 267         * stack.c: Update.
 268         * symfile-mem.c: Update.
 269         * symmisc.c: Update.
 270         * target.c: Update.
 271         * thread.c: Update.
 272         * top.c: Update.
 273         * tracefile-tfile.c: Update.
 274         * tui/tui.c: Update.
 275         * typeprint.c: Update.
 276         * unittests/cli-utils-selftests.c: Update.
 277         * unittests/parse-connection-spec-selftests.c: Update.
 278         * valops.c: Update.
 279         * valprint.c: Update.
 280         * value.c: Update.
 281         * varobj.c: Update.
 282         * windows-nat.c: Update.
 283         * x86-linux-nat.c: Update.
 284         * xml-support.c: Update.
 285
 286 2019-04-08  Tom Tromey  <tom@tromey.com>
 287
 288         * xml-support.c: Use C++ exception handling.
 289         * x86-linux-nat.c: Use C++ exception handling.
 290         * windows-nat.c: Use C++ exception handling.
 291         * varobj.c: Use C++ exception handling.
 292         * value.c: Use C++ exception handling.
 293         * valprint.c: Use C++ exception handling.
 294         * valops.c: Use C++ exception handling.
 295         * unittests/parse-connection-spec-selftests.c: Use C++ exception
 296         handling.
 297         * unittests/cli-utils-selftests.c: Use C++ exception handling.
 298         * typeprint.c: Use C++ exception handling.
 299         * tui/tui.c: Use C++ exception handling.
 300         * tracefile-tfile.c: Use C++ exception handling.
 301         * top.c: Use C++ exception handling.
 302         * thread.c: Use C++ exception handling.
 303         * target.c: Use C++ exception handling.
 304         * symmisc.c: Use C++ exception handling.
 305         * symfile-mem.c: Use C++ exception handling.
 306         * stack.c: Use C++ exception handling.
 307         * sparc64-linux-tdep.c: Use C++ exception handling.
 308         * solib.c: Use C++ exception handling.
 309         * solib-svr4.c: Use C++ exception handling.
 310         * solib-spu.c: Use C++ exception handling.
 311         * solib-frv.c: Use C++ exception handling.
 312         * solib-dsbt.c: Use C++ exception handling.
 313         * selftest-arch.c: Use C++ exception handling.
 314         * s390-tdep.c: Use C++ exception handling.
 315         * rust-lang.c: Use C++ exception handling.
 316         * rust-exp.y: Use C++ exception handling.
 317         * rs6000-tdep.c: Use C++ exception handling.
 318         * rs6000-aix-tdep.c: Use C++ exception handling.
 319         * riscv-tdep.c: Use C++ exception handling.
 320         * remote.c: Use C++ exception handling.
 321         * remote-fileio.c: Use C++ exception handling.
 322         * record-full.c: Use C++ exception handling.
 323         * record-btrace.c: Use C++ exception handling.
 324         * python/python.c: Use C++ exception handling.
 325         * python/py-value.c: Use C++ exception handling.
 326         * python/py-utils.c: Use C++ exception handling.
 327         * python/py-unwind.c: Use C++ exception handling.
 328         * python/py-type.c: Use C++ exception handling.
 329         * python/py-symbol.c: Use C++ exception handling.
 330         * python/py-record.c: Use C++ exception handling.
 331         * python/py-record-btrace.c: Use C++ exception handling.
 332         * python/py-progspace.c: Use C++ exception handling.
 333         * python/py-prettyprint.c: Use C++ exception handling.
 334         * python/py-param.c: Use C++ exception handling.
 335         * python/py-objfile.c: Use C++ exception handling.
 336         * python/py-linetable.c: Use C++ exception handling.
 337         * python/py-lazy-string.c: Use C++ exception handling.
 338         * python/py-infthread.c: Use C++ exception handling.
 339         * python/py-inferior.c: Use C++ exception handling.
 340         * python/py-gdb-readline.c: Use C++ exception handling.
 341         * python/py-framefilter.c: Use C++ exception handling.
 342         * python/py-frame.c: Use C++ exception handling.
 343         * python/py-finishbreakpoint.c: Use C++ exception handling.
 344         * python/py-cmd.c: Use C++ exception handling.
 345         * python/py-breakpoint.c: Use C++ exception handling.
 346         * python/py-arch.c: Use C++ exception handling.
 347         * printcmd.c: Use C++ exception handling.
 348         * ppc-linux-tdep.c: Use C++ exception handling.
 349         * parse.c: Use C++ exception handling.
 350         * p-valprint.c: Use C++ exception handling.
 351         * objc-lang.c: Use C++ exception handling.
 352         * mi/mi-main.c: Use C++ exception handling.
 353         * mi/mi-interp.c: Use C++ exception handling.
 354         * mi/mi-cmd-stack.c: Use C++ exception handling.
 355         * mi/mi-cmd-break.c: Use C++ exception handling.
 356         * main.c: Use C++ exception handling.
 357         * linux-thread-db.c: Use C++ exception handling.
 358         * linux-tdep.c: Use C++ exception handling.
 359         * linux-nat.c: Use C++ exception handling.
 360         * linux-fork.c: Use C++ exception handling.
 361         * linespec.c: Use C++ exception handling.
 362         * language.c: Use C++ exception handling.
 363         * jit.c: Use C++ exception handling.
 364         * infrun.c: Use C++ exception handling.
 365         * infcmd.c: Use C++ exception handling.
 366         * infcall.c: Use C++ exception handling.
 367         * inf-loop.c: Use C++ exception handling.
 368         * i386-tdep.c: Use C++ exception handling.
 369         * i386-linux-tdep.c: Use C++ exception handling.
 370         * guile/scm-value.c: Use C++ exception handling.
 371         * guile/scm-type.c: Use C++ exception handling.
 372         * guile/scm-symtab.c: Use C++ exception handling.
 373         * guile/scm-symbol.c: Use C++ exception handling.
 374         * guile/scm-pretty-print.c: Use C++ exception handling.
 375         * guile/scm-ports.c: Use C++ exception handling.
 376         * guile/scm-param.c: Use C++ exception handling.
 377         * guile/scm-math.c: Use C++ exception handling.
 378         * guile/scm-lazy-string.c: Use C++ exception handling.
 379         * guile/scm-frame.c: Use C++ exception handling.
 380         * guile/scm-disasm.c: Use C++ exception handling.
 381         * guile/scm-cmd.c: Use C++ exception handling.
 382         * guile/scm-breakpoint.c: Use C++ exception handling.
 383         * guile/scm-block.c: Use C++ exception handling.
 384         * guile/guile-internal.h: Use C++ exception handling.
 385         * gnu-v3-abi.c: Use C++ exception handling.
 386         * gdbtypes.c: Use C++ exception handling.
 387         * frame.c: Use C++ exception handling.
 388         * frame-unwind.c: Use C++ exception handling.
 389         * fbsd-tdep.c: Use C++ exception handling.
 390         * f-valprint.c: Use C++ exception handling.
 391         * exec.c: Use C++ exception handling.
 392         * event-top.c: Use C++ exception handling.
 393         * event-loop.c: Use C++ exception handling.
 394         * eval.c: Use C++ exception handling.
 395         * dwarf2read.c: Use C++ exception handling.
 396         * dwarf2loc.c: Use C++ exception handling.
 397         * dwarf2-frame.c: Use C++ exception handling.
 398         * dwarf2-frame-tailcall.c: Use C++ exception handling.
 399         * dwarf-index-write.c: Use C++ exception handling.
 400         * dwarf-index-cache.c: Use C++ exception handling.
 401         * dtrace-probe.c: Use C++ exception handling.
 402         * disasm-selftests.c: Use C++ exception handling.
 403         * darwin-nat.c: Use C++ exception handling.
 404         * cp-valprint.c: Use C++ exception handling.
 405         * cp-support.c: Use C++ exception handling.
 406         * cp-abi.c: Use C++ exception handling.
 407         * corelow.c: Use C++ exception handling.
 408         * completer.c: Use C++ exception handling.
 409         * compile/compile-object-run.c: Use C++ exception handling.
 410         * compile/compile-object-load.c: Use C++ exception handling.
 411         * compile/compile-cplus-symbols.c: Use C++ exception handling.
 412         * compile/compile-c-symbols.c: Use C++ exception handling.
 413         * common/selftest.c: Use C++ exception handling.
 414         * common/new-op.c: Use C++ exception handling.
 415         * cli/cli-script.c: Use C++ exception handling.
 416         * cli/cli-interp.c: Use C++ exception handling.
 417         * cli/cli-cmds.c: Use C++ exception handling.
 418         * c-varobj.c: Use C++ exception handling.
 419         * btrace.c: Use C++ exception handling.
 420         * breakpoint.c: Use C++ exception handling.
 421         * break-catch-throw.c: Use C++ exception handling.
 422         * arch-utils.c: Use C++ exception handling.
 423         * amd64-tdep.c: Use C++ exception handling.
 424         * ada-valprint.c: Use C++ exception handling.
 425         * ada-typeprint.c: Use C++ exception handling.
 426         * ada-lang.c: Use C++ exception handling.
 427         * aarch64-tdep.c: Use C++ exception handling.
 428
 429 2019-04-08  Tom Tromey  <tom@tromey.com>
 430
 431         * xml-support.c (gdb_xml_parser::parse): Update.
 432         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 433         * value.c (show_convenience): Update.
 434         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
 435         (test_parse_flags_qcs): Update.
 436         * thread.c (thr_try_catch_cmd): Update.
 437         * target.c (target_translate_tls_address): Update.
 438         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 439         (info_frame_command_core, frame_apply_command_count): Update.
 440         * rust-exp.y (rust_lex_exception_test): Update.
 441         * riscv-tdep.c (riscv_print_one_register_info): Update.
 442         * remote.c (remote_target::enable_btrace): Update.
 443         * record-btrace.c (record_btrace_enable_warn): Update.
 444         * python/py-utils.c (gdbpy_convert_exception): Update.
 445         * printcmd.c (do_one_display, print_variable_and_value): Update.
 446         * mi/mi-main.c (mi_print_exception): Update.
 447         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
 448         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 449         * linux-nat.c (linux_nat_target::attach): Update.
 450         * linux-fork.c (class scoped_switch_fork_info): Update.
 451         * infrun.c (displaced_step_prepare): Update.
 452         * infcall.c (call_function_by_hand_dummy): Update.
 453         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
 454         * gnu-v3-abi.c (print_one_vtable): Update.
 455         * frame.c (get_prev_frame_always): Update.
 456         * f-valprint.c (info_common_command_for_block): Update.
 457         * exec.c (try_open_exec_file): Update.
 458         * exceptions.c (print_exception, exception_print)
 459         (exception_fprintf, exception_print_same): Update.
 460         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
 461         * dwarf-index-cache.c (index_cache::store)
 462         (index_cache::lookup_gdb_index): Update.
 463         * darwin-nat.c (maybe_cache_shell): Update.
 464         * cp-valprint.c (cp_print_value_fields): Update.
 465         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
 466         (gcc_cplus_symbol_address): Update.
 467         * compile/compile-c-symbols.c (gcc_convert_symbol)
 468         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
 469         * common/selftest.c: Update.
 470         * common/common-exceptions.h (struct gdb_exception) <message>: Now
 471         a std::string.
 472         (exception_try_scope_entry, exception_try_scope_exit): Don't
 473         declare.
 474         (struct exception_try_scope): Remove.
 475         (TRY): Don't use exception_try_scope.
 476         (struct gdb_exception): Add constructor, operator=.
 477         <what>: New method.
 478         (struct gdb_exception_RETURN_MASK_ALL)
 479         (struct gdb_exception_RETURN_MASK_ERROR)
 480         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
 481         (struct gdb_quit_bad_alloc): Update.
 482         * common/common-exceptions.c (exception_none): Change
 483         initializer.
 484         (struct catcher) <state, exception>: Initialize inline.
 485         <prev>: Remove member.
 486         (current_catcher): Remove.
 487         (catchers): New global.
 488         (exceptions_state_mc_init): Simplify.
 489         (catcher_pop): Remove.
 490         (exceptions_state_mc, exceptions_state_mc_catch): Update.
 491         (try_scope_depth, exception_try_scope_entry)
 492         (exception_try_scope_exit): Remove.
 493         (throw_exception_sjlj): Update.
 494         (exception_messages, exception_messages_size): Remove.
 495         (throw_it): Simplify.
 496         (gdb_exception_sliced_copy): Remove.
 497         (throw_exception_cxx): Update.
 498         * cli/cli-script.c (script_from_file): Update.
 499         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
 500         Update.
 501         * ada-valprint.c (ada_val_print): Update.
 502         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
 503         (create_excep_cond_exprs): Update.
 504
 505 2019-04-08  Tom Tromey  <tom@tromey.com>
 506
 507         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
 508         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
 509         (TRY, CATCH, END_CATCH): Remove some definitions.
 510         * common/common-exceptions.c: Don't use GDB_XCPT.
 511         (catcher_list_size): Remove.
 512         (throw_exception, throw_it): Simplify.
 513
 514 2019-04-05  Tom Tromey  <tom@tromey.com>
 515
 516         Revert the header-sorting patch.
 517         * ft32-tdep.c: Revert.
 518         * frv-tdep.c: Revert.
 519         * frv-linux-tdep.c: Revert.
 520         * frame.c: Revert.
 521         * frame-unwind.c: Revert.
 522         * frame-base.c: Revert.
 523         * fork-child.c: Revert.
 524         * findvar.c: Revert.
 525         * findcmd.c: Revert.
 526         * filesystem.c: Revert.
 527         * filename-seen-cache.h: Revert.
 528         * filename-seen-cache.c: Revert.
 529         * fbsd-tdep.c: Revert.
 530         * fbsd-nat.h: Revert.
 531         * fbsd-nat.c: Revert.
 532         * f-valprint.c: Revert.
 533         * f-typeprint.c: Revert.
 534         * f-lang.c: Revert.
 535         * extension.h: Revert.
 536         * extension.c: Revert.
 537         * extension-priv.h: Revert.
 538         * expprint.c: Revert.
 539         * exec.h: Revert.
 540         * exec.c: Revert.
 541         * exceptions.c: Revert.
 542         * event-top.c: Revert.
 543         * event-loop.c: Revert.
 544         * eval.c: Revert.
 545         * elfread.c: Revert.
 546         * dwarf2read.h: Revert.
 547         * dwarf2read.c: Revert.
 548         * dwarf2loc.c: Revert.
 549         * dwarf2expr.h: Revert.
 550         * dwarf2expr.c: Revert.
 551         * dwarf2-frame.c: Revert.
 552         * dwarf2-frame-tailcall.c: Revert.
 553         * dwarf-index-write.h: Revert.
 554         * dwarf-index-write.c: Revert.
 555         * dwarf-index-common.c: Revert.
 556         * dwarf-index-cache.h: Revert.
 557         * dwarf-index-cache.c: Revert.
 558         * dummy-frame.c: Revert.
 559         * dtrace-probe.c: Revert.
 560         * disasm.h: Revert.
 561         * disasm.c: Revert.
 562         * disasm-selftests.c: Revert.
 563         * dictionary.c: Revert.
 564         * dicos-tdep.c: Revert.
 565         * demangle.c: Revert.
 566         * dcache.h: Revert.
 567         * dcache.c: Revert.
 568         * darwin-nat.h: Revert.
 569         * darwin-nat.c: Revert.
 570         * darwin-nat-info.c: Revert.
 571         * d-valprint.c: Revert.
 572         * d-namespace.c: Revert.
 573         * d-lang.c: Revert.
 574         * ctf.c: Revert.
 575         * csky-tdep.c: Revert.
 576         * csky-linux-tdep.c: Revert.
 577         * cris-tdep.c: Revert.
 578         * cris-linux-tdep.c: Revert.
 579         * cp-valprint.c: Revert.
 580         * cp-support.c: Revert.
 581         * cp-namespace.c: Revert.
 582         * cp-abi.c: Revert.
 583         * corelow.c: Revert.
 584         * corefile.c: Revert.
 585         * continuations.c: Revert.
 586         * completer.h: Revert.
 587         * completer.c: Revert.
 588         * complaints.c: Revert.
 589         * coffread.c: Revert.
 590         * coff-pe-read.c: Revert.
 591         * cli-out.h: Revert.
 592         * cli-out.c: Revert.
 593         * charset.c: Revert.
 594         * c-varobj.c: Revert.
 595         * c-valprint.c: Revert.
 596         * c-typeprint.c: Revert.
 597         * c-lang.c: Revert.
 598         * buildsym.c: Revert.
 599         * buildsym-legacy.c: Revert.
 600         * build-id.h: Revert.
 601         * build-id.c: Revert.
 602         * btrace.c: Revert.
 603         * bsd-uthread.c: Revert.
 604         * breakpoint.h: Revert.
 605         * breakpoint.c: Revert.
 606         * break-catch-throw.c: Revert.
 607         * break-catch-syscall.c: Revert.
 608         * break-catch-sig.c: Revert.
 609         * blockframe.c: Revert.
 610         * block.c: Revert.
 611         * bfin-tdep.c: Revert.
 612         * bfin-linux-tdep.c: Revert.
 613         * bfd-target.c: Revert.
 614         * bcache.c: Revert.
 615         * ax-general.c: Revert.
 616         * ax-gdb.h: Revert.
 617         * ax-gdb.c: Revert.
 618         * avr-tdep.c: Revert.
 619         * auxv.c: Revert.
 620         * auto-load.c: Revert.
 621         * arm-wince-tdep.c: Revert.
 622         * arm-tdep.c: Revert.
 623         * arm-symbian-tdep.c: Revert.
 624         * arm-pikeos-tdep.c: Revert.
 625         * arm-obsd-tdep.c: Revert.
 626         * arm-nbsd-tdep.c: Revert.
 627         * arm-nbsd-nat.c: Revert.
 628         * arm-linux-tdep.c: Revert.
 629         * arm-linux-nat.c: Revert.
 630         * arm-fbsd-tdep.c: Revert.
 631         * arm-fbsd-nat.c: Revert.
 632         * arm-bsd-tdep.c: Revert.
 633         * arch-utils.c: Revert.
 634         * arc-tdep.c: Revert.
 635         * arc-newlib-tdep.c: Revert.
 636         * annotate.h: Revert.
 637         * annotate.c: Revert.
 638         * amd64-windows-tdep.c: Revert.
 639         * amd64-windows-nat.c: Revert.
 640         * amd64-tdep.c: Revert.
 641         * amd64-sol2-tdep.c: Revert.
 642         * amd64-obsd-tdep.c: Revert.
 643         * amd64-obsd-nat.c: Revert.
 644         * amd64-nbsd-tdep.c: Revert.
 645         * amd64-nbsd-nat.c: Revert.
 646         * amd64-nat.c: Revert.
 647         * amd64-linux-tdep.c: Revert.
 648         * amd64-linux-nat.c: Revert.
 649         * amd64-fbsd-tdep.c: Revert.
 650         * amd64-fbsd-nat.c: Revert.
 651         * amd64-dicos-tdep.c: Revert.
 652         * amd64-darwin-tdep.c: Revert.
 653         * amd64-bsd-nat.c: Revert.
 654         * alpha-tdep.c: Revert.
 655         * alpha-obsd-tdep.c: Revert.
 656         * alpha-nbsd-tdep.c: Revert.
 657         * alpha-mdebug-tdep.c: Revert.
 658         * alpha-linux-tdep.c: Revert.
 659         * alpha-linux-nat.c: Revert.
 660         * alpha-bsd-tdep.c: Revert.
 661         * alpha-bsd-nat.c: Revert.
 662         * aix-thread.c: Revert.
 663         * agent.c: Revert.
 664         * addrmap.c: Revert.
 665         * ada-varobj.c: Revert.
 666         * ada-valprint.c: Revert.
 667         * ada-typeprint.c: Revert.
 668         * ada-tasks.c: Revert.
 669         * ada-lang.c: Revert.
 670         * aarch64-tdep.c: Revert.
 671         * aarch64-ravenscar-thread.c: Revert.
 672         * aarch64-newlib-tdep.c: Revert.
 673         * aarch64-linux-tdep.c: Revert.
 674         * aarch64-linux-nat.c: Revert.
 675         * aarch64-fbsd-tdep.c: Revert.
 676         * aarch64-fbsd-nat.c: Revert.
 677         * aarch32-linux-nat.c: Revert.
 678
 679 2019-04-05  Tom Tromey  <tom@tromey.com>
 680
 681         * ft32-tdep.c: Sort headers.
 682         * frv-tdep.c: Sort headers.
 683         * frv-linux-tdep.c: Sort headers.
 684         * frame.c: Sort headers.
 685         * frame-unwind.c: Sort headers.
 686         * frame-base.c: Sort headers.
 687         * fork-child.c: Sort headers.
 688         * findvar.c: Sort headers.
 689         * findcmd.c: Sort headers.
 690         * filesystem.c: Sort headers.
 691         * filename-seen-cache.h: Sort headers.
 692         * filename-seen-cache.c: Sort headers.
 693         * fbsd-tdep.c: Sort headers.
 694         * fbsd-nat.h: Sort headers.
 695         * fbsd-nat.c: Sort headers.
 696         * f-valprint.c: Sort headers.
 697         * f-typeprint.c: Sort headers.
 698         * f-lang.c: Sort headers.
 699         * extension.h: Sort headers.
 700         * extension.c: Sort headers.
 701         * extension-priv.h: Sort headers.
 702         * expprint.c: Sort headers.
 703         * exec.h: Sort headers.
 704         * exec.c: Sort headers.
 705         * exceptions.c: Sort headers.
 706         * event-top.c: Sort headers.
 707         * event-loop.c: Sort headers.
 708         * eval.c: Sort headers.
 709         * elfread.c: Sort headers.
 710         * dwarf2read.h: Sort headers.
 711         * dwarf2read.c: Sort headers.
 712         * dwarf2loc.c: Sort headers.
 713         * dwarf2expr.h: Sort headers.
 714         * dwarf2expr.c: Sort headers.
 715         * dwarf2-frame.c: Sort headers.
 716         * dwarf2-frame-tailcall.c: Sort headers.
 717         * dwarf-index-write.h: Sort headers.
 718         * dwarf-index-write.c: Sort headers.
 719         * dwarf-index-common.c: Sort headers.
 720         * dwarf-index-cache.h: Sort headers.
 721         * dwarf-index-cache.c: Sort headers.
 722         * dummy-frame.c: Sort headers.
 723         * dtrace-probe.c: Sort headers.
 724         * disasm.h: Sort headers.
 725         * disasm.c: Sort headers.
 726         * disasm-selftests.c: Sort headers.
 727         * dictionary.c: Sort headers.
 728         * dicos-tdep.c: Sort headers.
 729         * demangle.c: Sort headers.
 730         * dcache.h: Sort headers.
 731         * dcache.c: Sort headers.
 732         * darwin-nat.h: Sort headers.
 733         * darwin-nat.c: Sort headers.
 734         * darwin-nat-info.c: Sort headers.
 735         * d-valprint.c: Sort headers.
 736         * d-namespace.c: Sort headers.
 737         * d-lang.c: Sort headers.
 738         * ctf.c: Sort headers.
 739         * csky-tdep.c: Sort headers.
 740         * csky-linux-tdep.c: Sort headers.
 741         * cris-tdep.c: Sort headers.
 742         * cris-linux-tdep.c: Sort headers.
 743         * cp-valprint.c: Sort headers.
 744         * cp-support.c: Sort headers.
 745         * cp-namespace.c: Sort headers.
 746         * cp-abi.c: Sort headers.
 747         * corelow.c: Sort headers.
 748         * corefile.c: Sort headers.
 749         * continuations.c: Sort headers.
 750         * completer.h: Sort headers.
 751         * completer.c: Sort headers.
 752         * complaints.c: Sort headers.
 753         * coffread.c: Sort headers.
 754         * coff-pe-read.c: Sort headers.
 755         * cli-out.h: Sort headers.
 756         * cli-out.c: Sort headers.
 757         * charset.c: Sort headers.
 758         * c-varobj.c: Sort headers.
 759         * c-valprint.c: Sort headers.
 760         * c-typeprint.c: Sort headers.
 761         * c-lang.c: Sort headers.
 762         * buildsym.c: Sort headers.
 763         * buildsym-legacy.c: Sort headers.
 764         * build-id.h: Sort headers.
 765         * build-id.c: Sort headers.
 766         * btrace.c: Sort headers.
 767         * bsd-uthread.c: Sort headers.
 768         * breakpoint.h: Sort headers.
 769         * breakpoint.c: Sort headers.
 770         * break-catch-throw.c: Sort headers.
 771         * break-catch-syscall.c: Sort headers.
 772         * break-catch-sig.c: Sort headers.
 773         * blockframe.c: Sort headers.
 774         * block.c: Sort headers.
 775         * bfin-tdep.c: Sort headers.
 776         * bfin-linux-tdep.c: Sort headers.
 777         * bfd-target.c: Sort headers.
 778         * bcache.c: Sort headers.
 779         * ax-general.c: Sort headers.
 780         * ax-gdb.h: Sort headers.
 781         * ax-gdb.c: Sort headers.
 782         * avr-tdep.c: Sort headers.
 783         * auxv.c: Sort headers.
 784         * auto-load.c: Sort headers.
 785         * arm-wince-tdep.c: Sort headers.
 786         * arm-tdep.c: Sort headers.
 787         * arm-symbian-tdep.c: Sort headers.
 788         * arm-pikeos-tdep.c: Sort headers.
 789         * arm-obsd-tdep.c: Sort headers.
 790         * arm-nbsd-tdep.c: Sort headers.
 791         * arm-nbsd-nat.c: Sort headers.
 792         * arm-linux-tdep.c: Sort headers.
 793         * arm-linux-nat.c: Sort headers.
 794         * arm-fbsd-tdep.c: Sort headers.
 795         * arm-fbsd-nat.c: Sort headers.
 796         * arm-bsd-tdep.c: Sort headers.
 797         * arch-utils.c: Sort headers.
 798         * arc-tdep.c: Sort headers.
 799         * arc-newlib-tdep.c: Sort headers.
 800         * annotate.h: Sort headers.
 801         * annotate.c: Sort headers.
 802         * amd64-windows-tdep.c: Sort headers.
 803         * amd64-windows-nat.c: Sort headers.
 804         * amd64-tdep.c: Sort headers.
 805         * amd64-sol2-tdep.c: Sort headers.
 806         * amd64-obsd-tdep.c: Sort headers.
 807         * amd64-obsd-nat.c: Sort headers.
 808         * amd64-nbsd-tdep.c: Sort headers.
 809         * amd64-nbsd-nat.c: Sort headers.
 810         * amd64-nat.c: Sort headers.
 811         * amd64-linux-tdep.c: Sort headers.
 812         * amd64-linux-nat.c: Sort headers.
 813         * amd64-fbsd-tdep.c: Sort headers.
 814         * amd64-fbsd-nat.c: Sort headers.
 815         * amd64-dicos-tdep.c: Sort headers.
 816         * amd64-darwin-tdep.c: Sort headers.
 817         * amd64-bsd-nat.c: Sort headers.
 818         * alpha-tdep.c: Sort headers.
 819         * alpha-obsd-tdep.c: Sort headers.
 820         * alpha-nbsd-tdep.c: Sort headers.
 821         * alpha-mdebug-tdep.c: Sort headers.
 822         * alpha-linux-tdep.c: Sort headers.
 823         * alpha-linux-nat.c: Sort headers.
 824         * alpha-bsd-tdep.c: Sort headers.
 825         * alpha-bsd-nat.c: Sort headers.
 826         * aix-thread.c: Sort headers.
 827         * agent.c: Sort headers.
 828         * addrmap.c: Sort headers.
 829         * ada-varobj.c: Sort headers.
 830         * ada-valprint.c: Sort headers.
 831         * ada-typeprint.c: Sort headers.
 832         * ada-tasks.c: Sort headers.
 833         * ada-lang.c: Sort headers.
 834         * aarch64-tdep.c: Sort headers.
 835         * aarch64-ravenscar-thread.c: Sort headers.
 836         * aarch64-newlib-tdep.c: Sort headers.
 837         * aarch64-linux-tdep.c: Sort headers.
 838         * aarch64-linux-nat.c: Sort headers.
 839         * aarch64-fbsd-tdep.c: Sort headers.
 840         * aarch64-fbsd-nat.c: Sort headers.
 841         * aarch32-linux-nat.c: Sort headers.
 842
 843 2019-04-04  Tom Tromey  <tom@tromey.com>
 844
 845         * varobj.c (varobj_create): Update.
 846         * rust-exp.y (struct rust_parser) <update_innermost_block,
 847         lookup_symbol>: New methods.
 848         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
 849         Rename.
 850         (rust_parser::rust_lookup_type)
 851         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
 852         * printcmd.c (display_command, do_one_display): Update.
 853         * parser-defs.h (struct parser_state) <parser_state>: Add
 854         "tracker" parameter.
 855         (block_tracker): New member.
 856         (class innermost_block_tracker) <innermost_block_tracker>: Add
 857         "types" parameter.
 858         <reset>: Remove method.
 859         (innermost_block): Don't declare.
 860         (null_post_parser): Update.
 861         * parse.c (innermost_block): Remove global.
 862         (write_dollar_variable): Update.
 863         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
 864         Remove "tracker_types" parameter.
 865         (parse_expression): Add "tracker" parameter.
 866         (parse_expression_for_completion): Update.
 867         (null_post_parser): Add "tracker" parameter.
 868         * p-exp.y: Update rules.
 869         * m2-exp.y: Update rules.
 870         * language.h (struct language_defn) <la_post_parser>: Add
 871         "tracker" parameter.
 872         * go-exp.y: Update rules.
 873         * f-exp.y: Update rules.
 874         * expression.h (parse_expression, parse_exp_1): Add "tracker"
 875         parameter.
 876         * d-exp.y: Update rules.
 877         * c-exp.y: Update rules.
 878         * breakpoint.c (set_breakpoint_condition): Create an
 879         innermost_block_tracker.
 880         (watch_command_1): Likewise.
 881         * ada-lang.c (resolve): Add "tracker" parameter.
 882         (resolve_subexp): Likewise.
 883         * ada-exp.y (write_var_from_sym): Update.
 884
 885 2019-04-04  Tom Tromey  <tom@tromey.com>
 886
 887         * type-stack.h: New file.
 888         * type-stack.c: New file.
 889         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
 890         type-stack.h.
 891         (insert_into_type_stack, insert_type, push_type, push_type_int)
 892         (insert_type_address_space, pop_type, pop_type_int)
 893         (pop_typelist, pop_type_stack, append_type_stack)
 894         (push_type_stack, get_type_stack, push_typelist)
 895         (follow_type_instance_flags, follow_types): Don't declare.
 896         * parse.c (type_stack): Remove global.
 897         (parse_exp_in_context): Update.
 898         (insert_into_type_stack, insert_type, push_type, push_type_int)
 899         (insert_type_address_space, pop_type, pop_type_int)
 900         (pop_typelist, pop_type_stack, append_type_stack)
 901         (push_type_stack, get_type_stack, push_typelist)
 902         (follow_type_instance_flags, follow_types): Remove (moved to
 903         type-stack.c).
 904         * f-exp.y (type_stack): New global.
 905         Update rules.
 906         (push_kind_type, f_parse): Update.
 907         * d-exp.y (type_stack): New global.
 908         Update rules.
 909         (d_parse): Update.
 910         * c-exp.y (struct c_parse_state) <type_stack>: New member.
 911         Update rules.
 912         * Makefile.in (COMMON_SFILES): Add type-stack.c.
 913         (HFILES_NO_SRCDIR): Add type-stack.h.
 914
 915 2019-04-04  Tom Tromey  <tom@tromey.com>
 916
 917         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
 918         (rust_parser::convert_ast_to_expression, rust_parse)
 919         (rust_lex_test_completion, rust_lex_tests): Update.
 920         * parser-defs.h (struct expr_completion_state): New.
 921         (struct parser_state) <parser_state>: Add completion parameter.
 922         <mark_struct_expression, mark_completion_tag>: New methods.
 923         <parse_completion, m_completion_state>: New members.
 924         (prefixify_expression, null_post_parser): Update.
 925         (mark_struct_expression, mark_completion_tag): Don't declare.
 926         * parse.c (parse_completion, expout_last_struct)
 927         (expout_tag_completion_type, expout_completion_name): Remove
 928         globals.
 929         (parser_state::mark_struct_expression)
 930         (parser_state::mark_completion_tag): Now methods.
 931         (prefixify_expression): Add last_struct parameter.
 932         (prefixify_subexp): Likewise.
 933         (parse_exp_1): Update.
 934         (parse_exp_in_context): Add cstate parameter.  Update.
 935         (parse_expression_for_completion): Create an
 936         expr_completion_state.
 937         (null_post_parser): Add "completion" parameter.
 938         * p-exp.y: Update rules.
 939         (yylex): Update.
 940         * language.h (struct language_defn) <la_post_parser>: Add
 941         "completing" parameter.
 942         * go-exp.y: Update rules.
 943         (lex_one_token): Update.
 944         * expression.h (parse_completion): Don't declare.
 945         * d-exp.y: Update rules.
 946         (lex_one_token): Update rules.
 947         * c-exp.y: Update rules.
 948         (lex_one_token): Update.
 949         * ada-lang.c (resolve): Add "parse_completion" parameter.
 950         (resolve_subexp): Likewise.
 951         (ada_resolve_function): Likewise.
 952
 953 2019-04-04  Tom Tromey  <tom@tromey.com>
 954
 955         * parser-defs.h (struct parser_state) <start_arglist,
 956         end_arglist>: New methods.
 957         <arglist_len, m_funcall_chain>: New members.
 958         (arglist_len, start_arglist, end_arglist): Don't declare.
 959         * parse.c (arglist_len, funcall_chain): Remove global.
 960         (start_arglist, end_arglist): Remove functions.
 961         (parse_exp_in_context): Update.
 962         * p-exp.y: Update rules.
 963         * m2-exp.y: Update rules.
 964         * go-exp.y: Update rules.
 965         * f-exp.y: Update rules.
 966         * d-exp.y: Update rules.
 967         * c-exp.y: Update rules.
 968
 969 2019-04-04  Tom Tromey  <tom@tromey.com>
 970
 971         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
 972         lex_operator, push_back>: New methods.
 973         Update all rules.
 974         (rust_parser::lex_hex, lex_escape): Rename and update.
 975         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
 976         (rust_parser::lex_operator): Rename and update.
 977         (rust_parser::lex_number, rustyylex, rustyyerror)
 978         (rust_lex_test_init, rust_lex_test_sequence)
 979         (rust_lex_test_push_back, rust_lex_tests): Update.
 980         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
 981         parameter.
 982         <lexptr, prev_lexptr>: New members.
 983         (lexptr, prev_lexptr): Don't declare.
 984         * parse.c (lexptr, prev_lexptr): Remove globals.
 985         (parse_exp_in_context): Update.
 986         * p-exp.y (yylex, yyerror): Update.
 987         * m2-exp.y (parse_number, yylex, yyerror): Update.
 988         * go-exp.y (lex_one_token, yyerror): Update.
 989         * f-exp.y (match_string_literal, yylex, yyerror): Update.
 990         * d-exp.y (lex_one_token, yyerror): Update.
 991         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
 992         (lex_one_token, yyerror): Update.
 993         * ada-lex.l (YY_INPUT): Update.
 994         (rewind_to_char): Update.
 995         * ada-exp.y (yyerror): Update.
 996
 997 2019-04-04  Tom Tromey  <tom@tromey.com>
 998
 999         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1000         * parser-defs.h (struct parser_state) <parser_state>: Add new
1001         parameter.
1002         <comma_terminates>: New member.
1003         (comma_terminates): Don't declare global.
1004         * parse.c (comma_terminates): Remove global.
1005         (parse_exp_in_context): Update.
1006         * p-exp.y (yylex): Update.
1007         * m2-exp.y (yylex): Update.
1008         * go-exp.y (lex_one_token): Update.
1009         * f-exp.y (yylex): Update.
1010         * d-exp.y (lex_one_token): Update.
1011         * c-exp.y (lex_one_token): Update.
1012         * ada-lex.l: Update.
1013
1014 2019-04-04  Tom Tromey  <tom@tromey.com>
1015
1016         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1017         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1018         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1019         * parser-defs.h (paren_depth): Don't declare.
1020         * parse.c (paren_depth): Remove global.
1021         (parse_exp_in_context): Update.
1022         * p-exp.y (paren_depth): New global.
1023         (pascal_parse): Initialize it.
1024         * m2-exp.y (paren_depth): New global.
1025         (m2_parse): Initialize it.
1026         * go-exp.y (paren_depth): New global.
1027         (go_parse): Initialize it.
1028         * f-exp.y (paren_depth): New global.
1029         (f_parse): Initialize it.
1030         * d-exp.y (paren_depth): New global.
1031         (d_parse): Initialize it.
1032         * c-exp.y (paren_depth): New global.
1033         (c_parse): Initialize it.
1034         * ada-lex.l (paren_depth): New global.
1035         (lexer_init): Initialize it.
1036
1037 2019-04-04  Tom Tromey  <tom@tromey.com>
1038
1039         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1040         (rust_parser::convert_ast_to_type)
1041         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1042         * parser-defs.h (struct parser_state) <parser_state>: Add
1043         parameters.  Initialize new members.
1044         <expression_context_block, expression_context_pc>: New members.
1045         * parse.c (expression_context_block, expression_context_pc):
1046         Remove globals.
1047         (parse_exp_in_context): Update.
1048         * p-exp.y: Update all rules.
1049         (yylex): Update.
1050         * m2-exp.y: Update all rules.
1051         (yylex): Update.
1052         * go-exp.y (yylex): Update.
1053         * f-exp.y (yylex): Update.
1054         * d-exp.y: Update all rules.
1055         (yylex): Update.
1056         * c-exp.y: Update all rules.
1057         (lex_one_token, classify_name, yylex, c_parse): Update.
1058         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1059
1060 2019-04-04  Tom Tromey  <tom@tromey.com>
1061
1062         * gdbarch.h, gdbarch.c: Rebuild.
1063         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1064         * stap-probe.h:
1065         (struct stap_parse_info): Replace "parser_state" with
1066         "expr_builder".
1067         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1068         (parser_state): New class.
1069         * parse.c (expr_builder): Rename.
1070         (expr_builder::release): Rename.
1071         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1072         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1073         (write_exp_elt_longcst, write_exp_elt_floatcst)
1074         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1075         (write_exp_string_vector, write_exp_bitstring)
1076         (write_exp_msymbol, mark_struct_expression)
1077         (write_dollar_variable)
1078         (insert_type_address_space, increase_expout_size): Replace
1079         "parser_state" with "expr_builder".
1080         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1081         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1082         "parser_state" with "expr_builder".
1083
1084 2019-04-04  Tom Tromey  <tom@tromey.com>
1085
1086         * rust-exp.y: Replace "parse_language" with method call.
1087         * p-exp.y:
1088         (yylex): Replace "parse_language" with method call.
1089         * m2-exp.y:
1090         (yylex): Replace "parse_language" with method call.
1091         * go-exp.y (classify_name): Replace "parse_language" with method
1092         call.
1093         * f-exp.y (yylex): Replace "parse_language" with method call.
1094         * d-exp.y (lex_one_token): Replace "parse_language" with method
1095         call.
1096         * c-exp.y:
1097         (lex_one_token, classify_name, yylex): Replace "parse_language"
1098         with method call.
1099         * ada-exp.y (find_primitive_type, type_char)
1100         (type_system_address): Replace "parse_language" with method call.
1101
1102 2019-04-04  Tom Tromey  <tom@tromey.com>
1103
1104         * rust-exp.y: Replace "parse_gdbarch" with method call.
1105         * parse.c (write_dollar_variable, insert_type_address_space):
1106         Replace "parse_gdbarch" with method call.
1107         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1108         call.
1109         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1110         call.
1111         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1112         "parse_gdbarch" with method call.
1113         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1114         with method call.
1115         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1116         "parse_gdbarch" with method call.
1117         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1118         "parse_gdbarch" with method call.
1119         * c-exp.y (parse_type, parse_number, classify_name): Replace
1120         "parse_gdbarch" with method call.
1121         * ada-lex.l: Replace "parse_gdbarch" with method call.
1122         * ada-exp.y (parse_type, find_primitive_type, type_char)
1123         (type_system_address): Replace "parse_gdbarch" with method call.
1124
1125 2019-04-04  Tom Tromey  <tom@tromey.com>
1126
1127         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1128         * stap-probe.c (stap_parse_argument): Update.
1129         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1130         initial_size parameter.
1131         * rust-exp.y (rust_lex_tests): Update.
1132         * parse.c (parser_state): Update.
1133         (parse_exp_in_context): Update.
1134         * parser-defs.h (struct parser_state) <parser_state>: Remove
1135         "initial_size" parameter.
1136
1137 2019-04-04  Tom Tromey  <tom@tromey.com>
1138
1139         * parser-defs.h (increase_expout_size): Don't declare.
1140         * parse.c (increase_expout_size): Now static.
1141
1142 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1143
1144         * gnu-nat.c (gnu_nat_target::wait): Fix
1145         target_waitstatus_to_string call.
1146
1147 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1148
1149         * eval.c (evaluate_subexp_standard): Handle internal functions
1150         during Fortran function call handling.
1151
1152 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1153
1154         * NEWS: Mention new internal functions.
1155         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1156         (read_base_type): Use dwarf2_init_complex_target_type.
1157         * value.c (creal_internal_fn): New function.
1158         (cimag_internal_fn): New function.
1159         (_initialize_values): Register new internal functions.
1160
1161 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1162
1163         * infrun.c (stop_all_threads): If debug_infrun, always
1164         trace the wait status after wait_one, using
1165         target_waitstatus_to_string and target_pid_to_str.
1166         (handle_inferior_event): Replace various trace of
1167         wait status kind by a single trace.
1168         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1169         wait status kind image by target_waitstatus_to_string.
1170         * target/waitstatus.c (target_waitstatus_to_string): Fix
1171         obsolete comment.
1172
1173 2019-04-01  Tom Tromey  <tromey@adacore.com>
1174
1175         PR symtab/23331:
1176         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1177
1178 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1179             Pedro Alves  <palves@redhat.com>
1180
1181         * top.c (quit_force): Call 'finalize_values'.
1182         * value.c (finalize_values): New function.
1183         * value.h (finalize_values): Declare.
1184
1185 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1186
1187         * NEWS: Announce $_gdb_major and $_gdb_minor.
1188
1189         * top.c (init_gdb_version_vars): New function.
1190         (gdb_init): Call init_gdb_version_vars.
1191
1192 2019-03-29  Tom Tromey  <tromey@adacore.com>
1193
1194         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1195         help text.  Remove dead code.
1196
1197 2019-03-29  Keith Seitz  <keiths@redhat.com>
1198
1199         From Siddhesh Poyarekar:
1200         * f-lang.h (f77_get_upperbound): Return LONGEST.
1201         (f77_get_lowerbound): Likewise.
1202         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1203         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1204         print them.
1205         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1206         plongest to format print it.
1207         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1208         (f77_get_upperbound): Likewise.
1209         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1210         LOWER_BOUND to LONGEST.
1211         (f77_create_arrayprint_offset_tbl): Likewise.
1212
1213 2019-03-29  Keith Seitz  <keiths@redhat.com>
1214
1215         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1216         %s/pulongest for TYPE_LENGTH instead of %d in format
1217         strings.
1218         * ada-typerint.c (ada_print_type): Likewise.
1219         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1220         * compile/compile-c-support.c (generate_register_struct): Likewise.
1221         * gdbtypes.c (recursive_dump_type): Likewise.
1222         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1223         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1224         instead of %d in format strings.
1225         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1226         to std::min to ULONGEST.
1227         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1228         instead of %d in format strings.
1229         * tracepoint.c (info_scope_command): Likewise.
1230         * typeprint.c (print_offset_data::update)
1231         (print_offset_data::finish): Likewise.
1232         * xtensa-tdep.c (xtensa_store_return_value)
1233         (xtensa_push_dummy_call): Likewise.
1234
1235 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1236
1237         * windows-nat.c (display_selector): Fixed format specifications
1238         for 64-bit Cygwin.
1239
1240 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1241
1242         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1243
1244 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1245
1246         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1247         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1248         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1249         (nios2_linux_init_abi): Install it.
1250
1251 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1252
1253         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1254
1255 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1256
1257         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1258
1259 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1260             Tom Tromey  <tromey@adacore.com>
1261
1262         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1263
1264 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1265
1266         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1267         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1268         method to compute the bounds of range types. Also print "[evaluated]"
1269         if the bounds' values come from a dynamic evaluation.
1270
1271 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1272
1273         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1274         whitespace when pretty printing is on.
1275
1276 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1277
1278         * ppc-linux-nat.c: Add include.
1279
1280 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1281
1282         * NEWS: Mention AArch64 Pointer Authentication.
1283
1284 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1285
1286         * arm-linux-nat.c: Add include.
1287
1288 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1289
1290         * source-cache.c (source_cache::get_source_lines): Re-read
1291         fullname after calling open_source_file.
1292
1293 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1294
1295         * NEWS: Mention TLS support for FreeBSD.
1296
1297 2019-03-25  Tom Tromey  <tromey@adacore.com>
1298
1299         * minsyms.c (BUNCH_SIZE): Update comment.
1300         (~minimal_symbol_reader): Remove old comment.
1301         (compact_minimal_symbols): Update comment.
1302         (minimal_symbol_reader::install): Remove old comment.  Update
1303         other comments.
1304
1305 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1306
1307         * s390-linux-nat.c: Add include.
1308
1309 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1310
1311         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1312         Call linux_get_hwcap.
1313         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1314         Likewise.
1315         (aarch64_linux_get_hwcap): Remove function.
1316         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1317         declaration.
1318         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1319         linux_get_hwcap.
1320         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1321         * linux-tdep.c (linux_get_hwcap): Add function.
1322         (linux_get_hwcap2): Likewise.
1323         * linux-tdep.h (linux_get_hwcap): Add declaration.
1324         (linux_get_hwcap2): Likewise.
1325         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1326         (ppc_linux_get_hwcap2): Likewise.
1327         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1328         linux_get_hwcap.
1329         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1330         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1331         (ppc_linux_nat_target::read_description): Likewise.
1332         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1333         * s390-linux-nat.c: Likewise.
1334         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1335
1336 2019-03-24  Tom Tromey  <tom@tromey.com>
1337
1338         * ada-lang.c (standard_lookup): Simplify initialization.
1339         (ada_lookup_symbol_nonlocal): Simplify return.
1340         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1341         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1342         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1343         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1344         initialization.
1345         * solib.c (solib_global_lookup): Simplify.
1346         * symtab.c (null_block_symbol): Remove.
1347         (symbol_cache_lookup): Simplify returns.
1348         (lookup_language_this): Simplify returns.
1349         (lookup_symbol_aux): Simplify return.
1350         (lookup_local_symbol): Simplify returns.
1351         (lookup_global_symbol_from_objfile): Simplify return.
1352         (lookup_symbol_in_objfile_symtabs)
1353         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1354         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1355         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1356         * cp-namespace.c (cp_lookup_bare_symbol)
1357         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1358         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1359         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1360         (cp_lookup_symbol_via_imports): Simplify initialization.
1361         (find_symbol_in_baseclass): Likewise.
1362         * symtab.h (null_block_symbol): Remove.
1363         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1364         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1365         (d_lookup_symbol_module): Likewise.
1366         (find_symbol_in_baseclass): Simplify initialization.
1367
1368 2019-03-24  Tom Tromey  <tom@tromey.com>
1369
1370         * expression.h: Don't include symtab.h.
1371         (struct block): Forward declare.
1372
1373 2019-03-24  Tom Tromey  <tom@tromey.com>
1374
1375         * c-exp.y (typebase): Remove casts.
1376         * gdbtypes.c (lookup_unsigned_typename, )
1377         (lookup_signed_typename): Remove cast.
1378         * eval.c (parse_to_comma_and_eval): Remove cast.
1379         * parse.c (write_dollar_variable): Remove cast.
1380         * block.h (struct block) <superblock>: Now const.
1381         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1382         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1383         (map_block): Make "block" const.
1384         * symfile.h (struct quick_symbol_functions)
1385         <map_matching_symbols>: Constify block argument to "callback".
1386         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1387         const.
1388         (find_pc_sect_compunit_symtab): Make "b" const.
1389         (find_symbol_at_address): Likewise.
1390         (search_symbols): Likewise.
1391         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1392         (dw2_debug_names_lookup_symbol): Likewise.
1393         (dw2_map_matching_symbols): Update.
1394         * p-valprint.c (pascal_val_print): Remove "block".
1395         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1396         (aux_add_nonlocal_symbols): Make "block" const.
1397         (resolve_subexp): Remove cast.
1398         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1399         const.
1400         (iterate_over_file_blocks): Likewise.
1401         * f-exp.y (%union) <bval>: Remove.
1402         * coffread.c (patch_opaque_types): Make "b" const.
1403         * spu-tdep.c (spu_catch_start): Make "block" const.
1404         * c-valprint.c (print_unpacked_pointer): Remove "block".
1405         * symmisc.c (dump_symtab_1): Make "b" const.
1406         (block_depth): Make "block" const.
1407         * d-exp.y (%union) <bval>: Remove.
1408         * cp-support.h (cp_lookup_rtti_type): Update.
1409         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1410         * psymtab.c (psym_lookup_symbol): Make "block" const.
1411         (maintenance_check_psymtabs): Make "b" const.
1412         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1413         (enumerate_locals, enumerate_args): Update.
1414         * python/py-symtab.c (stpy_global_block): Make "block" const.
1415         (stpy_static_block): Likewise.
1416         * inline-frame.c (block_starting_point_at): Make "new_block"
1417         const.
1418         * block.c (find_block_in_blockvector): Make return type const.
1419         (blockvector_for_pc_sect): Make "b" const.
1420         (find_block_in_blockvector): Make "b" const.
1421
1422 2019-03-23  Tom Tromey  <tom@tromey.com>
1423
1424         * varobj.c (varobj_create): Update.
1425         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1426         * printcmd.c (display_command, do_one_display): Don't reset
1427         innermost_block.
1428         * parser-defs.h (enum innermost_block_tracker_type): Move to
1429         expression.h.
1430         (innermost_block): Update comment.
1431         * parse.c (parse_exp_1): Add tracker_types parameter.
1432         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1433         tracker_types parameter.  Reset innermost_block.
1434         (parse_exp_in_context): Remove.
1435         (parse_expression_for_completion): Update.
1436         * objfiles.c (~objfile): Don't reset expression_context_block or
1437         innermost_block.
1438         * expression.h (enum innermost_block_tracker_type): Move from
1439         parser-defs.h.
1440         (parse_exp_1): Add tracker_types parameter.
1441         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1442         reset innermost_block.
1443
1444 2019-03-23  Tom Tromey  <tom@tromey.com>
1445
1446         * objfiles.h: Include bcache.h.
1447
1448 2019-03-23  Tom Tromey  <tom@tromey.com>
1449
1450         * linespec.c (get_current_search_block): Use
1451         scoped_restore_current_language.
1452         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1453
1454 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1455             Jiong Wang  <jiong.wang@arm.com>
1456
1457         * aarch64-linux-tdep.c
1458         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1459         section.
1460         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1461
1462 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1463             Jiong Wang  <jiong.wang@arm.com>
1464
1465         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1466         instructions.
1467         (aarch64_analyze_prologue_test): Add PACIASP test.
1468         (aarch64_prologue_prev_register): Unmask PC value.
1469
1470 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1471             Jiong Wang  <jiong.wang@arm.com>
1472
1473         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1474         (aarch64_dwarf2_prev_register): Unmask PC value.
1475         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1476         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1477         DW_CFA_AARCH64_negate_ra_state.
1478         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1479
1480 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1481             Jiong Wang  <jiong.wang@arm.com>
1482
1483         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1484         registers.
1485         (aarch64_pseudo_register_name): Likewise.
1486         (aarch64_pseudo_register_type): Likewise.
1487         (aarch64_pseudo_register_reggroup_p): Likewise.
1488         (aarch64_gdbarch_init): Add pauth registers.
1489         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1490         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1491         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1492         (struct gdbarch_tdep): Add regnum for ra_state.
1493
1494 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1495             Jiong Wang  <jiong.wang@arm.com>
1496
1497         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1498
1499 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1500             Jiong Wang  <jiong.wang@arm.com>
1501
1502         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1503         function.
1504         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1505         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1506         (aarch64_gdbarch_init): Add puth registers.
1507         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1508         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1509         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1510
1511 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1512             Jiong Wang  <jiong.wang@arm.com>
1513
1514         * aarch64-linux-nat.c
1515         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1516         * aarch64-linux-tdep.c
1517         (aarch64_linux_core_read_description): Likewise.
1518         (aarch64_linux_get_hwcap): New function.
1519         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1520         (aarch64_linux_get_hwcap): New declaration.
1521
1522 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1523             Jiong Wang  <jiong.wang@arm.com>
1524
1525         * aarch64-linux-nat.c
1526         (aarch64_linux_nat_target::read_description): Add pauth param.
1527         * aarch64-linux-tdep.c
1528         (aarch64_linux_core_read_description): Likewise.
1529         * aarch64-tdep.c (struct target_desc): Add in pauth.
1530         (aarch64_read_description): Add pauth param.
1531         (aarch64_gdbarch_init): Likewise.
1532         * aarch64-tdep.h (aarch64_read_description): Likewise.
1533         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1534         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1535         * features/Makefile: Add new files.
1536         * features/aarch64-pauth.c: New file.
1537         * features/aarch64-pauth.xml: New file.
1538
1539 2019-03-20  Tom Tromey  <tromey@adacore.com>
1540
1541         * infrun.c (handle_inferior_event): Rename from
1542         handle_inferior_event_1.  Create a scoped_value_mark.
1543         (handle_inferior_event): Remove.
1544
1545 2019-03-19  Tom Tromey  <tromey@adacore.com>
1546
1547         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1548         * infrun.h (print_stop_event): Add "displays" parameter.
1549         * infrun.c (print_stop_event): Add "displays" parameter.
1550
1551 2019-03-19  Pedro Alves  <palves@redhat.com>
1552
1553         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1554         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1555         to -1.  Fix TABs vs spaces.
1556         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1557         * tui/tui-out.h (tui_ui_out) Add intro comments.
1558         <m_line, m_start_of_line>: In-class initialize, and add describing
1559         comment.
1560
1561 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1562
1563         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1564         variable names.
1565         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1566
1567 2019-03-18  Pedro Alves  <palves@redhat.com>
1568             Eli Zaretskii <eliz@gnu.org>
1569
1570         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1571         m_line and m_start_of_line.
1572
1573 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1574
1575         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1576         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1577         it returns a newline.  This fixes a regression in TU mode, whereby
1578         the next line is output on the same screen line as the user input.
1579
1580 2019-03-18  Tom Tromey  <tromey@adacore.com>
1581
1582         * minsyms.c (minimal_symbol_reader::install): Remove call to
1583         obstack_blank.
1584
1585 2019-03-18  Pedro Alves  <palves@redhat.com>
1586
1587         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1588         New globals.
1589         (apply_style): New, factored out from ...
1590         (apply_ansi_escape): ... this.  Handle reverse video mode.
1591         (tui_set_reverse_mode): New function.
1592         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1593         * tui/tui-winsource.c (tui_show_source_line): Use
1594         tui_set_reverse_mode instead of setting A_STANDOUT.
1595         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1596         New setter methods.
1597
1598 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1599
1600         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1601         Handle tabs.
1602
1603 2019-03-18  Tom Tromey  <tromey@adacore.com>
1604
1605         * ada-lang.c (empty_array): Add "high" parameter.
1606         (ada_evaluate_subexp): Update.
1607
1608 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1609
1610         * unittests/string_view-selftests.c: Define
1611         _initialize_string_view_selftests unconditionally.
1612
1613 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1614
1615         PR gdb/24350
1616         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1617
1618 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1619
1620         PR gdb/24351
1621         * windows-nat.c (display_selector): Fix format specifiers.
1622
1623 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1624
1625         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1626         tui_refill_source_window instead of tui_refresh_win, to update the
1627         current execution line.  This fixes redisplay of the current line
1628         when stepping through the code with "next" or "step".
1629
1630 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1631
1632         * source-cache.c (source_cache::get_source_lines): Call
1633         find_source_lines to initialize s->nlines.  This fixes vertical
1634         scrolling of TUI source window when the DOWN arrow is pressed.
1635
1636 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1637
1638         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1639         linux-thread-db.c (_initialize_thread_db): Likewise.
1640
1641 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1642
1643         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1644         wclrtoeol in tui_show_source_line".  This reverts changes made in
1645         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1646
1647 2019-03-15  Tom Tromey  <tom@tromey.com>
1648
1649         * symtab.h (struct minimal_symbol): Derive from
1650         general_symbol_info.
1651         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1652         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1653         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1654         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1655         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1656         (MSYMBOL_SEARCH_NAME): Update.
1657         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1658         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1659         * minsyms.c (minimal_symbol_reader::record_full): Update.
1660
1661 2019-03-15  Tom Tromey  <tom@tromey.com>
1662
1663         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1664
1665 2019-03-15  Tom Tromey  <tom@tromey.com>
1666
1667         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1668         unique_xmalloc_ptr.
1669         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1670         Update.
1671         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1672         (build_minimal_symbol_hash_tables)
1673         (minimal_symbol_reader::install): Update.
1674
1675 2019-03-15  Tom Tromey  <tom@tromey.com>
1676
1677         * symtab.c (create_demangled_names_hash): Update.
1678         (symbol_set_names): Update.
1679         * objfiles.h (struct objfile_per_bfd_storage)
1680         <demangled_names_hash>: Now an htab_up.
1681         * objfiles.c (objfile_per_bfd_storage): Simplify.
1682
1683 2019-03-15  Tom Tromey  <tom@tromey.com>
1684
1685         * objfiles.h (struct objfile_per_bfd_storage): Declare
1686         destructor.
1687         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1688         New.
1689         (get_objfile_bfd_data): Use new.  Don't initialize
1690         language_of_main.
1691         (free_objfile_per_bfd_storage): Remove.
1692         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1693
1694 2019-03-15  Tom Tromey  <tom@tromey.com>
1695
1696         * symfile.c (reread_symbols): Update.
1697         * objfiles.c (objfile::objfile): Update.
1698         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1699         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1700         comment.
1701         (minimal_symbol_reader::install): Update.
1702         (terminate_minimal_symbol_table): Remove.
1703         * jit.c (jit_object_close_impl): Update.
1704
1705 2019-03-15  Tom Tromey  <tom@tromey.com>
1706
1707         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1708         initializations.
1709
1710 2019-03-15  Tom Tromey  <tom@tromey.com>
1711
1712         * objfiles.h (struct objfile_per_bfd_storage)
1713         <demangled_hash_languages>: Now a bitset.
1714         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1715         (lookup_minimal_symbol): Update.
1716
1717 2019-03-15  Tom Tromey  <tom@tromey.com>
1718
1719         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1720         Don't return the symbol.
1721         * coffread.c (record_minimal_symbol): Use record_full.
1722
1723 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1724
1725         The MS-Windows port of ncurses fails to switch to a color pair if
1726         one or both of the colors are the implicit default colors.  This
1727         change records the default colors when TUI is initialized, and
1728         then specifies them explicitly when a color pair uses the default
1729         colors.  This allows color styling in TUI mode on MS-Windows.
1730
1731         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1732         ncurses_norm_attr.
1733         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1734         colors in ncurses_norm_attr.
1735         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1736         "none", replace it with the default color recorded in
1737         ncurses_norm_attr.
1738
1739 2019-03-14  Tom Tromey  <tromey@adacore.com>
1740
1741         * source-cache.h (class source_cache) <get_source_lines>: Return
1742         std::string.
1743         * source-cache.c (source_cache::extract_lines): Handle case where
1744         first_pos==npos.  Return std::string.
1745         (source_cache::get_source_lines): Update.
1746
1747 2019-03-14  Tom Tromey  <tromey@adacore.com>
1748
1749         * NEWS: Add item for "style sources" commands.
1750         * source-cache.c (source_cache::get_source_lines): Check
1751         source_styling.
1752         * cli/cli-style.c (source_styling): New global.
1753         (_initialize_cli_style): Add "style sources" commands.
1754         (show_style_sources): New function.
1755         * cli/cli-style.h (source_styling): Declare.
1756
1757 2019-03-14  Pedro Alves  <palves@redhat.com>
1758             Tom Tromey  <tromey@adacore.com>
1759
1760         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1761         * tui/tui-winsource.c (tui_refill_source_window): New function,
1762         from...
1763         (tui_horizontal_source_scroll): ... here.  Move some logic.
1764         * cli/cli-style.c (set_style_enabled): Notify new observable.
1765         * tui/tui-hooks.c (tui_redisplay_source): New function.
1766         (tui_attach_detach_observers): Attach or detach
1767         tui_redisplay_source.
1768         * observable.h (source_styling_changed): New observable.
1769         * observable.c: Define source_styling_changed observable.
1770
1771 2019-03-13  Tom Tromey  <tromey@adacore.com>
1772
1773         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1774         (i386_gnu_nat_target::store_registers): Update.
1775         * target-debug.h (target_debug_print_std_string): New macro.
1776         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1777         * windows-tdep.c (display_one_tib): Update.
1778         * tui/tui-stack.c (tui_make_status_line): Update.
1779         * top.c (print_inferior_quit_action): Update.
1780         * thread.c (thr_try_catch_cmd): Update.
1781         (add_thread_with_info): Update.
1782         (thread_target_id_str): Update.
1783         (thr_try_catch_cmd): Update.
1784         (thread_command): Update.
1785         (thread_find_command): Update.
1786         * record-btrace.c (record_btrace_target::info_record)
1787         (record_btrace_resume_thread, record_btrace_target::resume)
1788         (record_btrace_cancel_resume, record_btrace_step_thread)
1789         (record_btrace_target::wait, record_btrace_target::wait)
1790         (record_btrace_target::wait, record_btrace_target::stop): Update.
1791         * progspace.c (print_program_space): Update.
1792         * process-stratum-target.c
1793         (process_stratum_target::thread_address_space): Update.
1794         * linux-fork.c (linux_fork_mourn_inferior)
1795         (detach_checkpoint_command, info_checkpoints_command)
1796         (linux_fork_context): Update.
1797         (linux_fork_detach): Update.
1798         (class scoped_switch_fork_info): Update.
1799         (delete_checkpoint_command): Update.
1800         * infrun.c (follow_fork_inferior): Update.
1801         (follow_fork_inferior): Update.
1802         (proceed_after_vfork_done): Update.
1803         (handle_vfork_child_exec_or_exit): Update.
1804         (follow_exec): Update.
1805         (displaced_step_prepare_throw): Update.
1806         (displaced_step_restore): Update.
1807         (start_step_over): Update.
1808         (resume_1): Update.
1809         (clear_proceed_status_thread): Update.
1810         (proceed): Update.
1811         (print_target_wait_results): Update.
1812         (do_target_wait): Update.
1813         (context_switch): Update.
1814         (stop_all_threads): Update.
1815         (restart_threads): Update.
1816         (finish_step_over): Update.
1817         (handle_signal_stop): Update.
1818         (switch_back_to_stepped_thread): Update.
1819         (keep_going_pass_signal): Update.
1820         (print_exited_reason): Update.
1821         (normal_stop): Update.
1822         * inferior.c (inferior_pid_to_str): Change return type.
1823         (print_selected_inferior): Update.
1824         (add_inferior): Update.
1825         (detach_inferior): Update.
1826         * dummy-frame.c (fprint_dummy_frames): Update.
1827         * dcache.c (dcache_info_1): Update.
1828         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1829         (btrace_fetch, btrace_clear): Update.
1830         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1831         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1832         type.
1833         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1834         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1835         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1836         * gdbarch.c, gdbarch.h: Rebuild.
1837         * gdbarch.sh (core_pid_to_str): Change return type.
1838         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1839         return type.
1840         (windows_nat_target::pid_to_str): Change return type.
1841         (windows_delete_thread): Update.
1842         (windows_nat_target::attach): Update.
1843         (windows_nat_target::files_info): Update.
1844         * target-delegates.c: Rebuild.
1845         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1846         return type.
1847         (sol_thread_target::pid_to_str): Change return type.
1848         * remote.c (class remote_target) <pid_to_str>: Change return
1849         type.
1850         (remote_target::pid_to_str): Change return type.
1851         (extended_remote_target::attach, remote_target::remote_stop_ns)
1852         (remote_target::remote_notif_remove_queued_reply)
1853         (remote_target::push_stop_reply, remote_target::disable_btrace):
1854         Update.
1855         (extended_remote_target::attach): Update.
1856         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1857         type.
1858         (gdbsim_target::pid_to_str): Change return type.
1859         * ravenscar-thread.c (struct ravenscar_thread_target)
1860         <pid_to_str>: Change return type.
1861         (ravenscar_thread_target::pid_to_str): Change return type.
1862         * procfs.c (class procfs_target) <pid_to_str>: Change return
1863         type.
1864         (procfs_target::pid_to_str): Change return type.
1865         (procfs_target::attach): Update.
1866         (procfs_target::detach): Update.
1867         (procfs_target::fetch_registers): Update.
1868         (procfs_target::store_registers): Update.
1869         (procfs_target::wait): Update.
1870         (procfs_target::files_info): Update.
1871         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1872         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1873         return type.
1874         (nto_procfs_target::pid_to_str): Change return type.
1875         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1876         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1877         return type.
1878         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1879         (exit_lwp): Update.
1880         (attach_proc_task_lwp_callback, get_detach_signal)
1881         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1882         (linux_nat_target::resume, wait_lwp, stop_callback)
1883         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1884         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1885         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1886         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1887         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1888         type.
1889         (inf_ptrace_target::attach): Update.
1890         (inf_ptrace_target::files_info): Update.
1891         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1892         type.
1893         (go32_nat_target::pid_to_str): Change return type.
1894         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1895         (gnu_nat_target::wait): Update.
1896         (gnu_nat_target::wait): Update.
1897         (gnu_nat_target::resume): Update.
1898         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1899         (fbsd_nat_target::wait): Update.
1900         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1901         type.
1902         (darwin_nat_target::attach): Update.
1903         * corelow.c (class core_target) <pid_to_str>: Change return type.
1904         (core_target::pid_to_str): Change return type.
1905         * target.c (normal_pid_to_str): Change return type.
1906         (default_pid_to_str): Likewise.
1907         (target_pid_to_str): Change return type.
1908         (target_translate_tls_address): Update.
1909         (target_announce_detach): Update.
1910         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1911         return type.
1912         (bsd_uthread_target::pid_to_str): Change return type.
1913         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1914         type.
1915         (bsd_kvm_target::pid_to_str): Change return type.
1916         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1917         return type.
1918         (aix_thread_target::pid_to_str): Change return type.
1919         * target.h (struct target_ops) <pid_to_str>: Change return type.
1920         (target_pid_to_str, normal_pid_to_str): Likewise.
1921         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1922         type.
1923         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1924         type.
1925         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1926         return type.
1927         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1928         type.
1929         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1930         type.
1931         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1932         return type.
1933
1934 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1935
1936         * NEWS: Mention that the new default MI version is 3.  Mention
1937         changes to the output of commands and events that deal with
1938         multi-location breakpoints.
1939         * breakpoint.c: Include "mi/mi-out.h".
1940         (print_one_breakpoint): Change output syntax if using MI version
1941         >= 3.
1942         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1943         New.
1944         (mi_multi_location_breakpoint_output_fixed): New.
1945         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1946         (mi_cmd_fix_multi_location_breakpoint_output): New.
1947         (mi_multi_location_breakpoint_output_fixed): New.
1948         * mi/mi-cmds.c (mi_cmds): Register command
1949         -fix-multi-location-breakpoint-output.
1950         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1951         interpreter "mi".
1952
1953 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1954
1955         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1956         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1957         instantiate mi_ui_out based on interpreter name.
1958         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1959         * mi/mi-main.c (mi_load_progress): Likewise.
1960
1961 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1962
1963         * NEWS: Combine separate "New targets" sections for 8.3.
1964
1965 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1966
1967         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1968         (ppcfbsd_init_abi): Install gdbarch
1969         "fetch_tls_load_module_address" and "get_thread_local_address"
1970         methods.
1971
1972 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1973
1974         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1975         (riscv_fbsd_init_abi): Install gdbarch
1976         "fetch_tls_load_module_address" and "get_thread_local_address"
1977         methods.
1978
1979 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1980
1981         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1982         (i386fbsd_init_abi): Install gdbarch
1983         "fetch_tls_load_module_address" and "get_thread_local_address"
1984         methods.
1985
1986 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1987
1988         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1989         (amd64fbsd_init_abi): Install gdbarch
1990         "fetch_tls_load_module_address" and "get_thread_local_address"
1991         methods.
1992
1993 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1994
1995         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1996         (struct fbsd_pspace_data): New type.
1997         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1998         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1999         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2000         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2001         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2002
2003 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2004
2005         * gdbtypes.c (lookup_struct_elt): New function.
2006         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2007         * gdbtypes.h (struct struct_elt): New type.
2008         (lookup_struct_elt): New prototype.
2009
2010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2011
2012         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2013         remove disabled code block.
2014
2015 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2016
2017         * gdbarch.sh (get_thread_local_address): New method.
2018         * gdbarch.h, gdbarch.c: Regenerate.
2019         * target.c (target_translate_tls_address): Use
2020         gdbarch_get_thread_local_address if present instead of
2021         target::get_thread_local_address.
2022
2023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2024
2025         * target.h (target::get_thread_local_address): Update comment.
2026
2027 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2028
2029         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2030         objfile->separate_debug_objfile_backlink if not NULL.
2031
2032 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2033
2034         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2035         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2036         (amd64bsd_store_inferior_registers): Likewise.
2037         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2038         Enable segment base registers.
2039         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2040         PT_GETFSBASE and PT_GETGSBASE.
2041         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2042         PT_SETGSBASE.
2043         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2044         segment base registers.
2045         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2046
2047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2048
2049         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2050         Update calls to i386_target_description to add 'segments'
2051         parameter.
2052         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2053         add segment base registers.
2054         * arch/i386.c (i386_create_target_description): Add 'segments'
2055         parameter to enable segment base registers.
2056         * arch/i386.h (i386_create_target_description): Likewise.
2057         * features/i386/32bit-segments.xml: New file.
2058         * features/i386/32bit-segments.c: Generate.
2059         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2060         call to i386_target_description to add 'segments' parameter.
2061         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2062         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2063         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2064         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2065         if feature is present.
2066         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2067         Add 'segments' parameter to call to i386_target_description.
2068         (i386_target_description): Add 'segments' parameter to enable
2069         segment base registers.
2070         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2071         to call to i386_target_description.
2072         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2073         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2074         Define I386_NUM_REGS.
2075         (i386_target_description): Add 'segments' parameter to enable
2076         segment base registers.
2077
2078 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2079
2080         PR/24325
2081         * source-cache.c: #undef open and close, to avoid unresolved
2082         externals during linking.
2083
2084 2019-03-12  Tom Tromey  <tromey@adacore.com>
2085
2086         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2087         const.  Add initializers.
2088         (_initialize_remote): Don't initialize ptid globals.
2089
2090 2019-03-12  Pedro Alves  <palves@redhat.com>
2091
2092         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2093
2094 2019-03-12  Pedro Alves  <palves@redhat.com>
2095
2096         * cp-name-parser.y (main): Remove unused 'len' variable.
2097
2098 2019-03-12  Tom Tromey  <tromey@adacore.com>
2099
2100         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2101         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2102
2103 2019-03-12  Tom Tromey  <tromey@adacore.com>
2104
2105         * linux-nat.c (iterate_over_lwps): Update.
2106         (stop_callback): Remove parameter.
2107         (stop_wait_callback, detach_callback, resume_set_callback)
2108         (select_singlestep_lwp_callback, set_ignore_sigint)
2109         (status_callback, resumed_callback, resume_clear_callback)
2110         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2111         data parameter.
2112         (linux_nat_target::detach, linux_nat_target::resume)
2113         (linux_stop_and_wait_all_lwps, select_event_lwp)
2114         (linux_nat_filter_event, linux_nat_wait_1)
2115         (linux_nat_target::kill, linux_nat_target::stop)
2116         (linux_nat_target::stop): Update.
2117         (linux_nat_resume_callback): Change type.
2118         (resume_stopped_resumed_lwps, count_events_callback)
2119         (select_event_lwp_callback): Likewise.
2120         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2121         * arm-linux-nat.c (struct update_registers_data): Remove.
2122         (update_registers_callback): Change type.
2123         (arm_linux_insert_hw_breakpoint1): Update.
2124         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2125         parameter.
2126         (x86_linux_dr_set_addr): Update.
2127         (x86_linux_dr_set_control): Update.
2128         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2129         (iterate_over_lwps): Use gdb::function_view.
2130         * nat/aarch64-linux-hw-point.c (struct
2131         aarch64_dr_update_callback_param): Remove.
2132         (debug_reg_change_callback): Change type.
2133         (aarch64_notify_debug_reg_change): Update.
2134         * s390-linux-nat.c (s390_refresh_per_info): Update.
2135
2136 2019-03-11  Tom Tromey  <tromey@adacore.com>
2137
2138         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2139         redundant assignment to "this_cu".
2140
2141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2142
2143         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2144
2145 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2146
2147         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2148         from...
2149         (rank_one_type): ... this.
2150
2151 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2152
2153         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2154         from...
2155         (rank_one_type): ... this.
2156
2157 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2158
2159         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2160         from...
2161         (rank_one_type): ... this.
2162
2163 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2164
2165         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2166         from...
2167         (rank_one_type): ... this.
2168
2169 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2170
2171         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2172         from...
2173         (rank_one_type): ... this.
2174
2175 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2176
2177         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2178         from...
2179         (rank_one_type): ... this.
2180
2181 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2182
2183         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2184         from...
2185         (rank_one_type): ... this.
2186
2187 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2188
2189         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2190         from...
2191         (rank_one_type): ... this.
2192
2193 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2194
2195         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2196         from...
2197         (rank_one_type): ... this.
2198
2199 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2200
2201         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2202         from...
2203         (rank_one_type): ... this.
2204
2205 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2206
2207         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2208         from...
2209         (rank_one_type): ... this.
2210
2211 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2212
2213         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2214         from...
2215         (rank_one_type): ... this.
2216
2217 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2218
2219         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2220         inferior-events' shows the example events.
2221
2222 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2223
2224         Support styling on native MS-Windows console
2225
2226         PR/24315
2227         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2228         on MS-Windows if $TERM is not defined.
2229
2230         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2231
2232         * posix-hdep.c (gdb_console_fputs):
2233         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2234         functions.
2235         * ui-file.h (gdb_console_fputs): Add prototype.
2236
2237         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2238         back to fputs only if the former returns zero.
2239
2240 2019-03-07  Tom Tromey  <tom@tromey.com>
2241
2242         * symmisc.c (print_symbol_bcache_statistics): Update.
2243         (print_objfile_statistics): Update.
2244         * symfile.c (allocate_symtab): Update.
2245         * stabsread.c: Don't include bcache.h.
2246         * psymtab.h (struct psymbol_bcache): Don't declare.
2247         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2248         (psymbol_bcache_init, psymbol_bcache_free)
2249         (psymbol_bcache_get_bcache): Don't declare.
2250         * psymtab.c (struct psymbol_bcache): Remove.
2251         (psymtab_storage::psymtab_storage): Update.
2252         (psymtab_storage::~psymtab_storage): Update.
2253         (psymbol_bcache_init, psymbol_bcache_free)
2254         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2255         (add_psymbol_to_bcache): Update.
2256         (allocate_psymtab): Update.
2257         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2258         macro_cache>: No longer pointers.
2259         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2260         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2261         * macrotab.c (macro_bcache): Update.
2262         * macroexp.c: Don't include bcache.h.
2263         * gdbtypes.c (check_types_worklist): Update.
2264         (types_deeply_equal): Remove TRY/CATCH.  Update.
2265         * elfread.c (elf_symtab_read): Update.
2266         * dwarf2read.c: Don't include bcache.h.
2267         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2268         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2269         (print_bcache_statistics, bcache_memory_used): Don't declare.
2270         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2271         methods.  Rename all data members.
2272         * bcache.c (struct bcache): Move to bcache.h.
2273         (bcache::expand_hash_table): Rename from expand_hash_table.
2274         (bcache): Remove.
2275         (bcache::insert): Rename from bcache_full.
2276         (bcache::compare): Rename from bcache_compare.
2277         (bcache_xmalloc): Remove.
2278         (bcache::~bcache): Rename from bcache_xfree.
2279         (bcache::print_statistics): Rename from print_bcache_statistics.
2280         (bcache::memory_used): Rename from bcache_memory_used.
2281
2282 2019-03-07  Pedro Alves  <palves@redhat.com>
2283
2284         * infrun.c (normal_stop): Also check for
2285         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2286
2287 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2288
2289         * f-lang.c (value_from_host_double): Moved to...
2290         * value.c (value_from_host_double): ...here.
2291         * value.h (value_from_host_double): Declare.
2292         * guile/scm-math.c (vlscm_convert_typed_number): Use
2293         value_from_host_double.
2294         (vlscm_convert_number): Likewise.
2295         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2296         * python/py-value.c (convert_value_from_python): Likewise.
2297
2298 2019-03-06  Tom Tromey  <tom@tromey.com>
2299
2300         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2301
2302 2019-03-06  Tom Tromey  <tom@tromey.com>
2303
2304         * utils.h (free_current_contents): Don't declare.
2305         * utils.c (free_current_contents): Remove.
2306
2307 2019-03-06  Tom Tromey  <tom@tromey.com>
2308
2309         * top.c (quit_force): Update.
2310         * main.c (captured_command_loop): Update.
2311         * common/new-op.c (operator new): Update.
2312         * common/common-exceptions.c (struct catcher)
2313         <save_cleanup_chain>: Remove member.
2314         (exceptions_state_mc_init): Update.
2315         (exception_try_scope_entry): Return nullptr.
2316         (exception_try_scope_exit, exception_rethrow)
2317         (throw_exception_sjlj, throw_exception_cxx): Update.
2318         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2319         (all_cleanups, do_cleanups, discard_cleanups)
2320         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2321         (restore_cleanups, restore_final_cleanups): Don't declare.
2322         (do_final_cleanups): Remove parameter.
2323         * common/cleanups.c (cleanup_chain, make_cleanup)
2324         (make_cleanup_dtor, all_cleanups, do_cleanups)
2325         (discard_my_cleanups, discard_cleanups)
2326         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2327         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2328         (null_cleanup): Remove.
2329         (do_final_cleanups): Remove parameter.
2330
2331 2019-03-06  Tom Tromey  <tom@tromey.com>
2332
2333         * remote.c (remote_target::remote_parse_stop_reply): Use
2334         unique_xmalloc_ptr.
2335
2336 2019-03-06  Tom Tromey  <tom@tromey.com>
2337
2338         * stabsread.c (struct stabs_field_info): Rename from field_info.
2339         <list, fnlist>: Add initializers.
2340         <obstack>: New member.
2341         (read_member_functions, read_struct_fields, read_baseclasses):
2342         Allocate on obstack.  Don't use cleanups.
2343         (read_one_struct_field, read_member_functions, read_struct_fields)
2344         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2345         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2346         (read_struct_type): Update.
2347
2348 2019-03-06  Tom Tromey  <tom@tromey.com>
2349
2350         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2351         * common/filestuff.h (make_cleanup_close): Don't declare.
2352         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2353         Remove.
2354
2355 2019-03-06  Tom Tromey  <tom@tromey.com>
2356
2357         * solib-aix.c: Use make_scope_exit.
2358
2359 2019-03-06  Tom Tromey  <tom@tromey.com>
2360
2361         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2362         Use make_scope_exit.
2363
2364 2019-03-06  Tom Tromey  <tom@tromey.com>
2365
2366         * solib-svr4.c (disable_probes_interface): Remove parameter.
2367         (svr4_handle_solib_event): Use make_scope_exit.
2368
2369 2019-03-06  Tom Tromey  <tom@tromey.com>
2370
2371         * remote.c (struct stop_reply_deleter): Remove.
2372         (stop_reply_up): Update.
2373         (struct stop_reply): Derive from notif_event.  Don't typedef.
2374         <regcache>: Now a std::vector.
2375         (stop_reply_xfree): Remove.
2376         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2377         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2378         (remote_target::discard_pending_stop_replies): Use delete.
2379         (remote_target::remote_parse_stop_reply): Update.
2380         (remote_target::process_stop_reply): Update.
2381         * remote-notif.h (struct notif_event): Add virtual destructor.
2382         Remove "dtr" member.
2383         (struct notif_client) <alloc_event>: Return a unique_ptr.
2384         (notif_event_xfree): Don't declare.
2385         (notif_event_up): New typedef.
2386         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2387         (notif_event_xfree, do_notif_event_xfree): Remove.
2388         (remote_notif_state_xfree): Update.
2389
2390 2019-03-06  Tom Tromey  <tom@tromey.com>
2391
2392         * infrun.c (displaced_step_clear_cleanup): Now a
2393         forward_scope_exit type.
2394         (displaced_step_prepare_throw): Update.
2395         (displaced_step_fixup): Update.
2396
2397 2019-03-06  Tom Tromey  <tom@tromey.com>
2398
2399         * inferior.h (class inferior): Update comment.
2400         * gdbthread.h (class thread_info): Update comment.
2401
2402 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2403             Tom Tromey  <tom@tromey.com>
2404
2405         * stabsread.h (struct stab_section_list): Remove.
2406         (coffstab_build_psymtabs): Update.
2407         * dbxread.c (symbuf_sections): Now a std::vector.
2408         (sect_idx): New global.
2409         (fill_symbuf): Update.
2410         (coffstab_build_psymtabs): Change type of stabsects parameter.
2411         Update.
2412         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2413         std::vector.
2414         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2415         (coff_locate_sections): Update.
2416         (coff_symfile_read): Remove cleanups.  Update.
2417         (init_stringtab): Add storage parameter.
2418         (free_stringtab, free_stringtab_cleanup): Remove.
2419         (init_lineno): Add storage parameter.
2420         (free_linetab, free_linetab_cleanup): Remove.
2421
2422 2019-03-06  Pedro Alves  <palves@redhat.com>
2423
2424         * linux-fork.c (fork_info::clobber_regs): Delete.
2425         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2426         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2427         comment.  Adjust.
2428         (scoped_switch_fork_info::scoped_switch_fork_info)
2429         (checkpoint_command, linux_fork_context): Adjust
2430         fork_save_infrun_state calls.
2431
2432 2019-03-06  Pedro Alves  <palves@redhat.com>
2433
2434         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2435         (inf_has_multiple_threads): Return 'bool' and rewrite using
2436         inferior_info::threads().
2437
2438 2019-03-06  Pedro Alves  <palves@redhat.com>
2439
2440         * linux-fork.c: Include <list>.
2441         (fork_list): Now a std::list instance.
2442         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2443         (forks_exist_p, find_last_fork): Adjust.
2444         (new_fork): Delete.
2445         (one_fork_p): New.
2446         (add_fork): Adjust.
2447         (free_fork): Delete, folded into fork_info::~fork_info().
2448         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2449         Adjust.
2450         (init_fork_list): Delete.
2451         (linux_fork_killall, linux_fork_mourn_inferior)
2452         (linux_fork_detach, info_checkpoints_command): Adjust.
2453         (_initialize_linux_fork): No longer call init_fork_list.
2454
2455 2019-03-06  Pedro Alves  <palves@redhat.com>
2456
2457         * linux-fork.c (new_fork): New, split out of ...
2458         (add_fork): ... this.  Return void.  Move "first fork" special
2459         case from here, to ...
2460         (checkpoint_command): ... here.
2461         * linux-linux.h (add_fork): Return void.
2462
2463 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2464
2465         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2466
2467 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2468             Chris January  <chris.january@arm.com>
2469             David Lecomber  <david.lecomber@arm.com>
2470
2471         * f-exp.y: New token, UNOP_INTRINSIC.
2472         (exp): New pattern using UNOP_INTRINSIC token.
2473         (f77_keywords): Add 'abs' keyword.
2474         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2475         (value_from_host_double): New function.
2476         (evaluate_subexp_f): Support UNOP_ABS.
2477
2478 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2479
2480         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2481         types.
2482
2483 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2484
2485         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2486         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2487         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2488
2489 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2490
2491         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2492
2493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2494             Chris January  <chris.january@arm.com>
2495
2496         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2497         * f-exp.y: Define 'KIND' token.
2498         (exp): New pattern for KIND expressions.
2499         (ptype): Handle types with a kind extension.
2500         (direct_abs_decl): Extend to spot kind extensions.
2501         (f77_keywords): Add 'kind' to the list.
2502         (push_kind_type): New function.
2503         (convert_to_kind_type): New function.
2504         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2505         * parse.c (operator_length_standard): Likewise.
2506         * parser-defs.h (enum type_pieces): Add tp_kind.
2507         * std-operator.def: Add UNOP_KIND.
2508
2509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * f-exp.y (f_parse): Set yydebug.
2512
2513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2514
2515         * f-lang.c (evaluate_subexp_f): New function.
2516         (exp_descriptor_f): New global.
2517         (f_language_defn): Use exp_descriptor_f instead of
2518         exp_descriptor_standard.
2519
2520 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2521
2522         * f-exp.y (struct token): Add comments.
2523         (dot_ops): Remove uppercase versions and the end marker.
2524         (f77_keywords): Likewise.
2525         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2526         entries in the dot_ops array are case insensitive, and use
2527         strncasecmp to compare strings.  Also some whitespace cleanup in
2528         this area.  Similar for the f77_keywords array, except entries in
2529         this list might be case sensitive.
2530
2531 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2532
2533         * f-exp.y (struct f77_boolean_val): Add comments.
2534         (boolean_values): Remove uppercase versions, and end marker.
2535         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2536         and use strncasecmp to achieve case insensitivity.  Additionally,
2537         perform whitespace cleanup around this code.
2538
2539 2019-03-06  Tom Tromey  <tromey@adacore.com>
2540
2541         * remote-sim.c (gdbsim_target_open): Use result of
2542         gdb_argv::release.
2543
2544 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2545         Dirk Schubert  <dirk.schubert@arm.com>
2546         Chris January  <chris.january@arm.com>
2547
2548         * eval.c (evaluate_subexp_standard): Call Fortran argument
2549         wrapping logic.
2550         * f-lang.c (struct value): A value which can be passed into a
2551         Fortran function call.
2552         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2553         where appropriate.
2554         (struct type): Value ready for a Fortran function call.
2555         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2556         is needed.
2557         * f-lang.h (fortran_argument_convert): Declaration.
2558         (fortran_preserve_arg_pointer): Declaration.
2559         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2560
2561 2019-03-05  Tom Tromey  <tromey@adacore.com>
2562
2563         * python/py-prettyprint.c (print_string_repr): Remove #if.
2564         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2565
2566 2019-03-05  Tom Tromey  <tromey@adacore.com>
2567
2568         * target.c (the_dummy_target): Move later.  Change type to
2569         "dummy_target".
2570         (initialize_targets): Don't initialize the_dummy_target.
2571
2572 2019-03-05  Tom Tromey  <tromey@adacore.com>
2573
2574         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2575         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2576
2577 2019-03-05  Tom Tromey  <tromey@adacore.com>
2578
2579         * windows-nat.c (windows_nat_target::attach)
2580         (windows_nat_target::detach): Don't call gdb_flush.
2581         * valprint.c (generic_val_print, val_print, val_print_string):
2582         Don't call gdb_flush.
2583         * utils.c (defaulted_query): Don't call gdb_flush.
2584         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2585         * target.c (target_announce_detach): Don't call gdb_flush.
2586         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2587         * remote.c (extended_remote_target::attach): Don't call
2588         gdb_flush.
2589         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2590         * printcmd.c (do_examine): Don't call gdb_flush.
2591         (info_display_command): Don't call gdb_flush.
2592         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2593         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2594         * memattr.c (info_mem_command): Don't call gdb_flush.
2595         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2596         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2597         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2598         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2599         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2600         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2601         (gnu_nat_target::detach): Don't call gdb_flush.
2602         * f-valprint.c (f_val_print): Don't call gdb_flush.
2603         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2604         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2605         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2606         gdb_flush.
2607         * c-valprint.c (c_val_print): Don't call gdb_flush.
2608         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2609
2610 2019-03-05  Tom Tromey  <tromey@adacore.com>
2611
2612         * varobj.c (update_dynamic_varobj_children): Update.
2613         (install_default_visualizer): Use reset, not release.
2614         * value.c (set_internalvar): Update.
2615         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2616         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2617         ATTRIBUTE_UNUSED_RESULT.
2618
2619 2019-03-05  Tom Tromey  <tromey@adacore.com>
2620
2621         * remote.c (class scoped_remote_fd) <release>: Add
2622         ATTRIBUTE_UNUSED_RESULT.
2623
2624 2019-03-05  Tom Tromey  <tromey@adacore.com>
2625
2626         * macroexp.c (struct macro_buffer) <release>: Add
2627         ATTRIBUTE_UNUSED_RESULT.
2628
2629 2019-03-05  Tom Tromey  <tromey@adacore.com>
2630
2631         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2632         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2633         ATTRIBUTE_UNUSED_RESULT.
2634
2635 2019-03-05  Tom Tromey  <tromey@adacore.com>
2636
2637         * common/scoped_fd.h (class scoped_fd) <release>: Add
2638         ATTRIBUTE_UNUSED_RESULT.
2639
2640 2019-03-05  Tom Tromey  <tromey@adacore.com>
2641
2642         * parser-defs.h (struct parser_state) <release>: Add
2643         ATTRIBUTE_UNUSED_RESULT.
2644
2645 2019-03-05  Tom Tromey  <tromey@adacore.com>
2646
2647         * utils.h (class gdb_argv) <release>: Add
2648         ATTRIBUTE_UNUSED_RESULT.
2649         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2650
2651 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2652
2653         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2654         for-loop range, to avoid compiler warnings.
2655
2656         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2657         avoid compiler warnings about unused variables.
2658
2659         * NEWS: Mention end of support for native debugging on MS-Windows
2660         before XP.
2661
2662         PR gdb/24292
2663         * common/netstuff.c:
2664         * gdbserver/gdbreplay.c
2665         * gdbserver/remote-utils.c:
2666         * ser-tcp.c:
2667         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2668         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2669         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2670         'getaddrinfo' and 'freeaddrinfo' were not available before
2671         Windows XP, and mingw.org's MinGW headers by default define
2672         _WIN32_WINNT to 0x500.
2673
2674 2019-03-01  Gary Benson <gbenson@redhat.com>
2675
2676         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2677
2678 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2679             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2680
2681         PR gdb/8527
2682         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2683         set_sigint_trap, clear_sigint_trap.
2684
2685 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2686
2687         * target.c (target_detach): Clear the regcache and the
2688         frame cache.
2689
2690 2019-02-27  Pedro Alves  <palves@redhat.com>
2691
2692         * utils.c (set_screen_size): When we cap the height/width sizes,
2693         tweak the corresponding command variable to show "unlimited":
2694
2695 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2696             Pedro Alves  <palves@redhat.com>
2697
2698         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2699         before calling rl_set_screen_size.
2700
2701 2019-02-27  Tom Tromey  <tromey@adacore.com>
2702
2703         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2704         define.
2705         * python/py-value.c: Remove Python 2.4 workaround.
2706         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2707         workaround.
2708         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2709         Python 2.4 workaround.
2710         * python/python-internal.h: Remove Python 2.4 comment.
2711         (Py_ssize_t): Don't define.
2712         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2713         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2714         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2715         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2716         * python/python.c (do_start_initialization): Remove Python 2.4
2717         workaround.
2718         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2719         (print_children): Remove Python 2.4 workaround.
2720         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2721         workaround.
2722         (CHARBUFFERPROC_NAME): Remove.
2723         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2724         Python 2.4 workaround.
2725
2726 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2727
2728         * NEWS: Note minimum Python version.
2729
2730 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2731
2732         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2733         code from these functions.  Remove corresponding ifdefs.  Use
2734         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2735         Remove gotos and target of gotos.
2736         (infpy_search_memory): Likewise.
2737
2738 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2739
2740         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2741         (hppa_gdbarch_init): Don't register deleted functions with
2742         gdbarch.
2743
2744 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2745
2746         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2747         (h8300_unwind_sp): Delete.
2748         (h8300_dummy_id): Delete.
2749         (h8300_gdbarch_init): Don't register deleted functions with
2750         gdbarch.
2751
2752 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2753
2754         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2755         (ft32_unwind_pc): Delete.
2756         (ft32_unwind_sp): Delete.
2757         (ft32_gdbarch_init): Don't register deleted functions with
2758         gdbarch.
2759
2760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2761
2762         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2763         (frv_unwind_pc): Delete.
2764         (frv_unwind_sp): Delete.
2765         (frv_gdbarch_init): Don't register deleted functions with
2766         gdbarch.
2767
2768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2769
2770         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2771         (riscv_unwind_pc): Delete.
2772         (riscv_unwind_sp): Delete.
2773         (riscv_gdbarch_init): Don't register deleted functions with
2774         gdbarch.
2775
2776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2777
2778         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2779         (csky_unwind_pc): Delete.
2780         (csky_unwind_sp): Delete.
2781         (csky_gdbarch_init): Don't register deleted functions with
2782         gdbarch.
2783
2784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2785
2786         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2787         (cris_unwind_pc): Delete.
2788         (cris_unwind_sp): Delete.
2789         (cris_gdbarch_init): Don't register deleted functions with
2790         gdbarch.
2791
2792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2793
2794         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2795         (bfin_unwind_pc): Delete.
2796         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2797
2798 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2799
2800         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2801         (arm_unwind_pc): Delete.
2802         (arm_unwind_sp): Delete.
2803         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2804
2805 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2806
2807         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2808         (arc_unwind_pc): Delete.
2809         (arc_unwind_sp): Delete.
2810         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2811
2812 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2813
2814         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2815         (alpha_unwind_pc): Delete.
2816         (alpha_gdbarch_init): Don't register deleted functions with
2817         gdbarch.
2818
2819 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2820
2821         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2822         (aarch64_unwind_pc): Delete.
2823         (aarch64_unwind_sp): Delete.
2824         (aarch64_gdbarch_init): Don't register deleted functions with
2825         gdbarch.
2826
2827 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2828
2829         * gdbtypes.c (type_align): Don't consider static members when
2830         computing structure alignment.
2831
2832 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2833
2834         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2835         return 0 for other types.
2836         * arch-utils.c (default_type_align): Always return 0.
2837         * gdbarch.h: Regenerate.
2838         * gdbarch.sh (type_align): Extend comment.
2839         * gdbtypes.c (type_align): Add additional comments, always call
2840         gdbarch_type_align before applying the default rules.
2841         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2842         generic code will then apply a suitable default.
2843         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2844         types, return 0 for other types.
2845
2846 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2847
2848         * NEWS: Create a new section for the next release branch.
2849         Rename the section of the current branch, now that it has
2850         been cut.
2851
2852 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2853
2854         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2855         * version.in: Bump version to 8.3.50.DATE-git.
2856
2857 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2858
2859         * aix-thread.c (ptid_cmp): Remove unused variable.
2860         (get_signaled_thread): Likewise.
2861         (store_regs_user_thread): Likewise.
2862         (store_regs_kernel_thread): Likewise.
2863         (fetch_regs_kernel_thread): Remove shadowed variable.
2864
2865 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2866
2867         * features/riscv/32bit-cpu.xml: Add register numbers.
2868         * features/riscv/32bit-fpu.c: Regenerate.
2869         * features/riscv/32bit-fpu.xml: Add register numbers.
2870         * features/riscv/64bit-cpu.xml: Add register numbers.
2871         * features/riscv/64bit-fpu.c: Regenerate.
2872         * features/riscv/64bit-fpu.xml: Add register numbers.
2873
2874 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2875
2876         * NEWS: Mention two argument form of gdb.Value constructor.
2877         * python/py-value.c (convert_buffer_and_type_to_value): New
2878         function.
2879         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2880         Add support for handling an optional second argument.  Call
2881         convert_buffer_and_type_to_value as appropriate.
2882         * python/python-internal.h (Py_buffer_deleter): New struct.
2883         (Py_buffer_up): New typedef.
2884
2885 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2886
2887         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2888         instead of releasing ownership.
2889
2890 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2891
2892         * dwarf2read.c (open_and_init_dwp_file): Call
2893         elf_numsections instead of bfd_count_sections to initialize
2894         dwp_file->num_sections.
2895
2896 2019-02-25  Tom Tromey  <tromey@adacore.com>
2897
2898         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2899
2900 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2901
2902         * gcore.in: Add '--readnever' option when invoking GDB.
2903
2904 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2905
2906         * MAINTAINERS: Update my email address.
2907
2908 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2909
2910         * build-id.c (build_id_to_debug_bfd_1): New function.
2911         (build_id_to_debug_bfd): Look for separate debug file in
2912         sysroot.
2913
2914 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2915
2916         * gdbarch.sh: Update the copyright year range that is placed into
2917         generated files.
2918
2919 2019-02-22  Keith Seitz  <keiths@redhat.com>
2920
2921         PR symtab/23853
2922         * linespec.c (create_sals_line_offset): Search for the default
2923         symtab's filename instead of its fullname.
2924
2925 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2926
2927         * NEWS: Update style defaults.
2928
2929 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2930
2931         * main.c (captured_main_1): Disable styling in batch mode.
2932
2933 2019-02-20  Tom Tromey  <tom@tromey.com>
2934
2935         * symtab.c (symtab_symbol_info): Fix typos.
2936
2937 2019-02-20  Tom Tromey  <tromey@adacore.com>
2938
2939         * findcmd.c (_initialize_mem_search): Use upper case for
2940         metasyntactic variables.
2941
2942 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2943
2944         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2945         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2946
2947 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2948
2949         * top.h (source_file_name): Change to std::string.
2950         * top.c (source_file_name): Likewise.
2951         (command_line_input): Adjust.
2952         * cli/cli-script.c (script_from_file): Adjust.
2953
2954 2019-02-19  Tom Tromey  <tromey@adacore.com>
2955
2956         * ravenscar-thread.c
2957         (ravenscar_thread_target::update_thread_list): Don't call
2958         ada_build_task_list.
2959         * ada-lang.h (ada_build_task_list): Don't declare.
2960         * ada-tasks.c (struct ada_tasks_inferior_data)
2961         <task_list_valid_p>: Now bool.
2962         (read_known_tasks, ada_task_list_changed)
2963         (ada_tasks_invalidate_inferior_data): Update.
2964         (read_known_tasks_array): Return bool.
2965         (read_known_tasks_list): Likewise.
2966         (read_known_tasks): Return void.
2967         (ada_build_task_list): Now static.
2968
2969 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2970
2971         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2972         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2973
2974 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2975
2976         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2977         variant for ada_tasks_pspace_data_handle and
2978         ada_tasks_inferior_data_handle.
2979         (ada_tasks_pspace_data_cleanup): New function.
2980         (ada_tasks_inferior_data_cleanup): New function.
2981
2982 2019-02-17  Tom Tromey  <tom@tromey.com>
2983
2984         * macrotab.h (macro_source_fullname): Return a std::string.
2985         * macrotab.c (macro_include, check_for_redefinition)
2986         (macro_undef, macro_lookup_definition, foreach_macro)
2987         (foreach_macro_in_scope): Update.
2988         (macro_source_fullname): Return a std::string.
2989         * macrocmd.c (show_pp_source_pos): Update.
2990
2991 2019-02-17  Tom Tromey  <tom@tromey.com>
2992
2993         * macrocmd.c (show_pp_source_pos): Style the file names.
2994
2995 2019-02-17  Tom Tromey  <tom@tromey.com>
2996
2997         PR tui/24197:
2998         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2999
3000 2019-02-17  Tom Tromey  <tom@tromey.com>
3001
3002         * ada-lang.c (user_select_syms): Use filtered printing.
3003         * utils.c (wrap_style): New global.
3004         (desired_style): Remove.
3005         (emit_style_escape): Add stream parameter.
3006         (set_output_style, reset_terminal_style, prompt_for_continue):
3007         Update.
3008         (flush_wrap_buffer): Only flush gdb_stdout.
3009         (wrap_here): Set wrap_style.
3010         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3011         treat escape sequences as a character.  Change when wrap buffer is
3012         flushed.
3013         (fputs_styled): Do not set the output style when the default is
3014         requested.
3015         * ui-style.h (struct ui_file_style) <is_default>: New method.
3016         * source.c (print_source_lines_base): Emit escape sequences in one
3017         piece.
3018
3019 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3020
3021         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3022         integers and enumeration types.
3023
3024 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3025
3026         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3027         instead of lookup_symbol_in_language
3028         (do_exact_match): New function.
3029         (ada_get_symbol_name_matcher): Return do_exact_match when
3030         doing a verbatim match.
3031
3032 2019-02-15  Tom Tromey  <tromey@adacore.com>
3033
3034         * ravenscar-thread.c (ravenscar_thread_target::resume)
3035         (ravenscar_thread_target::wait): Special case wildcard requests.
3036
3037 2019-02-15  Tom Tromey  <tromey@adacore.com>
3038
3039         * ravenscar-thread.c (base_ptid): Remove.
3040         (struct ravenscar_thread_target) <close>: New method.
3041         <m_base_ptid>: New member.
3042         <update_inferior_ptid, active_task, task_is_currently_active,
3043         runtime_initialized>: Declare methods.
3044         <ravenscar_thread_target>: Add constructor.
3045         (ravenscar_thread_target::task_is_currently_active)
3046         (ravenscar_thread_target::update_inferior_ptid)
3047         (ravenscar_runtime_initialized): Rename.  Now methods.
3048         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3049         (ravenscar_thread_target::update_thread_list): Update.
3050         (ravenscar_thread_target::active_task): Now method.
3051         (ravenscar_thread_target::store_registers)
3052         (ravenscar_thread_target::prepare_to_store)
3053         (ravenscar_thread_target::prepare_to_store)
3054         (ravenscar_thread_target::mourn_inferior): Update.
3055         (ravenscar_inferior_created): Use "new" to create target.
3056         (ravenscar_thread_target::get_ada_task_ptid): Update.
3057         (_initialize_ravenscar): Don't initialize base_ptid.
3058         (ravenscar_ops): Remove global.
3059
3060 2019-02-15  Tom Tromey  <tromey@adacore.com>
3061
3062         * target.h (push_target): Declare new overload.
3063         * target.c (push_target): New overload, taking an rvalue reference.
3064         * remote.c (remote_target::open_1): Use push_target overload.
3065         * corelow.c (core_target_open): Use push_target overload.
3066
3067 2019-02-15  Tom Tromey  <tromey@adacore.com>
3068
3069         * ravenscar-thread.c (is_ravenscar_task)
3070         (ravenscar_task_is_currently_active): Return bool.
3071         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3072         (_initialize_ravenscar): Remove "(void)".
3073         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3074         Return bool.
3075
3076 2019-02-15  Tom Tromey  <tromey@adacore.com>
3077
3078         * ravenscar-thread.c (ravenscar_runtime_initializer)
3079         (has_ravenscar_runtime, get_running_thread_id)
3080         (ravenscar_thread_target::resume): Fix indentation.
3081
3082 2019-02-15  Tom Tromey  <tromey@adacore.com>
3083
3084         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3085         from ravenscar_arch_ops.
3086         (sparc_ravenscar_ops::fetch_registers)
3087         (sparc_ravenscar_ops::store_registers): Now methods.
3088         (sparc_ravenscar_prepare_to_store): Remove.
3089         (sparc_ravenscar_ops): Redefine.
3090         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3091         methods and destructor.  Remove members.
3092         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3093         (ravenscar_thread_target::store_registers)
3094         (ravenscar_thread_target::prepare_to_store): Update.
3095         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3096         Remove.
3097         (struct ppc_ravenscar_powerpc_ops): Derive from
3098         ravenscar_arch_ops.
3099         (ppc_ravenscar_powerpc_ops::fetch_registers)
3100         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3101         (ppc_ravenscar_powerpc_ops): Redefine.
3102         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3103         (ppc_ravenscar_e500_ops::fetch_registers)
3104         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3105         (ppc_ravenscar_e500_ops): Redefine.
3106         * aarch64-ravenscar-thread.c
3107         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3108         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3109         (aarch64_ravenscar_fetch_registers)
3110         (aarch64_ravenscar_store_registers): Now methods.
3111         (aarch64_ravenscar_ops): Redefine.
3112
3113 2019-02-15  Tom Tromey  <tromey@adacore.com>
3114
3115         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3116         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3117         (ravenscar_thread_target::stopped_by_watchpoint)
3118         (ravenscar_thread_target::stopped_data_address)
3119         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3120
3121 2019-02-15  Tom Tromey  <tromey@adacore.com>
3122
3123         * ravenscar-thread.c: Fix some typos.
3124
3125 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3126             Tom Tromey  <tromey@adacore.com>
3127
3128         * ada-lang.c (ada_exception_sal): Change addr_string to a
3129         std::string.
3130         (create_ada_exception_catchpoint): Update.
3131
3132 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3133             Tom Tromey  <tromey@adacore.com>
3134
3135         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3136         (bp_location_ops): Remove.
3137         (base_breakpoint_allocate_location): Update.
3138         (free_bp_location): Update.
3139         * ada-lang.c (class ada_catchpoint_location)
3140         <ada_catchpoint_location>: Remove ops parameter.
3141         (ada_catchpoint_location_dtor): Remove.
3142         (ada_catchpoint_location_ops): Remove.
3143         (allocate_location_exception): Update.
3144         * breakpoint.h (struct bp_location_ops): Remove.
3145         (class bp_location) <bp_location>: Remove bp_location_ops
3146         parameter.
3147         <~bp_location>: Add destructor.
3148         <ops>: Remove.
3149
3150 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3151             Pedro Alves  <palves@redhat.com>
3152
3153         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3154         'PATH_MAX'.
3155
3156 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3157             Samuel Thibault  <samuel.thibault@gnu.org>
3158             Thomas Schwinge  <thomas@codesourcery.com>
3159
3160         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3161         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3162
3163 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3164
3165         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3166         (check_empty): Use "const char *".
3167
3168         * gnu-nat.c (gnu_nat_target::detach): Instead of
3169         'detach_inferior (pid)' call
3170         'detach_inferior (find_inferior_pid (pid))'.
3171
3172         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3173         'nat/fork-inferior.o'.
3174         * gnu-nat.c: #include "nat/fork-inferior.h".
3175
3176         * gnu-nat.c (gnu_nat_target::detach): Instead of
3177         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3178         * gnu-nat.h: #include "inf-child.h".
3179         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3180         'i386_gnu_nat_target::fetch_registers'.
3181         (gnu_store_registers): Rename/move to
3182         'i386_gnu_nat_target::store_registers'.
3183
3184         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3185         * gnu-nat.h (mach_thread_info): New function.
3186         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3187
3188         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3189
3190 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3191
3192         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3193
3194 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3195
3196         * windows-nat.c (windows_add_thread): Add new parameter
3197         "main_thread_p" with default value set to false.  Update
3198         function documentation as well as all callers.
3199         (windows_delete_thread): Likewise.
3200         (fake_create_process): Update call to windows_add_thread.
3201         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3202         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3203         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3204         call to windows_delete_thread.
3205
3206 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3207
3208         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3209
3210 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3211
3212         * symfile.c (find_separate_debug_file): Use canonical path of
3213         sysroot with child_path instead of gdb_sysroot if it is valid.
3214
3215 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3216
3217         * symfile.c (find_separate_debug_file): Use child_path to
3218         determine if an object file is under a sysroot.
3219
3220 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3221
3222         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3223         unittests/child-path-selftests.c.
3224         * common/pathstuff.c (child_path): New function.
3225         * common/pathstuff.h (child_path): New prototype.
3226         * unittests/child-path-selftests.c: New file.
3227
3228 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3229
3230         * symfile.c (find_separate_debug_file): Look for separate debug
3231         files in debug directories under the sysroot.
3232
3233 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3234
3235         * symtab.h (struct minimal_symbol data_p): New const method.
3236         (struct minimal_symbol text_p): Likewise.
3237         * symtab.c (output_source_filename): Use file name style
3238         to print file name.
3239         (print_symbol_info): Likewise.
3240         (print_msymbol_info): Use address style to print addresses.
3241         Use function name style to print executable text symbols.
3242         (expand_symtab_containing_pc): Use data_p.
3243         (find_pc_sect_compunit_symtab): Likewise.
3244
3245 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3246
3247         * breakpoint.c (describe_other_breakpoints): Use address style
3248         to print addresses.
3249         (say_where): Likewise.
3250
3251 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3252
3253         * ada-typeprint.c (print_func_type): Print function name
3254         style to print function name.
3255         * c-typeprint.c (c_print_type_1): Likewise.
3256
3257 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3258
3259         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3260         for execve.
3261
3262 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3263
3264         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3265         type_stack.
3266
3267 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3268
3269         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3270         TYPE_CODE_REF types.
3271
3272 2019-02-08  Jim Wilson  <jimw@sifive.com>
3273
3274         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3275         (riscv_linux_fregset): New.
3276         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3277
3278 2019-02-07  Tom Tromey  <tom@tromey.com>
3279
3280         * thread.c (thread_cancel_execution_command): Update.
3281         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3282         methods.
3283         (struct thread_fsm_ops): Remove.
3284         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3285         (thread_fsm_should_stop, thread_fsm_return_value)
3286         (thread_fsm_set_finished, thread_fsm_finished_p)
3287         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3288         Don't declare.
3289         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3290         * infrun.c (clear_proceed_status_thread)
3291         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3292         (print_stop_event): Update.
3293         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3294         Add constructor.
3295         (step_command_fsm_ops): Remove.
3296         (new_step_command_fsm): Remove.
3297         (step_1): Update.
3298         (step_command_fsm::should_stop): Rename from
3299         step_command_fsm_should_stop.
3300         (step_command_fsm::clean_up): Rename from
3301         step_command_fsm_clean_up.
3302         (step_command_fsm::do_async_reply_reason): Rename from
3303         step_command_fsm_async_reply_reason.
3304         (struct until_next_fsm): Inherit from thread_fsm.  Add
3305         constructor.
3306         (until_next_fsm_ops): Remove.
3307         (new_until_next_fsm): Remove.
3308         (until_next_fsm::should_stop): Rename from
3309         until_next_fsm_should_stop.
3310         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3311         (until_next_fsm::do_async_reply_reason): Rename from
3312         until_next_fsm_async_reply_reason.
3313         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3314         constructor.  Change type of breakpoint.
3315         (finish_command_fsm_ops): Remove.
3316         (new_finish_command_fsm): Remove.
3317         (finish_command_fsm::should_stop): Rename from
3318         finish_command_fsm_should_stop.
3319         (finish_command_fsm::clean_up): Rename from
3320         finish_command_fsm_clean_up.
3321         (finish_command_fsm::return_value): Rename from
3322         finish_command_fsm_return_value.
3323         (finish_command_fsm::do_async_reply_reason): Rename from
3324         finish_command_fsm_async_reply_reason.
3325         (finish_command): Update.
3326         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3327         Add constructor.
3328         (call_thread_fsm_ops): Remove.
3329         (call_thread_fsm::call_thread_fsm): Rename from
3330         new_call_thread_fsm.
3331         (call_thread_fsm::should_stop): Rename from
3332         call_thread_fsm_should_stop.
3333         (call_thread_fsm::should_notify_stop): Rename from
3334         call_thread_fsm_should_notify_stop.
3335         (run_inferior_call, call_function_by_hand_dummy): Update.
3336         * cli/cli-interp.c (should_print_stop_to_console): Update.
3337         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3338         Add constructor.  Change type of location_breakpoint,
3339         caller_breakpoint.
3340         (until_break_fsm_ops): Remove.
3341         (new_until_break_fsm): Remove.
3342         (until_break_fsm::should_stop): Rename from
3343         until_break_fsm_should_stop.
3344         (until_break_fsm::clean_up): Rename from
3345         until_break_fsm_clean_up.
3346         (until_break_fsm::do_async_reply_reason): Rename from
3347         until_break_fsm_async_reply_reason.
3348         (until_break_command): Update.
3349         * thread-fsm.c: Remove.
3350         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3351
3352 2019-02-07  Tom Tromey  <tom@tromey.com>
3353
3354         * yy-remap.h: Add include guard.
3355         * xtensa-tdep.h: Add include guard.
3356         * xcoffread.h: Rename include guard.
3357         * varobj-iter.h: Add include guard.
3358         * tui/tui.h: Rename include guard.
3359         * tui/tui-winsource.h: Rename include guard.
3360         * tui/tui-wingeneral.h: Rename include guard.
3361         * tui/tui-windata.h: Rename include guard.
3362         * tui/tui-win.h: Rename include guard.
3363         * tui/tui-stack.h: Rename include guard.
3364         * tui/tui-source.h: Rename include guard.
3365         * tui/tui-regs.h: Rename include guard.
3366         * tui/tui-out.h: Rename include guard.
3367         * tui/tui-layout.h: Rename include guard.
3368         * tui/tui-io.h: Rename include guard.
3369         * tui/tui-hooks.h: Rename include guard.
3370         * tui/tui-file.h: Rename include guard.
3371         * tui/tui-disasm.h: Rename include guard.
3372         * tui/tui-data.h: Rename include guard.
3373         * tui/tui-command.h: Rename include guard.
3374         * tic6x-tdep.h: Add include guard.
3375         * target/waitstatus.h: Rename include guard.
3376         * target/wait.h: Rename include guard.
3377         * target/target.h: Rename include guard.
3378         * target/resume.h: Rename include guard.
3379         * target-float.h: Rename include guard.
3380         * stabsread.h: Add include guard.
3381         * rs6000-tdep.h: Add include guard.
3382         * riscv-fbsd-tdep.h: Add include guard.
3383         * regformats/regdef.h: Rename include guard.
3384         * record.h: Rename include guard.
3385         * python/python.h: Rename include guard.
3386         * python/python-internal.h: Rename include guard.
3387         * python/py-stopevent.h: Rename include guard.
3388         * python/py-ref.h: Rename include guard.
3389         * python/py-record.h: Rename include guard.
3390         * python/py-record-full.h: Rename include guard.
3391         * python/py-record-btrace.h: Rename include guard.
3392         * python/py-instruction.h: Rename include guard.
3393         * python/py-events.h: Rename include guard.
3394         * python/py-event.h: Rename include guard.
3395         * procfs.h: Add include guard.
3396         * proc-utils.h: Add include guard.
3397         * p-lang.h: Add include guard.
3398         * or1k-tdep.h: Rename include guard.
3399         * observable.h: Rename include guard.
3400         * nto-tdep.h: Rename include guard.
3401         * nat/x86-linux.h: Rename include guard.
3402         * nat/x86-linux-dregs.h: Rename include guard.
3403         * nat/x86-gcc-cpuid.h: Add include guard.
3404         * nat/x86-dregs.h: Rename include guard.
3405         * nat/x86-cpuid.h: Rename include guard.
3406         * nat/ppc-linux.h: Rename include guard.
3407         * nat/mips-linux-watch.h: Rename include guard.
3408         * nat/linux-waitpid.h: Rename include guard.
3409         * nat/linux-ptrace.h: Rename include guard.
3410         * nat/linux-procfs.h: Rename include guard.
3411         * nat/linux-osdata.h: Rename include guard.
3412         * nat/linux-nat.h: Rename include guard.
3413         * nat/linux-namespaces.h: Rename include guard.
3414         * nat/linux-btrace.h: Rename include guard.
3415         * nat/glibc_thread_db.h: Rename include guard.
3416         * nat/gdb_thread_db.h: Rename include guard.
3417         * nat/gdb_ptrace.h: Rename include guard.
3418         * nat/fork-inferior.h: Rename include guard.
3419         * nat/amd64-linux-siginfo.h: Rename include guard.
3420         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3421         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3422         * nat/aarch64-linux.h: Rename include guard.
3423         * nat/aarch64-linux-hw-point.h: Rename include guard.
3424         * mn10300-tdep.h: Add include guard.
3425         * mips-linux-tdep.h: Add include guard.
3426         * mi/mi-parse.h: Rename include guard.
3427         * mi/mi-out.h: Rename include guard.
3428         * mi/mi-main.h: Rename include guard.
3429         * mi/mi-interp.h: Rename include guard.
3430         * mi/mi-getopt.h: Rename include guard.
3431         * mi/mi-console.h: Rename include guard.
3432         * mi/mi-common.h: Rename include guard.
3433         * mi/mi-cmds.h: Rename include guard.
3434         * mi/mi-cmd-break.h: Rename include guard.
3435         * m2-lang.h: Add include guard.
3436         * location.h: Rename include guard.
3437         * linux-record.h: Rename include guard.
3438         * linux-nat.h: Add include guard.
3439         * linux-fork.h: Add include guard.
3440         * i386-darwin-tdep.h: Rename include guard.
3441         * hppa-linux-offsets.h: Add include guard.
3442         * guile/guile.h: Rename include guard.
3443         * guile/guile-internal.h: Rename include guard.
3444         * gnu-nat.h: Rename include guard.
3445         * gdb-stabs.h: Rename include guard.
3446         * frv-tdep.h: Add include guard.
3447         * f-lang.h: Add include guard.
3448         * event-loop.h: Add include guard.
3449         * darwin-nat.h: Rename include guard.
3450         * cp-abi.h: Rename include guard.
3451         * config/sparc/nm-sol2.h: Rename include guard.
3452         * config/nm-nto.h: Rename include guard.
3453         * config/nm-linux.h: Add include guard.
3454         * config/i386/nm-i386gnu.h: Rename include guard.
3455         * config/djgpp/nl_types.h: Rename include guard.
3456         * config/djgpp/langinfo.h: Rename include guard.
3457         * compile/gcc-cp-plugin.h: Add include guard.
3458         * compile/gcc-c-plugin.h: Add include guard.
3459         * compile/compile.h: Rename include guard.
3460         * compile/compile-object-run.h: Rename include guard.
3461         * compile/compile-object-load.h: Rename include guard.
3462         * compile/compile-internal.h: Rename include guard.
3463         * compile/compile-cplus.h: Rename include guard.
3464         * compile/compile-c.h: Rename include guard.
3465         * common/xml-utils.h: Rename include guard.
3466         * common/x86-xstate.h: Rename include guard.
3467         * common/version.h: Rename include guard.
3468         * common/vec.h: Rename include guard.
3469         * common/tdesc.h: Rename include guard.
3470         * common/selftest.h: Rename include guard.
3471         * common/scoped_restore.h: Rename include guard.
3472         * common/scoped_mmap.h: Rename include guard.
3473         * common/scoped_fd.h: Rename include guard.
3474         * common/safe-iterator.h: Rename include guard.
3475         * common/run-time-clock.h: Rename include guard.
3476         * common/refcounted-object.h: Rename include guard.
3477         * common/queue.h: Rename include guard.
3478         * common/ptid.h: Rename include guard.
3479         * common/print-utils.h: Rename include guard.
3480         * common/preprocessor.h: Rename include guard.
3481         * common/pathstuff.h: Rename include guard.
3482         * common/observable.h: Rename include guard.
3483         * common/netstuff.h: Rename include guard.
3484         * common/job-control.h: Rename include guard.
3485         * common/host-defs.h: Rename include guard.
3486         * common/gdb_wait.h: Rename include guard.
3487         * common/gdb_vecs.h: Rename include guard.
3488         * common/gdb_unlinker.h: Rename include guard.
3489         * common/gdb_unique_ptr.h: Rename include guard.
3490         * common/gdb_tilde_expand.h: Rename include guard.
3491         * common/gdb_sys_time.h: Rename include guard.
3492         * common/gdb_string_view.h: Rename include guard.
3493         * common/gdb_splay_tree.h: Rename include guard.
3494         * common/gdb_setjmp.h: Rename include guard.
3495         * common/gdb_ref_ptr.h: Rename include guard.
3496         * common/gdb_optional.h: Rename include guard.
3497         * common/gdb_locale.h: Rename include guard.
3498         * common/gdb_assert.h: Rename include guard.
3499         * common/filtered-iterator.h: Rename include guard.
3500         * common/filestuff.h: Rename include guard.
3501         * common/fileio.h: Rename include guard.
3502         * common/environ.h: Rename include guard.
3503         * common/common-utils.h: Rename include guard.
3504         * common/common-types.h: Rename include guard.
3505         * common/common-regcache.h: Rename include guard.
3506         * common/common-inferior.h: Rename include guard.
3507         * common/common-gdbthread.h: Rename include guard.
3508         * common/common-exceptions.h: Rename include guard.
3509         * common/common-defs.h: Rename include guard.
3510         * common/common-debug.h: Rename include guard.
3511         * common/cleanups.h: Rename include guard.
3512         * common/buffer.h: Rename include guard.
3513         * common/btrace-common.h: Rename include guard.
3514         * common/break-common.h: Rename include guard.
3515         * cli/cli-utils.h: Rename include guard.
3516         * cli/cli-style.h: Rename include guard.
3517         * cli/cli-setshow.h: Rename include guard.
3518         * cli/cli-script.h: Rename include guard.
3519         * cli/cli-interp.h: Rename include guard.
3520         * cli/cli-decode.h: Rename include guard.
3521         * cli/cli-cmds.h: Rename include guard.
3522         * charset-list.h: Add include guard.
3523         * buildsym-legacy.h: Rename include guard.
3524         * bfin-tdep.h: Add include guard.
3525         * ax.h: Rename include guard.
3526         * arm-linux-tdep.h: Add include guard.
3527         * arm-fbsd-tdep.h: Add include guard.
3528         * arch/xtensa.h: Rename include guard.
3529         * arch/tic6x.h: Add include guard.
3530         * arch/i386.h: Add include guard.
3531         * arch/arm.h: Rename include guard.
3532         * arch/arm-linux.h: Rename include guard.
3533         * arch/arm-get-next-pcs.h: Rename include guard.
3534         * arch/amd64.h: Add include guard.
3535         * arch/aarch64-insn.h: Rename include guard.
3536         * arch-utils.h: Rename include guard.
3537         * annotate.h: Add include guard.
3538         * amd64-darwin-tdep.h: Rename include guard.
3539         * aarch64-linux-tdep.h: Add include guard.
3540         * aarch64-fbsd-tdep.h: Add include guard.
3541         * aarch32-linux-nat.h: Add include guard.
3542
3543 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3544
3545         * macrotab.c (macro_define_internal): New function that
3546         factorizes macro_define_object_internal and macro_define_function
3547         code.
3548         (macro_define_object_internal): Use macro_define_internal.
3549         (macro_define_function): Likewise.
3550
3551 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3552
3553         * macrocmd.c (extract_identifier): Return
3554         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3555         callers.
3556
3557 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3558
3559         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3560
3561 2019-02-05  Tom Tromey  <tom@tromey.com>
3562
3563         * target.c (target_stack::unpush): Move assertion earlier.
3564
3565 2019-01-30  Tom Tromey  <tom@tromey.com>
3566
3567         PR python/23615:
3568         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3569         (gdbpy_parse_and_eval): Likewise.
3570         * python/python-internal.h (gdbpy_allow_threads): New class.
3571
3572 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3573
3574         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3575         (aarch64_fbsd_fpregmap): Move earlier.
3576         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3577         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3578         instead of individual calls to trad_frame_set_reg_addr.
3579         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3580         earlier.
3581         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3582         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3583         instead of individual calls to trad_frame_set_reg_addr.
3584
3585 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3586
3587         * CONTRIBUTE: Replace contribution list with wiki link.
3588
3589 2019-01-25  Tom Tromey  <tom@tromey.com>
3590
3591         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3592
3593 2019-01-25  Tom Tromey  <tom@tromey.com>
3594
3595         * xtensa-linux-nat.c: Fix common/ includes.
3596         * xml-support.h: Fix common/ includes.
3597         * xml-support.c: Fix common/ includes.
3598         * x86-linux-nat.c: Fix common/ includes.
3599         * windows-nat.c: Fix common/ includes.
3600         * varobj.h: Fix common/ includes.
3601         * varobj.c: Fix common/ includes.
3602         * value.c: Fix common/ includes.
3603         * valops.c: Fix common/ includes.
3604         * utils.c: Fix common/ includes.
3605         * unittests/xml-utils-selftests.c: Fix common/ includes.
3606         * unittests/utils-selftests.c: Fix common/ includes.
3607         * unittests/unpack-selftests.c: Fix common/ includes.
3608         * unittests/tracepoint-selftests.c: Fix common/ includes.
3609         * unittests/style-selftests.c: Fix common/ includes.
3610         * unittests/string_view-selftests.c: Fix common/ includes.
3611         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3612         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3613         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3614         * unittests/rsp-low-selftests.c: Fix common/ includes.
3615         * unittests/parse-connection-spec-selftests.c: Fix common/
3616         includes.
3617         * unittests/optional-selftests.c: Fix common/ includes.
3618         * unittests/offset-type-selftests.c: Fix common/ includes.
3619         * unittests/observable-selftests.c: Fix common/ includes.
3620         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3621         * unittests/memrange-selftests.c: Fix common/ includes.
3622         * unittests/memory-map-selftests.c: Fix common/ includes.
3623         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3624         * unittests/function-view-selftests.c: Fix common/ includes.
3625         * unittests/environ-selftests.c: Fix common/ includes.
3626         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3627         * unittests/common-utils-selftests.c: Fix common/ includes.
3628         * unittests/cli-utils-selftests.c: Fix common/ includes.
3629         * unittests/array-view-selftests.c: Fix common/ includes.
3630         * ui-file.c: Fix common/ includes.
3631         * tui/tui-io.c: Fix common/ includes.
3632         * tracepoint.h: Fix common/ includes.
3633         * tracepoint.c: Fix common/ includes.
3634         * tracefile-tfile.c: Fix common/ includes.
3635         * top.h: Fix common/ includes.
3636         * top.c: Fix common/ includes.
3637         * thread.c: Fix common/ includes.
3638         * target/waitstatus.h: Fix common/ includes.
3639         * target/waitstatus.c: Fix common/ includes.
3640         * target.h: Fix common/ includes.
3641         * target.c: Fix common/ includes.
3642         * target-memory.c: Fix common/ includes.
3643         * target-descriptions.c: Fix common/ includes.
3644         * symtab.h: Fix common/ includes.
3645         * symfile.c: Fix common/ includes.
3646         * stap-probe.c: Fix common/ includes.
3647         * spu-linux-nat.c: Fix common/ includes.
3648         * sparc-nat.c: Fix common/ includes.
3649         * source.c: Fix common/ includes.
3650         * solib.c: Fix common/ includes.
3651         * solib-target.c: Fix common/ includes.
3652         * ser-unix.c: Fix common/ includes.
3653         * ser-tcp.c: Fix common/ includes.
3654         * ser-pipe.c: Fix common/ includes.
3655         * ser-base.c: Fix common/ includes.
3656         * selftest-arch.c: Fix common/ includes.
3657         * s12z-tdep.c: Fix common/ includes.
3658         * rust-exp.y: Fix common/ includes.
3659         * rs6000-aix-tdep.c: Fix common/ includes.
3660         * riscv-tdep.c: Fix common/ includes.
3661         * remote.c: Fix common/ includes.
3662         * remote-notif.h: Fix common/ includes.
3663         * remote-fileio.h: Fix common/ includes.
3664         * remote-fileio.c: Fix common/ includes.
3665         * regcache.h: Fix common/ includes.
3666         * regcache.c: Fix common/ includes.
3667         * record-btrace.c: Fix common/ includes.
3668         * python/python.c: Fix common/ includes.
3669         * python/py-type.c: Fix common/ includes.
3670         * python/py-inferior.c: Fix common/ includes.
3671         * progspace.h: Fix common/ includes.
3672         * producer.c: Fix common/ includes.
3673         * procfs.c: Fix common/ includes.
3674         * proc-api.c: Fix common/ includes.
3675         * printcmd.c: Fix common/ includes.
3676         * ppc-linux-nat.c: Fix common/ includes.
3677         * parser-defs.h: Fix common/ includes.
3678         * osdata.c: Fix common/ includes.
3679         * obsd-nat.c: Fix common/ includes.
3680         * nat/x86-linux.c: Fix common/ includes.
3681         * nat/x86-linux-dregs.c: Fix common/ includes.
3682         * nat/x86-dregs.h: Fix common/ includes.
3683         * nat/x86-dregs.c: Fix common/ includes.
3684         * nat/ppc-linux.c: Fix common/ includes.
3685         * nat/mips-linux-watch.h: Fix common/ includes.
3686         * nat/mips-linux-watch.c: Fix common/ includes.
3687         * nat/linux-waitpid.c: Fix common/ includes.
3688         * nat/linux-ptrace.h: Fix common/ includes.
3689         * nat/linux-ptrace.c: Fix common/ includes.
3690         * nat/linux-procfs.c: Fix common/ includes.
3691         * nat/linux-personality.c: Fix common/ includes.
3692         * nat/linux-osdata.c: Fix common/ includes.
3693         * nat/linux-namespaces.c: Fix common/ includes.
3694         * nat/linux-btrace.h: Fix common/ includes.
3695         * nat/linux-btrace.c: Fix common/ includes.
3696         * nat/fork-inferior.c: Fix common/ includes.
3697         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3698         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3699         * nat/aarch64-linux.c: Fix common/ includes.
3700         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3701         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3702         * namespace.h: Fix common/ includes.
3703         * mips-linux-tdep.c: Fix common/ includes.
3704         * minsyms.c: Fix common/ includes.
3705         * mi/mi-parse.h: Fix common/ includes.
3706         * mi/mi-main.c: Fix common/ includes.
3707         * mi/mi-cmd-env.c: Fix common/ includes.
3708         * memrange.h: Fix common/ includes.
3709         * memattr.c: Fix common/ includes.
3710         * maint.h: Fix common/ includes.
3711         * maint.c: Fix common/ includes.
3712         * main.c: Fix common/ includes.
3713         * machoread.c: Fix common/ includes.
3714         * location.c: Fix common/ includes.
3715         * linux-thread-db.c: Fix common/ includes.
3716         * linux-nat.c: Fix common/ includes.
3717         * linux-fork.c: Fix common/ includes.
3718         * inline-frame.c: Fix common/ includes.
3719         * infrun.c: Fix common/ includes.
3720         * inflow.c: Fix common/ includes.
3721         * inferior.h: Fix common/ includes.
3722         * inferior.c: Fix common/ includes.
3723         * infcmd.c: Fix common/ includes.
3724         * inf-ptrace.c: Fix common/ includes.
3725         * inf-child.c: Fix common/ includes.
3726         * ia64-linux-nat.c: Fix common/ includes.
3727         * i387-tdep.c: Fix common/ includes.
3728         * i386-tdep.c: Fix common/ includes.
3729         * i386-linux-tdep.c: Fix common/ includes.
3730         * i386-linux-nat.c: Fix common/ includes.
3731         * i386-go32-tdep.c: Fix common/ includes.
3732         * i386-fbsd-tdep.c: Fix common/ includes.
3733         * i386-fbsd-nat.c: Fix common/ includes.
3734         * guile/scm-type.c: Fix common/ includes.
3735         * guile/guile.c: Fix common/ includes.
3736         * go32-nat.c: Fix common/ includes.
3737         * gnu-nat.c: Fix common/ includes.
3738         * gdbthread.h: Fix common/ includes.
3739         * gdbarch-selftests.c: Fix common/ includes.
3740         * gdb_usleep.c: Fix common/ includes.
3741         * gdb_select.h: Fix common/ includes.
3742         * gdb_bfd.c: Fix common/ includes.
3743         * gcore.c: Fix common/ includes.
3744         * fork-child.c: Fix common/ includes.
3745         * findvar.c: Fix common/ includes.
3746         * fbsd-nat.c: Fix common/ includes.
3747         * event-top.c: Fix common/ includes.
3748         * event-loop.c: Fix common/ includes.
3749         * dwarf2read.c: Fix common/ includes.
3750         * dwarf2loc.c: Fix common/ includes.
3751         * dwarf2-frame.c: Fix common/ includes.
3752         * dwarf-index-cache.c: Fix common/ includes.
3753         * dtrace-probe.c: Fix common/ includes.
3754         * disasm-selftests.c: Fix common/ includes.
3755         * defs.h: Fix common/ includes.
3756         * csky-tdep.c: Fix common/ includes.
3757         * cp-valprint.c: Fix common/ includes.
3758         * cp-support.h: Fix common/ includes.
3759         * cp-support.c: Fix common/ includes.
3760         * corelow.c: Fix common/ includes.
3761         * completer.h: Fix common/ includes.
3762         * completer.c: Fix common/ includes.
3763         * compile/compile.c: Fix common/ includes.
3764         * compile/compile-loc2c.c: Fix common/ includes.
3765         * compile/compile-cplus-types.c: Fix common/ includes.
3766         * compile/compile-cplus-symbols.c: Fix common/ includes.
3767         * command.h: Fix common/ includes.
3768         * cli/cli-dump.c: Fix common/ includes.
3769         * cli/cli-cmds.c: Fix common/ includes.
3770         * charset.c: Fix common/ includes.
3771         * build-id.c: Fix common/ includes.
3772         * btrace.h: Fix common/ includes.
3773         * btrace.c: Fix common/ includes.
3774         * breakpoint.h: Fix common/ includes.
3775         * breakpoint.c: Fix common/ includes.
3776         * ax.h:
3777         (enum agent_op): Fix common/ includes.
3778         * ax-general.c (struct aop_map): Fix common/ includes.
3779         * ax-gdb.c: Fix common/ includes.
3780         * auxv.c: Fix common/ includes.
3781         * auto-load.c: Fix common/ includes.
3782         * arm-tdep.c: Fix common/ includes.
3783         * arch/riscv.c: Fix common/ includes.
3784         * arch/ppc-linux-common.c: Fix common/ includes.
3785         * arch/i386.c: Fix common/ includes.
3786         * arch/arm.c: Fix common/ includes.
3787         * arch/arm-linux.c: Fix common/ includes.
3788         * arch/arm-get-next-pcs.c: Fix common/ includes.
3789         * arch/amd64.c: Fix common/ includes.
3790         * arch/aarch64.c: Fix common/ includes.
3791         * arch/aarch64-insn.c: Fix common/ includes.
3792         * arch-utils.c: Fix common/ includes.
3793         * amd64-windows-tdep.c: Fix common/ includes.
3794         * amd64-tdep.c: Fix common/ includes.
3795         * amd64-sol2-tdep.c: Fix common/ includes.
3796         * amd64-obsd-tdep.c: Fix common/ includes.
3797         * amd64-nbsd-tdep.c: Fix common/ includes.
3798         * amd64-linux-tdep.c: Fix common/ includes.
3799         * amd64-linux-nat.c: Fix common/ includes.
3800         * amd64-fbsd-tdep.c: Fix common/ includes.
3801         * amd64-fbsd-nat.c: Fix common/ includes.
3802         * amd64-dicos-tdep.c: Fix common/ includes.
3803         * amd64-darwin-tdep.c: Fix common/ includes.
3804         * agent.c: Fix common/ includes.
3805         * ada-lang.h: Fix common/ includes.
3806         * ada-lang.c: Fix common/ includes.
3807         * aarch64-tdep.c: Fix common/ includes.
3808
3809 2019-01-25  Tom Tromey  <tom@tromey.com>
3810
3811         * common/create-version.sh: Use common/version.h.
3812
3813 2019-01-24  Pedro Alves  <palves@redhat.com>
3814
3815         * infrun.c (signal_stop, signal_print, signal_program)
3816         (signal_catch, signal_pass): Now arrays instead of pointers.
3817         (update_signals_program_target, do_target_resume)
3818         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3819         * linux-nat.c (linux_nat_target::pass_signals)
3820         (linux_nat_target::create_inferior, linux_nat_target::attach):
3821         Adjust.
3822         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3823         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3824         * procfs.c (procfs_target::pass_signals): Adjust.
3825         * record-full.c (record_full_target::resume): Adjust.
3826         * remote.c (remote_target::pass_signals)
3827         (remote_target::program_signals): Adjust.
3828         * target-debug.h (target_debug_print_signals): Now takes a
3829         gdb::array_view as parameter.  Adjust.
3830         * target.h (target_ops) <pass_signals, program_signals>: Replace
3831         pointer and length parameters with gdb::array_view.
3832         (target_pass_signals, target_program_signals): Likewise.
3833         * target-delegates.c: Regenerate.
3834
3835 2019-01-24  Pedro Alves  <palves@redhat.com>
3836
3837         * common/forward-scope-exit.h
3838         (forward_scope_exit::forward_scope_exit): Pass arguments to
3839         m_bind_function directly, instead of creating a std::bind and
3840         copying that.
3841
3842 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3843
3844         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3845         for static members.
3846         (pass_in_v_vfp_candidate): Likewise.
3847
3848 2019-01-23  Tom Tromey  <tom@tromey.com>
3849             Pedro Alves  <palves@redhat.com>
3850
3851         * regcache.c (class regcache_invalidator): Remove.
3852         (regcache::raw_write): Use make_scope_exit.
3853
3854 2019-01-23  Tom Tromey  <tom@tromey.com>
3855
3856         * ui-out.h (class ui_out_emit_type): Update comment.
3857
3858 2019-01-23  Tom Tromey  <tom@tromey.com>
3859
3860         * infrun.c (fetch_inferior_event): Update comment.
3861
3862 2019-01-23  Tom Tromey  <tom@tromey.com>
3863             Pedro Alves  <palves@redhat.com>
3864
3865         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3866         parameter.
3867         (fetch_inferior_event): Use SCOPE_EXIT.
3868
3869
3870 2019-01-23  Tom Tromey  <tom@tromey.com>
3871             Pedro Alves  <palves@redhat.com>
3872
3873         * infrun.c (disable_thread_events): Delete.
3874         (stop_all_threads): Use SCOPE_EXIT.
3875
3876 2019-01-23  Tom Tromey  <tom@tromey.com>
3877             Pedro Alves  <palves@redhat.com>
3878
3879         * symfile.c: Include forward-scope-exit.h.
3880         (clear_symtab_users_cleanup): Replace forward declaration with
3881         a FORWARD_SCOPE_EXIT.
3882         (syms_from_objfile_1): Use the forward_scope_exit and
3883         gdb::optional instead of cleanup_function.
3884         (reread_symbols): Use the forward_scope_exit instead of
3885         cleanup_function.
3886         (clear_symtab_users_cleanup): Remove function.
3887
3888 2019-01-23  Tom Tromey  <tom@tromey.com>
3889             Pedro Alves  <palves@redhat.com>
3890
3891         * linux-nat.c: Include scope-exit.h.
3892         (cleanup_target_stop): Remove.
3893         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3894         SCOPE_EXIT.
3895
3896 2019-01-23  Tom Tromey  <tom@tromey.com>
3897             Pedro Alves  <palves@redhat.com>
3898
3899         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3900         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3901
3902 2019-01-23  Tom Tromey  <tom@tromey.com>
3903             Andrew Burgess  <andrew.burgess@embecosm.com>
3904             Pedro Alves  <palves@redhat.com>
3905
3906         * infrun.c (fetch_inferior_event): Use scope_exit.
3907         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3908         * top.c (execute_command): Use scope_exit.
3909         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3910         * utils.c (do_bpstat_clear_actions_cleanup)
3911         (make_bpstat_clear_actions_cleanup): Remove.
3912
3913 2019-01-23  Tom Tromey  <tom@tromey.com>
3914             Pedro Alves  <palves@redhat.com>
3915
3916         * infrun.c: Include "common/scope-exit.h"
3917         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3918         (wait_for_inferior): Use SCOPE_EXIT.
3919         (fetch_inferior_event): Use scope_exit.
3920
3921 2019-01-23  Tom Tromey  <tom@tromey.com>
3922             Pedro Alves  <palves@redhat.com>
3923
3924         * breakpoint.c (create_breakpoint): Remove cleanup.
3925
3926 2019-01-23  Tom Tromey  <tom@tromey.com>
3927             Andrew Burgess  <andrew.burgess@embecosm.com>
3928             Pedro Alves  <palves@redhat.com>
3929
3930 2019-01-23  Pedro Alves  <palves@redhat.com>
3931
3932         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3933
3934 2019-01-23  Pedro Alves  <palves@redhat.com>
3935             Andrew Burgess  <andrew.burgess@embecosm.com>
3936
3937         * gdbthread.h: Include "common/forward-scope-exit.h".
3938         (scoped_finish_thread_state): Redefine custom class in terms of
3939         forward_scope_exit.
3940
3941 2019-01-23  Pedro Alves  <palves@redhat.com>
3942             Andrew Burgess  <andrew.burgess@embecosm.com>
3943
3944         * common/forward-scope-exit.h: New file.
3945
3946 2019-01-23  Pedro Alves  <palves@redhat.com>
3947             Andrew Burgess  <andrew.burgess@embecosm.com>
3948             Tom Tromey  <tom@tromey.com>
3949
3950         * common/scope-exit.h: New file.
3951
3952 2019-01-23  Pedro Alves  <palves@redhat.com>
3953
3954         * common/preprocessor.h (ESC): Rename to ...
3955         (ESC_PARENS): ... this.
3956         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3957         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3958
3959 2019-01-23  Tom Tromey  <tom@tromey.com>
3960
3961         * language.h (class scoped_switch_to_sym_language_if_auto):
3962         Initialize m_lang in both cases.
3963
3964 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3965
3966         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3967         with XCNEW.
3968
3969 2019-01-22  Tom Tromey  <tom@tromey.com>
3970
3971         * corelow.c: Do not include sys/file.h.
3972
3973 2019-01-22  Tom Tromey  <tom@tromey.com>
3974
3975         * tui/tui-wingeneral.h: Include gdb_curses.h.
3976
3977 2019-01-22  Tom Tromey  <tom@tromey.com>
3978
3979         * source-cache.h (class source_cache) <get_source_lines,
3980         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3981
3982 2019-01-22  Tom Tromey  <tom@tromey.com>
3983
3984         * remote-fileio.h (struct remote_target): Declare.
3985
3986 2019-01-22  Tom Tromey  <tom@tromey.com>
3987
3988         * python/py-arch.c: Do not include py-ref.h.
3989         * python/py-bpevent.c: Do not include py-ref.h.
3990         * python/py-cmd.c: Do not include py-ref.h.
3991         * python/py-continueevent.c: Do not include py-ref.h.
3992         * python/py-event.h: Do not include py-ref.h.
3993         * python/py-evtregistry.c: Do not include py-ref.h.
3994         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3995         * python/py-frame.c: Do not include py-ref.h.
3996         * python/py-framefilter.c: Do not include py-ref.h.
3997         * python/py-function.c: Do not include py-ref.h.
3998         * python/py-infevents.c: Do not include py-ref.h.
3999         * python/py-linetable.c: Do not include py-ref.h.
4000         * python/py-objfile.c: Do not include py-ref.h.
4001         * python/py-param.c: Do not include py-ref.h.
4002         * python/py-prettyprint.c: Do not include py-ref.h.
4003         * python/py-progspace.c: Do not include py-ref.h.
4004         * python/py-symbol.c: Do not include py-ref.h.
4005         * python/py-symtab.c: Do not include py-ref.h.
4006         * python/py-type.c: Do not include py-ref.h.
4007         * python/py-unwind.c: Do not include py-ref.h.
4008         * python/py-utils.c: Do not include py-ref.h.
4009         * python/py-value.c: Do not include py-ref.h.
4010         * python/py-varobj.c: Do not include py-ref.h.
4011         * python/py-xmethods.c: Do not include py-ref.h.
4012         * python/python.c: Do not include py-ref.h.
4013         * varobj.c: Do not include py-ref.h.
4014
4015 2019-01-22  Tom Tromey  <tom@tromey.com>
4016
4017         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4018         keyword for bcache.
4019
4020 2019-01-22  Tom Tromey  <tom@tromey.com>
4021
4022         * compile/compile-cplus-types.c: Remove a comment by #include.
4023
4024 2019-01-22  Tom Tromey  <tom@tromey.com>
4025
4026         * compile/gcc-c-plugin.h: Include compile-internal.h.
4027
4028 2019-01-22  Tom Tromey  <tom@tromey.com>
4029
4030         * stabsread.c (EXTERN): Do not define.
4031         (symnum, next_symbol_text_func, processing_gcc_compilation)
4032         (within_function, global_sym_chain, global_stabs)
4033         (previous_stab_code, this_object_header_files)
4034         (n_this_object_header_files)
4035         (n_allocated_this_object_header_files): Define.
4036         * stabsread.h (EXTERN): Never define.  Use "extern".
4037
4038 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4039
4040         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4041         history_value.
4042
4043 2019-01-21  Tom Tromey  <tom@tromey.com>
4044
4045         * ui-out.c: Fix includes.
4046         * tui/tui-source.c: Fix includes.
4047         * target.c: Fix includes.
4048         * remote.c: Fix includes.
4049         * regcache.c: Fix includes.
4050         * python/py-block.c: Fix includes.
4051         * printcmd.c: Fix includes.
4052         * or1k-tdep.c: Fix includes.
4053         * mi/mi-main.c: Fix includes.
4054         * m32r-tdep.c: Fix includes.
4055         * csky-tdep.c: Fix includes.
4056         * compile/compile-cplus-types.c: Fix includes.
4057         * cli/cli-interp.c: Fix includes.
4058
4059 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4060
4061         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4062         for padding.
4063
4064 2019-01-16  Tom Tromey  <tom@tromey.com>
4065
4066         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4067         earlier.
4068         (struct objfile) <msymbols_range>: Move from top level.
4069         <msymbols>: New method.
4070         (class objfile_msymbols): Remove.
4071         * symtab.c (default_collect_symbol_completion_matches_break_on):
4072         Update.
4073         * symmisc.c (dump_msymbols): Update.
4074         * stabsread.c (scan_file_globals): Update.
4075         * objc-lang.c (info_selectors_command, info_classes_command)
4076         (find_methods): Update.
4077         * minsyms.c (find_solib_trampoline_target): Update.
4078         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4079         * coffread.c (coff_symfile_read): Update.
4080         * ada-lang.c (ada_lookup_simple_minsym)
4081         (ada_collect_symbol_completion_matches): Update.
4082
4083 2019-01-16  Tom Tromey  <tom@tromey.com>
4084
4085         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4086         type.  Remove no-argument constructor.
4087         <iterator::operator++>: Simplify.
4088         <begin>: Update.
4089         <end>: Use minimal_symbol_count.
4090
4091 2019-01-16  Tom Tromey  <tom@tromey.com>
4092
4093         * objfiles.h (struct objfile) <psymtabs>: New method.
4094         (class objfile_psymtabs): Remove.
4095         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4096         typedef.
4097         <range>: New method.
4098         (require_partial_symbols): Change return type.
4099         * psymtab.c (require_partial_symbols)
4100         (psym_expand_symtabs_matching): Update.
4101         * mdebugread.c (parse_partial_symbols): Update.
4102         * dbxread.c (dbx_end_psymtab): Update.
4103
4104 2019-01-15  Tom Tromey  <tom@tromey.com>
4105
4106         * symtab.c (lookup_objfile_from_block)
4107         (lookup_symbol_in_objfile_symtabs)
4108         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4109         (find_line_symtab, info_sources_command)
4110         (default_collect_symbol_completion_matches_break_on)
4111         (make_source_files_completion_list): Update.
4112         * symmisc.c (print_objfile_statistics, dump_objfile)
4113         (maintenance_print_symbols, maintenance_info_symtabs)
4114         (maintenance_check_symtabs, maintenance_info_line_tables):
4115         Update.
4116         * source.c (select_source_symtab)
4117         (forget_cached_source_info_for_objfile): Update.
4118         * objfiles.h (class objfile_compunits): Remove.
4119         (struct objfile) <compunits_range>: New typedef.
4120         (compunits): New method.
4121         * objfiles.c (objfile_relocate1): Update.
4122         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4123         * maint.c (count_symtabs_and_blocks): Update.
4124         * linespec.c (iterate_over_all_matching_symtabs): Update.
4125         * cp-support.c (add_symbol_overload_list_qualified): Update.
4126         * coffread.c (coff_symtab_read): Update.
4127         * ada-lang.c (add_nonlocal_symbols)
4128         (ada_collect_symbol_completion_matches)
4129         (ada_add_global_exceptions): Update.
4130
4131 2019-01-15  Tom Tromey  <tom@tromey.com>
4132
4133         * progspace.h (program_space) <objfiles_safe_range>: New
4134         typedef.
4135         <objfiles_safe>: New method.
4136         * objfiles.h (class all_objfiles_safe): Remove.
4137         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4138         * jit.c (jit_inferior_exit_hook): Update.
4139
4140 2019-01-17  Tom Tromey  <tom@tromey.com>
4141
4142         * progspace.h (program_space) <objfiles_range>: New typedef.
4143         <objfiles>: New method.
4144         <objfiles_head>: Rename from objfiles.
4145         (object_files): Update.
4146         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4147         * guile/scm-pretty-print.c
4148         (ppscm_find_pretty_printer_from_objfiles): Update.
4149         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4150         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4151         Update.
4152         * python/py-progspace.c (pspy_get_objfiles): Update.
4153         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4154         Update.
4155         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4156         (objfpy_lookup_objfile_by_build_id): Update.
4157         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4158         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4159         Update.
4160         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4161         (expand_symtab_containing_pc, lookup_objfile_from_block)
4162         (lookup_static_symbol, basic_lookup_transparent_type)
4163         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4164         (find_line_symtab, info_sources_command)
4165         (default_collect_symbol_completion_matches_break_on)
4166         (make_source_files_completion_list, find_main_name): Update.
4167         * symmisc.c (print_symbol_bcache_statistics)
4168         (print_objfile_statistics, maintenance_print_symbols)
4169         (maintenance_print_msymbols, maintenance_print_objfiles)
4170         (maintenance_info_symtabs, maintenance_check_symtabs)
4171         (maintenance_expand_symtabs, maintenance_info_line_tables):
4172         Update.
4173         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4174         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4175         (map_overlay_command, unmap_overlay_command)
4176         (simple_overlay_update, expand_symtabs_matching)
4177         (map_symbol_filenames): Update.
4178         * symfile-debug.c (set_debug_symfile): Update.
4179         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4180         Update.
4181         * source.c (select_source_symtab, forget_cached_source_info):
4182         Update.
4183         * solib.c (solib_read_symbols): Update.
4184         * solib-spu.c (append_ocl_sos): Update.
4185         * psymtab.c (maintenance_print_psymbols)
4186         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4187         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4188         * printcmd.c (info_symbol_command): Update.
4189         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4190         Update.
4191         * objfiles.h (class all_objfiles): Remove.
4192         * objfiles.c (have_partial_symbols, have_full_symbols)
4193         (have_minimal_symbols, qsort_cmp, update_section_map)
4194         (shared_objfile_contains_address_p)
4195         (default_iterate_over_objfiles_in_search_order): Update.
4196         * objc-lang.c (info_selectors_command, info_classes_command)
4197         (find_methods): Update.
4198         * minsyms.c (find_solib_trampoline_target): Update.
4199         * maint.c (maintenance_info_sections)
4200         (maintenance_translate_address, count_symtabs_and_blocks):
4201         Update.
4202         * main.c (captured_main_1): Update.
4203         * linux-thread-db.c (try_thread_db_load_from_pdir)
4204         (has_libpthread): Update.
4205         * linespec.c (iterate_over_all_matching_symtabs)
4206         (search_minsyms_for_name): Update.
4207         * jit.c (jit_find_objf_with_entry_addr): Update.
4208         * hppa-tdep.c (find_unwind_entry)
4209         (hppa_lookup_stub_minimal_symbol): Update.
4210         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4211         Update.
4212         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4213         (elf_gnu_ifunc_resolve_by_got): Update.
4214         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4215         * dwarf-index-write.c (save_gdb_index_command): Update.
4216         * cp-support.c (add_symbol_overload_list_qualified): Update.
4217         * breakpoint.c (create_overlay_event_breakpoint)
4218         (create_longjmp_master_breakpoint)
4219         (create_std_terminate_master_breakpoint)
4220         (create_exception_master_breakpoint): Update.
4221         * blockframe.c (find_pc_partial_function): Update.
4222         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4223         (ada_collect_symbol_completion_matches)
4224         (ada_add_global_exceptions): Update.
4225
4226 2019-01-17  Tom Tromey  <tom@tromey.com>
4227
4228         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4229         declare VEC.
4230         (solib_target_parse_libraries): Change return type.
4231         (library_list_start_segment, library_list_start_section)
4232         (library_list_end_library, library_list_start_library); Update.
4233         (solib_target_free_library_list): Remove.
4234         (solib_target_parse_libraries): Remove cleanup.  Change return
4235         type.
4236         (solib_target_current_sos): Update.
4237
4238 2019-01-17  Tom Tromey  <tromey@bapiya>
4239
4240         * valprint.c: Replace "the the" with "the".
4241         * symtab.c: Replace "the the" with "the".
4242         * solib.c: Replace "the the" with "the".
4243         * solib-dsbt.c: Replace "the the" with "the".
4244         * linespec.c: Replace "the the" with "the".
4245         * dwarf2loc.h: Replace "the the" with "the".
4246         * amd64-windows-tdep.c: Replace "the the" with "the".
4247         * aarch64-tdep.c: Replace "the the" with "the".
4248
4249 2019-01-16  Keith Seitz  <keiths@redhat.com>
4250
4251         PR gdb/23773
4252         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4253         <builder>: Rename to ..
4254         <m_builder>: ... this and make private.
4255         (dwarf2_cu::get_builder): New method.  Change all users of
4256         `builder' to use this method.
4257         (dwarf2_start_symtab): Move to ...
4258         (dwarf2_cu::start_symtab): ... here.  Update all callers
4259         (setup_type_unit_groups): Move to ...
4260         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4261         callers.
4262         (dwarf2_cu::reset_builder): New method.
4263         (process_full_compunit, process_full_type_unit): Use
4264         dwarf2_cu::reset_builder.
4265         (follow_die_offset): Record the ancestor CU if it is different
4266         from the followed DIE's CU.
4267         (follow_die_sig_1): Likewise.
4268
4269 2019-01-15  Tom Tromey  <tom@tromey.com>
4270
4271         * remote.c (class remote_state) <buf>: Now a char_vector.
4272         <buf_size>: Remove.
4273         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4274         parameter.
4275         (remote_target::getpkt_or_notif_sane_1)
4276         (remote_target::getpkt_sane)
4277         (remote_target::getpkt_or_notif_sane): Likewise.
4278         (class remote_target) <putpkt>: New overload.
4279         (remote_target::read_frame): Change type of "buf_p".  Remove
4280         sizeof_p parameter.
4281         (packet_ok): New overload.
4282         (packet_check_result): New overload.
4283         Update all uses.
4284
4285 2019-01-14  Tom Tromey  <tom@tromey.com>
4286
4287         * remote-notif.c (handle_notification, remote_notif_ack)
4288         (remote_notif_parse): Make "buf" const.
4289         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4290         const.
4291         (remote_notif_parse, remote_notif_ack, handle_notification):
4292         Likewise.
4293         * remote.c (remote_notif_stop_parse): Make "buf" const.
4294         (remote_target::remote_parse_stop_reply): Make "buf" const.
4295         (remote_notif_stop_ack): Make "buf" const.
4296
4297 2019-01-14  Tom Tromey  <tom@tromey.com>
4298
4299         * remote.c (remote_console_output): Make parameter const.
4300
4301 2019-01-14  Tom Tromey  <tom@tromey.com>
4302
4303         * target-debug.h (target_debug_print_signals): Constify.
4304         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4305         * procfs.c (procfs_target::pass_signals): Update.
4306         * linux-nat.c (linux_nat_target::pass_signals): Update.
4307         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4308         * target-delegates.c: Rebuild.
4309         * remote.c (remote_target::program_signals): Update.
4310         (remote_target::pass_signals): Update.
4311         * target.c (target_pass_signals): Constify argument.
4312         (target_program_signals): Likewise.
4313         * target.h (struct target_ops) <pass_signals, program_signals>:
4314         Constify argument.
4315         (target_pass_signals, target_program_signals): Constify argument.
4316
4317 2019-01-14  Tom Tromey  <tom@tromey.com>
4318
4319         PR tui/28819:
4320         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4321
4322 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4323
4324         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4325         field.
4326         * rs6000-tdep.c: Include reggroups.h.
4327         (IS_V_ALIAS_PSEUDOREG): Define.
4328         (rs6000_register_name): Return names for the "vX" aliases.
4329         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4330         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4331         aliases.  Call default_register_reggroup_p for all other
4332         pseudo-registers.
4333         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4334         New functions.
4335         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4336         Handle "vX" aliases.
4337         (v_alias_pseudo_register_collect): New function.
4338         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4339         (rs6000_gdbarch_init): Initialize "vX" aliases as
4340         pseudo-registers.  Restore registration of
4341         rs6000_pseudo_register_reggroup_p with
4342         set_tdesc_pseudo_register_reggroup_p.
4343
4344 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4345
4346         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4347         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4348         set_gdbarch_num_pseudo_regs.
4349
4350 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4351
4352         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4353         Remove arg prefixname, add do_set and do_show.
4354         Add member functions set_list and show_list.
4355         * cli/cli-style.c (class cli_style_option): Update accordingly.
4356         (style_set_list): Move to file scope.
4357         (style_show_list): Likewise.
4358         (set_style): Call help_list.
4359         (show_style): Call cmd_show_list.
4360         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4361         Update to use the new macro.
4362
4363 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4364
4365         * ada-lang.c (_initialize_ada_language): Expand the help text
4366         for the "catch exception" command.
4367
4368 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4369
4370         * symtab.c (matching_obj_sections): Initialize obj,
4371         declare it closer to its usage.
4372
4373 2019-01-10  Tom Tromey  <tom@tromey.com>
4374
4375         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4376         (basic_inf_threads_range): Remove.
4377         (inf_threads_range, inf_non_exited_threads_range)
4378         (safe_inf_threads_range): Use next_adapter.
4379
4380 2019-01-10  Keith Seitz  <keiths@redhat.com>
4381
4382         PR gdb/23712
4383         PR symtab/23010
4384         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4385         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4386
4387 2019-01-10  Keith Seitz  <keiths@redhat.com>
4388
4389         PR gdb/23712
4390         PR symtab/23010
4391         * dictionary.c (pending_to_vector): Remove.
4392         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4393         Remove _1 suffix, replacing functions of the same name.  Update
4394         all callers.
4395         (dict_create_hashed, dict_create_hashed_expandable)
4396         (dict_create_linear, dict_create_linear_expandable, dict_free)
4397         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4398         Make functions static.
4399
4400 2019-01-10  Keith Seitz  <keiths@redhat.com>
4401
4402         PR gdb/23712
4403         PR symtab/23010
4404         * dictionary.h (struct dictionary): Replace declaration with
4405         multidictionary.
4406         (dict_create_hashed, dict_create_hashed_expandable)
4407         (dict_create_linear, dict_create_linear_expandable)
4408         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4409         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4410         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4411         taking multidictionary argument.
4412         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4413         * block.h (struct block) <dict>: Change to multidictionary
4414         and rename `multidict'.
4415         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4416         symmisc.c: Update all dictionary references to multidictionary.
4417
4418 2019-01-10  Keith Seitz  <keiths@redhat.com>
4419
4420         PR gdb/23712
4421         PR symtab/23010
4422         * dictionary.c: Include unordered_map.
4423         (pending_to_vector): New function.
4424         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4425         Rewrite the non-"_1" functions to take vector instead
4426         of linked list.
4427         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4428         "new" _1 versions of the same name.
4429         (multidictionary): Define.
4430         (std::hash<enum language): New definition.
4431         (collate_pending_symbols_by_language, mdict_create_hashed)
4432         (mdict_create_hashed_expandable, mdict_create_linear)
4433         (mdict_create_linear_expandable, mdict_free)
4434         (find_language_dictionary, create_new_language_dictionary)
4435         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4436         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4437         (mdict_size, mdict_empty): New functions.
4438         * dictionary.h (mdict_iterator): Define.
4439
4440 2019-01-10  Pedro Alves  <palves@redhat.com>
4441
4442         * breakpoint.c (read_uploaded_action)
4443         (create_tracepoint_from_upload): Adjust to use
4444         gdb::unique_xmalloc_ptr.
4445         * ctf.c (ctf_write_uploaded_tp):
4446         (SET_ARRAY_FIELD): Use emplace_back.
4447         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4448         * tracefile-tfile.c (tfile_write_uploaded_tp):
4449         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4450         gdb::unique_xmalloc_ptr.
4451         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4452         at_string, cond_string, cmd_strings>: Replace char pointers
4453         with gdb::unique_xmalloc_ptr.
4454
4455 2019-01-10  Pedro Alves  <palves@redhat.com>
4456
4457         * solib-target.c (library_list_start_library): Don't xstrdup name.
4458
4459 2019-01-10  Pedro Alves  <palves@redhat.com>
4460
4461         * mdebugread.c (parse_partial_symbols): Use
4462         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4463
4464 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4465
4466         * linux-fork.c (scoped_switch_fork_info)
4467         <~scoped_switch_fork_info>: Fix incorrect variable name.
4468
4469 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4470
4471         * linux-fork.c (scoped_switch_fork_info)
4472         <scoped_switch_fork_info>: Make explicit.
4473         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4474
4475 2019-01-10  Tom Tromey  <tom@tromey.com>
4476
4477         * objfiles.h (objfile::reset_psymtabs): Update.
4478         * objfiles.c (objfile::objfile): Update.
4479         * psymtab.h (psymtab_storage::obstack): Update.
4480         (psymtab_storage::m_obstack): Use gdb::optional.
4481         (class psymtab_storage): Update comment.  Remove objfile
4482         parameter.
4483         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4484
4485 2019-01-10  Tom Tromey  <tom@tromey.com>
4486
4487         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4488         <free_psymtabs>: Now private.
4489         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4490         (allocate_psymtab): Use new method.
4491
4492 2019-01-10  Tom Tromey  <tom@tromey.com>
4493
4494         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4495         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4496         * mdebugread.c (parse_partial_symbols): Use
4497         allocate_dependencies.
4498         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4499         allocate_dependencies.
4500         (process_psymtab_comp_unit_reader)
4501         (build_type_psymtab_dependencies): Likewise.
4502         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4503
4504 2019-01-10  Tom Tromey  <tom@tromey.com>
4505
4506         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4507         PSYMBOL_SET_LANGUAGE.
4508         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4509
4510 2019-01-10  Tom Tromey  <tom@tromey.com>
4511
4512         * psymtab.h (psymtab_storage::obstack): New method.
4513         <m_obstack>: Rename from obstack; now private.
4514         * psymtab.c (psymtab_storage): Update.
4515         * dwarf2read.c (create_addrmap_from_index)
4516         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4517         Update.
4518
4519 2019-01-10  Tom Tromey  <tom@tromey.com>
4520
4521         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4522         * objfiles.h (objfile::reset_psymtabs): New method.
4523
4524 2019-01-10  Tom Tromey  <tom@tromey.com>
4525
4526         * symmisc.c (print_symbol_bcache_statistics): Update.
4527         (print_objfile_statistics): Update.
4528         * symfile.c (reread_symbols): Update.
4529         * psymtab.h (class psymtab_storage): New.
4530         * psymtab.c (psymtab_storage): New constructor.
4531         (~psymtab_storage): New destructor.
4532         (require_partial_symbols): Update.
4533         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4534         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4535         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4536         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4537         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4538         (start_psymtab_common, end_psymtab_common)
4539         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4540         (allocate_psymtab): Update.
4541         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4542         Update.
4543         (dump_psymtab_addrmap, maintenance_print_psymbols)
4544         (maintenance_check_psymtabs): Update.
4545         (class objfile_psymtabs): Move to objfiles.h.
4546         * psympriv.h (discard_psymtab): Now inline.
4547         (psymtab_discarder::psymtab_discarder): Update.
4548         (psymtab_discarder::~psymtab_discarder): Update.
4549         (ALL_OBJFILE_PSYMTABS): Rewrite.
4550         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4551         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4552         Remove fields.
4553         <partial_symtabs>: New field.
4554         (class objfile_psymtabs): Move from psymtab.h.  Update.
4555         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4556         psymbol_cache.
4557         (objfile::~objfile): Don't destroy psymbol_cache.
4558         * mdebugread.c (parse_partial_symbols): Update.
4559         * dwarf2read.c (create_addrmap_from_index)
4560         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4561         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4562         (add_partial_subprogram, dwarf2_ranges_read): Update.
4563         * dwarf-index-write.c (write_address_map)
4564         (write_one_signatured_type, recursively_write_psymbols)
4565         (class debug_names, class debug_names, write_psymtabs_to_index):
4566         Update.
4567
4568 2019-01-10  Tom Tromey  <tom@tromey.com>
4569
4570         * symtab.h (SYMBOL_SET_NAMES): Update.
4571         (symbol_set_names): Update.
4572         (MSYMBOL_SET_NAMES): Update.
4573         * symtab.c (symbol_set_names): Change argument to be an
4574         objfile_per_bfd_storage.
4575         * psymtab.c (add_psymbol_to_bcache): Update.
4576         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4577
4578 2019-01-10  Tom Tromey  <tom@tromey.com>
4579
4580         * symtab.c (create_demangled_names_hash): Change argument to be an
4581         objfile_per_bfd_storage.
4582         (symbol_set_names): Update.
4583
4584 2019-01-10  Tom Tromey  <tom@tromey.com>
4585
4586         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4587         init_psymbol_list.
4588         * psymtab.c (init_psymbol_list): Do nothing if already called.
4589         * psympriv.h (init_psymbol_list): Add comment.
4590         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4591         init_psymbol_list.
4592         * dbxread.c (dbx_symfile_read): Unconditionally call
4593         init_psymbol_list.
4594
4595 2019-01-10  Tom Tromey  <tom@tromey.com>
4596
4597         * xcoffread.c (scan_xcoff_symtab): Update.
4598         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4599         "where".
4600         * mdebugread.c (parse_partial_symbols)
4601         (handle_psymbol_enumerators): Update.
4602         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4603         * dbxread.c (read_dbx_symtab): Update.
4604         * psympriv.h (psymbol_placement): New enum.
4605         (add_psymbol_to_list): Update.
4606
4607 2019-01-10  Tom Tromey  <tom@tromey.com>
4608
4609         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4610         static_psymbols parameters.
4611         (scan_xcoff_symtab): Update.
4612         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4613         static_psymbols parameters.
4614         * psympriv.h (start_psymtab_common): Update.
4615         * mdebugread.c (parse_partial_symbols): Update.
4616         * dwarf2read.c (create_partial_symtab): Update.
4617         * dbxread.c (read_dbx_symtab): Update.
4618         (start_psymtab): Remove global_psymbols and static_psymbols
4619         parameters.
4620
4621 2019-01-10  Tom Tromey  <tom@tromey.com>
4622
4623         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4624         * psymtab.c (allocate_psymtab): Add comment.
4625         * psympriv.h (allocate_psymtab): Add comment.
4626         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4627         initializations.
4628         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4629
4630 2019-01-10  Tom Tromey  <tom@tromey.com>
4631
4632         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4633         Don't declare.
4634         * mipsread.c: Include mdebugread.h.
4635         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4636         Declare.
4637         * elfread.c: Include mdebugread.h.
4638
4639 2019-01-09  Tom Tromey  <tom@tromey.com>
4640
4641         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4642         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4643         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4644         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4645         (psym_lookup_symbol, psym_find_last_source_symtab)
4646         (psym_forget_cached_source_info, psym_print_stats)
4647         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4648         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4649         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4650         (psym_find_compunit_symtab_by_address)
4651         (maintenance_print_psymbols, maintenance_info_psymtabs)
4652         (maintenance_check_psymtabs): Use ranged for.
4653         * psymtab.h (class objfile_psymtabs): New.
4654         (require_partial_symbols): Return objfile_psymtabs.
4655         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4656
4657 2019-01-09  Tom Tromey  <tom@tromey.com>
4658
4659         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4660         (find_pc_mapped_section, list_overlays_command)
4661         (map_overlay_command, unmap_overlay_command)
4662         (simple_overlay_update): Use all_objfiles.
4663         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4664         * printcmd.c (info_symbol_command): Use all_objfiles.
4665         * objfiles.h (ALL_OBJSECTIONS): Remove.
4666         * maint.c (maintenance_translate_address): Use all_objfiles.
4667         * gcore.c (gcore_create_callback): Use all_objfiles.
4668         (objfile_find_memory_regions): Likewise.
4669
4670 2019-01-09  Tom Tromey  <tom@tromey.com>
4671
4672         * symtab.c (find_line_symtab, info_sources_command)
4673         (make_source_files_completion_list): Use objfile_compunits.
4674         * source.c (select_source_symtab): Use objfile_compunits.
4675         * objfiles.h (struct objfile): Update comment.
4676         (ALL_OBJFILES): Remove.
4677         (ALL_FILETABS): Remove.
4678         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4679         objfile_compunits.
4680
4681 2019-01-09  Tom Tromey  <tom@tromey.com>
4682
4683         * symmisc.c (print_objfile_statistics, dump_objfile)
4684         (maintenance_print_symbols): Use compunit_filetabs.
4685         * source.c (forget_cached_source_info_for_objfile): Use
4686         compunit_filetabs.
4687         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4688         (ALL_FILETABS): Use compunit_filetabs.
4689         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4690         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4691
4692 2019-01-09  Tom Tromey  <tom@tromey.com>
4693
4694         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4695         (compunit_filetabs): New.
4696         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4697         compunit_filetabs.
4698         (info_sources_command, make_source_files_completion_list): Remove
4699         declaration.
4700         * symmisc.c (print_objfile_statistics, dump_objfile)
4701         (maintenance_print_symbols): Remove declaration.
4702         (maintenance_info_symtabs): Use compunit_filetabs.
4703         (maintenance_info_line_tables): Likewise.
4704         * source.c (select_source_symtab): Change local variable name.
4705         (forget_cached_source_info_for_objfile): Remove declaration.
4706         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4707         * objfiles.c (objfile_relocate1): Remove declaration.
4708         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4709         declaration.
4710         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4711         * coffread.c (coff_symtab_read): Remove declaration.
4712         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4713         compunit_filetabs.
4714
4715 2019-01-09  Tom Tromey  <tom@tromey.com>
4716
4717         * symtab.c (lookup_objfile_from_block)
4718         (find_pc_sect_compunit_symtab, search_symbols)
4719         (default_collect_symbol_completion_matches_break_on): Use
4720         objfile_compunits.
4721         * objfiles.h (ALL_COMPUNITS): Remove.
4722         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4723         * cp-support.c (add_symbol_overload_list_qualified): Use
4724         objfile_compunits.
4725         * ada-lang.c (ada_collect_symbol_completion_matches)
4726         (ada_add_global_exceptions): Use objfile_compunits.
4727
4728 2019-01-09  Tom Tromey  <tom@tromey.com>
4729
4730         * source.c (select_source_symtab)
4731         (forget_cached_source_info_for_objfile): Remove declaration.
4732         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4733         declaration.
4734         * maint.c (count_symtabs_and_blocks): Remove declaration.
4735         * cp-support.c (add_symbol_overload_list_qualified): Remove
4736         declaration.
4737         * coffread.c (coff_symtab_read): Remove declaration.
4738         * symtab.c (lookup_symbol_in_objfile_symtabs)
4739         (basic_lookup_transparent_type_1): Use objfile_compunits.
4740         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4741         (info_sources_command, search_symbols)
4742         (default_collect_symbol_completion_matches_break_on)
4743         (make_source_files_completion_list): Remove declaration.
4744         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4745         (ada_collect_symbol_completion_matches)
4746         (ada_add_global_exceptions): Remove declaration.
4747         * linespec.c (iterate_over_all_matching_symtabs): Use
4748         objfile_compunits.
4749         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4750         (class objfile_compunits): New.
4751         (ALL_COMPUNITS): Use objfile_compunits.
4752         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4753         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4754         objfile_compunits.
4755         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4756
4757 2019-01-09  Tom Tromey  <tom@tromey.com>
4758
4759         * symtab.c (search_symbols)
4760         (default_collect_symbol_completion_matches_break_on): Use
4761         objfile_msymbols.
4762         * ada-lang.c (ada_lookup_simple_minsym)
4763         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4764         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4765         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4766         objfile_msymbols.
4767         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4768         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4769         * objc-lang.c (find_methods): Use objfile_msymbols.
4770         (info_selectors_command, info_classes_command): Likewise.
4771         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4772         * objfiles.h (class objfile_msymbols): New.
4773         (ALL_OBJFILE_MSYMBOLS): Remove.
4774         (ALL_MSYMBOLS): Remove.
4775
4776 2019-01-09  Tom Tromey  <tom@tromey.com>
4777
4778         * common/next-iterator.h (next_adapter): Add Iterator template
4779         parameter.
4780         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4781         (class all_objfiles_safe): New.
4782         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4783         * objfiles.c (put_objfile_before): Update comment.
4784         (add_separate_debug_objfile): Likewise.
4785         (free_all_objfiles): Use all_objfiles_safe.
4786         (objfile_purge_solibs): Likewise.
4787
4788 2019-01-09  Tom Tromey  <tom@tromey.com>
4789
4790         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4791         (expand_symtab_containing_pc, lookup_static_symbol)
4792         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4793         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4794         all_objfiles.
4795         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4796         * breakpoint.c (create_overlay_event_breakpoint)
4797         (create_longjmp_master_breakpoint)
4798         (create_std_terminate_master_breakpoint)
4799         (create_exception_master_breakpoint): Use all_objfiles.
4800         * linux-thread-db.c (try_thread_db_load_from_pdir)
4801         (has_libpthread): Use all_objfiles.
4802         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4803         * linespec.c (iterate_over_all_matching_symtabs)
4804         (search_minsyms_for_name): Use all_objfiles.
4805         * maint.c (maintenance_info_sections): Use all_objfiles.
4806         * main.c (captured_main_1): Use all_objfiles.
4807         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4808         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4809         * guile/scm-pretty-print.c
4810         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4811         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4812         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4813         (maintenance_print_msymbols): Use all_objfiles.
4814         * source.c (select_source_symtab): Use all_objfiles.
4815         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4816         * symfile.c (remove_symbol_file_command)
4817         (expand_symtabs_matching, map_symbol_filenames): Use
4818         all_objfiles.
4819         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4820         all_objfiles.
4821         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4822         * objc-lang.c (find_methods): Use all_objfiles.
4823         * objfiles.c (have_partial_symbols, have_full_symbols)
4824         (have_minimal_symbols, qsort_cmp)
4825         (default_iterate_over_objfiles_in_search_order): Use
4826         all_objfiles.
4827         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4828         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4829         (maintenance_check_psymtabs): Use all_objfiles.
4830         (ALL_PSYMTABS): Remove.
4831         * compile/compile-object-run.c (do_module_cleanup): Use
4832         all_objfiles.
4833         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4834         * cp-support.c (add_symbol_overload_list_qualified): Use
4835         all_objfiles.
4836         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4837         Use all_objfiles.
4838         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4839         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4840         all_objfiles.
4841         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4842         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4843         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4844         Uses all_objfiles.
4845         * solib.c (solib_read_symbols): Use all_objfiles
4846
4847 2019-01-09  Tom Tromey  <tom@tromey.com>
4848
4849         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4850         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4851         all_objfiles.
4852         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4853         * symmisc.c (print_symbol_bcache_statistics)
4854         (print_objfile_statistics, maintenance_print_objfiles)
4855         (maintenance_info_symtabs, maintenance_check_symtabs)
4856         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4857         all_objfiles.
4858         * source.c (forget_cached_source_info): Use all_objfiles.
4859         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4860         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4861         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4862         * objfiles.c (update_section_map): Use all_objfiles.
4863         (shared_objfile_contains_address_p): Likewise.
4864         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4865         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4866
4867 2019-01-09  Tom Tromey  <tom@tromey.com>
4868
4869         * common/next-iterator.h: New file.
4870         * objfiles.h (class all_objfiles): New.
4871         (struct objfile_iterator): New.
4872
4873 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4874
4875         * NEWS: Move the description of the changed "frame", "select-frame",
4876          and "info frame" commands to the Changed commands section.
4877
4878 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4879
4880         * gdbtypes.c (check_stub_method_group): Remove handling of old
4881         mangling schemes.
4882         * linespec.c (find_methods): Likewise.
4883         * stabsread.c (read_member_functions): Likewise.
4884         * valops.c (search_struct_method): Likewise.
4885         (value_struct_elt_for_reference): Likewise.
4886         * NEWS: Mention this change.
4887
4888 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4889
4890         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4891         print_source_lines.
4892         * source.c (print_source_lines_base): Update line number check.
4893         (print_source_lines): New function.
4894         (source_lines_range::source_lines_range): New function.
4895         * source.h (class source_lines_range): New class.
4896         (print_source_lines): New declaration.
4897
4898 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4899
4900         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4901
4902 2019-01-08  Tom Tromey  <tom@tromey.com>
4903             Simon Marchi  <simon.marchi@ericsson.com>
4904
4905         PR gdb/24060
4906         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4907         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4908         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4909         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4910         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4911         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4912
4913 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * source.c (select_source_symtab): Move header comment to
4916         declaration in source.h.
4917         (forget_cached_source_info_for_objfile): Likewise.
4918         (forget_cached_source_info): Likewise.
4919         (identify_source_line): Likewise.
4920         * source.h (identify_source_line): Move declaration from symtab.h
4921         and add comment from source.c
4922         (print_source_lines): Likewise.
4923         (forget_cached_source_info_for_objfile): Likewise.
4924         (forget_cached_source_info): Likewise.
4925         (select_source_symtab): Likewise.
4926         (enum print_source_lines_flag): Move definition from symtab.h.
4927         * symtab.h (identify_source_line): Move declaration to source.h.
4928         (print_source_lines): Likewise.
4929         (forget_cached_source_info_for_objfile): Likewise.
4930         (forget_cached_source_info): Likewise.
4931         (select_source_symtab): Likewise.
4932         (enum print_source_lines_flag): Move definition to source.h.
4933         * tui/tui-hooks.c: Add 'source.h' include.
4934
4935 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4936
4937         * source.c (print_source_lines_base): Handle requests to print
4938         reverse line number sequences, and guard against empty lines
4939         string.
4940
4941 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4942
4943         * source.c (print_source_lines_base): Fix skip of '\r' if next
4944         character is '\n'.
4945
4946 2019-01-06  Tom Tromey  <tom@tromey.com>
4947
4948         * c-exp.y (struct c_parse_state) <macro_original_text,
4949         expansion_obstack>: New member.
4950         (macro_original_text, expansion_obstack): Remove globals.
4951         (scan_macro_expansion, scanning_macro_expansion)
4952         (finished_macro_expansion): Update.
4953         (scan_macro_cleanup): Remove.
4954         (yylex, c_parse): Update.
4955
4956 2019-01-06  Tom Tromey  <tom@tromey.com>
4957
4958         * c-exp.y (struct c_parse_state) <strings>: New member.
4959         (operator_stoken): Update.
4960
4961 2019-01-06  Tom Tromey  <tom@tromey.com>
4962
4963         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4964         (union type_stack_elt) <typelist_val>: Now a pointer to
4965         std::vector.
4966         (type_stack_cleanup): Don't declare.
4967         (push_typelist): Update.
4968         * parse.c (pop_typelist): Return a std::vector.
4969         (push_typelist): Take a std::vector.
4970         (follow_types): Update.  Do not free args.
4971         (type_stack_cleanup): Remove.
4972         * c-exp.y (struct c_parse_state): New.
4973         (cpstate): New global.
4974         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4975         (nonempty_typelist): Update.
4976         (func_mod): Create a new vector.
4977         (c_parse): Create a c_parse_state.
4978         (check_parameter_typelist): Do not delete params.
4979         (function_method): Update.  Do not delete type_list.
4980
4981 2019-01-06  Tom Tromey  <tom@tromey.com>
4982
4983         PR gdb/28155:
4984         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4985         check_typedef.
4986         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4987         (print_return_value): Likewise.
4988
4989 2019-01-05  Tom Tromey  <tom@tromey.com>
4990
4991         * contrib/cleanup_check.py: Remove.
4992         * contrib/gcc-with-excheck: Remove.
4993         * contrib/exsummary.py: Remove.
4994         * contrib/excheck.py: Remove.
4995
4996 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4997
4998         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4999         NULL. Initialize tpprev to NULL instead of assigning it
5000         to NULL on the next statement.
5001         * windows-nat.c (windows_delete_thread): Remove check for
5002         main_thread_id before printing thread exit notifications.
5003         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5004         Remove thread ID check against main_thread_id.
5005         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5006         windows_delete_thread.
5007         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5008
5009 2019-01-04  Tom Tromey  <tom@tromey.com>
5010
5011         * compile/compile.c (_initialize_compile): Use upper case for
5012         metasyntactic variables.
5013         * symmisc.c (_initialize_symmisc): Use upper case for
5014         metasyntactic variables.
5015         * psymtab.c (_initialize_psymtab): Use upper case for
5016         metasyntactic variables.
5017         * demangle.c (demangle_command): Use upper case for metasyntactic
5018         variables.
5019         (_initialize_demangler): Likewise.
5020         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5021         variables.
5022
5023 2019-01-03  Tom Tromey  <tom@tromey.com>
5024
5025         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5026
5027 2019-01-03  Tom Tromey  <tom@tromey.com>
5028
5029         * python/py-symtab.c (salpy_str): Update.
5030         (struct salpy_sal_object) <symtab>: Now a PyObject.
5031         (salpy_dealloc): Update.
5032         (del_objfile_sal): Use gdbpy_ref.
5033
5034 2019-01-03  Tom Tromey  <tom@tromey.com>
5035
5036         * python/py-type.c (convert_field): Use new_reference.  Return
5037         gdbpy_ref.
5038         (make_fielditem): Return gdbpy_ref.
5039         (typy_fields): Update.
5040         (typy_getitem): Update.
5041         (field_name): Return gdbpy_ref.  Use new_reference.
5042         (typy_iterator_iternext): Update.
5043
5044 2019-01-03  Tom Tromey  <tom@tromey.com>
5045
5046         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5047
5048 2019-01-03  Tom Tromey  <tom@tromey.com>
5049
5050         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5051         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5052         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5053         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5054         (pspy_set_type_printers): Likewise.
5055         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5056         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5057         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5058         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5059         (objfpy_set_type_printers): Likewise.
5060
5061 2019-01-03  Tom Tromey  <tom@tromey.com>
5062
5063         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5064         (gdbpy_print_stack): Use gdbpy_err_fetch.
5065         * python/python-internal.h (class gdbpy_err_fetch): New class.
5066         (class gdbpy_enter) <m_error_type, m_error_value,
5067         m_error_traceback>: Remove.
5068         <m_error>: New member.
5069         (gdbpy_exception_to_string): Don't declare.
5070         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5071         * python/py-value.c (convert_value_from_python): Use
5072         gdbpy_err_fetch.
5073         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5074         gdbpy_exception_to_string.
5075         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5076         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5077         gdbpy_err_fetch.
5078
5079 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5080
5081         * linux-nat.c (delete_lwp_cleanup): Delete.
5082         (struct lwp_deleter): New struct.
5083         (lwp_info_up): New typedef.
5084         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5085         lwp_info_up.
5086
5087 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5088
5089         * linux-fork.c (class scoped_switch_fork_info): New class.
5090         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5091
5092 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5093
5094         * valops.c (find_overload_match): Remove use of null_cleanup, and
5095         calls to do_cleanups.
5096
5097 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5098
5099         * compile/compile-cplus-types.c
5100         (compile_cplus_instance::decl_name): Handle changes to
5101         cp_func_name.
5102         * cp-support.c (cp_func_name): Update header comment, update
5103         return type.
5104         * cp-support.h (cp_func_name): Update return type in declaration.
5105         * valops.c (find_overload_match): Move temp_func local to top
5106         level of function and change its type.  Use temp_func to hold and
5107         delete temporary string obtained from cp_func_name.
5108
5109 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5110
5111         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5112         gdb::char_vector, remove cleanup, and update uses of `msg`.
5113
5114 2019-01-03  Jim Wilson  <jimw@sifive.com>
5115
5116         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5117
5118 2019-01-02  Tom Tromey  <tom@tromey.com>
5119
5120         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5121         (tdesc_parse_xml): Remove cleanups.
5122         * target-descriptions.h (make_cleanup_free_target_description):
5123         Don't declare.
5124         (target_desc_deleter): New struct.
5125         (target_desc_up): New typedef.
5126         * target-descriptions.c (target_desc_deleter::operator()): Rename
5127         from free_target_description.
5128         (make_cleanup_free_target_description): Remove.
5129
5130 2019-01-02  Tom Tromey  <tom@tromey.com>
5131
5132         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5133         constructor, destructor.
5134         (linespec_parser): Remove typedef.
5135         (~linespec_parser): Rename from linespec_parser_delete.
5136         (linespec_lex_to_end, linespec_complete_label)
5137         (linespec_complete): Update.
5138         (decode_line_full): Remove cleanups.
5139         (decode_line_1): Update.
5140
5141 2019-01-02  Tom Tromey  <tom@tromey.com>
5142
5143         * python/python-internal.h (inferior_to_inferior_object): Change
5144         return type.
5145         * python/py-exitedevent.c (create_exited_event_object): Update.
5146         * python/py-inferior.c (inferior_to_inferior_object): Return
5147         gdbpy_ref.
5148         (python_new_inferior, python_inferior_deleted)
5149         (thread_to_thread_object, delete_thread_object)
5150         (build_inferior_list, gdbpy_selected_inferior): Update.
5151         * python/py-infthread.c (create_thread_object): Update.  Also fail
5152         if inferior_to_inferior_object fails.
5153
5154 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5155
5156         * inferior.h (class inferior) <displaced_step_state>: New field.
5157         * infrun.h (struct displaced_step_state): Move here from
5158         infrun.c.  Initialize fields, add constructor.
5159         <inf>: Remove field.
5160         <reset>: New method.
5161         * infrun.c (struct displaced_step_inferior_state): Move to
5162         infrun.h.
5163         (displaced_step_inferior_states): Remove.
5164         (get_displaced_stepping_state): Adust.
5165         (displaced_step_in_progress_any_inferior): Adjust.
5166         (displaced_step_in_progress_thread): Adjust.
5167         (displaced_step_in_progress): Adjust.
5168         (add_displaced_stepping_state): Remove.
5169         (get_displaced_step_closure_by_addr): Adjust.
5170         (remove_displaced_stepping_state): Remove.
5171         (infrun_inferior_exit): Call displaced_step_state.reset.
5172         (use_displaced_stepping): Don't check for NULL.
5173         (displaced_step_prepare_throw): Call
5174         get_displaced_stepping_state.
5175         (displaced_step_fixup): Don't check for NULL.
5176         (prepare_for_detach): Don't check for NULL.
5177
5178 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5179
5180         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5181          in case of call that did not complete.
5182
5183 2019-01-02  Andrey Utkin  <autkin@undo.io>
5184
5185         * symfile.c (find_separate_debug_file): Fix search of debug files for
5186         remote debuggee.
5187
5188 2019-01-02  Tom Tromey  <tom@tromey.com>
5189
5190         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5191         indentation.
5192         * python/py-frame.c (frapy_older): Remove cast.
5193         (frapy_newer): Likewise.
5194         * python/py-breakpoint.c (local_setattro): Remove cast.
5195         * python/py-arch.c (archpy_name): Remove local variable.
5196         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5197
5198 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5199
5200         * unittests/basic_string_view/element_access/char/empty.cc:
5201         Fix year range in copyright header.
5202
5203 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5204
5205         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5206         Delete.
5207         <operator==>: Update with for removed field.
5208         <hash>: Likewise.
5209         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5210         <isa_features>: ...this.
5211         <abi_features>: New field.
5212         (riscv_isa_flen): Update comment.
5213         (riscv_abi_xlen): New declaration.
5214         (riscv_abi_flen): New declaration.
5215         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5216         isa_features.
5217         (riscv_abi_xlen): New function.
5218         (riscv_isa_flen): Update to get answer from isa_features.
5219         (riscv_abi_flen): New function.
5220         (riscv_has_fp_abi): Update to get answer from abi_features.
5221         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5222         xlen and flen.
5223         (riscv_call_info) <xlen, flen>: Update comment.
5224         (riscv_call_arg_struct): Remove invalid assertions
5225         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5226         is removed.
5227         (riscv_gdbarch_init): Gather isa features and abi features
5228         separately, ensure both match on the gdbarch when reusing an old
5229         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5230         a target with 64-bit float hardware.
5231
5232 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5233
5234         * source.c (search_command_helper): Stop reverse search
5235         when line 1 has been searched.
5236
5237 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5238
5239         * record-full.c (record_full_base_target::close): Rewrite
5240         record_full_core_buf_list free logic.
5241
5242 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5243
5244         * break-catch-syscall.c (print_one_catch_syscall): xfree
5245         the last text.
5246
5247 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5248
5249         * top.c (print_gdb_version): Update Copyright year in version
5250         message.
5251
5252 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5253
5254         Update copyright year range in all GDB files.
5255
5256 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5257
5258         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5259
5260 For older changes see ChangeLog-2018.
5261 \f
5262 Local Variables:
5263 mode: change-log
5264 left-margin: 8
5265 fill-column: 74
5266 version-control: never
5267 coding: utf-8
5268 End:
5269