gdb/ChangeLog

   1 2019-03-14  Tom Tromey  <tromey@adacore.com>
   2
   3         * NEWS: Add item for "style sources" commands.
   4         * source-cache.c (source_cache::get_source_lines): Check
   5         source_styling.
   6         * cli/cli-style.c (source_styling): New global.
   7         (_initialize_cli_style): Add "style sources" commands.
   8         (show_style_sources): New function.
   9         * cli/cli-style.h (source_styling): Declare.
  10
  11 2019-03-14  Pedro Alves  <palves@redhat.com>
  12             Tom Tromey  <tromey@adacore.com>
  13
  14         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  15         * tui/tui-winsource.c (tui_refill_source_window): New function,
  16         from...
  17         (tui_horizontal_source_scroll): ... here.  Move some logic.
  18         * cli/cli-style.c (set_style_enabled): Notify new observable.
  19         * tui/tui-hooks.c (tui_redisplay_source): New function.
  20         (tui_attach_detach_observers): Attach or detach
  21         tui_redisplay_source.
  22         * observable.h (source_styling_changed): New observable.
  23         * observable.c: Define source_styling_changed observable.
  24
  25 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
  26
  27         PR/24325
  28         * source-cache.c: #undef open and close, to avoid unresolved
  29         externals during linking.
  30
  31 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
  32
  33         Support styling on native MS-Windows console
  34
  35         PR/24315
  36         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
  37         on MS-Windows if $TERM is not defined.
  38
  39         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
  40
  41         * posix-hdep.c (gdb_console_fputs):
  42         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
  43         functions.
  44         * ui-file.h (gdb_console_fputs): Add prototype.
  45
  46         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
  47         back to fputs only if the former returns zero.
  48
  49 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
  50             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  51
  52         PR gdb/8527
  53         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
  54         set_sigint_trap, clear_sigint_trap.
  55
  56 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  57
  58         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
  59         for-loop range, to avoid compiler warnings.
  60
  61         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
  62         avoid compiler warnings about unused variables.
  63
  64 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  65
  66         * NEWS: Mention end of support for native debugging on MS-Windows
  67         before XP.
  68
  69 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  70
  71         PR gdb/24292
  72         * common/netstuff.c:
  73         * gdbserver/gdbreplay.c
  74         * gdbserver/remote-utils.c:
  75         * ser-tcp.c:
  76         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
  77         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
  78         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
  79         'getaddrinfo' and 'freeaddrinfo' were not available before
  80         Windows XP, and mingw.org's MinGW headers by default define
  81         _WIN32_WINNT to 0x500.
  82
  83 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
  84
  85         * NEWS: Note minimum Python version.
  86
  87 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  88
  89         * version.in: Set GDB version number to 8.2.90.DATE-git.
  90
  91 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  92
  93         GDB 8.2.90 released.
  94
  95 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  96
  97         * version.in: Set GDB version number to 8.2.90.
  98
  99 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 100
 101         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 102
 103 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 104
 105         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 106         * version.in: Bump version to 8.2.90.DATE-git.
 107
 108 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 109
 110         * aix-thread.c (ptid_cmp): Remove unused variable.
 111         (get_signaled_thread): Likewise.
 112         (store_regs_user_thread): Likewise.
 113         (store_regs_kernel_thread): Likewise.
 114         (fetch_regs_kernel_thread): Remove shadowed variable.
 115
 116 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 117
 118         * features/riscv/32bit-cpu.xml: Add register numbers.
 119         * features/riscv/32bit-fpu.c: Regenerate.
 120         * features/riscv/32bit-fpu.xml: Add register numbers.
 121         * features/riscv/64bit-cpu.xml: Add register numbers.
 122         * features/riscv/64bit-fpu.c: Regenerate.
 123         * features/riscv/64bit-fpu.xml: Add register numbers.
 124
 125 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 126
 127         * NEWS: Mention two argument form of gdb.Value constructor.
 128         * python/py-value.c (convert_buffer_and_type_to_value): New
 129         function.
 130         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 131         Add support for handling an optional second argument.  Call
 132         convert_buffer_and_type_to_value as appropriate.
 133         * python/python-internal.h (Py_buffer_deleter): New struct.
 134         (Py_buffer_up): New typedef.
 135
 136 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 137
 138         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 139         instead of releasing ownership.
 140
 141 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 142
 143         * dwarf2read.c (open_and_init_dwp_file): Call
 144         elf_numsections instead of bfd_count_sections to initialize
 145         dwp_file->num_sections.
 146
 147 2019-02-25  Tom Tromey  <tromey@adacore.com>
 148
 149         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 150
 151 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 152
 153         * gcore.in: Add '--readnever' option when invoking GDB.
 154
 155 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 156
 157         * MAINTAINERS: Update my email address.
 158
 159 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 160
 161         * build-id.c (build_id_to_debug_bfd_1): New function.
 162         (build_id_to_debug_bfd): Look for separate debug file in
 163         sysroot.
 164
 165 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 166
 167         * gdbarch.sh: Update the copyright year range that is placed into
 168         generated files.
 169
 170 2019-02-22  Keith Seitz  <keiths@redhat.com>
 171
 172         PR symtab/23853
 173         * linespec.c (create_sals_line_offset): Search for the default
 174         symtab's filename instead of its fullname.
 175
 176 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 177
 178         * NEWS: Update style defaults.
 179
 180 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 181
 182         * main.c (captured_main_1): Disable styling in batch mode.
 183
 184 2019-02-20  Tom Tromey  <tom@tromey.com>
 185
 186         * symtab.c (symtab_symbol_info): Fix typos.
 187
 188 2019-02-20  Tom Tromey  <tromey@adacore.com>
 189
 190         * findcmd.c (_initialize_mem_search): Use upper case for
 191         metasyntactic variables.
 192
 193 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 194
 195         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 196         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 197
 198 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 199
 200         * top.h (source_file_name): Change to std::string.
 201         * top.c (source_file_name): Likewise.
 202         (command_line_input): Adjust.
 203         * cli/cli-script.c (script_from_file): Adjust.
 204
 205 2019-02-19  Tom Tromey  <tromey@adacore.com>
 206
 207         * ravenscar-thread.c
 208         (ravenscar_thread_target::update_thread_list): Don't call
 209         ada_build_task_list.
 210         * ada-lang.h (ada_build_task_list): Don't declare.
 211         * ada-tasks.c (struct ada_tasks_inferior_data)
 212         <task_list_valid_p>: Now bool.
 213         (read_known_tasks, ada_task_list_changed)
 214         (ada_tasks_invalidate_inferior_data): Update.
 215         (read_known_tasks_array): Return bool.
 216         (read_known_tasks_list): Likewise.
 217         (read_known_tasks): Return void.
 218         (ada_build_task_list): Now static.
 219
 220 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 221
 222         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 223         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 224
 225 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 226
 227         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 228         variant for ada_tasks_pspace_data_handle and
 229         ada_tasks_inferior_data_handle.
 230         (ada_tasks_pspace_data_cleanup): New function.
 231         (ada_tasks_inferior_data_cleanup): New function.
 232
 233 2019-02-17  Tom Tromey  <tom@tromey.com>
 234
 235         * macrotab.h (macro_source_fullname): Return a std::string.
 236         * macrotab.c (macro_include, check_for_redefinition)
 237         (macro_undef, macro_lookup_definition, foreach_macro)
 238         (foreach_macro_in_scope): Update.
 239         (macro_source_fullname): Return a std::string.
 240         * macrocmd.c (show_pp_source_pos): Update.
 241
 242 2019-02-17  Tom Tromey  <tom@tromey.com>
 243
 244         * macrocmd.c (show_pp_source_pos): Style the file names.
 245
 246 2019-02-17  Tom Tromey  <tom@tromey.com>
 247
 248         PR tui/24197:
 249         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 250
 251 2019-02-17  Tom Tromey  <tom@tromey.com>
 252
 253         * ada-lang.c (user_select_syms): Use filtered printing.
 254         * utils.c (wrap_style): New global.
 255         (desired_style): Remove.
 256         (emit_style_escape): Add stream parameter.
 257         (set_output_style, reset_terminal_style, prompt_for_continue):
 258         Update.
 259         (flush_wrap_buffer): Only flush gdb_stdout.
 260         (wrap_here): Set wrap_style.
 261         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 262         treat escape sequences as a character.  Change when wrap buffer is
 263         flushed.
 264         (fputs_styled): Do not set the output style when the default is
 265         requested.
 266         * ui-style.h (struct ui_file_style) <is_default>: New method.
 267         * source.c (print_source_lines_base): Emit escape sequences in one
 268         piece.
 269
 270 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 271
 272         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 273         integers and enumeration types.
 274
 275 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 276
 277         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 278         instead of lookup_symbol_in_language
 279         (do_exact_match): New function.
 280         (ada_get_symbol_name_matcher): Return do_exact_match when
 281         doing a verbatim match.
 282
 283 2019-02-15  Tom Tromey  <tromey@adacore.com>
 284
 285         * ravenscar-thread.c (ravenscar_thread_target::resume)
 286         (ravenscar_thread_target::wait): Special case wildcard requests.
 287
 288 2019-02-15  Tom Tromey  <tromey@adacore.com>
 289
 290         * ravenscar-thread.c (base_ptid): Remove.
 291         (struct ravenscar_thread_target) <close>: New method.
 292         <m_base_ptid>: New member.
 293         <update_inferior_ptid, active_task, task_is_currently_active,
 294         runtime_initialized>: Declare methods.
 295         <ravenscar_thread_target>: Add constructor.
 296         (ravenscar_thread_target::task_is_currently_active)
 297         (ravenscar_thread_target::update_inferior_ptid)
 298         (ravenscar_runtime_initialized): Rename.  Now methods.
 299         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 300         (ravenscar_thread_target::update_thread_list): Update.
 301         (ravenscar_thread_target::active_task): Now method.
 302         (ravenscar_thread_target::store_registers)
 303         (ravenscar_thread_target::prepare_to_store)
 304         (ravenscar_thread_target::prepare_to_store)
 305         (ravenscar_thread_target::mourn_inferior): Update.
 306         (ravenscar_inferior_created): Use "new" to create target.
 307         (ravenscar_thread_target::get_ada_task_ptid): Update.
 308         (_initialize_ravenscar): Don't initialize base_ptid.
 309         (ravenscar_ops): Remove global.
 310
 311 2019-02-15  Tom Tromey  <tromey@adacore.com>
 312
 313         * target.h (push_target): Declare new overload.
 314         * target.c (push_target): New overload, taking an rvalue reference.
 315         * remote.c (remote_target::open_1): Use push_target overload.
 316         * corelow.c (core_target_open): Use push_target overload.
 317
 318 2019-02-15  Tom Tromey  <tromey@adacore.com>
 319
 320         * ravenscar-thread.c (is_ravenscar_task)
 321         (ravenscar_task_is_currently_active): Return bool.
 322         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 323         (_initialize_ravenscar): Remove "(void)".
 324         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 325         Return bool.
 326
 327 2019-02-15  Tom Tromey  <tromey@adacore.com>
 328
 329         * ravenscar-thread.c (ravenscar_runtime_initializer)
 330         (has_ravenscar_runtime, get_running_thread_id)
 331         (ravenscar_thread_target::resume): Fix indentation.
 332
 333 2019-02-15  Tom Tromey  <tromey@adacore.com>
 334
 335         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 336         from ravenscar_arch_ops.
 337         (sparc_ravenscar_ops::fetch_registers)
 338         (sparc_ravenscar_ops::store_registers): Now methods.
 339         (sparc_ravenscar_prepare_to_store): Remove.
 340         (sparc_ravenscar_ops): Redefine.
 341         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 342         methods and destructor.  Remove members.
 343         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 344         (ravenscar_thread_target::store_registers)
 345         (ravenscar_thread_target::prepare_to_store): Update.
 346         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 347         Remove.
 348         (struct ppc_ravenscar_powerpc_ops): Derive from
 349         ravenscar_arch_ops.
 350         (ppc_ravenscar_powerpc_ops::fetch_registers)
 351         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 352         (ppc_ravenscar_powerpc_ops): Redefine.
 353         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 354         (ppc_ravenscar_e500_ops::fetch_registers)
 355         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 356         (ppc_ravenscar_e500_ops): Redefine.
 357         * aarch64-ravenscar-thread.c
 358         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 359         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 360         (aarch64_ravenscar_fetch_registers)
 361         (aarch64_ravenscar_store_registers): Now methods.
 362         (aarch64_ravenscar_ops): Redefine.
 363
 364 2019-02-15  Tom Tromey  <tromey@adacore.com>
 365
 366         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 367         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 368         (ravenscar_thread_target::stopped_by_watchpoint)
 369         (ravenscar_thread_target::stopped_data_address)
 370         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 371
 372 2019-02-15  Tom Tromey  <tromey@adacore.com>
 373
 374         * ravenscar-thread.c: Fix some typos.
 375
 376 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 377             Tom Tromey  <tromey@adacore.com>
 378
 379         * ada-lang.c (ada_exception_sal): Change addr_string to a
 380         std::string.
 381         (create_ada_exception_catchpoint): Update.
 382
 383 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 384             Tom Tromey  <tromey@adacore.com>
 385
 386         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 387         (bp_location_ops): Remove.
 388         (base_breakpoint_allocate_location): Update.
 389         (free_bp_location): Update.
 390         * ada-lang.c (class ada_catchpoint_location)
 391         <ada_catchpoint_location>: Remove ops parameter.
 392         (ada_catchpoint_location_dtor): Remove.
 393         (ada_catchpoint_location_ops): Remove.
 394         (allocate_location_exception): Update.
 395         * breakpoint.h (struct bp_location_ops): Remove.
 396         (class bp_location) <bp_location>: Remove bp_location_ops
 397         parameter.
 398         <~bp_location>: Add destructor.
 399         <ops>: Remove.
 400
 401 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 402             Pedro Alves  <palves@redhat.com>
 403
 404         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 405         'PATH_MAX'.
 406
 407 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 408             Samuel Thibault  <samuel.thibault@gnu.org>
 409             Thomas Schwinge  <thomas@codesourcery.com>
 410
 411         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 412         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 413
 414 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 415
 416         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 417         (check_empty): Use "const char *".
 418
 419         * gnu-nat.c (gnu_nat_target::detach): Instead of
 420         'detach_inferior (pid)' call
 421         'detach_inferior (find_inferior_pid (pid))'.
 422
 423         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 424         'nat/fork-inferior.o'.
 425         * gnu-nat.c: #include "nat/fork-inferior.h".
 426
 427         * gnu-nat.c (gnu_nat_target::detach): Instead of
 428         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 429         * gnu-nat.h: #include "inf-child.h".
 430         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 431         'i386_gnu_nat_target::fetch_registers'.
 432         (gnu_store_registers): Rename/move to
 433         'i386_gnu_nat_target::store_registers'.
 434
 435         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 436         * gnu-nat.h (mach_thread_info): New function.
 437         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 438
 439         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 440
 441 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 442
 443         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 444
 445 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 446
 447         * windows-nat.c (windows_add_thread): Add new parameter
 448         "main_thread_p" with default value set to false.  Update
 449         function documentation as well as all callers.
 450         (windows_delete_thread): Likewise.
 451         (fake_create_process): Update call to windows_add_thread.
 452         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 453         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 454         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 455         call to windows_delete_thread.
 456
 457 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 458
 459         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 460
 461 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 462
 463         * symfile.c (find_separate_debug_file): Use canonical path of
 464         sysroot with child_path instead of gdb_sysroot if it is valid.
 465
 466 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 467
 468         * symfile.c (find_separate_debug_file): Use child_path to
 469         determine if an object file is under a sysroot.
 470
 471 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 472
 473         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 474         unittests/child-path-selftests.c.
 475         * common/pathstuff.c (child_path): New function.
 476         * common/pathstuff.h (child_path): New prototype.
 477         * unittests/child-path-selftests.c: New file.
 478
 479 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 480
 481         * symfile.c (find_separate_debug_file): Look for separate debug
 482         files in debug directories under the sysroot.
 483
 484 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 485
 486         * symtab.h (struct minimal_symbol data_p): New const method.
 487         (struct minimal_symbol text_p): Likewise.
 488         * symtab.c (output_source_filename): Use file name style
 489         to print file name.
 490         (print_symbol_info): Likewise.
 491         (print_msymbol_info): Use address style to print addresses.
 492         Use function name style to print executable text symbols.
 493         (expand_symtab_containing_pc): Use data_p.
 494         (find_pc_sect_compunit_symtab): Likewise.
 495
 496 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 497
 498         * breakpoint.c (describe_other_breakpoints): Use address style
 499         to print addresses.
 500         (say_where): Likewise.
 501
 502 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 503
 504         * ada-typeprint.c (print_func_type): Print function name
 505         style to print function name.
 506         * c-typeprint.c (c_print_type_1): Likewise.
 507
 508 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 509
 510         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 511         for execve.
 512
 513 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 514
 515         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 516         type_stack.
 517
 518 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 519
 520         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 521         TYPE_CODE_REF types.
 522
 523 2019-02-08  Jim Wilson  <jimw@sifive.com>
 524
 525         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 526         (riscv_linux_fregset): New.
 527         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 528
 529 2019-02-07  Tom Tromey  <tom@tromey.com>
 530
 531         * thread.c (thread_cancel_execution_command): Update.
 532         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 533         methods.
 534         (struct thread_fsm_ops): Remove.
 535         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 536         (thread_fsm_should_stop, thread_fsm_return_value)
 537         (thread_fsm_set_finished, thread_fsm_finished_p)
 538         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 539         Don't declare.
 540         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 541         * infrun.c (clear_proceed_status_thread)
 542         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 543         (print_stop_event): Update.
 544         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 545         Add constructor.
 546         (step_command_fsm_ops): Remove.
 547         (new_step_command_fsm): Remove.
 548         (step_1): Update.
 549         (step_command_fsm::should_stop): Rename from
 550         step_command_fsm_should_stop.
 551         (step_command_fsm::clean_up): Rename from
 552         step_command_fsm_clean_up.
 553         (step_command_fsm::do_async_reply_reason): Rename from
 554         step_command_fsm_async_reply_reason.
 555         (struct until_next_fsm): Inherit from thread_fsm.  Add
 556         constructor.
 557         (until_next_fsm_ops): Remove.
 558         (new_until_next_fsm): Remove.
 559         (until_next_fsm::should_stop): Rename from
 560         until_next_fsm_should_stop.
 561         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 562         (until_next_fsm::do_async_reply_reason): Rename from
 563         until_next_fsm_async_reply_reason.
 564         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 565         constructor.  Change type of breakpoint.
 566         (finish_command_fsm_ops): Remove.
 567         (new_finish_command_fsm): Remove.
 568         (finish_command_fsm::should_stop): Rename from
 569         finish_command_fsm_should_stop.
 570         (finish_command_fsm::clean_up): Rename from
 571         finish_command_fsm_clean_up.
 572         (finish_command_fsm::return_value): Rename from
 573         finish_command_fsm_return_value.
 574         (finish_command_fsm::do_async_reply_reason): Rename from
 575         finish_command_fsm_async_reply_reason.
 576         (finish_command): Update.
 577         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 578         Add constructor.
 579         (call_thread_fsm_ops): Remove.
 580         (call_thread_fsm::call_thread_fsm): Rename from
 581         new_call_thread_fsm.
 582         (call_thread_fsm::should_stop): Rename from
 583         call_thread_fsm_should_stop.
 584         (call_thread_fsm::should_notify_stop): Rename from
 585         call_thread_fsm_should_notify_stop.
 586         (run_inferior_call, call_function_by_hand_dummy): Update.
 587         * cli/cli-interp.c (should_print_stop_to_console): Update.
 588         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 589         Add constructor.  Change type of location_breakpoint,
 590         caller_breakpoint.
 591         (until_break_fsm_ops): Remove.
 592         (new_until_break_fsm): Remove.
 593         (until_break_fsm::should_stop): Rename from
 594         until_break_fsm_should_stop.
 595         (until_break_fsm::clean_up): Rename from
 596         until_break_fsm_clean_up.
 597         (until_break_fsm::do_async_reply_reason): Rename from
 598         until_break_fsm_async_reply_reason.
 599         (until_break_command): Update.
 600         * thread-fsm.c: Remove.
 601         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 602
 603 2019-02-07  Tom Tromey  <tom@tromey.com>
 604
 605         * yy-remap.h: Add include guard.
 606         * xtensa-tdep.h: Add include guard.
 607         * xcoffread.h: Rename include guard.
 608         * varobj-iter.h: Add include guard.
 609         * tui/tui.h: Rename include guard.
 610         * tui/tui-winsource.h: Rename include guard.
 611         * tui/tui-wingeneral.h: Rename include guard.
 612         * tui/tui-windata.h: Rename include guard.
 613         * tui/tui-win.h: Rename include guard.
 614         * tui/tui-stack.h: Rename include guard.
 615         * tui/tui-source.h: Rename include guard.
 616         * tui/tui-regs.h: Rename include guard.
 617         * tui/tui-out.h: Rename include guard.
 618         * tui/tui-layout.h: Rename include guard.
 619         * tui/tui-io.h: Rename include guard.
 620         * tui/tui-hooks.h: Rename include guard.
 621         * tui/tui-file.h: Rename include guard.
 622         * tui/tui-disasm.h: Rename include guard.
 623         * tui/tui-data.h: Rename include guard.
 624         * tui/tui-command.h: Rename include guard.
 625         * tic6x-tdep.h: Add include guard.
 626         * target/waitstatus.h: Rename include guard.
 627         * target/wait.h: Rename include guard.
 628         * target/target.h: Rename include guard.
 629         * target/resume.h: Rename include guard.
 630         * target-float.h: Rename include guard.
 631         * stabsread.h: Add include guard.
 632         * rs6000-tdep.h: Add include guard.
 633         * riscv-fbsd-tdep.h: Add include guard.
 634         * regformats/regdef.h: Rename include guard.
 635         * record.h: Rename include guard.
 636         * python/python.h: Rename include guard.
 637         * python/python-internal.h: Rename include guard.
 638         * python/py-stopevent.h: Rename include guard.
 639         * python/py-ref.h: Rename include guard.
 640         * python/py-record.h: Rename include guard.
 641         * python/py-record-full.h: Rename include guard.
 642         * python/py-record-btrace.h: Rename include guard.
 643         * python/py-instruction.h: Rename include guard.
 644         * python/py-events.h: Rename include guard.
 645         * python/py-event.h: Rename include guard.
 646         * procfs.h: Add include guard.
 647         * proc-utils.h: Add include guard.
 648         * p-lang.h: Add include guard.
 649         * or1k-tdep.h: Rename include guard.
 650         * observable.h: Rename include guard.
 651         * nto-tdep.h: Rename include guard.
 652         * nat/x86-linux.h: Rename include guard.
 653         * nat/x86-linux-dregs.h: Rename include guard.
 654         * nat/x86-gcc-cpuid.h: Add include guard.
 655         * nat/x86-dregs.h: Rename include guard.
 656         * nat/x86-cpuid.h: Rename include guard.
 657         * nat/ppc-linux.h: Rename include guard.
 658         * nat/mips-linux-watch.h: Rename include guard.
 659         * nat/linux-waitpid.h: Rename include guard.
 660         * nat/linux-ptrace.h: Rename include guard.
 661         * nat/linux-procfs.h: Rename include guard.
 662         * nat/linux-osdata.h: Rename include guard.
 663         * nat/linux-nat.h: Rename include guard.
 664         * nat/linux-namespaces.h: Rename include guard.
 665         * nat/linux-btrace.h: Rename include guard.
 666         * nat/glibc_thread_db.h: Rename include guard.
 667         * nat/gdb_thread_db.h: Rename include guard.
 668         * nat/gdb_ptrace.h: Rename include guard.
 669         * nat/fork-inferior.h: Rename include guard.
 670         * nat/amd64-linux-siginfo.h: Rename include guard.
 671         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 672         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 673         * nat/aarch64-linux.h: Rename include guard.
 674         * nat/aarch64-linux-hw-point.h: Rename include guard.
 675         * mn10300-tdep.h: Add include guard.
 676         * mips-linux-tdep.h: Add include guard.
 677         * mi/mi-parse.h: Rename include guard.
 678         * mi/mi-out.h: Rename include guard.
 679         * mi/mi-main.h: Rename include guard.
 680         * mi/mi-interp.h: Rename include guard.
 681         * mi/mi-getopt.h: Rename include guard.
 682         * mi/mi-console.h: Rename include guard.
 683         * mi/mi-common.h: Rename include guard.
 684         * mi/mi-cmds.h: Rename include guard.
 685         * mi/mi-cmd-break.h: Rename include guard.
 686         * m2-lang.h: Add include guard.
 687         * location.h: Rename include guard.
 688         * linux-record.h: Rename include guard.
 689         * linux-nat.h: Add include guard.
 690         * linux-fork.h: Add include guard.
 691         * i386-darwin-tdep.h: Rename include guard.
 692         * hppa-linux-offsets.h: Add include guard.
 693         * guile/guile.h: Rename include guard.
 694         * guile/guile-internal.h: Rename include guard.
 695         * gnu-nat.h: Rename include guard.
 696         * gdb-stabs.h: Rename include guard.
 697         * frv-tdep.h: Add include guard.
 698         * f-lang.h: Add include guard.
 699         * event-loop.h: Add include guard.
 700         * darwin-nat.h: Rename include guard.
 701         * cp-abi.h: Rename include guard.
 702         * config/sparc/nm-sol2.h: Rename include guard.
 703         * config/nm-nto.h: Rename include guard.
 704         * config/nm-linux.h: Add include guard.
 705         * config/i386/nm-i386gnu.h: Rename include guard.
 706         * config/djgpp/nl_types.h: Rename include guard.
 707         * config/djgpp/langinfo.h: Rename include guard.
 708         * compile/gcc-cp-plugin.h: Add include guard.
 709         * compile/gcc-c-plugin.h: Add include guard.
 710         * compile/compile.h: Rename include guard.
 711         * compile/compile-object-run.h: Rename include guard.
 712         * compile/compile-object-load.h: Rename include guard.
 713         * compile/compile-internal.h: Rename include guard.
 714         * compile/compile-cplus.h: Rename include guard.
 715         * compile/compile-c.h: Rename include guard.
 716         * common/xml-utils.h: Rename include guard.
 717         * common/x86-xstate.h: Rename include guard.
 718         * common/version.h: Rename include guard.
 719         * common/vec.h: Rename include guard.
 720         * common/tdesc.h: Rename include guard.
 721         * common/selftest.h: Rename include guard.
 722         * common/scoped_restore.h: Rename include guard.
 723         * common/scoped_mmap.h: Rename include guard.
 724         * common/scoped_fd.h: Rename include guard.
 725         * common/safe-iterator.h: Rename include guard.
 726         * common/run-time-clock.h: Rename include guard.
 727         * common/refcounted-object.h: Rename include guard.
 728         * common/queue.h: Rename include guard.
 729         * common/ptid.h: Rename include guard.
 730         * common/print-utils.h: Rename include guard.
 731         * common/preprocessor.h: Rename include guard.
 732         * common/pathstuff.h: Rename include guard.
 733         * common/observable.h: Rename include guard.
 734         * common/netstuff.h: Rename include guard.
 735         * common/job-control.h: Rename include guard.
 736         * common/host-defs.h: Rename include guard.
 737         * common/gdb_wait.h: Rename include guard.
 738         * common/gdb_vecs.h: Rename include guard.
 739         * common/gdb_unlinker.h: Rename include guard.
 740         * common/gdb_unique_ptr.h: Rename include guard.
 741         * common/gdb_tilde_expand.h: Rename include guard.
 742         * common/gdb_sys_time.h: Rename include guard.
 743         * common/gdb_string_view.h: Rename include guard.
 744         * common/gdb_splay_tree.h: Rename include guard.
 745         * common/gdb_setjmp.h: Rename include guard.
 746         * common/gdb_ref_ptr.h: Rename include guard.
 747         * common/gdb_optional.h: Rename include guard.
 748         * common/gdb_locale.h: Rename include guard.
 749         * common/gdb_assert.h: Rename include guard.
 750         * common/filtered-iterator.h: Rename include guard.
 751         * common/filestuff.h: Rename include guard.
 752         * common/fileio.h: Rename include guard.
 753         * common/environ.h: Rename include guard.
 754         * common/common-utils.h: Rename include guard.
 755         * common/common-types.h: Rename include guard.
 756         * common/common-regcache.h: Rename include guard.
 757         * common/common-inferior.h: Rename include guard.
 758         * common/common-gdbthread.h: Rename include guard.
 759         * common/common-exceptions.h: Rename include guard.
 760         * common/common-defs.h: Rename include guard.
 761         * common/common-debug.h: Rename include guard.
 762         * common/cleanups.h: Rename include guard.
 763         * common/buffer.h: Rename include guard.
 764         * common/btrace-common.h: Rename include guard.
 765         * common/break-common.h: Rename include guard.
 766         * cli/cli-utils.h: Rename include guard.
 767         * cli/cli-style.h: Rename include guard.
 768         * cli/cli-setshow.h: Rename include guard.
 769         * cli/cli-script.h: Rename include guard.
 770         * cli/cli-interp.h: Rename include guard.
 771         * cli/cli-decode.h: Rename include guard.
 772         * cli/cli-cmds.h: Rename include guard.
 773         * charset-list.h: Add include guard.
 774         * buildsym-legacy.h: Rename include guard.
 775         * bfin-tdep.h: Add include guard.
 776         * ax.h: Rename include guard.
 777         * arm-linux-tdep.h: Add include guard.
 778         * arm-fbsd-tdep.h: Add include guard.
 779         * arch/xtensa.h: Rename include guard.
 780         * arch/tic6x.h: Add include guard.
 781         * arch/i386.h: Add include guard.
 782         * arch/arm.h: Rename include guard.
 783         * arch/arm-linux.h: Rename include guard.
 784         * arch/arm-get-next-pcs.h: Rename include guard.
 785         * arch/amd64.h: Add include guard.
 786         * arch/aarch64-insn.h: Rename include guard.
 787         * arch-utils.h: Rename include guard.
 788         * annotate.h: Add include guard.
 789         * amd64-darwin-tdep.h: Rename include guard.
 790         * aarch64-linux-tdep.h: Add include guard.
 791         * aarch64-fbsd-tdep.h: Add include guard.
 792         * aarch32-linux-nat.h: Add include guard.
 793
 794 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 795
 796         * macrotab.c (macro_define_internal): New function that
 797         factorizes macro_define_object_internal and macro_define_function
 798         code.
 799         (macro_define_object_internal): Use macro_define_internal.
 800         (macro_define_function): Likewise.
 801
 802 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 803
 804         * macrocmd.c (extract_identifier): Return
 805         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 806         callers.
 807
 808 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 809
 810         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 811
 812 2019-02-05  Tom Tromey  <tom@tromey.com>
 813
 814         * target.c (target_stack::unpush): Move assertion earlier.
 815
 816 2019-01-30  Tom Tromey  <tom@tromey.com>
 817
 818         PR python/23615:
 819         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 820         (gdbpy_parse_and_eval): Likewise.
 821         * python/python-internal.h (gdbpy_allow_threads): New class.
 822
 823 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 824
 825         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 826         (aarch64_fbsd_fpregmap): Move earlier.
 827         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 828         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 829         instead of individual calls to trad_frame_set_reg_addr.
 830         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 831         earlier.
 832         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 833         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 834         instead of individual calls to trad_frame_set_reg_addr.
 835
 836 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 837
 838         * CONTRIBUTE: Replace contribution list with wiki link.
 839
 840 2019-01-25  Tom Tromey  <tom@tromey.com>
 841
 842         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 843
 844 2019-01-25  Tom Tromey  <tom@tromey.com>
 845
 846         * xtensa-linux-nat.c: Fix common/ includes.
 847         * xml-support.h: Fix common/ includes.
 848         * xml-support.c: Fix common/ includes.
 849         * x86-linux-nat.c: Fix common/ includes.
 850         * windows-nat.c: Fix common/ includes.
 851         * varobj.h: Fix common/ includes.
 852         * varobj.c: Fix common/ includes.
 853         * value.c: Fix common/ includes.
 854         * valops.c: Fix common/ includes.
 855         * utils.c: Fix common/ includes.
 856         * unittests/xml-utils-selftests.c: Fix common/ includes.
 857         * unittests/utils-selftests.c: Fix common/ includes.
 858         * unittests/unpack-selftests.c: Fix common/ includes.
 859         * unittests/tracepoint-selftests.c: Fix common/ includes.
 860         * unittests/style-selftests.c: Fix common/ includes.
 861         * unittests/string_view-selftests.c: Fix common/ includes.
 862         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 863         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 864         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 865         * unittests/rsp-low-selftests.c: Fix common/ includes.
 866         * unittests/parse-connection-spec-selftests.c: Fix common/
 867         includes.
 868         * unittests/optional-selftests.c: Fix common/ includes.
 869         * unittests/offset-type-selftests.c: Fix common/ includes.
 870         * unittests/observable-selftests.c: Fix common/ includes.
 871         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 872         * unittests/memrange-selftests.c: Fix common/ includes.
 873         * unittests/memory-map-selftests.c: Fix common/ includes.
 874         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 875         * unittests/function-view-selftests.c: Fix common/ includes.
 876         * unittests/environ-selftests.c: Fix common/ includes.
 877         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 878         * unittests/common-utils-selftests.c: Fix common/ includes.
 879         * unittests/cli-utils-selftests.c: Fix common/ includes.
 880         * unittests/array-view-selftests.c: Fix common/ includes.
 881         * ui-file.c: Fix common/ includes.
 882         * tui/tui-io.c: Fix common/ includes.
 883         * tracepoint.h: Fix common/ includes.
 884         * tracepoint.c: Fix common/ includes.
 885         * tracefile-tfile.c: Fix common/ includes.
 886         * top.h: Fix common/ includes.
 887         * top.c: Fix common/ includes.
 888         * thread.c: Fix common/ includes.
 889         * target/waitstatus.h: Fix common/ includes.
 890         * target/waitstatus.c: Fix common/ includes.
 891         * target.h: Fix common/ includes.
 892         * target.c: Fix common/ includes.
 893         * target-memory.c: Fix common/ includes.
 894         * target-descriptions.c: Fix common/ includes.
 895         * symtab.h: Fix common/ includes.
 896         * symfile.c: Fix common/ includes.
 897         * stap-probe.c: Fix common/ includes.
 898         * spu-linux-nat.c: Fix common/ includes.
 899         * sparc-nat.c: Fix common/ includes.
 900         * source.c: Fix common/ includes.
 901         * solib.c: Fix common/ includes.
 902         * solib-target.c: Fix common/ includes.
 903         * ser-unix.c: Fix common/ includes.
 904         * ser-tcp.c: Fix common/ includes.
 905         * ser-pipe.c: Fix common/ includes.
 906         * ser-base.c: Fix common/ includes.
 907         * selftest-arch.c: Fix common/ includes.
 908         * s12z-tdep.c: Fix common/ includes.
 909         * rust-exp.y: Fix common/ includes.
 910         * rs6000-aix-tdep.c: Fix common/ includes.
 911         * riscv-tdep.c: Fix common/ includes.
 912         * remote.c: Fix common/ includes.
 913         * remote-notif.h: Fix common/ includes.
 914         * remote-fileio.h: Fix common/ includes.
 915         * remote-fileio.c: Fix common/ includes.
 916         * regcache.h: Fix common/ includes.
 917         * regcache.c: Fix common/ includes.
 918         * record-btrace.c: Fix common/ includes.
 919         * python/python.c: Fix common/ includes.
 920         * python/py-type.c: Fix common/ includes.
 921         * python/py-inferior.c: Fix common/ includes.
 922         * progspace.h: Fix common/ includes.
 923         * producer.c: Fix common/ includes.
 924         * procfs.c: Fix common/ includes.
 925         * proc-api.c: Fix common/ includes.
 926         * printcmd.c: Fix common/ includes.
 927         * ppc-linux-nat.c: Fix common/ includes.
 928         * parser-defs.h: Fix common/ includes.
 929         * osdata.c: Fix common/ includes.
 930         * obsd-nat.c: Fix common/ includes.
 931         * nat/x86-linux.c: Fix common/ includes.
 932         * nat/x86-linux-dregs.c: Fix common/ includes.
 933         * nat/x86-dregs.h: Fix common/ includes.
 934         * nat/x86-dregs.c: Fix common/ includes.
 935         * nat/ppc-linux.c: Fix common/ includes.
 936         * nat/mips-linux-watch.h: Fix common/ includes.
 937         * nat/mips-linux-watch.c: Fix common/ includes.
 938         * nat/linux-waitpid.c: Fix common/ includes.
 939         * nat/linux-ptrace.h: Fix common/ includes.
 940         * nat/linux-ptrace.c: Fix common/ includes.
 941         * nat/linux-procfs.c: Fix common/ includes.
 942         * nat/linux-personality.c: Fix common/ includes.
 943         * nat/linux-osdata.c: Fix common/ includes.
 944         * nat/linux-namespaces.c: Fix common/ includes.
 945         * nat/linux-btrace.h: Fix common/ includes.
 946         * nat/linux-btrace.c: Fix common/ includes.
 947         * nat/fork-inferior.c: Fix common/ includes.
 948         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 949         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 950         * nat/aarch64-linux.c: Fix common/ includes.
 951         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 952         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 953         * namespace.h: Fix common/ includes.
 954         * mips-linux-tdep.c: Fix common/ includes.
 955         * minsyms.c: Fix common/ includes.
 956         * mi/mi-parse.h: Fix common/ includes.
 957         * mi/mi-main.c: Fix common/ includes.
 958         * mi/mi-cmd-env.c: Fix common/ includes.
 959         * memrange.h: Fix common/ includes.
 960         * memattr.c: Fix common/ includes.
 961         * maint.h: Fix common/ includes.
 962         * maint.c: Fix common/ includes.
 963         * main.c: Fix common/ includes.
 964         * machoread.c: Fix common/ includes.
 965         * location.c: Fix common/ includes.
 966         * linux-thread-db.c: Fix common/ includes.
 967         * linux-nat.c: Fix common/ includes.
 968         * linux-fork.c: Fix common/ includes.
 969         * inline-frame.c: Fix common/ includes.
 970         * infrun.c: Fix common/ includes.
 971         * inflow.c: Fix common/ includes.
 972         * inferior.h: Fix common/ includes.
 973         * inferior.c: Fix common/ includes.
 974         * infcmd.c: Fix common/ includes.
 975         * inf-ptrace.c: Fix common/ includes.
 976         * inf-child.c: Fix common/ includes.
 977         * ia64-linux-nat.c: Fix common/ includes.
 978         * i387-tdep.c: Fix common/ includes.
 979         * i386-tdep.c: Fix common/ includes.
 980         * i386-linux-tdep.c: Fix common/ includes.
 981         * i386-linux-nat.c: Fix common/ includes.
 982         * i386-go32-tdep.c: Fix common/ includes.
 983         * i386-fbsd-tdep.c: Fix common/ includes.
 984         * i386-fbsd-nat.c: Fix common/ includes.
 985         * guile/scm-type.c: Fix common/ includes.
 986         * guile/guile.c: Fix common/ includes.
 987         * go32-nat.c: Fix common/ includes.
 988         * gnu-nat.c: Fix common/ includes.
 989         * gdbthread.h: Fix common/ includes.
 990         * gdbarch-selftests.c: Fix common/ includes.
 991         * gdb_usleep.c: Fix common/ includes.
 992         * gdb_select.h: Fix common/ includes.
 993         * gdb_bfd.c: Fix common/ includes.
 994         * gcore.c: Fix common/ includes.
 995         * fork-child.c: Fix common/ includes.
 996         * findvar.c: Fix common/ includes.
 997         * fbsd-nat.c: Fix common/ includes.
 998         * event-top.c: Fix common/ includes.
 999         * event-loop.c: Fix common/ includes.
1000         * dwarf2read.c: Fix common/ includes.
1001         * dwarf2loc.c: Fix common/ includes.
1002         * dwarf2-frame.c: Fix common/ includes.
1003         * dwarf-index-cache.c: Fix common/ includes.
1004         * dtrace-probe.c: Fix common/ includes.
1005         * disasm-selftests.c: Fix common/ includes.
1006         * defs.h: Fix common/ includes.
1007         * csky-tdep.c: Fix common/ includes.
1008         * cp-valprint.c: Fix common/ includes.
1009         * cp-support.h: Fix common/ includes.
1010         * cp-support.c: Fix common/ includes.
1011         * corelow.c: Fix common/ includes.
1012         * completer.h: Fix common/ includes.
1013         * completer.c: Fix common/ includes.
1014         * compile/compile.c: Fix common/ includes.
1015         * compile/compile-loc2c.c: Fix common/ includes.
1016         * compile/compile-cplus-types.c: Fix common/ includes.
1017         * compile/compile-cplus-symbols.c: Fix common/ includes.
1018         * command.h: Fix common/ includes.
1019         * cli/cli-dump.c: Fix common/ includes.
1020         * cli/cli-cmds.c: Fix common/ includes.
1021         * charset.c: Fix common/ includes.
1022         * build-id.c: Fix common/ includes.
1023         * btrace.h: Fix common/ includes.
1024         * btrace.c: Fix common/ includes.
1025         * breakpoint.h: Fix common/ includes.
1026         * breakpoint.c: Fix common/ includes.
1027         * ax.h:
1028         (enum agent_op): Fix common/ includes.
1029         * ax-general.c (struct aop_map): Fix common/ includes.
1030         * ax-gdb.c: Fix common/ includes.
1031         * auxv.c: Fix common/ includes.
1032         * auto-load.c: Fix common/ includes.
1033         * arm-tdep.c: Fix common/ includes.
1034         * arch/riscv.c: Fix common/ includes.
1035         * arch/ppc-linux-common.c: Fix common/ includes.
1036         * arch/i386.c: Fix common/ includes.
1037         * arch/arm.c: Fix common/ includes.
1038         * arch/arm-linux.c: Fix common/ includes.
1039         * arch/arm-get-next-pcs.c: Fix common/ includes.
1040         * arch/amd64.c: Fix common/ includes.
1041         * arch/aarch64.c: Fix common/ includes.
1042         * arch/aarch64-insn.c: Fix common/ includes.
1043         * arch-utils.c: Fix common/ includes.
1044         * amd64-windows-tdep.c: Fix common/ includes.
1045         * amd64-tdep.c: Fix common/ includes.
1046         * amd64-sol2-tdep.c: Fix common/ includes.
1047         * amd64-obsd-tdep.c: Fix common/ includes.
1048         * amd64-nbsd-tdep.c: Fix common/ includes.
1049         * amd64-linux-tdep.c: Fix common/ includes.
1050         * amd64-linux-nat.c: Fix common/ includes.
1051         * amd64-fbsd-tdep.c: Fix common/ includes.
1052         * amd64-fbsd-nat.c: Fix common/ includes.
1053         * amd64-dicos-tdep.c: Fix common/ includes.
1054         * amd64-darwin-tdep.c: Fix common/ includes.
1055         * agent.c: Fix common/ includes.
1056         * ada-lang.h: Fix common/ includes.
1057         * ada-lang.c: Fix common/ includes.
1058         * aarch64-tdep.c: Fix common/ includes.
1059
1060 2019-01-25  Tom Tromey  <tom@tromey.com>
1061
1062         * common/create-version.sh: Use common/version.h.
1063
1064 2019-01-24  Pedro Alves  <palves@redhat.com>
1065
1066         * infrun.c (signal_stop, signal_print, signal_program)
1067         (signal_catch, signal_pass): Now arrays instead of pointers.
1068         (update_signals_program_target, do_target_resume)
1069         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1070         * linux-nat.c (linux_nat_target::pass_signals)
1071         (linux_nat_target::create_inferior, linux_nat_target::attach):
1072         Adjust.
1073         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1074         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1075         * procfs.c (procfs_target::pass_signals): Adjust.
1076         * record-full.c (record_full_target::resume): Adjust.
1077         * remote.c (remote_target::pass_signals)
1078         (remote_target::program_signals): Adjust.
1079         * target-debug.h (target_debug_print_signals): Now takes a
1080         gdb::array_view as parameter.  Adjust.
1081         * target.h (target_ops) <pass_signals, program_signals>: Replace
1082         pointer and length parameters with gdb::array_view.
1083         (target_pass_signals, target_program_signals): Likewise.
1084         * target-delegates.c: Regenerate.
1085
1086 2019-01-24  Pedro Alves  <palves@redhat.com>
1087
1088         * common/forward-scope-exit.h
1089         (forward_scope_exit::forward_scope_exit): Pass arguments to
1090         m_bind_function directly, instead of creating a std::bind and
1091         copying that.
1092
1093 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1094
1095         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1096         for static members.
1097         (pass_in_v_vfp_candidate): Likewise.
1098
1099 2019-01-23  Tom Tromey  <tom@tromey.com>
1100             Pedro Alves  <palves@redhat.com>
1101
1102         * regcache.c (class regcache_invalidator): Remove.
1103         (regcache::raw_write): Use make_scope_exit.
1104
1105 2019-01-23  Tom Tromey  <tom@tromey.com>
1106
1107         * ui-out.h (class ui_out_emit_type): Update comment.
1108
1109 2019-01-23  Tom Tromey  <tom@tromey.com>
1110
1111         * infrun.c (fetch_inferior_event): Update comment.
1112
1113 2019-01-23  Tom Tromey  <tom@tromey.com>
1114             Pedro Alves  <palves@redhat.com>
1115
1116         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1117         parameter.
1118         (fetch_inferior_event): Use SCOPE_EXIT.
1119
1120
1121 2019-01-23  Tom Tromey  <tom@tromey.com>
1122             Pedro Alves  <palves@redhat.com>
1123
1124         * infrun.c (disable_thread_events): Delete.
1125         (stop_all_threads): Use SCOPE_EXIT.
1126
1127 2019-01-23  Tom Tromey  <tom@tromey.com>
1128             Pedro Alves  <palves@redhat.com>
1129
1130         * symfile.c: Include forward-scope-exit.h.
1131         (clear_symtab_users_cleanup): Replace forward declaration with
1132         a FORWARD_SCOPE_EXIT.
1133         (syms_from_objfile_1): Use the forward_scope_exit and
1134         gdb::optional instead of cleanup_function.
1135         (reread_symbols): Use the forward_scope_exit instead of
1136         cleanup_function.
1137         (clear_symtab_users_cleanup): Remove function.
1138
1139 2019-01-23  Tom Tromey  <tom@tromey.com>
1140             Pedro Alves  <palves@redhat.com>
1141
1142         * linux-nat.c: Include scope-exit.h.
1143         (cleanup_target_stop): Remove.
1144         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1145         SCOPE_EXIT.
1146
1147 2019-01-23  Tom Tromey  <tom@tromey.com>
1148             Pedro Alves  <palves@redhat.com>
1149
1150         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1151         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1152
1153 2019-01-23  Tom Tromey  <tom@tromey.com>
1154             Andrew Burgess  <andrew.burgess@embecosm.com>
1155             Pedro Alves  <palves@redhat.com>
1156
1157         * infrun.c (fetch_inferior_event): Use scope_exit.
1158         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1159         * top.c (execute_command): Use scope_exit.
1160         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1161         * utils.c (do_bpstat_clear_actions_cleanup)
1162         (make_bpstat_clear_actions_cleanup): Remove.
1163
1164 2019-01-23  Tom Tromey  <tom@tromey.com>
1165             Pedro Alves  <palves@redhat.com>
1166
1167         * infrun.c: Include "common/scope-exit.h"
1168         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1169         (wait_for_inferior): Use SCOPE_EXIT.
1170         (fetch_inferior_event): Use scope_exit.
1171
1172 2019-01-23  Tom Tromey  <tom@tromey.com>
1173             Pedro Alves  <palves@redhat.com>
1174
1175         * breakpoint.c (create_breakpoint): Remove cleanup.
1176
1177 2019-01-23  Tom Tromey  <tom@tromey.com>
1178             Andrew Burgess  <andrew.burgess@embecosm.com>
1179             Pedro Alves  <palves@redhat.com>
1180
1181 2019-01-23  Pedro Alves  <palves@redhat.com>
1182
1183         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1184
1185 2019-01-23  Pedro Alves  <palves@redhat.com>
1186             Andrew Burgess  <andrew.burgess@embecosm.com>
1187
1188         * gdbthread.h: Include "common/forward-scope-exit.h".
1189         (scoped_finish_thread_state): Redefine custom class in terms of
1190         forward_scope_exit.
1191
1192 2019-01-23  Pedro Alves  <palves@redhat.com>
1193             Andrew Burgess  <andrew.burgess@embecosm.com>
1194
1195         * common/forward-scope-exit.h: New file.
1196
1197 2019-01-23  Pedro Alves  <palves@redhat.com>
1198             Andrew Burgess  <andrew.burgess@embecosm.com>
1199             Tom Tromey  <tom@tromey.com>
1200
1201         * common/scope-exit.h: New file.
1202
1203 2019-01-23  Pedro Alves  <palves@redhat.com>
1204
1205         * common/preprocessor.h (ESC): Rename to ...
1206         (ESC_PARENS): ... this.
1207         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1208         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1209
1210 2019-01-23  Tom Tromey  <tom@tromey.com>
1211
1212         * language.h (class scoped_switch_to_sym_language_if_auto):
1213         Initialize m_lang in both cases.
1214
1215 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1216
1217         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1218         with XCNEW.
1219
1220 2019-01-22  Tom Tromey  <tom@tromey.com>
1221
1222         * corelow.c: Do not include sys/file.h.
1223
1224 2019-01-22  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-wingeneral.h: Include gdb_curses.h.
1227
1228 2019-01-22  Tom Tromey  <tom@tromey.com>
1229
1230         * source-cache.h (class source_cache) <get_source_lines,
1231         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1232
1233 2019-01-22  Tom Tromey  <tom@tromey.com>
1234
1235         * remote-fileio.h (struct remote_target): Declare.
1236
1237 2019-01-22  Tom Tromey  <tom@tromey.com>
1238
1239         * python/py-arch.c: Do not include py-ref.h.
1240         * python/py-bpevent.c: Do not include py-ref.h.
1241         * python/py-cmd.c: Do not include py-ref.h.
1242         * python/py-continueevent.c: Do not include py-ref.h.
1243         * python/py-event.h: Do not include py-ref.h.
1244         * python/py-evtregistry.c: Do not include py-ref.h.
1245         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1246         * python/py-frame.c: Do not include py-ref.h.
1247         * python/py-framefilter.c: Do not include py-ref.h.
1248         * python/py-function.c: Do not include py-ref.h.
1249         * python/py-infevents.c: Do not include py-ref.h.
1250         * python/py-linetable.c: Do not include py-ref.h.
1251         * python/py-objfile.c: Do not include py-ref.h.
1252         * python/py-param.c: Do not include py-ref.h.
1253         * python/py-prettyprint.c: Do not include py-ref.h.
1254         * python/py-progspace.c: Do not include py-ref.h.
1255         * python/py-symbol.c: Do not include py-ref.h.
1256         * python/py-symtab.c: Do not include py-ref.h.
1257         * python/py-type.c: Do not include py-ref.h.
1258         * python/py-unwind.c: Do not include py-ref.h.
1259         * python/py-utils.c: Do not include py-ref.h.
1260         * python/py-value.c: Do not include py-ref.h.
1261         * python/py-varobj.c: Do not include py-ref.h.
1262         * python/py-xmethods.c: Do not include py-ref.h.
1263         * python/python.c: Do not include py-ref.h.
1264         * varobj.c: Do not include py-ref.h.
1265
1266 2019-01-22  Tom Tromey  <tom@tromey.com>
1267
1268         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1269         keyword for bcache.
1270
1271 2019-01-22  Tom Tromey  <tom@tromey.com>
1272
1273         * compile/compile-cplus-types.c: Remove a comment by #include.
1274
1275 2019-01-22  Tom Tromey  <tom@tromey.com>
1276
1277         * compile/gcc-c-plugin.h: Include compile-internal.h.
1278
1279 2019-01-22  Tom Tromey  <tom@tromey.com>
1280
1281         * stabsread.c (EXTERN): Do not define.
1282         (symnum, next_symbol_text_func, processing_gcc_compilation)
1283         (within_function, global_sym_chain, global_stabs)
1284         (previous_stab_code, this_object_header_files)
1285         (n_this_object_header_files)
1286         (n_allocated_this_object_header_files): Define.
1287         * stabsread.h (EXTERN): Never define.  Use "extern".
1288
1289 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1290
1291         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1292         history_value.
1293
1294 2019-01-21  Tom Tromey  <tom@tromey.com>
1295
1296         * ui-out.c: Fix includes.
1297         * tui/tui-source.c: Fix includes.
1298         * target.c: Fix includes.
1299         * remote.c: Fix includes.
1300         * regcache.c: Fix includes.
1301         * python/py-block.c: Fix includes.
1302         * printcmd.c: Fix includes.
1303         * or1k-tdep.c: Fix includes.
1304         * mi/mi-main.c: Fix includes.
1305         * m32r-tdep.c: Fix includes.
1306         * csky-tdep.c: Fix includes.
1307         * compile/compile-cplus-types.c: Fix includes.
1308         * cli/cli-interp.c: Fix includes.
1309
1310 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1311
1312         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1313         for padding.
1314
1315 2019-01-16  Tom Tromey  <tom@tromey.com>
1316
1317         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1318         earlier.
1319         (struct objfile) <msymbols_range>: Move from top level.
1320         <msymbols>: New method.
1321         (class objfile_msymbols): Remove.
1322         * symtab.c (default_collect_symbol_completion_matches_break_on):
1323         Update.
1324         * symmisc.c (dump_msymbols): Update.
1325         * stabsread.c (scan_file_globals): Update.
1326         * objc-lang.c (info_selectors_command, info_classes_command)
1327         (find_methods): Update.
1328         * minsyms.c (find_solib_trampoline_target): Update.
1329         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1330         * coffread.c (coff_symfile_read): Update.
1331         * ada-lang.c (ada_lookup_simple_minsym)
1332         (ada_collect_symbol_completion_matches): Update.
1333
1334 2019-01-16  Tom Tromey  <tom@tromey.com>
1335
1336         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1337         type.  Remove no-argument constructor.
1338         <iterator::operator++>: Simplify.
1339         <begin>: Update.
1340         <end>: Use minimal_symbol_count.
1341
1342 2019-01-16  Tom Tromey  <tom@tromey.com>
1343
1344         * objfiles.h (struct objfile) <psymtabs>: New method.
1345         (class objfile_psymtabs): Remove.
1346         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1347         typedef.
1348         <range>: New method.
1349         (require_partial_symbols): Change return type.
1350         * psymtab.c (require_partial_symbols)
1351         (psym_expand_symtabs_matching): Update.
1352         * mdebugread.c (parse_partial_symbols): Update.
1353         * dbxread.c (dbx_end_psymtab): Update.
1354
1355 2019-01-15  Tom Tromey  <tom@tromey.com>
1356
1357         * symtab.c (lookup_objfile_from_block)
1358         (lookup_symbol_in_objfile_symtabs)
1359         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1360         (find_line_symtab, info_sources_command)
1361         (default_collect_symbol_completion_matches_break_on)
1362         (make_source_files_completion_list): Update.
1363         * symmisc.c (print_objfile_statistics, dump_objfile)
1364         (maintenance_print_symbols, maintenance_info_symtabs)
1365         (maintenance_check_symtabs, maintenance_info_line_tables):
1366         Update.
1367         * source.c (select_source_symtab)
1368         (forget_cached_source_info_for_objfile): Update.
1369         * objfiles.h (class objfile_compunits): Remove.
1370         (struct objfile) <compunits_range>: New typedef.
1371         (compunits): New method.
1372         * objfiles.c (objfile_relocate1): Update.
1373         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1374         * maint.c (count_symtabs_and_blocks): Update.
1375         * linespec.c (iterate_over_all_matching_symtabs): Update.
1376         * cp-support.c (add_symbol_overload_list_qualified): Update.
1377         * coffread.c (coff_symtab_read): Update.
1378         * ada-lang.c (add_nonlocal_symbols)
1379         (ada_collect_symbol_completion_matches)
1380         (ada_add_global_exceptions): Update.
1381
1382 2019-01-15  Tom Tromey  <tom@tromey.com>
1383
1384         * progspace.h (program_space) <objfiles_safe_range>: New
1385         typedef.
1386         <objfiles_safe>: New method.
1387         * objfiles.h (class all_objfiles_safe): Remove.
1388         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1389         * jit.c (jit_inferior_exit_hook): Update.
1390
1391 2019-01-17  Tom Tromey  <tom@tromey.com>
1392
1393         * progspace.h (program_space) <objfiles_range>: New typedef.
1394         <objfiles>: New method.
1395         <objfiles_head>: Rename from objfiles.
1396         (object_files): Update.
1397         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1398         * guile/scm-pretty-print.c
1399         (ppscm_find_pretty_printer_from_objfiles): Update.
1400         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1401         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1402         Update.
1403         * python/py-progspace.c (pspy_get_objfiles): Update.
1404         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1405         Update.
1406         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1407         (objfpy_lookup_objfile_by_build_id): Update.
1408         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1409         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1410         Update.
1411         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1412         (expand_symtab_containing_pc, lookup_objfile_from_block)
1413         (lookup_static_symbol, basic_lookup_transparent_type)
1414         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1415         (find_line_symtab, info_sources_command)
1416         (default_collect_symbol_completion_matches_break_on)
1417         (make_source_files_completion_list, find_main_name): Update.
1418         * symmisc.c (print_symbol_bcache_statistics)
1419         (print_objfile_statistics, maintenance_print_symbols)
1420         (maintenance_print_msymbols, maintenance_print_objfiles)
1421         (maintenance_info_symtabs, maintenance_check_symtabs)
1422         (maintenance_expand_symtabs, maintenance_info_line_tables):
1423         Update.
1424         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1425         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1426         (map_overlay_command, unmap_overlay_command)
1427         (simple_overlay_update, expand_symtabs_matching)
1428         (map_symbol_filenames): Update.
1429         * symfile-debug.c (set_debug_symfile): Update.
1430         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1431         Update.
1432         * source.c (select_source_symtab, forget_cached_source_info):
1433         Update.
1434         * solib.c (solib_read_symbols): Update.
1435         * solib-spu.c (append_ocl_sos): Update.
1436         * psymtab.c (maintenance_print_psymbols)
1437         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1438         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1439         * printcmd.c (info_symbol_command): Update.
1440         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1441         Update.
1442         * objfiles.h (class all_objfiles): Remove.
1443         * objfiles.c (have_partial_symbols, have_full_symbols)
1444         (have_minimal_symbols, qsort_cmp, update_section_map)
1445         (shared_objfile_contains_address_p)
1446         (default_iterate_over_objfiles_in_search_order): Update.
1447         * objc-lang.c (info_selectors_command, info_classes_command)
1448         (find_methods): Update.
1449         * minsyms.c (find_solib_trampoline_target): Update.
1450         * maint.c (maintenance_info_sections)
1451         (maintenance_translate_address, count_symtabs_and_blocks):
1452         Update.
1453         * main.c (captured_main_1): Update.
1454         * linux-thread-db.c (try_thread_db_load_from_pdir)
1455         (has_libpthread): Update.
1456         * linespec.c (iterate_over_all_matching_symtabs)
1457         (search_minsyms_for_name): Update.
1458         * jit.c (jit_find_objf_with_entry_addr): Update.
1459         * hppa-tdep.c (find_unwind_entry)
1460         (hppa_lookup_stub_minimal_symbol): Update.
1461         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1462         Update.
1463         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1464         (elf_gnu_ifunc_resolve_by_got): Update.
1465         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1466         * dwarf-index-write.c (save_gdb_index_command): Update.
1467         * cp-support.c (add_symbol_overload_list_qualified): Update.
1468         * breakpoint.c (create_overlay_event_breakpoint)
1469         (create_longjmp_master_breakpoint)
1470         (create_std_terminate_master_breakpoint)
1471         (create_exception_master_breakpoint): Update.
1472         * blockframe.c (find_pc_partial_function): Update.
1473         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1474         (ada_collect_symbol_completion_matches)
1475         (ada_add_global_exceptions): Update.
1476
1477 2019-01-17  Tom Tromey  <tom@tromey.com>
1478
1479         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1480         declare VEC.
1481         (solib_target_parse_libraries): Change return type.
1482         (library_list_start_segment, library_list_start_section)
1483         (library_list_end_library, library_list_start_library); Update.
1484         (solib_target_free_library_list): Remove.
1485         (solib_target_parse_libraries): Remove cleanup.  Change return
1486         type.
1487         (solib_target_current_sos): Update.
1488
1489 2019-01-17  Tom Tromey  <tromey@bapiya>
1490
1491         * valprint.c: Replace "the the" with "the".
1492         * symtab.c: Replace "the the" with "the".
1493         * solib.c: Replace "the the" with "the".
1494         * solib-dsbt.c: Replace "the the" with "the".
1495         * linespec.c: Replace "the the" with "the".
1496         * dwarf2loc.h: Replace "the the" with "the".
1497         * amd64-windows-tdep.c: Replace "the the" with "the".
1498         * aarch64-tdep.c: Replace "the the" with "the".
1499
1500 2019-01-16  Keith Seitz  <keiths@redhat.com>
1501
1502         PR gdb/23773
1503         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1504         <builder>: Rename to ..
1505         <m_builder>: ... this and make private.
1506         (dwarf2_cu::get_builder): New method.  Change all users of
1507         `builder' to use this method.
1508         (dwarf2_start_symtab): Move to ...
1509         (dwarf2_cu::start_symtab): ... here.  Update all callers
1510         (setup_type_unit_groups): Move to ...
1511         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1512         callers.
1513         (dwarf2_cu::reset_builder): New method.
1514         (process_full_compunit, process_full_type_unit): Use
1515         dwarf2_cu::reset_builder.
1516         (follow_die_offset): Record the ancestor CU if it is different
1517         from the followed DIE's CU.
1518         (follow_die_sig_1): Likewise.
1519
1520 2019-01-15  Tom Tromey  <tom@tromey.com>
1521
1522         * remote.c (class remote_state) <buf>: Now a char_vector.
1523         <buf_size>: Remove.
1524         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1525         parameter.
1526         (remote_target::getpkt_or_notif_sane_1)
1527         (remote_target::getpkt_sane)
1528         (remote_target::getpkt_or_notif_sane): Likewise.
1529         (class remote_target) <putpkt>: New overload.
1530         (remote_target::read_frame): Change type of "buf_p".  Remove
1531         sizeof_p parameter.
1532         (packet_ok): New overload.
1533         (packet_check_result): New overload.
1534         Update all uses.
1535
1536 2019-01-14  Tom Tromey  <tom@tromey.com>
1537
1538         * remote-notif.c (handle_notification, remote_notif_ack)
1539         (remote_notif_parse): Make "buf" const.
1540         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1541         const.
1542         (remote_notif_parse, remote_notif_ack, handle_notification):
1543         Likewise.
1544         * remote.c (remote_notif_stop_parse): Make "buf" const.
1545         (remote_target::remote_parse_stop_reply): Make "buf" const.
1546         (remote_notif_stop_ack): Make "buf" const.
1547
1548 2019-01-14  Tom Tromey  <tom@tromey.com>
1549
1550         * remote.c (remote_console_output): Make parameter const.
1551
1552 2019-01-14  Tom Tromey  <tom@tromey.com>
1553
1554         * target-debug.h (target_debug_print_signals): Constify.
1555         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1556         * procfs.c (procfs_target::pass_signals): Update.
1557         * linux-nat.c (linux_nat_target::pass_signals): Update.
1558         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1559         * target-delegates.c: Rebuild.
1560         * remote.c (remote_target::program_signals): Update.
1561         (remote_target::pass_signals): Update.
1562         * target.c (target_pass_signals): Constify argument.
1563         (target_program_signals): Likewise.
1564         * target.h (struct target_ops) <pass_signals, program_signals>:
1565         Constify argument.
1566         (target_pass_signals, target_program_signals): Constify argument.
1567
1568 2019-01-14  Tom Tromey  <tom@tromey.com>
1569
1570         PR tui/28819:
1571         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1572
1573 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1574
1575         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1576         field.
1577         * rs6000-tdep.c: Include reggroups.h.
1578         (IS_V_ALIAS_PSEUDOREG): Define.
1579         (rs6000_register_name): Return names for the "vX" aliases.
1580         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1581         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1582         aliases.  Call default_register_reggroup_p for all other
1583         pseudo-registers.
1584         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1585         New functions.
1586         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1587         Handle "vX" aliases.
1588         (v_alias_pseudo_register_collect): New function.
1589         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1590         (rs6000_gdbarch_init): Initialize "vX" aliases as
1591         pseudo-registers.  Restore registration of
1592         rs6000_pseudo_register_reggroup_p with
1593         set_tdesc_pseudo_register_reggroup_p.
1594
1595 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1596
1597         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1598         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1599         set_gdbarch_num_pseudo_regs.
1600
1601 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1602
1603         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1604         Remove arg prefixname, add do_set and do_show.
1605         Add member functions set_list and show_list.
1606         * cli/cli-style.c (class cli_style_option): Update accordingly.
1607         (style_set_list): Move to file scope.
1608         (style_show_list): Likewise.
1609         (set_style): Call help_list.
1610         (show_style): Call cmd_show_list.
1611         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1612         Update to use the new macro.
1613
1614 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1615
1616         * ada-lang.c (_initialize_ada_language): Expand the help text
1617         for the "catch exception" command.
1618
1619 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1620
1621         * symtab.c (matching_obj_sections): Initialize obj,
1622         declare it closer to its usage.
1623
1624 2019-01-10  Tom Tromey  <tom@tromey.com>
1625
1626         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1627         (basic_inf_threads_range): Remove.
1628         (inf_threads_range, inf_non_exited_threads_range)
1629         (safe_inf_threads_range): Use next_adapter.
1630
1631 2019-01-10  Keith Seitz  <keiths@redhat.com>
1632
1633         PR gdb/23712
1634         PR symtab/23010
1635         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1636         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1637
1638 2019-01-10  Keith Seitz  <keiths@redhat.com>
1639
1640         PR gdb/23712
1641         PR symtab/23010
1642         * dictionary.c (pending_to_vector): Remove.
1643         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1644         Remove _1 suffix, replacing functions of the same name.  Update
1645         all callers.
1646         (dict_create_hashed, dict_create_hashed_expandable)
1647         (dict_create_linear, dict_create_linear_expandable, dict_free)
1648         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1649         Make functions static.
1650
1651 2019-01-10  Keith Seitz  <keiths@redhat.com>
1652
1653         PR gdb/23712
1654         PR symtab/23010
1655         * dictionary.h (struct dictionary): Replace declaration with
1656         multidictionary.
1657         (dict_create_hashed, dict_create_hashed_expandable)
1658         (dict_create_linear, dict_create_linear_expandable)
1659         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1660         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1661         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1662         taking multidictionary argument.
1663         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1664         * block.h (struct block) <dict>: Change to multidictionary
1665         and rename `multidict'.
1666         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1667         symmisc.c: Update all dictionary references to multidictionary.
1668
1669 2019-01-10  Keith Seitz  <keiths@redhat.com>
1670
1671         PR gdb/23712
1672         PR symtab/23010
1673         * dictionary.c: Include unordered_map.
1674         (pending_to_vector): New function.
1675         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1676         Rewrite the non-"_1" functions to take vector instead
1677         of linked list.
1678         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1679         "new" _1 versions of the same name.
1680         (multidictionary): Define.
1681         (std::hash<enum language): New definition.
1682         (collate_pending_symbols_by_language, mdict_create_hashed)
1683         (mdict_create_hashed_expandable, mdict_create_linear)
1684         (mdict_create_linear_expandable, mdict_free)
1685         (find_language_dictionary, create_new_language_dictionary)
1686         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1687         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1688         (mdict_size, mdict_empty): New functions.
1689         * dictionary.h (mdict_iterator): Define.
1690
1691 2019-01-10  Pedro Alves  <palves@redhat.com>
1692
1693         * breakpoint.c (read_uploaded_action)
1694         (create_tracepoint_from_upload): Adjust to use
1695         gdb::unique_xmalloc_ptr.
1696         * ctf.c (ctf_write_uploaded_tp):
1697         (SET_ARRAY_FIELD): Use emplace_back.
1698         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1699         * tracefile-tfile.c (tfile_write_uploaded_tp):
1700         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1701         gdb::unique_xmalloc_ptr.
1702         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1703         at_string, cond_string, cmd_strings>: Replace char pointers
1704         with gdb::unique_xmalloc_ptr.
1705
1706 2019-01-10  Pedro Alves  <palves@redhat.com>
1707
1708         * solib-target.c (library_list_start_library): Don't xstrdup name.
1709
1710 2019-01-10  Pedro Alves  <palves@redhat.com>
1711
1712         * mdebugread.c (parse_partial_symbols): Use
1713         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1714
1715 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1716
1717         * linux-fork.c (scoped_switch_fork_info)
1718         <~scoped_switch_fork_info>: Fix incorrect variable name.
1719
1720 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1721
1722         * linux-fork.c (scoped_switch_fork_info)
1723         <scoped_switch_fork_info>: Make explicit.
1724         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1725
1726 2019-01-10  Tom Tromey  <tom@tromey.com>
1727
1728         * objfiles.h (objfile::reset_psymtabs): Update.
1729         * objfiles.c (objfile::objfile): Update.
1730         * psymtab.h (psymtab_storage::obstack): Update.
1731         (psymtab_storage::m_obstack): Use gdb::optional.
1732         (class psymtab_storage): Update comment.  Remove objfile
1733         parameter.
1734         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1735
1736 2019-01-10  Tom Tromey  <tom@tromey.com>
1737
1738         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1739         <free_psymtabs>: Now private.
1740         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1741         (allocate_psymtab): Use new method.
1742
1743 2019-01-10  Tom Tromey  <tom@tromey.com>
1744
1745         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1746         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1747         * mdebugread.c (parse_partial_symbols): Use
1748         allocate_dependencies.
1749         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1750         allocate_dependencies.
1751         (process_psymtab_comp_unit_reader)
1752         (build_type_psymtab_dependencies): Likewise.
1753         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1754
1755 2019-01-10  Tom Tromey  <tom@tromey.com>
1756
1757         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1758         PSYMBOL_SET_LANGUAGE.
1759         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1760
1761 2019-01-10  Tom Tromey  <tom@tromey.com>
1762
1763         * psymtab.h (psymtab_storage::obstack): New method.
1764         <m_obstack>: Rename from obstack; now private.
1765         * psymtab.c (psymtab_storage): Update.
1766         * dwarf2read.c (create_addrmap_from_index)
1767         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1768         Update.
1769
1770 2019-01-10  Tom Tromey  <tom@tromey.com>
1771
1772         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1773         * objfiles.h (objfile::reset_psymtabs): New method.
1774
1775 2019-01-10  Tom Tromey  <tom@tromey.com>
1776
1777         * symmisc.c (print_symbol_bcache_statistics): Update.
1778         (print_objfile_statistics): Update.
1779         * symfile.c (reread_symbols): Update.
1780         * psymtab.h (class psymtab_storage): New.
1781         * psymtab.c (psymtab_storage): New constructor.
1782         (~psymtab_storage): New destructor.
1783         (require_partial_symbols): Update.
1784         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1785         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1786         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1787         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1788         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1789         (start_psymtab_common, end_psymtab_common)
1790         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1791         (allocate_psymtab): Update.
1792         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1793         Update.
1794         (dump_psymtab_addrmap, maintenance_print_psymbols)
1795         (maintenance_check_psymtabs): Update.
1796         (class objfile_psymtabs): Move to objfiles.h.
1797         * psympriv.h (discard_psymtab): Now inline.
1798         (psymtab_discarder::psymtab_discarder): Update.
1799         (psymtab_discarder::~psymtab_discarder): Update.
1800         (ALL_OBJFILE_PSYMTABS): Rewrite.
1801         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1802         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1803         Remove fields.
1804         <partial_symtabs>: New field.
1805         (class objfile_psymtabs): Move from psymtab.h.  Update.
1806         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1807         psymbol_cache.
1808         (objfile::~objfile): Don't destroy psymbol_cache.
1809         * mdebugread.c (parse_partial_symbols): Update.
1810         * dwarf2read.c (create_addrmap_from_index)
1811         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1812         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1813         (add_partial_subprogram, dwarf2_ranges_read): Update.
1814         * dwarf-index-write.c (write_address_map)
1815         (write_one_signatured_type, recursively_write_psymbols)
1816         (class debug_names, class debug_names, write_psymtabs_to_index):
1817         Update.
1818
1819 2019-01-10  Tom Tromey  <tom@tromey.com>
1820
1821         * symtab.h (SYMBOL_SET_NAMES): Update.
1822         (symbol_set_names): Update.
1823         (MSYMBOL_SET_NAMES): Update.
1824         * symtab.c (symbol_set_names): Change argument to be an
1825         objfile_per_bfd_storage.
1826         * psymtab.c (add_psymbol_to_bcache): Update.
1827         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1828
1829 2019-01-10  Tom Tromey  <tom@tromey.com>
1830
1831         * symtab.c (create_demangled_names_hash): Change argument to be an
1832         objfile_per_bfd_storage.
1833         (symbol_set_names): Update.
1834
1835 2019-01-10  Tom Tromey  <tom@tromey.com>
1836
1837         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1838         init_psymbol_list.
1839         * psymtab.c (init_psymbol_list): Do nothing if already called.
1840         * psympriv.h (init_psymbol_list): Add comment.
1841         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1842         init_psymbol_list.
1843         * dbxread.c (dbx_symfile_read): Unconditionally call
1844         init_psymbol_list.
1845
1846 2019-01-10  Tom Tromey  <tom@tromey.com>
1847
1848         * xcoffread.c (scan_xcoff_symtab): Update.
1849         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1850         "where".
1851         * mdebugread.c (parse_partial_symbols)
1852         (handle_psymbol_enumerators): Update.
1853         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1854         * dbxread.c (read_dbx_symtab): Update.
1855         * psympriv.h (psymbol_placement): New enum.
1856         (add_psymbol_to_list): Update.
1857
1858 2019-01-10  Tom Tromey  <tom@tromey.com>
1859
1860         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1861         static_psymbols parameters.
1862         (scan_xcoff_symtab): Update.
1863         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1864         static_psymbols parameters.
1865         * psympriv.h (start_psymtab_common): Update.
1866         * mdebugread.c (parse_partial_symbols): Update.
1867         * dwarf2read.c (create_partial_symtab): Update.
1868         * dbxread.c (read_dbx_symtab): Update.
1869         (start_psymtab): Remove global_psymbols and static_psymbols
1870         parameters.
1871
1872 2019-01-10  Tom Tromey  <tom@tromey.com>
1873
1874         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1875         * psymtab.c (allocate_psymtab): Add comment.
1876         * psympriv.h (allocate_psymtab): Add comment.
1877         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1878         initializations.
1879         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1880
1881 2019-01-10  Tom Tromey  <tom@tromey.com>
1882
1883         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1884         Don't declare.
1885         * mipsread.c: Include mdebugread.h.
1886         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1887         Declare.
1888         * elfread.c: Include mdebugread.h.
1889
1890 2019-01-09  Tom Tromey  <tom@tromey.com>
1891
1892         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1893         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1894         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1895         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1896         (psym_lookup_symbol, psym_find_last_source_symtab)
1897         (psym_forget_cached_source_info, psym_print_stats)
1898         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1899         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1900         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1901         (psym_find_compunit_symtab_by_address)
1902         (maintenance_print_psymbols, maintenance_info_psymtabs)
1903         (maintenance_check_psymtabs): Use ranged for.
1904         * psymtab.h (class objfile_psymtabs): New.
1905         (require_partial_symbols): Return objfile_psymtabs.
1906         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1907
1908 2019-01-09  Tom Tromey  <tom@tromey.com>
1909
1910         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1911         (find_pc_mapped_section, list_overlays_command)
1912         (map_overlay_command, unmap_overlay_command)
1913         (simple_overlay_update): Use all_objfiles.
1914         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1915         * printcmd.c (info_symbol_command): Use all_objfiles.
1916         * objfiles.h (ALL_OBJSECTIONS): Remove.
1917         * maint.c (maintenance_translate_address): Use all_objfiles.
1918         * gcore.c (gcore_create_callback): Use all_objfiles.
1919         (objfile_find_memory_regions): Likewise.
1920
1921 2019-01-09  Tom Tromey  <tom@tromey.com>
1922
1923         * symtab.c (find_line_symtab, info_sources_command)
1924         (make_source_files_completion_list): Use objfile_compunits.
1925         * source.c (select_source_symtab): Use objfile_compunits.
1926         * objfiles.h (struct objfile): Update comment.
1927         (ALL_OBJFILES): Remove.
1928         (ALL_FILETABS): Remove.
1929         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1930         objfile_compunits.
1931
1932 2019-01-09  Tom Tromey  <tom@tromey.com>
1933
1934         * symmisc.c (print_objfile_statistics, dump_objfile)
1935         (maintenance_print_symbols): Use compunit_filetabs.
1936         * source.c (forget_cached_source_info_for_objfile): Use
1937         compunit_filetabs.
1938         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1939         (ALL_FILETABS): Use compunit_filetabs.
1940         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1941         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1942
1943 2019-01-09  Tom Tromey  <tom@tromey.com>
1944
1945         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1946         (compunit_filetabs): New.
1947         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1948         compunit_filetabs.
1949         (info_sources_command, make_source_files_completion_list): Remove
1950         declaration.
1951         * symmisc.c (print_objfile_statistics, dump_objfile)
1952         (maintenance_print_symbols): Remove declaration.
1953         (maintenance_info_symtabs): Use compunit_filetabs.
1954         (maintenance_info_line_tables): Likewise.
1955         * source.c (select_source_symtab): Change local variable name.
1956         (forget_cached_source_info_for_objfile): Remove declaration.
1957         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1958         * objfiles.c (objfile_relocate1): Remove declaration.
1959         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1960         declaration.
1961         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1962         * coffread.c (coff_symtab_read): Remove declaration.
1963         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1964         compunit_filetabs.
1965
1966 2019-01-09  Tom Tromey  <tom@tromey.com>
1967
1968         * symtab.c (lookup_objfile_from_block)
1969         (find_pc_sect_compunit_symtab, search_symbols)
1970         (default_collect_symbol_completion_matches_break_on): Use
1971         objfile_compunits.
1972         * objfiles.h (ALL_COMPUNITS): Remove.
1973         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1974         * cp-support.c (add_symbol_overload_list_qualified): Use
1975         objfile_compunits.
1976         * ada-lang.c (ada_collect_symbol_completion_matches)
1977         (ada_add_global_exceptions): Use objfile_compunits.
1978
1979 2019-01-09  Tom Tromey  <tom@tromey.com>
1980
1981         * source.c (select_source_symtab)
1982         (forget_cached_source_info_for_objfile): Remove declaration.
1983         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1984         declaration.
1985         * maint.c (count_symtabs_and_blocks): Remove declaration.
1986         * cp-support.c (add_symbol_overload_list_qualified): Remove
1987         declaration.
1988         * coffread.c (coff_symtab_read): Remove declaration.
1989         * symtab.c (lookup_symbol_in_objfile_symtabs)
1990         (basic_lookup_transparent_type_1): Use objfile_compunits.
1991         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1992         (info_sources_command, search_symbols)
1993         (default_collect_symbol_completion_matches_break_on)
1994         (make_source_files_completion_list): Remove declaration.
1995         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1996         (ada_collect_symbol_completion_matches)
1997         (ada_add_global_exceptions): Remove declaration.
1998         * linespec.c (iterate_over_all_matching_symtabs): Use
1999         objfile_compunits.
2000         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2001         (class objfile_compunits): New.
2002         (ALL_COMPUNITS): Use objfile_compunits.
2003         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2004         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2005         objfile_compunits.
2006         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2007
2008 2019-01-09  Tom Tromey  <tom@tromey.com>
2009
2010         * symtab.c (search_symbols)
2011         (default_collect_symbol_completion_matches_break_on): Use
2012         objfile_msymbols.
2013         * ada-lang.c (ada_lookup_simple_minsym)
2014         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2015         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2016         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2017         objfile_msymbols.
2018         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2019         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2020         * objc-lang.c (find_methods): Use objfile_msymbols.
2021         (info_selectors_command, info_classes_command): Likewise.
2022         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2023         * objfiles.h (class objfile_msymbols): New.
2024         (ALL_OBJFILE_MSYMBOLS): Remove.
2025         (ALL_MSYMBOLS): Remove.
2026
2027 2019-01-09  Tom Tromey  <tom@tromey.com>
2028
2029         * common/next-iterator.h (next_adapter): Add Iterator template
2030         parameter.
2031         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2032         (class all_objfiles_safe): New.
2033         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2034         * objfiles.c (put_objfile_before): Update comment.
2035         (add_separate_debug_objfile): Likewise.
2036         (free_all_objfiles): Use all_objfiles_safe.
2037         (objfile_purge_solibs): Likewise.
2038
2039 2019-01-09  Tom Tromey  <tom@tromey.com>
2040
2041         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2042         (expand_symtab_containing_pc, lookup_static_symbol)
2043         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2044         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2045         all_objfiles.
2046         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2047         * breakpoint.c (create_overlay_event_breakpoint)
2048         (create_longjmp_master_breakpoint)
2049         (create_std_terminate_master_breakpoint)
2050         (create_exception_master_breakpoint): Use all_objfiles.
2051         * linux-thread-db.c (try_thread_db_load_from_pdir)
2052         (has_libpthread): Use all_objfiles.
2053         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2054         * linespec.c (iterate_over_all_matching_symtabs)
2055         (search_minsyms_for_name): Use all_objfiles.
2056         * maint.c (maintenance_info_sections): Use all_objfiles.
2057         * main.c (captured_main_1): Use all_objfiles.
2058         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2059         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2060         * guile/scm-pretty-print.c
2061         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2062         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2063         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2064         (maintenance_print_msymbols): Use all_objfiles.
2065         * source.c (select_source_symtab): Use all_objfiles.
2066         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2067         * symfile.c (remove_symbol_file_command)
2068         (expand_symtabs_matching, map_symbol_filenames): Use
2069         all_objfiles.
2070         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2071         all_objfiles.
2072         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2073         * objc-lang.c (find_methods): Use all_objfiles.
2074         * objfiles.c (have_partial_symbols, have_full_symbols)
2075         (have_minimal_symbols, qsort_cmp)
2076         (default_iterate_over_objfiles_in_search_order): Use
2077         all_objfiles.
2078         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2079         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2080         (maintenance_check_psymtabs): Use all_objfiles.
2081         (ALL_PSYMTABS): Remove.
2082         * compile/compile-object-run.c (do_module_cleanup): Use
2083         all_objfiles.
2084         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2085         * cp-support.c (add_symbol_overload_list_qualified): Use
2086         all_objfiles.
2087         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2088         Use all_objfiles.
2089         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2090         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2091         all_objfiles.
2092         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2093         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2094         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2095         Uses all_objfiles.
2096         * solib.c (solib_read_symbols): Use all_objfiles
2097
2098 2019-01-09  Tom Tromey  <tom@tromey.com>
2099
2100         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2101         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2102         all_objfiles.
2103         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2104         * symmisc.c (print_symbol_bcache_statistics)
2105         (print_objfile_statistics, maintenance_print_objfiles)
2106         (maintenance_info_symtabs, maintenance_check_symtabs)
2107         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2108         all_objfiles.
2109         * source.c (forget_cached_source_info): Use all_objfiles.
2110         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2111         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2112         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2113         * objfiles.c (update_section_map): Use all_objfiles.
2114         (shared_objfile_contains_address_p): Likewise.
2115         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2116         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2117
2118 2019-01-09  Tom Tromey  <tom@tromey.com>
2119
2120         * common/next-iterator.h: New file.
2121         * objfiles.h (class all_objfiles): New.
2122         (struct objfile_iterator): New.
2123
2124 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2125
2126         * NEWS: Move the description of the changed "frame", "select-frame",
2127          and "info frame" commands to the Changed commands section.
2128
2129 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2130
2131         * gdbtypes.c (check_stub_method_group): Remove handling of old
2132         mangling schemes.
2133         * linespec.c (find_methods): Likewise.
2134         * stabsread.c (read_member_functions): Likewise.
2135         * valops.c (search_struct_method): Likewise.
2136         (value_struct_elt_for_reference): Likewise.
2137         * NEWS: Mention this change.
2138
2139 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2140
2141         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2142         print_source_lines.
2143         * source.c (print_source_lines_base): Update line number check.
2144         (print_source_lines): New function.
2145         (source_lines_range::source_lines_range): New function.
2146         * source.h (class source_lines_range): New class.
2147         (print_source_lines): New declaration.
2148
2149 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2150
2151         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2152
2153 2019-01-08  Tom Tromey  <tom@tromey.com>
2154             Simon Marchi  <simon.marchi@ericsson.com>
2155
2156         PR gdb/24060
2157         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2158         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2159         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2160         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2161         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2162         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2163
2164 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2165
2166         * source.c (select_source_symtab): Move header comment to
2167         declaration in source.h.
2168         (forget_cached_source_info_for_objfile): Likewise.
2169         (forget_cached_source_info): Likewise.
2170         (identify_source_line): Likewise.
2171         * source.h (identify_source_line): Move declaration from symtab.h
2172         and add comment from source.c
2173         (print_source_lines): Likewise.
2174         (forget_cached_source_info_for_objfile): Likewise.
2175         (forget_cached_source_info): Likewise.
2176         (select_source_symtab): Likewise.
2177         (enum print_source_lines_flag): Move definition from symtab.h.
2178         * symtab.h (identify_source_line): Move declaration to source.h.
2179         (print_source_lines): Likewise.
2180         (forget_cached_source_info_for_objfile): Likewise.
2181         (forget_cached_source_info): Likewise.
2182         (select_source_symtab): Likewise.
2183         (enum print_source_lines_flag): Move definition to source.h.
2184         * tui/tui-hooks.c: Add 'source.h' include.
2185
2186 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2187
2188         * source.c (print_source_lines_base): Handle requests to print
2189         reverse line number sequences, and guard against empty lines
2190         string.
2191
2192 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2193
2194         * source.c (print_source_lines_base): Fix skip of '\r' if next
2195         character is '\n'.
2196
2197 2019-01-06  Tom Tromey  <tom@tromey.com>
2198
2199         * c-exp.y (struct c_parse_state) <macro_original_text,
2200         expansion_obstack>: New member.
2201         (macro_original_text, expansion_obstack): Remove globals.
2202         (scan_macro_expansion, scanning_macro_expansion)
2203         (finished_macro_expansion): Update.
2204         (scan_macro_cleanup): Remove.
2205         (yylex, c_parse): Update.
2206
2207 2019-01-06  Tom Tromey  <tom@tromey.com>
2208
2209         * c-exp.y (struct c_parse_state) <strings>: New member.
2210         (operator_stoken): Update.
2211
2212 2019-01-06  Tom Tromey  <tom@tromey.com>
2213
2214         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2215         (union type_stack_elt) <typelist_val>: Now a pointer to
2216         std::vector.
2217         (type_stack_cleanup): Don't declare.
2218         (push_typelist): Update.
2219         * parse.c (pop_typelist): Return a std::vector.
2220         (push_typelist): Take a std::vector.
2221         (follow_types): Update.  Do not free args.
2222         (type_stack_cleanup): Remove.
2223         * c-exp.y (struct c_parse_state): New.
2224         (cpstate): New global.
2225         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2226         (nonempty_typelist): Update.
2227         (func_mod): Create a new vector.
2228         (c_parse): Create a c_parse_state.
2229         (check_parameter_typelist): Do not delete params.
2230         (function_method): Update.  Do not delete type_list.
2231
2232 2019-01-06  Tom Tromey  <tom@tromey.com>
2233
2234         PR gdb/28155:
2235         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2236         check_typedef.
2237         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2238         (print_return_value): Likewise.
2239
2240 2019-01-05  Tom Tromey  <tom@tromey.com>
2241
2242         * contrib/cleanup_check.py: Remove.
2243         * contrib/gcc-with-excheck: Remove.
2244         * contrib/exsummary.py: Remove.
2245         * contrib/excheck.py: Remove.
2246
2247 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2248
2249         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2250         NULL. Initialize tpprev to NULL instead of assigning it
2251         to NULL on the next statement.
2252         * windows-nat.c (windows_delete_thread): Remove check for
2253         main_thread_id before printing thread exit notifications.
2254         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2255         Remove thread ID check against main_thread_id.
2256         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2257         windows_delete_thread.
2258         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2259
2260 2019-01-04  Tom Tromey  <tom@tromey.com>
2261
2262         * compile/compile.c (_initialize_compile): Use upper case for
2263         metasyntactic variables.
2264         * symmisc.c (_initialize_symmisc): Use upper case for
2265         metasyntactic variables.
2266         * psymtab.c (_initialize_psymtab): Use upper case for
2267         metasyntactic variables.
2268         * demangle.c (demangle_command): Use upper case for metasyntactic
2269         variables.
2270         (_initialize_demangler): Likewise.
2271         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2272         variables.
2273
2274 2019-01-03  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2277
2278 2019-01-03  Tom Tromey  <tom@tromey.com>
2279
2280         * python/py-symtab.c (salpy_str): Update.
2281         (struct salpy_sal_object) <symtab>: Now a PyObject.
2282         (salpy_dealloc): Update.
2283         (del_objfile_sal): Use gdbpy_ref.
2284
2285 2019-01-03  Tom Tromey  <tom@tromey.com>
2286
2287         * python/py-type.c (convert_field): Use new_reference.  Return
2288         gdbpy_ref.
2289         (make_fielditem): Return gdbpy_ref.
2290         (typy_fields): Update.
2291         (typy_getitem): Update.
2292         (field_name): Return gdbpy_ref.  Use new_reference.
2293         (typy_iterator_iternext): Update.
2294
2295 2019-01-03  Tom Tromey  <tom@tromey.com>
2296
2297         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2298
2299 2019-01-03  Tom Tromey  <tom@tromey.com>
2300
2301         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2302         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2303         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2304         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2305         (pspy_set_type_printers): Likewise.
2306         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2307         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2308         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2309         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2310         (objfpy_set_type_printers): Likewise.
2311
2312 2019-01-03  Tom Tromey  <tom@tromey.com>
2313
2314         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2315         (gdbpy_print_stack): Use gdbpy_err_fetch.
2316         * python/python-internal.h (class gdbpy_err_fetch): New class.
2317         (class gdbpy_enter) <m_error_type, m_error_value,
2318         m_error_traceback>: Remove.
2319         <m_error>: New member.
2320         (gdbpy_exception_to_string): Don't declare.
2321         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2322         * python/py-value.c (convert_value_from_python): Use
2323         gdbpy_err_fetch.
2324         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2325         gdbpy_exception_to_string.
2326         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2327         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2328         gdbpy_err_fetch.
2329
2330 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2331
2332         * linux-nat.c (delete_lwp_cleanup): Delete.
2333         (struct lwp_deleter): New struct.
2334         (lwp_info_up): New typedef.
2335         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2336         lwp_info_up.
2337
2338 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2339
2340         * linux-fork.c (class scoped_switch_fork_info): New class.
2341         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2342
2343 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2344
2345         * valops.c (find_overload_match): Remove use of null_cleanup, and
2346         calls to do_cleanups.
2347
2348 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2349
2350         * compile/compile-cplus-types.c
2351         (compile_cplus_instance::decl_name): Handle changes to
2352         cp_func_name.
2353         * cp-support.c (cp_func_name): Update header comment, update
2354         return type.
2355         * cp-support.h (cp_func_name): Update return type in declaration.
2356         * valops.c (find_overload_match): Move temp_func local to top
2357         level of function and change its type.  Use temp_func to hold and
2358         delete temporary string obtained from cp_func_name.
2359
2360 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2361
2362         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2363         gdb::char_vector, remove cleanup, and update uses of `msg`.
2364
2365 2019-01-03  Jim Wilson  <jimw@sifive.com>
2366
2367         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2368
2369 2019-01-02  Tom Tromey  <tom@tromey.com>
2370
2371         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2372         (tdesc_parse_xml): Remove cleanups.
2373         * target-descriptions.h (make_cleanup_free_target_description):
2374         Don't declare.
2375         (target_desc_deleter): New struct.
2376         (target_desc_up): New typedef.
2377         * target-descriptions.c (target_desc_deleter::operator()): Rename
2378         from free_target_description.
2379         (make_cleanup_free_target_description): Remove.
2380
2381 2019-01-02  Tom Tromey  <tom@tromey.com>
2382
2383         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2384         constructor, destructor.
2385         (linespec_parser): Remove typedef.
2386         (~linespec_parser): Rename from linespec_parser_delete.
2387         (linespec_lex_to_end, linespec_complete_label)
2388         (linespec_complete): Update.
2389         (decode_line_full): Remove cleanups.
2390         (decode_line_1): Update.
2391
2392 2019-01-02  Tom Tromey  <tom@tromey.com>
2393
2394         * python/python-internal.h (inferior_to_inferior_object): Change
2395         return type.
2396         * python/py-exitedevent.c (create_exited_event_object): Update.
2397         * python/py-inferior.c (inferior_to_inferior_object): Return
2398         gdbpy_ref.
2399         (python_new_inferior, python_inferior_deleted)
2400         (thread_to_thread_object, delete_thread_object)
2401         (build_inferior_list, gdbpy_selected_inferior): Update.
2402         * python/py-infthread.c (create_thread_object): Update.  Also fail
2403         if inferior_to_inferior_object fails.
2404
2405 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2406
2407         * inferior.h (class inferior) <displaced_step_state>: New field.
2408         * infrun.h (struct displaced_step_state): Move here from
2409         infrun.c.  Initialize fields, add constructor.
2410         <inf>: Remove field.
2411         <reset>: New method.
2412         * infrun.c (struct displaced_step_inferior_state): Move to
2413         infrun.h.
2414         (displaced_step_inferior_states): Remove.
2415         (get_displaced_stepping_state): Adust.
2416         (displaced_step_in_progress_any_inferior): Adjust.
2417         (displaced_step_in_progress_thread): Adjust.
2418         (displaced_step_in_progress): Adjust.
2419         (add_displaced_stepping_state): Remove.
2420         (get_displaced_step_closure_by_addr): Adjust.
2421         (remove_displaced_stepping_state): Remove.
2422         (infrun_inferior_exit): Call displaced_step_state.reset.
2423         (use_displaced_stepping): Don't check for NULL.
2424         (displaced_step_prepare_throw): Call
2425         get_displaced_stepping_state.
2426         (displaced_step_fixup): Don't check for NULL.
2427         (prepare_for_detach): Don't check for NULL.
2428
2429 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2430
2431         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2432          in case of call that did not complete.
2433
2434 2019-01-02  Andrey Utkin  <autkin@undo.io>
2435
2436         * symfile.c (find_separate_debug_file): Fix search of debug files for
2437         remote debuggee.
2438
2439 2019-01-02  Tom Tromey  <tom@tromey.com>
2440
2441         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2442         indentation.
2443         * python/py-frame.c (frapy_older): Remove cast.
2444         (frapy_newer): Likewise.
2445         * python/py-breakpoint.c (local_setattro): Remove cast.
2446         * python/py-arch.c (archpy_name): Remove local variable.
2447         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2448
2449 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2450
2451         * unittests/basic_string_view/element_access/char/empty.cc:
2452         Fix year range in copyright header.
2453
2454 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2455
2456         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2457         Delete.
2458         <operator==>: Update with for removed field.
2459         <hash>: Likewise.
2460         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2461         <isa_features>: ...this.
2462         <abi_features>: New field.
2463         (riscv_isa_flen): Update comment.
2464         (riscv_abi_xlen): New declaration.
2465         (riscv_abi_flen): New declaration.
2466         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2467         isa_features.
2468         (riscv_abi_xlen): New function.
2469         (riscv_isa_flen): Update to get answer from isa_features.
2470         (riscv_abi_flen): New function.
2471         (riscv_has_fp_abi): Update to get answer from abi_features.
2472         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2473         xlen and flen.
2474         (riscv_call_info) <xlen, flen>: Update comment.
2475         (riscv_call_arg_struct): Remove invalid assertions
2476         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2477         is removed.
2478         (riscv_gdbarch_init): Gather isa features and abi features
2479         separately, ensure both match on the gdbarch when reusing an old
2480         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2481         a target with 64-bit float hardware.
2482
2483 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2484
2485         * source.c (search_command_helper): Stop reverse search
2486         when line 1 has been searched.
2487
2488 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2489
2490         * record-full.c (record_full_base_target::close): Rewrite
2491         record_full_core_buf_list free logic.
2492
2493 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2494
2495         * break-catch-syscall.c (print_one_catch_syscall): xfree
2496         the last text.
2497
2498 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2499
2500         * top.c (print_gdb_version): Update Copyright year in version
2501         message.
2502
2503 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2504
2505         Update copyright year range in all GDB files.
2506
2507 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2508
2509         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2510
2511 For older changes see ChangeLog-2018.
2512 \f
2513 Local Variables:
2514 mode: change-log
2515 left-margin: 8
2516 fill-column: 74
2517 version-control: never
2518 coding: utf-8
2519 End:
2520