gdb/ChangeLog

   1 2019-04-19  Tom Tromey  <tom@tromey.com>
   2
   3         * symfile.c (reread_symbols): Update.
   4         * objfiles.c (objfile_register_static_link)
   5         (objfile_lookup_static_link): Update
   6         (~objfile) Don't delete static_links.
   7         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
   8
   9 2019-04-19  Tom Tromey  <tom@tromey.com>
  10
  11         * type-stack.h (struct type_stack) <insert>: Constify string.
  12         * type-stack.c (type_stack::insert): Constify string.
  13         * gdbtypes.h (lookup_template_type): Update.
  14         (address_space_name_to_int): Update.
  15         * gdbtypes.c (address_space_name_to_int): Make space_identifier
  16         const.
  17         (lookup_template_type): Make name const.
  18         * c-exp.y: Update rules.
  19         (lex_one_token, classify_name, classify_inner_name)
  20         (c_print_token): Update.
  21         * p-exp.y: Update rules.
  22         (yylex): Update.
  23         * f-exp.y: Update rules.
  24         (yylex): Update.
  25         * d-exp.y: Update rules.
  26         (lex_one_token, classify_name, classify_inner_name): Update.
  27         * parse.c (write_dollar_variable, copy_name): Return std::string.
  28         * parser-defs.h (copy_name): Change return type.
  29         * m2-exp.y: Update rules.
  30         (yylex): Update.
  31         * go-exp.y (lex_one_token): Update.
  32         Update rules.
  33         (classify_unsafe_function, classify_packaged_name)
  34         (classify_name, yylex): Update.
  35
  36 2019-04-19  Sergei Trofimovich <siarheit@google.com>
  37
  38         * configure.ac: add --enable-source-highlight switch.
  39         * configure: Regenerate.
  40         * top.c (print_gdb_version): plumb --enable-source-highlight
  41         status to "show configuration".
  42
  43 2019-04-19  Tom Tromey  <tromey@adacore.com>
  44
  45         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
  46         Check ADA_TYPE_P.
  47         (empty_record, ada_template_to_fixed_record_type_1)
  48         (template_to_static_fixed_type)
  49         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
  50         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
  51         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
  52         macros.
  53
  54 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
  55
  56         PR symtab/24423:
  57         * source.c (print_source_lines_base): Advance "iter" when a
  58         control character is seen.
  59
  60 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  61
  62         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
  63         close to the add_com "shell".
  64
  65 2019-04-18  Tom Tromey  <tromey@adacore.com>
  66
  67         * process-stratum-target.h (class process_stratum_target)
  68         <stratum>: Add "final".
  69
  70 2019-04-17  Tom Tromey  <tromey@adacore.com>
  71
  72         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
  73         against nullptr before use.
  74
  75 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
  76
  77         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
  78
  79 2019-04-17  Jim Wilson  <jimw@sifive.com>
  80             Andrew Burgess  <andrew.burgess@embecosm.com>
  81
  82         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
  83         code read might fail, assume 4-byte breakpoint in that case.
  84
  85 2019-04-15  Leszek Swirski  <leszeks@google.com>
  86
  87         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
  88         rather than a hand-rolled POD check when checking for forced MEMORY
  89         classification.
  90
  91 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
  92
  93         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
  94         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
  95         function.
  96         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
  97         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
  98         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
  99         declaration.
 100
 101 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 102
 103         * aarch64-linux-nat.c
 104         (aarch64_linux_nat_target::thread_architecture): Add override.
 105         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 106         each VQ.
 107
 108 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 109
 110         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 111
 112 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 113
 114         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 115         target types of size 96-bits, add some additional comments, and
 116         check that the builtin type we found was the correct size.
 117
 118 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 119
 120         * utils.c (prompt_for_continue): Don't restore the styling at the
 121         end, as applied_style has the wrong value.  This fixes styling in
 122         long lists of file names that are interrupted by the "Continue?"
 123         prompt.
 124
 125 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 126
 127         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 128         * c-lang.c (c_language_defn): Likewise.
 129         (cplus_language_defn): Likewise.
 130         (asm_language_defn): Likewise.
 131         (minimal_language_defn): Likewise.
 132         * d-lang.c (d_language_defn): Likewise.
 133         * f-lang.c (f_language_defn): Likewise.
 134         * go-lang.c (go_language_defn): Likewise.
 135         * language.c (unknown_language_defn): Likewise.
 136         (auto_language_defn): Likewise.
 137         * language.h (struct language_defn): Remove la_magic field.
 138         (LANG_MAGIC): Delete.
 139         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 140         * objc-lang.c (objc_language_defn): Likewise.
 141         * opencl-lang.c (opencl_language_defn): Likewise.
 142         * p-lang.c (pascal_language_defn): Likewise.
 143         * rust-lang.c (rust_language_defn): Likewise.
 144
 145 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 146
 147         * riscv-tdep.c (riscv_type_align): New function.
 148         (riscv_type_alignment): Delete.
 149         (riscv_arg_location): Use 'type_align'.
 150         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 151
 152 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 153
 154         * gdbtypes.c (type_align): A struct with no non-static fields also
 155         has alignment of 1.
 156
 157 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 158
 159         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 160         component to 0.
 161         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 162         member.
 163         (riscv_struct_info::analyse): New implementation using new
 164         analyse_inner member function.
 165         (riscv_struct_info::field_offset): New member function.
 166         (riscv_struct_info::m_offsets): New member variable.
 167         (riscv_struct_info::analyse_inner): New private member function,
 168         takes the old implementation of riscv_struct_info::analyse but
 169         extended to track field offsets.
 170         (riscv_call_arg_struct): Update the struct folding special cases
 171         to handle cases where empty C++ structs, which are non-zero
 172         length, are found.
 173         (riscv_arg_location): Initialise the length of each location, a
 174         non-zero length now indicates the location is in use.
 175         (riscv_push_dummy_call): Allow for the first location having a
 176         non-zero offset when setting up arguments.
 177         (riscv_return_value): Likewise, but for return values.
 178
 179 2019-04-11  Tom Tromey  <tromey@adacore.com>
 180
 181         * utils.c (internal_vproblem): Make "msg" const.
 182
 183 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 184
 185         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 186         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 187         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 188         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 189
 190 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 191
 192         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 193         function.
 194         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 195         of amd64_collect_native_gregset.
 196         (amd64_linux_nat_target::store_registers): Likewise.
 197
 198 2019-04-10  Tom Tromey  <tom@tromey.com>
 199
 200         * symtab.c (lookup_global_symbol_from_objfile)
 201         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 202         * objfiles.h (class separate_debug_iterator): New.
 203         (class separate_debug_range): New.
 204         (struct objfile) <separate_debug_objfiles>: New method.
 205         (objfile_separate_debug_iterate): Don't declare.
 206         * objfiles.c (separate_debug_iterator::operator++): Rename from
 207         objfile_separate_debug_iterate.
 208         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 209         iterator.
 210         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 211         iterator.
 212
 213 2019-04-10  Tom Tromey  <tom@tromey.com>
 214
 215         * symfile.c (reread_symbols): Remove old comment.
 216         * objfiles.c (free_all_objfiles): Fix a typo.
 217
 218 2019-04-10  Tom Tromey  <tom@tromey.com>
 219
 220         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 221         * minsyms.c (lookup_minimal_symbol): Use foreach.
 222         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 223         (lookup_minimal_symbol_solib_trampoline): Likewise.
 224         * symfile.c (reread_symbols): Use foreach.
 225
 226 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 227             Tom Tromey  <tromey@adacore.com>
 228
 229         PR rust/24414:
 230         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 231         (rust_lex_int_test): Change "value" to be LONGEST.
 232         (rust_lex_tests): Add test for long integer literal.
 233
 234 2019-04-09  Tom Tromey  <tromey@adacore.com>
 235
 236         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 237         to bool.
 238         (extended_remote_target::attach): Update.
 239         (remote_target::remote_notice_new_inferior): Update.
 240         (remote_target::add_current_inferior_and_thread): Update.
 241         * inferior.c (exit_inferior_1): Use "false".
 242         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 243
 244 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 245
 246         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 247         the "start" command.
 248
 249 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 250
 251         * python/py-inferior.c (infpy_thread_from_thread_handle):
 252         Adjust comments to reflect renaming of thread_from_thread_handle
 253         to thread_from_handle.  Adjust keywords.  Fix type error message.
 254         (inferior_object_methods): Add thread_from_handle.  Retain
 255         thread_from_thread_handle, but mark it as deprecated.
 256
 257 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 258
 259         * gdbthread.h (find_thread_by_handle): Revise declaration.
 260         * thread.c (find_thread_by_handle): Likewise.  Adjust
 261         implementation too.
 262         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 263         support for buffer objects as handles.
 264
 265 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 266
 267         * python/py-infthread.c (thpy_thread_handle): New function.
 268         (thread_object_methods): Register thpy_thread_handle.
 269
 270 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 271
 272         * gdbthread.h (thread_to_thread_handle): Declare.
 273         * thread.c (gdbtypes.h): Include.
 274         (thread_to_thread_handle): New function.
 275
 276         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 277         (target_thread_info_to_thread_handle): Declare.
 278         * target.c (target_thread_info_to_thread_handle): New function.
 279         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 280         * target-delegates.c: Regenerate.
 281
 282         * linux-thread-db.c (class thread_db_target): Add method
 283         thread_info_to_thread_handle.
 284         (thread_db_target::thread_info_to_thread_handle): Define.
 285         * remote.c (class remote_target): Add new method
 286         thread_info_to_thread_handle.
 287         (remote_target::thread_info_to_thread_handle): Define.
 288
 289 2019-04-08  Pedro Alves  <palves@redhat.com>
 290
 291         * common/common-exceptions.c (throw_exception): Don't create
 292         named object to throw; throw directly.
 293         (throw_it): Likewise.  Don't initialize gdb_exception::message
 294         here, with new; pass FMT and AP to the ctor instead.
 295         * common/common-exceptions.h: Include <string>.
 296         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 297         const char *, va_list)): New ctor.  Use std::make_shared.
 298         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 299         errors)): Delete.
 300         (gdb_exception_error::gdb_exception_error(enum errors, const char
 301         *, va_list)): New.
 302         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 303         Add assertion.
 304         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 305         errors)): Delete.
 306         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 307         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 308         Add assertion.
 309
 310 2019-04-08  Tom Tromey  <tom@tromey.com>
 311
 312         * valops.c (value_rtti_indirect_type): Replace throw_exception
 313         with throw.
 314         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 315         with throw.
 316         * thread.c (thr_try_catch_cmd): Replace throw_exception with
 317         throw.
 318         * target.c (target_translate_tls_address): Replace throw_exception
 319         with throw.
 320         * stack.c (frame_apply_command_count): Replace throw_exception
 321         with throw.
 322         * solib-spu.c (append_ocl_sos): Replace throw_exception with
 323         throw.
 324         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 325         with throw.
 326         * rs6000-tdep.c (rs6000_frame_cache)
 327         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 328         * remote.c: Replace throw_exception with throw.
 329         * record-full.c (record_full_message, record_full_wait_1)
 330         (record_full_restore): Replace throw_exception with throw.
 331         * record-btrace.c:
 332         (get_thread_current_frame_id, record_btrace_start_replaying)
 333         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
 334         (cmd_record_btrace_start): Replace throw_exception with throw.
 335         * parse.c (parse_exp_in_context_1): Replace throw_exception with
 336         throw.
 337         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
 338         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
 339         * linespec.c:
 340         (find_linespec_symbols): Replace throw_exception with throw.
 341         * infrun.c (displaced_step_prepare, resume): Replace
 342         throw_exception with throw.
 343         * infcmd.c (post_create_inferior): Replace throw_exception with
 344         throw.
 345         * inf-loop.c (inferior_event_handler): Replace throw_exception
 346         with throw.
 347         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
 348         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
 349         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
 350         (get_prev_frame_always, get_frame_pc_if_available)
 351         (get_frame_address_in_block_if_available, get_frame_language):
 352         Replace throw_exception with throw.
 353         * frame-unwind.c (frame_unwind_try_unwinder): Replace
 354         throw_exception with throw.
 355         * eval.c (fetch_subexp_value, evaluate_var_value)
 356         (evaluate_funcall, evaluate_subexp_standard): Replace
 357         throw_exception with throw.
 358         * dwarf2loc.c (call_site_find_chain)
 359         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
 360         Replace throw_exception with throw.
 361         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
 362         with throw.
 363         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
 364         throw.
 365         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
 366         * completer.c (complete_line_internal): Replace throw_exception
 367         with throw.
 368         * compile/compile-object-run.c (compile_object_run): Replace
 369         throw_exception with throw.
 370         * cli/cli-script.c (process_next_line): Replace throw_exception
 371         with throw.
 372         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
 373         (btrace_enable, btrace_maint_update_pt_packets): Replace
 374         throw_exception with throw.
 375         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
 376         throw_exception with throw.
 377         * break-catch-throw.c (re_set_exception_catchpoint): Replace
 378         throw_exception with throw.
 379         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
 380         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
 381         * aarch64-tdep.c (aarch64_make_prologue_cache)
 382         (aarch64_make_stub_cache): Replace throw_exception with throw.
 383
 384 2019-04-08  Tom Tromey  <tom@tromey.com>
 385
 386         * common/common-exceptions.c (throw_exception): Rename from
 387         throw_exception_cxx.  Remove old copy.  Make argument const.
 388         (throw_it): Create and throw exception objects directly.
 389         * common/common-exceptions.h (throw_exception): Make argument
 390         const.
 391         (struct gdb_exception_error): Add constructor.
 392         (struct gdb_exception_quit): Add constructor.
 393
 394 2019-04-08  Tom Tromey  <tom@tromey.com>
 395
 396         * common/common-exceptions.h (exception_rethrow): Don't declare.
 397         (TRY_SJLJ): Update comment.
 398         (TRY, CATCH, END_CATCH): Remove.
 399         * common/common-exceptions.c (exception_rethrow): Remove.
 400
 401 2019-04-08  Tom Tromey  <tom@tromey.com>
 402
 403         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
 404         Remove.
 405         (gdb_exception_error): Rename from
 406         gdb_exception_RETURN_MASK_ERROR.
 407         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
 408         (gdb_quit_bad_alloc): Update.
 409         * aarch64-tdep.c: Update.
 410         * ada-lang.c: Update.
 411         * ada-typeprint.c: Update.
 412         * ada-valprint.c: Update.
 413         * amd64-tdep.c: Update.
 414         * arch-utils.c: Update.
 415         * break-catch-throw.c: Update.
 416         * breakpoint.c: Update.
 417         * btrace.c: Update.
 418         * c-varobj.c: Update.
 419         * cli/cli-cmds.c: Update.
 420         * cli/cli-interp.c: Update.
 421         * cli/cli-script.c: Update.
 422         * common/common-exceptions.c: Update.
 423         * common/new-op.c: Update.
 424         * common/selftest.c: Update.
 425         * compile/compile-c-symbols.c: Update.
 426         * compile/compile-cplus-symbols.c: Update.
 427         * compile/compile-object-load.c: Update.
 428         * compile/compile-object-run.c: Update.
 429         * completer.c: Update.
 430         * corelow.c: Update.
 431         * cp-abi.c: Update.
 432         * cp-support.c: Update.
 433         * cp-valprint.c: Update.
 434         * darwin-nat.c: Update.
 435         * disasm-selftests.c: Update.
 436         * dtrace-probe.c: Update.
 437         * dwarf-index-cache.c: Update.
 438         * dwarf-index-write.c: Update.
 439         * dwarf2-frame-tailcall.c: Update.
 440         * dwarf2-frame.c: Update.
 441         * dwarf2loc.c: Update.
 442         * dwarf2read.c: Update.
 443         * eval.c: Update.
 444         * event-loop.c: Update.
 445         * event-top.c: Update.
 446         * exec.c: Update.
 447         * f-valprint.c: Update.
 448         * fbsd-tdep.c: Update.
 449         * frame-unwind.c: Update.
 450         * frame.c: Update.
 451         * gdbtypes.c: Update.
 452         * gnu-v3-abi.c: Update.
 453         * guile/guile-internal.h: Update.
 454         * guile/scm-block.c: Update.
 455         * guile/scm-breakpoint.c: Update.
 456         * guile/scm-cmd.c: Update.
 457         * guile/scm-disasm.c: Update.
 458         * guile/scm-frame.c: Update.
 459         * guile/scm-lazy-string.c: Update.
 460         * guile/scm-math.c: Update.
 461         * guile/scm-param.c: Update.
 462         * guile/scm-ports.c: Update.
 463         * guile/scm-pretty-print.c: Update.
 464         * guile/scm-symbol.c: Update.
 465         * guile/scm-symtab.c: Update.
 466         * guile/scm-type.c: Update.
 467         * guile/scm-value.c: Update.
 468         * i386-linux-tdep.c: Update.
 469         * i386-tdep.c: Update.
 470         * inf-loop.c: Update.
 471         * infcall.c: Update.
 472         * infcmd.c: Update.
 473         * infrun.c: Update.
 474         * jit.c: Update.
 475         * language.c: Update.
 476         * linespec.c: Update.
 477         * linux-fork.c: Update.
 478         * linux-nat.c: Update.
 479         * linux-tdep.c: Update.
 480         * linux-thread-db.c: Update.
 481         * main.c: Update.
 482         * mi/mi-cmd-break.c: Update.
 483         * mi/mi-cmd-stack.c: Update.
 484         * mi/mi-interp.c: Update.
 485         * mi/mi-main.c: Update.
 486         * objc-lang.c: Update.
 487         * p-valprint.c: Update.
 488         * parse.c: Update.
 489         * ppc-linux-tdep.c: Update.
 490         * printcmd.c: Update.
 491         * python/py-arch.c: Update.
 492         * python/py-breakpoint.c: Update.
 493         * python/py-cmd.c: Update.
 494         * python/py-finishbreakpoint.c: Update.
 495         * python/py-frame.c: Update.
 496         * python/py-framefilter.c: Update.
 497         * python/py-gdb-readline.c: Update.
 498         * python/py-inferior.c: Update.
 499         * python/py-infthread.c: Update.
 500         * python/py-lazy-string.c: Update.
 501         * python/py-linetable.c: Update.
 502         * python/py-objfile.c: Update.
 503         * python/py-param.c: Update.
 504         * python/py-prettyprint.c: Update.
 505         * python/py-progspace.c: Update.
 506         * python/py-record-btrace.c: Update.
 507         * python/py-record.c: Update.
 508         * python/py-symbol.c: Update.
 509         * python/py-type.c: Update.
 510         * python/py-unwind.c: Update.
 511         * python/py-utils.c: Update.
 512         * python/py-value.c: Update.
 513         * python/python.c: Update.
 514         * record-btrace.c: Update.
 515         * record-full.c: Update.
 516         * remote-fileio.c: Update.
 517         * remote.c: Update.
 518         * riscv-tdep.c: Update.
 519         * rs6000-aix-tdep.c: Update.
 520         * rs6000-tdep.c: Update.
 521         * rust-exp.y: Update.
 522         * rust-lang.c: Update.
 523         * s390-tdep.c: Update.
 524         * selftest-arch.c: Update.
 525         * solib-dsbt.c: Update.
 526         * solib-frv.c: Update.
 527         * solib-spu.c: Update.
 528         * solib-svr4.c: Update.
 529         * solib.c: Update.
 530         * sparc64-linux-tdep.c: Update.
 531         * stack.c: Update.
 532         * symfile-mem.c: Update.
 533         * symmisc.c: Update.
 534         * target.c: Update.
 535         * thread.c: Update.
 536         * top.c: Update.
 537         * tracefile-tfile.c: Update.
 538         * tui/tui.c: Update.
 539         * typeprint.c: Update.
 540         * unittests/cli-utils-selftests.c: Update.
 541         * unittests/parse-connection-spec-selftests.c: Update.
 542         * valops.c: Update.
 543         * valprint.c: Update.
 544         * value.c: Update.
 545         * varobj.c: Update.
 546         * windows-nat.c: Update.
 547         * x86-linux-nat.c: Update.
 548         * xml-support.c: Update.
 549
 550 2019-04-08  Tom Tromey  <tom@tromey.com>
 551
 552         * xml-support.c: Use C++ exception handling.
 553         * x86-linux-nat.c: Use C++ exception handling.
 554         * windows-nat.c: Use C++ exception handling.
 555         * varobj.c: Use C++ exception handling.
 556         * value.c: Use C++ exception handling.
 557         * valprint.c: Use C++ exception handling.
 558         * valops.c: Use C++ exception handling.
 559         * unittests/parse-connection-spec-selftests.c: Use C++ exception
 560         handling.
 561         * unittests/cli-utils-selftests.c: Use C++ exception handling.
 562         * typeprint.c: Use C++ exception handling.
 563         * tui/tui.c: Use C++ exception handling.
 564         * tracefile-tfile.c: Use C++ exception handling.
 565         * top.c: Use C++ exception handling.
 566         * thread.c: Use C++ exception handling.
 567         * target.c: Use C++ exception handling.
 568         * symmisc.c: Use C++ exception handling.
 569         * symfile-mem.c: Use C++ exception handling.
 570         * stack.c: Use C++ exception handling.
 571         * sparc64-linux-tdep.c: Use C++ exception handling.
 572         * solib.c: Use C++ exception handling.
 573         * solib-svr4.c: Use C++ exception handling.
 574         * solib-spu.c: Use C++ exception handling.
 575         * solib-frv.c: Use C++ exception handling.
 576         * solib-dsbt.c: Use C++ exception handling.
 577         * selftest-arch.c: Use C++ exception handling.
 578         * s390-tdep.c: Use C++ exception handling.
 579         * rust-lang.c: Use C++ exception handling.
 580         * rust-exp.y: Use C++ exception handling.
 581         * rs6000-tdep.c: Use C++ exception handling.
 582         * rs6000-aix-tdep.c: Use C++ exception handling.
 583         * riscv-tdep.c: Use C++ exception handling.
 584         * remote.c: Use C++ exception handling.
 585         * remote-fileio.c: Use C++ exception handling.
 586         * record-full.c: Use C++ exception handling.
 587         * record-btrace.c: Use C++ exception handling.
 588         * python/python.c: Use C++ exception handling.
 589         * python/py-value.c: Use C++ exception handling.
 590         * python/py-utils.c: Use C++ exception handling.
 591         * python/py-unwind.c: Use C++ exception handling.
 592         * python/py-type.c: Use C++ exception handling.
 593         * python/py-symbol.c: Use C++ exception handling.
 594         * python/py-record.c: Use C++ exception handling.
 595         * python/py-record-btrace.c: Use C++ exception handling.
 596         * python/py-progspace.c: Use C++ exception handling.
 597         * python/py-prettyprint.c: Use C++ exception handling.
 598         * python/py-param.c: Use C++ exception handling.
 599         * python/py-objfile.c: Use C++ exception handling.
 600         * python/py-linetable.c: Use C++ exception handling.
 601         * python/py-lazy-string.c: Use C++ exception handling.
 602         * python/py-infthread.c: Use C++ exception handling.
 603         * python/py-inferior.c: Use C++ exception handling.
 604         * python/py-gdb-readline.c: Use C++ exception handling.
 605         * python/py-framefilter.c: Use C++ exception handling.
 606         * python/py-frame.c: Use C++ exception handling.
 607         * python/py-finishbreakpoint.c: Use C++ exception handling.
 608         * python/py-cmd.c: Use C++ exception handling.
 609         * python/py-breakpoint.c: Use C++ exception handling.
 610         * python/py-arch.c: Use C++ exception handling.
 611         * printcmd.c: Use C++ exception handling.
 612         * ppc-linux-tdep.c: Use C++ exception handling.
 613         * parse.c: Use C++ exception handling.
 614         * p-valprint.c: Use C++ exception handling.
 615         * objc-lang.c: Use C++ exception handling.
 616         * mi/mi-main.c: Use C++ exception handling.
 617         * mi/mi-interp.c: Use C++ exception handling.
 618         * mi/mi-cmd-stack.c: Use C++ exception handling.
 619         * mi/mi-cmd-break.c: Use C++ exception handling.
 620         * main.c: Use C++ exception handling.
 621         * linux-thread-db.c: Use C++ exception handling.
 622         * linux-tdep.c: Use C++ exception handling.
 623         * linux-nat.c: Use C++ exception handling.
 624         * linux-fork.c: Use C++ exception handling.
 625         * linespec.c: Use C++ exception handling.
 626         * language.c: Use C++ exception handling.
 627         * jit.c: Use C++ exception handling.
 628         * infrun.c: Use C++ exception handling.
 629         * infcmd.c: Use C++ exception handling.
 630         * infcall.c: Use C++ exception handling.
 631         * inf-loop.c: Use C++ exception handling.
 632         * i386-tdep.c: Use C++ exception handling.
 633         * i386-linux-tdep.c: Use C++ exception handling.
 634         * guile/scm-value.c: Use C++ exception handling.
 635         * guile/scm-type.c: Use C++ exception handling.
 636         * guile/scm-symtab.c: Use C++ exception handling.
 637         * guile/scm-symbol.c: Use C++ exception handling.
 638         * guile/scm-pretty-print.c: Use C++ exception handling.
 639         * guile/scm-ports.c: Use C++ exception handling.
 640         * guile/scm-param.c: Use C++ exception handling.
 641         * guile/scm-math.c: Use C++ exception handling.
 642         * guile/scm-lazy-string.c: Use C++ exception handling.
 643         * guile/scm-frame.c: Use C++ exception handling.
 644         * guile/scm-disasm.c: Use C++ exception handling.
 645         * guile/scm-cmd.c: Use C++ exception handling.
 646         * guile/scm-breakpoint.c: Use C++ exception handling.
 647         * guile/scm-block.c: Use C++ exception handling.
 648         * guile/guile-internal.h: Use C++ exception handling.
 649         * gnu-v3-abi.c: Use C++ exception handling.
 650         * gdbtypes.c: Use C++ exception handling.
 651         * frame.c: Use C++ exception handling.
 652         * frame-unwind.c: Use C++ exception handling.
 653         * fbsd-tdep.c: Use C++ exception handling.
 654         * f-valprint.c: Use C++ exception handling.
 655         * exec.c: Use C++ exception handling.
 656         * event-top.c: Use C++ exception handling.
 657         * event-loop.c: Use C++ exception handling.
 658         * eval.c: Use C++ exception handling.
 659         * dwarf2read.c: Use C++ exception handling.
 660         * dwarf2loc.c: Use C++ exception handling.
 661         * dwarf2-frame.c: Use C++ exception handling.
 662         * dwarf2-frame-tailcall.c: Use C++ exception handling.
 663         * dwarf-index-write.c: Use C++ exception handling.
 664         * dwarf-index-cache.c: Use C++ exception handling.
 665         * dtrace-probe.c: Use C++ exception handling.
 666         * disasm-selftests.c: Use C++ exception handling.
 667         * darwin-nat.c: Use C++ exception handling.
 668         * cp-valprint.c: Use C++ exception handling.
 669         * cp-support.c: Use C++ exception handling.
 670         * cp-abi.c: Use C++ exception handling.
 671         * corelow.c: Use C++ exception handling.
 672         * completer.c: Use C++ exception handling.
 673         * compile/compile-object-run.c: Use C++ exception handling.
 674         * compile/compile-object-load.c: Use C++ exception handling.
 675         * compile/compile-cplus-symbols.c: Use C++ exception handling.
 676         * compile/compile-c-symbols.c: Use C++ exception handling.
 677         * common/selftest.c: Use C++ exception handling.
 678         * common/new-op.c: Use C++ exception handling.
 679         * cli/cli-script.c: Use C++ exception handling.
 680         * cli/cli-interp.c: Use C++ exception handling.
 681         * cli/cli-cmds.c: Use C++ exception handling.
 682         * c-varobj.c: Use C++ exception handling.
 683         * btrace.c: Use C++ exception handling.
 684         * breakpoint.c: Use C++ exception handling.
 685         * break-catch-throw.c: Use C++ exception handling.
 686         * arch-utils.c: Use C++ exception handling.
 687         * amd64-tdep.c: Use C++ exception handling.
 688         * ada-valprint.c: Use C++ exception handling.
 689         * ada-typeprint.c: Use C++ exception handling.
 690         * ada-lang.c: Use C++ exception handling.
 691         * aarch64-tdep.c: Use C++ exception handling.
 692
 693 2019-04-08  Tom Tromey  <tom@tromey.com>
 694
 695         * xml-support.c (gdb_xml_parser::parse): Update.
 696         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 697         * value.c (show_convenience): Update.
 698         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
 699         (test_parse_flags_qcs): Update.
 700         * thread.c (thr_try_catch_cmd): Update.
 701         * target.c (target_translate_tls_address): Update.
 702         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 703         (info_frame_command_core, frame_apply_command_count): Update.
 704         * rust-exp.y (rust_lex_exception_test): Update.
 705         * riscv-tdep.c (riscv_print_one_register_info): Update.
 706         * remote.c (remote_target::enable_btrace): Update.
 707         * record-btrace.c (record_btrace_enable_warn): Update.
 708         * python/py-utils.c (gdbpy_convert_exception): Update.
 709         * printcmd.c (do_one_display, print_variable_and_value): Update.
 710         * mi/mi-main.c (mi_print_exception): Update.
 711         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
 712         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 713         * linux-nat.c (linux_nat_target::attach): Update.
 714         * linux-fork.c (class scoped_switch_fork_info): Update.
 715         * infrun.c (displaced_step_prepare): Update.
 716         * infcall.c (call_function_by_hand_dummy): Update.
 717         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
 718         * gnu-v3-abi.c (print_one_vtable): Update.
 719         * frame.c (get_prev_frame_always): Update.
 720         * f-valprint.c (info_common_command_for_block): Update.
 721         * exec.c (try_open_exec_file): Update.
 722         * exceptions.c (print_exception, exception_print)
 723         (exception_fprintf, exception_print_same): Update.
 724         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
 725         * dwarf-index-cache.c (index_cache::store)
 726         (index_cache::lookup_gdb_index): Update.
 727         * darwin-nat.c (maybe_cache_shell): Update.
 728         * cp-valprint.c (cp_print_value_fields): Update.
 729         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
 730         (gcc_cplus_symbol_address): Update.
 731         * compile/compile-c-symbols.c (gcc_convert_symbol)
 732         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
 733         * common/selftest.c: Update.
 734         * common/common-exceptions.h (struct gdb_exception) <message>: Now
 735         a std::string.
 736         (exception_try_scope_entry, exception_try_scope_exit): Don't
 737         declare.
 738         (struct exception_try_scope): Remove.
 739         (TRY): Don't use exception_try_scope.
 740         (struct gdb_exception): Add constructor, operator=.
 741         <what>: New method.
 742         (struct gdb_exception_RETURN_MASK_ALL)
 743         (struct gdb_exception_RETURN_MASK_ERROR)
 744         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
 745         (struct gdb_quit_bad_alloc): Update.
 746         * common/common-exceptions.c (exception_none): Change
 747         initializer.
 748         (struct catcher) <state, exception>: Initialize inline.
 749         <prev>: Remove member.
 750         (current_catcher): Remove.
 751         (catchers): New global.
 752         (exceptions_state_mc_init): Simplify.
 753         (catcher_pop): Remove.
 754         (exceptions_state_mc, exceptions_state_mc_catch): Update.
 755         (try_scope_depth, exception_try_scope_entry)
 756         (exception_try_scope_exit): Remove.
 757         (throw_exception_sjlj): Update.
 758         (exception_messages, exception_messages_size): Remove.
 759         (throw_it): Simplify.
 760         (gdb_exception_sliced_copy): Remove.
 761         (throw_exception_cxx): Update.
 762         * cli/cli-script.c (script_from_file): Update.
 763         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
 764         Update.
 765         * ada-valprint.c (ada_val_print): Update.
 766         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
 767         (create_excep_cond_exprs): Update.
 768
 769 2019-04-08  Tom Tromey  <tom@tromey.com>
 770
 771         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
 772         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
 773         (TRY, CATCH, END_CATCH): Remove some definitions.
 774         * common/common-exceptions.c: Don't use GDB_XCPT.
 775         (catcher_list_size): Remove.
 776         (throw_exception, throw_it): Simplify.
 777
 778 2019-04-05  Tom Tromey  <tom@tromey.com>
 779
 780         Revert the header-sorting patch.
 781         * ft32-tdep.c: Revert.
 782         * frv-tdep.c: Revert.
 783         * frv-linux-tdep.c: Revert.
 784         * frame.c: Revert.
 785         * frame-unwind.c: Revert.
 786         * frame-base.c: Revert.
 787         * fork-child.c: Revert.
 788         * findvar.c: Revert.
 789         * findcmd.c: Revert.
 790         * filesystem.c: Revert.
 791         * filename-seen-cache.h: Revert.
 792         * filename-seen-cache.c: Revert.
 793         * fbsd-tdep.c: Revert.
 794         * fbsd-nat.h: Revert.
 795         * fbsd-nat.c: Revert.
 796         * f-valprint.c: Revert.
 797         * f-typeprint.c: Revert.
 798         * f-lang.c: Revert.
 799         * extension.h: Revert.
 800         * extension.c: Revert.
 801         * extension-priv.h: Revert.
 802         * expprint.c: Revert.
 803         * exec.h: Revert.
 804         * exec.c: Revert.
 805         * exceptions.c: Revert.
 806         * event-top.c: Revert.
 807         * event-loop.c: Revert.
 808         * eval.c: Revert.
 809         * elfread.c: Revert.
 810         * dwarf2read.h: Revert.
 811         * dwarf2read.c: Revert.
 812         * dwarf2loc.c: Revert.
 813         * dwarf2expr.h: Revert.
 814         * dwarf2expr.c: Revert.
 815         * dwarf2-frame.c: Revert.
 816         * dwarf2-frame-tailcall.c: Revert.
 817         * dwarf-index-write.h: Revert.
 818         * dwarf-index-write.c: Revert.
 819         * dwarf-index-common.c: Revert.
 820         * dwarf-index-cache.h: Revert.
 821         * dwarf-index-cache.c: Revert.
 822         * dummy-frame.c: Revert.
 823         * dtrace-probe.c: Revert.
 824         * disasm.h: Revert.
 825         * disasm.c: Revert.
 826         * disasm-selftests.c: Revert.
 827         * dictionary.c: Revert.
 828         * dicos-tdep.c: Revert.
 829         * demangle.c: Revert.
 830         * dcache.h: Revert.
 831         * dcache.c: Revert.
 832         * darwin-nat.h: Revert.
 833         * darwin-nat.c: Revert.
 834         * darwin-nat-info.c: Revert.
 835         * d-valprint.c: Revert.
 836         * d-namespace.c: Revert.
 837         * d-lang.c: Revert.
 838         * ctf.c: Revert.
 839         * csky-tdep.c: Revert.
 840         * csky-linux-tdep.c: Revert.
 841         * cris-tdep.c: Revert.
 842         * cris-linux-tdep.c: Revert.
 843         * cp-valprint.c: Revert.
 844         * cp-support.c: Revert.
 845         * cp-namespace.c: Revert.
 846         * cp-abi.c: Revert.
 847         * corelow.c: Revert.
 848         * corefile.c: Revert.
 849         * continuations.c: Revert.
 850         * completer.h: Revert.
 851         * completer.c: Revert.
 852         * complaints.c: Revert.
 853         * coffread.c: Revert.
 854         * coff-pe-read.c: Revert.
 855         * cli-out.h: Revert.
 856         * cli-out.c: Revert.
 857         * charset.c: Revert.
 858         * c-varobj.c: Revert.
 859         * c-valprint.c: Revert.
 860         * c-typeprint.c: Revert.
 861         * c-lang.c: Revert.
 862         * buildsym.c: Revert.
 863         * buildsym-legacy.c: Revert.
 864         * build-id.h: Revert.
 865         * build-id.c: Revert.
 866         * btrace.c: Revert.
 867         * bsd-uthread.c: Revert.
 868         * breakpoint.h: Revert.
 869         * breakpoint.c: Revert.
 870         * break-catch-throw.c: Revert.
 871         * break-catch-syscall.c: Revert.
 872         * break-catch-sig.c: Revert.
 873         * blockframe.c: Revert.
 874         * block.c: Revert.
 875         * bfin-tdep.c: Revert.
 876         * bfin-linux-tdep.c: Revert.
 877         * bfd-target.c: Revert.
 878         * bcache.c: Revert.
 879         * ax-general.c: Revert.
 880         * ax-gdb.h: Revert.
 881         * ax-gdb.c: Revert.
 882         * avr-tdep.c: Revert.
 883         * auxv.c: Revert.
 884         * auto-load.c: Revert.
 885         * arm-wince-tdep.c: Revert.
 886         * arm-tdep.c: Revert.
 887         * arm-symbian-tdep.c: Revert.
 888         * arm-pikeos-tdep.c: Revert.
 889         * arm-obsd-tdep.c: Revert.
 890         * arm-nbsd-tdep.c: Revert.
 891         * arm-nbsd-nat.c: Revert.
 892         * arm-linux-tdep.c: Revert.
 893         * arm-linux-nat.c: Revert.
 894         * arm-fbsd-tdep.c: Revert.
 895         * arm-fbsd-nat.c: Revert.
 896         * arm-bsd-tdep.c: Revert.
 897         * arch-utils.c: Revert.
 898         * arc-tdep.c: Revert.
 899         * arc-newlib-tdep.c: Revert.
 900         * annotate.h: Revert.
 901         * annotate.c: Revert.
 902         * amd64-windows-tdep.c: Revert.
 903         * amd64-windows-nat.c: Revert.
 904         * amd64-tdep.c: Revert.
 905         * amd64-sol2-tdep.c: Revert.
 906         * amd64-obsd-tdep.c: Revert.
 907         * amd64-obsd-nat.c: Revert.
 908         * amd64-nbsd-tdep.c: Revert.
 909         * amd64-nbsd-nat.c: Revert.
 910         * amd64-nat.c: Revert.
 911         * amd64-linux-tdep.c: Revert.
 912         * amd64-linux-nat.c: Revert.
 913         * amd64-fbsd-tdep.c: Revert.
 914         * amd64-fbsd-nat.c: Revert.
 915         * amd64-dicos-tdep.c: Revert.
 916         * amd64-darwin-tdep.c: Revert.
 917         * amd64-bsd-nat.c: Revert.
 918         * alpha-tdep.c: Revert.
 919         * alpha-obsd-tdep.c: Revert.
 920         * alpha-nbsd-tdep.c: Revert.
 921         * alpha-mdebug-tdep.c: Revert.
 922         * alpha-linux-tdep.c: Revert.
 923         * alpha-linux-nat.c: Revert.
 924         * alpha-bsd-tdep.c: Revert.
 925         * alpha-bsd-nat.c: Revert.
 926         * aix-thread.c: Revert.
 927         * agent.c: Revert.
 928         * addrmap.c: Revert.
 929         * ada-varobj.c: Revert.
 930         * ada-valprint.c: Revert.
 931         * ada-typeprint.c: Revert.
 932         * ada-tasks.c: Revert.
 933         * ada-lang.c: Revert.
 934         * aarch64-tdep.c: Revert.
 935         * aarch64-ravenscar-thread.c: Revert.
 936         * aarch64-newlib-tdep.c: Revert.
 937         * aarch64-linux-tdep.c: Revert.
 938         * aarch64-linux-nat.c: Revert.
 939         * aarch64-fbsd-tdep.c: Revert.
 940         * aarch64-fbsd-nat.c: Revert.
 941         * aarch32-linux-nat.c: Revert.
 942
 943 2019-04-05  Tom Tromey  <tom@tromey.com>
 944
 945         * ft32-tdep.c: Sort headers.
 946         * frv-tdep.c: Sort headers.
 947         * frv-linux-tdep.c: Sort headers.
 948         * frame.c: Sort headers.
 949         * frame-unwind.c: Sort headers.
 950         * frame-base.c: Sort headers.
 951         * fork-child.c: Sort headers.
 952         * findvar.c: Sort headers.
 953         * findcmd.c: Sort headers.
 954         * filesystem.c: Sort headers.
 955         * filename-seen-cache.h: Sort headers.
 956         * filename-seen-cache.c: Sort headers.
 957         * fbsd-tdep.c: Sort headers.
 958         * fbsd-nat.h: Sort headers.
 959         * fbsd-nat.c: Sort headers.
 960         * f-valprint.c: Sort headers.
 961         * f-typeprint.c: Sort headers.
 962         * f-lang.c: Sort headers.
 963         * extension.h: Sort headers.
 964         * extension.c: Sort headers.
 965         * extension-priv.h: Sort headers.
 966         * expprint.c: Sort headers.
 967         * exec.h: Sort headers.
 968         * exec.c: Sort headers.
 969         * exceptions.c: Sort headers.
 970         * event-top.c: Sort headers.
 971         * event-loop.c: Sort headers.
 972         * eval.c: Sort headers.
 973         * elfread.c: Sort headers.
 974         * dwarf2read.h: Sort headers.
 975         * dwarf2read.c: Sort headers.
 976         * dwarf2loc.c: Sort headers.
 977         * dwarf2expr.h: Sort headers.
 978         * dwarf2expr.c: Sort headers.
 979         * dwarf2-frame.c: Sort headers.
 980         * dwarf2-frame-tailcall.c: Sort headers.
 981         * dwarf-index-write.h: Sort headers.
 982         * dwarf-index-write.c: Sort headers.
 983         * dwarf-index-common.c: Sort headers.
 984         * dwarf-index-cache.h: Sort headers.
 985         * dwarf-index-cache.c: Sort headers.
 986         * dummy-frame.c: Sort headers.
 987         * dtrace-probe.c: Sort headers.
 988         * disasm.h: Sort headers.
 989         * disasm.c: Sort headers.
 990         * disasm-selftests.c: Sort headers.
 991         * dictionary.c: Sort headers.
 992         * dicos-tdep.c: Sort headers.
 993         * demangle.c: Sort headers.
 994         * dcache.h: Sort headers.
 995         * dcache.c: Sort headers.
 996         * darwin-nat.h: Sort headers.
 997         * darwin-nat.c: Sort headers.
 998         * darwin-nat-info.c: Sort headers.
 999         * d-valprint.c: Sort headers.
1000         * d-namespace.c: Sort headers.
1001         * d-lang.c: Sort headers.
1002         * ctf.c: Sort headers.
1003         * csky-tdep.c: Sort headers.
1004         * csky-linux-tdep.c: Sort headers.
1005         * cris-tdep.c: Sort headers.
1006         * cris-linux-tdep.c: Sort headers.
1007         * cp-valprint.c: Sort headers.
1008         * cp-support.c: Sort headers.
1009         * cp-namespace.c: Sort headers.
1010         * cp-abi.c: Sort headers.
1011         * corelow.c: Sort headers.
1012         * corefile.c: Sort headers.
1013         * continuations.c: Sort headers.
1014         * completer.h: Sort headers.
1015         * completer.c: Sort headers.
1016         * complaints.c: Sort headers.
1017         * coffread.c: Sort headers.
1018         * coff-pe-read.c: Sort headers.
1019         * cli-out.h: Sort headers.
1020         * cli-out.c: Sort headers.
1021         * charset.c: Sort headers.
1022         * c-varobj.c: Sort headers.
1023         * c-valprint.c: Sort headers.
1024         * c-typeprint.c: Sort headers.
1025         * c-lang.c: Sort headers.
1026         * buildsym.c: Sort headers.
1027         * buildsym-legacy.c: Sort headers.
1028         * build-id.h: Sort headers.
1029         * build-id.c: Sort headers.
1030         * btrace.c: Sort headers.
1031         * bsd-uthread.c: Sort headers.
1032         * breakpoint.h: Sort headers.
1033         * breakpoint.c: Sort headers.
1034         * break-catch-throw.c: Sort headers.
1035         * break-catch-syscall.c: Sort headers.
1036         * break-catch-sig.c: Sort headers.
1037         * blockframe.c: Sort headers.
1038         * block.c: Sort headers.
1039         * bfin-tdep.c: Sort headers.
1040         * bfin-linux-tdep.c: Sort headers.
1041         * bfd-target.c: Sort headers.
1042         * bcache.c: Sort headers.
1043         * ax-general.c: Sort headers.
1044         * ax-gdb.h: Sort headers.
1045         * ax-gdb.c: Sort headers.
1046         * avr-tdep.c: Sort headers.
1047         * auxv.c: Sort headers.
1048         * auto-load.c: Sort headers.
1049         * arm-wince-tdep.c: Sort headers.
1050         * arm-tdep.c: Sort headers.
1051         * arm-symbian-tdep.c: Sort headers.
1052         * arm-pikeos-tdep.c: Sort headers.
1053         * arm-obsd-tdep.c: Sort headers.
1054         * arm-nbsd-tdep.c: Sort headers.
1055         * arm-nbsd-nat.c: Sort headers.
1056         * arm-linux-tdep.c: Sort headers.
1057         * arm-linux-nat.c: Sort headers.
1058         * arm-fbsd-tdep.c: Sort headers.
1059         * arm-fbsd-nat.c: Sort headers.
1060         * arm-bsd-tdep.c: Sort headers.
1061         * arch-utils.c: Sort headers.
1062         * arc-tdep.c: Sort headers.
1063         * arc-newlib-tdep.c: Sort headers.
1064         * annotate.h: Sort headers.
1065         * annotate.c: Sort headers.
1066         * amd64-windows-tdep.c: Sort headers.
1067         * amd64-windows-nat.c: Sort headers.
1068         * amd64-tdep.c: Sort headers.
1069         * amd64-sol2-tdep.c: Sort headers.
1070         * amd64-obsd-tdep.c: Sort headers.
1071         * amd64-obsd-nat.c: Sort headers.
1072         * amd64-nbsd-tdep.c: Sort headers.
1073         * amd64-nbsd-nat.c: Sort headers.
1074         * amd64-nat.c: Sort headers.
1075         * amd64-linux-tdep.c: Sort headers.
1076         * amd64-linux-nat.c: Sort headers.
1077         * amd64-fbsd-tdep.c: Sort headers.
1078         * amd64-fbsd-nat.c: Sort headers.
1079         * amd64-dicos-tdep.c: Sort headers.
1080         * amd64-darwin-tdep.c: Sort headers.
1081         * amd64-bsd-nat.c: Sort headers.
1082         * alpha-tdep.c: Sort headers.
1083         * alpha-obsd-tdep.c: Sort headers.
1084         * alpha-nbsd-tdep.c: Sort headers.
1085         * alpha-mdebug-tdep.c: Sort headers.
1086         * alpha-linux-tdep.c: Sort headers.
1087         * alpha-linux-nat.c: Sort headers.
1088         * alpha-bsd-tdep.c: Sort headers.
1089         * alpha-bsd-nat.c: Sort headers.
1090         * aix-thread.c: Sort headers.
1091         * agent.c: Sort headers.
1092         * addrmap.c: Sort headers.
1093         * ada-varobj.c: Sort headers.
1094         * ada-valprint.c: Sort headers.
1095         * ada-typeprint.c: Sort headers.
1096         * ada-tasks.c: Sort headers.
1097         * ada-lang.c: Sort headers.
1098         * aarch64-tdep.c: Sort headers.
1099         * aarch64-ravenscar-thread.c: Sort headers.
1100         * aarch64-newlib-tdep.c: Sort headers.
1101         * aarch64-linux-tdep.c: Sort headers.
1102         * aarch64-linux-nat.c: Sort headers.
1103         * aarch64-fbsd-tdep.c: Sort headers.
1104         * aarch64-fbsd-nat.c: Sort headers.
1105         * aarch32-linux-nat.c: Sort headers.
1106
1107 2019-04-04  Tom Tromey  <tom@tromey.com>
1108
1109         * varobj.c (varobj_create): Update.
1110         * rust-exp.y (struct rust_parser) <update_innermost_block,
1111         lookup_symbol>: New methods.
1112         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1113         Rename.
1114         (rust_parser::rust_lookup_type)
1115         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1116         * printcmd.c (display_command, do_one_display): Update.
1117         * parser-defs.h (struct parser_state) <parser_state>: Add
1118         "tracker" parameter.
1119         (block_tracker): New member.
1120         (class innermost_block_tracker) <innermost_block_tracker>: Add
1121         "types" parameter.
1122         <reset>: Remove method.
1123         (innermost_block): Don't declare.
1124         (null_post_parser): Update.
1125         * parse.c (innermost_block): Remove global.
1126         (write_dollar_variable): Update.
1127         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1128         Remove "tracker_types" parameter.
1129         (parse_expression): Add "tracker" parameter.
1130         (parse_expression_for_completion): Update.
1131         (null_post_parser): Add "tracker" parameter.
1132         * p-exp.y: Update rules.
1133         * m2-exp.y: Update rules.
1134         * language.h (struct language_defn) <la_post_parser>: Add
1135         "tracker" parameter.
1136         * go-exp.y: Update rules.
1137         * f-exp.y: Update rules.
1138         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1139         parameter.
1140         * d-exp.y: Update rules.
1141         * c-exp.y: Update rules.
1142         * breakpoint.c (set_breakpoint_condition): Create an
1143         innermost_block_tracker.
1144         (watch_command_1): Likewise.
1145         * ada-lang.c (resolve): Add "tracker" parameter.
1146         (resolve_subexp): Likewise.
1147         * ada-exp.y (write_var_from_sym): Update.
1148
1149 2019-04-04  Tom Tromey  <tom@tromey.com>
1150
1151         * type-stack.h: New file.
1152         * type-stack.c: New file.
1153         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1154         type-stack.h.
1155         (insert_into_type_stack, insert_type, push_type, push_type_int)
1156         (insert_type_address_space, pop_type, pop_type_int)
1157         (pop_typelist, pop_type_stack, append_type_stack)
1158         (push_type_stack, get_type_stack, push_typelist)
1159         (follow_type_instance_flags, follow_types): Don't declare.
1160         * parse.c (type_stack): Remove global.
1161         (parse_exp_in_context): Update.
1162         (insert_into_type_stack, insert_type, push_type, push_type_int)
1163         (insert_type_address_space, pop_type, pop_type_int)
1164         (pop_typelist, pop_type_stack, append_type_stack)
1165         (push_type_stack, get_type_stack, push_typelist)
1166         (follow_type_instance_flags, follow_types): Remove (moved to
1167         type-stack.c).
1168         * f-exp.y (type_stack): New global.
1169         Update rules.
1170         (push_kind_type, f_parse): Update.
1171         * d-exp.y (type_stack): New global.
1172         Update rules.
1173         (d_parse): Update.
1174         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1175         Update rules.
1176         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1177         (HFILES_NO_SRCDIR): Add type-stack.h.
1178
1179 2019-04-04  Tom Tromey  <tom@tromey.com>
1180
1181         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1182         (rust_parser::convert_ast_to_expression, rust_parse)
1183         (rust_lex_test_completion, rust_lex_tests): Update.
1184         * parser-defs.h (struct expr_completion_state): New.
1185         (struct parser_state) <parser_state>: Add completion parameter.
1186         <mark_struct_expression, mark_completion_tag>: New methods.
1187         <parse_completion, m_completion_state>: New members.
1188         (prefixify_expression, null_post_parser): Update.
1189         (mark_struct_expression, mark_completion_tag): Don't declare.
1190         * parse.c (parse_completion, expout_last_struct)
1191         (expout_tag_completion_type, expout_completion_name): Remove
1192         globals.
1193         (parser_state::mark_struct_expression)
1194         (parser_state::mark_completion_tag): Now methods.
1195         (prefixify_expression): Add last_struct parameter.
1196         (prefixify_subexp): Likewise.
1197         (parse_exp_1): Update.
1198         (parse_exp_in_context): Add cstate parameter.  Update.
1199         (parse_expression_for_completion): Create an
1200         expr_completion_state.
1201         (null_post_parser): Add "completion" parameter.
1202         * p-exp.y: Update rules.
1203         (yylex): Update.
1204         * language.h (struct language_defn) <la_post_parser>: Add
1205         "completing" parameter.
1206         * go-exp.y: Update rules.
1207         (lex_one_token): Update.
1208         * expression.h (parse_completion): Don't declare.
1209         * d-exp.y: Update rules.
1210         (lex_one_token): Update rules.
1211         * c-exp.y: Update rules.
1212         (lex_one_token): Update.
1213         * ada-lang.c (resolve): Add "parse_completion" parameter.
1214         (resolve_subexp): Likewise.
1215         (ada_resolve_function): Likewise.
1216
1217 2019-04-04  Tom Tromey  <tom@tromey.com>
1218
1219         * parser-defs.h (struct parser_state) <start_arglist,
1220         end_arglist>: New methods.
1221         <arglist_len, m_funcall_chain>: New members.
1222         (arglist_len, start_arglist, end_arglist): Don't declare.
1223         * parse.c (arglist_len, funcall_chain): Remove global.
1224         (start_arglist, end_arglist): Remove functions.
1225         (parse_exp_in_context): Update.
1226         * p-exp.y: Update rules.
1227         * m2-exp.y: Update rules.
1228         * go-exp.y: Update rules.
1229         * f-exp.y: Update rules.
1230         * d-exp.y: Update rules.
1231         * c-exp.y: Update rules.
1232
1233 2019-04-04  Tom Tromey  <tom@tromey.com>
1234
1235         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1236         lex_operator, push_back>: New methods.
1237         Update all rules.
1238         (rust_parser::lex_hex, lex_escape): Rename and update.
1239         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1240         (rust_parser::lex_operator): Rename and update.
1241         (rust_parser::lex_number, rustyylex, rustyyerror)
1242         (rust_lex_test_init, rust_lex_test_sequence)
1243         (rust_lex_test_push_back, rust_lex_tests): Update.
1244         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1245         parameter.
1246         <lexptr, prev_lexptr>: New members.
1247         (lexptr, prev_lexptr): Don't declare.
1248         * parse.c (lexptr, prev_lexptr): Remove globals.
1249         (parse_exp_in_context): Update.
1250         * p-exp.y (yylex, yyerror): Update.
1251         * m2-exp.y (parse_number, yylex, yyerror): Update.
1252         * go-exp.y (lex_one_token, yyerror): Update.
1253         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1254         * d-exp.y (lex_one_token, yyerror): Update.
1255         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1256         (lex_one_token, yyerror): Update.
1257         * ada-lex.l (YY_INPUT): Update.
1258         (rewind_to_char): Update.
1259         * ada-exp.y (yyerror): Update.
1260
1261 2019-04-04  Tom Tromey  <tom@tromey.com>
1262
1263         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1264         * parser-defs.h (struct parser_state) <parser_state>: Add new
1265         parameter.
1266         <comma_terminates>: New member.
1267         (comma_terminates): Don't declare global.
1268         * parse.c (comma_terminates): Remove global.
1269         (parse_exp_in_context): Update.
1270         * p-exp.y (yylex): Update.
1271         * m2-exp.y (yylex): Update.
1272         * go-exp.y (lex_one_token): Update.
1273         * f-exp.y (yylex): Update.
1274         * d-exp.y (lex_one_token): Update.
1275         * c-exp.y (lex_one_token): Update.
1276         * ada-lex.l: Update.
1277
1278 2019-04-04  Tom Tromey  <tom@tromey.com>
1279
1280         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1281         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1282         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1283         * parser-defs.h (paren_depth): Don't declare.
1284         * parse.c (paren_depth): Remove global.
1285         (parse_exp_in_context): Update.
1286         * p-exp.y (paren_depth): New global.
1287         (pascal_parse): Initialize it.
1288         * m2-exp.y (paren_depth): New global.
1289         (m2_parse): Initialize it.
1290         * go-exp.y (paren_depth): New global.
1291         (go_parse): Initialize it.
1292         * f-exp.y (paren_depth): New global.
1293         (f_parse): Initialize it.
1294         * d-exp.y (paren_depth): New global.
1295         (d_parse): Initialize it.
1296         * c-exp.y (paren_depth): New global.
1297         (c_parse): Initialize it.
1298         * ada-lex.l (paren_depth): New global.
1299         (lexer_init): Initialize it.
1300
1301 2019-04-04  Tom Tromey  <tom@tromey.com>
1302
1303         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1304         (rust_parser::convert_ast_to_type)
1305         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1306         * parser-defs.h (struct parser_state) <parser_state>: Add
1307         parameters.  Initialize new members.
1308         <expression_context_block, expression_context_pc>: New members.
1309         * parse.c (expression_context_block, expression_context_pc):
1310         Remove globals.
1311         (parse_exp_in_context): Update.
1312         * p-exp.y: Update all rules.
1313         (yylex): Update.
1314         * m2-exp.y: Update all rules.
1315         (yylex): Update.
1316         * go-exp.y (yylex): Update.
1317         * f-exp.y (yylex): Update.
1318         * d-exp.y: Update all rules.
1319         (yylex): Update.
1320         * c-exp.y: Update all rules.
1321         (lex_one_token, classify_name, yylex, c_parse): Update.
1322         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1323
1324 2019-04-04  Tom Tromey  <tom@tromey.com>
1325
1326         * gdbarch.h, gdbarch.c: Rebuild.
1327         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1328         * stap-probe.h:
1329         (struct stap_parse_info): Replace "parser_state" with
1330         "expr_builder".
1331         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1332         (parser_state): New class.
1333         * parse.c (expr_builder): Rename.
1334         (expr_builder::release): Rename.
1335         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1336         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1337         (write_exp_elt_longcst, write_exp_elt_floatcst)
1338         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1339         (write_exp_string_vector, write_exp_bitstring)
1340         (write_exp_msymbol, mark_struct_expression)
1341         (write_dollar_variable)
1342         (insert_type_address_space, increase_expout_size): Replace
1343         "parser_state" with "expr_builder".
1344         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1345         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1346         "parser_state" with "expr_builder".
1347
1348 2019-04-04  Tom Tromey  <tom@tromey.com>
1349
1350         * rust-exp.y: Replace "parse_language" with method call.
1351         * p-exp.y:
1352         (yylex): Replace "parse_language" with method call.
1353         * m2-exp.y:
1354         (yylex): Replace "parse_language" with method call.
1355         * go-exp.y (classify_name): Replace "parse_language" with method
1356         call.
1357         * f-exp.y (yylex): Replace "parse_language" with method call.
1358         * d-exp.y (lex_one_token): Replace "parse_language" with method
1359         call.
1360         * c-exp.y:
1361         (lex_one_token, classify_name, yylex): Replace "parse_language"
1362         with method call.
1363         * ada-exp.y (find_primitive_type, type_char)
1364         (type_system_address): Replace "parse_language" with method call.
1365
1366 2019-04-04  Tom Tromey  <tom@tromey.com>
1367
1368         * rust-exp.y: Replace "parse_gdbarch" with method call.
1369         * parse.c (write_dollar_variable, insert_type_address_space):
1370         Replace "parse_gdbarch" with method call.
1371         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1372         call.
1373         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1374         call.
1375         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1376         "parse_gdbarch" with method call.
1377         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1378         with method call.
1379         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1380         "parse_gdbarch" with method call.
1381         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1382         "parse_gdbarch" with method call.
1383         * c-exp.y (parse_type, parse_number, classify_name): Replace
1384         "parse_gdbarch" with method call.
1385         * ada-lex.l: Replace "parse_gdbarch" with method call.
1386         * ada-exp.y (parse_type, find_primitive_type, type_char)
1387         (type_system_address): Replace "parse_gdbarch" with method call.
1388
1389 2019-04-04  Tom Tromey  <tom@tromey.com>
1390
1391         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1392         * stap-probe.c (stap_parse_argument): Update.
1393         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1394         initial_size parameter.
1395         * rust-exp.y (rust_lex_tests): Update.
1396         * parse.c (parser_state): Update.
1397         (parse_exp_in_context): Update.
1398         * parser-defs.h (struct parser_state) <parser_state>: Remove
1399         "initial_size" parameter.
1400
1401 2019-04-04  Tom Tromey  <tom@tromey.com>
1402
1403         * parser-defs.h (increase_expout_size): Don't declare.
1404         * parse.c (increase_expout_size): Now static.
1405
1406 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1407
1408         * gnu-nat.c (gnu_nat_target::wait): Fix
1409         target_waitstatus_to_string call.
1410
1411 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1412
1413         * eval.c (evaluate_subexp_standard): Handle internal functions
1414         during Fortran function call handling.
1415
1416 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1417
1418         * NEWS: Mention new internal functions.
1419         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1420         (read_base_type): Use dwarf2_init_complex_target_type.
1421         * value.c (creal_internal_fn): New function.
1422         (cimag_internal_fn): New function.
1423         (_initialize_values): Register new internal functions.
1424
1425 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1426
1427         * infrun.c (stop_all_threads): If debug_infrun, always
1428         trace the wait status after wait_one, using
1429         target_waitstatus_to_string and target_pid_to_str.
1430         (handle_inferior_event): Replace various trace of
1431         wait status kind by a single trace.
1432         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1433         wait status kind image by target_waitstatus_to_string.
1434         * target/waitstatus.c (target_waitstatus_to_string): Fix
1435         obsolete comment.
1436
1437 2019-04-01  Tom Tromey  <tromey@adacore.com>
1438
1439         PR symtab/23331:
1440         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1441
1442 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1443             Pedro Alves  <palves@redhat.com>
1444
1445         * top.c (quit_force): Call 'finalize_values'.
1446         * value.c (finalize_values): New function.
1447         * value.h (finalize_values): Declare.
1448
1449 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1450
1451         * NEWS: Announce $_gdb_major and $_gdb_minor.
1452
1453         * top.c (init_gdb_version_vars): New function.
1454         (gdb_init): Call init_gdb_version_vars.
1455
1456 2019-03-29  Tom Tromey  <tromey@adacore.com>
1457
1458         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1459         help text.  Remove dead code.
1460
1461 2019-03-29  Keith Seitz  <keiths@redhat.com>
1462
1463         From Siddhesh Poyarekar:
1464         * f-lang.h (f77_get_upperbound): Return LONGEST.
1465         (f77_get_lowerbound): Likewise.
1466         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1467         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1468         print them.
1469         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1470         plongest to format print it.
1471         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1472         (f77_get_upperbound): Likewise.
1473         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1474         LOWER_BOUND to LONGEST.
1475         (f77_create_arrayprint_offset_tbl): Likewise.
1476
1477 2019-03-29  Keith Seitz  <keiths@redhat.com>
1478
1479         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1480         %s/pulongest for TYPE_LENGTH instead of %d in format
1481         strings.
1482         * ada-typerint.c (ada_print_type): Likewise.
1483         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1484         * compile/compile-c-support.c (generate_register_struct): Likewise.
1485         * gdbtypes.c (recursive_dump_type): Likewise.
1486         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1487         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1488         instead of %d in format strings.
1489         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1490         to std::min to ULONGEST.
1491         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1492         instead of %d in format strings.
1493         * tracepoint.c (info_scope_command): Likewise.
1494         * typeprint.c (print_offset_data::update)
1495         (print_offset_data::finish): Likewise.
1496         * xtensa-tdep.c (xtensa_store_return_value)
1497         (xtensa_push_dummy_call): Likewise.
1498
1499 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1500
1501         * windows-nat.c (display_selector): Fixed format specifications
1502         for 64-bit Cygwin.
1503
1504 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1505
1506         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1507
1508 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1509
1510         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1511         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1512         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1513         (nios2_linux_init_abi): Install it.
1514
1515 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1516
1517         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1518
1519 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1520
1521         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1522
1523 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1524             Tom Tromey  <tromey@adacore.com>
1525
1526         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1527
1528 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1529
1530         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1531         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1532         method to compute the bounds of range types. Also print "[evaluated]"
1533         if the bounds' values come from a dynamic evaluation.
1534
1535 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1536
1537         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1538         whitespace when pretty printing is on.
1539
1540 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1541
1542         * ppc-linux-nat.c: Add include.
1543
1544 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1545
1546         * NEWS: Mention AArch64 Pointer Authentication.
1547
1548 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1549
1550         * arm-linux-nat.c: Add include.
1551
1552 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1553
1554         * source-cache.c (source_cache::get_source_lines): Re-read
1555         fullname after calling open_source_file.
1556
1557 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1558
1559         * NEWS: Mention TLS support for FreeBSD.
1560
1561 2019-03-25  Tom Tromey  <tromey@adacore.com>
1562
1563         * minsyms.c (BUNCH_SIZE): Update comment.
1564         (~minimal_symbol_reader): Remove old comment.
1565         (compact_minimal_symbols): Update comment.
1566         (minimal_symbol_reader::install): Remove old comment.  Update
1567         other comments.
1568
1569 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1570
1571         * s390-linux-nat.c: Add include.
1572
1573 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1574
1575         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1576         Call linux_get_hwcap.
1577         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1578         Likewise.
1579         (aarch64_linux_get_hwcap): Remove function.
1580         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1581         declaration.
1582         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1583         linux_get_hwcap.
1584         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1585         * linux-tdep.c (linux_get_hwcap): Add function.
1586         (linux_get_hwcap2): Likewise.
1587         * linux-tdep.h (linux_get_hwcap): Add declaration.
1588         (linux_get_hwcap2): Likewise.
1589         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1590         (ppc_linux_get_hwcap2): Likewise.
1591         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1592         linux_get_hwcap.
1593         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1594         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1595         (ppc_linux_nat_target::read_description): Likewise.
1596         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1597         * s390-linux-nat.c: Likewise.
1598         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1599
1600 2019-03-24  Tom Tromey  <tom@tromey.com>
1601
1602         * ada-lang.c (standard_lookup): Simplify initialization.
1603         (ada_lookup_symbol_nonlocal): Simplify return.
1604         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1605         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1606         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1607         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1608         initialization.
1609         * solib.c (solib_global_lookup): Simplify.
1610         * symtab.c (null_block_symbol): Remove.
1611         (symbol_cache_lookup): Simplify returns.
1612         (lookup_language_this): Simplify returns.
1613         (lookup_symbol_aux): Simplify return.
1614         (lookup_local_symbol): Simplify returns.
1615         (lookup_global_symbol_from_objfile): Simplify return.
1616         (lookup_symbol_in_objfile_symtabs)
1617         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1618         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1619         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1620         * cp-namespace.c (cp_lookup_bare_symbol)
1621         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1622         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1623         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1624         (cp_lookup_symbol_via_imports): Simplify initialization.
1625         (find_symbol_in_baseclass): Likewise.
1626         * symtab.h (null_block_symbol): Remove.
1627         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1628         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1629         (d_lookup_symbol_module): Likewise.
1630         (find_symbol_in_baseclass): Simplify initialization.
1631
1632 2019-03-24  Tom Tromey  <tom@tromey.com>
1633
1634         * expression.h: Don't include symtab.h.
1635         (struct block): Forward declare.
1636
1637 2019-03-24  Tom Tromey  <tom@tromey.com>
1638
1639         * c-exp.y (typebase): Remove casts.
1640         * gdbtypes.c (lookup_unsigned_typename, )
1641         (lookup_signed_typename): Remove cast.
1642         * eval.c (parse_to_comma_and_eval): Remove cast.
1643         * parse.c (write_dollar_variable): Remove cast.
1644         * block.h (struct block) <superblock>: Now const.
1645         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1646         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1647         (map_block): Make "block" const.
1648         * symfile.h (struct quick_symbol_functions)
1649         <map_matching_symbols>: Constify block argument to "callback".
1650         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1651         const.
1652         (find_pc_sect_compunit_symtab): Make "b" const.
1653         (find_symbol_at_address): Likewise.
1654         (search_symbols): Likewise.
1655         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1656         (dw2_debug_names_lookup_symbol): Likewise.
1657         (dw2_map_matching_symbols): Update.
1658         * p-valprint.c (pascal_val_print): Remove "block".
1659         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1660         (aux_add_nonlocal_symbols): Make "block" const.
1661         (resolve_subexp): Remove cast.
1662         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1663         const.
1664         (iterate_over_file_blocks): Likewise.
1665         * f-exp.y (%union) <bval>: Remove.
1666         * coffread.c (patch_opaque_types): Make "b" const.
1667         * spu-tdep.c (spu_catch_start): Make "block" const.
1668         * c-valprint.c (print_unpacked_pointer): Remove "block".
1669         * symmisc.c (dump_symtab_1): Make "b" const.
1670         (block_depth): Make "block" const.
1671         * d-exp.y (%union) <bval>: Remove.
1672         * cp-support.h (cp_lookup_rtti_type): Update.
1673         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1674         * psymtab.c (psym_lookup_symbol): Make "block" const.
1675         (maintenance_check_psymtabs): Make "b" const.
1676         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1677         (enumerate_locals, enumerate_args): Update.
1678         * python/py-symtab.c (stpy_global_block): Make "block" const.
1679         (stpy_static_block): Likewise.
1680         * inline-frame.c (block_starting_point_at): Make "new_block"
1681         const.
1682         * block.c (find_block_in_blockvector): Make return type const.
1683         (blockvector_for_pc_sect): Make "b" const.
1684         (find_block_in_blockvector): Make "b" const.
1685
1686 2019-03-23  Tom Tromey  <tom@tromey.com>
1687
1688         * varobj.c (varobj_create): Update.
1689         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1690         * printcmd.c (display_command, do_one_display): Don't reset
1691         innermost_block.
1692         * parser-defs.h (enum innermost_block_tracker_type): Move to
1693         expression.h.
1694         (innermost_block): Update comment.
1695         * parse.c (parse_exp_1): Add tracker_types parameter.
1696         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1697         tracker_types parameter.  Reset innermost_block.
1698         (parse_exp_in_context): Remove.
1699         (parse_expression_for_completion): Update.
1700         * objfiles.c (~objfile): Don't reset expression_context_block or
1701         innermost_block.
1702         * expression.h (enum innermost_block_tracker_type): Move from
1703         parser-defs.h.
1704         (parse_exp_1): Add tracker_types parameter.
1705         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1706         reset innermost_block.
1707
1708 2019-03-23  Tom Tromey  <tom@tromey.com>
1709
1710         * objfiles.h: Include bcache.h.
1711
1712 2019-03-23  Tom Tromey  <tom@tromey.com>
1713
1714         * linespec.c (get_current_search_block): Use
1715         scoped_restore_current_language.
1716         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1717
1718 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1719             Jiong Wang  <jiong.wang@arm.com>
1720
1721         * aarch64-linux-tdep.c
1722         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1723         section.
1724         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1725
1726 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1727             Jiong Wang  <jiong.wang@arm.com>
1728
1729         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1730         instructions.
1731         (aarch64_analyze_prologue_test): Add PACIASP test.
1732         (aarch64_prologue_prev_register): Unmask PC value.
1733
1734 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1735             Jiong Wang  <jiong.wang@arm.com>
1736
1737         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1738         (aarch64_dwarf2_prev_register): Unmask PC value.
1739         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1740         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1741         DW_CFA_AARCH64_negate_ra_state.
1742         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1743
1744 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1745             Jiong Wang  <jiong.wang@arm.com>
1746
1747         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1748         registers.
1749         (aarch64_pseudo_register_name): Likewise.
1750         (aarch64_pseudo_register_type): Likewise.
1751         (aarch64_pseudo_register_reggroup_p): Likewise.
1752         (aarch64_gdbarch_init): Add pauth registers.
1753         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1754         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1755         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1756         (struct gdbarch_tdep): Add regnum for ra_state.
1757
1758 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1759             Jiong Wang  <jiong.wang@arm.com>
1760
1761         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1762
1763 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1764             Jiong Wang  <jiong.wang@arm.com>
1765
1766         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1767         function.
1768         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1769         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1770         (aarch64_gdbarch_init): Add puth registers.
1771         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1772         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1773         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1774
1775 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1776             Jiong Wang  <jiong.wang@arm.com>
1777
1778         * aarch64-linux-nat.c
1779         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1780         * aarch64-linux-tdep.c
1781         (aarch64_linux_core_read_description): Likewise.
1782         (aarch64_linux_get_hwcap): New function.
1783         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1784         (aarch64_linux_get_hwcap): New declaration.
1785
1786 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1787             Jiong Wang  <jiong.wang@arm.com>
1788
1789         * aarch64-linux-nat.c
1790         (aarch64_linux_nat_target::read_description): Add pauth param.
1791         * aarch64-linux-tdep.c
1792         (aarch64_linux_core_read_description): Likewise.
1793         * aarch64-tdep.c (struct target_desc): Add in pauth.
1794         (aarch64_read_description): Add pauth param.
1795         (aarch64_gdbarch_init): Likewise.
1796         * aarch64-tdep.h (aarch64_read_description): Likewise.
1797         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1798         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1799         * features/Makefile: Add new files.
1800         * features/aarch64-pauth.c: New file.
1801         * features/aarch64-pauth.xml: New file.
1802
1803 2019-03-20  Tom Tromey  <tromey@adacore.com>
1804
1805         * infrun.c (handle_inferior_event): Rename from
1806         handle_inferior_event_1.  Create a scoped_value_mark.
1807         (handle_inferior_event): Remove.
1808
1809 2019-03-19  Tom Tromey  <tromey@adacore.com>
1810
1811         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1812         * infrun.h (print_stop_event): Add "displays" parameter.
1813         * infrun.c (print_stop_event): Add "displays" parameter.
1814
1815 2019-03-19  Pedro Alves  <palves@redhat.com>
1816
1817         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1818         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1819         to -1.  Fix TABs vs spaces.
1820         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1821         * tui/tui-out.h (tui_ui_out) Add intro comments.
1822         <m_line, m_start_of_line>: In-class initialize, and add describing
1823         comment.
1824
1825 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1826
1827         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1828         variable names.
1829         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1830
1831 2019-03-18  Pedro Alves  <palves@redhat.com>
1832             Eli Zaretskii <eliz@gnu.org>
1833
1834         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1835         m_line and m_start_of_line.
1836
1837 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1838
1839         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1840         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1841         it returns a newline.  This fixes a regression in TU mode, whereby
1842         the next line is output on the same screen line as the user input.
1843
1844 2019-03-18  Tom Tromey  <tromey@adacore.com>
1845
1846         * minsyms.c (minimal_symbol_reader::install): Remove call to
1847         obstack_blank.
1848
1849 2019-03-18  Pedro Alves  <palves@redhat.com>
1850
1851         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1852         New globals.
1853         (apply_style): New, factored out from ...
1854         (apply_ansi_escape): ... this.  Handle reverse video mode.
1855         (tui_set_reverse_mode): New function.
1856         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1857         * tui/tui-winsource.c (tui_show_source_line): Use
1858         tui_set_reverse_mode instead of setting A_STANDOUT.
1859         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1860         New setter methods.
1861
1862 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1863
1864         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1865         Handle tabs.
1866
1867 2019-03-18  Tom Tromey  <tromey@adacore.com>
1868
1869         * ada-lang.c (empty_array): Add "high" parameter.
1870         (ada_evaluate_subexp): Update.
1871
1872 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1873
1874         * unittests/string_view-selftests.c: Define
1875         _initialize_string_view_selftests unconditionally.
1876
1877 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1878
1879         PR gdb/24350
1880         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1881
1882 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1883
1884         PR gdb/24351
1885         * windows-nat.c (display_selector): Fix format specifiers.
1886
1887 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1888
1889         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1890         tui_refill_source_window instead of tui_refresh_win, to update the
1891         current execution line.  This fixes redisplay of the current line
1892         when stepping through the code with "next" or "step".
1893
1894 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1895
1896         * source-cache.c (source_cache::get_source_lines): Call
1897         find_source_lines to initialize s->nlines.  This fixes vertical
1898         scrolling of TUI source window when the DOWN arrow is pressed.
1899
1900 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1901
1902         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1903         linux-thread-db.c (_initialize_thread_db): Likewise.
1904
1905 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1906
1907         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1908         wclrtoeol in tui_show_source_line".  This reverts changes made in
1909         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1910
1911 2019-03-15  Tom Tromey  <tom@tromey.com>
1912
1913         * symtab.h (struct minimal_symbol): Derive from
1914         general_symbol_info.
1915         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1916         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1917         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1918         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1919         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1920         (MSYMBOL_SEARCH_NAME): Update.
1921         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1922         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1923         * minsyms.c (minimal_symbol_reader::record_full): Update.
1924
1925 2019-03-15  Tom Tromey  <tom@tromey.com>
1926
1927         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1928
1929 2019-03-15  Tom Tromey  <tom@tromey.com>
1930
1931         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1932         unique_xmalloc_ptr.
1933         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1934         Update.
1935         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1936         (build_minimal_symbol_hash_tables)
1937         (minimal_symbol_reader::install): Update.
1938
1939 2019-03-15  Tom Tromey  <tom@tromey.com>
1940
1941         * symtab.c (create_demangled_names_hash): Update.
1942         (symbol_set_names): Update.
1943         * objfiles.h (struct objfile_per_bfd_storage)
1944         <demangled_names_hash>: Now an htab_up.
1945         * objfiles.c (objfile_per_bfd_storage): Simplify.
1946
1947 2019-03-15  Tom Tromey  <tom@tromey.com>
1948
1949         * objfiles.h (struct objfile_per_bfd_storage): Declare
1950         destructor.
1951         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1952         New.
1953         (get_objfile_bfd_data): Use new.  Don't initialize
1954         language_of_main.
1955         (free_objfile_per_bfd_storage): Remove.
1956         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1957
1958 2019-03-15  Tom Tromey  <tom@tromey.com>
1959
1960         * symfile.c (reread_symbols): Update.
1961         * objfiles.c (objfile::objfile): Update.
1962         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1963         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1964         comment.
1965         (minimal_symbol_reader::install): Update.
1966         (terminate_minimal_symbol_table): Remove.
1967         * jit.c (jit_object_close_impl): Update.
1968
1969 2019-03-15  Tom Tromey  <tom@tromey.com>
1970
1971         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1972         initializations.
1973
1974 2019-03-15  Tom Tromey  <tom@tromey.com>
1975
1976         * objfiles.h (struct objfile_per_bfd_storage)
1977         <demangled_hash_languages>: Now a bitset.
1978         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1979         (lookup_minimal_symbol): Update.
1980
1981 2019-03-15  Tom Tromey  <tom@tromey.com>
1982
1983         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1984         Don't return the symbol.
1985         * coffread.c (record_minimal_symbol): Use record_full.
1986
1987 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1988
1989         The MS-Windows port of ncurses fails to switch to a color pair if
1990         one or both of the colors are the implicit default colors.  This
1991         change records the default colors when TUI is initialized, and
1992         then specifies them explicitly when a color pair uses the default
1993         colors.  This allows color styling in TUI mode on MS-Windows.
1994
1995         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1996         ncurses_norm_attr.
1997         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1998         colors in ncurses_norm_attr.
1999         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2000         "none", replace it with the default color recorded in
2001         ncurses_norm_attr.
2002
2003 2019-03-14  Tom Tromey  <tromey@adacore.com>
2004
2005         * source-cache.h (class source_cache) <get_source_lines>: Return
2006         std::string.
2007         * source-cache.c (source_cache::extract_lines): Handle case where
2008         first_pos==npos.  Return std::string.
2009         (source_cache::get_source_lines): Update.
2010
2011 2019-03-14  Tom Tromey  <tromey@adacore.com>
2012
2013         * NEWS: Add item for "style sources" commands.
2014         * source-cache.c (source_cache::get_source_lines): Check
2015         source_styling.
2016         * cli/cli-style.c (source_styling): New global.
2017         (_initialize_cli_style): Add "style sources" commands.
2018         (show_style_sources): New function.
2019         * cli/cli-style.h (source_styling): Declare.
2020
2021 2019-03-14  Pedro Alves  <palves@redhat.com>
2022             Tom Tromey  <tromey@adacore.com>
2023
2024         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2025         * tui/tui-winsource.c (tui_refill_source_window): New function,
2026         from...
2027         (tui_horizontal_source_scroll): ... here.  Move some logic.
2028         * cli/cli-style.c (set_style_enabled): Notify new observable.
2029         * tui/tui-hooks.c (tui_redisplay_source): New function.
2030         (tui_attach_detach_observers): Attach or detach
2031         tui_redisplay_source.
2032         * observable.h (source_styling_changed): New observable.
2033         * observable.c: Define source_styling_changed observable.
2034
2035 2019-03-13  Tom Tromey  <tromey@adacore.com>
2036
2037         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2038         (i386_gnu_nat_target::store_registers): Update.
2039         * target-debug.h (target_debug_print_std_string): New macro.
2040         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2041         * windows-tdep.c (display_one_tib): Update.
2042         * tui/tui-stack.c (tui_make_status_line): Update.
2043         * top.c (print_inferior_quit_action): Update.
2044         * thread.c (thr_try_catch_cmd): Update.
2045         (add_thread_with_info): Update.
2046         (thread_target_id_str): Update.
2047         (thr_try_catch_cmd): Update.
2048         (thread_command): Update.
2049         (thread_find_command): Update.
2050         * record-btrace.c (record_btrace_target::info_record)
2051         (record_btrace_resume_thread, record_btrace_target::resume)
2052         (record_btrace_cancel_resume, record_btrace_step_thread)
2053         (record_btrace_target::wait, record_btrace_target::wait)
2054         (record_btrace_target::wait, record_btrace_target::stop): Update.
2055         * progspace.c (print_program_space): Update.
2056         * process-stratum-target.c
2057         (process_stratum_target::thread_address_space): Update.
2058         * linux-fork.c (linux_fork_mourn_inferior)
2059         (detach_checkpoint_command, info_checkpoints_command)
2060         (linux_fork_context): Update.
2061         (linux_fork_detach): Update.
2062         (class scoped_switch_fork_info): Update.
2063         (delete_checkpoint_command): Update.
2064         * infrun.c (follow_fork_inferior): Update.
2065         (follow_fork_inferior): Update.
2066         (proceed_after_vfork_done): Update.
2067         (handle_vfork_child_exec_or_exit): Update.
2068         (follow_exec): Update.
2069         (displaced_step_prepare_throw): Update.
2070         (displaced_step_restore): Update.
2071         (start_step_over): Update.
2072         (resume_1): Update.
2073         (clear_proceed_status_thread): Update.
2074         (proceed): Update.
2075         (print_target_wait_results): Update.
2076         (do_target_wait): Update.
2077         (context_switch): Update.
2078         (stop_all_threads): Update.
2079         (restart_threads): Update.
2080         (finish_step_over): Update.
2081         (handle_signal_stop): Update.
2082         (switch_back_to_stepped_thread): Update.
2083         (keep_going_pass_signal): Update.
2084         (print_exited_reason): Update.
2085         (normal_stop): Update.
2086         * inferior.c (inferior_pid_to_str): Change return type.
2087         (print_selected_inferior): Update.
2088         (add_inferior): Update.
2089         (detach_inferior): Update.
2090         * dummy-frame.c (fprint_dummy_frames): Update.
2091         * dcache.c (dcache_info_1): Update.
2092         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2093         (btrace_fetch, btrace_clear): Update.
2094         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2095         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2096         type.
2097         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2098         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2099         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2100         * gdbarch.c, gdbarch.h: Rebuild.
2101         * gdbarch.sh (core_pid_to_str): Change return type.
2102         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2103         return type.
2104         (windows_nat_target::pid_to_str): Change return type.
2105         (windows_delete_thread): Update.
2106         (windows_nat_target::attach): Update.
2107         (windows_nat_target::files_info): Update.
2108         * target-delegates.c: Rebuild.
2109         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2110         return type.
2111         (sol_thread_target::pid_to_str): Change return type.
2112         * remote.c (class remote_target) <pid_to_str>: Change return
2113         type.
2114         (remote_target::pid_to_str): Change return type.
2115         (extended_remote_target::attach, remote_target::remote_stop_ns)
2116         (remote_target::remote_notif_remove_queued_reply)
2117         (remote_target::push_stop_reply, remote_target::disable_btrace):
2118         Update.
2119         (extended_remote_target::attach): Update.
2120         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2121         type.
2122         (gdbsim_target::pid_to_str): Change return type.
2123         * ravenscar-thread.c (struct ravenscar_thread_target)
2124         <pid_to_str>: Change return type.
2125         (ravenscar_thread_target::pid_to_str): Change return type.
2126         * procfs.c (class procfs_target) <pid_to_str>: Change return
2127         type.
2128         (procfs_target::pid_to_str): Change return type.
2129         (procfs_target::attach): Update.
2130         (procfs_target::detach): Update.
2131         (procfs_target::fetch_registers): Update.
2132         (procfs_target::store_registers): Update.
2133         (procfs_target::wait): Update.
2134         (procfs_target::files_info): Update.
2135         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2136         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2137         return type.
2138         (nto_procfs_target::pid_to_str): Change return type.
2139         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2140         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2141         return type.
2142         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2143         (exit_lwp): Update.
2144         (attach_proc_task_lwp_callback, get_detach_signal)
2145         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2146         (linux_nat_target::resume, wait_lwp, stop_callback)
2147         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2148         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2149         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2150         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2151         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2152         type.
2153         (inf_ptrace_target::attach): Update.
2154         (inf_ptrace_target::files_info): Update.
2155         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2156         type.
2157         (go32_nat_target::pid_to_str): Change return type.
2158         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2159         (gnu_nat_target::wait): Update.
2160         (gnu_nat_target::wait): Update.
2161         (gnu_nat_target::resume): Update.
2162         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2163         (fbsd_nat_target::wait): Update.
2164         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2165         type.
2166         (darwin_nat_target::attach): Update.
2167         * corelow.c (class core_target) <pid_to_str>: Change return type.
2168         (core_target::pid_to_str): Change return type.
2169         * target.c (normal_pid_to_str): Change return type.
2170         (default_pid_to_str): Likewise.
2171         (target_pid_to_str): Change return type.
2172         (target_translate_tls_address): Update.
2173         (target_announce_detach): Update.
2174         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2175         return type.
2176         (bsd_uthread_target::pid_to_str): Change return type.
2177         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2178         type.
2179         (bsd_kvm_target::pid_to_str): Change return type.
2180         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2181         return type.
2182         (aix_thread_target::pid_to_str): Change return type.
2183         * target.h (struct target_ops) <pid_to_str>: Change return type.
2184         (target_pid_to_str, normal_pid_to_str): Likewise.
2185         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2186         type.
2187         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2188         type.
2189         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2190         return type.
2191         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2192         type.
2193         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2194         type.
2195         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2196         return type.
2197
2198 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2199
2200         * NEWS: Mention that the new default MI version is 3.  Mention
2201         changes to the output of commands and events that deal with
2202         multi-location breakpoints.
2203         * breakpoint.c: Include "mi/mi-out.h".
2204         (print_one_breakpoint): Change output syntax if using MI version
2205         >= 3.
2206         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2207         New.
2208         (mi_multi_location_breakpoint_output_fixed): New.
2209         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2210         (mi_cmd_fix_multi_location_breakpoint_output): New.
2211         (mi_multi_location_breakpoint_output_fixed): New.
2212         * mi/mi-cmds.c (mi_cmds): Register command
2213         -fix-multi-location-breakpoint-output.
2214         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2215         interpreter "mi".
2216
2217 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2218
2219         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2220         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2221         instantiate mi_ui_out based on interpreter name.
2222         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2223         * mi/mi-main.c (mi_load_progress): Likewise.
2224
2225 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2226
2227         * NEWS: Combine separate "New targets" sections for 8.3.
2228
2229 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2230
2231         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2232         (ppcfbsd_init_abi): Install gdbarch
2233         "fetch_tls_load_module_address" and "get_thread_local_address"
2234         methods.
2235
2236 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2237
2238         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2239         (riscv_fbsd_init_abi): Install gdbarch
2240         "fetch_tls_load_module_address" and "get_thread_local_address"
2241         methods.
2242
2243 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2244
2245         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2246         (i386fbsd_init_abi): Install gdbarch
2247         "fetch_tls_load_module_address" and "get_thread_local_address"
2248         methods.
2249
2250 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2251
2252         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2253         (amd64fbsd_init_abi): Install gdbarch
2254         "fetch_tls_load_module_address" and "get_thread_local_address"
2255         methods.
2256
2257 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2258
2259         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2260         (struct fbsd_pspace_data): New type.
2261         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2262         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2263         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2264         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2265         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2266
2267 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2268
2269         * gdbtypes.c (lookup_struct_elt): New function.
2270         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2271         * gdbtypes.h (struct struct_elt): New type.
2272         (lookup_struct_elt): New prototype.
2273
2274 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2275
2276         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2277         remove disabled code block.
2278
2279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2280
2281         * gdbarch.sh (get_thread_local_address): New method.
2282         * gdbarch.h, gdbarch.c: Regenerate.
2283         * target.c (target_translate_tls_address): Use
2284         gdbarch_get_thread_local_address if present instead of
2285         target::get_thread_local_address.
2286
2287 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2288
2289         * target.h (target::get_thread_local_address): Update comment.
2290
2291 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2292
2293         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2294         objfile->separate_debug_objfile_backlink if not NULL.
2295
2296 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2297
2298         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2299         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2300         (amd64bsd_store_inferior_registers): Likewise.
2301         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2302         Enable segment base registers.
2303         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2304         PT_GETFSBASE and PT_GETGSBASE.
2305         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2306         PT_SETGSBASE.
2307         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2308         segment base registers.
2309         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2310
2311 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2312
2313         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2314         Update calls to i386_target_description to add 'segments'
2315         parameter.
2316         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2317         add segment base registers.
2318         * arch/i386.c (i386_create_target_description): Add 'segments'
2319         parameter to enable segment base registers.
2320         * arch/i386.h (i386_create_target_description): Likewise.
2321         * features/i386/32bit-segments.xml: New file.
2322         * features/i386/32bit-segments.c: Generate.
2323         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2324         call to i386_target_description to add 'segments' parameter.
2325         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2326         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2327         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2328         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2329         if feature is present.
2330         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2331         Add 'segments' parameter to call to i386_target_description.
2332         (i386_target_description): Add 'segments' parameter to enable
2333         segment base registers.
2334         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2335         to call to i386_target_description.
2336         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2337         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2338         Define I386_NUM_REGS.
2339         (i386_target_description): Add 'segments' parameter to enable
2340         segment base registers.
2341
2342 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2343
2344         PR/24325
2345         * source-cache.c: #undef open and close, to avoid unresolved
2346         externals during linking.
2347
2348 2019-03-12  Tom Tromey  <tromey@adacore.com>
2349
2350         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2351         const.  Add initializers.
2352         (_initialize_remote): Don't initialize ptid globals.
2353
2354 2019-03-12  Pedro Alves  <palves@redhat.com>
2355
2356         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2357
2358 2019-03-12  Pedro Alves  <palves@redhat.com>
2359
2360         * cp-name-parser.y (main): Remove unused 'len' variable.
2361
2362 2019-03-12  Tom Tromey  <tromey@adacore.com>
2363
2364         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2365         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2366
2367 2019-03-12  Tom Tromey  <tromey@adacore.com>
2368
2369         * linux-nat.c (iterate_over_lwps): Update.
2370         (stop_callback): Remove parameter.
2371         (stop_wait_callback, detach_callback, resume_set_callback)
2372         (select_singlestep_lwp_callback, set_ignore_sigint)
2373         (status_callback, resumed_callback, resume_clear_callback)
2374         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2375         data parameter.
2376         (linux_nat_target::detach, linux_nat_target::resume)
2377         (linux_stop_and_wait_all_lwps, select_event_lwp)
2378         (linux_nat_filter_event, linux_nat_wait_1)
2379         (linux_nat_target::kill, linux_nat_target::stop)
2380         (linux_nat_target::stop): Update.
2381         (linux_nat_resume_callback): Change type.
2382         (resume_stopped_resumed_lwps, count_events_callback)
2383         (select_event_lwp_callback): Likewise.
2384         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2385         * arm-linux-nat.c (struct update_registers_data): Remove.
2386         (update_registers_callback): Change type.
2387         (arm_linux_insert_hw_breakpoint1): Update.
2388         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2389         parameter.
2390         (x86_linux_dr_set_addr): Update.
2391         (x86_linux_dr_set_control): Update.
2392         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2393         (iterate_over_lwps): Use gdb::function_view.
2394         * nat/aarch64-linux-hw-point.c (struct
2395         aarch64_dr_update_callback_param): Remove.
2396         (debug_reg_change_callback): Change type.
2397         (aarch64_notify_debug_reg_change): Update.
2398         * s390-linux-nat.c (s390_refresh_per_info): Update.
2399
2400 2019-03-11  Tom Tromey  <tromey@adacore.com>
2401
2402         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2403         redundant assignment to "this_cu".
2404
2405 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2406
2407         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2408
2409 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2410
2411         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2412         from...
2413         (rank_one_type): ... this.
2414
2415 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2416
2417         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2418         from...
2419         (rank_one_type): ... this.
2420
2421 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2422
2423         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2424         from...
2425         (rank_one_type): ... this.
2426
2427 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2428
2429         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2430         from...
2431         (rank_one_type): ... this.
2432
2433 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2434
2435         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2436         from...
2437         (rank_one_type): ... this.
2438
2439 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2440
2441         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2442         from...
2443         (rank_one_type): ... this.
2444
2445 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2446
2447         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2448         from...
2449         (rank_one_type): ... this.
2450
2451 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2452
2453         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2454         from...
2455         (rank_one_type): ... this.
2456
2457 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2458
2459         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2460         from...
2461         (rank_one_type): ... this.
2462
2463 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2464
2465         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2466         from...
2467         (rank_one_type): ... this.
2468
2469 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2470
2471         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2472         from...
2473         (rank_one_type): ... this.
2474
2475 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2476
2477         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2478         from...
2479         (rank_one_type): ... this.
2480
2481 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2482
2483         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2484         inferior-events' shows the example events.
2485
2486 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2487
2488         Support styling on native MS-Windows console
2489
2490         PR/24315
2491         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2492         on MS-Windows if $TERM is not defined.
2493
2494         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2495
2496         * posix-hdep.c (gdb_console_fputs):
2497         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2498         functions.
2499         * ui-file.h (gdb_console_fputs): Add prototype.
2500
2501         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2502         back to fputs only if the former returns zero.
2503
2504 2019-03-07  Tom Tromey  <tom@tromey.com>
2505
2506         * symmisc.c (print_symbol_bcache_statistics): Update.
2507         (print_objfile_statistics): Update.
2508         * symfile.c (allocate_symtab): Update.
2509         * stabsread.c: Don't include bcache.h.
2510         * psymtab.h (struct psymbol_bcache): Don't declare.
2511         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2512         (psymbol_bcache_init, psymbol_bcache_free)
2513         (psymbol_bcache_get_bcache): Don't declare.
2514         * psymtab.c (struct psymbol_bcache): Remove.
2515         (psymtab_storage::psymtab_storage): Update.
2516         (psymtab_storage::~psymtab_storage): Update.
2517         (psymbol_bcache_init, psymbol_bcache_free)
2518         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2519         (add_psymbol_to_bcache): Update.
2520         (allocate_psymtab): Update.
2521         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2522         macro_cache>: No longer pointers.
2523         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2524         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2525         * macrotab.c (macro_bcache): Update.
2526         * macroexp.c: Don't include bcache.h.
2527         * gdbtypes.c (check_types_worklist): Update.
2528         (types_deeply_equal): Remove TRY/CATCH.  Update.
2529         * elfread.c (elf_symtab_read): Update.
2530         * dwarf2read.c: Don't include bcache.h.
2531         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2532         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2533         (print_bcache_statistics, bcache_memory_used): Don't declare.
2534         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2535         methods.  Rename all data members.
2536         * bcache.c (struct bcache): Move to bcache.h.
2537         (bcache::expand_hash_table): Rename from expand_hash_table.
2538         (bcache): Remove.
2539         (bcache::insert): Rename from bcache_full.
2540         (bcache::compare): Rename from bcache_compare.
2541         (bcache_xmalloc): Remove.
2542         (bcache::~bcache): Rename from bcache_xfree.
2543         (bcache::print_statistics): Rename from print_bcache_statistics.
2544         (bcache::memory_used): Rename from bcache_memory_used.
2545
2546 2019-03-07  Pedro Alves  <palves@redhat.com>
2547
2548         * infrun.c (normal_stop): Also check for
2549         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2550
2551 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2552
2553         * f-lang.c (value_from_host_double): Moved to...
2554         * value.c (value_from_host_double): ...here.
2555         * value.h (value_from_host_double): Declare.
2556         * guile/scm-math.c (vlscm_convert_typed_number): Use
2557         value_from_host_double.
2558         (vlscm_convert_number): Likewise.
2559         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2560         * python/py-value.c (convert_value_from_python): Likewise.
2561
2562 2019-03-06  Tom Tromey  <tom@tromey.com>
2563
2564         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2565
2566 2019-03-06  Tom Tromey  <tom@tromey.com>
2567
2568         * utils.h (free_current_contents): Don't declare.
2569         * utils.c (free_current_contents): Remove.
2570
2571 2019-03-06  Tom Tromey  <tom@tromey.com>
2572
2573         * top.c (quit_force): Update.
2574         * main.c (captured_command_loop): Update.
2575         * common/new-op.c (operator new): Update.
2576         * common/common-exceptions.c (struct catcher)
2577         <save_cleanup_chain>: Remove member.
2578         (exceptions_state_mc_init): Update.
2579         (exception_try_scope_entry): Return nullptr.
2580         (exception_try_scope_exit, exception_rethrow)
2581         (throw_exception_sjlj, throw_exception_cxx): Update.
2582         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2583         (all_cleanups, do_cleanups, discard_cleanups)
2584         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2585         (restore_cleanups, restore_final_cleanups): Don't declare.
2586         (do_final_cleanups): Remove parameter.
2587         * common/cleanups.c (cleanup_chain, make_cleanup)
2588         (make_cleanup_dtor, all_cleanups, do_cleanups)
2589         (discard_my_cleanups, discard_cleanups)
2590         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2591         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2592         (null_cleanup): Remove.
2593         (do_final_cleanups): Remove parameter.
2594
2595 2019-03-06  Tom Tromey  <tom@tromey.com>
2596
2597         * remote.c (remote_target::remote_parse_stop_reply): Use
2598         unique_xmalloc_ptr.
2599
2600 2019-03-06  Tom Tromey  <tom@tromey.com>
2601
2602         * stabsread.c (struct stabs_field_info): Rename from field_info.
2603         <list, fnlist>: Add initializers.
2604         <obstack>: New member.
2605         (read_member_functions, read_struct_fields, read_baseclasses):
2606         Allocate on obstack.  Don't use cleanups.
2607         (read_one_struct_field, read_member_functions, read_struct_fields)
2608         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2609         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2610         (read_struct_type): Update.
2611
2612 2019-03-06  Tom Tromey  <tom@tromey.com>
2613
2614         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2615         * common/filestuff.h (make_cleanup_close): Don't declare.
2616         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2617         Remove.
2618
2619 2019-03-06  Tom Tromey  <tom@tromey.com>
2620
2621         * solib-aix.c: Use make_scope_exit.
2622
2623 2019-03-06  Tom Tromey  <tom@tromey.com>
2624
2625         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2626         Use make_scope_exit.
2627
2628 2019-03-06  Tom Tromey  <tom@tromey.com>
2629
2630         * solib-svr4.c (disable_probes_interface): Remove parameter.
2631         (svr4_handle_solib_event): Use make_scope_exit.
2632
2633 2019-03-06  Tom Tromey  <tom@tromey.com>
2634
2635         * remote.c (struct stop_reply_deleter): Remove.
2636         (stop_reply_up): Update.
2637         (struct stop_reply): Derive from notif_event.  Don't typedef.
2638         <regcache>: Now a std::vector.
2639         (stop_reply_xfree): Remove.
2640         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2641         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2642         (remote_target::discard_pending_stop_replies): Use delete.
2643         (remote_target::remote_parse_stop_reply): Update.
2644         (remote_target::process_stop_reply): Update.
2645         * remote-notif.h (struct notif_event): Add virtual destructor.
2646         Remove "dtr" member.
2647         (struct notif_client) <alloc_event>: Return a unique_ptr.
2648         (notif_event_xfree): Don't declare.
2649         (notif_event_up): New typedef.
2650         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2651         (notif_event_xfree, do_notif_event_xfree): Remove.
2652         (remote_notif_state_xfree): Update.
2653
2654 2019-03-06  Tom Tromey  <tom@tromey.com>
2655
2656         * infrun.c (displaced_step_clear_cleanup): Now a
2657         forward_scope_exit type.
2658         (displaced_step_prepare_throw): Update.
2659         (displaced_step_fixup): Update.
2660
2661 2019-03-06  Tom Tromey  <tom@tromey.com>
2662
2663         * inferior.h (class inferior): Update comment.
2664         * gdbthread.h (class thread_info): Update comment.
2665
2666 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2667             Tom Tromey  <tom@tromey.com>
2668
2669         * stabsread.h (struct stab_section_list): Remove.
2670         (coffstab_build_psymtabs): Update.
2671         * dbxread.c (symbuf_sections): Now a std::vector.
2672         (sect_idx): New global.
2673         (fill_symbuf): Update.
2674         (coffstab_build_psymtabs): Change type of stabsects parameter.
2675         Update.
2676         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2677         std::vector.
2678         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2679         (coff_locate_sections): Update.
2680         (coff_symfile_read): Remove cleanups.  Update.
2681         (init_stringtab): Add storage parameter.
2682         (free_stringtab, free_stringtab_cleanup): Remove.
2683         (init_lineno): Add storage parameter.
2684         (free_linetab, free_linetab_cleanup): Remove.
2685
2686 2019-03-06  Pedro Alves  <palves@redhat.com>
2687
2688         * linux-fork.c (fork_info::clobber_regs): Delete.
2689         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2690         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2691         comment.  Adjust.
2692         (scoped_switch_fork_info::scoped_switch_fork_info)
2693         (checkpoint_command, linux_fork_context): Adjust
2694         fork_save_infrun_state calls.
2695
2696 2019-03-06  Pedro Alves  <palves@redhat.com>
2697
2698         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2699         (inf_has_multiple_threads): Return 'bool' and rewrite using
2700         inferior_info::threads().
2701
2702 2019-03-06  Pedro Alves  <palves@redhat.com>
2703
2704         * linux-fork.c: Include <list>.
2705         (fork_list): Now a std::list instance.
2706         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2707         (forks_exist_p, find_last_fork): Adjust.
2708         (new_fork): Delete.
2709         (one_fork_p): New.
2710         (add_fork): Adjust.
2711         (free_fork): Delete, folded into fork_info::~fork_info().
2712         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2713         Adjust.
2714         (init_fork_list): Delete.
2715         (linux_fork_killall, linux_fork_mourn_inferior)
2716         (linux_fork_detach, info_checkpoints_command): Adjust.
2717         (_initialize_linux_fork): No longer call init_fork_list.
2718
2719 2019-03-06  Pedro Alves  <palves@redhat.com>
2720
2721         * linux-fork.c (new_fork): New, split out of ...
2722         (add_fork): ... this.  Return void.  Move "first fork" special
2723         case from here, to ...
2724         (checkpoint_command): ... here.
2725         * linux-linux.h (add_fork): Return void.
2726
2727 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2728
2729         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2730
2731 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2732             Chris January  <chris.january@arm.com>
2733             David Lecomber  <david.lecomber@arm.com>
2734
2735         * f-exp.y: New token, UNOP_INTRINSIC.
2736         (exp): New pattern using UNOP_INTRINSIC token.
2737         (f77_keywords): Add 'abs' keyword.
2738         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2739         (value_from_host_double): New function.
2740         (evaluate_subexp_f): Support UNOP_ABS.
2741
2742 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2743
2744         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2745         types.
2746
2747 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2748
2749         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2750         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2751         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2752
2753 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2754
2755         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2756
2757 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2758             Chris January  <chris.january@arm.com>
2759
2760         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2761         * f-exp.y: Define 'KIND' token.
2762         (exp): New pattern for KIND expressions.
2763         (ptype): Handle types with a kind extension.
2764         (direct_abs_decl): Extend to spot kind extensions.
2765         (f77_keywords): Add 'kind' to the list.
2766         (push_kind_type): New function.
2767         (convert_to_kind_type): New function.
2768         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2769         * parse.c (operator_length_standard): Likewise.
2770         * parser-defs.h (enum type_pieces): Add tp_kind.
2771         * std-operator.def: Add UNOP_KIND.
2772
2773 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2774
2775         * f-exp.y (f_parse): Set yydebug.
2776
2777 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2778
2779         * f-lang.c (evaluate_subexp_f): New function.
2780         (exp_descriptor_f): New global.
2781         (f_language_defn): Use exp_descriptor_f instead of
2782         exp_descriptor_standard.
2783
2784 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2785
2786         * f-exp.y (struct token): Add comments.
2787         (dot_ops): Remove uppercase versions and the end marker.
2788         (f77_keywords): Likewise.
2789         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2790         entries in the dot_ops array are case insensitive, and use
2791         strncasecmp to compare strings.  Also some whitespace cleanup in
2792         this area.  Similar for the f77_keywords array, except entries in
2793         this list might be case sensitive.
2794
2795 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2796
2797         * f-exp.y (struct f77_boolean_val): Add comments.
2798         (boolean_values): Remove uppercase versions, and end marker.
2799         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2800         and use strncasecmp to achieve case insensitivity.  Additionally,
2801         perform whitespace cleanup around this code.
2802
2803 2019-03-06  Tom Tromey  <tromey@adacore.com>
2804
2805         * remote-sim.c (gdbsim_target_open): Use result of
2806         gdb_argv::release.
2807
2808 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2809         Dirk Schubert  <dirk.schubert@arm.com>
2810         Chris January  <chris.january@arm.com>
2811
2812         * eval.c (evaluate_subexp_standard): Call Fortran argument
2813         wrapping logic.
2814         * f-lang.c (struct value): A value which can be passed into a
2815         Fortran function call.
2816         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2817         where appropriate.
2818         (struct type): Value ready for a Fortran function call.
2819         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2820         is needed.
2821         * f-lang.h (fortran_argument_convert): Declaration.
2822         (fortran_preserve_arg_pointer): Declaration.
2823         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2824
2825 2019-03-05  Tom Tromey  <tromey@adacore.com>
2826
2827         * python/py-prettyprint.c (print_string_repr): Remove #if.
2828         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2829
2830 2019-03-05  Tom Tromey  <tromey@adacore.com>
2831
2832         * target.c (the_dummy_target): Move later.  Change type to
2833         "dummy_target".
2834         (initialize_targets): Don't initialize the_dummy_target.
2835
2836 2019-03-05  Tom Tromey  <tromey@adacore.com>
2837
2838         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2839         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2840
2841 2019-03-05  Tom Tromey  <tromey@adacore.com>
2842
2843         * windows-nat.c (windows_nat_target::attach)
2844         (windows_nat_target::detach): Don't call gdb_flush.
2845         * valprint.c (generic_val_print, val_print, val_print_string):
2846         Don't call gdb_flush.
2847         * utils.c (defaulted_query): Don't call gdb_flush.
2848         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2849         * target.c (target_announce_detach): Don't call gdb_flush.
2850         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2851         * remote.c (extended_remote_target::attach): Don't call
2852         gdb_flush.
2853         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2854         * printcmd.c (do_examine): Don't call gdb_flush.
2855         (info_display_command): Don't call gdb_flush.
2856         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2857         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2858         * memattr.c (info_mem_command): Don't call gdb_flush.
2859         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2860         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2861         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2862         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2863         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2864         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2865         (gnu_nat_target::detach): Don't call gdb_flush.
2866         * f-valprint.c (f_val_print): Don't call gdb_flush.
2867         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2868         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2869         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2870         gdb_flush.
2871         * c-valprint.c (c_val_print): Don't call gdb_flush.
2872         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2873
2874 2019-03-05  Tom Tromey  <tromey@adacore.com>
2875
2876         * varobj.c (update_dynamic_varobj_children): Update.
2877         (install_default_visualizer): Use reset, not release.
2878         * value.c (set_internalvar): Update.
2879         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2880         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2881         ATTRIBUTE_UNUSED_RESULT.
2882
2883 2019-03-05  Tom Tromey  <tromey@adacore.com>
2884
2885         * remote.c (class scoped_remote_fd) <release>: Add
2886         ATTRIBUTE_UNUSED_RESULT.
2887
2888 2019-03-05  Tom Tromey  <tromey@adacore.com>
2889
2890         * macroexp.c (struct macro_buffer) <release>: Add
2891         ATTRIBUTE_UNUSED_RESULT.
2892
2893 2019-03-05  Tom Tromey  <tromey@adacore.com>
2894
2895         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2896         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2897         ATTRIBUTE_UNUSED_RESULT.
2898
2899 2019-03-05  Tom Tromey  <tromey@adacore.com>
2900
2901         * common/scoped_fd.h (class scoped_fd) <release>: Add
2902         ATTRIBUTE_UNUSED_RESULT.
2903
2904 2019-03-05  Tom Tromey  <tromey@adacore.com>
2905
2906         * parser-defs.h (struct parser_state) <release>: Add
2907         ATTRIBUTE_UNUSED_RESULT.
2908
2909 2019-03-05  Tom Tromey  <tromey@adacore.com>
2910
2911         * utils.h (class gdb_argv) <release>: Add
2912         ATTRIBUTE_UNUSED_RESULT.
2913         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2914
2915 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2916
2917         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2918         for-loop range, to avoid compiler warnings.
2919
2920         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2921         avoid compiler warnings about unused variables.
2922
2923         * NEWS: Mention end of support for native debugging on MS-Windows
2924         before XP.
2925
2926         PR gdb/24292
2927         * common/netstuff.c:
2928         * gdbserver/gdbreplay.c
2929         * gdbserver/remote-utils.c:
2930         * ser-tcp.c:
2931         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2932         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2933         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2934         'getaddrinfo' and 'freeaddrinfo' were not available before
2935         Windows XP, and mingw.org's MinGW headers by default define
2936         _WIN32_WINNT to 0x500.
2937
2938 2019-03-01  Gary Benson <gbenson@redhat.com>
2939
2940         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2941
2942 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2943             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2944
2945         PR gdb/8527
2946         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2947         set_sigint_trap, clear_sigint_trap.
2948
2949 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2950
2951         * target.c (target_detach): Clear the regcache and the
2952         frame cache.
2953
2954 2019-02-27  Pedro Alves  <palves@redhat.com>
2955
2956         * utils.c (set_screen_size): When we cap the height/width sizes,
2957         tweak the corresponding command variable to show "unlimited":
2958
2959 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2960             Pedro Alves  <palves@redhat.com>
2961
2962         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2963         before calling rl_set_screen_size.
2964
2965 2019-02-27  Tom Tromey  <tromey@adacore.com>
2966
2967         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2968         define.
2969         * python/py-value.c: Remove Python 2.4 workaround.
2970         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2971         workaround.
2972         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2973         Python 2.4 workaround.
2974         * python/python-internal.h: Remove Python 2.4 comment.
2975         (Py_ssize_t): Don't define.
2976         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2977         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2978         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2979         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2980         * python/python.c (do_start_initialization): Remove Python 2.4
2981         workaround.
2982         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2983         (print_children): Remove Python 2.4 workaround.
2984         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2985         workaround.
2986         (CHARBUFFERPROC_NAME): Remove.
2987         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2988         Python 2.4 workaround.
2989
2990 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2991
2992         * NEWS: Note minimum Python version.
2993
2994 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2995
2996         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2997         code from these functions.  Remove corresponding ifdefs.  Use
2998         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2999         Remove gotos and target of gotos.
3000         (infpy_search_memory): Likewise.
3001
3002 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3003
3004         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3005         (hppa_gdbarch_init): Don't register deleted functions with
3006         gdbarch.
3007
3008 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3009
3010         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3011         (h8300_unwind_sp): Delete.
3012         (h8300_dummy_id): Delete.
3013         (h8300_gdbarch_init): Don't register deleted functions with
3014         gdbarch.
3015
3016 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3017
3018         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3019         (ft32_unwind_pc): Delete.
3020         (ft32_unwind_sp): Delete.
3021         (ft32_gdbarch_init): Don't register deleted functions with
3022         gdbarch.
3023
3024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3025
3026         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3027         (frv_unwind_pc): Delete.
3028         (frv_unwind_sp): Delete.
3029         (frv_gdbarch_init): Don't register deleted functions with
3030         gdbarch.
3031
3032 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3033
3034         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3035         (riscv_unwind_pc): Delete.
3036         (riscv_unwind_sp): Delete.
3037         (riscv_gdbarch_init): Don't register deleted functions with
3038         gdbarch.
3039
3040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3041
3042         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3043         (csky_unwind_pc): Delete.
3044         (csky_unwind_sp): Delete.
3045         (csky_gdbarch_init): Don't register deleted functions with
3046         gdbarch.
3047
3048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3049
3050         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3051         (cris_unwind_pc): Delete.
3052         (cris_unwind_sp): Delete.
3053         (cris_gdbarch_init): Don't register deleted functions with
3054         gdbarch.
3055
3056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3057
3058         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3059         (bfin_unwind_pc): Delete.
3060         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3061
3062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3063
3064         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3065         (arm_unwind_pc): Delete.
3066         (arm_unwind_sp): Delete.
3067         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3068
3069 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3070
3071         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3072         (arc_unwind_pc): Delete.
3073         (arc_unwind_sp): Delete.
3074         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3075
3076 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3077
3078         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3079         (alpha_unwind_pc): Delete.
3080         (alpha_gdbarch_init): Don't register deleted functions with
3081         gdbarch.
3082
3083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3084
3085         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3086         (aarch64_unwind_pc): Delete.
3087         (aarch64_unwind_sp): Delete.
3088         (aarch64_gdbarch_init): Don't register deleted functions with
3089         gdbarch.
3090
3091 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3092
3093         * gdbtypes.c (type_align): Don't consider static members when
3094         computing structure alignment.
3095
3096 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3097
3098         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3099         return 0 for other types.
3100         * arch-utils.c (default_type_align): Always return 0.
3101         * gdbarch.h: Regenerate.
3102         * gdbarch.sh (type_align): Extend comment.
3103         * gdbtypes.c (type_align): Add additional comments, always call
3104         gdbarch_type_align before applying the default rules.
3105         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3106         generic code will then apply a suitable default.
3107         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3108         types, return 0 for other types.
3109
3110 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3111
3112         * NEWS: Create a new section for the next release branch.
3113         Rename the section of the current branch, now that it has
3114         been cut.
3115
3116 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3117
3118         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3119         * version.in: Bump version to 8.3.50.DATE-git.
3120
3121 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3122
3123         * aix-thread.c (ptid_cmp): Remove unused variable.
3124         (get_signaled_thread): Likewise.
3125         (store_regs_user_thread): Likewise.
3126         (store_regs_kernel_thread): Likewise.
3127         (fetch_regs_kernel_thread): Remove shadowed variable.
3128
3129 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3130
3131         * features/riscv/32bit-cpu.xml: Add register numbers.
3132         * features/riscv/32bit-fpu.c: Regenerate.
3133         * features/riscv/32bit-fpu.xml: Add register numbers.
3134         * features/riscv/64bit-cpu.xml: Add register numbers.
3135         * features/riscv/64bit-fpu.c: Regenerate.
3136         * features/riscv/64bit-fpu.xml: Add register numbers.
3137
3138 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3139
3140         * NEWS: Mention two argument form of gdb.Value constructor.
3141         * python/py-value.c (convert_buffer_and_type_to_value): New
3142         function.
3143         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3144         Add support for handling an optional second argument.  Call
3145         convert_buffer_and_type_to_value as appropriate.
3146         * python/python-internal.h (Py_buffer_deleter): New struct.
3147         (Py_buffer_up): New typedef.
3148
3149 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3150
3151         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3152         instead of releasing ownership.
3153
3154 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3155
3156         * dwarf2read.c (open_and_init_dwp_file): Call
3157         elf_numsections instead of bfd_count_sections to initialize
3158         dwp_file->num_sections.
3159
3160 2019-02-25  Tom Tromey  <tromey@adacore.com>
3161
3162         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3163
3164 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3165
3166         * gcore.in: Add '--readnever' option when invoking GDB.
3167
3168 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3169
3170         * MAINTAINERS: Update my email address.
3171
3172 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3173
3174         * build-id.c (build_id_to_debug_bfd_1): New function.
3175         (build_id_to_debug_bfd): Look for separate debug file in
3176         sysroot.
3177
3178 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3179
3180         * gdbarch.sh: Update the copyright year range that is placed into
3181         generated files.
3182
3183 2019-02-22  Keith Seitz  <keiths@redhat.com>
3184
3185         PR symtab/23853
3186         * linespec.c (create_sals_line_offset): Search for the default
3187         symtab's filename instead of its fullname.
3188
3189 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3190
3191         * NEWS: Update style defaults.
3192
3193 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3194
3195         * main.c (captured_main_1): Disable styling in batch mode.
3196
3197 2019-02-20  Tom Tromey  <tom@tromey.com>
3198
3199         * symtab.c (symtab_symbol_info): Fix typos.
3200
3201 2019-02-20  Tom Tromey  <tromey@adacore.com>
3202
3203         * findcmd.c (_initialize_mem_search): Use upper case for
3204         metasyntactic variables.
3205
3206 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3207
3208         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3209         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3210
3211 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3212
3213         * top.h (source_file_name): Change to std::string.
3214         * top.c (source_file_name): Likewise.
3215         (command_line_input): Adjust.
3216         * cli/cli-script.c (script_from_file): Adjust.
3217
3218 2019-02-19  Tom Tromey  <tromey@adacore.com>
3219
3220         * ravenscar-thread.c
3221         (ravenscar_thread_target::update_thread_list): Don't call
3222         ada_build_task_list.
3223         * ada-lang.h (ada_build_task_list): Don't declare.
3224         * ada-tasks.c (struct ada_tasks_inferior_data)
3225         <task_list_valid_p>: Now bool.
3226         (read_known_tasks, ada_task_list_changed)
3227         (ada_tasks_invalidate_inferior_data): Update.
3228         (read_known_tasks_array): Return bool.
3229         (read_known_tasks_list): Likewise.
3230         (read_known_tasks): Return void.
3231         (ada_build_task_list): Now static.
3232
3233 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3234
3235         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3236         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3237
3238 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3239
3240         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3241         variant for ada_tasks_pspace_data_handle and
3242         ada_tasks_inferior_data_handle.
3243         (ada_tasks_pspace_data_cleanup): New function.
3244         (ada_tasks_inferior_data_cleanup): New function.
3245
3246 2019-02-17  Tom Tromey  <tom@tromey.com>
3247
3248         * macrotab.h (macro_source_fullname): Return a std::string.
3249         * macrotab.c (macro_include, check_for_redefinition)
3250         (macro_undef, macro_lookup_definition, foreach_macro)
3251         (foreach_macro_in_scope): Update.
3252         (macro_source_fullname): Return a std::string.
3253         * macrocmd.c (show_pp_source_pos): Update.
3254
3255 2019-02-17  Tom Tromey  <tom@tromey.com>
3256
3257         * macrocmd.c (show_pp_source_pos): Style the file names.
3258
3259 2019-02-17  Tom Tromey  <tom@tromey.com>
3260
3261         PR tui/24197:
3262         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3263
3264 2019-02-17  Tom Tromey  <tom@tromey.com>
3265
3266         * ada-lang.c (user_select_syms): Use filtered printing.
3267         * utils.c (wrap_style): New global.
3268         (desired_style): Remove.
3269         (emit_style_escape): Add stream parameter.
3270         (set_output_style, reset_terminal_style, prompt_for_continue):
3271         Update.
3272         (flush_wrap_buffer): Only flush gdb_stdout.
3273         (wrap_here): Set wrap_style.
3274         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3275         treat escape sequences as a character.  Change when wrap buffer is
3276         flushed.
3277         (fputs_styled): Do not set the output style when the default is
3278         requested.
3279         * ui-style.h (struct ui_file_style) <is_default>: New method.
3280         * source.c (print_source_lines_base): Emit escape sequences in one
3281         piece.
3282
3283 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3284
3285         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3286         integers and enumeration types.
3287
3288 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3289
3290         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3291         instead of lookup_symbol_in_language
3292         (do_exact_match): New function.
3293         (ada_get_symbol_name_matcher): Return do_exact_match when
3294         doing a verbatim match.
3295
3296 2019-02-15  Tom Tromey  <tromey@adacore.com>
3297
3298         * ravenscar-thread.c (ravenscar_thread_target::resume)
3299         (ravenscar_thread_target::wait): Special case wildcard requests.
3300
3301 2019-02-15  Tom Tromey  <tromey@adacore.com>
3302
3303         * ravenscar-thread.c (base_ptid): Remove.
3304         (struct ravenscar_thread_target) <close>: New method.
3305         <m_base_ptid>: New member.
3306         <update_inferior_ptid, active_task, task_is_currently_active,
3307         runtime_initialized>: Declare methods.
3308         <ravenscar_thread_target>: Add constructor.
3309         (ravenscar_thread_target::task_is_currently_active)
3310         (ravenscar_thread_target::update_inferior_ptid)
3311         (ravenscar_runtime_initialized): Rename.  Now methods.
3312         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3313         (ravenscar_thread_target::update_thread_list): Update.
3314         (ravenscar_thread_target::active_task): Now method.
3315         (ravenscar_thread_target::store_registers)
3316         (ravenscar_thread_target::prepare_to_store)
3317         (ravenscar_thread_target::prepare_to_store)
3318         (ravenscar_thread_target::mourn_inferior): Update.
3319         (ravenscar_inferior_created): Use "new" to create target.
3320         (ravenscar_thread_target::get_ada_task_ptid): Update.
3321         (_initialize_ravenscar): Don't initialize base_ptid.
3322         (ravenscar_ops): Remove global.
3323
3324 2019-02-15  Tom Tromey  <tromey@adacore.com>
3325
3326         * target.h (push_target): Declare new overload.
3327         * target.c (push_target): New overload, taking an rvalue reference.
3328         * remote.c (remote_target::open_1): Use push_target overload.
3329         * corelow.c (core_target_open): Use push_target overload.
3330
3331 2019-02-15  Tom Tromey  <tromey@adacore.com>
3332
3333         * ravenscar-thread.c (is_ravenscar_task)
3334         (ravenscar_task_is_currently_active): Return bool.
3335         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3336         (_initialize_ravenscar): Remove "(void)".
3337         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3338         Return bool.
3339
3340 2019-02-15  Tom Tromey  <tromey@adacore.com>
3341
3342         * ravenscar-thread.c (ravenscar_runtime_initializer)
3343         (has_ravenscar_runtime, get_running_thread_id)
3344         (ravenscar_thread_target::resume): Fix indentation.
3345
3346 2019-02-15  Tom Tromey  <tromey@adacore.com>
3347
3348         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3349         from ravenscar_arch_ops.
3350         (sparc_ravenscar_ops::fetch_registers)
3351         (sparc_ravenscar_ops::store_registers): Now methods.
3352         (sparc_ravenscar_prepare_to_store): Remove.
3353         (sparc_ravenscar_ops): Redefine.
3354         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3355         methods and destructor.  Remove members.
3356         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3357         (ravenscar_thread_target::store_registers)
3358         (ravenscar_thread_target::prepare_to_store): Update.
3359         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3360         Remove.
3361         (struct ppc_ravenscar_powerpc_ops): Derive from
3362         ravenscar_arch_ops.
3363         (ppc_ravenscar_powerpc_ops::fetch_registers)
3364         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3365         (ppc_ravenscar_powerpc_ops): Redefine.
3366         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3367         (ppc_ravenscar_e500_ops::fetch_registers)
3368         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3369         (ppc_ravenscar_e500_ops): Redefine.
3370         * aarch64-ravenscar-thread.c
3371         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3372         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3373         (aarch64_ravenscar_fetch_registers)
3374         (aarch64_ravenscar_store_registers): Now methods.
3375         (aarch64_ravenscar_ops): Redefine.
3376
3377 2019-02-15  Tom Tromey  <tromey@adacore.com>
3378
3379         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3380         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3381         (ravenscar_thread_target::stopped_by_watchpoint)
3382         (ravenscar_thread_target::stopped_data_address)
3383         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3384
3385 2019-02-15  Tom Tromey  <tromey@adacore.com>
3386
3387         * ravenscar-thread.c: Fix some typos.
3388
3389 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3390             Tom Tromey  <tromey@adacore.com>
3391
3392         * ada-lang.c (ada_exception_sal): Change addr_string to a
3393         std::string.
3394         (create_ada_exception_catchpoint): Update.
3395
3396 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3397             Tom Tromey  <tromey@adacore.com>
3398
3399         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3400         (bp_location_ops): Remove.
3401         (base_breakpoint_allocate_location): Update.
3402         (free_bp_location): Update.
3403         * ada-lang.c (class ada_catchpoint_location)
3404         <ada_catchpoint_location>: Remove ops parameter.
3405         (ada_catchpoint_location_dtor): Remove.
3406         (ada_catchpoint_location_ops): Remove.
3407         (allocate_location_exception): Update.
3408         * breakpoint.h (struct bp_location_ops): Remove.
3409         (class bp_location) <bp_location>: Remove bp_location_ops
3410         parameter.
3411         <~bp_location>: Add destructor.
3412         <ops>: Remove.
3413
3414 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3415             Pedro Alves  <palves@redhat.com>
3416
3417         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3418         'PATH_MAX'.
3419
3420 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3421             Samuel Thibault  <samuel.thibault@gnu.org>
3422             Thomas Schwinge  <thomas@codesourcery.com>
3423
3424         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3425         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3426
3427 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3428
3429         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3430         (check_empty): Use "const char *".
3431
3432         * gnu-nat.c (gnu_nat_target::detach): Instead of
3433         'detach_inferior (pid)' call
3434         'detach_inferior (find_inferior_pid (pid))'.
3435
3436         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3437         'nat/fork-inferior.o'.
3438         * gnu-nat.c: #include "nat/fork-inferior.h".
3439
3440         * gnu-nat.c (gnu_nat_target::detach): Instead of
3441         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3442         * gnu-nat.h: #include "inf-child.h".
3443         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3444         'i386_gnu_nat_target::fetch_registers'.
3445         (gnu_store_registers): Rename/move to
3446         'i386_gnu_nat_target::store_registers'.
3447
3448         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3449         * gnu-nat.h (mach_thread_info): New function.
3450         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3451
3452         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3453
3454 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3455
3456         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3457
3458 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3459
3460         * windows-nat.c (windows_add_thread): Add new parameter
3461         "main_thread_p" with default value set to false.  Update
3462         function documentation as well as all callers.
3463         (windows_delete_thread): Likewise.
3464         (fake_create_process): Update call to windows_add_thread.
3465         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3466         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3467         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3468         call to windows_delete_thread.
3469
3470 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3471
3472         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3473
3474 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3475
3476         * symfile.c (find_separate_debug_file): Use canonical path of
3477         sysroot with child_path instead of gdb_sysroot if it is valid.
3478
3479 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3480
3481         * symfile.c (find_separate_debug_file): Use child_path to
3482         determine if an object file is under a sysroot.
3483
3484 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3485
3486         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3487         unittests/child-path-selftests.c.
3488         * common/pathstuff.c (child_path): New function.
3489         * common/pathstuff.h (child_path): New prototype.
3490         * unittests/child-path-selftests.c: New file.
3491
3492 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3493
3494         * symfile.c (find_separate_debug_file): Look for separate debug
3495         files in debug directories under the sysroot.
3496
3497 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3498
3499         * symtab.h (struct minimal_symbol data_p): New const method.
3500         (struct minimal_symbol text_p): Likewise.
3501         * symtab.c (output_source_filename): Use file name style
3502         to print file name.
3503         (print_symbol_info): Likewise.
3504         (print_msymbol_info): Use address style to print addresses.
3505         Use function name style to print executable text symbols.
3506         (expand_symtab_containing_pc): Use data_p.
3507         (find_pc_sect_compunit_symtab): Likewise.
3508
3509 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3510
3511         * breakpoint.c (describe_other_breakpoints): Use address style
3512         to print addresses.
3513         (say_where): Likewise.
3514
3515 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3516
3517         * ada-typeprint.c (print_func_type): Print function name
3518         style to print function name.
3519         * c-typeprint.c (c_print_type_1): Likewise.
3520
3521 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3522
3523         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3524         for execve.
3525
3526 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3527
3528         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3529         type_stack.
3530
3531 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3532
3533         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3534         TYPE_CODE_REF types.
3535
3536 2019-02-08  Jim Wilson  <jimw@sifive.com>
3537
3538         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3539         (riscv_linux_fregset): New.
3540         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3541
3542 2019-02-07  Tom Tromey  <tom@tromey.com>
3543
3544         * thread.c (thread_cancel_execution_command): Update.
3545         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3546         methods.
3547         (struct thread_fsm_ops): Remove.
3548         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3549         (thread_fsm_should_stop, thread_fsm_return_value)
3550         (thread_fsm_set_finished, thread_fsm_finished_p)
3551         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3552         Don't declare.
3553         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3554         * infrun.c (clear_proceed_status_thread)
3555         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3556         (print_stop_event): Update.
3557         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3558         Add constructor.
3559         (step_command_fsm_ops): Remove.
3560         (new_step_command_fsm): Remove.
3561         (step_1): Update.
3562         (step_command_fsm::should_stop): Rename from
3563         step_command_fsm_should_stop.
3564         (step_command_fsm::clean_up): Rename from
3565         step_command_fsm_clean_up.
3566         (step_command_fsm::do_async_reply_reason): Rename from
3567         step_command_fsm_async_reply_reason.
3568         (struct until_next_fsm): Inherit from thread_fsm.  Add
3569         constructor.
3570         (until_next_fsm_ops): Remove.
3571         (new_until_next_fsm): Remove.
3572         (until_next_fsm::should_stop): Rename from
3573         until_next_fsm_should_stop.
3574         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3575         (until_next_fsm::do_async_reply_reason): Rename from
3576         until_next_fsm_async_reply_reason.
3577         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3578         constructor.  Change type of breakpoint.
3579         (finish_command_fsm_ops): Remove.
3580         (new_finish_command_fsm): Remove.
3581         (finish_command_fsm::should_stop): Rename from
3582         finish_command_fsm_should_stop.
3583         (finish_command_fsm::clean_up): Rename from
3584         finish_command_fsm_clean_up.
3585         (finish_command_fsm::return_value): Rename from
3586         finish_command_fsm_return_value.
3587         (finish_command_fsm::do_async_reply_reason): Rename from
3588         finish_command_fsm_async_reply_reason.
3589         (finish_command): Update.
3590         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3591         Add constructor.
3592         (call_thread_fsm_ops): Remove.
3593         (call_thread_fsm::call_thread_fsm): Rename from
3594         new_call_thread_fsm.
3595         (call_thread_fsm::should_stop): Rename from
3596         call_thread_fsm_should_stop.
3597         (call_thread_fsm::should_notify_stop): Rename from
3598         call_thread_fsm_should_notify_stop.
3599         (run_inferior_call, call_function_by_hand_dummy): Update.
3600         * cli/cli-interp.c (should_print_stop_to_console): Update.
3601         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3602         Add constructor.  Change type of location_breakpoint,
3603         caller_breakpoint.
3604         (until_break_fsm_ops): Remove.
3605         (new_until_break_fsm): Remove.
3606         (until_break_fsm::should_stop): Rename from
3607         until_break_fsm_should_stop.
3608         (until_break_fsm::clean_up): Rename from
3609         until_break_fsm_clean_up.
3610         (until_break_fsm::do_async_reply_reason): Rename from
3611         until_break_fsm_async_reply_reason.
3612         (until_break_command): Update.
3613         * thread-fsm.c: Remove.
3614         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3615
3616 2019-02-07  Tom Tromey  <tom@tromey.com>
3617
3618         * yy-remap.h: Add include guard.
3619         * xtensa-tdep.h: Add include guard.
3620         * xcoffread.h: Rename include guard.
3621         * varobj-iter.h: Add include guard.
3622         * tui/tui.h: Rename include guard.
3623         * tui/tui-winsource.h: Rename include guard.
3624         * tui/tui-wingeneral.h: Rename include guard.
3625         * tui/tui-windata.h: Rename include guard.
3626         * tui/tui-win.h: Rename include guard.
3627         * tui/tui-stack.h: Rename include guard.
3628         * tui/tui-source.h: Rename include guard.
3629         * tui/tui-regs.h: Rename include guard.
3630         * tui/tui-out.h: Rename include guard.
3631         * tui/tui-layout.h: Rename include guard.
3632         * tui/tui-io.h: Rename include guard.
3633         * tui/tui-hooks.h: Rename include guard.
3634         * tui/tui-file.h: Rename include guard.
3635         * tui/tui-disasm.h: Rename include guard.
3636         * tui/tui-data.h: Rename include guard.
3637         * tui/tui-command.h: Rename include guard.
3638         * tic6x-tdep.h: Add include guard.
3639         * target/waitstatus.h: Rename include guard.
3640         * target/wait.h: Rename include guard.
3641         * target/target.h: Rename include guard.
3642         * target/resume.h: Rename include guard.
3643         * target-float.h: Rename include guard.
3644         * stabsread.h: Add include guard.
3645         * rs6000-tdep.h: Add include guard.
3646         * riscv-fbsd-tdep.h: Add include guard.
3647         * regformats/regdef.h: Rename include guard.
3648         * record.h: Rename include guard.
3649         * python/python.h: Rename include guard.
3650         * python/python-internal.h: Rename include guard.
3651         * python/py-stopevent.h: Rename include guard.
3652         * python/py-ref.h: Rename include guard.
3653         * python/py-record.h: Rename include guard.
3654         * python/py-record-full.h: Rename include guard.
3655         * python/py-record-btrace.h: Rename include guard.
3656         * python/py-instruction.h: Rename include guard.
3657         * python/py-events.h: Rename include guard.
3658         * python/py-event.h: Rename include guard.
3659         * procfs.h: Add include guard.
3660         * proc-utils.h: Add include guard.
3661         * p-lang.h: Add include guard.
3662         * or1k-tdep.h: Rename include guard.
3663         * observable.h: Rename include guard.
3664         * nto-tdep.h: Rename include guard.
3665         * nat/x86-linux.h: Rename include guard.
3666         * nat/x86-linux-dregs.h: Rename include guard.
3667         * nat/x86-gcc-cpuid.h: Add include guard.
3668         * nat/x86-dregs.h: Rename include guard.
3669         * nat/x86-cpuid.h: Rename include guard.
3670         * nat/ppc-linux.h: Rename include guard.
3671         * nat/mips-linux-watch.h: Rename include guard.
3672         * nat/linux-waitpid.h: Rename include guard.
3673         * nat/linux-ptrace.h: Rename include guard.
3674         * nat/linux-procfs.h: Rename include guard.
3675         * nat/linux-osdata.h: Rename include guard.
3676         * nat/linux-nat.h: Rename include guard.
3677         * nat/linux-namespaces.h: Rename include guard.
3678         * nat/linux-btrace.h: Rename include guard.
3679         * nat/glibc_thread_db.h: Rename include guard.
3680         * nat/gdb_thread_db.h: Rename include guard.
3681         * nat/gdb_ptrace.h: Rename include guard.
3682         * nat/fork-inferior.h: Rename include guard.
3683         * nat/amd64-linux-siginfo.h: Rename include guard.
3684         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3685         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3686         * nat/aarch64-linux.h: Rename include guard.
3687         * nat/aarch64-linux-hw-point.h: Rename include guard.
3688         * mn10300-tdep.h: Add include guard.
3689         * mips-linux-tdep.h: Add include guard.
3690         * mi/mi-parse.h: Rename include guard.
3691         * mi/mi-out.h: Rename include guard.
3692         * mi/mi-main.h: Rename include guard.
3693         * mi/mi-interp.h: Rename include guard.
3694         * mi/mi-getopt.h: Rename include guard.
3695         * mi/mi-console.h: Rename include guard.
3696         * mi/mi-common.h: Rename include guard.
3697         * mi/mi-cmds.h: Rename include guard.
3698         * mi/mi-cmd-break.h: Rename include guard.
3699         * m2-lang.h: Add include guard.
3700         * location.h: Rename include guard.
3701         * linux-record.h: Rename include guard.
3702         * linux-nat.h: Add include guard.
3703         * linux-fork.h: Add include guard.
3704         * i386-darwin-tdep.h: Rename include guard.
3705         * hppa-linux-offsets.h: Add include guard.
3706         * guile/guile.h: Rename include guard.
3707         * guile/guile-internal.h: Rename include guard.
3708         * gnu-nat.h: Rename include guard.
3709         * gdb-stabs.h: Rename include guard.
3710         * frv-tdep.h: Add include guard.
3711         * f-lang.h: Add include guard.
3712         * event-loop.h: Add include guard.
3713         * darwin-nat.h: Rename include guard.
3714         * cp-abi.h: Rename include guard.
3715         * config/sparc/nm-sol2.h: Rename include guard.
3716         * config/nm-nto.h: Rename include guard.
3717         * config/nm-linux.h: Add include guard.
3718         * config/i386/nm-i386gnu.h: Rename include guard.
3719         * config/djgpp/nl_types.h: Rename include guard.
3720         * config/djgpp/langinfo.h: Rename include guard.
3721         * compile/gcc-cp-plugin.h: Add include guard.
3722         * compile/gcc-c-plugin.h: Add include guard.
3723         * compile/compile.h: Rename include guard.
3724         * compile/compile-object-run.h: Rename include guard.
3725         * compile/compile-object-load.h: Rename include guard.
3726         * compile/compile-internal.h: Rename include guard.
3727         * compile/compile-cplus.h: Rename include guard.
3728         * compile/compile-c.h: Rename include guard.
3729         * common/xml-utils.h: Rename include guard.
3730         * common/x86-xstate.h: Rename include guard.
3731         * common/version.h: Rename include guard.
3732         * common/vec.h: Rename include guard.
3733         * common/tdesc.h: Rename include guard.
3734         * common/selftest.h: Rename include guard.
3735         * common/scoped_restore.h: Rename include guard.
3736         * common/scoped_mmap.h: Rename include guard.
3737         * common/scoped_fd.h: Rename include guard.
3738         * common/safe-iterator.h: Rename include guard.
3739         * common/run-time-clock.h: Rename include guard.
3740         * common/refcounted-object.h: Rename include guard.
3741         * common/queue.h: Rename include guard.
3742         * common/ptid.h: Rename include guard.
3743         * common/print-utils.h: Rename include guard.
3744         * common/preprocessor.h: Rename include guard.
3745         * common/pathstuff.h: Rename include guard.
3746         * common/observable.h: Rename include guard.
3747         * common/netstuff.h: Rename include guard.
3748         * common/job-control.h: Rename include guard.
3749         * common/host-defs.h: Rename include guard.
3750         * common/gdb_wait.h: Rename include guard.
3751         * common/gdb_vecs.h: Rename include guard.
3752         * common/gdb_unlinker.h: Rename include guard.
3753         * common/gdb_unique_ptr.h: Rename include guard.
3754         * common/gdb_tilde_expand.h: Rename include guard.
3755         * common/gdb_sys_time.h: Rename include guard.
3756         * common/gdb_string_view.h: Rename include guard.
3757         * common/gdb_splay_tree.h: Rename include guard.
3758         * common/gdb_setjmp.h: Rename include guard.
3759         * common/gdb_ref_ptr.h: Rename include guard.
3760         * common/gdb_optional.h: Rename include guard.
3761         * common/gdb_locale.h: Rename include guard.
3762         * common/gdb_assert.h: Rename include guard.
3763         * common/filtered-iterator.h: Rename include guard.
3764         * common/filestuff.h: Rename include guard.
3765         * common/fileio.h: Rename include guard.
3766         * common/environ.h: Rename include guard.
3767         * common/common-utils.h: Rename include guard.
3768         * common/common-types.h: Rename include guard.
3769         * common/common-regcache.h: Rename include guard.
3770         * common/common-inferior.h: Rename include guard.
3771         * common/common-gdbthread.h: Rename include guard.
3772         * common/common-exceptions.h: Rename include guard.
3773         * common/common-defs.h: Rename include guard.
3774         * common/common-debug.h: Rename include guard.
3775         * common/cleanups.h: Rename include guard.
3776         * common/buffer.h: Rename include guard.
3777         * common/btrace-common.h: Rename include guard.
3778         * common/break-common.h: Rename include guard.
3779         * cli/cli-utils.h: Rename include guard.
3780         * cli/cli-style.h: Rename include guard.
3781         * cli/cli-setshow.h: Rename include guard.
3782         * cli/cli-script.h: Rename include guard.
3783         * cli/cli-interp.h: Rename include guard.
3784         * cli/cli-decode.h: Rename include guard.
3785         * cli/cli-cmds.h: Rename include guard.
3786         * charset-list.h: Add include guard.
3787         * buildsym-legacy.h: Rename include guard.
3788         * bfin-tdep.h: Add include guard.
3789         * ax.h: Rename include guard.
3790         * arm-linux-tdep.h: Add include guard.
3791         * arm-fbsd-tdep.h: Add include guard.
3792         * arch/xtensa.h: Rename include guard.
3793         * arch/tic6x.h: Add include guard.
3794         * arch/i386.h: Add include guard.
3795         * arch/arm.h: Rename include guard.
3796         * arch/arm-linux.h: Rename include guard.
3797         * arch/arm-get-next-pcs.h: Rename include guard.
3798         * arch/amd64.h: Add include guard.
3799         * arch/aarch64-insn.h: Rename include guard.
3800         * arch-utils.h: Rename include guard.
3801         * annotate.h: Add include guard.
3802         * amd64-darwin-tdep.h: Rename include guard.
3803         * aarch64-linux-tdep.h: Add include guard.
3804         * aarch64-fbsd-tdep.h: Add include guard.
3805         * aarch32-linux-nat.h: Add include guard.
3806
3807 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3808
3809         * macrotab.c (macro_define_internal): New function that
3810         factorizes macro_define_object_internal and macro_define_function
3811         code.
3812         (macro_define_object_internal): Use macro_define_internal.
3813         (macro_define_function): Likewise.
3814
3815 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3816
3817         * macrocmd.c (extract_identifier): Return
3818         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3819         callers.
3820
3821 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3822
3823         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3824
3825 2019-02-05  Tom Tromey  <tom@tromey.com>
3826
3827         * target.c (target_stack::unpush): Move assertion earlier.
3828
3829 2019-01-30  Tom Tromey  <tom@tromey.com>
3830
3831         PR python/23615:
3832         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3833         (gdbpy_parse_and_eval): Likewise.
3834         * python/python-internal.h (gdbpy_allow_threads): New class.
3835
3836 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3837
3838         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3839         (aarch64_fbsd_fpregmap): Move earlier.
3840         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3841         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3842         instead of individual calls to trad_frame_set_reg_addr.
3843         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3844         earlier.
3845         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3846         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3847         instead of individual calls to trad_frame_set_reg_addr.
3848
3849 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3850
3851         * CONTRIBUTE: Replace contribution list with wiki link.
3852
3853 2019-01-25  Tom Tromey  <tom@tromey.com>
3854
3855         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3856
3857 2019-01-25  Tom Tromey  <tom@tromey.com>
3858
3859         * xtensa-linux-nat.c: Fix common/ includes.
3860         * xml-support.h: Fix common/ includes.
3861         * xml-support.c: Fix common/ includes.
3862         * x86-linux-nat.c: Fix common/ includes.
3863         * windows-nat.c: Fix common/ includes.
3864         * varobj.h: Fix common/ includes.
3865         * varobj.c: Fix common/ includes.
3866         * value.c: Fix common/ includes.
3867         * valops.c: Fix common/ includes.
3868         * utils.c: Fix common/ includes.
3869         * unittests/xml-utils-selftests.c: Fix common/ includes.
3870         * unittests/utils-selftests.c: Fix common/ includes.
3871         * unittests/unpack-selftests.c: Fix common/ includes.
3872         * unittests/tracepoint-selftests.c: Fix common/ includes.
3873         * unittests/style-selftests.c: Fix common/ includes.
3874         * unittests/string_view-selftests.c: Fix common/ includes.
3875         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3876         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3877         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3878         * unittests/rsp-low-selftests.c: Fix common/ includes.
3879         * unittests/parse-connection-spec-selftests.c: Fix common/
3880         includes.
3881         * unittests/optional-selftests.c: Fix common/ includes.
3882         * unittests/offset-type-selftests.c: Fix common/ includes.
3883         * unittests/observable-selftests.c: Fix common/ includes.
3884         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3885         * unittests/memrange-selftests.c: Fix common/ includes.
3886         * unittests/memory-map-selftests.c: Fix common/ includes.
3887         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3888         * unittests/function-view-selftests.c: Fix common/ includes.
3889         * unittests/environ-selftests.c: Fix common/ includes.
3890         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3891         * unittests/common-utils-selftests.c: Fix common/ includes.
3892         * unittests/cli-utils-selftests.c: Fix common/ includes.
3893         * unittests/array-view-selftests.c: Fix common/ includes.
3894         * ui-file.c: Fix common/ includes.
3895         * tui/tui-io.c: Fix common/ includes.
3896         * tracepoint.h: Fix common/ includes.
3897         * tracepoint.c: Fix common/ includes.
3898         * tracefile-tfile.c: Fix common/ includes.
3899         * top.h: Fix common/ includes.
3900         * top.c: Fix common/ includes.
3901         * thread.c: Fix common/ includes.
3902         * target/waitstatus.h: Fix common/ includes.
3903         * target/waitstatus.c: Fix common/ includes.
3904         * target.h: Fix common/ includes.
3905         * target.c: Fix common/ includes.
3906         * target-memory.c: Fix common/ includes.
3907         * target-descriptions.c: Fix common/ includes.
3908         * symtab.h: Fix common/ includes.
3909         * symfile.c: Fix common/ includes.
3910         * stap-probe.c: Fix common/ includes.
3911         * spu-linux-nat.c: Fix common/ includes.
3912         * sparc-nat.c: Fix common/ includes.
3913         * source.c: Fix common/ includes.
3914         * solib.c: Fix common/ includes.
3915         * solib-target.c: Fix common/ includes.
3916         * ser-unix.c: Fix common/ includes.
3917         * ser-tcp.c: Fix common/ includes.
3918         * ser-pipe.c: Fix common/ includes.
3919         * ser-base.c: Fix common/ includes.
3920         * selftest-arch.c: Fix common/ includes.
3921         * s12z-tdep.c: Fix common/ includes.
3922         * rust-exp.y: Fix common/ includes.
3923         * rs6000-aix-tdep.c: Fix common/ includes.
3924         * riscv-tdep.c: Fix common/ includes.
3925         * remote.c: Fix common/ includes.
3926         * remote-notif.h: Fix common/ includes.
3927         * remote-fileio.h: Fix common/ includes.
3928         * remote-fileio.c: Fix common/ includes.
3929         * regcache.h: Fix common/ includes.
3930         * regcache.c: Fix common/ includes.
3931         * record-btrace.c: Fix common/ includes.
3932         * python/python.c: Fix common/ includes.
3933         * python/py-type.c: Fix common/ includes.
3934         * python/py-inferior.c: Fix common/ includes.
3935         * progspace.h: Fix common/ includes.
3936         * producer.c: Fix common/ includes.
3937         * procfs.c: Fix common/ includes.
3938         * proc-api.c: Fix common/ includes.
3939         * printcmd.c: Fix common/ includes.
3940         * ppc-linux-nat.c: Fix common/ includes.
3941         * parser-defs.h: Fix common/ includes.
3942         * osdata.c: Fix common/ includes.
3943         * obsd-nat.c: Fix common/ includes.
3944         * nat/x86-linux.c: Fix common/ includes.
3945         * nat/x86-linux-dregs.c: Fix common/ includes.
3946         * nat/x86-dregs.h: Fix common/ includes.
3947         * nat/x86-dregs.c: Fix common/ includes.
3948         * nat/ppc-linux.c: Fix common/ includes.
3949         * nat/mips-linux-watch.h: Fix common/ includes.
3950         * nat/mips-linux-watch.c: Fix common/ includes.
3951         * nat/linux-waitpid.c: Fix common/ includes.
3952         * nat/linux-ptrace.h: Fix common/ includes.
3953         * nat/linux-ptrace.c: Fix common/ includes.
3954         * nat/linux-procfs.c: Fix common/ includes.
3955         * nat/linux-personality.c: Fix common/ includes.
3956         * nat/linux-osdata.c: Fix common/ includes.
3957         * nat/linux-namespaces.c: Fix common/ includes.
3958         * nat/linux-btrace.h: Fix common/ includes.
3959         * nat/linux-btrace.c: Fix common/ includes.
3960         * nat/fork-inferior.c: Fix common/ includes.
3961         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3962         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3963         * nat/aarch64-linux.c: Fix common/ includes.
3964         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3965         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3966         * namespace.h: Fix common/ includes.
3967         * mips-linux-tdep.c: Fix common/ includes.
3968         * minsyms.c: Fix common/ includes.
3969         * mi/mi-parse.h: Fix common/ includes.
3970         * mi/mi-main.c: Fix common/ includes.
3971         * mi/mi-cmd-env.c: Fix common/ includes.
3972         * memrange.h: Fix common/ includes.
3973         * memattr.c: Fix common/ includes.
3974         * maint.h: Fix common/ includes.
3975         * maint.c: Fix common/ includes.
3976         * main.c: Fix common/ includes.
3977         * machoread.c: Fix common/ includes.
3978         * location.c: Fix common/ includes.
3979         * linux-thread-db.c: Fix common/ includes.
3980         * linux-nat.c: Fix common/ includes.
3981         * linux-fork.c: Fix common/ includes.
3982         * inline-frame.c: Fix common/ includes.
3983         * infrun.c: Fix common/ includes.
3984         * inflow.c: Fix common/ includes.
3985         * inferior.h: Fix common/ includes.
3986         * inferior.c: Fix common/ includes.
3987         * infcmd.c: Fix common/ includes.
3988         * inf-ptrace.c: Fix common/ includes.
3989         * inf-child.c: Fix common/ includes.
3990         * ia64-linux-nat.c: Fix common/ includes.
3991         * i387-tdep.c: Fix common/ includes.
3992         * i386-tdep.c: Fix common/ includes.
3993         * i386-linux-tdep.c: Fix common/ includes.
3994         * i386-linux-nat.c: Fix common/ includes.
3995         * i386-go32-tdep.c: Fix common/ includes.
3996         * i386-fbsd-tdep.c: Fix common/ includes.
3997         * i386-fbsd-nat.c: Fix common/ includes.
3998         * guile/scm-type.c: Fix common/ includes.
3999         * guile/guile.c: Fix common/ includes.
4000         * go32-nat.c: Fix common/ includes.
4001         * gnu-nat.c: Fix common/ includes.
4002         * gdbthread.h: Fix common/ includes.
4003         * gdbarch-selftests.c: Fix common/ includes.
4004         * gdb_usleep.c: Fix common/ includes.
4005         * gdb_select.h: Fix common/ includes.
4006         * gdb_bfd.c: Fix common/ includes.
4007         * gcore.c: Fix common/ includes.
4008         * fork-child.c: Fix common/ includes.
4009         * findvar.c: Fix common/ includes.
4010         * fbsd-nat.c: Fix common/ includes.
4011         * event-top.c: Fix common/ includes.
4012         * event-loop.c: Fix common/ includes.
4013         * dwarf2read.c: Fix common/ includes.
4014         * dwarf2loc.c: Fix common/ includes.
4015         * dwarf2-frame.c: Fix common/ includes.
4016         * dwarf-index-cache.c: Fix common/ includes.
4017         * dtrace-probe.c: Fix common/ includes.
4018         * disasm-selftests.c: Fix common/ includes.
4019         * defs.h: Fix common/ includes.
4020         * csky-tdep.c: Fix common/ includes.
4021         * cp-valprint.c: Fix common/ includes.
4022         * cp-support.h: Fix common/ includes.
4023         * cp-support.c: Fix common/ includes.
4024         * corelow.c: Fix common/ includes.
4025         * completer.h: Fix common/ includes.
4026         * completer.c: Fix common/ includes.
4027         * compile/compile.c: Fix common/ includes.
4028         * compile/compile-loc2c.c: Fix common/ includes.
4029         * compile/compile-cplus-types.c: Fix common/ includes.
4030         * compile/compile-cplus-symbols.c: Fix common/ includes.
4031         * command.h: Fix common/ includes.
4032         * cli/cli-dump.c: Fix common/ includes.
4033         * cli/cli-cmds.c: Fix common/ includes.
4034         * charset.c: Fix common/ includes.
4035         * build-id.c: Fix common/ includes.
4036         * btrace.h: Fix common/ includes.
4037         * btrace.c: Fix common/ includes.
4038         * breakpoint.h: Fix common/ includes.
4039         * breakpoint.c: Fix common/ includes.
4040         * ax.h:
4041         (enum agent_op): Fix common/ includes.
4042         * ax-general.c (struct aop_map): Fix common/ includes.
4043         * ax-gdb.c: Fix common/ includes.
4044         * auxv.c: Fix common/ includes.
4045         * auto-load.c: Fix common/ includes.
4046         * arm-tdep.c: Fix common/ includes.
4047         * arch/riscv.c: Fix common/ includes.
4048         * arch/ppc-linux-common.c: Fix common/ includes.
4049         * arch/i386.c: Fix common/ includes.
4050         * arch/arm.c: Fix common/ includes.
4051         * arch/arm-linux.c: Fix common/ includes.
4052         * arch/arm-get-next-pcs.c: Fix common/ includes.
4053         * arch/amd64.c: Fix common/ includes.
4054         * arch/aarch64.c: Fix common/ includes.
4055         * arch/aarch64-insn.c: Fix common/ includes.
4056         * arch-utils.c: Fix common/ includes.
4057         * amd64-windows-tdep.c: Fix common/ includes.
4058         * amd64-tdep.c: Fix common/ includes.
4059         * amd64-sol2-tdep.c: Fix common/ includes.
4060         * amd64-obsd-tdep.c: Fix common/ includes.
4061         * amd64-nbsd-tdep.c: Fix common/ includes.
4062         * amd64-linux-tdep.c: Fix common/ includes.
4063         * amd64-linux-nat.c: Fix common/ includes.
4064         * amd64-fbsd-tdep.c: Fix common/ includes.
4065         * amd64-fbsd-nat.c: Fix common/ includes.
4066         * amd64-dicos-tdep.c: Fix common/ includes.
4067         * amd64-darwin-tdep.c: Fix common/ includes.
4068         * agent.c: Fix common/ includes.
4069         * ada-lang.h: Fix common/ includes.
4070         * ada-lang.c: Fix common/ includes.
4071         * aarch64-tdep.c: Fix common/ includes.
4072
4073 2019-01-25  Tom Tromey  <tom@tromey.com>
4074
4075         * common/create-version.sh: Use common/version.h.
4076
4077 2019-01-24  Pedro Alves  <palves@redhat.com>
4078
4079         * infrun.c (signal_stop, signal_print, signal_program)
4080         (signal_catch, signal_pass): Now arrays instead of pointers.
4081         (update_signals_program_target, do_target_resume)
4082         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4083         * linux-nat.c (linux_nat_target::pass_signals)
4084         (linux_nat_target::create_inferior, linux_nat_target::attach):
4085         Adjust.
4086         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4087         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4088         * procfs.c (procfs_target::pass_signals): Adjust.
4089         * record-full.c (record_full_target::resume): Adjust.
4090         * remote.c (remote_target::pass_signals)
4091         (remote_target::program_signals): Adjust.
4092         * target-debug.h (target_debug_print_signals): Now takes a
4093         gdb::array_view as parameter.  Adjust.
4094         * target.h (target_ops) <pass_signals, program_signals>: Replace
4095         pointer and length parameters with gdb::array_view.
4096         (target_pass_signals, target_program_signals): Likewise.
4097         * target-delegates.c: Regenerate.
4098
4099 2019-01-24  Pedro Alves  <palves@redhat.com>
4100
4101         * common/forward-scope-exit.h
4102         (forward_scope_exit::forward_scope_exit): Pass arguments to
4103         m_bind_function directly, instead of creating a std::bind and
4104         copying that.
4105
4106 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4107
4108         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4109         for static members.
4110         (pass_in_v_vfp_candidate): Likewise.
4111
4112 2019-01-23  Tom Tromey  <tom@tromey.com>
4113             Pedro Alves  <palves@redhat.com>
4114
4115         * regcache.c (class regcache_invalidator): Remove.
4116         (regcache::raw_write): Use make_scope_exit.
4117
4118 2019-01-23  Tom Tromey  <tom@tromey.com>
4119
4120         * ui-out.h (class ui_out_emit_type): Update comment.
4121
4122 2019-01-23  Tom Tromey  <tom@tromey.com>
4123
4124         * infrun.c (fetch_inferior_event): Update comment.
4125
4126 2019-01-23  Tom Tromey  <tom@tromey.com>
4127             Pedro Alves  <palves@redhat.com>
4128
4129         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4130         parameter.
4131         (fetch_inferior_event): Use SCOPE_EXIT.
4132
4133
4134 2019-01-23  Tom Tromey  <tom@tromey.com>
4135             Pedro Alves  <palves@redhat.com>
4136
4137         * infrun.c (disable_thread_events): Delete.
4138         (stop_all_threads): Use SCOPE_EXIT.
4139
4140 2019-01-23  Tom Tromey  <tom@tromey.com>
4141             Pedro Alves  <palves@redhat.com>
4142
4143         * symfile.c: Include forward-scope-exit.h.
4144         (clear_symtab_users_cleanup): Replace forward declaration with
4145         a FORWARD_SCOPE_EXIT.
4146         (syms_from_objfile_1): Use the forward_scope_exit and
4147         gdb::optional instead of cleanup_function.
4148         (reread_symbols): Use the forward_scope_exit instead of
4149         cleanup_function.
4150         (clear_symtab_users_cleanup): Remove function.
4151
4152 2019-01-23  Tom Tromey  <tom@tromey.com>
4153             Pedro Alves  <palves@redhat.com>
4154
4155         * linux-nat.c: Include scope-exit.h.
4156         (cleanup_target_stop): Remove.
4157         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4158         SCOPE_EXIT.
4159
4160 2019-01-23  Tom Tromey  <tom@tromey.com>
4161             Pedro Alves  <palves@redhat.com>
4162
4163         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4164         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4165
4166 2019-01-23  Tom Tromey  <tom@tromey.com>
4167             Andrew Burgess  <andrew.burgess@embecosm.com>
4168             Pedro Alves  <palves@redhat.com>
4169
4170         * infrun.c (fetch_inferior_event): Use scope_exit.
4171         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4172         * top.c (execute_command): Use scope_exit.
4173         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4174         * utils.c (do_bpstat_clear_actions_cleanup)
4175         (make_bpstat_clear_actions_cleanup): Remove.
4176
4177 2019-01-23  Tom Tromey  <tom@tromey.com>
4178             Pedro Alves  <palves@redhat.com>
4179
4180         * infrun.c: Include "common/scope-exit.h"
4181         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4182         (wait_for_inferior): Use SCOPE_EXIT.
4183         (fetch_inferior_event): Use scope_exit.
4184
4185 2019-01-23  Tom Tromey  <tom@tromey.com>
4186             Pedro Alves  <palves@redhat.com>
4187
4188         * breakpoint.c (create_breakpoint): Remove cleanup.
4189
4190 2019-01-23  Tom Tromey  <tom@tromey.com>
4191             Andrew Burgess  <andrew.burgess@embecosm.com>
4192             Pedro Alves  <palves@redhat.com>
4193
4194 2019-01-23  Pedro Alves  <palves@redhat.com>
4195
4196         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4197
4198 2019-01-23  Pedro Alves  <palves@redhat.com>
4199             Andrew Burgess  <andrew.burgess@embecosm.com>
4200
4201         * gdbthread.h: Include "common/forward-scope-exit.h".
4202         (scoped_finish_thread_state): Redefine custom class in terms of
4203         forward_scope_exit.
4204
4205 2019-01-23  Pedro Alves  <palves@redhat.com>
4206             Andrew Burgess  <andrew.burgess@embecosm.com>
4207
4208         * common/forward-scope-exit.h: New file.
4209
4210 2019-01-23  Pedro Alves  <palves@redhat.com>
4211             Andrew Burgess  <andrew.burgess@embecosm.com>
4212             Tom Tromey  <tom@tromey.com>
4213
4214         * common/scope-exit.h: New file.
4215
4216 2019-01-23  Pedro Alves  <palves@redhat.com>
4217
4218         * common/preprocessor.h (ESC): Rename to ...
4219         (ESC_PARENS): ... this.
4220         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4221         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4222
4223 2019-01-23  Tom Tromey  <tom@tromey.com>
4224
4225         * language.h (class scoped_switch_to_sym_language_if_auto):
4226         Initialize m_lang in both cases.
4227
4228 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4229
4230         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4231         with XCNEW.
4232
4233 2019-01-22  Tom Tromey  <tom@tromey.com>
4234
4235         * corelow.c: Do not include sys/file.h.
4236
4237 2019-01-22  Tom Tromey  <tom@tromey.com>
4238
4239         * tui/tui-wingeneral.h: Include gdb_curses.h.
4240
4241 2019-01-22  Tom Tromey  <tom@tromey.com>
4242
4243         * source-cache.h (class source_cache) <get_source_lines,
4244         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4245
4246 2019-01-22  Tom Tromey  <tom@tromey.com>
4247
4248         * remote-fileio.h (struct remote_target): Declare.
4249
4250 2019-01-22  Tom Tromey  <tom@tromey.com>
4251
4252         * python/py-arch.c: Do not include py-ref.h.
4253         * python/py-bpevent.c: Do not include py-ref.h.
4254         * python/py-cmd.c: Do not include py-ref.h.
4255         * python/py-continueevent.c: Do not include py-ref.h.
4256         * python/py-event.h: Do not include py-ref.h.
4257         * python/py-evtregistry.c: Do not include py-ref.h.
4258         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4259         * python/py-frame.c: Do not include py-ref.h.
4260         * python/py-framefilter.c: Do not include py-ref.h.
4261         * python/py-function.c: Do not include py-ref.h.
4262         * python/py-infevents.c: Do not include py-ref.h.
4263         * python/py-linetable.c: Do not include py-ref.h.
4264         * python/py-objfile.c: Do not include py-ref.h.
4265         * python/py-param.c: Do not include py-ref.h.
4266         * python/py-prettyprint.c: Do not include py-ref.h.
4267         * python/py-progspace.c: Do not include py-ref.h.
4268         * python/py-symbol.c: Do not include py-ref.h.
4269         * python/py-symtab.c: Do not include py-ref.h.
4270         * python/py-type.c: Do not include py-ref.h.
4271         * python/py-unwind.c: Do not include py-ref.h.
4272         * python/py-utils.c: Do not include py-ref.h.
4273         * python/py-value.c: Do not include py-ref.h.
4274         * python/py-varobj.c: Do not include py-ref.h.
4275         * python/py-xmethods.c: Do not include py-ref.h.
4276         * python/python.c: Do not include py-ref.h.
4277         * varobj.c: Do not include py-ref.h.
4278
4279 2019-01-22  Tom Tromey  <tom@tromey.com>
4280
4281         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4282         keyword for bcache.
4283
4284 2019-01-22  Tom Tromey  <tom@tromey.com>
4285
4286         * compile/compile-cplus-types.c: Remove a comment by #include.
4287
4288 2019-01-22  Tom Tromey  <tom@tromey.com>
4289
4290         * compile/gcc-c-plugin.h: Include compile-internal.h.
4291
4292 2019-01-22  Tom Tromey  <tom@tromey.com>
4293
4294         * stabsread.c (EXTERN): Do not define.
4295         (symnum, next_symbol_text_func, processing_gcc_compilation)
4296         (within_function, global_sym_chain, global_stabs)
4297         (previous_stab_code, this_object_header_files)
4298         (n_this_object_header_files)
4299         (n_allocated_this_object_header_files): Define.
4300         * stabsread.h (EXTERN): Never define.  Use "extern".
4301
4302 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4303
4304         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4305         history_value.
4306
4307 2019-01-21  Tom Tromey  <tom@tromey.com>
4308
4309         * ui-out.c: Fix includes.
4310         * tui/tui-source.c: Fix includes.
4311         * target.c: Fix includes.
4312         * remote.c: Fix includes.
4313         * regcache.c: Fix includes.
4314         * python/py-block.c: Fix includes.
4315         * printcmd.c: Fix includes.
4316         * or1k-tdep.c: Fix includes.
4317         * mi/mi-main.c: Fix includes.
4318         * m32r-tdep.c: Fix includes.
4319         * csky-tdep.c: Fix includes.
4320         * compile/compile-cplus-types.c: Fix includes.
4321         * cli/cli-interp.c: Fix includes.
4322
4323 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4324
4325         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4326         for padding.
4327
4328 2019-01-16  Tom Tromey  <tom@tromey.com>
4329
4330         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4331         earlier.
4332         (struct objfile) <msymbols_range>: Move from top level.
4333         <msymbols>: New method.
4334         (class objfile_msymbols): Remove.
4335         * symtab.c (default_collect_symbol_completion_matches_break_on):
4336         Update.
4337         * symmisc.c (dump_msymbols): Update.
4338         * stabsread.c (scan_file_globals): Update.
4339         * objc-lang.c (info_selectors_command, info_classes_command)
4340         (find_methods): Update.
4341         * minsyms.c (find_solib_trampoline_target): Update.
4342         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4343         * coffread.c (coff_symfile_read): Update.
4344         * ada-lang.c (ada_lookup_simple_minsym)
4345         (ada_collect_symbol_completion_matches): Update.
4346
4347 2019-01-16  Tom Tromey  <tom@tromey.com>
4348
4349         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4350         type.  Remove no-argument constructor.
4351         <iterator::operator++>: Simplify.
4352         <begin>: Update.
4353         <end>: Use minimal_symbol_count.
4354
4355 2019-01-16  Tom Tromey  <tom@tromey.com>
4356
4357         * objfiles.h (struct objfile) <psymtabs>: New method.
4358         (class objfile_psymtabs): Remove.
4359         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4360         typedef.
4361         <range>: New method.
4362         (require_partial_symbols): Change return type.
4363         * psymtab.c (require_partial_symbols)
4364         (psym_expand_symtabs_matching): Update.
4365         * mdebugread.c (parse_partial_symbols): Update.
4366         * dbxread.c (dbx_end_psymtab): Update.
4367
4368 2019-01-15  Tom Tromey  <tom@tromey.com>
4369
4370         * symtab.c (lookup_objfile_from_block)
4371         (lookup_symbol_in_objfile_symtabs)
4372         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4373         (find_line_symtab, info_sources_command)
4374         (default_collect_symbol_completion_matches_break_on)
4375         (make_source_files_completion_list): Update.
4376         * symmisc.c (print_objfile_statistics, dump_objfile)
4377         (maintenance_print_symbols, maintenance_info_symtabs)
4378         (maintenance_check_symtabs, maintenance_info_line_tables):
4379         Update.
4380         * source.c (select_source_symtab)
4381         (forget_cached_source_info_for_objfile): Update.
4382         * objfiles.h (class objfile_compunits): Remove.
4383         (struct objfile) <compunits_range>: New typedef.
4384         (compunits): New method.
4385         * objfiles.c (objfile_relocate1): Update.
4386         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4387         * maint.c (count_symtabs_and_blocks): Update.
4388         * linespec.c (iterate_over_all_matching_symtabs): Update.
4389         * cp-support.c (add_symbol_overload_list_qualified): Update.
4390         * coffread.c (coff_symtab_read): Update.
4391         * ada-lang.c (add_nonlocal_symbols)
4392         (ada_collect_symbol_completion_matches)
4393         (ada_add_global_exceptions): Update.
4394
4395 2019-01-15  Tom Tromey  <tom@tromey.com>
4396
4397         * progspace.h (program_space) <objfiles_safe_range>: New
4398         typedef.
4399         <objfiles_safe>: New method.
4400         * objfiles.h (class all_objfiles_safe): Remove.
4401         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4402         * jit.c (jit_inferior_exit_hook): Update.
4403
4404 2019-01-17  Tom Tromey  <tom@tromey.com>
4405
4406         * progspace.h (program_space) <objfiles_range>: New typedef.
4407         <objfiles>: New method.
4408         <objfiles_head>: Rename from objfiles.
4409         (object_files): Update.
4410         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4411         * guile/scm-pretty-print.c
4412         (ppscm_find_pretty_printer_from_objfiles): Update.
4413         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4414         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4415         Update.
4416         * python/py-progspace.c (pspy_get_objfiles): Update.
4417         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4418         Update.
4419         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4420         (objfpy_lookup_objfile_by_build_id): Update.
4421         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4422         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4423         Update.
4424         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4425         (expand_symtab_containing_pc, lookup_objfile_from_block)
4426         (lookup_static_symbol, basic_lookup_transparent_type)
4427         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4428         (find_line_symtab, info_sources_command)
4429         (default_collect_symbol_completion_matches_break_on)
4430         (make_source_files_completion_list, find_main_name): Update.
4431         * symmisc.c (print_symbol_bcache_statistics)
4432         (print_objfile_statistics, maintenance_print_symbols)
4433         (maintenance_print_msymbols, maintenance_print_objfiles)
4434         (maintenance_info_symtabs, maintenance_check_symtabs)
4435         (maintenance_expand_symtabs, maintenance_info_line_tables):
4436         Update.
4437         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4438         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4439         (map_overlay_command, unmap_overlay_command)
4440         (simple_overlay_update, expand_symtabs_matching)
4441         (map_symbol_filenames): Update.
4442         * symfile-debug.c (set_debug_symfile): Update.
4443         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4444         Update.
4445         * source.c (select_source_symtab, forget_cached_source_info):
4446         Update.
4447         * solib.c (solib_read_symbols): Update.
4448         * solib-spu.c (append_ocl_sos): Update.
4449         * psymtab.c (maintenance_print_psymbols)
4450         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4451         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4452         * printcmd.c (info_symbol_command): Update.
4453         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4454         Update.
4455         * objfiles.h (class all_objfiles): Remove.
4456         * objfiles.c (have_partial_symbols, have_full_symbols)
4457         (have_minimal_symbols, qsort_cmp, update_section_map)
4458         (shared_objfile_contains_address_p)
4459         (default_iterate_over_objfiles_in_search_order): Update.
4460         * objc-lang.c (info_selectors_command, info_classes_command)
4461         (find_methods): Update.
4462         * minsyms.c (find_solib_trampoline_target): Update.
4463         * maint.c (maintenance_info_sections)
4464         (maintenance_translate_address, count_symtabs_and_blocks):
4465         Update.
4466         * main.c (captured_main_1): Update.
4467         * linux-thread-db.c (try_thread_db_load_from_pdir)
4468         (has_libpthread): Update.
4469         * linespec.c (iterate_over_all_matching_symtabs)
4470         (search_minsyms_for_name): Update.
4471         * jit.c (jit_find_objf_with_entry_addr): Update.
4472         * hppa-tdep.c (find_unwind_entry)
4473         (hppa_lookup_stub_minimal_symbol): Update.
4474         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4475         Update.
4476         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4477         (elf_gnu_ifunc_resolve_by_got): Update.
4478         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4479         * dwarf-index-write.c (save_gdb_index_command): Update.
4480         * cp-support.c (add_symbol_overload_list_qualified): Update.
4481         * breakpoint.c (create_overlay_event_breakpoint)
4482         (create_longjmp_master_breakpoint)
4483         (create_std_terminate_master_breakpoint)
4484         (create_exception_master_breakpoint): Update.
4485         * blockframe.c (find_pc_partial_function): Update.
4486         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4487         (ada_collect_symbol_completion_matches)
4488         (ada_add_global_exceptions): Update.
4489
4490 2019-01-17  Tom Tromey  <tom@tromey.com>
4491
4492         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4493         declare VEC.
4494         (solib_target_parse_libraries): Change return type.
4495         (library_list_start_segment, library_list_start_section)
4496         (library_list_end_library, library_list_start_library); Update.
4497         (solib_target_free_library_list): Remove.
4498         (solib_target_parse_libraries): Remove cleanup.  Change return
4499         type.
4500         (solib_target_current_sos): Update.
4501
4502 2019-01-17  Tom Tromey  <tromey@bapiya>
4503
4504         * valprint.c: Replace "the the" with "the".
4505         * symtab.c: Replace "the the" with "the".
4506         * solib.c: Replace "the the" with "the".
4507         * solib-dsbt.c: Replace "the the" with "the".
4508         * linespec.c: Replace "the the" with "the".
4509         * dwarf2loc.h: Replace "the the" with "the".
4510         * amd64-windows-tdep.c: Replace "the the" with "the".
4511         * aarch64-tdep.c: Replace "the the" with "the".
4512
4513 2019-01-16  Keith Seitz  <keiths@redhat.com>
4514
4515         PR gdb/23773
4516         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4517         <builder>: Rename to ..
4518         <m_builder>: ... this and make private.
4519         (dwarf2_cu::get_builder): New method.  Change all users of
4520         `builder' to use this method.
4521         (dwarf2_start_symtab): Move to ...
4522         (dwarf2_cu::start_symtab): ... here.  Update all callers
4523         (setup_type_unit_groups): Move to ...
4524         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4525         callers.
4526         (dwarf2_cu::reset_builder): New method.
4527         (process_full_compunit, process_full_type_unit): Use
4528         dwarf2_cu::reset_builder.
4529         (follow_die_offset): Record the ancestor CU if it is different
4530         from the followed DIE's CU.
4531         (follow_die_sig_1): Likewise.
4532
4533 2019-01-15  Tom Tromey  <tom@tromey.com>
4534
4535         * remote.c (class remote_state) <buf>: Now a char_vector.
4536         <buf_size>: Remove.
4537         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4538         parameter.
4539         (remote_target::getpkt_or_notif_sane_1)
4540         (remote_target::getpkt_sane)
4541         (remote_target::getpkt_or_notif_sane): Likewise.
4542         (class remote_target) <putpkt>: New overload.
4543         (remote_target::read_frame): Change type of "buf_p".  Remove
4544         sizeof_p parameter.
4545         (packet_ok): New overload.
4546         (packet_check_result): New overload.
4547         Update all uses.
4548
4549 2019-01-14  Tom Tromey  <tom@tromey.com>
4550
4551         * remote-notif.c (handle_notification, remote_notif_ack)
4552         (remote_notif_parse): Make "buf" const.
4553         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4554         const.
4555         (remote_notif_parse, remote_notif_ack, handle_notification):
4556         Likewise.
4557         * remote.c (remote_notif_stop_parse): Make "buf" const.
4558         (remote_target::remote_parse_stop_reply): Make "buf" const.
4559         (remote_notif_stop_ack): Make "buf" const.
4560
4561 2019-01-14  Tom Tromey  <tom@tromey.com>
4562
4563         * remote.c (remote_console_output): Make parameter const.
4564
4565 2019-01-14  Tom Tromey  <tom@tromey.com>
4566
4567         * target-debug.h (target_debug_print_signals): Constify.
4568         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4569         * procfs.c (procfs_target::pass_signals): Update.
4570         * linux-nat.c (linux_nat_target::pass_signals): Update.
4571         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4572         * target-delegates.c: Rebuild.
4573         * remote.c (remote_target::program_signals): Update.
4574         (remote_target::pass_signals): Update.
4575         * target.c (target_pass_signals): Constify argument.
4576         (target_program_signals): Likewise.
4577         * target.h (struct target_ops) <pass_signals, program_signals>:
4578         Constify argument.
4579         (target_pass_signals, target_program_signals): Constify argument.
4580
4581 2019-01-14  Tom Tromey  <tom@tromey.com>
4582
4583         PR tui/28819:
4584         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4585
4586 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4587
4588         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4589         field.
4590         * rs6000-tdep.c: Include reggroups.h.
4591         (IS_V_ALIAS_PSEUDOREG): Define.
4592         (rs6000_register_name): Return names for the "vX" aliases.
4593         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4594         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4595         aliases.  Call default_register_reggroup_p for all other
4596         pseudo-registers.
4597         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4598         New functions.
4599         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4600         Handle "vX" aliases.
4601         (v_alias_pseudo_register_collect): New function.
4602         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4603         (rs6000_gdbarch_init): Initialize "vX" aliases as
4604         pseudo-registers.  Restore registration of
4605         rs6000_pseudo_register_reggroup_p with
4606         set_tdesc_pseudo_register_reggroup_p.
4607
4608 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4609
4610         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4611         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4612         set_gdbarch_num_pseudo_regs.
4613
4614 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4615
4616         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4617         Remove arg prefixname, add do_set and do_show.
4618         Add member functions set_list and show_list.
4619         * cli/cli-style.c (class cli_style_option): Update accordingly.
4620         (style_set_list): Move to file scope.
4621         (style_show_list): Likewise.
4622         (set_style): Call help_list.
4623         (show_style): Call cmd_show_list.
4624         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4625         Update to use the new macro.
4626
4627 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4628
4629         * ada-lang.c (_initialize_ada_language): Expand the help text
4630         for the "catch exception" command.
4631
4632 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4633
4634         * symtab.c (matching_obj_sections): Initialize obj,
4635         declare it closer to its usage.
4636
4637 2019-01-10  Tom Tromey  <tom@tromey.com>
4638
4639         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4640         (basic_inf_threads_range): Remove.
4641         (inf_threads_range, inf_non_exited_threads_range)
4642         (safe_inf_threads_range): Use next_adapter.
4643
4644 2019-01-10  Keith Seitz  <keiths@redhat.com>
4645
4646         PR gdb/23712
4647         PR symtab/23010
4648         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4649         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4650
4651 2019-01-10  Keith Seitz  <keiths@redhat.com>
4652
4653         PR gdb/23712
4654         PR symtab/23010
4655         * dictionary.c (pending_to_vector): Remove.
4656         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4657         Remove _1 suffix, replacing functions of the same name.  Update
4658         all callers.
4659         (dict_create_hashed, dict_create_hashed_expandable)
4660         (dict_create_linear, dict_create_linear_expandable, dict_free)
4661         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4662         Make functions static.
4663
4664 2019-01-10  Keith Seitz  <keiths@redhat.com>
4665
4666         PR gdb/23712
4667         PR symtab/23010
4668         * dictionary.h (struct dictionary): Replace declaration with
4669         multidictionary.
4670         (dict_create_hashed, dict_create_hashed_expandable)
4671         (dict_create_linear, dict_create_linear_expandable)
4672         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4673         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4674         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4675         taking multidictionary argument.
4676         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4677         * block.h (struct block) <dict>: Change to multidictionary
4678         and rename `multidict'.
4679         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4680         symmisc.c: Update all dictionary references to multidictionary.
4681
4682 2019-01-10  Keith Seitz  <keiths@redhat.com>
4683
4684         PR gdb/23712
4685         PR symtab/23010
4686         * dictionary.c: Include unordered_map.
4687         (pending_to_vector): New function.
4688         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4689         Rewrite the non-"_1" functions to take vector instead
4690         of linked list.
4691         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4692         "new" _1 versions of the same name.
4693         (multidictionary): Define.
4694         (std::hash<enum language): New definition.
4695         (collate_pending_symbols_by_language, mdict_create_hashed)
4696         (mdict_create_hashed_expandable, mdict_create_linear)
4697         (mdict_create_linear_expandable, mdict_free)
4698         (find_language_dictionary, create_new_language_dictionary)
4699         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4700         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4701         (mdict_size, mdict_empty): New functions.
4702         * dictionary.h (mdict_iterator): Define.
4703
4704 2019-01-10  Pedro Alves  <palves@redhat.com>
4705
4706         * breakpoint.c (read_uploaded_action)
4707         (create_tracepoint_from_upload): Adjust to use
4708         gdb::unique_xmalloc_ptr.
4709         * ctf.c (ctf_write_uploaded_tp):
4710         (SET_ARRAY_FIELD): Use emplace_back.
4711         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4712         * tracefile-tfile.c (tfile_write_uploaded_tp):
4713         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4714         gdb::unique_xmalloc_ptr.
4715         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4716         at_string, cond_string, cmd_strings>: Replace char pointers
4717         with gdb::unique_xmalloc_ptr.
4718
4719 2019-01-10  Pedro Alves  <palves@redhat.com>
4720
4721         * solib-target.c (library_list_start_library): Don't xstrdup name.
4722
4723 2019-01-10  Pedro Alves  <palves@redhat.com>
4724
4725         * mdebugread.c (parse_partial_symbols): Use
4726         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4727
4728 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4729
4730         * linux-fork.c (scoped_switch_fork_info)
4731         <~scoped_switch_fork_info>: Fix incorrect variable name.
4732
4733 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4734
4735         * linux-fork.c (scoped_switch_fork_info)
4736         <scoped_switch_fork_info>: Make explicit.
4737         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4738
4739 2019-01-10  Tom Tromey  <tom@tromey.com>
4740
4741         * objfiles.h (objfile::reset_psymtabs): Update.
4742         * objfiles.c (objfile::objfile): Update.
4743         * psymtab.h (psymtab_storage::obstack): Update.
4744         (psymtab_storage::m_obstack): Use gdb::optional.
4745         (class psymtab_storage): Update comment.  Remove objfile
4746         parameter.
4747         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4748
4749 2019-01-10  Tom Tromey  <tom@tromey.com>
4750
4751         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4752         <free_psymtabs>: Now private.
4753         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4754         (allocate_psymtab): Use new method.
4755
4756 2019-01-10  Tom Tromey  <tom@tromey.com>
4757
4758         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4759         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4760         * mdebugread.c (parse_partial_symbols): Use
4761         allocate_dependencies.
4762         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4763         allocate_dependencies.
4764         (process_psymtab_comp_unit_reader)
4765         (build_type_psymtab_dependencies): Likewise.
4766         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4767
4768 2019-01-10  Tom Tromey  <tom@tromey.com>
4769
4770         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4771         PSYMBOL_SET_LANGUAGE.
4772         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4773
4774 2019-01-10  Tom Tromey  <tom@tromey.com>
4775
4776         * psymtab.h (psymtab_storage::obstack): New method.
4777         <m_obstack>: Rename from obstack; now private.
4778         * psymtab.c (psymtab_storage): Update.
4779         * dwarf2read.c (create_addrmap_from_index)
4780         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4781         Update.
4782
4783 2019-01-10  Tom Tromey  <tom@tromey.com>
4784
4785         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4786         * objfiles.h (objfile::reset_psymtabs): New method.
4787
4788 2019-01-10  Tom Tromey  <tom@tromey.com>
4789
4790         * symmisc.c (print_symbol_bcache_statistics): Update.
4791         (print_objfile_statistics): Update.
4792         * symfile.c (reread_symbols): Update.
4793         * psymtab.h (class psymtab_storage): New.
4794         * psymtab.c (psymtab_storage): New constructor.
4795         (~psymtab_storage): New destructor.
4796         (require_partial_symbols): Update.
4797         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4798         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4799         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4800         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4801         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4802         (start_psymtab_common, end_psymtab_common)
4803         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4804         (allocate_psymtab): Update.
4805         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4806         Update.
4807         (dump_psymtab_addrmap, maintenance_print_psymbols)
4808         (maintenance_check_psymtabs): Update.
4809         (class objfile_psymtabs): Move to objfiles.h.
4810         * psympriv.h (discard_psymtab): Now inline.
4811         (psymtab_discarder::psymtab_discarder): Update.
4812         (psymtab_discarder::~psymtab_discarder): Update.
4813         (ALL_OBJFILE_PSYMTABS): Rewrite.
4814         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4815         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4816         Remove fields.
4817         <partial_symtabs>: New field.
4818         (class objfile_psymtabs): Move from psymtab.h.  Update.
4819         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4820         psymbol_cache.
4821         (objfile::~objfile): Don't destroy psymbol_cache.
4822         * mdebugread.c (parse_partial_symbols): Update.
4823         * dwarf2read.c (create_addrmap_from_index)
4824         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4825         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4826         (add_partial_subprogram, dwarf2_ranges_read): Update.
4827         * dwarf-index-write.c (write_address_map)
4828         (write_one_signatured_type, recursively_write_psymbols)
4829         (class debug_names, class debug_names, write_psymtabs_to_index):
4830         Update.
4831
4832 2019-01-10  Tom Tromey  <tom@tromey.com>
4833
4834         * symtab.h (SYMBOL_SET_NAMES): Update.
4835         (symbol_set_names): Update.
4836         (MSYMBOL_SET_NAMES): Update.
4837         * symtab.c (symbol_set_names): Change argument to be an
4838         objfile_per_bfd_storage.
4839         * psymtab.c (add_psymbol_to_bcache): Update.
4840         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4841
4842 2019-01-10  Tom Tromey  <tom@tromey.com>
4843
4844         * symtab.c (create_demangled_names_hash): Change argument to be an
4845         objfile_per_bfd_storage.
4846         (symbol_set_names): Update.
4847
4848 2019-01-10  Tom Tromey  <tom@tromey.com>
4849
4850         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4851         init_psymbol_list.
4852         * psymtab.c (init_psymbol_list): Do nothing if already called.
4853         * psympriv.h (init_psymbol_list): Add comment.
4854         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4855         init_psymbol_list.
4856         * dbxread.c (dbx_symfile_read): Unconditionally call
4857         init_psymbol_list.
4858
4859 2019-01-10  Tom Tromey  <tom@tromey.com>
4860
4861         * xcoffread.c (scan_xcoff_symtab): Update.
4862         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4863         "where".
4864         * mdebugread.c (parse_partial_symbols)
4865         (handle_psymbol_enumerators): Update.
4866         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4867         * dbxread.c (read_dbx_symtab): Update.
4868         * psympriv.h (psymbol_placement): New enum.
4869         (add_psymbol_to_list): Update.
4870
4871 2019-01-10  Tom Tromey  <tom@tromey.com>
4872
4873         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4874         static_psymbols parameters.
4875         (scan_xcoff_symtab): Update.
4876         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4877         static_psymbols parameters.
4878         * psympriv.h (start_psymtab_common): Update.
4879         * mdebugread.c (parse_partial_symbols): Update.
4880         * dwarf2read.c (create_partial_symtab): Update.
4881         * dbxread.c (read_dbx_symtab): Update.
4882         (start_psymtab): Remove global_psymbols and static_psymbols
4883         parameters.
4884
4885 2019-01-10  Tom Tromey  <tom@tromey.com>
4886
4887         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4888         * psymtab.c (allocate_psymtab): Add comment.
4889         * psympriv.h (allocate_psymtab): Add comment.
4890         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4891         initializations.
4892         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4893
4894 2019-01-10  Tom Tromey  <tom@tromey.com>
4895
4896         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4897         Don't declare.
4898         * mipsread.c: Include mdebugread.h.
4899         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4900         Declare.
4901         * elfread.c: Include mdebugread.h.
4902
4903 2019-01-09  Tom Tromey  <tom@tromey.com>
4904
4905         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4906         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4907         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4908         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4909         (psym_lookup_symbol, psym_find_last_source_symtab)
4910         (psym_forget_cached_source_info, psym_print_stats)
4911         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4912         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4913         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4914         (psym_find_compunit_symtab_by_address)
4915         (maintenance_print_psymbols, maintenance_info_psymtabs)
4916         (maintenance_check_psymtabs): Use ranged for.
4917         * psymtab.h (class objfile_psymtabs): New.
4918         (require_partial_symbols): Return objfile_psymtabs.
4919         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4920
4921 2019-01-09  Tom Tromey  <tom@tromey.com>
4922
4923         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4924         (find_pc_mapped_section, list_overlays_command)
4925         (map_overlay_command, unmap_overlay_command)
4926         (simple_overlay_update): Use all_objfiles.
4927         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4928         * printcmd.c (info_symbol_command): Use all_objfiles.
4929         * objfiles.h (ALL_OBJSECTIONS): Remove.
4930         * maint.c (maintenance_translate_address): Use all_objfiles.
4931         * gcore.c (gcore_create_callback): Use all_objfiles.
4932         (objfile_find_memory_regions): Likewise.
4933
4934 2019-01-09  Tom Tromey  <tom@tromey.com>
4935
4936         * symtab.c (find_line_symtab, info_sources_command)
4937         (make_source_files_completion_list): Use objfile_compunits.
4938         * source.c (select_source_symtab): Use objfile_compunits.
4939         * objfiles.h (struct objfile): Update comment.
4940         (ALL_OBJFILES): Remove.
4941         (ALL_FILETABS): Remove.
4942         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4943         objfile_compunits.
4944
4945 2019-01-09  Tom Tromey  <tom@tromey.com>
4946
4947         * symmisc.c (print_objfile_statistics, dump_objfile)
4948         (maintenance_print_symbols): Use compunit_filetabs.
4949         * source.c (forget_cached_source_info_for_objfile): Use
4950         compunit_filetabs.
4951         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4952         (ALL_FILETABS): Use compunit_filetabs.
4953         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4954         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4955
4956 2019-01-09  Tom Tromey  <tom@tromey.com>
4957
4958         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4959         (compunit_filetabs): New.
4960         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4961         compunit_filetabs.
4962         (info_sources_command, make_source_files_completion_list): Remove
4963         declaration.
4964         * symmisc.c (print_objfile_statistics, dump_objfile)
4965         (maintenance_print_symbols): Remove declaration.
4966         (maintenance_info_symtabs): Use compunit_filetabs.
4967         (maintenance_info_line_tables): Likewise.
4968         * source.c (select_source_symtab): Change local variable name.
4969         (forget_cached_source_info_for_objfile): Remove declaration.
4970         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4971         * objfiles.c (objfile_relocate1): Remove declaration.
4972         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4973         declaration.
4974         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4975         * coffread.c (coff_symtab_read): Remove declaration.
4976         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4977         compunit_filetabs.
4978
4979 2019-01-09  Tom Tromey  <tom@tromey.com>
4980
4981         * symtab.c (lookup_objfile_from_block)
4982         (find_pc_sect_compunit_symtab, search_symbols)
4983         (default_collect_symbol_completion_matches_break_on): Use
4984         objfile_compunits.
4985         * objfiles.h (ALL_COMPUNITS): Remove.
4986         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4987         * cp-support.c (add_symbol_overload_list_qualified): Use
4988         objfile_compunits.
4989         * ada-lang.c (ada_collect_symbol_completion_matches)
4990         (ada_add_global_exceptions): Use objfile_compunits.
4991
4992 2019-01-09  Tom Tromey  <tom@tromey.com>
4993
4994         * source.c (select_source_symtab)
4995         (forget_cached_source_info_for_objfile): Remove declaration.
4996         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4997         declaration.
4998         * maint.c (count_symtabs_and_blocks): Remove declaration.
4999         * cp-support.c (add_symbol_overload_list_qualified): Remove
5000         declaration.
5001         * coffread.c (coff_symtab_read): Remove declaration.
5002         * symtab.c (lookup_symbol_in_objfile_symtabs)
5003         (basic_lookup_transparent_type_1): Use objfile_compunits.
5004         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5005         (info_sources_command, search_symbols)
5006         (default_collect_symbol_completion_matches_break_on)
5007         (make_source_files_completion_list): Remove declaration.
5008         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5009         (ada_collect_symbol_completion_matches)
5010         (ada_add_global_exceptions): Remove declaration.
5011         * linespec.c (iterate_over_all_matching_symtabs): Use
5012         objfile_compunits.
5013         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5014         (class objfile_compunits): New.
5015         (ALL_COMPUNITS): Use objfile_compunits.
5016         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5017         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5018         objfile_compunits.
5019         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5020
5021 2019-01-09  Tom Tromey  <tom@tromey.com>
5022
5023         * symtab.c (search_symbols)
5024         (default_collect_symbol_completion_matches_break_on): Use
5025         objfile_msymbols.
5026         * ada-lang.c (ada_lookup_simple_minsym)
5027         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5028         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5029         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5030         objfile_msymbols.
5031         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5032         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5033         * objc-lang.c (find_methods): Use objfile_msymbols.
5034         (info_selectors_command, info_classes_command): Likewise.
5035         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5036         * objfiles.h (class objfile_msymbols): New.
5037         (ALL_OBJFILE_MSYMBOLS): Remove.
5038         (ALL_MSYMBOLS): Remove.
5039
5040 2019-01-09  Tom Tromey  <tom@tromey.com>
5041
5042         * common/next-iterator.h (next_adapter): Add Iterator template
5043         parameter.
5044         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5045         (class all_objfiles_safe): New.
5046         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5047         * objfiles.c (put_objfile_before): Update comment.
5048         (add_separate_debug_objfile): Likewise.
5049         (free_all_objfiles): Use all_objfiles_safe.
5050         (objfile_purge_solibs): Likewise.
5051
5052 2019-01-09  Tom Tromey  <tom@tromey.com>
5053
5054         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5055         (expand_symtab_containing_pc, lookup_static_symbol)
5056         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5057         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5058         all_objfiles.
5059         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5060         * breakpoint.c (create_overlay_event_breakpoint)
5061         (create_longjmp_master_breakpoint)
5062         (create_std_terminate_master_breakpoint)
5063         (create_exception_master_breakpoint): Use all_objfiles.
5064         * linux-thread-db.c (try_thread_db_load_from_pdir)
5065         (has_libpthread): Use all_objfiles.
5066         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5067         * linespec.c (iterate_over_all_matching_symtabs)
5068         (search_minsyms_for_name): Use all_objfiles.
5069         * maint.c (maintenance_info_sections): Use all_objfiles.
5070         * main.c (captured_main_1): Use all_objfiles.
5071         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5072         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5073         * guile/scm-pretty-print.c
5074         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5075         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5076         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5077         (maintenance_print_msymbols): Use all_objfiles.
5078         * source.c (select_source_symtab): Use all_objfiles.
5079         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5080         * symfile.c (remove_symbol_file_command)
5081         (expand_symtabs_matching, map_symbol_filenames): Use
5082         all_objfiles.
5083         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5084         all_objfiles.
5085         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5086         * objc-lang.c (find_methods): Use all_objfiles.
5087         * objfiles.c (have_partial_symbols, have_full_symbols)
5088         (have_minimal_symbols, qsort_cmp)
5089         (default_iterate_over_objfiles_in_search_order): Use
5090         all_objfiles.
5091         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5092         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5093         (maintenance_check_psymtabs): Use all_objfiles.
5094         (ALL_PSYMTABS): Remove.
5095         * compile/compile-object-run.c (do_module_cleanup): Use
5096         all_objfiles.
5097         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5098         * cp-support.c (add_symbol_overload_list_qualified): Use
5099         all_objfiles.
5100         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5101         Use all_objfiles.
5102         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5103         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5104         all_objfiles.
5105         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5106         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5107         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5108         Uses all_objfiles.
5109         * solib.c (solib_read_symbols): Use all_objfiles
5110
5111 2019-01-09  Tom Tromey  <tom@tromey.com>
5112
5113         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5114         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5115         all_objfiles.
5116         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5117         * symmisc.c (print_symbol_bcache_statistics)
5118         (print_objfile_statistics, maintenance_print_objfiles)
5119         (maintenance_info_symtabs, maintenance_check_symtabs)
5120         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5121         all_objfiles.
5122         * source.c (forget_cached_source_info): Use all_objfiles.
5123         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5124         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5125         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5126         * objfiles.c (update_section_map): Use all_objfiles.
5127         (shared_objfile_contains_address_p): Likewise.
5128         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5129         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5130
5131 2019-01-09  Tom Tromey  <tom@tromey.com>
5132
5133         * common/next-iterator.h: New file.
5134         * objfiles.h (class all_objfiles): New.
5135         (struct objfile_iterator): New.
5136
5137 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5138
5139         * NEWS: Move the description of the changed "frame", "select-frame",
5140          and "info frame" commands to the Changed commands section.
5141
5142 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5143
5144         * gdbtypes.c (check_stub_method_group): Remove handling of old
5145         mangling schemes.
5146         * linespec.c (find_methods): Likewise.
5147         * stabsread.c (read_member_functions): Likewise.
5148         * valops.c (search_struct_method): Likewise.
5149         (value_struct_elt_for_reference): Likewise.
5150         * NEWS: Mention this change.
5151
5152 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5153
5154         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5155         print_source_lines.
5156         * source.c (print_source_lines_base): Update line number check.
5157         (print_source_lines): New function.
5158         (source_lines_range::source_lines_range): New function.
5159         * source.h (class source_lines_range): New class.
5160         (print_source_lines): New declaration.
5161
5162 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5163
5164         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5165
5166 2019-01-08  Tom Tromey  <tom@tromey.com>
5167             Simon Marchi  <simon.marchi@ericsson.com>
5168
5169         PR gdb/24060
5170         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5171         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5172         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5173         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5174         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5175         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5176
5177 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5178
5179         * source.c (select_source_symtab): Move header comment to
5180         declaration in source.h.
5181         (forget_cached_source_info_for_objfile): Likewise.
5182         (forget_cached_source_info): Likewise.
5183         (identify_source_line): Likewise.
5184         * source.h (identify_source_line): Move declaration from symtab.h
5185         and add comment from source.c
5186         (print_source_lines): Likewise.
5187         (forget_cached_source_info_for_objfile): Likewise.
5188         (forget_cached_source_info): Likewise.
5189         (select_source_symtab): Likewise.
5190         (enum print_source_lines_flag): Move definition from symtab.h.
5191         * symtab.h (identify_source_line): Move declaration to source.h.
5192         (print_source_lines): Likewise.
5193         (forget_cached_source_info_for_objfile): Likewise.
5194         (forget_cached_source_info): Likewise.
5195         (select_source_symtab): Likewise.
5196         (enum print_source_lines_flag): Move definition to source.h.
5197         * tui/tui-hooks.c: Add 'source.h' include.
5198
5199 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5200
5201         * source.c (print_source_lines_base): Handle requests to print
5202         reverse line number sequences, and guard against empty lines
5203         string.
5204
5205 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5206
5207         * source.c (print_source_lines_base): Fix skip of '\r' if next
5208         character is '\n'.
5209
5210 2019-01-06  Tom Tromey  <tom@tromey.com>
5211
5212         * c-exp.y (struct c_parse_state) <macro_original_text,
5213         expansion_obstack>: New member.
5214         (macro_original_text, expansion_obstack): Remove globals.
5215         (scan_macro_expansion, scanning_macro_expansion)
5216         (finished_macro_expansion): Update.
5217         (scan_macro_cleanup): Remove.
5218         (yylex, c_parse): Update.
5219
5220 2019-01-06  Tom Tromey  <tom@tromey.com>
5221
5222         * c-exp.y (struct c_parse_state) <strings>: New member.
5223         (operator_stoken): Update.
5224
5225 2019-01-06  Tom Tromey  <tom@tromey.com>
5226
5227         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5228         (union type_stack_elt) <typelist_val>: Now a pointer to
5229         std::vector.
5230         (type_stack_cleanup): Don't declare.
5231         (push_typelist): Update.
5232         * parse.c (pop_typelist): Return a std::vector.
5233         (push_typelist): Take a std::vector.
5234         (follow_types): Update.  Do not free args.
5235         (type_stack_cleanup): Remove.
5236         * c-exp.y (struct c_parse_state): New.
5237         (cpstate): New global.
5238         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5239         (nonempty_typelist): Update.
5240         (func_mod): Create a new vector.
5241         (c_parse): Create a c_parse_state.
5242         (check_parameter_typelist): Do not delete params.
5243         (function_method): Update.  Do not delete type_list.
5244
5245 2019-01-06  Tom Tromey  <tom@tromey.com>
5246
5247         PR gdb/28155:
5248         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5249         check_typedef.
5250         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5251         (print_return_value): Likewise.
5252
5253 2019-01-05  Tom Tromey  <tom@tromey.com>
5254
5255         * contrib/cleanup_check.py: Remove.
5256         * contrib/gcc-with-excheck: Remove.
5257         * contrib/exsummary.py: Remove.
5258         * contrib/excheck.py: Remove.
5259
5260 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5261
5262         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5263         NULL. Initialize tpprev to NULL instead of assigning it
5264         to NULL on the next statement.
5265         * windows-nat.c (windows_delete_thread): Remove check for
5266         main_thread_id before printing thread exit notifications.
5267         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5268         Remove thread ID check against main_thread_id.
5269         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5270         windows_delete_thread.
5271         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5272
5273 2019-01-04  Tom Tromey  <tom@tromey.com>
5274
5275         * compile/compile.c (_initialize_compile): Use upper case for
5276         metasyntactic variables.
5277         * symmisc.c (_initialize_symmisc): Use upper case for
5278         metasyntactic variables.
5279         * psymtab.c (_initialize_psymtab): Use upper case for
5280         metasyntactic variables.
5281         * demangle.c (demangle_command): Use upper case for metasyntactic
5282         variables.
5283         (_initialize_demangler): Likewise.
5284         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5285         variables.
5286
5287 2019-01-03  Tom Tromey  <tom@tromey.com>
5288
5289         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5290
5291 2019-01-03  Tom Tromey  <tom@tromey.com>
5292
5293         * python/py-symtab.c (salpy_str): Update.
5294         (struct salpy_sal_object) <symtab>: Now a PyObject.
5295         (salpy_dealloc): Update.
5296         (del_objfile_sal): Use gdbpy_ref.
5297
5298 2019-01-03  Tom Tromey  <tom@tromey.com>
5299
5300         * python/py-type.c (convert_field): Use new_reference.  Return
5301         gdbpy_ref.
5302         (make_fielditem): Return gdbpy_ref.
5303         (typy_fields): Update.
5304         (typy_getitem): Update.
5305         (field_name): Return gdbpy_ref.  Use new_reference.
5306         (typy_iterator_iternext): Update.
5307
5308 2019-01-03  Tom Tromey  <tom@tromey.com>
5309
5310         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5311
5312 2019-01-03  Tom Tromey  <tom@tromey.com>
5313
5314         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5315         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5316         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5317         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5318         (pspy_set_type_printers): Likewise.
5319         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5320         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5321         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5322         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5323         (objfpy_set_type_printers): Likewise.
5324
5325 2019-01-03  Tom Tromey  <tom@tromey.com>
5326
5327         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5328         (gdbpy_print_stack): Use gdbpy_err_fetch.
5329         * python/python-internal.h (class gdbpy_err_fetch): New class.
5330         (class gdbpy_enter) <m_error_type, m_error_value,
5331         m_error_traceback>: Remove.
5332         <m_error>: New member.
5333         (gdbpy_exception_to_string): Don't declare.
5334         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5335         * python/py-value.c (convert_value_from_python): Use
5336         gdbpy_err_fetch.
5337         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5338         gdbpy_exception_to_string.
5339         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5340         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5341         gdbpy_err_fetch.
5342
5343 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5344
5345         * linux-nat.c (delete_lwp_cleanup): Delete.
5346         (struct lwp_deleter): New struct.
5347         (lwp_info_up): New typedef.
5348         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5349         lwp_info_up.
5350
5351 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5352
5353         * linux-fork.c (class scoped_switch_fork_info): New class.
5354         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5355
5356 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5357
5358         * valops.c (find_overload_match): Remove use of null_cleanup, and
5359         calls to do_cleanups.
5360
5361 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5362
5363         * compile/compile-cplus-types.c
5364         (compile_cplus_instance::decl_name): Handle changes to
5365         cp_func_name.
5366         * cp-support.c (cp_func_name): Update header comment, update
5367         return type.
5368         * cp-support.h (cp_func_name): Update return type in declaration.
5369         * valops.c (find_overload_match): Move temp_func local to top
5370         level of function and change its type.  Use temp_func to hold and
5371         delete temporary string obtained from cp_func_name.
5372
5373 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5374
5375         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5376         gdb::char_vector, remove cleanup, and update uses of `msg`.
5377
5378 2019-01-03  Jim Wilson  <jimw@sifive.com>
5379
5380         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5381
5382 2019-01-02  Tom Tromey  <tom@tromey.com>
5383
5384         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5385         (tdesc_parse_xml): Remove cleanups.
5386         * target-descriptions.h (make_cleanup_free_target_description):
5387         Don't declare.
5388         (target_desc_deleter): New struct.
5389         (target_desc_up): New typedef.
5390         * target-descriptions.c (target_desc_deleter::operator()): Rename
5391         from free_target_description.
5392         (make_cleanup_free_target_description): Remove.
5393
5394 2019-01-02  Tom Tromey  <tom@tromey.com>
5395
5396         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5397         constructor, destructor.
5398         (linespec_parser): Remove typedef.
5399         (~linespec_parser): Rename from linespec_parser_delete.
5400         (linespec_lex_to_end, linespec_complete_label)
5401         (linespec_complete): Update.
5402         (decode_line_full): Remove cleanups.
5403         (decode_line_1): Update.
5404
5405 2019-01-02  Tom Tromey  <tom@tromey.com>
5406
5407         * python/python-internal.h (inferior_to_inferior_object): Change
5408         return type.
5409         * python/py-exitedevent.c (create_exited_event_object): Update.
5410         * python/py-inferior.c (inferior_to_inferior_object): Return
5411         gdbpy_ref.
5412         (python_new_inferior, python_inferior_deleted)
5413         (thread_to_thread_object, delete_thread_object)
5414         (build_inferior_list, gdbpy_selected_inferior): Update.
5415         * python/py-infthread.c (create_thread_object): Update.  Also fail
5416         if inferior_to_inferior_object fails.
5417
5418 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5419
5420         * inferior.h (class inferior) <displaced_step_state>: New field.
5421         * infrun.h (struct displaced_step_state): Move here from
5422         infrun.c.  Initialize fields, add constructor.
5423         <inf>: Remove field.
5424         <reset>: New method.
5425         * infrun.c (struct displaced_step_inferior_state): Move to
5426         infrun.h.
5427         (displaced_step_inferior_states): Remove.
5428         (get_displaced_stepping_state): Adust.
5429         (displaced_step_in_progress_any_inferior): Adjust.
5430         (displaced_step_in_progress_thread): Adjust.
5431         (displaced_step_in_progress): Adjust.
5432         (add_displaced_stepping_state): Remove.
5433         (get_displaced_step_closure_by_addr): Adjust.
5434         (remove_displaced_stepping_state): Remove.
5435         (infrun_inferior_exit): Call displaced_step_state.reset.
5436         (use_displaced_stepping): Don't check for NULL.
5437         (displaced_step_prepare_throw): Call
5438         get_displaced_stepping_state.
5439         (displaced_step_fixup): Don't check for NULL.
5440         (prepare_for_detach): Don't check for NULL.
5441
5442 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5443
5444         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5445          in case of call that did not complete.
5446
5447 2019-01-02  Andrey Utkin  <autkin@undo.io>
5448
5449         * symfile.c (find_separate_debug_file): Fix search of debug files for
5450         remote debuggee.
5451
5452 2019-01-02  Tom Tromey  <tom@tromey.com>
5453
5454         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5455         indentation.
5456         * python/py-frame.c (frapy_older): Remove cast.
5457         (frapy_newer): Likewise.
5458         * python/py-breakpoint.c (local_setattro): Remove cast.
5459         * python/py-arch.c (archpy_name): Remove local variable.
5460         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5461
5462 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5463
5464         * unittests/basic_string_view/element_access/char/empty.cc:
5465         Fix year range in copyright header.
5466
5467 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5468
5469         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5470         Delete.
5471         <operator==>: Update with for removed field.
5472         <hash>: Likewise.
5473         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5474         <isa_features>: ...this.
5475         <abi_features>: New field.
5476         (riscv_isa_flen): Update comment.
5477         (riscv_abi_xlen): New declaration.
5478         (riscv_abi_flen): New declaration.
5479         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5480         isa_features.
5481         (riscv_abi_xlen): New function.
5482         (riscv_isa_flen): Update to get answer from isa_features.
5483         (riscv_abi_flen): New function.
5484         (riscv_has_fp_abi): Update to get answer from abi_features.
5485         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5486         xlen and flen.
5487         (riscv_call_info) <xlen, flen>: Update comment.
5488         (riscv_call_arg_struct): Remove invalid assertions
5489         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5490         is removed.
5491         (riscv_gdbarch_init): Gather isa features and abi features
5492         separately, ensure both match on the gdbarch when reusing an old
5493         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5494         a target with 64-bit float hardware.
5495
5496 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5497
5498         * source.c (search_command_helper): Stop reverse search
5499         when line 1 has been searched.
5500
5501 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5502
5503         * record-full.c (record_full_base_target::close): Rewrite
5504         record_full_core_buf_list free logic.
5505
5506 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5507
5508         * break-catch-syscall.c (print_one_catch_syscall): xfree
5509         the last text.
5510
5511 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5512
5513         * top.c (print_gdb_version): Update Copyright year in version
5514         message.
5515
5516 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5517
5518         Update copyright year range in all GDB files.
5519
5520 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5521
5522         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5523
5524 For older changes see ChangeLog-2018.
5525 \f
5526 Local Variables:
5527 mode: change-log
5528 left-margin: 8
5529 fill-column: 74
5530 version-control: never
5531 coding: utf-8
5532 End:
5533