gdb/ChangeLog

   1 2019-01-23  Pedro Alves  <palves@redhat.com>
   2
   3         * common/preprocessor.h (ESC): Rename to ...
   4         (ESC_PARENS): ... this.
   5         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
   6         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
   7
   8 2019-01-23  Tom Tromey  <tom@tromey.com>
   9
  10         * language.h (class scoped_switch_to_sym_language_if_auto):
  11         Initialize m_lang in both cases.
  12
  13 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
  14
  15         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
  16         with XCNEW.
  17
  18 2019-01-22  Tom Tromey  <tom@tromey.com>
  19
  20         * corelow.c: Do not include sys/file.h.
  21
  22 2019-01-22  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-wingeneral.h: Include gdb_curses.h.
  25
  26 2019-01-22  Tom Tromey  <tom@tromey.com>
  27
  28         * source-cache.h (class source_cache) <get_source_lines,
  29         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
  30
  31 2019-01-22  Tom Tromey  <tom@tromey.com>
  32
  33         * remote-fileio.h (struct remote_target): Declare.
  34
  35 2019-01-22  Tom Tromey  <tom@tromey.com>
  36
  37         * python/py-arch.c: Do not include py-ref.h.
  38         * python/py-bpevent.c: Do not include py-ref.h.
  39         * python/py-cmd.c: Do not include py-ref.h.
  40         * python/py-continueevent.c: Do not include py-ref.h.
  41         * python/py-event.h: Do not include py-ref.h.
  42         * python/py-evtregistry.c: Do not include py-ref.h.
  43         * python/py-finishbreakpoint.c: Do not include py-ref.h.
  44         * python/py-frame.c: Do not include py-ref.h.
  45         * python/py-framefilter.c: Do not include py-ref.h.
  46         * python/py-function.c: Do not include py-ref.h.
  47         * python/py-infevents.c: Do not include py-ref.h.
  48         * python/py-linetable.c: Do not include py-ref.h.
  49         * python/py-objfile.c: Do not include py-ref.h.
  50         * python/py-param.c: Do not include py-ref.h.
  51         * python/py-prettyprint.c: Do not include py-ref.h.
  52         * python/py-progspace.c: Do not include py-ref.h.
  53         * python/py-symbol.c: Do not include py-ref.h.
  54         * python/py-symtab.c: Do not include py-ref.h.
  55         * python/py-type.c: Do not include py-ref.h.
  56         * python/py-unwind.c: Do not include py-ref.h.
  57         * python/py-utils.c: Do not include py-ref.h.
  58         * python/py-value.c: Do not include py-ref.h.
  59         * python/py-varobj.c: Do not include py-ref.h.
  60         * python/py-xmethods.c: Do not include py-ref.h.
  61         * python/python.c: Do not include py-ref.h.
  62         * varobj.c: Do not include py-ref.h.
  63
  64 2019-01-22  Tom Tromey  <tom@tromey.com>
  65
  66         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
  67         keyword for bcache.
  68
  69 2019-01-22  Tom Tromey  <tom@tromey.com>
  70
  71         * compile/compile-cplus-types.c: Remove a comment by #include.
  72
  73 2019-01-22  Tom Tromey  <tom@tromey.com>
  74
  75         * compile/gcc-c-plugin.h: Include compile-internal.h.
  76
  77 2019-01-22  Tom Tromey  <tom@tromey.com>
  78
  79         * stabsread.c (EXTERN): Do not define.
  80         (symnum, next_symbol_text_func, processing_gcc_compilation)
  81         (within_function, global_sym_chain, global_stabs)
  82         (previous_stab_code, this_object_header_files)
  83         (n_this_object_header_files)
  84         (n_allocated_this_object_header_files): Define.
  85         * stabsread.h (EXTERN): Never define.  Use "extern".
  86
  87 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  88
  89         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
  90         history_value.
  91
  92 2019-01-21  Tom Tromey  <tom@tromey.com>
  93
  94         * ui-out.c: Fix includes.
  95         * tui/tui-source.c: Fix includes.
  96         * target.c: Fix includes.
  97         * remote.c: Fix includes.
  98         * regcache.c: Fix includes.
  99         * python/py-block.c: Fix includes.
 100         * printcmd.c: Fix includes.
 101         * or1k-tdep.c: Fix includes.
 102         * mi/mi-main.c: Fix includes.
 103         * m32r-tdep.c: Fix includes.
 104         * csky-tdep.c: Fix includes.
 105         * compile/compile-cplus-types.c: Fix includes.
 106         * cli/cli-interp.c: Fix includes.
 107
 108 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 109
 110         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 111         for padding.
 112
 113 2019-01-16  Tom Tromey  <tom@tromey.com>
 114
 115         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 116         earlier.
 117         (struct objfile) <msymbols_range>: Move from top level.
 118         <msymbols>: New method.
 119         (class objfile_msymbols): Remove.
 120         * symtab.c (default_collect_symbol_completion_matches_break_on):
 121         Update.
 122         * symmisc.c (dump_msymbols): Update.
 123         * stabsread.c (scan_file_globals): Update.
 124         * objc-lang.c (info_selectors_command, info_classes_command)
 125         (find_methods): Update.
 126         * minsyms.c (find_solib_trampoline_target): Update.
 127         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 128         * coffread.c (coff_symfile_read): Update.
 129         * ada-lang.c (ada_lookup_simple_minsym)
 130         (ada_collect_symbol_completion_matches): Update.
 131
 132 2019-01-16  Tom Tromey  <tom@tromey.com>
 133
 134         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 135         type.  Remove no-argument constructor.
 136         <iterator::operator++>: Simplify.
 137         <begin>: Update.
 138         <end>: Use minimal_symbol_count.
 139
 140 2019-01-16  Tom Tromey  <tom@tromey.com>
 141
 142         * objfiles.h (struct objfile) <psymtabs>: New method.
 143         (class objfile_psymtabs): Remove.
 144         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 145         typedef.
 146         <range>: New method.
 147         (require_partial_symbols): Change return type.
 148         * psymtab.c (require_partial_symbols)
 149         (psym_expand_symtabs_matching): Update.
 150         * mdebugread.c (parse_partial_symbols): Update.
 151         * dbxread.c (dbx_end_psymtab): Update.
 152
 153 2019-01-15  Tom Tromey  <tom@tromey.com>
 154
 155         * symtab.c (lookup_objfile_from_block)
 156         (lookup_symbol_in_objfile_symtabs)
 157         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 158         (find_line_symtab, info_sources_command)
 159         (default_collect_symbol_completion_matches_break_on)
 160         (make_source_files_completion_list): Update.
 161         * symmisc.c (print_objfile_statistics, dump_objfile)
 162         (maintenance_print_symbols, maintenance_info_symtabs)
 163         (maintenance_check_symtabs, maintenance_info_line_tables):
 164         Update.
 165         * source.c (select_source_symtab)
 166         (forget_cached_source_info_for_objfile): Update.
 167         * objfiles.h (class objfile_compunits): Remove.
 168         (struct objfile) <compunits_range>: New typedef.
 169         (compunits): New method.
 170         * objfiles.c (objfile_relocate1): Update.
 171         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 172         * maint.c (count_symtabs_and_blocks): Update.
 173         * linespec.c (iterate_over_all_matching_symtabs): Update.
 174         * cp-support.c (add_symbol_overload_list_qualified): Update.
 175         * coffread.c (coff_symtab_read): Update.
 176         * ada-lang.c (add_nonlocal_symbols)
 177         (ada_collect_symbol_completion_matches)
 178         (ada_add_global_exceptions): Update.
 179
 180 2019-01-15  Tom Tromey  <tom@tromey.com>
 181
 182         * progspace.h (program_space) <objfiles_safe_range>: New
 183         typedef.
 184         <objfiles_safe>: New method.
 185         * objfiles.h (class all_objfiles_safe): Remove.
 186         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 187         * jit.c (jit_inferior_exit_hook): Update.
 188
 189 2019-01-17  Tom Tromey  <tom@tromey.com>
 190
 191         * progspace.h (program_space) <objfiles_range>: New typedef.
 192         <objfiles>: New method.
 193         <objfiles_head>: Rename from objfiles.
 194         (object_files): Update.
 195         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 196         * guile/scm-pretty-print.c
 197         (ppscm_find_pretty_printer_from_objfiles): Update.
 198         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 199         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 200         Update.
 201         * python/py-progspace.c (pspy_get_objfiles): Update.
 202         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 203         Update.
 204         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 205         (objfpy_lookup_objfile_by_build_id): Update.
 206         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 207         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 208         Update.
 209         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 210         (expand_symtab_containing_pc, lookup_objfile_from_block)
 211         (lookup_static_symbol, basic_lookup_transparent_type)
 212         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 213         (find_line_symtab, info_sources_command)
 214         (default_collect_symbol_completion_matches_break_on)
 215         (make_source_files_completion_list, find_main_name): Update.
 216         * symmisc.c (print_symbol_bcache_statistics)
 217         (print_objfile_statistics, maintenance_print_symbols)
 218         (maintenance_print_msymbols, maintenance_print_objfiles)
 219         (maintenance_info_symtabs, maintenance_check_symtabs)
 220         (maintenance_expand_symtabs, maintenance_info_line_tables):
 221         Update.
 222         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 223         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 224         (map_overlay_command, unmap_overlay_command)
 225         (simple_overlay_update, expand_symtabs_matching)
 226         (map_symbol_filenames): Update.
 227         * symfile-debug.c (set_debug_symfile): Update.
 228         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 229         Update.
 230         * source.c (select_source_symtab, forget_cached_source_info):
 231         Update.
 232         * solib.c (solib_read_symbols): Update.
 233         * solib-spu.c (append_ocl_sos): Update.
 234         * psymtab.c (maintenance_print_psymbols)
 235         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 236         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 237         * printcmd.c (info_symbol_command): Update.
 238         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 239         Update.
 240         * objfiles.h (class all_objfiles): Remove.
 241         * objfiles.c (have_partial_symbols, have_full_symbols)
 242         (have_minimal_symbols, qsort_cmp, update_section_map)
 243         (shared_objfile_contains_address_p)
 244         (default_iterate_over_objfiles_in_search_order): Update.
 245         * objc-lang.c (info_selectors_command, info_classes_command)
 246         (find_methods): Update.
 247         * minsyms.c (find_solib_trampoline_target): Update.
 248         * maint.c (maintenance_info_sections)
 249         (maintenance_translate_address, count_symtabs_and_blocks):
 250         Update.
 251         * main.c (captured_main_1): Update.
 252         * linux-thread-db.c (try_thread_db_load_from_pdir)
 253         (has_libpthread): Update.
 254         * linespec.c (iterate_over_all_matching_symtabs)
 255         (search_minsyms_for_name): Update.
 256         * jit.c (jit_find_objf_with_entry_addr): Update.
 257         * hppa-tdep.c (find_unwind_entry)
 258         (hppa_lookup_stub_minimal_symbol): Update.
 259         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 260         Update.
 261         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 262         (elf_gnu_ifunc_resolve_by_got): Update.
 263         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 264         * dwarf-index-write.c (save_gdb_index_command): Update.
 265         * cp-support.c (add_symbol_overload_list_qualified): Update.
 266         * breakpoint.c (create_overlay_event_breakpoint)
 267         (create_longjmp_master_breakpoint)
 268         (create_std_terminate_master_breakpoint)
 269         (create_exception_master_breakpoint): Update.
 270         * blockframe.c (find_pc_partial_function): Update.
 271         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 272         (ada_collect_symbol_completion_matches)
 273         (ada_add_global_exceptions): Update.
 274
 275 2019-01-17  Tom Tromey  <tom@tromey.com>
 276
 277         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 278         declare VEC.
 279         (solib_target_parse_libraries): Change return type.
 280         (library_list_start_segment, library_list_start_section)
 281         (library_list_end_library, library_list_start_library); Update.
 282         (solib_target_free_library_list): Remove.
 283         (solib_target_parse_libraries): Remove cleanup.  Change return
 284         type.
 285         (solib_target_current_sos): Update.
 286
 287 2019-01-17  Tom Tromey  <tromey@bapiya>
 288
 289         * valprint.c: Replace "the the" with "the".
 290         * symtab.c: Replace "the the" with "the".
 291         * solib.c: Replace "the the" with "the".
 292         * solib-dsbt.c: Replace "the the" with "the".
 293         * linespec.c: Replace "the the" with "the".
 294         * dwarf2loc.h: Replace "the the" with "the".
 295         * amd64-windows-tdep.c: Replace "the the" with "the".
 296         * aarch64-tdep.c: Replace "the the" with "the".
 297
 298 2019-01-16  Keith Seitz  <keiths@redhat.com>
 299
 300         PR gdb/23773
 301         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 302         <builder>: Rename to ..
 303         <m_builder>: ... this and make private.
 304         (dwarf2_cu::get_builder): New method.  Change all users of
 305         `builder' to use this method.
 306         (dwarf2_start_symtab): Move to ...
 307         (dwarf2_cu::start_symtab): ... here.  Update all callers
 308         (setup_type_unit_groups): Move to ...
 309         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 310         callers.
 311         (dwarf2_cu::reset_builder): New method.
 312         (process_full_compunit, process_full_type_unit): Use
 313         dwarf2_cu::reset_builder.
 314         (follow_die_offset): Record the ancestor CU if it is different
 315         from the followed DIE's CU.
 316         (follow_die_sig_1): Likewise.
 317
 318 2019-01-15  Tom Tromey  <tom@tromey.com>
 319
 320         * remote.c (class remote_state) <buf>: Now a char_vector.
 321         <buf_size>: Remove.
 322         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 323         parameter.
 324         (remote_target::getpkt_or_notif_sane_1)
 325         (remote_target::getpkt_sane)
 326         (remote_target::getpkt_or_notif_sane): Likewise.
 327         (class remote_target) <putpkt>: New overload.
 328         (remote_target::read_frame): Change type of "buf_p".  Remove
 329         sizeof_p parameter.
 330         (packet_ok): New overload.
 331         (packet_check_result): New overload.
 332         Update all uses.
 333
 334 2019-01-14  Tom Tromey  <tom@tromey.com>
 335
 336         * remote-notif.c (handle_notification, remote_notif_ack)
 337         (remote_notif_parse): Make "buf" const.
 338         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 339         const.
 340         (remote_notif_parse, remote_notif_ack, handle_notification):
 341         Likewise.
 342         * remote.c (remote_notif_stop_parse): Make "buf" const.
 343         (remote_target::remote_parse_stop_reply): Make "buf" const.
 344         (remote_notif_stop_ack): Make "buf" const.
 345
 346 2019-01-14  Tom Tromey  <tom@tromey.com>
 347
 348         * remote.c (remote_console_output): Make parameter const.
 349
 350 2019-01-14  Tom Tromey  <tom@tromey.com>
 351
 352         * target-debug.h (target_debug_print_signals): Constify.
 353         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 354         * procfs.c (procfs_target::pass_signals): Update.
 355         * linux-nat.c (linux_nat_target::pass_signals): Update.
 356         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 357         * target-delegates.c: Rebuild.
 358         * remote.c (remote_target::program_signals): Update.
 359         (remote_target::pass_signals): Update.
 360         * target.c (target_pass_signals): Constify argument.
 361         (target_program_signals): Likewise.
 362         * target.h (struct target_ops) <pass_signals, program_signals>:
 363         Constify argument.
 364         (target_pass_signals, target_program_signals): Constify argument.
 365
 366 2019-01-14  Tom Tromey  <tom@tromey.com>
 367
 368         PR tui/28819:
 369         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 370
 371 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 372
 373         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 374         field.
 375         * rs6000-tdep.c: Include reggroups.h.
 376         (IS_V_ALIAS_PSEUDOREG): Define.
 377         (rs6000_register_name): Return names for the "vX" aliases.
 378         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 379         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 380         aliases.  Call default_register_reggroup_p for all other
 381         pseudo-registers.
 382         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 383         New functions.
 384         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 385         Handle "vX" aliases.
 386         (v_alias_pseudo_register_collect): New function.
 387         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 388         (rs6000_gdbarch_init): Initialize "vX" aliases as
 389         pseudo-registers.  Restore registration of
 390         rs6000_pseudo_register_reggroup_p with
 391         set_tdesc_pseudo_register_reggroup_p.
 392
 393 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 394
 395         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 396         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 397         set_gdbarch_num_pseudo_regs.
 398
 399 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 400
 401         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 402         Remove arg prefixname, add do_set and do_show.
 403         Add member functions set_list and show_list.
 404         * cli/cli-style.c (class cli_style_option): Update accordingly.
 405         (style_set_list): Move to file scope.
 406         (style_show_list): Likewise.
 407         (set_style): Call help_list.
 408         (show_style): Call cmd_show_list.
 409         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 410         Update to use the new macro.
 411
 412 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 413
 414         * ada-lang.c (_initialize_ada_language): Expand the help text
 415         for the "catch exception" command.
 416
 417 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 418
 419         * symtab.c (matching_obj_sections): Initialize obj,
 420         declare it closer to its usage.
 421
 422 2019-01-10  Tom Tromey  <tom@tromey.com>
 423
 424         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 425         (basic_inf_threads_range): Remove.
 426         (inf_threads_range, inf_non_exited_threads_range)
 427         (safe_inf_threads_range): Use next_adapter.
 428
 429 2019-01-10  Keith Seitz  <keiths@redhat.com>
 430
 431         PR gdb/23712
 432         PR symtab/23010
 433         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 434         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 435
 436 2019-01-10  Keith Seitz  <keiths@redhat.com>
 437
 438         PR gdb/23712
 439         PR symtab/23010
 440         * dictionary.c (pending_to_vector): Remove.
 441         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 442         Remove _1 suffix, replacing functions of the same name.  Update
 443         all callers.
 444         (dict_create_hashed, dict_create_hashed_expandable)
 445         (dict_create_linear, dict_create_linear_expandable, dict_free)
 446         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 447         Make functions static.
 448
 449 2019-01-10  Keith Seitz  <keiths@redhat.com>
 450
 451         PR gdb/23712
 452         PR symtab/23010
 453         * dictionary.h (struct dictionary): Replace declaration with
 454         multidictionary.
 455         (dict_create_hashed, dict_create_hashed_expandable)
 456         (dict_create_linear, dict_create_linear_expandable)
 457         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 458         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 459         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 460         taking multidictionary argument.
 461         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 462         * block.h (struct block) <dict>: Change to multidictionary
 463         and rename `multidict'.
 464         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 465         symmisc.c: Update all dictionary references to multidictionary.
 466
 467 2019-01-10  Keith Seitz  <keiths@redhat.com>
 468
 469         PR gdb/23712
 470         PR symtab/23010
 471         * dictionary.c: Include unordered_map.
 472         (pending_to_vector): New function.
 473         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 474         Rewrite the non-"_1" functions to take vector instead
 475         of linked list.
 476         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 477         "new" _1 versions of the same name.
 478         (multidictionary): Define.
 479         (std::hash<enum language): New definition.
 480         (collate_pending_symbols_by_language, mdict_create_hashed)
 481         (mdict_create_hashed_expandable, mdict_create_linear)
 482         (mdict_create_linear_expandable, mdict_free)
 483         (find_language_dictionary, create_new_language_dictionary)
 484         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 485         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 486         (mdict_size, mdict_empty): New functions.
 487         * dictionary.h (mdict_iterator): Define.
 488
 489 2019-01-10  Pedro Alves  <palves@redhat.com>
 490
 491         * breakpoint.c (read_uploaded_action)
 492         (create_tracepoint_from_upload): Adjust to use
 493         gdb::unique_xmalloc_ptr.
 494         * ctf.c (ctf_write_uploaded_tp):
 495         (SET_ARRAY_FIELD): Use emplace_back.
 496         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 497         * tracefile-tfile.c (tfile_write_uploaded_tp):
 498         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 499         gdb::unique_xmalloc_ptr.
 500         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 501         at_string, cond_string, cmd_strings>: Replace char pointers
 502         with gdb::unique_xmalloc_ptr.
 503
 504 2019-01-10  Pedro Alves  <palves@redhat.com>
 505
 506         * solib-target.c (library_list_start_library): Don't xstrdup name.
 507
 508 2019-01-10  Pedro Alves  <palves@redhat.com>
 509
 510         * mdebugread.c (parse_partial_symbols): Use
 511         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 512
 513 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 514
 515         * linux-fork.c (scoped_switch_fork_info)
 516         <~scoped_switch_fork_info>: Fix incorrect variable name.
 517
 518 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 519
 520         * linux-fork.c (scoped_switch_fork_info)
 521         <scoped_switch_fork_info>: Make explicit.
 522         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 523
 524 2019-01-10  Tom Tromey  <tom@tromey.com>
 525
 526         * objfiles.h (objfile::reset_psymtabs): Update.
 527         * objfiles.c (objfile::objfile): Update.
 528         * psymtab.h (psymtab_storage::obstack): Update.
 529         (psymtab_storage::m_obstack): Use gdb::optional.
 530         (class psymtab_storage): Update comment.  Remove objfile
 531         parameter.
 532         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 533
 534 2019-01-10  Tom Tromey  <tom@tromey.com>
 535
 536         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 537         <free_psymtabs>: Now private.
 538         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 539         (allocate_psymtab): Use new method.
 540
 541 2019-01-10  Tom Tromey  <tom@tromey.com>
 542
 543         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 544         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 545         * mdebugread.c (parse_partial_symbols): Use
 546         allocate_dependencies.
 547         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 548         allocate_dependencies.
 549         (process_psymtab_comp_unit_reader)
 550         (build_type_psymtab_dependencies): Likewise.
 551         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 552
 553 2019-01-10  Tom Tromey  <tom@tromey.com>
 554
 555         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 556         PSYMBOL_SET_LANGUAGE.
 557         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 558
 559 2019-01-10  Tom Tromey  <tom@tromey.com>
 560
 561         * psymtab.h (psymtab_storage::obstack): New method.
 562         <m_obstack>: Rename from obstack; now private.
 563         * psymtab.c (psymtab_storage): Update.
 564         * dwarf2read.c (create_addrmap_from_index)
 565         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 566         Update.
 567
 568 2019-01-10  Tom Tromey  <tom@tromey.com>
 569
 570         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 571         * objfiles.h (objfile::reset_psymtabs): New method.
 572
 573 2019-01-10  Tom Tromey  <tom@tromey.com>
 574
 575         * symmisc.c (print_symbol_bcache_statistics): Update.
 576         (print_objfile_statistics): Update.
 577         * symfile.c (reread_symbols): Update.
 578         * psymtab.h (class psymtab_storage): New.
 579         * psymtab.c (psymtab_storage): New constructor.
 580         (~psymtab_storage): New destructor.
 581         (require_partial_symbols): Update.
 582         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 583         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 584         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 585         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 586         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 587         (start_psymtab_common, end_psymtab_common)
 588         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 589         (allocate_psymtab): Update.
 590         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 591         Update.
 592         (dump_psymtab_addrmap, maintenance_print_psymbols)
 593         (maintenance_check_psymtabs): Update.
 594         (class objfile_psymtabs): Move to objfiles.h.
 595         * psympriv.h (discard_psymtab): Now inline.
 596         (psymtab_discarder::psymtab_discarder): Update.
 597         (psymtab_discarder::~psymtab_discarder): Update.
 598         (ALL_OBJFILE_PSYMTABS): Rewrite.
 599         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 600         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 601         Remove fields.
 602         <partial_symtabs>: New field.
 603         (class objfile_psymtabs): Move from psymtab.h.  Update.
 604         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 605         psymbol_cache.
 606         (objfile::~objfile): Don't destroy psymbol_cache.
 607         * mdebugread.c (parse_partial_symbols): Update.
 608         * dwarf2read.c (create_addrmap_from_index)
 609         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 610         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 611         (add_partial_subprogram, dwarf2_ranges_read): Update.
 612         * dwarf-index-write.c (write_address_map)
 613         (write_one_signatured_type, recursively_write_psymbols)
 614         (class debug_names, class debug_names, write_psymtabs_to_index):
 615         Update.
 616
 617 2019-01-10  Tom Tromey  <tom@tromey.com>
 618
 619         * symtab.h (SYMBOL_SET_NAMES): Update.
 620         (symbol_set_names): Update.
 621         (MSYMBOL_SET_NAMES): Update.
 622         * symtab.c (symbol_set_names): Change argument to be an
 623         objfile_per_bfd_storage.
 624         * psymtab.c (add_psymbol_to_bcache): Update.
 625         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 626
 627 2019-01-10  Tom Tromey  <tom@tromey.com>
 628
 629         * symtab.c (create_demangled_names_hash): Change argument to be an
 630         objfile_per_bfd_storage.
 631         (symbol_set_names): Update.
 632
 633 2019-01-10  Tom Tromey  <tom@tromey.com>
 634
 635         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 636         init_psymbol_list.
 637         * psymtab.c (init_psymbol_list): Do nothing if already called.
 638         * psympriv.h (init_psymbol_list): Add comment.
 639         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 640         init_psymbol_list.
 641         * dbxread.c (dbx_symfile_read): Unconditionally call
 642         init_psymbol_list.
 643
 644 2019-01-10  Tom Tromey  <tom@tromey.com>
 645
 646         * xcoffread.c (scan_xcoff_symtab): Update.
 647         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 648         "where".
 649         * mdebugread.c (parse_partial_symbols)
 650         (handle_psymbol_enumerators): Update.
 651         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 652         * dbxread.c (read_dbx_symtab): Update.
 653         * psympriv.h (psymbol_placement): New enum.
 654         (add_psymbol_to_list): Update.
 655
 656 2019-01-10  Tom Tromey  <tom@tromey.com>
 657
 658         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 659         static_psymbols parameters.
 660         (scan_xcoff_symtab): Update.
 661         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 662         static_psymbols parameters.
 663         * psympriv.h (start_psymtab_common): Update.
 664         * mdebugread.c (parse_partial_symbols): Update.
 665         * dwarf2read.c (create_partial_symtab): Update.
 666         * dbxread.c (read_dbx_symtab): Update.
 667         (start_psymtab): Remove global_psymbols and static_psymbols
 668         parameters.
 669
 670 2019-01-10  Tom Tromey  <tom@tromey.com>
 671
 672         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 673         * psymtab.c (allocate_psymtab): Add comment.
 674         * psympriv.h (allocate_psymtab): Add comment.
 675         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 676         initializations.
 677         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 678
 679 2019-01-10  Tom Tromey  <tom@tromey.com>
 680
 681         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 682         Don't declare.
 683         * mipsread.c: Include mdebugread.h.
 684         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 685         Declare.
 686         * elfread.c: Include mdebugread.h.
 687
 688 2019-01-09  Tom Tromey  <tom@tromey.com>
 689
 690         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 691         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 692         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 693         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 694         (psym_lookup_symbol, psym_find_last_source_symtab)
 695         (psym_forget_cached_source_info, psym_print_stats)
 696         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 697         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 698         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 699         (psym_find_compunit_symtab_by_address)
 700         (maintenance_print_psymbols, maintenance_info_psymtabs)
 701         (maintenance_check_psymtabs): Use ranged for.
 702         * psymtab.h (class objfile_psymtabs): New.
 703         (require_partial_symbols): Return objfile_psymtabs.
 704         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 705
 706 2019-01-09  Tom Tromey  <tom@tromey.com>
 707
 708         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 709         (find_pc_mapped_section, list_overlays_command)
 710         (map_overlay_command, unmap_overlay_command)
 711         (simple_overlay_update): Use all_objfiles.
 712         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 713         * printcmd.c (info_symbol_command): Use all_objfiles.
 714         * objfiles.h (ALL_OBJSECTIONS): Remove.
 715         * maint.c (maintenance_translate_address): Use all_objfiles.
 716         * gcore.c (gcore_create_callback): Use all_objfiles.
 717         (objfile_find_memory_regions): Likewise.
 718
 719 2019-01-09  Tom Tromey  <tom@tromey.com>
 720
 721         * symtab.c (find_line_symtab, info_sources_command)
 722         (make_source_files_completion_list): Use objfile_compunits.
 723         * source.c (select_source_symtab): Use objfile_compunits.
 724         * objfiles.h (struct objfile): Update comment.
 725         (ALL_OBJFILES): Remove.
 726         (ALL_FILETABS): Remove.
 727         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 728         objfile_compunits.
 729
 730 2019-01-09  Tom Tromey  <tom@tromey.com>
 731
 732         * symmisc.c (print_objfile_statistics, dump_objfile)
 733         (maintenance_print_symbols): Use compunit_filetabs.
 734         * source.c (forget_cached_source_info_for_objfile): Use
 735         compunit_filetabs.
 736         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 737         (ALL_FILETABS): Use compunit_filetabs.
 738         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 739         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 740
 741 2019-01-09  Tom Tromey  <tom@tromey.com>
 742
 743         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 744         (compunit_filetabs): New.
 745         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 746         compunit_filetabs.
 747         (info_sources_command, make_source_files_completion_list): Remove
 748         declaration.
 749         * symmisc.c (print_objfile_statistics, dump_objfile)
 750         (maintenance_print_symbols): Remove declaration.
 751         (maintenance_info_symtabs): Use compunit_filetabs.
 752         (maintenance_info_line_tables): Likewise.
 753         * source.c (select_source_symtab): Change local variable name.
 754         (forget_cached_source_info_for_objfile): Remove declaration.
 755         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 756         * objfiles.c (objfile_relocate1): Remove declaration.
 757         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 758         declaration.
 759         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 760         * coffread.c (coff_symtab_read): Remove declaration.
 761         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 762         compunit_filetabs.
 763
 764 2019-01-09  Tom Tromey  <tom@tromey.com>
 765
 766         * symtab.c (lookup_objfile_from_block)
 767         (find_pc_sect_compunit_symtab, search_symbols)
 768         (default_collect_symbol_completion_matches_break_on): Use
 769         objfile_compunits.
 770         * objfiles.h (ALL_COMPUNITS): Remove.
 771         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 772         * cp-support.c (add_symbol_overload_list_qualified): Use
 773         objfile_compunits.
 774         * ada-lang.c (ada_collect_symbol_completion_matches)
 775         (ada_add_global_exceptions): Use objfile_compunits.
 776
 777 2019-01-09  Tom Tromey  <tom@tromey.com>
 778
 779         * source.c (select_source_symtab)
 780         (forget_cached_source_info_for_objfile): Remove declaration.
 781         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 782         declaration.
 783         * maint.c (count_symtabs_and_blocks): Remove declaration.
 784         * cp-support.c (add_symbol_overload_list_qualified): Remove
 785         declaration.
 786         * coffread.c (coff_symtab_read): Remove declaration.
 787         * symtab.c (lookup_symbol_in_objfile_symtabs)
 788         (basic_lookup_transparent_type_1): Use objfile_compunits.
 789         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 790         (info_sources_command, search_symbols)
 791         (default_collect_symbol_completion_matches_break_on)
 792         (make_source_files_completion_list): Remove declaration.
 793         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 794         (ada_collect_symbol_completion_matches)
 795         (ada_add_global_exceptions): Remove declaration.
 796         * linespec.c (iterate_over_all_matching_symtabs): Use
 797         objfile_compunits.
 798         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 799         (class objfile_compunits): New.
 800         (ALL_COMPUNITS): Use objfile_compunits.
 801         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 802         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 803         objfile_compunits.
 804         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 805
 806 2019-01-09  Tom Tromey  <tom@tromey.com>
 807
 808         * symtab.c (search_symbols)
 809         (default_collect_symbol_completion_matches_break_on): Use
 810         objfile_msymbols.
 811         * ada-lang.c (ada_lookup_simple_minsym)
 812         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 813         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 814         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 815         objfile_msymbols.
 816         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 817         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 818         * objc-lang.c (find_methods): Use objfile_msymbols.
 819         (info_selectors_command, info_classes_command): Likewise.
 820         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 821         * objfiles.h (class objfile_msymbols): New.
 822         (ALL_OBJFILE_MSYMBOLS): Remove.
 823         (ALL_MSYMBOLS): Remove.
 824
 825 2019-01-09  Tom Tromey  <tom@tromey.com>
 826
 827         * common/next-iterator.h (next_adapter): Add Iterator template
 828         parameter.
 829         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 830         (class all_objfiles_safe): New.
 831         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 832         * objfiles.c (put_objfile_before): Update comment.
 833         (add_separate_debug_objfile): Likewise.
 834         (free_all_objfiles): Use all_objfiles_safe.
 835         (objfile_purge_solibs): Likewise.
 836
 837 2019-01-09  Tom Tromey  <tom@tromey.com>
 838
 839         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 840         (expand_symtab_containing_pc, lookup_static_symbol)
 841         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 842         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 843         all_objfiles.
 844         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 845         * breakpoint.c (create_overlay_event_breakpoint)
 846         (create_longjmp_master_breakpoint)
 847         (create_std_terminate_master_breakpoint)
 848         (create_exception_master_breakpoint): Use all_objfiles.
 849         * linux-thread-db.c (try_thread_db_load_from_pdir)
 850         (has_libpthread): Use all_objfiles.
 851         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 852         * linespec.c (iterate_over_all_matching_symtabs)
 853         (search_minsyms_for_name): Use all_objfiles.
 854         * maint.c (maintenance_info_sections): Use all_objfiles.
 855         * main.c (captured_main_1): Use all_objfiles.
 856         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 857         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 858         * guile/scm-pretty-print.c
 859         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 860         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 861         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 862         (maintenance_print_msymbols): Use all_objfiles.
 863         * source.c (select_source_symtab): Use all_objfiles.
 864         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 865         * symfile.c (remove_symbol_file_command)
 866         (expand_symtabs_matching, map_symbol_filenames): Use
 867         all_objfiles.
 868         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 869         all_objfiles.
 870         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 871         * objc-lang.c (find_methods): Use all_objfiles.
 872         * objfiles.c (have_partial_symbols, have_full_symbols)
 873         (have_minimal_symbols, qsort_cmp)
 874         (default_iterate_over_objfiles_in_search_order): Use
 875         all_objfiles.
 876         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 877         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 878         (maintenance_check_psymtabs): Use all_objfiles.
 879         (ALL_PSYMTABS): Remove.
 880         * compile/compile-object-run.c (do_module_cleanup): Use
 881         all_objfiles.
 882         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 883         * cp-support.c (add_symbol_overload_list_qualified): Use
 884         all_objfiles.
 885         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 886         Use all_objfiles.
 887         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 888         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 889         all_objfiles.
 890         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 891         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 892         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 893         Uses all_objfiles.
 894         * solib.c (solib_read_symbols): Use all_objfiles
 895
 896 2019-01-09  Tom Tromey  <tom@tromey.com>
 897
 898         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 899         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 900         all_objfiles.
 901         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 902         * symmisc.c (print_symbol_bcache_statistics)
 903         (print_objfile_statistics, maintenance_print_objfiles)
 904         (maintenance_info_symtabs, maintenance_check_symtabs)
 905         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 906         all_objfiles.
 907         * source.c (forget_cached_source_info): Use all_objfiles.
 908         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 909         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 910         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 911         * objfiles.c (update_section_map): Use all_objfiles.
 912         (shared_objfile_contains_address_p): Likewise.
 913         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 914         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 915
 916 2019-01-09  Tom Tromey  <tom@tromey.com>
 917
 918         * common/next-iterator.h: New file.
 919         * objfiles.h (class all_objfiles): New.
 920         (struct objfile_iterator): New.
 921
 922 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 923
 924         * NEWS: Move the description of the changed "frame", "select-frame",
 925          and "info frame" commands to the Changed commands section.
 926
 927 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 928
 929         * gdbtypes.c (check_stub_method_group): Remove handling of old
 930         mangling schemes.
 931         * linespec.c (find_methods): Likewise.
 932         * stabsread.c (read_member_functions): Likewise.
 933         * valops.c (search_struct_method): Likewise.
 934         (value_struct_elt_for_reference): Likewise.
 935         * NEWS: Mention this change.
 936
 937 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 938
 939         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 940         print_source_lines.
 941         * source.c (print_source_lines_base): Update line number check.
 942         (print_source_lines): New function.
 943         (source_lines_range::source_lines_range): New function.
 944         * source.h (class source_lines_range): New class.
 945         (print_source_lines): New declaration.
 946
 947 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 948
 949         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 950
 951 2019-01-08  Tom Tromey  <tom@tromey.com>
 952             Simon Marchi  <simon.marchi@ericsson.com>
 953
 954         PR gdb/24060
 955         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 956         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 957         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 958         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 959         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 960         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 961
 962 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 963
 964         * source.c (select_source_symtab): Move header comment to
 965         declaration in source.h.
 966         (forget_cached_source_info_for_objfile): Likewise.
 967         (forget_cached_source_info): Likewise.
 968         (identify_source_line): Likewise.
 969         * source.h (identify_source_line): Move declaration from symtab.h
 970         and add comment from source.c
 971         (print_source_lines): Likewise.
 972         (forget_cached_source_info_for_objfile): Likewise.
 973         (forget_cached_source_info): Likewise.
 974         (select_source_symtab): Likewise.
 975         (enum print_source_lines_flag): Move definition from symtab.h.
 976         * symtab.h (identify_source_line): Move declaration to source.h.
 977         (print_source_lines): Likewise.
 978         (forget_cached_source_info_for_objfile): Likewise.
 979         (forget_cached_source_info): Likewise.
 980         (select_source_symtab): Likewise.
 981         (enum print_source_lines_flag): Move definition to source.h.
 982         * tui/tui-hooks.c: Add 'source.h' include.
 983
 984 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 985
 986         * source.c (print_source_lines_base): Handle requests to print
 987         reverse line number sequences, and guard against empty lines
 988         string.
 989
 990 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 991
 992         * source.c (print_source_lines_base): Fix skip of '\r' if next
 993         character is '\n'.
 994
 995 2019-01-06  Tom Tromey  <tom@tromey.com>
 996
 997         * c-exp.y (struct c_parse_state) <macro_original_text,
 998         expansion_obstack>: New member.
 999         (macro_original_text, expansion_obstack): Remove globals.
1000         (scan_macro_expansion, scanning_macro_expansion)
1001         (finished_macro_expansion): Update.
1002         (scan_macro_cleanup): Remove.
1003         (yylex, c_parse): Update.
1004
1005 2019-01-06  Tom Tromey  <tom@tromey.com>
1006
1007         * c-exp.y (struct c_parse_state) <strings>: New member.
1008         (operator_stoken): Update.
1009
1010 2019-01-06  Tom Tromey  <tom@tromey.com>
1011
1012         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1013         (union type_stack_elt) <typelist_val>: Now a pointer to
1014         std::vector.
1015         (type_stack_cleanup): Don't declare.
1016         (push_typelist): Update.
1017         * parse.c (pop_typelist): Return a std::vector.
1018         (push_typelist): Take a std::vector.
1019         (follow_types): Update.  Do not free args.
1020         (type_stack_cleanup): Remove.
1021         * c-exp.y (struct c_parse_state): New.
1022         (cpstate): New global.
1023         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1024         (nonempty_typelist): Update.
1025         (func_mod): Create a new vector.
1026         (c_parse): Create a c_parse_state.
1027         (check_parameter_typelist): Do not delete params.
1028         (function_method): Update.  Do not delete type_list.
1029
1030 2019-01-06  Tom Tromey  <tom@tromey.com>
1031
1032         PR gdb/28155:
1033         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1034         check_typedef.
1035         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1036         (print_return_value): Likewise.
1037
1038 2019-01-05  Tom Tromey  <tom@tromey.com>
1039
1040         * contrib/cleanup_check.py: Remove.
1041         * contrib/gcc-with-excheck: Remove.
1042         * contrib/exsummary.py: Remove.
1043         * contrib/excheck.py: Remove.
1044
1045 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1046
1047         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1048         NULL. Initialize tpprev to NULL instead of assigning it
1049         to NULL on the next statement.
1050         * windows-nat.c (windows_delete_thread): Remove check for
1051         main_thread_id before printing thread exit notifications.
1052         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1053         Remove thread ID check against main_thread_id.
1054         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1055         windows_delete_thread.
1056         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1057
1058 2019-01-04  Tom Tromey  <tom@tromey.com>
1059
1060         * compile/compile.c (_initialize_compile): Use upper case for
1061         metasyntactic variables.
1062         * symmisc.c (_initialize_symmisc): Use upper case for
1063         metasyntactic variables.
1064         * psymtab.c (_initialize_psymtab): Use upper case for
1065         metasyntactic variables.
1066         * demangle.c (demangle_command): Use upper case for metasyntactic
1067         variables.
1068         (_initialize_demangler): Likewise.
1069         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1070         variables.
1071
1072 2019-01-03  Tom Tromey  <tom@tromey.com>
1073
1074         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1075
1076 2019-01-03  Tom Tromey  <tom@tromey.com>
1077
1078         * python/py-symtab.c (salpy_str): Update.
1079         (struct salpy_sal_object) <symtab>: Now a PyObject.
1080         (salpy_dealloc): Update.
1081         (del_objfile_sal): Use gdbpy_ref.
1082
1083 2019-01-03  Tom Tromey  <tom@tromey.com>
1084
1085         * python/py-type.c (convert_field): Use new_reference.  Return
1086         gdbpy_ref.
1087         (make_fielditem): Return gdbpy_ref.
1088         (typy_fields): Update.
1089         (typy_getitem): Update.
1090         (field_name): Return gdbpy_ref.  Use new_reference.
1091         (typy_iterator_iternext): Update.
1092
1093 2019-01-03  Tom Tromey  <tom@tromey.com>
1094
1095         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1096
1097 2019-01-03  Tom Tromey  <tom@tromey.com>
1098
1099         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1100         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1101         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1102         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1103         (pspy_set_type_printers): Likewise.
1104         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1105         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1106         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1107         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1108         (objfpy_set_type_printers): Likewise.
1109
1110 2019-01-03  Tom Tromey  <tom@tromey.com>
1111
1112         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1113         (gdbpy_print_stack): Use gdbpy_err_fetch.
1114         * python/python-internal.h (class gdbpy_err_fetch): New class.
1115         (class gdbpy_enter) <m_error_type, m_error_value,
1116         m_error_traceback>: Remove.
1117         <m_error>: New member.
1118         (gdbpy_exception_to_string): Don't declare.
1119         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1120         * python/py-value.c (convert_value_from_python): Use
1121         gdbpy_err_fetch.
1122         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1123         gdbpy_exception_to_string.
1124         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1125         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1126         gdbpy_err_fetch.
1127
1128 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1129
1130         * linux-nat.c (delete_lwp_cleanup): Delete.
1131         (struct lwp_deleter): New struct.
1132         (lwp_info_up): New typedef.
1133         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1134         lwp_info_up.
1135
1136 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1137
1138         * linux-fork.c (class scoped_switch_fork_info): New class.
1139         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1140
1141 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1142
1143         * valops.c (find_overload_match): Remove use of null_cleanup, and
1144         calls to do_cleanups.
1145
1146 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1147
1148         * compile/compile-cplus-types.c
1149         (compile_cplus_instance::decl_name): Handle changes to
1150         cp_func_name.
1151         * cp-support.c (cp_func_name): Update header comment, update
1152         return type.
1153         * cp-support.h (cp_func_name): Update return type in declaration.
1154         * valops.c (find_overload_match): Move temp_func local to top
1155         level of function and change its type.  Use temp_func to hold and
1156         delete temporary string obtained from cp_func_name.
1157
1158 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1159
1160         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1161         gdb::char_vector, remove cleanup, and update uses of `msg`.
1162
1163 2019-01-03  Jim Wilson  <jimw@sifive.com>
1164
1165         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1166
1167 2019-01-02  Tom Tromey  <tom@tromey.com>
1168
1169         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1170         (tdesc_parse_xml): Remove cleanups.
1171         * target-descriptions.h (make_cleanup_free_target_description):
1172         Don't declare.
1173         (target_desc_deleter): New struct.
1174         (target_desc_up): New typedef.
1175         * target-descriptions.c (target_desc_deleter::operator()): Rename
1176         from free_target_description.
1177         (make_cleanup_free_target_description): Remove.
1178
1179 2019-01-02  Tom Tromey  <tom@tromey.com>
1180
1181         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1182         constructor, destructor.
1183         (linespec_parser): Remove typedef.
1184         (~linespec_parser): Rename from linespec_parser_delete.
1185         (linespec_lex_to_end, linespec_complete_label)
1186         (linespec_complete): Update.
1187         (decode_line_full): Remove cleanups.
1188         (decode_line_1): Update.
1189
1190 2019-01-02  Tom Tromey  <tom@tromey.com>
1191
1192         * python/python-internal.h (inferior_to_inferior_object): Change
1193         return type.
1194         * python/py-exitedevent.c (create_exited_event_object): Update.
1195         * python/py-inferior.c (inferior_to_inferior_object): Return
1196         gdbpy_ref.
1197         (python_new_inferior, python_inferior_deleted)
1198         (thread_to_thread_object, delete_thread_object)
1199         (build_inferior_list, gdbpy_selected_inferior): Update.
1200         * python/py-infthread.c (create_thread_object): Update.  Also fail
1201         if inferior_to_inferior_object fails.
1202
1203 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1204
1205         * inferior.h (class inferior) <displaced_step_state>: New field.
1206         * infrun.h (struct displaced_step_state): Move here from
1207         infrun.c.  Initialize fields, add constructor.
1208         <inf>: Remove field.
1209         <reset>: New method.
1210         * infrun.c (struct displaced_step_inferior_state): Move to
1211         infrun.h.
1212         (displaced_step_inferior_states): Remove.
1213         (get_displaced_stepping_state): Adust.
1214         (displaced_step_in_progress_any_inferior): Adjust.
1215         (displaced_step_in_progress_thread): Adjust.
1216         (displaced_step_in_progress): Adjust.
1217         (add_displaced_stepping_state): Remove.
1218         (get_displaced_step_closure_by_addr): Adjust.
1219         (remove_displaced_stepping_state): Remove.
1220         (infrun_inferior_exit): Call displaced_step_state.reset.
1221         (use_displaced_stepping): Don't check for NULL.
1222         (displaced_step_prepare_throw): Call
1223         get_displaced_stepping_state.
1224         (displaced_step_fixup): Don't check for NULL.
1225         (prepare_for_detach): Don't check for NULL.
1226
1227 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1228
1229         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1230          in case of call that did not complete.
1231
1232 2019-01-02  Andrey Utkin  <autkin@undo.io>
1233
1234         * symfile.c (find_separate_debug_file): Fix search of debug files for
1235         remote debuggee.
1236
1237 2019-01-02  Tom Tromey  <tom@tromey.com>
1238
1239         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1240         indentation.
1241         * python/py-frame.c (frapy_older): Remove cast.
1242         (frapy_newer): Likewise.
1243         * python/py-breakpoint.c (local_setattro): Remove cast.
1244         * python/py-arch.c (archpy_name): Remove local variable.
1245         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1246
1247 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1248
1249         * unittests/basic_string_view/element_access/char/empty.cc:
1250         Fix year range in copyright header.
1251
1252 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1253
1254         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1255         Delete.
1256         <operator==>: Update with for removed field.
1257         <hash>: Likewise.
1258         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1259         <isa_features>: ...this.
1260         <abi_features>: New field.
1261         (riscv_isa_flen): Update comment.
1262         (riscv_abi_xlen): New declaration.
1263         (riscv_abi_flen): New declaration.
1264         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1265         isa_features.
1266         (riscv_abi_xlen): New function.
1267         (riscv_isa_flen): Update to get answer from isa_features.
1268         (riscv_abi_flen): New function.
1269         (riscv_has_fp_abi): Update to get answer from abi_features.
1270         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1271         xlen and flen.
1272         (riscv_call_info) <xlen, flen>: Update comment.
1273         (riscv_call_arg_struct): Remove invalid assertions
1274         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1275         is removed.
1276         (riscv_gdbarch_init): Gather isa features and abi features
1277         separately, ensure both match on the gdbarch when reusing an old
1278         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1279         a target with 64-bit float hardware.
1280
1281 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1282
1283         * source.c (search_command_helper): Stop reverse search
1284         when line 1 has been searched.
1285
1286 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1287
1288         * record-full.c (record_full_base_target::close): Rewrite
1289         record_full_core_buf_list free logic.
1290
1291 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1292
1293         * break-catch-syscall.c (print_one_catch_syscall): xfree
1294         the last text.
1295
1296 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1297
1298         * top.c (print_gdb_version): Update Copyright year in version
1299         message.
1300
1301 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1302
1303         Update copyright year range in all GDB files.
1304
1305 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1306
1307         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1308
1309 For older changes see ChangeLog-2018.
1310 \f
1311 Local Variables:
1312 mode: change-log
1313 left-margin: 8
1314 fill-column: 74
1315 version-control: never
1316 coding: utf-8
1317 End:
1318