gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui.c: Update.
   4         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
   5         (tui_cmd_window::max_height): Move to tui-command.c.
   6         * tui/tui-layout.c: Update.
   7         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
   8         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
   9         tui-command.c.
  10         * tui/tui-command.h (struct tui_cmd_window): Move from
  11         tui-data.h.
  12         * tui/tui-command.c: Remove "structuring" comments.
  13         (tui_cmd_window::clear_detail)
  14         (tui_cmd_window::do_make_visible_with_new_height)
  15         (tui_cmd_window::max_height): Move from elsewhere.
  16
  17 2019-07-17  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
  20         Now static.
  21         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
  22         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
  23
  24 2019-07-17  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui.c: Update.
  27         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
  28         tui-regs.c.
  29         * tui/tui-windata.h: Remove file.
  30         * tui/tui-windata.c: Remove file.
  31         * tui/tui-win.c (tui_data_window::set_new_height)
  32         (tui_data_window::do_make_visible_with_new_height): Move to
  33         tui-regs.c.
  34         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
  35         * tui/tui-regs.c: Remove "structuring" comments.
  36         (tui_data_window::first_data_item_displayed)
  37         (tui_data_window::delete_data_content_windows)
  38         (tui_data_window::erase_data_content)
  39         (tui_data_window::display_all_data)
  40         (tui_data_window::refresh_all)
  41         (tui_data_window::do_scroll_vertical)
  42         (tui_data_window::clear_detail, tui_data_window::set_new_height)
  43         (tui_data_window::do_make_visible_with_new_height)
  44         (tui_data_window::refresh_window): Move from elsewhere.
  45         (_initialize_tui_regs): Move to end of file.
  46         * tui/tui-layout.c: Update.
  47         * tui/tui-hooks.c: Update.
  48         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
  49         * tui/tui-data.c (tui_data_window::clear_detail): Move to
  50         tui-regs.c.
  51         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
  52
  53 2019-07-17  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
  56         seen.
  57
  58 2019-07-17  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-win.c (tui_source_window_base::set_new_height)
  61         (tui_source_window_base::do_make_visible_with_new_height): Use
  62         m_has_locator field directly.
  63         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
  64         method.
  65         (struct tui_source_window_base) <has_locator>: Likewise.
  66
  67 2019-07-17  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
  70         Don't declare.
  71         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
  72         Remove.
  73         * tui/tui-win.c (tui_source_window_base::set_new_height)
  74         (tui_source_window_base::set_new_height)
  75         (make_invisible_and_set_new_height)
  76         (tui_source_window_base::do_make_visible_with_new_height)
  77         (tui_source_window_base::do_make_visible_with_new_height):
  78         Update.
  79         * tui/tui-layout.c (show_source_disasm_command, show_data)
  80         (show_source_or_disasm_and_command): Update.
  81         * tui/tui-layout.c (show_layout): Update.
  82
  83 2019-07-17  Tom Tromey  <tom@tromey.com>
  84
  85         * tui/tui-layout.c (make_data_window): Remove.
  86         (show_data): Unify creation and re-initialization cases.
  87
  88 2019-07-17  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-layout.c (make_source_window, make_disasm_window):
  91         Remove.
  92         (show_data): Unify creation and re-initialization cases.
  93
  94 2019-07-17  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-layout.c (make_command_window): Remove.
  97         (show_source_disasm_command, show_source_or_disasm_and_command):
  98         Unify creation and re-initialization cases.
  99
 100 2019-07-17  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 103         creation and re-initialization cases.
 104
 105 2019-07-17  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui-regs.c (tui_get_register): Return void.
 108
 109 2019-07-17  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 112         Simplify.
 113
 114 2019-07-17  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 117         resetting.
 118
 119 2019-07-17  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 122         * tui/tui-regs.c (tui_reg_layout): New function.
 123         (tui_show_registers, tui_reg_command): Use it.
 124         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 125         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 126         parameters.
 127         (tui_layout_command): Remove.
 128
 129 2019-07-17  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-layout.h (tui/tui-layout): Return void.
 132         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 133
 134 2019-07-17  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-layout.c (show_source_disasm_command, show_data):
 137         Update.
 138         (reset_locator): Remove.
 139         (show_source_or_disasm_and_command): Update.
 140
 141 2019-07-17  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-source.c (tui_source_window_base::reset): Remove
 144         win_type parameter.
 145         * tui/tui-layout.c (make_command_window, make_source_window)
 146         (make_disasm_window, make_data_window)
 147         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 148         (reset_locator, show_source_or_disasm_and_command): Update.
 149         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 150         win_type parameter.
 151         (struct tui_source_window_base) <reset>: Likewise.
 152
 153 2019-07-17  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-layout.c (show_source_disasm_command): Use
 156         reset_locator.
 157         (reset_locator): New function.
 158         (init_and_make_win): Remove.
 159         (show_source_or_disasm_and_command): Use reset_locator.
 160
 161 2019-07-17  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 164         condition.
 165         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 166         Remove condition.
 167         * tui/tui-source.c (tui_source_window_base::reset): New method.
 168         * tui/tui-layout.c (make_command_window): Don't call
 169         init_and_make_win.
 170         (make_source_window, make_disasm_window): Don't call
 171         make_source_or_disasm_window.
 172         (make_data_window): Don't call init_and_make_win.  Change calling
 173         convention.
 174         (show_source_disasm_command, show_data): Simplify.
 175         (make_source_or_disasm_window): Remove.
 176         (show_source_or_disasm_and_command): Simplify.
 177         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 178         (struct tui_source_window_base) <reset>: Likewise.
 179         <execution_info>: Remove initializer.
 180         * tui/tui-data.c (tui_source_window_base): Initialize
 181         execution_info.
 182
 183 2019-07-17  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 186         variable.
 187
 188 2019-07-17  Tom Tromey  <tom@tromey.com>
 189
 190         * tui/tui.c (tui_rl_other_window): Update.
 191         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 192         superclass method first.  Always iterate over regs_content.
 193         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 194         method.
 195         * tui/tui-win.c (tui_set_focus_command): Update.
 196
 197 2019-07-17  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-win.c (tui_set_focus_command): Rename from
 200         tui_set_focus.  Call tui_enable.
 201         (tui_set_focus_command): Remove.
 202
 203 2019-07-17  Tom Tromey  <tom@tromey.com>
 204
 205         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 206         refresh_window.
 207         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 208         touchwin.
 209         (tui_data_window::refresh_window): Call refresh_window on data
 210         items.  Always call superclass refresh_window.
 211         (tui_win_info::refresh): Remove.
 212         (tui_source_window_base::refresh_window): Update.
 213         (tui_refresh_all): Update.
 214         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 215         refresh_window.
 216         (show_source_or_disasm_and_command): Likewise.
 217         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 218         (struct tui_source_window_base) <refresh>: Likewise.
 219
 220 2019-07-17  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-winsource.c (tui_clear_source_content)
 223         (tui_show_source_content): Update.
 224         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 225         whether content is empty.
 226         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 227         Remove.
 228
 229 2019-07-17  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 232         window's contents.
 233         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 234         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 235
 236 2019-07-17  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 239         (struct tui_data_item_window): Update.
 240
 241 2019-07-17  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 244         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 245         defines.
 246
 247 2019-07-17  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-winsource.h (tui_erase_source_content)
 250         (tui_clear_source_content): Remove "display_prompt" parameter.
 251         * tui/tui-winsource.c (tui_update_source_window_as_is)
 252         (tui_update_source_windows_with_addr): Update.
 253         (tui_clear_source_content): Remove "display_prompt" parameter.
 254         (tui_erase_source_content): Likewise.  Simplify.
 255         (tui_show_source_content): Update.
 256         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 257         * tui/tui-stack.c (tui_show_frame_info): Update.
 258         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 259         Remove defines.
 260
 261 2019-07-17  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 264         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 265         parameter.
 266         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 267         parameter.
 268
 269 2019-07-17  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-winsource.c (tui_clear_source_content)
 272         (tui_show_source_content, tui_show_exec_info_content)
 273         (tui_clear_exec_info_content): Update.
 274         * tui/tui-stack.c (tui_show_locator_content): Update.
 275         (tui_show_frame_info): Update.
 276         * tui/tui-source.h (tui_source_window): Don't declare.
 277         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 278         from tui_source_is_displayed.
 279         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 280         Remove field.
 281         (struct tui_source_window_base) <content_in_use>: New field.  Now
 282         bool.
 283         (struct tui_source_window) <showing_source_p>: New method.
 284         (TUI_SRC_WIN): Change cast.
 285         * tui/tui-data.c (tui_initialize_static_data): Update.
 286
 287 2019-07-17  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 290         location_matches_p.
 291         * tui/tui-source.c (tui_source_window::location_matches_p): New
 292         method.
 293         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 294         method.
 295         * tui/tui-data.h (struct tui_source_window_base)
 296         <location_matches_p>: New method.
 297         (struct tui_source_window, struct tui_disasm_window)
 298         <location_matches_p>: Likewise.
 299
 300 2019-07-17  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-win.c (tui_set_win_height_command): Rename from
 303         tui_set_win_height.
 304         (tui_set_win_height_command): Remove.
 305
 306 2019-07-17  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-source.c (tui_source_window): New constructor.  Add
 309         observer.
 310         (~tui_source_window): New destructor.
 311         (tui_source_window::style_changed): New method.
 312         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 313         (tui_attach_detach_observers): Update.
 314         * tui/tui-data.h (struct tui_source_window): Make constructor not
 315         inline.  Add destructor.
 316         (struct tui_source_window) <style_changed>: New method.
 317         <m_observable>: New member.
 318
 319 2019-07-17  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 322         * tui/tui-win.c (tui_resize_all): Fix typo.
 323
 324 2019-07-17  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 327         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 328         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 329         * tui/tui-win.c (window_name_completer): Use foreach.
 330         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 331         (update_tab_width): Likewise.
 332         * tui/tui-layout.c (show_layout): Update.
 333         * tui/tui-data.h (class tui_window_iterator): New.
 334         (struct all_tui_windows): New.
 335         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 336
 337 2019-07-17  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 340         parameter.  Don't reference globals.
 341         (tui_reg_command): Update.
 342
 343 2019-07-17  Tom Tromey  <tom@tromey.com>
 344
 345         * tui/tui-regs.c (tui_show_registers): Simplify.
 346
 347 2019-07-17  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-regs.c (tui_show_registers): Update.
 350         (tui_show_register_group): Add win_info parameter.
 351
 352 2019-07-17  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 355         Rename from tui_display_reg_element_at_line.
 356         (tui_data_window::display_registers_from_line): Update.
 357         * tui/tui-data.h (struct tui_data_window)
 358         <display_reg_element_at_line>: New method.
 359
 360 2019-07-17  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-regs.h (tui_display_registers_from)
 363         (tui_display_registers_from_line): Don't declare.
 364         * tui/tui-windata.c (tui_data_window::display_all_data)
 365         (tui_data_window::refresh_all)
 366         (tui_data_window::do_scroll_vertical): Update.
 367         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 368         from tui_display_registers_from.
 369         (tui_display_reg_element_at_line): Update.
 370         (tui_data_window::display_registers_from_line): Rename from
 371         tui_display_registers_from_line.
 372         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 373         display_registers_from_line>: New methods.
 374
 375 2019-07-17  Tom Tromey  <tom@tromey.com>
 376
 377         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 378         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 379         from tui_erase_data_content.
 380         (tui_data_window::display_all_data)
 381         (tui_data_window::refresh_all)
 382         (tui_data_window::do_scroll_vertical): Update.
 383         * tui/tui-regs.c (tui_show_registers): Update.
 384         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 385         New method.
 386
 387 2019-07-17  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 390         declare.
 391         * tui/tui-windata.c
 392         (tui_data_window::delete_data_content_windows): Rename from
 393         tui_delete_data_content_windows.
 394         (tui_data_window::display_all_data)
 395         (tui_data_window::do_scroll_vertical): Update.
 396         * tui/tui-data.h (struct tui_data_window)
 397         <delete_data_content_windows>: New method.
 398
 399 2019-07-17  Tom Tromey  <tom@tromey.com>
 400
 401         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 402         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 403
 404 2019-07-17  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 407         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 408         from tui_display_all_data.
 409         * tui/tui-win.c
 410         (tui_data_window::do_make_visible_with_new_height): Update.
 411         * tui/tui-regs.c (tui_show_registers): Update.
 412         * tui/tui-layout.c (tui_set_layout): Update.
 413         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 414         method.
 415
 416 2019-07-17  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 419         * tui/tui-windata.c (tui_display_data_from): Remove.
 420         (tui_data_window::refresh_all): Update.
 421
 422 2019-07-17  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 425         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 426         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 427         tui_display_registers_from_line.
 428         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 429         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 430         "force_display" parameter.
 431
 432 2019-07-17  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 435         declare.
 436         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 437         Rename from tui_first_reg_element_no_inline.
 438         (tui_display_reg_element_at_line)
 439         (tui_display_registers_from_line): Update.
 440         * tui/tui-data.h (struct tui_data_window)
 441         <first_reg_element_no_inline>: New method.
 442
 443 2019-07-17  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-windata.c (tui_display_data_from)
 446         (tui_data_window::do_scroll_vertical): Update.
 447         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 448         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 449         Rename from tui_line_from_reg_element_no.
 450         (tui_display_registers_from_line): Update.
 451         * tui/tui-data.h (struct tui_data_window)
 452         <line_from_reg_element_no>: New method.
 453
 454 2019-07-17  Tom Tromey  <tom@tromey.com>
 455
 456         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 457         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 458         tui_last_regs_line_no.
 459         (tui_display_reg_element_at_line)
 460         (tui_display_registers_from_line): Update.
 461         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 462         method.
 463
 464 2019-07-17  Tom Tromey  <tom@tromey.com>
 465
 466         PR tui/24722:
 467         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 468         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 469         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 470         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 471         (tui_update_breakpoint_info): Likewise.
 472         * tui/tui-hooks.c (tui_event_create_breakpoint)
 473         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 474         Update.
 475
 476 2019-07-17  Tom Tromey  <tom@tromey.com>
 477
 478         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 479
 480 2019-07-17  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-winsource.c (tui_update_source_window_as_is)
 483         (tui_update_source_windows_with_addr): Update.
 484         * tui/tui-source.h (tui_set_source_content)
 485         (tui_show_symtab_source): Add "win_info" parameter.
 486         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 487         parameter.
 488         (tui_show_symtab_source): Likewise.
 489
 490 2019-07-17  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-wingeneral.c
 493         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 494
 495 2019-07-17  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 498         (struct tui_cmd_window) <can_scroll>: New method.
 499         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 500         method.
 501
 502 2019-07-17  Tom Tromey  <tromey@adacore.com>
 503
 504         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 505         do_field_signed>: Rename.  Change type of "value".
 506         * ui-out.c (ui_out::field_signed): Rename from field_int.
 507         Change type of "value".
 508         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 509         type of "value".
 510         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 511         do_field_int.  Change type of "value".
 512         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 513         do_field_int.  Change type of "value".
 514         * tracepoint.c (trace_status_mi, tfind_1)
 515         (print_one_static_tracepoint_marker): Update.
 516         * thread.c (print_thread_info_1, print_selected_thread_frame):
 517         Update.
 518         * stack.c (print_frame, print_frame_info): Update.
 519         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 520         Update.
 521         * source.c (print_source_lines_base): Update.
 522         * skip.c (info_skip_command): Update.
 523         * record-btrace.c (btrace_ui_out_decode_error)
 524         (btrace_call_history_src_line): Update.
 525         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 526         Update.
 527         * progspace.c (print_program_space): Update.
 528         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 529         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 530         do_field_int.  Change type of "value".
 531         * mi/mi-out.c (mi_ui_out::do_table_begin)
 532         (mi_ui_out::do_table_header): Update.
 533         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 534         type of "value".
 535         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 536         (mi_cmd_data_list_changed_registers, output_register)
 537         (mi_cmd_data_read_memory, mi_load_progress)
 538         (mi_cmd_trace_frame_collected): Update.
 539         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 540         Update.
 541         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 542         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 543         (mi_cmd_var_list_children, varobj_update_one): Update.
 544         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 545         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 546         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 547         * inferior.c (print_inferior): Update.
 548         * gdb_bfd.c (print_one_bfd): Update.
 549         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 550         Update.
 551         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 552         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 553         do_field_int.  Change type of "value".
 554         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 555         do_field_int.  Change type of "value".
 556         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 557         (print_one_breakpoint_location, print_it_catch_fork)
 558         (print_one_catch_fork, print_it_catch_vfork)
 559         (print_one_catch_vfork, print_it_catch_solib)
 560         (print_it_catch_exec, print_it_ranged_breakpoint)
 561         (print_mention_watchpoint, print_mention_masked_watchpoint)
 562         (bkpt_print_it, update_static_tracepoint): Update.
 563         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 564         * break-catch-syscall.c (print_it_catch_syscall): Update.
 565         * ada-tasks.c (print_ada_task_info): Update.
 566         * ada-lang.c (print_it_exception, print_mention_exception):
 567         Update.
 568
 569 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 570
 571         PR breakpoints/24541
 572         * gdbarch.c: Regenerate.
 573         * gdbarch.h: Regenerate.
 574         * gdbarch.sh: Adjust return type and parameter types for
 575         'stap_adjust_register'.
 576         (i386_stap_adjust_register): Adjust signature and return new
 577         register name.
 578         * stap-probe.c (stap_parse_register_operand): Adjust use of
 579         'gdbarch_stap_adjust_register'.
 580
 581 2019-07-17  Tom Tromey  <tromey@adacore.com>
 582
 583         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 584         declare VEC.
 585         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 586         std::vector.
 587         (struct s390_process_info): Add initializers.
 588         (s390_add_process): Use new.
 589         (s390_linux_nat_target::low_forget_process): Use delete.
 590         (s390_linux_nat_target::low_new_fork)
 591         (s390_linux_nat_target::stopped_by_watchpoint)
 592         (s390_linux_nat_target::low_prepare_to_resume)
 593         (s390_linux_nat_target::insert_watchpoint)
 594         (s390_linux_nat_target::insert_hw_breakpoint)
 595         (s390_linux_nat_target::remove_watchpoint)
 596         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 597
 598 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 599
 600         * aarch64-fbsd-nat.c: Include regcache.h.
 601         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 602         argument.
 603         (aarch64_fbsd_nat_target::fetch_registers)
 604         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 605         variable.
 606         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 607
 608 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 609
 610         * fbsd-nat.c: Include gdbarch.h.
 611
 612 2019-07-15  Tom Tromey  <tromey@adacore.com>
 613
 614         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 615
 616 2019-07-15  Tom Tromey  <tromey@adacore.com>
 617
 618         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 619         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 620         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 621         * cli-out.c (cli_ui_out::do_field_int): New method.
 622         * ui-out.c (ui_out::field_unsigned): New method.
 623         * symfile.c (generic_load): Use field_unsigned.
 624         (print_transfer_performance): Likewise.
 625         * record-btrace.c (ui_out_field_uint): Remove.
 626         (btrace_call_history_insn_range, btrace_call_history): Use
 627         field_unsigned.
 628         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 629         field_unsigned.
 630         * ui-out.h (class ui_out) <field_unsigned>: New method.
 631         <do_field_unsigned>: Likewise.
 632
 633 2019-07-15  Tom Tromey  <tromey@adacore.com>
 634
 635         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 636         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 637         * target.c (flash_erase_command): Use field_string.
 638         * infrun.c (print_signal_received_reason): Use field_string.
 639         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 640         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 641         field_string.
 642         * ada-tasks.c (print_ada_task_info): Use field_string.
 643
 644 2019-07-15  Tom Tromey  <tromey@adacore.com>
 645
 646         * target.c (flash_erase_command): Use field_core_addr.
 647         * symfile.c (generic_load): Use field_core_addr.
 648         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 649         Use field_core_addr.
 650         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 651         field_core_addr.
 652
 653 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 654
 655         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 656         value if its desired type is smaller than a CORE_ADDR and signed.
 657
 658 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 659
 660         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 661         of changes to field names, and use new is_reference field to
 662         decide if a property is a reference or not.
 663         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 664         field.
 665         (struct dwarf2_property_baton): Update header comment, rename
 666         'referenced_type' to 'property_type' and update comments.
 667         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 668         default property type, store in property baton, update to take
 669         accound of renamed field.
 670         (read_func_scope): Update call to attr_to_dynamic_prop.
 671         (read_array_type): Likewise.
 672         (dwarf2_per_cu_addr_sized_int_type): New function.
 673         (read_subrange_index_type): Move type finding code to
 674         dwarf2_per_cu_addr_sized_int_type.
 675         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 676         (dwarf2_per_cu_addr_type): New function.
 677         (set_die_type): Update calls to attr_to_dynamic_prop.
 678
 679 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 680
 681         * dwarf2read.c (read_subrange_index_type): New function.
 682         (read_subrange_type): Move code into new function and call it.
 683         * gdbtypes.c (create_range_type): Add some asserts.
 684
 685 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 686
 687         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 688         update return statements.
 689         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 690         declaration, and update comment to match.
 691         * gdbtypes.c (resolve_dynamic_array): Update call to
 692         dwarf2_evaluate_property to match new return type.
 693
 694 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 695
 696         * valarith.c (value_subscripted_rvalue): Change lowerbound
 697         parameter type from int to LONGEST.
 698         * value.h (value_subscripted_rvalue): Likewise in declaration.
 699
 700 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 701
 702         * cli/cli-utils.c (info_print_command_completer): New function.
 703         * cli/cli-utils.h: Add 'completer.h' include, and forward
 704         declaration for 'struct cmd_list_element'.
 705         (info_print_command_completer): Declare.
 706         * stack.c (_initialize_stack): Add completer for 'info locals' and
 707         'info args'.
 708         * symtab.c (_initialize_symtab): Add completer for 'info
 709         variables' and 'info functions'.
 710         * NEWS: Mention completion for additional info commands.
 711
 712 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 713
 714         * cli/cli-utils.c (extract_info_print_args): Delete.
 715         (extract_arg_maybe_quoted): Delete.
 716         (info_print_options_defs): New variable.
 717         (make_info_print_options_def_group): New function.
 718         (extract_info_print_options): Define new function.
 719         * cli/cli-utils.h (extract_info_print_args): Delete.
 720         (struct info_print_options): New structure.
 721         (extract_info_print_options): Declare new function.
 722         * stack.c (info_locals_command): Update to use new
 723         extract_info_print_options, also add a header comment.
 724         (info_args_command): Likewise.
 725         * symtab.c (info_variables_command): Likewise.
 726         (info_functions_command): Likewise.
 727
 728 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 729
 730         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 731         to extract string arguments.
 732         * common/common-utils.c (extract_string_maybe_quoted): New function.
 733         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 734
 735 2019-07-11  Tom Tromey  <tromey@adacore.com>
 736
 737         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 738         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 739         * top.h (gdbinit): Don't declare.
 740         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 741         into...
 742         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 743         * top.c (gdb_init): Don't call init_cli_cmds.
 744         (gdbinit): Remove.
 745         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 746
 747 2019-07-11  Tom Tromey  <tromey@adacore.com>
 748
 749         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 750         after it has been moved.
 751
 752 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 753
 754         * valops.c (value_must_coerce_to_target): Change return type to
 755         bool.
 756         * value.h (value_must_coerce_to_target): Likewise.
 757
 758 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 759
 760         * breakpoint.c (is_hardware_watchpoint): Remove
 761         forward-declaration.
 762         (is_masked_watchpoint): Change return type to bool.
 763         (is_tracepoint): Likewise.
 764         (is_breakpoint): Likewise.
 765         (is_hardware_watchpoint): Likewise.
 766         (is_watchpoint): Likewise.
 767         (is_no_memory_software_watchpoint): Likewise.
 768         (is_catchpoint): Likewise.
 769         (breakpoint_1): Make FILTER parameter's return type bool.
 770         is_masked_watchpoint): Change return type to bool.
 771         (save_breakpoints): Make FILTER parameter's return type bool.
 772         * breakpoint.h (is_breakpoint): Change return type to bool.
 773         (is_watchpoint): Likewise.
 774         (is_catchpoint): Likewise.
 775         (is_tracepoint): Likewise.
 776
 777 2019-07-10  Tom Tromey  <tom@tromey.com>
 778
 779         * defs.h: Don't include gdbarch.h.
 780         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 781         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 782         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 783         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 784         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 785         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 786         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 787         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 788         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 789         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 790         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 791         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 792         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 793         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 794         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 795         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 796         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 797         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 798         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 799         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 800         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 801         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 802         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 803         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 804         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 805         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 806         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 807
 808 2019-07-10  Tom Tromey  <tromey@adacore.com>
 809
 810         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 811         * breakpoint.c (init_ada_exception_breakpoint): Register as
 812         bp_catchpoint.
 813         (print_one_breakpoint_location, print_one_breakpoint): Use
 814         is_ada_exception_catchpoint.
 815         * ada-lang.c (class ada_catchpoint_location): Pass
 816         bp_loc_software_breakpoint to bp_location constructor.
 817         (is_ada_exception_catchpoint): New function.
 818
 819 2019-07-10  Tom Tromey  <tromey@adacore.com>
 820
 821         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 822         VEC.
 823         (struct arm_exidx_entry): New method operator<.
 824         (struct arm_exidx_data) <section_maps>: Change type.
 825         (arm_exidx_data_free): Remove.
 826         (arm_exidx_data_key): Change type.  Move lower.
 827         (arm_exidx_new_objfile): Update.
 828         (arm_compare_exidx_entries): Remove.
 829         (arm_find_exidx_entry, _initialize_arm_tdep)
 830
 831 2019-07-10  Tom Tromey  <tromey@adacore.com>
 832
 833         * solib-spu.c (ocl_program_data_key): Change type.
 834         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 835         Update.
 836
 837 2019-07-10  Tom Tromey  <tromey@adacore.com>
 838
 839         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 840         (struct solib_aix_inferior_data) <library_list>: Change type.
 841         (solib_aix_inferior_data_handle): Change type.
 842         (get_solib_aix_inferior_data): Update.
 843         (solib_aix_free_library_list): Remove.
 844         (library_list_start_library): Update.
 845         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 846         return type.
 847         (solib_aix_get_library_list)
 848         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 849         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 850
 851 2019-07-10  Tom Tromey  <tromey@adacore.com>
 852
 853         * solib-dsbt.c (struct dsbt_info): Add initializers.
 854         (solib_dsbt_pspace_data): Change type.
 855         (dsbt_pspace_data_cleanup): Remove.
 856         (get_dsbt_info, _initialize_dsbt_solib): Update.
 857
 858 2019-07-10  Tom Tromey  <tromey@adacore.com>
 859
 860         * spu-tdep.c (spu_overlay_data): Change type.
 861         (spu_get_overlay_table, spu_overlay_new_objfile)
 862         (_initialize_spu_tdep): Update.
 863
 864 2019-07-10  Tom Tromey  <tromey@adacore.com>
 865
 866         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 867         destructor.
 868         (dbx_objfile_data_key): Change type and declare later.
 869         (DBX_SYMFILE_INFO): Rewrite.
 870         * dbxread.c (dbx_objfile_data_key): Change type.
 871         (dbx_symfile_init): Update.
 872         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 873         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 874         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 875
 876 2019-07-10  Tom Tromey  <tromey@adacore.com>
 877
 878         * jit.c (jit_program_space_key): Change type.  Move lower.
 879         (get_jit_program_space_data): Update.
 880         (jit_program_space_data_cleanup): Remove.
 881         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 882         Update.
 883         (struct jit_program_space_data): Add initializers.
 884
 885 2019-07-10  Tom Tromey  <tromey@adacore.com>
 886
 887         * solib-darwin.c (struct darwin_info): Add initializers.
 888         (solib_darwin_pspace_data): Change type.
 889         (darwin_pspace_data_cleanup): Remove.
 890         (get_darwin_info, _initialize_darwin_solib): Update.
 891
 892 2019-07-10  Tom Tromey  <tromey@adacore.com>
 893
 894         * remote-sim.c (struct sim_inferior_data): Add initializers,
 895         constructor, and destructor.
 896         (sim_inferior_data_key): Change type.  Move lower.
 897         (check_for_duplicate_sim_descriptor): Update.
 898         (get_sim_inferior_data): Use new.  Update.
 899         (~sim_inferior_data_cleanup): Rename from
 900         sim_inferior_data_cleanup.  Simplify.
 901         (gdbsim_close_inferior, simulator_command)
 902         (sim_command_completer, _initialize_remote_sim): Update.
 903         (next_pid, INITIAL_PID): Move earlier.
 904
 905 2019-07-10  Tom Tromey  <tromey@adacore.com>
 906
 907         * python/python-internal.h (create_thread_object): Return
 908         gdbpy_ref.
 909         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 910         * python/py-inferior.c (struct threadlist_entry): Add
 911         constructor.
 912         <thread_obj>: Now a gdbpy_ref.
 913         (thread_to_thread_object): Update.
 914         (add_thread_object): Use new.
 915         (delete_thread_object): Use delete.
 916         (infpy_threads): Update.
 917         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 918         GIL.
 919
 920 2019-07-10  Tom Tromey  <tromey@adacore.com>
 921
 922         * valops.c (value_cast): Specialize error message for Ada.
 923
 924 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 925
 926         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 927
 928 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 929
 930         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 931         bpstat_should_step): Return bool, adjust comments.
 932         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 933         bpstat_should_step): Likewise.
 934
 935 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 936
 937         * features/Makefile: Use feature target descriptions for Arm.
 938         * features/arm/arm-core.c: Generate new file.
 939         * features/arm/arm-fpa.c: Likewise.
 940         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 941         * features/arm/arm-m-profile.c: Likewise.
 942         * features/arm/arm-vfpv2.c: Likewise.
 943         * features/arm/arm-vfpv3.c: Likewise.
 944         * features/arm/xscale-iwmmxt.c: Likewise.
 945         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 946
 947 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 948
 949         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 950         ptrace earlier.
 951
 952 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 953
 954         * features/aarch64-pauth.c: Regenerate.
 955
 956 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 957
 958         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 959         bool.
 960         (bpstat_what): Use false instead of 0.
 961
 962 2019-07-09  Pedro Alves  <palves@redhat.com>
 963
 964         * break-catch-throw.c (is_exception_catchpoint): New.
 965         * breakpoint.c (print_one_breakpoint_location): New parameter
 966         'raw_loc'.  Handle it.  Use
 967         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 968         looking at the breakpoint's type.
 969         (print_one_breakpoint): If handling "maint info breakpoints", also
 970         print locations of exception catchpoints.
 971         * breakpoint.h (is_exception_catchpoint): Declare.
 972
 973 2019-07-09  Pedro Alves  <palves@redhat.com>
 974
 975         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 976         "addr" field.
 977         (allocate_location_exception_catchpoint): New.
 978         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 979         (initialize_throw_catchpoint_ops): Install
 980         allocate_location_exception_catchpoint as allocate_location
 981         method.
 982         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 983         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 984         bp_loc_other.
 985         (breakpoint_address_is_meaningful): Delete.
 986         (bl_address_is_meaningful): New.
 987         (breakpoint_locations_match): Adjust comment.
 988         (bp_location_from_bp_type): New, factored out of...
 989         (bp_location::bp_location(breakpoint *)): ... this.
 990         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 991         factored out of...
 992         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 993         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 994         breakpoint_address_is_meaningful.
 995         (bp_locations_compare): Adjust comment.
 996         (update_global_location_list): Use bl_address_is_meaningful
 997         instead of breakpoint_address_is_meaningful.
 998         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 999         explicit.
1000         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1001         * python/py-breakpoint.c (bppy_get_location): No longer check
1002         whether location is null.
1003
1004 2019-07-09  Pedro Alves  <palves@redhat.com>
1005
1006         PR c++/15468
1007         * breakpoint.c (print_one_breakpoint_location): Remove
1008         single-location assert.
1009
1010 2019-07-09  Tom Tromey  <tom@tromey.com>
1011
1012         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1013         * configure: Rebuild.
1014         * configure.ac: Change common to gdbsupport.
1015         * gdbsupport: Rename from common.
1016         * acinclude.m4: Change common to gdbsupport.
1017         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1018         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1019         gdbsupport.
1020         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1021         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1022         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1023         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1024         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1025         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1026         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1027         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1028         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1029         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1030         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1031         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1032         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1033         coff-pe-read.c, command.h, compile/compile-c-support.c,
1034         compile/compile-c.h, compile/compile-cplus-symbols.c,
1035         compile/compile-cplus-types.c, compile/compile-cplus.h,
1036         compile/compile-loc2c.c, compile/compile.c, completer.c,
1037         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1038         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1039         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1040         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1041         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1042         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1043         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1044         features/aarch64-core.c, features/aarch64-fpu.c,
1045         features/aarch64-pauth.c, features/aarch64-sve.c,
1046         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1047         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1048         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1049         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1050         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1051         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1052         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1053         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1054         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1055         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1056         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1057         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1058         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1059         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1060         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1061         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1062         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1063         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1064         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1065         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1066         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1067         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1068         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1069         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1070         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1071         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1072         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1073         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1074         minsyms.c, mips-linux-tdep.c, namespace.h,
1075         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1076         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1077         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1078         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1079         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1080         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1081         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1082         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1083         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1084         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1085         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1086         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1087         procfs.c, producer.c, progspace.h, psymtab.h,
1088         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1089         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1090         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1091         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1092         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1093         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1094         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1095         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1096         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1097         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1098         target-memory.c, target.c, target.h, target/waitstatus.c,
1099         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1100         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1101         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1102         unittests/array-view-selftests.c,
1103         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1104         unittests/common-utils-selftests.c,
1105         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1106         unittests/format_pieces-selftests.c,
1107         unittests/function-view-selftests.c,
1108         unittests/lookup_name_info-selftests.c,
1109         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1110         unittests/mkdir-recursive-selftests.c,
1111         unittests/observable-selftests.c,
1112         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1113         unittests/parse-connection-spec-selftests.c,
1114         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1115         unittests/scoped_fd-selftests.c,
1116         unittests/scoped_mmap-selftests.c,
1117         unittests/scoped_restore-selftests.c,
1118         unittests/string_view-selftests.c, unittests/style-selftests.c,
1119         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1120         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1121         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1122         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1123         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1124         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1125
1126 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1127
1128         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1129         bool value.
1130         (decode_digits_ordinary): Set explicit_line field in sal.
1131         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1132         symtab_and_line that was set on an explicit line number in
1133         assembler code.  Do always update the recorded symtab and line if
1134         we do skip the prologue.
1135
1136 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1137
1138         * breakpoint.c (set_breakpoint_location_function): Remove
1139         explicit_loc parameter.
1140         (momentary_breakpoint_from_master): Update call to
1141         set_breakpoint_location_function.
1142         (add_location_to_breakpoint): Likewise.
1143
1144 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1145
1146         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1147         required features based on default bfd type when no specific bfd
1148         is present.
1149
1150 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1151
1152         * NEWS: Mention that GDB printf and eval commands can now print
1153         C-style and Ada-style convenience var strings without
1154         calling the inferior.
1155         * printcmd.c (printf_c_string): Locally print GDB internal var
1156         instead of transiting via the inferior.
1157         (printf_wide_c_string): Likewise.
1158
1159 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1160
1161         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1162
1163 2019-07-04  Tom Tromey  <tom@tromey.com>
1164
1165         PR tui/24724:
1166         * tui/tui-winsource.c (tui_clear_source_content): Update.
1167         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1168         (tui_update_breakpoint_info): Update.
1169         (tui_set_exec_info_content): Update.
1170         * tui/tui-source.c (tui_set_source_content_nil): Update.
1171         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1172         has_break.
1173         * tui/tui-data.h (enum tui_bp_flag): New.
1174         (tui_bp_flags): New enum flags type.
1175         (struct tui_source_element) <break_mode>: Change type.  Rename
1176         from has_break.
1177         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1178         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1179         constants.
1180         * tui/tui-winsource.h: Fix comment.
1181
1182 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1183
1184         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1185         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1186         (store_fpregs_to_thread)
1187         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1188         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1189         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1190         (IWMMXT_REGS_SIZE): Add define.
1191         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1192         (fetch_vfp_regs, store_vfp_regs)
1193         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1194         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1195
1196 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1197
1198         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1199         defines.
1200         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1201         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1202         (ARM_INT_REGISTER_SIZE): ...to this.
1203         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1204         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1205         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1206         (arm_linux_collect_gregset, supply_nwfpe_register)
1207         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1208         defines.
1209         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1210         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1211         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1212         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1213         (arm_return_in_memory, arm_store_return_value)
1214         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1215         (arm_record_ld_st_multiple): Likewise.
1216         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1217         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1218
1219 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1220
1221         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1222         AARCH64_DISPLACED_MODIFIED_INSNS.
1223         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1224         (aarch64_displaced_step_copy_insn): Likewise.
1225         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1226         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1227         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1228         ARM_DISPLACED_MODIFIED_INSNS.
1229         * arm-tdep.c (arm_gdbarch_init): Likewise.
1230         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1231         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1232         (struct arm_displaced_step_closure): Use
1233         ARM_DISPLACED_MODIFIED_INSNS.
1234
1235 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1236
1237         * features/Makefile: Remove unused xml files.
1238         * features/aarch64.xml: Remove.
1239         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1240         * features/i386/amd64-avx-avx512.xml: Remove.
1241         * features/i386/amd64-avx-linux.xml: Remove.
1242         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1243         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1244         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1245         * features/i386/amd64-avx-mpx.xml: Remove.
1246         * features/i386/amd64-avx.xml: Remove.
1247         * features/i386/amd64-linux.xml: Remove.
1248         * features/i386/amd64-mpx-linux.xml: Remove.
1249         * features/i386/amd64-mpx.xml: Remove.
1250         * features/i386/amd64.xml: Remove.
1251         * features/i386/i386-avx-avx512-linux.xml: Remove.
1252         * features/i386/i386-avx-avx512.xml: Remove.
1253         * features/i386/i386-avx-linux.xml: Remove.
1254         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1255         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1256         * features/i386/i386-avx-mpx-linux.xml: Remove.
1257         * features/i386/i386-avx-mpx.xml: Remove.
1258         * features/i386/i386-avx.xml: Remove.
1259         * features/i386/i386-linux.xml: Remove.
1260         * features/i386/i386-mmx-linux.xml: Remove.
1261         * features/i386/i386-mmx.xml: Remove.
1262         * features/i386/i386-mpx-linux.xml: Remove.
1263         * features/i386/i386-mpx.xml: Remove.
1264         * features/i386/i386.xml: Remove.
1265         * features/i386/x32-avx-avx512-linux.xml: Remove.
1266         * features/i386/x32-avx-linux.xml: Remove.
1267         * features/i386/x32-linux.xml: Remove.
1268
1269 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1270
1271         * regformats/aarch64.dat: Remove.
1272         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1273         * regformats/i386/amd64-avx-linux.dat: Remove.
1274         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1275         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1276         * regformats/i386/amd64-linux.dat: Remove.
1277         * regformats/i386/amd64-mpx-linux.dat: Remove.
1278         * regformats/i386/amd64.dat: Remove.
1279         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1280         * regformats/i386/i386-avx-linux.dat: Remove.
1281         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1282         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1283         * regformats/i386/i386-linux.dat: Remove.
1284         * regformats/i386/i386-mmx-linux.dat: Remove.
1285         * regformats/i386/i386-mpx-linux.dat: Remove.
1286         * regformats/i386/i386.dat: Remove.
1287         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1288         * regformats/i386/x32-avx-linux.dat: Remove.
1289         * regformats/i386/x32-linux.dat: Remove.
1290
1291 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1292
1293         * aarch64-tdep.c: Remove xml self tests.
1294         * amd64-linux-tdep.c: Likewise.
1295         * amd64-tdep.c: Likewise.
1296         * i386-linux-tdep.c: Likewise.
1297         * i386-tdep.c: Likewise.
1298
1299 2019-07-03  Pedro Alves  <palves@redhat.com>
1300
1301         PR cli/24732
1302         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1303         (pipe_cmd_option_defs): New.
1304         (make_pipe_cmd_options_def_group): New.
1305         (pipe_command): Use gdb::option::process_options.
1306         (pipe_command_completer): New function.
1307         (_initialize_cli_cmds): Install completer for "pipe" command.
1308
1309 2019-07-03  Pedro Alves  <palves@redhat.com>
1310
1311         * cli/cli-option.c (union option_value) <string>: New field.
1312         (struct option_def_and_value): Add ctor, move ctor, dtor and
1313         use DISABLE_COPY_AND_ASSIGN.
1314         (option_def_and_value::clear_value): New.
1315         (parse_option, save_option_value_in_ctx, get_val_type_str)
1316         (add_setshow_cmds_for_options): Handle var_string.
1317         * cli-option.h (union option_def::var_address) <string>: New
1318         field.
1319         (struct string_option_def): New.
1320         * maint-test-options.c (struct test_options_opts): Add default
1321         ctor and use DISABLE_COPY_AND_ASSIGN.
1322         <string_opt>: New field.
1323         (test_options_opts::~test_options_opts): New.
1324         (test_options_opts::dump): Also dump "-string".
1325         (test_options_option_defs): Install "string.
1326
1327 2019-07-03  Pedro Alves  <palves@redhat.com>
1328
1329         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1330         option_value with a null enumeration.
1331         (complete_options): Save the option values in the context.
1332         (save_option_value_in_ctx): New, factored out from ...
1333         (process_options): ... here.
1334         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1335         of the function.
1336         * maint-test-options.c (test_options_opts::dump): New, factored
1337         out from ...
1338         (maintenance_test_options_command_mode): ... here.
1339         (maintenance_test_options_command_completion_result): Delete.
1340         (maintenance_test_options_command_completion_text): Update
1341         comment.
1342         (maintenance_show_test_options_completion_result): Change
1343         prototype.  Just print
1344         maintenance_test_options_command_completion_text.
1345         (save_completion_result): New.
1346         (maintenance_test_options_completer_mode): Pass options context to
1347         complete_options, and then save a dump.
1348         (_initialize_maint_test_options): Use add_cmd to install "maint
1349         show test-options-completion-result".
1350
1351 2019-07-03  Pedro Alves  <palves@redhat.com>
1352
1353         * NEWS (New commands): Mention "with" and "maint with".
1354         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1355         (with_command, with_command_completer): New.
1356         (pipe_command): Adjust to new repeat_previous
1357         interface.
1358         (_initialize_cli_cmds): Install the "with" command and its "w"
1359         alias.
1360         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1361         declarations.
1362         * cli/cli-setshow.c (parse_cli_var_uinteger)
1363         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1364         argument strings for all var_types.
1365         (get_setshow_command_value_string): New, factored out from ...
1366         (do_show_command): ... this.
1367         * cli/cli-setshow.h: Include <string>.
1368         (get_setshow_command_value_string): Declare.
1369         * command.h (repeat_previous): Now returns const char *.  Adjust
1370         comment.
1371         * maint.c: Include "cli/cli-cmds.h".
1372         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1373         (_initialize_maint_cmds): Register the "maintenance with" command.
1374         * top.c (repeat_previous): Move bits from pipe_command here:
1375         Return the saved command line, if any; error out if there's no
1376         command to relaunch.
1377
1378 2019-07-03  Pedro Alves  <palves@redhat.com>
1379
1380         * NEWS (New commands): Mention "maint set/show test-settings"
1381         instead of "maint test-settings".
1382         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1383         (maintenance_test_settings_set_list): Rename to ...
1384         (maintenance_set_test_settings_list): ... this.
1385         (maintenance_test_settings_show_list): Rename to  ...
1386         (maintenance_show_test_settings_list): ... this.
1387         (maintenance_test_settings_cmd): Delete.
1388         (maintenance_test_settings_set_cmd): ...
1389         (maintenance_set_test_settings_cmd): ... this.
1390         (maintenance_test_settings_show_cmd): ...
1391         (maintenance_show_test_settings_cmd): ... this.
1392         (maintenance_test_settings_show_value_cmd):
1393         (maintenance_show_test_settings_value_cmd): ... this.
1394         (_initialize_maint_test_settings): No longer install the "maint
1395         test-settings" prefix command.  Rename "maint test-settings set"
1396         to "maint set test-settings", and "maint test-settings show" to
1397         "maint show test-settings".  Adjust all subcommands.
1398
1399 2019-07-03  Pedro Alves  <palves@redhat.com>
1400
1401         * maint-test-settings.c: Fix file's intro comment.  Replace all
1402         references to "test-options" with references to "test-settings",
1403         in comments.
1404
1405 2019-07-03  Pedro Alves  <palves@redhat.com>
1406
1407         * maint-test-settings.c (maintenance_test_settings_xxx)
1408         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1409         New.
1410         (maintenance_test_settings_enums): Use them.
1411         (maintenance_test_settings_enum): Default to
1412         maintenance_test_settings_xxx.
1413         (_initialize_maint_test_settings): Initialize
1414         MAINTENANCE_TEST_SETTINGS_FILENAME.
1415
1416 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1417
1418         * breakpoint.h (remove_breakpoints_inf): Change return type to
1419         void, move function documentation here.
1420         * breakpoint.c (remove_breakpoints_inf): Change return type to
1421         void, move function documentation to header.
1422
1423 2019-07-02  Pedro Alves  <palves@redhat.com>
1424
1425         * NEWS (Completion improvements): Mention "info threads".
1426         * thread.c (struct info_threads_opts, info_threads_option_defs)
1427         (make_info_threads_options_def_group): New.
1428         (info_threads_command): Use gdb::option::process_options.
1429         (info_threads_command_completer): New.
1430         (_initialize_thread): Use gdb::option::build_help to build the
1431         help text for "info threads".
1432
1433 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1434
1435         * defs.h (generic_load): Move from here...
1436         * symfile.h (generic_load): ... to here.  Rename name parameter
1437         to args.
1438         * symfile.c (generic_load): Add comment.
1439
1440 2019-07-01  Tom Tromey  <tromey@adacore.com>
1441
1442         * dwarf2read.c
1443         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1444         declaration of without_params.  Fix formatting.
1445
1446 2019-07-01  Tom Tromey  <tromey@adacore.com>
1447
1448         * ada-exp.y (find_primitive_type): Update.
1449         * ada-lang.h (ada_lookup_symbol): Update.
1450         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1451         parameter.
1452         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1453
1454 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1455
1456         PR breakpoints/24541
1457         * gdbarch.c: Regenerate.
1458         * gdbarch.h: Regenerate.
1459         * gdbarch.sh: Add 'stap_adjust_register'.
1460         * i386-tdep.c: Include '<unordered_set>'.
1461         (i386_stap_adjust_register): New function.
1462         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1463         * stap-probe.c (stap_parse_register_operand): Call
1464         'gdbarch_stap_adjust_register'.
1465
1466 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1467
1468         PR python/24742
1469         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1470         * python/python.c (do_start_initialization): Use 'xmalloc'
1471         instead of 'PyMem_Malloc'.
1472
1473 2019-06-28  Tom Tromey  <tromey@adacore.com>
1474
1475         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1476         for Ada.
1477
1478 2019-06-27  Tom Tromey  <tromey@adacore.com>
1479
1480         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1481         objfile_key.
1482         (arm_find_mapping_symbol, arm_record_special_symbol)
1483         (_initialize_arm_tdep): Update.
1484         (arm_objfile_data_free): Remove.
1485
1486 2019-06-27  Tom Tromey  <tromey@adacore.com>
1487
1488         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1489         to cp_print_static_field.
1490
1491 2019-06-26  Tom Tromey  <tromey@adacore.com>
1492
1493         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1494         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1495         declare.
1496
1497 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1498
1499         * features/aarch64-core.c (create_feature_aarch64_core):
1500         Regenerate.
1501         * features/aarch64-core.xml: Add cpsr flags.
1502
1503 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1504
1505         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1506         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1507
1508 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1509
1510         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1511         field.
1512         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1513         use.
1514         (arm_record_special_symbol): Don't insert new symbol in sorted
1515         position, push it at the end.
1516
1517 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1518
1519         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1520         (arm_mapping_symbol_s): Remove.
1521         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1522         (arm_mapping_symbol_vec): New typedef.
1523         (struct arm_per_objfile): Add constructor.
1524         <section_maps>: Change type to
1525         std::unique_ptr<arm_mapping_symbol_vec[]>.
1526         (arm_compare_mapping_symbols): Remove.
1527         (arm_find_mapping_symbol): Adjust to section_maps type change.
1528         (arm_objfile_data_free): Call delete on arm_per_objfile.
1529         (arm_record_special_symbol): Adjust to section_maps type change.
1530         Allocate arm_per_objfile with new.
1531
1532 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1533
1534         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1535         with the command prefix.
1536
1537 2019-06-25  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1540         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1541
1542 2019-06-25  Tom Tromey  <tom@tromey.com>
1543
1544         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1545         type.
1546         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1547         protected.
1548
1549 2019-06-25  Tom Tromey  <tom@tromey.com>
1550
1551         * tui/tui-winsource.c
1552         (tui_source_window_base::set_is_exec_point_at): Add check against
1553         LOA_ADDRESS.
1554
1555 2019-06-25  Tom Tromey  <tom@tromey.com>
1556
1557         * tui/tui-source.c (tui_set_source_content): Don't check before
1558         xfree.
1559         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1560
1561 2019-06-25  Tom Tromey  <tom@tromey.com>
1562
1563         * tui/tui-winsource.h (tui_update_source_window_as_is)
1564         (tui_alloc_source_buffer, tui_line_is_displayed)
1565         (tui_addr_is_displayed): Change type of win_info.
1566         * tui/tui-winsource.c (tui_update_source_window_as_is)
1567         (tui_clear_source_content, tui_show_source_line)
1568         (tui_show_source_content, tui_source_window_base::refill)
1569         (tui_source_window_base::set_is_exec_point_at)
1570         (tui_source_window_base::set_is_exec_point_at)
1571         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1572         (tui_alloc_source_buffer, tui_line_is_displayed)
1573         (tui_addr_is_displayed): Change type of win_info.  Update.
1574         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1575         (tui_source_window_base::do_make_visible_with_new_height):
1576         Update.
1577         * tui/tui-source.c (tui_set_source_content)
1578         (tui_set_source_content_nil)
1579         (tui_source_window::do_scroll_vertical): Update.
1580         * tui/tui-layout.c (show_layout): Update.
1581         * tui/tui-disasm.c (tui_set_disassem_content)
1582         (tui_disasm_window::do_scroll_vertical): Update.
1583         * tui/tui-data.h (tui_win_content): Remove.
1584         (struct tui_gen_win_info) <content, content_size>: Remove.
1585         (struct tui_source_element): Add initializers and destructor.
1586         (union tui_which_element, struct tui_win_element): Remove.
1587         (struct tui_source_window_base) <content>: New field.
1588         (struct tui_data_window): Remove destructor.
1589         (tui_alloc_content, tui_free_win_content)
1590         (tui_free_all_source_wins_content): Don't declare.
1591         * tui/tui-data.c (tui_initialize_static_data): Update.
1592         (init_content_element, tui_alloc_content): Remove.
1593         (~tui_gen_win_info): Update.
1594         (~tui_data_window, tui_free_all_source_wins_content)
1595         (tui_free_win_content, free_content, free_content_elements):
1596         Remove.
1597
1598 2019-06-25  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-winsource.h (tui_clear_source_content)
1601         (tui_erase_source_content, tui_show_source_content): Change type
1602         of win_info.
1603         * tui/tui-winsource.c (tui_clear_source_content)
1604         (tui_erase_source_content, tui_show_source_content): Change type
1605         of win_info.
1606         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1607         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1608         win_info.
1609         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1610         win_info.
1611         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1612
1613 2019-06-25  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-winsource.c (tui_clear_source_content)
1616         (tui_source_window_base::set_is_exec_point_at): Update.
1617         * tui/tui-source.c (tui_set_source_content_nil): Update.
1618         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1619         a bool.
1620         * tui/tui-data.c (init_content_element): Update.
1621
1622 2019-06-25  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1625         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1626         * tui/tui-layout.c (init_and_make_win): Update.
1627         * tui/tui.h (enum tui_win_type): Update.
1628         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1629         tui_win_is_auxillary.
1630         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1631         tui_win_is_auxillary.
1632
1633 2019-06-25  Tom Tromey  <tom@tromey.com>
1634
1635         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1636         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1637         (tui_delete_data_content_windows, tui_display_all_data)
1638         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1639         Update.
1640         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1641         * tui/tui-regs.c (tui_last_regs_line_no)
1642         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1643         (tui_show_registers): Update.
1644         (tui_show_register_group): Return void.  Update.
1645         (tui_display_registers_from, tui_display_reg_element_at_line)
1646         (tui_display_registers_from_line, tui_check_register_values):
1647         Update.
1648         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1649         member.
1650         (struct tui_data_window) <regs_content>: Now a std::vector.
1651         <regs_content_count>: Remove.
1652         (tui_add_content_elements, tui_free_data_content): Don't declare.
1653         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1654         (init_content_element): Remove DATA_WIN case.  Add assert.
1655         (tui_add_content_elements): Remove.
1656         (tui_data_window): Update.
1657         (tui_free_data_content): Remove.
1658         (free_content_elements): Remove DATA_WIN case.
1659
1660 2019-06-25  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-data.c (tui_data_item_window): Update.
1663         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1664         * tui/tui-windata.c (tui_display_all_data)
1665         (tui_display_data_from_line): Update.
1666         (tui_check_data_values): Remove.
1667         * tui/tui-regs.c (tui_show_register_group)
1668         (tui_display_reg_element_at_line): Update.
1669         * tui/tui-hooks.c (tui_register_changed)
1670         (tui_refresh_frame_and_register_information): Call
1671         tui_check_register_values.
1672         * tui/tui-data.h (struct tui_data_window) <data_content,
1673         data_content_count, data_type>: Remove.
1674         (enum tui_data_type): Remove.
1675
1676         * tui/tui-data.c (tui_data_window::clear_detail)
1677         (~tui_data_window): Update.
1678
1679 2019-06-25  Tom Tromey  <tom@tromey.com>
1680
1681         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1682         declare.
1683         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1684         Rename from tui_first_data_item_displayed.  Update.
1685         (tui_data_window::refresh_all)
1686         (tui_data_window::do_scroll_vertical): Update.
1687         * tui/tui-data.h (struct tui_data_window)
1688         <first_data_item_displayed>: Declare new method.
1689
1690 2019-06-25  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1693         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1694         contents...
1695         (tui_initialize_static_data): ...here.
1696
1697 2019-06-25  Tom Tromey  <tom@tromey.com>
1698
1699         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1700         (tui_display_registers_from, tui_check_register_values): Update.
1701         (tui_display_register): Remove win_info parameter; update.
1702         (tui_get_register): Change type of parameters.
1703         * tui/tui-data.h (struct tui_data_element): Remove.
1704         (union tui_which_element) <data>: Remove.
1705         <data_window>: Change type.
1706         (struct tui_data_item_window): New.
1707         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1708         case.  Add assert.
1709         (~tui_data_item_window): New destructor.
1710         (free_content_elements): Remove DATA_ITEM_WIN case.
1711
1712 2019-06-25  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1715         Remove.
1716
1717 2019-06-25  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-data.h (struct tui_command_element): Remove.
1720         (union tui_which_element) <command>: Remove.
1721         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1722         assert.
1723         (free_content_elements): Remove CMD_WIN case.
1724
1725 2019-06-25  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-layout.c (tui_set_layout): Update.
1728         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1729         * tui/tui-data.c (layout_def): Update.
1730
1731 2019-06-25  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1734         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1735         (tui_source_window_base::set_new_height): Update.
1736         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1737         Update.
1738         (tui_set_locator_fullname, tui_set_locator_info)
1739         (tui_show_frame_info): Update.
1740         * tui/tui-source.c (tui_set_source_content)
1741         (tui_source_is_displayed): Update.
1742         * tui/tui-layout.c (show_source_disasm_command, show_data)
1743         (show_source_or_disasm_and_command): Update.
1744         * tui/tui-disasm.c (tui_set_disassem_content)
1745         (tui_get_begin_asm_address): Update.
1746         * tui/tui-data.h (struct tui_locator_element): Remove.
1747         (union tui_which_element) <locator>: Remove.
1748         (struct tui_locator_window): New.
1749         (tui_locator_win_info_ptr): Change return type.
1750         * tui/tui-data.c (_locator): Change type.
1751         (tui_locator_win_info_ptr): Change return type.
1752         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1753         (tui_alloc_content): Add assert.
1754
1755 2019-06-25  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-winsource.c
1758         (tui_exec_info_window::maybe_allocate_content): New method.
1759         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1760         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1761         (make_source_or_disasm_window): Add cast.
1762         * tui/tui-data.h (union tui_which_element) <simple_string>:
1763         Remove.
1764         (struct tui_source_info): New.
1765         (struct tui_source_window_base) <execution_info>: Change type.
1766         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1767         case, and add assert.
1768         (tui_alloc_content): Add assert.
1769
1770 2019-06-25  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1773         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1774         * tui/tui-data.c (tui_alloc_win_info): Remove.
1775
1776 2019-06-25  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1779         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1780         can_highlight.
1781
1782 2019-06-25  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1785         make_visible_with_new_height method.
1786         (tui_win_info::make_visible_with_new_height): New method.
1787         (tui_source_window_base::do_make_visible_with_new_height)
1788         (tui_data_window::do_make_visible_with_new_height)
1789         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1790         (make_visible_with_new_height): Remove.
1791         (tui_resize_all, tui_adjust_win_heights): Use
1792         make_visible_with_new_height method.
1793         * tui/tui-data.h (struct tui_win_info)
1794         <do_make_visible_with_new_height, make_visible_with_new_height>:
1795         New methods.
1796         (struct tui_source_window_base, struct tui_data_window)
1797         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1798         methods.
1799
1800 2019-06-25  Tom Tromey  <tom@tromey.com>
1801
1802         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1803         method.
1804         (update_tab_width): Call update_tab_width method.
1805         * tui/tui-data.h (struct tui_win_info)
1806         (struct tui_source_window_base) <update_tab_width>: New methods.
1807
1808 2019-06-25  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1811         parameter.
1812         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1813         parameter.
1814         (tui_gen_win_info::make_visible): Update.
1815         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1816         parameter.
1817         * tui/tui-data.h (enum tui_box): New enum.
1818         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1819
1820 2019-06-25  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1823         init_and_make_win for EXEC_INFO_WIN.
1824         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1825         longer inline.
1826         (struct tui_win_info) <~tui_win_info>: Inline.
1827         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1828         Don't declare.
1829         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1830         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1831         Remove.
1832         (tui_initialize_static_data): Update.
1833         (~tui_gen_win_info): Handle more cleanup here.
1834         (~tui_source_window_base): Delete "execution_info".
1835         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1836
1837 2019-06-25  Tom Tromey  <tom@tromey.com>
1838
1839         * tui/tui-layout.c (make_command_window): Don't set
1840         can_highlight.
1841         (show_source_disasm_command): Call the reset method.
1842         (show_data): Don't set can_highlight.  Call the reset method.
1843         (tui_gen_win_info::reset): Rename from init_gen_win_info
1844         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1845         (show_source_or_disasm_and_command): Call the reset method.
1846         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1847         (struct tui_cmd_window): Set can_highlight.
1848
1849 2019-06-25  Tom Tromey  <tom@tromey.com>
1850
1851         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1852         from make_visible.
1853         (tui_make_visible, tui_make_invisible): Rewrite.
1854         (tui_win_info::make_visible): Remove.
1855         (tui_source_window_base::make_visible): Update.
1856         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1857         method.  Moved from...
1858         (struct tui_win_info) <make_visible>: ...here.
1859
1860 2019-06-25  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-winsource.c
1863         (tui_source_window_base::do_scroll_horizontal): Remove direction
1864         parameter.
1865         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1866         direction parameter.
1867         * tui/tui-win.c (tui_win_info::forward_scroll)
1868         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1869         (tui_win_info::right_scroll): Update.
1870         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1871         direction parameter.
1872         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1873         direction parameter.
1874         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1875         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1876         Remove direction parameter.
1877         (struct tui_source_window_base, struct tui_source_window)
1878         (struct tui_disasm_window, struct tui_data_window)
1879         (struct tui_cmd_window): Update.
1880
1881 2019-06-25  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-winsource.h (tui_set_exec_info_content)
1884         (tui_show_exec_info_content, tui_erase_exec_info_content)
1885         (tui_clear_exec_info_content, tui_update_exec_info): Change
1886         argument to tui_source_window_base.
1887         * tui/tui-winsource.c (tui_set_exec_info_content)
1888         (tui_show_exec_info_content, tui_erase_exec_info_content)
1889         (tui_clear_exec_info_content, tui_update_exec_info): Change
1890         argument to tui_source_window_base.
1891
1892 2019-06-25  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1895         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1896
1897 2019-06-25  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1900         check.
1901
1902 2019-06-25  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1905         type to void.
1906         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1907         type to void.
1908         * tui/tui-source.c (tui_set_source_content): Update.
1909         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1910
1911 2019-06-25  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-win.c (window_name_completer, tui_set_focus)
1914         (tui_all_windows_info): Use name method.
1915         * tui/tui-data.h (struct tui_gen_win_info)
1916         (struct tui_source_window, struct tui_disasm_window)
1917         (struct tui_data_window, struct tui_cmd_window) <name>: New
1918         method.
1919         (tui_win_name): Don't declare.
1920         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1921         (tui_win_name): Remove.
1922
1923 2019-06-25  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-winsource.h (tui_update_source_window)
1926         (tui_update_source_window_as_is): Change parameter type.
1927         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1928         to be a tui_source_window_base.
1929         (tui_update_source_window_as_is): Likewise.
1930         * tui/tui-win.c (make_visible_with_new_height): Update.
1931
1932 2019-06-25  Tom Tromey  <tom@tromey.com>
1933
1934         * tui/tui-winsource.c (tui_erase_source_content)
1935         (tui_show_source_content, tui_show_exec_info_content)
1936         (tui_erase_exec_info_content): Use refresh_window method.
1937         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1938         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1939         from tui_refresh_win.
1940         (tui_data_window::refresh_window): New method.
1941         (tui_win_info::refresh, tui_source_window_base::refresh)
1942         (tui_refresh_all): Use refresh_window method.
1943         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1944         method.
1945         * tui/tui-regs.c (tui_display_register): Call refresh_window
1946         method.
1947         * tui/tui-layout.c (show_source_disasm_command)
1948         (show_source_or_disasm_and_command): Call refresh_window method.
1949         * tui/tui-data.h (struct tui_gen_win_info)
1950         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1951         New method.
1952
1953 2019-06-25  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui.c (tui_rl_other_window, tui_enable)
1956         (tui_is_window_visible, tui_get_command_dimension): Update.
1957         * tui/tui-winsource.c (tui_update_source_window_as_is)
1958         (tui_clear_source_content, tui_erase_source_content)
1959         (tui_show_source_line, tui_source_window_base::refill)
1960         (tui_source_window_base::do_scroll_horizontal)
1961         (tui_source_window_base::set_is_exec_point_at)
1962         (tui_update_breakpoint_info, tui_set_exec_info_content)
1963         (tui_alloc_source_buffer, tui_line_is_displayed)
1964         (tui_addr_is_displayed): Update.
1965         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1966         (tui_check_and_display_highlight_if_needed)
1967         (tui_win_info::make_visible, tui_win_info::refresh)
1968         (tui_refresh_all): Update.
1969         * tui/tui-windata.c (tui_first_data_item_displayed)
1970         (tui_delete_data_content_windows, tui_erase_data_content)
1971         (tui_display_all_data, tui_data_window::refresh_all)
1972         (tui_check_data_values): Update.
1973         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1974         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1975         (tui_win_info::backward_scroll, tui_refresh_all_win)
1976         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1977         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1978         (tui_source_window_base::set_new_height)
1979         (tui_data_window::set_new_height)
1980         (make_invisible_and_set_new_height)
1981         (make_visible_with_new_height, new_height_ok)
1982         (parse_scrolling_args): Update.
1983         * tui/tui-stack.c (tui_show_frame_info): Update.
1984         * tui/tui-source.c (tui_set_source_content)
1985         (tui_set_source_content_nil, tui_source_is_displayed)
1986         (tui_source_window::do_scroll_vertical): Update.
1987         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1988         (tui_display_registers_from, tui_display_reg_element_at_line)
1989         (tui_check_register_values, tui_reg_command): Update.
1990         * tui/tui-layout.c (tui_default_win_height)
1991         (show_source_disasm_command, show_data, init_and_make_win)
1992         (show_source_or_disasm_and_command): Update.
1993         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1994         (tui_redisplay_readline, tui_mld_flush)
1995         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1996         (tui_getc): Update.
1997         * tui/tui-disasm.c (tui_set_disassem_content)
1998         (tui_disasm_window::do_scroll_vertical): Update.
1999         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2000         Now virtual.
2001         (struct tui_win_info): Derive from tui_gen_win_info.
2002         <~tui_win_info>: Mark as override.
2003         <generic>: Remove member.
2004         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2005         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2006         (~tui_data_window, ~tui_win_info)
2007         (tui_free_all_source_wins_content): Update.
2008         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-layout.c (init_and_make_win): Use new.
2013         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2014         destructor, initializers.
2015         (tui_alloc_generic_win_info): Don't declare.
2016         * tui/tui-data.c (_locator): Add argument to constructor.
2017         (source_win, disasm_win): New globals.
2018         (exec_info): Remove.
2019         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2020         Update.
2021         (tui_alloc_generic_win_info): Remove.
2022         (init_content_element): Use new.
2023         (tui_win_info::tui_win_info): Update.
2024         (free_content_elements) <case DATA_WIN>: Use delete.
2025
2026 2019-06-25  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2029         * tui/tui-windata.c (tui_first_data_item_displayed)
2030         (tui_delete_data_content_windows): Update.
2031         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2032         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2033         (tui_display_registers_from, tui_check_register_values): Update.
2034         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2035         pointer.
2036         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2037         window.
2038         (tui_free_data_content): Update.
2039         (free_content_elements) <case DATA_WIN>: Free the window.
2040
2041 2019-06-25  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2044         Update.
2045         * tui/tui-layout.c (make_command_window)
2046         (show_source_disasm_command, show_data, init_and_make_win)
2047         (show_source_or_disasm_and_command): Update.
2048         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2049         method.
2050         <can_highight, is_highlighted>: Now bool.
2051         (tui_set_win_highlight): Don't declare.
2052         * tui/tui-data.c (tui_set_win_highlight): Remove.
2053
2054 2019-06-25  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-wingeneral.c (make_visible): Remove check of window
2057         type.
2058
2059 2019-06-25  Tom Tromey  <tom@tromey.com>
2060
2061         * tui/tui-win.c (tui_win_info::max_height)
2062         (tui_cmd_window::max_height): New methods.
2063         (new_height_ok): Call max_height.
2064         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2065         <max_height>: New method.
2066
2067 2019-06-25  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-win.c (tui_source_window_base::set_new_height)
2070         (tui_data_window::set_new_height): New methods.
2071         (make_invisible_and_set_new_height): Call set_new_height method.
2072         * tui/tui-data.h (struct tui_win_info)
2073         (struct tui_source_window_base, struct tui_data_window)
2074         <set_new_height>: New method.
2075
2076 2019-06-25  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2079         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2080         tui_refresh_data_win.
2081         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2082         method.
2083         (tui_refresh_all_win): Call the refresh_all method.
2084         (tui_set_focus): Likewise.
2085         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2086         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2087         Likewise.
2088
2089 2019-06-25  Tom Tromey  <tom@tromey.com>
2090
2091         * tui/tui-winsource.h (tui_refill_source_window)
2092         (tui_set_is_exec_point_at): Don't declare.
2093         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2094         (tui_source_window_base::refill): Rename from
2095         tui_refill_source_window.
2096         (tui_source_window_base::do_scroll_horizontal): Update.
2097         (tui_source_window_base::set_is_exec_point_at): Rename from
2098         tui_set_is_exec_point_at.
2099         (tui_update_all_breakpoint_info): Update.
2100         * tui/tui-stack.c (tui_show_frame_info): Update.
2101         * tui/tui-layout.c (show_data): Add cast.
2102         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2103         * tui/tui-data.h (struct tui_source_window_base) <refill,
2104         set_is_exec_point_at>: New methods.
2105         (tui_source_windows, tui_add_to_source_windows): Update types.
2106         (tui_add_to_source_windows): Remove redundant declaration.
2107         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2108         (tui_source_windows): Change return type.
2109         (tui_clear_source_windows_detail): Update.
2110         (tui_add_to_source_windows): Change type of parameter.
2111         (tui_free_all_source_wins_content): Update.
2112
2113 2019-06-25  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-wingeneral.c (tui_win_info::refresh)
2116         (tui_source_window_base::refresh): New methods.
2117         (tui_refresh_all): Call the refresh method.
2118         * tui/tui-data.h (struct tui_win_info)
2119         (struct tui_source_window_base) <refresh>: New method.
2120
2121 2019-06-25  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui.h (tui_is_window_visible): Return bool.
2124         * tui/tui.c (tui_is_window_visible): Return bool.
2125         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2126         (tui_make_visible, tui_make_invisible)
2127         (tui_win_info::make_visible)
2128         (tui_source_window_base::make_visible, make_all_visible)
2129         (tui_make_all_visible, tui_make_all_invisible): Update.
2130         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2131         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2132         bool.
2133         (struct tui_win_info, struct tui_source_window_base)
2134         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2135         * tui/tui-data.c (tui_init_generic_part): Update.
2136
2137 2019-06-25  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2140         (tui_source_window_base::make_visible): New methods.
2141         (make_all_visible): Make method call.
2142         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2143         (struct tui_source_window_base, struct tui_cmd_window): Override
2144         make_visible.
2145         (tui_win_is_source_type): Don't declare.
2146         * tui/tui-data.c (tui_win_is_source_type): Remove.
2147
2148 2019-06-25  Tom Tromey  <tom@tromey.com>
2149
2150         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2151         NULL check.
2152
2153 2019-06-25  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2156         Inline constructor.  Add initializers for members.
2157         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2158         constructors; now inline in class.
2159
2160 2019-06-25  Tom Tromey  <tom@tromey.com>
2161
2162         * tui/tui-regs.c (tui_show_registers): Update.
2163         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2164         bool.
2165         * tui/tui-data.c (tui_data_window::clear_detail)
2166         (tui_data_window): Update.
2167
2168 2019-06-25  Tom Tromey  <tom@tromey.com>
2169
2170         * tui/tui-windata.c (tui_display_all_data)
2171         (tui_display_data_from_line, tui_display_data_from)
2172         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2173         Update.
2174         * tui/tui-regs.c (tui_last_regs_line_no)
2175         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2176         (tui_show_registers, tui_show_register_group)
2177         (tui_display_registers_from, tui_display_reg_element_at_line)
2178         (tui_display_registers_from_line, tui_check_register_values)
2179         (tui_reg_next, tui_reg_prev): Update.
2180         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2181         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2182         tui_data_window.
2183         (struct tui_win_info) <detail>: Remove.  Add new fields from
2184         tui_data_info.
2185         (TUI_DATA_WIN): Add cast.
2186         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2187         (~tui_data_window): Simplify.
2188
2189 2019-06-25  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-layout.c (show_source_disasm_command)
2192         (show_source_or_disasm_and_command): Update.
2193         * tui/tui-io.c (update_cmdwin_start_line)
2194         (tui_redisplay_readline): Update.
2195         * tui/tui-data.h (struct tui_command_info): Remove.
2196         (struct tui_win_info) <detail>: Remove command_info member.
2197         (struct tui_data_window) <start_line>: New member, from
2198         tui_command_info.
2199         (TUI_CMD_WIN): Add casts.
2200
2201 2019-06-25  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-winsource.c (tui_update_source_window)
2204         (tui_refill_source_window)
2205         (tui_source_window_base::do_scroll_horizontal)
2206         (tui_update_breakpoint_info, tui_set_exec_info_content)
2207         (tui_show_exec_info_content, tui_erase_exec_info_content)
2208         (tui_clear_exec_info_content): Update.
2209         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2210         Update.
2211         * tui/tui-win.c (make_invisible_and_set_new_height)
2212         (make_visible_with_new_height): Update.
2213         * tui/tui-source.c (tui_set_source_content)
2214         (tui_show_symtab_source): Update.
2215         * tui/tui-layout.c (extract_display_start_addr)
2216         (show_source_disasm_command, show_data)
2217         (make_source_or_disasm_window)
2218         (show_source_or_disasm_and_command): Update.
2219         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2220         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2221         "gdbarch".
2222         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2223         to tui_source_window_base.
2224         (struct tui_win_info) <detail>: Remove source_info member.
2225         (struct tui_source_window_base) <has_locator>: Inline.
2226         Move contents from tui_source_info; rename has_locator member to
2227         m_has_locator.
2228         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2229         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2230         header file.
2231         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2232         Simplify.
2233         (tui_free_all_source_wins_content): Cast to
2234         tui_source_window_base.
2235
2236 2019-06-25  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-win.c (make_invisible_and_set_new_height)
2239         (make_visible_with_new_height): Call has_locator method.
2240         * tui/tui-layout.c (show_source_disasm_command, show_data)
2241         (show_source_or_disasm_and_command): Update for bool change.
2242         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2243         (tui_win_info) <has_locator>: New method.
2244         (struct tui_source_window_base) <has_locator>: New method.
2245         (tui_win_has_locator): Don't declare.
2246         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2247         from tui_win_has_locator.
2248         (tui_source_window_base): Use false, not FALSE.
2249
2250 2019-06-25  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2253         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2254         clear_detail method directly.
2255         (tui_clear_win_detail): Remove.
2256
2257 2019-06-25  Tom Tromey  <tom@tromey.com>
2258
2259         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2260         "this", not TUI_DISASM_WIN.
2261
2262 2019-06-25  Tom Tromey  <tom@tromey.com>
2263
2264         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2265         declare.
2266         * tui/tui-winsource.c
2267         (tui_source_window_base::do_scroll_horizontal): Rename from
2268         tui_horizontal_source_scroll.
2269         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2270         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2271         from tui_vertical_data_scroll.
2272         * tui/tui-win.h (tui_scroll): Don't declare.
2273         * tui/tui-win.c (tui_win_info::forward_scroll)
2274         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2275         (tui_win_info::right_scroll): Rename and update.
2276         (tui_scroll_forward_command, tui_scroll_backward_command)
2277         (tui_scroll_left_command, tui_scroll_right_command): Update.
2278         (tui_scroll): Remove.
2279         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2280         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2281         from tui_vertical_source_scroll.
2282         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2283         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2284         from tui_vertical_disassem_scroll.
2285         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2286         do_scroll_horizontal>: New methods.
2287         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2288         Likewise.
2289         (struct tui_source_window_base): Add do_scroll_horizontal.
2290         (struct tui_source_window, struct tui_disasm_window): Add
2291         do_scroll_vertical.
2292         (struct tui_data_window, struct tui_cmd_window): Add
2293         do_scroll_horizontal and do_scroll_vertical.
2294         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2295
2296 2019-06-25  Tom Tromey  <tom@tromey.com>
2297
2298         * tui/tui-data.h (struct tui_source_window_base): New struct.
2299         (struct tui_source_window): Derive from tui_source_window_base.
2300         (struct tui_disasm_window): New struct.
2301         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2302         from tui_source_window::clear_detail.
2303         (tui_source_window_base): Rename from tui_source_window.
2304         (~tui_source_window_base): Rename from ~tui_source_window.
2305         (tui_alloc_win_info): Create a tui_disasm_window.
2306
2307 2019-06-25  Tom Tromey  <tom@tromey.com>
2308
2309         * tui/tui-data.h (struct tui_source_window)
2310         (struct tui_data_window): Declare destructors.
2311         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2312         destructors.
2313         (tui_win_info): Simplify.
2314
2315 2019-06-25  Tom Tromey  <tom@tromey.com>
2316
2317         * tui/tui-winsource.c (tui_display_main)
2318         (tui_update_source_windows_with_addr)
2319         (tui_update_all_breakpoint_info): Update.
2320         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2321         (new_height_ok, parse_scrolling_args): Update.
2322         * tui/tui-stack.c (tui_show_frame_info): Update.
2323         * tui/tui-data.h (struct tui_list): Remove.
2324         (tui_source_windows): Return a reference to a std::vector.
2325         * tui/tui-data.c (source_windows): Now a std::vector.
2326         (tui_source_windows): Change return type.
2327         (tui_clear_source_windows): Rewrite.
2328         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2329         (tui_free_all_source_wins_content): Rewrite.
2330
2331 2019-06-25  Tom Tromey  <tom@tromey.com>
2332
2333         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2334         (struct tui_data_window, struct tui_cmd_window): Declare
2335         clear_detail method.
2336         * tui/tui-data.c (tui_source_window::clear_detail)
2337         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2338         methods.
2339         (tui_clear_win_detail): Simplify.
2340
2341 2019-06-25  Tom Tromey  <tom@tromey.com>
2342
2343         * tui/tui-layout.c (make_source_window, make_disasm_window)
2344         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2345         Return the new window.
2346         (show_source_disasm_command, show_data)
2347         (show_source_or_disasm_and_command): Update.
2348
2349 2019-06-25  Tom Tromey  <tom@tromey.com>
2350
2351         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2352         parameter.  Return the new window.
2353         (show_source_disasm_command): Update and remove NULL check.
2354         (show_source_or_disasm_and_command): Update.
2355
2356 2019-06-25  Tom Tromey  <tom@tromey.com>
2357
2358         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2359
2360 2019-06-25  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-data.h (struct tui_win_info): Make constructor
2363         protected.  Make destructor virtual.  Add initializers.
2364         (tui_source_window, tui_data_window, tui_cmd_window): New
2365         classes.
2366         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2367         constructor.  Add "type" parameter.
2368         (tui_source_window, tui_data_window, tui_cmd_window): New
2369         constructors.
2370         (tui_alloc_win_info): Instantiate the appropriate subclass.
2371
2372 2019-06-25  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-win.c (tui_resize_all): Use delete.
2375         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2376         destructor.
2377         (tui_free_window): Don't declare.
2378         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2379         Update.
2380
2381 2019-06-25  Tom Tromey  <tom@tromey.com>
2382
2383         * tui/tui-data.h (struct tui_win_info): Add constructor.
2384         * tui/tui-data.c (tui_alloc_win_info): Use new.
2385         (tui_free_window): Use delete.
2386
2387 2019-06-22  Tom Tromey  <tom@tromey.com>
2388
2389         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2390         declare.
2391         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2392
2393 2019-06-22  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2396         declare.
2397         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2398
2399 2019-06-22  Tom de Vries  <tdevries@suse.de>
2400
2401         * dwarf2read.c (create_addrmap_from_aranges)
2402         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2403         instead of '%zu'.
2404
2405 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2406
2407         * dwarf2read.h (dwarf2_section_info_def): Remove.
2408         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2409         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2410         std::vector<dwarf2_section_info>.
2411         (struct dwo_file) <~dwo_file>: Remove.
2412         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2413         types field.
2414         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2415         (dwarf2_read_debug_names): Likewise.
2416         (create_debug_types_hash_table): Change parameter type to
2417         array_view, adjust code accordingly.
2418         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2419         (partial_die_info::fixup): Likewise.
2420         (determine_prefix): Likewise.
2421         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2422
2423 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2424
2425         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2426         gdb_bfd_ref_ptr.
2427         <~dwo_file>: Remove call to gdb_bfd_unref.
2428         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2429         gdb_bfd_ref_ptr::get.
2430
2431 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2432
2433         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2434         type to htab_up.
2435         * dwarf2read.c (struct dwo_file): Initialize fields.
2436         <~dwo_file>: New.
2437         (free_dwo_file): Remove, move content to ~dwo_file.
2438         (struct dwo_file_deleter): Remove.
2439         (dwo_file_up>: Remove custom deleter.
2440         (free_dwo_files): Remove.
2441         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2442         dwo_files.
2443         (process_skeletonless_type_units): Call unique_ptr::get.
2444         (allocate_dwo_file_hash_table): Add deleter to created hash
2445         table.  Change return type to htab_up.
2446         (lookup_dwo_file_slot): Don't memset dwo_file, call
2447         unique_ptr::get.
2448         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2449         (create_dwo_unit_in_dwp_v2): Likewise.
2450         (open_and_init_dwo_file): Likewise.
2451         (free_dwo_file_from_slot): Remove.
2452
2453 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2454
2455         * dwarf2read.h (struct dwarf2_section_info) <readin,
2456         is_virtual>: Change type to bool.
2457         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2458         true instead of 1.
2459
2460 2019-06-19  Tom Tromey  <tom@tromey.com>
2461
2462         * tui/tui-data.h (tui_init_content_element): Don't declare.
2463
2464 2019-06-19  Tom Tromey  <tom@tromey.com>
2465
2466         * tui/tui-data.h (tui_init_win_info): Don't declare.
2467
2468 2019-06-19  Tom de Vries  <tdevries@suse.de>
2469
2470         * dwarf2read.h (abstract_to_concrete): Change type to
2471         std::unordered_map<sect_offset, std::vector<sect_offset>,
2472         gdb::hash_enum<sect_offset>>.
2473
2474 2019-06-19  Tom Tromey  <tromey@adacore.com>
2475
2476         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2477         EVAL_AVOID_SIDE_EFFECTS specially.
2478
2479 2019-06-19  Tom Tromey  <tromey@adacore.com>
2480
2481         * source-cache.c (highlighter): New global.
2482         (source_cache::get_source_lines): Create a highlighter on demand.
2483
2484 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2485
2486         * defs.h (deprecated_interactive_hook): Delete declaration.
2487         * interps.c (clear_interpreter_hooks): Remove use of
2488         deprecated_interactive_hook.
2489         * top.c (deprecated_interactive_hook): Delete definition.
2490         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2491
2492 2019-06-18  Tom de Vries  <tdevries@suse.de>
2493
2494         PR gdb/24515
2495         * dwarf2read.h (abstract_to_concrete): Change type from
2496         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2497         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2498         * dwarf2read.c (read_variable): Update.
2499         (dwarf2_fetch_die_loc_sect_off): Update.
2500
2501 2019-06-17  Tom de Vries  <tdevries@suse.de>
2502
2503         PR gdb/24617
2504         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2505         accessing parent[parent_len - 1].
2506
2507 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2508
2509         PR gdb/24364
2510         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2511         call dtrace_process_dof with NULL dof.
2512
2513 2019-06-16  Tom de Vries  <tdevries@suse.de>
2514
2515         PR gdb/24445
2516         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2517
2518 2019-06-16  Tom Tromey  <tom@tromey.com>
2519
2520         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2521         (make_all_visible): Use address of member.
2522
2523 2019-06-16  Tom Tromey  <tom@tromey.com>
2524
2525         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2526         (tui_free_window, free_content, free_content_elements): Remove
2527         unnecessary cast.
2528         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2529         cast.
2530         * tui/tui-regs.c (tui_show_register_group)
2531         (tui_display_registers_from, tui_display_reg_element_at_line):
2532         Remove unnecessary cast.
2533
2534 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2535
2536         * linux-nat.c (normal_mask): Delete.
2537         (_initialize_linux_nat): Don't initialise normal_mask.
2538
2539 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2540
2541         PR gdb/24445
2542         * dwarf-index-write.h (write_psymtabs_to_index): Add
2543         dwz_basename parameter.
2544         * dwarf-index-write.c (write_gdbindex): Move file writing to
2545         write_gdbindex_1.  Change return type void.
2546         (assert_file_size): Move up, remove filename parameter.
2547         (write_gdbindex_1): New function.
2548         (write_debug_names): Change return type to void, call
2549         assert_file_size.
2550         (struct index_wip_file): New struct.
2551         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2552         file logic to index_wip_file.  Write index for dwz file if
2553         needed.
2554         (save_gdb_index_command): Pass basename of dwz file, if present.
2555         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2556         build-id of dwz file, if present.
2557         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2558         (dwarf2_get_dwz_file): Likewise.
2559         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2560         (dwarf2_get_dwz_file): Likewise.
2561
2562 2019-06-16  Tom Tromey  <tom@tromey.com>
2563
2564         * coffread.c (process_coff_symbol): Use xstrdup.
2565         * value.c (create_internalvar): Use xstrdup.
2566
2567 2019-06-16  Tom Tromey  <tom@tromey.com>
2568
2569         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2570         * breakpoint.c (stopin_command, stopat_command)
2571         (until_break_command, decode_location_default): Remove unnecessary
2572         cast.
2573         * utils.c (subset_compare): Remove unnecessary cast.
2574         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2575         cast.
2576         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2577         cast.
2578         * infcmd.c (path_command): Remove unnecessary cast.
2579         * coffread.c (decode_type): Remove unnecessary cast.
2580         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2581         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2582         * tui/tui-stack.c (tui_show_locator_content)
2583         (tui_show_frame_info): Remove unnecessary cast.
2584         * tui/tui-win.c (tui_scroll_forward_command)
2585         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2586         (parse_scrolling_args): Remove unnecessary cast.
2587         * tui/tui-data.c (init_win_info, tui_del_window)
2588         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2589         (free_content_elements): Remove unnecessary cast.
2590         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2591         unnecessary cast.
2592         * tui/tui-source.c (tui_set_source_content)
2593         (tui_vertical_source_scroll): Remove unnecessary cast.
2594         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2595         cast.
2596         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2597         * tui/tui-regs.c (tui_display_registers_from)
2598         (tui_display_register): Remove unnecessary cast.
2599         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2600         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2601         (make_visible): Remove unnecessary cast.
2602         * tui/tui-winsource.c (tui_erase_source_content)
2603         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2604         unnecessary cast.
2605         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2606         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2607         * stabsread.c (read_type, read_array_type, read_range_type):
2608         Remove unnecessary cast.
2609         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2610         (parse_symbol, parse_type, upgrade_type, parse_external)
2611         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2612         unnecessary cast.
2613         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2614
2615 2019-06-16  Tom Tromey  <tom@tromey.com>
2616
2617         * tui/tui-data.c (tui_alloc_generic_win_info)
2618         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2619         checks.
2620
2621 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2622             Andrew Burgess  <andrew.burgess@embecosm.com>
2623
2624         * f-typeprint.c (f_print_type): Don't return early for not
2625         associated or not allocated types.
2626         (f_type_print_varspec_suffix): Add print_rank parameter and print
2627         ranks of array types in case they dangling.
2628         (f_type_print_base): Add print_rank parameter.
2629
2630 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2631
2632         * NEWS: Mention new MI commands.
2633         * break-catch-throw.c (enum exception_event_kind): Move to
2634         breakpoint.h.
2635         (print_mention_exception_catchpoint): Output text as a single
2636         message.
2637         (catch_exception_command_1): Rename to...
2638         (catch_exception_event): ...this, make non-static, update header
2639         command, and change some parameter types.
2640         (catch_catch_command): Update for changes to
2641         catch_exception_command_1.
2642         (catch_throw_command): Likewise.
2643         (catch_rethrow_command): Likewise.
2644         * breakpoint.c (enum exception_event_kind): Delete.
2645         * breakpoint.h (enum exception_event_kind): Moved here from
2646         break-catch-throw.c.
2647         (catch_exception_event): Declare.
2648         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2649         (mi_cmd_catch_throw): New function.
2650         (mi_cmd_catch_rethrow): New function.
2651         (mi_cmd_catch_catch): New function.
2652         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2653         'catch-catch' entries.
2654         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2655         (mi_cmd_catch_rethrow): Declare.
2656         (mi_cmd_catch_catch): Declare.
2657
2658 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2659
2660         * annotate.c (annotate_source_line): Change return type to void,
2661         update implementation to match.
2662         * annotate.h (annotate_source_line): Change return type to void,
2663         update header comment.
2664         * stack.c (print_frame_info): Don't change what frame information
2665         is printed based on whether annotations are on or not.
2666
2667 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2668
2669         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2670         (annotate_source): Make static.
2671         (annotate_source_line): Moved from source.c and renamed from
2672         identify_source_line.  Update the return type.
2673         * annotate.h (annotate_source): Delete declaration.
2674         (annotate_source_line): Declaration moved from source.h, and
2675         renamed from identify_source_line.  Return type updated.
2676         * source.c (identify_source_line): Moved to annotate.c and renamed
2677         to annotate_source_line.
2678         (info_line_command): Remove check of annotation_level.
2679         * source.h (identify_source_line): Move declaration to annotate.h
2680         and rename to annotate_source_line.
2681         * stack.c: Add 'annotate.h' include.
2682         (print_frame_info): Remove check of annotation_level before
2683         calling annotate_source_line.
2684
2685 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2686
2687         * source-cache.c (source_cache::get_plain_source_lines): Use
2688         open_source_file_with_line_charpos instead of just
2689         open_source_file, remove call to find_source_lines.
2690         (source_cache::get_source_lines): Likewise.
2691         * source.c (find_source_lines): Make static.
2692         (get_filename_and_charpos): Renamed into...
2693         (open_source_file_with_line_charpos): ..this along with changes to
2694         return a scoped_fd, and some other minor clean ups.
2695         (identify_source_line): Use open_source_file_with_line_charpos.
2696         (search_command_helper): Use open_source_file_with_line_charpos
2697         instead of just open_source_file, remove call to
2698         find_source_lines.
2699         * source.h (open_source_file_with_line_charpos): Declare new
2700         function.
2701         (find_source_lines): Delete declaration.
2702
2703 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2704
2705         * source.c (get_filename_and_charpos): Remove fullname
2706         parameter.
2707         (identify_source_line): Update call to get_filename_and_charpos.
2708
2709 2019-06-14  Tom Tromey  <tromey@adacore.com>
2710
2711         PR gdb/24502:
2712         * ui-style.h (skip_ansi_escape): Update comment.
2713         * ui-file.h (class no_terminal_escape_file): New class.
2714         * ui-file.c (no_terminal_escape_file::write)
2715         (no_terminal_escape_file::puts): New methods.
2716         * cli/cli-logging.c (handle_redirections): Use
2717         no_terminal_escape_file.
2718
2719 2019-06-14  Tom Tromey  <tromey@adacore.com>
2720
2721         * NEWS: Move convenience variable news above Python news.
2722
2723 2019-06-14  Tom Tromey  <tom@tromey.com>
2724
2725         * gnulib: Move directory to top-level.
2726         * configure.ac: Don't configure gnulib.
2727         * configure: Rebuild.
2728         * common/common-defs.h: Use new path to gnulib.
2729         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2730         (GNULIB_H): Remove.
2731         (INCGNU): Look in new gnulib location.
2732         (HFILES_NO_SRCDIR): Remove gnulib files.
2733         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2734         (generated_files): Remove GNULIB_H.
2735         ($(LIBGNU), all-lib): Remove targets.
2736         (distclean): Don't mention GNULIB_BUILDDIR.
2737         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2738
2739 2019-06-14  Tom Tromey  <tromey@adacore.com>
2740
2741         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2742         Warn if symbol file does not provide any symbols.
2743
2744 2019-06-14  Tom Tromey  <tromey@adacore.com>
2745
2746         * source.c (find_and_open_source): Respect basenames_may_differ.
2747
2748 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2749
2750         * annotate.c (annotate_breakpoints_invalid): Make use of
2751         scoped_restore_terminal_state.
2752         (annotate_frames_invalid): Likewise.
2753
2754 2019-06-14  Tom Tromey  <tromey@adacore.com>
2755
2756         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2757         allow assignment to an internalvar.
2758
2759 2019-06-14  Tom Tromey  <tromey@adacore.com>
2760
2761         * ada-lex.l: Allow "_" in attribute names.
2762
2763 2019-06-14  Tom Tromey  <tromey@adacore.com>
2764
2765         PR gdb/24653:
2766         * regcache.c (registers_changed): Don't call alloca.
2767         * top.c (execute_command): Don't call alloca.
2768
2769 2019-06-13  Pedro Alves  <palves@redhat.com>
2770
2771         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2772         'expression'.  When parsing an expression, error out if there's
2773         junk after "unlimited".
2774         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2775         (do_set_command): Adjust calls to is_unlimited_literal.
2776
2777 2019-06-13  Pedro Alves  <palves@redhat.com>
2778
2779         * compile/compile.c (make_compile_options_def_group): Add braces
2780         around array_view initializer.
2781         * thread.c (make_thread_apply_all_options_def_group)
2782         (make_thread_apply_all_options_def_group): Likewise.
2783
2784 2019-06-13  Pedro Alves  <palves@redhat.com>
2785
2786         * NEWS (New commands): Mention "maint test-options
2787         require-delimiter", "maint test-options unknown-is-error", "maint
2788         test-options unknown-is-operand" and "maint show
2789         test-options-completion-result".
2790         (New command options, command completion): New section.
2791         (Completion improvements): New section.
2792         Mention that you can abbreviate "unlimited".
2793
2794 2019-06-13  Pedro Alves  <palves@redhat.com>
2795
2796         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2797         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2798         * unittests/cli-utils-selftests.c (test_parse_flags)
2799         (test_parse_flags_qcs): Delete.
2800         (test_cli_utils): Don't call deleted functions.
2801
2802 2019-06-13  Pedro Alves  <palves@redhat.com>
2803
2804         * thread.c: Include "cli/cli-option.h".
2805         (tp_array_compar_ascending): Global.
2806         (tp_array_compar): Delete function.
2807         (tp_array_compar_ascending, tp_array_compar_descending): New
2808         functions.
2809         (ascending_option_def, qcs_flag_option_def)
2810         (thr_qcs_flags_option_defs)
2811         (make_thread_apply_all_options_def_group)
2812         (make_thread_apply_options_def_group): New.
2813         (thread_apply_all_command): Use gdb::option::process_options.
2814         (thread_apply_command_completer)
2815         (thread_apply_all_command_completer): New.
2816         (thread_apply_command): Use gdb::option::process_options.
2817         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2818         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2819         to generate help text of "thread apply".  Adjust "taas"'s help.
2820         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2821         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2822
2823 2019-06-13  Pedro Alves  <palves@redhat.com>
2824
2825         * thread.c (thread_apply_command): Check for invalid TID with
2826         isdigit instead of !isalpha.
2827
2828 2019-06-13  Pedro Alves  <palves@redhat.com>
2829
2830         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2831         (validate_flags_qcs): New.
2832         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2833         (validate_flags_qcs): Declare.
2834         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2835         (make_frame_apply_options_def_group): New.
2836         (frame_apply_command_count): Process options with
2837         gdb::option::process_options.
2838         (frame_apply_completer): New.
2839         (frame_apply_level_completer, frame_apply_all_completer)
2840         (frame_apply_completer): New.
2841         (_initialize_stack): Update help of "frame apply", "frame apply
2842         level", "frame apply all" and "faas" to mention supported options
2843         and install command completers.
2844         * stack.h (frame_apply_all_completer): Declare.
2845         * thread.c: Include "stack.h".
2846         (tfaas_command): Add "--".
2847         (_initialize_thread): Update help "tfaas" to mention supported
2848         options and install command completer.
2849
2850 2019-06-13  Pedro Alves  <palves@redhat.com>
2851
2852         * completer.c (complete_nested_command_line): New.
2853         (gdb_completion_word_break_characters_throw): Add assertion.
2854         * completer.h (complete_nested_command_line): Declare.
2855
2856 2019-06-13  Pedro Alves  <palves@redhat.com>
2857
2858         * stack.c (parse_backtrace_qualifiers): New.
2859         (backtrace_command): Use it.
2860         (backtrace_command_completer): Complete on qualifiers.
2861
2862 2019-06-13  Pedro Alves  <palves@redhat.com>
2863
2864         * frame.c: Include "cli/cli-option.h.
2865         (user_set_backtrace_options): New.
2866         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2867         Delete.
2868         (get_prev_frame): Adjust.
2869         (boolean_option_def, uinteger_option_def)
2870         (set_backtrace_option_defs): New.
2871         (_initialize_frame): Adjust and use
2872         gdb::option::add_setshow_cmds_for_options to install "set
2873         backtrace past-main" and "set backtrace past-entry".
2874         * frame.h: Include "cli/cli-option.h".
2875         (struct frame_print_options): Forward declare.
2876         (print_frame_arguments_all, print_frame_arguments_scalars)
2877         (print_frame_arguments_none): Declare.
2878         (print_entry_values): Delete declaration.
2879         (struct frame_print_options, user_frame_print_options): New.
2880         (struct set_backtrace_options): New.
2881         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2882         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2883         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2884         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2885         (list_args_or_locals): Add frame_print_options parameter.
2886         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2887         * python/py-framefilter.c (enumerate_args): Pass down
2888         USER_FRAME_PRINT_OPTIONS.
2889         * stack.c: Include "cli/cli-option.h".
2890         (print_frame_arguments_all, print_frame_arguments_scalars)
2891         (print_frame_arguments_none): Declare.
2892         (print_raw_frame_arguments, print_entry_values): Delete.
2893         (user_frame_print_options): New.
2894         (boolean_option_def, enum_option_def, frame_print_option_defs):
2895         New.
2896         (struct backtrace_cmd_options): New.
2897         (bt_flag_option_def): New.
2898         (backtrace_command_option_defs): New.
2899         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2900         (print_frame_arg, read_frame_arg, print_frame_args)
2901         (print_frame_info, print_frame): Add frame_print_options parameter
2902         and use it.
2903         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2904         (backtrace_command_1): Add frame_print_options and
2905         backtrace_cmd_options parameters and use them.
2906         (make_backtrace_options_def_group): New.
2907         (backtrace_command): Process command options with
2908         gdb::option::process_options.
2909         (backtrace_command_completer): New.
2910         (_initialize_stack): Extend "backtrace"'s help to mention
2911         supported options.  Install completer for "backtrace".
2912         Install some settings commands with add_setshow_cmds_for_options.
2913
2914 2019-06-13  Pedro Alves  <palves@redhat.com>
2915
2916         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2917         and that "set/show print raw frame-arguments" are now deprecated.
2918
2919         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2920         command.
2921         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2922         * stack.c (_initialize_stack): Install "set/show print
2923         raw-frame-arguments", and deprecate "set/show print raw
2924         frame-arguments".
2925         * valprint.c (_initialize_valprint): Deprecate "set/show print
2926         raw".
2927
2928 2019-06-13  Pedro Alves  <palves@redhat.com>
2929
2930         * compile/compile.c (struct compile_options): New.
2931         (compile_flag_option_def, compile_command_option_defs)
2932         (make_compile_options_def_group): New.
2933         (compile_file_command): Handle options with
2934         gdb::option::process_options.
2935         (compile_file_command_completer): New function.
2936         (compile_code_command): Handle options with
2937         gdb::option::process_options.
2938         (compile_code_command_completer): New function.
2939         (_initialize_compiler): Install completers for "compile code" and
2940         "compile file".  Mention available options in "compile code" and
2941         "compile code"'s help.
2942         * completer.c (advance_to_completion_word): New, factored out from
2943         ...
2944         (advance_to_expression_complete_word_point): ... this.
2945         (advance_to_filename_complete_word_point): New.
2946         * completer.h (advance_to_filename_complete_word_point): New
2947         declaration.
2948
2949 2019-06-13  Pedro Alves  <palves@redhat.com>
2950
2951         * compile/compile.c: Include "cli/cli-option.h".
2952         (compile_print_value): Scope data pointer is now a
2953         value_print_options pointer; adjust.
2954         (compile_print_command): Process options.  Scope data pointer is
2955         now a value_print_options pointer; adjust.
2956         (_initialize_compile): Update "compile print"'s help to include
2957         supported options.  Install a completer for "compile print".
2958         * cp-valprint.c (show_vtblprint, show_objectprint)
2959         (show_static_field_print): Delete.
2960         (_initialize_cp_valprint): Don't install "set print
2961         static-members", "set print vtbl", "set print object" here.
2962         * printcmd.c: Include "cli/cli-option.h" and
2963         "common/gdb_optional.h".
2964         (print_command_parse_format): Rework to fill in a
2965         value_print_options instead of a format_data.
2966         (print_value): Change parameter type from format_data pointer to
2967         value_print_options reference.  Adjust.
2968         (print_command_1): Process options.  Adjust to pass down a
2969         value_print_options.
2970         (print_command_completer): New.
2971         (_initialize_printcmd): Install print_command_completer as
2972         handle_brkchars completer for the "print" command.  Update
2973         "print"'s help to include supported options.
2974         * valprint.c: Include "cli/cli-option.h".
2975         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2976         here from cp-valprint.c.
2977         (boolean_option_def, uinteger_option_def)
2978         (value_print_option_defs, make_value_print_options_def_group):
2979         New.  Use gdb::option::add_setshow_cmds_for_options to install
2980         "set print elements", "set print null-stop", "set print repeats",
2981         "set print pretty", "set print union", "set print array", "set
2982         print address", "set print symbol", "set print array-indexes".
2983         * valprint.h: Include <string> and "cli/cli-option.h".
2984         (make_value_print_options_def_group): Declare.
2985         (print_value): Change parameter type from format_data pointer to
2986         value_print_options reference.
2987         (print_command_completer): Declare.
2988
2989 2019-06-13  Pedro Alves  <palves@redhat.com>
2990
2991         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2992         (COMMON_SFILES): Add maint-test-settings.c.
2993         * cli/cli-decode.c (boolean_enums): New global, factored out from
2994         ...
2995         (add_setshow_boolean_cmd): ... here.
2996         * cli/cli-decode.h (boolean_enums): Declare.
2997         * cli/cli-option.c: New file.
2998         * cli/cli-option.h: New file.
2999         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3000         factored out from ...
3001         (parse_cli_boolean_value(const char *)): ... this.
3002         (is_unlimited_literal): Change parameter type to pointer to
3003         pointer.  Adjust and advance ARG pointer.
3004         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3005         (parse_cli_var_enum): New, factored out from ...
3006         (do_set_command): ... this.  Adjust.
3007         * cli/cli-setshow.h (parse_cli_boolean_value)
3008         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3009         (parse_cli_var_enum): Declare.
3010         * cli/cli-utils.c: Include "cli/cli-option.h".
3011         (get_ulongest): New.
3012         * cli/cli-utils.h (get_ulongest): Declare.
3013         (check_for_argument): New overloads.
3014         * maint-test-options.c: New file.
3015
3016 2019-06-13  Pedro Alves  <palves@redhat.com>
3017
3018         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3019         parse a range if "-" is at the end of the string.
3020
3021 2019-06-13  Pedro Alves  <palves@redhat.com>
3022
3023         * cli/cli-setshow.c (parse_auto_binary_operation)
3024         (parse_cli_boolean_value): Don't allow "o".
3025
3026 2019-06-13  Pedro Alves  <palves@redhat.com>
3027
3028         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3029         * NEWS: Mention maint test-settings KIND.
3030         * maint-test-settings.c: New file.
3031
3032 2019-06-13  Pedro Alves  <palves@redhat.com>
3033
3034         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3035         completer.
3036         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3037         "set" completers.
3038
3039 2019-06-13  Pedro Alves  <palves@redhat.com>
3040
3041         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3042         after item.
3043
3044 2019-06-13  Pedro Alves  <palves@redhat.com>
3045
3046         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3047
3048 2019-06-13  Pedro Alves <palves@redhat.com>
3049
3050         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3051         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3052         call.
3053         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3054         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3055         calls.
3056         (check_for_argument): Skip spaces after argument.
3057
3058 2019-06-13  Pedro Alves  <palves@redhat.com>
3059
3060         * thread.c (thread_apply_command): Adjust TID parsing.
3061         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3062         detected before end of string.
3063         (tid_is_in_list): Error out if LIST is invalid.
3064
3065 2019-06-13  Pedro Alves  <palves@redhat.com>
3066
3067         * completer.c (complete_line_internal_1): Rewind completion word
3068         point.
3069         (completion_tracker::advance_custom_word_point_by): Change
3070         parameter type to int.
3071         * completer.h (completion_tracker::advance_custom_word_point_by):
3072         Likewise.
3073
3074 2019-06-13  Pedro Alves  <palves@redhat.com>
3075
3076         * completer.c (advance_to_completion_word): Handle delimiters.
3077
3078 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3079
3080         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3081
3082 2019-06-11  Tom Tromey  <tom@tromey.com>
3083
3084         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3085         (xmalloc_failed): Move to alloc.c.
3086         * alloc.c: New file.
3087         * Makefile.in (COMMON_SFILES): Add alloc.c.
3088
3089 2019-06-11  Tom Tromey  <tom@tromey.com>
3090
3091         * nat/linux-waitpid.c: Don't include server.h.
3092         (linux_debug): Remove.
3093         (my_waitpid): Update.
3094
3095 2019-06-11  Tom Tromey  <tromey@adacore.com>
3096
3097         * infcall.c (_initialize_infcall): Remove trailing newline from
3098         help.
3099         * user-regs.c (_initialize_user_regs): Remove trailing newline
3100         from help.
3101         * typeprint.c (_initialize_typeprint): Remove trailing newline
3102         from help.
3103         * reverse.c (_initialize_reverse): Remove trailing newlines from
3104         help.
3105         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3106         from help.
3107         * language.c (add_set_language_command): Remove trailing newline
3108         from help.
3109         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3110         help.
3111         * disasm.c (_initialize_disasm): Remove trailing newline from
3112         help.
3113         * top.c (init_main): Remove trailing newline from help.
3114         * interps.c (_initialize_interpreter): Remove trailing newline
3115         from help.
3116         * btrace.c (_initialize_btrace): Remove trailing newlines from
3117         help.
3118         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3119         from help.
3120         * python/python.c (_initialize_python): Remove trailing newline
3121         from help.
3122         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3123         help.
3124         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3125         from help.  Reformat some text.
3126         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3127         from help.
3128         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3129         newline from help.
3130
3131 2019-06-11  Tom Tromey  <tromey@adacore.com>
3132
3133         * darwin-nat.c (darwin_decode_exception_message)
3134         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3135
3136 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3137
3138         * valops.c (value_slice): Check for not allocated or not
3139         associated values.
3140
3141 2019-06-10  Tom de Vries  <tdevries@suse.de>
3142
3143         PR gdb/24618
3144         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3145         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3146         invalid.
3147
3148 2019-06-10  Tom de Vries  <tdevries@suse.de>
3149
3150         PR gdb/24611
3151         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3152         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3153
3154 2019-06-10  Tom de Vries  <tdevries@suse.de>
3155
3156         PR symtab/24545
3157         * symtab.c (struct demangled_name_entry): Add language field.
3158         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3159         static minimal symbol".  Set and use language field.
3160
3161 2019-06-10  Tom Tromey  <tromey@adacore.com>
3162
3163         * ada-lang.c (_initialize_ada_language): Update help text.
3164
3165 2019-06-10  Tom Tromey  <tromey@adacore.com>
3166
3167         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3168         with a newline.
3169         * guile/guile.c (handle_boot_error): Don't end warning with a
3170         newline.
3171         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3172         warning with a newline.
3173         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3174         newline.
3175         (s12z_frame_cache): Likewise.
3176         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3177         a newline.
3178         * solib-svr4.c (disable_probes_interface): Don't end warning with
3179         a newline.
3180         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3181         newline.
3182         * python/python.c (do_finish_initialization): Don't end warning
3183         with a newline.
3184
3185 2019-06-10  Tom Tromey  <tom@tromey.com>
3186
3187         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3188         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3189         gdbpy_enter.
3190
3191 2019-06-10  Tom Tromey  <tromey@adacore.com>
3192
3193         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3194         data.
3195         (elf_new_init): Don't call stabsread_new_init.
3196         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3197         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3198         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3199
3200 2019-06-10  Tom de Vries  <tdevries@suse.de>
3201
3202         PR symtab/16264
3203         PR symtab/24517
3204         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3205
3206 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3207
3208         * source.c (find_and_open_source): Also rewrite relative file
3209         names.
3210
3211 2019-04-26  Amos Bird  <amosbird@gmail.com>
3212
3213         * annotate.c (annotate_thread_exited): Add "thread-exited"
3214         annotation.
3215
3216 2019-06-06  Tom Tromey  <tromey@adacore.com>
3217
3218         * maint.h (class scoped_command_stats): Use
3219         DISABLE_COPY_AND_ASSIGN.
3220         <print_time>: New method.
3221         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3222         print_time.
3223         (scoped_command_stats::print_time): New method.
3224
3225 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3226
3227         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3228         instructions of lengths 6 or 8 bytes.
3229
3230 2019-06-04  Pedro Alves  <palves@redhat.com>
3231
3232         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3233
3234         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3235         * breakpoint.c (condition_completer): Likewise.
3236         * cli/cli-dump.c (scan_expression): Likewise.
3237         * common/filestuff.c (mkdir_recursive): Likewise.
3238         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3239         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3240         (gdb_abspath): Likewise.
3241         * compile/compile-cplus-types.c
3242         (compile_cplus_instance::decl_name): Likewise.
3243         * completer.c (complete_explicit_location):
3244         (signal_completer, reg_or_group_completer_1): Likewise.
3245         * cp-support.c (cp_remove_params_if_any): Likewise.
3246         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3247         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3248         * infcmd.c (strip_bg_char): Likewise.
3249         * linespec.c (copy_token_string): Likewise.
3250         * mi/mi-main.c (output_cores): Likewise.
3251         * psymtab.c (psymtab_search_name):
3252         * symfile.c (test_set_ext_lang_command): Likewise.
3253         * target.c (target_fileio_read_stralloc): Likewise.
3254         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3255         * value.c (complete_internalvar): Likewise.
3256
3257 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3258
3259         Add objfile property to gdb.Type.
3260         * NEWS: Mention Python API addition.
3261         * python/py-type.c (typy_get_objfile): New method.
3262
3263 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3264
3265         * NEWS: Mention the new set|show style [title|highlight].
3266         Mention changes to "show style", "help" and "apropos".
3267
3268 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3269
3270         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3271         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3272         instead of print_help_for_command.
3273         (print_doc_of_command): New function.
3274         (help_list): Add 'apropos -v word' suggestion.
3275         (print_help_for_command): Style the command name using title style.
3276         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3277         (_initialize_cli_cmds): Describe -v in apropos_command help.
3278
3279 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3280
3281         * cli/cli-style.h (cli_style_option): Add name in constructor,
3282         add m_name class member, add constructor with intensity,
3283         add name class function.
3284         (cli_style_option::add_setshow_commands): Remove name argument.
3285         (highlight_style, title_style): New styles.
3286         * cli/cli-style.c (do_show): New function that shows a style
3287         characteristic styling the style name with itself.
3288         (set_style_name): New function.
3289         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3290         Update all callers according to the changes in cli/cli-style.h.
3291         * utils.h (fputs_highlighted): New function.
3292         * utils.c (fputs_highlighted): Likewise.
3293
3294 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3295
3296         * NEWS: Mention new pipe command and new convenience variables.
3297
3298 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3299
3300         * cli/cli-cmds.c (pipe_command): New function.
3301         (_initialize_cli_cmds): Call add_com for pipe_command.
3302         Define | as an alias for pipe.
3303         (exit_status_set_internal_vars): New function.
3304         (shell_escape): Call exit_status_set_internal_vars.
3305         cli/cli-decode.c (find_command_name_length): Recognize | as
3306         a single character command.
3307
3308 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3309
3310         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3311         top.c (execute_command_to_ui_file): New function, mostly a copy
3312         of execute_command_to_string.
3313         (execute_command_to_string): Implement by calling
3314         execute_command_to_ui_file.
3315
3316 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3317
3318         * top.h (saved_command_line): Remove declaration.
3319         * top.c (previous_saved_command_line, previous_repeat_arguments):
3320         New variables.
3321         (saved_command_line): Make static, define together with other
3322         'repeat variables'.
3323         (dont_repeat): Clear repeat_arguments.
3324         (repeat_previous, get_saved_command_line, save_command_line):
3325         New functions.
3326         (gdb_init): Initialize saved_command_line
3327         and previous_saved_command_line.
3328         * main.c (captured_main_1): Remove saved_command_line initialization.
3329         * event-top.c (handle_line_of_input): Update to use
3330         the new 'repeat' related functions instead of direct access to
3331         saved_command_line.
3332         * command.h (repeat_previous, get_saved_command_line,
3333         save_command_line): New declarations.
3334         (dont_repeat): Add comment.
3335
3336 2019-05-30  Tom Tromey  <tromey@adacore.com>
3337
3338         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3339         Fix comment.
3340         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3341
3342 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3343
3344         PR cli/24587
3345         * completer.c (complete): Initialize variable word.
3346
3347 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3348
3349         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3350         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3351         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3352         'body' is NULL to the outter 'if', protecting the '!is_define'
3353         situation as well.
3354
3355 2019-05-29  Tom Tromey  <tromey@adacore.com>
3356
3357         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3358         (dwarf_unknown): New function.
3359         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3360         (dwarf_type_encoding_name): Use dwarf_unknown.
3361
3362 2019-05-29  Tom Tromey  <tromey@adacore.com>
3363
3364         PR c++/20020:
3365         * cp-valprint.c (cp_print_value_fields): Call
3366         cp_print_static_field inside "try".
3367
3368 2019-05-29  Tom Tromey  <tromey@adacore.com>
3369
3370         * inflow.c (struct terminal_info): Add default operator=.
3371         * configure: Rebuild.
3372         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3373         -Wdeprecated-copy-dtor, -Wredundant-move.
3374
3375 2019-05-29  Tom Tromey  <tromey@adacore.com>
3376
3377         * NEWS: Add entry.
3378         * infcmd.c (print_return_value_1): Handle finish_print
3379         option.
3380         (show_print_finish): New function.
3381         (_initialize_infcmd): Add "set/show print finish" commands.
3382         * valprint.c (user_print_options): Initialize new member.
3383         * valprint.h (struct value_print_options) <finish_print>: New
3384         member.
3385
3386 2019-05-28  Tom Tromey  <tromey@adacore.com>
3387
3388         * ada-lang.c (ada_remove_Xbn_suffix)
3389         (find_old_style_renaming_symbol)
3390         (parse_old_style_renaming): Remove.
3391         (ada_find_renaming_symbol): Don't call
3392         find_old_style_renaming_symbol.
3393         (ada_is_renaming_symbol): Rename from
3394         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3395         bool.  Now static.
3396         (ada_read_var_value): Update and simplify.
3397         * ada-exp.y (write_var_or_type): Remove old code.
3398
3399 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3400
3401         * event-top.c: Remove include comment.
3402         * inflow.c (class scoped_ignore_sigttou): Move from here...
3403         * inflow.h (class scoped_ignore_sigttou): ...to here.
3404         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3405         * top.c:  Remove include comment.
3406
3407 2019-05-27  Tom Tromey  <tom@tromey.com>
3408
3409         * NEWS: Fix typo.
3410
3411 2019-05-22  Tom Tromey  <tromey@adacore.com>
3412
3413         * target.c (target_follow_exec): Constify parameter.
3414         * target-delegates.c: Rebuild.
3415         * remote.c (remote_target::follow_exec): Constify parameter.
3416         * infrun.c (follow_exec): Constify parameter.
3417         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3418         (target_follow_exec): Likewise.
3419
3420 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3421
3422         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3423         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3424
3425 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3426
3427         * NEWS: Add debugredirect and testsuite sections.
3428
3429 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3430
3431         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3432         target descriptions using exclusively floating point register name
3433         aliases.
3434
3435 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3436
3437         PR gdb/18644:
3438         * f-lang.c (build_fortran_types): Handle the case where
3439         gdbarch_floatformat_for_type returns a nullptr.
3440
3441 2019-05-21  Tom de Vries  <tdevries@suse.de>
3442
3443         PR cli/24587
3444         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3445
3446 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3447
3448         PR gdb/18644:
3449         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3450         16-byte floats.
3451         * i386-tdep.c (i386_floatformat_for_type): Use
3452         floatformats_ia64_quad for the 16-byte floating point component
3453         within a fortran 32-byte complex number.
3454
3455 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3456
3457         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3458         delete default constructor.
3459         (find_partial_die): Update to return const struct.
3460         (partial_die_parent_scope): Move variable declaration into scope
3461         of its use and change its type to auto.
3462         (guess_partial_die_structure_name): Likewise.
3463         (partial_die_info::fixup): Likewise.
3464
3465 2019-05-17  Tom Tromey  <tromey@adacore.com>
3466
3467         * source.c (find_and_open_source): Remove cast.
3468
3469 2019-05-17  Tom Tromey  <tromey@adacore.com>
3470
3471         * annotate.c (annotate_source): Make "filename" const.
3472         * annotate.h (annotate_source): Use const.
3473
3474 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3475
3476         * disasm.c (set_disassembler_options): Send errors to stderr.
3477
3478 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3479
3480         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3481         (cli_interp_base::set_logging): Check debug_redirect.
3482         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3483         * cli/cli-logging.c (debug_redirect): Add static variable.
3484         (pop_output_files): Add default param.
3485         (handle_redirections): Print debug setting.
3486         (show_logging_command): Likewise.
3487         (_initialize_cli_logging): Add debugredirect command.
3488         * interps.c (current_interp_set_logging): Add debug_redirect
3489         parameter.
3490         * interps.h (set_logging): Add debug_redirect parameter.
3491         (current_interp_set_logging): Likewise.
3492         * mi/mi-common.h: Likewise.
3493         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3494
3495 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3496             Tom Tromey  <tromey@adacore.com>
3497
3498         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3499         directly.
3500         * cli/cli-interp.h (make_logging_output): Remove declaration.
3501         * cli/cli-logging.c (make_logging_output): Remove function.
3502         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3503         directly.
3504         * ui-file.c (tee_file::tee_file): Remove bools.
3505         (tee_file::~tee_file): Remove deletes.
3506         * ui-file.h (tee_file): Remove bools.
3507
3508 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3509
3510         * mi/mi-cmds.h (mi_cmd_complete): New function.
3511         * mi/mi-main.c (mi_cmd_complete): Likewise.
3512         * mi/mi-cmds.c: Define new MI command -complete.
3513         * NEWS: Mention new -complete command.
3514
3515 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3516
3517         * completer.h (complete): New function.
3518         * completer.c (complete): Likewise.
3519         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3520         function defined in completer.h.
3521
3522 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3523
3524         * MAINTAINERS (Write After Approval): Add myself.
3525
3526 2019-05-17  Tom de Vries  <tdevries@suse.de>
3527
3528         PR gdb/24094
3529         * dwarf2read.c (struct cu_partial_die_info): New struct.
3530         (find_partial_die): Return cu_partial_die_info.
3531         (partial_die_parent_scope, guess_partial_die_structure_name)
3532         (partial_die_info::fixup): Handle new return type of find_partial_die.
3533
3534 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3535
3536         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3537         "std::string", simplifying the algorithm.
3538
3539 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3540
3541         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3542         (stap_static_probe_ops::get_probes): Likewise.
3543
3544 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3545
3546         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3547         '-')" and "else if".
3548         (stap_parse_single_operand): Join checks for
3549         "gdbarch_stap_parse_special_token_p" and
3550         "gdbarch_stap_parse_special_token" in the same "if" statement.
3551         Invert check when verifying for operation on register
3552         displacement.
3553
3554 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3555
3556         * stap-probe.c (stap_get_opcode): Update comment.
3557         (stap_get_expected_argument_type): Likewise.
3558         (handle_stap_probe): Likewise.
3559
3560 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3561
3562         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3563         return type to 'bool'.  Adjust comment.  Use 'bool' when
3564         appropriate.
3565         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3566         * stap-probe.c (stap_parse_argument_1): Likewise.
3567         (stap_is_operator): Likewise.
3568         (stap_is_generic_prefix): Likewise.
3569         (stap_is_register_prefix): Likewise.
3570         (stap_is_register_indirection_prefix): Likewise.
3571         (stap_is_integer_prefix): Likewise.
3572         (stap_generic_check_suffix): Likewise.
3573         (stap_check_integer_suffix): Likewise.
3574         (stap_check_register_suffix): Likewise.
3575         (stap_check_register_indirection_suffix): Likewise.
3576         (stap_parse_register_operand): Likewise.
3577         (stap_parse_single_operand): Likewise.
3578         (stap_parse_argument_1): Likewise.
3579         (stap_probe::get_argument_count): Likewise.
3580         (stap_is_operator): Likewise.
3581
3582 2019-05-16  Tom Tromey  <tromey@adacore.com>
3583
3584         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3585         keyword to foreach.
3586
3587 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3588
3589         * linux-thread-db.c (try_thread_db_load_1): Change return type
3590         to bool.
3591         (try_thread_db_load): Likewise.
3592         (try_thread_db_load_from_pdir_1): Likewise.
3593         (try_thread_db_load_from_pdir): Likewise.
3594         (try_thread_db_load_from_sdir): Likewise.
3595         (try_thread_db_load_from_dir): Likewise.
3596         (thread_db_load_search): Likewise.
3597         (has_libpthread): Likewise.
3598         (thread_db_load): Likewise.
3599
3600 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3601
3602         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3603         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3604         NULL, and complain/return if that's the case.
3605
3606 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3607
3608         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3609         (advance, posn, abstract_read_memory): New functions.
3610         [struct mem_read_abstraction]: New struct.
3611         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3612
3613 2019-05-14  Tom Tromey  <tromey@adacore.com>
3614
3615         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3616         value is not lval_memory.
3617
3618 2019-05-14  Tom Tromey  <tromey@adacore.com>
3619
3620         * solib.c (info_sharedlibrary_command): Style the file name.
3621
3622 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3623
3624         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3625         (aarch64_vnv_type): Likewise.
3626         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3627         * common/tdesc.c: Likewise.
3628         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3629         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3630         * features/aarch64-fpu.xml: Add ieee half view.
3631         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3632         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3633         * gdbtypes.h (struct builtin_type): Likewise.
3634         (struct objfile_type): Likewise.
3635
3636 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3637
3638         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3639         typo.
3640         * location.h (string_to_event_location): Likewise.
3641
3642 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3643
3644         GDB 8.3 released.
3645
3646 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3647
3648         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3649         New variable declaration.
3650         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3651         New variable.
3652         (print_one_breakpoint): Use ui_out::test_flags and new global
3653         variable to compute use_fixed_output.
3654         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3655         Remove.
3656         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3657         (mi_multi_location_breakpoint_output_fixed): Remove.
3658         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3659         new variable.
3660         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3661         fix_multi_location_breakpoint_output flag if version >= 3.
3662         * ui-out.h (enum ui_out_flag)
3663         <fix_multi_location_breakpoint_output>: New enumerator.
3664
3665 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3666
3667         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3668
3669 2019-05-10  Tom Tromey  <tromey@adacore.com>
3670
3671         * ada-lang.c (catch_ada_completer): New function.
3672         (_initialize_ada_language): Use it.
3673
3674 2019-05-10  Tom Tromey  <tromey@adacore.com>
3675
3676         * thread.c (print_thread_info): Make "requested_threads" const.
3677         * gdbthread.h (print_thread_info): Make "requested_threads"
3678         const.
3679         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3680         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3681
3682 2019-05-08  Tom Tromey  <tom@tromey.com>
3683
3684         * gdbtypes.c (objfile_type_data): Change type.
3685         (objfile_type, _initialize_gdbtypes): Update.
3686
3687 2019-05-08  Tom Tromey  <tom@tromey.com>
3688
3689         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3690         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3691         (_initialize_dwarf2_frame): Update.
3692
3693 2019-05-08  Tom Tromey  <tom@tromey.com>
3694
3695         * objc-lang.c (objc_objfile_data): Change type.
3696         (find_methods): Update.
3697         (_initialize_objc_lang): Remove.
3698
3699 2019-05-08  Tom Tromey  <tom@tromey.com>
3700
3701         * stabsread.c (rs6000_builtin_type_data): Change type.
3702         (rs6000_builtin_type, _initialize_stabsread): Update.
3703
3704 2019-05-08  Tom Tromey  <tom@tromey.com>
3705
3706         * mips-tdep.c (mips_pdr_data): Remove.
3707         (_initialize_mips_tdep): Update.
3708
3709 2019-05-08  Tom Tromey  <tom@tromey.com>
3710
3711         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3712         (hppa_init_objfile_priv_data, read_unwind_info)
3713         (find_unwind_entry, _initialize_hppa_tdep): Update.
3714
3715 2019-05-08  Tom Tromey  <tom@tromey.com>
3716
3717         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3718         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3719         on obstack.
3720         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3721
3722 2019-05-08  Tom Tromey  <tom@tromey.com>
3723
3724         * mdebugread.c (basic_type_data): Change type.
3725         (basic_type, _initialize_mdebugread): Update.
3726
3727 2019-05-08  Tom Tromey  <tom@tromey.com>
3728
3729         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3730
3731 2019-05-08  Tom Tromey  <tom@tromey.com>
3732
3733         * nto-tdep.c (nto_inferior_data_reg): Change type.
3734         (nto_inferior_data): Update.
3735         (nto_inferior_data_cleanup, nto_new_inferior_data)
3736         (_initialize_nto_tdep): Remove.
3737         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3738
3739 2019-05-08  Tom Tromey  <tom@tromey.com>
3740
3741         * ada-lang.c (struct ada_inferior_data): Add initializers.
3742         (ada_inferior_data): Change type.
3743         (ada_inferior_data_cleanup): Remove.
3744         (get_ada_inferior_data, ada_inferior_exit)
3745         (struct ada_pspace_data): Add initializers, destructor.
3746         (ada_pspace_data_handle): Change type.
3747         (get_ada_pspace_data): Update.
3748         (ada_pspace_data_cleanup): Remove.
3749
3750 2019-05-08  Tom Tromey  <tom@tromey.com>
3751
3752         * coffread.c (struct coff_symfile_info): Add initializers.
3753         (coff_objfile_data_key): Move lower.  Change type.
3754         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3755         Update.
3756         (coff_free_info): Remove.
3757
3758 2019-05-08  Tom Tromey  <tom@tromey.com>
3759
3760         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3761         (fbsd_pspace_data_handle): Move lower.  Change type.
3762         (get_fbsd_pspace_data): Update.
3763         (fbsd_pspace_data_cleanup): Remove.
3764         (_initialize_fbsd_tdep): Update.
3765
3766 2019-05-08  Tom Tromey  <tom@tromey.com>
3767
3768         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3769         (get_ada_tasks_pspace_data): Update.
3770         (ada_tasks_pspace_data_cleanup): Remove.
3771         (_initialize_tasks): Update.
3772         (ada_tasks_inferior_data_handle): Change type.
3773         (get_ada_tasks_inferior_data): Update.
3774         (ada_tasks_inferior_data_cleanup): Remove.
3775         (struct ada_tasks_pspace_data): Add initializers.
3776
3777 2019-05-08  Tom Tromey  <tom@tromey.com>
3778
3779         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3780         * symfile-debug.c (debug_sym_get_probes): Change type.
3781         * stap-probe.c (handle_stap_probe):
3782         (stap_static_probe_ops::get_probes): Change type.
3783         * probe.h (class static_probe_ops) <get_probes>: Change type.
3784         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3785         (parse_probes_in_pspace): Update.
3786         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3787         Update.
3788         (any_static_probe_ops::get_probes): Change type.
3789         * elfread.c (elfread_data): New typedef.
3790         (probe_key): Change type.
3791         (elf_get_probes): Likewise.  Update.
3792         (probe_key_free): Remove.
3793         (_initialize_elfread): Update.
3794         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3795         Change type.
3796         (dtrace_process_dof_probe, dtrace_process_dof)
3797         (dtrace_static_probe_ops::get_probe): Change type.
3798
3799 2019-05-08  Tom Tromey  <tom@tromey.com>
3800
3801         * xcoffread.c (struct xcoff_symfile_info): Rename from
3802         coff_symfile_info.  Add initializers.
3803         (xcoff_objfile_data_key): Move lower.  Change type.
3804         (XCOFF_DATA): Rewrite.
3805         (xcoff_free_info): Remove.
3806         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3807         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3808         (xcoff_initial_scan): Update.
3809
3810 2019-05-08  Tom Tromey  <tom@tromey.com>
3811
3812         * solib-svr4.c (struct svr4_info): Add initializers and
3813         destructor.
3814         <probes_table>: Now an htab_up.
3815         (solib_svr4_pspace_data): Change type.
3816         (free_probes_table): Simplify.
3817         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3818         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3819         (probes_table_remove_objfile_probes, register_solib_event_probe)
3820         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3821         (_initialize_svr4_solib): Update.
3822
3823 2019-05-08  Tom Tromey  <tom@tromey.com>
3824
3825         * remote.c (remote_pspace_data): Change type.
3826         (remote_pspace_data_cleanup): Remove.
3827         (get_remote_exec_file, set_pspace_remote_exec_file)
3828         (_initialize_remote): Update.
3829
3830 2019-05-08  Tom Tromey  <tom@tromey.com>
3831
3832         * breakpoint.c (breakpoint_objfile_key): Change type.
3833         (get_breakpoint_objfile_data): Update.
3834         (free_breakpoint_objfile_data): Remove.
3835         (_initialize_breakpoint): Update.
3836
3837 2019-05-08  Tom Tromey  <tom@tromey.com>
3838
3839         * linux-tdep.c (struct linux_info): Add initializers.
3840         (linux_inferior_data): Move.  Change type.
3841         (invalidate_linux_cache_inf): Update.
3842         (linux_inferior_data_cleanup): Remove.
3843         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3844
3845 2019-05-08  Tom Tromey  <tom@tromey.com>
3846
3847         * auxv.c (auxv_inferior_data): Move.  Change type.
3848         (auxv_inferior_data_cleanup): Remove.
3849         (invalidate_auxv_cache_inf): Rewrite.
3850         (get_auxv_inferior_data, _initialize_auxv): Update.
3851
3852 2019-05-08  Tom Tromey  <tom@tromey.com>
3853
3854         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3855         (symfile_debug_objfile_data_key): Change type.
3856         (symfile_debug_installed, debug_qf_has_symbols)
3857         (debug_qf_find_last_source_symtab)
3858         (debug_qf_forget_cached_source_info)
3859         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3860         (debug_qf_print_stats, debug_qf_dump)
3861         (debug_qf_expand_symtabs_for_function)
3862         (debug_qf_expand_all_symtabs)
3863         (debug_qf_expand_symtabs_with_fullname)
3864         (debug_qf_map_matching_symbols)
3865         (debug_qf_expand_symtabs_matching)
3866         (debug_qf_find_pc_sect_compunit_symtab)
3867         (debug_qf_map_symbol_filenames)
3868         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3869         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3870         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3871         (debug_sym_read_linetable, debug_sym_relocate): Update.
3872         (symfile_debug_free_objfile): Remove.
3873         (install_symfile_debug_logging, _initialize_symfile_debug):
3874         Update.
3875
3876 2019-05-08  Tom Tromey  <tom@tromey.com>
3877
3878         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3879         allocate_on_obstack.
3880         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3881         (get_dwarf2_per_objfile): Update.
3882         (set_dwarf2_per_objfile): Remove.
3883         (dwarf2_has_info, dwarf2_get_section_info): Update.
3884         (dwarf2_free_objfile): Remove.
3885         (_initialize_dwarf2_read): Update.
3886
3887 2019-05-08  Tom Tromey  <tom@tromey.com>
3888
3889         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3890         initializers.
3891         <unsupported_script_warning_printed,
3892         script_not_found_warning_printed>: Now bool.
3893         (auto_load_pspace_data): Change type.
3894         (~auto_load_pspace_info): Rename from
3895         auto_load_pspace_data_cleanup.
3896         (get_auto_load_pspace_data, init_loaded_scripts_info)
3897         (clear_section_scripts, maybe_print_unsupported_script_warning)
3898         (maybe_print_script_not_found_warning, _initialize_auto_load):
3899         Update.
3900
3901 2019-05-08  Tom Tromey  <tom@tromey.com>
3902
3903         * objfiles.c (objfile_pspace_info): Add destructor and
3904         initializers.
3905         (objfiles_pspace_data): Change type.
3906         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3907         (get_objfile_pspace_data): Update.
3908         (objfiles_bfd_data): Change type.
3909         (get_objfile_bfd_data): Update.
3910         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3911
3912 2019-05-08  Tom Tromey  <tom@tromey.com>
3913
3914         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3915         Change type.
3916         (get_catch_syscall_inferior_data): Update.
3917         (catch_syscall_inferior_data_cleanup): Remove.
3918         (_initialize_break_catch_syscall): Update.
3919
3920 2019-05-08  Tom Tromey  <tom@tromey.com>
3921
3922         * inflow.c (struct terminal_info): Add destructor and
3923         initializers.
3924         (inflow_inferior_data): Change type.
3925         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3926         (get_inflow_inferior_data, inflow_inferior_exit)
3927         (swap_terminal_info, _initialize_inflow): Update.
3928
3929 2019-05-08  Tom Tromey  <tom@tromey.com>
3930
3931         * target-dcache.c (target_dcache_cleanup): Remove.
3932         (target_dcache_aspace_key): Change type.
3933         (target_dcache_init_p, target_dcache_invalidate)
3934         (target_dcache_get, target_dcache_get_or_init)
3935         (_initialize_target_dcache): Update.
3936         * dcache.h (struct dcache_deleter): New.
3937
3938 2019-05-08  Tom Tromey  <tom@tromey.com>
3939
3940         * symtab.c (struct symbol_cache): Add destructor and
3941         initializers.
3942         (symbol_cache_key): Move.  Change type.
3943         (make_symbol_cache, free_symbol_cache): Remove.
3944         (get_symbol_cache): Update.
3945         (symbol_cache_cleanup): Remove.
3946         (ALL_PSPACES, symbol_cache_flush)
3947         (maintenance_print_symbol_cache)
3948         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3949         Update.
3950
3951 2019-05-08  Tom Tromey  <tom@tromey.com>
3952
3953         * symtab.c (struct main_info): Add destructor and initializers.
3954         (main_progspace_key): Move.  Change type.
3955         (get_main_info): Update.
3956         (main_info_cleanup): Remove.
3957         (_initialize_symtab): Update.
3958
3959 2019-05-08  Tom Tromey  <tom@tromey.com>
3960
3961         * registry.h (DECLARE_REGISTRY): Define the _key class.
3962
3963 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3964
3965         * NEWS: Merge two 'New commands' sections.
3966
3967 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3968
3969         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3970         parameter and use Ada language definition instead.
3971         (ada_val_print_ptr): Remove unused language parameter.
3972         (ada_val_print_num): Remove language parameter and use Ada language
3973         definition instead.
3974         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3975         parameter.
3976         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3977         parameter and use Ada language definition instead.
3978         (ada_val_print_1): Update all ada_val_print_xxx calls.
3979         Remove language parameter.
3980         (ada_val_print): Update ada_val_print_1 call.
3981
3982 2019-05-08  Tom Tromey  <tromey@adacore.com>
3983
3984         * remote.c (remote_hw_watchpoint_limit)
3985         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3986         Now static.
3987
3988 2019-05-08  Tom Tromey  <tromey@adacore.com>
3989
3990         * maint.c (_initialize_maint_cmds): Move initialization code to
3991         remote.c.
3992         (watchdog, show_watchdog): Move to remote.c.
3993         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3994         "watchdog" static.
3995         (_initialize_remote): Move initialization code from maint.c.
3996         * defs.h (watchdog): Don't declare.
3997
3998 2019-05-08  Tom Tromey  <tromey@adacore.com>
3999
4000         * tui/tui-interp.c: Include main.h.
4001         * interps.c: Include main.h.
4002         * main.h (interpreter_p): Declare.
4003         * defs.h (interpreter_p): Don't declare.
4004
4005 2019-05-08  Tom Tromey  <tromey@adacore.com>
4006
4007         * dwarf2loc.c: Include dwarf2read.h.
4008         * defs.h (read_unsigned_leb128): Don't declare.
4009         * dwarf2read.h (read_unsigned_leb128): Declare.
4010
4011 2019-05-08  Tom Tromey  <tromey@adacore.com>
4012
4013         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4014         method.
4015
4016 2019-05-08  Tom Tromey  <tromey@adacore.com>
4017
4018         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4019         when no wrap column is set.
4020
4021 2019-05-08  Tom Tromey  <tromey@adacore.com>
4022
4023         * c-lang.c (c_get_string): Handle non-C-style arrays.
4024
4025 2019-05-08  Tom Tromey  <tromey@adacore.com>
4026
4027         * typeprint.c (print_offset_data::update): Print the bit offset,
4028         not the number of bits remaining.
4029
4030 2019-05-08  Tom Tromey  <tromey@adacore.com>
4031
4032         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4033         padding at end of comment.
4034
4035 2019-05-08  Tom Tromey  <tromey@adacore.com>
4036
4037         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4038         Compare main types.
4039
4040 2019-05-06  Tom Tromey  <tom@tromey.com>
4041
4042         * common/scoped_mmap.c: Include common-defs.h.
4043         * common/scoped_mmap.h: Don't include config.h.
4044
4045 2019-05-04  Tom Tromey  <tom@tromey.com>
4046
4047         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4048         (struct aarch64_call_info): Add initializers.
4049         <si>: Now a std::vector.
4050         (pass_on_stack, aarch64_push_dummy_call): Update.
4051
4052 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4053             Tom Tromey  <tom@tromey.com>
4054
4055         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4056         (ppc_threads): Now a std::vector.  Now static.
4057         (hwdebug_find_thread_points_by_tid)
4058         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4059         Update.
4060
4061 2019-05-04  Tom Tromey  <tom@tromey.com>
4062
4063         * arc-tdep.c (arc_tdesc_init): Return bool.
4064
4065 2019-05-04  Tom Tromey  <tom@tromey.com>
4066
4067         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4068         Use gdb_assert_not_reached.
4069
4070 2019-05-04  Tom Tromey  <tom@tromey.com>
4071
4072         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4073         "false".
4074
4075 2019-05-04  Tom Tromey  <tom@tromey.com>
4076
4077         * arc-tdep.c (arc_tdesc_init): Use bool.
4078
4079 2019-05-04  Tom Tromey  <tom@tromey.com>
4080
4081         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4082
4083 2019-05-04  Tom Tromey  <tom@tromey.com>
4084
4085         * cli/cli-cmds.c (valid_command_p): Return bool.
4086
4087 2019-05-04  Tom Tromey  <tom@tromey.com>
4088
4089         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4090         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4091
4092 2019-05-04  Raul Tambre  <raul@tambre.ee>
4093
4094         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4095         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4096         operator for comparison.
4097
4098 2019-05-04  Tom Tromey  <tom@tromey.com>
4099
4100         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4101         (lookup_partial_symbol, print_partial_symbols)
4102         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4103         (psymbol_compare): Update.
4104         (add_psymbol_to_bcache): Clear the entire psymbol.
4105         (maintenance_check_psymtabs): Update.
4106         * psympriv.h (struct partial_symbol): Don't derive from
4107         general_symbol_info.
4108         <obj_section, unrelocated_address, address,
4109         set_unrelocated_address>: Update.
4110         <ginfo>: New member.
4111         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4112         (debug_names::write_psymbols): Update.
4113
4114 2019-05-04  Tom de Vries  <tdevries@suse.de>
4115
4116         * contrib/cc-with-tweaks.sh: Support -n arg.
4117
4118 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4119
4120         * corelow.c (core_target::detach): Ensure frame cache and
4121         register caches are cleared.
4122         inferior.c (exit_inferior_1): Likewise.
4123
4124 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4125             Tom Tromey  <tom@tromey.com>
4126
4127         * dictionary.c (collate_pending_symbols_by_language): Remove
4128         "struct" from foreach.
4129         * symtab.c (lookup_global_symbol_from_objfile)
4130         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4131         foreach.
4132         * ser-tcp.c (net_open): Remove "struct" from foreach.
4133         * objfiles.c (objfile_relocate, objfile_rebase)
4134         (objfile_has_symbols): Remove "struct" from foreach.
4135         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4136         from foreach.
4137         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4138         foreach.
4139         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4140         "struct" from foreach.
4141         * ada-lang.c (create_excep_cond_exprs)
4142         (ada_exception_catchpoint_cond_string): Remove "struct" from
4143         foreach.
4144
4145 2019-05-03  Tom Tromey  <tromey@adacore.com>
4146
4147         * ada-exp.y (convert_char_literal): Check suffix of each
4148         enumerator.
4149
4150 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4151
4152         PR ada/21406:
4153         * ada-exp.y (yywrap): Don't define.
4154         * ada-lex.l (%option): Add noyywrap
4155         (yywrap): Remove.
4156
4157 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4158
4159         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4160         _WIN32_WINNT to the XP level, unless already defined to a higher
4161         level.
4162
4163         * unittests/parse-connection-spec-selftests.c:
4164         * ser-tcp.c:
4165         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4166         override.
4167
4168         * symfile.c (find_separate_debug_file): Remove colon from the
4169         drive spec of DOS/Windows file names of the target, so that the
4170         file name produced from DEBUGDIR and the target's directory will
4171         be valid on DOS/Windows systems.
4172
4173 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4174
4175         * rust-lang.c (val_print_struct): Handle printing structures
4176         containing strings.
4177
4178 2019-05-02  Tom Tromey  <tromey@adacore.com>
4179
4180         * valarith.c (_initialize_valarith): Remove.
4181
4182 2019-05-01  Tom Tromey  <tromey@adacore.com>
4183
4184         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4185         bitfields.
4186
4187 2019-05-01  Tom Tromey  <tromey@adacore.com>
4188
4189         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4190         for big-endian copies.
4191
4192 2019-04-30  Ali Tamur  <tamur@google.com>
4193         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4194         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4195         (read_3_bytes): New function.
4196
4197 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4198
4199         * windows-nat.c (main_thread_id): Delete.
4200         (handle_output_debug_string): Replace main_thread_id by
4201         current_event.dwThreadId.
4202         (fake_create_process): Likewise.
4203         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4204         Do not set main_thread_id.
4205         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4206         current_event.dwThreadId.
4207         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4208
4209 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4210
4211         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4212         Use current_event.dwThreadId instead of main_thread_id.
4213
4214 2019-04-30  Tom Tromey  <tromey@adacore.com>
4215
4216         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4217         (create_excep_cond_exprs): Iterate over program spaces.
4218         (ada_exception_catchpoint_cond_string): Examine all minimal
4219         symbols for exception types.
4220
4221 2019-04-30  Tom Tromey  <tromey@adacore.com>
4222
4223         PR c++/24470:
4224         * dwarf2read.c (process_structure_scope): Handle case where type
4225         has template parameters but no symbol was created.
4226
4227 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4228             Chris January  <chris.january@arm.com>
4229
4230         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4231         qualifier.
4232         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4233
4234 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4235
4236         * f-typeprint.c (f_print_type): Update rules for printing
4237         whitespace.
4238         (f_type_print_varspec_suffix): Likewise.
4239
4240 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4241             Chris January  <chris.january@arm.com>
4242
4243         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4244         function arguments.
4245
4246 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * f-lang.c (build_fortran_types): Change name of void type to
4249         lower case.
4250         * f-typeprint.c (f_type_print_base): Print the name of the void
4251         type, rather than a fixed string.
4252         * f-valprint.c (f_decorations): Use lower case void string.
4253
4254 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4255             Chris January  <chris.january@arm.com>
4256
4257         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4258         types for Fortran.
4259
4260 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4261             Chris January  <chris.january@arm.com>
4262             David Lecomber  <david.lecomber@arm.com>
4263
4264         * f-exp.y (BINOP_INTRINSIC): New token.
4265         (exp): New parser rule handling BINOP_INTRINSIC.
4266         (f77_keywords): Add new builtin procedures.
4267         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4268         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4269         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4270         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4271         (print_unop_subexp_f): New function.
4272         (print_binop_subexp_f): New function.
4273         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4274         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4275         (dump_subexp_body_f): Likewise.
4276         (operator_check_f): Likewise.
4277         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4278         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4279
4280 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4281
4282         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4283         UNOP_KIND.
4284         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4285         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4286         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4287         (operator_length_f): New fuction.
4288         (print_subexp_f): New function.
4289         (op_name_f): New function.
4290         (dump_subexp_body_f): New function.
4291         (operator_check_f): New function.
4292         (exp_descriptor_f): Replace standard expression handling functions
4293         with new functions.
4294         * gdb/fortran-operator.def: New file.
4295         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4296         * gdb/std-operator.def: Remove UNOP_KIND.
4297
4298 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4299
4300         * std-operator.def: Remove unbalanced, stray double quote
4301         character.
4302
4303 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4304             Chris January  <chris.january@arm.com>
4305             Daniel Everett  <daniel.everett@arm.com>
4306             Nick Forrington  <nick.forrington@arm.com>
4307             Richard Bunt  <richard.bunt@arm.com>
4308
4309         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4310         of depth when printing anonymous structs or unions.
4311         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4312         Don't print either the top-level value, or the children if the
4313         max-depth is exceeded.
4314         (ppscm_print_children): When printing the key of a map, allow one
4315         extra level of depth.
4316         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4317         print either the top-level value, or the children if the max-depth
4318         is exceeded.
4319         (print_children): When printing the key of a map, allow one extra
4320         level of depth.
4321         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4322         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4323         (user_print_options): Initialise max_depth field.
4324         (val_print_scalar_or_string_type_p): New function.
4325         (val_print): Check to see if the max depth has been reached.
4326         (val_print_check_max_depth): Define new function.
4327         (show_print_max_depth): New function.
4328         (_initialize_valprint): Add 'print max-depth' option.
4329         * valprint.h (struct value_print_options) <max_depth>: New field.
4330         (val_print_check_max_depth): Declare new function.
4331         * NEWS: Document new feature.
4332
4333 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4334
4335         * ada-lang.c (ada_language_defn): Initialise new field.
4336         * c-lang.c (c_is_string_type_p): New function.
4337         (c_language_defn): Initialise new field.
4338         (cplus_language_defn): Initialise new field.
4339         (asm_language_defn): Initialise new field.
4340         (minimal_language_defn): Initialise new field.
4341         * c-lang.h (c_is_string_type_p): Declare new function.
4342         * d-lang.c (d_language_defn): Initialise new field.
4343         * f-lang.c (f_is_string_type_p): New function.
4344         (f_language_defn): Initialise new field.
4345         * go-lang.c (go_is_string_type_p): New function.
4346         (go_language_defn): Initialise new field.
4347         * language.c (default_is_string_type_p): New function.
4348         (unknown_language_defn): Initialise new field.
4349         (auto_language_defn): Initialise new field.
4350         * language.h (struct language_defn) <la_is_string_type_p>: New
4351         member variable.
4352         (default_is_string_type_p): Declare new function.
4353         * m2-lang.c (m2_language_defn): Initialise new field.
4354         * objc-lang.c (objc_language_defn): Initialise new field.
4355         * opencl-lang.c (opencl_language_defn): Initialise new field.
4356         * p-lang.c (pascal_is_string_type_p): New function.
4357         (pascal_language_defn): Initialise new field.
4358         * rust-lang.c (rust_is_string_type_p): New function.
4359         (rust_language_defn): Initialise new field.
4360
4361 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4362
4363         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4364         New field.
4365         * ada-lang.c (ada_language_defn): Initialise new field.
4366         * c-lang.c (c_language_defn): Likewise.
4367         (cplus_language_defn): Likewise.
4368         (asm_language_defn): Likewise.
4369         (minimal_language_defn): Likewise.
4370         * d-lang.c (d_language_defn): Likewise.
4371         * f-lang.c (f_language_defn): Likewise.
4372         * go-lang.c (go_language_defn): Likewise.
4373         * language.c (unknown_language_defn): Likewise.
4374         (auto_language_defn): Likewise.
4375         * m2-lang.c (m2_language_defn): Likewise.
4376         * objc-lang.c (objc_language_defn): Likewise.
4377         * opencl-lang.c (opencl_language_defn): Likewise.
4378         * p-lang.c (pascal_language_defn): Likewise.
4379         * rust-lang.c (rust_language_defn): Likewise.
4380
4381 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4382
4383         * ada-lang.c (ada_is_character_type): Change return type to bool.
4384         (ada_is_string_type): Likewise.
4385         * ada-lang.h (ada_is_character_type): Update declaration
4386         (ada_is_string_type): Likewise.
4387
4388 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4389
4390         Support style in 'frame|thread apply'
4391
4392         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4393         * record.c (record_start, record_stop): Update callers of
4394         execute_command_to_string with false.
4395         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4396         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4397         methods.
4398         (class string_file): New constructor with term_out parameter.
4399         Override methods term_out and can_emit_style_escape.  New member
4400         term_out.
4401         (class stdio_file): Override can_emit_style_escape.
4402         (class tee_file): Override term_out and can_emit_style_escape.
4403         * utils.h (can_emit_style_escape): Remove.
4404         * utils.c (can_emit_style_escape): Likewise.
4405         Update all callers of can_emit_style_escape (SOMESTREAM) to
4406         SOMESTREAM->can_emit_style_escape.
4407         * source-cache.c (source_cache::get_source_lines): Likewise.
4408         * stack.c (frame_apply_command_count): Call execute_command_to_string
4409         passing the term_out characteristic of the current gdb_stdout.
4410         * thread.c (thr_try_catch_cmd): Likewise.
4411         * top.c (execute_command_to_string): pass term_out parameter
4412         to construct the string_file for the command output.
4413         * ui-file.c (term_cli_styling): New function (most code moved
4414         from utils.c can_emit_style_escape).
4415         (string_file::string_file, string_file::can_emit_style_escape,
4416         stdio_file::can_emit_style_escape, tee_file::term_out,
4417         tee_file::can_emit_style_escape): New functions.
4418
4419 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4420
4421         * NEWS: Mention the new set|show may-call-functions.
4422         * infcall.c (may_call_functions_p): New variable.
4423         (show_may_call_functions_p): New function.
4424         (call_function_by_hand_dummy): Throws an error if not
4425         may-call-functions.
4426         (_initialize_infcall): Call add_setshow_boolean_cmd for
4427         may-call-functions.
4428
4429 2019-04-25  Keith Seitz  <keiths@redhat.com>
4430
4431         PR c++/24367
4432         * cp-support.c (inspect_type): Don't attempt substitutions
4433         of symbol with the same name.
4434
4435 2019-04-25  Tom Tromey  <tromey@adacore.com>
4436
4437         PR gdb/24475:
4438         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4439         static.
4440
4441 2019-04-25  Tom Tromey  <tromey@adacore.com>
4442
4443         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4444         rvalue reference.
4445         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4446         (gdb_xml_parser::parse): Use std::move.
4447         * python/python-internal.h (gdbpy_convert_exception): Take a const
4448         reference.
4449         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4450         std::move.
4451         * python/py-utils.c (gdbpy_convert_exception): Take a const
4452         reference.
4453         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4454         Use std::move.
4455         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4456         Use std::move.
4457         * mi/mi-main.c (mi_print_exception): Take a const reference.
4458         * main.c (handle_command_errors): Take a const reference.
4459         * linespec.c (parse_linespec): Use std::move.
4460         * infcall.c (run_inferior_call): Use std::move.
4461         (call_function_by_hand_dummy): Use std::move.
4462         * exec.c (try_open_exec_file): Use std::move.
4463         * exceptions.h (exception_print, exception_fprintf)
4464         (exception_print_same): Update.
4465         * exceptions.c (print_exception, exception_print)
4466         (exception_fprintf, exception_print_same): Change parameters to
4467         const reference.
4468         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4469         * common/new-op.c: Use std::move.
4470         * common/common-exceptions.h (struct gdb_exception): Add move
4471         constructor.
4472         (struct gdb_exception_error, struct gdb_exception_quit, struct
4473         gdb_quit_bad_alloc): Change constructor to move constructor.
4474         (throw_exception): Change parameter to rvalue reference.
4475         * common/common-exceptions.c (throw_exception): Take rvalue
4476         reference.
4477         * cli/cli-interp.c (safe_execute_command): Use std::move.
4478         * breakpoint.c (insert_bp_location, location_to_sals): Use
4479         std::move.
4480
4481 2019-04-25  Tom Tromey  <tromey@adacore.com>
4482
4483         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4484         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4485         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4486         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4487         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4488         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4489         guile/scm-value.c: Use unpack.
4490         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4491         gdbscm_gdb_exception.
4492         (gdbscm_throw_gdb_exception): Likewise.
4493         (struct gdbscm_gdb_exception): New.
4494         (unpack): New function.
4495         (gdbscm_wrap): Use unpack.
4496
4497 2019-04-25  Tom Tromey  <tromey@adacore.com>
4498
4499         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4500         (gdb_rl_callback_handler): Use std::move.
4501         * common/common-exceptions.h (struct gdb_exception): Add move
4502         assignment operator.
4503         (throw_exception_sjlj): Change "exception" to const reference.
4504         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4505         (throw_exception_sjlj): Change "exception" to const reference.
4506
4507 2019-04-25  Tom Tromey  <tromey@adacore.com>
4508
4509         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4510         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4511         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4512         Update.
4513         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4514         Update.
4515         * mi/mi-interp.c (mi_interp::exec): Update.
4516         * linespec.c (parse_linespec): Update.
4517         * infcall.c (run_inferior_call): Update.
4518         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4519         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4520         (gdbscm_lookup_global_symbol): Update.
4521         * guile/scm-param.c (gdbscm_parameter_value): Update.
4522         * guile/scm-frame.c (gdbscm_frame_read_register)
4523         (gdbscm_frame_read_var): Update.
4524         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4525         * exec.c (try_open_exec_file): Update.
4526         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4527         (gdb_rl_callback_handler): Update.
4528         * common/common-exceptions.h (exception_none): Don't declare.
4529         * common/common-exceptions.c (exception_none): Don't define.
4530         (struct catcher) <exception>: Update.
4531         * cli/cli-interp.c (safe_execute_command): Update.
4532         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4533
4534 2019-04-25  Ali Tamur  <tamur@google.com>
4535
4536         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4537         (read_attribute_value): Likewise.
4538         (dwarf2_read_addr_index): Update comment.
4539         (read_str_index): Add DW_FORM_strx.
4540         (dwarf2_string_attr): Likewise.
4541         (dwarf2_const_value_attr): Likewise.
4542         (dump_die_shallow): Likewise.
4543         (dwarf2_fetch_constant_bytes): Likewise.
4544         (skip_form_bytes): Likewise.
4545         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4546
4547 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4548
4549         PR corefiles/11608
4550         PR corefiles/18187
4551         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4552         OFFSET.  Verify if current mapping contains an ELF header.
4553         (linux_find_memory_regions_full): Adjust call to
4554         dump_mapping_p.
4555
4556 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4557             Kang Li <kanglictf@gmail.com>
4558
4559         PR gdb/21600
4560
4561         * dwarf2-frame.c (read_initial_length): Be consistent about using
4562         unsigned representation of length.
4563         (decode_frame_entry_1): Likewise.  Check for wraparound of
4564         end pointer as well as buffer overflow.
4565
4566 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4567
4568         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4569         "vq".
4570
4571 2019-04-24  Tom Tromey  <tromey@adacore.com>
4572
4573         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4574
4575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4576
4577         * s12z-tdep.c (s12z_unwind_pc): Delete.
4578         (s12z_unwind_sp): Delete.
4579         (s12z_gdbarch_init): Don't register deleted functions with
4580         gdbarch.
4581
4582 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4583
4584         * rl78-tdep.c (rl78_unwind_sp): Delete.
4585         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4586
4587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4588
4589         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4590         (xstormy16_unwind_pc): Delete.
4591         (xstormy16_dummy_id): Delete.
4592         (xstormy16_gdbarch_init): Don't register deleted functions with
4593         gdbarch.
4594
4595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4596
4597         * vax-tdep.c (vax_unwind_pc): Delete.
4598         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4599
4600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4601
4602         * v850-tdep.c (v850_unwind_sp): Delete.
4603         (v850_unwind_pc): Delete.
4604         (v850_dummy_id): Delete.
4605         (v850_gdbarch_init): Don't register deleted functions with
4606         gdbarch.
4607
4608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4609
4610         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4611         (tilegx_unwind_pc): Delete.
4612         (tilegx_unwind_dummy_id): Delete.
4613         (tilegx_gdbarch_init): Don't register deleted functions with
4614         gdbarch.
4615
4616 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4617
4618         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4619         (tic6x_dummy_id): Delete.
4620         (tic6x_gdbarch_init): Don't register deleted functions with
4621         gdbarch.
4622
4623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4624
4625         * sparc-tdep.c (sparc_unwind_pc): Delete.
4626         (sparc32_gdbarch_init): Don't register deleted function with
4627         gdbarch.
4628
4629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4630
4631         * sh-tdep.c (sh_unwind_sp): Delete.
4632         (sh_unwind_pc): Delete.
4633         (sh_dummy_id): Delete.
4634         (sh_gdbarch_init): Don't register deleted functions with
4635         gdbarch.
4636
4637 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4638
4639         * score-tdep.c (score_unwind_sp): Delete.
4640         (score_unwind_pc): Delete.
4641         (score_dummy_id): Delete.
4642         (score_gdbarch_init): Don't register deleted functions with
4643         gdbarch.
4644
4645 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4646
4647         * rx-tdep.c (rx_unwind_pc): Delete.
4648         (rx_unwind_sp): Delete.
4649         (rx_dummy_id): Delete.
4650         (rx_gdbarch_init): Don't register deleted functions with
4651         gdbarch.  Update comment.
4652
4653 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4654
4655         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4656         (rs6000_dummy_id): Delete.
4657         (rs6000_gdbarch_init): Don't register deleted functions with
4658         gdbarch.
4659
4660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4661
4662         * or1k-tdep.c (or1k_dummy_id): Delete.
4663         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4664
4665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4666
4667         * nios2-tdep.c (nios2_dummy_id): Delete.
4668         (nios2_unwind_sp): Delete.
4669         (nios2_gdbarch_init): Don't register deleted functions with
4670         gdbarch.
4671
4672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4673
4674         * nds32-tdep.c (nds32_dummy_id): Delete.
4675         (nds32_unwind_pc): Delete.
4676         (nds32_unwind_sp): Delete.
4677         (nds32_gdbarch_init): Don't register deleted functions with
4678         gdbarch.
4679
4680 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4681
4682         * msp430-tdep.c (msp430_unwind_pc): Delete.
4683         (msp430_unwind_sp): Delete.
4684         (msp430_dummy_id): Delete.
4685         (msp430_gdbarch_init): Don't register deleted functions with
4686         gdbarch.
4687
4688 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4689
4690         * moxie-tdep.c (moxie_unwind_sp): Delete.
4691         (moxie_unwind_pc): Delete.
4692         (moxie_dummy_id): Delete.
4693         (moxie_gdbarch_init): Don't register deleted functions with
4694         gdbarch.
4695
4696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4697
4698         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4699         (mn10300_unwind_pc): Delete.
4700         (mn10300_unwind_sp): Delete.
4701         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4702         mn10300_unwind_sp.
4703         (mn10300_frame_unwind_init): Don't register deleted functions with
4704         gdbarch.
4705
4706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4707
4708         * mep-tdep.c (mep_unwind_pc): Delete.
4709         (mep_unwind_sp): Delete.
4710         (mep_dummy_id): Delete.
4711         (mep_gdbarch_init): Don't register deleted functions with
4712         gdbarch.
4713
4714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4715
4716         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4717         (m68hc11_unwind_sp): Delete.
4718         (m68hc11_gdbarch_init): Don't register deleted functions with
4719         gdbarch.
4720
4721 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4722
4723         * m32r-tdep.c (m32r_unwind_sp): Delete.
4724         (m32r_unwind_pc): Delete.
4725         (m32r_dummy_id): Delete.
4726         (m32r_gdbarch_init): Don't register deleted functions with
4727         gdbarch.
4728
4729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4730
4731         * m32c-tdep.c (m32c_unwind_pc): Delete.
4732         (m32c_unwind_sp): Delete.
4733         (m32c_dummy_id): Delete.
4734         (m32c_gdbarch_init): Don't register deleted functions with
4735         gdbarch.
4736
4737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4738
4739         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4740         (lm32_unwind_pc): Delete.
4741         (lm32_dummy_id): Delete.
4742         (lm32_gdbarch_init): Don't register deleted functions with
4743         gdbarch.
4744
4745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4746
4747         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4748         (iq2000_unwind_pc): Delete.
4749         (iq2000_dummy_id): Delete.
4750         (iq2000_gdbarch_init): Don't register deleted functions with
4751         gdbarch.
4752
4753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4754
4755         * nds32-tdep.c (nds32_type_align): Delete.
4756         (nds32_push_dummy_call): Use type_align instead.
4757
4758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4759
4760         * arm-tdep.c (arm_type_align): Only handle vector override case.
4761         (arm_push_dummy_call): Use type_align.
4762         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4763
4764 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4765
4766         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4767         case.
4768         (pass_on_stack): Use type_align.
4769         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4770         function.
4771
4772 2019-04-23  Tom Tromey  <tromey@adacore.com>
4773
4774         * dwarf2read.c (line_header::file_name_at): Remove unused
4775         overload.
4776
4777 2019-04-23  Tom de Vries  <tdevries@suse.de>
4778
4779         PR gdb/24438
4780         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4781         invocation.
4782
4783
4784 2019-03-27  Ali Tamur  <tamur@google.com>
4785
4786         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4787         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4788         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4789         (dwarf_expr_context::get_addr_index): Likewise
4790         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4791         (symbol_needs_eval_context::get_addr_index): Likewise
4792         (disassemble_dwarf_expression): Add DW_OP_addrx
4793         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4794         (read_cutu_die_from_dwo): Update comment
4795         (skip_one_die): Add DW_FORM_addrx
4796         (read_attribute_value): Likewise
4797         (var_decode_location): Add DW_OP_addrx
4798         (dwarf2_const_value_attr): Add DW_FORM_addrx
4799         (dump_die_shallow): Likewise
4800         (dwarf2_fetch_constant_bytes): Likewise
4801         (decode_locdesc): Add DW_OP_addrx
4802         (skip_form_bytes): Add DW_FORM_addrx
4803
4804 2019-04-22  Ali Tamur  <tamur@google.com>
4805
4806         * MAINTAINERS (Write After Approval): Add self.
4807
4808 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4809
4810         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4811         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4812         (open_symbol_file_object): Likewise.
4813         (svr4_default_sos): Add info parameter.
4814         (svr4_read_so_list): Likewise.
4815         (svr4_current_sos_direct): Adjust functions calls to pass down
4816         info.
4817         (svr4_current_sos_1): Add info parameter.
4818         (svr4_current_sos): Call get_svr4_info, pass info down to
4819         svr4_current_sos_1.
4820         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4821         get_svr4_info.
4822         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4823         get_svr4_info.
4824         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4825         to get_svr4_info.
4826         (probes_table_remove_objfile_probes): Likewise.
4827         (register_solib_event_probe): Add info parameter.
4828         (solist_update_incremental): Pass info parameter down to
4829         svr4_read_so_list.
4830         (disable_probes_interface): Add info parameter.
4831         (svr4_handle_solib_event): Pass current_program_space to
4832         get_svr4_info.  Adjust disable_probes_interface cleanup.
4833         (svr4_create_probe_breakpoints): Add info parameter, pass it
4834         down to register_solib_event_probe.
4835         (svr4_create_solib_event_breakpoints): Add info parameter,
4836         pass it down to svr4_create_probe_breakpoints.
4837         (enable_break): Pass info down to
4838         svr4_create_solib_event_breakpoints.
4839         (svr4_solib_create_inferior_hook): Pass current_program_space to
4840         get_svr4_info.
4841         (svr4_clear_solib): Likewise.
4842
4843 2019-04-22  Pedro Alves  <palves@redhat.com>
4844
4845         * solib-svr4.c (svr4_free_objfile_observer): New.
4846         (probe_and_action::objfile): New field.
4847         (probes_table_htab_remove_objfile_probes)
4848         (probes_table_remove_objfile_probes): New functions.
4849         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4850         in the new probe_and_action.  Don't store the probe in 'lookup'.
4851         (svr4_create_probe_breakpoints): Pass objfile to
4852         register_solib_event_probe.
4853         (_initialize_svr4_solib): Register a free_objfile observer.
4854
4855 2019-04-19  Tom Tromey  <tom@tromey.com>
4856
4857         * common/queue.h: Remove.
4858
4859 2019-04-19  Tom Tromey  <tom@tromey.com>
4860
4861         * event-loop.c: Don't include "common/queue.h".
4862
4863 2019-04-19  Tom Tromey  <tom@tromey.com>
4864
4865         * remote.c (remote_target): Use delete.
4866         * remote-notif.h: Include <list>, not "common/queue.h".
4867         (notif_client_p): Remove typedef.
4868         (remote_notif_state): Add constructor, destructor, initializer.
4869         <notif_queue>: Now a std::list.
4870         (remote_notif_state_xfree): Don't declare.
4871         * remote-notif.c (remote_notif_process, handle_notification)
4872         (remote_notif_state_allocate): Update.
4873         (~remote_notif_state): Rename from remote_notif_state_xfree.
4874
4875 2019-04-19  Tom Tromey  <tom@tromey.com>
4876
4877         * symfile.c (reread_symbols): Update.
4878         * objfiles.c (objfile_register_static_link)
4879         (objfile_lookup_static_link): Update
4880         (~objfile) Don't delete static_links.
4881         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4882
4883 2019-04-19  Tom Tromey  <tom@tromey.com>
4884
4885         * type-stack.h (struct type_stack) <insert>: Constify string.
4886         * type-stack.c (type_stack::insert): Constify string.
4887         * gdbtypes.h (lookup_template_type): Update.
4888         (address_space_name_to_int): Update.
4889         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4890         const.
4891         (lookup_template_type): Make name const.
4892         * c-exp.y: Update rules.
4893         (lex_one_token, classify_name, classify_inner_name)
4894         (c_print_token): Update.
4895         * p-exp.y: Update rules.
4896         (yylex): Update.
4897         * f-exp.y: Update rules.
4898         (yylex): Update.
4899         * d-exp.y: Update rules.
4900         (lex_one_token, classify_name, classify_inner_name): Update.
4901         * parse.c (write_dollar_variable, copy_name): Return std::string.
4902         * parser-defs.h (copy_name): Change return type.
4903         * m2-exp.y: Update rules.
4904         (yylex): Update.
4905         * go-exp.y (lex_one_token): Update.
4906         Update rules.
4907         (classify_unsafe_function, classify_packaged_name)
4908         (classify_name, yylex): Update.
4909
4910 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4911
4912         * configure.ac: add --enable-source-highlight switch.
4913         * configure: Regenerate.
4914         * top.c (print_gdb_version): plumb --enable-source-highlight
4915         status to "show configuration".
4916
4917 2019-04-19  Tom Tromey  <tromey@adacore.com>
4918
4919         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4920         Check ADA_TYPE_P.
4921         (empty_record, ada_template_to_fixed_record_type_1)
4922         (template_to_static_fixed_type)
4923         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4924         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4925         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4926         macros.
4927
4928 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4929
4930         PR symtab/24423:
4931         * source.c (print_source_lines_base): Advance "iter" when a
4932         control character is seen.
4933
4934 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4935
4936         * inferior.h (struct infcall_suspend_state_deleter):
4937         Catch exception in destructor to avoid crash.
4938
4939 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4940
4941         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4942         close to the add_com "shell".
4943
4944 2019-04-18  Tom Tromey  <tromey@adacore.com>
4945
4946         * process-stratum-target.h (class process_stratum_target)
4947         <stratum>: Add "final".
4948
4949 2019-04-17  Tom Tromey  <tromey@adacore.com>
4950
4951         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4952         against nullptr before use.
4953
4954 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4955
4956         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4957
4958 2019-04-17  Jim Wilson  <jimw@sifive.com>
4959             Andrew Burgess  <andrew.burgess@embecosm.com>
4960
4961         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4962         code read might fail, assume 4-byte breakpoint in that case.
4963
4964 2019-04-15  Leszek Swirski  <leszeks@google.com>
4965
4966         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4967         rather than a hand-rolled POD check when checking for forced MEMORY
4968         classification.
4969
4970 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4971
4972         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4973         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4974         function.
4975         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4976         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4977         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4978         declaration.
4979
4980 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4981
4982         * aarch64-linux-nat.c
4983         (aarch64_linux_nat_target::thread_architecture): Add override.
4984         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4985         each VQ.
4986
4987 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4988
4989         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4990
4991 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4992
4993         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4994         target types of size 96-bits, add some additional comments, and
4995         check that the builtin type we found was the correct size.
4996
4997 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4998
4999         * utils.c (prompt_for_continue): Don't restore the styling at the
5000         end, as applied_style has the wrong value.  This fixes styling in
5001         long lists of file names that are interrupted by the "Continue?"
5002         prompt.
5003
5004 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5005
5006         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5007         * c-lang.c (c_language_defn): Likewise.
5008         (cplus_language_defn): Likewise.
5009         (asm_language_defn): Likewise.
5010         (minimal_language_defn): Likewise.
5011         * d-lang.c (d_language_defn): Likewise.
5012         * f-lang.c (f_language_defn): Likewise.
5013         * go-lang.c (go_language_defn): Likewise.
5014         * language.c (unknown_language_defn): Likewise.
5015         (auto_language_defn): Likewise.
5016         * language.h (struct language_defn): Remove la_magic field.
5017         (LANG_MAGIC): Delete.
5018         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5019         * objc-lang.c (objc_language_defn): Likewise.
5020         * opencl-lang.c (opencl_language_defn): Likewise.
5021         * p-lang.c (pascal_language_defn): Likewise.
5022         * rust-lang.c (rust_language_defn): Likewise.
5023
5024 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5025
5026         * riscv-tdep.c (riscv_type_align): New function.
5027         (riscv_type_alignment): Delete.
5028         (riscv_arg_location): Use 'type_align'.
5029         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5030
5031 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5032
5033         * gdbtypes.c (type_align): A struct with no non-static fields also
5034         has alignment of 1.
5035
5036 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5037
5038         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5039         component to 0.
5040         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5041         member.
5042         (riscv_struct_info::analyse): New implementation using new
5043         analyse_inner member function.
5044         (riscv_struct_info::field_offset): New member function.
5045         (riscv_struct_info::m_offsets): New member variable.
5046         (riscv_struct_info::analyse_inner): New private member function,
5047         takes the old implementation of riscv_struct_info::analyse but
5048         extended to track field offsets.
5049         (riscv_call_arg_struct): Update the struct folding special cases
5050         to handle cases where empty C++ structs, which are non-zero
5051         length, are found.
5052         (riscv_arg_location): Initialise the length of each location, a
5053         non-zero length now indicates the location is in use.
5054         (riscv_push_dummy_call): Allow for the first location having a
5055         non-zero offset when setting up arguments.
5056         (riscv_return_value): Likewise, but for return values.
5057
5058 2019-04-11  Tom Tromey  <tromey@adacore.com>
5059
5060         * utils.c (internal_vproblem): Make "msg" const.
5061
5062 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5063
5064         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5065         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5066         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5067         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5068
5069 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5070
5071         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5072         function.
5073         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5074         of amd64_collect_native_gregset.
5075         (amd64_linux_nat_target::store_registers): Likewise.
5076
5077 2019-04-10  Tom Tromey  <tom@tromey.com>
5078
5079         * symtab.c (lookup_global_symbol_from_objfile)
5080         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5081         * objfiles.h (class separate_debug_iterator): New.
5082         (class separate_debug_range): New.
5083         (struct objfile) <separate_debug_objfiles>: New method.
5084         (objfile_separate_debug_iterate): Don't declare.
5085         * objfiles.c (separate_debug_iterator::operator++): Rename from
5086         objfile_separate_debug_iterate.
5087         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5088         iterator.
5089         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5090         iterator.
5091
5092 2019-04-10  Tom Tromey  <tom@tromey.com>
5093
5094         * symfile.c (reread_symbols): Remove old comment.
5095         * objfiles.c (free_all_objfiles): Fix a typo.
5096
5097 2019-04-10  Tom Tromey  <tom@tromey.com>
5098
5099         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5100         * minsyms.c (lookup_minimal_symbol): Use foreach.
5101         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5102         (lookup_minimal_symbol_solib_trampoline): Likewise.
5103         * symfile.c (reread_symbols): Use foreach.
5104
5105 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5106             Tom Tromey  <tromey@adacore.com>
5107
5108         PR rust/24414:
5109         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5110         (rust_lex_int_test): Change "value" to be LONGEST.
5111         (rust_lex_tests): Add test for long integer literal.
5112
5113 2019-04-09  Tom Tromey  <tromey@adacore.com>
5114
5115         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5116         to bool.
5117         (extended_remote_target::attach): Update.
5118         (remote_target::remote_notice_new_inferior): Update.
5119         (remote_target::add_current_inferior_and_thread): Update.
5120         * inferior.c (exit_inferior_1): Use "false".
5121         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5122
5123 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5124
5125         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5126         the "start" command.
5127
5128 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5129
5130         * python/py-inferior.c (infpy_thread_from_thread_handle):
5131         Adjust comments to reflect renaming of thread_from_thread_handle
5132         to thread_from_handle.  Adjust keywords.  Fix type error message.
5133         (inferior_object_methods): Add thread_from_handle.  Retain
5134         thread_from_thread_handle, but mark it as deprecated.
5135
5136 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5137
5138         * gdbthread.h (find_thread_by_handle): Revise declaration.
5139         * thread.c (find_thread_by_handle): Likewise.  Adjust
5140         implementation too.
5141         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5142         support for buffer objects as handles.
5143
5144 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5145
5146         * python/py-infthread.c (thpy_thread_handle): New function.
5147         (thread_object_methods): Register thpy_thread_handle.
5148
5149 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5150
5151         * gdbthread.h (thread_to_thread_handle): Declare.
5152         * thread.c (gdbtypes.h): Include.
5153         (thread_to_thread_handle): New function.
5154
5155         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5156         (target_thread_info_to_thread_handle): Declare.
5157         * target.c (target_thread_info_to_thread_handle): New function.
5158         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5159         * target-delegates.c: Regenerate.
5160
5161         * linux-thread-db.c (class thread_db_target): Add method
5162         thread_info_to_thread_handle.
5163         (thread_db_target::thread_info_to_thread_handle): Define.
5164         * remote.c (class remote_target): Add new method
5165         thread_info_to_thread_handle.
5166         (remote_target::thread_info_to_thread_handle): Define.
5167
5168 2019-04-08  Pedro Alves  <palves@redhat.com>
5169
5170         * common/common-exceptions.c (throw_exception): Don't create
5171         named object to throw; throw directly.
5172         (throw_it): Likewise.  Don't initialize gdb_exception::message
5173         here, with new; pass FMT and AP to the ctor instead.
5174         * common/common-exceptions.h: Include <string>.
5175         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5176         const char *, va_list)): New ctor.  Use std::make_shared.
5177         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5178         errors)): Delete.
5179         (gdb_exception_error::gdb_exception_error(enum errors, const char
5180         *, va_list)): New.
5181         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5182         Add assertion.
5183         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5184         errors)): Delete.
5185         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5186         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5187         Add assertion.
5188
5189 2019-04-08  Tom Tromey  <tom@tromey.com>
5190
5191         * valops.c (value_rtti_indirect_type): Replace throw_exception
5192         with throw.
5193         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5194         with throw.
5195         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5196         throw.
5197         * target.c (target_translate_tls_address): Replace throw_exception
5198         with throw.
5199         * stack.c (frame_apply_command_count): Replace throw_exception
5200         with throw.
5201         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5202         throw.
5203         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5204         with throw.
5205         * rs6000-tdep.c (rs6000_frame_cache)
5206         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5207         * remote.c: Replace throw_exception with throw.
5208         * record-full.c (record_full_message, record_full_wait_1)
5209         (record_full_restore): Replace throw_exception with throw.
5210         * record-btrace.c:
5211         (get_thread_current_frame_id, record_btrace_start_replaying)
5212         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5213         (cmd_record_btrace_start): Replace throw_exception with throw.
5214         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5215         throw.
5216         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5217         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5218         * linespec.c:
5219         (find_linespec_symbols): Replace throw_exception with throw.
5220         * infrun.c (displaced_step_prepare, resume): Replace
5221         throw_exception with throw.
5222         * infcmd.c (post_create_inferior): Replace throw_exception with
5223         throw.
5224         * inf-loop.c (inferior_event_handler): Replace throw_exception
5225         with throw.
5226         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5227         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5228         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5229         (get_prev_frame_always, get_frame_pc_if_available)
5230         (get_frame_address_in_block_if_available, get_frame_language):
5231         Replace throw_exception with throw.
5232         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5233         throw_exception with throw.
5234         * eval.c (fetch_subexp_value, evaluate_var_value)
5235         (evaluate_funcall, evaluate_subexp_standard): Replace
5236         throw_exception with throw.
5237         * dwarf2loc.c (call_site_find_chain)
5238         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5239         Replace throw_exception with throw.
5240         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5241         with throw.
5242         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5243         throw.
5244         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5245         * completer.c (complete_line_internal): Replace throw_exception
5246         with throw.
5247         * compile/compile-object-run.c (compile_object_run): Replace
5248         throw_exception with throw.
5249         * cli/cli-script.c (process_next_line): Replace throw_exception
5250         with throw.
5251         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5252         (btrace_enable, btrace_maint_update_pt_packets): Replace
5253         throw_exception with throw.
5254         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5255         throw_exception with throw.
5256         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5257         throw_exception with throw.
5258         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5259         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5260         * aarch64-tdep.c (aarch64_make_prologue_cache)
5261         (aarch64_make_stub_cache): Replace throw_exception with throw.
5262
5263 2019-04-08  Tom Tromey  <tom@tromey.com>
5264
5265         * common/common-exceptions.c (throw_exception): Rename from
5266         throw_exception_cxx.  Remove old copy.  Make argument const.
5267         (throw_it): Create and throw exception objects directly.
5268         * common/common-exceptions.h (throw_exception): Make argument
5269         const.
5270         (struct gdb_exception_error): Add constructor.
5271         (struct gdb_exception_quit): Add constructor.
5272
5273 2019-04-08  Tom Tromey  <tom@tromey.com>
5274
5275         * common/common-exceptions.h (exception_rethrow): Don't declare.
5276         (TRY_SJLJ): Update comment.
5277         (TRY, CATCH, END_CATCH): Remove.
5278         * common/common-exceptions.c (exception_rethrow): Remove.
5279
5280 2019-04-08  Tom Tromey  <tom@tromey.com>
5281
5282         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5283         Remove.
5284         (gdb_exception_error): Rename from
5285         gdb_exception_RETURN_MASK_ERROR.
5286         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5287         (gdb_quit_bad_alloc): Update.
5288         * aarch64-tdep.c: Update.
5289         * ada-lang.c: Update.
5290         * ada-typeprint.c: Update.
5291         * ada-valprint.c: Update.
5292         * amd64-tdep.c: Update.
5293         * arch-utils.c: Update.
5294         * break-catch-throw.c: Update.
5295         * breakpoint.c: Update.
5296         * btrace.c: Update.
5297         * c-varobj.c: Update.
5298         * cli/cli-cmds.c: Update.
5299         * cli/cli-interp.c: Update.
5300         * cli/cli-script.c: Update.
5301         * common/common-exceptions.c: Update.
5302         * common/new-op.c: Update.
5303         * common/selftest.c: Update.
5304         * compile/compile-c-symbols.c: Update.
5305         * compile/compile-cplus-symbols.c: Update.
5306         * compile/compile-object-load.c: Update.
5307         * compile/compile-object-run.c: Update.
5308         * completer.c: Update.
5309         * corelow.c: Update.
5310         * cp-abi.c: Update.
5311         * cp-support.c: Update.
5312         * cp-valprint.c: Update.
5313         * darwin-nat.c: Update.
5314         * disasm-selftests.c: Update.
5315         * dtrace-probe.c: Update.
5316         * dwarf-index-cache.c: Update.
5317         * dwarf-index-write.c: Update.
5318         * dwarf2-frame-tailcall.c: Update.
5319         * dwarf2-frame.c: Update.
5320         * dwarf2loc.c: Update.
5321         * dwarf2read.c: Update.
5322         * eval.c: Update.
5323         * event-loop.c: Update.
5324         * event-top.c: Update.
5325         * exec.c: Update.
5326         * f-valprint.c: Update.
5327         * fbsd-tdep.c: Update.
5328         * frame-unwind.c: Update.
5329         * frame.c: Update.
5330         * gdbtypes.c: Update.
5331         * gnu-v3-abi.c: Update.
5332         * guile/guile-internal.h: Update.
5333         * guile/scm-block.c: Update.
5334         * guile/scm-breakpoint.c: Update.
5335         * guile/scm-cmd.c: Update.
5336         * guile/scm-disasm.c: Update.
5337         * guile/scm-frame.c: Update.
5338         * guile/scm-lazy-string.c: Update.
5339         * guile/scm-math.c: Update.
5340         * guile/scm-param.c: Update.
5341         * guile/scm-ports.c: Update.
5342         * guile/scm-pretty-print.c: Update.
5343         * guile/scm-symbol.c: Update.
5344         * guile/scm-symtab.c: Update.
5345         * guile/scm-type.c: Update.
5346         * guile/scm-value.c: Update.
5347         * i386-linux-tdep.c: Update.
5348         * i386-tdep.c: Update.
5349         * inf-loop.c: Update.
5350         * infcall.c: Update.
5351         * infcmd.c: Update.
5352         * infrun.c: Update.
5353         * jit.c: Update.
5354         * language.c: Update.
5355         * linespec.c: Update.
5356         * linux-fork.c: Update.
5357         * linux-nat.c: Update.
5358         * linux-tdep.c: Update.
5359         * linux-thread-db.c: Update.
5360         * main.c: Update.
5361         * mi/mi-cmd-break.c: Update.
5362         * mi/mi-cmd-stack.c: Update.
5363         * mi/mi-interp.c: Update.
5364         * mi/mi-main.c: Update.
5365         * objc-lang.c: Update.
5366         * p-valprint.c: Update.
5367         * parse.c: Update.
5368         * ppc-linux-tdep.c: Update.
5369         * printcmd.c: Update.
5370         * python/py-arch.c: Update.
5371         * python/py-breakpoint.c: Update.
5372         * python/py-cmd.c: Update.
5373         * python/py-finishbreakpoint.c: Update.
5374         * python/py-frame.c: Update.
5375         * python/py-framefilter.c: Update.
5376         * python/py-gdb-readline.c: Update.
5377         * python/py-inferior.c: Update.
5378         * python/py-infthread.c: Update.
5379         * python/py-lazy-string.c: Update.
5380         * python/py-linetable.c: Update.
5381         * python/py-objfile.c: Update.
5382         * python/py-param.c: Update.
5383         * python/py-prettyprint.c: Update.
5384         * python/py-progspace.c: Update.
5385         * python/py-record-btrace.c: Update.
5386         * python/py-record.c: Update.
5387         * python/py-symbol.c: Update.
5388         * python/py-type.c: Update.
5389         * python/py-unwind.c: Update.
5390         * python/py-utils.c: Update.
5391         * python/py-value.c: Update.
5392         * python/python.c: Update.
5393         * record-btrace.c: Update.
5394         * record-full.c: Update.
5395         * remote-fileio.c: Update.
5396         * remote.c: Update.
5397         * riscv-tdep.c: Update.
5398         * rs6000-aix-tdep.c: Update.
5399         * rs6000-tdep.c: Update.
5400         * rust-exp.y: Update.
5401         * rust-lang.c: Update.
5402         * s390-tdep.c: Update.
5403         * selftest-arch.c: Update.
5404         * solib-dsbt.c: Update.
5405         * solib-frv.c: Update.
5406         * solib-spu.c: Update.
5407         * solib-svr4.c: Update.
5408         * solib.c: Update.
5409         * sparc64-linux-tdep.c: Update.
5410         * stack.c: Update.
5411         * symfile-mem.c: Update.
5412         * symmisc.c: Update.
5413         * target.c: Update.
5414         * thread.c: Update.
5415         * top.c: Update.
5416         * tracefile-tfile.c: Update.
5417         * tui/tui.c: Update.
5418         * typeprint.c: Update.
5419         * unittests/cli-utils-selftests.c: Update.
5420         * unittests/parse-connection-spec-selftests.c: Update.
5421         * valops.c: Update.
5422         * valprint.c: Update.
5423         * value.c: Update.
5424         * varobj.c: Update.
5425         * windows-nat.c: Update.
5426         * x86-linux-nat.c: Update.
5427         * xml-support.c: Update.
5428
5429 2019-04-08  Tom Tromey  <tom@tromey.com>
5430
5431         * xml-support.c: Use C++ exception handling.
5432         * x86-linux-nat.c: Use C++ exception handling.
5433         * windows-nat.c: Use C++ exception handling.
5434         * varobj.c: Use C++ exception handling.
5435         * value.c: Use C++ exception handling.
5436         * valprint.c: Use C++ exception handling.
5437         * valops.c: Use C++ exception handling.
5438         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5439         handling.
5440         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5441         * typeprint.c: Use C++ exception handling.
5442         * tui/tui.c: Use C++ exception handling.
5443         * tracefile-tfile.c: Use C++ exception handling.
5444         * top.c: Use C++ exception handling.
5445         * thread.c: Use C++ exception handling.
5446         * target.c: Use C++ exception handling.
5447         * symmisc.c: Use C++ exception handling.
5448         * symfile-mem.c: Use C++ exception handling.
5449         * stack.c: Use C++ exception handling.
5450         * sparc64-linux-tdep.c: Use C++ exception handling.
5451         * solib.c: Use C++ exception handling.
5452         * solib-svr4.c: Use C++ exception handling.
5453         * solib-spu.c: Use C++ exception handling.
5454         * solib-frv.c: Use C++ exception handling.
5455         * solib-dsbt.c: Use C++ exception handling.
5456         * selftest-arch.c: Use C++ exception handling.
5457         * s390-tdep.c: Use C++ exception handling.
5458         * rust-lang.c: Use C++ exception handling.
5459         * rust-exp.y: Use C++ exception handling.
5460         * rs6000-tdep.c: Use C++ exception handling.
5461         * rs6000-aix-tdep.c: Use C++ exception handling.
5462         * riscv-tdep.c: Use C++ exception handling.
5463         * remote.c: Use C++ exception handling.
5464         * remote-fileio.c: Use C++ exception handling.
5465         * record-full.c: Use C++ exception handling.
5466         * record-btrace.c: Use C++ exception handling.
5467         * python/python.c: Use C++ exception handling.
5468         * python/py-value.c: Use C++ exception handling.
5469         * python/py-utils.c: Use C++ exception handling.
5470         * python/py-unwind.c: Use C++ exception handling.
5471         * python/py-type.c: Use C++ exception handling.
5472         * python/py-symbol.c: Use C++ exception handling.
5473         * python/py-record.c: Use C++ exception handling.
5474         * python/py-record-btrace.c: Use C++ exception handling.
5475         * python/py-progspace.c: Use C++ exception handling.
5476         * python/py-prettyprint.c: Use C++ exception handling.
5477         * python/py-param.c: Use C++ exception handling.
5478         * python/py-objfile.c: Use C++ exception handling.
5479         * python/py-linetable.c: Use C++ exception handling.
5480         * python/py-lazy-string.c: Use C++ exception handling.
5481         * python/py-infthread.c: Use C++ exception handling.
5482         * python/py-inferior.c: Use C++ exception handling.
5483         * python/py-gdb-readline.c: Use C++ exception handling.
5484         * python/py-framefilter.c: Use C++ exception handling.
5485         * python/py-frame.c: Use C++ exception handling.
5486         * python/py-finishbreakpoint.c: Use C++ exception handling.
5487         * python/py-cmd.c: Use C++ exception handling.
5488         * python/py-breakpoint.c: Use C++ exception handling.
5489         * python/py-arch.c: Use C++ exception handling.
5490         * printcmd.c: Use C++ exception handling.
5491         * ppc-linux-tdep.c: Use C++ exception handling.
5492         * parse.c: Use C++ exception handling.
5493         * p-valprint.c: Use C++ exception handling.
5494         * objc-lang.c: Use C++ exception handling.
5495         * mi/mi-main.c: Use C++ exception handling.
5496         * mi/mi-interp.c: Use C++ exception handling.
5497         * mi/mi-cmd-stack.c: Use C++ exception handling.
5498         * mi/mi-cmd-break.c: Use C++ exception handling.
5499         * main.c: Use C++ exception handling.
5500         * linux-thread-db.c: Use C++ exception handling.
5501         * linux-tdep.c: Use C++ exception handling.
5502         * linux-nat.c: Use C++ exception handling.
5503         * linux-fork.c: Use C++ exception handling.
5504         * linespec.c: Use C++ exception handling.
5505         * language.c: Use C++ exception handling.
5506         * jit.c: Use C++ exception handling.
5507         * infrun.c: Use C++ exception handling.
5508         * infcmd.c: Use C++ exception handling.
5509         * infcall.c: Use C++ exception handling.
5510         * inf-loop.c: Use C++ exception handling.
5511         * i386-tdep.c: Use C++ exception handling.
5512         * i386-linux-tdep.c: Use C++ exception handling.
5513         * guile/scm-value.c: Use C++ exception handling.
5514         * guile/scm-type.c: Use C++ exception handling.
5515         * guile/scm-symtab.c: Use C++ exception handling.
5516         * guile/scm-symbol.c: Use C++ exception handling.
5517         * guile/scm-pretty-print.c: Use C++ exception handling.
5518         * guile/scm-ports.c: Use C++ exception handling.
5519         * guile/scm-param.c: Use C++ exception handling.
5520         * guile/scm-math.c: Use C++ exception handling.
5521         * guile/scm-lazy-string.c: Use C++ exception handling.
5522         * guile/scm-frame.c: Use C++ exception handling.
5523         * guile/scm-disasm.c: Use C++ exception handling.
5524         * guile/scm-cmd.c: Use C++ exception handling.
5525         * guile/scm-breakpoint.c: Use C++ exception handling.
5526         * guile/scm-block.c: Use C++ exception handling.
5527         * guile/guile-internal.h: Use C++ exception handling.
5528         * gnu-v3-abi.c: Use C++ exception handling.
5529         * gdbtypes.c: Use C++ exception handling.
5530         * frame.c: Use C++ exception handling.
5531         * frame-unwind.c: Use C++ exception handling.
5532         * fbsd-tdep.c: Use C++ exception handling.
5533         * f-valprint.c: Use C++ exception handling.
5534         * exec.c: Use C++ exception handling.
5535         * event-top.c: Use C++ exception handling.
5536         * event-loop.c: Use C++ exception handling.
5537         * eval.c: Use C++ exception handling.
5538         * dwarf2read.c: Use C++ exception handling.
5539         * dwarf2loc.c: Use C++ exception handling.
5540         * dwarf2-frame.c: Use C++ exception handling.
5541         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5542         * dwarf-index-write.c: Use C++ exception handling.
5543         * dwarf-index-cache.c: Use C++ exception handling.
5544         * dtrace-probe.c: Use C++ exception handling.
5545         * disasm-selftests.c: Use C++ exception handling.
5546         * darwin-nat.c: Use C++ exception handling.
5547         * cp-valprint.c: Use C++ exception handling.
5548         * cp-support.c: Use C++ exception handling.
5549         * cp-abi.c: Use C++ exception handling.
5550         * corelow.c: Use C++ exception handling.
5551         * completer.c: Use C++ exception handling.
5552         * compile/compile-object-run.c: Use C++ exception handling.
5553         * compile/compile-object-load.c: Use C++ exception handling.
5554         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5555         * compile/compile-c-symbols.c: Use C++ exception handling.
5556         * common/selftest.c: Use C++ exception handling.
5557         * common/new-op.c: Use C++ exception handling.
5558         * cli/cli-script.c: Use C++ exception handling.
5559         * cli/cli-interp.c: Use C++ exception handling.
5560         * cli/cli-cmds.c: Use C++ exception handling.
5561         * c-varobj.c: Use C++ exception handling.
5562         * btrace.c: Use C++ exception handling.
5563         * breakpoint.c: Use C++ exception handling.
5564         * break-catch-throw.c: Use C++ exception handling.
5565         * arch-utils.c: Use C++ exception handling.
5566         * amd64-tdep.c: Use C++ exception handling.
5567         * ada-valprint.c: Use C++ exception handling.
5568         * ada-typeprint.c: Use C++ exception handling.
5569         * ada-lang.c: Use C++ exception handling.
5570         * aarch64-tdep.c: Use C++ exception handling.
5571
5572 2019-04-08  Tom Tromey  <tom@tromey.com>
5573
5574         * xml-support.c (gdb_xml_parser::parse): Update.
5575         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5576         * value.c (show_convenience): Update.
5577         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5578         (test_parse_flags_qcs): Update.
5579         * thread.c (thr_try_catch_cmd): Update.
5580         * target.c (target_translate_tls_address): Update.
5581         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5582         (info_frame_command_core, frame_apply_command_count): Update.
5583         * rust-exp.y (rust_lex_exception_test): Update.
5584         * riscv-tdep.c (riscv_print_one_register_info): Update.
5585         * remote.c (remote_target::enable_btrace): Update.
5586         * record-btrace.c (record_btrace_enable_warn): Update.
5587         * python/py-utils.c (gdbpy_convert_exception): Update.
5588         * printcmd.c (do_one_display, print_variable_and_value): Update.
5589         * mi/mi-main.c (mi_print_exception): Update.
5590         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5591         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5592         * linux-nat.c (linux_nat_target::attach): Update.
5593         * linux-fork.c (class scoped_switch_fork_info): Update.
5594         * infrun.c (displaced_step_prepare): Update.
5595         * infcall.c (call_function_by_hand_dummy): Update.
5596         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5597         * gnu-v3-abi.c (print_one_vtable): Update.
5598         * frame.c (get_prev_frame_always): Update.
5599         * f-valprint.c (info_common_command_for_block): Update.
5600         * exec.c (try_open_exec_file): Update.
5601         * exceptions.c (print_exception, exception_print)
5602         (exception_fprintf, exception_print_same): Update.
5603         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5604         * dwarf-index-cache.c (index_cache::store)
5605         (index_cache::lookup_gdb_index): Update.
5606         * darwin-nat.c (maybe_cache_shell): Update.
5607         * cp-valprint.c (cp_print_value_fields): Update.
5608         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5609         (gcc_cplus_symbol_address): Update.
5610         * compile/compile-c-symbols.c (gcc_convert_symbol)
5611         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5612         * common/selftest.c: Update.
5613         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5614         a std::string.
5615         (exception_try_scope_entry, exception_try_scope_exit): Don't
5616         declare.
5617         (struct exception_try_scope): Remove.
5618         (TRY): Don't use exception_try_scope.
5619         (struct gdb_exception): Add constructor, operator=.
5620         <what>: New method.
5621         (struct gdb_exception_RETURN_MASK_ALL)
5622         (struct gdb_exception_RETURN_MASK_ERROR)
5623         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5624         (struct gdb_quit_bad_alloc): Update.
5625         * common/common-exceptions.c (exception_none): Change
5626         initializer.
5627         (struct catcher) <state, exception>: Initialize inline.
5628         <prev>: Remove member.
5629         (current_catcher): Remove.
5630         (catchers): New global.
5631         (exceptions_state_mc_init): Simplify.
5632         (catcher_pop): Remove.
5633         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5634         (try_scope_depth, exception_try_scope_entry)
5635         (exception_try_scope_exit): Remove.
5636         (throw_exception_sjlj): Update.
5637         (exception_messages, exception_messages_size): Remove.
5638         (throw_it): Simplify.
5639         (gdb_exception_sliced_copy): Remove.
5640         (throw_exception_cxx): Update.
5641         * cli/cli-script.c (script_from_file): Update.
5642         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5643         Update.
5644         * ada-valprint.c (ada_val_print): Update.
5645         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5646         (create_excep_cond_exprs): Update.
5647
5648 2019-04-08  Tom Tromey  <tom@tromey.com>
5649
5650         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5651         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5652         (TRY, CATCH, END_CATCH): Remove some definitions.
5653         * common/common-exceptions.c: Don't use GDB_XCPT.
5654         (catcher_list_size): Remove.
5655         (throw_exception, throw_it): Simplify.
5656
5657 2019-04-05  Tom Tromey  <tom@tromey.com>
5658
5659         Revert the header-sorting patch.
5660         * ft32-tdep.c: Revert.
5661         * frv-tdep.c: Revert.
5662         * frv-linux-tdep.c: Revert.
5663         * frame.c: Revert.
5664         * frame-unwind.c: Revert.
5665         * frame-base.c: Revert.
5666         * fork-child.c: Revert.
5667         * findvar.c: Revert.
5668         * findcmd.c: Revert.
5669         * filesystem.c: Revert.
5670         * filename-seen-cache.h: Revert.
5671         * filename-seen-cache.c: Revert.
5672         * fbsd-tdep.c: Revert.
5673         * fbsd-nat.h: Revert.
5674         * fbsd-nat.c: Revert.
5675         * f-valprint.c: Revert.
5676         * f-typeprint.c: Revert.
5677         * f-lang.c: Revert.
5678         * extension.h: Revert.
5679         * extension.c: Revert.
5680         * extension-priv.h: Revert.
5681         * expprint.c: Revert.
5682         * exec.h: Revert.
5683         * exec.c: Revert.
5684         * exceptions.c: Revert.
5685         * event-top.c: Revert.
5686         * event-loop.c: Revert.
5687         * eval.c: Revert.
5688         * elfread.c: Revert.
5689         * dwarf2read.h: Revert.
5690         * dwarf2read.c: Revert.
5691         * dwarf2loc.c: Revert.
5692         * dwarf2expr.h: Revert.
5693         * dwarf2expr.c: Revert.
5694         * dwarf2-frame.c: Revert.
5695         * dwarf2-frame-tailcall.c: Revert.
5696         * dwarf-index-write.h: Revert.
5697         * dwarf-index-write.c: Revert.
5698         * dwarf-index-common.c: Revert.
5699         * dwarf-index-cache.h: Revert.
5700         * dwarf-index-cache.c: Revert.
5701         * dummy-frame.c: Revert.
5702         * dtrace-probe.c: Revert.
5703         * disasm.h: Revert.
5704         * disasm.c: Revert.
5705         * disasm-selftests.c: Revert.
5706         * dictionary.c: Revert.
5707         * dicos-tdep.c: Revert.
5708         * demangle.c: Revert.
5709         * dcache.h: Revert.
5710         * dcache.c: Revert.
5711         * darwin-nat.h: Revert.
5712         * darwin-nat.c: Revert.
5713         * darwin-nat-info.c: Revert.
5714         * d-valprint.c: Revert.
5715         * d-namespace.c: Revert.
5716         * d-lang.c: Revert.
5717         * ctf.c: Revert.
5718         * csky-tdep.c: Revert.
5719         * csky-linux-tdep.c: Revert.
5720         * cris-tdep.c: Revert.
5721         * cris-linux-tdep.c: Revert.
5722         * cp-valprint.c: Revert.
5723         * cp-support.c: Revert.
5724         * cp-namespace.c: Revert.
5725         * cp-abi.c: Revert.
5726         * corelow.c: Revert.
5727         * corefile.c: Revert.
5728         * continuations.c: Revert.
5729         * completer.h: Revert.
5730         * completer.c: Revert.
5731         * complaints.c: Revert.
5732         * coffread.c: Revert.
5733         * coff-pe-read.c: Revert.
5734         * cli-out.h: Revert.
5735         * cli-out.c: Revert.
5736         * charset.c: Revert.
5737         * c-varobj.c: Revert.
5738         * c-valprint.c: Revert.
5739         * c-typeprint.c: Revert.
5740         * c-lang.c: Revert.
5741         * buildsym.c: Revert.
5742         * buildsym-legacy.c: Revert.
5743         * build-id.h: Revert.
5744         * build-id.c: Revert.
5745         * btrace.c: Revert.
5746         * bsd-uthread.c: Revert.
5747         * breakpoint.h: Revert.
5748         * breakpoint.c: Revert.
5749         * break-catch-throw.c: Revert.
5750         * break-catch-syscall.c: Revert.
5751         * break-catch-sig.c: Revert.
5752         * blockframe.c: Revert.
5753         * block.c: Revert.
5754         * bfin-tdep.c: Revert.
5755         * bfin-linux-tdep.c: Revert.
5756         * bfd-target.c: Revert.
5757         * bcache.c: Revert.
5758         * ax-general.c: Revert.
5759         * ax-gdb.h: Revert.
5760         * ax-gdb.c: Revert.
5761         * avr-tdep.c: Revert.
5762         * auxv.c: Revert.
5763         * auto-load.c: Revert.
5764         * arm-wince-tdep.c: Revert.
5765         * arm-tdep.c: Revert.
5766         * arm-symbian-tdep.c: Revert.
5767         * arm-pikeos-tdep.c: Revert.
5768         * arm-obsd-tdep.c: Revert.
5769         * arm-nbsd-tdep.c: Revert.
5770         * arm-nbsd-nat.c: Revert.
5771         * arm-linux-tdep.c: Revert.
5772         * arm-linux-nat.c: Revert.
5773         * arm-fbsd-tdep.c: Revert.
5774         * arm-fbsd-nat.c: Revert.
5775         * arm-bsd-tdep.c: Revert.
5776         * arch-utils.c: Revert.
5777         * arc-tdep.c: Revert.
5778         * arc-newlib-tdep.c: Revert.
5779         * annotate.h: Revert.
5780         * annotate.c: Revert.
5781         * amd64-windows-tdep.c: Revert.
5782         * amd64-windows-nat.c: Revert.
5783         * amd64-tdep.c: Revert.
5784         * amd64-sol2-tdep.c: Revert.
5785         * amd64-obsd-tdep.c: Revert.
5786         * amd64-obsd-nat.c: Revert.
5787         * amd64-nbsd-tdep.c: Revert.
5788         * amd64-nbsd-nat.c: Revert.
5789         * amd64-nat.c: Revert.
5790         * amd64-linux-tdep.c: Revert.
5791         * amd64-linux-nat.c: Revert.
5792         * amd64-fbsd-tdep.c: Revert.
5793         * amd64-fbsd-nat.c: Revert.
5794         * amd64-dicos-tdep.c: Revert.
5795         * amd64-darwin-tdep.c: Revert.
5796         * amd64-bsd-nat.c: Revert.
5797         * alpha-tdep.c: Revert.
5798         * alpha-obsd-tdep.c: Revert.
5799         * alpha-nbsd-tdep.c: Revert.
5800         * alpha-mdebug-tdep.c: Revert.
5801         * alpha-linux-tdep.c: Revert.
5802         * alpha-linux-nat.c: Revert.
5803         * alpha-bsd-tdep.c: Revert.
5804         * alpha-bsd-nat.c: Revert.
5805         * aix-thread.c: Revert.
5806         * agent.c: Revert.
5807         * addrmap.c: Revert.
5808         * ada-varobj.c: Revert.
5809         * ada-valprint.c: Revert.
5810         * ada-typeprint.c: Revert.
5811         * ada-tasks.c: Revert.
5812         * ada-lang.c: Revert.
5813         * aarch64-tdep.c: Revert.
5814         * aarch64-ravenscar-thread.c: Revert.
5815         * aarch64-newlib-tdep.c: Revert.
5816         * aarch64-linux-tdep.c: Revert.
5817         * aarch64-linux-nat.c: Revert.
5818         * aarch64-fbsd-tdep.c: Revert.
5819         * aarch64-fbsd-nat.c: Revert.
5820         * aarch32-linux-nat.c: Revert.
5821
5822 2019-04-05  Tom Tromey  <tom@tromey.com>
5823
5824         * ft32-tdep.c: Sort headers.
5825         * frv-tdep.c: Sort headers.
5826         * frv-linux-tdep.c: Sort headers.
5827         * frame.c: Sort headers.
5828         * frame-unwind.c: Sort headers.
5829         * frame-base.c: Sort headers.
5830         * fork-child.c: Sort headers.
5831         * findvar.c: Sort headers.
5832         * findcmd.c: Sort headers.
5833         * filesystem.c: Sort headers.
5834         * filename-seen-cache.h: Sort headers.
5835         * filename-seen-cache.c: Sort headers.
5836         * fbsd-tdep.c: Sort headers.
5837         * fbsd-nat.h: Sort headers.
5838         * fbsd-nat.c: Sort headers.
5839         * f-valprint.c: Sort headers.
5840         * f-typeprint.c: Sort headers.
5841         * f-lang.c: Sort headers.
5842         * extension.h: Sort headers.
5843         * extension.c: Sort headers.
5844         * extension-priv.h: Sort headers.
5845         * expprint.c: Sort headers.
5846         * exec.h: Sort headers.
5847         * exec.c: Sort headers.
5848         * exceptions.c: Sort headers.
5849         * event-top.c: Sort headers.
5850         * event-loop.c: Sort headers.
5851         * eval.c: Sort headers.
5852         * elfread.c: Sort headers.
5853         * dwarf2read.h: Sort headers.
5854         * dwarf2read.c: Sort headers.
5855         * dwarf2loc.c: Sort headers.
5856         * dwarf2expr.h: Sort headers.
5857         * dwarf2expr.c: Sort headers.
5858         * dwarf2-frame.c: Sort headers.
5859         * dwarf2-frame-tailcall.c: Sort headers.
5860         * dwarf-index-write.h: Sort headers.
5861         * dwarf-index-write.c: Sort headers.
5862         * dwarf-index-common.c: Sort headers.
5863         * dwarf-index-cache.h: Sort headers.
5864         * dwarf-index-cache.c: Sort headers.
5865         * dummy-frame.c: Sort headers.
5866         * dtrace-probe.c: Sort headers.
5867         * disasm.h: Sort headers.
5868         * disasm.c: Sort headers.
5869         * disasm-selftests.c: Sort headers.
5870         * dictionary.c: Sort headers.
5871         * dicos-tdep.c: Sort headers.
5872         * demangle.c: Sort headers.
5873         * dcache.h: Sort headers.
5874         * dcache.c: Sort headers.
5875         * darwin-nat.h: Sort headers.
5876         * darwin-nat.c: Sort headers.
5877         * darwin-nat-info.c: Sort headers.
5878         * d-valprint.c: Sort headers.
5879         * d-namespace.c: Sort headers.
5880         * d-lang.c: Sort headers.
5881         * ctf.c: Sort headers.
5882         * csky-tdep.c: Sort headers.
5883         * csky-linux-tdep.c: Sort headers.
5884         * cris-tdep.c: Sort headers.
5885         * cris-linux-tdep.c: Sort headers.
5886         * cp-valprint.c: Sort headers.
5887         * cp-support.c: Sort headers.
5888         * cp-namespace.c: Sort headers.
5889         * cp-abi.c: Sort headers.
5890         * corelow.c: Sort headers.
5891         * corefile.c: Sort headers.
5892         * continuations.c: Sort headers.
5893         * completer.h: Sort headers.
5894         * completer.c: Sort headers.
5895         * complaints.c: Sort headers.
5896         * coffread.c: Sort headers.
5897         * coff-pe-read.c: Sort headers.
5898         * cli-out.h: Sort headers.
5899         * cli-out.c: Sort headers.
5900         * charset.c: Sort headers.
5901         * c-varobj.c: Sort headers.
5902         * c-valprint.c: Sort headers.
5903         * c-typeprint.c: Sort headers.
5904         * c-lang.c: Sort headers.
5905         * buildsym.c: Sort headers.
5906         * buildsym-legacy.c: Sort headers.
5907         * build-id.h: Sort headers.
5908         * build-id.c: Sort headers.
5909         * btrace.c: Sort headers.
5910         * bsd-uthread.c: Sort headers.
5911         * breakpoint.h: Sort headers.
5912         * breakpoint.c: Sort headers.
5913         * break-catch-throw.c: Sort headers.
5914         * break-catch-syscall.c: Sort headers.
5915         * break-catch-sig.c: Sort headers.
5916         * blockframe.c: Sort headers.
5917         * block.c: Sort headers.
5918         * bfin-tdep.c: Sort headers.
5919         * bfin-linux-tdep.c: Sort headers.
5920         * bfd-target.c: Sort headers.
5921         * bcache.c: Sort headers.
5922         * ax-general.c: Sort headers.
5923         * ax-gdb.h: Sort headers.
5924         * ax-gdb.c: Sort headers.
5925         * avr-tdep.c: Sort headers.
5926         * auxv.c: Sort headers.
5927         * auto-load.c: Sort headers.
5928         * arm-wince-tdep.c: Sort headers.
5929         * arm-tdep.c: Sort headers.
5930         * arm-symbian-tdep.c: Sort headers.
5931         * arm-pikeos-tdep.c: Sort headers.
5932         * arm-obsd-tdep.c: Sort headers.
5933         * arm-nbsd-tdep.c: Sort headers.
5934         * arm-nbsd-nat.c: Sort headers.
5935         * arm-linux-tdep.c: Sort headers.
5936         * arm-linux-nat.c: Sort headers.
5937         * arm-fbsd-tdep.c: Sort headers.
5938         * arm-fbsd-nat.c: Sort headers.
5939         * arm-bsd-tdep.c: Sort headers.
5940         * arch-utils.c: Sort headers.
5941         * arc-tdep.c: Sort headers.
5942         * arc-newlib-tdep.c: Sort headers.
5943         * annotate.h: Sort headers.
5944         * annotate.c: Sort headers.
5945         * amd64-windows-tdep.c: Sort headers.
5946         * amd64-windows-nat.c: Sort headers.
5947         * amd64-tdep.c: Sort headers.
5948         * amd64-sol2-tdep.c: Sort headers.
5949         * amd64-obsd-tdep.c: Sort headers.
5950         * amd64-obsd-nat.c: Sort headers.
5951         * amd64-nbsd-tdep.c: Sort headers.
5952         * amd64-nbsd-nat.c: Sort headers.
5953         * amd64-nat.c: Sort headers.
5954         * amd64-linux-tdep.c: Sort headers.
5955         * amd64-linux-nat.c: Sort headers.
5956         * amd64-fbsd-tdep.c: Sort headers.
5957         * amd64-fbsd-nat.c: Sort headers.
5958         * amd64-dicos-tdep.c: Sort headers.
5959         * amd64-darwin-tdep.c: Sort headers.
5960         * amd64-bsd-nat.c: Sort headers.
5961         * alpha-tdep.c: Sort headers.
5962         * alpha-obsd-tdep.c: Sort headers.
5963         * alpha-nbsd-tdep.c: Sort headers.
5964         * alpha-mdebug-tdep.c: Sort headers.
5965         * alpha-linux-tdep.c: Sort headers.
5966         * alpha-linux-nat.c: Sort headers.
5967         * alpha-bsd-tdep.c: Sort headers.
5968         * alpha-bsd-nat.c: Sort headers.
5969         * aix-thread.c: Sort headers.
5970         * agent.c: Sort headers.
5971         * addrmap.c: Sort headers.
5972         * ada-varobj.c: Sort headers.
5973         * ada-valprint.c: Sort headers.
5974         * ada-typeprint.c: Sort headers.
5975         * ada-tasks.c: Sort headers.
5976         * ada-lang.c: Sort headers.
5977         * aarch64-tdep.c: Sort headers.
5978         * aarch64-ravenscar-thread.c: Sort headers.
5979         * aarch64-newlib-tdep.c: Sort headers.
5980         * aarch64-linux-tdep.c: Sort headers.
5981         * aarch64-linux-nat.c: Sort headers.
5982         * aarch64-fbsd-tdep.c: Sort headers.
5983         * aarch64-fbsd-nat.c: Sort headers.
5984         * aarch32-linux-nat.c: Sort headers.
5985
5986 2019-04-04  Tom Tromey  <tom@tromey.com>
5987
5988         * varobj.c (varobj_create): Update.
5989         * rust-exp.y (struct rust_parser) <update_innermost_block,
5990         lookup_symbol>: New methods.
5991         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5992         Rename.
5993         (rust_parser::rust_lookup_type)
5994         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5995         * printcmd.c (display_command, do_one_display): Update.
5996         * parser-defs.h (struct parser_state) <parser_state>: Add
5997         "tracker" parameter.
5998         (block_tracker): New member.
5999         (class innermost_block_tracker) <innermost_block_tracker>: Add
6000         "types" parameter.
6001         <reset>: Remove method.
6002         (innermost_block): Don't declare.
6003         (null_post_parser): Update.
6004         * parse.c (innermost_block): Remove global.
6005         (write_dollar_variable): Update.
6006         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6007         Remove "tracker_types" parameter.
6008         (parse_expression): Add "tracker" parameter.
6009         (parse_expression_for_completion): Update.
6010         (null_post_parser): Add "tracker" parameter.
6011         * p-exp.y: Update rules.
6012         * m2-exp.y: Update rules.
6013         * language.h (struct language_defn) <la_post_parser>: Add
6014         "tracker" parameter.
6015         * go-exp.y: Update rules.
6016         * f-exp.y: Update rules.
6017         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6018         parameter.
6019         * d-exp.y: Update rules.
6020         * c-exp.y: Update rules.
6021         * breakpoint.c (set_breakpoint_condition): Create an
6022         innermost_block_tracker.
6023         (watch_command_1): Likewise.
6024         * ada-lang.c (resolve): Add "tracker" parameter.
6025         (resolve_subexp): Likewise.
6026         * ada-exp.y (write_var_from_sym): Update.
6027
6028 2019-04-04  Tom Tromey  <tom@tromey.com>
6029
6030         * type-stack.h: New file.
6031         * type-stack.c: New file.
6032         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6033         type-stack.h.
6034         (insert_into_type_stack, insert_type, push_type, push_type_int)
6035         (insert_type_address_space, pop_type, pop_type_int)
6036         (pop_typelist, pop_type_stack, append_type_stack)
6037         (push_type_stack, get_type_stack, push_typelist)
6038         (follow_type_instance_flags, follow_types): Don't declare.
6039         * parse.c (type_stack): Remove global.
6040         (parse_exp_in_context): Update.
6041         (insert_into_type_stack, insert_type, push_type, push_type_int)
6042         (insert_type_address_space, pop_type, pop_type_int)
6043         (pop_typelist, pop_type_stack, append_type_stack)
6044         (push_type_stack, get_type_stack, push_typelist)
6045         (follow_type_instance_flags, follow_types): Remove (moved to
6046         type-stack.c).
6047         * f-exp.y (type_stack): New global.
6048         Update rules.
6049         (push_kind_type, f_parse): Update.
6050         * d-exp.y (type_stack): New global.
6051         Update rules.
6052         (d_parse): Update.
6053         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6054         Update rules.
6055         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6056         (HFILES_NO_SRCDIR): Add type-stack.h.
6057
6058 2019-04-04  Tom Tromey  <tom@tromey.com>
6059
6060         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6061         (rust_parser::convert_ast_to_expression, rust_parse)
6062         (rust_lex_test_completion, rust_lex_tests): Update.
6063         * parser-defs.h (struct expr_completion_state): New.
6064         (struct parser_state) <parser_state>: Add completion parameter.
6065         <mark_struct_expression, mark_completion_tag>: New methods.
6066         <parse_completion, m_completion_state>: New members.
6067         (prefixify_expression, null_post_parser): Update.
6068         (mark_struct_expression, mark_completion_tag): Don't declare.
6069         * parse.c (parse_completion, expout_last_struct)
6070         (expout_tag_completion_type, expout_completion_name): Remove
6071         globals.
6072         (parser_state::mark_struct_expression)
6073         (parser_state::mark_completion_tag): Now methods.
6074         (prefixify_expression): Add last_struct parameter.
6075         (prefixify_subexp): Likewise.
6076         (parse_exp_1): Update.
6077         (parse_exp_in_context): Add cstate parameter.  Update.
6078         (parse_expression_for_completion): Create an
6079         expr_completion_state.
6080         (null_post_parser): Add "completion" parameter.
6081         * p-exp.y: Update rules.
6082         (yylex): Update.
6083         * language.h (struct language_defn) <la_post_parser>: Add
6084         "completing" parameter.
6085         * go-exp.y: Update rules.
6086         (lex_one_token): Update.
6087         * expression.h (parse_completion): Don't declare.
6088         * d-exp.y: Update rules.
6089         (lex_one_token): Update rules.
6090         * c-exp.y: Update rules.
6091         (lex_one_token): Update.
6092         * ada-lang.c (resolve): Add "parse_completion" parameter.
6093         (resolve_subexp): Likewise.
6094         (ada_resolve_function): Likewise.
6095
6096 2019-04-04  Tom Tromey  <tom@tromey.com>
6097
6098         * parser-defs.h (struct parser_state) <start_arglist,
6099         end_arglist>: New methods.
6100         <arglist_len, m_funcall_chain>: New members.
6101         (arglist_len, start_arglist, end_arglist): Don't declare.
6102         * parse.c (arglist_len, funcall_chain): Remove global.
6103         (start_arglist, end_arglist): Remove functions.
6104         (parse_exp_in_context): Update.
6105         * p-exp.y: Update rules.
6106         * m2-exp.y: Update rules.
6107         * go-exp.y: Update rules.
6108         * f-exp.y: Update rules.
6109         * d-exp.y: Update rules.
6110         * c-exp.y: Update rules.
6111
6112 2019-04-04  Tom Tromey  <tom@tromey.com>
6113
6114         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6115         lex_operator, push_back>: New methods.
6116         Update all rules.
6117         (rust_parser::lex_hex, lex_escape): Rename and update.
6118         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6119         (rust_parser::lex_operator): Rename and update.
6120         (rust_parser::lex_number, rustyylex, rustyyerror)
6121         (rust_lex_test_init, rust_lex_test_sequence)
6122         (rust_lex_test_push_back, rust_lex_tests): Update.
6123         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6124         parameter.
6125         <lexptr, prev_lexptr>: New members.
6126         (lexptr, prev_lexptr): Don't declare.
6127         * parse.c (lexptr, prev_lexptr): Remove globals.
6128         (parse_exp_in_context): Update.
6129         * p-exp.y (yylex, yyerror): Update.
6130         * m2-exp.y (parse_number, yylex, yyerror): Update.
6131         * go-exp.y (lex_one_token, yyerror): Update.
6132         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6133         * d-exp.y (lex_one_token, yyerror): Update.
6134         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6135         (lex_one_token, yyerror): Update.
6136         * ada-lex.l (YY_INPUT): Update.
6137         (rewind_to_char): Update.
6138         * ada-exp.y (yyerror): Update.
6139
6140 2019-04-04  Tom Tromey  <tom@tromey.com>
6141
6142         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6143         * parser-defs.h (struct parser_state) <parser_state>: Add new
6144         parameter.
6145         <comma_terminates>: New member.
6146         (comma_terminates): Don't declare global.
6147         * parse.c (comma_terminates): Remove global.
6148         (parse_exp_in_context): Update.
6149         * p-exp.y (yylex): Update.
6150         * m2-exp.y (yylex): Update.
6151         * go-exp.y (lex_one_token): Update.
6152         * f-exp.y (yylex): Update.
6153         * d-exp.y (lex_one_token): Update.
6154         * c-exp.y (lex_one_token): Update.
6155         * ada-lex.l: Update.
6156
6157 2019-04-04  Tom Tromey  <tom@tromey.com>
6158
6159         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6160         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6161         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6162         * parser-defs.h (paren_depth): Don't declare.
6163         * parse.c (paren_depth): Remove global.
6164         (parse_exp_in_context): Update.
6165         * p-exp.y (paren_depth): New global.
6166         (pascal_parse): Initialize it.
6167         * m2-exp.y (paren_depth): New global.
6168         (m2_parse): Initialize it.
6169         * go-exp.y (paren_depth): New global.
6170         (go_parse): Initialize it.
6171         * f-exp.y (paren_depth): New global.
6172         (f_parse): Initialize it.
6173         * d-exp.y (paren_depth): New global.
6174         (d_parse): Initialize it.
6175         * c-exp.y (paren_depth): New global.
6176         (c_parse): Initialize it.
6177         * ada-lex.l (paren_depth): New global.
6178         (lexer_init): Initialize it.
6179
6180 2019-04-04  Tom Tromey  <tom@tromey.com>
6181
6182         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6183         (rust_parser::convert_ast_to_type)
6184         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6185         * parser-defs.h (struct parser_state) <parser_state>: Add
6186         parameters.  Initialize new members.
6187         <expression_context_block, expression_context_pc>: New members.
6188         * parse.c (expression_context_block, expression_context_pc):
6189         Remove globals.
6190         (parse_exp_in_context): Update.
6191         * p-exp.y: Update all rules.
6192         (yylex): Update.
6193         * m2-exp.y: Update all rules.
6194         (yylex): Update.
6195         * go-exp.y (yylex): Update.
6196         * f-exp.y (yylex): Update.
6197         * d-exp.y: Update all rules.
6198         (yylex): Update.
6199         * c-exp.y: Update all rules.
6200         (lex_one_token, classify_name, yylex, c_parse): Update.
6201         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6202
6203 2019-04-04  Tom Tromey  <tom@tromey.com>
6204
6205         * gdbarch.h, gdbarch.c: Rebuild.
6206         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6207         * stap-probe.h:
6208         (struct stap_parse_info): Replace "parser_state" with
6209         "expr_builder".
6210         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6211         (parser_state): New class.
6212         * parse.c (expr_builder): Rename.
6213         (expr_builder::release): Rename.
6214         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6215         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6216         (write_exp_elt_longcst, write_exp_elt_floatcst)
6217         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6218         (write_exp_string_vector, write_exp_bitstring)
6219         (write_exp_msymbol, mark_struct_expression)
6220         (write_dollar_variable)
6221         (insert_type_address_space, increase_expout_size): Replace
6222         "parser_state" with "expr_builder".
6223         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6224         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6225         "parser_state" with "expr_builder".
6226
6227 2019-04-04  Tom Tromey  <tom@tromey.com>
6228
6229         * rust-exp.y: Replace "parse_language" with method call.
6230         * p-exp.y:
6231         (yylex): Replace "parse_language" with method call.
6232         * m2-exp.y:
6233         (yylex): Replace "parse_language" with method call.
6234         * go-exp.y (classify_name): Replace "parse_language" with method
6235         call.
6236         * f-exp.y (yylex): Replace "parse_language" with method call.
6237         * d-exp.y (lex_one_token): Replace "parse_language" with method
6238         call.
6239         * c-exp.y:
6240         (lex_one_token, classify_name, yylex): Replace "parse_language"
6241         with method call.
6242         * ada-exp.y (find_primitive_type, type_char)
6243         (type_system_address): Replace "parse_language" with method call.
6244
6245 2019-04-04  Tom Tromey  <tom@tromey.com>
6246
6247         * rust-exp.y: Replace "parse_gdbarch" with method call.
6248         * parse.c (write_dollar_variable, insert_type_address_space):
6249         Replace "parse_gdbarch" with method call.
6250         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6251         call.
6252         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6253         call.
6254         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6255         "parse_gdbarch" with method call.
6256         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6257         with method call.
6258         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6259         "parse_gdbarch" with method call.
6260         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6261         "parse_gdbarch" with method call.
6262         * c-exp.y (parse_type, parse_number, classify_name): Replace
6263         "parse_gdbarch" with method call.
6264         * ada-lex.l: Replace "parse_gdbarch" with method call.
6265         * ada-exp.y (parse_type, find_primitive_type, type_char)
6266         (type_system_address): Replace "parse_gdbarch" with method call.
6267
6268 2019-04-04  Tom Tromey  <tom@tromey.com>
6269
6270         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6271         * stap-probe.c (stap_parse_argument): Update.
6272         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6273         initial_size parameter.
6274         * rust-exp.y (rust_lex_tests): Update.
6275         * parse.c (parser_state): Update.
6276         (parse_exp_in_context): Update.
6277         * parser-defs.h (struct parser_state) <parser_state>: Remove
6278         "initial_size" parameter.
6279
6280 2019-04-04  Tom Tromey  <tom@tromey.com>
6281
6282         * parser-defs.h (increase_expout_size): Don't declare.
6283         * parse.c (increase_expout_size): Now static.
6284
6285 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6286
6287         * gnu-nat.c (gnu_nat_target::wait): Fix
6288         target_waitstatus_to_string call.
6289
6290 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6291
6292         * eval.c (evaluate_subexp_standard): Handle internal functions
6293         during Fortran function call handling.
6294
6295 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6296
6297         * NEWS: Mention new internal functions.
6298         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6299         (read_base_type): Use dwarf2_init_complex_target_type.
6300         * value.c (creal_internal_fn): New function.
6301         (cimag_internal_fn): New function.
6302         (_initialize_values): Register new internal functions.
6303
6304 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6305
6306         * infrun.c (stop_all_threads): If debug_infrun, always
6307         trace the wait status after wait_one, using
6308         target_waitstatus_to_string and target_pid_to_str.
6309         (handle_inferior_event): Replace various trace of
6310         wait status kind by a single trace.
6311         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6312         wait status kind image by target_waitstatus_to_string.
6313         * target/waitstatus.c (target_waitstatus_to_string): Fix
6314         obsolete comment.
6315
6316 2019-04-01  Tom Tromey  <tromey@adacore.com>
6317
6318         PR symtab/23331:
6319         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6320
6321 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6322             Pedro Alves  <palves@redhat.com>
6323
6324         * top.c (quit_force): Call 'finalize_values'.
6325         * value.c (finalize_values): New function.
6326         * value.h (finalize_values): Declare.
6327
6328 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6329
6330         * NEWS: Announce $_gdb_major and $_gdb_minor.
6331
6332         * top.c (init_gdb_version_vars): New function.
6333         (gdb_init): Call init_gdb_version_vars.
6334
6335 2019-03-29  Tom Tromey  <tromey@adacore.com>
6336
6337         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6338         help text.  Remove dead code.
6339
6340 2019-03-29  Keith Seitz  <keiths@redhat.com>
6341
6342         From Siddhesh Poyarekar:
6343         * f-lang.h (f77_get_upperbound): Return LONGEST.
6344         (f77_get_lowerbound): Likewise.
6345         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6346         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6347         print them.
6348         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6349         plongest to format print it.
6350         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6351         (f77_get_upperbound): Likewise.
6352         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6353         LOWER_BOUND to LONGEST.
6354         (f77_create_arrayprint_offset_tbl): Likewise.
6355
6356 2019-03-29  Keith Seitz  <keiths@redhat.com>
6357
6358         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6359         %s/pulongest for TYPE_LENGTH instead of %d in format
6360         strings.
6361         * ada-typerint.c (ada_print_type): Likewise.
6362         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6363         * compile/compile-c-support.c (generate_register_struct): Likewise.
6364         * gdbtypes.c (recursive_dump_type): Likewise.
6365         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6366         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6367         instead of %d in format strings.
6368         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6369         to std::min to ULONGEST.
6370         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6371         instead of %d in format strings.
6372         * tracepoint.c (info_scope_command): Likewise.
6373         * typeprint.c (print_offset_data::update)
6374         (print_offset_data::finish): Likewise.
6375         * xtensa-tdep.c (xtensa_store_return_value)
6376         (xtensa_push_dummy_call): Likewise.
6377
6378 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6379
6380         * windows-nat.c (display_selector): Fixed format specifications
6381         for 64-bit Cygwin.
6382
6383 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6384
6385         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6386
6387 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6388
6389         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6390         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6391         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6392         (nios2_linux_init_abi): Install it.
6393
6394 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6395
6396         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6397
6398 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6399
6400         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6401
6402 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6403             Tom Tromey  <tromey@adacore.com>
6404
6405         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6406
6407 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6408
6409         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6410         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6411         method to compute the bounds of range types. Also print "[evaluated]"
6412         if the bounds' values come from a dynamic evaluation.
6413
6414 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6415
6416         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6417         whitespace when pretty printing is on.
6418
6419 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6420
6421         * ppc-linux-nat.c: Add include.
6422
6423 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6424
6425         * NEWS: Mention AArch64 Pointer Authentication.
6426
6427 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6428
6429         * arm-linux-nat.c: Add include.
6430
6431 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6432
6433         * source-cache.c (source_cache::get_source_lines): Re-read
6434         fullname after calling open_source_file.
6435
6436 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6437
6438         * NEWS: Mention TLS support for FreeBSD.
6439
6440 2019-03-25  Tom Tromey  <tromey@adacore.com>
6441
6442         * minsyms.c (BUNCH_SIZE): Update comment.
6443         (~minimal_symbol_reader): Remove old comment.
6444         (compact_minimal_symbols): Update comment.
6445         (minimal_symbol_reader::install): Remove old comment.  Update
6446         other comments.
6447
6448 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6449
6450         * s390-linux-nat.c: Add include.
6451
6452 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6453
6454         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6455         Call linux_get_hwcap.
6456         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6457         Likewise.
6458         (aarch64_linux_get_hwcap): Remove function.
6459         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6460         declaration.
6461         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6462         linux_get_hwcap.
6463         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6464         * linux-tdep.c (linux_get_hwcap): Add function.
6465         (linux_get_hwcap2): Likewise.
6466         * linux-tdep.h (linux_get_hwcap): Add declaration.
6467         (linux_get_hwcap2): Likewise.
6468         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6469         (ppc_linux_get_hwcap2): Likewise.
6470         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6471         linux_get_hwcap.
6472         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6473         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6474         (ppc_linux_nat_target::read_description): Likewise.
6475         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6476         * s390-linux-nat.c: Likewise.
6477         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6478
6479 2019-03-24  Tom Tromey  <tom@tromey.com>
6480
6481         * ada-lang.c (standard_lookup): Simplify initialization.
6482         (ada_lookup_symbol_nonlocal): Simplify return.
6483         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6484         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6485         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6486         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6487         initialization.
6488         * solib.c (solib_global_lookup): Simplify.
6489         * symtab.c (null_block_symbol): Remove.
6490         (symbol_cache_lookup): Simplify returns.
6491         (lookup_language_this): Simplify returns.
6492         (lookup_symbol_aux): Simplify return.
6493         (lookup_local_symbol): Simplify returns.
6494         (lookup_global_symbol_from_objfile): Simplify return.
6495         (lookup_symbol_in_objfile_symtabs)
6496         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6497         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6498         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6499         * cp-namespace.c (cp_lookup_bare_symbol)
6500         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6501         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6502         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6503         (cp_lookup_symbol_via_imports): Simplify initialization.
6504         (find_symbol_in_baseclass): Likewise.
6505         * symtab.h (null_block_symbol): Remove.
6506         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6507         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6508         (d_lookup_symbol_module): Likewise.
6509         (find_symbol_in_baseclass): Simplify initialization.
6510
6511 2019-03-24  Tom Tromey  <tom@tromey.com>
6512
6513         * expression.h: Don't include symtab.h.
6514         (struct block): Forward declare.
6515
6516 2019-03-24  Tom Tromey  <tom@tromey.com>
6517
6518         * c-exp.y (typebase): Remove casts.
6519         * gdbtypes.c (lookup_unsigned_typename, )
6520         (lookup_signed_typename): Remove cast.
6521         * eval.c (parse_to_comma_and_eval): Remove cast.
6522         * parse.c (write_dollar_variable): Remove cast.
6523         * block.h (struct block) <superblock>: Now const.
6524         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6525         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6526         (map_block): Make "block" const.
6527         * symfile.h (struct quick_symbol_functions)
6528         <map_matching_symbols>: Constify block argument to "callback".
6529         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6530         const.
6531         (find_pc_sect_compunit_symtab): Make "b" const.
6532         (find_symbol_at_address): Likewise.
6533         (search_symbols): Likewise.
6534         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6535         (dw2_debug_names_lookup_symbol): Likewise.
6536         (dw2_map_matching_symbols): Update.
6537         * p-valprint.c (pascal_val_print): Remove "block".
6538         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6539         (aux_add_nonlocal_symbols): Make "block" const.
6540         (resolve_subexp): Remove cast.
6541         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6542         const.
6543         (iterate_over_file_blocks): Likewise.
6544         * f-exp.y (%union) <bval>: Remove.
6545         * coffread.c (patch_opaque_types): Make "b" const.
6546         * spu-tdep.c (spu_catch_start): Make "block" const.
6547         * c-valprint.c (print_unpacked_pointer): Remove "block".
6548         * symmisc.c (dump_symtab_1): Make "b" const.
6549         (block_depth): Make "block" const.
6550         * d-exp.y (%union) <bval>: Remove.
6551         * cp-support.h (cp_lookup_rtti_type): Update.
6552         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6553         * psymtab.c (psym_lookup_symbol): Make "block" const.
6554         (maintenance_check_psymtabs): Make "b" const.
6555         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6556         (enumerate_locals, enumerate_args): Update.
6557         * python/py-symtab.c (stpy_global_block): Make "block" const.
6558         (stpy_static_block): Likewise.
6559         * inline-frame.c (block_starting_point_at): Make "new_block"
6560         const.
6561         * block.c (find_block_in_blockvector): Make return type const.
6562         (blockvector_for_pc_sect): Make "b" const.
6563         (find_block_in_blockvector): Make "b" const.
6564
6565 2019-03-23  Tom Tromey  <tom@tromey.com>
6566
6567         * varobj.c (varobj_create): Update.
6568         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6569         * printcmd.c (display_command, do_one_display): Don't reset
6570         innermost_block.
6571         * parser-defs.h (enum innermost_block_tracker_type): Move to
6572         expression.h.
6573         (innermost_block): Update comment.
6574         * parse.c (parse_exp_1): Add tracker_types parameter.
6575         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6576         tracker_types parameter.  Reset innermost_block.
6577         (parse_exp_in_context): Remove.
6578         (parse_expression_for_completion): Update.
6579         * objfiles.c (~objfile): Don't reset expression_context_block or
6580         innermost_block.
6581         * expression.h (enum innermost_block_tracker_type): Move from
6582         parser-defs.h.
6583         (parse_exp_1): Add tracker_types parameter.
6584         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6585         reset innermost_block.
6586
6587 2019-03-23  Tom Tromey  <tom@tromey.com>
6588
6589         * objfiles.h: Include bcache.h.
6590
6591 2019-03-23  Tom Tromey  <tom@tromey.com>
6592
6593         * linespec.c (get_current_search_block): Use
6594         scoped_restore_current_language.
6595         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6596
6597 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6598             Jiong Wang  <jiong.wang@arm.com>
6599
6600         * aarch64-linux-tdep.c
6601         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6602         section.
6603         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6604
6605 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6606             Jiong Wang  <jiong.wang@arm.com>
6607
6608         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6609         instructions.
6610         (aarch64_analyze_prologue_test): Add PACIASP test.
6611         (aarch64_prologue_prev_register): Unmask PC value.
6612
6613 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6614             Jiong Wang  <jiong.wang@arm.com>
6615
6616         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6617         (aarch64_dwarf2_prev_register): Unmask PC value.
6618         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6619         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6620         DW_CFA_AARCH64_negate_ra_state.
6621         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6622
6623 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6624             Jiong Wang  <jiong.wang@arm.com>
6625
6626         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6627         registers.
6628         (aarch64_pseudo_register_name): Likewise.
6629         (aarch64_pseudo_register_type): Likewise.
6630         (aarch64_pseudo_register_reggroup_p): Likewise.
6631         (aarch64_gdbarch_init): Add pauth registers.
6632         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6633         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6634         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6635         (struct gdbarch_tdep): Add regnum for ra_state.
6636
6637 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6638             Jiong Wang  <jiong.wang@arm.com>
6639
6640         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6641
6642 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6643             Jiong Wang  <jiong.wang@arm.com>
6644
6645         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6646         function.
6647         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6648         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6649         (aarch64_gdbarch_init): Add puth registers.
6650         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6651         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6652         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6653
6654 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6655             Jiong Wang  <jiong.wang@arm.com>
6656
6657         * aarch64-linux-nat.c
6658         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6659         * aarch64-linux-tdep.c
6660         (aarch64_linux_core_read_description): Likewise.
6661         (aarch64_linux_get_hwcap): New function.
6662         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6663         (aarch64_linux_get_hwcap): New declaration.
6664
6665 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6666             Jiong Wang  <jiong.wang@arm.com>
6667
6668         * aarch64-linux-nat.c
6669         (aarch64_linux_nat_target::read_description): Add pauth param.
6670         * aarch64-linux-tdep.c
6671         (aarch64_linux_core_read_description): Likewise.
6672         * aarch64-tdep.c (struct target_desc): Add in pauth.
6673         (aarch64_read_description): Add pauth param.
6674         (aarch64_gdbarch_init): Likewise.
6675         * aarch64-tdep.h (aarch64_read_description): Likewise.
6676         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6677         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6678         * features/Makefile: Add new files.
6679         * features/aarch64-pauth.c: New file.
6680         * features/aarch64-pauth.xml: New file.
6681
6682 2019-03-20  Tom Tromey  <tromey@adacore.com>
6683
6684         * infrun.c (handle_inferior_event): Rename from
6685         handle_inferior_event_1.  Create a scoped_value_mark.
6686         (handle_inferior_event): Remove.
6687
6688 2019-03-19  Tom Tromey  <tromey@adacore.com>
6689
6690         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6691         * infrun.h (print_stop_event): Add "displays" parameter.
6692         * infrun.c (print_stop_event): Add "displays" parameter.
6693
6694 2019-03-19  Pedro Alves  <palves@redhat.com>
6695
6696         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6697         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6698         to -1.  Fix TABs vs spaces.
6699         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6700         * tui/tui-out.h (tui_ui_out) Add intro comments.
6701         <m_line, m_start_of_line>: In-class initialize, and add describing
6702         comment.
6703
6704 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6705
6706         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6707         variable names.
6708         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6709
6710 2019-03-18  Pedro Alves  <palves@redhat.com>
6711             Eli Zaretskii <eliz@gnu.org>
6712
6713         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6714         m_line and m_start_of_line.
6715
6716 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6717
6718         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6719         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6720         it returns a newline.  This fixes a regression in TU mode, whereby
6721         the next line is output on the same screen line as the user input.
6722
6723 2019-03-18  Tom Tromey  <tromey@adacore.com>
6724
6725         * minsyms.c (minimal_symbol_reader::install): Remove call to
6726         obstack_blank.
6727
6728 2019-03-18  Pedro Alves  <palves@redhat.com>
6729
6730         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6731         New globals.
6732         (apply_style): New, factored out from ...
6733         (apply_ansi_escape): ... this.  Handle reverse video mode.
6734         (tui_set_reverse_mode): New function.
6735         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6736         * tui/tui-winsource.c (tui_show_source_line): Use
6737         tui_set_reverse_mode instead of setting A_STANDOUT.
6738         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6739         New setter methods.
6740
6741 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6742
6743         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6744         Handle tabs.
6745
6746 2019-03-18  Tom Tromey  <tromey@adacore.com>
6747
6748         * ada-lang.c (empty_array): Add "high" parameter.
6749         (ada_evaluate_subexp): Update.
6750
6751 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6752
6753         * unittests/string_view-selftests.c: Define
6754         _initialize_string_view_selftests unconditionally.
6755
6756 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6757
6758         PR gdb/24350
6759         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6760
6761 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6762
6763         PR gdb/24351
6764         * windows-nat.c (display_selector): Fix format specifiers.
6765
6766 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6767
6768         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6769         tui_refill_source_window instead of tui_refresh_win, to update the
6770         current execution line.  This fixes redisplay of the current line
6771         when stepping through the code with "next" or "step".
6772
6773 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6774
6775         * source-cache.c (source_cache::get_source_lines): Call
6776         find_source_lines to initialize s->nlines.  This fixes vertical
6777         scrolling of TUI source window when the DOWN arrow is pressed.
6778
6779 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6780
6781         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6782         linux-thread-db.c (_initialize_thread_db): Likewise.
6783
6784 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6785
6786         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6787         wclrtoeol in tui_show_source_line".  This reverts changes made in
6788         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6789
6790 2019-03-15  Tom Tromey  <tom@tromey.com>
6791
6792         * symtab.h (struct minimal_symbol): Derive from
6793         general_symbol_info.
6794         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6795         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6796         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6797         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6798         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6799         (MSYMBOL_SEARCH_NAME): Update.
6800         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6801         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6802         * minsyms.c (minimal_symbol_reader::record_full): Update.
6803
6804 2019-03-15  Tom Tromey  <tom@tromey.com>
6805
6806         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6807
6808 2019-03-15  Tom Tromey  <tom@tromey.com>
6809
6810         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6811         unique_xmalloc_ptr.
6812         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6813         Update.
6814         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6815         (build_minimal_symbol_hash_tables)
6816         (minimal_symbol_reader::install): Update.
6817
6818 2019-03-15  Tom Tromey  <tom@tromey.com>
6819
6820         * symtab.c (create_demangled_names_hash): Update.
6821         (symbol_set_names): Update.
6822         * objfiles.h (struct objfile_per_bfd_storage)
6823         <demangled_names_hash>: Now an htab_up.
6824         * objfiles.c (objfile_per_bfd_storage): Simplify.
6825
6826 2019-03-15  Tom Tromey  <tom@tromey.com>
6827
6828         * objfiles.h (struct objfile_per_bfd_storage): Declare
6829         destructor.
6830         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6831         New.
6832         (get_objfile_bfd_data): Use new.  Don't initialize
6833         language_of_main.
6834         (free_objfile_per_bfd_storage): Remove.
6835         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6836
6837 2019-03-15  Tom Tromey  <tom@tromey.com>
6838
6839         * symfile.c (reread_symbols): Update.
6840         * objfiles.c (objfile::objfile): Update.
6841         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6842         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6843         comment.
6844         (minimal_symbol_reader::install): Update.
6845         (terminate_minimal_symbol_table): Remove.
6846         * jit.c (jit_object_close_impl): Update.
6847
6848 2019-03-15  Tom Tromey  <tom@tromey.com>
6849
6850         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6851         initializations.
6852
6853 2019-03-15  Tom Tromey  <tom@tromey.com>
6854
6855         * objfiles.h (struct objfile_per_bfd_storage)
6856         <demangled_hash_languages>: Now a bitset.
6857         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6858         (lookup_minimal_symbol): Update.
6859
6860 2019-03-15  Tom Tromey  <tom@tromey.com>
6861
6862         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6863         Don't return the symbol.
6864         * coffread.c (record_minimal_symbol): Use record_full.
6865
6866 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6867
6868         The MS-Windows port of ncurses fails to switch to a color pair if
6869         one or both of the colors are the implicit default colors.  This
6870         change records the default colors when TUI is initialized, and
6871         then specifies them explicitly when a color pair uses the default
6872         colors.  This allows color styling in TUI mode on MS-Windows.
6873
6874         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6875         ncurses_norm_attr.
6876         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6877         colors in ncurses_norm_attr.
6878         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6879         "none", replace it with the default color recorded in
6880         ncurses_norm_attr.
6881
6882 2019-03-14  Tom Tromey  <tromey@adacore.com>
6883
6884         * source-cache.h (class source_cache) <get_source_lines>: Return
6885         std::string.
6886         * source-cache.c (source_cache::extract_lines): Handle case where
6887         first_pos==npos.  Return std::string.
6888         (source_cache::get_source_lines): Update.
6889
6890 2019-03-14  Tom Tromey  <tromey@adacore.com>
6891
6892         * NEWS: Add item for "style sources" commands.
6893         * source-cache.c (source_cache::get_source_lines): Check
6894         source_styling.
6895         * cli/cli-style.c (source_styling): New global.
6896         (_initialize_cli_style): Add "style sources" commands.
6897         (show_style_sources): New function.
6898         * cli/cli-style.h (source_styling): Declare.
6899
6900 2019-03-14  Pedro Alves  <palves@redhat.com>
6901             Tom Tromey  <tromey@adacore.com>
6902
6903         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6904         * tui/tui-winsource.c (tui_refill_source_window): New function,
6905         from...
6906         (tui_horizontal_source_scroll): ... here.  Move some logic.
6907         * cli/cli-style.c (set_style_enabled): Notify new observable.
6908         * tui/tui-hooks.c (tui_redisplay_source): New function.
6909         (tui_attach_detach_observers): Attach or detach
6910         tui_redisplay_source.
6911         * observable.h (source_styling_changed): New observable.
6912         * observable.c: Define source_styling_changed observable.
6913
6914 2019-03-13  Tom Tromey  <tromey@adacore.com>
6915
6916         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6917         (i386_gnu_nat_target::store_registers): Update.
6918         * target-debug.h (target_debug_print_std_string): New macro.
6919         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6920         * windows-tdep.c (display_one_tib): Update.
6921         * tui/tui-stack.c (tui_make_status_line): Update.
6922         * top.c (print_inferior_quit_action): Update.
6923         * thread.c (thr_try_catch_cmd): Update.
6924         (add_thread_with_info): Update.
6925         (thread_target_id_str): Update.
6926         (thr_try_catch_cmd): Update.
6927         (thread_command): Update.
6928         (thread_find_command): Update.
6929         * record-btrace.c (record_btrace_target::info_record)
6930         (record_btrace_resume_thread, record_btrace_target::resume)
6931         (record_btrace_cancel_resume, record_btrace_step_thread)
6932         (record_btrace_target::wait, record_btrace_target::wait)
6933         (record_btrace_target::wait, record_btrace_target::stop): Update.
6934         * progspace.c (print_program_space): Update.
6935         * process-stratum-target.c
6936         (process_stratum_target::thread_address_space): Update.
6937         * linux-fork.c (linux_fork_mourn_inferior)
6938         (detach_checkpoint_command, info_checkpoints_command)
6939         (linux_fork_context): Update.
6940         (linux_fork_detach): Update.
6941         (class scoped_switch_fork_info): Update.
6942         (delete_checkpoint_command): Update.
6943         * infrun.c (follow_fork_inferior): Update.
6944         (follow_fork_inferior): Update.
6945         (proceed_after_vfork_done): Update.
6946         (handle_vfork_child_exec_or_exit): Update.
6947         (follow_exec): Update.
6948         (displaced_step_prepare_throw): Update.
6949         (displaced_step_restore): Update.
6950         (start_step_over): Update.
6951         (resume_1): Update.
6952         (clear_proceed_status_thread): Update.
6953         (proceed): Update.
6954         (print_target_wait_results): Update.
6955         (do_target_wait): Update.
6956         (context_switch): Update.
6957         (stop_all_threads): Update.
6958         (restart_threads): Update.
6959         (finish_step_over): Update.
6960         (handle_signal_stop): Update.
6961         (switch_back_to_stepped_thread): Update.
6962         (keep_going_pass_signal): Update.
6963         (print_exited_reason): Update.
6964         (normal_stop): Update.
6965         * inferior.c (inferior_pid_to_str): Change return type.
6966         (print_selected_inferior): Update.
6967         (add_inferior): Update.
6968         (detach_inferior): Update.
6969         * dummy-frame.c (fprint_dummy_frames): Update.
6970         * dcache.c (dcache_info_1): Update.
6971         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6972         (btrace_fetch, btrace_clear): Update.
6973         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6974         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6975         type.
6976         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6977         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6978         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6979         * gdbarch.c, gdbarch.h: Rebuild.
6980         * gdbarch.sh (core_pid_to_str): Change return type.
6981         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6982         return type.
6983         (windows_nat_target::pid_to_str): Change return type.
6984         (windows_delete_thread): Update.
6985         (windows_nat_target::attach): Update.
6986         (windows_nat_target::files_info): Update.
6987         * target-delegates.c: Rebuild.
6988         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6989         return type.
6990         (sol_thread_target::pid_to_str): Change return type.
6991         * remote.c (class remote_target) <pid_to_str>: Change return
6992         type.
6993         (remote_target::pid_to_str): Change return type.
6994         (extended_remote_target::attach, remote_target::remote_stop_ns)
6995         (remote_target::remote_notif_remove_queued_reply)
6996         (remote_target::push_stop_reply, remote_target::disable_btrace):
6997         Update.
6998         (extended_remote_target::attach): Update.
6999         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7000         type.
7001         (gdbsim_target::pid_to_str): Change return type.
7002         * ravenscar-thread.c (struct ravenscar_thread_target)
7003         <pid_to_str>: Change return type.
7004         (ravenscar_thread_target::pid_to_str): Change return type.
7005         * procfs.c (class procfs_target) <pid_to_str>: Change return
7006         type.
7007         (procfs_target::pid_to_str): Change return type.
7008         (procfs_target::attach): Update.
7009         (procfs_target::detach): Update.
7010         (procfs_target::fetch_registers): Update.
7011         (procfs_target::store_registers): Update.
7012         (procfs_target::wait): Update.
7013         (procfs_target::files_info): Update.
7014         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7015         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7016         return type.
7017         (nto_procfs_target::pid_to_str): Change return type.
7018         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7019         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7020         return type.
7021         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7022         (exit_lwp): Update.
7023         (attach_proc_task_lwp_callback, get_detach_signal)
7024         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7025         (linux_nat_target::resume, wait_lwp, stop_callback)
7026         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7027         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7028         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7029         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7030         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7031         type.
7032         (inf_ptrace_target::attach): Update.
7033         (inf_ptrace_target::files_info): Update.
7034         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7035         type.
7036         (go32_nat_target::pid_to_str): Change return type.
7037         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7038         (gnu_nat_target::wait): Update.
7039         (gnu_nat_target::wait): Update.
7040         (gnu_nat_target::resume): Update.
7041         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7042         (fbsd_nat_target::wait): Update.
7043         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7044         type.
7045         (darwin_nat_target::attach): Update.
7046         * corelow.c (class core_target) <pid_to_str>: Change return type.
7047         (core_target::pid_to_str): Change return type.
7048         * target.c (normal_pid_to_str): Change return type.
7049         (default_pid_to_str): Likewise.
7050         (target_pid_to_str): Change return type.
7051         (target_translate_tls_address): Update.
7052         (target_announce_detach): Update.
7053         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7054         return type.
7055         (bsd_uthread_target::pid_to_str): Change return type.
7056         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7057         type.
7058         (bsd_kvm_target::pid_to_str): Change return type.
7059         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7060         return type.
7061         (aix_thread_target::pid_to_str): Change return type.
7062         * target.h (struct target_ops) <pid_to_str>: Change return type.
7063         (target_pid_to_str, normal_pid_to_str): Likewise.
7064         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7065         type.
7066         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7067         type.
7068         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7069         return type.
7070         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7071         type.
7072         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7073         type.
7074         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7075         return type.
7076
7077 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7078
7079         * NEWS: Mention that the new default MI version is 3.  Mention
7080         changes to the output of commands and events that deal with
7081         multi-location breakpoints.
7082         * breakpoint.c: Include "mi/mi-out.h".
7083         (print_one_breakpoint): Change output syntax if using MI version
7084         >= 3.
7085         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7086         New.
7087         (mi_multi_location_breakpoint_output_fixed): New.
7088         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7089         (mi_cmd_fix_multi_location_breakpoint_output): New.
7090         (mi_multi_location_breakpoint_output_fixed): New.
7091         * mi/mi-cmds.c (mi_cmds): Register command
7092         -fix-multi-location-breakpoint-output.
7093         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7094         interpreter "mi".
7095
7096 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7097
7098         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7099         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7100         instantiate mi_ui_out based on interpreter name.
7101         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7102         * mi/mi-main.c (mi_load_progress): Likewise.
7103
7104 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7105
7106         * NEWS: Combine separate "New targets" sections for 8.3.
7107
7108 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7109
7110         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7111         (ppcfbsd_init_abi): Install gdbarch
7112         "fetch_tls_load_module_address" and "get_thread_local_address"
7113         methods.
7114
7115 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7116
7117         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7118         (riscv_fbsd_init_abi): Install gdbarch
7119         "fetch_tls_load_module_address" and "get_thread_local_address"
7120         methods.
7121
7122 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7123
7124         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7125         (i386fbsd_init_abi): Install gdbarch
7126         "fetch_tls_load_module_address" and "get_thread_local_address"
7127         methods.
7128
7129 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7130
7131         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7132         (amd64fbsd_init_abi): Install gdbarch
7133         "fetch_tls_load_module_address" and "get_thread_local_address"
7134         methods.
7135
7136 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7137
7138         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7139         (struct fbsd_pspace_data): New type.
7140         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7141         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7142         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7143         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7144         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7145
7146 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7147
7148         * gdbtypes.c (lookup_struct_elt): New function.
7149         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7150         * gdbtypes.h (struct struct_elt): New type.
7151         (lookup_struct_elt): New prototype.
7152
7153 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7154
7155         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7156         remove disabled code block.
7157
7158 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7159
7160         * gdbarch.sh (get_thread_local_address): New method.
7161         * gdbarch.h, gdbarch.c: Regenerate.
7162         * target.c (target_translate_tls_address): Use
7163         gdbarch_get_thread_local_address if present instead of
7164         target::get_thread_local_address.
7165
7166 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7167
7168         * target.h (target::get_thread_local_address): Update comment.
7169
7170 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7171
7172         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7173         objfile->separate_debug_objfile_backlink if not NULL.
7174
7175 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7176
7177         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7178         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7179         (amd64bsd_store_inferior_registers): Likewise.
7180         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7181         Enable segment base registers.
7182         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7183         PT_GETFSBASE and PT_GETGSBASE.
7184         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7185         PT_SETGSBASE.
7186         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7187         segment base registers.
7188         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7189
7190 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7191
7192         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7193         Update calls to i386_target_description to add 'segments'
7194         parameter.
7195         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7196         add segment base registers.
7197         * arch/i386.c (i386_create_target_description): Add 'segments'
7198         parameter to enable segment base registers.
7199         * arch/i386.h (i386_create_target_description): Likewise.
7200         * features/i386/32bit-segments.xml: New file.
7201         * features/i386/32bit-segments.c: Generate.
7202         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7203         call to i386_target_description to add 'segments' parameter.
7204         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7205         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7206         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7207         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7208         if feature is present.
7209         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7210         Add 'segments' parameter to call to i386_target_description.
7211         (i386_target_description): Add 'segments' parameter to enable
7212         segment base registers.
7213         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7214         to call to i386_target_description.
7215         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7216         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7217         Define I386_NUM_REGS.
7218         (i386_target_description): Add 'segments' parameter to enable
7219         segment base registers.
7220
7221 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7222
7223         PR/24325
7224         * source-cache.c: #undef open and close, to avoid unresolved
7225         externals during linking.
7226
7227 2019-03-12  Tom Tromey  <tromey@adacore.com>
7228
7229         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7230         const.  Add initializers.
7231         (_initialize_remote): Don't initialize ptid globals.
7232
7233 2019-03-12  Pedro Alves  <palves@redhat.com>
7234
7235         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7236
7237 2019-03-12  Pedro Alves  <palves@redhat.com>
7238
7239         * cp-name-parser.y (main): Remove unused 'len' variable.
7240
7241 2019-03-12  Tom Tromey  <tromey@adacore.com>
7242
7243         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7244         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7245
7246 2019-03-12  Tom Tromey  <tromey@adacore.com>
7247
7248         * linux-nat.c (iterate_over_lwps): Update.
7249         (stop_callback): Remove parameter.
7250         (stop_wait_callback, detach_callback, resume_set_callback)
7251         (select_singlestep_lwp_callback, set_ignore_sigint)
7252         (status_callback, resumed_callback, resume_clear_callback)
7253         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7254         data parameter.
7255         (linux_nat_target::detach, linux_nat_target::resume)
7256         (linux_stop_and_wait_all_lwps, select_event_lwp)
7257         (linux_nat_filter_event, linux_nat_wait_1)
7258         (linux_nat_target::kill, linux_nat_target::stop)
7259         (linux_nat_target::stop): Update.
7260         (linux_nat_resume_callback): Change type.
7261         (resume_stopped_resumed_lwps, count_events_callback)
7262         (select_event_lwp_callback): Likewise.
7263         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7264         * arm-linux-nat.c (struct update_registers_data): Remove.
7265         (update_registers_callback): Change type.
7266         (arm_linux_insert_hw_breakpoint1): Update.
7267         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7268         parameter.
7269         (x86_linux_dr_set_addr): Update.
7270         (x86_linux_dr_set_control): Update.
7271         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7272         (iterate_over_lwps): Use gdb::function_view.
7273         * nat/aarch64-linux-hw-point.c (struct
7274         aarch64_dr_update_callback_param): Remove.
7275         (debug_reg_change_callback): Change type.
7276         (aarch64_notify_debug_reg_change): Update.
7277         * s390-linux-nat.c (s390_refresh_per_info): Update.
7278
7279 2019-03-11  Tom Tromey  <tromey@adacore.com>
7280
7281         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7282         redundant assignment to "this_cu".
7283
7284 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7285
7286         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7287
7288 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7289
7290         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7291         from...
7292         (rank_one_type): ... this.
7293
7294 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7295
7296         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7297         from...
7298         (rank_one_type): ... this.
7299
7300 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7301
7302         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7303         from...
7304         (rank_one_type): ... this.
7305
7306 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7307
7308         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7309         from...
7310         (rank_one_type): ... this.
7311
7312 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7313
7314         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7315         from...
7316         (rank_one_type): ... this.
7317
7318 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7319
7320         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7321         from...
7322         (rank_one_type): ... this.
7323
7324 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7325
7326         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7327         from...
7328         (rank_one_type): ... this.
7329
7330 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7331
7332         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7333         from...
7334         (rank_one_type): ... this.
7335
7336 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7337
7338         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7339         from...
7340         (rank_one_type): ... this.
7341
7342 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7343
7344         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7345         from...
7346         (rank_one_type): ... this.
7347
7348 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7349
7350         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7351         from...
7352         (rank_one_type): ... this.
7353
7354 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7355
7356         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7357         from...
7358         (rank_one_type): ... this.
7359
7360 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7361
7362         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7363         inferior-events' shows the example events.
7364
7365 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7366
7367         Support styling on native MS-Windows console
7368
7369         PR/24315
7370         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7371         on MS-Windows if $TERM is not defined.
7372
7373         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7374
7375         * posix-hdep.c (gdb_console_fputs):
7376         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7377         functions.
7378         * ui-file.h (gdb_console_fputs): Add prototype.
7379
7380         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7381         back to fputs only if the former returns zero.
7382
7383 2019-03-07  Tom Tromey  <tom@tromey.com>
7384
7385         * symmisc.c (print_symbol_bcache_statistics): Update.
7386         (print_objfile_statistics): Update.
7387         * symfile.c (allocate_symtab): Update.
7388         * stabsread.c: Don't include bcache.h.
7389         * psymtab.h (struct psymbol_bcache): Don't declare.
7390         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7391         (psymbol_bcache_init, psymbol_bcache_free)
7392         (psymbol_bcache_get_bcache): Don't declare.
7393         * psymtab.c (struct psymbol_bcache): Remove.
7394         (psymtab_storage::psymtab_storage): Update.
7395         (psymtab_storage::~psymtab_storage): Update.
7396         (psymbol_bcache_init, psymbol_bcache_free)
7397         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7398         (add_psymbol_to_bcache): Update.
7399         (allocate_psymtab): Update.
7400         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7401         macro_cache>: No longer pointers.
7402         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7403         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7404         * macrotab.c (macro_bcache): Update.
7405         * macroexp.c: Don't include bcache.h.
7406         * gdbtypes.c (check_types_worklist): Update.
7407         (types_deeply_equal): Remove TRY/CATCH.  Update.
7408         * elfread.c (elf_symtab_read): Update.
7409         * dwarf2read.c: Don't include bcache.h.
7410         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7411         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7412         (print_bcache_statistics, bcache_memory_used): Don't declare.
7413         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7414         methods.  Rename all data members.
7415         * bcache.c (struct bcache): Move to bcache.h.
7416         (bcache::expand_hash_table): Rename from expand_hash_table.
7417         (bcache): Remove.
7418         (bcache::insert): Rename from bcache_full.
7419         (bcache::compare): Rename from bcache_compare.
7420         (bcache_xmalloc): Remove.
7421         (bcache::~bcache): Rename from bcache_xfree.
7422         (bcache::print_statistics): Rename from print_bcache_statistics.
7423         (bcache::memory_used): Rename from bcache_memory_used.
7424
7425 2019-03-07  Pedro Alves  <palves@redhat.com>
7426
7427         * infrun.c (normal_stop): Also check for
7428         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7429
7430 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7431
7432         * f-lang.c (value_from_host_double): Moved to...
7433         * value.c (value_from_host_double): ...here.
7434         * value.h (value_from_host_double): Declare.
7435         * guile/scm-math.c (vlscm_convert_typed_number): Use
7436         value_from_host_double.
7437         (vlscm_convert_number): Likewise.
7438         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7439         * python/py-value.c (convert_value_from_python): Likewise.
7440
7441 2019-03-06  Tom Tromey  <tom@tromey.com>
7442
7443         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7444
7445 2019-03-06  Tom Tromey  <tom@tromey.com>
7446
7447         * utils.h (free_current_contents): Don't declare.
7448         * utils.c (free_current_contents): Remove.
7449
7450 2019-03-06  Tom Tromey  <tom@tromey.com>
7451
7452         * top.c (quit_force): Update.
7453         * main.c (captured_command_loop): Update.
7454         * common/new-op.c (operator new): Update.
7455         * common/common-exceptions.c (struct catcher)
7456         <save_cleanup_chain>: Remove member.
7457         (exceptions_state_mc_init): Update.
7458         (exception_try_scope_entry): Return nullptr.
7459         (exception_try_scope_exit, exception_rethrow)
7460         (throw_exception_sjlj, throw_exception_cxx): Update.
7461         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7462         (all_cleanups, do_cleanups, discard_cleanups)
7463         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7464         (restore_cleanups, restore_final_cleanups): Don't declare.
7465         (do_final_cleanups): Remove parameter.
7466         * common/cleanups.c (cleanup_chain, make_cleanup)
7467         (make_cleanup_dtor, all_cleanups, do_cleanups)
7468         (discard_my_cleanups, discard_cleanups)
7469         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7470         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7471         (null_cleanup): Remove.
7472         (do_final_cleanups): Remove parameter.
7473
7474 2019-03-06  Tom Tromey  <tom@tromey.com>
7475
7476         * remote.c (remote_target::remote_parse_stop_reply): Use
7477         unique_xmalloc_ptr.
7478
7479 2019-03-06  Tom Tromey  <tom@tromey.com>
7480
7481         * stabsread.c (struct stabs_field_info): Rename from field_info.
7482         <list, fnlist>: Add initializers.
7483         <obstack>: New member.
7484         (read_member_functions, read_struct_fields, read_baseclasses):
7485         Allocate on obstack.  Don't use cleanups.
7486         (read_one_struct_field, read_member_functions, read_struct_fields)
7487         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7488         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7489         (read_struct_type): Update.
7490
7491 2019-03-06  Tom Tromey  <tom@tromey.com>
7492
7493         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7494         * common/filestuff.h (make_cleanup_close): Don't declare.
7495         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7496         Remove.
7497
7498 2019-03-06  Tom Tromey  <tom@tromey.com>
7499
7500         * solib-aix.c: Use make_scope_exit.
7501
7502 2019-03-06  Tom Tromey  <tom@tromey.com>
7503
7504         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7505         Use make_scope_exit.
7506
7507 2019-03-06  Tom Tromey  <tom@tromey.com>
7508
7509         * solib-svr4.c (disable_probes_interface): Remove parameter.
7510         (svr4_handle_solib_event): Use make_scope_exit.
7511
7512 2019-03-06  Tom Tromey  <tom@tromey.com>
7513
7514         * remote.c (struct stop_reply_deleter): Remove.
7515         (stop_reply_up): Update.
7516         (struct stop_reply): Derive from notif_event.  Don't typedef.
7517         <regcache>: Now a std::vector.
7518         (stop_reply_xfree): Remove.
7519         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7520         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7521         (remote_target::discard_pending_stop_replies): Use delete.
7522         (remote_target::remote_parse_stop_reply): Update.
7523         (remote_target::process_stop_reply): Update.
7524         * remote-notif.h (struct notif_event): Add virtual destructor.
7525         Remove "dtr" member.
7526         (struct notif_client) <alloc_event>: Return a unique_ptr.
7527         (notif_event_xfree): Don't declare.
7528         (notif_event_up): New typedef.
7529         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7530         (notif_event_xfree, do_notif_event_xfree): Remove.
7531         (remote_notif_state_xfree): Update.
7532
7533 2019-03-06  Tom Tromey  <tom@tromey.com>
7534
7535         * infrun.c (displaced_step_clear_cleanup): Now a
7536         forward_scope_exit type.
7537         (displaced_step_prepare_throw): Update.
7538         (displaced_step_fixup): Update.
7539
7540 2019-03-06  Tom Tromey  <tom@tromey.com>
7541
7542         * inferior.h (class inferior): Update comment.
7543         * gdbthread.h (class thread_info): Update comment.
7544
7545 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7546             Tom Tromey  <tom@tromey.com>
7547
7548         * stabsread.h (struct stab_section_list): Remove.
7549         (coffstab_build_psymtabs): Update.
7550         * dbxread.c (symbuf_sections): Now a std::vector.
7551         (sect_idx): New global.
7552         (fill_symbuf): Update.
7553         (coffstab_build_psymtabs): Change type of stabsects parameter.
7554         Update.
7555         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7556         std::vector.
7557         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7558         (coff_locate_sections): Update.
7559         (coff_symfile_read): Remove cleanups.  Update.
7560         (init_stringtab): Add storage parameter.
7561         (free_stringtab, free_stringtab_cleanup): Remove.
7562         (init_lineno): Add storage parameter.
7563         (free_linetab, free_linetab_cleanup): Remove.
7564
7565 2019-03-06  Pedro Alves  <palves@redhat.com>
7566
7567         * linux-fork.c (fork_info::clobber_regs): Delete.
7568         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7569         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7570         comment.  Adjust.
7571         (scoped_switch_fork_info::scoped_switch_fork_info)
7572         (checkpoint_command, linux_fork_context): Adjust
7573         fork_save_infrun_state calls.
7574
7575 2019-03-06  Pedro Alves  <palves@redhat.com>
7576
7577         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7578         (inf_has_multiple_threads): Return 'bool' and rewrite using
7579         inferior_info::threads().
7580
7581 2019-03-06  Pedro Alves  <palves@redhat.com>
7582
7583         * linux-fork.c: Include <list>.
7584         (fork_list): Now a std::list instance.
7585         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7586         (forks_exist_p, find_last_fork): Adjust.
7587         (new_fork): Delete.
7588         (one_fork_p): New.
7589         (add_fork): Adjust.
7590         (free_fork): Delete, folded into fork_info::~fork_info().
7591         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7592         Adjust.
7593         (init_fork_list): Delete.
7594         (linux_fork_killall, linux_fork_mourn_inferior)
7595         (linux_fork_detach, info_checkpoints_command): Adjust.
7596         (_initialize_linux_fork): No longer call init_fork_list.
7597
7598 2019-03-06  Pedro Alves  <palves@redhat.com>
7599
7600         * linux-fork.c (new_fork): New, split out of ...
7601         (add_fork): ... this.  Return void.  Move "first fork" special
7602         case from here, to ...
7603         (checkpoint_command): ... here.
7604         * linux-linux.h (add_fork): Return void.
7605
7606 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7607
7608         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7609
7610 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7611             Chris January  <chris.january@arm.com>
7612             David Lecomber  <david.lecomber@arm.com>
7613
7614         * f-exp.y: New token, UNOP_INTRINSIC.
7615         (exp): New pattern using UNOP_INTRINSIC token.
7616         (f77_keywords): Add 'abs' keyword.
7617         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7618         (value_from_host_double): New function.
7619         (evaluate_subexp_f): Support UNOP_ABS.
7620
7621 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7622
7623         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7624         types.
7625
7626 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7627
7628         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7629         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7630         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7631
7632 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7633
7634         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7635
7636 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7637             Chris January  <chris.january@arm.com>
7638
7639         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7640         * f-exp.y: Define 'KIND' token.
7641         (exp): New pattern for KIND expressions.
7642         (ptype): Handle types with a kind extension.
7643         (direct_abs_decl): Extend to spot kind extensions.
7644         (f77_keywords): Add 'kind' to the list.
7645         (push_kind_type): New function.
7646         (convert_to_kind_type): New function.
7647         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7648         * parse.c (operator_length_standard): Likewise.
7649         * parser-defs.h (enum type_pieces): Add tp_kind.
7650         * std-operator.def: Add UNOP_KIND.
7651
7652 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7653
7654         * f-exp.y (f_parse): Set yydebug.
7655
7656 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7657
7658         * f-lang.c (evaluate_subexp_f): New function.
7659         (exp_descriptor_f): New global.
7660         (f_language_defn): Use exp_descriptor_f instead of
7661         exp_descriptor_standard.
7662
7663 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7664
7665         * f-exp.y (struct token): Add comments.
7666         (dot_ops): Remove uppercase versions and the end marker.
7667         (f77_keywords): Likewise.
7668         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7669         entries in the dot_ops array are case insensitive, and use
7670         strncasecmp to compare strings.  Also some whitespace cleanup in
7671         this area.  Similar for the f77_keywords array, except entries in
7672         this list might be case sensitive.
7673
7674 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7675
7676         * f-exp.y (struct f77_boolean_val): Add comments.
7677         (boolean_values): Remove uppercase versions, and end marker.
7678         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7679         and use strncasecmp to achieve case insensitivity.  Additionally,
7680         perform whitespace cleanup around this code.
7681
7682 2019-03-06  Tom Tromey  <tromey@adacore.com>
7683
7684         * remote-sim.c (gdbsim_target_open): Use result of
7685         gdb_argv::release.
7686
7687 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7688         Dirk Schubert  <dirk.schubert@arm.com>
7689         Chris January  <chris.january@arm.com>
7690
7691         * eval.c (evaluate_subexp_standard): Call Fortran argument
7692         wrapping logic.
7693         * f-lang.c (struct value): A value which can be passed into a
7694         Fortran function call.
7695         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7696         where appropriate.
7697         (struct type): Value ready for a Fortran function call.
7698         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7699         is needed.
7700         * f-lang.h (fortran_argument_convert): Declaration.
7701         (fortran_preserve_arg_pointer): Declaration.
7702         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7703
7704 2019-03-05  Tom Tromey  <tromey@adacore.com>
7705
7706         * python/py-prettyprint.c (print_string_repr): Remove #if.
7707         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7708
7709 2019-03-05  Tom Tromey  <tromey@adacore.com>
7710
7711         * target.c (the_dummy_target): Move later.  Change type to
7712         "dummy_target".
7713         (initialize_targets): Don't initialize the_dummy_target.
7714
7715 2019-03-05  Tom Tromey  <tromey@adacore.com>
7716
7717         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7718         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7719
7720 2019-03-05  Tom Tromey  <tromey@adacore.com>
7721
7722         * windows-nat.c (windows_nat_target::attach)
7723         (windows_nat_target::detach): Don't call gdb_flush.
7724         * valprint.c (generic_val_print, val_print, val_print_string):
7725         Don't call gdb_flush.
7726         * utils.c (defaulted_query): Don't call gdb_flush.
7727         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7728         * target.c (target_announce_detach): Don't call gdb_flush.
7729         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7730         * remote.c (extended_remote_target::attach): Don't call
7731         gdb_flush.
7732         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7733         * printcmd.c (do_examine): Don't call gdb_flush.
7734         (info_display_command): Don't call gdb_flush.
7735         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7736         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7737         * memattr.c (info_mem_command): Don't call gdb_flush.
7738         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7739         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7740         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7741         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7742         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7743         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7744         (gnu_nat_target::detach): Don't call gdb_flush.
7745         * f-valprint.c (f_val_print): Don't call gdb_flush.
7746         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7747         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7748         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7749         gdb_flush.
7750         * c-valprint.c (c_val_print): Don't call gdb_flush.
7751         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7752
7753 2019-03-05  Tom Tromey  <tromey@adacore.com>
7754
7755         * varobj.c (update_dynamic_varobj_children): Update.
7756         (install_default_visualizer): Use reset, not release.
7757         * value.c (set_internalvar): Update.
7758         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7759         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7760         ATTRIBUTE_UNUSED_RESULT.
7761
7762 2019-03-05  Tom Tromey  <tromey@adacore.com>
7763
7764         * remote.c (class scoped_remote_fd) <release>: Add
7765         ATTRIBUTE_UNUSED_RESULT.
7766
7767 2019-03-05  Tom Tromey  <tromey@adacore.com>
7768
7769         * macroexp.c (struct macro_buffer) <release>: Add
7770         ATTRIBUTE_UNUSED_RESULT.
7771
7772 2019-03-05  Tom Tromey  <tromey@adacore.com>
7773
7774         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7775         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7776         ATTRIBUTE_UNUSED_RESULT.
7777
7778 2019-03-05  Tom Tromey  <tromey@adacore.com>
7779
7780         * common/scoped_fd.h (class scoped_fd) <release>: Add
7781         ATTRIBUTE_UNUSED_RESULT.
7782
7783 2019-03-05  Tom Tromey  <tromey@adacore.com>
7784
7785         * parser-defs.h (struct parser_state) <release>: Add
7786         ATTRIBUTE_UNUSED_RESULT.
7787
7788 2019-03-05  Tom Tromey  <tromey@adacore.com>
7789
7790         * utils.h (class gdb_argv) <release>: Add
7791         ATTRIBUTE_UNUSED_RESULT.
7792         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7793
7794 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7795
7796         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7797         for-loop range, to avoid compiler warnings.
7798
7799         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7800         avoid compiler warnings about unused variables.
7801
7802         * NEWS: Mention end of support for native debugging on MS-Windows
7803         before XP.
7804
7805         PR gdb/24292
7806         * common/netstuff.c:
7807         * gdbserver/gdbreplay.c
7808         * gdbserver/remote-utils.c:
7809         * ser-tcp.c:
7810         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7811         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7812         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7813         'getaddrinfo' and 'freeaddrinfo' were not available before
7814         Windows XP, and mingw.org's MinGW headers by default define
7815         _WIN32_WINNT to 0x500.
7816
7817 2019-03-01  Gary Benson <gbenson@redhat.com>
7818
7819         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7820
7821 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7822             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7823
7824         PR gdb/8527
7825         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7826         set_sigint_trap, clear_sigint_trap.
7827
7828 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7829
7830         * target.c (target_detach): Clear the regcache and the
7831         frame cache.
7832
7833 2019-02-27  Pedro Alves  <palves@redhat.com>
7834
7835         * utils.c (set_screen_size): When we cap the height/width sizes,
7836         tweak the corresponding command variable to show "unlimited":
7837
7838 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7839             Pedro Alves  <palves@redhat.com>
7840
7841         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7842         before calling rl_set_screen_size.
7843
7844 2019-02-27  Tom Tromey  <tromey@adacore.com>
7845
7846         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7847         define.
7848         * python/py-value.c: Remove Python 2.4 workaround.
7849         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7850         workaround.
7851         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7852         Python 2.4 workaround.
7853         * python/python-internal.h: Remove Python 2.4 comment.
7854         (Py_ssize_t): Don't define.
7855         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7856         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7857         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7858         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7859         * python/python.c (do_start_initialization): Remove Python 2.4
7860         workaround.
7861         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7862         (print_children): Remove Python 2.4 workaround.
7863         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7864         workaround.
7865         (CHARBUFFERPROC_NAME): Remove.
7866         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7867         Python 2.4 workaround.
7868
7869 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7870
7871         * NEWS: Note minimum Python version.
7872
7873 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7874
7875         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7876         code from these functions.  Remove corresponding ifdefs.  Use
7877         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7878         Remove gotos and target of gotos.
7879         (infpy_search_memory): Likewise.
7880
7881 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7882
7883         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7884         (hppa_gdbarch_init): Don't register deleted functions with
7885         gdbarch.
7886
7887 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7888
7889         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7890         (h8300_unwind_sp): Delete.
7891         (h8300_dummy_id): Delete.
7892         (h8300_gdbarch_init): Don't register deleted functions with
7893         gdbarch.
7894
7895 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7896
7897         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7898         (ft32_unwind_pc): Delete.
7899         (ft32_unwind_sp): Delete.
7900         (ft32_gdbarch_init): Don't register deleted functions with
7901         gdbarch.
7902
7903 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7904
7905         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7906         (frv_unwind_pc): Delete.
7907         (frv_unwind_sp): Delete.
7908         (frv_gdbarch_init): Don't register deleted functions with
7909         gdbarch.
7910
7911 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7912
7913         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7914         (riscv_unwind_pc): Delete.
7915         (riscv_unwind_sp): Delete.
7916         (riscv_gdbarch_init): Don't register deleted functions with
7917         gdbarch.
7918
7919 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7920
7921         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7922         (csky_unwind_pc): Delete.
7923         (csky_unwind_sp): Delete.
7924         (csky_gdbarch_init): Don't register deleted functions with
7925         gdbarch.
7926
7927 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7928
7929         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7930         (cris_unwind_pc): Delete.
7931         (cris_unwind_sp): Delete.
7932         (cris_gdbarch_init): Don't register deleted functions with
7933         gdbarch.
7934
7935 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7936
7937         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7938         (bfin_unwind_pc): Delete.
7939         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7940
7941 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7942
7943         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7944         (arm_unwind_pc): Delete.
7945         (arm_unwind_sp): Delete.
7946         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7947
7948 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7949
7950         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7951         (arc_unwind_pc): Delete.
7952         (arc_unwind_sp): Delete.
7953         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7954
7955 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7956
7957         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7958         (alpha_unwind_pc): Delete.
7959         (alpha_gdbarch_init): Don't register deleted functions with
7960         gdbarch.
7961
7962 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7963
7964         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7965         (aarch64_unwind_pc): Delete.
7966         (aarch64_unwind_sp): Delete.
7967         (aarch64_gdbarch_init): Don't register deleted functions with
7968         gdbarch.
7969
7970 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7971
7972         * gdbtypes.c (type_align): Don't consider static members when
7973         computing structure alignment.
7974
7975 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7976
7977         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7978         return 0 for other types.
7979         * arch-utils.c (default_type_align): Always return 0.
7980         * gdbarch.h: Regenerate.
7981         * gdbarch.sh (type_align): Extend comment.
7982         * gdbtypes.c (type_align): Add additional comments, always call
7983         gdbarch_type_align before applying the default rules.
7984         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7985         generic code will then apply a suitable default.
7986         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7987         types, return 0 for other types.
7988
7989 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7990
7991         * NEWS: Create a new section for the next release branch.
7992         Rename the section of the current branch, now that it has
7993         been cut.
7994
7995 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7996
7997         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7998         * version.in: Bump version to 8.3.50.DATE-git.
7999
8000 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8001
8002         * aix-thread.c (ptid_cmp): Remove unused variable.
8003         (get_signaled_thread): Likewise.
8004         (store_regs_user_thread): Likewise.
8005         (store_regs_kernel_thread): Likewise.
8006         (fetch_regs_kernel_thread): Remove shadowed variable.
8007
8008 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8009
8010         * features/riscv/32bit-cpu.xml: Add register numbers.
8011         * features/riscv/32bit-fpu.c: Regenerate.
8012         * features/riscv/32bit-fpu.xml: Add register numbers.
8013         * features/riscv/64bit-cpu.xml: Add register numbers.
8014         * features/riscv/64bit-fpu.c: Regenerate.
8015         * features/riscv/64bit-fpu.xml: Add register numbers.
8016
8017 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8018
8019         * NEWS: Mention two argument form of gdb.Value constructor.
8020         * python/py-value.c (convert_buffer_and_type_to_value): New
8021         function.
8022         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8023         Add support for handling an optional second argument.  Call
8024         convert_buffer_and_type_to_value as appropriate.
8025         * python/python-internal.h (Py_buffer_deleter): New struct.
8026         (Py_buffer_up): New typedef.
8027
8028 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8029
8030         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8031         instead of releasing ownership.
8032
8033 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8034
8035         * dwarf2read.c (open_and_init_dwp_file): Call
8036         elf_numsections instead of bfd_count_sections to initialize
8037         dwp_file->num_sections.
8038
8039 2019-02-25  Tom Tromey  <tromey@adacore.com>
8040
8041         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8042
8043 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8044
8045         * gcore.in: Add '--readnever' option when invoking GDB.
8046
8047 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8048
8049         * MAINTAINERS: Update my email address.
8050
8051 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8052
8053         * build-id.c (build_id_to_debug_bfd_1): New function.
8054         (build_id_to_debug_bfd): Look for separate debug file in
8055         sysroot.
8056
8057 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8058
8059         * gdbarch.sh: Update the copyright year range that is placed into
8060         generated files.
8061
8062 2019-02-22  Keith Seitz  <keiths@redhat.com>
8063
8064         PR symtab/23853
8065         * linespec.c (create_sals_line_offset): Search for the default
8066         symtab's filename instead of its fullname.
8067
8068 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8069
8070         * NEWS: Update style defaults.
8071
8072 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8073
8074         * main.c (captured_main_1): Disable styling in batch mode.
8075
8076 2019-02-20  Tom Tromey  <tom@tromey.com>
8077
8078         * symtab.c (symtab_symbol_info): Fix typos.
8079
8080 2019-02-20  Tom Tromey  <tromey@adacore.com>
8081
8082         * findcmd.c (_initialize_mem_search): Use upper case for
8083         metasyntactic variables.
8084
8085 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8086
8087         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8088         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8089
8090 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8091
8092         * top.h (source_file_name): Change to std::string.
8093         * top.c (source_file_name): Likewise.
8094         (command_line_input): Adjust.
8095         * cli/cli-script.c (script_from_file): Adjust.
8096
8097 2019-02-19  Tom Tromey  <tromey@adacore.com>
8098
8099         * ravenscar-thread.c
8100         (ravenscar_thread_target::update_thread_list): Don't call
8101         ada_build_task_list.
8102         * ada-lang.h (ada_build_task_list): Don't declare.
8103         * ada-tasks.c (struct ada_tasks_inferior_data)
8104         <task_list_valid_p>: Now bool.
8105         (read_known_tasks, ada_task_list_changed)
8106         (ada_tasks_invalidate_inferior_data): Update.
8107         (read_known_tasks_array): Return bool.
8108         (read_known_tasks_list): Likewise.
8109         (read_known_tasks): Return void.
8110         (ada_build_task_list): Now static.
8111
8112 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8113
8114         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8115         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8116
8117 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8118
8119         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8120         variant for ada_tasks_pspace_data_handle and
8121         ada_tasks_inferior_data_handle.
8122         (ada_tasks_pspace_data_cleanup): New function.
8123         (ada_tasks_inferior_data_cleanup): New function.
8124
8125 2019-02-17  Tom Tromey  <tom@tromey.com>
8126
8127         * macrotab.h (macro_source_fullname): Return a std::string.
8128         * macrotab.c (macro_include, check_for_redefinition)
8129         (macro_undef, macro_lookup_definition, foreach_macro)
8130         (foreach_macro_in_scope): Update.
8131         (macro_source_fullname): Return a std::string.
8132         * macrocmd.c (show_pp_source_pos): Update.
8133
8134 2019-02-17  Tom Tromey  <tom@tromey.com>
8135
8136         * macrocmd.c (show_pp_source_pos): Style the file names.
8137
8138 2019-02-17  Tom Tromey  <tom@tromey.com>
8139
8140         PR tui/24197:
8141         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8142
8143 2019-02-17  Tom Tromey  <tom@tromey.com>
8144
8145         * ada-lang.c (user_select_syms): Use filtered printing.
8146         * utils.c (wrap_style): New global.
8147         (desired_style): Remove.
8148         (emit_style_escape): Add stream parameter.
8149         (set_output_style, reset_terminal_style, prompt_for_continue):
8150         Update.
8151         (flush_wrap_buffer): Only flush gdb_stdout.
8152         (wrap_here): Set wrap_style.
8153         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8154         treat escape sequences as a character.  Change when wrap buffer is
8155         flushed.
8156         (fputs_styled): Do not set the output style when the default is
8157         requested.
8158         * ui-style.h (struct ui_file_style) <is_default>: New method.
8159         * source.c (print_source_lines_base): Emit escape sequences in one
8160         piece.
8161
8162 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8163
8164         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8165         integers and enumeration types.
8166
8167 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8168
8169         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8170         instead of lookup_symbol_in_language
8171         (do_exact_match): New function.
8172         (ada_get_symbol_name_matcher): Return do_exact_match when
8173         doing a verbatim match.
8174
8175 2019-02-15  Tom Tromey  <tromey@adacore.com>
8176
8177         * ravenscar-thread.c (ravenscar_thread_target::resume)
8178         (ravenscar_thread_target::wait): Special case wildcard requests.
8179
8180 2019-02-15  Tom Tromey  <tromey@adacore.com>
8181
8182         * ravenscar-thread.c (base_ptid): Remove.
8183         (struct ravenscar_thread_target) <close>: New method.
8184         <m_base_ptid>: New member.
8185         <update_inferior_ptid, active_task, task_is_currently_active,
8186         runtime_initialized>: Declare methods.
8187         <ravenscar_thread_target>: Add constructor.
8188         (ravenscar_thread_target::task_is_currently_active)
8189         (ravenscar_thread_target::update_inferior_ptid)
8190         (ravenscar_runtime_initialized): Rename.  Now methods.
8191         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8192         (ravenscar_thread_target::update_thread_list): Update.
8193         (ravenscar_thread_target::active_task): Now method.
8194         (ravenscar_thread_target::store_registers)
8195         (ravenscar_thread_target::prepare_to_store)
8196         (ravenscar_thread_target::prepare_to_store)
8197         (ravenscar_thread_target::mourn_inferior): Update.
8198         (ravenscar_inferior_created): Use "new" to create target.
8199         (ravenscar_thread_target::get_ada_task_ptid): Update.
8200         (_initialize_ravenscar): Don't initialize base_ptid.
8201         (ravenscar_ops): Remove global.
8202
8203 2019-02-15  Tom Tromey  <tromey@adacore.com>
8204
8205         * target.h (push_target): Declare new overload.
8206         * target.c (push_target): New overload, taking an rvalue reference.
8207         * remote.c (remote_target::open_1): Use push_target overload.
8208         * corelow.c (core_target_open): Use push_target overload.
8209
8210 2019-02-15  Tom Tromey  <tromey@adacore.com>
8211
8212         * ravenscar-thread.c (is_ravenscar_task)
8213         (ravenscar_task_is_currently_active): Return bool.
8214         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8215         (_initialize_ravenscar): Remove "(void)".
8216         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8217         Return bool.
8218
8219 2019-02-15  Tom Tromey  <tromey@adacore.com>
8220
8221         * ravenscar-thread.c (ravenscar_runtime_initializer)
8222         (has_ravenscar_runtime, get_running_thread_id)
8223         (ravenscar_thread_target::resume): Fix indentation.
8224
8225 2019-02-15  Tom Tromey  <tromey@adacore.com>
8226
8227         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8228         from ravenscar_arch_ops.
8229         (sparc_ravenscar_ops::fetch_registers)
8230         (sparc_ravenscar_ops::store_registers): Now methods.
8231         (sparc_ravenscar_prepare_to_store): Remove.
8232         (sparc_ravenscar_ops): Redefine.
8233         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8234         methods and destructor.  Remove members.
8235         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8236         (ravenscar_thread_target::store_registers)
8237         (ravenscar_thread_target::prepare_to_store): Update.
8238         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8239         Remove.
8240         (struct ppc_ravenscar_powerpc_ops): Derive from
8241         ravenscar_arch_ops.
8242         (ppc_ravenscar_powerpc_ops::fetch_registers)
8243         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8244         (ppc_ravenscar_powerpc_ops): Redefine.
8245         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8246         (ppc_ravenscar_e500_ops::fetch_registers)
8247         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8248         (ppc_ravenscar_e500_ops): Redefine.
8249         * aarch64-ravenscar-thread.c
8250         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8251         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8252         (aarch64_ravenscar_fetch_registers)
8253         (aarch64_ravenscar_store_registers): Now methods.
8254         (aarch64_ravenscar_ops): Redefine.
8255
8256 2019-02-15  Tom Tromey  <tromey@adacore.com>
8257
8258         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8259         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8260         (ravenscar_thread_target::stopped_by_watchpoint)
8261         (ravenscar_thread_target::stopped_data_address)
8262         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8263
8264 2019-02-15  Tom Tromey  <tromey@adacore.com>
8265
8266         * ravenscar-thread.c: Fix some typos.
8267
8268 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8269             Tom Tromey  <tromey@adacore.com>
8270
8271         * ada-lang.c (ada_exception_sal): Change addr_string to a
8272         std::string.
8273         (create_ada_exception_catchpoint): Update.
8274
8275 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8276             Tom Tromey  <tromey@adacore.com>
8277
8278         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8279         (bp_location_ops): Remove.
8280         (base_breakpoint_allocate_location): Update.
8281         (free_bp_location): Update.
8282         * ada-lang.c (class ada_catchpoint_location)
8283         <ada_catchpoint_location>: Remove ops parameter.
8284         (ada_catchpoint_location_dtor): Remove.
8285         (ada_catchpoint_location_ops): Remove.
8286         (allocate_location_exception): Update.
8287         * breakpoint.h (struct bp_location_ops): Remove.
8288         (class bp_location) <bp_location>: Remove bp_location_ops
8289         parameter.
8290         <~bp_location>: Add destructor.
8291         <ops>: Remove.
8292
8293 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8294             Pedro Alves  <palves@redhat.com>
8295
8296         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8297         'PATH_MAX'.
8298
8299 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8300             Samuel Thibault  <samuel.thibault@gnu.org>
8301             Thomas Schwinge  <thomas@codesourcery.com>
8302
8303         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8304         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8305
8306 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8307
8308         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8309         (check_empty): Use "const char *".
8310
8311         * gnu-nat.c (gnu_nat_target::detach): Instead of
8312         'detach_inferior (pid)' call
8313         'detach_inferior (find_inferior_pid (pid))'.
8314
8315         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8316         'nat/fork-inferior.o'.
8317         * gnu-nat.c: #include "nat/fork-inferior.h".
8318
8319         * gnu-nat.c (gnu_nat_target::detach): Instead of
8320         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8321         * gnu-nat.h: #include "inf-child.h".
8322         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8323         'i386_gnu_nat_target::fetch_registers'.
8324         (gnu_store_registers): Rename/move to
8325         'i386_gnu_nat_target::store_registers'.
8326
8327         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8328         * gnu-nat.h (mach_thread_info): New function.
8329         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8330
8331         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8332
8333 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8334
8335         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8336
8337 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8338
8339         * windows-nat.c (windows_add_thread): Add new parameter
8340         "main_thread_p" with default value set to false.  Update
8341         function documentation as well as all callers.
8342         (windows_delete_thread): Likewise.
8343         (fake_create_process): Update call to windows_add_thread.
8344         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8345         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8346         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8347         call to windows_delete_thread.
8348
8349 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8350
8351         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8352
8353 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8354
8355         * symfile.c (find_separate_debug_file): Use canonical path of
8356         sysroot with child_path instead of gdb_sysroot if it is valid.
8357
8358 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8359
8360         * symfile.c (find_separate_debug_file): Use child_path to
8361         determine if an object file is under a sysroot.
8362
8363 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8364
8365         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8366         unittests/child-path-selftests.c.
8367         * common/pathstuff.c (child_path): New function.
8368         * common/pathstuff.h (child_path): New prototype.
8369         * unittests/child-path-selftests.c: New file.
8370
8371 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8372
8373         * symfile.c (find_separate_debug_file): Look for separate debug
8374         files in debug directories under the sysroot.
8375
8376 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8377
8378         * symtab.h (struct minimal_symbol data_p): New const method.
8379         (struct minimal_symbol text_p): Likewise.
8380         * symtab.c (output_source_filename): Use file name style
8381         to print file name.
8382         (print_symbol_info): Likewise.
8383         (print_msymbol_info): Use address style to print addresses.
8384         Use function name style to print executable text symbols.
8385         (expand_symtab_containing_pc): Use data_p.
8386         (find_pc_sect_compunit_symtab): Likewise.
8387
8388 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8389
8390         * breakpoint.c (describe_other_breakpoints): Use address style
8391         to print addresses.
8392         (say_where): Likewise.
8393
8394 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8395
8396         * ada-typeprint.c (print_func_type): Print function name
8397         style to print function name.
8398         * c-typeprint.c (c_print_type_1): Likewise.
8399
8400 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8401
8402         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8403         for execve.
8404
8405 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8406
8407         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8408         type_stack.
8409
8410 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8411
8412         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8413         TYPE_CODE_REF types.
8414
8415 2019-02-08  Jim Wilson  <jimw@sifive.com>
8416
8417         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8418         (riscv_linux_fregset): New.
8419         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8420
8421 2019-02-07  Tom Tromey  <tom@tromey.com>
8422
8423         * thread.c (thread_cancel_execution_command): Update.
8424         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8425         methods.
8426         (struct thread_fsm_ops): Remove.
8427         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8428         (thread_fsm_should_stop, thread_fsm_return_value)
8429         (thread_fsm_set_finished, thread_fsm_finished_p)
8430         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8431         Don't declare.
8432         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8433         * infrun.c (clear_proceed_status_thread)
8434         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8435         (print_stop_event): Update.
8436         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8437         Add constructor.
8438         (step_command_fsm_ops): Remove.
8439         (new_step_command_fsm): Remove.
8440         (step_1): Update.
8441         (step_command_fsm::should_stop): Rename from
8442         step_command_fsm_should_stop.
8443         (step_command_fsm::clean_up): Rename from
8444         step_command_fsm_clean_up.
8445         (step_command_fsm::do_async_reply_reason): Rename from
8446         step_command_fsm_async_reply_reason.
8447         (struct until_next_fsm): Inherit from thread_fsm.  Add
8448         constructor.
8449         (until_next_fsm_ops): Remove.
8450         (new_until_next_fsm): Remove.
8451         (until_next_fsm::should_stop): Rename from
8452         until_next_fsm_should_stop.
8453         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8454         (until_next_fsm::do_async_reply_reason): Rename from
8455         until_next_fsm_async_reply_reason.
8456         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8457         constructor.  Change type of breakpoint.
8458         (finish_command_fsm_ops): Remove.
8459         (new_finish_command_fsm): Remove.
8460         (finish_command_fsm::should_stop): Rename from
8461         finish_command_fsm_should_stop.
8462         (finish_command_fsm::clean_up): Rename from
8463         finish_command_fsm_clean_up.
8464         (finish_command_fsm::return_value): Rename from
8465         finish_command_fsm_return_value.
8466         (finish_command_fsm::do_async_reply_reason): Rename from
8467         finish_command_fsm_async_reply_reason.
8468         (finish_command): Update.
8469         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8470         Add constructor.
8471         (call_thread_fsm_ops): Remove.
8472         (call_thread_fsm::call_thread_fsm): Rename from
8473         new_call_thread_fsm.
8474         (call_thread_fsm::should_stop): Rename from
8475         call_thread_fsm_should_stop.
8476         (call_thread_fsm::should_notify_stop): Rename from
8477         call_thread_fsm_should_notify_stop.
8478         (run_inferior_call, call_function_by_hand_dummy): Update.
8479         * cli/cli-interp.c (should_print_stop_to_console): Update.
8480         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8481         Add constructor.  Change type of location_breakpoint,
8482         caller_breakpoint.
8483         (until_break_fsm_ops): Remove.
8484         (new_until_break_fsm): Remove.
8485         (until_break_fsm::should_stop): Rename from
8486         until_break_fsm_should_stop.
8487         (until_break_fsm::clean_up): Rename from
8488         until_break_fsm_clean_up.
8489         (until_break_fsm::do_async_reply_reason): Rename from
8490         until_break_fsm_async_reply_reason.
8491         (until_break_command): Update.
8492         * thread-fsm.c: Remove.
8493         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8494
8495 2019-02-07  Tom Tromey  <tom@tromey.com>
8496
8497         * yy-remap.h: Add include guard.
8498         * xtensa-tdep.h: Add include guard.
8499         * xcoffread.h: Rename include guard.
8500         * varobj-iter.h: Add include guard.
8501         * tui/tui.h: Rename include guard.
8502         * tui/tui-winsource.h: Rename include guard.
8503         * tui/tui-wingeneral.h: Rename include guard.
8504         * tui/tui-windata.h: Rename include guard.
8505         * tui/tui-win.h: Rename include guard.
8506         * tui/tui-stack.h: Rename include guard.
8507         * tui/tui-source.h: Rename include guard.
8508         * tui/tui-regs.h: Rename include guard.
8509         * tui/tui-out.h: Rename include guard.
8510         * tui/tui-layout.h: Rename include guard.
8511         * tui/tui-io.h: Rename include guard.
8512         * tui/tui-hooks.h: Rename include guard.
8513         * tui/tui-file.h: Rename include guard.
8514         * tui/tui-disasm.h: Rename include guard.
8515         * tui/tui-data.h: Rename include guard.
8516         * tui/tui-command.h: Rename include guard.
8517         * tic6x-tdep.h: Add include guard.
8518         * target/waitstatus.h: Rename include guard.
8519         * target/wait.h: Rename include guard.
8520         * target/target.h: Rename include guard.
8521         * target/resume.h: Rename include guard.
8522         * target-float.h: Rename include guard.
8523         * stabsread.h: Add include guard.
8524         * rs6000-tdep.h: Add include guard.
8525         * riscv-fbsd-tdep.h: Add include guard.
8526         * regformats/regdef.h: Rename include guard.
8527         * record.h: Rename include guard.
8528         * python/python.h: Rename include guard.
8529         * python/python-internal.h: Rename include guard.
8530         * python/py-stopevent.h: Rename include guard.
8531         * python/py-ref.h: Rename include guard.
8532         * python/py-record.h: Rename include guard.
8533         * python/py-record-full.h: Rename include guard.
8534         * python/py-record-btrace.h: Rename include guard.
8535         * python/py-instruction.h: Rename include guard.
8536         * python/py-events.h: Rename include guard.
8537         * python/py-event.h: Rename include guard.
8538         * procfs.h: Add include guard.
8539         * proc-utils.h: Add include guard.
8540         * p-lang.h: Add include guard.
8541         * or1k-tdep.h: Rename include guard.
8542         * observable.h: Rename include guard.
8543         * nto-tdep.h: Rename include guard.
8544         * nat/x86-linux.h: Rename include guard.
8545         * nat/x86-linux-dregs.h: Rename include guard.
8546         * nat/x86-gcc-cpuid.h: Add include guard.
8547         * nat/x86-dregs.h: Rename include guard.
8548         * nat/x86-cpuid.h: Rename include guard.
8549         * nat/ppc-linux.h: Rename include guard.
8550         * nat/mips-linux-watch.h: Rename include guard.
8551         * nat/linux-waitpid.h: Rename include guard.
8552         * nat/linux-ptrace.h: Rename include guard.
8553         * nat/linux-procfs.h: Rename include guard.
8554         * nat/linux-osdata.h: Rename include guard.
8555         * nat/linux-nat.h: Rename include guard.
8556         * nat/linux-namespaces.h: Rename include guard.
8557         * nat/linux-btrace.h: Rename include guard.
8558         * nat/glibc_thread_db.h: Rename include guard.
8559         * nat/gdb_thread_db.h: Rename include guard.
8560         * nat/gdb_ptrace.h: Rename include guard.
8561         * nat/fork-inferior.h: Rename include guard.
8562         * nat/amd64-linux-siginfo.h: Rename include guard.
8563         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8564         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8565         * nat/aarch64-linux.h: Rename include guard.
8566         * nat/aarch64-linux-hw-point.h: Rename include guard.
8567         * mn10300-tdep.h: Add include guard.
8568         * mips-linux-tdep.h: Add include guard.
8569         * mi/mi-parse.h: Rename include guard.
8570         * mi/mi-out.h: Rename include guard.
8571         * mi/mi-main.h: Rename include guard.
8572         * mi/mi-interp.h: Rename include guard.
8573         * mi/mi-getopt.h: Rename include guard.
8574         * mi/mi-console.h: Rename include guard.
8575         * mi/mi-common.h: Rename include guard.
8576         * mi/mi-cmds.h: Rename include guard.
8577         * mi/mi-cmd-break.h: Rename include guard.
8578         * m2-lang.h: Add include guard.
8579         * location.h: Rename include guard.
8580         * linux-record.h: Rename include guard.
8581         * linux-nat.h: Add include guard.
8582         * linux-fork.h: Add include guard.
8583         * i386-darwin-tdep.h: Rename include guard.
8584         * hppa-linux-offsets.h: Add include guard.
8585         * guile/guile.h: Rename include guard.
8586         * guile/guile-internal.h: Rename include guard.
8587         * gnu-nat.h: Rename include guard.
8588         * gdb-stabs.h: Rename include guard.
8589         * frv-tdep.h: Add include guard.
8590         * f-lang.h: Add include guard.
8591         * event-loop.h: Add include guard.
8592         * darwin-nat.h: Rename include guard.
8593         * cp-abi.h: Rename include guard.
8594         * config/sparc/nm-sol2.h: Rename include guard.
8595         * config/nm-nto.h: Rename include guard.
8596         * config/nm-linux.h: Add include guard.
8597         * config/i386/nm-i386gnu.h: Rename include guard.
8598         * config/djgpp/nl_types.h: Rename include guard.
8599         * config/djgpp/langinfo.h: Rename include guard.
8600         * compile/gcc-cp-plugin.h: Add include guard.
8601         * compile/gcc-c-plugin.h: Add include guard.
8602         * compile/compile.h: Rename include guard.
8603         * compile/compile-object-run.h: Rename include guard.
8604         * compile/compile-object-load.h: Rename include guard.
8605         * compile/compile-internal.h: Rename include guard.
8606         * compile/compile-cplus.h: Rename include guard.
8607         * compile/compile-c.h: Rename include guard.
8608         * common/xml-utils.h: Rename include guard.
8609         * common/x86-xstate.h: Rename include guard.
8610         * common/version.h: Rename include guard.
8611         * common/vec.h: Rename include guard.
8612         * common/tdesc.h: Rename include guard.
8613         * common/selftest.h: Rename include guard.
8614         * common/scoped_restore.h: Rename include guard.
8615         * common/scoped_mmap.h: Rename include guard.
8616         * common/scoped_fd.h: Rename include guard.
8617         * common/safe-iterator.h: Rename include guard.
8618         * common/run-time-clock.h: Rename include guard.
8619         * common/refcounted-object.h: Rename include guard.
8620         * common/queue.h: Rename include guard.
8621         * common/ptid.h: Rename include guard.
8622         * common/print-utils.h: Rename include guard.
8623         * common/preprocessor.h: Rename include guard.
8624         * common/pathstuff.h: Rename include guard.
8625         * common/observable.h: Rename include guard.
8626         * common/netstuff.h: Rename include guard.
8627         * common/job-control.h: Rename include guard.
8628         * common/host-defs.h: Rename include guard.
8629         * common/gdb_wait.h: Rename include guard.
8630         * common/gdb_vecs.h: Rename include guard.
8631         * common/gdb_unlinker.h: Rename include guard.
8632         * common/gdb_unique_ptr.h: Rename include guard.
8633         * common/gdb_tilde_expand.h: Rename include guard.
8634         * common/gdb_sys_time.h: Rename include guard.
8635         * common/gdb_string_view.h: Rename include guard.
8636         * common/gdb_splay_tree.h: Rename include guard.
8637         * common/gdb_setjmp.h: Rename include guard.
8638         * common/gdb_ref_ptr.h: Rename include guard.
8639         * common/gdb_optional.h: Rename include guard.
8640         * common/gdb_locale.h: Rename include guard.
8641         * common/gdb_assert.h: Rename include guard.
8642         * common/filtered-iterator.h: Rename include guard.
8643         * common/filestuff.h: Rename include guard.
8644         * common/fileio.h: Rename include guard.
8645         * common/environ.h: Rename include guard.
8646         * common/common-utils.h: Rename include guard.
8647         * common/common-types.h: Rename include guard.
8648         * common/common-regcache.h: Rename include guard.
8649         * common/common-inferior.h: Rename include guard.
8650         * common/common-gdbthread.h: Rename include guard.
8651         * common/common-exceptions.h: Rename include guard.
8652         * common/common-defs.h: Rename include guard.
8653         * common/common-debug.h: Rename include guard.
8654         * common/cleanups.h: Rename include guard.
8655         * common/buffer.h: Rename include guard.
8656         * common/btrace-common.h: Rename include guard.
8657         * common/break-common.h: Rename include guard.
8658         * cli/cli-utils.h: Rename include guard.
8659         * cli/cli-style.h: Rename include guard.
8660         * cli/cli-setshow.h: Rename include guard.
8661         * cli/cli-script.h: Rename include guard.
8662         * cli/cli-interp.h: Rename include guard.
8663         * cli/cli-decode.h: Rename include guard.
8664         * cli/cli-cmds.h: Rename include guard.
8665         * charset-list.h: Add include guard.
8666         * buildsym-legacy.h: Rename include guard.
8667         * bfin-tdep.h: Add include guard.
8668         * ax.h: Rename include guard.
8669         * arm-linux-tdep.h: Add include guard.
8670         * arm-fbsd-tdep.h: Add include guard.
8671         * arch/xtensa.h: Rename include guard.
8672         * arch/tic6x.h: Add include guard.
8673         * arch/i386.h: Add include guard.
8674         * arch/arm.h: Rename include guard.
8675         * arch/arm-linux.h: Rename include guard.
8676         * arch/arm-get-next-pcs.h: Rename include guard.
8677         * arch/amd64.h: Add include guard.
8678         * arch/aarch64-insn.h: Rename include guard.
8679         * arch-utils.h: Rename include guard.
8680         * annotate.h: Add include guard.
8681         * amd64-darwin-tdep.h: Rename include guard.
8682         * aarch64-linux-tdep.h: Add include guard.
8683         * aarch64-fbsd-tdep.h: Add include guard.
8684         * aarch32-linux-nat.h: Add include guard.
8685
8686 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8687
8688         * macrotab.c (macro_define_internal): New function that
8689         factorizes macro_define_object_internal and macro_define_function
8690         code.
8691         (macro_define_object_internal): Use macro_define_internal.
8692         (macro_define_function): Likewise.
8693
8694 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8695
8696         * macrocmd.c (extract_identifier): Return
8697         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8698         callers.
8699
8700 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8701
8702         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8703
8704 2019-02-05  Tom Tromey  <tom@tromey.com>
8705
8706         * target.c (target_stack::unpush): Move assertion earlier.
8707
8708 2019-01-30  Tom Tromey  <tom@tromey.com>
8709
8710         PR python/23615:
8711         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8712         (gdbpy_parse_and_eval): Likewise.
8713         * python/python-internal.h (gdbpy_allow_threads): New class.
8714
8715 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8716
8717         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8718         (aarch64_fbsd_fpregmap): Move earlier.
8719         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8720         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8721         instead of individual calls to trad_frame_set_reg_addr.
8722         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8723         earlier.
8724         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8725         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8726         instead of individual calls to trad_frame_set_reg_addr.
8727
8728 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8729
8730         * CONTRIBUTE: Replace contribution list with wiki link.
8731
8732 2019-01-25  Tom Tromey  <tom@tromey.com>
8733
8734         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8735
8736 2019-01-25  Tom Tromey  <tom@tromey.com>
8737
8738         * xtensa-linux-nat.c: Fix common/ includes.
8739         * xml-support.h: Fix common/ includes.
8740         * xml-support.c: Fix common/ includes.
8741         * x86-linux-nat.c: Fix common/ includes.
8742         * windows-nat.c: Fix common/ includes.
8743         * varobj.h: Fix common/ includes.
8744         * varobj.c: Fix common/ includes.
8745         * value.c: Fix common/ includes.
8746         * valops.c: Fix common/ includes.
8747         * utils.c: Fix common/ includes.
8748         * unittests/xml-utils-selftests.c: Fix common/ includes.
8749         * unittests/utils-selftests.c: Fix common/ includes.
8750         * unittests/unpack-selftests.c: Fix common/ includes.
8751         * unittests/tracepoint-selftests.c: Fix common/ includes.
8752         * unittests/style-selftests.c: Fix common/ includes.
8753         * unittests/string_view-selftests.c: Fix common/ includes.
8754         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8755         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8756         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8757         * unittests/rsp-low-selftests.c: Fix common/ includes.
8758         * unittests/parse-connection-spec-selftests.c: Fix common/
8759         includes.
8760         * unittests/optional-selftests.c: Fix common/ includes.
8761         * unittests/offset-type-selftests.c: Fix common/ includes.
8762         * unittests/observable-selftests.c: Fix common/ includes.
8763         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8764         * unittests/memrange-selftests.c: Fix common/ includes.
8765         * unittests/memory-map-selftests.c: Fix common/ includes.
8766         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8767         * unittests/function-view-selftests.c: Fix common/ includes.
8768         * unittests/environ-selftests.c: Fix common/ includes.
8769         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8770         * unittests/common-utils-selftests.c: Fix common/ includes.
8771         * unittests/cli-utils-selftests.c: Fix common/ includes.
8772         * unittests/array-view-selftests.c: Fix common/ includes.
8773         * ui-file.c: Fix common/ includes.
8774         * tui/tui-io.c: Fix common/ includes.
8775         * tracepoint.h: Fix common/ includes.
8776         * tracepoint.c: Fix common/ includes.
8777         * tracefile-tfile.c: Fix common/ includes.
8778         * top.h: Fix common/ includes.
8779         * top.c: Fix common/ includes.
8780         * thread.c: Fix common/ includes.
8781         * target/waitstatus.h: Fix common/ includes.
8782         * target/waitstatus.c: Fix common/ includes.
8783         * target.h: Fix common/ includes.
8784         * target.c: Fix common/ includes.
8785         * target-memory.c: Fix common/ includes.
8786         * target-descriptions.c: Fix common/ includes.
8787         * symtab.h: Fix common/ includes.
8788         * symfile.c: Fix common/ includes.
8789         * stap-probe.c: Fix common/ includes.
8790         * spu-linux-nat.c: Fix common/ includes.
8791         * sparc-nat.c: Fix common/ includes.
8792         * source.c: Fix common/ includes.
8793         * solib.c: Fix common/ includes.
8794         * solib-target.c: Fix common/ includes.
8795         * ser-unix.c: Fix common/ includes.
8796         * ser-tcp.c: Fix common/ includes.
8797         * ser-pipe.c: Fix common/ includes.
8798         * ser-base.c: Fix common/ includes.
8799         * selftest-arch.c: Fix common/ includes.
8800         * s12z-tdep.c: Fix common/ includes.
8801         * rust-exp.y: Fix common/ includes.
8802         * rs6000-aix-tdep.c: Fix common/ includes.
8803         * riscv-tdep.c: Fix common/ includes.
8804         * remote.c: Fix common/ includes.
8805         * remote-notif.h: Fix common/ includes.
8806         * remote-fileio.h: Fix common/ includes.
8807         * remote-fileio.c: Fix common/ includes.
8808         * regcache.h: Fix common/ includes.
8809         * regcache.c: Fix common/ includes.
8810         * record-btrace.c: Fix common/ includes.
8811         * python/python.c: Fix common/ includes.
8812         * python/py-type.c: Fix common/ includes.
8813         * python/py-inferior.c: Fix common/ includes.
8814         * progspace.h: Fix common/ includes.
8815         * producer.c: Fix common/ includes.
8816         * procfs.c: Fix common/ includes.
8817         * proc-api.c: Fix common/ includes.
8818         * printcmd.c: Fix common/ includes.
8819         * ppc-linux-nat.c: Fix common/ includes.
8820         * parser-defs.h: Fix common/ includes.
8821         * osdata.c: Fix common/ includes.
8822         * obsd-nat.c: Fix common/ includes.
8823         * nat/x86-linux.c: Fix common/ includes.
8824         * nat/x86-linux-dregs.c: Fix common/ includes.
8825         * nat/x86-dregs.h: Fix common/ includes.
8826         * nat/x86-dregs.c: Fix common/ includes.
8827         * nat/ppc-linux.c: Fix common/ includes.
8828         * nat/mips-linux-watch.h: Fix common/ includes.
8829         * nat/mips-linux-watch.c: Fix common/ includes.
8830         * nat/linux-waitpid.c: Fix common/ includes.
8831         * nat/linux-ptrace.h: Fix common/ includes.
8832         * nat/linux-ptrace.c: Fix common/ includes.
8833         * nat/linux-procfs.c: Fix common/ includes.
8834         * nat/linux-personality.c: Fix common/ includes.
8835         * nat/linux-osdata.c: Fix common/ includes.
8836         * nat/linux-namespaces.c: Fix common/ includes.
8837         * nat/linux-btrace.h: Fix common/ includes.
8838         * nat/linux-btrace.c: Fix common/ includes.
8839         * nat/fork-inferior.c: Fix common/ includes.
8840         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8841         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8842         * nat/aarch64-linux.c: Fix common/ includes.
8843         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8844         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8845         * namespace.h: Fix common/ includes.
8846         * mips-linux-tdep.c: Fix common/ includes.
8847         * minsyms.c: Fix common/ includes.
8848         * mi/mi-parse.h: Fix common/ includes.
8849         * mi/mi-main.c: Fix common/ includes.
8850         * mi/mi-cmd-env.c: Fix common/ includes.
8851         * memrange.h: Fix common/ includes.
8852         * memattr.c: Fix common/ includes.
8853         * maint.h: Fix common/ includes.
8854         * maint.c: Fix common/ includes.
8855         * main.c: Fix common/ includes.
8856         * machoread.c: Fix common/ includes.
8857         * location.c: Fix common/ includes.
8858         * linux-thread-db.c: Fix common/ includes.
8859         * linux-nat.c: Fix common/ includes.
8860         * linux-fork.c: Fix common/ includes.
8861         * inline-frame.c: Fix common/ includes.
8862         * infrun.c: Fix common/ includes.
8863         * inflow.c: Fix common/ includes.
8864         * inferior.h: Fix common/ includes.
8865         * inferior.c: Fix common/ includes.
8866         * infcmd.c: Fix common/ includes.
8867         * inf-ptrace.c: Fix common/ includes.
8868         * inf-child.c: Fix common/ includes.
8869         * ia64-linux-nat.c: Fix common/ includes.
8870         * i387-tdep.c: Fix common/ includes.
8871         * i386-tdep.c: Fix common/ includes.
8872         * i386-linux-tdep.c: Fix common/ includes.
8873         * i386-linux-nat.c: Fix common/ includes.
8874         * i386-go32-tdep.c: Fix common/ includes.
8875         * i386-fbsd-tdep.c: Fix common/ includes.
8876         * i386-fbsd-nat.c: Fix common/ includes.
8877         * guile/scm-type.c: Fix common/ includes.
8878         * guile/guile.c: Fix common/ includes.
8879         * go32-nat.c: Fix common/ includes.
8880         * gnu-nat.c: Fix common/ includes.
8881         * gdbthread.h: Fix common/ includes.
8882         * gdbarch-selftests.c: Fix common/ includes.
8883         * gdb_usleep.c: Fix common/ includes.
8884         * gdb_select.h: Fix common/ includes.
8885         * gdb_bfd.c: Fix common/ includes.
8886         * gcore.c: Fix common/ includes.
8887         * fork-child.c: Fix common/ includes.
8888         * findvar.c: Fix common/ includes.
8889         * fbsd-nat.c: Fix common/ includes.
8890         * event-top.c: Fix common/ includes.
8891         * event-loop.c: Fix common/ includes.
8892         * dwarf2read.c: Fix common/ includes.
8893         * dwarf2loc.c: Fix common/ includes.
8894         * dwarf2-frame.c: Fix common/ includes.
8895         * dwarf-index-cache.c: Fix common/ includes.
8896         * dtrace-probe.c: Fix common/ includes.
8897         * disasm-selftests.c: Fix common/ includes.
8898         * defs.h: Fix common/ includes.
8899         * csky-tdep.c: Fix common/ includes.
8900         * cp-valprint.c: Fix common/ includes.
8901         * cp-support.h: Fix common/ includes.
8902         * cp-support.c: Fix common/ includes.
8903         * corelow.c: Fix common/ includes.
8904         * completer.h: Fix common/ includes.
8905         * completer.c: Fix common/ includes.
8906         * compile/compile.c: Fix common/ includes.
8907         * compile/compile-loc2c.c: Fix common/ includes.
8908         * compile/compile-cplus-types.c: Fix common/ includes.
8909         * compile/compile-cplus-symbols.c: Fix common/ includes.
8910         * command.h: Fix common/ includes.
8911         * cli/cli-dump.c: Fix common/ includes.
8912         * cli/cli-cmds.c: Fix common/ includes.
8913         * charset.c: Fix common/ includes.
8914         * build-id.c: Fix common/ includes.
8915         * btrace.h: Fix common/ includes.
8916         * btrace.c: Fix common/ includes.
8917         * breakpoint.h: Fix common/ includes.
8918         * breakpoint.c: Fix common/ includes.
8919         * ax.h:
8920         (enum agent_op): Fix common/ includes.
8921         * ax-general.c (struct aop_map): Fix common/ includes.
8922         * ax-gdb.c: Fix common/ includes.
8923         * auxv.c: Fix common/ includes.
8924         * auto-load.c: Fix common/ includes.
8925         * arm-tdep.c: Fix common/ includes.
8926         * arch/riscv.c: Fix common/ includes.
8927         * arch/ppc-linux-common.c: Fix common/ includes.
8928         * arch/i386.c: Fix common/ includes.
8929         * arch/arm.c: Fix common/ includes.
8930         * arch/arm-linux.c: Fix common/ includes.
8931         * arch/arm-get-next-pcs.c: Fix common/ includes.
8932         * arch/amd64.c: Fix common/ includes.
8933         * arch/aarch64.c: Fix common/ includes.
8934         * arch/aarch64-insn.c: Fix common/ includes.
8935         * arch-utils.c: Fix common/ includes.
8936         * amd64-windows-tdep.c: Fix common/ includes.
8937         * amd64-tdep.c: Fix common/ includes.
8938         * amd64-sol2-tdep.c: Fix common/ includes.
8939         * amd64-obsd-tdep.c: Fix common/ includes.
8940         * amd64-nbsd-tdep.c: Fix common/ includes.
8941         * amd64-linux-tdep.c: Fix common/ includes.
8942         * amd64-linux-nat.c: Fix common/ includes.
8943         * amd64-fbsd-tdep.c: Fix common/ includes.
8944         * amd64-fbsd-nat.c: Fix common/ includes.
8945         * amd64-dicos-tdep.c: Fix common/ includes.
8946         * amd64-darwin-tdep.c: Fix common/ includes.
8947         * agent.c: Fix common/ includes.
8948         * ada-lang.h: Fix common/ includes.
8949         * ada-lang.c: Fix common/ includes.
8950         * aarch64-tdep.c: Fix common/ includes.
8951
8952 2019-01-25  Tom Tromey  <tom@tromey.com>
8953
8954         * common/create-version.sh: Use common/version.h.
8955
8956 2019-01-24  Pedro Alves  <palves@redhat.com>
8957
8958         * infrun.c (signal_stop, signal_print, signal_program)
8959         (signal_catch, signal_pass): Now arrays instead of pointers.
8960         (update_signals_program_target, do_target_resume)
8961         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8962         * linux-nat.c (linux_nat_target::pass_signals)
8963         (linux_nat_target::create_inferior, linux_nat_target::attach):
8964         Adjust.
8965         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8966         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8967         * procfs.c (procfs_target::pass_signals): Adjust.
8968         * record-full.c (record_full_target::resume): Adjust.
8969         * remote.c (remote_target::pass_signals)
8970         (remote_target::program_signals): Adjust.
8971         * target-debug.h (target_debug_print_signals): Now takes a
8972         gdb::array_view as parameter.  Adjust.
8973         * target.h (target_ops) <pass_signals, program_signals>: Replace
8974         pointer and length parameters with gdb::array_view.
8975         (target_pass_signals, target_program_signals): Likewise.
8976         * target-delegates.c: Regenerate.
8977
8978 2019-01-24  Pedro Alves  <palves@redhat.com>
8979
8980         * common/forward-scope-exit.h
8981         (forward_scope_exit::forward_scope_exit): Pass arguments to
8982         m_bind_function directly, instead of creating a std::bind and
8983         copying that.
8984
8985 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8986
8987         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8988         for static members.
8989         (pass_in_v_vfp_candidate): Likewise.
8990
8991 2019-01-23  Tom Tromey  <tom@tromey.com>
8992             Pedro Alves  <palves@redhat.com>
8993
8994         * regcache.c (class regcache_invalidator): Remove.
8995         (regcache::raw_write): Use make_scope_exit.
8996
8997 2019-01-23  Tom Tromey  <tom@tromey.com>
8998
8999         * ui-out.h (class ui_out_emit_type): Update comment.
9000
9001 2019-01-23  Tom Tromey  <tom@tromey.com>
9002
9003         * infrun.c (fetch_inferior_event): Update comment.
9004
9005 2019-01-23  Tom Tromey  <tom@tromey.com>
9006             Pedro Alves  <palves@redhat.com>
9007
9008         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9009         parameter.
9010         (fetch_inferior_event): Use SCOPE_EXIT.
9011
9012
9013 2019-01-23  Tom Tromey  <tom@tromey.com>
9014             Pedro Alves  <palves@redhat.com>
9015
9016         * infrun.c (disable_thread_events): Delete.
9017         (stop_all_threads): Use SCOPE_EXIT.
9018
9019 2019-01-23  Tom Tromey  <tom@tromey.com>
9020             Pedro Alves  <palves@redhat.com>
9021
9022         * symfile.c: Include forward-scope-exit.h.
9023         (clear_symtab_users_cleanup): Replace forward declaration with
9024         a FORWARD_SCOPE_EXIT.
9025         (syms_from_objfile_1): Use the forward_scope_exit and
9026         gdb::optional instead of cleanup_function.
9027         (reread_symbols): Use the forward_scope_exit instead of
9028         cleanup_function.
9029         (clear_symtab_users_cleanup): Remove function.
9030
9031 2019-01-23  Tom Tromey  <tom@tromey.com>
9032             Pedro Alves  <palves@redhat.com>
9033
9034         * linux-nat.c: Include scope-exit.h.
9035         (cleanup_target_stop): Remove.
9036         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9037         SCOPE_EXIT.
9038
9039 2019-01-23  Tom Tromey  <tom@tromey.com>
9040             Pedro Alves  <palves@redhat.com>
9041
9042         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9043         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9044
9045 2019-01-23  Tom Tromey  <tom@tromey.com>
9046             Andrew Burgess  <andrew.burgess@embecosm.com>
9047             Pedro Alves  <palves@redhat.com>
9048
9049         * infrun.c (fetch_inferior_event): Use scope_exit.
9050         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9051         * top.c (execute_command): Use scope_exit.
9052         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9053         * utils.c (do_bpstat_clear_actions_cleanup)
9054         (make_bpstat_clear_actions_cleanup): Remove.
9055
9056 2019-01-23  Tom Tromey  <tom@tromey.com>
9057             Pedro Alves  <palves@redhat.com>
9058
9059         * infrun.c: Include "common/scope-exit.h"
9060         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9061         (wait_for_inferior): Use SCOPE_EXIT.
9062         (fetch_inferior_event): Use scope_exit.
9063
9064 2019-01-23  Tom Tromey  <tom@tromey.com>
9065             Pedro Alves  <palves@redhat.com>
9066
9067         * breakpoint.c (create_breakpoint): Remove cleanup.
9068
9069 2019-01-23  Tom Tromey  <tom@tromey.com>
9070             Andrew Burgess  <andrew.burgess@embecosm.com>
9071             Pedro Alves  <palves@redhat.com>
9072
9073 2019-01-23  Pedro Alves  <palves@redhat.com>
9074
9075         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9076
9077 2019-01-23  Pedro Alves  <palves@redhat.com>
9078             Andrew Burgess  <andrew.burgess@embecosm.com>
9079
9080         * gdbthread.h: Include "common/forward-scope-exit.h".
9081         (scoped_finish_thread_state): Redefine custom class in terms of
9082         forward_scope_exit.
9083
9084 2019-01-23  Pedro Alves  <palves@redhat.com>
9085             Andrew Burgess  <andrew.burgess@embecosm.com>
9086
9087         * common/forward-scope-exit.h: New file.
9088
9089 2019-01-23  Pedro Alves  <palves@redhat.com>
9090             Andrew Burgess  <andrew.burgess@embecosm.com>
9091             Tom Tromey  <tom@tromey.com>
9092
9093         * common/scope-exit.h: New file.
9094
9095 2019-01-23  Pedro Alves  <palves@redhat.com>
9096
9097         * common/preprocessor.h (ESC): Rename to ...
9098         (ESC_PARENS): ... this.
9099         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9100         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9101
9102 2019-01-23  Tom Tromey  <tom@tromey.com>
9103
9104         * language.h (class scoped_switch_to_sym_language_if_auto):
9105         Initialize m_lang in both cases.
9106
9107 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9108
9109         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9110         with XCNEW.
9111
9112 2019-01-22  Tom Tromey  <tom@tromey.com>
9113
9114         * corelow.c: Do not include sys/file.h.
9115
9116 2019-01-22  Tom Tromey  <tom@tromey.com>
9117
9118         * tui/tui-wingeneral.h: Include gdb_curses.h.
9119
9120 2019-01-22  Tom Tromey  <tom@tromey.com>
9121
9122         * source-cache.h (class source_cache) <get_source_lines,
9123         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9124
9125 2019-01-22  Tom Tromey  <tom@tromey.com>
9126
9127         * remote-fileio.h (struct remote_target): Declare.
9128
9129 2019-01-22  Tom Tromey  <tom@tromey.com>
9130
9131         * python/py-arch.c: Do not include py-ref.h.
9132         * python/py-bpevent.c: Do not include py-ref.h.
9133         * python/py-cmd.c: Do not include py-ref.h.
9134         * python/py-continueevent.c: Do not include py-ref.h.
9135         * python/py-event.h: Do not include py-ref.h.
9136         * python/py-evtregistry.c: Do not include py-ref.h.
9137         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9138         * python/py-frame.c: Do not include py-ref.h.
9139         * python/py-framefilter.c: Do not include py-ref.h.
9140         * python/py-function.c: Do not include py-ref.h.
9141         * python/py-infevents.c: Do not include py-ref.h.
9142         * python/py-linetable.c: Do not include py-ref.h.
9143         * python/py-objfile.c: Do not include py-ref.h.
9144         * python/py-param.c: Do not include py-ref.h.
9145         * python/py-prettyprint.c: Do not include py-ref.h.
9146         * python/py-progspace.c: Do not include py-ref.h.
9147         * python/py-symbol.c: Do not include py-ref.h.
9148         * python/py-symtab.c: Do not include py-ref.h.
9149         * python/py-type.c: Do not include py-ref.h.
9150         * python/py-unwind.c: Do not include py-ref.h.
9151         * python/py-utils.c: Do not include py-ref.h.
9152         * python/py-value.c: Do not include py-ref.h.
9153         * python/py-varobj.c: Do not include py-ref.h.
9154         * python/py-xmethods.c: Do not include py-ref.h.
9155         * python/python.c: Do not include py-ref.h.
9156         * varobj.c: Do not include py-ref.h.
9157
9158 2019-01-22  Tom Tromey  <tom@tromey.com>
9159
9160         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9161         keyword for bcache.
9162
9163 2019-01-22  Tom Tromey  <tom@tromey.com>
9164
9165         * compile/compile-cplus-types.c: Remove a comment by #include.
9166
9167 2019-01-22  Tom Tromey  <tom@tromey.com>
9168
9169         * compile/gcc-c-plugin.h: Include compile-internal.h.
9170
9171 2019-01-22  Tom Tromey  <tom@tromey.com>
9172
9173         * stabsread.c (EXTERN): Do not define.
9174         (symnum, next_symbol_text_func, processing_gcc_compilation)
9175         (within_function, global_sym_chain, global_stabs)
9176         (previous_stab_code, this_object_header_files)
9177         (n_this_object_header_files)
9178         (n_allocated_this_object_header_files): Define.
9179         * stabsread.h (EXTERN): Never define.  Use "extern".
9180
9181 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9182
9183         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9184         history_value.
9185
9186 2019-01-21  Tom Tromey  <tom@tromey.com>
9187
9188         * ui-out.c: Fix includes.
9189         * tui/tui-source.c: Fix includes.
9190         * target.c: Fix includes.
9191         * remote.c: Fix includes.
9192         * regcache.c: Fix includes.
9193         * python/py-block.c: Fix includes.
9194         * printcmd.c: Fix includes.
9195         * or1k-tdep.c: Fix includes.
9196         * mi/mi-main.c: Fix includes.
9197         * m32r-tdep.c: Fix includes.
9198         * csky-tdep.c: Fix includes.
9199         * compile/compile-cplus-types.c: Fix includes.
9200         * cli/cli-interp.c: Fix includes.
9201
9202 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9203
9204         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9205         for padding.
9206
9207 2019-01-16  Tom Tromey  <tom@tromey.com>
9208
9209         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9210         earlier.
9211         (struct objfile) <msymbols_range>: Move from top level.
9212         <msymbols>: New method.
9213         (class objfile_msymbols): Remove.
9214         * symtab.c (default_collect_symbol_completion_matches_break_on):
9215         Update.
9216         * symmisc.c (dump_msymbols): Update.
9217         * stabsread.c (scan_file_globals): Update.
9218         * objc-lang.c (info_selectors_command, info_classes_command)
9219         (find_methods): Update.
9220         * minsyms.c (find_solib_trampoline_target): Update.
9221         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9222         * coffread.c (coff_symfile_read): Update.
9223         * ada-lang.c (ada_lookup_simple_minsym)
9224         (ada_collect_symbol_completion_matches): Update.
9225
9226 2019-01-16  Tom Tromey  <tom@tromey.com>
9227
9228         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9229         type.  Remove no-argument constructor.
9230         <iterator::operator++>: Simplify.
9231         <begin>: Update.
9232         <end>: Use minimal_symbol_count.
9233
9234 2019-01-16  Tom Tromey  <tom@tromey.com>
9235
9236         * objfiles.h (struct objfile) <psymtabs>: New method.
9237         (class objfile_psymtabs): Remove.
9238         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9239         typedef.
9240         <range>: New method.
9241         (require_partial_symbols): Change return type.
9242         * psymtab.c (require_partial_symbols)
9243         (psym_expand_symtabs_matching): Update.
9244         * mdebugread.c (parse_partial_symbols): Update.
9245         * dbxread.c (dbx_end_psymtab): Update.
9246
9247 2019-01-15  Tom Tromey  <tom@tromey.com>
9248
9249         * symtab.c (lookup_objfile_from_block)
9250         (lookup_symbol_in_objfile_symtabs)
9251         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9252         (find_line_symtab, info_sources_command)
9253         (default_collect_symbol_completion_matches_break_on)
9254         (make_source_files_completion_list): Update.
9255         * symmisc.c (print_objfile_statistics, dump_objfile)
9256         (maintenance_print_symbols, maintenance_info_symtabs)
9257         (maintenance_check_symtabs, maintenance_info_line_tables):
9258         Update.
9259         * source.c (select_source_symtab)
9260         (forget_cached_source_info_for_objfile): Update.
9261         * objfiles.h (class objfile_compunits): Remove.
9262         (struct objfile) <compunits_range>: New typedef.
9263         (compunits): New method.
9264         * objfiles.c (objfile_relocate1): Update.
9265         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9266         * maint.c (count_symtabs_and_blocks): Update.
9267         * linespec.c (iterate_over_all_matching_symtabs): Update.
9268         * cp-support.c (add_symbol_overload_list_qualified): Update.
9269         * coffread.c (coff_symtab_read): Update.
9270         * ada-lang.c (add_nonlocal_symbols)
9271         (ada_collect_symbol_completion_matches)
9272         (ada_add_global_exceptions): Update.
9273
9274 2019-01-15  Tom Tromey  <tom@tromey.com>
9275
9276         * progspace.h (program_space) <objfiles_safe_range>: New
9277         typedef.
9278         <objfiles_safe>: New method.
9279         * objfiles.h (class all_objfiles_safe): Remove.
9280         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9281         * jit.c (jit_inferior_exit_hook): Update.
9282
9283 2019-01-17  Tom Tromey  <tom@tromey.com>
9284
9285         * progspace.h (program_space) <objfiles_range>: New typedef.
9286         <objfiles>: New method.
9287         <objfiles_head>: Rename from objfiles.
9288         (object_files): Update.
9289         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9290         * guile/scm-pretty-print.c
9291         (ppscm_find_pretty_printer_from_objfiles): Update.
9292         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9293         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9294         Update.
9295         * python/py-progspace.c (pspy_get_objfiles): Update.
9296         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9297         Update.
9298         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9299         (objfpy_lookup_objfile_by_build_id): Update.
9300         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9301         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9302         Update.
9303         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9304         (expand_symtab_containing_pc, lookup_objfile_from_block)
9305         (lookup_static_symbol, basic_lookup_transparent_type)
9306         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9307         (find_line_symtab, info_sources_command)
9308         (default_collect_symbol_completion_matches_break_on)
9309         (make_source_files_completion_list, find_main_name): Update.
9310         * symmisc.c (print_symbol_bcache_statistics)
9311         (print_objfile_statistics, maintenance_print_symbols)
9312         (maintenance_print_msymbols, maintenance_print_objfiles)
9313         (maintenance_info_symtabs, maintenance_check_symtabs)
9314         (maintenance_expand_symtabs, maintenance_info_line_tables):
9315         Update.
9316         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9317         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9318         (map_overlay_command, unmap_overlay_command)
9319         (simple_overlay_update, expand_symtabs_matching)
9320         (map_symbol_filenames): Update.
9321         * symfile-debug.c (set_debug_symfile): Update.
9322         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9323         Update.
9324         * source.c (select_source_symtab, forget_cached_source_info):
9325         Update.
9326         * solib.c (solib_read_symbols): Update.
9327         * solib-spu.c (append_ocl_sos): Update.
9328         * psymtab.c (maintenance_print_psymbols)
9329         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9330         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9331         * printcmd.c (info_symbol_command): Update.
9332         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9333         Update.
9334         * objfiles.h (class all_objfiles): Remove.
9335         * objfiles.c (have_partial_symbols, have_full_symbols)
9336         (have_minimal_symbols, qsort_cmp, update_section_map)
9337         (shared_objfile_contains_address_p)
9338         (default_iterate_over_objfiles_in_search_order): Update.
9339         * objc-lang.c (info_selectors_command, info_classes_command)
9340         (find_methods): Update.
9341         * minsyms.c (find_solib_trampoline_target): Update.
9342         * maint.c (maintenance_info_sections)
9343         (maintenance_translate_address, count_symtabs_and_blocks):
9344         Update.
9345         * main.c (captured_main_1): Update.
9346         * linux-thread-db.c (try_thread_db_load_from_pdir)
9347         (has_libpthread): Update.
9348         * linespec.c (iterate_over_all_matching_symtabs)
9349         (search_minsyms_for_name): Update.
9350         * jit.c (jit_find_objf_with_entry_addr): Update.
9351         * hppa-tdep.c (find_unwind_entry)
9352         (hppa_lookup_stub_minimal_symbol): Update.
9353         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9354         Update.
9355         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9356         (elf_gnu_ifunc_resolve_by_got): Update.
9357         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9358         * dwarf-index-write.c (save_gdb_index_command): Update.
9359         * cp-support.c (add_symbol_overload_list_qualified): Update.
9360         * breakpoint.c (create_overlay_event_breakpoint)
9361         (create_longjmp_master_breakpoint)
9362         (create_std_terminate_master_breakpoint)
9363         (create_exception_master_breakpoint): Update.
9364         * blockframe.c (find_pc_partial_function): Update.
9365         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9366         (ada_collect_symbol_completion_matches)
9367         (ada_add_global_exceptions): Update.
9368
9369 2019-01-17  Tom Tromey  <tom@tromey.com>
9370
9371         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9372         declare VEC.
9373         (solib_target_parse_libraries): Change return type.
9374         (library_list_start_segment, library_list_start_section)
9375         (library_list_end_library, library_list_start_library); Update.
9376         (solib_target_free_library_list): Remove.
9377         (solib_target_parse_libraries): Remove cleanup.  Change return
9378         type.
9379         (solib_target_current_sos): Update.
9380
9381 2019-01-17  Tom Tromey  <tromey@bapiya>
9382
9383         * valprint.c: Replace "the the" with "the".
9384         * symtab.c: Replace "the the" with "the".
9385         * solib.c: Replace "the the" with "the".
9386         * solib-dsbt.c: Replace "the the" with "the".
9387         * linespec.c: Replace "the the" with "the".
9388         * dwarf2loc.h: Replace "the the" with "the".
9389         * amd64-windows-tdep.c: Replace "the the" with "the".
9390         * aarch64-tdep.c: Replace "the the" with "the".
9391
9392 2019-01-16  Keith Seitz  <keiths@redhat.com>
9393
9394         PR gdb/23773
9395         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9396         <builder>: Rename to ..
9397         <m_builder>: ... this and make private.
9398         (dwarf2_cu::get_builder): New method.  Change all users of
9399         `builder' to use this method.
9400         (dwarf2_start_symtab): Move to ...
9401         (dwarf2_cu::start_symtab): ... here.  Update all callers
9402         (setup_type_unit_groups): Move to ...
9403         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9404         callers.
9405         (dwarf2_cu::reset_builder): New method.
9406         (process_full_compunit, process_full_type_unit): Use
9407         dwarf2_cu::reset_builder.
9408         (follow_die_offset): Record the ancestor CU if it is different
9409         from the followed DIE's CU.
9410         (follow_die_sig_1): Likewise.
9411
9412 2019-01-15  Tom Tromey  <tom@tromey.com>
9413
9414         * remote.c (class remote_state) <buf>: Now a char_vector.
9415         <buf_size>: Remove.
9416         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9417         parameter.
9418         (remote_target::getpkt_or_notif_sane_1)
9419         (remote_target::getpkt_sane)
9420         (remote_target::getpkt_or_notif_sane): Likewise.
9421         (class remote_target) <putpkt>: New overload.
9422         (remote_target::read_frame): Change type of "buf_p".  Remove
9423         sizeof_p parameter.
9424         (packet_ok): New overload.
9425         (packet_check_result): New overload.
9426         Update all uses.
9427
9428 2019-01-14  Tom Tromey  <tom@tromey.com>
9429
9430         * remote-notif.c (handle_notification, remote_notif_ack)
9431         (remote_notif_parse): Make "buf" const.
9432         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9433         const.
9434         (remote_notif_parse, remote_notif_ack, handle_notification):
9435         Likewise.
9436         * remote.c (remote_notif_stop_parse): Make "buf" const.
9437         (remote_target::remote_parse_stop_reply): Make "buf" const.
9438         (remote_notif_stop_ack): Make "buf" const.
9439
9440 2019-01-14  Tom Tromey  <tom@tromey.com>
9441
9442         * remote.c (remote_console_output): Make parameter const.
9443
9444 2019-01-14  Tom Tromey  <tom@tromey.com>
9445
9446         * target-debug.h (target_debug_print_signals): Constify.
9447         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9448         * procfs.c (procfs_target::pass_signals): Update.
9449         * linux-nat.c (linux_nat_target::pass_signals): Update.
9450         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9451         * target-delegates.c: Rebuild.
9452         * remote.c (remote_target::program_signals): Update.
9453         (remote_target::pass_signals): Update.
9454         * target.c (target_pass_signals): Constify argument.
9455         (target_program_signals): Likewise.
9456         * target.h (struct target_ops) <pass_signals, program_signals>:
9457         Constify argument.
9458         (target_pass_signals, target_program_signals): Constify argument.
9459
9460 2019-01-14  Tom Tromey  <tom@tromey.com>
9461
9462         PR tui/28819:
9463         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9464
9465 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9466
9467         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9468         field.
9469         * rs6000-tdep.c: Include reggroups.h.
9470         (IS_V_ALIAS_PSEUDOREG): Define.
9471         (rs6000_register_name): Return names for the "vX" aliases.
9472         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9473         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9474         aliases.  Call default_register_reggroup_p for all other
9475         pseudo-registers.
9476         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9477         New functions.
9478         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9479         Handle "vX" aliases.
9480         (v_alias_pseudo_register_collect): New function.
9481         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9482         (rs6000_gdbarch_init): Initialize "vX" aliases as
9483         pseudo-registers.  Restore registration of
9484         rs6000_pseudo_register_reggroup_p with
9485         set_tdesc_pseudo_register_reggroup_p.
9486
9487 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9488
9489         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9490         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9491         set_gdbarch_num_pseudo_regs.
9492
9493 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9494
9495         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9496         Remove arg prefixname, add do_set and do_show.
9497         Add member functions set_list and show_list.
9498         * cli/cli-style.c (class cli_style_option): Update accordingly.
9499         (style_set_list): Move to file scope.
9500         (style_show_list): Likewise.
9501         (set_style): Call help_list.
9502         (show_style): Call cmd_show_list.
9503         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9504         Update to use the new macro.
9505
9506 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9507
9508         * ada-lang.c (_initialize_ada_language): Expand the help text
9509         for the "catch exception" command.
9510
9511 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9512
9513         * symtab.c (matching_obj_sections): Initialize obj,
9514         declare it closer to its usage.
9515
9516 2019-01-10  Tom Tromey  <tom@tromey.com>
9517
9518         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9519         (basic_inf_threads_range): Remove.
9520         (inf_threads_range, inf_non_exited_threads_range)
9521         (safe_inf_threads_range): Use next_adapter.
9522
9523 2019-01-10  Keith Seitz  <keiths@redhat.com>
9524
9525         PR gdb/23712
9526         PR symtab/23010
9527         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9528         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9529
9530 2019-01-10  Keith Seitz  <keiths@redhat.com>
9531
9532         PR gdb/23712
9533         PR symtab/23010
9534         * dictionary.c (pending_to_vector): Remove.
9535         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9536         Remove _1 suffix, replacing functions of the same name.  Update
9537         all callers.
9538         (dict_create_hashed, dict_create_hashed_expandable)
9539         (dict_create_linear, dict_create_linear_expandable, dict_free)
9540         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9541         Make functions static.
9542
9543 2019-01-10  Keith Seitz  <keiths@redhat.com>
9544
9545         PR gdb/23712
9546         PR symtab/23010
9547         * dictionary.h (struct dictionary): Replace declaration with
9548         multidictionary.
9549         (dict_create_hashed, dict_create_hashed_expandable)
9550         (dict_create_linear, dict_create_linear_expandable)
9551         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9552         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9553         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9554         taking multidictionary argument.
9555         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9556         * block.h (struct block) <dict>: Change to multidictionary
9557         and rename `multidict'.
9558         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9559         symmisc.c: Update all dictionary references to multidictionary.
9560
9561 2019-01-10  Keith Seitz  <keiths@redhat.com>
9562
9563         PR gdb/23712
9564         PR symtab/23010
9565         * dictionary.c: Include unordered_map.
9566         (pending_to_vector): New function.
9567         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9568         Rewrite the non-"_1" functions to take vector instead
9569         of linked list.
9570         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9571         "new" _1 versions of the same name.
9572         (multidictionary): Define.
9573         (std::hash<enum language): New definition.
9574         (collate_pending_symbols_by_language, mdict_create_hashed)
9575         (mdict_create_hashed_expandable, mdict_create_linear)
9576         (mdict_create_linear_expandable, mdict_free)
9577         (find_language_dictionary, create_new_language_dictionary)
9578         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9579         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9580         (mdict_size, mdict_empty): New functions.
9581         * dictionary.h (mdict_iterator): Define.
9582
9583 2019-01-10  Pedro Alves  <palves@redhat.com>
9584
9585         * breakpoint.c (read_uploaded_action)
9586         (create_tracepoint_from_upload): Adjust to use
9587         gdb::unique_xmalloc_ptr.
9588         * ctf.c (ctf_write_uploaded_tp):
9589         (SET_ARRAY_FIELD): Use emplace_back.
9590         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9591         * tracefile-tfile.c (tfile_write_uploaded_tp):
9592         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9593         gdb::unique_xmalloc_ptr.
9594         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9595         at_string, cond_string, cmd_strings>: Replace char pointers
9596         with gdb::unique_xmalloc_ptr.
9597
9598 2019-01-10  Pedro Alves  <palves@redhat.com>
9599
9600         * solib-target.c (library_list_start_library): Don't xstrdup name.
9601
9602 2019-01-10  Pedro Alves  <palves@redhat.com>
9603
9604         * mdebugread.c (parse_partial_symbols): Use
9605         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9606
9607 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9608
9609         * linux-fork.c (scoped_switch_fork_info)
9610         <~scoped_switch_fork_info>: Fix incorrect variable name.
9611
9612 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9613
9614         * linux-fork.c (scoped_switch_fork_info)
9615         <scoped_switch_fork_info>: Make explicit.
9616         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9617
9618 2019-01-10  Tom Tromey  <tom@tromey.com>
9619
9620         * objfiles.h (objfile::reset_psymtabs): Update.
9621         * objfiles.c (objfile::objfile): Update.
9622         * psymtab.h (psymtab_storage::obstack): Update.
9623         (psymtab_storage::m_obstack): Use gdb::optional.
9624         (class psymtab_storage): Update comment.  Remove objfile
9625         parameter.
9626         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9627
9628 2019-01-10  Tom Tromey  <tom@tromey.com>
9629
9630         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9631         <free_psymtabs>: Now private.
9632         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9633         (allocate_psymtab): Use new method.
9634
9635 2019-01-10  Tom Tromey  <tom@tromey.com>
9636
9637         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9638         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9639         * mdebugread.c (parse_partial_symbols): Use
9640         allocate_dependencies.
9641         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9642         allocate_dependencies.
9643         (process_psymtab_comp_unit_reader)
9644         (build_type_psymtab_dependencies): Likewise.
9645         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9646
9647 2019-01-10  Tom Tromey  <tom@tromey.com>
9648
9649         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9650         PSYMBOL_SET_LANGUAGE.
9651         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9652
9653 2019-01-10  Tom Tromey  <tom@tromey.com>
9654
9655         * psymtab.h (psymtab_storage::obstack): New method.
9656         <m_obstack>: Rename from obstack; now private.
9657         * psymtab.c (psymtab_storage): Update.
9658         * dwarf2read.c (create_addrmap_from_index)
9659         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9660         Update.
9661
9662 2019-01-10  Tom Tromey  <tom@tromey.com>
9663
9664         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9665         * objfiles.h (objfile::reset_psymtabs): New method.
9666
9667 2019-01-10  Tom Tromey  <tom@tromey.com>
9668
9669         * symmisc.c (print_symbol_bcache_statistics): Update.
9670         (print_objfile_statistics): Update.
9671         * symfile.c (reread_symbols): Update.
9672         * psymtab.h (class psymtab_storage): New.
9673         * psymtab.c (psymtab_storage): New constructor.
9674         (~psymtab_storage): New destructor.
9675         (require_partial_symbols): Update.
9676         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9677         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9678         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9679         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9680         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9681         (start_psymtab_common, end_psymtab_common)
9682         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9683         (allocate_psymtab): Update.
9684         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9685         Update.
9686         (dump_psymtab_addrmap, maintenance_print_psymbols)
9687         (maintenance_check_psymtabs): Update.
9688         (class objfile_psymtabs): Move to objfiles.h.
9689         * psympriv.h (discard_psymtab): Now inline.
9690         (psymtab_discarder::psymtab_discarder): Update.
9691         (psymtab_discarder::~psymtab_discarder): Update.
9692         (ALL_OBJFILE_PSYMTABS): Rewrite.
9693         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9694         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9695         Remove fields.
9696         <partial_symtabs>: New field.
9697         (class objfile_psymtabs): Move from psymtab.h.  Update.
9698         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9699         psymbol_cache.
9700         (objfile::~objfile): Don't destroy psymbol_cache.
9701         * mdebugread.c (parse_partial_symbols): Update.
9702         * dwarf2read.c (create_addrmap_from_index)
9703         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9704         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9705         (add_partial_subprogram, dwarf2_ranges_read): Update.
9706         * dwarf-index-write.c (write_address_map)
9707         (write_one_signatured_type, recursively_write_psymbols)
9708         (class debug_names, class debug_names, write_psymtabs_to_index):
9709         Update.
9710
9711 2019-01-10  Tom Tromey  <tom@tromey.com>
9712
9713         * symtab.h (SYMBOL_SET_NAMES): Update.
9714         (symbol_set_names): Update.
9715         (MSYMBOL_SET_NAMES): Update.
9716         * symtab.c (symbol_set_names): Change argument to be an
9717         objfile_per_bfd_storage.
9718         * psymtab.c (add_psymbol_to_bcache): Update.
9719         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9720
9721 2019-01-10  Tom Tromey  <tom@tromey.com>
9722
9723         * symtab.c (create_demangled_names_hash): Change argument to be an
9724         objfile_per_bfd_storage.
9725         (symbol_set_names): Update.
9726
9727 2019-01-10  Tom Tromey  <tom@tromey.com>
9728
9729         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9730         init_psymbol_list.
9731         * psymtab.c (init_psymbol_list): Do nothing if already called.
9732         * psympriv.h (init_psymbol_list): Add comment.
9733         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9734         init_psymbol_list.
9735         * dbxread.c (dbx_symfile_read): Unconditionally call
9736         init_psymbol_list.
9737
9738 2019-01-10  Tom Tromey  <tom@tromey.com>
9739
9740         * xcoffread.c (scan_xcoff_symtab): Update.
9741         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9742         "where".
9743         * mdebugread.c (parse_partial_symbols)
9744         (handle_psymbol_enumerators): Update.
9745         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9746         * dbxread.c (read_dbx_symtab): Update.
9747         * psympriv.h (psymbol_placement): New enum.
9748         (add_psymbol_to_list): Update.
9749
9750 2019-01-10  Tom Tromey  <tom@tromey.com>
9751
9752         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9753         static_psymbols parameters.
9754         (scan_xcoff_symtab): Update.
9755         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9756         static_psymbols parameters.
9757         * psympriv.h (start_psymtab_common): Update.
9758         * mdebugread.c (parse_partial_symbols): Update.
9759         * dwarf2read.c (create_partial_symtab): Update.
9760         * dbxread.c (read_dbx_symtab): Update.
9761         (start_psymtab): Remove global_psymbols and static_psymbols
9762         parameters.
9763
9764 2019-01-10  Tom Tromey  <tom@tromey.com>
9765
9766         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9767         * psymtab.c (allocate_psymtab): Add comment.
9768         * psympriv.h (allocate_psymtab): Add comment.
9769         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9770         initializations.
9771         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9772
9773 2019-01-10  Tom Tromey  <tom@tromey.com>
9774
9775         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9776         Don't declare.
9777         * mipsread.c: Include mdebugread.h.
9778         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9779         Declare.
9780         * elfread.c: Include mdebugread.h.
9781
9782 2019-01-09  Tom Tromey  <tom@tromey.com>
9783
9784         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9785         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9786         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9787         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9788         (psym_lookup_symbol, psym_find_last_source_symtab)
9789         (psym_forget_cached_source_info, psym_print_stats)
9790         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9791         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9792         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9793         (psym_find_compunit_symtab_by_address)
9794         (maintenance_print_psymbols, maintenance_info_psymtabs)
9795         (maintenance_check_psymtabs): Use ranged for.
9796         * psymtab.h (class objfile_psymtabs): New.
9797         (require_partial_symbols): Return objfile_psymtabs.
9798         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9799
9800 2019-01-09  Tom Tromey  <tom@tromey.com>
9801
9802         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9803         (find_pc_mapped_section, list_overlays_command)
9804         (map_overlay_command, unmap_overlay_command)
9805         (simple_overlay_update): Use all_objfiles.
9806         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9807         * printcmd.c (info_symbol_command): Use all_objfiles.
9808         * objfiles.h (ALL_OBJSECTIONS): Remove.
9809         * maint.c (maintenance_translate_address): Use all_objfiles.
9810         * gcore.c (gcore_create_callback): Use all_objfiles.
9811         (objfile_find_memory_regions): Likewise.
9812
9813 2019-01-09  Tom Tromey  <tom@tromey.com>
9814
9815         * symtab.c (find_line_symtab, info_sources_command)
9816         (make_source_files_completion_list): Use objfile_compunits.
9817         * source.c (select_source_symtab): Use objfile_compunits.
9818         * objfiles.h (struct objfile): Update comment.
9819         (ALL_OBJFILES): Remove.
9820         (ALL_FILETABS): Remove.
9821         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9822         objfile_compunits.
9823
9824 2019-01-09  Tom Tromey  <tom@tromey.com>
9825
9826         * symmisc.c (print_objfile_statistics, dump_objfile)
9827         (maintenance_print_symbols): Use compunit_filetabs.
9828         * source.c (forget_cached_source_info_for_objfile): Use
9829         compunit_filetabs.
9830         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9831         (ALL_FILETABS): Use compunit_filetabs.
9832         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9833         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9834
9835 2019-01-09  Tom Tromey  <tom@tromey.com>
9836
9837         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9838         (compunit_filetabs): New.
9839         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9840         compunit_filetabs.
9841         (info_sources_command, make_source_files_completion_list): Remove
9842         declaration.
9843         * symmisc.c (print_objfile_statistics, dump_objfile)
9844         (maintenance_print_symbols): Remove declaration.
9845         (maintenance_info_symtabs): Use compunit_filetabs.
9846         (maintenance_info_line_tables): Likewise.
9847         * source.c (select_source_symtab): Change local variable name.
9848         (forget_cached_source_info_for_objfile): Remove declaration.
9849         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9850         * objfiles.c (objfile_relocate1): Remove declaration.
9851         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9852         declaration.
9853         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9854         * coffread.c (coff_symtab_read): Remove declaration.
9855         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9856         compunit_filetabs.
9857
9858 2019-01-09  Tom Tromey  <tom@tromey.com>
9859
9860         * symtab.c (lookup_objfile_from_block)
9861         (find_pc_sect_compunit_symtab, search_symbols)
9862         (default_collect_symbol_completion_matches_break_on): Use
9863         objfile_compunits.
9864         * objfiles.h (ALL_COMPUNITS): Remove.
9865         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9866         * cp-support.c (add_symbol_overload_list_qualified): Use
9867         objfile_compunits.
9868         * ada-lang.c (ada_collect_symbol_completion_matches)
9869         (ada_add_global_exceptions): Use objfile_compunits.
9870
9871 2019-01-09  Tom Tromey  <tom@tromey.com>
9872
9873         * source.c (select_source_symtab)
9874         (forget_cached_source_info_for_objfile): Remove declaration.
9875         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9876         declaration.
9877         * maint.c (count_symtabs_and_blocks): Remove declaration.
9878         * cp-support.c (add_symbol_overload_list_qualified): Remove
9879         declaration.
9880         * coffread.c (coff_symtab_read): Remove declaration.
9881         * symtab.c (lookup_symbol_in_objfile_symtabs)
9882         (basic_lookup_transparent_type_1): Use objfile_compunits.
9883         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9884         (info_sources_command, search_symbols)
9885         (default_collect_symbol_completion_matches_break_on)
9886         (make_source_files_completion_list): Remove declaration.
9887         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9888         (ada_collect_symbol_completion_matches)
9889         (ada_add_global_exceptions): Remove declaration.
9890         * linespec.c (iterate_over_all_matching_symtabs): Use
9891         objfile_compunits.
9892         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9893         (class objfile_compunits): New.
9894         (ALL_COMPUNITS): Use objfile_compunits.
9895         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9896         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9897         objfile_compunits.
9898         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9899
9900 2019-01-09  Tom Tromey  <tom@tromey.com>
9901
9902         * symtab.c (search_symbols)
9903         (default_collect_symbol_completion_matches_break_on): Use
9904         objfile_msymbols.
9905         * ada-lang.c (ada_lookup_simple_minsym)
9906         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9907         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9908         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9909         objfile_msymbols.
9910         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9911         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9912         * objc-lang.c (find_methods): Use objfile_msymbols.
9913         (info_selectors_command, info_classes_command): Likewise.
9914         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9915         * objfiles.h (class objfile_msymbols): New.
9916         (ALL_OBJFILE_MSYMBOLS): Remove.
9917         (ALL_MSYMBOLS): Remove.
9918
9919 2019-01-09  Tom Tromey  <tom@tromey.com>
9920
9921         * common/next-iterator.h (next_adapter): Add Iterator template
9922         parameter.
9923         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9924         (class all_objfiles_safe): New.
9925         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9926         * objfiles.c (put_objfile_before): Update comment.
9927         (add_separate_debug_objfile): Likewise.
9928         (free_all_objfiles): Use all_objfiles_safe.
9929         (objfile_purge_solibs): Likewise.
9930
9931 2019-01-09  Tom Tromey  <tom@tromey.com>
9932
9933         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9934         (expand_symtab_containing_pc, lookup_static_symbol)
9935         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9936         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9937         all_objfiles.
9938         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9939         * breakpoint.c (create_overlay_event_breakpoint)
9940         (create_longjmp_master_breakpoint)
9941         (create_std_terminate_master_breakpoint)
9942         (create_exception_master_breakpoint): Use all_objfiles.
9943         * linux-thread-db.c (try_thread_db_load_from_pdir)
9944         (has_libpthread): Use all_objfiles.
9945         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9946         * linespec.c (iterate_over_all_matching_symtabs)
9947         (search_minsyms_for_name): Use all_objfiles.
9948         * maint.c (maintenance_info_sections): Use all_objfiles.
9949         * main.c (captured_main_1): Use all_objfiles.
9950         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9951         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9952         * guile/scm-pretty-print.c
9953         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9954         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9955         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9956         (maintenance_print_msymbols): Use all_objfiles.
9957         * source.c (select_source_symtab): Use all_objfiles.
9958         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9959         * symfile.c (remove_symbol_file_command)
9960         (expand_symtabs_matching, map_symbol_filenames): Use
9961         all_objfiles.
9962         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9963         all_objfiles.
9964         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9965         * objc-lang.c (find_methods): Use all_objfiles.
9966         * objfiles.c (have_partial_symbols, have_full_symbols)
9967         (have_minimal_symbols, qsort_cmp)
9968         (default_iterate_over_objfiles_in_search_order): Use
9969         all_objfiles.
9970         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9971         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9972         (maintenance_check_psymtabs): Use all_objfiles.
9973         (ALL_PSYMTABS): Remove.
9974         * compile/compile-object-run.c (do_module_cleanup): Use
9975         all_objfiles.
9976         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9977         * cp-support.c (add_symbol_overload_list_qualified): Use
9978         all_objfiles.
9979         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9980         Use all_objfiles.
9981         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9982         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9983         all_objfiles.
9984         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9985         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9986         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9987         Uses all_objfiles.
9988         * solib.c (solib_read_symbols): Use all_objfiles
9989
9990 2019-01-09  Tom Tromey  <tom@tromey.com>
9991
9992         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9993         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9994         all_objfiles.
9995         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9996         * symmisc.c (print_symbol_bcache_statistics)
9997         (print_objfile_statistics, maintenance_print_objfiles)
9998         (maintenance_info_symtabs, maintenance_check_symtabs)
9999         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10000         all_objfiles.
10001         * source.c (forget_cached_source_info): Use all_objfiles.
10002         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10003         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10004         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10005         * objfiles.c (update_section_map): Use all_objfiles.
10006         (shared_objfile_contains_address_p): Likewise.
10007         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10008         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10009
10010 2019-01-09  Tom Tromey  <tom@tromey.com>
10011
10012         * common/next-iterator.h: New file.
10013         * objfiles.h (class all_objfiles): New.
10014         (struct objfile_iterator): New.
10015
10016 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10017
10018         * NEWS: Move the description of the changed "frame", "select-frame",
10019          and "info frame" commands to the Changed commands section.
10020
10021 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10022
10023         * gdbtypes.c (check_stub_method_group): Remove handling of old
10024         mangling schemes.
10025         * linespec.c (find_methods): Likewise.
10026         * stabsread.c (read_member_functions): Likewise.
10027         * valops.c (search_struct_method): Likewise.
10028         (value_struct_elt_for_reference): Likewise.
10029         * NEWS: Mention this change.
10030
10031 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10032
10033         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10034         print_source_lines.
10035         * source.c (print_source_lines_base): Update line number check.
10036         (print_source_lines): New function.
10037         (source_lines_range::source_lines_range): New function.
10038         * source.h (class source_lines_range): New class.
10039         (print_source_lines): New declaration.
10040
10041 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10042
10043         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10044
10045 2019-01-08  Tom Tromey  <tom@tromey.com>
10046             Simon Marchi  <simon.marchi@ericsson.com>
10047
10048         PR gdb/24060
10049         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10050         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10051         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10052         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10053         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10054         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10055
10056 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10057
10058         * source.c (select_source_symtab): Move header comment to
10059         declaration in source.h.
10060         (forget_cached_source_info_for_objfile): Likewise.
10061         (forget_cached_source_info): Likewise.
10062         (identify_source_line): Likewise.
10063         * source.h (identify_source_line): Move declaration from symtab.h
10064         and add comment from source.c
10065         (print_source_lines): Likewise.
10066         (forget_cached_source_info_for_objfile): Likewise.
10067         (forget_cached_source_info): Likewise.
10068         (select_source_symtab): Likewise.
10069         (enum print_source_lines_flag): Move definition from symtab.h.
10070         * symtab.h (identify_source_line): Move declaration to source.h.
10071         (print_source_lines): Likewise.
10072         (forget_cached_source_info_for_objfile): Likewise.
10073         (forget_cached_source_info): Likewise.
10074         (select_source_symtab): Likewise.
10075         (enum print_source_lines_flag): Move definition to source.h.
10076         * tui/tui-hooks.c: Add 'source.h' include.
10077
10078 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10079
10080         * source.c (print_source_lines_base): Handle requests to print
10081         reverse line number sequences, and guard against empty lines
10082         string.
10083
10084 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10085
10086         * source.c (print_source_lines_base): Fix skip of '\r' if next
10087         character is '\n'.
10088
10089 2019-01-06  Tom Tromey  <tom@tromey.com>
10090
10091         * c-exp.y (struct c_parse_state) <macro_original_text,
10092         expansion_obstack>: New member.
10093         (macro_original_text, expansion_obstack): Remove globals.
10094         (scan_macro_expansion, scanning_macro_expansion)
10095         (finished_macro_expansion): Update.
10096         (scan_macro_cleanup): Remove.
10097         (yylex, c_parse): Update.
10098
10099 2019-01-06  Tom Tromey  <tom@tromey.com>
10100
10101         * c-exp.y (struct c_parse_state) <strings>: New member.
10102         (operator_stoken): Update.
10103
10104 2019-01-06  Tom Tromey  <tom@tromey.com>
10105
10106         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10107         (union type_stack_elt) <typelist_val>: Now a pointer to
10108         std::vector.
10109         (type_stack_cleanup): Don't declare.
10110         (push_typelist): Update.
10111         * parse.c (pop_typelist): Return a std::vector.
10112         (push_typelist): Take a std::vector.
10113         (follow_types): Update.  Do not free args.
10114         (type_stack_cleanup): Remove.
10115         * c-exp.y (struct c_parse_state): New.
10116         (cpstate): New global.
10117         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10118         (nonempty_typelist): Update.
10119         (func_mod): Create a new vector.
10120         (c_parse): Create a c_parse_state.
10121         (check_parameter_typelist): Do not delete params.
10122         (function_method): Update.  Do not delete type_list.
10123
10124 2019-01-06  Tom Tromey  <tom@tromey.com>
10125
10126         PR gdb/28155:
10127         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10128         check_typedef.
10129         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10130         (print_return_value): Likewise.
10131
10132 2019-01-05  Tom Tromey  <tom@tromey.com>
10133
10134         * contrib/cleanup_check.py: Remove.
10135         * contrib/gcc-with-excheck: Remove.
10136         * contrib/exsummary.py: Remove.
10137         * contrib/excheck.py: Remove.
10138
10139 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10140
10141         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10142         NULL. Initialize tpprev to NULL instead of assigning it
10143         to NULL on the next statement.
10144         * windows-nat.c (windows_delete_thread): Remove check for
10145         main_thread_id before printing thread exit notifications.
10146         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10147         Remove thread ID check against main_thread_id.
10148         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10149         windows_delete_thread.
10150         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10151
10152 2019-01-04  Tom Tromey  <tom@tromey.com>
10153
10154         * compile/compile.c (_initialize_compile): Use upper case for
10155         metasyntactic variables.
10156         * symmisc.c (_initialize_symmisc): Use upper case for
10157         metasyntactic variables.
10158         * psymtab.c (_initialize_psymtab): Use upper case for
10159         metasyntactic variables.
10160         * demangle.c (demangle_command): Use upper case for metasyntactic
10161         variables.
10162         (_initialize_demangler): Likewise.
10163         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10164         variables.
10165
10166 2019-01-03  Tom Tromey  <tom@tromey.com>
10167
10168         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10169
10170 2019-01-03  Tom Tromey  <tom@tromey.com>
10171
10172         * python/py-symtab.c (salpy_str): Update.
10173         (struct salpy_sal_object) <symtab>: Now a PyObject.
10174         (salpy_dealloc): Update.
10175         (del_objfile_sal): Use gdbpy_ref.
10176
10177 2019-01-03  Tom Tromey  <tom@tromey.com>
10178
10179         * python/py-type.c (convert_field): Use new_reference.  Return
10180         gdbpy_ref.
10181         (make_fielditem): Return gdbpy_ref.
10182         (typy_fields): Update.
10183         (typy_getitem): Update.
10184         (field_name): Return gdbpy_ref.  Use new_reference.
10185         (typy_iterator_iternext): Update.
10186
10187 2019-01-03  Tom Tromey  <tom@tromey.com>
10188
10189         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10190
10191 2019-01-03  Tom Tromey  <tom@tromey.com>
10192
10193         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10194         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10195         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10196         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10197         (pspy_set_type_printers): Likewise.
10198         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10199         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10200         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10201         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10202         (objfpy_set_type_printers): Likewise.
10203
10204 2019-01-03  Tom Tromey  <tom@tromey.com>
10205
10206         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10207         (gdbpy_print_stack): Use gdbpy_err_fetch.
10208         * python/python-internal.h (class gdbpy_err_fetch): New class.
10209         (class gdbpy_enter) <m_error_type, m_error_value,
10210         m_error_traceback>: Remove.
10211         <m_error>: New member.
10212         (gdbpy_exception_to_string): Don't declare.
10213         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10214         * python/py-value.c (convert_value_from_python): Use
10215         gdbpy_err_fetch.
10216         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10217         gdbpy_exception_to_string.
10218         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10219         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10220         gdbpy_err_fetch.
10221
10222 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10223
10224         * linux-nat.c (delete_lwp_cleanup): Delete.
10225         (struct lwp_deleter): New struct.
10226         (lwp_info_up): New typedef.
10227         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10228         lwp_info_up.
10229
10230 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10231
10232         * linux-fork.c (class scoped_switch_fork_info): New class.
10233         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10234
10235 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10236
10237         * valops.c (find_overload_match): Remove use of null_cleanup, and
10238         calls to do_cleanups.
10239
10240 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10241
10242         * compile/compile-cplus-types.c
10243         (compile_cplus_instance::decl_name): Handle changes to
10244         cp_func_name.
10245         * cp-support.c (cp_func_name): Update header comment, update
10246         return type.
10247         * cp-support.h (cp_func_name): Update return type in declaration.
10248         * valops.c (find_overload_match): Move temp_func local to top
10249         level of function and change its type.  Use temp_func to hold and
10250         delete temporary string obtained from cp_func_name.
10251
10252 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10253
10254         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10255         gdb::char_vector, remove cleanup, and update uses of `msg`.
10256
10257 2019-01-03  Jim Wilson  <jimw@sifive.com>
10258
10259         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10260
10261 2019-01-02  Tom Tromey  <tom@tromey.com>
10262
10263         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10264         (tdesc_parse_xml): Remove cleanups.
10265         * target-descriptions.h (make_cleanup_free_target_description):
10266         Don't declare.
10267         (target_desc_deleter): New struct.
10268         (target_desc_up): New typedef.
10269         * target-descriptions.c (target_desc_deleter::operator()): Rename
10270         from free_target_description.
10271         (make_cleanup_free_target_description): Remove.
10272
10273 2019-01-02  Tom Tromey  <tom@tromey.com>
10274
10275         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10276         constructor, destructor.
10277         (linespec_parser): Remove typedef.
10278         (~linespec_parser): Rename from linespec_parser_delete.
10279         (linespec_lex_to_end, linespec_complete_label)
10280         (linespec_complete): Update.
10281         (decode_line_full): Remove cleanups.
10282         (decode_line_1): Update.
10283
10284 2019-01-02  Tom Tromey  <tom@tromey.com>
10285
10286         * python/python-internal.h (inferior_to_inferior_object): Change
10287         return type.
10288         * python/py-exitedevent.c (create_exited_event_object): Update.
10289         * python/py-inferior.c (inferior_to_inferior_object): Return
10290         gdbpy_ref.
10291         (python_new_inferior, python_inferior_deleted)
10292         (thread_to_thread_object, delete_thread_object)
10293         (build_inferior_list, gdbpy_selected_inferior): Update.
10294         * python/py-infthread.c (create_thread_object): Update.  Also fail
10295         if inferior_to_inferior_object fails.
10296
10297 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10298
10299         * inferior.h (class inferior) <displaced_step_state>: New field.
10300         * infrun.h (struct displaced_step_state): Move here from
10301         infrun.c.  Initialize fields, add constructor.
10302         <inf>: Remove field.
10303         <reset>: New method.
10304         * infrun.c (struct displaced_step_inferior_state): Move to
10305         infrun.h.
10306         (displaced_step_inferior_states): Remove.
10307         (get_displaced_stepping_state): Adust.
10308         (displaced_step_in_progress_any_inferior): Adjust.
10309         (displaced_step_in_progress_thread): Adjust.
10310         (displaced_step_in_progress): Adjust.
10311         (add_displaced_stepping_state): Remove.
10312         (get_displaced_step_closure_by_addr): Adjust.
10313         (remove_displaced_stepping_state): Remove.
10314         (infrun_inferior_exit): Call displaced_step_state.reset.
10315         (use_displaced_stepping): Don't check for NULL.
10316         (displaced_step_prepare_throw): Call
10317         get_displaced_stepping_state.
10318         (displaced_step_fixup): Don't check for NULL.
10319         (prepare_for_detach): Don't check for NULL.
10320
10321 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10322
10323         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10324          in case of call that did not complete.
10325
10326 2019-01-02  Andrey Utkin  <autkin@undo.io>
10327
10328         * symfile.c (find_separate_debug_file): Fix search of debug files for
10329         remote debuggee.
10330
10331 2019-01-02  Tom Tromey  <tom@tromey.com>
10332
10333         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10334         indentation.
10335         * python/py-frame.c (frapy_older): Remove cast.
10336         (frapy_newer): Likewise.
10337         * python/py-breakpoint.c (local_setattro): Remove cast.
10338         * python/py-arch.c (archpy_name): Remove local variable.
10339         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10340
10341 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10342
10343         * unittests/basic_string_view/element_access/char/empty.cc:
10344         Fix year range in copyright header.
10345
10346 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10347
10348         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10349         Delete.
10350         <operator==>: Update with for removed field.
10351         <hash>: Likewise.
10352         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10353         <isa_features>: ...this.
10354         <abi_features>: New field.
10355         (riscv_isa_flen): Update comment.
10356         (riscv_abi_xlen): New declaration.
10357         (riscv_abi_flen): New declaration.
10358         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10359         isa_features.
10360         (riscv_abi_xlen): New function.
10361         (riscv_isa_flen): Update to get answer from isa_features.
10362         (riscv_abi_flen): New function.
10363         (riscv_has_fp_abi): Update to get answer from abi_features.
10364         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10365         xlen and flen.
10366         (riscv_call_info) <xlen, flen>: Update comment.
10367         (riscv_call_arg_struct): Remove invalid assertions
10368         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10369         is removed.
10370         (riscv_gdbarch_init): Gather isa features and abi features
10371         separately, ensure both match on the gdbarch when reusing an old
10372         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10373         a target with 64-bit float hardware.
10374
10375 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10376
10377         * source.c (search_command_helper): Stop reverse search
10378         when line 1 has been searched.
10379
10380 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10381
10382         * record-full.c (record_full_base_target::close): Rewrite
10383         record_full_core_buf_list free logic.
10384
10385 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10386
10387         * break-catch-syscall.c (print_one_catch_syscall): xfree
10388         the last text.
10389
10390 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10391
10392         * top.c (print_gdb_version): Update Copyright year in version
10393         message.
10394
10395 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10396
10397         Update copyright year range in all GDB files.
10398
10399 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10400
10401         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10402
10403 For older changes see ChangeLog-2018.
10404 \f
10405 Local Variables:
10406 mode: change-log
10407 left-margin: 8
10408 fill-column: 74
10409 version-control: never
10410 coding: utf-8
10411 End:
10412