Use child_path to determine if an object file is under a sysroot.
[external/binutils.git] / gdb / ChangeLog
1 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2
3         * symfile.c (find_separate_debug_file): Use child_path to
4         determine if an object file is under a sysroot.
5
6 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7
8         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9         unittests/child-path-selftests.c.
10         * common/pathstuff.c (child_path): New function.
11         * common/pathstuff.h (child_path): New prototype.
12         * unittests/child-path-selftests.c: New file.
13
14 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15
16         * symfile.c (find_separate_debug_file): Look for separate debug
17         files in debug directories under the sysroot.
18
19 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
20
21         * symtab.h (struct minimal_symbol data_p): New const method.
22         (struct minimal_symbol text_p): Likewise.
23         * symtab.c (output_source_filename): Use file name style
24         to print file name.
25         (print_symbol_info): Likewise.
26         (print_msymbol_info): Use address style to print addresses.
27         Use function name style to print executable text symbols.
28         (expand_symtab_containing_pc): Use data_p.
29         (find_pc_sect_compunit_symtab): Likewise.
30
31 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
32
33         * breakpoint.c (describe_other_breakpoints): Use address style
34         to print addresses.
35         (say_where): Likewise.
36
37 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
38
39         * ada-typeprint.c (print_func_type): Print function name
40         style to print function name.
41         * c-typeprint.c (c_print_type_1): Likewise.
42
43 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
44
45         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
46         for execve.
47
48 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
49
50         * c-exp.y (direct_abs_decl): Use emplace_back to record the
51         type_stack.
52
53 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
54
55         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
56         TYPE_CODE_REF types.
57
58 2019-02-08  Jim Wilson  <jimw@sifive.com>
59
60         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
61         (riscv_linux_fregset): New.
62         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
63
64 2019-02-07  Tom Tromey  <tom@tromey.com>
65
66         * thread.c (thread_cancel_execution_command): Update.
67         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
68         methods.
69         (struct thread_fsm_ops): Remove.
70         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
71         (thread_fsm_should_stop, thread_fsm_return_value)
72         (thread_fsm_set_finished, thread_fsm_finished_p)
73         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
74         Don't declare.
75         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
76         * infrun.c (clear_proceed_status_thread)
77         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
78         (print_stop_event): Update.
79         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
80         Add constructor.
81         (step_command_fsm_ops): Remove.
82         (new_step_command_fsm): Remove.
83         (step_1): Update.
84         (step_command_fsm::should_stop): Rename from
85         step_command_fsm_should_stop.
86         (step_command_fsm::clean_up): Rename from
87         step_command_fsm_clean_up.
88         (step_command_fsm::do_async_reply_reason): Rename from
89         step_command_fsm_async_reply_reason.
90         (struct until_next_fsm): Inherit from thread_fsm.  Add
91         constructor.
92         (until_next_fsm_ops): Remove.
93         (new_until_next_fsm): Remove.
94         (until_next_fsm::should_stop): Rename from
95         until_next_fsm_should_stop.
96         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
97         (until_next_fsm::do_async_reply_reason): Rename from
98         until_next_fsm_async_reply_reason.
99         (struct finish_command_fsm): Inherit from thread_fsm.  Add
100         constructor.  Change type of breakpoint.
101         (finish_command_fsm_ops): Remove.
102         (new_finish_command_fsm): Remove.
103         (finish_command_fsm::should_stop): Rename from
104         finish_command_fsm_should_stop.
105         (finish_command_fsm::clean_up): Rename from
106         finish_command_fsm_clean_up.
107         (finish_command_fsm::return_value): Rename from
108         finish_command_fsm_return_value.
109         (finish_command_fsm::do_async_reply_reason): Rename from
110         finish_command_fsm_async_reply_reason.
111         (finish_command): Update.
112         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
113         Add constructor.
114         (call_thread_fsm_ops): Remove.
115         (call_thread_fsm::call_thread_fsm): Rename from
116         new_call_thread_fsm.
117         (call_thread_fsm::should_stop): Rename from
118         call_thread_fsm_should_stop.
119         (call_thread_fsm::should_notify_stop): Rename from
120         call_thread_fsm_should_notify_stop.
121         (run_inferior_call, call_function_by_hand_dummy): Update.
122         * cli/cli-interp.c (should_print_stop_to_console): Update.
123         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
124         Add constructor.  Change type of location_breakpoint,
125         caller_breakpoint.
126         (until_break_fsm_ops): Remove.
127         (new_until_break_fsm): Remove.
128         (until_break_fsm::should_stop): Rename from
129         until_break_fsm_should_stop.
130         (until_break_fsm::clean_up): Rename from
131         until_break_fsm_clean_up.
132         (until_break_fsm::do_async_reply_reason): Rename from
133         until_break_fsm_async_reply_reason.
134         (until_break_command): Update.
135         * thread-fsm.c: Remove.
136         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
137
138 2019-02-07  Tom Tromey  <tom@tromey.com>
139
140         * yy-remap.h: Add include guard.
141         * xtensa-tdep.h: Add include guard.
142         * xcoffread.h: Rename include guard.
143         * varobj-iter.h: Add include guard.
144         * tui/tui.h: Rename include guard.
145         * tui/tui-winsource.h: Rename include guard.
146         * tui/tui-wingeneral.h: Rename include guard.
147         * tui/tui-windata.h: Rename include guard.
148         * tui/tui-win.h: Rename include guard.
149         * tui/tui-stack.h: Rename include guard.
150         * tui/tui-source.h: Rename include guard.
151         * tui/tui-regs.h: Rename include guard.
152         * tui/tui-out.h: Rename include guard.
153         * tui/tui-layout.h: Rename include guard.
154         * tui/tui-io.h: Rename include guard.
155         * tui/tui-hooks.h: Rename include guard.
156         * tui/tui-file.h: Rename include guard.
157         * tui/tui-disasm.h: Rename include guard.
158         * tui/tui-data.h: Rename include guard.
159         * tui/tui-command.h: Rename include guard.
160         * tic6x-tdep.h: Add include guard.
161         * target/waitstatus.h: Rename include guard.
162         * target/wait.h: Rename include guard.
163         * target/target.h: Rename include guard.
164         * target/resume.h: Rename include guard.
165         * target-float.h: Rename include guard.
166         * stabsread.h: Add include guard.
167         * rs6000-tdep.h: Add include guard.
168         * riscv-fbsd-tdep.h: Add include guard.
169         * regformats/regdef.h: Rename include guard.
170         * record.h: Rename include guard.
171         * python/python.h: Rename include guard.
172         * python/python-internal.h: Rename include guard.
173         * python/py-stopevent.h: Rename include guard.
174         * python/py-ref.h: Rename include guard.
175         * python/py-record.h: Rename include guard.
176         * python/py-record-full.h: Rename include guard.
177         * python/py-record-btrace.h: Rename include guard.
178         * python/py-instruction.h: Rename include guard.
179         * python/py-events.h: Rename include guard.
180         * python/py-event.h: Rename include guard.
181         * procfs.h: Add include guard.
182         * proc-utils.h: Add include guard.
183         * p-lang.h: Add include guard.
184         * or1k-tdep.h: Rename include guard.
185         * observable.h: Rename include guard.
186         * nto-tdep.h: Rename include guard.
187         * nat/x86-linux.h: Rename include guard.
188         * nat/x86-linux-dregs.h: Rename include guard.
189         * nat/x86-gcc-cpuid.h: Add include guard.
190         * nat/x86-dregs.h: Rename include guard.
191         * nat/x86-cpuid.h: Rename include guard.
192         * nat/ppc-linux.h: Rename include guard.
193         * nat/mips-linux-watch.h: Rename include guard.
194         * nat/linux-waitpid.h: Rename include guard.
195         * nat/linux-ptrace.h: Rename include guard.
196         * nat/linux-procfs.h: Rename include guard.
197         * nat/linux-osdata.h: Rename include guard.
198         * nat/linux-nat.h: Rename include guard.
199         * nat/linux-namespaces.h: Rename include guard.
200         * nat/linux-btrace.h: Rename include guard.
201         * nat/glibc_thread_db.h: Rename include guard.
202         * nat/gdb_thread_db.h: Rename include guard.
203         * nat/gdb_ptrace.h: Rename include guard.
204         * nat/fork-inferior.h: Rename include guard.
205         * nat/amd64-linux-siginfo.h: Rename include guard.
206         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
207         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
208         * nat/aarch64-linux.h: Rename include guard.
209         * nat/aarch64-linux-hw-point.h: Rename include guard.
210         * mn10300-tdep.h: Add include guard.
211         * mips-linux-tdep.h: Add include guard.
212         * mi/mi-parse.h: Rename include guard.
213         * mi/mi-out.h: Rename include guard.
214         * mi/mi-main.h: Rename include guard.
215         * mi/mi-interp.h: Rename include guard.
216         * mi/mi-getopt.h: Rename include guard.
217         * mi/mi-console.h: Rename include guard.
218         * mi/mi-common.h: Rename include guard.
219         * mi/mi-cmds.h: Rename include guard.
220         * mi/mi-cmd-break.h: Rename include guard.
221         * m2-lang.h: Add include guard.
222         * location.h: Rename include guard.
223         * linux-record.h: Rename include guard.
224         * linux-nat.h: Add include guard.
225         * linux-fork.h: Add include guard.
226         * i386-darwin-tdep.h: Rename include guard.
227         * hppa-linux-offsets.h: Add include guard.
228         * guile/guile.h: Rename include guard.
229         * guile/guile-internal.h: Rename include guard.
230         * gnu-nat.h: Rename include guard.
231         * gdb-stabs.h: Rename include guard.
232         * frv-tdep.h: Add include guard.
233         * f-lang.h: Add include guard.
234         * event-loop.h: Add include guard.
235         * darwin-nat.h: Rename include guard.
236         * cp-abi.h: Rename include guard.
237         * config/sparc/nm-sol2.h: Rename include guard.
238         * config/nm-nto.h: Rename include guard.
239         * config/nm-linux.h: Add include guard.
240         * config/i386/nm-i386gnu.h: Rename include guard.
241         * config/djgpp/nl_types.h: Rename include guard.
242         * config/djgpp/langinfo.h: Rename include guard.
243         * compile/gcc-cp-plugin.h: Add include guard.
244         * compile/gcc-c-plugin.h: Add include guard.
245         * compile/compile.h: Rename include guard.
246         * compile/compile-object-run.h: Rename include guard.
247         * compile/compile-object-load.h: Rename include guard.
248         * compile/compile-internal.h: Rename include guard.
249         * compile/compile-cplus.h: Rename include guard.
250         * compile/compile-c.h: Rename include guard.
251         * common/xml-utils.h: Rename include guard.
252         * common/x86-xstate.h: Rename include guard.
253         * common/version.h: Rename include guard.
254         * common/vec.h: Rename include guard.
255         * common/tdesc.h: Rename include guard.
256         * common/selftest.h: Rename include guard.
257         * common/scoped_restore.h: Rename include guard.
258         * common/scoped_mmap.h: Rename include guard.
259         * common/scoped_fd.h: Rename include guard.
260         * common/safe-iterator.h: Rename include guard.
261         * common/run-time-clock.h: Rename include guard.
262         * common/refcounted-object.h: Rename include guard.
263         * common/queue.h: Rename include guard.
264         * common/ptid.h: Rename include guard.
265         * common/print-utils.h: Rename include guard.
266         * common/preprocessor.h: Rename include guard.
267         * common/pathstuff.h: Rename include guard.
268         * common/observable.h: Rename include guard.
269         * common/netstuff.h: Rename include guard.
270         * common/job-control.h: Rename include guard.
271         * common/host-defs.h: Rename include guard.
272         * common/gdb_wait.h: Rename include guard.
273         * common/gdb_vecs.h: Rename include guard.
274         * common/gdb_unlinker.h: Rename include guard.
275         * common/gdb_unique_ptr.h: Rename include guard.
276         * common/gdb_tilde_expand.h: Rename include guard.
277         * common/gdb_sys_time.h: Rename include guard.
278         * common/gdb_string_view.h: Rename include guard.
279         * common/gdb_splay_tree.h: Rename include guard.
280         * common/gdb_setjmp.h: Rename include guard.
281         * common/gdb_ref_ptr.h: Rename include guard.
282         * common/gdb_optional.h: Rename include guard.
283         * common/gdb_locale.h: Rename include guard.
284         * common/gdb_assert.h: Rename include guard.
285         * common/filtered-iterator.h: Rename include guard.
286         * common/filestuff.h: Rename include guard.
287         * common/fileio.h: Rename include guard.
288         * common/environ.h: Rename include guard.
289         * common/common-utils.h: Rename include guard.
290         * common/common-types.h: Rename include guard.
291         * common/common-regcache.h: Rename include guard.
292         * common/common-inferior.h: Rename include guard.
293         * common/common-gdbthread.h: Rename include guard.
294         * common/common-exceptions.h: Rename include guard.
295         * common/common-defs.h: Rename include guard.
296         * common/common-debug.h: Rename include guard.
297         * common/cleanups.h: Rename include guard.
298         * common/buffer.h: Rename include guard.
299         * common/btrace-common.h: Rename include guard.
300         * common/break-common.h: Rename include guard.
301         * cli/cli-utils.h: Rename include guard.
302         * cli/cli-style.h: Rename include guard.
303         * cli/cli-setshow.h: Rename include guard.
304         * cli/cli-script.h: Rename include guard.
305         * cli/cli-interp.h: Rename include guard.
306         * cli/cli-decode.h: Rename include guard.
307         * cli/cli-cmds.h: Rename include guard.
308         * charset-list.h: Add include guard.
309         * buildsym-legacy.h: Rename include guard.
310         * bfin-tdep.h: Add include guard.
311         * ax.h: Rename include guard.
312         * arm-linux-tdep.h: Add include guard.
313         * arm-fbsd-tdep.h: Add include guard.
314         * arch/xtensa.h: Rename include guard.
315         * arch/tic6x.h: Add include guard.
316         * arch/i386.h: Add include guard.
317         * arch/arm.h: Rename include guard.
318         * arch/arm-linux.h: Rename include guard.
319         * arch/arm-get-next-pcs.h: Rename include guard.
320         * arch/amd64.h: Add include guard.
321         * arch/aarch64-insn.h: Rename include guard.
322         * arch-utils.h: Rename include guard.
323         * annotate.h: Add include guard.
324         * amd64-darwin-tdep.h: Rename include guard.
325         * aarch64-linux-tdep.h: Add include guard.
326         * aarch64-fbsd-tdep.h: Add include guard.
327         * aarch32-linux-nat.h: Add include guard.
328
329 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
330
331         * macrotab.c (macro_define_internal): New function that
332         factorizes macro_define_object_internal and macro_define_function
333         code.
334         (macro_define_object_internal): Use macro_define_internal.
335         (macro_define_function): Likewise.
336
337 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
338
339         * macrocmd.c (extract_identifier): Return
340         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
341         callers.
342
343 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
344
345         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
346
347 2019-02-05  Tom Tromey  <tom@tromey.com>
348
349         * target.c (target_stack::unpush): Move assertion earlier.
350
351 2019-01-30  Tom Tromey  <tom@tromey.com>
352
353         PR python/23615:
354         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
355         (gdbpy_parse_and_eval): Likewise.
356         * python/python-internal.h (gdbpy_allow_threads): New class.
357
358 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
359
360         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
361         (aarch64_fbsd_fpregmap): Move earlier.
362         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
363         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
364         instead of individual calls to trad_frame_set_reg_addr.
365         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
366         earlier.
367         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
368         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
369         instead of individual calls to trad_frame_set_reg_addr.
370
371 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
372
373         * CONTRIBUTE: Replace contribution list with wiki link.
374
375 2019-01-25  Tom Tromey  <tom@tromey.com>
376
377         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
378
379 2019-01-25  Tom Tromey  <tom@tromey.com>
380
381         * xtensa-linux-nat.c: Fix common/ includes.
382         * xml-support.h: Fix common/ includes.
383         * xml-support.c: Fix common/ includes.
384         * x86-linux-nat.c: Fix common/ includes.
385         * windows-nat.c: Fix common/ includes.
386         * varobj.h: Fix common/ includes.
387         * varobj.c: Fix common/ includes.
388         * value.c: Fix common/ includes.
389         * valops.c: Fix common/ includes.
390         * utils.c: Fix common/ includes.
391         * unittests/xml-utils-selftests.c: Fix common/ includes.
392         * unittests/utils-selftests.c: Fix common/ includes.
393         * unittests/unpack-selftests.c: Fix common/ includes.
394         * unittests/tracepoint-selftests.c: Fix common/ includes.
395         * unittests/style-selftests.c: Fix common/ includes.
396         * unittests/string_view-selftests.c: Fix common/ includes.
397         * unittests/scoped_restore-selftests.c: Fix common/ includes.
398         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
399         * unittests/scoped_fd-selftests.c: Fix common/ includes.
400         * unittests/rsp-low-selftests.c: Fix common/ includes.
401         * unittests/parse-connection-spec-selftests.c: Fix common/
402         includes.
403         * unittests/optional-selftests.c: Fix common/ includes.
404         * unittests/offset-type-selftests.c: Fix common/ includes.
405         * unittests/observable-selftests.c: Fix common/ includes.
406         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
407         * unittests/memrange-selftests.c: Fix common/ includes.
408         * unittests/memory-map-selftests.c: Fix common/ includes.
409         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
410         * unittests/function-view-selftests.c: Fix common/ includes.
411         * unittests/environ-selftests.c: Fix common/ includes.
412         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
413         * unittests/common-utils-selftests.c: Fix common/ includes.
414         * unittests/cli-utils-selftests.c: Fix common/ includes.
415         * unittests/array-view-selftests.c: Fix common/ includes.
416         * ui-file.c: Fix common/ includes.
417         * tui/tui-io.c: Fix common/ includes.
418         * tracepoint.h: Fix common/ includes.
419         * tracepoint.c: Fix common/ includes.
420         * tracefile-tfile.c: Fix common/ includes.
421         * top.h: Fix common/ includes.
422         * top.c: Fix common/ includes.
423         * thread.c: Fix common/ includes.
424         * target/waitstatus.h: Fix common/ includes.
425         * target/waitstatus.c: Fix common/ includes.
426         * target.h: Fix common/ includes.
427         * target.c: Fix common/ includes.
428         * target-memory.c: Fix common/ includes.
429         * target-descriptions.c: Fix common/ includes.
430         * symtab.h: Fix common/ includes.
431         * symfile.c: Fix common/ includes.
432         * stap-probe.c: Fix common/ includes.
433         * spu-linux-nat.c: Fix common/ includes.
434         * sparc-nat.c: Fix common/ includes.
435         * source.c: Fix common/ includes.
436         * solib.c: Fix common/ includes.
437         * solib-target.c: Fix common/ includes.
438         * ser-unix.c: Fix common/ includes.
439         * ser-tcp.c: Fix common/ includes.
440         * ser-pipe.c: Fix common/ includes.
441         * ser-base.c: Fix common/ includes.
442         * selftest-arch.c: Fix common/ includes.
443         * s12z-tdep.c: Fix common/ includes.
444         * rust-exp.y: Fix common/ includes.
445         * rs6000-aix-tdep.c: Fix common/ includes.
446         * riscv-tdep.c: Fix common/ includes.
447         * remote.c: Fix common/ includes.
448         * remote-notif.h: Fix common/ includes.
449         * remote-fileio.h: Fix common/ includes.
450         * remote-fileio.c: Fix common/ includes.
451         * regcache.h: Fix common/ includes.
452         * regcache.c: Fix common/ includes.
453         * record-btrace.c: Fix common/ includes.
454         * python/python.c: Fix common/ includes.
455         * python/py-type.c: Fix common/ includes.
456         * python/py-inferior.c: Fix common/ includes.
457         * progspace.h: Fix common/ includes.
458         * producer.c: Fix common/ includes.
459         * procfs.c: Fix common/ includes.
460         * proc-api.c: Fix common/ includes.
461         * printcmd.c: Fix common/ includes.
462         * ppc-linux-nat.c: Fix common/ includes.
463         * parser-defs.h: Fix common/ includes.
464         * osdata.c: Fix common/ includes.
465         * obsd-nat.c: Fix common/ includes.
466         * nat/x86-linux.c: Fix common/ includes.
467         * nat/x86-linux-dregs.c: Fix common/ includes.
468         * nat/x86-dregs.h: Fix common/ includes.
469         * nat/x86-dregs.c: Fix common/ includes.
470         * nat/ppc-linux.c: Fix common/ includes.
471         * nat/mips-linux-watch.h: Fix common/ includes.
472         * nat/mips-linux-watch.c: Fix common/ includes.
473         * nat/linux-waitpid.c: Fix common/ includes.
474         * nat/linux-ptrace.h: Fix common/ includes.
475         * nat/linux-ptrace.c: Fix common/ includes.
476         * nat/linux-procfs.c: Fix common/ includes.
477         * nat/linux-personality.c: Fix common/ includes.
478         * nat/linux-osdata.c: Fix common/ includes.
479         * nat/linux-namespaces.c: Fix common/ includes.
480         * nat/linux-btrace.h: Fix common/ includes.
481         * nat/linux-btrace.c: Fix common/ includes.
482         * nat/fork-inferior.c: Fix common/ includes.
483         * nat/amd64-linux-siginfo.c: Fix common/ includes.
484         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
485         * nat/aarch64-linux.c: Fix common/ includes.
486         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
487         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
488         * namespace.h: Fix common/ includes.
489         * mips-linux-tdep.c: Fix common/ includes.
490         * minsyms.c: Fix common/ includes.
491         * mi/mi-parse.h: Fix common/ includes.
492         * mi/mi-main.c: Fix common/ includes.
493         * mi/mi-cmd-env.c: Fix common/ includes.
494         * memrange.h: Fix common/ includes.
495         * memattr.c: Fix common/ includes.
496         * maint.h: Fix common/ includes.
497         * maint.c: Fix common/ includes.
498         * main.c: Fix common/ includes.
499         * machoread.c: Fix common/ includes.
500         * location.c: Fix common/ includes.
501         * linux-thread-db.c: Fix common/ includes.
502         * linux-nat.c: Fix common/ includes.
503         * linux-fork.c: Fix common/ includes.
504         * inline-frame.c: Fix common/ includes.
505         * infrun.c: Fix common/ includes.
506         * inflow.c: Fix common/ includes.
507         * inferior.h: Fix common/ includes.
508         * inferior.c: Fix common/ includes.
509         * infcmd.c: Fix common/ includes.
510         * inf-ptrace.c: Fix common/ includes.
511         * inf-child.c: Fix common/ includes.
512         * ia64-linux-nat.c: Fix common/ includes.
513         * i387-tdep.c: Fix common/ includes.
514         * i386-tdep.c: Fix common/ includes.
515         * i386-linux-tdep.c: Fix common/ includes.
516         * i386-linux-nat.c: Fix common/ includes.
517         * i386-go32-tdep.c: Fix common/ includes.
518         * i386-fbsd-tdep.c: Fix common/ includes.
519         * i386-fbsd-nat.c: Fix common/ includes.
520         * guile/scm-type.c: Fix common/ includes.
521         * guile/guile.c: Fix common/ includes.
522         * go32-nat.c: Fix common/ includes.
523         * gnu-nat.c: Fix common/ includes.
524         * gdbthread.h: Fix common/ includes.
525         * gdbarch-selftests.c: Fix common/ includes.
526         * gdb_usleep.c: Fix common/ includes.
527         * gdb_select.h: Fix common/ includes.
528         * gdb_bfd.c: Fix common/ includes.
529         * gcore.c: Fix common/ includes.
530         * fork-child.c: Fix common/ includes.
531         * findvar.c: Fix common/ includes.
532         * fbsd-nat.c: Fix common/ includes.
533         * event-top.c: Fix common/ includes.
534         * event-loop.c: Fix common/ includes.
535         * dwarf2read.c: Fix common/ includes.
536         * dwarf2loc.c: Fix common/ includes.
537         * dwarf2-frame.c: Fix common/ includes.
538         * dwarf-index-cache.c: Fix common/ includes.
539         * dtrace-probe.c: Fix common/ includes.
540         * disasm-selftests.c: Fix common/ includes.
541         * defs.h: Fix common/ includes.
542         * csky-tdep.c: Fix common/ includes.
543         * cp-valprint.c: Fix common/ includes.
544         * cp-support.h: Fix common/ includes.
545         * cp-support.c: Fix common/ includes.
546         * corelow.c: Fix common/ includes.
547         * completer.h: Fix common/ includes.
548         * completer.c: Fix common/ includes.
549         * compile/compile.c: Fix common/ includes.
550         * compile/compile-loc2c.c: Fix common/ includes.
551         * compile/compile-cplus-types.c: Fix common/ includes.
552         * compile/compile-cplus-symbols.c: Fix common/ includes.
553         * command.h: Fix common/ includes.
554         * cli/cli-dump.c: Fix common/ includes.
555         * cli/cli-cmds.c: Fix common/ includes.
556         * charset.c: Fix common/ includes.
557         * build-id.c: Fix common/ includes.
558         * btrace.h: Fix common/ includes.
559         * btrace.c: Fix common/ includes.
560         * breakpoint.h: Fix common/ includes.
561         * breakpoint.c: Fix common/ includes.
562         * ax.h: 
563         (enum agent_op): Fix common/ includes.
564         * ax-general.c (struct aop_map): Fix common/ includes.
565         * ax-gdb.c: Fix common/ includes.
566         * auxv.c: Fix common/ includes.
567         * auto-load.c: Fix common/ includes.
568         * arm-tdep.c: Fix common/ includes.
569         * arch/riscv.c: Fix common/ includes.
570         * arch/ppc-linux-common.c: Fix common/ includes.
571         * arch/i386.c: Fix common/ includes.
572         * arch/arm.c: Fix common/ includes.
573         * arch/arm-linux.c: Fix common/ includes.
574         * arch/arm-get-next-pcs.c: Fix common/ includes.
575         * arch/amd64.c: Fix common/ includes.
576         * arch/aarch64.c: Fix common/ includes.
577         * arch/aarch64-insn.c: Fix common/ includes.
578         * arch-utils.c: Fix common/ includes.
579         * amd64-windows-tdep.c: Fix common/ includes.
580         * amd64-tdep.c: Fix common/ includes.
581         * amd64-sol2-tdep.c: Fix common/ includes.
582         * amd64-obsd-tdep.c: Fix common/ includes.
583         * amd64-nbsd-tdep.c: Fix common/ includes.
584         * amd64-linux-tdep.c: Fix common/ includes.
585         * amd64-linux-nat.c: Fix common/ includes.
586         * amd64-fbsd-tdep.c: Fix common/ includes.
587         * amd64-fbsd-nat.c: Fix common/ includes.
588         * amd64-dicos-tdep.c: Fix common/ includes.
589         * amd64-darwin-tdep.c: Fix common/ includes.
590         * agent.c: Fix common/ includes.
591         * ada-lang.h: Fix common/ includes.
592         * ada-lang.c: Fix common/ includes.
593         * aarch64-tdep.c: Fix common/ includes.
594
595 2019-01-25  Tom Tromey  <tom@tromey.com>
596
597         * common/create-version.sh: Use common/version.h.
598
599 2019-01-24  Pedro Alves  <palves@redhat.com>
600
601         * infrun.c (signal_stop, signal_print, signal_program)
602         (signal_catch, signal_pass): Now arrays instead of pointers.
603         (update_signals_program_target, do_target_resume)
604         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
605         * linux-nat.c (linux_nat_target::pass_signals)
606         (linux_nat_target::create_inferior, linux_nat_target::attach):
607         Adjust.
608         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
609         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
610         * procfs.c (procfs_target::pass_signals): Adjust.
611         * record-full.c (record_full_target::resume): Adjust.
612         * remote.c (remote_target::pass_signals)
613         (remote_target::program_signals): Adjust.
614         * target-debug.h (target_debug_print_signals): Now takes a
615         gdb::array_view as parameter.  Adjust.
616         * target.h (target_ops) <pass_signals, program_signals>: Replace
617         pointer and length parameters with gdb::array_view.
618         (target_pass_signals, target_program_signals): Likewise.
619         * target-delegates.c: Regenerate.
620
621 2019-01-24  Pedro Alves  <palves@redhat.com>
622
623         * common/forward-scope-exit.h
624         (forward_scope_exit::forward_scope_exit): Pass arguments to
625         m_bind_function directly, instead of creating a std::bind and
626         copying that.
627
628 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
629
630         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
631         for static members.
632         (pass_in_v_vfp_candidate): Likewise.
633
634 2019-01-23  Tom Tromey  <tom@tromey.com>
635             Pedro Alves  <palves@redhat.com>
636
637         * regcache.c (class regcache_invalidator): Remove.
638         (regcache::raw_write): Use make_scope_exit.
639
640 2019-01-23  Tom Tromey  <tom@tromey.com>
641
642         * ui-out.h (class ui_out_emit_type): Update comment.
643
644 2019-01-23  Tom Tromey  <tom@tromey.com>
645
646         * infrun.c (fetch_inferior_event): Update comment.
647
648 2019-01-23  Tom Tromey  <tom@tromey.com>
649             Pedro Alves  <palves@redhat.com>
650
651         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
652         parameter.
653         (fetch_inferior_event): Use SCOPE_EXIT.
654
655
656 2019-01-23  Tom Tromey  <tom@tromey.com>
657             Pedro Alves  <palves@redhat.com>
658
659         * infrun.c (disable_thread_events): Delete.
660         (stop_all_threads): Use SCOPE_EXIT.
661
662 2019-01-23  Tom Tromey  <tom@tromey.com>
663             Pedro Alves  <palves@redhat.com>
664
665         * symfile.c: Include forward-scope-exit.h.
666         (clear_symtab_users_cleanup): Replace forward declaration with
667         a FORWARD_SCOPE_EXIT.
668         (syms_from_objfile_1): Use the forward_scope_exit and
669         gdb::optional instead of cleanup_function.
670         (reread_symbols): Use the forward_scope_exit instead of
671         cleanup_function.
672         (clear_symtab_users_cleanup): Remove function.
673
674 2019-01-23  Tom Tromey  <tom@tromey.com>
675             Pedro Alves  <palves@redhat.com>
676
677         * linux-nat.c: Include scope-exit.h.
678         (cleanup_target_stop): Remove.
679         (linux_nat_target::static_tracepoint_markers_by_strid): Use
680         SCOPE_EXIT.
681
682 2019-01-23  Tom Tromey  <tom@tromey.com>
683             Pedro Alves  <palves@redhat.com>
684
685         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
686         (call_function_by_hand_dummy): Use SCOPE_EXIT.
687
688 2019-01-23  Tom Tromey  <tom@tromey.com>
689             Andrew Burgess  <andrew.burgess@embecosm.com>
690             Pedro Alves  <palves@redhat.com>
691
692         * infrun.c (fetch_inferior_event): Use scope_exit.
693         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
694         * top.c (execute_command): Use scope_exit.
695         * breakpoint.c (bpstat_do_actions): Use scope_exit.
696         * utils.c (do_bpstat_clear_actions_cleanup)
697         (make_bpstat_clear_actions_cleanup): Remove.
698
699 2019-01-23  Tom Tromey  <tom@tromey.com>
700             Pedro Alves  <palves@redhat.com>
701
702         * infrun.c: Include "common/scope-exit.h"
703         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
704         (wait_for_inferior): Use SCOPE_EXIT.
705         (fetch_inferior_event): Use scope_exit.
706
707 2019-01-23  Tom Tromey  <tom@tromey.com>
708             Pedro Alves  <palves@redhat.com>
709
710         * breakpoint.c (create_breakpoint): Remove cleanup.
711
712 2019-01-23  Tom Tromey  <tom@tromey.com>
713             Andrew Burgess  <andrew.burgess@embecosm.com>
714             Pedro Alves  <palves@redhat.com>
715
716 2019-01-23  Pedro Alves  <palves@redhat.com>
717
718         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
719
720 2019-01-23  Pedro Alves  <palves@redhat.com>
721             Andrew Burgess  <andrew.burgess@embecosm.com>
722
723         * gdbthread.h: Include "common/forward-scope-exit.h".
724         (scoped_finish_thread_state): Redefine custom class in terms of
725         forward_scope_exit.
726
727 2019-01-23  Pedro Alves  <palves@redhat.com>
728             Andrew Burgess  <andrew.burgess@embecosm.com>
729
730         * common/forward-scope-exit.h: New file.
731
732 2019-01-23  Pedro Alves  <palves@redhat.com>
733             Andrew Burgess  <andrew.burgess@embecosm.com>
734             Tom Tromey  <tom@tromey.com>
735
736         * common/scope-exit.h: New file.
737
738 2019-01-23  Pedro Alves  <palves@redhat.com>
739
740         * common/preprocessor.h (ESC): Rename to ...
741         (ESC_PARENS): ... this.
742         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
743         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
744
745 2019-01-23  Tom Tromey  <tom@tromey.com>
746
747         * language.h (class scoped_switch_to_sym_language_if_auto):
748         Initialize m_lang in both cases.
749
750 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
751
752         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
753         with XCNEW.
754
755 2019-01-22  Tom Tromey  <tom@tromey.com>
756
757         * corelow.c: Do not include sys/file.h.
758
759 2019-01-22  Tom Tromey  <tom@tromey.com>
760
761         * tui/tui-wingeneral.h: Include gdb_curses.h.
762
763 2019-01-22  Tom Tromey  <tom@tromey.com>
764
765         * source-cache.h (class source_cache) <get_source_lines,
766         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
767
768 2019-01-22  Tom Tromey  <tom@tromey.com>
769
770         * remote-fileio.h (struct remote_target): Declare.
771
772 2019-01-22  Tom Tromey  <tom@tromey.com>
773
774         * python/py-arch.c: Do not include py-ref.h.
775         * python/py-bpevent.c: Do not include py-ref.h.
776         * python/py-cmd.c: Do not include py-ref.h.
777         * python/py-continueevent.c: Do not include py-ref.h.
778         * python/py-event.h: Do not include py-ref.h.
779         * python/py-evtregistry.c: Do not include py-ref.h.
780         * python/py-finishbreakpoint.c: Do not include py-ref.h.
781         * python/py-frame.c: Do not include py-ref.h.
782         * python/py-framefilter.c: Do not include py-ref.h.
783         * python/py-function.c: Do not include py-ref.h.
784         * python/py-infevents.c: Do not include py-ref.h.
785         * python/py-linetable.c: Do not include py-ref.h.
786         * python/py-objfile.c: Do not include py-ref.h.
787         * python/py-param.c: Do not include py-ref.h.
788         * python/py-prettyprint.c: Do not include py-ref.h.
789         * python/py-progspace.c: Do not include py-ref.h.
790         * python/py-symbol.c: Do not include py-ref.h.
791         * python/py-symtab.c: Do not include py-ref.h.
792         * python/py-type.c: Do not include py-ref.h.
793         * python/py-unwind.c: Do not include py-ref.h.
794         * python/py-utils.c: Do not include py-ref.h.
795         * python/py-value.c: Do not include py-ref.h.
796         * python/py-varobj.c: Do not include py-ref.h.
797         * python/py-xmethods.c: Do not include py-ref.h.
798         * python/python.c: Do not include py-ref.h.
799         * varobj.c: Do not include py-ref.h.
800
801 2019-01-22  Tom Tromey  <tom@tromey.com>
802
803         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
804         keyword for bcache.
805
806 2019-01-22  Tom Tromey  <tom@tromey.com>
807
808         * compile/compile-cplus-types.c: Remove a comment by #include.
809
810 2019-01-22  Tom Tromey  <tom@tromey.com>
811
812         * compile/gcc-c-plugin.h: Include compile-internal.h.
813
814 2019-01-22  Tom Tromey  <tom@tromey.com>
815
816         * stabsread.c (EXTERN): Do not define.
817         (symnum, next_symbol_text_func, processing_gcc_compilation)
818         (within_function, global_sym_chain, global_stabs)
819         (previous_stab_code, this_object_header_files)
820         (n_this_object_header_files)
821         (n_allocated_this_object_header_files): Define.
822         * stabsread.h (EXTERN): Never define.  Use "extern".
823
824 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
825
826         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
827         history_value.
828
829 2019-01-21  Tom Tromey  <tom@tromey.com>
830
831         * ui-out.c: Fix includes.
832         * tui/tui-source.c: Fix includes.
833         * target.c: Fix includes.
834         * remote.c: Fix includes.
835         * regcache.c: Fix includes.
836         * python/py-block.c: Fix includes.
837         * printcmd.c: Fix includes.
838         * or1k-tdep.c: Fix includes.
839         * mi/mi-main.c: Fix includes.
840         * m32r-tdep.c: Fix includes.
841         * csky-tdep.c: Fix includes.
842         * compile/compile-cplus-types.c: Fix includes.
843         * cli/cli-interp.c: Fix includes.
844
845 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
846
847         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
848         for padding.
849
850 2019-01-16  Tom Tromey  <tom@tromey.com>
851
852         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
853         earlier.
854         (struct objfile) <msymbols_range>: Move from top level.
855         <msymbols>: New method.
856         (class objfile_msymbols): Remove.
857         * symtab.c (default_collect_symbol_completion_matches_break_on):
858         Update.
859         * symmisc.c (dump_msymbols): Update.
860         * stabsread.c (scan_file_globals): Update.
861         * objc-lang.c (info_selectors_command, info_classes_command)
862         (find_methods): Update.
863         * minsyms.c (find_solib_trampoline_target): Update.
864         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
865         * coffread.c (coff_symfile_read): Update.
866         * ada-lang.c (ada_lookup_simple_minsym)
867         (ada_collect_symbol_completion_matches): Update.
868
869 2019-01-16  Tom Tromey  <tom@tromey.com>
870
871         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
872         type.  Remove no-argument constructor.
873         <iterator::operator++>: Simplify.
874         <begin>: Update.
875         <end>: Use minimal_symbol_count.
876
877 2019-01-16  Tom Tromey  <tom@tromey.com>
878
879         * objfiles.h (struct objfile) <psymtabs>: New method.
880         (class objfile_psymtabs): Remove.
881         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
882         typedef.
883         <range>: New method.
884         (require_partial_symbols): Change return type.
885         * psymtab.c (require_partial_symbols)
886         (psym_expand_symtabs_matching): Update.
887         * mdebugread.c (parse_partial_symbols): Update.
888         * dbxread.c (dbx_end_psymtab): Update.
889
890 2019-01-15  Tom Tromey  <tom@tromey.com>
891
892         * symtab.c (lookup_objfile_from_block)
893         (lookup_symbol_in_objfile_symtabs)
894         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
895         (find_line_symtab, info_sources_command)
896         (default_collect_symbol_completion_matches_break_on)
897         (make_source_files_completion_list): Update.
898         * symmisc.c (print_objfile_statistics, dump_objfile)
899         (maintenance_print_symbols, maintenance_info_symtabs)
900         (maintenance_check_symtabs, maintenance_info_line_tables):
901         Update.
902         * source.c (select_source_symtab)
903         (forget_cached_source_info_for_objfile): Update.
904         * objfiles.h (class objfile_compunits): Remove.
905         (struct objfile) <compunits_range>: New typedef.
906         (compunits): New method.
907         * objfiles.c (objfile_relocate1): Update.
908         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
909         * maint.c (count_symtabs_and_blocks): Update.
910         * linespec.c (iterate_over_all_matching_symtabs): Update.
911         * cp-support.c (add_symbol_overload_list_qualified): Update.
912         * coffread.c (coff_symtab_read): Update.
913         * ada-lang.c (add_nonlocal_symbols)
914         (ada_collect_symbol_completion_matches)
915         (ada_add_global_exceptions): Update.
916
917 2019-01-15  Tom Tromey  <tom@tromey.com>
918
919         * progspace.h (program_space) <objfiles_safe_range>: New
920         typedef.
921         <objfiles_safe>: New method.
922         * objfiles.h (class all_objfiles_safe): Remove.
923         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
924         * jit.c (jit_inferior_exit_hook): Update.
925
926 2019-01-17  Tom Tromey  <tom@tromey.com>
927
928         * progspace.h (program_space) <objfiles_range>: New typedef.
929         <objfiles>: New method.
930         <objfiles_head>: Rename from objfiles.
931         (object_files): Update.
932         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
933         * guile/scm-pretty-print.c
934         (ppscm_find_pretty_printer_from_objfiles): Update.
935         * guile/scm-objfile.c (gdbscm_objfiles): Update.
936         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
937         Update.
938         * python/py-progspace.c (pspy_get_objfiles): Update.
939         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
940         Update.
941         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
942         (objfpy_lookup_objfile_by_build_id): Update.
943         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
944         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
945         Update.
946         * symtab.c (iterate_over_symtabs, matching_obj_sections)
947         (expand_symtab_containing_pc, lookup_objfile_from_block)
948         (lookup_static_symbol, basic_lookup_transparent_type)
949         (find_pc_sect_compunit_symtab, find_symbol_at_address)
950         (find_line_symtab, info_sources_command)
951         (default_collect_symbol_completion_matches_break_on)
952         (make_source_files_completion_list, find_main_name): Update.
953         * symmisc.c (print_symbol_bcache_statistics)
954         (print_objfile_statistics, maintenance_print_symbols)
955         (maintenance_print_msymbols, maintenance_print_objfiles)
956         (maintenance_info_symtabs, maintenance_check_symtabs)
957         (maintenance_expand_symtabs, maintenance_info_line_tables):
958         Update.
959         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
960         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
961         (map_overlay_command, unmap_overlay_command)
962         (simple_overlay_update, expand_symtabs_matching)
963         (map_symbol_filenames): Update.
964         * symfile-debug.c (set_debug_symfile): Update.
965         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
966         Update.
967         * source.c (select_source_symtab, forget_cached_source_info):
968         Update.
969         * solib.c (solib_read_symbols): Update.
970         * solib-spu.c (append_ocl_sos): Update.
971         * psymtab.c (maintenance_print_psymbols)
972         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
973         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
974         * printcmd.c (info_symbol_command): Update.
975         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
976         Update.
977         * objfiles.h (class all_objfiles): Remove.
978         * objfiles.c (have_partial_symbols, have_full_symbols)
979         (have_minimal_symbols, qsort_cmp, update_section_map)
980         (shared_objfile_contains_address_p)
981         (default_iterate_over_objfiles_in_search_order): Update.
982         * objc-lang.c (info_selectors_command, info_classes_command)
983         (find_methods): Update.
984         * minsyms.c (find_solib_trampoline_target): Update.
985         * maint.c (maintenance_info_sections)
986         (maintenance_translate_address, count_symtabs_and_blocks):
987         Update.
988         * main.c (captured_main_1): Update.
989         * linux-thread-db.c (try_thread_db_load_from_pdir)
990         (has_libpthread): Update.
991         * linespec.c (iterate_over_all_matching_symtabs)
992         (search_minsyms_for_name): Update.
993         * jit.c (jit_find_objf_with_entry_addr): Update.
994         * hppa-tdep.c (find_unwind_entry)
995         (hppa_lookup_stub_minimal_symbol): Update.
996         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
997         Update.
998         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
999         (elf_gnu_ifunc_resolve_by_got): Update.
1000         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1001         * dwarf-index-write.c (save_gdb_index_command): Update.
1002         * cp-support.c (add_symbol_overload_list_qualified): Update.
1003         * breakpoint.c (create_overlay_event_breakpoint)
1004         (create_longjmp_master_breakpoint)
1005         (create_std_terminate_master_breakpoint)
1006         (create_exception_master_breakpoint): Update.
1007         * blockframe.c (find_pc_partial_function): Update.
1008         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1009         (ada_collect_symbol_completion_matches)
1010         (ada_add_global_exceptions): Update.
1011
1012 2019-01-17  Tom Tromey  <tom@tromey.com>
1013
1014         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1015         declare VEC.
1016         (solib_target_parse_libraries): Change return type.
1017         (library_list_start_segment, library_list_start_section)
1018         (library_list_end_library, library_list_start_library); Update.
1019         (solib_target_free_library_list): Remove.
1020         (solib_target_parse_libraries): Remove cleanup.  Change return
1021         type.
1022         (solib_target_current_sos): Update.
1023
1024 2019-01-17  Tom Tromey  <tromey@bapiya>
1025
1026         * valprint.c: Replace "the the" with "the".
1027         * symtab.c: Replace "the the" with "the".
1028         * solib.c: Replace "the the" with "the".
1029         * solib-dsbt.c: Replace "the the" with "the".
1030         * linespec.c: Replace "the the" with "the".
1031         * dwarf2loc.h: Replace "the the" with "the".
1032         * amd64-windows-tdep.c: Replace "the the" with "the".
1033         * aarch64-tdep.c: Replace "the the" with "the".
1034
1035 2019-01-16  Keith Seitz  <keiths@redhat.com>
1036
1037         PR gdb/23773
1038         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1039         <builder>: Rename to ..
1040         <m_builder>: ... this and make private.
1041         (dwarf2_cu::get_builder): New method.  Change all users of
1042         `builder' to use this method.
1043         (dwarf2_start_symtab): Move to ...
1044         (dwarf2_cu::start_symtab): ... here.  Update all callers
1045         (setup_type_unit_groups): Move to ...
1046         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1047         callers.
1048         (dwarf2_cu::reset_builder): New method.
1049         (process_full_compunit, process_full_type_unit): Use
1050         dwarf2_cu::reset_builder.
1051         (follow_die_offset): Record the ancestor CU if it is different
1052         from the followed DIE's CU.
1053         (follow_die_sig_1): Likewise.
1054
1055 2019-01-15  Tom Tromey  <tom@tromey.com>
1056
1057         * remote.c (class remote_state) <buf>: Now a char_vector.
1058         <buf_size>: Remove.
1059         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1060         parameter.
1061         (remote_target::getpkt_or_notif_sane_1)
1062         (remote_target::getpkt_sane)
1063         (remote_target::getpkt_or_notif_sane): Likewise.
1064         (class remote_target) <putpkt>: New overload.
1065         (remote_target::read_frame): Change type of "buf_p".  Remove
1066         sizeof_p parameter.
1067         (packet_ok): New overload.
1068         (packet_check_result): New overload.
1069         Update all uses.
1070
1071 2019-01-14  Tom Tromey  <tom@tromey.com>
1072
1073         * remote-notif.c (handle_notification, remote_notif_ack)
1074         (remote_notif_parse): Make "buf" const.
1075         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1076         const.
1077         (remote_notif_parse, remote_notif_ack, handle_notification):
1078         Likewise.
1079         * remote.c (remote_notif_stop_parse): Make "buf" const.
1080         (remote_target::remote_parse_stop_reply): Make "buf" const.
1081         (remote_notif_stop_ack): Make "buf" const.
1082
1083 2019-01-14  Tom Tromey  <tom@tromey.com>
1084
1085         * remote.c (remote_console_output): Make parameter const.
1086
1087 2019-01-14  Tom Tromey  <tom@tromey.com>
1088
1089         * target-debug.h (target_debug_print_signals): Constify.
1090         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1091         * procfs.c (procfs_target::pass_signals): Update.
1092         * linux-nat.c (linux_nat_target::pass_signals): Update.
1093         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1094         * target-delegates.c: Rebuild.
1095         * remote.c (remote_target::program_signals): Update.
1096         (remote_target::pass_signals): Update.
1097         * target.c (target_pass_signals): Constify argument.
1098         (target_program_signals): Likewise.
1099         * target.h (struct target_ops) <pass_signals, program_signals>:
1100         Constify argument.
1101         (target_pass_signals, target_program_signals): Constify argument.
1102
1103 2019-01-14  Tom Tromey  <tom@tromey.com>
1104
1105         PR tui/28819:
1106         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1107
1108 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1109
1110         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1111         field.
1112         * rs6000-tdep.c: Include reggroups.h.
1113         (IS_V_ALIAS_PSEUDOREG): Define.
1114         (rs6000_register_name): Return names for the "vX" aliases.
1115         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1116         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1117         aliases.  Call default_register_reggroup_p for all other
1118         pseudo-registers.
1119         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1120         New functions.
1121         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1122         Handle "vX" aliases.
1123         (v_alias_pseudo_register_collect): New function.
1124         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1125         (rs6000_gdbarch_init): Initialize "vX" aliases as
1126         pseudo-registers.  Restore registration of
1127         rs6000_pseudo_register_reggroup_p with
1128         set_tdesc_pseudo_register_reggroup_p.
1129
1130 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1131
1132         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1133         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1134         set_gdbarch_num_pseudo_regs.
1135
1136 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1137
1138         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1139         Remove arg prefixname, add do_set and do_show.
1140         Add member functions set_list and show_list.
1141         * cli/cli-style.c (class cli_style_option): Update accordingly.
1142         (style_set_list): Move to file scope.
1143         (style_show_list): Likewise.
1144         (set_style): Call help_list.
1145         (show_style): Call cmd_show_list.
1146         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1147         Update to use the new macro.
1148
1149 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1150
1151         * ada-lang.c (_initialize_ada_language): Expand the help text
1152         for the "catch exception" command.
1153
1154 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1155
1156         * symtab.c (matching_obj_sections): Initialize obj,
1157         declare it closer to its usage.
1158
1159 2019-01-10  Tom Tromey  <tom@tromey.com>
1160
1161         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1162         (basic_inf_threads_range): Remove.
1163         (inf_threads_range, inf_non_exited_threads_range)
1164         (safe_inf_threads_range): Use next_adapter.
1165
1166 2019-01-10  Keith Seitz  <keiths@redhat.com>
1167
1168         PR gdb/23712
1169         PR symtab/23010
1170         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1171         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1172
1173 2019-01-10  Keith Seitz  <keiths@redhat.com>
1174
1175         PR gdb/23712
1176         PR symtab/23010
1177         * dictionary.c (pending_to_vector): Remove.
1178         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1179         Remove _1 suffix, replacing functions of the same name.  Update
1180         all callers.
1181         (dict_create_hashed, dict_create_hashed_expandable)
1182         (dict_create_linear, dict_create_linear_expandable, dict_free)
1183         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1184         Make functions static.
1185
1186 2019-01-10  Keith Seitz  <keiths@redhat.com>
1187
1188         PR gdb/23712
1189         PR symtab/23010
1190         * dictionary.h (struct dictionary): Replace declaration with
1191         multidictionary.
1192         (dict_create_hashed, dict_create_hashed_expandable)
1193         (dict_create_linear, dict_create_linear_expandable)
1194         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1195         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1196         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1197         taking multidictionary argument.
1198         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1199         * block.h (struct block) <dict>: Change to multidictionary
1200         and rename `multidict'.
1201         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1202         symmisc.c: Update all dictionary references to multidictionary.
1203
1204 2019-01-10  Keith Seitz  <keiths@redhat.com>
1205
1206         PR gdb/23712
1207         PR symtab/23010
1208         * dictionary.c: Include unordered_map.
1209         (pending_to_vector): New function.
1210         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1211         Rewrite the non-"_1" functions to take vector instead
1212         of linked list.
1213         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1214         "new" _1 versions of the same name.
1215         (multidictionary): Define.
1216         (std::hash<enum language): New definition.
1217         (collate_pending_symbols_by_language, mdict_create_hashed)
1218         (mdict_create_hashed_expandable, mdict_create_linear)
1219         (mdict_create_linear_expandable, mdict_free)
1220         (find_language_dictionary, create_new_language_dictionary)
1221         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1222         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1223         (mdict_size, mdict_empty): New functions.
1224         * dictionary.h (mdict_iterator): Define.
1225
1226 2019-01-10  Pedro Alves  <palves@redhat.com>
1227
1228         * breakpoint.c (read_uploaded_action)
1229         (create_tracepoint_from_upload): Adjust to use
1230         gdb::unique_xmalloc_ptr.
1231         * ctf.c (ctf_write_uploaded_tp):
1232         (SET_ARRAY_FIELD): Use emplace_back.
1233         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1234         * tracefile-tfile.c (tfile_write_uploaded_tp):
1235         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1236         gdb::unique_xmalloc_ptr.
1237         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1238         at_string, cond_string, cmd_strings>: Replace char pointers
1239         with gdb::unique_xmalloc_ptr.
1240
1241 2019-01-10  Pedro Alves  <palves@redhat.com>
1242
1243         * solib-target.c (library_list_start_library): Don't xstrdup name.
1244
1245 2019-01-10  Pedro Alves  <palves@redhat.com>
1246
1247         * mdebugread.c (parse_partial_symbols): Use
1248         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1249
1250 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1251
1252         * linux-fork.c (scoped_switch_fork_info)
1253         <~scoped_switch_fork_info>: Fix incorrect variable name.
1254
1255 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * linux-fork.c (scoped_switch_fork_info)
1258         <scoped_switch_fork_info>: Make explicit.
1259         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1260
1261 2019-01-10  Tom Tromey  <tom@tromey.com>
1262
1263         * objfiles.h (objfile::reset_psymtabs): Update.
1264         * objfiles.c (objfile::objfile): Update.
1265         * psymtab.h (psymtab_storage::obstack): Update.
1266         (psymtab_storage::m_obstack): Use gdb::optional.
1267         (class psymtab_storage): Update comment.  Remove objfile
1268         parameter.
1269         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1270
1271 2019-01-10  Tom Tromey  <tom@tromey.com>
1272
1273         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1274         <free_psymtabs>: Now private.
1275         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1276         (allocate_psymtab): Use new method.
1277
1278 2019-01-10  Tom Tromey  <tom@tromey.com>
1279
1280         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1281         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1282         * mdebugread.c (parse_partial_symbols): Use
1283         allocate_dependencies.
1284         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1285         allocate_dependencies.
1286         (process_psymtab_comp_unit_reader)
1287         (build_type_psymtab_dependencies): Likewise.
1288         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1289
1290 2019-01-10  Tom Tromey  <tom@tromey.com>
1291
1292         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1293         PSYMBOL_SET_LANGUAGE.
1294         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1295
1296 2019-01-10  Tom Tromey  <tom@tromey.com>
1297
1298         * psymtab.h (psymtab_storage::obstack): New method.
1299         <m_obstack>: Rename from obstack; now private.
1300         * psymtab.c (psymtab_storage): Update.
1301         * dwarf2read.c (create_addrmap_from_index)
1302         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1303         Update.
1304
1305 2019-01-10  Tom Tromey  <tom@tromey.com>
1306
1307         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1308         * objfiles.h (objfile::reset_psymtabs): New method.
1309
1310 2019-01-10  Tom Tromey  <tom@tromey.com>
1311
1312         * symmisc.c (print_symbol_bcache_statistics): Update.
1313         (print_objfile_statistics): Update.
1314         * symfile.c (reread_symbols): Update.
1315         * psymtab.h (class psymtab_storage): New.
1316         * psymtab.c (psymtab_storage): New constructor.
1317         (~psymtab_storage): New destructor.
1318         (require_partial_symbols): Update.
1319         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1320         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1321         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1322         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1323         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1324         (start_psymtab_common, end_psymtab_common)
1325         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1326         (allocate_psymtab): Update.
1327         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1328         Update.
1329         (dump_psymtab_addrmap, maintenance_print_psymbols)
1330         (maintenance_check_psymtabs): Update.
1331         (class objfile_psymtabs): Move to objfiles.h.
1332         * psympriv.h (discard_psymtab): Now inline.
1333         (psymtab_discarder::psymtab_discarder): Update.
1334         (psymtab_discarder::~psymtab_discarder): Update.
1335         (ALL_OBJFILE_PSYMTABS): Rewrite.
1336         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1337         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1338         Remove fields.
1339         <partial_symtabs>: New field.
1340         (class objfile_psymtabs): Move from psymtab.h.  Update.
1341         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1342         psymbol_cache.
1343         (objfile::~objfile): Don't destroy psymbol_cache.
1344         * mdebugread.c (parse_partial_symbols): Update.
1345         * dwarf2read.c (create_addrmap_from_index)
1346         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1347         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1348         (add_partial_subprogram, dwarf2_ranges_read): Update.
1349         * dwarf-index-write.c (write_address_map)
1350         (write_one_signatured_type, recursively_write_psymbols)
1351         (class debug_names, class debug_names, write_psymtabs_to_index):
1352         Update.
1353
1354 2019-01-10  Tom Tromey  <tom@tromey.com>
1355
1356         * symtab.h (SYMBOL_SET_NAMES): Update.
1357         (symbol_set_names): Update.
1358         (MSYMBOL_SET_NAMES): Update.
1359         * symtab.c (symbol_set_names): Change argument to be an
1360         objfile_per_bfd_storage.
1361         * psymtab.c (add_psymbol_to_bcache): Update.
1362         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1363
1364 2019-01-10  Tom Tromey  <tom@tromey.com>
1365
1366         * symtab.c (create_demangled_names_hash): Change argument to be an
1367         objfile_per_bfd_storage.
1368         (symbol_set_names): Update.
1369
1370 2019-01-10  Tom Tromey  <tom@tromey.com>
1371
1372         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1373         init_psymbol_list.
1374         * psymtab.c (init_psymbol_list): Do nothing if already called.
1375         * psympriv.h (init_psymbol_list): Add comment.
1376         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1377         init_psymbol_list.
1378         * dbxread.c (dbx_symfile_read): Unconditionally call
1379         init_psymbol_list.
1380
1381 2019-01-10  Tom Tromey  <tom@tromey.com>
1382
1383         * xcoffread.c (scan_xcoff_symtab): Update.
1384         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1385         "where".
1386         * mdebugread.c (parse_partial_symbols)
1387         (handle_psymbol_enumerators): Update.
1388         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1389         * dbxread.c (read_dbx_symtab): Update.
1390         * psympriv.h (psymbol_placement): New enum.
1391         (add_psymbol_to_list): Update.
1392
1393 2019-01-10  Tom Tromey  <tom@tromey.com>
1394
1395         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1396         static_psymbols parameters.
1397         (scan_xcoff_symtab): Update.
1398         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1399         static_psymbols parameters.
1400         * psympriv.h (start_psymtab_common): Update.
1401         * mdebugread.c (parse_partial_symbols): Update.
1402         * dwarf2read.c (create_partial_symtab): Update.
1403         * dbxread.c (read_dbx_symtab): Update.
1404         (start_psymtab): Remove global_psymbols and static_psymbols
1405         parameters.
1406
1407 2019-01-10  Tom Tromey  <tom@tromey.com>
1408
1409         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1410         * psymtab.c (allocate_psymtab): Add comment.
1411         * psympriv.h (allocate_psymtab): Add comment.
1412         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1413         initializations.
1414         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1415
1416 2019-01-10  Tom Tromey  <tom@tromey.com>
1417
1418         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1419         Don't declare.
1420         * mipsread.c: Include mdebugread.h.
1421         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1422         Declare.
1423         * elfread.c: Include mdebugread.h.
1424
1425 2019-01-09  Tom Tromey  <tom@tromey.com>
1426
1427         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1428         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1429         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1430         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1431         (psym_lookup_symbol, psym_find_last_source_symtab)
1432         (psym_forget_cached_source_info, psym_print_stats)
1433         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1434         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1435         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1436         (psym_find_compunit_symtab_by_address)
1437         (maintenance_print_psymbols, maintenance_info_psymtabs)
1438         (maintenance_check_psymtabs): Use ranged for.
1439         * psymtab.h (class objfile_psymtabs): New.
1440         (require_partial_symbols): Return objfile_psymtabs.
1441         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1442
1443 2019-01-09  Tom Tromey  <tom@tromey.com>
1444
1445         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1446         (find_pc_mapped_section, list_overlays_command)
1447         (map_overlay_command, unmap_overlay_command)
1448         (simple_overlay_update): Use all_objfiles.
1449         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1450         * printcmd.c (info_symbol_command): Use all_objfiles.
1451         * objfiles.h (ALL_OBJSECTIONS): Remove.
1452         * maint.c (maintenance_translate_address): Use all_objfiles.
1453         * gcore.c (gcore_create_callback): Use all_objfiles.
1454         (objfile_find_memory_regions): Likewise.
1455
1456 2019-01-09  Tom Tromey  <tom@tromey.com>
1457
1458         * symtab.c (find_line_symtab, info_sources_command)
1459         (make_source_files_completion_list): Use objfile_compunits.
1460         * source.c (select_source_symtab): Use objfile_compunits.
1461         * objfiles.h (struct objfile): Update comment.
1462         (ALL_OBJFILES): Remove.
1463         (ALL_FILETABS): Remove.
1464         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1465         objfile_compunits.
1466
1467 2019-01-09  Tom Tromey  <tom@tromey.com>
1468
1469         * symmisc.c (print_objfile_statistics, dump_objfile)
1470         (maintenance_print_symbols): Use compunit_filetabs.
1471         * source.c (forget_cached_source_info_for_objfile): Use
1472         compunit_filetabs.
1473         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1474         (ALL_FILETABS): Use compunit_filetabs.
1475         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1476         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1477
1478 2019-01-09  Tom Tromey  <tom@tromey.com>
1479
1480         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1481         (compunit_filetabs): New.
1482         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1483         compunit_filetabs.
1484         (info_sources_command, make_source_files_completion_list): Remove
1485         declaration.
1486         * symmisc.c (print_objfile_statistics, dump_objfile)
1487         (maintenance_print_symbols): Remove declaration.
1488         (maintenance_info_symtabs): Use compunit_filetabs.
1489         (maintenance_info_line_tables): Likewise.
1490         * source.c (select_source_symtab): Change local variable name.
1491         (forget_cached_source_info_for_objfile): Remove declaration.
1492         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1493         * objfiles.c (objfile_relocate1): Remove declaration.
1494         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1495         declaration.
1496         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1497         * coffread.c (coff_symtab_read): Remove declaration.
1498         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1499         compunit_filetabs.
1500
1501 2019-01-09  Tom Tromey  <tom@tromey.com>
1502
1503         * symtab.c (lookup_objfile_from_block)
1504         (find_pc_sect_compunit_symtab, search_symbols)
1505         (default_collect_symbol_completion_matches_break_on): Use
1506         objfile_compunits.
1507         * objfiles.h (ALL_COMPUNITS): Remove.
1508         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1509         * cp-support.c (add_symbol_overload_list_qualified): Use
1510         objfile_compunits.
1511         * ada-lang.c (ada_collect_symbol_completion_matches)
1512         (ada_add_global_exceptions): Use objfile_compunits.
1513
1514 2019-01-09  Tom Tromey  <tom@tromey.com>
1515
1516         * source.c (select_source_symtab)
1517         (forget_cached_source_info_for_objfile): Remove declaration.
1518         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1519         declaration.
1520         * maint.c (count_symtabs_and_blocks): Remove declaration.
1521         * cp-support.c (add_symbol_overload_list_qualified): Remove
1522         declaration.
1523         * coffread.c (coff_symtab_read): Remove declaration.
1524         * symtab.c (lookup_symbol_in_objfile_symtabs)
1525         (basic_lookup_transparent_type_1): Use objfile_compunits.
1526         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1527         (info_sources_command, search_symbols)
1528         (default_collect_symbol_completion_matches_break_on)
1529         (make_source_files_completion_list): Remove declaration.
1530         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1531         (ada_collect_symbol_completion_matches)
1532         (ada_add_global_exceptions): Remove declaration.
1533         * linespec.c (iterate_over_all_matching_symtabs): Use
1534         objfile_compunits.
1535         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1536         (class objfile_compunits): New.
1537         (ALL_COMPUNITS): Use objfile_compunits.
1538         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1539         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1540         objfile_compunits.
1541         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1542
1543 2019-01-09  Tom Tromey  <tom@tromey.com>
1544
1545         * symtab.c (search_symbols)
1546         (default_collect_symbol_completion_matches_break_on): Use
1547         objfile_msymbols.
1548         * ada-lang.c (ada_lookup_simple_minsym)
1549         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1550         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1551         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1552         objfile_msymbols.
1553         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1554         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1555         * objc-lang.c (find_methods): Use objfile_msymbols.
1556         (info_selectors_command, info_classes_command): Likewise.
1557         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1558         * objfiles.h (class objfile_msymbols): New.
1559         (ALL_OBJFILE_MSYMBOLS): Remove.
1560         (ALL_MSYMBOLS): Remove.
1561
1562 2019-01-09  Tom Tromey  <tom@tromey.com>
1563
1564         * common/next-iterator.h (next_adapter): Add Iterator template
1565         parameter.
1566         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1567         (class all_objfiles_safe): New.
1568         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1569         * objfiles.c (put_objfile_before): Update comment.
1570         (add_separate_debug_objfile): Likewise.
1571         (free_all_objfiles): Use all_objfiles_safe.
1572         (objfile_purge_solibs): Likewise.
1573
1574 2019-01-09  Tom Tromey  <tom@tromey.com>
1575
1576         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1577         (expand_symtab_containing_pc, lookup_static_symbol)
1578         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1579         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1580         all_objfiles.
1581         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1582         * breakpoint.c (create_overlay_event_breakpoint)
1583         (create_longjmp_master_breakpoint)
1584         (create_std_terminate_master_breakpoint)
1585         (create_exception_master_breakpoint): Use all_objfiles.
1586         * linux-thread-db.c (try_thread_db_load_from_pdir)
1587         (has_libpthread): Use all_objfiles.
1588         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1589         * linespec.c (iterate_over_all_matching_symtabs)
1590         (search_minsyms_for_name): Use all_objfiles.
1591         * maint.c (maintenance_info_sections): Use all_objfiles.
1592         * main.c (captured_main_1): Use all_objfiles.
1593         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1594         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1595         * guile/scm-pretty-print.c
1596         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1597         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1598         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1599         (maintenance_print_msymbols): Use all_objfiles.
1600         * source.c (select_source_symtab): Use all_objfiles.
1601         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1602         * symfile.c (remove_symbol_file_command)
1603         (expand_symtabs_matching, map_symbol_filenames): Use
1604         all_objfiles.
1605         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1606         all_objfiles.
1607         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1608         * objc-lang.c (find_methods): Use all_objfiles.
1609         * objfiles.c (have_partial_symbols, have_full_symbols)
1610         (have_minimal_symbols, qsort_cmp)
1611         (default_iterate_over_objfiles_in_search_order): Use
1612         all_objfiles.
1613         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1614         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1615         (maintenance_check_psymtabs): Use all_objfiles.
1616         (ALL_PSYMTABS): Remove.
1617         * compile/compile-object-run.c (do_module_cleanup): Use
1618         all_objfiles.
1619         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1620         * cp-support.c (add_symbol_overload_list_qualified): Use
1621         all_objfiles.
1622         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1623         Use all_objfiles.
1624         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1625         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1626         all_objfiles.
1627         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1628         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1629         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1630         Uses all_objfiles.
1631         * solib.c (solib_read_symbols): Use all_objfiles
1632
1633 2019-01-09  Tom Tromey  <tom@tromey.com>
1634
1635         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1636         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1637         all_objfiles.
1638         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1639         * symmisc.c (print_symbol_bcache_statistics)
1640         (print_objfile_statistics, maintenance_print_objfiles)
1641         (maintenance_info_symtabs, maintenance_check_symtabs)
1642         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1643         all_objfiles.
1644         * source.c (forget_cached_source_info): Use all_objfiles.
1645         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1646         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1647         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1648         * objfiles.c (update_section_map): Use all_objfiles.
1649         (shared_objfile_contains_address_p): Likewise.
1650         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1651         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1652
1653 2019-01-09  Tom Tromey  <tom@tromey.com>
1654
1655         * common/next-iterator.h: New file.
1656         * objfiles.h (class all_objfiles): New.
1657         (struct objfile_iterator): New.
1658
1659 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1660
1661         * NEWS: Move the description of the changed "frame", "select-frame",
1662          and "info frame" commands to the Changed commands section.
1663
1664 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1665
1666         * gdbtypes.c (check_stub_method_group): Remove handling of old
1667         mangling schemes.
1668         * linespec.c (find_methods): Likewise.
1669         * stabsread.c (read_member_functions): Likewise.
1670         * valops.c (search_struct_method): Likewise.
1671         (value_struct_elt_for_reference): Likewise.
1672         * NEWS: Mention this change.
1673
1674 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1675
1676         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1677         print_source_lines.
1678         * source.c (print_source_lines_base): Update line number check.
1679         (print_source_lines): New function.
1680         (source_lines_range::source_lines_range): New function.
1681         * source.h (class source_lines_range): New class.
1682         (print_source_lines): New declaration.
1683
1684 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1685
1686         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1687
1688 2019-01-08  Tom Tromey  <tom@tromey.com>
1689             Simon Marchi  <simon.marchi@ericsson.com>
1690
1691         PR gdb/24060
1692         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1693         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1694         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1695         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1696         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1697         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1698
1699 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1700
1701         * source.c (select_source_symtab): Move header comment to
1702         declaration in source.h.
1703         (forget_cached_source_info_for_objfile): Likewise.
1704         (forget_cached_source_info): Likewise.
1705         (identify_source_line): Likewise.
1706         * source.h (identify_source_line): Move declaration from symtab.h
1707         and add comment from source.c
1708         (print_source_lines): Likewise.
1709         (forget_cached_source_info_for_objfile): Likewise.
1710         (forget_cached_source_info): Likewise.
1711         (select_source_symtab): Likewise.
1712         (enum print_source_lines_flag): Move definition from symtab.h.
1713         * symtab.h (identify_source_line): Move declaration to source.h.
1714         (print_source_lines): Likewise.
1715         (forget_cached_source_info_for_objfile): Likewise.
1716         (forget_cached_source_info): Likewise.
1717         (select_source_symtab): Likewise.
1718         (enum print_source_lines_flag): Move definition to source.h.
1719         * tui/tui-hooks.c: Add 'source.h' include.
1720
1721 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1722
1723         * source.c (print_source_lines_base): Handle requests to print
1724         reverse line number sequences, and guard against empty lines
1725         string.
1726
1727 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1728
1729         * source.c (print_source_lines_base): Fix skip of '\r' if next
1730         character is '\n'.
1731
1732 2019-01-06  Tom Tromey  <tom@tromey.com>
1733
1734         * c-exp.y (struct c_parse_state) <macro_original_text,
1735         expansion_obstack>: New member.
1736         (macro_original_text, expansion_obstack): Remove globals.
1737         (scan_macro_expansion, scanning_macro_expansion)
1738         (finished_macro_expansion): Update.
1739         (scan_macro_cleanup): Remove.
1740         (yylex, c_parse): Update.
1741
1742 2019-01-06  Tom Tromey  <tom@tromey.com>
1743
1744         * c-exp.y (struct c_parse_state) <strings>: New member.
1745         (operator_stoken): Update.
1746
1747 2019-01-06  Tom Tromey  <tom@tromey.com>
1748
1749         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1750         (union type_stack_elt) <typelist_val>: Now a pointer to
1751         std::vector.
1752         (type_stack_cleanup): Don't declare.
1753         (push_typelist): Update.
1754         * parse.c (pop_typelist): Return a std::vector.
1755         (push_typelist): Take a std::vector.
1756         (follow_types): Update.  Do not free args.
1757         (type_stack_cleanup): Remove.
1758         * c-exp.y (struct c_parse_state): New.
1759         (cpstate): New global.
1760         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1761         (nonempty_typelist): Update.
1762         (func_mod): Create a new vector.
1763         (c_parse): Create a c_parse_state.
1764         (check_parameter_typelist): Do not delete params.
1765         (function_method): Update.  Do not delete type_list.
1766
1767 2019-01-06  Tom Tromey  <tom@tromey.com>
1768
1769         PR gdb/28155:
1770         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1771         check_typedef.
1772         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1773         (print_return_value): Likewise.
1774
1775 2019-01-05  Tom Tromey  <tom@tromey.com>
1776
1777         * contrib/cleanup_check.py: Remove.
1778         * contrib/gcc-with-excheck: Remove.
1779         * contrib/exsummary.py: Remove.
1780         * contrib/excheck.py: Remove.
1781
1782 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1783
1784         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1785         NULL. Initialize tpprev to NULL instead of assigning it
1786         to NULL on the next statement.
1787         * windows-nat.c (windows_delete_thread): Remove check for
1788         main_thread_id before printing thread exit notifications.
1789         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1790         Remove thread ID check against main_thread_id.
1791         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1792         windows_delete_thread.
1793         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1794
1795 2019-01-04  Tom Tromey  <tom@tromey.com>
1796
1797         * compile/compile.c (_initialize_compile): Use upper case for
1798         metasyntactic variables.
1799         * symmisc.c (_initialize_symmisc): Use upper case for
1800         metasyntactic variables.
1801         * psymtab.c (_initialize_psymtab): Use upper case for
1802         metasyntactic variables.
1803         * demangle.c (demangle_command): Use upper case for metasyntactic
1804         variables.
1805         (_initialize_demangler): Likewise.
1806         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1807         variables.
1808
1809 2019-01-03  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1812
1813 2019-01-03  Tom Tromey  <tom@tromey.com>
1814
1815         * python/py-symtab.c (salpy_str): Update.
1816         (struct salpy_sal_object) <symtab>: Now a PyObject.
1817         (salpy_dealloc): Update.
1818         (del_objfile_sal): Use gdbpy_ref.
1819
1820 2019-01-03  Tom Tromey  <tom@tromey.com>
1821
1822         * python/py-type.c (convert_field): Use new_reference.  Return
1823         gdbpy_ref.
1824         (make_fielditem): Return gdbpy_ref.
1825         (typy_fields): Update.
1826         (typy_getitem): Update.
1827         (field_name): Return gdbpy_ref.  Use new_reference.
1828         (typy_iterator_iternext): Update.
1829
1830 2019-01-03  Tom Tromey  <tom@tromey.com>
1831
1832         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1833
1834 2019-01-03  Tom Tromey  <tom@tromey.com>
1835
1836         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1837         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1838         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1839         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1840         (pspy_set_type_printers): Likewise.
1841         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1842         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1843         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1844         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1845         (objfpy_set_type_printers): Likewise.
1846
1847 2019-01-03  Tom Tromey  <tom@tromey.com>
1848
1849         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1850         (gdbpy_print_stack): Use gdbpy_err_fetch.
1851         * python/python-internal.h (class gdbpy_err_fetch): New class.
1852         (class gdbpy_enter) <m_error_type, m_error_value,
1853         m_error_traceback>: Remove.
1854         <m_error>: New member.
1855         (gdbpy_exception_to_string): Don't declare.
1856         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1857         * python/py-value.c (convert_value_from_python): Use
1858         gdbpy_err_fetch.
1859         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1860         gdbpy_exception_to_string.
1861         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1862         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1863         gdbpy_err_fetch.
1864
1865 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1866
1867         * linux-nat.c (delete_lwp_cleanup): Delete.
1868         (struct lwp_deleter): New struct.
1869         (lwp_info_up): New typedef.
1870         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1871         lwp_info_up.
1872
1873 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1874
1875         * linux-fork.c (class scoped_switch_fork_info): New class.
1876         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1877
1878 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1879
1880         * valops.c (find_overload_match): Remove use of null_cleanup, and
1881         calls to do_cleanups.
1882
1883 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1884
1885         * compile/compile-cplus-types.c
1886         (compile_cplus_instance::decl_name): Handle changes to
1887         cp_func_name.
1888         * cp-support.c (cp_func_name): Update header comment, update
1889         return type.
1890         * cp-support.h (cp_func_name): Update return type in declaration.
1891         * valops.c (find_overload_match): Move temp_func local to top
1892         level of function and change its type.  Use temp_func to hold and
1893         delete temporary string obtained from cp_func_name.
1894
1895 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1896
1897         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1898         gdb::char_vector, remove cleanup, and update uses of `msg`.
1899
1900 2019-01-03  Jim Wilson  <jimw@sifive.com>
1901
1902         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1903
1904 2019-01-02  Tom Tromey  <tom@tromey.com>
1905
1906         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1907         (tdesc_parse_xml): Remove cleanups.
1908         * target-descriptions.h (make_cleanup_free_target_description):
1909         Don't declare.
1910         (target_desc_deleter): New struct.
1911         (target_desc_up): New typedef.
1912         * target-descriptions.c (target_desc_deleter::operator()): Rename
1913         from free_target_description.
1914         (make_cleanup_free_target_description): Remove.
1915
1916 2019-01-02  Tom Tromey  <tom@tromey.com>
1917
1918         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1919         constructor, destructor.
1920         (linespec_parser): Remove typedef.
1921         (~linespec_parser): Rename from linespec_parser_delete.
1922         (linespec_lex_to_end, linespec_complete_label)
1923         (linespec_complete): Update.
1924         (decode_line_full): Remove cleanups.
1925         (decode_line_1): Update.
1926
1927 2019-01-02  Tom Tromey  <tom@tromey.com>
1928
1929         * python/python-internal.h (inferior_to_inferior_object): Change
1930         return type.
1931         * python/py-exitedevent.c (create_exited_event_object): Update.
1932         * python/py-inferior.c (inferior_to_inferior_object): Return
1933         gdbpy_ref.
1934         (python_new_inferior, python_inferior_deleted)
1935         (thread_to_thread_object, delete_thread_object)
1936         (build_inferior_list, gdbpy_selected_inferior): Update.
1937         * python/py-infthread.c (create_thread_object): Update.  Also fail
1938         if inferior_to_inferior_object fails.
1939
1940 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1941
1942         * inferior.h (class inferior) <displaced_step_state>: New field.
1943         * infrun.h (struct displaced_step_state): Move here from
1944         infrun.c.  Initialize fields, add constructor.
1945         <inf>: Remove field.
1946         <reset>: New method.
1947         * infrun.c (struct displaced_step_inferior_state): Move to
1948         infrun.h.
1949         (displaced_step_inferior_states): Remove.
1950         (get_displaced_stepping_state): Adust.
1951         (displaced_step_in_progress_any_inferior): Adjust.
1952         (displaced_step_in_progress_thread): Adjust.
1953         (displaced_step_in_progress): Adjust.
1954         (add_displaced_stepping_state): Remove.
1955         (get_displaced_step_closure_by_addr): Adjust.
1956         (remove_displaced_stepping_state): Remove.
1957         (infrun_inferior_exit): Call displaced_step_state.reset.
1958         (use_displaced_stepping): Don't check for NULL.
1959         (displaced_step_prepare_throw): Call
1960         get_displaced_stepping_state.
1961         (displaced_step_fixup): Don't check for NULL.
1962         (prepare_for_detach): Don't check for NULL.
1963
1964 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1965
1966         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1967          in case of call that did not complete.
1968
1969 2019-01-02  Andrey Utkin  <autkin@undo.io>
1970
1971         * symfile.c (find_separate_debug_file): Fix search of debug files for
1972         remote debuggee.
1973
1974 2019-01-02  Tom Tromey  <tom@tromey.com>
1975
1976         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1977         indentation.
1978         * python/py-frame.c (frapy_older): Remove cast.
1979         (frapy_newer): Likewise.
1980         * python/py-breakpoint.c (local_setattro): Remove cast.
1981         * python/py-arch.c (archpy_name): Remove local variable.
1982         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1983
1984 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1985
1986         * unittests/basic_string_view/element_access/char/empty.cc:
1987         Fix year range in copyright header.
1988
1989 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1990
1991         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1992         Delete.
1993         <operator==>: Update with for removed field.
1994         <hash>: Likewise.
1995         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1996         <isa_features>: ...this.
1997         <abi_features>: New field.
1998         (riscv_isa_flen): Update comment.
1999         (riscv_abi_xlen): New declaration.
2000         (riscv_abi_flen): New declaration.
2001         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2002         isa_features.
2003         (riscv_abi_xlen): New function.
2004         (riscv_isa_flen): Update to get answer from isa_features.
2005         (riscv_abi_flen): New function.
2006         (riscv_has_fp_abi): Update to get answer from abi_features.
2007         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2008         xlen and flen.
2009         (riscv_call_info) <xlen, flen>: Update comment.
2010         (riscv_call_arg_struct): Remove invalid assertions
2011         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2012         is removed.
2013         (riscv_gdbarch_init): Gather isa features and abi features
2014         separately, ensure both match on the gdbarch when reusing an old
2015         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2016         a target with 64-bit float hardware.
2017
2018 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2019
2020         * source.c (search_command_helper): Stop reverse search
2021         when line 1 has been searched.
2022
2023 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2024
2025         * record-full.c (record_full_base_target::close): Rewrite
2026         record_full_core_buf_list free logic.
2027
2028 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2029
2030         * break-catch-syscall.c (print_one_catch_syscall): xfree
2031         the last text.
2032
2033 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2034
2035         * top.c (print_gdb_version): Update Copyright year in version
2036         message.
2037
2038 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2039
2040         Update copyright year range in all GDB files.
2041
2042 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2043
2044         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2045
2046 For older changes see ChangeLog-2018.
2047 \f
2048 Local Variables:
2049 mode: change-log
2050 left-margin: 8
2051 fill-column: 74
2052 version-control: never
2053 coding: utf-8
2054 End:
2055