gdb/ChangeLog

   1 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
   2
   3         * utils.c (prompt_for_continue): Don't restore the styling at the
   4         end, as applied_style has the wrong value.  This fixes styling in
   5         long lists of file names that are interrupted by the "Continue?"
   6         prompt.
   7
   8 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
   9
  10         * version.in: Set GDB version number to 8.2.91.DATE-git.
  11
  12 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  13
  14         GDB 8.2.91 released.
  15
  16 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  17
  18         * version.in: Set GDB version number to 8.2.91.
  19
  20 2019-03-20  Tom Tromey  <tromey@adacore.com>
  21
  22         PR gdb/24391
  23         * infrun.c (handle_inferior_event): Rename from
  24         handle_inferior_event_1.  Create a scoped_value_mark.
  25         (handle_inferior_event): Remove.
  26
  27 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  28
  29         * source-cache.c (source_cache::get_source_lines): Re-read
  30         fullname after calling open_source_file.
  31
  32 2019-03-18  Pedro Alves  <palves@redhat.com>
  33             Eli Zaretskii <eliz@gnu.org>
  34
  35         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
  36         m_line and m_start_of_line.
  37
  38 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
  39
  40         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
  41         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
  42         it returns a newline.  This fixes a regression in TU mode, whereby
  43         the next line is output on the same screen line as the user input.
  44
  45 2019-03-18  Pedro Alves  <palves@redhat.com>
  46
  47         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
  48         New globals.
  49         (apply_style): New, factored out from ...
  50         (apply_ansi_escape): ... this.  Handle reverse video mode.
  51         (tui_set_reverse_mode): New function.
  52         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
  53         * tui/tui-winsource.c (tui_show_source_line): Use
  54         tui_set_reverse_mode instead of setting A_STANDOUT.
  55         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
  56         New setter methods.
  57
  58 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
  59
  60         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
  61         Handle tabs.
  62
  63 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
  64
  65         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
  66         tui_refill_source_window instead of tui_refresh_win, to update the
  67         current execution line.  This fixes redisplay of the current line
  68         when stepping through the code with "next" or "step".
  69
  70 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  71
  72         * source-cache.c (source_cache::get_source_lines): Call
  73         find_source_lines to initialize s->nlines.  This fixes vertical
  74         scrolling of TUI source window when the DOWN arrow is pressed.
  75
  76 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  77
  78         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  79         wclrtoeol in tui_show_source_line".  This reverts changes made in
  80         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  81
  82 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  83
  84         * NEWS: Combine separate "New targets" sections for 8.3.
  85
  86 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  87
  88         The MS-Windows port of ncurses fails to switch to a color pair if
  89         one or both of the colors are the implicit default colors.  This
  90         change records the default colors when TUI is initialized, and
  91         then specifies them explicitly when a color pair uses the default
  92         colors.  This allows color styling in TUI mode on MS-Windows.
  93
  94         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  95         ncurses_norm_attr.
  96         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  97         colors in ncurses_norm_attr.
  98         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  99         "none", replace it with the default color recorded in
 100         ncurses_norm_attr.
 101
 102 2019-03-14  Tom Tromey  <tromey@adacore.com>
 103
 104         * source-cache.h (class source_cache) <get_source_lines>: Return
 105         std::string.
 106         * source-cache.c (source_cache::extract_lines): Handle case where
 107         first_pos==npos.  Return std::string.
 108         (source_cache::get_source_lines): Update.
 109
 110 2019-03-14  Tom Tromey  <tromey@adacore.com>
 111
 112         * NEWS: Add item for "style sources" commands.
 113         * source-cache.c (source_cache::get_source_lines): Check
 114         source_styling.
 115         * cli/cli-style.c (source_styling): New global.
 116         (_initialize_cli_style): Add "style sources" commands.
 117         (show_style_sources): New function.
 118         * cli/cli-style.h (source_styling): Declare.
 119
 120 2019-03-14  Pedro Alves  <palves@redhat.com>
 121             Tom Tromey  <tromey@adacore.com>
 122
 123         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 124         * tui/tui-winsource.c (tui_refill_source_window): New function,
 125         from...
 126         (tui_horizontal_source_scroll): ... here.  Move some logic.
 127         * cli/cli-style.c (set_style_enabled): Notify new observable.
 128         * tui/tui-hooks.c (tui_redisplay_source): New function.
 129         (tui_attach_detach_observers): Attach or detach
 130         tui_redisplay_source.
 131         * observable.h (source_styling_changed): New observable.
 132         * observable.c: Define source_styling_changed observable.
 133
 134 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 135
 136         PR/24325
 137         * source-cache.c: #undef open and close, to avoid unresolved
 138         externals during linking.
 139
 140 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 141
 142         Support styling on native MS-Windows console
 143
 144         PR/24315
 145         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 146         on MS-Windows if $TERM is not defined.
 147
 148         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 149
 150         * posix-hdep.c (gdb_console_fputs):
 151         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 152         functions.
 153         * ui-file.h (gdb_console_fputs): Add prototype.
 154
 155         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 156         back to fputs only if the former returns zero.
 157
 158 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
 159             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 160
 161         PR gdb/8527
 162         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 163         set_sigint_trap, clear_sigint_trap.
 164
 165 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 166
 167         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 168         for-loop range, to avoid compiler warnings.
 169
 170         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 171         avoid compiler warnings about unused variables.
 172
 173 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 174
 175         * NEWS: Mention end of support for native debugging on MS-Windows
 176         before XP.
 177
 178 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 179
 180         PR gdb/24292
 181         * common/netstuff.c:
 182         * gdbserver/gdbreplay.c
 183         * gdbserver/remote-utils.c:
 184         * ser-tcp.c:
 185         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 186         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 187         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 188         'getaddrinfo' and 'freeaddrinfo' were not available before
 189         Windows XP, and mingw.org's MinGW headers by default define
 190         _WIN32_WINNT to 0x500.
 191
 192 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 193
 194         * NEWS: Note minimum Python version.
 195
 196 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 197
 198         * version.in: Set GDB version number to 8.2.90.DATE-git.
 199
 200 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 201
 202         GDB 8.2.90 released.
 203
 204 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 205
 206         * version.in: Set GDB version number to 8.2.90.
 207
 208 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 209
 210         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 211
 212 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 213
 214         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 215         * version.in: Bump version to 8.2.90.DATE-git.
 216
 217 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 218
 219         * aix-thread.c (ptid_cmp): Remove unused variable.
 220         (get_signaled_thread): Likewise.
 221         (store_regs_user_thread): Likewise.
 222         (store_regs_kernel_thread): Likewise.
 223         (fetch_regs_kernel_thread): Remove shadowed variable.
 224
 225 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 226
 227         * features/riscv/32bit-cpu.xml: Add register numbers.
 228         * features/riscv/32bit-fpu.c: Regenerate.
 229         * features/riscv/32bit-fpu.xml: Add register numbers.
 230         * features/riscv/64bit-cpu.xml: Add register numbers.
 231         * features/riscv/64bit-fpu.c: Regenerate.
 232         * features/riscv/64bit-fpu.xml: Add register numbers.
 233
 234 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 235
 236         * NEWS: Mention two argument form of gdb.Value constructor.
 237         * python/py-value.c (convert_buffer_and_type_to_value): New
 238         function.
 239         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 240         Add support for handling an optional second argument.  Call
 241         convert_buffer_and_type_to_value as appropriate.
 242         * python/python-internal.h (Py_buffer_deleter): New struct.
 243         (Py_buffer_up): New typedef.
 244
 245 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 246
 247         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 248         instead of releasing ownership.
 249
 250 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 251
 252         * dwarf2read.c (open_and_init_dwp_file): Call
 253         elf_numsections instead of bfd_count_sections to initialize
 254         dwp_file->num_sections.
 255
 256 2019-02-25  Tom Tromey  <tromey@adacore.com>
 257
 258         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 259
 260 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 261
 262         * gcore.in: Add '--readnever' option when invoking GDB.
 263
 264 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 265
 266         * MAINTAINERS: Update my email address.
 267
 268 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 269
 270         * build-id.c (build_id_to_debug_bfd_1): New function.
 271         (build_id_to_debug_bfd): Look for separate debug file in
 272         sysroot.
 273
 274 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 275
 276         * gdbarch.sh: Update the copyright year range that is placed into
 277         generated files.
 278
 279 2019-02-22  Keith Seitz  <keiths@redhat.com>
 280
 281         PR symtab/23853
 282         * linespec.c (create_sals_line_offset): Search for the default
 283         symtab's filename instead of its fullname.
 284
 285 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 286
 287         * NEWS: Update style defaults.
 288
 289 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 290
 291         * main.c (captured_main_1): Disable styling in batch mode.
 292
 293 2019-02-20  Tom Tromey  <tom@tromey.com>
 294
 295         * symtab.c (symtab_symbol_info): Fix typos.
 296
 297 2019-02-20  Tom Tromey  <tromey@adacore.com>
 298
 299         * findcmd.c (_initialize_mem_search): Use upper case for
 300         metasyntactic variables.
 301
 302 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 303
 304         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 305         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 306
 307 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 308
 309         * top.h (source_file_name): Change to std::string.
 310         * top.c (source_file_name): Likewise.
 311         (command_line_input): Adjust.
 312         * cli/cli-script.c (script_from_file): Adjust.
 313
 314 2019-02-19  Tom Tromey  <tromey@adacore.com>
 315
 316         * ravenscar-thread.c
 317         (ravenscar_thread_target::update_thread_list): Don't call
 318         ada_build_task_list.
 319         * ada-lang.h (ada_build_task_list): Don't declare.
 320         * ada-tasks.c (struct ada_tasks_inferior_data)
 321         <task_list_valid_p>: Now bool.
 322         (read_known_tasks, ada_task_list_changed)
 323         (ada_tasks_invalidate_inferior_data): Update.
 324         (read_known_tasks_array): Return bool.
 325         (read_known_tasks_list): Likewise.
 326         (read_known_tasks): Return void.
 327         (ada_build_task_list): Now static.
 328
 329 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 330
 331         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 332         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 333
 334 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 335
 336         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 337         variant for ada_tasks_pspace_data_handle and
 338         ada_tasks_inferior_data_handle.
 339         (ada_tasks_pspace_data_cleanup): New function.
 340         (ada_tasks_inferior_data_cleanup): New function.
 341
 342 2019-02-17  Tom Tromey  <tom@tromey.com>
 343
 344         * macrotab.h (macro_source_fullname): Return a std::string.
 345         * macrotab.c (macro_include, check_for_redefinition)
 346         (macro_undef, macro_lookup_definition, foreach_macro)
 347         (foreach_macro_in_scope): Update.
 348         (macro_source_fullname): Return a std::string.
 349         * macrocmd.c (show_pp_source_pos): Update.
 350
 351 2019-02-17  Tom Tromey  <tom@tromey.com>
 352
 353         * macrocmd.c (show_pp_source_pos): Style the file names.
 354
 355 2019-02-17  Tom Tromey  <tom@tromey.com>
 356
 357         PR tui/24197:
 358         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 359
 360 2019-02-17  Tom Tromey  <tom@tromey.com>
 361
 362         * ada-lang.c (user_select_syms): Use filtered printing.
 363         * utils.c (wrap_style): New global.
 364         (desired_style): Remove.
 365         (emit_style_escape): Add stream parameter.
 366         (set_output_style, reset_terminal_style, prompt_for_continue):
 367         Update.
 368         (flush_wrap_buffer): Only flush gdb_stdout.
 369         (wrap_here): Set wrap_style.
 370         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 371         treat escape sequences as a character.  Change when wrap buffer is
 372         flushed.
 373         (fputs_styled): Do not set the output style when the default is
 374         requested.
 375         * ui-style.h (struct ui_file_style) <is_default>: New method.
 376         * source.c (print_source_lines_base): Emit escape sequences in one
 377         piece.
 378
 379 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 380
 381         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 382         integers and enumeration types.
 383
 384 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 385
 386         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 387         instead of lookup_symbol_in_language
 388         (do_exact_match): New function.
 389         (ada_get_symbol_name_matcher): Return do_exact_match when
 390         doing a verbatim match.
 391
 392 2019-02-15  Tom Tromey  <tromey@adacore.com>
 393
 394         * ravenscar-thread.c (ravenscar_thread_target::resume)
 395         (ravenscar_thread_target::wait): Special case wildcard requests.
 396
 397 2019-02-15  Tom Tromey  <tromey@adacore.com>
 398
 399         * ravenscar-thread.c (base_ptid): Remove.
 400         (struct ravenscar_thread_target) <close>: New method.
 401         <m_base_ptid>: New member.
 402         <update_inferior_ptid, active_task, task_is_currently_active,
 403         runtime_initialized>: Declare methods.
 404         <ravenscar_thread_target>: Add constructor.
 405         (ravenscar_thread_target::task_is_currently_active)
 406         (ravenscar_thread_target::update_inferior_ptid)
 407         (ravenscar_runtime_initialized): Rename.  Now methods.
 408         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 409         (ravenscar_thread_target::update_thread_list): Update.
 410         (ravenscar_thread_target::active_task): Now method.
 411         (ravenscar_thread_target::store_registers)
 412         (ravenscar_thread_target::prepare_to_store)
 413         (ravenscar_thread_target::prepare_to_store)
 414         (ravenscar_thread_target::mourn_inferior): Update.
 415         (ravenscar_inferior_created): Use "new" to create target.
 416         (ravenscar_thread_target::get_ada_task_ptid): Update.
 417         (_initialize_ravenscar): Don't initialize base_ptid.
 418         (ravenscar_ops): Remove global.
 419
 420 2019-02-15  Tom Tromey  <tromey@adacore.com>
 421
 422         * target.h (push_target): Declare new overload.
 423         * target.c (push_target): New overload, taking an rvalue reference.
 424         * remote.c (remote_target::open_1): Use push_target overload.
 425         * corelow.c (core_target_open): Use push_target overload.
 426
 427 2019-02-15  Tom Tromey  <tromey@adacore.com>
 428
 429         * ravenscar-thread.c (is_ravenscar_task)
 430         (ravenscar_task_is_currently_active): Return bool.
 431         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 432         (_initialize_ravenscar): Remove "(void)".
 433         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 434         Return bool.
 435
 436 2019-02-15  Tom Tromey  <tromey@adacore.com>
 437
 438         * ravenscar-thread.c (ravenscar_runtime_initializer)
 439         (has_ravenscar_runtime, get_running_thread_id)
 440         (ravenscar_thread_target::resume): Fix indentation.
 441
 442 2019-02-15  Tom Tromey  <tromey@adacore.com>
 443
 444         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 445         from ravenscar_arch_ops.
 446         (sparc_ravenscar_ops::fetch_registers)
 447         (sparc_ravenscar_ops::store_registers): Now methods.
 448         (sparc_ravenscar_prepare_to_store): Remove.
 449         (sparc_ravenscar_ops): Redefine.
 450         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 451         methods and destructor.  Remove members.
 452         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 453         (ravenscar_thread_target::store_registers)
 454         (ravenscar_thread_target::prepare_to_store): Update.
 455         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 456         Remove.
 457         (struct ppc_ravenscar_powerpc_ops): Derive from
 458         ravenscar_arch_ops.
 459         (ppc_ravenscar_powerpc_ops::fetch_registers)
 460         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 461         (ppc_ravenscar_powerpc_ops): Redefine.
 462         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 463         (ppc_ravenscar_e500_ops::fetch_registers)
 464         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 465         (ppc_ravenscar_e500_ops): Redefine.
 466         * aarch64-ravenscar-thread.c
 467         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 468         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 469         (aarch64_ravenscar_fetch_registers)
 470         (aarch64_ravenscar_store_registers): Now methods.
 471         (aarch64_ravenscar_ops): Redefine.
 472
 473 2019-02-15  Tom Tromey  <tromey@adacore.com>
 474
 475         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 476         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 477         (ravenscar_thread_target::stopped_by_watchpoint)
 478         (ravenscar_thread_target::stopped_data_address)
 479         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 480
 481 2019-02-15  Tom Tromey  <tromey@adacore.com>
 482
 483         * ravenscar-thread.c: Fix some typos.
 484
 485 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 486             Tom Tromey  <tromey@adacore.com>
 487
 488         * ada-lang.c (ada_exception_sal): Change addr_string to a
 489         std::string.
 490         (create_ada_exception_catchpoint): Update.
 491
 492 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 493             Tom Tromey  <tromey@adacore.com>
 494
 495         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 496         (bp_location_ops): Remove.
 497         (base_breakpoint_allocate_location): Update.
 498         (free_bp_location): Update.
 499         * ada-lang.c (class ada_catchpoint_location)
 500         <ada_catchpoint_location>: Remove ops parameter.
 501         (ada_catchpoint_location_dtor): Remove.
 502         (ada_catchpoint_location_ops): Remove.
 503         (allocate_location_exception): Update.
 504         * breakpoint.h (struct bp_location_ops): Remove.
 505         (class bp_location) <bp_location>: Remove bp_location_ops
 506         parameter.
 507         <~bp_location>: Add destructor.
 508         <ops>: Remove.
 509
 510 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 511             Pedro Alves  <palves@redhat.com>
 512
 513         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 514         'PATH_MAX'.
 515
 516 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 517             Samuel Thibault  <samuel.thibault@gnu.org>
 518             Thomas Schwinge  <thomas@codesourcery.com>
 519
 520         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 521         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 522
 523 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 524
 525         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 526         (check_empty): Use "const char *".
 527
 528         * gnu-nat.c (gnu_nat_target::detach): Instead of
 529         'detach_inferior (pid)' call
 530         'detach_inferior (find_inferior_pid (pid))'.
 531
 532         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 533         'nat/fork-inferior.o'.
 534         * gnu-nat.c: #include "nat/fork-inferior.h".
 535
 536         * gnu-nat.c (gnu_nat_target::detach): Instead of
 537         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 538         * gnu-nat.h: #include "inf-child.h".
 539         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 540         'i386_gnu_nat_target::fetch_registers'.
 541         (gnu_store_registers): Rename/move to
 542         'i386_gnu_nat_target::store_registers'.
 543
 544         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 545         * gnu-nat.h (mach_thread_info): New function.
 546         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 547
 548         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 549
 550 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 551
 552         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 553
 554 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 555
 556         * windows-nat.c (windows_add_thread): Add new parameter
 557         "main_thread_p" with default value set to false.  Update
 558         function documentation as well as all callers.
 559         (windows_delete_thread): Likewise.
 560         (fake_create_process): Update call to windows_add_thread.
 561         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 562         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 563         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 564         call to windows_delete_thread.
 565
 566 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 567
 568         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 569
 570 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 571
 572         * symfile.c (find_separate_debug_file): Use canonical path of
 573         sysroot with child_path instead of gdb_sysroot if it is valid.
 574
 575 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 576
 577         * symfile.c (find_separate_debug_file): Use child_path to
 578         determine if an object file is under a sysroot.
 579
 580 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 581
 582         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 583         unittests/child-path-selftests.c.
 584         * common/pathstuff.c (child_path): New function.
 585         * common/pathstuff.h (child_path): New prototype.
 586         * unittests/child-path-selftests.c: New file.
 587
 588 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 589
 590         * symfile.c (find_separate_debug_file): Look for separate debug
 591         files in debug directories under the sysroot.
 592
 593 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 594
 595         * symtab.h (struct minimal_symbol data_p): New const method.
 596         (struct minimal_symbol text_p): Likewise.
 597         * symtab.c (output_source_filename): Use file name style
 598         to print file name.
 599         (print_symbol_info): Likewise.
 600         (print_msymbol_info): Use address style to print addresses.
 601         Use function name style to print executable text symbols.
 602         (expand_symtab_containing_pc): Use data_p.
 603         (find_pc_sect_compunit_symtab): Likewise.
 604
 605 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 606
 607         * breakpoint.c (describe_other_breakpoints): Use address style
 608         to print addresses.
 609         (say_where): Likewise.
 610
 611 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 612
 613         * ada-typeprint.c (print_func_type): Print function name
 614         style to print function name.
 615         * c-typeprint.c (c_print_type_1): Likewise.
 616
 617 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 618
 619         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 620         for execve.
 621
 622 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 623
 624         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 625         type_stack.
 626
 627 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 628
 629         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 630         TYPE_CODE_REF types.
 631
 632 2019-02-08  Jim Wilson  <jimw@sifive.com>
 633
 634         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 635         (riscv_linux_fregset): New.
 636         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 637
 638 2019-02-07  Tom Tromey  <tom@tromey.com>
 639
 640         * thread.c (thread_cancel_execution_command): Update.
 641         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 642         methods.
 643         (struct thread_fsm_ops): Remove.
 644         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 645         (thread_fsm_should_stop, thread_fsm_return_value)
 646         (thread_fsm_set_finished, thread_fsm_finished_p)
 647         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 648         Don't declare.
 649         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 650         * infrun.c (clear_proceed_status_thread)
 651         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 652         (print_stop_event): Update.
 653         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 654         Add constructor.
 655         (step_command_fsm_ops): Remove.
 656         (new_step_command_fsm): Remove.
 657         (step_1): Update.
 658         (step_command_fsm::should_stop): Rename from
 659         step_command_fsm_should_stop.
 660         (step_command_fsm::clean_up): Rename from
 661         step_command_fsm_clean_up.
 662         (step_command_fsm::do_async_reply_reason): Rename from
 663         step_command_fsm_async_reply_reason.
 664         (struct until_next_fsm): Inherit from thread_fsm.  Add
 665         constructor.
 666         (until_next_fsm_ops): Remove.
 667         (new_until_next_fsm): Remove.
 668         (until_next_fsm::should_stop): Rename from
 669         until_next_fsm_should_stop.
 670         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 671         (until_next_fsm::do_async_reply_reason): Rename from
 672         until_next_fsm_async_reply_reason.
 673         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 674         constructor.  Change type of breakpoint.
 675         (finish_command_fsm_ops): Remove.
 676         (new_finish_command_fsm): Remove.
 677         (finish_command_fsm::should_stop): Rename from
 678         finish_command_fsm_should_stop.
 679         (finish_command_fsm::clean_up): Rename from
 680         finish_command_fsm_clean_up.
 681         (finish_command_fsm::return_value): Rename from
 682         finish_command_fsm_return_value.
 683         (finish_command_fsm::do_async_reply_reason): Rename from
 684         finish_command_fsm_async_reply_reason.
 685         (finish_command): Update.
 686         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 687         Add constructor.
 688         (call_thread_fsm_ops): Remove.
 689         (call_thread_fsm::call_thread_fsm): Rename from
 690         new_call_thread_fsm.
 691         (call_thread_fsm::should_stop): Rename from
 692         call_thread_fsm_should_stop.
 693         (call_thread_fsm::should_notify_stop): Rename from
 694         call_thread_fsm_should_notify_stop.
 695         (run_inferior_call, call_function_by_hand_dummy): Update.
 696         * cli/cli-interp.c (should_print_stop_to_console): Update.
 697         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 698         Add constructor.  Change type of location_breakpoint,
 699         caller_breakpoint.
 700         (until_break_fsm_ops): Remove.
 701         (new_until_break_fsm): Remove.
 702         (until_break_fsm::should_stop): Rename from
 703         until_break_fsm_should_stop.
 704         (until_break_fsm::clean_up): Rename from
 705         until_break_fsm_clean_up.
 706         (until_break_fsm::do_async_reply_reason): Rename from
 707         until_break_fsm_async_reply_reason.
 708         (until_break_command): Update.
 709         * thread-fsm.c: Remove.
 710         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 711
 712 2019-02-07  Tom Tromey  <tom@tromey.com>
 713
 714         * yy-remap.h: Add include guard.
 715         * xtensa-tdep.h: Add include guard.
 716         * xcoffread.h: Rename include guard.
 717         * varobj-iter.h: Add include guard.
 718         * tui/tui.h: Rename include guard.
 719         * tui/tui-winsource.h: Rename include guard.
 720         * tui/tui-wingeneral.h: Rename include guard.
 721         * tui/tui-windata.h: Rename include guard.
 722         * tui/tui-win.h: Rename include guard.
 723         * tui/tui-stack.h: Rename include guard.
 724         * tui/tui-source.h: Rename include guard.
 725         * tui/tui-regs.h: Rename include guard.
 726         * tui/tui-out.h: Rename include guard.
 727         * tui/tui-layout.h: Rename include guard.
 728         * tui/tui-io.h: Rename include guard.
 729         * tui/tui-hooks.h: Rename include guard.
 730         * tui/tui-file.h: Rename include guard.
 731         * tui/tui-disasm.h: Rename include guard.
 732         * tui/tui-data.h: Rename include guard.
 733         * tui/tui-command.h: Rename include guard.
 734         * tic6x-tdep.h: Add include guard.
 735         * target/waitstatus.h: Rename include guard.
 736         * target/wait.h: Rename include guard.
 737         * target/target.h: Rename include guard.
 738         * target/resume.h: Rename include guard.
 739         * target-float.h: Rename include guard.
 740         * stabsread.h: Add include guard.
 741         * rs6000-tdep.h: Add include guard.
 742         * riscv-fbsd-tdep.h: Add include guard.
 743         * regformats/regdef.h: Rename include guard.
 744         * record.h: Rename include guard.
 745         * python/python.h: Rename include guard.
 746         * python/python-internal.h: Rename include guard.
 747         * python/py-stopevent.h: Rename include guard.
 748         * python/py-ref.h: Rename include guard.
 749         * python/py-record.h: Rename include guard.
 750         * python/py-record-full.h: Rename include guard.
 751         * python/py-record-btrace.h: Rename include guard.
 752         * python/py-instruction.h: Rename include guard.
 753         * python/py-events.h: Rename include guard.
 754         * python/py-event.h: Rename include guard.
 755         * procfs.h: Add include guard.
 756         * proc-utils.h: Add include guard.
 757         * p-lang.h: Add include guard.
 758         * or1k-tdep.h: Rename include guard.
 759         * observable.h: Rename include guard.
 760         * nto-tdep.h: Rename include guard.
 761         * nat/x86-linux.h: Rename include guard.
 762         * nat/x86-linux-dregs.h: Rename include guard.
 763         * nat/x86-gcc-cpuid.h: Add include guard.
 764         * nat/x86-dregs.h: Rename include guard.
 765         * nat/x86-cpuid.h: Rename include guard.
 766         * nat/ppc-linux.h: Rename include guard.
 767         * nat/mips-linux-watch.h: Rename include guard.
 768         * nat/linux-waitpid.h: Rename include guard.
 769         * nat/linux-ptrace.h: Rename include guard.
 770         * nat/linux-procfs.h: Rename include guard.
 771         * nat/linux-osdata.h: Rename include guard.
 772         * nat/linux-nat.h: Rename include guard.
 773         * nat/linux-namespaces.h: Rename include guard.
 774         * nat/linux-btrace.h: Rename include guard.
 775         * nat/glibc_thread_db.h: Rename include guard.
 776         * nat/gdb_thread_db.h: Rename include guard.
 777         * nat/gdb_ptrace.h: Rename include guard.
 778         * nat/fork-inferior.h: Rename include guard.
 779         * nat/amd64-linux-siginfo.h: Rename include guard.
 780         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 781         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 782         * nat/aarch64-linux.h: Rename include guard.
 783         * nat/aarch64-linux-hw-point.h: Rename include guard.
 784         * mn10300-tdep.h: Add include guard.
 785         * mips-linux-tdep.h: Add include guard.
 786         * mi/mi-parse.h: Rename include guard.
 787         * mi/mi-out.h: Rename include guard.
 788         * mi/mi-main.h: Rename include guard.
 789         * mi/mi-interp.h: Rename include guard.
 790         * mi/mi-getopt.h: Rename include guard.
 791         * mi/mi-console.h: Rename include guard.
 792         * mi/mi-common.h: Rename include guard.
 793         * mi/mi-cmds.h: Rename include guard.
 794         * mi/mi-cmd-break.h: Rename include guard.
 795         * m2-lang.h: Add include guard.
 796         * location.h: Rename include guard.
 797         * linux-record.h: Rename include guard.
 798         * linux-nat.h: Add include guard.
 799         * linux-fork.h: Add include guard.
 800         * i386-darwin-tdep.h: Rename include guard.
 801         * hppa-linux-offsets.h: Add include guard.
 802         * guile/guile.h: Rename include guard.
 803         * guile/guile-internal.h: Rename include guard.
 804         * gnu-nat.h: Rename include guard.
 805         * gdb-stabs.h: Rename include guard.
 806         * frv-tdep.h: Add include guard.
 807         * f-lang.h: Add include guard.
 808         * event-loop.h: Add include guard.
 809         * darwin-nat.h: Rename include guard.
 810         * cp-abi.h: Rename include guard.
 811         * config/sparc/nm-sol2.h: Rename include guard.
 812         * config/nm-nto.h: Rename include guard.
 813         * config/nm-linux.h: Add include guard.
 814         * config/i386/nm-i386gnu.h: Rename include guard.
 815         * config/djgpp/nl_types.h: Rename include guard.
 816         * config/djgpp/langinfo.h: Rename include guard.
 817         * compile/gcc-cp-plugin.h: Add include guard.
 818         * compile/gcc-c-plugin.h: Add include guard.
 819         * compile/compile.h: Rename include guard.
 820         * compile/compile-object-run.h: Rename include guard.
 821         * compile/compile-object-load.h: Rename include guard.
 822         * compile/compile-internal.h: Rename include guard.
 823         * compile/compile-cplus.h: Rename include guard.
 824         * compile/compile-c.h: Rename include guard.
 825         * common/xml-utils.h: Rename include guard.
 826         * common/x86-xstate.h: Rename include guard.
 827         * common/version.h: Rename include guard.
 828         * common/vec.h: Rename include guard.
 829         * common/tdesc.h: Rename include guard.
 830         * common/selftest.h: Rename include guard.
 831         * common/scoped_restore.h: Rename include guard.
 832         * common/scoped_mmap.h: Rename include guard.
 833         * common/scoped_fd.h: Rename include guard.
 834         * common/safe-iterator.h: Rename include guard.
 835         * common/run-time-clock.h: Rename include guard.
 836         * common/refcounted-object.h: Rename include guard.
 837         * common/queue.h: Rename include guard.
 838         * common/ptid.h: Rename include guard.
 839         * common/print-utils.h: Rename include guard.
 840         * common/preprocessor.h: Rename include guard.
 841         * common/pathstuff.h: Rename include guard.
 842         * common/observable.h: Rename include guard.
 843         * common/netstuff.h: Rename include guard.
 844         * common/job-control.h: Rename include guard.
 845         * common/host-defs.h: Rename include guard.
 846         * common/gdb_wait.h: Rename include guard.
 847         * common/gdb_vecs.h: Rename include guard.
 848         * common/gdb_unlinker.h: Rename include guard.
 849         * common/gdb_unique_ptr.h: Rename include guard.
 850         * common/gdb_tilde_expand.h: Rename include guard.
 851         * common/gdb_sys_time.h: Rename include guard.
 852         * common/gdb_string_view.h: Rename include guard.
 853         * common/gdb_splay_tree.h: Rename include guard.
 854         * common/gdb_setjmp.h: Rename include guard.
 855         * common/gdb_ref_ptr.h: Rename include guard.
 856         * common/gdb_optional.h: Rename include guard.
 857         * common/gdb_locale.h: Rename include guard.
 858         * common/gdb_assert.h: Rename include guard.
 859         * common/filtered-iterator.h: Rename include guard.
 860         * common/filestuff.h: Rename include guard.
 861         * common/fileio.h: Rename include guard.
 862         * common/environ.h: Rename include guard.
 863         * common/common-utils.h: Rename include guard.
 864         * common/common-types.h: Rename include guard.
 865         * common/common-regcache.h: Rename include guard.
 866         * common/common-inferior.h: Rename include guard.
 867         * common/common-gdbthread.h: Rename include guard.
 868         * common/common-exceptions.h: Rename include guard.
 869         * common/common-defs.h: Rename include guard.
 870         * common/common-debug.h: Rename include guard.
 871         * common/cleanups.h: Rename include guard.
 872         * common/buffer.h: Rename include guard.
 873         * common/btrace-common.h: Rename include guard.
 874         * common/break-common.h: Rename include guard.
 875         * cli/cli-utils.h: Rename include guard.
 876         * cli/cli-style.h: Rename include guard.
 877         * cli/cli-setshow.h: Rename include guard.
 878         * cli/cli-script.h: Rename include guard.
 879         * cli/cli-interp.h: Rename include guard.
 880         * cli/cli-decode.h: Rename include guard.
 881         * cli/cli-cmds.h: Rename include guard.
 882         * charset-list.h: Add include guard.
 883         * buildsym-legacy.h: Rename include guard.
 884         * bfin-tdep.h: Add include guard.
 885         * ax.h: Rename include guard.
 886         * arm-linux-tdep.h: Add include guard.
 887         * arm-fbsd-tdep.h: Add include guard.
 888         * arch/xtensa.h: Rename include guard.
 889         * arch/tic6x.h: Add include guard.
 890         * arch/i386.h: Add include guard.
 891         * arch/arm.h: Rename include guard.
 892         * arch/arm-linux.h: Rename include guard.
 893         * arch/arm-get-next-pcs.h: Rename include guard.
 894         * arch/amd64.h: Add include guard.
 895         * arch/aarch64-insn.h: Rename include guard.
 896         * arch-utils.h: Rename include guard.
 897         * annotate.h: Add include guard.
 898         * amd64-darwin-tdep.h: Rename include guard.
 899         * aarch64-linux-tdep.h: Add include guard.
 900         * aarch64-fbsd-tdep.h: Add include guard.
 901         * aarch32-linux-nat.h: Add include guard.
 902
 903 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 904
 905         * macrotab.c (macro_define_internal): New function that
 906         factorizes macro_define_object_internal and macro_define_function
 907         code.
 908         (macro_define_object_internal): Use macro_define_internal.
 909         (macro_define_function): Likewise.
 910
 911 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 912
 913         * macrocmd.c (extract_identifier): Return
 914         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 915         callers.
 916
 917 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 918
 919         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 920
 921 2019-02-05  Tom Tromey  <tom@tromey.com>
 922
 923         * target.c (target_stack::unpush): Move assertion earlier.
 924
 925 2019-01-30  Tom Tromey  <tom@tromey.com>
 926
 927         PR python/23615:
 928         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 929         (gdbpy_parse_and_eval): Likewise.
 930         * python/python-internal.h (gdbpy_allow_threads): New class.
 931
 932 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 933
 934         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 935         (aarch64_fbsd_fpregmap): Move earlier.
 936         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 937         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 938         instead of individual calls to trad_frame_set_reg_addr.
 939         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 940         earlier.
 941         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 942         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 943         instead of individual calls to trad_frame_set_reg_addr.
 944
 945 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 946
 947         * CONTRIBUTE: Replace contribution list with wiki link.
 948
 949 2019-01-25  Tom Tromey  <tom@tromey.com>
 950
 951         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 952
 953 2019-01-25  Tom Tromey  <tom@tromey.com>
 954
 955         * xtensa-linux-nat.c: Fix common/ includes.
 956         * xml-support.h: Fix common/ includes.
 957         * xml-support.c: Fix common/ includes.
 958         * x86-linux-nat.c: Fix common/ includes.
 959         * windows-nat.c: Fix common/ includes.
 960         * varobj.h: Fix common/ includes.
 961         * varobj.c: Fix common/ includes.
 962         * value.c: Fix common/ includes.
 963         * valops.c: Fix common/ includes.
 964         * utils.c: Fix common/ includes.
 965         * unittests/xml-utils-selftests.c: Fix common/ includes.
 966         * unittests/utils-selftests.c: Fix common/ includes.
 967         * unittests/unpack-selftests.c: Fix common/ includes.
 968         * unittests/tracepoint-selftests.c: Fix common/ includes.
 969         * unittests/style-selftests.c: Fix common/ includes.
 970         * unittests/string_view-selftests.c: Fix common/ includes.
 971         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 972         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 973         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 974         * unittests/rsp-low-selftests.c: Fix common/ includes.
 975         * unittests/parse-connection-spec-selftests.c: Fix common/
 976         includes.
 977         * unittests/optional-selftests.c: Fix common/ includes.
 978         * unittests/offset-type-selftests.c: Fix common/ includes.
 979         * unittests/observable-selftests.c: Fix common/ includes.
 980         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 981         * unittests/memrange-selftests.c: Fix common/ includes.
 982         * unittests/memory-map-selftests.c: Fix common/ includes.
 983         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 984         * unittests/function-view-selftests.c: Fix common/ includes.
 985         * unittests/environ-selftests.c: Fix common/ includes.
 986         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 987         * unittests/common-utils-selftests.c: Fix common/ includes.
 988         * unittests/cli-utils-selftests.c: Fix common/ includes.
 989         * unittests/array-view-selftests.c: Fix common/ includes.
 990         * ui-file.c: Fix common/ includes.
 991         * tui/tui-io.c: Fix common/ includes.
 992         * tracepoint.h: Fix common/ includes.
 993         * tracepoint.c: Fix common/ includes.
 994         * tracefile-tfile.c: Fix common/ includes.
 995         * top.h: Fix common/ includes.
 996         * top.c: Fix common/ includes.
 997         * thread.c: Fix common/ includes.
 998         * target/waitstatus.h: Fix common/ includes.
 999         * target/waitstatus.c: Fix common/ includes.
1000         * target.h: Fix common/ includes.
1001         * target.c: Fix common/ includes.
1002         * target-memory.c: Fix common/ includes.
1003         * target-descriptions.c: Fix common/ includes.
1004         * symtab.h: Fix common/ includes.
1005         * symfile.c: Fix common/ includes.
1006         * stap-probe.c: Fix common/ includes.
1007         * spu-linux-nat.c: Fix common/ includes.
1008         * sparc-nat.c: Fix common/ includes.
1009         * source.c: Fix common/ includes.
1010         * solib.c: Fix common/ includes.
1011         * solib-target.c: Fix common/ includes.
1012         * ser-unix.c: Fix common/ includes.
1013         * ser-tcp.c: Fix common/ includes.
1014         * ser-pipe.c: Fix common/ includes.
1015         * ser-base.c: Fix common/ includes.
1016         * selftest-arch.c: Fix common/ includes.
1017         * s12z-tdep.c: Fix common/ includes.
1018         * rust-exp.y: Fix common/ includes.
1019         * rs6000-aix-tdep.c: Fix common/ includes.
1020         * riscv-tdep.c: Fix common/ includes.
1021         * remote.c: Fix common/ includes.
1022         * remote-notif.h: Fix common/ includes.
1023         * remote-fileio.h: Fix common/ includes.
1024         * remote-fileio.c: Fix common/ includes.
1025         * regcache.h: Fix common/ includes.
1026         * regcache.c: Fix common/ includes.
1027         * record-btrace.c: Fix common/ includes.
1028         * python/python.c: Fix common/ includes.
1029         * python/py-type.c: Fix common/ includes.
1030         * python/py-inferior.c: Fix common/ includes.
1031         * progspace.h: Fix common/ includes.
1032         * producer.c: Fix common/ includes.
1033         * procfs.c: Fix common/ includes.
1034         * proc-api.c: Fix common/ includes.
1035         * printcmd.c: Fix common/ includes.
1036         * ppc-linux-nat.c: Fix common/ includes.
1037         * parser-defs.h: Fix common/ includes.
1038         * osdata.c: Fix common/ includes.
1039         * obsd-nat.c: Fix common/ includes.
1040         * nat/x86-linux.c: Fix common/ includes.
1041         * nat/x86-linux-dregs.c: Fix common/ includes.
1042         * nat/x86-dregs.h: Fix common/ includes.
1043         * nat/x86-dregs.c: Fix common/ includes.
1044         * nat/ppc-linux.c: Fix common/ includes.
1045         * nat/mips-linux-watch.h: Fix common/ includes.
1046         * nat/mips-linux-watch.c: Fix common/ includes.
1047         * nat/linux-waitpid.c: Fix common/ includes.
1048         * nat/linux-ptrace.h: Fix common/ includes.
1049         * nat/linux-ptrace.c: Fix common/ includes.
1050         * nat/linux-procfs.c: Fix common/ includes.
1051         * nat/linux-personality.c: Fix common/ includes.
1052         * nat/linux-osdata.c: Fix common/ includes.
1053         * nat/linux-namespaces.c: Fix common/ includes.
1054         * nat/linux-btrace.h: Fix common/ includes.
1055         * nat/linux-btrace.c: Fix common/ includes.
1056         * nat/fork-inferior.c: Fix common/ includes.
1057         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1058         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1059         * nat/aarch64-linux.c: Fix common/ includes.
1060         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1061         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1062         * namespace.h: Fix common/ includes.
1063         * mips-linux-tdep.c: Fix common/ includes.
1064         * minsyms.c: Fix common/ includes.
1065         * mi/mi-parse.h: Fix common/ includes.
1066         * mi/mi-main.c: Fix common/ includes.
1067         * mi/mi-cmd-env.c: Fix common/ includes.
1068         * memrange.h: Fix common/ includes.
1069         * memattr.c: Fix common/ includes.
1070         * maint.h: Fix common/ includes.
1071         * maint.c: Fix common/ includes.
1072         * main.c: Fix common/ includes.
1073         * machoread.c: Fix common/ includes.
1074         * location.c: Fix common/ includes.
1075         * linux-thread-db.c: Fix common/ includes.
1076         * linux-nat.c: Fix common/ includes.
1077         * linux-fork.c: Fix common/ includes.
1078         * inline-frame.c: Fix common/ includes.
1079         * infrun.c: Fix common/ includes.
1080         * inflow.c: Fix common/ includes.
1081         * inferior.h: Fix common/ includes.
1082         * inferior.c: Fix common/ includes.
1083         * infcmd.c: Fix common/ includes.
1084         * inf-ptrace.c: Fix common/ includes.
1085         * inf-child.c: Fix common/ includes.
1086         * ia64-linux-nat.c: Fix common/ includes.
1087         * i387-tdep.c: Fix common/ includes.
1088         * i386-tdep.c: Fix common/ includes.
1089         * i386-linux-tdep.c: Fix common/ includes.
1090         * i386-linux-nat.c: Fix common/ includes.
1091         * i386-go32-tdep.c: Fix common/ includes.
1092         * i386-fbsd-tdep.c: Fix common/ includes.
1093         * i386-fbsd-nat.c: Fix common/ includes.
1094         * guile/scm-type.c: Fix common/ includes.
1095         * guile/guile.c: Fix common/ includes.
1096         * go32-nat.c: Fix common/ includes.
1097         * gnu-nat.c: Fix common/ includes.
1098         * gdbthread.h: Fix common/ includes.
1099         * gdbarch-selftests.c: Fix common/ includes.
1100         * gdb_usleep.c: Fix common/ includes.
1101         * gdb_select.h: Fix common/ includes.
1102         * gdb_bfd.c: Fix common/ includes.
1103         * gcore.c: Fix common/ includes.
1104         * fork-child.c: Fix common/ includes.
1105         * findvar.c: Fix common/ includes.
1106         * fbsd-nat.c: Fix common/ includes.
1107         * event-top.c: Fix common/ includes.
1108         * event-loop.c: Fix common/ includes.
1109         * dwarf2read.c: Fix common/ includes.
1110         * dwarf2loc.c: Fix common/ includes.
1111         * dwarf2-frame.c: Fix common/ includes.
1112         * dwarf-index-cache.c: Fix common/ includes.
1113         * dtrace-probe.c: Fix common/ includes.
1114         * disasm-selftests.c: Fix common/ includes.
1115         * defs.h: Fix common/ includes.
1116         * csky-tdep.c: Fix common/ includes.
1117         * cp-valprint.c: Fix common/ includes.
1118         * cp-support.h: Fix common/ includes.
1119         * cp-support.c: Fix common/ includes.
1120         * corelow.c: Fix common/ includes.
1121         * completer.h: Fix common/ includes.
1122         * completer.c: Fix common/ includes.
1123         * compile/compile.c: Fix common/ includes.
1124         * compile/compile-loc2c.c: Fix common/ includes.
1125         * compile/compile-cplus-types.c: Fix common/ includes.
1126         * compile/compile-cplus-symbols.c: Fix common/ includes.
1127         * command.h: Fix common/ includes.
1128         * cli/cli-dump.c: Fix common/ includes.
1129         * cli/cli-cmds.c: Fix common/ includes.
1130         * charset.c: Fix common/ includes.
1131         * build-id.c: Fix common/ includes.
1132         * btrace.h: Fix common/ includes.
1133         * btrace.c: Fix common/ includes.
1134         * breakpoint.h: Fix common/ includes.
1135         * breakpoint.c: Fix common/ includes.
1136         * ax.h:
1137         (enum agent_op): Fix common/ includes.
1138         * ax-general.c (struct aop_map): Fix common/ includes.
1139         * ax-gdb.c: Fix common/ includes.
1140         * auxv.c: Fix common/ includes.
1141         * auto-load.c: Fix common/ includes.
1142         * arm-tdep.c: Fix common/ includes.
1143         * arch/riscv.c: Fix common/ includes.
1144         * arch/ppc-linux-common.c: Fix common/ includes.
1145         * arch/i386.c: Fix common/ includes.
1146         * arch/arm.c: Fix common/ includes.
1147         * arch/arm-linux.c: Fix common/ includes.
1148         * arch/arm-get-next-pcs.c: Fix common/ includes.
1149         * arch/amd64.c: Fix common/ includes.
1150         * arch/aarch64.c: Fix common/ includes.
1151         * arch/aarch64-insn.c: Fix common/ includes.
1152         * arch-utils.c: Fix common/ includes.
1153         * amd64-windows-tdep.c: Fix common/ includes.
1154         * amd64-tdep.c: Fix common/ includes.
1155         * amd64-sol2-tdep.c: Fix common/ includes.
1156         * amd64-obsd-tdep.c: Fix common/ includes.
1157         * amd64-nbsd-tdep.c: Fix common/ includes.
1158         * amd64-linux-tdep.c: Fix common/ includes.
1159         * amd64-linux-nat.c: Fix common/ includes.
1160         * amd64-fbsd-tdep.c: Fix common/ includes.
1161         * amd64-fbsd-nat.c: Fix common/ includes.
1162         * amd64-dicos-tdep.c: Fix common/ includes.
1163         * amd64-darwin-tdep.c: Fix common/ includes.
1164         * agent.c: Fix common/ includes.
1165         * ada-lang.h: Fix common/ includes.
1166         * ada-lang.c: Fix common/ includes.
1167         * aarch64-tdep.c: Fix common/ includes.
1168
1169 2019-01-25  Tom Tromey  <tom@tromey.com>
1170
1171         * common/create-version.sh: Use common/version.h.
1172
1173 2019-01-24  Pedro Alves  <palves@redhat.com>
1174
1175         * infrun.c (signal_stop, signal_print, signal_program)
1176         (signal_catch, signal_pass): Now arrays instead of pointers.
1177         (update_signals_program_target, do_target_resume)
1178         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1179         * linux-nat.c (linux_nat_target::pass_signals)
1180         (linux_nat_target::create_inferior, linux_nat_target::attach):
1181         Adjust.
1182         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1183         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1184         * procfs.c (procfs_target::pass_signals): Adjust.
1185         * record-full.c (record_full_target::resume): Adjust.
1186         * remote.c (remote_target::pass_signals)
1187         (remote_target::program_signals): Adjust.
1188         * target-debug.h (target_debug_print_signals): Now takes a
1189         gdb::array_view as parameter.  Adjust.
1190         * target.h (target_ops) <pass_signals, program_signals>: Replace
1191         pointer and length parameters with gdb::array_view.
1192         (target_pass_signals, target_program_signals): Likewise.
1193         * target-delegates.c: Regenerate.
1194
1195 2019-01-24  Pedro Alves  <palves@redhat.com>
1196
1197         * common/forward-scope-exit.h
1198         (forward_scope_exit::forward_scope_exit): Pass arguments to
1199         m_bind_function directly, instead of creating a std::bind and
1200         copying that.
1201
1202 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1203
1204         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1205         for static members.
1206         (pass_in_v_vfp_candidate): Likewise.
1207
1208 2019-01-23  Tom Tromey  <tom@tromey.com>
1209             Pedro Alves  <palves@redhat.com>
1210
1211         * regcache.c (class regcache_invalidator): Remove.
1212         (regcache::raw_write): Use make_scope_exit.
1213
1214 2019-01-23  Tom Tromey  <tom@tromey.com>
1215
1216         * ui-out.h (class ui_out_emit_type): Update comment.
1217
1218 2019-01-23  Tom Tromey  <tom@tromey.com>
1219
1220         * infrun.c (fetch_inferior_event): Update comment.
1221
1222 2019-01-23  Tom Tromey  <tom@tromey.com>
1223             Pedro Alves  <palves@redhat.com>
1224
1225         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1226         parameter.
1227         (fetch_inferior_event): Use SCOPE_EXIT.
1228
1229
1230 2019-01-23  Tom Tromey  <tom@tromey.com>
1231             Pedro Alves  <palves@redhat.com>
1232
1233         * infrun.c (disable_thread_events): Delete.
1234         (stop_all_threads): Use SCOPE_EXIT.
1235
1236 2019-01-23  Tom Tromey  <tom@tromey.com>
1237             Pedro Alves  <palves@redhat.com>
1238
1239         * symfile.c: Include forward-scope-exit.h.
1240         (clear_symtab_users_cleanup): Replace forward declaration with
1241         a FORWARD_SCOPE_EXIT.
1242         (syms_from_objfile_1): Use the forward_scope_exit and
1243         gdb::optional instead of cleanup_function.
1244         (reread_symbols): Use the forward_scope_exit instead of
1245         cleanup_function.
1246         (clear_symtab_users_cleanup): Remove function.
1247
1248 2019-01-23  Tom Tromey  <tom@tromey.com>
1249             Pedro Alves  <palves@redhat.com>
1250
1251         * linux-nat.c: Include scope-exit.h.
1252         (cleanup_target_stop): Remove.
1253         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1254         SCOPE_EXIT.
1255
1256 2019-01-23  Tom Tromey  <tom@tromey.com>
1257             Pedro Alves  <palves@redhat.com>
1258
1259         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1260         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1261
1262 2019-01-23  Tom Tromey  <tom@tromey.com>
1263             Andrew Burgess  <andrew.burgess@embecosm.com>
1264             Pedro Alves  <palves@redhat.com>
1265
1266         * infrun.c (fetch_inferior_event): Use scope_exit.
1267         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1268         * top.c (execute_command): Use scope_exit.
1269         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1270         * utils.c (do_bpstat_clear_actions_cleanup)
1271         (make_bpstat_clear_actions_cleanup): Remove.
1272
1273 2019-01-23  Tom Tromey  <tom@tromey.com>
1274             Pedro Alves  <palves@redhat.com>
1275
1276         * infrun.c: Include "common/scope-exit.h"
1277         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1278         (wait_for_inferior): Use SCOPE_EXIT.
1279         (fetch_inferior_event): Use scope_exit.
1280
1281 2019-01-23  Tom Tromey  <tom@tromey.com>
1282             Pedro Alves  <palves@redhat.com>
1283
1284         * breakpoint.c (create_breakpoint): Remove cleanup.
1285
1286 2019-01-23  Tom Tromey  <tom@tromey.com>
1287             Andrew Burgess  <andrew.burgess@embecosm.com>
1288             Pedro Alves  <palves@redhat.com>
1289
1290 2019-01-23  Pedro Alves  <palves@redhat.com>
1291
1292         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1293
1294 2019-01-23  Pedro Alves  <palves@redhat.com>
1295             Andrew Burgess  <andrew.burgess@embecosm.com>
1296
1297         * gdbthread.h: Include "common/forward-scope-exit.h".
1298         (scoped_finish_thread_state): Redefine custom class in terms of
1299         forward_scope_exit.
1300
1301 2019-01-23  Pedro Alves  <palves@redhat.com>
1302             Andrew Burgess  <andrew.burgess@embecosm.com>
1303
1304         * common/forward-scope-exit.h: New file.
1305
1306 2019-01-23  Pedro Alves  <palves@redhat.com>
1307             Andrew Burgess  <andrew.burgess@embecosm.com>
1308             Tom Tromey  <tom@tromey.com>
1309
1310         * common/scope-exit.h: New file.
1311
1312 2019-01-23  Pedro Alves  <palves@redhat.com>
1313
1314         * common/preprocessor.h (ESC): Rename to ...
1315         (ESC_PARENS): ... this.
1316         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1317         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1318
1319 2019-01-23  Tom Tromey  <tom@tromey.com>
1320
1321         * language.h (class scoped_switch_to_sym_language_if_auto):
1322         Initialize m_lang in both cases.
1323
1324 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1325
1326         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1327         with XCNEW.
1328
1329 2019-01-22  Tom Tromey  <tom@tromey.com>
1330
1331         * corelow.c: Do not include sys/file.h.
1332
1333 2019-01-22  Tom Tromey  <tom@tromey.com>
1334
1335         * tui/tui-wingeneral.h: Include gdb_curses.h.
1336
1337 2019-01-22  Tom Tromey  <tom@tromey.com>
1338
1339         * source-cache.h (class source_cache) <get_source_lines,
1340         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1341
1342 2019-01-22  Tom Tromey  <tom@tromey.com>
1343
1344         * remote-fileio.h (struct remote_target): Declare.
1345
1346 2019-01-22  Tom Tromey  <tom@tromey.com>
1347
1348         * python/py-arch.c: Do not include py-ref.h.
1349         * python/py-bpevent.c: Do not include py-ref.h.
1350         * python/py-cmd.c: Do not include py-ref.h.
1351         * python/py-continueevent.c: Do not include py-ref.h.
1352         * python/py-event.h: Do not include py-ref.h.
1353         * python/py-evtregistry.c: Do not include py-ref.h.
1354         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1355         * python/py-frame.c: Do not include py-ref.h.
1356         * python/py-framefilter.c: Do not include py-ref.h.
1357         * python/py-function.c: Do not include py-ref.h.
1358         * python/py-infevents.c: Do not include py-ref.h.
1359         * python/py-linetable.c: Do not include py-ref.h.
1360         * python/py-objfile.c: Do not include py-ref.h.
1361         * python/py-param.c: Do not include py-ref.h.
1362         * python/py-prettyprint.c: Do not include py-ref.h.
1363         * python/py-progspace.c: Do not include py-ref.h.
1364         * python/py-symbol.c: Do not include py-ref.h.
1365         * python/py-symtab.c: Do not include py-ref.h.
1366         * python/py-type.c: Do not include py-ref.h.
1367         * python/py-unwind.c: Do not include py-ref.h.
1368         * python/py-utils.c: Do not include py-ref.h.
1369         * python/py-value.c: Do not include py-ref.h.
1370         * python/py-varobj.c: Do not include py-ref.h.
1371         * python/py-xmethods.c: Do not include py-ref.h.
1372         * python/python.c: Do not include py-ref.h.
1373         * varobj.c: Do not include py-ref.h.
1374
1375 2019-01-22  Tom Tromey  <tom@tromey.com>
1376
1377         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1378         keyword for bcache.
1379
1380 2019-01-22  Tom Tromey  <tom@tromey.com>
1381
1382         * compile/compile-cplus-types.c: Remove a comment by #include.
1383
1384 2019-01-22  Tom Tromey  <tom@tromey.com>
1385
1386         * compile/gcc-c-plugin.h: Include compile-internal.h.
1387
1388 2019-01-22  Tom Tromey  <tom@tromey.com>
1389
1390         * stabsread.c (EXTERN): Do not define.
1391         (symnum, next_symbol_text_func, processing_gcc_compilation)
1392         (within_function, global_sym_chain, global_stabs)
1393         (previous_stab_code, this_object_header_files)
1394         (n_this_object_header_files)
1395         (n_allocated_this_object_header_files): Define.
1396         * stabsread.h (EXTERN): Never define.  Use "extern".
1397
1398 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1399
1400         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1401         history_value.
1402
1403 2019-01-21  Tom Tromey  <tom@tromey.com>
1404
1405         * ui-out.c: Fix includes.
1406         * tui/tui-source.c: Fix includes.
1407         * target.c: Fix includes.
1408         * remote.c: Fix includes.
1409         * regcache.c: Fix includes.
1410         * python/py-block.c: Fix includes.
1411         * printcmd.c: Fix includes.
1412         * or1k-tdep.c: Fix includes.
1413         * mi/mi-main.c: Fix includes.
1414         * m32r-tdep.c: Fix includes.
1415         * csky-tdep.c: Fix includes.
1416         * compile/compile-cplus-types.c: Fix includes.
1417         * cli/cli-interp.c: Fix includes.
1418
1419 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1420
1421         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1422         for padding.
1423
1424 2019-01-16  Tom Tromey  <tom@tromey.com>
1425
1426         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1427         earlier.
1428         (struct objfile) <msymbols_range>: Move from top level.
1429         <msymbols>: New method.
1430         (class objfile_msymbols): Remove.
1431         * symtab.c (default_collect_symbol_completion_matches_break_on):
1432         Update.
1433         * symmisc.c (dump_msymbols): Update.
1434         * stabsread.c (scan_file_globals): Update.
1435         * objc-lang.c (info_selectors_command, info_classes_command)
1436         (find_methods): Update.
1437         * minsyms.c (find_solib_trampoline_target): Update.
1438         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1439         * coffread.c (coff_symfile_read): Update.
1440         * ada-lang.c (ada_lookup_simple_minsym)
1441         (ada_collect_symbol_completion_matches): Update.
1442
1443 2019-01-16  Tom Tromey  <tom@tromey.com>
1444
1445         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1446         type.  Remove no-argument constructor.
1447         <iterator::operator++>: Simplify.
1448         <begin>: Update.
1449         <end>: Use minimal_symbol_count.
1450
1451 2019-01-16  Tom Tromey  <tom@tromey.com>
1452
1453         * objfiles.h (struct objfile) <psymtabs>: New method.
1454         (class objfile_psymtabs): Remove.
1455         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1456         typedef.
1457         <range>: New method.
1458         (require_partial_symbols): Change return type.
1459         * psymtab.c (require_partial_symbols)
1460         (psym_expand_symtabs_matching): Update.
1461         * mdebugread.c (parse_partial_symbols): Update.
1462         * dbxread.c (dbx_end_psymtab): Update.
1463
1464 2019-01-15  Tom Tromey  <tom@tromey.com>
1465
1466         * symtab.c (lookup_objfile_from_block)
1467         (lookup_symbol_in_objfile_symtabs)
1468         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1469         (find_line_symtab, info_sources_command)
1470         (default_collect_symbol_completion_matches_break_on)
1471         (make_source_files_completion_list): Update.
1472         * symmisc.c (print_objfile_statistics, dump_objfile)
1473         (maintenance_print_symbols, maintenance_info_symtabs)
1474         (maintenance_check_symtabs, maintenance_info_line_tables):
1475         Update.
1476         * source.c (select_source_symtab)
1477         (forget_cached_source_info_for_objfile): Update.
1478         * objfiles.h (class objfile_compunits): Remove.
1479         (struct objfile) <compunits_range>: New typedef.
1480         (compunits): New method.
1481         * objfiles.c (objfile_relocate1): Update.
1482         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1483         * maint.c (count_symtabs_and_blocks): Update.
1484         * linespec.c (iterate_over_all_matching_symtabs): Update.
1485         * cp-support.c (add_symbol_overload_list_qualified): Update.
1486         * coffread.c (coff_symtab_read): Update.
1487         * ada-lang.c (add_nonlocal_symbols)
1488         (ada_collect_symbol_completion_matches)
1489         (ada_add_global_exceptions): Update.
1490
1491 2019-01-15  Tom Tromey  <tom@tromey.com>
1492
1493         * progspace.h (program_space) <objfiles_safe_range>: New
1494         typedef.
1495         <objfiles_safe>: New method.
1496         * objfiles.h (class all_objfiles_safe): Remove.
1497         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1498         * jit.c (jit_inferior_exit_hook): Update.
1499
1500 2019-01-17  Tom Tromey  <tom@tromey.com>
1501
1502         * progspace.h (program_space) <objfiles_range>: New typedef.
1503         <objfiles>: New method.
1504         <objfiles_head>: Rename from objfiles.
1505         (object_files): Update.
1506         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1507         * guile/scm-pretty-print.c
1508         (ppscm_find_pretty_printer_from_objfiles): Update.
1509         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1510         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1511         Update.
1512         * python/py-progspace.c (pspy_get_objfiles): Update.
1513         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1514         Update.
1515         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1516         (objfpy_lookup_objfile_by_build_id): Update.
1517         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1518         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1519         Update.
1520         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1521         (expand_symtab_containing_pc, lookup_objfile_from_block)
1522         (lookup_static_symbol, basic_lookup_transparent_type)
1523         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1524         (find_line_symtab, info_sources_command)
1525         (default_collect_symbol_completion_matches_break_on)
1526         (make_source_files_completion_list, find_main_name): Update.
1527         * symmisc.c (print_symbol_bcache_statistics)
1528         (print_objfile_statistics, maintenance_print_symbols)
1529         (maintenance_print_msymbols, maintenance_print_objfiles)
1530         (maintenance_info_symtabs, maintenance_check_symtabs)
1531         (maintenance_expand_symtabs, maintenance_info_line_tables):
1532         Update.
1533         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1534         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1535         (map_overlay_command, unmap_overlay_command)
1536         (simple_overlay_update, expand_symtabs_matching)
1537         (map_symbol_filenames): Update.
1538         * symfile-debug.c (set_debug_symfile): Update.
1539         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1540         Update.
1541         * source.c (select_source_symtab, forget_cached_source_info):
1542         Update.
1543         * solib.c (solib_read_symbols): Update.
1544         * solib-spu.c (append_ocl_sos): Update.
1545         * psymtab.c (maintenance_print_psymbols)
1546         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1547         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1548         * printcmd.c (info_symbol_command): Update.
1549         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1550         Update.
1551         * objfiles.h (class all_objfiles): Remove.
1552         * objfiles.c (have_partial_symbols, have_full_symbols)
1553         (have_minimal_symbols, qsort_cmp, update_section_map)
1554         (shared_objfile_contains_address_p)
1555         (default_iterate_over_objfiles_in_search_order): Update.
1556         * objc-lang.c (info_selectors_command, info_classes_command)
1557         (find_methods): Update.
1558         * minsyms.c (find_solib_trampoline_target): Update.
1559         * maint.c (maintenance_info_sections)
1560         (maintenance_translate_address, count_symtabs_and_blocks):
1561         Update.
1562         * main.c (captured_main_1): Update.
1563         * linux-thread-db.c (try_thread_db_load_from_pdir)
1564         (has_libpthread): Update.
1565         * linespec.c (iterate_over_all_matching_symtabs)
1566         (search_minsyms_for_name): Update.
1567         * jit.c (jit_find_objf_with_entry_addr): Update.
1568         * hppa-tdep.c (find_unwind_entry)
1569         (hppa_lookup_stub_minimal_symbol): Update.
1570         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1571         Update.
1572         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1573         (elf_gnu_ifunc_resolve_by_got): Update.
1574         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1575         * dwarf-index-write.c (save_gdb_index_command): Update.
1576         * cp-support.c (add_symbol_overload_list_qualified): Update.
1577         * breakpoint.c (create_overlay_event_breakpoint)
1578         (create_longjmp_master_breakpoint)
1579         (create_std_terminate_master_breakpoint)
1580         (create_exception_master_breakpoint): Update.
1581         * blockframe.c (find_pc_partial_function): Update.
1582         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1583         (ada_collect_symbol_completion_matches)
1584         (ada_add_global_exceptions): Update.
1585
1586 2019-01-17  Tom Tromey  <tom@tromey.com>
1587
1588         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1589         declare VEC.
1590         (solib_target_parse_libraries): Change return type.
1591         (library_list_start_segment, library_list_start_section)
1592         (library_list_end_library, library_list_start_library); Update.
1593         (solib_target_free_library_list): Remove.
1594         (solib_target_parse_libraries): Remove cleanup.  Change return
1595         type.
1596         (solib_target_current_sos): Update.
1597
1598 2019-01-17  Tom Tromey  <tromey@bapiya>
1599
1600         * valprint.c: Replace "the the" with "the".
1601         * symtab.c: Replace "the the" with "the".
1602         * solib.c: Replace "the the" with "the".
1603         * solib-dsbt.c: Replace "the the" with "the".
1604         * linespec.c: Replace "the the" with "the".
1605         * dwarf2loc.h: Replace "the the" with "the".
1606         * amd64-windows-tdep.c: Replace "the the" with "the".
1607         * aarch64-tdep.c: Replace "the the" with "the".
1608
1609 2019-01-16  Keith Seitz  <keiths@redhat.com>
1610
1611         PR gdb/23773
1612         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1613         <builder>: Rename to ..
1614         <m_builder>: ... this and make private.
1615         (dwarf2_cu::get_builder): New method.  Change all users of
1616         `builder' to use this method.
1617         (dwarf2_start_symtab): Move to ...
1618         (dwarf2_cu::start_symtab): ... here.  Update all callers
1619         (setup_type_unit_groups): Move to ...
1620         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1621         callers.
1622         (dwarf2_cu::reset_builder): New method.
1623         (process_full_compunit, process_full_type_unit): Use
1624         dwarf2_cu::reset_builder.
1625         (follow_die_offset): Record the ancestor CU if it is different
1626         from the followed DIE's CU.
1627         (follow_die_sig_1): Likewise.
1628
1629 2019-01-15  Tom Tromey  <tom@tromey.com>
1630
1631         * remote.c (class remote_state) <buf>: Now a char_vector.
1632         <buf_size>: Remove.
1633         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1634         parameter.
1635         (remote_target::getpkt_or_notif_sane_1)
1636         (remote_target::getpkt_sane)
1637         (remote_target::getpkt_or_notif_sane): Likewise.
1638         (class remote_target) <putpkt>: New overload.
1639         (remote_target::read_frame): Change type of "buf_p".  Remove
1640         sizeof_p parameter.
1641         (packet_ok): New overload.
1642         (packet_check_result): New overload.
1643         Update all uses.
1644
1645 2019-01-14  Tom Tromey  <tom@tromey.com>
1646
1647         * remote-notif.c (handle_notification, remote_notif_ack)
1648         (remote_notif_parse): Make "buf" const.
1649         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1650         const.
1651         (remote_notif_parse, remote_notif_ack, handle_notification):
1652         Likewise.
1653         * remote.c (remote_notif_stop_parse): Make "buf" const.
1654         (remote_target::remote_parse_stop_reply): Make "buf" const.
1655         (remote_notif_stop_ack): Make "buf" const.
1656
1657 2019-01-14  Tom Tromey  <tom@tromey.com>
1658
1659         * remote.c (remote_console_output): Make parameter const.
1660
1661 2019-01-14  Tom Tromey  <tom@tromey.com>
1662
1663         * target-debug.h (target_debug_print_signals): Constify.
1664         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1665         * procfs.c (procfs_target::pass_signals): Update.
1666         * linux-nat.c (linux_nat_target::pass_signals): Update.
1667         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1668         * target-delegates.c: Rebuild.
1669         * remote.c (remote_target::program_signals): Update.
1670         (remote_target::pass_signals): Update.
1671         * target.c (target_pass_signals): Constify argument.
1672         (target_program_signals): Likewise.
1673         * target.h (struct target_ops) <pass_signals, program_signals>:
1674         Constify argument.
1675         (target_pass_signals, target_program_signals): Constify argument.
1676
1677 2019-01-14  Tom Tromey  <tom@tromey.com>
1678
1679         PR tui/28819:
1680         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1681
1682 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1683
1684         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1685         field.
1686         * rs6000-tdep.c: Include reggroups.h.
1687         (IS_V_ALIAS_PSEUDOREG): Define.
1688         (rs6000_register_name): Return names for the "vX" aliases.
1689         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1690         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1691         aliases.  Call default_register_reggroup_p for all other
1692         pseudo-registers.
1693         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1694         New functions.
1695         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1696         Handle "vX" aliases.
1697         (v_alias_pseudo_register_collect): New function.
1698         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1699         (rs6000_gdbarch_init): Initialize "vX" aliases as
1700         pseudo-registers.  Restore registration of
1701         rs6000_pseudo_register_reggroup_p with
1702         set_tdesc_pseudo_register_reggroup_p.
1703
1704 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1705
1706         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1707         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1708         set_gdbarch_num_pseudo_regs.
1709
1710 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1711
1712         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1713         Remove arg prefixname, add do_set and do_show.
1714         Add member functions set_list and show_list.
1715         * cli/cli-style.c (class cli_style_option): Update accordingly.
1716         (style_set_list): Move to file scope.
1717         (style_show_list): Likewise.
1718         (set_style): Call help_list.
1719         (show_style): Call cmd_show_list.
1720         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1721         Update to use the new macro.
1722
1723 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1724
1725         * ada-lang.c (_initialize_ada_language): Expand the help text
1726         for the "catch exception" command.
1727
1728 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1729
1730         * symtab.c (matching_obj_sections): Initialize obj,
1731         declare it closer to its usage.
1732
1733 2019-01-10  Tom Tromey  <tom@tromey.com>
1734
1735         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1736         (basic_inf_threads_range): Remove.
1737         (inf_threads_range, inf_non_exited_threads_range)
1738         (safe_inf_threads_range): Use next_adapter.
1739
1740 2019-01-10  Keith Seitz  <keiths@redhat.com>
1741
1742         PR gdb/23712
1743         PR symtab/23010
1744         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1745         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1746
1747 2019-01-10  Keith Seitz  <keiths@redhat.com>
1748
1749         PR gdb/23712
1750         PR symtab/23010
1751         * dictionary.c (pending_to_vector): Remove.
1752         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1753         Remove _1 suffix, replacing functions of the same name.  Update
1754         all callers.
1755         (dict_create_hashed, dict_create_hashed_expandable)
1756         (dict_create_linear, dict_create_linear_expandable, dict_free)
1757         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1758         Make functions static.
1759
1760 2019-01-10  Keith Seitz  <keiths@redhat.com>
1761
1762         PR gdb/23712
1763         PR symtab/23010
1764         * dictionary.h (struct dictionary): Replace declaration with
1765         multidictionary.
1766         (dict_create_hashed, dict_create_hashed_expandable)
1767         (dict_create_linear, dict_create_linear_expandable)
1768         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1769         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1770         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1771         taking multidictionary argument.
1772         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1773         * block.h (struct block) <dict>: Change to multidictionary
1774         and rename `multidict'.
1775         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1776         symmisc.c: Update all dictionary references to multidictionary.
1777
1778 2019-01-10  Keith Seitz  <keiths@redhat.com>
1779
1780         PR gdb/23712
1781         PR symtab/23010
1782         * dictionary.c: Include unordered_map.
1783         (pending_to_vector): New function.
1784         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1785         Rewrite the non-"_1" functions to take vector instead
1786         of linked list.
1787         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1788         "new" _1 versions of the same name.
1789         (multidictionary): Define.
1790         (std::hash<enum language): New definition.
1791         (collate_pending_symbols_by_language, mdict_create_hashed)
1792         (mdict_create_hashed_expandable, mdict_create_linear)
1793         (mdict_create_linear_expandable, mdict_free)
1794         (find_language_dictionary, create_new_language_dictionary)
1795         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1796         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1797         (mdict_size, mdict_empty): New functions.
1798         * dictionary.h (mdict_iterator): Define.
1799
1800 2019-01-10  Pedro Alves  <palves@redhat.com>
1801
1802         * breakpoint.c (read_uploaded_action)
1803         (create_tracepoint_from_upload): Adjust to use
1804         gdb::unique_xmalloc_ptr.
1805         * ctf.c (ctf_write_uploaded_tp):
1806         (SET_ARRAY_FIELD): Use emplace_back.
1807         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1808         * tracefile-tfile.c (tfile_write_uploaded_tp):
1809         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1810         gdb::unique_xmalloc_ptr.
1811         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1812         at_string, cond_string, cmd_strings>: Replace char pointers
1813         with gdb::unique_xmalloc_ptr.
1814
1815 2019-01-10  Pedro Alves  <palves@redhat.com>
1816
1817         * solib-target.c (library_list_start_library): Don't xstrdup name.
1818
1819 2019-01-10  Pedro Alves  <palves@redhat.com>
1820
1821         * mdebugread.c (parse_partial_symbols): Use
1822         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1823
1824 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1825
1826         * linux-fork.c (scoped_switch_fork_info)
1827         <~scoped_switch_fork_info>: Fix incorrect variable name.
1828
1829 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1830
1831         * linux-fork.c (scoped_switch_fork_info)
1832         <scoped_switch_fork_info>: Make explicit.
1833         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1834
1835 2019-01-10  Tom Tromey  <tom@tromey.com>
1836
1837         * objfiles.h (objfile::reset_psymtabs): Update.
1838         * objfiles.c (objfile::objfile): Update.
1839         * psymtab.h (psymtab_storage::obstack): Update.
1840         (psymtab_storage::m_obstack): Use gdb::optional.
1841         (class psymtab_storage): Update comment.  Remove objfile
1842         parameter.
1843         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1844
1845 2019-01-10  Tom Tromey  <tom@tromey.com>
1846
1847         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1848         <free_psymtabs>: Now private.
1849         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1850         (allocate_psymtab): Use new method.
1851
1852 2019-01-10  Tom Tromey  <tom@tromey.com>
1853
1854         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1855         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1856         * mdebugread.c (parse_partial_symbols): Use
1857         allocate_dependencies.
1858         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1859         allocate_dependencies.
1860         (process_psymtab_comp_unit_reader)
1861         (build_type_psymtab_dependencies): Likewise.
1862         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1863
1864 2019-01-10  Tom Tromey  <tom@tromey.com>
1865
1866         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1867         PSYMBOL_SET_LANGUAGE.
1868         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1869
1870 2019-01-10  Tom Tromey  <tom@tromey.com>
1871
1872         * psymtab.h (psymtab_storage::obstack): New method.
1873         <m_obstack>: Rename from obstack; now private.
1874         * psymtab.c (psymtab_storage): Update.
1875         * dwarf2read.c (create_addrmap_from_index)
1876         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1877         Update.
1878
1879 2019-01-10  Tom Tromey  <tom@tromey.com>
1880
1881         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1882         * objfiles.h (objfile::reset_psymtabs): New method.
1883
1884 2019-01-10  Tom Tromey  <tom@tromey.com>
1885
1886         * symmisc.c (print_symbol_bcache_statistics): Update.
1887         (print_objfile_statistics): Update.
1888         * symfile.c (reread_symbols): Update.
1889         * psymtab.h (class psymtab_storage): New.
1890         * psymtab.c (psymtab_storage): New constructor.
1891         (~psymtab_storage): New destructor.
1892         (require_partial_symbols): Update.
1893         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1894         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1895         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1896         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1897         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1898         (start_psymtab_common, end_psymtab_common)
1899         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1900         (allocate_psymtab): Update.
1901         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1902         Update.
1903         (dump_psymtab_addrmap, maintenance_print_psymbols)
1904         (maintenance_check_psymtabs): Update.
1905         (class objfile_psymtabs): Move to objfiles.h.
1906         * psympriv.h (discard_psymtab): Now inline.
1907         (psymtab_discarder::psymtab_discarder): Update.
1908         (psymtab_discarder::~psymtab_discarder): Update.
1909         (ALL_OBJFILE_PSYMTABS): Rewrite.
1910         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1911         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1912         Remove fields.
1913         <partial_symtabs>: New field.
1914         (class objfile_psymtabs): Move from psymtab.h.  Update.
1915         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1916         psymbol_cache.
1917         (objfile::~objfile): Don't destroy psymbol_cache.
1918         * mdebugread.c (parse_partial_symbols): Update.
1919         * dwarf2read.c (create_addrmap_from_index)
1920         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1921         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1922         (add_partial_subprogram, dwarf2_ranges_read): Update.
1923         * dwarf-index-write.c (write_address_map)
1924         (write_one_signatured_type, recursively_write_psymbols)
1925         (class debug_names, class debug_names, write_psymtabs_to_index):
1926         Update.
1927
1928 2019-01-10  Tom Tromey  <tom@tromey.com>
1929
1930         * symtab.h (SYMBOL_SET_NAMES): Update.
1931         (symbol_set_names): Update.
1932         (MSYMBOL_SET_NAMES): Update.
1933         * symtab.c (symbol_set_names): Change argument to be an
1934         objfile_per_bfd_storage.
1935         * psymtab.c (add_psymbol_to_bcache): Update.
1936         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1937
1938 2019-01-10  Tom Tromey  <tom@tromey.com>
1939
1940         * symtab.c (create_demangled_names_hash): Change argument to be an
1941         objfile_per_bfd_storage.
1942         (symbol_set_names): Update.
1943
1944 2019-01-10  Tom Tromey  <tom@tromey.com>
1945
1946         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1947         init_psymbol_list.
1948         * psymtab.c (init_psymbol_list): Do nothing if already called.
1949         * psympriv.h (init_psymbol_list): Add comment.
1950         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1951         init_psymbol_list.
1952         * dbxread.c (dbx_symfile_read): Unconditionally call
1953         init_psymbol_list.
1954
1955 2019-01-10  Tom Tromey  <tom@tromey.com>
1956
1957         * xcoffread.c (scan_xcoff_symtab): Update.
1958         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1959         "where".
1960         * mdebugread.c (parse_partial_symbols)
1961         (handle_psymbol_enumerators): Update.
1962         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1963         * dbxread.c (read_dbx_symtab): Update.
1964         * psympriv.h (psymbol_placement): New enum.
1965         (add_psymbol_to_list): Update.
1966
1967 2019-01-10  Tom Tromey  <tom@tromey.com>
1968
1969         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1970         static_psymbols parameters.
1971         (scan_xcoff_symtab): Update.
1972         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1973         static_psymbols parameters.
1974         * psympriv.h (start_psymtab_common): Update.
1975         * mdebugread.c (parse_partial_symbols): Update.
1976         * dwarf2read.c (create_partial_symtab): Update.
1977         * dbxread.c (read_dbx_symtab): Update.
1978         (start_psymtab): Remove global_psymbols and static_psymbols
1979         parameters.
1980
1981 2019-01-10  Tom Tromey  <tom@tromey.com>
1982
1983         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1984         * psymtab.c (allocate_psymtab): Add comment.
1985         * psympriv.h (allocate_psymtab): Add comment.
1986         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1987         initializations.
1988         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1989
1990 2019-01-10  Tom Tromey  <tom@tromey.com>
1991
1992         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1993         Don't declare.
1994         * mipsread.c: Include mdebugread.h.
1995         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1996         Declare.
1997         * elfread.c: Include mdebugread.h.
1998
1999 2019-01-09  Tom Tromey  <tom@tromey.com>
2000
2001         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2002         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2003         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2004         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2005         (psym_lookup_symbol, psym_find_last_source_symtab)
2006         (psym_forget_cached_source_info, psym_print_stats)
2007         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2008         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2009         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2010         (psym_find_compunit_symtab_by_address)
2011         (maintenance_print_psymbols, maintenance_info_psymtabs)
2012         (maintenance_check_psymtabs): Use ranged for.
2013         * psymtab.h (class objfile_psymtabs): New.
2014         (require_partial_symbols): Return objfile_psymtabs.
2015         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2016
2017 2019-01-09  Tom Tromey  <tom@tromey.com>
2018
2019         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2020         (find_pc_mapped_section, list_overlays_command)
2021         (map_overlay_command, unmap_overlay_command)
2022         (simple_overlay_update): Use all_objfiles.
2023         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2024         * printcmd.c (info_symbol_command): Use all_objfiles.
2025         * objfiles.h (ALL_OBJSECTIONS): Remove.
2026         * maint.c (maintenance_translate_address): Use all_objfiles.
2027         * gcore.c (gcore_create_callback): Use all_objfiles.
2028         (objfile_find_memory_regions): Likewise.
2029
2030 2019-01-09  Tom Tromey  <tom@tromey.com>
2031
2032         * symtab.c (find_line_symtab, info_sources_command)
2033         (make_source_files_completion_list): Use objfile_compunits.
2034         * source.c (select_source_symtab): Use objfile_compunits.
2035         * objfiles.h (struct objfile): Update comment.
2036         (ALL_OBJFILES): Remove.
2037         (ALL_FILETABS): Remove.
2038         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2039         objfile_compunits.
2040
2041 2019-01-09  Tom Tromey  <tom@tromey.com>
2042
2043         * symmisc.c (print_objfile_statistics, dump_objfile)
2044         (maintenance_print_symbols): Use compunit_filetabs.
2045         * source.c (forget_cached_source_info_for_objfile): Use
2046         compunit_filetabs.
2047         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2048         (ALL_FILETABS): Use compunit_filetabs.
2049         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2050         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2051
2052 2019-01-09  Tom Tromey  <tom@tromey.com>
2053
2054         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2055         (compunit_filetabs): New.
2056         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2057         compunit_filetabs.
2058         (info_sources_command, make_source_files_completion_list): Remove
2059         declaration.
2060         * symmisc.c (print_objfile_statistics, dump_objfile)
2061         (maintenance_print_symbols): Remove declaration.
2062         (maintenance_info_symtabs): Use compunit_filetabs.
2063         (maintenance_info_line_tables): Likewise.
2064         * source.c (select_source_symtab): Change local variable name.
2065         (forget_cached_source_info_for_objfile): Remove declaration.
2066         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2067         * objfiles.c (objfile_relocate1): Remove declaration.
2068         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2069         declaration.
2070         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2071         * coffread.c (coff_symtab_read): Remove declaration.
2072         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2073         compunit_filetabs.
2074
2075 2019-01-09  Tom Tromey  <tom@tromey.com>
2076
2077         * symtab.c (lookup_objfile_from_block)
2078         (find_pc_sect_compunit_symtab, search_symbols)
2079         (default_collect_symbol_completion_matches_break_on): Use
2080         objfile_compunits.
2081         * objfiles.h (ALL_COMPUNITS): Remove.
2082         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2083         * cp-support.c (add_symbol_overload_list_qualified): Use
2084         objfile_compunits.
2085         * ada-lang.c (ada_collect_symbol_completion_matches)
2086         (ada_add_global_exceptions): Use objfile_compunits.
2087
2088 2019-01-09  Tom Tromey  <tom@tromey.com>
2089
2090         * source.c (select_source_symtab)
2091         (forget_cached_source_info_for_objfile): Remove declaration.
2092         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2093         declaration.
2094         * maint.c (count_symtabs_and_blocks): Remove declaration.
2095         * cp-support.c (add_symbol_overload_list_qualified): Remove
2096         declaration.
2097         * coffread.c (coff_symtab_read): Remove declaration.
2098         * symtab.c (lookup_symbol_in_objfile_symtabs)
2099         (basic_lookup_transparent_type_1): Use objfile_compunits.
2100         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2101         (info_sources_command, search_symbols)
2102         (default_collect_symbol_completion_matches_break_on)
2103         (make_source_files_completion_list): Remove declaration.
2104         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2105         (ada_collect_symbol_completion_matches)
2106         (ada_add_global_exceptions): Remove declaration.
2107         * linespec.c (iterate_over_all_matching_symtabs): Use
2108         objfile_compunits.
2109         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2110         (class objfile_compunits): New.
2111         (ALL_COMPUNITS): Use objfile_compunits.
2112         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2113         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2114         objfile_compunits.
2115         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2116
2117 2019-01-09  Tom Tromey  <tom@tromey.com>
2118
2119         * symtab.c (search_symbols)
2120         (default_collect_symbol_completion_matches_break_on): Use
2121         objfile_msymbols.
2122         * ada-lang.c (ada_lookup_simple_minsym)
2123         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2124         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2125         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2126         objfile_msymbols.
2127         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2128         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2129         * objc-lang.c (find_methods): Use objfile_msymbols.
2130         (info_selectors_command, info_classes_command): Likewise.
2131         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2132         * objfiles.h (class objfile_msymbols): New.
2133         (ALL_OBJFILE_MSYMBOLS): Remove.
2134         (ALL_MSYMBOLS): Remove.
2135
2136 2019-01-09  Tom Tromey  <tom@tromey.com>
2137
2138         * common/next-iterator.h (next_adapter): Add Iterator template
2139         parameter.
2140         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2141         (class all_objfiles_safe): New.
2142         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2143         * objfiles.c (put_objfile_before): Update comment.
2144         (add_separate_debug_objfile): Likewise.
2145         (free_all_objfiles): Use all_objfiles_safe.
2146         (objfile_purge_solibs): Likewise.
2147
2148 2019-01-09  Tom Tromey  <tom@tromey.com>
2149
2150         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2151         (expand_symtab_containing_pc, lookup_static_symbol)
2152         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2153         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2154         all_objfiles.
2155         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2156         * breakpoint.c (create_overlay_event_breakpoint)
2157         (create_longjmp_master_breakpoint)
2158         (create_std_terminate_master_breakpoint)
2159         (create_exception_master_breakpoint): Use all_objfiles.
2160         * linux-thread-db.c (try_thread_db_load_from_pdir)
2161         (has_libpthread): Use all_objfiles.
2162         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2163         * linespec.c (iterate_over_all_matching_symtabs)
2164         (search_minsyms_for_name): Use all_objfiles.
2165         * maint.c (maintenance_info_sections): Use all_objfiles.
2166         * main.c (captured_main_1): Use all_objfiles.
2167         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2168         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2169         * guile/scm-pretty-print.c
2170         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2171         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2172         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2173         (maintenance_print_msymbols): Use all_objfiles.
2174         * source.c (select_source_symtab): Use all_objfiles.
2175         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2176         * symfile.c (remove_symbol_file_command)
2177         (expand_symtabs_matching, map_symbol_filenames): Use
2178         all_objfiles.
2179         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2180         all_objfiles.
2181         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2182         * objc-lang.c (find_methods): Use all_objfiles.
2183         * objfiles.c (have_partial_symbols, have_full_symbols)
2184         (have_minimal_symbols, qsort_cmp)
2185         (default_iterate_over_objfiles_in_search_order): Use
2186         all_objfiles.
2187         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2188         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2189         (maintenance_check_psymtabs): Use all_objfiles.
2190         (ALL_PSYMTABS): Remove.
2191         * compile/compile-object-run.c (do_module_cleanup): Use
2192         all_objfiles.
2193         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2194         * cp-support.c (add_symbol_overload_list_qualified): Use
2195         all_objfiles.
2196         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2197         Use all_objfiles.
2198         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2199         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2200         all_objfiles.
2201         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2202         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2203         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2204         Uses all_objfiles.
2205         * solib.c (solib_read_symbols): Use all_objfiles
2206
2207 2019-01-09  Tom Tromey  <tom@tromey.com>
2208
2209         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2210         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2211         all_objfiles.
2212         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2213         * symmisc.c (print_symbol_bcache_statistics)
2214         (print_objfile_statistics, maintenance_print_objfiles)
2215         (maintenance_info_symtabs, maintenance_check_symtabs)
2216         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2217         all_objfiles.
2218         * source.c (forget_cached_source_info): Use all_objfiles.
2219         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2220         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2221         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2222         * objfiles.c (update_section_map): Use all_objfiles.
2223         (shared_objfile_contains_address_p): Likewise.
2224         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2225         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2226
2227 2019-01-09  Tom Tromey  <tom@tromey.com>
2228
2229         * common/next-iterator.h: New file.
2230         * objfiles.h (class all_objfiles): New.
2231         (struct objfile_iterator): New.
2232
2233 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2234
2235         * NEWS: Move the description of the changed "frame", "select-frame",
2236          and "info frame" commands to the Changed commands section.
2237
2238 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2239
2240         * gdbtypes.c (check_stub_method_group): Remove handling of old
2241         mangling schemes.
2242         * linespec.c (find_methods): Likewise.
2243         * stabsread.c (read_member_functions): Likewise.
2244         * valops.c (search_struct_method): Likewise.
2245         (value_struct_elt_for_reference): Likewise.
2246         * NEWS: Mention this change.
2247
2248 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2249
2250         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2251         print_source_lines.
2252         * source.c (print_source_lines_base): Update line number check.
2253         (print_source_lines): New function.
2254         (source_lines_range::source_lines_range): New function.
2255         * source.h (class source_lines_range): New class.
2256         (print_source_lines): New declaration.
2257
2258 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2259
2260         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2261
2262 2019-01-08  Tom Tromey  <tom@tromey.com>
2263             Simon Marchi  <simon.marchi@ericsson.com>
2264
2265         PR gdb/24060
2266         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2267         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2268         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2269         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2270         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2271         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2272
2273 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         * source.c (select_source_symtab): Move header comment to
2276         declaration in source.h.
2277         (forget_cached_source_info_for_objfile): Likewise.
2278         (forget_cached_source_info): Likewise.
2279         (identify_source_line): Likewise.
2280         * source.h (identify_source_line): Move declaration from symtab.h
2281         and add comment from source.c
2282         (print_source_lines): Likewise.
2283         (forget_cached_source_info_for_objfile): Likewise.
2284         (forget_cached_source_info): Likewise.
2285         (select_source_symtab): Likewise.
2286         (enum print_source_lines_flag): Move definition from symtab.h.
2287         * symtab.h (identify_source_line): Move declaration to source.h.
2288         (print_source_lines): Likewise.
2289         (forget_cached_source_info_for_objfile): Likewise.
2290         (forget_cached_source_info): Likewise.
2291         (select_source_symtab): Likewise.
2292         (enum print_source_lines_flag): Move definition to source.h.
2293         * tui/tui-hooks.c: Add 'source.h' include.
2294
2295 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2296
2297         * source.c (print_source_lines_base): Handle requests to print
2298         reverse line number sequences, and guard against empty lines
2299         string.
2300
2301 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2302
2303         * source.c (print_source_lines_base): Fix skip of '\r' if next
2304         character is '\n'.
2305
2306 2019-01-06  Tom Tromey  <tom@tromey.com>
2307
2308         * c-exp.y (struct c_parse_state) <macro_original_text,
2309         expansion_obstack>: New member.
2310         (macro_original_text, expansion_obstack): Remove globals.
2311         (scan_macro_expansion, scanning_macro_expansion)
2312         (finished_macro_expansion): Update.
2313         (scan_macro_cleanup): Remove.
2314         (yylex, c_parse): Update.
2315
2316 2019-01-06  Tom Tromey  <tom@tromey.com>
2317
2318         * c-exp.y (struct c_parse_state) <strings>: New member.
2319         (operator_stoken): Update.
2320
2321 2019-01-06  Tom Tromey  <tom@tromey.com>
2322
2323         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2324         (union type_stack_elt) <typelist_val>: Now a pointer to
2325         std::vector.
2326         (type_stack_cleanup): Don't declare.
2327         (push_typelist): Update.
2328         * parse.c (pop_typelist): Return a std::vector.
2329         (push_typelist): Take a std::vector.
2330         (follow_types): Update.  Do not free args.
2331         (type_stack_cleanup): Remove.
2332         * c-exp.y (struct c_parse_state): New.
2333         (cpstate): New global.
2334         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2335         (nonempty_typelist): Update.
2336         (func_mod): Create a new vector.
2337         (c_parse): Create a c_parse_state.
2338         (check_parameter_typelist): Do not delete params.
2339         (function_method): Update.  Do not delete type_list.
2340
2341 2019-01-06  Tom Tromey  <tom@tromey.com>
2342
2343         PR gdb/28155:
2344         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2345         check_typedef.
2346         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2347         (print_return_value): Likewise.
2348
2349 2019-01-05  Tom Tromey  <tom@tromey.com>
2350
2351         * contrib/cleanup_check.py: Remove.
2352         * contrib/gcc-with-excheck: Remove.
2353         * contrib/exsummary.py: Remove.
2354         * contrib/excheck.py: Remove.
2355
2356 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2357
2358         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2359         NULL. Initialize tpprev to NULL instead of assigning it
2360         to NULL on the next statement.
2361         * windows-nat.c (windows_delete_thread): Remove check for
2362         main_thread_id before printing thread exit notifications.
2363         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2364         Remove thread ID check against main_thread_id.
2365         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2366         windows_delete_thread.
2367         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2368
2369 2019-01-04  Tom Tromey  <tom@tromey.com>
2370
2371         * compile/compile.c (_initialize_compile): Use upper case for
2372         metasyntactic variables.
2373         * symmisc.c (_initialize_symmisc): Use upper case for
2374         metasyntactic variables.
2375         * psymtab.c (_initialize_psymtab): Use upper case for
2376         metasyntactic variables.
2377         * demangle.c (demangle_command): Use upper case for metasyntactic
2378         variables.
2379         (_initialize_demangler): Likewise.
2380         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2381         variables.
2382
2383 2019-01-03  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2386
2387 2019-01-03  Tom Tromey  <tom@tromey.com>
2388
2389         * python/py-symtab.c (salpy_str): Update.
2390         (struct salpy_sal_object) <symtab>: Now a PyObject.
2391         (salpy_dealloc): Update.
2392         (del_objfile_sal): Use gdbpy_ref.
2393
2394 2019-01-03  Tom Tromey  <tom@tromey.com>
2395
2396         * python/py-type.c (convert_field): Use new_reference.  Return
2397         gdbpy_ref.
2398         (make_fielditem): Return gdbpy_ref.
2399         (typy_fields): Update.
2400         (typy_getitem): Update.
2401         (field_name): Return gdbpy_ref.  Use new_reference.
2402         (typy_iterator_iternext): Update.
2403
2404 2019-01-03  Tom Tromey  <tom@tromey.com>
2405
2406         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2407
2408 2019-01-03  Tom Tromey  <tom@tromey.com>
2409
2410         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2411         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2412         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2413         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2414         (pspy_set_type_printers): Likewise.
2415         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2416         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2417         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2418         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2419         (objfpy_set_type_printers): Likewise.
2420
2421 2019-01-03  Tom Tromey  <tom@tromey.com>
2422
2423         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2424         (gdbpy_print_stack): Use gdbpy_err_fetch.
2425         * python/python-internal.h (class gdbpy_err_fetch): New class.
2426         (class gdbpy_enter) <m_error_type, m_error_value,
2427         m_error_traceback>: Remove.
2428         <m_error>: New member.
2429         (gdbpy_exception_to_string): Don't declare.
2430         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2431         * python/py-value.c (convert_value_from_python): Use
2432         gdbpy_err_fetch.
2433         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2434         gdbpy_exception_to_string.
2435         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2436         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2437         gdbpy_err_fetch.
2438
2439 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2440
2441         * linux-nat.c (delete_lwp_cleanup): Delete.
2442         (struct lwp_deleter): New struct.
2443         (lwp_info_up): New typedef.
2444         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2445         lwp_info_up.
2446
2447 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2448
2449         * linux-fork.c (class scoped_switch_fork_info): New class.
2450         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2451
2452 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2453
2454         * valops.c (find_overload_match): Remove use of null_cleanup, and
2455         calls to do_cleanups.
2456
2457 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2458
2459         * compile/compile-cplus-types.c
2460         (compile_cplus_instance::decl_name): Handle changes to
2461         cp_func_name.
2462         * cp-support.c (cp_func_name): Update header comment, update
2463         return type.
2464         * cp-support.h (cp_func_name): Update return type in declaration.
2465         * valops.c (find_overload_match): Move temp_func local to top
2466         level of function and change its type.  Use temp_func to hold and
2467         delete temporary string obtained from cp_func_name.
2468
2469 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2470
2471         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2472         gdb::char_vector, remove cleanup, and update uses of `msg`.
2473
2474 2019-01-03  Jim Wilson  <jimw@sifive.com>
2475
2476         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2477
2478 2019-01-02  Tom Tromey  <tom@tromey.com>
2479
2480         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2481         (tdesc_parse_xml): Remove cleanups.
2482         * target-descriptions.h (make_cleanup_free_target_description):
2483         Don't declare.
2484         (target_desc_deleter): New struct.
2485         (target_desc_up): New typedef.
2486         * target-descriptions.c (target_desc_deleter::operator()): Rename
2487         from free_target_description.
2488         (make_cleanup_free_target_description): Remove.
2489
2490 2019-01-02  Tom Tromey  <tom@tromey.com>
2491
2492         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2493         constructor, destructor.
2494         (linespec_parser): Remove typedef.
2495         (~linespec_parser): Rename from linespec_parser_delete.
2496         (linespec_lex_to_end, linespec_complete_label)
2497         (linespec_complete): Update.
2498         (decode_line_full): Remove cleanups.
2499         (decode_line_1): Update.
2500
2501 2019-01-02  Tom Tromey  <tom@tromey.com>
2502
2503         * python/python-internal.h (inferior_to_inferior_object): Change
2504         return type.
2505         * python/py-exitedevent.c (create_exited_event_object): Update.
2506         * python/py-inferior.c (inferior_to_inferior_object): Return
2507         gdbpy_ref.
2508         (python_new_inferior, python_inferior_deleted)
2509         (thread_to_thread_object, delete_thread_object)
2510         (build_inferior_list, gdbpy_selected_inferior): Update.
2511         * python/py-infthread.c (create_thread_object): Update.  Also fail
2512         if inferior_to_inferior_object fails.
2513
2514 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2515
2516         * inferior.h (class inferior) <displaced_step_state>: New field.
2517         * infrun.h (struct displaced_step_state): Move here from
2518         infrun.c.  Initialize fields, add constructor.
2519         <inf>: Remove field.
2520         <reset>: New method.
2521         * infrun.c (struct displaced_step_inferior_state): Move to
2522         infrun.h.
2523         (displaced_step_inferior_states): Remove.
2524         (get_displaced_stepping_state): Adust.
2525         (displaced_step_in_progress_any_inferior): Adjust.
2526         (displaced_step_in_progress_thread): Adjust.
2527         (displaced_step_in_progress): Adjust.
2528         (add_displaced_stepping_state): Remove.
2529         (get_displaced_step_closure_by_addr): Adjust.
2530         (remove_displaced_stepping_state): Remove.
2531         (infrun_inferior_exit): Call displaced_step_state.reset.
2532         (use_displaced_stepping): Don't check for NULL.
2533         (displaced_step_prepare_throw): Call
2534         get_displaced_stepping_state.
2535         (displaced_step_fixup): Don't check for NULL.
2536         (prepare_for_detach): Don't check for NULL.
2537
2538 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2539
2540         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2541          in case of call that did not complete.
2542
2543 2019-01-02  Andrey Utkin  <autkin@undo.io>
2544
2545         * symfile.c (find_separate_debug_file): Fix search of debug files for
2546         remote debuggee.
2547
2548 2019-01-02  Tom Tromey  <tom@tromey.com>
2549
2550         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2551         indentation.
2552         * python/py-frame.c (frapy_older): Remove cast.
2553         (frapy_newer): Likewise.
2554         * python/py-breakpoint.c (local_setattro): Remove cast.
2555         * python/py-arch.c (archpy_name): Remove local variable.
2556         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2557
2558 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2559
2560         * unittests/basic_string_view/element_access/char/empty.cc:
2561         Fix year range in copyright header.
2562
2563 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2564
2565         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2566         Delete.
2567         <operator==>: Update with for removed field.
2568         <hash>: Likewise.
2569         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2570         <isa_features>: ...this.
2571         <abi_features>: New field.
2572         (riscv_isa_flen): Update comment.
2573         (riscv_abi_xlen): New declaration.
2574         (riscv_abi_flen): New declaration.
2575         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2576         isa_features.
2577         (riscv_abi_xlen): New function.
2578         (riscv_isa_flen): Update to get answer from isa_features.
2579         (riscv_abi_flen): New function.
2580         (riscv_has_fp_abi): Update to get answer from abi_features.
2581         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2582         xlen and flen.
2583         (riscv_call_info) <xlen, flen>: Update comment.
2584         (riscv_call_arg_struct): Remove invalid assertions
2585         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2586         is removed.
2587         (riscv_gdbarch_init): Gather isa features and abi features
2588         separately, ensure both match on the gdbarch when reusing an old
2589         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2590         a target with 64-bit float hardware.
2591
2592 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2593
2594         * source.c (search_command_helper): Stop reverse search
2595         when line 1 has been searched.
2596
2597 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2598
2599         * record-full.c (record_full_base_target::close): Rewrite
2600         record_full_core_buf_list free logic.
2601
2602 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2603
2604         * break-catch-syscall.c (print_one_catch_syscall): xfree
2605         the last text.
2606
2607 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2608
2609         * top.c (print_gdb_version): Update Copyright year in version
2610         message.
2611
2612 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2613
2614         Update copyright year range in all GDB files.
2615
2616 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2617
2618         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2619
2620 For older changes see ChangeLog-2018.
2621 \f
2622 Local Variables:
2623 mode: change-log
2624 left-margin: 8
2625 fill-column: 74
2626 version-control: never
2627 coding: utf-8
2628 End:
2629