gdb/ChangeLog

   1 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2             Tom Tromey  <tromey@adacore.com>
   3
   4         * ada-lang.c (ada_exception_sal): Change addr_string to a
   5         std::string.
   6         (create_ada_exception_catchpoint): Update.
   7
   8 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   9             Tom Tromey  <tromey@adacore.com>
  10
  11         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
  12         (bp_location_ops): Remove.
  13         (base_breakpoint_allocate_location): Update.
  14         (free_bp_location): Update.
  15         * ada-lang.c (class ada_catchpoint_location)
  16         <ada_catchpoint_location>: Remove ops parameter.
  17         (ada_catchpoint_location_dtor): Remove.
  18         (ada_catchpoint_location_ops): Remove.
  19         (allocate_location_exception): Update.
  20         * breakpoint.h (struct bp_location_ops): Remove.
  21         (class bp_location) <bp_location>: Remove bp_location_ops
  22         parameter.
  23         <~bp_location>: Add destructor.
  24         <ops>: Remove.
  25
  26 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
  27             Pedro Alves  <palves@redhat.com>
  28
  29         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
  30         'PATH_MAX'.
  31
  32 2019-02-14  David Michael  <fedora.dm0@gmail.com>
  33             Samuel Thibault  <samuel.thibault@gnu.org>
  34             Thomas Schwinge  <thomas@codesourcery.com>
  35
  36         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
  37         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
  38
  39 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
  40
  41         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
  42         (check_empty): Use "const char *".
  43
  44         * gnu-nat.c (gnu_nat_target::detach): Instead of
  45         'detach_inferior (pid)' call
  46         'detach_inferior (find_inferior_pid (pid))'.
  47
  48         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
  49         'nat/fork-inferior.o'.
  50         * gnu-nat.c: #include "nat/fork-inferior.h".
  51
  52         * gnu-nat.c (gnu_nat_target::detach): Instead of
  53         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
  54         * gnu-nat.h: #include "inf-child.h".
  55         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
  56         'i386_gnu_nat_target::fetch_registers'.
  57         (gnu_store_registers): Rename/move to
  58         'i386_gnu_nat_target::store_registers'.
  59
  60         * config/i386/nm-i386gnu.h: Don't "#include" any files.
  61         * gnu-nat.h (mach_thread_info): New function.
  62         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
  63
  64         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
  65
  66 2019-02-14  Frederic Konrad  <konrad@adacore.com>
  67
  68         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
  69
  70 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
  71
  72         * windows-nat.c (windows_add_thread): Add new parameter
  73         "main_thread_p" with default value set to false.  Update
  74         function documentation as well as all callers.
  75         (windows_delete_thread): Likewise.
  76         (fake_create_process): Update call to windows_add_thread.
  77         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
  78         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
  79         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
  80         call to windows_delete_thread.
  81
  82 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
  83
  84         * MAINTAINERS: Add Andrew Burgess as global maintainer.
  85
  86 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  87
  88         * symfile.c (find_separate_debug_file): Use canonical path of
  89         sysroot with child_path instead of gdb_sysroot if it is valid.
  90
  91 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  92
  93         * symfile.c (find_separate_debug_file): Use child_path to
  94         determine if an object file is under a sysroot.
  95
  96 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  97
  98         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
  99         unittests/child-path-selftests.c.
 100         * common/pathstuff.c (child_path): New function.
 101         * common/pathstuff.h (child_path): New prototype.
 102         * unittests/child-path-selftests.c: New file.
 103
 104 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 105
 106         * symfile.c (find_separate_debug_file): Look for separate debug
 107         files in debug directories under the sysroot.
 108
 109 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 110
 111         * symtab.h (struct minimal_symbol data_p): New const method.
 112         (struct minimal_symbol text_p): Likewise.
 113         * symtab.c (output_source_filename): Use file name style
 114         to print file name.
 115         (print_symbol_info): Likewise.
 116         (print_msymbol_info): Use address style to print addresses.
 117         Use function name style to print executable text symbols.
 118         (expand_symtab_containing_pc): Use data_p.
 119         (find_pc_sect_compunit_symtab): Likewise.
 120
 121 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 122
 123         * breakpoint.c (describe_other_breakpoints): Use address style
 124         to print addresses.
 125         (say_where): Likewise.
 126
 127 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 128
 129         * ada-typeprint.c (print_func_type): Print function name
 130         style to print function name.
 131         * c-typeprint.c (c_print_type_1): Likewise.
 132
 133 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 134
 135         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 136         for execve.
 137
 138 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 139
 140         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 141         type_stack.
 142
 143 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 144
 145         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 146         TYPE_CODE_REF types.
 147
 148 2019-02-08  Jim Wilson  <jimw@sifive.com>
 149
 150         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 151         (riscv_linux_fregset): New.
 152         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 153
 154 2019-02-07  Tom Tromey  <tom@tromey.com>
 155
 156         * thread.c (thread_cancel_execution_command): Update.
 157         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 158         methods.
 159         (struct thread_fsm_ops): Remove.
 160         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 161         (thread_fsm_should_stop, thread_fsm_return_value)
 162         (thread_fsm_set_finished, thread_fsm_finished_p)
 163         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 164         Don't declare.
 165         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 166         * infrun.c (clear_proceed_status_thread)
 167         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 168         (print_stop_event): Update.
 169         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 170         Add constructor.
 171         (step_command_fsm_ops): Remove.
 172         (new_step_command_fsm): Remove.
 173         (step_1): Update.
 174         (step_command_fsm::should_stop): Rename from
 175         step_command_fsm_should_stop.
 176         (step_command_fsm::clean_up): Rename from
 177         step_command_fsm_clean_up.
 178         (step_command_fsm::do_async_reply_reason): Rename from
 179         step_command_fsm_async_reply_reason.
 180         (struct until_next_fsm): Inherit from thread_fsm.  Add
 181         constructor.
 182         (until_next_fsm_ops): Remove.
 183         (new_until_next_fsm): Remove.
 184         (until_next_fsm::should_stop): Rename from
 185         until_next_fsm_should_stop.
 186         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 187         (until_next_fsm::do_async_reply_reason): Rename from
 188         until_next_fsm_async_reply_reason.
 189         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 190         constructor.  Change type of breakpoint.
 191         (finish_command_fsm_ops): Remove.
 192         (new_finish_command_fsm): Remove.
 193         (finish_command_fsm::should_stop): Rename from
 194         finish_command_fsm_should_stop.
 195         (finish_command_fsm::clean_up): Rename from
 196         finish_command_fsm_clean_up.
 197         (finish_command_fsm::return_value): Rename from
 198         finish_command_fsm_return_value.
 199         (finish_command_fsm::do_async_reply_reason): Rename from
 200         finish_command_fsm_async_reply_reason.
 201         (finish_command): Update.
 202         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 203         Add constructor.
 204         (call_thread_fsm_ops): Remove.
 205         (call_thread_fsm::call_thread_fsm): Rename from
 206         new_call_thread_fsm.
 207         (call_thread_fsm::should_stop): Rename from
 208         call_thread_fsm_should_stop.
 209         (call_thread_fsm::should_notify_stop): Rename from
 210         call_thread_fsm_should_notify_stop.
 211         (run_inferior_call, call_function_by_hand_dummy): Update.
 212         * cli/cli-interp.c (should_print_stop_to_console): Update.
 213         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 214         Add constructor.  Change type of location_breakpoint,
 215         caller_breakpoint.
 216         (until_break_fsm_ops): Remove.
 217         (new_until_break_fsm): Remove.
 218         (until_break_fsm::should_stop): Rename from
 219         until_break_fsm_should_stop.
 220         (until_break_fsm::clean_up): Rename from
 221         until_break_fsm_clean_up.
 222         (until_break_fsm::do_async_reply_reason): Rename from
 223         until_break_fsm_async_reply_reason.
 224         (until_break_command): Update.
 225         * thread-fsm.c: Remove.
 226         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 227
 228 2019-02-07  Tom Tromey  <tom@tromey.com>
 229
 230         * yy-remap.h: Add include guard.
 231         * xtensa-tdep.h: Add include guard.
 232         * xcoffread.h: Rename include guard.
 233         * varobj-iter.h: Add include guard.
 234         * tui/tui.h: Rename include guard.
 235         * tui/tui-winsource.h: Rename include guard.
 236         * tui/tui-wingeneral.h: Rename include guard.
 237         * tui/tui-windata.h: Rename include guard.
 238         * tui/tui-win.h: Rename include guard.
 239         * tui/tui-stack.h: Rename include guard.
 240         * tui/tui-source.h: Rename include guard.
 241         * tui/tui-regs.h: Rename include guard.
 242         * tui/tui-out.h: Rename include guard.
 243         * tui/tui-layout.h: Rename include guard.
 244         * tui/tui-io.h: Rename include guard.
 245         * tui/tui-hooks.h: Rename include guard.
 246         * tui/tui-file.h: Rename include guard.
 247         * tui/tui-disasm.h: Rename include guard.
 248         * tui/tui-data.h: Rename include guard.
 249         * tui/tui-command.h: Rename include guard.
 250         * tic6x-tdep.h: Add include guard.
 251         * target/waitstatus.h: Rename include guard.
 252         * target/wait.h: Rename include guard.
 253         * target/target.h: Rename include guard.
 254         * target/resume.h: Rename include guard.
 255         * target-float.h: Rename include guard.
 256         * stabsread.h: Add include guard.
 257         * rs6000-tdep.h: Add include guard.
 258         * riscv-fbsd-tdep.h: Add include guard.
 259         * regformats/regdef.h: Rename include guard.
 260         * record.h: Rename include guard.
 261         * python/python.h: Rename include guard.
 262         * python/python-internal.h: Rename include guard.
 263         * python/py-stopevent.h: Rename include guard.
 264         * python/py-ref.h: Rename include guard.
 265         * python/py-record.h: Rename include guard.
 266         * python/py-record-full.h: Rename include guard.
 267         * python/py-record-btrace.h: Rename include guard.
 268         * python/py-instruction.h: Rename include guard.
 269         * python/py-events.h: Rename include guard.
 270         * python/py-event.h: Rename include guard.
 271         * procfs.h: Add include guard.
 272         * proc-utils.h: Add include guard.
 273         * p-lang.h: Add include guard.
 274         * or1k-tdep.h: Rename include guard.
 275         * observable.h: Rename include guard.
 276         * nto-tdep.h: Rename include guard.
 277         * nat/x86-linux.h: Rename include guard.
 278         * nat/x86-linux-dregs.h: Rename include guard.
 279         * nat/x86-gcc-cpuid.h: Add include guard.
 280         * nat/x86-dregs.h: Rename include guard.
 281         * nat/x86-cpuid.h: Rename include guard.
 282         * nat/ppc-linux.h: Rename include guard.
 283         * nat/mips-linux-watch.h: Rename include guard.
 284         * nat/linux-waitpid.h: Rename include guard.
 285         * nat/linux-ptrace.h: Rename include guard.
 286         * nat/linux-procfs.h: Rename include guard.
 287         * nat/linux-osdata.h: Rename include guard.
 288         * nat/linux-nat.h: Rename include guard.
 289         * nat/linux-namespaces.h: Rename include guard.
 290         * nat/linux-btrace.h: Rename include guard.
 291         * nat/glibc_thread_db.h: Rename include guard.
 292         * nat/gdb_thread_db.h: Rename include guard.
 293         * nat/gdb_ptrace.h: Rename include guard.
 294         * nat/fork-inferior.h: Rename include guard.
 295         * nat/amd64-linux-siginfo.h: Rename include guard.
 296         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 297         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 298         * nat/aarch64-linux.h: Rename include guard.
 299         * nat/aarch64-linux-hw-point.h: Rename include guard.
 300         * mn10300-tdep.h: Add include guard.
 301         * mips-linux-tdep.h: Add include guard.
 302         * mi/mi-parse.h: Rename include guard.
 303         * mi/mi-out.h: Rename include guard.
 304         * mi/mi-main.h: Rename include guard.
 305         * mi/mi-interp.h: Rename include guard.
 306         * mi/mi-getopt.h: Rename include guard.
 307         * mi/mi-console.h: Rename include guard.
 308         * mi/mi-common.h: Rename include guard.
 309         * mi/mi-cmds.h: Rename include guard.
 310         * mi/mi-cmd-break.h: Rename include guard.
 311         * m2-lang.h: Add include guard.
 312         * location.h: Rename include guard.
 313         * linux-record.h: Rename include guard.
 314         * linux-nat.h: Add include guard.
 315         * linux-fork.h: Add include guard.
 316         * i386-darwin-tdep.h: Rename include guard.
 317         * hppa-linux-offsets.h: Add include guard.
 318         * guile/guile.h: Rename include guard.
 319         * guile/guile-internal.h: Rename include guard.
 320         * gnu-nat.h: Rename include guard.
 321         * gdb-stabs.h: Rename include guard.
 322         * frv-tdep.h: Add include guard.
 323         * f-lang.h: Add include guard.
 324         * event-loop.h: Add include guard.
 325         * darwin-nat.h: Rename include guard.
 326         * cp-abi.h: Rename include guard.
 327         * config/sparc/nm-sol2.h: Rename include guard.
 328         * config/nm-nto.h: Rename include guard.
 329         * config/nm-linux.h: Add include guard.
 330         * config/i386/nm-i386gnu.h: Rename include guard.
 331         * config/djgpp/nl_types.h: Rename include guard.
 332         * config/djgpp/langinfo.h: Rename include guard.
 333         * compile/gcc-cp-plugin.h: Add include guard.
 334         * compile/gcc-c-plugin.h: Add include guard.
 335         * compile/compile.h: Rename include guard.
 336         * compile/compile-object-run.h: Rename include guard.
 337         * compile/compile-object-load.h: Rename include guard.
 338         * compile/compile-internal.h: Rename include guard.
 339         * compile/compile-cplus.h: Rename include guard.
 340         * compile/compile-c.h: Rename include guard.
 341         * common/xml-utils.h: Rename include guard.
 342         * common/x86-xstate.h: Rename include guard.
 343         * common/version.h: Rename include guard.
 344         * common/vec.h: Rename include guard.
 345         * common/tdesc.h: Rename include guard.
 346         * common/selftest.h: Rename include guard.
 347         * common/scoped_restore.h: Rename include guard.
 348         * common/scoped_mmap.h: Rename include guard.
 349         * common/scoped_fd.h: Rename include guard.
 350         * common/safe-iterator.h: Rename include guard.
 351         * common/run-time-clock.h: Rename include guard.
 352         * common/refcounted-object.h: Rename include guard.
 353         * common/queue.h: Rename include guard.
 354         * common/ptid.h: Rename include guard.
 355         * common/print-utils.h: Rename include guard.
 356         * common/preprocessor.h: Rename include guard.
 357         * common/pathstuff.h: Rename include guard.
 358         * common/observable.h: Rename include guard.
 359         * common/netstuff.h: Rename include guard.
 360         * common/job-control.h: Rename include guard.
 361         * common/host-defs.h: Rename include guard.
 362         * common/gdb_wait.h: Rename include guard.
 363         * common/gdb_vecs.h: Rename include guard.
 364         * common/gdb_unlinker.h: Rename include guard.
 365         * common/gdb_unique_ptr.h: Rename include guard.
 366         * common/gdb_tilde_expand.h: Rename include guard.
 367         * common/gdb_sys_time.h: Rename include guard.
 368         * common/gdb_string_view.h: Rename include guard.
 369         * common/gdb_splay_tree.h: Rename include guard.
 370         * common/gdb_setjmp.h: Rename include guard.
 371         * common/gdb_ref_ptr.h: Rename include guard.
 372         * common/gdb_optional.h: Rename include guard.
 373         * common/gdb_locale.h: Rename include guard.
 374         * common/gdb_assert.h: Rename include guard.
 375         * common/filtered-iterator.h: Rename include guard.
 376         * common/filestuff.h: Rename include guard.
 377         * common/fileio.h: Rename include guard.
 378         * common/environ.h: Rename include guard.
 379         * common/common-utils.h: Rename include guard.
 380         * common/common-types.h: Rename include guard.
 381         * common/common-regcache.h: Rename include guard.
 382         * common/common-inferior.h: Rename include guard.
 383         * common/common-gdbthread.h: Rename include guard.
 384         * common/common-exceptions.h: Rename include guard.
 385         * common/common-defs.h: Rename include guard.
 386         * common/common-debug.h: Rename include guard.
 387         * common/cleanups.h: Rename include guard.
 388         * common/buffer.h: Rename include guard.
 389         * common/btrace-common.h: Rename include guard.
 390         * common/break-common.h: Rename include guard.
 391         * cli/cli-utils.h: Rename include guard.
 392         * cli/cli-style.h: Rename include guard.
 393         * cli/cli-setshow.h: Rename include guard.
 394         * cli/cli-script.h: Rename include guard.
 395         * cli/cli-interp.h: Rename include guard.
 396         * cli/cli-decode.h: Rename include guard.
 397         * cli/cli-cmds.h: Rename include guard.
 398         * charset-list.h: Add include guard.
 399         * buildsym-legacy.h: Rename include guard.
 400         * bfin-tdep.h: Add include guard.
 401         * ax.h: Rename include guard.
 402         * arm-linux-tdep.h: Add include guard.
 403         * arm-fbsd-tdep.h: Add include guard.
 404         * arch/xtensa.h: Rename include guard.
 405         * arch/tic6x.h: Add include guard.
 406         * arch/i386.h: Add include guard.
 407         * arch/arm.h: Rename include guard.
 408         * arch/arm-linux.h: Rename include guard.
 409         * arch/arm-get-next-pcs.h: Rename include guard.
 410         * arch/amd64.h: Add include guard.
 411         * arch/aarch64-insn.h: Rename include guard.
 412         * arch-utils.h: Rename include guard.
 413         * annotate.h: Add include guard.
 414         * amd64-darwin-tdep.h: Rename include guard.
 415         * aarch64-linux-tdep.h: Add include guard.
 416         * aarch64-fbsd-tdep.h: Add include guard.
 417         * aarch32-linux-nat.h: Add include guard.
 418
 419 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 420
 421         * macrotab.c (macro_define_internal): New function that
 422         factorizes macro_define_object_internal and macro_define_function
 423         code.
 424         (macro_define_object_internal): Use macro_define_internal.
 425         (macro_define_function): Likewise.
 426
 427 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 428
 429         * macrocmd.c (extract_identifier): Return
 430         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 431         callers.
 432
 433 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 434
 435         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 436
 437 2019-02-05  Tom Tromey  <tom@tromey.com>
 438
 439         * target.c (target_stack::unpush): Move assertion earlier.
 440
 441 2019-01-30  Tom Tromey  <tom@tromey.com>
 442
 443         PR python/23615:
 444         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 445         (gdbpy_parse_and_eval): Likewise.
 446         * python/python-internal.h (gdbpy_allow_threads): New class.
 447
 448 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 449
 450         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 451         (aarch64_fbsd_fpregmap): Move earlier.
 452         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 453         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 454         instead of individual calls to trad_frame_set_reg_addr.
 455         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 456         earlier.
 457         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 458         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 459         instead of individual calls to trad_frame_set_reg_addr.
 460
 461 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 462
 463         * CONTRIBUTE: Replace contribution list with wiki link.
 464
 465 2019-01-25  Tom Tromey  <tom@tromey.com>
 466
 467         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 468
 469 2019-01-25  Tom Tromey  <tom@tromey.com>
 470
 471         * xtensa-linux-nat.c: Fix common/ includes.
 472         * xml-support.h: Fix common/ includes.
 473         * xml-support.c: Fix common/ includes.
 474         * x86-linux-nat.c: Fix common/ includes.
 475         * windows-nat.c: Fix common/ includes.
 476         * varobj.h: Fix common/ includes.
 477         * varobj.c: Fix common/ includes.
 478         * value.c: Fix common/ includes.
 479         * valops.c: Fix common/ includes.
 480         * utils.c: Fix common/ includes.
 481         * unittests/xml-utils-selftests.c: Fix common/ includes.
 482         * unittests/utils-selftests.c: Fix common/ includes.
 483         * unittests/unpack-selftests.c: Fix common/ includes.
 484         * unittests/tracepoint-selftests.c: Fix common/ includes.
 485         * unittests/style-selftests.c: Fix common/ includes.
 486         * unittests/string_view-selftests.c: Fix common/ includes.
 487         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 488         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 489         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 490         * unittests/rsp-low-selftests.c: Fix common/ includes.
 491         * unittests/parse-connection-spec-selftests.c: Fix common/
 492         includes.
 493         * unittests/optional-selftests.c: Fix common/ includes.
 494         * unittests/offset-type-selftests.c: Fix common/ includes.
 495         * unittests/observable-selftests.c: Fix common/ includes.
 496         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 497         * unittests/memrange-selftests.c: Fix common/ includes.
 498         * unittests/memory-map-selftests.c: Fix common/ includes.
 499         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 500         * unittests/function-view-selftests.c: Fix common/ includes.
 501         * unittests/environ-selftests.c: Fix common/ includes.
 502         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 503         * unittests/common-utils-selftests.c: Fix common/ includes.
 504         * unittests/cli-utils-selftests.c: Fix common/ includes.
 505         * unittests/array-view-selftests.c: Fix common/ includes.
 506         * ui-file.c: Fix common/ includes.
 507         * tui/tui-io.c: Fix common/ includes.
 508         * tracepoint.h: Fix common/ includes.
 509         * tracepoint.c: Fix common/ includes.
 510         * tracefile-tfile.c: Fix common/ includes.
 511         * top.h: Fix common/ includes.
 512         * top.c: Fix common/ includes.
 513         * thread.c: Fix common/ includes.
 514         * target/waitstatus.h: Fix common/ includes.
 515         * target/waitstatus.c: Fix common/ includes.
 516         * target.h: Fix common/ includes.
 517         * target.c: Fix common/ includes.
 518         * target-memory.c: Fix common/ includes.
 519         * target-descriptions.c: Fix common/ includes.
 520         * symtab.h: Fix common/ includes.
 521         * symfile.c: Fix common/ includes.
 522         * stap-probe.c: Fix common/ includes.
 523         * spu-linux-nat.c: Fix common/ includes.
 524         * sparc-nat.c: Fix common/ includes.
 525         * source.c: Fix common/ includes.
 526         * solib.c: Fix common/ includes.
 527         * solib-target.c: Fix common/ includes.
 528         * ser-unix.c: Fix common/ includes.
 529         * ser-tcp.c: Fix common/ includes.
 530         * ser-pipe.c: Fix common/ includes.
 531         * ser-base.c: Fix common/ includes.
 532         * selftest-arch.c: Fix common/ includes.
 533         * s12z-tdep.c: Fix common/ includes.
 534         * rust-exp.y: Fix common/ includes.
 535         * rs6000-aix-tdep.c: Fix common/ includes.
 536         * riscv-tdep.c: Fix common/ includes.
 537         * remote.c: Fix common/ includes.
 538         * remote-notif.h: Fix common/ includes.
 539         * remote-fileio.h: Fix common/ includes.
 540         * remote-fileio.c: Fix common/ includes.
 541         * regcache.h: Fix common/ includes.
 542         * regcache.c: Fix common/ includes.
 543         * record-btrace.c: Fix common/ includes.
 544         * python/python.c: Fix common/ includes.
 545         * python/py-type.c: Fix common/ includes.
 546         * python/py-inferior.c: Fix common/ includes.
 547         * progspace.h: Fix common/ includes.
 548         * producer.c: Fix common/ includes.
 549         * procfs.c: Fix common/ includes.
 550         * proc-api.c: Fix common/ includes.
 551         * printcmd.c: Fix common/ includes.
 552         * ppc-linux-nat.c: Fix common/ includes.
 553         * parser-defs.h: Fix common/ includes.
 554         * osdata.c: Fix common/ includes.
 555         * obsd-nat.c: Fix common/ includes.
 556         * nat/x86-linux.c: Fix common/ includes.
 557         * nat/x86-linux-dregs.c: Fix common/ includes.
 558         * nat/x86-dregs.h: Fix common/ includes.
 559         * nat/x86-dregs.c: Fix common/ includes.
 560         * nat/ppc-linux.c: Fix common/ includes.
 561         * nat/mips-linux-watch.h: Fix common/ includes.
 562         * nat/mips-linux-watch.c: Fix common/ includes.
 563         * nat/linux-waitpid.c: Fix common/ includes.
 564         * nat/linux-ptrace.h: Fix common/ includes.
 565         * nat/linux-ptrace.c: Fix common/ includes.
 566         * nat/linux-procfs.c: Fix common/ includes.
 567         * nat/linux-personality.c: Fix common/ includes.
 568         * nat/linux-osdata.c: Fix common/ includes.
 569         * nat/linux-namespaces.c: Fix common/ includes.
 570         * nat/linux-btrace.h: Fix common/ includes.
 571         * nat/linux-btrace.c: Fix common/ includes.
 572         * nat/fork-inferior.c: Fix common/ includes.
 573         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 574         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 575         * nat/aarch64-linux.c: Fix common/ includes.
 576         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 577         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 578         * namespace.h: Fix common/ includes.
 579         * mips-linux-tdep.c: Fix common/ includes.
 580         * minsyms.c: Fix common/ includes.
 581         * mi/mi-parse.h: Fix common/ includes.
 582         * mi/mi-main.c: Fix common/ includes.
 583         * mi/mi-cmd-env.c: Fix common/ includes.
 584         * memrange.h: Fix common/ includes.
 585         * memattr.c: Fix common/ includes.
 586         * maint.h: Fix common/ includes.
 587         * maint.c: Fix common/ includes.
 588         * main.c: Fix common/ includes.
 589         * machoread.c: Fix common/ includes.
 590         * location.c: Fix common/ includes.
 591         * linux-thread-db.c: Fix common/ includes.
 592         * linux-nat.c: Fix common/ includes.
 593         * linux-fork.c: Fix common/ includes.
 594         * inline-frame.c: Fix common/ includes.
 595         * infrun.c: Fix common/ includes.
 596         * inflow.c: Fix common/ includes.
 597         * inferior.h: Fix common/ includes.
 598         * inferior.c: Fix common/ includes.
 599         * infcmd.c: Fix common/ includes.
 600         * inf-ptrace.c: Fix common/ includes.
 601         * inf-child.c: Fix common/ includes.
 602         * ia64-linux-nat.c: Fix common/ includes.
 603         * i387-tdep.c: Fix common/ includes.
 604         * i386-tdep.c: Fix common/ includes.
 605         * i386-linux-tdep.c: Fix common/ includes.
 606         * i386-linux-nat.c: Fix common/ includes.
 607         * i386-go32-tdep.c: Fix common/ includes.
 608         * i386-fbsd-tdep.c: Fix common/ includes.
 609         * i386-fbsd-nat.c: Fix common/ includes.
 610         * guile/scm-type.c: Fix common/ includes.
 611         * guile/guile.c: Fix common/ includes.
 612         * go32-nat.c: Fix common/ includes.
 613         * gnu-nat.c: Fix common/ includes.
 614         * gdbthread.h: Fix common/ includes.
 615         * gdbarch-selftests.c: Fix common/ includes.
 616         * gdb_usleep.c: Fix common/ includes.
 617         * gdb_select.h: Fix common/ includes.
 618         * gdb_bfd.c: Fix common/ includes.
 619         * gcore.c: Fix common/ includes.
 620         * fork-child.c: Fix common/ includes.
 621         * findvar.c: Fix common/ includes.
 622         * fbsd-nat.c: Fix common/ includes.
 623         * event-top.c: Fix common/ includes.
 624         * event-loop.c: Fix common/ includes.
 625         * dwarf2read.c: Fix common/ includes.
 626         * dwarf2loc.c: Fix common/ includes.
 627         * dwarf2-frame.c: Fix common/ includes.
 628         * dwarf-index-cache.c: Fix common/ includes.
 629         * dtrace-probe.c: Fix common/ includes.
 630         * disasm-selftests.c: Fix common/ includes.
 631         * defs.h: Fix common/ includes.
 632         * csky-tdep.c: Fix common/ includes.
 633         * cp-valprint.c: Fix common/ includes.
 634         * cp-support.h: Fix common/ includes.
 635         * cp-support.c: Fix common/ includes.
 636         * corelow.c: Fix common/ includes.
 637         * completer.h: Fix common/ includes.
 638         * completer.c: Fix common/ includes.
 639         * compile/compile.c: Fix common/ includes.
 640         * compile/compile-loc2c.c: Fix common/ includes.
 641         * compile/compile-cplus-types.c: Fix common/ includes.
 642         * compile/compile-cplus-symbols.c: Fix common/ includes.
 643         * command.h: Fix common/ includes.
 644         * cli/cli-dump.c: Fix common/ includes.
 645         * cli/cli-cmds.c: Fix common/ includes.
 646         * charset.c: Fix common/ includes.
 647         * build-id.c: Fix common/ includes.
 648         * btrace.h: Fix common/ includes.
 649         * btrace.c: Fix common/ includes.
 650         * breakpoint.h: Fix common/ includes.
 651         * breakpoint.c: Fix common/ includes.
 652         * ax.h:
 653         (enum agent_op): Fix common/ includes.
 654         * ax-general.c (struct aop_map): Fix common/ includes.
 655         * ax-gdb.c: Fix common/ includes.
 656         * auxv.c: Fix common/ includes.
 657         * auto-load.c: Fix common/ includes.
 658         * arm-tdep.c: Fix common/ includes.
 659         * arch/riscv.c: Fix common/ includes.
 660         * arch/ppc-linux-common.c: Fix common/ includes.
 661         * arch/i386.c: Fix common/ includes.
 662         * arch/arm.c: Fix common/ includes.
 663         * arch/arm-linux.c: Fix common/ includes.
 664         * arch/arm-get-next-pcs.c: Fix common/ includes.
 665         * arch/amd64.c: Fix common/ includes.
 666         * arch/aarch64.c: Fix common/ includes.
 667         * arch/aarch64-insn.c: Fix common/ includes.
 668         * arch-utils.c: Fix common/ includes.
 669         * amd64-windows-tdep.c: Fix common/ includes.
 670         * amd64-tdep.c: Fix common/ includes.
 671         * amd64-sol2-tdep.c: Fix common/ includes.
 672         * amd64-obsd-tdep.c: Fix common/ includes.
 673         * amd64-nbsd-tdep.c: Fix common/ includes.
 674         * amd64-linux-tdep.c: Fix common/ includes.
 675         * amd64-linux-nat.c: Fix common/ includes.
 676         * amd64-fbsd-tdep.c: Fix common/ includes.
 677         * amd64-fbsd-nat.c: Fix common/ includes.
 678         * amd64-dicos-tdep.c: Fix common/ includes.
 679         * amd64-darwin-tdep.c: Fix common/ includes.
 680         * agent.c: Fix common/ includes.
 681         * ada-lang.h: Fix common/ includes.
 682         * ada-lang.c: Fix common/ includes.
 683         * aarch64-tdep.c: Fix common/ includes.
 684
 685 2019-01-25  Tom Tromey  <tom@tromey.com>
 686
 687         * common/create-version.sh: Use common/version.h.
 688
 689 2019-01-24  Pedro Alves  <palves@redhat.com>
 690
 691         * infrun.c (signal_stop, signal_print, signal_program)
 692         (signal_catch, signal_pass): Now arrays instead of pointers.
 693         (update_signals_program_target, do_target_resume)
 694         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 695         * linux-nat.c (linux_nat_target::pass_signals)
 696         (linux_nat_target::create_inferior, linux_nat_target::attach):
 697         Adjust.
 698         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 699         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 700         * procfs.c (procfs_target::pass_signals): Adjust.
 701         * record-full.c (record_full_target::resume): Adjust.
 702         * remote.c (remote_target::pass_signals)
 703         (remote_target::program_signals): Adjust.
 704         * target-debug.h (target_debug_print_signals): Now takes a
 705         gdb::array_view as parameter.  Adjust.
 706         * target.h (target_ops) <pass_signals, program_signals>: Replace
 707         pointer and length parameters with gdb::array_view.
 708         (target_pass_signals, target_program_signals): Likewise.
 709         * target-delegates.c: Regenerate.
 710
 711 2019-01-24  Pedro Alves  <palves@redhat.com>
 712
 713         * common/forward-scope-exit.h
 714         (forward_scope_exit::forward_scope_exit): Pass arguments to
 715         m_bind_function directly, instead of creating a std::bind and
 716         copying that.
 717
 718 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 719
 720         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 721         for static members.
 722         (pass_in_v_vfp_candidate): Likewise.
 723
 724 2019-01-23  Tom Tromey  <tom@tromey.com>
 725             Pedro Alves  <palves@redhat.com>
 726
 727         * regcache.c (class regcache_invalidator): Remove.
 728         (regcache::raw_write): Use make_scope_exit.
 729
 730 2019-01-23  Tom Tromey  <tom@tromey.com>
 731
 732         * ui-out.h (class ui_out_emit_type): Update comment.
 733
 734 2019-01-23  Tom Tromey  <tom@tromey.com>
 735
 736         * infrun.c (fetch_inferior_event): Update comment.
 737
 738 2019-01-23  Tom Tromey  <tom@tromey.com>
 739             Pedro Alves  <palves@redhat.com>
 740
 741         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 742         parameter.
 743         (fetch_inferior_event): Use SCOPE_EXIT.
 744
 745
 746 2019-01-23  Tom Tromey  <tom@tromey.com>
 747             Pedro Alves  <palves@redhat.com>
 748
 749         * infrun.c (disable_thread_events): Delete.
 750         (stop_all_threads): Use SCOPE_EXIT.
 751
 752 2019-01-23  Tom Tromey  <tom@tromey.com>
 753             Pedro Alves  <palves@redhat.com>
 754
 755         * symfile.c: Include forward-scope-exit.h.
 756         (clear_symtab_users_cleanup): Replace forward declaration with
 757         a FORWARD_SCOPE_EXIT.
 758         (syms_from_objfile_1): Use the forward_scope_exit and
 759         gdb::optional instead of cleanup_function.
 760         (reread_symbols): Use the forward_scope_exit instead of
 761         cleanup_function.
 762         (clear_symtab_users_cleanup): Remove function.
 763
 764 2019-01-23  Tom Tromey  <tom@tromey.com>
 765             Pedro Alves  <palves@redhat.com>
 766
 767         * linux-nat.c: Include scope-exit.h.
 768         (cleanup_target_stop): Remove.
 769         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 770         SCOPE_EXIT.
 771
 772 2019-01-23  Tom Tromey  <tom@tromey.com>
 773             Pedro Alves  <palves@redhat.com>
 774
 775         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 776         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 777
 778 2019-01-23  Tom Tromey  <tom@tromey.com>
 779             Andrew Burgess  <andrew.burgess@embecosm.com>
 780             Pedro Alves  <palves@redhat.com>
 781
 782         * infrun.c (fetch_inferior_event): Use scope_exit.
 783         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 784         * top.c (execute_command): Use scope_exit.
 785         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 786         * utils.c (do_bpstat_clear_actions_cleanup)
 787         (make_bpstat_clear_actions_cleanup): Remove.
 788
 789 2019-01-23  Tom Tromey  <tom@tromey.com>
 790             Pedro Alves  <palves@redhat.com>
 791
 792         * infrun.c: Include "common/scope-exit.h"
 793         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 794         (wait_for_inferior): Use SCOPE_EXIT.
 795         (fetch_inferior_event): Use scope_exit.
 796
 797 2019-01-23  Tom Tromey  <tom@tromey.com>
 798             Pedro Alves  <palves@redhat.com>
 799
 800         * breakpoint.c (create_breakpoint): Remove cleanup.
 801
 802 2019-01-23  Tom Tromey  <tom@tromey.com>
 803             Andrew Burgess  <andrew.burgess@embecosm.com>
 804             Pedro Alves  <palves@redhat.com>
 805
 806 2019-01-23  Pedro Alves  <palves@redhat.com>
 807
 808         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 809
 810 2019-01-23  Pedro Alves  <palves@redhat.com>
 811             Andrew Burgess  <andrew.burgess@embecosm.com>
 812
 813         * gdbthread.h: Include "common/forward-scope-exit.h".
 814         (scoped_finish_thread_state): Redefine custom class in terms of
 815         forward_scope_exit.
 816
 817 2019-01-23  Pedro Alves  <palves@redhat.com>
 818             Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * common/forward-scope-exit.h: New file.
 821
 822 2019-01-23  Pedro Alves  <palves@redhat.com>
 823             Andrew Burgess  <andrew.burgess@embecosm.com>
 824             Tom Tromey  <tom@tromey.com>
 825
 826         * common/scope-exit.h: New file.
 827
 828 2019-01-23  Pedro Alves  <palves@redhat.com>
 829
 830         * common/preprocessor.h (ESC): Rename to ...
 831         (ESC_PARENS): ... this.
 832         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 833         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 834
 835 2019-01-23  Tom Tromey  <tom@tromey.com>
 836
 837         * language.h (class scoped_switch_to_sym_language_if_auto):
 838         Initialize m_lang in both cases.
 839
 840 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 841
 842         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 843         with XCNEW.
 844
 845 2019-01-22  Tom Tromey  <tom@tromey.com>
 846
 847         * corelow.c: Do not include sys/file.h.
 848
 849 2019-01-22  Tom Tromey  <tom@tromey.com>
 850
 851         * tui/tui-wingeneral.h: Include gdb_curses.h.
 852
 853 2019-01-22  Tom Tromey  <tom@tromey.com>
 854
 855         * source-cache.h (class source_cache) <get_source_lines,
 856         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 857
 858 2019-01-22  Tom Tromey  <tom@tromey.com>
 859
 860         * remote-fileio.h (struct remote_target): Declare.
 861
 862 2019-01-22  Tom Tromey  <tom@tromey.com>
 863
 864         * python/py-arch.c: Do not include py-ref.h.
 865         * python/py-bpevent.c: Do not include py-ref.h.
 866         * python/py-cmd.c: Do not include py-ref.h.
 867         * python/py-continueevent.c: Do not include py-ref.h.
 868         * python/py-event.h: Do not include py-ref.h.
 869         * python/py-evtregistry.c: Do not include py-ref.h.
 870         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 871         * python/py-frame.c: Do not include py-ref.h.
 872         * python/py-framefilter.c: Do not include py-ref.h.
 873         * python/py-function.c: Do not include py-ref.h.
 874         * python/py-infevents.c: Do not include py-ref.h.
 875         * python/py-linetable.c: Do not include py-ref.h.
 876         * python/py-objfile.c: Do not include py-ref.h.
 877         * python/py-param.c: Do not include py-ref.h.
 878         * python/py-prettyprint.c: Do not include py-ref.h.
 879         * python/py-progspace.c: Do not include py-ref.h.
 880         * python/py-symbol.c: Do not include py-ref.h.
 881         * python/py-symtab.c: Do not include py-ref.h.
 882         * python/py-type.c: Do not include py-ref.h.
 883         * python/py-unwind.c: Do not include py-ref.h.
 884         * python/py-utils.c: Do not include py-ref.h.
 885         * python/py-value.c: Do not include py-ref.h.
 886         * python/py-varobj.c: Do not include py-ref.h.
 887         * python/py-xmethods.c: Do not include py-ref.h.
 888         * python/python.c: Do not include py-ref.h.
 889         * varobj.c: Do not include py-ref.h.
 890
 891 2019-01-22  Tom Tromey  <tom@tromey.com>
 892
 893         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 894         keyword for bcache.
 895
 896 2019-01-22  Tom Tromey  <tom@tromey.com>
 897
 898         * compile/compile-cplus-types.c: Remove a comment by #include.
 899
 900 2019-01-22  Tom Tromey  <tom@tromey.com>
 901
 902         * compile/gcc-c-plugin.h: Include compile-internal.h.
 903
 904 2019-01-22  Tom Tromey  <tom@tromey.com>
 905
 906         * stabsread.c (EXTERN): Do not define.
 907         (symnum, next_symbol_text_func, processing_gcc_compilation)
 908         (within_function, global_sym_chain, global_stabs)
 909         (previous_stab_code, this_object_header_files)
 910         (n_this_object_header_files)
 911         (n_allocated_this_object_header_files): Define.
 912         * stabsread.h (EXTERN): Never define.  Use "extern".
 913
 914 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 915
 916         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 917         history_value.
 918
 919 2019-01-21  Tom Tromey  <tom@tromey.com>
 920
 921         * ui-out.c: Fix includes.
 922         * tui/tui-source.c: Fix includes.
 923         * target.c: Fix includes.
 924         * remote.c: Fix includes.
 925         * regcache.c: Fix includes.
 926         * python/py-block.c: Fix includes.
 927         * printcmd.c: Fix includes.
 928         * or1k-tdep.c: Fix includes.
 929         * mi/mi-main.c: Fix includes.
 930         * m32r-tdep.c: Fix includes.
 931         * csky-tdep.c: Fix includes.
 932         * compile/compile-cplus-types.c: Fix includes.
 933         * cli/cli-interp.c: Fix includes.
 934
 935 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 936
 937         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 938         for padding.
 939
 940 2019-01-16  Tom Tromey  <tom@tromey.com>
 941
 942         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 943         earlier.
 944         (struct objfile) <msymbols_range>: Move from top level.
 945         <msymbols>: New method.
 946         (class objfile_msymbols): Remove.
 947         * symtab.c (default_collect_symbol_completion_matches_break_on):
 948         Update.
 949         * symmisc.c (dump_msymbols): Update.
 950         * stabsread.c (scan_file_globals): Update.
 951         * objc-lang.c (info_selectors_command, info_classes_command)
 952         (find_methods): Update.
 953         * minsyms.c (find_solib_trampoline_target): Update.
 954         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 955         * coffread.c (coff_symfile_read): Update.
 956         * ada-lang.c (ada_lookup_simple_minsym)
 957         (ada_collect_symbol_completion_matches): Update.
 958
 959 2019-01-16  Tom Tromey  <tom@tromey.com>
 960
 961         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 962         type.  Remove no-argument constructor.
 963         <iterator::operator++>: Simplify.
 964         <begin>: Update.
 965         <end>: Use minimal_symbol_count.
 966
 967 2019-01-16  Tom Tromey  <tom@tromey.com>
 968
 969         * objfiles.h (struct objfile) <psymtabs>: New method.
 970         (class objfile_psymtabs): Remove.
 971         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 972         typedef.
 973         <range>: New method.
 974         (require_partial_symbols): Change return type.
 975         * psymtab.c (require_partial_symbols)
 976         (psym_expand_symtabs_matching): Update.
 977         * mdebugread.c (parse_partial_symbols): Update.
 978         * dbxread.c (dbx_end_psymtab): Update.
 979
 980 2019-01-15  Tom Tromey  <tom@tromey.com>
 981
 982         * symtab.c (lookup_objfile_from_block)
 983         (lookup_symbol_in_objfile_symtabs)
 984         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 985         (find_line_symtab, info_sources_command)
 986         (default_collect_symbol_completion_matches_break_on)
 987         (make_source_files_completion_list): Update.
 988         * symmisc.c (print_objfile_statistics, dump_objfile)
 989         (maintenance_print_symbols, maintenance_info_symtabs)
 990         (maintenance_check_symtabs, maintenance_info_line_tables):
 991         Update.
 992         * source.c (select_source_symtab)
 993         (forget_cached_source_info_for_objfile): Update.
 994         * objfiles.h (class objfile_compunits): Remove.
 995         (struct objfile) <compunits_range>: New typedef.
 996         (compunits): New method.
 997         * objfiles.c (objfile_relocate1): Update.
 998         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 999         * maint.c (count_symtabs_and_blocks): Update.
1000         * linespec.c (iterate_over_all_matching_symtabs): Update.
1001         * cp-support.c (add_symbol_overload_list_qualified): Update.
1002         * coffread.c (coff_symtab_read): Update.
1003         * ada-lang.c (add_nonlocal_symbols)
1004         (ada_collect_symbol_completion_matches)
1005         (ada_add_global_exceptions): Update.
1006
1007 2019-01-15  Tom Tromey  <tom@tromey.com>
1008
1009         * progspace.h (program_space) <objfiles_safe_range>: New
1010         typedef.
1011         <objfiles_safe>: New method.
1012         * objfiles.h (class all_objfiles_safe): Remove.
1013         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1014         * jit.c (jit_inferior_exit_hook): Update.
1015
1016 2019-01-17  Tom Tromey  <tom@tromey.com>
1017
1018         * progspace.h (program_space) <objfiles_range>: New typedef.
1019         <objfiles>: New method.
1020         <objfiles_head>: Rename from objfiles.
1021         (object_files): Update.
1022         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1023         * guile/scm-pretty-print.c
1024         (ppscm_find_pretty_printer_from_objfiles): Update.
1025         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1026         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1027         Update.
1028         * python/py-progspace.c (pspy_get_objfiles): Update.
1029         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1030         Update.
1031         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1032         (objfpy_lookup_objfile_by_build_id): Update.
1033         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1034         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1035         Update.
1036         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1037         (expand_symtab_containing_pc, lookup_objfile_from_block)
1038         (lookup_static_symbol, basic_lookup_transparent_type)
1039         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1040         (find_line_symtab, info_sources_command)
1041         (default_collect_symbol_completion_matches_break_on)
1042         (make_source_files_completion_list, find_main_name): Update.
1043         * symmisc.c (print_symbol_bcache_statistics)
1044         (print_objfile_statistics, maintenance_print_symbols)
1045         (maintenance_print_msymbols, maintenance_print_objfiles)
1046         (maintenance_info_symtabs, maintenance_check_symtabs)
1047         (maintenance_expand_symtabs, maintenance_info_line_tables):
1048         Update.
1049         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1050         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1051         (map_overlay_command, unmap_overlay_command)
1052         (simple_overlay_update, expand_symtabs_matching)
1053         (map_symbol_filenames): Update.
1054         * symfile-debug.c (set_debug_symfile): Update.
1055         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1056         Update.
1057         * source.c (select_source_symtab, forget_cached_source_info):
1058         Update.
1059         * solib.c (solib_read_symbols): Update.
1060         * solib-spu.c (append_ocl_sos): Update.
1061         * psymtab.c (maintenance_print_psymbols)
1062         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1063         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1064         * printcmd.c (info_symbol_command): Update.
1065         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1066         Update.
1067         * objfiles.h (class all_objfiles): Remove.
1068         * objfiles.c (have_partial_symbols, have_full_symbols)
1069         (have_minimal_symbols, qsort_cmp, update_section_map)
1070         (shared_objfile_contains_address_p)
1071         (default_iterate_over_objfiles_in_search_order): Update.
1072         * objc-lang.c (info_selectors_command, info_classes_command)
1073         (find_methods): Update.
1074         * minsyms.c (find_solib_trampoline_target): Update.
1075         * maint.c (maintenance_info_sections)
1076         (maintenance_translate_address, count_symtabs_and_blocks):
1077         Update.
1078         * main.c (captured_main_1): Update.
1079         * linux-thread-db.c (try_thread_db_load_from_pdir)
1080         (has_libpthread): Update.
1081         * linespec.c (iterate_over_all_matching_symtabs)
1082         (search_minsyms_for_name): Update.
1083         * jit.c (jit_find_objf_with_entry_addr): Update.
1084         * hppa-tdep.c (find_unwind_entry)
1085         (hppa_lookup_stub_minimal_symbol): Update.
1086         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1087         Update.
1088         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1089         (elf_gnu_ifunc_resolve_by_got): Update.
1090         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1091         * dwarf-index-write.c (save_gdb_index_command): Update.
1092         * cp-support.c (add_symbol_overload_list_qualified): Update.
1093         * breakpoint.c (create_overlay_event_breakpoint)
1094         (create_longjmp_master_breakpoint)
1095         (create_std_terminate_master_breakpoint)
1096         (create_exception_master_breakpoint): Update.
1097         * blockframe.c (find_pc_partial_function): Update.
1098         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1099         (ada_collect_symbol_completion_matches)
1100         (ada_add_global_exceptions): Update.
1101
1102 2019-01-17  Tom Tromey  <tom@tromey.com>
1103
1104         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1105         declare VEC.
1106         (solib_target_parse_libraries): Change return type.
1107         (library_list_start_segment, library_list_start_section)
1108         (library_list_end_library, library_list_start_library); Update.
1109         (solib_target_free_library_list): Remove.
1110         (solib_target_parse_libraries): Remove cleanup.  Change return
1111         type.
1112         (solib_target_current_sos): Update.
1113
1114 2019-01-17  Tom Tromey  <tromey@bapiya>
1115
1116         * valprint.c: Replace "the the" with "the".
1117         * symtab.c: Replace "the the" with "the".
1118         * solib.c: Replace "the the" with "the".
1119         * solib-dsbt.c: Replace "the the" with "the".
1120         * linespec.c: Replace "the the" with "the".
1121         * dwarf2loc.h: Replace "the the" with "the".
1122         * amd64-windows-tdep.c: Replace "the the" with "the".
1123         * aarch64-tdep.c: Replace "the the" with "the".
1124
1125 2019-01-16  Keith Seitz  <keiths@redhat.com>
1126
1127         PR gdb/23773
1128         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1129         <builder>: Rename to ..
1130         <m_builder>: ... this and make private.
1131         (dwarf2_cu::get_builder): New method.  Change all users of
1132         `builder' to use this method.
1133         (dwarf2_start_symtab): Move to ...
1134         (dwarf2_cu::start_symtab): ... here.  Update all callers
1135         (setup_type_unit_groups): Move to ...
1136         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1137         callers.
1138         (dwarf2_cu::reset_builder): New method.
1139         (process_full_compunit, process_full_type_unit): Use
1140         dwarf2_cu::reset_builder.
1141         (follow_die_offset): Record the ancestor CU if it is different
1142         from the followed DIE's CU.
1143         (follow_die_sig_1): Likewise.
1144
1145 2019-01-15  Tom Tromey  <tom@tromey.com>
1146
1147         * remote.c (class remote_state) <buf>: Now a char_vector.
1148         <buf_size>: Remove.
1149         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1150         parameter.
1151         (remote_target::getpkt_or_notif_sane_1)
1152         (remote_target::getpkt_sane)
1153         (remote_target::getpkt_or_notif_sane): Likewise.
1154         (class remote_target) <putpkt>: New overload.
1155         (remote_target::read_frame): Change type of "buf_p".  Remove
1156         sizeof_p parameter.
1157         (packet_ok): New overload.
1158         (packet_check_result): New overload.
1159         Update all uses.
1160
1161 2019-01-14  Tom Tromey  <tom@tromey.com>
1162
1163         * remote-notif.c (handle_notification, remote_notif_ack)
1164         (remote_notif_parse): Make "buf" const.
1165         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1166         const.
1167         (remote_notif_parse, remote_notif_ack, handle_notification):
1168         Likewise.
1169         * remote.c (remote_notif_stop_parse): Make "buf" const.
1170         (remote_target::remote_parse_stop_reply): Make "buf" const.
1171         (remote_notif_stop_ack): Make "buf" const.
1172
1173 2019-01-14  Tom Tromey  <tom@tromey.com>
1174
1175         * remote.c (remote_console_output): Make parameter const.
1176
1177 2019-01-14  Tom Tromey  <tom@tromey.com>
1178
1179         * target-debug.h (target_debug_print_signals): Constify.
1180         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1181         * procfs.c (procfs_target::pass_signals): Update.
1182         * linux-nat.c (linux_nat_target::pass_signals): Update.
1183         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1184         * target-delegates.c: Rebuild.
1185         * remote.c (remote_target::program_signals): Update.
1186         (remote_target::pass_signals): Update.
1187         * target.c (target_pass_signals): Constify argument.
1188         (target_program_signals): Likewise.
1189         * target.h (struct target_ops) <pass_signals, program_signals>:
1190         Constify argument.
1191         (target_pass_signals, target_program_signals): Constify argument.
1192
1193 2019-01-14  Tom Tromey  <tom@tromey.com>
1194
1195         PR tui/28819:
1196         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1197
1198 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1199
1200         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1201         field.
1202         * rs6000-tdep.c: Include reggroups.h.
1203         (IS_V_ALIAS_PSEUDOREG): Define.
1204         (rs6000_register_name): Return names for the "vX" aliases.
1205         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1206         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1207         aliases.  Call default_register_reggroup_p for all other
1208         pseudo-registers.
1209         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1210         New functions.
1211         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1212         Handle "vX" aliases.
1213         (v_alias_pseudo_register_collect): New function.
1214         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1215         (rs6000_gdbarch_init): Initialize "vX" aliases as
1216         pseudo-registers.  Restore registration of
1217         rs6000_pseudo_register_reggroup_p with
1218         set_tdesc_pseudo_register_reggroup_p.
1219
1220 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1221
1222         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1223         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1224         set_gdbarch_num_pseudo_regs.
1225
1226 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1227
1228         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1229         Remove arg prefixname, add do_set and do_show.
1230         Add member functions set_list and show_list.
1231         * cli/cli-style.c (class cli_style_option): Update accordingly.
1232         (style_set_list): Move to file scope.
1233         (style_show_list): Likewise.
1234         (set_style): Call help_list.
1235         (show_style): Call cmd_show_list.
1236         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1237         Update to use the new macro.
1238
1239 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1240
1241         * ada-lang.c (_initialize_ada_language): Expand the help text
1242         for the "catch exception" command.
1243
1244 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1245
1246         * symtab.c (matching_obj_sections): Initialize obj,
1247         declare it closer to its usage.
1248
1249 2019-01-10  Tom Tromey  <tom@tromey.com>
1250
1251         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1252         (basic_inf_threads_range): Remove.
1253         (inf_threads_range, inf_non_exited_threads_range)
1254         (safe_inf_threads_range): Use next_adapter.
1255
1256 2019-01-10  Keith Seitz  <keiths@redhat.com>
1257
1258         PR gdb/23712
1259         PR symtab/23010
1260         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1261         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1262
1263 2019-01-10  Keith Seitz  <keiths@redhat.com>
1264
1265         PR gdb/23712
1266         PR symtab/23010
1267         * dictionary.c (pending_to_vector): Remove.
1268         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1269         Remove _1 suffix, replacing functions of the same name.  Update
1270         all callers.
1271         (dict_create_hashed, dict_create_hashed_expandable)
1272         (dict_create_linear, dict_create_linear_expandable, dict_free)
1273         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1274         Make functions static.
1275
1276 2019-01-10  Keith Seitz  <keiths@redhat.com>
1277
1278         PR gdb/23712
1279         PR symtab/23010
1280         * dictionary.h (struct dictionary): Replace declaration with
1281         multidictionary.
1282         (dict_create_hashed, dict_create_hashed_expandable)
1283         (dict_create_linear, dict_create_linear_expandable)
1284         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1285         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1286         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1287         taking multidictionary argument.
1288         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1289         * block.h (struct block) <dict>: Change to multidictionary
1290         and rename `multidict'.
1291         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1292         symmisc.c: Update all dictionary references to multidictionary.
1293
1294 2019-01-10  Keith Seitz  <keiths@redhat.com>
1295
1296         PR gdb/23712
1297         PR symtab/23010
1298         * dictionary.c: Include unordered_map.
1299         (pending_to_vector): New function.
1300         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1301         Rewrite the non-"_1" functions to take vector instead
1302         of linked list.
1303         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1304         "new" _1 versions of the same name.
1305         (multidictionary): Define.
1306         (std::hash<enum language): New definition.
1307         (collate_pending_symbols_by_language, mdict_create_hashed)
1308         (mdict_create_hashed_expandable, mdict_create_linear)
1309         (mdict_create_linear_expandable, mdict_free)
1310         (find_language_dictionary, create_new_language_dictionary)
1311         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1312         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1313         (mdict_size, mdict_empty): New functions.
1314         * dictionary.h (mdict_iterator): Define.
1315
1316 2019-01-10  Pedro Alves  <palves@redhat.com>
1317
1318         * breakpoint.c (read_uploaded_action)
1319         (create_tracepoint_from_upload): Adjust to use
1320         gdb::unique_xmalloc_ptr.
1321         * ctf.c (ctf_write_uploaded_tp):
1322         (SET_ARRAY_FIELD): Use emplace_back.
1323         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1324         * tracefile-tfile.c (tfile_write_uploaded_tp):
1325         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1326         gdb::unique_xmalloc_ptr.
1327         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1328         at_string, cond_string, cmd_strings>: Replace char pointers
1329         with gdb::unique_xmalloc_ptr.
1330
1331 2019-01-10  Pedro Alves  <palves@redhat.com>
1332
1333         * solib-target.c (library_list_start_library): Don't xstrdup name.
1334
1335 2019-01-10  Pedro Alves  <palves@redhat.com>
1336
1337         * mdebugread.c (parse_partial_symbols): Use
1338         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1339
1340 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1341
1342         * linux-fork.c (scoped_switch_fork_info)
1343         <~scoped_switch_fork_info>: Fix incorrect variable name.
1344
1345 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1346
1347         * linux-fork.c (scoped_switch_fork_info)
1348         <scoped_switch_fork_info>: Make explicit.
1349         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1350
1351 2019-01-10  Tom Tromey  <tom@tromey.com>
1352
1353         * objfiles.h (objfile::reset_psymtabs): Update.
1354         * objfiles.c (objfile::objfile): Update.
1355         * psymtab.h (psymtab_storage::obstack): Update.
1356         (psymtab_storage::m_obstack): Use gdb::optional.
1357         (class psymtab_storage): Update comment.  Remove objfile
1358         parameter.
1359         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1360
1361 2019-01-10  Tom Tromey  <tom@tromey.com>
1362
1363         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1364         <free_psymtabs>: Now private.
1365         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1366         (allocate_psymtab): Use new method.
1367
1368 2019-01-10  Tom Tromey  <tom@tromey.com>
1369
1370         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1371         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1372         * mdebugread.c (parse_partial_symbols): Use
1373         allocate_dependencies.
1374         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1375         allocate_dependencies.
1376         (process_psymtab_comp_unit_reader)
1377         (build_type_psymtab_dependencies): Likewise.
1378         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1379
1380 2019-01-10  Tom Tromey  <tom@tromey.com>
1381
1382         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1383         PSYMBOL_SET_LANGUAGE.
1384         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1385
1386 2019-01-10  Tom Tromey  <tom@tromey.com>
1387
1388         * psymtab.h (psymtab_storage::obstack): New method.
1389         <m_obstack>: Rename from obstack; now private.
1390         * psymtab.c (psymtab_storage): Update.
1391         * dwarf2read.c (create_addrmap_from_index)
1392         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1393         Update.
1394
1395 2019-01-10  Tom Tromey  <tom@tromey.com>
1396
1397         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1398         * objfiles.h (objfile::reset_psymtabs): New method.
1399
1400 2019-01-10  Tom Tromey  <tom@tromey.com>
1401
1402         * symmisc.c (print_symbol_bcache_statistics): Update.
1403         (print_objfile_statistics): Update.
1404         * symfile.c (reread_symbols): Update.
1405         * psymtab.h (class psymtab_storage): New.
1406         * psymtab.c (psymtab_storage): New constructor.
1407         (~psymtab_storage): New destructor.
1408         (require_partial_symbols): Update.
1409         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1410         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1411         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1412         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1413         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1414         (start_psymtab_common, end_psymtab_common)
1415         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1416         (allocate_psymtab): Update.
1417         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1418         Update.
1419         (dump_psymtab_addrmap, maintenance_print_psymbols)
1420         (maintenance_check_psymtabs): Update.
1421         (class objfile_psymtabs): Move to objfiles.h.
1422         * psympriv.h (discard_psymtab): Now inline.
1423         (psymtab_discarder::psymtab_discarder): Update.
1424         (psymtab_discarder::~psymtab_discarder): Update.
1425         (ALL_OBJFILE_PSYMTABS): Rewrite.
1426         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1427         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1428         Remove fields.
1429         <partial_symtabs>: New field.
1430         (class objfile_psymtabs): Move from psymtab.h.  Update.
1431         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1432         psymbol_cache.
1433         (objfile::~objfile): Don't destroy psymbol_cache.
1434         * mdebugread.c (parse_partial_symbols): Update.
1435         * dwarf2read.c (create_addrmap_from_index)
1436         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1437         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1438         (add_partial_subprogram, dwarf2_ranges_read): Update.
1439         * dwarf-index-write.c (write_address_map)
1440         (write_one_signatured_type, recursively_write_psymbols)
1441         (class debug_names, class debug_names, write_psymtabs_to_index):
1442         Update.
1443
1444 2019-01-10  Tom Tromey  <tom@tromey.com>
1445
1446         * symtab.h (SYMBOL_SET_NAMES): Update.
1447         (symbol_set_names): Update.
1448         (MSYMBOL_SET_NAMES): Update.
1449         * symtab.c (symbol_set_names): Change argument to be an
1450         objfile_per_bfd_storage.
1451         * psymtab.c (add_psymbol_to_bcache): Update.
1452         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1453
1454 2019-01-10  Tom Tromey  <tom@tromey.com>
1455
1456         * symtab.c (create_demangled_names_hash): Change argument to be an
1457         objfile_per_bfd_storage.
1458         (symbol_set_names): Update.
1459
1460 2019-01-10  Tom Tromey  <tom@tromey.com>
1461
1462         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1463         init_psymbol_list.
1464         * psymtab.c (init_psymbol_list): Do nothing if already called.
1465         * psympriv.h (init_psymbol_list): Add comment.
1466         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1467         init_psymbol_list.
1468         * dbxread.c (dbx_symfile_read): Unconditionally call
1469         init_psymbol_list.
1470
1471 2019-01-10  Tom Tromey  <tom@tromey.com>
1472
1473         * xcoffread.c (scan_xcoff_symtab): Update.
1474         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1475         "where".
1476         * mdebugread.c (parse_partial_symbols)
1477         (handle_psymbol_enumerators): Update.
1478         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1479         * dbxread.c (read_dbx_symtab): Update.
1480         * psympriv.h (psymbol_placement): New enum.
1481         (add_psymbol_to_list): Update.
1482
1483 2019-01-10  Tom Tromey  <tom@tromey.com>
1484
1485         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1486         static_psymbols parameters.
1487         (scan_xcoff_symtab): Update.
1488         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1489         static_psymbols parameters.
1490         * psympriv.h (start_psymtab_common): Update.
1491         * mdebugread.c (parse_partial_symbols): Update.
1492         * dwarf2read.c (create_partial_symtab): Update.
1493         * dbxread.c (read_dbx_symtab): Update.
1494         (start_psymtab): Remove global_psymbols and static_psymbols
1495         parameters.
1496
1497 2019-01-10  Tom Tromey  <tom@tromey.com>
1498
1499         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1500         * psymtab.c (allocate_psymtab): Add comment.
1501         * psympriv.h (allocate_psymtab): Add comment.
1502         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1503         initializations.
1504         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1505
1506 2019-01-10  Tom Tromey  <tom@tromey.com>
1507
1508         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1509         Don't declare.
1510         * mipsread.c: Include mdebugread.h.
1511         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1512         Declare.
1513         * elfread.c: Include mdebugread.h.
1514
1515 2019-01-09  Tom Tromey  <tom@tromey.com>
1516
1517         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1518         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1519         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1520         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1521         (psym_lookup_symbol, psym_find_last_source_symtab)
1522         (psym_forget_cached_source_info, psym_print_stats)
1523         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1524         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1525         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1526         (psym_find_compunit_symtab_by_address)
1527         (maintenance_print_psymbols, maintenance_info_psymtabs)
1528         (maintenance_check_psymtabs): Use ranged for.
1529         * psymtab.h (class objfile_psymtabs): New.
1530         (require_partial_symbols): Return objfile_psymtabs.
1531         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1532
1533 2019-01-09  Tom Tromey  <tom@tromey.com>
1534
1535         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1536         (find_pc_mapped_section, list_overlays_command)
1537         (map_overlay_command, unmap_overlay_command)
1538         (simple_overlay_update): Use all_objfiles.
1539         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1540         * printcmd.c (info_symbol_command): Use all_objfiles.
1541         * objfiles.h (ALL_OBJSECTIONS): Remove.
1542         * maint.c (maintenance_translate_address): Use all_objfiles.
1543         * gcore.c (gcore_create_callback): Use all_objfiles.
1544         (objfile_find_memory_regions): Likewise.
1545
1546 2019-01-09  Tom Tromey  <tom@tromey.com>
1547
1548         * symtab.c (find_line_symtab, info_sources_command)
1549         (make_source_files_completion_list): Use objfile_compunits.
1550         * source.c (select_source_symtab): Use objfile_compunits.
1551         * objfiles.h (struct objfile): Update comment.
1552         (ALL_OBJFILES): Remove.
1553         (ALL_FILETABS): Remove.
1554         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1555         objfile_compunits.
1556
1557 2019-01-09  Tom Tromey  <tom@tromey.com>
1558
1559         * symmisc.c (print_objfile_statistics, dump_objfile)
1560         (maintenance_print_symbols): Use compunit_filetabs.
1561         * source.c (forget_cached_source_info_for_objfile): Use
1562         compunit_filetabs.
1563         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1564         (ALL_FILETABS): Use compunit_filetabs.
1565         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1566         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1567
1568 2019-01-09  Tom Tromey  <tom@tromey.com>
1569
1570         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1571         (compunit_filetabs): New.
1572         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1573         compunit_filetabs.
1574         (info_sources_command, make_source_files_completion_list): Remove
1575         declaration.
1576         * symmisc.c (print_objfile_statistics, dump_objfile)
1577         (maintenance_print_symbols): Remove declaration.
1578         (maintenance_info_symtabs): Use compunit_filetabs.
1579         (maintenance_info_line_tables): Likewise.
1580         * source.c (select_source_symtab): Change local variable name.
1581         (forget_cached_source_info_for_objfile): Remove declaration.
1582         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1583         * objfiles.c (objfile_relocate1): Remove declaration.
1584         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1585         declaration.
1586         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1587         * coffread.c (coff_symtab_read): Remove declaration.
1588         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1589         compunit_filetabs.
1590
1591 2019-01-09  Tom Tromey  <tom@tromey.com>
1592
1593         * symtab.c (lookup_objfile_from_block)
1594         (find_pc_sect_compunit_symtab, search_symbols)
1595         (default_collect_symbol_completion_matches_break_on): Use
1596         objfile_compunits.
1597         * objfiles.h (ALL_COMPUNITS): Remove.
1598         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1599         * cp-support.c (add_symbol_overload_list_qualified): Use
1600         objfile_compunits.
1601         * ada-lang.c (ada_collect_symbol_completion_matches)
1602         (ada_add_global_exceptions): Use objfile_compunits.
1603
1604 2019-01-09  Tom Tromey  <tom@tromey.com>
1605
1606         * source.c (select_source_symtab)
1607         (forget_cached_source_info_for_objfile): Remove declaration.
1608         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1609         declaration.
1610         * maint.c (count_symtabs_and_blocks): Remove declaration.
1611         * cp-support.c (add_symbol_overload_list_qualified): Remove
1612         declaration.
1613         * coffread.c (coff_symtab_read): Remove declaration.
1614         * symtab.c (lookup_symbol_in_objfile_symtabs)
1615         (basic_lookup_transparent_type_1): Use objfile_compunits.
1616         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1617         (info_sources_command, search_symbols)
1618         (default_collect_symbol_completion_matches_break_on)
1619         (make_source_files_completion_list): Remove declaration.
1620         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1621         (ada_collect_symbol_completion_matches)
1622         (ada_add_global_exceptions): Remove declaration.
1623         * linespec.c (iterate_over_all_matching_symtabs): Use
1624         objfile_compunits.
1625         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1626         (class objfile_compunits): New.
1627         (ALL_COMPUNITS): Use objfile_compunits.
1628         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1629         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1630         objfile_compunits.
1631         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1632
1633 2019-01-09  Tom Tromey  <tom@tromey.com>
1634
1635         * symtab.c (search_symbols)
1636         (default_collect_symbol_completion_matches_break_on): Use
1637         objfile_msymbols.
1638         * ada-lang.c (ada_lookup_simple_minsym)
1639         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1640         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1641         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1642         objfile_msymbols.
1643         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1644         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1645         * objc-lang.c (find_methods): Use objfile_msymbols.
1646         (info_selectors_command, info_classes_command): Likewise.
1647         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1648         * objfiles.h (class objfile_msymbols): New.
1649         (ALL_OBJFILE_MSYMBOLS): Remove.
1650         (ALL_MSYMBOLS): Remove.
1651
1652 2019-01-09  Tom Tromey  <tom@tromey.com>
1653
1654         * common/next-iterator.h (next_adapter): Add Iterator template
1655         parameter.
1656         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1657         (class all_objfiles_safe): New.
1658         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1659         * objfiles.c (put_objfile_before): Update comment.
1660         (add_separate_debug_objfile): Likewise.
1661         (free_all_objfiles): Use all_objfiles_safe.
1662         (objfile_purge_solibs): Likewise.
1663
1664 2019-01-09  Tom Tromey  <tom@tromey.com>
1665
1666         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1667         (expand_symtab_containing_pc, lookup_static_symbol)
1668         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1669         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1670         all_objfiles.
1671         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1672         * breakpoint.c (create_overlay_event_breakpoint)
1673         (create_longjmp_master_breakpoint)
1674         (create_std_terminate_master_breakpoint)
1675         (create_exception_master_breakpoint): Use all_objfiles.
1676         * linux-thread-db.c (try_thread_db_load_from_pdir)
1677         (has_libpthread): Use all_objfiles.
1678         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1679         * linespec.c (iterate_over_all_matching_symtabs)
1680         (search_minsyms_for_name): Use all_objfiles.
1681         * maint.c (maintenance_info_sections): Use all_objfiles.
1682         * main.c (captured_main_1): Use all_objfiles.
1683         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1684         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1685         * guile/scm-pretty-print.c
1686         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1687         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1688         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1689         (maintenance_print_msymbols): Use all_objfiles.
1690         * source.c (select_source_symtab): Use all_objfiles.
1691         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1692         * symfile.c (remove_symbol_file_command)
1693         (expand_symtabs_matching, map_symbol_filenames): Use
1694         all_objfiles.
1695         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1696         all_objfiles.
1697         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1698         * objc-lang.c (find_methods): Use all_objfiles.
1699         * objfiles.c (have_partial_symbols, have_full_symbols)
1700         (have_minimal_symbols, qsort_cmp)
1701         (default_iterate_over_objfiles_in_search_order): Use
1702         all_objfiles.
1703         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1704         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1705         (maintenance_check_psymtabs): Use all_objfiles.
1706         (ALL_PSYMTABS): Remove.
1707         * compile/compile-object-run.c (do_module_cleanup): Use
1708         all_objfiles.
1709         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1710         * cp-support.c (add_symbol_overload_list_qualified): Use
1711         all_objfiles.
1712         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1713         Use all_objfiles.
1714         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1715         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1716         all_objfiles.
1717         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1718         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1719         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1720         Uses all_objfiles.
1721         * solib.c (solib_read_symbols): Use all_objfiles
1722
1723 2019-01-09  Tom Tromey  <tom@tromey.com>
1724
1725         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1726         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1727         all_objfiles.
1728         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1729         * symmisc.c (print_symbol_bcache_statistics)
1730         (print_objfile_statistics, maintenance_print_objfiles)
1731         (maintenance_info_symtabs, maintenance_check_symtabs)
1732         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1733         all_objfiles.
1734         * source.c (forget_cached_source_info): Use all_objfiles.
1735         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1736         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1737         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1738         * objfiles.c (update_section_map): Use all_objfiles.
1739         (shared_objfile_contains_address_p): Likewise.
1740         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1741         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1742
1743 2019-01-09  Tom Tromey  <tom@tromey.com>
1744
1745         * common/next-iterator.h: New file.
1746         * objfiles.h (class all_objfiles): New.
1747         (struct objfile_iterator): New.
1748
1749 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1750
1751         * NEWS: Move the description of the changed "frame", "select-frame",
1752          and "info frame" commands to the Changed commands section.
1753
1754 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1755
1756         * gdbtypes.c (check_stub_method_group): Remove handling of old
1757         mangling schemes.
1758         * linespec.c (find_methods): Likewise.
1759         * stabsread.c (read_member_functions): Likewise.
1760         * valops.c (search_struct_method): Likewise.
1761         (value_struct_elt_for_reference): Likewise.
1762         * NEWS: Mention this change.
1763
1764 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1765
1766         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1767         print_source_lines.
1768         * source.c (print_source_lines_base): Update line number check.
1769         (print_source_lines): New function.
1770         (source_lines_range::source_lines_range): New function.
1771         * source.h (class source_lines_range): New class.
1772         (print_source_lines): New declaration.
1773
1774 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1775
1776         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1777
1778 2019-01-08  Tom Tromey  <tom@tromey.com>
1779             Simon Marchi  <simon.marchi@ericsson.com>
1780
1781         PR gdb/24060
1782         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1783         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1784         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1785         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1786         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1787         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1788
1789 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1790
1791         * source.c (select_source_symtab): Move header comment to
1792         declaration in source.h.
1793         (forget_cached_source_info_for_objfile): Likewise.
1794         (forget_cached_source_info): Likewise.
1795         (identify_source_line): Likewise.
1796         * source.h (identify_source_line): Move declaration from symtab.h
1797         and add comment from source.c
1798         (print_source_lines): Likewise.
1799         (forget_cached_source_info_for_objfile): Likewise.
1800         (forget_cached_source_info): Likewise.
1801         (select_source_symtab): Likewise.
1802         (enum print_source_lines_flag): Move definition from symtab.h.
1803         * symtab.h (identify_source_line): Move declaration to source.h.
1804         (print_source_lines): Likewise.
1805         (forget_cached_source_info_for_objfile): Likewise.
1806         (forget_cached_source_info): Likewise.
1807         (select_source_symtab): Likewise.
1808         (enum print_source_lines_flag): Move definition to source.h.
1809         * tui/tui-hooks.c: Add 'source.h' include.
1810
1811 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1812
1813         * source.c (print_source_lines_base): Handle requests to print
1814         reverse line number sequences, and guard against empty lines
1815         string.
1816
1817 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1818
1819         * source.c (print_source_lines_base): Fix skip of '\r' if next
1820         character is '\n'.
1821
1822 2019-01-06  Tom Tromey  <tom@tromey.com>
1823
1824         * c-exp.y (struct c_parse_state) <macro_original_text,
1825         expansion_obstack>: New member.
1826         (macro_original_text, expansion_obstack): Remove globals.
1827         (scan_macro_expansion, scanning_macro_expansion)
1828         (finished_macro_expansion): Update.
1829         (scan_macro_cleanup): Remove.
1830         (yylex, c_parse): Update.
1831
1832 2019-01-06  Tom Tromey  <tom@tromey.com>
1833
1834         * c-exp.y (struct c_parse_state) <strings>: New member.
1835         (operator_stoken): Update.
1836
1837 2019-01-06  Tom Tromey  <tom@tromey.com>
1838
1839         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1840         (union type_stack_elt) <typelist_val>: Now a pointer to
1841         std::vector.
1842         (type_stack_cleanup): Don't declare.
1843         (push_typelist): Update.
1844         * parse.c (pop_typelist): Return a std::vector.
1845         (push_typelist): Take a std::vector.
1846         (follow_types): Update.  Do not free args.
1847         (type_stack_cleanup): Remove.
1848         * c-exp.y (struct c_parse_state): New.
1849         (cpstate): New global.
1850         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1851         (nonempty_typelist): Update.
1852         (func_mod): Create a new vector.
1853         (c_parse): Create a c_parse_state.
1854         (check_parameter_typelist): Do not delete params.
1855         (function_method): Update.  Do not delete type_list.
1856
1857 2019-01-06  Tom Tromey  <tom@tromey.com>
1858
1859         PR gdb/28155:
1860         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1861         check_typedef.
1862         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1863         (print_return_value): Likewise.
1864
1865 2019-01-05  Tom Tromey  <tom@tromey.com>
1866
1867         * contrib/cleanup_check.py: Remove.
1868         * contrib/gcc-with-excheck: Remove.
1869         * contrib/exsummary.py: Remove.
1870         * contrib/excheck.py: Remove.
1871
1872 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1873
1874         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1875         NULL. Initialize tpprev to NULL instead of assigning it
1876         to NULL on the next statement.
1877         * windows-nat.c (windows_delete_thread): Remove check for
1878         main_thread_id before printing thread exit notifications.
1879         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1880         Remove thread ID check against main_thread_id.
1881         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1882         windows_delete_thread.
1883         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1884
1885 2019-01-04  Tom Tromey  <tom@tromey.com>
1886
1887         * compile/compile.c (_initialize_compile): Use upper case for
1888         metasyntactic variables.
1889         * symmisc.c (_initialize_symmisc): Use upper case for
1890         metasyntactic variables.
1891         * psymtab.c (_initialize_psymtab): Use upper case for
1892         metasyntactic variables.
1893         * demangle.c (demangle_command): Use upper case for metasyntactic
1894         variables.
1895         (_initialize_demangler): Likewise.
1896         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1897         variables.
1898
1899 2019-01-03  Tom Tromey  <tom@tromey.com>
1900
1901         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1902
1903 2019-01-03  Tom Tromey  <tom@tromey.com>
1904
1905         * python/py-symtab.c (salpy_str): Update.
1906         (struct salpy_sal_object) <symtab>: Now a PyObject.
1907         (salpy_dealloc): Update.
1908         (del_objfile_sal): Use gdbpy_ref.
1909
1910 2019-01-03  Tom Tromey  <tom@tromey.com>
1911
1912         * python/py-type.c (convert_field): Use new_reference.  Return
1913         gdbpy_ref.
1914         (make_fielditem): Return gdbpy_ref.
1915         (typy_fields): Update.
1916         (typy_getitem): Update.
1917         (field_name): Return gdbpy_ref.  Use new_reference.
1918         (typy_iterator_iternext): Update.
1919
1920 2019-01-03  Tom Tromey  <tom@tromey.com>
1921
1922         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1923
1924 2019-01-03  Tom Tromey  <tom@tromey.com>
1925
1926         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1927         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1928         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1929         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1930         (pspy_set_type_printers): Likewise.
1931         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1932         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1933         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1934         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1935         (objfpy_set_type_printers): Likewise.
1936
1937 2019-01-03  Tom Tromey  <tom@tromey.com>
1938
1939         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1940         (gdbpy_print_stack): Use gdbpy_err_fetch.
1941         * python/python-internal.h (class gdbpy_err_fetch): New class.
1942         (class gdbpy_enter) <m_error_type, m_error_value,
1943         m_error_traceback>: Remove.
1944         <m_error>: New member.
1945         (gdbpy_exception_to_string): Don't declare.
1946         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1947         * python/py-value.c (convert_value_from_python): Use
1948         gdbpy_err_fetch.
1949         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1950         gdbpy_exception_to_string.
1951         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1952         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1953         gdbpy_err_fetch.
1954
1955 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1956
1957         * linux-nat.c (delete_lwp_cleanup): Delete.
1958         (struct lwp_deleter): New struct.
1959         (lwp_info_up): New typedef.
1960         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1961         lwp_info_up.
1962
1963 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1964
1965         * linux-fork.c (class scoped_switch_fork_info): New class.
1966         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1967
1968 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1969
1970         * valops.c (find_overload_match): Remove use of null_cleanup, and
1971         calls to do_cleanups.
1972
1973 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1974
1975         * compile/compile-cplus-types.c
1976         (compile_cplus_instance::decl_name): Handle changes to
1977         cp_func_name.
1978         * cp-support.c (cp_func_name): Update header comment, update
1979         return type.
1980         * cp-support.h (cp_func_name): Update return type in declaration.
1981         * valops.c (find_overload_match): Move temp_func local to top
1982         level of function and change its type.  Use temp_func to hold and
1983         delete temporary string obtained from cp_func_name.
1984
1985 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1986
1987         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1988         gdb::char_vector, remove cleanup, and update uses of `msg`.
1989
1990 2019-01-03  Jim Wilson  <jimw@sifive.com>
1991
1992         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1993
1994 2019-01-02  Tom Tromey  <tom@tromey.com>
1995
1996         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1997         (tdesc_parse_xml): Remove cleanups.
1998         * target-descriptions.h (make_cleanup_free_target_description):
1999         Don't declare.
2000         (target_desc_deleter): New struct.
2001         (target_desc_up): New typedef.
2002         * target-descriptions.c (target_desc_deleter::operator()): Rename
2003         from free_target_description.
2004         (make_cleanup_free_target_description): Remove.
2005
2006 2019-01-02  Tom Tromey  <tom@tromey.com>
2007
2008         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2009         constructor, destructor.
2010         (linespec_parser): Remove typedef.
2011         (~linespec_parser): Rename from linespec_parser_delete.
2012         (linespec_lex_to_end, linespec_complete_label)
2013         (linespec_complete): Update.
2014         (decode_line_full): Remove cleanups.
2015         (decode_line_1): Update.
2016
2017 2019-01-02  Tom Tromey  <tom@tromey.com>
2018
2019         * python/python-internal.h (inferior_to_inferior_object): Change
2020         return type.
2021         * python/py-exitedevent.c (create_exited_event_object): Update.
2022         * python/py-inferior.c (inferior_to_inferior_object): Return
2023         gdbpy_ref.
2024         (python_new_inferior, python_inferior_deleted)
2025         (thread_to_thread_object, delete_thread_object)
2026         (build_inferior_list, gdbpy_selected_inferior): Update.
2027         * python/py-infthread.c (create_thread_object): Update.  Also fail
2028         if inferior_to_inferior_object fails.
2029
2030 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2031
2032         * inferior.h (class inferior) <displaced_step_state>: New field.
2033         * infrun.h (struct displaced_step_state): Move here from
2034         infrun.c.  Initialize fields, add constructor.
2035         <inf>: Remove field.
2036         <reset>: New method.
2037         * infrun.c (struct displaced_step_inferior_state): Move to
2038         infrun.h.
2039         (displaced_step_inferior_states): Remove.
2040         (get_displaced_stepping_state): Adust.
2041         (displaced_step_in_progress_any_inferior): Adjust.
2042         (displaced_step_in_progress_thread): Adjust.
2043         (displaced_step_in_progress): Adjust.
2044         (add_displaced_stepping_state): Remove.
2045         (get_displaced_step_closure_by_addr): Adjust.
2046         (remove_displaced_stepping_state): Remove.
2047         (infrun_inferior_exit): Call displaced_step_state.reset.
2048         (use_displaced_stepping): Don't check for NULL.
2049         (displaced_step_prepare_throw): Call
2050         get_displaced_stepping_state.
2051         (displaced_step_fixup): Don't check for NULL.
2052         (prepare_for_detach): Don't check for NULL.
2053
2054 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2055
2056         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2057          in case of call that did not complete.
2058
2059 2019-01-02  Andrey Utkin  <autkin@undo.io>
2060
2061         * symfile.c (find_separate_debug_file): Fix search of debug files for
2062         remote debuggee.
2063
2064 2019-01-02  Tom Tromey  <tom@tromey.com>
2065
2066         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2067         indentation.
2068         * python/py-frame.c (frapy_older): Remove cast.
2069         (frapy_newer): Likewise.
2070         * python/py-breakpoint.c (local_setattro): Remove cast.
2071         * python/py-arch.c (archpy_name): Remove local variable.
2072         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2073
2074 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2075
2076         * unittests/basic_string_view/element_access/char/empty.cc:
2077         Fix year range in copyright header.
2078
2079 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2080
2081         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2082         Delete.
2083         <operator==>: Update with for removed field.
2084         <hash>: Likewise.
2085         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2086         <isa_features>: ...this.
2087         <abi_features>: New field.
2088         (riscv_isa_flen): Update comment.
2089         (riscv_abi_xlen): New declaration.
2090         (riscv_abi_flen): New declaration.
2091         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2092         isa_features.
2093         (riscv_abi_xlen): New function.
2094         (riscv_isa_flen): Update to get answer from isa_features.
2095         (riscv_abi_flen): New function.
2096         (riscv_has_fp_abi): Update to get answer from abi_features.
2097         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2098         xlen and flen.
2099         (riscv_call_info) <xlen, flen>: Update comment.
2100         (riscv_call_arg_struct): Remove invalid assertions
2101         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2102         is removed.
2103         (riscv_gdbarch_init): Gather isa features and abi features
2104         separately, ensure both match on the gdbarch when reusing an old
2105         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2106         a target with 64-bit float hardware.
2107
2108 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2109
2110         * source.c (search_command_helper): Stop reverse search
2111         when line 1 has been searched.
2112
2113 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2114
2115         * record-full.c (record_full_base_target::close): Rewrite
2116         record_full_core_buf_list free logic.
2117
2118 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2119
2120         * break-catch-syscall.c (print_one_catch_syscall): xfree
2121         the last text.
2122
2123 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2124
2125         * top.c (print_gdb_version): Update Copyright year in version
2126         message.
2127
2128 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2129
2130         Update copyright year range in all GDB files.
2131
2132 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2133
2134         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2135
2136 For older changes see ChangeLog-2018.
2137 \f
2138 Local Variables:
2139 mode: change-log
2140 left-margin: 8
2141 fill-column: 74
2142 version-control: never
2143 coding: utf-8
2144 End:
2145