gdb/ChangeLog

   1 2018-05-22  Pedro Alves  <palves@redhat.com>
   2
   3         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
   4         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
   5         (get_fixed_memory_packet_size): New.
   6         (get_memory_packet_size): Use it.
   7         (set_memory_packet_size): Don't override the config size with
   8         DEFAULT_MAX_MEMORY_PACKET_SIZE.
   9         (show_memory_packet_size): Use get_fixed_memory_packet_size.
  10         Don't refer to get_memory_packet_size if not connected to a remote
  11         target.  Show "(default)" if configured size is 0.
  12
  13 2018-05-22  Pedro Alves  <palves@redhat.com>
  14
  15         * remote.c (remote_target::mourn_inferior): Move
  16         discard_pending_stop_replies call here from ...
  17         (_initialize_remote): ... here.
  18
  19 2018-05-22  Pedro Alves  <palves@redhat.com>
  20
  21         * remote.c (compare_section_command): Remove set_general_process
  22         call.
  23
  24 2018-05-22  Pedro Alves  <palves@redhat.com>
  25
  26         * remote.c (struct packet_reg, struct remote_arch_state):
  27         Move higher up in the file.
  28         (remote_state) <m_arch_states>: Store remote_arch_state values
  29         instead of remote_arch_state pointers.
  30         (remote_state::get_remote_arch_state): Adjust.
  31
  32 2018-05-22  Pedro Alves  <palves@redhat.com>
  33
  34         * remote.c: Include <unordered_map>.
  35         (remote_state): Now a class.
  36         (remote_state) <get_remote_arch_state>: Declare method.
  37         <get_remote_arch_state>: New field.
  38         (remote_arch_state) <remote_arch_state>: Declare ctor.
  39         <regs>: Now a unique_ptr.
  40         (remote_gdbarch_data_handle): Delete.
  41         (get_remote_arch_state): Delete.
  42         (remote_state::get_remote_arch_state): New.
  43         (get_remote_state): Adjust to call remote_state's
  44         get_remote_arch_state method.
  45         (init_remote_state): Delete, bits factored out to ...
  46         (remote_arch_state::remote_arch_state): ... this new method.
  47         (get_remote_packet_size, get_memory_packet_size)
  48         (process_g_packet, remote_target::fetch_registers)
  49         (remote_target::prepare_to_store, store_registers_using_G)
  50         (remote_target::store_registers, remote_target::get_trace_status):
  51         Adjust to call remote_state's method.
  52         (_initialize_remote): Remove reference to
  53         remote_gdbarch_data_handle.
  54
  55 2018-05-22  Pedro Alves  <palves@redhat.com>
  56
  57         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
  58         pread>: New method declarations.
  59         (remote_target::open_1): Adjust.
  60         (readahead_cache_invalidate): Rename to ...
  61         (readahead_cache::invalidate): ... this, and adjust to be a class
  62         method.
  63         (readahead_cache_invalidate_fd): Rename to ...
  64         (readahead_cache::invalidate_fd): ... this, and adjust to be a
  65         class method.
  66         (remote_hostio_pwrite): Adjust.
  67         (remote_hostio_pread_from_cache): Rename to ...
  68         (readahead_cache::pread): ... this, and adjust to be a class
  69         method.
  70         (remote_hostio_close): Adjust.
  71
  72 2018-05-22  Pedro Alves  <palves@redhat.com>
  73
  74         * remote.c (remote_hostio_close_cleanup): Delete.
  75         (class scoped_remote_fd): New.
  76         (remote_file_put, remote_file_get): Use it.
  77
  78 2018-05-22  Pedro Alves  <palves@redhat.com>
  79
  80         (struct vCont_action_support): Use bool and initialize all fields.
  81         (struct readahead_cache): Initialize all fields.
  82         (remote_state): Use bool and initialize all fields.
  83         (remote_state::remote_state, remote_state::~remote_state): New.
  84         (new_remote_state): Delete.
  85         (_initialize_remote): Use new to allocate remote_state.
  86
  87 2018-05-22  Pedro Alves  <palves@redhat.com>
  88             張俊芝  <zjz@zjz.name>
  89
  90         PR gdb/22973
  91         * c-exp.y: Include "c-support.h".
  92         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
  93         of tolower.  Use c_ident_is_alpha to scan names.
  94         * c-lang.c: Include "c-support.h".
  95         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
  96         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
  97         * c-support.h: New file, with bits factored out from ...
  98         * cp-name-parser.y: ... this file.
  99         Include "c-support.h".
 100         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
 101         c-support.h and renamed.
 102         (symbol_end, yylex): Adjust.
 103
 104 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 105
 106         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
 107         parameter type to CORE_ADDR.
 108         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
 109         parameter type in declaration to CORE_ADDR.
 110         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
 111         target_auxv_search to get AT_HWCAP and use the result to get the
 112         target description.
 113         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
 114         to CORE_ADDR. Remove the cast of the return value to unsigned
 115         long. Fix error predicate of target_auxv_search.
 116         (ppc_linux_nat_target::read_description): Change the type of the
 117         hwcap variable to CORE_ADDR.
 118
 119 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 120
 121         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
 122         if the size of fpscr is larger than 32 bits.
 123
 124 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 125
 126         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
 127         (ppc32_linux_vsxregmap): New global.
 128         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
 129         regcache_supply_regset, and regcache_collect_regset.
 130         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
 131         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
 132         (fetch_vsx_register, store_vsx_register): Remove.
 133         (fetch_vsx_registers): Add regno parameter. Get regset using
 134         ppc_linux_vsxregset. Use regset to supply registers.
 135         (store_vsx_registers): Add regno parameter. Get regset using
 136         ppc_linux_vsxregset. Use regset to collect registers.
 137         (fetch_register): Call fetch_vsx_registers instead of
 138         fetch_vsx_register.
 139         (store_register): Call store_vsx_registers instead of
 140         store_vsx_register.
 141         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
 142         new regno parameter.
 143         (store_ppc_registers): Call store_vsx_registers with -1 for the
 144         new regno parameter.
 145         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
 146         (ppc_collect_vsxregset): Remove.
 147
 148 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 149
 150         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
 151         offset fields.
 152         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
 153         for vector register offset fields.
 154         (ppc64_fbsd_reg_offsets): Likewise.
 155         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
 156         to vector register offset fields.
 157         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
 158         to vector register offset fields.
 159         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
 160         vector register offset fields.
 161         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
 162         initializers for vector register offset fields.
 163         (rs6000_aix64_reg_offsets): Likewise.
 164         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
 165         (ppc_supply_vrregset): Remove.
 166         (ppc_collect_vrregset): Remove.
 167         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
 168         (ppc_linux_vrregset) : New function.
 169         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
 170         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
 171         (ppc32_linux_vrregset): Remove.
 172         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
 173         and use result instead of ppc32_linux_vrregset.
 174         (ppc32_linux_reg_offsets): Remove initializers for vector register
 175         offset fields.
 176         (ppc64_linux_reg_offsets): Likewise.
 177         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
 178         * ppc-linux-nat.c: Include regset.h.
 179         (gdb_vrregset_t): Adjust comment to account for little-endian
 180         mode.
 181         (supply_vrregset, fill_vrregset): Remove.
 182         (fetch_altivec_register, store_altivec_register): Remove.
 183         (fetch_altivec_registers): Add regno parameter. Get regset using
 184         ppc_linux_vrregset. Use regset to supply registers.
 185         (store_altivec_registers): Add regno parameter. Get regset using
 186         ppc_linux_vrregset. Use regset to collect registers.
 187         (fetch_register): Call fetch_altivec_registers instead of
 188         fetch_altivec_register.
 189         (store_register): Call store_altivec_registers instead of
 190         store_altivec_register.
 191         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
 192         the new regno parameter.
 193         (store_ppc_registers): Call store_altivec_registers with -1 for
 194         the new regno parameter.
 195
 196 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 197
 198         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
 199         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
 200         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
 201         (gdb_vrregset_t): Change array type size to
 202         PPC_LINUX_SIZEOF_VRREGSET.
 203         (gdb_vsxregset_t): Change array type size to
 204         PPC_LINUX_SIZEOF_VSXREGSET.
 205         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
 206         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
 207         PPC_LINUX_SIZEOF_VSXREGSET.
 208
 209 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 210
 211         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
 212         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
 213         nat/ppc-linux.c.
 214         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
 215         ppc_linux_target_wordsize with tid.
 216         (ppc_linux_nat_target::read_description): Call ppc_linux_target
 217         wordsize with tid.
 218         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
 219         (ppc64_64bit_inferior_p): Add static and inline specifiers.
 220         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
 221         tid parameter. Remove static specifier.
 222         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
 223         (ppc_linux_target_wordsize): New declaration.
 224
 225 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 226
 227         * arch/ppc-linux-common.c: New file.
 228         * arch/ppc-linux-common.h: New file.
 229         * arch/ppc-linux-tdesc.h: New file.
 230         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
 231         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
 232         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
 233         arch/ppc-linux-tdesc.h.
 234         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
 235         arch/ppc-linux-tdesc.h.
 236         (ppc_linux_nat_target::read_description): Remove target
 237         description matching code. Fill a ppc_linux_features struct and
 238         call ppc_linux_match_description with it. Move comment about ISA
 239         2.05 to ppc-linux-common.c.
 240         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
 241         arch/ppc-linux-tdesc.h.
 242         (ppc_linux_core_read_description): Remove target description
 243         matching code. Fill a ppc_linux_features struct and call
 244         ppc_linux_match_description with it.
 245         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
 246         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
 247         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
 248         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
 249         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
 250         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
 251         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
 252         (tdesc_powerpc_e500l): Remove.
 253
 254 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
 255
 256         * ada-lang.c (catch_assert_command): Pass empty string instead
 257         of NULL for excep_string argument.
 258
 259 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
 260
 261         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
 262         the width of the requested register exceeds the width of the
 263         `ptrace' data type.
 264
 265 2018-05-21  Tom Tromey  <tom@tromey.com>
 266
 267         * printcmd.c (output_command): Remove.
 268         (output_command_const): Rename to output_command.
 269         * valprint.h (output_command): Rename from output_command_const.
 270         * tracepoint.c (trace_dump_actions): Call output_command.
 271
 272 2018-05-21  Tom Tromey  <tom@tromey.com>
 273
 274         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
 275         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
 276         * ada-lang.h (create_ada_exception_catchpoint): Update.
 277         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
 278         std::string.
 279         (create_excep_cond_exprs, ~ada_catchpoint)
 280         (should_stop_exception, print_one_exception)
 281         (print_mention_exception, print_recreate_exception): Update.
 282         (ada_get_next_arg): Remove.
 283         (catch_ada_exception_command_split): Use std::string.  Change type
 284         of "excep_string", "cond_string".
 285         (catch_ada_exception_command): Update.
 286         (create_ada_exception_catchpoint): Change type of excep_string.
 287         (ada_exception_sal): Remove excep_string parameter.
 288         (~ada_catchpoint): Remove.
 289
 290 2018-05-21  Tom Tromey  <tom@tromey.com>
 291
 292         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
 293         cleanup.
 294
 295 2018-05-21  Tom Tromey  <tom@tromey.com>
 296
 297         * ada-lang.c (ada_exception_message_1, ada_exception_message):
 298         Return unique_xmalloc_ptr.
 299         (print_it_exception): Update.
 300
 301 2018-05-21  Tom Tromey  <tom@tromey.com>
 302
 303         * tracepoint.c (trace_dump_actions): Use std::string.
 304
 305 2018-05-21  Tom Tromey  <tom@tromey.com>
 306
 307         * symfile.c (reread_symbols): Use std::string for original_name.
 308
 309 2018-05-21  Tom Tromey  <tom@tromey.com>
 310
 311         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
 312         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
 313         constructor.
 314
 315 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
 316
 317         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
 318         instance to...
 319         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
 320         * objfiles.c (get_objfile_bfd_data): Allocate
 321         objfile_per_bfd_storage with obstack_new when allocating on
 322         obstack.
 323
 324 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
 325
 326         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
 327         OBSTACK_ZALLOC.
 328         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
 329         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
 330         * mdebugread.c (mdebug_build_psymtabs): Likewise.
 331         (add_pending): Likewise.
 332         (parse_symbol): Likewise.
 333         (parse_partial_symbols): Likewise.
 334         (psymtab_to_symtab_1): Likewise.
 335         (new_psymtab): Likewise.
 336         (elfmdebug_build_psymtabs): Likewise.
 337         * minsyms.c (terminate_minimal_symbol_table): Likewise.
 338         * objfiles.c (get_objfile_bfd_data): Likewise.
 339         (objfile_register_static_link): Likewise.
 340         * psymtab.c (allocate_psymtab): Likewise.
 341         * stabsread.c (read_member_functions): Likewise.
 342         * xcoffread.c (xcoff_end_psymtab): Likewise.
 343
 344 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
 345
 346         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
 347         compiler supports std::is_trivially_constructible.
 348         * common/poison.h: Include obstack.h.
 349         (IsMallocable): Define to is_trivially_constructible if the
 350         compiler supports it, define to true_type otherwise.
 351         (xobnew): New.
 352         (XOBNEW): Redefine.
 353         (xobnewvec): New.
 354         (XOBNEWVEC): Redefine.
 355         * gdb_obstack.h (obstack_zalloc): New.
 356         (OBSTACK_ZALLOC): Redefine.
 357         (obstack_calloc): New.
 358         (OBSTACK_CALLOC): Redefine.
 359         (obstack_new): New.
 360         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
 361         (gdbarch_obstack): New declaration in gdbarch.h, definition in
 362         gdbarch.c.
 363         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
 364         obstack_calloc/obstack_zalloc.
 365         (gdbarch_obstack_zalloc): Remove.
 366         * target-descriptions.c (tdesc_data_init): Use obstack_new.
 367
 368 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 369
 370         * stack.c (backtrace_command_1): Remove useless variable int i.
 371
 372 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 373
 374         * stack.c (print_frame_info): Fix comment.
 375
 376 2018-05-18  Tom Tromey  <tom@tromey.com>
 377
 378         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
 379         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
 380         (~dwarf2_per_objfile): Update
 381         (dwarf2_get_dwz_file): Use new.
 382         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
 383         unique_ptr.
 384
 385 2018-05-18  Tom Tromey  <tom@tromey.com>
 386
 387         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
 388         unique_ptr.
 389         * dwarf2read.c (struct dwp_file): Add constructor and
 390         initializers.
 391         (open_and_init_dwp_file): Return a unique_ptr.
 392         (dwarf2_per_objfile, create_dwp_hash_table)
 393         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
 394         (lookup_dwo_unit_in_dwp): Update.
 395         (open_and_init_dwp_file, get_dwp_file): Update.
 396
 397 2018-05-18  Tom Tromey  <tom@tromey.com>
 398
 399         * dwarf2read.c (dwarf2_per_objfile): Update.
 400         (struct mapped_index): Add initializers.
 401         (dwarf2_read_index): Use new.
 402         (dw2_symtab_iter_init): Update.
 403         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
 404         unique_ptr.
 405
 406 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
 407
 408         * dwarf2read.c (mapped_index) <total_size>: Remove.
 409
 410 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
 411
 412         * unittests/format_pieces-selftests.c (test_format_specifier):
 413         Add ARI comments.
 414
 415 2018-05-18  Tom Tromey  <tom@tromey.com>
 416
 417         * c-typeprint.c (maybe_print_hole): New function.
 418         (c_print_type_struct_field_offset): Update.
 419         (c_type_print_base_struct_union): Call maybe_print_hole.
 420
 421 2018-05-17  Keith Seitz  <keiths@redhat.com>
 422
 423         * breakpoint.c (build_bpstat_chain): New function, moved from
 424         bpstat_stop_status.
 425         (bpstat_stop_status): Add optional parameter, `stop_chain'.
 426         If no stop chain is passed, call build_bpstat_chain to build it.
 427         * breakpoint.h (build_bpstat_chain): Declare.
 428         (bpstat_stop_status): Move documentation here from breakpoint.c.
 429         * infrun.c (handle_signal_stop): Before eliding inlined frames,
 430         build the stop chain and pass it to skip_inline_frames.
 431         Pass this stop chain to bpstat_stop_status.
 432         * inline-frame.c: Include breakpoint.h.
 433         (stopped_by_user_bp_inline_frame): New function.
 434         (skip_inline_frames): Add parameter `stop_chain'.
 435         Move documention to inline-frame.h.
 436         If non-NULL, use stopped_by_user_bp_inline_frame to determine
 437         whether the frame should be elided.
 438         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
 439         Add moved documentation and update for new parameter.
 440
 441 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
 442
 443         PR cli/14975
 444         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 445         unittests/format_pieces-selftests.c.
 446         * common/format.h (format_piece) <operator==>: New.
 447         (format_pieces) <operator[]>: Remove.
 448         * common/format.c (format_pieces::format_pieces): Handle \e.
 449         * unittests/format_pieces-selftests.c: New.
 450
 451 2018-05-17  Tom Tromey  <tom@tromey.com>
 452
 453         PR symtab/23010:
 454         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
 455         (dw2_instantiate_symtab): Add skip_partial parameter.
 456         (dw2_find_last_source_symtab, dw2_map_expand_apply)
 457         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
 458         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
 459         (dw2_expand_symtabs_matching_one)
 460         (dw2_find_pc_sect_compunit_symtab)
 461         (dw2_debug_names_lookup_symbol)
 462         (dw2_debug_names_expand_symtabs_for_function): Update.
 463         (init_cutu_and_read_dies): Add skip_partial parameter.
 464         (process_psymtab_comp_unit, build_type_psymtabs_1)
 465         (process_skeletonless_type_unit, load_partial_comp_unit)
 466         (psymtab_to_symtab_1): Update.
 467         (load_full_comp_unit): Add skip_partial parameter.
 468         (process_imported_unit_die, dwarf2_read_addr_index)
 469         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
 470         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
 471         (read_signatured_type): Update.
 472
 473 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
 474
 475         * value.c (release_value): Remove unused variable.
 476         (record_latest_value): Likewise.
 477         (access_value_history): Likewise.
 478         (preserve_values): Likewise.
 479
 480 2018-05-17  Tom Tromey  <tom@tromey.com>
 481
 482         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
 483         Initialize.
 484
 485 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
 486
 487         PR gdb/22286
 488         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
 489         Also handle registers whose width is not a multiple of
 490         PTRACE_TYPE_RET.
 491         (linux_nat_trad_target::store_register): Likewise.
 492
 493 2018-05-16  Tom Tromey  <tom@tromey.com>
 494
 495         * gdbcore.h (core_bfd): Redefine.
 496         * corelow.c (core_target::close): Update.
 497         (core_target_open): Update.
 498         * progspace.h (struct program_space) <cbfd>: Now a
 499         gdb_bfd_ref_ptr.
 500
 501 2018-05-16  Tom Tromey  <tom@tromey.com>
 502
 503         PR cli/19551:
 504         * symfile-add-flags.h (enum symfile_add_flags)
 505         <SYMFILE_NOT_FILENAME>: New constant.
 506         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
 507         objfile name from BFD.
 508         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
 509         * minidebug.c (find_separate_debug_file_in_section): Put
 510         ".gnu_debugdata" into BFD's file name.
 511
 512 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
 513
 514         * regcache.c (regcache_read_ftype, regcache_write_ftype):
 515         Remove.
 516
 517 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
 518
 519         PR binutils/21446
 520         * aarch64-tdep.c (aarch64_analyze_prologue,
 521         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
 522         Indicate not interested in errors.
 523
 524 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
 525
 526         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
 527         Supply the MIPS_ZERO_REGNUM register.
 528
 529 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
 530
 531         * mips-tdep.c (mask_address_var): Make variable static.
 532
 533 2018-05-14  Tom Tromey  <tom@tromey.com>
 534
 535         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
 536
 537 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 538
 539         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
 540         FXSAVE_ADDR for the mxcsr register.
 541
 542 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
 543
 544         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
 545
 546 2018-05-11  Pedro Alves  <palves@redhat.com>
 547
 548         * corelow.c (core_target) <core_target>: No longer inline.
 549         Initialize m_core_gdbarch, m_core_vec and build the section table
 550         here.
 551         <~core_target>: New.
 552         <core_gdbarch, get_core_register_section>: New methods.
 553         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
 554         factored out from ...
 555         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
 556         (core_ops): Delete.
 557         (sniff_core_bfd): Add gdbarch parameter.
 558         (core_close): Delete, merged into ...
 559         (core_target::close): ... here.  Delete self.
 560         (core_close_cleanup): Delete.
 561         (core_target_open): Allocate a core_target on the heap.  Use a
 562         unique_ptr instead of a cleanup.  Bits moved into the core_target
 563         ctor.  Adjust to use core_target methods instead of globals.
 564         (get_core_register_section): Rename to ...
 565         (core_target::get_core_register_section): ... this and adjust.
 566         (struct get_core_registers_cb_data): New.
 567         (get_core_registers_cb): Use it.  Use bool.
 568         (core_target::fetch_registers, core_target::files_info)
 569         (core_target::xfer_partial, core_target::read_description)
 570         (core_target::pid_to, core_target::thread_name): Adjust to
 571         reference class fields instead of globals.
 572         * target.h (struct target_ops_deleter, target_ops_up): New.
 573
 574 2018-05-11  Pedro Alves  <palves@redhat.com>
 575
 576         * corefile.c (core_file_command): Move to corelow.c.
 577         * corelow.c (the_core_target): Delete.
 578         (core_file_command): Moved from corefile.c.  Check exec_bfd
 579         instead of the_core_target.  Use target_detach instead of calling
 580         into the_core_target directly.
 581         (maybe_say_no_core_file_now): New.
 582         (core_target::detach): Use it.
 583         (_initialize_corelow): Remove references to the_core_target.
 584         * gdbcore.h (the_core_target): Delete.
 585
 586 2018-05-11  Tom Tromey  <tromey@redhat.com>
 587             Pedro Alves  <palves@redhat.com>
 588
 589         * corefile.c (core_bfd): Remove.
 590         * gdbcore.h (core_bfd): Now a macro.
 591         * progspace.h (struct program_space) <cbfd>: New field.
 592
 593 2018-05-11  Tom Tromey  <tom@tromey.com>
 594
 595         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
 596         gdb::def_vector.
 597
 598 2018-05-10  Tom Tromey  <tom@tromey.com>
 599
 600         * configure: Rebuild.
 601         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
 602
 603 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
 604
 605         PR server/23158:
 606         * regformats/regdat.sh: Adjust script, following the addition
 607         of the new expedite_regs parameter to init_target_desc.
 608
 609 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
 610
 611         PR gdb/23127
 612         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
 613         set_gdbarch_significant_addr_bit.
 614         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
 615         set_gdbarch_significant_addr_bit.
 616         * utils.c (address_significant): Update to sign extend addr.
 617
 618 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
 619
 620         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
 621         (xtensa_linux_init_abi): Limit tdep->num_regs by
 622         tdep->num_nopriv_regs.
 623         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
 624         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
 625         not initialized.
 626
 627 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
 628
 629         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
 630
 631 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 632
 633         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
 634         (I387_MXCSR_INIT_VAL): New constant.
 635         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
 636         buffer if it was supplied by the inferior.
 637         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
 638         (i387_xsave_get_clear_bv): New function.
 639         (i387_supply_xsave): Only read x87 control registers from the
 640         xsave buffer if the feature is enabled, and the state will have
 641         been written, otherwise, provide a suitable default.
 642         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
 643         including x87 control registers.  Update control registers if they
 644         have changed from the default value, and mark features as enabled
 645         as required.
 646         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
 647
 648 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
 649
 650         * spu-tdep.c (info_spu_event_command): Fix output formatting.
 651
 652 2018-05-07  Tom Tromey  <tom@tromey.com>
 653
 654         * configure: Rebuild.
 655         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
 656
 657 2018-05-07  Tom Tromey  <tom@tromey.com>
 658
 659         PR tdep/20362:
 660         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
 661         bit.  Use correct value for VDIV.
 662
 663 2018-05-04  Tom Tromey  <tom@tromey.com>
 664
 665         * configure: Rebuild.
 666         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
 667
 668 2018-05-04  Tom Tromey  <tom@tromey.com>
 669
 670         * linux-record.c (record_linux_system_call) <case
 671         RECORD_SYS_RECVFROM>: Add "break".
 672
 673 2018-05-04  Tom Tromey  <tom@tromey.com>
 674
 675         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
 676         Add missing "break".
 677         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
 678         Add missing "break".
 679
 680 2018-05-04  Tom Tromey  <tom@tromey.com>
 681
 682         * rs6000-tdep.c (ppc_process_record_op4)
 683         (ppc_process_record_op63): Add fall-through comment.
 684
 685 2018-05-04  Tom Tromey  <tom@tromey.com>
 686
 687         * i386-tdep.c (i386_process_record): Add fall-through comment.
 688
 689 2018-05-04  Tom Tromey  <tom@tromey.com>
 690
 691         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
 692         comment.
 693
 694 2018-05-04  Tom Tromey  <tom@tromey.com>
 695
 696         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
 697         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
 698         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
 699         comment.
 700         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
 701         comment.
 702         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
 703         comment.
 704
 705 2018-05-04  Tom Tromey  <tom@tromey.com>
 706
 707         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
 708
 709 2018-05-04  Tom Tromey  <tom@tromey.com>
 710
 711         * s390-tdep.c (s390_process_record): Fix fall-through comments.
 712         * xcoffread.c (scan_xcoff_symtab): Move comment later.
 713         * symfile.c (section_is_mapped): Fix fall-through comment.
 714         * stabsread.c (define_symbol, read_member_functions): Fix
 715         fall-through comment.
 716         * s390-linux-tdep.c (s390_process_record): Fix fall-through
 717         comment.
 718         * remote.c (remote_wait_as): Fix fall-through comment.
 719         * p-exp.y (yylex): Fix fall-through comment.
 720         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
 721         comment.
 722         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
 723         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
 724         * jv-exp.y (yylex): Fix fall-through comment.
 725         * go-exp.y (lex_one_token): Fix fall-through comment.
 726         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
 727         fall-through comment.
 728         * f-exp.y (yylex): Fix fall-through comment.
 729         * dwarf2read.c (process_die): Fix fall-through comments.
 730         * dbxread.c (process_one_symbol): Fix fall-through comment.
 731         * d-exp.y (lex_one_token): Fix fall-through comment.
 732         * cp-name-parser.y (yylex): Fix fall-through comment.
 733         * coffread.c (coff_symtab_read): Fix fall-through comment.
 734         * c-exp.y (lex_one_token): Fix fall-through comment.
 735         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
 736         comment.
 737         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
 738         comment.
 739
 740 2018-05-04  Tom Tromey  <tom@tromey.com>
 741
 742         PR python/22730:
 743         * NEWS: Mention gdb.execute change.
 744         * gdbcmd.h (execute_control_command): Don't declare.
 745         * python/python.c (execute_gdb_command): Use read_command_lines_1,
 746         execute_control_commands, execute_control_commands_to_string.
 747         * cli/cli-script.h (execute_control_commands)
 748         (execute_control_commands_to_string): Declare.
 749         (execute_control_command): Add from_tty parameter.
 750         * cli/cli-script.c (execute_control_commands)
 751         (execute_control_commands_to_string): New functions.
 752         (execute_user_command): Use execute_control_commands.
 753         (execute_control_command_1): Add "from_tty" parameter.  Update.
 754         (execute_control_command): Likewise.
 755
 756 2018-05-04  Tom Tromey  <tom@tromey.com>
 757
 758         PR python/22731:
 759         * NEWS: Mention that breakpoint commands are writable.
 760         * python/py-breakpoint.c (bppy_set_commands): New function.
 761         (breakpoint_object_getset) <"commands">: Use it.
 762
 763 2018-05-04  Tom Tromey  <tom@tromey.com>
 764
 765         * tracepoint.c (actions_command): Update.
 766         * mi/mi-cmd-break.c (mi_command_line_array)
 767         (mi_command_line_array_cnt, mi_command_line_array_ptr)
 768         (mi_read_next_line): Remove.
 769         (mi_cmd_break_commands): Update.
 770         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
 771         function_view.
 772         * cli/cli-script.c (get_command_line): Update.
 773         (process_next_line): Use function_view.  Constify.
 774         (recurse_read_control_structure, read_command_lines)
 775         (read_command_lines_1): Change argument types to function_view.
 776         (do_define_command, document_command): Update.
 777         * breakpoint.h (check_tracepoint_command): Don't declare.
 778         * breakpoint.c (check_tracepoint_command): Remove.
 779         (commands_command_1, create_tracepoint_from_upload): Update.
 780
 781 2018-05-04  Tom Tromey  <tom@tromey.com>
 782
 783         PR gdb/11750:
 784         * cli/cli-script.h (enum command_control_type) <define_control>:
 785         New constant.
 786         * cli/cli-script.c (multi_line_command_p): Handle define_control.
 787         (build_command_line, execute_control_command_1)
 788         (process_next_line): Likewise.
 789         (do_define_command): New function, extracted from define_command.
 790         (define_command): Use it.
 791
 792 2018-05-04  Tom Tromey  <tom@tromey.com>
 793
 794         * tracepoint.c (actions_command): Update.
 795         * cli/cli-script.h (read_command_lines): Update.
 796         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
 797         (MAX_TMPBUF): Remove define.
 798         (define_command): Use string_printf.
 799         (document_command): Likewise.
 800         * breakpoint.c (commands_command_1): Update.
 801
 802 2018-05-04  Tom Tromey  <tom@tromey.com>
 803
 804         * top.c (execute_command): Update.
 805         * cli/cli-script.h (print_command_lines): Now varargs.
 806         * cli/cli-script.c (print_command_lines): Now varargs.
 807         (execute_control_command_1) <case while_control, case if_control>:
 808         Update.
 809
 810 2018-05-04  Tom Tromey  <tom@tromey.com>
 811
 812         * tracepoint.c (all_tracepoint_actions): Rename from
 813         all_tracepoint_actions_and_cleanup.  Change return type.
 814         (actions_command, encode_actions_1, encode_actions)
 815         (trace_dump_actions, tdump_command): Update.
 816         * remote.c (remote_download_command_source): Update.
 817         * python/python.c (gdbpy_eval_from_control_command)
 818         (python_command, python_interactive_command): Update.
 819         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
 820         * guile/guile.c (guile_command)
 821         (gdbscm_eval_from_control_command, guile_command): Update.
 822         * compile/compile.c (compile_code_command)
 823         (compile_print_command, compile_to_object): Update.
 824         * cli/cli-script.h (struct command_lines_deleter): New.
 825         (counted_command_line): New typedef.
 826         (struct command_line): Add constructor, destructor.
 827         <body_list>: Remove.
 828         <body_list_0, body_list_1>: New members.
 829         (command_line_up): Remove typedef.
 830         (read_command_lines, read_command_lines_1, get_command_line):
 831         Update.
 832         (copy_command_lines): Don't declare.
 833         * cli/cli-script.c (build_command_line): Use "new".
 834         (get_command_line): Return counted_command_line.
 835         (print_command_lines, execute_user_command)
 836         (execute_control_command_1, while_command, if_command): Update.
 837         (realloc_body_list): Remove.
 838         (process_next_line, recurse_read_control_structure): Update.
 839         (read_command_lines, read_command_lines_1): Return counted_command_line.
 840         (free_command_lines): Use "delete".
 841         (copy_command_lines): Remove.
 842         (define_command, document_command, show_user_1): Update.
 843         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
 844         a counted_command_line.
 845         * breakpoint.h (counted_command_line): Remove typedef.
 846         (breakpoint_set_commands): Update.
 847         * breakpoint.c (check_no_tracepoint_commands)
 848         (validate_commands_for_breakpoint): Update.
 849         (breakpoint_set_commands): Change commands to be a
 850         counted_command_line.
 851         (commands_command_1, update_dprintf_command_list)
 852         (create_tracepoint_from_upload): Update.
 853
 854 2018-05-04  Tom Tromey  <tom@tromey.com>
 855
 856         * cli/cli-decode.h (cmd_list_element): New constructor.
 857         (~cmd_list_element): New destructor.
 858         (struct cmd_list_element): Add initializers.
 859         * cli/cli-decode.c (do_add_cmd): Use "new".
 860         (delete_cmd): Use "delete".
 861
 862 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
 863             Pedro Alves <palves@redhat.com>
 864
 865         PR breakpoints/19806 and support for PR external/20207.
 866         * NEWS: Mention Aarch64 watchpoint improvements.
 867         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
 868         watchpoints and PR external/20207 watchpoints.
 869         * nat/aarch64-linux-hw-point.c
 870         (kernel_supports_any_contiguous_range): New.
 871         (aarch64_watchpoint_offset): New.
 872         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
 873         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
 874         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
 875         (aarch64_align_watchpoint): New parameters aligned_offset_p and
 876         next_addr_orig_p.  Support PR external/20207 watchpoints.
 877         (aarch64_downgrade_regs): New.
 878         (aarch64_dr_state_insert_one_point): New parameters offset and
 879         addr_orig.
 880         (aarch64_dr_state_remove_one_point): Likewise.
 881         (aarch64_handle_breakpoint): Update caller.
 882         (aarch64_handle_aligned_watchpoint): Likewise.
 883         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
 884         aligned_offset.
 885         (aarch64_linux_set_debug_regs): Remove const from state.  Call
 886         aarch64_downgrade_regs.
 887         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
 888         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
 889         (DR_CONTROL_MASK): ... this.
 890         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
 891         (unsigned int aarch64_watchpoint_offset): New prototype.
 892         (aarch64_linux_set_debug_regs): Remove const from state.
 893         * utils.c (align_up, align_down): Move to ...
 894         * common/common-utils.c (align_up, align_down): ... here.
 895         * utils.h (align_up, align_down): Move to ...
 896         * common/common-utils.h (align_up, align_down): ... here.
 897
 898 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
 899
 900         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
 901         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
 902         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
 903         Re-implement to match the ABI as summarized in GCC's
 904         gcc/config/sparc/sparc.c.  All callers updated.
 905         (sparc32_store_arguments): Remove assertion.
 906
 907 2018-05-04  Tom Tromey  <tom@tromey.com>
 908
 909         * printcmd.c: Don't include tui.h.
 910         (decode_format): Use skip_spaces.
 911
 912 2018-05-04  Tom Tromey  <tom@tromey.com>
 913
 914         PR gdb/22619:
 915         * printcmd.c (last_count): New global.
 916         (x_command): Use saved count when repeating.
 917
 918 2018-05-04  Tom Tromey  <tom@tromey.com>
 919
 920         * nto-procfs.c (do_closedir_cleanup): Remove.
 921         (procfs_pidlist): Use gdb_dir_up.
 922         * procfs.c (do_closedir_cleanup): Remove.
 923         (proc_update_threads): Use gdb_dir_up.
 924         * common/filestuff.h (struct gdb_dir_deleter): New.
 925         (gdb_dir_up): New typedef.
 926
 927 2018-05-04  Tom Tromey  <tom@tromey.com>
 928
 929         * ada-lang.c (print_mention_exception): Use std::string.
 930
 931 2018-05-04  Tom Tromey  <tom@tromey.com>
 932
 933         * ada-lang.c (create_excep_cond_exprs): Update.
 934         (ada_exception_catchpoint_cond_string): Use std::string.
 935
 936 2018-05-04  Tom Tromey  <tom@tromey.com>
 937
 938         * ada-lang.c (xget_renaming_scope): Return std::string.
 939         (old_renaming_is_invisible): Update.
 940
 941 2018-05-04  Tom Tromey  <tom@tromey.com>
 942
 943         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
 944         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
 945
 946 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
 947
 948         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
 949
 950 2018-05-04  Tom Tromey  <tom@tromey.com>
 951
 952         * remote.c (remote_query_supported_append): Change type.
 953         (remote_check_symbols): Update.
 954
 955 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
 956
 957         PR gdb/11420
 958         * configure.ac: Prepend libpython.
 959         * python/python-config.py: Likewise.
 960         * configure: Regenerate.
 961
 962 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
 963
 964         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
 965
 966 2018-05-03  Pedro Alves  <palves@redhat.com>
 967
 968         * s390-linux-nat.c
 969         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
 970         override.  Write 'true' instead of '1'.
 971         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
 972         declaration.
 973
 974 2018-05-02  Pedro Alves  <palves@redhat.com>
 975
 976         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
 977         add_inf_child_target.
 978         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
 979         add_inf_child_target.
 980         * aix-thread.c (aix_thread_target_info): New.
 981         (aix_thread_target) <shortname, longname, doc>: Delete.
 982         <info>: New.
 983         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
 984         add_inf_child_target.
 985         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
 986         add_inf_child_target.
 987         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
 988         add_inf_child_target.
 989         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
 990         add_inf_child_target.
 991         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
 992         add_inf_child_target.
 993         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
 994         add_inf_child_target.
 995         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
 996         add_inf_child_target.
 997         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
 998         add_inf_child_target.
 999         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
1000         add_inf_child_target.
1001         * bfd-target.c (target_bfd_target_info): New.
1002         (target_bfd) <shortname, longname, doc>: Delete.
1003         <info>: New.
1004         * bsd-kvm.c (bsd_kvm_target_info): New.
1005         (bsd_kvm_target) <shortname, longname, doc>: Delete.
1006         <info>: New.
1007         (bsd_kvm_target::open): Rename to ...
1008         (bsd_kvm_target_open): ... this.  Adjust.
1009         * bsd-uthread.c (bsd_uthread_target_info): New.
1010         (bsd_uthread_target) <shortname, longname, doc>: Delete.
1011         <info>: New.
1012         * corefile.c (core_file_command): Adjust.
1013         * corelow.c (core_target_info): New.
1014         (core_target) <shortname, longname, doc>: Delete.
1015         <info>: New.
1016         (core_target::open): Rename to ...
1017         (core_target_open): ... this.  Adjust.
1018         * ctf.c (ctf_target_info): New.
1019         (ctf_target) <shortname, longname, doc>: Delete.
1020         <info>: New.
1021         (ctf_target::open): Rename to ...
1022         (ctf_target_open): ... this.
1023         (_initialize_ctf): Adjust.
1024         * exec.c (exec_target_info): New.
1025         (exec_target) <shortname, longname, doc>: Delete.
1026         <info>: New.
1027         (exec_target::open): Rename to ...
1028         (exec_target_open): ... this.
1029         * gdbcore.h (core_target_open): Declare.
1030         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
1031         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
1032         add_inf_child_target.
1033         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
1034         add_inf_child_target.
1035         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
1036         add_inf_child_target.
1037         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
1038         add_inf_child_target.
1039         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
1040         add_inf_child_target.
1041         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
1042         add_inf_child_target.
1043         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
1044         add_inf_child_target.
1045         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
1046         add_inf_child_target.
1047         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
1048         add_inf_child_target.
1049         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
1050         add_inf_child_target.
1051         * inf-child.c (inf_child_target_info): New.
1052         (inf_child_target::info): New.
1053         (inf_child_open_target): Remove 'target' parameter.  Use
1054         get_native_target instead.
1055         (inf_child_target::open): Delete.
1056         (add_inf_child_target): New.
1057         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
1058         Delete.
1059         <info>: New.
1060         (add_inf_child_target): Declare.
1061         (inf_child_open_target): Declare.
1062         * linux-thread-db.c (thread_db_target_info): New.
1063         (thread_db_target) <shortname, longname, doc>: Delete.
1064         <info>: New.
1065         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
1066         add_inf_child_target.
1067         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
1068         add_inf_child_target.
1069         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
1070         add_inf_child_target.
1071         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
1072         add_inf_child_target.
1073         * make-target-delegates (print_class): Adjust.
1074         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
1075         add_inf_child_target.
1076         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
1077         add_inf_child_target.
1078         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
1079         add_inf_child_target.
1080         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
1081         add_inf_child_target.
1082         * nto-procfs.c (nto_native_target_info): New.
1083         (nto_procfs_target_native) <shortname, longname, doc>:
1084         Delete.
1085         <info>: New.
1086         (nto_procfs_target_info): New.
1087         (nto_procfs_target_procfs) <shortname, longname, doc>:
1088         Delete.
1089         <info>: New.
1090         (init_procfs_targets): Adjust.
1091         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
1092         add_inf_child_target.
1093         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
1094         add_inf_child_target.
1095         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
1096         add_inf_child_target.
1097         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
1098         add_inf_child_target.
1099         * ravenscar-thread.c (ravenscar_target_info): New.
1100         (ravenscar_thread_target) <shortname, longname, doc>:
1101         Delete.
1102         <info>: New.
1103         * record-btrace.c (record_btrace_target_info):
1104         (record_btrace_target) <shortname, longname, doc>: Delete.
1105         <info>: New.
1106         (record_btrace_target::open): Rename to ...
1107         (record_btrace_target_open): ... this.  Adjust.
1108         * record-full.c (record_longname, record_doc): New.
1109         (record_full_base_target) <shortname, longname, doc>: Delete.
1110         <info>: New.
1111         (record_full_target_info): New.
1112         (record_full_target): <shortname>: Delete.
1113         <info>: New.
1114         (record_full_core_open_1, record_full_open_1): Update comments.
1115         (record_full_base_target::open): Rename to ...
1116         (record_full_open): ... this.
1117         (cmd_record_full_restore): Update.
1118         (_initialize_record_full): Update.
1119         * remote-sim.c (remote_sim_target_info): New.
1120         (gdbsim_target) <shortname, longname, doc>: Delete.
1121         <info>: New.
1122         (gdbsim_target::open): Rename to ...
1123         (gdbsim_target_open): ... this.
1124         (_initialize_remote_sim): Adjust.
1125         * remote.c (remote_doc): New.
1126         (remote_target_info): New.
1127         (remote_target) <shortname, longname, doc>: Delete.
1128         <info>: New.
1129         (extended_remote_target_info): New.
1130         (extended_remote_target) <shortname, longname, doc>: Delete.
1131         <info>: New.
1132         (remote_target::open_1): Make static.  Adjust.
1133         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
1134         * s390-linux-nat.c (_initialize_s390_nat): Use
1135         add_inf_child_target.
1136         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
1137         add_inf_child_target.
1138         * sol-thread.c (thread_db_target_info): New.
1139         (sol_thread_target) <shortname, longname, doc>: Delete.
1140         <info>: New.
1141         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
1142         add_inf_child_target.
1143         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
1144         add_inf_child_target.
1145         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
1146         add_inf_child_target.
1147         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
1148         add_inf_child_target.
1149         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
1150         add_inf_child_target.
1151         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
1152         add_inf_child_target.
1153         * spu-linux-nat.c (_initialize_spu_nat): Use
1154         add_inf_child_target.
1155         * spu-multiarch.c (spu_multiarch_target_info): New.
1156         (spu_multiarch_target) <shortname, longname, doc>: Delete.
1157         <info>: New.
1158         * target-delegates.c: Regenerate.
1159         * target.c: Include <unordered_map>.
1160         (target_ops_p): Delete.
1161         (DEF_VEC_P(target_ops_p)): Delete.
1162         (target_factories): New.
1163         (test_target_info): New.
1164         (test_target_ops::info): New.
1165         (open_target): Adjust to use target_factories.
1166         (add_target_with_completer): Rename to ...
1167         (add_target): ... this.  Change prototype.  Register target_info
1168         and open callback in target_factories.  Register target_info in
1169         command context instead of target_ops.
1170         (add_target): Delete old implementation.
1171         (add_deprecated_target_alias): Change prototype.  Adjust.
1172         (the_native_target): New.
1173         (set_native_target, get_native_target): New.
1174         (find_default_run_target): Use the_native_target.
1175         (find_attach_target, find_run_target): Simplify.
1176         (target_ops::open): Delete.
1177         (dummy_target_info): New.
1178         (dummy_target::shortname, dummy_target::longname)
1179         (dummy_target::doc): Delete.
1180         (dummy_target::info): New.
1181         (debug_target::shortname, debug_target::longname)
1182         (debug_target::doc): Delete.
1183         (debug_target::info): New.
1184         * target.h (struct target_info): New.
1185         (target_ops::~target_ops): Add comment.
1186         (target_ops::info): New.
1187         (target_ops::shortname, target_ops::longname, target_ops::doc): No
1188         longer virtual.  Implement in terms of target_info.
1189         (set_native_target, get_native_target): Declare.
1190         (target_open_ftype): New.
1191         (add_target, add_target_with_completer)
1192         (add_deprecated_target_alias): Change prototype.
1193         (test_target) <shortname, longname, doc>: Delete.
1194         <info>: New.
1195         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
1196         add_inf_child_target.
1197         * tracefile-tfile.c (tfile_target_info): New.
1198         (tfile_target) <shortname, longname, doc>: Delete.
1199         <info>: New.
1200         (tfile_target::open): Rename to ...
1201         (tfile_target_open): ... this.
1202         (_initialize_tracefile_tfile): Adjust.
1203         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
1204         add_inf_child_target.
1205         * windows-nat.c (_initialize_windows_nat): Use
1206         add_inf_child_target.
1207         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
1208         add_inf_child_target.
1209
1210 2018-05-02  Pedro Alves  <palves@redhat.com>
1211
1212         * linux-nat.h (linux_nat_target) <low_new_thread,
1213         low_delete_thread, low_new_fork, low_forget_process,
1214         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
1215         New virtual methods.
1216         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1217         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
1218         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
1219         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1220         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
1221         Delete.
1222         * linux-fork.c (delete_fork): Adjust to call low method.
1223         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
1224         (linux_nat_new_fork, linux_nat_forget_process_hook)
1225         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
1226         (linux_nat_status_is_event):
1227         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
1228         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
1229         to call low method.
1230         (sigtrap_is_event): Rename to ...
1231         (linux_nat_target::low_status_is_event): ... this.
1232         (linux_nat_set_status_is_event): Delete.
1233         (save_stop_reason, linux_nat_wait_1)
1234         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
1235         low methods.
1236         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1237         (linux_nat_set_new_fork, linux_nat_set_forget_process)
1238         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1239         (linux_nat_set_prepare_to_resume): Delete.
1240         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
1241         low virtual methods.
1242         * amd64-linux-nat.c: Likewise.
1243         * arm-linux-nat.c: Likewise.
1244         * i386-linux-nat.c: Likewise.
1245         * ia64-linux-nat.c: Likewise.
1246         * mips-linux-nat.c: Likewise.
1247         * ppc-linux-nat.c: Likewise.
1248         * s390-linux-nat.c: Likewise.
1249         * sparc64-linux-nat.c: Likewise.
1250         * x86-linux-nat.c: Likewise.
1251         * x86-linux-nat.h: Include "nat/x86-linux.h".
1252         (x86_linux_nat_target) <low_new_fork, low_forget_process,
1253         low_prepare_to_resume, low_new_thread, low_delete_thread>:
1254         Override methods.
1255
1256 2018-05-02  Pedro Alves  <palves@redhat.com>
1257
1258         * target.h (target_ops)
1259         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
1260         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
1261         stopped_by_watchpoint, have_continuable_watchpoint,
1262         stopped_data_address, watchpoint_addr_within_range,
1263         can_accel_watchpoint_condition, can_run, thread_alive,
1264         has_all_memory, has_memory, has_stack, has_registers,
1265         has_execution, can_async_p, is_async_p, supports_non_stop,
1266         always_non_stop_p, can_execute_reverse, supports_multi_process,
1267         supports_enable_disable_tracepoint,
1268         supports_disable_randomization, supports_string_tracing,
1269         supports_evaluation_of_breakpoint_conditions,
1270         can_run_breakpoint_commands, filesystem_is_local,
1271         can_download_tracepoint, get_trace_state_variable_value,
1272         set_trace_notes, get_tib_address, use_agent, can_use_agent,
1273         record_is_replaying, record_will_replay,
1274         augmented_libraries_svr4_read>: Adjust to return bool.
1275         * aarch64-linux-nat.c: All implementations adjusted.
1276         * aix-thread.c: All implementations adjusted.
1277         * arm-linux-nat.c: All implementations adjusted.
1278         * breakpoint.c: All implementations adjusted.
1279         * bsd-kvm.c: All implementations adjusted.
1280         * bsd-uthread.c: All implementations adjusted.
1281         * corelow.c: All implementations adjusted.
1282         * ctf.c: All implementations adjusted.
1283         * darwin-nat.c: All implementations adjusted.
1284         * darwin-nat.h: All implementations adjusted.
1285         * exec.c: All implementations adjusted.
1286         * fbsd-nat.c: All implementations adjusted.
1287         * fbsd-nat.h: All implementations adjusted.
1288         * gnu-nat.c: All implementations adjusted.
1289         * gnu-nat.h: All implementations adjusted.
1290         * go32-nat.c: All implementations adjusted.
1291         * ia64-linux-nat.c: All implementations adjusted.
1292         * inf-child.c: All implementations adjusted.
1293         * inf-child.h: All implementations adjusted.
1294         * inf-ptrace.c: All implementations adjusted.
1295         * inf-ptrace.h: All implementations adjusted.
1296         * linux-nat.c: All implementations adjusted.
1297         * linux-nat.h: All implementations adjusted.
1298         * mips-linux-nat.c: All implementations adjusted.
1299         * nto-procfs.c: All implementations adjusted.
1300         * ppc-linux-nat.c: All implementations adjusted.
1301         * procfs.c: All implementations adjusted.
1302         * ravenscar-thread.c: All implementations adjusted.
1303         * record-btrace.c: All implementations adjusted.
1304         * record-full.c: All implementations adjusted.
1305         * remote-sim.c: All implementations adjusted.
1306         * remote.c: All implementations adjusted.
1307         * s390-linux-nat.c: All implementations adjusted.
1308         * sol-thread.c: All implementations adjusted.
1309         * spu-multiarch.c: All implementations adjusted.
1310         * target-delegates.c: All implementations adjusted.
1311         * target.c: All implementations adjusted.
1312         * target.h: All implementations adjusted.
1313         * tracefile-tfile.c: All implementations adjusted.
1314         * tracefile.c: All implementations adjusted.
1315         * tracefile.h: All implementations adjusted.
1316         * windows-nat.c: All implementations adjusted.
1317         * x86-linux-nat.h: All implementations adjusted.
1318         * x86-nat.h: All implementations adjusted.
1319
1320 2018-05-02  Pedro Alves  <palves@redhat.com>
1321
1322         * make-target-delegates (scan_target_h): Don't trim lines here.
1323         Replace sequences of tabs and/or whitespace with a single
1324         whitespace.
1325         (top level, parsing methods): Trim each line before processing it
1326         here.
1327
1328 2018-05-02  Pedro Alves  <palves@redhat.com>
1329             John Baldwin  <jhb@freebsd.org>
1330
1331         * target.h (enum strata) <debug_stratum>: New.
1332         (struct target_ops) <all delegation methods>: Replace by C++
1333         virtual methods, and drop "to_" prefix.  All references updated
1334         throughout.
1335         <to_shortname, to_longname, to_doc, to_data,
1336         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
1337         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
1338         virtual methods.  All references updated throughout.
1339         <can_attach, supports_terminal_ours, can_create_inferior,
1340         get_thread_control_capabilities, attach_no_wait>: New
1341         virtual methods.
1342         <insert_breakpoint, remove_breakpoint>: Now
1343         TARGET_DEFAULT_NORETURN methods.
1344         <info_proc>: Now returns bool.
1345         <to_magic>: Delete.
1346         (OPS_MAGIC): Delete.
1347         (current_target): Delete.  All references replaced by references
1348         to ...
1349         (target_stack): ... this.  New.
1350         (target_shortname, target_longname): Adjust.
1351         (target_can_run): Now a function declaration.
1352         (default_child_has_all_memory, default_child_has_memory)
1353         (default_child_has_stack, default_child_has_registers)
1354         (default_child_has_execution): Remove target_ops parameter.
1355         (complete_target_initialization): Delete.
1356         (memory_breakpoint_target): New template class.
1357         (test_target_ops): Refactor as a C++ class with virtual methods.
1358         * make-target-delegates (NAME_PART): Tighten.
1359         (POINTER_PART, CP_SYMBOL): New.
1360         (SIMPLE_RETURN_PART): Reimplement.
1361         (VEC_RETURN_PART): Expect less.
1362         (RETURN_PART, VIRTUAL_PART): New.
1363         (METHOD): Adjust to C++ virtual methods.
1364         (scan_target_h): Remove reference to C99.
1365         (dname): Output "target_ops::" prefix.
1366         (write_function_header): Adjust to output a C++ class method.
1367         (write_declaration): New.
1368         (write_delegator): Adjust to output a C++ class method.
1369         (tdname): Output "dummy_target::" prefix.
1370         (write_tdefault, write_debugmethod): Adjust to output a C++ class
1371         method.
1372         (tdefault_names, debug_names): Delete.
1373         (return_types, tdefaults, styles, argtypes_array): New.
1374         (top level): All methods are delegators.
1375         (print_class): New.
1376         (top level): Print dummy_target and debug_target classes.
1377         * target-delegates.c: Regenerate.
1378         * target-debug.h (target_debug_print_enum_info_proc_what)
1379         (target_debug_print_thread_control_capabilities)
1380         (target_debug_print_thread_info_p): New.
1381         * target.c (dummy_target): Delete.
1382         (the_dummy_target, the_debug_target): New.
1383         (target_stack): Now extern.
1384         (set_targetdebug): Push/unpush debug target.
1385         (default_child_has_all_memory, default_child_has_memory)
1386         (default_child_has_stack, default_child_has_registers)
1387         (default_child_has_execution): Remove target_ops parameter.
1388         (complete_target_initialization): Delete.
1389         (add_target_with_completer): No longer call
1390         complete_target_initialization.
1391         (target_supports_terminal_ours): Use regular delegation.
1392         (update_current_target): Delete.
1393         (push_target): No longer check magic number.  Don't call
1394         update_current_target.
1395         (unpush_target): Don't call update_current_target.
1396         (target_is_pushed): No longer check magic number.
1397         (target_require_runnable): Skip for all stratums over
1398         process_stratum.
1399         (target_ops::info_proc): New.
1400         (target_info_proc): Use find_target_at and
1401         find_default_run_target.
1402         (target_supports_disable_randomization): Use regular delegation.
1403         (target_get_osdata): Use find_target_at.
1404         (target_ops::open, target_ops::close, target_ops::can_attach)
1405         (target_ops::attach, target_ops::can_create_inferior)
1406         (target_ops::create_inferior, target_ops::can_run)
1407         (target_can_run): New.
1408         (default_fileio_target): Use regular delegation.
1409         (target_ops::fileio_open, target_ops::fileio_pwrite)
1410         (target_ops::fileio_pread, target_ops::fileio_fstat)
1411         (target_ops::fileio_close, target_ops::fileio_unlink)
1412         (target_ops::fileio_readlink): New.
1413         (target_fileio_open_1, target_fileio_unlink)
1414         (target_fileio_readlink): Always call the target method.  Handle
1415         FILEIO_ENOSYS.
1416         (return_zero, return_zero_has_execution): Delete.
1417         (init_dummy_target): Delete.
1418         (dummy_target::dummy_target, dummy_target::shortname)
1419         (dummy_target::longname, dummy_target::doc)
1420         (debug_target::debug_target, debug_target::shortname)
1421         (debug_target::longname, debug_target::doc): New.
1422         (target_supports_delete_record): Use regular delegation.
1423         (setup_target_debug): Delete.
1424         (maintenance_print_target_stack): Skip debug_stratum.
1425         (initialize_targets): Instantiate the_dummy_target and
1426         the_debug_target.
1427         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
1428         use target_stack.
1429         (target_auxv_search, fprint_target_auxv): Adjust.
1430         (info_auxv_command): Adjust to use target_stack.
1431         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
1432         * exceptions.c (print_flush): Handle a NULL target_stack.
1433         * regcache.c (target_ops_no_register): Refactor as class with
1434         virtual methods.
1435
1436         * exec.c (exec_target): New class.
1437         (exec_ops): Now an exec_target.
1438         (exec_open, exec_close_1, exec_get_section_table)
1439         (exec_xfer_partial, exec_files_info, exec_has_memory)
1440         (exec_make_note_section): Refactor as exec_target methods.
1441         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
1442         Delete.
1443         (exec_target::find_memory_regions): New.
1444         (_initialize_exec): Don't call init_exec_ops.
1445         * gdbcore.h (exec_file_clear): Delete.
1446
1447         * corefile.c (core_target): Delete.
1448         (core_file_command): Adjust.
1449         * corelow.c (core_target): New class.
1450         (the_core_target): New.
1451         (core_close): Remove target_ops parameter.
1452         (core_close_cleanup): Adjust.
1453         (core_target::close): New.
1454         (core_open, core_detach, get_core_registers, core_files_info)
1455         (core_xfer_partial, core_thread_alive, core_read_description)
1456         (core_pid_to_str, core_thread_name, core_has_memory)
1457         (core_has_stack, core_has_registers, core_info_proc): Rework as
1458         core_target methods.
1459         (ignore, core_remove_breakpoint, init_core_ops): Delete.
1460         (_initialize_corelow): Initialize the_core_target.
1461         * gdbcore.h (core_target): Delete.
1462         (the_core_target): New.
1463
1464         * ctf.c: (ctf_target): New class.
1465         (ctf_ops): Now a ctf_target.
1466         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
1467         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
1468         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
1469         methods.
1470         (init_ctf_ops): Delete.
1471         (_initialize_ctf): Don't call it.
1472         * tracefile-tfile.c (tfile_target): New class.
1473         (tfile_ops): Now a tfile_target.
1474         (tfile_open, tfile_close, tfile_files_info)
1475         (tfile_get_tracepoint_status, tfile_trace_find)
1476         (tfile_fetch_registers, tfile_xfer_partial)
1477         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
1478         Refactor as tfile_target methods.
1479         (tfile_xfer_partial_features): Remove target_ops parameter.
1480         (init_tfile_ops): Delete.
1481         (_initialize_tracefile_tfile): Don't call it.
1482         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
1483         (tracefile_has_stack, tracefile_has_registers)
1484         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
1485         tracefile_target methods.
1486         (init_tracefile_ops): Delete.
1487         (tracefile_target::tracefile_target): New.
1488         * tracefile.h: Include "target.h".
1489         (tracefile_target): New class.
1490         (init_tracefile_ops): Delete.
1491
1492         * spu-multiarch.c (spu_multiarch_target): New class.
1493         (spu_ops): Now a spu_multiarch_target.
1494         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
1495         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
1496         (spu_search_memory, spu_mourn_inferior): Refactor as
1497         spu_multiarch_target methods.
1498         (init_spu_ops): Delete.
1499         (_initialize_spu_multiarch): Remove references to init_spu_ops,
1500         complete_target_initialization.
1501
1502         * ravenscar-thread.c (ravenscar_thread_target): New class.
1503         (ravenscar_ops): Now a ravenscar_thread_target.
1504         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
1505         (ravenscar_thread_alive, ravenscar_pid_to_str)
1506         (ravenscar_fetch_registers, ravenscar_store_registers)
1507         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
1508         (ravenscar_stopped_by_hw_breakpoint)
1509         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
1510         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
1511         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
1512         methods.
1513         (init_ravenscar_thread_ops): Delete.
1514         (_initialize_ravenscar): Remove references to
1515         init_ravenscar_thread_ops and complete_target_initialization.
1516
1517         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
1518         (bsd_uthread_target): New class.
1519         (bsd_uthread_ops): Now a bsd_uthread_target.
1520         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
1521         (bsd_uthread_close, bsd_uthread_mourn_inferior)
1522         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
1523         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
1524         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
1525         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
1526         (bsd_uthread_target): Delete function.
1527         (_initialize_bsd_uthread): Remove reference to
1528         complete_target_initialization.
1529
1530         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
1531         (target_bfd): ... this new class.
1532         (target_bfd_xfer_partial, target_bfd_get_section_table)
1533         (target_bfd_close): Refactor as target_bfd methods.
1534         (target_bfd::~target_bfd): New.
1535         (target_bfd_reopen): Adjust.
1536         (target_bfd::close): New.
1537
1538         * record-btrace.c (record_btrace_target): New class.
1539         (record_btrace_ops): Now a record_btrace_target.
1540         (record_btrace_open, record_btrace_stop_recording)
1541         (record_btrace_disconnect, record_btrace_close)
1542         (record_btrace_async, record_btrace_info)
1543         (record_btrace_insn_history, record_btrace_insn_history_range)
1544         (record_btrace_insn_history_from, record_btrace_call_history)
1545         (record_btrace_call_history_range)
1546         (record_btrace_call_history_from, record_btrace_record_method)
1547         (record_btrace_is_replaying, record_btrace_will_replay)
1548         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
1549         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
1550         (record_btrace_store_registers, record_btrace_prepare_to_store)
1551         (record_btrace_to_get_unwinder)
1552         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
1553         (record_btrace_commit_resume, record_btrace_wait)
1554         (record_btrace_stop, record_btrace_can_execute_reverse)
1555         (record_btrace_stopped_by_sw_breakpoint)
1556         (record_btrace_supports_stopped_by_sw_breakpoint)
1557         (record_btrace_stopped_by_hw_breakpoint)
1558         (record_btrace_supports_stopped_by_hw_breakpoint)
1559         (record_btrace_update_thread_list, record_btrace_thread_alive)
1560         (record_btrace_goto_begin, record_btrace_goto_end)
1561         (record_btrace_goto, record_btrace_stop_replaying_all)
1562         (record_btrace_execution_direction)
1563         (record_btrace_prepare_to_generate_core)
1564         (record_btrace_done_generating_core): Refactor as
1565         record_btrace_target methods.
1566         (init_record_btrace_ops): Delete.
1567         (_initialize_record_btrace): Remove reference to
1568         init_record_btrace_ops.
1569         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
1570         the execution_direction global.
1571         (record_full_base_target, record_full_target)
1572         (record_full_core_target): New classes.
1573         (record_full_ops): Now a record_full_target.
1574         (record_full_core_ops): Now a record_full_core_target.
1575         (record_full_target::detach, record_full_target::disconnect)
1576         (record_full_core_target::disconnect)
1577         (record_full_target::mourn_inferior, record_full_target::kill):
1578         New.
1579         (record_full_open, record_full_close, record_full_async): Refactor
1580         as methods of the record_full_base_target class.
1581         (record_full_resume, record_full_commit_resume): Refactor
1582         as methods of the record_full_target class.
1583         (record_full_wait, record_full_stopped_by_watchpoint)
1584         (record_full_stopped_data_address)
1585         (record_full_stopped_by_sw_breakpoint)
1586         (record_full_supports_stopped_by_sw_breakpoint)
1587         (record_full_stopped_by_hw_breakpoint)
1588         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
1589         methods of the record_full_base_target class.
1590         (record_full_store_registers, record_full_xfer_partial)
1591         (record_full_insert_breakpoint, record_full_remove_breakpoint):
1592         Refactor as methods of the record_full_target class.
1593         (record_full_can_execute_reverse, record_full_get_bookmark)
1594         (record_full_goto_bookmark, record_full_execution_direction)
1595         (record_full_record_method, record_full_info, record_full_delete)
1596         (record_full_is_replaying, record_full_will_replay)
1597         (record_full_goto_begin, record_full_goto_end, record_full_goto)
1598         (record_full_stop_replaying): Refactor as methods of the
1599         record_full_base_target class.
1600         (record_full_core_resume, record_full_core_kill)
1601         (record_full_core_fetch_registers)
1602         (record_full_core_prepare_to_store)
1603         (record_full_core_store_registers, record_full_core_xfer_partial)
1604         (record_full_core_insert_breakpoint)
1605         (record_full_core_remove_breakpoint)
1606         (record_full_core_has_execution): Refactor
1607         as methods of the record_full_core_target class.
1608         (record_full_base_target::supports_delete_record): New.
1609         (init_record_full_ops): Delete.
1610         (init_record_full_core_ops): Delete.
1611         (record_full_save): Refactor as method of the
1612         record_full_base_target class.
1613         (_initialize_record_full): Remove references to
1614         init_record_full_ops and init_record_full_core_ops.
1615
1616         * remote.c (remote_target, extended_remote_target): New classes.
1617         (remote_ops): Now a remote_target.
1618         (extended_remote_ops): Now an extended_remote_target.
1619         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
1620         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
1621         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
1622         (remote_pass_signals, remote_set_syscall_catchpoint)
1623         (remote_program_signals, )
1624         (remote_thread_always_alive): Remove target_ops parameter.
1625         (remote_thread_alive, remote_thread_name)
1626         (remote_update_thread_list, remote_threads_extra_info)
1627         (remote_static_tracepoint_marker_at)
1628         (remote_static_tracepoint_markers_by_strid)
1629         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
1630         (remote_open): Refactor as methods of remote_target.
1631         (extended_remote_open, extended_remote_detach)
1632         (extended_remote_attach, extended_remote_post_attach):
1633         (extended_remote_supports_disable_randomization)
1634         (extended_remote_create_inferior): : Refactor as method of
1635         extended_remote_target.
1636         (remote_set_permissions, remote_open_1, remote_detach)
1637         (remote_follow_fork, remote_follow_exec, remote_disconnect)
1638         (remote_resume, remote_commit_resume, remote_stop)
1639         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
1640         (remote_terminal_ours, remote_wait, remote_fetch_registers)
1641         (remote_prepare_to_store, remote_store_registers)
1642         (remote_flash_erase, remote_flash_done, remote_files_info)
1643         (remote_kill, remote_mourn, remote_insert_breakpoint)
1644         (remote_remove_breakpoint, remote_insert_watchpoint)
1645         (remote_watchpoint_addr_within_range)
1646         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
1647         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
1648         (remote_supports_stopped_by_sw_breakpoint)
1649         (remote_stopped_by_hw_breakpoint)
1650         (remote_supports_stopped_by_hw_breakpoint)
1651         (remote_stopped_by_watchpoint, remote_stopped_data_address)
1652         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
1653         (remote_verify_memory): Refactor as methods of remote_target.
1654         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
1655         parameter.
1656         (remote_xfer_partial, remote_get_memory_xfer_limit)
1657         (remote_search_memory, remote_rcmd, remote_memory_map)
1658         (remote_pid_to_str, remote_get_thread_local_address)
1659         (remote_get_tib_address, remote_read_description): Refactor as
1660         methods of remote_target.
1661         (remote_target::fileio_open, remote_target::fileio_pwrite)
1662         (remote_target::fileio_pread, remote_target::fileio_close): New.
1663         (remote_hostio_readlink, remote_hostio_fstat)
1664         (remote_filesystem_is_local, remote_can_execute_reverse)
1665         (remote_supports_non_stop, remote_supports_disable_randomization)
1666         (remote_supports_multi_process, remote_supports_cond_breakpoints)
1667         (remote_supports_enable_disable_tracepoint)
1668         (remote_supports_string_tracing)
1669         (remote_can_run_breakpoint_commands, remote_trace_init)
1670         (remote_download_tracepoint, remote_can_download_tracepoint)
1671         (remote_download_trace_state_variable, remote_enable_tracepoint)
1672         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
1673         (remote_trace_start, remote_get_trace_status)
1674         (remote_get_tracepoint_status, remote_trace_stop)
1675         (remote_trace_find, remote_get_trace_state_variable_value)
1676         (remote_save_trace_data, remote_get_raw_trace_data)
1677         (remote_set_disconnected_tracing, remote_core_of_thread)
1678         (remote_set_circular_trace_buffer, remote_traceframe_info)
1679         (remote_get_min_fast_tracepoint_insn_len)
1680         (remote_set_trace_buffer_size, remote_set_trace_notes)
1681         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
1682         (remote_disable_btrace, remote_teardown_btrace)
1683         (remote_read_btrace, remote_btrace_conf)
1684         (remote_augmented_libraries_svr4_read, remote_load)
1685         (remote_pid_to_exec_file, remote_can_do_single_step)
1686         (remote_execution_direction, remote_thread_handle_to_thread_info):
1687         Refactor as methods of remote_target.
1688         (init_remote_ops, init_extended_remote_ops): Delete.
1689         (remote_can_async_p, remote_is_async_p, remote_async)
1690         (remote_thread_events, remote_upload_tracepoints)
1691         (remote_upload_trace_state_variables): Refactor as methods of
1692         remote_target.
1693         (_initialize_remote): Remove references to init_remote_ops and
1694         init_extended_remote_ops.
1695
1696         * remote-sim.c (gdbsim_target): New class.
1697         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
1698         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
1699         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
1700         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
1701         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
1702         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
1703         Refactor as methods of gdbsim_target.
1704         (gdbsim_ops): Now a gdbsim_target.
1705         (init_gdbsim_ops): Delete.
1706         (gdbsim_cntrl_c): Adjust.
1707         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
1708
1709         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
1710         (the_amd64_linux_nat_target): New.
1711         (amd64_linux_fetch_inferior_registers)
1712         (amd64_linux_store_inferior_registers): Refactor as methods of
1713         amd64_linux_nat_target.
1714         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
1715         * i386-linux-nat.c: Don't include "linux-nat.h".
1716         (i386_linux_nat_target): New class.
1717         (the_i386_linux_nat_target): New.
1718         (i386_linux_fetch_inferior_registers)
1719         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
1720         as methods of i386_linux_nat_target.
1721         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
1722         * inf-child.c (inf_child_ops): Delete.
1723         (inf_child_fetch_inferior_registers)
1724         (inf_child_store_inferior_registers): Delete.
1725         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
1726         methods of inf_child_target.
1727         (inf_child_target::supports_terminal_ours)
1728         (inf_child_target::terminal_init)
1729         (inf_child_target::terminal_inferior)
1730         (inf_child_target::terminal_ours_for_output)
1731         (inf_child_target::terminal_ours, inf_child_target::interrupt)
1732         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
1733         New.
1734         (inf_child_open, inf_child_disconnect, inf_child_close)
1735         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
1736         (inf_child_post_startup_inferior, inf_child_can_run)
1737         (inf_child_pid_to_exec_file): Refactor as methods of
1738         inf_child_target.
1739         (inf_child_follow_fork): Delete.
1740         (inf_child_target::can_create_inferior)
1741         (inf_child_target::can_attach): New.
1742         (inf_child_target::has_all_memory, inf_child_target::has_memory)
1743         (inf_child_target::has_stack, inf_child_target::has_registers)
1744         (inf_child_target::has_execution): New.
1745         (inf_child_fileio_open, inf_child_fileio_pwrite)
1746         (inf_child_fileio_pread, inf_child_fileio_fstat)
1747         (inf_child_fileio_close, inf_child_fileio_unlink)
1748         (inf_child_fileio_readlink, inf_child_use_agent)
1749         (inf_child_can_use_agent): Refactor as methods of
1750         inf_child_target.
1751         (return_zero, inf_child_target): Delete.
1752         (inf_child_target::inf_child_target): New.
1753         * inf-child.h: Include "target.h".
1754         (inf_child_target): Delete function prototype.
1755         (inf_child_target): New class.
1756         (inf_child_open_target, inf_child_mourn_inferior)
1757         (inf_child_maybe_unpush_target): Delete.
1758         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
1759         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
1760         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
1761         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
1762         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
1763         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
1764         (inf_ptrace_wait, inf_ptrace_xfer_partial)
1765         (inf_ptrace_thread_alive, inf_ptrace_files_info)
1766         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
1767         methods of inf_ptrace_target.
1768         (inf_ptrace_target): Delete function.
1769         * inf-ptrace.h: Include "inf-child.h".
1770         (inf_ptrace_target): Delete function declaration.
1771         (inf_ptrace_target): New class.
1772         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
1773         * linux-nat.c (linux_target): New.
1774         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
1775         (linux_nat_target::~linux_nat_target): New.
1776         (linux_child_post_attach, linux_child_post_startup_inferior)
1777         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
1778         (linux_child_remove_fork_catchpoint)
1779         (linux_child_insert_vfork_catchpoint)
1780         (linux_child_remove_vfork_catchpoint)
1781         (linux_child_insert_exec_catchpoint)
1782         (linux_child_remove_exec_catchpoint)
1783         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
1784         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
1785         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
1786         (linux_nat_stopped_data_address)
1787         (linux_nat_stopped_by_sw_breakpoint)
1788         (linux_nat_supports_stopped_by_sw_breakpoint)
1789         (linux_nat_stopped_by_hw_breakpoint)
1790         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
1791         (linux_nat_kill, linux_nat_mourn_inferior)
1792         (linux_nat_xfer_partial, linux_nat_thread_alive)
1793         (linux_nat_update_thread_list, linux_nat_pid_to_str)
1794         (linux_nat_thread_name, linux_child_pid_to_exec_file)
1795         (linux_child_static_tracepoint_markers_by_strid)
1796         (linux_nat_is_async_p, linux_nat_can_async_p)
1797         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
1798         (linux_nat_supports_multi_process)
1799         (linux_nat_supports_disable_randomization, linux_nat_async)
1800         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
1801         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
1802         (linux_nat_fileio_open, linux_nat_fileio_readlink)
1803         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
1804         methods of linux_nat_target.
1805         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
1806         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
1807         parameter.
1808         (check_stopped_by_watchpoint): Adjust.
1809         (linux_xfer_partial): Delete.
1810         (linux_target_install_ops, linux_target, linux_nat_add_target):
1811         Delete.
1812         (linux_nat_target::linux_nat_target): New.
1813         * linux-nat.h: Include "inf-ptrace.h".
1814         (linux_nat_target): New.
1815         (linux_target, linux_target_install_ops, linux_nat_add_target):
1816         Delete function declarations.
1817         (linux_target): Declare global.
1818         * linux-thread-db.c (thread_db_target): New.
1819         (thread_db_target::thread_db_target): New.
1820         (thread_db_ops): Delete.
1821         (the_thread_db_target): New.
1822         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
1823         (thread_db_update_thread_list, thread_db_pid_to_str)
1824         (thread_db_extra_thread_info)
1825         (thread_db_thread_handle_to_thread_info)
1826         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
1827         (thread_db_resume): Refactor as methods of thread_db_target.
1828         (init_thread_db_ops): Delete.
1829         (_initialize_thread_db): Remove reference to init_thread_db_ops.
1830         * x86-linux-nat.c: Don't include "linux-nat.h".
1831         (super_post_startup_inferior): Delete.
1832         (x86_linux_nat_target::~x86_linux_nat_target): New.
1833         (x86_linux_child_post_startup_inferior)
1834         (x86_linux_read_description, x86_linux_enable_btrace)
1835         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
1836         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
1837         methods of x86_linux_nat_target.
1838         (x86_linux_create_target): Delete.  Bits folded ...
1839         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
1840         pointer.
1841         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
1842         (x86_linux_nat_target): New class.
1843         (x86_linux_create_target): Delete.
1844         (x86_linux_add_target): Now takes a linux_nat_target pointer.
1845         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
1846         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
1847         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
1848         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
1849         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
1850         make extern.
1851         (x86_use_watchpoints): Delete.
1852         * x86-nat.h: Include "breakpoint.h" and "target.h".
1853         (x86_use_watchpoints): Delete.
1854         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
1855         (x86_stopped_by_watchpoint, x86_stopped_data_address)
1856         (x86_insert_watchpoint, x86_remove_watchpoint)
1857         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
1858         (x86_stopped_by_hw_breakpoint): New declarations.
1859         (x86_nat_target): New template class.
1860
1861         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
1862         (the_ppc_linux_nat_target): New.
1863         (ppc_linux_fetch_inferior_registers)
1864         (ppc_linux_can_use_hw_breakpoint)
1865         (ppc_linux_region_ok_for_hw_watchpoint)
1866         (ppc_linux_ranged_break_num_registers)
1867         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
1868         (ppc_linux_insert_mask_watchpoint)
1869         (ppc_linux_remove_mask_watchpoint)
1870         (ppc_linux_can_accel_watchpoint_condition)
1871         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
1872         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
1873         (ppc_linux_watchpoint_addr_within_range)
1874         (ppc_linux_masked_watch_num_registers)
1875         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
1876         (ppc_linux_read_description): Refactor as methods of
1877         ppc_linux_nat_target.
1878         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
1879
1880         * procfs.c (procfs_xfer_partial): Delete forward declaration.
1881         (procfs_target): New class.
1882         (the_procfs_target): New.
1883         (procfs_target): Delete function.
1884         (procfs_auxv_parse, procfs_attach, procfs_detach)
1885         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
1886         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
1887         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
1888         (procfs_create_inferior, procfs_update_thread_list)
1889         (procfs_thread_alive, procfs_pid_to_str)
1890         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
1891         (procfs_stopped_data_address, procfs_insert_watchpoint)
1892         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
1893         (proc_find_memory_regions, procfs_info_proc)
1894         (procfs_make_note_section): Refactor as methods of procfs_target.
1895         (_initialize_procfs): Adjust.
1896         * sol-thread.c (sol_thread_target): New class.
1897         (sol_thread_ops): Now a sol_thread_target.
1898         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
1899         (sol_thread_fetch_registers, sol_thread_store_registers)
1900         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
1901         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
1902         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
1903         (init_sol_thread_ops): Delete.
1904         (_initialize_sol_thread): Adjust.  Remove references to
1905         init_sol_thread_ops and complete_target_initialization.
1906
1907         * windows-nat.c (windows_nat_target): New class.
1908         (windows_fetch_inferior_registers)
1909         (windows_store_inferior_registers, windows_resume, windows_wait)
1910         (windows_attach, windows_detach, windows_pid_to_exec_file)
1911         (windows_files_info, windows_create_inferior)
1912         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
1913         (windows_close, windows_pid_to_str, windows_xfer_partial)
1914         (windows_get_tib_address, windows_get_ada_task_ptid)
1915         (windows_thread_name, windows_thread_alive): Refactor as
1916         windows_nat_target methods.
1917         (do_initial_windows_stuff): Adjust.
1918         (windows_target): Delete function.
1919         (_initialize_windows_nat): Adjust.
1920
1921         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
1922         (darwin_mourn_inferior, darwin_kill_inferior)
1923         (darwin_create_inferior, darwin_attach, darwin_detach)
1924         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
1925         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
1926         (darwin_supports_multi_process): Refactor as darwin_nat_target
1927         methods.
1928         (darwin_resume_to, darwin_files_info): Delete.
1929         (_initialize_darwin_inferior): Rename to ...
1930         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
1931         * darwin-nat.h: Include "inf-child.h".
1932         (darwin_nat_target): New class.
1933         (darwin_complete_target): Delete.
1934         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
1935         (darwin_target): New.
1936         (i386_darwin_fetch_inferior_registers)
1937         (i386_darwin_store_inferior_registers): Refactor as methods of
1938         darwin_nat_target.
1939         (darwin_complete_target): Delete, with ...
1940         (_initialize_i386_darwin_nat): ... bits factored out here.
1941
1942         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
1943         (the_alpha_linux_nat_target): New.
1944         (alpha_linux_register_u_offset): Refactor as
1945         alpha_linux_nat_target method.
1946         (_initialize_alpha_linux_nat): Adjust.
1947         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
1948         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
1949         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
1950         methods of linux_nat_trad_target.
1951         (linux_trad_target): Delete.
1952         * linux-nat-trad.h (linux_trad_target): Delete function.
1953         (linux_nat_trad_target): New class.
1954         * mips-linux-nat.c (mips_linux_nat_target): New class.
1955         (super_fetch_registers, super_store_registers, super_close):
1956         Delete.
1957         (the_mips_linux_nat_target): New.
1958         (mips64_linux_regsets_fetch_registers)
1959         (mips64_linux_regsets_store_registers)
1960         (mips64_linux_fetch_registers, mips64_linux_store_registers)
1961         (mips_linux_register_u_offset, mips_linux_read_description)
1962         (mips_linux_can_use_hw_breakpoint)
1963         (mips_linux_stopped_by_watchpoint)
1964         (mips_linux_stopped_data_address)
1965         (mips_linux_region_ok_for_hw_watchpoint)
1966         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
1967         (mips_linux_close): Refactor as methods of mips_linux_nat.
1968         (_initialize_mips_linux_nat): Adjust to C++ification.
1969
1970         * aix-thread.c (aix_thread_target): New class.
1971         (aix_thread_ops): Now an aix_thread_target.
1972         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
1973         (aix_thread_fetch_registers, aix_thread_store_registers)
1974         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
1975         (aix_thread_thread_alive, aix_thread_pid_to_str)
1976         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
1977         Refactor as methods of aix_thread_target.
1978         (init_aix_thread_ops): Delete.
1979         (_initialize_aix_thread): Remove references to init_aix_thread_ops
1980         and complete_target_initialization.
1981         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
1982         (rs6000_nat_target): New class.
1983         (the_rs6000_nat_target): New.
1984         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
1985         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
1986         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
1987         (super_create_inferior): Delete.
1988         (_initialize_rs6000_nat): Adjust to C++ification.
1989
1990         * arm-linux-nat.c (arm_linux_nat_target): New class.
1991         (the_arm_linux_nat_target): New.
1992         (arm_linux_fetch_inferior_registers)
1993         (arm_linux_store_inferior_registers, arm_linux_read_description)
1994         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
1995         (arm_linux_remove_hw_breakpoint)
1996         (arm_linux_region_ok_for_hw_watchpoint)
1997         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
1998         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
1999         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
2000         arm_linux_nat_target.
2001         (_initialize_arm_linux_nat): Adjust to C++ification.
2002
2003         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
2004         (the_aarch64_linux_nat_target): New.
2005         (aarch64_linux_fetch_inferior_registers)
2006         (aarch64_linux_store_inferior_registers)
2007         (aarch64_linux_child_post_startup_inferior)
2008         (aarch64_linux_read_description)
2009         (aarch64_linux_can_use_hw_breakpoint)
2010         (aarch64_linux_insert_hw_breakpoint)
2011         (aarch64_linux_remove_hw_breakpoint)
2012         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
2013         (aarch64_linux_region_ok_for_hw_watchpoint)
2014         (aarch64_linux_stopped_data_address)
2015         (aarch64_linux_stopped_by_watchpoint)
2016         (aarch64_linux_watchpoint_addr_within_range)
2017         (aarch64_linux_can_do_single_step): Refactor as methods of
2018         aarch64_linux_nat_target.
2019         (super_post_startup_inferior): Delete.
2020         (_initialize_aarch64_linux_nat): Adjust to C++ification.
2021
2022         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
2023         (the_hppa_linux_nat_target): New.
2024         (hppa_linux_fetch_inferior_registers)
2025         (hppa_linux_store_inferior_registers): Refactor as methods of
2026         hppa_linux_nat_target.
2027         (_initialize_hppa_linux_nat): Adjust to C++ification.
2028
2029         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
2030         (the_ia64_linux_nat_target): New.
2031         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
2032         (ia64_linux_stopped_data_address)
2033         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
2034         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
2035         ia64_linux_nat_target methods.
2036         (super_xfer_partial): Delete.
2037         (_initialize_ia64_linux_nat): Adjust to C++ification.
2038
2039         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
2040         (the_m32r_linux_nat_target): New.
2041         (m32r_linux_fetch_inferior_registers)
2042         (m32r_linux_store_inferior_registers): Refactor as
2043         m32r_linux_nat_target methods.
2044         (_initialize_m32r_linux_nat): Adjust to C++ification.
2045
2046         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
2047         (the_m68k_linux_nat_target): New.
2048         (m68k_linux_fetch_inferior_registers)
2049         (m68k_linux_store_inferior_registers): Refactor as
2050         m68k_linux_nat_target methods.
2051         (_initialize_m68k_linux_nat): Adjust to C++ification.
2052
2053         * s390-linux-nat.c (s390_linux_nat_target): New class.
2054         (the_s390_linux_nat_target): New.
2055         (s390_linux_fetch_inferior_registers)
2056         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
2057         (s390_insert_watchpoint, s390_remove_watchpoint)
2058         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
2059         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
2060         (s390_auxv_parse, s390_read_description): Refactor as methods of
2061         s390_linux_nat_target.
2062         (_initialize_s390_nat): Adjust to C++ification.
2063
2064         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
2065         (the_sparc_linux_nat_target): New.
2066         (_initialize_sparc_linux_nat): Adjust to C++ification.
2067         * sparc-nat.c (sparc_fetch_inferior_registers)
2068         (sparc_store_inferior_registers): Remove target_ops parameter.
2069         * sparc-nat.h (sparc_fetch_inferior_registers)
2070         (sparc_store_inferior_registers): Remove target_ops parameter.
2071         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
2072         (the_sparc64_linux_nat_target): New.
2073         (_initialize_sparc64_linux_nat): Adjust to C++ification.
2074
2075         * spu-linux-nat.c (spu_linux_nat_target): New class.
2076         (the_spu_linux_nat_target): New.
2077         (spu_child_post_startup_inferior, spu_child_post_attach)
2078         (spu_child_wait, spu_fetch_inferior_registers)
2079         (spu_store_inferior_registers, spu_xfer_partial)
2080         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
2081         methods.
2082         (_initialize_spu_nat): Adjust to C++ification.
2083
2084         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
2085         (the_tilegx_linux_nat_target): New.
2086         (fetch_inferior_registers, store_inferior_registers):
2087         Refactor as methods.
2088         (_initialize_tile_linux_nat): Adjust to C++ification.
2089
2090         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
2091         (the_xtensa_linux_nat_target): New.
2092         (xtensa_linux_fetch_inferior_registers)
2093         (xtensa_linux_store_inferior_registers): Refactor as
2094         xtensa_linux_nat_target methods.
2095         (_initialize_xtensa_linux_nat): Adjust to C++ification.
2096
2097         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
2098         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
2099         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
2100         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
2101         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
2102         (fbsd_stopped_by_sw_breakpoint)
2103         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
2104         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
2105         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
2106         (fbsd_post_startup_inferior, fbsd_post_attach)
2107         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
2108         (fbsd_set_syscall_catchpoint)
2109         (super_xfer_partial, super_resume, super_wait)
2110         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
2111         (fbsd_handle_debug_trap): Remove target_ops parameter.
2112         (fbsd_nat_add_target): Delete.
2113         * fbsd-nat.h: Include "inf-ptrace.h".
2114         (fbsd_nat_add_target): Delete.
2115         (USE_SIGTRAP_SIGINFO): Define.
2116         (fbsd_nat_target): New class.
2117
2118         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
2119         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
2120         (amd64bsd_target): Delete.
2121         * amd64-bsd-nat.h: New file.
2122         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
2123         "x86-bsd-nat.h".
2124         (amd64_fbsd_nat_target): New class.
2125         (the_amd64_fbsd_nat_target): New.
2126         (amd64fbsd_read_description): Refactor as method of
2127         amd64_fbsd_nat_target.
2128         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2129         (_initialize_amd64fbsd_nat): Adjust to C++ification.
2130         * amd64-nat.h (amd64bsd_target): Delete function declaration.
2131         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
2132         (i386bsd_store_inferior_registers): Remove target_ops parameter.
2133         (i386bsd_target): Delete.
2134         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
2135         (i386bsd_fetch_inferior_registers)
2136         (i386bsd_store_inferior_registers): Declare.
2137         (i386_bsd_nat_target): New class.
2138         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
2139         (the_i386_fbsd_nat_target): New.
2140         (i386fbsd_resume, i386fbsd_read_description): Refactor as
2141         i386_fbsd_nat_target methods.
2142         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2143         (_initialize_i386fbsd_nat): Adjust to C++ification.
2144         * x86-bsd-nat.c (super_mourn_inferior): Delete.
2145         (x86bsd_mourn_inferior, x86bsd_target): Delete.
2146         (_initialize_x86_bsd_nat): Adjust to C++ification.
2147         * x86-bsd-nat.h: Include "x86-nat.h".
2148         (x86bsd_target): Delete declaration.
2149         (x86bsd_nat_target): New class.
2150
2151         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
2152         (the_aarch64_fbsd_nat_target): New.
2153         (aarch64_fbsd_fetch_inferior_registers)
2154         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
2155         aarch64_fbsd_nat_target.
2156         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
2157         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
2158         (the_alpha_bsd_nat_target): New.
2159         (alphabsd_fetch_inferior_registers)
2160         (alphabsd_store_inferior_registers): Refactor as
2161         alpha_bsd_nat_target methods.
2162         (_initialize_alphabsd_nat): Refactor as methods of
2163         alpha_bsd_nat_target.
2164         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
2165         (the_amd64_nbsd_nat_target): New.
2166         (_initialize_amd64nbsd_nat): Adjust to C++ification.
2167         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
2168         (the_amd64_obsd_nat_target): New.
2169         (_initialize_amd64obsd_nat): Adjust to C++ification.
2170         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
2171         (the_arm_fbsd_nat_target): New.
2172         (arm_fbsd_fetch_inferior_registers)
2173         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
2174         (_initialize_arm_fbsd_nat): Refactor as methods of
2175         arm_fbsd_nat_target.
2176         (_initialize_arm_fbsd_nat): Adjust to C++ification.
2177         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
2178         (the_arm_netbsd_nat_target): New.
2179         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
2180         arm_netbsd_nat_target.
2181         (_initialize_arm_netbsd_nat): Adjust to C++ification.
2182         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
2183         (the_hppa_nbsd_nat_target): New.
2184         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
2185         hppa_nbsd_nat_target methods.
2186         (_initialize_hppanbsd_nat): Adjust to C++ification.
2187         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
2188         (the_hppa_obsd_nat_target): New.
2189         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
2190         methods of hppa_obsd_nat_target.
2191         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
2192         add_target.
2193         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
2194         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
2195         add_target.
2196         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
2197         (_initialize_i386obsd_nat): Use add_target.
2198         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
2199         (the_m68k_bsd_nat_target): New.
2200         (m68kbsd_fetch_inferior_registers)
2201         (m68kbsd_store_inferior_registers): Refactor as methods of
2202         m68k_bsd_nat_target.
2203         (_initialize_m68kbsd_nat): Adjust to C++ification.
2204         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
2205         (the_mips_fbsd_nat_target): New.
2206         (mips_fbsd_fetch_inferior_registers)
2207         (mips_fbsd_store_inferior_registers): Refactor as methods of
2208         mips_fbsd_nat_target.
2209         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
2210         add_target.
2211         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
2212         (the_mips_nbsd_nat_target): New.
2213         (mipsnbsd_fetch_inferior_registers)
2214         (mipsnbsd_store_inferior_registers): Refactor as methods of
2215         mips_nbsd_nat_target.
2216         (_initialize_mipsnbsd_nat): Adjust to C++ification.
2217         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
2218         (the_mips64_obsd_nat_target): New.
2219         (mips64obsd_fetch_inferior_registers)
2220         (mips64obsd_store_inferior_registers): Refactor as methods of
2221         mips64_obsd_nat_target.
2222         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
2223         add_target.
2224         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
2225         nbsd_nat_target.
2226         * nbsd-nat.h: Include "inf-ptrace.h".
2227         (nbsd_nat_target): New class.
2228         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
2229         (obsd_wait): Refactor as methods of obsd_nat_target.
2230         (obsd_add_target): Delete.
2231         * obsd-nat.h: Include "inf-ptrace.h".
2232         (obsd_nat_target): New class.
2233         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
2234         (the_ppc_fbsd_nat_target): New.
2235         (ppcfbsd_fetch_inferior_registers)
2236         (ppcfbsd_store_inferior_registers): Refactor as methods of
2237         ppc_fbsd_nat_target.
2238         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
2239         add_target.
2240         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
2241         (the_ppc_nbsd_nat_target): New.
2242         (ppcnbsd_fetch_inferior_registers)
2243         (ppcnbsd_store_inferior_registers): Refactor as methods of
2244         ppc_nbsd_nat_target.
2245         (_initialize_ppcnbsd_nat): Adjust to C++ification.
2246         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
2247         (the_ppc_obsd_nat_target): New.
2248         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
2249         methods of ppc_obsd_nat_target.
2250         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
2251         add_target.
2252         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
2253         (the_sh_nbsd_nat_target): New.
2254         (shnbsd_fetch_inferior_registers)
2255         (shnbsd_store_inferior_registers): Refactor as methods of
2256         sh_nbsd_nat_target.
2257         (_initialize_shnbsd_nat): Adjust to C++ification.
2258         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
2259         (inf_ptrace_xfer_partial): Delete.
2260         (sparc_xfer_partial, sparc_target): Delete.
2261         * sparc-nat.h (sparc_fetch_inferior_registers)
2262         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
2263         (sparc_target): Delete function declaration.
2264         (sparc_target): New template class.
2265         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
2266         (_initialize_sparcnbsd_nat): Adjust to C++ification.
2267         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
2268         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
2269         add_target.
2270         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
2271         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
2272         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
2273         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
2274         add_target.
2275         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
2276         (the_vax_bsd_nat_target): New.
2277         (vaxbsd_fetch_inferior_registers)
2278         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
2279         methods.
2280         (_initialize_vaxbsd_nat): Adjust to C++ification.
2281
2282         * bsd-kvm.c (bsd_kvm_target): New class.
2283         (bsd_kvm_ops): Now a bsd_kvm_target.
2284         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
2285         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
2286         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
2287         bsd_kvm_target.
2288         (bsd_kvm_return_one): Delete.
2289         (bsd_kvm_add_target): Adjust to C++ification.
2290
2291         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
2292         (nto_procfs_target_procfs): New classes.
2293         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
2294         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
2295         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
2296         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
2297         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
2298         (procfs_remove_hw_breakpoint, procfs_resume)
2299         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
2300         (procfs_kill_inferior, procfs_store_registers)
2301         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
2302         as methods of nto_procfs_target.
2303         (nto_procfs_ops): Now an nto_procfs_target_procfs.
2304         (nto_native_ops): Delete.
2305         (procfs_open, procfs_native_open): Delete.
2306         (nto_native_ops): Now an nto_procfs_target_native.
2307         (init_procfs_targets): Adjust to C++ification.
2308         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
2309         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
2310         Refactor as methods of nto_procfs_target.
2311
2312         * go32-nat.c (go32_nat_target): New class.
2313         (the_go32_nat_target): New.
2314         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
2315         (go32_store_registers, go32_xfer_partial, go32_files_info)
2316         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
2317         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
2318         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
2319         (go32_pid_to_str): Refactor as methods of go32_nat_target.
2320         (go32_target): Delete.
2321         (_initialize_go32_nat): Adjust to C++ification.
2322
2323         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
2324         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
2325         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
2326         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
2327         gnu_nat_target.
2328         (gnu_target): Delete.
2329         * gnu-nat.h (gnu_target): Delete.
2330         (gnu_nat_target): New class.
2331         * i386-gnu-nat.c (gnu_base_target): New.
2332         (i386_gnu_nat_target): New class.
2333         (the_i386_gnu_nat_target): New.
2334         (_initialize_i386gnu_nat): Adjust to C++ification.
2335
2336 2018-05-02  Pedro Alves  <palves@redhat.com>
2337
2338         * bfd-target.c (target_bfd_xclose): Rename to ...
2339         (target_bfd_close): ... this.
2340         (target_bfd_reopen): Adjust.
2341         * target.c (target_close): Remove references to to_xclose.
2342         * target.h (target_ops::to_xclose): Delete.
2343         (target_ops::to_close): Update comments.
2344
2345 2018-05-02  Pedro Alves  <palves@redhat.com>
2346
2347         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
2348         "linux-nat.h".
2349         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
2350         * inf-ptrace.c (inf_ptrace_register_u_offset)
2351         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2352         (inf_ptrace_store_register, inf_ptrace_store_registers)
2353         (inf_ptrace_trad_target): Move to ...
2354         * linux-nat-trad.c: ... this new file.
2355         * linux-nat-trad.h: New file.
2356         * linux-nat.c (linux_target_install_ops): Make extern.
2357         (linux_trad_target): Delete.
2358         * linux-nat.h (linux_trad_target): Delete declaration.
2359         (linux_target_install_ops): Declare.
2360         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
2361         "linux-nat.h".
2362
2363 2018-05-02  Pedro Alves  <palves@redhat.com>
2364
2365         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2366         procfs_target/add_target here.
2367         * procfs.c (procfs_target): Make static.
2368         (_initialize_procfs): Call add_target here.
2369         * procfs.h (struct target_ops): Remove forward declaration.
2370         (procfs_target): Remove declaration.
2371         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
2372
2373 2018-05-02  Pedro Alves  <palves@redhat.com>
2374
2375         * procfs.c (procfs_stopped_by_watchpoint)
2376         (procfs_insert_watchpoint, procfs_remove_watchpoint)
2377         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
2378         Forward declare.
2379         (procfs_use_watchpoints): Delete, move contents...
2380         (procfs_target): ... here.
2381         * procfs.h (procfs_use_watchpoints): Delete declaration.
2382         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2383         procfs_use_watchpoints.
2384         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
2385         procfs_use_watchpoints.
2386
2387 2018-05-02  Tom Tromey  <tom@tromey.com>
2388
2389         PR python/20084:
2390         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
2391         and var_zuinteger_unlimited.
2392         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
2393         and PARAM_ZUINTEGER_UNLIMITED.
2394         (set_parameter_value): Handle var_zuinteger and
2395         var_zuinteger_unlimited.
2396         (add_setshow_generic): Likewise.
2397         (parmpy_init): Likewise.
2398
2399 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
2400
2401         PR rust/23124
2402         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
2403         pointer is not null before dereferencing it.
2404
2405 2018-04-30  Tom Tromey  <tom@tromey.com>
2406
2407         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
2408         is_mi_like_p.
2409
2410 2018-04-30  Tom Tromey  <tom@tromey.com>
2411
2412         * breakpoint.c (mention): Remove use of is_mi_like_p.
2413         (print_mention_ranged_breakpoint): Likewise.
2414         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
2415         of is_mi_like_p.
2416
2417 2018-04-30  Tom Tromey  <tom@tromey.com>
2418
2419         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
2420
2421 2018-04-30  Tom Tromey  <tom@tromey.com>
2422
2423         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
2424         (info_spu_event_command): Remove some uses of is_mi_like_p.
2425
2426 2018-04-30  Tom Tromey  <tom@tromey.com>
2427
2428         * python/py-framefilter.c (py_print_single_arg)
2429         (enumerate_locals, py_print_args, py_print_frame): Remove some
2430         uses of is_mi_like_p.
2431
2432 2018-04-30  Tom Tromey  <tom@tromey.com>
2433
2434         * ui-out.c: Update.
2435         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
2436         * ui-out.h (ui_out::is_mi_like_p): Now const.
2437         (ui_out::do_is_mi_like_p): Now const.
2438         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
2439
2440 2018-04-30  Tom Tromey  <tom@tromey.com>
2441
2442         * varobj.c (varobj_set_visualizer): Use new_reference.
2443         * python/python.c (gdbpy_decode_line): Use new_reference.
2444         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
2445         new_reference.
2446
2447 2018-04-30  Tom Tromey  <tom@tromey.com>
2448
2449         * varobj.c (install_new_value): Use new_reference.
2450         * value.h (value_incref): Return void.  Swap intro comment with
2451         value_decref.
2452         * value.c (set_value_parent): Use new_reference.
2453         (value_incref): Return void.  Update intro comment.
2454         (release_value): Use new_reference.
2455         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
2456
2457 2018-04-30  Tom Tromey  <tom@tromey.com>
2458
2459         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
2460         * gdb_bfd.h (new_bfd_ref): Remove.
2461         (gdb_bfd_open): Update comment.
2462         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
2463         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
2464         (gdb_bfd_fdopenr): Use new_reference.
2465         * exec.c (exec_file_attach): Use new_reference.
2466
2467 2018-04-30  Tom Tromey  <tom@tromey.com>
2468
2469         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
2470         method.
2471
2472 2018-04-30  Tom Tromey  <tom@tromey.com>
2473
2474         * jit.c (jit_read_code_entry): Use type_align.
2475         * i386-tdep.c (i386_gdbarch_init): Don't call
2476         set_gdbarch_long_long_align_bit.
2477         * gdbarch.sh: Remove long_long_align_bit.
2478         * gdbarch.c, gdbarch.h: Rebuild.
2479         * arc-tdep.c (arc_type_align): New function.
2480         (arc_gdbarch_init): Use arc_type_align.  Don't call
2481         set_gdbarch_long_long_align_bit.
2482
2483 2018-04-30  Tom Tromey  <tom@tromey.com>
2484
2485         * rust-lang.c (rust_type_alignment): Remove.
2486         (rust_composite_type): Use type_align.
2487
2488 2018-04-30  Tom Tromey  <tom@tromey.com>
2489
2490         * NEWS: Mention Type.align.
2491         * python/py-type.c (typy_get_alignof): New function.
2492         (type_object_getset): Add "alignof".
2493
2494 2018-04-30  Tom Tromey  <tom@tromey.com>
2495
2496         PR exp/17095:
2497         * NEWS: Update.
2498         * std-operator.def (UNOP_ALIGNOF): New operator.
2499         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
2500         New.
2501         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
2502         * c-lang.c (c_op_print_tab): Add alignof.
2503         * c-exp.y (ALIGNOF): New token.
2504         (exp): Add "ALIGNOF" production.
2505         (ident_tokens): Add _Alignof and alignof.
2506
2507 2018-04-30  Tom Tromey  <tom@tromey.com>
2508
2509         * i386-tdep.c (i386_type_align): New function.
2510         (i386_gdbarch_init): Update.
2511         * gdbarch.sh (type_align): New method.
2512         * gdbarch.c, gdbarch.h: Rebuild.
2513         * arch-utils.h (default_type_align): Declare.
2514         * arch-utils.c (default_type_align): New function.
2515         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
2516         (struct type) <align_log2>: New field.
2517         <instance_flags>: Now a bitfield.
2518         (TYPE_RAW_ALIGN): New macro.
2519         (type_align, type_raw_align, set_type_align): Declare.
2520         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
2521         functions.
2522         * dwarf2read.c (quirk_rust_enum): Set type alignment.
2523         (get_alignment, maybe_set_alignment): New functions.
2524         (read_structure_type, read_enumeration_type, read_array_type)
2525         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
2526         (read_subrange_type, read_base_type): Set type alignment.
2527
2528 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
2529
2530         * dwarf2read.c (read_index_from_section): Use bool.
2531
2532 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
2533
2534         PR gdb/22950
2535         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
2536         with #ifdef.
2537
2538 2018-04-29  John Reiser  <jreiser@BitWagon.com>
2539
2540         PR build/22873
2541         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
2542         last step, and do it atomically.
2543
2544 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
2545
2546         * compile/compile-c-types.c (convert_int, convert_float):
2547         Update for C FE v1.
2548
2549 2018-04-27  Tom Tromey  <tom@tromey.com>
2550
2551         PR rust/22545:
2552         * rust-lang.c (rust_inclusive_range_type_p): New function.
2553         (rust_range): Handle inclusive ranges.
2554         (rust_compute_range): Likewise.
2555         * rust-exp.y (struct rust_op) <inclusive>: New field.
2556         (DOTDOTEQ): New constant.
2557         (range_expr): Add "..=" productions.
2558         (operator_tokens): Add "..=" token.
2559         (ast_range): Add "inclusive" parameter.
2560         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
2561         ranges.
2562         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
2563         bounds values.
2564         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
2565         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
2566         Update comments.
2567         * expprint.c (print_subexp_standard): Handle new bounds values.
2568         (dump_subexp_body_standard): Likewise.
2569
2570 2018-04-27  Tom Tromey  <tom@tromey.com>
2571
2572         * configure: Rebuild.
2573         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
2574         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
2575         "OVERRIDE".
2576         (class symbol_needs_eval_context): Likewise.
2577         * dwarf2read.c (mock_mapped_index::symbol_name_count)
2578         (mock_mapped_index::symbol_name_at): Use "override".  Remove
2579         "virtual".
2580         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
2581         "override".
2582         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
2583         * aarch64-tdep.c (instruction_reader::read): Use "override".
2584         (instruction_reader_test::read): Likewise.
2585         * arm-tdep.c (instruction_reader::read): Use "override".
2586         (instruction_reader_thumb::read): Likewise.
2587
2588 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
2589
2590         PR remote/9665
2591         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
2592         instead of remote_send.
2593         (remote_send): Remove.
2594
2595 2018-04-26  Pedro Alves  <palves@redhat.com>
2596
2597         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
2598         find_function_start_sal instead of find_pc_line.
2599
2600 2018-04-26  Pedro Alves  <palves@redhat.com>
2601
2602         * breakpoint.c (set_breakpoint_location_function): Handle
2603         mst_data_gnu_ifunc.
2604         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
2605         * elfread.c (elf_symtab_read): Give data symbols with
2606         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
2607         (elf_rel_plt_read): Update comment.
2608         * linespec.c (convert_linespec_to_sals): Handle
2609         mst_data_gnu_ifunc.
2610         (minsym_found): Handle mst_data_gnu_ifunc.
2611         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
2612         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
2613         * parse.c (find_minsym_type_and_address): Handle
2614         mst_data_gnu_ifunc.
2615         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
2616         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
2617         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
2618         comment.
2619         <mst_data_gnu_ifunc>: New enumerator.
2620
2621 2018-04-26  Pedro Alves  <palves@redhat.com>
2622
2623         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
2624         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
2625         'want_trampoline' parameter by a lookup_msym_prefer parameter.
2626         Handle it.
2627         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
2628         (lookup_minimal_symbol_by_pc): Adjust.
2629         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
2630         (lookup_solib_trampoline_symbol_by_pc): Adjust.
2631         * minsyms.h (lookup_msym_prefer): New enum.
2632         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
2633         parameter by a lookup_msym_prefer parameter.
2634
2635 2018-04-26  Pedro Alves  <palves@redhat.com>
2636
2637         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
2638         ends in "@plt" instead of looking at the symbol's section.
2639
2640 2018-04-26  Pedro Alves  <palves@redhat.com>
2641
2642         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
2643         all references.
2644         (find_pc_partial_function_gnu_ifunc): Rename to ...
2645         (find_pc_partial_function): ... this, and remove references to
2646         'is_gnu_ifunc_p'.
2647         (find_pc_partial_function): Delete old implementation.
2648         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
2649
2650 2018-04-26  Pedro Alves  <palves@redhat.com>
2651
2652         * linespec.c (struct bound_minimal_symbol_search_key): New.
2653         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
2654         skip first line if we found a GNU ifunc minimal symbol by name.
2655         (compare_msymbols): Change parameters to work with a destructured
2656         lhs minsym.
2657         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
2658         functions.
2659
2660 2018-04-26  Pedro Alves  <palves@redhat.com>
2661
2662         * breakpoint.c (set_breakpoint_location_function): Don't resolve
2663         ifunc targets here.  Instead, if we have an ifunc minsym, use its
2664         address/name.
2665         (add_location_to_breakpoint): Store the minsym and the objfile in
2666         the breakpoint location.
2667         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
2668         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
2669         Record the minsym in the sal.
2670         * symtab.h (symtab_and_line) <msymbol>: New field.
2671
2672 2018-04-26  Pedro Alves  <palves@redhat.com>
2673
2674         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
2675         unless we actually resolved the ifunc.
2676
2677 2018-04-26  Pedro Alves  <palves@redhat.com>
2678
2679         * c-exp.y (variable production): Prefer ifunc minsyms over
2680         regular function symbols.
2681         * symtab.c (find_gnu_ifunc): New function.
2682         * minsyms.h (lookup_msym_prefer): New enum.
2683         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
2684         parameter by a lookup_msym_prefer parameter.
2685         * symtab.h (find_gnu_ifunc): New declaration.
2686
2687 2018-04-26  Pedro Alves  <palves@redhat.com>
2688
2689         * blockframe.c (find_gnu_ifunc_target_type): New function.
2690         (find_function_type): New.
2691         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
2692         return a value with a memory address.
2693         (eval_call): For calls to GNU ifunc functions, try to find the
2694         type of the target function from the type that the resolver
2695         returns.
2696         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
2697         symbols.
2698         * infcall.c (find_function_return_type): Delete.
2699         (find_function_addr): Add 'function_type' parameter.  For calls to
2700         GNU ifunc functions, try to find the type of the target function
2701         from the type that the resolver returns, and return it via
2702         FUNCTION_TYPE.
2703         (call_function_by_hand_dummy): Adjust to use the function type
2704         returned by find_function_addr.
2705         (find_function_addr): Add 'function_type' parameter and move
2706         description here.
2707         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
2708         declarations.
2709
2710 2018-04-26  Pedro Alves  <palves@redhat.com>
2711
2712         * c-exp.y (variable production): Skip finding an alias for ifunc
2713         symbols.
2714
2715 2018-04-26  Pedro Alves  <palves@redhat.com>
2716
2717         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
2718
2719 2018-04-25  Pedro Alves  <palves@redhat.com>
2720
2721         * infcmd.c (kill_command): Print the pid as string, not the whole
2722         thread's ptid.  Add comment.  s/has been killed/killed/ in output
2723         message.
2724         * remote.c (remote_detach_1): Print the pid as string, not the
2725         whole thread's ptid.
2726
2727 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
2728             Sergio Durigan Junior  <sergiodj@redhat.com>
2729             Pedro Alves  <palves@redhat.com>
2730
2731         * infcmd.c (kill_command): Print message when inferior has
2732         been killed.
2733         * inferior.c (print_inferior_events): Remove 'static'.  Set as
2734         '1'.
2735         (add_inferior): Improve message printed when
2736         'print_inferior_events' is on.
2737         (exit_inferior): Remove message printed when
2738         'print_inferior_events' is on.
2739         (detach_inferior): Improve message printed when
2740         'print_inferior_events' is on.
2741         (initialize_inferiors): Use 'add_inferior_silent' to set
2742         'current_inferior_'.
2743         * inferior.h (print_inferior_events): Declare here as
2744         'extern'.
2745         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
2746         '[Detaching...]' messages when 'print_inferior_events' is on.
2747         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
2748         as prefix/suffix for messages.  Remove periods.  Fix erroneous
2749         'Detaching after fork from child...', replace it by '... from
2750         parent...'.
2751         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
2752         prefix/suffix when printing 'Detaching...' messages.  Print
2753         them when 'print_inferior_events' is on.
2754         * remote.c (remote_detach_1): Print message when detaching
2755         from inferior and '!is_fork_parent'.
2756
2757 2018-04-24  Tom Tromey  <tom@tromey.com>
2758
2759         * cli-out.h: Reindent.
2760
2761 2018-04-24  Tom Tromey  <tom@tromey.com>
2762
2763         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
2764         (cli_ui_out::do_field_string): Use fputs_filtered.
2765         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
2766
2767 2018-04-23  Tom Tromey  <tom@tromey.com>
2768
2769         * guile/scm-frame.c (gdbscm_frame_read_var): Use
2770         gdb::unique_xmalloc_ptr.
2771
2772 2018-04-23  Tom Tromey  <tom@tromey.com>
2773
2774         * configure: Rebuild.
2775
2776 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
2777
2778         PR gdb/23095
2779         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
2780         prepare_for_testing.  Set normal_bp to r_debug_state if target
2781         is bsd.
2782
2783 2018-04-21  Pedro Alves  <palves@redhat.com>
2784             Rajendra SY  <rajendra.sy@gmail.com>
2785
2786         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
2787         * remote.c (extended_remote_attach): In all-stop mode, mark the
2788         thread as executing.
2789
2790 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2791
2792         * thread.c (thread_apply_all_command): Fix comment.
2793         (thread_command): Fix comment.
2794
2795 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
2796
2797         * common/tdesc.h (tdesc_create_feature): Remove xml filename
2798         parameter.
2799         * features/aarch64-core.c (create_feature_aarch64_core):
2800         Regenerate.
2801         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
2802         Likewise.
2803         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
2804         Likewise.
2805         * features/i386/32bit-avx512.c
2806         (create_feature_i386_32bit_avx512): Likewise.
2807         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
2808         Likewise.
2809         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
2810         Likewise.
2811         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
2812         Likewise.
2813         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
2814         Likewise.
2815         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
2816         Likewise.
2817         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
2818         Likewise.
2819         * features/i386/64bit-avx512.c
2820         (create_feature_i386_64bit_avx512): Likewise.
2821         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
2822         Likewise.
2823         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
2824         Likewise.
2825         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
2826         Likewise.
2827         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
2828         Likewise.
2829         * features/i386/64bit-segments.c
2830         (create_feature_i386_64bit_segments): Likewise.
2831         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
2832         Likewise.
2833         * features/i386/x32-core.c
2834         (create_feature_i386_x32_core): Likewise.
2835         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
2836         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
2837         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
2838         * target-descriptions.c: In generated code, don't pass xml
2839         filename.
2840
2841 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2842
2843         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
2844         (print_xml_feature::visit_post): Likewise.
2845         (print_xml_feature::visit): Likewise.
2846         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
2847         (print_xml_feature): Add new class.
2848         * regformats/regdat.sh: Null xmltarget on feature targets.
2849         * target-descriptions.c (struct target_desc): Add xmltarget.
2850         (maintenance_check_tdesc_xml_convert): Add unittest function.
2851         (tdesc_get_features_xml): Add function to get xml.
2852         (maintenance_check_xml_descriptions): Test xml generation.
2853         * xml-tdesc.c (string_read_description_xml): Add function.
2854         * xml-tdesc.h (string_read_description_xml): Add declaration.
2855
2856 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2857
2858         * features/Makefile: Add feature marker to targets with new style
2859         target descriptions.
2860         * regformats/aarch64.dat: Regenerate.
2861         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
2862         * regformats/i386/amd64-avx-linux.dat: Likewise.
2863         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
2864         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
2865         * regformats/i386/amd64-linux.dat: Likewise.
2866         * regformats/i386/amd64-mpx-linux.dat: Likewise.
2867         * regformats/i386/amd64.dat: Likewise.
2868         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
2869         * regformats/i386/i386-avx-linux.dat: Likewise.
2870         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
2871         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
2872         * regformats/i386/i386-linux.dat: Likewise.
2873         * regformats/i386/i386-mmx-linux.dat: Likewise.
2874         * regformats/i386/i386-mpx-linux.dat: Likewise.
2875         * regformats/i386/i386.dat: Likewise.
2876         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
2877         * regformats/i386/x32-avx-linux.dat: Likewise.
2878         * regformats/i386/x32-linux.dat: Likewise.
2879         * regformats/tic6x-c62x-linux.dat: Likewise.
2880         * regformats/tic6x-c64x-linux.dat: Likewise.
2881         * regformats/tic6x-c64xp-linux.dat: Likewise.
2882         * regformats/regdat.sh: Parse feature marker.
2883
2884 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2885
2886         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
2887         (tdesc_osabi_name): Likewise.
2888         * target-descriptions.c (tdesc_architecture_name): Add new
2889         function.
2890         (tdesc_osabi_name): Likewise.
2891
2892 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2893
2894         * common/tdesc.c (tdesc_predefined_type): Move to here.
2895         (tdesc_named_type): Likewise.
2896         (tdesc_create_vector): Likewise.
2897         (tdesc_create_struct): Likewise.
2898         (tdesc_set_struct_size): Likewise.
2899         (tdesc_create_union): Likewise.
2900         (tdesc_create_flags): Likewise.
2901         (tdesc_create_enum): Likewise.
2902         (tdesc_add_field): Likewise.
2903         (tdesc_add_typed_bitfield): Likewise.
2904         (tdesc_add_bitfield): Likewise.
2905         (tdesc_add_flag): Likewise.
2906         (tdesc_add_enum_value): Likewise.
2907         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
2908         (struct tdesc_type_vector): Likewise.
2909         (struct tdesc_type_field): Likewise.
2910         (struct tdesc_type_with_fields): Likewise.
2911         (tdesc_create_enum): Add declaration.
2912         (tdesc_add_typed_bitfield): Likewise.
2913         (tdesc_add_enum_value): Likewise.
2914         * target-descriptions.c (tdesc_type_field): Move from here.
2915         (tdesc_type_builtin): Likewise.
2916         (tdesc_type_vector): Likewise.
2917         (tdesc_type_with_fields): Likewise.
2918         (tdesc_predefined_types): Likewise.
2919         (tdesc_named_type): Likewise.
2920         (tdesc_create_vector): Likewise.
2921         (tdesc_create_struct): Likewise.
2922         (tdesc_set_struct_size): Likewise.
2923         (tdesc_create_union): Likewise.
2924         (tdesc_create_flags): Likewise.
2925         (tdesc_create_enum): Likewise.
2926         (tdesc_add_field): Likewise.
2927         (tdesc_add_typed_bitfield): Likewise.
2928         (tdesc_add_bitfield): Likewise.
2929         (tdesc_add_flag): Likewise.
2930         (tdesc_add_enum_value): Likewise.
2931         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
2932         (tdesc_add_typed_bitfield): Likewise.
2933         (tdesc_add_enum_value): Likewise.
2934
2935 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2936
2937         * common/tdesc.c (tdesc_feature::accept): Move to here.
2938         (tdesc_feature::operator==): Likewise.
2939         (tdesc_create_reg): Likewise.
2940         * common/tdesc.h (tdesc_type_kind): Likewise.
2941         (struct tdesc_type): Likewise.
2942         (struct tdesc_feature): Likewise.
2943         * regformats/regdat.sh: Create a feature.
2944         * target-descriptions.c (tdesc_type_kind): Move from here.
2945         (tdesc_type): Likewise.
2946         (tdesc_type_up): Likewise.
2947         (tdesc_feature): Likewise.
2948         (tdesc_create_reg): Likewise.
2949
2950 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2951
2952         * Makefile.in: Add arch/tdesc.c
2953         * common/tdesc.c: New file.
2954         * common/tdesc.h (tdesc_element_visitor): Move to here.
2955         (tdesc_element): Likewise.
2956         (tdesc_reg): Likewise.
2957         (tdesc_reg_up): Likewise.
2958         * regformats/regdef.h (reg): Add offset to constructors.
2959         * target-descriptions.c (tdesc_element_visitor): Move from here.
2960         (tdesc_element): Likewise.
2961         (tdesc_reg): Likewise.
2962         (tdesc_reg_up): Likewise.
2963
2964 2018-04-17  Tom Tromey  <tom@tromey.com>
2965
2966         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
2967         discriminant field.
2968
2969 2018-04-17  Tom Tromey  <tom@tromey.com>
2970
2971         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
2972
2973 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
2974
2975         * symtab.c (print_symbol_info): Skip printing filename and line
2976         number when `last' is NULL.
2977         (symtab_symbol_info): Use empty string instead of NULL for first
2978         invocation of print_symbol_info.
2979         (rbreak_command): Pass NULL to `last' parameter of
2980         print_symbol_info.
2981
2982 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
2983
2984         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
2985         instead of nullptr.
2986
2987 2018-04-16  Pedro Alves  <palves@redhat.com>
2988
2989         * MAINTAINERS (sh): Remove.
2990         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
2991         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
2992         (ALLDEPFILES): Remove sh64-tdep.c.
2993         * NEWS: Mentions that support for SH-5/SH64 is removed.
2994         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
2995         (sh*-*-openbsd*): Ditto.
2996         (sh64-*-elf*): Remove.
2997         (sh*): Remove.
2998         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
2999         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
3000         * sh-tdep.c: No longer include "sh64-tdep.h".
3001         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
3002         * sh64-tdep.c, sh64-tdep.h: Remove files.
3003
3004 2018-04-16  Pedro Alves  <palves@redhat.com>
3005
3006         * MAINTAINERS: Remove m88k.
3007         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
3008         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
3009         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
3010         * NEWS: Mention that support for m88k was removed.
3011         * configure.host (m88*-*-*): Remove support.
3012         * configure.nat (m88k-*-*): Remove support.
3013         * configure.tgt (m88*-*-openbsd*): Remove.
3014         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
3015
3016 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
3017
3018         * configure.tgt (x86_tobjs): New variable.
3019         (amd64_tobjs, i386_tobjs): Use it.
3020
3021 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3022
3023         * symtab.c (print_symbol_info): Precede the symbol definition by
3024         the line number when available.
3025         * NEWS: Advertise this enhancement.
3026
3027 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3028
3029         * NEWS (New options): announce set/show record btrace cpu.
3030         * btrace.c: Include record-btrace.h.
3031         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
3032         the vendor is unknown.
3033         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
3034         Maybe overwrite the btrace configuration's cpu.
3035         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
3036         (btrace_fetch): Add cpu parameter.  Update callers.
3037         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
3038         Maybe overwrite the btrace configuration's cpu.  Skip enabling
3039         errata workarounds if the vendor is unknown.
3040         * python/py-record-btrace.c: Include record-btrace.h.
3041         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
3042         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
3043         * record-btrace.c (record_btrace_cpu_state_kind): New.
3044         (record_btrace_cpu): New.
3045         (set_record_btrace_cpu_cmdlist): New.
3046         (record_btrace_get_cpu): New.
3047         (require_btrace_thread, record_btrace_info)
3048         (record_btrace_resume_thread): Call record_btrace_get_cpu.
3049         (cmd_set_record_btrace_cpu_none): New.
3050         (cmd_set_record_btrace_cpu_auto): New.
3051         (cmd_set_record_btrace_cpu): New.
3052         (cmd_show_record_btrace_cpu): New.
3053         (_initialize_record_btrace): Initialize set/show record btrace cpu
3054         commands.
3055         * record-btrace.h (record_btrace_get_cpu): New.
3056
3057 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3058
3059         * record.c (set_record_command): Fix typo in message.
3060
3061 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3062
3063         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
3064
3065 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3066
3067         * infrun.c (process_event_stop_test): Call
3068         gdbarch_in_indirect_branch_thunk.
3069         * gdbarch.sh (in_indirect_branch_thunk): New.
3070         * gdbarch.c: Regenerated.
3071         * gdbarch.h: Regenerated.
3072         * x86-tdep.h: New.
3073         * x86-tdep.c: New.
3074         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
3075         (HFILES_NO_SRCDIR): Add x86-tdep.h.
3076         (ALLDEPFILES): Add x86-tdep.c.
3077         * arch-utils.h (default_in_indirect_branch_thunk): New.
3078         * arch-utils.c (default_in_indirect_branch_thunk): New.
3079         * i386-tdep: Include x86-tdep.h.
3080         (i386_in_indirect_branch_thunk): New.
3081         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
3082         function.
3083         * amd64-tdep: Include x86-tdep.h.
3084         (amd64_in_indirect_branch_thunk): New.
3085         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
3086
3087 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
3088
3089         PR gdb/23053
3090         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
3091         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
3092         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
3093         regression.
3094
3095 2018-04-12  Tom Tromey  <tom@tromey.com>
3096
3097         * rust-lang.c (rust_print_struct_def): Remove univariant code.
3098         (rust_evaluate_subexp): Likewise.
3099
3100 2018-04-12  Pedro Alves  <palves@redhat.com>
3101
3102         * procfs.c (procfs_detach): Make forward declaration's prototype
3103         match definition's protototype.
3104         (proc_get_LDT_entry): Remove stale do_cleanups call.
3105
3106 2018-04-12  Pedro Alves  <palves@redhat.com>
3107
3108         * target.h (target_ops::to_has_exited): Delete.
3109         (target_has_exited): Delete.
3110         * target-delegates.c: Regenerate.
3111
3112 2018-04-11  Pedro Alves  <palves@redhat.com>
3113
3114         * target.c (fileio_fh_t::t): Add comment.
3115         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3116         (target_fileio_close): Handle a NULL target.
3117         (invalidate_fileio_fh): New.
3118         (target_close): Call it.
3119         * remote.c (remote_hostio_send_command): No longer check whether
3120         remote_desc is open.
3121
3122 2018-04-11  Pedro Alves  <palves@redhat.com>
3123
3124         * target.c (fileio_fh_t): Make it a named struct instead of a
3125         typedef.
3126         (fileio_fh_t::is_closed): New method.
3127         (DEF_VEC_O (fileio_fh_t)): Remove.
3128         (fileio_fhandles): Now a std::vector.
3129         (is_closed_fileio_fh): Delete.
3130         (acquire_fileio_fd): Adjust.  Rename parameters.
3131         (release_fileio_fd): Adjust.
3132         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
3133         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3134         (target_fileio_close): Adjust.
3135
3136 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
3137
3138         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
3139         index.
3140
3141 2018-04-10  Pedro Alves  <palves@redhat.com>
3142
3143         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
3144         (scoped_finish_thread_state): New class.
3145         * infcmd.c (run_command_1): Use it instead of finish_thread_state
3146         cleanup.
3147         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
3148         (fetch_inferior_event, normal_stop): Likewise.
3149         * thread.c (finish_thread_state_cleanup): Delete.
3150
3151 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3152             Pedro Alves  <palves@redhat.com>
3153
3154         * value.c: Include "selftest.h" and "common/array-view.h".
3155         (struct range) <operator ==>: New.
3156         (test_ranges_contain): New.
3157         (check_ranges_vector): New.
3158         (test_insert_into_bit_range_vector): New.
3159         (_initialize_values): Register selftests.
3160         * common/array-view.h (operator==, operator!=): New.
3161
3162 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3163
3164         * common/gdb_vecs.h (unordered_remove): Add overload that takes
3165         an iterator.
3166         * inline-frame.c: Include <algorithm>.
3167         (struct inline_state): Add constructor.
3168         (inline_state_s): Remove.
3169         (DEF_VEC_O(inline_state_s)): Remove.
3170         (inline_states): Change type to std::vector.
3171         (find_inline_frame_state): Adjust to std::vector.
3172         (allocate_inline_frame_state): Remove.
3173         (clear_inline_frame_state): Adjust to std::vector.
3174         (skip_inline_frames): Adjust to std::vector.
3175
3176 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3177
3178         * tracepoint.h (struct trace_state_variable): Add constructor.
3179         <name>: Change type to std::string.
3180         * tracepoint.c (tsv_s): Remove.
3181         (DEF_VEC_O(tsv_s)): Remove.
3182         (tvariables): Change to std::vector.
3183         (create_trace_state_variable): Adjust to std::vector.
3184         (find_trace_state_variable): Likewise.
3185         (find_trace_state_variable_by_number): Likewise.
3186         (delete_trace_state_variable): Likewise.
3187         (trace_variable_command): Adjust to std::string.
3188         (delete_trace_variable_command): Likewise.
3189         (tvariables_info_1): Adjust to std::vector.
3190         (save_trace_state_variables): Likewise.
3191         (start_tracing): Likewise.
3192         (merge_uploaded_trace_state_variables): Adjust to std::vector
3193         and std::string.
3194         * target.h (struct target_ops)
3195         <to_download_trace_state_variable>: Pass reference to
3196         trace_state_variable.
3197         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
3198         * target-delegates.c: Re-generate.
3199         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
3200         (mi_tsv_deleted): Likewise.
3201         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
3202         * remote.c (remote_download_trace_state_variable): Change
3203         pointer to reference and adjust.
3204         * make-target-delegates (parse_argtypes): Handle references.
3205         (write_function_header): Likewise.
3206         (munge_type): Likewise.
3207
3208 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3209
3210         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3211         string_view-selftests.c.
3212         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
3213         testsuite.
3214         * unittests/basic_string_view/cons/char/1.cc: Likewise.
3215         * unittests/basic_string_view/cons/char/2.cc: Likewise.
3216         * unittests/basic_string_view/cons/char/3.cc: Likewise.
3217         * unittests/basic_string_view/element_access/char/1.cc:
3218         Likewise.
3219         * unittests/basic_string_view/element_access/char/empty.cc:
3220         Likewise.
3221         * unittests/basic_string_view/element_access/char/front_back.cc:
3222         Likewise.
3223         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
3224         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
3225         Likewise.
3226         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
3227         Likewise.
3228         * unittests/basic_string_view/modifiers/swap/char/1.cc:
3229         Likewise.
3230         * unittests/basic_string_view/operations/compare/char/1.cc:
3231         Likewise.
3232         * unittests/basic_string_view/operations/compare/char/13650.cc:
3233         Likewise.
3234         * unittests/basic_string_view/operations/copy/char/1.cc:
3235         Likewise.
3236         * unittests/basic_string_view/operations/data/char/1.cc:
3237         Likewise.
3238         * unittests/basic_string_view/operations/find/char/1.cc:
3239         Likewise.
3240         * unittests/basic_string_view/operations/find/char/2.cc:
3241         Likewise.
3242         * unittests/basic_string_view/operations/find/char/3.cc:
3243         Likewise.
3244         * unittests/basic_string_view/operations/find/char/4.cc:
3245         Likewise.
3246         * unittests/basic_string_view/operations/rfind/char/1.cc:
3247         Likewise.
3248         * unittests/basic_string_view/operations/rfind/char/2.cc:
3249         Likewise.
3250         * unittests/basic_string_view/operations/rfind/char/3.cc:
3251         Likewise.
3252         * unittests/basic_string_view/operations/substr/char/1.cc:
3253         Likewise.
3254         * unittests/basic_string_view/operators/char/2.cc: Likewise.
3255         * unittests/string_view-selftests.c: New file.
3256
3257 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3258
3259         * unittests/basic_string_view/capacity/1.cc: New file.
3260         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
3261         * unittests/basic_string_view/cons/char/1.cc: New file.
3262         * unittests/basic_string_view/cons/char/2.cc: New file.
3263         * unittests/basic_string_view/cons/char/3.cc: New file.
3264         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
3265         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
3266         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
3267         * unittests/basic_string_view/element_access/char/1.cc: New file.
3268         * unittests/basic_string_view/element_access/char/2.cc: New file.
3269         * unittests/basic_string_view/element_access/char/empty.cc: New file.
3270         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
3271         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
3272         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
3273         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
3274         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
3275         * unittests/basic_string_view/include.cc: New file.
3276         * unittests/basic_string_view/inserters/char/1.cc: New file.
3277         * unittests/basic_string_view/inserters/char/2.cc: New file.
3278         * unittests/basic_string_view/inserters/char/3.cc: New file.
3279         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
3280         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
3281         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
3282         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
3283         * unittests/basic_string_view/literals/types.cc: New file.
3284         * unittests/basic_string_view/literals/values.cc: New file.
3285         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
3286         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
3287         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
3288         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
3289         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
3290         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
3291         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
3292         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
3293         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
3294         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
3295         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
3296         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
3297         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
3298         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
3299         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
3300         * unittests/basic_string_view/operations/data/char/1.cc: New file.
3301         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
3302         * unittests/basic_string_view/operations/find/char/1.cc: New file.
3303         * unittests/basic_string_view/operations/find/char/2.cc: New file.
3304         * unittests/basic_string_view/operations/find/char/3.cc: New file.
3305         * unittests/basic_string_view/operations/find/char/4.cc: New file.
3306         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
3307         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
3308         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
3309         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
3310         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
3311         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
3312         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
3313         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
3314         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
3315         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
3316         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
3317         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
3318         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
3319         * unittests/basic_string_view/operators/char/2.cc: New file.
3320         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
3321         * unittests/basic_string_view/range_access/char/1.cc: New file.
3322         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
3323         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
3324         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
3325         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
3326         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
3327         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
3328         * unittests/basic_string_view/requirements/typedefs.cc: New file.
3329         * unittests/basic_string_view/typedefs.cc: New file.
3330         * unittests/basic_string_view/types/1.cc: New file.
3331
3332 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3333
3334         * common/gdb_string_view.h: Remove libstdc++ implementation
3335         details, adjust to gdb reality.
3336         * common/gdb_string_view.tcc: Likewise.
3337         * cli/cli-script.c (struct string_view): Remove.
3338         (user_args) <m_args>: Change element type to gdb::string_view.
3339         (user_args::insert_args): Adjust.
3340
3341 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3342
3343         * common/gdb_string_view.h: New file.
3344         * common/gdb_string_view.tcc: New file.
3345
3346 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3347
3348         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
3349         * configure: Re-generate.
3350
3351 2018-04-09  Pedro Alves  <palves@redhat.com>
3352
3353         * gdbarch.sh: Include "observable.h" instead of "observer.h".
3354         (set_target_gdbarch): Call
3355         gdb::observers::architecture_changed.notify instead of
3356         observer_notify_architecture_changed.
3357
3358 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3359
3360         * tracepoint.c (struct current_traceframe_cleanup): Remove.
3361         (do_restore_current_traceframe_cleanup): Remove.
3362         (restore_current_traceframe_cleanup_dtor): Remove.
3363         (make_cleanup_restore_current_traceframe): Remove.
3364         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
3365         New.
3366         * tracepoint.h (struct scoped_restore_current_traceframe): New.
3367         * infrun.c (fetch_inferior_event): Use
3368         scoped_restore_current_traceframe.
3369
3370 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3371
3372         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
3373         Remove.
3374         <n_allocated_type_units>: Remove.
3375         <all_type_units>: Change to std::vector.
3376         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3377         to std::vector change.
3378         (dwarf2_per_objfile::get_cutu): Likewise.
3379         (dwarf2_per_objfile::get_tu): Likewise.
3380         (create_signatured_type_table_from_index): Likewise.
3381         (create_signatured_type_table_from_debug_names): Likewise.
3382         (dw2_symtab_iter_next): Likewise.
3383         (dw2_print_stats): Likewise.
3384         (dw2_expand_all_symtabs): Likewise.
3385         (dw2_expand_marked_cus): Likewise.
3386         (dw2_debug_names_iterator::next): Likewise.
3387         (dwarf2_initialize_objfile): Likewise.
3388         (add_signatured_type_cu_to_table): Likewise.
3389         (create_all_type_units): Likewise.
3390         (add_type_unit): Likewise.
3391         (struct tu_abbrev_offset): Add constructor.
3392         (build_type_psymtabs_1): Adjust to std::vector change.
3393         (print_tu_stats): Likewise.
3394         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3395         (write_debug_names): Likewise.
3396
3397 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3398
3399         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
3400         Make an std::vector.
3401         <n_comp_units>: Remove.
3402         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3403         to std::vector change.
3404         (dwarf2_per_objfile::get_cutu): Likewise.
3405         (dwarf2_per_objfile::get_cu): Likewise.
3406         (create_cus_from_index): Likewise.
3407         (create_addrmap_from_index): Likewise.
3408         (create_addrmap_from_aranges): Likewise.
3409         (dwarf2_read_index): Likewise.
3410         (dw2_find_last_source_symtab): Likewise.
3411         (dw2_map_symtabs_matching_filename): Likewise.
3412         (dw2_symtab_iter_next): Likewise.
3413         (dw2_print_stats): Likewise.
3414         (dw2_expand_all_symtabs): Likewise.
3415         (dw2_expand_symtabs_with_fullname): Likewise.
3416         (dw2_expand_marked_cus): Likewise.
3417         (dw2_map_symbol_filenames): Likewise.
3418         (create_cus_from_debug_names): Likewise.
3419         (dwarf2_read_debug_names): Likewise.
3420         (dw2_debug_names_iterator::next): Likewise.
3421         (dwarf2_initialize_objfile): Likewise.
3422         (set_partial_user): Likewise.
3423         (dwarf2_build_psymtabs_hard): Likewise.
3424         (read_comp_units_from_section): Remove arguments, adjust to
3425         std::vector change.
3426         (create_all_comp_units): Adjust to std::vector and
3427         read_comp_units_from_section changes.
3428         (dwarf2_find_containing_comp_unit): Adjust to std::vector
3429         change.
3430         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3431         (psyms_seen_size): Likewise.
3432         (write_gdbindex): Likewise.
3433         (write_debug_names): Likewise.
3434
3435 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3436
3437         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
3438         with dwarf2_per_objfile.
3439         (create_cus_from_index): Likewise.
3440         (create_signatured_type_table_from_index): Likewise.
3441         (dwarf2_read_index): Likewise.
3442         (dwarf2_initialize_objfile): Likewise.
3443         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
3444         per_cu rather than get_dwarf2_per_objfile.
3445
3446 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3447
3448         * dwarf2read.h (struct signatured_type): Forward declare.
3449         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
3450         New methods.
3451         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
3452         (dw2_get_cutu): ...this.
3453         (dwarf2_per_objfile::get_cu): Rename from...
3454         (dw2_get_cu): ...this.
3455         (dwarf2_per_objfile::get_tu): New.
3456         (create_addrmap_from_index): Adjust.
3457         (create_addrmap_from_aranges): Adjust.
3458         (dw2_find_last_source_symtab): Adjust.
3459         (dw2_map_symtabs_matching_filename): Adjust.
3460         (dw2_symtab_iter_next): Adjust.
3461         (dw2_print_stats): Adjust.
3462         (dw2_expand_all_symtabs): Adjust.
3463         (dw2_expand_symtabs_with_fullname): Adjust.
3464         (dw2_expand_marked_cus): Adjust.
3465         (dw_expand_symtabs_matching_file_matcher): Adjust.
3466         (dw2_map_symbol_filenames): Adjust.
3467         (dw2_debug_names_iterator::next): Adjust.
3468         (dwarf2_initialize_objfile): Adjust.
3469         (set_partial_user): Adjust.
3470         (dwarf2_build_psymtabs_hard): Adjust.
3471
3472 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3473
3474         * dwarf2read.c (create_signatured_type_table_from_debug_names):
3475         Remove unused variables.
3476         (dw2_map_symtabs_matching_filename): Likewise.
3477         (dwarf2_record_block_ranges): Likewise.
3478         (dwarf2_read_addr_index): Likewise.
3479         (follow_die_offset): Likewise.
3480
3481 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3482
3483         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
3484         to symbol_file_add_main.
3485
3486 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3487
3488         PR mi/22299
3489         * mi/mi-console.c (do_fputc_async_safe): New.
3490         (mi_console_file::write_async_safe): New.
3491         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
3492         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
3493         New.
3494         * ui-file.c (ui_file::putstrn): Adjust call to
3495         fputstrn_unfiltered.
3496         * utils.c (printchar): Replace do_fputs and do_fprintf
3497         parameters by do_fputc.
3498         (fputstr_filtered): Adjust call to printchar.
3499         (fputstr_unfiltered): Likewise.
3500         (fputstrn_filtered): Likewise.
3501         (fputstrn_unfiltered): Add do_fputc parameter, pass to
3502         printchar.
3503         * utils.h (do_fputc_ftype): New typedef.
3504         (fputstrn_unfiltered): Add do_fputc parameter.
3505
3506 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3507
3508         * regformats/i386/i386-avx.dat: Remove.
3509
3510 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3511
3512         PR gdb/22979
3513         * amd64-tdep.c (amd64_none_init_abi): New function.
3514         (amd64_x32_none_init_abi): New function.
3515         (_initialize_amd64_tdep): Register handlers for x86-64 and
3516         x64_32 with GDB_OSABI_NONE.
3517         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
3518         GDB_OSABI_NONE osabi.
3519
3520 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3521
3522         PR gdb/22980
3523         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
3524         GDB_OSABI_NONE.
3525         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
3526         * osabi.c (gdb_osabi_names): Add "unknown" entry.
3527
3528 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3529
3530         * common/byte-vector.h (char_vector): New type.
3531         * target.h (target_read_alloc): Return
3532         gdb::optional<byte_vector>.
3533         (target_read_stralloc): Return gdb::optional<char_vector>.
3534         (target_get_osdata): Return gdb::optional<char_vector>.
3535         * target.c (target_read_alloc_1): Templatize.  Replacement
3536         manual memory management with vector.
3537         (target_read_alloc): Change return type, adjust.
3538         (target_read_stralloc): Change return type, adjust.
3539         (target_get_osdata): Change return type, adjust.
3540         * auxv.c (struct auxv_info) <length>: Remove.
3541         <data>: Change type to gdb::optional<byte_vector>.
3542         (auxv_inferior_data_cleanup): Free auxv_info with delete.
3543         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
3544         (target_auxv_search): Adjust.
3545         (fprint_target_auxv): Adjust.
3546         * avr-tdep.c (avr_io_reg_read_command): Adjust.
3547         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
3548         (linux_make_corefile_notes): Adjust.
3549         * osdata.c (get_osdata): Adjust.
3550         * remote.c (remote_get_threads_with_qxfer): Adjust.
3551         (remote_memory_map): Adjust.
3552         (remote_traceframe_info): Adjust.
3553         (btrace_read_config): Adjust.
3554         (remote_read_btrace): Adjust.
3555         (remote_pid_to_exec_file): Adjust.
3556         * solib-aix.c (solib_aix_get_library_list): Adjust.
3557         * solib-dsbt.c (decode_loadmap): Don't free buf.
3558         (dsbt_get_initial_loadmaps): Adjust.
3559         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
3560         * solib-target.c (solib_target_current_sos): Adjust.
3561         * tracepoint.c (sdata_make_value): Adjust.
3562         * xml-support.c (xinclude_start_include): Adjust.
3563         (xml_fetch_content_from_file): Adjust.
3564         * xml-support.h (xml_fetch_another): Change return type.
3565         (xml_fetch_content_from_file): Change return type.
3566         * xml-syscall.c (xml_init_syscalls_info): Adjust.
3567         * xml-tdesc.c (file_read_description_xml): Adjust.
3568         (fetch_available_features_from_target): Change return type.
3569         (target_fetch_description_xml): Adjust.
3570         (target_read_description_xml): Adjust.
3571
3572 2018-04-06  Tom Tromey  <tom@tromey.com>
3573
3574         * value.c (~value): Update.
3575         (struct value) <contents>: Now unique_xmalloc_ptr.
3576         (value_contents_bits_eq, allocate_value_contents)
3577         (value_contents_raw, value_contents_all_raw)
3578         (value_contents_for_printing, value_contents_for_printing_const)
3579         (set_value_enclosing_type): Update.
3580
3581 2018-04-06  Tom Tromey  <tom@tromey.com>
3582
3583         * value.c (range_s): Remove typedef, VEC.
3584         (struct range): Add operator<.
3585         (range_lessthan): Remove.
3586         (ranges_contain): Change type.
3587         (~value): Update.
3588         (struct value) <unavailable, optimized_out>: Now std::vector.
3589         (value_entirely_available)
3590         (value_entirely_covered_by_range_vector)
3591         (value_entirely_unavailable, value_entirely_optimized_out):
3592         Update.
3593         (insert_into_bit_range_vector): Change argument type.
3594         (find_first_range_overlap): Likewise.
3595         (struct ranges_and_idx, value_contents_bits_eq)
3596         (require_not_optimized_out, require_available): Update.
3597         (ranges_copy_adjusted): Change argument types.
3598         (value_optimized_out, value_copy, value_fetch_lazy): Update.
3599
3600 2018-04-06  Tom Tromey  <tom@tromey.com>
3601
3602         * value.c (~value): Update.
3603         (struct value) <parent>: Now a value_ref_ptr.
3604         (value_parent, set_value_parent, value_address, value_copy):
3605         Update.
3606
3607 2018-04-06  Tom Tromey  <tom@tromey.com>
3608
3609         * value.c (struct value): Add constructor, destructor, and member
3610         initializers.
3611         (allocate_value_lazy, value_decref): Update.
3612
3613 2018-04-06  Tom Tromey  <tom@tromey.com>
3614
3615         * value.c (struct value) <released, next>: Remove.
3616         (all_values): Now a std::vector.
3617         (allocate_value_lazy): Update.
3618         (value_next): Remove.
3619         (value_mark, value_free_to_mark, release_value)
3620         (value_release_to_mark): Update.
3621
3622 2018-04-06  Tom Tromey  <tom@tromey.com>
3623
3624         * value.h (fetch_subexp_value, value_release_to_mark): Update.
3625         (free_value_chain): Remove.
3626         * value.c (free_value_chain): Remove.
3627         (value_release_to_mark): Return a std::vector.
3628         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
3629         std::vector.
3630         (check_condition): Update.
3631         * eval.c (fetch_subexp_value): Change "val_chain" to a
3632         std::vector.
3633         * breakpoint.c (update_watchpoint): Update.
3634         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
3635
3636 2018-04-06  Tom Tromey  <tom@tromey.com>
3637
3638         * value.h (free_all_values): Remove.
3639         * value.c (free_all_values): Remove.
3640
3641 2018-04-06  Tom Tromey  <tom@tromey.com>
3642
3643         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
3644         (value_history_chain, value_history_count): Remove.
3645         (value_history): New global.
3646         (record_latest_value, access_value_history, show_values)
3647         (preserve_values): Update.
3648
3649 2018-04-06  Tom Tromey  <tom@tromey.com>
3650
3651         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
3652         * varobj.c (varobj_set_display_format, varobj_set_value)
3653         (install_default_visualizer, construct_visualizer)
3654         (install_new_value, ~varobj, varobj_get_value_type)
3655         (my_value_of_variable, varobj_editable_p): Update.
3656         * c-varobj.c (c_describe_child, c_value_of_variable)
3657         (cplus_number_of_children, cplus_describe_child): Update.
3658         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
3659         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
3660         (ada_value_of_variable, ada_value_is_changeable_p): Update.
3661
3662 2018-04-06  Tom Tromey  <tom@tromey.com>
3663
3664         * printcmd.c (last_examine_address): Change type to
3665         value_ref_ptr.
3666         (do_examine, x_command): Update.
3667
3668 2018-04-06  Tom Tromey  <tom@tromey.com>
3669
3670         * value.c (release_value): Update.
3671         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
3672         (struct bpstats) <val>: Now a value_ref_ptr.
3673         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
3674         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
3675         (~watchpoint, print_it_watchpoint, watch_command_1)
3676         (invalidate_bp_value_on_memory_change): Update.
3677
3678 2018-04-06  Tom Tromey  <tom@tromey.com>
3679
3680         * varobj.c (varobj_clear_saved_item)
3681         (update_dynamic_varobj_children, install_new_value, ~varobj):
3682         Update.
3683         * value.h (value_incref): Move declaration earlier.
3684         (value_decref): Rename from value_free.
3685         (struct value_ref_policy): New.
3686         (value_ref_ptr): New typedef.
3687         (struct value_deleter): Remove.
3688         (gdb_value_up): Remove typedef.
3689         (release_value): Change return type.
3690         (release_value_or_incref): Remove.
3691         * value.c (set_value_parent): Update.
3692         (value_incref): Change return type.
3693         (value_decref): Rename from value_free.
3694         (value_free_to_mark, free_all_values, free_value_chain): Update.
3695         (release_value): Return value_ref_ptr.
3696         (release_value_or_incref): Remove.
3697         (record_latest_value, set_internalvar, clear_internalvar):
3698         Update.
3699         * stack.c (info_frame_command): Don't call value_free.
3700         * python/py-value.c (valpy_dealloc, valpy_new)
3701         (value_to_value_object): Update.
3702         * printcmd.c (do_examine): Update.
3703         * opencl-lang.c (lval_func_free_closure): Update.
3704         * mi/mi-main.c (register_changed_p): Don't call value_free.
3705         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
3706         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
3707         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
3708         value_free.
3709         * guile/scm-value.c (vlscm_free_value_smob)
3710         (vlscm_scm_from_value): Update.
3711         * frame.c (frame_register_unwind, frame_unwind_register_signed)
3712         (frame_unwind_register_unsigned, get_frame_register_bytes)
3713         (put_frame_register_bytes): Don't call value_free.
3714         * findvar.c (address_from_register): Don't call value_free.
3715         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
3716         * dwarf2loc.c (entry_data_value_free_closure)
3717         (value_of_dwarf_reg_entry, free_pieced_value_closure)
3718         (dwarf2_evaluate_loc_desc_full): Update.
3719         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
3720         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
3721         (~watchpoint, watch_command_1)
3722         (invalidate_bp_value_on_memory_change): Update.
3723         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
3724
3725 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
3726
3727         PR gdb/23022
3728         * warning.m4: Add -Wno-error=deprecated-register.
3729         * configure: Re-generate.
3730
3731 2018-04-05  Tom Tromey  <tom@tromey.com>
3732
3733         * linespec.h: Remove include of "vec.h".
3734
3735 2018-04-05  Tom Tromey  <tom@tromey.com>
3736
3737         * linespec.c (typep): Remove typedef.
3738         (find_methods, find_superclass_methods): Take a std::vector.
3739         (find_method): Use std::vector.
3740
3741 2018-04-05  Tom Tromey  <tom@tromey.com>
3742
3743         * utils.c (compare_strings): Remove.
3744         * utils.h (compare_strings): Remove.
3745         * objc-lang.h (find_imps): Update.
3746         * objc-lang.c (find_methods): Take a std::vector.
3747         (uniquify_strings, find_imps): Likewise.
3748         * linespec.c (find_methods): Take a std::vector.
3749         (decode_objc): Use std::vector.
3750         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
3751         a std::vector.
3752         (find_method, find_function_symbols): Use std::vector.
3753
3754 2018-04-05  Tom Tromey  <tom@tromey.com>
3755
3756         * completer.c (completion_tracker::completion_tracker): Remove
3757         cast.
3758         (completion_tracker::discard_completions): Likewise.
3759         * breakpoint.c (ambiguous_names_p): Remove cast.
3760         * ada-lang.c (_initialize_ada_language): Remove cast.
3761         * utils.h (streq): Update.
3762         (streq_hash): Add new declaration.
3763         * utils.c (streq): Return bool.
3764         (streq_hash): New function.
3765
3766 2018-04-05  Tom Tromey  <tom@tromey.com>
3767
3768         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
3769         Remove a string copy.
3770
3771 2018-04-05  Tom Tromey  <tom@tromey.com>
3772
3773         * linespec.c (filter_results): Use std::vector.
3774         (decode_line_2, decode_line_full): Update.
3775
3776 2018-04-05  Tom Tromey  <tom@tromey.com>
3777
3778         * linespec.c (canonical_to_fullform): Return std::string.
3779         (filter_results): Update.
3780         (struct decode_line_2_item): Add constructor.
3781         <fullform, displayform>: Now std::string.
3782         (decode_line_2_compare_items): Now a std::sort comparator.
3783         (decode_line_2): Update.
3784
3785 2018-04-05  Tom Tromey  <tom@tromey.com>
3786
3787         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
3788         (unexpected_linespec_error): Update.
3789         (linespec_parse_basic, parse_linespec): Update.
3790
3791 2018-04-05  Tom Tromey  <tom@tromey.com>
3792
3793         * linespec.c (linespec_parse_basic): Reindent.
3794
3795 2018-04-05  Tom Tromey  <tom@tromey.com>
3796
3797         * minsyms.h (iterate_over_minimal_symbols): Update.
3798         * minsyms.c (iterate_over_minimal_symbols): Take a
3799         gdb::function_view.
3800         * linespec.c (struct collect_minsyms): Remove.
3801         (compare_msyms): Now a std::sort comparator.
3802         (add_minsym): Add parameters.
3803         (search_minsyms_for_name): Update.  Use std::vector.
3804
3805 2018-04-03  Tom Tromey  <tom@tromey.com>
3806
3807         * mipsread.c (read_alphacoff_dynamic_symtab): Use
3808         gdb::byte_vector.
3809
3810 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
3811
3812         * MAINTAINERS (Write After Approval): Add Weimin Pan.
3813
3814 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
3815
3816         PR gdb/16959
3817         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when
3818         printing static type.
3819
3820 2018-04-01  Tom Tromey  <tom@tromey.com>
3821
3822         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
3823         (rs6000_xfer_shared_libraries): Update.
3824
3825 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
3826
3827         * common/gdb_vecs.h (char_ptr): Remove.
3828         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
3829
3830 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
3831
3832         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
3833         with std::vector.
3834         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
3835
3836 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
3837
3838         * tracepoint.h (struct uploaded_tp): Initialize fields.
3839         <actions, step_actions, cmd_strings>: Change type to
3840         std::vector<char *>.
3841         * tracepoint.c (get_uploaded_tp): Allocate with new.
3842         (free_uploaded_tps): Free with delete.
3843         (parse_tracepoint_definition): Adjust to std::vector change.
3844         * breakpoint.c (read_uploaded_action): Likewise.
3845         (create_tracepoint_from_upload): Likewise.
3846         * ctf.c (ctf_write_uploaded_tp): Likewise.
3847         (SET_ARRAY_FIELD): Likewise.
3848         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
3849
3850 2018-03-30  Tom Tromey  <tom@tromey.com>
3851
3852         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
3853         std::unique_ptr.
3854         (svr4_keep_data_in_core): Update.
3855         (svr4_read_so_list): Update.
3856
3857 2018-03-30  Tom Tromey  <tom@tromey.com>
3858
3859         * windows-nat.c (handle_output_debug_string, handle_exception):
3860         Update.
3861         * target.h (target_read_string): Update.
3862         * target.c (target_read_string): Change "string" to
3863         unique_xmalloc_ptr.
3864         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
3865         Update.
3866         * solib-frv.c (frv_current_sos): Update.
3867         * solib-dsbt.c (dsbt_current_sos): Update.
3868         * solib-darwin.c (darwin_current_sos): Update.
3869         * linux-thread-db.c (inferior_has_bug): Update.
3870         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
3871         Update.  Remove alloca.
3872         * ada-lang.c (ada_main_name): Update.
3873
3874 2018-03-30  Tom Tromey  <tom@tromey.com>
3875
3876         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
3877         (struct dwo_file_deleter): New.
3878         (dwo_file_up): New typedef.
3879         (open_and_init_dwo_file): Use dwo_file_up.
3880         (free_dwo_file_cleanup): Remove.
3881
3882 2018-03-30  Tom Tromey  <tom@tromey.com>
3883
3884         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
3885         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
3886
3887 2018-03-30  Tom Tromey  <tom@tromey.com>
3888
3889         * dwarf2read.c (class free_cached_comp_units): New class.
3890         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
3891         (free_cached_comp_units): Remove function.
3892
3893 2018-03-30  Tom Tromey  <tom@tromey.com>
3894
3895         * utils.h (make_cleanup_unpush_target): Remove.
3896         * inf-ptrace.c (struct target_unpusher): New.
3897         (target_unpush_up) New typedef.
3898         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
3899         target_unpush_up.
3900         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
3901
3902 2018-03-27  Tom Tromey  <tom@tromey.com>
3903
3904         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
3905
3906 2018-03-27  Pedro Alves  <palves@redhat.com>
3907             Tom Tromey  <tom@tromey.com>
3908
3909         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
3910         destructor.  Now a class.
3911         (gdb_readline_wrapper_cleanup): Remove function.
3912         (gdb_readline_wrapper): Remove cleanups.
3913
3914 2018-03-27  Tom Tromey  <tom@tromey.com>
3915
3916         * typeprint.h (struct type_print_options) <local_typedefs,
3917         global_typedefs>: Remove "struct" keyword.
3918         (class typedef_hash_table): New class.
3919         (recursively_update_typedef_hash, add_template_parameters)
3920         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
3921         (find_typedef_in_hash): Don't declare.
3922         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
3923         (typedef_hash_table::recursively_update): Rename from
3924         recursively_update_typedef_hash.  Now a member.
3925         (typedef_hash_table::add_template_parameters): Rename from
3926         add_template_parameters.  Now a member.
3927         (typedef_hash_table::typedef_hash_table): Now a constructor;
3928         rename from create_typedef_hash.
3929         (typedef_hash_table::~typedef_hash_table): Now a destructor;
3930         rename from free_typedef_hash.
3931         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
3932         (do_free_global_table): Remove.
3933         (typedef_hash_table::typedef_hash_table): New constructor; renamed
3934         from copy_type_recursive.
3935         (create_global_typedef_table): Remove.
3936         (typedef_hash_table::find_global_typedef): Now a member of
3937         typedef_hash_table.
3938         (typedef_hash_table::find_typedef): Rename from
3939         find_typedef_in_hash; now a member.
3940         (whatis_exp): Update.
3941         * extension.h (struct ext_lang_type_printers): Add constructor and
3942         destructor.
3943         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
3944         declare.
3945         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
3946         Now a constructor; rename from start_ext_lang_type_printers.
3947         (ext_lang_type_printers): Now a destructor; rename from
3948         free_ext_lang_type_printers.
3949         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
3950         Update.
3951         (c_type_print_base_struct_union): Update.  Remove cleanups.
3952
3953 2018-03-27  Tom Tromey  <tom@tromey.com>
3954
3955         * dwarf-index-write.c: Include <cmath>.
3956
3957 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
3958
3959         * NEWS: Add entry describing new "set|show varsize-limit" command.
3960         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
3961         command.
3962         * printcmd.c (_initialize_printcmd): Add "set var" alias of
3963         "set variable".
3964
3965 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
3966
3967         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
3968         dwarf-index-write.c
3969         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
3970         * dwarf-index-common.c: New file.
3971         * dwarf-index-common.h: New file.
3972         * dwarf-index-write.c: New file.
3973         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
3974         (struct dwarf2_section_info): Move from here.
3975         (dwarf2_section_info_def): Likewise.
3976         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
3977         (offset_type): Likewise.
3978         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
3979         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
3980         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
3981         (byte_swap): Likewise.
3982         (MAYBE_SWAP): Likewise.
3983         (dwarf2_per_cu_ptr): Likewise.
3984         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
3985         (struct tu_stats): Likewise.
3986         (struct dwarf2_per_objfile): Likewise.
3987         (struct dwarf2_per_cu_data): Likewise.
3988         (struct signatured_type): Likewise.
3989         (sig_type_ptr): Likewise.
3990         (DEF_VEC_P (sig_type_ptr)): Likewise.
3991         (INDEX4_SUFFIX): Likewise.
3992         (INDEX5_SUFFIX): Likewise.
3993         (DEBUG_STR_SUFFIX): Likewise.
3994         (dwarf2_read_section): Make non-static.
3995         (mapped_index_string_hash): Move from here.
3996         (dwarf5_djb_hash): Likewise.
3997         (file_write): Likewise.
3998         (class data_buf): Likewise.
3999         (struct symtab_index_entry): Likewise.
4000         (struct mapped_symtab): Likewise.
4001         (find_slot): Likewise.
4002         (hash_expand): Likewise.
4003         (add_index_entry): Likewise.
4004         (uniquify_cu_indices): Likewise.
4005         (class c_str_view): Likewise.
4006         (class c_str_view_hasher): Likewise.
4007         (class vector_hasher): Likewise.
4008         (write_hash_table): Likewise.
4009         (psym_index_map): Likewise.
4010         (struct addrmap_index_data): Likewise.
4011         (add_address_entry): Likewise.
4012         (add_address_entry_worker): Likewise.
4013         (write_address_map): Likewise.
4014         (symbol_kind): Likewise.
4015         (write_psymbols): Likewise.
4016         (struct signatured_type_index_data): Likewise.
4017         (write_one_signatured_type): Likewise.
4018         (recursively_count_psymbols): Likewise.
4019         (recursively_write_psymbols): Likewise.
4020         (class debug_names): Likewise.
4021         (check_dwarf64_offsets): Likewise.
4022         (psyms_seen_size): Likewise.
4023         (write_gdbindex): Likewise.
4024         (write_debug_names): Likewise.
4025         (assert_file_size): Likewise.
4026         (write_psymtabs_to_index): Likewise.
4027         (save_gdb_index_command): Likewise.
4028         (_initialize_dwarf2_read): Don't register the "save gdb-index"
4029         command.
4030         * dwarf2read.h: New file.
4031
4032 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4033
4034         PR gdb/22670
4035         * dwarf2read.c (dwarf2_physname): Do not return the demangled
4036         symbol name if the CU's language stores symbol names in linkage
4037         format.
4038         * language.h (struct language_defn)
4039         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
4040         all instances of this struct.
4041
4042 2018-03-26  Tom Tromey  <tom@tromey.com>
4043
4044         * stack.c (backtrace_command_1): Remove verbose code.
4045
4046 2018-03-26  Tom Tromey  <tom@tromey.com>
4047
4048         * python/py-framefilter.c (py_print_type): Don't catch
4049         exceptions.  Return void.
4050         (py_print_value): Likewise.
4051         (py_print_single_arg): Likewise.
4052         (enumerate_args): Don't catch exceptions.
4053         (py_print_args): Likewise.
4054         (py_print_frame): Likewise.
4055         (gdbpy_apply_frame_filter): Catch exceptions here.
4056
4057 2018-03-26  Tom Tromey  <tom@tromey.com>
4058
4059         * stack.c (_initialize_stack): Remove trailing newlines from help
4060         text.  Add "Usage" line to "backtrace" help.
4061
4062 2018-03-26  Tom Tromey  <tom@tromey.com>
4063
4064         PR python/16486:
4065         * python/py-framefilter.c (py_print_args): Call wrap_hint.
4066
4067 2018-03-26  Tom Tromey  <tom@tromey.com>
4068
4069         * python/py-framefilter.c (py_print_single_arg): Return
4070         EXT_LANG_BT_ERROR from catch.
4071
4072 2018-03-26  Tom Tromey  <tom@tromey.com>
4073
4074         PR backtrace/15584:
4075         * stack.c (backtrace_command_1): Move some code into no-filters
4076         "if".
4077
4078 2018-03-26  Tom Tromey  <tom@tromey.com>
4079
4080         * python/py-framefilter.c (throw_quit_or_print_exception): New
4081         function.
4082         (gdbpy_apply_frame_filter): Use it.
4083
4084 2018-03-26  Tom Tromey  <tom@tromey.com>
4085
4086         PR cli/17716:
4087         * python/py-framefilter.c (py_print_type, py_print_value)
4088         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
4089         RETURN_MASK_ERROR.
4090
4091 2018-03-26  Tom Tromey  <tom@tromey.com>
4092
4093         * python/py-framefilter.c (enumerate_args): Use
4094         gdb::unique_xmalloc_ptr.
4095
4096 2018-03-26  Tom Tromey  <tom@tromey.com>
4097
4098         * python/py-framefilter.c (py_print_frame): Return
4099         EXT_LANG_BT_OK.
4100         (gdbpy_apply_frame_filter): Update comment.
4101         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
4102         Remove.
4103         <EXT_LANG_BT_NO_FILTERS>: Change value.
4104
4105 2018-03-26  Tom Tromey  <tom@tromey.com>
4106
4107         PR backtrace/15582:
4108         * stack.c (backtrace_command): Parse "hide" argument.
4109         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
4110         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
4111         constant.
4112
4113 2018-03-26  Tom Tromey  <tom@tromey.com>
4114
4115         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
4116         add "flags".
4117         (backtrace_command): Remove "fulltrace", add "flags".
4118
4119 2018-03-26  Tom Tromey  <tom@tromey.com>
4120
4121         * stack.c (backtrace_command): Rewrite command line parsing.
4122
4123 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4124
4125         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
4126
4127 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4128
4129         * filename-seen-cache.h: Add include guard.
4130
4131 2018-03-26  Keith Seitz  <keiths@redhat.com>
4132
4133         * symfile.c (place_section): Remove "struct" from section_addr_info
4134         in comment.
4135         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
4136         "struct" keyword from section_addr_info.
4137
4138 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
4139
4140         * regformats/regdef.h (reg): Add constructors.
4141
4142 2018-03-25  Pedro Alves  <palves@redhat.com>
4143
4144         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
4145         if then/else bodies in var_func_name extraction.
4146
4147 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
4148
4149         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
4150         lookup_minimal_symbol() to find symbol entry.
4151         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
4152
4153 2018-03-23  Keith Seitz  <keiths@redhat.com>
4154
4155         PR c++/22968
4156         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
4157         nested type definitions for C++, too.
4158
4159 2018-03-23  Tom Tromey  <tom@tromey.com>
4160
4161         * machoread.c (struct oso_el): Add a constructor.  Don't define as
4162         a typedef.
4163         (macho_register_oso): Remove.
4164         (macho_symtab_read): Take a std::vector.
4165         (oso_el_compare_name): Now a std::sort comparator.
4166         (macho_symfile_read_all_oso): Take a std::vector.
4167         (macho_symfile_read): Use std::vector.  Remove cleanups.
4168
4169 2018-03-22  Tom Tromey  <tom@tromey.com>
4170
4171         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
4172         (record_full_goto_bookmark): Use std::string.
4173
4174 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4175
4176         PR tdep/18295
4177         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
4178         a single mask.
4179
4180 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4181
4182         * rs6000-tdep.c (store_insn_p): New function.
4183         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
4184         and cr_reg to their unshifted values. Use store_insn_p to
4185         match LR saves using either R1 or fdata->alloca_reg. Use
4186         store_insn_p to match CR saves. Set alloca_reg_offset
4187         when alloca_reg and framep are set. Remove lr_reg shift
4188         when assigning to fdata->lr_register.
4189
4190 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4191
4192         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
4193         command line args instead of emitting a warning.
4194
4195 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4196
4197         * tracepoint.h (struct static_tracepoint_marker): Initialize
4198         fields, define default constructor, move constructor and move
4199         assignment, disable the rest.
4200         <str_id, extra>: Make std::string.
4201         (release_static_tracepoint_marker): Remove.
4202         (free_current_marker): Remove.
4203         * tracepoint.c (free_current_marker): Remove.
4204         (parse_static_tracepoint_marker_definition): Adjust to
4205         std::string, use new hex2str overload.
4206         (release_static_tracepoint_marker): Remove.
4207         (print_one_static_tracepoint_marker): Get marker by reference
4208         and adjust to std::string.
4209         (info_static_tracepoint_markers_command): Adjust to std::vector
4210         changes
4211         * target.h (static_tracepoint_marker_p): Remove typedef.
4212         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
4213         (struct target_ops) <to_static_tracepoint_marker_at>: Return
4214         bool.
4215         <to_static_tracepoint_markers_by_strid>: Return std::vector.
4216         * target-debug.h
4217         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
4218         (target_debug_print_std_vector_static_tracepoint_marker): New.
4219         (target_debug_print_struct_static_tracepoint_marker_p): Rename
4220         to...
4221         (target_debug_print_static_tracepoint_marker_p): ... this.
4222         * target-delegates.c: Re-generate.
4223         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
4224         Make std::string.
4225         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
4226         (decode_static_tracepoint_spec): Adjust to std::vector.
4227         (tracepoint_print_one_detail): Adjust to std::string.
4228         (strace_marker_decode_location): Adjust to std::string.
4229         (update_static_tracepoint): Adjust to std::string, remove call
4230         to release_static_tracepoint_marker.
4231         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
4232         Adjust to std::vector.
4233         * remote.c (remote_static_tracepoint_marker_at): Return bool.
4234         (remote_static_tracepoint_markers_by_strid): Adjust to
4235         std::vector.
4236         * common/rsp-low.h (hex2str): New overload with explicit count
4237         of bytes.
4238         * common/rsp-low.c (hex2str): New overload with explicit count
4239         of bytes.
4240         * unittests/rsp-low-selftests.c (test_hex2str): New function.
4241         (_initialize_rsp_low_selftests): Add test_hex2str test.
4242         * unittests/tracepoint-selftests.c
4243         (test_parse_static_tracepoint_marker_definition): Adjust to
4244         std::string.
4245
4246 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4247
4248         * tracepoint.c (parse_static_tracepoint_marker_definition):
4249         Consider case where the definition is followed by more
4250         definitions.
4251         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4252         tracepoint-selftests.c.
4253         * unittests/tracepoint-selftests.c: New.
4254
4255 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4256
4257         * MAINTAINERS (Write After Approval): Add Pedro Franco de
4258         Carvalho.
4259
4260 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4261
4262         * symtab.c (find_pc_sect_line): fixed indentation.
4263
4264 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4265
4266         * symtab.c (find_pc_sect_line): now uses binary search.
4267
4268 2018-03-19  Tom Tromey  <tom@tromey.com>
4269
4270         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
4271         "IDENT" production.
4272
4273 2018-03-19  Pedro Alves  <palves@redhat.com>
4274             Tom Tromey  <tom@tromey.com>
4275
4276         * unittests/observable-selftests.c: New file.
4277         * common/observable.h: New file.
4278         * observable.h: New file.
4279         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
4280         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
4281         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
4282         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
4283         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
4284         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
4285         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
4286         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
4287         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
4288         python/py-breakpoint.c, python/py-finishbreakpoint.c,
4289         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
4290         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
4291         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
4292         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
4293         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
4294         tui/tui-interp.c, valops.c: Update all users.
4295         * tui/tui-hooks.c (tui_bp_created_observer)
4296         (tui_bp_deleted_observer, tui_bp_modified_observer)
4297         (tui_inferior_exit_observer, tui_before_prompt_observer)
4298         (tui_normal_stop_observer, tui_register_changed_observer):
4299         Remove.
4300         (tui_observers_token): New global.
4301         (attach_or_detach, tui_attach_detach_observers): New functions.
4302         (tui_install_hooks, tui_remove_hooks): Use
4303         tui_attach_detach_observers.
4304         * record-btrace.c (record_btrace_thread_observer): Remove.
4305         (record_btrace_thread_observer_token): New global.
4306         * observer.sh: Remove.
4307         * observer.c: Rename to observable.c.
4308         * observable.c (namespace gdb_observers): Define new objects.
4309         (observer_debug): Move into gdb_observers namespace.
4310         (struct observer, struct observer_list, xalloc_observer_list_node)
4311         (xfree_observer_list_node, generic_observer_attach)
4312         (generic_observer_detach, generic_observer_notify): Remove.
4313         (_initialize_observer): Update.
4314         Don't include observer.inc.
4315         * Makefile.in (generated_files): Remove observer.h, observer.inc.
4316         (clean mostlyclean): Likewise.
4317         (observer.h, observer.inc): Remove targets.
4318         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
4319         (COMMON_SFILES): Use observable.c, not observer.c.
4320         * .gitignore: Remove observer.h.
4321
4322 2018-03-18  Tom Tromey  <tom@tromey.com>
4323
4324         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
4325         gdb::def_vector.
4326         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
4327
4328 2018-03-17  Tom Tromey  <tom@tromey.com>
4329
4330         * auto-load.c (auto_load_objfile_script_1): Use std::string.
4331
4332 2018-03-17  Tom Tromey  <tom@tromey.com>
4333
4334         * target.c (class scoped_target_fd): New.
4335         (target_fileio_close_cleanup): Remove.
4336         (target_fileio_read_alloc_1): Use scoped_target_fd.
4337
4338 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
4339
4340         * silent-rules.mk: New.
4341         * Makefile.in: Include silent-rules.mk
4342         (srcdir, VPATH, top_srcdir): Move up.
4343         (COMPILE): Add ECHO_CXX.
4344         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
4345         (init.c): Add ECHO_INIT_C.
4346         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
4347         (version.c): Add ECHO_GEN.
4348         (printcmd.o): Add ECHO_CXX.
4349         (target-float.o): Add ECHO_CXX.
4350         (ada-exp.o): Add ECHO_CXX.
4351         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
4352         (insight$(EXEEXT)): Add ECHO_CXXLD.
4353         * gnulib/configure.ac: Add AM_SILENT_RULES.
4354         * gnulib/aclocal.m4: Re-generate.
4355         * gnulib/configure: Re-generate.
4356         * gnulib/import/Makefile.in: Re-generate.
4357
4358 2018-03-16  Tom Tromey  <tom@tromey.com>
4359
4360         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
4361         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
4362         * utils.c (do_free_section_addr_info)
4363         (make_cleanup_free_section_addr_info): Remove.
4364         * symfile.h (struct other_sections): Add constructor.
4365         (struct section_addr_info): Remove.
4366         (section_addr_info): New typedef.
4367         (struct sym_fns) <sym_offsets>: Change type of parameter.
4368         (build_section_addr_info_from_objfile)
4369         (relative_addr_info_to_section_offsets, addr_info_make_relative)
4370         (default_symfile_offsets, symbol_file_add)
4371         (symbol_file_add_from_bfd)
4372         (build_section_addr_info_from_section_table): Update.
4373         (alloc_section_addr_info, free_section_addr_info): Don't declare.
4374         * symfile.c (alloc_section_addr_info): Remove.
4375         (build_section_addr_info_from_section_table): Change return type.
4376         Update.
4377         (build_section_addr_info_from_bfd)
4378         (build_section_addr_info_from_objfile): Likewise.
4379         (free_section_addr_info): Remove.
4380         (relative_addr_info_to_section_offsets): Change type of "addrs".
4381         (addrs_section_compar): Now a std::sort comparator.
4382         (addrs_section_sort): Change return type.
4383         (addr_info_make_relative): Change type of "addrs".  Update.
4384         (default_symfile_offsets, syms_from_objfile_1)
4385         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
4386         (symbol_file_add_separate): Update.
4387         (symbol_file_add): Change type of "addrs".  Update.
4388         (add_symbol_file_command): Update.  Remove cleanups.
4389         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
4390         cleanups.
4391         * symfile-debug.c (debug_sym_offsets): Change type of "info".
4392         * solib.c (solib_read_symbols): Update.
4393         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
4394         * machoread.c (macho_symfile_offsets): Update.
4395         * jit.c (jit_bfd_try_read_symtab): Update.
4396
4397 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
4398
4399         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4400         unittests/utils-selftests.c.
4401         * unittests/utils-selftests.c: New file.
4402
4403 2018-03-14  Tom Tromey  <tom@tromey.com>
4404
4405         PR cli/14977:
4406         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
4407         for NULL.
4408
4409 2018-03-14  Tom Tromey  <tom@tromey.com>
4410
4411         PR cli/19918:
4412         * printcmd.c (printf_pointer): Allow "-" in format.
4413
4414 2018-03-14  Tom Tromey  <tom@tromey.com>
4415
4416         * printcmd.c (_initialize_printcmd): Add usage to printf.
4417
4418 2018-03-14  Yao Qi  <qiyao@sourceware.org>
4419
4420         * MAINTAINERS: Update my email address.
4421
4422 2018-03-13  Tom Tromey  <tom@tromey.com>
4423
4424         * machoread.c (macho_check_dsym): Change filenamep to a
4425         std::string*.
4426         (macho_symfile_read): Update.
4427         * symfile.c (load_command): Use std::string.
4428
4429 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4430
4431         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
4432         to error message string.
4433         (riscv_register_name): Use xsnprintf instead of sprintf.
4434         (riscv_insn::fetch_instruction): Use gdb_assert instead of
4435         internal_error.
4436         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
4437         error.
4438         (riscv_push_dummy_call): Likewise.
4439
4440 2018-03-12  Tom Tromey  <tom@tromey.com>
4441
4442         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
4443         Use gdb::byte_vector.
4444         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
4445
4446 2018-03-12  Yao Qi  <yao.qi@linaro.org>
4447
4448         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
4449         parameter type to readable_regcache.
4450         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
4451         the declaration.
4452
4453 2018-03-11  Tom Tromey  <tom@tromey.com>
4454
4455         * dwarf2read.c (struct nextfield): Add initializers.
4456         (struct nextfnfield): Remove.
4457         (struct fnfieldlist): Add initializers.  Remove "length" and
4458         "head", use std::vector.
4459         (struct decl_field_list): Remove.
4460         (struct field_info): Add initializers.
4461         <fields, baseclasses>: Now std::vector.
4462         <nbaseclasses, nfnfields, typedef_field_list_count,
4463         nested_types_list_count>: Remove.
4464         (dwarf2_add_field, dwarf2_add_type_defn)
4465         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
4466         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
4467         (process_structure_scope): Update.
4468
4469 2018-03-11  Tom Tromey  <tom@tromey.com>
4470
4471         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
4472         for use by std::sort.
4473         (build_type_psymtabs_1): Use std::vector.
4474
4475 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
4476
4477         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
4478         and LIBMPFR in the printed configuration.
4479
4480 2018-03-08  Tom Tromey  <tom@tromey.com>
4481
4482         * source.c (get_filename_and_charpos): Use scoped_fd.
4483         * nto-procfs.c (procfs_open_1): Use scoped_fd.
4484         (procfs_pidlist): Likewise.
4485         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
4486         (iterate_over_mappings): Likewise.
4487
4488 2018-03-08  Tom Tromey  <tom@tromey.com>
4489
4490         * infcall.c (struct call_return_meta_info)
4491         <stack_temporaries_enabled>: Remove.
4492         (get_call_return_value, call_function_by_hand_dummy): Update.
4493         * thread.c (disable_thread_stack_temporaries): Remove.
4494         (enable_thread_stack_temporaries): Remove.
4495         (thread_stack_temporaries_enabled_p): Return bool.
4496         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
4497         (get_last_thread_stack_temporary): Update.
4498         * eval.c (evaluate_subexp): Update.
4499         * gdbthread.h (class enable_thread_stack_temporaries): Now a
4500         class, not a function.
4501         (value_ptr, value_vec): Remove typedefs.
4502         (class thread_info) <stack_temporaries_enabled>: Now bool.
4503         <stack_temporaries>: Now a std::vector.
4504         (thread_stack_temporaries_enabled_p)
4505         (value_in_thread_stack_temporaries): Return bool.
4506
4507 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
4508
4509         * remote.c (putpkt_binary): Fix omitted bytes reporting.
4510         (getpkt_or_notif_sane_1): Likewise.
4511
4512 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4513
4514         * build-id.c (build_id_to_debug_bfd): Use std::string.
4515
4516 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4517
4518         * build-id.c (find_separate_debug_file_by_buildid): Return
4519         std::string.
4520         * build-id.h (find_separate_debug_file_by_buildid): Return
4521         std::string.
4522         * coffread.c (coff_symfile_read): Adjust to std::string.
4523         * elfread.c (elf_symfile_read): Adjust to std::string.
4524         * symfile.c (separate_debug_file_exists): Change parameter to
4525         std::string.
4526         (find_separate_debug_file): Return std::string.
4527         (find_separate_debug_file_by_debuglink): Return std::string.
4528         * symfile.h (find_separate_debug_file_by_debuglink): Return
4529         std::string.
4530
4531 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4532
4533         * common/xml-utils.c (xml_escape_text): Move code to...
4534         (xml_escape_text_append): ... this new function.
4535         * common/xml-utils.h (xml_escape_text_append): New declaration.
4536         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
4537         New function.
4538         (_initialize_xml_utils): register test_xml_escape_text_append as
4539         a selftest.
4540
4541 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
4542
4543         * defs.h: Remove MAX_REGISTER_SIZE.
4544         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
4545         asserts.
4546         * python/py-unwind.c (pyuw_sniffer): Likewise.
4547
4548 2018-03-07  Tom Tromey  <tom@tromey.com>
4549
4550         * linux-tdep.c (linux_info_proc): Update.
4551         * target.h (struct target_ops) <to_fileio_readlink>: Return
4552         optional<string>.
4553         (target_fileio_readlink): Return optional<string>.
4554         * remote.c (remote_hostio_readlink): Return optional<string>.
4555         * inf-child.c (inf_child_fileio_readlink): Return
4556         optional<string>.
4557         * target.c (target_fileio_readlink): Return optional<string>.
4558
4559 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4560
4561         * regcache.c (cooked_read_test): Add riscv to the list of
4562         architectures that have a save_reggroup.
4563
4564 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4565
4566         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
4567         value is not a dynamic class object.
4568
4569 2018-03-06  Tom Tromey  <tom@tromey.com>
4570
4571         * rust-exp.y: Formatting fixes.
4572
4573 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4574
4575         * riscv-tdep.c (riscv_register_name): Remove target description
4576         support.
4577         (riscv_gdbarch_init): Remove target description check.
4578
4579 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4580
4581         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
4582         comment.
4583         * riscv-tdep.h: Likewise.
4584
4585 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
4588         (riscv_pseudo_register_write): Delete.
4589         (riscv_gdbarch_init): Remove all use of pseudo registers.
4590
4591 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4592
4593         * record-btrace.c (btrace_print_lines): Replace cleanup
4594         parameter with RAII equivalents.
4595         (btrace_insn_history): Replace cleanup with RAII equivalents.
4596         * ui-out.h (make_cleanup_ui_out_list_begin_end,
4597         make_cleanup_ui_out_tuple_begin_end): Remove.
4598         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
4599         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
4600         make_cleanup_ui_out_list_begin_end): Remove.
4601
4602 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4603
4604         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
4605         parameter types to std::vector.  Use bool.
4606         (record_btrace_wait): Replace VEC(tp_t) with
4607         std::vector<thread_info *>.
4608         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
4609
4610 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4611
4612         * record-btrace.c (record_btrace_disable_callback): Remove.
4613         (struct scoped_btrace_disable): New.
4614         (record_btrace_open): Use scoped_btrace_disable.
4615
4616 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4617
4618         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
4619         reading values from registers.
4620
4621 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4622
4623         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
4624         where appropriate.
4625
4626 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4627
4628         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
4629         change parameter type.  Use GDB's print functions, and use
4630         core_addr_to_string where appropriate.
4631         (riscv_push_dummy_call): Use core_addr_to_string where
4632         appropriate, update call to riscv_print_arg_location, and reindent
4633         a few lines.
4634         (riscv_return_value): Update call to riscv_print_arg_location.
4635
4636 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4637             Tim Newsome <tim@sifive.com>
4638             Albert Ou <a0u@eecs.berkeley.edu>
4639             Darius Rad <darius@bluespec.com>
4640
4641         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
4642         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
4643         (ALLDEPFILES): Add riscv-tdep.c
4644         * configure.tgt: Add riscv support.
4645         * riscv-tdep.c: New file.
4646         * riscv-tdep.h: New file.
4647         * NEWS: Mention new target.
4648         * MAINTAINERS: Add entry for riscv.
4649
4650 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4651
4652         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
4653         fields within aggregates.
4654
4655 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
4656
4657         * record-btrace.c (btrace_print_lines): Change type of flags to
4658         gdb_disassembly_flags.
4659
4660 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4661
4662         * fbsd-nat.c: Include "inf-ptrace.h".
4663         (USE_SIGTRAP_SIGINFO): Conditionally define.
4664         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
4665         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
4666         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
4667         function.
4668         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
4669         Likewise.
4670         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
4671         Likewise.
4672         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
4673         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
4674         "supports_stopped_by_hw_breakpoint" target methods.
4675
4676 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4677
4678         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
4679         * fbsd-nat.c (debug_fbsd_nat): New variable.
4680         (show_fbsd_nat_debug): New function.
4681         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
4682         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
4683
4684 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4685
4686         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
4687         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
4688         prototype.
4689         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
4690         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
4691         method.
4692
4693 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4694
4695         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
4696         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
4697
4698 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4699
4700         * charset.c (struct charset_vector): New.
4701         (charsets): Change type to charset_vector.
4702         (find_charset_names): Adjust.
4703         (add_one): Adjust.
4704         (_initialize_charset): Adjust.
4705
4706 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4707
4708         * progspace.h (struct program_space) <deleted_solibs>: Change
4709         type to std::vector<std::string>.
4710         * progspace.c (clear_program_space_solib_cache): Adjust.
4711         * breakpoint.c (print_solib_event): Adjust.
4712         (check_status_catch_solib): Adjust.
4713         * solib.c (update_solib_list): Adjust.
4714         * ui-out.h (class ui_out) <field_string>: New overload.
4715         * ui-out.c (ui_out::field_string): New overload.
4716
4717 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4718
4719         * progspace.h (struct program_space): Add constructor and
4720         destructor, initialize fields.
4721         (add_program_space): Remove.
4722         * progspace.c (add_program_space): Rename to...
4723         (program_space::program_space): ... this.
4724         (release_program_space): Rename to...
4725         (program_space::~program_space): ... this.
4726         (delete_program_space): Use delete to delete program_space.
4727         (initialize_progspace): Use new to allocate program_space.
4728         * inferior.c (add_inferior_with_spaces): Likewise.
4729         (clone_inferior_command): Likewise.
4730         * infrun.c (follow_fork_inferior): Likewise.
4731         (handle_vfork_child_exec_or_exit): Likewise.
4732
4733 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4734
4735         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
4736         (delim_string_to_char_ptr_vec): Return std::vector of
4737         gdb::unique_xmalloc_ptr.
4738         (dirnames_to_char_ptr_vec_append): Take std::vector of
4739         gdb::unique_xmalloc_ptr.
4740         (dirnames_to_char_ptr_vec): Return std::vector of
4741         gdb::unique_xmalloc_ptr.
4742         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
4743         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
4744         (delim_string_to_char_ptr_vec): Return an std::vector of
4745         gdb::unique_xmalloc_ptr, adjust the code.
4746         (dirnames_to_char_ptr_vec_append): Take an std::vector of
4747         gdb::unique_xmalloc_ptr, adjust the code.
4748         (dirnames_to_char_ptr_vec): Return an std::vector of
4749         gdb::unique_xmalloc_ptr, adjust the code.
4750         * auto-load.c (auto_load_safe_path_vec): Change type to
4751         std::vector of gdb::unique_xmalloc_ptr.
4752         (auto_load_expand_dir_vars): Return an std::vector of
4753         gdb::unique_xmalloc_ptr, adjust the code.
4754         (auto_load_safe_path_vec_update): Adjust.
4755         (filename_is_in_auto_load_safe_path_vec): Adjust.
4756         (auto_load_objfile_script_1): Adjust.
4757         * build-id.c (build_id_to_debug_bfd): Adjust.
4758         * linux-thread-db.c (thread_db_load_search): Adjust.
4759         * source.c (add_path): Adjust.
4760         (openp): Adjust.
4761         * symfile.c (find_separate_debug_file): Adjust.
4762         * utils.c (do_free_char_ptr_vec): Remove.
4763         (make_cleanup_free_char_ptr_vec): Remove.
4764
4765 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4766
4767         PR gdb/22907
4768         * common/pathstuff.c: Conditionally include "<windows.h>".
4769
4770 2018-03-01  Georg Sauthoff  <mail@georg.so>
4771
4772         PR gdb/22888
4773         * gcore.in: Quote variables and switch interpreter to bash.
4774
4775 2018-03-01  Tom Tromey  <tom@tromey.com>
4776
4777         * dwarf2read.c (alloc_discriminant_info): Fix default_index
4778         assertion.  Add assertion for discriminant_index.
4779         (quirk_rust_enum): Use correct base type name in univariant case.
4780
4781 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
4782
4783         * record.c (get_call_history_modifiers): Return a
4784         record_print_flags.
4785         (cmd_record_call_history): Adjust.
4786         * record-btrace.c (record_btrace_call_history): Adjust.
4787         (record_btrace_call_history_range): Adjust.
4788         (record_btrace_call_history_from): Adjust.
4789         * target-debug.h (target_debug_print_record_print_flags): New.
4790         * target-delegates.c: Re-generate.
4791         * target.c (target_call_history): Change flags type.
4792         (target_call_history_from): Likewise.
4793         (target_call_history_range): Likewise.
4794         * target.h (struct target_ops) <target_call_history>: Likewise.
4795         (target_call_history_from): Likewise.
4796         (target_call_history_range): Likewise.
4797
4798 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4799             Simon Marchi  <simon.marchi@polymtl.ca>
4800
4801         * common/common-utils.c: Include "sys/stat.h".
4802         (is_regular_file): Move here from "source.c"; change return
4803         type to "bool".
4804         * common/common-utils.h (is_regular_file): New prototype.
4805         * common/pathstuff.c (contains_dir_separator): New function.
4806         * common/pathstuff.h (contains_dir_separator): New prototype.
4807         * source.c: Don't include "sys/stat.h".
4808         (is_regular_file): Move to "common/common-utils.c".
4809
4810 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4811
4812         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
4813         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
4814         * auto-load.c: Include "common/pathstuff.h".
4815         * common/common-def.h (current_directory): Move here.
4816         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
4817         function.
4818         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
4819         prototype.
4820         * common/pathstuff.c: New file.
4821         * common/pathstuff.h: New file.
4822         * compile/compile.c: Include "common/pathstuff.h".
4823         * defs.h (current_directory): Move to "common/common-defs.h".
4824         * dwarf2read.c: Include "common/pathstuff.h".
4825         * exec.c: Likewise.
4826         * guile/scm-safe-call.c: Likewise.
4827         * linux-thread-db.c: Likewise.
4828         * main.c: Likewise.
4829         * nto-tdep.c: Likewise.
4830         * objfiles.c: Likewise.
4831         * source.c: Likewise.
4832         * symtab.c: Likewise.
4833         * utils.c: Include "common/pathstuff.h".
4834         (gdb_realpath): Move to "common/pathstuff.c".
4835         (gdb_realpath_keepfile): Likewise.
4836         (gdb_abspath): Likewise.
4837         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
4838         (gdb_realpath_keepfile): Likewise.
4839         (gdb_abspath): Likewise.
4840
4841 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
4842
4843         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
4844         wildcard process pid for super_resume for kernels with a
4845         specific bug.
4846
4847 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
4848
4849         * compile/compile.c (get_args): Add additional comments
4850         explaining function.
4851
4852 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
4853             Tom Tromey  <tom@tromey.com>
4854
4855         * target.h (memory_write_request_s): Remove typedef.  Don't define
4856         VEC.
4857         (target_write_memory_blocks): Change argument to std::vector.
4858         (struct memory_write_request): Add constructor.
4859         * target-memory.c (compare_block_starting_address): Return bool.
4860         Change argument types.
4861         (claim_memory): Change arguments to use std::vector.
4862         (split_regular_and_flash_blocks, blocks_to_erase)
4863         (compute_garbled_blocks): Likewise.
4864         (cleanup_request_data, cleanup_write_requests_vector): Remove.
4865         (target_write_memory_blocks): Change argument to std::vector.
4866         * symfile.c (struct load_section_data): Add constructor and
4867         destructor.  Use std::vector for "requests".
4868         (struct load_progress_data): Add initializers.
4869         (load_section_callback): Update.  Use "new".
4870         (clear_memory_write_data): Remove.
4871         (generic_load): Update.
4872
4873 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
4874
4875         * arch/aarch64.h: Use common/tdesc.h.
4876
4877 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
4878
4879         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
4880         architecture with a 64-bit ABI.
4881
4882 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
4883
4884         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
4885         ahead of target description loading.
4886
4887 2018-02-26  Tom Tromey  <tom@tromey.com>
4888
4889         * stack.c (backtrace_command_1): Update.
4890         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
4891         of "flags".
4892         * python/py-framefilter.c (py_print_frame)
4893         (gdbpy_apply_frame_filter): Change type of "flags".
4894         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
4895         of "flags".
4896         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
4897         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
4898         * extension.h (enum frame_filter_flag): Rename from
4899         frame_filter_flags.
4900         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
4901         (apply_ext_lang_frame_filter): Change type of "flags".
4902         * extension.c (apply_ext_lang_frame_filter): Change type of
4903         "flags".
4904         * extension-priv.h (struct extension_language_ops)
4905         <apply_frame_filter>: Change type of "flags".
4906
4907 2018-02-26  Tom Tromey  <tom@tromey.com>
4908
4909         PR python/16497:
4910         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
4911         off-by-one in py_end computation.
4912         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
4913         PRINT_MORE_FRAMES.
4914         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
4915         constant.
4916
4917 2018-02-26  Tom Tromey  <tom@tromey.com>
4918
4919         * dwarf2read.c (struct variant_field): New.
4920         (struct nextfield) <variant>: New field.
4921         (dwarf2_add_field): Handle DW_TAG_variant_part.
4922         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
4923         discriminated union.
4924         (read_structure_type): Handle DW_TAG_variant_part.
4925         (handle_struct_member_die): New function, extracted from
4926         process_structure_scope.  Handle DW_TAG_variant.
4927         (process_structure_scope): Handle discriminated unions.  Call
4928         handle_struct_member_die.
4929
4930 2018-02-26  Tom Tromey  <tom@tromey.com>
4931
4932         * rust-lang.h (rust_last_path_segment): Declare.
4933         * rust-lang.c (rust_last_path_segment): Now public.  Change
4934         contract.
4935         (struct disr_info): Remove.
4936         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
4937         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
4938         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
4939         (rust_enum_p, rust_enum_variant): New function.
4940         (rust_underscore_fields): Remove "offset" parameter.
4941         (rust_print_enum): New function.
4942         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
4943         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
4944         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
4945         enums.
4946         (rust_internal_print_type): New function, from rust_print_type.
4947         Remove enum code.
4948         (rust_print_type): Call rust_internal_print_type.
4949         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
4950         Update enum handling.
4951         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
4952         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
4953         (rust_union_quirks): New functions.
4954         (process_full_comp_unit, process_full_type_unit): Call
4955         rust_union_quirks.
4956         (process_structure_scope): Update rust_unions if necessary.
4957
4958 2018-02-26  Tom Tromey  <tom@tromey.com>
4959
4960         * value.h (value_union_variant): Declare.
4961         * valops.c (value_union_variant): New function.
4962         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
4963         (struct discriminant_info): New.
4964         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
4965         enumerator.
4966         (struct main_type) <flag_discriminated_union>: New field.
4967
4968 2018-02-26  Tom Tromey  <tom@tromey.com>
4969
4970         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4971         unittests/unpack-selftests.c.
4972         * unittests/unpack-selftests.c: New file.
4973         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
4974
4975 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4976
4977         * dwarf2read.c (struct partial_die_info) <read>: New method.
4978         (read_partial_die): Remove the declaration.
4979         (load_partial_dies): Update.
4980         (partial_die_info::partial_die_info):
4981         (read_partial_die): Change it to partial_die_info::read.
4982
4983 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4984
4985         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
4986         (fixup_partial_die): Remove declaration.
4987         (scan_partial_symbols): Update.
4988         (partial_die_parent_scope): Likewise.
4989         (partial_die_full_name): Likewise.
4990         (fixup_partial_die): Change it to partial_die_info::fixup.
4991
4992 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4993
4994         * dwarf2read.c (read_partial_die): Update the declaration.
4995         (load_partial_dies): Caller update.
4996         (read_partial_die): Remove one argument abbrev_len.
4997
4998 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4999
5000         * dwarf2read.c (struct partial_die_info): Add ctor, delete
5001         assignment operator.
5002         (load_partial_dies): Use ctor and copy ctor.
5003         (read_partial_die): Update.
5004         (dwarf2_cu::find_partial_die): Use ctor.
5005
5006 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5007
5008         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
5009         (find_partial_die_in_comp_unit): Change it to
5010         dwarf2_cu::find_partial_die.
5011         (find_partial_die): Update.
5012
5013 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5014
5015         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
5016         is NULL.
5017
5018 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5019
5020         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
5021
5022 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
5023
5024         * arch/amd64.h: Use common/tdesc.h.
5025         * arch/i386.c: Likewise.
5026         * arch/i386.h: Likewise.
5027         * arch/tic6x.c: Likewise.
5028         * arch/tdesc.h: Move file from here...
5029         * common/tdesc.h: ...to here.
5030         * features/aarch64-core.c: Regenerate.
5031         * features/aarch64-fpu.c: Regenerate.
5032         * features/i386/32bit-avx.c: Regenerate.
5033         * features/i386/32bit-avx512.c: Regenerate.
5034         * features/i386/32bit-core.c: Regenerate.
5035         * features/i386/32bit-linux.c: Regenerate.
5036         * features/i386/32bit-mpx.c: Regenerate.
5037         * features/i386/32bit-pkeys.c: Regenerate.
5038         * features/i386/32bit-sse.c: Regenerate.
5039         * features/i386/64bit-avx.c: Regenerate.
5040         * features/i386/64bit-avx512.c: Regenerate.
5041         * features/i386/64bit-core.c: Regenerate.
5042         * features/i386/64bit-linux.c: Regenerate.
5043         * features/i386/64bit-mpx.c: Regenerate.
5044         * features/i386/64bit-pkeys.c: Regenerate.
5045         * features/i386/64bit-segments.c: Regenerate.
5046         * features/i386/64bit-sse.c: Regenerate.
5047         * features/i386/x32-core.c: Regenerate.
5048         * features/tic6x-c6xp.c: Regenerate.
5049         * features/tic6x-core.c: Regenerate.
5050         * features/tic6x-gp.c: Regenerate.
5051         * target-descriptions.c: Use common/tdesc.h.
5052         * target-descriptions.h: Likewise.
5053
5054 2018-02-24  Tom Tromey  <tom@tromey.com>
5055
5056         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
5057         (try_thread_db_load_from_dir, thread_db_load_search): Use
5058         std::string.
5059         (info_auto_load_libthread_db_compare): Return bool.  Change
5060         argument types.
5061         (info_auto_load_libthread_db): Use std::vector, std::string.
5062         Remove cleanups.
5063
5064 2018-02-24  Tom Tromey  <tom@tromey.com>
5065
5066         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
5067         std::string.
5068         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
5069         std::string*.
5070         * gdbarch.c: Rebuild.
5071         * gdbarch.h: Rebuild.
5072         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
5073         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
5074         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
5075         std::string*.
5076
5077 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
5078
5079         * gdbtypes.h (sect_offset): Change type to uint64_t.
5080         (sect_offset_str): New function.
5081         * dwarf2read.c (create_addrmap_from_aranges): Use
5082         sect_offset_str.
5083         (error_check_comp_unit_head): Likewise.
5084         (create_debug_type_hash_table): Likewise.
5085         (read_cutu_die_from_dwo): Likewise.
5086         (init_cutu_and_read_dies): Likewise.
5087         (init_cutu_and_read_dies_no_follow): Likewise.
5088         (process_psymtab_comp_unit_reader): Likewise.
5089         (partial_die_parent_scope): Likewise.
5090         (peek_die_abbrev): Likewise.
5091         (process_queue): Likewise.
5092         (dwarf2_physname): Likewise.
5093         (read_namespace_alias): Likewise.
5094         (read_import_statement): Likewise.
5095         (create_dwo_cu_reader): Likewise.
5096         (create_cus_hash_table): Likewise.
5097         (lookup_dwo_cutu): Likewise.
5098         (inherit_abstract_dies): Likewise.
5099         (read_func_scope): Likewise.
5100         (read_call_site_scope): Likewise.
5101         (dwarf2_add_member_fn): Likewise.
5102         (read_common_block): Likewise.
5103         (read_module_type): Likewise.
5104         (read_typedef): Likewise.
5105         (read_subrange_type): Likewise.
5106         (load_partial_dies): Likewise.
5107         (read_partial_die): Likewise.
5108         (find_partial_die): Likewise.
5109         (read_str_index): Likewise.
5110         (dwarf2_string_attr): Likewise.
5111         (build_error_marker_type): Likewise.
5112         (lookup_die_type): Likewise.
5113         (dump_die_shallow): Likewise.
5114         (follow_die_ref): Likewise.
5115         (dwarf2_fetch_die_loc_sect_off): Likewise.
5116         (dwarf2_fetch_constant_bytes): Likewise.
5117         (follow_die_sig): Likewise.
5118         (get_signatured_type): Likewise.
5119         (get_DW_AT_signature_type): Likewise.
5120         (dwarf2_find_containing_comp_unit): Likewise.
5121         (set_die_type): Likewise.
5122
5123 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
5124
5125         * arch/aarch64.c: Include "common-defs.h".
5126         * arch/amd64.c: Likewise.
5127         * arch/i386.c: Likewise.
5128
5129 2018-02-21  Tom Tromey  <tom@tromey.com>
5130
5131         * value.h: (extract_field_op): Update.
5132         * eval.c (extract_field_op): Return a const char *.
5133         * expression.h (parse_expression_for_completion): Update.
5134         * completer.c (complete_expression): Update.
5135         (add_struct_fields): Make fieldname const.
5136         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
5137         (mark_completion_tag, parse_exp_in_context_1): Update.
5138         (parse_expression_for_completion): Change "name" to
5139         unique_xmalloc_ptr*.
5140
5141 2018-02-21  Tom Tromey  <tom@tromey.com>
5142
5143         * infcall.c (call_function_by_hand_dummy): Use std::vector.
5144
5145 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5146
5147         * avr-tdep.c (avr_read_pc): Change parameter type to
5148         readable_regcache.
5149         * gdbarch.sh (read_pc): Likewise.
5150         * gdbarch.c: Re-generated.
5151         * gdbarch.h: Re-generated.
5152         * hppa-tdep.c (hppa_read_pc): Change parameter type to
5153         readable_regcache.
5154         * ia64-tdep.c (ia64_read_pc): Likewise.
5155         * mips-tdep.c (mips_read_pc): Likewise.
5156         * spu-tdep.c (spu_read_pc): Likewise.
5157
5158 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5159
5160         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
5161         * regcache-dump.c: New file.
5162         * regcache.c: Move register_dump to regcache-dump.c.
5163         (maintenance_print_registers): Likewise.
5164         (maintenance_print_raw_registers): Likewise.
5165         (maintenance_print_cooked_registers): Likewise.
5166         (maintenance_print_register_groups): Likewise.
5167         (maintenance_print_remote_registers): Likewise.
5168         (_initialize_regcache): Likewise.
5169         * regcache.h (register_dump): Moved from regcache.c.
5170
5171 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5172
5173         * regcache.c (regcache::regcache): Update.
5174         (regcache::invalidate): Move it to detached_regcache::invalidate.
5175         (get_thread_arch_aspace_regcache): Update.
5176         (regcache::raw_update): Update.
5177         (regcache::cooked_read): Remove some code.
5178         (regcache::cooked_read_value): Likewise.
5179         (regcache::raw_write): Remove assert on m_readonly_p.
5180         (regcache::raw_supply_integer): Move it to
5181         detached_regcache::raw_supply_integer.
5182         (regcache::raw_supply_zeroed): Likewise.
5183         * regcache.h (detached_regcache) <raw_supply_integer>: New
5184         declaration.
5185         <raw_supply_zeroed, invalidate>: Likewise.
5186         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
5187         <invalidate>: Likewise.
5188         <m_readonly_p>: Removed.
5189
5190 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5191
5192         * infcmd.c (get_return_value): Let stop_regs point to
5193         get_current_regcache.
5194         * regcache.c (regcache::regcache): Remove.
5195         (register_dump_reg_buffer): New class.
5196         (regcache_print): Adjust.
5197         * regcache.h (regcache): Remove constructors.
5198
5199 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5200
5201         * regcache.c (class register_dump): New class.
5202         (register_dump_regcache, register_dump_none): New class.
5203         (register_dump_remote, register_dump_groups): New class.
5204         (regcache_print): Update.
5205         * regcache.h (regcache_dump_what): Move it to regcache.c.
5206         (regcache) <dump>: Remove.
5207
5208 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5209
5210         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
5211          reg_buffer_rw *.
5212         (jit_unwind_reg_set_impl): Call raw_supply.
5213         (jit_frame_sniffer): Use reg_buffer_rw.
5214         * record-full.c (record_full_core_regbuf): Change its type.
5215         (record_full_core_open_1): Use reg_buffer_rw.
5216         (record_full_close): Likewise.
5217         (record_full_core_fetch_registers): Use regcache->raw_supply.
5218         (record_full_core_store_registers): Likewise.
5219         * regcache.c (regcache::get_register_status): Move it to
5220         reg_buffer.
5221         (regcache_raw_set_cached_value): Remove.
5222         (regcache::raw_set_cached_value): Remove.
5223         (regcache::raw_write): Call raw_supply.
5224         (regcache::raw_supply): Move it to reg_buffer_rw.
5225         * regcache.h (regcache_raw_set_cached_value): Remove.
5226         (reg_buffer_rw): New class.
5227
5228 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5229
5230         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
5231         readonly_detached_regcache.
5232         (dummy_frame_prev_register): Use regcache->cooked_read.
5233         * frame.c (frame_save_as_regcache): Change return type.
5234         (frame_pop): Update.
5235         * frame.h (frame_save_as_regcache): Update declaration.
5236         * inferior.h (get_infcall_suspend_state_regcache): Update
5237         declaration.
5238         * infrun.c (infcall_suspend_state) <registers>: use
5239         readonly_detached_regcache.
5240         (save_infcall_suspend_state): Don't use regcache_dup.
5241         (get_infcall_suspend_state_regcache): Change return type.
5242         * linux-fork.c (struct fork_info) <savedregs>: Change to
5243         readonly_detached_regcache.
5244         <pc>: New field.
5245         (fork_save_infrun_state): Don't use regcache_dup.
5246         (info_checkpoints_command): Adjust.
5247         * mi/mi-main.c (register_changed_p): Update declaration.
5248         (mi_cmd_data_list_changed_registers): Use
5249         readonly_detached_regcache.
5250         (register_changed_p): Change parameter type to
5251         readonly_detached_regcache.
5252         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
5253         readonly_detached_regcache.
5254         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
5255         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
5256         New.
5257         (regcache::save): Move it to reg_buffer.
5258         (regcache::restore): Change parameter type.
5259         (regcache_dup): Remove.
5260         * regcache.h (reg_buffer) <save>: New method.
5261         (readonly_detached_regcache): New class.
5262         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
5263         readonly_detached_regcache.
5264         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
5265
5266 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5267
5268         * frame.c (frame_save_as_regcache): Use regcache method save.
5269         (frame_pop): Use regcache method restore.
5270         * infrun.c (restore_infcall_suspend_state): Likewise.
5271         * linux-fork.c (fork_load_infrun_state): Likewise.
5272         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
5273         save.
5274         * regcache.c (regcache_save): Remove.
5275         (regcache::restore): More asserts.
5276         (regcache_cpy): Remove.
5277         * regcache.h (regcache_save): Remove the declaration.
5278         (regcache::restore): Move from private to public.
5279         Remove the friend declaration of regcache_cpy.
5280         (regcache_cpy): Remove declaration.
5281
5282 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5283
5284         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
5285         parameter type to 'readable_regcache *'.
5286         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5287         * arm-tdep.c (arm_neon_quad_read): Likewise.
5288         (arm_pseudo_read): Likewise.
5289         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5290         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5291         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5292         * gdbarch.c: Re-generated.
5293         * gdbarch.h: Re-generated.
5294         * gdbarch.sh (pseudo_register_read): Change parameter type to
5295         'readable_regcache *'.
5296         (pseudo_register_read_value): Likewise.
5297         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
5298         (h8300_pseudo_register_read): Likewise.
5299         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
5300         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5301         (i386_pseudo_register_read_into_value): Likewise.
5302         (i386_pseudo_register_read_value): Likewise.
5303         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
5304         declaration.
5305         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
5306         * m32c-tdep.c (m32c_raw_read): Likewise.
5307         (m32c_read_flg): Likewise.
5308         (m32c_banked_register): Likewise.
5309         (m32c_banked_read): Likewise.
5310         (m32c_sb_read): Likewise.
5311         (m32c_part_read): Likewise.
5312         (m32c_cat_read): Likewise.
5313         (m32c_r3r2r1r0_read): Likewise.
5314         (m32c_pseudo_register_read): Likewise.
5315         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5316         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5317         (mep_pseudo_cr64_read): Likewise.
5318         (mep_pseudo_register_read): Likewise.
5319         * mips-tdep.c (mips_pseudo_register_read): Likewise.
5320         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5321         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5322         * regcache.c (regcache::raw_read): Move it to readable_regcache.
5323         (regcache::cooked_read): Likewise.
5324         (regcache::cooked_read_value): Likewise.
5325         (regcache_cooked_read_signed):
5326         (regcache::cooked_read): Likewise.
5327         * regcache.h (readable_regcache): New class.
5328         (regcache): Inherit readable_regcache.  Move some methods to
5329         readable_regcache.
5330         * rl78-tdep.c (rl78_pseudo_register_read): Change
5331         parameter type to 'readable_regcache *'.
5332         * rs6000-tdep.c (do_regcache_raw_read): Remove.
5333         (e500_pseudo_register_read): Change parameter type to
5334         'readable_regcache *'.
5335         (dfp_pseudo_register_read): Likewise.
5336         (vsx_pseudo_register_read): Likewise.
5337         (efpr_pseudo_register_read): Likewise.
5338         * s390-tdep.c (s390_pseudo_register_read): Likewise.
5339         * sh-tdep.c (sh_pseudo_register_read): Likewise.
5340         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
5341         (sh64_pseudo_register_read): Likewise.
5342         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
5343         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
5344         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
5345         (spu_pseudo_register_read): Likewise.
5346         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
5347         (xtensa_pseudo_register_read): Likewise.
5348
5349 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5350
5351         * regcache.c (regcache::regcache): Call reg_buffer ctor.
5352         (regcache::arch): Move it to reg_buffer::arch.
5353         (regcache::register_buffer): Likewise.
5354         (regcache::assert_regnum): Likewise.
5355         (regcache::num_raw_registers): Likewise.
5356         * regcache.h (reg_buffer): New class.
5357         (regcache): Inherit reg_buffer.
5358
5359 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
5360
5361         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
5362         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
5363
5364 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
5365
5366         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
5367
5368 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
5369
5370         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
5371         (SFILES): Remove common/*.c files.
5372         (COMMON_OBS): Remove some *.o files built from common/*.c files.
5373         * common/common.host: Add common reference.
5374         * configure.ac: Likewise.
5375         * configure: Regenerate.
5376
5377 2018-02-16  Yao Qi  <yao.qi@linaro.org>
5378
5379         * block.c (block_namespace_info): Inherit allocate_on_obstack.
5380         (block_initialize_namespace): Use new.
5381         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
5382         (dwarf2_free_objfile): Use delete.
5383         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
5384         (copy_type_recursive): Use new.
5385         * gdb_obstack.h (allocate_on_obstack): New.
5386
5387 2018-02-15  Yao Qi  <yao.qi@linaro.org>
5388
5389         PR gdb/22849
5390         * inferior.c (exit_inferior_1): Reset inf->control.
5391
5392 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
5393
5394         * ada-lang.c (ada_to_fixed_value_create): Delete advance
5395         declaration.
5396
5397 2018-02-14  Pedro Alves  <palves@redhat.com>
5398
5399         * frame-unwind.c (frame_unwind_try_unwinder): Always call
5400         frame_cleanup_after_sniffer on exception.
5401
5402 2018-02-14  Tom Tromey  <tom@tromey.com>
5403
5404         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
5405         const.
5406         (solib_bfd_open): Make pathname const.
5407         * solib.c (solib_bfd_open): Make pathname const.
5408         * solib-spu.c (spu_bfd_fopen): Make name const.
5409         (spu_bfd_open): Make pathname const.
5410         * solib-darwin.c (darwin_bfd_open): Make pathname const.
5411         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
5412
5413 2018-02-14  Tom Tromey  <tom@tromey.com>
5414
5415         * symfile.c (symfile_bfd_open): Update.
5416         * source.h (openp, source_full_path_of, find_and_open_source):
5417         Change argument type to unique_xmalloc_ptr.
5418         * source.c (openp): Take a unique_xmalloc_ptr.
5419         (source_full_path_of, find_and_open_source): Likewise.
5420         (open_source_file, symtab_to_fullname): Update.
5421         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
5422         unique_xmalloc_ptr.
5423         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
5424         (exec_file_find): Update.
5425         * psymtab.c (psymtab_to_fullname): Update.
5426         * nto-tdep.h (nto_find_and_open_solib): Update.
5427         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
5428         unique_xmalloc_ptr.
5429         * exec.c (exec_file_attach): Update.
5430         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
5431         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
5432
5433 2018-02-14  Tom Tromey  <tom@tromey.com>
5434
5435         * solib.c: Include source.h.
5436         * nto-tdep.c: Include source.h.
5437         * mi/mi-cmd-env.c: Include source.h.
5438         * infcmd.c: Include source.h.
5439         * exec.c: Include source.h.
5440         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
5441         (add_path, directory_switch, source_path, init_source_path): Move
5442         declarations...
5443         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
5444         (add_path, directory_switch, source_path, init_source_path):
5445         ...here.
5446
5447 2018-02-14  Tom Tromey  <tom@tromey.com>
5448
5449         * solist.h (exec_file_find, solib_find): Return
5450         unique_xmalloc_ptr.
5451         (solib_bfd_fopen): Take a const char *.
5452         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
5453         (exec_file_find, solib_find): Likewise.
5454         (solib_bfd_fopen): Do not take ownership of "pathname".
5455         (solib_bfd_open): Use unique_xmalloc_ptr.
5456         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
5457         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
5458         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
5459         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
5460
5461 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
5462
5463         * ada-lang.c (name_match_type_from_name): Remove reference to
5464         ada_name_for_lookup in function's documentation.
5465         * ada-lang.h (ada_name_for_lookup): Delete declaration.
5466
5467 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5468
5469         * defs.h (enum openp_flags): New enum.
5470         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
5471         Move to enum openp_flags.
5472         (openp_flags): New enum flags.
5473         (openp): Change parameter type to openp_flags.
5474         * source.c (openp): Change parameter type to openp_flags.
5475         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
5476         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
5477
5478 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5479
5480         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
5481         per-command.
5482
5483 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5484
5485         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
5486         into...
5487         (class dwarf2_queue_guard): ...the destructor of this new class.
5488         (dw2_do_instantiate_symtab): Create instance of the new class
5489         dwarf2_queue_guard, remove cleanup.
5490
5491 2018-02-09  Tom Tromey  <tom@tromey.com>
5492
5493         * source.c (find_source_lines): Don't reference past the end of
5494         the vector.
5495
5496 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5497
5498         * remote.c (remote_btrace_maybe_reopen): Change error message.
5499         * btrace.c (btrace_enable): Likewise.
5500         (parse_xml_btrace): Likewise.
5501         (parse_xml_btrace_conf): Likewise.
5502
5503 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5504
5505         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
5506         (linux_enable_pt, linux_enable_bts): Call
5507         diagnose_perf_event_open_fail.
5508
5509 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5510
5511         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
5512         Remove parameter and change return type.  Update callers.  Move it.
5513         (linux_enable_bts, linux_enable_pt): Improve error message.
5514         (linux_enable_pt): Remove zero buffer size check.
5515         (linux_enable_btrace): Improve error messages.  Remove NULL return
5516         check.
5517
5518 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5519
5520         * btrace.c (btrace_enable): Remove target_supports_btrace call.
5521         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
5522         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
5523         (linux_supports_pt, linux_supports_btrace): Remove.
5524         (linux_enable_bts): Call cpu_supports_bts.
5525         * nat/linux-btrace.h (linux_supports_btrace): Remove.
5526         * remote.c (remote_supports_btrace): Remove.
5527         (init_remote_ops): Remove remote_supports_btrace.
5528         * target-delegates.c: Regenerated.
5529         * target.c (target_supports_btrace): Remove.
5530         * target.h (target_ops) <to_supports_btrace>: Remove
5531         (target_supports_btrace): Remove.
5532         * x86-linux-nat.c (x86_linux_create_target): Remove
5533         linux_supports_btrace.
5534
5535 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5536
5537         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
5538         btrace failed.
5539         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
5540         exception and use message in own exception.
5541
5542 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5543
5544         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
5545         (perf_event_pt_event_type): Use gdb_file_up.
5546         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
5547         scoped_fd, and scoped_mmap.
5548
5549 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5550
5551         * common/scoped_mmap.h: New.
5552         * unittests/scoped_mmap-selftest.c: New.
5553         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5554         unittests/scoped_mmap-selftest.c.
5555
5556 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5557
5558         * common/scoped_fd.h: New.
5559         * unittests/scoped_fd-selftest.c: New.
5560         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5561         unittests/scoped_fd-selftest.c.
5562
5563 2018-02-09  Tom Tromey  <tom@tromey.com>
5564
5565         * auto-load.c (auto_load_section_scripts): Use
5566         gdb::unique_xmalloc_ptr.
5567
5568 2018-02-09  Tom Tromey  <tom@tromey.com>
5569
5570         * auto-load.c (execute_script_contents): Use std::string.
5571
5572 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
5573
5574         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
5575         Python function, rather than a new command.
5576
5577 2018-02-08  Tom Tromey  <tom@tromey.com>
5578
5579         * solib.c (solib_find_1): Use std::string.
5580         (solib_bfd_fopen): Use unique_xmalloc_ptr.
5581
5582 2018-02-08  Tom Tromey  <tom@tromey.com>
5583
5584         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
5585
5586 2018-02-08  Tom Tromey  <tom@tromey.com>
5587
5588         * source.c (find_source_lines): Use gdb::def_vector.
5589
5590 2018-02-08  Tom Tromey  <tom@tromey.com>
5591
5592         * macrocmd.c (struct temporary_macro_definition): New.
5593         (macro_define_command): Use temporary_macro_definition.  Remove
5594         cleanups.
5595         (free_macro_definition_ptr): Remove.
5596
5597 2018-02-08  Tom Tromey  <tom@tromey.com>
5598
5599         * macroexp.c (maybe_expand): Use std::string.
5600
5601 2018-02-08  Tom Tromey  <tom@tromey.com>
5602
5603         * macroexp.c (struct macro_buffer): Add initializers for some
5604         members.
5605         (init_buffer, init_shared_buffer, free_buffer)
5606         (free_buffer_return_text): Remove.
5607         (macro_buffer): New constructors.
5608         (~macro_buffer): New destructor.
5609         (macro_buffer::set_shared): New method.
5610         (macro_buffer::resize_buffer, macro_buffer::appendc)
5611         (macro_buffer::appendmem): Now methods, not free functions.
5612         (set_token, append_tokens_without_splicing, stringify)
5613         (macro_stringify): Update.
5614         (gather_arguments): Change return type.  Remove argc_p argument,
5615         add args_ptr argument.  Use std::vector.
5616         (substitute_args): Remove argc argument.  Accept std::vector.
5617         (expand): Update.  Use std::vector.
5618         (scan, macro_expand, macro_expand_next): Update.
5619
5620 2018-02-08  Tom Tromey  <tom@tromey.com>
5621
5622         * symtab.c (default_collect_symbol_completion_matches_break_on):
5623         Use unique_xmalloc_ptr.
5624         * macroscope.h: (sal_macro_scope, user_macro_scope)
5625         (default_macro_scope): Return unique_xmalloc_ptr.
5626         * macroscope.c (sal_macro_scope, user_macro_scope)
5627         (default_macro_scope): Return unique_xmalloc_ptr.
5628         * macroexp.h (macro_expand, macro_expand_once): Return
5629         unique_xmalloc_ptr.
5630         * macroexp.c (macro_expand, macro_expand_once): Return
5631         unique_xmalloc_ptr.
5632         * macrocmd.c (macro_expand_command, macro_expand_once_command)
5633         (info_macro_command, info_macros_command): Use
5634         unique_xmalloc_ptr.
5635         * compile/compile-c-support.c (write_macro_definitions): Use
5636         unique_xmalloc_ptr.
5637         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
5638
5639 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
5640
5641         * value.c (value_static_field): Assign field type instead of
5642         containing type when returning an optimized out value.
5643
5644 2018-02-06  Yao Qi  <yao.qi@linaro.org>
5645
5646         * ft32-tdep.c (ft32_read_pc): Remove.
5647         (ft32_write_pc): Remove.
5648         (ft32_gdbarch_init): Update.
5649         * m32r-tdep.c (m32r_read_pc): Remove.
5650         (m32r_gdbarch_init): Update.
5651         * mep-tdep.c (mep_read_pc): Remove.
5652         (mep_gdbarch_init): Update.
5653         * microblaze-tdep.c (microblaze_write_pc): Remove.
5654         (microblaze_gdbarch_init): Update.
5655         * mn10300-tdep.c (mn10300_read_pc): Remove.
5656         (mn10300_write_pc): Remove.
5657         (mn10300_gdbarch_init): Update.
5658         * moxie-tdep.c (moxie_read_pc): Remove.
5659         (moxie_write_pc): Remove.
5660         (moxie_gdbarch_init): Update.
5661
5662 2018-02-06  Yao Qi  <yao.qi@linaro.org>
5663
5664         * expprint.c (print_subexp_standard): Handle
5665         OP_F77_UNDETERMINED_ARGLIST.
5666         (dump_subexp_body_standard): Likewise.
5667
5668 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
5669
5670         * target-descriptions.c (tdesc_element_visitor) Add empty
5671         implementations.
5672         (tdesc_type): Move make_gdb_type from here.
5673         (tdesc_type_builtin): Likewise.
5674         (tdesc_type_vector): Likewise.
5675         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
5676         (make_gdb_type_struct): Move from tdesc_type_with_fields.
5677         (make_gdb_type_union): Likewise.
5678         (make_gdb_type_flags): Likewise.
5679         (make_gdb_type_enum): Likewise.
5680         (make_gdb_type): New function.
5681         (tdesc_register_type): Use static make_gdb_type.
5682
5683 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
5684
5685         * infcmd.c (default_print_one_register_info): Align natural-format
5686         column values consistently one under another.
5687         (pad_to_column): New function.
5688
5689 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
5690
5691         * dwarf2read.c (dwarf2_physname): Move commment.
5692
5693 2018-02-01  Leszek Swirski  <leszeks@google.com>
5694
5695         * varobj.c (varobj_formatted_print_options): Allow recursive
5696         pretty printing if pretty printing is enabled.
5697
5698 2018-02-01  Leszek Swirski  <leszeks@google.com>
5699
5700         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
5701         names after a structop as a filename.
5702
5703 2018-02-01  Yao Qi  <yao.qi@linaro.org>
5704
5705         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
5706         (arm_record_coproc_data_proc): Likewise.
5707
5708 2018-02-01  Yao Qi  <yao.qi@linaro.org>
5709
5710         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
5711
5712 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
5713
5714         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
5715         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
5716
5717 2018-01-31  Pedro Alves  <palves@redhat.com>
5718
5719         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
5720         * inflow.c (child_terminal_save_inferior): Wrap reference to
5721         tcgetpgrp in HAVE_TERMIOS_H.
5722         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
5723         _WIN32.
5724         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
5725         always iterate over all inferiors.
5726         (gdbsim_cntrl_c): Adjust.
5727         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
5728
5729 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
5730
5731         * gdbtypes.c (lookup_array_range_type): Make sure the array's
5732         index type is objfile-owned if the element type is as well.
5733
5734 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
5735
5736         GDB 8.1 released.
5737
5738 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5739
5740         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
5741         "features/s390x-linux64.c".
5742         (_initialize_s390_linux_tdep): Remove initialization of tdescs
5743         s390_linux32 and s390x_linux64.
5744         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
5745         default tdesc.
5746         * s390-tdep.c: Include "features/s390-linux32.c" and
5747         "features/s390x-linux64.c".
5748         (s390_tdesc_valid): Add check for tdesc_has_registers.
5749         (s390_gdbarch_init): Make sure there is always a valid tdesc.
5750         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
5751         tdesc_s390x_linux64.
5752         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
5753         tdesc_s390x_linux64 to...
5754         * s390-tdep.h: ...here.
5755
5756 2018-01-30  Pedro Alves  <palves@redhat.com>
5757
5758         PR gdb/13211
5759         * config.in, configure: Regenerate.
5760         * configure.ac: Check for getpgid.
5761         * go32-nat.c (go32_pass_ctrlc): New.
5762         (go32_target): Install it.
5763         * inf-child.c (inf_child_target): Install
5764         child_terminal_save_inferior, child_pass_ctrlc and
5765         child_interrupt.
5766         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
5767         (inf_ptrace_target): No longer install it.
5768         * infcmd.c (interrupt_target_1): Adjust.
5769         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
5770         (child_interrupt): Declare.
5771         (inferior::terminal_state): New.
5772         * inflow.c (struct terminal_info): Update comments.
5773         (inferior_process_group): Delete.
5774         (terminal_is_ours): Delete.
5775         (gdb_tty_state): New.
5776         (child_terminal_init): Adjust.
5777         (is_gdb_terminal, sharing_input_terminal_1)
5778         (sharing_input_terminal): New functions.
5779         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
5780         Set the process's actual process group in the foreground if
5781         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
5782         mark terminal as the inferior's if not sharing GDB's terminal.
5783         Don't check attach_flag.
5784         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
5785         pass down a target_terminal_state.
5786         (child_terminal_save_inferior): New, factored out from ...
5787         (child_terminal_ours_1): ... this.  Handle
5788         target_terminal_state::is_ours_for_output.
5789         (child_interrupt, child_pass_ctrlc): New.
5790         (inflow_inferior_exit): Clear the inferior's terminal_state.
5791         (copy_terminal_info): Copy the inferior's terminal state.
5792         (_initialize_inflow): Remove reference to terminal_is_ours.
5793         * inflow.h (inferior_process_group): Delete.
5794         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
5795         * procfs.c (procfs_target): Don't install procfs_interrupt.
5796         (procfs_interrupt): Delete.
5797         * remote.c (remote_serial_quit_handler): Adjust.
5798         (remote_interrupt): Remove ptid parameter.  Adjust.
5799         * target-delegates.c: Regenerate.
5800         * target.c: Include "terminal.h".
5801         (target_terminal::terminal_state): Rename to ...
5802         (target_terminal::m_terminal_state): ... this.
5803         (target_terminal::init): Adjust.
5804         (target_terminal::inferior): Adjust to per-inferior
5805         terminal_state.
5806         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
5807         (target_terminal::ours, target_terminal::ours_for_output): Use
5808         target_terminal_is_ours_kind.
5809         (target_interrupt): Remove ptid parameter.  Adjust.
5810         (default_target_pass_ctrlc): Adjust.
5811         * target.h (target_ops::to_terminal_save_inferior): New field.
5812         (target_ops::to_interrupt): Remove ptid_t parameter.
5813         (target_interrupt): Remove ptid_t parameter.  Update comment.
5814         (target_pass_ctrlc): Update comment.
5815         * target/target.h (target_terminal_state): New scoped enum,
5816         factored out of ...
5817         (target_terminal::terminal_state): ... here.
5818         (target_terminal::inferior): Update comments.
5819         (target_terminal::restore_inferior): New.
5820         (target_terminal::is_inferior, target_terminal::is_ours)
5821         (target_terminal::is_ours_for_output): Adjust.
5822         (target_terminal::scoped_restore_terminal_state): Adjust to
5823         rename, and call restore_inferior() instead of inferior().
5824         (target_terminal::scoped_restore_terminal_state::m_state): Change
5825         type.
5826         (target_terminal::terminal_state): Rename to ...
5827         (target_terminal::m_terminal_state): ... this and change type.
5828
5829 2018-01-30  Pedro Alves  <palves@redhat.com>
5830
5831         * linux-nat.c (wait_for_signal): New function.
5832         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
5833         directly.
5834         (async_terminal_is_ours)
5835         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
5836         (linux_nat_add_target): Don't override
5837         to_terminal_inferior/to_terminal_ours.
5838
5839 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5840
5841         * remote.c (remote_follow_fork): Don't call "detach_inferior".
5842
5843 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
5844
5845         * dwarf2read.c (free_dwo_files): Add forward-declaration.
5846         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
5847         dwarf2_per_objfile_free here.
5848         (dwarf2_per_objfile_free): Remove.
5849         (_initialize_dwarf2_read): Don't register
5850         dwarf2_per_objfile_free as a registry cleanup.
5851
5852 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
5853
5854         Avoid compilation errors in MinGW native builds
5855
5856         The error is triggered by including python-internal.h, and the
5857         error message is:
5858
5859              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
5860                       from build-gnulib/import/math.h:27,
5861                       from d:/usr/Python26/include/pyport.h:235,
5862                       from d:/usr/Python26/include/Python.h:58,
5863                       from python/python-internal.h:94,
5864                       from python/py-arch.c:24:
5865              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
5866         using ::hypot;
5867                 ^~~~~
5868
5869         This happens because Python headers define 'hypot' to expand t
5870         '_hypot' in the Windows builds.
5871         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
5872         'hypoth'.  This avoids a compilation error.
5873
5874 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
5875
5876         * MAINTAINERS (Write After Approval): Fix ordering.
5877
5878 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
5879
5880         * MAINTAINERS (Write After Approval): Add Alan Hayward.
5881
5882 2018-01-26  Alan Modra  <amodra@gmail.com>
5883
5884         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
5885         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
5886         Remove nop.  Make const.  Comment.
5887         (powerpc32_plt_stub_so_2): New.
5888         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
5889         Correct count.  Update uses.
5890         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
5891         Move common code reading PLT entry word.  Correct
5892         powerpc32_plt_stub PLT address calculation.
5893         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
5894         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
5895         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
5896         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
5897         (ppc64_standard_linkage8): Likewise.
5898         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
5899         Correct insns description.
5900         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
5901
5902 2018-01-24  Pedro Alves  <palves@redhat.com>
5903
5904         GCC PR libstdc++/83906
5905         * gdbtypes.c (operator==(const dynamic_prop &,
5906         const dynamic_prop &)): New.
5907         (operator==(const range_bounds &, const range_bounds &)): New.
5908         (check_types_equal): Use them instead of memcmp.
5909         * gdbtypes.h (operator==(const dynamic_prop &,
5910         const dynamic_prop &)): Declare.
5911         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
5912         (operator==(const range_bounds &, const range_bounds &)): Declare.
5913         (operator!=(const range_bounds &, const range_bounds &)): Declare.
5914
5915 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5916
5917         * s390-linux-tdep.c (s390_record_address_mask)
5918         (s390_record_calc_disp_common, s390_record_calc_disp)
5919         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
5920         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
5921         (s390_process_record): Move to s390-tdep.c.
5922         (s390_linux_init_abi_any): Adjust.
5923         * s390-tdep.c (s390_record_address_mask)
5924         (s390_record_calc_disp_common, s390_record_calc_disp)
5925         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
5926         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
5927         (s390_process_record): Moved from s390-linux-tdep.c
5928         (s390_gdbarch_init): Adjust.
5929
5930 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5931
5932         * s390-linux-nat.c (s390-tdep.h): New include.
5933         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
5934         (HFILES_NO_SRCDIR): Add s390-tdep.h.
5935         (ALLDEPFILES): Add s390-tdep.c.
5936         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
5937         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
5938         * s390-tdep.h: ...this.  New file.
5939         * s390-linux-tdep.c (s390-tdep.h): New include.
5940         (_initialize_s390_tdep): Rename to...
5941         (_initialize_s390_linux_tdep): ...this and adjust.
5942         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
5943         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
5944         s390-tdep.h.
5945         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
5946         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
5947         (s390_is_partial_instruction, s390_software_single_step)
5948         (is_non_branch_ril, s390_displaced_step_copy_insn)
5949         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
5950         (s390_prologue_data, s390_addr, s390_store, s390_load)
5951         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
5952         (s390_register_call_saved, s390_guess_tracepoint_registers)
5953         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
5954         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
5955         (s390_pseudo_register_name, s390_pseudo_register_type)
5956         (s390_pseudo_register_read, s390_pseudo_register_write)
5957         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
5958         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
5959         (s390_addr_bits_remove, s390_address_class_type_flags)
5960         (s390_address_class_type_flags_to_name)
5961         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
5962         (s390_function_arg_float, s390_function_arg_vector)
5963         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
5964         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
5965         (s390_frame_align, s390_register_return_value, s390_return_value)
5966         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
5967         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
5968         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
5969         (s390_trad_frame_prev_register, s390_unwind_cache)
5970         (s390_prologue_frame_unwind_cache)
5971         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
5972         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
5973         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
5974         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
5975         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
5976         (s390_frame_base_address, s390_local_base_address)
5977         (s390_frame_base, s390_gcc_target_options)
5978         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
5979         (s390_validate_reg_range, s390_tdesc_valid)
5980         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
5981         * s390-tdep.c: ...this.  New file.
5982
5983 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5984
5985         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
5986         (s390_process_record, s390_gdbarch_tdep_alloc)
5987         (s390_linux_init_abi_any): Use/set new hook.
5988
5989 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5990
5991         * s390-linux-tdep.c (osabi.h): New include.
5992         (s390_linux_init_abi_31, s390_linux_init_abi_64)
5993         (s390_linux_init_abi_any): New functions.
5994         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
5995
5996 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5997
5998         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
5999         tdesc_has_registers check
6000
6001 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6002
6003         * s390-linux-tdep.c (s390_tdesc_valid): New function.
6004         (s390_validate_reg_range): New macro.
6005         (s390_gdbarch_init): Adjust.
6006
6007 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6008
6009         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
6010         (s390_gdbarch_tdep_alloc): Adjust.
6011         (s390_gdbarch_init): Adjust.
6012
6013 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6014
6015         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
6016         <have_tdb>: Change type to bool.
6017         (s390_gdbarch_tdep_alloc): Adjust.
6018         (s390_gdbarch_init): Adjust.
6019
6020 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6021
6022         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
6023         (gdbarch_tdep) <have_upper, have_vx>: New fields.
6024         (s390_gdbarch_tdep_alloc): New function.
6025         (s390_gdbarch_init): Allocate tdep at start and use its fields
6026         instead of separate variables.
6027
6028 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6029
6030         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
6031         when looking for cached gdbarch and add comment for remaining.
6032
6033 2018-01-22  Pedro Alves  <palves@redhat.com>
6034             Sergio Durigan Junior  <sergiodj@redhat.com>
6035
6036         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
6037         case.
6038
6039 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
6040
6041         * MAINTAINERS: Update my company e-mail address.
6042
6043 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6044
6045         * regcache.c (cooked_write_test): New function.
6046         (_initialize_regcache): Register the test.
6047
6048 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6049
6050         * ia64-tdep.c (ia64_pseudo_register_read): Call
6051         regcache->cooked_read instead of regcache_cooked_read_unsigned.
6052         * m32c-tdep.c (m32c_cat_read): Likewise.
6053         (m32c_r3r2r1r0_read): Likewise.
6054         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6055         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6056
6057 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6058
6059         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
6060         method raw_read instead of regcache_raw_read.
6061         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6062         * arm-tdep.c (arm_neon_quad_read): Likewise.
6063         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6064         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6065         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6066         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
6067         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6068         (i386_pseudo_register_read_into_value): Likewise.
6069         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6070         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6071         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6072         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
6073         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
6074         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
6075         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6076         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
6077         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
6078
6079 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6080
6081         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
6082         * configure.tgt: Remove target mt.
6083         * mt-tdep.c: Remove.
6084         * regcache.c (cooked_read_test): Remove the check for mt.
6085
6086 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6087
6088         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
6089         instead of gdbarch_pseudo_register_read_value.
6090
6091 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6092
6093         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
6094         language is Ada.
6095
6096 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6097
6098         * linespec.c (create_sals_line_offset): Remove code that preserved
6099         the symtab_and_line's line number.
6100
6101 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6102
6103         * varobj.c (varobj_create): Don't set valid_block when creating a
6104         floating varobj.
6105
6106 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6107
6108         * varobj.c (varobj_create): Remove out of date comment.
6109
6110 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6111
6112         PR mi/20395
6113         * ada-exp.y (write_var_from_sym): Pass extra parameter when
6114         updating innermost block.
6115         * parse.c (innermost_block_tracker::update): Take extra type
6116         parameter, and check types match before updating innermost block.
6117         (write_dollar_variable): Update innermost block for registers.
6118         * parser-defs.h (enum innermost_block_tracker_type): New enum.
6119         (innermost_block_tracker::innermost_block_tracker): Initialise
6120         m_types member.
6121         (innermost_block_tracker::reset): Take type parameter.
6122         (innermost_block_tracker::update): Take type parameter, and pass
6123         type through as needed.
6124         (innermost_block_tracker::m_types): New member.
6125         * varobj.c (varobj_create): Pass type when reseting innermost
6126         block.
6127
6128 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6129
6130         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
6131         * ada-lang.c (resolve_subexp): Likewise.
6132         * breakpoint.c (set_breakpoint_condition) Likewise.
6133         (watch_command_1) Likewise.
6134         * c-exp.y (variable): Likewise.
6135         * d-exp.y (PrimaryExpression): Likewise.
6136         * f-exp.y (variable): Likewise.
6137         * go-exp.y (variable): Likewise.
6138         * m2-exp.y (variable): Likewise.
6139         * objfiles.c (objfile::~objfile): Likewise.
6140         * p-exp.y (variable): Likewise.
6141         * parse.c (innermost_block): Change type.
6142         * parser-defs.h (class innermost_block_tracker): New.
6143         (innermost_block): Change to innermost_block_tracker.
6144         * printcmd.c (display_command): Switch to innermost_block API.
6145         (do_one_display): Likewise.
6146         * rust-exp.y (do_one_display): Likewise.
6147         * symfile.c (clear_symtab_users): Likewise.
6148         * varobj.c (varobj_create): Switch to innermost_block API, replace
6149         use of innermost_block with block stored on varobj object.
6150
6151 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6152
6153         * expression.h (innermost_block): Remove declaration.
6154         * varobj.c: Add 'parser-defs.h' include.
6155
6156 2018-01-19  Tom Tromey  <tom@tromey.com>
6157
6158         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
6159         symbols in the static and global blocks.
6160
6161 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
6162
6163         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
6164         gdb_ptrace.h, and move including gdb_wait.h ...
6165         * nat/linux-ptrace.h: ... to here.
6166
6167 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6168
6169         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
6170         inf_ptrace_detach_success.
6171         (inf_ptrace_detach_success): Add inferior parameter, use it
6172         instead of inferior_ptid, pass it to detach_inferior.
6173         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
6174         parameter.
6175         * inferior.c (detach_inferior): Add overload that takes an
6176         inferior object.
6177         * inferior.h (detach_inferior): Likewise.
6178         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
6179         use inferior_ptid, adjust call to inf_ptrace_detach_success.
6180         * linux-thread-db.c (thread_db_detach): Use inf parameter.
6181
6182 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6183
6184         * target.h (struct target_ops) <to_detach>: Add inferior
6185         parameter.
6186         (target_detach): Likewise.
6187         * target.c (dispose_inferior): Pass inferior down.
6188         (target_detach): Pass inferior down.  Assert that it is equal to
6189         the current inferior.
6190         * aix-thread.c (aix_thread_detach): Pass inferior down.
6191         * corefile.c (core_file_command): Pass current_inferior() down.
6192         * corelow.c (core_detach): Add inferior parameter.
6193         * darwin-nat.c (darwin_detach): Likewise.
6194         * gnu-nat.c (gnu_detach): Likewise.
6195         * inf-ptrace.c (inf_ptrace_detach): Likewise.
6196         * infcmd.c (detach_command): Pass current_inferior() down to
6197         target_detach.
6198         * infrun.c (follow_fork_inferior): Pass parent_inf to
6199         target_detach.
6200         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
6201         target_detach.
6202         * linux-nat.c (linux_nat_detach): Add inferior parameter.
6203         * linux-thread-db.c (thread_db_detach): Likewise.
6204         * nto-procfs.c (procfs_detach): Likewise.
6205         * procfs.c (procfs_detach): Likewise.
6206         * record.c (record_detach): Likewise.
6207         * record.h (struct inferior): Forward-declare.
6208         (record_detach): Add inferior parameter.
6209         * remote-sim.c (gdbsim_detach): Likewise.
6210         * remote.c (remote_detach_1): Likewise.
6211         (remote_detach): Likewise.
6212         (extended_remote_detach): Likewise.
6213         * sol-thread.c (sol_thread_detach): Likewise.
6214         * target-debug.h (target_debug_print_inferior_p): New macro.
6215         * target-delegates.c: Re-generate.
6216         * top.c (kill_or_detach): Pass inferior down to target_detach.
6217         * windows-nat.c (windows_detach): Add inferior parameter.
6218
6219 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6220
6221         * target.h (struct target_ops) <to_detach>: Remove args
6222         parameter.
6223         (target_detach): Likewise.
6224         * target.c (dispose_inferior): Adjust.
6225         (target_detach): Remove args parameter, adjust.
6226         * aix-thread.c (aix_thread_detach): Adjust.
6227         * corefile.c (core_file_command): Adjust.
6228         * corelow.c (core_detach): Adjust.
6229         * darwin-nat.c (darwin_detach): Adjust.
6230         * gnu-nat.c (gnu_detach): Adjust.
6231         * inf-ptrace.c (inf_ptrace_detach): Adjust.
6232         * infcmd.c (detach_command): Adjust
6233         * infrun.c (follow_fork_inferior): Adjust.
6234         (handle_vfork_child_exec_or_exit): Adjust.
6235         * linux-fork.c (linux_fork_detach): Remove args parameter.
6236         * linux-fork.h (linux_fork_detach): Likewise.
6237         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
6238         * linux-thread-db.c (thread_db_detach): Likewise.
6239         * nto-procfs.c (procfs_detach): Likewise.
6240         * procfs.c (procfs_detach): Likewise.
6241         (do_detach): Remove signo parameter.
6242         * record.c (record_detach): Remove args parameter.
6243         * record.h (record_detach): Likewise.
6244         * remote-sim.c (gdbsim_detach): Likewise.
6245         * remote.c (remote_detach_1): Likewise.
6246         (remote_detach): Likewise.
6247         (extended_remote_detach): Likewise.
6248         * sol-thread.c (sol_thread_detach): Likewise.
6249         * target-delegates.c: Re-generate.
6250         * top.c (struct qt_args) <args>: Remove field.
6251         (kill_or_detach): Don't pass args.
6252         (quit_force): Don't set args.
6253         * windows-nat.c (windows_detach): Remove args parameter.
6254
6255 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6256
6257         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
6258         (arm_linux_init_abi): Install it.
6259
6260 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6261
6262         * osabi.c (gdb_osabi_names): Extend the regexp for
6263         arm-linux-gnueabihf.
6264
6265 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6266
6267         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
6268         m_abbrevs.
6269         (abbrev_table::add_abbrev): Update.
6270         (abbrev_table::lookup_abbrev): Update.
6271
6272 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6273
6274         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
6275
6276 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
6277
6278         * compile/compile.c (compile_to_object): Convert "triplet_rx"
6279         to "std::string".
6280
6281 2018-01-17  Tom Tromey  <tom@tromey.com>
6282
6283         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
6284
6285 2018-01-17  Tom Tromey  <tom@tromey.com>
6286
6287         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
6288         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
6289         (create_array_type_with_stride): Update.
6290         * dwarf2read.c (set_die_type): Update.
6291
6292 2018-01-17  Tom Tromey  <tom@tromey.com>
6293
6294         * dwarf2read.c (delayed_method_info): Remove typedef.
6295         (dwarf2_cu::method_info): Now a std::vector.
6296         (add_to_method_list): Update.
6297         (free_delayed_list): Remove.
6298         (compute_delayed_physnames): Update.
6299         (process_full_comp_unit, process_full_type_unit): Clear the method
6300         list.  Remove cleanups.
6301         (psymtab_include_file_name): Add name_holder parameter.  Use
6302         unique_xmalloc_ptr.
6303         (dwarf_decode_lines): Update.
6304
6305 2018-01-17  Tom Tromey  <tom@tromey.com>
6306             Simon Marchi  <simon.marchi@ericsson.com>
6307
6308         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
6309         (dwarf2_per_objfile::free_cached_comp_units)
6310         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6311         (init_cutu_and_read_dies_no_follow): Update.
6312         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
6313         (dwarf2_cu::~dwarf2_cu): New.
6314         (free_heap_comp_unit, free_stack_comp_unit): Remove.
6315         (age_cached_comp_units, free_one_cached_comp_unit): Update.
6316
6317 2018-01-17  Tom Tromey  <tom@tromey.com>
6318             Simon Marchi  <simon.marchi@ericsson.com>
6319
6320         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
6321         (struct die_reader_specs) <abbrev_table>: New member.
6322         (struct abbrev_table): Add constructor.
6323         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
6324         <abbrev_obstack>: Now an auto_obstack.
6325         (abbrev_table_up): New typedef.
6326         (init_cu_die_reader): Add abbrev_table parameter.
6327         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
6328         Add result_dwo_abbrev_table.
6329         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6330         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
6331         Update.
6332         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
6333         parameter.
6334         (skip_children): Update.
6335         (abbrev_table::alloc_abbrev): Rename from
6336         abbrev_table_alloc_abbrev.
6337         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
6338         (abbrev_table::lookup_abbrev): Rename from
6339         abbrev_table_lookup_abbrev.
6340         (abbrev_table_read_table): Return abbrev_table_up.
6341         (abbrev_table_free, abbrev_table_free_cleanup)
6342         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
6343         (load_partial_dies): Update.
6344
6345 2018-01-17  Tom Tromey  <tom@tromey.com>
6346
6347         * dwarf2read.c (dwarf2_compute_name): Update comment.
6348         (read_func_scope, read_variable): Update.
6349         (new_symbol): Remove.
6350         (new_symbol_full): Rename to new_symbol.
6351
6352 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
6353
6354         PR gdb/16577
6355         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
6356         a warning instead of throwing an error, set section size to 0 and return
6357         NULL.
6358         * gdb_bfd.h (gdb_bfd_map_section): Update description.
6359
6360 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6361
6362         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
6363         std::string.
6364         (linux_ptrace_attach_fail_reason_string): Likewise.
6365         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
6366         Likewise.
6367         (linux_ptrace_attach_fail_reason_string): Likewise.
6368         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
6369
6370 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6371
6372         * linux-nat.c (linux_nat_attach): Remove xstrdup.
6373
6374 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
6375
6376         PR gdb/21559
6377         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
6378         checking for fs_base/gs_base fields in struct user_regs_struct.
6379         * configure: Regenerate.
6380
6381 2018-01-17  Yao Qi  <yao.qi@linaro.org>
6382
6383         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
6384         function.
6385         (aarch64_linux_init_abi): Install it to gdbarch hook
6386         gcc_target_options.
6387
6388 2018-01-15  Pedro Alves  <palves@redhat.com>
6389
6390         * common/signals-state-save-restore.c
6391         (save_original_signals_state): Fix typos.
6392
6393 2017-01-12  Tom Tromey  <tom@tromey.com>
6394             Sergio Durigan Junior  <sergiodj@redhat.com>
6395
6396         * Makefile.in (install-only): Install gdb-add-index.
6397
6398 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
6399
6400         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
6401
6402 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
6403
6404         * infrun.c (keep_going_pass_signal): Clear step-over info when
6405         insert_breakpoints fails.
6406
6407 2018-01-11  Pedro Alves  <palves@redhat.com>
6408
6409         PR gdb/22583
6410         * infrun.c (resume): Rename to ...
6411         (resume_1): ... this.
6412         (resume): Reimplement as wrapper around resume_1.
6413
6414 2018-01-11  Pedro Alves  <palves@redhat.com>
6415
6416         PR remote/22597
6417         * remote.c (remote_parse_stop_reply): Default to the last-set
6418         general thread instead of to 'magic_null_ptid'.
6419
6420 2018-01-10  Pedro Alves  <palves@redhat.com>
6421
6422         * language.h (language_get_symbol_name_matcher): Rename ...
6423         (get_symbol_name_matcher): ... this.
6424         * language.c (language_get_symbol_name_matcher): Ditto.
6425         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
6426         callers adjusted.
6427
6428 2018-01-10  Pedro Alves  <palves@redhat.com>
6429
6430         PR gdb/22670
6431         * dwarf2read.c
6432         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
6433         Adjust to use language_get_symbol_name_matcher instead of
6434         language_defn::la_get_symbol_name_matcher.
6435         * language.c (language_get_symbol_name_matcher): If in Ada mode
6436         and the lookup name is a verbatim match, return Ada's matcher.
6437         * language.h (language_get_symbol_name_matcher): Adjust comment.
6438         (ada_lookup_name_info::verbatim_p):: New method.
6439
6440 2018-01-10  Pedro Alves  <palves@redhat.com>
6441
6442         PR gdb/22670
6443         * ada-lang.c (ada_collect_symbol_completion_matches): If the
6444         minsym's language is language_auto or language_cplus, pass down
6445         language_ada instead.
6446         * symtab.c (compare_symbol_name): Don't frob symbol language here.
6447
6448 2018-01-10  Pedro Alves  <palves@redhat.com>
6449
6450         PR gdb/22670
6451         * minsyms.c (linkage_name_str): New function.
6452         (iterate_over_minimal_symbols): Use it.
6453
6454 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6455
6456         * NEWS: Document that 'info proc' now works on FreeBSD.
6457
6458 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6459
6460         * configure.ac: Check for kinfo_getfile in libutil.
6461         * configure: Regenerate.
6462         * config.in: Regenerate.
6463         * fbsd-nat.c: Include "fbsd-tdep.h".
6464         (fbsd_fetch_cmdline): New.
6465         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
6466         rather than calling error.
6467         (fbsd_info_proc): New.
6468         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
6469         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
6470         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
6471
6472 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6473
6474         * fbsd-nat.c (struct free_deleter): Remove.
6475         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
6476
6477 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6478
6479         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
6480         NULL for an empty pathname.
6481
6482 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6483
6484         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
6485         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
6486         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
6487         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
6488         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
6489         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
6490         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
6491         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
6492         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
6493         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
6494         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
6495         (fbsd_core_fetch_timeval, fbsd_print_sigset)
6496         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
6497         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
6498         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
6499
6500 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
6501
6502         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
6503         (gnu_xfer_auxv): New function.
6504         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
6505         TARGET_OBJECT_AUXV.
6506
6507 2018-01-08  Yao Qi  <yao.qi@linaro.org>
6508             Simon Marchi  <simon.marchi@ericsson.com>
6509
6510         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
6511         common/selftest.c.
6512         (COMMON_OBS): Remove selftest.o.
6513         * configure.ac: Append selftest-arch.c and common/selftest.c to
6514         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
6515         * configure: Re-generated.
6516         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
6517         GDB_SELF_TEST.
6518         (maintenance_info_selftests): Likewise.
6519
6520 2018-01-08  Xavier Roirand  <roirand@adacore.com>
6521
6522         * ada-valprint.c (val_print_packed_array_elements): Use
6523         proper number of elements when printing an array indexed
6524         by an enumeration type.
6525
6526 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6527
6528         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
6529         (dw2_get_file_names_reader): Adjust.
6530         (lookup_dwo_signatured_type): Adjust.
6531         (lookup_dwp_signatured_type): Adjust.
6532         (lookup_signatured_type): Adjust.
6533         (create_type_unit_group): Adjust.
6534         (get_type_unit_group): Adjust.
6535         (process_psymtab_comp_unit_reader): Adjust.
6536         (build_type_psymtabs_reader): Adjust.
6537         (scan_partial_symbols): Adjust.
6538         (add_partial_symbol): Adjust.
6539         (add_partial_subprogram): Adjust.
6540         (peek_die_abbrev): Adjust.
6541         (fixup_go_packaging): Adjust.
6542         (process_imported_unit_die): Adjust.
6543         (dwarf2_compute_name): Adjust.
6544         (dwarf2_physname): Adjust.
6545         (read_import_statement): Adjust.
6546         (handle_DW_AT_stmt_list): Adjust.
6547         (read_file_scope): Adjust.
6548         (read_func_scope): Adjust.
6549         (read_lexical_block_scope): Adjust.
6550         (read_call_site_scope): Adjust.
6551         (read_variable): Adjust.
6552         (dwarf2_rnglists_process): Adjust.
6553         (dwarf2_ranges_process): Adjust.
6554         (dwarf2_ranges_read): Adjust.
6555         (dwarf2_get_pc_bounds): Adjust.
6556         (dwarf2_record_block_ranges): Adjust.
6557         (dwarf2_add_field): Adjust.
6558         (dwarf2_add_member_fn): Adjust.
6559         (read_structure_type): Adjust.
6560         (process_structure_scope): Adjust.
6561         (read_enumeration_type): Adjust.
6562         (read_array_type): Adjust.
6563         (mark_common_block_symbol_computed): Adjust.
6564         (read_common_block): Adjust.
6565         (read_namespace_type): Adjust.
6566         (read_namespace): Adjust.
6567         (read_module_type): Adjust.
6568         (read_tag_pointer_type): Adjust.
6569         (read_tag_ptr_to_member_type): Adjust.
6570         (read_tag_string_type): Adjust.
6571         (read_subroutine_type): Adjust.
6572         (read_typedef): Adjust.
6573         (read_base_type): Adjust.
6574         (attr_to_dynamic_prop): Adjust.
6575         (read_subrange_type): Adjust.
6576         (read_unspecified_type): Adjust.
6577         (dwarf2_read_abbrevs): Adjust.
6578         (load_partial_dies): Adjust.
6579         (read_partial_die): Adjust.
6580         (find_partial_die): Adjust.
6581         (guess_partial_die_structure_name): Adjust.
6582         (fixup_partial_die): Adjust.
6583         (read_attribute_value): Adjust.
6584         (read_addr_index): Adjust.
6585         (read_addr_index_from_leb128): Adjust.
6586         (read_str_index): Adjust.
6587         (dwarf2_string_attr): Adjust.
6588         (get_debug_line_section): Adjust.
6589         (dwarf_decode_line_header): Adjust.
6590         (lnp_state_machine::check_line_address): Adjust.
6591         (dwarf_decode_lines_1): Adjust.
6592         (dwarf_decode_lines): Adjust.
6593         (dwarf2_start_symtab): Adjust.
6594         (var_decode_location): Adjust.
6595         (new_symbol_full): Adjust.
6596         (dwarf2_const_value_data): Adjust.
6597         (dwarf2_const_value_attr): Adjust.
6598         (dwarf2_const_value): Adjust.
6599         (die_type): Adjust.
6600         (die_containing_type): Adjust.
6601         (build_error_marker_type): Adjust.
6602         (lookup_die_type): Adjust.
6603         (guess_full_die_structure_name): Adjust.
6604         (anonymous_struct_prefix): Adjust.
6605         (determine_prefix): Adjust.
6606         (dwarf2_name): Adjust.
6607         (follow_die_ref_or_sig): Adjust.
6608         (follow_die_offset): Adjust.
6609         (follow_die_ref): Adjust.
6610         (follow_die_sig_1): Adjust.
6611         (follow_die_sig): Adjust.
6612         (get_signatured_type): Adjust.
6613         (get_DW_AT_signature_type): Adjust.
6614         (decode_locdesc): Adjust.
6615         (dwarf_decode_macros): Adjust.
6616         (cu_debug_loc_section): Adjust.
6617         (fill_in_loclist_baton): Adjust.
6618         (dwarf2_symbol_mark_computed): Adjust.
6619         (init_one_comp_unit): Don't assign
6620         dwarf2_cu::dwarf2_per_objfile.
6621         (set_die_type): Adjust.
6622
6623 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
6624
6625         * dwarf2read.c (struct mapped_debug_names): Add constructor.
6626         <dwarf2_per_objfile>: New field.
6627         (dwarf2_per_objfile): Remove global.
6628         (get_dwarf2_per_objfile): New function.
6629         (set_dwarf2_per_objfile): New function.
6630         (dwarf2_build_psymtabs_hard): Change objfile parameter to
6631         dwarf2_per_objfile.
6632         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
6633         (read_abbrev_offset): Likewise.
6634         (read_indirect_string): Likewise.
6635         (read_indirect_line_string): Likewise.
6636         (read_indirect_string_at_offset): Likewise.
6637         (read_indirect_string_from_dwz): Likewise.
6638         (dwarf2_find_containing_comp_unit): Change objfile parameter to
6639         dwarf2_per_objfile.
6640         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
6641         (create_all_comp_units): Change objfile parameter to
6642         dwarf2_per_objfile.
6643         (create_all_type_units): Likewise.
6644         (process_queue): Add dwarf2_per_objfile parameter.
6645         (read_and_check_comp_unit_head): Likewise.
6646         (lookup_dwo_unit_in_dwp): Likewise.
6647         (get_dwp_file): Likewise.
6648         (process_cu_includes): Likewise.
6649         (struct free_dwo_file_cleanup_data): New struct.
6650         (dwarf2_has_info): Use get_dwarf2_per_objfile and
6651         set_dwarf2_per_objfile.
6652         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
6653         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
6654         context, adjust calls.
6655         (dw2_instantiate_symtab): Likewise.
6656         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
6657         (dw2_get_cu): Likewise.
6658         (create_cu_from_index_list): Change objfile parameter to
6659         dwarf2_per_objfile.
6660         (create_cus_from_index_list): Get dwarf2_per_objfile from
6661         context, adjust calls.
6662         (create_cus_from_index): Likewise.
6663         (create_signatured_type_table_from_index): Change objfile
6664         parameter to dwarf2_per_objfile.
6665         (create_signatured_type_table_from_debug_names): Change objfile
6666         parameter to dwarf2_per_objfile.
6667         (create_addrmap_from_index): Likewise.
6668         (create_addrmap_from_aranges): Likewise.
6669         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
6670         (dw2_setup): Remove.
6671         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
6672         context.
6673         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
6674         get_dwarf2_per_objfile.
6675         (dw2_forget_cached_source_info): Likewise.
6676         (dw2_map_symtabs_matching_filename): Likewise.
6677         (struct dw2_symtab_iterator) <index>: Remove.
6678         <dwarf2_per_objfile>: New field.
6679         (dw2_symtab_iter_init): Replace index parameter with
6680         dwarf2_per_objfile.
6681         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
6682         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
6683         (dw2_print_stats): Likewise.
6684         (dw2_dump): Likewise.
6685         (dw2_expand_symtabs_for_function): Likewise.
6686         (dw2_expand_all_symtabs): Likewise.
6687         (dw2_expand_symtabs_with_fullname): Likewise.
6688         (dw2_expand_marked_cus): Replace index and objfile parameters
6689         with dwarf2_per_objfile.
6690         (dw_expand_symtabs_matching_file_matcher): Add
6691         dwarf2_per_objfile parameter and adjust calls.
6692         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
6693         adjust calls.
6694         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
6695         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
6696         adjust calls.
6697         (create_cus_from_debug_names_list): Replace objfile parameter
6698         with dwarf2_per_objfile and adjust calls.
6699         (create_cus_from_debug_names): Likewise.
6700         (dwarf2_read_debug_names): Likewise.
6701         (mapped_debug_names::namei_to_name): Adjust call.
6702         (dw2_debug_names_iterator::next): Likewise.
6703         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
6704         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
6705         (dw2_debug_names_dump): Likewise.
6706         (dw2_debug_names_expand_symtabs_for_function): Likewise.
6707         (dw2_debug_names_expand_symtabs_matching): Likewise.
6708         (dwarf2_initialize_objfile): Likewise.
6709         (dwarf2_build_psymtabs): Likewise.
6710         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
6711         this_cu.
6712         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
6713         (read_and_check_comp_unit_head): Likewise.
6714         (read_abbrev_offset): Likewise.
6715         (create_debug_type_hash_table): Likewise.
6716         (create_debug_types_hash_table): Likewise.
6717         (create_all_type_units): Replace objfile parameter with
6718         dwarf2_per_objfile.
6719         (add_type_unit): Add dwarf2_per_objfile parameter.
6720         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
6721         with dwarf2_per_objfile.
6722         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
6723         (lookup_dwp_signatured_type): Likewise.
6724         (lookup_signatured_type): Likewise.
6725         (read_cutu_die_from_dwo): Likewise.
6726         (init_tu_and_read_dwo_dies): Likewise.
6727         (init_cutu_and_read_dies): Likewise.
6728         (init_cutu_and_read_dies_no_follow): Likewise.
6729         (allocate_type_unit_groups_table): Add objfile parameter.
6730         (create_type_unit_group): Use dwarf2_per_objfile from cu.
6731         (get_type_unit_group): Likewise.
6732         (process_psymtab_comp_unit): Update call.
6733         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
6734         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
6735         (print_tu_stats): Likewise.
6736         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
6737         in void* parameter.
6738         (build_type_psymtabs): Change objfile parameter to
6739         dwarf2_per_objfile.
6740         (process_skeletonless_type_unit): Use dwarf2_per_objfile
6741         passed in void* parameter.
6742         (process_skeletonless_type_units): Change objfile parameter to
6743         dwarf2_per_objfile.
6744         (set_partial_user): Likewise.
6745         (dwarf2_build_psymtabs_hard): Likewise.
6746         (read_comp_units_from_section): Likewise.
6747         (create_all_comp_units): Likewise.
6748         (scan_partial_symbols): Update calls.
6749         (add_partial_symbol): Likewise.
6750         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
6751         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
6752         (process_queue): Add dwarf2_per_objfile parameter.
6753         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
6754         (compute_compunit_symtab_includes): Likewise.
6755         (process_cu_includes): Add dwarf2_per_objfile parameter.
6756         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
6757         (process_full_type_unit): Likewise.
6758         (process_imported_unit_die): Update call.
6759         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
6760         (read_file_scope): Likewise.
6761         (allocate_dwo_file_hash_table): Add objfile parameter.
6762         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
6763         (create_cus_hash_table): Likewise.
6764         (create_dwp_hash_table): Likewise.
6765         (create_dwo_unit_in_dwp_v1): Likewise.
6766         (create_dwp_v2_section): Likewise.
6767         (create_dwo_unit_in_dwp_v2): Likewise.
6768         (lookup_dwo_unit_in_dwp): Likewise.
6769         (try_open_dwop_file): Likewise.
6770         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
6771         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
6772         cleanup to include a reference to dwarf2_per_objfile.
6773         (open_dwp_file): Add dwarf2_per_objfile parameter.
6774         (open_and_init_dwp_file): Likewise.
6775         (get_dwp_file): Likewise.
6776         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
6777         (queue_and_load_all_dwo_tus): Update call.
6778         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
6779         data.
6780         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
6781         (dwarf2_ranges_process): Likewise.
6782         (dwarf2_get_pc_bounds): Likewise.
6783         (mark_common_block_symbol_computed): Likewise.
6784         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
6785         (dwarf2_read_abbrevs): Update call.
6786         (read_partial_die): Use dwarf2_per_objfile from cu.
6787         (find_partial_die): Likewise.
6788         (fixup_partial_die): Likewise.
6789         (read_attribute_value): Likewise.
6790         (read_indirect_string_at_offset_from): Add objfile parameter.
6791         (read_indirect_string_at_offset): Add dwarf2_per_objfile
6792         parameter.
6793         (read_indirect_string_from_dwz): Add objfile parameter.
6794         (read_indirect_string): Add objfile parameter.
6795         (read_addr_index_1): Add dwarf2_per_objfile parameter.
6796         (read_addr_index): Use dwarf2_per_objfile from cu.
6797         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
6798         call dw2_setup.
6799         (read_str_index): Use dwarf2_per_objfile from cu.
6800         (get_debug_line_section): Likewise.
6801         (read_formatted_entries): Add dwarf2_per_objfile parameter.
6802         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
6803         (new_symbol_full): Use dwarf2_per_objfile from cu.
6804         (build_error_marker_type): Likewise.
6805         (lookup_die_type): Likewise.
6806         (determine_prefix): Likewise.
6807         (follow_die_offset): Likewise.
6808         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
6809         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
6810         (dwarf2_fetch_die_type_sect_off): Likewise.
6811         (dwarf2_get_die_type): Likewise.
6812         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
6813         (get_signatured_type): Likewise.
6814         (get_DW_AT_signature_type): Likewise.
6815         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
6816         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
6817         (cu_debug_loc_section): Likewise.
6818         (fill_in_loclist_baton): Likewise.
6819         (dwarf2_symbol_mark_computed): Likewise.
6820         (dwarf2_find_containing_comp_unit): Change objfile parameter to
6821         dwarf2_per_objfile.
6822         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
6823         parameter.
6824         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
6825         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
6826         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
6827         (set_die_type): Use dwarf2_free_objfile from cu.
6828         (get_die_type_at_offset): Likewise.
6829         (dwarf2_per_objfile_free): Don't assign global variable.
6830         (debug_names) <constructor>: Add dwarf2_per_objfile
6831         parameter, update m_debugstrlookup construction.
6832         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
6833         parameter.
6834         <m_dwarf2_per_objfile>: New field.
6835         <lookup>: Use m_dwarf2_per_objfile.
6836         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
6837         (psyms_seen_size): Likewise.
6838         (write_gdbindex): Replace objfile parameter with
6839         dwarf2_per_objfile.
6840         (write_debug_names): Likewise.
6841         (write_psymtabs_to_index): Likewise.
6842         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
6843         calls.
6844
6845 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
6846
6847         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
6848         <dwarf2_per_objfile>: New field.
6849         (struct dwarf2_per_cu_data) <objfile>: Remove.
6850         <dwarf2_per_objfile>: New field.
6851         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
6852         of objfile.
6853         (create_signatured_type_table_from_index): Likewise.
6854         (create_debug_type_hash_table): Likewise.
6855         (fill_in_sig_entry_from_dwo_entry): Likewise.
6856         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
6857         (create_type_unit_group): Assign dwarf2_per_objfile instead of
6858         objfile.
6859         (create_partial_symtab): Access objfile through
6860         dwarf2_per_objfile.
6861         (process_psymtab_comp_unit_reader): Likewise.
6862         (read_comp_units_from_section): Likewise.
6863         (scan_partial_symbols): Likewise.
6864         (add_partial_symbol): Likewise.
6865         (add_partial_subprogram): Likewise.
6866         (peek_die_abbrev): Likewise.
6867         (fixup_go_packaging): Likewise.
6868         (process_full_comp_unit): Likewise.
6869         (process_full_type_unit): Likewise.
6870         (process_imported_unit_die): Likewise.
6871         (dwarf2_compute_name): Likewise.
6872         (dwarf2_physname): Likewise.
6873         (read_import_statement): Likewise.
6874         (create_cus_hash_table): Assign dwarf2_physname instead of
6875         objfile.
6876         (read_func_scope): Access objfile through dwarf2_per_objfile.
6877         (read_lexical_block_scope): Likewise.
6878         (read_call_site_scope): Likewise.
6879         (read_variable): Likewise.
6880         (dwarf2_rnglists_process): Likewise.
6881         (dwarf2_ranges_process): Likewise.
6882         (dwarf2_ranges_read): Likewise.
6883         (dwarf2_record_block_ranges): Likewise.
6884         (dwarf2_add_field): Likewise.
6885         (dwarf2_add_member_fn): Likewise.
6886         (read_structure_type): Likewise.
6887         (process_structure_scope): Likewise.
6888         (read_enumeration_type): Likewise.
6889         (read_array_type): Likewise.
6890         (read_common_block): Likewise.
6891         (read_namespace_type): Likewise.
6892         (read_namespace): Likewise.
6893         (read_module_type): Likewise.
6894         (read_tag_pointer_type): Likewise.
6895         (read_tag_ptr_to_member_type): Likewise.
6896         (read_tag_string_type): Likewise.
6897         (read_subroutine_type): Likewise.
6898         (read_typedef): Likewise.
6899         (read_base_type): Likewise.
6900         (attr_to_dynamic_prop): Likewise.
6901         (read_subrange_type): Likewise.
6902         (read_unspecified_type): Likewise.
6903         (load_partial_dies): Likewise.
6904         (read_partial_die): Likewise.
6905         (find_partial_die): Likewise.
6906         (guess_partial_die_structure_name): Likewise.
6907         (fixup_partial_die): Likewise.
6908         (read_attribute_value): Likewise.
6909         (read_addr_index_from_leb128): Likewise.
6910         (dwarf2_read_addr_index): Likewise.
6911         (dwarf2_string_attr): Likewise.
6912         (lnp_state_machine::check_line_address): Likewise.
6913         (dwarf_decode_lines_1): Likewise.
6914         (dwarf_decode_lines): Likewise.
6915         (dwarf2_start_symtab): Likewise.
6916         (var_decode_location): Likewise.
6917         (new_symbol_full): Likewise.
6918         (dwarf2_const_value_data): Likewise.
6919         (dwarf2_const_value_attr): Likewise.
6920         (dwarf2_const_value): Likewise.
6921         (die_type): Likewise.
6922         (die_containing_type): Likewise.
6923         (lookup_die_type): Likewise.
6924         (guess_full_die_structure_name): Likewise.
6925         (anonymous_struct_prefix): Likewise.
6926         (dwarf2_name): Likewise.
6927         (follow_die_ref_or_sig): Likewise.
6928         (follow_die_offset): Likewise.
6929         (follow_die_ref): Likewise.
6930         (dwarf2_fetch_die_loc_sect_off): Likewise.
6931         (dwarf2_fetch_constant_bytes): Likewise.
6932         (dwarf2_fetch_die_type_sect_off): Likewise.
6933         (dwarf2_get_die_type): Likewise.
6934         (follow_die_sig): Likewise.
6935         (decode_locdesc): Likewise.
6936         (dwarf2_per_cu_objfile): Likewise.
6937         (dwarf2_per_cu_text_offset): Likewise.
6938         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
6939         objfile.
6940         (set_die_type): Access objfile through
6941         dwarf2_per_objfile.
6942
6943 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
6944
6945         * valprint.c (converted_character_d): Remove typedef.
6946         (DEF_VEC_O (converted_character_d)): Remove.
6947         (count_next_character): Use std::vector.
6948         (print_converted_chars_to_obstack): Likewise.
6949         (generic_printstr): Likewise.
6950
6951 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6952
6953         * xml-support.h (struct gdb_xml_value): Add constructor.
6954         <value>: Change type to unique_xmalloc_ptr.
6955         (gdb_xml_value_s): Remove typedef.
6956         (DEF_VEC_O (gdb_xml_value_s)): Remove.
6957         (gdb_xml_element_start_handler): Change parameter type to
6958         std::vector.
6959         (xml_find_attribute): Likewise.
6960         * xml-support.c (xml_find_attribute): Change parameter type to
6961         std::vector and adjust.
6962         (gdb_xml_values_cleanup): Remove.
6963         (gdb_xml_parser::start_element): Adjust to std::vector.
6964         (xinclude_start_include): Change paraeter type to std::vector
6965         and adjust.
6966         * btrace.c (check_xml_btrace_version): Likewise.
6967         (parse_xml_btrace_block): Likewise.
6968         (parse_xml_btrace_pt_config_cpu): Likewise.
6969         (parse_xml_btrace_pt): Likewise.
6970         (parse_xml_btrace_conf_bts): Likewise.
6971         (parse_xml_btrace_conf_pt): Likewise.
6972         * memory-map.c (memory_map_start_memory): Likewise.
6973         (memory_map_start_property): Likewise.
6974         * osdata.c (osdata_start_osdata): Likewise.
6975         (osdata_start_item): Likewise.
6976         (osdata_start_column): Likewise.
6977         * remote.c (start_thread): Likewise.
6978         * solib-aix.c (library_list_start_library): Likewise.
6979         (library_list_start_list): Likewise.
6980         * solib-svr4.c (library_list_start_library): Likewise.
6981         (svr4_library_list_start_list): Likewise.
6982         * solib-target.c (library_list_start_segment): Likewise.
6983         (library_list_start_section): Likewise.
6984         (library_list_start_library): Likewise.
6985         (library_list_start_list): Likewise.
6986         * tracepoint.c (traceframe_info_start_memory): Likewise.
6987         (traceframe_info_start_tvar): Likewise.
6988         * xml-syscall.c (syscall_start_syscall): Likewise.
6989         * xml-tdesc.c (tdesc_start_target): Likewise.
6990         (tdesc_start_feature): Likewise.
6991         (tdesc_start_reg): Likewise.
6992         (tdesc_start_union): Likewise.
6993         (tdesc_start_struct): Likewise.
6994         (tdesc_start_flags): Likewise.
6995         (tdesc_start_enum): Likewise.
6996         (tdesc_start_field): Likewise.
6997         (tdesc_start_enum_value): Likewise.
6998         (tdesc_start_vector): Likewise.
6999
7000 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7001
7002         * extension.h (struct xmethod_worker) <clone>: Remove.
7003         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
7004         Remove.
7005         (python_xmethod_worker::clone): Remove.
7006         * valops.c (find_overload_match): Use std::move instead of
7007         clone.
7008
7009 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7010
7011         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
7012         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
7013         <free_xmethod_worker_data>: Remove.
7014         <get_matching_xmethod_workers>: Chance VEC to std::vector.
7015         <get_xmethod_arg_types>: Remove.
7016         <get_xmethod_result_type>: Remove.
7017         <invoke_xmethod>: Remove.
7018         * extension.c (new_xmethod_worker): Remove.
7019         (clone_xmethod_worker): Remove.
7020         (get_matching_xmethod_workers): Return void, pass std::vector by
7021         pointer.
7022         (get_xmethod_arg_types): Rename to...
7023         (xmethod_worker::get_arg_types): ... this, and adjust.
7024         (get_xmethod_result_type): Rename to...
7025         (xmethod_worker::get_result_type): ... this, and adjust.
7026         (invoke_xmethod): Remove.
7027         (free_xmethod_worker): Remove.
7028         (free_xmethod_worker_vec): Remove.
7029         * extension.h (enum ext_lang_rc): Move here from
7030         extension-priv.h.
7031         (struct xmethod_worker): Add constructor and destructor.
7032         <data>: Remove.
7033         <value>: Remove.
7034         <invoke, clone, do_get_result_type, do_get_arg_types>: New
7035         virtual pure methods.
7036         <get_arg_types, get_result_type>: New methods.
7037         (xmethod_worker_ptr): Remove typedef.
7038         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
7039         (xmethod_worker_vec): Remove typedef.
7040         (xmethod_worker_up): New typedef.
7041         (invoke_xmethod): Remove.
7042         (clone_xmethod_worker): Remove.
7043         (free_xmethod_worker): Remove.
7044         (free_xmethod_worker_vec): Remove.
7045         (get_xmethod_arg_types): Remove.
7046         (get_xmethod_result_type): Remove.
7047         * valops.c (find_method_list): Use std::vector, don't use
7048         intermediate vector.
7049         (value_find_oload_method_list): Use std::vector.
7050         (find_overload_match): Use std::vector.
7051         (find_oload_champ): Use std::vector.
7052         * value.c (value_free): Use operator delete.
7053         (value_of_xmethod): Rename to...
7054         (value_from_xmethod): ... this.  Don't assign
7055         xmethod_worker::value, take rvalue-reference.
7056         (result_type_of_xmethod): Adjust.
7057         (call_xmethod): Adjust.
7058         * value.h: Include extension.h.
7059         (struct xmethod_worker): Don't forward-declare.
7060         (value_of_xmethod): Rename to...
7061         (value_from_xmethod): ... this, take rvalue-reference.
7062         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
7063         (struct python_xmethod_worker): ... this, add constructor and
7064         destructor.
7065         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
7066         (gdbpy_free_xmethod_worker_data): Rename to...
7067         (python_xmethod_worker::~python_xmethod_worker): ... this and
7068         adjust.
7069         (gdbpy_clone_xmethod_worker_data): Rename to...
7070         (python_xmethod_worker::clone): ... this and adjust.
7071         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
7072         temporary vector.
7073         (gdbpy_get_xmethod_arg_types): Rename to...
7074         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
7075         (gdbpy_get_xmethod_result_type): Rename to...
7076         (python_xmethod_worker::do_get_result_type): ... this and
7077         adjust.
7078         (gdbpy_invoke_xmethod): Rename to...
7079         (python_xmethod_worker::invoke): ... this and adjust.
7080         (new_python_xmethod_worker): Rename to...
7081         (python_xmethod_worker::python_xmethod_worker): ... this and
7082         adjust.
7083         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
7084         Remove.
7085         (gdbpy_free_xmethod_worker_data): Remove.
7086         (gdbpy_get_matching_xmethod_workers): Use std::vector.
7087         (gdbpy_get_xmethod_arg_types): Remove.
7088         (gdbpy_get_xmethod_result_type): Remove.
7089         (gdbpy_invoke_xmethod): Remove.
7090         * python/python.c (python_extension_ops): Remove obsolete
7091         callbacks.
7092
7093 2018-01-05  Pedro Alves  <palves@redhat.com>
7094
7095         PR gdb/18653
7096         * common/signals-state-save-restore.c
7097         (save_original_signals_state): New parameter 'quiet'.  Warn if we
7098         find a custom handler preinstalled, instead of internal erroring.
7099         But only warn if !quiet.
7100         * common/signals-state-save-restore.h
7101         (save_original_signals_state): New parameter 'quiet'.
7102         * main.c (captured_main_1): Move save_original_signals_state call
7103         after option handling, and pass QUIET.
7104
7105 2018-01-05  Pedro Alves  <palves@redhat.com>
7106
7107         * spu-tdep.c (spu_catch_start): Pass
7108         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
7109
7110 2018-01-05  Pedro Alves  <palves@redhat.com>
7111
7112         PR gdb/22670
7113         * ada-lang.c (literal_symbol_name_matcher): New function.
7114         (ada_get_symbol_name_matcher): Use it for
7115         symbol_name_match_type::SEARCH_NAME.
7116         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
7117         it down instead of assuming symbol_name_match_type::FULL.
7118         * block.h (block_lookup_symbol): New parameter 'match_type'.
7119         * c-valprint.c (print_unpacked_pointer): Use
7120         lookup_symbol_search_name instead of lookup_symbol.
7121         * compile/compile-object-load.c (get_out_value_type): Pass down
7122         symbol_name_match_type::SEARCH_NAME.
7123         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
7124         symbol_name_match_type::FULL.
7125         * cp-support.c (cp_get_symbol_name_matcher): Handle
7126         symbol_name_match_type::SEARCH_NAME.
7127         * infrun.c (insert_exception_resume_breakpoint): Use
7128         lookup_symbol_search_name.
7129         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
7130         * psymtab.c (maintenance_check_psymtabs): Use
7131         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
7132         * stack.c (print_frame_args): Use lookup_symbol_search_name and
7133         SYMBOL_SEARCH_NAME.
7134         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
7135         if symbol_name_match_type::SEARCH_NAME.
7136         (lookup_symbol_in_language): Pass down
7137         symbol_name_match_type::FULL.
7138         (lookup_symbol_search_name): New.
7139         (lookup_language_this): Pass down
7140         symbol_name_match_type::SEARCH_NAME.
7141         (lookup_symbol_aux, lookup_local_symbol): New parameter
7142         'match_type'.  Pass it down.
7143         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
7144         (lookup_symbol_search_name): New declaration.
7145         (lookup_symbol_in_block): New 'match_type' parameter.
7146
7147 2018-01-05  Pedro Alves  <palves@redhat.com>
7148
7149         PR gdb/22670
7150         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
7151         ada_lookup_symbol.
7152         (ada_lookup_symbol): Reimplement in terms of
7153         ada_lookup_symbol_list, bits factored out from
7154         ada_lookup_encoded_symbol.
7155
7156 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7157
7158         * ada-exp.y (write_object_renaming): When subscripting an array
7159         using a symbol as the index, pass the block in call to
7160         ada_lookup_encoded_symbol when looking that symbol up.
7161
7162 2018-01-05  Jerome Guitton  <guitton@adacore.com>
7163
7164         * ada-lang.c (ada_array_length): Use ada_index_type instead of
7165         TYPE_INDEX_TYPE.
7166
7167 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7168
7169         * ada-lang.c (ada_to_fixed_value_create): Add handling of
7170         the case where VALUE_LVAL (val0) is not lval_memory.
7171
7172 2018-01-05  Xavier Roirand  <roirand@adacore.com>
7173
7174         * ada-valprint.c (print_optional_low_bound): Handle
7175         character-indexed array printing like boolean-indexed array
7176         printing.
7177
7178 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7179
7180         * NEWS: Create a new section for the next release branch.
7181         Rename the section of the current branch, now that it has
7182         been cut.
7183
7184 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7185
7186         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
7187         * version.in: Bump version to 8.1.50.DATE-git.
7188
7189 2018-01-03  Xavier Roirand  <roirand@adacore.com>
7190
7191         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
7192         Add field.
7193         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
7194         Add field.
7195         (default_exception_support_info) <catch_handlers_sym>: Add field.
7196         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
7197         (ada_exception_name_addr_1): Add "catch handlers" handling.
7198         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
7199         Update all callers.
7200         (create_excep_cond_exprs) <ex>: Add parameter.
7201         (re_set_exception): Update create_excep_cond_exprs call.
7202         (print_it_exception, print_one_exception, print_mention_exception)
7203         (print_recreate_exception): Add "catch handler" handling.
7204         (allocate_location_catch_handlers, re_set_catch_handlers)
7205         (check_status_catch_handlers, print_it_catch_handlers)
7206         (print_one_catch_handlers, print_mention_catch_handlers)
7207         (print_recreate_catch_handlers): New function.
7208         (catch_handlers_breakpoint_ops): New variable.
7209         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
7210         Add parameter.  Add "catch handler" handling.
7211         (ada_exception_sym_name, ada_exception_breakpoint_ops):
7212         Add "catch handler" handling.
7213         (ada_exception_catchpoint_cond_string): Add "catch handler"
7214         handling.
7215         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
7216         call.
7217         (catch_ada_handlers_command): New function.
7218         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
7219         operations structure.
7220         (_initialize_ada_language): Add "catch handlers" command entry.
7221         * NEWS: Document "catch handlers" feature.
7222
7223 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7224
7225         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
7226         account when creating the array type of the slice.
7227         (ada_value_slice): Likewise.
7228
7229 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7230
7231         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
7232         New enum value.
7233         (create_array_type_with_stride): Add byte_stride_prop parameter.
7234         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
7235         New parameter.  Update all callers in this file.
7236         (array_type_has_dynamic_stride): New function.
7237         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
7238         of arrays with dynamic byte strides.
7239         * dwarf2read.c (read_array_type): Add support for dynamic
7240         DW_AT_byte_stride attributes.
7241
7242 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7243
7244         * dwarf2read.c (read_unspecified_type): Treat
7245         DW_TAG_enumeration_type DIEs from Ada units as stubs.
7246
7247 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7248
7249         Update copyright year range in all GDB files.
7250
7251 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7252
7253         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
7254         and gdb/testsuite/gdb.base/step-line.c.
7255
7256 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7257
7258         * copyright.py (main): Dump the contents of
7259         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
7260         even if BY_HAND is empty.
7261
7262 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7263
7264         * top.c (print_gdb_version): Update Copyright year in version
7265         message.
7266
7267 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7268
7269         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
7270
7271 For older changes see ChangeLog-2017.
7272 \f
7273 Local Variables:
7274 mode: change-log
7275 left-margin: 8
7276 fill-column: 74
7277 version-control: never
7278 coding: utf-8
7279 End: