Remove exception_none
[external/binutils.git] / gdb / ChangeLog
1 2019-04-25  Tom Tromey  <tromey@adacore.com>
2
3         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6         Update.
7         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8         Update.
9         * mi/mi-interp.c (mi_interp::exec): Update.
10         * linespec.c (parse_linespec): Update.
11         * infcall.c (run_inferior_call): Update.
12         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
13         * guile/scm-symbol.c (gdbscm_lookup_symbol)
14         (gdbscm_lookup_global_symbol): Update.
15         * guile/scm-param.c (gdbscm_parameter_value): Update.
16         * guile/scm-frame.c (gdbscm_frame_read_register)
17         (gdbscm_frame_read_var): Update.
18         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
19         * exec.c (try_open_exec_file): Update.
20         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
21         (gdb_rl_callback_handler): Update.
22         * common/common-exceptions.h (exception_none): Don't declare.
23         * common/common-exceptions.c (exception_none): Don't define.
24         (struct catcher) <exception>: Update.
25         * cli/cli-interp.c (safe_execute_command): Update.
26         * breakpoint.c (insert_bp_location, location_to_sals): Update.
27
28 2019-04-25  Ali Tamur  <tamur@google.com>
29
30         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
31         (read_attribute_value): Likewise.
32         (dwarf2_read_addr_index): Update comment.
33         (read_str_index): Add DW_FORM_strx.
34         (dwarf2_string_attr): Likewise.
35         (dwarf2_const_value_attr): Likewise.
36         (dump_die_shallow): Likewise.
37         (dwarf2_fetch_constant_bytes): Likewise.
38         (skip_form_bytes): Likewise.
39         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
40
41 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
42
43         PR corefiles/11608
44         PR corefiles/18187
45         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
46         OFFSET.  Verify if current mapping contains an ELF header.
47         (linux_find_memory_regions_full): Adjust call to
48         dump_mapping_p.
49
50 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
51             Kang Li <kanglictf@gmail.com>
52
53         PR gdb/21600
54
55         * dwarf2-frame.c (read_initial_length): Be consistent about using
56         unsigned representation of length.
57         (decode_frame_entry_1): Likewise.  Check for wraparound of
58         end pointer as well as buffer overflow.
59
60 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
61
62         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
63         "vq".
64
65 2019-04-24  Tom Tromey  <tromey@adacore.com>
66
67         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
68
69 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
70
71         * s12z-tdep.c (s12z_unwind_pc): Delete.
72         (s12z_unwind_sp): Delete.
73         (s12z_gdbarch_init): Don't register deleted functions with
74         gdbarch.
75
76 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
77
78         * rl78-tdep.c (rl78_unwind_sp): Delete.
79         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
80
81 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
82
83         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
84         (xstormy16_unwind_pc): Delete.
85         (xstormy16_dummy_id): Delete.
86         (xstormy16_gdbarch_init): Don't register deleted functions with
87         gdbarch.
88
89 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
90
91         * vax-tdep.c (vax_unwind_pc): Delete.
92         (vax_gdbarch_init): Don't register deleted function with gdbarch.
93
94 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
95
96         * v850-tdep.c (v850_unwind_sp): Delete.
97         (v850_unwind_pc): Delete.
98         (v850_dummy_id): Delete.
99         (v850_gdbarch_init): Don't register deleted functions with
100         gdbarch.
101
102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
103
104         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
105         (tilegx_unwind_pc): Delete.
106         (tilegx_unwind_dummy_id): Delete.
107         (tilegx_gdbarch_init): Don't register deleted functions with
108         gdbarch.
109
110 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
111
112         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
113         (tic6x_dummy_id): Delete.
114         (tic6x_gdbarch_init): Don't register deleted functions with
115         gdbarch.
116
117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
118
119         * sparc-tdep.c (sparc_unwind_pc): Delete.
120         (sparc32_gdbarch_init): Don't register deleted function with
121         gdbarch.
122
123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
124
125         * sh-tdep.c (sh_unwind_sp): Delete.
126         (sh_unwind_pc): Delete.
127         (sh_dummy_id): Delete.
128         (sh_gdbarch_init): Don't register deleted functions with
129         gdbarch.
130
131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
132
133         * score-tdep.c (score_unwind_sp): Delete.
134         (score_unwind_pc): Delete.
135         (score_dummy_id): Delete.
136         (score_gdbarch_init): Don't register deleted functions with
137         gdbarch.
138
139 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
140
141         * rx-tdep.c (rx_unwind_pc): Delete.
142         (rx_unwind_sp): Delete.
143         (rx_dummy_id): Delete.
144         (rx_gdbarch_init): Don't register deleted functions with
145         gdbarch.  Update comment.
146
147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
148
149         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
150         (rs6000_dummy_id): Delete.
151         (rs6000_gdbarch_init): Don't register deleted functions with
152         gdbarch.
153
154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
155
156         * or1k-tdep.c (or1k_dummy_id): Delete.
157         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
158
159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
160
161         * nios2-tdep.c (nios2_dummy_id): Delete.
162         (nios2_unwind_sp): Delete.
163         (nios2_gdbarch_init): Don't register deleted functions with
164         gdbarch.
165
166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
167
168         * nds32-tdep.c (nds32_dummy_id): Delete.
169         (nds32_unwind_pc): Delete.
170         (nds32_unwind_sp): Delete.
171         (nds32_gdbarch_init): Don't register deleted functions with
172         gdbarch.
173
174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
175
176         * msp430-tdep.c (msp430_unwind_pc): Delete.
177         (msp430_unwind_sp): Delete.
178         (msp430_dummy_id): Delete.
179         (msp430_gdbarch_init): Don't register deleted functions with
180         gdbarch.
181
182 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
183
184         * moxie-tdep.c (moxie_unwind_sp): Delete.
185         (moxie_unwind_pc): Delete.
186         (moxie_dummy_id): Delete.
187         (moxie_gdbarch_init): Don't register deleted functions with
188         gdbarch.
189
190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
191
192         * mn10300-tdep.c (mn10300_dummy_id): Delete.
193         (mn10300_unwind_pc): Delete.
194         (mn10300_unwind_sp): Delete.
195         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
196         mn10300_unwind_sp.
197         (mn10300_frame_unwind_init): Don't register deleted functions with
198         gdbarch.
199
200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
201
202         * mep-tdep.c (mep_unwind_pc): Delete.
203         (mep_unwind_sp): Delete.
204         (mep_dummy_id): Delete.
205         (mep_gdbarch_init): Don't register deleted functions with
206         gdbarch.
207
208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
209
210         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
211         (m68hc11_unwind_sp): Delete.
212         (m68hc11_gdbarch_init): Don't register deleted functions with
213         gdbarch.
214
215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
216
217         * m32r-tdep.c (m32r_unwind_sp): Delete.
218         (m32r_unwind_pc): Delete.
219         (m32r_dummy_id): Delete.
220         (m32r_gdbarch_init): Don't register deleted functions with
221         gdbarch.
222
223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
224
225         * m32c-tdep.c (m32c_unwind_pc): Delete.
226         (m32c_unwind_sp): Delete.
227         (m32c_dummy_id): Delete.
228         (m32c_gdbarch_init): Don't register deleted functions with
229         gdbarch.
230
231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
232
233         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
234         (lm32_unwind_pc): Delete.
235         (lm32_dummy_id): Delete.
236         (lm32_gdbarch_init): Don't register deleted functions with
237         gdbarch.
238
239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
240
241         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
242         (iq2000_unwind_pc): Delete.
243         (iq2000_dummy_id): Delete.
244         (iq2000_gdbarch_init): Don't register deleted functions with
245         gdbarch.
246
247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
248
249         * nds32-tdep.c (nds32_type_align): Delete.
250         (nds32_push_dummy_call): Use type_align instead.
251
252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
253
254         * arm-tdep.c (arm_type_align): Only handle vector override case.
255         (arm_push_dummy_call): Use type_align.
256         (arm_gdbarch_init): Register arm_type_align gdbarch function.
257
258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
259
260         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
261         case.
262         (pass_on_stack): Use type_align.
263         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
264         function.
265
266 2019-04-23  Tom Tromey  <tromey@adacore.com>
267
268         * dwarf2read.c (line_header::file_name_at): Remove unused
269         overload.
270
271 2019-04-23  Tom de Vries  <tdevries@suse.de>
272
273         PR gdb/24438
274         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
275         invocation.
276
277
278 2019-03-27  Ali Tamur  <tamur@google.com>
279
280         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
281         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
282         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
283         (dwarf_expr_context::get_addr_index): Likewise
284         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
285         (symbol_needs_eval_context::get_addr_index): Likewise
286         (disassemble_dwarf_expression): Add DW_OP_addrx
287         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
288         (read_cutu_die_from_dwo): Update comment
289         (skip_one_die): Add DW_FORM_addrx
290         (read_attribute_value): Likewise
291         (var_decode_location): Add DW_OP_addrx
292         (dwarf2_const_value_attr): Add DW_FORM_addrx
293         (dump_die_shallow): Likewise
294         (dwarf2_fetch_constant_bytes): Likewise
295         (decode_locdesc): Add DW_OP_addrx
296         (skip_form_bytes): Add DW_FORM_addrx
297
298 2019-04-22  Ali Tamur  <tamur@google.com>
299
300         * MAINTAINERS (Write After Approval): Add self.
301
302 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
303
304         * solib-svr4.c (get_svr4_info): Add pspace parameter.
305         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
306         (open_symbol_file_object): Likewise.
307         (svr4_default_sos): Add info parameter.
308         (svr4_read_so_list): Likewise.
309         (svr4_current_sos_direct): Adjust functions calls to pass down
310         info.
311         (svr4_current_sos_1): Add info parameter.
312         (svr4_current_sos): Call get_svr4_info, pass info down to
313         svr4_current_sos_1.
314         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
315         get_svr4_info.
316         (svr4_in_dynsym_resolve_code): Pass current_program_space to
317         get_svr4_info.
318         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
319         to get_svr4_info.
320         (probes_table_remove_objfile_probes): Likewise.
321         (register_solib_event_probe): Add info parameter.
322         (solist_update_incremental): Pass info parameter down to
323         svr4_read_so_list.
324         (disable_probes_interface): Add info parameter.
325         (svr4_handle_solib_event): Pass current_program_space to
326         get_svr4_info.  Adjust disable_probes_interface cleanup.
327         (svr4_create_probe_breakpoints): Add info parameter, pass it
328         down to register_solib_event_probe.
329         (svr4_create_solib_event_breakpoints): Add info parameter,
330         pass it down to svr4_create_probe_breakpoints.
331         (enable_break): Pass info down to
332         svr4_create_solib_event_breakpoints.
333         (svr4_solib_create_inferior_hook): Pass current_program_space to
334         get_svr4_info.
335         (svr4_clear_solib): Likewise.
336
337 2019-04-22  Pedro Alves  <palves@redhat.com>
338
339         * solib-svr4.c (svr4_free_objfile_observer): New.
340         (probe_and_action::objfile): New field.
341         (probes_table_htab_remove_objfile_probes)
342         (probes_table_remove_objfile_probes): New functions.
343         (register_solib_event_probe): Add 'objfile' parameter.  Store it
344         in the new probe_and_action.  Don't store the probe in 'lookup'.
345         (svr4_create_probe_breakpoints): Pass objfile to
346         register_solib_event_probe.
347         (_initialize_svr4_solib): Register a free_objfile observer.
348
349 2019-04-19  Tom Tromey  <tom@tromey.com>
350
351         * common/queue.h: Remove.
352
353 2019-04-19  Tom Tromey  <tom@tromey.com>
354
355         * event-loop.c: Don't include "common/queue.h".
356
357 2019-04-19  Tom Tromey  <tom@tromey.com>
358
359         * remote.c (remote_target): Use delete.
360         * remote-notif.h: Include <list>, not "common/queue.h".
361         (notif_client_p): Remove typedef.
362         (remote_notif_state): Add constructor, destructor, initializer.
363         <notif_queue>: Now a std::list.
364         (remote_notif_state_xfree): Don't declare.
365         * remote-notif.c (remote_notif_process, handle_notification)
366         (remote_notif_state_allocate): Update.
367         (~remote_notif_state): Rename from remote_notif_state_xfree.
368
369 2019-04-19  Tom Tromey  <tom@tromey.com>
370
371         * symfile.c (reread_symbols): Update.
372         * objfiles.c (objfile_register_static_link)
373         (objfile_lookup_static_link): Update
374         (~objfile) Don't delete static_links.
375         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
376
377 2019-04-19  Tom Tromey  <tom@tromey.com>
378
379         * type-stack.h (struct type_stack) <insert>: Constify string.
380         * type-stack.c (type_stack::insert): Constify string.
381         * gdbtypes.h (lookup_template_type): Update.
382         (address_space_name_to_int): Update.
383         * gdbtypes.c (address_space_name_to_int): Make space_identifier
384         const.
385         (lookup_template_type): Make name const.
386         * c-exp.y: Update rules.
387         (lex_one_token, classify_name, classify_inner_name)
388         (c_print_token): Update.
389         * p-exp.y: Update rules.
390         (yylex): Update.
391         * f-exp.y: Update rules.
392         (yylex): Update.
393         * d-exp.y: Update rules.
394         (lex_one_token, classify_name, classify_inner_name): Update.
395         * parse.c (write_dollar_variable, copy_name): Return std::string.
396         * parser-defs.h (copy_name): Change return type.
397         * m2-exp.y: Update rules.
398         (yylex): Update.
399         * go-exp.y (lex_one_token): Update.
400         Update rules.
401         (classify_unsafe_function, classify_packaged_name)
402         (classify_name, yylex): Update.
403
404 2019-04-19  Sergei Trofimovich <siarheit@google.com>
405
406         * configure.ac: add --enable-source-highlight switch.
407         * configure: Regenerate.
408         * top.c (print_gdb_version): plumb --enable-source-highlight
409         status to "show configuration".
410
411 2019-04-19  Tom Tromey  <tromey@adacore.com>
412
413         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
414         Check ADA_TYPE_P.
415         (empty_record, ada_template_to_fixed_record_type_1)
416         (template_to_static_fixed_type)
417         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
418         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
419         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
420         macros.
421
422 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
423
424         PR symtab/24423:
425         * source.c (print_source_lines_base): Advance "iter" when a
426         control character is seen.
427
428 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
429
430         * inferior.h (struct infcall_suspend_state_deleter):
431         Catch exception in destructor to avoid crash.
432
433 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
434
435         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
436         close to the add_com "shell".
437
438 2019-04-18  Tom Tromey  <tromey@adacore.com>
439
440         * process-stratum-target.h (class process_stratum_target)
441         <stratum>: Add "final".
442
443 2019-04-17  Tom Tromey  <tromey@adacore.com>
444
445         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
446         against nullptr before use.
447
448 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
449
450         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
451
452 2019-04-17  Jim Wilson  <jimw@sifive.com>
453             Andrew Burgess  <andrew.burgess@embecosm.com>
454
455         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
456         code read might fail, assume 4-byte breakpoint in that case.
457
458 2019-04-15  Leszek Swirski  <leszeks@google.com>
459
460         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
461         rather than a hand-rolled POD check when checking for forced MEMORY
462         classification.
463
464 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
465
466         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
467         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
468         function.
469         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
470         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
471         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
472         declaration.
473
474 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
475
476         * aarch64-linux-nat.c
477         (aarch64_linux_nat_target::thread_architecture): Add override.
478         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
479         each VQ.
480
481 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
482
483         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
484
485 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
486
487         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
488         target types of size 96-bits, add some additional comments, and
489         check that the builtin type we found was the correct size.
490
491 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
492
493         * utils.c (prompt_for_continue): Don't restore the styling at the
494         end, as applied_style has the wrong value.  This fixes styling in
495         long lists of file names that are interrupted by the "Continue?"
496         prompt.
497
498 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
499
500         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
501         * c-lang.c (c_language_defn): Likewise.
502         (cplus_language_defn): Likewise.
503         (asm_language_defn): Likewise.
504         (minimal_language_defn): Likewise.
505         * d-lang.c (d_language_defn): Likewise.
506         * f-lang.c (f_language_defn): Likewise.
507         * go-lang.c (go_language_defn): Likewise.
508         * language.c (unknown_language_defn): Likewise.
509         (auto_language_defn): Likewise.
510         * language.h (struct language_defn): Remove la_magic field.
511         (LANG_MAGIC): Delete.
512         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
513         * objc-lang.c (objc_language_defn): Likewise.
514         * opencl-lang.c (opencl_language_defn): Likewise.
515         * p-lang.c (pascal_language_defn): Likewise.
516         * rust-lang.c (rust_language_defn): Likewise.
517
518 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
519
520         * riscv-tdep.c (riscv_type_align): New function.
521         (riscv_type_alignment): Delete.
522         (riscv_arg_location): Use 'type_align'.
523         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
524
525 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
526
527         * gdbtypes.c (type_align): A struct with no non-static fields also
528         has alignment of 1.
529
530 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
531
532         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
533         component to 0.
534         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
535         member.
536         (riscv_struct_info::analyse): New implementation using new
537         analyse_inner member function.
538         (riscv_struct_info::field_offset): New member function.
539         (riscv_struct_info::m_offsets): New member variable.
540         (riscv_struct_info::analyse_inner): New private member function,
541         takes the old implementation of riscv_struct_info::analyse but
542         extended to track field offsets.
543         (riscv_call_arg_struct): Update the struct folding special cases
544         to handle cases where empty C++ structs, which are non-zero
545         length, are found.
546         (riscv_arg_location): Initialise the length of each location, a
547         non-zero length now indicates the location is in use.
548         (riscv_push_dummy_call): Allow for the first location having a
549         non-zero offset when setting up arguments.
550         (riscv_return_value): Likewise, but for return values.
551
552 2019-04-11  Tom Tromey  <tromey@adacore.com>
553
554         * utils.c (internal_vproblem): Make "msg" const.
555
556 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
557
558         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
559         * trad-frame.c (trad_frame_reset_saved_regs): New function.
560         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
561         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
562
563 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
564
565         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
566         function.
567         (fill_gregset): Call amd64_linux_collect_native_gregset instead
568         of amd64_collect_native_gregset.
569         (amd64_linux_nat_target::store_registers): Likewise.
570
571 2019-04-10  Tom Tromey  <tom@tromey.com>
572
573         * symtab.c (lookup_global_symbol_from_objfile)
574         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
575         * objfiles.h (class separate_debug_iterator): New.
576         (class separate_debug_range): New.
577         (struct objfile) <separate_debug_objfiles>: New method.
578         (objfile_separate_debug_iterate): Don't declare.
579         * objfiles.c (separate_debug_iterator::operator++): Rename from
580         objfile_separate_debug_iterate.
581         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
582         iterator.
583         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
584         iterator.
585
586 2019-04-10  Tom Tromey  <tom@tromey.com>
587
588         * symfile.c (reread_symbols): Remove old comment.
589         * objfiles.c (free_all_objfiles): Fix a typo.
590
591 2019-04-10  Tom Tromey  <tom@tromey.com>
592
593         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
594         * minsyms.c (lookup_minimal_symbol): Use foreach.
595         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
596         (lookup_minimal_symbol_solib_trampoline): Likewise.
597         * symfile.c (reread_symbols): Use foreach.
598
599 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
600             Tom Tromey  <tromey@adacore.com>
601
602         PR rust/24414:
603         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
604         (rust_lex_int_test): Change "value" to be LONGEST.
605         (rust_lex_tests): Add test for long integer literal.
606
607 2019-04-09  Tom Tromey  <tromey@adacore.com>
608
609         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
610         to bool.
611         (extended_remote_target::attach): Update.
612         (remote_target::remote_notice_new_inferior): Update.
613         (remote_target::add_current_inferior_and_thread): Update.
614         * inferior.c (exit_inferior_1): Use "false".
615         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
616
617 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
618
619         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
620         the "start" command.
621
622 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
623
624         * python/py-inferior.c (infpy_thread_from_thread_handle):
625         Adjust comments to reflect renaming of thread_from_thread_handle
626         to thread_from_handle.  Adjust keywords.  Fix type error message.
627         (inferior_object_methods): Add thread_from_handle.  Retain
628         thread_from_thread_handle, but mark it as deprecated.
629
630 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
631
632         * gdbthread.h (find_thread_by_handle): Revise declaration.
633         * thread.c (find_thread_by_handle): Likewise.  Adjust
634         implementation too.
635         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
636         support for buffer objects as handles.
637
638 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
639
640         * python/py-infthread.c (thpy_thread_handle): New function.
641         (thread_object_methods): Register thpy_thread_handle.
642
643 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
644
645         * gdbthread.h (thread_to_thread_handle): Declare.
646         * thread.c (gdbtypes.h): Include.
647         (thread_to_thread_handle): New function.
648
649         * target.h (struct target_ops): Add thread_info_to_thread_handle.
650         (target_thread_info_to_thread_handle): Declare.
651         * target.c (target_thread_info_to_thread_handle): New function.
652         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
653         * target-delegates.c: Regenerate.
654
655         * linux-thread-db.c (class thread_db_target): Add method
656         thread_info_to_thread_handle.
657         (thread_db_target::thread_info_to_thread_handle): Define.
658         * remote.c (class remote_target): Add new method
659         thread_info_to_thread_handle.
660         (remote_target::thread_info_to_thread_handle): Define.
661
662 2019-04-08  Pedro Alves  <palves@redhat.com>
663
664         * common/common-exceptions.c (throw_exception): Don't create
665         named object to throw; throw directly.
666         (throw_it): Likewise.  Don't initialize gdb_exception::message
667         here, with new; pass FMT and AP to the ctor instead.
668         * common/common-exceptions.h: Include <string>.
669         (gdb_exception::gdb_exception(enum return_reason, enum errors,
670         const char *, va_list)): New ctor.  Use std::make_shared.
671         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
672         errors)): Delete.
673         (gdb_exception_error::gdb_exception_error(enum errors, const char
674         *, va_list)): New.
675         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
676         Add assertion.
677         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
678         errors)): Delete.
679         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
680         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
681         Add assertion.
682
683 2019-04-08  Tom Tromey  <tom@tromey.com>
684
685         * valops.c (value_rtti_indirect_type): Replace throw_exception
686         with throw.
687         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
688         with throw.
689         * thread.c (thr_try_catch_cmd): Replace throw_exception with
690         throw.
691         * target.c (target_translate_tls_address): Replace throw_exception
692         with throw.
693         * stack.c (frame_apply_command_count): Replace throw_exception
694         with throw.
695         * solib-spu.c (append_ocl_sos): Replace throw_exception with
696         throw.
697         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
698         with throw.
699         * rs6000-tdep.c (rs6000_frame_cache)
700         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
701         * remote.c: Replace throw_exception with throw.
702         * record-full.c (record_full_message, record_full_wait_1)
703         (record_full_restore): Replace throw_exception with throw.
704         * record-btrace.c:
705         (get_thread_current_frame_id, record_btrace_start_replaying)
706         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
707         (cmd_record_btrace_start): Replace throw_exception with throw.
708         * parse.c (parse_exp_in_context_1): Replace throw_exception with
709         throw.
710         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
711         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
712         * linespec.c:
713         (find_linespec_symbols): Replace throw_exception with throw.
714         * infrun.c (displaced_step_prepare, resume): Replace
715         throw_exception with throw.
716         * infcmd.c (post_create_inferior): Replace throw_exception with
717         throw.
718         * inf-loop.c (inferior_event_handler): Replace throw_exception
719         with throw.
720         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
721         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
722         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
723         (get_prev_frame_always, get_frame_pc_if_available)
724         (get_frame_address_in_block_if_available, get_frame_language):
725         Replace throw_exception with throw.
726         * frame-unwind.c (frame_unwind_try_unwinder): Replace
727         throw_exception with throw.
728         * eval.c (fetch_subexp_value, evaluate_var_value)
729         (evaluate_funcall, evaluate_subexp_standard): Replace
730         throw_exception with throw.
731         * dwarf2loc.c (call_site_find_chain)
732         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
733         Replace throw_exception with throw.
734         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
735         with throw.
736         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
737         throw.
738         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
739         * completer.c (complete_line_internal): Replace throw_exception
740         with throw.
741         * compile/compile-object-run.c (compile_object_run): Replace
742         throw_exception with throw.
743         * cli/cli-script.c (process_next_line): Replace throw_exception
744         with throw.
745         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
746         (btrace_enable, btrace_maint_update_pt_packets): Replace
747         throw_exception with throw.
748         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
749         throw_exception with throw.
750         * break-catch-throw.c (re_set_exception_catchpoint): Replace
751         throw_exception with throw.
752         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
753         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
754         * aarch64-tdep.c (aarch64_make_prologue_cache)
755         (aarch64_make_stub_cache): Replace throw_exception with throw.
756
757 2019-04-08  Tom Tromey  <tom@tromey.com>
758
759         * common/common-exceptions.c (throw_exception): Rename from
760         throw_exception_cxx.  Remove old copy.  Make argument const.
761         (throw_it): Create and throw exception objects directly.
762         * common/common-exceptions.h (throw_exception): Make argument
763         const.
764         (struct gdb_exception_error): Add constructor.
765         (struct gdb_exception_quit): Add constructor.
766
767 2019-04-08  Tom Tromey  <tom@tromey.com>
768
769         * common/common-exceptions.h (exception_rethrow): Don't declare.
770         (TRY_SJLJ): Update comment.
771         (TRY, CATCH, END_CATCH): Remove.
772         * common/common-exceptions.c (exception_rethrow): Remove.
773
774 2019-04-08  Tom Tromey  <tom@tromey.com>
775
776         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
777         Remove.
778         (gdb_exception_error): Rename from
779         gdb_exception_RETURN_MASK_ERROR.
780         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
781         (gdb_quit_bad_alloc): Update.
782         * aarch64-tdep.c: Update.
783         * ada-lang.c: Update.
784         * ada-typeprint.c: Update.
785         * ada-valprint.c: Update.
786         * amd64-tdep.c: Update.
787         * arch-utils.c: Update.
788         * break-catch-throw.c: Update.
789         * breakpoint.c: Update.
790         * btrace.c: Update.
791         * c-varobj.c: Update.
792         * cli/cli-cmds.c: Update.
793         * cli/cli-interp.c: Update.
794         * cli/cli-script.c: Update.
795         * common/common-exceptions.c: Update.
796         * common/new-op.c: Update.
797         * common/selftest.c: Update.
798         * compile/compile-c-symbols.c: Update.
799         * compile/compile-cplus-symbols.c: Update.
800         * compile/compile-object-load.c: Update.
801         * compile/compile-object-run.c: Update.
802         * completer.c: Update.
803         * corelow.c: Update.
804         * cp-abi.c: Update.
805         * cp-support.c: Update.
806         * cp-valprint.c: Update.
807         * darwin-nat.c: Update.
808         * disasm-selftests.c: Update.
809         * dtrace-probe.c: Update.
810         * dwarf-index-cache.c: Update.
811         * dwarf-index-write.c: Update.
812         * dwarf2-frame-tailcall.c: Update.
813         * dwarf2-frame.c: Update.
814         * dwarf2loc.c: Update.
815         * dwarf2read.c: Update.
816         * eval.c: Update.
817         * event-loop.c: Update.
818         * event-top.c: Update.
819         * exec.c: Update.
820         * f-valprint.c: Update.
821         * fbsd-tdep.c: Update.
822         * frame-unwind.c: Update.
823         * frame.c: Update.
824         * gdbtypes.c: Update.
825         * gnu-v3-abi.c: Update.
826         * guile/guile-internal.h: Update.
827         * guile/scm-block.c: Update.
828         * guile/scm-breakpoint.c: Update.
829         * guile/scm-cmd.c: Update.
830         * guile/scm-disasm.c: Update.
831         * guile/scm-frame.c: Update.
832         * guile/scm-lazy-string.c: Update.
833         * guile/scm-math.c: Update.
834         * guile/scm-param.c: Update.
835         * guile/scm-ports.c: Update.
836         * guile/scm-pretty-print.c: Update.
837         * guile/scm-symbol.c: Update.
838         * guile/scm-symtab.c: Update.
839         * guile/scm-type.c: Update.
840         * guile/scm-value.c: Update.
841         * i386-linux-tdep.c: Update.
842         * i386-tdep.c: Update.
843         * inf-loop.c: Update.
844         * infcall.c: Update.
845         * infcmd.c: Update.
846         * infrun.c: Update.
847         * jit.c: Update.
848         * language.c: Update.
849         * linespec.c: Update.
850         * linux-fork.c: Update.
851         * linux-nat.c: Update.
852         * linux-tdep.c: Update.
853         * linux-thread-db.c: Update.
854         * main.c: Update.
855         * mi/mi-cmd-break.c: Update.
856         * mi/mi-cmd-stack.c: Update.
857         * mi/mi-interp.c: Update.
858         * mi/mi-main.c: Update.
859         * objc-lang.c: Update.
860         * p-valprint.c: Update.
861         * parse.c: Update.
862         * ppc-linux-tdep.c: Update.
863         * printcmd.c: Update.
864         * python/py-arch.c: Update.
865         * python/py-breakpoint.c: Update.
866         * python/py-cmd.c: Update.
867         * python/py-finishbreakpoint.c: Update.
868         * python/py-frame.c: Update.
869         * python/py-framefilter.c: Update.
870         * python/py-gdb-readline.c: Update.
871         * python/py-inferior.c: Update.
872         * python/py-infthread.c: Update.
873         * python/py-lazy-string.c: Update.
874         * python/py-linetable.c: Update.
875         * python/py-objfile.c: Update.
876         * python/py-param.c: Update.
877         * python/py-prettyprint.c: Update.
878         * python/py-progspace.c: Update.
879         * python/py-record-btrace.c: Update.
880         * python/py-record.c: Update.
881         * python/py-symbol.c: Update.
882         * python/py-type.c: Update.
883         * python/py-unwind.c: Update.
884         * python/py-utils.c: Update.
885         * python/py-value.c: Update.
886         * python/python.c: Update.
887         * record-btrace.c: Update.
888         * record-full.c: Update.
889         * remote-fileio.c: Update.
890         * remote.c: Update.
891         * riscv-tdep.c: Update.
892         * rs6000-aix-tdep.c: Update.
893         * rs6000-tdep.c: Update.
894         * rust-exp.y: Update.
895         * rust-lang.c: Update.
896         * s390-tdep.c: Update.
897         * selftest-arch.c: Update.
898         * solib-dsbt.c: Update.
899         * solib-frv.c: Update.
900         * solib-spu.c: Update.
901         * solib-svr4.c: Update.
902         * solib.c: Update.
903         * sparc64-linux-tdep.c: Update.
904         * stack.c: Update.
905         * symfile-mem.c: Update.
906         * symmisc.c: Update.
907         * target.c: Update.
908         * thread.c: Update.
909         * top.c: Update.
910         * tracefile-tfile.c: Update.
911         * tui/tui.c: Update.
912         * typeprint.c: Update.
913         * unittests/cli-utils-selftests.c: Update.
914         * unittests/parse-connection-spec-selftests.c: Update.
915         * valops.c: Update.
916         * valprint.c: Update.
917         * value.c: Update.
918         * varobj.c: Update.
919         * windows-nat.c: Update.
920         * x86-linux-nat.c: Update.
921         * xml-support.c: Update.
922
923 2019-04-08  Tom Tromey  <tom@tromey.com>
924
925         * xml-support.c: Use C++ exception handling.
926         * x86-linux-nat.c: Use C++ exception handling.
927         * windows-nat.c: Use C++ exception handling.
928         * varobj.c: Use C++ exception handling.
929         * value.c: Use C++ exception handling.
930         * valprint.c: Use C++ exception handling.
931         * valops.c: Use C++ exception handling.
932         * unittests/parse-connection-spec-selftests.c: Use C++ exception
933         handling.
934         * unittests/cli-utils-selftests.c: Use C++ exception handling.
935         * typeprint.c: Use C++ exception handling.
936         * tui/tui.c: Use C++ exception handling.
937         * tracefile-tfile.c: Use C++ exception handling.
938         * top.c: Use C++ exception handling.
939         * thread.c: Use C++ exception handling.
940         * target.c: Use C++ exception handling.
941         * symmisc.c: Use C++ exception handling.
942         * symfile-mem.c: Use C++ exception handling.
943         * stack.c: Use C++ exception handling.
944         * sparc64-linux-tdep.c: Use C++ exception handling.
945         * solib.c: Use C++ exception handling.
946         * solib-svr4.c: Use C++ exception handling.
947         * solib-spu.c: Use C++ exception handling.
948         * solib-frv.c: Use C++ exception handling.
949         * solib-dsbt.c: Use C++ exception handling.
950         * selftest-arch.c: Use C++ exception handling.
951         * s390-tdep.c: Use C++ exception handling.
952         * rust-lang.c: Use C++ exception handling.
953         * rust-exp.y: Use C++ exception handling.
954         * rs6000-tdep.c: Use C++ exception handling.
955         * rs6000-aix-tdep.c: Use C++ exception handling.
956         * riscv-tdep.c: Use C++ exception handling.
957         * remote.c: Use C++ exception handling.
958         * remote-fileio.c: Use C++ exception handling.
959         * record-full.c: Use C++ exception handling.
960         * record-btrace.c: Use C++ exception handling.
961         * python/python.c: Use C++ exception handling.
962         * python/py-value.c: Use C++ exception handling.
963         * python/py-utils.c: Use C++ exception handling.
964         * python/py-unwind.c: Use C++ exception handling.
965         * python/py-type.c: Use C++ exception handling.
966         * python/py-symbol.c: Use C++ exception handling.
967         * python/py-record.c: Use C++ exception handling.
968         * python/py-record-btrace.c: Use C++ exception handling.
969         * python/py-progspace.c: Use C++ exception handling.
970         * python/py-prettyprint.c: Use C++ exception handling.
971         * python/py-param.c: Use C++ exception handling.
972         * python/py-objfile.c: Use C++ exception handling.
973         * python/py-linetable.c: Use C++ exception handling.
974         * python/py-lazy-string.c: Use C++ exception handling.
975         * python/py-infthread.c: Use C++ exception handling.
976         * python/py-inferior.c: Use C++ exception handling.
977         * python/py-gdb-readline.c: Use C++ exception handling.
978         * python/py-framefilter.c: Use C++ exception handling.
979         * python/py-frame.c: Use C++ exception handling.
980         * python/py-finishbreakpoint.c: Use C++ exception handling.
981         * python/py-cmd.c: Use C++ exception handling.
982         * python/py-breakpoint.c: Use C++ exception handling.
983         * python/py-arch.c: Use C++ exception handling.
984         * printcmd.c: Use C++ exception handling.
985         * ppc-linux-tdep.c: Use C++ exception handling.
986         * parse.c: Use C++ exception handling.
987         * p-valprint.c: Use C++ exception handling.
988         * objc-lang.c: Use C++ exception handling.
989         * mi/mi-main.c: Use C++ exception handling.
990         * mi/mi-interp.c: Use C++ exception handling.
991         * mi/mi-cmd-stack.c: Use C++ exception handling.
992         * mi/mi-cmd-break.c: Use C++ exception handling.
993         * main.c: Use C++ exception handling.
994         * linux-thread-db.c: Use C++ exception handling.
995         * linux-tdep.c: Use C++ exception handling.
996         * linux-nat.c: Use C++ exception handling.
997         * linux-fork.c: Use C++ exception handling.
998         * linespec.c: Use C++ exception handling.
999         * language.c: Use C++ exception handling.
1000         * jit.c: Use C++ exception handling.
1001         * infrun.c: Use C++ exception handling.
1002         * infcmd.c: Use C++ exception handling.
1003         * infcall.c: Use C++ exception handling.
1004         * inf-loop.c: Use C++ exception handling.
1005         * i386-tdep.c: Use C++ exception handling.
1006         * i386-linux-tdep.c: Use C++ exception handling.
1007         * guile/scm-value.c: Use C++ exception handling.
1008         * guile/scm-type.c: Use C++ exception handling.
1009         * guile/scm-symtab.c: Use C++ exception handling.
1010         * guile/scm-symbol.c: Use C++ exception handling.
1011         * guile/scm-pretty-print.c: Use C++ exception handling.
1012         * guile/scm-ports.c: Use C++ exception handling.
1013         * guile/scm-param.c: Use C++ exception handling.
1014         * guile/scm-math.c: Use C++ exception handling.
1015         * guile/scm-lazy-string.c: Use C++ exception handling.
1016         * guile/scm-frame.c: Use C++ exception handling.
1017         * guile/scm-disasm.c: Use C++ exception handling.
1018         * guile/scm-cmd.c: Use C++ exception handling.
1019         * guile/scm-breakpoint.c: Use C++ exception handling.
1020         * guile/scm-block.c: Use C++ exception handling.
1021         * guile/guile-internal.h: Use C++ exception handling.
1022         * gnu-v3-abi.c: Use C++ exception handling.
1023         * gdbtypes.c: Use C++ exception handling.
1024         * frame.c: Use C++ exception handling.
1025         * frame-unwind.c: Use C++ exception handling.
1026         * fbsd-tdep.c: Use C++ exception handling.
1027         * f-valprint.c: Use C++ exception handling.
1028         * exec.c: Use C++ exception handling.
1029         * event-top.c: Use C++ exception handling.
1030         * event-loop.c: Use C++ exception handling.
1031         * eval.c: Use C++ exception handling.
1032         * dwarf2read.c: Use C++ exception handling.
1033         * dwarf2loc.c: Use C++ exception handling.
1034         * dwarf2-frame.c: Use C++ exception handling.
1035         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1036         * dwarf-index-write.c: Use C++ exception handling.
1037         * dwarf-index-cache.c: Use C++ exception handling.
1038         * dtrace-probe.c: Use C++ exception handling.
1039         * disasm-selftests.c: Use C++ exception handling.
1040         * darwin-nat.c: Use C++ exception handling.
1041         * cp-valprint.c: Use C++ exception handling.
1042         * cp-support.c: Use C++ exception handling.
1043         * cp-abi.c: Use C++ exception handling.
1044         * corelow.c: Use C++ exception handling.
1045         * completer.c: Use C++ exception handling.
1046         * compile/compile-object-run.c: Use C++ exception handling.
1047         * compile/compile-object-load.c: Use C++ exception handling.
1048         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1049         * compile/compile-c-symbols.c: Use C++ exception handling.
1050         * common/selftest.c: Use C++ exception handling.
1051         * common/new-op.c: Use C++ exception handling.
1052         * cli/cli-script.c: Use C++ exception handling.
1053         * cli/cli-interp.c: Use C++ exception handling.
1054         * cli/cli-cmds.c: Use C++ exception handling.
1055         * c-varobj.c: Use C++ exception handling.
1056         * btrace.c: Use C++ exception handling.
1057         * breakpoint.c: Use C++ exception handling.
1058         * break-catch-throw.c: Use C++ exception handling.
1059         * arch-utils.c: Use C++ exception handling.
1060         * amd64-tdep.c: Use C++ exception handling.
1061         * ada-valprint.c: Use C++ exception handling.
1062         * ada-typeprint.c: Use C++ exception handling.
1063         * ada-lang.c: Use C++ exception handling.
1064         * aarch64-tdep.c: Use C++ exception handling.
1065
1066 2019-04-08  Tom Tromey  <tom@tromey.com>
1067
1068         * xml-support.c (gdb_xml_parser::parse): Update.
1069         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1070         * value.c (show_convenience): Update.
1071         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1072         (test_parse_flags_qcs): Update.
1073         * thread.c (thr_try_catch_cmd): Update.
1074         * target.c (target_translate_tls_address): Update.
1075         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1076         (info_frame_command_core, frame_apply_command_count): Update.
1077         * rust-exp.y (rust_lex_exception_test): Update.
1078         * riscv-tdep.c (riscv_print_one_register_info): Update.
1079         * remote.c (remote_target::enable_btrace): Update.
1080         * record-btrace.c (record_btrace_enable_warn): Update.
1081         * python/py-utils.c (gdbpy_convert_exception): Update.
1082         * printcmd.c (do_one_display, print_variable_and_value): Update.
1083         * mi/mi-main.c (mi_print_exception): Update.
1084         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1085         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1086         * linux-nat.c (linux_nat_target::attach): Update.
1087         * linux-fork.c (class scoped_switch_fork_info): Update.
1088         * infrun.c (displaced_step_prepare): Update.
1089         * infcall.c (call_function_by_hand_dummy): Update.
1090         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1091         * gnu-v3-abi.c (print_one_vtable): Update.
1092         * frame.c (get_prev_frame_always): Update.
1093         * f-valprint.c (info_common_command_for_block): Update.
1094         * exec.c (try_open_exec_file): Update.
1095         * exceptions.c (print_exception, exception_print)
1096         (exception_fprintf, exception_print_same): Update.
1097         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1098         * dwarf-index-cache.c (index_cache::store)
1099         (index_cache::lookup_gdb_index): Update.
1100         * darwin-nat.c (maybe_cache_shell): Update.
1101         * cp-valprint.c (cp_print_value_fields): Update.
1102         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1103         (gcc_cplus_symbol_address): Update.
1104         * compile/compile-c-symbols.c (gcc_convert_symbol)
1105         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1106         * common/selftest.c: Update.
1107         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1108         a std::string.
1109         (exception_try_scope_entry, exception_try_scope_exit): Don't
1110         declare.
1111         (struct exception_try_scope): Remove.
1112         (TRY): Don't use exception_try_scope.
1113         (struct gdb_exception): Add constructor, operator=.
1114         <what>: New method.
1115         (struct gdb_exception_RETURN_MASK_ALL)
1116         (struct gdb_exception_RETURN_MASK_ERROR)
1117         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1118         (struct gdb_quit_bad_alloc): Update.
1119         * common/common-exceptions.c (exception_none): Change
1120         initializer.
1121         (struct catcher) <state, exception>: Initialize inline.
1122         <prev>: Remove member.
1123         (current_catcher): Remove.
1124         (catchers): New global.
1125         (exceptions_state_mc_init): Simplify.
1126         (catcher_pop): Remove.
1127         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1128         (try_scope_depth, exception_try_scope_entry)
1129         (exception_try_scope_exit): Remove.
1130         (throw_exception_sjlj): Update.
1131         (exception_messages, exception_messages_size): Remove.
1132         (throw_it): Simplify.
1133         (gdb_exception_sliced_copy): Remove.
1134         (throw_exception_cxx): Update.
1135         * cli/cli-script.c (script_from_file): Update.
1136         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1137         Update.
1138         * ada-valprint.c (ada_val_print): Update.
1139         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1140         (create_excep_cond_exprs): Update.
1141
1142 2019-04-08  Tom Tromey  <tom@tromey.com>
1143
1144         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1145         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1146         (TRY, CATCH, END_CATCH): Remove some definitions.
1147         * common/common-exceptions.c: Don't use GDB_XCPT.
1148         (catcher_list_size): Remove.
1149         (throw_exception, throw_it): Simplify.
1150
1151 2019-04-05  Tom Tromey  <tom@tromey.com>
1152
1153         Revert the header-sorting patch.
1154         * ft32-tdep.c: Revert.
1155         * frv-tdep.c: Revert.
1156         * frv-linux-tdep.c: Revert.
1157         * frame.c: Revert.
1158         * frame-unwind.c: Revert.
1159         * frame-base.c: Revert.
1160         * fork-child.c: Revert.
1161         * findvar.c: Revert.
1162         * findcmd.c: Revert.
1163         * filesystem.c: Revert.
1164         * filename-seen-cache.h: Revert.
1165         * filename-seen-cache.c: Revert.
1166         * fbsd-tdep.c: Revert.
1167         * fbsd-nat.h: Revert.
1168         * fbsd-nat.c: Revert.
1169         * f-valprint.c: Revert.
1170         * f-typeprint.c: Revert.
1171         * f-lang.c: Revert.
1172         * extension.h: Revert.
1173         * extension.c: Revert.
1174         * extension-priv.h: Revert.
1175         * expprint.c: Revert.
1176         * exec.h: Revert.
1177         * exec.c: Revert.
1178         * exceptions.c: Revert.
1179         * event-top.c: Revert.
1180         * event-loop.c: Revert.
1181         * eval.c: Revert.
1182         * elfread.c: Revert.
1183         * dwarf2read.h: Revert.
1184         * dwarf2read.c: Revert.
1185         * dwarf2loc.c: Revert.
1186         * dwarf2expr.h: Revert.
1187         * dwarf2expr.c: Revert.
1188         * dwarf2-frame.c: Revert.
1189         * dwarf2-frame-tailcall.c: Revert.
1190         * dwarf-index-write.h: Revert.
1191         * dwarf-index-write.c: Revert.
1192         * dwarf-index-common.c: Revert.
1193         * dwarf-index-cache.h: Revert.
1194         * dwarf-index-cache.c: Revert.
1195         * dummy-frame.c: Revert.
1196         * dtrace-probe.c: Revert.
1197         * disasm.h: Revert.
1198         * disasm.c: Revert.
1199         * disasm-selftests.c: Revert.
1200         * dictionary.c: Revert.
1201         * dicos-tdep.c: Revert.
1202         * demangle.c: Revert.
1203         * dcache.h: Revert.
1204         * dcache.c: Revert.
1205         * darwin-nat.h: Revert.
1206         * darwin-nat.c: Revert.
1207         * darwin-nat-info.c: Revert.
1208         * d-valprint.c: Revert.
1209         * d-namespace.c: Revert.
1210         * d-lang.c: Revert.
1211         * ctf.c: Revert.
1212         * csky-tdep.c: Revert.
1213         * csky-linux-tdep.c: Revert.
1214         * cris-tdep.c: Revert.
1215         * cris-linux-tdep.c: Revert.
1216         * cp-valprint.c: Revert.
1217         * cp-support.c: Revert.
1218         * cp-namespace.c: Revert.
1219         * cp-abi.c: Revert.
1220         * corelow.c: Revert.
1221         * corefile.c: Revert.
1222         * continuations.c: Revert.
1223         * completer.h: Revert.
1224         * completer.c: Revert.
1225         * complaints.c: Revert.
1226         * coffread.c: Revert.
1227         * coff-pe-read.c: Revert.
1228         * cli-out.h: Revert.
1229         * cli-out.c: Revert.
1230         * charset.c: Revert.
1231         * c-varobj.c: Revert.
1232         * c-valprint.c: Revert.
1233         * c-typeprint.c: Revert.
1234         * c-lang.c: Revert.
1235         * buildsym.c: Revert.
1236         * buildsym-legacy.c: Revert.
1237         * build-id.h: Revert.
1238         * build-id.c: Revert.
1239         * btrace.c: Revert.
1240         * bsd-uthread.c: Revert.
1241         * breakpoint.h: Revert.
1242         * breakpoint.c: Revert.
1243         * break-catch-throw.c: Revert.
1244         * break-catch-syscall.c: Revert.
1245         * break-catch-sig.c: Revert.
1246         * blockframe.c: Revert.
1247         * block.c: Revert.
1248         * bfin-tdep.c: Revert.
1249         * bfin-linux-tdep.c: Revert.
1250         * bfd-target.c: Revert.
1251         * bcache.c: Revert.
1252         * ax-general.c: Revert.
1253         * ax-gdb.h: Revert.
1254         * ax-gdb.c: Revert.
1255         * avr-tdep.c: Revert.
1256         * auxv.c: Revert.
1257         * auto-load.c: Revert.
1258         * arm-wince-tdep.c: Revert.
1259         * arm-tdep.c: Revert.
1260         * arm-symbian-tdep.c: Revert.
1261         * arm-pikeos-tdep.c: Revert.
1262         * arm-obsd-tdep.c: Revert.
1263         * arm-nbsd-tdep.c: Revert.
1264         * arm-nbsd-nat.c: Revert.
1265         * arm-linux-tdep.c: Revert.
1266         * arm-linux-nat.c: Revert.
1267         * arm-fbsd-tdep.c: Revert.
1268         * arm-fbsd-nat.c: Revert.
1269         * arm-bsd-tdep.c: Revert.
1270         * arch-utils.c: Revert.
1271         * arc-tdep.c: Revert.
1272         * arc-newlib-tdep.c: Revert.
1273         * annotate.h: Revert.
1274         * annotate.c: Revert.
1275         * amd64-windows-tdep.c: Revert.
1276         * amd64-windows-nat.c: Revert.
1277         * amd64-tdep.c: Revert.
1278         * amd64-sol2-tdep.c: Revert.
1279         * amd64-obsd-tdep.c: Revert.
1280         * amd64-obsd-nat.c: Revert.
1281         * amd64-nbsd-tdep.c: Revert.
1282         * amd64-nbsd-nat.c: Revert.
1283         * amd64-nat.c: Revert.
1284         * amd64-linux-tdep.c: Revert.
1285         * amd64-linux-nat.c: Revert.
1286         * amd64-fbsd-tdep.c: Revert.
1287         * amd64-fbsd-nat.c: Revert.
1288         * amd64-dicos-tdep.c: Revert.
1289         * amd64-darwin-tdep.c: Revert.
1290         * amd64-bsd-nat.c: Revert.
1291         * alpha-tdep.c: Revert.
1292         * alpha-obsd-tdep.c: Revert.
1293         * alpha-nbsd-tdep.c: Revert.
1294         * alpha-mdebug-tdep.c: Revert.
1295         * alpha-linux-tdep.c: Revert.
1296         * alpha-linux-nat.c: Revert.
1297         * alpha-bsd-tdep.c: Revert.
1298         * alpha-bsd-nat.c: Revert.
1299         * aix-thread.c: Revert.
1300         * agent.c: Revert.
1301         * addrmap.c: Revert.
1302         * ada-varobj.c: Revert.
1303         * ada-valprint.c: Revert.
1304         * ada-typeprint.c: Revert.
1305         * ada-tasks.c: Revert.
1306         * ada-lang.c: Revert.
1307         * aarch64-tdep.c: Revert.
1308         * aarch64-ravenscar-thread.c: Revert.
1309         * aarch64-newlib-tdep.c: Revert.
1310         * aarch64-linux-tdep.c: Revert.
1311         * aarch64-linux-nat.c: Revert.
1312         * aarch64-fbsd-tdep.c: Revert.
1313         * aarch64-fbsd-nat.c: Revert.
1314         * aarch32-linux-nat.c: Revert.
1315
1316 2019-04-05  Tom Tromey  <tom@tromey.com>
1317
1318         * ft32-tdep.c: Sort headers.
1319         * frv-tdep.c: Sort headers.
1320         * frv-linux-tdep.c: Sort headers.
1321         * frame.c: Sort headers.
1322         * frame-unwind.c: Sort headers.
1323         * frame-base.c: Sort headers.
1324         * fork-child.c: Sort headers.
1325         * findvar.c: Sort headers.
1326         * findcmd.c: Sort headers.
1327         * filesystem.c: Sort headers.
1328         * filename-seen-cache.h: Sort headers.
1329         * filename-seen-cache.c: Sort headers.
1330         * fbsd-tdep.c: Sort headers.
1331         * fbsd-nat.h: Sort headers.
1332         * fbsd-nat.c: Sort headers.
1333         * f-valprint.c: Sort headers.
1334         * f-typeprint.c: Sort headers.
1335         * f-lang.c: Sort headers.
1336         * extension.h: Sort headers.
1337         * extension.c: Sort headers.
1338         * extension-priv.h: Sort headers.
1339         * expprint.c: Sort headers.
1340         * exec.h: Sort headers.
1341         * exec.c: Sort headers.
1342         * exceptions.c: Sort headers.
1343         * event-top.c: Sort headers.
1344         * event-loop.c: Sort headers.
1345         * eval.c: Sort headers.
1346         * elfread.c: Sort headers.
1347         * dwarf2read.h: Sort headers.
1348         * dwarf2read.c: Sort headers.
1349         * dwarf2loc.c: Sort headers.
1350         * dwarf2expr.h: Sort headers.
1351         * dwarf2expr.c: Sort headers.
1352         * dwarf2-frame.c: Sort headers.
1353         * dwarf2-frame-tailcall.c: Sort headers.
1354         * dwarf-index-write.h: Sort headers.
1355         * dwarf-index-write.c: Sort headers.
1356         * dwarf-index-common.c: Sort headers.
1357         * dwarf-index-cache.h: Sort headers.
1358         * dwarf-index-cache.c: Sort headers.
1359         * dummy-frame.c: Sort headers.
1360         * dtrace-probe.c: Sort headers.
1361         * disasm.h: Sort headers.
1362         * disasm.c: Sort headers.
1363         * disasm-selftests.c: Sort headers.
1364         * dictionary.c: Sort headers.
1365         * dicos-tdep.c: Sort headers.
1366         * demangle.c: Sort headers.
1367         * dcache.h: Sort headers.
1368         * dcache.c: Sort headers.
1369         * darwin-nat.h: Sort headers.
1370         * darwin-nat.c: Sort headers.
1371         * darwin-nat-info.c: Sort headers.
1372         * d-valprint.c: Sort headers.
1373         * d-namespace.c: Sort headers.
1374         * d-lang.c: Sort headers.
1375         * ctf.c: Sort headers.
1376         * csky-tdep.c: Sort headers.
1377         * csky-linux-tdep.c: Sort headers.
1378         * cris-tdep.c: Sort headers.
1379         * cris-linux-tdep.c: Sort headers.
1380         * cp-valprint.c: Sort headers.
1381         * cp-support.c: Sort headers.
1382         * cp-namespace.c: Sort headers.
1383         * cp-abi.c: Sort headers.
1384         * corelow.c: Sort headers.
1385         * corefile.c: Sort headers.
1386         * continuations.c: Sort headers.
1387         * completer.h: Sort headers.
1388         * completer.c: Sort headers.
1389         * complaints.c: Sort headers.
1390         * coffread.c: Sort headers.
1391         * coff-pe-read.c: Sort headers.
1392         * cli-out.h: Sort headers.
1393         * cli-out.c: Sort headers.
1394         * charset.c: Sort headers.
1395         * c-varobj.c: Sort headers.
1396         * c-valprint.c: Sort headers.
1397         * c-typeprint.c: Sort headers.
1398         * c-lang.c: Sort headers.
1399         * buildsym.c: Sort headers.
1400         * buildsym-legacy.c: Sort headers.
1401         * build-id.h: Sort headers.
1402         * build-id.c: Sort headers.
1403         * btrace.c: Sort headers.
1404         * bsd-uthread.c: Sort headers.
1405         * breakpoint.h: Sort headers.
1406         * breakpoint.c: Sort headers.
1407         * break-catch-throw.c: Sort headers.
1408         * break-catch-syscall.c: Sort headers.
1409         * break-catch-sig.c: Sort headers.
1410         * blockframe.c: Sort headers.
1411         * block.c: Sort headers.
1412         * bfin-tdep.c: Sort headers.
1413         * bfin-linux-tdep.c: Sort headers.
1414         * bfd-target.c: Sort headers.
1415         * bcache.c: Sort headers.
1416         * ax-general.c: Sort headers.
1417         * ax-gdb.h: Sort headers.
1418         * ax-gdb.c: Sort headers.
1419         * avr-tdep.c: Sort headers.
1420         * auxv.c: Sort headers.
1421         * auto-load.c: Sort headers.
1422         * arm-wince-tdep.c: Sort headers.
1423         * arm-tdep.c: Sort headers.
1424         * arm-symbian-tdep.c: Sort headers.
1425         * arm-pikeos-tdep.c: Sort headers.
1426         * arm-obsd-tdep.c: Sort headers.
1427         * arm-nbsd-tdep.c: Sort headers.
1428         * arm-nbsd-nat.c: Sort headers.
1429         * arm-linux-tdep.c: Sort headers.
1430         * arm-linux-nat.c: Sort headers.
1431         * arm-fbsd-tdep.c: Sort headers.
1432         * arm-fbsd-nat.c: Sort headers.
1433         * arm-bsd-tdep.c: Sort headers.
1434         * arch-utils.c: Sort headers.
1435         * arc-tdep.c: Sort headers.
1436         * arc-newlib-tdep.c: Sort headers.
1437         * annotate.h: Sort headers.
1438         * annotate.c: Sort headers.
1439         * amd64-windows-tdep.c: Sort headers.
1440         * amd64-windows-nat.c: Sort headers.
1441         * amd64-tdep.c: Sort headers.
1442         * amd64-sol2-tdep.c: Sort headers.
1443         * amd64-obsd-tdep.c: Sort headers.
1444         * amd64-obsd-nat.c: Sort headers.
1445         * amd64-nbsd-tdep.c: Sort headers.
1446         * amd64-nbsd-nat.c: Sort headers.
1447         * amd64-nat.c: Sort headers.
1448         * amd64-linux-tdep.c: Sort headers.
1449         * amd64-linux-nat.c: Sort headers.
1450         * amd64-fbsd-tdep.c: Sort headers.
1451         * amd64-fbsd-nat.c: Sort headers.
1452         * amd64-dicos-tdep.c: Sort headers.
1453         * amd64-darwin-tdep.c: Sort headers.
1454         * amd64-bsd-nat.c: Sort headers.
1455         * alpha-tdep.c: Sort headers.
1456         * alpha-obsd-tdep.c: Sort headers.
1457         * alpha-nbsd-tdep.c: Sort headers.
1458         * alpha-mdebug-tdep.c: Sort headers.
1459         * alpha-linux-tdep.c: Sort headers.
1460         * alpha-linux-nat.c: Sort headers.
1461         * alpha-bsd-tdep.c: Sort headers.
1462         * alpha-bsd-nat.c: Sort headers.
1463         * aix-thread.c: Sort headers.
1464         * agent.c: Sort headers.
1465         * addrmap.c: Sort headers.
1466         * ada-varobj.c: Sort headers.
1467         * ada-valprint.c: Sort headers.
1468         * ada-typeprint.c: Sort headers.
1469         * ada-tasks.c: Sort headers.
1470         * ada-lang.c: Sort headers.
1471         * aarch64-tdep.c: Sort headers.
1472         * aarch64-ravenscar-thread.c: Sort headers.
1473         * aarch64-newlib-tdep.c: Sort headers.
1474         * aarch64-linux-tdep.c: Sort headers.
1475         * aarch64-linux-nat.c: Sort headers.
1476         * aarch64-fbsd-tdep.c: Sort headers.
1477         * aarch64-fbsd-nat.c: Sort headers.
1478         * aarch32-linux-nat.c: Sort headers.
1479
1480 2019-04-04  Tom Tromey  <tom@tromey.com>
1481
1482         * varobj.c (varobj_create): Update.
1483         * rust-exp.y (struct rust_parser) <update_innermost_block,
1484         lookup_symbol>: New methods.
1485         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1486         Rename.
1487         (rust_parser::rust_lookup_type)
1488         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1489         * printcmd.c (display_command, do_one_display): Update.
1490         * parser-defs.h (struct parser_state) <parser_state>: Add
1491         "tracker" parameter.
1492         (block_tracker): New member.
1493         (class innermost_block_tracker) <innermost_block_tracker>: Add
1494         "types" parameter.
1495         <reset>: Remove method.
1496         (innermost_block): Don't declare.
1497         (null_post_parser): Update.
1498         * parse.c (innermost_block): Remove global.
1499         (write_dollar_variable): Update.
1500         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1501         Remove "tracker_types" parameter.
1502         (parse_expression): Add "tracker" parameter.
1503         (parse_expression_for_completion): Update.
1504         (null_post_parser): Add "tracker" parameter.
1505         * p-exp.y: Update rules.
1506         * m2-exp.y: Update rules.
1507         * language.h (struct language_defn) <la_post_parser>: Add
1508         "tracker" parameter.
1509         * go-exp.y: Update rules.
1510         * f-exp.y: Update rules.
1511         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1512         parameter.
1513         * d-exp.y: Update rules.
1514         * c-exp.y: Update rules.
1515         * breakpoint.c (set_breakpoint_condition): Create an
1516         innermost_block_tracker.
1517         (watch_command_1): Likewise.
1518         * ada-lang.c (resolve): Add "tracker" parameter.
1519         (resolve_subexp): Likewise.
1520         * ada-exp.y (write_var_from_sym): Update.
1521
1522 2019-04-04  Tom Tromey  <tom@tromey.com>
1523
1524         * type-stack.h: New file.
1525         * type-stack.c: New file.
1526         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1527         type-stack.h.
1528         (insert_into_type_stack, insert_type, push_type, push_type_int)
1529         (insert_type_address_space, pop_type, pop_type_int)
1530         (pop_typelist, pop_type_stack, append_type_stack)
1531         (push_type_stack, get_type_stack, push_typelist)
1532         (follow_type_instance_flags, follow_types): Don't declare.
1533         * parse.c (type_stack): Remove global.
1534         (parse_exp_in_context): Update.
1535         (insert_into_type_stack, insert_type, push_type, push_type_int)
1536         (insert_type_address_space, pop_type, pop_type_int)
1537         (pop_typelist, pop_type_stack, append_type_stack)
1538         (push_type_stack, get_type_stack, push_typelist)
1539         (follow_type_instance_flags, follow_types): Remove (moved to
1540         type-stack.c).
1541         * f-exp.y (type_stack): New global.
1542         Update rules.
1543         (push_kind_type, f_parse): Update.
1544         * d-exp.y (type_stack): New global.
1545         Update rules.
1546         (d_parse): Update.
1547         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1548         Update rules.
1549         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1550         (HFILES_NO_SRCDIR): Add type-stack.h.
1551
1552 2019-04-04  Tom Tromey  <tom@tromey.com>
1553
1554         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1555         (rust_parser::convert_ast_to_expression, rust_parse)
1556         (rust_lex_test_completion, rust_lex_tests): Update.
1557         * parser-defs.h (struct expr_completion_state): New.
1558         (struct parser_state) <parser_state>: Add completion parameter.
1559         <mark_struct_expression, mark_completion_tag>: New methods.
1560         <parse_completion, m_completion_state>: New members.
1561         (prefixify_expression, null_post_parser): Update.
1562         (mark_struct_expression, mark_completion_tag): Don't declare.
1563         * parse.c (parse_completion, expout_last_struct)
1564         (expout_tag_completion_type, expout_completion_name): Remove
1565         globals.
1566         (parser_state::mark_struct_expression)
1567         (parser_state::mark_completion_tag): Now methods.
1568         (prefixify_expression): Add last_struct parameter.
1569         (prefixify_subexp): Likewise.
1570         (parse_exp_1): Update.
1571         (parse_exp_in_context): Add cstate parameter.  Update.
1572         (parse_expression_for_completion): Create an
1573         expr_completion_state.
1574         (null_post_parser): Add "completion" parameter.
1575         * p-exp.y: Update rules.
1576         (yylex): Update.
1577         * language.h (struct language_defn) <la_post_parser>: Add
1578         "completing" parameter.
1579         * go-exp.y: Update rules.
1580         (lex_one_token): Update.
1581         * expression.h (parse_completion): Don't declare.
1582         * d-exp.y: Update rules.
1583         (lex_one_token): Update rules.
1584         * c-exp.y: Update rules.
1585         (lex_one_token): Update.
1586         * ada-lang.c (resolve): Add "parse_completion" parameter.
1587         (resolve_subexp): Likewise.
1588         (ada_resolve_function): Likewise.
1589
1590 2019-04-04  Tom Tromey  <tom@tromey.com>
1591
1592         * parser-defs.h (struct parser_state) <start_arglist,
1593         end_arglist>: New methods.
1594         <arglist_len, m_funcall_chain>: New members.
1595         (arglist_len, start_arglist, end_arglist): Don't declare.
1596         * parse.c (arglist_len, funcall_chain): Remove global.
1597         (start_arglist, end_arglist): Remove functions.
1598         (parse_exp_in_context): Update.
1599         * p-exp.y: Update rules.
1600         * m2-exp.y: Update rules.
1601         * go-exp.y: Update rules.
1602         * f-exp.y: Update rules.
1603         * d-exp.y: Update rules.
1604         * c-exp.y: Update rules.
1605
1606 2019-04-04  Tom Tromey  <tom@tromey.com>
1607
1608         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1609         lex_operator, push_back>: New methods.
1610         Update all rules.
1611         (rust_parser::lex_hex, lex_escape): Rename and update.
1612         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1613         (rust_parser::lex_operator): Rename and update.
1614         (rust_parser::lex_number, rustyylex, rustyyerror)
1615         (rust_lex_test_init, rust_lex_test_sequence)
1616         (rust_lex_test_push_back, rust_lex_tests): Update.
1617         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1618         parameter.
1619         <lexptr, prev_lexptr>: New members.
1620         (lexptr, prev_lexptr): Don't declare.
1621         * parse.c (lexptr, prev_lexptr): Remove globals.
1622         (parse_exp_in_context): Update.
1623         * p-exp.y (yylex, yyerror): Update.
1624         * m2-exp.y (parse_number, yylex, yyerror): Update.
1625         * go-exp.y (lex_one_token, yyerror): Update.
1626         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1627         * d-exp.y (lex_one_token, yyerror): Update.
1628         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1629         (lex_one_token, yyerror): Update.
1630         * ada-lex.l (YY_INPUT): Update.
1631         (rewind_to_char): Update.
1632         * ada-exp.y (yyerror): Update.
1633
1634 2019-04-04  Tom Tromey  <tom@tromey.com>
1635
1636         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1637         * parser-defs.h (struct parser_state) <parser_state>: Add new
1638         parameter.
1639         <comma_terminates>: New member.
1640         (comma_terminates): Don't declare global.
1641         * parse.c (comma_terminates): Remove global.
1642         (parse_exp_in_context): Update.
1643         * p-exp.y (yylex): Update.
1644         * m2-exp.y (yylex): Update.
1645         * go-exp.y (lex_one_token): Update.
1646         * f-exp.y (yylex): Update.
1647         * d-exp.y (lex_one_token): Update.
1648         * c-exp.y (lex_one_token): Update.
1649         * ada-lex.l: Update.
1650
1651 2019-04-04  Tom Tromey  <tom@tromey.com>
1652
1653         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1654         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1655         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1656         * parser-defs.h (paren_depth): Don't declare.
1657         * parse.c (paren_depth): Remove global.
1658         (parse_exp_in_context): Update.
1659         * p-exp.y (paren_depth): New global.
1660         (pascal_parse): Initialize it.
1661         * m2-exp.y (paren_depth): New global.
1662         (m2_parse): Initialize it.
1663         * go-exp.y (paren_depth): New global.
1664         (go_parse): Initialize it.
1665         * f-exp.y (paren_depth): New global.
1666         (f_parse): Initialize it.
1667         * d-exp.y (paren_depth): New global.
1668         (d_parse): Initialize it.
1669         * c-exp.y (paren_depth): New global.
1670         (c_parse): Initialize it.
1671         * ada-lex.l (paren_depth): New global.
1672         (lexer_init): Initialize it.
1673
1674 2019-04-04  Tom Tromey  <tom@tromey.com>
1675
1676         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1677         (rust_parser::convert_ast_to_type)
1678         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1679         * parser-defs.h (struct parser_state) <parser_state>: Add
1680         parameters.  Initialize new members.
1681         <expression_context_block, expression_context_pc>: New members.
1682         * parse.c (expression_context_block, expression_context_pc):
1683         Remove globals.
1684         (parse_exp_in_context): Update.
1685         * p-exp.y: Update all rules.
1686         (yylex): Update.
1687         * m2-exp.y: Update all rules.
1688         (yylex): Update.
1689         * go-exp.y (yylex): Update.
1690         * f-exp.y (yylex): Update.
1691         * d-exp.y: Update all rules.
1692         (yylex): Update.
1693         * c-exp.y: Update all rules.
1694         (lex_one_token, classify_name, yylex, c_parse): Update.
1695         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1696
1697 2019-04-04  Tom Tromey  <tom@tromey.com>
1698
1699         * gdbarch.h, gdbarch.c: Rebuild.
1700         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1701         * stap-probe.h: 
1702         (struct stap_parse_info): Replace "parser_state" with
1703         "expr_builder".
1704         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1705         (parser_state): New class.
1706         * parse.c (expr_builder): Rename.
1707         (expr_builder::release): Rename.
1708         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1709         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1710         (write_exp_elt_longcst, write_exp_elt_floatcst)
1711         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1712         (write_exp_string_vector, write_exp_bitstring)
1713         (write_exp_msymbol, mark_struct_expression)
1714         (write_dollar_variable)
1715         (insert_type_address_space, increase_expout_size): Replace
1716         "parser_state" with "expr_builder".
1717         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1718         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1719         "parser_state" with "expr_builder".
1720
1721 2019-04-04  Tom Tromey  <tom@tromey.com>
1722
1723         * rust-exp.y: Replace "parse_language" with method call.
1724         * p-exp.y: 
1725         (yylex): Replace "parse_language" with method call.
1726         * m2-exp.y: 
1727         (yylex): Replace "parse_language" with method call.
1728         * go-exp.y (classify_name): Replace "parse_language" with method
1729         call.
1730         * f-exp.y (yylex): Replace "parse_language" with method call.
1731         * d-exp.y (lex_one_token): Replace "parse_language" with method
1732         call.
1733         * c-exp.y: 
1734         (lex_one_token, classify_name, yylex): Replace "parse_language"
1735         with method call.
1736         * ada-exp.y (find_primitive_type, type_char)
1737         (type_system_address): Replace "parse_language" with method call.
1738
1739 2019-04-04  Tom Tromey  <tom@tromey.com>
1740
1741         * rust-exp.y: Replace "parse_gdbarch" with method call.
1742         * parse.c (write_dollar_variable, insert_type_address_space):
1743         Replace "parse_gdbarch" with method call.
1744         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1745         call.
1746         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1747         call.
1748         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1749         "parse_gdbarch" with method call.
1750         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1751         with method call.
1752         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1753         "parse_gdbarch" with method call.
1754         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1755         "parse_gdbarch" with method call.
1756         * c-exp.y (parse_type, parse_number, classify_name): Replace
1757         "parse_gdbarch" with method call.
1758         * ada-lex.l: Replace "parse_gdbarch" with method call.
1759         * ada-exp.y (parse_type, find_primitive_type, type_char)
1760         (type_system_address): Replace "parse_gdbarch" with method call.
1761
1762 2019-04-04  Tom Tromey  <tom@tromey.com>
1763
1764         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1765         * stap-probe.c (stap_parse_argument): Update.
1766         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1767         initial_size parameter.
1768         * rust-exp.y (rust_lex_tests): Update.
1769         * parse.c (parser_state): Update.
1770         (parse_exp_in_context): Update.
1771         * parser-defs.h (struct parser_state) <parser_state>: Remove
1772         "initial_size" parameter.
1773
1774 2019-04-04  Tom Tromey  <tom@tromey.com>
1775
1776         * parser-defs.h (increase_expout_size): Don't declare.
1777         * parse.c (increase_expout_size): Now static.
1778
1779 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1780
1781         * gnu-nat.c (gnu_nat_target::wait): Fix
1782         target_waitstatus_to_string call.
1783
1784 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1785
1786         * eval.c (evaluate_subexp_standard): Handle internal functions
1787         during Fortran function call handling.
1788
1789 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1790
1791         * NEWS: Mention new internal functions.
1792         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1793         (read_base_type): Use dwarf2_init_complex_target_type.
1794         * value.c (creal_internal_fn): New function.
1795         (cimag_internal_fn): New function.
1796         (_initialize_values): Register new internal functions.
1797
1798 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1799
1800         * infrun.c (stop_all_threads): If debug_infrun, always
1801         trace the wait status after wait_one, using
1802         target_waitstatus_to_string and target_pid_to_str.
1803         (handle_inferior_event): Replace various trace of
1804         wait status kind by a single trace.
1805         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1806         wait status kind image by target_waitstatus_to_string.
1807         * target/waitstatus.c (target_waitstatus_to_string): Fix
1808         obsolete comment.
1809
1810 2019-04-01  Tom Tromey  <tromey@adacore.com>
1811
1812         PR symtab/23331:
1813         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1814
1815 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1816             Pedro Alves  <palves@redhat.com>
1817
1818         * top.c (quit_force): Call 'finalize_values'.
1819         * value.c (finalize_values): New function.
1820         * value.h (finalize_values): Declare.
1821
1822 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1823
1824         * NEWS: Announce $_gdb_major and $_gdb_minor.
1825
1826         * top.c (init_gdb_version_vars): New function.
1827         (gdb_init): Call init_gdb_version_vars.
1828
1829 2019-03-29  Tom Tromey  <tromey@adacore.com>
1830
1831         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1832         help text.  Remove dead code.
1833
1834 2019-03-29  Keith Seitz  <keiths@redhat.com>
1835
1836         From Siddhesh Poyarekar:
1837         * f-lang.h (f77_get_upperbound): Return LONGEST.
1838         (f77_get_lowerbound): Likewise.
1839         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1840         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1841         print them.
1842         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1843         plongest to format print it.
1844         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1845         (f77_get_upperbound): Likewise.
1846         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1847         LOWER_BOUND to LONGEST.
1848         (f77_create_arrayprint_offset_tbl): Likewise.
1849
1850 2019-03-29  Keith Seitz  <keiths@redhat.com>
1851
1852         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1853         %s/pulongest for TYPE_LENGTH instead of %d in format
1854         strings.
1855         * ada-typerint.c (ada_print_type): Likewise.
1856         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1857         * compile/compile-c-support.c (generate_register_struct): Likewise.
1858         * gdbtypes.c (recursive_dump_type): Likewise.
1859         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1860         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1861         instead of %d in format strings.
1862         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1863         to std::min to ULONGEST.
1864         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1865         instead of %d in format strings.
1866         * tracepoint.c (info_scope_command): Likewise.
1867         * typeprint.c (print_offset_data::update)
1868         (print_offset_data::finish): Likewise.
1869         * xtensa-tdep.c (xtensa_store_return_value)
1870         (xtensa_push_dummy_call): Likewise.
1871
1872 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1873
1874         * windows-nat.c (display_selector): Fixed format specifications
1875         for 64-bit Cygwin.
1876
1877 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1878
1879         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1880
1881 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1882
1883         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1884         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1885         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1886         (nios2_linux_init_abi): Install it.
1887
1888 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1889
1890         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1891
1892 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1893
1894         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1895
1896 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1897             Tom Tromey  <tromey@adacore.com>
1898
1899         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1900
1901 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1902
1903         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1904         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1905         method to compute the bounds of range types. Also print "[evaluated]"
1906         if the bounds' values come from a dynamic evaluation.
1907
1908 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1909
1910         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1911         whitespace when pretty printing is on.
1912
1913 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1914
1915         * ppc-linux-nat.c: Add include.
1916
1917 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1918
1919         * NEWS: Mention AArch64 Pointer Authentication.
1920
1921 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1922
1923         * arm-linux-nat.c: Add include.
1924
1925 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1926
1927         * source-cache.c (source_cache::get_source_lines): Re-read
1928         fullname after calling open_source_file.
1929
1930 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1931
1932         * NEWS: Mention TLS support for FreeBSD.
1933
1934 2019-03-25  Tom Tromey  <tromey@adacore.com>
1935
1936         * minsyms.c (BUNCH_SIZE): Update comment.
1937         (~minimal_symbol_reader): Remove old comment.
1938         (compact_minimal_symbols): Update comment.
1939         (minimal_symbol_reader::install): Remove old comment.  Update
1940         other comments.
1941
1942 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1943
1944         * s390-linux-nat.c: Add include.
1945
1946 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1947
1948         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1949         Call linux_get_hwcap.
1950         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1951         Likewise.
1952         (aarch64_linux_get_hwcap): Remove function.
1953         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1954         declaration.
1955         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1956         linux_get_hwcap.
1957         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1958         * linux-tdep.c (linux_get_hwcap): Add function.
1959         (linux_get_hwcap2): Likewise.
1960         * linux-tdep.h (linux_get_hwcap): Add declaration.
1961         (linux_get_hwcap2): Likewise.
1962         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1963         (ppc_linux_get_hwcap2): Likewise.
1964         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1965         linux_get_hwcap.
1966         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1967         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1968         (ppc_linux_nat_target::read_description): Likewise.
1969         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1970         * s390-linux-nat.c: Likewise.
1971         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1972
1973 2019-03-24  Tom Tromey  <tom@tromey.com>
1974
1975         * ada-lang.c (standard_lookup): Simplify initialization.
1976         (ada_lookup_symbol_nonlocal): Simplify return.
1977         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1978         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1979         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1980         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1981         initialization.
1982         * solib.c (solib_global_lookup): Simplify.
1983         * symtab.c (null_block_symbol): Remove.
1984         (symbol_cache_lookup): Simplify returns.
1985         (lookup_language_this): Simplify returns.
1986         (lookup_symbol_aux): Simplify return.
1987         (lookup_local_symbol): Simplify returns.
1988         (lookup_global_symbol_from_objfile): Simplify return.
1989         (lookup_symbol_in_objfile_symtabs)
1990         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1991         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1992         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1993         * cp-namespace.c (cp_lookup_bare_symbol)
1994         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1995         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1996         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1997         (cp_lookup_symbol_via_imports): Simplify initialization.
1998         (find_symbol_in_baseclass): Likewise.
1999         * symtab.h (null_block_symbol): Remove.
2000         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2001         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2002         (d_lookup_symbol_module): Likewise.
2003         (find_symbol_in_baseclass): Simplify initialization.
2004
2005 2019-03-24  Tom Tromey  <tom@tromey.com>
2006
2007         * expression.h: Don't include symtab.h.
2008         (struct block): Forward declare.
2009
2010 2019-03-24  Tom Tromey  <tom@tromey.com>
2011
2012         * c-exp.y (typebase): Remove casts.
2013         * gdbtypes.c (lookup_unsigned_typename, )
2014         (lookup_signed_typename): Remove cast.
2015         * eval.c (parse_to_comma_and_eval): Remove cast.
2016         * parse.c (write_dollar_variable): Remove cast.
2017         * block.h (struct block) <superblock>: Now const.
2018         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2019         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2020         (map_block): Make "block" const.
2021         * symfile.h (struct quick_symbol_functions)
2022         <map_matching_symbols>: Constify block argument to "callback".
2023         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2024         const.
2025         (find_pc_sect_compunit_symtab): Make "b" const.
2026         (find_symbol_at_address): Likewise.
2027         (search_symbols): Likewise.
2028         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2029         (dw2_debug_names_lookup_symbol): Likewise.
2030         (dw2_map_matching_symbols): Update.
2031         * p-valprint.c (pascal_val_print): Remove "block".
2032         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2033         (aux_add_nonlocal_symbols): Make "block" const.
2034         (resolve_subexp): Remove cast.
2035         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2036         const.
2037         (iterate_over_file_blocks): Likewise.
2038         * f-exp.y (%union) <bval>: Remove.
2039         * coffread.c (patch_opaque_types): Make "b" const.
2040         * spu-tdep.c (spu_catch_start): Make "block" const.
2041         * c-valprint.c (print_unpacked_pointer): Remove "block".
2042         * symmisc.c (dump_symtab_1): Make "b" const.
2043         (block_depth): Make "block" const.
2044         * d-exp.y (%union) <bval>: Remove.
2045         * cp-support.h (cp_lookup_rtti_type): Update.
2046         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2047         * psymtab.c (psym_lookup_symbol): Make "block" const.
2048         (maintenance_check_psymtabs): Make "b" const.
2049         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2050         (enumerate_locals, enumerate_args): Update.
2051         * python/py-symtab.c (stpy_global_block): Make "block" const.
2052         (stpy_static_block): Likewise.
2053         * inline-frame.c (block_starting_point_at): Make "new_block"
2054         const.
2055         * block.c (find_block_in_blockvector): Make return type const.
2056         (blockvector_for_pc_sect): Make "b" const.
2057         (find_block_in_blockvector): Make "b" const.
2058
2059 2019-03-23  Tom Tromey  <tom@tromey.com>
2060
2061         * varobj.c (varobj_create): Update.
2062         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2063         * printcmd.c (display_command, do_one_display): Don't reset
2064         innermost_block.
2065         * parser-defs.h (enum innermost_block_tracker_type): Move to
2066         expression.h.
2067         (innermost_block): Update comment.
2068         * parse.c (parse_exp_1): Add tracker_types parameter.
2069         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2070         tracker_types parameter.  Reset innermost_block.
2071         (parse_exp_in_context): Remove.
2072         (parse_expression_for_completion): Update.
2073         * objfiles.c (~objfile): Don't reset expression_context_block or
2074         innermost_block.
2075         * expression.h (enum innermost_block_tracker_type): Move from
2076         parser-defs.h.
2077         (parse_exp_1): Add tracker_types parameter.
2078         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2079         reset innermost_block.
2080
2081 2019-03-23  Tom Tromey  <tom@tromey.com>
2082
2083         * objfiles.h: Include bcache.h.
2084
2085 2019-03-23  Tom Tromey  <tom@tromey.com>
2086
2087         * linespec.c (get_current_search_block): Use
2088         scoped_restore_current_language.
2089         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2090
2091 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2092             Jiong Wang  <jiong.wang@arm.com>
2093
2094         * aarch64-linux-tdep.c
2095         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2096         section.
2097         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2098
2099 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2100             Jiong Wang  <jiong.wang@arm.com>
2101
2102         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2103         instructions.
2104         (aarch64_analyze_prologue_test): Add PACIASP test.
2105         (aarch64_prologue_prev_register): Unmask PC value.
2106
2107 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2108             Jiong Wang  <jiong.wang@arm.com>
2109
2110         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2111         (aarch64_dwarf2_prev_register): Unmask PC value.
2112         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2113         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2114         DW_CFA_AARCH64_negate_ra_state.
2115         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2116
2117 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2118             Jiong Wang  <jiong.wang@arm.com>
2119
2120         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2121         registers.
2122         (aarch64_pseudo_register_name): Likewise.
2123         (aarch64_pseudo_register_type): Likewise.
2124         (aarch64_pseudo_register_reggroup_p): Likewise.
2125         (aarch64_gdbarch_init): Add pauth registers.
2126         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2127         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2128         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2129         (struct gdbarch_tdep): Add regnum for ra_state.
2130
2131 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2132             Jiong Wang  <jiong.wang@arm.com>
2133
2134         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2135
2136 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2137             Jiong Wang  <jiong.wang@arm.com>
2138
2139         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2140         function.
2141         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2142         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2143         (aarch64_gdbarch_init): Add puth registers.
2144         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2145         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2146         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2147
2148 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2149             Jiong Wang  <jiong.wang@arm.com>
2150
2151         * aarch64-linux-nat.c
2152         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2153         * aarch64-linux-tdep.c
2154         (aarch64_linux_core_read_description): Likewise.
2155         (aarch64_linux_get_hwcap): New function.
2156         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2157         (aarch64_linux_get_hwcap): New declaration.
2158
2159 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2160             Jiong Wang  <jiong.wang@arm.com>
2161
2162         * aarch64-linux-nat.c
2163         (aarch64_linux_nat_target::read_description): Add pauth param.
2164         * aarch64-linux-tdep.c
2165         (aarch64_linux_core_read_description): Likewise.
2166         * aarch64-tdep.c (struct target_desc): Add in pauth.
2167         (aarch64_read_description): Add pauth param.
2168         (aarch64_gdbarch_init): Likewise.
2169         * aarch64-tdep.h (aarch64_read_description): Likewise.
2170         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2171         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2172         * features/Makefile: Add new files.
2173         * features/aarch64-pauth.c: New file.
2174         * features/aarch64-pauth.xml: New file.
2175
2176 2019-03-20  Tom Tromey  <tromey@adacore.com>
2177
2178         * infrun.c (handle_inferior_event): Rename from
2179         handle_inferior_event_1.  Create a scoped_value_mark.
2180         (handle_inferior_event): Remove.
2181
2182 2019-03-19  Tom Tromey  <tromey@adacore.com>
2183
2184         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2185         * infrun.h (print_stop_event): Add "displays" parameter.
2186         * infrun.c (print_stop_event): Add "displays" parameter.
2187
2188 2019-03-19  Pedro Alves  <palves@redhat.com>
2189
2190         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2191         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2192         to -1.  Fix TABs vs spaces.
2193         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2194         * tui/tui-out.h (tui_ui_out) Add intro comments.
2195         <m_line, m_start_of_line>: In-class initialize, and add describing
2196         comment.
2197
2198 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2199
2200         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2201         variable names.
2202         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2203
2204 2019-03-18  Pedro Alves  <palves@redhat.com>
2205             Eli Zaretskii <eliz@gnu.org>
2206
2207         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2208         m_line and m_start_of_line.
2209
2210 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2211
2212         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2213         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2214         it returns a newline.  This fixes a regression in TU mode, whereby
2215         the next line is output on the same screen line as the user input.
2216
2217 2019-03-18  Tom Tromey  <tromey@adacore.com>
2218
2219         * minsyms.c (minimal_symbol_reader::install): Remove call to
2220         obstack_blank.
2221
2222 2019-03-18  Pedro Alves  <palves@redhat.com>
2223
2224         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2225         New globals.
2226         (apply_style): New, factored out from ...
2227         (apply_ansi_escape): ... this.  Handle reverse video mode.
2228         (tui_set_reverse_mode): New function.
2229         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2230         * tui/tui-winsource.c (tui_show_source_line): Use
2231         tui_set_reverse_mode instead of setting A_STANDOUT.
2232         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2233         New setter methods.
2234
2235 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2236
2237         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2238         Handle tabs.
2239
2240 2019-03-18  Tom Tromey  <tromey@adacore.com>
2241
2242         * ada-lang.c (empty_array): Add "high" parameter.
2243         (ada_evaluate_subexp): Update.
2244
2245 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2246
2247         * unittests/string_view-selftests.c: Define
2248         _initialize_string_view_selftests unconditionally.
2249
2250 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2251
2252         PR gdb/24350
2253         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2254
2255 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2256
2257         PR gdb/24351
2258         * windows-nat.c (display_selector): Fix format specifiers.
2259
2260 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2261
2262         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2263         tui_refill_source_window instead of tui_refresh_win, to update the
2264         current execution line.  This fixes redisplay of the current line
2265         when stepping through the code with "next" or "step".
2266
2267 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2268
2269         * source-cache.c (source_cache::get_source_lines): Call
2270         find_source_lines to initialize s->nlines.  This fixes vertical
2271         scrolling of TUI source window when the DOWN arrow is pressed.
2272
2273 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2274
2275         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2276         linux-thread-db.c (_initialize_thread_db): Likewise.
2277
2278 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2279
2280         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2281         wclrtoeol in tui_show_source_line".  This reverts changes made in
2282         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2283
2284 2019-03-15  Tom Tromey  <tom@tromey.com>
2285
2286         * symtab.h (struct minimal_symbol): Derive from
2287         general_symbol_info.
2288         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2289         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2290         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2291         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2292         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2293         (MSYMBOL_SEARCH_NAME): Update.
2294         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2295         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2296         * minsyms.c (minimal_symbol_reader::record_full): Update.
2297
2298 2019-03-15  Tom Tromey  <tom@tromey.com>
2299
2300         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2301
2302 2019-03-15  Tom Tromey  <tom@tromey.com>
2303
2304         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2305         unique_xmalloc_ptr.
2306         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2307         Update.
2308         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2309         (build_minimal_symbol_hash_tables)
2310         (minimal_symbol_reader::install): Update.
2311
2312 2019-03-15  Tom Tromey  <tom@tromey.com>
2313
2314         * symtab.c (create_demangled_names_hash): Update.
2315         (symbol_set_names): Update.
2316         * objfiles.h (struct objfile_per_bfd_storage)
2317         <demangled_names_hash>: Now an htab_up.
2318         * objfiles.c (objfile_per_bfd_storage): Simplify.
2319
2320 2019-03-15  Tom Tromey  <tom@tromey.com>
2321
2322         * objfiles.h (struct objfile_per_bfd_storage): Declare
2323         destructor.
2324         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2325         New.
2326         (get_objfile_bfd_data): Use new.  Don't initialize
2327         language_of_main.
2328         (free_objfile_per_bfd_storage): Remove.
2329         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2330
2331 2019-03-15  Tom Tromey  <tom@tromey.com>
2332
2333         * symfile.c (reread_symbols): Update.
2334         * objfiles.c (objfile::objfile): Update.
2335         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2336         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2337         comment.
2338         (minimal_symbol_reader::install): Update.
2339         (terminate_minimal_symbol_table): Remove.
2340         * jit.c (jit_object_close_impl): Update.
2341
2342 2019-03-15  Tom Tromey  <tom@tromey.com>
2343
2344         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2345         initializations.
2346
2347 2019-03-15  Tom Tromey  <tom@tromey.com>
2348
2349         * objfiles.h (struct objfile_per_bfd_storage)
2350         <demangled_hash_languages>: Now a bitset.
2351         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2352         (lookup_minimal_symbol): Update.
2353
2354 2019-03-15  Tom Tromey  <tom@tromey.com>
2355
2356         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2357         Don't return the symbol.
2358         * coffread.c (record_minimal_symbol): Use record_full.
2359
2360 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2361
2362         The MS-Windows port of ncurses fails to switch to a color pair if
2363         one or both of the colors are the implicit default colors.  This
2364         change records the default colors when TUI is initialized, and
2365         then specifies them explicitly when a color pair uses the default
2366         colors.  This allows color styling in TUI mode on MS-Windows.
2367
2368         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2369         ncurses_norm_attr.
2370         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2371         colors in ncurses_norm_attr.
2372         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2373         "none", replace it with the default color recorded in
2374         ncurses_norm_attr.
2375
2376 2019-03-14  Tom Tromey  <tromey@adacore.com>
2377
2378         * source-cache.h (class source_cache) <get_source_lines>: Return
2379         std::string.
2380         * source-cache.c (source_cache::extract_lines): Handle case where
2381         first_pos==npos.  Return std::string.
2382         (source_cache::get_source_lines): Update.
2383
2384 2019-03-14  Tom Tromey  <tromey@adacore.com>
2385
2386         * NEWS: Add item for "style sources" commands.
2387         * source-cache.c (source_cache::get_source_lines): Check
2388         source_styling.
2389         * cli/cli-style.c (source_styling): New global.
2390         (_initialize_cli_style): Add "style sources" commands.
2391         (show_style_sources): New function.
2392         * cli/cli-style.h (source_styling): Declare.
2393
2394 2019-03-14  Pedro Alves  <palves@redhat.com>
2395             Tom Tromey  <tromey@adacore.com>
2396
2397         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2398         * tui/tui-winsource.c (tui_refill_source_window): New function,
2399         from...
2400         (tui_horizontal_source_scroll): ... here.  Move some logic.
2401         * cli/cli-style.c (set_style_enabled): Notify new observable.
2402         * tui/tui-hooks.c (tui_redisplay_source): New function.
2403         (tui_attach_detach_observers): Attach or detach
2404         tui_redisplay_source.
2405         * observable.h (source_styling_changed): New observable.
2406         * observable.c: Define source_styling_changed observable.
2407
2408 2019-03-13  Tom Tromey  <tromey@adacore.com>
2409
2410         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2411         (i386_gnu_nat_target::store_registers): Update.
2412         * target-debug.h (target_debug_print_std_string): New macro.
2413         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2414         * windows-tdep.c (display_one_tib): Update.
2415         * tui/tui-stack.c (tui_make_status_line): Update.
2416         * top.c (print_inferior_quit_action): Update.
2417         * thread.c (thr_try_catch_cmd): Update.
2418         (add_thread_with_info): Update.
2419         (thread_target_id_str): Update.
2420         (thr_try_catch_cmd): Update.
2421         (thread_command): Update.
2422         (thread_find_command): Update.
2423         * record-btrace.c (record_btrace_target::info_record)
2424         (record_btrace_resume_thread, record_btrace_target::resume)
2425         (record_btrace_cancel_resume, record_btrace_step_thread)
2426         (record_btrace_target::wait, record_btrace_target::wait)
2427         (record_btrace_target::wait, record_btrace_target::stop): Update.
2428         * progspace.c (print_program_space): Update.
2429         * process-stratum-target.c
2430         (process_stratum_target::thread_address_space): Update.
2431         * linux-fork.c (linux_fork_mourn_inferior)
2432         (detach_checkpoint_command, info_checkpoints_command)
2433         (linux_fork_context): Update.
2434         (linux_fork_detach): Update.
2435         (class scoped_switch_fork_info): Update.
2436         (delete_checkpoint_command): Update.
2437         * infrun.c (follow_fork_inferior): Update.
2438         (follow_fork_inferior): Update.
2439         (proceed_after_vfork_done): Update.
2440         (handle_vfork_child_exec_or_exit): Update.
2441         (follow_exec): Update.
2442         (displaced_step_prepare_throw): Update.
2443         (displaced_step_restore): Update.
2444         (start_step_over): Update.
2445         (resume_1): Update.
2446         (clear_proceed_status_thread): Update.
2447         (proceed): Update.
2448         (print_target_wait_results): Update.
2449         (do_target_wait): Update.
2450         (context_switch): Update.
2451         (stop_all_threads): Update.
2452         (restart_threads): Update.
2453         (finish_step_over): Update.
2454         (handle_signal_stop): Update.
2455         (switch_back_to_stepped_thread): Update.
2456         (keep_going_pass_signal): Update.
2457         (print_exited_reason): Update.
2458         (normal_stop): Update.
2459         * inferior.c (inferior_pid_to_str): Change return type.
2460         (print_selected_inferior): Update.
2461         (add_inferior): Update.
2462         (detach_inferior): Update.
2463         * dummy-frame.c (fprint_dummy_frames): Update.
2464         * dcache.c (dcache_info_1): Update.
2465         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2466         (btrace_fetch, btrace_clear): Update.
2467         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2468         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2469         type.
2470         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2471         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2472         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2473         * gdbarch.c, gdbarch.h: Rebuild.
2474         * gdbarch.sh (core_pid_to_str): Change return type.
2475         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2476         return type.
2477         (windows_nat_target::pid_to_str): Change return type.
2478         (windows_delete_thread): Update.
2479         (windows_nat_target::attach): Update.
2480         (windows_nat_target::files_info): Update.
2481         * target-delegates.c: Rebuild.
2482         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2483         return type.
2484         (sol_thread_target::pid_to_str): Change return type.
2485         * remote.c (class remote_target) <pid_to_str>: Change return
2486         type.
2487         (remote_target::pid_to_str): Change return type.
2488         (extended_remote_target::attach, remote_target::remote_stop_ns)
2489         (remote_target::remote_notif_remove_queued_reply)
2490         (remote_target::push_stop_reply, remote_target::disable_btrace):
2491         Update.
2492         (extended_remote_target::attach): Update.
2493         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2494         type.
2495         (gdbsim_target::pid_to_str): Change return type.
2496         * ravenscar-thread.c (struct ravenscar_thread_target)
2497         <pid_to_str>: Change return type.
2498         (ravenscar_thread_target::pid_to_str): Change return type.
2499         * procfs.c (class procfs_target) <pid_to_str>: Change return
2500         type.
2501         (procfs_target::pid_to_str): Change return type.
2502         (procfs_target::attach): Update.
2503         (procfs_target::detach): Update.
2504         (procfs_target::fetch_registers): Update.
2505         (procfs_target::store_registers): Update.
2506         (procfs_target::wait): Update.
2507         (procfs_target::files_info): Update.
2508         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2509         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2510         return type.
2511         (nto_procfs_target::pid_to_str): Change return type.
2512         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2513         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2514         return type.
2515         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2516         (exit_lwp): Update.
2517         (attach_proc_task_lwp_callback, get_detach_signal)
2518         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2519         (linux_nat_target::resume, wait_lwp, stop_callback)
2520         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2521         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2522         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2523         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2524         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2525         type.
2526         (inf_ptrace_target::attach): Update.
2527         (inf_ptrace_target::files_info): Update.
2528         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2529         type.
2530         (go32_nat_target::pid_to_str): Change return type.
2531         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2532         (gnu_nat_target::wait): Update.
2533         (gnu_nat_target::wait): Update.
2534         (gnu_nat_target::resume): Update.
2535         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2536         (fbsd_nat_target::wait): Update.
2537         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2538         type.
2539         (darwin_nat_target::attach): Update.
2540         * corelow.c (class core_target) <pid_to_str>: Change return type.
2541         (core_target::pid_to_str): Change return type.
2542         * target.c (normal_pid_to_str): Change return type.
2543         (default_pid_to_str): Likewise.
2544         (target_pid_to_str): Change return type.
2545         (target_translate_tls_address): Update.
2546         (target_announce_detach): Update.
2547         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2548         return type.
2549         (bsd_uthread_target::pid_to_str): Change return type.
2550         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2551         type.
2552         (bsd_kvm_target::pid_to_str): Change return type.
2553         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2554         return type.
2555         (aix_thread_target::pid_to_str): Change return type.
2556         * target.h (struct target_ops) <pid_to_str>: Change return type.
2557         (target_pid_to_str, normal_pid_to_str): Likewise.
2558         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2559         type.
2560         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2561         type.
2562         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2563         return type.
2564         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2565         type.
2566         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2567         type.
2568         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2569         return type.
2570
2571 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2572
2573         * NEWS: Mention that the new default MI version is 3.  Mention
2574         changes to the output of commands and events that deal with
2575         multi-location breakpoints.
2576         * breakpoint.c: Include "mi/mi-out.h".
2577         (print_one_breakpoint): Change output syntax if using MI version
2578         >= 3.
2579         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2580         New.
2581         (mi_multi_location_breakpoint_output_fixed): New.
2582         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2583         (mi_cmd_fix_multi_location_breakpoint_output): New.
2584         (mi_multi_location_breakpoint_output_fixed): New.
2585         * mi/mi-cmds.c (mi_cmds): Register command
2586         -fix-multi-location-breakpoint-output.
2587         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2588         interpreter "mi".
2589
2590 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2591
2592         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2593         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2594         instantiate mi_ui_out based on interpreter name.
2595         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2596         * mi/mi-main.c (mi_load_progress): Likewise.
2597
2598 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2599
2600         * NEWS: Combine separate "New targets" sections for 8.3.
2601
2602 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2603
2604         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2605         (ppcfbsd_init_abi): Install gdbarch
2606         "fetch_tls_load_module_address" and "get_thread_local_address"
2607         methods.
2608
2609 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2610
2611         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2612         (riscv_fbsd_init_abi): Install gdbarch
2613         "fetch_tls_load_module_address" and "get_thread_local_address"
2614         methods.
2615
2616 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2617
2618         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2619         (i386fbsd_init_abi): Install gdbarch
2620         "fetch_tls_load_module_address" and "get_thread_local_address"
2621         methods.
2622
2623 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2624
2625         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2626         (amd64fbsd_init_abi): Install gdbarch
2627         "fetch_tls_load_module_address" and "get_thread_local_address"
2628         methods.
2629
2630 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2631
2632         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2633         (struct fbsd_pspace_data): New type.
2634         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2635         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2636         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2637         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2638         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2639
2640 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2641
2642         * gdbtypes.c (lookup_struct_elt): New function.
2643         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2644         * gdbtypes.h (struct struct_elt): New type.
2645         (lookup_struct_elt): New prototype.
2646
2647 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2648
2649         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2650         remove disabled code block.
2651
2652 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2653
2654         * gdbarch.sh (get_thread_local_address): New method.
2655         * gdbarch.h, gdbarch.c: Regenerate.
2656         * target.c (target_translate_tls_address): Use
2657         gdbarch_get_thread_local_address if present instead of
2658         target::get_thread_local_address.
2659
2660 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2661
2662         * target.h (target::get_thread_local_address): Update comment.
2663
2664 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2665
2666         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2667         objfile->separate_debug_objfile_backlink if not NULL.
2668
2669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2670
2671         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2672         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2673         (amd64bsd_store_inferior_registers): Likewise.
2674         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2675         Enable segment base registers.
2676         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2677         PT_GETFSBASE and PT_GETGSBASE.
2678         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2679         PT_SETGSBASE.
2680         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2681         segment base registers.
2682         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2683
2684 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2685
2686         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2687         Update calls to i386_target_description to add 'segments'
2688         parameter.
2689         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2690         add segment base registers.
2691         * arch/i386.c (i386_create_target_description): Add 'segments'
2692         parameter to enable segment base registers.
2693         * arch/i386.h (i386_create_target_description): Likewise.
2694         * features/i386/32bit-segments.xml: New file.
2695         * features/i386/32bit-segments.c: Generate.
2696         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2697         call to i386_target_description to add 'segments' parameter.
2698         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2699         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2700         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2701         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2702         if feature is present.
2703         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2704         Add 'segments' parameter to call to i386_target_description.
2705         (i386_target_description): Add 'segments' parameter to enable
2706         segment base registers.
2707         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2708         to call to i386_target_description.
2709         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2710         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2711         Define I386_NUM_REGS.
2712         (i386_target_description): Add 'segments' parameter to enable
2713         segment base registers.
2714
2715 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2716
2717         PR/24325
2718         * source-cache.c: #undef open and close, to avoid unresolved
2719         externals during linking.
2720
2721 2019-03-12  Tom Tromey  <tromey@adacore.com>
2722
2723         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2724         const.  Add initializers.
2725         (_initialize_remote): Don't initialize ptid globals.
2726
2727 2019-03-12  Pedro Alves  <palves@redhat.com>
2728
2729         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2730
2731 2019-03-12  Pedro Alves  <palves@redhat.com>
2732
2733         * cp-name-parser.y (main): Remove unused 'len' variable.
2734
2735 2019-03-12  Tom Tromey  <tromey@adacore.com>
2736
2737         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2738         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2739
2740 2019-03-12  Tom Tromey  <tromey@adacore.com>
2741
2742         * linux-nat.c (iterate_over_lwps): Update.
2743         (stop_callback): Remove parameter.
2744         (stop_wait_callback, detach_callback, resume_set_callback)
2745         (select_singlestep_lwp_callback, set_ignore_sigint)
2746         (status_callback, resumed_callback, resume_clear_callback)
2747         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2748         data parameter.
2749         (linux_nat_target::detach, linux_nat_target::resume)
2750         (linux_stop_and_wait_all_lwps, select_event_lwp)
2751         (linux_nat_filter_event, linux_nat_wait_1)
2752         (linux_nat_target::kill, linux_nat_target::stop)
2753         (linux_nat_target::stop): Update.
2754         (linux_nat_resume_callback): Change type.
2755         (resume_stopped_resumed_lwps, count_events_callback)
2756         (select_event_lwp_callback): Likewise.
2757         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2758         * arm-linux-nat.c (struct update_registers_data): Remove.
2759         (update_registers_callback): Change type.
2760         (arm_linux_insert_hw_breakpoint1): Update.
2761         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2762         parameter.
2763         (x86_linux_dr_set_addr): Update.
2764         (x86_linux_dr_set_control): Update.
2765         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2766         (iterate_over_lwps): Use gdb::function_view.
2767         * nat/aarch64-linux-hw-point.c (struct
2768         aarch64_dr_update_callback_param): Remove.
2769         (debug_reg_change_callback): Change type.
2770         (aarch64_notify_debug_reg_change): Update.
2771         * s390-linux-nat.c (s390_refresh_per_info): Update.
2772
2773 2019-03-11  Tom Tromey  <tromey@adacore.com>
2774
2775         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2776         redundant assignment to "this_cu".
2777
2778 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2779
2780         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2781
2782 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2783
2784         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2785         from...
2786         (rank_one_type): ... this.
2787
2788 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2789
2790         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2791         from...
2792         (rank_one_type): ... this.
2793
2794 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2795
2796         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2797         from...
2798         (rank_one_type): ... this.
2799
2800 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2801
2802         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2803         from...
2804         (rank_one_type): ... this.
2805
2806 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2807
2808         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2809         from...
2810         (rank_one_type): ... this.
2811
2812 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2813
2814         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2815         from...
2816         (rank_one_type): ... this.
2817
2818 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2819
2820         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2821         from...
2822         (rank_one_type): ... this.
2823
2824 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2825
2826         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2827         from...
2828         (rank_one_type): ... this.
2829
2830 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2831
2832         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2833         from...
2834         (rank_one_type): ... this.
2835
2836 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2837
2838         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2839         from...
2840         (rank_one_type): ... this.
2841
2842 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2843
2844         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2845         from...
2846         (rank_one_type): ... this.
2847
2848 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2849
2850         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2851         from...
2852         (rank_one_type): ... this.
2853
2854 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2855
2856         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2857         inferior-events' shows the example events.
2858
2859 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2860
2861         Support styling on native MS-Windows console
2862
2863         PR/24315
2864         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2865         on MS-Windows if $TERM is not defined.
2866
2867         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2868
2869         * posix-hdep.c (gdb_console_fputs):
2870         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2871         functions.
2872         * ui-file.h (gdb_console_fputs): Add prototype.
2873
2874         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2875         back to fputs only if the former returns zero.
2876
2877 2019-03-07  Tom Tromey  <tom@tromey.com>
2878
2879         * symmisc.c (print_symbol_bcache_statistics): Update.
2880         (print_objfile_statistics): Update.
2881         * symfile.c (allocate_symtab): Update.
2882         * stabsread.c: Don't include bcache.h.
2883         * psymtab.h (struct psymbol_bcache): Don't declare.
2884         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2885         (psymbol_bcache_init, psymbol_bcache_free)
2886         (psymbol_bcache_get_bcache): Don't declare.
2887         * psymtab.c (struct psymbol_bcache): Remove.
2888         (psymtab_storage::psymtab_storage): Update.
2889         (psymtab_storage::~psymtab_storage): Update.
2890         (psymbol_bcache_init, psymbol_bcache_free)
2891         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2892         (add_psymbol_to_bcache): Update.
2893         (allocate_psymtab): Update.
2894         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2895         macro_cache>: No longer pointers.
2896         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2897         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2898         * macrotab.c (macro_bcache): Update.
2899         * macroexp.c: Don't include bcache.h.
2900         * gdbtypes.c (check_types_worklist): Update.
2901         (types_deeply_equal): Remove TRY/CATCH.  Update.
2902         * elfread.c (elf_symtab_read): Update.
2903         * dwarf2read.c: Don't include bcache.h.
2904         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2905         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2906         (print_bcache_statistics, bcache_memory_used): Don't declare.
2907         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2908         methods.  Rename all data members.
2909         * bcache.c (struct bcache): Move to bcache.h.
2910         (bcache::expand_hash_table): Rename from expand_hash_table.
2911         (bcache): Remove.
2912         (bcache::insert): Rename from bcache_full.
2913         (bcache::compare): Rename from bcache_compare.
2914         (bcache_xmalloc): Remove.
2915         (bcache::~bcache): Rename from bcache_xfree.
2916         (bcache::print_statistics): Rename from print_bcache_statistics.
2917         (bcache::memory_used): Rename from bcache_memory_used.
2918
2919 2019-03-07  Pedro Alves  <palves@redhat.com>
2920
2921         * infrun.c (normal_stop): Also check for
2922         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2923
2924 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2925
2926         * f-lang.c (value_from_host_double): Moved to...
2927         * value.c (value_from_host_double): ...here.
2928         * value.h (value_from_host_double): Declare.
2929         * guile/scm-math.c (vlscm_convert_typed_number): Use
2930         value_from_host_double.
2931         (vlscm_convert_number): Likewise.
2932         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2933         * python/py-value.c (convert_value_from_python): Likewise.
2934
2935 2019-03-06  Tom Tromey  <tom@tromey.com>
2936
2937         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2938
2939 2019-03-06  Tom Tromey  <tom@tromey.com>
2940
2941         * utils.h (free_current_contents): Don't declare.
2942         * utils.c (free_current_contents): Remove.
2943
2944 2019-03-06  Tom Tromey  <tom@tromey.com>
2945
2946         * top.c (quit_force): Update.
2947         * main.c (captured_command_loop): Update.
2948         * common/new-op.c (operator new): Update.
2949         * common/common-exceptions.c (struct catcher)
2950         <save_cleanup_chain>: Remove member.
2951         (exceptions_state_mc_init): Update.
2952         (exception_try_scope_entry): Return nullptr.
2953         (exception_try_scope_exit, exception_rethrow)
2954         (throw_exception_sjlj, throw_exception_cxx): Update.
2955         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2956         (all_cleanups, do_cleanups, discard_cleanups)
2957         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2958         (restore_cleanups, restore_final_cleanups): Don't declare.
2959         (do_final_cleanups): Remove parameter.
2960         * common/cleanups.c (cleanup_chain, make_cleanup)
2961         (make_cleanup_dtor, all_cleanups, do_cleanups)
2962         (discard_my_cleanups, discard_cleanups)
2963         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2964         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2965         (null_cleanup): Remove.
2966         (do_final_cleanups): Remove parameter.
2967
2968 2019-03-06  Tom Tromey  <tom@tromey.com>
2969
2970         * remote.c (remote_target::remote_parse_stop_reply): Use
2971         unique_xmalloc_ptr.
2972
2973 2019-03-06  Tom Tromey  <tom@tromey.com>
2974
2975         * stabsread.c (struct stabs_field_info): Rename from field_info.
2976         <list, fnlist>: Add initializers.
2977         <obstack>: New member.
2978         (read_member_functions, read_struct_fields, read_baseclasses):
2979         Allocate on obstack.  Don't use cleanups.
2980         (read_one_struct_field, read_member_functions, read_struct_fields)
2981         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2982         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2983         (read_struct_type): Update.
2984
2985 2019-03-06  Tom Tromey  <tom@tromey.com>
2986
2987         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2988         * common/filestuff.h (make_cleanup_close): Don't declare.
2989         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2990         Remove.
2991
2992 2019-03-06  Tom Tromey  <tom@tromey.com>
2993
2994         * solib-aix.c: Use make_scope_exit.
2995
2996 2019-03-06  Tom Tromey  <tom@tromey.com>
2997
2998         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2999         Use make_scope_exit.
3000
3001 2019-03-06  Tom Tromey  <tom@tromey.com>
3002
3003         * solib-svr4.c (disable_probes_interface): Remove parameter.
3004         (svr4_handle_solib_event): Use make_scope_exit.
3005
3006 2019-03-06  Tom Tromey  <tom@tromey.com>
3007
3008         * remote.c (struct stop_reply_deleter): Remove.
3009         (stop_reply_up): Update.
3010         (struct stop_reply): Derive from notif_event.  Don't typedef.
3011         <regcache>: Now a std::vector.
3012         (stop_reply_xfree): Remove.
3013         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3014         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3015         (remote_target::discard_pending_stop_replies): Use delete.
3016         (remote_target::remote_parse_stop_reply): Update.
3017         (remote_target::process_stop_reply): Update.
3018         * remote-notif.h (struct notif_event): Add virtual destructor.
3019         Remove "dtr" member.
3020         (struct notif_client) <alloc_event>: Return a unique_ptr.
3021         (notif_event_xfree): Don't declare.
3022         (notif_event_up): New typedef.
3023         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3024         (notif_event_xfree, do_notif_event_xfree): Remove.
3025         (remote_notif_state_xfree): Update.
3026
3027 2019-03-06  Tom Tromey  <tom@tromey.com>
3028
3029         * infrun.c (displaced_step_clear_cleanup): Now a
3030         forward_scope_exit type.
3031         (displaced_step_prepare_throw): Update.
3032         (displaced_step_fixup): Update.
3033
3034 2019-03-06  Tom Tromey  <tom@tromey.com>
3035
3036         * inferior.h (class inferior): Update comment.
3037         * gdbthread.h (class thread_info): Update comment.
3038
3039 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3040             Tom Tromey  <tom@tromey.com>
3041
3042         * stabsread.h (struct stab_section_list): Remove.
3043         (coffstab_build_psymtabs): Update.
3044         * dbxread.c (symbuf_sections): Now a std::vector.
3045         (sect_idx): New global.
3046         (fill_symbuf): Update.
3047         (coffstab_build_psymtabs): Change type of stabsects parameter.
3048         Update.
3049         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3050         std::vector.
3051         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3052         (coff_locate_sections): Update.
3053         (coff_symfile_read): Remove cleanups.  Update.
3054         (init_stringtab): Add storage parameter.
3055         (free_stringtab, free_stringtab_cleanup): Remove.
3056         (init_lineno): Add storage parameter.
3057         (free_linetab, free_linetab_cleanup): Remove.
3058
3059 2019-03-06  Pedro Alves  <palves@redhat.com>
3060
3061         * linux-fork.c (fork_info::clobber_regs): Delete.
3062         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3063         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3064         comment.  Adjust.
3065         (scoped_switch_fork_info::scoped_switch_fork_info)
3066         (checkpoint_command, linux_fork_context): Adjust
3067         fork_save_infrun_state calls.
3068
3069 2019-03-06  Pedro Alves  <palves@redhat.com>
3070
3071         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3072         (inf_has_multiple_threads): Return 'bool' and rewrite using
3073         inferior_info::threads().
3074
3075 2019-03-06  Pedro Alves  <palves@redhat.com>
3076
3077         * linux-fork.c: Include <list>.
3078         (fork_list): Now a std::list instance.
3079         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3080         (forks_exist_p, find_last_fork): Adjust.
3081         (new_fork): Delete.
3082         (one_fork_p): New.
3083         (add_fork): Adjust.
3084         (free_fork): Delete, folded into fork_info::~fork_info().
3085         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3086         Adjust.
3087         (init_fork_list): Delete.
3088         (linux_fork_killall, linux_fork_mourn_inferior)
3089         (linux_fork_detach, info_checkpoints_command): Adjust.
3090         (_initialize_linux_fork): No longer call init_fork_list.
3091
3092 2019-03-06  Pedro Alves  <palves@redhat.com>
3093
3094         * linux-fork.c (new_fork): New, split out of ...
3095         (add_fork): ... this.  Return void.  Move "first fork" special
3096         case from here, to ...
3097         (checkpoint_command): ... here.
3098         * linux-linux.h (add_fork): Return void.
3099
3100 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3103
3104 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3105             Chris January  <chris.january@arm.com>
3106             David Lecomber  <david.lecomber@arm.com>
3107
3108         * f-exp.y: New token, UNOP_INTRINSIC.
3109         (exp): New pattern using UNOP_INTRINSIC token.
3110         (f77_keywords): Add 'abs' keyword.
3111         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3112         (value_from_host_double): New function.
3113         (evaluate_subexp_f): Support UNOP_ABS.
3114
3115 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3116
3117         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3118         types.
3119
3120 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3121
3122         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3123         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3124         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3125
3126 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3127
3128         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3129
3130 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3131             Chris January  <chris.january@arm.com>
3132
3133         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3134         * f-exp.y: Define 'KIND' token.
3135         (exp): New pattern for KIND expressions.
3136         (ptype): Handle types with a kind extension.
3137         (direct_abs_decl): Extend to spot kind extensions.
3138         (f77_keywords): Add 'kind' to the list.
3139         (push_kind_type): New function.
3140         (convert_to_kind_type): New function.
3141         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3142         * parse.c (operator_length_standard): Likewise.
3143         * parser-defs.h (enum type_pieces): Add tp_kind.
3144         * std-operator.def: Add UNOP_KIND.
3145
3146 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3147
3148         * f-exp.y (f_parse): Set yydebug.
3149
3150 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3151
3152         * f-lang.c (evaluate_subexp_f): New function.
3153         (exp_descriptor_f): New global.
3154         (f_language_defn): Use exp_descriptor_f instead of
3155         exp_descriptor_standard.
3156
3157 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3158
3159         * f-exp.y (struct token): Add comments.
3160         (dot_ops): Remove uppercase versions and the end marker.
3161         (f77_keywords): Likewise.
3162         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3163         entries in the dot_ops array are case insensitive, and use
3164         strncasecmp to compare strings.  Also some whitespace cleanup in
3165         this area.  Similar for the f77_keywords array, except entries in
3166         this list might be case sensitive.
3167
3168 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3169
3170         * f-exp.y (struct f77_boolean_val): Add comments.
3171         (boolean_values): Remove uppercase versions, and end marker.
3172         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3173         and use strncasecmp to achieve case insensitivity.  Additionally,
3174         perform whitespace cleanup around this code.
3175
3176 2019-03-06  Tom Tromey  <tromey@adacore.com>
3177
3178         * remote-sim.c (gdbsim_target_open): Use result of
3179         gdb_argv::release.
3180
3181 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3182         Dirk Schubert  <dirk.schubert@arm.com>
3183         Chris January  <chris.january@arm.com>
3184
3185         * eval.c (evaluate_subexp_standard): Call Fortran argument
3186         wrapping logic.
3187         * f-lang.c (struct value): A value which can be passed into a
3188         Fortran function call.
3189         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3190         where appropriate.
3191         (struct type): Value ready for a Fortran function call.
3192         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3193         is needed.
3194         * f-lang.h (fortran_argument_convert): Declaration.
3195         (fortran_preserve_arg_pointer): Declaration.
3196         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3197
3198 2019-03-05  Tom Tromey  <tromey@adacore.com>
3199
3200         * python/py-prettyprint.c (print_string_repr): Remove #if.
3201         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3202
3203 2019-03-05  Tom Tromey  <tromey@adacore.com>
3204
3205         * target.c (the_dummy_target): Move later.  Change type to
3206         "dummy_target".
3207         (initialize_targets): Don't initialize the_dummy_target.
3208
3209 2019-03-05  Tom Tromey  <tromey@adacore.com>
3210
3211         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3212         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3213
3214 2019-03-05  Tom Tromey  <tromey@adacore.com>
3215
3216         * windows-nat.c (windows_nat_target::attach)
3217         (windows_nat_target::detach): Don't call gdb_flush.
3218         * valprint.c (generic_val_print, val_print, val_print_string):
3219         Don't call gdb_flush.
3220         * utils.c (defaulted_query): Don't call gdb_flush.
3221         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3222         * target.c (target_announce_detach): Don't call gdb_flush.
3223         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3224         * remote.c (extended_remote_target::attach): Don't call
3225         gdb_flush.
3226         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3227         * printcmd.c (do_examine): Don't call gdb_flush.
3228         (info_display_command): Don't call gdb_flush.
3229         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3230         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3231         * memattr.c (info_mem_command): Don't call gdb_flush.
3232         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3233         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3234         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3235         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3236         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3237         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3238         (gnu_nat_target::detach): Don't call gdb_flush.
3239         * f-valprint.c (f_val_print): Don't call gdb_flush.
3240         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3241         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3242         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3243         gdb_flush.
3244         * c-valprint.c (c_val_print): Don't call gdb_flush.
3245         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3246
3247 2019-03-05  Tom Tromey  <tromey@adacore.com>
3248
3249         * varobj.c (update_dynamic_varobj_children): Update.
3250         (install_default_visualizer): Use reset, not release.
3251         * value.c (set_internalvar): Update.
3252         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3253         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3254         ATTRIBUTE_UNUSED_RESULT.
3255
3256 2019-03-05  Tom Tromey  <tromey@adacore.com>
3257
3258         * remote.c (class scoped_remote_fd) <release>: Add
3259         ATTRIBUTE_UNUSED_RESULT.
3260
3261 2019-03-05  Tom Tromey  <tromey@adacore.com>
3262
3263         * macroexp.c (struct macro_buffer) <release>: Add
3264         ATTRIBUTE_UNUSED_RESULT.
3265
3266 2019-03-05  Tom Tromey  <tromey@adacore.com>
3267
3268         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3269         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3270         ATTRIBUTE_UNUSED_RESULT.
3271
3272 2019-03-05  Tom Tromey  <tromey@adacore.com>
3273
3274         * common/scoped_fd.h (class scoped_fd) <release>: Add
3275         ATTRIBUTE_UNUSED_RESULT.
3276
3277 2019-03-05  Tom Tromey  <tromey@adacore.com>
3278
3279         * parser-defs.h (struct parser_state) <release>: Add
3280         ATTRIBUTE_UNUSED_RESULT.
3281
3282 2019-03-05  Tom Tromey  <tromey@adacore.com>
3283
3284         * utils.h (class gdb_argv) <release>: Add
3285         ATTRIBUTE_UNUSED_RESULT.
3286         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3287
3288 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3289
3290         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3291         for-loop range, to avoid compiler warnings.
3292
3293         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3294         avoid compiler warnings about unused variables.
3295
3296         * NEWS: Mention end of support for native debugging on MS-Windows
3297         before XP.
3298
3299         PR gdb/24292
3300         * common/netstuff.c:
3301         * gdbserver/gdbreplay.c
3302         * gdbserver/remote-utils.c:
3303         * ser-tcp.c:
3304         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3305         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3306         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3307         'getaddrinfo' and 'freeaddrinfo' were not available before
3308         Windows XP, and mingw.org's MinGW headers by default define
3309         _WIN32_WINNT to 0x500.
3310
3311 2019-03-01  Gary Benson <gbenson@redhat.com>
3312
3313         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3314
3315 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3316             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3317
3318         PR gdb/8527
3319         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3320         set_sigint_trap, clear_sigint_trap.
3321
3322 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3323
3324         * target.c (target_detach): Clear the regcache and the
3325         frame cache.
3326
3327 2019-02-27  Pedro Alves  <palves@redhat.com>
3328
3329         * utils.c (set_screen_size): When we cap the height/width sizes,
3330         tweak the corresponding command variable to show "unlimited":
3331
3332 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3333             Pedro Alves  <palves@redhat.com>
3334
3335         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3336         before calling rl_set_screen_size.
3337
3338 2019-02-27  Tom Tromey  <tromey@adacore.com>
3339
3340         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3341         define.
3342         * python/py-value.c: Remove Python 2.4 workaround.
3343         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3344         workaround.
3345         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3346         Python 2.4 workaround.
3347         * python/python-internal.h: Remove Python 2.4 comment.
3348         (Py_ssize_t): Don't define.
3349         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3350         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3351         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3352         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3353         * python/python.c (do_start_initialization): Remove Python 2.4
3354         workaround.
3355         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3356         (print_children): Remove Python 2.4 workaround.
3357         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3358         workaround.
3359         (CHARBUFFERPROC_NAME): Remove.
3360         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3361         Python 2.4 workaround.
3362
3363 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3364
3365         * NEWS: Note minimum Python version.
3366
3367 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3368
3369         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3370         code from these functions.  Remove corresponding ifdefs.  Use
3371         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3372         Remove gotos and target of gotos.
3373         (infpy_search_memory): Likewise.
3374
3375 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3376
3377         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3378         (hppa_gdbarch_init): Don't register deleted functions with
3379         gdbarch.
3380
3381 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3382
3383         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3384         (h8300_unwind_sp): Delete.
3385         (h8300_dummy_id): Delete.
3386         (h8300_gdbarch_init): Don't register deleted functions with
3387         gdbarch.
3388
3389 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3390
3391         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3392         (ft32_unwind_pc): Delete.
3393         (ft32_unwind_sp): Delete.
3394         (ft32_gdbarch_init): Don't register deleted functions with
3395         gdbarch.
3396
3397 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3398
3399         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3400         (frv_unwind_pc): Delete.
3401         (frv_unwind_sp): Delete.
3402         (frv_gdbarch_init): Don't register deleted functions with
3403         gdbarch.
3404
3405 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3406
3407         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3408         (riscv_unwind_pc): Delete.
3409         (riscv_unwind_sp): Delete.
3410         (riscv_gdbarch_init): Don't register deleted functions with
3411         gdbarch.
3412
3413 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3414
3415         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3416         (csky_unwind_pc): Delete.
3417         (csky_unwind_sp): Delete.
3418         (csky_gdbarch_init): Don't register deleted functions with
3419         gdbarch.
3420
3421 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3422
3423         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3424         (cris_unwind_pc): Delete.
3425         (cris_unwind_sp): Delete.
3426         (cris_gdbarch_init): Don't register deleted functions with
3427         gdbarch.
3428
3429 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3430
3431         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3432         (bfin_unwind_pc): Delete.
3433         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3434
3435 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3436
3437         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3438         (arm_unwind_pc): Delete.
3439         (arm_unwind_sp): Delete.
3440         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3441
3442 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3443
3444         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3445         (arc_unwind_pc): Delete.
3446         (arc_unwind_sp): Delete.
3447         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3448
3449 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3450
3451         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3452         (alpha_unwind_pc): Delete.
3453         (alpha_gdbarch_init): Don't register deleted functions with
3454         gdbarch.
3455
3456 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3457
3458         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3459         (aarch64_unwind_pc): Delete.
3460         (aarch64_unwind_sp): Delete.
3461         (aarch64_gdbarch_init): Don't register deleted functions with
3462         gdbarch.
3463
3464 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3465
3466         * gdbtypes.c (type_align): Don't consider static members when
3467         computing structure alignment.
3468
3469 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3470
3471         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3472         return 0 for other types.
3473         * arch-utils.c (default_type_align): Always return 0.
3474         * gdbarch.h: Regenerate.
3475         * gdbarch.sh (type_align): Extend comment.
3476         * gdbtypes.c (type_align): Add additional comments, always call
3477         gdbarch_type_align before applying the default rules.
3478         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3479         generic code will then apply a suitable default.
3480         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3481         types, return 0 for other types.
3482
3483 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3484
3485         * NEWS: Create a new section for the next release branch.
3486         Rename the section of the current branch, now that it has
3487         been cut.
3488
3489 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3490
3491         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3492         * version.in: Bump version to 8.3.50.DATE-git.
3493
3494 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3495
3496         * aix-thread.c (ptid_cmp): Remove unused variable.
3497         (get_signaled_thread): Likewise.
3498         (store_regs_user_thread): Likewise.
3499         (store_regs_kernel_thread): Likewise.
3500         (fetch_regs_kernel_thread): Remove shadowed variable.
3501
3502 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3503
3504         * features/riscv/32bit-cpu.xml: Add register numbers.
3505         * features/riscv/32bit-fpu.c: Regenerate.
3506         * features/riscv/32bit-fpu.xml: Add register numbers.
3507         * features/riscv/64bit-cpu.xml: Add register numbers.
3508         * features/riscv/64bit-fpu.c: Regenerate.
3509         * features/riscv/64bit-fpu.xml: Add register numbers.
3510
3511 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3512
3513         * NEWS: Mention two argument form of gdb.Value constructor.
3514         * python/py-value.c (convert_buffer_and_type_to_value): New
3515         function.
3516         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3517         Add support for handling an optional second argument.  Call
3518         convert_buffer_and_type_to_value as appropriate.
3519         * python/python-internal.h (Py_buffer_deleter): New struct.
3520         (Py_buffer_up): New typedef.
3521
3522 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3523
3524         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3525         instead of releasing ownership.
3526
3527 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3528
3529         * dwarf2read.c (open_and_init_dwp_file): Call
3530         elf_numsections instead of bfd_count_sections to initialize
3531         dwp_file->num_sections.
3532
3533 2019-02-25  Tom Tromey  <tromey@adacore.com>
3534
3535         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3536
3537 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3538
3539         * gcore.in: Add '--readnever' option when invoking GDB.
3540
3541 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3542
3543         * MAINTAINERS: Update my email address.
3544
3545 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3546
3547         * build-id.c (build_id_to_debug_bfd_1): New function.
3548         (build_id_to_debug_bfd): Look for separate debug file in
3549         sysroot.
3550
3551 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3552
3553         * gdbarch.sh: Update the copyright year range that is placed into
3554         generated files.
3555
3556 2019-02-22  Keith Seitz  <keiths@redhat.com>
3557
3558         PR symtab/23853
3559         * linespec.c (create_sals_line_offset): Search for the default
3560         symtab's filename instead of its fullname.
3561
3562 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3563
3564         * NEWS: Update style defaults.
3565
3566 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3567
3568         * main.c (captured_main_1): Disable styling in batch mode.
3569
3570 2019-02-20  Tom Tromey  <tom@tromey.com>
3571
3572         * symtab.c (symtab_symbol_info): Fix typos.
3573
3574 2019-02-20  Tom Tromey  <tromey@adacore.com>
3575
3576         * findcmd.c (_initialize_mem_search): Use upper case for
3577         metasyntactic variables.
3578
3579 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3580
3581         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3582         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3583
3584 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3585
3586         * top.h (source_file_name): Change to std::string.
3587         * top.c (source_file_name): Likewise.
3588         (command_line_input): Adjust.
3589         * cli/cli-script.c (script_from_file): Adjust.
3590
3591 2019-02-19  Tom Tromey  <tromey@adacore.com>
3592
3593         * ravenscar-thread.c
3594         (ravenscar_thread_target::update_thread_list): Don't call
3595         ada_build_task_list.
3596         * ada-lang.h (ada_build_task_list): Don't declare.
3597         * ada-tasks.c (struct ada_tasks_inferior_data)
3598         <task_list_valid_p>: Now bool.
3599         (read_known_tasks, ada_task_list_changed)
3600         (ada_tasks_invalidate_inferior_data): Update.
3601         (read_known_tasks_array): Return bool.
3602         (read_known_tasks_list): Likewise.
3603         (read_known_tasks): Return void.
3604         (ada_build_task_list): Now static.
3605
3606 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3607
3608         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3609         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3610
3611 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3612
3613         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3614         variant for ada_tasks_pspace_data_handle and
3615         ada_tasks_inferior_data_handle.
3616         (ada_tasks_pspace_data_cleanup): New function.
3617         (ada_tasks_inferior_data_cleanup): New function.
3618
3619 2019-02-17  Tom Tromey  <tom@tromey.com>
3620
3621         * macrotab.h (macro_source_fullname): Return a std::string.
3622         * macrotab.c (macro_include, check_for_redefinition)
3623         (macro_undef, macro_lookup_definition, foreach_macro)
3624         (foreach_macro_in_scope): Update.
3625         (macro_source_fullname): Return a std::string.
3626         * macrocmd.c (show_pp_source_pos): Update.
3627
3628 2019-02-17  Tom Tromey  <tom@tromey.com>
3629
3630         * macrocmd.c (show_pp_source_pos): Style the file names.
3631
3632 2019-02-17  Tom Tromey  <tom@tromey.com>
3633
3634         PR tui/24197:
3635         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3636
3637 2019-02-17  Tom Tromey  <tom@tromey.com>
3638
3639         * ada-lang.c (user_select_syms): Use filtered printing.
3640         * utils.c (wrap_style): New global.
3641         (desired_style): Remove.
3642         (emit_style_escape): Add stream parameter.
3643         (set_output_style, reset_terminal_style, prompt_for_continue):
3644         Update.
3645         (flush_wrap_buffer): Only flush gdb_stdout.
3646         (wrap_here): Set wrap_style.
3647         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3648         treat escape sequences as a character.  Change when wrap buffer is
3649         flushed.
3650         (fputs_styled): Do not set the output style when the default is
3651         requested.
3652         * ui-style.h (struct ui_file_style) <is_default>: New method.
3653         * source.c (print_source_lines_base): Emit escape sequences in one
3654         piece.
3655
3656 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3657
3658         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3659         integers and enumeration types.
3660
3661 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3662
3663         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3664         instead of lookup_symbol_in_language
3665         (do_exact_match): New function.
3666         (ada_get_symbol_name_matcher): Return do_exact_match when
3667         doing a verbatim match.
3668
3669 2019-02-15  Tom Tromey  <tromey@adacore.com>
3670
3671         * ravenscar-thread.c (ravenscar_thread_target::resume)
3672         (ravenscar_thread_target::wait): Special case wildcard requests.
3673
3674 2019-02-15  Tom Tromey  <tromey@adacore.com>
3675
3676         * ravenscar-thread.c (base_ptid): Remove.
3677         (struct ravenscar_thread_target) <close>: New method.
3678         <m_base_ptid>: New member.
3679         <update_inferior_ptid, active_task, task_is_currently_active,
3680         runtime_initialized>: Declare methods.
3681         <ravenscar_thread_target>: Add constructor.
3682         (ravenscar_thread_target::task_is_currently_active)
3683         (ravenscar_thread_target::update_inferior_ptid)
3684         (ravenscar_runtime_initialized): Rename.  Now methods.
3685         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3686         (ravenscar_thread_target::update_thread_list): Update.
3687         (ravenscar_thread_target::active_task): Now method.
3688         (ravenscar_thread_target::store_registers)
3689         (ravenscar_thread_target::prepare_to_store)
3690         (ravenscar_thread_target::prepare_to_store)
3691         (ravenscar_thread_target::mourn_inferior): Update.
3692         (ravenscar_inferior_created): Use "new" to create target.
3693         (ravenscar_thread_target::get_ada_task_ptid): Update.
3694         (_initialize_ravenscar): Don't initialize base_ptid.
3695         (ravenscar_ops): Remove global.
3696
3697 2019-02-15  Tom Tromey  <tromey@adacore.com>
3698
3699         * target.h (push_target): Declare new overload.
3700         * target.c (push_target): New overload, taking an rvalue reference.
3701         * remote.c (remote_target::open_1): Use push_target overload.
3702         * corelow.c (core_target_open): Use push_target overload.
3703
3704 2019-02-15  Tom Tromey  <tromey@adacore.com>
3705
3706         * ravenscar-thread.c (is_ravenscar_task)
3707         (ravenscar_task_is_currently_active): Return bool.
3708         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3709         (_initialize_ravenscar): Remove "(void)".
3710         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3711         Return bool.
3712
3713 2019-02-15  Tom Tromey  <tromey@adacore.com>
3714
3715         * ravenscar-thread.c (ravenscar_runtime_initializer)
3716         (has_ravenscar_runtime, get_running_thread_id)
3717         (ravenscar_thread_target::resume): Fix indentation.
3718
3719 2019-02-15  Tom Tromey  <tromey@adacore.com>
3720
3721         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3722         from ravenscar_arch_ops.
3723         (sparc_ravenscar_ops::fetch_registers)
3724         (sparc_ravenscar_ops::store_registers): Now methods.
3725         (sparc_ravenscar_prepare_to_store): Remove.
3726         (sparc_ravenscar_ops): Redefine.
3727         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3728         methods and destructor.  Remove members.
3729         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3730         (ravenscar_thread_target::store_registers)
3731         (ravenscar_thread_target::prepare_to_store): Update.
3732         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3733         Remove.
3734         (struct ppc_ravenscar_powerpc_ops): Derive from
3735         ravenscar_arch_ops.
3736         (ppc_ravenscar_powerpc_ops::fetch_registers)
3737         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3738         (ppc_ravenscar_powerpc_ops): Redefine.
3739         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3740         (ppc_ravenscar_e500_ops::fetch_registers)
3741         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3742         (ppc_ravenscar_e500_ops): Redefine.
3743         * aarch64-ravenscar-thread.c
3744         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3745         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3746         (aarch64_ravenscar_fetch_registers)
3747         (aarch64_ravenscar_store_registers): Now methods.
3748         (aarch64_ravenscar_ops): Redefine.
3749
3750 2019-02-15  Tom Tromey  <tromey@adacore.com>
3751
3752         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3753         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3754         (ravenscar_thread_target::stopped_by_watchpoint)
3755         (ravenscar_thread_target::stopped_data_address)
3756         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3757
3758 2019-02-15  Tom Tromey  <tromey@adacore.com>
3759
3760         * ravenscar-thread.c: Fix some typos.
3761
3762 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3763             Tom Tromey  <tromey@adacore.com>
3764
3765         * ada-lang.c (ada_exception_sal): Change addr_string to a
3766         std::string.
3767         (create_ada_exception_catchpoint): Update.
3768
3769 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3770             Tom Tromey  <tromey@adacore.com>
3771
3772         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3773         (bp_location_ops): Remove.
3774         (base_breakpoint_allocate_location): Update.
3775         (free_bp_location): Update.
3776         * ada-lang.c (class ada_catchpoint_location)
3777         <ada_catchpoint_location>: Remove ops parameter.
3778         (ada_catchpoint_location_dtor): Remove.
3779         (ada_catchpoint_location_ops): Remove.
3780         (allocate_location_exception): Update.
3781         * breakpoint.h (struct bp_location_ops): Remove.
3782         (class bp_location) <bp_location>: Remove bp_location_ops
3783         parameter.
3784         <~bp_location>: Add destructor.
3785         <ops>: Remove.
3786
3787 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3788             Pedro Alves  <palves@redhat.com>
3789
3790         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3791         'PATH_MAX'.
3792
3793 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3794             Samuel Thibault  <samuel.thibault@gnu.org>
3795             Thomas Schwinge  <thomas@codesourcery.com>
3796
3797         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3798         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3799
3800 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3801
3802         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3803         (check_empty): Use "const char *".
3804
3805         * gnu-nat.c (gnu_nat_target::detach): Instead of
3806         'detach_inferior (pid)' call
3807         'detach_inferior (find_inferior_pid (pid))'.
3808
3809         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3810         'nat/fork-inferior.o'.
3811         * gnu-nat.c: #include "nat/fork-inferior.h".
3812
3813         * gnu-nat.c (gnu_nat_target::detach): Instead of
3814         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3815         * gnu-nat.h: #include "inf-child.h".
3816         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3817         'i386_gnu_nat_target::fetch_registers'.
3818         (gnu_store_registers): Rename/move to
3819         'i386_gnu_nat_target::store_registers'.
3820
3821         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3822         * gnu-nat.h (mach_thread_info): New function.
3823         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3824
3825         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3826
3827 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3828
3829         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3830
3831 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3832
3833         * windows-nat.c (windows_add_thread): Add new parameter
3834         "main_thread_p" with default value set to false.  Update
3835         function documentation as well as all callers.
3836         (windows_delete_thread): Likewise.
3837         (fake_create_process): Update call to windows_add_thread.
3838         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3839         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3840         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3841         call to windows_delete_thread.
3842
3843 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3844
3845         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3846
3847 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3848
3849         * symfile.c (find_separate_debug_file): Use canonical path of
3850         sysroot with child_path instead of gdb_sysroot if it is valid.
3851
3852 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3853
3854         * symfile.c (find_separate_debug_file): Use child_path to
3855         determine if an object file is under a sysroot.
3856
3857 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3858
3859         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3860         unittests/child-path-selftests.c.
3861         * common/pathstuff.c (child_path): New function.
3862         * common/pathstuff.h (child_path): New prototype.
3863         * unittests/child-path-selftests.c: New file.
3864
3865 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3866
3867         * symfile.c (find_separate_debug_file): Look for separate debug
3868         files in debug directories under the sysroot.
3869
3870 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3871
3872         * symtab.h (struct minimal_symbol data_p): New const method.
3873         (struct minimal_symbol text_p): Likewise.
3874         * symtab.c (output_source_filename): Use file name style
3875         to print file name.
3876         (print_symbol_info): Likewise.
3877         (print_msymbol_info): Use address style to print addresses.
3878         Use function name style to print executable text symbols.
3879         (expand_symtab_containing_pc): Use data_p.
3880         (find_pc_sect_compunit_symtab): Likewise.
3881
3882 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3883
3884         * breakpoint.c (describe_other_breakpoints): Use address style
3885         to print addresses.
3886         (say_where): Likewise.
3887
3888 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3889
3890         * ada-typeprint.c (print_func_type): Print function name
3891         style to print function name.
3892         * c-typeprint.c (c_print_type_1): Likewise.
3893
3894 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3895
3896         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3897         for execve.
3898
3899 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3900
3901         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3902         type_stack.
3903
3904 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3905
3906         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3907         TYPE_CODE_REF types.
3908
3909 2019-02-08  Jim Wilson  <jimw@sifive.com>
3910
3911         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3912         (riscv_linux_fregset): New.
3913         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3914
3915 2019-02-07  Tom Tromey  <tom@tromey.com>
3916
3917         * thread.c (thread_cancel_execution_command): Update.
3918         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3919         methods.
3920         (struct thread_fsm_ops): Remove.
3921         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3922         (thread_fsm_should_stop, thread_fsm_return_value)
3923         (thread_fsm_set_finished, thread_fsm_finished_p)
3924         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3925         Don't declare.
3926         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3927         * infrun.c (clear_proceed_status_thread)
3928         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3929         (print_stop_event): Update.
3930         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3931         Add constructor.
3932         (step_command_fsm_ops): Remove.
3933         (new_step_command_fsm): Remove.
3934         (step_1): Update.
3935         (step_command_fsm::should_stop): Rename from
3936         step_command_fsm_should_stop.
3937         (step_command_fsm::clean_up): Rename from
3938         step_command_fsm_clean_up.
3939         (step_command_fsm::do_async_reply_reason): Rename from
3940         step_command_fsm_async_reply_reason.
3941         (struct until_next_fsm): Inherit from thread_fsm.  Add
3942         constructor.
3943         (until_next_fsm_ops): Remove.
3944         (new_until_next_fsm): Remove.
3945         (until_next_fsm::should_stop): Rename from
3946         until_next_fsm_should_stop.
3947         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3948         (until_next_fsm::do_async_reply_reason): Rename from
3949         until_next_fsm_async_reply_reason.
3950         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3951         constructor.  Change type of breakpoint.
3952         (finish_command_fsm_ops): Remove.
3953         (new_finish_command_fsm): Remove.
3954         (finish_command_fsm::should_stop): Rename from
3955         finish_command_fsm_should_stop.
3956         (finish_command_fsm::clean_up): Rename from
3957         finish_command_fsm_clean_up.
3958         (finish_command_fsm::return_value): Rename from
3959         finish_command_fsm_return_value.
3960         (finish_command_fsm::do_async_reply_reason): Rename from
3961         finish_command_fsm_async_reply_reason.
3962         (finish_command): Update.
3963         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3964         Add constructor.
3965         (call_thread_fsm_ops): Remove.
3966         (call_thread_fsm::call_thread_fsm): Rename from
3967         new_call_thread_fsm.
3968         (call_thread_fsm::should_stop): Rename from
3969         call_thread_fsm_should_stop.
3970         (call_thread_fsm::should_notify_stop): Rename from
3971         call_thread_fsm_should_notify_stop.
3972         (run_inferior_call, call_function_by_hand_dummy): Update.
3973         * cli/cli-interp.c (should_print_stop_to_console): Update.
3974         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3975         Add constructor.  Change type of location_breakpoint,
3976         caller_breakpoint.
3977         (until_break_fsm_ops): Remove.
3978         (new_until_break_fsm): Remove.
3979         (until_break_fsm::should_stop): Rename from
3980         until_break_fsm_should_stop.
3981         (until_break_fsm::clean_up): Rename from
3982         until_break_fsm_clean_up.
3983         (until_break_fsm::do_async_reply_reason): Rename from
3984         until_break_fsm_async_reply_reason.
3985         (until_break_command): Update.
3986         * thread-fsm.c: Remove.
3987         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3988
3989 2019-02-07  Tom Tromey  <tom@tromey.com>
3990
3991         * yy-remap.h: Add include guard.
3992         * xtensa-tdep.h: Add include guard.
3993         * xcoffread.h: Rename include guard.
3994         * varobj-iter.h: Add include guard.
3995         * tui/tui.h: Rename include guard.
3996         * tui/tui-winsource.h: Rename include guard.
3997         * tui/tui-wingeneral.h: Rename include guard.
3998         * tui/tui-windata.h: Rename include guard.
3999         * tui/tui-win.h: Rename include guard.
4000         * tui/tui-stack.h: Rename include guard.
4001         * tui/tui-source.h: Rename include guard.
4002         * tui/tui-regs.h: Rename include guard.
4003         * tui/tui-out.h: Rename include guard.
4004         * tui/tui-layout.h: Rename include guard.
4005         * tui/tui-io.h: Rename include guard.
4006         * tui/tui-hooks.h: Rename include guard.
4007         * tui/tui-file.h: Rename include guard.
4008         * tui/tui-disasm.h: Rename include guard.
4009         * tui/tui-data.h: Rename include guard.
4010         * tui/tui-command.h: Rename include guard.
4011         * tic6x-tdep.h: Add include guard.
4012         * target/waitstatus.h: Rename include guard.
4013         * target/wait.h: Rename include guard.
4014         * target/target.h: Rename include guard.
4015         * target/resume.h: Rename include guard.
4016         * target-float.h: Rename include guard.
4017         * stabsread.h: Add include guard.
4018         * rs6000-tdep.h: Add include guard.
4019         * riscv-fbsd-tdep.h: Add include guard.
4020         * regformats/regdef.h: Rename include guard.
4021         * record.h: Rename include guard.
4022         * python/python.h: Rename include guard.
4023         * python/python-internal.h: Rename include guard.
4024         * python/py-stopevent.h: Rename include guard.
4025         * python/py-ref.h: Rename include guard.
4026         * python/py-record.h: Rename include guard.
4027         * python/py-record-full.h: Rename include guard.
4028         * python/py-record-btrace.h: Rename include guard.
4029         * python/py-instruction.h: Rename include guard.
4030         * python/py-events.h: Rename include guard.
4031         * python/py-event.h: Rename include guard.
4032         * procfs.h: Add include guard.
4033         * proc-utils.h: Add include guard.
4034         * p-lang.h: Add include guard.
4035         * or1k-tdep.h: Rename include guard.
4036         * observable.h: Rename include guard.
4037         * nto-tdep.h: Rename include guard.
4038         * nat/x86-linux.h: Rename include guard.
4039         * nat/x86-linux-dregs.h: Rename include guard.
4040         * nat/x86-gcc-cpuid.h: Add include guard.
4041         * nat/x86-dregs.h: Rename include guard.
4042         * nat/x86-cpuid.h: Rename include guard.
4043         * nat/ppc-linux.h: Rename include guard.
4044         * nat/mips-linux-watch.h: Rename include guard.
4045         * nat/linux-waitpid.h: Rename include guard.
4046         * nat/linux-ptrace.h: Rename include guard.
4047         * nat/linux-procfs.h: Rename include guard.
4048         * nat/linux-osdata.h: Rename include guard.
4049         * nat/linux-nat.h: Rename include guard.
4050         * nat/linux-namespaces.h: Rename include guard.
4051         * nat/linux-btrace.h: Rename include guard.
4052         * nat/glibc_thread_db.h: Rename include guard.
4053         * nat/gdb_thread_db.h: Rename include guard.
4054         * nat/gdb_ptrace.h: Rename include guard.
4055         * nat/fork-inferior.h: Rename include guard.
4056         * nat/amd64-linux-siginfo.h: Rename include guard.
4057         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4058         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4059         * nat/aarch64-linux.h: Rename include guard.
4060         * nat/aarch64-linux-hw-point.h: Rename include guard.
4061         * mn10300-tdep.h: Add include guard.
4062         * mips-linux-tdep.h: Add include guard.
4063         * mi/mi-parse.h: Rename include guard.
4064         * mi/mi-out.h: Rename include guard.
4065         * mi/mi-main.h: Rename include guard.
4066         * mi/mi-interp.h: Rename include guard.
4067         * mi/mi-getopt.h: Rename include guard.
4068         * mi/mi-console.h: Rename include guard.
4069         * mi/mi-common.h: Rename include guard.
4070         * mi/mi-cmds.h: Rename include guard.
4071         * mi/mi-cmd-break.h: Rename include guard.
4072         * m2-lang.h: Add include guard.
4073         * location.h: Rename include guard.
4074         * linux-record.h: Rename include guard.
4075         * linux-nat.h: Add include guard.
4076         * linux-fork.h: Add include guard.
4077         * i386-darwin-tdep.h: Rename include guard.
4078         * hppa-linux-offsets.h: Add include guard.
4079         * guile/guile.h: Rename include guard.
4080         * guile/guile-internal.h: Rename include guard.
4081         * gnu-nat.h: Rename include guard.
4082         * gdb-stabs.h: Rename include guard.
4083         * frv-tdep.h: Add include guard.
4084         * f-lang.h: Add include guard.
4085         * event-loop.h: Add include guard.
4086         * darwin-nat.h: Rename include guard.
4087         * cp-abi.h: Rename include guard.
4088         * config/sparc/nm-sol2.h: Rename include guard.
4089         * config/nm-nto.h: Rename include guard.
4090         * config/nm-linux.h: Add include guard.
4091         * config/i386/nm-i386gnu.h: Rename include guard.
4092         * config/djgpp/nl_types.h: Rename include guard.
4093         * config/djgpp/langinfo.h: Rename include guard.
4094         * compile/gcc-cp-plugin.h: Add include guard.
4095         * compile/gcc-c-plugin.h: Add include guard.
4096         * compile/compile.h: Rename include guard.
4097         * compile/compile-object-run.h: Rename include guard.
4098         * compile/compile-object-load.h: Rename include guard.
4099         * compile/compile-internal.h: Rename include guard.
4100         * compile/compile-cplus.h: Rename include guard.
4101         * compile/compile-c.h: Rename include guard.
4102         * common/xml-utils.h: Rename include guard.
4103         * common/x86-xstate.h: Rename include guard.
4104         * common/version.h: Rename include guard.
4105         * common/vec.h: Rename include guard.
4106         * common/tdesc.h: Rename include guard.
4107         * common/selftest.h: Rename include guard.
4108         * common/scoped_restore.h: Rename include guard.
4109         * common/scoped_mmap.h: Rename include guard.
4110         * common/scoped_fd.h: Rename include guard.
4111         * common/safe-iterator.h: Rename include guard.
4112         * common/run-time-clock.h: Rename include guard.
4113         * common/refcounted-object.h: Rename include guard.
4114         * common/queue.h: Rename include guard.
4115         * common/ptid.h: Rename include guard.
4116         * common/print-utils.h: Rename include guard.
4117         * common/preprocessor.h: Rename include guard.
4118         * common/pathstuff.h: Rename include guard.
4119         * common/observable.h: Rename include guard.
4120         * common/netstuff.h: Rename include guard.
4121         * common/job-control.h: Rename include guard.
4122         * common/host-defs.h: Rename include guard.
4123         * common/gdb_wait.h: Rename include guard.
4124         * common/gdb_vecs.h: Rename include guard.
4125         * common/gdb_unlinker.h: Rename include guard.
4126         * common/gdb_unique_ptr.h: Rename include guard.
4127         * common/gdb_tilde_expand.h: Rename include guard.
4128         * common/gdb_sys_time.h: Rename include guard.
4129         * common/gdb_string_view.h: Rename include guard.
4130         * common/gdb_splay_tree.h: Rename include guard.
4131         * common/gdb_setjmp.h: Rename include guard.
4132         * common/gdb_ref_ptr.h: Rename include guard.
4133         * common/gdb_optional.h: Rename include guard.
4134         * common/gdb_locale.h: Rename include guard.
4135         * common/gdb_assert.h: Rename include guard.
4136         * common/filtered-iterator.h: Rename include guard.
4137         * common/filestuff.h: Rename include guard.
4138         * common/fileio.h: Rename include guard.
4139         * common/environ.h: Rename include guard.
4140         * common/common-utils.h: Rename include guard.
4141         * common/common-types.h: Rename include guard.
4142         * common/common-regcache.h: Rename include guard.
4143         * common/common-inferior.h: Rename include guard.
4144         * common/common-gdbthread.h: Rename include guard.
4145         * common/common-exceptions.h: Rename include guard.
4146         * common/common-defs.h: Rename include guard.
4147         * common/common-debug.h: Rename include guard.
4148         * common/cleanups.h: Rename include guard.
4149         * common/buffer.h: Rename include guard.
4150         * common/btrace-common.h: Rename include guard.
4151         * common/break-common.h: Rename include guard.
4152         * cli/cli-utils.h: Rename include guard.
4153         * cli/cli-style.h: Rename include guard.
4154         * cli/cli-setshow.h: Rename include guard.
4155         * cli/cli-script.h: Rename include guard.
4156         * cli/cli-interp.h: Rename include guard.
4157         * cli/cli-decode.h: Rename include guard.
4158         * cli/cli-cmds.h: Rename include guard.
4159         * charset-list.h: Add include guard.
4160         * buildsym-legacy.h: Rename include guard.
4161         * bfin-tdep.h: Add include guard.
4162         * ax.h: Rename include guard.
4163         * arm-linux-tdep.h: Add include guard.
4164         * arm-fbsd-tdep.h: Add include guard.
4165         * arch/xtensa.h: Rename include guard.
4166         * arch/tic6x.h: Add include guard.
4167         * arch/i386.h: Add include guard.
4168         * arch/arm.h: Rename include guard.
4169         * arch/arm-linux.h: Rename include guard.
4170         * arch/arm-get-next-pcs.h: Rename include guard.
4171         * arch/amd64.h: Add include guard.
4172         * arch/aarch64-insn.h: Rename include guard.
4173         * arch-utils.h: Rename include guard.
4174         * annotate.h: Add include guard.
4175         * amd64-darwin-tdep.h: Rename include guard.
4176         * aarch64-linux-tdep.h: Add include guard.
4177         * aarch64-fbsd-tdep.h: Add include guard.
4178         * aarch32-linux-nat.h: Add include guard.
4179
4180 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4181
4182         * macrotab.c (macro_define_internal): New function that
4183         factorizes macro_define_object_internal and macro_define_function
4184         code.
4185         (macro_define_object_internal): Use macro_define_internal.
4186         (macro_define_function): Likewise.
4187
4188 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4189
4190         * macrocmd.c (extract_identifier): Return
4191         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4192         callers.
4193
4194 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4195
4196         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4197
4198 2019-02-05  Tom Tromey  <tom@tromey.com>
4199
4200         * target.c (target_stack::unpush): Move assertion earlier.
4201
4202 2019-01-30  Tom Tromey  <tom@tromey.com>
4203
4204         PR python/23615:
4205         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4206         (gdbpy_parse_and_eval): Likewise.
4207         * python/python-internal.h (gdbpy_allow_threads): New class.
4208
4209 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4210
4211         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4212         (aarch64_fbsd_fpregmap): Move earlier.
4213         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4214         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4215         instead of individual calls to trad_frame_set_reg_addr.
4216         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4217         earlier.
4218         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4219         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4220         instead of individual calls to trad_frame_set_reg_addr.
4221
4222 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4223
4224         * CONTRIBUTE: Replace contribution list with wiki link.
4225
4226 2019-01-25  Tom Tromey  <tom@tromey.com>
4227
4228         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4229
4230 2019-01-25  Tom Tromey  <tom@tromey.com>
4231
4232         * xtensa-linux-nat.c: Fix common/ includes.
4233         * xml-support.h: Fix common/ includes.
4234         * xml-support.c: Fix common/ includes.
4235         * x86-linux-nat.c: Fix common/ includes.
4236         * windows-nat.c: Fix common/ includes.
4237         * varobj.h: Fix common/ includes.
4238         * varobj.c: Fix common/ includes.
4239         * value.c: Fix common/ includes.
4240         * valops.c: Fix common/ includes.
4241         * utils.c: Fix common/ includes.
4242         * unittests/xml-utils-selftests.c: Fix common/ includes.
4243         * unittests/utils-selftests.c: Fix common/ includes.
4244         * unittests/unpack-selftests.c: Fix common/ includes.
4245         * unittests/tracepoint-selftests.c: Fix common/ includes.
4246         * unittests/style-selftests.c: Fix common/ includes.
4247         * unittests/string_view-selftests.c: Fix common/ includes.
4248         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4249         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4250         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4251         * unittests/rsp-low-selftests.c: Fix common/ includes.
4252         * unittests/parse-connection-spec-selftests.c: Fix common/
4253         includes.
4254         * unittests/optional-selftests.c: Fix common/ includes.
4255         * unittests/offset-type-selftests.c: Fix common/ includes.
4256         * unittests/observable-selftests.c: Fix common/ includes.
4257         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4258         * unittests/memrange-selftests.c: Fix common/ includes.
4259         * unittests/memory-map-selftests.c: Fix common/ includes.
4260         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4261         * unittests/function-view-selftests.c: Fix common/ includes.
4262         * unittests/environ-selftests.c: Fix common/ includes.
4263         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4264         * unittests/common-utils-selftests.c: Fix common/ includes.
4265         * unittests/cli-utils-selftests.c: Fix common/ includes.
4266         * unittests/array-view-selftests.c: Fix common/ includes.
4267         * ui-file.c: Fix common/ includes.
4268         * tui/tui-io.c: Fix common/ includes.
4269         * tracepoint.h: Fix common/ includes.
4270         * tracepoint.c: Fix common/ includes.
4271         * tracefile-tfile.c: Fix common/ includes.
4272         * top.h: Fix common/ includes.
4273         * top.c: Fix common/ includes.
4274         * thread.c: Fix common/ includes.
4275         * target/waitstatus.h: Fix common/ includes.
4276         * target/waitstatus.c: Fix common/ includes.
4277         * target.h: Fix common/ includes.
4278         * target.c: Fix common/ includes.
4279         * target-memory.c: Fix common/ includes.
4280         * target-descriptions.c: Fix common/ includes.
4281         * symtab.h: Fix common/ includes.
4282         * symfile.c: Fix common/ includes.
4283         * stap-probe.c: Fix common/ includes.
4284         * spu-linux-nat.c: Fix common/ includes.
4285         * sparc-nat.c: Fix common/ includes.
4286         * source.c: Fix common/ includes.
4287         * solib.c: Fix common/ includes.
4288         * solib-target.c: Fix common/ includes.
4289         * ser-unix.c: Fix common/ includes.
4290         * ser-tcp.c: Fix common/ includes.
4291         * ser-pipe.c: Fix common/ includes.
4292         * ser-base.c: Fix common/ includes.
4293         * selftest-arch.c: Fix common/ includes.
4294         * s12z-tdep.c: Fix common/ includes.
4295         * rust-exp.y: Fix common/ includes.
4296         * rs6000-aix-tdep.c: Fix common/ includes.
4297         * riscv-tdep.c: Fix common/ includes.
4298         * remote.c: Fix common/ includes.
4299         * remote-notif.h: Fix common/ includes.
4300         * remote-fileio.h: Fix common/ includes.
4301         * remote-fileio.c: Fix common/ includes.
4302         * regcache.h: Fix common/ includes.
4303         * regcache.c: Fix common/ includes.
4304         * record-btrace.c: Fix common/ includes.
4305         * python/python.c: Fix common/ includes.
4306         * python/py-type.c: Fix common/ includes.
4307         * python/py-inferior.c: Fix common/ includes.
4308         * progspace.h: Fix common/ includes.
4309         * producer.c: Fix common/ includes.
4310         * procfs.c: Fix common/ includes.
4311         * proc-api.c: Fix common/ includes.
4312         * printcmd.c: Fix common/ includes.
4313         * ppc-linux-nat.c: Fix common/ includes.
4314         * parser-defs.h: Fix common/ includes.
4315         * osdata.c: Fix common/ includes.
4316         * obsd-nat.c: Fix common/ includes.
4317         * nat/x86-linux.c: Fix common/ includes.
4318         * nat/x86-linux-dregs.c: Fix common/ includes.
4319         * nat/x86-dregs.h: Fix common/ includes.
4320         * nat/x86-dregs.c: Fix common/ includes.
4321         * nat/ppc-linux.c: Fix common/ includes.
4322         * nat/mips-linux-watch.h: Fix common/ includes.
4323         * nat/mips-linux-watch.c: Fix common/ includes.
4324         * nat/linux-waitpid.c: Fix common/ includes.
4325         * nat/linux-ptrace.h: Fix common/ includes.
4326         * nat/linux-ptrace.c: Fix common/ includes.
4327         * nat/linux-procfs.c: Fix common/ includes.
4328         * nat/linux-personality.c: Fix common/ includes.
4329         * nat/linux-osdata.c: Fix common/ includes.
4330         * nat/linux-namespaces.c: Fix common/ includes.
4331         * nat/linux-btrace.h: Fix common/ includes.
4332         * nat/linux-btrace.c: Fix common/ includes.
4333         * nat/fork-inferior.c: Fix common/ includes.
4334         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4335         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4336         * nat/aarch64-linux.c: Fix common/ includes.
4337         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4338         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4339         * namespace.h: Fix common/ includes.
4340         * mips-linux-tdep.c: Fix common/ includes.
4341         * minsyms.c: Fix common/ includes.
4342         * mi/mi-parse.h: Fix common/ includes.
4343         * mi/mi-main.c: Fix common/ includes.
4344         * mi/mi-cmd-env.c: Fix common/ includes.
4345         * memrange.h: Fix common/ includes.
4346         * memattr.c: Fix common/ includes.
4347         * maint.h: Fix common/ includes.
4348         * maint.c: Fix common/ includes.
4349         * main.c: Fix common/ includes.
4350         * machoread.c: Fix common/ includes.
4351         * location.c: Fix common/ includes.
4352         * linux-thread-db.c: Fix common/ includes.
4353         * linux-nat.c: Fix common/ includes.
4354         * linux-fork.c: Fix common/ includes.
4355         * inline-frame.c: Fix common/ includes.
4356         * infrun.c: Fix common/ includes.
4357         * inflow.c: Fix common/ includes.
4358         * inferior.h: Fix common/ includes.
4359         * inferior.c: Fix common/ includes.
4360         * infcmd.c: Fix common/ includes.
4361         * inf-ptrace.c: Fix common/ includes.
4362         * inf-child.c: Fix common/ includes.
4363         * ia64-linux-nat.c: Fix common/ includes.
4364         * i387-tdep.c: Fix common/ includes.
4365         * i386-tdep.c: Fix common/ includes.
4366         * i386-linux-tdep.c: Fix common/ includes.
4367         * i386-linux-nat.c: Fix common/ includes.
4368         * i386-go32-tdep.c: Fix common/ includes.
4369         * i386-fbsd-tdep.c: Fix common/ includes.
4370         * i386-fbsd-nat.c: Fix common/ includes.
4371         * guile/scm-type.c: Fix common/ includes.
4372         * guile/guile.c: Fix common/ includes.
4373         * go32-nat.c: Fix common/ includes.
4374         * gnu-nat.c: Fix common/ includes.
4375         * gdbthread.h: Fix common/ includes.
4376         * gdbarch-selftests.c: Fix common/ includes.
4377         * gdb_usleep.c: Fix common/ includes.
4378         * gdb_select.h: Fix common/ includes.
4379         * gdb_bfd.c: Fix common/ includes.
4380         * gcore.c: Fix common/ includes.
4381         * fork-child.c: Fix common/ includes.
4382         * findvar.c: Fix common/ includes.
4383         * fbsd-nat.c: Fix common/ includes.
4384         * event-top.c: Fix common/ includes.
4385         * event-loop.c: Fix common/ includes.
4386         * dwarf2read.c: Fix common/ includes.
4387         * dwarf2loc.c: Fix common/ includes.
4388         * dwarf2-frame.c: Fix common/ includes.
4389         * dwarf-index-cache.c: Fix common/ includes.
4390         * dtrace-probe.c: Fix common/ includes.
4391         * disasm-selftests.c: Fix common/ includes.
4392         * defs.h: Fix common/ includes.
4393         * csky-tdep.c: Fix common/ includes.
4394         * cp-valprint.c: Fix common/ includes.
4395         * cp-support.h: Fix common/ includes.
4396         * cp-support.c: Fix common/ includes.
4397         * corelow.c: Fix common/ includes.
4398         * completer.h: Fix common/ includes.
4399         * completer.c: Fix common/ includes.
4400         * compile/compile.c: Fix common/ includes.
4401         * compile/compile-loc2c.c: Fix common/ includes.
4402         * compile/compile-cplus-types.c: Fix common/ includes.
4403         * compile/compile-cplus-symbols.c: Fix common/ includes.
4404         * command.h: Fix common/ includes.
4405         * cli/cli-dump.c: Fix common/ includes.
4406         * cli/cli-cmds.c: Fix common/ includes.
4407         * charset.c: Fix common/ includes.
4408         * build-id.c: Fix common/ includes.
4409         * btrace.h: Fix common/ includes.
4410         * btrace.c: Fix common/ includes.
4411         * breakpoint.h: Fix common/ includes.
4412         * breakpoint.c: Fix common/ includes.
4413         * ax.h: 
4414         (enum agent_op): Fix common/ includes.
4415         * ax-general.c (struct aop_map): Fix common/ includes.
4416         * ax-gdb.c: Fix common/ includes.
4417         * auxv.c: Fix common/ includes.
4418         * auto-load.c: Fix common/ includes.
4419         * arm-tdep.c: Fix common/ includes.
4420         * arch/riscv.c: Fix common/ includes.
4421         * arch/ppc-linux-common.c: Fix common/ includes.
4422         * arch/i386.c: Fix common/ includes.
4423         * arch/arm.c: Fix common/ includes.
4424         * arch/arm-linux.c: Fix common/ includes.
4425         * arch/arm-get-next-pcs.c: Fix common/ includes.
4426         * arch/amd64.c: Fix common/ includes.
4427         * arch/aarch64.c: Fix common/ includes.
4428         * arch/aarch64-insn.c: Fix common/ includes.
4429         * arch-utils.c: Fix common/ includes.
4430         * amd64-windows-tdep.c: Fix common/ includes.
4431         * amd64-tdep.c: Fix common/ includes.
4432         * amd64-sol2-tdep.c: Fix common/ includes.
4433         * amd64-obsd-tdep.c: Fix common/ includes.
4434         * amd64-nbsd-tdep.c: Fix common/ includes.
4435         * amd64-linux-tdep.c: Fix common/ includes.
4436         * amd64-linux-nat.c: Fix common/ includes.
4437         * amd64-fbsd-tdep.c: Fix common/ includes.
4438         * amd64-fbsd-nat.c: Fix common/ includes.
4439         * amd64-dicos-tdep.c: Fix common/ includes.
4440         * amd64-darwin-tdep.c: Fix common/ includes.
4441         * agent.c: Fix common/ includes.
4442         * ada-lang.h: Fix common/ includes.
4443         * ada-lang.c: Fix common/ includes.
4444         * aarch64-tdep.c: Fix common/ includes.
4445
4446 2019-01-25  Tom Tromey  <tom@tromey.com>
4447
4448         * common/create-version.sh: Use common/version.h.
4449
4450 2019-01-24  Pedro Alves  <palves@redhat.com>
4451
4452         * infrun.c (signal_stop, signal_print, signal_program)
4453         (signal_catch, signal_pass): Now arrays instead of pointers.
4454         (update_signals_program_target, do_target_resume)
4455         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4456         * linux-nat.c (linux_nat_target::pass_signals)
4457         (linux_nat_target::create_inferior, linux_nat_target::attach):
4458         Adjust.
4459         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4460         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4461         * procfs.c (procfs_target::pass_signals): Adjust.
4462         * record-full.c (record_full_target::resume): Adjust.
4463         * remote.c (remote_target::pass_signals)
4464         (remote_target::program_signals): Adjust.
4465         * target-debug.h (target_debug_print_signals): Now takes a
4466         gdb::array_view as parameter.  Adjust.
4467         * target.h (target_ops) <pass_signals, program_signals>: Replace
4468         pointer and length parameters with gdb::array_view.
4469         (target_pass_signals, target_program_signals): Likewise.
4470         * target-delegates.c: Regenerate.
4471
4472 2019-01-24  Pedro Alves  <palves@redhat.com>
4473
4474         * common/forward-scope-exit.h
4475         (forward_scope_exit::forward_scope_exit): Pass arguments to
4476         m_bind_function directly, instead of creating a std::bind and
4477         copying that.
4478
4479 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4480
4481         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4482         for static members.
4483         (pass_in_v_vfp_candidate): Likewise.
4484
4485 2019-01-23  Tom Tromey  <tom@tromey.com>
4486             Pedro Alves  <palves@redhat.com>
4487
4488         * regcache.c (class regcache_invalidator): Remove.
4489         (regcache::raw_write): Use make_scope_exit.
4490
4491 2019-01-23  Tom Tromey  <tom@tromey.com>
4492
4493         * ui-out.h (class ui_out_emit_type): Update comment.
4494
4495 2019-01-23  Tom Tromey  <tom@tromey.com>
4496
4497         * infrun.c (fetch_inferior_event): Update comment.
4498
4499 2019-01-23  Tom Tromey  <tom@tromey.com>
4500             Pedro Alves  <palves@redhat.com>
4501
4502         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4503         parameter.
4504         (fetch_inferior_event): Use SCOPE_EXIT.
4505
4506
4507 2019-01-23  Tom Tromey  <tom@tromey.com>
4508             Pedro Alves  <palves@redhat.com>
4509
4510         * infrun.c (disable_thread_events): Delete.
4511         (stop_all_threads): Use SCOPE_EXIT.
4512
4513 2019-01-23  Tom Tromey  <tom@tromey.com>
4514             Pedro Alves  <palves@redhat.com>
4515
4516         * symfile.c: Include forward-scope-exit.h.
4517         (clear_symtab_users_cleanup): Replace forward declaration with
4518         a FORWARD_SCOPE_EXIT.
4519         (syms_from_objfile_1): Use the forward_scope_exit and
4520         gdb::optional instead of cleanup_function.
4521         (reread_symbols): Use the forward_scope_exit instead of
4522         cleanup_function.
4523         (clear_symtab_users_cleanup): Remove function.
4524
4525 2019-01-23  Tom Tromey  <tom@tromey.com>
4526             Pedro Alves  <palves@redhat.com>
4527
4528         * linux-nat.c: Include scope-exit.h.
4529         (cleanup_target_stop): Remove.
4530         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4531         SCOPE_EXIT.
4532
4533 2019-01-23  Tom Tromey  <tom@tromey.com>
4534             Pedro Alves  <palves@redhat.com>
4535
4536         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4537         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4538
4539 2019-01-23  Tom Tromey  <tom@tromey.com>
4540             Andrew Burgess  <andrew.burgess@embecosm.com>
4541             Pedro Alves  <palves@redhat.com>
4542
4543         * infrun.c (fetch_inferior_event): Use scope_exit.
4544         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4545         * top.c (execute_command): Use scope_exit.
4546         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4547         * utils.c (do_bpstat_clear_actions_cleanup)
4548         (make_bpstat_clear_actions_cleanup): Remove.
4549
4550 2019-01-23  Tom Tromey  <tom@tromey.com>
4551             Pedro Alves  <palves@redhat.com>
4552
4553         * infrun.c: Include "common/scope-exit.h"
4554         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4555         (wait_for_inferior): Use SCOPE_EXIT.
4556         (fetch_inferior_event): Use scope_exit.
4557
4558 2019-01-23  Tom Tromey  <tom@tromey.com>
4559             Pedro Alves  <palves@redhat.com>
4560
4561         * breakpoint.c (create_breakpoint): Remove cleanup.
4562
4563 2019-01-23  Tom Tromey  <tom@tromey.com>
4564             Andrew Burgess  <andrew.burgess@embecosm.com>
4565             Pedro Alves  <palves@redhat.com>
4566
4567 2019-01-23  Pedro Alves  <palves@redhat.com>
4568
4569         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4570
4571 2019-01-23  Pedro Alves  <palves@redhat.com>
4572             Andrew Burgess  <andrew.burgess@embecosm.com>
4573
4574         * gdbthread.h: Include "common/forward-scope-exit.h".
4575         (scoped_finish_thread_state): Redefine custom class in terms of
4576         forward_scope_exit.
4577
4578 2019-01-23  Pedro Alves  <palves@redhat.com>
4579             Andrew Burgess  <andrew.burgess@embecosm.com>
4580
4581         * common/forward-scope-exit.h: New file.
4582
4583 2019-01-23  Pedro Alves  <palves@redhat.com>
4584             Andrew Burgess  <andrew.burgess@embecosm.com>
4585             Tom Tromey  <tom@tromey.com>
4586
4587         * common/scope-exit.h: New file.
4588
4589 2019-01-23  Pedro Alves  <palves@redhat.com>
4590
4591         * common/preprocessor.h (ESC): Rename to ...
4592         (ESC_PARENS): ... this.
4593         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4594         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4595
4596 2019-01-23  Tom Tromey  <tom@tromey.com>
4597
4598         * language.h (class scoped_switch_to_sym_language_if_auto):
4599         Initialize m_lang in both cases.
4600
4601 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4602
4603         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4604         with XCNEW.
4605
4606 2019-01-22  Tom Tromey  <tom@tromey.com>
4607
4608         * corelow.c: Do not include sys/file.h.
4609
4610 2019-01-22  Tom Tromey  <tom@tromey.com>
4611
4612         * tui/tui-wingeneral.h: Include gdb_curses.h.
4613
4614 2019-01-22  Tom Tromey  <tom@tromey.com>
4615
4616         * source-cache.h (class source_cache) <get_source_lines,
4617         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4618
4619 2019-01-22  Tom Tromey  <tom@tromey.com>
4620
4621         * remote-fileio.h (struct remote_target): Declare.
4622
4623 2019-01-22  Tom Tromey  <tom@tromey.com>
4624
4625         * python/py-arch.c: Do not include py-ref.h.
4626         * python/py-bpevent.c: Do not include py-ref.h.
4627         * python/py-cmd.c: Do not include py-ref.h.
4628         * python/py-continueevent.c: Do not include py-ref.h.
4629         * python/py-event.h: Do not include py-ref.h.
4630         * python/py-evtregistry.c: Do not include py-ref.h.
4631         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4632         * python/py-frame.c: Do not include py-ref.h.
4633         * python/py-framefilter.c: Do not include py-ref.h.
4634         * python/py-function.c: Do not include py-ref.h.
4635         * python/py-infevents.c: Do not include py-ref.h.
4636         * python/py-linetable.c: Do not include py-ref.h.
4637         * python/py-objfile.c: Do not include py-ref.h.
4638         * python/py-param.c: Do not include py-ref.h.
4639         * python/py-prettyprint.c: Do not include py-ref.h.
4640         * python/py-progspace.c: Do not include py-ref.h.
4641         * python/py-symbol.c: Do not include py-ref.h.
4642         * python/py-symtab.c: Do not include py-ref.h.
4643         * python/py-type.c: Do not include py-ref.h.
4644         * python/py-unwind.c: Do not include py-ref.h.
4645         * python/py-utils.c: Do not include py-ref.h.
4646         * python/py-value.c: Do not include py-ref.h.
4647         * python/py-varobj.c: Do not include py-ref.h.
4648         * python/py-xmethods.c: Do not include py-ref.h.
4649         * python/python.c: Do not include py-ref.h.
4650         * varobj.c: Do not include py-ref.h.
4651
4652 2019-01-22  Tom Tromey  <tom@tromey.com>
4653
4654         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4655         keyword for bcache.
4656
4657 2019-01-22  Tom Tromey  <tom@tromey.com>
4658
4659         * compile/compile-cplus-types.c: Remove a comment by #include.
4660
4661 2019-01-22  Tom Tromey  <tom@tromey.com>
4662
4663         * compile/gcc-c-plugin.h: Include compile-internal.h.
4664
4665 2019-01-22  Tom Tromey  <tom@tromey.com>
4666
4667         * stabsread.c (EXTERN): Do not define.
4668         (symnum, next_symbol_text_func, processing_gcc_compilation)
4669         (within_function, global_sym_chain, global_stabs)
4670         (previous_stab_code, this_object_header_files)
4671         (n_this_object_header_files)
4672         (n_allocated_this_object_header_files): Define.
4673         * stabsread.h (EXTERN): Never define.  Use "extern".
4674
4675 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4676
4677         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4678         history_value.
4679
4680 2019-01-21  Tom Tromey  <tom@tromey.com>
4681
4682         * ui-out.c: Fix includes.
4683         * tui/tui-source.c: Fix includes.
4684         * target.c: Fix includes.
4685         * remote.c: Fix includes.
4686         * regcache.c: Fix includes.
4687         * python/py-block.c: Fix includes.
4688         * printcmd.c: Fix includes.
4689         * or1k-tdep.c: Fix includes.
4690         * mi/mi-main.c: Fix includes.
4691         * m32r-tdep.c: Fix includes.
4692         * csky-tdep.c: Fix includes.
4693         * compile/compile-cplus-types.c: Fix includes.
4694         * cli/cli-interp.c: Fix includes.
4695
4696 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4697
4698         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4699         for padding.
4700
4701 2019-01-16  Tom Tromey  <tom@tromey.com>
4702
4703         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4704         earlier.
4705         (struct objfile) <msymbols_range>: Move from top level.
4706         <msymbols>: New method.
4707         (class objfile_msymbols): Remove.
4708         * symtab.c (default_collect_symbol_completion_matches_break_on):
4709         Update.
4710         * symmisc.c (dump_msymbols): Update.
4711         * stabsread.c (scan_file_globals): Update.
4712         * objc-lang.c (info_selectors_command, info_classes_command)
4713         (find_methods): Update.
4714         * minsyms.c (find_solib_trampoline_target): Update.
4715         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4716         * coffread.c (coff_symfile_read): Update.
4717         * ada-lang.c (ada_lookup_simple_minsym)
4718         (ada_collect_symbol_completion_matches): Update.
4719
4720 2019-01-16  Tom Tromey  <tom@tromey.com>
4721
4722         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4723         type.  Remove no-argument constructor.
4724         <iterator::operator++>: Simplify.
4725         <begin>: Update.
4726         <end>: Use minimal_symbol_count.
4727
4728 2019-01-16  Tom Tromey  <tom@tromey.com>
4729
4730         * objfiles.h (struct objfile) <psymtabs>: New method.
4731         (class objfile_psymtabs): Remove.
4732         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4733         typedef.
4734         <range>: New method.
4735         (require_partial_symbols): Change return type.
4736         * psymtab.c (require_partial_symbols)
4737         (psym_expand_symtabs_matching): Update.
4738         * mdebugread.c (parse_partial_symbols): Update.
4739         * dbxread.c (dbx_end_psymtab): Update.
4740
4741 2019-01-15  Tom Tromey  <tom@tromey.com>
4742
4743         * symtab.c (lookup_objfile_from_block)
4744         (lookup_symbol_in_objfile_symtabs)
4745         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4746         (find_line_symtab, info_sources_command)
4747         (default_collect_symbol_completion_matches_break_on)
4748         (make_source_files_completion_list): Update.
4749         * symmisc.c (print_objfile_statistics, dump_objfile)
4750         (maintenance_print_symbols, maintenance_info_symtabs)
4751         (maintenance_check_symtabs, maintenance_info_line_tables):
4752         Update.
4753         * source.c (select_source_symtab)
4754         (forget_cached_source_info_for_objfile): Update.
4755         * objfiles.h (class objfile_compunits): Remove.
4756         (struct objfile) <compunits_range>: New typedef.
4757         (compunits): New method.
4758         * objfiles.c (objfile_relocate1): Update.
4759         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4760         * maint.c (count_symtabs_and_blocks): Update.
4761         * linespec.c (iterate_over_all_matching_symtabs): Update.
4762         * cp-support.c (add_symbol_overload_list_qualified): Update.
4763         * coffread.c (coff_symtab_read): Update.
4764         * ada-lang.c (add_nonlocal_symbols)
4765         (ada_collect_symbol_completion_matches)
4766         (ada_add_global_exceptions): Update.
4767
4768 2019-01-15  Tom Tromey  <tom@tromey.com>
4769
4770         * progspace.h (program_space) <objfiles_safe_range>: New
4771         typedef.
4772         <objfiles_safe>: New method.
4773         * objfiles.h (class all_objfiles_safe): Remove.
4774         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4775         * jit.c (jit_inferior_exit_hook): Update.
4776
4777 2019-01-17  Tom Tromey  <tom@tromey.com>
4778
4779         * progspace.h (program_space) <objfiles_range>: New typedef.
4780         <objfiles>: New method.
4781         <objfiles_head>: Rename from objfiles.
4782         (object_files): Update.
4783         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4784         * guile/scm-pretty-print.c
4785         (ppscm_find_pretty_printer_from_objfiles): Update.
4786         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4787         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4788         Update.
4789         * python/py-progspace.c (pspy_get_objfiles): Update.
4790         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4791         Update.
4792         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4793         (objfpy_lookup_objfile_by_build_id): Update.
4794         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4795         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4796         Update.
4797         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4798         (expand_symtab_containing_pc, lookup_objfile_from_block)
4799         (lookup_static_symbol, basic_lookup_transparent_type)
4800         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4801         (find_line_symtab, info_sources_command)
4802         (default_collect_symbol_completion_matches_break_on)
4803         (make_source_files_completion_list, find_main_name): Update.
4804         * symmisc.c (print_symbol_bcache_statistics)
4805         (print_objfile_statistics, maintenance_print_symbols)
4806         (maintenance_print_msymbols, maintenance_print_objfiles)
4807         (maintenance_info_symtabs, maintenance_check_symtabs)
4808         (maintenance_expand_symtabs, maintenance_info_line_tables):
4809         Update.
4810         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4811         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4812         (map_overlay_command, unmap_overlay_command)
4813         (simple_overlay_update, expand_symtabs_matching)
4814         (map_symbol_filenames): Update.
4815         * symfile-debug.c (set_debug_symfile): Update.
4816         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4817         Update.
4818         * source.c (select_source_symtab, forget_cached_source_info):
4819         Update.
4820         * solib.c (solib_read_symbols): Update.
4821         * solib-spu.c (append_ocl_sos): Update.
4822         * psymtab.c (maintenance_print_psymbols)
4823         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4824         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4825         * printcmd.c (info_symbol_command): Update.
4826         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4827         Update.
4828         * objfiles.h (class all_objfiles): Remove.
4829         * objfiles.c (have_partial_symbols, have_full_symbols)
4830         (have_minimal_symbols, qsort_cmp, update_section_map)
4831         (shared_objfile_contains_address_p)
4832         (default_iterate_over_objfiles_in_search_order): Update.
4833         * objc-lang.c (info_selectors_command, info_classes_command)
4834         (find_methods): Update.
4835         * minsyms.c (find_solib_trampoline_target): Update.
4836         * maint.c (maintenance_info_sections)
4837         (maintenance_translate_address, count_symtabs_and_blocks):
4838         Update.
4839         * main.c (captured_main_1): Update.
4840         * linux-thread-db.c (try_thread_db_load_from_pdir)
4841         (has_libpthread): Update.
4842         * linespec.c (iterate_over_all_matching_symtabs)
4843         (search_minsyms_for_name): Update.
4844         * jit.c (jit_find_objf_with_entry_addr): Update.
4845         * hppa-tdep.c (find_unwind_entry)
4846         (hppa_lookup_stub_minimal_symbol): Update.
4847         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4848         Update.
4849         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4850         (elf_gnu_ifunc_resolve_by_got): Update.
4851         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4852         * dwarf-index-write.c (save_gdb_index_command): Update.
4853         * cp-support.c (add_symbol_overload_list_qualified): Update.
4854         * breakpoint.c (create_overlay_event_breakpoint)
4855         (create_longjmp_master_breakpoint)
4856         (create_std_terminate_master_breakpoint)
4857         (create_exception_master_breakpoint): Update.
4858         * blockframe.c (find_pc_partial_function): Update.
4859         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4860         (ada_collect_symbol_completion_matches)
4861         (ada_add_global_exceptions): Update.
4862
4863 2019-01-17  Tom Tromey  <tom@tromey.com>
4864
4865         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4866         declare VEC.
4867         (solib_target_parse_libraries): Change return type.
4868         (library_list_start_segment, library_list_start_section)
4869         (library_list_end_library, library_list_start_library); Update.
4870         (solib_target_free_library_list): Remove.
4871         (solib_target_parse_libraries): Remove cleanup.  Change return
4872         type.
4873         (solib_target_current_sos): Update.
4874
4875 2019-01-17  Tom Tromey  <tromey@bapiya>
4876
4877         * valprint.c: Replace "the the" with "the".
4878         * symtab.c: Replace "the the" with "the".
4879         * solib.c: Replace "the the" with "the".
4880         * solib-dsbt.c: Replace "the the" with "the".
4881         * linespec.c: Replace "the the" with "the".
4882         * dwarf2loc.h: Replace "the the" with "the".
4883         * amd64-windows-tdep.c: Replace "the the" with "the".
4884         * aarch64-tdep.c: Replace "the the" with "the".
4885
4886 2019-01-16  Keith Seitz  <keiths@redhat.com>
4887
4888         PR gdb/23773
4889         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4890         <builder>: Rename to ..
4891         <m_builder>: ... this and make private.
4892         (dwarf2_cu::get_builder): New method.  Change all users of
4893         `builder' to use this method.
4894         (dwarf2_start_symtab): Move to ...
4895         (dwarf2_cu::start_symtab): ... here.  Update all callers
4896         (setup_type_unit_groups): Move to ...
4897         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4898         callers.
4899         (dwarf2_cu::reset_builder): New method.
4900         (process_full_compunit, process_full_type_unit): Use
4901         dwarf2_cu::reset_builder.
4902         (follow_die_offset): Record the ancestor CU if it is different
4903         from the followed DIE's CU.
4904         (follow_die_sig_1): Likewise.
4905
4906 2019-01-15  Tom Tromey  <tom@tromey.com>
4907
4908         * remote.c (class remote_state) <buf>: Now a char_vector.
4909         <buf_size>: Remove.
4910         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4911         parameter.
4912         (remote_target::getpkt_or_notif_sane_1)
4913         (remote_target::getpkt_sane)
4914         (remote_target::getpkt_or_notif_sane): Likewise.
4915         (class remote_target) <putpkt>: New overload.
4916         (remote_target::read_frame): Change type of "buf_p".  Remove
4917         sizeof_p parameter.
4918         (packet_ok): New overload.
4919         (packet_check_result): New overload.
4920         Update all uses.
4921
4922 2019-01-14  Tom Tromey  <tom@tromey.com>
4923
4924         * remote-notif.c (handle_notification, remote_notif_ack)
4925         (remote_notif_parse): Make "buf" const.
4926         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4927         const.
4928         (remote_notif_parse, remote_notif_ack, handle_notification):
4929         Likewise.
4930         * remote.c (remote_notif_stop_parse): Make "buf" const.
4931         (remote_target::remote_parse_stop_reply): Make "buf" const.
4932         (remote_notif_stop_ack): Make "buf" const.
4933
4934 2019-01-14  Tom Tromey  <tom@tromey.com>
4935
4936         * remote.c (remote_console_output): Make parameter const.
4937
4938 2019-01-14  Tom Tromey  <tom@tromey.com>
4939
4940         * target-debug.h (target_debug_print_signals): Constify.
4941         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4942         * procfs.c (procfs_target::pass_signals): Update.
4943         * linux-nat.c (linux_nat_target::pass_signals): Update.
4944         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4945         * target-delegates.c: Rebuild.
4946         * remote.c (remote_target::program_signals): Update.
4947         (remote_target::pass_signals): Update.
4948         * target.c (target_pass_signals): Constify argument.
4949         (target_program_signals): Likewise.
4950         * target.h (struct target_ops) <pass_signals, program_signals>:
4951         Constify argument.
4952         (target_pass_signals, target_program_signals): Constify argument.
4953
4954 2019-01-14  Tom Tromey  <tom@tromey.com>
4955
4956         PR tui/28819:
4957         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4958
4959 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4960
4961         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4962         field.
4963         * rs6000-tdep.c: Include reggroups.h.
4964         (IS_V_ALIAS_PSEUDOREG): Define.
4965         (rs6000_register_name): Return names for the "vX" aliases.
4966         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4967         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4968         aliases.  Call default_register_reggroup_p for all other
4969         pseudo-registers.
4970         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4971         New functions.
4972         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4973         Handle "vX" aliases.
4974         (v_alias_pseudo_register_collect): New function.
4975         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4976         (rs6000_gdbarch_init): Initialize "vX" aliases as
4977         pseudo-registers.  Restore registration of
4978         rs6000_pseudo_register_reggroup_p with
4979         set_tdesc_pseudo_register_reggroup_p.
4980
4981 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4982
4983         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4984         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4985         set_gdbarch_num_pseudo_regs.
4986
4987 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4988
4989         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4990         Remove arg prefixname, add do_set and do_show.
4991         Add member functions set_list and show_list.
4992         * cli/cli-style.c (class cli_style_option): Update accordingly.
4993         (style_set_list): Move to file scope.
4994         (style_show_list): Likewise.
4995         (set_style): Call help_list.
4996         (show_style): Call cmd_show_list.
4997         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4998         Update to use the new macro.
4999
5000 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5001
5002         * ada-lang.c (_initialize_ada_language): Expand the help text
5003         for the "catch exception" command.
5004
5005 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5006
5007         * symtab.c (matching_obj_sections): Initialize obj,
5008         declare it closer to its usage.
5009
5010 2019-01-10  Tom Tromey  <tom@tromey.com>
5011
5012         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5013         (basic_inf_threads_range): Remove.
5014         (inf_threads_range, inf_non_exited_threads_range)
5015         (safe_inf_threads_range): Use next_adapter.
5016
5017 2019-01-10  Keith Seitz  <keiths@redhat.com>
5018
5019         PR gdb/23712
5020         PR symtab/23010
5021         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5022         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5023
5024 2019-01-10  Keith Seitz  <keiths@redhat.com>
5025
5026         PR gdb/23712
5027         PR symtab/23010
5028         * dictionary.c (pending_to_vector): Remove.
5029         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5030         Remove _1 suffix, replacing functions of the same name.  Update
5031         all callers.
5032         (dict_create_hashed, dict_create_hashed_expandable)
5033         (dict_create_linear, dict_create_linear_expandable, dict_free)
5034         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5035         Make functions static.
5036
5037 2019-01-10  Keith Seitz  <keiths@redhat.com>
5038
5039         PR gdb/23712
5040         PR symtab/23010
5041         * dictionary.h (struct dictionary): Replace declaration with
5042         multidictionary.
5043         (dict_create_hashed, dict_create_hashed_expandable)
5044         (dict_create_linear, dict_create_linear_expandable)
5045         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5046         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5047         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5048         taking multidictionary argument.
5049         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5050         * block.h (struct block) <dict>: Change to multidictionary
5051         and rename `multidict'.
5052         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5053         symmisc.c: Update all dictionary references to multidictionary.
5054
5055 2019-01-10  Keith Seitz  <keiths@redhat.com>
5056
5057         PR gdb/23712
5058         PR symtab/23010
5059         * dictionary.c: Include unordered_map.
5060         (pending_to_vector): New function.
5061         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5062         Rewrite the non-"_1" functions to take vector instead
5063         of linked list.
5064         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5065         "new" _1 versions of the same name.
5066         (multidictionary): Define.
5067         (std::hash<enum language): New definition.
5068         (collate_pending_symbols_by_language, mdict_create_hashed)
5069         (mdict_create_hashed_expandable, mdict_create_linear)
5070         (mdict_create_linear_expandable, mdict_free)
5071         (find_language_dictionary, create_new_language_dictionary)
5072         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5073         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5074         (mdict_size, mdict_empty): New functions.
5075         * dictionary.h (mdict_iterator): Define.
5076
5077 2019-01-10  Pedro Alves  <palves@redhat.com>
5078
5079         * breakpoint.c (read_uploaded_action)
5080         (create_tracepoint_from_upload): Adjust to use
5081         gdb::unique_xmalloc_ptr.
5082         * ctf.c (ctf_write_uploaded_tp):
5083         (SET_ARRAY_FIELD): Use emplace_back.
5084         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5085         * tracefile-tfile.c (tfile_write_uploaded_tp):
5086         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5087         gdb::unique_xmalloc_ptr.
5088         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5089         at_string, cond_string, cmd_strings>: Replace char pointers
5090         with gdb::unique_xmalloc_ptr.
5091
5092 2019-01-10  Pedro Alves  <palves@redhat.com>
5093
5094         * solib-target.c (library_list_start_library): Don't xstrdup name.
5095
5096 2019-01-10  Pedro Alves  <palves@redhat.com>
5097
5098         * mdebugread.c (parse_partial_symbols): Use
5099         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5100
5101 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5102
5103         * linux-fork.c (scoped_switch_fork_info)
5104         <~scoped_switch_fork_info>: Fix incorrect variable name.
5105
5106 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5107
5108         * linux-fork.c (scoped_switch_fork_info)
5109         <scoped_switch_fork_info>: Make explicit.
5110         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5111
5112 2019-01-10  Tom Tromey  <tom@tromey.com>
5113
5114         * objfiles.h (objfile::reset_psymtabs): Update.
5115         * objfiles.c (objfile::objfile): Update.
5116         * psymtab.h (psymtab_storage::obstack): Update.
5117         (psymtab_storage::m_obstack): Use gdb::optional.
5118         (class psymtab_storage): Update comment.  Remove objfile
5119         parameter.
5120         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5121
5122 2019-01-10  Tom Tromey  <tom@tromey.com>
5123
5124         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5125         <free_psymtabs>: Now private.
5126         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5127         (allocate_psymtab): Use new method.
5128
5129 2019-01-10  Tom Tromey  <tom@tromey.com>
5130
5131         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5132         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5133         * mdebugread.c (parse_partial_symbols): Use
5134         allocate_dependencies.
5135         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5136         allocate_dependencies.
5137         (process_psymtab_comp_unit_reader)
5138         (build_type_psymtab_dependencies): Likewise.
5139         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5140
5141 2019-01-10  Tom Tromey  <tom@tromey.com>
5142
5143         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5144         PSYMBOL_SET_LANGUAGE.
5145         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5146
5147 2019-01-10  Tom Tromey  <tom@tromey.com>
5148
5149         * psymtab.h (psymtab_storage::obstack): New method.
5150         <m_obstack>: Rename from obstack; now private.
5151         * psymtab.c (psymtab_storage): Update.
5152         * dwarf2read.c (create_addrmap_from_index)
5153         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5154         Update.
5155
5156 2019-01-10  Tom Tromey  <tom@tromey.com>
5157
5158         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5159         * objfiles.h (objfile::reset_psymtabs): New method.
5160
5161 2019-01-10  Tom Tromey  <tom@tromey.com>
5162
5163         * symmisc.c (print_symbol_bcache_statistics): Update.
5164         (print_objfile_statistics): Update.
5165         * symfile.c (reread_symbols): Update.
5166         * psymtab.h (class psymtab_storage): New.
5167         * psymtab.c (psymtab_storage): New constructor.
5168         (~psymtab_storage): New destructor.
5169         (require_partial_symbols): Update.
5170         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5171         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5172         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5173         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5174         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5175         (start_psymtab_common, end_psymtab_common)
5176         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5177         (allocate_psymtab): Update.
5178         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5179         Update.
5180         (dump_psymtab_addrmap, maintenance_print_psymbols)
5181         (maintenance_check_psymtabs): Update.
5182         (class objfile_psymtabs): Move to objfiles.h.
5183         * psympriv.h (discard_psymtab): Now inline.
5184         (psymtab_discarder::psymtab_discarder): Update.
5185         (psymtab_discarder::~psymtab_discarder): Update.
5186         (ALL_OBJFILE_PSYMTABS): Rewrite.
5187         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5188         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5189         Remove fields.
5190         <partial_symtabs>: New field.
5191         (class objfile_psymtabs): Move from psymtab.h.  Update.
5192         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5193         psymbol_cache.
5194         (objfile::~objfile): Don't destroy psymbol_cache.
5195         * mdebugread.c (parse_partial_symbols): Update.
5196         * dwarf2read.c (create_addrmap_from_index)
5197         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5198         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5199         (add_partial_subprogram, dwarf2_ranges_read): Update.
5200         * dwarf-index-write.c (write_address_map)
5201         (write_one_signatured_type, recursively_write_psymbols)
5202         (class debug_names, class debug_names, write_psymtabs_to_index):
5203         Update.
5204
5205 2019-01-10  Tom Tromey  <tom@tromey.com>
5206
5207         * symtab.h (SYMBOL_SET_NAMES): Update.
5208         (symbol_set_names): Update.
5209         (MSYMBOL_SET_NAMES): Update.
5210         * symtab.c (symbol_set_names): Change argument to be an
5211         objfile_per_bfd_storage.
5212         * psymtab.c (add_psymbol_to_bcache): Update.
5213         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5214
5215 2019-01-10  Tom Tromey  <tom@tromey.com>
5216
5217         * symtab.c (create_demangled_names_hash): Change argument to be an
5218         objfile_per_bfd_storage.
5219         (symbol_set_names): Update.
5220
5221 2019-01-10  Tom Tromey  <tom@tromey.com>
5222
5223         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5224         init_psymbol_list.
5225         * psymtab.c (init_psymbol_list): Do nothing if already called.
5226         * psympriv.h (init_psymbol_list): Add comment.
5227         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5228         init_psymbol_list.
5229         * dbxread.c (dbx_symfile_read): Unconditionally call
5230         init_psymbol_list.
5231
5232 2019-01-10  Tom Tromey  <tom@tromey.com>
5233
5234         * xcoffread.c (scan_xcoff_symtab): Update.
5235         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5236         "where".
5237         * mdebugread.c (parse_partial_symbols)
5238         (handle_psymbol_enumerators): Update.
5239         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5240         * dbxread.c (read_dbx_symtab): Update.
5241         * psympriv.h (psymbol_placement): New enum.
5242         (add_psymbol_to_list): Update.
5243
5244 2019-01-10  Tom Tromey  <tom@tromey.com>
5245
5246         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5247         static_psymbols parameters.
5248         (scan_xcoff_symtab): Update.
5249         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5250         static_psymbols parameters.
5251         * psympriv.h (start_psymtab_common): Update.
5252         * mdebugread.c (parse_partial_symbols): Update.
5253         * dwarf2read.c (create_partial_symtab): Update.
5254         * dbxread.c (read_dbx_symtab): Update.
5255         (start_psymtab): Remove global_psymbols and static_psymbols
5256         parameters.
5257
5258 2019-01-10  Tom Tromey  <tom@tromey.com>
5259
5260         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5261         * psymtab.c (allocate_psymtab): Add comment.
5262         * psympriv.h (allocate_psymtab): Add comment.
5263         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5264         initializations.
5265         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5266
5267 2019-01-10  Tom Tromey  <tom@tromey.com>
5268
5269         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5270         Don't declare.
5271         * mipsread.c: Include mdebugread.h.
5272         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5273         Declare.
5274         * elfread.c: Include mdebugread.h.
5275
5276 2019-01-09  Tom Tromey  <tom@tromey.com>
5277
5278         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5279         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5280         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5281         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5282         (psym_lookup_symbol, psym_find_last_source_symtab)
5283         (psym_forget_cached_source_info, psym_print_stats)
5284         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5285         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5286         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5287         (psym_find_compunit_symtab_by_address)
5288         (maintenance_print_psymbols, maintenance_info_psymtabs)
5289         (maintenance_check_psymtabs): Use ranged for.
5290         * psymtab.h (class objfile_psymtabs): New.
5291         (require_partial_symbols): Return objfile_psymtabs.
5292         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5293
5294 2019-01-09  Tom Tromey  <tom@tromey.com>
5295
5296         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5297         (find_pc_mapped_section, list_overlays_command)
5298         (map_overlay_command, unmap_overlay_command)
5299         (simple_overlay_update): Use all_objfiles.
5300         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5301         * printcmd.c (info_symbol_command): Use all_objfiles.
5302         * objfiles.h (ALL_OBJSECTIONS): Remove.
5303         * maint.c (maintenance_translate_address): Use all_objfiles.
5304         * gcore.c (gcore_create_callback): Use all_objfiles.
5305         (objfile_find_memory_regions): Likewise.
5306
5307 2019-01-09  Tom Tromey  <tom@tromey.com>
5308
5309         * symtab.c (find_line_symtab, info_sources_command)
5310         (make_source_files_completion_list): Use objfile_compunits.
5311         * source.c (select_source_symtab): Use objfile_compunits.
5312         * objfiles.h (struct objfile): Update comment.
5313         (ALL_OBJFILES): Remove.
5314         (ALL_FILETABS): Remove.
5315         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5316         objfile_compunits.
5317
5318 2019-01-09  Tom Tromey  <tom@tromey.com>
5319
5320         * symmisc.c (print_objfile_statistics, dump_objfile)
5321         (maintenance_print_symbols): Use compunit_filetabs.
5322         * source.c (forget_cached_source_info_for_objfile): Use
5323         compunit_filetabs.
5324         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5325         (ALL_FILETABS): Use compunit_filetabs.
5326         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5327         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5328
5329 2019-01-09  Tom Tromey  <tom@tromey.com>
5330
5331         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5332         (compunit_filetabs): New.
5333         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5334         compunit_filetabs.
5335         (info_sources_command, make_source_files_completion_list): Remove
5336         declaration.
5337         * symmisc.c (print_objfile_statistics, dump_objfile)
5338         (maintenance_print_symbols): Remove declaration.
5339         (maintenance_info_symtabs): Use compunit_filetabs.
5340         (maintenance_info_line_tables): Likewise.
5341         * source.c (select_source_symtab): Change local variable name.
5342         (forget_cached_source_info_for_objfile): Remove declaration.
5343         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5344         * objfiles.c (objfile_relocate1): Remove declaration.
5345         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5346         declaration.
5347         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5348         * coffread.c (coff_symtab_read): Remove declaration.
5349         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5350         compunit_filetabs.
5351
5352 2019-01-09  Tom Tromey  <tom@tromey.com>
5353
5354         * symtab.c (lookup_objfile_from_block)
5355         (find_pc_sect_compunit_symtab, search_symbols)
5356         (default_collect_symbol_completion_matches_break_on): Use
5357         objfile_compunits.
5358         * objfiles.h (ALL_COMPUNITS): Remove.
5359         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5360         * cp-support.c (add_symbol_overload_list_qualified): Use
5361         objfile_compunits.
5362         * ada-lang.c (ada_collect_symbol_completion_matches)
5363         (ada_add_global_exceptions): Use objfile_compunits.
5364
5365 2019-01-09  Tom Tromey  <tom@tromey.com>
5366
5367         * source.c (select_source_symtab)
5368         (forget_cached_source_info_for_objfile): Remove declaration.
5369         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5370         declaration.
5371         * maint.c (count_symtabs_and_blocks): Remove declaration.
5372         * cp-support.c (add_symbol_overload_list_qualified): Remove
5373         declaration.
5374         * coffread.c (coff_symtab_read): Remove declaration.
5375         * symtab.c (lookup_symbol_in_objfile_symtabs)
5376         (basic_lookup_transparent_type_1): Use objfile_compunits.
5377         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5378         (info_sources_command, search_symbols)
5379         (default_collect_symbol_completion_matches_break_on)
5380         (make_source_files_completion_list): Remove declaration.
5381         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5382         (ada_collect_symbol_completion_matches)
5383         (ada_add_global_exceptions): Remove declaration.
5384         * linespec.c (iterate_over_all_matching_symtabs): Use
5385         objfile_compunits.
5386         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5387         (class objfile_compunits): New.
5388         (ALL_COMPUNITS): Use objfile_compunits.
5389         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5390         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5391         objfile_compunits.
5392         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5393
5394 2019-01-09  Tom Tromey  <tom@tromey.com>
5395
5396         * symtab.c (search_symbols)
5397         (default_collect_symbol_completion_matches_break_on): Use
5398         objfile_msymbols.
5399         * ada-lang.c (ada_lookup_simple_minsym)
5400         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5401         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5402         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5403         objfile_msymbols.
5404         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5405         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5406         * objc-lang.c (find_methods): Use objfile_msymbols.
5407         (info_selectors_command, info_classes_command): Likewise.
5408         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5409         * objfiles.h (class objfile_msymbols): New.
5410         (ALL_OBJFILE_MSYMBOLS): Remove.
5411         (ALL_MSYMBOLS): Remove.
5412
5413 2019-01-09  Tom Tromey  <tom@tromey.com>
5414
5415         * common/next-iterator.h (next_adapter): Add Iterator template
5416         parameter.
5417         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5418         (class all_objfiles_safe): New.
5419         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5420         * objfiles.c (put_objfile_before): Update comment.
5421         (add_separate_debug_objfile): Likewise.
5422         (free_all_objfiles): Use all_objfiles_safe.
5423         (objfile_purge_solibs): Likewise.
5424
5425 2019-01-09  Tom Tromey  <tom@tromey.com>
5426
5427         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5428         (expand_symtab_containing_pc, lookup_static_symbol)
5429         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5430         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5431         all_objfiles.
5432         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5433         * breakpoint.c (create_overlay_event_breakpoint)
5434         (create_longjmp_master_breakpoint)
5435         (create_std_terminate_master_breakpoint)
5436         (create_exception_master_breakpoint): Use all_objfiles.
5437         * linux-thread-db.c (try_thread_db_load_from_pdir)
5438         (has_libpthread): Use all_objfiles.
5439         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5440         * linespec.c (iterate_over_all_matching_symtabs)
5441         (search_minsyms_for_name): Use all_objfiles.
5442         * maint.c (maintenance_info_sections): Use all_objfiles.
5443         * main.c (captured_main_1): Use all_objfiles.
5444         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5445         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5446         * guile/scm-pretty-print.c
5447         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5448         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5449         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5450         (maintenance_print_msymbols): Use all_objfiles.
5451         * source.c (select_source_symtab): Use all_objfiles.
5452         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5453         * symfile.c (remove_symbol_file_command)
5454         (expand_symtabs_matching, map_symbol_filenames): Use
5455         all_objfiles.
5456         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5457         all_objfiles.
5458         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5459         * objc-lang.c (find_methods): Use all_objfiles.
5460         * objfiles.c (have_partial_symbols, have_full_symbols)
5461         (have_minimal_symbols, qsort_cmp)
5462         (default_iterate_over_objfiles_in_search_order): Use
5463         all_objfiles.
5464         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5465         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5466         (maintenance_check_psymtabs): Use all_objfiles.
5467         (ALL_PSYMTABS): Remove.
5468         * compile/compile-object-run.c (do_module_cleanup): Use
5469         all_objfiles.
5470         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5471         * cp-support.c (add_symbol_overload_list_qualified): Use
5472         all_objfiles.
5473         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5474         Use all_objfiles.
5475         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5476         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5477         all_objfiles.
5478         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5479         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5480         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5481         Uses all_objfiles.
5482         * solib.c (solib_read_symbols): Use all_objfiles
5483
5484 2019-01-09  Tom Tromey  <tom@tromey.com>
5485
5486         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5487         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5488         all_objfiles.
5489         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5490         * symmisc.c (print_symbol_bcache_statistics)
5491         (print_objfile_statistics, maintenance_print_objfiles)
5492         (maintenance_info_symtabs, maintenance_check_symtabs)
5493         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5494         all_objfiles.
5495         * source.c (forget_cached_source_info): Use all_objfiles.
5496         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5497         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5498         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5499         * objfiles.c (update_section_map): Use all_objfiles.
5500         (shared_objfile_contains_address_p): Likewise.
5501         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5502         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5503
5504 2019-01-09  Tom Tromey  <tom@tromey.com>
5505
5506         * common/next-iterator.h: New file.
5507         * objfiles.h (class all_objfiles): New.
5508         (struct objfile_iterator): New.
5509
5510 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5511
5512         * NEWS: Move the description of the changed "frame", "select-frame",
5513          and "info frame" commands to the Changed commands section.
5514
5515 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5516
5517         * gdbtypes.c (check_stub_method_group): Remove handling of old
5518         mangling schemes.
5519         * linespec.c (find_methods): Likewise.
5520         * stabsread.c (read_member_functions): Likewise.
5521         * valops.c (search_struct_method): Likewise.
5522         (value_struct_elt_for_reference): Likewise.
5523         * NEWS: Mention this change.
5524
5525 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5526
5527         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5528         print_source_lines.
5529         * source.c (print_source_lines_base): Update line number check.
5530         (print_source_lines): New function.
5531         (source_lines_range::source_lines_range): New function.
5532         * source.h (class source_lines_range): New class.
5533         (print_source_lines): New declaration.
5534
5535 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5536
5537         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5538
5539 2019-01-08  Tom Tromey  <tom@tromey.com>
5540             Simon Marchi  <simon.marchi@ericsson.com>
5541
5542         PR gdb/24060
5543         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5544         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5545         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5546         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5547         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5548         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5549
5550 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5551
5552         * source.c (select_source_symtab): Move header comment to
5553         declaration in source.h.
5554         (forget_cached_source_info_for_objfile): Likewise.
5555         (forget_cached_source_info): Likewise.
5556         (identify_source_line): Likewise.
5557         * source.h (identify_source_line): Move declaration from symtab.h
5558         and add comment from source.c
5559         (print_source_lines): Likewise.
5560         (forget_cached_source_info_for_objfile): Likewise.
5561         (forget_cached_source_info): Likewise.
5562         (select_source_symtab): Likewise.
5563         (enum print_source_lines_flag): Move definition from symtab.h.
5564         * symtab.h (identify_source_line): Move declaration to source.h.
5565         (print_source_lines): Likewise.
5566         (forget_cached_source_info_for_objfile): Likewise.
5567         (forget_cached_source_info): Likewise.
5568         (select_source_symtab): Likewise.
5569         (enum print_source_lines_flag): Move definition to source.h.
5570         * tui/tui-hooks.c: Add 'source.h' include.
5571
5572 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5573
5574         * source.c (print_source_lines_base): Handle requests to print
5575         reverse line number sequences, and guard against empty lines
5576         string.
5577
5578 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5579
5580         * source.c (print_source_lines_base): Fix skip of '\r' if next
5581         character is '\n'.
5582
5583 2019-01-06  Tom Tromey  <tom@tromey.com>
5584
5585         * c-exp.y (struct c_parse_state) <macro_original_text,
5586         expansion_obstack>: New member.
5587         (macro_original_text, expansion_obstack): Remove globals.
5588         (scan_macro_expansion, scanning_macro_expansion)
5589         (finished_macro_expansion): Update.
5590         (scan_macro_cleanup): Remove.
5591         (yylex, c_parse): Update.
5592
5593 2019-01-06  Tom Tromey  <tom@tromey.com>
5594
5595         * c-exp.y (struct c_parse_state) <strings>: New member.
5596         (operator_stoken): Update.
5597
5598 2019-01-06  Tom Tromey  <tom@tromey.com>
5599
5600         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5601         (union type_stack_elt) <typelist_val>: Now a pointer to
5602         std::vector.
5603         (type_stack_cleanup): Don't declare.
5604         (push_typelist): Update.
5605         * parse.c (pop_typelist): Return a std::vector.
5606         (push_typelist): Take a std::vector.
5607         (follow_types): Update.  Do not free args.
5608         (type_stack_cleanup): Remove.
5609         * c-exp.y (struct c_parse_state): New.
5610         (cpstate): New global.
5611         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5612         (nonempty_typelist): Update.
5613         (func_mod): Create a new vector.
5614         (c_parse): Create a c_parse_state.
5615         (check_parameter_typelist): Do not delete params.
5616         (function_method): Update.  Do not delete type_list.
5617
5618 2019-01-06  Tom Tromey  <tom@tromey.com>
5619
5620         PR gdb/28155:
5621         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5622         check_typedef.
5623         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5624         (print_return_value): Likewise.
5625
5626 2019-01-05  Tom Tromey  <tom@tromey.com>
5627
5628         * contrib/cleanup_check.py: Remove.
5629         * contrib/gcc-with-excheck: Remove.
5630         * contrib/exsummary.py: Remove.
5631         * contrib/excheck.py: Remove.
5632
5633 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5634
5635         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5636         NULL. Initialize tpprev to NULL instead of assigning it
5637         to NULL on the next statement.
5638         * windows-nat.c (windows_delete_thread): Remove check for
5639         main_thread_id before printing thread exit notifications.
5640         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5641         Remove thread ID check against main_thread_id.
5642         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5643         windows_delete_thread.
5644         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5645
5646 2019-01-04  Tom Tromey  <tom@tromey.com>
5647
5648         * compile/compile.c (_initialize_compile): Use upper case for
5649         metasyntactic variables.
5650         * symmisc.c (_initialize_symmisc): Use upper case for
5651         metasyntactic variables.
5652         * psymtab.c (_initialize_psymtab): Use upper case for
5653         metasyntactic variables.
5654         * demangle.c (demangle_command): Use upper case for metasyntactic
5655         variables.
5656         (_initialize_demangler): Likewise.
5657         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5658         variables.
5659
5660 2019-01-03  Tom Tromey  <tom@tromey.com>
5661
5662         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5663
5664 2019-01-03  Tom Tromey  <tom@tromey.com>
5665
5666         * python/py-symtab.c (salpy_str): Update.
5667         (struct salpy_sal_object) <symtab>: Now a PyObject.
5668         (salpy_dealloc): Update.
5669         (del_objfile_sal): Use gdbpy_ref.
5670
5671 2019-01-03  Tom Tromey  <tom@tromey.com>
5672
5673         * python/py-type.c (convert_field): Use new_reference.  Return
5674         gdbpy_ref.
5675         (make_fielditem): Return gdbpy_ref.
5676         (typy_fields): Update.
5677         (typy_getitem): Update.
5678         (field_name): Return gdbpy_ref.  Use new_reference.
5679         (typy_iterator_iternext): Update.
5680
5681 2019-01-03  Tom Tromey  <tom@tromey.com>
5682
5683         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5684
5685 2019-01-03  Tom Tromey  <tom@tromey.com>
5686
5687         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5688         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5689         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5690         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5691         (pspy_set_type_printers): Likewise.
5692         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5693         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5694         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5695         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5696         (objfpy_set_type_printers): Likewise.
5697
5698 2019-01-03  Tom Tromey  <tom@tromey.com>
5699
5700         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5701         (gdbpy_print_stack): Use gdbpy_err_fetch.
5702         * python/python-internal.h (class gdbpy_err_fetch): New class.
5703         (class gdbpy_enter) <m_error_type, m_error_value,
5704         m_error_traceback>: Remove.
5705         <m_error>: New member.
5706         (gdbpy_exception_to_string): Don't declare.
5707         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5708         * python/py-value.c (convert_value_from_python): Use
5709         gdbpy_err_fetch.
5710         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5711         gdbpy_exception_to_string.
5712         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5713         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5714         gdbpy_err_fetch.
5715
5716 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5717
5718         * linux-nat.c (delete_lwp_cleanup): Delete.
5719         (struct lwp_deleter): New struct.
5720         (lwp_info_up): New typedef.
5721         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5722         lwp_info_up.
5723
5724 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5725
5726         * linux-fork.c (class scoped_switch_fork_info): New class.
5727         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5728
5729 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5730
5731         * valops.c (find_overload_match): Remove use of null_cleanup, and
5732         calls to do_cleanups.
5733
5734 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5735
5736         * compile/compile-cplus-types.c
5737         (compile_cplus_instance::decl_name): Handle changes to
5738         cp_func_name.
5739         * cp-support.c (cp_func_name): Update header comment, update
5740         return type.
5741         * cp-support.h (cp_func_name): Update return type in declaration.
5742         * valops.c (find_overload_match): Move temp_func local to top
5743         level of function and change its type.  Use temp_func to hold and
5744         delete temporary string obtained from cp_func_name.
5745
5746 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5747
5748         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5749         gdb::char_vector, remove cleanup, and update uses of `msg`.
5750
5751 2019-01-03  Jim Wilson  <jimw@sifive.com>
5752
5753         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5754
5755 2019-01-02  Tom Tromey  <tom@tromey.com>
5756
5757         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5758         (tdesc_parse_xml): Remove cleanups.
5759         * target-descriptions.h (make_cleanup_free_target_description):
5760         Don't declare.
5761         (target_desc_deleter): New struct.
5762         (target_desc_up): New typedef.
5763         * target-descriptions.c (target_desc_deleter::operator()): Rename
5764         from free_target_description.
5765         (make_cleanup_free_target_description): Remove.
5766
5767 2019-01-02  Tom Tromey  <tom@tromey.com>
5768
5769         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5770         constructor, destructor.
5771         (linespec_parser): Remove typedef.
5772         (~linespec_parser): Rename from linespec_parser_delete.
5773         (linespec_lex_to_end, linespec_complete_label)
5774         (linespec_complete): Update.
5775         (decode_line_full): Remove cleanups.
5776         (decode_line_1): Update.
5777
5778 2019-01-02  Tom Tromey  <tom@tromey.com>
5779
5780         * python/python-internal.h (inferior_to_inferior_object): Change
5781         return type.
5782         * python/py-exitedevent.c (create_exited_event_object): Update.
5783         * python/py-inferior.c (inferior_to_inferior_object): Return
5784         gdbpy_ref.
5785         (python_new_inferior, python_inferior_deleted)
5786         (thread_to_thread_object, delete_thread_object)
5787         (build_inferior_list, gdbpy_selected_inferior): Update.
5788         * python/py-infthread.c (create_thread_object): Update.  Also fail
5789         if inferior_to_inferior_object fails.
5790
5791 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5792
5793         * inferior.h (class inferior) <displaced_step_state>: New field.
5794         * infrun.h (struct displaced_step_state): Move here from
5795         infrun.c.  Initialize fields, add constructor.
5796         <inf>: Remove field.
5797         <reset>: New method.
5798         * infrun.c (struct displaced_step_inferior_state): Move to
5799         infrun.h.
5800         (displaced_step_inferior_states): Remove.
5801         (get_displaced_stepping_state): Adust.
5802         (displaced_step_in_progress_any_inferior): Adjust.
5803         (displaced_step_in_progress_thread): Adjust.
5804         (displaced_step_in_progress): Adjust.
5805         (add_displaced_stepping_state): Remove.
5806         (get_displaced_step_closure_by_addr): Adjust.
5807         (remove_displaced_stepping_state): Remove.
5808         (infrun_inferior_exit): Call displaced_step_state.reset.
5809         (use_displaced_stepping): Don't check for NULL.
5810         (displaced_step_prepare_throw): Call
5811         get_displaced_stepping_state.
5812         (displaced_step_fixup): Don't check for NULL.
5813         (prepare_for_detach): Don't check for NULL.
5814
5815 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5816
5817         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5818          in case of call that did not complete.
5819
5820 2019-01-02  Andrey Utkin  <autkin@undo.io>
5821
5822         * symfile.c (find_separate_debug_file): Fix search of debug files for
5823         remote debuggee.
5824
5825 2019-01-02  Tom Tromey  <tom@tromey.com>
5826
5827         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5828         indentation.
5829         * python/py-frame.c (frapy_older): Remove cast.
5830         (frapy_newer): Likewise.
5831         * python/py-breakpoint.c (local_setattro): Remove cast.
5832         * python/py-arch.c (archpy_name): Remove local variable.
5833         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5834
5835 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5836
5837         * unittests/basic_string_view/element_access/char/empty.cc:
5838         Fix year range in copyright header.
5839
5840 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5841
5842         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5843         Delete.
5844         <operator==>: Update with for removed field.
5845         <hash>: Likewise.
5846         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5847         <isa_features>: ...this.
5848         <abi_features>: New field.
5849         (riscv_isa_flen): Update comment.
5850         (riscv_abi_xlen): New declaration.
5851         (riscv_abi_flen): New declaration.
5852         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5853         isa_features.
5854         (riscv_abi_xlen): New function.
5855         (riscv_isa_flen): Update to get answer from isa_features.
5856         (riscv_abi_flen): New function.
5857         (riscv_has_fp_abi): Update to get answer from abi_features.
5858         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5859         xlen and flen.
5860         (riscv_call_info) <xlen, flen>: Update comment.
5861         (riscv_call_arg_struct): Remove invalid assertions
5862         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5863         is removed.
5864         (riscv_gdbarch_init): Gather isa features and abi features
5865         separately, ensure both match on the gdbarch when reusing an old
5866         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5867         a target with 64-bit float hardware.
5868
5869 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5870
5871         * source.c (search_command_helper): Stop reverse search
5872         when line 1 has been searched.
5873
5874 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5875
5876         * record-full.c (record_full_base_target::close): Rewrite
5877         record_full_core_buf_list free logic.
5878
5879 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5880
5881         * break-catch-syscall.c (print_one_catch_syscall): xfree
5882         the last text.
5883
5884 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5885
5886         * top.c (print_gdb_version): Update Copyright year in version
5887         message.
5888
5889 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5890
5891         Update copyright year range in all GDB files.
5892
5893 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5894
5895         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5896
5897 For older changes see ChangeLog-2018.
5898 \f
5899 Local Variables:
5900 mode: change-log
5901 left-margin: 8
5902 fill-column: 74
5903 version-control: never
5904 coding: utf-8
5905 End:
5906