gdb/ChangeLog

   1 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
   2
   3         * fbsd-nat.c: Include gdbarch.h.
   4
   5 2019-07-15  Tom Tromey  <tromey@adacore.com>
   6
   7         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
   8
   9 2019-07-15  Tom Tromey  <tromey@adacore.com>
  10
  11         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
  12         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
  13         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
  14         * cli-out.c (cli_ui_out::do_field_int): New method.
  15         * ui-out.c (ui_out::field_unsigned): New method.
  16         * symfile.c (generic_load): Use field_unsigned.
  17         (print_transfer_performance): Likewise.
  18         * record-btrace.c (ui_out_field_uint): Remove.
  19         (btrace_call_history_insn_range, btrace_call_history): Use
  20         field_unsigned.
  21         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
  22         field_unsigned.
  23         * ui-out.h (class ui_out) <field_unsigned>: New method.
  24         <do_field_unsigned>: Likewise.
  25
  26 2019-07-15  Tom Tromey  <tromey@adacore.com>
  27
  28         * mi/mi-main.c (list_available_thread_groups): Use field_string.
  29         * mi/mi-interp.c (mi_memory_changed): Use field_string.
  30         * target.c (flash_erase_command): Use field_string.
  31         * infrun.c (print_signal_received_reason): Use field_string.
  32         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
  33         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
  34         field_string.
  35         * ada-tasks.c (print_ada_task_info): Use field_string.
  36
  37 2019-07-15  Tom Tromey  <tromey@adacore.com>
  38
  39         * target.c (flash_erase_command): Use field_core_addr.
  40         * symfile.c (generic_load): Use field_core_addr.
  41         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
  42         Use field_core_addr.
  43         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
  44         field_core_addr.
  45
  46 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  47
  48         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
  49         value if its desired type is smaller than a CORE_ADDR and signed.
  50
  51 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  52
  53         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
  54         of changes to field names, and use new is_reference field to
  55         decide if a property is a reference or not.
  56         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
  57         field.
  58         (struct dwarf2_property_baton): Update header comment, rename
  59         'referenced_type' to 'property_type' and update comments.
  60         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
  61         default property type, store in property baton, update to take
  62         accound of renamed field.
  63         (read_func_scope): Update call to attr_to_dynamic_prop.
  64         (read_array_type): Likewise.
  65         (dwarf2_per_cu_addr_sized_int_type): New function.
  66         (read_subrange_index_type): Move type finding code to
  67         dwarf2_per_cu_addr_sized_int_type.
  68         (read_subrange_type): Update calls to attr_to_dynamic_prop.
  69         (dwarf2_per_cu_addr_type): New function.
  70         (set_die_type): Update calls to attr_to_dynamic_prop.
  71
  72 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  73
  74         * dwarf2read.c (read_subrange_index_type): New function.
  75         (read_subrange_type): Move code into new function and call it.
  76         * gdbtypes.c (create_range_type): Add some asserts.
  77
  78 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  79
  80         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
  81         update return statements.
  82         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
  83         declaration, and update comment to match.
  84         * gdbtypes.c (resolve_dynamic_array): Update call to
  85         dwarf2_evaluate_property to match new return type.
  86
  87 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  88
  89         * valarith.c (value_subscripted_rvalue): Change lowerbound
  90         parameter type from int to LONGEST.
  91         * value.h (value_subscripted_rvalue): Likewise in declaration.
  92
  93 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  94
  95         * cli/cli-utils.c (info_print_command_completer): New function.
  96         * cli/cli-utils.h: Add 'completer.h' include, and forward
  97         declaration for 'struct cmd_list_element'.
  98         (info_print_command_completer): Declare.
  99         * stack.c (_initialize_stack): Add completer for 'info locals' and
 100         'info args'.
 101         * symtab.c (_initialize_symtab): Add completer for 'info
 102         variables' and 'info functions'.
 103         * NEWS: Mention completion for additional info commands.
 104
 105 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 106
 107         * cli/cli-utils.c (extract_info_print_args): Delete.
 108         (extract_arg_maybe_quoted): Delete.
 109         (info_print_options_defs): New variable.
 110         (make_info_print_options_def_group): New function.
 111         (extract_info_print_options): Define new function.
 112         * cli/cli-utils.h (extract_info_print_args): Delete.
 113         (struct info_print_options): New structure.
 114         (extract_info_print_options): Declare new function.
 115         * stack.c (info_locals_command): Update to use new
 116         extract_info_print_options, also add a header comment.
 117         (info_args_command): Likewise.
 118         * symtab.c (info_variables_command): Likewise.
 119         (info_functions_command): Likewise.
 120
 121 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 122
 123         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 124         to extract string arguments.
 125         * common/common-utils.c (extract_string_maybe_quoted): New function.
 126         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 127
 128 2019-07-11  Tom Tromey  <tromey@adacore.com>
 129
 130         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 131         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 132         * top.h (gdbinit): Don't declare.
 133         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 134         into...
 135         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 136         * top.c (gdb_init): Don't call init_cli_cmds.
 137         (gdbinit): Remove.
 138         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 139
 140 2019-07-11  Tom Tromey  <tromey@adacore.com>
 141
 142         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 143         after it has been moved.
 144
 145 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 146
 147         * valops.c (value_must_coerce_to_target): Change return type to
 148         bool.
 149         * value.h (value_must_coerce_to_target): Likewise.
 150
 151 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 152
 153         * breakpoint.c (is_hardware_watchpoint): Remove
 154         forward-declaration.
 155         (is_masked_watchpoint): Change return type to bool.
 156         (is_tracepoint): Likewise.
 157         (is_breakpoint): Likewise.
 158         (is_hardware_watchpoint): Likewise.
 159         (is_watchpoint): Likewise.
 160         (is_no_memory_software_watchpoint): Likewise.
 161         (is_catchpoint): Likewise.
 162         (breakpoint_1): Make FILTER parameter's return type bool.
 163         is_masked_watchpoint): Change return type to bool.
 164         (save_breakpoints): Make FILTER parameter's return type bool.
 165         * breakpoint.h (is_breakpoint): Change return type to bool.
 166         (is_watchpoint): Likewise.
 167         (is_catchpoint): Likewise.
 168         (is_tracepoint): Likewise.
 169
 170 2019-07-10  Tom Tromey  <tom@tromey.com>
 171
 172         * defs.h: Don't include gdbarch.h.
 173         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 174         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 175         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 176         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 177         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 178         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 179         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 180         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 181         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 182         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 183         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 184         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 185         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 186         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 187         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 188         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 189         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 190         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 191         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 192         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 193         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 194         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 195         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 196         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 197         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 198         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 199         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 200
 201 2019-07-10  Tom Tromey  <tromey@adacore.com>
 202
 203         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 204         * breakpoint.c (init_ada_exception_breakpoint): Register as
 205         bp_catchpoint.
 206         (print_one_breakpoint_location, print_one_breakpoint): Use
 207         is_ada_exception_catchpoint.
 208         * ada-lang.c (class ada_catchpoint_location): Pass
 209         bp_loc_software_breakpoint to bp_location constructor.
 210         (is_ada_exception_catchpoint): New function.
 211
 212 2019-07-10  Tom Tromey  <tromey@adacore.com>
 213
 214         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 215         VEC.
 216         (struct arm_exidx_entry): New method operator<.
 217         (struct arm_exidx_data) <section_maps>: Change type.
 218         (arm_exidx_data_free): Remove.
 219         (arm_exidx_data_key): Change type.  Move lower.
 220         (arm_exidx_new_objfile): Update.
 221         (arm_compare_exidx_entries): Remove.
 222         (arm_find_exidx_entry, _initialize_arm_tdep)
 223
 224 2019-07-10  Tom Tromey  <tromey@adacore.com>
 225
 226         * solib-spu.c (ocl_program_data_key): Change type.
 227         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 228         Update.
 229
 230 2019-07-10  Tom Tromey  <tromey@adacore.com>
 231
 232         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 233         (struct solib_aix_inferior_data) <library_list>: Change type.
 234         (solib_aix_inferior_data_handle): Change type.
 235         (get_solib_aix_inferior_data): Update.
 236         (solib_aix_free_library_list): Remove.
 237         (library_list_start_library): Update.
 238         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 239         return type.
 240         (solib_aix_get_library_list)
 241         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 242         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 243
 244 2019-07-10  Tom Tromey  <tromey@adacore.com>
 245
 246         * solib-dsbt.c (struct dsbt_info): Add initializers.
 247         (solib_dsbt_pspace_data): Change type.
 248         (dsbt_pspace_data_cleanup): Remove.
 249         (get_dsbt_info, _initialize_dsbt_solib): Update.
 250
 251 2019-07-10  Tom Tromey  <tromey@adacore.com>
 252
 253         * spu-tdep.c (spu_overlay_data): Change type.
 254         (spu_get_overlay_table, spu_overlay_new_objfile)
 255         (_initialize_spu_tdep): Update.
 256
 257 2019-07-10  Tom Tromey  <tromey@adacore.com>
 258
 259         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 260         destructor.
 261         (dbx_objfile_data_key): Change type and declare later.
 262         (DBX_SYMFILE_INFO): Rewrite.
 263         * dbxread.c (dbx_objfile_data_key): Change type.
 264         (dbx_symfile_init): Update.
 265         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 266         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 267         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 268
 269 2019-07-10  Tom Tromey  <tromey@adacore.com>
 270
 271         * jit.c (jit_program_space_key): Change type.  Move lower.
 272         (get_jit_program_space_data): Update.
 273         (jit_program_space_data_cleanup): Remove.
 274         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 275         Update.
 276         (struct jit_program_space_data): Add initializers.
 277
 278 2019-07-10  Tom Tromey  <tromey@adacore.com>
 279
 280         * solib-darwin.c (struct darwin_info): Add initializers.
 281         (solib_darwin_pspace_data): Change type.
 282         (darwin_pspace_data_cleanup): Remove.
 283         (get_darwin_info, _initialize_darwin_solib): Update.
 284
 285 2019-07-10  Tom Tromey  <tromey@adacore.com>
 286
 287         * remote-sim.c (struct sim_inferior_data): Add initializers,
 288         constructor, and destructor.
 289         (sim_inferior_data_key): Change type.  Move lower.
 290         (check_for_duplicate_sim_descriptor): Update.
 291         (get_sim_inferior_data): Use new.  Update.
 292         (~sim_inferior_data_cleanup): Rename from
 293         sim_inferior_data_cleanup.  Simplify.
 294         (gdbsim_close_inferior, simulator_command)
 295         (sim_command_completer, _initialize_remote_sim): Update.
 296         (next_pid, INITIAL_PID): Move earlier.
 297
 298 2019-07-10  Tom Tromey  <tromey@adacore.com>
 299
 300         * python/python-internal.h (create_thread_object): Return
 301         gdbpy_ref.
 302         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 303         * python/py-inferior.c (struct threadlist_entry): Add
 304         constructor.
 305         <thread_obj>: Now a gdbpy_ref.
 306         (thread_to_thread_object): Update.
 307         (add_thread_object): Use new.
 308         (delete_thread_object): Use delete.
 309         (infpy_threads): Update.
 310         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 311         GIL.
 312
 313 2019-07-10  Tom Tromey  <tromey@adacore.com>
 314
 315         * valops.c (value_cast): Specialize error message for Ada.
 316
 317 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 318
 319         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 320
 321 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 322
 323         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 324         bpstat_should_step): Return bool, adjust comments.
 325         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 326         bpstat_should_step): Likewise.
 327
 328 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 329
 330         * features/Makefile: Use feature target descriptions for Arm.
 331         * features/arm/arm-core.c: Generate new file.
 332         * features/arm/arm-fpa.c: Likewise.
 333         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 334         * features/arm/arm-m-profile.c: Likewise.
 335         * features/arm/arm-vfpv2.c: Likewise.
 336         * features/arm/arm-vfpv3.c: Likewise.
 337         * features/arm/xscale-iwmmxt.c: Likewise.
 338         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 339
 340 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 341
 342         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 343         ptrace earlier.
 344
 345 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 346
 347         * features/aarch64-pauth.c: Regenerate.
 348
 349 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 350
 351         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 352         bool.
 353         (bpstat_what): Use false instead of 0.
 354
 355 2019-07-09  Pedro Alves  <palves@redhat.com>
 356
 357         * break-catch-throw.c (is_exception_catchpoint): New.
 358         * breakpoint.c (print_one_breakpoint_location): New parameter
 359         'raw_loc'.  Handle it.  Use
 360         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 361         looking at the breakpoint's type.
 362         (print_one_breakpoint): If handling "maint info breakpoints", also
 363         print locations of exception catchpoints.
 364         * breakpoint.h (is_exception_catchpoint): Declare.
 365
 366 2019-07-09  Pedro Alves  <palves@redhat.com>
 367
 368         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 369         "addr" field.
 370         (allocate_location_exception_catchpoint): New.
 371         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 372         (initialize_throw_catchpoint_ops): Install
 373         allocate_location_exception_catchpoint as allocate_location
 374         method.
 375         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 376         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 377         bp_loc_other.
 378         (breakpoint_address_is_meaningful): Delete.
 379         (bl_address_is_meaningful): New.
 380         (breakpoint_locations_match): Adjust comment.
 381         (bp_location_from_bp_type): New, factored out of...
 382         (bp_location::bp_location(breakpoint *)): ... this.
 383         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 384         factored out of...
 385         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 386         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 387         breakpoint_address_is_meaningful.
 388         (bp_locations_compare): Adjust comment.
 389         (update_global_location_list): Use bl_address_is_meaningful
 390         instead of breakpoint_address_is_meaningful.
 391         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 392         explicit.
 393         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 394         * python/py-breakpoint.c (bppy_get_location): No longer check
 395         whether location is null.
 396
 397 2019-07-09  Pedro Alves  <palves@redhat.com>
 398
 399         PR c++/15468
 400         * breakpoint.c (print_one_breakpoint_location): Remove
 401         single-location assert.
 402
 403 2019-07-09  Tom Tromey  <tom@tromey.com>
 404
 405         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 406         * configure: Rebuild.
 407         * configure.ac: Change common to gdbsupport.
 408         * gdbsupport: Rename from common.
 409         * acinclude.m4: Change common to gdbsupport.
 410         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 411         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 412         gdbsupport.
 413         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 414         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 415         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 416         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 417         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 418         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 419         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 420         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 421         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 422         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 423         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 424         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 425         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 426         coff-pe-read.c, command.h, compile/compile-c-support.c,
 427         compile/compile-c.h, compile/compile-cplus-symbols.c,
 428         compile/compile-cplus-types.c, compile/compile-cplus.h,
 429         compile/compile-loc2c.c, compile/compile.c, completer.c,
 430         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 431         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 432         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 433         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 434         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 435         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 436         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 437         features/aarch64-core.c, features/aarch64-fpu.c,
 438         features/aarch64-pauth.c, features/aarch64-sve.c,
 439         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 440         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 441         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 442         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 443         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 444         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 445         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 446         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 447         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 448         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 449         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 450         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 451         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 452         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 453         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 454         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 455         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 456         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 457         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 458         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 459         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 460         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 461         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 462         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 463         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 464         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 465         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 466         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 467         minsyms.c, mips-linux-tdep.c, namespace.h,
 468         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 469         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 470         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 471         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 472         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 473         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 474         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 475         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 476         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 477         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 478         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 479         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 480         procfs.c, producer.c, progspace.h, psymtab.h,
 481         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 482         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 483         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 484         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 485         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 486         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 487         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 488         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 489         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 490         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 491         target-memory.c, target.c, target.h, target/waitstatus.c,
 492         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 493         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 494         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 495         unittests/array-view-selftests.c,
 496         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 497         unittests/common-utils-selftests.c,
 498         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 499         unittests/format_pieces-selftests.c,
 500         unittests/function-view-selftests.c,
 501         unittests/lookup_name_info-selftests.c,
 502         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 503         unittests/mkdir-recursive-selftests.c,
 504         unittests/observable-selftests.c,
 505         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 506         unittests/parse-connection-spec-selftests.c,
 507         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 508         unittests/scoped_fd-selftests.c,
 509         unittests/scoped_mmap-selftests.c,
 510         unittests/scoped_restore-selftests.c,
 511         unittests/string_view-selftests.c, unittests/style-selftests.c,
 512         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 513         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 514         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 515         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 516         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 517         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 518
 519 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 520
 521         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 522         bool value.
 523         (decode_digits_ordinary): Set explicit_line field in sal.
 524         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 525         symtab_and_line that was set on an explicit line number in
 526         assembler code.  Do always update the recorded symtab and line if
 527         we do skip the prologue.
 528
 529 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 530
 531         * breakpoint.c (set_breakpoint_location_function): Remove
 532         explicit_loc parameter.
 533         (momentary_breakpoint_from_master): Update call to
 534         set_breakpoint_location_function.
 535         (add_location_to_breakpoint): Likewise.
 536
 537 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 538
 539         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 540         required features based on default bfd type when no specific bfd
 541         is present.
 542
 543 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 544
 545         * NEWS: Mention that GDB printf and eval commands can now print
 546         C-style and Ada-style convenience var strings without
 547         calling the inferior.
 548         * printcmd.c (printf_c_string): Locally print GDB internal var
 549         instead of transiting via the inferior.
 550         (printf_wide_c_string): Likewise.
 551
 552 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 553
 554         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 555
 556 2019-07-04  Tom Tromey  <tom@tromey.com>
 557
 558         PR tui/24724:
 559         * tui/tui-winsource.c (tui_clear_source_content): Update.
 560         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 561         (tui_update_breakpoint_info): Update.
 562         (tui_set_exec_info_content): Update.
 563         * tui/tui-source.c (tui_set_source_content_nil): Update.
 564         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 565         has_break.
 566         * tui/tui-data.h (enum tui_bp_flag): New.
 567         (tui_bp_flags): New enum flags type.
 568         (struct tui_source_element) <break_mode>: Change type.  Rename
 569         from has_break.
 570         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 571         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 572         constants.
 573         * tui/tui-winsource.h: Fix comment.
 574
 575 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 576
 577         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 578         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 579         (store_fpregs_to_thread)
 580         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 581         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 582         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 583         (IWMMXT_REGS_SIZE): Add define.
 584         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 585         (fetch_vfp_regs, store_vfp_regs)
 586         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 587         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 588
 589 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 590
 591         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 592         defines.
 593         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 594         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 595         (ARM_INT_REGISTER_SIZE): ...to this.
 596         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 597         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 598         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 599         (arm_linux_collect_gregset, supply_nwfpe_register)
 600         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 601         defines.
 602         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 603         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 604         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 605         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 606         (arm_return_in_memory, arm_store_return_value)
 607         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 608         (arm_record_ld_st_multiple): Likewise.
 609         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 610         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 611
 612 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 613
 614         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 615         AARCH64_DISPLACED_MODIFIED_INSNS.
 616         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 617         (aarch64_displaced_step_copy_insn): Likewise.
 618         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 619         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 620         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 621         ARM_DISPLACED_MODIFIED_INSNS.
 622         * arm-tdep.c (arm_gdbarch_init): Likewise.
 623         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 624         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 625         (struct arm_displaced_step_closure): Use
 626         ARM_DISPLACED_MODIFIED_INSNS.
 627
 628 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 629
 630         * features/Makefile: Remove unused xml files.
 631         * features/aarch64.xml: Remove.
 632         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 633         * features/i386/amd64-avx-avx512.xml: Remove.
 634         * features/i386/amd64-avx-linux.xml: Remove.
 635         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 636         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 637         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 638         * features/i386/amd64-avx-mpx.xml: Remove.
 639         * features/i386/amd64-avx.xml: Remove.
 640         * features/i386/amd64-linux.xml: Remove.
 641         * features/i386/amd64-mpx-linux.xml: Remove.
 642         * features/i386/amd64-mpx.xml: Remove.
 643         * features/i386/amd64.xml: Remove.
 644         * features/i386/i386-avx-avx512-linux.xml: Remove.
 645         * features/i386/i386-avx-avx512.xml: Remove.
 646         * features/i386/i386-avx-linux.xml: Remove.
 647         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 648         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 649         * features/i386/i386-avx-mpx-linux.xml: Remove.
 650         * features/i386/i386-avx-mpx.xml: Remove.
 651         * features/i386/i386-avx.xml: Remove.
 652         * features/i386/i386-linux.xml: Remove.
 653         * features/i386/i386-mmx-linux.xml: Remove.
 654         * features/i386/i386-mmx.xml: Remove.
 655         * features/i386/i386-mpx-linux.xml: Remove.
 656         * features/i386/i386-mpx.xml: Remove.
 657         * features/i386/i386.xml: Remove.
 658         * features/i386/x32-avx-avx512-linux.xml: Remove.
 659         * features/i386/x32-avx-linux.xml: Remove.
 660         * features/i386/x32-linux.xml: Remove.
 661
 662 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 663
 664         * regformats/aarch64.dat: Remove.
 665         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 666         * regformats/i386/amd64-avx-linux.dat: Remove.
 667         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 668         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 669         * regformats/i386/amd64-linux.dat: Remove.
 670         * regformats/i386/amd64-mpx-linux.dat: Remove.
 671         * regformats/i386/amd64.dat: Remove.
 672         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 673         * regformats/i386/i386-avx-linux.dat: Remove.
 674         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 675         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 676         * regformats/i386/i386-linux.dat: Remove.
 677         * regformats/i386/i386-mmx-linux.dat: Remove.
 678         * regformats/i386/i386-mpx-linux.dat: Remove.
 679         * regformats/i386/i386.dat: Remove.
 680         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 681         * regformats/i386/x32-avx-linux.dat: Remove.
 682         * regformats/i386/x32-linux.dat: Remove.
 683
 684 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 685
 686         * aarch64-tdep.c: Remove xml self tests.
 687         * amd64-linux-tdep.c: Likewise.
 688         * amd64-tdep.c: Likewise.
 689         * i386-linux-tdep.c: Likewise.
 690         * i386-tdep.c: Likewise.
 691
 692 2019-07-03  Pedro Alves  <palves@redhat.com>
 693
 694         PR cli/24732
 695         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 696         (pipe_cmd_option_defs): New.
 697         (make_pipe_cmd_options_def_group): New.
 698         (pipe_command): Use gdb::option::process_options.
 699         (pipe_command_completer): New function.
 700         (_initialize_cli_cmds): Install completer for "pipe" command.
 701
 702 2019-07-03  Pedro Alves  <palves@redhat.com>
 703
 704         * cli/cli-option.c (union option_value) <string>: New field.
 705         (struct option_def_and_value): Add ctor, move ctor, dtor and
 706         use DISABLE_COPY_AND_ASSIGN.
 707         (option_def_and_value::clear_value): New.
 708         (parse_option, save_option_value_in_ctx, get_val_type_str)
 709         (add_setshow_cmds_for_options): Handle var_string.
 710         * cli-option.h (union option_def::var_address) <string>: New
 711         field.
 712         (struct string_option_def): New.
 713         * maint-test-options.c (struct test_options_opts): Add default
 714         ctor and use DISABLE_COPY_AND_ASSIGN.
 715         <string_opt>: New field.
 716         (test_options_opts::~test_options_opts): New.
 717         (test_options_opts::dump): Also dump "-string".
 718         (test_options_option_defs): Install "string.
 719
 720 2019-07-03  Pedro Alves  <palves@redhat.com>
 721
 722         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 723         option_value with a null enumeration.
 724         (complete_options): Save the option values in the context.
 725         (save_option_value_in_ctx): New, factored out from ...
 726         (process_options): ... here.
 727         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 728         of the function.
 729         * maint-test-options.c (test_options_opts::dump): New, factored
 730         out from ...
 731         (maintenance_test_options_command_mode): ... here.
 732         (maintenance_test_options_command_completion_result): Delete.
 733         (maintenance_test_options_command_completion_text): Update
 734         comment.
 735         (maintenance_show_test_options_completion_result): Change
 736         prototype.  Just print
 737         maintenance_test_options_command_completion_text.
 738         (save_completion_result): New.
 739         (maintenance_test_options_completer_mode): Pass options context to
 740         complete_options, and then save a dump.
 741         (_initialize_maint_test_options): Use add_cmd to install "maint
 742         show test-options-completion-result".
 743
 744 2019-07-03  Pedro Alves  <palves@redhat.com>
 745
 746         * NEWS (New commands): Mention "with" and "maint with".
 747         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 748         (with_command, with_command_completer): New.
 749         (pipe_command): Adjust to new repeat_previous
 750         interface.
 751         (_initialize_cli_cmds): Install the "with" command and its "w"
 752         alias.
 753         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 754         declarations.
 755         * cli/cli-setshow.c (parse_cli_var_uinteger)
 756         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 757         argument strings for all var_types.
 758         (get_setshow_command_value_string): New, factored out from ...
 759         (do_show_command): ... this.
 760         * cli/cli-setshow.h: Include <string>.
 761         (get_setshow_command_value_string): Declare.
 762         * command.h (repeat_previous): Now returns const char *.  Adjust
 763         comment.
 764         * maint.c: Include "cli/cli-cmds.h".
 765         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 766         (_initialize_maint_cmds): Register the "maintenance with" command.
 767         * top.c (repeat_previous): Move bits from pipe_command here:
 768         Return the saved command line, if any; error out if there's no
 769         command to relaunch.
 770
 771 2019-07-03  Pedro Alves  <palves@redhat.com>
 772
 773         * NEWS (New commands): Mention "maint set/show test-settings"
 774         instead of "maint test-settings".
 775         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 776         (maintenance_test_settings_set_list): Rename to ...
 777         (maintenance_set_test_settings_list): ... this.
 778         (maintenance_test_settings_show_list): Rename to  ...
 779         (maintenance_show_test_settings_list): ... this.
 780         (maintenance_test_settings_cmd): Delete.
 781         (maintenance_test_settings_set_cmd): ...
 782         (maintenance_set_test_settings_cmd): ... this.
 783         (maintenance_test_settings_show_cmd): ...
 784         (maintenance_show_test_settings_cmd): ... this.
 785         (maintenance_test_settings_show_value_cmd):
 786         (maintenance_show_test_settings_value_cmd): ... this.
 787         (_initialize_maint_test_settings): No longer install the "maint
 788         test-settings" prefix command.  Rename "maint test-settings set"
 789         to "maint set test-settings", and "maint test-settings show" to
 790         "maint show test-settings".  Adjust all subcommands.
 791
 792 2019-07-03  Pedro Alves  <palves@redhat.com>
 793
 794         * maint-test-settings.c: Fix file's intro comment.  Replace all
 795         references to "test-options" with references to "test-settings",
 796         in comments.
 797
 798 2019-07-03  Pedro Alves  <palves@redhat.com>
 799
 800         * maint-test-settings.c (maintenance_test_settings_xxx)
 801         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 802         New.
 803         (maintenance_test_settings_enums): Use them.
 804         (maintenance_test_settings_enum): Default to
 805         maintenance_test_settings_xxx.
 806         (_initialize_maint_test_settings): Initialize
 807         MAINTENANCE_TEST_SETTINGS_FILENAME.
 808
 809 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 810
 811         * breakpoint.h (remove_breakpoints_inf): Change return type to
 812         void, move function documentation here.
 813         * breakpoint.c (remove_breakpoints_inf): Change return type to
 814         void, move function documentation to header.
 815
 816 2019-07-02  Pedro Alves  <palves@redhat.com>
 817
 818         * NEWS (Completion improvements): Mention "info threads".
 819         * thread.c (struct info_threads_opts, info_threads_option_defs)
 820         (make_info_threads_options_def_group): New.
 821         (info_threads_command): Use gdb::option::process_options.
 822         (info_threads_command_completer): New.
 823         (_initialize_thread): Use gdb::option::build_help to build the
 824         help text for "info threads".
 825
 826 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 827
 828         * defs.h (generic_load): Move from here...
 829         * symfile.h (generic_load): ... to here.  Rename name parameter
 830         to args.
 831         * symfile.c (generic_load): Add comment.
 832
 833 2019-07-01  Tom Tromey  <tromey@adacore.com>
 834
 835         * dwarf2read.c
 836         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 837         declaration of without_params.  Fix formatting.
 838
 839 2019-07-01  Tom Tromey  <tromey@adacore.com>
 840
 841         * ada-exp.y (find_primitive_type): Update.
 842         * ada-lang.h (ada_lookup_symbol): Update.
 843         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 844         parameter.
 845         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 846
 847 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 848
 849         PR breakpoints/24541
 850         * gdbarch.c: Regenerate.
 851         * gdbarch.h: Regenerate.
 852         * gdbarch.sh: Add 'stap_adjust_register'.
 853         * i386-tdep.c: Include '<unordered_set>'.
 854         (i386_stap_adjust_register): New function.
 855         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 856         * stap-probe.c (stap_parse_register_operand): Call
 857         'gdbarch_stap_adjust_register'.
 858
 859 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 860
 861         PR python/24742
 862         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 863         * python/python.c (do_start_initialization): Use 'xmalloc'
 864         instead of 'PyMem_Malloc'.
 865
 866 2019-06-28  Tom Tromey  <tromey@adacore.com>
 867
 868         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 869         for Ada.
 870
 871 2019-06-27  Tom Tromey  <tromey@adacore.com>
 872
 873         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 874         objfile_key.
 875         (arm_find_mapping_symbol, arm_record_special_symbol)
 876         (_initialize_arm_tdep): Update.
 877         (arm_objfile_data_free): Remove.
 878
 879 2019-06-27  Tom Tromey  <tromey@adacore.com>
 880
 881         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 882         to cp_print_static_field.
 883
 884 2019-06-26  Tom Tromey  <tromey@adacore.com>
 885
 886         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 887         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 888         declare.
 889
 890 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 891
 892         * features/aarch64-core.c (create_feature_aarch64_core):
 893         Regenerate.
 894         * features/aarch64-core.xml: Add cpsr flags.
 895
 896 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 897
 898         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 899         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 900
 901 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 902
 903         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 904         field.
 905         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 906         use.
 907         (arm_record_special_symbol): Don't insert new symbol in sorted
 908         position, push it at the end.
 909
 910 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 911
 912         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 913         (arm_mapping_symbol_s): Remove.
 914         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 915         (arm_mapping_symbol_vec): New typedef.
 916         (struct arm_per_objfile): Add constructor.
 917         <section_maps>: Change type to
 918         std::unique_ptr<arm_mapping_symbol_vec[]>.
 919         (arm_compare_mapping_symbols): Remove.
 920         (arm_find_mapping_symbol): Adjust to section_maps type change.
 921         (arm_objfile_data_free): Call delete on arm_per_objfile.
 922         (arm_record_special_symbol): Adjust to section_maps type change.
 923         Allocate arm_per_objfile with new.
 924
 925 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 926
 927         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 928         with the command prefix.
 929
 930 2019-06-25  Tom Tromey  <tom@tromey.com>
 931
 932         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 933         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 934
 935 2019-06-25  Tom Tromey  <tom@tromey.com>
 936
 937         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 938         type.
 939         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 940         protected.
 941
 942 2019-06-25  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-winsource.c
 945         (tui_source_window_base::set_is_exec_point_at): Add check against
 946         LOA_ADDRESS.
 947
 948 2019-06-25  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-source.c (tui_set_source_content): Don't check before
 951         xfree.
 952         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 953
 954 2019-06-25  Tom Tromey  <tom@tromey.com>
 955
 956         * tui/tui-winsource.h (tui_update_source_window_as_is)
 957         (tui_alloc_source_buffer, tui_line_is_displayed)
 958         (tui_addr_is_displayed): Change type of win_info.
 959         * tui/tui-winsource.c (tui_update_source_window_as_is)
 960         (tui_clear_source_content, tui_show_source_line)
 961         (tui_show_source_content, tui_source_window_base::refill)
 962         (tui_source_window_base::set_is_exec_point_at)
 963         (tui_source_window_base::set_is_exec_point_at)
 964         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 965         (tui_alloc_source_buffer, tui_line_is_displayed)
 966         (tui_addr_is_displayed): Change type of win_info.  Update.
 967         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 968         (tui_source_window_base::do_make_visible_with_new_height):
 969         Update.
 970         * tui/tui-source.c (tui_set_source_content)
 971         (tui_set_source_content_nil)
 972         (tui_source_window::do_scroll_vertical): Update.
 973         * tui/tui-layout.c (show_layout): Update.
 974         * tui/tui-disasm.c (tui_set_disassem_content)
 975         (tui_disasm_window::do_scroll_vertical): Update.
 976         * tui/tui-data.h (tui_win_content): Remove.
 977         (struct tui_gen_win_info) <content, content_size>: Remove.
 978         (struct tui_source_element): Add initializers and destructor.
 979         (union tui_which_element, struct tui_win_element): Remove.
 980         (struct tui_source_window_base) <content>: New field.
 981         (struct tui_data_window): Remove destructor.
 982         (tui_alloc_content, tui_free_win_content)
 983         (tui_free_all_source_wins_content): Don't declare.
 984         * tui/tui-data.c (tui_initialize_static_data): Update.
 985         (init_content_element, tui_alloc_content): Remove.
 986         (~tui_gen_win_info): Update.
 987         (~tui_data_window, tui_free_all_source_wins_content)
 988         (tui_free_win_content, free_content, free_content_elements):
 989         Remove.
 990
 991 2019-06-25  Tom Tromey  <tom@tromey.com>
 992
 993         * tui/tui-winsource.h (tui_clear_source_content)
 994         (tui_erase_source_content, tui_show_source_content): Change type
 995         of win_info.
 996         * tui/tui-winsource.c (tui_clear_source_content)
 997         (tui_erase_source_content, tui_show_source_content): Change type
 998         of win_info.
 999         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1000         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1001         win_info.
1002         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1003         win_info.
1004         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1005
1006 2019-06-25  Tom Tromey  <tom@tromey.com>
1007
1008         * tui/tui-winsource.c (tui_clear_source_content)
1009         (tui_source_window_base::set_is_exec_point_at): Update.
1010         * tui/tui-source.c (tui_set_source_content_nil): Update.
1011         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1012         a bool.
1013         * tui/tui-data.c (init_content_element): Update.
1014
1015 2019-06-25  Tom Tromey  <tom@tromey.com>
1016
1017         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1018         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1019         * tui/tui-layout.c (init_and_make_win): Update.
1020         * tui/tui.h (enum tui_win_type): Update.
1021         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1022         tui_win_is_auxillary.
1023         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1024         tui_win_is_auxillary.
1025
1026 2019-06-25  Tom Tromey  <tom@tromey.com>
1027
1028         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1029         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1030         (tui_delete_data_content_windows, tui_display_all_data)
1031         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1032         Update.
1033         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1034         * tui/tui-regs.c (tui_last_regs_line_no)
1035         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1036         (tui_show_registers): Update.
1037         (tui_show_register_group): Return void.  Update.
1038         (tui_display_registers_from, tui_display_reg_element_at_line)
1039         (tui_display_registers_from_line, tui_check_register_values):
1040         Update.
1041         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1042         member.
1043         (struct tui_data_window) <regs_content>: Now a std::vector.
1044         <regs_content_count>: Remove.
1045         (tui_add_content_elements, tui_free_data_content): Don't declare.
1046         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1047         (init_content_element): Remove DATA_WIN case.  Add assert.
1048         (tui_add_content_elements): Remove.
1049         (tui_data_window): Update.
1050         (tui_free_data_content): Remove.
1051         (free_content_elements): Remove DATA_WIN case.
1052
1053 2019-06-25  Tom Tromey  <tom@tromey.com>
1054
1055         * tui/tui-data.c (tui_data_item_window): Update.
1056         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1057         * tui/tui-windata.c (tui_display_all_data)
1058         (tui_display_data_from_line): Update.
1059         (tui_check_data_values): Remove.
1060         * tui/tui-regs.c (tui_show_register_group)
1061         (tui_display_reg_element_at_line): Update.
1062         * tui/tui-hooks.c (tui_register_changed)
1063         (tui_refresh_frame_and_register_information): Call
1064         tui_check_register_values.
1065         * tui/tui-data.h (struct tui_data_window) <data_content,
1066         data_content_count, data_type>: Remove.
1067         (enum tui_data_type): Remove.
1068
1069         * tui/tui-data.c (tui_data_window::clear_detail)
1070         (~tui_data_window): Update.
1071
1072 2019-06-25  Tom Tromey  <tom@tromey.com>
1073
1074         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1075         declare.
1076         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1077         Rename from tui_first_data_item_displayed.  Update.
1078         (tui_data_window::refresh_all)
1079         (tui_data_window::do_scroll_vertical): Update.
1080         * tui/tui-data.h (struct tui_data_window)
1081         <first_data_item_displayed>: Declare new method.
1082
1083 2019-06-25  Tom Tromey  <tom@tromey.com>
1084
1085         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1086         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1087         contents...
1088         (tui_initialize_static_data): ...here.
1089
1090 2019-06-25  Tom Tromey  <tom@tromey.com>
1091
1092         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1093         (tui_display_registers_from, tui_check_register_values): Update.
1094         (tui_display_register): Remove win_info parameter; update.
1095         (tui_get_register): Change type of parameters.
1096         * tui/tui-data.h (struct tui_data_element): Remove.
1097         (union tui_which_element) <data>: Remove.
1098         <data_window>: Change type.
1099         (struct tui_data_item_window): New.
1100         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1101         case.  Add assert.
1102         (~tui_data_item_window): New destructor.
1103         (free_content_elements): Remove DATA_ITEM_WIN case.
1104
1105 2019-06-25  Tom Tromey  <tom@tromey.com>
1106
1107         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1108         Remove.
1109
1110 2019-06-25  Tom Tromey  <tom@tromey.com>
1111
1112         * tui/tui-data.h (struct tui_command_element): Remove.
1113         (union tui_which_element) <command>: Remove.
1114         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1115         assert.
1116         (free_content_elements): Remove CMD_WIN case.
1117
1118 2019-06-25  Tom Tromey  <tom@tromey.com>
1119
1120         * tui/tui-layout.c (tui_set_layout): Update.
1121         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1122         * tui/tui-data.c (layout_def): Update.
1123
1124 2019-06-25  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1127         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1128         (tui_source_window_base::set_new_height): Update.
1129         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1130         Update.
1131         (tui_set_locator_fullname, tui_set_locator_info)
1132         (tui_show_frame_info): Update.
1133         * tui/tui-source.c (tui_set_source_content)
1134         (tui_source_is_displayed): Update.
1135         * tui/tui-layout.c (show_source_disasm_command, show_data)
1136         (show_source_or_disasm_and_command): Update.
1137         * tui/tui-disasm.c (tui_set_disassem_content)
1138         (tui_get_begin_asm_address): Update.
1139         * tui/tui-data.h (struct tui_locator_element): Remove.
1140         (union tui_which_element) <locator>: Remove.
1141         (struct tui_locator_window): New.
1142         (tui_locator_win_info_ptr): Change return type.
1143         * tui/tui-data.c (_locator): Change type.
1144         (tui_locator_win_info_ptr): Change return type.
1145         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1146         (tui_alloc_content): Add assert.
1147
1148 2019-06-25  Tom Tromey  <tom@tromey.com>
1149
1150         * tui/tui-winsource.c
1151         (tui_exec_info_window::maybe_allocate_content): New method.
1152         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1153         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1154         (make_source_or_disasm_window): Add cast.
1155         * tui/tui-data.h (union tui_which_element) <simple_string>:
1156         Remove.
1157         (struct tui_source_info): New.
1158         (struct tui_source_window_base) <execution_info>: Change type.
1159         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1160         case, and add assert.
1161         (tui_alloc_content): Add assert.
1162
1163 2019-06-25  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1166         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1167         * tui/tui-data.c (tui_alloc_win_info): Remove.
1168
1169 2019-06-25  Tom Tromey  <tom@tromey.com>
1170
1171         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1172         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1173         can_highlight.
1174
1175 2019-06-25  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1178         make_visible_with_new_height method.
1179         (tui_win_info::make_visible_with_new_height): New method.
1180         (tui_source_window_base::do_make_visible_with_new_height)
1181         (tui_data_window::do_make_visible_with_new_height)
1182         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1183         (make_visible_with_new_height): Remove.
1184         (tui_resize_all, tui_adjust_win_heights): Use
1185         make_visible_with_new_height method.
1186         * tui/tui-data.h (struct tui_win_info)
1187         <do_make_visible_with_new_height, make_visible_with_new_height>:
1188         New methods.
1189         (struct tui_source_window_base, struct tui_data_window)
1190         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1191         methods.
1192
1193 2019-06-25  Tom Tromey  <tom@tromey.com>
1194
1195         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1196         method.
1197         (update_tab_width): Call update_tab_width method.
1198         * tui/tui-data.h (struct tui_win_info)
1199         (struct tui_source_window_base) <update_tab_width>: New methods.
1200
1201 2019-06-25  Tom Tromey  <tom@tromey.com>
1202
1203         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1204         parameter.
1205         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1206         parameter.
1207         (tui_gen_win_info::make_visible): Update.
1208         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1209         parameter.
1210         * tui/tui-data.h (enum tui_box): New enum.
1211         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1212
1213 2019-06-25  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1216         init_and_make_win for EXEC_INFO_WIN.
1217         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1218         longer inline.
1219         (struct tui_win_info) <~tui_win_info>: Inline.
1220         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1221         Don't declare.
1222         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1223         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1224         Remove.
1225         (tui_initialize_static_data): Update.
1226         (~tui_gen_win_info): Handle more cleanup here.
1227         (~tui_source_window_base): Delete "execution_info".
1228         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1229
1230 2019-06-25  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-layout.c (make_command_window): Don't set
1233         can_highlight.
1234         (show_source_disasm_command): Call the reset method.
1235         (show_data): Don't set can_highlight.  Call the reset method.
1236         (tui_gen_win_info::reset): Rename from init_gen_win_info
1237         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1238         (show_source_or_disasm_and_command): Call the reset method.
1239         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1240         (struct tui_cmd_window): Set can_highlight.
1241
1242 2019-06-25  Tom Tromey  <tom@tromey.com>
1243
1244         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1245         from make_visible.
1246         (tui_make_visible, tui_make_invisible): Rewrite.
1247         (tui_win_info::make_visible): Remove.
1248         (tui_source_window_base::make_visible): Update.
1249         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1250         method.  Moved from...
1251         (struct tui_win_info) <make_visible>: ...here.
1252
1253 2019-06-25  Tom Tromey  <tom@tromey.com>
1254
1255         * tui/tui-winsource.c
1256         (tui_source_window_base::do_scroll_horizontal): Remove direction
1257         parameter.
1258         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1259         direction parameter.
1260         * tui/tui-win.c (tui_win_info::forward_scroll)
1261         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1262         (tui_win_info::right_scroll): Update.
1263         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1264         direction parameter.
1265         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1266         direction parameter.
1267         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1268         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1269         Remove direction parameter.
1270         (struct tui_source_window_base, struct tui_source_window)
1271         (struct tui_disasm_window, struct tui_data_window)
1272         (struct tui_cmd_window): Update.
1273
1274 2019-06-25  Tom Tromey  <tom@tromey.com>
1275
1276         * tui/tui-winsource.h (tui_set_exec_info_content)
1277         (tui_show_exec_info_content, tui_erase_exec_info_content)
1278         (tui_clear_exec_info_content, tui_update_exec_info): Change
1279         argument to tui_source_window_base.
1280         * tui/tui-winsource.c (tui_set_exec_info_content)
1281         (tui_show_exec_info_content, tui_erase_exec_info_content)
1282         (tui_clear_exec_info_content, tui_update_exec_info): Change
1283         argument to tui_source_window_base.
1284
1285 2019-06-25  Tom Tromey  <tom@tromey.com>
1286
1287         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1288         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1289
1290 2019-06-25  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1293         check.
1294
1295 2019-06-25  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1298         type to void.
1299         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1300         type to void.
1301         * tui/tui-source.c (tui_set_source_content): Update.
1302         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1303
1304 2019-06-25  Tom Tromey  <tom@tromey.com>
1305
1306         * tui/tui-win.c (window_name_completer, tui_set_focus)
1307         (tui_all_windows_info): Use name method.
1308         * tui/tui-data.h (struct tui_gen_win_info)
1309         (struct tui_source_window, struct tui_disasm_window)
1310         (struct tui_data_window, struct tui_cmd_window) <name>: New
1311         method.
1312         (tui_win_name): Don't declare.
1313         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1314         (tui_win_name): Remove.
1315
1316 2019-06-25  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-winsource.h (tui_update_source_window)
1319         (tui_update_source_window_as_is): Change parameter type.
1320         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1321         to be a tui_source_window_base.
1322         (tui_update_source_window_as_is): Likewise.
1323         * tui/tui-win.c (make_visible_with_new_height): Update.
1324
1325 2019-06-25  Tom Tromey  <tom@tromey.com>
1326
1327         * tui/tui-winsource.c (tui_erase_source_content)
1328         (tui_show_source_content, tui_show_exec_info_content)
1329         (tui_erase_exec_info_content): Use refresh_window method.
1330         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1331         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1332         from tui_refresh_win.
1333         (tui_data_window::refresh_window): New method.
1334         (tui_win_info::refresh, tui_source_window_base::refresh)
1335         (tui_refresh_all): Use refresh_window method.
1336         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1337         method.
1338         * tui/tui-regs.c (tui_display_register): Call refresh_window
1339         method.
1340         * tui/tui-layout.c (show_source_disasm_command)
1341         (show_source_or_disasm_and_command): Call refresh_window method.
1342         * tui/tui-data.h (struct tui_gen_win_info)
1343         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1344         New method.
1345
1346 2019-06-25  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui.c (tui_rl_other_window, tui_enable)
1349         (tui_is_window_visible, tui_get_command_dimension): Update.
1350         * tui/tui-winsource.c (tui_update_source_window_as_is)
1351         (tui_clear_source_content, tui_erase_source_content)
1352         (tui_show_source_line, tui_source_window_base::refill)
1353         (tui_source_window_base::do_scroll_horizontal)
1354         (tui_source_window_base::set_is_exec_point_at)
1355         (tui_update_breakpoint_info, tui_set_exec_info_content)
1356         (tui_alloc_source_buffer, tui_line_is_displayed)
1357         (tui_addr_is_displayed): Update.
1358         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1359         (tui_check_and_display_highlight_if_needed)
1360         (tui_win_info::make_visible, tui_win_info::refresh)
1361         (tui_refresh_all): Update.
1362         * tui/tui-windata.c (tui_first_data_item_displayed)
1363         (tui_delete_data_content_windows, tui_erase_data_content)
1364         (tui_display_all_data, tui_data_window::refresh_all)
1365         (tui_check_data_values): Update.
1366         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1367         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1368         (tui_win_info::backward_scroll, tui_refresh_all_win)
1369         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1370         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1371         (tui_source_window_base::set_new_height)
1372         (tui_data_window::set_new_height)
1373         (make_invisible_and_set_new_height)
1374         (make_visible_with_new_height, new_height_ok)
1375         (parse_scrolling_args): Update.
1376         * tui/tui-stack.c (tui_show_frame_info): Update.
1377         * tui/tui-source.c (tui_set_source_content)
1378         (tui_set_source_content_nil, tui_source_is_displayed)
1379         (tui_source_window::do_scroll_vertical): Update.
1380         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1381         (tui_display_registers_from, tui_display_reg_element_at_line)
1382         (tui_check_register_values, tui_reg_command): Update.
1383         * tui/tui-layout.c (tui_default_win_height)
1384         (show_source_disasm_command, show_data, init_and_make_win)
1385         (show_source_or_disasm_and_command): Update.
1386         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1387         (tui_redisplay_readline, tui_mld_flush)
1388         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1389         (tui_getc): Update.
1390         * tui/tui-disasm.c (tui_set_disassem_content)
1391         (tui_disasm_window::do_scroll_vertical): Update.
1392         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1393         Now virtual.
1394         (struct tui_win_info): Derive from tui_gen_win_info.
1395         <~tui_win_info>: Mark as override.
1396         <generic>: Remove member.
1397         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1398         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1399         (~tui_data_window, ~tui_win_info)
1400         (tui_free_all_source_wins_content): Update.
1401         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1402
1403 2019-06-25  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-layout.c (init_and_make_win): Use new.
1406         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1407         destructor, initializers.
1408         (tui_alloc_generic_win_info): Don't declare.
1409         * tui/tui-data.c (_locator): Add argument to constructor.
1410         (source_win, disasm_win): New globals.
1411         (exec_info): Remove.
1412         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1413         Update.
1414         (tui_alloc_generic_win_info): Remove.
1415         (init_content_element): Use new.
1416         (tui_win_info::tui_win_info): Update.
1417         (free_content_elements) <case DATA_WIN>: Use delete.
1418
1419 2019-06-25  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1422         * tui/tui-windata.c (tui_first_data_item_displayed)
1423         (tui_delete_data_content_windows): Update.
1424         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1425         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1426         (tui_display_registers_from, tui_check_register_values): Update.
1427         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1428         pointer.
1429         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1430         window.
1431         (tui_free_data_content): Update.
1432         (free_content_elements) <case DATA_WIN>: Free the window.
1433
1434 2019-06-25  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1437         Update.
1438         * tui/tui-layout.c (make_command_window)
1439         (show_source_disasm_command, show_data, init_and_make_win)
1440         (show_source_or_disasm_and_command): Update.
1441         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1442         method.
1443         <can_highight, is_highlighted>: Now bool.
1444         (tui_set_win_highlight): Don't declare.
1445         * tui/tui-data.c (tui_set_win_highlight): Remove.
1446
1447 2019-06-25  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui-wingeneral.c (make_visible): Remove check of window
1450         type.
1451
1452 2019-06-25  Tom Tromey  <tom@tromey.com>
1453
1454         * tui/tui-win.c (tui_win_info::max_height)
1455         (tui_cmd_window::max_height): New methods.
1456         (new_height_ok): Call max_height.
1457         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1458         <max_height>: New method.
1459
1460 2019-06-25  Tom Tromey  <tom@tromey.com>
1461
1462         * tui/tui-win.c (tui_source_window_base::set_new_height)
1463         (tui_data_window::set_new_height): New methods.
1464         (make_invisible_and_set_new_height): Call set_new_height method.
1465         * tui/tui-data.h (struct tui_win_info)
1466         (struct tui_source_window_base, struct tui_data_window)
1467         <set_new_height>: New method.
1468
1469 2019-06-25  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1472         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1473         tui_refresh_data_win.
1474         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1475         method.
1476         (tui_refresh_all_win): Call the refresh_all method.
1477         (tui_set_focus): Likewise.
1478         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1479         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1480         Likewise.
1481
1482 2019-06-25  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-winsource.h (tui_refill_source_window)
1485         (tui_set_is_exec_point_at): Don't declare.
1486         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1487         (tui_source_window_base::refill): Rename from
1488         tui_refill_source_window.
1489         (tui_source_window_base::do_scroll_horizontal): Update.
1490         (tui_source_window_base::set_is_exec_point_at): Rename from
1491         tui_set_is_exec_point_at.
1492         (tui_update_all_breakpoint_info): Update.
1493         * tui/tui-stack.c (tui_show_frame_info): Update.
1494         * tui/tui-layout.c (show_data): Add cast.
1495         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1496         * tui/tui-data.h (struct tui_source_window_base) <refill,
1497         set_is_exec_point_at>: New methods.
1498         (tui_source_windows, tui_add_to_source_windows): Update types.
1499         (tui_add_to_source_windows): Remove redundant declaration.
1500         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1501         (tui_source_windows): Change return type.
1502         (tui_clear_source_windows_detail): Update.
1503         (tui_add_to_source_windows): Change type of parameter.
1504         (tui_free_all_source_wins_content): Update.
1505
1506 2019-06-25  Tom Tromey  <tom@tromey.com>
1507
1508         * tui/tui-wingeneral.c (tui_win_info::refresh)
1509         (tui_source_window_base::refresh): New methods.
1510         (tui_refresh_all): Call the refresh method.
1511         * tui/tui-data.h (struct tui_win_info)
1512         (struct tui_source_window_base) <refresh>: New method.
1513
1514 2019-06-25  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui.h (tui_is_window_visible): Return bool.
1517         * tui/tui.c (tui_is_window_visible): Return bool.
1518         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1519         (tui_make_visible, tui_make_invisible)
1520         (tui_win_info::make_visible)
1521         (tui_source_window_base::make_visible, make_all_visible)
1522         (tui_make_all_visible, tui_make_all_invisible): Update.
1523         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1524         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1525         bool.
1526         (struct tui_win_info, struct tui_source_window_base)
1527         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1528         * tui/tui-data.c (tui_init_generic_part): Update.
1529
1530 2019-06-25  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1533         (tui_source_window_base::make_visible): New methods.
1534         (make_all_visible): Make method call.
1535         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1536         (struct tui_source_window_base, struct tui_cmd_window): Override
1537         make_visible.
1538         (tui_win_is_source_type): Don't declare.
1539         * tui/tui-data.c (tui_win_is_source_type): Remove.
1540
1541 2019-06-25  Tom Tromey  <tom@tromey.com>
1542
1543         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1544         NULL check.
1545
1546 2019-06-25  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1549         Inline constructor.  Add initializers for members.
1550         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1551         constructors; now inline in class.
1552
1553 2019-06-25  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui-regs.c (tui_show_registers): Update.
1556         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1557         bool.
1558         * tui/tui-data.c (tui_data_window::clear_detail)
1559         (tui_data_window): Update.
1560
1561 2019-06-25  Tom Tromey  <tom@tromey.com>
1562
1563         * tui/tui-windata.c (tui_display_all_data)
1564         (tui_display_data_from_line, tui_display_data_from)
1565         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1566         Update.
1567         * tui/tui-regs.c (tui_last_regs_line_no)
1568         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1569         (tui_show_registers, tui_show_register_group)
1570         (tui_display_registers_from, tui_display_reg_element_at_line)
1571         (tui_display_registers_from_line, tui_check_register_values)
1572         (tui_reg_next, tui_reg_prev): Update.
1573         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1574         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1575         tui_data_window.
1576         (struct tui_win_info) <detail>: Remove.  Add new fields from
1577         tui_data_info.
1578         (TUI_DATA_WIN): Add cast.
1579         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1580         (~tui_data_window): Simplify.
1581
1582 2019-06-25  Tom Tromey  <tom@tromey.com>
1583
1584         * tui/tui-layout.c (show_source_disasm_command)
1585         (show_source_or_disasm_and_command): Update.
1586         * tui/tui-io.c (update_cmdwin_start_line)
1587         (tui_redisplay_readline): Update.
1588         * tui/tui-data.h (struct tui_command_info): Remove.
1589         (struct tui_win_info) <detail>: Remove command_info member.
1590         (struct tui_data_window) <start_line>: New member, from
1591         tui_command_info.
1592         (TUI_CMD_WIN): Add casts.
1593
1594 2019-06-25  Tom Tromey  <tom@tromey.com>
1595
1596         * tui/tui-winsource.c (tui_update_source_window)
1597         (tui_refill_source_window)
1598         (tui_source_window_base::do_scroll_horizontal)
1599         (tui_update_breakpoint_info, tui_set_exec_info_content)
1600         (tui_show_exec_info_content, tui_erase_exec_info_content)
1601         (tui_clear_exec_info_content): Update.
1602         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1603         Update.
1604         * tui/tui-win.c (make_invisible_and_set_new_height)
1605         (make_visible_with_new_height): Update.
1606         * tui/tui-source.c (tui_set_source_content)
1607         (tui_show_symtab_source): Update.
1608         * tui/tui-layout.c (extract_display_start_addr)
1609         (show_source_disasm_command, show_data)
1610         (make_source_or_disasm_window)
1611         (show_source_or_disasm_and_command): Update.
1612         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1613         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1614         "gdbarch".
1615         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1616         to tui_source_window_base.
1617         (struct tui_win_info) <detail>: Remove source_info member.
1618         (struct tui_source_window_base) <has_locator>: Inline.
1619         Move contents from tui_source_info; rename has_locator member to
1620         m_has_locator.
1621         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1622         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1623         header file.
1624         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1625         Simplify.
1626         (tui_free_all_source_wins_content): Cast to
1627         tui_source_window_base.
1628
1629 2019-06-25  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-win.c (make_invisible_and_set_new_height)
1632         (make_visible_with_new_height): Call has_locator method.
1633         * tui/tui-layout.c (show_source_disasm_command, show_data)
1634         (show_source_or_disasm_and_command): Update for bool change.
1635         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1636         (tui_win_info) <has_locator>: New method.
1637         (struct tui_source_window_base) <has_locator>: New method.
1638         (tui_win_has_locator): Don't declare.
1639         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1640         from tui_win_has_locator.
1641         (tui_source_window_base): Use false, not FALSE.
1642
1643 2019-06-25  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1646         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1647         clear_detail method directly.
1648         (tui_clear_win_detail): Remove.
1649
1650 2019-06-25  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1653         "this", not TUI_DISASM_WIN.
1654
1655 2019-06-25  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1658         declare.
1659         * tui/tui-winsource.c
1660         (tui_source_window_base::do_scroll_horizontal): Rename from
1661         tui_horizontal_source_scroll.
1662         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1663         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1664         from tui_vertical_data_scroll.
1665         * tui/tui-win.h (tui_scroll): Don't declare.
1666         * tui/tui-win.c (tui_win_info::forward_scroll)
1667         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1668         (tui_win_info::right_scroll): Rename and update.
1669         (tui_scroll_forward_command, tui_scroll_backward_command)
1670         (tui_scroll_left_command, tui_scroll_right_command): Update.
1671         (tui_scroll): Remove.
1672         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1673         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1674         from tui_vertical_source_scroll.
1675         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1676         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1677         from tui_vertical_disassem_scroll.
1678         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1679         do_scroll_horizontal>: New methods.
1680         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1681         Likewise.
1682         (struct tui_source_window_base): Add do_scroll_horizontal.
1683         (struct tui_source_window, struct tui_disasm_window): Add
1684         do_scroll_vertical.
1685         (struct tui_data_window, struct tui_cmd_window): Add
1686         do_scroll_horizontal and do_scroll_vertical.
1687         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1688
1689 2019-06-25  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-data.h (struct tui_source_window_base): New struct.
1692         (struct tui_source_window): Derive from tui_source_window_base.
1693         (struct tui_disasm_window): New struct.
1694         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1695         from tui_source_window::clear_detail.
1696         (tui_source_window_base): Rename from tui_source_window.
1697         (~tui_source_window_base): Rename from ~tui_source_window.
1698         (tui_alloc_win_info): Create a tui_disasm_window.
1699
1700 2019-06-25  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-data.h (struct tui_source_window)
1703         (struct tui_data_window): Declare destructors.
1704         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1705         destructors.
1706         (tui_win_info): Simplify.
1707
1708 2019-06-25  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-winsource.c (tui_display_main)
1711         (tui_update_source_windows_with_addr)
1712         (tui_update_all_breakpoint_info): Update.
1713         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1714         (new_height_ok, parse_scrolling_args): Update.
1715         * tui/tui-stack.c (tui_show_frame_info): Update.
1716         * tui/tui-data.h (struct tui_list): Remove.
1717         (tui_source_windows): Return a reference to a std::vector.
1718         * tui/tui-data.c (source_windows): Now a std::vector.
1719         (tui_source_windows): Change return type.
1720         (tui_clear_source_windows): Rewrite.
1721         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1722         (tui_free_all_source_wins_content): Rewrite.
1723
1724 2019-06-25  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1727         (struct tui_data_window, struct tui_cmd_window): Declare
1728         clear_detail method.
1729         * tui/tui-data.c (tui_source_window::clear_detail)
1730         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1731         methods.
1732         (tui_clear_win_detail): Simplify.
1733
1734 2019-06-25  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui-layout.c (make_source_window, make_disasm_window)
1737         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1738         Return the new window.
1739         (show_source_disasm_command, show_data)
1740         (show_source_or_disasm_and_command): Update.
1741
1742 2019-06-25  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1745         parameter.  Return the new window.
1746         (show_source_disasm_command): Update and remove NULL check.
1747         (show_source_or_disasm_and_command): Update.
1748
1749 2019-06-25  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1752
1753 2019-06-25  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-data.h (struct tui_win_info): Make constructor
1756         protected.  Make destructor virtual.  Add initializers.
1757         (tui_source_window, tui_data_window, tui_cmd_window): New
1758         classes.
1759         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1760         constructor.  Add "type" parameter.
1761         (tui_source_window, tui_data_window, tui_cmd_window): New
1762         constructors.
1763         (tui_alloc_win_info): Instantiate the appropriate subclass.
1764
1765 2019-06-25  Tom Tromey  <tom@tromey.com>
1766
1767         * tui/tui-win.c (tui_resize_all): Use delete.
1768         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1769         destructor.
1770         (tui_free_window): Don't declare.
1771         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1772         Update.
1773
1774 2019-06-25  Tom Tromey  <tom@tromey.com>
1775
1776         * tui/tui-data.h (struct tui_win_info): Add constructor.
1777         * tui/tui-data.c (tui_alloc_win_info): Use new.
1778         (tui_free_window): Use delete.
1779
1780 2019-06-22  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1783         declare.
1784         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1785
1786 2019-06-22  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1789         declare.
1790         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1791
1792 2019-06-22  Tom de Vries  <tdevries@suse.de>
1793
1794         * dwarf2read.c (create_addrmap_from_aranges)
1795         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1796         instead of '%zu'.
1797
1798 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1799
1800         * dwarf2read.h (dwarf2_section_info_def): Remove.
1801         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1802         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1803         std::vector<dwarf2_section_info>.
1804         (struct dwo_file) <~dwo_file>: Remove.
1805         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1806         types field.
1807         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1808         (dwarf2_read_debug_names): Likewise.
1809         (create_debug_types_hash_table): Change parameter type to
1810         array_view, adjust code accordingly.
1811         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1812         (partial_die_info::fixup): Likewise.
1813         (determine_prefix): Likewise.
1814         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1815
1816 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1817
1818         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1819         gdb_bfd_ref_ptr.
1820         <~dwo_file>: Remove call to gdb_bfd_unref.
1821         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1822         gdb_bfd_ref_ptr::get.
1823
1824 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1825
1826         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1827         type to htab_up.
1828         * dwarf2read.c (struct dwo_file): Initialize fields.
1829         <~dwo_file>: New.
1830         (free_dwo_file): Remove, move content to ~dwo_file.
1831         (struct dwo_file_deleter): Remove.
1832         (dwo_file_up>: Remove custom deleter.
1833         (free_dwo_files): Remove.
1834         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1835         dwo_files.
1836         (process_skeletonless_type_units): Call unique_ptr::get.
1837         (allocate_dwo_file_hash_table): Add deleter to created hash
1838         table.  Change return type to htab_up.
1839         (lookup_dwo_file_slot): Don't memset dwo_file, call
1840         unique_ptr::get.
1841         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1842         (create_dwo_unit_in_dwp_v2): Likewise.
1843         (open_and_init_dwo_file): Likewise.
1844         (free_dwo_file_from_slot): Remove.
1845
1846 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1847
1848         * dwarf2read.h (struct dwarf2_section_info) <readin,
1849         is_virtual>: Change type to bool.
1850         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1851         true instead of 1.
1852
1853 2019-06-19  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-data.h (tui_init_content_element): Don't declare.
1856
1857 2019-06-19  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-data.h (tui_init_win_info): Don't declare.
1860
1861 2019-06-19  Tom de Vries  <tdevries@suse.de>
1862
1863         * dwarf2read.h (abstract_to_concrete): Change type to
1864         std::unordered_map<sect_offset, std::vector<sect_offset>,
1865         gdb::hash_enum<sect_offset>>.
1866
1867 2019-06-19  Tom Tromey  <tromey@adacore.com>
1868
1869         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1870         EVAL_AVOID_SIDE_EFFECTS specially.
1871
1872 2019-06-19  Tom Tromey  <tromey@adacore.com>
1873
1874         * source-cache.c (highlighter): New global.
1875         (source_cache::get_source_lines): Create a highlighter on demand.
1876
1877 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1878
1879         * defs.h (deprecated_interactive_hook): Delete declaration.
1880         * interps.c (clear_interpreter_hooks): Remove use of
1881         deprecated_interactive_hook.
1882         * top.c (deprecated_interactive_hook): Delete definition.
1883         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1884
1885 2019-06-18  Tom de Vries  <tdevries@suse.de>
1886
1887         PR gdb/24515
1888         * dwarf2read.h (abstract_to_concrete): Change type from
1889         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1890         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1891         * dwarf2read.c (read_variable): Update.
1892         (dwarf2_fetch_die_loc_sect_off): Update.
1893
1894 2019-06-17  Tom de Vries  <tdevries@suse.de>
1895
1896         PR gdb/24617
1897         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1898         accessing parent[parent_len - 1].
1899
1900 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1901
1902         PR gdb/24364
1903         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1904         call dtrace_process_dof with NULL dof.
1905
1906 2019-06-16  Tom de Vries  <tdevries@suse.de>
1907
1908         PR gdb/24445
1909         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1910
1911 2019-06-16  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1914         (make_all_visible): Use address of member.
1915
1916 2019-06-16  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1919         (tui_free_window, free_content, free_content_elements): Remove
1920         unnecessary cast.
1921         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1922         cast.
1923         * tui/tui-regs.c (tui_show_register_group)
1924         (tui_display_registers_from, tui_display_reg_element_at_line):
1925         Remove unnecessary cast.
1926
1927 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1928
1929         * linux-nat.c (normal_mask): Delete.
1930         (_initialize_linux_nat): Don't initialise normal_mask.
1931
1932 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1933
1934         PR gdb/24445
1935         * dwarf-index-write.h (write_psymtabs_to_index): Add
1936         dwz_basename parameter.
1937         * dwarf-index-write.c (write_gdbindex): Move file writing to
1938         write_gdbindex_1.  Change return type void.
1939         (assert_file_size): Move up, remove filename parameter.
1940         (write_gdbindex_1): New function.
1941         (write_debug_names): Change return type to void, call
1942         assert_file_size.
1943         (struct index_wip_file): New struct.
1944         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1945         file logic to index_wip_file.  Write index for dwz file if
1946         needed.
1947         (save_gdb_index_command): Pass basename of dwz file, if present.
1948         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1949         build-id of dwz file, if present.
1950         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1951         (dwarf2_get_dwz_file): Likewise.
1952         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1953         (dwarf2_get_dwz_file): Likewise.
1954
1955 2019-06-16  Tom Tromey  <tom@tromey.com>
1956
1957         * coffread.c (process_coff_symbol): Use xstrdup.
1958         * value.c (create_internalvar): Use xstrdup.
1959
1960 2019-06-16  Tom Tromey  <tom@tromey.com>
1961
1962         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1963         * breakpoint.c (stopin_command, stopat_command)
1964         (until_break_command, decode_location_default): Remove unnecessary
1965         cast.
1966         * utils.c (subset_compare): Remove unnecessary cast.
1967         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1968         cast.
1969         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1970         cast.
1971         * infcmd.c (path_command): Remove unnecessary cast.
1972         * coffread.c (decode_type): Remove unnecessary cast.
1973         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1974         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1975         * tui/tui-stack.c (tui_show_locator_content)
1976         (tui_show_frame_info): Remove unnecessary cast.
1977         * tui/tui-win.c (tui_scroll_forward_command)
1978         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1979         (parse_scrolling_args): Remove unnecessary cast.
1980         * tui/tui-data.c (init_win_info, tui_del_window)
1981         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1982         (free_content_elements): Remove unnecessary cast.
1983         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1984         unnecessary cast.
1985         * tui/tui-source.c (tui_set_source_content)
1986         (tui_vertical_source_scroll): Remove unnecessary cast.
1987         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1988         cast.
1989         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1990         * tui/tui-regs.c (tui_display_registers_from)
1991         (tui_display_register): Remove unnecessary cast.
1992         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1993         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1994         (make_visible): Remove unnecessary cast.
1995         * tui/tui-winsource.c (tui_erase_source_content)
1996         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1997         unnecessary cast.
1998         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1999         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2000         * stabsread.c (read_type, read_array_type, read_range_type):
2001         Remove unnecessary cast.
2002         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2003         (parse_symbol, parse_type, upgrade_type, parse_external)
2004         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2005         unnecessary cast.
2006         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2007
2008 2019-06-16  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-data.c (tui_alloc_generic_win_info)
2011         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2012         checks.
2013
2014 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2015             Andrew Burgess  <andrew.burgess@embecosm.com>
2016
2017         * f-typeprint.c (f_print_type): Don't return early for not
2018         associated or not allocated types.
2019         (f_type_print_varspec_suffix): Add print_rank parameter and print
2020         ranks of array types in case they dangling.
2021         (f_type_print_base): Add print_rank parameter.
2022
2023 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2024
2025         * NEWS: Mention new MI commands.
2026         * break-catch-throw.c (enum exception_event_kind): Move to
2027         breakpoint.h.
2028         (print_mention_exception_catchpoint): Output text as a single
2029         message.
2030         (catch_exception_command_1): Rename to...
2031         (catch_exception_event): ...this, make non-static, update header
2032         command, and change some parameter types.
2033         (catch_catch_command): Update for changes to
2034         catch_exception_command_1.
2035         (catch_throw_command): Likewise.
2036         (catch_rethrow_command): Likewise.
2037         * breakpoint.c (enum exception_event_kind): Delete.
2038         * breakpoint.h (enum exception_event_kind): Moved here from
2039         break-catch-throw.c.
2040         (catch_exception_event): Declare.
2041         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2042         (mi_cmd_catch_throw): New function.
2043         (mi_cmd_catch_rethrow): New function.
2044         (mi_cmd_catch_catch): New function.
2045         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2046         'catch-catch' entries.
2047         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2048         (mi_cmd_catch_rethrow): Declare.
2049         (mi_cmd_catch_catch): Declare.
2050
2051 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2052
2053         * annotate.c (annotate_source_line): Change return type to void,
2054         update implementation to match.
2055         * annotate.h (annotate_source_line): Change return type to void,
2056         update header comment.
2057         * stack.c (print_frame_info): Don't change what frame information
2058         is printed based on whether annotations are on or not.
2059
2060 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2061
2062         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2063         (annotate_source): Make static.
2064         (annotate_source_line): Moved from source.c and renamed from
2065         identify_source_line.  Update the return type.
2066         * annotate.h (annotate_source): Delete declaration.
2067         (annotate_source_line): Declaration moved from source.h, and
2068         renamed from identify_source_line.  Return type updated.
2069         * source.c (identify_source_line): Moved to annotate.c and renamed
2070         to annotate_source_line.
2071         (info_line_command): Remove check of annotation_level.
2072         * source.h (identify_source_line): Move declaration to annotate.h
2073         and rename to annotate_source_line.
2074         * stack.c: Add 'annotate.h' include.
2075         (print_frame_info): Remove check of annotation_level before
2076         calling annotate_source_line.
2077
2078 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2079
2080         * source-cache.c (source_cache::get_plain_source_lines): Use
2081         open_source_file_with_line_charpos instead of just
2082         open_source_file, remove call to find_source_lines.
2083         (source_cache::get_source_lines): Likewise.
2084         * source.c (find_source_lines): Make static.
2085         (get_filename_and_charpos): Renamed into...
2086         (open_source_file_with_line_charpos): ..this along with changes to
2087         return a scoped_fd, and some other minor clean ups.
2088         (identify_source_line): Use open_source_file_with_line_charpos.
2089         (search_command_helper): Use open_source_file_with_line_charpos
2090         instead of just open_source_file, remove call to
2091         find_source_lines.
2092         * source.h (open_source_file_with_line_charpos): Declare new
2093         function.
2094         (find_source_lines): Delete declaration.
2095
2096 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2097
2098         * source.c (get_filename_and_charpos): Remove fullname
2099         parameter.
2100         (identify_source_line): Update call to get_filename_and_charpos.
2101
2102 2019-06-14  Tom Tromey  <tromey@adacore.com>
2103
2104         PR gdb/24502:
2105         * ui-style.h (skip_ansi_escape): Update comment.
2106         * ui-file.h (class no_terminal_escape_file): New class.
2107         * ui-file.c (no_terminal_escape_file::write)
2108         (no_terminal_escape_file::puts): New methods.
2109         * cli/cli-logging.c (handle_redirections): Use
2110         no_terminal_escape_file.
2111
2112 2019-06-14  Tom Tromey  <tromey@adacore.com>
2113
2114         * NEWS: Move convenience variable news above Python news.
2115
2116 2019-06-14  Tom Tromey  <tom@tromey.com>
2117
2118         * gnulib: Move directory to top-level.
2119         * configure.ac: Don't configure gnulib.
2120         * configure: Rebuild.
2121         * common/common-defs.h: Use new path to gnulib.
2122         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2123         (GNULIB_H): Remove.
2124         (INCGNU): Look in new gnulib location.
2125         (HFILES_NO_SRCDIR): Remove gnulib files.
2126         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2127         (generated_files): Remove GNULIB_H.
2128         ($(LIBGNU), all-lib): Remove targets.
2129         (distclean): Don't mention GNULIB_BUILDDIR.
2130         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2131
2132 2019-06-14  Tom Tromey  <tromey@adacore.com>
2133
2134         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2135         Warn if symbol file does not provide any symbols.
2136
2137 2019-06-14  Tom Tromey  <tromey@adacore.com>
2138
2139         * source.c (find_and_open_source): Respect basenames_may_differ.
2140
2141 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2142
2143         * annotate.c (annotate_breakpoints_invalid): Make use of
2144         scoped_restore_terminal_state.
2145         (annotate_frames_invalid): Likewise.
2146
2147 2019-06-14  Tom Tromey  <tromey@adacore.com>
2148
2149         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2150         allow assignment to an internalvar.
2151
2152 2019-06-14  Tom Tromey  <tromey@adacore.com>
2153
2154         * ada-lex.l: Allow "_" in attribute names.
2155
2156 2019-06-14  Tom Tromey  <tromey@adacore.com>
2157
2158         PR gdb/24653:
2159         * regcache.c (registers_changed): Don't call alloca.
2160         * top.c (execute_command): Don't call alloca.
2161
2162 2019-06-13  Pedro Alves  <palves@redhat.com>
2163
2164         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2165         'expression'.  When parsing an expression, error out if there's
2166         junk after "unlimited".
2167         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2168         (do_set_command): Adjust calls to is_unlimited_literal.
2169
2170 2019-06-13  Pedro Alves  <palves@redhat.com>
2171
2172         * compile/compile.c (make_compile_options_def_group): Add braces
2173         around array_view initializer.
2174         * thread.c (make_thread_apply_all_options_def_group)
2175         (make_thread_apply_all_options_def_group): Likewise.
2176
2177 2019-06-13  Pedro Alves  <palves@redhat.com>
2178
2179         * NEWS (New commands): Mention "maint test-options
2180         require-delimiter", "maint test-options unknown-is-error", "maint
2181         test-options unknown-is-operand" and "maint show
2182         test-options-completion-result".
2183         (New command options, command completion): New section.
2184         (Completion improvements): New section.
2185         Mention that you can abbreviate "unlimited".
2186
2187 2019-06-13  Pedro Alves  <palves@redhat.com>
2188
2189         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2190         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2191         * unittests/cli-utils-selftests.c (test_parse_flags)
2192         (test_parse_flags_qcs): Delete.
2193         (test_cli_utils): Don't call deleted functions.
2194
2195 2019-06-13  Pedro Alves  <palves@redhat.com>
2196
2197         * thread.c: Include "cli/cli-option.h".
2198         (tp_array_compar_ascending): Global.
2199         (tp_array_compar): Delete function.
2200         (tp_array_compar_ascending, tp_array_compar_descending): New
2201         functions.
2202         (ascending_option_def, qcs_flag_option_def)
2203         (thr_qcs_flags_option_defs)
2204         (make_thread_apply_all_options_def_group)
2205         (make_thread_apply_options_def_group): New.
2206         (thread_apply_all_command): Use gdb::option::process_options.
2207         (thread_apply_command_completer)
2208         (thread_apply_all_command_completer): New.
2209         (thread_apply_command): Use gdb::option::process_options.
2210         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2211         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2212         to generate help text of "thread apply".  Adjust "taas"'s help.
2213         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2214         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2215
2216 2019-06-13  Pedro Alves  <palves@redhat.com>
2217
2218         * thread.c (thread_apply_command): Check for invalid TID with
2219         isdigit instead of !isalpha.
2220
2221 2019-06-13  Pedro Alves  <palves@redhat.com>
2222
2223         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2224         (validate_flags_qcs): New.
2225         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2226         (validate_flags_qcs): Declare.
2227         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2228         (make_frame_apply_options_def_group): New.
2229         (frame_apply_command_count): Process options with
2230         gdb::option::process_options.
2231         (frame_apply_completer): New.
2232         (frame_apply_level_completer, frame_apply_all_completer)
2233         (frame_apply_completer): New.
2234         (_initialize_stack): Update help of "frame apply", "frame apply
2235         level", "frame apply all" and "faas" to mention supported options
2236         and install command completers.
2237         * stack.h (frame_apply_all_completer): Declare.
2238         * thread.c: Include "stack.h".
2239         (tfaas_command): Add "--".
2240         (_initialize_thread): Update help "tfaas" to mention supported
2241         options and install command completer.
2242
2243 2019-06-13  Pedro Alves  <palves@redhat.com>
2244
2245         * completer.c (complete_nested_command_line): New.
2246         (gdb_completion_word_break_characters_throw): Add assertion.
2247         * completer.h (complete_nested_command_line): Declare.
2248
2249 2019-06-13  Pedro Alves  <palves@redhat.com>
2250
2251         * stack.c (parse_backtrace_qualifiers): New.
2252         (backtrace_command): Use it.
2253         (backtrace_command_completer): Complete on qualifiers.
2254
2255 2019-06-13  Pedro Alves  <palves@redhat.com>
2256
2257         * frame.c: Include "cli/cli-option.h.
2258         (user_set_backtrace_options): New.
2259         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2260         Delete.
2261         (get_prev_frame): Adjust.
2262         (boolean_option_def, uinteger_option_def)
2263         (set_backtrace_option_defs): New.
2264         (_initialize_frame): Adjust and use
2265         gdb::option::add_setshow_cmds_for_options to install "set
2266         backtrace past-main" and "set backtrace past-entry".
2267         * frame.h: Include "cli/cli-option.h".
2268         (struct frame_print_options): Forward declare.
2269         (print_frame_arguments_all, print_frame_arguments_scalars)
2270         (print_frame_arguments_none): Declare.
2271         (print_entry_values): Delete declaration.
2272         (struct frame_print_options, user_frame_print_options): New.
2273         (struct set_backtrace_options): New.
2274         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2275         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2276         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2277         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2278         (list_args_or_locals): Add frame_print_options parameter.
2279         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2280         * python/py-framefilter.c (enumerate_args): Pass down
2281         USER_FRAME_PRINT_OPTIONS.
2282         * stack.c: Include "cli/cli-option.h".
2283         (print_frame_arguments_all, print_frame_arguments_scalars)
2284         (print_frame_arguments_none): Declare.
2285         (print_raw_frame_arguments, print_entry_values): Delete.
2286         (user_frame_print_options): New.
2287         (boolean_option_def, enum_option_def, frame_print_option_defs):
2288         New.
2289         (struct backtrace_cmd_options): New.
2290         (bt_flag_option_def): New.
2291         (backtrace_command_option_defs): New.
2292         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2293         (print_frame_arg, read_frame_arg, print_frame_args)
2294         (print_frame_info, print_frame): Add frame_print_options parameter
2295         and use it.
2296         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2297         (backtrace_command_1): Add frame_print_options and
2298         backtrace_cmd_options parameters and use them.
2299         (make_backtrace_options_def_group): New.
2300         (backtrace_command): Process command options with
2301         gdb::option::process_options.
2302         (backtrace_command_completer): New.
2303         (_initialize_stack): Extend "backtrace"'s help to mention
2304         supported options.  Install completer for "backtrace".
2305         Install some settings commands with add_setshow_cmds_for_options.
2306
2307 2019-06-13  Pedro Alves  <palves@redhat.com>
2308
2309         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2310         and that "set/show print raw frame-arguments" are now deprecated.
2311
2312         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2313         command.
2314         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2315         * stack.c (_initialize_stack): Install "set/show print
2316         raw-frame-arguments", and deprecate "set/show print raw
2317         frame-arguments".
2318         * valprint.c (_initialize_valprint): Deprecate "set/show print
2319         raw".
2320
2321 2019-06-13  Pedro Alves  <palves@redhat.com>
2322
2323         * compile/compile.c (struct compile_options): New.
2324         (compile_flag_option_def, compile_command_option_defs)
2325         (make_compile_options_def_group): New.
2326         (compile_file_command): Handle options with
2327         gdb::option::process_options.
2328         (compile_file_command_completer): New function.
2329         (compile_code_command): Handle options with
2330         gdb::option::process_options.
2331         (compile_code_command_completer): New function.
2332         (_initialize_compiler): Install completers for "compile code" and
2333         "compile file".  Mention available options in "compile code" and
2334         "compile code"'s help.
2335         * completer.c (advance_to_completion_word): New, factored out from
2336         ...
2337         (advance_to_expression_complete_word_point): ... this.
2338         (advance_to_filename_complete_word_point): New.
2339         * completer.h (advance_to_filename_complete_word_point): New
2340         declaration.
2341
2342 2019-06-13  Pedro Alves  <palves@redhat.com>
2343
2344         * compile/compile.c: Include "cli/cli-option.h".
2345         (compile_print_value): Scope data pointer is now a
2346         value_print_options pointer; adjust.
2347         (compile_print_command): Process options.  Scope data pointer is
2348         now a value_print_options pointer; adjust.
2349         (_initialize_compile): Update "compile print"'s help to include
2350         supported options.  Install a completer for "compile print".
2351         * cp-valprint.c (show_vtblprint, show_objectprint)
2352         (show_static_field_print): Delete.
2353         (_initialize_cp_valprint): Don't install "set print
2354         static-members", "set print vtbl", "set print object" here.
2355         * printcmd.c: Include "cli/cli-option.h" and
2356         "common/gdb_optional.h".
2357         (print_command_parse_format): Rework to fill in a
2358         value_print_options instead of a format_data.
2359         (print_value): Change parameter type from format_data pointer to
2360         value_print_options reference.  Adjust.
2361         (print_command_1): Process options.  Adjust to pass down a
2362         value_print_options.
2363         (print_command_completer): New.
2364         (_initialize_printcmd): Install print_command_completer as
2365         handle_brkchars completer for the "print" command.  Update
2366         "print"'s help to include supported options.
2367         * valprint.c: Include "cli/cli-option.h".
2368         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2369         here from cp-valprint.c.
2370         (boolean_option_def, uinteger_option_def)
2371         (value_print_option_defs, make_value_print_options_def_group):
2372         New.  Use gdb::option::add_setshow_cmds_for_options to install
2373         "set print elements", "set print null-stop", "set print repeats",
2374         "set print pretty", "set print union", "set print array", "set
2375         print address", "set print symbol", "set print array-indexes".
2376         * valprint.h: Include <string> and "cli/cli-option.h".
2377         (make_value_print_options_def_group): Declare.
2378         (print_value): Change parameter type from format_data pointer to
2379         value_print_options reference.
2380         (print_command_completer): Declare.
2381
2382 2019-06-13  Pedro Alves  <palves@redhat.com>
2383
2384         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2385         (COMMON_SFILES): Add maint-test-settings.c.
2386         * cli/cli-decode.c (boolean_enums): New global, factored out from
2387         ...
2388         (add_setshow_boolean_cmd): ... here.
2389         * cli/cli-decode.h (boolean_enums): Declare.
2390         * cli/cli-option.c: New file.
2391         * cli/cli-option.h: New file.
2392         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2393         factored out from ...
2394         (parse_cli_boolean_value(const char *)): ... this.
2395         (is_unlimited_literal): Change parameter type to pointer to
2396         pointer.  Adjust and advance ARG pointer.
2397         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2398         (parse_cli_var_enum): New, factored out from ...
2399         (do_set_command): ... this.  Adjust.
2400         * cli/cli-setshow.h (parse_cli_boolean_value)
2401         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2402         (parse_cli_var_enum): Declare.
2403         * cli/cli-utils.c: Include "cli/cli-option.h".
2404         (get_ulongest): New.
2405         * cli/cli-utils.h (get_ulongest): Declare.
2406         (check_for_argument): New overloads.
2407         * maint-test-options.c: New file.
2408
2409 2019-06-13  Pedro Alves  <palves@redhat.com>
2410
2411         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2412         parse a range if "-" is at the end of the string.
2413
2414 2019-06-13  Pedro Alves  <palves@redhat.com>
2415
2416         * cli/cli-setshow.c (parse_auto_binary_operation)
2417         (parse_cli_boolean_value): Don't allow "o".
2418
2419 2019-06-13  Pedro Alves  <palves@redhat.com>
2420
2421         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2422         * NEWS: Mention maint test-settings KIND.
2423         * maint-test-settings.c: New file.
2424
2425 2019-06-13  Pedro Alves  <palves@redhat.com>
2426
2427         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2428         completer.
2429         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2430         "set" completers.
2431
2432 2019-06-13  Pedro Alves  <palves@redhat.com>
2433
2434         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2435         after item.
2436
2437 2019-06-13  Pedro Alves  <palves@redhat.com>
2438
2439         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2440
2441 2019-06-13  Pedro Alves <palves@redhat.com>
2442
2443         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2444         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2445         call.
2446         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2447         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2448         calls.
2449         (check_for_argument): Skip spaces after argument.
2450
2451 2019-06-13  Pedro Alves  <palves@redhat.com>
2452
2453         * thread.c (thread_apply_command): Adjust TID parsing.
2454         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2455         detected before end of string.
2456         (tid_is_in_list): Error out if LIST is invalid.
2457
2458 2019-06-13  Pedro Alves  <palves@redhat.com>
2459
2460         * completer.c (complete_line_internal_1): Rewind completion word
2461         point.
2462         (completion_tracker::advance_custom_word_point_by): Change
2463         parameter type to int.
2464         * completer.h (completion_tracker::advance_custom_word_point_by):
2465         Likewise.
2466
2467 2019-06-13  Pedro Alves  <palves@redhat.com>
2468
2469         * completer.c (advance_to_completion_word): Handle delimiters.
2470
2471 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2472
2473         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2474
2475 2019-06-11  Tom Tromey  <tom@tromey.com>
2476
2477         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2478         (xmalloc_failed): Move to alloc.c.
2479         * alloc.c: New file.
2480         * Makefile.in (COMMON_SFILES): Add alloc.c.
2481
2482 2019-06-11  Tom Tromey  <tom@tromey.com>
2483
2484         * nat/linux-waitpid.c: Don't include server.h.
2485         (linux_debug): Remove.
2486         (my_waitpid): Update.
2487
2488 2019-06-11  Tom Tromey  <tromey@adacore.com>
2489
2490         * infcall.c (_initialize_infcall): Remove trailing newline from
2491         help.
2492         * user-regs.c (_initialize_user_regs): Remove trailing newline
2493         from help.
2494         * typeprint.c (_initialize_typeprint): Remove trailing newline
2495         from help.
2496         * reverse.c (_initialize_reverse): Remove trailing newlines from
2497         help.
2498         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2499         from help.
2500         * language.c (add_set_language_command): Remove trailing newline
2501         from help.
2502         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2503         help.
2504         * disasm.c (_initialize_disasm): Remove trailing newline from
2505         help.
2506         * top.c (init_main): Remove trailing newline from help.
2507         * interps.c (_initialize_interpreter): Remove trailing newline
2508         from help.
2509         * btrace.c (_initialize_btrace): Remove trailing newlines from
2510         help.
2511         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2512         from help.
2513         * python/python.c (_initialize_python): Remove trailing newline
2514         from help.
2515         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2516         help.
2517         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2518         from help.  Reformat some text.
2519         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2520         from help.
2521         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2522         newline from help.
2523
2524 2019-06-11  Tom Tromey  <tromey@adacore.com>
2525
2526         * darwin-nat.c (darwin_decode_exception_message)
2527         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2528
2529 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * valops.c (value_slice): Check for not allocated or not
2532         associated values.
2533
2534 2019-06-10  Tom de Vries  <tdevries@suse.de>
2535
2536         PR gdb/24618
2537         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2538         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2539         invalid.
2540
2541 2019-06-10  Tom de Vries  <tdevries@suse.de>
2542
2543         PR gdb/24611
2544         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2545         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2546
2547 2019-06-10  Tom de Vries  <tdevries@suse.de>
2548
2549         PR symtab/24545
2550         * symtab.c (struct demangled_name_entry): Add language field.
2551         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2552         static minimal symbol".  Set and use language field.
2553
2554 2019-06-10  Tom Tromey  <tromey@adacore.com>
2555
2556         * ada-lang.c (_initialize_ada_language): Update help text.
2557
2558 2019-06-10  Tom Tromey  <tromey@adacore.com>
2559
2560         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2561         with a newline.
2562         * guile/guile.c (handle_boot_error): Don't end warning with a
2563         newline.
2564         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2565         warning with a newline.
2566         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2567         newline.
2568         (s12z_frame_cache): Likewise.
2569         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2570         a newline.
2571         * solib-svr4.c (disable_probes_interface): Don't end warning with
2572         a newline.
2573         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2574         newline.
2575         * python/python.c (do_finish_initialization): Don't end warning
2576         with a newline.
2577
2578 2019-06-10  Tom Tromey  <tom@tromey.com>
2579
2580         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2581         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2582         gdbpy_enter.
2583
2584 2019-06-10  Tom Tromey  <tromey@adacore.com>
2585
2586         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2587         data.
2588         (elf_new_init): Don't call stabsread_new_init.
2589         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2590         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2591         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2592
2593 2019-06-10  Tom de Vries  <tdevries@suse.de>
2594
2595         PR symtab/16264
2596         PR symtab/24517
2597         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2598
2599 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2600
2601         * source.c (find_and_open_source): Also rewrite relative file
2602         names.
2603
2604 2019-04-26  Amos Bird  <amosbird@gmail.com>
2605
2606         * annotate.c (annotate_thread_exited): Add "thread-exited"
2607         annotation.
2608
2609 2019-06-06  Tom Tromey  <tromey@adacore.com>
2610
2611         * maint.h (class scoped_command_stats): Use
2612         DISABLE_COPY_AND_ASSIGN.
2613         <print_time>: New method.
2614         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2615         print_time.
2616         (scoped_command_stats::print_time): New method.
2617
2618 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2619
2620         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2621         instructions of lengths 6 or 8 bytes.
2622
2623 2019-06-04  Pedro Alves  <palves@redhat.com>
2624
2625         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2626
2627         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2628         * breakpoint.c (condition_completer): Likewise.
2629         * cli/cli-dump.c (scan_expression): Likewise.
2630         * common/filestuff.c (mkdir_recursive): Likewise.
2631         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2632         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2633         (gdb_abspath): Likewise.
2634         * compile/compile-cplus-types.c
2635         (compile_cplus_instance::decl_name): Likewise.
2636         * completer.c (complete_explicit_location):
2637         (signal_completer, reg_or_group_completer_1): Likewise.
2638         * cp-support.c (cp_remove_params_if_any): Likewise.
2639         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2640         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2641         * infcmd.c (strip_bg_char): Likewise.
2642         * linespec.c (copy_token_string): Likewise.
2643         * mi/mi-main.c (output_cores): Likewise.
2644         * psymtab.c (psymtab_search_name):
2645         * symfile.c (test_set_ext_lang_command): Likewise.
2646         * target.c (target_fileio_read_stralloc): Likewise.
2647         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2648         * value.c (complete_internalvar): Likewise.
2649
2650 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2651
2652         Add objfile property to gdb.Type.
2653         * NEWS: Mention Python API addition.
2654         * python/py-type.c (typy_get_objfile): New method.
2655
2656 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2657
2658         * NEWS: Mention the new set|show style [title|highlight].
2659         Mention changes to "show style", "help" and "apropos".
2660
2661 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2662
2663         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2664         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2665         instead of print_help_for_command.
2666         (print_doc_of_command): New function.
2667         (help_list): Add 'apropos -v word' suggestion.
2668         (print_help_for_command): Style the command name using title style.
2669         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2670         (_initialize_cli_cmds): Describe -v in apropos_command help.
2671
2672 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2673
2674         * cli/cli-style.h (cli_style_option): Add name in constructor,
2675         add m_name class member, add constructor with intensity,
2676         add name class function.
2677         (cli_style_option::add_setshow_commands): Remove name argument.
2678         (highlight_style, title_style): New styles.
2679         * cli/cli-style.c (do_show): New function that shows a style
2680         characteristic styling the style name with itself.
2681         (set_style_name): New function.
2682         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2683         Update all callers according to the changes in cli/cli-style.h.
2684         * utils.h (fputs_highlighted): New function.
2685         * utils.c (fputs_highlighted): Likewise.
2686
2687 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2688
2689         * NEWS: Mention new pipe command and new convenience variables.
2690
2691 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2692
2693         * cli/cli-cmds.c (pipe_command): New function.
2694         (_initialize_cli_cmds): Call add_com for pipe_command.
2695         Define | as an alias for pipe.
2696         (exit_status_set_internal_vars): New function.
2697         (shell_escape): Call exit_status_set_internal_vars.
2698         cli/cli-decode.c (find_command_name_length): Recognize | as
2699         a single character command.
2700
2701 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2702
2703         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2704         top.c (execute_command_to_ui_file): New function, mostly a copy
2705         of execute_command_to_string.
2706         (execute_command_to_string): Implement by calling
2707         execute_command_to_ui_file.
2708
2709 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2710
2711         * top.h (saved_command_line): Remove declaration.
2712         * top.c (previous_saved_command_line, previous_repeat_arguments):
2713         New variables.
2714         (saved_command_line): Make static, define together with other
2715         'repeat variables'.
2716         (dont_repeat): Clear repeat_arguments.
2717         (repeat_previous, get_saved_command_line, save_command_line):
2718         New functions.
2719         (gdb_init): Initialize saved_command_line
2720         and previous_saved_command_line.
2721         * main.c (captured_main_1): Remove saved_command_line initialization.
2722         * event-top.c (handle_line_of_input): Update to use
2723         the new 'repeat' related functions instead of direct access to
2724         saved_command_line.
2725         * command.h (repeat_previous, get_saved_command_line,
2726         save_command_line): New declarations.
2727         (dont_repeat): Add comment.
2728
2729 2019-05-30  Tom Tromey  <tromey@adacore.com>
2730
2731         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2732         Fix comment.
2733         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2734
2735 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2736
2737         PR cli/24587
2738         * completer.c (complete): Initialize variable word.
2739
2740 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2741
2742         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2743         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2744         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2745         'body' is NULL to the outter 'if', protecting the '!is_define'
2746         situation as well.
2747
2748 2019-05-29  Tom Tromey  <tromey@adacore.com>
2749
2750         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2751         (dwarf_unknown): New function.
2752         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2753         (dwarf_type_encoding_name): Use dwarf_unknown.
2754
2755 2019-05-29  Tom Tromey  <tromey@adacore.com>
2756
2757         PR c++/20020:
2758         * cp-valprint.c (cp_print_value_fields): Call
2759         cp_print_static_field inside "try".
2760
2761 2019-05-29  Tom Tromey  <tromey@adacore.com>
2762
2763         * inflow.c (struct terminal_info): Add default operator=.
2764         * configure: Rebuild.
2765         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2766         -Wdeprecated-copy-dtor, -Wredundant-move.
2767
2768 2019-05-29  Tom Tromey  <tromey@adacore.com>
2769
2770         * NEWS: Add entry.
2771         * infcmd.c (print_return_value_1): Handle finish_print
2772         option.
2773         (show_print_finish): New function.
2774         (_initialize_infcmd): Add "set/show print finish" commands.
2775         * valprint.c (user_print_options): Initialize new member.
2776         * valprint.h (struct value_print_options) <finish_print>: New
2777         member.
2778
2779 2019-05-28  Tom Tromey  <tromey@adacore.com>
2780
2781         * ada-lang.c (ada_remove_Xbn_suffix)
2782         (find_old_style_renaming_symbol)
2783         (parse_old_style_renaming): Remove.
2784         (ada_find_renaming_symbol): Don't call
2785         find_old_style_renaming_symbol.
2786         (ada_is_renaming_symbol): Rename from
2787         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2788         bool.  Now static.
2789         (ada_read_var_value): Update and simplify.
2790         * ada-exp.y (write_var_or_type): Remove old code.
2791
2792 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2793
2794         * event-top.c: Remove include comment.
2795         * inflow.c (class scoped_ignore_sigttou): Move from here...
2796         * inflow.h (class scoped_ignore_sigttou): ...to here.
2797         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2798         * top.c:  Remove include comment.
2799
2800 2019-05-27  Tom Tromey  <tom@tromey.com>
2801
2802         * NEWS: Fix typo.
2803
2804 2019-05-22  Tom Tromey  <tromey@adacore.com>
2805
2806         * target.c (target_follow_exec): Constify parameter.
2807         * target-delegates.c: Rebuild.
2808         * remote.c (remote_target::follow_exec): Constify parameter.
2809         * infrun.c (follow_exec): Constify parameter.
2810         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2811         (target_follow_exec): Likewise.
2812
2813 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2814
2815         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2816         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2817
2818 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2819
2820         * NEWS: Add debugredirect and testsuite sections.
2821
2822 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2823
2824         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2825         target descriptions using exclusively floating point register name
2826         aliases.
2827
2828 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2829
2830         PR gdb/18644:
2831         * f-lang.c (build_fortran_types): Handle the case where
2832         gdbarch_floatformat_for_type returns a nullptr.
2833
2834 2019-05-21  Tom de Vries  <tdevries@suse.de>
2835
2836         PR cli/24587
2837         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2838
2839 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2840
2841         PR gdb/18644:
2842         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2843         16-byte floats.
2844         * i386-tdep.c (i386_floatformat_for_type): Use
2845         floatformats_ia64_quad for the 16-byte floating point component
2846         within a fortran 32-byte complex number.
2847
2848 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2849
2850         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2851         delete default constructor.
2852         (find_partial_die): Update to return const struct.
2853         (partial_die_parent_scope): Move variable declaration into scope
2854         of its use and change its type to auto.
2855         (guess_partial_die_structure_name): Likewise.
2856         (partial_die_info::fixup): Likewise.
2857
2858 2019-05-17  Tom Tromey  <tromey@adacore.com>
2859
2860         * source.c (find_and_open_source): Remove cast.
2861
2862 2019-05-17  Tom Tromey  <tromey@adacore.com>
2863
2864         * annotate.c (annotate_source): Make "filename" const.
2865         * annotate.h (annotate_source): Use const.
2866
2867 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2868
2869         * disasm.c (set_disassembler_options): Send errors to stderr.
2870
2871 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2872
2873         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2874         (cli_interp_base::set_logging): Check debug_redirect.
2875         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2876         * cli/cli-logging.c (debug_redirect): Add static variable.
2877         (pop_output_files): Add default param.
2878         (handle_redirections): Print debug setting.
2879         (show_logging_command): Likewise.
2880         (_initialize_cli_logging): Add debugredirect command.
2881         * interps.c (current_interp_set_logging): Add debug_redirect
2882         parameter.
2883         * interps.h (set_logging): Add debug_redirect parameter.
2884         (current_interp_set_logging): Likewise.
2885         * mi/mi-common.h: Likewise.
2886         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2887
2888 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2889             Tom Tromey  <tromey@adacore.com>
2890
2891         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2892         directly.
2893         * cli/cli-interp.h (make_logging_output): Remove declaration.
2894         * cli/cli-logging.c (make_logging_output): Remove function.
2895         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2896         directly.
2897         * ui-file.c (tee_file::tee_file): Remove bools.
2898         (tee_file::~tee_file): Remove deletes.
2899         * ui-file.h (tee_file): Remove bools.
2900
2901 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2902
2903         * mi/mi-cmds.h (mi_cmd_complete): New function.
2904         * mi/mi-main.c (mi_cmd_complete): Likewise.
2905         * mi/mi-cmds.c: Define new MI command -complete.
2906         * NEWS: Mention new -complete command.
2907
2908 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2909
2910         * completer.h (complete): New function.
2911         * completer.c (complete): Likewise.
2912         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2913         function defined in completer.h.
2914
2915 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2916
2917         * MAINTAINERS (Write After Approval): Add myself.
2918
2919 2019-05-17  Tom de Vries  <tdevries@suse.de>
2920
2921         PR gdb/24094
2922         * dwarf2read.c (struct cu_partial_die_info): New struct.
2923         (find_partial_die): Return cu_partial_die_info.
2924         (partial_die_parent_scope, guess_partial_die_structure_name)
2925         (partial_die_info::fixup): Handle new return type of find_partial_die.
2926
2927 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2928
2929         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2930         "std::string", simplifying the algorithm.
2931
2932 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2933
2934         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2935         (stap_static_probe_ops::get_probes): Likewise.
2936
2937 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2938
2939         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2940         '-')" and "else if".
2941         (stap_parse_single_operand): Join checks for
2942         "gdbarch_stap_parse_special_token_p" and
2943         "gdbarch_stap_parse_special_token" in the same "if" statement.
2944         Invert check when verifying for operation on register
2945         displacement.
2946
2947 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2948
2949         * stap-probe.c (stap_get_opcode): Update comment.
2950         (stap_get_expected_argument_type): Likewise.
2951         (handle_stap_probe): Likewise.
2952
2953 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2954
2955         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2956         return type to 'bool'.  Adjust comment.  Use 'bool' when
2957         appropriate.
2958         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2959         * stap-probe.c (stap_parse_argument_1): Likewise.
2960         (stap_is_operator): Likewise.
2961         (stap_is_generic_prefix): Likewise.
2962         (stap_is_register_prefix): Likewise.
2963         (stap_is_register_indirection_prefix): Likewise.
2964         (stap_is_integer_prefix): Likewise.
2965         (stap_generic_check_suffix): Likewise.
2966         (stap_check_integer_suffix): Likewise.
2967         (stap_check_register_suffix): Likewise.
2968         (stap_check_register_indirection_suffix): Likewise.
2969         (stap_parse_register_operand): Likewise.
2970         (stap_parse_single_operand): Likewise.
2971         (stap_parse_argument_1): Likewise.
2972         (stap_probe::get_argument_count): Likewise.
2973         (stap_is_operator): Likewise.
2974
2975 2019-05-16  Tom Tromey  <tromey@adacore.com>
2976
2977         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2978         keyword to foreach.
2979
2980 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2981
2982         * linux-thread-db.c (try_thread_db_load_1): Change return type
2983         to bool.
2984         (try_thread_db_load): Likewise.
2985         (try_thread_db_load_from_pdir_1): Likewise.
2986         (try_thread_db_load_from_pdir): Likewise.
2987         (try_thread_db_load_from_sdir): Likewise.
2988         (try_thread_db_load_from_dir): Likewise.
2989         (thread_db_load_search): Likewise.
2990         (has_libpthread): Likewise.
2991         (thread_db_load): Likewise.
2992
2993 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2994
2995         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2996         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2997         NULL, and complain/return if that's the case.
2998
2999 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3000
3001         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3002         (advance, posn, abstract_read_memory): New functions.
3003         [struct mem_read_abstraction]: New struct.
3004         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3005
3006 2019-05-14  Tom Tromey  <tromey@adacore.com>
3007
3008         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3009         value is not lval_memory.
3010
3011 2019-05-14  Tom Tromey  <tromey@adacore.com>
3012
3013         * solib.c (info_sharedlibrary_command): Style the file name.
3014
3015 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3016
3017         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3018         (aarch64_vnv_type): Likewise.
3019         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3020         * common/tdesc.c: Likewise.
3021         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3022         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3023         * features/aarch64-fpu.xml: Add ieee half view.
3024         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3025         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3026         * gdbtypes.h (struct builtin_type): Likewise.
3027         (struct objfile_type): Likewise.
3028
3029 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3030
3031         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3032         typo.
3033         * location.h (string_to_event_location): Likewise.
3034
3035 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3036
3037         GDB 8.3 released.
3038
3039 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3040
3041         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3042         New variable declaration.
3043         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3044         New variable.
3045         (print_one_breakpoint): Use ui_out::test_flags and new global
3046         variable to compute use_fixed_output.
3047         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3048         Remove.
3049         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3050         (mi_multi_location_breakpoint_output_fixed): Remove.
3051         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3052         new variable.
3053         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3054         fix_multi_location_breakpoint_output flag if version >= 3.
3055         * ui-out.h (enum ui_out_flag)
3056         <fix_multi_location_breakpoint_output>: New enumerator.
3057
3058 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3059
3060         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3061
3062 2019-05-10  Tom Tromey  <tromey@adacore.com>
3063
3064         * ada-lang.c (catch_ada_completer): New function.
3065         (_initialize_ada_language): Use it.
3066
3067 2019-05-10  Tom Tromey  <tromey@adacore.com>
3068
3069         * thread.c (print_thread_info): Make "requested_threads" const.
3070         * gdbthread.h (print_thread_info): Make "requested_threads"
3071         const.
3072         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3073         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3074
3075 2019-05-08  Tom Tromey  <tom@tromey.com>
3076
3077         * gdbtypes.c (objfile_type_data): Change type.
3078         (objfile_type, _initialize_gdbtypes): Update.
3079
3080 2019-05-08  Tom Tromey  <tom@tromey.com>
3081
3082         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3083         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3084         (_initialize_dwarf2_frame): Update.
3085
3086 2019-05-08  Tom Tromey  <tom@tromey.com>
3087
3088         * objc-lang.c (objc_objfile_data): Change type.
3089         (find_methods): Update.
3090         (_initialize_objc_lang): Remove.
3091
3092 2019-05-08  Tom Tromey  <tom@tromey.com>
3093
3094         * stabsread.c (rs6000_builtin_type_data): Change type.
3095         (rs6000_builtin_type, _initialize_stabsread): Update.
3096
3097 2019-05-08  Tom Tromey  <tom@tromey.com>
3098
3099         * mips-tdep.c (mips_pdr_data): Remove.
3100         (_initialize_mips_tdep): Update.
3101
3102 2019-05-08  Tom Tromey  <tom@tromey.com>
3103
3104         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3105         (hppa_init_objfile_priv_data, read_unwind_info)
3106         (find_unwind_entry, _initialize_hppa_tdep): Update.
3107
3108 2019-05-08  Tom Tromey  <tom@tromey.com>
3109
3110         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3111         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3112         on obstack.
3113         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3114
3115 2019-05-08  Tom Tromey  <tom@tromey.com>
3116
3117         * mdebugread.c (basic_type_data): Change type.
3118         (basic_type, _initialize_mdebugread): Update.
3119
3120 2019-05-08  Tom Tromey  <tom@tromey.com>
3121
3122         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3123
3124 2019-05-08  Tom Tromey  <tom@tromey.com>
3125
3126         * nto-tdep.c (nto_inferior_data_reg): Change type.
3127         (nto_inferior_data): Update.
3128         (nto_inferior_data_cleanup, nto_new_inferior_data)
3129         (_initialize_nto_tdep): Remove.
3130         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3131
3132 2019-05-08  Tom Tromey  <tom@tromey.com>
3133
3134         * ada-lang.c (struct ada_inferior_data): Add initializers.
3135         (ada_inferior_data): Change type.
3136         (ada_inferior_data_cleanup): Remove.
3137         (get_ada_inferior_data, ada_inferior_exit)
3138         (struct ada_pspace_data): Add initializers, destructor.
3139         (ada_pspace_data_handle): Change type.
3140         (get_ada_pspace_data): Update.
3141         (ada_pspace_data_cleanup): Remove.
3142
3143 2019-05-08  Tom Tromey  <tom@tromey.com>
3144
3145         * coffread.c (struct coff_symfile_info): Add initializers.
3146         (coff_objfile_data_key): Move lower.  Change type.
3147         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3148         Update.
3149         (coff_free_info): Remove.
3150
3151 2019-05-08  Tom Tromey  <tom@tromey.com>
3152
3153         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3154         (fbsd_pspace_data_handle): Move lower.  Change type.
3155         (get_fbsd_pspace_data): Update.
3156         (fbsd_pspace_data_cleanup): Remove.
3157         (_initialize_fbsd_tdep): Update.
3158
3159 2019-05-08  Tom Tromey  <tom@tromey.com>
3160
3161         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3162         (get_ada_tasks_pspace_data): Update.
3163         (ada_tasks_pspace_data_cleanup): Remove.
3164         (_initialize_tasks): Update.
3165         (ada_tasks_inferior_data_handle): Change type.
3166         (get_ada_tasks_inferior_data): Update.
3167         (ada_tasks_inferior_data_cleanup): Remove.
3168         (struct ada_tasks_pspace_data): Add initializers.
3169
3170 2019-05-08  Tom Tromey  <tom@tromey.com>
3171
3172         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3173         * symfile-debug.c (debug_sym_get_probes): Change type.
3174         * stap-probe.c (handle_stap_probe):
3175         (stap_static_probe_ops::get_probes): Change type.
3176         * probe.h (class static_probe_ops) <get_probes>: Change type.
3177         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3178         (parse_probes_in_pspace): Update.
3179         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3180         Update.
3181         (any_static_probe_ops::get_probes): Change type.
3182         * elfread.c (elfread_data): New typedef.
3183         (probe_key): Change type.
3184         (elf_get_probes): Likewise.  Update.
3185         (probe_key_free): Remove.
3186         (_initialize_elfread): Update.
3187         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3188         Change type.
3189         (dtrace_process_dof_probe, dtrace_process_dof)
3190         (dtrace_static_probe_ops::get_probe): Change type.
3191
3192 2019-05-08  Tom Tromey  <tom@tromey.com>
3193
3194         * xcoffread.c (struct xcoff_symfile_info): Rename from
3195         coff_symfile_info.  Add initializers.
3196         (xcoff_objfile_data_key): Move lower.  Change type.
3197         (XCOFF_DATA): Rewrite.
3198         (xcoff_free_info): Remove.
3199         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3200         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3201         (xcoff_initial_scan): Update.
3202
3203 2019-05-08  Tom Tromey  <tom@tromey.com>
3204
3205         * solib-svr4.c (struct svr4_info): Add initializers and
3206         destructor.
3207         <probes_table>: Now an htab_up.
3208         (solib_svr4_pspace_data): Change type.
3209         (free_probes_table): Simplify.
3210         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3211         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3212         (probes_table_remove_objfile_probes, register_solib_event_probe)
3213         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3214         (_initialize_svr4_solib): Update.
3215
3216 2019-05-08  Tom Tromey  <tom@tromey.com>
3217
3218         * remote.c (remote_pspace_data): Change type.
3219         (remote_pspace_data_cleanup): Remove.
3220         (get_remote_exec_file, set_pspace_remote_exec_file)
3221         (_initialize_remote): Update.
3222
3223 2019-05-08  Tom Tromey  <tom@tromey.com>
3224
3225         * breakpoint.c (breakpoint_objfile_key): Change type.
3226         (get_breakpoint_objfile_data): Update.
3227         (free_breakpoint_objfile_data): Remove.
3228         (_initialize_breakpoint): Update.
3229
3230 2019-05-08  Tom Tromey  <tom@tromey.com>
3231
3232         * linux-tdep.c (struct linux_info): Add initializers.
3233         (linux_inferior_data): Move.  Change type.
3234         (invalidate_linux_cache_inf): Update.
3235         (linux_inferior_data_cleanup): Remove.
3236         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3237
3238 2019-05-08  Tom Tromey  <tom@tromey.com>
3239
3240         * auxv.c (auxv_inferior_data): Move.  Change type.
3241         (auxv_inferior_data_cleanup): Remove.
3242         (invalidate_auxv_cache_inf): Rewrite.
3243         (get_auxv_inferior_data, _initialize_auxv): Update.
3244
3245 2019-05-08  Tom Tromey  <tom@tromey.com>
3246
3247         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3248         (symfile_debug_objfile_data_key): Change type.
3249         (symfile_debug_installed, debug_qf_has_symbols)
3250         (debug_qf_find_last_source_symtab)
3251         (debug_qf_forget_cached_source_info)
3252         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3253         (debug_qf_print_stats, debug_qf_dump)
3254         (debug_qf_expand_symtabs_for_function)
3255         (debug_qf_expand_all_symtabs)
3256         (debug_qf_expand_symtabs_with_fullname)
3257         (debug_qf_map_matching_symbols)
3258         (debug_qf_expand_symtabs_matching)
3259         (debug_qf_find_pc_sect_compunit_symtab)
3260         (debug_qf_map_symbol_filenames)
3261         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3262         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3263         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3264         (debug_sym_read_linetable, debug_sym_relocate): Update.
3265         (symfile_debug_free_objfile): Remove.
3266         (install_symfile_debug_logging, _initialize_symfile_debug):
3267         Update.
3268
3269 2019-05-08  Tom Tromey  <tom@tromey.com>
3270
3271         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3272         allocate_on_obstack.
3273         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3274         (get_dwarf2_per_objfile): Update.
3275         (set_dwarf2_per_objfile): Remove.
3276         (dwarf2_has_info, dwarf2_get_section_info): Update.
3277         (dwarf2_free_objfile): Remove.
3278         (_initialize_dwarf2_read): Update.
3279
3280 2019-05-08  Tom Tromey  <tom@tromey.com>
3281
3282         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3283         initializers.
3284         <unsupported_script_warning_printed,
3285         script_not_found_warning_printed>: Now bool.
3286         (auto_load_pspace_data): Change type.
3287         (~auto_load_pspace_info): Rename from
3288         auto_load_pspace_data_cleanup.
3289         (get_auto_load_pspace_data, init_loaded_scripts_info)
3290         (clear_section_scripts, maybe_print_unsupported_script_warning)
3291         (maybe_print_script_not_found_warning, _initialize_auto_load):
3292         Update.
3293
3294 2019-05-08  Tom Tromey  <tom@tromey.com>
3295
3296         * objfiles.c (objfile_pspace_info): Add destructor and
3297         initializers.
3298         (objfiles_pspace_data): Change type.
3299         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3300         (get_objfile_pspace_data): Update.
3301         (objfiles_bfd_data): Change type.
3302         (get_objfile_bfd_data): Update.
3303         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3304
3305 2019-05-08  Tom Tromey  <tom@tromey.com>
3306
3307         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3308         Change type.
3309         (get_catch_syscall_inferior_data): Update.
3310         (catch_syscall_inferior_data_cleanup): Remove.
3311         (_initialize_break_catch_syscall): Update.
3312
3313 2019-05-08  Tom Tromey  <tom@tromey.com>
3314
3315         * inflow.c (struct terminal_info): Add destructor and
3316         initializers.
3317         (inflow_inferior_data): Change type.
3318         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3319         (get_inflow_inferior_data, inflow_inferior_exit)
3320         (swap_terminal_info, _initialize_inflow): Update.
3321
3322 2019-05-08  Tom Tromey  <tom@tromey.com>
3323
3324         * target-dcache.c (target_dcache_cleanup): Remove.
3325         (target_dcache_aspace_key): Change type.
3326         (target_dcache_init_p, target_dcache_invalidate)
3327         (target_dcache_get, target_dcache_get_or_init)
3328         (_initialize_target_dcache): Update.
3329         * dcache.h (struct dcache_deleter): New.
3330
3331 2019-05-08  Tom Tromey  <tom@tromey.com>
3332
3333         * symtab.c (struct symbol_cache): Add destructor and
3334         initializers.
3335         (symbol_cache_key): Move.  Change type.
3336         (make_symbol_cache, free_symbol_cache): Remove.
3337         (get_symbol_cache): Update.
3338         (symbol_cache_cleanup): Remove.
3339         (ALL_PSPACES, symbol_cache_flush)
3340         (maintenance_print_symbol_cache)
3341         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3342         Update.
3343
3344 2019-05-08  Tom Tromey  <tom@tromey.com>
3345
3346         * symtab.c (struct main_info): Add destructor and initializers.
3347         (main_progspace_key): Move.  Change type.
3348         (get_main_info): Update.
3349         (main_info_cleanup): Remove.
3350         (_initialize_symtab): Update.
3351
3352 2019-05-08  Tom Tromey  <tom@tromey.com>
3353
3354         * registry.h (DECLARE_REGISTRY): Define the _key class.
3355
3356 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3357
3358         * NEWS: Merge two 'New commands' sections.
3359
3360 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3361
3362         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3363         parameter and use Ada language definition instead.
3364         (ada_val_print_ptr): Remove unused language parameter.
3365         (ada_val_print_num): Remove language parameter and use Ada language
3366         definition instead.
3367         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3368         parameter.
3369         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3370         parameter and use Ada language definition instead.
3371         (ada_val_print_1): Update all ada_val_print_xxx calls.
3372         Remove language parameter.
3373         (ada_val_print): Update ada_val_print_1 call.
3374
3375 2019-05-08  Tom Tromey  <tromey@adacore.com>
3376
3377         * remote.c (remote_hw_watchpoint_limit)
3378         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3379         Now static.
3380
3381 2019-05-08  Tom Tromey  <tromey@adacore.com>
3382
3383         * maint.c (_initialize_maint_cmds): Move initialization code to
3384         remote.c.
3385         (watchdog, show_watchdog): Move to remote.c.
3386         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3387         "watchdog" static.
3388         (_initialize_remote): Move initialization code from maint.c.
3389         * defs.h (watchdog): Don't declare.
3390
3391 2019-05-08  Tom Tromey  <tromey@adacore.com>
3392
3393         * tui/tui-interp.c: Include main.h.
3394         * interps.c: Include main.h.
3395         * main.h (interpreter_p): Declare.
3396         * defs.h (interpreter_p): Don't declare.
3397
3398 2019-05-08  Tom Tromey  <tromey@adacore.com>
3399
3400         * dwarf2loc.c: Include dwarf2read.h.
3401         * defs.h (read_unsigned_leb128): Don't declare.
3402         * dwarf2read.h (read_unsigned_leb128): Declare.
3403
3404 2019-05-08  Tom Tromey  <tromey@adacore.com>
3405
3406         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3407         method.
3408
3409 2019-05-08  Tom Tromey  <tromey@adacore.com>
3410
3411         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3412         when no wrap column is set.
3413
3414 2019-05-08  Tom Tromey  <tromey@adacore.com>
3415
3416         * c-lang.c (c_get_string): Handle non-C-style arrays.
3417
3418 2019-05-08  Tom Tromey  <tromey@adacore.com>
3419
3420         * typeprint.c (print_offset_data::update): Print the bit offset,
3421         not the number of bits remaining.
3422
3423 2019-05-08  Tom Tromey  <tromey@adacore.com>
3424
3425         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3426         padding at end of comment.
3427
3428 2019-05-08  Tom Tromey  <tromey@adacore.com>
3429
3430         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3431         Compare main types.
3432
3433 2019-05-06  Tom Tromey  <tom@tromey.com>
3434
3435         * common/scoped_mmap.c: Include common-defs.h.
3436         * common/scoped_mmap.h: Don't include config.h.
3437
3438 2019-05-04  Tom Tromey  <tom@tromey.com>
3439
3440         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3441         (struct aarch64_call_info): Add initializers.
3442         <si>: Now a std::vector.
3443         (pass_on_stack, aarch64_push_dummy_call): Update.
3444
3445 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3446             Tom Tromey  <tom@tromey.com>
3447
3448         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3449         (ppc_threads): Now a std::vector.  Now static.
3450         (hwdebug_find_thread_points_by_tid)
3451         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3452         Update.
3453
3454 2019-05-04  Tom Tromey  <tom@tromey.com>
3455
3456         * arc-tdep.c (arc_tdesc_init): Return bool.
3457
3458 2019-05-04  Tom Tromey  <tom@tromey.com>
3459
3460         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3461         Use gdb_assert_not_reached.
3462
3463 2019-05-04  Tom Tromey  <tom@tromey.com>
3464
3465         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3466         "false".
3467
3468 2019-05-04  Tom Tromey  <tom@tromey.com>
3469
3470         * arc-tdep.c (arc_tdesc_init): Use bool.
3471
3472 2019-05-04  Tom Tromey  <tom@tromey.com>
3473
3474         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3475
3476 2019-05-04  Tom Tromey  <tom@tromey.com>
3477
3478         * cli/cli-cmds.c (valid_command_p): Return bool.
3479
3480 2019-05-04  Tom Tromey  <tom@tromey.com>
3481
3482         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3483         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3484
3485 2019-05-04  Raul Tambre  <raul@tambre.ee>
3486
3487         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3488         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3489         operator for comparison.
3490
3491 2019-05-04  Tom Tromey  <tom@tromey.com>
3492
3493         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3494         (lookup_partial_symbol, print_partial_symbols)
3495         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3496         (psymbol_compare): Update.
3497         (add_psymbol_to_bcache): Clear the entire psymbol.
3498         (maintenance_check_psymtabs): Update.
3499         * psympriv.h (struct partial_symbol): Don't derive from
3500         general_symbol_info.
3501         <obj_section, unrelocated_address, address,
3502         set_unrelocated_address>: Update.
3503         <ginfo>: New member.
3504         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3505         (debug_names::write_psymbols): Update.
3506
3507 2019-05-04  Tom de Vries  <tdevries@suse.de>
3508
3509         * contrib/cc-with-tweaks.sh: Support -n arg.
3510
3511 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3512
3513         * corelow.c (core_target::detach): Ensure frame cache and
3514         register caches are cleared.
3515         inferior.c (exit_inferior_1): Likewise.
3516
3517 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3518             Tom Tromey  <tom@tromey.com>
3519
3520         * dictionary.c (collate_pending_symbols_by_language): Remove
3521         "struct" from foreach.
3522         * symtab.c (lookup_global_symbol_from_objfile)
3523         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3524         foreach.
3525         * ser-tcp.c (net_open): Remove "struct" from foreach.
3526         * objfiles.c (objfile_relocate, objfile_rebase)
3527         (objfile_has_symbols): Remove "struct" from foreach.
3528         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3529         from foreach.
3530         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3531         foreach.
3532         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3533         "struct" from foreach.
3534         * ada-lang.c (create_excep_cond_exprs)
3535         (ada_exception_catchpoint_cond_string): Remove "struct" from
3536         foreach.
3537
3538 2019-05-03  Tom Tromey  <tromey@adacore.com>
3539
3540         * ada-exp.y (convert_char_literal): Check suffix of each
3541         enumerator.
3542
3543 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3544
3545         PR ada/21406:
3546         * ada-exp.y (yywrap): Don't define.
3547         * ada-lex.l (%option): Add noyywrap
3548         (yywrap): Remove.
3549
3550 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3551
3552         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3553         _WIN32_WINNT to the XP level, unless already defined to a higher
3554         level.
3555
3556         * unittests/parse-connection-spec-selftests.c:
3557         * ser-tcp.c:
3558         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3559         override.
3560
3561         * symfile.c (find_separate_debug_file): Remove colon from the
3562         drive spec of DOS/Windows file names of the target, so that the
3563         file name produced from DEBUGDIR and the target's directory will
3564         be valid on DOS/Windows systems.
3565
3566 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3567
3568         * rust-lang.c (val_print_struct): Handle printing structures
3569         containing strings.
3570
3571 2019-05-02  Tom Tromey  <tromey@adacore.com>
3572
3573         * valarith.c (_initialize_valarith): Remove.
3574
3575 2019-05-01  Tom Tromey  <tromey@adacore.com>
3576
3577         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3578         bitfields.
3579
3580 2019-05-01  Tom Tromey  <tromey@adacore.com>
3581
3582         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3583         for big-endian copies.
3584
3585 2019-04-30  Ali Tamur  <tamur@google.com>
3586         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3587         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3588         (read_3_bytes): New function.
3589
3590 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3591
3592         * windows-nat.c (main_thread_id): Delete.
3593         (handle_output_debug_string): Replace main_thread_id by
3594         current_event.dwThreadId.
3595         (fake_create_process): Likewise.
3596         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3597         Do not set main_thread_id.
3598         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3599         current_event.dwThreadId.
3600         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3601
3602 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3603
3604         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3605         Use current_event.dwThreadId instead of main_thread_id.
3606
3607 2019-04-30  Tom Tromey  <tromey@adacore.com>
3608
3609         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3610         (create_excep_cond_exprs): Iterate over program spaces.
3611         (ada_exception_catchpoint_cond_string): Examine all minimal
3612         symbols for exception types.
3613
3614 2019-04-30  Tom Tromey  <tromey@adacore.com>
3615
3616         PR c++/24470:
3617         * dwarf2read.c (process_structure_scope): Handle case where type
3618         has template parameters but no symbol was created.
3619
3620 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3621             Chris January  <chris.january@arm.com>
3622
3623         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3624         qualifier.
3625         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3626
3627 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3628
3629         * f-typeprint.c (f_print_type): Update rules for printing
3630         whitespace.
3631         (f_type_print_varspec_suffix): Likewise.
3632
3633 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3634             Chris January  <chris.january@arm.com>
3635
3636         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3637         function arguments.
3638
3639 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3640
3641         * f-lang.c (build_fortran_types): Change name of void type to
3642         lower case.
3643         * f-typeprint.c (f_type_print_base): Print the name of the void
3644         type, rather than a fixed string.
3645         * f-valprint.c (f_decorations): Use lower case void string.
3646
3647 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3648             Chris January  <chris.january@arm.com>
3649
3650         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3651         types for Fortran.
3652
3653 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3654             Chris January  <chris.january@arm.com>
3655             David Lecomber  <david.lecomber@arm.com>
3656
3657         * f-exp.y (BINOP_INTRINSIC): New token.
3658         (exp): New parser rule handling BINOP_INTRINSIC.
3659         (f77_keywords): Add new builtin procedures.
3660         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3661         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3662         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3663         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3664         (print_unop_subexp_f): New function.
3665         (print_binop_subexp_f): New function.
3666         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3667         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3668         (dump_subexp_body_f): Likewise.
3669         (operator_check_f): Likewise.
3670         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3671         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3672
3673 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3674
3675         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3676         UNOP_KIND.
3677         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3678         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3679         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3680         (operator_length_f): New fuction.
3681         (print_subexp_f): New function.
3682         (op_name_f): New function.
3683         (dump_subexp_body_f): New function.
3684         (operator_check_f): New function.
3685         (exp_descriptor_f): Replace standard expression handling functions
3686         with new functions.
3687         * gdb/fortran-operator.def: New file.
3688         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3689         * gdb/std-operator.def: Remove UNOP_KIND.
3690
3691 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3692
3693         * std-operator.def: Remove unbalanced, stray double quote
3694         character.
3695
3696 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3697             Chris January  <chris.january@arm.com>
3698             Daniel Everett  <daniel.everett@arm.com>
3699             Nick Forrington  <nick.forrington@arm.com>
3700             Richard Bunt  <richard.bunt@arm.com>
3701
3702         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3703         of depth when printing anonymous structs or unions.
3704         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3705         Don't print either the top-level value, or the children if the
3706         max-depth is exceeded.
3707         (ppscm_print_children): When printing the key of a map, allow one
3708         extra level of depth.
3709         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3710         print either the top-level value, or the children if the max-depth
3711         is exceeded.
3712         (print_children): When printing the key of a map, allow one extra
3713         level of depth.
3714         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3715         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3716         (user_print_options): Initialise max_depth field.
3717         (val_print_scalar_or_string_type_p): New function.
3718         (val_print): Check to see if the max depth has been reached.
3719         (val_print_check_max_depth): Define new function.
3720         (show_print_max_depth): New function.
3721         (_initialize_valprint): Add 'print max-depth' option.
3722         * valprint.h (struct value_print_options) <max_depth>: New field.
3723         (val_print_check_max_depth): Declare new function.
3724         * NEWS: Document new feature.
3725
3726 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3727
3728         * ada-lang.c (ada_language_defn): Initialise new field.
3729         * c-lang.c (c_is_string_type_p): New function.
3730         (c_language_defn): Initialise new field.
3731         (cplus_language_defn): Initialise new field.
3732         (asm_language_defn): Initialise new field.
3733         (minimal_language_defn): Initialise new field.
3734         * c-lang.h (c_is_string_type_p): Declare new function.
3735         * d-lang.c (d_language_defn): Initialise new field.
3736         * f-lang.c (f_is_string_type_p): New function.
3737         (f_language_defn): Initialise new field.
3738         * go-lang.c (go_is_string_type_p): New function.
3739         (go_language_defn): Initialise new field.
3740         * language.c (default_is_string_type_p): New function.
3741         (unknown_language_defn): Initialise new field.
3742         (auto_language_defn): Initialise new field.
3743         * language.h (struct language_defn) <la_is_string_type_p>: New
3744         member variable.
3745         (default_is_string_type_p): Declare new function.
3746         * m2-lang.c (m2_language_defn): Initialise new field.
3747         * objc-lang.c (objc_language_defn): Initialise new field.
3748         * opencl-lang.c (opencl_language_defn): Initialise new field.
3749         * p-lang.c (pascal_is_string_type_p): New function.
3750         (pascal_language_defn): Initialise new field.
3751         * rust-lang.c (rust_is_string_type_p): New function.
3752         (rust_language_defn): Initialise new field.
3753
3754 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3755
3756         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3757         New field.
3758         * ada-lang.c (ada_language_defn): Initialise new field.
3759         * c-lang.c (c_language_defn): Likewise.
3760         (cplus_language_defn): Likewise.
3761         (asm_language_defn): Likewise.
3762         (minimal_language_defn): Likewise.
3763         * d-lang.c (d_language_defn): Likewise.
3764         * f-lang.c (f_language_defn): Likewise.
3765         * go-lang.c (go_language_defn): Likewise.
3766         * language.c (unknown_language_defn): Likewise.
3767         (auto_language_defn): Likewise.
3768         * m2-lang.c (m2_language_defn): Likewise.
3769         * objc-lang.c (objc_language_defn): Likewise.
3770         * opencl-lang.c (opencl_language_defn): Likewise.
3771         * p-lang.c (pascal_language_defn): Likewise.
3772         * rust-lang.c (rust_language_defn): Likewise.
3773
3774 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3775
3776         * ada-lang.c (ada_is_character_type): Change return type to bool.
3777         (ada_is_string_type): Likewise.
3778         * ada-lang.h (ada_is_character_type): Update declaration
3779         (ada_is_string_type): Likewise.
3780
3781 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3782
3783         Support style in 'frame|thread apply'
3784
3785         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3786         * record.c (record_start, record_stop): Update callers of
3787         execute_command_to_string with false.
3788         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3789         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3790         methods.
3791         (class string_file): New constructor with term_out parameter.
3792         Override methods term_out and can_emit_style_escape.  New member
3793         term_out.
3794         (class stdio_file): Override can_emit_style_escape.
3795         (class tee_file): Override term_out and can_emit_style_escape.
3796         * utils.h (can_emit_style_escape): Remove.
3797         * utils.c (can_emit_style_escape): Likewise.
3798         Update all callers of can_emit_style_escape (SOMESTREAM) to
3799         SOMESTREAM->can_emit_style_escape.
3800         * source-cache.c (source_cache::get_source_lines): Likewise.
3801         * stack.c (frame_apply_command_count): Call execute_command_to_string
3802         passing the term_out characteristic of the current gdb_stdout.
3803         * thread.c (thr_try_catch_cmd): Likewise.
3804         * top.c (execute_command_to_string): pass term_out parameter
3805         to construct the string_file for the command output.
3806         * ui-file.c (term_cli_styling): New function (most code moved
3807         from utils.c can_emit_style_escape).
3808         (string_file::string_file, string_file::can_emit_style_escape,
3809         stdio_file::can_emit_style_escape, tee_file::term_out,
3810         tee_file::can_emit_style_escape): New functions.
3811
3812 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3813
3814         * NEWS: Mention the new set|show may-call-functions.
3815         * infcall.c (may_call_functions_p): New variable.
3816         (show_may_call_functions_p): New function.
3817         (call_function_by_hand_dummy): Throws an error if not
3818         may-call-functions.
3819         (_initialize_infcall): Call add_setshow_boolean_cmd for
3820         may-call-functions.
3821
3822 2019-04-25  Keith Seitz  <keiths@redhat.com>
3823
3824         PR c++/24367
3825         * cp-support.c (inspect_type): Don't attempt substitutions
3826         of symbol with the same name.
3827
3828 2019-04-25  Tom Tromey  <tromey@adacore.com>
3829
3830         PR gdb/24475:
3831         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3832         static.
3833
3834 2019-04-25  Tom Tromey  <tromey@adacore.com>
3835
3836         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3837         rvalue reference.
3838         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3839         (gdb_xml_parser::parse): Use std::move.
3840         * python/python-internal.h (gdbpy_convert_exception): Take a const
3841         reference.
3842         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3843         std::move.
3844         * python/py-utils.c (gdbpy_convert_exception): Take a const
3845         reference.
3846         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3847         Use std::move.
3848         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3849         Use std::move.
3850         * mi/mi-main.c (mi_print_exception): Take a const reference.
3851         * main.c (handle_command_errors): Take a const reference.
3852         * linespec.c (parse_linespec): Use std::move.
3853         * infcall.c (run_inferior_call): Use std::move.
3854         (call_function_by_hand_dummy): Use std::move.
3855         * exec.c (try_open_exec_file): Use std::move.
3856         * exceptions.h (exception_print, exception_fprintf)
3857         (exception_print_same): Update.
3858         * exceptions.c (print_exception, exception_print)
3859         (exception_fprintf, exception_print_same): Change parameters to
3860         const reference.
3861         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3862         * common/new-op.c: Use std::move.
3863         * common/common-exceptions.h (struct gdb_exception): Add move
3864         constructor.
3865         (struct gdb_exception_error, struct gdb_exception_quit, struct
3866         gdb_quit_bad_alloc): Change constructor to move constructor.
3867         (throw_exception): Change parameter to rvalue reference.
3868         * common/common-exceptions.c (throw_exception): Take rvalue
3869         reference.
3870         * cli/cli-interp.c (safe_execute_command): Use std::move.
3871         * breakpoint.c (insert_bp_location, location_to_sals): Use
3872         std::move.
3873
3874 2019-04-25  Tom Tromey  <tromey@adacore.com>
3875
3876         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3877         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3878         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3879         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3880         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3881         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3882         guile/scm-value.c: Use unpack.
3883         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3884         gdbscm_gdb_exception.
3885         (gdbscm_throw_gdb_exception): Likewise.
3886         (struct gdbscm_gdb_exception): New.
3887         (unpack): New function.
3888         (gdbscm_wrap): Use unpack.
3889
3890 2019-04-25  Tom Tromey  <tromey@adacore.com>
3891
3892         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3893         (gdb_rl_callback_handler): Use std::move.
3894         * common/common-exceptions.h (struct gdb_exception): Add move
3895         assignment operator.
3896         (throw_exception_sjlj): Change "exception" to const reference.
3897         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3898         (throw_exception_sjlj): Change "exception" to const reference.
3899
3900 2019-04-25  Tom Tromey  <tromey@adacore.com>
3901
3902         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3903         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3904         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3905         Update.
3906         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3907         Update.
3908         * mi/mi-interp.c (mi_interp::exec): Update.
3909         * linespec.c (parse_linespec): Update.
3910         * infcall.c (run_inferior_call): Update.
3911         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3912         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3913         (gdbscm_lookup_global_symbol): Update.
3914         * guile/scm-param.c (gdbscm_parameter_value): Update.
3915         * guile/scm-frame.c (gdbscm_frame_read_register)
3916         (gdbscm_frame_read_var): Update.
3917         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3918         * exec.c (try_open_exec_file): Update.
3919         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3920         (gdb_rl_callback_handler): Update.
3921         * common/common-exceptions.h (exception_none): Don't declare.
3922         * common/common-exceptions.c (exception_none): Don't define.
3923         (struct catcher) <exception>: Update.
3924         * cli/cli-interp.c (safe_execute_command): Update.
3925         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3926
3927 2019-04-25  Ali Tamur  <tamur@google.com>
3928
3929         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3930         (read_attribute_value): Likewise.
3931         (dwarf2_read_addr_index): Update comment.
3932         (read_str_index): Add DW_FORM_strx.
3933         (dwarf2_string_attr): Likewise.
3934         (dwarf2_const_value_attr): Likewise.
3935         (dump_die_shallow): Likewise.
3936         (dwarf2_fetch_constant_bytes): Likewise.
3937         (skip_form_bytes): Likewise.
3938         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3939
3940 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3941
3942         PR corefiles/11608
3943         PR corefiles/18187
3944         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3945         OFFSET.  Verify if current mapping contains an ELF header.
3946         (linux_find_memory_regions_full): Adjust call to
3947         dump_mapping_p.
3948
3949 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3950             Kang Li <kanglictf@gmail.com>
3951
3952         PR gdb/21600
3953
3954         * dwarf2-frame.c (read_initial_length): Be consistent about using
3955         unsigned representation of length.
3956         (decode_frame_entry_1): Likewise.  Check for wraparound of
3957         end pointer as well as buffer overflow.
3958
3959 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3960
3961         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3962         "vq".
3963
3964 2019-04-24  Tom Tromey  <tromey@adacore.com>
3965
3966         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3967
3968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3969
3970         * s12z-tdep.c (s12z_unwind_pc): Delete.
3971         (s12z_unwind_sp): Delete.
3972         (s12z_gdbarch_init): Don't register deleted functions with
3973         gdbarch.
3974
3975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3976
3977         * rl78-tdep.c (rl78_unwind_sp): Delete.
3978         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3979
3980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3981
3982         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3983         (xstormy16_unwind_pc): Delete.
3984         (xstormy16_dummy_id): Delete.
3985         (xstormy16_gdbarch_init): Don't register deleted functions with
3986         gdbarch.
3987
3988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3989
3990         * vax-tdep.c (vax_unwind_pc): Delete.
3991         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3992
3993 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3994
3995         * v850-tdep.c (v850_unwind_sp): Delete.
3996         (v850_unwind_pc): Delete.
3997         (v850_dummy_id): Delete.
3998         (v850_gdbarch_init): Don't register deleted functions with
3999         gdbarch.
4000
4001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4002
4003         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4004         (tilegx_unwind_pc): Delete.
4005         (tilegx_unwind_dummy_id): Delete.
4006         (tilegx_gdbarch_init): Don't register deleted functions with
4007         gdbarch.
4008
4009 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4010
4011         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4012         (tic6x_dummy_id): Delete.
4013         (tic6x_gdbarch_init): Don't register deleted functions with
4014         gdbarch.
4015
4016 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4017
4018         * sparc-tdep.c (sparc_unwind_pc): Delete.
4019         (sparc32_gdbarch_init): Don't register deleted function with
4020         gdbarch.
4021
4022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4023
4024         * sh-tdep.c (sh_unwind_sp): Delete.
4025         (sh_unwind_pc): Delete.
4026         (sh_dummy_id): Delete.
4027         (sh_gdbarch_init): Don't register deleted functions with
4028         gdbarch.
4029
4030 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4031
4032         * score-tdep.c (score_unwind_sp): Delete.
4033         (score_unwind_pc): Delete.
4034         (score_dummy_id): Delete.
4035         (score_gdbarch_init): Don't register deleted functions with
4036         gdbarch.
4037
4038 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4039
4040         * rx-tdep.c (rx_unwind_pc): Delete.
4041         (rx_unwind_sp): Delete.
4042         (rx_dummy_id): Delete.
4043         (rx_gdbarch_init): Don't register deleted functions with
4044         gdbarch.  Update comment.
4045
4046 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4047
4048         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4049         (rs6000_dummy_id): Delete.
4050         (rs6000_gdbarch_init): Don't register deleted functions with
4051         gdbarch.
4052
4053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4054
4055         * or1k-tdep.c (or1k_dummy_id): Delete.
4056         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4057
4058 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4059
4060         * nios2-tdep.c (nios2_dummy_id): Delete.
4061         (nios2_unwind_sp): Delete.
4062         (nios2_gdbarch_init): Don't register deleted functions with
4063         gdbarch.
4064
4065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4066
4067         * nds32-tdep.c (nds32_dummy_id): Delete.
4068         (nds32_unwind_pc): Delete.
4069         (nds32_unwind_sp): Delete.
4070         (nds32_gdbarch_init): Don't register deleted functions with
4071         gdbarch.
4072
4073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4074
4075         * msp430-tdep.c (msp430_unwind_pc): Delete.
4076         (msp430_unwind_sp): Delete.
4077         (msp430_dummy_id): Delete.
4078         (msp430_gdbarch_init): Don't register deleted functions with
4079         gdbarch.
4080
4081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4082
4083         * moxie-tdep.c (moxie_unwind_sp): Delete.
4084         (moxie_unwind_pc): Delete.
4085         (moxie_dummy_id): Delete.
4086         (moxie_gdbarch_init): Don't register deleted functions with
4087         gdbarch.
4088
4089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4090
4091         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4092         (mn10300_unwind_pc): Delete.
4093         (mn10300_unwind_sp): Delete.
4094         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4095         mn10300_unwind_sp.
4096         (mn10300_frame_unwind_init): Don't register deleted functions with
4097         gdbarch.
4098
4099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4100
4101         * mep-tdep.c (mep_unwind_pc): Delete.
4102         (mep_unwind_sp): Delete.
4103         (mep_dummy_id): Delete.
4104         (mep_gdbarch_init): Don't register deleted functions with
4105         gdbarch.
4106
4107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4108
4109         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4110         (m68hc11_unwind_sp): Delete.
4111         (m68hc11_gdbarch_init): Don't register deleted functions with
4112         gdbarch.
4113
4114 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4115
4116         * m32r-tdep.c (m32r_unwind_sp): Delete.
4117         (m32r_unwind_pc): Delete.
4118         (m32r_dummy_id): Delete.
4119         (m32r_gdbarch_init): Don't register deleted functions with
4120         gdbarch.
4121
4122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4123
4124         * m32c-tdep.c (m32c_unwind_pc): Delete.
4125         (m32c_unwind_sp): Delete.
4126         (m32c_dummy_id): Delete.
4127         (m32c_gdbarch_init): Don't register deleted functions with
4128         gdbarch.
4129
4130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4131
4132         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4133         (lm32_unwind_pc): Delete.
4134         (lm32_dummy_id): Delete.
4135         (lm32_gdbarch_init): Don't register deleted functions with
4136         gdbarch.
4137
4138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4139
4140         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4141         (iq2000_unwind_pc): Delete.
4142         (iq2000_dummy_id): Delete.
4143         (iq2000_gdbarch_init): Don't register deleted functions with
4144         gdbarch.
4145
4146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * nds32-tdep.c (nds32_type_align): Delete.
4149         (nds32_push_dummy_call): Use type_align instead.
4150
4151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4152
4153         * arm-tdep.c (arm_type_align): Only handle vector override case.
4154         (arm_push_dummy_call): Use type_align.
4155         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4156
4157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4160         case.
4161         (pass_on_stack): Use type_align.
4162         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4163         function.
4164
4165 2019-04-23  Tom Tromey  <tromey@adacore.com>
4166
4167         * dwarf2read.c (line_header::file_name_at): Remove unused
4168         overload.
4169
4170 2019-04-23  Tom de Vries  <tdevries@suse.de>
4171
4172         PR gdb/24438
4173         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4174         invocation.
4175
4176
4177 2019-03-27  Ali Tamur  <tamur@google.com>
4178
4179         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4180         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4181         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4182         (dwarf_expr_context::get_addr_index): Likewise
4183         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4184         (symbol_needs_eval_context::get_addr_index): Likewise
4185         (disassemble_dwarf_expression): Add DW_OP_addrx
4186         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4187         (read_cutu_die_from_dwo): Update comment
4188         (skip_one_die): Add DW_FORM_addrx
4189         (read_attribute_value): Likewise
4190         (var_decode_location): Add DW_OP_addrx
4191         (dwarf2_const_value_attr): Add DW_FORM_addrx
4192         (dump_die_shallow): Likewise
4193         (dwarf2_fetch_constant_bytes): Likewise
4194         (decode_locdesc): Add DW_OP_addrx
4195         (skip_form_bytes): Add DW_FORM_addrx
4196
4197 2019-04-22  Ali Tamur  <tamur@google.com>
4198
4199         * MAINTAINERS (Write After Approval): Add self.
4200
4201 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4202
4203         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4204         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4205         (open_symbol_file_object): Likewise.
4206         (svr4_default_sos): Add info parameter.
4207         (svr4_read_so_list): Likewise.
4208         (svr4_current_sos_direct): Adjust functions calls to pass down
4209         info.
4210         (svr4_current_sos_1): Add info parameter.
4211         (svr4_current_sos): Call get_svr4_info, pass info down to
4212         svr4_current_sos_1.
4213         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4214         get_svr4_info.
4215         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4216         get_svr4_info.
4217         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4218         to get_svr4_info.
4219         (probes_table_remove_objfile_probes): Likewise.
4220         (register_solib_event_probe): Add info parameter.
4221         (solist_update_incremental): Pass info parameter down to
4222         svr4_read_so_list.
4223         (disable_probes_interface): Add info parameter.
4224         (svr4_handle_solib_event): Pass current_program_space to
4225         get_svr4_info.  Adjust disable_probes_interface cleanup.
4226         (svr4_create_probe_breakpoints): Add info parameter, pass it
4227         down to register_solib_event_probe.
4228         (svr4_create_solib_event_breakpoints): Add info parameter,
4229         pass it down to svr4_create_probe_breakpoints.
4230         (enable_break): Pass info down to
4231         svr4_create_solib_event_breakpoints.
4232         (svr4_solib_create_inferior_hook): Pass current_program_space to
4233         get_svr4_info.
4234         (svr4_clear_solib): Likewise.
4235
4236 2019-04-22  Pedro Alves  <palves@redhat.com>
4237
4238         * solib-svr4.c (svr4_free_objfile_observer): New.
4239         (probe_and_action::objfile): New field.
4240         (probes_table_htab_remove_objfile_probes)
4241         (probes_table_remove_objfile_probes): New functions.
4242         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4243         in the new probe_and_action.  Don't store the probe in 'lookup'.
4244         (svr4_create_probe_breakpoints): Pass objfile to
4245         register_solib_event_probe.
4246         (_initialize_svr4_solib): Register a free_objfile observer.
4247
4248 2019-04-19  Tom Tromey  <tom@tromey.com>
4249
4250         * common/queue.h: Remove.
4251
4252 2019-04-19  Tom Tromey  <tom@tromey.com>
4253
4254         * event-loop.c: Don't include "common/queue.h".
4255
4256 2019-04-19  Tom Tromey  <tom@tromey.com>
4257
4258         * remote.c (remote_target): Use delete.
4259         * remote-notif.h: Include <list>, not "common/queue.h".
4260         (notif_client_p): Remove typedef.
4261         (remote_notif_state): Add constructor, destructor, initializer.
4262         <notif_queue>: Now a std::list.
4263         (remote_notif_state_xfree): Don't declare.
4264         * remote-notif.c (remote_notif_process, handle_notification)
4265         (remote_notif_state_allocate): Update.
4266         (~remote_notif_state): Rename from remote_notif_state_xfree.
4267
4268 2019-04-19  Tom Tromey  <tom@tromey.com>
4269
4270         * symfile.c (reread_symbols): Update.
4271         * objfiles.c (objfile_register_static_link)
4272         (objfile_lookup_static_link): Update
4273         (~objfile) Don't delete static_links.
4274         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4275
4276 2019-04-19  Tom Tromey  <tom@tromey.com>
4277
4278         * type-stack.h (struct type_stack) <insert>: Constify string.
4279         * type-stack.c (type_stack::insert): Constify string.
4280         * gdbtypes.h (lookup_template_type): Update.
4281         (address_space_name_to_int): Update.
4282         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4283         const.
4284         (lookup_template_type): Make name const.
4285         * c-exp.y: Update rules.
4286         (lex_one_token, classify_name, classify_inner_name)
4287         (c_print_token): Update.
4288         * p-exp.y: Update rules.
4289         (yylex): Update.
4290         * f-exp.y: Update rules.
4291         (yylex): Update.
4292         * d-exp.y: Update rules.
4293         (lex_one_token, classify_name, classify_inner_name): Update.
4294         * parse.c (write_dollar_variable, copy_name): Return std::string.
4295         * parser-defs.h (copy_name): Change return type.
4296         * m2-exp.y: Update rules.
4297         (yylex): Update.
4298         * go-exp.y (lex_one_token): Update.
4299         Update rules.
4300         (classify_unsafe_function, classify_packaged_name)
4301         (classify_name, yylex): Update.
4302
4303 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4304
4305         * configure.ac: add --enable-source-highlight switch.
4306         * configure: Regenerate.
4307         * top.c (print_gdb_version): plumb --enable-source-highlight
4308         status to "show configuration".
4309
4310 2019-04-19  Tom Tromey  <tromey@adacore.com>
4311
4312         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4313         Check ADA_TYPE_P.
4314         (empty_record, ada_template_to_fixed_record_type_1)
4315         (template_to_static_fixed_type)
4316         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4317         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4318         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4319         macros.
4320
4321 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4322
4323         PR symtab/24423:
4324         * source.c (print_source_lines_base): Advance "iter" when a
4325         control character is seen.
4326
4327 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4328
4329         * inferior.h (struct infcall_suspend_state_deleter):
4330         Catch exception in destructor to avoid crash.
4331
4332 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4333
4334         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4335         close to the add_com "shell".
4336
4337 2019-04-18  Tom Tromey  <tromey@adacore.com>
4338
4339         * process-stratum-target.h (class process_stratum_target)
4340         <stratum>: Add "final".
4341
4342 2019-04-17  Tom Tromey  <tromey@adacore.com>
4343
4344         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4345         against nullptr before use.
4346
4347 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4348
4349         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4350
4351 2019-04-17  Jim Wilson  <jimw@sifive.com>
4352             Andrew Burgess  <andrew.burgess@embecosm.com>
4353
4354         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4355         code read might fail, assume 4-byte breakpoint in that case.
4356
4357 2019-04-15  Leszek Swirski  <leszeks@google.com>
4358
4359         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4360         rather than a hand-rolled POD check when checking for forced MEMORY
4361         classification.
4362
4363 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4364
4365         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4366         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4367         function.
4368         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4369         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4370         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4371         declaration.
4372
4373 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4374
4375         * aarch64-linux-nat.c
4376         (aarch64_linux_nat_target::thread_architecture): Add override.
4377         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4378         each VQ.
4379
4380 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4381
4382         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4383
4384 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4385
4386         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4387         target types of size 96-bits, add some additional comments, and
4388         check that the builtin type we found was the correct size.
4389
4390 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4391
4392         * utils.c (prompt_for_continue): Don't restore the styling at the
4393         end, as applied_style has the wrong value.  This fixes styling in
4394         long lists of file names that are interrupted by the "Continue?"
4395         prompt.
4396
4397 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4398
4399         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4400         * c-lang.c (c_language_defn): Likewise.
4401         (cplus_language_defn): Likewise.
4402         (asm_language_defn): Likewise.
4403         (minimal_language_defn): Likewise.
4404         * d-lang.c (d_language_defn): Likewise.
4405         * f-lang.c (f_language_defn): Likewise.
4406         * go-lang.c (go_language_defn): Likewise.
4407         * language.c (unknown_language_defn): Likewise.
4408         (auto_language_defn): Likewise.
4409         * language.h (struct language_defn): Remove la_magic field.
4410         (LANG_MAGIC): Delete.
4411         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4412         * objc-lang.c (objc_language_defn): Likewise.
4413         * opencl-lang.c (opencl_language_defn): Likewise.
4414         * p-lang.c (pascal_language_defn): Likewise.
4415         * rust-lang.c (rust_language_defn): Likewise.
4416
4417 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4418
4419         * riscv-tdep.c (riscv_type_align): New function.
4420         (riscv_type_alignment): Delete.
4421         (riscv_arg_location): Use 'type_align'.
4422         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4423
4424 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4425
4426         * gdbtypes.c (type_align): A struct with no non-static fields also
4427         has alignment of 1.
4428
4429 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4430
4431         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4432         component to 0.
4433         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4434         member.
4435         (riscv_struct_info::analyse): New implementation using new
4436         analyse_inner member function.
4437         (riscv_struct_info::field_offset): New member function.
4438         (riscv_struct_info::m_offsets): New member variable.
4439         (riscv_struct_info::analyse_inner): New private member function,
4440         takes the old implementation of riscv_struct_info::analyse but
4441         extended to track field offsets.
4442         (riscv_call_arg_struct): Update the struct folding special cases
4443         to handle cases where empty C++ structs, which are non-zero
4444         length, are found.
4445         (riscv_arg_location): Initialise the length of each location, a
4446         non-zero length now indicates the location is in use.
4447         (riscv_push_dummy_call): Allow for the first location having a
4448         non-zero offset when setting up arguments.
4449         (riscv_return_value): Likewise, but for return values.
4450
4451 2019-04-11  Tom Tromey  <tromey@adacore.com>
4452
4453         * utils.c (internal_vproblem): Make "msg" const.
4454
4455 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4456
4457         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4458         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4459         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4460         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4461
4462 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4463
4464         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4465         function.
4466         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4467         of amd64_collect_native_gregset.
4468         (amd64_linux_nat_target::store_registers): Likewise.
4469
4470 2019-04-10  Tom Tromey  <tom@tromey.com>
4471
4472         * symtab.c (lookup_global_symbol_from_objfile)
4473         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4474         * objfiles.h (class separate_debug_iterator): New.
4475         (class separate_debug_range): New.
4476         (struct objfile) <separate_debug_objfiles>: New method.
4477         (objfile_separate_debug_iterate): Don't declare.
4478         * objfiles.c (separate_debug_iterator::operator++): Rename from
4479         objfile_separate_debug_iterate.
4480         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4481         iterator.
4482         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4483         iterator.
4484
4485 2019-04-10  Tom Tromey  <tom@tromey.com>
4486
4487         * symfile.c (reread_symbols): Remove old comment.
4488         * objfiles.c (free_all_objfiles): Fix a typo.
4489
4490 2019-04-10  Tom Tromey  <tom@tromey.com>
4491
4492         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4493         * minsyms.c (lookup_minimal_symbol): Use foreach.
4494         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4495         (lookup_minimal_symbol_solib_trampoline): Likewise.
4496         * symfile.c (reread_symbols): Use foreach.
4497
4498 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4499             Tom Tromey  <tromey@adacore.com>
4500
4501         PR rust/24414:
4502         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4503         (rust_lex_int_test): Change "value" to be LONGEST.
4504         (rust_lex_tests): Add test for long integer literal.
4505
4506 2019-04-09  Tom Tromey  <tromey@adacore.com>
4507
4508         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4509         to bool.
4510         (extended_remote_target::attach): Update.
4511         (remote_target::remote_notice_new_inferior): Update.
4512         (remote_target::add_current_inferior_and_thread): Update.
4513         * inferior.c (exit_inferior_1): Use "false".
4514         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4515
4516 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4517
4518         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4519         the "start" command.
4520
4521 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4522
4523         * python/py-inferior.c (infpy_thread_from_thread_handle):
4524         Adjust comments to reflect renaming of thread_from_thread_handle
4525         to thread_from_handle.  Adjust keywords.  Fix type error message.
4526         (inferior_object_methods): Add thread_from_handle.  Retain
4527         thread_from_thread_handle, but mark it as deprecated.
4528
4529 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4530
4531         * gdbthread.h (find_thread_by_handle): Revise declaration.
4532         * thread.c (find_thread_by_handle): Likewise.  Adjust
4533         implementation too.
4534         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4535         support for buffer objects as handles.
4536
4537 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4538
4539         * python/py-infthread.c (thpy_thread_handle): New function.
4540         (thread_object_methods): Register thpy_thread_handle.
4541
4542 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4543
4544         * gdbthread.h (thread_to_thread_handle): Declare.
4545         * thread.c (gdbtypes.h): Include.
4546         (thread_to_thread_handle): New function.
4547
4548         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4549         (target_thread_info_to_thread_handle): Declare.
4550         * target.c (target_thread_info_to_thread_handle): New function.
4551         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4552         * target-delegates.c: Regenerate.
4553
4554         * linux-thread-db.c (class thread_db_target): Add method
4555         thread_info_to_thread_handle.
4556         (thread_db_target::thread_info_to_thread_handle): Define.
4557         * remote.c (class remote_target): Add new method
4558         thread_info_to_thread_handle.
4559         (remote_target::thread_info_to_thread_handle): Define.
4560
4561 2019-04-08  Pedro Alves  <palves@redhat.com>
4562
4563         * common/common-exceptions.c (throw_exception): Don't create
4564         named object to throw; throw directly.
4565         (throw_it): Likewise.  Don't initialize gdb_exception::message
4566         here, with new; pass FMT and AP to the ctor instead.
4567         * common/common-exceptions.h: Include <string>.
4568         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4569         const char *, va_list)): New ctor.  Use std::make_shared.
4570         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4571         errors)): Delete.
4572         (gdb_exception_error::gdb_exception_error(enum errors, const char
4573         *, va_list)): New.
4574         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4575         Add assertion.
4576         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4577         errors)): Delete.
4578         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4579         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4580         Add assertion.
4581
4582 2019-04-08  Tom Tromey  <tom@tromey.com>
4583
4584         * valops.c (value_rtti_indirect_type): Replace throw_exception
4585         with throw.
4586         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4587         with throw.
4588         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4589         throw.
4590         * target.c (target_translate_tls_address): Replace throw_exception
4591         with throw.
4592         * stack.c (frame_apply_command_count): Replace throw_exception
4593         with throw.
4594         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4595         throw.
4596         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4597         with throw.
4598         * rs6000-tdep.c (rs6000_frame_cache)
4599         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4600         * remote.c: Replace throw_exception with throw.
4601         * record-full.c (record_full_message, record_full_wait_1)
4602         (record_full_restore): Replace throw_exception with throw.
4603         * record-btrace.c:
4604         (get_thread_current_frame_id, record_btrace_start_replaying)
4605         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4606         (cmd_record_btrace_start): Replace throw_exception with throw.
4607         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4608         throw.
4609         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4610         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4611         * linespec.c:
4612         (find_linespec_symbols): Replace throw_exception with throw.
4613         * infrun.c (displaced_step_prepare, resume): Replace
4614         throw_exception with throw.
4615         * infcmd.c (post_create_inferior): Replace throw_exception with
4616         throw.
4617         * inf-loop.c (inferior_event_handler): Replace throw_exception
4618         with throw.
4619         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4620         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4621         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4622         (get_prev_frame_always, get_frame_pc_if_available)
4623         (get_frame_address_in_block_if_available, get_frame_language):
4624         Replace throw_exception with throw.
4625         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4626         throw_exception with throw.
4627         * eval.c (fetch_subexp_value, evaluate_var_value)
4628         (evaluate_funcall, evaluate_subexp_standard): Replace
4629         throw_exception with throw.
4630         * dwarf2loc.c (call_site_find_chain)
4631         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4632         Replace throw_exception with throw.
4633         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4634         with throw.
4635         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4636         throw.
4637         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4638         * completer.c (complete_line_internal): Replace throw_exception
4639         with throw.
4640         * compile/compile-object-run.c (compile_object_run): Replace
4641         throw_exception with throw.
4642         * cli/cli-script.c (process_next_line): Replace throw_exception
4643         with throw.
4644         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4645         (btrace_enable, btrace_maint_update_pt_packets): Replace
4646         throw_exception with throw.
4647         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4648         throw_exception with throw.
4649         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4650         throw_exception with throw.
4651         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4652         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4653         * aarch64-tdep.c (aarch64_make_prologue_cache)
4654         (aarch64_make_stub_cache): Replace throw_exception with throw.
4655
4656 2019-04-08  Tom Tromey  <tom@tromey.com>
4657
4658         * common/common-exceptions.c (throw_exception): Rename from
4659         throw_exception_cxx.  Remove old copy.  Make argument const.
4660         (throw_it): Create and throw exception objects directly.
4661         * common/common-exceptions.h (throw_exception): Make argument
4662         const.
4663         (struct gdb_exception_error): Add constructor.
4664         (struct gdb_exception_quit): Add constructor.
4665
4666 2019-04-08  Tom Tromey  <tom@tromey.com>
4667
4668         * common/common-exceptions.h (exception_rethrow): Don't declare.
4669         (TRY_SJLJ): Update comment.
4670         (TRY, CATCH, END_CATCH): Remove.
4671         * common/common-exceptions.c (exception_rethrow): Remove.
4672
4673 2019-04-08  Tom Tromey  <tom@tromey.com>
4674
4675         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4676         Remove.
4677         (gdb_exception_error): Rename from
4678         gdb_exception_RETURN_MASK_ERROR.
4679         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4680         (gdb_quit_bad_alloc): Update.
4681         * aarch64-tdep.c: Update.
4682         * ada-lang.c: Update.
4683         * ada-typeprint.c: Update.
4684         * ada-valprint.c: Update.
4685         * amd64-tdep.c: Update.
4686         * arch-utils.c: Update.
4687         * break-catch-throw.c: Update.
4688         * breakpoint.c: Update.
4689         * btrace.c: Update.
4690         * c-varobj.c: Update.
4691         * cli/cli-cmds.c: Update.
4692         * cli/cli-interp.c: Update.
4693         * cli/cli-script.c: Update.
4694         * common/common-exceptions.c: Update.
4695         * common/new-op.c: Update.
4696         * common/selftest.c: Update.
4697         * compile/compile-c-symbols.c: Update.
4698         * compile/compile-cplus-symbols.c: Update.
4699         * compile/compile-object-load.c: Update.
4700         * compile/compile-object-run.c: Update.
4701         * completer.c: Update.
4702         * corelow.c: Update.
4703         * cp-abi.c: Update.
4704         * cp-support.c: Update.
4705         * cp-valprint.c: Update.
4706         * darwin-nat.c: Update.
4707         * disasm-selftests.c: Update.
4708         * dtrace-probe.c: Update.
4709         * dwarf-index-cache.c: Update.
4710         * dwarf-index-write.c: Update.
4711         * dwarf2-frame-tailcall.c: Update.
4712         * dwarf2-frame.c: Update.
4713         * dwarf2loc.c: Update.
4714         * dwarf2read.c: Update.
4715         * eval.c: Update.
4716         * event-loop.c: Update.
4717         * event-top.c: Update.
4718         * exec.c: Update.
4719         * f-valprint.c: Update.
4720         * fbsd-tdep.c: Update.
4721         * frame-unwind.c: Update.
4722         * frame.c: Update.
4723         * gdbtypes.c: Update.
4724         * gnu-v3-abi.c: Update.
4725         * guile/guile-internal.h: Update.
4726         * guile/scm-block.c: Update.
4727         * guile/scm-breakpoint.c: Update.
4728         * guile/scm-cmd.c: Update.
4729         * guile/scm-disasm.c: Update.
4730         * guile/scm-frame.c: Update.
4731         * guile/scm-lazy-string.c: Update.
4732         * guile/scm-math.c: Update.
4733         * guile/scm-param.c: Update.
4734         * guile/scm-ports.c: Update.
4735         * guile/scm-pretty-print.c: Update.
4736         * guile/scm-symbol.c: Update.
4737         * guile/scm-symtab.c: Update.
4738         * guile/scm-type.c: Update.
4739         * guile/scm-value.c: Update.
4740         * i386-linux-tdep.c: Update.
4741         * i386-tdep.c: Update.
4742         * inf-loop.c: Update.
4743         * infcall.c: Update.
4744         * infcmd.c: Update.
4745         * infrun.c: Update.
4746         * jit.c: Update.
4747         * language.c: Update.
4748         * linespec.c: Update.
4749         * linux-fork.c: Update.
4750         * linux-nat.c: Update.
4751         * linux-tdep.c: Update.
4752         * linux-thread-db.c: Update.
4753         * main.c: Update.
4754         * mi/mi-cmd-break.c: Update.
4755         * mi/mi-cmd-stack.c: Update.
4756         * mi/mi-interp.c: Update.
4757         * mi/mi-main.c: Update.
4758         * objc-lang.c: Update.
4759         * p-valprint.c: Update.
4760         * parse.c: Update.
4761         * ppc-linux-tdep.c: Update.
4762         * printcmd.c: Update.
4763         * python/py-arch.c: Update.
4764         * python/py-breakpoint.c: Update.
4765         * python/py-cmd.c: Update.
4766         * python/py-finishbreakpoint.c: Update.
4767         * python/py-frame.c: Update.
4768         * python/py-framefilter.c: Update.
4769         * python/py-gdb-readline.c: Update.
4770         * python/py-inferior.c: Update.
4771         * python/py-infthread.c: Update.
4772         * python/py-lazy-string.c: Update.
4773         * python/py-linetable.c: Update.
4774         * python/py-objfile.c: Update.
4775         * python/py-param.c: Update.
4776         * python/py-prettyprint.c: Update.
4777         * python/py-progspace.c: Update.
4778         * python/py-record-btrace.c: Update.
4779         * python/py-record.c: Update.
4780         * python/py-symbol.c: Update.
4781         * python/py-type.c: Update.
4782         * python/py-unwind.c: Update.
4783         * python/py-utils.c: Update.
4784         * python/py-value.c: Update.
4785         * python/python.c: Update.
4786         * record-btrace.c: Update.
4787         * record-full.c: Update.
4788         * remote-fileio.c: Update.
4789         * remote.c: Update.
4790         * riscv-tdep.c: Update.
4791         * rs6000-aix-tdep.c: Update.
4792         * rs6000-tdep.c: Update.
4793         * rust-exp.y: Update.
4794         * rust-lang.c: Update.
4795         * s390-tdep.c: Update.
4796         * selftest-arch.c: Update.
4797         * solib-dsbt.c: Update.
4798         * solib-frv.c: Update.
4799         * solib-spu.c: Update.
4800         * solib-svr4.c: Update.
4801         * solib.c: Update.
4802         * sparc64-linux-tdep.c: Update.
4803         * stack.c: Update.
4804         * symfile-mem.c: Update.
4805         * symmisc.c: Update.
4806         * target.c: Update.
4807         * thread.c: Update.
4808         * top.c: Update.
4809         * tracefile-tfile.c: Update.
4810         * tui/tui.c: Update.
4811         * typeprint.c: Update.
4812         * unittests/cli-utils-selftests.c: Update.
4813         * unittests/parse-connection-spec-selftests.c: Update.
4814         * valops.c: Update.
4815         * valprint.c: Update.
4816         * value.c: Update.
4817         * varobj.c: Update.
4818         * windows-nat.c: Update.
4819         * x86-linux-nat.c: Update.
4820         * xml-support.c: Update.
4821
4822 2019-04-08  Tom Tromey  <tom@tromey.com>
4823
4824         * xml-support.c: Use C++ exception handling.
4825         * x86-linux-nat.c: Use C++ exception handling.
4826         * windows-nat.c: Use C++ exception handling.
4827         * varobj.c: Use C++ exception handling.
4828         * value.c: Use C++ exception handling.
4829         * valprint.c: Use C++ exception handling.
4830         * valops.c: Use C++ exception handling.
4831         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4832         handling.
4833         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4834         * typeprint.c: Use C++ exception handling.
4835         * tui/tui.c: Use C++ exception handling.
4836         * tracefile-tfile.c: Use C++ exception handling.
4837         * top.c: Use C++ exception handling.
4838         * thread.c: Use C++ exception handling.
4839         * target.c: Use C++ exception handling.
4840         * symmisc.c: Use C++ exception handling.
4841         * symfile-mem.c: Use C++ exception handling.
4842         * stack.c: Use C++ exception handling.
4843         * sparc64-linux-tdep.c: Use C++ exception handling.
4844         * solib.c: Use C++ exception handling.
4845         * solib-svr4.c: Use C++ exception handling.
4846         * solib-spu.c: Use C++ exception handling.
4847         * solib-frv.c: Use C++ exception handling.
4848         * solib-dsbt.c: Use C++ exception handling.
4849         * selftest-arch.c: Use C++ exception handling.
4850         * s390-tdep.c: Use C++ exception handling.
4851         * rust-lang.c: Use C++ exception handling.
4852         * rust-exp.y: Use C++ exception handling.
4853         * rs6000-tdep.c: Use C++ exception handling.
4854         * rs6000-aix-tdep.c: Use C++ exception handling.
4855         * riscv-tdep.c: Use C++ exception handling.
4856         * remote.c: Use C++ exception handling.
4857         * remote-fileio.c: Use C++ exception handling.
4858         * record-full.c: Use C++ exception handling.
4859         * record-btrace.c: Use C++ exception handling.
4860         * python/python.c: Use C++ exception handling.
4861         * python/py-value.c: Use C++ exception handling.
4862         * python/py-utils.c: Use C++ exception handling.
4863         * python/py-unwind.c: Use C++ exception handling.
4864         * python/py-type.c: Use C++ exception handling.
4865         * python/py-symbol.c: Use C++ exception handling.
4866         * python/py-record.c: Use C++ exception handling.
4867         * python/py-record-btrace.c: Use C++ exception handling.
4868         * python/py-progspace.c: Use C++ exception handling.
4869         * python/py-prettyprint.c: Use C++ exception handling.
4870         * python/py-param.c: Use C++ exception handling.
4871         * python/py-objfile.c: Use C++ exception handling.
4872         * python/py-linetable.c: Use C++ exception handling.
4873         * python/py-lazy-string.c: Use C++ exception handling.
4874         * python/py-infthread.c: Use C++ exception handling.
4875         * python/py-inferior.c: Use C++ exception handling.
4876         * python/py-gdb-readline.c: Use C++ exception handling.
4877         * python/py-framefilter.c: Use C++ exception handling.
4878         * python/py-frame.c: Use C++ exception handling.
4879         * python/py-finishbreakpoint.c: Use C++ exception handling.
4880         * python/py-cmd.c: Use C++ exception handling.
4881         * python/py-breakpoint.c: Use C++ exception handling.
4882         * python/py-arch.c: Use C++ exception handling.
4883         * printcmd.c: Use C++ exception handling.
4884         * ppc-linux-tdep.c: Use C++ exception handling.
4885         * parse.c: Use C++ exception handling.
4886         * p-valprint.c: Use C++ exception handling.
4887         * objc-lang.c: Use C++ exception handling.
4888         * mi/mi-main.c: Use C++ exception handling.
4889         * mi/mi-interp.c: Use C++ exception handling.
4890         * mi/mi-cmd-stack.c: Use C++ exception handling.
4891         * mi/mi-cmd-break.c: Use C++ exception handling.
4892         * main.c: Use C++ exception handling.
4893         * linux-thread-db.c: Use C++ exception handling.
4894         * linux-tdep.c: Use C++ exception handling.
4895         * linux-nat.c: Use C++ exception handling.
4896         * linux-fork.c: Use C++ exception handling.
4897         * linespec.c: Use C++ exception handling.
4898         * language.c: Use C++ exception handling.
4899         * jit.c: Use C++ exception handling.
4900         * infrun.c: Use C++ exception handling.
4901         * infcmd.c: Use C++ exception handling.
4902         * infcall.c: Use C++ exception handling.
4903         * inf-loop.c: Use C++ exception handling.
4904         * i386-tdep.c: Use C++ exception handling.
4905         * i386-linux-tdep.c: Use C++ exception handling.
4906         * guile/scm-value.c: Use C++ exception handling.
4907         * guile/scm-type.c: Use C++ exception handling.
4908         * guile/scm-symtab.c: Use C++ exception handling.
4909         * guile/scm-symbol.c: Use C++ exception handling.
4910         * guile/scm-pretty-print.c: Use C++ exception handling.
4911         * guile/scm-ports.c: Use C++ exception handling.
4912         * guile/scm-param.c: Use C++ exception handling.
4913         * guile/scm-math.c: Use C++ exception handling.
4914         * guile/scm-lazy-string.c: Use C++ exception handling.
4915         * guile/scm-frame.c: Use C++ exception handling.
4916         * guile/scm-disasm.c: Use C++ exception handling.
4917         * guile/scm-cmd.c: Use C++ exception handling.
4918         * guile/scm-breakpoint.c: Use C++ exception handling.
4919         * guile/scm-block.c: Use C++ exception handling.
4920         * guile/guile-internal.h: Use C++ exception handling.
4921         * gnu-v3-abi.c: Use C++ exception handling.
4922         * gdbtypes.c: Use C++ exception handling.
4923         * frame.c: Use C++ exception handling.
4924         * frame-unwind.c: Use C++ exception handling.
4925         * fbsd-tdep.c: Use C++ exception handling.
4926         * f-valprint.c: Use C++ exception handling.
4927         * exec.c: Use C++ exception handling.
4928         * event-top.c: Use C++ exception handling.
4929         * event-loop.c: Use C++ exception handling.
4930         * eval.c: Use C++ exception handling.
4931         * dwarf2read.c: Use C++ exception handling.
4932         * dwarf2loc.c: Use C++ exception handling.
4933         * dwarf2-frame.c: Use C++ exception handling.
4934         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4935         * dwarf-index-write.c: Use C++ exception handling.
4936         * dwarf-index-cache.c: Use C++ exception handling.
4937         * dtrace-probe.c: Use C++ exception handling.
4938         * disasm-selftests.c: Use C++ exception handling.
4939         * darwin-nat.c: Use C++ exception handling.
4940         * cp-valprint.c: Use C++ exception handling.
4941         * cp-support.c: Use C++ exception handling.
4942         * cp-abi.c: Use C++ exception handling.
4943         * corelow.c: Use C++ exception handling.
4944         * completer.c: Use C++ exception handling.
4945         * compile/compile-object-run.c: Use C++ exception handling.
4946         * compile/compile-object-load.c: Use C++ exception handling.
4947         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4948         * compile/compile-c-symbols.c: Use C++ exception handling.
4949         * common/selftest.c: Use C++ exception handling.
4950         * common/new-op.c: Use C++ exception handling.
4951         * cli/cli-script.c: Use C++ exception handling.
4952         * cli/cli-interp.c: Use C++ exception handling.
4953         * cli/cli-cmds.c: Use C++ exception handling.
4954         * c-varobj.c: Use C++ exception handling.
4955         * btrace.c: Use C++ exception handling.
4956         * breakpoint.c: Use C++ exception handling.
4957         * break-catch-throw.c: Use C++ exception handling.
4958         * arch-utils.c: Use C++ exception handling.
4959         * amd64-tdep.c: Use C++ exception handling.
4960         * ada-valprint.c: Use C++ exception handling.
4961         * ada-typeprint.c: Use C++ exception handling.
4962         * ada-lang.c: Use C++ exception handling.
4963         * aarch64-tdep.c: Use C++ exception handling.
4964
4965 2019-04-08  Tom Tromey  <tom@tromey.com>
4966
4967         * xml-support.c (gdb_xml_parser::parse): Update.
4968         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4969         * value.c (show_convenience): Update.
4970         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4971         (test_parse_flags_qcs): Update.
4972         * thread.c (thr_try_catch_cmd): Update.
4973         * target.c (target_translate_tls_address): Update.
4974         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4975         (info_frame_command_core, frame_apply_command_count): Update.
4976         * rust-exp.y (rust_lex_exception_test): Update.
4977         * riscv-tdep.c (riscv_print_one_register_info): Update.
4978         * remote.c (remote_target::enable_btrace): Update.
4979         * record-btrace.c (record_btrace_enable_warn): Update.
4980         * python/py-utils.c (gdbpy_convert_exception): Update.
4981         * printcmd.c (do_one_display, print_variable_and_value): Update.
4982         * mi/mi-main.c (mi_print_exception): Update.
4983         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4984         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4985         * linux-nat.c (linux_nat_target::attach): Update.
4986         * linux-fork.c (class scoped_switch_fork_info): Update.
4987         * infrun.c (displaced_step_prepare): Update.
4988         * infcall.c (call_function_by_hand_dummy): Update.
4989         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4990         * gnu-v3-abi.c (print_one_vtable): Update.
4991         * frame.c (get_prev_frame_always): Update.
4992         * f-valprint.c (info_common_command_for_block): Update.
4993         * exec.c (try_open_exec_file): Update.
4994         * exceptions.c (print_exception, exception_print)
4995         (exception_fprintf, exception_print_same): Update.
4996         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4997         * dwarf-index-cache.c (index_cache::store)
4998         (index_cache::lookup_gdb_index): Update.
4999         * darwin-nat.c (maybe_cache_shell): Update.
5000         * cp-valprint.c (cp_print_value_fields): Update.
5001         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5002         (gcc_cplus_symbol_address): Update.
5003         * compile/compile-c-symbols.c (gcc_convert_symbol)
5004         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5005         * common/selftest.c: Update.
5006         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5007         a std::string.
5008         (exception_try_scope_entry, exception_try_scope_exit): Don't
5009         declare.
5010         (struct exception_try_scope): Remove.
5011         (TRY): Don't use exception_try_scope.
5012         (struct gdb_exception): Add constructor, operator=.
5013         <what>: New method.
5014         (struct gdb_exception_RETURN_MASK_ALL)
5015         (struct gdb_exception_RETURN_MASK_ERROR)
5016         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5017         (struct gdb_quit_bad_alloc): Update.
5018         * common/common-exceptions.c (exception_none): Change
5019         initializer.
5020         (struct catcher) <state, exception>: Initialize inline.
5021         <prev>: Remove member.
5022         (current_catcher): Remove.
5023         (catchers): New global.
5024         (exceptions_state_mc_init): Simplify.
5025         (catcher_pop): Remove.
5026         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5027         (try_scope_depth, exception_try_scope_entry)
5028         (exception_try_scope_exit): Remove.
5029         (throw_exception_sjlj): Update.
5030         (exception_messages, exception_messages_size): Remove.
5031         (throw_it): Simplify.
5032         (gdb_exception_sliced_copy): Remove.
5033         (throw_exception_cxx): Update.
5034         * cli/cli-script.c (script_from_file): Update.
5035         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5036         Update.
5037         * ada-valprint.c (ada_val_print): Update.
5038         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5039         (create_excep_cond_exprs): Update.
5040
5041 2019-04-08  Tom Tromey  <tom@tromey.com>
5042
5043         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5044         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5045         (TRY, CATCH, END_CATCH): Remove some definitions.
5046         * common/common-exceptions.c: Don't use GDB_XCPT.
5047         (catcher_list_size): Remove.
5048         (throw_exception, throw_it): Simplify.
5049
5050 2019-04-05  Tom Tromey  <tom@tromey.com>
5051
5052         Revert the header-sorting patch.
5053         * ft32-tdep.c: Revert.
5054         * frv-tdep.c: Revert.
5055         * frv-linux-tdep.c: Revert.
5056         * frame.c: Revert.
5057         * frame-unwind.c: Revert.
5058         * frame-base.c: Revert.
5059         * fork-child.c: Revert.
5060         * findvar.c: Revert.
5061         * findcmd.c: Revert.
5062         * filesystem.c: Revert.
5063         * filename-seen-cache.h: Revert.
5064         * filename-seen-cache.c: Revert.
5065         * fbsd-tdep.c: Revert.
5066         * fbsd-nat.h: Revert.
5067         * fbsd-nat.c: Revert.
5068         * f-valprint.c: Revert.
5069         * f-typeprint.c: Revert.
5070         * f-lang.c: Revert.
5071         * extension.h: Revert.
5072         * extension.c: Revert.
5073         * extension-priv.h: Revert.
5074         * expprint.c: Revert.
5075         * exec.h: Revert.
5076         * exec.c: Revert.
5077         * exceptions.c: Revert.
5078         * event-top.c: Revert.
5079         * event-loop.c: Revert.
5080         * eval.c: Revert.
5081         * elfread.c: Revert.
5082         * dwarf2read.h: Revert.
5083         * dwarf2read.c: Revert.
5084         * dwarf2loc.c: Revert.
5085         * dwarf2expr.h: Revert.
5086         * dwarf2expr.c: Revert.
5087         * dwarf2-frame.c: Revert.
5088         * dwarf2-frame-tailcall.c: Revert.
5089         * dwarf-index-write.h: Revert.
5090         * dwarf-index-write.c: Revert.
5091         * dwarf-index-common.c: Revert.
5092         * dwarf-index-cache.h: Revert.
5093         * dwarf-index-cache.c: Revert.
5094         * dummy-frame.c: Revert.
5095         * dtrace-probe.c: Revert.
5096         * disasm.h: Revert.
5097         * disasm.c: Revert.
5098         * disasm-selftests.c: Revert.
5099         * dictionary.c: Revert.
5100         * dicos-tdep.c: Revert.
5101         * demangle.c: Revert.
5102         * dcache.h: Revert.
5103         * dcache.c: Revert.
5104         * darwin-nat.h: Revert.
5105         * darwin-nat.c: Revert.
5106         * darwin-nat-info.c: Revert.
5107         * d-valprint.c: Revert.
5108         * d-namespace.c: Revert.
5109         * d-lang.c: Revert.
5110         * ctf.c: Revert.
5111         * csky-tdep.c: Revert.
5112         * csky-linux-tdep.c: Revert.
5113         * cris-tdep.c: Revert.
5114         * cris-linux-tdep.c: Revert.
5115         * cp-valprint.c: Revert.
5116         * cp-support.c: Revert.
5117         * cp-namespace.c: Revert.
5118         * cp-abi.c: Revert.
5119         * corelow.c: Revert.
5120         * corefile.c: Revert.
5121         * continuations.c: Revert.
5122         * completer.h: Revert.
5123         * completer.c: Revert.
5124         * complaints.c: Revert.
5125         * coffread.c: Revert.
5126         * coff-pe-read.c: Revert.
5127         * cli-out.h: Revert.
5128         * cli-out.c: Revert.
5129         * charset.c: Revert.
5130         * c-varobj.c: Revert.
5131         * c-valprint.c: Revert.
5132         * c-typeprint.c: Revert.
5133         * c-lang.c: Revert.
5134         * buildsym.c: Revert.
5135         * buildsym-legacy.c: Revert.
5136         * build-id.h: Revert.
5137         * build-id.c: Revert.
5138         * btrace.c: Revert.
5139         * bsd-uthread.c: Revert.
5140         * breakpoint.h: Revert.
5141         * breakpoint.c: Revert.
5142         * break-catch-throw.c: Revert.
5143         * break-catch-syscall.c: Revert.
5144         * break-catch-sig.c: Revert.
5145         * blockframe.c: Revert.
5146         * block.c: Revert.
5147         * bfin-tdep.c: Revert.
5148         * bfin-linux-tdep.c: Revert.
5149         * bfd-target.c: Revert.
5150         * bcache.c: Revert.
5151         * ax-general.c: Revert.
5152         * ax-gdb.h: Revert.
5153         * ax-gdb.c: Revert.
5154         * avr-tdep.c: Revert.
5155         * auxv.c: Revert.
5156         * auto-load.c: Revert.
5157         * arm-wince-tdep.c: Revert.
5158         * arm-tdep.c: Revert.
5159         * arm-symbian-tdep.c: Revert.
5160         * arm-pikeos-tdep.c: Revert.
5161         * arm-obsd-tdep.c: Revert.
5162         * arm-nbsd-tdep.c: Revert.
5163         * arm-nbsd-nat.c: Revert.
5164         * arm-linux-tdep.c: Revert.
5165         * arm-linux-nat.c: Revert.
5166         * arm-fbsd-tdep.c: Revert.
5167         * arm-fbsd-nat.c: Revert.
5168         * arm-bsd-tdep.c: Revert.
5169         * arch-utils.c: Revert.
5170         * arc-tdep.c: Revert.
5171         * arc-newlib-tdep.c: Revert.
5172         * annotate.h: Revert.
5173         * annotate.c: Revert.
5174         * amd64-windows-tdep.c: Revert.
5175         * amd64-windows-nat.c: Revert.
5176         * amd64-tdep.c: Revert.
5177         * amd64-sol2-tdep.c: Revert.
5178         * amd64-obsd-tdep.c: Revert.
5179         * amd64-obsd-nat.c: Revert.
5180         * amd64-nbsd-tdep.c: Revert.
5181         * amd64-nbsd-nat.c: Revert.
5182         * amd64-nat.c: Revert.
5183         * amd64-linux-tdep.c: Revert.
5184         * amd64-linux-nat.c: Revert.
5185         * amd64-fbsd-tdep.c: Revert.
5186         * amd64-fbsd-nat.c: Revert.
5187         * amd64-dicos-tdep.c: Revert.
5188         * amd64-darwin-tdep.c: Revert.
5189         * amd64-bsd-nat.c: Revert.
5190         * alpha-tdep.c: Revert.
5191         * alpha-obsd-tdep.c: Revert.
5192         * alpha-nbsd-tdep.c: Revert.
5193         * alpha-mdebug-tdep.c: Revert.
5194         * alpha-linux-tdep.c: Revert.
5195         * alpha-linux-nat.c: Revert.
5196         * alpha-bsd-tdep.c: Revert.
5197         * alpha-bsd-nat.c: Revert.
5198         * aix-thread.c: Revert.
5199         * agent.c: Revert.
5200         * addrmap.c: Revert.
5201         * ada-varobj.c: Revert.
5202         * ada-valprint.c: Revert.
5203         * ada-typeprint.c: Revert.
5204         * ada-tasks.c: Revert.
5205         * ada-lang.c: Revert.
5206         * aarch64-tdep.c: Revert.
5207         * aarch64-ravenscar-thread.c: Revert.
5208         * aarch64-newlib-tdep.c: Revert.
5209         * aarch64-linux-tdep.c: Revert.
5210         * aarch64-linux-nat.c: Revert.
5211         * aarch64-fbsd-tdep.c: Revert.
5212         * aarch64-fbsd-nat.c: Revert.
5213         * aarch32-linux-nat.c: Revert.
5214
5215 2019-04-05  Tom Tromey  <tom@tromey.com>
5216
5217         * ft32-tdep.c: Sort headers.
5218         * frv-tdep.c: Sort headers.
5219         * frv-linux-tdep.c: Sort headers.
5220         * frame.c: Sort headers.
5221         * frame-unwind.c: Sort headers.
5222         * frame-base.c: Sort headers.
5223         * fork-child.c: Sort headers.
5224         * findvar.c: Sort headers.
5225         * findcmd.c: Sort headers.
5226         * filesystem.c: Sort headers.
5227         * filename-seen-cache.h: Sort headers.
5228         * filename-seen-cache.c: Sort headers.
5229         * fbsd-tdep.c: Sort headers.
5230         * fbsd-nat.h: Sort headers.
5231         * fbsd-nat.c: Sort headers.
5232         * f-valprint.c: Sort headers.
5233         * f-typeprint.c: Sort headers.
5234         * f-lang.c: Sort headers.
5235         * extension.h: Sort headers.
5236         * extension.c: Sort headers.
5237         * extension-priv.h: Sort headers.
5238         * expprint.c: Sort headers.
5239         * exec.h: Sort headers.
5240         * exec.c: Sort headers.
5241         * exceptions.c: Sort headers.
5242         * event-top.c: Sort headers.
5243         * event-loop.c: Sort headers.
5244         * eval.c: Sort headers.
5245         * elfread.c: Sort headers.
5246         * dwarf2read.h: Sort headers.
5247         * dwarf2read.c: Sort headers.
5248         * dwarf2loc.c: Sort headers.
5249         * dwarf2expr.h: Sort headers.
5250         * dwarf2expr.c: Sort headers.
5251         * dwarf2-frame.c: Sort headers.
5252         * dwarf2-frame-tailcall.c: Sort headers.
5253         * dwarf-index-write.h: Sort headers.
5254         * dwarf-index-write.c: Sort headers.
5255         * dwarf-index-common.c: Sort headers.
5256         * dwarf-index-cache.h: Sort headers.
5257         * dwarf-index-cache.c: Sort headers.
5258         * dummy-frame.c: Sort headers.
5259         * dtrace-probe.c: Sort headers.
5260         * disasm.h: Sort headers.
5261         * disasm.c: Sort headers.
5262         * disasm-selftests.c: Sort headers.
5263         * dictionary.c: Sort headers.
5264         * dicos-tdep.c: Sort headers.
5265         * demangle.c: Sort headers.
5266         * dcache.h: Sort headers.
5267         * dcache.c: Sort headers.
5268         * darwin-nat.h: Sort headers.
5269         * darwin-nat.c: Sort headers.
5270         * darwin-nat-info.c: Sort headers.
5271         * d-valprint.c: Sort headers.
5272         * d-namespace.c: Sort headers.
5273         * d-lang.c: Sort headers.
5274         * ctf.c: Sort headers.
5275         * csky-tdep.c: Sort headers.
5276         * csky-linux-tdep.c: Sort headers.
5277         * cris-tdep.c: Sort headers.
5278         * cris-linux-tdep.c: Sort headers.
5279         * cp-valprint.c: Sort headers.
5280         * cp-support.c: Sort headers.
5281         * cp-namespace.c: Sort headers.
5282         * cp-abi.c: Sort headers.
5283         * corelow.c: Sort headers.
5284         * corefile.c: Sort headers.
5285         * continuations.c: Sort headers.
5286         * completer.h: Sort headers.
5287         * completer.c: Sort headers.
5288         * complaints.c: Sort headers.
5289         * coffread.c: Sort headers.
5290         * coff-pe-read.c: Sort headers.
5291         * cli-out.h: Sort headers.
5292         * cli-out.c: Sort headers.
5293         * charset.c: Sort headers.
5294         * c-varobj.c: Sort headers.
5295         * c-valprint.c: Sort headers.
5296         * c-typeprint.c: Sort headers.
5297         * c-lang.c: Sort headers.
5298         * buildsym.c: Sort headers.
5299         * buildsym-legacy.c: Sort headers.
5300         * build-id.h: Sort headers.
5301         * build-id.c: Sort headers.
5302         * btrace.c: Sort headers.
5303         * bsd-uthread.c: Sort headers.
5304         * breakpoint.h: Sort headers.
5305         * breakpoint.c: Sort headers.
5306         * break-catch-throw.c: Sort headers.
5307         * break-catch-syscall.c: Sort headers.
5308         * break-catch-sig.c: Sort headers.
5309         * blockframe.c: Sort headers.
5310         * block.c: Sort headers.
5311         * bfin-tdep.c: Sort headers.
5312         * bfin-linux-tdep.c: Sort headers.
5313         * bfd-target.c: Sort headers.
5314         * bcache.c: Sort headers.
5315         * ax-general.c: Sort headers.
5316         * ax-gdb.h: Sort headers.
5317         * ax-gdb.c: Sort headers.
5318         * avr-tdep.c: Sort headers.
5319         * auxv.c: Sort headers.
5320         * auto-load.c: Sort headers.
5321         * arm-wince-tdep.c: Sort headers.
5322         * arm-tdep.c: Sort headers.
5323         * arm-symbian-tdep.c: Sort headers.
5324         * arm-pikeos-tdep.c: Sort headers.
5325         * arm-obsd-tdep.c: Sort headers.
5326         * arm-nbsd-tdep.c: Sort headers.
5327         * arm-nbsd-nat.c: Sort headers.
5328         * arm-linux-tdep.c: Sort headers.
5329         * arm-linux-nat.c: Sort headers.
5330         * arm-fbsd-tdep.c: Sort headers.
5331         * arm-fbsd-nat.c: Sort headers.
5332         * arm-bsd-tdep.c: Sort headers.
5333         * arch-utils.c: Sort headers.
5334         * arc-tdep.c: Sort headers.
5335         * arc-newlib-tdep.c: Sort headers.
5336         * annotate.h: Sort headers.
5337         * annotate.c: Sort headers.
5338         * amd64-windows-tdep.c: Sort headers.
5339         * amd64-windows-nat.c: Sort headers.
5340         * amd64-tdep.c: Sort headers.
5341         * amd64-sol2-tdep.c: Sort headers.
5342         * amd64-obsd-tdep.c: Sort headers.
5343         * amd64-obsd-nat.c: Sort headers.
5344         * amd64-nbsd-tdep.c: Sort headers.
5345         * amd64-nbsd-nat.c: Sort headers.
5346         * amd64-nat.c: Sort headers.
5347         * amd64-linux-tdep.c: Sort headers.
5348         * amd64-linux-nat.c: Sort headers.
5349         * amd64-fbsd-tdep.c: Sort headers.
5350         * amd64-fbsd-nat.c: Sort headers.
5351         * amd64-dicos-tdep.c: Sort headers.
5352         * amd64-darwin-tdep.c: Sort headers.
5353         * amd64-bsd-nat.c: Sort headers.
5354         * alpha-tdep.c: Sort headers.
5355         * alpha-obsd-tdep.c: Sort headers.
5356         * alpha-nbsd-tdep.c: Sort headers.
5357         * alpha-mdebug-tdep.c: Sort headers.
5358         * alpha-linux-tdep.c: Sort headers.
5359         * alpha-linux-nat.c: Sort headers.
5360         * alpha-bsd-tdep.c: Sort headers.
5361         * alpha-bsd-nat.c: Sort headers.
5362         * aix-thread.c: Sort headers.
5363         * agent.c: Sort headers.
5364         * addrmap.c: Sort headers.
5365         * ada-varobj.c: Sort headers.
5366         * ada-valprint.c: Sort headers.
5367         * ada-typeprint.c: Sort headers.
5368         * ada-tasks.c: Sort headers.
5369         * ada-lang.c: Sort headers.
5370         * aarch64-tdep.c: Sort headers.
5371         * aarch64-ravenscar-thread.c: Sort headers.
5372         * aarch64-newlib-tdep.c: Sort headers.
5373         * aarch64-linux-tdep.c: Sort headers.
5374         * aarch64-linux-nat.c: Sort headers.
5375         * aarch64-fbsd-tdep.c: Sort headers.
5376         * aarch64-fbsd-nat.c: Sort headers.
5377         * aarch32-linux-nat.c: Sort headers.
5378
5379 2019-04-04  Tom Tromey  <tom@tromey.com>
5380
5381         * varobj.c (varobj_create): Update.
5382         * rust-exp.y (struct rust_parser) <update_innermost_block,
5383         lookup_symbol>: New methods.
5384         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5385         Rename.
5386         (rust_parser::rust_lookup_type)
5387         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5388         * printcmd.c (display_command, do_one_display): Update.
5389         * parser-defs.h (struct parser_state) <parser_state>: Add
5390         "tracker" parameter.
5391         (block_tracker): New member.
5392         (class innermost_block_tracker) <innermost_block_tracker>: Add
5393         "types" parameter.
5394         <reset>: Remove method.
5395         (innermost_block): Don't declare.
5396         (null_post_parser): Update.
5397         * parse.c (innermost_block): Remove global.
5398         (write_dollar_variable): Update.
5399         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5400         Remove "tracker_types" parameter.
5401         (parse_expression): Add "tracker" parameter.
5402         (parse_expression_for_completion): Update.
5403         (null_post_parser): Add "tracker" parameter.
5404         * p-exp.y: Update rules.
5405         * m2-exp.y: Update rules.
5406         * language.h (struct language_defn) <la_post_parser>: Add
5407         "tracker" parameter.
5408         * go-exp.y: Update rules.
5409         * f-exp.y: Update rules.
5410         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5411         parameter.
5412         * d-exp.y: Update rules.
5413         * c-exp.y: Update rules.
5414         * breakpoint.c (set_breakpoint_condition): Create an
5415         innermost_block_tracker.
5416         (watch_command_1): Likewise.
5417         * ada-lang.c (resolve): Add "tracker" parameter.
5418         (resolve_subexp): Likewise.
5419         * ada-exp.y (write_var_from_sym): Update.
5420
5421 2019-04-04  Tom Tromey  <tom@tromey.com>
5422
5423         * type-stack.h: New file.
5424         * type-stack.c: New file.
5425         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5426         type-stack.h.
5427         (insert_into_type_stack, insert_type, push_type, push_type_int)
5428         (insert_type_address_space, pop_type, pop_type_int)
5429         (pop_typelist, pop_type_stack, append_type_stack)
5430         (push_type_stack, get_type_stack, push_typelist)
5431         (follow_type_instance_flags, follow_types): Don't declare.
5432         * parse.c (type_stack): Remove global.
5433         (parse_exp_in_context): Update.
5434         (insert_into_type_stack, insert_type, push_type, push_type_int)
5435         (insert_type_address_space, pop_type, pop_type_int)
5436         (pop_typelist, pop_type_stack, append_type_stack)
5437         (push_type_stack, get_type_stack, push_typelist)
5438         (follow_type_instance_flags, follow_types): Remove (moved to
5439         type-stack.c).
5440         * f-exp.y (type_stack): New global.
5441         Update rules.
5442         (push_kind_type, f_parse): Update.
5443         * d-exp.y (type_stack): New global.
5444         Update rules.
5445         (d_parse): Update.
5446         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5447         Update rules.
5448         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5449         (HFILES_NO_SRCDIR): Add type-stack.h.
5450
5451 2019-04-04  Tom Tromey  <tom@tromey.com>
5452
5453         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5454         (rust_parser::convert_ast_to_expression, rust_parse)
5455         (rust_lex_test_completion, rust_lex_tests): Update.
5456         * parser-defs.h (struct expr_completion_state): New.
5457         (struct parser_state) <parser_state>: Add completion parameter.
5458         <mark_struct_expression, mark_completion_tag>: New methods.
5459         <parse_completion, m_completion_state>: New members.
5460         (prefixify_expression, null_post_parser): Update.
5461         (mark_struct_expression, mark_completion_tag): Don't declare.
5462         * parse.c (parse_completion, expout_last_struct)
5463         (expout_tag_completion_type, expout_completion_name): Remove
5464         globals.
5465         (parser_state::mark_struct_expression)
5466         (parser_state::mark_completion_tag): Now methods.
5467         (prefixify_expression): Add last_struct parameter.
5468         (prefixify_subexp): Likewise.
5469         (parse_exp_1): Update.
5470         (parse_exp_in_context): Add cstate parameter.  Update.
5471         (parse_expression_for_completion): Create an
5472         expr_completion_state.
5473         (null_post_parser): Add "completion" parameter.
5474         * p-exp.y: Update rules.
5475         (yylex): Update.
5476         * language.h (struct language_defn) <la_post_parser>: Add
5477         "completing" parameter.
5478         * go-exp.y: Update rules.
5479         (lex_one_token): Update.
5480         * expression.h (parse_completion): Don't declare.
5481         * d-exp.y: Update rules.
5482         (lex_one_token): Update rules.
5483         * c-exp.y: Update rules.
5484         (lex_one_token): Update.
5485         * ada-lang.c (resolve): Add "parse_completion" parameter.
5486         (resolve_subexp): Likewise.
5487         (ada_resolve_function): Likewise.
5488
5489 2019-04-04  Tom Tromey  <tom@tromey.com>
5490
5491         * parser-defs.h (struct parser_state) <start_arglist,
5492         end_arglist>: New methods.
5493         <arglist_len, m_funcall_chain>: New members.
5494         (arglist_len, start_arglist, end_arglist): Don't declare.
5495         * parse.c (arglist_len, funcall_chain): Remove global.
5496         (start_arglist, end_arglist): Remove functions.
5497         (parse_exp_in_context): Update.
5498         * p-exp.y: Update rules.
5499         * m2-exp.y: Update rules.
5500         * go-exp.y: Update rules.
5501         * f-exp.y: Update rules.
5502         * d-exp.y: Update rules.
5503         * c-exp.y: Update rules.
5504
5505 2019-04-04  Tom Tromey  <tom@tromey.com>
5506
5507         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5508         lex_operator, push_back>: New methods.
5509         Update all rules.
5510         (rust_parser::lex_hex, lex_escape): Rename and update.
5511         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5512         (rust_parser::lex_operator): Rename and update.
5513         (rust_parser::lex_number, rustyylex, rustyyerror)
5514         (rust_lex_test_init, rust_lex_test_sequence)
5515         (rust_lex_test_push_back, rust_lex_tests): Update.
5516         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5517         parameter.
5518         <lexptr, prev_lexptr>: New members.
5519         (lexptr, prev_lexptr): Don't declare.
5520         * parse.c (lexptr, prev_lexptr): Remove globals.
5521         (parse_exp_in_context): Update.
5522         * p-exp.y (yylex, yyerror): Update.
5523         * m2-exp.y (parse_number, yylex, yyerror): Update.
5524         * go-exp.y (lex_one_token, yyerror): Update.
5525         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5526         * d-exp.y (lex_one_token, yyerror): Update.
5527         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5528         (lex_one_token, yyerror): Update.
5529         * ada-lex.l (YY_INPUT): Update.
5530         (rewind_to_char): Update.
5531         * ada-exp.y (yyerror): Update.
5532
5533 2019-04-04  Tom Tromey  <tom@tromey.com>
5534
5535         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5536         * parser-defs.h (struct parser_state) <parser_state>: Add new
5537         parameter.
5538         <comma_terminates>: New member.
5539         (comma_terminates): Don't declare global.
5540         * parse.c (comma_terminates): Remove global.
5541         (parse_exp_in_context): Update.
5542         * p-exp.y (yylex): Update.
5543         * m2-exp.y (yylex): Update.
5544         * go-exp.y (lex_one_token): Update.
5545         * f-exp.y (yylex): Update.
5546         * d-exp.y (lex_one_token): Update.
5547         * c-exp.y (lex_one_token): Update.
5548         * ada-lex.l: Update.
5549
5550 2019-04-04  Tom Tromey  <tom@tromey.com>
5551
5552         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5553         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5554         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5555         * parser-defs.h (paren_depth): Don't declare.
5556         * parse.c (paren_depth): Remove global.
5557         (parse_exp_in_context): Update.
5558         * p-exp.y (paren_depth): New global.
5559         (pascal_parse): Initialize it.
5560         * m2-exp.y (paren_depth): New global.
5561         (m2_parse): Initialize it.
5562         * go-exp.y (paren_depth): New global.
5563         (go_parse): Initialize it.
5564         * f-exp.y (paren_depth): New global.
5565         (f_parse): Initialize it.
5566         * d-exp.y (paren_depth): New global.
5567         (d_parse): Initialize it.
5568         * c-exp.y (paren_depth): New global.
5569         (c_parse): Initialize it.
5570         * ada-lex.l (paren_depth): New global.
5571         (lexer_init): Initialize it.
5572
5573 2019-04-04  Tom Tromey  <tom@tromey.com>
5574
5575         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5576         (rust_parser::convert_ast_to_type)
5577         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5578         * parser-defs.h (struct parser_state) <parser_state>: Add
5579         parameters.  Initialize new members.
5580         <expression_context_block, expression_context_pc>: New members.
5581         * parse.c (expression_context_block, expression_context_pc):
5582         Remove globals.
5583         (parse_exp_in_context): Update.
5584         * p-exp.y: Update all rules.
5585         (yylex): Update.
5586         * m2-exp.y: Update all rules.
5587         (yylex): Update.
5588         * go-exp.y (yylex): Update.
5589         * f-exp.y (yylex): Update.
5590         * d-exp.y: Update all rules.
5591         (yylex): Update.
5592         * c-exp.y: Update all rules.
5593         (lex_one_token, classify_name, yylex, c_parse): Update.
5594         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5595
5596 2019-04-04  Tom Tromey  <tom@tromey.com>
5597
5598         * gdbarch.h, gdbarch.c: Rebuild.
5599         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5600         * stap-probe.h:
5601         (struct stap_parse_info): Replace "parser_state" with
5602         "expr_builder".
5603         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5604         (parser_state): New class.
5605         * parse.c (expr_builder): Rename.
5606         (expr_builder::release): Rename.
5607         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5608         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5609         (write_exp_elt_longcst, write_exp_elt_floatcst)
5610         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5611         (write_exp_string_vector, write_exp_bitstring)
5612         (write_exp_msymbol, mark_struct_expression)
5613         (write_dollar_variable)
5614         (insert_type_address_space, increase_expout_size): Replace
5615         "parser_state" with "expr_builder".
5616         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5617         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5618         "parser_state" with "expr_builder".
5619
5620 2019-04-04  Tom Tromey  <tom@tromey.com>
5621
5622         * rust-exp.y: Replace "parse_language" with method call.
5623         * p-exp.y:
5624         (yylex): Replace "parse_language" with method call.
5625         * m2-exp.y:
5626         (yylex): Replace "parse_language" with method call.
5627         * go-exp.y (classify_name): Replace "parse_language" with method
5628         call.
5629         * f-exp.y (yylex): Replace "parse_language" with method call.
5630         * d-exp.y (lex_one_token): Replace "parse_language" with method
5631         call.
5632         * c-exp.y:
5633         (lex_one_token, classify_name, yylex): Replace "parse_language"
5634         with method call.
5635         * ada-exp.y (find_primitive_type, type_char)
5636         (type_system_address): Replace "parse_language" with method call.
5637
5638 2019-04-04  Tom Tromey  <tom@tromey.com>
5639
5640         * rust-exp.y: Replace "parse_gdbarch" with method call.
5641         * parse.c (write_dollar_variable, insert_type_address_space):
5642         Replace "parse_gdbarch" with method call.
5643         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5644         call.
5645         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5646         call.
5647         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5648         "parse_gdbarch" with method call.
5649         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5650         with method call.
5651         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5652         "parse_gdbarch" with method call.
5653         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5654         "parse_gdbarch" with method call.
5655         * c-exp.y (parse_type, parse_number, classify_name): Replace
5656         "parse_gdbarch" with method call.
5657         * ada-lex.l: Replace "parse_gdbarch" with method call.
5658         * ada-exp.y (parse_type, find_primitive_type, type_char)
5659         (type_system_address): Replace "parse_gdbarch" with method call.
5660
5661 2019-04-04  Tom Tromey  <tom@tromey.com>
5662
5663         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5664         * stap-probe.c (stap_parse_argument): Update.
5665         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5666         initial_size parameter.
5667         * rust-exp.y (rust_lex_tests): Update.
5668         * parse.c (parser_state): Update.
5669         (parse_exp_in_context): Update.
5670         * parser-defs.h (struct parser_state) <parser_state>: Remove
5671         "initial_size" parameter.
5672
5673 2019-04-04  Tom Tromey  <tom@tromey.com>
5674
5675         * parser-defs.h (increase_expout_size): Don't declare.
5676         * parse.c (increase_expout_size): Now static.
5677
5678 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5679
5680         * gnu-nat.c (gnu_nat_target::wait): Fix
5681         target_waitstatus_to_string call.
5682
5683 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5684
5685         * eval.c (evaluate_subexp_standard): Handle internal functions
5686         during Fortran function call handling.
5687
5688 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5689
5690         * NEWS: Mention new internal functions.
5691         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5692         (read_base_type): Use dwarf2_init_complex_target_type.
5693         * value.c (creal_internal_fn): New function.
5694         (cimag_internal_fn): New function.
5695         (_initialize_values): Register new internal functions.
5696
5697 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5698
5699         * infrun.c (stop_all_threads): If debug_infrun, always
5700         trace the wait status after wait_one, using
5701         target_waitstatus_to_string and target_pid_to_str.
5702         (handle_inferior_event): Replace various trace of
5703         wait status kind by a single trace.
5704         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5705         wait status kind image by target_waitstatus_to_string.
5706         * target/waitstatus.c (target_waitstatus_to_string): Fix
5707         obsolete comment.
5708
5709 2019-04-01  Tom Tromey  <tromey@adacore.com>
5710
5711         PR symtab/23331:
5712         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5713
5714 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5715             Pedro Alves  <palves@redhat.com>
5716
5717         * top.c (quit_force): Call 'finalize_values'.
5718         * value.c (finalize_values): New function.
5719         * value.h (finalize_values): Declare.
5720
5721 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5722
5723         * NEWS: Announce $_gdb_major and $_gdb_minor.
5724
5725         * top.c (init_gdb_version_vars): New function.
5726         (gdb_init): Call init_gdb_version_vars.
5727
5728 2019-03-29  Tom Tromey  <tromey@adacore.com>
5729
5730         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5731         help text.  Remove dead code.
5732
5733 2019-03-29  Keith Seitz  <keiths@redhat.com>
5734
5735         From Siddhesh Poyarekar:
5736         * f-lang.h (f77_get_upperbound): Return LONGEST.
5737         (f77_get_lowerbound): Likewise.
5738         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5739         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5740         print them.
5741         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5742         plongest to format print it.
5743         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5744         (f77_get_upperbound): Likewise.
5745         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5746         LOWER_BOUND to LONGEST.
5747         (f77_create_arrayprint_offset_tbl): Likewise.
5748
5749 2019-03-29  Keith Seitz  <keiths@redhat.com>
5750
5751         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5752         %s/pulongest for TYPE_LENGTH instead of %d in format
5753         strings.
5754         * ada-typerint.c (ada_print_type): Likewise.
5755         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5756         * compile/compile-c-support.c (generate_register_struct): Likewise.
5757         * gdbtypes.c (recursive_dump_type): Likewise.
5758         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5759         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5760         instead of %d in format strings.
5761         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5762         to std::min to ULONGEST.
5763         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5764         instead of %d in format strings.
5765         * tracepoint.c (info_scope_command): Likewise.
5766         * typeprint.c (print_offset_data::update)
5767         (print_offset_data::finish): Likewise.
5768         * xtensa-tdep.c (xtensa_store_return_value)
5769         (xtensa_push_dummy_call): Likewise.
5770
5771 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5772
5773         * windows-nat.c (display_selector): Fixed format specifications
5774         for 64-bit Cygwin.
5775
5776 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5777
5778         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5779
5780 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5781
5782         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5783         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5784         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5785         (nios2_linux_init_abi): Install it.
5786
5787 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5788
5789         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5790
5791 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5792
5793         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5794
5795 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5796             Tom Tromey  <tromey@adacore.com>
5797
5798         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5799
5800 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5801
5802         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5803         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5804         method to compute the bounds of range types. Also print "[evaluated]"
5805         if the bounds' values come from a dynamic evaluation.
5806
5807 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5808
5809         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5810         whitespace when pretty printing is on.
5811
5812 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5813
5814         * ppc-linux-nat.c: Add include.
5815
5816 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5817
5818         * NEWS: Mention AArch64 Pointer Authentication.
5819
5820 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5821
5822         * arm-linux-nat.c: Add include.
5823
5824 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5825
5826         * source-cache.c (source_cache::get_source_lines): Re-read
5827         fullname after calling open_source_file.
5828
5829 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5830
5831         * NEWS: Mention TLS support for FreeBSD.
5832
5833 2019-03-25  Tom Tromey  <tromey@adacore.com>
5834
5835         * minsyms.c (BUNCH_SIZE): Update comment.
5836         (~minimal_symbol_reader): Remove old comment.
5837         (compact_minimal_symbols): Update comment.
5838         (minimal_symbol_reader::install): Remove old comment.  Update
5839         other comments.
5840
5841 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5842
5843         * s390-linux-nat.c: Add include.
5844
5845 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5846
5847         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5848         Call linux_get_hwcap.
5849         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5850         Likewise.
5851         (aarch64_linux_get_hwcap): Remove function.
5852         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5853         declaration.
5854         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5855         linux_get_hwcap.
5856         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5857         * linux-tdep.c (linux_get_hwcap): Add function.
5858         (linux_get_hwcap2): Likewise.
5859         * linux-tdep.h (linux_get_hwcap): Add declaration.
5860         (linux_get_hwcap2): Likewise.
5861         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5862         (ppc_linux_get_hwcap2): Likewise.
5863         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5864         linux_get_hwcap.
5865         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5866         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5867         (ppc_linux_nat_target::read_description): Likewise.
5868         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5869         * s390-linux-nat.c: Likewise.
5870         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5871
5872 2019-03-24  Tom Tromey  <tom@tromey.com>
5873
5874         * ada-lang.c (standard_lookup): Simplify initialization.
5875         (ada_lookup_symbol_nonlocal): Simplify return.
5876         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5877         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5878         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5879         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5880         initialization.
5881         * solib.c (solib_global_lookup): Simplify.
5882         * symtab.c (null_block_symbol): Remove.
5883         (symbol_cache_lookup): Simplify returns.
5884         (lookup_language_this): Simplify returns.
5885         (lookup_symbol_aux): Simplify return.
5886         (lookup_local_symbol): Simplify returns.
5887         (lookup_global_symbol_from_objfile): Simplify return.
5888         (lookup_symbol_in_objfile_symtabs)
5889         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5890         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5891         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5892         * cp-namespace.c (cp_lookup_bare_symbol)
5893         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5894         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5895         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5896         (cp_lookup_symbol_via_imports): Simplify initialization.
5897         (find_symbol_in_baseclass): Likewise.
5898         * symtab.h (null_block_symbol): Remove.
5899         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5900         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5901         (d_lookup_symbol_module): Likewise.
5902         (find_symbol_in_baseclass): Simplify initialization.
5903
5904 2019-03-24  Tom Tromey  <tom@tromey.com>
5905
5906         * expression.h: Don't include symtab.h.
5907         (struct block): Forward declare.
5908
5909 2019-03-24  Tom Tromey  <tom@tromey.com>
5910
5911         * c-exp.y (typebase): Remove casts.
5912         * gdbtypes.c (lookup_unsigned_typename, )
5913         (lookup_signed_typename): Remove cast.
5914         * eval.c (parse_to_comma_and_eval): Remove cast.
5915         * parse.c (write_dollar_variable): Remove cast.
5916         * block.h (struct block) <superblock>: Now const.
5917         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5918         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5919         (map_block): Make "block" const.
5920         * symfile.h (struct quick_symbol_functions)
5921         <map_matching_symbols>: Constify block argument to "callback".
5922         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5923         const.
5924         (find_pc_sect_compunit_symtab): Make "b" const.
5925         (find_symbol_at_address): Likewise.
5926         (search_symbols): Likewise.
5927         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5928         (dw2_debug_names_lookup_symbol): Likewise.
5929         (dw2_map_matching_symbols): Update.
5930         * p-valprint.c (pascal_val_print): Remove "block".
5931         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5932         (aux_add_nonlocal_symbols): Make "block" const.
5933         (resolve_subexp): Remove cast.
5934         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5935         const.
5936         (iterate_over_file_blocks): Likewise.
5937         * f-exp.y (%union) <bval>: Remove.
5938         * coffread.c (patch_opaque_types): Make "b" const.
5939         * spu-tdep.c (spu_catch_start): Make "block" const.
5940         * c-valprint.c (print_unpacked_pointer): Remove "block".
5941         * symmisc.c (dump_symtab_1): Make "b" const.
5942         (block_depth): Make "block" const.
5943         * d-exp.y (%union) <bval>: Remove.
5944         * cp-support.h (cp_lookup_rtti_type): Update.
5945         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5946         * psymtab.c (psym_lookup_symbol): Make "block" const.
5947         (maintenance_check_psymtabs): Make "b" const.
5948         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5949         (enumerate_locals, enumerate_args): Update.
5950         * python/py-symtab.c (stpy_global_block): Make "block" const.
5951         (stpy_static_block): Likewise.
5952         * inline-frame.c (block_starting_point_at): Make "new_block"
5953         const.
5954         * block.c (find_block_in_blockvector): Make return type const.
5955         (blockvector_for_pc_sect): Make "b" const.
5956         (find_block_in_blockvector): Make "b" const.
5957
5958 2019-03-23  Tom Tromey  <tom@tromey.com>
5959
5960         * varobj.c (varobj_create): Update.
5961         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5962         * printcmd.c (display_command, do_one_display): Don't reset
5963         innermost_block.
5964         * parser-defs.h (enum innermost_block_tracker_type): Move to
5965         expression.h.
5966         (innermost_block): Update comment.
5967         * parse.c (parse_exp_1): Add tracker_types parameter.
5968         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5969         tracker_types parameter.  Reset innermost_block.
5970         (parse_exp_in_context): Remove.
5971         (parse_expression_for_completion): Update.
5972         * objfiles.c (~objfile): Don't reset expression_context_block or
5973         innermost_block.
5974         * expression.h (enum innermost_block_tracker_type): Move from
5975         parser-defs.h.
5976         (parse_exp_1): Add tracker_types parameter.
5977         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5978         reset innermost_block.
5979
5980 2019-03-23  Tom Tromey  <tom@tromey.com>
5981
5982         * objfiles.h: Include bcache.h.
5983
5984 2019-03-23  Tom Tromey  <tom@tromey.com>
5985
5986         * linespec.c (get_current_search_block): Use
5987         scoped_restore_current_language.
5988         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5989
5990 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5991             Jiong Wang  <jiong.wang@arm.com>
5992
5993         * aarch64-linux-tdep.c
5994         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5995         section.
5996         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5997
5998 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5999             Jiong Wang  <jiong.wang@arm.com>
6000
6001         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6002         instructions.
6003         (aarch64_analyze_prologue_test): Add PACIASP test.
6004         (aarch64_prologue_prev_register): Unmask PC value.
6005
6006 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6007             Jiong Wang  <jiong.wang@arm.com>
6008
6009         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6010         (aarch64_dwarf2_prev_register): Unmask PC value.
6011         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6012         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6013         DW_CFA_AARCH64_negate_ra_state.
6014         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6015
6016 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6017             Jiong Wang  <jiong.wang@arm.com>
6018
6019         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6020         registers.
6021         (aarch64_pseudo_register_name): Likewise.
6022         (aarch64_pseudo_register_type): Likewise.
6023         (aarch64_pseudo_register_reggroup_p): Likewise.
6024         (aarch64_gdbarch_init): Add pauth registers.
6025         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6026         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6027         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6028         (struct gdbarch_tdep): Add regnum for ra_state.
6029
6030 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6031             Jiong Wang  <jiong.wang@arm.com>
6032
6033         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6034
6035 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6036             Jiong Wang  <jiong.wang@arm.com>
6037
6038         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6039         function.
6040         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6041         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6042         (aarch64_gdbarch_init): Add puth registers.
6043         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6044         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6045         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6046
6047 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6048             Jiong Wang  <jiong.wang@arm.com>
6049
6050         * aarch64-linux-nat.c
6051         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6052         * aarch64-linux-tdep.c
6053         (aarch64_linux_core_read_description): Likewise.
6054         (aarch64_linux_get_hwcap): New function.
6055         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6056         (aarch64_linux_get_hwcap): New declaration.
6057
6058 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6059             Jiong Wang  <jiong.wang@arm.com>
6060
6061         * aarch64-linux-nat.c
6062         (aarch64_linux_nat_target::read_description): Add pauth param.
6063         * aarch64-linux-tdep.c
6064         (aarch64_linux_core_read_description): Likewise.
6065         * aarch64-tdep.c (struct target_desc): Add in pauth.
6066         (aarch64_read_description): Add pauth param.
6067         (aarch64_gdbarch_init): Likewise.
6068         * aarch64-tdep.h (aarch64_read_description): Likewise.
6069         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6070         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6071         * features/Makefile: Add new files.
6072         * features/aarch64-pauth.c: New file.
6073         * features/aarch64-pauth.xml: New file.
6074
6075 2019-03-20  Tom Tromey  <tromey@adacore.com>
6076
6077         * infrun.c (handle_inferior_event): Rename from
6078         handle_inferior_event_1.  Create a scoped_value_mark.
6079         (handle_inferior_event): Remove.
6080
6081 2019-03-19  Tom Tromey  <tromey@adacore.com>
6082
6083         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6084         * infrun.h (print_stop_event): Add "displays" parameter.
6085         * infrun.c (print_stop_event): Add "displays" parameter.
6086
6087 2019-03-19  Pedro Alves  <palves@redhat.com>
6088
6089         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6090         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6091         to -1.  Fix TABs vs spaces.
6092         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6093         * tui/tui-out.h (tui_ui_out) Add intro comments.
6094         <m_line, m_start_of_line>: In-class initialize, and add describing
6095         comment.
6096
6097 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6098
6099         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6100         variable names.
6101         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6102
6103 2019-03-18  Pedro Alves  <palves@redhat.com>
6104             Eli Zaretskii <eliz@gnu.org>
6105
6106         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6107         m_line and m_start_of_line.
6108
6109 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6110
6111         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6112         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6113         it returns a newline.  This fixes a regression in TU mode, whereby
6114         the next line is output on the same screen line as the user input.
6115
6116 2019-03-18  Tom Tromey  <tromey@adacore.com>
6117
6118         * minsyms.c (minimal_symbol_reader::install): Remove call to
6119         obstack_blank.
6120
6121 2019-03-18  Pedro Alves  <palves@redhat.com>
6122
6123         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6124         New globals.
6125         (apply_style): New, factored out from ...
6126         (apply_ansi_escape): ... this.  Handle reverse video mode.
6127         (tui_set_reverse_mode): New function.
6128         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6129         * tui/tui-winsource.c (tui_show_source_line): Use
6130         tui_set_reverse_mode instead of setting A_STANDOUT.
6131         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6132         New setter methods.
6133
6134 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6135
6136         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6137         Handle tabs.
6138
6139 2019-03-18  Tom Tromey  <tromey@adacore.com>
6140
6141         * ada-lang.c (empty_array): Add "high" parameter.
6142         (ada_evaluate_subexp): Update.
6143
6144 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6145
6146         * unittests/string_view-selftests.c: Define
6147         _initialize_string_view_selftests unconditionally.
6148
6149 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6150
6151         PR gdb/24350
6152         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6153
6154 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6155
6156         PR gdb/24351
6157         * windows-nat.c (display_selector): Fix format specifiers.
6158
6159 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6160
6161         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6162         tui_refill_source_window instead of tui_refresh_win, to update the
6163         current execution line.  This fixes redisplay of the current line
6164         when stepping through the code with "next" or "step".
6165
6166 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6167
6168         * source-cache.c (source_cache::get_source_lines): Call
6169         find_source_lines to initialize s->nlines.  This fixes vertical
6170         scrolling of TUI source window when the DOWN arrow is pressed.
6171
6172 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6173
6174         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6175         linux-thread-db.c (_initialize_thread_db): Likewise.
6176
6177 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6178
6179         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6180         wclrtoeol in tui_show_source_line".  This reverts changes made in
6181         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6182
6183 2019-03-15  Tom Tromey  <tom@tromey.com>
6184
6185         * symtab.h (struct minimal_symbol): Derive from
6186         general_symbol_info.
6187         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6188         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6189         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6190         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6191         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6192         (MSYMBOL_SEARCH_NAME): Update.
6193         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6194         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6195         * minsyms.c (minimal_symbol_reader::record_full): Update.
6196
6197 2019-03-15  Tom Tromey  <tom@tromey.com>
6198
6199         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6200
6201 2019-03-15  Tom Tromey  <tom@tromey.com>
6202
6203         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6204         unique_xmalloc_ptr.
6205         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6206         Update.
6207         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6208         (build_minimal_symbol_hash_tables)
6209         (minimal_symbol_reader::install): Update.
6210
6211 2019-03-15  Tom Tromey  <tom@tromey.com>
6212
6213         * symtab.c (create_demangled_names_hash): Update.
6214         (symbol_set_names): Update.
6215         * objfiles.h (struct objfile_per_bfd_storage)
6216         <demangled_names_hash>: Now an htab_up.
6217         * objfiles.c (objfile_per_bfd_storage): Simplify.
6218
6219 2019-03-15  Tom Tromey  <tom@tromey.com>
6220
6221         * objfiles.h (struct objfile_per_bfd_storage): Declare
6222         destructor.
6223         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6224         New.
6225         (get_objfile_bfd_data): Use new.  Don't initialize
6226         language_of_main.
6227         (free_objfile_per_bfd_storage): Remove.
6228         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6229
6230 2019-03-15  Tom Tromey  <tom@tromey.com>
6231
6232         * symfile.c (reread_symbols): Update.
6233         * objfiles.c (objfile::objfile): Update.
6234         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6235         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6236         comment.
6237         (minimal_symbol_reader::install): Update.
6238         (terminate_minimal_symbol_table): Remove.
6239         * jit.c (jit_object_close_impl): Update.
6240
6241 2019-03-15  Tom Tromey  <tom@tromey.com>
6242
6243         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6244         initializations.
6245
6246 2019-03-15  Tom Tromey  <tom@tromey.com>
6247
6248         * objfiles.h (struct objfile_per_bfd_storage)
6249         <demangled_hash_languages>: Now a bitset.
6250         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6251         (lookup_minimal_symbol): Update.
6252
6253 2019-03-15  Tom Tromey  <tom@tromey.com>
6254
6255         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6256         Don't return the symbol.
6257         * coffread.c (record_minimal_symbol): Use record_full.
6258
6259 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6260
6261         The MS-Windows port of ncurses fails to switch to a color pair if
6262         one or both of the colors are the implicit default colors.  This
6263         change records the default colors when TUI is initialized, and
6264         then specifies them explicitly when a color pair uses the default
6265         colors.  This allows color styling in TUI mode on MS-Windows.
6266
6267         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6268         ncurses_norm_attr.
6269         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6270         colors in ncurses_norm_attr.
6271         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6272         "none", replace it with the default color recorded in
6273         ncurses_norm_attr.
6274
6275 2019-03-14  Tom Tromey  <tromey@adacore.com>
6276
6277         * source-cache.h (class source_cache) <get_source_lines>: Return
6278         std::string.
6279         * source-cache.c (source_cache::extract_lines): Handle case where
6280         first_pos==npos.  Return std::string.
6281         (source_cache::get_source_lines): Update.
6282
6283 2019-03-14  Tom Tromey  <tromey@adacore.com>
6284
6285         * NEWS: Add item for "style sources" commands.
6286         * source-cache.c (source_cache::get_source_lines): Check
6287         source_styling.
6288         * cli/cli-style.c (source_styling): New global.
6289         (_initialize_cli_style): Add "style sources" commands.
6290         (show_style_sources): New function.
6291         * cli/cli-style.h (source_styling): Declare.
6292
6293 2019-03-14  Pedro Alves  <palves@redhat.com>
6294             Tom Tromey  <tromey@adacore.com>
6295
6296         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6297         * tui/tui-winsource.c (tui_refill_source_window): New function,
6298         from...
6299         (tui_horizontal_source_scroll): ... here.  Move some logic.
6300         * cli/cli-style.c (set_style_enabled): Notify new observable.
6301         * tui/tui-hooks.c (tui_redisplay_source): New function.
6302         (tui_attach_detach_observers): Attach or detach
6303         tui_redisplay_source.
6304         * observable.h (source_styling_changed): New observable.
6305         * observable.c: Define source_styling_changed observable.
6306
6307 2019-03-13  Tom Tromey  <tromey@adacore.com>
6308
6309         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6310         (i386_gnu_nat_target::store_registers): Update.
6311         * target-debug.h (target_debug_print_std_string): New macro.
6312         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6313         * windows-tdep.c (display_one_tib): Update.
6314         * tui/tui-stack.c (tui_make_status_line): Update.
6315         * top.c (print_inferior_quit_action): Update.
6316         * thread.c (thr_try_catch_cmd): Update.
6317         (add_thread_with_info): Update.
6318         (thread_target_id_str): Update.
6319         (thr_try_catch_cmd): Update.
6320         (thread_command): Update.
6321         (thread_find_command): Update.
6322         * record-btrace.c (record_btrace_target::info_record)
6323         (record_btrace_resume_thread, record_btrace_target::resume)
6324         (record_btrace_cancel_resume, record_btrace_step_thread)
6325         (record_btrace_target::wait, record_btrace_target::wait)
6326         (record_btrace_target::wait, record_btrace_target::stop): Update.
6327         * progspace.c (print_program_space): Update.
6328         * process-stratum-target.c
6329         (process_stratum_target::thread_address_space): Update.
6330         * linux-fork.c (linux_fork_mourn_inferior)
6331         (detach_checkpoint_command, info_checkpoints_command)
6332         (linux_fork_context): Update.
6333         (linux_fork_detach): Update.
6334         (class scoped_switch_fork_info): Update.
6335         (delete_checkpoint_command): Update.
6336         * infrun.c (follow_fork_inferior): Update.
6337         (follow_fork_inferior): Update.
6338         (proceed_after_vfork_done): Update.
6339         (handle_vfork_child_exec_or_exit): Update.
6340         (follow_exec): Update.
6341         (displaced_step_prepare_throw): Update.
6342         (displaced_step_restore): Update.
6343         (start_step_over): Update.
6344         (resume_1): Update.
6345         (clear_proceed_status_thread): Update.
6346         (proceed): Update.
6347         (print_target_wait_results): Update.
6348         (do_target_wait): Update.
6349         (context_switch): Update.
6350         (stop_all_threads): Update.
6351         (restart_threads): Update.
6352         (finish_step_over): Update.
6353         (handle_signal_stop): Update.
6354         (switch_back_to_stepped_thread): Update.
6355         (keep_going_pass_signal): Update.
6356         (print_exited_reason): Update.
6357         (normal_stop): Update.
6358         * inferior.c (inferior_pid_to_str): Change return type.
6359         (print_selected_inferior): Update.
6360         (add_inferior): Update.
6361         (detach_inferior): Update.
6362         * dummy-frame.c (fprint_dummy_frames): Update.
6363         * dcache.c (dcache_info_1): Update.
6364         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6365         (btrace_fetch, btrace_clear): Update.
6366         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6367         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6368         type.
6369         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6370         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6371         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6372         * gdbarch.c, gdbarch.h: Rebuild.
6373         * gdbarch.sh (core_pid_to_str): Change return type.
6374         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6375         return type.
6376         (windows_nat_target::pid_to_str): Change return type.
6377         (windows_delete_thread): Update.
6378         (windows_nat_target::attach): Update.
6379         (windows_nat_target::files_info): Update.
6380         * target-delegates.c: Rebuild.
6381         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6382         return type.
6383         (sol_thread_target::pid_to_str): Change return type.
6384         * remote.c (class remote_target) <pid_to_str>: Change return
6385         type.
6386         (remote_target::pid_to_str): Change return type.
6387         (extended_remote_target::attach, remote_target::remote_stop_ns)
6388         (remote_target::remote_notif_remove_queued_reply)
6389         (remote_target::push_stop_reply, remote_target::disable_btrace):
6390         Update.
6391         (extended_remote_target::attach): Update.
6392         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6393         type.
6394         (gdbsim_target::pid_to_str): Change return type.
6395         * ravenscar-thread.c (struct ravenscar_thread_target)
6396         <pid_to_str>: Change return type.
6397         (ravenscar_thread_target::pid_to_str): Change return type.
6398         * procfs.c (class procfs_target) <pid_to_str>: Change return
6399         type.
6400         (procfs_target::pid_to_str): Change return type.
6401         (procfs_target::attach): Update.
6402         (procfs_target::detach): Update.
6403         (procfs_target::fetch_registers): Update.
6404         (procfs_target::store_registers): Update.
6405         (procfs_target::wait): Update.
6406         (procfs_target::files_info): Update.
6407         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6408         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6409         return type.
6410         (nto_procfs_target::pid_to_str): Change return type.
6411         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6412         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6413         return type.
6414         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6415         (exit_lwp): Update.
6416         (attach_proc_task_lwp_callback, get_detach_signal)
6417         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6418         (linux_nat_target::resume, wait_lwp, stop_callback)
6419         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6420         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6421         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6422         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6423         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6424         type.
6425         (inf_ptrace_target::attach): Update.
6426         (inf_ptrace_target::files_info): Update.
6427         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6428         type.
6429         (go32_nat_target::pid_to_str): Change return type.
6430         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6431         (gnu_nat_target::wait): Update.
6432         (gnu_nat_target::wait): Update.
6433         (gnu_nat_target::resume): Update.
6434         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6435         (fbsd_nat_target::wait): Update.
6436         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6437         type.
6438         (darwin_nat_target::attach): Update.
6439         * corelow.c (class core_target) <pid_to_str>: Change return type.
6440         (core_target::pid_to_str): Change return type.
6441         * target.c (normal_pid_to_str): Change return type.
6442         (default_pid_to_str): Likewise.
6443         (target_pid_to_str): Change return type.
6444         (target_translate_tls_address): Update.
6445         (target_announce_detach): Update.
6446         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6447         return type.
6448         (bsd_uthread_target::pid_to_str): Change return type.
6449         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6450         type.
6451         (bsd_kvm_target::pid_to_str): Change return type.
6452         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6453         return type.
6454         (aix_thread_target::pid_to_str): Change return type.
6455         * target.h (struct target_ops) <pid_to_str>: Change return type.
6456         (target_pid_to_str, normal_pid_to_str): Likewise.
6457         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6458         type.
6459         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6460         type.
6461         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6462         return type.
6463         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6464         type.
6465         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6466         type.
6467         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6468         return type.
6469
6470 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6471
6472         * NEWS: Mention that the new default MI version is 3.  Mention
6473         changes to the output of commands and events that deal with
6474         multi-location breakpoints.
6475         * breakpoint.c: Include "mi/mi-out.h".
6476         (print_one_breakpoint): Change output syntax if using MI version
6477         >= 3.
6478         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6479         New.
6480         (mi_multi_location_breakpoint_output_fixed): New.
6481         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6482         (mi_cmd_fix_multi_location_breakpoint_output): New.
6483         (mi_multi_location_breakpoint_output_fixed): New.
6484         * mi/mi-cmds.c (mi_cmds): Register command
6485         -fix-multi-location-breakpoint-output.
6486         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6487         interpreter "mi".
6488
6489 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6490
6491         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6492         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6493         instantiate mi_ui_out based on interpreter name.
6494         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6495         * mi/mi-main.c (mi_load_progress): Likewise.
6496
6497 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6498
6499         * NEWS: Combine separate "New targets" sections for 8.3.
6500
6501 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6502
6503         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6504         (ppcfbsd_init_abi): Install gdbarch
6505         "fetch_tls_load_module_address" and "get_thread_local_address"
6506         methods.
6507
6508 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6509
6510         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6511         (riscv_fbsd_init_abi): Install gdbarch
6512         "fetch_tls_load_module_address" and "get_thread_local_address"
6513         methods.
6514
6515 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6516
6517         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6518         (i386fbsd_init_abi): Install gdbarch
6519         "fetch_tls_load_module_address" and "get_thread_local_address"
6520         methods.
6521
6522 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6523
6524         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6525         (amd64fbsd_init_abi): Install gdbarch
6526         "fetch_tls_load_module_address" and "get_thread_local_address"
6527         methods.
6528
6529 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6530
6531         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6532         (struct fbsd_pspace_data): New type.
6533         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6534         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6535         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6536         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6537         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6538
6539 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6540
6541         * gdbtypes.c (lookup_struct_elt): New function.
6542         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6543         * gdbtypes.h (struct struct_elt): New type.
6544         (lookup_struct_elt): New prototype.
6545
6546 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6547
6548         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6549         remove disabled code block.
6550
6551 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6552
6553         * gdbarch.sh (get_thread_local_address): New method.
6554         * gdbarch.h, gdbarch.c: Regenerate.
6555         * target.c (target_translate_tls_address): Use
6556         gdbarch_get_thread_local_address if present instead of
6557         target::get_thread_local_address.
6558
6559 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6560
6561         * target.h (target::get_thread_local_address): Update comment.
6562
6563 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6564
6565         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6566         objfile->separate_debug_objfile_backlink if not NULL.
6567
6568 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6569
6570         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6571         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6572         (amd64bsd_store_inferior_registers): Likewise.
6573         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6574         Enable segment base registers.
6575         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6576         PT_GETFSBASE and PT_GETGSBASE.
6577         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6578         PT_SETGSBASE.
6579         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6580         segment base registers.
6581         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6582
6583 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6584
6585         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6586         Update calls to i386_target_description to add 'segments'
6587         parameter.
6588         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6589         add segment base registers.
6590         * arch/i386.c (i386_create_target_description): Add 'segments'
6591         parameter to enable segment base registers.
6592         * arch/i386.h (i386_create_target_description): Likewise.
6593         * features/i386/32bit-segments.xml: New file.
6594         * features/i386/32bit-segments.c: Generate.
6595         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6596         call to i386_target_description to add 'segments' parameter.
6597         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6598         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6599         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6600         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6601         if feature is present.
6602         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6603         Add 'segments' parameter to call to i386_target_description.
6604         (i386_target_description): Add 'segments' parameter to enable
6605         segment base registers.
6606         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6607         to call to i386_target_description.
6608         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6609         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6610         Define I386_NUM_REGS.
6611         (i386_target_description): Add 'segments' parameter to enable
6612         segment base registers.
6613
6614 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6615
6616         PR/24325
6617         * source-cache.c: #undef open and close, to avoid unresolved
6618         externals during linking.
6619
6620 2019-03-12  Tom Tromey  <tromey@adacore.com>
6621
6622         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6623         const.  Add initializers.
6624         (_initialize_remote): Don't initialize ptid globals.
6625
6626 2019-03-12  Pedro Alves  <palves@redhat.com>
6627
6628         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6629
6630 2019-03-12  Pedro Alves  <palves@redhat.com>
6631
6632         * cp-name-parser.y (main): Remove unused 'len' variable.
6633
6634 2019-03-12  Tom Tromey  <tromey@adacore.com>
6635
6636         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6637         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6638
6639 2019-03-12  Tom Tromey  <tromey@adacore.com>
6640
6641         * linux-nat.c (iterate_over_lwps): Update.
6642         (stop_callback): Remove parameter.
6643         (stop_wait_callback, detach_callback, resume_set_callback)
6644         (select_singlestep_lwp_callback, set_ignore_sigint)
6645         (status_callback, resumed_callback, resume_clear_callback)
6646         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6647         data parameter.
6648         (linux_nat_target::detach, linux_nat_target::resume)
6649         (linux_stop_and_wait_all_lwps, select_event_lwp)
6650         (linux_nat_filter_event, linux_nat_wait_1)
6651         (linux_nat_target::kill, linux_nat_target::stop)
6652         (linux_nat_target::stop): Update.
6653         (linux_nat_resume_callback): Change type.
6654         (resume_stopped_resumed_lwps, count_events_callback)
6655         (select_event_lwp_callback): Likewise.
6656         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6657         * arm-linux-nat.c (struct update_registers_data): Remove.
6658         (update_registers_callback): Change type.
6659         (arm_linux_insert_hw_breakpoint1): Update.
6660         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6661         parameter.
6662         (x86_linux_dr_set_addr): Update.
6663         (x86_linux_dr_set_control): Update.
6664         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6665         (iterate_over_lwps): Use gdb::function_view.
6666         * nat/aarch64-linux-hw-point.c (struct
6667         aarch64_dr_update_callback_param): Remove.
6668         (debug_reg_change_callback): Change type.
6669         (aarch64_notify_debug_reg_change): Update.
6670         * s390-linux-nat.c (s390_refresh_per_info): Update.
6671
6672 2019-03-11  Tom Tromey  <tromey@adacore.com>
6673
6674         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6675         redundant assignment to "this_cu".
6676
6677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6678
6679         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6680
6681 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6682
6683         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6684         from...
6685         (rank_one_type): ... this.
6686
6687 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6688
6689         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6690         from...
6691         (rank_one_type): ... this.
6692
6693 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6694
6695         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6696         from...
6697         (rank_one_type): ... this.
6698
6699 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6700
6701         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6702         from...
6703         (rank_one_type): ... this.
6704
6705 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6706
6707         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6708         from...
6709         (rank_one_type): ... this.
6710
6711 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6712
6713         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6714         from...
6715         (rank_one_type): ... this.
6716
6717 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6718
6719         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6720         from...
6721         (rank_one_type): ... this.
6722
6723 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6724
6725         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6726         from...
6727         (rank_one_type): ... this.
6728
6729 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6730
6731         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6732         from...
6733         (rank_one_type): ... this.
6734
6735 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6736
6737         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6738         from...
6739         (rank_one_type): ... this.
6740
6741 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6742
6743         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6744         from...
6745         (rank_one_type): ... this.
6746
6747 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6748
6749         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6750         from...
6751         (rank_one_type): ... this.
6752
6753 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6754
6755         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6756         inferior-events' shows the example events.
6757
6758 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6759
6760         Support styling on native MS-Windows console
6761
6762         PR/24315
6763         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6764         on MS-Windows if $TERM is not defined.
6765
6766         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6767
6768         * posix-hdep.c (gdb_console_fputs):
6769         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6770         functions.
6771         * ui-file.h (gdb_console_fputs): Add prototype.
6772
6773         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6774         back to fputs only if the former returns zero.
6775
6776 2019-03-07  Tom Tromey  <tom@tromey.com>
6777
6778         * symmisc.c (print_symbol_bcache_statistics): Update.
6779         (print_objfile_statistics): Update.
6780         * symfile.c (allocate_symtab): Update.
6781         * stabsread.c: Don't include bcache.h.
6782         * psymtab.h (struct psymbol_bcache): Don't declare.
6783         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6784         (psymbol_bcache_init, psymbol_bcache_free)
6785         (psymbol_bcache_get_bcache): Don't declare.
6786         * psymtab.c (struct psymbol_bcache): Remove.
6787         (psymtab_storage::psymtab_storage): Update.
6788         (psymtab_storage::~psymtab_storage): Update.
6789         (psymbol_bcache_init, psymbol_bcache_free)
6790         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6791         (add_psymbol_to_bcache): Update.
6792         (allocate_psymtab): Update.
6793         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6794         macro_cache>: No longer pointers.
6795         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6796         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6797         * macrotab.c (macro_bcache): Update.
6798         * macroexp.c: Don't include bcache.h.
6799         * gdbtypes.c (check_types_worklist): Update.
6800         (types_deeply_equal): Remove TRY/CATCH.  Update.
6801         * elfread.c (elf_symtab_read): Update.
6802         * dwarf2read.c: Don't include bcache.h.
6803         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6804         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6805         (print_bcache_statistics, bcache_memory_used): Don't declare.
6806         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6807         methods.  Rename all data members.
6808         * bcache.c (struct bcache): Move to bcache.h.
6809         (bcache::expand_hash_table): Rename from expand_hash_table.
6810         (bcache): Remove.
6811         (bcache::insert): Rename from bcache_full.
6812         (bcache::compare): Rename from bcache_compare.
6813         (bcache_xmalloc): Remove.
6814         (bcache::~bcache): Rename from bcache_xfree.
6815         (bcache::print_statistics): Rename from print_bcache_statistics.
6816         (bcache::memory_used): Rename from bcache_memory_used.
6817
6818 2019-03-07  Pedro Alves  <palves@redhat.com>
6819
6820         * infrun.c (normal_stop): Also check for
6821         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6822
6823 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6824
6825         * f-lang.c (value_from_host_double): Moved to...
6826         * value.c (value_from_host_double): ...here.
6827         * value.h (value_from_host_double): Declare.
6828         * guile/scm-math.c (vlscm_convert_typed_number): Use
6829         value_from_host_double.
6830         (vlscm_convert_number): Likewise.
6831         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6832         * python/py-value.c (convert_value_from_python): Likewise.
6833
6834 2019-03-06  Tom Tromey  <tom@tromey.com>
6835
6836         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6837
6838 2019-03-06  Tom Tromey  <tom@tromey.com>
6839
6840         * utils.h (free_current_contents): Don't declare.
6841         * utils.c (free_current_contents): Remove.
6842
6843 2019-03-06  Tom Tromey  <tom@tromey.com>
6844
6845         * top.c (quit_force): Update.
6846         * main.c (captured_command_loop): Update.
6847         * common/new-op.c (operator new): Update.
6848         * common/common-exceptions.c (struct catcher)
6849         <save_cleanup_chain>: Remove member.
6850         (exceptions_state_mc_init): Update.
6851         (exception_try_scope_entry): Return nullptr.
6852         (exception_try_scope_exit, exception_rethrow)
6853         (throw_exception_sjlj, throw_exception_cxx): Update.
6854         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6855         (all_cleanups, do_cleanups, discard_cleanups)
6856         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6857         (restore_cleanups, restore_final_cleanups): Don't declare.
6858         (do_final_cleanups): Remove parameter.
6859         * common/cleanups.c (cleanup_chain, make_cleanup)
6860         (make_cleanup_dtor, all_cleanups, do_cleanups)
6861         (discard_my_cleanups, discard_cleanups)
6862         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6863         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6864         (null_cleanup): Remove.
6865         (do_final_cleanups): Remove parameter.
6866
6867 2019-03-06  Tom Tromey  <tom@tromey.com>
6868
6869         * remote.c (remote_target::remote_parse_stop_reply): Use
6870         unique_xmalloc_ptr.
6871
6872 2019-03-06  Tom Tromey  <tom@tromey.com>
6873
6874         * stabsread.c (struct stabs_field_info): Rename from field_info.
6875         <list, fnlist>: Add initializers.
6876         <obstack>: New member.
6877         (read_member_functions, read_struct_fields, read_baseclasses):
6878         Allocate on obstack.  Don't use cleanups.
6879         (read_one_struct_field, read_member_functions, read_struct_fields)
6880         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6881         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6882         (read_struct_type): Update.
6883
6884 2019-03-06  Tom Tromey  <tom@tromey.com>
6885
6886         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6887         * common/filestuff.h (make_cleanup_close): Don't declare.
6888         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6889         Remove.
6890
6891 2019-03-06  Tom Tromey  <tom@tromey.com>
6892
6893         * solib-aix.c: Use make_scope_exit.
6894
6895 2019-03-06  Tom Tromey  <tom@tromey.com>
6896
6897         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6898         Use make_scope_exit.
6899
6900 2019-03-06  Tom Tromey  <tom@tromey.com>
6901
6902         * solib-svr4.c (disable_probes_interface): Remove parameter.
6903         (svr4_handle_solib_event): Use make_scope_exit.
6904
6905 2019-03-06  Tom Tromey  <tom@tromey.com>
6906
6907         * remote.c (struct stop_reply_deleter): Remove.
6908         (stop_reply_up): Update.
6909         (struct stop_reply): Derive from notif_event.  Don't typedef.
6910         <regcache>: Now a std::vector.
6911         (stop_reply_xfree): Remove.
6912         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6913         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6914         (remote_target::discard_pending_stop_replies): Use delete.
6915         (remote_target::remote_parse_stop_reply): Update.
6916         (remote_target::process_stop_reply): Update.
6917         * remote-notif.h (struct notif_event): Add virtual destructor.
6918         Remove "dtr" member.
6919         (struct notif_client) <alloc_event>: Return a unique_ptr.
6920         (notif_event_xfree): Don't declare.
6921         (notif_event_up): New typedef.
6922         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6923         (notif_event_xfree, do_notif_event_xfree): Remove.
6924         (remote_notif_state_xfree): Update.
6925
6926 2019-03-06  Tom Tromey  <tom@tromey.com>
6927
6928         * infrun.c (displaced_step_clear_cleanup): Now a
6929         forward_scope_exit type.
6930         (displaced_step_prepare_throw): Update.
6931         (displaced_step_fixup): Update.
6932
6933 2019-03-06  Tom Tromey  <tom@tromey.com>
6934
6935         * inferior.h (class inferior): Update comment.
6936         * gdbthread.h (class thread_info): Update comment.
6937
6938 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6939             Tom Tromey  <tom@tromey.com>
6940
6941         * stabsread.h (struct stab_section_list): Remove.
6942         (coffstab_build_psymtabs): Update.
6943         * dbxread.c (symbuf_sections): Now a std::vector.
6944         (sect_idx): New global.
6945         (fill_symbuf): Update.
6946         (coffstab_build_psymtabs): Change type of stabsects parameter.
6947         Update.
6948         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6949         std::vector.
6950         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6951         (coff_locate_sections): Update.
6952         (coff_symfile_read): Remove cleanups.  Update.
6953         (init_stringtab): Add storage parameter.
6954         (free_stringtab, free_stringtab_cleanup): Remove.
6955         (init_lineno): Add storage parameter.
6956         (free_linetab, free_linetab_cleanup): Remove.
6957
6958 2019-03-06  Pedro Alves  <palves@redhat.com>
6959
6960         * linux-fork.c (fork_info::clobber_regs): Delete.
6961         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6962         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6963         comment.  Adjust.
6964         (scoped_switch_fork_info::scoped_switch_fork_info)
6965         (checkpoint_command, linux_fork_context): Adjust
6966         fork_save_infrun_state calls.
6967
6968 2019-03-06  Pedro Alves  <palves@redhat.com>
6969
6970         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6971         (inf_has_multiple_threads): Return 'bool' and rewrite using
6972         inferior_info::threads().
6973
6974 2019-03-06  Pedro Alves  <palves@redhat.com>
6975
6976         * linux-fork.c: Include <list>.
6977         (fork_list): Now a std::list instance.
6978         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6979         (forks_exist_p, find_last_fork): Adjust.
6980         (new_fork): Delete.
6981         (one_fork_p): New.
6982         (add_fork): Adjust.
6983         (free_fork): Delete, folded into fork_info::~fork_info().
6984         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6985         Adjust.
6986         (init_fork_list): Delete.
6987         (linux_fork_killall, linux_fork_mourn_inferior)
6988         (linux_fork_detach, info_checkpoints_command): Adjust.
6989         (_initialize_linux_fork): No longer call init_fork_list.
6990
6991 2019-03-06  Pedro Alves  <palves@redhat.com>
6992
6993         * linux-fork.c (new_fork): New, split out of ...
6994         (add_fork): ... this.  Return void.  Move "first fork" special
6995         case from here, to ...
6996         (checkpoint_command): ... here.
6997         * linux-linux.h (add_fork): Return void.
6998
6999 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7000
7001         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7002
7003 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7004             Chris January  <chris.january@arm.com>
7005             David Lecomber  <david.lecomber@arm.com>
7006
7007         * f-exp.y: New token, UNOP_INTRINSIC.
7008         (exp): New pattern using UNOP_INTRINSIC token.
7009         (f77_keywords): Add 'abs' keyword.
7010         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7011         (value_from_host_double): New function.
7012         (evaluate_subexp_f): Support UNOP_ABS.
7013
7014 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7015
7016         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7017         types.
7018
7019 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7020
7021         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7022         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7023         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7024
7025 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7026
7027         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7028
7029 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7030             Chris January  <chris.january@arm.com>
7031
7032         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7033         * f-exp.y: Define 'KIND' token.
7034         (exp): New pattern for KIND expressions.
7035         (ptype): Handle types with a kind extension.
7036         (direct_abs_decl): Extend to spot kind extensions.
7037         (f77_keywords): Add 'kind' to the list.
7038         (push_kind_type): New function.
7039         (convert_to_kind_type): New function.
7040         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7041         * parse.c (operator_length_standard): Likewise.
7042         * parser-defs.h (enum type_pieces): Add tp_kind.
7043         * std-operator.def: Add UNOP_KIND.
7044
7045 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7046
7047         * f-exp.y (f_parse): Set yydebug.
7048
7049 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7050
7051         * f-lang.c (evaluate_subexp_f): New function.
7052         (exp_descriptor_f): New global.
7053         (f_language_defn): Use exp_descriptor_f instead of
7054         exp_descriptor_standard.
7055
7056 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7057
7058         * f-exp.y (struct token): Add comments.
7059         (dot_ops): Remove uppercase versions and the end marker.
7060         (f77_keywords): Likewise.
7061         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7062         entries in the dot_ops array are case insensitive, and use
7063         strncasecmp to compare strings.  Also some whitespace cleanup in
7064         this area.  Similar for the f77_keywords array, except entries in
7065         this list might be case sensitive.
7066
7067 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7068
7069         * f-exp.y (struct f77_boolean_val): Add comments.
7070         (boolean_values): Remove uppercase versions, and end marker.
7071         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7072         and use strncasecmp to achieve case insensitivity.  Additionally,
7073         perform whitespace cleanup around this code.
7074
7075 2019-03-06  Tom Tromey  <tromey@adacore.com>
7076
7077         * remote-sim.c (gdbsim_target_open): Use result of
7078         gdb_argv::release.
7079
7080 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7081         Dirk Schubert  <dirk.schubert@arm.com>
7082         Chris January  <chris.january@arm.com>
7083
7084         * eval.c (evaluate_subexp_standard): Call Fortran argument
7085         wrapping logic.
7086         * f-lang.c (struct value): A value which can be passed into a
7087         Fortran function call.
7088         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7089         where appropriate.
7090         (struct type): Value ready for a Fortran function call.
7091         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7092         is needed.
7093         * f-lang.h (fortran_argument_convert): Declaration.
7094         (fortran_preserve_arg_pointer): Declaration.
7095         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7096
7097 2019-03-05  Tom Tromey  <tromey@adacore.com>
7098
7099         * python/py-prettyprint.c (print_string_repr): Remove #if.
7100         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7101
7102 2019-03-05  Tom Tromey  <tromey@adacore.com>
7103
7104         * target.c (the_dummy_target): Move later.  Change type to
7105         "dummy_target".
7106         (initialize_targets): Don't initialize the_dummy_target.
7107
7108 2019-03-05  Tom Tromey  <tromey@adacore.com>
7109
7110         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7111         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7112
7113 2019-03-05  Tom Tromey  <tromey@adacore.com>
7114
7115         * windows-nat.c (windows_nat_target::attach)
7116         (windows_nat_target::detach): Don't call gdb_flush.
7117         * valprint.c (generic_val_print, val_print, val_print_string):
7118         Don't call gdb_flush.
7119         * utils.c (defaulted_query): Don't call gdb_flush.
7120         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7121         * target.c (target_announce_detach): Don't call gdb_flush.
7122         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7123         * remote.c (extended_remote_target::attach): Don't call
7124         gdb_flush.
7125         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7126         * printcmd.c (do_examine): Don't call gdb_flush.
7127         (info_display_command): Don't call gdb_flush.
7128         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7129         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7130         * memattr.c (info_mem_command): Don't call gdb_flush.
7131         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7132         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7133         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7134         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7135         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7136         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7137         (gnu_nat_target::detach): Don't call gdb_flush.
7138         * f-valprint.c (f_val_print): Don't call gdb_flush.
7139         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7140         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7141         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7142         gdb_flush.
7143         * c-valprint.c (c_val_print): Don't call gdb_flush.
7144         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7145
7146 2019-03-05  Tom Tromey  <tromey@adacore.com>
7147
7148         * varobj.c (update_dynamic_varobj_children): Update.
7149         (install_default_visualizer): Use reset, not release.
7150         * value.c (set_internalvar): Update.
7151         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7152         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7153         ATTRIBUTE_UNUSED_RESULT.
7154
7155 2019-03-05  Tom Tromey  <tromey@adacore.com>
7156
7157         * remote.c (class scoped_remote_fd) <release>: Add
7158         ATTRIBUTE_UNUSED_RESULT.
7159
7160 2019-03-05  Tom Tromey  <tromey@adacore.com>
7161
7162         * macroexp.c (struct macro_buffer) <release>: Add
7163         ATTRIBUTE_UNUSED_RESULT.
7164
7165 2019-03-05  Tom Tromey  <tromey@adacore.com>
7166
7167         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7168         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7169         ATTRIBUTE_UNUSED_RESULT.
7170
7171 2019-03-05  Tom Tromey  <tromey@adacore.com>
7172
7173         * common/scoped_fd.h (class scoped_fd) <release>: Add
7174         ATTRIBUTE_UNUSED_RESULT.
7175
7176 2019-03-05  Tom Tromey  <tromey@adacore.com>
7177
7178         * parser-defs.h (struct parser_state) <release>: Add
7179         ATTRIBUTE_UNUSED_RESULT.
7180
7181 2019-03-05  Tom Tromey  <tromey@adacore.com>
7182
7183         * utils.h (class gdb_argv) <release>: Add
7184         ATTRIBUTE_UNUSED_RESULT.
7185         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7186
7187 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7188
7189         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7190         for-loop range, to avoid compiler warnings.
7191
7192         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7193         avoid compiler warnings about unused variables.
7194
7195         * NEWS: Mention end of support for native debugging on MS-Windows
7196         before XP.
7197
7198         PR gdb/24292
7199         * common/netstuff.c:
7200         * gdbserver/gdbreplay.c
7201         * gdbserver/remote-utils.c:
7202         * ser-tcp.c:
7203         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7204         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7205         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7206         'getaddrinfo' and 'freeaddrinfo' were not available before
7207         Windows XP, and mingw.org's MinGW headers by default define
7208         _WIN32_WINNT to 0x500.
7209
7210 2019-03-01  Gary Benson <gbenson@redhat.com>
7211
7212         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7213
7214 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7215             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7216
7217         PR gdb/8527
7218         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7219         set_sigint_trap, clear_sigint_trap.
7220
7221 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7222
7223         * target.c (target_detach): Clear the regcache and the
7224         frame cache.
7225
7226 2019-02-27  Pedro Alves  <palves@redhat.com>
7227
7228         * utils.c (set_screen_size): When we cap the height/width sizes,
7229         tweak the corresponding command variable to show "unlimited":
7230
7231 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7232             Pedro Alves  <palves@redhat.com>
7233
7234         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7235         before calling rl_set_screen_size.
7236
7237 2019-02-27  Tom Tromey  <tromey@adacore.com>
7238
7239         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7240         define.
7241         * python/py-value.c: Remove Python 2.4 workaround.
7242         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7243         workaround.
7244         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7245         Python 2.4 workaround.
7246         * python/python-internal.h: Remove Python 2.4 comment.
7247         (Py_ssize_t): Don't define.
7248         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7249         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7250         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7251         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7252         * python/python.c (do_start_initialization): Remove Python 2.4
7253         workaround.
7254         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7255         (print_children): Remove Python 2.4 workaround.
7256         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7257         workaround.
7258         (CHARBUFFERPROC_NAME): Remove.
7259         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7260         Python 2.4 workaround.
7261
7262 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7263
7264         * NEWS: Note minimum Python version.
7265
7266 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7267
7268         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7269         code from these functions.  Remove corresponding ifdefs.  Use
7270         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7271         Remove gotos and target of gotos.
7272         (infpy_search_memory): Likewise.
7273
7274 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7275
7276         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7277         (hppa_gdbarch_init): Don't register deleted functions with
7278         gdbarch.
7279
7280 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7281
7282         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7283         (h8300_unwind_sp): Delete.
7284         (h8300_dummy_id): Delete.
7285         (h8300_gdbarch_init): Don't register deleted functions with
7286         gdbarch.
7287
7288 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7289
7290         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7291         (ft32_unwind_pc): Delete.
7292         (ft32_unwind_sp): Delete.
7293         (ft32_gdbarch_init): Don't register deleted functions with
7294         gdbarch.
7295
7296 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7297
7298         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7299         (frv_unwind_pc): Delete.
7300         (frv_unwind_sp): Delete.
7301         (frv_gdbarch_init): Don't register deleted functions with
7302         gdbarch.
7303
7304 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7305
7306         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7307         (riscv_unwind_pc): Delete.
7308         (riscv_unwind_sp): Delete.
7309         (riscv_gdbarch_init): Don't register deleted functions with
7310         gdbarch.
7311
7312 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7313
7314         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7315         (csky_unwind_pc): Delete.
7316         (csky_unwind_sp): Delete.
7317         (csky_gdbarch_init): Don't register deleted functions with
7318         gdbarch.
7319
7320 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7321
7322         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7323         (cris_unwind_pc): Delete.
7324         (cris_unwind_sp): Delete.
7325         (cris_gdbarch_init): Don't register deleted functions with
7326         gdbarch.
7327
7328 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7329
7330         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7331         (bfin_unwind_pc): Delete.
7332         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7333
7334 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7335
7336         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7337         (arm_unwind_pc): Delete.
7338         (arm_unwind_sp): Delete.
7339         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7340
7341 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7342
7343         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7344         (arc_unwind_pc): Delete.
7345         (arc_unwind_sp): Delete.
7346         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7347
7348 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7349
7350         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7351         (alpha_unwind_pc): Delete.
7352         (alpha_gdbarch_init): Don't register deleted functions with
7353         gdbarch.
7354
7355 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7356
7357         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7358         (aarch64_unwind_pc): Delete.
7359         (aarch64_unwind_sp): Delete.
7360         (aarch64_gdbarch_init): Don't register deleted functions with
7361         gdbarch.
7362
7363 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7364
7365         * gdbtypes.c (type_align): Don't consider static members when
7366         computing structure alignment.
7367
7368 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7369
7370         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7371         return 0 for other types.
7372         * arch-utils.c (default_type_align): Always return 0.
7373         * gdbarch.h: Regenerate.
7374         * gdbarch.sh (type_align): Extend comment.
7375         * gdbtypes.c (type_align): Add additional comments, always call
7376         gdbarch_type_align before applying the default rules.
7377         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7378         generic code will then apply a suitable default.
7379         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7380         types, return 0 for other types.
7381
7382 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7383
7384         * NEWS: Create a new section for the next release branch.
7385         Rename the section of the current branch, now that it has
7386         been cut.
7387
7388 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7389
7390         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7391         * version.in: Bump version to 8.3.50.DATE-git.
7392
7393 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7394
7395         * aix-thread.c (ptid_cmp): Remove unused variable.
7396         (get_signaled_thread): Likewise.
7397         (store_regs_user_thread): Likewise.
7398         (store_regs_kernel_thread): Likewise.
7399         (fetch_regs_kernel_thread): Remove shadowed variable.
7400
7401 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7402
7403         * features/riscv/32bit-cpu.xml: Add register numbers.
7404         * features/riscv/32bit-fpu.c: Regenerate.
7405         * features/riscv/32bit-fpu.xml: Add register numbers.
7406         * features/riscv/64bit-cpu.xml: Add register numbers.
7407         * features/riscv/64bit-fpu.c: Regenerate.
7408         * features/riscv/64bit-fpu.xml: Add register numbers.
7409
7410 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7411
7412         * NEWS: Mention two argument form of gdb.Value constructor.
7413         * python/py-value.c (convert_buffer_and_type_to_value): New
7414         function.
7415         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7416         Add support for handling an optional second argument.  Call
7417         convert_buffer_and_type_to_value as appropriate.
7418         * python/python-internal.h (Py_buffer_deleter): New struct.
7419         (Py_buffer_up): New typedef.
7420
7421 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7422
7423         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7424         instead of releasing ownership.
7425
7426 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7427
7428         * dwarf2read.c (open_and_init_dwp_file): Call
7429         elf_numsections instead of bfd_count_sections to initialize
7430         dwp_file->num_sections.
7431
7432 2019-02-25  Tom Tromey  <tromey@adacore.com>
7433
7434         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7435
7436 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7437
7438         * gcore.in: Add '--readnever' option when invoking GDB.
7439
7440 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7441
7442         * MAINTAINERS: Update my email address.
7443
7444 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7445
7446         * build-id.c (build_id_to_debug_bfd_1): New function.
7447         (build_id_to_debug_bfd): Look for separate debug file in
7448         sysroot.
7449
7450 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7451
7452         * gdbarch.sh: Update the copyright year range that is placed into
7453         generated files.
7454
7455 2019-02-22  Keith Seitz  <keiths@redhat.com>
7456
7457         PR symtab/23853
7458         * linespec.c (create_sals_line_offset): Search for the default
7459         symtab's filename instead of its fullname.
7460
7461 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7462
7463         * NEWS: Update style defaults.
7464
7465 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7466
7467         * main.c (captured_main_1): Disable styling in batch mode.
7468
7469 2019-02-20  Tom Tromey  <tom@tromey.com>
7470
7471         * symtab.c (symtab_symbol_info): Fix typos.
7472
7473 2019-02-20  Tom Tromey  <tromey@adacore.com>
7474
7475         * findcmd.c (_initialize_mem_search): Use upper case for
7476         metasyntactic variables.
7477
7478 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7479
7480         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7481         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7482
7483 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7484
7485         * top.h (source_file_name): Change to std::string.
7486         * top.c (source_file_name): Likewise.
7487         (command_line_input): Adjust.
7488         * cli/cli-script.c (script_from_file): Adjust.
7489
7490 2019-02-19  Tom Tromey  <tromey@adacore.com>
7491
7492         * ravenscar-thread.c
7493         (ravenscar_thread_target::update_thread_list): Don't call
7494         ada_build_task_list.
7495         * ada-lang.h (ada_build_task_list): Don't declare.
7496         * ada-tasks.c (struct ada_tasks_inferior_data)
7497         <task_list_valid_p>: Now bool.
7498         (read_known_tasks, ada_task_list_changed)
7499         (ada_tasks_invalidate_inferior_data): Update.
7500         (read_known_tasks_array): Return bool.
7501         (read_known_tasks_list): Likewise.
7502         (read_known_tasks): Return void.
7503         (ada_build_task_list): Now static.
7504
7505 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7506
7507         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7508         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7509
7510 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7511
7512         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7513         variant for ada_tasks_pspace_data_handle and
7514         ada_tasks_inferior_data_handle.
7515         (ada_tasks_pspace_data_cleanup): New function.
7516         (ada_tasks_inferior_data_cleanup): New function.
7517
7518 2019-02-17  Tom Tromey  <tom@tromey.com>
7519
7520         * macrotab.h (macro_source_fullname): Return a std::string.
7521         * macrotab.c (macro_include, check_for_redefinition)
7522         (macro_undef, macro_lookup_definition, foreach_macro)
7523         (foreach_macro_in_scope): Update.
7524         (macro_source_fullname): Return a std::string.
7525         * macrocmd.c (show_pp_source_pos): Update.
7526
7527 2019-02-17  Tom Tromey  <tom@tromey.com>
7528
7529         * macrocmd.c (show_pp_source_pos): Style the file names.
7530
7531 2019-02-17  Tom Tromey  <tom@tromey.com>
7532
7533         PR tui/24197:
7534         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7535
7536 2019-02-17  Tom Tromey  <tom@tromey.com>
7537
7538         * ada-lang.c (user_select_syms): Use filtered printing.
7539         * utils.c (wrap_style): New global.
7540         (desired_style): Remove.
7541         (emit_style_escape): Add stream parameter.
7542         (set_output_style, reset_terminal_style, prompt_for_continue):
7543         Update.
7544         (flush_wrap_buffer): Only flush gdb_stdout.
7545         (wrap_here): Set wrap_style.
7546         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7547         treat escape sequences as a character.  Change when wrap buffer is
7548         flushed.
7549         (fputs_styled): Do not set the output style when the default is
7550         requested.
7551         * ui-style.h (struct ui_file_style) <is_default>: New method.
7552         * source.c (print_source_lines_base): Emit escape sequences in one
7553         piece.
7554
7555 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7556
7557         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7558         integers and enumeration types.
7559
7560 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7561
7562         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7563         instead of lookup_symbol_in_language
7564         (do_exact_match): New function.
7565         (ada_get_symbol_name_matcher): Return do_exact_match when
7566         doing a verbatim match.
7567
7568 2019-02-15  Tom Tromey  <tromey@adacore.com>
7569
7570         * ravenscar-thread.c (ravenscar_thread_target::resume)
7571         (ravenscar_thread_target::wait): Special case wildcard requests.
7572
7573 2019-02-15  Tom Tromey  <tromey@adacore.com>
7574
7575         * ravenscar-thread.c (base_ptid): Remove.
7576         (struct ravenscar_thread_target) <close>: New method.
7577         <m_base_ptid>: New member.
7578         <update_inferior_ptid, active_task, task_is_currently_active,
7579         runtime_initialized>: Declare methods.
7580         <ravenscar_thread_target>: Add constructor.
7581         (ravenscar_thread_target::task_is_currently_active)
7582         (ravenscar_thread_target::update_inferior_ptid)
7583         (ravenscar_runtime_initialized): Rename.  Now methods.
7584         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7585         (ravenscar_thread_target::update_thread_list): Update.
7586         (ravenscar_thread_target::active_task): Now method.
7587         (ravenscar_thread_target::store_registers)
7588         (ravenscar_thread_target::prepare_to_store)
7589         (ravenscar_thread_target::prepare_to_store)
7590         (ravenscar_thread_target::mourn_inferior): Update.
7591         (ravenscar_inferior_created): Use "new" to create target.
7592         (ravenscar_thread_target::get_ada_task_ptid): Update.
7593         (_initialize_ravenscar): Don't initialize base_ptid.
7594         (ravenscar_ops): Remove global.
7595
7596 2019-02-15  Tom Tromey  <tromey@adacore.com>
7597
7598         * target.h (push_target): Declare new overload.
7599         * target.c (push_target): New overload, taking an rvalue reference.
7600         * remote.c (remote_target::open_1): Use push_target overload.
7601         * corelow.c (core_target_open): Use push_target overload.
7602
7603 2019-02-15  Tom Tromey  <tromey@adacore.com>
7604
7605         * ravenscar-thread.c (is_ravenscar_task)
7606         (ravenscar_task_is_currently_active): Return bool.
7607         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7608         (_initialize_ravenscar): Remove "(void)".
7609         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7610         Return bool.
7611
7612 2019-02-15  Tom Tromey  <tromey@adacore.com>
7613
7614         * ravenscar-thread.c (ravenscar_runtime_initializer)
7615         (has_ravenscar_runtime, get_running_thread_id)
7616         (ravenscar_thread_target::resume): Fix indentation.
7617
7618 2019-02-15  Tom Tromey  <tromey@adacore.com>
7619
7620         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7621         from ravenscar_arch_ops.
7622         (sparc_ravenscar_ops::fetch_registers)
7623         (sparc_ravenscar_ops::store_registers): Now methods.
7624         (sparc_ravenscar_prepare_to_store): Remove.
7625         (sparc_ravenscar_ops): Redefine.
7626         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7627         methods and destructor.  Remove members.
7628         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7629         (ravenscar_thread_target::store_registers)
7630         (ravenscar_thread_target::prepare_to_store): Update.
7631         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7632         Remove.
7633         (struct ppc_ravenscar_powerpc_ops): Derive from
7634         ravenscar_arch_ops.
7635         (ppc_ravenscar_powerpc_ops::fetch_registers)
7636         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7637         (ppc_ravenscar_powerpc_ops): Redefine.
7638         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7639         (ppc_ravenscar_e500_ops::fetch_registers)
7640         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7641         (ppc_ravenscar_e500_ops): Redefine.
7642         * aarch64-ravenscar-thread.c
7643         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7644         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7645         (aarch64_ravenscar_fetch_registers)
7646         (aarch64_ravenscar_store_registers): Now methods.
7647         (aarch64_ravenscar_ops): Redefine.
7648
7649 2019-02-15  Tom Tromey  <tromey@adacore.com>
7650
7651         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7652         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7653         (ravenscar_thread_target::stopped_by_watchpoint)
7654         (ravenscar_thread_target::stopped_data_address)
7655         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7656
7657 2019-02-15  Tom Tromey  <tromey@adacore.com>
7658
7659         * ravenscar-thread.c: Fix some typos.
7660
7661 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7662             Tom Tromey  <tromey@adacore.com>
7663
7664         * ada-lang.c (ada_exception_sal): Change addr_string to a
7665         std::string.
7666         (create_ada_exception_catchpoint): Update.
7667
7668 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7669             Tom Tromey  <tromey@adacore.com>
7670
7671         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7672         (bp_location_ops): Remove.
7673         (base_breakpoint_allocate_location): Update.
7674         (free_bp_location): Update.
7675         * ada-lang.c (class ada_catchpoint_location)
7676         <ada_catchpoint_location>: Remove ops parameter.
7677         (ada_catchpoint_location_dtor): Remove.
7678         (ada_catchpoint_location_ops): Remove.
7679         (allocate_location_exception): Update.
7680         * breakpoint.h (struct bp_location_ops): Remove.
7681         (class bp_location) <bp_location>: Remove bp_location_ops
7682         parameter.
7683         <~bp_location>: Add destructor.
7684         <ops>: Remove.
7685
7686 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7687             Pedro Alves  <palves@redhat.com>
7688
7689         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7690         'PATH_MAX'.
7691
7692 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7693             Samuel Thibault  <samuel.thibault@gnu.org>
7694             Thomas Schwinge  <thomas@codesourcery.com>
7695
7696         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7697         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7698
7699 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7700
7701         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7702         (check_empty): Use "const char *".
7703
7704         * gnu-nat.c (gnu_nat_target::detach): Instead of
7705         'detach_inferior (pid)' call
7706         'detach_inferior (find_inferior_pid (pid))'.
7707
7708         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7709         'nat/fork-inferior.o'.
7710         * gnu-nat.c: #include "nat/fork-inferior.h".
7711
7712         * gnu-nat.c (gnu_nat_target::detach): Instead of
7713         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7714         * gnu-nat.h: #include "inf-child.h".
7715         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7716         'i386_gnu_nat_target::fetch_registers'.
7717         (gnu_store_registers): Rename/move to
7718         'i386_gnu_nat_target::store_registers'.
7719
7720         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7721         * gnu-nat.h (mach_thread_info): New function.
7722         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7723
7724         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7725
7726 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7727
7728         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7729
7730 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7731
7732         * windows-nat.c (windows_add_thread): Add new parameter
7733         "main_thread_p" with default value set to false.  Update
7734         function documentation as well as all callers.
7735         (windows_delete_thread): Likewise.
7736         (fake_create_process): Update call to windows_add_thread.
7737         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7738         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7739         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7740         call to windows_delete_thread.
7741
7742 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7743
7744         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7745
7746 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7747
7748         * symfile.c (find_separate_debug_file): Use canonical path of
7749         sysroot with child_path instead of gdb_sysroot if it is valid.
7750
7751 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7752
7753         * symfile.c (find_separate_debug_file): Use child_path to
7754         determine if an object file is under a sysroot.
7755
7756 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7757
7758         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7759         unittests/child-path-selftests.c.
7760         * common/pathstuff.c (child_path): New function.
7761         * common/pathstuff.h (child_path): New prototype.
7762         * unittests/child-path-selftests.c: New file.
7763
7764 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7765
7766         * symfile.c (find_separate_debug_file): Look for separate debug
7767         files in debug directories under the sysroot.
7768
7769 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7770
7771         * symtab.h (struct minimal_symbol data_p): New const method.
7772         (struct minimal_symbol text_p): Likewise.
7773         * symtab.c (output_source_filename): Use file name style
7774         to print file name.
7775         (print_symbol_info): Likewise.
7776         (print_msymbol_info): Use address style to print addresses.
7777         Use function name style to print executable text symbols.
7778         (expand_symtab_containing_pc): Use data_p.
7779         (find_pc_sect_compunit_symtab): Likewise.
7780
7781 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7782
7783         * breakpoint.c (describe_other_breakpoints): Use address style
7784         to print addresses.
7785         (say_where): Likewise.
7786
7787 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7788
7789         * ada-typeprint.c (print_func_type): Print function name
7790         style to print function name.
7791         * c-typeprint.c (c_print_type_1): Likewise.
7792
7793 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7794
7795         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7796         for execve.
7797
7798 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7799
7800         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7801         type_stack.
7802
7803 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7804
7805         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7806         TYPE_CODE_REF types.
7807
7808 2019-02-08  Jim Wilson  <jimw@sifive.com>
7809
7810         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7811         (riscv_linux_fregset): New.
7812         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7813
7814 2019-02-07  Tom Tromey  <tom@tromey.com>
7815
7816         * thread.c (thread_cancel_execution_command): Update.
7817         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7818         methods.
7819         (struct thread_fsm_ops): Remove.
7820         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7821         (thread_fsm_should_stop, thread_fsm_return_value)
7822         (thread_fsm_set_finished, thread_fsm_finished_p)
7823         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7824         Don't declare.
7825         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7826         * infrun.c (clear_proceed_status_thread)
7827         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7828         (print_stop_event): Update.
7829         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7830         Add constructor.
7831         (step_command_fsm_ops): Remove.
7832         (new_step_command_fsm): Remove.
7833         (step_1): Update.
7834         (step_command_fsm::should_stop): Rename from
7835         step_command_fsm_should_stop.
7836         (step_command_fsm::clean_up): Rename from
7837         step_command_fsm_clean_up.
7838         (step_command_fsm::do_async_reply_reason): Rename from
7839         step_command_fsm_async_reply_reason.
7840         (struct until_next_fsm): Inherit from thread_fsm.  Add
7841         constructor.
7842         (until_next_fsm_ops): Remove.
7843         (new_until_next_fsm): Remove.
7844         (until_next_fsm::should_stop): Rename from
7845         until_next_fsm_should_stop.
7846         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7847         (until_next_fsm::do_async_reply_reason): Rename from
7848         until_next_fsm_async_reply_reason.
7849         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7850         constructor.  Change type of breakpoint.
7851         (finish_command_fsm_ops): Remove.
7852         (new_finish_command_fsm): Remove.
7853         (finish_command_fsm::should_stop): Rename from
7854         finish_command_fsm_should_stop.
7855         (finish_command_fsm::clean_up): Rename from
7856         finish_command_fsm_clean_up.
7857         (finish_command_fsm::return_value): Rename from
7858         finish_command_fsm_return_value.
7859         (finish_command_fsm::do_async_reply_reason): Rename from
7860         finish_command_fsm_async_reply_reason.
7861         (finish_command): Update.
7862         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7863         Add constructor.
7864         (call_thread_fsm_ops): Remove.
7865         (call_thread_fsm::call_thread_fsm): Rename from
7866         new_call_thread_fsm.
7867         (call_thread_fsm::should_stop): Rename from
7868         call_thread_fsm_should_stop.
7869         (call_thread_fsm::should_notify_stop): Rename from
7870         call_thread_fsm_should_notify_stop.
7871         (run_inferior_call, call_function_by_hand_dummy): Update.
7872         * cli/cli-interp.c (should_print_stop_to_console): Update.
7873         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7874         Add constructor.  Change type of location_breakpoint,
7875         caller_breakpoint.
7876         (until_break_fsm_ops): Remove.
7877         (new_until_break_fsm): Remove.
7878         (until_break_fsm::should_stop): Rename from
7879         until_break_fsm_should_stop.
7880         (until_break_fsm::clean_up): Rename from
7881         until_break_fsm_clean_up.
7882         (until_break_fsm::do_async_reply_reason): Rename from
7883         until_break_fsm_async_reply_reason.
7884         (until_break_command): Update.
7885         * thread-fsm.c: Remove.
7886         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7887
7888 2019-02-07  Tom Tromey  <tom@tromey.com>
7889
7890         * yy-remap.h: Add include guard.
7891         * xtensa-tdep.h: Add include guard.
7892         * xcoffread.h: Rename include guard.
7893         * varobj-iter.h: Add include guard.
7894         * tui/tui.h: Rename include guard.
7895         * tui/tui-winsource.h: Rename include guard.
7896         * tui/tui-wingeneral.h: Rename include guard.
7897         * tui/tui-windata.h: Rename include guard.
7898         * tui/tui-win.h: Rename include guard.
7899         * tui/tui-stack.h: Rename include guard.
7900         * tui/tui-source.h: Rename include guard.
7901         * tui/tui-regs.h: Rename include guard.
7902         * tui/tui-out.h: Rename include guard.
7903         * tui/tui-layout.h: Rename include guard.
7904         * tui/tui-io.h: Rename include guard.
7905         * tui/tui-hooks.h: Rename include guard.
7906         * tui/tui-file.h: Rename include guard.
7907         * tui/tui-disasm.h: Rename include guard.
7908         * tui/tui-data.h: Rename include guard.
7909         * tui/tui-command.h: Rename include guard.
7910         * tic6x-tdep.h: Add include guard.
7911         * target/waitstatus.h: Rename include guard.
7912         * target/wait.h: Rename include guard.
7913         * target/target.h: Rename include guard.
7914         * target/resume.h: Rename include guard.
7915         * target-float.h: Rename include guard.
7916         * stabsread.h: Add include guard.
7917         * rs6000-tdep.h: Add include guard.
7918         * riscv-fbsd-tdep.h: Add include guard.
7919         * regformats/regdef.h: Rename include guard.
7920         * record.h: Rename include guard.
7921         * python/python.h: Rename include guard.
7922         * python/python-internal.h: Rename include guard.
7923         * python/py-stopevent.h: Rename include guard.
7924         * python/py-ref.h: Rename include guard.
7925         * python/py-record.h: Rename include guard.
7926         * python/py-record-full.h: Rename include guard.
7927         * python/py-record-btrace.h: Rename include guard.
7928         * python/py-instruction.h: Rename include guard.
7929         * python/py-events.h: Rename include guard.
7930         * python/py-event.h: Rename include guard.
7931         * procfs.h: Add include guard.
7932         * proc-utils.h: Add include guard.
7933         * p-lang.h: Add include guard.
7934         * or1k-tdep.h: Rename include guard.
7935         * observable.h: Rename include guard.
7936         * nto-tdep.h: Rename include guard.
7937         * nat/x86-linux.h: Rename include guard.
7938         * nat/x86-linux-dregs.h: Rename include guard.
7939         * nat/x86-gcc-cpuid.h: Add include guard.
7940         * nat/x86-dregs.h: Rename include guard.
7941         * nat/x86-cpuid.h: Rename include guard.
7942         * nat/ppc-linux.h: Rename include guard.
7943         * nat/mips-linux-watch.h: Rename include guard.
7944         * nat/linux-waitpid.h: Rename include guard.
7945         * nat/linux-ptrace.h: Rename include guard.
7946         * nat/linux-procfs.h: Rename include guard.
7947         * nat/linux-osdata.h: Rename include guard.
7948         * nat/linux-nat.h: Rename include guard.
7949         * nat/linux-namespaces.h: Rename include guard.
7950         * nat/linux-btrace.h: Rename include guard.
7951         * nat/glibc_thread_db.h: Rename include guard.
7952         * nat/gdb_thread_db.h: Rename include guard.
7953         * nat/gdb_ptrace.h: Rename include guard.
7954         * nat/fork-inferior.h: Rename include guard.
7955         * nat/amd64-linux-siginfo.h: Rename include guard.
7956         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7957         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7958         * nat/aarch64-linux.h: Rename include guard.
7959         * nat/aarch64-linux-hw-point.h: Rename include guard.
7960         * mn10300-tdep.h: Add include guard.
7961         * mips-linux-tdep.h: Add include guard.
7962         * mi/mi-parse.h: Rename include guard.
7963         * mi/mi-out.h: Rename include guard.
7964         * mi/mi-main.h: Rename include guard.
7965         * mi/mi-interp.h: Rename include guard.
7966         * mi/mi-getopt.h: Rename include guard.
7967         * mi/mi-console.h: Rename include guard.
7968         * mi/mi-common.h: Rename include guard.
7969         * mi/mi-cmds.h: Rename include guard.
7970         * mi/mi-cmd-break.h: Rename include guard.
7971         * m2-lang.h: Add include guard.
7972         * location.h: Rename include guard.
7973         * linux-record.h: Rename include guard.
7974         * linux-nat.h: Add include guard.
7975         * linux-fork.h: Add include guard.
7976         * i386-darwin-tdep.h: Rename include guard.
7977         * hppa-linux-offsets.h: Add include guard.
7978         * guile/guile.h: Rename include guard.
7979         * guile/guile-internal.h: Rename include guard.
7980         * gnu-nat.h: Rename include guard.
7981         * gdb-stabs.h: Rename include guard.
7982         * frv-tdep.h: Add include guard.
7983         * f-lang.h: Add include guard.
7984         * event-loop.h: Add include guard.
7985         * darwin-nat.h: Rename include guard.
7986         * cp-abi.h: Rename include guard.
7987         * config/sparc/nm-sol2.h: Rename include guard.
7988         * config/nm-nto.h: Rename include guard.
7989         * config/nm-linux.h: Add include guard.
7990         * config/i386/nm-i386gnu.h: Rename include guard.
7991         * config/djgpp/nl_types.h: Rename include guard.
7992         * config/djgpp/langinfo.h: Rename include guard.
7993         * compile/gcc-cp-plugin.h: Add include guard.
7994         * compile/gcc-c-plugin.h: Add include guard.
7995         * compile/compile.h: Rename include guard.
7996         * compile/compile-object-run.h: Rename include guard.
7997         * compile/compile-object-load.h: Rename include guard.
7998         * compile/compile-internal.h: Rename include guard.
7999         * compile/compile-cplus.h: Rename include guard.
8000         * compile/compile-c.h: Rename include guard.
8001         * common/xml-utils.h: Rename include guard.
8002         * common/x86-xstate.h: Rename include guard.
8003         * common/version.h: Rename include guard.
8004         * common/vec.h: Rename include guard.
8005         * common/tdesc.h: Rename include guard.
8006         * common/selftest.h: Rename include guard.
8007         * common/scoped_restore.h: Rename include guard.
8008         * common/scoped_mmap.h: Rename include guard.
8009         * common/scoped_fd.h: Rename include guard.
8010         * common/safe-iterator.h: Rename include guard.
8011         * common/run-time-clock.h: Rename include guard.
8012         * common/refcounted-object.h: Rename include guard.
8013         * common/queue.h: Rename include guard.
8014         * common/ptid.h: Rename include guard.
8015         * common/print-utils.h: Rename include guard.
8016         * common/preprocessor.h: Rename include guard.
8017         * common/pathstuff.h: Rename include guard.
8018         * common/observable.h: Rename include guard.
8019         * common/netstuff.h: Rename include guard.
8020         * common/job-control.h: Rename include guard.
8021         * common/host-defs.h: Rename include guard.
8022         * common/gdb_wait.h: Rename include guard.
8023         * common/gdb_vecs.h: Rename include guard.
8024         * common/gdb_unlinker.h: Rename include guard.
8025         * common/gdb_unique_ptr.h: Rename include guard.
8026         * common/gdb_tilde_expand.h: Rename include guard.
8027         * common/gdb_sys_time.h: Rename include guard.
8028         * common/gdb_string_view.h: Rename include guard.
8029         * common/gdb_splay_tree.h: Rename include guard.
8030         * common/gdb_setjmp.h: Rename include guard.
8031         * common/gdb_ref_ptr.h: Rename include guard.
8032         * common/gdb_optional.h: Rename include guard.
8033         * common/gdb_locale.h: Rename include guard.
8034         * common/gdb_assert.h: Rename include guard.
8035         * common/filtered-iterator.h: Rename include guard.
8036         * common/filestuff.h: Rename include guard.
8037         * common/fileio.h: Rename include guard.
8038         * common/environ.h: Rename include guard.
8039         * common/common-utils.h: Rename include guard.
8040         * common/common-types.h: Rename include guard.
8041         * common/common-regcache.h: Rename include guard.
8042         * common/common-inferior.h: Rename include guard.
8043         * common/common-gdbthread.h: Rename include guard.
8044         * common/common-exceptions.h: Rename include guard.
8045         * common/common-defs.h: Rename include guard.
8046         * common/common-debug.h: Rename include guard.
8047         * common/cleanups.h: Rename include guard.
8048         * common/buffer.h: Rename include guard.
8049         * common/btrace-common.h: Rename include guard.
8050         * common/break-common.h: Rename include guard.
8051         * cli/cli-utils.h: Rename include guard.
8052         * cli/cli-style.h: Rename include guard.
8053         * cli/cli-setshow.h: Rename include guard.
8054         * cli/cli-script.h: Rename include guard.
8055         * cli/cli-interp.h: Rename include guard.
8056         * cli/cli-decode.h: Rename include guard.
8057         * cli/cli-cmds.h: Rename include guard.
8058         * charset-list.h: Add include guard.
8059         * buildsym-legacy.h: Rename include guard.
8060         * bfin-tdep.h: Add include guard.
8061         * ax.h: Rename include guard.
8062         * arm-linux-tdep.h: Add include guard.
8063         * arm-fbsd-tdep.h: Add include guard.
8064         * arch/xtensa.h: Rename include guard.
8065         * arch/tic6x.h: Add include guard.
8066         * arch/i386.h: Add include guard.
8067         * arch/arm.h: Rename include guard.
8068         * arch/arm-linux.h: Rename include guard.
8069         * arch/arm-get-next-pcs.h: Rename include guard.
8070         * arch/amd64.h: Add include guard.
8071         * arch/aarch64-insn.h: Rename include guard.
8072         * arch-utils.h: Rename include guard.
8073         * annotate.h: Add include guard.
8074         * amd64-darwin-tdep.h: Rename include guard.
8075         * aarch64-linux-tdep.h: Add include guard.
8076         * aarch64-fbsd-tdep.h: Add include guard.
8077         * aarch32-linux-nat.h: Add include guard.
8078
8079 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8080
8081         * macrotab.c (macro_define_internal): New function that
8082         factorizes macro_define_object_internal and macro_define_function
8083         code.
8084         (macro_define_object_internal): Use macro_define_internal.
8085         (macro_define_function): Likewise.
8086
8087 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8088
8089         * macrocmd.c (extract_identifier): Return
8090         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8091         callers.
8092
8093 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8094
8095         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8096
8097 2019-02-05  Tom Tromey  <tom@tromey.com>
8098
8099         * target.c (target_stack::unpush): Move assertion earlier.
8100
8101 2019-01-30  Tom Tromey  <tom@tromey.com>
8102
8103         PR python/23615:
8104         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8105         (gdbpy_parse_and_eval): Likewise.
8106         * python/python-internal.h (gdbpy_allow_threads): New class.
8107
8108 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8109
8110         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8111         (aarch64_fbsd_fpregmap): Move earlier.
8112         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8113         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8114         instead of individual calls to trad_frame_set_reg_addr.
8115         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8116         earlier.
8117         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8118         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8119         instead of individual calls to trad_frame_set_reg_addr.
8120
8121 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8122
8123         * CONTRIBUTE: Replace contribution list with wiki link.
8124
8125 2019-01-25  Tom Tromey  <tom@tromey.com>
8126
8127         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8128
8129 2019-01-25  Tom Tromey  <tom@tromey.com>
8130
8131         * xtensa-linux-nat.c: Fix common/ includes.
8132         * xml-support.h: Fix common/ includes.
8133         * xml-support.c: Fix common/ includes.
8134         * x86-linux-nat.c: Fix common/ includes.
8135         * windows-nat.c: Fix common/ includes.
8136         * varobj.h: Fix common/ includes.
8137         * varobj.c: Fix common/ includes.
8138         * value.c: Fix common/ includes.
8139         * valops.c: Fix common/ includes.
8140         * utils.c: Fix common/ includes.
8141         * unittests/xml-utils-selftests.c: Fix common/ includes.
8142         * unittests/utils-selftests.c: Fix common/ includes.
8143         * unittests/unpack-selftests.c: Fix common/ includes.
8144         * unittests/tracepoint-selftests.c: Fix common/ includes.
8145         * unittests/style-selftests.c: Fix common/ includes.
8146         * unittests/string_view-selftests.c: Fix common/ includes.
8147         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8148         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8149         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8150         * unittests/rsp-low-selftests.c: Fix common/ includes.
8151         * unittests/parse-connection-spec-selftests.c: Fix common/
8152         includes.
8153         * unittests/optional-selftests.c: Fix common/ includes.
8154         * unittests/offset-type-selftests.c: Fix common/ includes.
8155         * unittests/observable-selftests.c: Fix common/ includes.
8156         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8157         * unittests/memrange-selftests.c: Fix common/ includes.
8158         * unittests/memory-map-selftests.c: Fix common/ includes.
8159         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8160         * unittests/function-view-selftests.c: Fix common/ includes.
8161         * unittests/environ-selftests.c: Fix common/ includes.
8162         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8163         * unittests/common-utils-selftests.c: Fix common/ includes.
8164         * unittests/cli-utils-selftests.c: Fix common/ includes.
8165         * unittests/array-view-selftests.c: Fix common/ includes.
8166         * ui-file.c: Fix common/ includes.
8167         * tui/tui-io.c: Fix common/ includes.
8168         * tracepoint.h: Fix common/ includes.
8169         * tracepoint.c: Fix common/ includes.
8170         * tracefile-tfile.c: Fix common/ includes.
8171         * top.h: Fix common/ includes.
8172         * top.c: Fix common/ includes.
8173         * thread.c: Fix common/ includes.
8174         * target/waitstatus.h: Fix common/ includes.
8175         * target/waitstatus.c: Fix common/ includes.
8176         * target.h: Fix common/ includes.
8177         * target.c: Fix common/ includes.
8178         * target-memory.c: Fix common/ includes.
8179         * target-descriptions.c: Fix common/ includes.
8180         * symtab.h: Fix common/ includes.
8181         * symfile.c: Fix common/ includes.
8182         * stap-probe.c: Fix common/ includes.
8183         * spu-linux-nat.c: Fix common/ includes.
8184         * sparc-nat.c: Fix common/ includes.
8185         * source.c: Fix common/ includes.
8186         * solib.c: Fix common/ includes.
8187         * solib-target.c: Fix common/ includes.
8188         * ser-unix.c: Fix common/ includes.
8189         * ser-tcp.c: Fix common/ includes.
8190         * ser-pipe.c: Fix common/ includes.
8191         * ser-base.c: Fix common/ includes.
8192         * selftest-arch.c: Fix common/ includes.
8193         * s12z-tdep.c: Fix common/ includes.
8194         * rust-exp.y: Fix common/ includes.
8195         * rs6000-aix-tdep.c: Fix common/ includes.
8196         * riscv-tdep.c: Fix common/ includes.
8197         * remote.c: Fix common/ includes.
8198         * remote-notif.h: Fix common/ includes.
8199         * remote-fileio.h: Fix common/ includes.
8200         * remote-fileio.c: Fix common/ includes.
8201         * regcache.h: Fix common/ includes.
8202         * regcache.c: Fix common/ includes.
8203         * record-btrace.c: Fix common/ includes.
8204         * python/python.c: Fix common/ includes.
8205         * python/py-type.c: Fix common/ includes.
8206         * python/py-inferior.c: Fix common/ includes.
8207         * progspace.h: Fix common/ includes.
8208         * producer.c: Fix common/ includes.
8209         * procfs.c: Fix common/ includes.
8210         * proc-api.c: Fix common/ includes.
8211         * printcmd.c: Fix common/ includes.
8212         * ppc-linux-nat.c: Fix common/ includes.
8213         * parser-defs.h: Fix common/ includes.
8214         * osdata.c: Fix common/ includes.
8215         * obsd-nat.c: Fix common/ includes.
8216         * nat/x86-linux.c: Fix common/ includes.
8217         * nat/x86-linux-dregs.c: Fix common/ includes.
8218         * nat/x86-dregs.h: Fix common/ includes.
8219         * nat/x86-dregs.c: Fix common/ includes.
8220         * nat/ppc-linux.c: Fix common/ includes.
8221         * nat/mips-linux-watch.h: Fix common/ includes.
8222         * nat/mips-linux-watch.c: Fix common/ includes.
8223         * nat/linux-waitpid.c: Fix common/ includes.
8224         * nat/linux-ptrace.h: Fix common/ includes.
8225         * nat/linux-ptrace.c: Fix common/ includes.
8226         * nat/linux-procfs.c: Fix common/ includes.
8227         * nat/linux-personality.c: Fix common/ includes.
8228         * nat/linux-osdata.c: Fix common/ includes.
8229         * nat/linux-namespaces.c: Fix common/ includes.
8230         * nat/linux-btrace.h: Fix common/ includes.
8231         * nat/linux-btrace.c: Fix common/ includes.
8232         * nat/fork-inferior.c: Fix common/ includes.
8233         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8234         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8235         * nat/aarch64-linux.c: Fix common/ includes.
8236         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8237         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8238         * namespace.h: Fix common/ includes.
8239         * mips-linux-tdep.c: Fix common/ includes.
8240         * minsyms.c: Fix common/ includes.
8241         * mi/mi-parse.h: Fix common/ includes.
8242         * mi/mi-main.c: Fix common/ includes.
8243         * mi/mi-cmd-env.c: Fix common/ includes.
8244         * memrange.h: Fix common/ includes.
8245         * memattr.c: Fix common/ includes.
8246         * maint.h: Fix common/ includes.
8247         * maint.c: Fix common/ includes.
8248         * main.c: Fix common/ includes.
8249         * machoread.c: Fix common/ includes.
8250         * location.c: Fix common/ includes.
8251         * linux-thread-db.c: Fix common/ includes.
8252         * linux-nat.c: Fix common/ includes.
8253         * linux-fork.c: Fix common/ includes.
8254         * inline-frame.c: Fix common/ includes.
8255         * infrun.c: Fix common/ includes.
8256         * inflow.c: Fix common/ includes.
8257         * inferior.h: Fix common/ includes.
8258         * inferior.c: Fix common/ includes.
8259         * infcmd.c: Fix common/ includes.
8260         * inf-ptrace.c: Fix common/ includes.
8261         * inf-child.c: Fix common/ includes.
8262         * ia64-linux-nat.c: Fix common/ includes.
8263         * i387-tdep.c: Fix common/ includes.
8264         * i386-tdep.c: Fix common/ includes.
8265         * i386-linux-tdep.c: Fix common/ includes.
8266         * i386-linux-nat.c: Fix common/ includes.
8267         * i386-go32-tdep.c: Fix common/ includes.
8268         * i386-fbsd-tdep.c: Fix common/ includes.
8269         * i386-fbsd-nat.c: Fix common/ includes.
8270         * guile/scm-type.c: Fix common/ includes.
8271         * guile/guile.c: Fix common/ includes.
8272         * go32-nat.c: Fix common/ includes.
8273         * gnu-nat.c: Fix common/ includes.
8274         * gdbthread.h: Fix common/ includes.
8275         * gdbarch-selftests.c: Fix common/ includes.
8276         * gdb_usleep.c: Fix common/ includes.
8277         * gdb_select.h: Fix common/ includes.
8278         * gdb_bfd.c: Fix common/ includes.
8279         * gcore.c: Fix common/ includes.
8280         * fork-child.c: Fix common/ includes.
8281         * findvar.c: Fix common/ includes.
8282         * fbsd-nat.c: Fix common/ includes.
8283         * event-top.c: Fix common/ includes.
8284         * event-loop.c: Fix common/ includes.
8285         * dwarf2read.c: Fix common/ includes.
8286         * dwarf2loc.c: Fix common/ includes.
8287         * dwarf2-frame.c: Fix common/ includes.
8288         * dwarf-index-cache.c: Fix common/ includes.
8289         * dtrace-probe.c: Fix common/ includes.
8290         * disasm-selftests.c: Fix common/ includes.
8291         * defs.h: Fix common/ includes.
8292         * csky-tdep.c: Fix common/ includes.
8293         * cp-valprint.c: Fix common/ includes.
8294         * cp-support.h: Fix common/ includes.
8295         * cp-support.c: Fix common/ includes.
8296         * corelow.c: Fix common/ includes.
8297         * completer.h: Fix common/ includes.
8298         * completer.c: Fix common/ includes.
8299         * compile/compile.c: Fix common/ includes.
8300         * compile/compile-loc2c.c: Fix common/ includes.
8301         * compile/compile-cplus-types.c: Fix common/ includes.
8302         * compile/compile-cplus-symbols.c: Fix common/ includes.
8303         * command.h: Fix common/ includes.
8304         * cli/cli-dump.c: Fix common/ includes.
8305         * cli/cli-cmds.c: Fix common/ includes.
8306         * charset.c: Fix common/ includes.
8307         * build-id.c: Fix common/ includes.
8308         * btrace.h: Fix common/ includes.
8309         * btrace.c: Fix common/ includes.
8310         * breakpoint.h: Fix common/ includes.
8311         * breakpoint.c: Fix common/ includes.
8312         * ax.h:
8313         (enum agent_op): Fix common/ includes.
8314         * ax-general.c (struct aop_map): Fix common/ includes.
8315         * ax-gdb.c: Fix common/ includes.
8316         * auxv.c: Fix common/ includes.
8317         * auto-load.c: Fix common/ includes.
8318         * arm-tdep.c: Fix common/ includes.
8319         * arch/riscv.c: Fix common/ includes.
8320         * arch/ppc-linux-common.c: Fix common/ includes.
8321         * arch/i386.c: Fix common/ includes.
8322         * arch/arm.c: Fix common/ includes.
8323         * arch/arm-linux.c: Fix common/ includes.
8324         * arch/arm-get-next-pcs.c: Fix common/ includes.
8325         * arch/amd64.c: Fix common/ includes.
8326         * arch/aarch64.c: Fix common/ includes.
8327         * arch/aarch64-insn.c: Fix common/ includes.
8328         * arch-utils.c: Fix common/ includes.
8329         * amd64-windows-tdep.c: Fix common/ includes.
8330         * amd64-tdep.c: Fix common/ includes.
8331         * amd64-sol2-tdep.c: Fix common/ includes.
8332         * amd64-obsd-tdep.c: Fix common/ includes.
8333         * amd64-nbsd-tdep.c: Fix common/ includes.
8334         * amd64-linux-tdep.c: Fix common/ includes.
8335         * amd64-linux-nat.c: Fix common/ includes.
8336         * amd64-fbsd-tdep.c: Fix common/ includes.
8337         * amd64-fbsd-nat.c: Fix common/ includes.
8338         * amd64-dicos-tdep.c: Fix common/ includes.
8339         * amd64-darwin-tdep.c: Fix common/ includes.
8340         * agent.c: Fix common/ includes.
8341         * ada-lang.h: Fix common/ includes.
8342         * ada-lang.c: Fix common/ includes.
8343         * aarch64-tdep.c: Fix common/ includes.
8344
8345 2019-01-25  Tom Tromey  <tom@tromey.com>
8346
8347         * common/create-version.sh: Use common/version.h.
8348
8349 2019-01-24  Pedro Alves  <palves@redhat.com>
8350
8351         * infrun.c (signal_stop, signal_print, signal_program)
8352         (signal_catch, signal_pass): Now arrays instead of pointers.
8353         (update_signals_program_target, do_target_resume)
8354         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8355         * linux-nat.c (linux_nat_target::pass_signals)
8356         (linux_nat_target::create_inferior, linux_nat_target::attach):
8357         Adjust.
8358         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8359         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8360         * procfs.c (procfs_target::pass_signals): Adjust.
8361         * record-full.c (record_full_target::resume): Adjust.
8362         * remote.c (remote_target::pass_signals)
8363         (remote_target::program_signals): Adjust.
8364         * target-debug.h (target_debug_print_signals): Now takes a
8365         gdb::array_view as parameter.  Adjust.
8366         * target.h (target_ops) <pass_signals, program_signals>: Replace
8367         pointer and length parameters with gdb::array_view.
8368         (target_pass_signals, target_program_signals): Likewise.
8369         * target-delegates.c: Regenerate.
8370
8371 2019-01-24  Pedro Alves  <palves@redhat.com>
8372
8373         * common/forward-scope-exit.h
8374         (forward_scope_exit::forward_scope_exit): Pass arguments to
8375         m_bind_function directly, instead of creating a std::bind and
8376         copying that.
8377
8378 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8379
8380         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8381         for static members.
8382         (pass_in_v_vfp_candidate): Likewise.
8383
8384 2019-01-23  Tom Tromey  <tom@tromey.com>
8385             Pedro Alves  <palves@redhat.com>
8386
8387         * regcache.c (class regcache_invalidator): Remove.
8388         (regcache::raw_write): Use make_scope_exit.
8389
8390 2019-01-23  Tom Tromey  <tom@tromey.com>
8391
8392         * ui-out.h (class ui_out_emit_type): Update comment.
8393
8394 2019-01-23  Tom Tromey  <tom@tromey.com>
8395
8396         * infrun.c (fetch_inferior_event): Update comment.
8397
8398 2019-01-23  Tom Tromey  <tom@tromey.com>
8399             Pedro Alves  <palves@redhat.com>
8400
8401         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8402         parameter.
8403         (fetch_inferior_event): Use SCOPE_EXIT.
8404
8405
8406 2019-01-23  Tom Tromey  <tom@tromey.com>
8407             Pedro Alves  <palves@redhat.com>
8408
8409         * infrun.c (disable_thread_events): Delete.
8410         (stop_all_threads): Use SCOPE_EXIT.
8411
8412 2019-01-23  Tom Tromey  <tom@tromey.com>
8413             Pedro Alves  <palves@redhat.com>
8414
8415         * symfile.c: Include forward-scope-exit.h.
8416         (clear_symtab_users_cleanup): Replace forward declaration with
8417         a FORWARD_SCOPE_EXIT.
8418         (syms_from_objfile_1): Use the forward_scope_exit and
8419         gdb::optional instead of cleanup_function.
8420         (reread_symbols): Use the forward_scope_exit instead of
8421         cleanup_function.
8422         (clear_symtab_users_cleanup): Remove function.
8423
8424 2019-01-23  Tom Tromey  <tom@tromey.com>
8425             Pedro Alves  <palves@redhat.com>
8426
8427         * linux-nat.c: Include scope-exit.h.
8428         (cleanup_target_stop): Remove.
8429         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8430         SCOPE_EXIT.
8431
8432 2019-01-23  Tom Tromey  <tom@tromey.com>
8433             Pedro Alves  <palves@redhat.com>
8434
8435         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8436         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8437
8438 2019-01-23  Tom Tromey  <tom@tromey.com>
8439             Andrew Burgess  <andrew.burgess@embecosm.com>
8440             Pedro Alves  <palves@redhat.com>
8441
8442         * infrun.c (fetch_inferior_event): Use scope_exit.
8443         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8444         * top.c (execute_command): Use scope_exit.
8445         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8446         * utils.c (do_bpstat_clear_actions_cleanup)
8447         (make_bpstat_clear_actions_cleanup): Remove.
8448
8449 2019-01-23  Tom Tromey  <tom@tromey.com>
8450             Pedro Alves  <palves@redhat.com>
8451
8452         * infrun.c: Include "common/scope-exit.h"
8453         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8454         (wait_for_inferior): Use SCOPE_EXIT.
8455         (fetch_inferior_event): Use scope_exit.
8456
8457 2019-01-23  Tom Tromey  <tom@tromey.com>
8458             Pedro Alves  <palves@redhat.com>
8459
8460         * breakpoint.c (create_breakpoint): Remove cleanup.
8461
8462 2019-01-23  Tom Tromey  <tom@tromey.com>
8463             Andrew Burgess  <andrew.burgess@embecosm.com>
8464             Pedro Alves  <palves@redhat.com>
8465
8466 2019-01-23  Pedro Alves  <palves@redhat.com>
8467
8468         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8469
8470 2019-01-23  Pedro Alves  <palves@redhat.com>
8471             Andrew Burgess  <andrew.burgess@embecosm.com>
8472
8473         * gdbthread.h: Include "common/forward-scope-exit.h".
8474         (scoped_finish_thread_state): Redefine custom class in terms of
8475         forward_scope_exit.
8476
8477 2019-01-23  Pedro Alves  <palves@redhat.com>
8478             Andrew Burgess  <andrew.burgess@embecosm.com>
8479
8480         * common/forward-scope-exit.h: New file.
8481
8482 2019-01-23  Pedro Alves  <palves@redhat.com>
8483             Andrew Burgess  <andrew.burgess@embecosm.com>
8484             Tom Tromey  <tom@tromey.com>
8485
8486         * common/scope-exit.h: New file.
8487
8488 2019-01-23  Pedro Alves  <palves@redhat.com>
8489
8490         * common/preprocessor.h (ESC): Rename to ...
8491         (ESC_PARENS): ... this.
8492         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8493         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8494
8495 2019-01-23  Tom Tromey  <tom@tromey.com>
8496
8497         * language.h (class scoped_switch_to_sym_language_if_auto):
8498         Initialize m_lang in both cases.
8499
8500 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8501
8502         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8503         with XCNEW.
8504
8505 2019-01-22  Tom Tromey  <tom@tromey.com>
8506
8507         * corelow.c: Do not include sys/file.h.
8508
8509 2019-01-22  Tom Tromey  <tom@tromey.com>
8510
8511         * tui/tui-wingeneral.h: Include gdb_curses.h.
8512
8513 2019-01-22  Tom Tromey  <tom@tromey.com>
8514
8515         * source-cache.h (class source_cache) <get_source_lines,
8516         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8517
8518 2019-01-22  Tom Tromey  <tom@tromey.com>
8519
8520         * remote-fileio.h (struct remote_target): Declare.
8521
8522 2019-01-22  Tom Tromey  <tom@tromey.com>
8523
8524         * python/py-arch.c: Do not include py-ref.h.
8525         * python/py-bpevent.c: Do not include py-ref.h.
8526         * python/py-cmd.c: Do not include py-ref.h.
8527         * python/py-continueevent.c: Do not include py-ref.h.
8528         * python/py-event.h: Do not include py-ref.h.
8529         * python/py-evtregistry.c: Do not include py-ref.h.
8530         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8531         * python/py-frame.c: Do not include py-ref.h.
8532         * python/py-framefilter.c: Do not include py-ref.h.
8533         * python/py-function.c: Do not include py-ref.h.
8534         * python/py-infevents.c: Do not include py-ref.h.
8535         * python/py-linetable.c: Do not include py-ref.h.
8536         * python/py-objfile.c: Do not include py-ref.h.
8537         * python/py-param.c: Do not include py-ref.h.
8538         * python/py-prettyprint.c: Do not include py-ref.h.
8539         * python/py-progspace.c: Do not include py-ref.h.
8540         * python/py-symbol.c: Do not include py-ref.h.
8541         * python/py-symtab.c: Do not include py-ref.h.
8542         * python/py-type.c: Do not include py-ref.h.
8543         * python/py-unwind.c: Do not include py-ref.h.
8544         * python/py-utils.c: Do not include py-ref.h.
8545         * python/py-value.c: Do not include py-ref.h.
8546         * python/py-varobj.c: Do not include py-ref.h.
8547         * python/py-xmethods.c: Do not include py-ref.h.
8548         * python/python.c: Do not include py-ref.h.
8549         * varobj.c: Do not include py-ref.h.
8550
8551 2019-01-22  Tom Tromey  <tom@tromey.com>
8552
8553         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8554         keyword for bcache.
8555
8556 2019-01-22  Tom Tromey  <tom@tromey.com>
8557
8558         * compile/compile-cplus-types.c: Remove a comment by #include.
8559
8560 2019-01-22  Tom Tromey  <tom@tromey.com>
8561
8562         * compile/gcc-c-plugin.h: Include compile-internal.h.
8563
8564 2019-01-22  Tom Tromey  <tom@tromey.com>
8565
8566         * stabsread.c (EXTERN): Do not define.
8567         (symnum, next_symbol_text_func, processing_gcc_compilation)
8568         (within_function, global_sym_chain, global_stabs)
8569         (previous_stab_code, this_object_header_files)
8570         (n_this_object_header_files)
8571         (n_allocated_this_object_header_files): Define.
8572         * stabsread.h (EXTERN): Never define.  Use "extern".
8573
8574 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8575
8576         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8577         history_value.
8578
8579 2019-01-21  Tom Tromey  <tom@tromey.com>
8580
8581         * ui-out.c: Fix includes.
8582         * tui/tui-source.c: Fix includes.
8583         * target.c: Fix includes.
8584         * remote.c: Fix includes.
8585         * regcache.c: Fix includes.
8586         * python/py-block.c: Fix includes.
8587         * printcmd.c: Fix includes.
8588         * or1k-tdep.c: Fix includes.
8589         * mi/mi-main.c: Fix includes.
8590         * m32r-tdep.c: Fix includes.
8591         * csky-tdep.c: Fix includes.
8592         * compile/compile-cplus-types.c: Fix includes.
8593         * cli/cli-interp.c: Fix includes.
8594
8595 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8596
8597         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8598         for padding.
8599
8600 2019-01-16  Tom Tromey  <tom@tromey.com>
8601
8602         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8603         earlier.
8604         (struct objfile) <msymbols_range>: Move from top level.
8605         <msymbols>: New method.
8606         (class objfile_msymbols): Remove.
8607         * symtab.c (default_collect_symbol_completion_matches_break_on):
8608         Update.
8609         * symmisc.c (dump_msymbols): Update.
8610         * stabsread.c (scan_file_globals): Update.
8611         * objc-lang.c (info_selectors_command, info_classes_command)
8612         (find_methods): Update.
8613         * minsyms.c (find_solib_trampoline_target): Update.
8614         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8615         * coffread.c (coff_symfile_read): Update.
8616         * ada-lang.c (ada_lookup_simple_minsym)
8617         (ada_collect_symbol_completion_matches): Update.
8618
8619 2019-01-16  Tom Tromey  <tom@tromey.com>
8620
8621         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8622         type.  Remove no-argument constructor.
8623         <iterator::operator++>: Simplify.
8624         <begin>: Update.
8625         <end>: Use minimal_symbol_count.
8626
8627 2019-01-16  Tom Tromey  <tom@tromey.com>
8628
8629         * objfiles.h (struct objfile) <psymtabs>: New method.
8630         (class objfile_psymtabs): Remove.
8631         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8632         typedef.
8633         <range>: New method.
8634         (require_partial_symbols): Change return type.
8635         * psymtab.c (require_partial_symbols)
8636         (psym_expand_symtabs_matching): Update.
8637         * mdebugread.c (parse_partial_symbols): Update.
8638         * dbxread.c (dbx_end_psymtab): Update.
8639
8640 2019-01-15  Tom Tromey  <tom@tromey.com>
8641
8642         * symtab.c (lookup_objfile_from_block)
8643         (lookup_symbol_in_objfile_symtabs)
8644         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8645         (find_line_symtab, info_sources_command)
8646         (default_collect_symbol_completion_matches_break_on)
8647         (make_source_files_completion_list): Update.
8648         * symmisc.c (print_objfile_statistics, dump_objfile)
8649         (maintenance_print_symbols, maintenance_info_symtabs)
8650         (maintenance_check_symtabs, maintenance_info_line_tables):
8651         Update.
8652         * source.c (select_source_symtab)
8653         (forget_cached_source_info_for_objfile): Update.
8654         * objfiles.h (class objfile_compunits): Remove.
8655         (struct objfile) <compunits_range>: New typedef.
8656         (compunits): New method.
8657         * objfiles.c (objfile_relocate1): Update.
8658         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8659         * maint.c (count_symtabs_and_blocks): Update.
8660         * linespec.c (iterate_over_all_matching_symtabs): Update.
8661         * cp-support.c (add_symbol_overload_list_qualified): Update.
8662         * coffread.c (coff_symtab_read): Update.
8663         * ada-lang.c (add_nonlocal_symbols)
8664         (ada_collect_symbol_completion_matches)
8665         (ada_add_global_exceptions): Update.
8666
8667 2019-01-15  Tom Tromey  <tom@tromey.com>
8668
8669         * progspace.h (program_space) <objfiles_safe_range>: New
8670         typedef.
8671         <objfiles_safe>: New method.
8672         * objfiles.h (class all_objfiles_safe): Remove.
8673         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8674         * jit.c (jit_inferior_exit_hook): Update.
8675
8676 2019-01-17  Tom Tromey  <tom@tromey.com>
8677
8678         * progspace.h (program_space) <objfiles_range>: New typedef.
8679         <objfiles>: New method.
8680         <objfiles_head>: Rename from objfiles.
8681         (object_files): Update.
8682         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8683         * guile/scm-pretty-print.c
8684         (ppscm_find_pretty_printer_from_objfiles): Update.
8685         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8686         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8687         Update.
8688         * python/py-progspace.c (pspy_get_objfiles): Update.
8689         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8690         Update.
8691         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8692         (objfpy_lookup_objfile_by_build_id): Update.
8693         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8694         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8695         Update.
8696         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8697         (expand_symtab_containing_pc, lookup_objfile_from_block)
8698         (lookup_static_symbol, basic_lookup_transparent_type)
8699         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8700         (find_line_symtab, info_sources_command)
8701         (default_collect_symbol_completion_matches_break_on)
8702         (make_source_files_completion_list, find_main_name): Update.
8703         * symmisc.c (print_symbol_bcache_statistics)
8704         (print_objfile_statistics, maintenance_print_symbols)
8705         (maintenance_print_msymbols, maintenance_print_objfiles)
8706         (maintenance_info_symtabs, maintenance_check_symtabs)
8707         (maintenance_expand_symtabs, maintenance_info_line_tables):
8708         Update.
8709         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8710         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8711         (map_overlay_command, unmap_overlay_command)
8712         (simple_overlay_update, expand_symtabs_matching)
8713         (map_symbol_filenames): Update.
8714         * symfile-debug.c (set_debug_symfile): Update.
8715         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8716         Update.
8717         * source.c (select_source_symtab, forget_cached_source_info):
8718         Update.
8719         * solib.c (solib_read_symbols): Update.
8720         * solib-spu.c (append_ocl_sos): Update.
8721         * psymtab.c (maintenance_print_psymbols)
8722         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8723         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8724         * printcmd.c (info_symbol_command): Update.
8725         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8726         Update.
8727         * objfiles.h (class all_objfiles): Remove.
8728         * objfiles.c (have_partial_symbols, have_full_symbols)
8729         (have_minimal_symbols, qsort_cmp, update_section_map)
8730         (shared_objfile_contains_address_p)
8731         (default_iterate_over_objfiles_in_search_order): Update.
8732         * objc-lang.c (info_selectors_command, info_classes_command)
8733         (find_methods): Update.
8734         * minsyms.c (find_solib_trampoline_target): Update.
8735         * maint.c (maintenance_info_sections)
8736         (maintenance_translate_address, count_symtabs_and_blocks):
8737         Update.
8738         * main.c (captured_main_1): Update.
8739         * linux-thread-db.c (try_thread_db_load_from_pdir)
8740         (has_libpthread): Update.
8741         * linespec.c (iterate_over_all_matching_symtabs)
8742         (search_minsyms_for_name): Update.
8743         * jit.c (jit_find_objf_with_entry_addr): Update.
8744         * hppa-tdep.c (find_unwind_entry)
8745         (hppa_lookup_stub_minimal_symbol): Update.
8746         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8747         Update.
8748         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8749         (elf_gnu_ifunc_resolve_by_got): Update.
8750         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8751         * dwarf-index-write.c (save_gdb_index_command): Update.
8752         * cp-support.c (add_symbol_overload_list_qualified): Update.
8753         * breakpoint.c (create_overlay_event_breakpoint)
8754         (create_longjmp_master_breakpoint)
8755         (create_std_terminate_master_breakpoint)
8756         (create_exception_master_breakpoint): Update.
8757         * blockframe.c (find_pc_partial_function): Update.
8758         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8759         (ada_collect_symbol_completion_matches)
8760         (ada_add_global_exceptions): Update.
8761
8762 2019-01-17  Tom Tromey  <tom@tromey.com>
8763
8764         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8765         declare VEC.
8766         (solib_target_parse_libraries): Change return type.
8767         (library_list_start_segment, library_list_start_section)
8768         (library_list_end_library, library_list_start_library); Update.
8769         (solib_target_free_library_list): Remove.
8770         (solib_target_parse_libraries): Remove cleanup.  Change return
8771         type.
8772         (solib_target_current_sos): Update.
8773
8774 2019-01-17  Tom Tromey  <tromey@bapiya>
8775
8776         * valprint.c: Replace "the the" with "the".
8777         * symtab.c: Replace "the the" with "the".
8778         * solib.c: Replace "the the" with "the".
8779         * solib-dsbt.c: Replace "the the" with "the".
8780         * linespec.c: Replace "the the" with "the".
8781         * dwarf2loc.h: Replace "the the" with "the".
8782         * amd64-windows-tdep.c: Replace "the the" with "the".
8783         * aarch64-tdep.c: Replace "the the" with "the".
8784
8785 2019-01-16  Keith Seitz  <keiths@redhat.com>
8786
8787         PR gdb/23773
8788         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8789         <builder>: Rename to ..
8790         <m_builder>: ... this and make private.
8791         (dwarf2_cu::get_builder): New method.  Change all users of
8792         `builder' to use this method.
8793         (dwarf2_start_symtab): Move to ...
8794         (dwarf2_cu::start_symtab): ... here.  Update all callers
8795         (setup_type_unit_groups): Move to ...
8796         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8797         callers.
8798         (dwarf2_cu::reset_builder): New method.
8799         (process_full_compunit, process_full_type_unit): Use
8800         dwarf2_cu::reset_builder.
8801         (follow_die_offset): Record the ancestor CU if it is different
8802         from the followed DIE's CU.
8803         (follow_die_sig_1): Likewise.
8804
8805 2019-01-15  Tom Tromey  <tom@tromey.com>
8806
8807         * remote.c (class remote_state) <buf>: Now a char_vector.
8808         <buf_size>: Remove.
8809         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8810         parameter.
8811         (remote_target::getpkt_or_notif_sane_1)
8812         (remote_target::getpkt_sane)
8813         (remote_target::getpkt_or_notif_sane): Likewise.
8814         (class remote_target) <putpkt>: New overload.
8815         (remote_target::read_frame): Change type of "buf_p".  Remove
8816         sizeof_p parameter.
8817         (packet_ok): New overload.
8818         (packet_check_result): New overload.
8819         Update all uses.
8820
8821 2019-01-14  Tom Tromey  <tom@tromey.com>
8822
8823         * remote-notif.c (handle_notification, remote_notif_ack)
8824         (remote_notif_parse): Make "buf" const.
8825         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8826         const.
8827         (remote_notif_parse, remote_notif_ack, handle_notification):
8828         Likewise.
8829         * remote.c (remote_notif_stop_parse): Make "buf" const.
8830         (remote_target::remote_parse_stop_reply): Make "buf" const.
8831         (remote_notif_stop_ack): Make "buf" const.
8832
8833 2019-01-14  Tom Tromey  <tom@tromey.com>
8834
8835         * remote.c (remote_console_output): Make parameter const.
8836
8837 2019-01-14  Tom Tromey  <tom@tromey.com>
8838
8839         * target-debug.h (target_debug_print_signals): Constify.
8840         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8841         * procfs.c (procfs_target::pass_signals): Update.
8842         * linux-nat.c (linux_nat_target::pass_signals): Update.
8843         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8844         * target-delegates.c: Rebuild.
8845         * remote.c (remote_target::program_signals): Update.
8846         (remote_target::pass_signals): Update.
8847         * target.c (target_pass_signals): Constify argument.
8848         (target_program_signals): Likewise.
8849         * target.h (struct target_ops) <pass_signals, program_signals>:
8850         Constify argument.
8851         (target_pass_signals, target_program_signals): Constify argument.
8852
8853 2019-01-14  Tom Tromey  <tom@tromey.com>
8854
8855         PR tui/28819:
8856         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8857
8858 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8859
8860         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8861         field.
8862         * rs6000-tdep.c: Include reggroups.h.
8863         (IS_V_ALIAS_PSEUDOREG): Define.
8864         (rs6000_register_name): Return names for the "vX" aliases.
8865         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8866         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8867         aliases.  Call default_register_reggroup_p for all other
8868         pseudo-registers.
8869         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8870         New functions.
8871         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8872         Handle "vX" aliases.
8873         (v_alias_pseudo_register_collect): New function.
8874         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8875         (rs6000_gdbarch_init): Initialize "vX" aliases as
8876         pseudo-registers.  Restore registration of
8877         rs6000_pseudo_register_reggroup_p with
8878         set_tdesc_pseudo_register_reggroup_p.
8879
8880 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8881
8882         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8883         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8884         set_gdbarch_num_pseudo_regs.
8885
8886 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8887
8888         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8889         Remove arg prefixname, add do_set and do_show.
8890         Add member functions set_list and show_list.
8891         * cli/cli-style.c (class cli_style_option): Update accordingly.
8892         (style_set_list): Move to file scope.
8893         (style_show_list): Likewise.
8894         (set_style): Call help_list.
8895         (show_style): Call cmd_show_list.
8896         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8897         Update to use the new macro.
8898
8899 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8900
8901         * ada-lang.c (_initialize_ada_language): Expand the help text
8902         for the "catch exception" command.
8903
8904 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8905
8906         * symtab.c (matching_obj_sections): Initialize obj,
8907         declare it closer to its usage.
8908
8909 2019-01-10  Tom Tromey  <tom@tromey.com>
8910
8911         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8912         (basic_inf_threads_range): Remove.
8913         (inf_threads_range, inf_non_exited_threads_range)
8914         (safe_inf_threads_range): Use next_adapter.
8915
8916 2019-01-10  Keith Seitz  <keiths@redhat.com>
8917
8918         PR gdb/23712
8919         PR symtab/23010
8920         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8921         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8922
8923 2019-01-10  Keith Seitz  <keiths@redhat.com>
8924
8925         PR gdb/23712
8926         PR symtab/23010
8927         * dictionary.c (pending_to_vector): Remove.
8928         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8929         Remove _1 suffix, replacing functions of the same name.  Update
8930         all callers.
8931         (dict_create_hashed, dict_create_hashed_expandable)
8932         (dict_create_linear, dict_create_linear_expandable, dict_free)
8933         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8934         Make functions static.
8935
8936 2019-01-10  Keith Seitz  <keiths@redhat.com>
8937
8938         PR gdb/23712
8939         PR symtab/23010
8940         * dictionary.h (struct dictionary): Replace declaration with
8941         multidictionary.
8942         (dict_create_hashed, dict_create_hashed_expandable)
8943         (dict_create_linear, dict_create_linear_expandable)
8944         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8945         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8946         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8947         taking multidictionary argument.
8948         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8949         * block.h (struct block) <dict>: Change to multidictionary
8950         and rename `multidict'.
8951         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8952         symmisc.c: Update all dictionary references to multidictionary.
8953
8954 2019-01-10  Keith Seitz  <keiths@redhat.com>
8955
8956         PR gdb/23712
8957         PR symtab/23010
8958         * dictionary.c: Include unordered_map.
8959         (pending_to_vector): New function.
8960         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8961         Rewrite the non-"_1" functions to take vector instead
8962         of linked list.
8963         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8964         "new" _1 versions of the same name.
8965         (multidictionary): Define.
8966         (std::hash<enum language): New definition.
8967         (collate_pending_symbols_by_language, mdict_create_hashed)
8968         (mdict_create_hashed_expandable, mdict_create_linear)
8969         (mdict_create_linear_expandable, mdict_free)
8970         (find_language_dictionary, create_new_language_dictionary)
8971         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8972         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8973         (mdict_size, mdict_empty): New functions.
8974         * dictionary.h (mdict_iterator): Define.
8975
8976 2019-01-10  Pedro Alves  <palves@redhat.com>
8977
8978         * breakpoint.c (read_uploaded_action)
8979         (create_tracepoint_from_upload): Adjust to use
8980         gdb::unique_xmalloc_ptr.
8981         * ctf.c (ctf_write_uploaded_tp):
8982         (SET_ARRAY_FIELD): Use emplace_back.
8983         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8984         * tracefile-tfile.c (tfile_write_uploaded_tp):
8985         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8986         gdb::unique_xmalloc_ptr.
8987         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8988         at_string, cond_string, cmd_strings>: Replace char pointers
8989         with gdb::unique_xmalloc_ptr.
8990
8991 2019-01-10  Pedro Alves  <palves@redhat.com>
8992
8993         * solib-target.c (library_list_start_library): Don't xstrdup name.
8994
8995 2019-01-10  Pedro Alves  <palves@redhat.com>
8996
8997         * mdebugread.c (parse_partial_symbols): Use
8998         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8999
9000 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9001
9002         * linux-fork.c (scoped_switch_fork_info)
9003         <~scoped_switch_fork_info>: Fix incorrect variable name.
9004
9005 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9006
9007         * linux-fork.c (scoped_switch_fork_info)
9008         <scoped_switch_fork_info>: Make explicit.
9009         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9010
9011 2019-01-10  Tom Tromey  <tom@tromey.com>
9012
9013         * objfiles.h (objfile::reset_psymtabs): Update.
9014         * objfiles.c (objfile::objfile): Update.
9015         * psymtab.h (psymtab_storage::obstack): Update.
9016         (psymtab_storage::m_obstack): Use gdb::optional.
9017         (class psymtab_storage): Update comment.  Remove objfile
9018         parameter.
9019         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9020
9021 2019-01-10  Tom Tromey  <tom@tromey.com>
9022
9023         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9024         <free_psymtabs>: Now private.
9025         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9026         (allocate_psymtab): Use new method.
9027
9028 2019-01-10  Tom Tromey  <tom@tromey.com>
9029
9030         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9031         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9032         * mdebugread.c (parse_partial_symbols): Use
9033         allocate_dependencies.
9034         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9035         allocate_dependencies.
9036         (process_psymtab_comp_unit_reader)
9037         (build_type_psymtab_dependencies): Likewise.
9038         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9039
9040 2019-01-10  Tom Tromey  <tom@tromey.com>
9041
9042         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9043         PSYMBOL_SET_LANGUAGE.
9044         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9045
9046 2019-01-10  Tom Tromey  <tom@tromey.com>
9047
9048         * psymtab.h (psymtab_storage::obstack): New method.
9049         <m_obstack>: Rename from obstack; now private.
9050         * psymtab.c (psymtab_storage): Update.
9051         * dwarf2read.c (create_addrmap_from_index)
9052         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9053         Update.
9054
9055 2019-01-10  Tom Tromey  <tom@tromey.com>
9056
9057         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9058         * objfiles.h (objfile::reset_psymtabs): New method.
9059
9060 2019-01-10  Tom Tromey  <tom@tromey.com>
9061
9062         * symmisc.c (print_symbol_bcache_statistics): Update.
9063         (print_objfile_statistics): Update.
9064         * symfile.c (reread_symbols): Update.
9065         * psymtab.h (class psymtab_storage): New.
9066         * psymtab.c (psymtab_storage): New constructor.
9067         (~psymtab_storage): New destructor.
9068         (require_partial_symbols): Update.
9069         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9070         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9071         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9072         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9073         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9074         (start_psymtab_common, end_psymtab_common)
9075         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9076         (allocate_psymtab): Update.
9077         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9078         Update.
9079         (dump_psymtab_addrmap, maintenance_print_psymbols)
9080         (maintenance_check_psymtabs): Update.
9081         (class objfile_psymtabs): Move to objfiles.h.
9082         * psympriv.h (discard_psymtab): Now inline.
9083         (psymtab_discarder::psymtab_discarder): Update.
9084         (psymtab_discarder::~psymtab_discarder): Update.
9085         (ALL_OBJFILE_PSYMTABS): Rewrite.
9086         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9087         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9088         Remove fields.
9089         <partial_symtabs>: New field.
9090         (class objfile_psymtabs): Move from psymtab.h.  Update.
9091         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9092         psymbol_cache.
9093         (objfile::~objfile): Don't destroy psymbol_cache.
9094         * mdebugread.c (parse_partial_symbols): Update.
9095         * dwarf2read.c (create_addrmap_from_index)
9096         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9097         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9098         (add_partial_subprogram, dwarf2_ranges_read): Update.
9099         * dwarf-index-write.c (write_address_map)
9100         (write_one_signatured_type, recursively_write_psymbols)
9101         (class debug_names, class debug_names, write_psymtabs_to_index):
9102         Update.
9103
9104 2019-01-10  Tom Tromey  <tom@tromey.com>
9105
9106         * symtab.h (SYMBOL_SET_NAMES): Update.
9107         (symbol_set_names): Update.
9108         (MSYMBOL_SET_NAMES): Update.
9109         * symtab.c (symbol_set_names): Change argument to be an
9110         objfile_per_bfd_storage.
9111         * psymtab.c (add_psymbol_to_bcache): Update.
9112         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9113
9114 2019-01-10  Tom Tromey  <tom@tromey.com>
9115
9116         * symtab.c (create_demangled_names_hash): Change argument to be an
9117         objfile_per_bfd_storage.
9118         (symbol_set_names): Update.
9119
9120 2019-01-10  Tom Tromey  <tom@tromey.com>
9121
9122         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9123         init_psymbol_list.
9124         * psymtab.c (init_psymbol_list): Do nothing if already called.
9125         * psympriv.h (init_psymbol_list): Add comment.
9126         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9127         init_psymbol_list.
9128         * dbxread.c (dbx_symfile_read): Unconditionally call
9129         init_psymbol_list.
9130
9131 2019-01-10  Tom Tromey  <tom@tromey.com>
9132
9133         * xcoffread.c (scan_xcoff_symtab): Update.
9134         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9135         "where".
9136         * mdebugread.c (parse_partial_symbols)
9137         (handle_psymbol_enumerators): Update.
9138         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9139         * dbxread.c (read_dbx_symtab): Update.
9140         * psympriv.h (psymbol_placement): New enum.
9141         (add_psymbol_to_list): Update.
9142
9143 2019-01-10  Tom Tromey  <tom@tromey.com>
9144
9145         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9146         static_psymbols parameters.
9147         (scan_xcoff_symtab): Update.
9148         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9149         static_psymbols parameters.
9150         * psympriv.h (start_psymtab_common): Update.
9151         * mdebugread.c (parse_partial_symbols): Update.
9152         * dwarf2read.c (create_partial_symtab): Update.
9153         * dbxread.c (read_dbx_symtab): Update.
9154         (start_psymtab): Remove global_psymbols and static_psymbols
9155         parameters.
9156
9157 2019-01-10  Tom Tromey  <tom@tromey.com>
9158
9159         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9160         * psymtab.c (allocate_psymtab): Add comment.
9161         * psympriv.h (allocate_psymtab): Add comment.
9162         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9163         initializations.
9164         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9165
9166 2019-01-10  Tom Tromey  <tom@tromey.com>
9167
9168         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9169         Don't declare.
9170         * mipsread.c: Include mdebugread.h.
9171         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9172         Declare.
9173         * elfread.c: Include mdebugread.h.
9174
9175 2019-01-09  Tom Tromey  <tom@tromey.com>
9176
9177         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9178         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9179         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9180         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9181         (psym_lookup_symbol, psym_find_last_source_symtab)
9182         (psym_forget_cached_source_info, psym_print_stats)
9183         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9184         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9185         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9186         (psym_find_compunit_symtab_by_address)
9187         (maintenance_print_psymbols, maintenance_info_psymtabs)
9188         (maintenance_check_psymtabs): Use ranged for.
9189         * psymtab.h (class objfile_psymtabs): New.
9190         (require_partial_symbols): Return objfile_psymtabs.
9191         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9192
9193 2019-01-09  Tom Tromey  <tom@tromey.com>
9194
9195         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9196         (find_pc_mapped_section, list_overlays_command)
9197         (map_overlay_command, unmap_overlay_command)
9198         (simple_overlay_update): Use all_objfiles.
9199         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9200         * printcmd.c (info_symbol_command): Use all_objfiles.
9201         * objfiles.h (ALL_OBJSECTIONS): Remove.
9202         * maint.c (maintenance_translate_address): Use all_objfiles.
9203         * gcore.c (gcore_create_callback): Use all_objfiles.
9204         (objfile_find_memory_regions): Likewise.
9205
9206 2019-01-09  Tom Tromey  <tom@tromey.com>
9207
9208         * symtab.c (find_line_symtab, info_sources_command)
9209         (make_source_files_completion_list): Use objfile_compunits.
9210         * source.c (select_source_symtab): Use objfile_compunits.
9211         * objfiles.h (struct objfile): Update comment.
9212         (ALL_OBJFILES): Remove.
9213         (ALL_FILETABS): Remove.
9214         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9215         objfile_compunits.
9216
9217 2019-01-09  Tom Tromey  <tom@tromey.com>
9218
9219         * symmisc.c (print_objfile_statistics, dump_objfile)
9220         (maintenance_print_symbols): Use compunit_filetabs.
9221         * source.c (forget_cached_source_info_for_objfile): Use
9222         compunit_filetabs.
9223         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9224         (ALL_FILETABS): Use compunit_filetabs.
9225         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9226         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9227
9228 2019-01-09  Tom Tromey  <tom@tromey.com>
9229
9230         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9231         (compunit_filetabs): New.
9232         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9233         compunit_filetabs.
9234         (info_sources_command, make_source_files_completion_list): Remove
9235         declaration.
9236         * symmisc.c (print_objfile_statistics, dump_objfile)
9237         (maintenance_print_symbols): Remove declaration.
9238         (maintenance_info_symtabs): Use compunit_filetabs.
9239         (maintenance_info_line_tables): Likewise.
9240         * source.c (select_source_symtab): Change local variable name.
9241         (forget_cached_source_info_for_objfile): Remove declaration.
9242         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9243         * objfiles.c (objfile_relocate1): Remove declaration.
9244         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9245         declaration.
9246         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9247         * coffread.c (coff_symtab_read): Remove declaration.
9248         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9249         compunit_filetabs.
9250
9251 2019-01-09  Tom Tromey  <tom@tromey.com>
9252
9253         * symtab.c (lookup_objfile_from_block)
9254         (find_pc_sect_compunit_symtab, search_symbols)
9255         (default_collect_symbol_completion_matches_break_on): Use
9256         objfile_compunits.
9257         * objfiles.h (ALL_COMPUNITS): Remove.
9258         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9259         * cp-support.c (add_symbol_overload_list_qualified): Use
9260         objfile_compunits.
9261         * ada-lang.c (ada_collect_symbol_completion_matches)
9262         (ada_add_global_exceptions): Use objfile_compunits.
9263
9264 2019-01-09  Tom Tromey  <tom@tromey.com>
9265
9266         * source.c (select_source_symtab)
9267         (forget_cached_source_info_for_objfile): Remove declaration.
9268         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9269         declaration.
9270         * maint.c (count_symtabs_and_blocks): Remove declaration.
9271         * cp-support.c (add_symbol_overload_list_qualified): Remove
9272         declaration.
9273         * coffread.c (coff_symtab_read): Remove declaration.
9274         * symtab.c (lookup_symbol_in_objfile_symtabs)
9275         (basic_lookup_transparent_type_1): Use objfile_compunits.
9276         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9277         (info_sources_command, search_symbols)
9278         (default_collect_symbol_completion_matches_break_on)
9279         (make_source_files_completion_list): Remove declaration.
9280         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9281         (ada_collect_symbol_completion_matches)
9282         (ada_add_global_exceptions): Remove declaration.
9283         * linespec.c (iterate_over_all_matching_symtabs): Use
9284         objfile_compunits.
9285         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9286         (class objfile_compunits): New.
9287         (ALL_COMPUNITS): Use objfile_compunits.
9288         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9289         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9290         objfile_compunits.
9291         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9292
9293 2019-01-09  Tom Tromey  <tom@tromey.com>
9294
9295         * symtab.c (search_symbols)
9296         (default_collect_symbol_completion_matches_break_on): Use
9297         objfile_msymbols.
9298         * ada-lang.c (ada_lookup_simple_minsym)
9299         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9300         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9301         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9302         objfile_msymbols.
9303         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9304         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9305         * objc-lang.c (find_methods): Use objfile_msymbols.
9306         (info_selectors_command, info_classes_command): Likewise.
9307         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9308         * objfiles.h (class objfile_msymbols): New.
9309         (ALL_OBJFILE_MSYMBOLS): Remove.
9310         (ALL_MSYMBOLS): Remove.
9311
9312 2019-01-09  Tom Tromey  <tom@tromey.com>
9313
9314         * common/next-iterator.h (next_adapter): Add Iterator template
9315         parameter.
9316         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9317         (class all_objfiles_safe): New.
9318         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9319         * objfiles.c (put_objfile_before): Update comment.
9320         (add_separate_debug_objfile): Likewise.
9321         (free_all_objfiles): Use all_objfiles_safe.
9322         (objfile_purge_solibs): Likewise.
9323
9324 2019-01-09  Tom Tromey  <tom@tromey.com>
9325
9326         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9327         (expand_symtab_containing_pc, lookup_static_symbol)
9328         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9329         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9330         all_objfiles.
9331         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9332         * breakpoint.c (create_overlay_event_breakpoint)
9333         (create_longjmp_master_breakpoint)
9334         (create_std_terminate_master_breakpoint)
9335         (create_exception_master_breakpoint): Use all_objfiles.
9336         * linux-thread-db.c (try_thread_db_load_from_pdir)
9337         (has_libpthread): Use all_objfiles.
9338         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9339         * linespec.c (iterate_over_all_matching_symtabs)
9340         (search_minsyms_for_name): Use all_objfiles.
9341         * maint.c (maintenance_info_sections): Use all_objfiles.
9342         * main.c (captured_main_1): Use all_objfiles.
9343         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9344         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9345         * guile/scm-pretty-print.c
9346         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9347         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9348         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9349         (maintenance_print_msymbols): Use all_objfiles.
9350         * source.c (select_source_symtab): Use all_objfiles.
9351         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9352         * symfile.c (remove_symbol_file_command)
9353         (expand_symtabs_matching, map_symbol_filenames): Use
9354         all_objfiles.
9355         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9356         all_objfiles.
9357         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9358         * objc-lang.c (find_methods): Use all_objfiles.
9359         * objfiles.c (have_partial_symbols, have_full_symbols)
9360         (have_minimal_symbols, qsort_cmp)
9361         (default_iterate_over_objfiles_in_search_order): Use
9362         all_objfiles.
9363         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9364         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9365         (maintenance_check_psymtabs): Use all_objfiles.
9366         (ALL_PSYMTABS): Remove.
9367         * compile/compile-object-run.c (do_module_cleanup): Use
9368         all_objfiles.
9369         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9370         * cp-support.c (add_symbol_overload_list_qualified): Use
9371         all_objfiles.
9372         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9373         Use all_objfiles.
9374         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9375         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9376         all_objfiles.
9377         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9378         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9379         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9380         Uses all_objfiles.
9381         * solib.c (solib_read_symbols): Use all_objfiles
9382
9383 2019-01-09  Tom Tromey  <tom@tromey.com>
9384
9385         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9386         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9387         all_objfiles.
9388         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9389         * symmisc.c (print_symbol_bcache_statistics)
9390         (print_objfile_statistics, maintenance_print_objfiles)
9391         (maintenance_info_symtabs, maintenance_check_symtabs)
9392         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9393         all_objfiles.
9394         * source.c (forget_cached_source_info): Use all_objfiles.
9395         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9396         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9397         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9398         * objfiles.c (update_section_map): Use all_objfiles.
9399         (shared_objfile_contains_address_p): Likewise.
9400         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9401         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9402
9403 2019-01-09  Tom Tromey  <tom@tromey.com>
9404
9405         * common/next-iterator.h: New file.
9406         * objfiles.h (class all_objfiles): New.
9407         (struct objfile_iterator): New.
9408
9409 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9410
9411         * NEWS: Move the description of the changed "frame", "select-frame",
9412          and "info frame" commands to the Changed commands section.
9413
9414 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9415
9416         * gdbtypes.c (check_stub_method_group): Remove handling of old
9417         mangling schemes.
9418         * linespec.c (find_methods): Likewise.
9419         * stabsread.c (read_member_functions): Likewise.
9420         * valops.c (search_struct_method): Likewise.
9421         (value_struct_elt_for_reference): Likewise.
9422         * NEWS: Mention this change.
9423
9424 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9425
9426         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9427         print_source_lines.
9428         * source.c (print_source_lines_base): Update line number check.
9429         (print_source_lines): New function.
9430         (source_lines_range::source_lines_range): New function.
9431         * source.h (class source_lines_range): New class.
9432         (print_source_lines): New declaration.
9433
9434 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9435
9436         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9437
9438 2019-01-08  Tom Tromey  <tom@tromey.com>
9439             Simon Marchi  <simon.marchi@ericsson.com>
9440
9441         PR gdb/24060
9442         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9443         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9444         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9445         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9446         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9447         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9448
9449 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9450
9451         * source.c (select_source_symtab): Move header comment to
9452         declaration in source.h.
9453         (forget_cached_source_info_for_objfile): Likewise.
9454         (forget_cached_source_info): Likewise.
9455         (identify_source_line): Likewise.
9456         * source.h (identify_source_line): Move declaration from symtab.h
9457         and add comment from source.c
9458         (print_source_lines): Likewise.
9459         (forget_cached_source_info_for_objfile): Likewise.
9460         (forget_cached_source_info): Likewise.
9461         (select_source_symtab): Likewise.
9462         (enum print_source_lines_flag): Move definition from symtab.h.
9463         * symtab.h (identify_source_line): Move declaration to source.h.
9464         (print_source_lines): Likewise.
9465         (forget_cached_source_info_for_objfile): Likewise.
9466         (forget_cached_source_info): Likewise.
9467         (select_source_symtab): Likewise.
9468         (enum print_source_lines_flag): Move definition to source.h.
9469         * tui/tui-hooks.c: Add 'source.h' include.
9470
9471 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9472
9473         * source.c (print_source_lines_base): Handle requests to print
9474         reverse line number sequences, and guard against empty lines
9475         string.
9476
9477 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9478
9479         * source.c (print_source_lines_base): Fix skip of '\r' if next
9480         character is '\n'.
9481
9482 2019-01-06  Tom Tromey  <tom@tromey.com>
9483
9484         * c-exp.y (struct c_parse_state) <macro_original_text,
9485         expansion_obstack>: New member.
9486         (macro_original_text, expansion_obstack): Remove globals.
9487         (scan_macro_expansion, scanning_macro_expansion)
9488         (finished_macro_expansion): Update.
9489         (scan_macro_cleanup): Remove.
9490         (yylex, c_parse): Update.
9491
9492 2019-01-06  Tom Tromey  <tom@tromey.com>
9493
9494         * c-exp.y (struct c_parse_state) <strings>: New member.
9495         (operator_stoken): Update.
9496
9497 2019-01-06  Tom Tromey  <tom@tromey.com>
9498
9499         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9500         (union type_stack_elt) <typelist_val>: Now a pointer to
9501         std::vector.
9502         (type_stack_cleanup): Don't declare.
9503         (push_typelist): Update.
9504         * parse.c (pop_typelist): Return a std::vector.
9505         (push_typelist): Take a std::vector.
9506         (follow_types): Update.  Do not free args.
9507         (type_stack_cleanup): Remove.
9508         * c-exp.y (struct c_parse_state): New.
9509         (cpstate): New global.
9510         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9511         (nonempty_typelist): Update.
9512         (func_mod): Create a new vector.
9513         (c_parse): Create a c_parse_state.
9514         (check_parameter_typelist): Do not delete params.
9515         (function_method): Update.  Do not delete type_list.
9516
9517 2019-01-06  Tom Tromey  <tom@tromey.com>
9518
9519         PR gdb/28155:
9520         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9521         check_typedef.
9522         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9523         (print_return_value): Likewise.
9524
9525 2019-01-05  Tom Tromey  <tom@tromey.com>
9526
9527         * contrib/cleanup_check.py: Remove.
9528         * contrib/gcc-with-excheck: Remove.
9529         * contrib/exsummary.py: Remove.
9530         * contrib/excheck.py: Remove.
9531
9532 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9533
9534         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9535         NULL. Initialize tpprev to NULL instead of assigning it
9536         to NULL on the next statement.
9537         * windows-nat.c (windows_delete_thread): Remove check for
9538         main_thread_id before printing thread exit notifications.
9539         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9540         Remove thread ID check against main_thread_id.
9541         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9542         windows_delete_thread.
9543         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9544
9545 2019-01-04  Tom Tromey  <tom@tromey.com>
9546
9547         * compile/compile.c (_initialize_compile): Use upper case for
9548         metasyntactic variables.
9549         * symmisc.c (_initialize_symmisc): Use upper case for
9550         metasyntactic variables.
9551         * psymtab.c (_initialize_psymtab): Use upper case for
9552         metasyntactic variables.
9553         * demangle.c (demangle_command): Use upper case for metasyntactic
9554         variables.
9555         (_initialize_demangler): Likewise.
9556         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9557         variables.
9558
9559 2019-01-03  Tom Tromey  <tom@tromey.com>
9560
9561         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9562
9563 2019-01-03  Tom Tromey  <tom@tromey.com>
9564
9565         * python/py-symtab.c (salpy_str): Update.
9566         (struct salpy_sal_object) <symtab>: Now a PyObject.
9567         (salpy_dealloc): Update.
9568         (del_objfile_sal): Use gdbpy_ref.
9569
9570 2019-01-03  Tom Tromey  <tom@tromey.com>
9571
9572         * python/py-type.c (convert_field): Use new_reference.  Return
9573         gdbpy_ref.
9574         (make_fielditem): Return gdbpy_ref.
9575         (typy_fields): Update.
9576         (typy_getitem): Update.
9577         (field_name): Return gdbpy_ref.  Use new_reference.
9578         (typy_iterator_iternext): Update.
9579
9580 2019-01-03  Tom Tromey  <tom@tromey.com>
9581
9582         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9583
9584 2019-01-03  Tom Tromey  <tom@tromey.com>
9585
9586         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9587         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9588         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9589         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9590         (pspy_set_type_printers): Likewise.
9591         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9592         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9593         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9594         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9595         (objfpy_set_type_printers): Likewise.
9596
9597 2019-01-03  Tom Tromey  <tom@tromey.com>
9598
9599         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9600         (gdbpy_print_stack): Use gdbpy_err_fetch.
9601         * python/python-internal.h (class gdbpy_err_fetch): New class.
9602         (class gdbpy_enter) <m_error_type, m_error_value,
9603         m_error_traceback>: Remove.
9604         <m_error>: New member.
9605         (gdbpy_exception_to_string): Don't declare.
9606         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9607         * python/py-value.c (convert_value_from_python): Use
9608         gdbpy_err_fetch.
9609         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9610         gdbpy_exception_to_string.
9611         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9612         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9613         gdbpy_err_fetch.
9614
9615 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9616
9617         * linux-nat.c (delete_lwp_cleanup): Delete.
9618         (struct lwp_deleter): New struct.
9619         (lwp_info_up): New typedef.
9620         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9621         lwp_info_up.
9622
9623 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9624
9625         * linux-fork.c (class scoped_switch_fork_info): New class.
9626         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9627
9628 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9629
9630         * valops.c (find_overload_match): Remove use of null_cleanup, and
9631         calls to do_cleanups.
9632
9633 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9634
9635         * compile/compile-cplus-types.c
9636         (compile_cplus_instance::decl_name): Handle changes to
9637         cp_func_name.
9638         * cp-support.c (cp_func_name): Update header comment, update
9639         return type.
9640         * cp-support.h (cp_func_name): Update return type in declaration.
9641         * valops.c (find_overload_match): Move temp_func local to top
9642         level of function and change its type.  Use temp_func to hold and
9643         delete temporary string obtained from cp_func_name.
9644
9645 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9646
9647         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9648         gdb::char_vector, remove cleanup, and update uses of `msg`.
9649
9650 2019-01-03  Jim Wilson  <jimw@sifive.com>
9651
9652         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9653
9654 2019-01-02  Tom Tromey  <tom@tromey.com>
9655
9656         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9657         (tdesc_parse_xml): Remove cleanups.
9658         * target-descriptions.h (make_cleanup_free_target_description):
9659         Don't declare.
9660         (target_desc_deleter): New struct.
9661         (target_desc_up): New typedef.
9662         * target-descriptions.c (target_desc_deleter::operator()): Rename
9663         from free_target_description.
9664         (make_cleanup_free_target_description): Remove.
9665
9666 2019-01-02  Tom Tromey  <tom@tromey.com>
9667
9668         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9669         constructor, destructor.
9670         (linespec_parser): Remove typedef.
9671         (~linespec_parser): Rename from linespec_parser_delete.
9672         (linespec_lex_to_end, linespec_complete_label)
9673         (linespec_complete): Update.
9674         (decode_line_full): Remove cleanups.
9675         (decode_line_1): Update.
9676
9677 2019-01-02  Tom Tromey  <tom@tromey.com>
9678
9679         * python/python-internal.h (inferior_to_inferior_object): Change
9680         return type.
9681         * python/py-exitedevent.c (create_exited_event_object): Update.
9682         * python/py-inferior.c (inferior_to_inferior_object): Return
9683         gdbpy_ref.
9684         (python_new_inferior, python_inferior_deleted)
9685         (thread_to_thread_object, delete_thread_object)
9686         (build_inferior_list, gdbpy_selected_inferior): Update.
9687         * python/py-infthread.c (create_thread_object): Update.  Also fail
9688         if inferior_to_inferior_object fails.
9689
9690 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9691
9692         * inferior.h (class inferior) <displaced_step_state>: New field.
9693         * infrun.h (struct displaced_step_state): Move here from
9694         infrun.c.  Initialize fields, add constructor.
9695         <inf>: Remove field.
9696         <reset>: New method.
9697         * infrun.c (struct displaced_step_inferior_state): Move to
9698         infrun.h.
9699         (displaced_step_inferior_states): Remove.
9700         (get_displaced_stepping_state): Adust.
9701         (displaced_step_in_progress_any_inferior): Adjust.
9702         (displaced_step_in_progress_thread): Adjust.
9703         (displaced_step_in_progress): Adjust.
9704         (add_displaced_stepping_state): Remove.
9705         (get_displaced_step_closure_by_addr): Adjust.
9706         (remove_displaced_stepping_state): Remove.
9707         (infrun_inferior_exit): Call displaced_step_state.reset.
9708         (use_displaced_stepping): Don't check for NULL.
9709         (displaced_step_prepare_throw): Call
9710         get_displaced_stepping_state.
9711         (displaced_step_fixup): Don't check for NULL.
9712         (prepare_for_detach): Don't check for NULL.
9713
9714 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9715
9716         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9717          in case of call that did not complete.
9718
9719 2019-01-02  Andrey Utkin  <autkin@undo.io>
9720
9721         * symfile.c (find_separate_debug_file): Fix search of debug files for
9722         remote debuggee.
9723
9724 2019-01-02  Tom Tromey  <tom@tromey.com>
9725
9726         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9727         indentation.
9728         * python/py-frame.c (frapy_older): Remove cast.
9729         (frapy_newer): Likewise.
9730         * python/py-breakpoint.c (local_setattro): Remove cast.
9731         * python/py-arch.c (archpy_name): Remove local variable.
9732         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9733
9734 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9735
9736         * unittests/basic_string_view/element_access/char/empty.cc:
9737         Fix year range in copyright header.
9738
9739 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9740
9741         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9742         Delete.
9743         <operator==>: Update with for removed field.
9744         <hash>: Likewise.
9745         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9746         <isa_features>: ...this.
9747         <abi_features>: New field.
9748         (riscv_isa_flen): Update comment.
9749         (riscv_abi_xlen): New declaration.
9750         (riscv_abi_flen): New declaration.
9751         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9752         isa_features.
9753         (riscv_abi_xlen): New function.
9754         (riscv_isa_flen): Update to get answer from isa_features.
9755         (riscv_abi_flen): New function.
9756         (riscv_has_fp_abi): Update to get answer from abi_features.
9757         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9758         xlen and flen.
9759         (riscv_call_info) <xlen, flen>: Update comment.
9760         (riscv_call_arg_struct): Remove invalid assertions
9761         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9762         is removed.
9763         (riscv_gdbarch_init): Gather isa features and abi features
9764         separately, ensure both match on the gdbarch when reusing an old
9765         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9766         a target with 64-bit float hardware.
9767
9768 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9769
9770         * source.c (search_command_helper): Stop reverse search
9771         when line 1 has been searched.
9772
9773 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9774
9775         * record-full.c (record_full_base_target::close): Rewrite
9776         record_full_core_buf_list free logic.
9777
9778 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9779
9780         * break-catch-syscall.c (print_one_catch_syscall): xfree
9781         the last text.
9782
9783 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9784
9785         * top.c (print_gdb_version): Update Copyright year in version
9786         message.
9787
9788 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9789
9790         Update copyright year range in all GDB files.
9791
9792 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9793
9794         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9795
9796 For older changes see ChangeLog-2018.
9797 \f
9798 Local Variables:
9799 mode: change-log
9800 left-margin: 8
9801 fill-column: 74
9802 version-control: never
9803 coding: utf-8
9804 End:
9805