gdb/ChangeLog

   1 2019-07-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * jit.c (jit_program_space_key): Change type.  Move lower.
   4         (get_jit_program_space_data): Update.
   5         (jit_program_space_data_cleanup): Remove.
   6         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
   7         Update.
   8         (struct jit_program_space_data): Add initializers.
   9
  10 2019-07-10  Tom Tromey  <tromey@adacore.com>
  11
  12         * solib-darwin.c (struct darwin_info): Add initializers.
  13         (solib_darwin_pspace_data): Change type.
  14         (darwin_pspace_data_cleanup): Remove.
  15         (get_darwin_info, _initialize_darwin_solib): Update.
  16
  17 2019-07-10  Tom Tromey  <tromey@adacore.com>
  18
  19         * remote-sim.c (struct sim_inferior_data): Add initializers,
  20         constructor, and destructor.
  21         (sim_inferior_data_key): Change type.  Move lower.
  22         (check_for_duplicate_sim_descriptor): Update.
  23         (get_sim_inferior_data): Use new.  Update.
  24         (~sim_inferior_data_cleanup): Rename from
  25         sim_inferior_data_cleanup.  Simplify.
  26         (gdbsim_close_inferior, simulator_command)
  27         (sim_command_completer, _initialize_remote_sim): Update.
  28         (next_pid, INITIAL_PID): Move earlier.
  29
  30 2019-07-10  Tom Tromey  <tromey@adacore.com>
  31
  32         * python/python-internal.h (create_thread_object): Return
  33         gdbpy_ref.
  34         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
  35         * python/py-inferior.c (struct threadlist_entry): Add
  36         constructor.
  37         <thread_obj>: Now a gdbpy_ref.
  38         (thread_to_thread_object): Update.
  39         (add_thread_object): Use new.
  40         (delete_thread_object): Use delete.
  41         (infpy_threads): Update.
  42         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
  43         GIL.
  44
  45 2019-07-10  Tom Tromey  <tromey@adacore.com>
  46
  47         * valops.c (value_cast): Specialize error message for Ada.
  48
  49 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  50
  51         * breakpoint.c (breakpoint_1): Update doc and parameter names.
  52
  53 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  54
  55         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
  56         bpstat_should_step): Return bool, adjust comments.
  57         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
  58         bpstat_should_step): Likewise.
  59
  60 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  61
  62         * features/Makefile: Use feature target descriptions for Arm.
  63         * features/arm/arm-core.c: Generate new file.
  64         * features/arm/arm-fpa.c: Likewise.
  65         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
  66         * features/arm/arm-m-profile.c: Likewise.
  67         * features/arm/arm-vfpv2.c: Likewise.
  68         * features/arm/arm-vfpv3.c: Likewise.
  69         * features/arm/xscale-iwmmxt.c: Likewise.
  70         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
  71
  72 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  73
  74         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
  75         ptrace earlier.
  76
  77 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  78
  79         * features/aarch64-pauth.c: Regenerate.
  80
  81 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
  82
  83         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
  84         bool.
  85         (bpstat_what): Use false instead of 0.
  86
  87 2019-07-09  Pedro Alves  <palves@redhat.com>
  88
  89         * break-catch-throw.c (is_exception_catchpoint): New.
  90         * breakpoint.c (print_one_breakpoint_location): New parameter
  91         'raw_loc'.  Handle it.  Use
  92         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
  93         looking at the breakpoint's type.
  94         (print_one_breakpoint): If handling "maint info breakpoints", also
  95         print locations of exception catchpoints.
  96         * breakpoint.h (is_exception_catchpoint): Declare.
  97
  98 2019-07-09  Pedro Alves  <palves@redhat.com>
  99
 100         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 101         "addr" field.
 102         (allocate_location_exception_catchpoint): New.
 103         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 104         (initialize_throw_catchpoint_ops): Install
 105         allocate_location_exception_catchpoint as allocate_location
 106         method.
 107         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 108         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 109         bp_loc_other.
 110         (breakpoint_address_is_meaningful): Delete.
 111         (bl_address_is_meaningful): New.
 112         (breakpoint_locations_match): Adjust comment.
 113         (bp_location_from_bp_type): New, factored out of...
 114         (bp_location::bp_location(breakpoint *)): ... this.
 115         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 116         factored out of...
 117         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 118         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 119         breakpoint_address_is_meaningful.
 120         (bp_locations_compare): Adjust comment.
 121         (update_global_location_list): Use bl_address_is_meaningful
 122         instead of breakpoint_address_is_meaningful.
 123         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 124         explicit.
 125         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 126         * python/py-breakpoint.c (bppy_get_location): No longer check
 127         whether location is null.
 128
 129 2019-07-09  Pedro Alves  <palves@redhat.com>
 130
 131         PR c++/15468
 132         * breakpoint.c (print_one_breakpoint_location): Remove
 133         single-location assert.
 134
 135 2019-07-09  Tom Tromey  <tom@tromey.com>
 136
 137         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 138         * configure: Rebuild.
 139         * configure.ac: Change common to gdbsupport.
 140         * gdbsupport: Rename from common.
 141         * acinclude.m4: Change common to gdbsupport.
 142         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 143         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 144         gdbsupport.
 145         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 146         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 147         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 148         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 149         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 150         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 151         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 152         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 153         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 154         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 155         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 156         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 157         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 158         coff-pe-read.c, command.h, compile/compile-c-support.c,
 159         compile/compile-c.h, compile/compile-cplus-symbols.c,
 160         compile/compile-cplus-types.c, compile/compile-cplus.h,
 161         compile/compile-loc2c.c, compile/compile.c, completer.c,
 162         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 163         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 164         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 165         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 166         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 167         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 168         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 169         features/aarch64-core.c, features/aarch64-fpu.c,
 170         features/aarch64-pauth.c, features/aarch64-sve.c,
 171         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 172         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 173         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 174         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 175         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 176         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 177         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 178         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 179         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 180         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 181         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 182         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 183         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 184         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 185         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 186         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 187         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 188         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 189         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 190         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 191         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 192         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 193         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 194         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 195         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 196         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 197         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 198         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 199         minsyms.c, mips-linux-tdep.c, namespace.h,
 200         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 201         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 202         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 203         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 204         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 205         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 206         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 207         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 208         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 209         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 210         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 211         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 212         procfs.c, producer.c, progspace.h, psymtab.h,
 213         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 214         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 215         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 216         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 217         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 218         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 219         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 220         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 221         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 222         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 223         target-memory.c, target.c, target.h, target/waitstatus.c,
 224         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 225         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 226         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 227         unittests/array-view-selftests.c,
 228         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 229         unittests/common-utils-selftests.c,
 230         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 231         unittests/format_pieces-selftests.c,
 232         unittests/function-view-selftests.c,
 233         unittests/lookup_name_info-selftests.c,
 234         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 235         unittests/mkdir-recursive-selftests.c,
 236         unittests/observable-selftests.c,
 237         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 238         unittests/parse-connection-spec-selftests.c,
 239         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 240         unittests/scoped_fd-selftests.c,
 241         unittests/scoped_mmap-selftests.c,
 242         unittests/scoped_restore-selftests.c,
 243         unittests/string_view-selftests.c, unittests/style-selftests.c,
 244         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 245         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 246         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 247         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 248         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 249         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 250
 251 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 252
 253         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 254         bool value.
 255         (decode_digits_ordinary): Set explicit_line field in sal.
 256         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 257         symtab_and_line that was set on an explicit line number in
 258         assembler code.  Do always update the recorded symtab and line if
 259         we do skip the prologue.
 260
 261 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 262
 263         * breakpoint.c (set_breakpoint_location_function): Remove
 264         explicit_loc parameter.
 265         (momentary_breakpoint_from_master): Update call to
 266         set_breakpoint_location_function.
 267         (add_location_to_breakpoint): Likewise.
 268
 269 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 270
 271         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 272         required features based on default bfd type when no specific bfd
 273         is present.
 274
 275 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 276
 277         * NEWS: Mention that GDB printf and eval commands can now print
 278         C-style and Ada-style convenience var strings without
 279         calling the inferior.
 280         * printcmd.c (printf_c_string): Locally print GDB internal var
 281         instead of transiting via the inferior.
 282         (printf_wide_c_string): Likewise.
 283
 284 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 285
 286         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 287
 288 2019-07-04  Tom Tromey  <tom@tromey.com>
 289
 290         PR tui/24724:
 291         * tui/tui-winsource.c (tui_clear_source_content): Update.
 292         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 293         (tui_update_breakpoint_info): Update.
 294         (tui_set_exec_info_content): Update.
 295         * tui/tui-source.c (tui_set_source_content_nil): Update.
 296         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 297         has_break.
 298         * tui/tui-data.h (enum tui_bp_flag): New.
 299         (tui_bp_flags): New enum flags type.
 300         (struct tui_source_element) <break_mode>: Change type.  Rename
 301         from has_break.
 302         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 303         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 304         constants.
 305         * tui/tui-winsource.h: Fix comment.
 306
 307 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 308
 309         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 310         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 311         (store_fpregs_to_thread)
 312         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 313         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 314         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 315         (IWMMXT_REGS_SIZE): Add define.
 316         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 317         (fetch_vfp_regs, store_vfp_regs)
 318         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 319         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 320
 321 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 322
 323         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 324         defines.
 325         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 326         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 327         (ARM_INT_REGISTER_SIZE): ...to this.
 328         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 329         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 330         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 331         (arm_linux_collect_gregset, supply_nwfpe_register)
 332         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 333         defines.
 334         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 335         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 336         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 337         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 338         (arm_return_in_memory, arm_store_return_value)
 339         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 340         (arm_record_ld_st_multiple): Likewise.
 341         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 342         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 343
 344 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 345
 346         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 347         AARCH64_DISPLACED_MODIFIED_INSNS.
 348         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 349         (aarch64_displaced_step_copy_insn): Likewise.
 350         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 351         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 352         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 353         ARM_DISPLACED_MODIFIED_INSNS.
 354         * arm-tdep.c (arm_gdbarch_init): Likewise.
 355         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 356         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 357         (struct arm_displaced_step_closure): Use
 358         ARM_DISPLACED_MODIFIED_INSNS.
 359
 360 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 361
 362         * features/Makefile: Remove unused xml files.
 363         * features/aarch64.xml: Remove.
 364         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 365         * features/i386/amd64-avx-avx512.xml: Remove.
 366         * features/i386/amd64-avx-linux.xml: Remove.
 367         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 368         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 369         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 370         * features/i386/amd64-avx-mpx.xml: Remove.
 371         * features/i386/amd64-avx.xml: Remove.
 372         * features/i386/amd64-linux.xml: Remove.
 373         * features/i386/amd64-mpx-linux.xml: Remove.
 374         * features/i386/amd64-mpx.xml: Remove.
 375         * features/i386/amd64.xml: Remove.
 376         * features/i386/i386-avx-avx512-linux.xml: Remove.
 377         * features/i386/i386-avx-avx512.xml: Remove.
 378         * features/i386/i386-avx-linux.xml: Remove.
 379         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 380         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 381         * features/i386/i386-avx-mpx-linux.xml: Remove.
 382         * features/i386/i386-avx-mpx.xml: Remove.
 383         * features/i386/i386-avx.xml: Remove.
 384         * features/i386/i386-linux.xml: Remove.
 385         * features/i386/i386-mmx-linux.xml: Remove.
 386         * features/i386/i386-mmx.xml: Remove.
 387         * features/i386/i386-mpx-linux.xml: Remove.
 388         * features/i386/i386-mpx.xml: Remove.
 389         * features/i386/i386.xml: Remove.
 390         * features/i386/x32-avx-avx512-linux.xml: Remove.
 391         * features/i386/x32-avx-linux.xml: Remove.
 392         * features/i386/x32-linux.xml: Remove.
 393
 394 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 395
 396         * regformats/aarch64.dat: Remove.
 397         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 398         * regformats/i386/amd64-avx-linux.dat: Remove.
 399         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 400         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 401         * regformats/i386/amd64-linux.dat: Remove.
 402         * regformats/i386/amd64-mpx-linux.dat: Remove.
 403         * regformats/i386/amd64.dat: Remove.
 404         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 405         * regformats/i386/i386-avx-linux.dat: Remove.
 406         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 407         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 408         * regformats/i386/i386-linux.dat: Remove.
 409         * regformats/i386/i386-mmx-linux.dat: Remove.
 410         * regformats/i386/i386-mpx-linux.dat: Remove.
 411         * regformats/i386/i386.dat: Remove.
 412         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 413         * regformats/i386/x32-avx-linux.dat: Remove.
 414         * regformats/i386/x32-linux.dat: Remove.
 415
 416 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 417
 418         * aarch64-tdep.c: Remove xml self tests.
 419         * amd64-linux-tdep.c: Likewise.
 420         * amd64-tdep.c: Likewise.
 421         * i386-linux-tdep.c: Likewise.
 422         * i386-tdep.c: Likewise.
 423
 424 2019-07-03  Pedro Alves  <palves@redhat.com>
 425
 426         PR cli/24732
 427         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 428         (pipe_cmd_option_defs): New.
 429         (make_pipe_cmd_options_def_group): New.
 430         (pipe_command): Use gdb::option::process_options.
 431         (pipe_command_completer): New function.
 432         (_initialize_cli_cmds): Install completer for "pipe" command.
 433
 434 2019-07-03  Pedro Alves  <palves@redhat.com>
 435
 436         * cli/cli-option.c (union option_value) <string>: New field.
 437         (struct option_def_and_value): Add ctor, move ctor, dtor and
 438         use DISABLE_COPY_AND_ASSIGN.
 439         (option_def_and_value::clear_value): New.
 440         (parse_option, save_option_value_in_ctx, get_val_type_str)
 441         (add_setshow_cmds_for_options): Handle var_string.
 442         * cli-option.h (union option_def::var_address) <string>: New
 443         field.
 444         (struct string_option_def): New.
 445         * maint-test-options.c (struct test_options_opts): Add default
 446         ctor and use DISABLE_COPY_AND_ASSIGN.
 447         <string_opt>: New field.
 448         (test_options_opts::~test_options_opts): New.
 449         (test_options_opts::dump): Also dump "-string".
 450         (test_options_option_defs): Install "string.
 451
 452 2019-07-03  Pedro Alves  <palves@redhat.com>
 453
 454         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 455         option_value with a null enumeration.
 456         (complete_options): Save the option values in the context.
 457         (save_option_value_in_ctx): New, factored out from ...
 458         (process_options): ... here.
 459         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 460         of the function.
 461         * maint-test-options.c (test_options_opts::dump): New, factored
 462         out from ...
 463         (maintenance_test_options_command_mode): ... here.
 464         (maintenance_test_options_command_completion_result): Delete.
 465         (maintenance_test_options_command_completion_text): Update
 466         comment.
 467         (maintenance_show_test_options_completion_result): Change
 468         prototype.  Just print
 469         maintenance_test_options_command_completion_text.
 470         (save_completion_result): New.
 471         (maintenance_test_options_completer_mode): Pass options context to
 472         complete_options, and then save a dump.
 473         (_initialize_maint_test_options): Use add_cmd to install "maint
 474         show test-options-completion-result".
 475
 476 2019-07-03  Pedro Alves  <palves@redhat.com>
 477
 478         * NEWS (New commands): Mention "with" and "maint with".
 479         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 480         (with_command, with_command_completer): New.
 481         (pipe_command): Adjust to new repeat_previous
 482         interface.
 483         (_initialize_cli_cmds): Install the "with" command and its "w"
 484         alias.
 485         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 486         declarations.
 487         * cli/cli-setshow.c (parse_cli_var_uinteger)
 488         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 489         argument strings for all var_types.
 490         (get_setshow_command_value_string): New, factored out from ...
 491         (do_show_command): ... this.
 492         * cli/cli-setshow.h: Include <string>.
 493         (get_setshow_command_value_string): Declare.
 494         * command.h (repeat_previous): Now returns const char *.  Adjust
 495         comment.
 496         * maint.c: Include "cli/cli-cmds.h".
 497         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 498         (_initialize_maint_cmds): Register the "maintenance with" command.
 499         * top.c (repeat_previous): Move bits from pipe_command here:
 500         Return the saved command line, if any; error out if there's no
 501         command to relaunch.
 502
 503 2019-07-03  Pedro Alves  <palves@redhat.com>
 504
 505         * NEWS (New commands): Mention "maint set/show test-settings"
 506         instead of "maint test-settings".
 507         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 508         (maintenance_test_settings_set_list): Rename to ...
 509         (maintenance_set_test_settings_list): ... this.
 510         (maintenance_test_settings_show_list): Rename to  ...
 511         (maintenance_show_test_settings_list): ... this.
 512         (maintenance_test_settings_cmd): Delete.
 513         (maintenance_test_settings_set_cmd): ...
 514         (maintenance_set_test_settings_cmd): ... this.
 515         (maintenance_test_settings_show_cmd): ...
 516         (maintenance_show_test_settings_cmd): ... this.
 517         (maintenance_test_settings_show_value_cmd):
 518         (maintenance_show_test_settings_value_cmd): ... this.
 519         (_initialize_maint_test_settings): No longer install the "maint
 520         test-settings" prefix command.  Rename "maint test-settings set"
 521         to "maint set test-settings", and "maint test-settings show" to
 522         "maint show test-settings".  Adjust all subcommands.
 523
 524 2019-07-03  Pedro Alves  <palves@redhat.com>
 525
 526         * maint-test-settings.c: Fix file's intro comment.  Replace all
 527         references to "test-options" with references to "test-settings",
 528         in comments.
 529
 530 2019-07-03  Pedro Alves  <palves@redhat.com>
 531
 532         * maint-test-settings.c (maintenance_test_settings_xxx)
 533         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 534         New.
 535         (maintenance_test_settings_enums): Use them.
 536         (maintenance_test_settings_enum): Default to
 537         maintenance_test_settings_xxx.
 538         (_initialize_maint_test_settings): Initialize
 539         MAINTENANCE_TEST_SETTINGS_FILENAME.
 540
 541 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 542
 543         * breakpoint.h (remove_breakpoints_inf): Change return type to
 544         void, move function documentation here.
 545         * breakpoint.c (remove_breakpoints_inf): Change return type to
 546         void, move function documentation to header.
 547
 548 2019-07-02  Pedro Alves  <palves@redhat.com>
 549
 550         * NEWS (Completion improvements): Mention "info threads".
 551         * thread.c (struct info_threads_opts, info_threads_option_defs)
 552         (make_info_threads_options_def_group): New.
 553         (info_threads_command): Use gdb::option::process_options.
 554         (info_threads_command_completer): New.
 555         (_initialize_thread): Use gdb::option::build_help to build the
 556         help text for "info threads".
 557
 558 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 559
 560         * defs.h (generic_load): Move from here...
 561         * symfile.h (generic_load): ... to here.  Rename name parameter
 562         to args.
 563         * symfile.c (generic_load): Add comment.
 564
 565 2019-07-01  Tom Tromey  <tromey@adacore.com>
 566
 567         * dwarf2read.c
 568         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 569         declaration of without_params.  Fix formatting.
 570
 571 2019-07-01  Tom Tromey  <tromey@adacore.com>
 572
 573         * ada-exp.y (find_primitive_type): Update.
 574         * ada-lang.h (ada_lookup_symbol): Update.
 575         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 576         parameter.
 577         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 578
 579 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 580
 581         PR breakpoints/24541
 582         * gdbarch.c: Regenerate.
 583         * gdbarch.h: Regenerate.
 584         * gdbarch.sh: Add 'stap_adjust_register'.
 585         * i386-tdep.c: Include '<unordered_set>'.
 586         (i386_stap_adjust_register): New function.
 587         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 588         * stap-probe.c (stap_parse_register_operand): Call
 589         'gdbarch_stap_adjust_register'.
 590
 591 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 592
 593         PR python/24742
 594         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 595         * python/python.c (do_start_initialization): Use 'xmalloc'
 596         instead of 'PyMem_Malloc'.
 597
 598 2019-06-28  Tom Tromey  <tromey@adacore.com>
 599
 600         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 601         for Ada.
 602
 603 2019-06-27  Tom Tromey  <tromey@adacore.com>
 604
 605         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 606         objfile_key.
 607         (arm_find_mapping_symbol, arm_record_special_symbol)
 608         (_initialize_arm_tdep): Update.
 609         (arm_objfile_data_free): Remove.
 610
 611 2019-06-27  Tom Tromey  <tromey@adacore.com>
 612
 613         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 614         to cp_print_static_field.
 615
 616 2019-06-26  Tom Tromey  <tromey@adacore.com>
 617
 618         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 619         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 620         declare.
 621
 622 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 623
 624         * features/aarch64-core.c (create_feature_aarch64_core):
 625         Regenerate.
 626         * features/aarch64-core.xml: Add cpsr flags.
 627
 628 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 629
 630         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 631         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 632
 633 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 634
 635         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 636         field.
 637         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 638         use.
 639         (arm_record_special_symbol): Don't insert new symbol in sorted
 640         position, push it at the end.
 641
 642 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 643
 644         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 645         (arm_mapping_symbol_s): Remove.
 646         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 647         (arm_mapping_symbol_vec): New typedef.
 648         (struct arm_per_objfile): Add constructor.
 649         <section_maps>: Change type to
 650         std::unique_ptr<arm_mapping_symbol_vec[]>.
 651         (arm_compare_mapping_symbols): Remove.
 652         (arm_find_mapping_symbol): Adjust to section_maps type change.
 653         (arm_objfile_data_free): Call delete on arm_per_objfile.
 654         (arm_record_special_symbol): Adjust to section_maps type change.
 655         Allocate arm_per_objfile with new.
 656
 657 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 658
 659         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 660         with the command prefix.
 661
 662 2019-06-25  Tom Tromey  <tom@tromey.com>
 663
 664         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 665         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 666
 667 2019-06-25  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 670         type.
 671         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 672         protected.
 673
 674 2019-06-25  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-winsource.c
 677         (tui_source_window_base::set_is_exec_point_at): Add check against
 678         LOA_ADDRESS.
 679
 680 2019-06-25  Tom Tromey  <tom@tromey.com>
 681
 682         * tui/tui-source.c (tui_set_source_content): Don't check before
 683         xfree.
 684         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 685
 686 2019-06-25  Tom Tromey  <tom@tromey.com>
 687
 688         * tui/tui-winsource.h (tui_update_source_window_as_is)
 689         (tui_alloc_source_buffer, tui_line_is_displayed)
 690         (tui_addr_is_displayed): Change type of win_info.
 691         * tui/tui-winsource.c (tui_update_source_window_as_is)
 692         (tui_clear_source_content, tui_show_source_line)
 693         (tui_show_source_content, tui_source_window_base::refill)
 694         (tui_source_window_base::set_is_exec_point_at)
 695         (tui_source_window_base::set_is_exec_point_at)
 696         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 697         (tui_alloc_source_buffer, tui_line_is_displayed)
 698         (tui_addr_is_displayed): Change type of win_info.  Update.
 699         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 700         (tui_source_window_base::do_make_visible_with_new_height):
 701         Update.
 702         * tui/tui-source.c (tui_set_source_content)
 703         (tui_set_source_content_nil)
 704         (tui_source_window::do_scroll_vertical): Update.
 705         * tui/tui-layout.c (show_layout): Update.
 706         * tui/tui-disasm.c (tui_set_disassem_content)
 707         (tui_disasm_window::do_scroll_vertical): Update.
 708         * tui/tui-data.h (tui_win_content): Remove.
 709         (struct tui_gen_win_info) <content, content_size>: Remove.
 710         (struct tui_source_element): Add initializers and destructor.
 711         (union tui_which_element, struct tui_win_element): Remove.
 712         (struct tui_source_window_base) <content>: New field.
 713         (struct tui_data_window): Remove destructor.
 714         (tui_alloc_content, tui_free_win_content)
 715         (tui_free_all_source_wins_content): Don't declare.
 716         * tui/tui-data.c (tui_initialize_static_data): Update.
 717         (init_content_element, tui_alloc_content): Remove.
 718         (~tui_gen_win_info): Update.
 719         (~tui_data_window, tui_free_all_source_wins_content)
 720         (tui_free_win_content, free_content, free_content_elements):
 721         Remove.
 722
 723 2019-06-25  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui-winsource.h (tui_clear_source_content)
 726         (tui_erase_source_content, tui_show_source_content): Change type
 727         of win_info.
 728         * tui/tui-winsource.c (tui_clear_source_content)
 729         (tui_erase_source_content, tui_show_source_content): Change type
 730         of win_info.
 731         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 732         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 733         win_info.
 734         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 735         win_info.
 736         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 737
 738 2019-06-25  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-winsource.c (tui_clear_source_content)
 741         (tui_source_window_base::set_is_exec_point_at): Update.
 742         * tui/tui-source.c (tui_set_source_content_nil): Update.
 743         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 744         a bool.
 745         * tui/tui-data.c (init_content_element): Update.
 746
 747 2019-06-25  Tom Tromey  <tom@tromey.com>
 748
 749         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 750         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 751         * tui/tui-layout.c (init_and_make_win): Update.
 752         * tui/tui.h (enum tui_win_type): Update.
 753         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 754         tui_win_is_auxillary.
 755         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 756         tui_win_is_auxillary.
 757
 758 2019-06-25  Tom Tromey  <tom@tromey.com>
 759
 760         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 761         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 762         (tui_delete_data_content_windows, tui_display_all_data)
 763         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 764         Update.
 765         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 766         * tui/tui-regs.c (tui_last_regs_line_no)
 767         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 768         (tui_show_registers): Update.
 769         (tui_show_register_group): Return void.  Update.
 770         (tui_display_registers_from, tui_display_reg_element_at_line)
 771         (tui_display_registers_from_line, tui_check_register_values):
 772         Update.
 773         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 774         member.
 775         (struct tui_data_window) <regs_content>: Now a std::vector.
 776         <regs_content_count>: Remove.
 777         (tui_add_content_elements, tui_free_data_content): Don't declare.
 778         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 779         (init_content_element): Remove DATA_WIN case.  Add assert.
 780         (tui_add_content_elements): Remove.
 781         (tui_data_window): Update.
 782         (tui_free_data_content): Remove.
 783         (free_content_elements): Remove DATA_WIN case.
 784
 785 2019-06-25  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-data.c (tui_data_item_window): Update.
 788         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 789         * tui/tui-windata.c (tui_display_all_data)
 790         (tui_display_data_from_line): Update.
 791         (tui_check_data_values): Remove.
 792         * tui/tui-regs.c (tui_show_register_group)
 793         (tui_display_reg_element_at_line): Update.
 794         * tui/tui-hooks.c (tui_register_changed)
 795         (tui_refresh_frame_and_register_information): Call
 796         tui_check_register_values.
 797         * tui/tui-data.h (struct tui_data_window) <data_content,
 798         data_content_count, data_type>: Remove.
 799         (enum tui_data_type): Remove.
 800
 801         * tui/tui-data.c (tui_data_window::clear_detail)
 802         (~tui_data_window): Update.
 803
 804 2019-06-25  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 807         declare.
 808         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 809         Rename from tui_first_data_item_displayed.  Update.
 810         (tui_data_window::refresh_all)
 811         (tui_data_window::do_scroll_vertical): Update.
 812         * tui/tui-data.h (struct tui_data_window)
 813         <first_data_item_displayed>: Declare new method.
 814
 815 2019-06-25  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 818         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 819         contents...
 820         (tui_initialize_static_data): ...here.
 821
 822 2019-06-25  Tom Tromey  <tom@tromey.com>
 823
 824         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 825         (tui_display_registers_from, tui_check_register_values): Update.
 826         (tui_display_register): Remove win_info parameter; update.
 827         (tui_get_register): Change type of parameters.
 828         * tui/tui-data.h (struct tui_data_element): Remove.
 829         (union tui_which_element) <data>: Remove.
 830         <data_window>: Change type.
 831         (struct tui_data_item_window): New.
 832         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 833         case.  Add assert.
 834         (~tui_data_item_window): New destructor.
 835         (free_content_elements): Remove DATA_ITEM_WIN case.
 836
 837 2019-06-25  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 840         Remove.
 841
 842 2019-06-25  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-data.h (struct tui_command_element): Remove.
 845         (union tui_which_element) <command>: Remove.
 846         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 847         assert.
 848         (free_content_elements): Remove CMD_WIN case.
 849
 850 2019-06-25  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-layout.c (tui_set_layout): Update.
 853         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 854         * tui/tui-data.c (layout_def): Update.
 855
 856 2019-06-25  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 859         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 860         (tui_source_window_base::set_new_height): Update.
 861         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 862         Update.
 863         (tui_set_locator_fullname, tui_set_locator_info)
 864         (tui_show_frame_info): Update.
 865         * tui/tui-source.c (tui_set_source_content)
 866         (tui_source_is_displayed): Update.
 867         * tui/tui-layout.c (show_source_disasm_command, show_data)
 868         (show_source_or_disasm_and_command): Update.
 869         * tui/tui-disasm.c (tui_set_disassem_content)
 870         (tui_get_begin_asm_address): Update.
 871         * tui/tui-data.h (struct tui_locator_element): Remove.
 872         (union tui_which_element) <locator>: Remove.
 873         (struct tui_locator_window): New.
 874         (tui_locator_win_info_ptr): Change return type.
 875         * tui/tui-data.c (_locator): Change type.
 876         (tui_locator_win_info_ptr): Change return type.
 877         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 878         (tui_alloc_content): Add assert.
 879
 880 2019-06-25  Tom Tromey  <tom@tromey.com>
 881
 882         * tui/tui-winsource.c
 883         (tui_exec_info_window::maybe_allocate_content): New method.
 884         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 885         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 886         (make_source_or_disasm_window): Add cast.
 887         * tui/tui-data.h (union tui_which_element) <simple_string>:
 888         Remove.
 889         (struct tui_source_info): New.
 890         (struct tui_source_window_base) <execution_info>: Change type.
 891         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 892         case, and add assert.
 893         (tui_alloc_content): Add assert.
 894
 895 2019-06-25  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 898         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 899         * tui/tui-data.c (tui_alloc_win_info): Remove.
 900
 901 2019-06-25  Tom Tromey  <tom@tromey.com>
 902
 903         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 904         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 905         can_highlight.
 906
 907 2019-06-25  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 910         make_visible_with_new_height method.
 911         (tui_win_info::make_visible_with_new_height): New method.
 912         (tui_source_window_base::do_make_visible_with_new_height)
 913         (tui_data_window::do_make_visible_with_new_height)
 914         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 915         (make_visible_with_new_height): Remove.
 916         (tui_resize_all, tui_adjust_win_heights): Use
 917         make_visible_with_new_height method.
 918         * tui/tui-data.h (struct tui_win_info)
 919         <do_make_visible_with_new_height, make_visible_with_new_height>:
 920         New methods.
 921         (struct tui_source_window_base, struct tui_data_window)
 922         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 923         methods.
 924
 925 2019-06-25  Tom Tromey  <tom@tromey.com>
 926
 927         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 928         method.
 929         (update_tab_width): Call update_tab_width method.
 930         * tui/tui-data.h (struct tui_win_info)
 931         (struct tui_source_window_base) <update_tab_width>: New methods.
 932
 933 2019-06-25  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 936         parameter.
 937         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 938         parameter.
 939         (tui_gen_win_info::make_visible): Update.
 940         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 941         parameter.
 942         * tui/tui-data.h (enum tui_box): New enum.
 943         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 944
 945 2019-06-25  Tom Tromey  <tom@tromey.com>
 946
 947         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 948         init_and_make_win for EXEC_INFO_WIN.
 949         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 950         longer inline.
 951         (struct tui_win_info) <~tui_win_info>: Inline.
 952         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 953         Don't declare.
 954         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 955         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 956         Remove.
 957         (tui_initialize_static_data): Update.
 958         (~tui_gen_win_info): Handle more cleanup here.
 959         (~tui_source_window_base): Delete "execution_info".
 960         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 961
 962 2019-06-25  Tom Tromey  <tom@tromey.com>
 963
 964         * tui/tui-layout.c (make_command_window): Don't set
 965         can_highlight.
 966         (show_source_disasm_command): Call the reset method.
 967         (show_data): Don't set can_highlight.  Call the reset method.
 968         (tui_gen_win_info::reset): Rename from init_gen_win_info
 969         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 970         (show_source_or_disasm_and_command): Call the reset method.
 971         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 972         (struct tui_cmd_window): Set can_highlight.
 973
 974 2019-06-25  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 977         from make_visible.
 978         (tui_make_visible, tui_make_invisible): Rewrite.
 979         (tui_win_info::make_visible): Remove.
 980         (tui_source_window_base::make_visible): Update.
 981         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 982         method.  Moved from...
 983         (struct tui_win_info) <make_visible>: ...here.
 984
 985 2019-06-25  Tom Tromey  <tom@tromey.com>
 986
 987         * tui/tui-winsource.c
 988         (tui_source_window_base::do_scroll_horizontal): Remove direction
 989         parameter.
 990         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 991         direction parameter.
 992         * tui/tui-win.c (tui_win_info::forward_scroll)
 993         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 994         (tui_win_info::right_scroll): Update.
 995         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 996         direction parameter.
 997         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 998         direction parameter.
 999         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1000         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1001         Remove direction parameter.
1002         (struct tui_source_window_base, struct tui_source_window)
1003         (struct tui_disasm_window, struct tui_data_window)
1004         (struct tui_cmd_window): Update.
1005
1006 2019-06-25  Tom Tromey  <tom@tromey.com>
1007
1008         * tui/tui-winsource.h (tui_set_exec_info_content)
1009         (tui_show_exec_info_content, tui_erase_exec_info_content)
1010         (tui_clear_exec_info_content, tui_update_exec_info): Change
1011         argument to tui_source_window_base.
1012         * tui/tui-winsource.c (tui_set_exec_info_content)
1013         (tui_show_exec_info_content, tui_erase_exec_info_content)
1014         (tui_clear_exec_info_content, tui_update_exec_info): Change
1015         argument to tui_source_window_base.
1016
1017 2019-06-25  Tom Tromey  <tom@tromey.com>
1018
1019         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1020         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1021
1022 2019-06-25  Tom Tromey  <tom@tromey.com>
1023
1024         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1025         check.
1026
1027 2019-06-25  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1030         type to void.
1031         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1032         type to void.
1033         * tui/tui-source.c (tui_set_source_content): Update.
1034         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1035
1036 2019-06-25  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-win.c (window_name_completer, tui_set_focus)
1039         (tui_all_windows_info): Use name method.
1040         * tui/tui-data.h (struct tui_gen_win_info)
1041         (struct tui_source_window, struct tui_disasm_window)
1042         (struct tui_data_window, struct tui_cmd_window) <name>: New
1043         method.
1044         (tui_win_name): Don't declare.
1045         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1046         (tui_win_name): Remove.
1047
1048 2019-06-25  Tom Tromey  <tom@tromey.com>
1049
1050         * tui/tui-winsource.h (tui_update_source_window)
1051         (tui_update_source_window_as_is): Change parameter type.
1052         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1053         to be a tui_source_window_base.
1054         (tui_update_source_window_as_is): Likewise.
1055         * tui/tui-win.c (make_visible_with_new_height): Update.
1056
1057 2019-06-25  Tom Tromey  <tom@tromey.com>
1058
1059         * tui/tui-winsource.c (tui_erase_source_content)
1060         (tui_show_source_content, tui_show_exec_info_content)
1061         (tui_erase_exec_info_content): Use refresh_window method.
1062         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1063         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1064         from tui_refresh_win.
1065         (tui_data_window::refresh_window): New method.
1066         (tui_win_info::refresh, tui_source_window_base::refresh)
1067         (tui_refresh_all): Use refresh_window method.
1068         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1069         method.
1070         * tui/tui-regs.c (tui_display_register): Call refresh_window
1071         method.
1072         * tui/tui-layout.c (show_source_disasm_command)
1073         (show_source_or_disasm_and_command): Call refresh_window method.
1074         * tui/tui-data.h (struct tui_gen_win_info)
1075         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1076         New method.
1077
1078 2019-06-25  Tom Tromey  <tom@tromey.com>
1079
1080         * tui/tui.c (tui_rl_other_window, tui_enable)
1081         (tui_is_window_visible, tui_get_command_dimension): Update.
1082         * tui/tui-winsource.c (tui_update_source_window_as_is)
1083         (tui_clear_source_content, tui_erase_source_content)
1084         (tui_show_source_line, tui_source_window_base::refill)
1085         (tui_source_window_base::do_scroll_horizontal)
1086         (tui_source_window_base::set_is_exec_point_at)
1087         (tui_update_breakpoint_info, tui_set_exec_info_content)
1088         (tui_alloc_source_buffer, tui_line_is_displayed)
1089         (tui_addr_is_displayed): Update.
1090         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1091         (tui_check_and_display_highlight_if_needed)
1092         (tui_win_info::make_visible, tui_win_info::refresh)
1093         (tui_refresh_all): Update.
1094         * tui/tui-windata.c (tui_first_data_item_displayed)
1095         (tui_delete_data_content_windows, tui_erase_data_content)
1096         (tui_display_all_data, tui_data_window::refresh_all)
1097         (tui_check_data_values): Update.
1098         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1099         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1100         (tui_win_info::backward_scroll, tui_refresh_all_win)
1101         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1102         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1103         (tui_source_window_base::set_new_height)
1104         (tui_data_window::set_new_height)
1105         (make_invisible_and_set_new_height)
1106         (make_visible_with_new_height, new_height_ok)
1107         (parse_scrolling_args): Update.
1108         * tui/tui-stack.c (tui_show_frame_info): Update.
1109         * tui/tui-source.c (tui_set_source_content)
1110         (tui_set_source_content_nil, tui_source_is_displayed)
1111         (tui_source_window::do_scroll_vertical): Update.
1112         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1113         (tui_display_registers_from, tui_display_reg_element_at_line)
1114         (tui_check_register_values, tui_reg_command): Update.
1115         * tui/tui-layout.c (tui_default_win_height)
1116         (show_source_disasm_command, show_data, init_and_make_win)
1117         (show_source_or_disasm_and_command): Update.
1118         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1119         (tui_redisplay_readline, tui_mld_flush)
1120         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1121         (tui_getc): Update.
1122         * tui/tui-disasm.c (tui_set_disassem_content)
1123         (tui_disasm_window::do_scroll_vertical): Update.
1124         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1125         Now virtual.
1126         (struct tui_win_info): Derive from tui_gen_win_info.
1127         <~tui_win_info>: Mark as override.
1128         <generic>: Remove member.
1129         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1130         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1131         (~tui_data_window, ~tui_win_info)
1132         (tui_free_all_source_wins_content): Update.
1133         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1134
1135 2019-06-25  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui-layout.c (init_and_make_win): Use new.
1138         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1139         destructor, initializers.
1140         (tui_alloc_generic_win_info): Don't declare.
1141         * tui/tui-data.c (_locator): Add argument to constructor.
1142         (source_win, disasm_win): New globals.
1143         (exec_info): Remove.
1144         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1145         Update.
1146         (tui_alloc_generic_win_info): Remove.
1147         (init_content_element): Use new.
1148         (tui_win_info::tui_win_info): Update.
1149         (free_content_elements) <case DATA_WIN>: Use delete.
1150
1151 2019-06-25  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1154         * tui/tui-windata.c (tui_first_data_item_displayed)
1155         (tui_delete_data_content_windows): Update.
1156         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1157         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1158         (tui_display_registers_from, tui_check_register_values): Update.
1159         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1160         pointer.
1161         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1162         window.
1163         (tui_free_data_content): Update.
1164         (free_content_elements) <case DATA_WIN>: Free the window.
1165
1166 2019-06-25  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1169         Update.
1170         * tui/tui-layout.c (make_command_window)
1171         (show_source_disasm_command, show_data, init_and_make_win)
1172         (show_source_or_disasm_and_command): Update.
1173         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1174         method.
1175         <can_highight, is_highlighted>: Now bool.
1176         (tui_set_win_highlight): Don't declare.
1177         * tui/tui-data.c (tui_set_win_highlight): Remove.
1178
1179 2019-06-25  Tom Tromey  <tom@tromey.com>
1180
1181         * tui/tui-wingeneral.c (make_visible): Remove check of window
1182         type.
1183
1184 2019-06-25  Tom Tromey  <tom@tromey.com>
1185
1186         * tui/tui-win.c (tui_win_info::max_height)
1187         (tui_cmd_window::max_height): New methods.
1188         (new_height_ok): Call max_height.
1189         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1190         <max_height>: New method.
1191
1192 2019-06-25  Tom Tromey  <tom@tromey.com>
1193
1194         * tui/tui-win.c (tui_source_window_base::set_new_height)
1195         (tui_data_window::set_new_height): New methods.
1196         (make_invisible_and_set_new_height): Call set_new_height method.
1197         * tui/tui-data.h (struct tui_win_info)
1198         (struct tui_source_window_base, struct tui_data_window)
1199         <set_new_height>: New method.
1200
1201 2019-06-25  Tom Tromey  <tom@tromey.com>
1202
1203         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1204         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1205         tui_refresh_data_win.
1206         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1207         method.
1208         (tui_refresh_all_win): Call the refresh_all method.
1209         (tui_set_focus): Likewise.
1210         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1211         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1212         Likewise.
1213
1214 2019-06-25  Tom Tromey  <tom@tromey.com>
1215
1216         * tui/tui-winsource.h (tui_refill_source_window)
1217         (tui_set_is_exec_point_at): Don't declare.
1218         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1219         (tui_source_window_base::refill): Rename from
1220         tui_refill_source_window.
1221         (tui_source_window_base::do_scroll_horizontal): Update.
1222         (tui_source_window_base::set_is_exec_point_at): Rename from
1223         tui_set_is_exec_point_at.
1224         (tui_update_all_breakpoint_info): Update.
1225         * tui/tui-stack.c (tui_show_frame_info): Update.
1226         * tui/tui-layout.c (show_data): Add cast.
1227         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1228         * tui/tui-data.h (struct tui_source_window_base) <refill,
1229         set_is_exec_point_at>: New methods.
1230         (tui_source_windows, tui_add_to_source_windows): Update types.
1231         (tui_add_to_source_windows): Remove redundant declaration.
1232         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1233         (tui_source_windows): Change return type.
1234         (tui_clear_source_windows_detail): Update.
1235         (tui_add_to_source_windows): Change type of parameter.
1236         (tui_free_all_source_wins_content): Update.
1237
1238 2019-06-25  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui-wingeneral.c (tui_win_info::refresh)
1241         (tui_source_window_base::refresh): New methods.
1242         (tui_refresh_all): Call the refresh method.
1243         * tui/tui-data.h (struct tui_win_info)
1244         (struct tui_source_window_base) <refresh>: New method.
1245
1246 2019-06-25  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui.h (tui_is_window_visible): Return bool.
1249         * tui/tui.c (tui_is_window_visible): Return bool.
1250         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1251         (tui_make_visible, tui_make_invisible)
1252         (tui_win_info::make_visible)
1253         (tui_source_window_base::make_visible, make_all_visible)
1254         (tui_make_all_visible, tui_make_all_invisible): Update.
1255         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1256         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1257         bool.
1258         (struct tui_win_info, struct tui_source_window_base)
1259         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1260         * tui/tui-data.c (tui_init_generic_part): Update.
1261
1262 2019-06-25  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1265         (tui_source_window_base::make_visible): New methods.
1266         (make_all_visible): Make method call.
1267         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1268         (struct tui_source_window_base, struct tui_cmd_window): Override
1269         make_visible.
1270         (tui_win_is_source_type): Don't declare.
1271         * tui/tui-data.c (tui_win_is_source_type): Remove.
1272
1273 2019-06-25  Tom Tromey  <tom@tromey.com>
1274
1275         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1276         NULL check.
1277
1278 2019-06-25  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1281         Inline constructor.  Add initializers for members.
1282         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1283         constructors; now inline in class.
1284
1285 2019-06-25  Tom Tromey  <tom@tromey.com>
1286
1287         * tui/tui-regs.c (tui_show_registers): Update.
1288         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1289         bool.
1290         * tui/tui-data.c (tui_data_window::clear_detail)
1291         (tui_data_window): Update.
1292
1293 2019-06-25  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-windata.c (tui_display_all_data)
1296         (tui_display_data_from_line, tui_display_data_from)
1297         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1298         Update.
1299         * tui/tui-regs.c (tui_last_regs_line_no)
1300         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1301         (tui_show_registers, tui_show_register_group)
1302         (tui_display_registers_from, tui_display_reg_element_at_line)
1303         (tui_display_registers_from_line, tui_check_register_values)
1304         (tui_reg_next, tui_reg_prev): Update.
1305         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1306         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1307         tui_data_window.
1308         (struct tui_win_info) <detail>: Remove.  Add new fields from
1309         tui_data_info.
1310         (TUI_DATA_WIN): Add cast.
1311         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1312         (~tui_data_window): Simplify.
1313
1314 2019-06-25  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-layout.c (show_source_disasm_command)
1317         (show_source_or_disasm_and_command): Update.
1318         * tui/tui-io.c (update_cmdwin_start_line)
1319         (tui_redisplay_readline): Update.
1320         * tui/tui-data.h (struct tui_command_info): Remove.
1321         (struct tui_win_info) <detail>: Remove command_info member.
1322         (struct tui_data_window) <start_line>: New member, from
1323         tui_command_info.
1324         (TUI_CMD_WIN): Add casts.
1325
1326 2019-06-25  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-winsource.c (tui_update_source_window)
1329         (tui_refill_source_window)
1330         (tui_source_window_base::do_scroll_horizontal)
1331         (tui_update_breakpoint_info, tui_set_exec_info_content)
1332         (tui_show_exec_info_content, tui_erase_exec_info_content)
1333         (tui_clear_exec_info_content): Update.
1334         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1335         Update.
1336         * tui/tui-win.c (make_invisible_and_set_new_height)
1337         (make_visible_with_new_height): Update.
1338         * tui/tui-source.c (tui_set_source_content)
1339         (tui_show_symtab_source): Update.
1340         * tui/tui-layout.c (extract_display_start_addr)
1341         (show_source_disasm_command, show_data)
1342         (make_source_or_disasm_window)
1343         (show_source_or_disasm_and_command): Update.
1344         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1345         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1346         "gdbarch".
1347         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1348         to tui_source_window_base.
1349         (struct tui_win_info) <detail>: Remove source_info member.
1350         (struct tui_source_window_base) <has_locator>: Inline.
1351         Move contents from tui_source_info; rename has_locator member to
1352         m_has_locator.
1353         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1354         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1355         header file.
1356         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1357         Simplify.
1358         (tui_free_all_source_wins_content): Cast to
1359         tui_source_window_base.
1360
1361 2019-06-25  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-win.c (make_invisible_and_set_new_height)
1364         (make_visible_with_new_height): Call has_locator method.
1365         * tui/tui-layout.c (show_source_disasm_command, show_data)
1366         (show_source_or_disasm_and_command): Update for bool change.
1367         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1368         (tui_win_info) <has_locator>: New method.
1369         (struct tui_source_window_base) <has_locator>: New method.
1370         (tui_win_has_locator): Don't declare.
1371         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1372         from tui_win_has_locator.
1373         (tui_source_window_base): Use false, not FALSE.
1374
1375 2019-06-25  Tom Tromey  <tom@tromey.com>
1376
1377         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1378         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1379         clear_detail method directly.
1380         (tui_clear_win_detail): Remove.
1381
1382 2019-06-25  Tom Tromey  <tom@tromey.com>
1383
1384         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1385         "this", not TUI_DISASM_WIN.
1386
1387 2019-06-25  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1390         declare.
1391         * tui/tui-winsource.c
1392         (tui_source_window_base::do_scroll_horizontal): Rename from
1393         tui_horizontal_source_scroll.
1394         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1395         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1396         from tui_vertical_data_scroll.
1397         * tui/tui-win.h (tui_scroll): Don't declare.
1398         * tui/tui-win.c (tui_win_info::forward_scroll)
1399         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1400         (tui_win_info::right_scroll): Rename and update.
1401         (tui_scroll_forward_command, tui_scroll_backward_command)
1402         (tui_scroll_left_command, tui_scroll_right_command): Update.
1403         (tui_scroll): Remove.
1404         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1405         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1406         from tui_vertical_source_scroll.
1407         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1408         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1409         from tui_vertical_disassem_scroll.
1410         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1411         do_scroll_horizontal>: New methods.
1412         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1413         Likewise.
1414         (struct tui_source_window_base): Add do_scroll_horizontal.
1415         (struct tui_source_window, struct tui_disasm_window): Add
1416         do_scroll_vertical.
1417         (struct tui_data_window, struct tui_cmd_window): Add
1418         do_scroll_horizontal and do_scroll_vertical.
1419         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1420
1421 2019-06-25  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-data.h (struct tui_source_window_base): New struct.
1424         (struct tui_source_window): Derive from tui_source_window_base.
1425         (struct tui_disasm_window): New struct.
1426         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1427         from tui_source_window::clear_detail.
1428         (tui_source_window_base): Rename from tui_source_window.
1429         (~tui_source_window_base): Rename from ~tui_source_window.
1430         (tui_alloc_win_info): Create a tui_disasm_window.
1431
1432 2019-06-25  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-data.h (struct tui_source_window)
1435         (struct tui_data_window): Declare destructors.
1436         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1437         destructors.
1438         (tui_win_info): Simplify.
1439
1440 2019-06-25  Tom Tromey  <tom@tromey.com>
1441
1442         * tui/tui-winsource.c (tui_display_main)
1443         (tui_update_source_windows_with_addr)
1444         (tui_update_all_breakpoint_info): Update.
1445         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1446         (new_height_ok, parse_scrolling_args): Update.
1447         * tui/tui-stack.c (tui_show_frame_info): Update.
1448         * tui/tui-data.h (struct tui_list): Remove.
1449         (tui_source_windows): Return a reference to a std::vector.
1450         * tui/tui-data.c (source_windows): Now a std::vector.
1451         (tui_source_windows): Change return type.
1452         (tui_clear_source_windows): Rewrite.
1453         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1454         (tui_free_all_source_wins_content): Rewrite.
1455
1456 2019-06-25  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1459         (struct tui_data_window, struct tui_cmd_window): Declare
1460         clear_detail method.
1461         * tui/tui-data.c (tui_source_window::clear_detail)
1462         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1463         methods.
1464         (tui_clear_win_detail): Simplify.
1465
1466 2019-06-25  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui-layout.c (make_source_window, make_disasm_window)
1469         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1470         Return the new window.
1471         (show_source_disasm_command, show_data)
1472         (show_source_or_disasm_and_command): Update.
1473
1474 2019-06-25  Tom Tromey  <tom@tromey.com>
1475
1476         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1477         parameter.  Return the new window.
1478         (show_source_disasm_command): Update and remove NULL check.
1479         (show_source_or_disasm_and_command): Update.
1480
1481 2019-06-25  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1484
1485 2019-06-25  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-data.h (struct tui_win_info): Make constructor
1488         protected.  Make destructor virtual.  Add initializers.
1489         (tui_source_window, tui_data_window, tui_cmd_window): New
1490         classes.
1491         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1492         constructor.  Add "type" parameter.
1493         (tui_source_window, tui_data_window, tui_cmd_window): New
1494         constructors.
1495         (tui_alloc_win_info): Instantiate the appropriate subclass.
1496
1497 2019-06-25  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-win.c (tui_resize_all): Use delete.
1500         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1501         destructor.
1502         (tui_free_window): Don't declare.
1503         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1504         Update.
1505
1506 2019-06-25  Tom Tromey  <tom@tromey.com>
1507
1508         * tui/tui-data.h (struct tui_win_info): Add constructor.
1509         * tui/tui-data.c (tui_alloc_win_info): Use new.
1510         (tui_free_window): Use delete.
1511
1512 2019-06-22  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1515         declare.
1516         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1517
1518 2019-06-22  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1521         declare.
1522         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1523
1524 2019-06-22  Tom de Vries  <tdevries@suse.de>
1525
1526         * dwarf2read.c (create_addrmap_from_aranges)
1527         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1528         instead of '%zu'.
1529
1530 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1531
1532         * dwarf2read.h (dwarf2_section_info_def): Remove.
1533         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1534         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1535         std::vector<dwarf2_section_info>.
1536         (struct dwo_file) <~dwo_file>: Remove.
1537         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1538         types field.
1539         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1540         (dwarf2_read_debug_names): Likewise.
1541         (create_debug_types_hash_table): Change parameter type to
1542         array_view, adjust code accordingly.
1543         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1544         (partial_die_info::fixup): Likewise.
1545         (determine_prefix): Likewise.
1546         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1547
1548 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1549
1550         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1551         gdb_bfd_ref_ptr.
1552         <~dwo_file>: Remove call to gdb_bfd_unref.
1553         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1554         gdb_bfd_ref_ptr::get.
1555
1556 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1557
1558         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1559         type to htab_up.
1560         * dwarf2read.c (struct dwo_file): Initialize fields.
1561         <~dwo_file>: New.
1562         (free_dwo_file): Remove, move content to ~dwo_file.
1563         (struct dwo_file_deleter): Remove.
1564         (dwo_file_up>: Remove custom deleter.
1565         (free_dwo_files): Remove.
1566         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1567         dwo_files.
1568         (process_skeletonless_type_units): Call unique_ptr::get.
1569         (allocate_dwo_file_hash_table): Add deleter to created hash
1570         table.  Change return type to htab_up.
1571         (lookup_dwo_file_slot): Don't memset dwo_file, call
1572         unique_ptr::get.
1573         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1574         (create_dwo_unit_in_dwp_v2): Likewise.
1575         (open_and_init_dwo_file): Likewise.
1576         (free_dwo_file_from_slot): Remove.
1577
1578 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1579
1580         * dwarf2read.h (struct dwarf2_section_info) <readin,
1581         is_virtual>: Change type to bool.
1582         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1583         true instead of 1.
1584
1585 2019-06-19  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-data.h (tui_init_content_element): Don't declare.
1588
1589 2019-06-19  Tom Tromey  <tom@tromey.com>
1590
1591         * tui/tui-data.h (tui_init_win_info): Don't declare.
1592
1593 2019-06-19  Tom de Vries  <tdevries@suse.de>
1594
1595         * dwarf2read.h (abstract_to_concrete): Change type to
1596         std::unordered_map<sect_offset, std::vector<sect_offset>,
1597         gdb::hash_enum<sect_offset>>.
1598
1599 2019-06-19  Tom Tromey  <tromey@adacore.com>
1600
1601         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1602         EVAL_AVOID_SIDE_EFFECTS specially.
1603
1604 2019-06-19  Tom Tromey  <tromey@adacore.com>
1605
1606         * source-cache.c (highlighter): New global.
1607         (source_cache::get_source_lines): Create a highlighter on demand.
1608
1609 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1610
1611         * defs.h (deprecated_interactive_hook): Delete declaration.
1612         * interps.c (clear_interpreter_hooks): Remove use of
1613         deprecated_interactive_hook.
1614         * top.c (deprecated_interactive_hook): Delete definition.
1615         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1616
1617 2019-06-18  Tom de Vries  <tdevries@suse.de>
1618
1619         PR gdb/24515
1620         * dwarf2read.h (abstract_to_concrete): Change type from
1621         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1622         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1623         * dwarf2read.c (read_variable): Update.
1624         (dwarf2_fetch_die_loc_sect_off): Update.
1625
1626 2019-06-17  Tom de Vries  <tdevries@suse.de>
1627
1628         PR gdb/24617
1629         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1630         accessing parent[parent_len - 1].
1631
1632 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1633
1634         PR gdb/24364
1635         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1636         call dtrace_process_dof with NULL dof.
1637
1638 2019-06-16  Tom de Vries  <tdevries@suse.de>
1639
1640         PR gdb/24445
1641         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1642
1643 2019-06-16  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1646         (make_all_visible): Use address of member.
1647
1648 2019-06-16  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1651         (tui_free_window, free_content, free_content_elements): Remove
1652         unnecessary cast.
1653         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1654         cast.
1655         * tui/tui-regs.c (tui_show_register_group)
1656         (tui_display_registers_from, tui_display_reg_element_at_line):
1657         Remove unnecessary cast.
1658
1659 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1660
1661         * linux-nat.c (normal_mask): Delete.
1662         (_initialize_linux_nat): Don't initialise normal_mask.
1663
1664 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1665
1666         PR gdb/24445
1667         * dwarf-index-write.h (write_psymtabs_to_index): Add
1668         dwz_basename parameter.
1669         * dwarf-index-write.c (write_gdbindex): Move file writing to
1670         write_gdbindex_1.  Change return type void.
1671         (assert_file_size): Move up, remove filename parameter.
1672         (write_gdbindex_1): New function.
1673         (write_debug_names): Change return type to void, call
1674         assert_file_size.
1675         (struct index_wip_file): New struct.
1676         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1677         file logic to index_wip_file.  Write index for dwz file if
1678         needed.
1679         (save_gdb_index_command): Pass basename of dwz file, if present.
1680         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1681         build-id of dwz file, if present.
1682         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1683         (dwarf2_get_dwz_file): Likewise.
1684         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1685         (dwarf2_get_dwz_file): Likewise.
1686
1687 2019-06-16  Tom Tromey  <tom@tromey.com>
1688
1689         * coffread.c (process_coff_symbol): Use xstrdup.
1690         * value.c (create_internalvar): Use xstrdup.
1691
1692 2019-06-16  Tom Tromey  <tom@tromey.com>
1693
1694         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1695         * breakpoint.c (stopin_command, stopat_command)
1696         (until_break_command, decode_location_default): Remove unnecessary
1697         cast.
1698         * utils.c (subset_compare): Remove unnecessary cast.
1699         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1700         cast.
1701         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1702         cast.
1703         * infcmd.c (path_command): Remove unnecessary cast.
1704         * coffread.c (decode_type): Remove unnecessary cast.
1705         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1706         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1707         * tui/tui-stack.c (tui_show_locator_content)
1708         (tui_show_frame_info): Remove unnecessary cast.
1709         * tui/tui-win.c (tui_scroll_forward_command)
1710         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1711         (parse_scrolling_args): Remove unnecessary cast.
1712         * tui/tui-data.c (init_win_info, tui_del_window)
1713         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1714         (free_content_elements): Remove unnecessary cast.
1715         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1716         unnecessary cast.
1717         * tui/tui-source.c (tui_set_source_content)
1718         (tui_vertical_source_scroll): Remove unnecessary cast.
1719         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1720         cast.
1721         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1722         * tui/tui-regs.c (tui_display_registers_from)
1723         (tui_display_register): Remove unnecessary cast.
1724         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1725         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1726         (make_visible): Remove unnecessary cast.
1727         * tui/tui-winsource.c (tui_erase_source_content)
1728         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1729         unnecessary cast.
1730         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1731         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1732         * stabsread.c (read_type, read_array_type, read_range_type):
1733         Remove unnecessary cast.
1734         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1735         (parse_symbol, parse_type, upgrade_type, parse_external)
1736         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1737         unnecessary cast.
1738         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1739
1740 2019-06-16  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-data.c (tui_alloc_generic_win_info)
1743         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1744         checks.
1745
1746 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1747             Andrew Burgess  <andrew.burgess@embecosm.com>
1748
1749         * f-typeprint.c (f_print_type): Don't return early for not
1750         associated or not allocated types.
1751         (f_type_print_varspec_suffix): Add print_rank parameter and print
1752         ranks of array types in case they dangling.
1753         (f_type_print_base): Add print_rank parameter.
1754
1755 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1756
1757         * NEWS: Mention new MI commands.
1758         * break-catch-throw.c (enum exception_event_kind): Move to
1759         breakpoint.h.
1760         (print_mention_exception_catchpoint): Output text as a single
1761         message.
1762         (catch_exception_command_1): Rename to...
1763         (catch_exception_event): ...this, make non-static, update header
1764         command, and change some parameter types.
1765         (catch_catch_command): Update for changes to
1766         catch_exception_command_1.
1767         (catch_throw_command): Likewise.
1768         (catch_rethrow_command): Likewise.
1769         * breakpoint.c (enum exception_event_kind): Delete.
1770         * breakpoint.h (enum exception_event_kind): Moved here from
1771         break-catch-throw.c.
1772         (catch_exception_event): Declare.
1773         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1774         (mi_cmd_catch_throw): New function.
1775         (mi_cmd_catch_rethrow): New function.
1776         (mi_cmd_catch_catch): New function.
1777         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1778         'catch-catch' entries.
1779         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1780         (mi_cmd_catch_rethrow): Declare.
1781         (mi_cmd_catch_catch): Declare.
1782
1783 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1784
1785         * annotate.c (annotate_source_line): Change return type to void,
1786         update implementation to match.
1787         * annotate.h (annotate_source_line): Change return type to void,
1788         update header comment.
1789         * stack.c (print_frame_info): Don't change what frame information
1790         is printed based on whether annotations are on or not.
1791
1792 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1793
1794         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1795         (annotate_source): Make static.
1796         (annotate_source_line): Moved from source.c and renamed from
1797         identify_source_line.  Update the return type.
1798         * annotate.h (annotate_source): Delete declaration.
1799         (annotate_source_line): Declaration moved from source.h, and
1800         renamed from identify_source_line.  Return type updated.
1801         * source.c (identify_source_line): Moved to annotate.c and renamed
1802         to annotate_source_line.
1803         (info_line_command): Remove check of annotation_level.
1804         * source.h (identify_source_line): Move declaration to annotate.h
1805         and rename to annotate_source_line.
1806         * stack.c: Add 'annotate.h' include.
1807         (print_frame_info): Remove check of annotation_level before
1808         calling annotate_source_line.
1809
1810 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1811
1812         * source-cache.c (source_cache::get_plain_source_lines): Use
1813         open_source_file_with_line_charpos instead of just
1814         open_source_file, remove call to find_source_lines.
1815         (source_cache::get_source_lines): Likewise.
1816         * source.c (find_source_lines): Make static.
1817         (get_filename_and_charpos): Renamed into...
1818         (open_source_file_with_line_charpos): ..this along with changes to
1819         return a scoped_fd, and some other minor clean ups.
1820         (identify_source_line): Use open_source_file_with_line_charpos.
1821         (search_command_helper): Use open_source_file_with_line_charpos
1822         instead of just open_source_file, remove call to
1823         find_source_lines.
1824         * source.h (open_source_file_with_line_charpos): Declare new
1825         function.
1826         (find_source_lines): Delete declaration.
1827
1828 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1829
1830         * source.c (get_filename_and_charpos): Remove fullname
1831         parameter.
1832         (identify_source_line): Update call to get_filename_and_charpos.
1833
1834 2019-06-14  Tom Tromey  <tromey@adacore.com>
1835
1836         PR gdb/24502:
1837         * ui-style.h (skip_ansi_escape): Update comment.
1838         * ui-file.h (class no_terminal_escape_file): New class.
1839         * ui-file.c (no_terminal_escape_file::write)
1840         (no_terminal_escape_file::puts): New methods.
1841         * cli/cli-logging.c (handle_redirections): Use
1842         no_terminal_escape_file.
1843
1844 2019-06-14  Tom Tromey  <tromey@adacore.com>
1845
1846         * NEWS: Move convenience variable news above Python news.
1847
1848 2019-06-14  Tom Tromey  <tom@tromey.com>
1849
1850         * gnulib: Move directory to top-level.
1851         * configure.ac: Don't configure gnulib.
1852         * configure: Rebuild.
1853         * common/common-defs.h: Use new path to gnulib.
1854         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1855         (GNULIB_H): Remove.
1856         (INCGNU): Look in new gnulib location.
1857         (HFILES_NO_SRCDIR): Remove gnulib files.
1858         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1859         (generated_files): Remove GNULIB_H.
1860         ($(LIBGNU), all-lib): Remove targets.
1861         (distclean): Don't mention GNULIB_BUILDDIR.
1862         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1863
1864 2019-06-14  Tom Tromey  <tromey@adacore.com>
1865
1866         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1867         Warn if symbol file does not provide any symbols.
1868
1869 2019-06-14  Tom Tromey  <tromey@adacore.com>
1870
1871         * source.c (find_and_open_source): Respect basenames_may_differ.
1872
1873 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1874
1875         * annotate.c (annotate_breakpoints_invalid): Make use of
1876         scoped_restore_terminal_state.
1877         (annotate_frames_invalid): Likewise.
1878
1879 2019-06-14  Tom Tromey  <tromey@adacore.com>
1880
1881         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1882         allow assignment to an internalvar.
1883
1884 2019-06-14  Tom Tromey  <tromey@adacore.com>
1885
1886         * ada-lex.l: Allow "_" in attribute names.
1887
1888 2019-06-14  Tom Tromey  <tromey@adacore.com>
1889
1890         PR gdb/24653:
1891         * regcache.c (registers_changed): Don't call alloca.
1892         * top.c (execute_command): Don't call alloca.
1893
1894 2019-06-13  Pedro Alves  <palves@redhat.com>
1895
1896         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1897         'expression'.  When parsing an expression, error out if there's
1898         junk after "unlimited".
1899         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1900         (do_set_command): Adjust calls to is_unlimited_literal.
1901
1902 2019-06-13  Pedro Alves  <palves@redhat.com>
1903
1904         * compile/compile.c (make_compile_options_def_group): Add braces
1905         around array_view initializer.
1906         * thread.c (make_thread_apply_all_options_def_group)
1907         (make_thread_apply_all_options_def_group): Likewise.
1908
1909 2019-06-13  Pedro Alves  <palves@redhat.com>
1910
1911         * NEWS (New commands): Mention "maint test-options
1912         require-delimiter", "maint test-options unknown-is-error", "maint
1913         test-options unknown-is-operand" and "maint show
1914         test-options-completion-result".
1915         (New command options, command completion): New section.
1916         (Completion improvements): New section.
1917         Mention that you can abbreviate "unlimited".
1918
1919 2019-06-13  Pedro Alves  <palves@redhat.com>
1920
1921         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1922         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1923         * unittests/cli-utils-selftests.c (test_parse_flags)
1924         (test_parse_flags_qcs): Delete.
1925         (test_cli_utils): Don't call deleted functions.
1926
1927 2019-06-13  Pedro Alves  <palves@redhat.com>
1928
1929         * thread.c: Include "cli/cli-option.h".
1930         (tp_array_compar_ascending): Global.
1931         (tp_array_compar): Delete function.
1932         (tp_array_compar_ascending, tp_array_compar_descending): New
1933         functions.
1934         (ascending_option_def, qcs_flag_option_def)
1935         (thr_qcs_flags_option_defs)
1936         (make_thread_apply_all_options_def_group)
1937         (make_thread_apply_options_def_group): New.
1938         (thread_apply_all_command): Use gdb::option::process_options.
1939         (thread_apply_command_completer)
1940         (thread_apply_all_command_completer): New.
1941         (thread_apply_command): Use gdb::option::process_options.
1942         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1943         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1944         to generate help text of "thread apply".  Adjust "taas"'s help.
1945         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1946         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1947
1948 2019-06-13  Pedro Alves  <palves@redhat.com>
1949
1950         * thread.c (thread_apply_command): Check for invalid TID with
1951         isdigit instead of !isalpha.
1952
1953 2019-06-13  Pedro Alves  <palves@redhat.com>
1954
1955         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1956         (validate_flags_qcs): New.
1957         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1958         (validate_flags_qcs): Declare.
1959         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1960         (make_frame_apply_options_def_group): New.
1961         (frame_apply_command_count): Process options with
1962         gdb::option::process_options.
1963         (frame_apply_completer): New.
1964         (frame_apply_level_completer, frame_apply_all_completer)
1965         (frame_apply_completer): New.
1966         (_initialize_stack): Update help of "frame apply", "frame apply
1967         level", "frame apply all" and "faas" to mention supported options
1968         and install command completers.
1969         * stack.h (frame_apply_all_completer): Declare.
1970         * thread.c: Include "stack.h".
1971         (tfaas_command): Add "--".
1972         (_initialize_thread): Update help "tfaas" to mention supported
1973         options and install command completer.
1974
1975 2019-06-13  Pedro Alves  <palves@redhat.com>
1976
1977         * completer.c (complete_nested_command_line): New.
1978         (gdb_completion_word_break_characters_throw): Add assertion.
1979         * completer.h (complete_nested_command_line): Declare.
1980
1981 2019-06-13  Pedro Alves  <palves@redhat.com>
1982
1983         * stack.c (parse_backtrace_qualifiers): New.
1984         (backtrace_command): Use it.
1985         (backtrace_command_completer): Complete on qualifiers.
1986
1987 2019-06-13  Pedro Alves  <palves@redhat.com>
1988
1989         * frame.c: Include "cli/cli-option.h.
1990         (user_set_backtrace_options): New.
1991         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1992         Delete.
1993         (get_prev_frame): Adjust.
1994         (boolean_option_def, uinteger_option_def)
1995         (set_backtrace_option_defs): New.
1996         (_initialize_frame): Adjust and use
1997         gdb::option::add_setshow_cmds_for_options to install "set
1998         backtrace past-main" and "set backtrace past-entry".
1999         * frame.h: Include "cli/cli-option.h".
2000         (struct frame_print_options): Forward declare.
2001         (print_frame_arguments_all, print_frame_arguments_scalars)
2002         (print_frame_arguments_none): Declare.
2003         (print_entry_values): Delete declaration.
2004         (struct frame_print_options, user_frame_print_options): New.
2005         (struct set_backtrace_options): New.
2006         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2007         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2008         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2009         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2010         (list_args_or_locals): Add frame_print_options parameter.
2011         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2012         * python/py-framefilter.c (enumerate_args): Pass down
2013         USER_FRAME_PRINT_OPTIONS.
2014         * stack.c: Include "cli/cli-option.h".
2015         (print_frame_arguments_all, print_frame_arguments_scalars)
2016         (print_frame_arguments_none): Declare.
2017         (print_raw_frame_arguments, print_entry_values): Delete.
2018         (user_frame_print_options): New.
2019         (boolean_option_def, enum_option_def, frame_print_option_defs):
2020         New.
2021         (struct backtrace_cmd_options): New.
2022         (bt_flag_option_def): New.
2023         (backtrace_command_option_defs): New.
2024         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2025         (print_frame_arg, read_frame_arg, print_frame_args)
2026         (print_frame_info, print_frame): Add frame_print_options parameter
2027         and use it.
2028         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2029         (backtrace_command_1): Add frame_print_options and
2030         backtrace_cmd_options parameters and use them.
2031         (make_backtrace_options_def_group): New.
2032         (backtrace_command): Process command options with
2033         gdb::option::process_options.
2034         (backtrace_command_completer): New.
2035         (_initialize_stack): Extend "backtrace"'s help to mention
2036         supported options.  Install completer for "backtrace".
2037         Install some settings commands with add_setshow_cmds_for_options.
2038
2039 2019-06-13  Pedro Alves  <palves@redhat.com>
2040
2041         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2042         and that "set/show print raw frame-arguments" are now deprecated.
2043
2044         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2045         command.
2046         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2047         * stack.c (_initialize_stack): Install "set/show print
2048         raw-frame-arguments", and deprecate "set/show print raw
2049         frame-arguments".
2050         * valprint.c (_initialize_valprint): Deprecate "set/show print
2051         raw".
2052
2053 2019-06-13  Pedro Alves  <palves@redhat.com>
2054
2055         * compile/compile.c (struct compile_options): New.
2056         (compile_flag_option_def, compile_command_option_defs)
2057         (make_compile_options_def_group): New.
2058         (compile_file_command): Handle options with
2059         gdb::option::process_options.
2060         (compile_file_command_completer): New function.
2061         (compile_code_command): Handle options with
2062         gdb::option::process_options.
2063         (compile_code_command_completer): New function.
2064         (_initialize_compiler): Install completers for "compile code" and
2065         "compile file".  Mention available options in "compile code" and
2066         "compile code"'s help.
2067         * completer.c (advance_to_completion_word): New, factored out from
2068         ...
2069         (advance_to_expression_complete_word_point): ... this.
2070         (advance_to_filename_complete_word_point): New.
2071         * completer.h (advance_to_filename_complete_word_point): New
2072         declaration.
2073
2074 2019-06-13  Pedro Alves  <palves@redhat.com>
2075
2076         * compile/compile.c: Include "cli/cli-option.h".
2077         (compile_print_value): Scope data pointer is now a
2078         value_print_options pointer; adjust.
2079         (compile_print_command): Process options.  Scope data pointer is
2080         now a value_print_options pointer; adjust.
2081         (_initialize_compile): Update "compile print"'s help to include
2082         supported options.  Install a completer for "compile print".
2083         * cp-valprint.c (show_vtblprint, show_objectprint)
2084         (show_static_field_print): Delete.
2085         (_initialize_cp_valprint): Don't install "set print
2086         static-members", "set print vtbl", "set print object" here.
2087         * printcmd.c: Include "cli/cli-option.h" and
2088         "common/gdb_optional.h".
2089         (print_command_parse_format): Rework to fill in a
2090         value_print_options instead of a format_data.
2091         (print_value): Change parameter type from format_data pointer to
2092         value_print_options reference.  Adjust.
2093         (print_command_1): Process options.  Adjust to pass down a
2094         value_print_options.
2095         (print_command_completer): New.
2096         (_initialize_printcmd): Install print_command_completer as
2097         handle_brkchars completer for the "print" command.  Update
2098         "print"'s help to include supported options.
2099         * valprint.c: Include "cli/cli-option.h".
2100         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2101         here from cp-valprint.c.
2102         (boolean_option_def, uinteger_option_def)
2103         (value_print_option_defs, make_value_print_options_def_group):
2104         New.  Use gdb::option::add_setshow_cmds_for_options to install
2105         "set print elements", "set print null-stop", "set print repeats",
2106         "set print pretty", "set print union", "set print array", "set
2107         print address", "set print symbol", "set print array-indexes".
2108         * valprint.h: Include <string> and "cli/cli-option.h".
2109         (make_value_print_options_def_group): Declare.
2110         (print_value): Change parameter type from format_data pointer to
2111         value_print_options reference.
2112         (print_command_completer): Declare.
2113
2114 2019-06-13  Pedro Alves  <palves@redhat.com>
2115
2116         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2117         (COMMON_SFILES): Add maint-test-settings.c.
2118         * cli/cli-decode.c (boolean_enums): New global, factored out from
2119         ...
2120         (add_setshow_boolean_cmd): ... here.
2121         * cli/cli-decode.h (boolean_enums): Declare.
2122         * cli/cli-option.c: New file.
2123         * cli/cli-option.h: New file.
2124         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2125         factored out from ...
2126         (parse_cli_boolean_value(const char *)): ... this.
2127         (is_unlimited_literal): Change parameter type to pointer to
2128         pointer.  Adjust and advance ARG pointer.
2129         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2130         (parse_cli_var_enum): New, factored out from ...
2131         (do_set_command): ... this.  Adjust.
2132         * cli/cli-setshow.h (parse_cli_boolean_value)
2133         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2134         (parse_cli_var_enum): Declare.
2135         * cli/cli-utils.c: Include "cli/cli-option.h".
2136         (get_ulongest): New.
2137         * cli/cli-utils.h (get_ulongest): Declare.
2138         (check_for_argument): New overloads.
2139         * maint-test-options.c: New file.
2140
2141 2019-06-13  Pedro Alves  <palves@redhat.com>
2142
2143         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2144         parse a range if "-" is at the end of the string.
2145
2146 2019-06-13  Pedro Alves  <palves@redhat.com>
2147
2148         * cli/cli-setshow.c (parse_auto_binary_operation)
2149         (parse_cli_boolean_value): Don't allow "o".
2150
2151 2019-06-13  Pedro Alves  <palves@redhat.com>
2152
2153         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2154         * NEWS: Mention maint test-settings KIND.
2155         * maint-test-settings.c: New file.
2156
2157 2019-06-13  Pedro Alves  <palves@redhat.com>
2158
2159         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2160         completer.
2161         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2162         "set" completers.
2163
2164 2019-06-13  Pedro Alves  <palves@redhat.com>
2165
2166         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2167         after item.
2168
2169 2019-06-13  Pedro Alves  <palves@redhat.com>
2170
2171         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2172
2173 2019-06-13  Pedro Alves <palves@redhat.com>
2174
2175         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2176         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2177         call.
2178         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2179         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2180         calls.
2181         (check_for_argument): Skip spaces after argument.
2182
2183 2019-06-13  Pedro Alves  <palves@redhat.com>
2184
2185         * thread.c (thread_apply_command): Adjust TID parsing.
2186         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2187         detected before end of string.
2188         (tid_is_in_list): Error out if LIST is invalid.
2189
2190 2019-06-13  Pedro Alves  <palves@redhat.com>
2191
2192         * completer.c (complete_line_internal_1): Rewind completion word
2193         point.
2194         (completion_tracker::advance_custom_word_point_by): Change
2195         parameter type to int.
2196         * completer.h (completion_tracker::advance_custom_word_point_by):
2197         Likewise.
2198
2199 2019-06-13  Pedro Alves  <palves@redhat.com>
2200
2201         * completer.c (advance_to_completion_word): Handle delimiters.
2202
2203 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2204
2205         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2206
2207 2019-06-11  Tom Tromey  <tom@tromey.com>
2208
2209         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2210         (xmalloc_failed): Move to alloc.c.
2211         * alloc.c: New file.
2212         * Makefile.in (COMMON_SFILES): Add alloc.c.
2213
2214 2019-06-11  Tom Tromey  <tom@tromey.com>
2215
2216         * nat/linux-waitpid.c: Don't include server.h.
2217         (linux_debug): Remove.
2218         (my_waitpid): Update.
2219
2220 2019-06-11  Tom Tromey  <tromey@adacore.com>
2221
2222         * infcall.c (_initialize_infcall): Remove trailing newline from
2223         help.
2224         * user-regs.c (_initialize_user_regs): Remove trailing newline
2225         from help.
2226         * typeprint.c (_initialize_typeprint): Remove trailing newline
2227         from help.
2228         * reverse.c (_initialize_reverse): Remove trailing newlines from
2229         help.
2230         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2231         from help.
2232         * language.c (add_set_language_command): Remove trailing newline
2233         from help.
2234         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2235         help.
2236         * disasm.c (_initialize_disasm): Remove trailing newline from
2237         help.
2238         * top.c (init_main): Remove trailing newline from help.
2239         * interps.c (_initialize_interpreter): Remove trailing newline
2240         from help.
2241         * btrace.c (_initialize_btrace): Remove trailing newlines from
2242         help.
2243         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2244         from help.
2245         * python/python.c (_initialize_python): Remove trailing newline
2246         from help.
2247         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2248         help.
2249         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2250         from help.  Reformat some text.
2251         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2252         from help.
2253         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2254         newline from help.
2255
2256 2019-06-11  Tom Tromey  <tromey@adacore.com>
2257
2258         * darwin-nat.c (darwin_decode_exception_message)
2259         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2260
2261 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2262
2263         * valops.c (value_slice): Check for not allocated or not
2264         associated values.
2265
2266 2019-06-10  Tom de Vries  <tdevries@suse.de>
2267
2268         PR gdb/24618
2269         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2270         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2271         invalid.
2272
2273 2019-06-10  Tom de Vries  <tdevries@suse.de>
2274
2275         PR gdb/24611
2276         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2277         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2278
2279 2019-06-10  Tom de Vries  <tdevries@suse.de>
2280
2281         PR symtab/24545
2282         * symtab.c (struct demangled_name_entry): Add language field.
2283         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2284         static minimal symbol".  Set and use language field.
2285
2286 2019-06-10  Tom Tromey  <tromey@adacore.com>
2287
2288         * ada-lang.c (_initialize_ada_language): Update help text.
2289
2290 2019-06-10  Tom Tromey  <tromey@adacore.com>
2291
2292         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2293         with a newline.
2294         * guile/guile.c (handle_boot_error): Don't end warning with a
2295         newline.
2296         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2297         warning with a newline.
2298         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2299         newline.
2300         (s12z_frame_cache): Likewise.
2301         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2302         a newline.
2303         * solib-svr4.c (disable_probes_interface): Don't end warning with
2304         a newline.
2305         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2306         newline.
2307         * python/python.c (do_finish_initialization): Don't end warning
2308         with a newline.
2309
2310 2019-06-10  Tom Tromey  <tom@tromey.com>
2311
2312         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2313         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2314         gdbpy_enter.
2315
2316 2019-06-10  Tom Tromey  <tromey@adacore.com>
2317
2318         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2319         data.
2320         (elf_new_init): Don't call stabsread_new_init.
2321         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2322         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2323         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2324
2325 2019-06-10  Tom de Vries  <tdevries@suse.de>
2326
2327         PR symtab/16264
2328         PR symtab/24517
2329         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2330
2331 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2332
2333         * source.c (find_and_open_source): Also rewrite relative file
2334         names.
2335
2336 2019-04-26  Amos Bird  <amosbird@gmail.com>
2337
2338         * annotate.c (annotate_thread_exited): Add "thread-exited"
2339         annotation.
2340
2341 2019-06-06  Tom Tromey  <tromey@adacore.com>
2342
2343         * maint.h (class scoped_command_stats): Use
2344         DISABLE_COPY_AND_ASSIGN.
2345         <print_time>: New method.
2346         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2347         print_time.
2348         (scoped_command_stats::print_time): New method.
2349
2350 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2351
2352         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2353         instructions of lengths 6 or 8 bytes.
2354
2355 2019-06-04  Pedro Alves  <palves@redhat.com>
2356
2357         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2358
2359         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2360         * breakpoint.c (condition_completer): Likewise.
2361         * cli/cli-dump.c (scan_expression): Likewise.
2362         * common/filestuff.c (mkdir_recursive): Likewise.
2363         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2364         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2365         (gdb_abspath): Likewise.
2366         * compile/compile-cplus-types.c
2367         (compile_cplus_instance::decl_name): Likewise.
2368         * completer.c (complete_explicit_location):
2369         (signal_completer, reg_or_group_completer_1): Likewise.
2370         * cp-support.c (cp_remove_params_if_any): Likewise.
2371         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2372         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2373         * infcmd.c (strip_bg_char): Likewise.
2374         * linespec.c (copy_token_string): Likewise.
2375         * mi/mi-main.c (output_cores): Likewise.
2376         * psymtab.c (psymtab_search_name):
2377         * symfile.c (test_set_ext_lang_command): Likewise.
2378         * target.c (target_fileio_read_stralloc): Likewise.
2379         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2380         * value.c (complete_internalvar): Likewise.
2381
2382 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2383
2384         Add objfile property to gdb.Type.
2385         * NEWS: Mention Python API addition.
2386         * python/py-type.c (typy_get_objfile): New method.
2387
2388 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2389
2390         * NEWS: Mention the new set|show style [title|highlight].
2391         Mention changes to "show style", "help" and "apropos".
2392
2393 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2394
2395         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2396         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2397         instead of print_help_for_command.
2398         (print_doc_of_command): New function.
2399         (help_list): Add 'apropos -v word' suggestion.
2400         (print_help_for_command): Style the command name using title style.
2401         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2402         (_initialize_cli_cmds): Describe -v in apropos_command help.
2403
2404 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2405
2406         * cli/cli-style.h (cli_style_option): Add name in constructor,
2407         add m_name class member, add constructor with intensity,
2408         add name class function.
2409         (cli_style_option::add_setshow_commands): Remove name argument.
2410         (highlight_style, title_style): New styles.
2411         * cli/cli-style.c (do_show): New function that shows a style
2412         characteristic styling the style name with itself.
2413         (set_style_name): New function.
2414         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2415         Update all callers according to the changes in cli/cli-style.h.
2416         * utils.h (fputs_highlighted): New function.
2417         * utils.c (fputs_highlighted): Likewise.
2418
2419 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2420
2421         * NEWS: Mention new pipe command and new convenience variables.
2422
2423 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2424
2425         * cli/cli-cmds.c (pipe_command): New function.
2426         (_initialize_cli_cmds): Call add_com for pipe_command.
2427         Define | as an alias for pipe.
2428         (exit_status_set_internal_vars): New function.
2429         (shell_escape): Call exit_status_set_internal_vars.
2430         cli/cli-decode.c (find_command_name_length): Recognize | as
2431         a single character command.
2432
2433 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2434
2435         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2436         top.c (execute_command_to_ui_file): New function, mostly a copy
2437         of execute_command_to_string.
2438         (execute_command_to_string): Implement by calling
2439         execute_command_to_ui_file.
2440
2441 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2442
2443         * top.h (saved_command_line): Remove declaration.
2444         * top.c (previous_saved_command_line, previous_repeat_arguments):
2445         New variables.
2446         (saved_command_line): Make static, define together with other
2447         'repeat variables'.
2448         (dont_repeat): Clear repeat_arguments.
2449         (repeat_previous, get_saved_command_line, save_command_line):
2450         New functions.
2451         (gdb_init): Initialize saved_command_line
2452         and previous_saved_command_line.
2453         * main.c (captured_main_1): Remove saved_command_line initialization.
2454         * event-top.c (handle_line_of_input): Update to use
2455         the new 'repeat' related functions instead of direct access to
2456         saved_command_line.
2457         * command.h (repeat_previous, get_saved_command_line,
2458         save_command_line): New declarations.
2459         (dont_repeat): Add comment.
2460
2461 2019-05-30  Tom Tromey  <tromey@adacore.com>
2462
2463         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2464         Fix comment.
2465         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2466
2467 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2468
2469         PR cli/24587
2470         * completer.c (complete): Initialize variable word.
2471
2472 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2473
2474         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2475         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2476         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2477         'body' is NULL to the outter 'if', protecting the '!is_define'
2478         situation as well.
2479
2480 2019-05-29  Tom Tromey  <tromey@adacore.com>
2481
2482         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2483         (dwarf_unknown): New function.
2484         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2485         (dwarf_type_encoding_name): Use dwarf_unknown.
2486
2487 2019-05-29  Tom Tromey  <tromey@adacore.com>
2488
2489         PR c++/20020:
2490         * cp-valprint.c (cp_print_value_fields): Call
2491         cp_print_static_field inside "try".
2492
2493 2019-05-29  Tom Tromey  <tromey@adacore.com>
2494
2495         * inflow.c (struct terminal_info): Add default operator=.
2496         * configure: Rebuild.
2497         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2498         -Wdeprecated-copy-dtor, -Wredundant-move.
2499
2500 2019-05-29  Tom Tromey  <tromey@adacore.com>
2501
2502         * NEWS: Add entry.
2503         * infcmd.c (print_return_value_1): Handle finish_print
2504         option.
2505         (show_print_finish): New function.
2506         (_initialize_infcmd): Add "set/show print finish" commands.
2507         * valprint.c (user_print_options): Initialize new member.
2508         * valprint.h (struct value_print_options) <finish_print>: New
2509         member.
2510
2511 2019-05-28  Tom Tromey  <tromey@adacore.com>
2512
2513         * ada-lang.c (ada_remove_Xbn_suffix)
2514         (find_old_style_renaming_symbol)
2515         (parse_old_style_renaming): Remove.
2516         (ada_find_renaming_symbol): Don't call
2517         find_old_style_renaming_symbol.
2518         (ada_is_renaming_symbol): Rename from
2519         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2520         bool.  Now static.
2521         (ada_read_var_value): Update and simplify.
2522         * ada-exp.y (write_var_or_type): Remove old code.
2523
2524 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2525
2526         * event-top.c: Remove include comment.
2527         * inflow.c (class scoped_ignore_sigttou): Move from here...
2528         * inflow.h (class scoped_ignore_sigttou): ...to here.
2529         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2530         * top.c:  Remove include comment.
2531
2532 2019-05-27  Tom Tromey  <tom@tromey.com>
2533
2534         * NEWS: Fix typo.
2535
2536 2019-05-22  Tom Tromey  <tromey@adacore.com>
2537
2538         * target.c (target_follow_exec): Constify parameter.
2539         * target-delegates.c: Rebuild.
2540         * remote.c (remote_target::follow_exec): Constify parameter.
2541         * infrun.c (follow_exec): Constify parameter.
2542         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2543         (target_follow_exec): Likewise.
2544
2545 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2546
2547         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2548         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2549
2550 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2551
2552         * NEWS: Add debugredirect and testsuite sections.
2553
2554 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2555
2556         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2557         target descriptions using exclusively floating point register name
2558         aliases.
2559
2560 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2561
2562         PR gdb/18644:
2563         * f-lang.c (build_fortran_types): Handle the case where
2564         gdbarch_floatformat_for_type returns a nullptr.
2565
2566 2019-05-21  Tom de Vries  <tdevries@suse.de>
2567
2568         PR cli/24587
2569         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2570
2571 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2572
2573         PR gdb/18644:
2574         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2575         16-byte floats.
2576         * i386-tdep.c (i386_floatformat_for_type): Use
2577         floatformats_ia64_quad for the 16-byte floating point component
2578         within a fortran 32-byte complex number.
2579
2580 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2581
2582         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2583         delete default constructor.
2584         (find_partial_die): Update to return const struct.
2585         (partial_die_parent_scope): Move variable declaration into scope
2586         of its use and change its type to auto.
2587         (guess_partial_die_structure_name): Likewise.
2588         (partial_die_info::fixup): Likewise.
2589
2590 2019-05-17  Tom Tromey  <tromey@adacore.com>
2591
2592         * source.c (find_and_open_source): Remove cast.
2593
2594 2019-05-17  Tom Tromey  <tromey@adacore.com>
2595
2596         * annotate.c (annotate_source): Make "filename" const.
2597         * annotate.h (annotate_source): Use const.
2598
2599 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2600
2601         * disasm.c (set_disassembler_options): Send errors to stderr.
2602
2603 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2604
2605         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2606         (cli_interp_base::set_logging): Check debug_redirect.
2607         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2608         * cli/cli-logging.c (debug_redirect): Add static variable.
2609         (pop_output_files): Add default param.
2610         (handle_redirections): Print debug setting.
2611         (show_logging_command): Likewise.
2612         (_initialize_cli_logging): Add debugredirect command.
2613         * interps.c (current_interp_set_logging): Add debug_redirect
2614         parameter.
2615         * interps.h (set_logging): Add debug_redirect parameter.
2616         (current_interp_set_logging): Likewise.
2617         * mi/mi-common.h: Likewise.
2618         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2619
2620 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2621             Tom Tromey  <tromey@adacore.com>
2622
2623         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2624         directly.
2625         * cli/cli-interp.h (make_logging_output): Remove declaration.
2626         * cli/cli-logging.c (make_logging_output): Remove function.
2627         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2628         directly.
2629         * ui-file.c (tee_file::tee_file): Remove bools.
2630         (tee_file::~tee_file): Remove deletes.
2631         * ui-file.h (tee_file): Remove bools.
2632
2633 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2634
2635         * mi/mi-cmds.h (mi_cmd_complete): New function.
2636         * mi/mi-main.c (mi_cmd_complete): Likewise.
2637         * mi/mi-cmds.c: Define new MI command -complete.
2638         * NEWS: Mention new -complete command.
2639
2640 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2641
2642         * completer.h (complete): New function.
2643         * completer.c (complete): Likewise.
2644         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2645         function defined in completer.h.
2646
2647 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2648
2649         * MAINTAINERS (Write After Approval): Add myself.
2650
2651 2019-05-17  Tom de Vries  <tdevries@suse.de>
2652
2653         PR gdb/24094
2654         * dwarf2read.c (struct cu_partial_die_info): New struct.
2655         (find_partial_die): Return cu_partial_die_info.
2656         (partial_die_parent_scope, guess_partial_die_structure_name)
2657         (partial_die_info::fixup): Handle new return type of find_partial_die.
2658
2659 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2660
2661         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2662         "std::string", simplifying the algorithm.
2663
2664 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2665
2666         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2667         (stap_static_probe_ops::get_probes): Likewise.
2668
2669 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2670
2671         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2672         '-')" and "else if".
2673         (stap_parse_single_operand): Join checks for
2674         "gdbarch_stap_parse_special_token_p" and
2675         "gdbarch_stap_parse_special_token" in the same "if" statement.
2676         Invert check when verifying for operation on register
2677         displacement.
2678
2679 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2680
2681         * stap-probe.c (stap_get_opcode): Update comment.
2682         (stap_get_expected_argument_type): Likewise.
2683         (handle_stap_probe): Likewise.
2684
2685 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2686
2687         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2688         return type to 'bool'.  Adjust comment.  Use 'bool' when
2689         appropriate.
2690         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2691         * stap-probe.c (stap_parse_argument_1): Likewise.
2692         (stap_is_operator): Likewise.
2693         (stap_is_generic_prefix): Likewise.
2694         (stap_is_register_prefix): Likewise.
2695         (stap_is_register_indirection_prefix): Likewise.
2696         (stap_is_integer_prefix): Likewise.
2697         (stap_generic_check_suffix): Likewise.
2698         (stap_check_integer_suffix): Likewise.
2699         (stap_check_register_suffix): Likewise.
2700         (stap_check_register_indirection_suffix): Likewise.
2701         (stap_parse_register_operand): Likewise.
2702         (stap_parse_single_operand): Likewise.
2703         (stap_parse_argument_1): Likewise.
2704         (stap_probe::get_argument_count): Likewise.
2705         (stap_is_operator): Likewise.
2706
2707 2019-05-16  Tom Tromey  <tromey@adacore.com>
2708
2709         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2710         keyword to foreach.
2711
2712 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2713
2714         * linux-thread-db.c (try_thread_db_load_1): Change return type
2715         to bool.
2716         (try_thread_db_load): Likewise.
2717         (try_thread_db_load_from_pdir_1): Likewise.
2718         (try_thread_db_load_from_pdir): Likewise.
2719         (try_thread_db_load_from_sdir): Likewise.
2720         (try_thread_db_load_from_dir): Likewise.
2721         (thread_db_load_search): Likewise.
2722         (has_libpthread): Likewise.
2723         (thread_db_load): Likewise.
2724
2725 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2726
2727         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2728         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2729         NULL, and complain/return if that's the case.
2730
2731 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2732
2733         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2734         (advance, posn, abstract_read_memory): New functions.
2735         [struct mem_read_abstraction]: New struct.
2736         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2737
2738 2019-05-14  Tom Tromey  <tromey@adacore.com>
2739
2740         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2741         value is not lval_memory.
2742
2743 2019-05-14  Tom Tromey  <tromey@adacore.com>
2744
2745         * solib.c (info_sharedlibrary_command): Style the file name.
2746
2747 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2748
2749         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2750         (aarch64_vnv_type): Likewise.
2751         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2752         * common/tdesc.c: Likewise.
2753         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2754         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2755         * features/aarch64-fpu.xml: Add ieee half view.
2756         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2757         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2758         * gdbtypes.h (struct builtin_type): Likewise.
2759         (struct objfile_type): Likewise.
2760
2761 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2762
2763         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2764         typo.
2765         * location.h (string_to_event_location): Likewise.
2766
2767 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2768
2769         GDB 8.3 released.
2770
2771 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2772
2773         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2774         New variable declaration.
2775         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2776         New variable.
2777         (print_one_breakpoint): Use ui_out::test_flags and new global
2778         variable to compute use_fixed_output.
2779         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2780         Remove.
2781         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2782         (mi_multi_location_breakpoint_output_fixed): Remove.
2783         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2784         new variable.
2785         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2786         fix_multi_location_breakpoint_output flag if version >= 3.
2787         * ui-out.h (enum ui_out_flag)
2788         <fix_multi_location_breakpoint_output>: New enumerator.
2789
2790 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2791
2792         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2793
2794 2019-05-10  Tom Tromey  <tromey@adacore.com>
2795
2796         * ada-lang.c (catch_ada_completer): New function.
2797         (_initialize_ada_language): Use it.
2798
2799 2019-05-10  Tom Tromey  <tromey@adacore.com>
2800
2801         * thread.c (print_thread_info): Make "requested_threads" const.
2802         * gdbthread.h (print_thread_info): Make "requested_threads"
2803         const.
2804         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2805         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2806
2807 2019-05-08  Tom Tromey  <tom@tromey.com>
2808
2809         * gdbtypes.c (objfile_type_data): Change type.
2810         (objfile_type, _initialize_gdbtypes): Update.
2811
2812 2019-05-08  Tom Tromey  <tom@tromey.com>
2813
2814         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2815         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2816         (_initialize_dwarf2_frame): Update.
2817
2818 2019-05-08  Tom Tromey  <tom@tromey.com>
2819
2820         * objc-lang.c (objc_objfile_data): Change type.
2821         (find_methods): Update.
2822         (_initialize_objc_lang): Remove.
2823
2824 2019-05-08  Tom Tromey  <tom@tromey.com>
2825
2826         * stabsread.c (rs6000_builtin_type_data): Change type.
2827         (rs6000_builtin_type, _initialize_stabsread): Update.
2828
2829 2019-05-08  Tom Tromey  <tom@tromey.com>
2830
2831         * mips-tdep.c (mips_pdr_data): Remove.
2832         (_initialize_mips_tdep): Update.
2833
2834 2019-05-08  Tom Tromey  <tom@tromey.com>
2835
2836         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2837         (hppa_init_objfile_priv_data, read_unwind_info)
2838         (find_unwind_entry, _initialize_hppa_tdep): Update.
2839
2840 2019-05-08  Tom Tromey  <tom@tromey.com>
2841
2842         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2843         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2844         on obstack.
2845         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2846
2847 2019-05-08  Tom Tromey  <tom@tromey.com>
2848
2849         * mdebugread.c (basic_type_data): Change type.
2850         (basic_type, _initialize_mdebugread): Update.
2851
2852 2019-05-08  Tom Tromey  <tom@tromey.com>
2853
2854         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2855
2856 2019-05-08  Tom Tromey  <tom@tromey.com>
2857
2858         * nto-tdep.c (nto_inferior_data_reg): Change type.
2859         (nto_inferior_data): Update.
2860         (nto_inferior_data_cleanup, nto_new_inferior_data)
2861         (_initialize_nto_tdep): Remove.
2862         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2863
2864 2019-05-08  Tom Tromey  <tom@tromey.com>
2865
2866         * ada-lang.c (struct ada_inferior_data): Add initializers.
2867         (ada_inferior_data): Change type.
2868         (ada_inferior_data_cleanup): Remove.
2869         (get_ada_inferior_data, ada_inferior_exit)
2870         (struct ada_pspace_data): Add initializers, destructor.
2871         (ada_pspace_data_handle): Change type.
2872         (get_ada_pspace_data): Update.
2873         (ada_pspace_data_cleanup): Remove.
2874
2875 2019-05-08  Tom Tromey  <tom@tromey.com>
2876
2877         * coffread.c (struct coff_symfile_info): Add initializers.
2878         (coff_objfile_data_key): Move lower.  Change type.
2879         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2880         Update.
2881         (coff_free_info): Remove.
2882
2883 2019-05-08  Tom Tromey  <tom@tromey.com>
2884
2885         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2886         (fbsd_pspace_data_handle): Move lower.  Change type.
2887         (get_fbsd_pspace_data): Update.
2888         (fbsd_pspace_data_cleanup): Remove.
2889         (_initialize_fbsd_tdep): Update.
2890
2891 2019-05-08  Tom Tromey  <tom@tromey.com>
2892
2893         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2894         (get_ada_tasks_pspace_data): Update.
2895         (ada_tasks_pspace_data_cleanup): Remove.
2896         (_initialize_tasks): Update.
2897         (ada_tasks_inferior_data_handle): Change type.
2898         (get_ada_tasks_inferior_data): Update.
2899         (ada_tasks_inferior_data_cleanup): Remove.
2900         (struct ada_tasks_pspace_data): Add initializers.
2901
2902 2019-05-08  Tom Tromey  <tom@tromey.com>
2903
2904         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2905         * symfile-debug.c (debug_sym_get_probes): Change type.
2906         * stap-probe.c (handle_stap_probe):
2907         (stap_static_probe_ops::get_probes): Change type.
2908         * probe.h (class static_probe_ops) <get_probes>: Change type.
2909         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2910         (parse_probes_in_pspace): Update.
2911         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2912         Update.
2913         (any_static_probe_ops::get_probes): Change type.
2914         * elfread.c (elfread_data): New typedef.
2915         (probe_key): Change type.
2916         (elf_get_probes): Likewise.  Update.
2917         (probe_key_free): Remove.
2918         (_initialize_elfread): Update.
2919         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2920         Change type.
2921         (dtrace_process_dof_probe, dtrace_process_dof)
2922         (dtrace_static_probe_ops::get_probe): Change type.
2923
2924 2019-05-08  Tom Tromey  <tom@tromey.com>
2925
2926         * xcoffread.c (struct xcoff_symfile_info): Rename from
2927         coff_symfile_info.  Add initializers.
2928         (xcoff_objfile_data_key): Move lower.  Change type.
2929         (XCOFF_DATA): Rewrite.
2930         (xcoff_free_info): Remove.
2931         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2932         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2933         (xcoff_initial_scan): Update.
2934
2935 2019-05-08  Tom Tromey  <tom@tromey.com>
2936
2937         * solib-svr4.c (struct svr4_info): Add initializers and
2938         destructor.
2939         <probes_table>: Now an htab_up.
2940         (solib_svr4_pspace_data): Change type.
2941         (free_probes_table): Simplify.
2942         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2943         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2944         (probes_table_remove_objfile_probes, register_solib_event_probe)
2945         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2946         (_initialize_svr4_solib): Update.
2947
2948 2019-05-08  Tom Tromey  <tom@tromey.com>
2949
2950         * remote.c (remote_pspace_data): Change type.
2951         (remote_pspace_data_cleanup): Remove.
2952         (get_remote_exec_file, set_pspace_remote_exec_file)
2953         (_initialize_remote): Update.
2954
2955 2019-05-08  Tom Tromey  <tom@tromey.com>
2956
2957         * breakpoint.c (breakpoint_objfile_key): Change type.
2958         (get_breakpoint_objfile_data): Update.
2959         (free_breakpoint_objfile_data): Remove.
2960         (_initialize_breakpoint): Update.
2961
2962 2019-05-08  Tom Tromey  <tom@tromey.com>
2963
2964         * linux-tdep.c (struct linux_info): Add initializers.
2965         (linux_inferior_data): Move.  Change type.
2966         (invalidate_linux_cache_inf): Update.
2967         (linux_inferior_data_cleanup): Remove.
2968         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2969
2970 2019-05-08  Tom Tromey  <tom@tromey.com>
2971
2972         * auxv.c (auxv_inferior_data): Move.  Change type.
2973         (auxv_inferior_data_cleanup): Remove.
2974         (invalidate_auxv_cache_inf): Rewrite.
2975         (get_auxv_inferior_data, _initialize_auxv): Update.
2976
2977 2019-05-08  Tom Tromey  <tom@tromey.com>
2978
2979         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2980         (symfile_debug_objfile_data_key): Change type.
2981         (symfile_debug_installed, debug_qf_has_symbols)
2982         (debug_qf_find_last_source_symtab)
2983         (debug_qf_forget_cached_source_info)
2984         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2985         (debug_qf_print_stats, debug_qf_dump)
2986         (debug_qf_expand_symtabs_for_function)
2987         (debug_qf_expand_all_symtabs)
2988         (debug_qf_expand_symtabs_with_fullname)
2989         (debug_qf_map_matching_symbols)
2990         (debug_qf_expand_symtabs_matching)
2991         (debug_qf_find_pc_sect_compunit_symtab)
2992         (debug_qf_map_symbol_filenames)
2993         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2994         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2995         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2996         (debug_sym_read_linetable, debug_sym_relocate): Update.
2997         (symfile_debug_free_objfile): Remove.
2998         (install_symfile_debug_logging, _initialize_symfile_debug):
2999         Update.
3000
3001 2019-05-08  Tom Tromey  <tom@tromey.com>
3002
3003         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3004         allocate_on_obstack.
3005         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3006         (get_dwarf2_per_objfile): Update.
3007         (set_dwarf2_per_objfile): Remove.
3008         (dwarf2_has_info, dwarf2_get_section_info): Update.
3009         (dwarf2_free_objfile): Remove.
3010         (_initialize_dwarf2_read): Update.
3011
3012 2019-05-08  Tom Tromey  <tom@tromey.com>
3013
3014         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3015         initializers.
3016         <unsupported_script_warning_printed,
3017         script_not_found_warning_printed>: Now bool.
3018         (auto_load_pspace_data): Change type.
3019         (~auto_load_pspace_info): Rename from
3020         auto_load_pspace_data_cleanup.
3021         (get_auto_load_pspace_data, init_loaded_scripts_info)
3022         (clear_section_scripts, maybe_print_unsupported_script_warning)
3023         (maybe_print_script_not_found_warning, _initialize_auto_load):
3024         Update.
3025
3026 2019-05-08  Tom Tromey  <tom@tromey.com>
3027
3028         * objfiles.c (objfile_pspace_info): Add destructor and
3029         initializers.
3030         (objfiles_pspace_data): Change type.
3031         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3032         (get_objfile_pspace_data): Update.
3033         (objfiles_bfd_data): Change type.
3034         (get_objfile_bfd_data): Update.
3035         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3036
3037 2019-05-08  Tom Tromey  <tom@tromey.com>
3038
3039         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3040         Change type.
3041         (get_catch_syscall_inferior_data): Update.
3042         (catch_syscall_inferior_data_cleanup): Remove.
3043         (_initialize_break_catch_syscall): Update.
3044
3045 2019-05-08  Tom Tromey  <tom@tromey.com>
3046
3047         * inflow.c (struct terminal_info): Add destructor and
3048         initializers.
3049         (inflow_inferior_data): Change type.
3050         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3051         (get_inflow_inferior_data, inflow_inferior_exit)
3052         (swap_terminal_info, _initialize_inflow): Update.
3053
3054 2019-05-08  Tom Tromey  <tom@tromey.com>
3055
3056         * target-dcache.c (target_dcache_cleanup): Remove.
3057         (target_dcache_aspace_key): Change type.
3058         (target_dcache_init_p, target_dcache_invalidate)
3059         (target_dcache_get, target_dcache_get_or_init)
3060         (_initialize_target_dcache): Update.
3061         * dcache.h (struct dcache_deleter): New.
3062
3063 2019-05-08  Tom Tromey  <tom@tromey.com>
3064
3065         * symtab.c (struct symbol_cache): Add destructor and
3066         initializers.
3067         (symbol_cache_key): Move.  Change type.
3068         (make_symbol_cache, free_symbol_cache): Remove.
3069         (get_symbol_cache): Update.
3070         (symbol_cache_cleanup): Remove.
3071         (ALL_PSPACES, symbol_cache_flush)
3072         (maintenance_print_symbol_cache)
3073         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3074         Update.
3075
3076 2019-05-08  Tom Tromey  <tom@tromey.com>
3077
3078         * symtab.c (struct main_info): Add destructor and initializers.
3079         (main_progspace_key): Move.  Change type.
3080         (get_main_info): Update.
3081         (main_info_cleanup): Remove.
3082         (_initialize_symtab): Update.
3083
3084 2019-05-08  Tom Tromey  <tom@tromey.com>
3085
3086         * registry.h (DECLARE_REGISTRY): Define the _key class.
3087
3088 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3089
3090         * NEWS: Merge two 'New commands' sections.
3091
3092 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3093
3094         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3095         parameter and use Ada language definition instead.
3096         (ada_val_print_ptr): Remove unused language parameter.
3097         (ada_val_print_num): Remove language parameter and use Ada language
3098         definition instead.
3099         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3100         parameter.
3101         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3102         parameter and use Ada language definition instead.
3103         (ada_val_print_1): Update all ada_val_print_xxx calls.
3104         Remove language parameter.
3105         (ada_val_print): Update ada_val_print_1 call.
3106
3107 2019-05-08  Tom Tromey  <tromey@adacore.com>
3108
3109         * remote.c (remote_hw_watchpoint_limit)
3110         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3111         Now static.
3112
3113 2019-05-08  Tom Tromey  <tromey@adacore.com>
3114
3115         * maint.c (_initialize_maint_cmds): Move initialization code to
3116         remote.c.
3117         (watchdog, show_watchdog): Move to remote.c.
3118         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3119         "watchdog" static.
3120         (_initialize_remote): Move initialization code from maint.c.
3121         * defs.h (watchdog): Don't declare.
3122
3123 2019-05-08  Tom Tromey  <tromey@adacore.com>
3124
3125         * tui/tui-interp.c: Include main.h.
3126         * interps.c: Include main.h.
3127         * main.h (interpreter_p): Declare.
3128         * defs.h (interpreter_p): Don't declare.
3129
3130 2019-05-08  Tom Tromey  <tromey@adacore.com>
3131
3132         * dwarf2loc.c: Include dwarf2read.h.
3133         * defs.h (read_unsigned_leb128): Don't declare.
3134         * dwarf2read.h (read_unsigned_leb128): Declare.
3135
3136 2019-05-08  Tom Tromey  <tromey@adacore.com>
3137
3138         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3139         method.
3140
3141 2019-05-08  Tom Tromey  <tromey@adacore.com>
3142
3143         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3144         when no wrap column is set.
3145
3146 2019-05-08  Tom Tromey  <tromey@adacore.com>
3147
3148         * c-lang.c (c_get_string): Handle non-C-style arrays.
3149
3150 2019-05-08  Tom Tromey  <tromey@adacore.com>
3151
3152         * typeprint.c (print_offset_data::update): Print the bit offset,
3153         not the number of bits remaining.
3154
3155 2019-05-08  Tom Tromey  <tromey@adacore.com>
3156
3157         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3158         padding at end of comment.
3159
3160 2019-05-08  Tom Tromey  <tromey@adacore.com>
3161
3162         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3163         Compare main types.
3164
3165 2019-05-06  Tom Tromey  <tom@tromey.com>
3166
3167         * common/scoped_mmap.c: Include common-defs.h.
3168         * common/scoped_mmap.h: Don't include config.h.
3169
3170 2019-05-04  Tom Tromey  <tom@tromey.com>
3171
3172         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3173         (struct aarch64_call_info): Add initializers.
3174         <si>: Now a std::vector.
3175         (pass_on_stack, aarch64_push_dummy_call): Update.
3176
3177 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3178             Tom Tromey  <tom@tromey.com>
3179
3180         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3181         (ppc_threads): Now a std::vector.  Now static.
3182         (hwdebug_find_thread_points_by_tid)
3183         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3184         Update.
3185
3186 2019-05-04  Tom Tromey  <tom@tromey.com>
3187
3188         * arc-tdep.c (arc_tdesc_init): Return bool.
3189
3190 2019-05-04  Tom Tromey  <tom@tromey.com>
3191
3192         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3193         Use gdb_assert_not_reached.
3194
3195 2019-05-04  Tom Tromey  <tom@tromey.com>
3196
3197         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3198         "false".
3199
3200 2019-05-04  Tom Tromey  <tom@tromey.com>
3201
3202         * arc-tdep.c (arc_tdesc_init): Use bool.
3203
3204 2019-05-04  Tom Tromey  <tom@tromey.com>
3205
3206         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3207
3208 2019-05-04  Tom Tromey  <tom@tromey.com>
3209
3210         * cli/cli-cmds.c (valid_command_p): Return bool.
3211
3212 2019-05-04  Tom Tromey  <tom@tromey.com>
3213
3214         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3215         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3216
3217 2019-05-04  Raul Tambre  <raul@tambre.ee>
3218
3219         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3220         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3221         operator for comparison.
3222
3223 2019-05-04  Tom Tromey  <tom@tromey.com>
3224
3225         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3226         (lookup_partial_symbol, print_partial_symbols)
3227         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3228         (psymbol_compare): Update.
3229         (add_psymbol_to_bcache): Clear the entire psymbol.
3230         (maintenance_check_psymtabs): Update.
3231         * psympriv.h (struct partial_symbol): Don't derive from
3232         general_symbol_info.
3233         <obj_section, unrelocated_address, address,
3234         set_unrelocated_address>: Update.
3235         <ginfo>: New member.
3236         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3237         (debug_names::write_psymbols): Update.
3238
3239 2019-05-04  Tom de Vries  <tdevries@suse.de>
3240
3241         * contrib/cc-with-tweaks.sh: Support -n arg.
3242
3243 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3244
3245         * corelow.c (core_target::detach): Ensure frame cache and
3246         register caches are cleared.
3247         inferior.c (exit_inferior_1): Likewise.
3248
3249 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3250             Tom Tromey  <tom@tromey.com>
3251
3252         * dictionary.c (collate_pending_symbols_by_language): Remove
3253         "struct" from foreach.
3254         * symtab.c (lookup_global_symbol_from_objfile)
3255         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3256         foreach.
3257         * ser-tcp.c (net_open): Remove "struct" from foreach.
3258         * objfiles.c (objfile_relocate, objfile_rebase)
3259         (objfile_has_symbols): Remove "struct" from foreach.
3260         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3261         from foreach.
3262         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3263         foreach.
3264         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3265         "struct" from foreach.
3266         * ada-lang.c (create_excep_cond_exprs)
3267         (ada_exception_catchpoint_cond_string): Remove "struct" from
3268         foreach.
3269
3270 2019-05-03  Tom Tromey  <tromey@adacore.com>
3271
3272         * ada-exp.y (convert_char_literal): Check suffix of each
3273         enumerator.
3274
3275 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3276
3277         PR ada/21406:
3278         * ada-exp.y (yywrap): Don't define.
3279         * ada-lex.l (%option): Add noyywrap
3280         (yywrap): Remove.
3281
3282 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3283
3284         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3285         _WIN32_WINNT to the XP level, unless already defined to a higher
3286         level.
3287
3288         * unittests/parse-connection-spec-selftests.c:
3289         * ser-tcp.c:
3290         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3291         override.
3292
3293         * symfile.c (find_separate_debug_file): Remove colon from the
3294         drive spec of DOS/Windows file names of the target, so that the
3295         file name produced from DEBUGDIR and the target's directory will
3296         be valid on DOS/Windows systems.
3297
3298 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3299
3300         * rust-lang.c (val_print_struct): Handle printing structures
3301         containing strings.
3302
3303 2019-05-02  Tom Tromey  <tromey@adacore.com>
3304
3305         * valarith.c (_initialize_valarith): Remove.
3306
3307 2019-05-01  Tom Tromey  <tromey@adacore.com>
3308
3309         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3310         bitfields.
3311
3312 2019-05-01  Tom Tromey  <tromey@adacore.com>
3313
3314         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3315         for big-endian copies.
3316
3317 2019-04-30  Ali Tamur  <tamur@google.com>
3318         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3319         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3320         (read_3_bytes): New function.
3321
3322 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3323
3324         * windows-nat.c (main_thread_id): Delete.
3325         (handle_output_debug_string): Replace main_thread_id by
3326         current_event.dwThreadId.
3327         (fake_create_process): Likewise.
3328         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3329         Do not set main_thread_id.
3330         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3331         current_event.dwThreadId.
3332         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3333
3334 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3335
3336         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3337         Use current_event.dwThreadId instead of main_thread_id.
3338
3339 2019-04-30  Tom Tromey  <tromey@adacore.com>
3340
3341         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3342         (create_excep_cond_exprs): Iterate over program spaces.
3343         (ada_exception_catchpoint_cond_string): Examine all minimal
3344         symbols for exception types.
3345
3346 2019-04-30  Tom Tromey  <tromey@adacore.com>
3347
3348         PR c++/24470:
3349         * dwarf2read.c (process_structure_scope): Handle case where type
3350         has template parameters but no symbol was created.
3351
3352 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3353             Chris January  <chris.january@arm.com>
3354
3355         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3356         qualifier.
3357         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3358
3359 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3360
3361         * f-typeprint.c (f_print_type): Update rules for printing
3362         whitespace.
3363         (f_type_print_varspec_suffix): Likewise.
3364
3365 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3366             Chris January  <chris.january@arm.com>
3367
3368         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3369         function arguments.
3370
3371 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3372
3373         * f-lang.c (build_fortran_types): Change name of void type to
3374         lower case.
3375         * f-typeprint.c (f_type_print_base): Print the name of the void
3376         type, rather than a fixed string.
3377         * f-valprint.c (f_decorations): Use lower case void string.
3378
3379 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3380             Chris January  <chris.january@arm.com>
3381
3382         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3383         types for Fortran.
3384
3385 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3386             Chris January  <chris.january@arm.com>
3387             David Lecomber  <david.lecomber@arm.com>
3388
3389         * f-exp.y (BINOP_INTRINSIC): New token.
3390         (exp): New parser rule handling BINOP_INTRINSIC.
3391         (f77_keywords): Add new builtin procedures.
3392         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3393         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3394         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3395         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3396         (print_unop_subexp_f): New function.
3397         (print_binop_subexp_f): New function.
3398         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3399         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3400         (dump_subexp_body_f): Likewise.
3401         (operator_check_f): Likewise.
3402         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3403         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3404
3405 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3406
3407         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3408         UNOP_KIND.
3409         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3410         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3411         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3412         (operator_length_f): New fuction.
3413         (print_subexp_f): New function.
3414         (op_name_f): New function.
3415         (dump_subexp_body_f): New function.
3416         (operator_check_f): New function.
3417         (exp_descriptor_f): Replace standard expression handling functions
3418         with new functions.
3419         * gdb/fortran-operator.def: New file.
3420         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3421         * gdb/std-operator.def: Remove UNOP_KIND.
3422
3423 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3424
3425         * std-operator.def: Remove unbalanced, stray double quote
3426         character.
3427
3428 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3429             Chris January  <chris.january@arm.com>
3430             Daniel Everett  <daniel.everett@arm.com>
3431             Nick Forrington  <nick.forrington@arm.com>
3432             Richard Bunt  <richard.bunt@arm.com>
3433
3434         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3435         of depth when printing anonymous structs or unions.
3436         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3437         Don't print either the top-level value, or the children if the
3438         max-depth is exceeded.
3439         (ppscm_print_children): When printing the key of a map, allow one
3440         extra level of depth.
3441         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3442         print either the top-level value, or the children if the max-depth
3443         is exceeded.
3444         (print_children): When printing the key of a map, allow one extra
3445         level of depth.
3446         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3447         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3448         (user_print_options): Initialise max_depth field.
3449         (val_print_scalar_or_string_type_p): New function.
3450         (val_print): Check to see if the max depth has been reached.
3451         (val_print_check_max_depth): Define new function.
3452         (show_print_max_depth): New function.
3453         (_initialize_valprint): Add 'print max-depth' option.
3454         * valprint.h (struct value_print_options) <max_depth>: New field.
3455         (val_print_check_max_depth): Declare new function.
3456         * NEWS: Document new feature.
3457
3458 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3459
3460         * ada-lang.c (ada_language_defn): Initialise new field.
3461         * c-lang.c (c_is_string_type_p): New function.
3462         (c_language_defn): Initialise new field.
3463         (cplus_language_defn): Initialise new field.
3464         (asm_language_defn): Initialise new field.
3465         (minimal_language_defn): Initialise new field.
3466         * c-lang.h (c_is_string_type_p): Declare new function.
3467         * d-lang.c (d_language_defn): Initialise new field.
3468         * f-lang.c (f_is_string_type_p): New function.
3469         (f_language_defn): Initialise new field.
3470         * go-lang.c (go_is_string_type_p): New function.
3471         (go_language_defn): Initialise new field.
3472         * language.c (default_is_string_type_p): New function.
3473         (unknown_language_defn): Initialise new field.
3474         (auto_language_defn): Initialise new field.
3475         * language.h (struct language_defn) <la_is_string_type_p>: New
3476         member variable.
3477         (default_is_string_type_p): Declare new function.
3478         * m2-lang.c (m2_language_defn): Initialise new field.
3479         * objc-lang.c (objc_language_defn): Initialise new field.
3480         * opencl-lang.c (opencl_language_defn): Initialise new field.
3481         * p-lang.c (pascal_is_string_type_p): New function.
3482         (pascal_language_defn): Initialise new field.
3483         * rust-lang.c (rust_is_string_type_p): New function.
3484         (rust_language_defn): Initialise new field.
3485
3486 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3487
3488         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3489         New field.
3490         * ada-lang.c (ada_language_defn): Initialise new field.
3491         * c-lang.c (c_language_defn): Likewise.
3492         (cplus_language_defn): Likewise.
3493         (asm_language_defn): Likewise.
3494         (minimal_language_defn): Likewise.
3495         * d-lang.c (d_language_defn): Likewise.
3496         * f-lang.c (f_language_defn): Likewise.
3497         * go-lang.c (go_language_defn): Likewise.
3498         * language.c (unknown_language_defn): Likewise.
3499         (auto_language_defn): Likewise.
3500         * m2-lang.c (m2_language_defn): Likewise.
3501         * objc-lang.c (objc_language_defn): Likewise.
3502         * opencl-lang.c (opencl_language_defn): Likewise.
3503         * p-lang.c (pascal_language_defn): Likewise.
3504         * rust-lang.c (rust_language_defn): Likewise.
3505
3506 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3507
3508         * ada-lang.c (ada_is_character_type): Change return type to bool.
3509         (ada_is_string_type): Likewise.
3510         * ada-lang.h (ada_is_character_type): Update declaration
3511         (ada_is_string_type): Likewise.
3512
3513 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3514
3515         Support style in 'frame|thread apply'
3516
3517         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3518         * record.c (record_start, record_stop): Update callers of
3519         execute_command_to_string with false.
3520         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3521         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3522         methods.
3523         (class string_file): New constructor with term_out parameter.
3524         Override methods term_out and can_emit_style_escape.  New member
3525         term_out.
3526         (class stdio_file): Override can_emit_style_escape.
3527         (class tee_file): Override term_out and can_emit_style_escape.
3528         * utils.h (can_emit_style_escape): Remove.
3529         * utils.c (can_emit_style_escape): Likewise.
3530         Update all callers of can_emit_style_escape (SOMESTREAM) to
3531         SOMESTREAM->can_emit_style_escape.
3532         * source-cache.c (source_cache::get_source_lines): Likewise.
3533         * stack.c (frame_apply_command_count): Call execute_command_to_string
3534         passing the term_out characteristic of the current gdb_stdout.
3535         * thread.c (thr_try_catch_cmd): Likewise.
3536         * top.c (execute_command_to_string): pass term_out parameter
3537         to construct the string_file for the command output.
3538         * ui-file.c (term_cli_styling): New function (most code moved
3539         from utils.c can_emit_style_escape).
3540         (string_file::string_file, string_file::can_emit_style_escape,
3541         stdio_file::can_emit_style_escape, tee_file::term_out,
3542         tee_file::can_emit_style_escape): New functions.
3543
3544 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3545
3546         * NEWS: Mention the new set|show may-call-functions.
3547         * infcall.c (may_call_functions_p): New variable.
3548         (show_may_call_functions_p): New function.
3549         (call_function_by_hand_dummy): Throws an error if not
3550         may-call-functions.
3551         (_initialize_infcall): Call add_setshow_boolean_cmd for
3552         may-call-functions.
3553
3554 2019-04-25  Keith Seitz  <keiths@redhat.com>
3555
3556         PR c++/24367
3557         * cp-support.c (inspect_type): Don't attempt substitutions
3558         of symbol with the same name.
3559
3560 2019-04-25  Tom Tromey  <tromey@adacore.com>
3561
3562         PR gdb/24475:
3563         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3564         static.
3565
3566 2019-04-25  Tom Tromey  <tromey@adacore.com>
3567
3568         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3569         rvalue reference.
3570         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3571         (gdb_xml_parser::parse): Use std::move.
3572         * python/python-internal.h (gdbpy_convert_exception): Take a const
3573         reference.
3574         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3575         std::move.
3576         * python/py-utils.c (gdbpy_convert_exception): Take a const
3577         reference.
3578         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3579         Use std::move.
3580         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3581         Use std::move.
3582         * mi/mi-main.c (mi_print_exception): Take a const reference.
3583         * main.c (handle_command_errors): Take a const reference.
3584         * linespec.c (parse_linespec): Use std::move.
3585         * infcall.c (run_inferior_call): Use std::move.
3586         (call_function_by_hand_dummy): Use std::move.
3587         * exec.c (try_open_exec_file): Use std::move.
3588         * exceptions.h (exception_print, exception_fprintf)
3589         (exception_print_same): Update.
3590         * exceptions.c (print_exception, exception_print)
3591         (exception_fprintf, exception_print_same): Change parameters to
3592         const reference.
3593         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3594         * common/new-op.c: Use std::move.
3595         * common/common-exceptions.h (struct gdb_exception): Add move
3596         constructor.
3597         (struct gdb_exception_error, struct gdb_exception_quit, struct
3598         gdb_quit_bad_alloc): Change constructor to move constructor.
3599         (throw_exception): Change parameter to rvalue reference.
3600         * common/common-exceptions.c (throw_exception): Take rvalue
3601         reference.
3602         * cli/cli-interp.c (safe_execute_command): Use std::move.
3603         * breakpoint.c (insert_bp_location, location_to_sals): Use
3604         std::move.
3605
3606 2019-04-25  Tom Tromey  <tromey@adacore.com>
3607
3608         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3609         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3610         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3611         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3612         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3613         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3614         guile/scm-value.c: Use unpack.
3615         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3616         gdbscm_gdb_exception.
3617         (gdbscm_throw_gdb_exception): Likewise.
3618         (struct gdbscm_gdb_exception): New.
3619         (unpack): New function.
3620         (gdbscm_wrap): Use unpack.
3621
3622 2019-04-25  Tom Tromey  <tromey@adacore.com>
3623
3624         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3625         (gdb_rl_callback_handler): Use std::move.
3626         * common/common-exceptions.h (struct gdb_exception): Add move
3627         assignment operator.
3628         (throw_exception_sjlj): Change "exception" to const reference.
3629         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3630         (throw_exception_sjlj): Change "exception" to const reference.
3631
3632 2019-04-25  Tom Tromey  <tromey@adacore.com>
3633
3634         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3635         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3636         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3637         Update.
3638         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3639         Update.
3640         * mi/mi-interp.c (mi_interp::exec): Update.
3641         * linespec.c (parse_linespec): Update.
3642         * infcall.c (run_inferior_call): Update.
3643         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3644         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3645         (gdbscm_lookup_global_symbol): Update.
3646         * guile/scm-param.c (gdbscm_parameter_value): Update.
3647         * guile/scm-frame.c (gdbscm_frame_read_register)
3648         (gdbscm_frame_read_var): Update.
3649         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3650         * exec.c (try_open_exec_file): Update.
3651         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3652         (gdb_rl_callback_handler): Update.
3653         * common/common-exceptions.h (exception_none): Don't declare.
3654         * common/common-exceptions.c (exception_none): Don't define.
3655         (struct catcher) <exception>: Update.
3656         * cli/cli-interp.c (safe_execute_command): Update.
3657         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3658
3659 2019-04-25  Ali Tamur  <tamur@google.com>
3660
3661         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3662         (read_attribute_value): Likewise.
3663         (dwarf2_read_addr_index): Update comment.
3664         (read_str_index): Add DW_FORM_strx.
3665         (dwarf2_string_attr): Likewise.
3666         (dwarf2_const_value_attr): Likewise.
3667         (dump_die_shallow): Likewise.
3668         (dwarf2_fetch_constant_bytes): Likewise.
3669         (skip_form_bytes): Likewise.
3670         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3671
3672 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3673
3674         PR corefiles/11608
3675         PR corefiles/18187
3676         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3677         OFFSET.  Verify if current mapping contains an ELF header.
3678         (linux_find_memory_regions_full): Adjust call to
3679         dump_mapping_p.
3680
3681 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3682             Kang Li <kanglictf@gmail.com>
3683
3684         PR gdb/21600
3685
3686         * dwarf2-frame.c (read_initial_length): Be consistent about using
3687         unsigned representation of length.
3688         (decode_frame_entry_1): Likewise.  Check for wraparound of
3689         end pointer as well as buffer overflow.
3690
3691 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3692
3693         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3694         "vq".
3695
3696 2019-04-24  Tom Tromey  <tromey@adacore.com>
3697
3698         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3699
3700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3701
3702         * s12z-tdep.c (s12z_unwind_pc): Delete.
3703         (s12z_unwind_sp): Delete.
3704         (s12z_gdbarch_init): Don't register deleted functions with
3705         gdbarch.
3706
3707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3708
3709         * rl78-tdep.c (rl78_unwind_sp): Delete.
3710         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3711
3712 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3713
3714         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3715         (xstormy16_unwind_pc): Delete.
3716         (xstormy16_dummy_id): Delete.
3717         (xstormy16_gdbarch_init): Don't register deleted functions with
3718         gdbarch.
3719
3720 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3721
3722         * vax-tdep.c (vax_unwind_pc): Delete.
3723         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3724
3725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3726
3727         * v850-tdep.c (v850_unwind_sp): Delete.
3728         (v850_unwind_pc): Delete.
3729         (v850_dummy_id): Delete.
3730         (v850_gdbarch_init): Don't register deleted functions with
3731         gdbarch.
3732
3733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3734
3735         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3736         (tilegx_unwind_pc): Delete.
3737         (tilegx_unwind_dummy_id): Delete.
3738         (tilegx_gdbarch_init): Don't register deleted functions with
3739         gdbarch.
3740
3741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3742
3743         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3744         (tic6x_dummy_id): Delete.
3745         (tic6x_gdbarch_init): Don't register deleted functions with
3746         gdbarch.
3747
3748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3749
3750         * sparc-tdep.c (sparc_unwind_pc): Delete.
3751         (sparc32_gdbarch_init): Don't register deleted function with
3752         gdbarch.
3753
3754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3755
3756         * sh-tdep.c (sh_unwind_sp): Delete.
3757         (sh_unwind_pc): Delete.
3758         (sh_dummy_id): Delete.
3759         (sh_gdbarch_init): Don't register deleted functions with
3760         gdbarch.
3761
3762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3763
3764         * score-tdep.c (score_unwind_sp): Delete.
3765         (score_unwind_pc): Delete.
3766         (score_dummy_id): Delete.
3767         (score_gdbarch_init): Don't register deleted functions with
3768         gdbarch.
3769
3770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3771
3772         * rx-tdep.c (rx_unwind_pc): Delete.
3773         (rx_unwind_sp): Delete.
3774         (rx_dummy_id): Delete.
3775         (rx_gdbarch_init): Don't register deleted functions with
3776         gdbarch.  Update comment.
3777
3778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3779
3780         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3781         (rs6000_dummy_id): Delete.
3782         (rs6000_gdbarch_init): Don't register deleted functions with
3783         gdbarch.
3784
3785 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3786
3787         * or1k-tdep.c (or1k_dummy_id): Delete.
3788         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3789
3790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3791
3792         * nios2-tdep.c (nios2_dummy_id): Delete.
3793         (nios2_unwind_sp): Delete.
3794         (nios2_gdbarch_init): Don't register deleted functions with
3795         gdbarch.
3796
3797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3798
3799         * nds32-tdep.c (nds32_dummy_id): Delete.
3800         (nds32_unwind_pc): Delete.
3801         (nds32_unwind_sp): Delete.
3802         (nds32_gdbarch_init): Don't register deleted functions with
3803         gdbarch.
3804
3805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3806
3807         * msp430-tdep.c (msp430_unwind_pc): Delete.
3808         (msp430_unwind_sp): Delete.
3809         (msp430_dummy_id): Delete.
3810         (msp430_gdbarch_init): Don't register deleted functions with
3811         gdbarch.
3812
3813 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3814
3815         * moxie-tdep.c (moxie_unwind_sp): Delete.
3816         (moxie_unwind_pc): Delete.
3817         (moxie_dummy_id): Delete.
3818         (moxie_gdbarch_init): Don't register deleted functions with
3819         gdbarch.
3820
3821 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3822
3823         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3824         (mn10300_unwind_pc): Delete.
3825         (mn10300_unwind_sp): Delete.
3826         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3827         mn10300_unwind_sp.
3828         (mn10300_frame_unwind_init): Don't register deleted functions with
3829         gdbarch.
3830
3831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * mep-tdep.c (mep_unwind_pc): Delete.
3834         (mep_unwind_sp): Delete.
3835         (mep_dummy_id): Delete.
3836         (mep_gdbarch_init): Don't register deleted functions with
3837         gdbarch.
3838
3839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3840
3841         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3842         (m68hc11_unwind_sp): Delete.
3843         (m68hc11_gdbarch_init): Don't register deleted functions with
3844         gdbarch.
3845
3846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3847
3848         * m32r-tdep.c (m32r_unwind_sp): Delete.
3849         (m32r_unwind_pc): Delete.
3850         (m32r_dummy_id): Delete.
3851         (m32r_gdbarch_init): Don't register deleted functions with
3852         gdbarch.
3853
3854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3855
3856         * m32c-tdep.c (m32c_unwind_pc): Delete.
3857         (m32c_unwind_sp): Delete.
3858         (m32c_dummy_id): Delete.
3859         (m32c_gdbarch_init): Don't register deleted functions with
3860         gdbarch.
3861
3862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3863
3864         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3865         (lm32_unwind_pc): Delete.
3866         (lm32_dummy_id): Delete.
3867         (lm32_gdbarch_init): Don't register deleted functions with
3868         gdbarch.
3869
3870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3871
3872         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3873         (iq2000_unwind_pc): Delete.
3874         (iq2000_dummy_id): Delete.
3875         (iq2000_gdbarch_init): Don't register deleted functions with
3876         gdbarch.
3877
3878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3879
3880         * nds32-tdep.c (nds32_type_align): Delete.
3881         (nds32_push_dummy_call): Use type_align instead.
3882
3883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3884
3885         * arm-tdep.c (arm_type_align): Only handle vector override case.
3886         (arm_push_dummy_call): Use type_align.
3887         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3888
3889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3890
3891         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3892         case.
3893         (pass_on_stack): Use type_align.
3894         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3895         function.
3896
3897 2019-04-23  Tom Tromey  <tromey@adacore.com>
3898
3899         * dwarf2read.c (line_header::file_name_at): Remove unused
3900         overload.
3901
3902 2019-04-23  Tom de Vries  <tdevries@suse.de>
3903
3904         PR gdb/24438
3905         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3906         invocation.
3907
3908
3909 2019-03-27  Ali Tamur  <tamur@google.com>
3910
3911         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3912         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3913         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3914         (dwarf_expr_context::get_addr_index): Likewise
3915         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3916         (symbol_needs_eval_context::get_addr_index): Likewise
3917         (disassemble_dwarf_expression): Add DW_OP_addrx
3918         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3919         (read_cutu_die_from_dwo): Update comment
3920         (skip_one_die): Add DW_FORM_addrx
3921         (read_attribute_value): Likewise
3922         (var_decode_location): Add DW_OP_addrx
3923         (dwarf2_const_value_attr): Add DW_FORM_addrx
3924         (dump_die_shallow): Likewise
3925         (dwarf2_fetch_constant_bytes): Likewise
3926         (decode_locdesc): Add DW_OP_addrx
3927         (skip_form_bytes): Add DW_FORM_addrx
3928
3929 2019-04-22  Ali Tamur  <tamur@google.com>
3930
3931         * MAINTAINERS (Write After Approval): Add self.
3932
3933 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3934
3935         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3936         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3937         (open_symbol_file_object): Likewise.
3938         (svr4_default_sos): Add info parameter.
3939         (svr4_read_so_list): Likewise.
3940         (svr4_current_sos_direct): Adjust functions calls to pass down
3941         info.
3942         (svr4_current_sos_1): Add info parameter.
3943         (svr4_current_sos): Call get_svr4_info, pass info down to
3944         svr4_current_sos_1.
3945         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3946         get_svr4_info.
3947         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3948         get_svr4_info.
3949         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3950         to get_svr4_info.
3951         (probes_table_remove_objfile_probes): Likewise.
3952         (register_solib_event_probe): Add info parameter.
3953         (solist_update_incremental): Pass info parameter down to
3954         svr4_read_so_list.
3955         (disable_probes_interface): Add info parameter.
3956         (svr4_handle_solib_event): Pass current_program_space to
3957         get_svr4_info.  Adjust disable_probes_interface cleanup.
3958         (svr4_create_probe_breakpoints): Add info parameter, pass it
3959         down to register_solib_event_probe.
3960         (svr4_create_solib_event_breakpoints): Add info parameter,
3961         pass it down to svr4_create_probe_breakpoints.
3962         (enable_break): Pass info down to
3963         svr4_create_solib_event_breakpoints.
3964         (svr4_solib_create_inferior_hook): Pass current_program_space to
3965         get_svr4_info.
3966         (svr4_clear_solib): Likewise.
3967
3968 2019-04-22  Pedro Alves  <palves@redhat.com>
3969
3970         * solib-svr4.c (svr4_free_objfile_observer): New.
3971         (probe_and_action::objfile): New field.
3972         (probes_table_htab_remove_objfile_probes)
3973         (probes_table_remove_objfile_probes): New functions.
3974         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3975         in the new probe_and_action.  Don't store the probe in 'lookup'.
3976         (svr4_create_probe_breakpoints): Pass objfile to
3977         register_solib_event_probe.
3978         (_initialize_svr4_solib): Register a free_objfile observer.
3979
3980 2019-04-19  Tom Tromey  <tom@tromey.com>
3981
3982         * common/queue.h: Remove.
3983
3984 2019-04-19  Tom Tromey  <tom@tromey.com>
3985
3986         * event-loop.c: Don't include "common/queue.h".
3987
3988 2019-04-19  Tom Tromey  <tom@tromey.com>
3989
3990         * remote.c (remote_target): Use delete.
3991         * remote-notif.h: Include <list>, not "common/queue.h".
3992         (notif_client_p): Remove typedef.
3993         (remote_notif_state): Add constructor, destructor, initializer.
3994         <notif_queue>: Now a std::list.
3995         (remote_notif_state_xfree): Don't declare.
3996         * remote-notif.c (remote_notif_process, handle_notification)
3997         (remote_notif_state_allocate): Update.
3998         (~remote_notif_state): Rename from remote_notif_state_xfree.
3999
4000 2019-04-19  Tom Tromey  <tom@tromey.com>
4001
4002         * symfile.c (reread_symbols): Update.
4003         * objfiles.c (objfile_register_static_link)
4004         (objfile_lookup_static_link): Update
4005         (~objfile) Don't delete static_links.
4006         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4007
4008 2019-04-19  Tom Tromey  <tom@tromey.com>
4009
4010         * type-stack.h (struct type_stack) <insert>: Constify string.
4011         * type-stack.c (type_stack::insert): Constify string.
4012         * gdbtypes.h (lookup_template_type): Update.
4013         (address_space_name_to_int): Update.
4014         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4015         const.
4016         (lookup_template_type): Make name const.
4017         * c-exp.y: Update rules.
4018         (lex_one_token, classify_name, classify_inner_name)
4019         (c_print_token): Update.
4020         * p-exp.y: Update rules.
4021         (yylex): Update.
4022         * f-exp.y: Update rules.
4023         (yylex): Update.
4024         * d-exp.y: Update rules.
4025         (lex_one_token, classify_name, classify_inner_name): Update.
4026         * parse.c (write_dollar_variable, copy_name): Return std::string.
4027         * parser-defs.h (copy_name): Change return type.
4028         * m2-exp.y: Update rules.
4029         (yylex): Update.
4030         * go-exp.y (lex_one_token): Update.
4031         Update rules.
4032         (classify_unsafe_function, classify_packaged_name)
4033         (classify_name, yylex): Update.
4034
4035 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4036
4037         * configure.ac: add --enable-source-highlight switch.
4038         * configure: Regenerate.
4039         * top.c (print_gdb_version): plumb --enable-source-highlight
4040         status to "show configuration".
4041
4042 2019-04-19  Tom Tromey  <tromey@adacore.com>
4043
4044         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4045         Check ADA_TYPE_P.
4046         (empty_record, ada_template_to_fixed_record_type_1)
4047         (template_to_static_fixed_type)
4048         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4049         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4050         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4051         macros.
4052
4053 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4054
4055         PR symtab/24423:
4056         * source.c (print_source_lines_base): Advance "iter" when a
4057         control character is seen.
4058
4059 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4060
4061         * inferior.h (struct infcall_suspend_state_deleter):
4062         Catch exception in destructor to avoid crash.
4063
4064 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4065
4066         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4067         close to the add_com "shell".
4068
4069 2019-04-18  Tom Tromey  <tromey@adacore.com>
4070
4071         * process-stratum-target.h (class process_stratum_target)
4072         <stratum>: Add "final".
4073
4074 2019-04-17  Tom Tromey  <tromey@adacore.com>
4075
4076         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4077         against nullptr before use.
4078
4079 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4080
4081         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4082
4083 2019-04-17  Jim Wilson  <jimw@sifive.com>
4084             Andrew Burgess  <andrew.burgess@embecosm.com>
4085
4086         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4087         code read might fail, assume 4-byte breakpoint in that case.
4088
4089 2019-04-15  Leszek Swirski  <leszeks@google.com>
4090
4091         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4092         rather than a hand-rolled POD check when checking for forced MEMORY
4093         classification.
4094
4095 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4096
4097         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4098         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4099         function.
4100         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4101         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4102         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4103         declaration.
4104
4105 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4106
4107         * aarch64-linux-nat.c
4108         (aarch64_linux_nat_target::thread_architecture): Add override.
4109         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4110         each VQ.
4111
4112 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4113
4114         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4115
4116 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4117
4118         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4119         target types of size 96-bits, add some additional comments, and
4120         check that the builtin type we found was the correct size.
4121
4122 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4123
4124         * utils.c (prompt_for_continue): Don't restore the styling at the
4125         end, as applied_style has the wrong value.  This fixes styling in
4126         long lists of file names that are interrupted by the "Continue?"
4127         prompt.
4128
4129 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4130
4131         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4132         * c-lang.c (c_language_defn): Likewise.
4133         (cplus_language_defn): Likewise.
4134         (asm_language_defn): Likewise.
4135         (minimal_language_defn): Likewise.
4136         * d-lang.c (d_language_defn): Likewise.
4137         * f-lang.c (f_language_defn): Likewise.
4138         * go-lang.c (go_language_defn): Likewise.
4139         * language.c (unknown_language_defn): Likewise.
4140         (auto_language_defn): Likewise.
4141         * language.h (struct language_defn): Remove la_magic field.
4142         (LANG_MAGIC): Delete.
4143         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4144         * objc-lang.c (objc_language_defn): Likewise.
4145         * opencl-lang.c (opencl_language_defn): Likewise.
4146         * p-lang.c (pascal_language_defn): Likewise.
4147         * rust-lang.c (rust_language_defn): Likewise.
4148
4149 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4150
4151         * riscv-tdep.c (riscv_type_align): New function.
4152         (riscv_type_alignment): Delete.
4153         (riscv_arg_location): Use 'type_align'.
4154         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4155
4156 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4157
4158         * gdbtypes.c (type_align): A struct with no non-static fields also
4159         has alignment of 1.
4160
4161 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4162
4163         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4164         component to 0.
4165         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4166         member.
4167         (riscv_struct_info::analyse): New implementation using new
4168         analyse_inner member function.
4169         (riscv_struct_info::field_offset): New member function.
4170         (riscv_struct_info::m_offsets): New member variable.
4171         (riscv_struct_info::analyse_inner): New private member function,
4172         takes the old implementation of riscv_struct_info::analyse but
4173         extended to track field offsets.
4174         (riscv_call_arg_struct): Update the struct folding special cases
4175         to handle cases where empty C++ structs, which are non-zero
4176         length, are found.
4177         (riscv_arg_location): Initialise the length of each location, a
4178         non-zero length now indicates the location is in use.
4179         (riscv_push_dummy_call): Allow for the first location having a
4180         non-zero offset when setting up arguments.
4181         (riscv_return_value): Likewise, but for return values.
4182
4183 2019-04-11  Tom Tromey  <tromey@adacore.com>
4184
4185         * utils.c (internal_vproblem): Make "msg" const.
4186
4187 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4188
4189         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4190         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4191         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4192         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4193
4194 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4195
4196         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4197         function.
4198         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4199         of amd64_collect_native_gregset.
4200         (amd64_linux_nat_target::store_registers): Likewise.
4201
4202 2019-04-10  Tom Tromey  <tom@tromey.com>
4203
4204         * symtab.c (lookup_global_symbol_from_objfile)
4205         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4206         * objfiles.h (class separate_debug_iterator): New.
4207         (class separate_debug_range): New.
4208         (struct objfile) <separate_debug_objfiles>: New method.
4209         (objfile_separate_debug_iterate): Don't declare.
4210         * objfiles.c (separate_debug_iterator::operator++): Rename from
4211         objfile_separate_debug_iterate.
4212         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4213         iterator.
4214         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4215         iterator.
4216
4217 2019-04-10  Tom Tromey  <tom@tromey.com>
4218
4219         * symfile.c (reread_symbols): Remove old comment.
4220         * objfiles.c (free_all_objfiles): Fix a typo.
4221
4222 2019-04-10  Tom Tromey  <tom@tromey.com>
4223
4224         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4225         * minsyms.c (lookup_minimal_symbol): Use foreach.
4226         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4227         (lookup_minimal_symbol_solib_trampoline): Likewise.
4228         * symfile.c (reread_symbols): Use foreach.
4229
4230 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4231             Tom Tromey  <tromey@adacore.com>
4232
4233         PR rust/24414:
4234         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4235         (rust_lex_int_test): Change "value" to be LONGEST.
4236         (rust_lex_tests): Add test for long integer literal.
4237
4238 2019-04-09  Tom Tromey  <tromey@adacore.com>
4239
4240         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4241         to bool.
4242         (extended_remote_target::attach): Update.
4243         (remote_target::remote_notice_new_inferior): Update.
4244         (remote_target::add_current_inferior_and_thread): Update.
4245         * inferior.c (exit_inferior_1): Use "false".
4246         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4247
4248 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4249
4250         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4251         the "start" command.
4252
4253 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4254
4255         * python/py-inferior.c (infpy_thread_from_thread_handle):
4256         Adjust comments to reflect renaming of thread_from_thread_handle
4257         to thread_from_handle.  Adjust keywords.  Fix type error message.
4258         (inferior_object_methods): Add thread_from_handle.  Retain
4259         thread_from_thread_handle, but mark it as deprecated.
4260
4261 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4262
4263         * gdbthread.h (find_thread_by_handle): Revise declaration.
4264         * thread.c (find_thread_by_handle): Likewise.  Adjust
4265         implementation too.
4266         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4267         support for buffer objects as handles.
4268
4269 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4270
4271         * python/py-infthread.c (thpy_thread_handle): New function.
4272         (thread_object_methods): Register thpy_thread_handle.
4273
4274 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4275
4276         * gdbthread.h (thread_to_thread_handle): Declare.
4277         * thread.c (gdbtypes.h): Include.
4278         (thread_to_thread_handle): New function.
4279
4280         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4281         (target_thread_info_to_thread_handle): Declare.
4282         * target.c (target_thread_info_to_thread_handle): New function.
4283         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4284         * target-delegates.c: Regenerate.
4285
4286         * linux-thread-db.c (class thread_db_target): Add method
4287         thread_info_to_thread_handle.
4288         (thread_db_target::thread_info_to_thread_handle): Define.
4289         * remote.c (class remote_target): Add new method
4290         thread_info_to_thread_handle.
4291         (remote_target::thread_info_to_thread_handle): Define.
4292
4293 2019-04-08  Pedro Alves  <palves@redhat.com>
4294
4295         * common/common-exceptions.c (throw_exception): Don't create
4296         named object to throw; throw directly.
4297         (throw_it): Likewise.  Don't initialize gdb_exception::message
4298         here, with new; pass FMT and AP to the ctor instead.
4299         * common/common-exceptions.h: Include <string>.
4300         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4301         const char *, va_list)): New ctor.  Use std::make_shared.
4302         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4303         errors)): Delete.
4304         (gdb_exception_error::gdb_exception_error(enum errors, const char
4305         *, va_list)): New.
4306         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4307         Add assertion.
4308         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4309         errors)): Delete.
4310         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4311         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4312         Add assertion.
4313
4314 2019-04-08  Tom Tromey  <tom@tromey.com>
4315
4316         * valops.c (value_rtti_indirect_type): Replace throw_exception
4317         with throw.
4318         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4319         with throw.
4320         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4321         throw.
4322         * target.c (target_translate_tls_address): Replace throw_exception
4323         with throw.
4324         * stack.c (frame_apply_command_count): Replace throw_exception
4325         with throw.
4326         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4327         throw.
4328         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4329         with throw.
4330         * rs6000-tdep.c (rs6000_frame_cache)
4331         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4332         * remote.c: Replace throw_exception with throw.
4333         * record-full.c (record_full_message, record_full_wait_1)
4334         (record_full_restore): Replace throw_exception with throw.
4335         * record-btrace.c:
4336         (get_thread_current_frame_id, record_btrace_start_replaying)
4337         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4338         (cmd_record_btrace_start): Replace throw_exception with throw.
4339         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4340         throw.
4341         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4342         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4343         * linespec.c:
4344         (find_linespec_symbols): Replace throw_exception with throw.
4345         * infrun.c (displaced_step_prepare, resume): Replace
4346         throw_exception with throw.
4347         * infcmd.c (post_create_inferior): Replace throw_exception with
4348         throw.
4349         * inf-loop.c (inferior_event_handler): Replace throw_exception
4350         with throw.
4351         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4352         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4353         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4354         (get_prev_frame_always, get_frame_pc_if_available)
4355         (get_frame_address_in_block_if_available, get_frame_language):
4356         Replace throw_exception with throw.
4357         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4358         throw_exception with throw.
4359         * eval.c (fetch_subexp_value, evaluate_var_value)
4360         (evaluate_funcall, evaluate_subexp_standard): Replace
4361         throw_exception with throw.
4362         * dwarf2loc.c (call_site_find_chain)
4363         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4364         Replace throw_exception with throw.
4365         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4366         with throw.
4367         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4368         throw.
4369         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4370         * completer.c (complete_line_internal): Replace throw_exception
4371         with throw.
4372         * compile/compile-object-run.c (compile_object_run): Replace
4373         throw_exception with throw.
4374         * cli/cli-script.c (process_next_line): Replace throw_exception
4375         with throw.
4376         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4377         (btrace_enable, btrace_maint_update_pt_packets): Replace
4378         throw_exception with throw.
4379         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4380         throw_exception with throw.
4381         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4382         throw_exception with throw.
4383         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4384         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4385         * aarch64-tdep.c (aarch64_make_prologue_cache)
4386         (aarch64_make_stub_cache): Replace throw_exception with throw.
4387
4388 2019-04-08  Tom Tromey  <tom@tromey.com>
4389
4390         * common/common-exceptions.c (throw_exception): Rename from
4391         throw_exception_cxx.  Remove old copy.  Make argument const.
4392         (throw_it): Create and throw exception objects directly.
4393         * common/common-exceptions.h (throw_exception): Make argument
4394         const.
4395         (struct gdb_exception_error): Add constructor.
4396         (struct gdb_exception_quit): Add constructor.
4397
4398 2019-04-08  Tom Tromey  <tom@tromey.com>
4399
4400         * common/common-exceptions.h (exception_rethrow): Don't declare.
4401         (TRY_SJLJ): Update comment.
4402         (TRY, CATCH, END_CATCH): Remove.
4403         * common/common-exceptions.c (exception_rethrow): Remove.
4404
4405 2019-04-08  Tom Tromey  <tom@tromey.com>
4406
4407         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4408         Remove.
4409         (gdb_exception_error): Rename from
4410         gdb_exception_RETURN_MASK_ERROR.
4411         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4412         (gdb_quit_bad_alloc): Update.
4413         * aarch64-tdep.c: Update.
4414         * ada-lang.c: Update.
4415         * ada-typeprint.c: Update.
4416         * ada-valprint.c: Update.
4417         * amd64-tdep.c: Update.
4418         * arch-utils.c: Update.
4419         * break-catch-throw.c: Update.
4420         * breakpoint.c: Update.
4421         * btrace.c: Update.
4422         * c-varobj.c: Update.
4423         * cli/cli-cmds.c: Update.
4424         * cli/cli-interp.c: Update.
4425         * cli/cli-script.c: Update.
4426         * common/common-exceptions.c: Update.
4427         * common/new-op.c: Update.
4428         * common/selftest.c: Update.
4429         * compile/compile-c-symbols.c: Update.
4430         * compile/compile-cplus-symbols.c: Update.
4431         * compile/compile-object-load.c: Update.
4432         * compile/compile-object-run.c: Update.
4433         * completer.c: Update.
4434         * corelow.c: Update.
4435         * cp-abi.c: Update.
4436         * cp-support.c: Update.
4437         * cp-valprint.c: Update.
4438         * darwin-nat.c: Update.
4439         * disasm-selftests.c: Update.
4440         * dtrace-probe.c: Update.
4441         * dwarf-index-cache.c: Update.
4442         * dwarf-index-write.c: Update.
4443         * dwarf2-frame-tailcall.c: Update.
4444         * dwarf2-frame.c: Update.
4445         * dwarf2loc.c: Update.
4446         * dwarf2read.c: Update.
4447         * eval.c: Update.
4448         * event-loop.c: Update.
4449         * event-top.c: Update.
4450         * exec.c: Update.
4451         * f-valprint.c: Update.
4452         * fbsd-tdep.c: Update.
4453         * frame-unwind.c: Update.
4454         * frame.c: Update.
4455         * gdbtypes.c: Update.
4456         * gnu-v3-abi.c: Update.
4457         * guile/guile-internal.h: Update.
4458         * guile/scm-block.c: Update.
4459         * guile/scm-breakpoint.c: Update.
4460         * guile/scm-cmd.c: Update.
4461         * guile/scm-disasm.c: Update.
4462         * guile/scm-frame.c: Update.
4463         * guile/scm-lazy-string.c: Update.
4464         * guile/scm-math.c: Update.
4465         * guile/scm-param.c: Update.
4466         * guile/scm-ports.c: Update.
4467         * guile/scm-pretty-print.c: Update.
4468         * guile/scm-symbol.c: Update.
4469         * guile/scm-symtab.c: Update.
4470         * guile/scm-type.c: Update.
4471         * guile/scm-value.c: Update.
4472         * i386-linux-tdep.c: Update.
4473         * i386-tdep.c: Update.
4474         * inf-loop.c: Update.
4475         * infcall.c: Update.
4476         * infcmd.c: Update.
4477         * infrun.c: Update.
4478         * jit.c: Update.
4479         * language.c: Update.
4480         * linespec.c: Update.
4481         * linux-fork.c: Update.
4482         * linux-nat.c: Update.
4483         * linux-tdep.c: Update.
4484         * linux-thread-db.c: Update.
4485         * main.c: Update.
4486         * mi/mi-cmd-break.c: Update.
4487         * mi/mi-cmd-stack.c: Update.
4488         * mi/mi-interp.c: Update.
4489         * mi/mi-main.c: Update.
4490         * objc-lang.c: Update.
4491         * p-valprint.c: Update.
4492         * parse.c: Update.
4493         * ppc-linux-tdep.c: Update.
4494         * printcmd.c: Update.
4495         * python/py-arch.c: Update.
4496         * python/py-breakpoint.c: Update.
4497         * python/py-cmd.c: Update.
4498         * python/py-finishbreakpoint.c: Update.
4499         * python/py-frame.c: Update.
4500         * python/py-framefilter.c: Update.
4501         * python/py-gdb-readline.c: Update.
4502         * python/py-inferior.c: Update.
4503         * python/py-infthread.c: Update.
4504         * python/py-lazy-string.c: Update.
4505         * python/py-linetable.c: Update.
4506         * python/py-objfile.c: Update.
4507         * python/py-param.c: Update.
4508         * python/py-prettyprint.c: Update.
4509         * python/py-progspace.c: Update.
4510         * python/py-record-btrace.c: Update.
4511         * python/py-record.c: Update.
4512         * python/py-symbol.c: Update.
4513         * python/py-type.c: Update.
4514         * python/py-unwind.c: Update.
4515         * python/py-utils.c: Update.
4516         * python/py-value.c: Update.
4517         * python/python.c: Update.
4518         * record-btrace.c: Update.
4519         * record-full.c: Update.
4520         * remote-fileio.c: Update.
4521         * remote.c: Update.
4522         * riscv-tdep.c: Update.
4523         * rs6000-aix-tdep.c: Update.
4524         * rs6000-tdep.c: Update.
4525         * rust-exp.y: Update.
4526         * rust-lang.c: Update.
4527         * s390-tdep.c: Update.
4528         * selftest-arch.c: Update.
4529         * solib-dsbt.c: Update.
4530         * solib-frv.c: Update.
4531         * solib-spu.c: Update.
4532         * solib-svr4.c: Update.
4533         * solib.c: Update.
4534         * sparc64-linux-tdep.c: Update.
4535         * stack.c: Update.
4536         * symfile-mem.c: Update.
4537         * symmisc.c: Update.
4538         * target.c: Update.
4539         * thread.c: Update.
4540         * top.c: Update.
4541         * tracefile-tfile.c: Update.
4542         * tui/tui.c: Update.
4543         * typeprint.c: Update.
4544         * unittests/cli-utils-selftests.c: Update.
4545         * unittests/parse-connection-spec-selftests.c: Update.
4546         * valops.c: Update.
4547         * valprint.c: Update.
4548         * value.c: Update.
4549         * varobj.c: Update.
4550         * windows-nat.c: Update.
4551         * x86-linux-nat.c: Update.
4552         * xml-support.c: Update.
4553
4554 2019-04-08  Tom Tromey  <tom@tromey.com>
4555
4556         * xml-support.c: Use C++ exception handling.
4557         * x86-linux-nat.c: Use C++ exception handling.
4558         * windows-nat.c: Use C++ exception handling.
4559         * varobj.c: Use C++ exception handling.
4560         * value.c: Use C++ exception handling.
4561         * valprint.c: Use C++ exception handling.
4562         * valops.c: Use C++ exception handling.
4563         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4564         handling.
4565         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4566         * typeprint.c: Use C++ exception handling.
4567         * tui/tui.c: Use C++ exception handling.
4568         * tracefile-tfile.c: Use C++ exception handling.
4569         * top.c: Use C++ exception handling.
4570         * thread.c: Use C++ exception handling.
4571         * target.c: Use C++ exception handling.
4572         * symmisc.c: Use C++ exception handling.
4573         * symfile-mem.c: Use C++ exception handling.
4574         * stack.c: Use C++ exception handling.
4575         * sparc64-linux-tdep.c: Use C++ exception handling.
4576         * solib.c: Use C++ exception handling.
4577         * solib-svr4.c: Use C++ exception handling.
4578         * solib-spu.c: Use C++ exception handling.
4579         * solib-frv.c: Use C++ exception handling.
4580         * solib-dsbt.c: Use C++ exception handling.
4581         * selftest-arch.c: Use C++ exception handling.
4582         * s390-tdep.c: Use C++ exception handling.
4583         * rust-lang.c: Use C++ exception handling.
4584         * rust-exp.y: Use C++ exception handling.
4585         * rs6000-tdep.c: Use C++ exception handling.
4586         * rs6000-aix-tdep.c: Use C++ exception handling.
4587         * riscv-tdep.c: Use C++ exception handling.
4588         * remote.c: Use C++ exception handling.
4589         * remote-fileio.c: Use C++ exception handling.
4590         * record-full.c: Use C++ exception handling.
4591         * record-btrace.c: Use C++ exception handling.
4592         * python/python.c: Use C++ exception handling.
4593         * python/py-value.c: Use C++ exception handling.
4594         * python/py-utils.c: Use C++ exception handling.
4595         * python/py-unwind.c: Use C++ exception handling.
4596         * python/py-type.c: Use C++ exception handling.
4597         * python/py-symbol.c: Use C++ exception handling.
4598         * python/py-record.c: Use C++ exception handling.
4599         * python/py-record-btrace.c: Use C++ exception handling.
4600         * python/py-progspace.c: Use C++ exception handling.
4601         * python/py-prettyprint.c: Use C++ exception handling.
4602         * python/py-param.c: Use C++ exception handling.
4603         * python/py-objfile.c: Use C++ exception handling.
4604         * python/py-linetable.c: Use C++ exception handling.
4605         * python/py-lazy-string.c: Use C++ exception handling.
4606         * python/py-infthread.c: Use C++ exception handling.
4607         * python/py-inferior.c: Use C++ exception handling.
4608         * python/py-gdb-readline.c: Use C++ exception handling.
4609         * python/py-framefilter.c: Use C++ exception handling.
4610         * python/py-frame.c: Use C++ exception handling.
4611         * python/py-finishbreakpoint.c: Use C++ exception handling.
4612         * python/py-cmd.c: Use C++ exception handling.
4613         * python/py-breakpoint.c: Use C++ exception handling.
4614         * python/py-arch.c: Use C++ exception handling.
4615         * printcmd.c: Use C++ exception handling.
4616         * ppc-linux-tdep.c: Use C++ exception handling.
4617         * parse.c: Use C++ exception handling.
4618         * p-valprint.c: Use C++ exception handling.
4619         * objc-lang.c: Use C++ exception handling.
4620         * mi/mi-main.c: Use C++ exception handling.
4621         * mi/mi-interp.c: Use C++ exception handling.
4622         * mi/mi-cmd-stack.c: Use C++ exception handling.
4623         * mi/mi-cmd-break.c: Use C++ exception handling.
4624         * main.c: Use C++ exception handling.
4625         * linux-thread-db.c: Use C++ exception handling.
4626         * linux-tdep.c: Use C++ exception handling.
4627         * linux-nat.c: Use C++ exception handling.
4628         * linux-fork.c: Use C++ exception handling.
4629         * linespec.c: Use C++ exception handling.
4630         * language.c: Use C++ exception handling.
4631         * jit.c: Use C++ exception handling.
4632         * infrun.c: Use C++ exception handling.
4633         * infcmd.c: Use C++ exception handling.
4634         * infcall.c: Use C++ exception handling.
4635         * inf-loop.c: Use C++ exception handling.
4636         * i386-tdep.c: Use C++ exception handling.
4637         * i386-linux-tdep.c: Use C++ exception handling.
4638         * guile/scm-value.c: Use C++ exception handling.
4639         * guile/scm-type.c: Use C++ exception handling.
4640         * guile/scm-symtab.c: Use C++ exception handling.
4641         * guile/scm-symbol.c: Use C++ exception handling.
4642         * guile/scm-pretty-print.c: Use C++ exception handling.
4643         * guile/scm-ports.c: Use C++ exception handling.
4644         * guile/scm-param.c: Use C++ exception handling.
4645         * guile/scm-math.c: Use C++ exception handling.
4646         * guile/scm-lazy-string.c: Use C++ exception handling.
4647         * guile/scm-frame.c: Use C++ exception handling.
4648         * guile/scm-disasm.c: Use C++ exception handling.
4649         * guile/scm-cmd.c: Use C++ exception handling.
4650         * guile/scm-breakpoint.c: Use C++ exception handling.
4651         * guile/scm-block.c: Use C++ exception handling.
4652         * guile/guile-internal.h: Use C++ exception handling.
4653         * gnu-v3-abi.c: Use C++ exception handling.
4654         * gdbtypes.c: Use C++ exception handling.
4655         * frame.c: Use C++ exception handling.
4656         * frame-unwind.c: Use C++ exception handling.
4657         * fbsd-tdep.c: Use C++ exception handling.
4658         * f-valprint.c: Use C++ exception handling.
4659         * exec.c: Use C++ exception handling.
4660         * event-top.c: Use C++ exception handling.
4661         * event-loop.c: Use C++ exception handling.
4662         * eval.c: Use C++ exception handling.
4663         * dwarf2read.c: Use C++ exception handling.
4664         * dwarf2loc.c: Use C++ exception handling.
4665         * dwarf2-frame.c: Use C++ exception handling.
4666         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4667         * dwarf-index-write.c: Use C++ exception handling.
4668         * dwarf-index-cache.c: Use C++ exception handling.
4669         * dtrace-probe.c: Use C++ exception handling.
4670         * disasm-selftests.c: Use C++ exception handling.
4671         * darwin-nat.c: Use C++ exception handling.
4672         * cp-valprint.c: Use C++ exception handling.
4673         * cp-support.c: Use C++ exception handling.
4674         * cp-abi.c: Use C++ exception handling.
4675         * corelow.c: Use C++ exception handling.
4676         * completer.c: Use C++ exception handling.
4677         * compile/compile-object-run.c: Use C++ exception handling.
4678         * compile/compile-object-load.c: Use C++ exception handling.
4679         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4680         * compile/compile-c-symbols.c: Use C++ exception handling.
4681         * common/selftest.c: Use C++ exception handling.
4682         * common/new-op.c: Use C++ exception handling.
4683         * cli/cli-script.c: Use C++ exception handling.
4684         * cli/cli-interp.c: Use C++ exception handling.
4685         * cli/cli-cmds.c: Use C++ exception handling.
4686         * c-varobj.c: Use C++ exception handling.
4687         * btrace.c: Use C++ exception handling.
4688         * breakpoint.c: Use C++ exception handling.
4689         * break-catch-throw.c: Use C++ exception handling.
4690         * arch-utils.c: Use C++ exception handling.
4691         * amd64-tdep.c: Use C++ exception handling.
4692         * ada-valprint.c: Use C++ exception handling.
4693         * ada-typeprint.c: Use C++ exception handling.
4694         * ada-lang.c: Use C++ exception handling.
4695         * aarch64-tdep.c: Use C++ exception handling.
4696
4697 2019-04-08  Tom Tromey  <tom@tromey.com>
4698
4699         * xml-support.c (gdb_xml_parser::parse): Update.
4700         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4701         * value.c (show_convenience): Update.
4702         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4703         (test_parse_flags_qcs): Update.
4704         * thread.c (thr_try_catch_cmd): Update.
4705         * target.c (target_translate_tls_address): Update.
4706         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4707         (info_frame_command_core, frame_apply_command_count): Update.
4708         * rust-exp.y (rust_lex_exception_test): Update.
4709         * riscv-tdep.c (riscv_print_one_register_info): Update.
4710         * remote.c (remote_target::enable_btrace): Update.
4711         * record-btrace.c (record_btrace_enable_warn): Update.
4712         * python/py-utils.c (gdbpy_convert_exception): Update.
4713         * printcmd.c (do_one_display, print_variable_and_value): Update.
4714         * mi/mi-main.c (mi_print_exception): Update.
4715         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4716         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4717         * linux-nat.c (linux_nat_target::attach): Update.
4718         * linux-fork.c (class scoped_switch_fork_info): Update.
4719         * infrun.c (displaced_step_prepare): Update.
4720         * infcall.c (call_function_by_hand_dummy): Update.
4721         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4722         * gnu-v3-abi.c (print_one_vtable): Update.
4723         * frame.c (get_prev_frame_always): Update.
4724         * f-valprint.c (info_common_command_for_block): Update.
4725         * exec.c (try_open_exec_file): Update.
4726         * exceptions.c (print_exception, exception_print)
4727         (exception_fprintf, exception_print_same): Update.
4728         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4729         * dwarf-index-cache.c (index_cache::store)
4730         (index_cache::lookup_gdb_index): Update.
4731         * darwin-nat.c (maybe_cache_shell): Update.
4732         * cp-valprint.c (cp_print_value_fields): Update.
4733         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4734         (gcc_cplus_symbol_address): Update.
4735         * compile/compile-c-symbols.c (gcc_convert_symbol)
4736         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4737         * common/selftest.c: Update.
4738         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4739         a std::string.
4740         (exception_try_scope_entry, exception_try_scope_exit): Don't
4741         declare.
4742         (struct exception_try_scope): Remove.
4743         (TRY): Don't use exception_try_scope.
4744         (struct gdb_exception): Add constructor, operator=.
4745         <what>: New method.
4746         (struct gdb_exception_RETURN_MASK_ALL)
4747         (struct gdb_exception_RETURN_MASK_ERROR)
4748         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4749         (struct gdb_quit_bad_alloc): Update.
4750         * common/common-exceptions.c (exception_none): Change
4751         initializer.
4752         (struct catcher) <state, exception>: Initialize inline.
4753         <prev>: Remove member.
4754         (current_catcher): Remove.
4755         (catchers): New global.
4756         (exceptions_state_mc_init): Simplify.
4757         (catcher_pop): Remove.
4758         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4759         (try_scope_depth, exception_try_scope_entry)
4760         (exception_try_scope_exit): Remove.
4761         (throw_exception_sjlj): Update.
4762         (exception_messages, exception_messages_size): Remove.
4763         (throw_it): Simplify.
4764         (gdb_exception_sliced_copy): Remove.
4765         (throw_exception_cxx): Update.
4766         * cli/cli-script.c (script_from_file): Update.
4767         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4768         Update.
4769         * ada-valprint.c (ada_val_print): Update.
4770         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4771         (create_excep_cond_exprs): Update.
4772
4773 2019-04-08  Tom Tromey  <tom@tromey.com>
4774
4775         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4776         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4777         (TRY, CATCH, END_CATCH): Remove some definitions.
4778         * common/common-exceptions.c: Don't use GDB_XCPT.
4779         (catcher_list_size): Remove.
4780         (throw_exception, throw_it): Simplify.
4781
4782 2019-04-05  Tom Tromey  <tom@tromey.com>
4783
4784         Revert the header-sorting patch.
4785         * ft32-tdep.c: Revert.
4786         * frv-tdep.c: Revert.
4787         * frv-linux-tdep.c: Revert.
4788         * frame.c: Revert.
4789         * frame-unwind.c: Revert.
4790         * frame-base.c: Revert.
4791         * fork-child.c: Revert.
4792         * findvar.c: Revert.
4793         * findcmd.c: Revert.
4794         * filesystem.c: Revert.
4795         * filename-seen-cache.h: Revert.
4796         * filename-seen-cache.c: Revert.
4797         * fbsd-tdep.c: Revert.
4798         * fbsd-nat.h: Revert.
4799         * fbsd-nat.c: Revert.
4800         * f-valprint.c: Revert.
4801         * f-typeprint.c: Revert.
4802         * f-lang.c: Revert.
4803         * extension.h: Revert.
4804         * extension.c: Revert.
4805         * extension-priv.h: Revert.
4806         * expprint.c: Revert.
4807         * exec.h: Revert.
4808         * exec.c: Revert.
4809         * exceptions.c: Revert.
4810         * event-top.c: Revert.
4811         * event-loop.c: Revert.
4812         * eval.c: Revert.
4813         * elfread.c: Revert.
4814         * dwarf2read.h: Revert.
4815         * dwarf2read.c: Revert.
4816         * dwarf2loc.c: Revert.
4817         * dwarf2expr.h: Revert.
4818         * dwarf2expr.c: Revert.
4819         * dwarf2-frame.c: Revert.
4820         * dwarf2-frame-tailcall.c: Revert.
4821         * dwarf-index-write.h: Revert.
4822         * dwarf-index-write.c: Revert.
4823         * dwarf-index-common.c: Revert.
4824         * dwarf-index-cache.h: Revert.
4825         * dwarf-index-cache.c: Revert.
4826         * dummy-frame.c: Revert.
4827         * dtrace-probe.c: Revert.
4828         * disasm.h: Revert.
4829         * disasm.c: Revert.
4830         * disasm-selftests.c: Revert.
4831         * dictionary.c: Revert.
4832         * dicos-tdep.c: Revert.
4833         * demangle.c: Revert.
4834         * dcache.h: Revert.
4835         * dcache.c: Revert.
4836         * darwin-nat.h: Revert.
4837         * darwin-nat.c: Revert.
4838         * darwin-nat-info.c: Revert.
4839         * d-valprint.c: Revert.
4840         * d-namespace.c: Revert.
4841         * d-lang.c: Revert.
4842         * ctf.c: Revert.
4843         * csky-tdep.c: Revert.
4844         * csky-linux-tdep.c: Revert.
4845         * cris-tdep.c: Revert.
4846         * cris-linux-tdep.c: Revert.
4847         * cp-valprint.c: Revert.
4848         * cp-support.c: Revert.
4849         * cp-namespace.c: Revert.
4850         * cp-abi.c: Revert.
4851         * corelow.c: Revert.
4852         * corefile.c: Revert.
4853         * continuations.c: Revert.
4854         * completer.h: Revert.
4855         * completer.c: Revert.
4856         * complaints.c: Revert.
4857         * coffread.c: Revert.
4858         * coff-pe-read.c: Revert.
4859         * cli-out.h: Revert.
4860         * cli-out.c: Revert.
4861         * charset.c: Revert.
4862         * c-varobj.c: Revert.
4863         * c-valprint.c: Revert.
4864         * c-typeprint.c: Revert.
4865         * c-lang.c: Revert.
4866         * buildsym.c: Revert.
4867         * buildsym-legacy.c: Revert.
4868         * build-id.h: Revert.
4869         * build-id.c: Revert.
4870         * btrace.c: Revert.
4871         * bsd-uthread.c: Revert.
4872         * breakpoint.h: Revert.
4873         * breakpoint.c: Revert.
4874         * break-catch-throw.c: Revert.
4875         * break-catch-syscall.c: Revert.
4876         * break-catch-sig.c: Revert.
4877         * blockframe.c: Revert.
4878         * block.c: Revert.
4879         * bfin-tdep.c: Revert.
4880         * bfin-linux-tdep.c: Revert.
4881         * bfd-target.c: Revert.
4882         * bcache.c: Revert.
4883         * ax-general.c: Revert.
4884         * ax-gdb.h: Revert.
4885         * ax-gdb.c: Revert.
4886         * avr-tdep.c: Revert.
4887         * auxv.c: Revert.
4888         * auto-load.c: Revert.
4889         * arm-wince-tdep.c: Revert.
4890         * arm-tdep.c: Revert.
4891         * arm-symbian-tdep.c: Revert.
4892         * arm-pikeos-tdep.c: Revert.
4893         * arm-obsd-tdep.c: Revert.
4894         * arm-nbsd-tdep.c: Revert.
4895         * arm-nbsd-nat.c: Revert.
4896         * arm-linux-tdep.c: Revert.
4897         * arm-linux-nat.c: Revert.
4898         * arm-fbsd-tdep.c: Revert.
4899         * arm-fbsd-nat.c: Revert.
4900         * arm-bsd-tdep.c: Revert.
4901         * arch-utils.c: Revert.
4902         * arc-tdep.c: Revert.
4903         * arc-newlib-tdep.c: Revert.
4904         * annotate.h: Revert.
4905         * annotate.c: Revert.
4906         * amd64-windows-tdep.c: Revert.
4907         * amd64-windows-nat.c: Revert.
4908         * amd64-tdep.c: Revert.
4909         * amd64-sol2-tdep.c: Revert.
4910         * amd64-obsd-tdep.c: Revert.
4911         * amd64-obsd-nat.c: Revert.
4912         * amd64-nbsd-tdep.c: Revert.
4913         * amd64-nbsd-nat.c: Revert.
4914         * amd64-nat.c: Revert.
4915         * amd64-linux-tdep.c: Revert.
4916         * amd64-linux-nat.c: Revert.
4917         * amd64-fbsd-tdep.c: Revert.
4918         * amd64-fbsd-nat.c: Revert.
4919         * amd64-dicos-tdep.c: Revert.
4920         * amd64-darwin-tdep.c: Revert.
4921         * amd64-bsd-nat.c: Revert.
4922         * alpha-tdep.c: Revert.
4923         * alpha-obsd-tdep.c: Revert.
4924         * alpha-nbsd-tdep.c: Revert.
4925         * alpha-mdebug-tdep.c: Revert.
4926         * alpha-linux-tdep.c: Revert.
4927         * alpha-linux-nat.c: Revert.
4928         * alpha-bsd-tdep.c: Revert.
4929         * alpha-bsd-nat.c: Revert.
4930         * aix-thread.c: Revert.
4931         * agent.c: Revert.
4932         * addrmap.c: Revert.
4933         * ada-varobj.c: Revert.
4934         * ada-valprint.c: Revert.
4935         * ada-typeprint.c: Revert.
4936         * ada-tasks.c: Revert.
4937         * ada-lang.c: Revert.
4938         * aarch64-tdep.c: Revert.
4939         * aarch64-ravenscar-thread.c: Revert.
4940         * aarch64-newlib-tdep.c: Revert.
4941         * aarch64-linux-tdep.c: Revert.
4942         * aarch64-linux-nat.c: Revert.
4943         * aarch64-fbsd-tdep.c: Revert.
4944         * aarch64-fbsd-nat.c: Revert.
4945         * aarch32-linux-nat.c: Revert.
4946
4947 2019-04-05  Tom Tromey  <tom@tromey.com>
4948
4949         * ft32-tdep.c: Sort headers.
4950         * frv-tdep.c: Sort headers.
4951         * frv-linux-tdep.c: Sort headers.
4952         * frame.c: Sort headers.
4953         * frame-unwind.c: Sort headers.
4954         * frame-base.c: Sort headers.
4955         * fork-child.c: Sort headers.
4956         * findvar.c: Sort headers.
4957         * findcmd.c: Sort headers.
4958         * filesystem.c: Sort headers.
4959         * filename-seen-cache.h: Sort headers.
4960         * filename-seen-cache.c: Sort headers.
4961         * fbsd-tdep.c: Sort headers.
4962         * fbsd-nat.h: Sort headers.
4963         * fbsd-nat.c: Sort headers.
4964         * f-valprint.c: Sort headers.
4965         * f-typeprint.c: Sort headers.
4966         * f-lang.c: Sort headers.
4967         * extension.h: Sort headers.
4968         * extension.c: Sort headers.
4969         * extension-priv.h: Sort headers.
4970         * expprint.c: Sort headers.
4971         * exec.h: Sort headers.
4972         * exec.c: Sort headers.
4973         * exceptions.c: Sort headers.
4974         * event-top.c: Sort headers.
4975         * event-loop.c: Sort headers.
4976         * eval.c: Sort headers.
4977         * elfread.c: Sort headers.
4978         * dwarf2read.h: Sort headers.
4979         * dwarf2read.c: Sort headers.
4980         * dwarf2loc.c: Sort headers.
4981         * dwarf2expr.h: Sort headers.
4982         * dwarf2expr.c: Sort headers.
4983         * dwarf2-frame.c: Sort headers.
4984         * dwarf2-frame-tailcall.c: Sort headers.
4985         * dwarf-index-write.h: Sort headers.
4986         * dwarf-index-write.c: Sort headers.
4987         * dwarf-index-common.c: Sort headers.
4988         * dwarf-index-cache.h: Sort headers.
4989         * dwarf-index-cache.c: Sort headers.
4990         * dummy-frame.c: Sort headers.
4991         * dtrace-probe.c: Sort headers.
4992         * disasm.h: Sort headers.
4993         * disasm.c: Sort headers.
4994         * disasm-selftests.c: Sort headers.
4995         * dictionary.c: Sort headers.
4996         * dicos-tdep.c: Sort headers.
4997         * demangle.c: Sort headers.
4998         * dcache.h: Sort headers.
4999         * dcache.c: Sort headers.
5000         * darwin-nat.h: Sort headers.
5001         * darwin-nat.c: Sort headers.
5002         * darwin-nat-info.c: Sort headers.
5003         * d-valprint.c: Sort headers.
5004         * d-namespace.c: Sort headers.
5005         * d-lang.c: Sort headers.
5006         * ctf.c: Sort headers.
5007         * csky-tdep.c: Sort headers.
5008         * csky-linux-tdep.c: Sort headers.
5009         * cris-tdep.c: Sort headers.
5010         * cris-linux-tdep.c: Sort headers.
5011         * cp-valprint.c: Sort headers.
5012         * cp-support.c: Sort headers.
5013         * cp-namespace.c: Sort headers.
5014         * cp-abi.c: Sort headers.
5015         * corelow.c: Sort headers.
5016         * corefile.c: Sort headers.
5017         * continuations.c: Sort headers.
5018         * completer.h: Sort headers.
5019         * completer.c: Sort headers.
5020         * complaints.c: Sort headers.
5021         * coffread.c: Sort headers.
5022         * coff-pe-read.c: Sort headers.
5023         * cli-out.h: Sort headers.
5024         * cli-out.c: Sort headers.
5025         * charset.c: Sort headers.
5026         * c-varobj.c: Sort headers.
5027         * c-valprint.c: Sort headers.
5028         * c-typeprint.c: Sort headers.
5029         * c-lang.c: Sort headers.
5030         * buildsym.c: Sort headers.
5031         * buildsym-legacy.c: Sort headers.
5032         * build-id.h: Sort headers.
5033         * build-id.c: Sort headers.
5034         * btrace.c: Sort headers.
5035         * bsd-uthread.c: Sort headers.
5036         * breakpoint.h: Sort headers.
5037         * breakpoint.c: Sort headers.
5038         * break-catch-throw.c: Sort headers.
5039         * break-catch-syscall.c: Sort headers.
5040         * break-catch-sig.c: Sort headers.
5041         * blockframe.c: Sort headers.
5042         * block.c: Sort headers.
5043         * bfin-tdep.c: Sort headers.
5044         * bfin-linux-tdep.c: Sort headers.
5045         * bfd-target.c: Sort headers.
5046         * bcache.c: Sort headers.
5047         * ax-general.c: Sort headers.
5048         * ax-gdb.h: Sort headers.
5049         * ax-gdb.c: Sort headers.
5050         * avr-tdep.c: Sort headers.
5051         * auxv.c: Sort headers.
5052         * auto-load.c: Sort headers.
5053         * arm-wince-tdep.c: Sort headers.
5054         * arm-tdep.c: Sort headers.
5055         * arm-symbian-tdep.c: Sort headers.
5056         * arm-pikeos-tdep.c: Sort headers.
5057         * arm-obsd-tdep.c: Sort headers.
5058         * arm-nbsd-tdep.c: Sort headers.
5059         * arm-nbsd-nat.c: Sort headers.
5060         * arm-linux-tdep.c: Sort headers.
5061         * arm-linux-nat.c: Sort headers.
5062         * arm-fbsd-tdep.c: Sort headers.
5063         * arm-fbsd-nat.c: Sort headers.
5064         * arm-bsd-tdep.c: Sort headers.
5065         * arch-utils.c: Sort headers.
5066         * arc-tdep.c: Sort headers.
5067         * arc-newlib-tdep.c: Sort headers.
5068         * annotate.h: Sort headers.
5069         * annotate.c: Sort headers.
5070         * amd64-windows-tdep.c: Sort headers.
5071         * amd64-windows-nat.c: Sort headers.
5072         * amd64-tdep.c: Sort headers.
5073         * amd64-sol2-tdep.c: Sort headers.
5074         * amd64-obsd-tdep.c: Sort headers.
5075         * amd64-obsd-nat.c: Sort headers.
5076         * amd64-nbsd-tdep.c: Sort headers.
5077         * amd64-nbsd-nat.c: Sort headers.
5078         * amd64-nat.c: Sort headers.
5079         * amd64-linux-tdep.c: Sort headers.
5080         * amd64-linux-nat.c: Sort headers.
5081         * amd64-fbsd-tdep.c: Sort headers.
5082         * amd64-fbsd-nat.c: Sort headers.
5083         * amd64-dicos-tdep.c: Sort headers.
5084         * amd64-darwin-tdep.c: Sort headers.
5085         * amd64-bsd-nat.c: Sort headers.
5086         * alpha-tdep.c: Sort headers.
5087         * alpha-obsd-tdep.c: Sort headers.
5088         * alpha-nbsd-tdep.c: Sort headers.
5089         * alpha-mdebug-tdep.c: Sort headers.
5090         * alpha-linux-tdep.c: Sort headers.
5091         * alpha-linux-nat.c: Sort headers.
5092         * alpha-bsd-tdep.c: Sort headers.
5093         * alpha-bsd-nat.c: Sort headers.
5094         * aix-thread.c: Sort headers.
5095         * agent.c: Sort headers.
5096         * addrmap.c: Sort headers.
5097         * ada-varobj.c: Sort headers.
5098         * ada-valprint.c: Sort headers.
5099         * ada-typeprint.c: Sort headers.
5100         * ada-tasks.c: Sort headers.
5101         * ada-lang.c: Sort headers.
5102         * aarch64-tdep.c: Sort headers.
5103         * aarch64-ravenscar-thread.c: Sort headers.
5104         * aarch64-newlib-tdep.c: Sort headers.
5105         * aarch64-linux-tdep.c: Sort headers.
5106         * aarch64-linux-nat.c: Sort headers.
5107         * aarch64-fbsd-tdep.c: Sort headers.
5108         * aarch64-fbsd-nat.c: Sort headers.
5109         * aarch32-linux-nat.c: Sort headers.
5110
5111 2019-04-04  Tom Tromey  <tom@tromey.com>
5112
5113         * varobj.c (varobj_create): Update.
5114         * rust-exp.y (struct rust_parser) <update_innermost_block,
5115         lookup_symbol>: New methods.
5116         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5117         Rename.
5118         (rust_parser::rust_lookup_type)
5119         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5120         * printcmd.c (display_command, do_one_display): Update.
5121         * parser-defs.h (struct parser_state) <parser_state>: Add
5122         "tracker" parameter.
5123         (block_tracker): New member.
5124         (class innermost_block_tracker) <innermost_block_tracker>: Add
5125         "types" parameter.
5126         <reset>: Remove method.
5127         (innermost_block): Don't declare.
5128         (null_post_parser): Update.
5129         * parse.c (innermost_block): Remove global.
5130         (write_dollar_variable): Update.
5131         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5132         Remove "tracker_types" parameter.
5133         (parse_expression): Add "tracker" parameter.
5134         (parse_expression_for_completion): Update.
5135         (null_post_parser): Add "tracker" parameter.
5136         * p-exp.y: Update rules.
5137         * m2-exp.y: Update rules.
5138         * language.h (struct language_defn) <la_post_parser>: Add
5139         "tracker" parameter.
5140         * go-exp.y: Update rules.
5141         * f-exp.y: Update rules.
5142         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5143         parameter.
5144         * d-exp.y: Update rules.
5145         * c-exp.y: Update rules.
5146         * breakpoint.c (set_breakpoint_condition): Create an
5147         innermost_block_tracker.
5148         (watch_command_1): Likewise.
5149         * ada-lang.c (resolve): Add "tracker" parameter.
5150         (resolve_subexp): Likewise.
5151         * ada-exp.y (write_var_from_sym): Update.
5152
5153 2019-04-04  Tom Tromey  <tom@tromey.com>
5154
5155         * type-stack.h: New file.
5156         * type-stack.c: New file.
5157         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5158         type-stack.h.
5159         (insert_into_type_stack, insert_type, push_type, push_type_int)
5160         (insert_type_address_space, pop_type, pop_type_int)
5161         (pop_typelist, pop_type_stack, append_type_stack)
5162         (push_type_stack, get_type_stack, push_typelist)
5163         (follow_type_instance_flags, follow_types): Don't declare.
5164         * parse.c (type_stack): Remove global.
5165         (parse_exp_in_context): Update.
5166         (insert_into_type_stack, insert_type, push_type, push_type_int)
5167         (insert_type_address_space, pop_type, pop_type_int)
5168         (pop_typelist, pop_type_stack, append_type_stack)
5169         (push_type_stack, get_type_stack, push_typelist)
5170         (follow_type_instance_flags, follow_types): Remove (moved to
5171         type-stack.c).
5172         * f-exp.y (type_stack): New global.
5173         Update rules.
5174         (push_kind_type, f_parse): Update.
5175         * d-exp.y (type_stack): New global.
5176         Update rules.
5177         (d_parse): Update.
5178         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5179         Update rules.
5180         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5181         (HFILES_NO_SRCDIR): Add type-stack.h.
5182
5183 2019-04-04  Tom Tromey  <tom@tromey.com>
5184
5185         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5186         (rust_parser::convert_ast_to_expression, rust_parse)
5187         (rust_lex_test_completion, rust_lex_tests): Update.
5188         * parser-defs.h (struct expr_completion_state): New.
5189         (struct parser_state) <parser_state>: Add completion parameter.
5190         <mark_struct_expression, mark_completion_tag>: New methods.
5191         <parse_completion, m_completion_state>: New members.
5192         (prefixify_expression, null_post_parser): Update.
5193         (mark_struct_expression, mark_completion_tag): Don't declare.
5194         * parse.c (parse_completion, expout_last_struct)
5195         (expout_tag_completion_type, expout_completion_name): Remove
5196         globals.
5197         (parser_state::mark_struct_expression)
5198         (parser_state::mark_completion_tag): Now methods.
5199         (prefixify_expression): Add last_struct parameter.
5200         (prefixify_subexp): Likewise.
5201         (parse_exp_1): Update.
5202         (parse_exp_in_context): Add cstate parameter.  Update.
5203         (parse_expression_for_completion): Create an
5204         expr_completion_state.
5205         (null_post_parser): Add "completion" parameter.
5206         * p-exp.y: Update rules.
5207         (yylex): Update.
5208         * language.h (struct language_defn) <la_post_parser>: Add
5209         "completing" parameter.
5210         * go-exp.y: Update rules.
5211         (lex_one_token): Update.
5212         * expression.h (parse_completion): Don't declare.
5213         * d-exp.y: Update rules.
5214         (lex_one_token): Update rules.
5215         * c-exp.y: Update rules.
5216         (lex_one_token): Update.
5217         * ada-lang.c (resolve): Add "parse_completion" parameter.
5218         (resolve_subexp): Likewise.
5219         (ada_resolve_function): Likewise.
5220
5221 2019-04-04  Tom Tromey  <tom@tromey.com>
5222
5223         * parser-defs.h (struct parser_state) <start_arglist,
5224         end_arglist>: New methods.
5225         <arglist_len, m_funcall_chain>: New members.
5226         (arglist_len, start_arglist, end_arglist): Don't declare.
5227         * parse.c (arglist_len, funcall_chain): Remove global.
5228         (start_arglist, end_arglist): Remove functions.
5229         (parse_exp_in_context): Update.
5230         * p-exp.y: Update rules.
5231         * m2-exp.y: Update rules.
5232         * go-exp.y: Update rules.
5233         * f-exp.y: Update rules.
5234         * d-exp.y: Update rules.
5235         * c-exp.y: Update rules.
5236
5237 2019-04-04  Tom Tromey  <tom@tromey.com>
5238
5239         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5240         lex_operator, push_back>: New methods.
5241         Update all rules.
5242         (rust_parser::lex_hex, lex_escape): Rename and update.
5243         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5244         (rust_parser::lex_operator): Rename and update.
5245         (rust_parser::lex_number, rustyylex, rustyyerror)
5246         (rust_lex_test_init, rust_lex_test_sequence)
5247         (rust_lex_test_push_back, rust_lex_tests): Update.
5248         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5249         parameter.
5250         <lexptr, prev_lexptr>: New members.
5251         (lexptr, prev_lexptr): Don't declare.
5252         * parse.c (lexptr, prev_lexptr): Remove globals.
5253         (parse_exp_in_context): Update.
5254         * p-exp.y (yylex, yyerror): Update.
5255         * m2-exp.y (parse_number, yylex, yyerror): Update.
5256         * go-exp.y (lex_one_token, yyerror): Update.
5257         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5258         * d-exp.y (lex_one_token, yyerror): Update.
5259         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5260         (lex_one_token, yyerror): Update.
5261         * ada-lex.l (YY_INPUT): Update.
5262         (rewind_to_char): Update.
5263         * ada-exp.y (yyerror): Update.
5264
5265 2019-04-04  Tom Tromey  <tom@tromey.com>
5266
5267         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5268         * parser-defs.h (struct parser_state) <parser_state>: Add new
5269         parameter.
5270         <comma_terminates>: New member.
5271         (comma_terminates): Don't declare global.
5272         * parse.c (comma_terminates): Remove global.
5273         (parse_exp_in_context): Update.
5274         * p-exp.y (yylex): Update.
5275         * m2-exp.y (yylex): Update.
5276         * go-exp.y (lex_one_token): Update.
5277         * f-exp.y (yylex): Update.
5278         * d-exp.y (lex_one_token): Update.
5279         * c-exp.y (lex_one_token): Update.
5280         * ada-lex.l: Update.
5281
5282 2019-04-04  Tom Tromey  <tom@tromey.com>
5283
5284         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5285         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5286         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5287         * parser-defs.h (paren_depth): Don't declare.
5288         * parse.c (paren_depth): Remove global.
5289         (parse_exp_in_context): Update.
5290         * p-exp.y (paren_depth): New global.
5291         (pascal_parse): Initialize it.
5292         * m2-exp.y (paren_depth): New global.
5293         (m2_parse): Initialize it.
5294         * go-exp.y (paren_depth): New global.
5295         (go_parse): Initialize it.
5296         * f-exp.y (paren_depth): New global.
5297         (f_parse): Initialize it.
5298         * d-exp.y (paren_depth): New global.
5299         (d_parse): Initialize it.
5300         * c-exp.y (paren_depth): New global.
5301         (c_parse): Initialize it.
5302         * ada-lex.l (paren_depth): New global.
5303         (lexer_init): Initialize it.
5304
5305 2019-04-04  Tom Tromey  <tom@tromey.com>
5306
5307         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5308         (rust_parser::convert_ast_to_type)
5309         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5310         * parser-defs.h (struct parser_state) <parser_state>: Add
5311         parameters.  Initialize new members.
5312         <expression_context_block, expression_context_pc>: New members.
5313         * parse.c (expression_context_block, expression_context_pc):
5314         Remove globals.
5315         (parse_exp_in_context): Update.
5316         * p-exp.y: Update all rules.
5317         (yylex): Update.
5318         * m2-exp.y: Update all rules.
5319         (yylex): Update.
5320         * go-exp.y (yylex): Update.
5321         * f-exp.y (yylex): Update.
5322         * d-exp.y: Update all rules.
5323         (yylex): Update.
5324         * c-exp.y: Update all rules.
5325         (lex_one_token, classify_name, yylex, c_parse): Update.
5326         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5327
5328 2019-04-04  Tom Tromey  <tom@tromey.com>
5329
5330         * gdbarch.h, gdbarch.c: Rebuild.
5331         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5332         * stap-probe.h:
5333         (struct stap_parse_info): Replace "parser_state" with
5334         "expr_builder".
5335         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5336         (parser_state): New class.
5337         * parse.c (expr_builder): Rename.
5338         (expr_builder::release): Rename.
5339         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5340         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5341         (write_exp_elt_longcst, write_exp_elt_floatcst)
5342         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5343         (write_exp_string_vector, write_exp_bitstring)
5344         (write_exp_msymbol, mark_struct_expression)
5345         (write_dollar_variable)
5346         (insert_type_address_space, increase_expout_size): Replace
5347         "parser_state" with "expr_builder".
5348         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5349         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5350         "parser_state" with "expr_builder".
5351
5352 2019-04-04  Tom Tromey  <tom@tromey.com>
5353
5354         * rust-exp.y: Replace "parse_language" with method call.
5355         * p-exp.y:
5356         (yylex): Replace "parse_language" with method call.
5357         * m2-exp.y:
5358         (yylex): Replace "parse_language" with method call.
5359         * go-exp.y (classify_name): Replace "parse_language" with method
5360         call.
5361         * f-exp.y (yylex): Replace "parse_language" with method call.
5362         * d-exp.y (lex_one_token): Replace "parse_language" with method
5363         call.
5364         * c-exp.y:
5365         (lex_one_token, classify_name, yylex): Replace "parse_language"
5366         with method call.
5367         * ada-exp.y (find_primitive_type, type_char)
5368         (type_system_address): Replace "parse_language" with method call.
5369
5370 2019-04-04  Tom Tromey  <tom@tromey.com>
5371
5372         * rust-exp.y: Replace "parse_gdbarch" with method call.
5373         * parse.c (write_dollar_variable, insert_type_address_space):
5374         Replace "parse_gdbarch" with method call.
5375         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5376         call.
5377         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5378         call.
5379         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5380         "parse_gdbarch" with method call.
5381         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5382         with method call.
5383         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5384         "parse_gdbarch" with method call.
5385         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5386         "parse_gdbarch" with method call.
5387         * c-exp.y (parse_type, parse_number, classify_name): Replace
5388         "parse_gdbarch" with method call.
5389         * ada-lex.l: Replace "parse_gdbarch" with method call.
5390         * ada-exp.y (parse_type, find_primitive_type, type_char)
5391         (type_system_address): Replace "parse_gdbarch" with method call.
5392
5393 2019-04-04  Tom Tromey  <tom@tromey.com>
5394
5395         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5396         * stap-probe.c (stap_parse_argument): Update.
5397         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5398         initial_size parameter.
5399         * rust-exp.y (rust_lex_tests): Update.
5400         * parse.c (parser_state): Update.
5401         (parse_exp_in_context): Update.
5402         * parser-defs.h (struct parser_state) <parser_state>: Remove
5403         "initial_size" parameter.
5404
5405 2019-04-04  Tom Tromey  <tom@tromey.com>
5406
5407         * parser-defs.h (increase_expout_size): Don't declare.
5408         * parse.c (increase_expout_size): Now static.
5409
5410 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5411
5412         * gnu-nat.c (gnu_nat_target::wait): Fix
5413         target_waitstatus_to_string call.
5414
5415 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5416
5417         * eval.c (evaluate_subexp_standard): Handle internal functions
5418         during Fortran function call handling.
5419
5420 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5421
5422         * NEWS: Mention new internal functions.
5423         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5424         (read_base_type): Use dwarf2_init_complex_target_type.
5425         * value.c (creal_internal_fn): New function.
5426         (cimag_internal_fn): New function.
5427         (_initialize_values): Register new internal functions.
5428
5429 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5430
5431         * infrun.c (stop_all_threads): If debug_infrun, always
5432         trace the wait status after wait_one, using
5433         target_waitstatus_to_string and target_pid_to_str.
5434         (handle_inferior_event): Replace various trace of
5435         wait status kind by a single trace.
5436         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5437         wait status kind image by target_waitstatus_to_string.
5438         * target/waitstatus.c (target_waitstatus_to_string): Fix
5439         obsolete comment.
5440
5441 2019-04-01  Tom Tromey  <tromey@adacore.com>
5442
5443         PR symtab/23331:
5444         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5445
5446 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5447             Pedro Alves  <palves@redhat.com>
5448
5449         * top.c (quit_force): Call 'finalize_values'.
5450         * value.c (finalize_values): New function.
5451         * value.h (finalize_values): Declare.
5452
5453 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5454
5455         * NEWS: Announce $_gdb_major and $_gdb_minor.
5456
5457         * top.c (init_gdb_version_vars): New function.
5458         (gdb_init): Call init_gdb_version_vars.
5459
5460 2019-03-29  Tom Tromey  <tromey@adacore.com>
5461
5462         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5463         help text.  Remove dead code.
5464
5465 2019-03-29  Keith Seitz  <keiths@redhat.com>
5466
5467         From Siddhesh Poyarekar:
5468         * f-lang.h (f77_get_upperbound): Return LONGEST.
5469         (f77_get_lowerbound): Likewise.
5470         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5471         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5472         print them.
5473         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5474         plongest to format print it.
5475         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5476         (f77_get_upperbound): Likewise.
5477         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5478         LOWER_BOUND to LONGEST.
5479         (f77_create_arrayprint_offset_tbl): Likewise.
5480
5481 2019-03-29  Keith Seitz  <keiths@redhat.com>
5482
5483         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5484         %s/pulongest for TYPE_LENGTH instead of %d in format
5485         strings.
5486         * ada-typerint.c (ada_print_type): Likewise.
5487         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5488         * compile/compile-c-support.c (generate_register_struct): Likewise.
5489         * gdbtypes.c (recursive_dump_type): Likewise.
5490         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5491         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5492         instead of %d in format strings.
5493         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5494         to std::min to ULONGEST.
5495         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5496         instead of %d in format strings.
5497         * tracepoint.c (info_scope_command): Likewise.
5498         * typeprint.c (print_offset_data::update)
5499         (print_offset_data::finish): Likewise.
5500         * xtensa-tdep.c (xtensa_store_return_value)
5501         (xtensa_push_dummy_call): Likewise.
5502
5503 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5504
5505         * windows-nat.c (display_selector): Fixed format specifications
5506         for 64-bit Cygwin.
5507
5508 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5509
5510         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5511
5512 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5513
5514         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5515         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5516         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5517         (nios2_linux_init_abi): Install it.
5518
5519 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5520
5521         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5522
5523 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5524
5525         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5526
5527 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5528             Tom Tromey  <tromey@adacore.com>
5529
5530         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5531
5532 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5533
5534         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5535         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5536         method to compute the bounds of range types. Also print "[evaluated]"
5537         if the bounds' values come from a dynamic evaluation.
5538
5539 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5540
5541         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5542         whitespace when pretty printing is on.
5543
5544 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5545
5546         * ppc-linux-nat.c: Add include.
5547
5548 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5549
5550         * NEWS: Mention AArch64 Pointer Authentication.
5551
5552 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5553
5554         * arm-linux-nat.c: Add include.
5555
5556 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5557
5558         * source-cache.c (source_cache::get_source_lines): Re-read
5559         fullname after calling open_source_file.
5560
5561 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5562
5563         * NEWS: Mention TLS support for FreeBSD.
5564
5565 2019-03-25  Tom Tromey  <tromey@adacore.com>
5566
5567         * minsyms.c (BUNCH_SIZE): Update comment.
5568         (~minimal_symbol_reader): Remove old comment.
5569         (compact_minimal_symbols): Update comment.
5570         (minimal_symbol_reader::install): Remove old comment.  Update
5571         other comments.
5572
5573 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5574
5575         * s390-linux-nat.c: Add include.
5576
5577 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5578
5579         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5580         Call linux_get_hwcap.
5581         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5582         Likewise.
5583         (aarch64_linux_get_hwcap): Remove function.
5584         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5585         declaration.
5586         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5587         linux_get_hwcap.
5588         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5589         * linux-tdep.c (linux_get_hwcap): Add function.
5590         (linux_get_hwcap2): Likewise.
5591         * linux-tdep.h (linux_get_hwcap): Add declaration.
5592         (linux_get_hwcap2): Likewise.
5593         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5594         (ppc_linux_get_hwcap2): Likewise.
5595         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5596         linux_get_hwcap.
5597         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5598         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5599         (ppc_linux_nat_target::read_description): Likewise.
5600         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5601         * s390-linux-nat.c: Likewise.
5602         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5603
5604 2019-03-24  Tom Tromey  <tom@tromey.com>
5605
5606         * ada-lang.c (standard_lookup): Simplify initialization.
5607         (ada_lookup_symbol_nonlocal): Simplify return.
5608         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5609         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5610         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5611         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5612         initialization.
5613         * solib.c (solib_global_lookup): Simplify.
5614         * symtab.c (null_block_symbol): Remove.
5615         (symbol_cache_lookup): Simplify returns.
5616         (lookup_language_this): Simplify returns.
5617         (lookup_symbol_aux): Simplify return.
5618         (lookup_local_symbol): Simplify returns.
5619         (lookup_global_symbol_from_objfile): Simplify return.
5620         (lookup_symbol_in_objfile_symtabs)
5621         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5622         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5623         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5624         * cp-namespace.c (cp_lookup_bare_symbol)
5625         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5626         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5627         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5628         (cp_lookup_symbol_via_imports): Simplify initialization.
5629         (find_symbol_in_baseclass): Likewise.
5630         * symtab.h (null_block_symbol): Remove.
5631         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5632         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5633         (d_lookup_symbol_module): Likewise.
5634         (find_symbol_in_baseclass): Simplify initialization.
5635
5636 2019-03-24  Tom Tromey  <tom@tromey.com>
5637
5638         * expression.h: Don't include symtab.h.
5639         (struct block): Forward declare.
5640
5641 2019-03-24  Tom Tromey  <tom@tromey.com>
5642
5643         * c-exp.y (typebase): Remove casts.
5644         * gdbtypes.c (lookup_unsigned_typename, )
5645         (lookup_signed_typename): Remove cast.
5646         * eval.c (parse_to_comma_and_eval): Remove cast.
5647         * parse.c (write_dollar_variable): Remove cast.
5648         * block.h (struct block) <superblock>: Now const.
5649         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5650         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5651         (map_block): Make "block" const.
5652         * symfile.h (struct quick_symbol_functions)
5653         <map_matching_symbols>: Constify block argument to "callback".
5654         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5655         const.
5656         (find_pc_sect_compunit_symtab): Make "b" const.
5657         (find_symbol_at_address): Likewise.
5658         (search_symbols): Likewise.
5659         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5660         (dw2_debug_names_lookup_symbol): Likewise.
5661         (dw2_map_matching_symbols): Update.
5662         * p-valprint.c (pascal_val_print): Remove "block".
5663         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5664         (aux_add_nonlocal_symbols): Make "block" const.
5665         (resolve_subexp): Remove cast.
5666         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5667         const.
5668         (iterate_over_file_blocks): Likewise.
5669         * f-exp.y (%union) <bval>: Remove.
5670         * coffread.c (patch_opaque_types): Make "b" const.
5671         * spu-tdep.c (spu_catch_start): Make "block" const.
5672         * c-valprint.c (print_unpacked_pointer): Remove "block".
5673         * symmisc.c (dump_symtab_1): Make "b" const.
5674         (block_depth): Make "block" const.
5675         * d-exp.y (%union) <bval>: Remove.
5676         * cp-support.h (cp_lookup_rtti_type): Update.
5677         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5678         * psymtab.c (psym_lookup_symbol): Make "block" const.
5679         (maintenance_check_psymtabs): Make "b" const.
5680         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5681         (enumerate_locals, enumerate_args): Update.
5682         * python/py-symtab.c (stpy_global_block): Make "block" const.
5683         (stpy_static_block): Likewise.
5684         * inline-frame.c (block_starting_point_at): Make "new_block"
5685         const.
5686         * block.c (find_block_in_blockvector): Make return type const.
5687         (blockvector_for_pc_sect): Make "b" const.
5688         (find_block_in_blockvector): Make "b" const.
5689
5690 2019-03-23  Tom Tromey  <tom@tromey.com>
5691
5692         * varobj.c (varobj_create): Update.
5693         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5694         * printcmd.c (display_command, do_one_display): Don't reset
5695         innermost_block.
5696         * parser-defs.h (enum innermost_block_tracker_type): Move to
5697         expression.h.
5698         (innermost_block): Update comment.
5699         * parse.c (parse_exp_1): Add tracker_types parameter.
5700         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5701         tracker_types parameter.  Reset innermost_block.
5702         (parse_exp_in_context): Remove.
5703         (parse_expression_for_completion): Update.
5704         * objfiles.c (~objfile): Don't reset expression_context_block or
5705         innermost_block.
5706         * expression.h (enum innermost_block_tracker_type): Move from
5707         parser-defs.h.
5708         (parse_exp_1): Add tracker_types parameter.
5709         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5710         reset innermost_block.
5711
5712 2019-03-23  Tom Tromey  <tom@tromey.com>
5713
5714         * objfiles.h: Include bcache.h.
5715
5716 2019-03-23  Tom Tromey  <tom@tromey.com>
5717
5718         * linespec.c (get_current_search_block): Use
5719         scoped_restore_current_language.
5720         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5721
5722 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5723             Jiong Wang  <jiong.wang@arm.com>
5724
5725         * aarch64-linux-tdep.c
5726         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5727         section.
5728         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5729
5730 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5731             Jiong Wang  <jiong.wang@arm.com>
5732
5733         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5734         instructions.
5735         (aarch64_analyze_prologue_test): Add PACIASP test.
5736         (aarch64_prologue_prev_register): Unmask PC value.
5737
5738 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5739             Jiong Wang  <jiong.wang@arm.com>
5740
5741         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5742         (aarch64_dwarf2_prev_register): Unmask PC value.
5743         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5744         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5745         DW_CFA_AARCH64_negate_ra_state.
5746         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5747
5748 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5749             Jiong Wang  <jiong.wang@arm.com>
5750
5751         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5752         registers.
5753         (aarch64_pseudo_register_name): Likewise.
5754         (aarch64_pseudo_register_type): Likewise.
5755         (aarch64_pseudo_register_reggroup_p): Likewise.
5756         (aarch64_gdbarch_init): Add pauth registers.
5757         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5758         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5759         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5760         (struct gdbarch_tdep): Add regnum for ra_state.
5761
5762 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5763             Jiong Wang  <jiong.wang@arm.com>
5764
5765         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5766
5767 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5768             Jiong Wang  <jiong.wang@arm.com>
5769
5770         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5771         function.
5772         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5773         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5774         (aarch64_gdbarch_init): Add puth registers.
5775         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5776         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5777         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5778
5779 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5780             Jiong Wang  <jiong.wang@arm.com>
5781
5782         * aarch64-linux-nat.c
5783         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5784         * aarch64-linux-tdep.c
5785         (aarch64_linux_core_read_description): Likewise.
5786         (aarch64_linux_get_hwcap): New function.
5787         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5788         (aarch64_linux_get_hwcap): New declaration.
5789
5790 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5791             Jiong Wang  <jiong.wang@arm.com>
5792
5793         * aarch64-linux-nat.c
5794         (aarch64_linux_nat_target::read_description): Add pauth param.
5795         * aarch64-linux-tdep.c
5796         (aarch64_linux_core_read_description): Likewise.
5797         * aarch64-tdep.c (struct target_desc): Add in pauth.
5798         (aarch64_read_description): Add pauth param.
5799         (aarch64_gdbarch_init): Likewise.
5800         * aarch64-tdep.h (aarch64_read_description): Likewise.
5801         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5802         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5803         * features/Makefile: Add new files.
5804         * features/aarch64-pauth.c: New file.
5805         * features/aarch64-pauth.xml: New file.
5806
5807 2019-03-20  Tom Tromey  <tromey@adacore.com>
5808
5809         * infrun.c (handle_inferior_event): Rename from
5810         handle_inferior_event_1.  Create a scoped_value_mark.
5811         (handle_inferior_event): Remove.
5812
5813 2019-03-19  Tom Tromey  <tromey@adacore.com>
5814
5815         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5816         * infrun.h (print_stop_event): Add "displays" parameter.
5817         * infrun.c (print_stop_event): Add "displays" parameter.
5818
5819 2019-03-19  Pedro Alves  <palves@redhat.com>
5820
5821         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5822         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5823         to -1.  Fix TABs vs spaces.
5824         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5825         * tui/tui-out.h (tui_ui_out) Add intro comments.
5826         <m_line, m_start_of_line>: In-class initialize, and add describing
5827         comment.
5828
5829 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5830
5831         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5832         variable names.
5833         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5834
5835 2019-03-18  Pedro Alves  <palves@redhat.com>
5836             Eli Zaretskii <eliz@gnu.org>
5837
5838         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5839         m_line and m_start_of_line.
5840
5841 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5842
5843         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5844         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5845         it returns a newline.  This fixes a regression in TU mode, whereby
5846         the next line is output on the same screen line as the user input.
5847
5848 2019-03-18  Tom Tromey  <tromey@adacore.com>
5849
5850         * minsyms.c (minimal_symbol_reader::install): Remove call to
5851         obstack_blank.
5852
5853 2019-03-18  Pedro Alves  <palves@redhat.com>
5854
5855         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5856         New globals.
5857         (apply_style): New, factored out from ...
5858         (apply_ansi_escape): ... this.  Handle reverse video mode.
5859         (tui_set_reverse_mode): New function.
5860         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5861         * tui/tui-winsource.c (tui_show_source_line): Use
5862         tui_set_reverse_mode instead of setting A_STANDOUT.
5863         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5864         New setter methods.
5865
5866 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5867
5868         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5869         Handle tabs.
5870
5871 2019-03-18  Tom Tromey  <tromey@adacore.com>
5872
5873         * ada-lang.c (empty_array): Add "high" parameter.
5874         (ada_evaluate_subexp): Update.
5875
5876 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5877
5878         * unittests/string_view-selftests.c: Define
5879         _initialize_string_view_selftests unconditionally.
5880
5881 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5882
5883         PR gdb/24350
5884         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5885
5886 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5887
5888         PR gdb/24351
5889         * windows-nat.c (display_selector): Fix format specifiers.
5890
5891 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5892
5893         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5894         tui_refill_source_window instead of tui_refresh_win, to update the
5895         current execution line.  This fixes redisplay of the current line
5896         when stepping through the code with "next" or "step".
5897
5898 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5899
5900         * source-cache.c (source_cache::get_source_lines): Call
5901         find_source_lines to initialize s->nlines.  This fixes vertical
5902         scrolling of TUI source window when the DOWN arrow is pressed.
5903
5904 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5905
5906         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5907         linux-thread-db.c (_initialize_thread_db): Likewise.
5908
5909 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5910
5911         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5912         wclrtoeol in tui_show_source_line".  This reverts changes made in
5913         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5914
5915 2019-03-15  Tom Tromey  <tom@tromey.com>
5916
5917         * symtab.h (struct minimal_symbol): Derive from
5918         general_symbol_info.
5919         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5920         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5921         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5922         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5923         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5924         (MSYMBOL_SEARCH_NAME): Update.
5925         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5926         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5927         * minsyms.c (minimal_symbol_reader::record_full): Update.
5928
5929 2019-03-15  Tom Tromey  <tom@tromey.com>
5930
5931         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5932
5933 2019-03-15  Tom Tromey  <tom@tromey.com>
5934
5935         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5936         unique_xmalloc_ptr.
5937         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5938         Update.
5939         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5940         (build_minimal_symbol_hash_tables)
5941         (minimal_symbol_reader::install): Update.
5942
5943 2019-03-15  Tom Tromey  <tom@tromey.com>
5944
5945         * symtab.c (create_demangled_names_hash): Update.
5946         (symbol_set_names): Update.
5947         * objfiles.h (struct objfile_per_bfd_storage)
5948         <demangled_names_hash>: Now an htab_up.
5949         * objfiles.c (objfile_per_bfd_storage): Simplify.
5950
5951 2019-03-15  Tom Tromey  <tom@tromey.com>
5952
5953         * objfiles.h (struct objfile_per_bfd_storage): Declare
5954         destructor.
5955         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5956         New.
5957         (get_objfile_bfd_data): Use new.  Don't initialize
5958         language_of_main.
5959         (free_objfile_per_bfd_storage): Remove.
5960         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5961
5962 2019-03-15  Tom Tromey  <tom@tromey.com>
5963
5964         * symfile.c (reread_symbols): Update.
5965         * objfiles.c (objfile::objfile): Update.
5966         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5967         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5968         comment.
5969         (minimal_symbol_reader::install): Update.
5970         (terminate_minimal_symbol_table): Remove.
5971         * jit.c (jit_object_close_impl): Update.
5972
5973 2019-03-15  Tom Tromey  <tom@tromey.com>
5974
5975         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5976         initializations.
5977
5978 2019-03-15  Tom Tromey  <tom@tromey.com>
5979
5980         * objfiles.h (struct objfile_per_bfd_storage)
5981         <demangled_hash_languages>: Now a bitset.
5982         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5983         (lookup_minimal_symbol): Update.
5984
5985 2019-03-15  Tom Tromey  <tom@tromey.com>
5986
5987         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5988         Don't return the symbol.
5989         * coffread.c (record_minimal_symbol): Use record_full.
5990
5991 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5992
5993         The MS-Windows port of ncurses fails to switch to a color pair if
5994         one or both of the colors are the implicit default colors.  This
5995         change records the default colors when TUI is initialized, and
5996         then specifies them explicitly when a color pair uses the default
5997         colors.  This allows color styling in TUI mode on MS-Windows.
5998
5999         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6000         ncurses_norm_attr.
6001         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6002         colors in ncurses_norm_attr.
6003         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6004         "none", replace it with the default color recorded in
6005         ncurses_norm_attr.
6006
6007 2019-03-14  Tom Tromey  <tromey@adacore.com>
6008
6009         * source-cache.h (class source_cache) <get_source_lines>: Return
6010         std::string.
6011         * source-cache.c (source_cache::extract_lines): Handle case where
6012         first_pos==npos.  Return std::string.
6013         (source_cache::get_source_lines): Update.
6014
6015 2019-03-14  Tom Tromey  <tromey@adacore.com>
6016
6017         * NEWS: Add item for "style sources" commands.
6018         * source-cache.c (source_cache::get_source_lines): Check
6019         source_styling.
6020         * cli/cli-style.c (source_styling): New global.
6021         (_initialize_cli_style): Add "style sources" commands.
6022         (show_style_sources): New function.
6023         * cli/cli-style.h (source_styling): Declare.
6024
6025 2019-03-14  Pedro Alves  <palves@redhat.com>
6026             Tom Tromey  <tromey@adacore.com>
6027
6028         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6029         * tui/tui-winsource.c (tui_refill_source_window): New function,
6030         from...
6031         (tui_horizontal_source_scroll): ... here.  Move some logic.
6032         * cli/cli-style.c (set_style_enabled): Notify new observable.
6033         * tui/tui-hooks.c (tui_redisplay_source): New function.
6034         (tui_attach_detach_observers): Attach or detach
6035         tui_redisplay_source.
6036         * observable.h (source_styling_changed): New observable.
6037         * observable.c: Define source_styling_changed observable.
6038
6039 2019-03-13  Tom Tromey  <tromey@adacore.com>
6040
6041         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6042         (i386_gnu_nat_target::store_registers): Update.
6043         * target-debug.h (target_debug_print_std_string): New macro.
6044         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6045         * windows-tdep.c (display_one_tib): Update.
6046         * tui/tui-stack.c (tui_make_status_line): Update.
6047         * top.c (print_inferior_quit_action): Update.
6048         * thread.c (thr_try_catch_cmd): Update.
6049         (add_thread_with_info): Update.
6050         (thread_target_id_str): Update.
6051         (thr_try_catch_cmd): Update.
6052         (thread_command): Update.
6053         (thread_find_command): Update.
6054         * record-btrace.c (record_btrace_target::info_record)
6055         (record_btrace_resume_thread, record_btrace_target::resume)
6056         (record_btrace_cancel_resume, record_btrace_step_thread)
6057         (record_btrace_target::wait, record_btrace_target::wait)
6058         (record_btrace_target::wait, record_btrace_target::stop): Update.
6059         * progspace.c (print_program_space): Update.
6060         * process-stratum-target.c
6061         (process_stratum_target::thread_address_space): Update.
6062         * linux-fork.c (linux_fork_mourn_inferior)
6063         (detach_checkpoint_command, info_checkpoints_command)
6064         (linux_fork_context): Update.
6065         (linux_fork_detach): Update.
6066         (class scoped_switch_fork_info): Update.
6067         (delete_checkpoint_command): Update.
6068         * infrun.c (follow_fork_inferior): Update.
6069         (follow_fork_inferior): Update.
6070         (proceed_after_vfork_done): Update.
6071         (handle_vfork_child_exec_or_exit): Update.
6072         (follow_exec): Update.
6073         (displaced_step_prepare_throw): Update.
6074         (displaced_step_restore): Update.
6075         (start_step_over): Update.
6076         (resume_1): Update.
6077         (clear_proceed_status_thread): Update.
6078         (proceed): Update.
6079         (print_target_wait_results): Update.
6080         (do_target_wait): Update.
6081         (context_switch): Update.
6082         (stop_all_threads): Update.
6083         (restart_threads): Update.
6084         (finish_step_over): Update.
6085         (handle_signal_stop): Update.
6086         (switch_back_to_stepped_thread): Update.
6087         (keep_going_pass_signal): Update.
6088         (print_exited_reason): Update.
6089         (normal_stop): Update.
6090         * inferior.c (inferior_pid_to_str): Change return type.
6091         (print_selected_inferior): Update.
6092         (add_inferior): Update.
6093         (detach_inferior): Update.
6094         * dummy-frame.c (fprint_dummy_frames): Update.
6095         * dcache.c (dcache_info_1): Update.
6096         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6097         (btrace_fetch, btrace_clear): Update.
6098         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6099         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6100         type.
6101         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6102         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6103         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6104         * gdbarch.c, gdbarch.h: Rebuild.
6105         * gdbarch.sh (core_pid_to_str): Change return type.
6106         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6107         return type.
6108         (windows_nat_target::pid_to_str): Change return type.
6109         (windows_delete_thread): Update.
6110         (windows_nat_target::attach): Update.
6111         (windows_nat_target::files_info): Update.
6112         * target-delegates.c: Rebuild.
6113         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6114         return type.
6115         (sol_thread_target::pid_to_str): Change return type.
6116         * remote.c (class remote_target) <pid_to_str>: Change return
6117         type.
6118         (remote_target::pid_to_str): Change return type.
6119         (extended_remote_target::attach, remote_target::remote_stop_ns)
6120         (remote_target::remote_notif_remove_queued_reply)
6121         (remote_target::push_stop_reply, remote_target::disable_btrace):
6122         Update.
6123         (extended_remote_target::attach): Update.
6124         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6125         type.
6126         (gdbsim_target::pid_to_str): Change return type.
6127         * ravenscar-thread.c (struct ravenscar_thread_target)
6128         <pid_to_str>: Change return type.
6129         (ravenscar_thread_target::pid_to_str): Change return type.
6130         * procfs.c (class procfs_target) <pid_to_str>: Change return
6131         type.
6132         (procfs_target::pid_to_str): Change return type.
6133         (procfs_target::attach): Update.
6134         (procfs_target::detach): Update.
6135         (procfs_target::fetch_registers): Update.
6136         (procfs_target::store_registers): Update.
6137         (procfs_target::wait): Update.
6138         (procfs_target::files_info): Update.
6139         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6140         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6141         return type.
6142         (nto_procfs_target::pid_to_str): Change return type.
6143         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6144         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6145         return type.
6146         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6147         (exit_lwp): Update.
6148         (attach_proc_task_lwp_callback, get_detach_signal)
6149         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6150         (linux_nat_target::resume, wait_lwp, stop_callback)
6151         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6152         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6153         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6154         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6155         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6156         type.
6157         (inf_ptrace_target::attach): Update.
6158         (inf_ptrace_target::files_info): Update.
6159         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6160         type.
6161         (go32_nat_target::pid_to_str): Change return type.
6162         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6163         (gnu_nat_target::wait): Update.
6164         (gnu_nat_target::wait): Update.
6165         (gnu_nat_target::resume): Update.
6166         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6167         (fbsd_nat_target::wait): Update.
6168         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6169         type.
6170         (darwin_nat_target::attach): Update.
6171         * corelow.c (class core_target) <pid_to_str>: Change return type.
6172         (core_target::pid_to_str): Change return type.
6173         * target.c (normal_pid_to_str): Change return type.
6174         (default_pid_to_str): Likewise.
6175         (target_pid_to_str): Change return type.
6176         (target_translate_tls_address): Update.
6177         (target_announce_detach): Update.
6178         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6179         return type.
6180         (bsd_uthread_target::pid_to_str): Change return type.
6181         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6182         type.
6183         (bsd_kvm_target::pid_to_str): Change return type.
6184         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6185         return type.
6186         (aix_thread_target::pid_to_str): Change return type.
6187         * target.h (struct target_ops) <pid_to_str>: Change return type.
6188         (target_pid_to_str, normal_pid_to_str): Likewise.
6189         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6190         type.
6191         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6192         type.
6193         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6194         return type.
6195         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6196         type.
6197         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6198         type.
6199         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6200         return type.
6201
6202 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6203
6204         * NEWS: Mention that the new default MI version is 3.  Mention
6205         changes to the output of commands and events that deal with
6206         multi-location breakpoints.
6207         * breakpoint.c: Include "mi/mi-out.h".
6208         (print_one_breakpoint): Change output syntax if using MI version
6209         >= 3.
6210         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6211         New.
6212         (mi_multi_location_breakpoint_output_fixed): New.
6213         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6214         (mi_cmd_fix_multi_location_breakpoint_output): New.
6215         (mi_multi_location_breakpoint_output_fixed): New.
6216         * mi/mi-cmds.c (mi_cmds): Register command
6217         -fix-multi-location-breakpoint-output.
6218         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6219         interpreter "mi".
6220
6221 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6222
6223         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6224         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6225         instantiate mi_ui_out based on interpreter name.
6226         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6227         * mi/mi-main.c (mi_load_progress): Likewise.
6228
6229 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6230
6231         * NEWS: Combine separate "New targets" sections for 8.3.
6232
6233 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6234
6235         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6236         (ppcfbsd_init_abi): Install gdbarch
6237         "fetch_tls_load_module_address" and "get_thread_local_address"
6238         methods.
6239
6240 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6241
6242         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6243         (riscv_fbsd_init_abi): Install gdbarch
6244         "fetch_tls_load_module_address" and "get_thread_local_address"
6245         methods.
6246
6247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6248
6249         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6250         (i386fbsd_init_abi): Install gdbarch
6251         "fetch_tls_load_module_address" and "get_thread_local_address"
6252         methods.
6253
6254 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6255
6256         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6257         (amd64fbsd_init_abi): Install gdbarch
6258         "fetch_tls_load_module_address" and "get_thread_local_address"
6259         methods.
6260
6261 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6262
6263         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6264         (struct fbsd_pspace_data): New type.
6265         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6266         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6267         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6268         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6269         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6270
6271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6272
6273         * gdbtypes.c (lookup_struct_elt): New function.
6274         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6275         * gdbtypes.h (struct struct_elt): New type.
6276         (lookup_struct_elt): New prototype.
6277
6278 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6279
6280         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6281         remove disabled code block.
6282
6283 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6284
6285         * gdbarch.sh (get_thread_local_address): New method.
6286         * gdbarch.h, gdbarch.c: Regenerate.
6287         * target.c (target_translate_tls_address): Use
6288         gdbarch_get_thread_local_address if present instead of
6289         target::get_thread_local_address.
6290
6291 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6292
6293         * target.h (target::get_thread_local_address): Update comment.
6294
6295 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6296
6297         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6298         objfile->separate_debug_objfile_backlink if not NULL.
6299
6300 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6301
6302         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6303         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6304         (amd64bsd_store_inferior_registers): Likewise.
6305         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6306         Enable segment base registers.
6307         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6308         PT_GETFSBASE and PT_GETGSBASE.
6309         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6310         PT_SETGSBASE.
6311         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6312         segment base registers.
6313         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6314
6315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6316
6317         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6318         Update calls to i386_target_description to add 'segments'
6319         parameter.
6320         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6321         add segment base registers.
6322         * arch/i386.c (i386_create_target_description): Add 'segments'
6323         parameter to enable segment base registers.
6324         * arch/i386.h (i386_create_target_description): Likewise.
6325         * features/i386/32bit-segments.xml: New file.
6326         * features/i386/32bit-segments.c: Generate.
6327         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6328         call to i386_target_description to add 'segments' parameter.
6329         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6330         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6331         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6332         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6333         if feature is present.
6334         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6335         Add 'segments' parameter to call to i386_target_description.
6336         (i386_target_description): Add 'segments' parameter to enable
6337         segment base registers.
6338         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6339         to call to i386_target_description.
6340         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6341         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6342         Define I386_NUM_REGS.
6343         (i386_target_description): Add 'segments' parameter to enable
6344         segment base registers.
6345
6346 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6347
6348         PR/24325
6349         * source-cache.c: #undef open and close, to avoid unresolved
6350         externals during linking.
6351
6352 2019-03-12  Tom Tromey  <tromey@adacore.com>
6353
6354         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6355         const.  Add initializers.
6356         (_initialize_remote): Don't initialize ptid globals.
6357
6358 2019-03-12  Pedro Alves  <palves@redhat.com>
6359
6360         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6361
6362 2019-03-12  Pedro Alves  <palves@redhat.com>
6363
6364         * cp-name-parser.y (main): Remove unused 'len' variable.
6365
6366 2019-03-12  Tom Tromey  <tromey@adacore.com>
6367
6368         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6369         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6370
6371 2019-03-12  Tom Tromey  <tromey@adacore.com>
6372
6373         * linux-nat.c (iterate_over_lwps): Update.
6374         (stop_callback): Remove parameter.
6375         (stop_wait_callback, detach_callback, resume_set_callback)
6376         (select_singlestep_lwp_callback, set_ignore_sigint)
6377         (status_callback, resumed_callback, resume_clear_callback)
6378         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6379         data parameter.
6380         (linux_nat_target::detach, linux_nat_target::resume)
6381         (linux_stop_and_wait_all_lwps, select_event_lwp)
6382         (linux_nat_filter_event, linux_nat_wait_1)
6383         (linux_nat_target::kill, linux_nat_target::stop)
6384         (linux_nat_target::stop): Update.
6385         (linux_nat_resume_callback): Change type.
6386         (resume_stopped_resumed_lwps, count_events_callback)
6387         (select_event_lwp_callback): Likewise.
6388         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6389         * arm-linux-nat.c (struct update_registers_data): Remove.
6390         (update_registers_callback): Change type.
6391         (arm_linux_insert_hw_breakpoint1): Update.
6392         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6393         parameter.
6394         (x86_linux_dr_set_addr): Update.
6395         (x86_linux_dr_set_control): Update.
6396         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6397         (iterate_over_lwps): Use gdb::function_view.
6398         * nat/aarch64-linux-hw-point.c (struct
6399         aarch64_dr_update_callback_param): Remove.
6400         (debug_reg_change_callback): Change type.
6401         (aarch64_notify_debug_reg_change): Update.
6402         * s390-linux-nat.c (s390_refresh_per_info): Update.
6403
6404 2019-03-11  Tom Tromey  <tromey@adacore.com>
6405
6406         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6407         redundant assignment to "this_cu".
6408
6409 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6410
6411         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6412
6413 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6414
6415         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6416         from...
6417         (rank_one_type): ... this.
6418
6419 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6420
6421         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6422         from...
6423         (rank_one_type): ... this.
6424
6425 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6426
6427         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6428         from...
6429         (rank_one_type): ... this.
6430
6431 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6432
6433         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6434         from...
6435         (rank_one_type): ... this.
6436
6437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6438
6439         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6440         from...
6441         (rank_one_type): ... this.
6442
6443 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6444
6445         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6446         from...
6447         (rank_one_type): ... this.
6448
6449 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6450
6451         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6452         from...
6453         (rank_one_type): ... this.
6454
6455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6456
6457         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6458         from...
6459         (rank_one_type): ... this.
6460
6461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6462
6463         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6464         from...
6465         (rank_one_type): ... this.
6466
6467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6468
6469         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6470         from...
6471         (rank_one_type): ... this.
6472
6473 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6474
6475         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6476         from...
6477         (rank_one_type): ... this.
6478
6479 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6480
6481         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6482         from...
6483         (rank_one_type): ... this.
6484
6485 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6486
6487         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6488         inferior-events' shows the example events.
6489
6490 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6491
6492         Support styling on native MS-Windows console
6493
6494         PR/24315
6495         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6496         on MS-Windows if $TERM is not defined.
6497
6498         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6499
6500         * posix-hdep.c (gdb_console_fputs):
6501         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6502         functions.
6503         * ui-file.h (gdb_console_fputs): Add prototype.
6504
6505         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6506         back to fputs only if the former returns zero.
6507
6508 2019-03-07  Tom Tromey  <tom@tromey.com>
6509
6510         * symmisc.c (print_symbol_bcache_statistics): Update.
6511         (print_objfile_statistics): Update.
6512         * symfile.c (allocate_symtab): Update.
6513         * stabsread.c: Don't include bcache.h.
6514         * psymtab.h (struct psymbol_bcache): Don't declare.
6515         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6516         (psymbol_bcache_init, psymbol_bcache_free)
6517         (psymbol_bcache_get_bcache): Don't declare.
6518         * psymtab.c (struct psymbol_bcache): Remove.
6519         (psymtab_storage::psymtab_storage): Update.
6520         (psymtab_storage::~psymtab_storage): Update.
6521         (psymbol_bcache_init, psymbol_bcache_free)
6522         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6523         (add_psymbol_to_bcache): Update.
6524         (allocate_psymtab): Update.
6525         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6526         macro_cache>: No longer pointers.
6527         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6528         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6529         * macrotab.c (macro_bcache): Update.
6530         * macroexp.c: Don't include bcache.h.
6531         * gdbtypes.c (check_types_worklist): Update.
6532         (types_deeply_equal): Remove TRY/CATCH.  Update.
6533         * elfread.c (elf_symtab_read): Update.
6534         * dwarf2read.c: Don't include bcache.h.
6535         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6536         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6537         (print_bcache_statistics, bcache_memory_used): Don't declare.
6538         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6539         methods.  Rename all data members.
6540         * bcache.c (struct bcache): Move to bcache.h.
6541         (bcache::expand_hash_table): Rename from expand_hash_table.
6542         (bcache): Remove.
6543         (bcache::insert): Rename from bcache_full.
6544         (bcache::compare): Rename from bcache_compare.
6545         (bcache_xmalloc): Remove.
6546         (bcache::~bcache): Rename from bcache_xfree.
6547         (bcache::print_statistics): Rename from print_bcache_statistics.
6548         (bcache::memory_used): Rename from bcache_memory_used.
6549
6550 2019-03-07  Pedro Alves  <palves@redhat.com>
6551
6552         * infrun.c (normal_stop): Also check for
6553         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6554
6555 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6556
6557         * f-lang.c (value_from_host_double): Moved to...
6558         * value.c (value_from_host_double): ...here.
6559         * value.h (value_from_host_double): Declare.
6560         * guile/scm-math.c (vlscm_convert_typed_number): Use
6561         value_from_host_double.
6562         (vlscm_convert_number): Likewise.
6563         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6564         * python/py-value.c (convert_value_from_python): Likewise.
6565
6566 2019-03-06  Tom Tromey  <tom@tromey.com>
6567
6568         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6569
6570 2019-03-06  Tom Tromey  <tom@tromey.com>
6571
6572         * utils.h (free_current_contents): Don't declare.
6573         * utils.c (free_current_contents): Remove.
6574
6575 2019-03-06  Tom Tromey  <tom@tromey.com>
6576
6577         * top.c (quit_force): Update.
6578         * main.c (captured_command_loop): Update.
6579         * common/new-op.c (operator new): Update.
6580         * common/common-exceptions.c (struct catcher)
6581         <save_cleanup_chain>: Remove member.
6582         (exceptions_state_mc_init): Update.
6583         (exception_try_scope_entry): Return nullptr.
6584         (exception_try_scope_exit, exception_rethrow)
6585         (throw_exception_sjlj, throw_exception_cxx): Update.
6586         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6587         (all_cleanups, do_cleanups, discard_cleanups)
6588         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6589         (restore_cleanups, restore_final_cleanups): Don't declare.
6590         (do_final_cleanups): Remove parameter.
6591         * common/cleanups.c (cleanup_chain, make_cleanup)
6592         (make_cleanup_dtor, all_cleanups, do_cleanups)
6593         (discard_my_cleanups, discard_cleanups)
6594         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6595         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6596         (null_cleanup): Remove.
6597         (do_final_cleanups): Remove parameter.
6598
6599 2019-03-06  Tom Tromey  <tom@tromey.com>
6600
6601         * remote.c (remote_target::remote_parse_stop_reply): Use
6602         unique_xmalloc_ptr.
6603
6604 2019-03-06  Tom Tromey  <tom@tromey.com>
6605
6606         * stabsread.c (struct stabs_field_info): Rename from field_info.
6607         <list, fnlist>: Add initializers.
6608         <obstack>: New member.
6609         (read_member_functions, read_struct_fields, read_baseclasses):
6610         Allocate on obstack.  Don't use cleanups.
6611         (read_one_struct_field, read_member_functions, read_struct_fields)
6612         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6613         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6614         (read_struct_type): Update.
6615
6616 2019-03-06  Tom Tromey  <tom@tromey.com>
6617
6618         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6619         * common/filestuff.h (make_cleanup_close): Don't declare.
6620         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6621         Remove.
6622
6623 2019-03-06  Tom Tromey  <tom@tromey.com>
6624
6625         * solib-aix.c: Use make_scope_exit.
6626
6627 2019-03-06  Tom Tromey  <tom@tromey.com>
6628
6629         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6630         Use make_scope_exit.
6631
6632 2019-03-06  Tom Tromey  <tom@tromey.com>
6633
6634         * solib-svr4.c (disable_probes_interface): Remove parameter.
6635         (svr4_handle_solib_event): Use make_scope_exit.
6636
6637 2019-03-06  Tom Tromey  <tom@tromey.com>
6638
6639         * remote.c (struct stop_reply_deleter): Remove.
6640         (stop_reply_up): Update.
6641         (struct stop_reply): Derive from notif_event.  Don't typedef.
6642         <regcache>: Now a std::vector.
6643         (stop_reply_xfree): Remove.
6644         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6645         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6646         (remote_target::discard_pending_stop_replies): Use delete.
6647         (remote_target::remote_parse_stop_reply): Update.
6648         (remote_target::process_stop_reply): Update.
6649         * remote-notif.h (struct notif_event): Add virtual destructor.
6650         Remove "dtr" member.
6651         (struct notif_client) <alloc_event>: Return a unique_ptr.
6652         (notif_event_xfree): Don't declare.
6653         (notif_event_up): New typedef.
6654         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6655         (notif_event_xfree, do_notif_event_xfree): Remove.
6656         (remote_notif_state_xfree): Update.
6657
6658 2019-03-06  Tom Tromey  <tom@tromey.com>
6659
6660         * infrun.c (displaced_step_clear_cleanup): Now a
6661         forward_scope_exit type.
6662         (displaced_step_prepare_throw): Update.
6663         (displaced_step_fixup): Update.
6664
6665 2019-03-06  Tom Tromey  <tom@tromey.com>
6666
6667         * inferior.h (class inferior): Update comment.
6668         * gdbthread.h (class thread_info): Update comment.
6669
6670 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6671             Tom Tromey  <tom@tromey.com>
6672
6673         * stabsread.h (struct stab_section_list): Remove.
6674         (coffstab_build_psymtabs): Update.
6675         * dbxread.c (symbuf_sections): Now a std::vector.
6676         (sect_idx): New global.
6677         (fill_symbuf): Update.
6678         (coffstab_build_psymtabs): Change type of stabsects parameter.
6679         Update.
6680         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6681         std::vector.
6682         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6683         (coff_locate_sections): Update.
6684         (coff_symfile_read): Remove cleanups.  Update.
6685         (init_stringtab): Add storage parameter.
6686         (free_stringtab, free_stringtab_cleanup): Remove.
6687         (init_lineno): Add storage parameter.
6688         (free_linetab, free_linetab_cleanup): Remove.
6689
6690 2019-03-06  Pedro Alves  <palves@redhat.com>
6691
6692         * linux-fork.c (fork_info::clobber_regs): Delete.
6693         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6694         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6695         comment.  Adjust.
6696         (scoped_switch_fork_info::scoped_switch_fork_info)
6697         (checkpoint_command, linux_fork_context): Adjust
6698         fork_save_infrun_state calls.
6699
6700 2019-03-06  Pedro Alves  <palves@redhat.com>
6701
6702         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6703         (inf_has_multiple_threads): Return 'bool' and rewrite using
6704         inferior_info::threads().
6705
6706 2019-03-06  Pedro Alves  <palves@redhat.com>
6707
6708         * linux-fork.c: Include <list>.
6709         (fork_list): Now a std::list instance.
6710         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6711         (forks_exist_p, find_last_fork): Adjust.
6712         (new_fork): Delete.
6713         (one_fork_p): New.
6714         (add_fork): Adjust.
6715         (free_fork): Delete, folded into fork_info::~fork_info().
6716         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6717         Adjust.
6718         (init_fork_list): Delete.
6719         (linux_fork_killall, linux_fork_mourn_inferior)
6720         (linux_fork_detach, info_checkpoints_command): Adjust.
6721         (_initialize_linux_fork): No longer call init_fork_list.
6722
6723 2019-03-06  Pedro Alves  <palves@redhat.com>
6724
6725         * linux-fork.c (new_fork): New, split out of ...
6726         (add_fork): ... this.  Return void.  Move "first fork" special
6727         case from here, to ...
6728         (checkpoint_command): ... here.
6729         * linux-linux.h (add_fork): Return void.
6730
6731 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6732
6733         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6734
6735 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6736             Chris January  <chris.january@arm.com>
6737             David Lecomber  <david.lecomber@arm.com>
6738
6739         * f-exp.y: New token, UNOP_INTRINSIC.
6740         (exp): New pattern using UNOP_INTRINSIC token.
6741         (f77_keywords): Add 'abs' keyword.
6742         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6743         (value_from_host_double): New function.
6744         (evaluate_subexp_f): Support UNOP_ABS.
6745
6746 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6747
6748         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6749         types.
6750
6751 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6752
6753         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6754         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6755         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6756
6757 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6758
6759         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6760
6761 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6762             Chris January  <chris.january@arm.com>
6763
6764         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6765         * f-exp.y: Define 'KIND' token.
6766         (exp): New pattern for KIND expressions.
6767         (ptype): Handle types with a kind extension.
6768         (direct_abs_decl): Extend to spot kind extensions.
6769         (f77_keywords): Add 'kind' to the list.
6770         (push_kind_type): New function.
6771         (convert_to_kind_type): New function.
6772         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6773         * parse.c (operator_length_standard): Likewise.
6774         * parser-defs.h (enum type_pieces): Add tp_kind.
6775         * std-operator.def: Add UNOP_KIND.
6776
6777 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6778
6779         * f-exp.y (f_parse): Set yydebug.
6780
6781 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6782
6783         * f-lang.c (evaluate_subexp_f): New function.
6784         (exp_descriptor_f): New global.
6785         (f_language_defn): Use exp_descriptor_f instead of
6786         exp_descriptor_standard.
6787
6788 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6789
6790         * f-exp.y (struct token): Add comments.
6791         (dot_ops): Remove uppercase versions and the end marker.
6792         (f77_keywords): Likewise.
6793         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6794         entries in the dot_ops array are case insensitive, and use
6795         strncasecmp to compare strings.  Also some whitespace cleanup in
6796         this area.  Similar for the f77_keywords array, except entries in
6797         this list might be case sensitive.
6798
6799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6800
6801         * f-exp.y (struct f77_boolean_val): Add comments.
6802         (boolean_values): Remove uppercase versions, and end marker.
6803         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6804         and use strncasecmp to achieve case insensitivity.  Additionally,
6805         perform whitespace cleanup around this code.
6806
6807 2019-03-06  Tom Tromey  <tromey@adacore.com>
6808
6809         * remote-sim.c (gdbsim_target_open): Use result of
6810         gdb_argv::release.
6811
6812 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6813         Dirk Schubert  <dirk.schubert@arm.com>
6814         Chris January  <chris.january@arm.com>
6815
6816         * eval.c (evaluate_subexp_standard): Call Fortran argument
6817         wrapping logic.
6818         * f-lang.c (struct value): A value which can be passed into a
6819         Fortran function call.
6820         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6821         where appropriate.
6822         (struct type): Value ready for a Fortran function call.
6823         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6824         is needed.
6825         * f-lang.h (fortran_argument_convert): Declaration.
6826         (fortran_preserve_arg_pointer): Declaration.
6827         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6828
6829 2019-03-05  Tom Tromey  <tromey@adacore.com>
6830
6831         * python/py-prettyprint.c (print_string_repr): Remove #if.
6832         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6833
6834 2019-03-05  Tom Tromey  <tromey@adacore.com>
6835
6836         * target.c (the_dummy_target): Move later.  Change type to
6837         "dummy_target".
6838         (initialize_targets): Don't initialize the_dummy_target.
6839
6840 2019-03-05  Tom Tromey  <tromey@adacore.com>
6841
6842         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6843         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6844
6845 2019-03-05  Tom Tromey  <tromey@adacore.com>
6846
6847         * windows-nat.c (windows_nat_target::attach)
6848         (windows_nat_target::detach): Don't call gdb_flush.
6849         * valprint.c (generic_val_print, val_print, val_print_string):
6850         Don't call gdb_flush.
6851         * utils.c (defaulted_query): Don't call gdb_flush.
6852         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6853         * target.c (target_announce_detach): Don't call gdb_flush.
6854         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6855         * remote.c (extended_remote_target::attach): Don't call
6856         gdb_flush.
6857         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6858         * printcmd.c (do_examine): Don't call gdb_flush.
6859         (info_display_command): Don't call gdb_flush.
6860         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6861         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6862         * memattr.c (info_mem_command): Don't call gdb_flush.
6863         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6864         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6865         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6866         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6867         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6868         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6869         (gnu_nat_target::detach): Don't call gdb_flush.
6870         * f-valprint.c (f_val_print): Don't call gdb_flush.
6871         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6872         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6873         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6874         gdb_flush.
6875         * c-valprint.c (c_val_print): Don't call gdb_flush.
6876         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6877
6878 2019-03-05  Tom Tromey  <tromey@adacore.com>
6879
6880         * varobj.c (update_dynamic_varobj_children): Update.
6881         (install_default_visualizer): Use reset, not release.
6882         * value.c (set_internalvar): Update.
6883         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6884         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6885         ATTRIBUTE_UNUSED_RESULT.
6886
6887 2019-03-05  Tom Tromey  <tromey@adacore.com>
6888
6889         * remote.c (class scoped_remote_fd) <release>: Add
6890         ATTRIBUTE_UNUSED_RESULT.
6891
6892 2019-03-05  Tom Tromey  <tromey@adacore.com>
6893
6894         * macroexp.c (struct macro_buffer) <release>: Add
6895         ATTRIBUTE_UNUSED_RESULT.
6896
6897 2019-03-05  Tom Tromey  <tromey@adacore.com>
6898
6899         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6900         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6901         ATTRIBUTE_UNUSED_RESULT.
6902
6903 2019-03-05  Tom Tromey  <tromey@adacore.com>
6904
6905         * common/scoped_fd.h (class scoped_fd) <release>: Add
6906         ATTRIBUTE_UNUSED_RESULT.
6907
6908 2019-03-05  Tom Tromey  <tromey@adacore.com>
6909
6910         * parser-defs.h (struct parser_state) <release>: Add
6911         ATTRIBUTE_UNUSED_RESULT.
6912
6913 2019-03-05  Tom Tromey  <tromey@adacore.com>
6914
6915         * utils.h (class gdb_argv) <release>: Add
6916         ATTRIBUTE_UNUSED_RESULT.
6917         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6918
6919 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6920
6921         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6922         for-loop range, to avoid compiler warnings.
6923
6924         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6925         avoid compiler warnings about unused variables.
6926
6927         * NEWS: Mention end of support for native debugging on MS-Windows
6928         before XP.
6929
6930         PR gdb/24292
6931         * common/netstuff.c:
6932         * gdbserver/gdbreplay.c
6933         * gdbserver/remote-utils.c:
6934         * ser-tcp.c:
6935         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6936         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6937         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6938         'getaddrinfo' and 'freeaddrinfo' were not available before
6939         Windows XP, and mingw.org's MinGW headers by default define
6940         _WIN32_WINNT to 0x500.
6941
6942 2019-03-01  Gary Benson <gbenson@redhat.com>
6943
6944         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6945
6946 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6947             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6948
6949         PR gdb/8527
6950         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6951         set_sigint_trap, clear_sigint_trap.
6952
6953 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6954
6955         * target.c (target_detach): Clear the regcache and the
6956         frame cache.
6957
6958 2019-02-27  Pedro Alves  <palves@redhat.com>
6959
6960         * utils.c (set_screen_size): When we cap the height/width sizes,
6961         tweak the corresponding command variable to show "unlimited":
6962
6963 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6964             Pedro Alves  <palves@redhat.com>
6965
6966         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6967         before calling rl_set_screen_size.
6968
6969 2019-02-27  Tom Tromey  <tromey@adacore.com>
6970
6971         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6972         define.
6973         * python/py-value.c: Remove Python 2.4 workaround.
6974         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6975         workaround.
6976         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6977         Python 2.4 workaround.
6978         * python/python-internal.h: Remove Python 2.4 comment.
6979         (Py_ssize_t): Don't define.
6980         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6981         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6982         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6983         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6984         * python/python.c (do_start_initialization): Remove Python 2.4
6985         workaround.
6986         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6987         (print_children): Remove Python 2.4 workaround.
6988         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6989         workaround.
6990         (CHARBUFFERPROC_NAME): Remove.
6991         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6992         Python 2.4 workaround.
6993
6994 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6995
6996         * NEWS: Note minimum Python version.
6997
6998 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6999
7000         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7001         code from these functions.  Remove corresponding ifdefs.  Use
7002         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7003         Remove gotos and target of gotos.
7004         (infpy_search_memory): Likewise.
7005
7006 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7007
7008         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7009         (hppa_gdbarch_init): Don't register deleted functions with
7010         gdbarch.
7011
7012 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7013
7014         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7015         (h8300_unwind_sp): Delete.
7016         (h8300_dummy_id): Delete.
7017         (h8300_gdbarch_init): Don't register deleted functions with
7018         gdbarch.
7019
7020 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7021
7022         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7023         (ft32_unwind_pc): Delete.
7024         (ft32_unwind_sp): Delete.
7025         (ft32_gdbarch_init): Don't register deleted functions with
7026         gdbarch.
7027
7028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7029
7030         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7031         (frv_unwind_pc): Delete.
7032         (frv_unwind_sp): Delete.
7033         (frv_gdbarch_init): Don't register deleted functions with
7034         gdbarch.
7035
7036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7037
7038         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7039         (riscv_unwind_pc): Delete.
7040         (riscv_unwind_sp): Delete.
7041         (riscv_gdbarch_init): Don't register deleted functions with
7042         gdbarch.
7043
7044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7045
7046         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7047         (csky_unwind_pc): Delete.
7048         (csky_unwind_sp): Delete.
7049         (csky_gdbarch_init): Don't register deleted functions with
7050         gdbarch.
7051
7052 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7053
7054         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7055         (cris_unwind_pc): Delete.
7056         (cris_unwind_sp): Delete.
7057         (cris_gdbarch_init): Don't register deleted functions with
7058         gdbarch.
7059
7060 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7061
7062         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7063         (bfin_unwind_pc): Delete.
7064         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7065
7066 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7067
7068         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7069         (arm_unwind_pc): Delete.
7070         (arm_unwind_sp): Delete.
7071         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7072
7073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7074
7075         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7076         (arc_unwind_pc): Delete.
7077         (arc_unwind_sp): Delete.
7078         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7079
7080 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7081
7082         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7083         (alpha_unwind_pc): Delete.
7084         (alpha_gdbarch_init): Don't register deleted functions with
7085         gdbarch.
7086
7087 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7088
7089         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7090         (aarch64_unwind_pc): Delete.
7091         (aarch64_unwind_sp): Delete.
7092         (aarch64_gdbarch_init): Don't register deleted functions with
7093         gdbarch.
7094
7095 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7096
7097         * gdbtypes.c (type_align): Don't consider static members when
7098         computing structure alignment.
7099
7100 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7101
7102         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7103         return 0 for other types.
7104         * arch-utils.c (default_type_align): Always return 0.
7105         * gdbarch.h: Regenerate.
7106         * gdbarch.sh (type_align): Extend comment.
7107         * gdbtypes.c (type_align): Add additional comments, always call
7108         gdbarch_type_align before applying the default rules.
7109         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7110         generic code will then apply a suitable default.
7111         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7112         types, return 0 for other types.
7113
7114 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7115
7116         * NEWS: Create a new section for the next release branch.
7117         Rename the section of the current branch, now that it has
7118         been cut.
7119
7120 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7121
7122         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7123         * version.in: Bump version to 8.3.50.DATE-git.
7124
7125 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7126
7127         * aix-thread.c (ptid_cmp): Remove unused variable.
7128         (get_signaled_thread): Likewise.
7129         (store_regs_user_thread): Likewise.
7130         (store_regs_kernel_thread): Likewise.
7131         (fetch_regs_kernel_thread): Remove shadowed variable.
7132
7133 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7134
7135         * features/riscv/32bit-cpu.xml: Add register numbers.
7136         * features/riscv/32bit-fpu.c: Regenerate.
7137         * features/riscv/32bit-fpu.xml: Add register numbers.
7138         * features/riscv/64bit-cpu.xml: Add register numbers.
7139         * features/riscv/64bit-fpu.c: Regenerate.
7140         * features/riscv/64bit-fpu.xml: Add register numbers.
7141
7142 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7143
7144         * NEWS: Mention two argument form of gdb.Value constructor.
7145         * python/py-value.c (convert_buffer_and_type_to_value): New
7146         function.
7147         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7148         Add support for handling an optional second argument.  Call
7149         convert_buffer_and_type_to_value as appropriate.
7150         * python/python-internal.h (Py_buffer_deleter): New struct.
7151         (Py_buffer_up): New typedef.
7152
7153 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7154
7155         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7156         instead of releasing ownership.
7157
7158 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7159
7160         * dwarf2read.c (open_and_init_dwp_file): Call
7161         elf_numsections instead of bfd_count_sections to initialize
7162         dwp_file->num_sections.
7163
7164 2019-02-25  Tom Tromey  <tromey@adacore.com>
7165
7166         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7167
7168 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7169
7170         * gcore.in: Add '--readnever' option when invoking GDB.
7171
7172 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7173
7174         * MAINTAINERS: Update my email address.
7175
7176 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7177
7178         * build-id.c (build_id_to_debug_bfd_1): New function.
7179         (build_id_to_debug_bfd): Look for separate debug file in
7180         sysroot.
7181
7182 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7183
7184         * gdbarch.sh: Update the copyright year range that is placed into
7185         generated files.
7186
7187 2019-02-22  Keith Seitz  <keiths@redhat.com>
7188
7189         PR symtab/23853
7190         * linespec.c (create_sals_line_offset): Search for the default
7191         symtab's filename instead of its fullname.
7192
7193 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7194
7195         * NEWS: Update style defaults.
7196
7197 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7198
7199         * main.c (captured_main_1): Disable styling in batch mode.
7200
7201 2019-02-20  Tom Tromey  <tom@tromey.com>
7202
7203         * symtab.c (symtab_symbol_info): Fix typos.
7204
7205 2019-02-20  Tom Tromey  <tromey@adacore.com>
7206
7207         * findcmd.c (_initialize_mem_search): Use upper case for
7208         metasyntactic variables.
7209
7210 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7211
7212         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7213         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7214
7215 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7216
7217         * top.h (source_file_name): Change to std::string.
7218         * top.c (source_file_name): Likewise.
7219         (command_line_input): Adjust.
7220         * cli/cli-script.c (script_from_file): Adjust.
7221
7222 2019-02-19  Tom Tromey  <tromey@adacore.com>
7223
7224         * ravenscar-thread.c
7225         (ravenscar_thread_target::update_thread_list): Don't call
7226         ada_build_task_list.
7227         * ada-lang.h (ada_build_task_list): Don't declare.
7228         * ada-tasks.c (struct ada_tasks_inferior_data)
7229         <task_list_valid_p>: Now bool.
7230         (read_known_tasks, ada_task_list_changed)
7231         (ada_tasks_invalidate_inferior_data): Update.
7232         (read_known_tasks_array): Return bool.
7233         (read_known_tasks_list): Likewise.
7234         (read_known_tasks): Return void.
7235         (ada_build_task_list): Now static.
7236
7237 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7238
7239         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7240         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7241
7242 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7243
7244         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7245         variant for ada_tasks_pspace_data_handle and
7246         ada_tasks_inferior_data_handle.
7247         (ada_tasks_pspace_data_cleanup): New function.
7248         (ada_tasks_inferior_data_cleanup): New function.
7249
7250 2019-02-17  Tom Tromey  <tom@tromey.com>
7251
7252         * macrotab.h (macro_source_fullname): Return a std::string.
7253         * macrotab.c (macro_include, check_for_redefinition)
7254         (macro_undef, macro_lookup_definition, foreach_macro)
7255         (foreach_macro_in_scope): Update.
7256         (macro_source_fullname): Return a std::string.
7257         * macrocmd.c (show_pp_source_pos): Update.
7258
7259 2019-02-17  Tom Tromey  <tom@tromey.com>
7260
7261         * macrocmd.c (show_pp_source_pos): Style the file names.
7262
7263 2019-02-17  Tom Tromey  <tom@tromey.com>
7264
7265         PR tui/24197:
7266         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7267
7268 2019-02-17  Tom Tromey  <tom@tromey.com>
7269
7270         * ada-lang.c (user_select_syms): Use filtered printing.
7271         * utils.c (wrap_style): New global.
7272         (desired_style): Remove.
7273         (emit_style_escape): Add stream parameter.
7274         (set_output_style, reset_terminal_style, prompt_for_continue):
7275         Update.
7276         (flush_wrap_buffer): Only flush gdb_stdout.
7277         (wrap_here): Set wrap_style.
7278         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7279         treat escape sequences as a character.  Change when wrap buffer is
7280         flushed.
7281         (fputs_styled): Do not set the output style when the default is
7282         requested.
7283         * ui-style.h (struct ui_file_style) <is_default>: New method.
7284         * source.c (print_source_lines_base): Emit escape sequences in one
7285         piece.
7286
7287 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7288
7289         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7290         integers and enumeration types.
7291
7292 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7293
7294         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7295         instead of lookup_symbol_in_language
7296         (do_exact_match): New function.
7297         (ada_get_symbol_name_matcher): Return do_exact_match when
7298         doing a verbatim match.
7299
7300 2019-02-15  Tom Tromey  <tromey@adacore.com>
7301
7302         * ravenscar-thread.c (ravenscar_thread_target::resume)
7303         (ravenscar_thread_target::wait): Special case wildcard requests.
7304
7305 2019-02-15  Tom Tromey  <tromey@adacore.com>
7306
7307         * ravenscar-thread.c (base_ptid): Remove.
7308         (struct ravenscar_thread_target) <close>: New method.
7309         <m_base_ptid>: New member.
7310         <update_inferior_ptid, active_task, task_is_currently_active,
7311         runtime_initialized>: Declare methods.
7312         <ravenscar_thread_target>: Add constructor.
7313         (ravenscar_thread_target::task_is_currently_active)
7314         (ravenscar_thread_target::update_inferior_ptid)
7315         (ravenscar_runtime_initialized): Rename.  Now methods.
7316         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7317         (ravenscar_thread_target::update_thread_list): Update.
7318         (ravenscar_thread_target::active_task): Now method.
7319         (ravenscar_thread_target::store_registers)
7320         (ravenscar_thread_target::prepare_to_store)
7321         (ravenscar_thread_target::prepare_to_store)
7322         (ravenscar_thread_target::mourn_inferior): Update.
7323         (ravenscar_inferior_created): Use "new" to create target.
7324         (ravenscar_thread_target::get_ada_task_ptid): Update.
7325         (_initialize_ravenscar): Don't initialize base_ptid.
7326         (ravenscar_ops): Remove global.
7327
7328 2019-02-15  Tom Tromey  <tromey@adacore.com>
7329
7330         * target.h (push_target): Declare new overload.
7331         * target.c (push_target): New overload, taking an rvalue reference.
7332         * remote.c (remote_target::open_1): Use push_target overload.
7333         * corelow.c (core_target_open): Use push_target overload.
7334
7335 2019-02-15  Tom Tromey  <tromey@adacore.com>
7336
7337         * ravenscar-thread.c (is_ravenscar_task)
7338         (ravenscar_task_is_currently_active): Return bool.
7339         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7340         (_initialize_ravenscar): Remove "(void)".
7341         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7342         Return bool.
7343
7344 2019-02-15  Tom Tromey  <tromey@adacore.com>
7345
7346         * ravenscar-thread.c (ravenscar_runtime_initializer)
7347         (has_ravenscar_runtime, get_running_thread_id)
7348         (ravenscar_thread_target::resume): Fix indentation.
7349
7350 2019-02-15  Tom Tromey  <tromey@adacore.com>
7351
7352         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7353         from ravenscar_arch_ops.
7354         (sparc_ravenscar_ops::fetch_registers)
7355         (sparc_ravenscar_ops::store_registers): Now methods.
7356         (sparc_ravenscar_prepare_to_store): Remove.
7357         (sparc_ravenscar_ops): Redefine.
7358         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7359         methods and destructor.  Remove members.
7360         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7361         (ravenscar_thread_target::store_registers)
7362         (ravenscar_thread_target::prepare_to_store): Update.
7363         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7364         Remove.
7365         (struct ppc_ravenscar_powerpc_ops): Derive from
7366         ravenscar_arch_ops.
7367         (ppc_ravenscar_powerpc_ops::fetch_registers)
7368         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7369         (ppc_ravenscar_powerpc_ops): Redefine.
7370         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7371         (ppc_ravenscar_e500_ops::fetch_registers)
7372         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7373         (ppc_ravenscar_e500_ops): Redefine.
7374         * aarch64-ravenscar-thread.c
7375         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7376         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7377         (aarch64_ravenscar_fetch_registers)
7378         (aarch64_ravenscar_store_registers): Now methods.
7379         (aarch64_ravenscar_ops): Redefine.
7380
7381 2019-02-15  Tom Tromey  <tromey@adacore.com>
7382
7383         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7384         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7385         (ravenscar_thread_target::stopped_by_watchpoint)
7386         (ravenscar_thread_target::stopped_data_address)
7387         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7388
7389 2019-02-15  Tom Tromey  <tromey@adacore.com>
7390
7391         * ravenscar-thread.c: Fix some typos.
7392
7393 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7394             Tom Tromey  <tromey@adacore.com>
7395
7396         * ada-lang.c (ada_exception_sal): Change addr_string to a
7397         std::string.
7398         (create_ada_exception_catchpoint): Update.
7399
7400 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7401             Tom Tromey  <tromey@adacore.com>
7402
7403         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7404         (bp_location_ops): Remove.
7405         (base_breakpoint_allocate_location): Update.
7406         (free_bp_location): Update.
7407         * ada-lang.c (class ada_catchpoint_location)
7408         <ada_catchpoint_location>: Remove ops parameter.
7409         (ada_catchpoint_location_dtor): Remove.
7410         (ada_catchpoint_location_ops): Remove.
7411         (allocate_location_exception): Update.
7412         * breakpoint.h (struct bp_location_ops): Remove.
7413         (class bp_location) <bp_location>: Remove bp_location_ops
7414         parameter.
7415         <~bp_location>: Add destructor.
7416         <ops>: Remove.
7417
7418 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7419             Pedro Alves  <palves@redhat.com>
7420
7421         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7422         'PATH_MAX'.
7423
7424 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7425             Samuel Thibault  <samuel.thibault@gnu.org>
7426             Thomas Schwinge  <thomas@codesourcery.com>
7427
7428         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7429         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7430
7431 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7432
7433         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7434         (check_empty): Use "const char *".
7435
7436         * gnu-nat.c (gnu_nat_target::detach): Instead of
7437         'detach_inferior (pid)' call
7438         'detach_inferior (find_inferior_pid (pid))'.
7439
7440         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7441         'nat/fork-inferior.o'.
7442         * gnu-nat.c: #include "nat/fork-inferior.h".
7443
7444         * gnu-nat.c (gnu_nat_target::detach): Instead of
7445         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7446         * gnu-nat.h: #include "inf-child.h".
7447         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7448         'i386_gnu_nat_target::fetch_registers'.
7449         (gnu_store_registers): Rename/move to
7450         'i386_gnu_nat_target::store_registers'.
7451
7452         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7453         * gnu-nat.h (mach_thread_info): New function.
7454         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7455
7456         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7457
7458 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7459
7460         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7461
7462 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7463
7464         * windows-nat.c (windows_add_thread): Add new parameter
7465         "main_thread_p" with default value set to false.  Update
7466         function documentation as well as all callers.
7467         (windows_delete_thread): Likewise.
7468         (fake_create_process): Update call to windows_add_thread.
7469         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7470         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7471         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7472         call to windows_delete_thread.
7473
7474 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7475
7476         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7477
7478 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7479
7480         * symfile.c (find_separate_debug_file): Use canonical path of
7481         sysroot with child_path instead of gdb_sysroot if it is valid.
7482
7483 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7484
7485         * symfile.c (find_separate_debug_file): Use child_path to
7486         determine if an object file is under a sysroot.
7487
7488 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7489
7490         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7491         unittests/child-path-selftests.c.
7492         * common/pathstuff.c (child_path): New function.
7493         * common/pathstuff.h (child_path): New prototype.
7494         * unittests/child-path-selftests.c: New file.
7495
7496 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7497
7498         * symfile.c (find_separate_debug_file): Look for separate debug
7499         files in debug directories under the sysroot.
7500
7501 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7502
7503         * symtab.h (struct minimal_symbol data_p): New const method.
7504         (struct minimal_symbol text_p): Likewise.
7505         * symtab.c (output_source_filename): Use file name style
7506         to print file name.
7507         (print_symbol_info): Likewise.
7508         (print_msymbol_info): Use address style to print addresses.
7509         Use function name style to print executable text symbols.
7510         (expand_symtab_containing_pc): Use data_p.
7511         (find_pc_sect_compunit_symtab): Likewise.
7512
7513 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7514
7515         * breakpoint.c (describe_other_breakpoints): Use address style
7516         to print addresses.
7517         (say_where): Likewise.
7518
7519 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7520
7521         * ada-typeprint.c (print_func_type): Print function name
7522         style to print function name.
7523         * c-typeprint.c (c_print_type_1): Likewise.
7524
7525 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7526
7527         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7528         for execve.
7529
7530 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7531
7532         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7533         type_stack.
7534
7535 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7536
7537         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7538         TYPE_CODE_REF types.
7539
7540 2019-02-08  Jim Wilson  <jimw@sifive.com>
7541
7542         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7543         (riscv_linux_fregset): New.
7544         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7545
7546 2019-02-07  Tom Tromey  <tom@tromey.com>
7547
7548         * thread.c (thread_cancel_execution_command): Update.
7549         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7550         methods.
7551         (struct thread_fsm_ops): Remove.
7552         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7553         (thread_fsm_should_stop, thread_fsm_return_value)
7554         (thread_fsm_set_finished, thread_fsm_finished_p)
7555         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7556         Don't declare.
7557         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7558         * infrun.c (clear_proceed_status_thread)
7559         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7560         (print_stop_event): Update.
7561         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7562         Add constructor.
7563         (step_command_fsm_ops): Remove.
7564         (new_step_command_fsm): Remove.
7565         (step_1): Update.
7566         (step_command_fsm::should_stop): Rename from
7567         step_command_fsm_should_stop.
7568         (step_command_fsm::clean_up): Rename from
7569         step_command_fsm_clean_up.
7570         (step_command_fsm::do_async_reply_reason): Rename from
7571         step_command_fsm_async_reply_reason.
7572         (struct until_next_fsm): Inherit from thread_fsm.  Add
7573         constructor.
7574         (until_next_fsm_ops): Remove.
7575         (new_until_next_fsm): Remove.
7576         (until_next_fsm::should_stop): Rename from
7577         until_next_fsm_should_stop.
7578         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7579         (until_next_fsm::do_async_reply_reason): Rename from
7580         until_next_fsm_async_reply_reason.
7581         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7582         constructor.  Change type of breakpoint.
7583         (finish_command_fsm_ops): Remove.
7584         (new_finish_command_fsm): Remove.
7585         (finish_command_fsm::should_stop): Rename from
7586         finish_command_fsm_should_stop.
7587         (finish_command_fsm::clean_up): Rename from
7588         finish_command_fsm_clean_up.
7589         (finish_command_fsm::return_value): Rename from
7590         finish_command_fsm_return_value.
7591         (finish_command_fsm::do_async_reply_reason): Rename from
7592         finish_command_fsm_async_reply_reason.
7593         (finish_command): Update.
7594         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7595         Add constructor.
7596         (call_thread_fsm_ops): Remove.
7597         (call_thread_fsm::call_thread_fsm): Rename from
7598         new_call_thread_fsm.
7599         (call_thread_fsm::should_stop): Rename from
7600         call_thread_fsm_should_stop.
7601         (call_thread_fsm::should_notify_stop): Rename from
7602         call_thread_fsm_should_notify_stop.
7603         (run_inferior_call, call_function_by_hand_dummy): Update.
7604         * cli/cli-interp.c (should_print_stop_to_console): Update.
7605         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7606         Add constructor.  Change type of location_breakpoint,
7607         caller_breakpoint.
7608         (until_break_fsm_ops): Remove.
7609         (new_until_break_fsm): Remove.
7610         (until_break_fsm::should_stop): Rename from
7611         until_break_fsm_should_stop.
7612         (until_break_fsm::clean_up): Rename from
7613         until_break_fsm_clean_up.
7614         (until_break_fsm::do_async_reply_reason): Rename from
7615         until_break_fsm_async_reply_reason.
7616         (until_break_command): Update.
7617         * thread-fsm.c: Remove.
7618         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7619
7620 2019-02-07  Tom Tromey  <tom@tromey.com>
7621
7622         * yy-remap.h: Add include guard.
7623         * xtensa-tdep.h: Add include guard.
7624         * xcoffread.h: Rename include guard.
7625         * varobj-iter.h: Add include guard.
7626         * tui/tui.h: Rename include guard.
7627         * tui/tui-winsource.h: Rename include guard.
7628         * tui/tui-wingeneral.h: Rename include guard.
7629         * tui/tui-windata.h: Rename include guard.
7630         * tui/tui-win.h: Rename include guard.
7631         * tui/tui-stack.h: Rename include guard.
7632         * tui/tui-source.h: Rename include guard.
7633         * tui/tui-regs.h: Rename include guard.
7634         * tui/tui-out.h: Rename include guard.
7635         * tui/tui-layout.h: Rename include guard.
7636         * tui/tui-io.h: Rename include guard.
7637         * tui/tui-hooks.h: Rename include guard.
7638         * tui/tui-file.h: Rename include guard.
7639         * tui/tui-disasm.h: Rename include guard.
7640         * tui/tui-data.h: Rename include guard.
7641         * tui/tui-command.h: Rename include guard.
7642         * tic6x-tdep.h: Add include guard.
7643         * target/waitstatus.h: Rename include guard.
7644         * target/wait.h: Rename include guard.
7645         * target/target.h: Rename include guard.
7646         * target/resume.h: Rename include guard.
7647         * target-float.h: Rename include guard.
7648         * stabsread.h: Add include guard.
7649         * rs6000-tdep.h: Add include guard.
7650         * riscv-fbsd-tdep.h: Add include guard.
7651         * regformats/regdef.h: Rename include guard.
7652         * record.h: Rename include guard.
7653         * python/python.h: Rename include guard.
7654         * python/python-internal.h: Rename include guard.
7655         * python/py-stopevent.h: Rename include guard.
7656         * python/py-ref.h: Rename include guard.
7657         * python/py-record.h: Rename include guard.
7658         * python/py-record-full.h: Rename include guard.
7659         * python/py-record-btrace.h: Rename include guard.
7660         * python/py-instruction.h: Rename include guard.
7661         * python/py-events.h: Rename include guard.
7662         * python/py-event.h: Rename include guard.
7663         * procfs.h: Add include guard.
7664         * proc-utils.h: Add include guard.
7665         * p-lang.h: Add include guard.
7666         * or1k-tdep.h: Rename include guard.
7667         * observable.h: Rename include guard.
7668         * nto-tdep.h: Rename include guard.
7669         * nat/x86-linux.h: Rename include guard.
7670         * nat/x86-linux-dregs.h: Rename include guard.
7671         * nat/x86-gcc-cpuid.h: Add include guard.
7672         * nat/x86-dregs.h: Rename include guard.
7673         * nat/x86-cpuid.h: Rename include guard.
7674         * nat/ppc-linux.h: Rename include guard.
7675         * nat/mips-linux-watch.h: Rename include guard.
7676         * nat/linux-waitpid.h: Rename include guard.
7677         * nat/linux-ptrace.h: Rename include guard.
7678         * nat/linux-procfs.h: Rename include guard.
7679         * nat/linux-osdata.h: Rename include guard.
7680         * nat/linux-nat.h: Rename include guard.
7681         * nat/linux-namespaces.h: Rename include guard.
7682         * nat/linux-btrace.h: Rename include guard.
7683         * nat/glibc_thread_db.h: Rename include guard.
7684         * nat/gdb_thread_db.h: Rename include guard.
7685         * nat/gdb_ptrace.h: Rename include guard.
7686         * nat/fork-inferior.h: Rename include guard.
7687         * nat/amd64-linux-siginfo.h: Rename include guard.
7688         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7689         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7690         * nat/aarch64-linux.h: Rename include guard.
7691         * nat/aarch64-linux-hw-point.h: Rename include guard.
7692         * mn10300-tdep.h: Add include guard.
7693         * mips-linux-tdep.h: Add include guard.
7694         * mi/mi-parse.h: Rename include guard.
7695         * mi/mi-out.h: Rename include guard.
7696         * mi/mi-main.h: Rename include guard.
7697         * mi/mi-interp.h: Rename include guard.
7698         * mi/mi-getopt.h: Rename include guard.
7699         * mi/mi-console.h: Rename include guard.
7700         * mi/mi-common.h: Rename include guard.
7701         * mi/mi-cmds.h: Rename include guard.
7702         * mi/mi-cmd-break.h: Rename include guard.
7703         * m2-lang.h: Add include guard.
7704         * location.h: Rename include guard.
7705         * linux-record.h: Rename include guard.
7706         * linux-nat.h: Add include guard.
7707         * linux-fork.h: Add include guard.
7708         * i386-darwin-tdep.h: Rename include guard.
7709         * hppa-linux-offsets.h: Add include guard.
7710         * guile/guile.h: Rename include guard.
7711         * guile/guile-internal.h: Rename include guard.
7712         * gnu-nat.h: Rename include guard.
7713         * gdb-stabs.h: Rename include guard.
7714         * frv-tdep.h: Add include guard.
7715         * f-lang.h: Add include guard.
7716         * event-loop.h: Add include guard.
7717         * darwin-nat.h: Rename include guard.
7718         * cp-abi.h: Rename include guard.
7719         * config/sparc/nm-sol2.h: Rename include guard.
7720         * config/nm-nto.h: Rename include guard.
7721         * config/nm-linux.h: Add include guard.
7722         * config/i386/nm-i386gnu.h: Rename include guard.
7723         * config/djgpp/nl_types.h: Rename include guard.
7724         * config/djgpp/langinfo.h: Rename include guard.
7725         * compile/gcc-cp-plugin.h: Add include guard.
7726         * compile/gcc-c-plugin.h: Add include guard.
7727         * compile/compile.h: Rename include guard.
7728         * compile/compile-object-run.h: Rename include guard.
7729         * compile/compile-object-load.h: Rename include guard.
7730         * compile/compile-internal.h: Rename include guard.
7731         * compile/compile-cplus.h: Rename include guard.
7732         * compile/compile-c.h: Rename include guard.
7733         * common/xml-utils.h: Rename include guard.
7734         * common/x86-xstate.h: Rename include guard.
7735         * common/version.h: Rename include guard.
7736         * common/vec.h: Rename include guard.
7737         * common/tdesc.h: Rename include guard.
7738         * common/selftest.h: Rename include guard.
7739         * common/scoped_restore.h: Rename include guard.
7740         * common/scoped_mmap.h: Rename include guard.
7741         * common/scoped_fd.h: Rename include guard.
7742         * common/safe-iterator.h: Rename include guard.
7743         * common/run-time-clock.h: Rename include guard.
7744         * common/refcounted-object.h: Rename include guard.
7745         * common/queue.h: Rename include guard.
7746         * common/ptid.h: Rename include guard.
7747         * common/print-utils.h: Rename include guard.
7748         * common/preprocessor.h: Rename include guard.
7749         * common/pathstuff.h: Rename include guard.
7750         * common/observable.h: Rename include guard.
7751         * common/netstuff.h: Rename include guard.
7752         * common/job-control.h: Rename include guard.
7753         * common/host-defs.h: Rename include guard.
7754         * common/gdb_wait.h: Rename include guard.
7755         * common/gdb_vecs.h: Rename include guard.
7756         * common/gdb_unlinker.h: Rename include guard.
7757         * common/gdb_unique_ptr.h: Rename include guard.
7758         * common/gdb_tilde_expand.h: Rename include guard.
7759         * common/gdb_sys_time.h: Rename include guard.
7760         * common/gdb_string_view.h: Rename include guard.
7761         * common/gdb_splay_tree.h: Rename include guard.
7762         * common/gdb_setjmp.h: Rename include guard.
7763         * common/gdb_ref_ptr.h: Rename include guard.
7764         * common/gdb_optional.h: Rename include guard.
7765         * common/gdb_locale.h: Rename include guard.
7766         * common/gdb_assert.h: Rename include guard.
7767         * common/filtered-iterator.h: Rename include guard.
7768         * common/filestuff.h: Rename include guard.
7769         * common/fileio.h: Rename include guard.
7770         * common/environ.h: Rename include guard.
7771         * common/common-utils.h: Rename include guard.
7772         * common/common-types.h: Rename include guard.
7773         * common/common-regcache.h: Rename include guard.
7774         * common/common-inferior.h: Rename include guard.
7775         * common/common-gdbthread.h: Rename include guard.
7776         * common/common-exceptions.h: Rename include guard.
7777         * common/common-defs.h: Rename include guard.
7778         * common/common-debug.h: Rename include guard.
7779         * common/cleanups.h: Rename include guard.
7780         * common/buffer.h: Rename include guard.
7781         * common/btrace-common.h: Rename include guard.
7782         * common/break-common.h: Rename include guard.
7783         * cli/cli-utils.h: Rename include guard.
7784         * cli/cli-style.h: Rename include guard.
7785         * cli/cli-setshow.h: Rename include guard.
7786         * cli/cli-script.h: Rename include guard.
7787         * cli/cli-interp.h: Rename include guard.
7788         * cli/cli-decode.h: Rename include guard.
7789         * cli/cli-cmds.h: Rename include guard.
7790         * charset-list.h: Add include guard.
7791         * buildsym-legacy.h: Rename include guard.
7792         * bfin-tdep.h: Add include guard.
7793         * ax.h: Rename include guard.
7794         * arm-linux-tdep.h: Add include guard.
7795         * arm-fbsd-tdep.h: Add include guard.
7796         * arch/xtensa.h: Rename include guard.
7797         * arch/tic6x.h: Add include guard.
7798         * arch/i386.h: Add include guard.
7799         * arch/arm.h: Rename include guard.
7800         * arch/arm-linux.h: Rename include guard.
7801         * arch/arm-get-next-pcs.h: Rename include guard.
7802         * arch/amd64.h: Add include guard.
7803         * arch/aarch64-insn.h: Rename include guard.
7804         * arch-utils.h: Rename include guard.
7805         * annotate.h: Add include guard.
7806         * amd64-darwin-tdep.h: Rename include guard.
7807         * aarch64-linux-tdep.h: Add include guard.
7808         * aarch64-fbsd-tdep.h: Add include guard.
7809         * aarch32-linux-nat.h: Add include guard.
7810
7811 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7812
7813         * macrotab.c (macro_define_internal): New function that
7814         factorizes macro_define_object_internal and macro_define_function
7815         code.
7816         (macro_define_object_internal): Use macro_define_internal.
7817         (macro_define_function): Likewise.
7818
7819 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7820
7821         * macrocmd.c (extract_identifier): Return
7822         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7823         callers.
7824
7825 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7826
7827         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7828
7829 2019-02-05  Tom Tromey  <tom@tromey.com>
7830
7831         * target.c (target_stack::unpush): Move assertion earlier.
7832
7833 2019-01-30  Tom Tromey  <tom@tromey.com>
7834
7835         PR python/23615:
7836         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7837         (gdbpy_parse_and_eval): Likewise.
7838         * python/python-internal.h (gdbpy_allow_threads): New class.
7839
7840 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7841
7842         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7843         (aarch64_fbsd_fpregmap): Move earlier.
7844         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7845         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7846         instead of individual calls to trad_frame_set_reg_addr.
7847         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7848         earlier.
7849         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7850         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7851         instead of individual calls to trad_frame_set_reg_addr.
7852
7853 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7854
7855         * CONTRIBUTE: Replace contribution list with wiki link.
7856
7857 2019-01-25  Tom Tromey  <tom@tromey.com>
7858
7859         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7860
7861 2019-01-25  Tom Tromey  <tom@tromey.com>
7862
7863         * xtensa-linux-nat.c: Fix common/ includes.
7864         * xml-support.h: Fix common/ includes.
7865         * xml-support.c: Fix common/ includes.
7866         * x86-linux-nat.c: Fix common/ includes.
7867         * windows-nat.c: Fix common/ includes.
7868         * varobj.h: Fix common/ includes.
7869         * varobj.c: Fix common/ includes.
7870         * value.c: Fix common/ includes.
7871         * valops.c: Fix common/ includes.
7872         * utils.c: Fix common/ includes.
7873         * unittests/xml-utils-selftests.c: Fix common/ includes.
7874         * unittests/utils-selftests.c: Fix common/ includes.
7875         * unittests/unpack-selftests.c: Fix common/ includes.
7876         * unittests/tracepoint-selftests.c: Fix common/ includes.
7877         * unittests/style-selftests.c: Fix common/ includes.
7878         * unittests/string_view-selftests.c: Fix common/ includes.
7879         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7880         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7881         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7882         * unittests/rsp-low-selftests.c: Fix common/ includes.
7883         * unittests/parse-connection-spec-selftests.c: Fix common/
7884         includes.
7885         * unittests/optional-selftests.c: Fix common/ includes.
7886         * unittests/offset-type-selftests.c: Fix common/ includes.
7887         * unittests/observable-selftests.c: Fix common/ includes.
7888         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7889         * unittests/memrange-selftests.c: Fix common/ includes.
7890         * unittests/memory-map-selftests.c: Fix common/ includes.
7891         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7892         * unittests/function-view-selftests.c: Fix common/ includes.
7893         * unittests/environ-selftests.c: Fix common/ includes.
7894         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7895         * unittests/common-utils-selftests.c: Fix common/ includes.
7896         * unittests/cli-utils-selftests.c: Fix common/ includes.
7897         * unittests/array-view-selftests.c: Fix common/ includes.
7898         * ui-file.c: Fix common/ includes.
7899         * tui/tui-io.c: Fix common/ includes.
7900         * tracepoint.h: Fix common/ includes.
7901         * tracepoint.c: Fix common/ includes.
7902         * tracefile-tfile.c: Fix common/ includes.
7903         * top.h: Fix common/ includes.
7904         * top.c: Fix common/ includes.
7905         * thread.c: Fix common/ includes.
7906         * target/waitstatus.h: Fix common/ includes.
7907         * target/waitstatus.c: Fix common/ includes.
7908         * target.h: Fix common/ includes.
7909         * target.c: Fix common/ includes.
7910         * target-memory.c: Fix common/ includes.
7911         * target-descriptions.c: Fix common/ includes.
7912         * symtab.h: Fix common/ includes.
7913         * symfile.c: Fix common/ includes.
7914         * stap-probe.c: Fix common/ includes.
7915         * spu-linux-nat.c: Fix common/ includes.
7916         * sparc-nat.c: Fix common/ includes.
7917         * source.c: Fix common/ includes.
7918         * solib.c: Fix common/ includes.
7919         * solib-target.c: Fix common/ includes.
7920         * ser-unix.c: Fix common/ includes.
7921         * ser-tcp.c: Fix common/ includes.
7922         * ser-pipe.c: Fix common/ includes.
7923         * ser-base.c: Fix common/ includes.
7924         * selftest-arch.c: Fix common/ includes.
7925         * s12z-tdep.c: Fix common/ includes.
7926         * rust-exp.y: Fix common/ includes.
7927         * rs6000-aix-tdep.c: Fix common/ includes.
7928         * riscv-tdep.c: Fix common/ includes.
7929         * remote.c: Fix common/ includes.
7930         * remote-notif.h: Fix common/ includes.
7931         * remote-fileio.h: Fix common/ includes.
7932         * remote-fileio.c: Fix common/ includes.
7933         * regcache.h: Fix common/ includes.
7934         * regcache.c: Fix common/ includes.
7935         * record-btrace.c: Fix common/ includes.
7936         * python/python.c: Fix common/ includes.
7937         * python/py-type.c: Fix common/ includes.
7938         * python/py-inferior.c: Fix common/ includes.
7939         * progspace.h: Fix common/ includes.
7940         * producer.c: Fix common/ includes.
7941         * procfs.c: Fix common/ includes.
7942         * proc-api.c: Fix common/ includes.
7943         * printcmd.c: Fix common/ includes.
7944         * ppc-linux-nat.c: Fix common/ includes.
7945         * parser-defs.h: Fix common/ includes.
7946         * osdata.c: Fix common/ includes.
7947         * obsd-nat.c: Fix common/ includes.
7948         * nat/x86-linux.c: Fix common/ includes.
7949         * nat/x86-linux-dregs.c: Fix common/ includes.
7950         * nat/x86-dregs.h: Fix common/ includes.
7951         * nat/x86-dregs.c: Fix common/ includes.
7952         * nat/ppc-linux.c: Fix common/ includes.
7953         * nat/mips-linux-watch.h: Fix common/ includes.
7954         * nat/mips-linux-watch.c: Fix common/ includes.
7955         * nat/linux-waitpid.c: Fix common/ includes.
7956         * nat/linux-ptrace.h: Fix common/ includes.
7957         * nat/linux-ptrace.c: Fix common/ includes.
7958         * nat/linux-procfs.c: Fix common/ includes.
7959         * nat/linux-personality.c: Fix common/ includes.
7960         * nat/linux-osdata.c: Fix common/ includes.
7961         * nat/linux-namespaces.c: Fix common/ includes.
7962         * nat/linux-btrace.h: Fix common/ includes.
7963         * nat/linux-btrace.c: Fix common/ includes.
7964         * nat/fork-inferior.c: Fix common/ includes.
7965         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7966         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7967         * nat/aarch64-linux.c: Fix common/ includes.
7968         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7969         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7970         * namespace.h: Fix common/ includes.
7971         * mips-linux-tdep.c: Fix common/ includes.
7972         * minsyms.c: Fix common/ includes.
7973         * mi/mi-parse.h: Fix common/ includes.
7974         * mi/mi-main.c: Fix common/ includes.
7975         * mi/mi-cmd-env.c: Fix common/ includes.
7976         * memrange.h: Fix common/ includes.
7977         * memattr.c: Fix common/ includes.
7978         * maint.h: Fix common/ includes.
7979         * maint.c: Fix common/ includes.
7980         * main.c: Fix common/ includes.
7981         * machoread.c: Fix common/ includes.
7982         * location.c: Fix common/ includes.
7983         * linux-thread-db.c: Fix common/ includes.
7984         * linux-nat.c: Fix common/ includes.
7985         * linux-fork.c: Fix common/ includes.
7986         * inline-frame.c: Fix common/ includes.
7987         * infrun.c: Fix common/ includes.
7988         * inflow.c: Fix common/ includes.
7989         * inferior.h: Fix common/ includes.
7990         * inferior.c: Fix common/ includes.
7991         * infcmd.c: Fix common/ includes.
7992         * inf-ptrace.c: Fix common/ includes.
7993         * inf-child.c: Fix common/ includes.
7994         * ia64-linux-nat.c: Fix common/ includes.
7995         * i387-tdep.c: Fix common/ includes.
7996         * i386-tdep.c: Fix common/ includes.
7997         * i386-linux-tdep.c: Fix common/ includes.
7998         * i386-linux-nat.c: Fix common/ includes.
7999         * i386-go32-tdep.c: Fix common/ includes.
8000         * i386-fbsd-tdep.c: Fix common/ includes.
8001         * i386-fbsd-nat.c: Fix common/ includes.
8002         * guile/scm-type.c: Fix common/ includes.
8003         * guile/guile.c: Fix common/ includes.
8004         * go32-nat.c: Fix common/ includes.
8005         * gnu-nat.c: Fix common/ includes.
8006         * gdbthread.h: Fix common/ includes.
8007         * gdbarch-selftests.c: Fix common/ includes.
8008         * gdb_usleep.c: Fix common/ includes.
8009         * gdb_select.h: Fix common/ includes.
8010         * gdb_bfd.c: Fix common/ includes.
8011         * gcore.c: Fix common/ includes.
8012         * fork-child.c: Fix common/ includes.
8013         * findvar.c: Fix common/ includes.
8014         * fbsd-nat.c: Fix common/ includes.
8015         * event-top.c: Fix common/ includes.
8016         * event-loop.c: Fix common/ includes.
8017         * dwarf2read.c: Fix common/ includes.
8018         * dwarf2loc.c: Fix common/ includes.
8019         * dwarf2-frame.c: Fix common/ includes.
8020         * dwarf-index-cache.c: Fix common/ includes.
8021         * dtrace-probe.c: Fix common/ includes.
8022         * disasm-selftests.c: Fix common/ includes.
8023         * defs.h: Fix common/ includes.
8024         * csky-tdep.c: Fix common/ includes.
8025         * cp-valprint.c: Fix common/ includes.
8026         * cp-support.h: Fix common/ includes.
8027         * cp-support.c: Fix common/ includes.
8028         * corelow.c: Fix common/ includes.
8029         * completer.h: Fix common/ includes.
8030         * completer.c: Fix common/ includes.
8031         * compile/compile.c: Fix common/ includes.
8032         * compile/compile-loc2c.c: Fix common/ includes.
8033         * compile/compile-cplus-types.c: Fix common/ includes.
8034         * compile/compile-cplus-symbols.c: Fix common/ includes.
8035         * command.h: Fix common/ includes.
8036         * cli/cli-dump.c: Fix common/ includes.
8037         * cli/cli-cmds.c: Fix common/ includes.
8038         * charset.c: Fix common/ includes.
8039         * build-id.c: Fix common/ includes.
8040         * btrace.h: Fix common/ includes.
8041         * btrace.c: Fix common/ includes.
8042         * breakpoint.h: Fix common/ includes.
8043         * breakpoint.c: Fix common/ includes.
8044         * ax.h:
8045         (enum agent_op): Fix common/ includes.
8046         * ax-general.c (struct aop_map): Fix common/ includes.
8047         * ax-gdb.c: Fix common/ includes.
8048         * auxv.c: Fix common/ includes.
8049         * auto-load.c: Fix common/ includes.
8050         * arm-tdep.c: Fix common/ includes.
8051         * arch/riscv.c: Fix common/ includes.
8052         * arch/ppc-linux-common.c: Fix common/ includes.
8053         * arch/i386.c: Fix common/ includes.
8054         * arch/arm.c: Fix common/ includes.
8055         * arch/arm-linux.c: Fix common/ includes.
8056         * arch/arm-get-next-pcs.c: Fix common/ includes.
8057         * arch/amd64.c: Fix common/ includes.
8058         * arch/aarch64.c: Fix common/ includes.
8059         * arch/aarch64-insn.c: Fix common/ includes.
8060         * arch-utils.c: Fix common/ includes.
8061         * amd64-windows-tdep.c: Fix common/ includes.
8062         * amd64-tdep.c: Fix common/ includes.
8063         * amd64-sol2-tdep.c: Fix common/ includes.
8064         * amd64-obsd-tdep.c: Fix common/ includes.
8065         * amd64-nbsd-tdep.c: Fix common/ includes.
8066         * amd64-linux-tdep.c: Fix common/ includes.
8067         * amd64-linux-nat.c: Fix common/ includes.
8068         * amd64-fbsd-tdep.c: Fix common/ includes.
8069         * amd64-fbsd-nat.c: Fix common/ includes.
8070         * amd64-dicos-tdep.c: Fix common/ includes.
8071         * amd64-darwin-tdep.c: Fix common/ includes.
8072         * agent.c: Fix common/ includes.
8073         * ada-lang.h: Fix common/ includes.
8074         * ada-lang.c: Fix common/ includes.
8075         * aarch64-tdep.c: Fix common/ includes.
8076
8077 2019-01-25  Tom Tromey  <tom@tromey.com>
8078
8079         * common/create-version.sh: Use common/version.h.
8080
8081 2019-01-24  Pedro Alves  <palves@redhat.com>
8082
8083         * infrun.c (signal_stop, signal_print, signal_program)
8084         (signal_catch, signal_pass): Now arrays instead of pointers.
8085         (update_signals_program_target, do_target_resume)
8086         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8087         * linux-nat.c (linux_nat_target::pass_signals)
8088         (linux_nat_target::create_inferior, linux_nat_target::attach):
8089         Adjust.
8090         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8091         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8092         * procfs.c (procfs_target::pass_signals): Adjust.
8093         * record-full.c (record_full_target::resume): Adjust.
8094         * remote.c (remote_target::pass_signals)
8095         (remote_target::program_signals): Adjust.
8096         * target-debug.h (target_debug_print_signals): Now takes a
8097         gdb::array_view as parameter.  Adjust.
8098         * target.h (target_ops) <pass_signals, program_signals>: Replace
8099         pointer and length parameters with gdb::array_view.
8100         (target_pass_signals, target_program_signals): Likewise.
8101         * target-delegates.c: Regenerate.
8102
8103 2019-01-24  Pedro Alves  <palves@redhat.com>
8104
8105         * common/forward-scope-exit.h
8106         (forward_scope_exit::forward_scope_exit): Pass arguments to
8107         m_bind_function directly, instead of creating a std::bind and
8108         copying that.
8109
8110 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8111
8112         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8113         for static members.
8114         (pass_in_v_vfp_candidate): Likewise.
8115
8116 2019-01-23  Tom Tromey  <tom@tromey.com>
8117             Pedro Alves  <palves@redhat.com>
8118
8119         * regcache.c (class regcache_invalidator): Remove.
8120         (regcache::raw_write): Use make_scope_exit.
8121
8122 2019-01-23  Tom Tromey  <tom@tromey.com>
8123
8124         * ui-out.h (class ui_out_emit_type): Update comment.
8125
8126 2019-01-23  Tom Tromey  <tom@tromey.com>
8127
8128         * infrun.c (fetch_inferior_event): Update comment.
8129
8130 2019-01-23  Tom Tromey  <tom@tromey.com>
8131             Pedro Alves  <palves@redhat.com>
8132
8133         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8134         parameter.
8135         (fetch_inferior_event): Use SCOPE_EXIT.
8136
8137
8138 2019-01-23  Tom Tromey  <tom@tromey.com>
8139             Pedro Alves  <palves@redhat.com>
8140
8141         * infrun.c (disable_thread_events): Delete.
8142         (stop_all_threads): Use SCOPE_EXIT.
8143
8144 2019-01-23  Tom Tromey  <tom@tromey.com>
8145             Pedro Alves  <palves@redhat.com>
8146
8147         * symfile.c: Include forward-scope-exit.h.
8148         (clear_symtab_users_cleanup): Replace forward declaration with
8149         a FORWARD_SCOPE_EXIT.
8150         (syms_from_objfile_1): Use the forward_scope_exit and
8151         gdb::optional instead of cleanup_function.
8152         (reread_symbols): Use the forward_scope_exit instead of
8153         cleanup_function.
8154         (clear_symtab_users_cleanup): Remove function.
8155
8156 2019-01-23  Tom Tromey  <tom@tromey.com>
8157             Pedro Alves  <palves@redhat.com>
8158
8159         * linux-nat.c: Include scope-exit.h.
8160         (cleanup_target_stop): Remove.
8161         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8162         SCOPE_EXIT.
8163
8164 2019-01-23  Tom Tromey  <tom@tromey.com>
8165             Pedro Alves  <palves@redhat.com>
8166
8167         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8168         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8169
8170 2019-01-23  Tom Tromey  <tom@tromey.com>
8171             Andrew Burgess  <andrew.burgess@embecosm.com>
8172             Pedro Alves  <palves@redhat.com>
8173
8174         * infrun.c (fetch_inferior_event): Use scope_exit.
8175         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8176         * top.c (execute_command): Use scope_exit.
8177         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8178         * utils.c (do_bpstat_clear_actions_cleanup)
8179         (make_bpstat_clear_actions_cleanup): Remove.
8180
8181 2019-01-23  Tom Tromey  <tom@tromey.com>
8182             Pedro Alves  <palves@redhat.com>
8183
8184         * infrun.c: Include "common/scope-exit.h"
8185         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8186         (wait_for_inferior): Use SCOPE_EXIT.
8187         (fetch_inferior_event): Use scope_exit.
8188
8189 2019-01-23  Tom Tromey  <tom@tromey.com>
8190             Pedro Alves  <palves@redhat.com>
8191
8192         * breakpoint.c (create_breakpoint): Remove cleanup.
8193
8194 2019-01-23  Tom Tromey  <tom@tromey.com>
8195             Andrew Burgess  <andrew.burgess@embecosm.com>
8196             Pedro Alves  <palves@redhat.com>
8197
8198 2019-01-23  Pedro Alves  <palves@redhat.com>
8199
8200         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8201
8202 2019-01-23  Pedro Alves  <palves@redhat.com>
8203             Andrew Burgess  <andrew.burgess@embecosm.com>
8204
8205         * gdbthread.h: Include "common/forward-scope-exit.h".
8206         (scoped_finish_thread_state): Redefine custom class in terms of
8207         forward_scope_exit.
8208
8209 2019-01-23  Pedro Alves  <palves@redhat.com>
8210             Andrew Burgess  <andrew.burgess@embecosm.com>
8211
8212         * common/forward-scope-exit.h: New file.
8213
8214 2019-01-23  Pedro Alves  <palves@redhat.com>
8215             Andrew Burgess  <andrew.burgess@embecosm.com>
8216             Tom Tromey  <tom@tromey.com>
8217
8218         * common/scope-exit.h: New file.
8219
8220 2019-01-23  Pedro Alves  <palves@redhat.com>
8221
8222         * common/preprocessor.h (ESC): Rename to ...
8223         (ESC_PARENS): ... this.
8224         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8225         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8226
8227 2019-01-23  Tom Tromey  <tom@tromey.com>
8228
8229         * language.h (class scoped_switch_to_sym_language_if_auto):
8230         Initialize m_lang in both cases.
8231
8232 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8233
8234         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8235         with XCNEW.
8236
8237 2019-01-22  Tom Tromey  <tom@tromey.com>
8238
8239         * corelow.c: Do not include sys/file.h.
8240
8241 2019-01-22  Tom Tromey  <tom@tromey.com>
8242
8243         * tui/tui-wingeneral.h: Include gdb_curses.h.
8244
8245 2019-01-22  Tom Tromey  <tom@tromey.com>
8246
8247         * source-cache.h (class source_cache) <get_source_lines,
8248         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8249
8250 2019-01-22  Tom Tromey  <tom@tromey.com>
8251
8252         * remote-fileio.h (struct remote_target): Declare.
8253
8254 2019-01-22  Tom Tromey  <tom@tromey.com>
8255
8256         * python/py-arch.c: Do not include py-ref.h.
8257         * python/py-bpevent.c: Do not include py-ref.h.
8258         * python/py-cmd.c: Do not include py-ref.h.
8259         * python/py-continueevent.c: Do not include py-ref.h.
8260         * python/py-event.h: Do not include py-ref.h.
8261         * python/py-evtregistry.c: Do not include py-ref.h.
8262         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8263         * python/py-frame.c: Do not include py-ref.h.
8264         * python/py-framefilter.c: Do not include py-ref.h.
8265         * python/py-function.c: Do not include py-ref.h.
8266         * python/py-infevents.c: Do not include py-ref.h.
8267         * python/py-linetable.c: Do not include py-ref.h.
8268         * python/py-objfile.c: Do not include py-ref.h.
8269         * python/py-param.c: Do not include py-ref.h.
8270         * python/py-prettyprint.c: Do not include py-ref.h.
8271         * python/py-progspace.c: Do not include py-ref.h.
8272         * python/py-symbol.c: Do not include py-ref.h.
8273         * python/py-symtab.c: Do not include py-ref.h.
8274         * python/py-type.c: Do not include py-ref.h.
8275         * python/py-unwind.c: Do not include py-ref.h.
8276         * python/py-utils.c: Do not include py-ref.h.
8277         * python/py-value.c: Do not include py-ref.h.
8278         * python/py-varobj.c: Do not include py-ref.h.
8279         * python/py-xmethods.c: Do not include py-ref.h.
8280         * python/python.c: Do not include py-ref.h.
8281         * varobj.c: Do not include py-ref.h.
8282
8283 2019-01-22  Tom Tromey  <tom@tromey.com>
8284
8285         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8286         keyword for bcache.
8287
8288 2019-01-22  Tom Tromey  <tom@tromey.com>
8289
8290         * compile/compile-cplus-types.c: Remove a comment by #include.
8291
8292 2019-01-22  Tom Tromey  <tom@tromey.com>
8293
8294         * compile/gcc-c-plugin.h: Include compile-internal.h.
8295
8296 2019-01-22  Tom Tromey  <tom@tromey.com>
8297
8298         * stabsread.c (EXTERN): Do not define.
8299         (symnum, next_symbol_text_func, processing_gcc_compilation)
8300         (within_function, global_sym_chain, global_stabs)
8301         (previous_stab_code, this_object_header_files)
8302         (n_this_object_header_files)
8303         (n_allocated_this_object_header_files): Define.
8304         * stabsread.h (EXTERN): Never define.  Use "extern".
8305
8306 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8307
8308         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8309         history_value.
8310
8311 2019-01-21  Tom Tromey  <tom@tromey.com>
8312
8313         * ui-out.c: Fix includes.
8314         * tui/tui-source.c: Fix includes.
8315         * target.c: Fix includes.
8316         * remote.c: Fix includes.
8317         * regcache.c: Fix includes.
8318         * python/py-block.c: Fix includes.
8319         * printcmd.c: Fix includes.
8320         * or1k-tdep.c: Fix includes.
8321         * mi/mi-main.c: Fix includes.
8322         * m32r-tdep.c: Fix includes.
8323         * csky-tdep.c: Fix includes.
8324         * compile/compile-cplus-types.c: Fix includes.
8325         * cli/cli-interp.c: Fix includes.
8326
8327 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8328
8329         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8330         for padding.
8331
8332 2019-01-16  Tom Tromey  <tom@tromey.com>
8333
8334         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8335         earlier.
8336         (struct objfile) <msymbols_range>: Move from top level.
8337         <msymbols>: New method.
8338         (class objfile_msymbols): Remove.
8339         * symtab.c (default_collect_symbol_completion_matches_break_on):
8340         Update.
8341         * symmisc.c (dump_msymbols): Update.
8342         * stabsread.c (scan_file_globals): Update.
8343         * objc-lang.c (info_selectors_command, info_classes_command)
8344         (find_methods): Update.
8345         * minsyms.c (find_solib_trampoline_target): Update.
8346         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8347         * coffread.c (coff_symfile_read): Update.
8348         * ada-lang.c (ada_lookup_simple_minsym)
8349         (ada_collect_symbol_completion_matches): Update.
8350
8351 2019-01-16  Tom Tromey  <tom@tromey.com>
8352
8353         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8354         type.  Remove no-argument constructor.
8355         <iterator::operator++>: Simplify.
8356         <begin>: Update.
8357         <end>: Use minimal_symbol_count.
8358
8359 2019-01-16  Tom Tromey  <tom@tromey.com>
8360
8361         * objfiles.h (struct objfile) <psymtabs>: New method.
8362         (class objfile_psymtabs): Remove.
8363         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8364         typedef.
8365         <range>: New method.
8366         (require_partial_symbols): Change return type.
8367         * psymtab.c (require_partial_symbols)
8368         (psym_expand_symtabs_matching): Update.
8369         * mdebugread.c (parse_partial_symbols): Update.
8370         * dbxread.c (dbx_end_psymtab): Update.
8371
8372 2019-01-15  Tom Tromey  <tom@tromey.com>
8373
8374         * symtab.c (lookup_objfile_from_block)
8375         (lookup_symbol_in_objfile_symtabs)
8376         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8377         (find_line_symtab, info_sources_command)
8378         (default_collect_symbol_completion_matches_break_on)
8379         (make_source_files_completion_list): Update.
8380         * symmisc.c (print_objfile_statistics, dump_objfile)
8381         (maintenance_print_symbols, maintenance_info_symtabs)
8382         (maintenance_check_symtabs, maintenance_info_line_tables):
8383         Update.
8384         * source.c (select_source_symtab)
8385         (forget_cached_source_info_for_objfile): Update.
8386         * objfiles.h (class objfile_compunits): Remove.
8387         (struct objfile) <compunits_range>: New typedef.
8388         (compunits): New method.
8389         * objfiles.c (objfile_relocate1): Update.
8390         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8391         * maint.c (count_symtabs_and_blocks): Update.
8392         * linespec.c (iterate_over_all_matching_symtabs): Update.
8393         * cp-support.c (add_symbol_overload_list_qualified): Update.
8394         * coffread.c (coff_symtab_read): Update.
8395         * ada-lang.c (add_nonlocal_symbols)
8396         (ada_collect_symbol_completion_matches)
8397         (ada_add_global_exceptions): Update.
8398
8399 2019-01-15  Tom Tromey  <tom@tromey.com>
8400
8401         * progspace.h (program_space) <objfiles_safe_range>: New
8402         typedef.
8403         <objfiles_safe>: New method.
8404         * objfiles.h (class all_objfiles_safe): Remove.
8405         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8406         * jit.c (jit_inferior_exit_hook): Update.
8407
8408 2019-01-17  Tom Tromey  <tom@tromey.com>
8409
8410         * progspace.h (program_space) <objfiles_range>: New typedef.
8411         <objfiles>: New method.
8412         <objfiles_head>: Rename from objfiles.
8413         (object_files): Update.
8414         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8415         * guile/scm-pretty-print.c
8416         (ppscm_find_pretty_printer_from_objfiles): Update.
8417         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8418         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8419         Update.
8420         * python/py-progspace.c (pspy_get_objfiles): Update.
8421         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8422         Update.
8423         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8424         (objfpy_lookup_objfile_by_build_id): Update.
8425         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8426         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8427         Update.
8428         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8429         (expand_symtab_containing_pc, lookup_objfile_from_block)
8430         (lookup_static_symbol, basic_lookup_transparent_type)
8431         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8432         (find_line_symtab, info_sources_command)
8433         (default_collect_symbol_completion_matches_break_on)
8434         (make_source_files_completion_list, find_main_name): Update.
8435         * symmisc.c (print_symbol_bcache_statistics)
8436         (print_objfile_statistics, maintenance_print_symbols)
8437         (maintenance_print_msymbols, maintenance_print_objfiles)
8438         (maintenance_info_symtabs, maintenance_check_symtabs)
8439         (maintenance_expand_symtabs, maintenance_info_line_tables):
8440         Update.
8441         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8442         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8443         (map_overlay_command, unmap_overlay_command)
8444         (simple_overlay_update, expand_symtabs_matching)
8445         (map_symbol_filenames): Update.
8446         * symfile-debug.c (set_debug_symfile): Update.
8447         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8448         Update.
8449         * source.c (select_source_symtab, forget_cached_source_info):
8450         Update.
8451         * solib.c (solib_read_symbols): Update.
8452         * solib-spu.c (append_ocl_sos): Update.
8453         * psymtab.c (maintenance_print_psymbols)
8454         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8455         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8456         * printcmd.c (info_symbol_command): Update.
8457         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8458         Update.
8459         * objfiles.h (class all_objfiles): Remove.
8460         * objfiles.c (have_partial_symbols, have_full_symbols)
8461         (have_minimal_symbols, qsort_cmp, update_section_map)
8462         (shared_objfile_contains_address_p)
8463         (default_iterate_over_objfiles_in_search_order): Update.
8464         * objc-lang.c (info_selectors_command, info_classes_command)
8465         (find_methods): Update.
8466         * minsyms.c (find_solib_trampoline_target): Update.
8467         * maint.c (maintenance_info_sections)
8468         (maintenance_translate_address, count_symtabs_and_blocks):
8469         Update.
8470         * main.c (captured_main_1): Update.
8471         * linux-thread-db.c (try_thread_db_load_from_pdir)
8472         (has_libpthread): Update.
8473         * linespec.c (iterate_over_all_matching_symtabs)
8474         (search_minsyms_for_name): Update.
8475         * jit.c (jit_find_objf_with_entry_addr): Update.
8476         * hppa-tdep.c (find_unwind_entry)
8477         (hppa_lookup_stub_minimal_symbol): Update.
8478         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8479         Update.
8480         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8481         (elf_gnu_ifunc_resolve_by_got): Update.
8482         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8483         * dwarf-index-write.c (save_gdb_index_command): Update.
8484         * cp-support.c (add_symbol_overload_list_qualified): Update.
8485         * breakpoint.c (create_overlay_event_breakpoint)
8486         (create_longjmp_master_breakpoint)
8487         (create_std_terminate_master_breakpoint)
8488         (create_exception_master_breakpoint): Update.
8489         * blockframe.c (find_pc_partial_function): Update.
8490         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8491         (ada_collect_symbol_completion_matches)
8492         (ada_add_global_exceptions): Update.
8493
8494 2019-01-17  Tom Tromey  <tom@tromey.com>
8495
8496         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8497         declare VEC.
8498         (solib_target_parse_libraries): Change return type.
8499         (library_list_start_segment, library_list_start_section)
8500         (library_list_end_library, library_list_start_library); Update.
8501         (solib_target_free_library_list): Remove.
8502         (solib_target_parse_libraries): Remove cleanup.  Change return
8503         type.
8504         (solib_target_current_sos): Update.
8505
8506 2019-01-17  Tom Tromey  <tromey@bapiya>
8507
8508         * valprint.c: Replace "the the" with "the".
8509         * symtab.c: Replace "the the" with "the".
8510         * solib.c: Replace "the the" with "the".
8511         * solib-dsbt.c: Replace "the the" with "the".
8512         * linespec.c: Replace "the the" with "the".
8513         * dwarf2loc.h: Replace "the the" with "the".
8514         * amd64-windows-tdep.c: Replace "the the" with "the".
8515         * aarch64-tdep.c: Replace "the the" with "the".
8516
8517 2019-01-16  Keith Seitz  <keiths@redhat.com>
8518
8519         PR gdb/23773
8520         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8521         <builder>: Rename to ..
8522         <m_builder>: ... this and make private.
8523         (dwarf2_cu::get_builder): New method.  Change all users of
8524         `builder' to use this method.
8525         (dwarf2_start_symtab): Move to ...
8526         (dwarf2_cu::start_symtab): ... here.  Update all callers
8527         (setup_type_unit_groups): Move to ...
8528         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8529         callers.
8530         (dwarf2_cu::reset_builder): New method.
8531         (process_full_compunit, process_full_type_unit): Use
8532         dwarf2_cu::reset_builder.
8533         (follow_die_offset): Record the ancestor CU if it is different
8534         from the followed DIE's CU.
8535         (follow_die_sig_1): Likewise.
8536
8537 2019-01-15  Tom Tromey  <tom@tromey.com>
8538
8539         * remote.c (class remote_state) <buf>: Now a char_vector.
8540         <buf_size>: Remove.
8541         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8542         parameter.
8543         (remote_target::getpkt_or_notif_sane_1)
8544         (remote_target::getpkt_sane)
8545         (remote_target::getpkt_or_notif_sane): Likewise.
8546         (class remote_target) <putpkt>: New overload.
8547         (remote_target::read_frame): Change type of "buf_p".  Remove
8548         sizeof_p parameter.
8549         (packet_ok): New overload.
8550         (packet_check_result): New overload.
8551         Update all uses.
8552
8553 2019-01-14  Tom Tromey  <tom@tromey.com>
8554
8555         * remote-notif.c (handle_notification, remote_notif_ack)
8556         (remote_notif_parse): Make "buf" const.
8557         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8558         const.
8559         (remote_notif_parse, remote_notif_ack, handle_notification):
8560         Likewise.
8561         * remote.c (remote_notif_stop_parse): Make "buf" const.
8562         (remote_target::remote_parse_stop_reply): Make "buf" const.
8563         (remote_notif_stop_ack): Make "buf" const.
8564
8565 2019-01-14  Tom Tromey  <tom@tromey.com>
8566
8567         * remote.c (remote_console_output): Make parameter const.
8568
8569 2019-01-14  Tom Tromey  <tom@tromey.com>
8570
8571         * target-debug.h (target_debug_print_signals): Constify.
8572         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8573         * procfs.c (procfs_target::pass_signals): Update.
8574         * linux-nat.c (linux_nat_target::pass_signals): Update.
8575         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8576         * target-delegates.c: Rebuild.
8577         * remote.c (remote_target::program_signals): Update.
8578         (remote_target::pass_signals): Update.
8579         * target.c (target_pass_signals): Constify argument.
8580         (target_program_signals): Likewise.
8581         * target.h (struct target_ops) <pass_signals, program_signals>:
8582         Constify argument.
8583         (target_pass_signals, target_program_signals): Constify argument.
8584
8585 2019-01-14  Tom Tromey  <tom@tromey.com>
8586
8587         PR tui/28819:
8588         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8589
8590 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8591
8592         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8593         field.
8594         * rs6000-tdep.c: Include reggroups.h.
8595         (IS_V_ALIAS_PSEUDOREG): Define.
8596         (rs6000_register_name): Return names for the "vX" aliases.
8597         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8598         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8599         aliases.  Call default_register_reggroup_p for all other
8600         pseudo-registers.
8601         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8602         New functions.
8603         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8604         Handle "vX" aliases.
8605         (v_alias_pseudo_register_collect): New function.
8606         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8607         (rs6000_gdbarch_init): Initialize "vX" aliases as
8608         pseudo-registers.  Restore registration of
8609         rs6000_pseudo_register_reggroup_p with
8610         set_tdesc_pseudo_register_reggroup_p.
8611
8612 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8613
8614         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8615         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8616         set_gdbarch_num_pseudo_regs.
8617
8618 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8619
8620         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8621         Remove arg prefixname, add do_set and do_show.
8622         Add member functions set_list and show_list.
8623         * cli/cli-style.c (class cli_style_option): Update accordingly.
8624         (style_set_list): Move to file scope.
8625         (style_show_list): Likewise.
8626         (set_style): Call help_list.
8627         (show_style): Call cmd_show_list.
8628         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8629         Update to use the new macro.
8630
8631 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8632
8633         * ada-lang.c (_initialize_ada_language): Expand the help text
8634         for the "catch exception" command.
8635
8636 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8637
8638         * symtab.c (matching_obj_sections): Initialize obj,
8639         declare it closer to its usage.
8640
8641 2019-01-10  Tom Tromey  <tom@tromey.com>
8642
8643         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8644         (basic_inf_threads_range): Remove.
8645         (inf_threads_range, inf_non_exited_threads_range)
8646         (safe_inf_threads_range): Use next_adapter.
8647
8648 2019-01-10  Keith Seitz  <keiths@redhat.com>
8649
8650         PR gdb/23712
8651         PR symtab/23010
8652         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8653         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8654
8655 2019-01-10  Keith Seitz  <keiths@redhat.com>
8656
8657         PR gdb/23712
8658         PR symtab/23010
8659         * dictionary.c (pending_to_vector): Remove.
8660         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8661         Remove _1 suffix, replacing functions of the same name.  Update
8662         all callers.
8663         (dict_create_hashed, dict_create_hashed_expandable)
8664         (dict_create_linear, dict_create_linear_expandable, dict_free)
8665         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8666         Make functions static.
8667
8668 2019-01-10  Keith Seitz  <keiths@redhat.com>
8669
8670         PR gdb/23712
8671         PR symtab/23010
8672         * dictionary.h (struct dictionary): Replace declaration with
8673         multidictionary.
8674         (dict_create_hashed, dict_create_hashed_expandable)
8675         (dict_create_linear, dict_create_linear_expandable)
8676         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8677         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8678         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8679         taking multidictionary argument.
8680         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8681         * block.h (struct block) <dict>: Change to multidictionary
8682         and rename `multidict'.
8683         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8684         symmisc.c: Update all dictionary references to multidictionary.
8685
8686 2019-01-10  Keith Seitz  <keiths@redhat.com>
8687
8688         PR gdb/23712
8689         PR symtab/23010
8690         * dictionary.c: Include unordered_map.
8691         (pending_to_vector): New function.
8692         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8693         Rewrite the non-"_1" functions to take vector instead
8694         of linked list.
8695         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8696         "new" _1 versions of the same name.
8697         (multidictionary): Define.
8698         (std::hash<enum language): New definition.
8699         (collate_pending_symbols_by_language, mdict_create_hashed)
8700         (mdict_create_hashed_expandable, mdict_create_linear)
8701         (mdict_create_linear_expandable, mdict_free)
8702         (find_language_dictionary, create_new_language_dictionary)
8703         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8704         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8705         (mdict_size, mdict_empty): New functions.
8706         * dictionary.h (mdict_iterator): Define.
8707
8708 2019-01-10  Pedro Alves  <palves@redhat.com>
8709
8710         * breakpoint.c (read_uploaded_action)
8711         (create_tracepoint_from_upload): Adjust to use
8712         gdb::unique_xmalloc_ptr.
8713         * ctf.c (ctf_write_uploaded_tp):
8714         (SET_ARRAY_FIELD): Use emplace_back.
8715         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8716         * tracefile-tfile.c (tfile_write_uploaded_tp):
8717         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8718         gdb::unique_xmalloc_ptr.
8719         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8720         at_string, cond_string, cmd_strings>: Replace char pointers
8721         with gdb::unique_xmalloc_ptr.
8722
8723 2019-01-10  Pedro Alves  <palves@redhat.com>
8724
8725         * solib-target.c (library_list_start_library): Don't xstrdup name.
8726
8727 2019-01-10  Pedro Alves  <palves@redhat.com>
8728
8729         * mdebugread.c (parse_partial_symbols): Use
8730         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8731
8732 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8733
8734         * linux-fork.c (scoped_switch_fork_info)
8735         <~scoped_switch_fork_info>: Fix incorrect variable name.
8736
8737 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8738
8739         * linux-fork.c (scoped_switch_fork_info)
8740         <scoped_switch_fork_info>: Make explicit.
8741         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8742
8743 2019-01-10  Tom Tromey  <tom@tromey.com>
8744
8745         * objfiles.h (objfile::reset_psymtabs): Update.
8746         * objfiles.c (objfile::objfile): Update.
8747         * psymtab.h (psymtab_storage::obstack): Update.
8748         (psymtab_storage::m_obstack): Use gdb::optional.
8749         (class psymtab_storage): Update comment.  Remove objfile
8750         parameter.
8751         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8752
8753 2019-01-10  Tom Tromey  <tom@tromey.com>
8754
8755         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8756         <free_psymtabs>: Now private.
8757         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8758         (allocate_psymtab): Use new method.
8759
8760 2019-01-10  Tom Tromey  <tom@tromey.com>
8761
8762         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8763         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8764         * mdebugread.c (parse_partial_symbols): Use
8765         allocate_dependencies.
8766         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8767         allocate_dependencies.
8768         (process_psymtab_comp_unit_reader)
8769         (build_type_psymtab_dependencies): Likewise.
8770         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8771
8772 2019-01-10  Tom Tromey  <tom@tromey.com>
8773
8774         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8775         PSYMBOL_SET_LANGUAGE.
8776         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8777
8778 2019-01-10  Tom Tromey  <tom@tromey.com>
8779
8780         * psymtab.h (psymtab_storage::obstack): New method.
8781         <m_obstack>: Rename from obstack; now private.
8782         * psymtab.c (psymtab_storage): Update.
8783         * dwarf2read.c (create_addrmap_from_index)
8784         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8785         Update.
8786
8787 2019-01-10  Tom Tromey  <tom@tromey.com>
8788
8789         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8790         * objfiles.h (objfile::reset_psymtabs): New method.
8791
8792 2019-01-10  Tom Tromey  <tom@tromey.com>
8793
8794         * symmisc.c (print_symbol_bcache_statistics): Update.
8795         (print_objfile_statistics): Update.
8796         * symfile.c (reread_symbols): Update.
8797         * psymtab.h (class psymtab_storage): New.
8798         * psymtab.c (psymtab_storage): New constructor.
8799         (~psymtab_storage): New destructor.
8800         (require_partial_symbols): Update.
8801         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8802         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8803         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8804         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8805         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8806         (start_psymtab_common, end_psymtab_common)
8807         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8808         (allocate_psymtab): Update.
8809         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8810         Update.
8811         (dump_psymtab_addrmap, maintenance_print_psymbols)
8812         (maintenance_check_psymtabs): Update.
8813         (class objfile_psymtabs): Move to objfiles.h.
8814         * psympriv.h (discard_psymtab): Now inline.
8815         (psymtab_discarder::psymtab_discarder): Update.
8816         (psymtab_discarder::~psymtab_discarder): Update.
8817         (ALL_OBJFILE_PSYMTABS): Rewrite.
8818         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8819         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8820         Remove fields.
8821         <partial_symtabs>: New field.
8822         (class objfile_psymtabs): Move from psymtab.h.  Update.
8823         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8824         psymbol_cache.
8825         (objfile::~objfile): Don't destroy psymbol_cache.
8826         * mdebugread.c (parse_partial_symbols): Update.
8827         * dwarf2read.c (create_addrmap_from_index)
8828         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8829         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8830         (add_partial_subprogram, dwarf2_ranges_read): Update.
8831         * dwarf-index-write.c (write_address_map)
8832         (write_one_signatured_type, recursively_write_psymbols)
8833         (class debug_names, class debug_names, write_psymtabs_to_index):
8834         Update.
8835
8836 2019-01-10  Tom Tromey  <tom@tromey.com>
8837
8838         * symtab.h (SYMBOL_SET_NAMES): Update.
8839         (symbol_set_names): Update.
8840         (MSYMBOL_SET_NAMES): Update.
8841         * symtab.c (symbol_set_names): Change argument to be an
8842         objfile_per_bfd_storage.
8843         * psymtab.c (add_psymbol_to_bcache): Update.
8844         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8845
8846 2019-01-10  Tom Tromey  <tom@tromey.com>
8847
8848         * symtab.c (create_demangled_names_hash): Change argument to be an
8849         objfile_per_bfd_storage.
8850         (symbol_set_names): Update.
8851
8852 2019-01-10  Tom Tromey  <tom@tromey.com>
8853
8854         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8855         init_psymbol_list.
8856         * psymtab.c (init_psymbol_list): Do nothing if already called.
8857         * psympriv.h (init_psymbol_list): Add comment.
8858         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8859         init_psymbol_list.
8860         * dbxread.c (dbx_symfile_read): Unconditionally call
8861         init_psymbol_list.
8862
8863 2019-01-10  Tom Tromey  <tom@tromey.com>
8864
8865         * xcoffread.c (scan_xcoff_symtab): Update.
8866         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8867         "where".
8868         * mdebugread.c (parse_partial_symbols)
8869         (handle_psymbol_enumerators): Update.
8870         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8871         * dbxread.c (read_dbx_symtab): Update.
8872         * psympriv.h (psymbol_placement): New enum.
8873         (add_psymbol_to_list): Update.
8874
8875 2019-01-10  Tom Tromey  <tom@tromey.com>
8876
8877         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8878         static_psymbols parameters.
8879         (scan_xcoff_symtab): Update.
8880         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8881         static_psymbols parameters.
8882         * psympriv.h (start_psymtab_common): Update.
8883         * mdebugread.c (parse_partial_symbols): Update.
8884         * dwarf2read.c (create_partial_symtab): Update.
8885         * dbxread.c (read_dbx_symtab): Update.
8886         (start_psymtab): Remove global_psymbols and static_psymbols
8887         parameters.
8888
8889 2019-01-10  Tom Tromey  <tom@tromey.com>
8890
8891         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8892         * psymtab.c (allocate_psymtab): Add comment.
8893         * psympriv.h (allocate_psymtab): Add comment.
8894         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8895         initializations.
8896         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8897
8898 2019-01-10  Tom Tromey  <tom@tromey.com>
8899
8900         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8901         Don't declare.
8902         * mipsread.c: Include mdebugread.h.
8903         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8904         Declare.
8905         * elfread.c: Include mdebugread.h.
8906
8907 2019-01-09  Tom Tromey  <tom@tromey.com>
8908
8909         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8910         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8911         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8912         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8913         (psym_lookup_symbol, psym_find_last_source_symtab)
8914         (psym_forget_cached_source_info, psym_print_stats)
8915         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8916         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8917         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8918         (psym_find_compunit_symtab_by_address)
8919         (maintenance_print_psymbols, maintenance_info_psymtabs)
8920         (maintenance_check_psymtabs): Use ranged for.
8921         * psymtab.h (class objfile_psymtabs): New.
8922         (require_partial_symbols): Return objfile_psymtabs.
8923         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8924
8925 2019-01-09  Tom Tromey  <tom@tromey.com>
8926
8927         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8928         (find_pc_mapped_section, list_overlays_command)
8929         (map_overlay_command, unmap_overlay_command)
8930         (simple_overlay_update): Use all_objfiles.
8931         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8932         * printcmd.c (info_symbol_command): Use all_objfiles.
8933         * objfiles.h (ALL_OBJSECTIONS): Remove.
8934         * maint.c (maintenance_translate_address): Use all_objfiles.
8935         * gcore.c (gcore_create_callback): Use all_objfiles.
8936         (objfile_find_memory_regions): Likewise.
8937
8938 2019-01-09  Tom Tromey  <tom@tromey.com>
8939
8940         * symtab.c (find_line_symtab, info_sources_command)
8941         (make_source_files_completion_list): Use objfile_compunits.
8942         * source.c (select_source_symtab): Use objfile_compunits.
8943         * objfiles.h (struct objfile): Update comment.
8944         (ALL_OBJFILES): Remove.
8945         (ALL_FILETABS): Remove.
8946         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8947         objfile_compunits.
8948
8949 2019-01-09  Tom Tromey  <tom@tromey.com>
8950
8951         * symmisc.c (print_objfile_statistics, dump_objfile)
8952         (maintenance_print_symbols): Use compunit_filetabs.
8953         * source.c (forget_cached_source_info_for_objfile): Use
8954         compunit_filetabs.
8955         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8956         (ALL_FILETABS): Use compunit_filetabs.
8957         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8958         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8959
8960 2019-01-09  Tom Tromey  <tom@tromey.com>
8961
8962         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8963         (compunit_filetabs): New.
8964         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8965         compunit_filetabs.
8966         (info_sources_command, make_source_files_completion_list): Remove
8967         declaration.
8968         * symmisc.c (print_objfile_statistics, dump_objfile)
8969         (maintenance_print_symbols): Remove declaration.
8970         (maintenance_info_symtabs): Use compunit_filetabs.
8971         (maintenance_info_line_tables): Likewise.
8972         * source.c (select_source_symtab): Change local variable name.
8973         (forget_cached_source_info_for_objfile): Remove declaration.
8974         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8975         * objfiles.c (objfile_relocate1): Remove declaration.
8976         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8977         declaration.
8978         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8979         * coffread.c (coff_symtab_read): Remove declaration.
8980         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8981         compunit_filetabs.
8982
8983 2019-01-09  Tom Tromey  <tom@tromey.com>
8984
8985         * symtab.c (lookup_objfile_from_block)
8986         (find_pc_sect_compunit_symtab, search_symbols)
8987         (default_collect_symbol_completion_matches_break_on): Use
8988         objfile_compunits.
8989         * objfiles.h (ALL_COMPUNITS): Remove.
8990         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8991         * cp-support.c (add_symbol_overload_list_qualified): Use
8992         objfile_compunits.
8993         * ada-lang.c (ada_collect_symbol_completion_matches)
8994         (ada_add_global_exceptions): Use objfile_compunits.
8995
8996 2019-01-09  Tom Tromey  <tom@tromey.com>
8997
8998         * source.c (select_source_symtab)
8999         (forget_cached_source_info_for_objfile): Remove declaration.
9000         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9001         declaration.
9002         * maint.c (count_symtabs_and_blocks): Remove declaration.
9003         * cp-support.c (add_symbol_overload_list_qualified): Remove
9004         declaration.
9005         * coffread.c (coff_symtab_read): Remove declaration.
9006         * symtab.c (lookup_symbol_in_objfile_symtabs)
9007         (basic_lookup_transparent_type_1): Use objfile_compunits.
9008         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9009         (info_sources_command, search_symbols)
9010         (default_collect_symbol_completion_matches_break_on)
9011         (make_source_files_completion_list): Remove declaration.
9012         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9013         (ada_collect_symbol_completion_matches)
9014         (ada_add_global_exceptions): Remove declaration.
9015         * linespec.c (iterate_over_all_matching_symtabs): Use
9016         objfile_compunits.
9017         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9018         (class objfile_compunits): New.
9019         (ALL_COMPUNITS): Use objfile_compunits.
9020         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9021         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9022         objfile_compunits.
9023         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9024
9025 2019-01-09  Tom Tromey  <tom@tromey.com>
9026
9027         * symtab.c (search_symbols)
9028         (default_collect_symbol_completion_matches_break_on): Use
9029         objfile_msymbols.
9030         * ada-lang.c (ada_lookup_simple_minsym)
9031         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9032         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9033         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9034         objfile_msymbols.
9035         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9036         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9037         * objc-lang.c (find_methods): Use objfile_msymbols.
9038         (info_selectors_command, info_classes_command): Likewise.
9039         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9040         * objfiles.h (class objfile_msymbols): New.
9041         (ALL_OBJFILE_MSYMBOLS): Remove.
9042         (ALL_MSYMBOLS): Remove.
9043
9044 2019-01-09  Tom Tromey  <tom@tromey.com>
9045
9046         * common/next-iterator.h (next_adapter): Add Iterator template
9047         parameter.
9048         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9049         (class all_objfiles_safe): New.
9050         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9051         * objfiles.c (put_objfile_before): Update comment.
9052         (add_separate_debug_objfile): Likewise.
9053         (free_all_objfiles): Use all_objfiles_safe.
9054         (objfile_purge_solibs): Likewise.
9055
9056 2019-01-09  Tom Tromey  <tom@tromey.com>
9057
9058         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9059         (expand_symtab_containing_pc, lookup_static_symbol)
9060         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9061         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9062         all_objfiles.
9063         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9064         * breakpoint.c (create_overlay_event_breakpoint)
9065         (create_longjmp_master_breakpoint)
9066         (create_std_terminate_master_breakpoint)
9067         (create_exception_master_breakpoint): Use all_objfiles.
9068         * linux-thread-db.c (try_thread_db_load_from_pdir)
9069         (has_libpthread): Use all_objfiles.
9070         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9071         * linespec.c (iterate_over_all_matching_symtabs)
9072         (search_minsyms_for_name): Use all_objfiles.
9073         * maint.c (maintenance_info_sections): Use all_objfiles.
9074         * main.c (captured_main_1): Use all_objfiles.
9075         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9076         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9077         * guile/scm-pretty-print.c
9078         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9079         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9080         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9081         (maintenance_print_msymbols): Use all_objfiles.
9082         * source.c (select_source_symtab): Use all_objfiles.
9083         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9084         * symfile.c (remove_symbol_file_command)
9085         (expand_symtabs_matching, map_symbol_filenames): Use
9086         all_objfiles.
9087         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9088         all_objfiles.
9089         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9090         * objc-lang.c (find_methods): Use all_objfiles.
9091         * objfiles.c (have_partial_symbols, have_full_symbols)
9092         (have_minimal_symbols, qsort_cmp)
9093         (default_iterate_over_objfiles_in_search_order): Use
9094         all_objfiles.
9095         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9096         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9097         (maintenance_check_psymtabs): Use all_objfiles.
9098         (ALL_PSYMTABS): Remove.
9099         * compile/compile-object-run.c (do_module_cleanup): Use
9100         all_objfiles.
9101         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9102         * cp-support.c (add_symbol_overload_list_qualified): Use
9103         all_objfiles.
9104         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9105         Use all_objfiles.
9106         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9107         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9108         all_objfiles.
9109         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9110         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9111         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9112         Uses all_objfiles.
9113         * solib.c (solib_read_symbols): Use all_objfiles
9114
9115 2019-01-09  Tom Tromey  <tom@tromey.com>
9116
9117         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9118         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9119         all_objfiles.
9120         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9121         * symmisc.c (print_symbol_bcache_statistics)
9122         (print_objfile_statistics, maintenance_print_objfiles)
9123         (maintenance_info_symtabs, maintenance_check_symtabs)
9124         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9125         all_objfiles.
9126         * source.c (forget_cached_source_info): Use all_objfiles.
9127         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9128         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9129         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9130         * objfiles.c (update_section_map): Use all_objfiles.
9131         (shared_objfile_contains_address_p): Likewise.
9132         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9133         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9134
9135 2019-01-09  Tom Tromey  <tom@tromey.com>
9136
9137         * common/next-iterator.h: New file.
9138         * objfiles.h (class all_objfiles): New.
9139         (struct objfile_iterator): New.
9140
9141 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9142
9143         * NEWS: Move the description of the changed "frame", "select-frame",
9144          and "info frame" commands to the Changed commands section.
9145
9146 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9147
9148         * gdbtypes.c (check_stub_method_group): Remove handling of old
9149         mangling schemes.
9150         * linespec.c (find_methods): Likewise.
9151         * stabsread.c (read_member_functions): Likewise.
9152         * valops.c (search_struct_method): Likewise.
9153         (value_struct_elt_for_reference): Likewise.
9154         * NEWS: Mention this change.
9155
9156 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9157
9158         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9159         print_source_lines.
9160         * source.c (print_source_lines_base): Update line number check.
9161         (print_source_lines): New function.
9162         (source_lines_range::source_lines_range): New function.
9163         * source.h (class source_lines_range): New class.
9164         (print_source_lines): New declaration.
9165
9166 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9167
9168         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9169
9170 2019-01-08  Tom Tromey  <tom@tromey.com>
9171             Simon Marchi  <simon.marchi@ericsson.com>
9172
9173         PR gdb/24060
9174         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9175         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9176         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9177         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9178         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9179         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9180
9181 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9182
9183         * source.c (select_source_symtab): Move header comment to
9184         declaration in source.h.
9185         (forget_cached_source_info_for_objfile): Likewise.
9186         (forget_cached_source_info): Likewise.
9187         (identify_source_line): Likewise.
9188         * source.h (identify_source_line): Move declaration from symtab.h
9189         and add comment from source.c
9190         (print_source_lines): Likewise.
9191         (forget_cached_source_info_for_objfile): Likewise.
9192         (forget_cached_source_info): Likewise.
9193         (select_source_symtab): Likewise.
9194         (enum print_source_lines_flag): Move definition from symtab.h.
9195         * symtab.h (identify_source_line): Move declaration to source.h.
9196         (print_source_lines): Likewise.
9197         (forget_cached_source_info_for_objfile): Likewise.
9198         (forget_cached_source_info): Likewise.
9199         (select_source_symtab): Likewise.
9200         (enum print_source_lines_flag): Move definition to source.h.
9201         * tui/tui-hooks.c: Add 'source.h' include.
9202
9203 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9204
9205         * source.c (print_source_lines_base): Handle requests to print
9206         reverse line number sequences, and guard against empty lines
9207         string.
9208
9209 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9210
9211         * source.c (print_source_lines_base): Fix skip of '\r' if next
9212         character is '\n'.
9213
9214 2019-01-06  Tom Tromey  <tom@tromey.com>
9215
9216         * c-exp.y (struct c_parse_state) <macro_original_text,
9217         expansion_obstack>: New member.
9218         (macro_original_text, expansion_obstack): Remove globals.
9219         (scan_macro_expansion, scanning_macro_expansion)
9220         (finished_macro_expansion): Update.
9221         (scan_macro_cleanup): Remove.
9222         (yylex, c_parse): Update.
9223
9224 2019-01-06  Tom Tromey  <tom@tromey.com>
9225
9226         * c-exp.y (struct c_parse_state) <strings>: New member.
9227         (operator_stoken): Update.
9228
9229 2019-01-06  Tom Tromey  <tom@tromey.com>
9230
9231         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9232         (union type_stack_elt) <typelist_val>: Now a pointer to
9233         std::vector.
9234         (type_stack_cleanup): Don't declare.
9235         (push_typelist): Update.
9236         * parse.c (pop_typelist): Return a std::vector.
9237         (push_typelist): Take a std::vector.
9238         (follow_types): Update.  Do not free args.
9239         (type_stack_cleanup): Remove.
9240         * c-exp.y (struct c_parse_state): New.
9241         (cpstate): New global.
9242         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9243         (nonempty_typelist): Update.
9244         (func_mod): Create a new vector.
9245         (c_parse): Create a c_parse_state.
9246         (check_parameter_typelist): Do not delete params.
9247         (function_method): Update.  Do not delete type_list.
9248
9249 2019-01-06  Tom Tromey  <tom@tromey.com>
9250
9251         PR gdb/28155:
9252         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9253         check_typedef.
9254         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9255         (print_return_value): Likewise.
9256
9257 2019-01-05  Tom Tromey  <tom@tromey.com>
9258
9259         * contrib/cleanup_check.py: Remove.
9260         * contrib/gcc-with-excheck: Remove.
9261         * contrib/exsummary.py: Remove.
9262         * contrib/excheck.py: Remove.
9263
9264 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9265
9266         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9267         NULL. Initialize tpprev to NULL instead of assigning it
9268         to NULL on the next statement.
9269         * windows-nat.c (windows_delete_thread): Remove check for
9270         main_thread_id before printing thread exit notifications.
9271         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9272         Remove thread ID check against main_thread_id.
9273         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9274         windows_delete_thread.
9275         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9276
9277 2019-01-04  Tom Tromey  <tom@tromey.com>
9278
9279         * compile/compile.c (_initialize_compile): Use upper case for
9280         metasyntactic variables.
9281         * symmisc.c (_initialize_symmisc): Use upper case for
9282         metasyntactic variables.
9283         * psymtab.c (_initialize_psymtab): Use upper case for
9284         metasyntactic variables.
9285         * demangle.c (demangle_command): Use upper case for metasyntactic
9286         variables.
9287         (_initialize_demangler): Likewise.
9288         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9289         variables.
9290
9291 2019-01-03  Tom Tromey  <tom@tromey.com>
9292
9293         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9294
9295 2019-01-03  Tom Tromey  <tom@tromey.com>
9296
9297         * python/py-symtab.c (salpy_str): Update.
9298         (struct salpy_sal_object) <symtab>: Now a PyObject.
9299         (salpy_dealloc): Update.
9300         (del_objfile_sal): Use gdbpy_ref.
9301
9302 2019-01-03  Tom Tromey  <tom@tromey.com>
9303
9304         * python/py-type.c (convert_field): Use new_reference.  Return
9305         gdbpy_ref.
9306         (make_fielditem): Return gdbpy_ref.
9307         (typy_fields): Update.
9308         (typy_getitem): Update.
9309         (field_name): Return gdbpy_ref.  Use new_reference.
9310         (typy_iterator_iternext): Update.
9311
9312 2019-01-03  Tom Tromey  <tom@tromey.com>
9313
9314         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9315
9316 2019-01-03  Tom Tromey  <tom@tromey.com>
9317
9318         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9319         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9320         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9321         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9322         (pspy_set_type_printers): Likewise.
9323         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9324         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9325         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9326         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9327         (objfpy_set_type_printers): Likewise.
9328
9329 2019-01-03  Tom Tromey  <tom@tromey.com>
9330
9331         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9332         (gdbpy_print_stack): Use gdbpy_err_fetch.
9333         * python/python-internal.h (class gdbpy_err_fetch): New class.
9334         (class gdbpy_enter) <m_error_type, m_error_value,
9335         m_error_traceback>: Remove.
9336         <m_error>: New member.
9337         (gdbpy_exception_to_string): Don't declare.
9338         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9339         * python/py-value.c (convert_value_from_python): Use
9340         gdbpy_err_fetch.
9341         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9342         gdbpy_exception_to_string.
9343         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9344         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9345         gdbpy_err_fetch.
9346
9347 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9348
9349         * linux-nat.c (delete_lwp_cleanup): Delete.
9350         (struct lwp_deleter): New struct.
9351         (lwp_info_up): New typedef.
9352         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9353         lwp_info_up.
9354
9355 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9356
9357         * linux-fork.c (class scoped_switch_fork_info): New class.
9358         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9359
9360 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9361
9362         * valops.c (find_overload_match): Remove use of null_cleanup, and
9363         calls to do_cleanups.
9364
9365 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9366
9367         * compile/compile-cplus-types.c
9368         (compile_cplus_instance::decl_name): Handle changes to
9369         cp_func_name.
9370         * cp-support.c (cp_func_name): Update header comment, update
9371         return type.
9372         * cp-support.h (cp_func_name): Update return type in declaration.
9373         * valops.c (find_overload_match): Move temp_func local to top
9374         level of function and change its type.  Use temp_func to hold and
9375         delete temporary string obtained from cp_func_name.
9376
9377 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9378
9379         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9380         gdb::char_vector, remove cleanup, and update uses of `msg`.
9381
9382 2019-01-03  Jim Wilson  <jimw@sifive.com>
9383
9384         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9385
9386 2019-01-02  Tom Tromey  <tom@tromey.com>
9387
9388         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9389         (tdesc_parse_xml): Remove cleanups.
9390         * target-descriptions.h (make_cleanup_free_target_description):
9391         Don't declare.
9392         (target_desc_deleter): New struct.
9393         (target_desc_up): New typedef.
9394         * target-descriptions.c (target_desc_deleter::operator()): Rename
9395         from free_target_description.
9396         (make_cleanup_free_target_description): Remove.
9397
9398 2019-01-02  Tom Tromey  <tom@tromey.com>
9399
9400         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9401         constructor, destructor.
9402         (linespec_parser): Remove typedef.
9403         (~linespec_parser): Rename from linespec_parser_delete.
9404         (linespec_lex_to_end, linespec_complete_label)
9405         (linespec_complete): Update.
9406         (decode_line_full): Remove cleanups.
9407         (decode_line_1): Update.
9408
9409 2019-01-02  Tom Tromey  <tom@tromey.com>
9410
9411         * python/python-internal.h (inferior_to_inferior_object): Change
9412         return type.
9413         * python/py-exitedevent.c (create_exited_event_object): Update.
9414         * python/py-inferior.c (inferior_to_inferior_object): Return
9415         gdbpy_ref.
9416         (python_new_inferior, python_inferior_deleted)
9417         (thread_to_thread_object, delete_thread_object)
9418         (build_inferior_list, gdbpy_selected_inferior): Update.
9419         * python/py-infthread.c (create_thread_object): Update.  Also fail
9420         if inferior_to_inferior_object fails.
9421
9422 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9423
9424         * inferior.h (class inferior) <displaced_step_state>: New field.
9425         * infrun.h (struct displaced_step_state): Move here from
9426         infrun.c.  Initialize fields, add constructor.
9427         <inf>: Remove field.
9428         <reset>: New method.
9429         * infrun.c (struct displaced_step_inferior_state): Move to
9430         infrun.h.
9431         (displaced_step_inferior_states): Remove.
9432         (get_displaced_stepping_state): Adust.
9433         (displaced_step_in_progress_any_inferior): Adjust.
9434         (displaced_step_in_progress_thread): Adjust.
9435         (displaced_step_in_progress): Adjust.
9436         (add_displaced_stepping_state): Remove.
9437         (get_displaced_step_closure_by_addr): Adjust.
9438         (remove_displaced_stepping_state): Remove.
9439         (infrun_inferior_exit): Call displaced_step_state.reset.
9440         (use_displaced_stepping): Don't check for NULL.
9441         (displaced_step_prepare_throw): Call
9442         get_displaced_stepping_state.
9443         (displaced_step_fixup): Don't check for NULL.
9444         (prepare_for_detach): Don't check for NULL.
9445
9446 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9447
9448         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9449          in case of call that did not complete.
9450
9451 2019-01-02  Andrey Utkin  <autkin@undo.io>
9452
9453         * symfile.c (find_separate_debug_file): Fix search of debug files for
9454         remote debuggee.
9455
9456 2019-01-02  Tom Tromey  <tom@tromey.com>
9457
9458         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9459         indentation.
9460         * python/py-frame.c (frapy_older): Remove cast.
9461         (frapy_newer): Likewise.
9462         * python/py-breakpoint.c (local_setattro): Remove cast.
9463         * python/py-arch.c (archpy_name): Remove local variable.
9464         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9465
9466 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9467
9468         * unittests/basic_string_view/element_access/char/empty.cc:
9469         Fix year range in copyright header.
9470
9471 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9472
9473         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9474         Delete.
9475         <operator==>: Update with for removed field.
9476         <hash>: Likewise.
9477         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9478         <isa_features>: ...this.
9479         <abi_features>: New field.
9480         (riscv_isa_flen): Update comment.
9481         (riscv_abi_xlen): New declaration.
9482         (riscv_abi_flen): New declaration.
9483         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9484         isa_features.
9485         (riscv_abi_xlen): New function.
9486         (riscv_isa_flen): Update to get answer from isa_features.
9487         (riscv_abi_flen): New function.
9488         (riscv_has_fp_abi): Update to get answer from abi_features.
9489         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9490         xlen and flen.
9491         (riscv_call_info) <xlen, flen>: Update comment.
9492         (riscv_call_arg_struct): Remove invalid assertions
9493         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9494         is removed.
9495         (riscv_gdbarch_init): Gather isa features and abi features
9496         separately, ensure both match on the gdbarch when reusing an old
9497         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9498         a target with 64-bit float hardware.
9499
9500 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9501
9502         * source.c (search_command_helper): Stop reverse search
9503         when line 1 has been searched.
9504
9505 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9506
9507         * record-full.c (record_full_base_target::close): Rewrite
9508         record_full_core_buf_list free logic.
9509
9510 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9511
9512         * break-catch-syscall.c (print_one_catch_syscall): xfree
9513         the last text.
9514
9515 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9516
9517         * top.c (print_gdb_version): Update Copyright year in version
9518         message.
9519
9520 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9521
9522         Update copyright year range in all GDB files.
9523
9524 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9525
9526         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9527
9528 For older changes see ChangeLog-2018.
9529 \f
9530 Local Variables:
9531 mode: change-log
9532 left-margin: 8
9533 fill-column: 74
9534 version-control: never
9535 coding: utf-8
9536 End:
9537