gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui.c (tui_rl_other_window, tui_enable)
   4         (tui_is_window_visible, tui_get_command_dimension): Update.
   5         * tui/tui-winsource.c (tui_update_source_window_as_is)
   6         (tui_clear_source_content, tui_erase_source_content)
   7         (tui_show_source_line, tui_source_window_base::refill)
   8         (tui_source_window_base::do_scroll_horizontal)
   9         (tui_source_window_base::set_is_exec_point_at)
  10         (tui_update_breakpoint_info, tui_set_exec_info_content)
  11         (tui_alloc_source_buffer, tui_line_is_displayed)
  12         (tui_addr_is_displayed): Update.
  13         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  14         (tui_check_and_display_highlight_if_needed)
  15         (tui_win_info::make_visible, tui_win_info::refresh)
  16         (tui_refresh_all): Update.
  17         * tui/tui-windata.c (tui_first_data_item_displayed)
  18         (tui_delete_data_content_windows, tui_erase_data_content)
  19         (tui_display_all_data, tui_data_window::refresh_all)
  20         (tui_check_data_values): Update.
  21         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
  22         (tui_set_win_focus_to, tui_win_info::forward_scroll)
  23         (tui_win_info::backward_scroll, tui_refresh_all_win)
  24         (tui_resize_all, tui_set_focus, tui_all_windows_info)
  25         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
  26         (tui_source_window_base::set_new_height)
  27         (tui_data_window::set_new_height)
  28         (make_invisible_and_set_new_height)
  29         (make_visible_with_new_height, new_height_ok)
  30         (parse_scrolling_args): Update.
  31         * tui/tui-stack.c (tui_show_frame_info): Update.
  32         * tui/tui-source.c (tui_set_source_content)
  33         (tui_set_source_content_nil, tui_source_is_displayed)
  34         (tui_source_window::do_scroll_vertical): Update.
  35         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
  36         (tui_display_registers_from, tui_display_reg_element_at_line)
  37         (tui_check_register_values, tui_reg_command): Update.
  38         * tui/tui-layout.c (tui_default_win_height)
  39         (show_source_disasm_command, show_data, init_and_make_win)
  40         (show_source_or_disasm_and_command): Update.
  41         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
  42         (tui_redisplay_readline, tui_mld_flush)
  43         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
  44         (tui_getc): Update.
  45         * tui/tui-disasm.c (tui_set_disassem_content)
  46         (tui_disasm_window::do_scroll_vertical): Update.
  47         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
  48         Now virtual.
  49         (struct tui_win_info): Derive from tui_gen_win_info.
  50         <~tui_win_info>: Mark as override.
  51         <generic>: Remove member.
  52         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
  53         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
  54         (~tui_data_window, ~tui_win_info)
  55         (tui_free_all_source_wins_content): Update.
  56         * tui/tui-command.c (tui_refresh_cmd_win): Update.
  57
  58 2019-06-25  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-layout.c (init_and_make_win): Use new.
  61         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
  62         destructor, initializers.
  63         (tui_alloc_generic_win_info): Don't declare.
  64         * tui/tui-data.c (_locator): Add argument to constructor.
  65         (source_win, disasm_win): New globals.
  66         (exec_info): Remove.
  67         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
  68         Update.
  69         (tui_alloc_generic_win_info): Remove.
  70         (init_content_element): Use new.
  71         (tui_win_info::tui_win_info): Update.
  72         (free_content_elements) <case DATA_WIN>: Use delete.
  73
  74 2019-06-25  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-wingeneral.c (tui_refresh_win): Update.
  77         * tui/tui-windata.c (tui_first_data_item_displayed)
  78         (tui_delete_data_content_windows): Update.
  79         * tui/tui-win.c (tui_data_window::set_new_height): Update.
  80         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
  81         (tui_display_registers_from, tui_check_register_values): Update.
  82         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
  83         pointer.
  84         * tui/tui-data.c (init_content_element): Update.  Allocate the new
  85         window.
  86         (tui_free_data_content): Update.
  87         (free_content_elements) <case DATA_WIN>: Free the window.
  88
  89 2019-06-25  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
  92         Update.
  93         * tui/tui-layout.c (make_command_window)
  94         (show_source_disasm_command, show_data, init_and_make_win)
  95         (show_source_or_disasm_and_command): Update.
  96         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
  97         method.
  98         <can_highight, is_highlighted>: Now bool.
  99         (tui_set_win_highlight): Don't declare.
 100         * tui/tui-data.c (tui_set_win_highlight): Remove.
 101
 102 2019-06-25  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-wingeneral.c (make_visible): Remove check of window
 105         type.
 106
 107 2019-06-25  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-win.c (tui_win_info::max_height)
 110         (tui_cmd_window::max_height): New methods.
 111         (new_height_ok): Call max_height.
 112         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 113         <max_height>: New method.
 114
 115 2019-06-25  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui-win.c (tui_source_window_base::set_new_height)
 118         (tui_data_window::set_new_height): New methods.
 119         (make_invisible_and_set_new_height): Call set_new_height method.
 120         * tui/tui-data.h (struct tui_win_info)
 121         (struct tui_source_window_base, struct tui_data_window)
 122         <set_new_height>: New method.
 123
 124 2019-06-25  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 127         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 128         tui_refresh_data_win.
 129         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 130         method.
 131         (tui_refresh_all_win): Call the refresh_all method.
 132         (tui_set_focus): Likewise.
 133         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 134         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 135         Likewise.
 136
 137 2019-06-25  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-winsource.h (tui_refill_source_window)
 140         (tui_set_is_exec_point_at): Don't declare.
 141         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 142         (tui_source_window_base::refill): Rename from
 143         tui_refill_source_window.
 144         (tui_source_window_base::do_scroll_horizontal): Update.
 145         (tui_source_window_base::set_is_exec_point_at): Rename from
 146         tui_set_is_exec_point_at.
 147         (tui_update_all_breakpoint_info): Update.
 148         * tui/tui-stack.c (tui_show_frame_info): Update.
 149         * tui/tui-layout.c (show_data): Add cast.
 150         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 151         * tui/tui-data.h (struct tui_source_window_base) <refill,
 152         set_is_exec_point_at>: New methods.
 153         (tui_source_windows, tui_add_to_source_windows): Update types.
 154         (tui_add_to_source_windows): Remove redundant declaration.
 155         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 156         (tui_source_windows): Change return type.
 157         (tui_clear_source_windows_detail): Update.
 158         (tui_add_to_source_windows): Change type of parameter.
 159         (tui_free_all_source_wins_content): Update.
 160
 161 2019-06-25  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-wingeneral.c (tui_win_info::refresh)
 164         (tui_source_window_base::refresh): New methods.
 165         (tui_refresh_all): Call the refresh method.
 166         * tui/tui-data.h (struct tui_win_info)
 167         (struct tui_source_window_base) <refresh>: New method.
 168
 169 2019-06-25  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui.h (tui_is_window_visible): Return bool.
 172         * tui/tui.c (tui_is_window_visible): Return bool.
 173         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 174         (tui_make_visible, tui_make_invisible)
 175         (tui_win_info::make_visible)
 176         (tui_source_window_base::make_visible, make_all_visible)
 177         (tui_make_all_visible, tui_make_all_invisible): Update.
 178         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 179         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 180         bool.
 181         (struct tui_win_info, struct tui_source_window_base)
 182         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 183         * tui/tui-data.c (tui_init_generic_part): Update.
 184
 185 2019-06-25  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 188         (tui_source_window_base::make_visible): New methods.
 189         (make_all_visible): Make method call.
 190         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 191         (struct tui_source_window_base, struct tui_cmd_window): Override
 192         make_visible.
 193         (tui_win_is_source_type): Don't declare.
 194         * tui/tui-data.c (tui_win_is_source_type): Remove.
 195
 196 2019-06-25  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 199         NULL check.
 200
 201 2019-06-25  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 204         Inline constructor.  Add initializers for members.
 205         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 206         constructors; now inline in class.
 207
 208 2019-06-25  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-regs.c (tui_show_registers): Update.
 211         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 212         bool.
 213         * tui/tui-data.c (tui_data_window::clear_detail)
 214         (tui_data_window): Update.
 215
 216 2019-06-25  Tom Tromey  <tom@tromey.com>
 217
 218         * tui/tui-windata.c (tui_display_all_data)
 219         (tui_display_data_from_line, tui_display_data_from)
 220         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 221         Update.
 222         * tui/tui-regs.c (tui_last_regs_line_no)
 223         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 224         (tui_show_registers, tui_show_register_group)
 225         (tui_display_registers_from, tui_display_reg_element_at_line)
 226         (tui_display_registers_from_line, tui_check_register_values)
 227         (tui_reg_next, tui_reg_prev): Update.
 228         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 229         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 230         tui_data_window.
 231         (struct tui_win_info) <detail>: Remove.  Add new fields from
 232         tui_data_info.
 233         (TUI_DATA_WIN): Add cast.
 234         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 235         (~tui_data_window): Simplify.
 236
 237 2019-06-25  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui-layout.c (show_source_disasm_command)
 240         (show_source_or_disasm_and_command): Update.
 241         * tui/tui-io.c (update_cmdwin_start_line)
 242         (tui_redisplay_readline): Update.
 243         * tui/tui-data.h (struct tui_command_info): Remove.
 244         (struct tui_win_info) <detail>: Remove command_info member.
 245         (struct tui_data_window) <start_line>: New member, from
 246         tui_command_info.
 247         (TUI_CMD_WIN): Add casts.
 248
 249 2019-06-25  Tom Tromey  <tom@tromey.com>
 250
 251         * tui/tui-winsource.c (tui_update_source_window)
 252         (tui_refill_source_window)
 253         (tui_source_window_base::do_scroll_horizontal)
 254         (tui_update_breakpoint_info, tui_set_exec_info_content)
 255         (tui_show_exec_info_content, tui_erase_exec_info_content)
 256         (tui_clear_exec_info_content): Update.
 257         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 258         Update.
 259         * tui/tui-win.c (make_invisible_and_set_new_height)
 260         (make_visible_with_new_height): Update.
 261         * tui/tui-source.c (tui_set_source_content)
 262         (tui_show_symtab_source): Update.
 263         * tui/tui-layout.c (extract_display_start_addr)
 264         (show_source_disasm_command, show_data)
 265         (make_source_or_disasm_window)
 266         (show_source_or_disasm_and_command): Update.
 267         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 268         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 269         "gdbarch".
 270         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 271         to tui_source_window_base.
 272         (struct tui_win_info) <detail>: Remove source_info member.
 273         (struct tui_source_window_base) <has_locator>: Inline.
 274         Move contents from tui_source_info; rename has_locator member to
 275         m_has_locator.
 276         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 277         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 278         header file.
 279         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 280         Simplify.
 281         (tui_free_all_source_wins_content): Cast to
 282         tui_source_window_base.
 283
 284 2019-06-25  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-win.c (make_invisible_and_set_new_height)
 287         (make_visible_with_new_height): Call has_locator method.
 288         * tui/tui-layout.c (show_source_disasm_command, show_data)
 289         (show_source_or_disasm_and_command): Update for bool change.
 290         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 291         (tui_win_info) <has_locator>: New method.
 292         (struct tui_source_window_base) <has_locator>: New method.
 293         (tui_win_has_locator): Don't declare.
 294         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 295         from tui_win_has_locator.
 296         (tui_source_window_base): Use false, not FALSE.
 297
 298 2019-06-25  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 301         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 302         clear_detail method directly.
 303         (tui_clear_win_detail): Remove.
 304
 305 2019-06-25  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 308         "this", not TUI_DISASM_WIN.
 309
 310 2019-06-25  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 313         declare.
 314         * tui/tui-winsource.c
 315         (tui_source_window_base::do_scroll_horizontal): Rename from
 316         tui_horizontal_source_scroll.
 317         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 318         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 319         from tui_vertical_data_scroll.
 320         * tui/tui-win.h (tui_scroll): Don't declare.
 321         * tui/tui-win.c (tui_win_info::forward_scroll)
 322         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 323         (tui_win_info::right_scroll): Rename and update.
 324         (tui_scroll_forward_command, tui_scroll_backward_command)
 325         (tui_scroll_left_command, tui_scroll_right_command): Update.
 326         (tui_scroll): Remove.
 327         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 328         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 329         from tui_vertical_source_scroll.
 330         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 331         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 332         from tui_vertical_disassem_scroll.
 333         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 334         do_scroll_horizontal>: New methods.
 335         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 336         Likewise.
 337         (struct tui_source_window_base): Add do_scroll_horizontal.
 338         (struct tui_source_window, struct tui_disasm_window): Add
 339         do_scroll_vertical.
 340         (struct tui_data_window, struct tui_cmd_window): Add
 341         do_scroll_horizontal and do_scroll_vertical.
 342         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 343
 344 2019-06-25  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-data.h (struct tui_source_window_base): New struct.
 347         (struct tui_source_window): Derive from tui_source_window_base.
 348         (struct tui_disasm_window): New struct.
 349         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 350         from tui_source_window::clear_detail.
 351         (tui_source_window_base): Rename from tui_source_window.
 352         (~tui_source_window_base): Rename from ~tui_source_window.
 353         (tui_alloc_win_info): Create a tui_disasm_window.
 354
 355 2019-06-25  Tom Tromey  <tom@tromey.com>
 356
 357         * tui/tui-data.h (struct tui_source_window)
 358         (struct tui_data_window): Declare destructors.
 359         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 360         destructors.
 361         (tui_win_info): Simplify.
 362
 363 2019-06-25  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-winsource.c (tui_display_main)
 366         (tui_update_source_windows_with_addr)
 367         (tui_update_all_breakpoint_info): Update.
 368         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 369         (new_height_ok, parse_scrolling_args): Update.
 370         * tui/tui-stack.c (tui_show_frame_info): Update.
 371         * tui/tui-data.h (struct tui_list): Remove.
 372         (tui_source_windows): Return a reference to a std::vector.
 373         * tui/tui-data.c (source_windows): Now a std::vector.
 374         (tui_source_windows): Change return type.
 375         (tui_clear_source_windows): Rewrite.
 376         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 377         (tui_free_all_source_wins_content): Rewrite.
 378
 379 2019-06-25  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 382         (struct tui_data_window, struct tui_cmd_window): Declare
 383         clear_detail method.
 384         * tui/tui-data.c (tui_source_window::clear_detail)
 385         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 386         methods.
 387         (tui_clear_win_detail): Simplify.
 388
 389 2019-06-25  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-layout.c (make_source_window, make_disasm_window)
 392         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 393         Return the new window.
 394         (show_source_disasm_command, show_data)
 395         (show_source_or_disasm_and_command): Update.
 396
 397 2019-06-25  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 400         parameter.  Return the new window.
 401         (show_source_disasm_command): Update and remove NULL check.
 402         (show_source_or_disasm_and_command): Update.
 403
 404 2019-06-25  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 407
 408 2019-06-25  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-data.h (struct tui_win_info): Make constructor
 411         protected.  Make destructor virtual.  Add initializers.
 412         (tui_source_window, tui_data_window, tui_cmd_window): New
 413         classes.
 414         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 415         constructor.  Add "type" parameter.
 416         (tui_source_window, tui_data_window, tui_cmd_window): New
 417         constructors.
 418         (tui_alloc_win_info): Instantiate the appropriate subclass.
 419
 420 2019-06-25  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-win.c (tui_resize_all): Use delete.
 423         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 424         destructor.
 425         (tui_free_window): Don't declare.
 426         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 427         Update.
 428
 429 2019-06-25  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-data.h (struct tui_win_info): Add constructor.
 432         * tui/tui-data.c (tui_alloc_win_info): Use new.
 433         (tui_free_window): Use delete.
 434
 435 2019-06-22  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 438         declare.
 439         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 440
 441 2019-06-22  Tom Tromey  <tom@tromey.com>
 442
 443         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 444         declare.
 445         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 446
 447 2019-06-22  Tom de Vries  <tdevries@suse.de>
 448
 449         * dwarf2read.c (create_addrmap_from_aranges)
 450         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 451         instead of '%zu'.
 452
 453 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 454
 455         * dwarf2read.h (dwarf2_section_info_def): Remove.
 456         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 457         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 458         std::vector<dwarf2_section_info>.
 459         (struct dwo_file) <~dwo_file>: Remove.
 460         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 461         types field.
 462         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 463         (dwarf2_read_debug_names): Likewise.
 464         (create_debug_types_hash_table): Change parameter type to
 465         array_view, adjust code accordingly.
 466         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 467         (partial_die_info::fixup): Likewise.
 468         (determine_prefix): Likewise.
 469         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 470
 471 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 472
 473         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 474         gdb_bfd_ref_ptr.
 475         <~dwo_file>: Remove call to gdb_bfd_unref.
 476         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 477         gdb_bfd_ref_ptr::get.
 478
 479 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 480
 481         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 482         type to htab_up.
 483         * dwarf2read.c (struct dwo_file): Initialize fields.
 484         <~dwo_file>: New.
 485         (free_dwo_file): Remove, move content to ~dwo_file.
 486         (struct dwo_file_deleter): Remove.
 487         (dwo_file_up>: Remove custom deleter.
 488         (free_dwo_files): Remove.
 489         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 490         dwo_files.
 491         (process_skeletonless_type_units): Call unique_ptr::get.
 492         (allocate_dwo_file_hash_table): Add deleter to created hash
 493         table.  Change return type to htab_up.
 494         (lookup_dwo_file_slot): Don't memset dwo_file, call
 495         unique_ptr::get.
 496         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 497         (create_dwo_unit_in_dwp_v2): Likewise.
 498         (open_and_init_dwo_file): Likewise.
 499         (free_dwo_file_from_slot): Remove.
 500
 501 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 502
 503         * dwarf2read.h (struct dwarf2_section_info) <readin,
 504         is_virtual>: Change type to bool.
 505         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 506         true instead of 1.
 507
 508 2019-06-19  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-data.h (tui_init_content_element): Don't declare.
 511
 512 2019-06-19  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-data.h (tui_init_win_info): Don't declare.
 515
 516 2019-06-19  Tom de Vries  <tdevries@suse.de>
 517
 518         * dwarf2read.h (abstract_to_concrete): Change type to
 519         std::unordered_map<sect_offset, std::vector<sect_offset>,
 520         gdb::hash_enum<sect_offset>>.
 521
 522 2019-06-19  Tom Tromey  <tromey@adacore.com>
 523
 524         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 525         EVAL_AVOID_SIDE_EFFECTS specially.
 526
 527 2019-06-19  Tom Tromey  <tromey@adacore.com>
 528
 529         * source-cache.c (highlighter): New global.
 530         (source_cache::get_source_lines): Create a highlighter on demand.
 531
 532 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 533
 534         * defs.h (deprecated_interactive_hook): Delete declaration.
 535         * interps.c (clear_interpreter_hooks): Remove use of
 536         deprecated_interactive_hook.
 537         * top.c (deprecated_interactive_hook): Delete definition.
 538         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 539
 540 2019-06-18  Tom de Vries  <tdevries@suse.de>
 541
 542         PR gdb/24515
 543         * dwarf2read.h (abstract_to_concrete): Change type from
 544         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 545         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 546         * dwarf2read.c (read_variable): Update.
 547         (dwarf2_fetch_die_loc_sect_off): Update.
 548
 549 2019-06-17  Tom de Vries  <tdevries@suse.de>
 550
 551         PR gdb/24617
 552         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 553         accessing parent[parent_len - 1].
 554
 555 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 556
 557         PR gdb/24364
 558         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 559         call dtrace_process_dof with NULL dof.
 560
 561 2019-06-16  Tom de Vries  <tdevries@suse.de>
 562
 563         PR gdb/24445
 564         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 565
 566 2019-06-16  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 569         (make_all_visible): Use address of member.
 570
 571 2019-06-16  Tom Tromey  <tom@tromey.com>
 572
 573         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 574         (tui_free_window, free_content, free_content_elements): Remove
 575         unnecessary cast.
 576         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 577         cast.
 578         * tui/tui-regs.c (tui_show_register_group)
 579         (tui_display_registers_from, tui_display_reg_element_at_line):
 580         Remove unnecessary cast.
 581
 582 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 583
 584         * linux-nat.c (normal_mask): Delete.
 585         (_initialize_linux_nat): Don't initialise normal_mask.
 586
 587 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 588
 589         PR gdb/24445
 590         * dwarf-index-write.h (write_psymtabs_to_index): Add
 591         dwz_basename parameter.
 592         * dwarf-index-write.c (write_gdbindex): Move file writing to
 593         write_gdbindex_1.  Change return type void.
 594         (assert_file_size): Move up, remove filename parameter.
 595         (write_gdbindex_1): New function.
 596         (write_debug_names): Change return type to void, call
 597         assert_file_size.
 598         (struct index_wip_file): New struct.
 599         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 600         file logic to index_wip_file.  Write index for dwz file if
 601         needed.
 602         (save_gdb_index_command): Pass basename of dwz file, if present.
 603         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 604         build-id of dwz file, if present.
 605         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 606         (dwarf2_get_dwz_file): Likewise.
 607         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 608         (dwarf2_get_dwz_file): Likewise.
 609
 610 2019-06-16  Tom Tromey  <tom@tromey.com>
 611
 612         * coffread.c (process_coff_symbol): Use xstrdup.
 613         * value.c (create_internalvar): Use xstrdup.
 614
 615 2019-06-16  Tom Tromey  <tom@tromey.com>
 616
 617         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 618         * breakpoint.c (stopin_command, stopat_command)
 619         (until_break_command, decode_location_default): Remove unnecessary
 620         cast.
 621         * utils.c (subset_compare): Remove unnecessary cast.
 622         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 623         cast.
 624         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 625         cast.
 626         * infcmd.c (path_command): Remove unnecessary cast.
 627         * coffread.c (decode_type): Remove unnecessary cast.
 628         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 629         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 630         * tui/tui-stack.c (tui_show_locator_content)
 631         (tui_show_frame_info): Remove unnecessary cast.
 632         * tui/tui-win.c (tui_scroll_forward_command)
 633         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 634         (parse_scrolling_args): Remove unnecessary cast.
 635         * tui/tui-data.c (init_win_info, tui_del_window)
 636         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 637         (free_content_elements): Remove unnecessary cast.
 638         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 639         unnecessary cast.
 640         * tui/tui-source.c (tui_set_source_content)
 641         (tui_vertical_source_scroll): Remove unnecessary cast.
 642         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 643         cast.
 644         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 645         * tui/tui-regs.c (tui_display_registers_from)
 646         (tui_display_register): Remove unnecessary cast.
 647         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 648         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 649         (make_visible): Remove unnecessary cast.
 650         * tui/tui-winsource.c (tui_erase_source_content)
 651         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 652         unnecessary cast.
 653         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 654         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 655         * stabsread.c (read_type, read_array_type, read_range_type):
 656         Remove unnecessary cast.
 657         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 658         (parse_symbol, parse_type, upgrade_type, parse_external)
 659         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 660         unnecessary cast.
 661         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 662
 663 2019-06-16  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-data.c (tui_alloc_generic_win_info)
 666         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 667         checks.
 668
 669 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 670             Andrew Burgess  <andrew.burgess@embecosm.com>
 671
 672         * f-typeprint.c (f_print_type): Don't return early for not
 673         associated or not allocated types.
 674         (f_type_print_varspec_suffix): Add print_rank parameter and print
 675         ranks of array types in case they dangling.
 676         (f_type_print_base): Add print_rank parameter.
 677
 678 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 679
 680         * NEWS: Mention new MI commands.
 681         * break-catch-throw.c (enum exception_event_kind): Move to
 682         breakpoint.h.
 683         (print_mention_exception_catchpoint): Output text as a single
 684         message.
 685         (catch_exception_command_1): Rename to...
 686         (catch_exception_event): ...this, make non-static, update header
 687         command, and change some parameter types.
 688         (catch_catch_command): Update for changes to
 689         catch_exception_command_1.
 690         (catch_throw_command): Likewise.
 691         (catch_rethrow_command): Likewise.
 692         * breakpoint.c (enum exception_event_kind): Delete.
 693         * breakpoint.h (enum exception_event_kind): Moved here from
 694         break-catch-throw.c.
 695         (catch_exception_event): Declare.
 696         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 697         (mi_cmd_catch_throw): New function.
 698         (mi_cmd_catch_rethrow): New function.
 699         (mi_cmd_catch_catch): New function.
 700         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 701         'catch-catch' entries.
 702         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 703         (mi_cmd_catch_rethrow): Declare.
 704         (mi_cmd_catch_catch): Declare.
 705
 706 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 707
 708         * annotate.c (annotate_source_line): Change return type to void,
 709         update implementation to match.
 710         * annotate.h (annotate_source_line): Change return type to void,
 711         update header comment.
 712         * stack.c (print_frame_info): Don't change what frame information
 713         is printed based on whether annotations are on or not.
 714
 715 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 716
 717         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 718         (annotate_source): Make static.
 719         (annotate_source_line): Moved from source.c and renamed from
 720         identify_source_line.  Update the return type.
 721         * annotate.h (annotate_source): Delete declaration.
 722         (annotate_source_line): Declaration moved from source.h, and
 723         renamed from identify_source_line.  Return type updated.
 724         * source.c (identify_source_line): Moved to annotate.c and renamed
 725         to annotate_source_line.
 726         (info_line_command): Remove check of annotation_level.
 727         * source.h (identify_source_line): Move declaration to annotate.h
 728         and rename to annotate_source_line.
 729         * stack.c: Add 'annotate.h' include.
 730         (print_frame_info): Remove check of annotation_level before
 731         calling annotate_source_line.
 732
 733 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         * source-cache.c (source_cache::get_plain_source_lines): Use
 736         open_source_file_with_line_charpos instead of just
 737         open_source_file, remove call to find_source_lines.
 738         (source_cache::get_source_lines): Likewise.
 739         * source.c (find_source_lines): Make static.
 740         (get_filename_and_charpos): Renamed into...
 741         (open_source_file_with_line_charpos): ..this along with changes to
 742         return a scoped_fd, and some other minor clean ups.
 743         (identify_source_line): Use open_source_file_with_line_charpos.
 744         (search_command_helper): Use open_source_file_with_line_charpos
 745         instead of just open_source_file, remove call to
 746         find_source_lines.
 747         * source.h (open_source_file_with_line_charpos): Declare new
 748         function.
 749         (find_source_lines): Delete declaration.
 750
 751 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 752
 753         * source.c (get_filename_and_charpos): Remove fullname
 754         parameter.
 755         (identify_source_line): Update call to get_filename_and_charpos.
 756
 757 2019-06-14  Tom Tromey  <tromey@adacore.com>
 758
 759         PR gdb/24502:
 760         * ui-style.h (skip_ansi_escape): Update comment.
 761         * ui-file.h (class no_terminal_escape_file): New class.
 762         * ui-file.c (no_terminal_escape_file::write)
 763         (no_terminal_escape_file::puts): New methods.
 764         * cli/cli-logging.c (handle_redirections): Use
 765         no_terminal_escape_file.
 766
 767 2019-06-14  Tom Tromey  <tromey@adacore.com>
 768
 769         * NEWS: Move convenience variable news above Python news.
 770
 771 2019-06-14  Tom Tromey  <tom@tromey.com>
 772
 773         * gnulib: Move directory to top-level.
 774         * configure.ac: Don't configure gnulib.
 775         * configure: Rebuild.
 776         * common/common-defs.h: Use new path to gnulib.
 777         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 778         (GNULIB_H): Remove.
 779         (INCGNU): Look in new gnulib location.
 780         (HFILES_NO_SRCDIR): Remove gnulib files.
 781         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 782         (generated_files): Remove GNULIB_H.
 783         ($(LIBGNU), all-lib): Remove targets.
 784         (distclean): Don't mention GNULIB_BUILDDIR.
 785         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 786
 787 2019-06-14  Tom Tromey  <tromey@adacore.com>
 788
 789         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 790         Warn if symbol file does not provide any symbols.
 791
 792 2019-06-14  Tom Tromey  <tromey@adacore.com>
 793
 794         * source.c (find_and_open_source): Respect basenames_may_differ.
 795
 796 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 797
 798         * annotate.c (annotate_breakpoints_invalid): Make use of
 799         scoped_restore_terminal_state.
 800         (annotate_frames_invalid): Likewise.
 801
 802 2019-06-14  Tom Tromey  <tromey@adacore.com>
 803
 804         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 805         allow assignment to an internalvar.
 806
 807 2019-06-14  Tom Tromey  <tromey@adacore.com>
 808
 809         * ada-lex.l: Allow "_" in attribute names.
 810
 811 2019-06-14  Tom Tromey  <tromey@adacore.com>
 812
 813         PR gdb/24653:
 814         * regcache.c (registers_changed): Don't call alloca.
 815         * top.c (execute_command): Don't call alloca.
 816
 817 2019-06-13  Pedro Alves  <palves@redhat.com>
 818
 819         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 820         'expression'.  When parsing an expression, error out if there's
 821         junk after "unlimited".
 822         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 823         (do_set_command): Adjust calls to is_unlimited_literal.
 824
 825 2019-06-13  Pedro Alves  <palves@redhat.com>
 826
 827         * compile/compile.c (make_compile_options_def_group): Add braces
 828         around array_view initializer.
 829         * thread.c (make_thread_apply_all_options_def_group)
 830         (make_thread_apply_all_options_def_group): Likewise.
 831
 832 2019-06-13  Pedro Alves  <palves@redhat.com>
 833
 834         * NEWS (New commands): Mention "maint test-options
 835         require-delimiter", "maint test-options unknown-is-error", "maint
 836         test-options unknown-is-operand" and "maint show
 837         test-options-completion-result".
 838         (New command options, command completion): New section.
 839         (Completion improvements): New section.
 840         Mention that you can abbreviate "unlimited".
 841
 842 2019-06-13  Pedro Alves  <palves@redhat.com>
 843
 844         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 845         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 846         * unittests/cli-utils-selftests.c (test_parse_flags)
 847         (test_parse_flags_qcs): Delete.
 848         (test_cli_utils): Don't call deleted functions.
 849
 850 2019-06-13  Pedro Alves  <palves@redhat.com>
 851
 852         * thread.c: Include "cli/cli-option.h".
 853         (tp_array_compar_ascending): Global.
 854         (tp_array_compar): Delete function.
 855         (tp_array_compar_ascending, tp_array_compar_descending): New
 856         functions.
 857         (ascending_option_def, qcs_flag_option_def)
 858         (thr_qcs_flags_option_defs)
 859         (make_thread_apply_all_options_def_group)
 860         (make_thread_apply_options_def_group): New.
 861         (thread_apply_all_command): Use gdb::option::process_options.
 862         (thread_apply_command_completer)
 863         (thread_apply_all_command_completer): New.
 864         (thread_apply_command): Use gdb::option::process_options.
 865         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 866         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 867         to generate help text of "thread apply".  Adjust "taas"'s help.
 868         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 869         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 870
 871 2019-06-13  Pedro Alves  <palves@redhat.com>
 872
 873         * thread.c (thread_apply_command): Check for invalid TID with
 874         isdigit instead of !isalpha.
 875
 876 2019-06-13  Pedro Alves  <palves@redhat.com>
 877
 878         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 879         (validate_flags_qcs): New.
 880         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 881         (validate_flags_qcs): Declare.
 882         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 883         (make_frame_apply_options_def_group): New.
 884         (frame_apply_command_count): Process options with
 885         gdb::option::process_options.
 886         (frame_apply_completer): New.
 887         (frame_apply_level_completer, frame_apply_all_completer)
 888         (frame_apply_completer): New.
 889         (_initialize_stack): Update help of "frame apply", "frame apply
 890         level", "frame apply all" and "faas" to mention supported options
 891         and install command completers.
 892         * stack.h (frame_apply_all_completer): Declare.
 893         * thread.c: Include "stack.h".
 894         (tfaas_command): Add "--".
 895         (_initialize_thread): Update help "tfaas" to mention supported
 896         options and install command completer.
 897
 898 2019-06-13  Pedro Alves  <palves@redhat.com>
 899
 900         * completer.c (complete_nested_command_line): New.
 901         (gdb_completion_word_break_characters_throw): Add assertion.
 902         * completer.h (complete_nested_command_line): Declare.
 903
 904 2019-06-13  Pedro Alves  <palves@redhat.com>
 905
 906         * stack.c (parse_backtrace_qualifiers): New.
 907         (backtrace_command): Use it.
 908         (backtrace_command_completer): Complete on qualifiers.
 909
 910 2019-06-13  Pedro Alves  <palves@redhat.com>
 911
 912         * frame.c: Include "cli/cli-option.h.
 913         (user_set_backtrace_options): New.
 914         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 915         Delete.
 916         (get_prev_frame): Adjust.
 917         (boolean_option_def, uinteger_option_def)
 918         (set_backtrace_option_defs): New.
 919         (_initialize_frame): Adjust and use
 920         gdb::option::add_setshow_cmds_for_options to install "set
 921         backtrace past-main" and "set backtrace past-entry".
 922         * frame.h: Include "cli/cli-option.h".
 923         (struct frame_print_options): Forward declare.
 924         (print_frame_arguments_all, print_frame_arguments_scalars)
 925         (print_frame_arguments_none): Declare.
 926         (print_entry_values): Delete declaration.
 927         (struct frame_print_options, user_frame_print_options): New.
 928         (struct set_backtrace_options): New.
 929         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 930         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 931         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 932         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 933         (list_args_or_locals): Add frame_print_options parameter.
 934         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 935         * python/py-framefilter.c (enumerate_args): Pass down
 936         USER_FRAME_PRINT_OPTIONS.
 937         * stack.c: Include "cli/cli-option.h".
 938         (print_frame_arguments_all, print_frame_arguments_scalars)
 939         (print_frame_arguments_none): Declare.
 940         (print_raw_frame_arguments, print_entry_values): Delete.
 941         (user_frame_print_options): New.
 942         (boolean_option_def, enum_option_def, frame_print_option_defs):
 943         New.
 944         (struct backtrace_cmd_options): New.
 945         (bt_flag_option_def): New.
 946         (backtrace_command_option_defs): New.
 947         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 948         (print_frame_arg, read_frame_arg, print_frame_args)
 949         (print_frame_info, print_frame): Add frame_print_options parameter
 950         and use it.
 951         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 952         (backtrace_command_1): Add frame_print_options and
 953         backtrace_cmd_options parameters and use them.
 954         (make_backtrace_options_def_group): New.
 955         (backtrace_command): Process command options with
 956         gdb::option::process_options.
 957         (backtrace_command_completer): New.
 958         (_initialize_stack): Extend "backtrace"'s help to mention
 959         supported options.  Install completer for "backtrace".
 960         Install some settings commands with add_setshow_cmds_for_options.
 961
 962 2019-06-13  Pedro Alves  <palves@redhat.com>
 963
 964         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 965         and that "set/show print raw frame-arguments" are now deprecated.
 966
 967         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 968         command.
 969         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 970         * stack.c (_initialize_stack): Install "set/show print
 971         raw-frame-arguments", and deprecate "set/show print raw
 972         frame-arguments".
 973         * valprint.c (_initialize_valprint): Deprecate "set/show print
 974         raw".
 975
 976 2019-06-13  Pedro Alves  <palves@redhat.com>
 977
 978         * compile/compile.c (struct compile_options): New.
 979         (compile_flag_option_def, compile_command_option_defs)
 980         (make_compile_options_def_group): New.
 981         (compile_file_command): Handle options with
 982         gdb::option::process_options.
 983         (compile_file_command_completer): New function.
 984         (compile_code_command): Handle options with
 985         gdb::option::process_options.
 986         (compile_code_command_completer): New function.
 987         (_initialize_compiler): Install completers for "compile code" and
 988         "compile file".  Mention available options in "compile code" and
 989         "compile code"'s help.
 990         * completer.c (advance_to_completion_word): New, factored out from
 991         ...
 992         (advance_to_expression_complete_word_point): ... this.
 993         (advance_to_filename_complete_word_point): New.
 994         * completer.h (advance_to_filename_complete_word_point): New
 995         declaration.
 996
 997 2019-06-13  Pedro Alves  <palves@redhat.com>
 998
 999         * compile/compile.c: Include "cli/cli-option.h".
1000         (compile_print_value): Scope data pointer is now a
1001         value_print_options pointer; adjust.
1002         (compile_print_command): Process options.  Scope data pointer is
1003         now a value_print_options pointer; adjust.
1004         (_initialize_compile): Update "compile print"'s help to include
1005         supported options.  Install a completer for "compile print".
1006         * cp-valprint.c (show_vtblprint, show_objectprint)
1007         (show_static_field_print): Delete.
1008         (_initialize_cp_valprint): Don't install "set print
1009         static-members", "set print vtbl", "set print object" here.
1010         * printcmd.c: Include "cli/cli-option.h" and
1011         "common/gdb_optional.h".
1012         (print_command_parse_format): Rework to fill in a
1013         value_print_options instead of a format_data.
1014         (print_value): Change parameter type from format_data pointer to
1015         value_print_options reference.  Adjust.
1016         (print_command_1): Process options.  Adjust to pass down a
1017         value_print_options.
1018         (print_command_completer): New.
1019         (_initialize_printcmd): Install print_command_completer as
1020         handle_brkchars completer for the "print" command.  Update
1021         "print"'s help to include supported options.
1022         * valprint.c: Include "cli/cli-option.h".
1023         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1024         here from cp-valprint.c.
1025         (boolean_option_def, uinteger_option_def)
1026         (value_print_option_defs, make_value_print_options_def_group):
1027         New.  Use gdb::option::add_setshow_cmds_for_options to install
1028         "set print elements", "set print null-stop", "set print repeats",
1029         "set print pretty", "set print union", "set print array", "set
1030         print address", "set print symbol", "set print array-indexes".
1031         * valprint.h: Include <string> and "cli/cli-option.h".
1032         (make_value_print_options_def_group): Declare.
1033         (print_value): Change parameter type from format_data pointer to
1034         value_print_options reference.
1035         (print_command_completer): Declare.
1036
1037 2019-06-13  Pedro Alves  <palves@redhat.com>
1038
1039         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1040         (COMMON_SFILES): Add maint-test-settings.c.
1041         * cli/cli-decode.c (boolean_enums): New global, factored out from
1042         ...
1043         (add_setshow_boolean_cmd): ... here.
1044         * cli/cli-decode.h (boolean_enums): Declare.
1045         * cli/cli-option.c: New file.
1046         * cli/cli-option.h: New file.
1047         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1048         factored out from ...
1049         (parse_cli_boolean_value(const char *)): ... this.
1050         (is_unlimited_literal): Change parameter type to pointer to
1051         pointer.  Adjust and advance ARG pointer.
1052         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1053         (parse_cli_var_enum): New, factored out from ...
1054         (do_set_command): ... this.  Adjust.
1055         * cli/cli-setshow.h (parse_cli_boolean_value)
1056         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1057         (parse_cli_var_enum): Declare.
1058         * cli/cli-utils.c: Include "cli/cli-option.h".
1059         (get_ulongest): New.
1060         * cli/cli-utils.h (get_ulongest): Declare.
1061         (check_for_argument): New overloads.
1062         * maint-test-options.c: New file.
1063
1064 2019-06-13  Pedro Alves  <palves@redhat.com>
1065
1066         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1067         parse a range if "-" is at the end of the string.
1068
1069 2019-06-13  Pedro Alves  <palves@redhat.com>
1070
1071         * cli/cli-setshow.c (parse_auto_binary_operation)
1072         (parse_cli_boolean_value): Don't allow "o".
1073
1074 2019-06-13  Pedro Alves  <palves@redhat.com>
1075
1076         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1077         * NEWS: Mention maint test-settings KIND.
1078         * maint-test-settings.c: New file.
1079
1080 2019-06-13  Pedro Alves  <palves@redhat.com>
1081
1082         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1083         completer.
1084         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1085         "set" completers.
1086
1087 2019-06-13  Pedro Alves  <palves@redhat.com>
1088
1089         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1090         after item.
1091
1092 2019-06-13  Pedro Alves  <palves@redhat.com>
1093
1094         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1095
1096 2019-06-13  Pedro Alves <palves@redhat.com>
1097
1098         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1099         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1100         call.
1101         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1102         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1103         calls.
1104         (check_for_argument): Skip spaces after argument.
1105
1106 2019-06-13  Pedro Alves  <palves@redhat.com>
1107
1108         * thread.c (thread_apply_command): Adjust TID parsing.
1109         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1110         detected before end of string.
1111         (tid_is_in_list): Error out if LIST is invalid.
1112
1113 2019-06-13  Pedro Alves  <palves@redhat.com>
1114
1115         * completer.c (complete_line_internal_1): Rewind completion word
1116         point.
1117         (completion_tracker::advance_custom_word_point_by): Change
1118         parameter type to int.
1119         * completer.h (completion_tracker::advance_custom_word_point_by):
1120         Likewise.
1121
1122 2019-06-13  Pedro Alves  <palves@redhat.com>
1123
1124         * completer.c (advance_to_completion_word): Handle delimiters.
1125
1126 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1127
1128         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1129
1130 2019-06-11  Tom Tromey  <tom@tromey.com>
1131
1132         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1133         (xmalloc_failed): Move to alloc.c.
1134         * alloc.c: New file.
1135         * Makefile.in (COMMON_SFILES): Add alloc.c.
1136
1137 2019-06-11  Tom Tromey  <tom@tromey.com>
1138
1139         * nat/linux-waitpid.c: Don't include server.h.
1140         (linux_debug): Remove.
1141         (my_waitpid): Update.
1142
1143 2019-06-11  Tom Tromey  <tromey@adacore.com>
1144
1145         * infcall.c (_initialize_infcall): Remove trailing newline from
1146         help.
1147         * user-regs.c (_initialize_user_regs): Remove trailing newline
1148         from help.
1149         * typeprint.c (_initialize_typeprint): Remove trailing newline
1150         from help.
1151         * reverse.c (_initialize_reverse): Remove trailing newlines from
1152         help.
1153         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1154         from help.
1155         * language.c (add_set_language_command): Remove trailing newline
1156         from help.
1157         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1158         help.
1159         * disasm.c (_initialize_disasm): Remove trailing newline from
1160         help.
1161         * top.c (init_main): Remove trailing newline from help.
1162         * interps.c (_initialize_interpreter): Remove trailing newline
1163         from help.
1164         * btrace.c (_initialize_btrace): Remove trailing newlines from
1165         help.
1166         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1167         from help.
1168         * python/python.c (_initialize_python): Remove trailing newline
1169         from help.
1170         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1171         help.
1172         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1173         from help.  Reformat some text.
1174         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1175         from help.
1176         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1177         newline from help.
1178
1179 2019-06-11  Tom Tromey  <tromey@adacore.com>
1180
1181         * darwin-nat.c (darwin_decode_exception_message)
1182         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1183
1184 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * valops.c (value_slice): Check for not allocated or not
1187         associated values.
1188
1189 2019-06-10  Tom de Vries  <tdevries@suse.de>
1190
1191         PR gdb/24618
1192         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1193         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1194         invalid.
1195
1196 2019-06-10  Tom de Vries  <tdevries@suse.de>
1197
1198         PR gdb/24611
1199         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1200         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1201
1202 2019-06-10  Tom de Vries  <tdevries@suse.de>
1203
1204         PR symtab/24545
1205         * symtab.c (struct demangled_name_entry): Add language field.
1206         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1207         static minimal symbol".  Set and use language field.
1208
1209 2019-06-10  Tom Tromey  <tromey@adacore.com>
1210
1211         * ada-lang.c (_initialize_ada_language): Update help text.
1212
1213 2019-06-10  Tom Tromey  <tromey@adacore.com>
1214
1215         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1216         with a newline.
1217         * guile/guile.c (handle_boot_error): Don't end warning with a
1218         newline.
1219         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1220         warning with a newline.
1221         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1222         newline.
1223         (s12z_frame_cache): Likewise.
1224         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1225         a newline.
1226         * solib-svr4.c (disable_probes_interface): Don't end warning with
1227         a newline.
1228         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1229         newline.
1230         * python/python.c (do_finish_initialization): Don't end warning
1231         with a newline.
1232
1233 2019-06-10  Tom Tromey  <tom@tromey.com>
1234
1235         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1236         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1237         gdbpy_enter.
1238
1239 2019-06-10  Tom Tromey  <tromey@adacore.com>
1240
1241         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1242         data.
1243         (elf_new_init): Don't call stabsread_new_init.
1244         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1245         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1246         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1247
1248 2019-06-10  Tom de Vries  <tdevries@suse.de>
1249
1250         PR symtab/16264
1251         PR symtab/24517
1252         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1253
1254 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1255
1256         * source.c (find_and_open_source): Also rewrite relative file
1257         names.
1258
1259 2019-04-26  Amos Bird  <amosbird@gmail.com>
1260
1261         * annotate.c (annotate_thread_exited): Add "thread-exited"
1262         annotation.
1263
1264 2019-06-06  Tom Tromey  <tromey@adacore.com>
1265
1266         * maint.h (class scoped_command_stats): Use
1267         DISABLE_COPY_AND_ASSIGN.
1268         <print_time>: New method.
1269         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1270         print_time.
1271         (scoped_command_stats::print_time): New method.
1272
1273 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1274
1275         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1276         instructions of lengths 6 or 8 bytes.
1277
1278 2019-06-04  Pedro Alves  <palves@redhat.com>
1279
1280         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1281
1282         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1283         * breakpoint.c (condition_completer): Likewise.
1284         * cli/cli-dump.c (scan_expression): Likewise.
1285         * common/filestuff.c (mkdir_recursive): Likewise.
1286         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1287         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1288         (gdb_abspath): Likewise.
1289         * compile/compile-cplus-types.c
1290         (compile_cplus_instance::decl_name): Likewise.
1291         * completer.c (complete_explicit_location):
1292         (signal_completer, reg_or_group_completer_1): Likewise.
1293         * cp-support.c (cp_remove_params_if_any): Likewise.
1294         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1295         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1296         * infcmd.c (strip_bg_char): Likewise.
1297         * linespec.c (copy_token_string): Likewise.
1298         * mi/mi-main.c (output_cores): Likewise.
1299         * psymtab.c (psymtab_search_name):
1300         * symfile.c (test_set_ext_lang_command): Likewise.
1301         * target.c (target_fileio_read_stralloc): Likewise.
1302         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1303         * value.c (complete_internalvar): Likewise.
1304
1305 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1306
1307         Add objfile property to gdb.Type.
1308         * NEWS: Mention Python API addition.
1309         * python/py-type.c (typy_get_objfile): New method.
1310
1311 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1312
1313         * NEWS: Mention the new set|show style [title|highlight].
1314         Mention changes to "show style", "help" and "apropos".
1315
1316 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1317
1318         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1319         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1320         instead of print_help_for_command.
1321         (print_doc_of_command): New function.
1322         (help_list): Add 'apropos -v word' suggestion.
1323         (print_help_for_command): Style the command name using title style.
1324         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1325         (_initialize_cli_cmds): Describe -v in apropos_command help.
1326
1327 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1328
1329         * cli/cli-style.h (cli_style_option): Add name in constructor,
1330         add m_name class member, add constructor with intensity,
1331         add name class function.
1332         (cli_style_option::add_setshow_commands): Remove name argument.
1333         (highlight_style, title_style): New styles.
1334         * cli/cli-style.c (do_show): New function that shows a style
1335         characteristic styling the style name with itself.
1336         (set_style_name): New function.
1337         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1338         Update all callers according to the changes in cli/cli-style.h.
1339         * utils.h (fputs_highlighted): New function.
1340         * utils.c (fputs_highlighted): Likewise.
1341
1342 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1343
1344         * NEWS: Mention new pipe command and new convenience variables.
1345
1346 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1347
1348         * cli/cli-cmds.c (pipe_command): New function.
1349         (_initialize_cli_cmds): Call add_com for pipe_command.
1350         Define | as an alias for pipe.
1351         (exit_status_set_internal_vars): New function.
1352         (shell_escape): Call exit_status_set_internal_vars.
1353         cli/cli-decode.c (find_command_name_length): Recognize | as
1354         a single character command.
1355
1356 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1357
1358         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1359         top.c (execute_command_to_ui_file): New function, mostly a copy
1360         of execute_command_to_string.
1361         (execute_command_to_string): Implement by calling
1362         execute_command_to_ui_file.
1363
1364 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1365
1366         * top.h (saved_command_line): Remove declaration.
1367         * top.c (previous_saved_command_line, previous_repeat_arguments):
1368         New variables.
1369         (saved_command_line): Make static, define together with other
1370         'repeat variables'.
1371         (dont_repeat): Clear repeat_arguments.
1372         (repeat_previous, get_saved_command_line, save_command_line):
1373         New functions.
1374         (gdb_init): Initialize saved_command_line
1375         and previous_saved_command_line.
1376         * main.c (captured_main_1): Remove saved_command_line initialization.
1377         * event-top.c (handle_line_of_input): Update to use
1378         the new 'repeat' related functions instead of direct access to
1379         saved_command_line.
1380         * command.h (repeat_previous, get_saved_command_line,
1381         save_command_line): New declarations.
1382         (dont_repeat): Add comment.
1383
1384 2019-05-30  Tom Tromey  <tromey@adacore.com>
1385
1386         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1387         Fix comment.
1388         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1389
1390 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1391
1392         PR cli/24587
1393         * completer.c (complete): Initialize variable word.
1394
1395 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1396
1397         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1398         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1399         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1400         'body' is NULL to the outter 'if', protecting the '!is_define'
1401         situation as well.
1402
1403 2019-05-29  Tom Tromey  <tromey@adacore.com>
1404
1405         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1406         (dwarf_unknown): New function.
1407         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1408         (dwarf_type_encoding_name): Use dwarf_unknown.
1409
1410 2019-05-29  Tom Tromey  <tromey@adacore.com>
1411
1412         PR c++/20020:
1413         * cp-valprint.c (cp_print_value_fields): Call
1414         cp_print_static_field inside "try".
1415
1416 2019-05-29  Tom Tromey  <tromey@adacore.com>
1417
1418         * inflow.c (struct terminal_info): Add default operator=.
1419         * configure: Rebuild.
1420         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1421         -Wdeprecated-copy-dtor, -Wredundant-move.
1422
1423 2019-05-29  Tom Tromey  <tromey@adacore.com>
1424
1425         * NEWS: Add entry.
1426         * infcmd.c (print_return_value_1): Handle finish_print
1427         option.
1428         (show_print_finish): New function.
1429         (_initialize_infcmd): Add "set/show print finish" commands.
1430         * valprint.c (user_print_options): Initialize new member.
1431         * valprint.h (struct value_print_options) <finish_print>: New
1432         member.
1433
1434 2019-05-28  Tom Tromey  <tromey@adacore.com>
1435
1436         * ada-lang.c (ada_remove_Xbn_suffix)
1437         (find_old_style_renaming_symbol)
1438         (parse_old_style_renaming): Remove.
1439         (ada_find_renaming_symbol): Don't call
1440         find_old_style_renaming_symbol.
1441         (ada_is_renaming_symbol): Rename from
1442         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1443         bool.  Now static.
1444         (ada_read_var_value): Update and simplify.
1445         * ada-exp.y (write_var_or_type): Remove old code.
1446
1447 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1448
1449         * event-top.c: Remove include comment.
1450         * inflow.c (class scoped_ignore_sigttou): Move from here...
1451         * inflow.h (class scoped_ignore_sigttou): ...to here.
1452         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1453         * top.c:  Remove include comment.
1454
1455 2019-05-27  Tom Tromey  <tom@tromey.com>
1456
1457         * NEWS: Fix typo.
1458
1459 2019-05-22  Tom Tromey  <tromey@adacore.com>
1460
1461         * target.c (target_follow_exec): Constify parameter.
1462         * target-delegates.c: Rebuild.
1463         * remote.c (remote_target::follow_exec): Constify parameter.
1464         * infrun.c (follow_exec): Constify parameter.
1465         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1466         (target_follow_exec): Likewise.
1467
1468 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1469
1470         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1471         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1472
1473 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1474
1475         * NEWS: Add debugredirect and testsuite sections.
1476
1477 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1478
1479         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1480         target descriptions using exclusively floating point register name
1481         aliases.
1482
1483 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1484
1485         PR gdb/18644:
1486         * f-lang.c (build_fortran_types): Handle the case where
1487         gdbarch_floatformat_for_type returns a nullptr.
1488
1489 2019-05-21  Tom de Vries  <tdevries@suse.de>
1490
1491         PR cli/24587
1492         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1493
1494 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1495
1496         PR gdb/18644:
1497         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1498         16-byte floats.
1499         * i386-tdep.c (i386_floatformat_for_type): Use
1500         floatformats_ia64_quad for the 16-byte floating point component
1501         within a fortran 32-byte complex number.
1502
1503 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1504
1505         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1506         delete default constructor.
1507         (find_partial_die): Update to return const struct.
1508         (partial_die_parent_scope): Move variable declaration into scope
1509         of its use and change its type to auto.
1510         (guess_partial_die_structure_name): Likewise.
1511         (partial_die_info::fixup): Likewise.
1512
1513 2019-05-17  Tom Tromey  <tromey@adacore.com>
1514
1515         * source.c (find_and_open_source): Remove cast.
1516
1517 2019-05-17  Tom Tromey  <tromey@adacore.com>
1518
1519         * annotate.c (annotate_source): Make "filename" const.
1520         * annotate.h (annotate_source): Use const.
1521
1522 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1523
1524         * disasm.c (set_disassembler_options): Send errors to stderr.
1525
1526 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1527
1528         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1529         (cli_interp_base::set_logging): Check debug_redirect.
1530         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1531         * cli/cli-logging.c (debug_redirect): Add static variable.
1532         (pop_output_files): Add default param.
1533         (handle_redirections): Print debug setting.
1534         (show_logging_command): Likewise.
1535         (_initialize_cli_logging): Add debugredirect command.
1536         * interps.c (current_interp_set_logging): Add debug_redirect
1537         parameter.
1538         * interps.h (set_logging): Add debug_redirect parameter.
1539         (current_interp_set_logging): Likewise.
1540         * mi/mi-common.h: Likewise.
1541         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1542
1543 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1544             Tom Tromey  <tromey@adacore.com>
1545
1546         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1547         directly.
1548         * cli/cli-interp.h (make_logging_output): Remove declaration.
1549         * cli/cli-logging.c (make_logging_output): Remove function.
1550         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1551         directly.
1552         * ui-file.c (tee_file::tee_file): Remove bools.
1553         (tee_file::~tee_file): Remove deletes.
1554         * ui-file.h (tee_file): Remove bools.
1555
1556 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1557
1558         * mi/mi-cmds.h (mi_cmd_complete): New function.
1559         * mi/mi-main.c (mi_cmd_complete): Likewise.
1560         * mi/mi-cmds.c: Define new MI command -complete.
1561         * NEWS: Mention new -complete command.
1562
1563 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1564
1565         * completer.h (complete): New function.
1566         * completer.c (complete): Likewise.
1567         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1568         function defined in completer.h.
1569
1570 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1571
1572         * MAINTAINERS (Write After Approval): Add myself.
1573
1574 2019-05-17  Tom de Vries  <tdevries@suse.de>
1575
1576         PR gdb/24094
1577         * dwarf2read.c (struct cu_partial_die_info): New struct.
1578         (find_partial_die): Return cu_partial_die_info.
1579         (partial_die_parent_scope, guess_partial_die_structure_name)
1580         (partial_die_info::fixup): Handle new return type of find_partial_die.
1581
1582 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1583
1584         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1585         "std::string", simplifying the algorithm.
1586
1587 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1588
1589         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1590         (stap_static_probe_ops::get_probes): Likewise.
1591
1592 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1593
1594         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1595         '-')" and "else if".
1596         (stap_parse_single_operand): Join checks for
1597         "gdbarch_stap_parse_special_token_p" and
1598         "gdbarch_stap_parse_special_token" in the same "if" statement.
1599         Invert check when verifying for operation on register
1600         displacement.
1601
1602 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1603
1604         * stap-probe.c (stap_get_opcode): Update comment.
1605         (stap_get_expected_argument_type): Likewise.
1606         (handle_stap_probe): Likewise.
1607
1608 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1609
1610         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1611         return type to 'bool'.  Adjust comment.  Use 'bool' when
1612         appropriate.
1613         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1614         * stap-probe.c (stap_parse_argument_1): Likewise.
1615         (stap_is_operator): Likewise.
1616         (stap_is_generic_prefix): Likewise.
1617         (stap_is_register_prefix): Likewise.
1618         (stap_is_register_indirection_prefix): Likewise.
1619         (stap_is_integer_prefix): Likewise.
1620         (stap_generic_check_suffix): Likewise.
1621         (stap_check_integer_suffix): Likewise.
1622         (stap_check_register_suffix): Likewise.
1623         (stap_check_register_indirection_suffix): Likewise.
1624         (stap_parse_register_operand): Likewise.
1625         (stap_parse_single_operand): Likewise.
1626         (stap_parse_argument_1): Likewise.
1627         (stap_probe::get_argument_count): Likewise.
1628         (stap_is_operator): Likewise.
1629
1630 2019-05-16  Tom Tromey  <tromey@adacore.com>
1631
1632         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1633         keyword to foreach.
1634
1635 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1636
1637         * linux-thread-db.c (try_thread_db_load_1): Change return type
1638         to bool.
1639         (try_thread_db_load): Likewise.
1640         (try_thread_db_load_from_pdir_1): Likewise.
1641         (try_thread_db_load_from_pdir): Likewise.
1642         (try_thread_db_load_from_sdir): Likewise.
1643         (try_thread_db_load_from_dir): Likewise.
1644         (thread_db_load_search): Likewise.
1645         (has_libpthread): Likewise.
1646         (thread_db_load): Likewise.
1647
1648 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1649
1650         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1651         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1652         NULL, and complain/return if that's the case.
1653
1654 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1655
1656         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1657         (advance, posn, abstract_read_memory): New functions.
1658         [struct mem_read_abstraction]: New struct.
1659         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1660
1661 2019-05-14  Tom Tromey  <tromey@adacore.com>
1662
1663         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1664         value is not lval_memory.
1665
1666 2019-05-14  Tom Tromey  <tromey@adacore.com>
1667
1668         * solib.c (info_sharedlibrary_command): Style the file name.
1669
1670 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1671
1672         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1673         (aarch64_vnv_type): Likewise.
1674         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1675         * common/tdesc.c: Likewise.
1676         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1677         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1678         * features/aarch64-fpu.xml: Add ieee half view.
1679         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1680         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1681         * gdbtypes.h (struct builtin_type): Likewise.
1682         (struct objfile_type): Likewise.
1683
1684 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1685
1686         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1687         typo.
1688         * location.h (string_to_event_location): Likewise.
1689
1690 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1691
1692         GDB 8.3 released.
1693
1694 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1695
1696         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1697         New variable declaration.
1698         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1699         New variable.
1700         (print_one_breakpoint): Use ui_out::test_flags and new global
1701         variable to compute use_fixed_output.
1702         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1703         Remove.
1704         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1705         (mi_multi_location_breakpoint_output_fixed): Remove.
1706         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1707         new variable.
1708         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1709         fix_multi_location_breakpoint_output flag if version >= 3.
1710         * ui-out.h (enum ui_out_flag)
1711         <fix_multi_location_breakpoint_output>: New enumerator.
1712
1713 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1714
1715         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1716
1717 2019-05-10  Tom Tromey  <tromey@adacore.com>
1718
1719         * ada-lang.c (catch_ada_completer): New function.
1720         (_initialize_ada_language): Use it.
1721
1722 2019-05-10  Tom Tromey  <tromey@adacore.com>
1723
1724         * thread.c (print_thread_info): Make "requested_threads" const.
1725         * gdbthread.h (print_thread_info): Make "requested_threads"
1726         const.
1727         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1728         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1729
1730 2019-05-08  Tom Tromey  <tom@tromey.com>
1731
1732         * gdbtypes.c (objfile_type_data): Change type.
1733         (objfile_type, _initialize_gdbtypes): Update.
1734
1735 2019-05-08  Tom Tromey  <tom@tromey.com>
1736
1737         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1738         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1739         (_initialize_dwarf2_frame): Update.
1740
1741 2019-05-08  Tom Tromey  <tom@tromey.com>
1742
1743         * objc-lang.c (objc_objfile_data): Change type.
1744         (find_methods): Update.
1745         (_initialize_objc_lang): Remove.
1746
1747 2019-05-08  Tom Tromey  <tom@tromey.com>
1748
1749         * stabsread.c (rs6000_builtin_type_data): Change type.
1750         (rs6000_builtin_type, _initialize_stabsread): Update.
1751
1752 2019-05-08  Tom Tromey  <tom@tromey.com>
1753
1754         * mips-tdep.c (mips_pdr_data): Remove.
1755         (_initialize_mips_tdep): Update.
1756
1757 2019-05-08  Tom Tromey  <tom@tromey.com>
1758
1759         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1760         (hppa_init_objfile_priv_data, read_unwind_info)
1761         (find_unwind_entry, _initialize_hppa_tdep): Update.
1762
1763 2019-05-08  Tom Tromey  <tom@tromey.com>
1764
1765         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1766         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1767         on obstack.
1768         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1769
1770 2019-05-08  Tom Tromey  <tom@tromey.com>
1771
1772         * mdebugread.c (basic_type_data): Change type.
1773         (basic_type, _initialize_mdebugread): Update.
1774
1775 2019-05-08  Tom Tromey  <tom@tromey.com>
1776
1777         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1778
1779 2019-05-08  Tom Tromey  <tom@tromey.com>
1780
1781         * nto-tdep.c (nto_inferior_data_reg): Change type.
1782         (nto_inferior_data): Update.
1783         (nto_inferior_data_cleanup, nto_new_inferior_data)
1784         (_initialize_nto_tdep): Remove.
1785         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1786
1787 2019-05-08  Tom Tromey  <tom@tromey.com>
1788
1789         * ada-lang.c (struct ada_inferior_data): Add initializers.
1790         (ada_inferior_data): Change type.
1791         (ada_inferior_data_cleanup): Remove.
1792         (get_ada_inferior_data, ada_inferior_exit)
1793         (struct ada_pspace_data): Add initializers, destructor.
1794         (ada_pspace_data_handle): Change type.
1795         (get_ada_pspace_data): Update.
1796         (ada_pspace_data_cleanup): Remove.
1797
1798 2019-05-08  Tom Tromey  <tom@tromey.com>
1799
1800         * coffread.c (struct coff_symfile_info): Add initializers.
1801         (coff_objfile_data_key): Move lower.  Change type.
1802         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1803         Update.
1804         (coff_free_info): Remove.
1805
1806 2019-05-08  Tom Tromey  <tom@tromey.com>
1807
1808         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1809         (fbsd_pspace_data_handle): Move lower.  Change type.
1810         (get_fbsd_pspace_data): Update.
1811         (fbsd_pspace_data_cleanup): Remove.
1812         (_initialize_fbsd_tdep): Update.
1813
1814 2019-05-08  Tom Tromey  <tom@tromey.com>
1815
1816         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1817         (get_ada_tasks_pspace_data): Update.
1818         (ada_tasks_pspace_data_cleanup): Remove.
1819         (_initialize_tasks): Update.
1820         (ada_tasks_inferior_data_handle): Change type.
1821         (get_ada_tasks_inferior_data): Update.
1822         (ada_tasks_inferior_data_cleanup): Remove.
1823         (struct ada_tasks_pspace_data): Add initializers.
1824
1825 2019-05-08  Tom Tromey  <tom@tromey.com>
1826
1827         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1828         * symfile-debug.c (debug_sym_get_probes): Change type.
1829         * stap-probe.c (handle_stap_probe):
1830         (stap_static_probe_ops::get_probes): Change type.
1831         * probe.h (class static_probe_ops) <get_probes>: Change type.
1832         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1833         (parse_probes_in_pspace): Update.
1834         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1835         Update.
1836         (any_static_probe_ops::get_probes): Change type.
1837         * elfread.c (elfread_data): New typedef.
1838         (probe_key): Change type.
1839         (elf_get_probes): Likewise.  Update.
1840         (probe_key_free): Remove.
1841         (_initialize_elfread): Update.
1842         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1843         Change type.
1844         (dtrace_process_dof_probe, dtrace_process_dof)
1845         (dtrace_static_probe_ops::get_probe): Change type.
1846
1847 2019-05-08  Tom Tromey  <tom@tromey.com>
1848
1849         * xcoffread.c (struct xcoff_symfile_info): Rename from
1850         coff_symfile_info.  Add initializers.
1851         (xcoff_objfile_data_key): Move lower.  Change type.
1852         (XCOFF_DATA): Rewrite.
1853         (xcoff_free_info): Remove.
1854         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1855         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1856         (xcoff_initial_scan): Update.
1857
1858 2019-05-08  Tom Tromey  <tom@tromey.com>
1859
1860         * solib-svr4.c (struct svr4_info): Add initializers and
1861         destructor.
1862         <probes_table>: Now an htab_up.
1863         (solib_svr4_pspace_data): Change type.
1864         (free_probes_table): Simplify.
1865         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1866         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1867         (probes_table_remove_objfile_probes, register_solib_event_probe)
1868         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1869         (_initialize_svr4_solib): Update.
1870
1871 2019-05-08  Tom Tromey  <tom@tromey.com>
1872
1873         * remote.c (remote_pspace_data): Change type.
1874         (remote_pspace_data_cleanup): Remove.
1875         (get_remote_exec_file, set_pspace_remote_exec_file)
1876         (_initialize_remote): Update.
1877
1878 2019-05-08  Tom Tromey  <tom@tromey.com>
1879
1880         * breakpoint.c (breakpoint_objfile_key): Change type.
1881         (get_breakpoint_objfile_data): Update.
1882         (free_breakpoint_objfile_data): Remove.
1883         (_initialize_breakpoint): Update.
1884
1885 2019-05-08  Tom Tromey  <tom@tromey.com>
1886
1887         * linux-tdep.c (struct linux_info): Add initializers.
1888         (linux_inferior_data): Move.  Change type.
1889         (invalidate_linux_cache_inf): Update.
1890         (linux_inferior_data_cleanup): Remove.
1891         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1892
1893 2019-05-08  Tom Tromey  <tom@tromey.com>
1894
1895         * auxv.c (auxv_inferior_data): Move.  Change type.
1896         (auxv_inferior_data_cleanup): Remove.
1897         (invalidate_auxv_cache_inf): Rewrite.
1898         (get_auxv_inferior_data, _initialize_auxv): Update.
1899
1900 2019-05-08  Tom Tromey  <tom@tromey.com>
1901
1902         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1903         (symfile_debug_objfile_data_key): Change type.
1904         (symfile_debug_installed, debug_qf_has_symbols)
1905         (debug_qf_find_last_source_symtab)
1906         (debug_qf_forget_cached_source_info)
1907         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1908         (debug_qf_print_stats, debug_qf_dump)
1909         (debug_qf_expand_symtabs_for_function)
1910         (debug_qf_expand_all_symtabs)
1911         (debug_qf_expand_symtabs_with_fullname)
1912         (debug_qf_map_matching_symbols)
1913         (debug_qf_expand_symtabs_matching)
1914         (debug_qf_find_pc_sect_compunit_symtab)
1915         (debug_qf_map_symbol_filenames)
1916         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1917         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1918         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1919         (debug_sym_read_linetable, debug_sym_relocate): Update.
1920         (symfile_debug_free_objfile): Remove.
1921         (install_symfile_debug_logging, _initialize_symfile_debug):
1922         Update.
1923
1924 2019-05-08  Tom Tromey  <tom@tromey.com>
1925
1926         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1927         allocate_on_obstack.
1928         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1929         (get_dwarf2_per_objfile): Update.
1930         (set_dwarf2_per_objfile): Remove.
1931         (dwarf2_has_info, dwarf2_get_section_info): Update.
1932         (dwarf2_free_objfile): Remove.
1933         (_initialize_dwarf2_read): Update.
1934
1935 2019-05-08  Tom Tromey  <tom@tromey.com>
1936
1937         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1938         initializers.
1939         <unsupported_script_warning_printed,
1940         script_not_found_warning_printed>: Now bool.
1941         (auto_load_pspace_data): Change type.
1942         (~auto_load_pspace_info): Rename from
1943         auto_load_pspace_data_cleanup.
1944         (get_auto_load_pspace_data, init_loaded_scripts_info)
1945         (clear_section_scripts, maybe_print_unsupported_script_warning)
1946         (maybe_print_script_not_found_warning, _initialize_auto_load):
1947         Update.
1948
1949 2019-05-08  Tom Tromey  <tom@tromey.com>
1950
1951         * objfiles.c (objfile_pspace_info): Add destructor and
1952         initializers.
1953         (objfiles_pspace_data): Change type.
1954         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1955         (get_objfile_pspace_data): Update.
1956         (objfiles_bfd_data): Change type.
1957         (get_objfile_bfd_data): Update.
1958         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1959
1960 2019-05-08  Tom Tromey  <tom@tromey.com>
1961
1962         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1963         Change type.
1964         (get_catch_syscall_inferior_data): Update.
1965         (catch_syscall_inferior_data_cleanup): Remove.
1966         (_initialize_break_catch_syscall): Update.
1967
1968 2019-05-08  Tom Tromey  <tom@tromey.com>
1969
1970         * inflow.c (struct terminal_info): Add destructor and
1971         initializers.
1972         (inflow_inferior_data): Change type.
1973         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1974         (get_inflow_inferior_data, inflow_inferior_exit)
1975         (swap_terminal_info, _initialize_inflow): Update.
1976
1977 2019-05-08  Tom Tromey  <tom@tromey.com>
1978
1979         * target-dcache.c (target_dcache_cleanup): Remove.
1980         (target_dcache_aspace_key): Change type.
1981         (target_dcache_init_p, target_dcache_invalidate)
1982         (target_dcache_get, target_dcache_get_or_init)
1983         (_initialize_target_dcache): Update.
1984         * dcache.h (struct dcache_deleter): New.
1985
1986 2019-05-08  Tom Tromey  <tom@tromey.com>
1987
1988         * symtab.c (struct symbol_cache): Add destructor and
1989         initializers.
1990         (symbol_cache_key): Move.  Change type.
1991         (make_symbol_cache, free_symbol_cache): Remove.
1992         (get_symbol_cache): Update.
1993         (symbol_cache_cleanup): Remove.
1994         (ALL_PSPACES, symbol_cache_flush)
1995         (maintenance_print_symbol_cache)
1996         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1997         Update.
1998
1999 2019-05-08  Tom Tromey  <tom@tromey.com>
2000
2001         * symtab.c (struct main_info): Add destructor and initializers.
2002         (main_progspace_key): Move.  Change type.
2003         (get_main_info): Update.
2004         (main_info_cleanup): Remove.
2005         (_initialize_symtab): Update.
2006
2007 2019-05-08  Tom Tromey  <tom@tromey.com>
2008
2009         * registry.h (DECLARE_REGISTRY): Define the _key class.
2010
2011 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2012
2013         * NEWS: Merge two 'New commands' sections.
2014
2015 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2016
2017         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2018         parameter and use Ada language definition instead.
2019         (ada_val_print_ptr): Remove unused language parameter.
2020         (ada_val_print_num): Remove language parameter and use Ada language
2021         definition instead.
2022         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2023         parameter.
2024         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2025         parameter and use Ada language definition instead.
2026         (ada_val_print_1): Update all ada_val_print_xxx calls.
2027         Remove language parameter.
2028         (ada_val_print): Update ada_val_print_1 call.
2029
2030 2019-05-08  Tom Tromey  <tromey@adacore.com>
2031
2032         * remote.c (remote_hw_watchpoint_limit)
2033         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2034         Now static.
2035
2036 2019-05-08  Tom Tromey  <tromey@adacore.com>
2037
2038         * maint.c (_initialize_maint_cmds): Move initialization code to
2039         remote.c.
2040         (watchdog, show_watchdog): Move to remote.c.
2041         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2042         "watchdog" static.
2043         (_initialize_remote): Move initialization code from maint.c.
2044         * defs.h (watchdog): Don't declare.
2045
2046 2019-05-08  Tom Tromey  <tromey@adacore.com>
2047
2048         * tui/tui-interp.c: Include main.h.
2049         * interps.c: Include main.h.
2050         * main.h (interpreter_p): Declare.
2051         * defs.h (interpreter_p): Don't declare.
2052
2053 2019-05-08  Tom Tromey  <tromey@adacore.com>
2054
2055         * dwarf2loc.c: Include dwarf2read.h.
2056         * defs.h (read_unsigned_leb128): Don't declare.
2057         * dwarf2read.h (read_unsigned_leb128): Declare.
2058
2059 2019-05-08  Tom Tromey  <tromey@adacore.com>
2060
2061         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2062         method.
2063
2064 2019-05-08  Tom Tromey  <tromey@adacore.com>
2065
2066         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2067         when no wrap column is set.
2068
2069 2019-05-08  Tom Tromey  <tromey@adacore.com>
2070
2071         * c-lang.c (c_get_string): Handle non-C-style arrays.
2072
2073 2019-05-08  Tom Tromey  <tromey@adacore.com>
2074
2075         * typeprint.c (print_offset_data::update): Print the bit offset,
2076         not the number of bits remaining.
2077
2078 2019-05-08  Tom Tromey  <tromey@adacore.com>
2079
2080         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2081         padding at end of comment.
2082
2083 2019-05-08  Tom Tromey  <tromey@adacore.com>
2084
2085         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2086         Compare main types.
2087
2088 2019-05-06  Tom Tromey  <tom@tromey.com>
2089
2090         * common/scoped_mmap.c: Include common-defs.h.
2091         * common/scoped_mmap.h: Don't include config.h.
2092
2093 2019-05-04  Tom Tromey  <tom@tromey.com>
2094
2095         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2096         (struct aarch64_call_info): Add initializers.
2097         <si>: Now a std::vector.
2098         (pass_on_stack, aarch64_push_dummy_call): Update.
2099
2100 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2101             Tom Tromey  <tom@tromey.com>
2102
2103         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2104         (ppc_threads): Now a std::vector.  Now static.
2105         (hwdebug_find_thread_points_by_tid)
2106         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2107         Update.
2108
2109 2019-05-04  Tom Tromey  <tom@tromey.com>
2110
2111         * arc-tdep.c (arc_tdesc_init): Return bool.
2112
2113 2019-05-04  Tom Tromey  <tom@tromey.com>
2114
2115         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2116         Use gdb_assert_not_reached.
2117
2118 2019-05-04  Tom Tromey  <tom@tromey.com>
2119
2120         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2121         "false".
2122
2123 2019-05-04  Tom Tromey  <tom@tromey.com>
2124
2125         * arc-tdep.c (arc_tdesc_init): Use bool.
2126
2127 2019-05-04  Tom Tromey  <tom@tromey.com>
2128
2129         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2130
2131 2019-05-04  Tom Tromey  <tom@tromey.com>
2132
2133         * cli/cli-cmds.c (valid_command_p): Return bool.
2134
2135 2019-05-04  Tom Tromey  <tom@tromey.com>
2136
2137         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2138         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2139
2140 2019-05-04  Raul Tambre  <raul@tambre.ee>
2141
2142         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2143         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2144         operator for comparison.
2145
2146 2019-05-04  Tom Tromey  <tom@tromey.com>
2147
2148         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2149         (lookup_partial_symbol, print_partial_symbols)
2150         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2151         (psymbol_compare): Update.
2152         (add_psymbol_to_bcache): Clear the entire psymbol.
2153         (maintenance_check_psymtabs): Update.
2154         * psympriv.h (struct partial_symbol): Don't derive from
2155         general_symbol_info.
2156         <obj_section, unrelocated_address, address,
2157         set_unrelocated_address>: Update.
2158         <ginfo>: New member.
2159         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2160         (debug_names::write_psymbols): Update.
2161
2162 2019-05-04  Tom de Vries  <tdevries@suse.de>
2163
2164         * contrib/cc-with-tweaks.sh: Support -n arg.
2165
2166 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2167
2168         * corelow.c (core_target::detach): Ensure frame cache and
2169         register caches are cleared.
2170         inferior.c (exit_inferior_1): Likewise.
2171
2172 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2173             Tom Tromey  <tom@tromey.com>
2174
2175         * dictionary.c (collate_pending_symbols_by_language): Remove
2176         "struct" from foreach.
2177         * symtab.c (lookup_global_symbol_from_objfile)
2178         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2179         foreach.
2180         * ser-tcp.c (net_open): Remove "struct" from foreach.
2181         * objfiles.c (objfile_relocate, objfile_rebase)
2182         (objfile_has_symbols): Remove "struct" from foreach.
2183         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2184         from foreach.
2185         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2186         foreach.
2187         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2188         "struct" from foreach.
2189         * ada-lang.c (create_excep_cond_exprs)
2190         (ada_exception_catchpoint_cond_string): Remove "struct" from
2191         foreach.
2192
2193 2019-05-03  Tom Tromey  <tromey@adacore.com>
2194
2195         * ada-exp.y (convert_char_literal): Check suffix of each
2196         enumerator.
2197
2198 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2199
2200         PR ada/21406:
2201         * ada-exp.y (yywrap): Don't define.
2202         * ada-lex.l (%option): Add noyywrap
2203         (yywrap): Remove.
2204
2205 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2206
2207         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2208         _WIN32_WINNT to the XP level, unless already defined to a higher
2209         level.
2210
2211         * unittests/parse-connection-spec-selftests.c:
2212         * ser-tcp.c:
2213         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2214         override.
2215
2216         * symfile.c (find_separate_debug_file): Remove colon from the
2217         drive spec of DOS/Windows file names of the target, so that the
2218         file name produced from DEBUGDIR and the target's directory will
2219         be valid on DOS/Windows systems.
2220
2221 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2222
2223         * rust-lang.c (val_print_struct): Handle printing structures
2224         containing strings.
2225
2226 2019-05-02  Tom Tromey  <tromey@adacore.com>
2227
2228         * valarith.c (_initialize_valarith): Remove.
2229
2230 2019-05-01  Tom Tromey  <tromey@adacore.com>
2231
2232         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2233         bitfields.
2234
2235 2019-05-01  Tom Tromey  <tromey@adacore.com>
2236
2237         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2238         for big-endian copies.
2239
2240 2019-04-30  Ali Tamur  <tamur@google.com>
2241         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2242         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2243         (read_3_bytes): New function.
2244
2245 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2246
2247         * windows-nat.c (main_thread_id): Delete.
2248         (handle_output_debug_string): Replace main_thread_id by
2249         current_event.dwThreadId.
2250         (fake_create_process): Likewise.
2251         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2252         Do not set main_thread_id.
2253         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2254         current_event.dwThreadId.
2255         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2256
2257 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2258
2259         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2260         Use current_event.dwThreadId instead of main_thread_id.
2261
2262 2019-04-30  Tom Tromey  <tromey@adacore.com>
2263
2264         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2265         (create_excep_cond_exprs): Iterate over program spaces.
2266         (ada_exception_catchpoint_cond_string): Examine all minimal
2267         symbols for exception types.
2268
2269 2019-04-30  Tom Tromey  <tromey@adacore.com>
2270
2271         PR c++/24470:
2272         * dwarf2read.c (process_structure_scope): Handle case where type
2273         has template parameters but no symbol was created.
2274
2275 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2276             Chris January  <chris.january@arm.com>
2277
2278         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2279         qualifier.
2280         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2281
2282 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * f-typeprint.c (f_print_type): Update rules for printing
2285         whitespace.
2286         (f_type_print_varspec_suffix): Likewise.
2287
2288 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2289             Chris January  <chris.january@arm.com>
2290
2291         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2292         function arguments.
2293
2294 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2295
2296         * f-lang.c (build_fortran_types): Change name of void type to
2297         lower case.
2298         * f-typeprint.c (f_type_print_base): Print the name of the void
2299         type, rather than a fixed string.
2300         * f-valprint.c (f_decorations): Use lower case void string.
2301
2302 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2303             Chris January  <chris.january@arm.com>
2304
2305         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2306         types for Fortran.
2307
2308 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2309             Chris January  <chris.january@arm.com>
2310             David Lecomber  <david.lecomber@arm.com>
2311
2312         * f-exp.y (BINOP_INTRINSIC): New token.
2313         (exp): New parser rule handling BINOP_INTRINSIC.
2314         (f77_keywords): Add new builtin procedures.
2315         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2316         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2317         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2318         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2319         (print_unop_subexp_f): New function.
2320         (print_binop_subexp_f): New function.
2321         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2322         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2323         (dump_subexp_body_f): Likewise.
2324         (operator_check_f): Likewise.
2325         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2326         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2327
2328 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2329
2330         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2331         UNOP_KIND.
2332         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2333         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2334         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2335         (operator_length_f): New fuction.
2336         (print_subexp_f): New function.
2337         (op_name_f): New function.
2338         (dump_subexp_body_f): New function.
2339         (operator_check_f): New function.
2340         (exp_descriptor_f): Replace standard expression handling functions
2341         with new functions.
2342         * gdb/fortran-operator.def: New file.
2343         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2344         * gdb/std-operator.def: Remove UNOP_KIND.
2345
2346 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2347
2348         * std-operator.def: Remove unbalanced, stray double quote
2349         character.
2350
2351 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2352             Chris January  <chris.january@arm.com>
2353             Daniel Everett  <daniel.everett@arm.com>
2354             Nick Forrington  <nick.forrington@arm.com>
2355             Richard Bunt  <richard.bunt@arm.com>
2356
2357         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2358         of depth when printing anonymous structs or unions.
2359         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2360         Don't print either the top-level value, or the children if the
2361         max-depth is exceeded.
2362         (ppscm_print_children): When printing the key of a map, allow one
2363         extra level of depth.
2364         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2365         print either the top-level value, or the children if the max-depth
2366         is exceeded.
2367         (print_children): When printing the key of a map, allow one extra
2368         level of depth.
2369         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2370         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2371         (user_print_options): Initialise max_depth field.
2372         (val_print_scalar_or_string_type_p): New function.
2373         (val_print): Check to see if the max depth has been reached.
2374         (val_print_check_max_depth): Define new function.
2375         (show_print_max_depth): New function.
2376         (_initialize_valprint): Add 'print max-depth' option.
2377         * valprint.h (struct value_print_options) <max_depth>: New field.
2378         (val_print_check_max_depth): Declare new function.
2379         * NEWS: Document new feature.
2380
2381 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2382
2383         * ada-lang.c (ada_language_defn): Initialise new field.
2384         * c-lang.c (c_is_string_type_p): New function.
2385         (c_language_defn): Initialise new field.
2386         (cplus_language_defn): Initialise new field.
2387         (asm_language_defn): Initialise new field.
2388         (minimal_language_defn): Initialise new field.
2389         * c-lang.h (c_is_string_type_p): Declare new function.
2390         * d-lang.c (d_language_defn): Initialise new field.
2391         * f-lang.c (f_is_string_type_p): New function.
2392         (f_language_defn): Initialise new field.
2393         * go-lang.c (go_is_string_type_p): New function.
2394         (go_language_defn): Initialise new field.
2395         * language.c (default_is_string_type_p): New function.
2396         (unknown_language_defn): Initialise new field.
2397         (auto_language_defn): Initialise new field.
2398         * language.h (struct language_defn) <la_is_string_type_p>: New
2399         member variable.
2400         (default_is_string_type_p): Declare new function.
2401         * m2-lang.c (m2_language_defn): Initialise new field.
2402         * objc-lang.c (objc_language_defn): Initialise new field.
2403         * opencl-lang.c (opencl_language_defn): Initialise new field.
2404         * p-lang.c (pascal_is_string_type_p): New function.
2405         (pascal_language_defn): Initialise new field.
2406         * rust-lang.c (rust_is_string_type_p): New function.
2407         (rust_language_defn): Initialise new field.
2408
2409 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2410
2411         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2412         New field.
2413         * ada-lang.c (ada_language_defn): Initialise new field.
2414         * c-lang.c (c_language_defn): Likewise.
2415         (cplus_language_defn): Likewise.
2416         (asm_language_defn): Likewise.
2417         (minimal_language_defn): Likewise.
2418         * d-lang.c (d_language_defn): Likewise.
2419         * f-lang.c (f_language_defn): Likewise.
2420         * go-lang.c (go_language_defn): Likewise.
2421         * language.c (unknown_language_defn): Likewise.
2422         (auto_language_defn): Likewise.
2423         * m2-lang.c (m2_language_defn): Likewise.
2424         * objc-lang.c (objc_language_defn): Likewise.
2425         * opencl-lang.c (opencl_language_defn): Likewise.
2426         * p-lang.c (pascal_language_defn): Likewise.
2427         * rust-lang.c (rust_language_defn): Likewise.
2428
2429 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2430
2431         * ada-lang.c (ada_is_character_type): Change return type to bool.
2432         (ada_is_string_type): Likewise.
2433         * ada-lang.h (ada_is_character_type): Update declaration
2434         (ada_is_string_type): Likewise.
2435
2436 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2437
2438         Support style in 'frame|thread apply'
2439
2440         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2441         * record.c (record_start, record_stop): Update callers of
2442         execute_command_to_string with false.
2443         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2444         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2445         methods.
2446         (class string_file): New constructor with term_out parameter.
2447         Override methods term_out and can_emit_style_escape.  New member
2448         term_out.
2449         (class stdio_file): Override can_emit_style_escape.
2450         (class tee_file): Override term_out and can_emit_style_escape.
2451         * utils.h (can_emit_style_escape): Remove.
2452         * utils.c (can_emit_style_escape): Likewise.
2453         Update all callers of can_emit_style_escape (SOMESTREAM) to
2454         SOMESTREAM->can_emit_style_escape.
2455         * source-cache.c (source_cache::get_source_lines): Likewise.
2456         * stack.c (frame_apply_command_count): Call execute_command_to_string
2457         passing the term_out characteristic of the current gdb_stdout.
2458         * thread.c (thr_try_catch_cmd): Likewise.
2459         * top.c (execute_command_to_string): pass term_out parameter
2460         to construct the string_file for the command output.
2461         * ui-file.c (term_cli_styling): New function (most code moved
2462         from utils.c can_emit_style_escape).
2463         (string_file::string_file, string_file::can_emit_style_escape,
2464         stdio_file::can_emit_style_escape, tee_file::term_out,
2465         tee_file::can_emit_style_escape): New functions.
2466
2467 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2468
2469         * NEWS: Mention the new set|show may-call-functions.
2470         * infcall.c (may_call_functions_p): New variable.
2471         (show_may_call_functions_p): New function.
2472         (call_function_by_hand_dummy): Throws an error if not
2473         may-call-functions.
2474         (_initialize_infcall): Call add_setshow_boolean_cmd for
2475         may-call-functions.
2476
2477 2019-04-25  Keith Seitz  <keiths@redhat.com>
2478
2479         PR c++/24367
2480         * cp-support.c (inspect_type): Don't attempt substitutions
2481         of symbol with the same name.
2482
2483 2019-04-25  Tom Tromey  <tromey@adacore.com>
2484
2485         PR gdb/24475:
2486         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2487         static.
2488
2489 2019-04-25  Tom Tromey  <tromey@adacore.com>
2490
2491         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2492         rvalue reference.
2493         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2494         (gdb_xml_parser::parse): Use std::move.
2495         * python/python-internal.h (gdbpy_convert_exception): Take a const
2496         reference.
2497         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2498         std::move.
2499         * python/py-utils.c (gdbpy_convert_exception): Take a const
2500         reference.
2501         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2502         Use std::move.
2503         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2504         Use std::move.
2505         * mi/mi-main.c (mi_print_exception): Take a const reference.
2506         * main.c (handle_command_errors): Take a const reference.
2507         * linespec.c (parse_linespec): Use std::move.
2508         * infcall.c (run_inferior_call): Use std::move.
2509         (call_function_by_hand_dummy): Use std::move.
2510         * exec.c (try_open_exec_file): Use std::move.
2511         * exceptions.h (exception_print, exception_fprintf)
2512         (exception_print_same): Update.
2513         * exceptions.c (print_exception, exception_print)
2514         (exception_fprintf, exception_print_same): Change parameters to
2515         const reference.
2516         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2517         * common/new-op.c: Use std::move.
2518         * common/common-exceptions.h (struct gdb_exception): Add move
2519         constructor.
2520         (struct gdb_exception_error, struct gdb_exception_quit, struct
2521         gdb_quit_bad_alloc): Change constructor to move constructor.
2522         (throw_exception): Change parameter to rvalue reference.
2523         * common/common-exceptions.c (throw_exception): Take rvalue
2524         reference.
2525         * cli/cli-interp.c (safe_execute_command): Use std::move.
2526         * breakpoint.c (insert_bp_location, location_to_sals): Use
2527         std::move.
2528
2529 2019-04-25  Tom Tromey  <tromey@adacore.com>
2530
2531         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2532         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2533         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2534         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2535         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2536         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2537         guile/scm-value.c: Use unpack.
2538         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2539         gdbscm_gdb_exception.
2540         (gdbscm_throw_gdb_exception): Likewise.
2541         (struct gdbscm_gdb_exception): New.
2542         (unpack): New function.
2543         (gdbscm_wrap): Use unpack.
2544
2545 2019-04-25  Tom Tromey  <tromey@adacore.com>
2546
2547         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2548         (gdb_rl_callback_handler): Use std::move.
2549         * common/common-exceptions.h (struct gdb_exception): Add move
2550         assignment operator.
2551         (throw_exception_sjlj): Change "exception" to const reference.
2552         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2553         (throw_exception_sjlj): Change "exception" to const reference.
2554
2555 2019-04-25  Tom Tromey  <tromey@adacore.com>
2556
2557         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2558         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2559         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2560         Update.
2561         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2562         Update.
2563         * mi/mi-interp.c (mi_interp::exec): Update.
2564         * linespec.c (parse_linespec): Update.
2565         * infcall.c (run_inferior_call): Update.
2566         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2567         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2568         (gdbscm_lookup_global_symbol): Update.
2569         * guile/scm-param.c (gdbscm_parameter_value): Update.
2570         * guile/scm-frame.c (gdbscm_frame_read_register)
2571         (gdbscm_frame_read_var): Update.
2572         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2573         * exec.c (try_open_exec_file): Update.
2574         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2575         (gdb_rl_callback_handler): Update.
2576         * common/common-exceptions.h (exception_none): Don't declare.
2577         * common/common-exceptions.c (exception_none): Don't define.
2578         (struct catcher) <exception>: Update.
2579         * cli/cli-interp.c (safe_execute_command): Update.
2580         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2581
2582 2019-04-25  Ali Tamur  <tamur@google.com>
2583
2584         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2585         (read_attribute_value): Likewise.
2586         (dwarf2_read_addr_index): Update comment.
2587         (read_str_index): Add DW_FORM_strx.
2588         (dwarf2_string_attr): Likewise.
2589         (dwarf2_const_value_attr): Likewise.
2590         (dump_die_shallow): Likewise.
2591         (dwarf2_fetch_constant_bytes): Likewise.
2592         (skip_form_bytes): Likewise.
2593         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2594
2595 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2596
2597         PR corefiles/11608
2598         PR corefiles/18187
2599         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2600         OFFSET.  Verify if current mapping contains an ELF header.
2601         (linux_find_memory_regions_full): Adjust call to
2602         dump_mapping_p.
2603
2604 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2605             Kang Li <kanglictf@gmail.com>
2606
2607         PR gdb/21600
2608
2609         * dwarf2-frame.c (read_initial_length): Be consistent about using
2610         unsigned representation of length.
2611         (decode_frame_entry_1): Likewise.  Check for wraparound of
2612         end pointer as well as buffer overflow.
2613
2614 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2615
2616         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2617         "vq".
2618
2619 2019-04-24  Tom Tromey  <tromey@adacore.com>
2620
2621         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2622
2623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2624
2625         * s12z-tdep.c (s12z_unwind_pc): Delete.
2626         (s12z_unwind_sp): Delete.
2627         (s12z_gdbarch_init): Don't register deleted functions with
2628         gdbarch.
2629
2630 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2631
2632         * rl78-tdep.c (rl78_unwind_sp): Delete.
2633         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2634
2635 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2636
2637         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2638         (xstormy16_unwind_pc): Delete.
2639         (xstormy16_dummy_id): Delete.
2640         (xstormy16_gdbarch_init): Don't register deleted functions with
2641         gdbarch.
2642
2643 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2644
2645         * vax-tdep.c (vax_unwind_pc): Delete.
2646         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2647
2648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2649
2650         * v850-tdep.c (v850_unwind_sp): Delete.
2651         (v850_unwind_pc): Delete.
2652         (v850_dummy_id): Delete.
2653         (v850_gdbarch_init): Don't register deleted functions with
2654         gdbarch.
2655
2656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2657
2658         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2659         (tilegx_unwind_pc): Delete.
2660         (tilegx_unwind_dummy_id): Delete.
2661         (tilegx_gdbarch_init): Don't register deleted functions with
2662         gdbarch.
2663
2664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2665
2666         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2667         (tic6x_dummy_id): Delete.
2668         (tic6x_gdbarch_init): Don't register deleted functions with
2669         gdbarch.
2670
2671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2672
2673         * sparc-tdep.c (sparc_unwind_pc): Delete.
2674         (sparc32_gdbarch_init): Don't register deleted function with
2675         gdbarch.
2676
2677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2678
2679         * sh-tdep.c (sh_unwind_sp): Delete.
2680         (sh_unwind_pc): Delete.
2681         (sh_dummy_id): Delete.
2682         (sh_gdbarch_init): Don't register deleted functions with
2683         gdbarch.
2684
2685 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2686
2687         * score-tdep.c (score_unwind_sp): Delete.
2688         (score_unwind_pc): Delete.
2689         (score_dummy_id): Delete.
2690         (score_gdbarch_init): Don't register deleted functions with
2691         gdbarch.
2692
2693 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2694
2695         * rx-tdep.c (rx_unwind_pc): Delete.
2696         (rx_unwind_sp): Delete.
2697         (rx_dummy_id): Delete.
2698         (rx_gdbarch_init): Don't register deleted functions with
2699         gdbarch.  Update comment.
2700
2701 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2702
2703         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2704         (rs6000_dummy_id): Delete.
2705         (rs6000_gdbarch_init): Don't register deleted functions with
2706         gdbarch.
2707
2708 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2709
2710         * or1k-tdep.c (or1k_dummy_id): Delete.
2711         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2712
2713 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2714
2715         * nios2-tdep.c (nios2_dummy_id): Delete.
2716         (nios2_unwind_sp): Delete.
2717         (nios2_gdbarch_init): Don't register deleted functions with
2718         gdbarch.
2719
2720 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2721
2722         * nds32-tdep.c (nds32_dummy_id): Delete.
2723         (nds32_unwind_pc): Delete.
2724         (nds32_unwind_sp): Delete.
2725         (nds32_gdbarch_init): Don't register deleted functions with
2726         gdbarch.
2727
2728 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2729
2730         * msp430-tdep.c (msp430_unwind_pc): Delete.
2731         (msp430_unwind_sp): Delete.
2732         (msp430_dummy_id): Delete.
2733         (msp430_gdbarch_init): Don't register deleted functions with
2734         gdbarch.
2735
2736 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2737
2738         * moxie-tdep.c (moxie_unwind_sp): Delete.
2739         (moxie_unwind_pc): Delete.
2740         (moxie_dummy_id): Delete.
2741         (moxie_gdbarch_init): Don't register deleted functions with
2742         gdbarch.
2743
2744 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2745
2746         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2747         (mn10300_unwind_pc): Delete.
2748         (mn10300_unwind_sp): Delete.
2749         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2750         mn10300_unwind_sp.
2751         (mn10300_frame_unwind_init): Don't register deleted functions with
2752         gdbarch.
2753
2754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2755
2756         * mep-tdep.c (mep_unwind_pc): Delete.
2757         (mep_unwind_sp): Delete.
2758         (mep_dummy_id): Delete.
2759         (mep_gdbarch_init): Don't register deleted functions with
2760         gdbarch.
2761
2762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2763
2764         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2765         (m68hc11_unwind_sp): Delete.
2766         (m68hc11_gdbarch_init): Don't register deleted functions with
2767         gdbarch.
2768
2769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2770
2771         * m32r-tdep.c (m32r_unwind_sp): Delete.
2772         (m32r_unwind_pc): Delete.
2773         (m32r_dummy_id): Delete.
2774         (m32r_gdbarch_init): Don't register deleted functions with
2775         gdbarch.
2776
2777 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2778
2779         * m32c-tdep.c (m32c_unwind_pc): Delete.
2780         (m32c_unwind_sp): Delete.
2781         (m32c_dummy_id): Delete.
2782         (m32c_gdbarch_init): Don't register deleted functions with
2783         gdbarch.
2784
2785 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2786
2787         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2788         (lm32_unwind_pc): Delete.
2789         (lm32_dummy_id): Delete.
2790         (lm32_gdbarch_init): Don't register deleted functions with
2791         gdbarch.
2792
2793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2794
2795         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2796         (iq2000_unwind_pc): Delete.
2797         (iq2000_dummy_id): Delete.
2798         (iq2000_gdbarch_init): Don't register deleted functions with
2799         gdbarch.
2800
2801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2802
2803         * nds32-tdep.c (nds32_type_align): Delete.
2804         (nds32_push_dummy_call): Use type_align instead.
2805
2806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2807
2808         * arm-tdep.c (arm_type_align): Only handle vector override case.
2809         (arm_push_dummy_call): Use type_align.
2810         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2811
2812 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2813
2814         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2815         case.
2816         (pass_on_stack): Use type_align.
2817         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2818         function.
2819
2820 2019-04-23  Tom Tromey  <tromey@adacore.com>
2821
2822         * dwarf2read.c (line_header::file_name_at): Remove unused
2823         overload.
2824
2825 2019-04-23  Tom de Vries  <tdevries@suse.de>
2826
2827         PR gdb/24438
2828         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2829         invocation.
2830
2831
2832 2019-03-27  Ali Tamur  <tamur@google.com>
2833
2834         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2835         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2836         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2837         (dwarf_expr_context::get_addr_index): Likewise
2838         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2839         (symbol_needs_eval_context::get_addr_index): Likewise
2840         (disassemble_dwarf_expression): Add DW_OP_addrx
2841         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2842         (read_cutu_die_from_dwo): Update comment
2843         (skip_one_die): Add DW_FORM_addrx
2844         (read_attribute_value): Likewise
2845         (var_decode_location): Add DW_OP_addrx
2846         (dwarf2_const_value_attr): Add DW_FORM_addrx
2847         (dump_die_shallow): Likewise
2848         (dwarf2_fetch_constant_bytes): Likewise
2849         (decode_locdesc): Add DW_OP_addrx
2850         (skip_form_bytes): Add DW_FORM_addrx
2851
2852 2019-04-22  Ali Tamur  <tamur@google.com>
2853
2854         * MAINTAINERS (Write After Approval): Add self.
2855
2856 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2857
2858         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2859         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2860         (open_symbol_file_object): Likewise.
2861         (svr4_default_sos): Add info parameter.
2862         (svr4_read_so_list): Likewise.
2863         (svr4_current_sos_direct): Adjust functions calls to pass down
2864         info.
2865         (svr4_current_sos_1): Add info parameter.
2866         (svr4_current_sos): Call get_svr4_info, pass info down to
2867         svr4_current_sos_1.
2868         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2869         get_svr4_info.
2870         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2871         get_svr4_info.
2872         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2873         to get_svr4_info.
2874         (probes_table_remove_objfile_probes): Likewise.
2875         (register_solib_event_probe): Add info parameter.
2876         (solist_update_incremental): Pass info parameter down to
2877         svr4_read_so_list.
2878         (disable_probes_interface): Add info parameter.
2879         (svr4_handle_solib_event): Pass current_program_space to
2880         get_svr4_info.  Adjust disable_probes_interface cleanup.
2881         (svr4_create_probe_breakpoints): Add info parameter, pass it
2882         down to register_solib_event_probe.
2883         (svr4_create_solib_event_breakpoints): Add info parameter,
2884         pass it down to svr4_create_probe_breakpoints.
2885         (enable_break): Pass info down to
2886         svr4_create_solib_event_breakpoints.
2887         (svr4_solib_create_inferior_hook): Pass current_program_space to
2888         get_svr4_info.
2889         (svr4_clear_solib): Likewise.
2890
2891 2019-04-22  Pedro Alves  <palves@redhat.com>
2892
2893         * solib-svr4.c (svr4_free_objfile_observer): New.
2894         (probe_and_action::objfile): New field.
2895         (probes_table_htab_remove_objfile_probes)
2896         (probes_table_remove_objfile_probes): New functions.
2897         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2898         in the new probe_and_action.  Don't store the probe in 'lookup'.
2899         (svr4_create_probe_breakpoints): Pass objfile to
2900         register_solib_event_probe.
2901         (_initialize_svr4_solib): Register a free_objfile observer.
2902
2903 2019-04-19  Tom Tromey  <tom@tromey.com>
2904
2905         * common/queue.h: Remove.
2906
2907 2019-04-19  Tom Tromey  <tom@tromey.com>
2908
2909         * event-loop.c: Don't include "common/queue.h".
2910
2911 2019-04-19  Tom Tromey  <tom@tromey.com>
2912
2913         * remote.c (remote_target): Use delete.
2914         * remote-notif.h: Include <list>, not "common/queue.h".
2915         (notif_client_p): Remove typedef.
2916         (remote_notif_state): Add constructor, destructor, initializer.
2917         <notif_queue>: Now a std::list.
2918         (remote_notif_state_xfree): Don't declare.
2919         * remote-notif.c (remote_notif_process, handle_notification)
2920         (remote_notif_state_allocate): Update.
2921         (~remote_notif_state): Rename from remote_notif_state_xfree.
2922
2923 2019-04-19  Tom Tromey  <tom@tromey.com>
2924
2925         * symfile.c (reread_symbols): Update.
2926         * objfiles.c (objfile_register_static_link)
2927         (objfile_lookup_static_link): Update
2928         (~objfile) Don't delete static_links.
2929         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2930
2931 2019-04-19  Tom Tromey  <tom@tromey.com>
2932
2933         * type-stack.h (struct type_stack) <insert>: Constify string.
2934         * type-stack.c (type_stack::insert): Constify string.
2935         * gdbtypes.h (lookup_template_type): Update.
2936         (address_space_name_to_int): Update.
2937         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2938         const.
2939         (lookup_template_type): Make name const.
2940         * c-exp.y: Update rules.
2941         (lex_one_token, classify_name, classify_inner_name)
2942         (c_print_token): Update.
2943         * p-exp.y: Update rules.
2944         (yylex): Update.
2945         * f-exp.y: Update rules.
2946         (yylex): Update.
2947         * d-exp.y: Update rules.
2948         (lex_one_token, classify_name, classify_inner_name): Update.
2949         * parse.c (write_dollar_variable, copy_name): Return std::string.
2950         * parser-defs.h (copy_name): Change return type.
2951         * m2-exp.y: Update rules.
2952         (yylex): Update.
2953         * go-exp.y (lex_one_token): Update.
2954         Update rules.
2955         (classify_unsafe_function, classify_packaged_name)
2956         (classify_name, yylex): Update.
2957
2958 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2959
2960         * configure.ac: add --enable-source-highlight switch.
2961         * configure: Regenerate.
2962         * top.c (print_gdb_version): plumb --enable-source-highlight
2963         status to "show configuration".
2964
2965 2019-04-19  Tom Tromey  <tromey@adacore.com>
2966
2967         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2968         Check ADA_TYPE_P.
2969         (empty_record, ada_template_to_fixed_record_type_1)
2970         (template_to_static_fixed_type)
2971         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2972         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2973         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2974         macros.
2975
2976 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2977
2978         PR symtab/24423:
2979         * source.c (print_source_lines_base): Advance "iter" when a
2980         control character is seen.
2981
2982 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2983
2984         * inferior.h (struct infcall_suspend_state_deleter):
2985         Catch exception in destructor to avoid crash.
2986
2987 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2988
2989         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2990         close to the add_com "shell".
2991
2992 2019-04-18  Tom Tromey  <tromey@adacore.com>
2993
2994         * process-stratum-target.h (class process_stratum_target)
2995         <stratum>: Add "final".
2996
2997 2019-04-17  Tom Tromey  <tromey@adacore.com>
2998
2999         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3000         against nullptr before use.
3001
3002 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3003
3004         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3005
3006 2019-04-17  Jim Wilson  <jimw@sifive.com>
3007             Andrew Burgess  <andrew.burgess@embecosm.com>
3008
3009         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3010         code read might fail, assume 4-byte breakpoint in that case.
3011
3012 2019-04-15  Leszek Swirski  <leszeks@google.com>
3013
3014         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3015         rather than a hand-rolled POD check when checking for forced MEMORY
3016         classification.
3017
3018 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3019
3020         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3021         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3022         function.
3023         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3024         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3025         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3026         declaration.
3027
3028 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3029
3030         * aarch64-linux-nat.c
3031         (aarch64_linux_nat_target::thread_architecture): Add override.
3032         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3033         each VQ.
3034
3035 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3036
3037         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3038
3039 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3040
3041         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3042         target types of size 96-bits, add some additional comments, and
3043         check that the builtin type we found was the correct size.
3044
3045 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3046
3047         * utils.c (prompt_for_continue): Don't restore the styling at the
3048         end, as applied_style has the wrong value.  This fixes styling in
3049         long lists of file names that are interrupted by the "Continue?"
3050         prompt.
3051
3052 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3053
3054         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3055         * c-lang.c (c_language_defn): Likewise.
3056         (cplus_language_defn): Likewise.
3057         (asm_language_defn): Likewise.
3058         (minimal_language_defn): Likewise.
3059         * d-lang.c (d_language_defn): Likewise.
3060         * f-lang.c (f_language_defn): Likewise.
3061         * go-lang.c (go_language_defn): Likewise.
3062         * language.c (unknown_language_defn): Likewise.
3063         (auto_language_defn): Likewise.
3064         * language.h (struct language_defn): Remove la_magic field.
3065         (LANG_MAGIC): Delete.
3066         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3067         * objc-lang.c (objc_language_defn): Likewise.
3068         * opencl-lang.c (opencl_language_defn): Likewise.
3069         * p-lang.c (pascal_language_defn): Likewise.
3070         * rust-lang.c (rust_language_defn): Likewise.
3071
3072 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3073
3074         * riscv-tdep.c (riscv_type_align): New function.
3075         (riscv_type_alignment): Delete.
3076         (riscv_arg_location): Use 'type_align'.
3077         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3078
3079 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3080
3081         * gdbtypes.c (type_align): A struct with no non-static fields also
3082         has alignment of 1.
3083
3084 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3085
3086         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3087         component to 0.
3088         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3089         member.
3090         (riscv_struct_info::analyse): New implementation using new
3091         analyse_inner member function.
3092         (riscv_struct_info::field_offset): New member function.
3093         (riscv_struct_info::m_offsets): New member variable.
3094         (riscv_struct_info::analyse_inner): New private member function,
3095         takes the old implementation of riscv_struct_info::analyse but
3096         extended to track field offsets.
3097         (riscv_call_arg_struct): Update the struct folding special cases
3098         to handle cases where empty C++ structs, which are non-zero
3099         length, are found.
3100         (riscv_arg_location): Initialise the length of each location, a
3101         non-zero length now indicates the location is in use.
3102         (riscv_push_dummy_call): Allow for the first location having a
3103         non-zero offset when setting up arguments.
3104         (riscv_return_value): Likewise, but for return values.
3105
3106 2019-04-11  Tom Tromey  <tromey@adacore.com>
3107
3108         * utils.c (internal_vproblem): Make "msg" const.
3109
3110 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3111
3112         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3113         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3114         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3115         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3116
3117 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3118
3119         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3120         function.
3121         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3122         of amd64_collect_native_gregset.
3123         (amd64_linux_nat_target::store_registers): Likewise.
3124
3125 2019-04-10  Tom Tromey  <tom@tromey.com>
3126
3127         * symtab.c (lookup_global_symbol_from_objfile)
3128         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3129         * objfiles.h (class separate_debug_iterator): New.
3130         (class separate_debug_range): New.
3131         (struct objfile) <separate_debug_objfiles>: New method.
3132         (objfile_separate_debug_iterate): Don't declare.
3133         * objfiles.c (separate_debug_iterator::operator++): Rename from
3134         objfile_separate_debug_iterate.
3135         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3136         iterator.
3137         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3138         iterator.
3139
3140 2019-04-10  Tom Tromey  <tom@tromey.com>
3141
3142         * symfile.c (reread_symbols): Remove old comment.
3143         * objfiles.c (free_all_objfiles): Fix a typo.
3144
3145 2019-04-10  Tom Tromey  <tom@tromey.com>
3146
3147         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3148         * minsyms.c (lookup_minimal_symbol): Use foreach.
3149         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3150         (lookup_minimal_symbol_solib_trampoline): Likewise.
3151         * symfile.c (reread_symbols): Use foreach.
3152
3153 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3154             Tom Tromey  <tromey@adacore.com>
3155
3156         PR rust/24414:
3157         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3158         (rust_lex_int_test): Change "value" to be LONGEST.
3159         (rust_lex_tests): Add test for long integer literal.
3160
3161 2019-04-09  Tom Tromey  <tromey@adacore.com>
3162
3163         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3164         to bool.
3165         (extended_remote_target::attach): Update.
3166         (remote_target::remote_notice_new_inferior): Update.
3167         (remote_target::add_current_inferior_and_thread): Update.
3168         * inferior.c (exit_inferior_1): Use "false".
3169         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3170
3171 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3172
3173         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3174         the "start" command.
3175
3176 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3177
3178         * python/py-inferior.c (infpy_thread_from_thread_handle):
3179         Adjust comments to reflect renaming of thread_from_thread_handle
3180         to thread_from_handle.  Adjust keywords.  Fix type error message.
3181         (inferior_object_methods): Add thread_from_handle.  Retain
3182         thread_from_thread_handle, but mark it as deprecated.
3183
3184 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3185
3186         * gdbthread.h (find_thread_by_handle): Revise declaration.
3187         * thread.c (find_thread_by_handle): Likewise.  Adjust
3188         implementation too.
3189         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3190         support for buffer objects as handles.
3191
3192 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3193
3194         * python/py-infthread.c (thpy_thread_handle): New function.
3195         (thread_object_methods): Register thpy_thread_handle.
3196
3197 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3198
3199         * gdbthread.h (thread_to_thread_handle): Declare.
3200         * thread.c (gdbtypes.h): Include.
3201         (thread_to_thread_handle): New function.
3202
3203         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3204         (target_thread_info_to_thread_handle): Declare.
3205         * target.c (target_thread_info_to_thread_handle): New function.
3206         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3207         * target-delegates.c: Regenerate.
3208
3209         * linux-thread-db.c (class thread_db_target): Add method
3210         thread_info_to_thread_handle.
3211         (thread_db_target::thread_info_to_thread_handle): Define.
3212         * remote.c (class remote_target): Add new method
3213         thread_info_to_thread_handle.
3214         (remote_target::thread_info_to_thread_handle): Define.
3215
3216 2019-04-08  Pedro Alves  <palves@redhat.com>
3217
3218         * common/common-exceptions.c (throw_exception): Don't create
3219         named object to throw; throw directly.
3220         (throw_it): Likewise.  Don't initialize gdb_exception::message
3221         here, with new; pass FMT and AP to the ctor instead.
3222         * common/common-exceptions.h: Include <string>.
3223         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3224         const char *, va_list)): New ctor.  Use std::make_shared.
3225         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3226         errors)): Delete.
3227         (gdb_exception_error::gdb_exception_error(enum errors, const char
3228         *, va_list)): New.
3229         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3230         Add assertion.
3231         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3232         errors)): Delete.
3233         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3234         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3235         Add assertion.
3236
3237 2019-04-08  Tom Tromey  <tom@tromey.com>
3238
3239         * valops.c (value_rtti_indirect_type): Replace throw_exception
3240         with throw.
3241         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3242         with throw.
3243         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3244         throw.
3245         * target.c (target_translate_tls_address): Replace throw_exception
3246         with throw.
3247         * stack.c (frame_apply_command_count): Replace throw_exception
3248         with throw.
3249         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3250         throw.
3251         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3252         with throw.
3253         * rs6000-tdep.c (rs6000_frame_cache)
3254         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3255         * remote.c: Replace throw_exception with throw.
3256         * record-full.c (record_full_message, record_full_wait_1)
3257         (record_full_restore): Replace throw_exception with throw.
3258         * record-btrace.c:
3259         (get_thread_current_frame_id, record_btrace_start_replaying)
3260         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3261         (cmd_record_btrace_start): Replace throw_exception with throw.
3262         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3263         throw.
3264         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3265         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3266         * linespec.c:
3267         (find_linespec_symbols): Replace throw_exception with throw.
3268         * infrun.c (displaced_step_prepare, resume): Replace
3269         throw_exception with throw.
3270         * infcmd.c (post_create_inferior): Replace throw_exception with
3271         throw.
3272         * inf-loop.c (inferior_event_handler): Replace throw_exception
3273         with throw.
3274         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3275         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3276         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3277         (get_prev_frame_always, get_frame_pc_if_available)
3278         (get_frame_address_in_block_if_available, get_frame_language):
3279         Replace throw_exception with throw.
3280         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3281         throw_exception with throw.
3282         * eval.c (fetch_subexp_value, evaluate_var_value)
3283         (evaluate_funcall, evaluate_subexp_standard): Replace
3284         throw_exception with throw.
3285         * dwarf2loc.c (call_site_find_chain)
3286         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3287         Replace throw_exception with throw.
3288         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3289         with throw.
3290         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3291         throw.
3292         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3293         * completer.c (complete_line_internal): Replace throw_exception
3294         with throw.
3295         * compile/compile-object-run.c (compile_object_run): Replace
3296         throw_exception with throw.
3297         * cli/cli-script.c (process_next_line): Replace throw_exception
3298         with throw.
3299         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3300         (btrace_enable, btrace_maint_update_pt_packets): Replace
3301         throw_exception with throw.
3302         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3303         throw_exception with throw.
3304         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3305         throw_exception with throw.
3306         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3307         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3308         * aarch64-tdep.c (aarch64_make_prologue_cache)
3309         (aarch64_make_stub_cache): Replace throw_exception with throw.
3310
3311 2019-04-08  Tom Tromey  <tom@tromey.com>
3312
3313         * common/common-exceptions.c (throw_exception): Rename from
3314         throw_exception_cxx.  Remove old copy.  Make argument const.
3315         (throw_it): Create and throw exception objects directly.
3316         * common/common-exceptions.h (throw_exception): Make argument
3317         const.
3318         (struct gdb_exception_error): Add constructor.
3319         (struct gdb_exception_quit): Add constructor.
3320
3321 2019-04-08  Tom Tromey  <tom@tromey.com>
3322
3323         * common/common-exceptions.h (exception_rethrow): Don't declare.
3324         (TRY_SJLJ): Update comment.
3325         (TRY, CATCH, END_CATCH): Remove.
3326         * common/common-exceptions.c (exception_rethrow): Remove.
3327
3328 2019-04-08  Tom Tromey  <tom@tromey.com>
3329
3330         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3331         Remove.
3332         (gdb_exception_error): Rename from
3333         gdb_exception_RETURN_MASK_ERROR.
3334         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3335         (gdb_quit_bad_alloc): Update.
3336         * aarch64-tdep.c: Update.
3337         * ada-lang.c: Update.
3338         * ada-typeprint.c: Update.
3339         * ada-valprint.c: Update.
3340         * amd64-tdep.c: Update.
3341         * arch-utils.c: Update.
3342         * break-catch-throw.c: Update.
3343         * breakpoint.c: Update.
3344         * btrace.c: Update.
3345         * c-varobj.c: Update.
3346         * cli/cli-cmds.c: Update.
3347         * cli/cli-interp.c: Update.
3348         * cli/cli-script.c: Update.
3349         * common/common-exceptions.c: Update.
3350         * common/new-op.c: Update.
3351         * common/selftest.c: Update.
3352         * compile/compile-c-symbols.c: Update.
3353         * compile/compile-cplus-symbols.c: Update.
3354         * compile/compile-object-load.c: Update.
3355         * compile/compile-object-run.c: Update.
3356         * completer.c: Update.
3357         * corelow.c: Update.
3358         * cp-abi.c: Update.
3359         * cp-support.c: Update.
3360         * cp-valprint.c: Update.
3361         * darwin-nat.c: Update.
3362         * disasm-selftests.c: Update.
3363         * dtrace-probe.c: Update.
3364         * dwarf-index-cache.c: Update.
3365         * dwarf-index-write.c: Update.
3366         * dwarf2-frame-tailcall.c: Update.
3367         * dwarf2-frame.c: Update.
3368         * dwarf2loc.c: Update.
3369         * dwarf2read.c: Update.
3370         * eval.c: Update.
3371         * event-loop.c: Update.
3372         * event-top.c: Update.
3373         * exec.c: Update.
3374         * f-valprint.c: Update.
3375         * fbsd-tdep.c: Update.
3376         * frame-unwind.c: Update.
3377         * frame.c: Update.
3378         * gdbtypes.c: Update.
3379         * gnu-v3-abi.c: Update.
3380         * guile/guile-internal.h: Update.
3381         * guile/scm-block.c: Update.
3382         * guile/scm-breakpoint.c: Update.
3383         * guile/scm-cmd.c: Update.
3384         * guile/scm-disasm.c: Update.
3385         * guile/scm-frame.c: Update.
3386         * guile/scm-lazy-string.c: Update.
3387         * guile/scm-math.c: Update.
3388         * guile/scm-param.c: Update.
3389         * guile/scm-ports.c: Update.
3390         * guile/scm-pretty-print.c: Update.
3391         * guile/scm-symbol.c: Update.
3392         * guile/scm-symtab.c: Update.
3393         * guile/scm-type.c: Update.
3394         * guile/scm-value.c: Update.
3395         * i386-linux-tdep.c: Update.
3396         * i386-tdep.c: Update.
3397         * inf-loop.c: Update.
3398         * infcall.c: Update.
3399         * infcmd.c: Update.
3400         * infrun.c: Update.
3401         * jit.c: Update.
3402         * language.c: Update.
3403         * linespec.c: Update.
3404         * linux-fork.c: Update.
3405         * linux-nat.c: Update.
3406         * linux-tdep.c: Update.
3407         * linux-thread-db.c: Update.
3408         * main.c: Update.
3409         * mi/mi-cmd-break.c: Update.
3410         * mi/mi-cmd-stack.c: Update.
3411         * mi/mi-interp.c: Update.
3412         * mi/mi-main.c: Update.
3413         * objc-lang.c: Update.
3414         * p-valprint.c: Update.
3415         * parse.c: Update.
3416         * ppc-linux-tdep.c: Update.
3417         * printcmd.c: Update.
3418         * python/py-arch.c: Update.
3419         * python/py-breakpoint.c: Update.
3420         * python/py-cmd.c: Update.
3421         * python/py-finishbreakpoint.c: Update.
3422         * python/py-frame.c: Update.
3423         * python/py-framefilter.c: Update.
3424         * python/py-gdb-readline.c: Update.
3425         * python/py-inferior.c: Update.
3426         * python/py-infthread.c: Update.
3427         * python/py-lazy-string.c: Update.
3428         * python/py-linetable.c: Update.
3429         * python/py-objfile.c: Update.
3430         * python/py-param.c: Update.
3431         * python/py-prettyprint.c: Update.
3432         * python/py-progspace.c: Update.
3433         * python/py-record-btrace.c: Update.
3434         * python/py-record.c: Update.
3435         * python/py-symbol.c: Update.
3436         * python/py-type.c: Update.
3437         * python/py-unwind.c: Update.
3438         * python/py-utils.c: Update.
3439         * python/py-value.c: Update.
3440         * python/python.c: Update.
3441         * record-btrace.c: Update.
3442         * record-full.c: Update.
3443         * remote-fileio.c: Update.
3444         * remote.c: Update.
3445         * riscv-tdep.c: Update.
3446         * rs6000-aix-tdep.c: Update.
3447         * rs6000-tdep.c: Update.
3448         * rust-exp.y: Update.
3449         * rust-lang.c: Update.
3450         * s390-tdep.c: Update.
3451         * selftest-arch.c: Update.
3452         * solib-dsbt.c: Update.
3453         * solib-frv.c: Update.
3454         * solib-spu.c: Update.
3455         * solib-svr4.c: Update.
3456         * solib.c: Update.
3457         * sparc64-linux-tdep.c: Update.
3458         * stack.c: Update.
3459         * symfile-mem.c: Update.
3460         * symmisc.c: Update.
3461         * target.c: Update.
3462         * thread.c: Update.
3463         * top.c: Update.
3464         * tracefile-tfile.c: Update.
3465         * tui/tui.c: Update.
3466         * typeprint.c: Update.
3467         * unittests/cli-utils-selftests.c: Update.
3468         * unittests/parse-connection-spec-selftests.c: Update.
3469         * valops.c: Update.
3470         * valprint.c: Update.
3471         * value.c: Update.
3472         * varobj.c: Update.
3473         * windows-nat.c: Update.
3474         * x86-linux-nat.c: Update.
3475         * xml-support.c: Update.
3476
3477 2019-04-08  Tom Tromey  <tom@tromey.com>
3478
3479         * xml-support.c: Use C++ exception handling.
3480         * x86-linux-nat.c: Use C++ exception handling.
3481         * windows-nat.c: Use C++ exception handling.
3482         * varobj.c: Use C++ exception handling.
3483         * value.c: Use C++ exception handling.
3484         * valprint.c: Use C++ exception handling.
3485         * valops.c: Use C++ exception handling.
3486         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3487         handling.
3488         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3489         * typeprint.c: Use C++ exception handling.
3490         * tui/tui.c: Use C++ exception handling.
3491         * tracefile-tfile.c: Use C++ exception handling.
3492         * top.c: Use C++ exception handling.
3493         * thread.c: Use C++ exception handling.
3494         * target.c: Use C++ exception handling.
3495         * symmisc.c: Use C++ exception handling.
3496         * symfile-mem.c: Use C++ exception handling.
3497         * stack.c: Use C++ exception handling.
3498         * sparc64-linux-tdep.c: Use C++ exception handling.
3499         * solib.c: Use C++ exception handling.
3500         * solib-svr4.c: Use C++ exception handling.
3501         * solib-spu.c: Use C++ exception handling.
3502         * solib-frv.c: Use C++ exception handling.
3503         * solib-dsbt.c: Use C++ exception handling.
3504         * selftest-arch.c: Use C++ exception handling.
3505         * s390-tdep.c: Use C++ exception handling.
3506         * rust-lang.c: Use C++ exception handling.
3507         * rust-exp.y: Use C++ exception handling.
3508         * rs6000-tdep.c: Use C++ exception handling.
3509         * rs6000-aix-tdep.c: Use C++ exception handling.
3510         * riscv-tdep.c: Use C++ exception handling.
3511         * remote.c: Use C++ exception handling.
3512         * remote-fileio.c: Use C++ exception handling.
3513         * record-full.c: Use C++ exception handling.
3514         * record-btrace.c: Use C++ exception handling.
3515         * python/python.c: Use C++ exception handling.
3516         * python/py-value.c: Use C++ exception handling.
3517         * python/py-utils.c: Use C++ exception handling.
3518         * python/py-unwind.c: Use C++ exception handling.
3519         * python/py-type.c: Use C++ exception handling.
3520         * python/py-symbol.c: Use C++ exception handling.
3521         * python/py-record.c: Use C++ exception handling.
3522         * python/py-record-btrace.c: Use C++ exception handling.
3523         * python/py-progspace.c: Use C++ exception handling.
3524         * python/py-prettyprint.c: Use C++ exception handling.
3525         * python/py-param.c: Use C++ exception handling.
3526         * python/py-objfile.c: Use C++ exception handling.
3527         * python/py-linetable.c: Use C++ exception handling.
3528         * python/py-lazy-string.c: Use C++ exception handling.
3529         * python/py-infthread.c: Use C++ exception handling.
3530         * python/py-inferior.c: Use C++ exception handling.
3531         * python/py-gdb-readline.c: Use C++ exception handling.
3532         * python/py-framefilter.c: Use C++ exception handling.
3533         * python/py-frame.c: Use C++ exception handling.
3534         * python/py-finishbreakpoint.c: Use C++ exception handling.
3535         * python/py-cmd.c: Use C++ exception handling.
3536         * python/py-breakpoint.c: Use C++ exception handling.
3537         * python/py-arch.c: Use C++ exception handling.
3538         * printcmd.c: Use C++ exception handling.
3539         * ppc-linux-tdep.c: Use C++ exception handling.
3540         * parse.c: Use C++ exception handling.
3541         * p-valprint.c: Use C++ exception handling.
3542         * objc-lang.c: Use C++ exception handling.
3543         * mi/mi-main.c: Use C++ exception handling.
3544         * mi/mi-interp.c: Use C++ exception handling.
3545         * mi/mi-cmd-stack.c: Use C++ exception handling.
3546         * mi/mi-cmd-break.c: Use C++ exception handling.
3547         * main.c: Use C++ exception handling.
3548         * linux-thread-db.c: Use C++ exception handling.
3549         * linux-tdep.c: Use C++ exception handling.
3550         * linux-nat.c: Use C++ exception handling.
3551         * linux-fork.c: Use C++ exception handling.
3552         * linespec.c: Use C++ exception handling.
3553         * language.c: Use C++ exception handling.
3554         * jit.c: Use C++ exception handling.
3555         * infrun.c: Use C++ exception handling.
3556         * infcmd.c: Use C++ exception handling.
3557         * infcall.c: Use C++ exception handling.
3558         * inf-loop.c: Use C++ exception handling.
3559         * i386-tdep.c: Use C++ exception handling.
3560         * i386-linux-tdep.c: Use C++ exception handling.
3561         * guile/scm-value.c: Use C++ exception handling.
3562         * guile/scm-type.c: Use C++ exception handling.
3563         * guile/scm-symtab.c: Use C++ exception handling.
3564         * guile/scm-symbol.c: Use C++ exception handling.
3565         * guile/scm-pretty-print.c: Use C++ exception handling.
3566         * guile/scm-ports.c: Use C++ exception handling.
3567         * guile/scm-param.c: Use C++ exception handling.
3568         * guile/scm-math.c: Use C++ exception handling.
3569         * guile/scm-lazy-string.c: Use C++ exception handling.
3570         * guile/scm-frame.c: Use C++ exception handling.
3571         * guile/scm-disasm.c: Use C++ exception handling.
3572         * guile/scm-cmd.c: Use C++ exception handling.
3573         * guile/scm-breakpoint.c: Use C++ exception handling.
3574         * guile/scm-block.c: Use C++ exception handling.
3575         * guile/guile-internal.h: Use C++ exception handling.
3576         * gnu-v3-abi.c: Use C++ exception handling.
3577         * gdbtypes.c: Use C++ exception handling.
3578         * frame.c: Use C++ exception handling.
3579         * frame-unwind.c: Use C++ exception handling.
3580         * fbsd-tdep.c: Use C++ exception handling.
3581         * f-valprint.c: Use C++ exception handling.
3582         * exec.c: Use C++ exception handling.
3583         * event-top.c: Use C++ exception handling.
3584         * event-loop.c: Use C++ exception handling.
3585         * eval.c: Use C++ exception handling.
3586         * dwarf2read.c: Use C++ exception handling.
3587         * dwarf2loc.c: Use C++ exception handling.
3588         * dwarf2-frame.c: Use C++ exception handling.
3589         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3590         * dwarf-index-write.c: Use C++ exception handling.
3591         * dwarf-index-cache.c: Use C++ exception handling.
3592         * dtrace-probe.c: Use C++ exception handling.
3593         * disasm-selftests.c: Use C++ exception handling.
3594         * darwin-nat.c: Use C++ exception handling.
3595         * cp-valprint.c: Use C++ exception handling.
3596         * cp-support.c: Use C++ exception handling.
3597         * cp-abi.c: Use C++ exception handling.
3598         * corelow.c: Use C++ exception handling.
3599         * completer.c: Use C++ exception handling.
3600         * compile/compile-object-run.c: Use C++ exception handling.
3601         * compile/compile-object-load.c: Use C++ exception handling.
3602         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3603         * compile/compile-c-symbols.c: Use C++ exception handling.
3604         * common/selftest.c: Use C++ exception handling.
3605         * common/new-op.c: Use C++ exception handling.
3606         * cli/cli-script.c: Use C++ exception handling.
3607         * cli/cli-interp.c: Use C++ exception handling.
3608         * cli/cli-cmds.c: Use C++ exception handling.
3609         * c-varobj.c: Use C++ exception handling.
3610         * btrace.c: Use C++ exception handling.
3611         * breakpoint.c: Use C++ exception handling.
3612         * break-catch-throw.c: Use C++ exception handling.
3613         * arch-utils.c: Use C++ exception handling.
3614         * amd64-tdep.c: Use C++ exception handling.
3615         * ada-valprint.c: Use C++ exception handling.
3616         * ada-typeprint.c: Use C++ exception handling.
3617         * ada-lang.c: Use C++ exception handling.
3618         * aarch64-tdep.c: Use C++ exception handling.
3619
3620 2019-04-08  Tom Tromey  <tom@tromey.com>
3621
3622         * xml-support.c (gdb_xml_parser::parse): Update.
3623         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3624         * value.c (show_convenience): Update.
3625         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3626         (test_parse_flags_qcs): Update.
3627         * thread.c (thr_try_catch_cmd): Update.
3628         * target.c (target_translate_tls_address): Update.
3629         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3630         (info_frame_command_core, frame_apply_command_count): Update.
3631         * rust-exp.y (rust_lex_exception_test): Update.
3632         * riscv-tdep.c (riscv_print_one_register_info): Update.
3633         * remote.c (remote_target::enable_btrace): Update.
3634         * record-btrace.c (record_btrace_enable_warn): Update.
3635         * python/py-utils.c (gdbpy_convert_exception): Update.
3636         * printcmd.c (do_one_display, print_variable_and_value): Update.
3637         * mi/mi-main.c (mi_print_exception): Update.
3638         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3639         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3640         * linux-nat.c (linux_nat_target::attach): Update.
3641         * linux-fork.c (class scoped_switch_fork_info): Update.
3642         * infrun.c (displaced_step_prepare): Update.
3643         * infcall.c (call_function_by_hand_dummy): Update.
3644         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3645         * gnu-v3-abi.c (print_one_vtable): Update.
3646         * frame.c (get_prev_frame_always): Update.
3647         * f-valprint.c (info_common_command_for_block): Update.
3648         * exec.c (try_open_exec_file): Update.
3649         * exceptions.c (print_exception, exception_print)
3650         (exception_fprintf, exception_print_same): Update.
3651         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3652         * dwarf-index-cache.c (index_cache::store)
3653         (index_cache::lookup_gdb_index): Update.
3654         * darwin-nat.c (maybe_cache_shell): Update.
3655         * cp-valprint.c (cp_print_value_fields): Update.
3656         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3657         (gcc_cplus_symbol_address): Update.
3658         * compile/compile-c-symbols.c (gcc_convert_symbol)
3659         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3660         * common/selftest.c: Update.
3661         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3662         a std::string.
3663         (exception_try_scope_entry, exception_try_scope_exit): Don't
3664         declare.
3665         (struct exception_try_scope): Remove.
3666         (TRY): Don't use exception_try_scope.
3667         (struct gdb_exception): Add constructor, operator=.
3668         <what>: New method.
3669         (struct gdb_exception_RETURN_MASK_ALL)
3670         (struct gdb_exception_RETURN_MASK_ERROR)
3671         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3672         (struct gdb_quit_bad_alloc): Update.
3673         * common/common-exceptions.c (exception_none): Change
3674         initializer.
3675         (struct catcher) <state, exception>: Initialize inline.
3676         <prev>: Remove member.
3677         (current_catcher): Remove.
3678         (catchers): New global.
3679         (exceptions_state_mc_init): Simplify.
3680         (catcher_pop): Remove.
3681         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3682         (try_scope_depth, exception_try_scope_entry)
3683         (exception_try_scope_exit): Remove.
3684         (throw_exception_sjlj): Update.
3685         (exception_messages, exception_messages_size): Remove.
3686         (throw_it): Simplify.
3687         (gdb_exception_sliced_copy): Remove.
3688         (throw_exception_cxx): Update.
3689         * cli/cli-script.c (script_from_file): Update.
3690         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3691         Update.
3692         * ada-valprint.c (ada_val_print): Update.
3693         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3694         (create_excep_cond_exprs): Update.
3695
3696 2019-04-08  Tom Tromey  <tom@tromey.com>
3697
3698         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3699         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3700         (TRY, CATCH, END_CATCH): Remove some definitions.
3701         * common/common-exceptions.c: Don't use GDB_XCPT.
3702         (catcher_list_size): Remove.
3703         (throw_exception, throw_it): Simplify.
3704
3705 2019-04-05  Tom Tromey  <tom@tromey.com>
3706
3707         Revert the header-sorting patch.
3708         * ft32-tdep.c: Revert.
3709         * frv-tdep.c: Revert.
3710         * frv-linux-tdep.c: Revert.
3711         * frame.c: Revert.
3712         * frame-unwind.c: Revert.
3713         * frame-base.c: Revert.
3714         * fork-child.c: Revert.
3715         * findvar.c: Revert.
3716         * findcmd.c: Revert.
3717         * filesystem.c: Revert.
3718         * filename-seen-cache.h: Revert.
3719         * filename-seen-cache.c: Revert.
3720         * fbsd-tdep.c: Revert.
3721         * fbsd-nat.h: Revert.
3722         * fbsd-nat.c: Revert.
3723         * f-valprint.c: Revert.
3724         * f-typeprint.c: Revert.
3725         * f-lang.c: Revert.
3726         * extension.h: Revert.
3727         * extension.c: Revert.
3728         * extension-priv.h: Revert.
3729         * expprint.c: Revert.
3730         * exec.h: Revert.
3731         * exec.c: Revert.
3732         * exceptions.c: Revert.
3733         * event-top.c: Revert.
3734         * event-loop.c: Revert.
3735         * eval.c: Revert.
3736         * elfread.c: Revert.
3737         * dwarf2read.h: Revert.
3738         * dwarf2read.c: Revert.
3739         * dwarf2loc.c: Revert.
3740         * dwarf2expr.h: Revert.
3741         * dwarf2expr.c: Revert.
3742         * dwarf2-frame.c: Revert.
3743         * dwarf2-frame-tailcall.c: Revert.
3744         * dwarf-index-write.h: Revert.
3745         * dwarf-index-write.c: Revert.
3746         * dwarf-index-common.c: Revert.
3747         * dwarf-index-cache.h: Revert.
3748         * dwarf-index-cache.c: Revert.
3749         * dummy-frame.c: Revert.
3750         * dtrace-probe.c: Revert.
3751         * disasm.h: Revert.
3752         * disasm.c: Revert.
3753         * disasm-selftests.c: Revert.
3754         * dictionary.c: Revert.
3755         * dicos-tdep.c: Revert.
3756         * demangle.c: Revert.
3757         * dcache.h: Revert.
3758         * dcache.c: Revert.
3759         * darwin-nat.h: Revert.
3760         * darwin-nat.c: Revert.
3761         * darwin-nat-info.c: Revert.
3762         * d-valprint.c: Revert.
3763         * d-namespace.c: Revert.
3764         * d-lang.c: Revert.
3765         * ctf.c: Revert.
3766         * csky-tdep.c: Revert.
3767         * csky-linux-tdep.c: Revert.
3768         * cris-tdep.c: Revert.
3769         * cris-linux-tdep.c: Revert.
3770         * cp-valprint.c: Revert.
3771         * cp-support.c: Revert.
3772         * cp-namespace.c: Revert.
3773         * cp-abi.c: Revert.
3774         * corelow.c: Revert.
3775         * corefile.c: Revert.
3776         * continuations.c: Revert.
3777         * completer.h: Revert.
3778         * completer.c: Revert.
3779         * complaints.c: Revert.
3780         * coffread.c: Revert.
3781         * coff-pe-read.c: Revert.
3782         * cli-out.h: Revert.
3783         * cli-out.c: Revert.
3784         * charset.c: Revert.
3785         * c-varobj.c: Revert.
3786         * c-valprint.c: Revert.
3787         * c-typeprint.c: Revert.
3788         * c-lang.c: Revert.
3789         * buildsym.c: Revert.
3790         * buildsym-legacy.c: Revert.
3791         * build-id.h: Revert.
3792         * build-id.c: Revert.
3793         * btrace.c: Revert.
3794         * bsd-uthread.c: Revert.
3795         * breakpoint.h: Revert.
3796         * breakpoint.c: Revert.
3797         * break-catch-throw.c: Revert.
3798         * break-catch-syscall.c: Revert.
3799         * break-catch-sig.c: Revert.
3800         * blockframe.c: Revert.
3801         * block.c: Revert.
3802         * bfin-tdep.c: Revert.
3803         * bfin-linux-tdep.c: Revert.
3804         * bfd-target.c: Revert.
3805         * bcache.c: Revert.
3806         * ax-general.c: Revert.
3807         * ax-gdb.h: Revert.
3808         * ax-gdb.c: Revert.
3809         * avr-tdep.c: Revert.
3810         * auxv.c: Revert.
3811         * auto-load.c: Revert.
3812         * arm-wince-tdep.c: Revert.
3813         * arm-tdep.c: Revert.
3814         * arm-symbian-tdep.c: Revert.
3815         * arm-pikeos-tdep.c: Revert.
3816         * arm-obsd-tdep.c: Revert.
3817         * arm-nbsd-tdep.c: Revert.
3818         * arm-nbsd-nat.c: Revert.
3819         * arm-linux-tdep.c: Revert.
3820         * arm-linux-nat.c: Revert.
3821         * arm-fbsd-tdep.c: Revert.
3822         * arm-fbsd-nat.c: Revert.
3823         * arm-bsd-tdep.c: Revert.
3824         * arch-utils.c: Revert.
3825         * arc-tdep.c: Revert.
3826         * arc-newlib-tdep.c: Revert.
3827         * annotate.h: Revert.
3828         * annotate.c: Revert.
3829         * amd64-windows-tdep.c: Revert.
3830         * amd64-windows-nat.c: Revert.
3831         * amd64-tdep.c: Revert.
3832         * amd64-sol2-tdep.c: Revert.
3833         * amd64-obsd-tdep.c: Revert.
3834         * amd64-obsd-nat.c: Revert.
3835         * amd64-nbsd-tdep.c: Revert.
3836         * amd64-nbsd-nat.c: Revert.
3837         * amd64-nat.c: Revert.
3838         * amd64-linux-tdep.c: Revert.
3839         * amd64-linux-nat.c: Revert.
3840         * amd64-fbsd-tdep.c: Revert.
3841         * amd64-fbsd-nat.c: Revert.
3842         * amd64-dicos-tdep.c: Revert.
3843         * amd64-darwin-tdep.c: Revert.
3844         * amd64-bsd-nat.c: Revert.
3845         * alpha-tdep.c: Revert.
3846         * alpha-obsd-tdep.c: Revert.
3847         * alpha-nbsd-tdep.c: Revert.
3848         * alpha-mdebug-tdep.c: Revert.
3849         * alpha-linux-tdep.c: Revert.
3850         * alpha-linux-nat.c: Revert.
3851         * alpha-bsd-tdep.c: Revert.
3852         * alpha-bsd-nat.c: Revert.
3853         * aix-thread.c: Revert.
3854         * agent.c: Revert.
3855         * addrmap.c: Revert.
3856         * ada-varobj.c: Revert.
3857         * ada-valprint.c: Revert.
3858         * ada-typeprint.c: Revert.
3859         * ada-tasks.c: Revert.
3860         * ada-lang.c: Revert.
3861         * aarch64-tdep.c: Revert.
3862         * aarch64-ravenscar-thread.c: Revert.
3863         * aarch64-newlib-tdep.c: Revert.
3864         * aarch64-linux-tdep.c: Revert.
3865         * aarch64-linux-nat.c: Revert.
3866         * aarch64-fbsd-tdep.c: Revert.
3867         * aarch64-fbsd-nat.c: Revert.
3868         * aarch32-linux-nat.c: Revert.
3869
3870 2019-04-05  Tom Tromey  <tom@tromey.com>
3871
3872         * ft32-tdep.c: Sort headers.
3873         * frv-tdep.c: Sort headers.
3874         * frv-linux-tdep.c: Sort headers.
3875         * frame.c: Sort headers.
3876         * frame-unwind.c: Sort headers.
3877         * frame-base.c: Sort headers.
3878         * fork-child.c: Sort headers.
3879         * findvar.c: Sort headers.
3880         * findcmd.c: Sort headers.
3881         * filesystem.c: Sort headers.
3882         * filename-seen-cache.h: Sort headers.
3883         * filename-seen-cache.c: Sort headers.
3884         * fbsd-tdep.c: Sort headers.
3885         * fbsd-nat.h: Sort headers.
3886         * fbsd-nat.c: Sort headers.
3887         * f-valprint.c: Sort headers.
3888         * f-typeprint.c: Sort headers.
3889         * f-lang.c: Sort headers.
3890         * extension.h: Sort headers.
3891         * extension.c: Sort headers.
3892         * extension-priv.h: Sort headers.
3893         * expprint.c: Sort headers.
3894         * exec.h: Sort headers.
3895         * exec.c: Sort headers.
3896         * exceptions.c: Sort headers.
3897         * event-top.c: Sort headers.
3898         * event-loop.c: Sort headers.
3899         * eval.c: Sort headers.
3900         * elfread.c: Sort headers.
3901         * dwarf2read.h: Sort headers.
3902         * dwarf2read.c: Sort headers.
3903         * dwarf2loc.c: Sort headers.
3904         * dwarf2expr.h: Sort headers.
3905         * dwarf2expr.c: Sort headers.
3906         * dwarf2-frame.c: Sort headers.
3907         * dwarf2-frame-tailcall.c: Sort headers.
3908         * dwarf-index-write.h: Sort headers.
3909         * dwarf-index-write.c: Sort headers.
3910         * dwarf-index-common.c: Sort headers.
3911         * dwarf-index-cache.h: Sort headers.
3912         * dwarf-index-cache.c: Sort headers.
3913         * dummy-frame.c: Sort headers.
3914         * dtrace-probe.c: Sort headers.
3915         * disasm.h: Sort headers.
3916         * disasm.c: Sort headers.
3917         * disasm-selftests.c: Sort headers.
3918         * dictionary.c: Sort headers.
3919         * dicos-tdep.c: Sort headers.
3920         * demangle.c: Sort headers.
3921         * dcache.h: Sort headers.
3922         * dcache.c: Sort headers.
3923         * darwin-nat.h: Sort headers.
3924         * darwin-nat.c: Sort headers.
3925         * darwin-nat-info.c: Sort headers.
3926         * d-valprint.c: Sort headers.
3927         * d-namespace.c: Sort headers.
3928         * d-lang.c: Sort headers.
3929         * ctf.c: Sort headers.
3930         * csky-tdep.c: Sort headers.
3931         * csky-linux-tdep.c: Sort headers.
3932         * cris-tdep.c: Sort headers.
3933         * cris-linux-tdep.c: Sort headers.
3934         * cp-valprint.c: Sort headers.
3935         * cp-support.c: Sort headers.
3936         * cp-namespace.c: Sort headers.
3937         * cp-abi.c: Sort headers.
3938         * corelow.c: Sort headers.
3939         * corefile.c: Sort headers.
3940         * continuations.c: Sort headers.
3941         * completer.h: Sort headers.
3942         * completer.c: Sort headers.
3943         * complaints.c: Sort headers.
3944         * coffread.c: Sort headers.
3945         * coff-pe-read.c: Sort headers.
3946         * cli-out.h: Sort headers.
3947         * cli-out.c: Sort headers.
3948         * charset.c: Sort headers.
3949         * c-varobj.c: Sort headers.
3950         * c-valprint.c: Sort headers.
3951         * c-typeprint.c: Sort headers.
3952         * c-lang.c: Sort headers.
3953         * buildsym.c: Sort headers.
3954         * buildsym-legacy.c: Sort headers.
3955         * build-id.h: Sort headers.
3956         * build-id.c: Sort headers.
3957         * btrace.c: Sort headers.
3958         * bsd-uthread.c: Sort headers.
3959         * breakpoint.h: Sort headers.
3960         * breakpoint.c: Sort headers.
3961         * break-catch-throw.c: Sort headers.
3962         * break-catch-syscall.c: Sort headers.
3963         * break-catch-sig.c: Sort headers.
3964         * blockframe.c: Sort headers.
3965         * block.c: Sort headers.
3966         * bfin-tdep.c: Sort headers.
3967         * bfin-linux-tdep.c: Sort headers.
3968         * bfd-target.c: Sort headers.
3969         * bcache.c: Sort headers.
3970         * ax-general.c: Sort headers.
3971         * ax-gdb.h: Sort headers.
3972         * ax-gdb.c: Sort headers.
3973         * avr-tdep.c: Sort headers.
3974         * auxv.c: Sort headers.
3975         * auto-load.c: Sort headers.
3976         * arm-wince-tdep.c: Sort headers.
3977         * arm-tdep.c: Sort headers.
3978         * arm-symbian-tdep.c: Sort headers.
3979         * arm-pikeos-tdep.c: Sort headers.
3980         * arm-obsd-tdep.c: Sort headers.
3981         * arm-nbsd-tdep.c: Sort headers.
3982         * arm-nbsd-nat.c: Sort headers.
3983         * arm-linux-tdep.c: Sort headers.
3984         * arm-linux-nat.c: Sort headers.
3985         * arm-fbsd-tdep.c: Sort headers.
3986         * arm-fbsd-nat.c: Sort headers.
3987         * arm-bsd-tdep.c: Sort headers.
3988         * arch-utils.c: Sort headers.
3989         * arc-tdep.c: Sort headers.
3990         * arc-newlib-tdep.c: Sort headers.
3991         * annotate.h: Sort headers.
3992         * annotate.c: Sort headers.
3993         * amd64-windows-tdep.c: Sort headers.
3994         * amd64-windows-nat.c: Sort headers.
3995         * amd64-tdep.c: Sort headers.
3996         * amd64-sol2-tdep.c: Sort headers.
3997         * amd64-obsd-tdep.c: Sort headers.
3998         * amd64-obsd-nat.c: Sort headers.
3999         * amd64-nbsd-tdep.c: Sort headers.
4000         * amd64-nbsd-nat.c: Sort headers.
4001         * amd64-nat.c: Sort headers.
4002         * amd64-linux-tdep.c: Sort headers.
4003         * amd64-linux-nat.c: Sort headers.
4004         * amd64-fbsd-tdep.c: Sort headers.
4005         * amd64-fbsd-nat.c: Sort headers.
4006         * amd64-dicos-tdep.c: Sort headers.
4007         * amd64-darwin-tdep.c: Sort headers.
4008         * amd64-bsd-nat.c: Sort headers.
4009         * alpha-tdep.c: Sort headers.
4010         * alpha-obsd-tdep.c: Sort headers.
4011         * alpha-nbsd-tdep.c: Sort headers.
4012         * alpha-mdebug-tdep.c: Sort headers.
4013         * alpha-linux-tdep.c: Sort headers.
4014         * alpha-linux-nat.c: Sort headers.
4015         * alpha-bsd-tdep.c: Sort headers.
4016         * alpha-bsd-nat.c: Sort headers.
4017         * aix-thread.c: Sort headers.
4018         * agent.c: Sort headers.
4019         * addrmap.c: Sort headers.
4020         * ada-varobj.c: Sort headers.
4021         * ada-valprint.c: Sort headers.
4022         * ada-typeprint.c: Sort headers.
4023         * ada-tasks.c: Sort headers.
4024         * ada-lang.c: Sort headers.
4025         * aarch64-tdep.c: Sort headers.
4026         * aarch64-ravenscar-thread.c: Sort headers.
4027         * aarch64-newlib-tdep.c: Sort headers.
4028         * aarch64-linux-tdep.c: Sort headers.
4029         * aarch64-linux-nat.c: Sort headers.
4030         * aarch64-fbsd-tdep.c: Sort headers.
4031         * aarch64-fbsd-nat.c: Sort headers.
4032         * aarch32-linux-nat.c: Sort headers.
4033
4034 2019-04-04  Tom Tromey  <tom@tromey.com>
4035
4036         * varobj.c (varobj_create): Update.
4037         * rust-exp.y (struct rust_parser) <update_innermost_block,
4038         lookup_symbol>: New methods.
4039         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4040         Rename.
4041         (rust_parser::rust_lookup_type)
4042         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4043         * printcmd.c (display_command, do_one_display): Update.
4044         * parser-defs.h (struct parser_state) <parser_state>: Add
4045         "tracker" parameter.
4046         (block_tracker): New member.
4047         (class innermost_block_tracker) <innermost_block_tracker>: Add
4048         "types" parameter.
4049         <reset>: Remove method.
4050         (innermost_block): Don't declare.
4051         (null_post_parser): Update.
4052         * parse.c (innermost_block): Remove global.
4053         (write_dollar_variable): Update.
4054         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4055         Remove "tracker_types" parameter.
4056         (parse_expression): Add "tracker" parameter.
4057         (parse_expression_for_completion): Update.
4058         (null_post_parser): Add "tracker" parameter.
4059         * p-exp.y: Update rules.
4060         * m2-exp.y: Update rules.
4061         * language.h (struct language_defn) <la_post_parser>: Add
4062         "tracker" parameter.
4063         * go-exp.y: Update rules.
4064         * f-exp.y: Update rules.
4065         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4066         parameter.
4067         * d-exp.y: Update rules.
4068         * c-exp.y: Update rules.
4069         * breakpoint.c (set_breakpoint_condition): Create an
4070         innermost_block_tracker.
4071         (watch_command_1): Likewise.
4072         * ada-lang.c (resolve): Add "tracker" parameter.
4073         (resolve_subexp): Likewise.
4074         * ada-exp.y (write_var_from_sym): Update.
4075
4076 2019-04-04  Tom Tromey  <tom@tromey.com>
4077
4078         * type-stack.h: New file.
4079         * type-stack.c: New file.
4080         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4081         type-stack.h.
4082         (insert_into_type_stack, insert_type, push_type, push_type_int)
4083         (insert_type_address_space, pop_type, pop_type_int)
4084         (pop_typelist, pop_type_stack, append_type_stack)
4085         (push_type_stack, get_type_stack, push_typelist)
4086         (follow_type_instance_flags, follow_types): Don't declare.
4087         * parse.c (type_stack): Remove global.
4088         (parse_exp_in_context): Update.
4089         (insert_into_type_stack, insert_type, push_type, push_type_int)
4090         (insert_type_address_space, pop_type, pop_type_int)
4091         (pop_typelist, pop_type_stack, append_type_stack)
4092         (push_type_stack, get_type_stack, push_typelist)
4093         (follow_type_instance_flags, follow_types): Remove (moved to
4094         type-stack.c).
4095         * f-exp.y (type_stack): New global.
4096         Update rules.
4097         (push_kind_type, f_parse): Update.
4098         * d-exp.y (type_stack): New global.
4099         Update rules.
4100         (d_parse): Update.
4101         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4102         Update rules.
4103         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4104         (HFILES_NO_SRCDIR): Add type-stack.h.
4105
4106 2019-04-04  Tom Tromey  <tom@tromey.com>
4107
4108         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4109         (rust_parser::convert_ast_to_expression, rust_parse)
4110         (rust_lex_test_completion, rust_lex_tests): Update.
4111         * parser-defs.h (struct expr_completion_state): New.
4112         (struct parser_state) <parser_state>: Add completion parameter.
4113         <mark_struct_expression, mark_completion_tag>: New methods.
4114         <parse_completion, m_completion_state>: New members.
4115         (prefixify_expression, null_post_parser): Update.
4116         (mark_struct_expression, mark_completion_tag): Don't declare.
4117         * parse.c (parse_completion, expout_last_struct)
4118         (expout_tag_completion_type, expout_completion_name): Remove
4119         globals.
4120         (parser_state::mark_struct_expression)
4121         (parser_state::mark_completion_tag): Now methods.
4122         (prefixify_expression): Add last_struct parameter.
4123         (prefixify_subexp): Likewise.
4124         (parse_exp_1): Update.
4125         (parse_exp_in_context): Add cstate parameter.  Update.
4126         (parse_expression_for_completion): Create an
4127         expr_completion_state.
4128         (null_post_parser): Add "completion" parameter.
4129         * p-exp.y: Update rules.
4130         (yylex): Update.
4131         * language.h (struct language_defn) <la_post_parser>: Add
4132         "completing" parameter.
4133         * go-exp.y: Update rules.
4134         (lex_one_token): Update.
4135         * expression.h (parse_completion): Don't declare.
4136         * d-exp.y: Update rules.
4137         (lex_one_token): Update rules.
4138         * c-exp.y: Update rules.
4139         (lex_one_token): Update.
4140         * ada-lang.c (resolve): Add "parse_completion" parameter.
4141         (resolve_subexp): Likewise.
4142         (ada_resolve_function): Likewise.
4143
4144 2019-04-04  Tom Tromey  <tom@tromey.com>
4145
4146         * parser-defs.h (struct parser_state) <start_arglist,
4147         end_arglist>: New methods.
4148         <arglist_len, m_funcall_chain>: New members.
4149         (arglist_len, start_arglist, end_arglist): Don't declare.
4150         * parse.c (arglist_len, funcall_chain): Remove global.
4151         (start_arglist, end_arglist): Remove functions.
4152         (parse_exp_in_context): Update.
4153         * p-exp.y: Update rules.
4154         * m2-exp.y: Update rules.
4155         * go-exp.y: Update rules.
4156         * f-exp.y: Update rules.
4157         * d-exp.y: Update rules.
4158         * c-exp.y: Update rules.
4159
4160 2019-04-04  Tom Tromey  <tom@tromey.com>
4161
4162         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4163         lex_operator, push_back>: New methods.
4164         Update all rules.
4165         (rust_parser::lex_hex, lex_escape): Rename and update.
4166         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4167         (rust_parser::lex_operator): Rename and update.
4168         (rust_parser::lex_number, rustyylex, rustyyerror)
4169         (rust_lex_test_init, rust_lex_test_sequence)
4170         (rust_lex_test_push_back, rust_lex_tests): Update.
4171         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4172         parameter.
4173         <lexptr, prev_lexptr>: New members.
4174         (lexptr, prev_lexptr): Don't declare.
4175         * parse.c (lexptr, prev_lexptr): Remove globals.
4176         (parse_exp_in_context): Update.
4177         * p-exp.y (yylex, yyerror): Update.
4178         * m2-exp.y (parse_number, yylex, yyerror): Update.
4179         * go-exp.y (lex_one_token, yyerror): Update.
4180         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4181         * d-exp.y (lex_one_token, yyerror): Update.
4182         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4183         (lex_one_token, yyerror): Update.
4184         * ada-lex.l (YY_INPUT): Update.
4185         (rewind_to_char): Update.
4186         * ada-exp.y (yyerror): Update.
4187
4188 2019-04-04  Tom Tromey  <tom@tromey.com>
4189
4190         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4191         * parser-defs.h (struct parser_state) <parser_state>: Add new
4192         parameter.
4193         <comma_terminates>: New member.
4194         (comma_terminates): Don't declare global.
4195         * parse.c (comma_terminates): Remove global.
4196         (parse_exp_in_context): Update.
4197         * p-exp.y (yylex): Update.
4198         * m2-exp.y (yylex): Update.
4199         * go-exp.y (lex_one_token): Update.
4200         * f-exp.y (yylex): Update.
4201         * d-exp.y (lex_one_token): Update.
4202         * c-exp.y (lex_one_token): Update.
4203         * ada-lex.l: Update.
4204
4205 2019-04-04  Tom Tromey  <tom@tromey.com>
4206
4207         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4208         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4209         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4210         * parser-defs.h (paren_depth): Don't declare.
4211         * parse.c (paren_depth): Remove global.
4212         (parse_exp_in_context): Update.
4213         * p-exp.y (paren_depth): New global.
4214         (pascal_parse): Initialize it.
4215         * m2-exp.y (paren_depth): New global.
4216         (m2_parse): Initialize it.
4217         * go-exp.y (paren_depth): New global.
4218         (go_parse): Initialize it.
4219         * f-exp.y (paren_depth): New global.
4220         (f_parse): Initialize it.
4221         * d-exp.y (paren_depth): New global.
4222         (d_parse): Initialize it.
4223         * c-exp.y (paren_depth): New global.
4224         (c_parse): Initialize it.
4225         * ada-lex.l (paren_depth): New global.
4226         (lexer_init): Initialize it.
4227
4228 2019-04-04  Tom Tromey  <tom@tromey.com>
4229
4230         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4231         (rust_parser::convert_ast_to_type)
4232         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4233         * parser-defs.h (struct parser_state) <parser_state>: Add
4234         parameters.  Initialize new members.
4235         <expression_context_block, expression_context_pc>: New members.
4236         * parse.c (expression_context_block, expression_context_pc):
4237         Remove globals.
4238         (parse_exp_in_context): Update.
4239         * p-exp.y: Update all rules.
4240         (yylex): Update.
4241         * m2-exp.y: Update all rules.
4242         (yylex): Update.
4243         * go-exp.y (yylex): Update.
4244         * f-exp.y (yylex): Update.
4245         * d-exp.y: Update all rules.
4246         (yylex): Update.
4247         * c-exp.y: Update all rules.
4248         (lex_one_token, classify_name, yylex, c_parse): Update.
4249         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4250
4251 2019-04-04  Tom Tromey  <tom@tromey.com>
4252
4253         * gdbarch.h, gdbarch.c: Rebuild.
4254         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4255         * stap-probe.h:
4256         (struct stap_parse_info): Replace "parser_state" with
4257         "expr_builder".
4258         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4259         (parser_state): New class.
4260         * parse.c (expr_builder): Rename.
4261         (expr_builder::release): Rename.
4262         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4263         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4264         (write_exp_elt_longcst, write_exp_elt_floatcst)
4265         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4266         (write_exp_string_vector, write_exp_bitstring)
4267         (write_exp_msymbol, mark_struct_expression)
4268         (write_dollar_variable)
4269         (insert_type_address_space, increase_expout_size): Replace
4270         "parser_state" with "expr_builder".
4271         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4272         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4273         "parser_state" with "expr_builder".
4274
4275 2019-04-04  Tom Tromey  <tom@tromey.com>
4276
4277         * rust-exp.y: Replace "parse_language" with method call.
4278         * p-exp.y:
4279         (yylex): Replace "parse_language" with method call.
4280         * m2-exp.y:
4281         (yylex): Replace "parse_language" with method call.
4282         * go-exp.y (classify_name): Replace "parse_language" with method
4283         call.
4284         * f-exp.y (yylex): Replace "parse_language" with method call.
4285         * d-exp.y (lex_one_token): Replace "parse_language" with method
4286         call.
4287         * c-exp.y:
4288         (lex_one_token, classify_name, yylex): Replace "parse_language"
4289         with method call.
4290         * ada-exp.y (find_primitive_type, type_char)
4291         (type_system_address): Replace "parse_language" with method call.
4292
4293 2019-04-04  Tom Tromey  <tom@tromey.com>
4294
4295         * rust-exp.y: Replace "parse_gdbarch" with method call.
4296         * parse.c (write_dollar_variable, insert_type_address_space):
4297         Replace "parse_gdbarch" with method call.
4298         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4299         call.
4300         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4301         call.
4302         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4303         "parse_gdbarch" with method call.
4304         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4305         with method call.
4306         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4307         "parse_gdbarch" with method call.
4308         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4309         "parse_gdbarch" with method call.
4310         * c-exp.y (parse_type, parse_number, classify_name): Replace
4311         "parse_gdbarch" with method call.
4312         * ada-lex.l: Replace "parse_gdbarch" with method call.
4313         * ada-exp.y (parse_type, find_primitive_type, type_char)
4314         (type_system_address): Replace "parse_gdbarch" with method call.
4315
4316 2019-04-04  Tom Tromey  <tom@tromey.com>
4317
4318         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4319         * stap-probe.c (stap_parse_argument): Update.
4320         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4321         initial_size parameter.
4322         * rust-exp.y (rust_lex_tests): Update.
4323         * parse.c (parser_state): Update.
4324         (parse_exp_in_context): Update.
4325         * parser-defs.h (struct parser_state) <parser_state>: Remove
4326         "initial_size" parameter.
4327
4328 2019-04-04  Tom Tromey  <tom@tromey.com>
4329
4330         * parser-defs.h (increase_expout_size): Don't declare.
4331         * parse.c (increase_expout_size): Now static.
4332
4333 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4334
4335         * gnu-nat.c (gnu_nat_target::wait): Fix
4336         target_waitstatus_to_string call.
4337
4338 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4339
4340         * eval.c (evaluate_subexp_standard): Handle internal functions
4341         during Fortran function call handling.
4342
4343 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4344
4345         * NEWS: Mention new internal functions.
4346         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4347         (read_base_type): Use dwarf2_init_complex_target_type.
4348         * value.c (creal_internal_fn): New function.
4349         (cimag_internal_fn): New function.
4350         (_initialize_values): Register new internal functions.
4351
4352 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4353
4354         * infrun.c (stop_all_threads): If debug_infrun, always
4355         trace the wait status after wait_one, using
4356         target_waitstatus_to_string and target_pid_to_str.
4357         (handle_inferior_event): Replace various trace of
4358         wait status kind by a single trace.
4359         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4360         wait status kind image by target_waitstatus_to_string.
4361         * target/waitstatus.c (target_waitstatus_to_string): Fix
4362         obsolete comment.
4363
4364 2019-04-01  Tom Tromey  <tromey@adacore.com>
4365
4366         PR symtab/23331:
4367         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4368
4369 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4370             Pedro Alves  <palves@redhat.com>
4371
4372         * top.c (quit_force): Call 'finalize_values'.
4373         * value.c (finalize_values): New function.
4374         * value.h (finalize_values): Declare.
4375
4376 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4377
4378         * NEWS: Announce $_gdb_major and $_gdb_minor.
4379
4380         * top.c (init_gdb_version_vars): New function.
4381         (gdb_init): Call init_gdb_version_vars.
4382
4383 2019-03-29  Tom Tromey  <tromey@adacore.com>
4384
4385         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4386         help text.  Remove dead code.
4387
4388 2019-03-29  Keith Seitz  <keiths@redhat.com>
4389
4390         From Siddhesh Poyarekar:
4391         * f-lang.h (f77_get_upperbound): Return LONGEST.
4392         (f77_get_lowerbound): Likewise.
4393         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4394         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4395         print them.
4396         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4397         plongest to format print it.
4398         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4399         (f77_get_upperbound): Likewise.
4400         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4401         LOWER_BOUND to LONGEST.
4402         (f77_create_arrayprint_offset_tbl): Likewise.
4403
4404 2019-03-29  Keith Seitz  <keiths@redhat.com>
4405
4406         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4407         %s/pulongest for TYPE_LENGTH instead of %d in format
4408         strings.
4409         * ada-typerint.c (ada_print_type): Likewise.
4410         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4411         * compile/compile-c-support.c (generate_register_struct): Likewise.
4412         * gdbtypes.c (recursive_dump_type): Likewise.
4413         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4414         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4415         instead of %d in format strings.
4416         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4417         to std::min to ULONGEST.
4418         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4419         instead of %d in format strings.
4420         * tracepoint.c (info_scope_command): Likewise.
4421         * typeprint.c (print_offset_data::update)
4422         (print_offset_data::finish): Likewise.
4423         * xtensa-tdep.c (xtensa_store_return_value)
4424         (xtensa_push_dummy_call): Likewise.
4425
4426 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4427
4428         * windows-nat.c (display_selector): Fixed format specifications
4429         for 64-bit Cygwin.
4430
4431 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4432
4433         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4434
4435 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4436
4437         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4438         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4439         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4440         (nios2_linux_init_abi): Install it.
4441
4442 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4443
4444         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4445
4446 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4447
4448         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4449
4450 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4451             Tom Tromey  <tromey@adacore.com>
4452
4453         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4454
4455 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4456
4457         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4458         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4459         method to compute the bounds of range types. Also print "[evaluated]"
4460         if the bounds' values come from a dynamic evaluation.
4461
4462 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4463
4464         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4465         whitespace when pretty printing is on.
4466
4467 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4468
4469         * ppc-linux-nat.c: Add include.
4470
4471 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4472
4473         * NEWS: Mention AArch64 Pointer Authentication.
4474
4475 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4476
4477         * arm-linux-nat.c: Add include.
4478
4479 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4480
4481         * source-cache.c (source_cache::get_source_lines): Re-read
4482         fullname after calling open_source_file.
4483
4484 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4485
4486         * NEWS: Mention TLS support for FreeBSD.
4487
4488 2019-03-25  Tom Tromey  <tromey@adacore.com>
4489
4490         * minsyms.c (BUNCH_SIZE): Update comment.
4491         (~minimal_symbol_reader): Remove old comment.
4492         (compact_minimal_symbols): Update comment.
4493         (minimal_symbol_reader::install): Remove old comment.  Update
4494         other comments.
4495
4496 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4497
4498         * s390-linux-nat.c: Add include.
4499
4500 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4501
4502         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4503         Call linux_get_hwcap.
4504         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4505         Likewise.
4506         (aarch64_linux_get_hwcap): Remove function.
4507         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4508         declaration.
4509         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4510         linux_get_hwcap.
4511         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4512         * linux-tdep.c (linux_get_hwcap): Add function.
4513         (linux_get_hwcap2): Likewise.
4514         * linux-tdep.h (linux_get_hwcap): Add declaration.
4515         (linux_get_hwcap2): Likewise.
4516         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4517         (ppc_linux_get_hwcap2): Likewise.
4518         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4519         linux_get_hwcap.
4520         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4521         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4522         (ppc_linux_nat_target::read_description): Likewise.
4523         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4524         * s390-linux-nat.c: Likewise.
4525         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4526
4527 2019-03-24  Tom Tromey  <tom@tromey.com>
4528
4529         * ada-lang.c (standard_lookup): Simplify initialization.
4530         (ada_lookup_symbol_nonlocal): Simplify return.
4531         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4532         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4533         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4534         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4535         initialization.
4536         * solib.c (solib_global_lookup): Simplify.
4537         * symtab.c (null_block_symbol): Remove.
4538         (symbol_cache_lookup): Simplify returns.
4539         (lookup_language_this): Simplify returns.
4540         (lookup_symbol_aux): Simplify return.
4541         (lookup_local_symbol): Simplify returns.
4542         (lookup_global_symbol_from_objfile): Simplify return.
4543         (lookup_symbol_in_objfile_symtabs)
4544         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4545         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4546         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4547         * cp-namespace.c (cp_lookup_bare_symbol)
4548         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4549         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4550         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4551         (cp_lookup_symbol_via_imports): Simplify initialization.
4552         (find_symbol_in_baseclass): Likewise.
4553         * symtab.h (null_block_symbol): Remove.
4554         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4555         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4556         (d_lookup_symbol_module): Likewise.
4557         (find_symbol_in_baseclass): Simplify initialization.
4558
4559 2019-03-24  Tom Tromey  <tom@tromey.com>
4560
4561         * expression.h: Don't include symtab.h.
4562         (struct block): Forward declare.
4563
4564 2019-03-24  Tom Tromey  <tom@tromey.com>
4565
4566         * c-exp.y (typebase): Remove casts.
4567         * gdbtypes.c (lookup_unsigned_typename, )
4568         (lookup_signed_typename): Remove cast.
4569         * eval.c (parse_to_comma_and_eval): Remove cast.
4570         * parse.c (write_dollar_variable): Remove cast.
4571         * block.h (struct block) <superblock>: Now const.
4572         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4573         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4574         (map_block): Make "block" const.
4575         * symfile.h (struct quick_symbol_functions)
4576         <map_matching_symbols>: Constify block argument to "callback".
4577         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4578         const.
4579         (find_pc_sect_compunit_symtab): Make "b" const.
4580         (find_symbol_at_address): Likewise.
4581         (search_symbols): Likewise.
4582         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4583         (dw2_debug_names_lookup_symbol): Likewise.
4584         (dw2_map_matching_symbols): Update.
4585         * p-valprint.c (pascal_val_print): Remove "block".
4586         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4587         (aux_add_nonlocal_symbols): Make "block" const.
4588         (resolve_subexp): Remove cast.
4589         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4590         const.
4591         (iterate_over_file_blocks): Likewise.
4592         * f-exp.y (%union) <bval>: Remove.
4593         * coffread.c (patch_opaque_types): Make "b" const.
4594         * spu-tdep.c (spu_catch_start): Make "block" const.
4595         * c-valprint.c (print_unpacked_pointer): Remove "block".
4596         * symmisc.c (dump_symtab_1): Make "b" const.
4597         (block_depth): Make "block" const.
4598         * d-exp.y (%union) <bval>: Remove.
4599         * cp-support.h (cp_lookup_rtti_type): Update.
4600         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4601         * psymtab.c (psym_lookup_symbol): Make "block" const.
4602         (maintenance_check_psymtabs): Make "b" const.
4603         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4604         (enumerate_locals, enumerate_args): Update.
4605         * python/py-symtab.c (stpy_global_block): Make "block" const.
4606         (stpy_static_block): Likewise.
4607         * inline-frame.c (block_starting_point_at): Make "new_block"
4608         const.
4609         * block.c (find_block_in_blockvector): Make return type const.
4610         (blockvector_for_pc_sect): Make "b" const.
4611         (find_block_in_blockvector): Make "b" const.
4612
4613 2019-03-23  Tom Tromey  <tom@tromey.com>
4614
4615         * varobj.c (varobj_create): Update.
4616         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4617         * printcmd.c (display_command, do_one_display): Don't reset
4618         innermost_block.
4619         * parser-defs.h (enum innermost_block_tracker_type): Move to
4620         expression.h.
4621         (innermost_block): Update comment.
4622         * parse.c (parse_exp_1): Add tracker_types parameter.
4623         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4624         tracker_types parameter.  Reset innermost_block.
4625         (parse_exp_in_context): Remove.
4626         (parse_expression_for_completion): Update.
4627         * objfiles.c (~objfile): Don't reset expression_context_block or
4628         innermost_block.
4629         * expression.h (enum innermost_block_tracker_type): Move from
4630         parser-defs.h.
4631         (parse_exp_1): Add tracker_types parameter.
4632         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4633         reset innermost_block.
4634
4635 2019-03-23  Tom Tromey  <tom@tromey.com>
4636
4637         * objfiles.h: Include bcache.h.
4638
4639 2019-03-23  Tom Tromey  <tom@tromey.com>
4640
4641         * linespec.c (get_current_search_block): Use
4642         scoped_restore_current_language.
4643         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4644
4645 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4646             Jiong Wang  <jiong.wang@arm.com>
4647
4648         * aarch64-linux-tdep.c
4649         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4650         section.
4651         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4652
4653 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4654             Jiong Wang  <jiong.wang@arm.com>
4655
4656         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4657         instructions.
4658         (aarch64_analyze_prologue_test): Add PACIASP test.
4659         (aarch64_prologue_prev_register): Unmask PC value.
4660
4661 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4662             Jiong Wang  <jiong.wang@arm.com>
4663
4664         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4665         (aarch64_dwarf2_prev_register): Unmask PC value.
4666         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4667         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4668         DW_CFA_AARCH64_negate_ra_state.
4669         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4670
4671 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4672             Jiong Wang  <jiong.wang@arm.com>
4673
4674         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4675         registers.
4676         (aarch64_pseudo_register_name): Likewise.
4677         (aarch64_pseudo_register_type): Likewise.
4678         (aarch64_pseudo_register_reggroup_p): Likewise.
4679         (aarch64_gdbarch_init): Add pauth registers.
4680         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4681         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4682         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4683         (struct gdbarch_tdep): Add regnum for ra_state.
4684
4685 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4686             Jiong Wang  <jiong.wang@arm.com>
4687
4688         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4689
4690 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4691             Jiong Wang  <jiong.wang@arm.com>
4692
4693         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4694         function.
4695         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4696         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4697         (aarch64_gdbarch_init): Add puth registers.
4698         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4699         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4700         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4701
4702 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4703             Jiong Wang  <jiong.wang@arm.com>
4704
4705         * aarch64-linux-nat.c
4706         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4707         * aarch64-linux-tdep.c
4708         (aarch64_linux_core_read_description): Likewise.
4709         (aarch64_linux_get_hwcap): New function.
4710         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4711         (aarch64_linux_get_hwcap): New declaration.
4712
4713 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4714             Jiong Wang  <jiong.wang@arm.com>
4715
4716         * aarch64-linux-nat.c
4717         (aarch64_linux_nat_target::read_description): Add pauth param.
4718         * aarch64-linux-tdep.c
4719         (aarch64_linux_core_read_description): Likewise.
4720         * aarch64-tdep.c (struct target_desc): Add in pauth.
4721         (aarch64_read_description): Add pauth param.
4722         (aarch64_gdbarch_init): Likewise.
4723         * aarch64-tdep.h (aarch64_read_description): Likewise.
4724         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4725         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4726         * features/Makefile: Add new files.
4727         * features/aarch64-pauth.c: New file.
4728         * features/aarch64-pauth.xml: New file.
4729
4730 2019-03-20  Tom Tromey  <tromey@adacore.com>
4731
4732         * infrun.c (handle_inferior_event): Rename from
4733         handle_inferior_event_1.  Create a scoped_value_mark.
4734         (handle_inferior_event): Remove.
4735
4736 2019-03-19  Tom Tromey  <tromey@adacore.com>
4737
4738         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4739         * infrun.h (print_stop_event): Add "displays" parameter.
4740         * infrun.c (print_stop_event): Add "displays" parameter.
4741
4742 2019-03-19  Pedro Alves  <palves@redhat.com>
4743
4744         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4745         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4746         to -1.  Fix TABs vs spaces.
4747         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4748         * tui/tui-out.h (tui_ui_out) Add intro comments.
4749         <m_line, m_start_of_line>: In-class initialize, and add describing
4750         comment.
4751
4752 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4753
4754         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4755         variable names.
4756         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4757
4758 2019-03-18  Pedro Alves  <palves@redhat.com>
4759             Eli Zaretskii <eliz@gnu.org>
4760
4761         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4762         m_line and m_start_of_line.
4763
4764 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4765
4766         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4767         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4768         it returns a newline.  This fixes a regression in TU mode, whereby
4769         the next line is output on the same screen line as the user input.
4770
4771 2019-03-18  Tom Tromey  <tromey@adacore.com>
4772
4773         * minsyms.c (minimal_symbol_reader::install): Remove call to
4774         obstack_blank.
4775
4776 2019-03-18  Pedro Alves  <palves@redhat.com>
4777
4778         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4779         New globals.
4780         (apply_style): New, factored out from ...
4781         (apply_ansi_escape): ... this.  Handle reverse video mode.
4782         (tui_set_reverse_mode): New function.
4783         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4784         * tui/tui-winsource.c (tui_show_source_line): Use
4785         tui_set_reverse_mode instead of setting A_STANDOUT.
4786         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4787         New setter methods.
4788
4789 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4790
4791         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4792         Handle tabs.
4793
4794 2019-03-18  Tom Tromey  <tromey@adacore.com>
4795
4796         * ada-lang.c (empty_array): Add "high" parameter.
4797         (ada_evaluate_subexp): Update.
4798
4799 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4800
4801         * unittests/string_view-selftests.c: Define
4802         _initialize_string_view_selftests unconditionally.
4803
4804 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4805
4806         PR gdb/24350
4807         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4808
4809 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4810
4811         PR gdb/24351
4812         * windows-nat.c (display_selector): Fix format specifiers.
4813
4814 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4815
4816         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4817         tui_refill_source_window instead of tui_refresh_win, to update the
4818         current execution line.  This fixes redisplay of the current line
4819         when stepping through the code with "next" or "step".
4820
4821 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4822
4823         * source-cache.c (source_cache::get_source_lines): Call
4824         find_source_lines to initialize s->nlines.  This fixes vertical
4825         scrolling of TUI source window when the DOWN arrow is pressed.
4826
4827 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4828
4829         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4830         linux-thread-db.c (_initialize_thread_db): Likewise.
4831
4832 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4833
4834         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4835         wclrtoeol in tui_show_source_line".  This reverts changes made in
4836         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4837
4838 2019-03-15  Tom Tromey  <tom@tromey.com>
4839
4840         * symtab.h (struct minimal_symbol): Derive from
4841         general_symbol_info.
4842         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4843         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4844         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4845         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4846         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4847         (MSYMBOL_SEARCH_NAME): Update.
4848         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4849         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4850         * minsyms.c (minimal_symbol_reader::record_full): Update.
4851
4852 2019-03-15  Tom Tromey  <tom@tromey.com>
4853
4854         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4855
4856 2019-03-15  Tom Tromey  <tom@tromey.com>
4857
4858         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4859         unique_xmalloc_ptr.
4860         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4861         Update.
4862         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4863         (build_minimal_symbol_hash_tables)
4864         (minimal_symbol_reader::install): Update.
4865
4866 2019-03-15  Tom Tromey  <tom@tromey.com>
4867
4868         * symtab.c (create_demangled_names_hash): Update.
4869         (symbol_set_names): Update.
4870         * objfiles.h (struct objfile_per_bfd_storage)
4871         <demangled_names_hash>: Now an htab_up.
4872         * objfiles.c (objfile_per_bfd_storage): Simplify.
4873
4874 2019-03-15  Tom Tromey  <tom@tromey.com>
4875
4876         * objfiles.h (struct objfile_per_bfd_storage): Declare
4877         destructor.
4878         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4879         New.
4880         (get_objfile_bfd_data): Use new.  Don't initialize
4881         language_of_main.
4882         (free_objfile_per_bfd_storage): Remove.
4883         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4884
4885 2019-03-15  Tom Tromey  <tom@tromey.com>
4886
4887         * symfile.c (reread_symbols): Update.
4888         * objfiles.c (objfile::objfile): Update.
4889         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4890         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4891         comment.
4892         (minimal_symbol_reader::install): Update.
4893         (terminate_minimal_symbol_table): Remove.
4894         * jit.c (jit_object_close_impl): Update.
4895
4896 2019-03-15  Tom Tromey  <tom@tromey.com>
4897
4898         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4899         initializations.
4900
4901 2019-03-15  Tom Tromey  <tom@tromey.com>
4902
4903         * objfiles.h (struct objfile_per_bfd_storage)
4904         <demangled_hash_languages>: Now a bitset.
4905         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4906         (lookup_minimal_symbol): Update.
4907
4908 2019-03-15  Tom Tromey  <tom@tromey.com>
4909
4910         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4911         Don't return the symbol.
4912         * coffread.c (record_minimal_symbol): Use record_full.
4913
4914 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4915
4916         The MS-Windows port of ncurses fails to switch to a color pair if
4917         one or both of the colors are the implicit default colors.  This
4918         change records the default colors when TUI is initialized, and
4919         then specifies them explicitly when a color pair uses the default
4920         colors.  This allows color styling in TUI mode on MS-Windows.
4921
4922         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4923         ncurses_norm_attr.
4924         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4925         colors in ncurses_norm_attr.
4926         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4927         "none", replace it with the default color recorded in
4928         ncurses_norm_attr.
4929
4930 2019-03-14  Tom Tromey  <tromey@adacore.com>
4931
4932         * source-cache.h (class source_cache) <get_source_lines>: Return
4933         std::string.
4934         * source-cache.c (source_cache::extract_lines): Handle case where
4935         first_pos==npos.  Return std::string.
4936         (source_cache::get_source_lines): Update.
4937
4938 2019-03-14  Tom Tromey  <tromey@adacore.com>
4939
4940         * NEWS: Add item for "style sources" commands.
4941         * source-cache.c (source_cache::get_source_lines): Check
4942         source_styling.
4943         * cli/cli-style.c (source_styling): New global.
4944         (_initialize_cli_style): Add "style sources" commands.
4945         (show_style_sources): New function.
4946         * cli/cli-style.h (source_styling): Declare.
4947
4948 2019-03-14  Pedro Alves  <palves@redhat.com>
4949             Tom Tromey  <tromey@adacore.com>
4950
4951         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4952         * tui/tui-winsource.c (tui_refill_source_window): New function,
4953         from...
4954         (tui_horizontal_source_scroll): ... here.  Move some logic.
4955         * cli/cli-style.c (set_style_enabled): Notify new observable.
4956         * tui/tui-hooks.c (tui_redisplay_source): New function.
4957         (tui_attach_detach_observers): Attach or detach
4958         tui_redisplay_source.
4959         * observable.h (source_styling_changed): New observable.
4960         * observable.c: Define source_styling_changed observable.
4961
4962 2019-03-13  Tom Tromey  <tromey@adacore.com>
4963
4964         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4965         (i386_gnu_nat_target::store_registers): Update.
4966         * target-debug.h (target_debug_print_std_string): New macro.
4967         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4968         * windows-tdep.c (display_one_tib): Update.
4969         * tui/tui-stack.c (tui_make_status_line): Update.
4970         * top.c (print_inferior_quit_action): Update.
4971         * thread.c (thr_try_catch_cmd): Update.
4972         (add_thread_with_info): Update.
4973         (thread_target_id_str): Update.
4974         (thr_try_catch_cmd): Update.
4975         (thread_command): Update.
4976         (thread_find_command): Update.
4977         * record-btrace.c (record_btrace_target::info_record)
4978         (record_btrace_resume_thread, record_btrace_target::resume)
4979         (record_btrace_cancel_resume, record_btrace_step_thread)
4980         (record_btrace_target::wait, record_btrace_target::wait)
4981         (record_btrace_target::wait, record_btrace_target::stop): Update.
4982         * progspace.c (print_program_space): Update.
4983         * process-stratum-target.c
4984         (process_stratum_target::thread_address_space): Update.
4985         * linux-fork.c (linux_fork_mourn_inferior)
4986         (detach_checkpoint_command, info_checkpoints_command)
4987         (linux_fork_context): Update.
4988         (linux_fork_detach): Update.
4989         (class scoped_switch_fork_info): Update.
4990         (delete_checkpoint_command): Update.
4991         * infrun.c (follow_fork_inferior): Update.
4992         (follow_fork_inferior): Update.
4993         (proceed_after_vfork_done): Update.
4994         (handle_vfork_child_exec_or_exit): Update.
4995         (follow_exec): Update.
4996         (displaced_step_prepare_throw): Update.
4997         (displaced_step_restore): Update.
4998         (start_step_over): Update.
4999         (resume_1): Update.
5000         (clear_proceed_status_thread): Update.
5001         (proceed): Update.
5002         (print_target_wait_results): Update.
5003         (do_target_wait): Update.
5004         (context_switch): Update.
5005         (stop_all_threads): Update.
5006         (restart_threads): Update.
5007         (finish_step_over): Update.
5008         (handle_signal_stop): Update.
5009         (switch_back_to_stepped_thread): Update.
5010         (keep_going_pass_signal): Update.
5011         (print_exited_reason): Update.
5012         (normal_stop): Update.
5013         * inferior.c (inferior_pid_to_str): Change return type.
5014         (print_selected_inferior): Update.
5015         (add_inferior): Update.
5016         (detach_inferior): Update.
5017         * dummy-frame.c (fprint_dummy_frames): Update.
5018         * dcache.c (dcache_info_1): Update.
5019         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5020         (btrace_fetch, btrace_clear): Update.
5021         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5022         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5023         type.
5024         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5025         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5026         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5027         * gdbarch.c, gdbarch.h: Rebuild.
5028         * gdbarch.sh (core_pid_to_str): Change return type.
5029         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5030         return type.
5031         (windows_nat_target::pid_to_str): Change return type.
5032         (windows_delete_thread): Update.
5033         (windows_nat_target::attach): Update.
5034         (windows_nat_target::files_info): Update.
5035         * target-delegates.c: Rebuild.
5036         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5037         return type.
5038         (sol_thread_target::pid_to_str): Change return type.
5039         * remote.c (class remote_target) <pid_to_str>: Change return
5040         type.
5041         (remote_target::pid_to_str): Change return type.
5042         (extended_remote_target::attach, remote_target::remote_stop_ns)
5043         (remote_target::remote_notif_remove_queued_reply)
5044         (remote_target::push_stop_reply, remote_target::disable_btrace):
5045         Update.
5046         (extended_remote_target::attach): Update.
5047         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5048         type.
5049         (gdbsim_target::pid_to_str): Change return type.
5050         * ravenscar-thread.c (struct ravenscar_thread_target)
5051         <pid_to_str>: Change return type.
5052         (ravenscar_thread_target::pid_to_str): Change return type.
5053         * procfs.c (class procfs_target) <pid_to_str>: Change return
5054         type.
5055         (procfs_target::pid_to_str): Change return type.
5056         (procfs_target::attach): Update.
5057         (procfs_target::detach): Update.
5058         (procfs_target::fetch_registers): Update.
5059         (procfs_target::store_registers): Update.
5060         (procfs_target::wait): Update.
5061         (procfs_target::files_info): Update.
5062         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5063         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5064         return type.
5065         (nto_procfs_target::pid_to_str): Change return type.
5066         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5067         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5068         return type.
5069         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5070         (exit_lwp): Update.
5071         (attach_proc_task_lwp_callback, get_detach_signal)
5072         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5073         (linux_nat_target::resume, wait_lwp, stop_callback)
5074         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5075         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5076         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5077         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5078         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5079         type.
5080         (inf_ptrace_target::attach): Update.
5081         (inf_ptrace_target::files_info): Update.
5082         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5083         type.
5084         (go32_nat_target::pid_to_str): Change return type.
5085         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5086         (gnu_nat_target::wait): Update.
5087         (gnu_nat_target::wait): Update.
5088         (gnu_nat_target::resume): Update.
5089         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5090         (fbsd_nat_target::wait): Update.
5091         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5092         type.
5093         (darwin_nat_target::attach): Update.
5094         * corelow.c (class core_target) <pid_to_str>: Change return type.
5095         (core_target::pid_to_str): Change return type.
5096         * target.c (normal_pid_to_str): Change return type.
5097         (default_pid_to_str): Likewise.
5098         (target_pid_to_str): Change return type.
5099         (target_translate_tls_address): Update.
5100         (target_announce_detach): Update.
5101         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5102         return type.
5103         (bsd_uthread_target::pid_to_str): Change return type.
5104         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5105         type.
5106         (bsd_kvm_target::pid_to_str): Change return type.
5107         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5108         return type.
5109         (aix_thread_target::pid_to_str): Change return type.
5110         * target.h (struct target_ops) <pid_to_str>: Change return type.
5111         (target_pid_to_str, normal_pid_to_str): Likewise.
5112         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5113         type.
5114         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5115         type.
5116         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5117         return type.
5118         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5119         type.
5120         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5121         type.
5122         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5123         return type.
5124
5125 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5126
5127         * NEWS: Mention that the new default MI version is 3.  Mention
5128         changes to the output of commands and events that deal with
5129         multi-location breakpoints.
5130         * breakpoint.c: Include "mi/mi-out.h".
5131         (print_one_breakpoint): Change output syntax if using MI version
5132         >= 3.
5133         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5134         New.
5135         (mi_multi_location_breakpoint_output_fixed): New.
5136         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5137         (mi_cmd_fix_multi_location_breakpoint_output): New.
5138         (mi_multi_location_breakpoint_output_fixed): New.
5139         * mi/mi-cmds.c (mi_cmds): Register command
5140         -fix-multi-location-breakpoint-output.
5141         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5142         interpreter "mi".
5143
5144 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5145
5146         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5147         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5148         instantiate mi_ui_out based on interpreter name.
5149         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5150         * mi/mi-main.c (mi_load_progress): Likewise.
5151
5152 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5153
5154         * NEWS: Combine separate "New targets" sections for 8.3.
5155
5156 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5157
5158         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5159         (ppcfbsd_init_abi): Install gdbarch
5160         "fetch_tls_load_module_address" and "get_thread_local_address"
5161         methods.
5162
5163 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5164
5165         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5166         (riscv_fbsd_init_abi): Install gdbarch
5167         "fetch_tls_load_module_address" and "get_thread_local_address"
5168         methods.
5169
5170 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5171
5172         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5173         (i386fbsd_init_abi): Install gdbarch
5174         "fetch_tls_load_module_address" and "get_thread_local_address"
5175         methods.
5176
5177 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5178
5179         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5180         (amd64fbsd_init_abi): Install gdbarch
5181         "fetch_tls_load_module_address" and "get_thread_local_address"
5182         methods.
5183
5184 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5185
5186         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5187         (struct fbsd_pspace_data): New type.
5188         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5189         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5190         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5191         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5192         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5193
5194 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5195
5196         * gdbtypes.c (lookup_struct_elt): New function.
5197         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5198         * gdbtypes.h (struct struct_elt): New type.
5199         (lookup_struct_elt): New prototype.
5200
5201 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5202
5203         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5204         remove disabled code block.
5205
5206 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5207
5208         * gdbarch.sh (get_thread_local_address): New method.
5209         * gdbarch.h, gdbarch.c: Regenerate.
5210         * target.c (target_translate_tls_address): Use
5211         gdbarch_get_thread_local_address if present instead of
5212         target::get_thread_local_address.
5213
5214 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5215
5216         * target.h (target::get_thread_local_address): Update comment.
5217
5218 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5219
5220         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5221         objfile->separate_debug_objfile_backlink if not NULL.
5222
5223 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5224
5225         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5226         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5227         (amd64bsd_store_inferior_registers): Likewise.
5228         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5229         Enable segment base registers.
5230         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5231         PT_GETFSBASE and PT_GETGSBASE.
5232         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5233         PT_SETGSBASE.
5234         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5235         segment base registers.
5236         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5237
5238 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5239
5240         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5241         Update calls to i386_target_description to add 'segments'
5242         parameter.
5243         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5244         add segment base registers.
5245         * arch/i386.c (i386_create_target_description): Add 'segments'
5246         parameter to enable segment base registers.
5247         * arch/i386.h (i386_create_target_description): Likewise.
5248         * features/i386/32bit-segments.xml: New file.
5249         * features/i386/32bit-segments.c: Generate.
5250         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5251         call to i386_target_description to add 'segments' parameter.
5252         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5253         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5254         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5255         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5256         if feature is present.
5257         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5258         Add 'segments' parameter to call to i386_target_description.
5259         (i386_target_description): Add 'segments' parameter to enable
5260         segment base registers.
5261         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5262         to call to i386_target_description.
5263         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5264         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5265         Define I386_NUM_REGS.
5266         (i386_target_description): Add 'segments' parameter to enable
5267         segment base registers.
5268
5269 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5270
5271         PR/24325
5272         * source-cache.c: #undef open and close, to avoid unresolved
5273         externals during linking.
5274
5275 2019-03-12  Tom Tromey  <tromey@adacore.com>
5276
5277         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5278         const.  Add initializers.
5279         (_initialize_remote): Don't initialize ptid globals.
5280
5281 2019-03-12  Pedro Alves  <palves@redhat.com>
5282
5283         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5284
5285 2019-03-12  Pedro Alves  <palves@redhat.com>
5286
5287         * cp-name-parser.y (main): Remove unused 'len' variable.
5288
5289 2019-03-12  Tom Tromey  <tromey@adacore.com>
5290
5291         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5292         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5293
5294 2019-03-12  Tom Tromey  <tromey@adacore.com>
5295
5296         * linux-nat.c (iterate_over_lwps): Update.
5297         (stop_callback): Remove parameter.
5298         (stop_wait_callback, detach_callback, resume_set_callback)
5299         (select_singlestep_lwp_callback, set_ignore_sigint)
5300         (status_callback, resumed_callback, resume_clear_callback)
5301         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5302         data parameter.
5303         (linux_nat_target::detach, linux_nat_target::resume)
5304         (linux_stop_and_wait_all_lwps, select_event_lwp)
5305         (linux_nat_filter_event, linux_nat_wait_1)
5306         (linux_nat_target::kill, linux_nat_target::stop)
5307         (linux_nat_target::stop): Update.
5308         (linux_nat_resume_callback): Change type.
5309         (resume_stopped_resumed_lwps, count_events_callback)
5310         (select_event_lwp_callback): Likewise.
5311         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5312         * arm-linux-nat.c (struct update_registers_data): Remove.
5313         (update_registers_callback): Change type.
5314         (arm_linux_insert_hw_breakpoint1): Update.
5315         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5316         parameter.
5317         (x86_linux_dr_set_addr): Update.
5318         (x86_linux_dr_set_control): Update.
5319         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5320         (iterate_over_lwps): Use gdb::function_view.
5321         * nat/aarch64-linux-hw-point.c (struct
5322         aarch64_dr_update_callback_param): Remove.
5323         (debug_reg_change_callback): Change type.
5324         (aarch64_notify_debug_reg_change): Update.
5325         * s390-linux-nat.c (s390_refresh_per_info): Update.
5326
5327 2019-03-11  Tom Tromey  <tromey@adacore.com>
5328
5329         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5330         redundant assignment to "this_cu".
5331
5332 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5333
5334         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5335
5336 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5337
5338         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5339         from...
5340         (rank_one_type): ... this.
5341
5342 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5343
5344         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5345         from...
5346         (rank_one_type): ... this.
5347
5348 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5349
5350         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5351         from...
5352         (rank_one_type): ... this.
5353
5354 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5355
5356         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5357         from...
5358         (rank_one_type): ... this.
5359
5360 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5361
5362         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5363         from...
5364         (rank_one_type): ... this.
5365
5366 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5367
5368         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5369         from...
5370         (rank_one_type): ... this.
5371
5372 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5373
5374         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5375         from...
5376         (rank_one_type): ... this.
5377
5378 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5379
5380         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5381         from...
5382         (rank_one_type): ... this.
5383
5384 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5385
5386         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5387         from...
5388         (rank_one_type): ... this.
5389
5390 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5391
5392         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5393         from...
5394         (rank_one_type): ... this.
5395
5396 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5397
5398         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5399         from...
5400         (rank_one_type): ... this.
5401
5402 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5403
5404         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5405         from...
5406         (rank_one_type): ... this.
5407
5408 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5409
5410         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5411         inferior-events' shows the example events.
5412
5413 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5414
5415         Support styling on native MS-Windows console
5416
5417         PR/24315
5418         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5419         on MS-Windows if $TERM is not defined.
5420
5421         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5422
5423         * posix-hdep.c (gdb_console_fputs):
5424         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5425         functions.
5426         * ui-file.h (gdb_console_fputs): Add prototype.
5427
5428         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5429         back to fputs only if the former returns zero.
5430
5431 2019-03-07  Tom Tromey  <tom@tromey.com>
5432
5433         * symmisc.c (print_symbol_bcache_statistics): Update.
5434         (print_objfile_statistics): Update.
5435         * symfile.c (allocate_symtab): Update.
5436         * stabsread.c: Don't include bcache.h.
5437         * psymtab.h (struct psymbol_bcache): Don't declare.
5438         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5439         (psymbol_bcache_init, psymbol_bcache_free)
5440         (psymbol_bcache_get_bcache): Don't declare.
5441         * psymtab.c (struct psymbol_bcache): Remove.
5442         (psymtab_storage::psymtab_storage): Update.
5443         (psymtab_storage::~psymtab_storage): Update.
5444         (psymbol_bcache_init, psymbol_bcache_free)
5445         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5446         (add_psymbol_to_bcache): Update.
5447         (allocate_psymtab): Update.
5448         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5449         macro_cache>: No longer pointers.
5450         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5451         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5452         * macrotab.c (macro_bcache): Update.
5453         * macroexp.c: Don't include bcache.h.
5454         * gdbtypes.c (check_types_worklist): Update.
5455         (types_deeply_equal): Remove TRY/CATCH.  Update.
5456         * elfread.c (elf_symtab_read): Update.
5457         * dwarf2read.c: Don't include bcache.h.
5458         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5459         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5460         (print_bcache_statistics, bcache_memory_used): Don't declare.
5461         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5462         methods.  Rename all data members.
5463         * bcache.c (struct bcache): Move to bcache.h.
5464         (bcache::expand_hash_table): Rename from expand_hash_table.
5465         (bcache): Remove.
5466         (bcache::insert): Rename from bcache_full.
5467         (bcache::compare): Rename from bcache_compare.
5468         (bcache_xmalloc): Remove.
5469         (bcache::~bcache): Rename from bcache_xfree.
5470         (bcache::print_statistics): Rename from print_bcache_statistics.
5471         (bcache::memory_used): Rename from bcache_memory_used.
5472
5473 2019-03-07  Pedro Alves  <palves@redhat.com>
5474
5475         * infrun.c (normal_stop): Also check for
5476         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5477
5478 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5479
5480         * f-lang.c (value_from_host_double): Moved to...
5481         * value.c (value_from_host_double): ...here.
5482         * value.h (value_from_host_double): Declare.
5483         * guile/scm-math.c (vlscm_convert_typed_number): Use
5484         value_from_host_double.
5485         (vlscm_convert_number): Likewise.
5486         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5487         * python/py-value.c (convert_value_from_python): Likewise.
5488
5489 2019-03-06  Tom Tromey  <tom@tromey.com>
5490
5491         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5492
5493 2019-03-06  Tom Tromey  <tom@tromey.com>
5494
5495         * utils.h (free_current_contents): Don't declare.
5496         * utils.c (free_current_contents): Remove.
5497
5498 2019-03-06  Tom Tromey  <tom@tromey.com>
5499
5500         * top.c (quit_force): Update.
5501         * main.c (captured_command_loop): Update.
5502         * common/new-op.c (operator new): Update.
5503         * common/common-exceptions.c (struct catcher)
5504         <save_cleanup_chain>: Remove member.
5505         (exceptions_state_mc_init): Update.
5506         (exception_try_scope_entry): Return nullptr.
5507         (exception_try_scope_exit, exception_rethrow)
5508         (throw_exception_sjlj, throw_exception_cxx): Update.
5509         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5510         (all_cleanups, do_cleanups, discard_cleanups)
5511         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5512         (restore_cleanups, restore_final_cleanups): Don't declare.
5513         (do_final_cleanups): Remove parameter.
5514         * common/cleanups.c (cleanup_chain, make_cleanup)
5515         (make_cleanup_dtor, all_cleanups, do_cleanups)
5516         (discard_my_cleanups, discard_cleanups)
5517         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5518         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5519         (null_cleanup): Remove.
5520         (do_final_cleanups): Remove parameter.
5521
5522 2019-03-06  Tom Tromey  <tom@tromey.com>
5523
5524         * remote.c (remote_target::remote_parse_stop_reply): Use
5525         unique_xmalloc_ptr.
5526
5527 2019-03-06  Tom Tromey  <tom@tromey.com>
5528
5529         * stabsread.c (struct stabs_field_info): Rename from field_info.
5530         <list, fnlist>: Add initializers.
5531         <obstack>: New member.
5532         (read_member_functions, read_struct_fields, read_baseclasses):
5533         Allocate on obstack.  Don't use cleanups.
5534         (read_one_struct_field, read_member_functions, read_struct_fields)
5535         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5536         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5537         (read_struct_type): Update.
5538
5539 2019-03-06  Tom Tromey  <tom@tromey.com>
5540
5541         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5542         * common/filestuff.h (make_cleanup_close): Don't declare.
5543         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5544         Remove.
5545
5546 2019-03-06  Tom Tromey  <tom@tromey.com>
5547
5548         * solib-aix.c: Use make_scope_exit.
5549
5550 2019-03-06  Tom Tromey  <tom@tromey.com>
5551
5552         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5553         Use make_scope_exit.
5554
5555 2019-03-06  Tom Tromey  <tom@tromey.com>
5556
5557         * solib-svr4.c (disable_probes_interface): Remove parameter.
5558         (svr4_handle_solib_event): Use make_scope_exit.
5559
5560 2019-03-06  Tom Tromey  <tom@tromey.com>
5561
5562         * remote.c (struct stop_reply_deleter): Remove.
5563         (stop_reply_up): Update.
5564         (struct stop_reply): Derive from notif_event.  Don't typedef.
5565         <regcache>: Now a std::vector.
5566         (stop_reply_xfree): Remove.
5567         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5568         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5569         (remote_target::discard_pending_stop_replies): Use delete.
5570         (remote_target::remote_parse_stop_reply): Update.
5571         (remote_target::process_stop_reply): Update.
5572         * remote-notif.h (struct notif_event): Add virtual destructor.
5573         Remove "dtr" member.
5574         (struct notif_client) <alloc_event>: Return a unique_ptr.
5575         (notif_event_xfree): Don't declare.
5576         (notif_event_up): New typedef.
5577         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5578         (notif_event_xfree, do_notif_event_xfree): Remove.
5579         (remote_notif_state_xfree): Update.
5580
5581 2019-03-06  Tom Tromey  <tom@tromey.com>
5582
5583         * infrun.c (displaced_step_clear_cleanup): Now a
5584         forward_scope_exit type.
5585         (displaced_step_prepare_throw): Update.
5586         (displaced_step_fixup): Update.
5587
5588 2019-03-06  Tom Tromey  <tom@tromey.com>
5589
5590         * inferior.h (class inferior): Update comment.
5591         * gdbthread.h (class thread_info): Update comment.
5592
5593 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5594             Tom Tromey  <tom@tromey.com>
5595
5596         * stabsread.h (struct stab_section_list): Remove.
5597         (coffstab_build_psymtabs): Update.
5598         * dbxread.c (symbuf_sections): Now a std::vector.
5599         (sect_idx): New global.
5600         (fill_symbuf): Update.
5601         (coffstab_build_psymtabs): Change type of stabsects parameter.
5602         Update.
5603         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5604         std::vector.
5605         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5606         (coff_locate_sections): Update.
5607         (coff_symfile_read): Remove cleanups.  Update.
5608         (init_stringtab): Add storage parameter.
5609         (free_stringtab, free_stringtab_cleanup): Remove.
5610         (init_lineno): Add storage parameter.
5611         (free_linetab, free_linetab_cleanup): Remove.
5612
5613 2019-03-06  Pedro Alves  <palves@redhat.com>
5614
5615         * linux-fork.c (fork_info::clobber_regs): Delete.
5616         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5617         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5618         comment.  Adjust.
5619         (scoped_switch_fork_info::scoped_switch_fork_info)
5620         (checkpoint_command, linux_fork_context): Adjust
5621         fork_save_infrun_state calls.
5622
5623 2019-03-06  Pedro Alves  <palves@redhat.com>
5624
5625         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5626         (inf_has_multiple_threads): Return 'bool' and rewrite using
5627         inferior_info::threads().
5628
5629 2019-03-06  Pedro Alves  <palves@redhat.com>
5630
5631         * linux-fork.c: Include <list>.
5632         (fork_list): Now a std::list instance.
5633         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5634         (forks_exist_p, find_last_fork): Adjust.
5635         (new_fork): Delete.
5636         (one_fork_p): New.
5637         (add_fork): Adjust.
5638         (free_fork): Delete, folded into fork_info::~fork_info().
5639         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5640         Adjust.
5641         (init_fork_list): Delete.
5642         (linux_fork_killall, linux_fork_mourn_inferior)
5643         (linux_fork_detach, info_checkpoints_command): Adjust.
5644         (_initialize_linux_fork): No longer call init_fork_list.
5645
5646 2019-03-06  Pedro Alves  <palves@redhat.com>
5647
5648         * linux-fork.c (new_fork): New, split out of ...
5649         (add_fork): ... this.  Return void.  Move "first fork" special
5650         case from here, to ...
5651         (checkpoint_command): ... here.
5652         * linux-linux.h (add_fork): Return void.
5653
5654 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5655
5656         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5657
5658 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5659             Chris January  <chris.january@arm.com>
5660             David Lecomber  <david.lecomber@arm.com>
5661
5662         * f-exp.y: New token, UNOP_INTRINSIC.
5663         (exp): New pattern using UNOP_INTRINSIC token.
5664         (f77_keywords): Add 'abs' keyword.
5665         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5666         (value_from_host_double): New function.
5667         (evaluate_subexp_f): Support UNOP_ABS.
5668
5669 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5670
5671         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5672         types.
5673
5674 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5675
5676         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5677         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5678         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5679
5680 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5681
5682         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5683
5684 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5685             Chris January  <chris.january@arm.com>
5686
5687         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5688         * f-exp.y: Define 'KIND' token.
5689         (exp): New pattern for KIND expressions.
5690         (ptype): Handle types with a kind extension.
5691         (direct_abs_decl): Extend to spot kind extensions.
5692         (f77_keywords): Add 'kind' to the list.
5693         (push_kind_type): New function.
5694         (convert_to_kind_type): New function.
5695         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5696         * parse.c (operator_length_standard): Likewise.
5697         * parser-defs.h (enum type_pieces): Add tp_kind.
5698         * std-operator.def: Add UNOP_KIND.
5699
5700 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5701
5702         * f-exp.y (f_parse): Set yydebug.
5703
5704 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5705
5706         * f-lang.c (evaluate_subexp_f): New function.
5707         (exp_descriptor_f): New global.
5708         (f_language_defn): Use exp_descriptor_f instead of
5709         exp_descriptor_standard.
5710
5711 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5712
5713         * f-exp.y (struct token): Add comments.
5714         (dot_ops): Remove uppercase versions and the end marker.
5715         (f77_keywords): Likewise.
5716         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5717         entries in the dot_ops array are case insensitive, and use
5718         strncasecmp to compare strings.  Also some whitespace cleanup in
5719         this area.  Similar for the f77_keywords array, except entries in
5720         this list might be case sensitive.
5721
5722 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5723
5724         * f-exp.y (struct f77_boolean_val): Add comments.
5725         (boolean_values): Remove uppercase versions, and end marker.
5726         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5727         and use strncasecmp to achieve case insensitivity.  Additionally,
5728         perform whitespace cleanup around this code.
5729
5730 2019-03-06  Tom Tromey  <tromey@adacore.com>
5731
5732         * remote-sim.c (gdbsim_target_open): Use result of
5733         gdb_argv::release.
5734
5735 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5736         Dirk Schubert  <dirk.schubert@arm.com>
5737         Chris January  <chris.january@arm.com>
5738
5739         * eval.c (evaluate_subexp_standard): Call Fortran argument
5740         wrapping logic.
5741         * f-lang.c (struct value): A value which can be passed into a
5742         Fortran function call.
5743         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5744         where appropriate.
5745         (struct type): Value ready for a Fortran function call.
5746         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5747         is needed.
5748         * f-lang.h (fortran_argument_convert): Declaration.
5749         (fortran_preserve_arg_pointer): Declaration.
5750         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5751
5752 2019-03-05  Tom Tromey  <tromey@adacore.com>
5753
5754         * python/py-prettyprint.c (print_string_repr): Remove #if.
5755         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5756
5757 2019-03-05  Tom Tromey  <tromey@adacore.com>
5758
5759         * target.c (the_dummy_target): Move later.  Change type to
5760         "dummy_target".
5761         (initialize_targets): Don't initialize the_dummy_target.
5762
5763 2019-03-05  Tom Tromey  <tromey@adacore.com>
5764
5765         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5766         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5767
5768 2019-03-05  Tom Tromey  <tromey@adacore.com>
5769
5770         * windows-nat.c (windows_nat_target::attach)
5771         (windows_nat_target::detach): Don't call gdb_flush.
5772         * valprint.c (generic_val_print, val_print, val_print_string):
5773         Don't call gdb_flush.
5774         * utils.c (defaulted_query): Don't call gdb_flush.
5775         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5776         * target.c (target_announce_detach): Don't call gdb_flush.
5777         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5778         * remote.c (extended_remote_target::attach): Don't call
5779         gdb_flush.
5780         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5781         * printcmd.c (do_examine): Don't call gdb_flush.
5782         (info_display_command): Don't call gdb_flush.
5783         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5784         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5785         * memattr.c (info_mem_command): Don't call gdb_flush.
5786         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5787         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5788         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5789         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5790         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5791         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5792         (gnu_nat_target::detach): Don't call gdb_flush.
5793         * f-valprint.c (f_val_print): Don't call gdb_flush.
5794         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5795         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5796         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5797         gdb_flush.
5798         * c-valprint.c (c_val_print): Don't call gdb_flush.
5799         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5800
5801 2019-03-05  Tom Tromey  <tromey@adacore.com>
5802
5803         * varobj.c (update_dynamic_varobj_children): Update.
5804         (install_default_visualizer): Use reset, not release.
5805         * value.c (set_internalvar): Update.
5806         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5807         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5808         ATTRIBUTE_UNUSED_RESULT.
5809
5810 2019-03-05  Tom Tromey  <tromey@adacore.com>
5811
5812         * remote.c (class scoped_remote_fd) <release>: Add
5813         ATTRIBUTE_UNUSED_RESULT.
5814
5815 2019-03-05  Tom Tromey  <tromey@adacore.com>
5816
5817         * macroexp.c (struct macro_buffer) <release>: Add
5818         ATTRIBUTE_UNUSED_RESULT.
5819
5820 2019-03-05  Tom Tromey  <tromey@adacore.com>
5821
5822         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5823         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5824         ATTRIBUTE_UNUSED_RESULT.
5825
5826 2019-03-05  Tom Tromey  <tromey@adacore.com>
5827
5828         * common/scoped_fd.h (class scoped_fd) <release>: Add
5829         ATTRIBUTE_UNUSED_RESULT.
5830
5831 2019-03-05  Tom Tromey  <tromey@adacore.com>
5832
5833         * parser-defs.h (struct parser_state) <release>: Add
5834         ATTRIBUTE_UNUSED_RESULT.
5835
5836 2019-03-05  Tom Tromey  <tromey@adacore.com>
5837
5838         * utils.h (class gdb_argv) <release>: Add
5839         ATTRIBUTE_UNUSED_RESULT.
5840         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5841
5842 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5843
5844         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5845         for-loop range, to avoid compiler warnings.
5846
5847         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5848         avoid compiler warnings about unused variables.
5849
5850         * NEWS: Mention end of support for native debugging on MS-Windows
5851         before XP.
5852
5853         PR gdb/24292
5854         * common/netstuff.c:
5855         * gdbserver/gdbreplay.c
5856         * gdbserver/remote-utils.c:
5857         * ser-tcp.c:
5858         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5859         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5860         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5861         'getaddrinfo' and 'freeaddrinfo' were not available before
5862         Windows XP, and mingw.org's MinGW headers by default define
5863         _WIN32_WINNT to 0x500.
5864
5865 2019-03-01  Gary Benson <gbenson@redhat.com>
5866
5867         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5868
5869 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5870             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5871
5872         PR gdb/8527
5873         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5874         set_sigint_trap, clear_sigint_trap.
5875
5876 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5877
5878         * target.c (target_detach): Clear the regcache and the
5879         frame cache.
5880
5881 2019-02-27  Pedro Alves  <palves@redhat.com>
5882
5883         * utils.c (set_screen_size): When we cap the height/width sizes,
5884         tweak the corresponding command variable to show "unlimited":
5885
5886 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5887             Pedro Alves  <palves@redhat.com>
5888
5889         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5890         before calling rl_set_screen_size.
5891
5892 2019-02-27  Tom Tromey  <tromey@adacore.com>
5893
5894         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5895         define.
5896         * python/py-value.c: Remove Python 2.4 workaround.
5897         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5898         workaround.
5899         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5900         Python 2.4 workaround.
5901         * python/python-internal.h: Remove Python 2.4 comment.
5902         (Py_ssize_t): Don't define.
5903         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5904         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5905         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5906         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5907         * python/python.c (do_start_initialization): Remove Python 2.4
5908         workaround.
5909         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5910         (print_children): Remove Python 2.4 workaround.
5911         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5912         workaround.
5913         (CHARBUFFERPROC_NAME): Remove.
5914         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5915         Python 2.4 workaround.
5916
5917 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5918
5919         * NEWS: Note minimum Python version.
5920
5921 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5922
5923         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5924         code from these functions.  Remove corresponding ifdefs.  Use
5925         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5926         Remove gotos and target of gotos.
5927         (infpy_search_memory): Likewise.
5928
5929 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5930
5931         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5932         (hppa_gdbarch_init): Don't register deleted functions with
5933         gdbarch.
5934
5935 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5936
5937         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5938         (h8300_unwind_sp): Delete.
5939         (h8300_dummy_id): Delete.
5940         (h8300_gdbarch_init): Don't register deleted functions with
5941         gdbarch.
5942
5943 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5944
5945         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5946         (ft32_unwind_pc): Delete.
5947         (ft32_unwind_sp): Delete.
5948         (ft32_gdbarch_init): Don't register deleted functions with
5949         gdbarch.
5950
5951 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5952
5953         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5954         (frv_unwind_pc): Delete.
5955         (frv_unwind_sp): Delete.
5956         (frv_gdbarch_init): Don't register deleted functions with
5957         gdbarch.
5958
5959 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5960
5961         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5962         (riscv_unwind_pc): Delete.
5963         (riscv_unwind_sp): Delete.
5964         (riscv_gdbarch_init): Don't register deleted functions with
5965         gdbarch.
5966
5967 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5968
5969         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5970         (csky_unwind_pc): Delete.
5971         (csky_unwind_sp): Delete.
5972         (csky_gdbarch_init): Don't register deleted functions with
5973         gdbarch.
5974
5975 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5976
5977         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5978         (cris_unwind_pc): Delete.
5979         (cris_unwind_sp): Delete.
5980         (cris_gdbarch_init): Don't register deleted functions with
5981         gdbarch.
5982
5983 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5984
5985         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5986         (bfin_unwind_pc): Delete.
5987         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5988
5989 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5990
5991         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5992         (arm_unwind_pc): Delete.
5993         (arm_unwind_sp): Delete.
5994         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5995
5996 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5997
5998         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5999         (arc_unwind_pc): Delete.
6000         (arc_unwind_sp): Delete.
6001         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6002
6003 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6004
6005         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6006         (alpha_unwind_pc): Delete.
6007         (alpha_gdbarch_init): Don't register deleted functions with
6008         gdbarch.
6009
6010 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6011
6012         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6013         (aarch64_unwind_pc): Delete.
6014         (aarch64_unwind_sp): Delete.
6015         (aarch64_gdbarch_init): Don't register deleted functions with
6016         gdbarch.
6017
6018 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6019
6020         * gdbtypes.c (type_align): Don't consider static members when
6021         computing structure alignment.
6022
6023 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6024
6025         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6026         return 0 for other types.
6027         * arch-utils.c (default_type_align): Always return 0.
6028         * gdbarch.h: Regenerate.
6029         * gdbarch.sh (type_align): Extend comment.
6030         * gdbtypes.c (type_align): Add additional comments, always call
6031         gdbarch_type_align before applying the default rules.
6032         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6033         generic code will then apply a suitable default.
6034         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6035         types, return 0 for other types.
6036
6037 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6038
6039         * NEWS: Create a new section for the next release branch.
6040         Rename the section of the current branch, now that it has
6041         been cut.
6042
6043 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6044
6045         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6046         * version.in: Bump version to 8.3.50.DATE-git.
6047
6048 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6049
6050         * aix-thread.c (ptid_cmp): Remove unused variable.
6051         (get_signaled_thread): Likewise.
6052         (store_regs_user_thread): Likewise.
6053         (store_regs_kernel_thread): Likewise.
6054         (fetch_regs_kernel_thread): Remove shadowed variable.
6055
6056 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6057
6058         * features/riscv/32bit-cpu.xml: Add register numbers.
6059         * features/riscv/32bit-fpu.c: Regenerate.
6060         * features/riscv/32bit-fpu.xml: Add register numbers.
6061         * features/riscv/64bit-cpu.xml: Add register numbers.
6062         * features/riscv/64bit-fpu.c: Regenerate.
6063         * features/riscv/64bit-fpu.xml: Add register numbers.
6064
6065 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6066
6067         * NEWS: Mention two argument form of gdb.Value constructor.
6068         * python/py-value.c (convert_buffer_and_type_to_value): New
6069         function.
6070         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6071         Add support for handling an optional second argument.  Call
6072         convert_buffer_and_type_to_value as appropriate.
6073         * python/python-internal.h (Py_buffer_deleter): New struct.
6074         (Py_buffer_up): New typedef.
6075
6076 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6077
6078         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6079         instead of releasing ownership.
6080
6081 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6082
6083         * dwarf2read.c (open_and_init_dwp_file): Call
6084         elf_numsections instead of bfd_count_sections to initialize
6085         dwp_file->num_sections.
6086
6087 2019-02-25  Tom Tromey  <tromey@adacore.com>
6088
6089         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6090
6091 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6092
6093         * gcore.in: Add '--readnever' option when invoking GDB.
6094
6095 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6096
6097         * MAINTAINERS: Update my email address.
6098
6099 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6100
6101         * build-id.c (build_id_to_debug_bfd_1): New function.
6102         (build_id_to_debug_bfd): Look for separate debug file in
6103         sysroot.
6104
6105 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6106
6107         * gdbarch.sh: Update the copyright year range that is placed into
6108         generated files.
6109
6110 2019-02-22  Keith Seitz  <keiths@redhat.com>
6111
6112         PR symtab/23853
6113         * linespec.c (create_sals_line_offset): Search for the default
6114         symtab's filename instead of its fullname.
6115
6116 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6117
6118         * NEWS: Update style defaults.
6119
6120 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6121
6122         * main.c (captured_main_1): Disable styling in batch mode.
6123
6124 2019-02-20  Tom Tromey  <tom@tromey.com>
6125
6126         * symtab.c (symtab_symbol_info): Fix typos.
6127
6128 2019-02-20  Tom Tromey  <tromey@adacore.com>
6129
6130         * findcmd.c (_initialize_mem_search): Use upper case for
6131         metasyntactic variables.
6132
6133 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6134
6135         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6136         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6137
6138 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6139
6140         * top.h (source_file_name): Change to std::string.
6141         * top.c (source_file_name): Likewise.
6142         (command_line_input): Adjust.
6143         * cli/cli-script.c (script_from_file): Adjust.
6144
6145 2019-02-19  Tom Tromey  <tromey@adacore.com>
6146
6147         * ravenscar-thread.c
6148         (ravenscar_thread_target::update_thread_list): Don't call
6149         ada_build_task_list.
6150         * ada-lang.h (ada_build_task_list): Don't declare.
6151         * ada-tasks.c (struct ada_tasks_inferior_data)
6152         <task_list_valid_p>: Now bool.
6153         (read_known_tasks, ada_task_list_changed)
6154         (ada_tasks_invalidate_inferior_data): Update.
6155         (read_known_tasks_array): Return bool.
6156         (read_known_tasks_list): Likewise.
6157         (read_known_tasks): Return void.
6158         (ada_build_task_list): Now static.
6159
6160 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6161
6162         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6163         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6164
6165 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6166
6167         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6168         variant for ada_tasks_pspace_data_handle and
6169         ada_tasks_inferior_data_handle.
6170         (ada_tasks_pspace_data_cleanup): New function.
6171         (ada_tasks_inferior_data_cleanup): New function.
6172
6173 2019-02-17  Tom Tromey  <tom@tromey.com>
6174
6175         * macrotab.h (macro_source_fullname): Return a std::string.
6176         * macrotab.c (macro_include, check_for_redefinition)
6177         (macro_undef, macro_lookup_definition, foreach_macro)
6178         (foreach_macro_in_scope): Update.
6179         (macro_source_fullname): Return a std::string.
6180         * macrocmd.c (show_pp_source_pos): Update.
6181
6182 2019-02-17  Tom Tromey  <tom@tromey.com>
6183
6184         * macrocmd.c (show_pp_source_pos): Style the file names.
6185
6186 2019-02-17  Tom Tromey  <tom@tromey.com>
6187
6188         PR tui/24197:
6189         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6190
6191 2019-02-17  Tom Tromey  <tom@tromey.com>
6192
6193         * ada-lang.c (user_select_syms): Use filtered printing.
6194         * utils.c (wrap_style): New global.
6195         (desired_style): Remove.
6196         (emit_style_escape): Add stream parameter.
6197         (set_output_style, reset_terminal_style, prompt_for_continue):
6198         Update.
6199         (flush_wrap_buffer): Only flush gdb_stdout.
6200         (wrap_here): Set wrap_style.
6201         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6202         treat escape sequences as a character.  Change when wrap buffer is
6203         flushed.
6204         (fputs_styled): Do not set the output style when the default is
6205         requested.
6206         * ui-style.h (struct ui_file_style) <is_default>: New method.
6207         * source.c (print_source_lines_base): Emit escape sequences in one
6208         piece.
6209
6210 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6211
6212         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6213         integers and enumeration types.
6214
6215 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6216
6217         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6218         instead of lookup_symbol_in_language
6219         (do_exact_match): New function.
6220         (ada_get_symbol_name_matcher): Return do_exact_match when
6221         doing a verbatim match.
6222
6223 2019-02-15  Tom Tromey  <tromey@adacore.com>
6224
6225         * ravenscar-thread.c (ravenscar_thread_target::resume)
6226         (ravenscar_thread_target::wait): Special case wildcard requests.
6227
6228 2019-02-15  Tom Tromey  <tromey@adacore.com>
6229
6230         * ravenscar-thread.c (base_ptid): Remove.
6231         (struct ravenscar_thread_target) <close>: New method.
6232         <m_base_ptid>: New member.
6233         <update_inferior_ptid, active_task, task_is_currently_active,
6234         runtime_initialized>: Declare methods.
6235         <ravenscar_thread_target>: Add constructor.
6236         (ravenscar_thread_target::task_is_currently_active)
6237         (ravenscar_thread_target::update_inferior_ptid)
6238         (ravenscar_runtime_initialized): Rename.  Now methods.
6239         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6240         (ravenscar_thread_target::update_thread_list): Update.
6241         (ravenscar_thread_target::active_task): Now method.
6242         (ravenscar_thread_target::store_registers)
6243         (ravenscar_thread_target::prepare_to_store)
6244         (ravenscar_thread_target::prepare_to_store)
6245         (ravenscar_thread_target::mourn_inferior): Update.
6246         (ravenscar_inferior_created): Use "new" to create target.
6247         (ravenscar_thread_target::get_ada_task_ptid): Update.
6248         (_initialize_ravenscar): Don't initialize base_ptid.
6249         (ravenscar_ops): Remove global.
6250
6251 2019-02-15  Tom Tromey  <tromey@adacore.com>
6252
6253         * target.h (push_target): Declare new overload.
6254         * target.c (push_target): New overload, taking an rvalue reference.
6255         * remote.c (remote_target::open_1): Use push_target overload.
6256         * corelow.c (core_target_open): Use push_target overload.
6257
6258 2019-02-15  Tom Tromey  <tromey@adacore.com>
6259
6260         * ravenscar-thread.c (is_ravenscar_task)
6261         (ravenscar_task_is_currently_active): Return bool.
6262         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6263         (_initialize_ravenscar): Remove "(void)".
6264         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6265         Return bool.
6266
6267 2019-02-15  Tom Tromey  <tromey@adacore.com>
6268
6269         * ravenscar-thread.c (ravenscar_runtime_initializer)
6270         (has_ravenscar_runtime, get_running_thread_id)
6271         (ravenscar_thread_target::resume): Fix indentation.
6272
6273 2019-02-15  Tom Tromey  <tromey@adacore.com>
6274
6275         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6276         from ravenscar_arch_ops.
6277         (sparc_ravenscar_ops::fetch_registers)
6278         (sparc_ravenscar_ops::store_registers): Now methods.
6279         (sparc_ravenscar_prepare_to_store): Remove.
6280         (sparc_ravenscar_ops): Redefine.
6281         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6282         methods and destructor.  Remove members.
6283         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6284         (ravenscar_thread_target::store_registers)
6285         (ravenscar_thread_target::prepare_to_store): Update.
6286         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6287         Remove.
6288         (struct ppc_ravenscar_powerpc_ops): Derive from
6289         ravenscar_arch_ops.
6290         (ppc_ravenscar_powerpc_ops::fetch_registers)
6291         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6292         (ppc_ravenscar_powerpc_ops): Redefine.
6293         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6294         (ppc_ravenscar_e500_ops::fetch_registers)
6295         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6296         (ppc_ravenscar_e500_ops): Redefine.
6297         * aarch64-ravenscar-thread.c
6298         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6299         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6300         (aarch64_ravenscar_fetch_registers)
6301         (aarch64_ravenscar_store_registers): Now methods.
6302         (aarch64_ravenscar_ops): Redefine.
6303
6304 2019-02-15  Tom Tromey  <tromey@adacore.com>
6305
6306         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6307         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6308         (ravenscar_thread_target::stopped_by_watchpoint)
6309         (ravenscar_thread_target::stopped_data_address)
6310         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6311
6312 2019-02-15  Tom Tromey  <tromey@adacore.com>
6313
6314         * ravenscar-thread.c: Fix some typos.
6315
6316 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6317             Tom Tromey  <tromey@adacore.com>
6318
6319         * ada-lang.c (ada_exception_sal): Change addr_string to a
6320         std::string.
6321         (create_ada_exception_catchpoint): Update.
6322
6323 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6324             Tom Tromey  <tromey@adacore.com>
6325
6326         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6327         (bp_location_ops): Remove.
6328         (base_breakpoint_allocate_location): Update.
6329         (free_bp_location): Update.
6330         * ada-lang.c (class ada_catchpoint_location)
6331         <ada_catchpoint_location>: Remove ops parameter.
6332         (ada_catchpoint_location_dtor): Remove.
6333         (ada_catchpoint_location_ops): Remove.
6334         (allocate_location_exception): Update.
6335         * breakpoint.h (struct bp_location_ops): Remove.
6336         (class bp_location) <bp_location>: Remove bp_location_ops
6337         parameter.
6338         <~bp_location>: Add destructor.
6339         <ops>: Remove.
6340
6341 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6342             Pedro Alves  <palves@redhat.com>
6343
6344         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6345         'PATH_MAX'.
6346
6347 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6348             Samuel Thibault  <samuel.thibault@gnu.org>
6349             Thomas Schwinge  <thomas@codesourcery.com>
6350
6351         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6352         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6353
6354 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6355
6356         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6357         (check_empty): Use "const char *".
6358
6359         * gnu-nat.c (gnu_nat_target::detach): Instead of
6360         'detach_inferior (pid)' call
6361         'detach_inferior (find_inferior_pid (pid))'.
6362
6363         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6364         'nat/fork-inferior.o'.
6365         * gnu-nat.c: #include "nat/fork-inferior.h".
6366
6367         * gnu-nat.c (gnu_nat_target::detach): Instead of
6368         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6369         * gnu-nat.h: #include "inf-child.h".
6370         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6371         'i386_gnu_nat_target::fetch_registers'.
6372         (gnu_store_registers): Rename/move to
6373         'i386_gnu_nat_target::store_registers'.
6374
6375         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6376         * gnu-nat.h (mach_thread_info): New function.
6377         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6378
6379         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6380
6381 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6382
6383         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6384
6385 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6386
6387         * windows-nat.c (windows_add_thread): Add new parameter
6388         "main_thread_p" with default value set to false.  Update
6389         function documentation as well as all callers.
6390         (windows_delete_thread): Likewise.
6391         (fake_create_process): Update call to windows_add_thread.
6392         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6393         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6394         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6395         call to windows_delete_thread.
6396
6397 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6398
6399         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6400
6401 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6402
6403         * symfile.c (find_separate_debug_file): Use canonical path of
6404         sysroot with child_path instead of gdb_sysroot if it is valid.
6405
6406 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6407
6408         * symfile.c (find_separate_debug_file): Use child_path to
6409         determine if an object file is under a sysroot.
6410
6411 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6412
6413         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6414         unittests/child-path-selftests.c.
6415         * common/pathstuff.c (child_path): New function.
6416         * common/pathstuff.h (child_path): New prototype.
6417         * unittests/child-path-selftests.c: New file.
6418
6419 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6420
6421         * symfile.c (find_separate_debug_file): Look for separate debug
6422         files in debug directories under the sysroot.
6423
6424 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6425
6426         * symtab.h (struct minimal_symbol data_p): New const method.
6427         (struct minimal_symbol text_p): Likewise.
6428         * symtab.c (output_source_filename): Use file name style
6429         to print file name.
6430         (print_symbol_info): Likewise.
6431         (print_msymbol_info): Use address style to print addresses.
6432         Use function name style to print executable text symbols.
6433         (expand_symtab_containing_pc): Use data_p.
6434         (find_pc_sect_compunit_symtab): Likewise.
6435
6436 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6437
6438         * breakpoint.c (describe_other_breakpoints): Use address style
6439         to print addresses.
6440         (say_where): Likewise.
6441
6442 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6443
6444         * ada-typeprint.c (print_func_type): Print function name
6445         style to print function name.
6446         * c-typeprint.c (c_print_type_1): Likewise.
6447
6448 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6449
6450         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6451         for execve.
6452
6453 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6454
6455         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6456         type_stack.
6457
6458 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6459
6460         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6461         TYPE_CODE_REF types.
6462
6463 2019-02-08  Jim Wilson  <jimw@sifive.com>
6464
6465         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6466         (riscv_linux_fregset): New.
6467         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6468
6469 2019-02-07  Tom Tromey  <tom@tromey.com>
6470
6471         * thread.c (thread_cancel_execution_command): Update.
6472         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6473         methods.
6474         (struct thread_fsm_ops): Remove.
6475         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6476         (thread_fsm_should_stop, thread_fsm_return_value)
6477         (thread_fsm_set_finished, thread_fsm_finished_p)
6478         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6479         Don't declare.
6480         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6481         * infrun.c (clear_proceed_status_thread)
6482         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6483         (print_stop_event): Update.
6484         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6485         Add constructor.
6486         (step_command_fsm_ops): Remove.
6487         (new_step_command_fsm): Remove.
6488         (step_1): Update.
6489         (step_command_fsm::should_stop): Rename from
6490         step_command_fsm_should_stop.
6491         (step_command_fsm::clean_up): Rename from
6492         step_command_fsm_clean_up.
6493         (step_command_fsm::do_async_reply_reason): Rename from
6494         step_command_fsm_async_reply_reason.
6495         (struct until_next_fsm): Inherit from thread_fsm.  Add
6496         constructor.
6497         (until_next_fsm_ops): Remove.
6498         (new_until_next_fsm): Remove.
6499         (until_next_fsm::should_stop): Rename from
6500         until_next_fsm_should_stop.
6501         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6502         (until_next_fsm::do_async_reply_reason): Rename from
6503         until_next_fsm_async_reply_reason.
6504         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6505         constructor.  Change type of breakpoint.
6506         (finish_command_fsm_ops): Remove.
6507         (new_finish_command_fsm): Remove.
6508         (finish_command_fsm::should_stop): Rename from
6509         finish_command_fsm_should_stop.
6510         (finish_command_fsm::clean_up): Rename from
6511         finish_command_fsm_clean_up.
6512         (finish_command_fsm::return_value): Rename from
6513         finish_command_fsm_return_value.
6514         (finish_command_fsm::do_async_reply_reason): Rename from
6515         finish_command_fsm_async_reply_reason.
6516         (finish_command): Update.
6517         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6518         Add constructor.
6519         (call_thread_fsm_ops): Remove.
6520         (call_thread_fsm::call_thread_fsm): Rename from
6521         new_call_thread_fsm.
6522         (call_thread_fsm::should_stop): Rename from
6523         call_thread_fsm_should_stop.
6524         (call_thread_fsm::should_notify_stop): Rename from
6525         call_thread_fsm_should_notify_stop.
6526         (run_inferior_call, call_function_by_hand_dummy): Update.
6527         * cli/cli-interp.c (should_print_stop_to_console): Update.
6528         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6529         Add constructor.  Change type of location_breakpoint,
6530         caller_breakpoint.
6531         (until_break_fsm_ops): Remove.
6532         (new_until_break_fsm): Remove.
6533         (until_break_fsm::should_stop): Rename from
6534         until_break_fsm_should_stop.
6535         (until_break_fsm::clean_up): Rename from
6536         until_break_fsm_clean_up.
6537         (until_break_fsm::do_async_reply_reason): Rename from
6538         until_break_fsm_async_reply_reason.
6539         (until_break_command): Update.
6540         * thread-fsm.c: Remove.
6541         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6542
6543 2019-02-07  Tom Tromey  <tom@tromey.com>
6544
6545         * yy-remap.h: Add include guard.
6546         * xtensa-tdep.h: Add include guard.
6547         * xcoffread.h: Rename include guard.
6548         * varobj-iter.h: Add include guard.
6549         * tui/tui.h: Rename include guard.
6550         * tui/tui-winsource.h: Rename include guard.
6551         * tui/tui-wingeneral.h: Rename include guard.
6552         * tui/tui-windata.h: Rename include guard.
6553         * tui/tui-win.h: Rename include guard.
6554         * tui/tui-stack.h: Rename include guard.
6555         * tui/tui-source.h: Rename include guard.
6556         * tui/tui-regs.h: Rename include guard.
6557         * tui/tui-out.h: Rename include guard.
6558         * tui/tui-layout.h: Rename include guard.
6559         * tui/tui-io.h: Rename include guard.
6560         * tui/tui-hooks.h: Rename include guard.
6561         * tui/tui-file.h: Rename include guard.
6562         * tui/tui-disasm.h: Rename include guard.
6563         * tui/tui-data.h: Rename include guard.
6564         * tui/tui-command.h: Rename include guard.
6565         * tic6x-tdep.h: Add include guard.
6566         * target/waitstatus.h: Rename include guard.
6567         * target/wait.h: Rename include guard.
6568         * target/target.h: Rename include guard.
6569         * target/resume.h: Rename include guard.
6570         * target-float.h: Rename include guard.
6571         * stabsread.h: Add include guard.
6572         * rs6000-tdep.h: Add include guard.
6573         * riscv-fbsd-tdep.h: Add include guard.
6574         * regformats/regdef.h: Rename include guard.
6575         * record.h: Rename include guard.
6576         * python/python.h: Rename include guard.
6577         * python/python-internal.h: Rename include guard.
6578         * python/py-stopevent.h: Rename include guard.
6579         * python/py-ref.h: Rename include guard.
6580         * python/py-record.h: Rename include guard.
6581         * python/py-record-full.h: Rename include guard.
6582         * python/py-record-btrace.h: Rename include guard.
6583         * python/py-instruction.h: Rename include guard.
6584         * python/py-events.h: Rename include guard.
6585         * python/py-event.h: Rename include guard.
6586         * procfs.h: Add include guard.
6587         * proc-utils.h: Add include guard.
6588         * p-lang.h: Add include guard.
6589         * or1k-tdep.h: Rename include guard.
6590         * observable.h: Rename include guard.
6591         * nto-tdep.h: Rename include guard.
6592         * nat/x86-linux.h: Rename include guard.
6593         * nat/x86-linux-dregs.h: Rename include guard.
6594         * nat/x86-gcc-cpuid.h: Add include guard.
6595         * nat/x86-dregs.h: Rename include guard.
6596         * nat/x86-cpuid.h: Rename include guard.
6597         * nat/ppc-linux.h: Rename include guard.
6598         * nat/mips-linux-watch.h: Rename include guard.
6599         * nat/linux-waitpid.h: Rename include guard.
6600         * nat/linux-ptrace.h: Rename include guard.
6601         * nat/linux-procfs.h: Rename include guard.
6602         * nat/linux-osdata.h: Rename include guard.
6603         * nat/linux-nat.h: Rename include guard.
6604         * nat/linux-namespaces.h: Rename include guard.
6605         * nat/linux-btrace.h: Rename include guard.
6606         * nat/glibc_thread_db.h: Rename include guard.
6607         * nat/gdb_thread_db.h: Rename include guard.
6608         * nat/gdb_ptrace.h: Rename include guard.
6609         * nat/fork-inferior.h: Rename include guard.
6610         * nat/amd64-linux-siginfo.h: Rename include guard.
6611         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6612         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6613         * nat/aarch64-linux.h: Rename include guard.
6614         * nat/aarch64-linux-hw-point.h: Rename include guard.
6615         * mn10300-tdep.h: Add include guard.
6616         * mips-linux-tdep.h: Add include guard.
6617         * mi/mi-parse.h: Rename include guard.
6618         * mi/mi-out.h: Rename include guard.
6619         * mi/mi-main.h: Rename include guard.
6620         * mi/mi-interp.h: Rename include guard.
6621         * mi/mi-getopt.h: Rename include guard.
6622         * mi/mi-console.h: Rename include guard.
6623         * mi/mi-common.h: Rename include guard.
6624         * mi/mi-cmds.h: Rename include guard.
6625         * mi/mi-cmd-break.h: Rename include guard.
6626         * m2-lang.h: Add include guard.
6627         * location.h: Rename include guard.
6628         * linux-record.h: Rename include guard.
6629         * linux-nat.h: Add include guard.
6630         * linux-fork.h: Add include guard.
6631         * i386-darwin-tdep.h: Rename include guard.
6632         * hppa-linux-offsets.h: Add include guard.
6633         * guile/guile.h: Rename include guard.
6634         * guile/guile-internal.h: Rename include guard.
6635         * gnu-nat.h: Rename include guard.
6636         * gdb-stabs.h: Rename include guard.
6637         * frv-tdep.h: Add include guard.
6638         * f-lang.h: Add include guard.
6639         * event-loop.h: Add include guard.
6640         * darwin-nat.h: Rename include guard.
6641         * cp-abi.h: Rename include guard.
6642         * config/sparc/nm-sol2.h: Rename include guard.
6643         * config/nm-nto.h: Rename include guard.
6644         * config/nm-linux.h: Add include guard.
6645         * config/i386/nm-i386gnu.h: Rename include guard.
6646         * config/djgpp/nl_types.h: Rename include guard.
6647         * config/djgpp/langinfo.h: Rename include guard.
6648         * compile/gcc-cp-plugin.h: Add include guard.
6649         * compile/gcc-c-plugin.h: Add include guard.
6650         * compile/compile.h: Rename include guard.
6651         * compile/compile-object-run.h: Rename include guard.
6652         * compile/compile-object-load.h: Rename include guard.
6653         * compile/compile-internal.h: Rename include guard.
6654         * compile/compile-cplus.h: Rename include guard.
6655         * compile/compile-c.h: Rename include guard.
6656         * common/xml-utils.h: Rename include guard.
6657         * common/x86-xstate.h: Rename include guard.
6658         * common/version.h: Rename include guard.
6659         * common/vec.h: Rename include guard.
6660         * common/tdesc.h: Rename include guard.
6661         * common/selftest.h: Rename include guard.
6662         * common/scoped_restore.h: Rename include guard.
6663         * common/scoped_mmap.h: Rename include guard.
6664         * common/scoped_fd.h: Rename include guard.
6665         * common/safe-iterator.h: Rename include guard.
6666         * common/run-time-clock.h: Rename include guard.
6667         * common/refcounted-object.h: Rename include guard.
6668         * common/queue.h: Rename include guard.
6669         * common/ptid.h: Rename include guard.
6670         * common/print-utils.h: Rename include guard.
6671         * common/preprocessor.h: Rename include guard.
6672         * common/pathstuff.h: Rename include guard.
6673         * common/observable.h: Rename include guard.
6674         * common/netstuff.h: Rename include guard.
6675         * common/job-control.h: Rename include guard.
6676         * common/host-defs.h: Rename include guard.
6677         * common/gdb_wait.h: Rename include guard.
6678         * common/gdb_vecs.h: Rename include guard.
6679         * common/gdb_unlinker.h: Rename include guard.
6680         * common/gdb_unique_ptr.h: Rename include guard.
6681         * common/gdb_tilde_expand.h: Rename include guard.
6682         * common/gdb_sys_time.h: Rename include guard.
6683         * common/gdb_string_view.h: Rename include guard.
6684         * common/gdb_splay_tree.h: Rename include guard.
6685         * common/gdb_setjmp.h: Rename include guard.
6686         * common/gdb_ref_ptr.h: Rename include guard.
6687         * common/gdb_optional.h: Rename include guard.
6688         * common/gdb_locale.h: Rename include guard.
6689         * common/gdb_assert.h: Rename include guard.
6690         * common/filtered-iterator.h: Rename include guard.
6691         * common/filestuff.h: Rename include guard.
6692         * common/fileio.h: Rename include guard.
6693         * common/environ.h: Rename include guard.
6694         * common/common-utils.h: Rename include guard.
6695         * common/common-types.h: Rename include guard.
6696         * common/common-regcache.h: Rename include guard.
6697         * common/common-inferior.h: Rename include guard.
6698         * common/common-gdbthread.h: Rename include guard.
6699         * common/common-exceptions.h: Rename include guard.
6700         * common/common-defs.h: Rename include guard.
6701         * common/common-debug.h: Rename include guard.
6702         * common/cleanups.h: Rename include guard.
6703         * common/buffer.h: Rename include guard.
6704         * common/btrace-common.h: Rename include guard.
6705         * common/break-common.h: Rename include guard.
6706         * cli/cli-utils.h: Rename include guard.
6707         * cli/cli-style.h: Rename include guard.
6708         * cli/cli-setshow.h: Rename include guard.
6709         * cli/cli-script.h: Rename include guard.
6710         * cli/cli-interp.h: Rename include guard.
6711         * cli/cli-decode.h: Rename include guard.
6712         * cli/cli-cmds.h: Rename include guard.
6713         * charset-list.h: Add include guard.
6714         * buildsym-legacy.h: Rename include guard.
6715         * bfin-tdep.h: Add include guard.
6716         * ax.h: Rename include guard.
6717         * arm-linux-tdep.h: Add include guard.
6718         * arm-fbsd-tdep.h: Add include guard.
6719         * arch/xtensa.h: Rename include guard.
6720         * arch/tic6x.h: Add include guard.
6721         * arch/i386.h: Add include guard.
6722         * arch/arm.h: Rename include guard.
6723         * arch/arm-linux.h: Rename include guard.
6724         * arch/arm-get-next-pcs.h: Rename include guard.
6725         * arch/amd64.h: Add include guard.
6726         * arch/aarch64-insn.h: Rename include guard.
6727         * arch-utils.h: Rename include guard.
6728         * annotate.h: Add include guard.
6729         * amd64-darwin-tdep.h: Rename include guard.
6730         * aarch64-linux-tdep.h: Add include guard.
6731         * aarch64-fbsd-tdep.h: Add include guard.
6732         * aarch32-linux-nat.h: Add include guard.
6733
6734 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6735
6736         * macrotab.c (macro_define_internal): New function that
6737         factorizes macro_define_object_internal and macro_define_function
6738         code.
6739         (macro_define_object_internal): Use macro_define_internal.
6740         (macro_define_function): Likewise.
6741
6742 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6743
6744         * macrocmd.c (extract_identifier): Return
6745         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6746         callers.
6747
6748 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6749
6750         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6751
6752 2019-02-05  Tom Tromey  <tom@tromey.com>
6753
6754         * target.c (target_stack::unpush): Move assertion earlier.
6755
6756 2019-01-30  Tom Tromey  <tom@tromey.com>
6757
6758         PR python/23615:
6759         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6760         (gdbpy_parse_and_eval): Likewise.
6761         * python/python-internal.h (gdbpy_allow_threads): New class.
6762
6763 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6764
6765         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6766         (aarch64_fbsd_fpregmap): Move earlier.
6767         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6768         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6769         instead of individual calls to trad_frame_set_reg_addr.
6770         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6771         earlier.
6772         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6773         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6774         instead of individual calls to trad_frame_set_reg_addr.
6775
6776 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6777
6778         * CONTRIBUTE: Replace contribution list with wiki link.
6779
6780 2019-01-25  Tom Tromey  <tom@tromey.com>
6781
6782         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6783
6784 2019-01-25  Tom Tromey  <tom@tromey.com>
6785
6786         * xtensa-linux-nat.c: Fix common/ includes.
6787         * xml-support.h: Fix common/ includes.
6788         * xml-support.c: Fix common/ includes.
6789         * x86-linux-nat.c: Fix common/ includes.
6790         * windows-nat.c: Fix common/ includes.
6791         * varobj.h: Fix common/ includes.
6792         * varobj.c: Fix common/ includes.
6793         * value.c: Fix common/ includes.
6794         * valops.c: Fix common/ includes.
6795         * utils.c: Fix common/ includes.
6796         * unittests/xml-utils-selftests.c: Fix common/ includes.
6797         * unittests/utils-selftests.c: Fix common/ includes.
6798         * unittests/unpack-selftests.c: Fix common/ includes.
6799         * unittests/tracepoint-selftests.c: Fix common/ includes.
6800         * unittests/style-selftests.c: Fix common/ includes.
6801         * unittests/string_view-selftests.c: Fix common/ includes.
6802         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6803         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6804         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6805         * unittests/rsp-low-selftests.c: Fix common/ includes.
6806         * unittests/parse-connection-spec-selftests.c: Fix common/
6807         includes.
6808         * unittests/optional-selftests.c: Fix common/ includes.
6809         * unittests/offset-type-selftests.c: Fix common/ includes.
6810         * unittests/observable-selftests.c: Fix common/ includes.
6811         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6812         * unittests/memrange-selftests.c: Fix common/ includes.
6813         * unittests/memory-map-selftests.c: Fix common/ includes.
6814         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6815         * unittests/function-view-selftests.c: Fix common/ includes.
6816         * unittests/environ-selftests.c: Fix common/ includes.
6817         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6818         * unittests/common-utils-selftests.c: Fix common/ includes.
6819         * unittests/cli-utils-selftests.c: Fix common/ includes.
6820         * unittests/array-view-selftests.c: Fix common/ includes.
6821         * ui-file.c: Fix common/ includes.
6822         * tui/tui-io.c: Fix common/ includes.
6823         * tracepoint.h: Fix common/ includes.
6824         * tracepoint.c: Fix common/ includes.
6825         * tracefile-tfile.c: Fix common/ includes.
6826         * top.h: Fix common/ includes.
6827         * top.c: Fix common/ includes.
6828         * thread.c: Fix common/ includes.
6829         * target/waitstatus.h: Fix common/ includes.
6830         * target/waitstatus.c: Fix common/ includes.
6831         * target.h: Fix common/ includes.
6832         * target.c: Fix common/ includes.
6833         * target-memory.c: Fix common/ includes.
6834         * target-descriptions.c: Fix common/ includes.
6835         * symtab.h: Fix common/ includes.
6836         * symfile.c: Fix common/ includes.
6837         * stap-probe.c: Fix common/ includes.
6838         * spu-linux-nat.c: Fix common/ includes.
6839         * sparc-nat.c: Fix common/ includes.
6840         * source.c: Fix common/ includes.
6841         * solib.c: Fix common/ includes.
6842         * solib-target.c: Fix common/ includes.
6843         * ser-unix.c: Fix common/ includes.
6844         * ser-tcp.c: Fix common/ includes.
6845         * ser-pipe.c: Fix common/ includes.
6846         * ser-base.c: Fix common/ includes.
6847         * selftest-arch.c: Fix common/ includes.
6848         * s12z-tdep.c: Fix common/ includes.
6849         * rust-exp.y: Fix common/ includes.
6850         * rs6000-aix-tdep.c: Fix common/ includes.
6851         * riscv-tdep.c: Fix common/ includes.
6852         * remote.c: Fix common/ includes.
6853         * remote-notif.h: Fix common/ includes.
6854         * remote-fileio.h: Fix common/ includes.
6855         * remote-fileio.c: Fix common/ includes.
6856         * regcache.h: Fix common/ includes.
6857         * regcache.c: Fix common/ includes.
6858         * record-btrace.c: Fix common/ includes.
6859         * python/python.c: Fix common/ includes.
6860         * python/py-type.c: Fix common/ includes.
6861         * python/py-inferior.c: Fix common/ includes.
6862         * progspace.h: Fix common/ includes.
6863         * producer.c: Fix common/ includes.
6864         * procfs.c: Fix common/ includes.
6865         * proc-api.c: Fix common/ includes.
6866         * printcmd.c: Fix common/ includes.
6867         * ppc-linux-nat.c: Fix common/ includes.
6868         * parser-defs.h: Fix common/ includes.
6869         * osdata.c: Fix common/ includes.
6870         * obsd-nat.c: Fix common/ includes.
6871         * nat/x86-linux.c: Fix common/ includes.
6872         * nat/x86-linux-dregs.c: Fix common/ includes.
6873         * nat/x86-dregs.h: Fix common/ includes.
6874         * nat/x86-dregs.c: Fix common/ includes.
6875         * nat/ppc-linux.c: Fix common/ includes.
6876         * nat/mips-linux-watch.h: Fix common/ includes.
6877         * nat/mips-linux-watch.c: Fix common/ includes.
6878         * nat/linux-waitpid.c: Fix common/ includes.
6879         * nat/linux-ptrace.h: Fix common/ includes.
6880         * nat/linux-ptrace.c: Fix common/ includes.
6881         * nat/linux-procfs.c: Fix common/ includes.
6882         * nat/linux-personality.c: Fix common/ includes.
6883         * nat/linux-osdata.c: Fix common/ includes.
6884         * nat/linux-namespaces.c: Fix common/ includes.
6885         * nat/linux-btrace.h: Fix common/ includes.
6886         * nat/linux-btrace.c: Fix common/ includes.
6887         * nat/fork-inferior.c: Fix common/ includes.
6888         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6889         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6890         * nat/aarch64-linux.c: Fix common/ includes.
6891         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6892         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6893         * namespace.h: Fix common/ includes.
6894         * mips-linux-tdep.c: Fix common/ includes.
6895         * minsyms.c: Fix common/ includes.
6896         * mi/mi-parse.h: Fix common/ includes.
6897         * mi/mi-main.c: Fix common/ includes.
6898         * mi/mi-cmd-env.c: Fix common/ includes.
6899         * memrange.h: Fix common/ includes.
6900         * memattr.c: Fix common/ includes.
6901         * maint.h: Fix common/ includes.
6902         * maint.c: Fix common/ includes.
6903         * main.c: Fix common/ includes.
6904         * machoread.c: Fix common/ includes.
6905         * location.c: Fix common/ includes.
6906         * linux-thread-db.c: Fix common/ includes.
6907         * linux-nat.c: Fix common/ includes.
6908         * linux-fork.c: Fix common/ includes.
6909         * inline-frame.c: Fix common/ includes.
6910         * infrun.c: Fix common/ includes.
6911         * inflow.c: Fix common/ includes.
6912         * inferior.h: Fix common/ includes.
6913         * inferior.c: Fix common/ includes.
6914         * infcmd.c: Fix common/ includes.
6915         * inf-ptrace.c: Fix common/ includes.
6916         * inf-child.c: Fix common/ includes.
6917         * ia64-linux-nat.c: Fix common/ includes.
6918         * i387-tdep.c: Fix common/ includes.
6919         * i386-tdep.c: Fix common/ includes.
6920         * i386-linux-tdep.c: Fix common/ includes.
6921         * i386-linux-nat.c: Fix common/ includes.
6922         * i386-go32-tdep.c: Fix common/ includes.
6923         * i386-fbsd-tdep.c: Fix common/ includes.
6924         * i386-fbsd-nat.c: Fix common/ includes.
6925         * guile/scm-type.c: Fix common/ includes.
6926         * guile/guile.c: Fix common/ includes.
6927         * go32-nat.c: Fix common/ includes.
6928         * gnu-nat.c: Fix common/ includes.
6929         * gdbthread.h: Fix common/ includes.
6930         * gdbarch-selftests.c: Fix common/ includes.
6931         * gdb_usleep.c: Fix common/ includes.
6932         * gdb_select.h: Fix common/ includes.
6933         * gdb_bfd.c: Fix common/ includes.
6934         * gcore.c: Fix common/ includes.
6935         * fork-child.c: Fix common/ includes.
6936         * findvar.c: Fix common/ includes.
6937         * fbsd-nat.c: Fix common/ includes.
6938         * event-top.c: Fix common/ includes.
6939         * event-loop.c: Fix common/ includes.
6940         * dwarf2read.c: Fix common/ includes.
6941         * dwarf2loc.c: Fix common/ includes.
6942         * dwarf2-frame.c: Fix common/ includes.
6943         * dwarf-index-cache.c: Fix common/ includes.
6944         * dtrace-probe.c: Fix common/ includes.
6945         * disasm-selftests.c: Fix common/ includes.
6946         * defs.h: Fix common/ includes.
6947         * csky-tdep.c: Fix common/ includes.
6948         * cp-valprint.c: Fix common/ includes.
6949         * cp-support.h: Fix common/ includes.
6950         * cp-support.c: Fix common/ includes.
6951         * corelow.c: Fix common/ includes.
6952         * completer.h: Fix common/ includes.
6953         * completer.c: Fix common/ includes.
6954         * compile/compile.c: Fix common/ includes.
6955         * compile/compile-loc2c.c: Fix common/ includes.
6956         * compile/compile-cplus-types.c: Fix common/ includes.
6957         * compile/compile-cplus-symbols.c: Fix common/ includes.
6958         * command.h: Fix common/ includes.
6959         * cli/cli-dump.c: Fix common/ includes.
6960         * cli/cli-cmds.c: Fix common/ includes.
6961         * charset.c: Fix common/ includes.
6962         * build-id.c: Fix common/ includes.
6963         * btrace.h: Fix common/ includes.
6964         * btrace.c: Fix common/ includes.
6965         * breakpoint.h: Fix common/ includes.
6966         * breakpoint.c: Fix common/ includes.
6967         * ax.h:
6968         (enum agent_op): Fix common/ includes.
6969         * ax-general.c (struct aop_map): Fix common/ includes.
6970         * ax-gdb.c: Fix common/ includes.
6971         * auxv.c: Fix common/ includes.
6972         * auto-load.c: Fix common/ includes.
6973         * arm-tdep.c: Fix common/ includes.
6974         * arch/riscv.c: Fix common/ includes.
6975         * arch/ppc-linux-common.c: Fix common/ includes.
6976         * arch/i386.c: Fix common/ includes.
6977         * arch/arm.c: Fix common/ includes.
6978         * arch/arm-linux.c: Fix common/ includes.
6979         * arch/arm-get-next-pcs.c: Fix common/ includes.
6980         * arch/amd64.c: Fix common/ includes.
6981         * arch/aarch64.c: Fix common/ includes.
6982         * arch/aarch64-insn.c: Fix common/ includes.
6983         * arch-utils.c: Fix common/ includes.
6984         * amd64-windows-tdep.c: Fix common/ includes.
6985         * amd64-tdep.c: Fix common/ includes.
6986         * amd64-sol2-tdep.c: Fix common/ includes.
6987         * amd64-obsd-tdep.c: Fix common/ includes.
6988         * amd64-nbsd-tdep.c: Fix common/ includes.
6989         * amd64-linux-tdep.c: Fix common/ includes.
6990         * amd64-linux-nat.c: Fix common/ includes.
6991         * amd64-fbsd-tdep.c: Fix common/ includes.
6992         * amd64-fbsd-nat.c: Fix common/ includes.
6993         * amd64-dicos-tdep.c: Fix common/ includes.
6994         * amd64-darwin-tdep.c: Fix common/ includes.
6995         * agent.c: Fix common/ includes.
6996         * ada-lang.h: Fix common/ includes.
6997         * ada-lang.c: Fix common/ includes.
6998         * aarch64-tdep.c: Fix common/ includes.
6999
7000 2019-01-25  Tom Tromey  <tom@tromey.com>
7001
7002         * common/create-version.sh: Use common/version.h.
7003
7004 2019-01-24  Pedro Alves  <palves@redhat.com>
7005
7006         * infrun.c (signal_stop, signal_print, signal_program)
7007         (signal_catch, signal_pass): Now arrays instead of pointers.
7008         (update_signals_program_target, do_target_resume)
7009         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7010         * linux-nat.c (linux_nat_target::pass_signals)
7011         (linux_nat_target::create_inferior, linux_nat_target::attach):
7012         Adjust.
7013         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7014         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7015         * procfs.c (procfs_target::pass_signals): Adjust.
7016         * record-full.c (record_full_target::resume): Adjust.
7017         * remote.c (remote_target::pass_signals)
7018         (remote_target::program_signals): Adjust.
7019         * target-debug.h (target_debug_print_signals): Now takes a
7020         gdb::array_view as parameter.  Adjust.
7021         * target.h (target_ops) <pass_signals, program_signals>: Replace
7022         pointer and length parameters with gdb::array_view.
7023         (target_pass_signals, target_program_signals): Likewise.
7024         * target-delegates.c: Regenerate.
7025
7026 2019-01-24  Pedro Alves  <palves@redhat.com>
7027
7028         * common/forward-scope-exit.h
7029         (forward_scope_exit::forward_scope_exit): Pass arguments to
7030         m_bind_function directly, instead of creating a std::bind and
7031         copying that.
7032
7033 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7034
7035         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7036         for static members.
7037         (pass_in_v_vfp_candidate): Likewise.
7038
7039 2019-01-23  Tom Tromey  <tom@tromey.com>
7040             Pedro Alves  <palves@redhat.com>
7041
7042         * regcache.c (class regcache_invalidator): Remove.
7043         (regcache::raw_write): Use make_scope_exit.
7044
7045 2019-01-23  Tom Tromey  <tom@tromey.com>
7046
7047         * ui-out.h (class ui_out_emit_type): Update comment.
7048
7049 2019-01-23  Tom Tromey  <tom@tromey.com>
7050
7051         * infrun.c (fetch_inferior_event): Update comment.
7052
7053 2019-01-23  Tom Tromey  <tom@tromey.com>
7054             Pedro Alves  <palves@redhat.com>
7055
7056         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7057         parameter.
7058         (fetch_inferior_event): Use SCOPE_EXIT.
7059
7060
7061 2019-01-23  Tom Tromey  <tom@tromey.com>
7062             Pedro Alves  <palves@redhat.com>
7063
7064         * infrun.c (disable_thread_events): Delete.
7065         (stop_all_threads): Use SCOPE_EXIT.
7066
7067 2019-01-23  Tom Tromey  <tom@tromey.com>
7068             Pedro Alves  <palves@redhat.com>
7069
7070         * symfile.c: Include forward-scope-exit.h.
7071         (clear_symtab_users_cleanup): Replace forward declaration with
7072         a FORWARD_SCOPE_EXIT.
7073         (syms_from_objfile_1): Use the forward_scope_exit and
7074         gdb::optional instead of cleanup_function.
7075         (reread_symbols): Use the forward_scope_exit instead of
7076         cleanup_function.
7077         (clear_symtab_users_cleanup): Remove function.
7078
7079 2019-01-23  Tom Tromey  <tom@tromey.com>
7080             Pedro Alves  <palves@redhat.com>
7081
7082         * linux-nat.c: Include scope-exit.h.
7083         (cleanup_target_stop): Remove.
7084         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7085         SCOPE_EXIT.
7086
7087 2019-01-23  Tom Tromey  <tom@tromey.com>
7088             Pedro Alves  <palves@redhat.com>
7089
7090         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7091         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7092
7093 2019-01-23  Tom Tromey  <tom@tromey.com>
7094             Andrew Burgess  <andrew.burgess@embecosm.com>
7095             Pedro Alves  <palves@redhat.com>
7096
7097         * infrun.c (fetch_inferior_event): Use scope_exit.
7098         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7099         * top.c (execute_command): Use scope_exit.
7100         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7101         * utils.c (do_bpstat_clear_actions_cleanup)
7102         (make_bpstat_clear_actions_cleanup): Remove.
7103
7104 2019-01-23  Tom Tromey  <tom@tromey.com>
7105             Pedro Alves  <palves@redhat.com>
7106
7107         * infrun.c: Include "common/scope-exit.h"
7108         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7109         (wait_for_inferior): Use SCOPE_EXIT.
7110         (fetch_inferior_event): Use scope_exit.
7111
7112 2019-01-23  Tom Tromey  <tom@tromey.com>
7113             Pedro Alves  <palves@redhat.com>
7114
7115         * breakpoint.c (create_breakpoint): Remove cleanup.
7116
7117 2019-01-23  Tom Tromey  <tom@tromey.com>
7118             Andrew Burgess  <andrew.burgess@embecosm.com>
7119             Pedro Alves  <palves@redhat.com>
7120
7121 2019-01-23  Pedro Alves  <palves@redhat.com>
7122
7123         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7124
7125 2019-01-23  Pedro Alves  <palves@redhat.com>
7126             Andrew Burgess  <andrew.burgess@embecosm.com>
7127
7128         * gdbthread.h: Include "common/forward-scope-exit.h".
7129         (scoped_finish_thread_state): Redefine custom class in terms of
7130         forward_scope_exit.
7131
7132 2019-01-23  Pedro Alves  <palves@redhat.com>
7133             Andrew Burgess  <andrew.burgess@embecosm.com>
7134
7135         * common/forward-scope-exit.h: New file.
7136
7137 2019-01-23  Pedro Alves  <palves@redhat.com>
7138             Andrew Burgess  <andrew.burgess@embecosm.com>
7139             Tom Tromey  <tom@tromey.com>
7140
7141         * common/scope-exit.h: New file.
7142
7143 2019-01-23  Pedro Alves  <palves@redhat.com>
7144
7145         * common/preprocessor.h (ESC): Rename to ...
7146         (ESC_PARENS): ... this.
7147         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7148         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7149
7150 2019-01-23  Tom Tromey  <tom@tromey.com>
7151
7152         * language.h (class scoped_switch_to_sym_language_if_auto):
7153         Initialize m_lang in both cases.
7154
7155 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7156
7157         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7158         with XCNEW.
7159
7160 2019-01-22  Tom Tromey  <tom@tromey.com>
7161
7162         * corelow.c: Do not include sys/file.h.
7163
7164 2019-01-22  Tom Tromey  <tom@tromey.com>
7165
7166         * tui/tui-wingeneral.h: Include gdb_curses.h.
7167
7168 2019-01-22  Tom Tromey  <tom@tromey.com>
7169
7170         * source-cache.h (class source_cache) <get_source_lines,
7171         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7172
7173 2019-01-22  Tom Tromey  <tom@tromey.com>
7174
7175         * remote-fileio.h (struct remote_target): Declare.
7176
7177 2019-01-22  Tom Tromey  <tom@tromey.com>
7178
7179         * python/py-arch.c: Do not include py-ref.h.
7180         * python/py-bpevent.c: Do not include py-ref.h.
7181         * python/py-cmd.c: Do not include py-ref.h.
7182         * python/py-continueevent.c: Do not include py-ref.h.
7183         * python/py-event.h: Do not include py-ref.h.
7184         * python/py-evtregistry.c: Do not include py-ref.h.
7185         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7186         * python/py-frame.c: Do not include py-ref.h.
7187         * python/py-framefilter.c: Do not include py-ref.h.
7188         * python/py-function.c: Do not include py-ref.h.
7189         * python/py-infevents.c: Do not include py-ref.h.
7190         * python/py-linetable.c: Do not include py-ref.h.
7191         * python/py-objfile.c: Do not include py-ref.h.
7192         * python/py-param.c: Do not include py-ref.h.
7193         * python/py-prettyprint.c: Do not include py-ref.h.
7194         * python/py-progspace.c: Do not include py-ref.h.
7195         * python/py-symbol.c: Do not include py-ref.h.
7196         * python/py-symtab.c: Do not include py-ref.h.
7197         * python/py-type.c: Do not include py-ref.h.
7198         * python/py-unwind.c: Do not include py-ref.h.
7199         * python/py-utils.c: Do not include py-ref.h.
7200         * python/py-value.c: Do not include py-ref.h.
7201         * python/py-varobj.c: Do not include py-ref.h.
7202         * python/py-xmethods.c: Do not include py-ref.h.
7203         * python/python.c: Do not include py-ref.h.
7204         * varobj.c: Do not include py-ref.h.
7205
7206 2019-01-22  Tom Tromey  <tom@tromey.com>
7207
7208         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7209         keyword for bcache.
7210
7211 2019-01-22  Tom Tromey  <tom@tromey.com>
7212
7213         * compile/compile-cplus-types.c: Remove a comment by #include.
7214
7215 2019-01-22  Tom Tromey  <tom@tromey.com>
7216
7217         * compile/gcc-c-plugin.h: Include compile-internal.h.
7218
7219 2019-01-22  Tom Tromey  <tom@tromey.com>
7220
7221         * stabsread.c (EXTERN): Do not define.
7222         (symnum, next_symbol_text_func, processing_gcc_compilation)
7223         (within_function, global_sym_chain, global_stabs)
7224         (previous_stab_code, this_object_header_files)
7225         (n_this_object_header_files)
7226         (n_allocated_this_object_header_files): Define.
7227         * stabsread.h (EXTERN): Never define.  Use "extern".
7228
7229 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7230
7231         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7232         history_value.
7233
7234 2019-01-21  Tom Tromey  <tom@tromey.com>
7235
7236         * ui-out.c: Fix includes.
7237         * tui/tui-source.c: Fix includes.
7238         * target.c: Fix includes.
7239         * remote.c: Fix includes.
7240         * regcache.c: Fix includes.
7241         * python/py-block.c: Fix includes.
7242         * printcmd.c: Fix includes.
7243         * or1k-tdep.c: Fix includes.
7244         * mi/mi-main.c: Fix includes.
7245         * m32r-tdep.c: Fix includes.
7246         * csky-tdep.c: Fix includes.
7247         * compile/compile-cplus-types.c: Fix includes.
7248         * cli/cli-interp.c: Fix includes.
7249
7250 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7251
7252         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7253         for padding.
7254
7255 2019-01-16  Tom Tromey  <tom@tromey.com>
7256
7257         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7258         earlier.
7259         (struct objfile) <msymbols_range>: Move from top level.
7260         <msymbols>: New method.
7261         (class objfile_msymbols): Remove.
7262         * symtab.c (default_collect_symbol_completion_matches_break_on):
7263         Update.
7264         * symmisc.c (dump_msymbols): Update.
7265         * stabsread.c (scan_file_globals): Update.
7266         * objc-lang.c (info_selectors_command, info_classes_command)
7267         (find_methods): Update.
7268         * minsyms.c (find_solib_trampoline_target): Update.
7269         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7270         * coffread.c (coff_symfile_read): Update.
7271         * ada-lang.c (ada_lookup_simple_minsym)
7272         (ada_collect_symbol_completion_matches): Update.
7273
7274 2019-01-16  Tom Tromey  <tom@tromey.com>
7275
7276         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7277         type.  Remove no-argument constructor.
7278         <iterator::operator++>: Simplify.
7279         <begin>: Update.
7280         <end>: Use minimal_symbol_count.
7281
7282 2019-01-16  Tom Tromey  <tom@tromey.com>
7283
7284         * objfiles.h (struct objfile) <psymtabs>: New method.
7285         (class objfile_psymtabs): Remove.
7286         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7287         typedef.
7288         <range>: New method.
7289         (require_partial_symbols): Change return type.
7290         * psymtab.c (require_partial_symbols)
7291         (psym_expand_symtabs_matching): Update.
7292         * mdebugread.c (parse_partial_symbols): Update.
7293         * dbxread.c (dbx_end_psymtab): Update.
7294
7295 2019-01-15  Tom Tromey  <tom@tromey.com>
7296
7297         * symtab.c (lookup_objfile_from_block)
7298         (lookup_symbol_in_objfile_symtabs)
7299         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7300         (find_line_symtab, info_sources_command)
7301         (default_collect_symbol_completion_matches_break_on)
7302         (make_source_files_completion_list): Update.
7303         * symmisc.c (print_objfile_statistics, dump_objfile)
7304         (maintenance_print_symbols, maintenance_info_symtabs)
7305         (maintenance_check_symtabs, maintenance_info_line_tables):
7306         Update.
7307         * source.c (select_source_symtab)
7308         (forget_cached_source_info_for_objfile): Update.
7309         * objfiles.h (class objfile_compunits): Remove.
7310         (struct objfile) <compunits_range>: New typedef.
7311         (compunits): New method.
7312         * objfiles.c (objfile_relocate1): Update.
7313         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7314         * maint.c (count_symtabs_and_blocks): Update.
7315         * linespec.c (iterate_over_all_matching_symtabs): Update.
7316         * cp-support.c (add_symbol_overload_list_qualified): Update.
7317         * coffread.c (coff_symtab_read): Update.
7318         * ada-lang.c (add_nonlocal_symbols)
7319         (ada_collect_symbol_completion_matches)
7320         (ada_add_global_exceptions): Update.
7321
7322 2019-01-15  Tom Tromey  <tom@tromey.com>
7323
7324         * progspace.h (program_space) <objfiles_safe_range>: New
7325         typedef.
7326         <objfiles_safe>: New method.
7327         * objfiles.h (class all_objfiles_safe): Remove.
7328         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7329         * jit.c (jit_inferior_exit_hook): Update.
7330
7331 2019-01-17  Tom Tromey  <tom@tromey.com>
7332
7333         * progspace.h (program_space) <objfiles_range>: New typedef.
7334         <objfiles>: New method.
7335         <objfiles_head>: Rename from objfiles.
7336         (object_files): Update.
7337         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7338         * guile/scm-pretty-print.c
7339         (ppscm_find_pretty_printer_from_objfiles): Update.
7340         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7341         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7342         Update.
7343         * python/py-progspace.c (pspy_get_objfiles): Update.
7344         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7345         Update.
7346         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7347         (objfpy_lookup_objfile_by_build_id): Update.
7348         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7349         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7350         Update.
7351         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7352         (expand_symtab_containing_pc, lookup_objfile_from_block)
7353         (lookup_static_symbol, basic_lookup_transparent_type)
7354         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7355         (find_line_symtab, info_sources_command)
7356         (default_collect_symbol_completion_matches_break_on)
7357         (make_source_files_completion_list, find_main_name): Update.
7358         * symmisc.c (print_symbol_bcache_statistics)
7359         (print_objfile_statistics, maintenance_print_symbols)
7360         (maintenance_print_msymbols, maintenance_print_objfiles)
7361         (maintenance_info_symtabs, maintenance_check_symtabs)
7362         (maintenance_expand_symtabs, maintenance_info_line_tables):
7363         Update.
7364         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7365         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7366         (map_overlay_command, unmap_overlay_command)
7367         (simple_overlay_update, expand_symtabs_matching)
7368         (map_symbol_filenames): Update.
7369         * symfile-debug.c (set_debug_symfile): Update.
7370         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7371         Update.
7372         * source.c (select_source_symtab, forget_cached_source_info):
7373         Update.
7374         * solib.c (solib_read_symbols): Update.
7375         * solib-spu.c (append_ocl_sos): Update.
7376         * psymtab.c (maintenance_print_psymbols)
7377         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7378         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7379         * printcmd.c (info_symbol_command): Update.
7380         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7381         Update.
7382         * objfiles.h (class all_objfiles): Remove.
7383         * objfiles.c (have_partial_symbols, have_full_symbols)
7384         (have_minimal_symbols, qsort_cmp, update_section_map)
7385         (shared_objfile_contains_address_p)
7386         (default_iterate_over_objfiles_in_search_order): Update.
7387         * objc-lang.c (info_selectors_command, info_classes_command)
7388         (find_methods): Update.
7389         * minsyms.c (find_solib_trampoline_target): Update.
7390         * maint.c (maintenance_info_sections)
7391         (maintenance_translate_address, count_symtabs_and_blocks):
7392         Update.
7393         * main.c (captured_main_1): Update.
7394         * linux-thread-db.c (try_thread_db_load_from_pdir)
7395         (has_libpthread): Update.
7396         * linespec.c (iterate_over_all_matching_symtabs)
7397         (search_minsyms_for_name): Update.
7398         * jit.c (jit_find_objf_with_entry_addr): Update.
7399         * hppa-tdep.c (find_unwind_entry)
7400         (hppa_lookup_stub_minimal_symbol): Update.
7401         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7402         Update.
7403         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7404         (elf_gnu_ifunc_resolve_by_got): Update.
7405         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7406         * dwarf-index-write.c (save_gdb_index_command): Update.
7407         * cp-support.c (add_symbol_overload_list_qualified): Update.
7408         * breakpoint.c (create_overlay_event_breakpoint)
7409         (create_longjmp_master_breakpoint)
7410         (create_std_terminate_master_breakpoint)
7411         (create_exception_master_breakpoint): Update.
7412         * blockframe.c (find_pc_partial_function): Update.
7413         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7414         (ada_collect_symbol_completion_matches)
7415         (ada_add_global_exceptions): Update.
7416
7417 2019-01-17  Tom Tromey  <tom@tromey.com>
7418
7419         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7420         declare VEC.
7421         (solib_target_parse_libraries): Change return type.
7422         (library_list_start_segment, library_list_start_section)
7423         (library_list_end_library, library_list_start_library); Update.
7424         (solib_target_free_library_list): Remove.
7425         (solib_target_parse_libraries): Remove cleanup.  Change return
7426         type.
7427         (solib_target_current_sos): Update.
7428
7429 2019-01-17  Tom Tromey  <tromey@bapiya>
7430
7431         * valprint.c: Replace "the the" with "the".
7432         * symtab.c: Replace "the the" with "the".
7433         * solib.c: Replace "the the" with "the".
7434         * solib-dsbt.c: Replace "the the" with "the".
7435         * linespec.c: Replace "the the" with "the".
7436         * dwarf2loc.h: Replace "the the" with "the".
7437         * amd64-windows-tdep.c: Replace "the the" with "the".
7438         * aarch64-tdep.c: Replace "the the" with "the".
7439
7440 2019-01-16  Keith Seitz  <keiths@redhat.com>
7441
7442         PR gdb/23773
7443         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7444         <builder>: Rename to ..
7445         <m_builder>: ... this and make private.
7446         (dwarf2_cu::get_builder): New method.  Change all users of
7447         `builder' to use this method.
7448         (dwarf2_start_symtab): Move to ...
7449         (dwarf2_cu::start_symtab): ... here.  Update all callers
7450         (setup_type_unit_groups): Move to ...
7451         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7452         callers.
7453         (dwarf2_cu::reset_builder): New method.
7454         (process_full_compunit, process_full_type_unit): Use
7455         dwarf2_cu::reset_builder.
7456         (follow_die_offset): Record the ancestor CU if it is different
7457         from the followed DIE's CU.
7458         (follow_die_sig_1): Likewise.
7459
7460 2019-01-15  Tom Tromey  <tom@tromey.com>
7461
7462         * remote.c (class remote_state) <buf>: Now a char_vector.
7463         <buf_size>: Remove.
7464         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7465         parameter.
7466         (remote_target::getpkt_or_notif_sane_1)
7467         (remote_target::getpkt_sane)
7468         (remote_target::getpkt_or_notif_sane): Likewise.
7469         (class remote_target) <putpkt>: New overload.
7470         (remote_target::read_frame): Change type of "buf_p".  Remove
7471         sizeof_p parameter.
7472         (packet_ok): New overload.
7473         (packet_check_result): New overload.
7474         Update all uses.
7475
7476 2019-01-14  Tom Tromey  <tom@tromey.com>
7477
7478         * remote-notif.c (handle_notification, remote_notif_ack)
7479         (remote_notif_parse): Make "buf" const.
7480         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7481         const.
7482         (remote_notif_parse, remote_notif_ack, handle_notification):
7483         Likewise.
7484         * remote.c (remote_notif_stop_parse): Make "buf" const.
7485         (remote_target::remote_parse_stop_reply): Make "buf" const.
7486         (remote_notif_stop_ack): Make "buf" const.
7487
7488 2019-01-14  Tom Tromey  <tom@tromey.com>
7489
7490         * remote.c (remote_console_output): Make parameter const.
7491
7492 2019-01-14  Tom Tromey  <tom@tromey.com>
7493
7494         * target-debug.h (target_debug_print_signals): Constify.
7495         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7496         * procfs.c (procfs_target::pass_signals): Update.
7497         * linux-nat.c (linux_nat_target::pass_signals): Update.
7498         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7499         * target-delegates.c: Rebuild.
7500         * remote.c (remote_target::program_signals): Update.
7501         (remote_target::pass_signals): Update.
7502         * target.c (target_pass_signals): Constify argument.
7503         (target_program_signals): Likewise.
7504         * target.h (struct target_ops) <pass_signals, program_signals>:
7505         Constify argument.
7506         (target_pass_signals, target_program_signals): Constify argument.
7507
7508 2019-01-14  Tom Tromey  <tom@tromey.com>
7509
7510         PR tui/28819:
7511         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7512
7513 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7514
7515         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7516         field.
7517         * rs6000-tdep.c: Include reggroups.h.
7518         (IS_V_ALIAS_PSEUDOREG): Define.
7519         (rs6000_register_name): Return names for the "vX" aliases.
7520         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7521         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7522         aliases.  Call default_register_reggroup_p for all other
7523         pseudo-registers.
7524         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7525         New functions.
7526         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7527         Handle "vX" aliases.
7528         (v_alias_pseudo_register_collect): New function.
7529         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7530         (rs6000_gdbarch_init): Initialize "vX" aliases as
7531         pseudo-registers.  Restore registration of
7532         rs6000_pseudo_register_reggroup_p with
7533         set_tdesc_pseudo_register_reggroup_p.
7534
7535 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7536
7537         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7538         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7539         set_gdbarch_num_pseudo_regs.
7540
7541 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7542
7543         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7544         Remove arg prefixname, add do_set and do_show.
7545         Add member functions set_list and show_list.
7546         * cli/cli-style.c (class cli_style_option): Update accordingly.
7547         (style_set_list): Move to file scope.
7548         (style_show_list): Likewise.
7549         (set_style): Call help_list.
7550         (show_style): Call cmd_show_list.
7551         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7552         Update to use the new macro.
7553
7554 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7555
7556         * ada-lang.c (_initialize_ada_language): Expand the help text
7557         for the "catch exception" command.
7558
7559 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7560
7561         * symtab.c (matching_obj_sections): Initialize obj,
7562         declare it closer to its usage.
7563
7564 2019-01-10  Tom Tromey  <tom@tromey.com>
7565
7566         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7567         (basic_inf_threads_range): Remove.
7568         (inf_threads_range, inf_non_exited_threads_range)
7569         (safe_inf_threads_range): Use next_adapter.
7570
7571 2019-01-10  Keith Seitz  <keiths@redhat.com>
7572
7573         PR gdb/23712
7574         PR symtab/23010
7575         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7576         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7577
7578 2019-01-10  Keith Seitz  <keiths@redhat.com>
7579
7580         PR gdb/23712
7581         PR symtab/23010
7582         * dictionary.c (pending_to_vector): Remove.
7583         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7584         Remove _1 suffix, replacing functions of the same name.  Update
7585         all callers.
7586         (dict_create_hashed, dict_create_hashed_expandable)
7587         (dict_create_linear, dict_create_linear_expandable, dict_free)
7588         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7589         Make functions static.
7590
7591 2019-01-10  Keith Seitz  <keiths@redhat.com>
7592
7593         PR gdb/23712
7594         PR symtab/23010
7595         * dictionary.h (struct dictionary): Replace declaration with
7596         multidictionary.
7597         (dict_create_hashed, dict_create_hashed_expandable)
7598         (dict_create_linear, dict_create_linear_expandable)
7599         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7600         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7601         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7602         taking multidictionary argument.
7603         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7604         * block.h (struct block) <dict>: Change to multidictionary
7605         and rename `multidict'.
7606         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7607         symmisc.c: Update all dictionary references to multidictionary.
7608
7609 2019-01-10  Keith Seitz  <keiths@redhat.com>
7610
7611         PR gdb/23712
7612         PR symtab/23010
7613         * dictionary.c: Include unordered_map.
7614         (pending_to_vector): New function.
7615         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7616         Rewrite the non-"_1" functions to take vector instead
7617         of linked list.
7618         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7619         "new" _1 versions of the same name.
7620         (multidictionary): Define.
7621         (std::hash<enum language): New definition.
7622         (collate_pending_symbols_by_language, mdict_create_hashed)
7623         (mdict_create_hashed_expandable, mdict_create_linear)
7624         (mdict_create_linear_expandable, mdict_free)
7625         (find_language_dictionary, create_new_language_dictionary)
7626         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7627         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7628         (mdict_size, mdict_empty): New functions.
7629         * dictionary.h (mdict_iterator): Define.
7630
7631 2019-01-10  Pedro Alves  <palves@redhat.com>
7632
7633         * breakpoint.c (read_uploaded_action)
7634         (create_tracepoint_from_upload): Adjust to use
7635         gdb::unique_xmalloc_ptr.
7636         * ctf.c (ctf_write_uploaded_tp):
7637         (SET_ARRAY_FIELD): Use emplace_back.
7638         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7639         * tracefile-tfile.c (tfile_write_uploaded_tp):
7640         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7641         gdb::unique_xmalloc_ptr.
7642         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7643         at_string, cond_string, cmd_strings>: Replace char pointers
7644         with gdb::unique_xmalloc_ptr.
7645
7646 2019-01-10  Pedro Alves  <palves@redhat.com>
7647
7648         * solib-target.c (library_list_start_library): Don't xstrdup name.
7649
7650 2019-01-10  Pedro Alves  <palves@redhat.com>
7651
7652         * mdebugread.c (parse_partial_symbols): Use
7653         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7654
7655 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7656
7657         * linux-fork.c (scoped_switch_fork_info)
7658         <~scoped_switch_fork_info>: Fix incorrect variable name.
7659
7660 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7661
7662         * linux-fork.c (scoped_switch_fork_info)
7663         <scoped_switch_fork_info>: Make explicit.
7664         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7665
7666 2019-01-10  Tom Tromey  <tom@tromey.com>
7667
7668         * objfiles.h (objfile::reset_psymtabs): Update.
7669         * objfiles.c (objfile::objfile): Update.
7670         * psymtab.h (psymtab_storage::obstack): Update.
7671         (psymtab_storage::m_obstack): Use gdb::optional.
7672         (class psymtab_storage): Update comment.  Remove objfile
7673         parameter.
7674         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7675
7676 2019-01-10  Tom Tromey  <tom@tromey.com>
7677
7678         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7679         <free_psymtabs>: Now private.
7680         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7681         (allocate_psymtab): Use new method.
7682
7683 2019-01-10  Tom Tromey  <tom@tromey.com>
7684
7685         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7686         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7687         * mdebugread.c (parse_partial_symbols): Use
7688         allocate_dependencies.
7689         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7690         allocate_dependencies.
7691         (process_psymtab_comp_unit_reader)
7692         (build_type_psymtab_dependencies): Likewise.
7693         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7694
7695 2019-01-10  Tom Tromey  <tom@tromey.com>
7696
7697         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7698         PSYMBOL_SET_LANGUAGE.
7699         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7700
7701 2019-01-10  Tom Tromey  <tom@tromey.com>
7702
7703         * psymtab.h (psymtab_storage::obstack): New method.
7704         <m_obstack>: Rename from obstack; now private.
7705         * psymtab.c (psymtab_storage): Update.
7706         * dwarf2read.c (create_addrmap_from_index)
7707         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7708         Update.
7709
7710 2019-01-10  Tom Tromey  <tom@tromey.com>
7711
7712         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7713         * objfiles.h (objfile::reset_psymtabs): New method.
7714
7715 2019-01-10  Tom Tromey  <tom@tromey.com>
7716
7717         * symmisc.c (print_symbol_bcache_statistics): Update.
7718         (print_objfile_statistics): Update.
7719         * symfile.c (reread_symbols): Update.
7720         * psymtab.h (class psymtab_storage): New.
7721         * psymtab.c (psymtab_storage): New constructor.
7722         (~psymtab_storage): New destructor.
7723         (require_partial_symbols): Update.
7724         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7725         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7726         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7727         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7728         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7729         (start_psymtab_common, end_psymtab_common)
7730         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7731         (allocate_psymtab): Update.
7732         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7733         Update.
7734         (dump_psymtab_addrmap, maintenance_print_psymbols)
7735         (maintenance_check_psymtabs): Update.
7736         (class objfile_psymtabs): Move to objfiles.h.
7737         * psympriv.h (discard_psymtab): Now inline.
7738         (psymtab_discarder::psymtab_discarder): Update.
7739         (psymtab_discarder::~psymtab_discarder): Update.
7740         (ALL_OBJFILE_PSYMTABS): Rewrite.
7741         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7742         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7743         Remove fields.
7744         <partial_symtabs>: New field.
7745         (class objfile_psymtabs): Move from psymtab.h.  Update.
7746         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7747         psymbol_cache.
7748         (objfile::~objfile): Don't destroy psymbol_cache.
7749         * mdebugread.c (parse_partial_symbols): Update.
7750         * dwarf2read.c (create_addrmap_from_index)
7751         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7752         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7753         (add_partial_subprogram, dwarf2_ranges_read): Update.
7754         * dwarf-index-write.c (write_address_map)
7755         (write_one_signatured_type, recursively_write_psymbols)
7756         (class debug_names, class debug_names, write_psymtabs_to_index):
7757         Update.
7758
7759 2019-01-10  Tom Tromey  <tom@tromey.com>
7760
7761         * symtab.h (SYMBOL_SET_NAMES): Update.
7762         (symbol_set_names): Update.
7763         (MSYMBOL_SET_NAMES): Update.
7764         * symtab.c (symbol_set_names): Change argument to be an
7765         objfile_per_bfd_storage.
7766         * psymtab.c (add_psymbol_to_bcache): Update.
7767         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7768
7769 2019-01-10  Tom Tromey  <tom@tromey.com>
7770
7771         * symtab.c (create_demangled_names_hash): Change argument to be an
7772         objfile_per_bfd_storage.
7773         (symbol_set_names): Update.
7774
7775 2019-01-10  Tom Tromey  <tom@tromey.com>
7776
7777         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7778         init_psymbol_list.
7779         * psymtab.c (init_psymbol_list): Do nothing if already called.
7780         * psympriv.h (init_psymbol_list): Add comment.
7781         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7782         init_psymbol_list.
7783         * dbxread.c (dbx_symfile_read): Unconditionally call
7784         init_psymbol_list.
7785
7786 2019-01-10  Tom Tromey  <tom@tromey.com>
7787
7788         * xcoffread.c (scan_xcoff_symtab): Update.
7789         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7790         "where".
7791         * mdebugread.c (parse_partial_symbols)
7792         (handle_psymbol_enumerators): Update.
7793         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7794         * dbxread.c (read_dbx_symtab): Update.
7795         * psympriv.h (psymbol_placement): New enum.
7796         (add_psymbol_to_list): Update.
7797
7798 2019-01-10  Tom Tromey  <tom@tromey.com>
7799
7800         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7801         static_psymbols parameters.
7802         (scan_xcoff_symtab): Update.
7803         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7804         static_psymbols parameters.
7805         * psympriv.h (start_psymtab_common): Update.
7806         * mdebugread.c (parse_partial_symbols): Update.
7807         * dwarf2read.c (create_partial_symtab): Update.
7808         * dbxread.c (read_dbx_symtab): Update.
7809         (start_psymtab): Remove global_psymbols and static_psymbols
7810         parameters.
7811
7812 2019-01-10  Tom Tromey  <tom@tromey.com>
7813
7814         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7815         * psymtab.c (allocate_psymtab): Add comment.
7816         * psympriv.h (allocate_psymtab): Add comment.
7817         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7818         initializations.
7819         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7820
7821 2019-01-10  Tom Tromey  <tom@tromey.com>
7822
7823         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7824         Don't declare.
7825         * mipsread.c: Include mdebugread.h.
7826         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7827         Declare.
7828         * elfread.c: Include mdebugread.h.
7829
7830 2019-01-09  Tom Tromey  <tom@tromey.com>
7831
7832         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7833         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7834         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7835         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7836         (psym_lookup_symbol, psym_find_last_source_symtab)
7837         (psym_forget_cached_source_info, psym_print_stats)
7838         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7839         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7840         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7841         (psym_find_compunit_symtab_by_address)
7842         (maintenance_print_psymbols, maintenance_info_psymtabs)
7843         (maintenance_check_psymtabs): Use ranged for.
7844         * psymtab.h (class objfile_psymtabs): New.
7845         (require_partial_symbols): Return objfile_psymtabs.
7846         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7847
7848 2019-01-09  Tom Tromey  <tom@tromey.com>
7849
7850         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7851         (find_pc_mapped_section, list_overlays_command)
7852         (map_overlay_command, unmap_overlay_command)
7853         (simple_overlay_update): Use all_objfiles.
7854         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7855         * printcmd.c (info_symbol_command): Use all_objfiles.
7856         * objfiles.h (ALL_OBJSECTIONS): Remove.
7857         * maint.c (maintenance_translate_address): Use all_objfiles.
7858         * gcore.c (gcore_create_callback): Use all_objfiles.
7859         (objfile_find_memory_regions): Likewise.
7860
7861 2019-01-09  Tom Tromey  <tom@tromey.com>
7862
7863         * symtab.c (find_line_symtab, info_sources_command)
7864         (make_source_files_completion_list): Use objfile_compunits.
7865         * source.c (select_source_symtab): Use objfile_compunits.
7866         * objfiles.h (struct objfile): Update comment.
7867         (ALL_OBJFILES): Remove.
7868         (ALL_FILETABS): Remove.
7869         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7870         objfile_compunits.
7871
7872 2019-01-09  Tom Tromey  <tom@tromey.com>
7873
7874         * symmisc.c (print_objfile_statistics, dump_objfile)
7875         (maintenance_print_symbols): Use compunit_filetabs.
7876         * source.c (forget_cached_source_info_for_objfile): Use
7877         compunit_filetabs.
7878         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7879         (ALL_FILETABS): Use compunit_filetabs.
7880         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7881         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7882
7883 2019-01-09  Tom Tromey  <tom@tromey.com>
7884
7885         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7886         (compunit_filetabs): New.
7887         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7888         compunit_filetabs.
7889         (info_sources_command, make_source_files_completion_list): Remove
7890         declaration.
7891         * symmisc.c (print_objfile_statistics, dump_objfile)
7892         (maintenance_print_symbols): Remove declaration.
7893         (maintenance_info_symtabs): Use compunit_filetabs.
7894         (maintenance_info_line_tables): Likewise.
7895         * source.c (select_source_symtab): Change local variable name.
7896         (forget_cached_source_info_for_objfile): Remove declaration.
7897         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7898         * objfiles.c (objfile_relocate1): Remove declaration.
7899         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7900         declaration.
7901         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7902         * coffread.c (coff_symtab_read): Remove declaration.
7903         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7904         compunit_filetabs.
7905
7906 2019-01-09  Tom Tromey  <tom@tromey.com>
7907
7908         * symtab.c (lookup_objfile_from_block)
7909         (find_pc_sect_compunit_symtab, search_symbols)
7910         (default_collect_symbol_completion_matches_break_on): Use
7911         objfile_compunits.
7912         * objfiles.h (ALL_COMPUNITS): Remove.
7913         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7914         * cp-support.c (add_symbol_overload_list_qualified): Use
7915         objfile_compunits.
7916         * ada-lang.c (ada_collect_symbol_completion_matches)
7917         (ada_add_global_exceptions): Use objfile_compunits.
7918
7919 2019-01-09  Tom Tromey  <tom@tromey.com>
7920
7921         * source.c (select_source_symtab)
7922         (forget_cached_source_info_for_objfile): Remove declaration.
7923         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7924         declaration.
7925         * maint.c (count_symtabs_and_blocks): Remove declaration.
7926         * cp-support.c (add_symbol_overload_list_qualified): Remove
7927         declaration.
7928         * coffread.c (coff_symtab_read): Remove declaration.
7929         * symtab.c (lookup_symbol_in_objfile_symtabs)
7930         (basic_lookup_transparent_type_1): Use objfile_compunits.
7931         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7932         (info_sources_command, search_symbols)
7933         (default_collect_symbol_completion_matches_break_on)
7934         (make_source_files_completion_list): Remove declaration.
7935         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7936         (ada_collect_symbol_completion_matches)
7937         (ada_add_global_exceptions): Remove declaration.
7938         * linespec.c (iterate_over_all_matching_symtabs): Use
7939         objfile_compunits.
7940         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7941         (class objfile_compunits): New.
7942         (ALL_COMPUNITS): Use objfile_compunits.
7943         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7944         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7945         objfile_compunits.
7946         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7947
7948 2019-01-09  Tom Tromey  <tom@tromey.com>
7949
7950         * symtab.c (search_symbols)
7951         (default_collect_symbol_completion_matches_break_on): Use
7952         objfile_msymbols.
7953         * ada-lang.c (ada_lookup_simple_minsym)
7954         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7955         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7956         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7957         objfile_msymbols.
7958         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7959         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7960         * objc-lang.c (find_methods): Use objfile_msymbols.
7961         (info_selectors_command, info_classes_command): Likewise.
7962         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7963         * objfiles.h (class objfile_msymbols): New.
7964         (ALL_OBJFILE_MSYMBOLS): Remove.
7965         (ALL_MSYMBOLS): Remove.
7966
7967 2019-01-09  Tom Tromey  <tom@tromey.com>
7968
7969         * common/next-iterator.h (next_adapter): Add Iterator template
7970         parameter.
7971         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7972         (class all_objfiles_safe): New.
7973         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7974         * objfiles.c (put_objfile_before): Update comment.
7975         (add_separate_debug_objfile): Likewise.
7976         (free_all_objfiles): Use all_objfiles_safe.
7977         (objfile_purge_solibs): Likewise.
7978
7979 2019-01-09  Tom Tromey  <tom@tromey.com>
7980
7981         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7982         (expand_symtab_containing_pc, lookup_static_symbol)
7983         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7984         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7985         all_objfiles.
7986         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7987         * breakpoint.c (create_overlay_event_breakpoint)
7988         (create_longjmp_master_breakpoint)
7989         (create_std_terminate_master_breakpoint)
7990         (create_exception_master_breakpoint): Use all_objfiles.
7991         * linux-thread-db.c (try_thread_db_load_from_pdir)
7992         (has_libpthread): Use all_objfiles.
7993         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7994         * linespec.c (iterate_over_all_matching_symtabs)
7995         (search_minsyms_for_name): Use all_objfiles.
7996         * maint.c (maintenance_info_sections): Use all_objfiles.
7997         * main.c (captured_main_1): Use all_objfiles.
7998         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7999         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8000         * guile/scm-pretty-print.c
8001         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8002         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8003         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8004         (maintenance_print_msymbols): Use all_objfiles.
8005         * source.c (select_source_symtab): Use all_objfiles.
8006         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8007         * symfile.c (remove_symbol_file_command)
8008         (expand_symtabs_matching, map_symbol_filenames): Use
8009         all_objfiles.
8010         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8011         all_objfiles.
8012         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8013         * objc-lang.c (find_methods): Use all_objfiles.
8014         * objfiles.c (have_partial_symbols, have_full_symbols)
8015         (have_minimal_symbols, qsort_cmp)
8016         (default_iterate_over_objfiles_in_search_order): Use
8017         all_objfiles.
8018         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8019         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8020         (maintenance_check_psymtabs): Use all_objfiles.
8021         (ALL_PSYMTABS): Remove.
8022         * compile/compile-object-run.c (do_module_cleanup): Use
8023         all_objfiles.
8024         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8025         * cp-support.c (add_symbol_overload_list_qualified): Use
8026         all_objfiles.
8027         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8028         Use all_objfiles.
8029         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8030         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8031         all_objfiles.
8032         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8033         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8034         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8035         Uses all_objfiles.
8036         * solib.c (solib_read_symbols): Use all_objfiles
8037
8038 2019-01-09  Tom Tromey  <tom@tromey.com>
8039
8040         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8041         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8042         all_objfiles.
8043         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8044         * symmisc.c (print_symbol_bcache_statistics)
8045         (print_objfile_statistics, maintenance_print_objfiles)
8046         (maintenance_info_symtabs, maintenance_check_symtabs)
8047         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8048         all_objfiles.
8049         * source.c (forget_cached_source_info): Use all_objfiles.
8050         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8051         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8052         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8053         * objfiles.c (update_section_map): Use all_objfiles.
8054         (shared_objfile_contains_address_p): Likewise.
8055         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8056         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8057
8058 2019-01-09  Tom Tromey  <tom@tromey.com>
8059
8060         * common/next-iterator.h: New file.
8061         * objfiles.h (class all_objfiles): New.
8062         (struct objfile_iterator): New.
8063
8064 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8065
8066         * NEWS: Move the description of the changed "frame", "select-frame",
8067          and "info frame" commands to the Changed commands section.
8068
8069 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8070
8071         * gdbtypes.c (check_stub_method_group): Remove handling of old
8072         mangling schemes.
8073         * linespec.c (find_methods): Likewise.
8074         * stabsread.c (read_member_functions): Likewise.
8075         * valops.c (search_struct_method): Likewise.
8076         (value_struct_elt_for_reference): Likewise.
8077         * NEWS: Mention this change.
8078
8079 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8080
8081         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8082         print_source_lines.
8083         * source.c (print_source_lines_base): Update line number check.
8084         (print_source_lines): New function.
8085         (source_lines_range::source_lines_range): New function.
8086         * source.h (class source_lines_range): New class.
8087         (print_source_lines): New declaration.
8088
8089 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8090
8091         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8092
8093 2019-01-08  Tom Tromey  <tom@tromey.com>
8094             Simon Marchi  <simon.marchi@ericsson.com>
8095
8096         PR gdb/24060
8097         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8098         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8099         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8100         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8101         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8102         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8103
8104 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8105
8106         * source.c (select_source_symtab): Move header comment to
8107         declaration in source.h.
8108         (forget_cached_source_info_for_objfile): Likewise.
8109         (forget_cached_source_info): Likewise.
8110         (identify_source_line): Likewise.
8111         * source.h (identify_source_line): Move declaration from symtab.h
8112         and add comment from source.c
8113         (print_source_lines): Likewise.
8114         (forget_cached_source_info_for_objfile): Likewise.
8115         (forget_cached_source_info): Likewise.
8116         (select_source_symtab): Likewise.
8117         (enum print_source_lines_flag): Move definition from symtab.h.
8118         * symtab.h (identify_source_line): Move declaration to source.h.
8119         (print_source_lines): Likewise.
8120         (forget_cached_source_info_for_objfile): Likewise.
8121         (forget_cached_source_info): Likewise.
8122         (select_source_symtab): Likewise.
8123         (enum print_source_lines_flag): Move definition to source.h.
8124         * tui/tui-hooks.c: Add 'source.h' include.
8125
8126 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8127
8128         * source.c (print_source_lines_base): Handle requests to print
8129         reverse line number sequences, and guard against empty lines
8130         string.
8131
8132 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8133
8134         * source.c (print_source_lines_base): Fix skip of '\r' if next
8135         character is '\n'.
8136
8137 2019-01-06  Tom Tromey  <tom@tromey.com>
8138
8139         * c-exp.y (struct c_parse_state) <macro_original_text,
8140         expansion_obstack>: New member.
8141         (macro_original_text, expansion_obstack): Remove globals.
8142         (scan_macro_expansion, scanning_macro_expansion)
8143         (finished_macro_expansion): Update.
8144         (scan_macro_cleanup): Remove.
8145         (yylex, c_parse): Update.
8146
8147 2019-01-06  Tom Tromey  <tom@tromey.com>
8148
8149         * c-exp.y (struct c_parse_state) <strings>: New member.
8150         (operator_stoken): Update.
8151
8152 2019-01-06  Tom Tromey  <tom@tromey.com>
8153
8154         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8155         (union type_stack_elt) <typelist_val>: Now a pointer to
8156         std::vector.
8157         (type_stack_cleanup): Don't declare.
8158         (push_typelist): Update.
8159         * parse.c (pop_typelist): Return a std::vector.
8160         (push_typelist): Take a std::vector.
8161         (follow_types): Update.  Do not free args.
8162         (type_stack_cleanup): Remove.
8163         * c-exp.y (struct c_parse_state): New.
8164         (cpstate): New global.
8165         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8166         (nonempty_typelist): Update.
8167         (func_mod): Create a new vector.
8168         (c_parse): Create a c_parse_state.
8169         (check_parameter_typelist): Do not delete params.
8170         (function_method): Update.  Do not delete type_list.
8171
8172 2019-01-06  Tom Tromey  <tom@tromey.com>
8173
8174         PR gdb/28155:
8175         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8176         check_typedef.
8177         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8178         (print_return_value): Likewise.
8179
8180 2019-01-05  Tom Tromey  <tom@tromey.com>
8181
8182         * contrib/cleanup_check.py: Remove.
8183         * contrib/gcc-with-excheck: Remove.
8184         * contrib/exsummary.py: Remove.
8185         * contrib/excheck.py: Remove.
8186
8187 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8188
8189         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8190         NULL. Initialize tpprev to NULL instead of assigning it
8191         to NULL on the next statement.
8192         * windows-nat.c (windows_delete_thread): Remove check for
8193         main_thread_id before printing thread exit notifications.
8194         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8195         Remove thread ID check against main_thread_id.
8196         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8197         windows_delete_thread.
8198         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8199
8200 2019-01-04  Tom Tromey  <tom@tromey.com>
8201
8202         * compile/compile.c (_initialize_compile): Use upper case for
8203         metasyntactic variables.
8204         * symmisc.c (_initialize_symmisc): Use upper case for
8205         metasyntactic variables.
8206         * psymtab.c (_initialize_psymtab): Use upper case for
8207         metasyntactic variables.
8208         * demangle.c (demangle_command): Use upper case for metasyntactic
8209         variables.
8210         (_initialize_demangler): Likewise.
8211         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8212         variables.
8213
8214 2019-01-03  Tom Tromey  <tom@tromey.com>
8215
8216         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8217
8218 2019-01-03  Tom Tromey  <tom@tromey.com>
8219
8220         * python/py-symtab.c (salpy_str): Update.
8221         (struct salpy_sal_object) <symtab>: Now a PyObject.
8222         (salpy_dealloc): Update.
8223         (del_objfile_sal): Use gdbpy_ref.
8224
8225 2019-01-03  Tom Tromey  <tom@tromey.com>
8226
8227         * python/py-type.c (convert_field): Use new_reference.  Return
8228         gdbpy_ref.
8229         (make_fielditem): Return gdbpy_ref.
8230         (typy_fields): Update.
8231         (typy_getitem): Update.
8232         (field_name): Return gdbpy_ref.  Use new_reference.
8233         (typy_iterator_iternext): Update.
8234
8235 2019-01-03  Tom Tromey  <tom@tromey.com>
8236
8237         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8238
8239 2019-01-03  Tom Tromey  <tom@tromey.com>
8240
8241         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8242         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8243         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8244         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8245         (pspy_set_type_printers): Likewise.
8246         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8247         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8248         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8249         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8250         (objfpy_set_type_printers): Likewise.
8251
8252 2019-01-03  Tom Tromey  <tom@tromey.com>
8253
8254         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8255         (gdbpy_print_stack): Use gdbpy_err_fetch.
8256         * python/python-internal.h (class gdbpy_err_fetch): New class.
8257         (class gdbpy_enter) <m_error_type, m_error_value,
8258         m_error_traceback>: Remove.
8259         <m_error>: New member.
8260         (gdbpy_exception_to_string): Don't declare.
8261         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8262         * python/py-value.c (convert_value_from_python): Use
8263         gdbpy_err_fetch.
8264         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8265         gdbpy_exception_to_string.
8266         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8267         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8268         gdbpy_err_fetch.
8269
8270 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8271
8272         * linux-nat.c (delete_lwp_cleanup): Delete.
8273         (struct lwp_deleter): New struct.
8274         (lwp_info_up): New typedef.
8275         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8276         lwp_info_up.
8277
8278 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8279
8280         * linux-fork.c (class scoped_switch_fork_info): New class.
8281         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8282
8283 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8284
8285         * valops.c (find_overload_match): Remove use of null_cleanup, and
8286         calls to do_cleanups.
8287
8288 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8289
8290         * compile/compile-cplus-types.c
8291         (compile_cplus_instance::decl_name): Handle changes to
8292         cp_func_name.
8293         * cp-support.c (cp_func_name): Update header comment, update
8294         return type.
8295         * cp-support.h (cp_func_name): Update return type in declaration.
8296         * valops.c (find_overload_match): Move temp_func local to top
8297         level of function and change its type.  Use temp_func to hold and
8298         delete temporary string obtained from cp_func_name.
8299
8300 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8301
8302         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8303         gdb::char_vector, remove cleanup, and update uses of `msg`.
8304
8305 2019-01-03  Jim Wilson  <jimw@sifive.com>
8306
8307         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8308
8309 2019-01-02  Tom Tromey  <tom@tromey.com>
8310
8311         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8312         (tdesc_parse_xml): Remove cleanups.
8313         * target-descriptions.h (make_cleanup_free_target_description):
8314         Don't declare.
8315         (target_desc_deleter): New struct.
8316         (target_desc_up): New typedef.
8317         * target-descriptions.c (target_desc_deleter::operator()): Rename
8318         from free_target_description.
8319         (make_cleanup_free_target_description): Remove.
8320
8321 2019-01-02  Tom Tromey  <tom@tromey.com>
8322
8323         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8324         constructor, destructor.
8325         (linespec_parser): Remove typedef.
8326         (~linespec_parser): Rename from linespec_parser_delete.
8327         (linespec_lex_to_end, linespec_complete_label)
8328         (linespec_complete): Update.
8329         (decode_line_full): Remove cleanups.
8330         (decode_line_1): Update.
8331
8332 2019-01-02  Tom Tromey  <tom@tromey.com>
8333
8334         * python/python-internal.h (inferior_to_inferior_object): Change
8335         return type.
8336         * python/py-exitedevent.c (create_exited_event_object): Update.
8337         * python/py-inferior.c (inferior_to_inferior_object): Return
8338         gdbpy_ref.
8339         (python_new_inferior, python_inferior_deleted)
8340         (thread_to_thread_object, delete_thread_object)
8341         (build_inferior_list, gdbpy_selected_inferior): Update.
8342         * python/py-infthread.c (create_thread_object): Update.  Also fail
8343         if inferior_to_inferior_object fails.
8344
8345 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8346
8347         * inferior.h (class inferior) <displaced_step_state>: New field.
8348         * infrun.h (struct displaced_step_state): Move here from
8349         infrun.c.  Initialize fields, add constructor.
8350         <inf>: Remove field.
8351         <reset>: New method.
8352         * infrun.c (struct displaced_step_inferior_state): Move to
8353         infrun.h.
8354         (displaced_step_inferior_states): Remove.
8355         (get_displaced_stepping_state): Adust.
8356         (displaced_step_in_progress_any_inferior): Adjust.
8357         (displaced_step_in_progress_thread): Adjust.
8358         (displaced_step_in_progress): Adjust.
8359         (add_displaced_stepping_state): Remove.
8360         (get_displaced_step_closure_by_addr): Adjust.
8361         (remove_displaced_stepping_state): Remove.
8362         (infrun_inferior_exit): Call displaced_step_state.reset.
8363         (use_displaced_stepping): Don't check for NULL.
8364         (displaced_step_prepare_throw): Call
8365         get_displaced_stepping_state.
8366         (displaced_step_fixup): Don't check for NULL.
8367         (prepare_for_detach): Don't check for NULL.
8368
8369 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8370
8371         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8372          in case of call that did not complete.
8373
8374 2019-01-02  Andrey Utkin  <autkin@undo.io>
8375
8376         * symfile.c (find_separate_debug_file): Fix search of debug files for
8377         remote debuggee.
8378
8379 2019-01-02  Tom Tromey  <tom@tromey.com>
8380
8381         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8382         indentation.
8383         * python/py-frame.c (frapy_older): Remove cast.
8384         (frapy_newer): Likewise.
8385         * python/py-breakpoint.c (local_setattro): Remove cast.
8386         * python/py-arch.c (archpy_name): Remove local variable.
8387         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8388
8389 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8390
8391         * unittests/basic_string_view/element_access/char/empty.cc:
8392         Fix year range in copyright header.
8393
8394 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8395
8396         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8397         Delete.
8398         <operator==>: Update with for removed field.
8399         <hash>: Likewise.
8400         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8401         <isa_features>: ...this.
8402         <abi_features>: New field.
8403         (riscv_isa_flen): Update comment.
8404         (riscv_abi_xlen): New declaration.
8405         (riscv_abi_flen): New declaration.
8406         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8407         isa_features.
8408         (riscv_abi_xlen): New function.
8409         (riscv_isa_flen): Update to get answer from isa_features.
8410         (riscv_abi_flen): New function.
8411         (riscv_has_fp_abi): Update to get answer from abi_features.
8412         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8413         xlen and flen.
8414         (riscv_call_info) <xlen, flen>: Update comment.
8415         (riscv_call_arg_struct): Remove invalid assertions
8416         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8417         is removed.
8418         (riscv_gdbarch_init): Gather isa features and abi features
8419         separately, ensure both match on the gdbarch when reusing an old
8420         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8421         a target with 64-bit float hardware.
8422
8423 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8424
8425         * source.c (search_command_helper): Stop reverse search
8426         when line 1 has been searched.
8427
8428 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8429
8430         * record-full.c (record_full_base_target::close): Rewrite
8431         record_full_core_buf_list free logic.
8432
8433 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8434
8435         * break-catch-syscall.c (print_one_catch_syscall): xfree
8436         the last text.
8437
8438 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8439
8440         * top.c (print_gdb_version): Update Copyright year in version
8441         message.
8442
8443 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8444
8445         Update copyright year range in all GDB files.
8446
8447 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8448
8449         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8450
8451 For older changes see ChangeLog-2018.
8452 \f
8453 Local Variables:
8454 mode: change-log
8455 left-margin: 8
8456 fill-column: 74
8457 version-control: never
8458 coding: utf-8
8459 End:
8460