gdb/ChangeLog

   1 2019-03-19  Pedro Alves  <palves@redhat.com>
   2
   3         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
   4         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
   5         to -1.  Fix TABs vs spaces.
   6         (tui_ui_out::tui_ui_out): Don't initialize fields here.
   7         * tui/tui-out.h (tui_ui_out) Add intro comments.
   8         <m_line, m_start_of_line>: In-class initialize, and add describing
   9         comment.
  10
  11 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
  12
  13         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
  14         variable names.
  15         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
  16
  17 2019-03-18  Pedro Alves  <palves@redhat.com>
  18             Eli Zaretskii <eliz@gnu.org>
  19
  20         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
  21         m_line and m_start_of_line.
  22
  23 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
  24
  25         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
  26         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
  27         it returns a newline.  This fixes a regression in TU mode, whereby
  28         the next line is output on the same screen line as the user input.
  29
  30 2019-03-18  Tom Tromey  <tromey@adacore.com>
  31
  32         * minsyms.c (minimal_symbol_reader::install): Remove call to
  33         obstack_blank.
  34
  35 2019-03-18  Pedro Alves  <palves@redhat.com>
  36
  37         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
  38         New globals.
  39         (apply_style): New, factored out from ...
  40         (apply_ansi_escape): ... this.  Handle reverse video mode.
  41         (tui_set_reverse_mode): New function.
  42         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
  43         * tui/tui-winsource.c (tui_show_source_line): Use
  44         tui_set_reverse_mode instead of setting A_STANDOUT.
  45         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
  46         New setter methods.
  47
  48 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
  49
  50         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
  51         Handle tabs.
  52
  53 2019-03-18  Tom Tromey  <tromey@adacore.com>
  54
  55         * ada-lang.c (empty_array): Add "high" parameter.
  56         (ada_evaluate_subexp): Update.
  57
  58 2019-03-17  Sergei Trofimovich <siarheit@google.com>
  59
  60         * unittests/string_view-selftests.c: Define
  61         _initialize_string_view_selftests unconditionally.
  62
  63 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
  64
  65         PR gdb/24350
  66         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
  67
  68 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
  69
  70         PR gdb/24351
  71         * windows-nat.c (display_selector): Fix format specifiers.
  72
  73 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
  74
  75         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
  76         tui_refill_source_window instead of tui_refresh_win, to update the
  77         current execution line.  This fixes redisplay of the current line
  78         when stepping through the code with "next" or "step".
  79
  80 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  81
  82         * source-cache.c (source_cache::get_source_lines): Call
  83         find_source_lines to initialize s->nlines.  This fixes vertical
  84         scrolling of TUI source window when the DOWN arrow is pressed.
  85
  86 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  87
  88         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
  89         linux-thread-db.c (_initialize_thread_db): Likewise.
  90
  91 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  92
  93         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  94         wclrtoeol in tui_show_source_line".  This reverts changes made in
  95         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  96
  97 2019-03-15  Tom Tromey  <tom@tromey.com>
  98
  99         * symtab.h (struct minimal_symbol): Derive from
 100         general_symbol_info.
 101         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 102         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 103         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 104         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 105         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 106         (MSYMBOL_SEARCH_NAME): Update.
 107         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 108         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 109         * minsyms.c (minimal_symbol_reader::record_full): Update.
 110
 111 2019-03-15  Tom Tromey  <tom@tromey.com>
 112
 113         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 114
 115 2019-03-15  Tom Tromey  <tom@tromey.com>
 116
 117         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 118         unique_xmalloc_ptr.
 119         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 120         Update.
 121         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 122         (build_minimal_symbol_hash_tables)
 123         (minimal_symbol_reader::install): Update.
 124
 125 2019-03-15  Tom Tromey  <tom@tromey.com>
 126
 127         * symtab.c (create_demangled_names_hash): Update.
 128         (symbol_set_names): Update.
 129         * objfiles.h (struct objfile_per_bfd_storage)
 130         <demangled_names_hash>: Now an htab_up.
 131         * objfiles.c (objfile_per_bfd_storage): Simplify.
 132
 133 2019-03-15  Tom Tromey  <tom@tromey.com>
 134
 135         * objfiles.h (struct objfile_per_bfd_storage): Declare
 136         destructor.
 137         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 138         New.
 139         (get_objfile_bfd_data): Use new.  Don't initialize
 140         language_of_main.
 141         (free_objfile_per_bfd_storage): Remove.
 142         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 143
 144 2019-03-15  Tom Tromey  <tom@tromey.com>
 145
 146         * symfile.c (reread_symbols): Update.
 147         * objfiles.c (objfile::objfile): Update.
 148         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 149         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 150         comment.
 151         (minimal_symbol_reader::install): Update.
 152         (terminate_minimal_symbol_table): Remove.
 153         * jit.c (jit_object_close_impl): Update.
 154
 155 2019-03-15  Tom Tromey  <tom@tromey.com>
 156
 157         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 158         initializations.
 159
 160 2019-03-15  Tom Tromey  <tom@tromey.com>
 161
 162         * objfiles.h (struct objfile_per_bfd_storage)
 163         <demangled_hash_languages>: Now a bitset.
 164         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 165         (lookup_minimal_symbol): Update.
 166
 167 2019-03-15  Tom Tromey  <tom@tromey.com>
 168
 169         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 170         Don't return the symbol.
 171         * coffread.c (record_minimal_symbol): Use record_full.
 172
 173 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 174
 175         The MS-Windows port of ncurses fails to switch to a color pair if
 176         one or both of the colors are the implicit default colors.  This
 177         change records the default colors when TUI is initialized, and
 178         then specifies them explicitly when a color pair uses the default
 179         colors.  This allows color styling in TUI mode on MS-Windows.
 180
 181         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 182         ncurses_norm_attr.
 183         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 184         colors in ncurses_norm_attr.
 185         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 186         "none", replace it with the default color recorded in
 187         ncurses_norm_attr.
 188
 189 2019-03-14  Tom Tromey  <tromey@adacore.com>
 190
 191         * source-cache.h (class source_cache) <get_source_lines>: Return
 192         std::string.
 193         * source-cache.c (source_cache::extract_lines): Handle case where
 194         first_pos==npos.  Return std::string.
 195         (source_cache::get_source_lines): Update.
 196
 197 2019-03-14  Tom Tromey  <tromey@adacore.com>
 198
 199         * NEWS: Add item for "style sources" commands.
 200         * source-cache.c (source_cache::get_source_lines): Check
 201         source_styling.
 202         * cli/cli-style.c (source_styling): New global.
 203         (_initialize_cli_style): Add "style sources" commands.
 204         (show_style_sources): New function.
 205         * cli/cli-style.h (source_styling): Declare.
 206
 207 2019-03-14  Pedro Alves  <palves@redhat.com>
 208             Tom Tromey  <tromey@adacore.com>
 209
 210         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 211         * tui/tui-winsource.c (tui_refill_source_window): New function,
 212         from...
 213         (tui_horizontal_source_scroll): ... here.  Move some logic.
 214         * cli/cli-style.c (set_style_enabled): Notify new observable.
 215         * tui/tui-hooks.c (tui_redisplay_source): New function.
 216         (tui_attach_detach_observers): Attach or detach
 217         tui_redisplay_source.
 218         * observable.h (source_styling_changed): New observable.
 219         * observable.c: Define source_styling_changed observable.
 220
 221 2019-03-13  Tom Tromey  <tromey@adacore.com>
 222
 223         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 224         (i386_gnu_nat_target::store_registers): Update.
 225         * target-debug.h (target_debug_print_std_string): New macro.
 226         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 227         * windows-tdep.c (display_one_tib): Update.
 228         * tui/tui-stack.c (tui_make_status_line): Update.
 229         * top.c (print_inferior_quit_action): Update.
 230         * thread.c (thr_try_catch_cmd): Update.
 231         (add_thread_with_info): Update.
 232         (thread_target_id_str): Update.
 233         (thr_try_catch_cmd): Update.
 234         (thread_command): Update.
 235         (thread_find_command): Update.
 236         * record-btrace.c (record_btrace_target::info_record)
 237         (record_btrace_resume_thread, record_btrace_target::resume)
 238         (record_btrace_cancel_resume, record_btrace_step_thread)
 239         (record_btrace_target::wait, record_btrace_target::wait)
 240         (record_btrace_target::wait, record_btrace_target::stop): Update.
 241         * progspace.c (print_program_space): Update.
 242         * process-stratum-target.c
 243         (process_stratum_target::thread_address_space): Update.
 244         * linux-fork.c (linux_fork_mourn_inferior)
 245         (detach_checkpoint_command, info_checkpoints_command)
 246         (linux_fork_context): Update.
 247         (linux_fork_detach): Update.
 248         (class scoped_switch_fork_info): Update.
 249         (delete_checkpoint_command): Update.
 250         * infrun.c (follow_fork_inferior): Update.
 251         (follow_fork_inferior): Update.
 252         (proceed_after_vfork_done): Update.
 253         (handle_vfork_child_exec_or_exit): Update.
 254         (follow_exec): Update.
 255         (displaced_step_prepare_throw): Update.
 256         (displaced_step_restore): Update.
 257         (start_step_over): Update.
 258         (resume_1): Update.
 259         (clear_proceed_status_thread): Update.
 260         (proceed): Update.
 261         (print_target_wait_results): Update.
 262         (do_target_wait): Update.
 263         (context_switch): Update.
 264         (stop_all_threads): Update.
 265         (restart_threads): Update.
 266         (finish_step_over): Update.
 267         (handle_signal_stop): Update.
 268         (switch_back_to_stepped_thread): Update.
 269         (keep_going_pass_signal): Update.
 270         (print_exited_reason): Update.
 271         (normal_stop): Update.
 272         * inferior.c (inferior_pid_to_str): Change return type.
 273         (print_selected_inferior): Update.
 274         (add_inferior): Update.
 275         (detach_inferior): Update.
 276         * dummy-frame.c (fprint_dummy_frames): Update.
 277         * dcache.c (dcache_info_1): Update.
 278         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 279         (btrace_fetch, btrace_clear): Update.
 280         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 281         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 282         type.
 283         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 284         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 285         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 286         * gdbarch.c, gdbarch.h: Rebuild.
 287         * gdbarch.sh (core_pid_to_str): Change return type.
 288         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 289         return type.
 290         (windows_nat_target::pid_to_str): Change return type.
 291         (windows_delete_thread): Update.
 292         (windows_nat_target::attach): Update.
 293         (windows_nat_target::files_info): Update.
 294         * target-delegates.c: Rebuild.
 295         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 296         return type.
 297         (sol_thread_target::pid_to_str): Change return type.
 298         * remote.c (class remote_target) <pid_to_str>: Change return
 299         type.
 300         (remote_target::pid_to_str): Change return type.
 301         (extended_remote_target::attach, remote_target::remote_stop_ns)
 302         (remote_target::remote_notif_remove_queued_reply)
 303         (remote_target::push_stop_reply, remote_target::disable_btrace):
 304         Update.
 305         (extended_remote_target::attach): Update.
 306         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 307         type.
 308         (gdbsim_target::pid_to_str): Change return type.
 309         * ravenscar-thread.c (struct ravenscar_thread_target)
 310         <pid_to_str>: Change return type.
 311         (ravenscar_thread_target::pid_to_str): Change return type.
 312         * procfs.c (class procfs_target) <pid_to_str>: Change return
 313         type.
 314         (procfs_target::pid_to_str): Change return type.
 315         (procfs_target::attach): Update.
 316         (procfs_target::detach): Update.
 317         (procfs_target::fetch_registers): Update.
 318         (procfs_target::store_registers): Update.
 319         (procfs_target::wait): Update.
 320         (procfs_target::files_info): Update.
 321         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 322         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 323         return type.
 324         (nto_procfs_target::pid_to_str): Change return type.
 325         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 326         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 327         return type.
 328         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 329         (exit_lwp): Update.
 330         (attach_proc_task_lwp_callback, get_detach_signal)
 331         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 332         (linux_nat_target::resume, wait_lwp, stop_callback)
 333         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 334         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 335         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 336         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 337         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 338         type.
 339         (inf_ptrace_target::attach): Update.
 340         (inf_ptrace_target::files_info): Update.
 341         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 342         type.
 343         (go32_nat_target::pid_to_str): Change return type.
 344         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 345         (gnu_nat_target::wait): Update.
 346         (gnu_nat_target::wait): Update.
 347         (gnu_nat_target::resume): Update.
 348         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 349         (fbsd_nat_target::wait): Update.
 350         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 351         type.
 352         (darwin_nat_target::attach): Update.
 353         * corelow.c (class core_target) <pid_to_str>: Change return type.
 354         (core_target::pid_to_str): Change return type.
 355         * target.c (normal_pid_to_str): Change return type.
 356         (default_pid_to_str): Likewise.
 357         (target_pid_to_str): Change return type.
 358         (target_translate_tls_address): Update.
 359         (target_announce_detach): Update.
 360         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 361         return type.
 362         (bsd_uthread_target::pid_to_str): Change return type.
 363         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 364         type.
 365         (bsd_kvm_target::pid_to_str): Change return type.
 366         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 367         return type.
 368         (aix_thread_target::pid_to_str): Change return type.
 369         * target.h (struct target_ops) <pid_to_str>: Change return type.
 370         (target_pid_to_str, normal_pid_to_str): Likewise.
 371         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 372         type.
 373         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 374         type.
 375         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 376         return type.
 377         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 378         type.
 379         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 380         type.
 381         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 382         return type.
 383
 384 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 385
 386         * NEWS: Mention that the new default MI version is 3.  Mention
 387         changes to the output of commands and events that deal with
 388         multi-location breakpoints.
 389         * breakpoint.c: Include "mi/mi-out.h".
 390         (print_one_breakpoint): Change output syntax if using MI version
 391         >= 3.
 392         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 393         New.
 394         (mi_multi_location_breakpoint_output_fixed): New.
 395         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 396         (mi_cmd_fix_multi_location_breakpoint_output): New.
 397         (mi_multi_location_breakpoint_output_fixed): New.
 398         * mi/mi-cmds.c (mi_cmds): Register command
 399         -fix-multi-location-breakpoint-output.
 400         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 401         interpreter "mi".
 402
 403 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 404
 405         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 406         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 407         instantiate mi_ui_out based on interpreter name.
 408         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 409         * mi/mi-main.c (mi_load_progress): Likewise.
 410
 411 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 412
 413         * NEWS: Combine separate "New targets" sections for 8.3.
 414
 415 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 416
 417         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 418         (ppcfbsd_init_abi): Install gdbarch
 419         "fetch_tls_load_module_address" and "get_thread_local_address"
 420         methods.
 421
 422 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 423
 424         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 425         (riscv_fbsd_init_abi): Install gdbarch
 426         "fetch_tls_load_module_address" and "get_thread_local_address"
 427         methods.
 428
 429 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 430
 431         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 432         (i386fbsd_init_abi): Install gdbarch
 433         "fetch_tls_load_module_address" and "get_thread_local_address"
 434         methods.
 435
 436 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 437
 438         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 439         (amd64fbsd_init_abi): Install gdbarch
 440         "fetch_tls_load_module_address" and "get_thread_local_address"
 441         methods.
 442
 443 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 444
 445         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 446         (struct fbsd_pspace_data): New type.
 447         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 448         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 449         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 450         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 451         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 452
 453 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 454
 455         * gdbtypes.c (lookup_struct_elt): New function.
 456         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 457         * gdbtypes.h (struct struct_elt): New type.
 458         (lookup_struct_elt): New prototype.
 459
 460 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 461
 462         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 463         remove disabled code block.
 464
 465 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 466
 467         * gdbarch.sh (get_thread_local_address): New method.
 468         * gdbarch.h, gdbarch.c: Regenerate.
 469         * target.c (target_translate_tls_address): Use
 470         gdbarch_get_thread_local_address if present instead of
 471         target::get_thread_local_address.
 472
 473 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 474
 475         * target.h (target::get_thread_local_address): Update comment.
 476
 477 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 478
 479         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 480         objfile->separate_debug_objfile_backlink if not NULL.
 481
 482 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 483
 484         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 485         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 486         (amd64bsd_store_inferior_registers): Likewise.
 487         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 488         Enable segment base registers.
 489         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 490         PT_GETFSBASE and PT_GETGSBASE.
 491         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 492         PT_SETGSBASE.
 493         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 494         segment base registers.
 495         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 496
 497 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 498
 499         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 500         Update calls to i386_target_description to add 'segments'
 501         parameter.
 502         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 503         add segment base registers.
 504         * arch/i386.c (i386_create_target_description): Add 'segments'
 505         parameter to enable segment base registers.
 506         * arch/i386.h (i386_create_target_description): Likewise.
 507         * features/i386/32bit-segments.xml: New file.
 508         * features/i386/32bit-segments.c: Generate.
 509         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 510         call to i386_target_description to add 'segments' parameter.
 511         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 512         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 513         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 514         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 515         if feature is present.
 516         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 517         Add 'segments' parameter to call to i386_target_description.
 518         (i386_target_description): Add 'segments' parameter to enable
 519         segment base registers.
 520         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 521         to call to i386_target_description.
 522         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 523         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 524         Define I386_NUM_REGS.
 525         (i386_target_description): Add 'segments' parameter to enable
 526         segment base registers.
 527
 528 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 529
 530         PR/24325
 531         * source-cache.c: #undef open and close, to avoid unresolved
 532         externals during linking.
 533
 534 2019-03-12  Tom Tromey  <tromey@adacore.com>
 535
 536         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 537         const.  Add initializers.
 538         (_initialize_remote): Don't initialize ptid globals.
 539
 540 2019-03-12  Pedro Alves  <palves@redhat.com>
 541
 542         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 543
 544 2019-03-12  Pedro Alves  <palves@redhat.com>
 545
 546         * cp-name-parser.y (main): Remove unused 'len' variable.
 547
 548 2019-03-12  Tom Tromey  <tromey@adacore.com>
 549
 550         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 551         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 552
 553 2019-03-12  Tom Tromey  <tromey@adacore.com>
 554
 555         * linux-nat.c (iterate_over_lwps): Update.
 556         (stop_callback): Remove parameter.
 557         (stop_wait_callback, detach_callback, resume_set_callback)
 558         (select_singlestep_lwp_callback, set_ignore_sigint)
 559         (status_callback, resumed_callback, resume_clear_callback)
 560         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 561         data parameter.
 562         (linux_nat_target::detach, linux_nat_target::resume)
 563         (linux_stop_and_wait_all_lwps, select_event_lwp)
 564         (linux_nat_filter_event, linux_nat_wait_1)
 565         (linux_nat_target::kill, linux_nat_target::stop)
 566         (linux_nat_target::stop): Update.
 567         (linux_nat_resume_callback): Change type.
 568         (resume_stopped_resumed_lwps, count_events_callback)
 569         (select_event_lwp_callback): Likewise.
 570         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 571         * arm-linux-nat.c (struct update_registers_data): Remove.
 572         (update_registers_callback): Change type.
 573         (arm_linux_insert_hw_breakpoint1): Update.
 574         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 575         parameter.
 576         (x86_linux_dr_set_addr): Update.
 577         (x86_linux_dr_set_control): Update.
 578         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 579         (iterate_over_lwps): Use gdb::function_view.
 580         * nat/aarch64-linux-hw-point.c (struct
 581         aarch64_dr_update_callback_param): Remove.
 582         (debug_reg_change_callback): Change type.
 583         (aarch64_notify_debug_reg_change): Update.
 584         * s390-linux-nat.c (s390_refresh_per_info): Update.
 585
 586 2019-03-11  Tom Tromey  <tromey@adacore.com>
 587
 588         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 589         redundant assignment to "this_cu".
 590
 591 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 592
 593         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 594
 595 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 596
 597         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 598         from...
 599         (rank_one_type): ... this.
 600
 601 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 602
 603         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 604         from...
 605         (rank_one_type): ... this.
 606
 607 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 608
 609         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 610         from...
 611         (rank_one_type): ... this.
 612
 613 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 614
 615         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 616         from...
 617         (rank_one_type): ... this.
 618
 619 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 620
 621         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 622         from...
 623         (rank_one_type): ... this.
 624
 625 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 626
 627         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 628         from...
 629         (rank_one_type): ... this.
 630
 631 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 632
 633         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 634         from...
 635         (rank_one_type): ... this.
 636
 637 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 638
 639         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 640         from...
 641         (rank_one_type): ... this.
 642
 643 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 644
 645         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 646         from...
 647         (rank_one_type): ... this.
 648
 649 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 650
 651         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 652         from...
 653         (rank_one_type): ... this.
 654
 655 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 656
 657         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 658         from...
 659         (rank_one_type): ... this.
 660
 661 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 662
 663         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 664         from...
 665         (rank_one_type): ... this.
 666
 667 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 668
 669         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 670         inferior-events' shows the example events.
 671
 672 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 673
 674         Support styling on native MS-Windows console
 675
 676         PR/24315
 677         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 678         on MS-Windows if $TERM is not defined.
 679
 680         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 681
 682         * posix-hdep.c (gdb_console_fputs):
 683         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 684         functions.
 685         * ui-file.h (gdb_console_fputs): Add prototype.
 686
 687         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 688         back to fputs only if the former returns zero.
 689
 690 2019-03-07  Tom Tromey  <tom@tromey.com>
 691
 692         * symmisc.c (print_symbol_bcache_statistics): Update.
 693         (print_objfile_statistics): Update.
 694         * symfile.c (allocate_symtab): Update.
 695         * stabsread.c: Don't include bcache.h.
 696         * psymtab.h (struct psymbol_bcache): Don't declare.
 697         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 698         (psymbol_bcache_init, psymbol_bcache_free)
 699         (psymbol_bcache_get_bcache): Don't declare.
 700         * psymtab.c (struct psymbol_bcache): Remove.
 701         (psymtab_storage::psymtab_storage): Update.
 702         (psymtab_storage::~psymtab_storage): Update.
 703         (psymbol_bcache_init, psymbol_bcache_free)
 704         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 705         (add_psymbol_to_bcache): Update.
 706         (allocate_psymtab): Update.
 707         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 708         macro_cache>: No longer pointers.
 709         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 710         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 711         * macrotab.c (macro_bcache): Update.
 712         * macroexp.c: Don't include bcache.h.
 713         * gdbtypes.c (check_types_worklist): Update.
 714         (types_deeply_equal): Remove TRY/CATCH.  Update.
 715         * elfread.c (elf_symtab_read): Update.
 716         * dwarf2read.c: Don't include bcache.h.
 717         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 718         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 719         (print_bcache_statistics, bcache_memory_used): Don't declare.
 720         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 721         methods.  Rename all data members.
 722         * bcache.c (struct bcache): Move to bcache.h.
 723         (bcache::expand_hash_table): Rename from expand_hash_table.
 724         (bcache): Remove.
 725         (bcache::insert): Rename from bcache_full.
 726         (bcache::compare): Rename from bcache_compare.
 727         (bcache_xmalloc): Remove.
 728         (bcache::~bcache): Rename from bcache_xfree.
 729         (bcache::print_statistics): Rename from print_bcache_statistics.
 730         (bcache::memory_used): Rename from bcache_memory_used.
 731
 732 2019-03-07  Pedro Alves  <palves@redhat.com>
 733
 734         * infrun.c (normal_stop): Also check for
 735         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 736
 737 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 738
 739         * f-lang.c (value_from_host_double): Moved to...
 740         * value.c (value_from_host_double): ...here.
 741         * value.h (value_from_host_double): Declare.
 742         * guile/scm-math.c (vlscm_convert_typed_number): Use
 743         value_from_host_double.
 744         (vlscm_convert_number): Likewise.
 745         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 746         * python/py-value.c (convert_value_from_python): Likewise.
 747
 748 2019-03-06  Tom Tromey  <tom@tromey.com>
 749
 750         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 751
 752 2019-03-06  Tom Tromey  <tom@tromey.com>
 753
 754         * utils.h (free_current_contents): Don't declare.
 755         * utils.c (free_current_contents): Remove.
 756
 757 2019-03-06  Tom Tromey  <tom@tromey.com>
 758
 759         * top.c (quit_force): Update.
 760         * main.c (captured_command_loop): Update.
 761         * common/new-op.c (operator new): Update.
 762         * common/common-exceptions.c (struct catcher)
 763         <save_cleanup_chain>: Remove member.
 764         (exceptions_state_mc_init): Update.
 765         (exception_try_scope_entry): Return nullptr.
 766         (exception_try_scope_exit, exception_rethrow)
 767         (throw_exception_sjlj, throw_exception_cxx): Update.
 768         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 769         (all_cleanups, do_cleanups, discard_cleanups)
 770         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 771         (restore_cleanups, restore_final_cleanups): Don't declare.
 772         (do_final_cleanups): Remove parameter.
 773         * common/cleanups.c (cleanup_chain, make_cleanup)
 774         (make_cleanup_dtor, all_cleanups, do_cleanups)
 775         (discard_my_cleanups, discard_cleanups)
 776         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 777         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 778         (null_cleanup): Remove.
 779         (do_final_cleanups): Remove parameter.
 780
 781 2019-03-06  Tom Tromey  <tom@tromey.com>
 782
 783         * remote.c (remote_target::remote_parse_stop_reply): Use
 784         unique_xmalloc_ptr.
 785
 786 2019-03-06  Tom Tromey  <tom@tromey.com>
 787
 788         * stabsread.c (struct stabs_field_info): Rename from field_info.
 789         <list, fnlist>: Add initializers.
 790         <obstack>: New member.
 791         (read_member_functions, read_struct_fields, read_baseclasses):
 792         Allocate on obstack.  Don't use cleanups.
 793         (read_one_struct_field, read_member_functions, read_struct_fields)
 794         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 795         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 796         (read_struct_type): Update.
 797
 798 2019-03-06  Tom Tromey  <tom@tromey.com>
 799
 800         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 801         * common/filestuff.h (make_cleanup_close): Don't declare.
 802         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 803         Remove.
 804
 805 2019-03-06  Tom Tromey  <tom@tromey.com>
 806
 807         * solib-aix.c: Use make_scope_exit.
 808
 809 2019-03-06  Tom Tromey  <tom@tromey.com>
 810
 811         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 812         Use make_scope_exit.
 813
 814 2019-03-06  Tom Tromey  <tom@tromey.com>
 815
 816         * solib-svr4.c (disable_probes_interface): Remove parameter.
 817         (svr4_handle_solib_event): Use make_scope_exit.
 818
 819 2019-03-06  Tom Tromey  <tom@tromey.com>
 820
 821         * remote.c (struct stop_reply_deleter): Remove.
 822         (stop_reply_up): Update.
 823         (struct stop_reply): Derive from notif_event.  Don't typedef.
 824         <regcache>: Now a std::vector.
 825         (stop_reply_xfree): Remove.
 826         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 827         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 828         (remote_target::discard_pending_stop_replies): Use delete.
 829         (remote_target::remote_parse_stop_reply): Update.
 830         (remote_target::process_stop_reply): Update.
 831         * remote-notif.h (struct notif_event): Add virtual destructor.
 832         Remove "dtr" member.
 833         (struct notif_client) <alloc_event>: Return a unique_ptr.
 834         (notif_event_xfree): Don't declare.
 835         (notif_event_up): New typedef.
 836         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 837         (notif_event_xfree, do_notif_event_xfree): Remove.
 838         (remote_notif_state_xfree): Update.
 839
 840 2019-03-06  Tom Tromey  <tom@tromey.com>
 841
 842         * infrun.c (displaced_step_clear_cleanup): Now a
 843         forward_scope_exit type.
 844         (displaced_step_prepare_throw): Update.
 845         (displaced_step_fixup): Update.
 846
 847 2019-03-06  Tom Tromey  <tom@tromey.com>
 848
 849         * inferior.h (class inferior): Update comment.
 850         * gdbthread.h (class thread_info): Update comment.
 851
 852 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 853             Tom Tromey  <tom@tromey.com>
 854
 855         * stabsread.h (struct stab_section_list): Remove.
 856         (coffstab_build_psymtabs): Update.
 857         * dbxread.c (symbuf_sections): Now a std::vector.
 858         (sect_idx): New global.
 859         (fill_symbuf): Update.
 860         (coffstab_build_psymtabs): Change type of stabsects parameter.
 861         Update.
 862         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 863         std::vector.
 864         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 865         (coff_locate_sections): Update.
 866         (coff_symfile_read): Remove cleanups.  Update.
 867         (init_stringtab): Add storage parameter.
 868         (free_stringtab, free_stringtab_cleanup): Remove.
 869         (init_lineno): Add storage parameter.
 870         (free_linetab, free_linetab_cleanup): Remove.
 871
 872 2019-03-06  Pedro Alves  <palves@redhat.com>
 873
 874         * linux-fork.c (fork_info::clobber_regs): Delete.
 875         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 876         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 877         comment.  Adjust.
 878         (scoped_switch_fork_info::scoped_switch_fork_info)
 879         (checkpoint_command, linux_fork_context): Adjust
 880         fork_save_infrun_state calls.
 881
 882 2019-03-06  Pedro Alves  <palves@redhat.com>
 883
 884         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 885         (inf_has_multiple_threads): Return 'bool' and rewrite using
 886         inferior_info::threads().
 887
 888 2019-03-06  Pedro Alves  <palves@redhat.com>
 889
 890         * linux-fork.c: Include <list>.
 891         (fork_list): Now a std::list instance.
 892         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 893         (forks_exist_p, find_last_fork): Adjust.
 894         (new_fork): Delete.
 895         (one_fork_p): New.
 896         (add_fork): Adjust.
 897         (free_fork): Delete, folded into fork_info::~fork_info().
 898         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 899         Adjust.
 900         (init_fork_list): Delete.
 901         (linux_fork_killall, linux_fork_mourn_inferior)
 902         (linux_fork_detach, info_checkpoints_command): Adjust.
 903         (_initialize_linux_fork): No longer call init_fork_list.
 904
 905 2019-03-06  Pedro Alves  <palves@redhat.com>
 906
 907         * linux-fork.c (new_fork): New, split out of ...
 908         (add_fork): ... this.  Return void.  Move "first fork" special
 909         case from here, to ...
 910         (checkpoint_command): ... here.
 911         * linux-linux.h (add_fork): Return void.
 912
 913 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 916
 917 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 918             Chris January  <chris.january@arm.com>
 919             David Lecomber  <david.lecomber@arm.com>
 920
 921         * f-exp.y: New token, UNOP_INTRINSIC.
 922         (exp): New pattern using UNOP_INTRINSIC token.
 923         (f77_keywords): Add 'abs' keyword.
 924         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 925         (value_from_host_double): New function.
 926         (evaluate_subexp_f): Support UNOP_ABS.
 927
 928 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 929
 930         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 931         types.
 932
 933 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 934
 935         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 936         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 937         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 938
 939 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 942
 943 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 944             Chris January  <chris.january@arm.com>
 945
 946         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 947         * f-exp.y: Define 'KIND' token.
 948         (exp): New pattern for KIND expressions.
 949         (ptype): Handle types with a kind extension.
 950         (direct_abs_decl): Extend to spot kind extensions.
 951         (f77_keywords): Add 'kind' to the list.
 952         (push_kind_type): New function.
 953         (convert_to_kind_type): New function.
 954         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 955         * parse.c (operator_length_standard): Likewise.
 956         * parser-defs.h (enum type_pieces): Add tp_kind.
 957         * std-operator.def: Add UNOP_KIND.
 958
 959 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 960
 961         * f-exp.y (f_parse): Set yydebug.
 962
 963 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 964
 965         * f-lang.c (evaluate_subexp_f): New function.
 966         (exp_descriptor_f): New global.
 967         (f_language_defn): Use exp_descriptor_f instead of
 968         exp_descriptor_standard.
 969
 970 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 971
 972         * f-exp.y (struct token): Add comments.
 973         (dot_ops): Remove uppercase versions and the end marker.
 974         (f77_keywords): Likewise.
 975         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 976         entries in the dot_ops array are case insensitive, and use
 977         strncasecmp to compare strings.  Also some whitespace cleanup in
 978         this area.  Similar for the f77_keywords array, except entries in
 979         this list might be case sensitive.
 980
 981 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 982
 983         * f-exp.y (struct f77_boolean_val): Add comments.
 984         (boolean_values): Remove uppercase versions, and end marker.
 985         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 986         and use strncasecmp to achieve case insensitivity.  Additionally,
 987         perform whitespace cleanup around this code.
 988
 989 2019-03-06  Tom Tromey  <tromey@adacore.com>
 990
 991         * remote-sim.c (gdbsim_target_open): Use result of
 992         gdb_argv::release.
 993
 994 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 995         Dirk Schubert  <dirk.schubert@arm.com>
 996         Chris January  <chris.january@arm.com>
 997
 998         * eval.c (evaluate_subexp_standard): Call Fortran argument
 999         wrapping logic.
1000         * f-lang.c (struct value): A value which can be passed into a
1001         Fortran function call.
1002         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1003         where appropriate.
1004         (struct type): Value ready for a Fortran function call.
1005         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1006         is needed.
1007         * f-lang.h (fortran_argument_convert): Declaration.
1008         (fortran_preserve_arg_pointer): Declaration.
1009         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1010
1011 2019-03-05  Tom Tromey  <tromey@adacore.com>
1012
1013         * python/py-prettyprint.c (print_string_repr): Remove #if.
1014         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1015
1016 2019-03-05  Tom Tromey  <tromey@adacore.com>
1017
1018         * target.c (the_dummy_target): Move later.  Change type to
1019         "dummy_target".
1020         (initialize_targets): Don't initialize the_dummy_target.
1021
1022 2019-03-05  Tom Tromey  <tromey@adacore.com>
1023
1024         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1025         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1026
1027 2019-03-05  Tom Tromey  <tromey@adacore.com>
1028
1029         * windows-nat.c (windows_nat_target::attach)
1030         (windows_nat_target::detach): Don't call gdb_flush.
1031         * valprint.c (generic_val_print, val_print, val_print_string):
1032         Don't call gdb_flush.
1033         * utils.c (defaulted_query): Don't call gdb_flush.
1034         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1035         * target.c (target_announce_detach): Don't call gdb_flush.
1036         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1037         * remote.c (extended_remote_target::attach): Don't call
1038         gdb_flush.
1039         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1040         * printcmd.c (do_examine): Don't call gdb_flush.
1041         (info_display_command): Don't call gdb_flush.
1042         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1043         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1044         * memattr.c (info_mem_command): Don't call gdb_flush.
1045         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1046         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1047         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1048         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1049         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1050         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1051         (gnu_nat_target::detach): Don't call gdb_flush.
1052         * f-valprint.c (f_val_print): Don't call gdb_flush.
1053         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1054         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1055         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1056         gdb_flush.
1057         * c-valprint.c (c_val_print): Don't call gdb_flush.
1058         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1059
1060 2019-03-05  Tom Tromey  <tromey@adacore.com>
1061
1062         * varobj.c (update_dynamic_varobj_children): Update.
1063         (install_default_visualizer): Use reset, not release.
1064         * value.c (set_internalvar): Update.
1065         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1066         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1067         ATTRIBUTE_UNUSED_RESULT.
1068
1069 2019-03-05  Tom Tromey  <tromey@adacore.com>
1070
1071         * remote.c (class scoped_remote_fd) <release>: Add
1072         ATTRIBUTE_UNUSED_RESULT.
1073
1074 2019-03-05  Tom Tromey  <tromey@adacore.com>
1075
1076         * macroexp.c (struct macro_buffer) <release>: Add
1077         ATTRIBUTE_UNUSED_RESULT.
1078
1079 2019-03-05  Tom Tromey  <tromey@adacore.com>
1080
1081         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1082         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1083         ATTRIBUTE_UNUSED_RESULT.
1084
1085 2019-03-05  Tom Tromey  <tromey@adacore.com>
1086
1087         * common/scoped_fd.h (class scoped_fd) <release>: Add
1088         ATTRIBUTE_UNUSED_RESULT.
1089
1090 2019-03-05  Tom Tromey  <tromey@adacore.com>
1091
1092         * parser-defs.h (struct parser_state) <release>: Add
1093         ATTRIBUTE_UNUSED_RESULT.
1094
1095 2019-03-05  Tom Tromey  <tromey@adacore.com>
1096
1097         * utils.h (class gdb_argv) <release>: Add
1098         ATTRIBUTE_UNUSED_RESULT.
1099         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1100
1101 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1102
1103         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1104         for-loop range, to avoid compiler warnings.
1105
1106         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1107         avoid compiler warnings about unused variables.
1108
1109         * NEWS: Mention end of support for native debugging on MS-Windows
1110         before XP.
1111
1112         PR gdb/24292
1113         * common/netstuff.c:
1114         * gdbserver/gdbreplay.c
1115         * gdbserver/remote-utils.c:
1116         * ser-tcp.c:
1117         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1118         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1119         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1120         'getaddrinfo' and 'freeaddrinfo' were not available before
1121         Windows XP, and mingw.org's MinGW headers by default define
1122         _WIN32_WINNT to 0x500.
1123
1124 2019-03-01  Gary Benson <gbenson@redhat.com>
1125
1126         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1127
1128 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1129             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1130
1131         PR gdb/8527
1132         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1133         set_sigint_trap, clear_sigint_trap.
1134
1135 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1136
1137         * target.c (target_detach): Clear the regcache and the
1138         frame cache.
1139
1140 2019-02-27  Pedro Alves  <palves@redhat.com>
1141
1142         * utils.c (set_screen_size): When we cap the height/width sizes,
1143         tweak the corresponding command variable to show "unlimited":
1144
1145 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1146             Pedro Alves  <palves@redhat.com>
1147
1148         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1149         before calling rl_set_screen_size.
1150
1151 2019-02-27  Tom Tromey  <tromey@adacore.com>
1152
1153         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1154         define.
1155         * python/py-value.c: Remove Python 2.4 workaround.
1156         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1157         workaround.
1158         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1159         Python 2.4 workaround.
1160         * python/python-internal.h: Remove Python 2.4 comment.
1161         (Py_ssize_t): Don't define.
1162         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1163         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1164         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1165         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1166         * python/python.c (do_start_initialization): Remove Python 2.4
1167         workaround.
1168         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1169         (print_children): Remove Python 2.4 workaround.
1170         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1171         workaround.
1172         (CHARBUFFERPROC_NAME): Remove.
1173         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1174         Python 2.4 workaround.
1175
1176 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1177
1178         * NEWS: Note minimum Python version.
1179
1180 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1181
1182         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1183         code from these functions.  Remove corresponding ifdefs.  Use
1184         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1185         Remove gotos and target of gotos.
1186         (infpy_search_memory): Likewise.
1187
1188 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1189
1190         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1191         (hppa_gdbarch_init): Don't register deleted functions with
1192         gdbarch.
1193
1194 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1195
1196         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1197         (h8300_unwind_sp): Delete.
1198         (h8300_dummy_id): Delete.
1199         (h8300_gdbarch_init): Don't register deleted functions with
1200         gdbarch.
1201
1202 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1203
1204         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1205         (ft32_unwind_pc): Delete.
1206         (ft32_unwind_sp): Delete.
1207         (ft32_gdbarch_init): Don't register deleted functions with
1208         gdbarch.
1209
1210 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1211
1212         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1213         (frv_unwind_pc): Delete.
1214         (frv_unwind_sp): Delete.
1215         (frv_gdbarch_init): Don't register deleted functions with
1216         gdbarch.
1217
1218 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1219
1220         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1221         (riscv_unwind_pc): Delete.
1222         (riscv_unwind_sp): Delete.
1223         (riscv_gdbarch_init): Don't register deleted functions with
1224         gdbarch.
1225
1226 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1229         (csky_unwind_pc): Delete.
1230         (csky_unwind_sp): Delete.
1231         (csky_gdbarch_init): Don't register deleted functions with
1232         gdbarch.
1233
1234 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1235
1236         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1237         (cris_unwind_pc): Delete.
1238         (cris_unwind_sp): Delete.
1239         (cris_gdbarch_init): Don't register deleted functions with
1240         gdbarch.
1241
1242 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1243
1244         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1245         (bfin_unwind_pc): Delete.
1246         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1247
1248 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1249
1250         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1251         (arm_unwind_pc): Delete.
1252         (arm_unwind_sp): Delete.
1253         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1254
1255 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1258         (arc_unwind_pc): Delete.
1259         (arc_unwind_sp): Delete.
1260         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1261
1262 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1263
1264         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1265         (alpha_unwind_pc): Delete.
1266         (alpha_gdbarch_init): Don't register deleted functions with
1267         gdbarch.
1268
1269 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1270
1271         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1272         (aarch64_unwind_pc): Delete.
1273         (aarch64_unwind_sp): Delete.
1274         (aarch64_gdbarch_init): Don't register deleted functions with
1275         gdbarch.
1276
1277 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * gdbtypes.c (type_align): Don't consider static members when
1280         computing structure alignment.
1281
1282 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1283
1284         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1285         return 0 for other types.
1286         * arch-utils.c (default_type_align): Always return 0.
1287         * gdbarch.h: Regenerate.
1288         * gdbarch.sh (type_align): Extend comment.
1289         * gdbtypes.c (type_align): Add additional comments, always call
1290         gdbarch_type_align before applying the default rules.
1291         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1292         generic code will then apply a suitable default.
1293         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1294         types, return 0 for other types.
1295
1296 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1297
1298         * NEWS: Create a new section for the next release branch.
1299         Rename the section of the current branch, now that it has
1300         been cut.
1301
1302 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1303
1304         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1305         * version.in: Bump version to 8.3.50.DATE-git.
1306
1307 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1308
1309         * aix-thread.c (ptid_cmp): Remove unused variable.
1310         (get_signaled_thread): Likewise.
1311         (store_regs_user_thread): Likewise.
1312         (store_regs_kernel_thread): Likewise.
1313         (fetch_regs_kernel_thread): Remove shadowed variable.
1314
1315 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1316
1317         * features/riscv/32bit-cpu.xml: Add register numbers.
1318         * features/riscv/32bit-fpu.c: Regenerate.
1319         * features/riscv/32bit-fpu.xml: Add register numbers.
1320         * features/riscv/64bit-cpu.xml: Add register numbers.
1321         * features/riscv/64bit-fpu.c: Regenerate.
1322         * features/riscv/64bit-fpu.xml: Add register numbers.
1323
1324 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1325
1326         * NEWS: Mention two argument form of gdb.Value constructor.
1327         * python/py-value.c (convert_buffer_and_type_to_value): New
1328         function.
1329         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1330         Add support for handling an optional second argument.  Call
1331         convert_buffer_and_type_to_value as appropriate.
1332         * python/python-internal.h (Py_buffer_deleter): New struct.
1333         (Py_buffer_up): New typedef.
1334
1335 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1336
1337         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1338         instead of releasing ownership.
1339
1340 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1341
1342         * dwarf2read.c (open_and_init_dwp_file): Call
1343         elf_numsections instead of bfd_count_sections to initialize
1344         dwp_file->num_sections.
1345
1346 2019-02-25  Tom Tromey  <tromey@adacore.com>
1347
1348         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1349
1350 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1351
1352         * gcore.in: Add '--readnever' option when invoking GDB.
1353
1354 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1355
1356         * MAINTAINERS: Update my email address.
1357
1358 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1359
1360         * build-id.c (build_id_to_debug_bfd_1): New function.
1361         (build_id_to_debug_bfd): Look for separate debug file in
1362         sysroot.
1363
1364 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1365
1366         * gdbarch.sh: Update the copyright year range that is placed into
1367         generated files.
1368
1369 2019-02-22  Keith Seitz  <keiths@redhat.com>
1370
1371         PR symtab/23853
1372         * linespec.c (create_sals_line_offset): Search for the default
1373         symtab's filename instead of its fullname.
1374
1375 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1376
1377         * NEWS: Update style defaults.
1378
1379 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1380
1381         * main.c (captured_main_1): Disable styling in batch mode.
1382
1383 2019-02-20  Tom Tromey  <tom@tromey.com>
1384
1385         * symtab.c (symtab_symbol_info): Fix typos.
1386
1387 2019-02-20  Tom Tromey  <tromey@adacore.com>
1388
1389         * findcmd.c (_initialize_mem_search): Use upper case for
1390         metasyntactic variables.
1391
1392 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1393
1394         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1395         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1396
1397 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1398
1399         * top.h (source_file_name): Change to std::string.
1400         * top.c (source_file_name): Likewise.
1401         (command_line_input): Adjust.
1402         * cli/cli-script.c (script_from_file): Adjust.
1403
1404 2019-02-19  Tom Tromey  <tromey@adacore.com>
1405
1406         * ravenscar-thread.c
1407         (ravenscar_thread_target::update_thread_list): Don't call
1408         ada_build_task_list.
1409         * ada-lang.h (ada_build_task_list): Don't declare.
1410         * ada-tasks.c (struct ada_tasks_inferior_data)
1411         <task_list_valid_p>: Now bool.
1412         (read_known_tasks, ada_task_list_changed)
1413         (ada_tasks_invalidate_inferior_data): Update.
1414         (read_known_tasks_array): Return bool.
1415         (read_known_tasks_list): Likewise.
1416         (read_known_tasks): Return void.
1417         (ada_build_task_list): Now static.
1418
1419 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1420
1421         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1422         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1423
1424 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1425
1426         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1427         variant for ada_tasks_pspace_data_handle and
1428         ada_tasks_inferior_data_handle.
1429         (ada_tasks_pspace_data_cleanup): New function.
1430         (ada_tasks_inferior_data_cleanup): New function.
1431
1432 2019-02-17  Tom Tromey  <tom@tromey.com>
1433
1434         * macrotab.h (macro_source_fullname): Return a std::string.
1435         * macrotab.c (macro_include, check_for_redefinition)
1436         (macro_undef, macro_lookup_definition, foreach_macro)
1437         (foreach_macro_in_scope): Update.
1438         (macro_source_fullname): Return a std::string.
1439         * macrocmd.c (show_pp_source_pos): Update.
1440
1441 2019-02-17  Tom Tromey  <tom@tromey.com>
1442
1443         * macrocmd.c (show_pp_source_pos): Style the file names.
1444
1445 2019-02-17  Tom Tromey  <tom@tromey.com>
1446
1447         PR tui/24197:
1448         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1449
1450 2019-02-17  Tom Tromey  <tom@tromey.com>
1451
1452         * ada-lang.c (user_select_syms): Use filtered printing.
1453         * utils.c (wrap_style): New global.
1454         (desired_style): Remove.
1455         (emit_style_escape): Add stream parameter.
1456         (set_output_style, reset_terminal_style, prompt_for_continue):
1457         Update.
1458         (flush_wrap_buffer): Only flush gdb_stdout.
1459         (wrap_here): Set wrap_style.
1460         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1461         treat escape sequences as a character.  Change when wrap buffer is
1462         flushed.
1463         (fputs_styled): Do not set the output style when the default is
1464         requested.
1465         * ui-style.h (struct ui_file_style) <is_default>: New method.
1466         * source.c (print_source_lines_base): Emit escape sequences in one
1467         piece.
1468
1469 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1470
1471         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1472         integers and enumeration types.
1473
1474 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1475
1476         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1477         instead of lookup_symbol_in_language
1478         (do_exact_match): New function.
1479         (ada_get_symbol_name_matcher): Return do_exact_match when
1480         doing a verbatim match.
1481
1482 2019-02-15  Tom Tromey  <tromey@adacore.com>
1483
1484         * ravenscar-thread.c (ravenscar_thread_target::resume)
1485         (ravenscar_thread_target::wait): Special case wildcard requests.
1486
1487 2019-02-15  Tom Tromey  <tromey@adacore.com>
1488
1489         * ravenscar-thread.c (base_ptid): Remove.
1490         (struct ravenscar_thread_target) <close>: New method.
1491         <m_base_ptid>: New member.
1492         <update_inferior_ptid, active_task, task_is_currently_active,
1493         runtime_initialized>: Declare methods.
1494         <ravenscar_thread_target>: Add constructor.
1495         (ravenscar_thread_target::task_is_currently_active)
1496         (ravenscar_thread_target::update_inferior_ptid)
1497         (ravenscar_runtime_initialized): Rename.  Now methods.
1498         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1499         (ravenscar_thread_target::update_thread_list): Update.
1500         (ravenscar_thread_target::active_task): Now method.
1501         (ravenscar_thread_target::store_registers)
1502         (ravenscar_thread_target::prepare_to_store)
1503         (ravenscar_thread_target::prepare_to_store)
1504         (ravenscar_thread_target::mourn_inferior): Update.
1505         (ravenscar_inferior_created): Use "new" to create target.
1506         (ravenscar_thread_target::get_ada_task_ptid): Update.
1507         (_initialize_ravenscar): Don't initialize base_ptid.
1508         (ravenscar_ops): Remove global.
1509
1510 2019-02-15  Tom Tromey  <tromey@adacore.com>
1511
1512         * target.h (push_target): Declare new overload.
1513         * target.c (push_target): New overload, taking an rvalue reference.
1514         * remote.c (remote_target::open_1): Use push_target overload.
1515         * corelow.c (core_target_open): Use push_target overload.
1516
1517 2019-02-15  Tom Tromey  <tromey@adacore.com>
1518
1519         * ravenscar-thread.c (is_ravenscar_task)
1520         (ravenscar_task_is_currently_active): Return bool.
1521         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1522         (_initialize_ravenscar): Remove "(void)".
1523         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1524         Return bool.
1525
1526 2019-02-15  Tom Tromey  <tromey@adacore.com>
1527
1528         * ravenscar-thread.c (ravenscar_runtime_initializer)
1529         (has_ravenscar_runtime, get_running_thread_id)
1530         (ravenscar_thread_target::resume): Fix indentation.
1531
1532 2019-02-15  Tom Tromey  <tromey@adacore.com>
1533
1534         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1535         from ravenscar_arch_ops.
1536         (sparc_ravenscar_ops::fetch_registers)
1537         (sparc_ravenscar_ops::store_registers): Now methods.
1538         (sparc_ravenscar_prepare_to_store): Remove.
1539         (sparc_ravenscar_ops): Redefine.
1540         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1541         methods and destructor.  Remove members.
1542         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1543         (ravenscar_thread_target::store_registers)
1544         (ravenscar_thread_target::prepare_to_store): Update.
1545         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1546         Remove.
1547         (struct ppc_ravenscar_powerpc_ops): Derive from
1548         ravenscar_arch_ops.
1549         (ppc_ravenscar_powerpc_ops::fetch_registers)
1550         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1551         (ppc_ravenscar_powerpc_ops): Redefine.
1552         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1553         (ppc_ravenscar_e500_ops::fetch_registers)
1554         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1555         (ppc_ravenscar_e500_ops): Redefine.
1556         * aarch64-ravenscar-thread.c
1557         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1558         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1559         (aarch64_ravenscar_fetch_registers)
1560         (aarch64_ravenscar_store_registers): Now methods.
1561         (aarch64_ravenscar_ops): Redefine.
1562
1563 2019-02-15  Tom Tromey  <tromey@adacore.com>
1564
1565         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1566         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1567         (ravenscar_thread_target::stopped_by_watchpoint)
1568         (ravenscar_thread_target::stopped_data_address)
1569         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1570
1571 2019-02-15  Tom Tromey  <tromey@adacore.com>
1572
1573         * ravenscar-thread.c: Fix some typos.
1574
1575 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1576             Tom Tromey  <tromey@adacore.com>
1577
1578         * ada-lang.c (ada_exception_sal): Change addr_string to a
1579         std::string.
1580         (create_ada_exception_catchpoint): Update.
1581
1582 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1583             Tom Tromey  <tromey@adacore.com>
1584
1585         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1586         (bp_location_ops): Remove.
1587         (base_breakpoint_allocate_location): Update.
1588         (free_bp_location): Update.
1589         * ada-lang.c (class ada_catchpoint_location)
1590         <ada_catchpoint_location>: Remove ops parameter.
1591         (ada_catchpoint_location_dtor): Remove.
1592         (ada_catchpoint_location_ops): Remove.
1593         (allocate_location_exception): Update.
1594         * breakpoint.h (struct bp_location_ops): Remove.
1595         (class bp_location) <bp_location>: Remove bp_location_ops
1596         parameter.
1597         <~bp_location>: Add destructor.
1598         <ops>: Remove.
1599
1600 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1601             Pedro Alves  <palves@redhat.com>
1602
1603         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1604         'PATH_MAX'.
1605
1606 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1607             Samuel Thibault  <samuel.thibault@gnu.org>
1608             Thomas Schwinge  <thomas@codesourcery.com>
1609
1610         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1611         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1612
1613 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1614
1615         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1616         (check_empty): Use "const char *".
1617
1618         * gnu-nat.c (gnu_nat_target::detach): Instead of
1619         'detach_inferior (pid)' call
1620         'detach_inferior (find_inferior_pid (pid))'.
1621
1622         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1623         'nat/fork-inferior.o'.
1624         * gnu-nat.c: #include "nat/fork-inferior.h".
1625
1626         * gnu-nat.c (gnu_nat_target::detach): Instead of
1627         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1628         * gnu-nat.h: #include "inf-child.h".
1629         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1630         'i386_gnu_nat_target::fetch_registers'.
1631         (gnu_store_registers): Rename/move to
1632         'i386_gnu_nat_target::store_registers'.
1633
1634         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1635         * gnu-nat.h (mach_thread_info): New function.
1636         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1637
1638         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1639
1640 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1641
1642         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1643
1644 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1645
1646         * windows-nat.c (windows_add_thread): Add new parameter
1647         "main_thread_p" with default value set to false.  Update
1648         function documentation as well as all callers.
1649         (windows_delete_thread): Likewise.
1650         (fake_create_process): Update call to windows_add_thread.
1651         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1652         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1653         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1654         call to windows_delete_thread.
1655
1656 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1657
1658         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1659
1660 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1661
1662         * symfile.c (find_separate_debug_file): Use canonical path of
1663         sysroot with child_path instead of gdb_sysroot if it is valid.
1664
1665 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1666
1667         * symfile.c (find_separate_debug_file): Use child_path to
1668         determine if an object file is under a sysroot.
1669
1670 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1671
1672         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1673         unittests/child-path-selftests.c.
1674         * common/pathstuff.c (child_path): New function.
1675         * common/pathstuff.h (child_path): New prototype.
1676         * unittests/child-path-selftests.c: New file.
1677
1678 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1679
1680         * symfile.c (find_separate_debug_file): Look for separate debug
1681         files in debug directories under the sysroot.
1682
1683 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1684
1685         * symtab.h (struct minimal_symbol data_p): New const method.
1686         (struct minimal_symbol text_p): Likewise.
1687         * symtab.c (output_source_filename): Use file name style
1688         to print file name.
1689         (print_symbol_info): Likewise.
1690         (print_msymbol_info): Use address style to print addresses.
1691         Use function name style to print executable text symbols.
1692         (expand_symtab_containing_pc): Use data_p.
1693         (find_pc_sect_compunit_symtab): Likewise.
1694
1695 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1696
1697         * breakpoint.c (describe_other_breakpoints): Use address style
1698         to print addresses.
1699         (say_where): Likewise.
1700
1701 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1702
1703         * ada-typeprint.c (print_func_type): Print function name
1704         style to print function name.
1705         * c-typeprint.c (c_print_type_1): Likewise.
1706
1707 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1708
1709         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1710         for execve.
1711
1712 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1713
1714         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1715         type_stack.
1716
1717 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1718
1719         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1720         TYPE_CODE_REF types.
1721
1722 2019-02-08  Jim Wilson  <jimw@sifive.com>
1723
1724         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1725         (riscv_linux_fregset): New.
1726         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1727
1728 2019-02-07  Tom Tromey  <tom@tromey.com>
1729
1730         * thread.c (thread_cancel_execution_command): Update.
1731         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1732         methods.
1733         (struct thread_fsm_ops): Remove.
1734         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1735         (thread_fsm_should_stop, thread_fsm_return_value)
1736         (thread_fsm_set_finished, thread_fsm_finished_p)
1737         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1738         Don't declare.
1739         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1740         * infrun.c (clear_proceed_status_thread)
1741         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1742         (print_stop_event): Update.
1743         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1744         Add constructor.
1745         (step_command_fsm_ops): Remove.
1746         (new_step_command_fsm): Remove.
1747         (step_1): Update.
1748         (step_command_fsm::should_stop): Rename from
1749         step_command_fsm_should_stop.
1750         (step_command_fsm::clean_up): Rename from
1751         step_command_fsm_clean_up.
1752         (step_command_fsm::do_async_reply_reason): Rename from
1753         step_command_fsm_async_reply_reason.
1754         (struct until_next_fsm): Inherit from thread_fsm.  Add
1755         constructor.
1756         (until_next_fsm_ops): Remove.
1757         (new_until_next_fsm): Remove.
1758         (until_next_fsm::should_stop): Rename from
1759         until_next_fsm_should_stop.
1760         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1761         (until_next_fsm::do_async_reply_reason): Rename from
1762         until_next_fsm_async_reply_reason.
1763         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1764         constructor.  Change type of breakpoint.
1765         (finish_command_fsm_ops): Remove.
1766         (new_finish_command_fsm): Remove.
1767         (finish_command_fsm::should_stop): Rename from
1768         finish_command_fsm_should_stop.
1769         (finish_command_fsm::clean_up): Rename from
1770         finish_command_fsm_clean_up.
1771         (finish_command_fsm::return_value): Rename from
1772         finish_command_fsm_return_value.
1773         (finish_command_fsm::do_async_reply_reason): Rename from
1774         finish_command_fsm_async_reply_reason.
1775         (finish_command): Update.
1776         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1777         Add constructor.
1778         (call_thread_fsm_ops): Remove.
1779         (call_thread_fsm::call_thread_fsm): Rename from
1780         new_call_thread_fsm.
1781         (call_thread_fsm::should_stop): Rename from
1782         call_thread_fsm_should_stop.
1783         (call_thread_fsm::should_notify_stop): Rename from
1784         call_thread_fsm_should_notify_stop.
1785         (run_inferior_call, call_function_by_hand_dummy): Update.
1786         * cli/cli-interp.c (should_print_stop_to_console): Update.
1787         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1788         Add constructor.  Change type of location_breakpoint,
1789         caller_breakpoint.
1790         (until_break_fsm_ops): Remove.
1791         (new_until_break_fsm): Remove.
1792         (until_break_fsm::should_stop): Rename from
1793         until_break_fsm_should_stop.
1794         (until_break_fsm::clean_up): Rename from
1795         until_break_fsm_clean_up.
1796         (until_break_fsm::do_async_reply_reason): Rename from
1797         until_break_fsm_async_reply_reason.
1798         (until_break_command): Update.
1799         * thread-fsm.c: Remove.
1800         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1801
1802 2019-02-07  Tom Tromey  <tom@tromey.com>
1803
1804         * yy-remap.h: Add include guard.
1805         * xtensa-tdep.h: Add include guard.
1806         * xcoffread.h: Rename include guard.
1807         * varobj-iter.h: Add include guard.
1808         * tui/tui.h: Rename include guard.
1809         * tui/tui-winsource.h: Rename include guard.
1810         * tui/tui-wingeneral.h: Rename include guard.
1811         * tui/tui-windata.h: Rename include guard.
1812         * tui/tui-win.h: Rename include guard.
1813         * tui/tui-stack.h: Rename include guard.
1814         * tui/tui-source.h: Rename include guard.
1815         * tui/tui-regs.h: Rename include guard.
1816         * tui/tui-out.h: Rename include guard.
1817         * tui/tui-layout.h: Rename include guard.
1818         * tui/tui-io.h: Rename include guard.
1819         * tui/tui-hooks.h: Rename include guard.
1820         * tui/tui-file.h: Rename include guard.
1821         * tui/tui-disasm.h: Rename include guard.
1822         * tui/tui-data.h: Rename include guard.
1823         * tui/tui-command.h: Rename include guard.
1824         * tic6x-tdep.h: Add include guard.
1825         * target/waitstatus.h: Rename include guard.
1826         * target/wait.h: Rename include guard.
1827         * target/target.h: Rename include guard.
1828         * target/resume.h: Rename include guard.
1829         * target-float.h: Rename include guard.
1830         * stabsread.h: Add include guard.
1831         * rs6000-tdep.h: Add include guard.
1832         * riscv-fbsd-tdep.h: Add include guard.
1833         * regformats/regdef.h: Rename include guard.
1834         * record.h: Rename include guard.
1835         * python/python.h: Rename include guard.
1836         * python/python-internal.h: Rename include guard.
1837         * python/py-stopevent.h: Rename include guard.
1838         * python/py-ref.h: Rename include guard.
1839         * python/py-record.h: Rename include guard.
1840         * python/py-record-full.h: Rename include guard.
1841         * python/py-record-btrace.h: Rename include guard.
1842         * python/py-instruction.h: Rename include guard.
1843         * python/py-events.h: Rename include guard.
1844         * python/py-event.h: Rename include guard.
1845         * procfs.h: Add include guard.
1846         * proc-utils.h: Add include guard.
1847         * p-lang.h: Add include guard.
1848         * or1k-tdep.h: Rename include guard.
1849         * observable.h: Rename include guard.
1850         * nto-tdep.h: Rename include guard.
1851         * nat/x86-linux.h: Rename include guard.
1852         * nat/x86-linux-dregs.h: Rename include guard.
1853         * nat/x86-gcc-cpuid.h: Add include guard.
1854         * nat/x86-dregs.h: Rename include guard.
1855         * nat/x86-cpuid.h: Rename include guard.
1856         * nat/ppc-linux.h: Rename include guard.
1857         * nat/mips-linux-watch.h: Rename include guard.
1858         * nat/linux-waitpid.h: Rename include guard.
1859         * nat/linux-ptrace.h: Rename include guard.
1860         * nat/linux-procfs.h: Rename include guard.
1861         * nat/linux-osdata.h: Rename include guard.
1862         * nat/linux-nat.h: Rename include guard.
1863         * nat/linux-namespaces.h: Rename include guard.
1864         * nat/linux-btrace.h: Rename include guard.
1865         * nat/glibc_thread_db.h: Rename include guard.
1866         * nat/gdb_thread_db.h: Rename include guard.
1867         * nat/gdb_ptrace.h: Rename include guard.
1868         * nat/fork-inferior.h: Rename include guard.
1869         * nat/amd64-linux-siginfo.h: Rename include guard.
1870         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1871         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1872         * nat/aarch64-linux.h: Rename include guard.
1873         * nat/aarch64-linux-hw-point.h: Rename include guard.
1874         * mn10300-tdep.h: Add include guard.
1875         * mips-linux-tdep.h: Add include guard.
1876         * mi/mi-parse.h: Rename include guard.
1877         * mi/mi-out.h: Rename include guard.
1878         * mi/mi-main.h: Rename include guard.
1879         * mi/mi-interp.h: Rename include guard.
1880         * mi/mi-getopt.h: Rename include guard.
1881         * mi/mi-console.h: Rename include guard.
1882         * mi/mi-common.h: Rename include guard.
1883         * mi/mi-cmds.h: Rename include guard.
1884         * mi/mi-cmd-break.h: Rename include guard.
1885         * m2-lang.h: Add include guard.
1886         * location.h: Rename include guard.
1887         * linux-record.h: Rename include guard.
1888         * linux-nat.h: Add include guard.
1889         * linux-fork.h: Add include guard.
1890         * i386-darwin-tdep.h: Rename include guard.
1891         * hppa-linux-offsets.h: Add include guard.
1892         * guile/guile.h: Rename include guard.
1893         * guile/guile-internal.h: Rename include guard.
1894         * gnu-nat.h: Rename include guard.
1895         * gdb-stabs.h: Rename include guard.
1896         * frv-tdep.h: Add include guard.
1897         * f-lang.h: Add include guard.
1898         * event-loop.h: Add include guard.
1899         * darwin-nat.h: Rename include guard.
1900         * cp-abi.h: Rename include guard.
1901         * config/sparc/nm-sol2.h: Rename include guard.
1902         * config/nm-nto.h: Rename include guard.
1903         * config/nm-linux.h: Add include guard.
1904         * config/i386/nm-i386gnu.h: Rename include guard.
1905         * config/djgpp/nl_types.h: Rename include guard.
1906         * config/djgpp/langinfo.h: Rename include guard.
1907         * compile/gcc-cp-plugin.h: Add include guard.
1908         * compile/gcc-c-plugin.h: Add include guard.
1909         * compile/compile.h: Rename include guard.
1910         * compile/compile-object-run.h: Rename include guard.
1911         * compile/compile-object-load.h: Rename include guard.
1912         * compile/compile-internal.h: Rename include guard.
1913         * compile/compile-cplus.h: Rename include guard.
1914         * compile/compile-c.h: Rename include guard.
1915         * common/xml-utils.h: Rename include guard.
1916         * common/x86-xstate.h: Rename include guard.
1917         * common/version.h: Rename include guard.
1918         * common/vec.h: Rename include guard.
1919         * common/tdesc.h: Rename include guard.
1920         * common/selftest.h: Rename include guard.
1921         * common/scoped_restore.h: Rename include guard.
1922         * common/scoped_mmap.h: Rename include guard.
1923         * common/scoped_fd.h: Rename include guard.
1924         * common/safe-iterator.h: Rename include guard.
1925         * common/run-time-clock.h: Rename include guard.
1926         * common/refcounted-object.h: Rename include guard.
1927         * common/queue.h: Rename include guard.
1928         * common/ptid.h: Rename include guard.
1929         * common/print-utils.h: Rename include guard.
1930         * common/preprocessor.h: Rename include guard.
1931         * common/pathstuff.h: Rename include guard.
1932         * common/observable.h: Rename include guard.
1933         * common/netstuff.h: Rename include guard.
1934         * common/job-control.h: Rename include guard.
1935         * common/host-defs.h: Rename include guard.
1936         * common/gdb_wait.h: Rename include guard.
1937         * common/gdb_vecs.h: Rename include guard.
1938         * common/gdb_unlinker.h: Rename include guard.
1939         * common/gdb_unique_ptr.h: Rename include guard.
1940         * common/gdb_tilde_expand.h: Rename include guard.
1941         * common/gdb_sys_time.h: Rename include guard.
1942         * common/gdb_string_view.h: Rename include guard.
1943         * common/gdb_splay_tree.h: Rename include guard.
1944         * common/gdb_setjmp.h: Rename include guard.
1945         * common/gdb_ref_ptr.h: Rename include guard.
1946         * common/gdb_optional.h: Rename include guard.
1947         * common/gdb_locale.h: Rename include guard.
1948         * common/gdb_assert.h: Rename include guard.
1949         * common/filtered-iterator.h: Rename include guard.
1950         * common/filestuff.h: Rename include guard.
1951         * common/fileio.h: Rename include guard.
1952         * common/environ.h: Rename include guard.
1953         * common/common-utils.h: Rename include guard.
1954         * common/common-types.h: Rename include guard.
1955         * common/common-regcache.h: Rename include guard.
1956         * common/common-inferior.h: Rename include guard.
1957         * common/common-gdbthread.h: Rename include guard.
1958         * common/common-exceptions.h: Rename include guard.
1959         * common/common-defs.h: Rename include guard.
1960         * common/common-debug.h: Rename include guard.
1961         * common/cleanups.h: Rename include guard.
1962         * common/buffer.h: Rename include guard.
1963         * common/btrace-common.h: Rename include guard.
1964         * common/break-common.h: Rename include guard.
1965         * cli/cli-utils.h: Rename include guard.
1966         * cli/cli-style.h: Rename include guard.
1967         * cli/cli-setshow.h: Rename include guard.
1968         * cli/cli-script.h: Rename include guard.
1969         * cli/cli-interp.h: Rename include guard.
1970         * cli/cli-decode.h: Rename include guard.
1971         * cli/cli-cmds.h: Rename include guard.
1972         * charset-list.h: Add include guard.
1973         * buildsym-legacy.h: Rename include guard.
1974         * bfin-tdep.h: Add include guard.
1975         * ax.h: Rename include guard.
1976         * arm-linux-tdep.h: Add include guard.
1977         * arm-fbsd-tdep.h: Add include guard.
1978         * arch/xtensa.h: Rename include guard.
1979         * arch/tic6x.h: Add include guard.
1980         * arch/i386.h: Add include guard.
1981         * arch/arm.h: Rename include guard.
1982         * arch/arm-linux.h: Rename include guard.
1983         * arch/arm-get-next-pcs.h: Rename include guard.
1984         * arch/amd64.h: Add include guard.
1985         * arch/aarch64-insn.h: Rename include guard.
1986         * arch-utils.h: Rename include guard.
1987         * annotate.h: Add include guard.
1988         * amd64-darwin-tdep.h: Rename include guard.
1989         * aarch64-linux-tdep.h: Add include guard.
1990         * aarch64-fbsd-tdep.h: Add include guard.
1991         * aarch32-linux-nat.h: Add include guard.
1992
1993 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1994
1995         * macrotab.c (macro_define_internal): New function that
1996         factorizes macro_define_object_internal and macro_define_function
1997         code.
1998         (macro_define_object_internal): Use macro_define_internal.
1999         (macro_define_function): Likewise.
2000
2001 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2002
2003         * macrocmd.c (extract_identifier): Return
2004         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2005         callers.
2006
2007 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2008
2009         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2010
2011 2019-02-05  Tom Tromey  <tom@tromey.com>
2012
2013         * target.c (target_stack::unpush): Move assertion earlier.
2014
2015 2019-01-30  Tom Tromey  <tom@tromey.com>
2016
2017         PR python/23615:
2018         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2019         (gdbpy_parse_and_eval): Likewise.
2020         * python/python-internal.h (gdbpy_allow_threads): New class.
2021
2022 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2023
2024         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2025         (aarch64_fbsd_fpregmap): Move earlier.
2026         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2027         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2028         instead of individual calls to trad_frame_set_reg_addr.
2029         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2030         earlier.
2031         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2032         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2033         instead of individual calls to trad_frame_set_reg_addr.
2034
2035 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2036
2037         * CONTRIBUTE: Replace contribution list with wiki link.
2038
2039 2019-01-25  Tom Tromey  <tom@tromey.com>
2040
2041         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2042
2043 2019-01-25  Tom Tromey  <tom@tromey.com>
2044
2045         * xtensa-linux-nat.c: Fix common/ includes.
2046         * xml-support.h: Fix common/ includes.
2047         * xml-support.c: Fix common/ includes.
2048         * x86-linux-nat.c: Fix common/ includes.
2049         * windows-nat.c: Fix common/ includes.
2050         * varobj.h: Fix common/ includes.
2051         * varobj.c: Fix common/ includes.
2052         * value.c: Fix common/ includes.
2053         * valops.c: Fix common/ includes.
2054         * utils.c: Fix common/ includes.
2055         * unittests/xml-utils-selftests.c: Fix common/ includes.
2056         * unittests/utils-selftests.c: Fix common/ includes.
2057         * unittests/unpack-selftests.c: Fix common/ includes.
2058         * unittests/tracepoint-selftests.c: Fix common/ includes.
2059         * unittests/style-selftests.c: Fix common/ includes.
2060         * unittests/string_view-selftests.c: Fix common/ includes.
2061         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2062         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2063         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2064         * unittests/rsp-low-selftests.c: Fix common/ includes.
2065         * unittests/parse-connection-spec-selftests.c: Fix common/
2066         includes.
2067         * unittests/optional-selftests.c: Fix common/ includes.
2068         * unittests/offset-type-selftests.c: Fix common/ includes.
2069         * unittests/observable-selftests.c: Fix common/ includes.
2070         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2071         * unittests/memrange-selftests.c: Fix common/ includes.
2072         * unittests/memory-map-selftests.c: Fix common/ includes.
2073         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2074         * unittests/function-view-selftests.c: Fix common/ includes.
2075         * unittests/environ-selftests.c: Fix common/ includes.
2076         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2077         * unittests/common-utils-selftests.c: Fix common/ includes.
2078         * unittests/cli-utils-selftests.c: Fix common/ includes.
2079         * unittests/array-view-selftests.c: Fix common/ includes.
2080         * ui-file.c: Fix common/ includes.
2081         * tui/tui-io.c: Fix common/ includes.
2082         * tracepoint.h: Fix common/ includes.
2083         * tracepoint.c: Fix common/ includes.
2084         * tracefile-tfile.c: Fix common/ includes.
2085         * top.h: Fix common/ includes.
2086         * top.c: Fix common/ includes.
2087         * thread.c: Fix common/ includes.
2088         * target/waitstatus.h: Fix common/ includes.
2089         * target/waitstatus.c: Fix common/ includes.
2090         * target.h: Fix common/ includes.
2091         * target.c: Fix common/ includes.
2092         * target-memory.c: Fix common/ includes.
2093         * target-descriptions.c: Fix common/ includes.
2094         * symtab.h: Fix common/ includes.
2095         * symfile.c: Fix common/ includes.
2096         * stap-probe.c: Fix common/ includes.
2097         * spu-linux-nat.c: Fix common/ includes.
2098         * sparc-nat.c: Fix common/ includes.
2099         * source.c: Fix common/ includes.
2100         * solib.c: Fix common/ includes.
2101         * solib-target.c: Fix common/ includes.
2102         * ser-unix.c: Fix common/ includes.
2103         * ser-tcp.c: Fix common/ includes.
2104         * ser-pipe.c: Fix common/ includes.
2105         * ser-base.c: Fix common/ includes.
2106         * selftest-arch.c: Fix common/ includes.
2107         * s12z-tdep.c: Fix common/ includes.
2108         * rust-exp.y: Fix common/ includes.
2109         * rs6000-aix-tdep.c: Fix common/ includes.
2110         * riscv-tdep.c: Fix common/ includes.
2111         * remote.c: Fix common/ includes.
2112         * remote-notif.h: Fix common/ includes.
2113         * remote-fileio.h: Fix common/ includes.
2114         * remote-fileio.c: Fix common/ includes.
2115         * regcache.h: Fix common/ includes.
2116         * regcache.c: Fix common/ includes.
2117         * record-btrace.c: Fix common/ includes.
2118         * python/python.c: Fix common/ includes.
2119         * python/py-type.c: Fix common/ includes.
2120         * python/py-inferior.c: Fix common/ includes.
2121         * progspace.h: Fix common/ includes.
2122         * producer.c: Fix common/ includes.
2123         * procfs.c: Fix common/ includes.
2124         * proc-api.c: Fix common/ includes.
2125         * printcmd.c: Fix common/ includes.
2126         * ppc-linux-nat.c: Fix common/ includes.
2127         * parser-defs.h: Fix common/ includes.
2128         * osdata.c: Fix common/ includes.
2129         * obsd-nat.c: Fix common/ includes.
2130         * nat/x86-linux.c: Fix common/ includes.
2131         * nat/x86-linux-dregs.c: Fix common/ includes.
2132         * nat/x86-dregs.h: Fix common/ includes.
2133         * nat/x86-dregs.c: Fix common/ includes.
2134         * nat/ppc-linux.c: Fix common/ includes.
2135         * nat/mips-linux-watch.h: Fix common/ includes.
2136         * nat/mips-linux-watch.c: Fix common/ includes.
2137         * nat/linux-waitpid.c: Fix common/ includes.
2138         * nat/linux-ptrace.h: Fix common/ includes.
2139         * nat/linux-ptrace.c: Fix common/ includes.
2140         * nat/linux-procfs.c: Fix common/ includes.
2141         * nat/linux-personality.c: Fix common/ includes.
2142         * nat/linux-osdata.c: Fix common/ includes.
2143         * nat/linux-namespaces.c: Fix common/ includes.
2144         * nat/linux-btrace.h: Fix common/ includes.
2145         * nat/linux-btrace.c: Fix common/ includes.
2146         * nat/fork-inferior.c: Fix common/ includes.
2147         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2148         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2149         * nat/aarch64-linux.c: Fix common/ includes.
2150         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2151         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2152         * namespace.h: Fix common/ includes.
2153         * mips-linux-tdep.c: Fix common/ includes.
2154         * minsyms.c: Fix common/ includes.
2155         * mi/mi-parse.h: Fix common/ includes.
2156         * mi/mi-main.c: Fix common/ includes.
2157         * mi/mi-cmd-env.c: Fix common/ includes.
2158         * memrange.h: Fix common/ includes.
2159         * memattr.c: Fix common/ includes.
2160         * maint.h: Fix common/ includes.
2161         * maint.c: Fix common/ includes.
2162         * main.c: Fix common/ includes.
2163         * machoread.c: Fix common/ includes.
2164         * location.c: Fix common/ includes.
2165         * linux-thread-db.c: Fix common/ includes.
2166         * linux-nat.c: Fix common/ includes.
2167         * linux-fork.c: Fix common/ includes.
2168         * inline-frame.c: Fix common/ includes.
2169         * infrun.c: Fix common/ includes.
2170         * inflow.c: Fix common/ includes.
2171         * inferior.h: Fix common/ includes.
2172         * inferior.c: Fix common/ includes.
2173         * infcmd.c: Fix common/ includes.
2174         * inf-ptrace.c: Fix common/ includes.
2175         * inf-child.c: Fix common/ includes.
2176         * ia64-linux-nat.c: Fix common/ includes.
2177         * i387-tdep.c: Fix common/ includes.
2178         * i386-tdep.c: Fix common/ includes.
2179         * i386-linux-tdep.c: Fix common/ includes.
2180         * i386-linux-nat.c: Fix common/ includes.
2181         * i386-go32-tdep.c: Fix common/ includes.
2182         * i386-fbsd-tdep.c: Fix common/ includes.
2183         * i386-fbsd-nat.c: Fix common/ includes.
2184         * guile/scm-type.c: Fix common/ includes.
2185         * guile/guile.c: Fix common/ includes.
2186         * go32-nat.c: Fix common/ includes.
2187         * gnu-nat.c: Fix common/ includes.
2188         * gdbthread.h: Fix common/ includes.
2189         * gdbarch-selftests.c: Fix common/ includes.
2190         * gdb_usleep.c: Fix common/ includes.
2191         * gdb_select.h: Fix common/ includes.
2192         * gdb_bfd.c: Fix common/ includes.
2193         * gcore.c: Fix common/ includes.
2194         * fork-child.c: Fix common/ includes.
2195         * findvar.c: Fix common/ includes.
2196         * fbsd-nat.c: Fix common/ includes.
2197         * event-top.c: Fix common/ includes.
2198         * event-loop.c: Fix common/ includes.
2199         * dwarf2read.c: Fix common/ includes.
2200         * dwarf2loc.c: Fix common/ includes.
2201         * dwarf2-frame.c: Fix common/ includes.
2202         * dwarf-index-cache.c: Fix common/ includes.
2203         * dtrace-probe.c: Fix common/ includes.
2204         * disasm-selftests.c: Fix common/ includes.
2205         * defs.h: Fix common/ includes.
2206         * csky-tdep.c: Fix common/ includes.
2207         * cp-valprint.c: Fix common/ includes.
2208         * cp-support.h: Fix common/ includes.
2209         * cp-support.c: Fix common/ includes.
2210         * corelow.c: Fix common/ includes.
2211         * completer.h: Fix common/ includes.
2212         * completer.c: Fix common/ includes.
2213         * compile/compile.c: Fix common/ includes.
2214         * compile/compile-loc2c.c: Fix common/ includes.
2215         * compile/compile-cplus-types.c: Fix common/ includes.
2216         * compile/compile-cplus-symbols.c: Fix common/ includes.
2217         * command.h: Fix common/ includes.
2218         * cli/cli-dump.c: Fix common/ includes.
2219         * cli/cli-cmds.c: Fix common/ includes.
2220         * charset.c: Fix common/ includes.
2221         * build-id.c: Fix common/ includes.
2222         * btrace.h: Fix common/ includes.
2223         * btrace.c: Fix common/ includes.
2224         * breakpoint.h: Fix common/ includes.
2225         * breakpoint.c: Fix common/ includes.
2226         * ax.h:
2227         (enum agent_op): Fix common/ includes.
2228         * ax-general.c (struct aop_map): Fix common/ includes.
2229         * ax-gdb.c: Fix common/ includes.
2230         * auxv.c: Fix common/ includes.
2231         * auto-load.c: Fix common/ includes.
2232         * arm-tdep.c: Fix common/ includes.
2233         * arch/riscv.c: Fix common/ includes.
2234         * arch/ppc-linux-common.c: Fix common/ includes.
2235         * arch/i386.c: Fix common/ includes.
2236         * arch/arm.c: Fix common/ includes.
2237         * arch/arm-linux.c: Fix common/ includes.
2238         * arch/arm-get-next-pcs.c: Fix common/ includes.
2239         * arch/amd64.c: Fix common/ includes.
2240         * arch/aarch64.c: Fix common/ includes.
2241         * arch/aarch64-insn.c: Fix common/ includes.
2242         * arch-utils.c: Fix common/ includes.
2243         * amd64-windows-tdep.c: Fix common/ includes.
2244         * amd64-tdep.c: Fix common/ includes.
2245         * amd64-sol2-tdep.c: Fix common/ includes.
2246         * amd64-obsd-tdep.c: Fix common/ includes.
2247         * amd64-nbsd-tdep.c: Fix common/ includes.
2248         * amd64-linux-tdep.c: Fix common/ includes.
2249         * amd64-linux-nat.c: Fix common/ includes.
2250         * amd64-fbsd-tdep.c: Fix common/ includes.
2251         * amd64-fbsd-nat.c: Fix common/ includes.
2252         * amd64-dicos-tdep.c: Fix common/ includes.
2253         * amd64-darwin-tdep.c: Fix common/ includes.
2254         * agent.c: Fix common/ includes.
2255         * ada-lang.h: Fix common/ includes.
2256         * ada-lang.c: Fix common/ includes.
2257         * aarch64-tdep.c: Fix common/ includes.
2258
2259 2019-01-25  Tom Tromey  <tom@tromey.com>
2260
2261         * common/create-version.sh: Use common/version.h.
2262
2263 2019-01-24  Pedro Alves  <palves@redhat.com>
2264
2265         * infrun.c (signal_stop, signal_print, signal_program)
2266         (signal_catch, signal_pass): Now arrays instead of pointers.
2267         (update_signals_program_target, do_target_resume)
2268         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2269         * linux-nat.c (linux_nat_target::pass_signals)
2270         (linux_nat_target::create_inferior, linux_nat_target::attach):
2271         Adjust.
2272         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2273         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2274         * procfs.c (procfs_target::pass_signals): Adjust.
2275         * record-full.c (record_full_target::resume): Adjust.
2276         * remote.c (remote_target::pass_signals)
2277         (remote_target::program_signals): Adjust.
2278         * target-debug.h (target_debug_print_signals): Now takes a
2279         gdb::array_view as parameter.  Adjust.
2280         * target.h (target_ops) <pass_signals, program_signals>: Replace
2281         pointer and length parameters with gdb::array_view.
2282         (target_pass_signals, target_program_signals): Likewise.
2283         * target-delegates.c: Regenerate.
2284
2285 2019-01-24  Pedro Alves  <palves@redhat.com>
2286
2287         * common/forward-scope-exit.h
2288         (forward_scope_exit::forward_scope_exit): Pass arguments to
2289         m_bind_function directly, instead of creating a std::bind and
2290         copying that.
2291
2292 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2293
2294         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2295         for static members.
2296         (pass_in_v_vfp_candidate): Likewise.
2297
2298 2019-01-23  Tom Tromey  <tom@tromey.com>
2299             Pedro Alves  <palves@redhat.com>
2300
2301         * regcache.c (class regcache_invalidator): Remove.
2302         (regcache::raw_write): Use make_scope_exit.
2303
2304 2019-01-23  Tom Tromey  <tom@tromey.com>
2305
2306         * ui-out.h (class ui_out_emit_type): Update comment.
2307
2308 2019-01-23  Tom Tromey  <tom@tromey.com>
2309
2310         * infrun.c (fetch_inferior_event): Update comment.
2311
2312 2019-01-23  Tom Tromey  <tom@tromey.com>
2313             Pedro Alves  <palves@redhat.com>
2314
2315         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2316         parameter.
2317         (fetch_inferior_event): Use SCOPE_EXIT.
2318
2319
2320 2019-01-23  Tom Tromey  <tom@tromey.com>
2321             Pedro Alves  <palves@redhat.com>
2322
2323         * infrun.c (disable_thread_events): Delete.
2324         (stop_all_threads): Use SCOPE_EXIT.
2325
2326 2019-01-23  Tom Tromey  <tom@tromey.com>
2327             Pedro Alves  <palves@redhat.com>
2328
2329         * symfile.c: Include forward-scope-exit.h.
2330         (clear_symtab_users_cleanup): Replace forward declaration with
2331         a FORWARD_SCOPE_EXIT.
2332         (syms_from_objfile_1): Use the forward_scope_exit and
2333         gdb::optional instead of cleanup_function.
2334         (reread_symbols): Use the forward_scope_exit instead of
2335         cleanup_function.
2336         (clear_symtab_users_cleanup): Remove function.
2337
2338 2019-01-23  Tom Tromey  <tom@tromey.com>
2339             Pedro Alves  <palves@redhat.com>
2340
2341         * linux-nat.c: Include scope-exit.h.
2342         (cleanup_target_stop): Remove.
2343         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2344         SCOPE_EXIT.
2345
2346 2019-01-23  Tom Tromey  <tom@tromey.com>
2347             Pedro Alves  <palves@redhat.com>
2348
2349         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2350         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2351
2352 2019-01-23  Tom Tromey  <tom@tromey.com>
2353             Andrew Burgess  <andrew.burgess@embecosm.com>
2354             Pedro Alves  <palves@redhat.com>
2355
2356         * infrun.c (fetch_inferior_event): Use scope_exit.
2357         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2358         * top.c (execute_command): Use scope_exit.
2359         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2360         * utils.c (do_bpstat_clear_actions_cleanup)
2361         (make_bpstat_clear_actions_cleanup): Remove.
2362
2363 2019-01-23  Tom Tromey  <tom@tromey.com>
2364             Pedro Alves  <palves@redhat.com>
2365
2366         * infrun.c: Include "common/scope-exit.h"
2367         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2368         (wait_for_inferior): Use SCOPE_EXIT.
2369         (fetch_inferior_event): Use scope_exit.
2370
2371 2019-01-23  Tom Tromey  <tom@tromey.com>
2372             Pedro Alves  <palves@redhat.com>
2373
2374         * breakpoint.c (create_breakpoint): Remove cleanup.
2375
2376 2019-01-23  Tom Tromey  <tom@tromey.com>
2377             Andrew Burgess  <andrew.burgess@embecosm.com>
2378             Pedro Alves  <palves@redhat.com>
2379
2380 2019-01-23  Pedro Alves  <palves@redhat.com>
2381
2382         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2383
2384 2019-01-23  Pedro Alves  <palves@redhat.com>
2385             Andrew Burgess  <andrew.burgess@embecosm.com>
2386
2387         * gdbthread.h: Include "common/forward-scope-exit.h".
2388         (scoped_finish_thread_state): Redefine custom class in terms of
2389         forward_scope_exit.
2390
2391 2019-01-23  Pedro Alves  <palves@redhat.com>
2392             Andrew Burgess  <andrew.burgess@embecosm.com>
2393
2394         * common/forward-scope-exit.h: New file.
2395
2396 2019-01-23  Pedro Alves  <palves@redhat.com>
2397             Andrew Burgess  <andrew.burgess@embecosm.com>
2398             Tom Tromey  <tom@tromey.com>
2399
2400         * common/scope-exit.h: New file.
2401
2402 2019-01-23  Pedro Alves  <palves@redhat.com>
2403
2404         * common/preprocessor.h (ESC): Rename to ...
2405         (ESC_PARENS): ... this.
2406         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2407         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2408
2409 2019-01-23  Tom Tromey  <tom@tromey.com>
2410
2411         * language.h (class scoped_switch_to_sym_language_if_auto):
2412         Initialize m_lang in both cases.
2413
2414 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2415
2416         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2417         with XCNEW.
2418
2419 2019-01-22  Tom Tromey  <tom@tromey.com>
2420
2421         * corelow.c: Do not include sys/file.h.
2422
2423 2019-01-22  Tom Tromey  <tom@tromey.com>
2424
2425         * tui/tui-wingeneral.h: Include gdb_curses.h.
2426
2427 2019-01-22  Tom Tromey  <tom@tromey.com>
2428
2429         * source-cache.h (class source_cache) <get_source_lines,
2430         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2431
2432 2019-01-22  Tom Tromey  <tom@tromey.com>
2433
2434         * remote-fileio.h (struct remote_target): Declare.
2435
2436 2019-01-22  Tom Tromey  <tom@tromey.com>
2437
2438         * python/py-arch.c: Do not include py-ref.h.
2439         * python/py-bpevent.c: Do not include py-ref.h.
2440         * python/py-cmd.c: Do not include py-ref.h.
2441         * python/py-continueevent.c: Do not include py-ref.h.
2442         * python/py-event.h: Do not include py-ref.h.
2443         * python/py-evtregistry.c: Do not include py-ref.h.
2444         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2445         * python/py-frame.c: Do not include py-ref.h.
2446         * python/py-framefilter.c: Do not include py-ref.h.
2447         * python/py-function.c: Do not include py-ref.h.
2448         * python/py-infevents.c: Do not include py-ref.h.
2449         * python/py-linetable.c: Do not include py-ref.h.
2450         * python/py-objfile.c: Do not include py-ref.h.
2451         * python/py-param.c: Do not include py-ref.h.
2452         * python/py-prettyprint.c: Do not include py-ref.h.
2453         * python/py-progspace.c: Do not include py-ref.h.
2454         * python/py-symbol.c: Do not include py-ref.h.
2455         * python/py-symtab.c: Do not include py-ref.h.
2456         * python/py-type.c: Do not include py-ref.h.
2457         * python/py-unwind.c: Do not include py-ref.h.
2458         * python/py-utils.c: Do not include py-ref.h.
2459         * python/py-value.c: Do not include py-ref.h.
2460         * python/py-varobj.c: Do not include py-ref.h.
2461         * python/py-xmethods.c: Do not include py-ref.h.
2462         * python/python.c: Do not include py-ref.h.
2463         * varobj.c: Do not include py-ref.h.
2464
2465 2019-01-22  Tom Tromey  <tom@tromey.com>
2466
2467         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2468         keyword for bcache.
2469
2470 2019-01-22  Tom Tromey  <tom@tromey.com>
2471
2472         * compile/compile-cplus-types.c: Remove a comment by #include.
2473
2474 2019-01-22  Tom Tromey  <tom@tromey.com>
2475
2476         * compile/gcc-c-plugin.h: Include compile-internal.h.
2477
2478 2019-01-22  Tom Tromey  <tom@tromey.com>
2479
2480         * stabsread.c (EXTERN): Do not define.
2481         (symnum, next_symbol_text_func, processing_gcc_compilation)
2482         (within_function, global_sym_chain, global_stabs)
2483         (previous_stab_code, this_object_header_files)
2484         (n_this_object_header_files)
2485         (n_allocated_this_object_header_files): Define.
2486         * stabsread.h (EXTERN): Never define.  Use "extern".
2487
2488 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2489
2490         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2491         history_value.
2492
2493 2019-01-21  Tom Tromey  <tom@tromey.com>
2494
2495         * ui-out.c: Fix includes.
2496         * tui/tui-source.c: Fix includes.
2497         * target.c: Fix includes.
2498         * remote.c: Fix includes.
2499         * regcache.c: Fix includes.
2500         * python/py-block.c: Fix includes.
2501         * printcmd.c: Fix includes.
2502         * or1k-tdep.c: Fix includes.
2503         * mi/mi-main.c: Fix includes.
2504         * m32r-tdep.c: Fix includes.
2505         * csky-tdep.c: Fix includes.
2506         * compile/compile-cplus-types.c: Fix includes.
2507         * cli/cli-interp.c: Fix includes.
2508
2509 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2510
2511         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2512         for padding.
2513
2514 2019-01-16  Tom Tromey  <tom@tromey.com>
2515
2516         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2517         earlier.
2518         (struct objfile) <msymbols_range>: Move from top level.
2519         <msymbols>: New method.
2520         (class objfile_msymbols): Remove.
2521         * symtab.c (default_collect_symbol_completion_matches_break_on):
2522         Update.
2523         * symmisc.c (dump_msymbols): Update.
2524         * stabsread.c (scan_file_globals): Update.
2525         * objc-lang.c (info_selectors_command, info_classes_command)
2526         (find_methods): Update.
2527         * minsyms.c (find_solib_trampoline_target): Update.
2528         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2529         * coffread.c (coff_symfile_read): Update.
2530         * ada-lang.c (ada_lookup_simple_minsym)
2531         (ada_collect_symbol_completion_matches): Update.
2532
2533 2019-01-16  Tom Tromey  <tom@tromey.com>
2534
2535         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2536         type.  Remove no-argument constructor.
2537         <iterator::operator++>: Simplify.
2538         <begin>: Update.
2539         <end>: Use minimal_symbol_count.
2540
2541 2019-01-16  Tom Tromey  <tom@tromey.com>
2542
2543         * objfiles.h (struct objfile) <psymtabs>: New method.
2544         (class objfile_psymtabs): Remove.
2545         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2546         typedef.
2547         <range>: New method.
2548         (require_partial_symbols): Change return type.
2549         * psymtab.c (require_partial_symbols)
2550         (psym_expand_symtabs_matching): Update.
2551         * mdebugread.c (parse_partial_symbols): Update.
2552         * dbxread.c (dbx_end_psymtab): Update.
2553
2554 2019-01-15  Tom Tromey  <tom@tromey.com>
2555
2556         * symtab.c (lookup_objfile_from_block)
2557         (lookup_symbol_in_objfile_symtabs)
2558         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2559         (find_line_symtab, info_sources_command)
2560         (default_collect_symbol_completion_matches_break_on)
2561         (make_source_files_completion_list): Update.
2562         * symmisc.c (print_objfile_statistics, dump_objfile)
2563         (maintenance_print_symbols, maintenance_info_symtabs)
2564         (maintenance_check_symtabs, maintenance_info_line_tables):
2565         Update.
2566         * source.c (select_source_symtab)
2567         (forget_cached_source_info_for_objfile): Update.
2568         * objfiles.h (class objfile_compunits): Remove.
2569         (struct objfile) <compunits_range>: New typedef.
2570         (compunits): New method.
2571         * objfiles.c (objfile_relocate1): Update.
2572         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2573         * maint.c (count_symtabs_and_blocks): Update.
2574         * linespec.c (iterate_over_all_matching_symtabs): Update.
2575         * cp-support.c (add_symbol_overload_list_qualified): Update.
2576         * coffread.c (coff_symtab_read): Update.
2577         * ada-lang.c (add_nonlocal_symbols)
2578         (ada_collect_symbol_completion_matches)
2579         (ada_add_global_exceptions): Update.
2580
2581 2019-01-15  Tom Tromey  <tom@tromey.com>
2582
2583         * progspace.h (program_space) <objfiles_safe_range>: New
2584         typedef.
2585         <objfiles_safe>: New method.
2586         * objfiles.h (class all_objfiles_safe): Remove.
2587         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2588         * jit.c (jit_inferior_exit_hook): Update.
2589
2590 2019-01-17  Tom Tromey  <tom@tromey.com>
2591
2592         * progspace.h (program_space) <objfiles_range>: New typedef.
2593         <objfiles>: New method.
2594         <objfiles_head>: Rename from objfiles.
2595         (object_files): Update.
2596         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2597         * guile/scm-pretty-print.c
2598         (ppscm_find_pretty_printer_from_objfiles): Update.
2599         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2600         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2601         Update.
2602         * python/py-progspace.c (pspy_get_objfiles): Update.
2603         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2604         Update.
2605         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2606         (objfpy_lookup_objfile_by_build_id): Update.
2607         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2608         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2609         Update.
2610         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2611         (expand_symtab_containing_pc, lookup_objfile_from_block)
2612         (lookup_static_symbol, basic_lookup_transparent_type)
2613         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2614         (find_line_symtab, info_sources_command)
2615         (default_collect_symbol_completion_matches_break_on)
2616         (make_source_files_completion_list, find_main_name): Update.
2617         * symmisc.c (print_symbol_bcache_statistics)
2618         (print_objfile_statistics, maintenance_print_symbols)
2619         (maintenance_print_msymbols, maintenance_print_objfiles)
2620         (maintenance_info_symtabs, maintenance_check_symtabs)
2621         (maintenance_expand_symtabs, maintenance_info_line_tables):
2622         Update.
2623         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2624         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2625         (map_overlay_command, unmap_overlay_command)
2626         (simple_overlay_update, expand_symtabs_matching)
2627         (map_symbol_filenames): Update.
2628         * symfile-debug.c (set_debug_symfile): Update.
2629         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2630         Update.
2631         * source.c (select_source_symtab, forget_cached_source_info):
2632         Update.
2633         * solib.c (solib_read_symbols): Update.
2634         * solib-spu.c (append_ocl_sos): Update.
2635         * psymtab.c (maintenance_print_psymbols)
2636         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2637         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2638         * printcmd.c (info_symbol_command): Update.
2639         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2640         Update.
2641         * objfiles.h (class all_objfiles): Remove.
2642         * objfiles.c (have_partial_symbols, have_full_symbols)
2643         (have_minimal_symbols, qsort_cmp, update_section_map)
2644         (shared_objfile_contains_address_p)
2645         (default_iterate_over_objfiles_in_search_order): Update.
2646         * objc-lang.c (info_selectors_command, info_classes_command)
2647         (find_methods): Update.
2648         * minsyms.c (find_solib_trampoline_target): Update.
2649         * maint.c (maintenance_info_sections)
2650         (maintenance_translate_address, count_symtabs_and_blocks):
2651         Update.
2652         * main.c (captured_main_1): Update.
2653         * linux-thread-db.c (try_thread_db_load_from_pdir)
2654         (has_libpthread): Update.
2655         * linespec.c (iterate_over_all_matching_symtabs)
2656         (search_minsyms_for_name): Update.
2657         * jit.c (jit_find_objf_with_entry_addr): Update.
2658         * hppa-tdep.c (find_unwind_entry)
2659         (hppa_lookup_stub_minimal_symbol): Update.
2660         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2661         Update.
2662         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2663         (elf_gnu_ifunc_resolve_by_got): Update.
2664         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2665         * dwarf-index-write.c (save_gdb_index_command): Update.
2666         * cp-support.c (add_symbol_overload_list_qualified): Update.
2667         * breakpoint.c (create_overlay_event_breakpoint)
2668         (create_longjmp_master_breakpoint)
2669         (create_std_terminate_master_breakpoint)
2670         (create_exception_master_breakpoint): Update.
2671         * blockframe.c (find_pc_partial_function): Update.
2672         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2673         (ada_collect_symbol_completion_matches)
2674         (ada_add_global_exceptions): Update.
2675
2676 2019-01-17  Tom Tromey  <tom@tromey.com>
2677
2678         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2679         declare VEC.
2680         (solib_target_parse_libraries): Change return type.
2681         (library_list_start_segment, library_list_start_section)
2682         (library_list_end_library, library_list_start_library); Update.
2683         (solib_target_free_library_list): Remove.
2684         (solib_target_parse_libraries): Remove cleanup.  Change return
2685         type.
2686         (solib_target_current_sos): Update.
2687
2688 2019-01-17  Tom Tromey  <tromey@bapiya>
2689
2690         * valprint.c: Replace "the the" with "the".
2691         * symtab.c: Replace "the the" with "the".
2692         * solib.c: Replace "the the" with "the".
2693         * solib-dsbt.c: Replace "the the" with "the".
2694         * linespec.c: Replace "the the" with "the".
2695         * dwarf2loc.h: Replace "the the" with "the".
2696         * amd64-windows-tdep.c: Replace "the the" with "the".
2697         * aarch64-tdep.c: Replace "the the" with "the".
2698
2699 2019-01-16  Keith Seitz  <keiths@redhat.com>
2700
2701         PR gdb/23773
2702         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2703         <builder>: Rename to ..
2704         <m_builder>: ... this and make private.
2705         (dwarf2_cu::get_builder): New method.  Change all users of
2706         `builder' to use this method.
2707         (dwarf2_start_symtab): Move to ...
2708         (dwarf2_cu::start_symtab): ... here.  Update all callers
2709         (setup_type_unit_groups): Move to ...
2710         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2711         callers.
2712         (dwarf2_cu::reset_builder): New method.
2713         (process_full_compunit, process_full_type_unit): Use
2714         dwarf2_cu::reset_builder.
2715         (follow_die_offset): Record the ancestor CU if it is different
2716         from the followed DIE's CU.
2717         (follow_die_sig_1): Likewise.
2718
2719 2019-01-15  Tom Tromey  <tom@tromey.com>
2720
2721         * remote.c (class remote_state) <buf>: Now a char_vector.
2722         <buf_size>: Remove.
2723         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2724         parameter.
2725         (remote_target::getpkt_or_notif_sane_1)
2726         (remote_target::getpkt_sane)
2727         (remote_target::getpkt_or_notif_sane): Likewise.
2728         (class remote_target) <putpkt>: New overload.
2729         (remote_target::read_frame): Change type of "buf_p".  Remove
2730         sizeof_p parameter.
2731         (packet_ok): New overload.
2732         (packet_check_result): New overload.
2733         Update all uses.
2734
2735 2019-01-14  Tom Tromey  <tom@tromey.com>
2736
2737         * remote-notif.c (handle_notification, remote_notif_ack)
2738         (remote_notif_parse): Make "buf" const.
2739         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2740         const.
2741         (remote_notif_parse, remote_notif_ack, handle_notification):
2742         Likewise.
2743         * remote.c (remote_notif_stop_parse): Make "buf" const.
2744         (remote_target::remote_parse_stop_reply): Make "buf" const.
2745         (remote_notif_stop_ack): Make "buf" const.
2746
2747 2019-01-14  Tom Tromey  <tom@tromey.com>
2748
2749         * remote.c (remote_console_output): Make parameter const.
2750
2751 2019-01-14  Tom Tromey  <tom@tromey.com>
2752
2753         * target-debug.h (target_debug_print_signals): Constify.
2754         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2755         * procfs.c (procfs_target::pass_signals): Update.
2756         * linux-nat.c (linux_nat_target::pass_signals): Update.
2757         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2758         * target-delegates.c: Rebuild.
2759         * remote.c (remote_target::program_signals): Update.
2760         (remote_target::pass_signals): Update.
2761         * target.c (target_pass_signals): Constify argument.
2762         (target_program_signals): Likewise.
2763         * target.h (struct target_ops) <pass_signals, program_signals>:
2764         Constify argument.
2765         (target_pass_signals, target_program_signals): Constify argument.
2766
2767 2019-01-14  Tom Tromey  <tom@tromey.com>
2768
2769         PR tui/28819:
2770         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2771
2772 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2773
2774         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2775         field.
2776         * rs6000-tdep.c: Include reggroups.h.
2777         (IS_V_ALIAS_PSEUDOREG): Define.
2778         (rs6000_register_name): Return names for the "vX" aliases.
2779         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2780         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2781         aliases.  Call default_register_reggroup_p for all other
2782         pseudo-registers.
2783         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2784         New functions.
2785         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2786         Handle "vX" aliases.
2787         (v_alias_pseudo_register_collect): New function.
2788         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2789         (rs6000_gdbarch_init): Initialize "vX" aliases as
2790         pseudo-registers.  Restore registration of
2791         rs6000_pseudo_register_reggroup_p with
2792         set_tdesc_pseudo_register_reggroup_p.
2793
2794 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2795
2796         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2797         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2798         set_gdbarch_num_pseudo_regs.
2799
2800 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2801
2802         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2803         Remove arg prefixname, add do_set and do_show.
2804         Add member functions set_list and show_list.
2805         * cli/cli-style.c (class cli_style_option): Update accordingly.
2806         (style_set_list): Move to file scope.
2807         (style_show_list): Likewise.
2808         (set_style): Call help_list.
2809         (show_style): Call cmd_show_list.
2810         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2811         Update to use the new macro.
2812
2813 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2814
2815         * ada-lang.c (_initialize_ada_language): Expand the help text
2816         for the "catch exception" command.
2817
2818 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2819
2820         * symtab.c (matching_obj_sections): Initialize obj,
2821         declare it closer to its usage.
2822
2823 2019-01-10  Tom Tromey  <tom@tromey.com>
2824
2825         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2826         (basic_inf_threads_range): Remove.
2827         (inf_threads_range, inf_non_exited_threads_range)
2828         (safe_inf_threads_range): Use next_adapter.
2829
2830 2019-01-10  Keith Seitz  <keiths@redhat.com>
2831
2832         PR gdb/23712
2833         PR symtab/23010
2834         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2835         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2836
2837 2019-01-10  Keith Seitz  <keiths@redhat.com>
2838
2839         PR gdb/23712
2840         PR symtab/23010
2841         * dictionary.c (pending_to_vector): Remove.
2842         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2843         Remove _1 suffix, replacing functions of the same name.  Update
2844         all callers.
2845         (dict_create_hashed, dict_create_hashed_expandable)
2846         (dict_create_linear, dict_create_linear_expandable, dict_free)
2847         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2848         Make functions static.
2849
2850 2019-01-10  Keith Seitz  <keiths@redhat.com>
2851
2852         PR gdb/23712
2853         PR symtab/23010
2854         * dictionary.h (struct dictionary): Replace declaration with
2855         multidictionary.
2856         (dict_create_hashed, dict_create_hashed_expandable)
2857         (dict_create_linear, dict_create_linear_expandable)
2858         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2859         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2860         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2861         taking multidictionary argument.
2862         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2863         * block.h (struct block) <dict>: Change to multidictionary
2864         and rename `multidict'.
2865         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2866         symmisc.c: Update all dictionary references to multidictionary.
2867
2868 2019-01-10  Keith Seitz  <keiths@redhat.com>
2869
2870         PR gdb/23712
2871         PR symtab/23010
2872         * dictionary.c: Include unordered_map.
2873         (pending_to_vector): New function.
2874         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2875         Rewrite the non-"_1" functions to take vector instead
2876         of linked list.
2877         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2878         "new" _1 versions of the same name.
2879         (multidictionary): Define.
2880         (std::hash<enum language): New definition.
2881         (collate_pending_symbols_by_language, mdict_create_hashed)
2882         (mdict_create_hashed_expandable, mdict_create_linear)
2883         (mdict_create_linear_expandable, mdict_free)
2884         (find_language_dictionary, create_new_language_dictionary)
2885         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2886         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2887         (mdict_size, mdict_empty): New functions.
2888         * dictionary.h (mdict_iterator): Define.
2889
2890 2019-01-10  Pedro Alves  <palves@redhat.com>
2891
2892         * breakpoint.c (read_uploaded_action)
2893         (create_tracepoint_from_upload): Adjust to use
2894         gdb::unique_xmalloc_ptr.
2895         * ctf.c (ctf_write_uploaded_tp):
2896         (SET_ARRAY_FIELD): Use emplace_back.
2897         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2898         * tracefile-tfile.c (tfile_write_uploaded_tp):
2899         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2900         gdb::unique_xmalloc_ptr.
2901         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2902         at_string, cond_string, cmd_strings>: Replace char pointers
2903         with gdb::unique_xmalloc_ptr.
2904
2905 2019-01-10  Pedro Alves  <palves@redhat.com>
2906
2907         * solib-target.c (library_list_start_library): Don't xstrdup name.
2908
2909 2019-01-10  Pedro Alves  <palves@redhat.com>
2910
2911         * mdebugread.c (parse_partial_symbols): Use
2912         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2913
2914 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2915
2916         * linux-fork.c (scoped_switch_fork_info)
2917         <~scoped_switch_fork_info>: Fix incorrect variable name.
2918
2919 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2920
2921         * linux-fork.c (scoped_switch_fork_info)
2922         <scoped_switch_fork_info>: Make explicit.
2923         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2924
2925 2019-01-10  Tom Tromey  <tom@tromey.com>
2926
2927         * objfiles.h (objfile::reset_psymtabs): Update.
2928         * objfiles.c (objfile::objfile): Update.
2929         * psymtab.h (psymtab_storage::obstack): Update.
2930         (psymtab_storage::m_obstack): Use gdb::optional.
2931         (class psymtab_storage): Update comment.  Remove objfile
2932         parameter.
2933         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2934
2935 2019-01-10  Tom Tromey  <tom@tromey.com>
2936
2937         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2938         <free_psymtabs>: Now private.
2939         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2940         (allocate_psymtab): Use new method.
2941
2942 2019-01-10  Tom Tromey  <tom@tromey.com>
2943
2944         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2945         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2946         * mdebugread.c (parse_partial_symbols): Use
2947         allocate_dependencies.
2948         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2949         allocate_dependencies.
2950         (process_psymtab_comp_unit_reader)
2951         (build_type_psymtab_dependencies): Likewise.
2952         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2953
2954 2019-01-10  Tom Tromey  <tom@tromey.com>
2955
2956         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2957         PSYMBOL_SET_LANGUAGE.
2958         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2959
2960 2019-01-10  Tom Tromey  <tom@tromey.com>
2961
2962         * psymtab.h (psymtab_storage::obstack): New method.
2963         <m_obstack>: Rename from obstack; now private.
2964         * psymtab.c (psymtab_storage): Update.
2965         * dwarf2read.c (create_addrmap_from_index)
2966         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2967         Update.
2968
2969 2019-01-10  Tom Tromey  <tom@tromey.com>
2970
2971         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2972         * objfiles.h (objfile::reset_psymtabs): New method.
2973
2974 2019-01-10  Tom Tromey  <tom@tromey.com>
2975
2976         * symmisc.c (print_symbol_bcache_statistics): Update.
2977         (print_objfile_statistics): Update.
2978         * symfile.c (reread_symbols): Update.
2979         * psymtab.h (class psymtab_storage): New.
2980         * psymtab.c (psymtab_storage): New constructor.
2981         (~psymtab_storage): New destructor.
2982         (require_partial_symbols): Update.
2983         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2984         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2985         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2986         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2987         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2988         (start_psymtab_common, end_psymtab_common)
2989         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2990         (allocate_psymtab): Update.
2991         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2992         Update.
2993         (dump_psymtab_addrmap, maintenance_print_psymbols)
2994         (maintenance_check_psymtabs): Update.
2995         (class objfile_psymtabs): Move to objfiles.h.
2996         * psympriv.h (discard_psymtab): Now inline.
2997         (psymtab_discarder::psymtab_discarder): Update.
2998         (psymtab_discarder::~psymtab_discarder): Update.
2999         (ALL_OBJFILE_PSYMTABS): Rewrite.
3000         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3001         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3002         Remove fields.
3003         <partial_symtabs>: New field.
3004         (class objfile_psymtabs): Move from psymtab.h.  Update.
3005         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3006         psymbol_cache.
3007         (objfile::~objfile): Don't destroy psymbol_cache.
3008         * mdebugread.c (parse_partial_symbols): Update.
3009         * dwarf2read.c (create_addrmap_from_index)
3010         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3011         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3012         (add_partial_subprogram, dwarf2_ranges_read): Update.
3013         * dwarf-index-write.c (write_address_map)
3014         (write_one_signatured_type, recursively_write_psymbols)
3015         (class debug_names, class debug_names, write_psymtabs_to_index):
3016         Update.
3017
3018 2019-01-10  Tom Tromey  <tom@tromey.com>
3019
3020         * symtab.h (SYMBOL_SET_NAMES): Update.
3021         (symbol_set_names): Update.
3022         (MSYMBOL_SET_NAMES): Update.
3023         * symtab.c (symbol_set_names): Change argument to be an
3024         objfile_per_bfd_storage.
3025         * psymtab.c (add_psymbol_to_bcache): Update.
3026         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3027
3028 2019-01-10  Tom Tromey  <tom@tromey.com>
3029
3030         * symtab.c (create_demangled_names_hash): Change argument to be an
3031         objfile_per_bfd_storage.
3032         (symbol_set_names): Update.
3033
3034 2019-01-10  Tom Tromey  <tom@tromey.com>
3035
3036         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3037         init_psymbol_list.
3038         * psymtab.c (init_psymbol_list): Do nothing if already called.
3039         * psympriv.h (init_psymbol_list): Add comment.
3040         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3041         init_psymbol_list.
3042         * dbxread.c (dbx_symfile_read): Unconditionally call
3043         init_psymbol_list.
3044
3045 2019-01-10  Tom Tromey  <tom@tromey.com>
3046
3047         * xcoffread.c (scan_xcoff_symtab): Update.
3048         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3049         "where".
3050         * mdebugread.c (parse_partial_symbols)
3051         (handle_psymbol_enumerators): Update.
3052         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3053         * dbxread.c (read_dbx_symtab): Update.
3054         * psympriv.h (psymbol_placement): New enum.
3055         (add_psymbol_to_list): Update.
3056
3057 2019-01-10  Tom Tromey  <tom@tromey.com>
3058
3059         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3060         static_psymbols parameters.
3061         (scan_xcoff_symtab): Update.
3062         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3063         static_psymbols parameters.
3064         * psympriv.h (start_psymtab_common): Update.
3065         * mdebugread.c (parse_partial_symbols): Update.
3066         * dwarf2read.c (create_partial_symtab): Update.
3067         * dbxread.c (read_dbx_symtab): Update.
3068         (start_psymtab): Remove global_psymbols and static_psymbols
3069         parameters.
3070
3071 2019-01-10  Tom Tromey  <tom@tromey.com>
3072
3073         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3074         * psymtab.c (allocate_psymtab): Add comment.
3075         * psympriv.h (allocate_psymtab): Add comment.
3076         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3077         initializations.
3078         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3079
3080 2019-01-10  Tom Tromey  <tom@tromey.com>
3081
3082         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3083         Don't declare.
3084         * mipsread.c: Include mdebugread.h.
3085         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3086         Declare.
3087         * elfread.c: Include mdebugread.h.
3088
3089 2019-01-09  Tom Tromey  <tom@tromey.com>
3090
3091         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3092         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3093         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3094         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3095         (psym_lookup_symbol, psym_find_last_source_symtab)
3096         (psym_forget_cached_source_info, psym_print_stats)
3097         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3098         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3099         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3100         (psym_find_compunit_symtab_by_address)
3101         (maintenance_print_psymbols, maintenance_info_psymtabs)
3102         (maintenance_check_psymtabs): Use ranged for.
3103         * psymtab.h (class objfile_psymtabs): New.
3104         (require_partial_symbols): Return objfile_psymtabs.
3105         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3106
3107 2019-01-09  Tom Tromey  <tom@tromey.com>
3108
3109         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3110         (find_pc_mapped_section, list_overlays_command)
3111         (map_overlay_command, unmap_overlay_command)
3112         (simple_overlay_update): Use all_objfiles.
3113         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3114         * printcmd.c (info_symbol_command): Use all_objfiles.
3115         * objfiles.h (ALL_OBJSECTIONS): Remove.
3116         * maint.c (maintenance_translate_address): Use all_objfiles.
3117         * gcore.c (gcore_create_callback): Use all_objfiles.
3118         (objfile_find_memory_regions): Likewise.
3119
3120 2019-01-09  Tom Tromey  <tom@tromey.com>
3121
3122         * symtab.c (find_line_symtab, info_sources_command)
3123         (make_source_files_completion_list): Use objfile_compunits.
3124         * source.c (select_source_symtab): Use objfile_compunits.
3125         * objfiles.h (struct objfile): Update comment.
3126         (ALL_OBJFILES): Remove.
3127         (ALL_FILETABS): Remove.
3128         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3129         objfile_compunits.
3130
3131 2019-01-09  Tom Tromey  <tom@tromey.com>
3132
3133         * symmisc.c (print_objfile_statistics, dump_objfile)
3134         (maintenance_print_symbols): Use compunit_filetabs.
3135         * source.c (forget_cached_source_info_for_objfile): Use
3136         compunit_filetabs.
3137         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3138         (ALL_FILETABS): Use compunit_filetabs.
3139         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3140         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3141
3142 2019-01-09  Tom Tromey  <tom@tromey.com>
3143
3144         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3145         (compunit_filetabs): New.
3146         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3147         compunit_filetabs.
3148         (info_sources_command, make_source_files_completion_list): Remove
3149         declaration.
3150         * symmisc.c (print_objfile_statistics, dump_objfile)
3151         (maintenance_print_symbols): Remove declaration.
3152         (maintenance_info_symtabs): Use compunit_filetabs.
3153         (maintenance_info_line_tables): Likewise.
3154         * source.c (select_source_symtab): Change local variable name.
3155         (forget_cached_source_info_for_objfile): Remove declaration.
3156         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3157         * objfiles.c (objfile_relocate1): Remove declaration.
3158         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3159         declaration.
3160         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3161         * coffread.c (coff_symtab_read): Remove declaration.
3162         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3163         compunit_filetabs.
3164
3165 2019-01-09  Tom Tromey  <tom@tromey.com>
3166
3167         * symtab.c (lookup_objfile_from_block)
3168         (find_pc_sect_compunit_symtab, search_symbols)
3169         (default_collect_symbol_completion_matches_break_on): Use
3170         objfile_compunits.
3171         * objfiles.h (ALL_COMPUNITS): Remove.
3172         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3173         * cp-support.c (add_symbol_overload_list_qualified): Use
3174         objfile_compunits.
3175         * ada-lang.c (ada_collect_symbol_completion_matches)
3176         (ada_add_global_exceptions): Use objfile_compunits.
3177
3178 2019-01-09  Tom Tromey  <tom@tromey.com>
3179
3180         * source.c (select_source_symtab)
3181         (forget_cached_source_info_for_objfile): Remove declaration.
3182         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3183         declaration.
3184         * maint.c (count_symtabs_and_blocks): Remove declaration.
3185         * cp-support.c (add_symbol_overload_list_qualified): Remove
3186         declaration.
3187         * coffread.c (coff_symtab_read): Remove declaration.
3188         * symtab.c (lookup_symbol_in_objfile_symtabs)
3189         (basic_lookup_transparent_type_1): Use objfile_compunits.
3190         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3191         (info_sources_command, search_symbols)
3192         (default_collect_symbol_completion_matches_break_on)
3193         (make_source_files_completion_list): Remove declaration.
3194         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3195         (ada_collect_symbol_completion_matches)
3196         (ada_add_global_exceptions): Remove declaration.
3197         * linespec.c (iterate_over_all_matching_symtabs): Use
3198         objfile_compunits.
3199         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3200         (class objfile_compunits): New.
3201         (ALL_COMPUNITS): Use objfile_compunits.
3202         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3203         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3204         objfile_compunits.
3205         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3206
3207 2019-01-09  Tom Tromey  <tom@tromey.com>
3208
3209         * symtab.c (search_symbols)
3210         (default_collect_symbol_completion_matches_break_on): Use
3211         objfile_msymbols.
3212         * ada-lang.c (ada_lookup_simple_minsym)
3213         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3214         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3215         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3216         objfile_msymbols.
3217         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3218         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3219         * objc-lang.c (find_methods): Use objfile_msymbols.
3220         (info_selectors_command, info_classes_command): Likewise.
3221         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3222         * objfiles.h (class objfile_msymbols): New.
3223         (ALL_OBJFILE_MSYMBOLS): Remove.
3224         (ALL_MSYMBOLS): Remove.
3225
3226 2019-01-09  Tom Tromey  <tom@tromey.com>
3227
3228         * common/next-iterator.h (next_adapter): Add Iterator template
3229         parameter.
3230         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3231         (class all_objfiles_safe): New.
3232         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3233         * objfiles.c (put_objfile_before): Update comment.
3234         (add_separate_debug_objfile): Likewise.
3235         (free_all_objfiles): Use all_objfiles_safe.
3236         (objfile_purge_solibs): Likewise.
3237
3238 2019-01-09  Tom Tromey  <tom@tromey.com>
3239
3240         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3241         (expand_symtab_containing_pc, lookup_static_symbol)
3242         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3243         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3244         all_objfiles.
3245         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3246         * breakpoint.c (create_overlay_event_breakpoint)
3247         (create_longjmp_master_breakpoint)
3248         (create_std_terminate_master_breakpoint)
3249         (create_exception_master_breakpoint): Use all_objfiles.
3250         * linux-thread-db.c (try_thread_db_load_from_pdir)
3251         (has_libpthread): Use all_objfiles.
3252         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3253         * linespec.c (iterate_over_all_matching_symtabs)
3254         (search_minsyms_for_name): Use all_objfiles.
3255         * maint.c (maintenance_info_sections): Use all_objfiles.
3256         * main.c (captured_main_1): Use all_objfiles.
3257         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3258         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3259         * guile/scm-pretty-print.c
3260         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3261         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3262         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3263         (maintenance_print_msymbols): Use all_objfiles.
3264         * source.c (select_source_symtab): Use all_objfiles.
3265         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3266         * symfile.c (remove_symbol_file_command)
3267         (expand_symtabs_matching, map_symbol_filenames): Use
3268         all_objfiles.
3269         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3270         all_objfiles.
3271         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3272         * objc-lang.c (find_methods): Use all_objfiles.
3273         * objfiles.c (have_partial_symbols, have_full_symbols)
3274         (have_minimal_symbols, qsort_cmp)
3275         (default_iterate_over_objfiles_in_search_order): Use
3276         all_objfiles.
3277         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3278         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3279         (maintenance_check_psymtabs): Use all_objfiles.
3280         (ALL_PSYMTABS): Remove.
3281         * compile/compile-object-run.c (do_module_cleanup): Use
3282         all_objfiles.
3283         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3284         * cp-support.c (add_symbol_overload_list_qualified): Use
3285         all_objfiles.
3286         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3287         Use all_objfiles.
3288         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3289         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3290         all_objfiles.
3291         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3292         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3293         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3294         Uses all_objfiles.
3295         * solib.c (solib_read_symbols): Use all_objfiles
3296
3297 2019-01-09  Tom Tromey  <tom@tromey.com>
3298
3299         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3300         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3301         all_objfiles.
3302         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3303         * symmisc.c (print_symbol_bcache_statistics)
3304         (print_objfile_statistics, maintenance_print_objfiles)
3305         (maintenance_info_symtabs, maintenance_check_symtabs)
3306         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3307         all_objfiles.
3308         * source.c (forget_cached_source_info): Use all_objfiles.
3309         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3310         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3311         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3312         * objfiles.c (update_section_map): Use all_objfiles.
3313         (shared_objfile_contains_address_p): Likewise.
3314         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3315         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3316
3317 2019-01-09  Tom Tromey  <tom@tromey.com>
3318
3319         * common/next-iterator.h: New file.
3320         * objfiles.h (class all_objfiles): New.
3321         (struct objfile_iterator): New.
3322
3323 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3324
3325         * NEWS: Move the description of the changed "frame", "select-frame",
3326          and "info frame" commands to the Changed commands section.
3327
3328 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3329
3330         * gdbtypes.c (check_stub_method_group): Remove handling of old
3331         mangling schemes.
3332         * linespec.c (find_methods): Likewise.
3333         * stabsread.c (read_member_functions): Likewise.
3334         * valops.c (search_struct_method): Likewise.
3335         (value_struct_elt_for_reference): Likewise.
3336         * NEWS: Mention this change.
3337
3338 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3339
3340         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3341         print_source_lines.
3342         * source.c (print_source_lines_base): Update line number check.
3343         (print_source_lines): New function.
3344         (source_lines_range::source_lines_range): New function.
3345         * source.h (class source_lines_range): New class.
3346         (print_source_lines): New declaration.
3347
3348 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3349
3350         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3351
3352 2019-01-08  Tom Tromey  <tom@tromey.com>
3353             Simon Marchi  <simon.marchi@ericsson.com>
3354
3355         PR gdb/24060
3356         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3357         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3358         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3359         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3360         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3361         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3362
3363 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3364
3365         * source.c (select_source_symtab): Move header comment to
3366         declaration in source.h.
3367         (forget_cached_source_info_for_objfile): Likewise.
3368         (forget_cached_source_info): Likewise.
3369         (identify_source_line): Likewise.
3370         * source.h (identify_source_line): Move declaration from symtab.h
3371         and add comment from source.c
3372         (print_source_lines): Likewise.
3373         (forget_cached_source_info_for_objfile): Likewise.
3374         (forget_cached_source_info): Likewise.
3375         (select_source_symtab): Likewise.
3376         (enum print_source_lines_flag): Move definition from symtab.h.
3377         * symtab.h (identify_source_line): Move declaration to source.h.
3378         (print_source_lines): Likewise.
3379         (forget_cached_source_info_for_objfile): Likewise.
3380         (forget_cached_source_info): Likewise.
3381         (select_source_symtab): Likewise.
3382         (enum print_source_lines_flag): Move definition to source.h.
3383         * tui/tui-hooks.c: Add 'source.h' include.
3384
3385 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3386
3387         * source.c (print_source_lines_base): Handle requests to print
3388         reverse line number sequences, and guard against empty lines
3389         string.
3390
3391 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3392
3393         * source.c (print_source_lines_base): Fix skip of '\r' if next
3394         character is '\n'.
3395
3396 2019-01-06  Tom Tromey  <tom@tromey.com>
3397
3398         * c-exp.y (struct c_parse_state) <macro_original_text,
3399         expansion_obstack>: New member.
3400         (macro_original_text, expansion_obstack): Remove globals.
3401         (scan_macro_expansion, scanning_macro_expansion)
3402         (finished_macro_expansion): Update.
3403         (scan_macro_cleanup): Remove.
3404         (yylex, c_parse): Update.
3405
3406 2019-01-06  Tom Tromey  <tom@tromey.com>
3407
3408         * c-exp.y (struct c_parse_state) <strings>: New member.
3409         (operator_stoken): Update.
3410
3411 2019-01-06  Tom Tromey  <tom@tromey.com>
3412
3413         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3414         (union type_stack_elt) <typelist_val>: Now a pointer to
3415         std::vector.
3416         (type_stack_cleanup): Don't declare.
3417         (push_typelist): Update.
3418         * parse.c (pop_typelist): Return a std::vector.
3419         (push_typelist): Take a std::vector.
3420         (follow_types): Update.  Do not free args.
3421         (type_stack_cleanup): Remove.
3422         * c-exp.y (struct c_parse_state): New.
3423         (cpstate): New global.
3424         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3425         (nonempty_typelist): Update.
3426         (func_mod): Create a new vector.
3427         (c_parse): Create a c_parse_state.
3428         (check_parameter_typelist): Do not delete params.
3429         (function_method): Update.  Do not delete type_list.
3430
3431 2019-01-06  Tom Tromey  <tom@tromey.com>
3432
3433         PR gdb/28155:
3434         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3435         check_typedef.
3436         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3437         (print_return_value): Likewise.
3438
3439 2019-01-05  Tom Tromey  <tom@tromey.com>
3440
3441         * contrib/cleanup_check.py: Remove.
3442         * contrib/gcc-with-excheck: Remove.
3443         * contrib/exsummary.py: Remove.
3444         * contrib/excheck.py: Remove.
3445
3446 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3447
3448         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3449         NULL. Initialize tpprev to NULL instead of assigning it
3450         to NULL on the next statement.
3451         * windows-nat.c (windows_delete_thread): Remove check for
3452         main_thread_id before printing thread exit notifications.
3453         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3454         Remove thread ID check against main_thread_id.
3455         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3456         windows_delete_thread.
3457         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3458
3459 2019-01-04  Tom Tromey  <tom@tromey.com>
3460
3461         * compile/compile.c (_initialize_compile): Use upper case for
3462         metasyntactic variables.
3463         * symmisc.c (_initialize_symmisc): Use upper case for
3464         metasyntactic variables.
3465         * psymtab.c (_initialize_psymtab): Use upper case for
3466         metasyntactic variables.
3467         * demangle.c (demangle_command): Use upper case for metasyntactic
3468         variables.
3469         (_initialize_demangler): Likewise.
3470         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3471         variables.
3472
3473 2019-01-03  Tom Tromey  <tom@tromey.com>
3474
3475         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3476
3477 2019-01-03  Tom Tromey  <tom@tromey.com>
3478
3479         * python/py-symtab.c (salpy_str): Update.
3480         (struct salpy_sal_object) <symtab>: Now a PyObject.
3481         (salpy_dealloc): Update.
3482         (del_objfile_sal): Use gdbpy_ref.
3483
3484 2019-01-03  Tom Tromey  <tom@tromey.com>
3485
3486         * python/py-type.c (convert_field): Use new_reference.  Return
3487         gdbpy_ref.
3488         (make_fielditem): Return gdbpy_ref.
3489         (typy_fields): Update.
3490         (typy_getitem): Update.
3491         (field_name): Return gdbpy_ref.  Use new_reference.
3492         (typy_iterator_iternext): Update.
3493
3494 2019-01-03  Tom Tromey  <tom@tromey.com>
3495
3496         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3497
3498 2019-01-03  Tom Tromey  <tom@tromey.com>
3499
3500         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3501         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3502         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3503         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3504         (pspy_set_type_printers): Likewise.
3505         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3506         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3507         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3508         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3509         (objfpy_set_type_printers): Likewise.
3510
3511 2019-01-03  Tom Tromey  <tom@tromey.com>
3512
3513         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3514         (gdbpy_print_stack): Use gdbpy_err_fetch.
3515         * python/python-internal.h (class gdbpy_err_fetch): New class.
3516         (class gdbpy_enter) <m_error_type, m_error_value,
3517         m_error_traceback>: Remove.
3518         <m_error>: New member.
3519         (gdbpy_exception_to_string): Don't declare.
3520         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3521         * python/py-value.c (convert_value_from_python): Use
3522         gdbpy_err_fetch.
3523         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3524         gdbpy_exception_to_string.
3525         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3526         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3527         gdbpy_err_fetch.
3528
3529 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3530
3531         * linux-nat.c (delete_lwp_cleanup): Delete.
3532         (struct lwp_deleter): New struct.
3533         (lwp_info_up): New typedef.
3534         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3535         lwp_info_up.
3536
3537 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * linux-fork.c (class scoped_switch_fork_info): New class.
3540         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3541
3542 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3543
3544         * valops.c (find_overload_match): Remove use of null_cleanup, and
3545         calls to do_cleanups.
3546
3547 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3548
3549         * compile/compile-cplus-types.c
3550         (compile_cplus_instance::decl_name): Handle changes to
3551         cp_func_name.
3552         * cp-support.c (cp_func_name): Update header comment, update
3553         return type.
3554         * cp-support.h (cp_func_name): Update return type in declaration.
3555         * valops.c (find_overload_match): Move temp_func local to top
3556         level of function and change its type.  Use temp_func to hold and
3557         delete temporary string obtained from cp_func_name.
3558
3559 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3560
3561         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3562         gdb::char_vector, remove cleanup, and update uses of `msg`.
3563
3564 2019-01-03  Jim Wilson  <jimw@sifive.com>
3565
3566         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3567
3568 2019-01-02  Tom Tromey  <tom@tromey.com>
3569
3570         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3571         (tdesc_parse_xml): Remove cleanups.
3572         * target-descriptions.h (make_cleanup_free_target_description):
3573         Don't declare.
3574         (target_desc_deleter): New struct.
3575         (target_desc_up): New typedef.
3576         * target-descriptions.c (target_desc_deleter::operator()): Rename
3577         from free_target_description.
3578         (make_cleanup_free_target_description): Remove.
3579
3580 2019-01-02  Tom Tromey  <tom@tromey.com>
3581
3582         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3583         constructor, destructor.
3584         (linespec_parser): Remove typedef.
3585         (~linespec_parser): Rename from linespec_parser_delete.
3586         (linespec_lex_to_end, linespec_complete_label)
3587         (linespec_complete): Update.
3588         (decode_line_full): Remove cleanups.
3589         (decode_line_1): Update.
3590
3591 2019-01-02  Tom Tromey  <tom@tromey.com>
3592
3593         * python/python-internal.h (inferior_to_inferior_object): Change
3594         return type.
3595         * python/py-exitedevent.c (create_exited_event_object): Update.
3596         * python/py-inferior.c (inferior_to_inferior_object): Return
3597         gdbpy_ref.
3598         (python_new_inferior, python_inferior_deleted)
3599         (thread_to_thread_object, delete_thread_object)
3600         (build_inferior_list, gdbpy_selected_inferior): Update.
3601         * python/py-infthread.c (create_thread_object): Update.  Also fail
3602         if inferior_to_inferior_object fails.
3603
3604 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3605
3606         * inferior.h (class inferior) <displaced_step_state>: New field.
3607         * infrun.h (struct displaced_step_state): Move here from
3608         infrun.c.  Initialize fields, add constructor.
3609         <inf>: Remove field.
3610         <reset>: New method.
3611         * infrun.c (struct displaced_step_inferior_state): Move to
3612         infrun.h.
3613         (displaced_step_inferior_states): Remove.
3614         (get_displaced_stepping_state): Adust.
3615         (displaced_step_in_progress_any_inferior): Adjust.
3616         (displaced_step_in_progress_thread): Adjust.
3617         (displaced_step_in_progress): Adjust.
3618         (add_displaced_stepping_state): Remove.
3619         (get_displaced_step_closure_by_addr): Adjust.
3620         (remove_displaced_stepping_state): Remove.
3621         (infrun_inferior_exit): Call displaced_step_state.reset.
3622         (use_displaced_stepping): Don't check for NULL.
3623         (displaced_step_prepare_throw): Call
3624         get_displaced_stepping_state.
3625         (displaced_step_fixup): Don't check for NULL.
3626         (prepare_for_detach): Don't check for NULL.
3627
3628 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3629
3630         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3631          in case of call that did not complete.
3632
3633 2019-01-02  Andrey Utkin  <autkin@undo.io>
3634
3635         * symfile.c (find_separate_debug_file): Fix search of debug files for
3636         remote debuggee.
3637
3638 2019-01-02  Tom Tromey  <tom@tromey.com>
3639
3640         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3641         indentation.
3642         * python/py-frame.c (frapy_older): Remove cast.
3643         (frapy_newer): Likewise.
3644         * python/py-breakpoint.c (local_setattro): Remove cast.
3645         * python/py-arch.c (archpy_name): Remove local variable.
3646         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3647
3648 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3649
3650         * unittests/basic_string_view/element_access/char/empty.cc:
3651         Fix year range in copyright header.
3652
3653 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3654
3655         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3656         Delete.
3657         <operator==>: Update with for removed field.
3658         <hash>: Likewise.
3659         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3660         <isa_features>: ...this.
3661         <abi_features>: New field.
3662         (riscv_isa_flen): Update comment.
3663         (riscv_abi_xlen): New declaration.
3664         (riscv_abi_flen): New declaration.
3665         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3666         isa_features.
3667         (riscv_abi_xlen): New function.
3668         (riscv_isa_flen): Update to get answer from isa_features.
3669         (riscv_abi_flen): New function.
3670         (riscv_has_fp_abi): Update to get answer from abi_features.
3671         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3672         xlen and flen.
3673         (riscv_call_info) <xlen, flen>: Update comment.
3674         (riscv_call_arg_struct): Remove invalid assertions
3675         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3676         is removed.
3677         (riscv_gdbarch_init): Gather isa features and abi features
3678         separately, ensure both match on the gdbarch when reusing an old
3679         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3680         a target with 64-bit float hardware.
3681
3682 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3683
3684         * source.c (search_command_helper): Stop reverse search
3685         when line 1 has been searched.
3686
3687 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3688
3689         * record-full.c (record_full_base_target::close): Rewrite
3690         record_full_core_buf_list free logic.
3691
3692 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3693
3694         * break-catch-syscall.c (print_one_catch_syscall): xfree
3695         the last text.
3696
3697 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3698
3699         * top.c (print_gdb_version): Update Copyright year in version
3700         message.
3701
3702 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3703
3704         Update copyright year range in all GDB files.
3705
3706 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3707
3708         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3709
3710 For older changes see ChangeLog-2018.
3711 \f
3712 Local Variables:
3713 mode: change-log
3714 left-margin: 8
3715 fill-column: 74
3716 version-control: never
3717 coding: utf-8
3718 End:
3719