gdb/ChangeLog

   1 2019-07-09  Pedro Alves  <palves@redhat.com>
   2
   3         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
   4         "addr" field.
   5         (allocate_location_exception_catchpoint): New.
   6         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
   7         (initialize_throw_catchpoint_ops): Install
   8         allocate_location_exception_catchpoint as allocate_location
   9         method.
  10         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
  11         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
  12         bp_loc_other.
  13         (breakpoint_address_is_meaningful): Delete.
  14         (bl_address_is_meaningful): New.
  15         (breakpoint_locations_match): Adjust comment.
  16         (bp_location_from_bp_type): New, factored out of...
  17         (bp_location::bp_location(breakpoint *)): ... this.
  18         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
  19         factored out of...
  20         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
  21         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
  22         breakpoint_address_is_meaningful.
  23         (bp_locations_compare): Adjust comment.
  24         (update_global_location_list): Use bl_address_is_meaningful
  25         instead of breakpoint_address_is_meaningful.
  26         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
  27         explicit.
  28         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
  29         * python/py-breakpoint.c (bppy_get_location): No longer check
  30         whether location is null.
  31
  32 2019-07-09  Pedro Alves  <palves@redhat.com>
  33
  34         PR c++/15468
  35         * breakpoint.c (print_one_breakpoint_location): Remove
  36         single-location assert.
  37
  38 2019-07-09  Tom Tromey  <tom@tromey.com>
  39
  40         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
  41         * configure: Rebuild.
  42         * configure.ac: Change common to gdbsupport.
  43         * gdbsupport: Rename from common.
  44         * acinclude.m4: Change common to gdbsupport.
  45         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
  46         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
  47         gdbsupport.
  48         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
  49         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
  50         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
  51         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
  52         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
  53         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
  54         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
  55         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
  56         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
  57         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
  58         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
  59         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
  60         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
  61         coff-pe-read.c, command.h, compile/compile-c-support.c,
  62         compile/compile-c.h, compile/compile-cplus-symbols.c,
  63         compile/compile-cplus-types.c, compile/compile-cplus.h,
  64         compile/compile-loc2c.c, compile/compile.c, completer.c,
  65         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
  66         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
  67         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
  68         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
  69         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
  70         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
  71         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
  72         features/aarch64-core.c, features/aarch64-fpu.c,
  73         features/aarch64-pauth.c, features/aarch64-sve.c,
  74         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
  75         features/i386/32bit-core.c, features/i386/32bit-linux.c,
  76         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
  77         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
  78         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
  79         features/i386/64bit-core.c, features/i386/64bit-linux.c,
  80         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
  81         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
  82         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
  83         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
  84         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
  85         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
  86         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
  87         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
  88         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
  89         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
  90         go32-nat.c, guile/guile.c, guile/scm-ports.c,
  91         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
  92         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
  93         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
  94         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
  95         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
  96         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
  97         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
  98         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
  99         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 100         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 101         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 102         minsyms.c, mips-linux-tdep.c, namespace.h,
 103         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 104         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 105         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 106         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 107         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 108         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 109         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 110         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 111         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 112         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 113         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 114         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 115         procfs.c, producer.c, progspace.h, psymtab.h,
 116         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 117         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 118         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 119         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 120         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 121         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 122         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 123         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 124         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 125         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 126         target-memory.c, target.c, target.h, target/waitstatus.c,
 127         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 128         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 129         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 130         unittests/array-view-selftests.c,
 131         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 132         unittests/common-utils-selftests.c,
 133         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 134         unittests/format_pieces-selftests.c,
 135         unittests/function-view-selftests.c,
 136         unittests/lookup_name_info-selftests.c,
 137         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 138         unittests/mkdir-recursive-selftests.c,
 139         unittests/observable-selftests.c,
 140         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 141         unittests/parse-connection-spec-selftests.c,
 142         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 143         unittests/scoped_fd-selftests.c,
 144         unittests/scoped_mmap-selftests.c,
 145         unittests/scoped_restore-selftests.c,
 146         unittests/string_view-selftests.c, unittests/style-selftests.c,
 147         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 148         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 149         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 150         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 151         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 152         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 153
 154 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 155
 156         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 157         bool value.
 158         (decode_digits_ordinary): Set explicit_line field in sal.
 159         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 160         symtab_and_line that was set on an explicit line number in
 161         assembler code.  Do always update the recorded symtab and line if
 162         we do skip the prologue.
 163
 164 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 165
 166         * breakpoint.c (set_breakpoint_location_function): Remove
 167         explicit_loc parameter.
 168         (momentary_breakpoint_from_master): Update call to
 169         set_breakpoint_location_function.
 170         (add_location_to_breakpoint): Likewise.
 171
 172 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 173
 174         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 175         required features based on default bfd type when no specific bfd
 176         is present.
 177
 178 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 179
 180         * NEWS: Mention that GDB printf and eval commands can now print
 181         C-style and Ada-style convenience var strings without
 182         calling the inferior.
 183         * printcmd.c (printf_c_string): Locally print GDB internal var
 184         instead of transiting via the inferior.
 185         (printf_wide_c_string): Likewise.
 186
 187 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 188
 189         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 190
 191 2019-07-04  Tom Tromey  <tom@tromey.com>
 192
 193         PR tui/24724:
 194         * tui/tui-winsource.c (tui_clear_source_content): Update.
 195         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 196         (tui_update_breakpoint_info): Update.
 197         (tui_set_exec_info_content): Update.
 198         * tui/tui-source.c (tui_set_source_content_nil): Update.
 199         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 200         has_break.
 201         * tui/tui-data.h (enum tui_bp_flag): New.
 202         (tui_bp_flags): New enum flags type.
 203         (struct tui_source_element) <break_mode>: Change type.  Rename
 204         from has_break.
 205         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 206         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 207         constants.
 208         * tui/tui-winsource.h: Fix comment.
 209
 210 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 211
 212         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 213         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 214         (store_fpregs_to_thread)
 215         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 216         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 217         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 218         (IWMMXT_REGS_SIZE): Add define.
 219         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 220         (fetch_vfp_regs, store_vfp_regs)
 221         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 222         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 223
 224 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 225
 226         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 227         defines.
 228         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 229         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 230         (ARM_INT_REGISTER_SIZE): ...to this.
 231         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 232         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 233         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 234         (arm_linux_collect_gregset, supply_nwfpe_register)
 235         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 236         defines.
 237         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 238         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 239         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 240         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 241         (arm_return_in_memory, arm_store_return_value)
 242         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 243         (arm_record_ld_st_multiple): Likewise.
 244         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 245         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 246
 247 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 248
 249         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 250         AARCH64_DISPLACED_MODIFIED_INSNS.
 251         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 252         (aarch64_displaced_step_copy_insn): Likewise.
 253         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 254         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 255         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 256         ARM_DISPLACED_MODIFIED_INSNS.
 257         * arm-tdep.c (arm_gdbarch_init): Likewise.
 258         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 259         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 260         (struct arm_displaced_step_closure): Use
 261         ARM_DISPLACED_MODIFIED_INSNS.
 262
 263 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 264
 265         * features/Makefile: Remove unused xml files.
 266         * features/aarch64.xml: Remove.
 267         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 268         * features/i386/amd64-avx-avx512.xml: Remove.
 269         * features/i386/amd64-avx-linux.xml: Remove.
 270         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 271         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 272         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 273         * features/i386/amd64-avx-mpx.xml: Remove.
 274         * features/i386/amd64-avx.xml: Remove.
 275         * features/i386/amd64-linux.xml: Remove.
 276         * features/i386/amd64-mpx-linux.xml: Remove.
 277         * features/i386/amd64-mpx.xml: Remove.
 278         * features/i386/amd64.xml: Remove.
 279         * features/i386/i386-avx-avx512-linux.xml: Remove.
 280         * features/i386/i386-avx-avx512.xml: Remove.
 281         * features/i386/i386-avx-linux.xml: Remove.
 282         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 283         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 284         * features/i386/i386-avx-mpx-linux.xml: Remove.
 285         * features/i386/i386-avx-mpx.xml: Remove.
 286         * features/i386/i386-avx.xml: Remove.
 287         * features/i386/i386-linux.xml: Remove.
 288         * features/i386/i386-mmx-linux.xml: Remove.
 289         * features/i386/i386-mmx.xml: Remove.
 290         * features/i386/i386-mpx-linux.xml: Remove.
 291         * features/i386/i386-mpx.xml: Remove.
 292         * features/i386/i386.xml: Remove.
 293         * features/i386/x32-avx-avx512-linux.xml: Remove.
 294         * features/i386/x32-avx-linux.xml: Remove.
 295         * features/i386/x32-linux.xml: Remove.
 296
 297 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 298
 299         * regformats/aarch64.dat: Remove.
 300         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 301         * regformats/i386/amd64-avx-linux.dat: Remove.
 302         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 303         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 304         * regformats/i386/amd64-linux.dat: Remove.
 305         * regformats/i386/amd64-mpx-linux.dat: Remove.
 306         * regformats/i386/amd64.dat: Remove.
 307         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 308         * regformats/i386/i386-avx-linux.dat: Remove.
 309         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 310         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 311         * regformats/i386/i386-linux.dat: Remove.
 312         * regformats/i386/i386-mmx-linux.dat: Remove.
 313         * regformats/i386/i386-mpx-linux.dat: Remove.
 314         * regformats/i386/i386.dat: Remove.
 315         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 316         * regformats/i386/x32-avx-linux.dat: Remove.
 317         * regformats/i386/x32-linux.dat: Remove.
 318
 319 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 320
 321         * aarch64-tdep.c: Remove xml self tests.
 322         * amd64-linux-tdep.c: Likewise.
 323         * amd64-tdep.c: Likewise.
 324         * i386-linux-tdep.c: Likewise.
 325         * i386-tdep.c: Likewise.
 326
 327 2019-07-03  Pedro Alves  <palves@redhat.com>
 328
 329         PR cli/24732
 330         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 331         (pipe_cmd_option_defs): New.
 332         (make_pipe_cmd_options_def_group): New.
 333         (pipe_command): Use gdb::option::process_options.
 334         (pipe_command_completer): New function.
 335         (_initialize_cli_cmds): Install completer for "pipe" command.
 336
 337 2019-07-03  Pedro Alves  <palves@redhat.com>
 338
 339         * cli/cli-option.c (union option_value) <string>: New field.
 340         (struct option_def_and_value): Add ctor, move ctor, dtor and
 341         use DISABLE_COPY_AND_ASSIGN.
 342         (option_def_and_value::clear_value): New.
 343         (parse_option, save_option_value_in_ctx, get_val_type_str)
 344         (add_setshow_cmds_for_options): Handle var_string.
 345         * cli-option.h (union option_def::var_address) <string>: New
 346         field.
 347         (struct string_option_def): New.
 348         * maint-test-options.c (struct test_options_opts): Add default
 349         ctor and use DISABLE_COPY_AND_ASSIGN.
 350         <string_opt>: New field.
 351         (test_options_opts::~test_options_opts): New.
 352         (test_options_opts::dump): Also dump "-string".
 353         (test_options_option_defs): Install "string.
 354
 355 2019-07-03  Pedro Alves  <palves@redhat.com>
 356
 357         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 358         option_value with a null enumeration.
 359         (complete_options): Save the option values in the context.
 360         (save_option_value_in_ctx): New, factored out from ...
 361         (process_options): ... here.
 362         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 363         of the function.
 364         * maint-test-options.c (test_options_opts::dump): New, factored
 365         out from ...
 366         (maintenance_test_options_command_mode): ... here.
 367         (maintenance_test_options_command_completion_result): Delete.
 368         (maintenance_test_options_command_completion_text): Update
 369         comment.
 370         (maintenance_show_test_options_completion_result): Change
 371         prototype.  Just print
 372         maintenance_test_options_command_completion_text.
 373         (save_completion_result): New.
 374         (maintenance_test_options_completer_mode): Pass options context to
 375         complete_options, and then save a dump.
 376         (_initialize_maint_test_options): Use add_cmd to install "maint
 377         show test-options-completion-result".
 378
 379 2019-07-03  Pedro Alves  <palves@redhat.com>
 380
 381         * NEWS (New commands): Mention "with" and "maint with".
 382         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 383         (with_command, with_command_completer): New.
 384         (pipe_command): Adjust to new repeat_previous
 385         interface.
 386         (_initialize_cli_cmds): Install the "with" command and its "w"
 387         alias.
 388         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 389         declarations.
 390         * cli/cli-setshow.c (parse_cli_var_uinteger)
 391         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 392         argument strings for all var_types.
 393         (get_setshow_command_value_string): New, factored out from ...
 394         (do_show_command): ... this.
 395         * cli/cli-setshow.h: Include <string>.
 396         (get_setshow_command_value_string): Declare.
 397         * command.h (repeat_previous): Now returns const char *.  Adjust
 398         comment.
 399         * maint.c: Include "cli/cli-cmds.h".
 400         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 401         (_initialize_maint_cmds): Register the "maintenance with" command.
 402         * top.c (repeat_previous): Move bits from pipe_command here:
 403         Return the saved command line, if any; error out if there's no
 404         command to relaunch.
 405
 406 2019-07-03  Pedro Alves  <palves@redhat.com>
 407
 408         * NEWS (New commands): Mention "maint set/show test-settings"
 409         instead of "maint test-settings".
 410         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 411         (maintenance_test_settings_set_list): Rename to ...
 412         (maintenance_set_test_settings_list): ... this.
 413         (maintenance_test_settings_show_list): Rename to  ...
 414         (maintenance_show_test_settings_list): ... this.
 415         (maintenance_test_settings_cmd): Delete.
 416         (maintenance_test_settings_set_cmd): ...
 417         (maintenance_set_test_settings_cmd): ... this.
 418         (maintenance_test_settings_show_cmd): ...
 419         (maintenance_show_test_settings_cmd): ... this.
 420         (maintenance_test_settings_show_value_cmd):
 421         (maintenance_show_test_settings_value_cmd): ... this.
 422         (_initialize_maint_test_settings): No longer install the "maint
 423         test-settings" prefix command.  Rename "maint test-settings set"
 424         to "maint set test-settings", and "maint test-settings show" to
 425         "maint show test-settings".  Adjust all subcommands.
 426
 427 2019-07-03  Pedro Alves  <palves@redhat.com>
 428
 429         * maint-test-settings.c: Fix file's intro comment.  Replace all
 430         references to "test-options" with references to "test-settings",
 431         in comments.
 432
 433 2019-07-03  Pedro Alves  <palves@redhat.com>
 434
 435         * maint-test-settings.c (maintenance_test_settings_xxx)
 436         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 437         New.
 438         (maintenance_test_settings_enums): Use them.
 439         (maintenance_test_settings_enum): Default to
 440         maintenance_test_settings_xxx.
 441         (_initialize_maint_test_settings): Initialize
 442         MAINTENANCE_TEST_SETTINGS_FILENAME.
 443
 444 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 445
 446         * breakpoint.h (remove_breakpoints_inf): Change return type to
 447         void, move function documentation here.
 448         * breakpoint.c (remove_breakpoints_inf): Change return type to
 449         void, move function documentation to header.
 450
 451 2019-07-02  Pedro Alves  <palves@redhat.com>
 452
 453         * NEWS (Completion improvements): Mention "info threads".
 454         * thread.c (struct info_threads_opts, info_threads_option_defs)
 455         (make_info_threads_options_def_group): New.
 456         (info_threads_command): Use gdb::option::process_options.
 457         (info_threads_command_completer): New.
 458         (_initialize_thread): Use gdb::option::build_help to build the
 459         help text for "info threads".
 460
 461 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 462
 463         * defs.h (generic_load): Move from here...
 464         * symfile.h (generic_load): ... to here.  Rename name parameter
 465         to args.
 466         * symfile.c (generic_load): Add comment.
 467
 468 2019-07-01  Tom Tromey  <tromey@adacore.com>
 469
 470         * dwarf2read.c
 471         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 472         declaration of without_params.  Fix formatting.
 473
 474 2019-07-01  Tom Tromey  <tromey@adacore.com>
 475
 476         * ada-exp.y (find_primitive_type): Update.
 477         * ada-lang.h (ada_lookup_symbol): Update.
 478         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 479         parameter.
 480         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 481
 482 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 483
 484         PR breakpoints/24541
 485         * gdbarch.c: Regenerate.
 486         * gdbarch.h: Regenerate.
 487         * gdbarch.sh: Add 'stap_adjust_register'.
 488         * i386-tdep.c: Include '<unordered_set>'.
 489         (i386_stap_adjust_register): New function.
 490         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 491         * stap-probe.c (stap_parse_register_operand): Call
 492         'gdbarch_stap_adjust_register'.
 493
 494 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 495
 496         PR python/24742
 497         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 498         * python/python.c (do_start_initialization): Use 'xmalloc'
 499         instead of 'PyMem_Malloc'.
 500
 501 2019-06-28  Tom Tromey  <tromey@adacore.com>
 502
 503         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 504         for Ada.
 505
 506 2019-06-27  Tom Tromey  <tromey@adacore.com>
 507
 508         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 509         objfile_key.
 510         (arm_find_mapping_symbol, arm_record_special_symbol)
 511         (_initialize_arm_tdep): Update.
 512         (arm_objfile_data_free): Remove.
 513
 514 2019-06-27  Tom Tromey  <tromey@adacore.com>
 515
 516         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 517         to cp_print_static_field.
 518
 519 2019-06-26  Tom Tromey  <tromey@adacore.com>
 520
 521         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 522         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 523         declare.
 524
 525 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 526
 527         * features/aarch64-core.c (create_feature_aarch64_core):
 528         Regenerate.
 529         * features/aarch64-core.xml: Add cpsr flags.
 530
 531 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 532
 533         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 534         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 535
 536 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 537
 538         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 539         field.
 540         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 541         use.
 542         (arm_record_special_symbol): Don't insert new symbol in sorted
 543         position, push it at the end.
 544
 545 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 546
 547         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 548         (arm_mapping_symbol_s): Remove.
 549         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 550         (arm_mapping_symbol_vec): New typedef.
 551         (struct arm_per_objfile): Add constructor.
 552         <section_maps>: Change type to
 553         std::unique_ptr<arm_mapping_symbol_vec[]>.
 554         (arm_compare_mapping_symbols): Remove.
 555         (arm_find_mapping_symbol): Adjust to section_maps type change.
 556         (arm_objfile_data_free): Call delete on arm_per_objfile.
 557         (arm_record_special_symbol): Adjust to section_maps type change.
 558         Allocate arm_per_objfile with new.
 559
 560 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 561
 562         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 563         with the command prefix.
 564
 565 2019-06-25  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 568         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 569
 570 2019-06-25  Tom Tromey  <tom@tromey.com>
 571
 572         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 573         type.
 574         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 575         protected.
 576
 577 2019-06-25  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-winsource.c
 580         (tui_source_window_base::set_is_exec_point_at): Add check against
 581         LOA_ADDRESS.
 582
 583 2019-06-25  Tom Tromey  <tom@tromey.com>
 584
 585         * tui/tui-source.c (tui_set_source_content): Don't check before
 586         xfree.
 587         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 588
 589 2019-06-25  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-winsource.h (tui_update_source_window_as_is)
 592         (tui_alloc_source_buffer, tui_line_is_displayed)
 593         (tui_addr_is_displayed): Change type of win_info.
 594         * tui/tui-winsource.c (tui_update_source_window_as_is)
 595         (tui_clear_source_content, tui_show_source_line)
 596         (tui_show_source_content, tui_source_window_base::refill)
 597         (tui_source_window_base::set_is_exec_point_at)
 598         (tui_source_window_base::set_is_exec_point_at)
 599         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 600         (tui_alloc_source_buffer, tui_line_is_displayed)
 601         (tui_addr_is_displayed): Change type of win_info.  Update.
 602         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 603         (tui_source_window_base::do_make_visible_with_new_height):
 604         Update.
 605         * tui/tui-source.c (tui_set_source_content)
 606         (tui_set_source_content_nil)
 607         (tui_source_window::do_scroll_vertical): Update.
 608         * tui/tui-layout.c (show_layout): Update.
 609         * tui/tui-disasm.c (tui_set_disassem_content)
 610         (tui_disasm_window::do_scroll_vertical): Update.
 611         * tui/tui-data.h (tui_win_content): Remove.
 612         (struct tui_gen_win_info) <content, content_size>: Remove.
 613         (struct tui_source_element): Add initializers and destructor.
 614         (union tui_which_element, struct tui_win_element): Remove.
 615         (struct tui_source_window_base) <content>: New field.
 616         (struct tui_data_window): Remove destructor.
 617         (tui_alloc_content, tui_free_win_content)
 618         (tui_free_all_source_wins_content): Don't declare.
 619         * tui/tui-data.c (tui_initialize_static_data): Update.
 620         (init_content_element, tui_alloc_content): Remove.
 621         (~tui_gen_win_info): Update.
 622         (~tui_data_window, tui_free_all_source_wins_content)
 623         (tui_free_win_content, free_content, free_content_elements):
 624         Remove.
 625
 626 2019-06-25  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-winsource.h (tui_clear_source_content)
 629         (tui_erase_source_content, tui_show_source_content): Change type
 630         of win_info.
 631         * tui/tui-winsource.c (tui_clear_source_content)
 632         (tui_erase_source_content, tui_show_source_content): Change type
 633         of win_info.
 634         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 635         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 636         win_info.
 637         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 638         win_info.
 639         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 640
 641 2019-06-25  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-winsource.c (tui_clear_source_content)
 644         (tui_source_window_base::set_is_exec_point_at): Update.
 645         * tui/tui-source.c (tui_set_source_content_nil): Update.
 646         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 647         a bool.
 648         * tui/tui-data.c (init_content_element): Update.
 649
 650 2019-06-25  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 653         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 654         * tui/tui-layout.c (init_and_make_win): Update.
 655         * tui/tui.h (enum tui_win_type): Update.
 656         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 657         tui_win_is_auxillary.
 658         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 659         tui_win_is_auxillary.
 660
 661 2019-06-25  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 664         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 665         (tui_delete_data_content_windows, tui_display_all_data)
 666         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 667         Update.
 668         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 669         * tui/tui-regs.c (tui_last_regs_line_no)
 670         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 671         (tui_show_registers): Update.
 672         (tui_show_register_group): Return void.  Update.
 673         (tui_display_registers_from, tui_display_reg_element_at_line)
 674         (tui_display_registers_from_line, tui_check_register_values):
 675         Update.
 676         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 677         member.
 678         (struct tui_data_window) <regs_content>: Now a std::vector.
 679         <regs_content_count>: Remove.
 680         (tui_add_content_elements, tui_free_data_content): Don't declare.
 681         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 682         (init_content_element): Remove DATA_WIN case.  Add assert.
 683         (tui_add_content_elements): Remove.
 684         (tui_data_window): Update.
 685         (tui_free_data_content): Remove.
 686         (free_content_elements): Remove DATA_WIN case.
 687
 688 2019-06-25  Tom Tromey  <tom@tromey.com>
 689
 690         * tui/tui-data.c (tui_data_item_window): Update.
 691         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 692         * tui/tui-windata.c (tui_display_all_data)
 693         (tui_display_data_from_line): Update.
 694         (tui_check_data_values): Remove.
 695         * tui/tui-regs.c (tui_show_register_group)
 696         (tui_display_reg_element_at_line): Update.
 697         * tui/tui-hooks.c (tui_register_changed)
 698         (tui_refresh_frame_and_register_information): Call
 699         tui_check_register_values.
 700         * tui/tui-data.h (struct tui_data_window) <data_content,
 701         data_content_count, data_type>: Remove.
 702         (enum tui_data_type): Remove.
 703
 704         * tui/tui-data.c (tui_data_window::clear_detail)
 705         (~tui_data_window): Update.
 706
 707 2019-06-25  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 710         declare.
 711         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 712         Rename from tui_first_data_item_displayed.  Update.
 713         (tui_data_window::refresh_all)
 714         (tui_data_window::do_scroll_vertical): Update.
 715         * tui/tui-data.h (struct tui_data_window)
 716         <first_data_item_displayed>: Declare new method.
 717
 718 2019-06-25  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 721         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 722         contents...
 723         (tui_initialize_static_data): ...here.
 724
 725 2019-06-25  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 728         (tui_display_registers_from, tui_check_register_values): Update.
 729         (tui_display_register): Remove win_info parameter; update.
 730         (tui_get_register): Change type of parameters.
 731         * tui/tui-data.h (struct tui_data_element): Remove.
 732         (union tui_which_element) <data>: Remove.
 733         <data_window>: Change type.
 734         (struct tui_data_item_window): New.
 735         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 736         case.  Add assert.
 737         (~tui_data_item_window): New destructor.
 738         (free_content_elements): Remove DATA_ITEM_WIN case.
 739
 740 2019-06-25  Tom Tromey  <tom@tromey.com>
 741
 742         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 743         Remove.
 744
 745 2019-06-25  Tom Tromey  <tom@tromey.com>
 746
 747         * tui/tui-data.h (struct tui_command_element): Remove.
 748         (union tui_which_element) <command>: Remove.
 749         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 750         assert.
 751         (free_content_elements): Remove CMD_WIN case.
 752
 753 2019-06-25  Tom Tromey  <tom@tromey.com>
 754
 755         * tui/tui-layout.c (tui_set_layout): Update.
 756         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 757         * tui/tui-data.c (layout_def): Update.
 758
 759 2019-06-25  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 762         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 763         (tui_source_window_base::set_new_height): Update.
 764         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 765         Update.
 766         (tui_set_locator_fullname, tui_set_locator_info)
 767         (tui_show_frame_info): Update.
 768         * tui/tui-source.c (tui_set_source_content)
 769         (tui_source_is_displayed): Update.
 770         * tui/tui-layout.c (show_source_disasm_command, show_data)
 771         (show_source_or_disasm_and_command): Update.
 772         * tui/tui-disasm.c (tui_set_disassem_content)
 773         (tui_get_begin_asm_address): Update.
 774         * tui/tui-data.h (struct tui_locator_element): Remove.
 775         (union tui_which_element) <locator>: Remove.
 776         (struct tui_locator_window): New.
 777         (tui_locator_win_info_ptr): Change return type.
 778         * tui/tui-data.c (_locator): Change type.
 779         (tui_locator_win_info_ptr): Change return type.
 780         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 781         (tui_alloc_content): Add assert.
 782
 783 2019-06-25  Tom Tromey  <tom@tromey.com>
 784
 785         * tui/tui-winsource.c
 786         (tui_exec_info_window::maybe_allocate_content): New method.
 787         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 788         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 789         (make_source_or_disasm_window): Add cast.
 790         * tui/tui-data.h (union tui_which_element) <simple_string>:
 791         Remove.
 792         (struct tui_source_info): New.
 793         (struct tui_source_window_base) <execution_info>: Change type.
 794         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 795         case, and add assert.
 796         (tui_alloc_content): Add assert.
 797
 798 2019-06-25  Tom Tromey  <tom@tromey.com>
 799
 800         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 801         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 802         * tui/tui-data.c (tui_alloc_win_info): Remove.
 803
 804 2019-06-25  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 807         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 808         can_highlight.
 809
 810 2019-06-25  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 813         make_visible_with_new_height method.
 814         (tui_win_info::make_visible_with_new_height): New method.
 815         (tui_source_window_base::do_make_visible_with_new_height)
 816         (tui_data_window::do_make_visible_with_new_height)
 817         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 818         (make_visible_with_new_height): Remove.
 819         (tui_resize_all, tui_adjust_win_heights): Use
 820         make_visible_with_new_height method.
 821         * tui/tui-data.h (struct tui_win_info)
 822         <do_make_visible_with_new_height, make_visible_with_new_height>:
 823         New methods.
 824         (struct tui_source_window_base, struct tui_data_window)
 825         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 826         methods.
 827
 828 2019-06-25  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 831         method.
 832         (update_tab_width): Call update_tab_width method.
 833         * tui/tui-data.h (struct tui_win_info)
 834         (struct tui_source_window_base) <update_tab_width>: New methods.
 835
 836 2019-06-25  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 839         parameter.
 840         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 841         parameter.
 842         (tui_gen_win_info::make_visible): Update.
 843         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 844         parameter.
 845         * tui/tui-data.h (enum tui_box): New enum.
 846         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 847
 848 2019-06-25  Tom Tromey  <tom@tromey.com>
 849
 850         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 851         init_and_make_win for EXEC_INFO_WIN.
 852         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 853         longer inline.
 854         (struct tui_win_info) <~tui_win_info>: Inline.
 855         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 856         Don't declare.
 857         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 858         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 859         Remove.
 860         (tui_initialize_static_data): Update.
 861         (~tui_gen_win_info): Handle more cleanup here.
 862         (~tui_source_window_base): Delete "execution_info".
 863         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 864
 865 2019-06-25  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-layout.c (make_command_window): Don't set
 868         can_highlight.
 869         (show_source_disasm_command): Call the reset method.
 870         (show_data): Don't set can_highlight.  Call the reset method.
 871         (tui_gen_win_info::reset): Rename from init_gen_win_info
 872         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 873         (show_source_or_disasm_and_command): Call the reset method.
 874         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 875         (struct tui_cmd_window): Set can_highlight.
 876
 877 2019-06-25  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 880         from make_visible.
 881         (tui_make_visible, tui_make_invisible): Rewrite.
 882         (tui_win_info::make_visible): Remove.
 883         (tui_source_window_base::make_visible): Update.
 884         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 885         method.  Moved from...
 886         (struct tui_win_info) <make_visible>: ...here.
 887
 888 2019-06-25  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-winsource.c
 891         (tui_source_window_base::do_scroll_horizontal): Remove direction
 892         parameter.
 893         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 894         direction parameter.
 895         * tui/tui-win.c (tui_win_info::forward_scroll)
 896         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 897         (tui_win_info::right_scroll): Update.
 898         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 899         direction parameter.
 900         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 901         direction parameter.
 902         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 903         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 904         Remove direction parameter.
 905         (struct tui_source_window_base, struct tui_source_window)
 906         (struct tui_disasm_window, struct tui_data_window)
 907         (struct tui_cmd_window): Update.
 908
 909 2019-06-25  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-winsource.h (tui_set_exec_info_content)
 912         (tui_show_exec_info_content, tui_erase_exec_info_content)
 913         (tui_clear_exec_info_content, tui_update_exec_info): Change
 914         argument to tui_source_window_base.
 915         * tui/tui-winsource.c (tui_set_exec_info_content)
 916         (tui_show_exec_info_content, tui_erase_exec_info_content)
 917         (tui_clear_exec_info_content, tui_update_exec_info): Change
 918         argument to tui_source_window_base.
 919
 920 2019-06-25  Tom Tromey  <tom@tromey.com>
 921
 922         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 923         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 924
 925 2019-06-25  Tom Tromey  <tom@tromey.com>
 926
 927         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 928         check.
 929
 930 2019-06-25  Tom Tromey  <tom@tromey.com>
 931
 932         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 933         type to void.
 934         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 935         type to void.
 936         * tui/tui-source.c (tui_set_source_content): Update.
 937         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 938
 939 2019-06-25  Tom Tromey  <tom@tromey.com>
 940
 941         * tui/tui-win.c (window_name_completer, tui_set_focus)
 942         (tui_all_windows_info): Use name method.
 943         * tui/tui-data.h (struct tui_gen_win_info)
 944         (struct tui_source_window, struct tui_disasm_window)
 945         (struct tui_data_window, struct tui_cmd_window) <name>: New
 946         method.
 947         (tui_win_name): Don't declare.
 948         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 949         (tui_win_name): Remove.
 950
 951 2019-06-25  Tom Tromey  <tom@tromey.com>
 952
 953         * tui/tui-winsource.h (tui_update_source_window)
 954         (tui_update_source_window_as_is): Change parameter type.
 955         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 956         to be a tui_source_window_base.
 957         (tui_update_source_window_as_is): Likewise.
 958         * tui/tui-win.c (make_visible_with_new_height): Update.
 959
 960 2019-06-25  Tom Tromey  <tom@tromey.com>
 961
 962         * tui/tui-winsource.c (tui_erase_source_content)
 963         (tui_show_source_content, tui_show_exec_info_content)
 964         (tui_erase_exec_info_content): Use refresh_window method.
 965         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 966         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 967         from tui_refresh_win.
 968         (tui_data_window::refresh_window): New method.
 969         (tui_win_info::refresh, tui_source_window_base::refresh)
 970         (tui_refresh_all): Use refresh_window method.
 971         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 972         method.
 973         * tui/tui-regs.c (tui_display_register): Call refresh_window
 974         method.
 975         * tui/tui-layout.c (show_source_disasm_command)
 976         (show_source_or_disasm_and_command): Call refresh_window method.
 977         * tui/tui-data.h (struct tui_gen_win_info)
 978         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 979         New method.
 980
 981 2019-06-25  Tom Tromey  <tom@tromey.com>
 982
 983         * tui/tui.c (tui_rl_other_window, tui_enable)
 984         (tui_is_window_visible, tui_get_command_dimension): Update.
 985         * tui/tui-winsource.c (tui_update_source_window_as_is)
 986         (tui_clear_source_content, tui_erase_source_content)
 987         (tui_show_source_line, tui_source_window_base::refill)
 988         (tui_source_window_base::do_scroll_horizontal)
 989         (tui_source_window_base::set_is_exec_point_at)
 990         (tui_update_breakpoint_info, tui_set_exec_info_content)
 991         (tui_alloc_source_buffer, tui_line_is_displayed)
 992         (tui_addr_is_displayed): Update.
 993         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 994         (tui_check_and_display_highlight_if_needed)
 995         (tui_win_info::make_visible, tui_win_info::refresh)
 996         (tui_refresh_all): Update.
 997         * tui/tui-windata.c (tui_first_data_item_displayed)
 998         (tui_delete_data_content_windows, tui_erase_data_content)
 999         (tui_display_all_data, tui_data_window::refresh_all)
1000         (tui_check_data_values): Update.
1001         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1002         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1003         (tui_win_info::backward_scroll, tui_refresh_all_win)
1004         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1005         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1006         (tui_source_window_base::set_new_height)
1007         (tui_data_window::set_new_height)
1008         (make_invisible_and_set_new_height)
1009         (make_visible_with_new_height, new_height_ok)
1010         (parse_scrolling_args): Update.
1011         * tui/tui-stack.c (tui_show_frame_info): Update.
1012         * tui/tui-source.c (tui_set_source_content)
1013         (tui_set_source_content_nil, tui_source_is_displayed)
1014         (tui_source_window::do_scroll_vertical): Update.
1015         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1016         (tui_display_registers_from, tui_display_reg_element_at_line)
1017         (tui_check_register_values, tui_reg_command): Update.
1018         * tui/tui-layout.c (tui_default_win_height)
1019         (show_source_disasm_command, show_data, init_and_make_win)
1020         (show_source_or_disasm_and_command): Update.
1021         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1022         (tui_redisplay_readline, tui_mld_flush)
1023         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1024         (tui_getc): Update.
1025         * tui/tui-disasm.c (tui_set_disassem_content)
1026         (tui_disasm_window::do_scroll_vertical): Update.
1027         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1028         Now virtual.
1029         (struct tui_win_info): Derive from tui_gen_win_info.
1030         <~tui_win_info>: Mark as override.
1031         <generic>: Remove member.
1032         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1033         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1034         (~tui_data_window, ~tui_win_info)
1035         (tui_free_all_source_wins_content): Update.
1036         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1037
1038 2019-06-25  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-layout.c (init_and_make_win): Use new.
1041         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1042         destructor, initializers.
1043         (tui_alloc_generic_win_info): Don't declare.
1044         * tui/tui-data.c (_locator): Add argument to constructor.
1045         (source_win, disasm_win): New globals.
1046         (exec_info): Remove.
1047         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1048         Update.
1049         (tui_alloc_generic_win_info): Remove.
1050         (init_content_element): Use new.
1051         (tui_win_info::tui_win_info): Update.
1052         (free_content_elements) <case DATA_WIN>: Use delete.
1053
1054 2019-06-25  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1057         * tui/tui-windata.c (tui_first_data_item_displayed)
1058         (tui_delete_data_content_windows): Update.
1059         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1060         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1061         (tui_display_registers_from, tui_check_register_values): Update.
1062         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1063         pointer.
1064         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1065         window.
1066         (tui_free_data_content): Update.
1067         (free_content_elements) <case DATA_WIN>: Free the window.
1068
1069 2019-06-25  Tom Tromey  <tom@tromey.com>
1070
1071         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1072         Update.
1073         * tui/tui-layout.c (make_command_window)
1074         (show_source_disasm_command, show_data, init_and_make_win)
1075         (show_source_or_disasm_and_command): Update.
1076         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1077         method.
1078         <can_highight, is_highlighted>: Now bool.
1079         (tui_set_win_highlight): Don't declare.
1080         * tui/tui-data.c (tui_set_win_highlight): Remove.
1081
1082 2019-06-25  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-wingeneral.c (make_visible): Remove check of window
1085         type.
1086
1087 2019-06-25  Tom Tromey  <tom@tromey.com>
1088
1089         * tui/tui-win.c (tui_win_info::max_height)
1090         (tui_cmd_window::max_height): New methods.
1091         (new_height_ok): Call max_height.
1092         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1093         <max_height>: New method.
1094
1095 2019-06-25  Tom Tromey  <tom@tromey.com>
1096
1097         * tui/tui-win.c (tui_source_window_base::set_new_height)
1098         (tui_data_window::set_new_height): New methods.
1099         (make_invisible_and_set_new_height): Call set_new_height method.
1100         * tui/tui-data.h (struct tui_win_info)
1101         (struct tui_source_window_base, struct tui_data_window)
1102         <set_new_height>: New method.
1103
1104 2019-06-25  Tom Tromey  <tom@tromey.com>
1105
1106         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1107         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1108         tui_refresh_data_win.
1109         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1110         method.
1111         (tui_refresh_all_win): Call the refresh_all method.
1112         (tui_set_focus): Likewise.
1113         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1114         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1115         Likewise.
1116
1117 2019-06-25  Tom Tromey  <tom@tromey.com>
1118
1119         * tui/tui-winsource.h (tui_refill_source_window)
1120         (tui_set_is_exec_point_at): Don't declare.
1121         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1122         (tui_source_window_base::refill): Rename from
1123         tui_refill_source_window.
1124         (tui_source_window_base::do_scroll_horizontal): Update.
1125         (tui_source_window_base::set_is_exec_point_at): Rename from
1126         tui_set_is_exec_point_at.
1127         (tui_update_all_breakpoint_info): Update.
1128         * tui/tui-stack.c (tui_show_frame_info): Update.
1129         * tui/tui-layout.c (show_data): Add cast.
1130         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1131         * tui/tui-data.h (struct tui_source_window_base) <refill,
1132         set_is_exec_point_at>: New methods.
1133         (tui_source_windows, tui_add_to_source_windows): Update types.
1134         (tui_add_to_source_windows): Remove redundant declaration.
1135         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1136         (tui_source_windows): Change return type.
1137         (tui_clear_source_windows_detail): Update.
1138         (tui_add_to_source_windows): Change type of parameter.
1139         (tui_free_all_source_wins_content): Update.
1140
1141 2019-06-25  Tom Tromey  <tom@tromey.com>
1142
1143         * tui/tui-wingeneral.c (tui_win_info::refresh)
1144         (tui_source_window_base::refresh): New methods.
1145         (tui_refresh_all): Call the refresh method.
1146         * tui/tui-data.h (struct tui_win_info)
1147         (struct tui_source_window_base) <refresh>: New method.
1148
1149 2019-06-25  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui.h (tui_is_window_visible): Return bool.
1152         * tui/tui.c (tui_is_window_visible): Return bool.
1153         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1154         (tui_make_visible, tui_make_invisible)
1155         (tui_win_info::make_visible)
1156         (tui_source_window_base::make_visible, make_all_visible)
1157         (tui_make_all_visible, tui_make_all_invisible): Update.
1158         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1159         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1160         bool.
1161         (struct tui_win_info, struct tui_source_window_base)
1162         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1163         * tui/tui-data.c (tui_init_generic_part): Update.
1164
1165 2019-06-25  Tom Tromey  <tom@tromey.com>
1166
1167         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1168         (tui_source_window_base::make_visible): New methods.
1169         (make_all_visible): Make method call.
1170         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1171         (struct tui_source_window_base, struct tui_cmd_window): Override
1172         make_visible.
1173         (tui_win_is_source_type): Don't declare.
1174         * tui/tui-data.c (tui_win_is_source_type): Remove.
1175
1176 2019-06-25  Tom Tromey  <tom@tromey.com>
1177
1178         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1179         NULL check.
1180
1181 2019-06-25  Tom Tromey  <tom@tromey.com>
1182
1183         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1184         Inline constructor.  Add initializers for members.
1185         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1186         constructors; now inline in class.
1187
1188 2019-06-25  Tom Tromey  <tom@tromey.com>
1189
1190         * tui/tui-regs.c (tui_show_registers): Update.
1191         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1192         bool.
1193         * tui/tui-data.c (tui_data_window::clear_detail)
1194         (tui_data_window): Update.
1195
1196 2019-06-25  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-windata.c (tui_display_all_data)
1199         (tui_display_data_from_line, tui_display_data_from)
1200         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1201         Update.
1202         * tui/tui-regs.c (tui_last_regs_line_no)
1203         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1204         (tui_show_registers, tui_show_register_group)
1205         (tui_display_registers_from, tui_display_reg_element_at_line)
1206         (tui_display_registers_from_line, tui_check_register_values)
1207         (tui_reg_next, tui_reg_prev): Update.
1208         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1209         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1210         tui_data_window.
1211         (struct tui_win_info) <detail>: Remove.  Add new fields from
1212         tui_data_info.
1213         (TUI_DATA_WIN): Add cast.
1214         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1215         (~tui_data_window): Simplify.
1216
1217 2019-06-25  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui-layout.c (show_source_disasm_command)
1220         (show_source_or_disasm_and_command): Update.
1221         * tui/tui-io.c (update_cmdwin_start_line)
1222         (tui_redisplay_readline): Update.
1223         * tui/tui-data.h (struct tui_command_info): Remove.
1224         (struct tui_win_info) <detail>: Remove command_info member.
1225         (struct tui_data_window) <start_line>: New member, from
1226         tui_command_info.
1227         (TUI_CMD_WIN): Add casts.
1228
1229 2019-06-25  Tom Tromey  <tom@tromey.com>
1230
1231         * tui/tui-winsource.c (tui_update_source_window)
1232         (tui_refill_source_window)
1233         (tui_source_window_base::do_scroll_horizontal)
1234         (tui_update_breakpoint_info, tui_set_exec_info_content)
1235         (tui_show_exec_info_content, tui_erase_exec_info_content)
1236         (tui_clear_exec_info_content): Update.
1237         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1238         Update.
1239         * tui/tui-win.c (make_invisible_and_set_new_height)
1240         (make_visible_with_new_height): Update.
1241         * tui/tui-source.c (tui_set_source_content)
1242         (tui_show_symtab_source): Update.
1243         * tui/tui-layout.c (extract_display_start_addr)
1244         (show_source_disasm_command, show_data)
1245         (make_source_or_disasm_window)
1246         (show_source_or_disasm_and_command): Update.
1247         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1248         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1249         "gdbarch".
1250         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1251         to tui_source_window_base.
1252         (struct tui_win_info) <detail>: Remove source_info member.
1253         (struct tui_source_window_base) <has_locator>: Inline.
1254         Move contents from tui_source_info; rename has_locator member to
1255         m_has_locator.
1256         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1257         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1258         header file.
1259         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1260         Simplify.
1261         (tui_free_all_source_wins_content): Cast to
1262         tui_source_window_base.
1263
1264 2019-06-25  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui-win.c (make_invisible_and_set_new_height)
1267         (make_visible_with_new_height): Call has_locator method.
1268         * tui/tui-layout.c (show_source_disasm_command, show_data)
1269         (show_source_or_disasm_and_command): Update for bool change.
1270         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1271         (tui_win_info) <has_locator>: New method.
1272         (struct tui_source_window_base) <has_locator>: New method.
1273         (tui_win_has_locator): Don't declare.
1274         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1275         from tui_win_has_locator.
1276         (tui_source_window_base): Use false, not FALSE.
1277
1278 2019-06-25  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1281         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1282         clear_detail method directly.
1283         (tui_clear_win_detail): Remove.
1284
1285 2019-06-25  Tom Tromey  <tom@tromey.com>
1286
1287         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1288         "this", not TUI_DISASM_WIN.
1289
1290 2019-06-25  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1293         declare.
1294         * tui/tui-winsource.c
1295         (tui_source_window_base::do_scroll_horizontal): Rename from
1296         tui_horizontal_source_scroll.
1297         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1298         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1299         from tui_vertical_data_scroll.
1300         * tui/tui-win.h (tui_scroll): Don't declare.
1301         * tui/tui-win.c (tui_win_info::forward_scroll)
1302         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1303         (tui_win_info::right_scroll): Rename and update.
1304         (tui_scroll_forward_command, tui_scroll_backward_command)
1305         (tui_scroll_left_command, tui_scroll_right_command): Update.
1306         (tui_scroll): Remove.
1307         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1308         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1309         from tui_vertical_source_scroll.
1310         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1311         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1312         from tui_vertical_disassem_scroll.
1313         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1314         do_scroll_horizontal>: New methods.
1315         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1316         Likewise.
1317         (struct tui_source_window_base): Add do_scroll_horizontal.
1318         (struct tui_source_window, struct tui_disasm_window): Add
1319         do_scroll_vertical.
1320         (struct tui_data_window, struct tui_cmd_window): Add
1321         do_scroll_horizontal and do_scroll_vertical.
1322         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1323
1324 2019-06-25  Tom Tromey  <tom@tromey.com>
1325
1326         * tui/tui-data.h (struct tui_source_window_base): New struct.
1327         (struct tui_source_window): Derive from tui_source_window_base.
1328         (struct tui_disasm_window): New struct.
1329         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1330         from tui_source_window::clear_detail.
1331         (tui_source_window_base): Rename from tui_source_window.
1332         (~tui_source_window_base): Rename from ~tui_source_window.
1333         (tui_alloc_win_info): Create a tui_disasm_window.
1334
1335 2019-06-25  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-data.h (struct tui_source_window)
1338         (struct tui_data_window): Declare destructors.
1339         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1340         destructors.
1341         (tui_win_info): Simplify.
1342
1343 2019-06-25  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-winsource.c (tui_display_main)
1346         (tui_update_source_windows_with_addr)
1347         (tui_update_all_breakpoint_info): Update.
1348         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1349         (new_height_ok, parse_scrolling_args): Update.
1350         * tui/tui-stack.c (tui_show_frame_info): Update.
1351         * tui/tui-data.h (struct tui_list): Remove.
1352         (tui_source_windows): Return a reference to a std::vector.
1353         * tui/tui-data.c (source_windows): Now a std::vector.
1354         (tui_source_windows): Change return type.
1355         (tui_clear_source_windows): Rewrite.
1356         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1357         (tui_free_all_source_wins_content): Rewrite.
1358
1359 2019-06-25  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1362         (struct tui_data_window, struct tui_cmd_window): Declare
1363         clear_detail method.
1364         * tui/tui-data.c (tui_source_window::clear_detail)
1365         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1366         methods.
1367         (tui_clear_win_detail): Simplify.
1368
1369 2019-06-25  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-layout.c (make_source_window, make_disasm_window)
1372         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1373         Return the new window.
1374         (show_source_disasm_command, show_data)
1375         (show_source_or_disasm_and_command): Update.
1376
1377 2019-06-25  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1380         parameter.  Return the new window.
1381         (show_source_disasm_command): Update and remove NULL check.
1382         (show_source_or_disasm_and_command): Update.
1383
1384 2019-06-25  Tom Tromey  <tom@tromey.com>
1385
1386         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1387
1388 2019-06-25  Tom Tromey  <tom@tromey.com>
1389
1390         * tui/tui-data.h (struct tui_win_info): Make constructor
1391         protected.  Make destructor virtual.  Add initializers.
1392         (tui_source_window, tui_data_window, tui_cmd_window): New
1393         classes.
1394         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1395         constructor.  Add "type" parameter.
1396         (tui_source_window, tui_data_window, tui_cmd_window): New
1397         constructors.
1398         (tui_alloc_win_info): Instantiate the appropriate subclass.
1399
1400 2019-06-25  Tom Tromey  <tom@tromey.com>
1401
1402         * tui/tui-win.c (tui_resize_all): Use delete.
1403         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1404         destructor.
1405         (tui_free_window): Don't declare.
1406         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1407         Update.
1408
1409 2019-06-25  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-data.h (struct tui_win_info): Add constructor.
1412         * tui/tui-data.c (tui_alloc_win_info): Use new.
1413         (tui_free_window): Use delete.
1414
1415 2019-06-22  Tom Tromey  <tom@tromey.com>
1416
1417         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1418         declare.
1419         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1420
1421 2019-06-22  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1424         declare.
1425         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1426
1427 2019-06-22  Tom de Vries  <tdevries@suse.de>
1428
1429         * dwarf2read.c (create_addrmap_from_aranges)
1430         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1431         instead of '%zu'.
1432
1433 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1434
1435         * dwarf2read.h (dwarf2_section_info_def): Remove.
1436         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1437         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1438         std::vector<dwarf2_section_info>.
1439         (struct dwo_file) <~dwo_file>: Remove.
1440         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1441         types field.
1442         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1443         (dwarf2_read_debug_names): Likewise.
1444         (create_debug_types_hash_table): Change parameter type to
1445         array_view, adjust code accordingly.
1446         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1447         (partial_die_info::fixup): Likewise.
1448         (determine_prefix): Likewise.
1449         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1450
1451 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1452
1453         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1454         gdb_bfd_ref_ptr.
1455         <~dwo_file>: Remove call to gdb_bfd_unref.
1456         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1457         gdb_bfd_ref_ptr::get.
1458
1459 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1460
1461         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1462         type to htab_up.
1463         * dwarf2read.c (struct dwo_file): Initialize fields.
1464         <~dwo_file>: New.
1465         (free_dwo_file): Remove, move content to ~dwo_file.
1466         (struct dwo_file_deleter): Remove.
1467         (dwo_file_up>: Remove custom deleter.
1468         (free_dwo_files): Remove.
1469         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1470         dwo_files.
1471         (process_skeletonless_type_units): Call unique_ptr::get.
1472         (allocate_dwo_file_hash_table): Add deleter to created hash
1473         table.  Change return type to htab_up.
1474         (lookup_dwo_file_slot): Don't memset dwo_file, call
1475         unique_ptr::get.
1476         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1477         (create_dwo_unit_in_dwp_v2): Likewise.
1478         (open_and_init_dwo_file): Likewise.
1479         (free_dwo_file_from_slot): Remove.
1480
1481 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1482
1483         * dwarf2read.h (struct dwarf2_section_info) <readin,
1484         is_virtual>: Change type to bool.
1485         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1486         true instead of 1.
1487
1488 2019-06-19  Tom Tromey  <tom@tromey.com>
1489
1490         * tui/tui-data.h (tui_init_content_element): Don't declare.
1491
1492 2019-06-19  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-data.h (tui_init_win_info): Don't declare.
1495
1496 2019-06-19  Tom de Vries  <tdevries@suse.de>
1497
1498         * dwarf2read.h (abstract_to_concrete): Change type to
1499         std::unordered_map<sect_offset, std::vector<sect_offset>,
1500         gdb::hash_enum<sect_offset>>.
1501
1502 2019-06-19  Tom Tromey  <tromey@adacore.com>
1503
1504         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1505         EVAL_AVOID_SIDE_EFFECTS specially.
1506
1507 2019-06-19  Tom Tromey  <tromey@adacore.com>
1508
1509         * source-cache.c (highlighter): New global.
1510         (source_cache::get_source_lines): Create a highlighter on demand.
1511
1512 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1513
1514         * defs.h (deprecated_interactive_hook): Delete declaration.
1515         * interps.c (clear_interpreter_hooks): Remove use of
1516         deprecated_interactive_hook.
1517         * top.c (deprecated_interactive_hook): Delete definition.
1518         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1519
1520 2019-06-18  Tom de Vries  <tdevries@suse.de>
1521
1522         PR gdb/24515
1523         * dwarf2read.h (abstract_to_concrete): Change type from
1524         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1525         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1526         * dwarf2read.c (read_variable): Update.
1527         (dwarf2_fetch_die_loc_sect_off): Update.
1528
1529 2019-06-17  Tom de Vries  <tdevries@suse.de>
1530
1531         PR gdb/24617
1532         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1533         accessing parent[parent_len - 1].
1534
1535 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1536
1537         PR gdb/24364
1538         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1539         call dtrace_process_dof with NULL dof.
1540
1541 2019-06-16  Tom de Vries  <tdevries@suse.de>
1542
1543         PR gdb/24445
1544         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1545
1546 2019-06-16  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1549         (make_all_visible): Use address of member.
1550
1551 2019-06-16  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1554         (tui_free_window, free_content, free_content_elements): Remove
1555         unnecessary cast.
1556         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1557         cast.
1558         * tui/tui-regs.c (tui_show_register_group)
1559         (tui_display_registers_from, tui_display_reg_element_at_line):
1560         Remove unnecessary cast.
1561
1562 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1563
1564         * linux-nat.c (normal_mask): Delete.
1565         (_initialize_linux_nat): Don't initialise normal_mask.
1566
1567 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1568
1569         PR gdb/24445
1570         * dwarf-index-write.h (write_psymtabs_to_index): Add
1571         dwz_basename parameter.
1572         * dwarf-index-write.c (write_gdbindex): Move file writing to
1573         write_gdbindex_1.  Change return type void.
1574         (assert_file_size): Move up, remove filename parameter.
1575         (write_gdbindex_1): New function.
1576         (write_debug_names): Change return type to void, call
1577         assert_file_size.
1578         (struct index_wip_file): New struct.
1579         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1580         file logic to index_wip_file.  Write index for dwz file if
1581         needed.
1582         (save_gdb_index_command): Pass basename of dwz file, if present.
1583         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1584         build-id of dwz file, if present.
1585         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1586         (dwarf2_get_dwz_file): Likewise.
1587         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1588         (dwarf2_get_dwz_file): Likewise.
1589
1590 2019-06-16  Tom Tromey  <tom@tromey.com>
1591
1592         * coffread.c (process_coff_symbol): Use xstrdup.
1593         * value.c (create_internalvar): Use xstrdup.
1594
1595 2019-06-16  Tom Tromey  <tom@tromey.com>
1596
1597         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1598         * breakpoint.c (stopin_command, stopat_command)
1599         (until_break_command, decode_location_default): Remove unnecessary
1600         cast.
1601         * utils.c (subset_compare): Remove unnecessary cast.
1602         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1603         cast.
1604         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1605         cast.
1606         * infcmd.c (path_command): Remove unnecessary cast.
1607         * coffread.c (decode_type): Remove unnecessary cast.
1608         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1609         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1610         * tui/tui-stack.c (tui_show_locator_content)
1611         (tui_show_frame_info): Remove unnecessary cast.
1612         * tui/tui-win.c (tui_scroll_forward_command)
1613         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1614         (parse_scrolling_args): Remove unnecessary cast.
1615         * tui/tui-data.c (init_win_info, tui_del_window)
1616         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1617         (free_content_elements): Remove unnecessary cast.
1618         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1619         unnecessary cast.
1620         * tui/tui-source.c (tui_set_source_content)
1621         (tui_vertical_source_scroll): Remove unnecessary cast.
1622         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1623         cast.
1624         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1625         * tui/tui-regs.c (tui_display_registers_from)
1626         (tui_display_register): Remove unnecessary cast.
1627         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1628         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1629         (make_visible): Remove unnecessary cast.
1630         * tui/tui-winsource.c (tui_erase_source_content)
1631         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1632         unnecessary cast.
1633         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1634         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1635         * stabsread.c (read_type, read_array_type, read_range_type):
1636         Remove unnecessary cast.
1637         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1638         (parse_symbol, parse_type, upgrade_type, parse_external)
1639         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1640         unnecessary cast.
1641         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1642
1643 2019-06-16  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-data.c (tui_alloc_generic_win_info)
1646         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1647         checks.
1648
1649 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1650             Andrew Burgess  <andrew.burgess@embecosm.com>
1651
1652         * f-typeprint.c (f_print_type): Don't return early for not
1653         associated or not allocated types.
1654         (f_type_print_varspec_suffix): Add print_rank parameter and print
1655         ranks of array types in case they dangling.
1656         (f_type_print_base): Add print_rank parameter.
1657
1658 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1659
1660         * NEWS: Mention new MI commands.
1661         * break-catch-throw.c (enum exception_event_kind): Move to
1662         breakpoint.h.
1663         (print_mention_exception_catchpoint): Output text as a single
1664         message.
1665         (catch_exception_command_1): Rename to...
1666         (catch_exception_event): ...this, make non-static, update header
1667         command, and change some parameter types.
1668         (catch_catch_command): Update for changes to
1669         catch_exception_command_1.
1670         (catch_throw_command): Likewise.
1671         (catch_rethrow_command): Likewise.
1672         * breakpoint.c (enum exception_event_kind): Delete.
1673         * breakpoint.h (enum exception_event_kind): Moved here from
1674         break-catch-throw.c.
1675         (catch_exception_event): Declare.
1676         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1677         (mi_cmd_catch_throw): New function.
1678         (mi_cmd_catch_rethrow): New function.
1679         (mi_cmd_catch_catch): New function.
1680         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1681         'catch-catch' entries.
1682         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1683         (mi_cmd_catch_rethrow): Declare.
1684         (mi_cmd_catch_catch): Declare.
1685
1686 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1687
1688         * annotate.c (annotate_source_line): Change return type to void,
1689         update implementation to match.
1690         * annotate.h (annotate_source_line): Change return type to void,
1691         update header comment.
1692         * stack.c (print_frame_info): Don't change what frame information
1693         is printed based on whether annotations are on or not.
1694
1695 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1696
1697         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1698         (annotate_source): Make static.
1699         (annotate_source_line): Moved from source.c and renamed from
1700         identify_source_line.  Update the return type.
1701         * annotate.h (annotate_source): Delete declaration.
1702         (annotate_source_line): Declaration moved from source.h, and
1703         renamed from identify_source_line.  Return type updated.
1704         * source.c (identify_source_line): Moved to annotate.c and renamed
1705         to annotate_source_line.
1706         (info_line_command): Remove check of annotation_level.
1707         * source.h (identify_source_line): Move declaration to annotate.h
1708         and rename to annotate_source_line.
1709         * stack.c: Add 'annotate.h' include.
1710         (print_frame_info): Remove check of annotation_level before
1711         calling annotate_source_line.
1712
1713 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1714
1715         * source-cache.c (source_cache::get_plain_source_lines): Use
1716         open_source_file_with_line_charpos instead of just
1717         open_source_file, remove call to find_source_lines.
1718         (source_cache::get_source_lines): Likewise.
1719         * source.c (find_source_lines): Make static.
1720         (get_filename_and_charpos): Renamed into...
1721         (open_source_file_with_line_charpos): ..this along with changes to
1722         return a scoped_fd, and some other minor clean ups.
1723         (identify_source_line): Use open_source_file_with_line_charpos.
1724         (search_command_helper): Use open_source_file_with_line_charpos
1725         instead of just open_source_file, remove call to
1726         find_source_lines.
1727         * source.h (open_source_file_with_line_charpos): Declare new
1728         function.
1729         (find_source_lines): Delete declaration.
1730
1731 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1732
1733         * source.c (get_filename_and_charpos): Remove fullname
1734         parameter.
1735         (identify_source_line): Update call to get_filename_and_charpos.
1736
1737 2019-06-14  Tom Tromey  <tromey@adacore.com>
1738
1739         PR gdb/24502:
1740         * ui-style.h (skip_ansi_escape): Update comment.
1741         * ui-file.h (class no_terminal_escape_file): New class.
1742         * ui-file.c (no_terminal_escape_file::write)
1743         (no_terminal_escape_file::puts): New methods.
1744         * cli/cli-logging.c (handle_redirections): Use
1745         no_terminal_escape_file.
1746
1747 2019-06-14  Tom Tromey  <tromey@adacore.com>
1748
1749         * NEWS: Move convenience variable news above Python news.
1750
1751 2019-06-14  Tom Tromey  <tom@tromey.com>
1752
1753         * gnulib: Move directory to top-level.
1754         * configure.ac: Don't configure gnulib.
1755         * configure: Rebuild.
1756         * common/common-defs.h: Use new path to gnulib.
1757         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1758         (GNULIB_H): Remove.
1759         (INCGNU): Look in new gnulib location.
1760         (HFILES_NO_SRCDIR): Remove gnulib files.
1761         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1762         (generated_files): Remove GNULIB_H.
1763         ($(LIBGNU), all-lib): Remove targets.
1764         (distclean): Don't mention GNULIB_BUILDDIR.
1765         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1766
1767 2019-06-14  Tom Tromey  <tromey@adacore.com>
1768
1769         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1770         Warn if symbol file does not provide any symbols.
1771
1772 2019-06-14  Tom Tromey  <tromey@adacore.com>
1773
1774         * source.c (find_and_open_source): Respect basenames_may_differ.
1775
1776 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1777
1778         * annotate.c (annotate_breakpoints_invalid): Make use of
1779         scoped_restore_terminal_state.
1780         (annotate_frames_invalid): Likewise.
1781
1782 2019-06-14  Tom Tromey  <tromey@adacore.com>
1783
1784         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1785         allow assignment to an internalvar.
1786
1787 2019-06-14  Tom Tromey  <tromey@adacore.com>
1788
1789         * ada-lex.l: Allow "_" in attribute names.
1790
1791 2019-06-14  Tom Tromey  <tromey@adacore.com>
1792
1793         PR gdb/24653:
1794         * regcache.c (registers_changed): Don't call alloca.
1795         * top.c (execute_command): Don't call alloca.
1796
1797 2019-06-13  Pedro Alves  <palves@redhat.com>
1798
1799         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1800         'expression'.  When parsing an expression, error out if there's
1801         junk after "unlimited".
1802         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1803         (do_set_command): Adjust calls to is_unlimited_literal.
1804
1805 2019-06-13  Pedro Alves  <palves@redhat.com>
1806
1807         * compile/compile.c (make_compile_options_def_group): Add braces
1808         around array_view initializer.
1809         * thread.c (make_thread_apply_all_options_def_group)
1810         (make_thread_apply_all_options_def_group): Likewise.
1811
1812 2019-06-13  Pedro Alves  <palves@redhat.com>
1813
1814         * NEWS (New commands): Mention "maint test-options
1815         require-delimiter", "maint test-options unknown-is-error", "maint
1816         test-options unknown-is-operand" and "maint show
1817         test-options-completion-result".
1818         (New command options, command completion): New section.
1819         (Completion improvements): New section.
1820         Mention that you can abbreviate "unlimited".
1821
1822 2019-06-13  Pedro Alves  <palves@redhat.com>
1823
1824         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1825         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1826         * unittests/cli-utils-selftests.c (test_parse_flags)
1827         (test_parse_flags_qcs): Delete.
1828         (test_cli_utils): Don't call deleted functions.
1829
1830 2019-06-13  Pedro Alves  <palves@redhat.com>
1831
1832         * thread.c: Include "cli/cli-option.h".
1833         (tp_array_compar_ascending): Global.
1834         (tp_array_compar): Delete function.
1835         (tp_array_compar_ascending, tp_array_compar_descending): New
1836         functions.
1837         (ascending_option_def, qcs_flag_option_def)
1838         (thr_qcs_flags_option_defs)
1839         (make_thread_apply_all_options_def_group)
1840         (make_thread_apply_options_def_group): New.
1841         (thread_apply_all_command): Use gdb::option::process_options.
1842         (thread_apply_command_completer)
1843         (thread_apply_all_command_completer): New.
1844         (thread_apply_command): Use gdb::option::process_options.
1845         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1846         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1847         to generate help text of "thread apply".  Adjust "taas"'s help.
1848         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1849         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1850
1851 2019-06-13  Pedro Alves  <palves@redhat.com>
1852
1853         * thread.c (thread_apply_command): Check for invalid TID with
1854         isdigit instead of !isalpha.
1855
1856 2019-06-13  Pedro Alves  <palves@redhat.com>
1857
1858         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1859         (validate_flags_qcs): New.
1860         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1861         (validate_flags_qcs): Declare.
1862         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1863         (make_frame_apply_options_def_group): New.
1864         (frame_apply_command_count): Process options with
1865         gdb::option::process_options.
1866         (frame_apply_completer): New.
1867         (frame_apply_level_completer, frame_apply_all_completer)
1868         (frame_apply_completer): New.
1869         (_initialize_stack): Update help of "frame apply", "frame apply
1870         level", "frame apply all" and "faas" to mention supported options
1871         and install command completers.
1872         * stack.h (frame_apply_all_completer): Declare.
1873         * thread.c: Include "stack.h".
1874         (tfaas_command): Add "--".
1875         (_initialize_thread): Update help "tfaas" to mention supported
1876         options and install command completer.
1877
1878 2019-06-13  Pedro Alves  <palves@redhat.com>
1879
1880         * completer.c (complete_nested_command_line): New.
1881         (gdb_completion_word_break_characters_throw): Add assertion.
1882         * completer.h (complete_nested_command_line): Declare.
1883
1884 2019-06-13  Pedro Alves  <palves@redhat.com>
1885
1886         * stack.c (parse_backtrace_qualifiers): New.
1887         (backtrace_command): Use it.
1888         (backtrace_command_completer): Complete on qualifiers.
1889
1890 2019-06-13  Pedro Alves  <palves@redhat.com>
1891
1892         * frame.c: Include "cli/cli-option.h.
1893         (user_set_backtrace_options): New.
1894         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1895         Delete.
1896         (get_prev_frame): Adjust.
1897         (boolean_option_def, uinteger_option_def)
1898         (set_backtrace_option_defs): New.
1899         (_initialize_frame): Adjust and use
1900         gdb::option::add_setshow_cmds_for_options to install "set
1901         backtrace past-main" and "set backtrace past-entry".
1902         * frame.h: Include "cli/cli-option.h".
1903         (struct frame_print_options): Forward declare.
1904         (print_frame_arguments_all, print_frame_arguments_scalars)
1905         (print_frame_arguments_none): Declare.
1906         (print_entry_values): Delete declaration.
1907         (struct frame_print_options, user_frame_print_options): New.
1908         (struct set_backtrace_options): New.
1909         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1910         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1911         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1912         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1913         (list_args_or_locals): Add frame_print_options parameter.
1914         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1915         * python/py-framefilter.c (enumerate_args): Pass down
1916         USER_FRAME_PRINT_OPTIONS.
1917         * stack.c: Include "cli/cli-option.h".
1918         (print_frame_arguments_all, print_frame_arguments_scalars)
1919         (print_frame_arguments_none): Declare.
1920         (print_raw_frame_arguments, print_entry_values): Delete.
1921         (user_frame_print_options): New.
1922         (boolean_option_def, enum_option_def, frame_print_option_defs):
1923         New.
1924         (struct backtrace_cmd_options): New.
1925         (bt_flag_option_def): New.
1926         (backtrace_command_option_defs): New.
1927         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1928         (print_frame_arg, read_frame_arg, print_frame_args)
1929         (print_frame_info, print_frame): Add frame_print_options parameter
1930         and use it.
1931         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1932         (backtrace_command_1): Add frame_print_options and
1933         backtrace_cmd_options parameters and use them.
1934         (make_backtrace_options_def_group): New.
1935         (backtrace_command): Process command options with
1936         gdb::option::process_options.
1937         (backtrace_command_completer): New.
1938         (_initialize_stack): Extend "backtrace"'s help to mention
1939         supported options.  Install completer for "backtrace".
1940         Install some settings commands with add_setshow_cmds_for_options.
1941
1942 2019-06-13  Pedro Alves  <palves@redhat.com>
1943
1944         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1945         and that "set/show print raw frame-arguments" are now deprecated.
1946
1947         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1948         command.
1949         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1950         * stack.c (_initialize_stack): Install "set/show print
1951         raw-frame-arguments", and deprecate "set/show print raw
1952         frame-arguments".
1953         * valprint.c (_initialize_valprint): Deprecate "set/show print
1954         raw".
1955
1956 2019-06-13  Pedro Alves  <palves@redhat.com>
1957
1958         * compile/compile.c (struct compile_options): New.
1959         (compile_flag_option_def, compile_command_option_defs)
1960         (make_compile_options_def_group): New.
1961         (compile_file_command): Handle options with
1962         gdb::option::process_options.
1963         (compile_file_command_completer): New function.
1964         (compile_code_command): Handle options with
1965         gdb::option::process_options.
1966         (compile_code_command_completer): New function.
1967         (_initialize_compiler): Install completers for "compile code" and
1968         "compile file".  Mention available options in "compile code" and
1969         "compile code"'s help.
1970         * completer.c (advance_to_completion_word): New, factored out from
1971         ...
1972         (advance_to_expression_complete_word_point): ... this.
1973         (advance_to_filename_complete_word_point): New.
1974         * completer.h (advance_to_filename_complete_word_point): New
1975         declaration.
1976
1977 2019-06-13  Pedro Alves  <palves@redhat.com>
1978
1979         * compile/compile.c: Include "cli/cli-option.h".
1980         (compile_print_value): Scope data pointer is now a
1981         value_print_options pointer; adjust.
1982         (compile_print_command): Process options.  Scope data pointer is
1983         now a value_print_options pointer; adjust.
1984         (_initialize_compile): Update "compile print"'s help to include
1985         supported options.  Install a completer for "compile print".
1986         * cp-valprint.c (show_vtblprint, show_objectprint)
1987         (show_static_field_print): Delete.
1988         (_initialize_cp_valprint): Don't install "set print
1989         static-members", "set print vtbl", "set print object" here.
1990         * printcmd.c: Include "cli/cli-option.h" and
1991         "common/gdb_optional.h".
1992         (print_command_parse_format): Rework to fill in a
1993         value_print_options instead of a format_data.
1994         (print_value): Change parameter type from format_data pointer to
1995         value_print_options reference.  Adjust.
1996         (print_command_1): Process options.  Adjust to pass down a
1997         value_print_options.
1998         (print_command_completer): New.
1999         (_initialize_printcmd): Install print_command_completer as
2000         handle_brkchars completer for the "print" command.  Update
2001         "print"'s help to include supported options.
2002         * valprint.c: Include "cli/cli-option.h".
2003         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2004         here from cp-valprint.c.
2005         (boolean_option_def, uinteger_option_def)
2006         (value_print_option_defs, make_value_print_options_def_group):
2007         New.  Use gdb::option::add_setshow_cmds_for_options to install
2008         "set print elements", "set print null-stop", "set print repeats",
2009         "set print pretty", "set print union", "set print array", "set
2010         print address", "set print symbol", "set print array-indexes".
2011         * valprint.h: Include <string> and "cli/cli-option.h".
2012         (make_value_print_options_def_group): Declare.
2013         (print_value): Change parameter type from format_data pointer to
2014         value_print_options reference.
2015         (print_command_completer): Declare.
2016
2017 2019-06-13  Pedro Alves  <palves@redhat.com>
2018
2019         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2020         (COMMON_SFILES): Add maint-test-settings.c.
2021         * cli/cli-decode.c (boolean_enums): New global, factored out from
2022         ...
2023         (add_setshow_boolean_cmd): ... here.
2024         * cli/cli-decode.h (boolean_enums): Declare.
2025         * cli/cli-option.c: New file.
2026         * cli/cli-option.h: New file.
2027         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2028         factored out from ...
2029         (parse_cli_boolean_value(const char *)): ... this.
2030         (is_unlimited_literal): Change parameter type to pointer to
2031         pointer.  Adjust and advance ARG pointer.
2032         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2033         (parse_cli_var_enum): New, factored out from ...
2034         (do_set_command): ... this.  Adjust.
2035         * cli/cli-setshow.h (parse_cli_boolean_value)
2036         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2037         (parse_cli_var_enum): Declare.
2038         * cli/cli-utils.c: Include "cli/cli-option.h".
2039         (get_ulongest): New.
2040         * cli/cli-utils.h (get_ulongest): Declare.
2041         (check_for_argument): New overloads.
2042         * maint-test-options.c: New file.
2043
2044 2019-06-13  Pedro Alves  <palves@redhat.com>
2045
2046         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2047         parse a range if "-" is at the end of the string.
2048
2049 2019-06-13  Pedro Alves  <palves@redhat.com>
2050
2051         * cli/cli-setshow.c (parse_auto_binary_operation)
2052         (parse_cli_boolean_value): Don't allow "o".
2053
2054 2019-06-13  Pedro Alves  <palves@redhat.com>
2055
2056         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2057         * NEWS: Mention maint test-settings KIND.
2058         * maint-test-settings.c: New file.
2059
2060 2019-06-13  Pedro Alves  <palves@redhat.com>
2061
2062         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2063         completer.
2064         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2065         "set" completers.
2066
2067 2019-06-13  Pedro Alves  <palves@redhat.com>
2068
2069         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2070         after item.
2071
2072 2019-06-13  Pedro Alves  <palves@redhat.com>
2073
2074         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2075
2076 2019-06-13  Pedro Alves <palves@redhat.com>
2077
2078         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2079         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2080         call.
2081         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2082         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2083         calls.
2084         (check_for_argument): Skip spaces after argument.
2085
2086 2019-06-13  Pedro Alves  <palves@redhat.com>
2087
2088         * thread.c (thread_apply_command): Adjust TID parsing.
2089         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2090         detected before end of string.
2091         (tid_is_in_list): Error out if LIST is invalid.
2092
2093 2019-06-13  Pedro Alves  <palves@redhat.com>
2094
2095         * completer.c (complete_line_internal_1): Rewind completion word
2096         point.
2097         (completion_tracker::advance_custom_word_point_by): Change
2098         parameter type to int.
2099         * completer.h (completion_tracker::advance_custom_word_point_by):
2100         Likewise.
2101
2102 2019-06-13  Pedro Alves  <palves@redhat.com>
2103
2104         * completer.c (advance_to_completion_word): Handle delimiters.
2105
2106 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2107
2108         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2109
2110 2019-06-11  Tom Tromey  <tom@tromey.com>
2111
2112         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2113         (xmalloc_failed): Move to alloc.c.
2114         * alloc.c: New file.
2115         * Makefile.in (COMMON_SFILES): Add alloc.c.
2116
2117 2019-06-11  Tom Tromey  <tom@tromey.com>
2118
2119         * nat/linux-waitpid.c: Don't include server.h.
2120         (linux_debug): Remove.
2121         (my_waitpid): Update.
2122
2123 2019-06-11  Tom Tromey  <tromey@adacore.com>
2124
2125         * infcall.c (_initialize_infcall): Remove trailing newline from
2126         help.
2127         * user-regs.c (_initialize_user_regs): Remove trailing newline
2128         from help.
2129         * typeprint.c (_initialize_typeprint): Remove trailing newline
2130         from help.
2131         * reverse.c (_initialize_reverse): Remove trailing newlines from
2132         help.
2133         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2134         from help.
2135         * language.c (add_set_language_command): Remove trailing newline
2136         from help.
2137         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2138         help.
2139         * disasm.c (_initialize_disasm): Remove trailing newline from
2140         help.
2141         * top.c (init_main): Remove trailing newline from help.
2142         * interps.c (_initialize_interpreter): Remove trailing newline
2143         from help.
2144         * btrace.c (_initialize_btrace): Remove trailing newlines from
2145         help.
2146         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2147         from help.
2148         * python/python.c (_initialize_python): Remove trailing newline
2149         from help.
2150         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2151         help.
2152         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2153         from help.  Reformat some text.
2154         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2155         from help.
2156         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2157         newline from help.
2158
2159 2019-06-11  Tom Tromey  <tromey@adacore.com>
2160
2161         * darwin-nat.c (darwin_decode_exception_message)
2162         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2163
2164 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2165
2166         * valops.c (value_slice): Check for not allocated or not
2167         associated values.
2168
2169 2019-06-10  Tom de Vries  <tdevries@suse.de>
2170
2171         PR gdb/24618
2172         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2173         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2174         invalid.
2175
2176 2019-06-10  Tom de Vries  <tdevries@suse.de>
2177
2178         PR gdb/24611
2179         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2180         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2181
2182 2019-06-10  Tom de Vries  <tdevries@suse.de>
2183
2184         PR symtab/24545
2185         * symtab.c (struct demangled_name_entry): Add language field.
2186         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2187         static minimal symbol".  Set and use language field.
2188
2189 2019-06-10  Tom Tromey  <tromey@adacore.com>
2190
2191         * ada-lang.c (_initialize_ada_language): Update help text.
2192
2193 2019-06-10  Tom Tromey  <tromey@adacore.com>
2194
2195         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2196         with a newline.
2197         * guile/guile.c (handle_boot_error): Don't end warning with a
2198         newline.
2199         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2200         warning with a newline.
2201         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2202         newline.
2203         (s12z_frame_cache): Likewise.
2204         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2205         a newline.
2206         * solib-svr4.c (disable_probes_interface): Don't end warning with
2207         a newline.
2208         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2209         newline.
2210         * python/python.c (do_finish_initialization): Don't end warning
2211         with a newline.
2212
2213 2019-06-10  Tom Tromey  <tom@tromey.com>
2214
2215         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2216         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2217         gdbpy_enter.
2218
2219 2019-06-10  Tom Tromey  <tromey@adacore.com>
2220
2221         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2222         data.
2223         (elf_new_init): Don't call stabsread_new_init.
2224         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2225         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2226         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2227
2228 2019-06-10  Tom de Vries  <tdevries@suse.de>
2229
2230         PR symtab/16264
2231         PR symtab/24517
2232         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2233
2234 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2235
2236         * source.c (find_and_open_source): Also rewrite relative file
2237         names.
2238
2239 2019-04-26  Amos Bird  <amosbird@gmail.com>
2240
2241         * annotate.c (annotate_thread_exited): Add "thread-exited"
2242         annotation.
2243
2244 2019-06-06  Tom Tromey  <tromey@adacore.com>
2245
2246         * maint.h (class scoped_command_stats): Use
2247         DISABLE_COPY_AND_ASSIGN.
2248         <print_time>: New method.
2249         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2250         print_time.
2251         (scoped_command_stats::print_time): New method.
2252
2253 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2254
2255         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2256         instructions of lengths 6 or 8 bytes.
2257
2258 2019-06-04  Pedro Alves  <palves@redhat.com>
2259
2260         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2261
2262         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2263         * breakpoint.c (condition_completer): Likewise.
2264         * cli/cli-dump.c (scan_expression): Likewise.
2265         * common/filestuff.c (mkdir_recursive): Likewise.
2266         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2267         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2268         (gdb_abspath): Likewise.
2269         * compile/compile-cplus-types.c
2270         (compile_cplus_instance::decl_name): Likewise.
2271         * completer.c (complete_explicit_location):
2272         (signal_completer, reg_or_group_completer_1): Likewise.
2273         * cp-support.c (cp_remove_params_if_any): Likewise.
2274         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2275         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2276         * infcmd.c (strip_bg_char): Likewise.
2277         * linespec.c (copy_token_string): Likewise.
2278         * mi/mi-main.c (output_cores): Likewise.
2279         * psymtab.c (psymtab_search_name):
2280         * symfile.c (test_set_ext_lang_command): Likewise.
2281         * target.c (target_fileio_read_stralloc): Likewise.
2282         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2283         * value.c (complete_internalvar): Likewise.
2284
2285 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2286
2287         Add objfile property to gdb.Type.
2288         * NEWS: Mention Python API addition.
2289         * python/py-type.c (typy_get_objfile): New method.
2290
2291 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2292
2293         * NEWS: Mention the new set|show style [title|highlight].
2294         Mention changes to "show style", "help" and "apropos".
2295
2296 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2297
2298         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2299         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2300         instead of print_help_for_command.
2301         (print_doc_of_command): New function.
2302         (help_list): Add 'apropos -v word' suggestion.
2303         (print_help_for_command): Style the command name using title style.
2304         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2305         (_initialize_cli_cmds): Describe -v in apropos_command help.
2306
2307 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2308
2309         * cli/cli-style.h (cli_style_option): Add name in constructor,
2310         add m_name class member, add constructor with intensity,
2311         add name class function.
2312         (cli_style_option::add_setshow_commands): Remove name argument.
2313         (highlight_style, title_style): New styles.
2314         * cli/cli-style.c (do_show): New function that shows a style
2315         characteristic styling the style name with itself.
2316         (set_style_name): New function.
2317         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2318         Update all callers according to the changes in cli/cli-style.h.
2319         * utils.h (fputs_highlighted): New function.
2320         * utils.c (fputs_highlighted): Likewise.
2321
2322 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2323
2324         * NEWS: Mention new pipe command and new convenience variables.
2325
2326 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2327
2328         * cli/cli-cmds.c (pipe_command): New function.
2329         (_initialize_cli_cmds): Call add_com for pipe_command.
2330         Define | as an alias for pipe.
2331         (exit_status_set_internal_vars): New function.
2332         (shell_escape): Call exit_status_set_internal_vars.
2333         cli/cli-decode.c (find_command_name_length): Recognize | as
2334         a single character command.
2335
2336 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2337
2338         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2339         top.c (execute_command_to_ui_file): New function, mostly a copy
2340         of execute_command_to_string.
2341         (execute_command_to_string): Implement by calling
2342         execute_command_to_ui_file.
2343
2344 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2345
2346         * top.h (saved_command_line): Remove declaration.
2347         * top.c (previous_saved_command_line, previous_repeat_arguments):
2348         New variables.
2349         (saved_command_line): Make static, define together with other
2350         'repeat variables'.
2351         (dont_repeat): Clear repeat_arguments.
2352         (repeat_previous, get_saved_command_line, save_command_line):
2353         New functions.
2354         (gdb_init): Initialize saved_command_line
2355         and previous_saved_command_line.
2356         * main.c (captured_main_1): Remove saved_command_line initialization.
2357         * event-top.c (handle_line_of_input): Update to use
2358         the new 'repeat' related functions instead of direct access to
2359         saved_command_line.
2360         * command.h (repeat_previous, get_saved_command_line,
2361         save_command_line): New declarations.
2362         (dont_repeat): Add comment.
2363
2364 2019-05-30  Tom Tromey  <tromey@adacore.com>
2365
2366         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2367         Fix comment.
2368         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2369
2370 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2371
2372         PR cli/24587
2373         * completer.c (complete): Initialize variable word.
2374
2375 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2376
2377         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2378         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2379         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2380         'body' is NULL to the outter 'if', protecting the '!is_define'
2381         situation as well.
2382
2383 2019-05-29  Tom Tromey  <tromey@adacore.com>
2384
2385         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2386         (dwarf_unknown): New function.
2387         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2388         (dwarf_type_encoding_name): Use dwarf_unknown.
2389
2390 2019-05-29  Tom Tromey  <tromey@adacore.com>
2391
2392         PR c++/20020:
2393         * cp-valprint.c (cp_print_value_fields): Call
2394         cp_print_static_field inside "try".
2395
2396 2019-05-29  Tom Tromey  <tromey@adacore.com>
2397
2398         * inflow.c (struct terminal_info): Add default operator=.
2399         * configure: Rebuild.
2400         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2401         -Wdeprecated-copy-dtor, -Wredundant-move.
2402
2403 2019-05-29  Tom Tromey  <tromey@adacore.com>
2404
2405         * NEWS: Add entry.
2406         * infcmd.c (print_return_value_1): Handle finish_print
2407         option.
2408         (show_print_finish): New function.
2409         (_initialize_infcmd): Add "set/show print finish" commands.
2410         * valprint.c (user_print_options): Initialize new member.
2411         * valprint.h (struct value_print_options) <finish_print>: New
2412         member.
2413
2414 2019-05-28  Tom Tromey  <tromey@adacore.com>
2415
2416         * ada-lang.c (ada_remove_Xbn_suffix)
2417         (find_old_style_renaming_symbol)
2418         (parse_old_style_renaming): Remove.
2419         (ada_find_renaming_symbol): Don't call
2420         find_old_style_renaming_symbol.
2421         (ada_is_renaming_symbol): Rename from
2422         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2423         bool.  Now static.
2424         (ada_read_var_value): Update and simplify.
2425         * ada-exp.y (write_var_or_type): Remove old code.
2426
2427 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2428
2429         * event-top.c: Remove include comment.
2430         * inflow.c (class scoped_ignore_sigttou): Move from here...
2431         * inflow.h (class scoped_ignore_sigttou): ...to here.
2432         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2433         * top.c:  Remove include comment.
2434
2435 2019-05-27  Tom Tromey  <tom@tromey.com>
2436
2437         * NEWS: Fix typo.
2438
2439 2019-05-22  Tom Tromey  <tromey@adacore.com>
2440
2441         * target.c (target_follow_exec): Constify parameter.
2442         * target-delegates.c: Rebuild.
2443         * remote.c (remote_target::follow_exec): Constify parameter.
2444         * infrun.c (follow_exec): Constify parameter.
2445         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2446         (target_follow_exec): Likewise.
2447
2448 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2449
2450         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2451         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2452
2453 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2454
2455         * NEWS: Add debugredirect and testsuite sections.
2456
2457 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2458
2459         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2460         target descriptions using exclusively floating point register name
2461         aliases.
2462
2463 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2464
2465         PR gdb/18644:
2466         * f-lang.c (build_fortran_types): Handle the case where
2467         gdbarch_floatformat_for_type returns a nullptr.
2468
2469 2019-05-21  Tom de Vries  <tdevries@suse.de>
2470
2471         PR cli/24587
2472         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2473
2474 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2475
2476         PR gdb/18644:
2477         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2478         16-byte floats.
2479         * i386-tdep.c (i386_floatformat_for_type): Use
2480         floatformats_ia64_quad for the 16-byte floating point component
2481         within a fortran 32-byte complex number.
2482
2483 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2484
2485         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2486         delete default constructor.
2487         (find_partial_die): Update to return const struct.
2488         (partial_die_parent_scope): Move variable declaration into scope
2489         of its use and change its type to auto.
2490         (guess_partial_die_structure_name): Likewise.
2491         (partial_die_info::fixup): Likewise.
2492
2493 2019-05-17  Tom Tromey  <tromey@adacore.com>
2494
2495         * source.c (find_and_open_source): Remove cast.
2496
2497 2019-05-17  Tom Tromey  <tromey@adacore.com>
2498
2499         * annotate.c (annotate_source): Make "filename" const.
2500         * annotate.h (annotate_source): Use const.
2501
2502 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2503
2504         * disasm.c (set_disassembler_options): Send errors to stderr.
2505
2506 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2507
2508         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2509         (cli_interp_base::set_logging): Check debug_redirect.
2510         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2511         * cli/cli-logging.c (debug_redirect): Add static variable.
2512         (pop_output_files): Add default param.
2513         (handle_redirections): Print debug setting.
2514         (show_logging_command): Likewise.
2515         (_initialize_cli_logging): Add debugredirect command.
2516         * interps.c (current_interp_set_logging): Add debug_redirect
2517         parameter.
2518         * interps.h (set_logging): Add debug_redirect parameter.
2519         (current_interp_set_logging): Likewise.
2520         * mi/mi-common.h: Likewise.
2521         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2522
2523 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2524             Tom Tromey  <tromey@adacore.com>
2525
2526         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2527         directly.
2528         * cli/cli-interp.h (make_logging_output): Remove declaration.
2529         * cli/cli-logging.c (make_logging_output): Remove function.
2530         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2531         directly.
2532         * ui-file.c (tee_file::tee_file): Remove bools.
2533         (tee_file::~tee_file): Remove deletes.
2534         * ui-file.h (tee_file): Remove bools.
2535
2536 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2537
2538         * mi/mi-cmds.h (mi_cmd_complete): New function.
2539         * mi/mi-main.c (mi_cmd_complete): Likewise.
2540         * mi/mi-cmds.c: Define new MI command -complete.
2541         * NEWS: Mention new -complete command.
2542
2543 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2544
2545         * completer.h (complete): New function.
2546         * completer.c (complete): Likewise.
2547         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2548         function defined in completer.h.
2549
2550 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2551
2552         * MAINTAINERS (Write After Approval): Add myself.
2553
2554 2019-05-17  Tom de Vries  <tdevries@suse.de>
2555
2556         PR gdb/24094
2557         * dwarf2read.c (struct cu_partial_die_info): New struct.
2558         (find_partial_die): Return cu_partial_die_info.
2559         (partial_die_parent_scope, guess_partial_die_structure_name)
2560         (partial_die_info::fixup): Handle new return type of find_partial_die.
2561
2562 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2563
2564         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2565         "std::string", simplifying the algorithm.
2566
2567 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2568
2569         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2570         (stap_static_probe_ops::get_probes): Likewise.
2571
2572 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2573
2574         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2575         '-')" and "else if".
2576         (stap_parse_single_operand): Join checks for
2577         "gdbarch_stap_parse_special_token_p" and
2578         "gdbarch_stap_parse_special_token" in the same "if" statement.
2579         Invert check when verifying for operation on register
2580         displacement.
2581
2582 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2583
2584         * stap-probe.c (stap_get_opcode): Update comment.
2585         (stap_get_expected_argument_type): Likewise.
2586         (handle_stap_probe): Likewise.
2587
2588 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2589
2590         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2591         return type to 'bool'.  Adjust comment.  Use 'bool' when
2592         appropriate.
2593         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2594         * stap-probe.c (stap_parse_argument_1): Likewise.
2595         (stap_is_operator): Likewise.
2596         (stap_is_generic_prefix): Likewise.
2597         (stap_is_register_prefix): Likewise.
2598         (stap_is_register_indirection_prefix): Likewise.
2599         (stap_is_integer_prefix): Likewise.
2600         (stap_generic_check_suffix): Likewise.
2601         (stap_check_integer_suffix): Likewise.
2602         (stap_check_register_suffix): Likewise.
2603         (stap_check_register_indirection_suffix): Likewise.
2604         (stap_parse_register_operand): Likewise.
2605         (stap_parse_single_operand): Likewise.
2606         (stap_parse_argument_1): Likewise.
2607         (stap_probe::get_argument_count): Likewise.
2608         (stap_is_operator): Likewise.
2609
2610 2019-05-16  Tom Tromey  <tromey@adacore.com>
2611
2612         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2613         keyword to foreach.
2614
2615 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2616
2617         * linux-thread-db.c (try_thread_db_load_1): Change return type
2618         to bool.
2619         (try_thread_db_load): Likewise.
2620         (try_thread_db_load_from_pdir_1): Likewise.
2621         (try_thread_db_load_from_pdir): Likewise.
2622         (try_thread_db_load_from_sdir): Likewise.
2623         (try_thread_db_load_from_dir): Likewise.
2624         (thread_db_load_search): Likewise.
2625         (has_libpthread): Likewise.
2626         (thread_db_load): Likewise.
2627
2628 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2629
2630         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2631         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2632         NULL, and complain/return if that's the case.
2633
2634 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2635
2636         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2637         (advance, posn, abstract_read_memory): New functions.
2638         [struct mem_read_abstraction]: New struct.
2639         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2640
2641 2019-05-14  Tom Tromey  <tromey@adacore.com>
2642
2643         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2644         value is not lval_memory.
2645
2646 2019-05-14  Tom Tromey  <tromey@adacore.com>
2647
2648         * solib.c (info_sharedlibrary_command): Style the file name.
2649
2650 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2651
2652         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2653         (aarch64_vnv_type): Likewise.
2654         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2655         * common/tdesc.c: Likewise.
2656         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2657         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2658         * features/aarch64-fpu.xml: Add ieee half view.
2659         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2660         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2661         * gdbtypes.h (struct builtin_type): Likewise.
2662         (struct objfile_type): Likewise.
2663
2664 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2665
2666         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2667         typo.
2668         * location.h (string_to_event_location): Likewise.
2669
2670 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2671
2672         GDB 8.3 released.
2673
2674 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2675
2676         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2677         New variable declaration.
2678         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2679         New variable.
2680         (print_one_breakpoint): Use ui_out::test_flags and new global
2681         variable to compute use_fixed_output.
2682         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2683         Remove.
2684         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2685         (mi_multi_location_breakpoint_output_fixed): Remove.
2686         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2687         new variable.
2688         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2689         fix_multi_location_breakpoint_output flag if version >= 3.
2690         * ui-out.h (enum ui_out_flag)
2691         <fix_multi_location_breakpoint_output>: New enumerator.
2692
2693 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2694
2695         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2696
2697 2019-05-10  Tom Tromey  <tromey@adacore.com>
2698
2699         * ada-lang.c (catch_ada_completer): New function.
2700         (_initialize_ada_language): Use it.
2701
2702 2019-05-10  Tom Tromey  <tromey@adacore.com>
2703
2704         * thread.c (print_thread_info): Make "requested_threads" const.
2705         * gdbthread.h (print_thread_info): Make "requested_threads"
2706         const.
2707         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2708         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2709
2710 2019-05-08  Tom Tromey  <tom@tromey.com>
2711
2712         * gdbtypes.c (objfile_type_data): Change type.
2713         (objfile_type, _initialize_gdbtypes): Update.
2714
2715 2019-05-08  Tom Tromey  <tom@tromey.com>
2716
2717         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2718         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2719         (_initialize_dwarf2_frame): Update.
2720
2721 2019-05-08  Tom Tromey  <tom@tromey.com>
2722
2723         * objc-lang.c (objc_objfile_data): Change type.
2724         (find_methods): Update.
2725         (_initialize_objc_lang): Remove.
2726
2727 2019-05-08  Tom Tromey  <tom@tromey.com>
2728
2729         * stabsread.c (rs6000_builtin_type_data): Change type.
2730         (rs6000_builtin_type, _initialize_stabsread): Update.
2731
2732 2019-05-08  Tom Tromey  <tom@tromey.com>
2733
2734         * mips-tdep.c (mips_pdr_data): Remove.
2735         (_initialize_mips_tdep): Update.
2736
2737 2019-05-08  Tom Tromey  <tom@tromey.com>
2738
2739         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2740         (hppa_init_objfile_priv_data, read_unwind_info)
2741         (find_unwind_entry, _initialize_hppa_tdep): Update.
2742
2743 2019-05-08  Tom Tromey  <tom@tromey.com>
2744
2745         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2746         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2747         on obstack.
2748         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2749
2750 2019-05-08  Tom Tromey  <tom@tromey.com>
2751
2752         * mdebugread.c (basic_type_data): Change type.
2753         (basic_type, _initialize_mdebugread): Update.
2754
2755 2019-05-08  Tom Tromey  <tom@tromey.com>
2756
2757         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2758
2759 2019-05-08  Tom Tromey  <tom@tromey.com>
2760
2761         * nto-tdep.c (nto_inferior_data_reg): Change type.
2762         (nto_inferior_data): Update.
2763         (nto_inferior_data_cleanup, nto_new_inferior_data)
2764         (_initialize_nto_tdep): Remove.
2765         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2766
2767 2019-05-08  Tom Tromey  <tom@tromey.com>
2768
2769         * ada-lang.c (struct ada_inferior_data): Add initializers.
2770         (ada_inferior_data): Change type.
2771         (ada_inferior_data_cleanup): Remove.
2772         (get_ada_inferior_data, ada_inferior_exit)
2773         (struct ada_pspace_data): Add initializers, destructor.
2774         (ada_pspace_data_handle): Change type.
2775         (get_ada_pspace_data): Update.
2776         (ada_pspace_data_cleanup): Remove.
2777
2778 2019-05-08  Tom Tromey  <tom@tromey.com>
2779
2780         * coffread.c (struct coff_symfile_info): Add initializers.
2781         (coff_objfile_data_key): Move lower.  Change type.
2782         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2783         Update.
2784         (coff_free_info): Remove.
2785
2786 2019-05-08  Tom Tromey  <tom@tromey.com>
2787
2788         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2789         (fbsd_pspace_data_handle): Move lower.  Change type.
2790         (get_fbsd_pspace_data): Update.
2791         (fbsd_pspace_data_cleanup): Remove.
2792         (_initialize_fbsd_tdep): Update.
2793
2794 2019-05-08  Tom Tromey  <tom@tromey.com>
2795
2796         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2797         (get_ada_tasks_pspace_data): Update.
2798         (ada_tasks_pspace_data_cleanup): Remove.
2799         (_initialize_tasks): Update.
2800         (ada_tasks_inferior_data_handle): Change type.
2801         (get_ada_tasks_inferior_data): Update.
2802         (ada_tasks_inferior_data_cleanup): Remove.
2803         (struct ada_tasks_pspace_data): Add initializers.
2804
2805 2019-05-08  Tom Tromey  <tom@tromey.com>
2806
2807         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2808         * symfile-debug.c (debug_sym_get_probes): Change type.
2809         * stap-probe.c (handle_stap_probe):
2810         (stap_static_probe_ops::get_probes): Change type.
2811         * probe.h (class static_probe_ops) <get_probes>: Change type.
2812         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2813         (parse_probes_in_pspace): Update.
2814         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2815         Update.
2816         (any_static_probe_ops::get_probes): Change type.
2817         * elfread.c (elfread_data): New typedef.
2818         (probe_key): Change type.
2819         (elf_get_probes): Likewise.  Update.
2820         (probe_key_free): Remove.
2821         (_initialize_elfread): Update.
2822         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2823         Change type.
2824         (dtrace_process_dof_probe, dtrace_process_dof)
2825         (dtrace_static_probe_ops::get_probe): Change type.
2826
2827 2019-05-08  Tom Tromey  <tom@tromey.com>
2828
2829         * xcoffread.c (struct xcoff_symfile_info): Rename from
2830         coff_symfile_info.  Add initializers.
2831         (xcoff_objfile_data_key): Move lower.  Change type.
2832         (XCOFF_DATA): Rewrite.
2833         (xcoff_free_info): Remove.
2834         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2835         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2836         (xcoff_initial_scan): Update.
2837
2838 2019-05-08  Tom Tromey  <tom@tromey.com>
2839
2840         * solib-svr4.c (struct svr4_info): Add initializers and
2841         destructor.
2842         <probes_table>: Now an htab_up.
2843         (solib_svr4_pspace_data): Change type.
2844         (free_probes_table): Simplify.
2845         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2846         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2847         (probes_table_remove_objfile_probes, register_solib_event_probe)
2848         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2849         (_initialize_svr4_solib): Update.
2850
2851 2019-05-08  Tom Tromey  <tom@tromey.com>
2852
2853         * remote.c (remote_pspace_data): Change type.
2854         (remote_pspace_data_cleanup): Remove.
2855         (get_remote_exec_file, set_pspace_remote_exec_file)
2856         (_initialize_remote): Update.
2857
2858 2019-05-08  Tom Tromey  <tom@tromey.com>
2859
2860         * breakpoint.c (breakpoint_objfile_key): Change type.
2861         (get_breakpoint_objfile_data): Update.
2862         (free_breakpoint_objfile_data): Remove.
2863         (_initialize_breakpoint): Update.
2864
2865 2019-05-08  Tom Tromey  <tom@tromey.com>
2866
2867         * linux-tdep.c (struct linux_info): Add initializers.
2868         (linux_inferior_data): Move.  Change type.
2869         (invalidate_linux_cache_inf): Update.
2870         (linux_inferior_data_cleanup): Remove.
2871         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2872
2873 2019-05-08  Tom Tromey  <tom@tromey.com>
2874
2875         * auxv.c (auxv_inferior_data): Move.  Change type.
2876         (auxv_inferior_data_cleanup): Remove.
2877         (invalidate_auxv_cache_inf): Rewrite.
2878         (get_auxv_inferior_data, _initialize_auxv): Update.
2879
2880 2019-05-08  Tom Tromey  <tom@tromey.com>
2881
2882         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2883         (symfile_debug_objfile_data_key): Change type.
2884         (symfile_debug_installed, debug_qf_has_symbols)
2885         (debug_qf_find_last_source_symtab)
2886         (debug_qf_forget_cached_source_info)
2887         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2888         (debug_qf_print_stats, debug_qf_dump)
2889         (debug_qf_expand_symtabs_for_function)
2890         (debug_qf_expand_all_symtabs)
2891         (debug_qf_expand_symtabs_with_fullname)
2892         (debug_qf_map_matching_symbols)
2893         (debug_qf_expand_symtabs_matching)
2894         (debug_qf_find_pc_sect_compunit_symtab)
2895         (debug_qf_map_symbol_filenames)
2896         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2897         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2898         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2899         (debug_sym_read_linetable, debug_sym_relocate): Update.
2900         (symfile_debug_free_objfile): Remove.
2901         (install_symfile_debug_logging, _initialize_symfile_debug):
2902         Update.
2903
2904 2019-05-08  Tom Tromey  <tom@tromey.com>
2905
2906         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2907         allocate_on_obstack.
2908         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2909         (get_dwarf2_per_objfile): Update.
2910         (set_dwarf2_per_objfile): Remove.
2911         (dwarf2_has_info, dwarf2_get_section_info): Update.
2912         (dwarf2_free_objfile): Remove.
2913         (_initialize_dwarf2_read): Update.
2914
2915 2019-05-08  Tom Tromey  <tom@tromey.com>
2916
2917         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2918         initializers.
2919         <unsupported_script_warning_printed,
2920         script_not_found_warning_printed>: Now bool.
2921         (auto_load_pspace_data): Change type.
2922         (~auto_load_pspace_info): Rename from
2923         auto_load_pspace_data_cleanup.
2924         (get_auto_load_pspace_data, init_loaded_scripts_info)
2925         (clear_section_scripts, maybe_print_unsupported_script_warning)
2926         (maybe_print_script_not_found_warning, _initialize_auto_load):
2927         Update.
2928
2929 2019-05-08  Tom Tromey  <tom@tromey.com>
2930
2931         * objfiles.c (objfile_pspace_info): Add destructor and
2932         initializers.
2933         (objfiles_pspace_data): Change type.
2934         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2935         (get_objfile_pspace_data): Update.
2936         (objfiles_bfd_data): Change type.
2937         (get_objfile_bfd_data): Update.
2938         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2939
2940 2019-05-08  Tom Tromey  <tom@tromey.com>
2941
2942         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2943         Change type.
2944         (get_catch_syscall_inferior_data): Update.
2945         (catch_syscall_inferior_data_cleanup): Remove.
2946         (_initialize_break_catch_syscall): Update.
2947
2948 2019-05-08  Tom Tromey  <tom@tromey.com>
2949
2950         * inflow.c (struct terminal_info): Add destructor and
2951         initializers.
2952         (inflow_inferior_data): Change type.
2953         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2954         (get_inflow_inferior_data, inflow_inferior_exit)
2955         (swap_terminal_info, _initialize_inflow): Update.
2956
2957 2019-05-08  Tom Tromey  <tom@tromey.com>
2958
2959         * target-dcache.c (target_dcache_cleanup): Remove.
2960         (target_dcache_aspace_key): Change type.
2961         (target_dcache_init_p, target_dcache_invalidate)
2962         (target_dcache_get, target_dcache_get_or_init)
2963         (_initialize_target_dcache): Update.
2964         * dcache.h (struct dcache_deleter): New.
2965
2966 2019-05-08  Tom Tromey  <tom@tromey.com>
2967
2968         * symtab.c (struct symbol_cache): Add destructor and
2969         initializers.
2970         (symbol_cache_key): Move.  Change type.
2971         (make_symbol_cache, free_symbol_cache): Remove.
2972         (get_symbol_cache): Update.
2973         (symbol_cache_cleanup): Remove.
2974         (ALL_PSPACES, symbol_cache_flush)
2975         (maintenance_print_symbol_cache)
2976         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2977         Update.
2978
2979 2019-05-08  Tom Tromey  <tom@tromey.com>
2980
2981         * symtab.c (struct main_info): Add destructor and initializers.
2982         (main_progspace_key): Move.  Change type.
2983         (get_main_info): Update.
2984         (main_info_cleanup): Remove.
2985         (_initialize_symtab): Update.
2986
2987 2019-05-08  Tom Tromey  <tom@tromey.com>
2988
2989         * registry.h (DECLARE_REGISTRY): Define the _key class.
2990
2991 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2992
2993         * NEWS: Merge two 'New commands' sections.
2994
2995 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2996
2997         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2998         parameter and use Ada language definition instead.
2999         (ada_val_print_ptr): Remove unused language parameter.
3000         (ada_val_print_num): Remove language parameter and use Ada language
3001         definition instead.
3002         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3003         parameter.
3004         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3005         parameter and use Ada language definition instead.
3006         (ada_val_print_1): Update all ada_val_print_xxx calls.
3007         Remove language parameter.
3008         (ada_val_print): Update ada_val_print_1 call.
3009
3010 2019-05-08  Tom Tromey  <tromey@adacore.com>
3011
3012         * remote.c (remote_hw_watchpoint_limit)
3013         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3014         Now static.
3015
3016 2019-05-08  Tom Tromey  <tromey@adacore.com>
3017
3018         * maint.c (_initialize_maint_cmds): Move initialization code to
3019         remote.c.
3020         (watchdog, show_watchdog): Move to remote.c.
3021         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3022         "watchdog" static.
3023         (_initialize_remote): Move initialization code from maint.c.
3024         * defs.h (watchdog): Don't declare.
3025
3026 2019-05-08  Tom Tromey  <tromey@adacore.com>
3027
3028         * tui/tui-interp.c: Include main.h.
3029         * interps.c: Include main.h.
3030         * main.h (interpreter_p): Declare.
3031         * defs.h (interpreter_p): Don't declare.
3032
3033 2019-05-08  Tom Tromey  <tromey@adacore.com>
3034
3035         * dwarf2loc.c: Include dwarf2read.h.
3036         * defs.h (read_unsigned_leb128): Don't declare.
3037         * dwarf2read.h (read_unsigned_leb128): Declare.
3038
3039 2019-05-08  Tom Tromey  <tromey@adacore.com>
3040
3041         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3042         method.
3043
3044 2019-05-08  Tom Tromey  <tromey@adacore.com>
3045
3046         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3047         when no wrap column is set.
3048
3049 2019-05-08  Tom Tromey  <tromey@adacore.com>
3050
3051         * c-lang.c (c_get_string): Handle non-C-style arrays.
3052
3053 2019-05-08  Tom Tromey  <tromey@adacore.com>
3054
3055         * typeprint.c (print_offset_data::update): Print the bit offset,
3056         not the number of bits remaining.
3057
3058 2019-05-08  Tom Tromey  <tromey@adacore.com>
3059
3060         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3061         padding at end of comment.
3062
3063 2019-05-08  Tom Tromey  <tromey@adacore.com>
3064
3065         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3066         Compare main types.
3067
3068 2019-05-06  Tom Tromey  <tom@tromey.com>
3069
3070         * common/scoped_mmap.c: Include common-defs.h.
3071         * common/scoped_mmap.h: Don't include config.h.
3072
3073 2019-05-04  Tom Tromey  <tom@tromey.com>
3074
3075         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3076         (struct aarch64_call_info): Add initializers.
3077         <si>: Now a std::vector.
3078         (pass_on_stack, aarch64_push_dummy_call): Update.
3079
3080 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3081             Tom Tromey  <tom@tromey.com>
3082
3083         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3084         (ppc_threads): Now a std::vector.  Now static.
3085         (hwdebug_find_thread_points_by_tid)
3086         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3087         Update.
3088
3089 2019-05-04  Tom Tromey  <tom@tromey.com>
3090
3091         * arc-tdep.c (arc_tdesc_init): Return bool.
3092
3093 2019-05-04  Tom Tromey  <tom@tromey.com>
3094
3095         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3096         Use gdb_assert_not_reached.
3097
3098 2019-05-04  Tom Tromey  <tom@tromey.com>
3099
3100         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3101         "false".
3102
3103 2019-05-04  Tom Tromey  <tom@tromey.com>
3104
3105         * arc-tdep.c (arc_tdesc_init): Use bool.
3106
3107 2019-05-04  Tom Tromey  <tom@tromey.com>
3108
3109         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3110
3111 2019-05-04  Tom Tromey  <tom@tromey.com>
3112
3113         * cli/cli-cmds.c (valid_command_p): Return bool.
3114
3115 2019-05-04  Tom Tromey  <tom@tromey.com>
3116
3117         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3118         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3119
3120 2019-05-04  Raul Tambre  <raul@tambre.ee>
3121
3122         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3123         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3124         operator for comparison.
3125
3126 2019-05-04  Tom Tromey  <tom@tromey.com>
3127
3128         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3129         (lookup_partial_symbol, print_partial_symbols)
3130         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3131         (psymbol_compare): Update.
3132         (add_psymbol_to_bcache): Clear the entire psymbol.
3133         (maintenance_check_psymtabs): Update.
3134         * psympriv.h (struct partial_symbol): Don't derive from
3135         general_symbol_info.
3136         <obj_section, unrelocated_address, address,
3137         set_unrelocated_address>: Update.
3138         <ginfo>: New member.
3139         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3140         (debug_names::write_psymbols): Update.
3141
3142 2019-05-04  Tom de Vries  <tdevries@suse.de>
3143
3144         * contrib/cc-with-tweaks.sh: Support -n arg.
3145
3146 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3147
3148         * corelow.c (core_target::detach): Ensure frame cache and
3149         register caches are cleared.
3150         inferior.c (exit_inferior_1): Likewise.
3151
3152 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3153             Tom Tromey  <tom@tromey.com>
3154
3155         * dictionary.c (collate_pending_symbols_by_language): Remove
3156         "struct" from foreach.
3157         * symtab.c (lookup_global_symbol_from_objfile)
3158         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3159         foreach.
3160         * ser-tcp.c (net_open): Remove "struct" from foreach.
3161         * objfiles.c (objfile_relocate, objfile_rebase)
3162         (objfile_has_symbols): Remove "struct" from foreach.
3163         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3164         from foreach.
3165         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3166         foreach.
3167         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3168         "struct" from foreach.
3169         * ada-lang.c (create_excep_cond_exprs)
3170         (ada_exception_catchpoint_cond_string): Remove "struct" from
3171         foreach.
3172
3173 2019-05-03  Tom Tromey  <tromey@adacore.com>
3174
3175         * ada-exp.y (convert_char_literal): Check suffix of each
3176         enumerator.
3177
3178 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3179
3180         PR ada/21406:
3181         * ada-exp.y (yywrap): Don't define.
3182         * ada-lex.l (%option): Add noyywrap
3183         (yywrap): Remove.
3184
3185 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3186
3187         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3188         _WIN32_WINNT to the XP level, unless already defined to a higher
3189         level.
3190
3191         * unittests/parse-connection-spec-selftests.c:
3192         * ser-tcp.c:
3193         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3194         override.
3195
3196         * symfile.c (find_separate_debug_file): Remove colon from the
3197         drive spec of DOS/Windows file names of the target, so that the
3198         file name produced from DEBUGDIR and the target's directory will
3199         be valid on DOS/Windows systems.
3200
3201 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3202
3203         * rust-lang.c (val_print_struct): Handle printing structures
3204         containing strings.
3205
3206 2019-05-02  Tom Tromey  <tromey@adacore.com>
3207
3208         * valarith.c (_initialize_valarith): Remove.
3209
3210 2019-05-01  Tom Tromey  <tromey@adacore.com>
3211
3212         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3213         bitfields.
3214
3215 2019-05-01  Tom Tromey  <tromey@adacore.com>
3216
3217         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3218         for big-endian copies.
3219
3220 2019-04-30  Ali Tamur  <tamur@google.com>
3221         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3222         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3223         (read_3_bytes): New function.
3224
3225 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3226
3227         * windows-nat.c (main_thread_id): Delete.
3228         (handle_output_debug_string): Replace main_thread_id by
3229         current_event.dwThreadId.
3230         (fake_create_process): Likewise.
3231         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3232         Do not set main_thread_id.
3233         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3234         current_event.dwThreadId.
3235         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3236
3237 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3238
3239         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3240         Use current_event.dwThreadId instead of main_thread_id.
3241
3242 2019-04-30  Tom Tromey  <tromey@adacore.com>
3243
3244         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3245         (create_excep_cond_exprs): Iterate over program spaces.
3246         (ada_exception_catchpoint_cond_string): Examine all minimal
3247         symbols for exception types.
3248
3249 2019-04-30  Tom Tromey  <tromey@adacore.com>
3250
3251         PR c++/24470:
3252         * dwarf2read.c (process_structure_scope): Handle case where type
3253         has template parameters but no symbol was created.
3254
3255 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3256             Chris January  <chris.january@arm.com>
3257
3258         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3259         qualifier.
3260         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3261
3262 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3263
3264         * f-typeprint.c (f_print_type): Update rules for printing
3265         whitespace.
3266         (f_type_print_varspec_suffix): Likewise.
3267
3268 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3269             Chris January  <chris.january@arm.com>
3270
3271         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3272         function arguments.
3273
3274 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3275
3276         * f-lang.c (build_fortran_types): Change name of void type to
3277         lower case.
3278         * f-typeprint.c (f_type_print_base): Print the name of the void
3279         type, rather than a fixed string.
3280         * f-valprint.c (f_decorations): Use lower case void string.
3281
3282 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3283             Chris January  <chris.january@arm.com>
3284
3285         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3286         types for Fortran.
3287
3288 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3289             Chris January  <chris.january@arm.com>
3290             David Lecomber  <david.lecomber@arm.com>
3291
3292         * f-exp.y (BINOP_INTRINSIC): New token.
3293         (exp): New parser rule handling BINOP_INTRINSIC.
3294         (f77_keywords): Add new builtin procedures.
3295         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3296         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3297         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3298         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3299         (print_unop_subexp_f): New function.
3300         (print_binop_subexp_f): New function.
3301         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3302         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3303         (dump_subexp_body_f): Likewise.
3304         (operator_check_f): Likewise.
3305         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3306         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3307
3308 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3309
3310         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3311         UNOP_KIND.
3312         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3313         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3314         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3315         (operator_length_f): New fuction.
3316         (print_subexp_f): New function.
3317         (op_name_f): New function.
3318         (dump_subexp_body_f): New function.
3319         (operator_check_f): New function.
3320         (exp_descriptor_f): Replace standard expression handling functions
3321         with new functions.
3322         * gdb/fortran-operator.def: New file.
3323         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3324         * gdb/std-operator.def: Remove UNOP_KIND.
3325
3326 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3327
3328         * std-operator.def: Remove unbalanced, stray double quote
3329         character.
3330
3331 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3332             Chris January  <chris.january@arm.com>
3333             Daniel Everett  <daniel.everett@arm.com>
3334             Nick Forrington  <nick.forrington@arm.com>
3335             Richard Bunt  <richard.bunt@arm.com>
3336
3337         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3338         of depth when printing anonymous structs or unions.
3339         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3340         Don't print either the top-level value, or the children if the
3341         max-depth is exceeded.
3342         (ppscm_print_children): When printing the key of a map, allow one
3343         extra level of depth.
3344         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3345         print either the top-level value, or the children if the max-depth
3346         is exceeded.
3347         (print_children): When printing the key of a map, allow one extra
3348         level of depth.
3349         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3350         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3351         (user_print_options): Initialise max_depth field.
3352         (val_print_scalar_or_string_type_p): New function.
3353         (val_print): Check to see if the max depth has been reached.
3354         (val_print_check_max_depth): Define new function.
3355         (show_print_max_depth): New function.
3356         (_initialize_valprint): Add 'print max-depth' option.
3357         * valprint.h (struct value_print_options) <max_depth>: New field.
3358         (val_print_check_max_depth): Declare new function.
3359         * NEWS: Document new feature.
3360
3361 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3362
3363         * ada-lang.c (ada_language_defn): Initialise new field.
3364         * c-lang.c (c_is_string_type_p): New function.
3365         (c_language_defn): Initialise new field.
3366         (cplus_language_defn): Initialise new field.
3367         (asm_language_defn): Initialise new field.
3368         (minimal_language_defn): Initialise new field.
3369         * c-lang.h (c_is_string_type_p): Declare new function.
3370         * d-lang.c (d_language_defn): Initialise new field.
3371         * f-lang.c (f_is_string_type_p): New function.
3372         (f_language_defn): Initialise new field.
3373         * go-lang.c (go_is_string_type_p): New function.
3374         (go_language_defn): Initialise new field.
3375         * language.c (default_is_string_type_p): New function.
3376         (unknown_language_defn): Initialise new field.
3377         (auto_language_defn): Initialise new field.
3378         * language.h (struct language_defn) <la_is_string_type_p>: New
3379         member variable.
3380         (default_is_string_type_p): Declare new function.
3381         * m2-lang.c (m2_language_defn): Initialise new field.
3382         * objc-lang.c (objc_language_defn): Initialise new field.
3383         * opencl-lang.c (opencl_language_defn): Initialise new field.
3384         * p-lang.c (pascal_is_string_type_p): New function.
3385         (pascal_language_defn): Initialise new field.
3386         * rust-lang.c (rust_is_string_type_p): New function.
3387         (rust_language_defn): Initialise new field.
3388
3389 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3390
3391         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3392         New field.
3393         * ada-lang.c (ada_language_defn): Initialise new field.
3394         * c-lang.c (c_language_defn): Likewise.
3395         (cplus_language_defn): Likewise.
3396         (asm_language_defn): Likewise.
3397         (minimal_language_defn): Likewise.
3398         * d-lang.c (d_language_defn): Likewise.
3399         * f-lang.c (f_language_defn): Likewise.
3400         * go-lang.c (go_language_defn): Likewise.
3401         * language.c (unknown_language_defn): Likewise.
3402         (auto_language_defn): Likewise.
3403         * m2-lang.c (m2_language_defn): Likewise.
3404         * objc-lang.c (objc_language_defn): Likewise.
3405         * opencl-lang.c (opencl_language_defn): Likewise.
3406         * p-lang.c (pascal_language_defn): Likewise.
3407         * rust-lang.c (rust_language_defn): Likewise.
3408
3409 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3410
3411         * ada-lang.c (ada_is_character_type): Change return type to bool.
3412         (ada_is_string_type): Likewise.
3413         * ada-lang.h (ada_is_character_type): Update declaration
3414         (ada_is_string_type): Likewise.
3415
3416 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3417
3418         Support style in 'frame|thread apply'
3419
3420         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3421         * record.c (record_start, record_stop): Update callers of
3422         execute_command_to_string with false.
3423         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3424         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3425         methods.
3426         (class string_file): New constructor with term_out parameter.
3427         Override methods term_out and can_emit_style_escape.  New member
3428         term_out.
3429         (class stdio_file): Override can_emit_style_escape.
3430         (class tee_file): Override term_out and can_emit_style_escape.
3431         * utils.h (can_emit_style_escape): Remove.
3432         * utils.c (can_emit_style_escape): Likewise.
3433         Update all callers of can_emit_style_escape (SOMESTREAM) to
3434         SOMESTREAM->can_emit_style_escape.
3435         * source-cache.c (source_cache::get_source_lines): Likewise.
3436         * stack.c (frame_apply_command_count): Call execute_command_to_string
3437         passing the term_out characteristic of the current gdb_stdout.
3438         * thread.c (thr_try_catch_cmd): Likewise.
3439         * top.c (execute_command_to_string): pass term_out parameter
3440         to construct the string_file for the command output.
3441         * ui-file.c (term_cli_styling): New function (most code moved
3442         from utils.c can_emit_style_escape).
3443         (string_file::string_file, string_file::can_emit_style_escape,
3444         stdio_file::can_emit_style_escape, tee_file::term_out,
3445         tee_file::can_emit_style_escape): New functions.
3446
3447 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3448
3449         * NEWS: Mention the new set|show may-call-functions.
3450         * infcall.c (may_call_functions_p): New variable.
3451         (show_may_call_functions_p): New function.
3452         (call_function_by_hand_dummy): Throws an error if not
3453         may-call-functions.
3454         (_initialize_infcall): Call add_setshow_boolean_cmd for
3455         may-call-functions.
3456
3457 2019-04-25  Keith Seitz  <keiths@redhat.com>
3458
3459         PR c++/24367
3460         * cp-support.c (inspect_type): Don't attempt substitutions
3461         of symbol with the same name.
3462
3463 2019-04-25  Tom Tromey  <tromey@adacore.com>
3464
3465         PR gdb/24475:
3466         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3467         static.
3468
3469 2019-04-25  Tom Tromey  <tromey@adacore.com>
3470
3471         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3472         rvalue reference.
3473         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3474         (gdb_xml_parser::parse): Use std::move.
3475         * python/python-internal.h (gdbpy_convert_exception): Take a const
3476         reference.
3477         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3478         std::move.
3479         * python/py-utils.c (gdbpy_convert_exception): Take a const
3480         reference.
3481         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3482         Use std::move.
3483         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3484         Use std::move.
3485         * mi/mi-main.c (mi_print_exception): Take a const reference.
3486         * main.c (handle_command_errors): Take a const reference.
3487         * linespec.c (parse_linespec): Use std::move.
3488         * infcall.c (run_inferior_call): Use std::move.
3489         (call_function_by_hand_dummy): Use std::move.
3490         * exec.c (try_open_exec_file): Use std::move.
3491         * exceptions.h (exception_print, exception_fprintf)
3492         (exception_print_same): Update.
3493         * exceptions.c (print_exception, exception_print)
3494         (exception_fprintf, exception_print_same): Change parameters to
3495         const reference.
3496         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3497         * common/new-op.c: Use std::move.
3498         * common/common-exceptions.h (struct gdb_exception): Add move
3499         constructor.
3500         (struct gdb_exception_error, struct gdb_exception_quit, struct
3501         gdb_quit_bad_alloc): Change constructor to move constructor.
3502         (throw_exception): Change parameter to rvalue reference.
3503         * common/common-exceptions.c (throw_exception): Take rvalue
3504         reference.
3505         * cli/cli-interp.c (safe_execute_command): Use std::move.
3506         * breakpoint.c (insert_bp_location, location_to_sals): Use
3507         std::move.
3508
3509 2019-04-25  Tom Tromey  <tromey@adacore.com>
3510
3511         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3512         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3513         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3514         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3515         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3516         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3517         guile/scm-value.c: Use unpack.
3518         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3519         gdbscm_gdb_exception.
3520         (gdbscm_throw_gdb_exception): Likewise.
3521         (struct gdbscm_gdb_exception): New.
3522         (unpack): New function.
3523         (gdbscm_wrap): Use unpack.
3524
3525 2019-04-25  Tom Tromey  <tromey@adacore.com>
3526
3527         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3528         (gdb_rl_callback_handler): Use std::move.
3529         * common/common-exceptions.h (struct gdb_exception): Add move
3530         assignment operator.
3531         (throw_exception_sjlj): Change "exception" to const reference.
3532         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3533         (throw_exception_sjlj): Change "exception" to const reference.
3534
3535 2019-04-25  Tom Tromey  <tromey@adacore.com>
3536
3537         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3538         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3539         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3540         Update.
3541         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3542         Update.
3543         * mi/mi-interp.c (mi_interp::exec): Update.
3544         * linespec.c (parse_linespec): Update.
3545         * infcall.c (run_inferior_call): Update.
3546         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3547         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3548         (gdbscm_lookup_global_symbol): Update.
3549         * guile/scm-param.c (gdbscm_parameter_value): Update.
3550         * guile/scm-frame.c (gdbscm_frame_read_register)
3551         (gdbscm_frame_read_var): Update.
3552         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3553         * exec.c (try_open_exec_file): Update.
3554         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3555         (gdb_rl_callback_handler): Update.
3556         * common/common-exceptions.h (exception_none): Don't declare.
3557         * common/common-exceptions.c (exception_none): Don't define.
3558         (struct catcher) <exception>: Update.
3559         * cli/cli-interp.c (safe_execute_command): Update.
3560         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3561
3562 2019-04-25  Ali Tamur  <tamur@google.com>
3563
3564         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3565         (read_attribute_value): Likewise.
3566         (dwarf2_read_addr_index): Update comment.
3567         (read_str_index): Add DW_FORM_strx.
3568         (dwarf2_string_attr): Likewise.
3569         (dwarf2_const_value_attr): Likewise.
3570         (dump_die_shallow): Likewise.
3571         (dwarf2_fetch_constant_bytes): Likewise.
3572         (skip_form_bytes): Likewise.
3573         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3574
3575 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3576
3577         PR corefiles/11608
3578         PR corefiles/18187
3579         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3580         OFFSET.  Verify if current mapping contains an ELF header.
3581         (linux_find_memory_regions_full): Adjust call to
3582         dump_mapping_p.
3583
3584 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3585             Kang Li <kanglictf@gmail.com>
3586
3587         PR gdb/21600
3588
3589         * dwarf2-frame.c (read_initial_length): Be consistent about using
3590         unsigned representation of length.
3591         (decode_frame_entry_1): Likewise.  Check for wraparound of
3592         end pointer as well as buffer overflow.
3593
3594 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3595
3596         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3597         "vq".
3598
3599 2019-04-24  Tom Tromey  <tromey@adacore.com>
3600
3601         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3602
3603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3604
3605         * s12z-tdep.c (s12z_unwind_pc): Delete.
3606         (s12z_unwind_sp): Delete.
3607         (s12z_gdbarch_init): Don't register deleted functions with
3608         gdbarch.
3609
3610 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3611
3612         * rl78-tdep.c (rl78_unwind_sp): Delete.
3613         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3614
3615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3616
3617         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3618         (xstormy16_unwind_pc): Delete.
3619         (xstormy16_dummy_id): Delete.
3620         (xstormy16_gdbarch_init): Don't register deleted functions with
3621         gdbarch.
3622
3623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3624
3625         * vax-tdep.c (vax_unwind_pc): Delete.
3626         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3627
3628 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3629
3630         * v850-tdep.c (v850_unwind_sp): Delete.
3631         (v850_unwind_pc): Delete.
3632         (v850_dummy_id): Delete.
3633         (v850_gdbarch_init): Don't register deleted functions with
3634         gdbarch.
3635
3636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3637
3638         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3639         (tilegx_unwind_pc): Delete.
3640         (tilegx_unwind_dummy_id): Delete.
3641         (tilegx_gdbarch_init): Don't register deleted functions with
3642         gdbarch.
3643
3644 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3645
3646         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3647         (tic6x_dummy_id): Delete.
3648         (tic6x_gdbarch_init): Don't register deleted functions with
3649         gdbarch.
3650
3651 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3652
3653         * sparc-tdep.c (sparc_unwind_pc): Delete.
3654         (sparc32_gdbarch_init): Don't register deleted function with
3655         gdbarch.
3656
3657 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3658
3659         * sh-tdep.c (sh_unwind_sp): Delete.
3660         (sh_unwind_pc): Delete.
3661         (sh_dummy_id): Delete.
3662         (sh_gdbarch_init): Don't register deleted functions with
3663         gdbarch.
3664
3665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3666
3667         * score-tdep.c (score_unwind_sp): Delete.
3668         (score_unwind_pc): Delete.
3669         (score_dummy_id): Delete.
3670         (score_gdbarch_init): Don't register deleted functions with
3671         gdbarch.
3672
3673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3674
3675         * rx-tdep.c (rx_unwind_pc): Delete.
3676         (rx_unwind_sp): Delete.
3677         (rx_dummy_id): Delete.
3678         (rx_gdbarch_init): Don't register deleted functions with
3679         gdbarch.  Update comment.
3680
3681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3682
3683         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3684         (rs6000_dummy_id): Delete.
3685         (rs6000_gdbarch_init): Don't register deleted functions with
3686         gdbarch.
3687
3688 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3689
3690         * or1k-tdep.c (or1k_dummy_id): Delete.
3691         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3692
3693 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3694
3695         * nios2-tdep.c (nios2_dummy_id): Delete.
3696         (nios2_unwind_sp): Delete.
3697         (nios2_gdbarch_init): Don't register deleted functions with
3698         gdbarch.
3699
3700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3701
3702         * nds32-tdep.c (nds32_dummy_id): Delete.
3703         (nds32_unwind_pc): Delete.
3704         (nds32_unwind_sp): Delete.
3705         (nds32_gdbarch_init): Don't register deleted functions with
3706         gdbarch.
3707
3708 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3709
3710         * msp430-tdep.c (msp430_unwind_pc): Delete.
3711         (msp430_unwind_sp): Delete.
3712         (msp430_dummy_id): Delete.
3713         (msp430_gdbarch_init): Don't register deleted functions with
3714         gdbarch.
3715
3716 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3717
3718         * moxie-tdep.c (moxie_unwind_sp): Delete.
3719         (moxie_unwind_pc): Delete.
3720         (moxie_dummy_id): Delete.
3721         (moxie_gdbarch_init): Don't register deleted functions with
3722         gdbarch.
3723
3724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3725
3726         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3727         (mn10300_unwind_pc): Delete.
3728         (mn10300_unwind_sp): Delete.
3729         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3730         mn10300_unwind_sp.
3731         (mn10300_frame_unwind_init): Don't register deleted functions with
3732         gdbarch.
3733
3734 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3735
3736         * mep-tdep.c (mep_unwind_pc): Delete.
3737         (mep_unwind_sp): Delete.
3738         (mep_dummy_id): Delete.
3739         (mep_gdbarch_init): Don't register deleted functions with
3740         gdbarch.
3741
3742 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3743
3744         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3745         (m68hc11_unwind_sp): Delete.
3746         (m68hc11_gdbarch_init): Don't register deleted functions with
3747         gdbarch.
3748
3749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3750
3751         * m32r-tdep.c (m32r_unwind_sp): Delete.
3752         (m32r_unwind_pc): Delete.
3753         (m32r_dummy_id): Delete.
3754         (m32r_gdbarch_init): Don't register deleted functions with
3755         gdbarch.
3756
3757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         * m32c-tdep.c (m32c_unwind_pc): Delete.
3760         (m32c_unwind_sp): Delete.
3761         (m32c_dummy_id): Delete.
3762         (m32c_gdbarch_init): Don't register deleted functions with
3763         gdbarch.
3764
3765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3766
3767         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3768         (lm32_unwind_pc): Delete.
3769         (lm32_dummy_id): Delete.
3770         (lm32_gdbarch_init): Don't register deleted functions with
3771         gdbarch.
3772
3773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3774
3775         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3776         (iq2000_unwind_pc): Delete.
3777         (iq2000_dummy_id): Delete.
3778         (iq2000_gdbarch_init): Don't register deleted functions with
3779         gdbarch.
3780
3781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3782
3783         * nds32-tdep.c (nds32_type_align): Delete.
3784         (nds32_push_dummy_call): Use type_align instead.
3785
3786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3787
3788         * arm-tdep.c (arm_type_align): Only handle vector override case.
3789         (arm_push_dummy_call): Use type_align.
3790         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3791
3792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3793
3794         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3795         case.
3796         (pass_on_stack): Use type_align.
3797         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3798         function.
3799
3800 2019-04-23  Tom Tromey  <tromey@adacore.com>
3801
3802         * dwarf2read.c (line_header::file_name_at): Remove unused
3803         overload.
3804
3805 2019-04-23  Tom de Vries  <tdevries@suse.de>
3806
3807         PR gdb/24438
3808         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3809         invocation.
3810
3811
3812 2019-03-27  Ali Tamur  <tamur@google.com>
3813
3814         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3815         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3816         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3817         (dwarf_expr_context::get_addr_index): Likewise
3818         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3819         (symbol_needs_eval_context::get_addr_index): Likewise
3820         (disassemble_dwarf_expression): Add DW_OP_addrx
3821         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3822         (read_cutu_die_from_dwo): Update comment
3823         (skip_one_die): Add DW_FORM_addrx
3824         (read_attribute_value): Likewise
3825         (var_decode_location): Add DW_OP_addrx
3826         (dwarf2_const_value_attr): Add DW_FORM_addrx
3827         (dump_die_shallow): Likewise
3828         (dwarf2_fetch_constant_bytes): Likewise
3829         (decode_locdesc): Add DW_OP_addrx
3830         (skip_form_bytes): Add DW_FORM_addrx
3831
3832 2019-04-22  Ali Tamur  <tamur@google.com>
3833
3834         * MAINTAINERS (Write After Approval): Add self.
3835
3836 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3837
3838         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3839         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3840         (open_symbol_file_object): Likewise.
3841         (svr4_default_sos): Add info parameter.
3842         (svr4_read_so_list): Likewise.
3843         (svr4_current_sos_direct): Adjust functions calls to pass down
3844         info.
3845         (svr4_current_sos_1): Add info parameter.
3846         (svr4_current_sos): Call get_svr4_info, pass info down to
3847         svr4_current_sos_1.
3848         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3849         get_svr4_info.
3850         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3851         get_svr4_info.
3852         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3853         to get_svr4_info.
3854         (probes_table_remove_objfile_probes): Likewise.
3855         (register_solib_event_probe): Add info parameter.
3856         (solist_update_incremental): Pass info parameter down to
3857         svr4_read_so_list.
3858         (disable_probes_interface): Add info parameter.
3859         (svr4_handle_solib_event): Pass current_program_space to
3860         get_svr4_info.  Adjust disable_probes_interface cleanup.
3861         (svr4_create_probe_breakpoints): Add info parameter, pass it
3862         down to register_solib_event_probe.
3863         (svr4_create_solib_event_breakpoints): Add info parameter,
3864         pass it down to svr4_create_probe_breakpoints.
3865         (enable_break): Pass info down to
3866         svr4_create_solib_event_breakpoints.
3867         (svr4_solib_create_inferior_hook): Pass current_program_space to
3868         get_svr4_info.
3869         (svr4_clear_solib): Likewise.
3870
3871 2019-04-22  Pedro Alves  <palves@redhat.com>
3872
3873         * solib-svr4.c (svr4_free_objfile_observer): New.
3874         (probe_and_action::objfile): New field.
3875         (probes_table_htab_remove_objfile_probes)
3876         (probes_table_remove_objfile_probes): New functions.
3877         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3878         in the new probe_and_action.  Don't store the probe in 'lookup'.
3879         (svr4_create_probe_breakpoints): Pass objfile to
3880         register_solib_event_probe.
3881         (_initialize_svr4_solib): Register a free_objfile observer.
3882
3883 2019-04-19  Tom Tromey  <tom@tromey.com>
3884
3885         * common/queue.h: Remove.
3886
3887 2019-04-19  Tom Tromey  <tom@tromey.com>
3888
3889         * event-loop.c: Don't include "common/queue.h".
3890
3891 2019-04-19  Tom Tromey  <tom@tromey.com>
3892
3893         * remote.c (remote_target): Use delete.
3894         * remote-notif.h: Include <list>, not "common/queue.h".
3895         (notif_client_p): Remove typedef.
3896         (remote_notif_state): Add constructor, destructor, initializer.
3897         <notif_queue>: Now a std::list.
3898         (remote_notif_state_xfree): Don't declare.
3899         * remote-notif.c (remote_notif_process, handle_notification)
3900         (remote_notif_state_allocate): Update.
3901         (~remote_notif_state): Rename from remote_notif_state_xfree.
3902
3903 2019-04-19  Tom Tromey  <tom@tromey.com>
3904
3905         * symfile.c (reread_symbols): Update.
3906         * objfiles.c (objfile_register_static_link)
3907         (objfile_lookup_static_link): Update
3908         (~objfile) Don't delete static_links.
3909         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3910
3911 2019-04-19  Tom Tromey  <tom@tromey.com>
3912
3913         * type-stack.h (struct type_stack) <insert>: Constify string.
3914         * type-stack.c (type_stack::insert): Constify string.
3915         * gdbtypes.h (lookup_template_type): Update.
3916         (address_space_name_to_int): Update.
3917         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3918         const.
3919         (lookup_template_type): Make name const.
3920         * c-exp.y: Update rules.
3921         (lex_one_token, classify_name, classify_inner_name)
3922         (c_print_token): Update.
3923         * p-exp.y: Update rules.
3924         (yylex): Update.
3925         * f-exp.y: Update rules.
3926         (yylex): Update.
3927         * d-exp.y: Update rules.
3928         (lex_one_token, classify_name, classify_inner_name): Update.
3929         * parse.c (write_dollar_variable, copy_name): Return std::string.
3930         * parser-defs.h (copy_name): Change return type.
3931         * m2-exp.y: Update rules.
3932         (yylex): Update.
3933         * go-exp.y (lex_one_token): Update.
3934         Update rules.
3935         (classify_unsafe_function, classify_packaged_name)
3936         (classify_name, yylex): Update.
3937
3938 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3939
3940         * configure.ac: add --enable-source-highlight switch.
3941         * configure: Regenerate.
3942         * top.c (print_gdb_version): plumb --enable-source-highlight
3943         status to "show configuration".
3944
3945 2019-04-19  Tom Tromey  <tromey@adacore.com>
3946
3947         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3948         Check ADA_TYPE_P.
3949         (empty_record, ada_template_to_fixed_record_type_1)
3950         (template_to_static_fixed_type)
3951         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3952         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3953         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3954         macros.
3955
3956 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3957
3958         PR symtab/24423:
3959         * source.c (print_source_lines_base): Advance "iter" when a
3960         control character is seen.
3961
3962 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3963
3964         * inferior.h (struct infcall_suspend_state_deleter):
3965         Catch exception in destructor to avoid crash.
3966
3967 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3968
3969         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3970         close to the add_com "shell".
3971
3972 2019-04-18  Tom Tromey  <tromey@adacore.com>
3973
3974         * process-stratum-target.h (class process_stratum_target)
3975         <stratum>: Add "final".
3976
3977 2019-04-17  Tom Tromey  <tromey@adacore.com>
3978
3979         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3980         against nullptr before use.
3981
3982 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3983
3984         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3985
3986 2019-04-17  Jim Wilson  <jimw@sifive.com>
3987             Andrew Burgess  <andrew.burgess@embecosm.com>
3988
3989         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3990         code read might fail, assume 4-byte breakpoint in that case.
3991
3992 2019-04-15  Leszek Swirski  <leszeks@google.com>
3993
3994         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3995         rather than a hand-rolled POD check when checking for forced MEMORY
3996         classification.
3997
3998 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3999
4000         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4001         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4002         function.
4003         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4004         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4005         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4006         declaration.
4007
4008 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4009
4010         * aarch64-linux-nat.c
4011         (aarch64_linux_nat_target::thread_architecture): Add override.
4012         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4013         each VQ.
4014
4015 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4016
4017         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4018
4019 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4020
4021         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4022         target types of size 96-bits, add some additional comments, and
4023         check that the builtin type we found was the correct size.
4024
4025 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4026
4027         * utils.c (prompt_for_continue): Don't restore the styling at the
4028         end, as applied_style has the wrong value.  This fixes styling in
4029         long lists of file names that are interrupted by the "Continue?"
4030         prompt.
4031
4032 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4033
4034         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4035         * c-lang.c (c_language_defn): Likewise.
4036         (cplus_language_defn): Likewise.
4037         (asm_language_defn): Likewise.
4038         (minimal_language_defn): Likewise.
4039         * d-lang.c (d_language_defn): Likewise.
4040         * f-lang.c (f_language_defn): Likewise.
4041         * go-lang.c (go_language_defn): Likewise.
4042         * language.c (unknown_language_defn): Likewise.
4043         (auto_language_defn): Likewise.
4044         * language.h (struct language_defn): Remove la_magic field.
4045         (LANG_MAGIC): Delete.
4046         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4047         * objc-lang.c (objc_language_defn): Likewise.
4048         * opencl-lang.c (opencl_language_defn): Likewise.
4049         * p-lang.c (pascal_language_defn): Likewise.
4050         * rust-lang.c (rust_language_defn): Likewise.
4051
4052 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4053
4054         * riscv-tdep.c (riscv_type_align): New function.
4055         (riscv_type_alignment): Delete.
4056         (riscv_arg_location): Use 'type_align'.
4057         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4058
4059 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4060
4061         * gdbtypes.c (type_align): A struct with no non-static fields also
4062         has alignment of 1.
4063
4064 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4065
4066         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4067         component to 0.
4068         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4069         member.
4070         (riscv_struct_info::analyse): New implementation using new
4071         analyse_inner member function.
4072         (riscv_struct_info::field_offset): New member function.
4073         (riscv_struct_info::m_offsets): New member variable.
4074         (riscv_struct_info::analyse_inner): New private member function,
4075         takes the old implementation of riscv_struct_info::analyse but
4076         extended to track field offsets.
4077         (riscv_call_arg_struct): Update the struct folding special cases
4078         to handle cases where empty C++ structs, which are non-zero
4079         length, are found.
4080         (riscv_arg_location): Initialise the length of each location, a
4081         non-zero length now indicates the location is in use.
4082         (riscv_push_dummy_call): Allow for the first location having a
4083         non-zero offset when setting up arguments.
4084         (riscv_return_value): Likewise, but for return values.
4085
4086 2019-04-11  Tom Tromey  <tromey@adacore.com>
4087
4088         * utils.c (internal_vproblem): Make "msg" const.
4089
4090 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4091
4092         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4093         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4094         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4095         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4096
4097 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4098
4099         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4100         function.
4101         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4102         of amd64_collect_native_gregset.
4103         (amd64_linux_nat_target::store_registers): Likewise.
4104
4105 2019-04-10  Tom Tromey  <tom@tromey.com>
4106
4107         * symtab.c (lookup_global_symbol_from_objfile)
4108         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4109         * objfiles.h (class separate_debug_iterator): New.
4110         (class separate_debug_range): New.
4111         (struct objfile) <separate_debug_objfiles>: New method.
4112         (objfile_separate_debug_iterate): Don't declare.
4113         * objfiles.c (separate_debug_iterator::operator++): Rename from
4114         objfile_separate_debug_iterate.
4115         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4116         iterator.
4117         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4118         iterator.
4119
4120 2019-04-10  Tom Tromey  <tom@tromey.com>
4121
4122         * symfile.c (reread_symbols): Remove old comment.
4123         * objfiles.c (free_all_objfiles): Fix a typo.
4124
4125 2019-04-10  Tom Tromey  <tom@tromey.com>
4126
4127         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4128         * minsyms.c (lookup_minimal_symbol): Use foreach.
4129         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4130         (lookup_minimal_symbol_solib_trampoline): Likewise.
4131         * symfile.c (reread_symbols): Use foreach.
4132
4133 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4134             Tom Tromey  <tromey@adacore.com>
4135
4136         PR rust/24414:
4137         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4138         (rust_lex_int_test): Change "value" to be LONGEST.
4139         (rust_lex_tests): Add test for long integer literal.
4140
4141 2019-04-09  Tom Tromey  <tromey@adacore.com>
4142
4143         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4144         to bool.
4145         (extended_remote_target::attach): Update.
4146         (remote_target::remote_notice_new_inferior): Update.
4147         (remote_target::add_current_inferior_and_thread): Update.
4148         * inferior.c (exit_inferior_1): Use "false".
4149         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4150
4151 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4152
4153         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4154         the "start" command.
4155
4156 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4157
4158         * python/py-inferior.c (infpy_thread_from_thread_handle):
4159         Adjust comments to reflect renaming of thread_from_thread_handle
4160         to thread_from_handle.  Adjust keywords.  Fix type error message.
4161         (inferior_object_methods): Add thread_from_handle.  Retain
4162         thread_from_thread_handle, but mark it as deprecated.
4163
4164 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4165
4166         * gdbthread.h (find_thread_by_handle): Revise declaration.
4167         * thread.c (find_thread_by_handle): Likewise.  Adjust
4168         implementation too.
4169         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4170         support for buffer objects as handles.
4171
4172 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4173
4174         * python/py-infthread.c (thpy_thread_handle): New function.
4175         (thread_object_methods): Register thpy_thread_handle.
4176
4177 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4178
4179         * gdbthread.h (thread_to_thread_handle): Declare.
4180         * thread.c (gdbtypes.h): Include.
4181         (thread_to_thread_handle): New function.
4182
4183         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4184         (target_thread_info_to_thread_handle): Declare.
4185         * target.c (target_thread_info_to_thread_handle): New function.
4186         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4187         * target-delegates.c: Regenerate.
4188
4189         * linux-thread-db.c (class thread_db_target): Add method
4190         thread_info_to_thread_handle.
4191         (thread_db_target::thread_info_to_thread_handle): Define.
4192         * remote.c (class remote_target): Add new method
4193         thread_info_to_thread_handle.
4194         (remote_target::thread_info_to_thread_handle): Define.
4195
4196 2019-04-08  Pedro Alves  <palves@redhat.com>
4197
4198         * common/common-exceptions.c (throw_exception): Don't create
4199         named object to throw; throw directly.
4200         (throw_it): Likewise.  Don't initialize gdb_exception::message
4201         here, with new; pass FMT and AP to the ctor instead.
4202         * common/common-exceptions.h: Include <string>.
4203         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4204         const char *, va_list)): New ctor.  Use std::make_shared.
4205         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4206         errors)): Delete.
4207         (gdb_exception_error::gdb_exception_error(enum errors, const char
4208         *, va_list)): New.
4209         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4210         Add assertion.
4211         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4212         errors)): Delete.
4213         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4214         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4215         Add assertion.
4216
4217 2019-04-08  Tom Tromey  <tom@tromey.com>
4218
4219         * valops.c (value_rtti_indirect_type): Replace throw_exception
4220         with throw.
4221         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4222         with throw.
4223         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4224         throw.
4225         * target.c (target_translate_tls_address): Replace throw_exception
4226         with throw.
4227         * stack.c (frame_apply_command_count): Replace throw_exception
4228         with throw.
4229         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4230         throw.
4231         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4232         with throw.
4233         * rs6000-tdep.c (rs6000_frame_cache)
4234         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4235         * remote.c: Replace throw_exception with throw.
4236         * record-full.c (record_full_message, record_full_wait_1)
4237         (record_full_restore): Replace throw_exception with throw.
4238         * record-btrace.c:
4239         (get_thread_current_frame_id, record_btrace_start_replaying)
4240         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4241         (cmd_record_btrace_start): Replace throw_exception with throw.
4242         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4243         throw.
4244         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4245         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4246         * linespec.c:
4247         (find_linespec_symbols): Replace throw_exception with throw.
4248         * infrun.c (displaced_step_prepare, resume): Replace
4249         throw_exception with throw.
4250         * infcmd.c (post_create_inferior): Replace throw_exception with
4251         throw.
4252         * inf-loop.c (inferior_event_handler): Replace throw_exception
4253         with throw.
4254         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4255         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4256         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4257         (get_prev_frame_always, get_frame_pc_if_available)
4258         (get_frame_address_in_block_if_available, get_frame_language):
4259         Replace throw_exception with throw.
4260         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4261         throw_exception with throw.
4262         * eval.c (fetch_subexp_value, evaluate_var_value)
4263         (evaluate_funcall, evaluate_subexp_standard): Replace
4264         throw_exception with throw.
4265         * dwarf2loc.c (call_site_find_chain)
4266         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4267         Replace throw_exception with throw.
4268         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4269         with throw.
4270         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4271         throw.
4272         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4273         * completer.c (complete_line_internal): Replace throw_exception
4274         with throw.
4275         * compile/compile-object-run.c (compile_object_run): Replace
4276         throw_exception with throw.
4277         * cli/cli-script.c (process_next_line): Replace throw_exception
4278         with throw.
4279         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4280         (btrace_enable, btrace_maint_update_pt_packets): Replace
4281         throw_exception with throw.
4282         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4283         throw_exception with throw.
4284         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4285         throw_exception with throw.
4286         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4287         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4288         * aarch64-tdep.c (aarch64_make_prologue_cache)
4289         (aarch64_make_stub_cache): Replace throw_exception with throw.
4290
4291 2019-04-08  Tom Tromey  <tom@tromey.com>
4292
4293         * common/common-exceptions.c (throw_exception): Rename from
4294         throw_exception_cxx.  Remove old copy.  Make argument const.
4295         (throw_it): Create and throw exception objects directly.
4296         * common/common-exceptions.h (throw_exception): Make argument
4297         const.
4298         (struct gdb_exception_error): Add constructor.
4299         (struct gdb_exception_quit): Add constructor.
4300
4301 2019-04-08  Tom Tromey  <tom@tromey.com>
4302
4303         * common/common-exceptions.h (exception_rethrow): Don't declare.
4304         (TRY_SJLJ): Update comment.
4305         (TRY, CATCH, END_CATCH): Remove.
4306         * common/common-exceptions.c (exception_rethrow): Remove.
4307
4308 2019-04-08  Tom Tromey  <tom@tromey.com>
4309
4310         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4311         Remove.
4312         (gdb_exception_error): Rename from
4313         gdb_exception_RETURN_MASK_ERROR.
4314         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4315         (gdb_quit_bad_alloc): Update.
4316         * aarch64-tdep.c: Update.
4317         * ada-lang.c: Update.
4318         * ada-typeprint.c: Update.
4319         * ada-valprint.c: Update.
4320         * amd64-tdep.c: Update.
4321         * arch-utils.c: Update.
4322         * break-catch-throw.c: Update.
4323         * breakpoint.c: Update.
4324         * btrace.c: Update.
4325         * c-varobj.c: Update.
4326         * cli/cli-cmds.c: Update.
4327         * cli/cli-interp.c: Update.
4328         * cli/cli-script.c: Update.
4329         * common/common-exceptions.c: Update.
4330         * common/new-op.c: Update.
4331         * common/selftest.c: Update.
4332         * compile/compile-c-symbols.c: Update.
4333         * compile/compile-cplus-symbols.c: Update.
4334         * compile/compile-object-load.c: Update.
4335         * compile/compile-object-run.c: Update.
4336         * completer.c: Update.
4337         * corelow.c: Update.
4338         * cp-abi.c: Update.
4339         * cp-support.c: Update.
4340         * cp-valprint.c: Update.
4341         * darwin-nat.c: Update.
4342         * disasm-selftests.c: Update.
4343         * dtrace-probe.c: Update.
4344         * dwarf-index-cache.c: Update.
4345         * dwarf-index-write.c: Update.
4346         * dwarf2-frame-tailcall.c: Update.
4347         * dwarf2-frame.c: Update.
4348         * dwarf2loc.c: Update.
4349         * dwarf2read.c: Update.
4350         * eval.c: Update.
4351         * event-loop.c: Update.
4352         * event-top.c: Update.
4353         * exec.c: Update.
4354         * f-valprint.c: Update.
4355         * fbsd-tdep.c: Update.
4356         * frame-unwind.c: Update.
4357         * frame.c: Update.
4358         * gdbtypes.c: Update.
4359         * gnu-v3-abi.c: Update.
4360         * guile/guile-internal.h: Update.
4361         * guile/scm-block.c: Update.
4362         * guile/scm-breakpoint.c: Update.
4363         * guile/scm-cmd.c: Update.
4364         * guile/scm-disasm.c: Update.
4365         * guile/scm-frame.c: Update.
4366         * guile/scm-lazy-string.c: Update.
4367         * guile/scm-math.c: Update.
4368         * guile/scm-param.c: Update.
4369         * guile/scm-ports.c: Update.
4370         * guile/scm-pretty-print.c: Update.
4371         * guile/scm-symbol.c: Update.
4372         * guile/scm-symtab.c: Update.
4373         * guile/scm-type.c: Update.
4374         * guile/scm-value.c: Update.
4375         * i386-linux-tdep.c: Update.
4376         * i386-tdep.c: Update.
4377         * inf-loop.c: Update.
4378         * infcall.c: Update.
4379         * infcmd.c: Update.
4380         * infrun.c: Update.
4381         * jit.c: Update.
4382         * language.c: Update.
4383         * linespec.c: Update.
4384         * linux-fork.c: Update.
4385         * linux-nat.c: Update.
4386         * linux-tdep.c: Update.
4387         * linux-thread-db.c: Update.
4388         * main.c: Update.
4389         * mi/mi-cmd-break.c: Update.
4390         * mi/mi-cmd-stack.c: Update.
4391         * mi/mi-interp.c: Update.
4392         * mi/mi-main.c: Update.
4393         * objc-lang.c: Update.
4394         * p-valprint.c: Update.
4395         * parse.c: Update.
4396         * ppc-linux-tdep.c: Update.
4397         * printcmd.c: Update.
4398         * python/py-arch.c: Update.
4399         * python/py-breakpoint.c: Update.
4400         * python/py-cmd.c: Update.
4401         * python/py-finishbreakpoint.c: Update.
4402         * python/py-frame.c: Update.
4403         * python/py-framefilter.c: Update.
4404         * python/py-gdb-readline.c: Update.
4405         * python/py-inferior.c: Update.
4406         * python/py-infthread.c: Update.
4407         * python/py-lazy-string.c: Update.
4408         * python/py-linetable.c: Update.
4409         * python/py-objfile.c: Update.
4410         * python/py-param.c: Update.
4411         * python/py-prettyprint.c: Update.
4412         * python/py-progspace.c: Update.
4413         * python/py-record-btrace.c: Update.
4414         * python/py-record.c: Update.
4415         * python/py-symbol.c: Update.
4416         * python/py-type.c: Update.
4417         * python/py-unwind.c: Update.
4418         * python/py-utils.c: Update.
4419         * python/py-value.c: Update.
4420         * python/python.c: Update.
4421         * record-btrace.c: Update.
4422         * record-full.c: Update.
4423         * remote-fileio.c: Update.
4424         * remote.c: Update.
4425         * riscv-tdep.c: Update.
4426         * rs6000-aix-tdep.c: Update.
4427         * rs6000-tdep.c: Update.
4428         * rust-exp.y: Update.
4429         * rust-lang.c: Update.
4430         * s390-tdep.c: Update.
4431         * selftest-arch.c: Update.
4432         * solib-dsbt.c: Update.
4433         * solib-frv.c: Update.
4434         * solib-spu.c: Update.
4435         * solib-svr4.c: Update.
4436         * solib.c: Update.
4437         * sparc64-linux-tdep.c: Update.
4438         * stack.c: Update.
4439         * symfile-mem.c: Update.
4440         * symmisc.c: Update.
4441         * target.c: Update.
4442         * thread.c: Update.
4443         * top.c: Update.
4444         * tracefile-tfile.c: Update.
4445         * tui/tui.c: Update.
4446         * typeprint.c: Update.
4447         * unittests/cli-utils-selftests.c: Update.
4448         * unittests/parse-connection-spec-selftests.c: Update.
4449         * valops.c: Update.
4450         * valprint.c: Update.
4451         * value.c: Update.
4452         * varobj.c: Update.
4453         * windows-nat.c: Update.
4454         * x86-linux-nat.c: Update.
4455         * xml-support.c: Update.
4456
4457 2019-04-08  Tom Tromey  <tom@tromey.com>
4458
4459         * xml-support.c: Use C++ exception handling.
4460         * x86-linux-nat.c: Use C++ exception handling.
4461         * windows-nat.c: Use C++ exception handling.
4462         * varobj.c: Use C++ exception handling.
4463         * value.c: Use C++ exception handling.
4464         * valprint.c: Use C++ exception handling.
4465         * valops.c: Use C++ exception handling.
4466         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4467         handling.
4468         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4469         * typeprint.c: Use C++ exception handling.
4470         * tui/tui.c: Use C++ exception handling.
4471         * tracefile-tfile.c: Use C++ exception handling.
4472         * top.c: Use C++ exception handling.
4473         * thread.c: Use C++ exception handling.
4474         * target.c: Use C++ exception handling.
4475         * symmisc.c: Use C++ exception handling.
4476         * symfile-mem.c: Use C++ exception handling.
4477         * stack.c: Use C++ exception handling.
4478         * sparc64-linux-tdep.c: Use C++ exception handling.
4479         * solib.c: Use C++ exception handling.
4480         * solib-svr4.c: Use C++ exception handling.
4481         * solib-spu.c: Use C++ exception handling.
4482         * solib-frv.c: Use C++ exception handling.
4483         * solib-dsbt.c: Use C++ exception handling.
4484         * selftest-arch.c: Use C++ exception handling.
4485         * s390-tdep.c: Use C++ exception handling.
4486         * rust-lang.c: Use C++ exception handling.
4487         * rust-exp.y: Use C++ exception handling.
4488         * rs6000-tdep.c: Use C++ exception handling.
4489         * rs6000-aix-tdep.c: Use C++ exception handling.
4490         * riscv-tdep.c: Use C++ exception handling.
4491         * remote.c: Use C++ exception handling.
4492         * remote-fileio.c: Use C++ exception handling.
4493         * record-full.c: Use C++ exception handling.
4494         * record-btrace.c: Use C++ exception handling.
4495         * python/python.c: Use C++ exception handling.
4496         * python/py-value.c: Use C++ exception handling.
4497         * python/py-utils.c: Use C++ exception handling.
4498         * python/py-unwind.c: Use C++ exception handling.
4499         * python/py-type.c: Use C++ exception handling.
4500         * python/py-symbol.c: Use C++ exception handling.
4501         * python/py-record.c: Use C++ exception handling.
4502         * python/py-record-btrace.c: Use C++ exception handling.
4503         * python/py-progspace.c: Use C++ exception handling.
4504         * python/py-prettyprint.c: Use C++ exception handling.
4505         * python/py-param.c: Use C++ exception handling.
4506         * python/py-objfile.c: Use C++ exception handling.
4507         * python/py-linetable.c: Use C++ exception handling.
4508         * python/py-lazy-string.c: Use C++ exception handling.
4509         * python/py-infthread.c: Use C++ exception handling.
4510         * python/py-inferior.c: Use C++ exception handling.
4511         * python/py-gdb-readline.c: Use C++ exception handling.
4512         * python/py-framefilter.c: Use C++ exception handling.
4513         * python/py-frame.c: Use C++ exception handling.
4514         * python/py-finishbreakpoint.c: Use C++ exception handling.
4515         * python/py-cmd.c: Use C++ exception handling.
4516         * python/py-breakpoint.c: Use C++ exception handling.
4517         * python/py-arch.c: Use C++ exception handling.
4518         * printcmd.c: Use C++ exception handling.
4519         * ppc-linux-tdep.c: Use C++ exception handling.
4520         * parse.c: Use C++ exception handling.
4521         * p-valprint.c: Use C++ exception handling.
4522         * objc-lang.c: Use C++ exception handling.
4523         * mi/mi-main.c: Use C++ exception handling.
4524         * mi/mi-interp.c: Use C++ exception handling.
4525         * mi/mi-cmd-stack.c: Use C++ exception handling.
4526         * mi/mi-cmd-break.c: Use C++ exception handling.
4527         * main.c: Use C++ exception handling.
4528         * linux-thread-db.c: Use C++ exception handling.
4529         * linux-tdep.c: Use C++ exception handling.
4530         * linux-nat.c: Use C++ exception handling.
4531         * linux-fork.c: Use C++ exception handling.
4532         * linespec.c: Use C++ exception handling.
4533         * language.c: Use C++ exception handling.
4534         * jit.c: Use C++ exception handling.
4535         * infrun.c: Use C++ exception handling.
4536         * infcmd.c: Use C++ exception handling.
4537         * infcall.c: Use C++ exception handling.
4538         * inf-loop.c: Use C++ exception handling.
4539         * i386-tdep.c: Use C++ exception handling.
4540         * i386-linux-tdep.c: Use C++ exception handling.
4541         * guile/scm-value.c: Use C++ exception handling.
4542         * guile/scm-type.c: Use C++ exception handling.
4543         * guile/scm-symtab.c: Use C++ exception handling.
4544         * guile/scm-symbol.c: Use C++ exception handling.
4545         * guile/scm-pretty-print.c: Use C++ exception handling.
4546         * guile/scm-ports.c: Use C++ exception handling.
4547         * guile/scm-param.c: Use C++ exception handling.
4548         * guile/scm-math.c: Use C++ exception handling.
4549         * guile/scm-lazy-string.c: Use C++ exception handling.
4550         * guile/scm-frame.c: Use C++ exception handling.
4551         * guile/scm-disasm.c: Use C++ exception handling.
4552         * guile/scm-cmd.c: Use C++ exception handling.
4553         * guile/scm-breakpoint.c: Use C++ exception handling.
4554         * guile/scm-block.c: Use C++ exception handling.
4555         * guile/guile-internal.h: Use C++ exception handling.
4556         * gnu-v3-abi.c: Use C++ exception handling.
4557         * gdbtypes.c: Use C++ exception handling.
4558         * frame.c: Use C++ exception handling.
4559         * frame-unwind.c: Use C++ exception handling.
4560         * fbsd-tdep.c: Use C++ exception handling.
4561         * f-valprint.c: Use C++ exception handling.
4562         * exec.c: Use C++ exception handling.
4563         * event-top.c: Use C++ exception handling.
4564         * event-loop.c: Use C++ exception handling.
4565         * eval.c: Use C++ exception handling.
4566         * dwarf2read.c: Use C++ exception handling.
4567         * dwarf2loc.c: Use C++ exception handling.
4568         * dwarf2-frame.c: Use C++ exception handling.
4569         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4570         * dwarf-index-write.c: Use C++ exception handling.
4571         * dwarf-index-cache.c: Use C++ exception handling.
4572         * dtrace-probe.c: Use C++ exception handling.
4573         * disasm-selftests.c: Use C++ exception handling.
4574         * darwin-nat.c: Use C++ exception handling.
4575         * cp-valprint.c: Use C++ exception handling.
4576         * cp-support.c: Use C++ exception handling.
4577         * cp-abi.c: Use C++ exception handling.
4578         * corelow.c: Use C++ exception handling.
4579         * completer.c: Use C++ exception handling.
4580         * compile/compile-object-run.c: Use C++ exception handling.
4581         * compile/compile-object-load.c: Use C++ exception handling.
4582         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4583         * compile/compile-c-symbols.c: Use C++ exception handling.
4584         * common/selftest.c: Use C++ exception handling.
4585         * common/new-op.c: Use C++ exception handling.
4586         * cli/cli-script.c: Use C++ exception handling.
4587         * cli/cli-interp.c: Use C++ exception handling.
4588         * cli/cli-cmds.c: Use C++ exception handling.
4589         * c-varobj.c: Use C++ exception handling.
4590         * btrace.c: Use C++ exception handling.
4591         * breakpoint.c: Use C++ exception handling.
4592         * break-catch-throw.c: Use C++ exception handling.
4593         * arch-utils.c: Use C++ exception handling.
4594         * amd64-tdep.c: Use C++ exception handling.
4595         * ada-valprint.c: Use C++ exception handling.
4596         * ada-typeprint.c: Use C++ exception handling.
4597         * ada-lang.c: Use C++ exception handling.
4598         * aarch64-tdep.c: Use C++ exception handling.
4599
4600 2019-04-08  Tom Tromey  <tom@tromey.com>
4601
4602         * xml-support.c (gdb_xml_parser::parse): Update.
4603         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4604         * value.c (show_convenience): Update.
4605         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4606         (test_parse_flags_qcs): Update.
4607         * thread.c (thr_try_catch_cmd): Update.
4608         * target.c (target_translate_tls_address): Update.
4609         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4610         (info_frame_command_core, frame_apply_command_count): Update.
4611         * rust-exp.y (rust_lex_exception_test): Update.
4612         * riscv-tdep.c (riscv_print_one_register_info): Update.
4613         * remote.c (remote_target::enable_btrace): Update.
4614         * record-btrace.c (record_btrace_enable_warn): Update.
4615         * python/py-utils.c (gdbpy_convert_exception): Update.
4616         * printcmd.c (do_one_display, print_variable_and_value): Update.
4617         * mi/mi-main.c (mi_print_exception): Update.
4618         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4619         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4620         * linux-nat.c (linux_nat_target::attach): Update.
4621         * linux-fork.c (class scoped_switch_fork_info): Update.
4622         * infrun.c (displaced_step_prepare): Update.
4623         * infcall.c (call_function_by_hand_dummy): Update.
4624         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4625         * gnu-v3-abi.c (print_one_vtable): Update.
4626         * frame.c (get_prev_frame_always): Update.
4627         * f-valprint.c (info_common_command_for_block): Update.
4628         * exec.c (try_open_exec_file): Update.
4629         * exceptions.c (print_exception, exception_print)
4630         (exception_fprintf, exception_print_same): Update.
4631         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4632         * dwarf-index-cache.c (index_cache::store)
4633         (index_cache::lookup_gdb_index): Update.
4634         * darwin-nat.c (maybe_cache_shell): Update.
4635         * cp-valprint.c (cp_print_value_fields): Update.
4636         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4637         (gcc_cplus_symbol_address): Update.
4638         * compile/compile-c-symbols.c (gcc_convert_symbol)
4639         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4640         * common/selftest.c: Update.
4641         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4642         a std::string.
4643         (exception_try_scope_entry, exception_try_scope_exit): Don't
4644         declare.
4645         (struct exception_try_scope): Remove.
4646         (TRY): Don't use exception_try_scope.
4647         (struct gdb_exception): Add constructor, operator=.
4648         <what>: New method.
4649         (struct gdb_exception_RETURN_MASK_ALL)
4650         (struct gdb_exception_RETURN_MASK_ERROR)
4651         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4652         (struct gdb_quit_bad_alloc): Update.
4653         * common/common-exceptions.c (exception_none): Change
4654         initializer.
4655         (struct catcher) <state, exception>: Initialize inline.
4656         <prev>: Remove member.
4657         (current_catcher): Remove.
4658         (catchers): New global.
4659         (exceptions_state_mc_init): Simplify.
4660         (catcher_pop): Remove.
4661         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4662         (try_scope_depth, exception_try_scope_entry)
4663         (exception_try_scope_exit): Remove.
4664         (throw_exception_sjlj): Update.
4665         (exception_messages, exception_messages_size): Remove.
4666         (throw_it): Simplify.
4667         (gdb_exception_sliced_copy): Remove.
4668         (throw_exception_cxx): Update.
4669         * cli/cli-script.c (script_from_file): Update.
4670         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4671         Update.
4672         * ada-valprint.c (ada_val_print): Update.
4673         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4674         (create_excep_cond_exprs): Update.
4675
4676 2019-04-08  Tom Tromey  <tom@tromey.com>
4677
4678         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4679         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4680         (TRY, CATCH, END_CATCH): Remove some definitions.
4681         * common/common-exceptions.c: Don't use GDB_XCPT.
4682         (catcher_list_size): Remove.
4683         (throw_exception, throw_it): Simplify.
4684
4685 2019-04-05  Tom Tromey  <tom@tromey.com>
4686
4687         Revert the header-sorting patch.
4688         * ft32-tdep.c: Revert.
4689         * frv-tdep.c: Revert.
4690         * frv-linux-tdep.c: Revert.
4691         * frame.c: Revert.
4692         * frame-unwind.c: Revert.
4693         * frame-base.c: Revert.
4694         * fork-child.c: Revert.
4695         * findvar.c: Revert.
4696         * findcmd.c: Revert.
4697         * filesystem.c: Revert.
4698         * filename-seen-cache.h: Revert.
4699         * filename-seen-cache.c: Revert.
4700         * fbsd-tdep.c: Revert.
4701         * fbsd-nat.h: Revert.
4702         * fbsd-nat.c: Revert.
4703         * f-valprint.c: Revert.
4704         * f-typeprint.c: Revert.
4705         * f-lang.c: Revert.
4706         * extension.h: Revert.
4707         * extension.c: Revert.
4708         * extension-priv.h: Revert.
4709         * expprint.c: Revert.
4710         * exec.h: Revert.
4711         * exec.c: Revert.
4712         * exceptions.c: Revert.
4713         * event-top.c: Revert.
4714         * event-loop.c: Revert.
4715         * eval.c: Revert.
4716         * elfread.c: Revert.
4717         * dwarf2read.h: Revert.
4718         * dwarf2read.c: Revert.
4719         * dwarf2loc.c: Revert.
4720         * dwarf2expr.h: Revert.
4721         * dwarf2expr.c: Revert.
4722         * dwarf2-frame.c: Revert.
4723         * dwarf2-frame-tailcall.c: Revert.
4724         * dwarf-index-write.h: Revert.
4725         * dwarf-index-write.c: Revert.
4726         * dwarf-index-common.c: Revert.
4727         * dwarf-index-cache.h: Revert.
4728         * dwarf-index-cache.c: Revert.
4729         * dummy-frame.c: Revert.
4730         * dtrace-probe.c: Revert.
4731         * disasm.h: Revert.
4732         * disasm.c: Revert.
4733         * disasm-selftests.c: Revert.
4734         * dictionary.c: Revert.
4735         * dicos-tdep.c: Revert.
4736         * demangle.c: Revert.
4737         * dcache.h: Revert.
4738         * dcache.c: Revert.
4739         * darwin-nat.h: Revert.
4740         * darwin-nat.c: Revert.
4741         * darwin-nat-info.c: Revert.
4742         * d-valprint.c: Revert.
4743         * d-namespace.c: Revert.
4744         * d-lang.c: Revert.
4745         * ctf.c: Revert.
4746         * csky-tdep.c: Revert.
4747         * csky-linux-tdep.c: Revert.
4748         * cris-tdep.c: Revert.
4749         * cris-linux-tdep.c: Revert.
4750         * cp-valprint.c: Revert.
4751         * cp-support.c: Revert.
4752         * cp-namespace.c: Revert.
4753         * cp-abi.c: Revert.
4754         * corelow.c: Revert.
4755         * corefile.c: Revert.
4756         * continuations.c: Revert.
4757         * completer.h: Revert.
4758         * completer.c: Revert.
4759         * complaints.c: Revert.
4760         * coffread.c: Revert.
4761         * coff-pe-read.c: Revert.
4762         * cli-out.h: Revert.
4763         * cli-out.c: Revert.
4764         * charset.c: Revert.
4765         * c-varobj.c: Revert.
4766         * c-valprint.c: Revert.
4767         * c-typeprint.c: Revert.
4768         * c-lang.c: Revert.
4769         * buildsym.c: Revert.
4770         * buildsym-legacy.c: Revert.
4771         * build-id.h: Revert.
4772         * build-id.c: Revert.
4773         * btrace.c: Revert.
4774         * bsd-uthread.c: Revert.
4775         * breakpoint.h: Revert.
4776         * breakpoint.c: Revert.
4777         * break-catch-throw.c: Revert.
4778         * break-catch-syscall.c: Revert.
4779         * break-catch-sig.c: Revert.
4780         * blockframe.c: Revert.
4781         * block.c: Revert.
4782         * bfin-tdep.c: Revert.
4783         * bfin-linux-tdep.c: Revert.
4784         * bfd-target.c: Revert.
4785         * bcache.c: Revert.
4786         * ax-general.c: Revert.
4787         * ax-gdb.h: Revert.
4788         * ax-gdb.c: Revert.
4789         * avr-tdep.c: Revert.
4790         * auxv.c: Revert.
4791         * auto-load.c: Revert.
4792         * arm-wince-tdep.c: Revert.
4793         * arm-tdep.c: Revert.
4794         * arm-symbian-tdep.c: Revert.
4795         * arm-pikeos-tdep.c: Revert.
4796         * arm-obsd-tdep.c: Revert.
4797         * arm-nbsd-tdep.c: Revert.
4798         * arm-nbsd-nat.c: Revert.
4799         * arm-linux-tdep.c: Revert.
4800         * arm-linux-nat.c: Revert.
4801         * arm-fbsd-tdep.c: Revert.
4802         * arm-fbsd-nat.c: Revert.
4803         * arm-bsd-tdep.c: Revert.
4804         * arch-utils.c: Revert.
4805         * arc-tdep.c: Revert.
4806         * arc-newlib-tdep.c: Revert.
4807         * annotate.h: Revert.
4808         * annotate.c: Revert.
4809         * amd64-windows-tdep.c: Revert.
4810         * amd64-windows-nat.c: Revert.
4811         * amd64-tdep.c: Revert.
4812         * amd64-sol2-tdep.c: Revert.
4813         * amd64-obsd-tdep.c: Revert.
4814         * amd64-obsd-nat.c: Revert.
4815         * amd64-nbsd-tdep.c: Revert.
4816         * amd64-nbsd-nat.c: Revert.
4817         * amd64-nat.c: Revert.
4818         * amd64-linux-tdep.c: Revert.
4819         * amd64-linux-nat.c: Revert.
4820         * amd64-fbsd-tdep.c: Revert.
4821         * amd64-fbsd-nat.c: Revert.
4822         * amd64-dicos-tdep.c: Revert.
4823         * amd64-darwin-tdep.c: Revert.
4824         * amd64-bsd-nat.c: Revert.
4825         * alpha-tdep.c: Revert.
4826         * alpha-obsd-tdep.c: Revert.
4827         * alpha-nbsd-tdep.c: Revert.
4828         * alpha-mdebug-tdep.c: Revert.
4829         * alpha-linux-tdep.c: Revert.
4830         * alpha-linux-nat.c: Revert.
4831         * alpha-bsd-tdep.c: Revert.
4832         * alpha-bsd-nat.c: Revert.
4833         * aix-thread.c: Revert.
4834         * agent.c: Revert.
4835         * addrmap.c: Revert.
4836         * ada-varobj.c: Revert.
4837         * ada-valprint.c: Revert.
4838         * ada-typeprint.c: Revert.
4839         * ada-tasks.c: Revert.
4840         * ada-lang.c: Revert.
4841         * aarch64-tdep.c: Revert.
4842         * aarch64-ravenscar-thread.c: Revert.
4843         * aarch64-newlib-tdep.c: Revert.
4844         * aarch64-linux-tdep.c: Revert.
4845         * aarch64-linux-nat.c: Revert.
4846         * aarch64-fbsd-tdep.c: Revert.
4847         * aarch64-fbsd-nat.c: Revert.
4848         * aarch32-linux-nat.c: Revert.
4849
4850 2019-04-05  Tom Tromey  <tom@tromey.com>
4851
4852         * ft32-tdep.c: Sort headers.
4853         * frv-tdep.c: Sort headers.
4854         * frv-linux-tdep.c: Sort headers.
4855         * frame.c: Sort headers.
4856         * frame-unwind.c: Sort headers.
4857         * frame-base.c: Sort headers.
4858         * fork-child.c: Sort headers.
4859         * findvar.c: Sort headers.
4860         * findcmd.c: Sort headers.
4861         * filesystem.c: Sort headers.
4862         * filename-seen-cache.h: Sort headers.
4863         * filename-seen-cache.c: Sort headers.
4864         * fbsd-tdep.c: Sort headers.
4865         * fbsd-nat.h: Sort headers.
4866         * fbsd-nat.c: Sort headers.
4867         * f-valprint.c: Sort headers.
4868         * f-typeprint.c: Sort headers.
4869         * f-lang.c: Sort headers.
4870         * extension.h: Sort headers.
4871         * extension.c: Sort headers.
4872         * extension-priv.h: Sort headers.
4873         * expprint.c: Sort headers.
4874         * exec.h: Sort headers.
4875         * exec.c: Sort headers.
4876         * exceptions.c: Sort headers.
4877         * event-top.c: Sort headers.
4878         * event-loop.c: Sort headers.
4879         * eval.c: Sort headers.
4880         * elfread.c: Sort headers.
4881         * dwarf2read.h: Sort headers.
4882         * dwarf2read.c: Sort headers.
4883         * dwarf2loc.c: Sort headers.
4884         * dwarf2expr.h: Sort headers.
4885         * dwarf2expr.c: Sort headers.
4886         * dwarf2-frame.c: Sort headers.
4887         * dwarf2-frame-tailcall.c: Sort headers.
4888         * dwarf-index-write.h: Sort headers.
4889         * dwarf-index-write.c: Sort headers.
4890         * dwarf-index-common.c: Sort headers.
4891         * dwarf-index-cache.h: Sort headers.
4892         * dwarf-index-cache.c: Sort headers.
4893         * dummy-frame.c: Sort headers.
4894         * dtrace-probe.c: Sort headers.
4895         * disasm.h: Sort headers.
4896         * disasm.c: Sort headers.
4897         * disasm-selftests.c: Sort headers.
4898         * dictionary.c: Sort headers.
4899         * dicos-tdep.c: Sort headers.
4900         * demangle.c: Sort headers.
4901         * dcache.h: Sort headers.
4902         * dcache.c: Sort headers.
4903         * darwin-nat.h: Sort headers.
4904         * darwin-nat.c: Sort headers.
4905         * darwin-nat-info.c: Sort headers.
4906         * d-valprint.c: Sort headers.
4907         * d-namespace.c: Sort headers.
4908         * d-lang.c: Sort headers.
4909         * ctf.c: Sort headers.
4910         * csky-tdep.c: Sort headers.
4911         * csky-linux-tdep.c: Sort headers.
4912         * cris-tdep.c: Sort headers.
4913         * cris-linux-tdep.c: Sort headers.
4914         * cp-valprint.c: Sort headers.
4915         * cp-support.c: Sort headers.
4916         * cp-namespace.c: Sort headers.
4917         * cp-abi.c: Sort headers.
4918         * corelow.c: Sort headers.
4919         * corefile.c: Sort headers.
4920         * continuations.c: Sort headers.
4921         * completer.h: Sort headers.
4922         * completer.c: Sort headers.
4923         * complaints.c: Sort headers.
4924         * coffread.c: Sort headers.
4925         * coff-pe-read.c: Sort headers.
4926         * cli-out.h: Sort headers.
4927         * cli-out.c: Sort headers.
4928         * charset.c: Sort headers.
4929         * c-varobj.c: Sort headers.
4930         * c-valprint.c: Sort headers.
4931         * c-typeprint.c: Sort headers.
4932         * c-lang.c: Sort headers.
4933         * buildsym.c: Sort headers.
4934         * buildsym-legacy.c: Sort headers.
4935         * build-id.h: Sort headers.
4936         * build-id.c: Sort headers.
4937         * btrace.c: Sort headers.
4938         * bsd-uthread.c: Sort headers.
4939         * breakpoint.h: Sort headers.
4940         * breakpoint.c: Sort headers.
4941         * break-catch-throw.c: Sort headers.
4942         * break-catch-syscall.c: Sort headers.
4943         * break-catch-sig.c: Sort headers.
4944         * blockframe.c: Sort headers.
4945         * block.c: Sort headers.
4946         * bfin-tdep.c: Sort headers.
4947         * bfin-linux-tdep.c: Sort headers.
4948         * bfd-target.c: Sort headers.
4949         * bcache.c: Sort headers.
4950         * ax-general.c: Sort headers.
4951         * ax-gdb.h: Sort headers.
4952         * ax-gdb.c: Sort headers.
4953         * avr-tdep.c: Sort headers.
4954         * auxv.c: Sort headers.
4955         * auto-load.c: Sort headers.
4956         * arm-wince-tdep.c: Sort headers.
4957         * arm-tdep.c: Sort headers.
4958         * arm-symbian-tdep.c: Sort headers.
4959         * arm-pikeos-tdep.c: Sort headers.
4960         * arm-obsd-tdep.c: Sort headers.
4961         * arm-nbsd-tdep.c: Sort headers.
4962         * arm-nbsd-nat.c: Sort headers.
4963         * arm-linux-tdep.c: Sort headers.
4964         * arm-linux-nat.c: Sort headers.
4965         * arm-fbsd-tdep.c: Sort headers.
4966         * arm-fbsd-nat.c: Sort headers.
4967         * arm-bsd-tdep.c: Sort headers.
4968         * arch-utils.c: Sort headers.
4969         * arc-tdep.c: Sort headers.
4970         * arc-newlib-tdep.c: Sort headers.
4971         * annotate.h: Sort headers.
4972         * annotate.c: Sort headers.
4973         * amd64-windows-tdep.c: Sort headers.
4974         * amd64-windows-nat.c: Sort headers.
4975         * amd64-tdep.c: Sort headers.
4976         * amd64-sol2-tdep.c: Sort headers.
4977         * amd64-obsd-tdep.c: Sort headers.
4978         * amd64-obsd-nat.c: Sort headers.
4979         * amd64-nbsd-tdep.c: Sort headers.
4980         * amd64-nbsd-nat.c: Sort headers.
4981         * amd64-nat.c: Sort headers.
4982         * amd64-linux-tdep.c: Sort headers.
4983         * amd64-linux-nat.c: Sort headers.
4984         * amd64-fbsd-tdep.c: Sort headers.
4985         * amd64-fbsd-nat.c: Sort headers.
4986         * amd64-dicos-tdep.c: Sort headers.
4987         * amd64-darwin-tdep.c: Sort headers.
4988         * amd64-bsd-nat.c: Sort headers.
4989         * alpha-tdep.c: Sort headers.
4990         * alpha-obsd-tdep.c: Sort headers.
4991         * alpha-nbsd-tdep.c: Sort headers.
4992         * alpha-mdebug-tdep.c: Sort headers.
4993         * alpha-linux-tdep.c: Sort headers.
4994         * alpha-linux-nat.c: Sort headers.
4995         * alpha-bsd-tdep.c: Sort headers.
4996         * alpha-bsd-nat.c: Sort headers.
4997         * aix-thread.c: Sort headers.
4998         * agent.c: Sort headers.
4999         * addrmap.c: Sort headers.
5000         * ada-varobj.c: Sort headers.
5001         * ada-valprint.c: Sort headers.
5002         * ada-typeprint.c: Sort headers.
5003         * ada-tasks.c: Sort headers.
5004         * ada-lang.c: Sort headers.
5005         * aarch64-tdep.c: Sort headers.
5006         * aarch64-ravenscar-thread.c: Sort headers.
5007         * aarch64-newlib-tdep.c: Sort headers.
5008         * aarch64-linux-tdep.c: Sort headers.
5009         * aarch64-linux-nat.c: Sort headers.
5010         * aarch64-fbsd-tdep.c: Sort headers.
5011         * aarch64-fbsd-nat.c: Sort headers.
5012         * aarch32-linux-nat.c: Sort headers.
5013
5014 2019-04-04  Tom Tromey  <tom@tromey.com>
5015
5016         * varobj.c (varobj_create): Update.
5017         * rust-exp.y (struct rust_parser) <update_innermost_block,
5018         lookup_symbol>: New methods.
5019         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5020         Rename.
5021         (rust_parser::rust_lookup_type)
5022         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5023         * printcmd.c (display_command, do_one_display): Update.
5024         * parser-defs.h (struct parser_state) <parser_state>: Add
5025         "tracker" parameter.
5026         (block_tracker): New member.
5027         (class innermost_block_tracker) <innermost_block_tracker>: Add
5028         "types" parameter.
5029         <reset>: Remove method.
5030         (innermost_block): Don't declare.
5031         (null_post_parser): Update.
5032         * parse.c (innermost_block): Remove global.
5033         (write_dollar_variable): Update.
5034         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5035         Remove "tracker_types" parameter.
5036         (parse_expression): Add "tracker" parameter.
5037         (parse_expression_for_completion): Update.
5038         (null_post_parser): Add "tracker" parameter.
5039         * p-exp.y: Update rules.
5040         * m2-exp.y: Update rules.
5041         * language.h (struct language_defn) <la_post_parser>: Add
5042         "tracker" parameter.
5043         * go-exp.y: Update rules.
5044         * f-exp.y: Update rules.
5045         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5046         parameter.
5047         * d-exp.y: Update rules.
5048         * c-exp.y: Update rules.
5049         * breakpoint.c (set_breakpoint_condition): Create an
5050         innermost_block_tracker.
5051         (watch_command_1): Likewise.
5052         * ada-lang.c (resolve): Add "tracker" parameter.
5053         (resolve_subexp): Likewise.
5054         * ada-exp.y (write_var_from_sym): Update.
5055
5056 2019-04-04  Tom Tromey  <tom@tromey.com>
5057
5058         * type-stack.h: New file.
5059         * type-stack.c: New file.
5060         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5061         type-stack.h.
5062         (insert_into_type_stack, insert_type, push_type, push_type_int)
5063         (insert_type_address_space, pop_type, pop_type_int)
5064         (pop_typelist, pop_type_stack, append_type_stack)
5065         (push_type_stack, get_type_stack, push_typelist)
5066         (follow_type_instance_flags, follow_types): Don't declare.
5067         * parse.c (type_stack): Remove global.
5068         (parse_exp_in_context): Update.
5069         (insert_into_type_stack, insert_type, push_type, push_type_int)
5070         (insert_type_address_space, pop_type, pop_type_int)
5071         (pop_typelist, pop_type_stack, append_type_stack)
5072         (push_type_stack, get_type_stack, push_typelist)
5073         (follow_type_instance_flags, follow_types): Remove (moved to
5074         type-stack.c).
5075         * f-exp.y (type_stack): New global.
5076         Update rules.
5077         (push_kind_type, f_parse): Update.
5078         * d-exp.y (type_stack): New global.
5079         Update rules.
5080         (d_parse): Update.
5081         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5082         Update rules.
5083         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5084         (HFILES_NO_SRCDIR): Add type-stack.h.
5085
5086 2019-04-04  Tom Tromey  <tom@tromey.com>
5087
5088         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5089         (rust_parser::convert_ast_to_expression, rust_parse)
5090         (rust_lex_test_completion, rust_lex_tests): Update.
5091         * parser-defs.h (struct expr_completion_state): New.
5092         (struct parser_state) <parser_state>: Add completion parameter.
5093         <mark_struct_expression, mark_completion_tag>: New methods.
5094         <parse_completion, m_completion_state>: New members.
5095         (prefixify_expression, null_post_parser): Update.
5096         (mark_struct_expression, mark_completion_tag): Don't declare.
5097         * parse.c (parse_completion, expout_last_struct)
5098         (expout_tag_completion_type, expout_completion_name): Remove
5099         globals.
5100         (parser_state::mark_struct_expression)
5101         (parser_state::mark_completion_tag): Now methods.
5102         (prefixify_expression): Add last_struct parameter.
5103         (prefixify_subexp): Likewise.
5104         (parse_exp_1): Update.
5105         (parse_exp_in_context): Add cstate parameter.  Update.
5106         (parse_expression_for_completion): Create an
5107         expr_completion_state.
5108         (null_post_parser): Add "completion" parameter.
5109         * p-exp.y: Update rules.
5110         (yylex): Update.
5111         * language.h (struct language_defn) <la_post_parser>: Add
5112         "completing" parameter.
5113         * go-exp.y: Update rules.
5114         (lex_one_token): Update.
5115         * expression.h (parse_completion): Don't declare.
5116         * d-exp.y: Update rules.
5117         (lex_one_token): Update rules.
5118         * c-exp.y: Update rules.
5119         (lex_one_token): Update.
5120         * ada-lang.c (resolve): Add "parse_completion" parameter.
5121         (resolve_subexp): Likewise.
5122         (ada_resolve_function): Likewise.
5123
5124 2019-04-04  Tom Tromey  <tom@tromey.com>
5125
5126         * parser-defs.h (struct parser_state) <start_arglist,
5127         end_arglist>: New methods.
5128         <arglist_len, m_funcall_chain>: New members.
5129         (arglist_len, start_arglist, end_arglist): Don't declare.
5130         * parse.c (arglist_len, funcall_chain): Remove global.
5131         (start_arglist, end_arglist): Remove functions.
5132         (parse_exp_in_context): Update.
5133         * p-exp.y: Update rules.
5134         * m2-exp.y: Update rules.
5135         * go-exp.y: Update rules.
5136         * f-exp.y: Update rules.
5137         * d-exp.y: Update rules.
5138         * c-exp.y: Update rules.
5139
5140 2019-04-04  Tom Tromey  <tom@tromey.com>
5141
5142         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5143         lex_operator, push_back>: New methods.
5144         Update all rules.
5145         (rust_parser::lex_hex, lex_escape): Rename and update.
5146         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5147         (rust_parser::lex_operator): Rename and update.
5148         (rust_parser::lex_number, rustyylex, rustyyerror)
5149         (rust_lex_test_init, rust_lex_test_sequence)
5150         (rust_lex_test_push_back, rust_lex_tests): Update.
5151         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5152         parameter.
5153         <lexptr, prev_lexptr>: New members.
5154         (lexptr, prev_lexptr): Don't declare.
5155         * parse.c (lexptr, prev_lexptr): Remove globals.
5156         (parse_exp_in_context): Update.
5157         * p-exp.y (yylex, yyerror): Update.
5158         * m2-exp.y (parse_number, yylex, yyerror): Update.
5159         * go-exp.y (lex_one_token, yyerror): Update.
5160         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5161         * d-exp.y (lex_one_token, yyerror): Update.
5162         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5163         (lex_one_token, yyerror): Update.
5164         * ada-lex.l (YY_INPUT): Update.
5165         (rewind_to_char): Update.
5166         * ada-exp.y (yyerror): Update.
5167
5168 2019-04-04  Tom Tromey  <tom@tromey.com>
5169
5170         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5171         * parser-defs.h (struct parser_state) <parser_state>: Add new
5172         parameter.
5173         <comma_terminates>: New member.
5174         (comma_terminates): Don't declare global.
5175         * parse.c (comma_terminates): Remove global.
5176         (parse_exp_in_context): Update.
5177         * p-exp.y (yylex): Update.
5178         * m2-exp.y (yylex): Update.
5179         * go-exp.y (lex_one_token): Update.
5180         * f-exp.y (yylex): Update.
5181         * d-exp.y (lex_one_token): Update.
5182         * c-exp.y (lex_one_token): Update.
5183         * ada-lex.l: Update.
5184
5185 2019-04-04  Tom Tromey  <tom@tromey.com>
5186
5187         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5188         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5189         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5190         * parser-defs.h (paren_depth): Don't declare.
5191         * parse.c (paren_depth): Remove global.
5192         (parse_exp_in_context): Update.
5193         * p-exp.y (paren_depth): New global.
5194         (pascal_parse): Initialize it.
5195         * m2-exp.y (paren_depth): New global.
5196         (m2_parse): Initialize it.
5197         * go-exp.y (paren_depth): New global.
5198         (go_parse): Initialize it.
5199         * f-exp.y (paren_depth): New global.
5200         (f_parse): Initialize it.
5201         * d-exp.y (paren_depth): New global.
5202         (d_parse): Initialize it.
5203         * c-exp.y (paren_depth): New global.
5204         (c_parse): Initialize it.
5205         * ada-lex.l (paren_depth): New global.
5206         (lexer_init): Initialize it.
5207
5208 2019-04-04  Tom Tromey  <tom@tromey.com>
5209
5210         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5211         (rust_parser::convert_ast_to_type)
5212         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5213         * parser-defs.h (struct parser_state) <parser_state>: Add
5214         parameters.  Initialize new members.
5215         <expression_context_block, expression_context_pc>: New members.
5216         * parse.c (expression_context_block, expression_context_pc):
5217         Remove globals.
5218         (parse_exp_in_context): Update.
5219         * p-exp.y: Update all rules.
5220         (yylex): Update.
5221         * m2-exp.y: Update all rules.
5222         (yylex): Update.
5223         * go-exp.y (yylex): Update.
5224         * f-exp.y (yylex): Update.
5225         * d-exp.y: Update all rules.
5226         (yylex): Update.
5227         * c-exp.y: Update all rules.
5228         (lex_one_token, classify_name, yylex, c_parse): Update.
5229         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5230
5231 2019-04-04  Tom Tromey  <tom@tromey.com>
5232
5233         * gdbarch.h, gdbarch.c: Rebuild.
5234         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5235         * stap-probe.h:
5236         (struct stap_parse_info): Replace "parser_state" with
5237         "expr_builder".
5238         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5239         (parser_state): New class.
5240         * parse.c (expr_builder): Rename.
5241         (expr_builder::release): Rename.
5242         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5243         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5244         (write_exp_elt_longcst, write_exp_elt_floatcst)
5245         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5246         (write_exp_string_vector, write_exp_bitstring)
5247         (write_exp_msymbol, mark_struct_expression)
5248         (write_dollar_variable)
5249         (insert_type_address_space, increase_expout_size): Replace
5250         "parser_state" with "expr_builder".
5251         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5252         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5253         "parser_state" with "expr_builder".
5254
5255 2019-04-04  Tom Tromey  <tom@tromey.com>
5256
5257         * rust-exp.y: Replace "parse_language" with method call.
5258         * p-exp.y:
5259         (yylex): Replace "parse_language" with method call.
5260         * m2-exp.y:
5261         (yylex): Replace "parse_language" with method call.
5262         * go-exp.y (classify_name): Replace "parse_language" with method
5263         call.
5264         * f-exp.y (yylex): Replace "parse_language" with method call.
5265         * d-exp.y (lex_one_token): Replace "parse_language" with method
5266         call.
5267         * c-exp.y:
5268         (lex_one_token, classify_name, yylex): Replace "parse_language"
5269         with method call.
5270         * ada-exp.y (find_primitive_type, type_char)
5271         (type_system_address): Replace "parse_language" with method call.
5272
5273 2019-04-04  Tom Tromey  <tom@tromey.com>
5274
5275         * rust-exp.y: Replace "parse_gdbarch" with method call.
5276         * parse.c (write_dollar_variable, insert_type_address_space):
5277         Replace "parse_gdbarch" with method call.
5278         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5279         call.
5280         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5281         call.
5282         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5283         "parse_gdbarch" with method call.
5284         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5285         with method call.
5286         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5287         "parse_gdbarch" with method call.
5288         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5289         "parse_gdbarch" with method call.
5290         * c-exp.y (parse_type, parse_number, classify_name): Replace
5291         "parse_gdbarch" with method call.
5292         * ada-lex.l: Replace "parse_gdbarch" with method call.
5293         * ada-exp.y (parse_type, find_primitive_type, type_char)
5294         (type_system_address): Replace "parse_gdbarch" with method call.
5295
5296 2019-04-04  Tom Tromey  <tom@tromey.com>
5297
5298         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5299         * stap-probe.c (stap_parse_argument): Update.
5300         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5301         initial_size parameter.
5302         * rust-exp.y (rust_lex_tests): Update.
5303         * parse.c (parser_state): Update.
5304         (parse_exp_in_context): Update.
5305         * parser-defs.h (struct parser_state) <parser_state>: Remove
5306         "initial_size" parameter.
5307
5308 2019-04-04  Tom Tromey  <tom@tromey.com>
5309
5310         * parser-defs.h (increase_expout_size): Don't declare.
5311         * parse.c (increase_expout_size): Now static.
5312
5313 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5314
5315         * gnu-nat.c (gnu_nat_target::wait): Fix
5316         target_waitstatus_to_string call.
5317
5318 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5319
5320         * eval.c (evaluate_subexp_standard): Handle internal functions
5321         during Fortran function call handling.
5322
5323 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5324
5325         * NEWS: Mention new internal functions.
5326         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5327         (read_base_type): Use dwarf2_init_complex_target_type.
5328         * value.c (creal_internal_fn): New function.
5329         (cimag_internal_fn): New function.
5330         (_initialize_values): Register new internal functions.
5331
5332 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5333
5334         * infrun.c (stop_all_threads): If debug_infrun, always
5335         trace the wait status after wait_one, using
5336         target_waitstatus_to_string and target_pid_to_str.
5337         (handle_inferior_event): Replace various trace of
5338         wait status kind by a single trace.
5339         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5340         wait status kind image by target_waitstatus_to_string.
5341         * target/waitstatus.c (target_waitstatus_to_string): Fix
5342         obsolete comment.
5343
5344 2019-04-01  Tom Tromey  <tromey@adacore.com>
5345
5346         PR symtab/23331:
5347         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5348
5349 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5350             Pedro Alves  <palves@redhat.com>
5351
5352         * top.c (quit_force): Call 'finalize_values'.
5353         * value.c (finalize_values): New function.
5354         * value.h (finalize_values): Declare.
5355
5356 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5357
5358         * NEWS: Announce $_gdb_major and $_gdb_minor.
5359
5360         * top.c (init_gdb_version_vars): New function.
5361         (gdb_init): Call init_gdb_version_vars.
5362
5363 2019-03-29  Tom Tromey  <tromey@adacore.com>
5364
5365         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5366         help text.  Remove dead code.
5367
5368 2019-03-29  Keith Seitz  <keiths@redhat.com>
5369
5370         From Siddhesh Poyarekar:
5371         * f-lang.h (f77_get_upperbound): Return LONGEST.
5372         (f77_get_lowerbound): Likewise.
5373         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5374         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5375         print them.
5376         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5377         plongest to format print it.
5378         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5379         (f77_get_upperbound): Likewise.
5380         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5381         LOWER_BOUND to LONGEST.
5382         (f77_create_arrayprint_offset_tbl): Likewise.
5383
5384 2019-03-29  Keith Seitz  <keiths@redhat.com>
5385
5386         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5387         %s/pulongest for TYPE_LENGTH instead of %d in format
5388         strings.
5389         * ada-typerint.c (ada_print_type): Likewise.
5390         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5391         * compile/compile-c-support.c (generate_register_struct): Likewise.
5392         * gdbtypes.c (recursive_dump_type): Likewise.
5393         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5394         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5395         instead of %d in format strings.
5396         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5397         to std::min to ULONGEST.
5398         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5399         instead of %d in format strings.
5400         * tracepoint.c (info_scope_command): Likewise.
5401         * typeprint.c (print_offset_data::update)
5402         (print_offset_data::finish): Likewise.
5403         * xtensa-tdep.c (xtensa_store_return_value)
5404         (xtensa_push_dummy_call): Likewise.
5405
5406 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5407
5408         * windows-nat.c (display_selector): Fixed format specifications
5409         for 64-bit Cygwin.
5410
5411 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5412
5413         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5414
5415 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5416
5417         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5418         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5419         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5420         (nios2_linux_init_abi): Install it.
5421
5422 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5423
5424         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5425
5426 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5427
5428         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5429
5430 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5431             Tom Tromey  <tromey@adacore.com>
5432
5433         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5434
5435 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5436
5437         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5438         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5439         method to compute the bounds of range types. Also print "[evaluated]"
5440         if the bounds' values come from a dynamic evaluation.
5441
5442 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5443
5444         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5445         whitespace when pretty printing is on.
5446
5447 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5448
5449         * ppc-linux-nat.c: Add include.
5450
5451 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5452
5453         * NEWS: Mention AArch64 Pointer Authentication.
5454
5455 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5456
5457         * arm-linux-nat.c: Add include.
5458
5459 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5460
5461         * source-cache.c (source_cache::get_source_lines): Re-read
5462         fullname after calling open_source_file.
5463
5464 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5465
5466         * NEWS: Mention TLS support for FreeBSD.
5467
5468 2019-03-25  Tom Tromey  <tromey@adacore.com>
5469
5470         * minsyms.c (BUNCH_SIZE): Update comment.
5471         (~minimal_symbol_reader): Remove old comment.
5472         (compact_minimal_symbols): Update comment.
5473         (minimal_symbol_reader::install): Remove old comment.  Update
5474         other comments.
5475
5476 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5477
5478         * s390-linux-nat.c: Add include.
5479
5480 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5481
5482         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5483         Call linux_get_hwcap.
5484         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5485         Likewise.
5486         (aarch64_linux_get_hwcap): Remove function.
5487         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5488         declaration.
5489         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5490         linux_get_hwcap.
5491         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5492         * linux-tdep.c (linux_get_hwcap): Add function.
5493         (linux_get_hwcap2): Likewise.
5494         * linux-tdep.h (linux_get_hwcap): Add declaration.
5495         (linux_get_hwcap2): Likewise.
5496         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5497         (ppc_linux_get_hwcap2): Likewise.
5498         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5499         linux_get_hwcap.
5500         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5501         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5502         (ppc_linux_nat_target::read_description): Likewise.
5503         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5504         * s390-linux-nat.c: Likewise.
5505         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5506
5507 2019-03-24  Tom Tromey  <tom@tromey.com>
5508
5509         * ada-lang.c (standard_lookup): Simplify initialization.
5510         (ada_lookup_symbol_nonlocal): Simplify return.
5511         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5512         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5513         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5514         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5515         initialization.
5516         * solib.c (solib_global_lookup): Simplify.
5517         * symtab.c (null_block_symbol): Remove.
5518         (symbol_cache_lookup): Simplify returns.
5519         (lookup_language_this): Simplify returns.
5520         (lookup_symbol_aux): Simplify return.
5521         (lookup_local_symbol): Simplify returns.
5522         (lookup_global_symbol_from_objfile): Simplify return.
5523         (lookup_symbol_in_objfile_symtabs)
5524         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5525         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5526         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5527         * cp-namespace.c (cp_lookup_bare_symbol)
5528         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5529         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5530         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5531         (cp_lookup_symbol_via_imports): Simplify initialization.
5532         (find_symbol_in_baseclass): Likewise.
5533         * symtab.h (null_block_symbol): Remove.
5534         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5535         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5536         (d_lookup_symbol_module): Likewise.
5537         (find_symbol_in_baseclass): Simplify initialization.
5538
5539 2019-03-24  Tom Tromey  <tom@tromey.com>
5540
5541         * expression.h: Don't include symtab.h.
5542         (struct block): Forward declare.
5543
5544 2019-03-24  Tom Tromey  <tom@tromey.com>
5545
5546         * c-exp.y (typebase): Remove casts.
5547         * gdbtypes.c (lookup_unsigned_typename, )
5548         (lookup_signed_typename): Remove cast.
5549         * eval.c (parse_to_comma_and_eval): Remove cast.
5550         * parse.c (write_dollar_variable): Remove cast.
5551         * block.h (struct block) <superblock>: Now const.
5552         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5553         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5554         (map_block): Make "block" const.
5555         * symfile.h (struct quick_symbol_functions)
5556         <map_matching_symbols>: Constify block argument to "callback".
5557         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5558         const.
5559         (find_pc_sect_compunit_symtab): Make "b" const.
5560         (find_symbol_at_address): Likewise.
5561         (search_symbols): Likewise.
5562         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5563         (dw2_debug_names_lookup_symbol): Likewise.
5564         (dw2_map_matching_symbols): Update.
5565         * p-valprint.c (pascal_val_print): Remove "block".
5566         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5567         (aux_add_nonlocal_symbols): Make "block" const.
5568         (resolve_subexp): Remove cast.
5569         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5570         const.
5571         (iterate_over_file_blocks): Likewise.
5572         * f-exp.y (%union) <bval>: Remove.
5573         * coffread.c (patch_opaque_types): Make "b" const.
5574         * spu-tdep.c (spu_catch_start): Make "block" const.
5575         * c-valprint.c (print_unpacked_pointer): Remove "block".
5576         * symmisc.c (dump_symtab_1): Make "b" const.
5577         (block_depth): Make "block" const.
5578         * d-exp.y (%union) <bval>: Remove.
5579         * cp-support.h (cp_lookup_rtti_type): Update.
5580         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5581         * psymtab.c (psym_lookup_symbol): Make "block" const.
5582         (maintenance_check_psymtabs): Make "b" const.
5583         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5584         (enumerate_locals, enumerate_args): Update.
5585         * python/py-symtab.c (stpy_global_block): Make "block" const.
5586         (stpy_static_block): Likewise.
5587         * inline-frame.c (block_starting_point_at): Make "new_block"
5588         const.
5589         * block.c (find_block_in_blockvector): Make return type const.
5590         (blockvector_for_pc_sect): Make "b" const.
5591         (find_block_in_blockvector): Make "b" const.
5592
5593 2019-03-23  Tom Tromey  <tom@tromey.com>
5594
5595         * varobj.c (varobj_create): Update.
5596         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5597         * printcmd.c (display_command, do_one_display): Don't reset
5598         innermost_block.
5599         * parser-defs.h (enum innermost_block_tracker_type): Move to
5600         expression.h.
5601         (innermost_block): Update comment.
5602         * parse.c (parse_exp_1): Add tracker_types parameter.
5603         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5604         tracker_types parameter.  Reset innermost_block.
5605         (parse_exp_in_context): Remove.
5606         (parse_expression_for_completion): Update.
5607         * objfiles.c (~objfile): Don't reset expression_context_block or
5608         innermost_block.
5609         * expression.h (enum innermost_block_tracker_type): Move from
5610         parser-defs.h.
5611         (parse_exp_1): Add tracker_types parameter.
5612         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5613         reset innermost_block.
5614
5615 2019-03-23  Tom Tromey  <tom@tromey.com>
5616
5617         * objfiles.h: Include bcache.h.
5618
5619 2019-03-23  Tom Tromey  <tom@tromey.com>
5620
5621         * linespec.c (get_current_search_block): Use
5622         scoped_restore_current_language.
5623         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5624
5625 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5626             Jiong Wang  <jiong.wang@arm.com>
5627
5628         * aarch64-linux-tdep.c
5629         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5630         section.
5631         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5632
5633 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5634             Jiong Wang  <jiong.wang@arm.com>
5635
5636         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5637         instructions.
5638         (aarch64_analyze_prologue_test): Add PACIASP test.
5639         (aarch64_prologue_prev_register): Unmask PC value.
5640
5641 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5642             Jiong Wang  <jiong.wang@arm.com>
5643
5644         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5645         (aarch64_dwarf2_prev_register): Unmask PC value.
5646         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5647         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5648         DW_CFA_AARCH64_negate_ra_state.
5649         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5650
5651 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5652             Jiong Wang  <jiong.wang@arm.com>
5653
5654         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5655         registers.
5656         (aarch64_pseudo_register_name): Likewise.
5657         (aarch64_pseudo_register_type): Likewise.
5658         (aarch64_pseudo_register_reggroup_p): Likewise.
5659         (aarch64_gdbarch_init): Add pauth registers.
5660         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5661         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5662         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5663         (struct gdbarch_tdep): Add regnum for ra_state.
5664
5665 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5666             Jiong Wang  <jiong.wang@arm.com>
5667
5668         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5669
5670 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5671             Jiong Wang  <jiong.wang@arm.com>
5672
5673         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5674         function.
5675         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5676         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5677         (aarch64_gdbarch_init): Add puth registers.
5678         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5679         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5680         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5681
5682 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5683             Jiong Wang  <jiong.wang@arm.com>
5684
5685         * aarch64-linux-nat.c
5686         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5687         * aarch64-linux-tdep.c
5688         (aarch64_linux_core_read_description): Likewise.
5689         (aarch64_linux_get_hwcap): New function.
5690         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5691         (aarch64_linux_get_hwcap): New declaration.
5692
5693 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5694             Jiong Wang  <jiong.wang@arm.com>
5695
5696         * aarch64-linux-nat.c
5697         (aarch64_linux_nat_target::read_description): Add pauth param.
5698         * aarch64-linux-tdep.c
5699         (aarch64_linux_core_read_description): Likewise.
5700         * aarch64-tdep.c (struct target_desc): Add in pauth.
5701         (aarch64_read_description): Add pauth param.
5702         (aarch64_gdbarch_init): Likewise.
5703         * aarch64-tdep.h (aarch64_read_description): Likewise.
5704         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5705         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5706         * features/Makefile: Add new files.
5707         * features/aarch64-pauth.c: New file.
5708         * features/aarch64-pauth.xml: New file.
5709
5710 2019-03-20  Tom Tromey  <tromey@adacore.com>
5711
5712         * infrun.c (handle_inferior_event): Rename from
5713         handle_inferior_event_1.  Create a scoped_value_mark.
5714         (handle_inferior_event): Remove.
5715
5716 2019-03-19  Tom Tromey  <tromey@adacore.com>
5717
5718         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5719         * infrun.h (print_stop_event): Add "displays" parameter.
5720         * infrun.c (print_stop_event): Add "displays" parameter.
5721
5722 2019-03-19  Pedro Alves  <palves@redhat.com>
5723
5724         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5725         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5726         to -1.  Fix TABs vs spaces.
5727         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5728         * tui/tui-out.h (tui_ui_out) Add intro comments.
5729         <m_line, m_start_of_line>: In-class initialize, and add describing
5730         comment.
5731
5732 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5733
5734         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5735         variable names.
5736         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5737
5738 2019-03-18  Pedro Alves  <palves@redhat.com>
5739             Eli Zaretskii <eliz@gnu.org>
5740
5741         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5742         m_line and m_start_of_line.
5743
5744 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5745
5746         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5747         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5748         it returns a newline.  This fixes a regression in TU mode, whereby
5749         the next line is output on the same screen line as the user input.
5750
5751 2019-03-18  Tom Tromey  <tromey@adacore.com>
5752
5753         * minsyms.c (minimal_symbol_reader::install): Remove call to
5754         obstack_blank.
5755
5756 2019-03-18  Pedro Alves  <palves@redhat.com>
5757
5758         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5759         New globals.
5760         (apply_style): New, factored out from ...
5761         (apply_ansi_escape): ... this.  Handle reverse video mode.
5762         (tui_set_reverse_mode): New function.
5763         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5764         * tui/tui-winsource.c (tui_show_source_line): Use
5765         tui_set_reverse_mode instead of setting A_STANDOUT.
5766         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5767         New setter methods.
5768
5769 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5770
5771         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5772         Handle tabs.
5773
5774 2019-03-18  Tom Tromey  <tromey@adacore.com>
5775
5776         * ada-lang.c (empty_array): Add "high" parameter.
5777         (ada_evaluate_subexp): Update.
5778
5779 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5780
5781         * unittests/string_view-selftests.c: Define
5782         _initialize_string_view_selftests unconditionally.
5783
5784 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5785
5786         PR gdb/24350
5787         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5788
5789 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5790
5791         PR gdb/24351
5792         * windows-nat.c (display_selector): Fix format specifiers.
5793
5794 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5795
5796         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5797         tui_refill_source_window instead of tui_refresh_win, to update the
5798         current execution line.  This fixes redisplay of the current line
5799         when stepping through the code with "next" or "step".
5800
5801 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5802
5803         * source-cache.c (source_cache::get_source_lines): Call
5804         find_source_lines to initialize s->nlines.  This fixes vertical
5805         scrolling of TUI source window when the DOWN arrow is pressed.
5806
5807 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5808
5809         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5810         linux-thread-db.c (_initialize_thread_db): Likewise.
5811
5812 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5813
5814         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5815         wclrtoeol in tui_show_source_line".  This reverts changes made in
5816         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5817
5818 2019-03-15  Tom Tromey  <tom@tromey.com>
5819
5820         * symtab.h (struct minimal_symbol): Derive from
5821         general_symbol_info.
5822         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5823         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5824         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5825         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5826         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5827         (MSYMBOL_SEARCH_NAME): Update.
5828         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5829         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5830         * minsyms.c (minimal_symbol_reader::record_full): Update.
5831
5832 2019-03-15  Tom Tromey  <tom@tromey.com>
5833
5834         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5835
5836 2019-03-15  Tom Tromey  <tom@tromey.com>
5837
5838         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5839         unique_xmalloc_ptr.
5840         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5841         Update.
5842         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5843         (build_minimal_symbol_hash_tables)
5844         (minimal_symbol_reader::install): Update.
5845
5846 2019-03-15  Tom Tromey  <tom@tromey.com>
5847
5848         * symtab.c (create_demangled_names_hash): Update.
5849         (symbol_set_names): Update.
5850         * objfiles.h (struct objfile_per_bfd_storage)
5851         <demangled_names_hash>: Now an htab_up.
5852         * objfiles.c (objfile_per_bfd_storage): Simplify.
5853
5854 2019-03-15  Tom Tromey  <tom@tromey.com>
5855
5856         * objfiles.h (struct objfile_per_bfd_storage): Declare
5857         destructor.
5858         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5859         New.
5860         (get_objfile_bfd_data): Use new.  Don't initialize
5861         language_of_main.
5862         (free_objfile_per_bfd_storage): Remove.
5863         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5864
5865 2019-03-15  Tom Tromey  <tom@tromey.com>
5866
5867         * symfile.c (reread_symbols): Update.
5868         * objfiles.c (objfile::objfile): Update.
5869         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5870         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5871         comment.
5872         (minimal_symbol_reader::install): Update.
5873         (terminate_minimal_symbol_table): Remove.
5874         * jit.c (jit_object_close_impl): Update.
5875
5876 2019-03-15  Tom Tromey  <tom@tromey.com>
5877
5878         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5879         initializations.
5880
5881 2019-03-15  Tom Tromey  <tom@tromey.com>
5882
5883         * objfiles.h (struct objfile_per_bfd_storage)
5884         <demangled_hash_languages>: Now a bitset.
5885         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5886         (lookup_minimal_symbol): Update.
5887
5888 2019-03-15  Tom Tromey  <tom@tromey.com>
5889
5890         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5891         Don't return the symbol.
5892         * coffread.c (record_minimal_symbol): Use record_full.
5893
5894 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5895
5896         The MS-Windows port of ncurses fails to switch to a color pair if
5897         one or both of the colors are the implicit default colors.  This
5898         change records the default colors when TUI is initialized, and
5899         then specifies them explicitly when a color pair uses the default
5900         colors.  This allows color styling in TUI mode on MS-Windows.
5901
5902         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5903         ncurses_norm_attr.
5904         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5905         colors in ncurses_norm_attr.
5906         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5907         "none", replace it with the default color recorded in
5908         ncurses_norm_attr.
5909
5910 2019-03-14  Tom Tromey  <tromey@adacore.com>
5911
5912         * source-cache.h (class source_cache) <get_source_lines>: Return
5913         std::string.
5914         * source-cache.c (source_cache::extract_lines): Handle case where
5915         first_pos==npos.  Return std::string.
5916         (source_cache::get_source_lines): Update.
5917
5918 2019-03-14  Tom Tromey  <tromey@adacore.com>
5919
5920         * NEWS: Add item for "style sources" commands.
5921         * source-cache.c (source_cache::get_source_lines): Check
5922         source_styling.
5923         * cli/cli-style.c (source_styling): New global.
5924         (_initialize_cli_style): Add "style sources" commands.
5925         (show_style_sources): New function.
5926         * cli/cli-style.h (source_styling): Declare.
5927
5928 2019-03-14  Pedro Alves  <palves@redhat.com>
5929             Tom Tromey  <tromey@adacore.com>
5930
5931         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5932         * tui/tui-winsource.c (tui_refill_source_window): New function,
5933         from...
5934         (tui_horizontal_source_scroll): ... here.  Move some logic.
5935         * cli/cli-style.c (set_style_enabled): Notify new observable.
5936         * tui/tui-hooks.c (tui_redisplay_source): New function.
5937         (tui_attach_detach_observers): Attach or detach
5938         tui_redisplay_source.
5939         * observable.h (source_styling_changed): New observable.
5940         * observable.c: Define source_styling_changed observable.
5941
5942 2019-03-13  Tom Tromey  <tromey@adacore.com>
5943
5944         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5945         (i386_gnu_nat_target::store_registers): Update.
5946         * target-debug.h (target_debug_print_std_string): New macro.
5947         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5948         * windows-tdep.c (display_one_tib): Update.
5949         * tui/tui-stack.c (tui_make_status_line): Update.
5950         * top.c (print_inferior_quit_action): Update.
5951         * thread.c (thr_try_catch_cmd): Update.
5952         (add_thread_with_info): Update.
5953         (thread_target_id_str): Update.
5954         (thr_try_catch_cmd): Update.
5955         (thread_command): Update.
5956         (thread_find_command): Update.
5957         * record-btrace.c (record_btrace_target::info_record)
5958         (record_btrace_resume_thread, record_btrace_target::resume)
5959         (record_btrace_cancel_resume, record_btrace_step_thread)
5960         (record_btrace_target::wait, record_btrace_target::wait)
5961         (record_btrace_target::wait, record_btrace_target::stop): Update.
5962         * progspace.c (print_program_space): Update.
5963         * process-stratum-target.c
5964         (process_stratum_target::thread_address_space): Update.
5965         * linux-fork.c (linux_fork_mourn_inferior)
5966         (detach_checkpoint_command, info_checkpoints_command)
5967         (linux_fork_context): Update.
5968         (linux_fork_detach): Update.
5969         (class scoped_switch_fork_info): Update.
5970         (delete_checkpoint_command): Update.
5971         * infrun.c (follow_fork_inferior): Update.
5972         (follow_fork_inferior): Update.
5973         (proceed_after_vfork_done): Update.
5974         (handle_vfork_child_exec_or_exit): Update.
5975         (follow_exec): Update.
5976         (displaced_step_prepare_throw): Update.
5977         (displaced_step_restore): Update.
5978         (start_step_over): Update.
5979         (resume_1): Update.
5980         (clear_proceed_status_thread): Update.
5981         (proceed): Update.
5982         (print_target_wait_results): Update.
5983         (do_target_wait): Update.
5984         (context_switch): Update.
5985         (stop_all_threads): Update.
5986         (restart_threads): Update.
5987         (finish_step_over): Update.
5988         (handle_signal_stop): Update.
5989         (switch_back_to_stepped_thread): Update.
5990         (keep_going_pass_signal): Update.
5991         (print_exited_reason): Update.
5992         (normal_stop): Update.
5993         * inferior.c (inferior_pid_to_str): Change return type.
5994         (print_selected_inferior): Update.
5995         (add_inferior): Update.
5996         (detach_inferior): Update.
5997         * dummy-frame.c (fprint_dummy_frames): Update.
5998         * dcache.c (dcache_info_1): Update.
5999         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6000         (btrace_fetch, btrace_clear): Update.
6001         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6002         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6003         type.
6004         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6005         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6006         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6007         * gdbarch.c, gdbarch.h: Rebuild.
6008         * gdbarch.sh (core_pid_to_str): Change return type.
6009         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6010         return type.
6011         (windows_nat_target::pid_to_str): Change return type.
6012         (windows_delete_thread): Update.
6013         (windows_nat_target::attach): Update.
6014         (windows_nat_target::files_info): Update.
6015         * target-delegates.c: Rebuild.
6016         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6017         return type.
6018         (sol_thread_target::pid_to_str): Change return type.
6019         * remote.c (class remote_target) <pid_to_str>: Change return
6020         type.
6021         (remote_target::pid_to_str): Change return type.
6022         (extended_remote_target::attach, remote_target::remote_stop_ns)
6023         (remote_target::remote_notif_remove_queued_reply)
6024         (remote_target::push_stop_reply, remote_target::disable_btrace):
6025         Update.
6026         (extended_remote_target::attach): Update.
6027         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6028         type.
6029         (gdbsim_target::pid_to_str): Change return type.
6030         * ravenscar-thread.c (struct ravenscar_thread_target)
6031         <pid_to_str>: Change return type.
6032         (ravenscar_thread_target::pid_to_str): Change return type.
6033         * procfs.c (class procfs_target) <pid_to_str>: Change return
6034         type.
6035         (procfs_target::pid_to_str): Change return type.
6036         (procfs_target::attach): Update.
6037         (procfs_target::detach): Update.
6038         (procfs_target::fetch_registers): Update.
6039         (procfs_target::store_registers): Update.
6040         (procfs_target::wait): Update.
6041         (procfs_target::files_info): Update.
6042         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6043         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6044         return type.
6045         (nto_procfs_target::pid_to_str): Change return type.
6046         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6047         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6048         return type.
6049         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6050         (exit_lwp): Update.
6051         (attach_proc_task_lwp_callback, get_detach_signal)
6052         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6053         (linux_nat_target::resume, wait_lwp, stop_callback)
6054         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6055         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6056         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6057         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6058         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6059         type.
6060         (inf_ptrace_target::attach): Update.
6061         (inf_ptrace_target::files_info): Update.
6062         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6063         type.
6064         (go32_nat_target::pid_to_str): Change return type.
6065         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6066         (gnu_nat_target::wait): Update.
6067         (gnu_nat_target::wait): Update.
6068         (gnu_nat_target::resume): Update.
6069         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6070         (fbsd_nat_target::wait): Update.
6071         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6072         type.
6073         (darwin_nat_target::attach): Update.
6074         * corelow.c (class core_target) <pid_to_str>: Change return type.
6075         (core_target::pid_to_str): Change return type.
6076         * target.c (normal_pid_to_str): Change return type.
6077         (default_pid_to_str): Likewise.
6078         (target_pid_to_str): Change return type.
6079         (target_translate_tls_address): Update.
6080         (target_announce_detach): Update.
6081         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6082         return type.
6083         (bsd_uthread_target::pid_to_str): Change return type.
6084         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6085         type.
6086         (bsd_kvm_target::pid_to_str): Change return type.
6087         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6088         return type.
6089         (aix_thread_target::pid_to_str): Change return type.
6090         * target.h (struct target_ops) <pid_to_str>: Change return type.
6091         (target_pid_to_str, normal_pid_to_str): Likewise.
6092         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6093         type.
6094         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6095         type.
6096         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6097         return type.
6098         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6099         type.
6100         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6101         type.
6102         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6103         return type.
6104
6105 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6106
6107         * NEWS: Mention that the new default MI version is 3.  Mention
6108         changes to the output of commands and events that deal with
6109         multi-location breakpoints.
6110         * breakpoint.c: Include "mi/mi-out.h".
6111         (print_one_breakpoint): Change output syntax if using MI version
6112         >= 3.
6113         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6114         New.
6115         (mi_multi_location_breakpoint_output_fixed): New.
6116         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6117         (mi_cmd_fix_multi_location_breakpoint_output): New.
6118         (mi_multi_location_breakpoint_output_fixed): New.
6119         * mi/mi-cmds.c (mi_cmds): Register command
6120         -fix-multi-location-breakpoint-output.
6121         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6122         interpreter "mi".
6123
6124 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6125
6126         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6127         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6128         instantiate mi_ui_out based on interpreter name.
6129         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6130         * mi/mi-main.c (mi_load_progress): Likewise.
6131
6132 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6133
6134         * NEWS: Combine separate "New targets" sections for 8.3.
6135
6136 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6137
6138         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6139         (ppcfbsd_init_abi): Install gdbarch
6140         "fetch_tls_load_module_address" and "get_thread_local_address"
6141         methods.
6142
6143 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6144
6145         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6146         (riscv_fbsd_init_abi): Install gdbarch
6147         "fetch_tls_load_module_address" and "get_thread_local_address"
6148         methods.
6149
6150 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6151
6152         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6153         (i386fbsd_init_abi): Install gdbarch
6154         "fetch_tls_load_module_address" and "get_thread_local_address"
6155         methods.
6156
6157 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6158
6159         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6160         (amd64fbsd_init_abi): Install gdbarch
6161         "fetch_tls_load_module_address" and "get_thread_local_address"
6162         methods.
6163
6164 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6165
6166         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6167         (struct fbsd_pspace_data): New type.
6168         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6169         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6170         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6171         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6172         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6173
6174 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6175
6176         * gdbtypes.c (lookup_struct_elt): New function.
6177         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6178         * gdbtypes.h (struct struct_elt): New type.
6179         (lookup_struct_elt): New prototype.
6180
6181 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6182
6183         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6184         remove disabled code block.
6185
6186 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6187
6188         * gdbarch.sh (get_thread_local_address): New method.
6189         * gdbarch.h, gdbarch.c: Regenerate.
6190         * target.c (target_translate_tls_address): Use
6191         gdbarch_get_thread_local_address if present instead of
6192         target::get_thread_local_address.
6193
6194 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6195
6196         * target.h (target::get_thread_local_address): Update comment.
6197
6198 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6199
6200         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6201         objfile->separate_debug_objfile_backlink if not NULL.
6202
6203 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6204
6205         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6206         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6207         (amd64bsd_store_inferior_registers): Likewise.
6208         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6209         Enable segment base registers.
6210         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6211         PT_GETFSBASE and PT_GETGSBASE.
6212         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6213         PT_SETGSBASE.
6214         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6215         segment base registers.
6216         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6217
6218 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6219
6220         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6221         Update calls to i386_target_description to add 'segments'
6222         parameter.
6223         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6224         add segment base registers.
6225         * arch/i386.c (i386_create_target_description): Add 'segments'
6226         parameter to enable segment base registers.
6227         * arch/i386.h (i386_create_target_description): Likewise.
6228         * features/i386/32bit-segments.xml: New file.
6229         * features/i386/32bit-segments.c: Generate.
6230         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6231         call to i386_target_description to add 'segments' parameter.
6232         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6233         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6234         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6235         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6236         if feature is present.
6237         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6238         Add 'segments' parameter to call to i386_target_description.
6239         (i386_target_description): Add 'segments' parameter to enable
6240         segment base registers.
6241         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6242         to call to i386_target_description.
6243         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6244         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6245         Define I386_NUM_REGS.
6246         (i386_target_description): Add 'segments' parameter to enable
6247         segment base registers.
6248
6249 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6250
6251         PR/24325
6252         * source-cache.c: #undef open and close, to avoid unresolved
6253         externals during linking.
6254
6255 2019-03-12  Tom Tromey  <tromey@adacore.com>
6256
6257         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6258         const.  Add initializers.
6259         (_initialize_remote): Don't initialize ptid globals.
6260
6261 2019-03-12  Pedro Alves  <palves@redhat.com>
6262
6263         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6264
6265 2019-03-12  Pedro Alves  <palves@redhat.com>
6266
6267         * cp-name-parser.y (main): Remove unused 'len' variable.
6268
6269 2019-03-12  Tom Tromey  <tromey@adacore.com>
6270
6271         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6272         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6273
6274 2019-03-12  Tom Tromey  <tromey@adacore.com>
6275
6276         * linux-nat.c (iterate_over_lwps): Update.
6277         (stop_callback): Remove parameter.
6278         (stop_wait_callback, detach_callback, resume_set_callback)
6279         (select_singlestep_lwp_callback, set_ignore_sigint)
6280         (status_callback, resumed_callback, resume_clear_callback)
6281         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6282         data parameter.
6283         (linux_nat_target::detach, linux_nat_target::resume)
6284         (linux_stop_and_wait_all_lwps, select_event_lwp)
6285         (linux_nat_filter_event, linux_nat_wait_1)
6286         (linux_nat_target::kill, linux_nat_target::stop)
6287         (linux_nat_target::stop): Update.
6288         (linux_nat_resume_callback): Change type.
6289         (resume_stopped_resumed_lwps, count_events_callback)
6290         (select_event_lwp_callback): Likewise.
6291         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6292         * arm-linux-nat.c (struct update_registers_data): Remove.
6293         (update_registers_callback): Change type.
6294         (arm_linux_insert_hw_breakpoint1): Update.
6295         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6296         parameter.
6297         (x86_linux_dr_set_addr): Update.
6298         (x86_linux_dr_set_control): Update.
6299         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6300         (iterate_over_lwps): Use gdb::function_view.
6301         * nat/aarch64-linux-hw-point.c (struct
6302         aarch64_dr_update_callback_param): Remove.
6303         (debug_reg_change_callback): Change type.
6304         (aarch64_notify_debug_reg_change): Update.
6305         * s390-linux-nat.c (s390_refresh_per_info): Update.
6306
6307 2019-03-11  Tom Tromey  <tromey@adacore.com>
6308
6309         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6310         redundant assignment to "this_cu".
6311
6312 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6313
6314         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6315
6316 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6317
6318         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6319         from...
6320         (rank_one_type): ... this.
6321
6322 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6323
6324         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6325         from...
6326         (rank_one_type): ... this.
6327
6328 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6329
6330         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6331         from...
6332         (rank_one_type): ... this.
6333
6334 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6335
6336         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6337         from...
6338         (rank_one_type): ... this.
6339
6340 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6341
6342         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6343         from...
6344         (rank_one_type): ... this.
6345
6346 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6347
6348         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6349         from...
6350         (rank_one_type): ... this.
6351
6352 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6353
6354         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6355         from...
6356         (rank_one_type): ... this.
6357
6358 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6359
6360         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6361         from...
6362         (rank_one_type): ... this.
6363
6364 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6365
6366         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6367         from...
6368         (rank_one_type): ... this.
6369
6370 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6371
6372         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6373         from...
6374         (rank_one_type): ... this.
6375
6376 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6377
6378         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6379         from...
6380         (rank_one_type): ... this.
6381
6382 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6383
6384         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6385         from...
6386         (rank_one_type): ... this.
6387
6388 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6389
6390         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6391         inferior-events' shows the example events.
6392
6393 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6394
6395         Support styling on native MS-Windows console
6396
6397         PR/24315
6398         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6399         on MS-Windows if $TERM is not defined.
6400
6401         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6402
6403         * posix-hdep.c (gdb_console_fputs):
6404         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6405         functions.
6406         * ui-file.h (gdb_console_fputs): Add prototype.
6407
6408         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6409         back to fputs only if the former returns zero.
6410
6411 2019-03-07  Tom Tromey  <tom@tromey.com>
6412
6413         * symmisc.c (print_symbol_bcache_statistics): Update.
6414         (print_objfile_statistics): Update.
6415         * symfile.c (allocate_symtab): Update.
6416         * stabsread.c: Don't include bcache.h.
6417         * psymtab.h (struct psymbol_bcache): Don't declare.
6418         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6419         (psymbol_bcache_init, psymbol_bcache_free)
6420         (psymbol_bcache_get_bcache): Don't declare.
6421         * psymtab.c (struct psymbol_bcache): Remove.
6422         (psymtab_storage::psymtab_storage): Update.
6423         (psymtab_storage::~psymtab_storage): Update.
6424         (psymbol_bcache_init, psymbol_bcache_free)
6425         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6426         (add_psymbol_to_bcache): Update.
6427         (allocate_psymtab): Update.
6428         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6429         macro_cache>: No longer pointers.
6430         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6431         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6432         * macrotab.c (macro_bcache): Update.
6433         * macroexp.c: Don't include bcache.h.
6434         * gdbtypes.c (check_types_worklist): Update.
6435         (types_deeply_equal): Remove TRY/CATCH.  Update.
6436         * elfread.c (elf_symtab_read): Update.
6437         * dwarf2read.c: Don't include bcache.h.
6438         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6439         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6440         (print_bcache_statistics, bcache_memory_used): Don't declare.
6441         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6442         methods.  Rename all data members.
6443         * bcache.c (struct bcache): Move to bcache.h.
6444         (bcache::expand_hash_table): Rename from expand_hash_table.
6445         (bcache): Remove.
6446         (bcache::insert): Rename from bcache_full.
6447         (bcache::compare): Rename from bcache_compare.
6448         (bcache_xmalloc): Remove.
6449         (bcache::~bcache): Rename from bcache_xfree.
6450         (bcache::print_statistics): Rename from print_bcache_statistics.
6451         (bcache::memory_used): Rename from bcache_memory_used.
6452
6453 2019-03-07  Pedro Alves  <palves@redhat.com>
6454
6455         * infrun.c (normal_stop): Also check for
6456         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6457
6458 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6459
6460         * f-lang.c (value_from_host_double): Moved to...
6461         * value.c (value_from_host_double): ...here.
6462         * value.h (value_from_host_double): Declare.
6463         * guile/scm-math.c (vlscm_convert_typed_number): Use
6464         value_from_host_double.
6465         (vlscm_convert_number): Likewise.
6466         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6467         * python/py-value.c (convert_value_from_python): Likewise.
6468
6469 2019-03-06  Tom Tromey  <tom@tromey.com>
6470
6471         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6472
6473 2019-03-06  Tom Tromey  <tom@tromey.com>
6474
6475         * utils.h (free_current_contents): Don't declare.
6476         * utils.c (free_current_contents): Remove.
6477
6478 2019-03-06  Tom Tromey  <tom@tromey.com>
6479
6480         * top.c (quit_force): Update.
6481         * main.c (captured_command_loop): Update.
6482         * common/new-op.c (operator new): Update.
6483         * common/common-exceptions.c (struct catcher)
6484         <save_cleanup_chain>: Remove member.
6485         (exceptions_state_mc_init): Update.
6486         (exception_try_scope_entry): Return nullptr.
6487         (exception_try_scope_exit, exception_rethrow)
6488         (throw_exception_sjlj, throw_exception_cxx): Update.
6489         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6490         (all_cleanups, do_cleanups, discard_cleanups)
6491         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6492         (restore_cleanups, restore_final_cleanups): Don't declare.
6493         (do_final_cleanups): Remove parameter.
6494         * common/cleanups.c (cleanup_chain, make_cleanup)
6495         (make_cleanup_dtor, all_cleanups, do_cleanups)
6496         (discard_my_cleanups, discard_cleanups)
6497         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6498         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6499         (null_cleanup): Remove.
6500         (do_final_cleanups): Remove parameter.
6501
6502 2019-03-06  Tom Tromey  <tom@tromey.com>
6503
6504         * remote.c (remote_target::remote_parse_stop_reply): Use
6505         unique_xmalloc_ptr.
6506
6507 2019-03-06  Tom Tromey  <tom@tromey.com>
6508
6509         * stabsread.c (struct stabs_field_info): Rename from field_info.
6510         <list, fnlist>: Add initializers.
6511         <obstack>: New member.
6512         (read_member_functions, read_struct_fields, read_baseclasses):
6513         Allocate on obstack.  Don't use cleanups.
6514         (read_one_struct_field, read_member_functions, read_struct_fields)
6515         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6516         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6517         (read_struct_type): Update.
6518
6519 2019-03-06  Tom Tromey  <tom@tromey.com>
6520
6521         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6522         * common/filestuff.h (make_cleanup_close): Don't declare.
6523         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6524         Remove.
6525
6526 2019-03-06  Tom Tromey  <tom@tromey.com>
6527
6528         * solib-aix.c: Use make_scope_exit.
6529
6530 2019-03-06  Tom Tromey  <tom@tromey.com>
6531
6532         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6533         Use make_scope_exit.
6534
6535 2019-03-06  Tom Tromey  <tom@tromey.com>
6536
6537         * solib-svr4.c (disable_probes_interface): Remove parameter.
6538         (svr4_handle_solib_event): Use make_scope_exit.
6539
6540 2019-03-06  Tom Tromey  <tom@tromey.com>
6541
6542         * remote.c (struct stop_reply_deleter): Remove.
6543         (stop_reply_up): Update.
6544         (struct stop_reply): Derive from notif_event.  Don't typedef.
6545         <regcache>: Now a std::vector.
6546         (stop_reply_xfree): Remove.
6547         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6548         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6549         (remote_target::discard_pending_stop_replies): Use delete.
6550         (remote_target::remote_parse_stop_reply): Update.
6551         (remote_target::process_stop_reply): Update.
6552         * remote-notif.h (struct notif_event): Add virtual destructor.
6553         Remove "dtr" member.
6554         (struct notif_client) <alloc_event>: Return a unique_ptr.
6555         (notif_event_xfree): Don't declare.
6556         (notif_event_up): New typedef.
6557         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6558         (notif_event_xfree, do_notif_event_xfree): Remove.
6559         (remote_notif_state_xfree): Update.
6560
6561 2019-03-06  Tom Tromey  <tom@tromey.com>
6562
6563         * infrun.c (displaced_step_clear_cleanup): Now a
6564         forward_scope_exit type.
6565         (displaced_step_prepare_throw): Update.
6566         (displaced_step_fixup): Update.
6567
6568 2019-03-06  Tom Tromey  <tom@tromey.com>
6569
6570         * inferior.h (class inferior): Update comment.
6571         * gdbthread.h (class thread_info): Update comment.
6572
6573 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6574             Tom Tromey  <tom@tromey.com>
6575
6576         * stabsread.h (struct stab_section_list): Remove.
6577         (coffstab_build_psymtabs): Update.
6578         * dbxread.c (symbuf_sections): Now a std::vector.
6579         (sect_idx): New global.
6580         (fill_symbuf): Update.
6581         (coffstab_build_psymtabs): Change type of stabsects parameter.
6582         Update.
6583         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6584         std::vector.
6585         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6586         (coff_locate_sections): Update.
6587         (coff_symfile_read): Remove cleanups.  Update.
6588         (init_stringtab): Add storage parameter.
6589         (free_stringtab, free_stringtab_cleanup): Remove.
6590         (init_lineno): Add storage parameter.
6591         (free_linetab, free_linetab_cleanup): Remove.
6592
6593 2019-03-06  Pedro Alves  <palves@redhat.com>
6594
6595         * linux-fork.c (fork_info::clobber_regs): Delete.
6596         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6597         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6598         comment.  Adjust.
6599         (scoped_switch_fork_info::scoped_switch_fork_info)
6600         (checkpoint_command, linux_fork_context): Adjust
6601         fork_save_infrun_state calls.
6602
6603 2019-03-06  Pedro Alves  <palves@redhat.com>
6604
6605         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6606         (inf_has_multiple_threads): Return 'bool' and rewrite using
6607         inferior_info::threads().
6608
6609 2019-03-06  Pedro Alves  <palves@redhat.com>
6610
6611         * linux-fork.c: Include <list>.
6612         (fork_list): Now a std::list instance.
6613         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6614         (forks_exist_p, find_last_fork): Adjust.
6615         (new_fork): Delete.
6616         (one_fork_p): New.
6617         (add_fork): Adjust.
6618         (free_fork): Delete, folded into fork_info::~fork_info().
6619         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6620         Adjust.
6621         (init_fork_list): Delete.
6622         (linux_fork_killall, linux_fork_mourn_inferior)
6623         (linux_fork_detach, info_checkpoints_command): Adjust.
6624         (_initialize_linux_fork): No longer call init_fork_list.
6625
6626 2019-03-06  Pedro Alves  <palves@redhat.com>
6627
6628         * linux-fork.c (new_fork): New, split out of ...
6629         (add_fork): ... this.  Return void.  Move "first fork" special
6630         case from here, to ...
6631         (checkpoint_command): ... here.
6632         * linux-linux.h (add_fork): Return void.
6633
6634 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6635
6636         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6637
6638 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6639             Chris January  <chris.january@arm.com>
6640             David Lecomber  <david.lecomber@arm.com>
6641
6642         * f-exp.y: New token, UNOP_INTRINSIC.
6643         (exp): New pattern using UNOP_INTRINSIC token.
6644         (f77_keywords): Add 'abs' keyword.
6645         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6646         (value_from_host_double): New function.
6647         (evaluate_subexp_f): Support UNOP_ABS.
6648
6649 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6650
6651         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6652         types.
6653
6654 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6655
6656         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6657         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6658         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6659
6660 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6661
6662         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6663
6664 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6665             Chris January  <chris.january@arm.com>
6666
6667         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6668         * f-exp.y: Define 'KIND' token.
6669         (exp): New pattern for KIND expressions.
6670         (ptype): Handle types with a kind extension.
6671         (direct_abs_decl): Extend to spot kind extensions.
6672         (f77_keywords): Add 'kind' to the list.
6673         (push_kind_type): New function.
6674         (convert_to_kind_type): New function.
6675         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6676         * parse.c (operator_length_standard): Likewise.
6677         * parser-defs.h (enum type_pieces): Add tp_kind.
6678         * std-operator.def: Add UNOP_KIND.
6679
6680 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6681
6682         * f-exp.y (f_parse): Set yydebug.
6683
6684 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6685
6686         * f-lang.c (evaluate_subexp_f): New function.
6687         (exp_descriptor_f): New global.
6688         (f_language_defn): Use exp_descriptor_f instead of
6689         exp_descriptor_standard.
6690
6691 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6692
6693         * f-exp.y (struct token): Add comments.
6694         (dot_ops): Remove uppercase versions and the end marker.
6695         (f77_keywords): Likewise.
6696         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6697         entries in the dot_ops array are case insensitive, and use
6698         strncasecmp to compare strings.  Also some whitespace cleanup in
6699         this area.  Similar for the f77_keywords array, except entries in
6700         this list might be case sensitive.
6701
6702 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6703
6704         * f-exp.y (struct f77_boolean_val): Add comments.
6705         (boolean_values): Remove uppercase versions, and end marker.
6706         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6707         and use strncasecmp to achieve case insensitivity.  Additionally,
6708         perform whitespace cleanup around this code.
6709
6710 2019-03-06  Tom Tromey  <tromey@adacore.com>
6711
6712         * remote-sim.c (gdbsim_target_open): Use result of
6713         gdb_argv::release.
6714
6715 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6716         Dirk Schubert  <dirk.schubert@arm.com>
6717         Chris January  <chris.january@arm.com>
6718
6719         * eval.c (evaluate_subexp_standard): Call Fortran argument
6720         wrapping logic.
6721         * f-lang.c (struct value): A value which can be passed into a
6722         Fortran function call.
6723         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6724         where appropriate.
6725         (struct type): Value ready for a Fortran function call.
6726         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6727         is needed.
6728         * f-lang.h (fortran_argument_convert): Declaration.
6729         (fortran_preserve_arg_pointer): Declaration.
6730         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6731
6732 2019-03-05  Tom Tromey  <tromey@adacore.com>
6733
6734         * python/py-prettyprint.c (print_string_repr): Remove #if.
6735         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6736
6737 2019-03-05  Tom Tromey  <tromey@adacore.com>
6738
6739         * target.c (the_dummy_target): Move later.  Change type to
6740         "dummy_target".
6741         (initialize_targets): Don't initialize the_dummy_target.
6742
6743 2019-03-05  Tom Tromey  <tromey@adacore.com>
6744
6745         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6746         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6747
6748 2019-03-05  Tom Tromey  <tromey@adacore.com>
6749
6750         * windows-nat.c (windows_nat_target::attach)
6751         (windows_nat_target::detach): Don't call gdb_flush.
6752         * valprint.c (generic_val_print, val_print, val_print_string):
6753         Don't call gdb_flush.
6754         * utils.c (defaulted_query): Don't call gdb_flush.
6755         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6756         * target.c (target_announce_detach): Don't call gdb_flush.
6757         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6758         * remote.c (extended_remote_target::attach): Don't call
6759         gdb_flush.
6760         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6761         * printcmd.c (do_examine): Don't call gdb_flush.
6762         (info_display_command): Don't call gdb_flush.
6763         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6764         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6765         * memattr.c (info_mem_command): Don't call gdb_flush.
6766         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6767         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6768         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6769         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6770         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6771         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6772         (gnu_nat_target::detach): Don't call gdb_flush.
6773         * f-valprint.c (f_val_print): Don't call gdb_flush.
6774         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6775         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6776         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6777         gdb_flush.
6778         * c-valprint.c (c_val_print): Don't call gdb_flush.
6779         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6780
6781 2019-03-05  Tom Tromey  <tromey@adacore.com>
6782
6783         * varobj.c (update_dynamic_varobj_children): Update.
6784         (install_default_visualizer): Use reset, not release.
6785         * value.c (set_internalvar): Update.
6786         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6787         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6788         ATTRIBUTE_UNUSED_RESULT.
6789
6790 2019-03-05  Tom Tromey  <tromey@adacore.com>
6791
6792         * remote.c (class scoped_remote_fd) <release>: Add
6793         ATTRIBUTE_UNUSED_RESULT.
6794
6795 2019-03-05  Tom Tromey  <tromey@adacore.com>
6796
6797         * macroexp.c (struct macro_buffer) <release>: Add
6798         ATTRIBUTE_UNUSED_RESULT.
6799
6800 2019-03-05  Tom Tromey  <tromey@adacore.com>
6801
6802         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6803         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6804         ATTRIBUTE_UNUSED_RESULT.
6805
6806 2019-03-05  Tom Tromey  <tromey@adacore.com>
6807
6808         * common/scoped_fd.h (class scoped_fd) <release>: Add
6809         ATTRIBUTE_UNUSED_RESULT.
6810
6811 2019-03-05  Tom Tromey  <tromey@adacore.com>
6812
6813         * parser-defs.h (struct parser_state) <release>: Add
6814         ATTRIBUTE_UNUSED_RESULT.
6815
6816 2019-03-05  Tom Tromey  <tromey@adacore.com>
6817
6818         * utils.h (class gdb_argv) <release>: Add
6819         ATTRIBUTE_UNUSED_RESULT.
6820         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6821
6822 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6823
6824         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6825         for-loop range, to avoid compiler warnings.
6826
6827         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6828         avoid compiler warnings about unused variables.
6829
6830         * NEWS: Mention end of support for native debugging on MS-Windows
6831         before XP.
6832
6833         PR gdb/24292
6834         * common/netstuff.c:
6835         * gdbserver/gdbreplay.c
6836         * gdbserver/remote-utils.c:
6837         * ser-tcp.c:
6838         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6839         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6840         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6841         'getaddrinfo' and 'freeaddrinfo' were not available before
6842         Windows XP, and mingw.org's MinGW headers by default define
6843         _WIN32_WINNT to 0x500.
6844
6845 2019-03-01  Gary Benson <gbenson@redhat.com>
6846
6847         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6848
6849 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6850             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6851
6852         PR gdb/8527
6853         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6854         set_sigint_trap, clear_sigint_trap.
6855
6856 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6857
6858         * target.c (target_detach): Clear the regcache and the
6859         frame cache.
6860
6861 2019-02-27  Pedro Alves  <palves@redhat.com>
6862
6863         * utils.c (set_screen_size): When we cap the height/width sizes,
6864         tweak the corresponding command variable to show "unlimited":
6865
6866 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6867             Pedro Alves  <palves@redhat.com>
6868
6869         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6870         before calling rl_set_screen_size.
6871
6872 2019-02-27  Tom Tromey  <tromey@adacore.com>
6873
6874         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6875         define.
6876         * python/py-value.c: Remove Python 2.4 workaround.
6877         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6878         workaround.
6879         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6880         Python 2.4 workaround.
6881         * python/python-internal.h: Remove Python 2.4 comment.
6882         (Py_ssize_t): Don't define.
6883         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6884         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6885         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6886         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6887         * python/python.c (do_start_initialization): Remove Python 2.4
6888         workaround.
6889         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6890         (print_children): Remove Python 2.4 workaround.
6891         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6892         workaround.
6893         (CHARBUFFERPROC_NAME): Remove.
6894         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6895         Python 2.4 workaround.
6896
6897 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6898
6899         * NEWS: Note minimum Python version.
6900
6901 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6902
6903         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6904         code from these functions.  Remove corresponding ifdefs.  Use
6905         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6906         Remove gotos and target of gotos.
6907         (infpy_search_memory): Likewise.
6908
6909 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6910
6911         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6912         (hppa_gdbarch_init): Don't register deleted functions with
6913         gdbarch.
6914
6915 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6916
6917         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6918         (h8300_unwind_sp): Delete.
6919         (h8300_dummy_id): Delete.
6920         (h8300_gdbarch_init): Don't register deleted functions with
6921         gdbarch.
6922
6923 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6924
6925         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6926         (ft32_unwind_pc): Delete.
6927         (ft32_unwind_sp): Delete.
6928         (ft32_gdbarch_init): Don't register deleted functions with
6929         gdbarch.
6930
6931 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6932
6933         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6934         (frv_unwind_pc): Delete.
6935         (frv_unwind_sp): Delete.
6936         (frv_gdbarch_init): Don't register deleted functions with
6937         gdbarch.
6938
6939 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6940
6941         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6942         (riscv_unwind_pc): Delete.
6943         (riscv_unwind_sp): Delete.
6944         (riscv_gdbarch_init): Don't register deleted functions with
6945         gdbarch.
6946
6947 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6948
6949         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6950         (csky_unwind_pc): Delete.
6951         (csky_unwind_sp): Delete.
6952         (csky_gdbarch_init): Don't register deleted functions with
6953         gdbarch.
6954
6955 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6956
6957         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6958         (cris_unwind_pc): Delete.
6959         (cris_unwind_sp): Delete.
6960         (cris_gdbarch_init): Don't register deleted functions with
6961         gdbarch.
6962
6963 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6964
6965         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6966         (bfin_unwind_pc): Delete.
6967         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6968
6969 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6970
6971         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6972         (arm_unwind_pc): Delete.
6973         (arm_unwind_sp): Delete.
6974         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6975
6976 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6977
6978         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6979         (arc_unwind_pc): Delete.
6980         (arc_unwind_sp): Delete.
6981         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6982
6983 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6984
6985         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6986         (alpha_unwind_pc): Delete.
6987         (alpha_gdbarch_init): Don't register deleted functions with
6988         gdbarch.
6989
6990 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6991
6992         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6993         (aarch64_unwind_pc): Delete.
6994         (aarch64_unwind_sp): Delete.
6995         (aarch64_gdbarch_init): Don't register deleted functions with
6996         gdbarch.
6997
6998 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6999
7000         * gdbtypes.c (type_align): Don't consider static members when
7001         computing structure alignment.
7002
7003 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7004
7005         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7006         return 0 for other types.
7007         * arch-utils.c (default_type_align): Always return 0.
7008         * gdbarch.h: Regenerate.
7009         * gdbarch.sh (type_align): Extend comment.
7010         * gdbtypes.c (type_align): Add additional comments, always call
7011         gdbarch_type_align before applying the default rules.
7012         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7013         generic code will then apply a suitable default.
7014         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7015         types, return 0 for other types.
7016
7017 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7018
7019         * NEWS: Create a new section for the next release branch.
7020         Rename the section of the current branch, now that it has
7021         been cut.
7022
7023 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7024
7025         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7026         * version.in: Bump version to 8.3.50.DATE-git.
7027
7028 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7029
7030         * aix-thread.c (ptid_cmp): Remove unused variable.
7031         (get_signaled_thread): Likewise.
7032         (store_regs_user_thread): Likewise.
7033         (store_regs_kernel_thread): Likewise.
7034         (fetch_regs_kernel_thread): Remove shadowed variable.
7035
7036 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7037
7038         * features/riscv/32bit-cpu.xml: Add register numbers.
7039         * features/riscv/32bit-fpu.c: Regenerate.
7040         * features/riscv/32bit-fpu.xml: Add register numbers.
7041         * features/riscv/64bit-cpu.xml: Add register numbers.
7042         * features/riscv/64bit-fpu.c: Regenerate.
7043         * features/riscv/64bit-fpu.xml: Add register numbers.
7044
7045 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7046
7047         * NEWS: Mention two argument form of gdb.Value constructor.
7048         * python/py-value.c (convert_buffer_and_type_to_value): New
7049         function.
7050         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7051         Add support for handling an optional second argument.  Call
7052         convert_buffer_and_type_to_value as appropriate.
7053         * python/python-internal.h (Py_buffer_deleter): New struct.
7054         (Py_buffer_up): New typedef.
7055
7056 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7057
7058         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7059         instead of releasing ownership.
7060
7061 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7062
7063         * dwarf2read.c (open_and_init_dwp_file): Call
7064         elf_numsections instead of bfd_count_sections to initialize
7065         dwp_file->num_sections.
7066
7067 2019-02-25  Tom Tromey  <tromey@adacore.com>
7068
7069         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7070
7071 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7072
7073         * gcore.in: Add '--readnever' option when invoking GDB.
7074
7075 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7076
7077         * MAINTAINERS: Update my email address.
7078
7079 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7080
7081         * build-id.c (build_id_to_debug_bfd_1): New function.
7082         (build_id_to_debug_bfd): Look for separate debug file in
7083         sysroot.
7084
7085 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7086
7087         * gdbarch.sh: Update the copyright year range that is placed into
7088         generated files.
7089
7090 2019-02-22  Keith Seitz  <keiths@redhat.com>
7091
7092         PR symtab/23853
7093         * linespec.c (create_sals_line_offset): Search for the default
7094         symtab's filename instead of its fullname.
7095
7096 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7097
7098         * NEWS: Update style defaults.
7099
7100 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7101
7102         * main.c (captured_main_1): Disable styling in batch mode.
7103
7104 2019-02-20  Tom Tromey  <tom@tromey.com>
7105
7106         * symtab.c (symtab_symbol_info): Fix typos.
7107
7108 2019-02-20  Tom Tromey  <tromey@adacore.com>
7109
7110         * findcmd.c (_initialize_mem_search): Use upper case for
7111         metasyntactic variables.
7112
7113 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7114
7115         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7116         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7117
7118 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7119
7120         * top.h (source_file_name): Change to std::string.
7121         * top.c (source_file_name): Likewise.
7122         (command_line_input): Adjust.
7123         * cli/cli-script.c (script_from_file): Adjust.
7124
7125 2019-02-19  Tom Tromey  <tromey@adacore.com>
7126
7127         * ravenscar-thread.c
7128         (ravenscar_thread_target::update_thread_list): Don't call
7129         ada_build_task_list.
7130         * ada-lang.h (ada_build_task_list): Don't declare.
7131         * ada-tasks.c (struct ada_tasks_inferior_data)
7132         <task_list_valid_p>: Now bool.
7133         (read_known_tasks, ada_task_list_changed)
7134         (ada_tasks_invalidate_inferior_data): Update.
7135         (read_known_tasks_array): Return bool.
7136         (read_known_tasks_list): Likewise.
7137         (read_known_tasks): Return void.
7138         (ada_build_task_list): Now static.
7139
7140 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7141
7142         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7143         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7144
7145 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7146
7147         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7148         variant for ada_tasks_pspace_data_handle and
7149         ada_tasks_inferior_data_handle.
7150         (ada_tasks_pspace_data_cleanup): New function.
7151         (ada_tasks_inferior_data_cleanup): New function.
7152
7153 2019-02-17  Tom Tromey  <tom@tromey.com>
7154
7155         * macrotab.h (macro_source_fullname): Return a std::string.
7156         * macrotab.c (macro_include, check_for_redefinition)
7157         (macro_undef, macro_lookup_definition, foreach_macro)
7158         (foreach_macro_in_scope): Update.
7159         (macro_source_fullname): Return a std::string.
7160         * macrocmd.c (show_pp_source_pos): Update.
7161
7162 2019-02-17  Tom Tromey  <tom@tromey.com>
7163
7164         * macrocmd.c (show_pp_source_pos): Style the file names.
7165
7166 2019-02-17  Tom Tromey  <tom@tromey.com>
7167
7168         PR tui/24197:
7169         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7170
7171 2019-02-17  Tom Tromey  <tom@tromey.com>
7172
7173         * ada-lang.c (user_select_syms): Use filtered printing.
7174         * utils.c (wrap_style): New global.
7175         (desired_style): Remove.
7176         (emit_style_escape): Add stream parameter.
7177         (set_output_style, reset_terminal_style, prompt_for_continue):
7178         Update.
7179         (flush_wrap_buffer): Only flush gdb_stdout.
7180         (wrap_here): Set wrap_style.
7181         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7182         treat escape sequences as a character.  Change when wrap buffer is
7183         flushed.
7184         (fputs_styled): Do not set the output style when the default is
7185         requested.
7186         * ui-style.h (struct ui_file_style) <is_default>: New method.
7187         * source.c (print_source_lines_base): Emit escape sequences in one
7188         piece.
7189
7190 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7191
7192         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7193         integers and enumeration types.
7194
7195 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7196
7197         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7198         instead of lookup_symbol_in_language
7199         (do_exact_match): New function.
7200         (ada_get_symbol_name_matcher): Return do_exact_match when
7201         doing a verbatim match.
7202
7203 2019-02-15  Tom Tromey  <tromey@adacore.com>
7204
7205         * ravenscar-thread.c (ravenscar_thread_target::resume)
7206         (ravenscar_thread_target::wait): Special case wildcard requests.
7207
7208 2019-02-15  Tom Tromey  <tromey@adacore.com>
7209
7210         * ravenscar-thread.c (base_ptid): Remove.
7211         (struct ravenscar_thread_target) <close>: New method.
7212         <m_base_ptid>: New member.
7213         <update_inferior_ptid, active_task, task_is_currently_active,
7214         runtime_initialized>: Declare methods.
7215         <ravenscar_thread_target>: Add constructor.
7216         (ravenscar_thread_target::task_is_currently_active)
7217         (ravenscar_thread_target::update_inferior_ptid)
7218         (ravenscar_runtime_initialized): Rename.  Now methods.
7219         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7220         (ravenscar_thread_target::update_thread_list): Update.
7221         (ravenscar_thread_target::active_task): Now method.
7222         (ravenscar_thread_target::store_registers)
7223         (ravenscar_thread_target::prepare_to_store)
7224         (ravenscar_thread_target::prepare_to_store)
7225         (ravenscar_thread_target::mourn_inferior): Update.
7226         (ravenscar_inferior_created): Use "new" to create target.
7227         (ravenscar_thread_target::get_ada_task_ptid): Update.
7228         (_initialize_ravenscar): Don't initialize base_ptid.
7229         (ravenscar_ops): Remove global.
7230
7231 2019-02-15  Tom Tromey  <tromey@adacore.com>
7232
7233         * target.h (push_target): Declare new overload.
7234         * target.c (push_target): New overload, taking an rvalue reference.
7235         * remote.c (remote_target::open_1): Use push_target overload.
7236         * corelow.c (core_target_open): Use push_target overload.
7237
7238 2019-02-15  Tom Tromey  <tromey@adacore.com>
7239
7240         * ravenscar-thread.c (is_ravenscar_task)
7241         (ravenscar_task_is_currently_active): Return bool.
7242         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7243         (_initialize_ravenscar): Remove "(void)".
7244         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7245         Return bool.
7246
7247 2019-02-15  Tom Tromey  <tromey@adacore.com>
7248
7249         * ravenscar-thread.c (ravenscar_runtime_initializer)
7250         (has_ravenscar_runtime, get_running_thread_id)
7251         (ravenscar_thread_target::resume): Fix indentation.
7252
7253 2019-02-15  Tom Tromey  <tromey@adacore.com>
7254
7255         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7256         from ravenscar_arch_ops.
7257         (sparc_ravenscar_ops::fetch_registers)
7258         (sparc_ravenscar_ops::store_registers): Now methods.
7259         (sparc_ravenscar_prepare_to_store): Remove.
7260         (sparc_ravenscar_ops): Redefine.
7261         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7262         methods and destructor.  Remove members.
7263         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7264         (ravenscar_thread_target::store_registers)
7265         (ravenscar_thread_target::prepare_to_store): Update.
7266         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7267         Remove.
7268         (struct ppc_ravenscar_powerpc_ops): Derive from
7269         ravenscar_arch_ops.
7270         (ppc_ravenscar_powerpc_ops::fetch_registers)
7271         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7272         (ppc_ravenscar_powerpc_ops): Redefine.
7273         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7274         (ppc_ravenscar_e500_ops::fetch_registers)
7275         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7276         (ppc_ravenscar_e500_ops): Redefine.
7277         * aarch64-ravenscar-thread.c
7278         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7279         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7280         (aarch64_ravenscar_fetch_registers)
7281         (aarch64_ravenscar_store_registers): Now methods.
7282         (aarch64_ravenscar_ops): Redefine.
7283
7284 2019-02-15  Tom Tromey  <tromey@adacore.com>
7285
7286         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7287         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7288         (ravenscar_thread_target::stopped_by_watchpoint)
7289         (ravenscar_thread_target::stopped_data_address)
7290         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7291
7292 2019-02-15  Tom Tromey  <tromey@adacore.com>
7293
7294         * ravenscar-thread.c: Fix some typos.
7295
7296 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7297             Tom Tromey  <tromey@adacore.com>
7298
7299         * ada-lang.c (ada_exception_sal): Change addr_string to a
7300         std::string.
7301         (create_ada_exception_catchpoint): Update.
7302
7303 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7304             Tom Tromey  <tromey@adacore.com>
7305
7306         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7307         (bp_location_ops): Remove.
7308         (base_breakpoint_allocate_location): Update.
7309         (free_bp_location): Update.
7310         * ada-lang.c (class ada_catchpoint_location)
7311         <ada_catchpoint_location>: Remove ops parameter.
7312         (ada_catchpoint_location_dtor): Remove.
7313         (ada_catchpoint_location_ops): Remove.
7314         (allocate_location_exception): Update.
7315         * breakpoint.h (struct bp_location_ops): Remove.
7316         (class bp_location) <bp_location>: Remove bp_location_ops
7317         parameter.
7318         <~bp_location>: Add destructor.
7319         <ops>: Remove.
7320
7321 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7322             Pedro Alves  <palves@redhat.com>
7323
7324         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7325         'PATH_MAX'.
7326
7327 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7328             Samuel Thibault  <samuel.thibault@gnu.org>
7329             Thomas Schwinge  <thomas@codesourcery.com>
7330
7331         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7332         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7333
7334 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7335
7336         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7337         (check_empty): Use "const char *".
7338
7339         * gnu-nat.c (gnu_nat_target::detach): Instead of
7340         'detach_inferior (pid)' call
7341         'detach_inferior (find_inferior_pid (pid))'.
7342
7343         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7344         'nat/fork-inferior.o'.
7345         * gnu-nat.c: #include "nat/fork-inferior.h".
7346
7347         * gnu-nat.c (gnu_nat_target::detach): Instead of
7348         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7349         * gnu-nat.h: #include "inf-child.h".
7350         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7351         'i386_gnu_nat_target::fetch_registers'.
7352         (gnu_store_registers): Rename/move to
7353         'i386_gnu_nat_target::store_registers'.
7354
7355         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7356         * gnu-nat.h (mach_thread_info): New function.
7357         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7358
7359         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7360
7361 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7362
7363         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7364
7365 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7366
7367         * windows-nat.c (windows_add_thread): Add new parameter
7368         "main_thread_p" with default value set to false.  Update
7369         function documentation as well as all callers.
7370         (windows_delete_thread): Likewise.
7371         (fake_create_process): Update call to windows_add_thread.
7372         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7373         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7374         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7375         call to windows_delete_thread.
7376
7377 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7378
7379         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7380
7381 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7382
7383         * symfile.c (find_separate_debug_file): Use canonical path of
7384         sysroot with child_path instead of gdb_sysroot if it is valid.
7385
7386 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7387
7388         * symfile.c (find_separate_debug_file): Use child_path to
7389         determine if an object file is under a sysroot.
7390
7391 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7392
7393         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7394         unittests/child-path-selftests.c.
7395         * common/pathstuff.c (child_path): New function.
7396         * common/pathstuff.h (child_path): New prototype.
7397         * unittests/child-path-selftests.c: New file.
7398
7399 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7400
7401         * symfile.c (find_separate_debug_file): Look for separate debug
7402         files in debug directories under the sysroot.
7403
7404 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7405
7406         * symtab.h (struct minimal_symbol data_p): New const method.
7407         (struct minimal_symbol text_p): Likewise.
7408         * symtab.c (output_source_filename): Use file name style
7409         to print file name.
7410         (print_symbol_info): Likewise.
7411         (print_msymbol_info): Use address style to print addresses.
7412         Use function name style to print executable text symbols.
7413         (expand_symtab_containing_pc): Use data_p.
7414         (find_pc_sect_compunit_symtab): Likewise.
7415
7416 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7417
7418         * breakpoint.c (describe_other_breakpoints): Use address style
7419         to print addresses.
7420         (say_where): Likewise.
7421
7422 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7423
7424         * ada-typeprint.c (print_func_type): Print function name
7425         style to print function name.
7426         * c-typeprint.c (c_print_type_1): Likewise.
7427
7428 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7429
7430         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7431         for execve.
7432
7433 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7434
7435         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7436         type_stack.
7437
7438 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7439
7440         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7441         TYPE_CODE_REF types.
7442
7443 2019-02-08  Jim Wilson  <jimw@sifive.com>
7444
7445         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7446         (riscv_linux_fregset): New.
7447         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7448
7449 2019-02-07  Tom Tromey  <tom@tromey.com>
7450
7451         * thread.c (thread_cancel_execution_command): Update.
7452         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7453         methods.
7454         (struct thread_fsm_ops): Remove.
7455         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7456         (thread_fsm_should_stop, thread_fsm_return_value)
7457         (thread_fsm_set_finished, thread_fsm_finished_p)
7458         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7459         Don't declare.
7460         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7461         * infrun.c (clear_proceed_status_thread)
7462         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7463         (print_stop_event): Update.
7464         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7465         Add constructor.
7466         (step_command_fsm_ops): Remove.
7467         (new_step_command_fsm): Remove.
7468         (step_1): Update.
7469         (step_command_fsm::should_stop): Rename from
7470         step_command_fsm_should_stop.
7471         (step_command_fsm::clean_up): Rename from
7472         step_command_fsm_clean_up.
7473         (step_command_fsm::do_async_reply_reason): Rename from
7474         step_command_fsm_async_reply_reason.
7475         (struct until_next_fsm): Inherit from thread_fsm.  Add
7476         constructor.
7477         (until_next_fsm_ops): Remove.
7478         (new_until_next_fsm): Remove.
7479         (until_next_fsm::should_stop): Rename from
7480         until_next_fsm_should_stop.
7481         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7482         (until_next_fsm::do_async_reply_reason): Rename from
7483         until_next_fsm_async_reply_reason.
7484         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7485         constructor.  Change type of breakpoint.
7486         (finish_command_fsm_ops): Remove.
7487         (new_finish_command_fsm): Remove.
7488         (finish_command_fsm::should_stop): Rename from
7489         finish_command_fsm_should_stop.
7490         (finish_command_fsm::clean_up): Rename from
7491         finish_command_fsm_clean_up.
7492         (finish_command_fsm::return_value): Rename from
7493         finish_command_fsm_return_value.
7494         (finish_command_fsm::do_async_reply_reason): Rename from
7495         finish_command_fsm_async_reply_reason.
7496         (finish_command): Update.
7497         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7498         Add constructor.
7499         (call_thread_fsm_ops): Remove.
7500         (call_thread_fsm::call_thread_fsm): Rename from
7501         new_call_thread_fsm.
7502         (call_thread_fsm::should_stop): Rename from
7503         call_thread_fsm_should_stop.
7504         (call_thread_fsm::should_notify_stop): Rename from
7505         call_thread_fsm_should_notify_stop.
7506         (run_inferior_call, call_function_by_hand_dummy): Update.
7507         * cli/cli-interp.c (should_print_stop_to_console): Update.
7508         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7509         Add constructor.  Change type of location_breakpoint,
7510         caller_breakpoint.
7511         (until_break_fsm_ops): Remove.
7512         (new_until_break_fsm): Remove.
7513         (until_break_fsm::should_stop): Rename from
7514         until_break_fsm_should_stop.
7515         (until_break_fsm::clean_up): Rename from
7516         until_break_fsm_clean_up.
7517         (until_break_fsm::do_async_reply_reason): Rename from
7518         until_break_fsm_async_reply_reason.
7519         (until_break_command): Update.
7520         * thread-fsm.c: Remove.
7521         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7522
7523 2019-02-07  Tom Tromey  <tom@tromey.com>
7524
7525         * yy-remap.h: Add include guard.
7526         * xtensa-tdep.h: Add include guard.
7527         * xcoffread.h: Rename include guard.
7528         * varobj-iter.h: Add include guard.
7529         * tui/tui.h: Rename include guard.
7530         * tui/tui-winsource.h: Rename include guard.
7531         * tui/tui-wingeneral.h: Rename include guard.
7532         * tui/tui-windata.h: Rename include guard.
7533         * tui/tui-win.h: Rename include guard.
7534         * tui/tui-stack.h: Rename include guard.
7535         * tui/tui-source.h: Rename include guard.
7536         * tui/tui-regs.h: Rename include guard.
7537         * tui/tui-out.h: Rename include guard.
7538         * tui/tui-layout.h: Rename include guard.
7539         * tui/tui-io.h: Rename include guard.
7540         * tui/tui-hooks.h: Rename include guard.
7541         * tui/tui-file.h: Rename include guard.
7542         * tui/tui-disasm.h: Rename include guard.
7543         * tui/tui-data.h: Rename include guard.
7544         * tui/tui-command.h: Rename include guard.
7545         * tic6x-tdep.h: Add include guard.
7546         * target/waitstatus.h: Rename include guard.
7547         * target/wait.h: Rename include guard.
7548         * target/target.h: Rename include guard.
7549         * target/resume.h: Rename include guard.
7550         * target-float.h: Rename include guard.
7551         * stabsread.h: Add include guard.
7552         * rs6000-tdep.h: Add include guard.
7553         * riscv-fbsd-tdep.h: Add include guard.
7554         * regformats/regdef.h: Rename include guard.
7555         * record.h: Rename include guard.
7556         * python/python.h: Rename include guard.
7557         * python/python-internal.h: Rename include guard.
7558         * python/py-stopevent.h: Rename include guard.
7559         * python/py-ref.h: Rename include guard.
7560         * python/py-record.h: Rename include guard.
7561         * python/py-record-full.h: Rename include guard.
7562         * python/py-record-btrace.h: Rename include guard.
7563         * python/py-instruction.h: Rename include guard.
7564         * python/py-events.h: Rename include guard.
7565         * python/py-event.h: Rename include guard.
7566         * procfs.h: Add include guard.
7567         * proc-utils.h: Add include guard.
7568         * p-lang.h: Add include guard.
7569         * or1k-tdep.h: Rename include guard.
7570         * observable.h: Rename include guard.
7571         * nto-tdep.h: Rename include guard.
7572         * nat/x86-linux.h: Rename include guard.
7573         * nat/x86-linux-dregs.h: Rename include guard.
7574         * nat/x86-gcc-cpuid.h: Add include guard.
7575         * nat/x86-dregs.h: Rename include guard.
7576         * nat/x86-cpuid.h: Rename include guard.
7577         * nat/ppc-linux.h: Rename include guard.
7578         * nat/mips-linux-watch.h: Rename include guard.
7579         * nat/linux-waitpid.h: Rename include guard.
7580         * nat/linux-ptrace.h: Rename include guard.
7581         * nat/linux-procfs.h: Rename include guard.
7582         * nat/linux-osdata.h: Rename include guard.
7583         * nat/linux-nat.h: Rename include guard.
7584         * nat/linux-namespaces.h: Rename include guard.
7585         * nat/linux-btrace.h: Rename include guard.
7586         * nat/glibc_thread_db.h: Rename include guard.
7587         * nat/gdb_thread_db.h: Rename include guard.
7588         * nat/gdb_ptrace.h: Rename include guard.
7589         * nat/fork-inferior.h: Rename include guard.
7590         * nat/amd64-linux-siginfo.h: Rename include guard.
7591         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7592         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7593         * nat/aarch64-linux.h: Rename include guard.
7594         * nat/aarch64-linux-hw-point.h: Rename include guard.
7595         * mn10300-tdep.h: Add include guard.
7596         * mips-linux-tdep.h: Add include guard.
7597         * mi/mi-parse.h: Rename include guard.
7598         * mi/mi-out.h: Rename include guard.
7599         * mi/mi-main.h: Rename include guard.
7600         * mi/mi-interp.h: Rename include guard.
7601         * mi/mi-getopt.h: Rename include guard.
7602         * mi/mi-console.h: Rename include guard.
7603         * mi/mi-common.h: Rename include guard.
7604         * mi/mi-cmds.h: Rename include guard.
7605         * mi/mi-cmd-break.h: Rename include guard.
7606         * m2-lang.h: Add include guard.
7607         * location.h: Rename include guard.
7608         * linux-record.h: Rename include guard.
7609         * linux-nat.h: Add include guard.
7610         * linux-fork.h: Add include guard.
7611         * i386-darwin-tdep.h: Rename include guard.
7612         * hppa-linux-offsets.h: Add include guard.
7613         * guile/guile.h: Rename include guard.
7614         * guile/guile-internal.h: Rename include guard.
7615         * gnu-nat.h: Rename include guard.
7616         * gdb-stabs.h: Rename include guard.
7617         * frv-tdep.h: Add include guard.
7618         * f-lang.h: Add include guard.
7619         * event-loop.h: Add include guard.
7620         * darwin-nat.h: Rename include guard.
7621         * cp-abi.h: Rename include guard.
7622         * config/sparc/nm-sol2.h: Rename include guard.
7623         * config/nm-nto.h: Rename include guard.
7624         * config/nm-linux.h: Add include guard.
7625         * config/i386/nm-i386gnu.h: Rename include guard.
7626         * config/djgpp/nl_types.h: Rename include guard.
7627         * config/djgpp/langinfo.h: Rename include guard.
7628         * compile/gcc-cp-plugin.h: Add include guard.
7629         * compile/gcc-c-plugin.h: Add include guard.
7630         * compile/compile.h: Rename include guard.
7631         * compile/compile-object-run.h: Rename include guard.
7632         * compile/compile-object-load.h: Rename include guard.
7633         * compile/compile-internal.h: Rename include guard.
7634         * compile/compile-cplus.h: Rename include guard.
7635         * compile/compile-c.h: Rename include guard.
7636         * common/xml-utils.h: Rename include guard.
7637         * common/x86-xstate.h: Rename include guard.
7638         * common/version.h: Rename include guard.
7639         * common/vec.h: Rename include guard.
7640         * common/tdesc.h: Rename include guard.
7641         * common/selftest.h: Rename include guard.
7642         * common/scoped_restore.h: Rename include guard.
7643         * common/scoped_mmap.h: Rename include guard.
7644         * common/scoped_fd.h: Rename include guard.
7645         * common/safe-iterator.h: Rename include guard.
7646         * common/run-time-clock.h: Rename include guard.
7647         * common/refcounted-object.h: Rename include guard.
7648         * common/queue.h: Rename include guard.
7649         * common/ptid.h: Rename include guard.
7650         * common/print-utils.h: Rename include guard.
7651         * common/preprocessor.h: Rename include guard.
7652         * common/pathstuff.h: Rename include guard.
7653         * common/observable.h: Rename include guard.
7654         * common/netstuff.h: Rename include guard.
7655         * common/job-control.h: Rename include guard.
7656         * common/host-defs.h: Rename include guard.
7657         * common/gdb_wait.h: Rename include guard.
7658         * common/gdb_vecs.h: Rename include guard.
7659         * common/gdb_unlinker.h: Rename include guard.
7660         * common/gdb_unique_ptr.h: Rename include guard.
7661         * common/gdb_tilde_expand.h: Rename include guard.
7662         * common/gdb_sys_time.h: Rename include guard.
7663         * common/gdb_string_view.h: Rename include guard.
7664         * common/gdb_splay_tree.h: Rename include guard.
7665         * common/gdb_setjmp.h: Rename include guard.
7666         * common/gdb_ref_ptr.h: Rename include guard.
7667         * common/gdb_optional.h: Rename include guard.
7668         * common/gdb_locale.h: Rename include guard.
7669         * common/gdb_assert.h: Rename include guard.
7670         * common/filtered-iterator.h: Rename include guard.
7671         * common/filestuff.h: Rename include guard.
7672         * common/fileio.h: Rename include guard.
7673         * common/environ.h: Rename include guard.
7674         * common/common-utils.h: Rename include guard.
7675         * common/common-types.h: Rename include guard.
7676         * common/common-regcache.h: Rename include guard.
7677         * common/common-inferior.h: Rename include guard.
7678         * common/common-gdbthread.h: Rename include guard.
7679         * common/common-exceptions.h: Rename include guard.
7680         * common/common-defs.h: Rename include guard.
7681         * common/common-debug.h: Rename include guard.
7682         * common/cleanups.h: Rename include guard.
7683         * common/buffer.h: Rename include guard.
7684         * common/btrace-common.h: Rename include guard.
7685         * common/break-common.h: Rename include guard.
7686         * cli/cli-utils.h: Rename include guard.
7687         * cli/cli-style.h: Rename include guard.
7688         * cli/cli-setshow.h: Rename include guard.
7689         * cli/cli-script.h: Rename include guard.
7690         * cli/cli-interp.h: Rename include guard.
7691         * cli/cli-decode.h: Rename include guard.
7692         * cli/cli-cmds.h: Rename include guard.
7693         * charset-list.h: Add include guard.
7694         * buildsym-legacy.h: Rename include guard.
7695         * bfin-tdep.h: Add include guard.
7696         * ax.h: Rename include guard.
7697         * arm-linux-tdep.h: Add include guard.
7698         * arm-fbsd-tdep.h: Add include guard.
7699         * arch/xtensa.h: Rename include guard.
7700         * arch/tic6x.h: Add include guard.
7701         * arch/i386.h: Add include guard.
7702         * arch/arm.h: Rename include guard.
7703         * arch/arm-linux.h: Rename include guard.
7704         * arch/arm-get-next-pcs.h: Rename include guard.
7705         * arch/amd64.h: Add include guard.
7706         * arch/aarch64-insn.h: Rename include guard.
7707         * arch-utils.h: Rename include guard.
7708         * annotate.h: Add include guard.
7709         * amd64-darwin-tdep.h: Rename include guard.
7710         * aarch64-linux-tdep.h: Add include guard.
7711         * aarch64-fbsd-tdep.h: Add include guard.
7712         * aarch32-linux-nat.h: Add include guard.
7713
7714 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7715
7716         * macrotab.c (macro_define_internal): New function that
7717         factorizes macro_define_object_internal and macro_define_function
7718         code.
7719         (macro_define_object_internal): Use macro_define_internal.
7720         (macro_define_function): Likewise.
7721
7722 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7723
7724         * macrocmd.c (extract_identifier): Return
7725         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7726         callers.
7727
7728 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7729
7730         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7731
7732 2019-02-05  Tom Tromey  <tom@tromey.com>
7733
7734         * target.c (target_stack::unpush): Move assertion earlier.
7735
7736 2019-01-30  Tom Tromey  <tom@tromey.com>
7737
7738         PR python/23615:
7739         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7740         (gdbpy_parse_and_eval): Likewise.
7741         * python/python-internal.h (gdbpy_allow_threads): New class.
7742
7743 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7744
7745         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7746         (aarch64_fbsd_fpregmap): Move earlier.
7747         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7748         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7749         instead of individual calls to trad_frame_set_reg_addr.
7750         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7751         earlier.
7752         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7753         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7754         instead of individual calls to trad_frame_set_reg_addr.
7755
7756 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7757
7758         * CONTRIBUTE: Replace contribution list with wiki link.
7759
7760 2019-01-25  Tom Tromey  <tom@tromey.com>
7761
7762         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7763
7764 2019-01-25  Tom Tromey  <tom@tromey.com>
7765
7766         * xtensa-linux-nat.c: Fix common/ includes.
7767         * xml-support.h: Fix common/ includes.
7768         * xml-support.c: Fix common/ includes.
7769         * x86-linux-nat.c: Fix common/ includes.
7770         * windows-nat.c: Fix common/ includes.
7771         * varobj.h: Fix common/ includes.
7772         * varobj.c: Fix common/ includes.
7773         * value.c: Fix common/ includes.
7774         * valops.c: Fix common/ includes.
7775         * utils.c: Fix common/ includes.
7776         * unittests/xml-utils-selftests.c: Fix common/ includes.
7777         * unittests/utils-selftests.c: Fix common/ includes.
7778         * unittests/unpack-selftests.c: Fix common/ includes.
7779         * unittests/tracepoint-selftests.c: Fix common/ includes.
7780         * unittests/style-selftests.c: Fix common/ includes.
7781         * unittests/string_view-selftests.c: Fix common/ includes.
7782         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7783         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7784         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7785         * unittests/rsp-low-selftests.c: Fix common/ includes.
7786         * unittests/parse-connection-spec-selftests.c: Fix common/
7787         includes.
7788         * unittests/optional-selftests.c: Fix common/ includes.
7789         * unittests/offset-type-selftests.c: Fix common/ includes.
7790         * unittests/observable-selftests.c: Fix common/ includes.
7791         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7792         * unittests/memrange-selftests.c: Fix common/ includes.
7793         * unittests/memory-map-selftests.c: Fix common/ includes.
7794         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7795         * unittests/function-view-selftests.c: Fix common/ includes.
7796         * unittests/environ-selftests.c: Fix common/ includes.
7797         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7798         * unittests/common-utils-selftests.c: Fix common/ includes.
7799         * unittests/cli-utils-selftests.c: Fix common/ includes.
7800         * unittests/array-view-selftests.c: Fix common/ includes.
7801         * ui-file.c: Fix common/ includes.
7802         * tui/tui-io.c: Fix common/ includes.
7803         * tracepoint.h: Fix common/ includes.
7804         * tracepoint.c: Fix common/ includes.
7805         * tracefile-tfile.c: Fix common/ includes.
7806         * top.h: Fix common/ includes.
7807         * top.c: Fix common/ includes.
7808         * thread.c: Fix common/ includes.
7809         * target/waitstatus.h: Fix common/ includes.
7810         * target/waitstatus.c: Fix common/ includes.
7811         * target.h: Fix common/ includes.
7812         * target.c: Fix common/ includes.
7813         * target-memory.c: Fix common/ includes.
7814         * target-descriptions.c: Fix common/ includes.
7815         * symtab.h: Fix common/ includes.
7816         * symfile.c: Fix common/ includes.
7817         * stap-probe.c: Fix common/ includes.
7818         * spu-linux-nat.c: Fix common/ includes.
7819         * sparc-nat.c: Fix common/ includes.
7820         * source.c: Fix common/ includes.
7821         * solib.c: Fix common/ includes.
7822         * solib-target.c: Fix common/ includes.
7823         * ser-unix.c: Fix common/ includes.
7824         * ser-tcp.c: Fix common/ includes.
7825         * ser-pipe.c: Fix common/ includes.
7826         * ser-base.c: Fix common/ includes.
7827         * selftest-arch.c: Fix common/ includes.
7828         * s12z-tdep.c: Fix common/ includes.
7829         * rust-exp.y: Fix common/ includes.
7830         * rs6000-aix-tdep.c: Fix common/ includes.
7831         * riscv-tdep.c: Fix common/ includes.
7832         * remote.c: Fix common/ includes.
7833         * remote-notif.h: Fix common/ includes.
7834         * remote-fileio.h: Fix common/ includes.
7835         * remote-fileio.c: Fix common/ includes.
7836         * regcache.h: Fix common/ includes.
7837         * regcache.c: Fix common/ includes.
7838         * record-btrace.c: Fix common/ includes.
7839         * python/python.c: Fix common/ includes.
7840         * python/py-type.c: Fix common/ includes.
7841         * python/py-inferior.c: Fix common/ includes.
7842         * progspace.h: Fix common/ includes.
7843         * producer.c: Fix common/ includes.
7844         * procfs.c: Fix common/ includes.
7845         * proc-api.c: Fix common/ includes.
7846         * printcmd.c: Fix common/ includes.
7847         * ppc-linux-nat.c: Fix common/ includes.
7848         * parser-defs.h: Fix common/ includes.
7849         * osdata.c: Fix common/ includes.
7850         * obsd-nat.c: Fix common/ includes.
7851         * nat/x86-linux.c: Fix common/ includes.
7852         * nat/x86-linux-dregs.c: Fix common/ includes.
7853         * nat/x86-dregs.h: Fix common/ includes.
7854         * nat/x86-dregs.c: Fix common/ includes.
7855         * nat/ppc-linux.c: Fix common/ includes.
7856         * nat/mips-linux-watch.h: Fix common/ includes.
7857         * nat/mips-linux-watch.c: Fix common/ includes.
7858         * nat/linux-waitpid.c: Fix common/ includes.
7859         * nat/linux-ptrace.h: Fix common/ includes.
7860         * nat/linux-ptrace.c: Fix common/ includes.
7861         * nat/linux-procfs.c: Fix common/ includes.
7862         * nat/linux-personality.c: Fix common/ includes.
7863         * nat/linux-osdata.c: Fix common/ includes.
7864         * nat/linux-namespaces.c: Fix common/ includes.
7865         * nat/linux-btrace.h: Fix common/ includes.
7866         * nat/linux-btrace.c: Fix common/ includes.
7867         * nat/fork-inferior.c: Fix common/ includes.
7868         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7869         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7870         * nat/aarch64-linux.c: Fix common/ includes.
7871         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7872         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7873         * namespace.h: Fix common/ includes.
7874         * mips-linux-tdep.c: Fix common/ includes.
7875         * minsyms.c: Fix common/ includes.
7876         * mi/mi-parse.h: Fix common/ includes.
7877         * mi/mi-main.c: Fix common/ includes.
7878         * mi/mi-cmd-env.c: Fix common/ includes.
7879         * memrange.h: Fix common/ includes.
7880         * memattr.c: Fix common/ includes.
7881         * maint.h: Fix common/ includes.
7882         * maint.c: Fix common/ includes.
7883         * main.c: Fix common/ includes.
7884         * machoread.c: Fix common/ includes.
7885         * location.c: Fix common/ includes.
7886         * linux-thread-db.c: Fix common/ includes.
7887         * linux-nat.c: Fix common/ includes.
7888         * linux-fork.c: Fix common/ includes.
7889         * inline-frame.c: Fix common/ includes.
7890         * infrun.c: Fix common/ includes.
7891         * inflow.c: Fix common/ includes.
7892         * inferior.h: Fix common/ includes.
7893         * inferior.c: Fix common/ includes.
7894         * infcmd.c: Fix common/ includes.
7895         * inf-ptrace.c: Fix common/ includes.
7896         * inf-child.c: Fix common/ includes.
7897         * ia64-linux-nat.c: Fix common/ includes.
7898         * i387-tdep.c: Fix common/ includes.
7899         * i386-tdep.c: Fix common/ includes.
7900         * i386-linux-tdep.c: Fix common/ includes.
7901         * i386-linux-nat.c: Fix common/ includes.
7902         * i386-go32-tdep.c: Fix common/ includes.
7903         * i386-fbsd-tdep.c: Fix common/ includes.
7904         * i386-fbsd-nat.c: Fix common/ includes.
7905         * guile/scm-type.c: Fix common/ includes.
7906         * guile/guile.c: Fix common/ includes.
7907         * go32-nat.c: Fix common/ includes.
7908         * gnu-nat.c: Fix common/ includes.
7909         * gdbthread.h: Fix common/ includes.
7910         * gdbarch-selftests.c: Fix common/ includes.
7911         * gdb_usleep.c: Fix common/ includes.
7912         * gdb_select.h: Fix common/ includes.
7913         * gdb_bfd.c: Fix common/ includes.
7914         * gcore.c: Fix common/ includes.
7915         * fork-child.c: Fix common/ includes.
7916         * findvar.c: Fix common/ includes.
7917         * fbsd-nat.c: Fix common/ includes.
7918         * event-top.c: Fix common/ includes.
7919         * event-loop.c: Fix common/ includes.
7920         * dwarf2read.c: Fix common/ includes.
7921         * dwarf2loc.c: Fix common/ includes.
7922         * dwarf2-frame.c: Fix common/ includes.
7923         * dwarf-index-cache.c: Fix common/ includes.
7924         * dtrace-probe.c: Fix common/ includes.
7925         * disasm-selftests.c: Fix common/ includes.
7926         * defs.h: Fix common/ includes.
7927         * csky-tdep.c: Fix common/ includes.
7928         * cp-valprint.c: Fix common/ includes.
7929         * cp-support.h: Fix common/ includes.
7930         * cp-support.c: Fix common/ includes.
7931         * corelow.c: Fix common/ includes.
7932         * completer.h: Fix common/ includes.
7933         * completer.c: Fix common/ includes.
7934         * compile/compile.c: Fix common/ includes.
7935         * compile/compile-loc2c.c: Fix common/ includes.
7936         * compile/compile-cplus-types.c: Fix common/ includes.
7937         * compile/compile-cplus-symbols.c: Fix common/ includes.
7938         * command.h: Fix common/ includes.
7939         * cli/cli-dump.c: Fix common/ includes.
7940         * cli/cli-cmds.c: Fix common/ includes.
7941         * charset.c: Fix common/ includes.
7942         * build-id.c: Fix common/ includes.
7943         * btrace.h: Fix common/ includes.
7944         * btrace.c: Fix common/ includes.
7945         * breakpoint.h: Fix common/ includes.
7946         * breakpoint.c: Fix common/ includes.
7947         * ax.h:
7948         (enum agent_op): Fix common/ includes.
7949         * ax-general.c (struct aop_map): Fix common/ includes.
7950         * ax-gdb.c: Fix common/ includes.
7951         * auxv.c: Fix common/ includes.
7952         * auto-load.c: Fix common/ includes.
7953         * arm-tdep.c: Fix common/ includes.
7954         * arch/riscv.c: Fix common/ includes.
7955         * arch/ppc-linux-common.c: Fix common/ includes.
7956         * arch/i386.c: Fix common/ includes.
7957         * arch/arm.c: Fix common/ includes.
7958         * arch/arm-linux.c: Fix common/ includes.
7959         * arch/arm-get-next-pcs.c: Fix common/ includes.
7960         * arch/amd64.c: Fix common/ includes.
7961         * arch/aarch64.c: Fix common/ includes.
7962         * arch/aarch64-insn.c: Fix common/ includes.
7963         * arch-utils.c: Fix common/ includes.
7964         * amd64-windows-tdep.c: Fix common/ includes.
7965         * amd64-tdep.c: Fix common/ includes.
7966         * amd64-sol2-tdep.c: Fix common/ includes.
7967         * amd64-obsd-tdep.c: Fix common/ includes.
7968         * amd64-nbsd-tdep.c: Fix common/ includes.
7969         * amd64-linux-tdep.c: Fix common/ includes.
7970         * amd64-linux-nat.c: Fix common/ includes.
7971         * amd64-fbsd-tdep.c: Fix common/ includes.
7972         * amd64-fbsd-nat.c: Fix common/ includes.
7973         * amd64-dicos-tdep.c: Fix common/ includes.
7974         * amd64-darwin-tdep.c: Fix common/ includes.
7975         * agent.c: Fix common/ includes.
7976         * ada-lang.h: Fix common/ includes.
7977         * ada-lang.c: Fix common/ includes.
7978         * aarch64-tdep.c: Fix common/ includes.
7979
7980 2019-01-25  Tom Tromey  <tom@tromey.com>
7981
7982         * common/create-version.sh: Use common/version.h.
7983
7984 2019-01-24  Pedro Alves  <palves@redhat.com>
7985
7986         * infrun.c (signal_stop, signal_print, signal_program)
7987         (signal_catch, signal_pass): Now arrays instead of pointers.
7988         (update_signals_program_target, do_target_resume)
7989         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7990         * linux-nat.c (linux_nat_target::pass_signals)
7991         (linux_nat_target::create_inferior, linux_nat_target::attach):
7992         Adjust.
7993         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7994         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7995         * procfs.c (procfs_target::pass_signals): Adjust.
7996         * record-full.c (record_full_target::resume): Adjust.
7997         * remote.c (remote_target::pass_signals)
7998         (remote_target::program_signals): Adjust.
7999         * target-debug.h (target_debug_print_signals): Now takes a
8000         gdb::array_view as parameter.  Adjust.
8001         * target.h (target_ops) <pass_signals, program_signals>: Replace
8002         pointer and length parameters with gdb::array_view.
8003         (target_pass_signals, target_program_signals): Likewise.
8004         * target-delegates.c: Regenerate.
8005
8006 2019-01-24  Pedro Alves  <palves@redhat.com>
8007
8008         * common/forward-scope-exit.h
8009         (forward_scope_exit::forward_scope_exit): Pass arguments to
8010         m_bind_function directly, instead of creating a std::bind and
8011         copying that.
8012
8013 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8014
8015         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8016         for static members.
8017         (pass_in_v_vfp_candidate): Likewise.
8018
8019 2019-01-23  Tom Tromey  <tom@tromey.com>
8020             Pedro Alves  <palves@redhat.com>
8021
8022         * regcache.c (class regcache_invalidator): Remove.
8023         (regcache::raw_write): Use make_scope_exit.
8024
8025 2019-01-23  Tom Tromey  <tom@tromey.com>
8026
8027         * ui-out.h (class ui_out_emit_type): Update comment.
8028
8029 2019-01-23  Tom Tromey  <tom@tromey.com>
8030
8031         * infrun.c (fetch_inferior_event): Update comment.
8032
8033 2019-01-23  Tom Tromey  <tom@tromey.com>
8034             Pedro Alves  <palves@redhat.com>
8035
8036         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8037         parameter.
8038         (fetch_inferior_event): Use SCOPE_EXIT.
8039
8040
8041 2019-01-23  Tom Tromey  <tom@tromey.com>
8042             Pedro Alves  <palves@redhat.com>
8043
8044         * infrun.c (disable_thread_events): Delete.
8045         (stop_all_threads): Use SCOPE_EXIT.
8046
8047 2019-01-23  Tom Tromey  <tom@tromey.com>
8048             Pedro Alves  <palves@redhat.com>
8049
8050         * symfile.c: Include forward-scope-exit.h.
8051         (clear_symtab_users_cleanup): Replace forward declaration with
8052         a FORWARD_SCOPE_EXIT.
8053         (syms_from_objfile_1): Use the forward_scope_exit and
8054         gdb::optional instead of cleanup_function.
8055         (reread_symbols): Use the forward_scope_exit instead of
8056         cleanup_function.
8057         (clear_symtab_users_cleanup): Remove function.
8058
8059 2019-01-23  Tom Tromey  <tom@tromey.com>
8060             Pedro Alves  <palves@redhat.com>
8061
8062         * linux-nat.c: Include scope-exit.h.
8063         (cleanup_target_stop): Remove.
8064         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8065         SCOPE_EXIT.
8066
8067 2019-01-23  Tom Tromey  <tom@tromey.com>
8068             Pedro Alves  <palves@redhat.com>
8069
8070         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8071         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8072
8073 2019-01-23  Tom Tromey  <tom@tromey.com>
8074             Andrew Burgess  <andrew.burgess@embecosm.com>
8075             Pedro Alves  <palves@redhat.com>
8076
8077         * infrun.c (fetch_inferior_event): Use scope_exit.
8078         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8079         * top.c (execute_command): Use scope_exit.
8080         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8081         * utils.c (do_bpstat_clear_actions_cleanup)
8082         (make_bpstat_clear_actions_cleanup): Remove.
8083
8084 2019-01-23  Tom Tromey  <tom@tromey.com>
8085             Pedro Alves  <palves@redhat.com>
8086
8087         * infrun.c: Include "common/scope-exit.h"
8088         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8089         (wait_for_inferior): Use SCOPE_EXIT.
8090         (fetch_inferior_event): Use scope_exit.
8091
8092 2019-01-23  Tom Tromey  <tom@tromey.com>
8093             Pedro Alves  <palves@redhat.com>
8094
8095         * breakpoint.c (create_breakpoint): Remove cleanup.
8096
8097 2019-01-23  Tom Tromey  <tom@tromey.com>
8098             Andrew Burgess  <andrew.burgess@embecosm.com>
8099             Pedro Alves  <palves@redhat.com>
8100
8101 2019-01-23  Pedro Alves  <palves@redhat.com>
8102
8103         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8104
8105 2019-01-23  Pedro Alves  <palves@redhat.com>
8106             Andrew Burgess  <andrew.burgess@embecosm.com>
8107
8108         * gdbthread.h: Include "common/forward-scope-exit.h".
8109         (scoped_finish_thread_state): Redefine custom class in terms of
8110         forward_scope_exit.
8111
8112 2019-01-23  Pedro Alves  <palves@redhat.com>
8113             Andrew Burgess  <andrew.burgess@embecosm.com>
8114
8115         * common/forward-scope-exit.h: New file.
8116
8117 2019-01-23  Pedro Alves  <palves@redhat.com>
8118             Andrew Burgess  <andrew.burgess@embecosm.com>
8119             Tom Tromey  <tom@tromey.com>
8120
8121         * common/scope-exit.h: New file.
8122
8123 2019-01-23  Pedro Alves  <palves@redhat.com>
8124
8125         * common/preprocessor.h (ESC): Rename to ...
8126         (ESC_PARENS): ... this.
8127         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8128         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8129
8130 2019-01-23  Tom Tromey  <tom@tromey.com>
8131
8132         * language.h (class scoped_switch_to_sym_language_if_auto):
8133         Initialize m_lang in both cases.
8134
8135 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8136
8137         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8138         with XCNEW.
8139
8140 2019-01-22  Tom Tromey  <tom@tromey.com>
8141
8142         * corelow.c: Do not include sys/file.h.
8143
8144 2019-01-22  Tom Tromey  <tom@tromey.com>
8145
8146         * tui/tui-wingeneral.h: Include gdb_curses.h.
8147
8148 2019-01-22  Tom Tromey  <tom@tromey.com>
8149
8150         * source-cache.h (class source_cache) <get_source_lines,
8151         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8152
8153 2019-01-22  Tom Tromey  <tom@tromey.com>
8154
8155         * remote-fileio.h (struct remote_target): Declare.
8156
8157 2019-01-22  Tom Tromey  <tom@tromey.com>
8158
8159         * python/py-arch.c: Do not include py-ref.h.
8160         * python/py-bpevent.c: Do not include py-ref.h.
8161         * python/py-cmd.c: Do not include py-ref.h.
8162         * python/py-continueevent.c: Do not include py-ref.h.
8163         * python/py-event.h: Do not include py-ref.h.
8164         * python/py-evtregistry.c: Do not include py-ref.h.
8165         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8166         * python/py-frame.c: Do not include py-ref.h.
8167         * python/py-framefilter.c: Do not include py-ref.h.
8168         * python/py-function.c: Do not include py-ref.h.
8169         * python/py-infevents.c: Do not include py-ref.h.
8170         * python/py-linetable.c: Do not include py-ref.h.
8171         * python/py-objfile.c: Do not include py-ref.h.
8172         * python/py-param.c: Do not include py-ref.h.
8173         * python/py-prettyprint.c: Do not include py-ref.h.
8174         * python/py-progspace.c: Do not include py-ref.h.
8175         * python/py-symbol.c: Do not include py-ref.h.
8176         * python/py-symtab.c: Do not include py-ref.h.
8177         * python/py-type.c: Do not include py-ref.h.
8178         * python/py-unwind.c: Do not include py-ref.h.
8179         * python/py-utils.c: Do not include py-ref.h.
8180         * python/py-value.c: Do not include py-ref.h.
8181         * python/py-varobj.c: Do not include py-ref.h.
8182         * python/py-xmethods.c: Do not include py-ref.h.
8183         * python/python.c: Do not include py-ref.h.
8184         * varobj.c: Do not include py-ref.h.
8185
8186 2019-01-22  Tom Tromey  <tom@tromey.com>
8187
8188         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8189         keyword for bcache.
8190
8191 2019-01-22  Tom Tromey  <tom@tromey.com>
8192
8193         * compile/compile-cplus-types.c: Remove a comment by #include.
8194
8195 2019-01-22  Tom Tromey  <tom@tromey.com>
8196
8197         * compile/gcc-c-plugin.h: Include compile-internal.h.
8198
8199 2019-01-22  Tom Tromey  <tom@tromey.com>
8200
8201         * stabsread.c (EXTERN): Do not define.
8202         (symnum, next_symbol_text_func, processing_gcc_compilation)
8203         (within_function, global_sym_chain, global_stabs)
8204         (previous_stab_code, this_object_header_files)
8205         (n_this_object_header_files)
8206         (n_allocated_this_object_header_files): Define.
8207         * stabsread.h (EXTERN): Never define.  Use "extern".
8208
8209 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8210
8211         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8212         history_value.
8213
8214 2019-01-21  Tom Tromey  <tom@tromey.com>
8215
8216         * ui-out.c: Fix includes.
8217         * tui/tui-source.c: Fix includes.
8218         * target.c: Fix includes.
8219         * remote.c: Fix includes.
8220         * regcache.c: Fix includes.
8221         * python/py-block.c: Fix includes.
8222         * printcmd.c: Fix includes.
8223         * or1k-tdep.c: Fix includes.
8224         * mi/mi-main.c: Fix includes.
8225         * m32r-tdep.c: Fix includes.
8226         * csky-tdep.c: Fix includes.
8227         * compile/compile-cplus-types.c: Fix includes.
8228         * cli/cli-interp.c: Fix includes.
8229
8230 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8231
8232         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8233         for padding.
8234
8235 2019-01-16  Tom Tromey  <tom@tromey.com>
8236
8237         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8238         earlier.
8239         (struct objfile) <msymbols_range>: Move from top level.
8240         <msymbols>: New method.
8241         (class objfile_msymbols): Remove.
8242         * symtab.c (default_collect_symbol_completion_matches_break_on):
8243         Update.
8244         * symmisc.c (dump_msymbols): Update.
8245         * stabsread.c (scan_file_globals): Update.
8246         * objc-lang.c (info_selectors_command, info_classes_command)
8247         (find_methods): Update.
8248         * minsyms.c (find_solib_trampoline_target): Update.
8249         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8250         * coffread.c (coff_symfile_read): Update.
8251         * ada-lang.c (ada_lookup_simple_minsym)
8252         (ada_collect_symbol_completion_matches): Update.
8253
8254 2019-01-16  Tom Tromey  <tom@tromey.com>
8255
8256         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8257         type.  Remove no-argument constructor.
8258         <iterator::operator++>: Simplify.
8259         <begin>: Update.
8260         <end>: Use minimal_symbol_count.
8261
8262 2019-01-16  Tom Tromey  <tom@tromey.com>
8263
8264         * objfiles.h (struct objfile) <psymtabs>: New method.
8265         (class objfile_psymtabs): Remove.
8266         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8267         typedef.
8268         <range>: New method.
8269         (require_partial_symbols): Change return type.
8270         * psymtab.c (require_partial_symbols)
8271         (psym_expand_symtabs_matching): Update.
8272         * mdebugread.c (parse_partial_symbols): Update.
8273         * dbxread.c (dbx_end_psymtab): Update.
8274
8275 2019-01-15  Tom Tromey  <tom@tromey.com>
8276
8277         * symtab.c (lookup_objfile_from_block)
8278         (lookup_symbol_in_objfile_symtabs)
8279         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8280         (find_line_symtab, info_sources_command)
8281         (default_collect_symbol_completion_matches_break_on)
8282         (make_source_files_completion_list): Update.
8283         * symmisc.c (print_objfile_statistics, dump_objfile)
8284         (maintenance_print_symbols, maintenance_info_symtabs)
8285         (maintenance_check_symtabs, maintenance_info_line_tables):
8286         Update.
8287         * source.c (select_source_symtab)
8288         (forget_cached_source_info_for_objfile): Update.
8289         * objfiles.h (class objfile_compunits): Remove.
8290         (struct objfile) <compunits_range>: New typedef.
8291         (compunits): New method.
8292         * objfiles.c (objfile_relocate1): Update.
8293         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8294         * maint.c (count_symtabs_and_blocks): Update.
8295         * linespec.c (iterate_over_all_matching_symtabs): Update.
8296         * cp-support.c (add_symbol_overload_list_qualified): Update.
8297         * coffread.c (coff_symtab_read): Update.
8298         * ada-lang.c (add_nonlocal_symbols)
8299         (ada_collect_symbol_completion_matches)
8300         (ada_add_global_exceptions): Update.
8301
8302 2019-01-15  Tom Tromey  <tom@tromey.com>
8303
8304         * progspace.h (program_space) <objfiles_safe_range>: New
8305         typedef.
8306         <objfiles_safe>: New method.
8307         * objfiles.h (class all_objfiles_safe): Remove.
8308         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8309         * jit.c (jit_inferior_exit_hook): Update.
8310
8311 2019-01-17  Tom Tromey  <tom@tromey.com>
8312
8313         * progspace.h (program_space) <objfiles_range>: New typedef.
8314         <objfiles>: New method.
8315         <objfiles_head>: Rename from objfiles.
8316         (object_files): Update.
8317         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8318         * guile/scm-pretty-print.c
8319         (ppscm_find_pretty_printer_from_objfiles): Update.
8320         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8321         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8322         Update.
8323         * python/py-progspace.c (pspy_get_objfiles): Update.
8324         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8325         Update.
8326         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8327         (objfpy_lookup_objfile_by_build_id): Update.
8328         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8329         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8330         Update.
8331         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8332         (expand_symtab_containing_pc, lookup_objfile_from_block)
8333         (lookup_static_symbol, basic_lookup_transparent_type)
8334         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8335         (find_line_symtab, info_sources_command)
8336         (default_collect_symbol_completion_matches_break_on)
8337         (make_source_files_completion_list, find_main_name): Update.
8338         * symmisc.c (print_symbol_bcache_statistics)
8339         (print_objfile_statistics, maintenance_print_symbols)
8340         (maintenance_print_msymbols, maintenance_print_objfiles)
8341         (maintenance_info_symtabs, maintenance_check_symtabs)
8342         (maintenance_expand_symtabs, maintenance_info_line_tables):
8343         Update.
8344         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8345         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8346         (map_overlay_command, unmap_overlay_command)
8347         (simple_overlay_update, expand_symtabs_matching)
8348         (map_symbol_filenames): Update.
8349         * symfile-debug.c (set_debug_symfile): Update.
8350         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8351         Update.
8352         * source.c (select_source_symtab, forget_cached_source_info):
8353         Update.
8354         * solib.c (solib_read_symbols): Update.
8355         * solib-spu.c (append_ocl_sos): Update.
8356         * psymtab.c (maintenance_print_psymbols)
8357         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8358         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8359         * printcmd.c (info_symbol_command): Update.
8360         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8361         Update.
8362         * objfiles.h (class all_objfiles): Remove.
8363         * objfiles.c (have_partial_symbols, have_full_symbols)
8364         (have_minimal_symbols, qsort_cmp, update_section_map)
8365         (shared_objfile_contains_address_p)
8366         (default_iterate_over_objfiles_in_search_order): Update.
8367         * objc-lang.c (info_selectors_command, info_classes_command)
8368         (find_methods): Update.
8369         * minsyms.c (find_solib_trampoline_target): Update.
8370         * maint.c (maintenance_info_sections)
8371         (maintenance_translate_address, count_symtabs_and_blocks):
8372         Update.
8373         * main.c (captured_main_1): Update.
8374         * linux-thread-db.c (try_thread_db_load_from_pdir)
8375         (has_libpthread): Update.
8376         * linespec.c (iterate_over_all_matching_symtabs)
8377         (search_minsyms_for_name): Update.
8378         * jit.c (jit_find_objf_with_entry_addr): Update.
8379         * hppa-tdep.c (find_unwind_entry)
8380         (hppa_lookup_stub_minimal_symbol): Update.
8381         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8382         Update.
8383         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8384         (elf_gnu_ifunc_resolve_by_got): Update.
8385         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8386         * dwarf-index-write.c (save_gdb_index_command): Update.
8387         * cp-support.c (add_symbol_overload_list_qualified): Update.
8388         * breakpoint.c (create_overlay_event_breakpoint)
8389         (create_longjmp_master_breakpoint)
8390         (create_std_terminate_master_breakpoint)
8391         (create_exception_master_breakpoint): Update.
8392         * blockframe.c (find_pc_partial_function): Update.
8393         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8394         (ada_collect_symbol_completion_matches)
8395         (ada_add_global_exceptions): Update.
8396
8397 2019-01-17  Tom Tromey  <tom@tromey.com>
8398
8399         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8400         declare VEC.
8401         (solib_target_parse_libraries): Change return type.
8402         (library_list_start_segment, library_list_start_section)
8403         (library_list_end_library, library_list_start_library); Update.
8404         (solib_target_free_library_list): Remove.
8405         (solib_target_parse_libraries): Remove cleanup.  Change return
8406         type.
8407         (solib_target_current_sos): Update.
8408
8409 2019-01-17  Tom Tromey  <tromey@bapiya>
8410
8411         * valprint.c: Replace "the the" with "the".
8412         * symtab.c: Replace "the the" with "the".
8413         * solib.c: Replace "the the" with "the".
8414         * solib-dsbt.c: Replace "the the" with "the".
8415         * linespec.c: Replace "the the" with "the".
8416         * dwarf2loc.h: Replace "the the" with "the".
8417         * amd64-windows-tdep.c: Replace "the the" with "the".
8418         * aarch64-tdep.c: Replace "the the" with "the".
8419
8420 2019-01-16  Keith Seitz  <keiths@redhat.com>
8421
8422         PR gdb/23773
8423         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8424         <builder>: Rename to ..
8425         <m_builder>: ... this and make private.
8426         (dwarf2_cu::get_builder): New method.  Change all users of
8427         `builder' to use this method.
8428         (dwarf2_start_symtab): Move to ...
8429         (dwarf2_cu::start_symtab): ... here.  Update all callers
8430         (setup_type_unit_groups): Move to ...
8431         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8432         callers.
8433         (dwarf2_cu::reset_builder): New method.
8434         (process_full_compunit, process_full_type_unit): Use
8435         dwarf2_cu::reset_builder.
8436         (follow_die_offset): Record the ancestor CU if it is different
8437         from the followed DIE's CU.
8438         (follow_die_sig_1): Likewise.
8439
8440 2019-01-15  Tom Tromey  <tom@tromey.com>
8441
8442         * remote.c (class remote_state) <buf>: Now a char_vector.
8443         <buf_size>: Remove.
8444         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8445         parameter.
8446         (remote_target::getpkt_or_notif_sane_1)
8447         (remote_target::getpkt_sane)
8448         (remote_target::getpkt_or_notif_sane): Likewise.
8449         (class remote_target) <putpkt>: New overload.
8450         (remote_target::read_frame): Change type of "buf_p".  Remove
8451         sizeof_p parameter.
8452         (packet_ok): New overload.
8453         (packet_check_result): New overload.
8454         Update all uses.
8455
8456 2019-01-14  Tom Tromey  <tom@tromey.com>
8457
8458         * remote-notif.c (handle_notification, remote_notif_ack)
8459         (remote_notif_parse): Make "buf" const.
8460         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8461         const.
8462         (remote_notif_parse, remote_notif_ack, handle_notification):
8463         Likewise.
8464         * remote.c (remote_notif_stop_parse): Make "buf" const.
8465         (remote_target::remote_parse_stop_reply): Make "buf" const.
8466         (remote_notif_stop_ack): Make "buf" const.
8467
8468 2019-01-14  Tom Tromey  <tom@tromey.com>
8469
8470         * remote.c (remote_console_output): Make parameter const.
8471
8472 2019-01-14  Tom Tromey  <tom@tromey.com>
8473
8474         * target-debug.h (target_debug_print_signals): Constify.
8475         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8476         * procfs.c (procfs_target::pass_signals): Update.
8477         * linux-nat.c (linux_nat_target::pass_signals): Update.
8478         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8479         * target-delegates.c: Rebuild.
8480         * remote.c (remote_target::program_signals): Update.
8481         (remote_target::pass_signals): Update.
8482         * target.c (target_pass_signals): Constify argument.
8483         (target_program_signals): Likewise.
8484         * target.h (struct target_ops) <pass_signals, program_signals>:
8485         Constify argument.
8486         (target_pass_signals, target_program_signals): Constify argument.
8487
8488 2019-01-14  Tom Tromey  <tom@tromey.com>
8489
8490         PR tui/28819:
8491         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8492
8493 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8494
8495         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8496         field.
8497         * rs6000-tdep.c: Include reggroups.h.
8498         (IS_V_ALIAS_PSEUDOREG): Define.
8499         (rs6000_register_name): Return names for the "vX" aliases.
8500         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8501         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8502         aliases.  Call default_register_reggroup_p for all other
8503         pseudo-registers.
8504         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8505         New functions.
8506         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8507         Handle "vX" aliases.
8508         (v_alias_pseudo_register_collect): New function.
8509         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8510         (rs6000_gdbarch_init): Initialize "vX" aliases as
8511         pseudo-registers.  Restore registration of
8512         rs6000_pseudo_register_reggroup_p with
8513         set_tdesc_pseudo_register_reggroup_p.
8514
8515 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8516
8517         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8518         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8519         set_gdbarch_num_pseudo_regs.
8520
8521 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8522
8523         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8524         Remove arg prefixname, add do_set and do_show.
8525         Add member functions set_list and show_list.
8526         * cli/cli-style.c (class cli_style_option): Update accordingly.
8527         (style_set_list): Move to file scope.
8528         (style_show_list): Likewise.
8529         (set_style): Call help_list.
8530         (show_style): Call cmd_show_list.
8531         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8532         Update to use the new macro.
8533
8534 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8535
8536         * ada-lang.c (_initialize_ada_language): Expand the help text
8537         for the "catch exception" command.
8538
8539 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8540
8541         * symtab.c (matching_obj_sections): Initialize obj,
8542         declare it closer to its usage.
8543
8544 2019-01-10  Tom Tromey  <tom@tromey.com>
8545
8546         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8547         (basic_inf_threads_range): Remove.
8548         (inf_threads_range, inf_non_exited_threads_range)
8549         (safe_inf_threads_range): Use next_adapter.
8550
8551 2019-01-10  Keith Seitz  <keiths@redhat.com>
8552
8553         PR gdb/23712
8554         PR symtab/23010
8555         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8556         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8557
8558 2019-01-10  Keith Seitz  <keiths@redhat.com>
8559
8560         PR gdb/23712
8561         PR symtab/23010
8562         * dictionary.c (pending_to_vector): Remove.
8563         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8564         Remove _1 suffix, replacing functions of the same name.  Update
8565         all callers.
8566         (dict_create_hashed, dict_create_hashed_expandable)
8567         (dict_create_linear, dict_create_linear_expandable, dict_free)
8568         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8569         Make functions static.
8570
8571 2019-01-10  Keith Seitz  <keiths@redhat.com>
8572
8573         PR gdb/23712
8574         PR symtab/23010
8575         * dictionary.h (struct dictionary): Replace declaration with
8576         multidictionary.
8577         (dict_create_hashed, dict_create_hashed_expandable)
8578         (dict_create_linear, dict_create_linear_expandable)
8579         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8580         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8581         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8582         taking multidictionary argument.
8583         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8584         * block.h (struct block) <dict>: Change to multidictionary
8585         and rename `multidict'.
8586         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8587         symmisc.c: Update all dictionary references to multidictionary.
8588
8589 2019-01-10  Keith Seitz  <keiths@redhat.com>
8590
8591         PR gdb/23712
8592         PR symtab/23010
8593         * dictionary.c: Include unordered_map.
8594         (pending_to_vector): New function.
8595         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8596         Rewrite the non-"_1" functions to take vector instead
8597         of linked list.
8598         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8599         "new" _1 versions of the same name.
8600         (multidictionary): Define.
8601         (std::hash<enum language): New definition.
8602         (collate_pending_symbols_by_language, mdict_create_hashed)
8603         (mdict_create_hashed_expandable, mdict_create_linear)
8604         (mdict_create_linear_expandable, mdict_free)
8605         (find_language_dictionary, create_new_language_dictionary)
8606         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8607         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8608         (mdict_size, mdict_empty): New functions.
8609         * dictionary.h (mdict_iterator): Define.
8610
8611 2019-01-10  Pedro Alves  <palves@redhat.com>
8612
8613         * breakpoint.c (read_uploaded_action)
8614         (create_tracepoint_from_upload): Adjust to use
8615         gdb::unique_xmalloc_ptr.
8616         * ctf.c (ctf_write_uploaded_tp):
8617         (SET_ARRAY_FIELD): Use emplace_back.
8618         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8619         * tracefile-tfile.c (tfile_write_uploaded_tp):
8620         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8621         gdb::unique_xmalloc_ptr.
8622         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8623         at_string, cond_string, cmd_strings>: Replace char pointers
8624         with gdb::unique_xmalloc_ptr.
8625
8626 2019-01-10  Pedro Alves  <palves@redhat.com>
8627
8628         * solib-target.c (library_list_start_library): Don't xstrdup name.
8629
8630 2019-01-10  Pedro Alves  <palves@redhat.com>
8631
8632         * mdebugread.c (parse_partial_symbols): Use
8633         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8634
8635 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8636
8637         * linux-fork.c (scoped_switch_fork_info)
8638         <~scoped_switch_fork_info>: Fix incorrect variable name.
8639
8640 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8641
8642         * linux-fork.c (scoped_switch_fork_info)
8643         <scoped_switch_fork_info>: Make explicit.
8644         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8645
8646 2019-01-10  Tom Tromey  <tom@tromey.com>
8647
8648         * objfiles.h (objfile::reset_psymtabs): Update.
8649         * objfiles.c (objfile::objfile): Update.
8650         * psymtab.h (psymtab_storage::obstack): Update.
8651         (psymtab_storage::m_obstack): Use gdb::optional.
8652         (class psymtab_storage): Update comment.  Remove objfile
8653         parameter.
8654         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8655
8656 2019-01-10  Tom Tromey  <tom@tromey.com>
8657
8658         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8659         <free_psymtabs>: Now private.
8660         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8661         (allocate_psymtab): Use new method.
8662
8663 2019-01-10  Tom Tromey  <tom@tromey.com>
8664
8665         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8666         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8667         * mdebugread.c (parse_partial_symbols): Use
8668         allocate_dependencies.
8669         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8670         allocate_dependencies.
8671         (process_psymtab_comp_unit_reader)
8672         (build_type_psymtab_dependencies): Likewise.
8673         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8674
8675 2019-01-10  Tom Tromey  <tom@tromey.com>
8676
8677         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8678         PSYMBOL_SET_LANGUAGE.
8679         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8680
8681 2019-01-10  Tom Tromey  <tom@tromey.com>
8682
8683         * psymtab.h (psymtab_storage::obstack): New method.
8684         <m_obstack>: Rename from obstack; now private.
8685         * psymtab.c (psymtab_storage): Update.
8686         * dwarf2read.c (create_addrmap_from_index)
8687         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8688         Update.
8689
8690 2019-01-10  Tom Tromey  <tom@tromey.com>
8691
8692         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8693         * objfiles.h (objfile::reset_psymtabs): New method.
8694
8695 2019-01-10  Tom Tromey  <tom@tromey.com>
8696
8697         * symmisc.c (print_symbol_bcache_statistics): Update.
8698         (print_objfile_statistics): Update.
8699         * symfile.c (reread_symbols): Update.
8700         * psymtab.h (class psymtab_storage): New.
8701         * psymtab.c (psymtab_storage): New constructor.
8702         (~psymtab_storage): New destructor.
8703         (require_partial_symbols): Update.
8704         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8705         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8706         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8707         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8708         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8709         (start_psymtab_common, end_psymtab_common)
8710         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8711         (allocate_psymtab): Update.
8712         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8713         Update.
8714         (dump_psymtab_addrmap, maintenance_print_psymbols)
8715         (maintenance_check_psymtabs): Update.
8716         (class objfile_psymtabs): Move to objfiles.h.
8717         * psympriv.h (discard_psymtab): Now inline.
8718         (psymtab_discarder::psymtab_discarder): Update.
8719         (psymtab_discarder::~psymtab_discarder): Update.
8720         (ALL_OBJFILE_PSYMTABS): Rewrite.
8721         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8722         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8723         Remove fields.
8724         <partial_symtabs>: New field.
8725         (class objfile_psymtabs): Move from psymtab.h.  Update.
8726         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8727         psymbol_cache.
8728         (objfile::~objfile): Don't destroy psymbol_cache.
8729         * mdebugread.c (parse_partial_symbols): Update.
8730         * dwarf2read.c (create_addrmap_from_index)
8731         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8732         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8733         (add_partial_subprogram, dwarf2_ranges_read): Update.
8734         * dwarf-index-write.c (write_address_map)
8735         (write_one_signatured_type, recursively_write_psymbols)
8736         (class debug_names, class debug_names, write_psymtabs_to_index):
8737         Update.
8738
8739 2019-01-10  Tom Tromey  <tom@tromey.com>
8740
8741         * symtab.h (SYMBOL_SET_NAMES): Update.
8742         (symbol_set_names): Update.
8743         (MSYMBOL_SET_NAMES): Update.
8744         * symtab.c (symbol_set_names): Change argument to be an
8745         objfile_per_bfd_storage.
8746         * psymtab.c (add_psymbol_to_bcache): Update.
8747         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8748
8749 2019-01-10  Tom Tromey  <tom@tromey.com>
8750
8751         * symtab.c (create_demangled_names_hash): Change argument to be an
8752         objfile_per_bfd_storage.
8753         (symbol_set_names): Update.
8754
8755 2019-01-10  Tom Tromey  <tom@tromey.com>
8756
8757         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8758         init_psymbol_list.
8759         * psymtab.c (init_psymbol_list): Do nothing if already called.
8760         * psympriv.h (init_psymbol_list): Add comment.
8761         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8762         init_psymbol_list.
8763         * dbxread.c (dbx_symfile_read): Unconditionally call
8764         init_psymbol_list.
8765
8766 2019-01-10  Tom Tromey  <tom@tromey.com>
8767
8768         * xcoffread.c (scan_xcoff_symtab): Update.
8769         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8770         "where".
8771         * mdebugread.c (parse_partial_symbols)
8772         (handle_psymbol_enumerators): Update.
8773         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8774         * dbxread.c (read_dbx_symtab): Update.
8775         * psympriv.h (psymbol_placement): New enum.
8776         (add_psymbol_to_list): Update.
8777
8778 2019-01-10  Tom Tromey  <tom@tromey.com>
8779
8780         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8781         static_psymbols parameters.
8782         (scan_xcoff_symtab): Update.
8783         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8784         static_psymbols parameters.
8785         * psympriv.h (start_psymtab_common): Update.
8786         * mdebugread.c (parse_partial_symbols): Update.
8787         * dwarf2read.c (create_partial_symtab): Update.
8788         * dbxread.c (read_dbx_symtab): Update.
8789         (start_psymtab): Remove global_psymbols and static_psymbols
8790         parameters.
8791
8792 2019-01-10  Tom Tromey  <tom@tromey.com>
8793
8794         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8795         * psymtab.c (allocate_psymtab): Add comment.
8796         * psympriv.h (allocate_psymtab): Add comment.
8797         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8798         initializations.
8799         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8800
8801 2019-01-10  Tom Tromey  <tom@tromey.com>
8802
8803         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8804         Don't declare.
8805         * mipsread.c: Include mdebugread.h.
8806         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8807         Declare.
8808         * elfread.c: Include mdebugread.h.
8809
8810 2019-01-09  Tom Tromey  <tom@tromey.com>
8811
8812         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8813         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8814         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8815         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8816         (psym_lookup_symbol, psym_find_last_source_symtab)
8817         (psym_forget_cached_source_info, psym_print_stats)
8818         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8819         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8820         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8821         (psym_find_compunit_symtab_by_address)
8822         (maintenance_print_psymbols, maintenance_info_psymtabs)
8823         (maintenance_check_psymtabs): Use ranged for.
8824         * psymtab.h (class objfile_psymtabs): New.
8825         (require_partial_symbols): Return objfile_psymtabs.
8826         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8827
8828 2019-01-09  Tom Tromey  <tom@tromey.com>
8829
8830         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8831         (find_pc_mapped_section, list_overlays_command)
8832         (map_overlay_command, unmap_overlay_command)
8833         (simple_overlay_update): Use all_objfiles.
8834         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8835         * printcmd.c (info_symbol_command): Use all_objfiles.
8836         * objfiles.h (ALL_OBJSECTIONS): Remove.
8837         * maint.c (maintenance_translate_address): Use all_objfiles.
8838         * gcore.c (gcore_create_callback): Use all_objfiles.
8839         (objfile_find_memory_regions): Likewise.
8840
8841 2019-01-09  Tom Tromey  <tom@tromey.com>
8842
8843         * symtab.c (find_line_symtab, info_sources_command)
8844         (make_source_files_completion_list): Use objfile_compunits.
8845         * source.c (select_source_symtab): Use objfile_compunits.
8846         * objfiles.h (struct objfile): Update comment.
8847         (ALL_OBJFILES): Remove.
8848         (ALL_FILETABS): Remove.
8849         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8850         objfile_compunits.
8851
8852 2019-01-09  Tom Tromey  <tom@tromey.com>
8853
8854         * symmisc.c (print_objfile_statistics, dump_objfile)
8855         (maintenance_print_symbols): Use compunit_filetabs.
8856         * source.c (forget_cached_source_info_for_objfile): Use
8857         compunit_filetabs.
8858         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8859         (ALL_FILETABS): Use compunit_filetabs.
8860         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8861         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8862
8863 2019-01-09  Tom Tromey  <tom@tromey.com>
8864
8865         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8866         (compunit_filetabs): New.
8867         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8868         compunit_filetabs.
8869         (info_sources_command, make_source_files_completion_list): Remove
8870         declaration.
8871         * symmisc.c (print_objfile_statistics, dump_objfile)
8872         (maintenance_print_symbols): Remove declaration.
8873         (maintenance_info_symtabs): Use compunit_filetabs.
8874         (maintenance_info_line_tables): Likewise.
8875         * source.c (select_source_symtab): Change local variable name.
8876         (forget_cached_source_info_for_objfile): Remove declaration.
8877         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8878         * objfiles.c (objfile_relocate1): Remove declaration.
8879         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8880         declaration.
8881         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8882         * coffread.c (coff_symtab_read): Remove declaration.
8883         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8884         compunit_filetabs.
8885
8886 2019-01-09  Tom Tromey  <tom@tromey.com>
8887
8888         * symtab.c (lookup_objfile_from_block)
8889         (find_pc_sect_compunit_symtab, search_symbols)
8890         (default_collect_symbol_completion_matches_break_on): Use
8891         objfile_compunits.
8892         * objfiles.h (ALL_COMPUNITS): Remove.
8893         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8894         * cp-support.c (add_symbol_overload_list_qualified): Use
8895         objfile_compunits.
8896         * ada-lang.c (ada_collect_symbol_completion_matches)
8897         (ada_add_global_exceptions): Use objfile_compunits.
8898
8899 2019-01-09  Tom Tromey  <tom@tromey.com>
8900
8901         * source.c (select_source_symtab)
8902         (forget_cached_source_info_for_objfile): Remove declaration.
8903         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8904         declaration.
8905         * maint.c (count_symtabs_and_blocks): Remove declaration.
8906         * cp-support.c (add_symbol_overload_list_qualified): Remove
8907         declaration.
8908         * coffread.c (coff_symtab_read): Remove declaration.
8909         * symtab.c (lookup_symbol_in_objfile_symtabs)
8910         (basic_lookup_transparent_type_1): Use objfile_compunits.
8911         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8912         (info_sources_command, search_symbols)
8913         (default_collect_symbol_completion_matches_break_on)
8914         (make_source_files_completion_list): Remove declaration.
8915         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8916         (ada_collect_symbol_completion_matches)
8917         (ada_add_global_exceptions): Remove declaration.
8918         * linespec.c (iterate_over_all_matching_symtabs): Use
8919         objfile_compunits.
8920         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8921         (class objfile_compunits): New.
8922         (ALL_COMPUNITS): Use objfile_compunits.
8923         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8924         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8925         objfile_compunits.
8926         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8927
8928 2019-01-09  Tom Tromey  <tom@tromey.com>
8929
8930         * symtab.c (search_symbols)
8931         (default_collect_symbol_completion_matches_break_on): Use
8932         objfile_msymbols.
8933         * ada-lang.c (ada_lookup_simple_minsym)
8934         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8935         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8936         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8937         objfile_msymbols.
8938         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8939         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8940         * objc-lang.c (find_methods): Use objfile_msymbols.
8941         (info_selectors_command, info_classes_command): Likewise.
8942         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8943         * objfiles.h (class objfile_msymbols): New.
8944         (ALL_OBJFILE_MSYMBOLS): Remove.
8945         (ALL_MSYMBOLS): Remove.
8946
8947 2019-01-09  Tom Tromey  <tom@tromey.com>
8948
8949         * common/next-iterator.h (next_adapter): Add Iterator template
8950         parameter.
8951         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8952         (class all_objfiles_safe): New.
8953         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8954         * objfiles.c (put_objfile_before): Update comment.
8955         (add_separate_debug_objfile): Likewise.
8956         (free_all_objfiles): Use all_objfiles_safe.
8957         (objfile_purge_solibs): Likewise.
8958
8959 2019-01-09  Tom Tromey  <tom@tromey.com>
8960
8961         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8962         (expand_symtab_containing_pc, lookup_static_symbol)
8963         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8964         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8965         all_objfiles.
8966         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8967         * breakpoint.c (create_overlay_event_breakpoint)
8968         (create_longjmp_master_breakpoint)
8969         (create_std_terminate_master_breakpoint)
8970         (create_exception_master_breakpoint): Use all_objfiles.
8971         * linux-thread-db.c (try_thread_db_load_from_pdir)
8972         (has_libpthread): Use all_objfiles.
8973         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8974         * linespec.c (iterate_over_all_matching_symtabs)
8975         (search_minsyms_for_name): Use all_objfiles.
8976         * maint.c (maintenance_info_sections): Use all_objfiles.
8977         * main.c (captured_main_1): Use all_objfiles.
8978         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8979         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8980         * guile/scm-pretty-print.c
8981         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8982         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8983         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8984         (maintenance_print_msymbols): Use all_objfiles.
8985         * source.c (select_source_symtab): Use all_objfiles.
8986         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8987         * symfile.c (remove_symbol_file_command)
8988         (expand_symtabs_matching, map_symbol_filenames): Use
8989         all_objfiles.
8990         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8991         all_objfiles.
8992         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8993         * objc-lang.c (find_methods): Use all_objfiles.
8994         * objfiles.c (have_partial_symbols, have_full_symbols)
8995         (have_minimal_symbols, qsort_cmp)
8996         (default_iterate_over_objfiles_in_search_order): Use
8997         all_objfiles.
8998         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8999         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9000         (maintenance_check_psymtabs): Use all_objfiles.
9001         (ALL_PSYMTABS): Remove.
9002         * compile/compile-object-run.c (do_module_cleanup): Use
9003         all_objfiles.
9004         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9005         * cp-support.c (add_symbol_overload_list_qualified): Use
9006         all_objfiles.
9007         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9008         Use all_objfiles.
9009         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9010         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9011         all_objfiles.
9012         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9013         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9014         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9015         Uses all_objfiles.
9016         * solib.c (solib_read_symbols): Use all_objfiles
9017
9018 2019-01-09  Tom Tromey  <tom@tromey.com>
9019
9020         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9021         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9022         all_objfiles.
9023         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9024         * symmisc.c (print_symbol_bcache_statistics)
9025         (print_objfile_statistics, maintenance_print_objfiles)
9026         (maintenance_info_symtabs, maintenance_check_symtabs)
9027         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9028         all_objfiles.
9029         * source.c (forget_cached_source_info): Use all_objfiles.
9030         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9031         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9032         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9033         * objfiles.c (update_section_map): Use all_objfiles.
9034         (shared_objfile_contains_address_p): Likewise.
9035         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9036         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9037
9038 2019-01-09  Tom Tromey  <tom@tromey.com>
9039
9040         * common/next-iterator.h: New file.
9041         * objfiles.h (class all_objfiles): New.
9042         (struct objfile_iterator): New.
9043
9044 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9045
9046         * NEWS: Move the description of the changed "frame", "select-frame",
9047          and "info frame" commands to the Changed commands section.
9048
9049 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9050
9051         * gdbtypes.c (check_stub_method_group): Remove handling of old
9052         mangling schemes.
9053         * linespec.c (find_methods): Likewise.
9054         * stabsread.c (read_member_functions): Likewise.
9055         * valops.c (search_struct_method): Likewise.
9056         (value_struct_elt_for_reference): Likewise.
9057         * NEWS: Mention this change.
9058
9059 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9060
9061         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9062         print_source_lines.
9063         * source.c (print_source_lines_base): Update line number check.
9064         (print_source_lines): New function.
9065         (source_lines_range::source_lines_range): New function.
9066         * source.h (class source_lines_range): New class.
9067         (print_source_lines): New declaration.
9068
9069 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9070
9071         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9072
9073 2019-01-08  Tom Tromey  <tom@tromey.com>
9074             Simon Marchi  <simon.marchi@ericsson.com>
9075
9076         PR gdb/24060
9077         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9078         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9079         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9080         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9081         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9082         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9083
9084 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9085
9086         * source.c (select_source_symtab): Move header comment to
9087         declaration in source.h.
9088         (forget_cached_source_info_for_objfile): Likewise.
9089         (forget_cached_source_info): Likewise.
9090         (identify_source_line): Likewise.
9091         * source.h (identify_source_line): Move declaration from symtab.h
9092         and add comment from source.c
9093         (print_source_lines): Likewise.
9094         (forget_cached_source_info_for_objfile): Likewise.
9095         (forget_cached_source_info): Likewise.
9096         (select_source_symtab): Likewise.
9097         (enum print_source_lines_flag): Move definition from symtab.h.
9098         * symtab.h (identify_source_line): Move declaration to source.h.
9099         (print_source_lines): Likewise.
9100         (forget_cached_source_info_for_objfile): Likewise.
9101         (forget_cached_source_info): Likewise.
9102         (select_source_symtab): Likewise.
9103         (enum print_source_lines_flag): Move definition to source.h.
9104         * tui/tui-hooks.c: Add 'source.h' include.
9105
9106 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9107
9108         * source.c (print_source_lines_base): Handle requests to print
9109         reverse line number sequences, and guard against empty lines
9110         string.
9111
9112 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9113
9114         * source.c (print_source_lines_base): Fix skip of '\r' if next
9115         character is '\n'.
9116
9117 2019-01-06  Tom Tromey  <tom@tromey.com>
9118
9119         * c-exp.y (struct c_parse_state) <macro_original_text,
9120         expansion_obstack>: New member.
9121         (macro_original_text, expansion_obstack): Remove globals.
9122         (scan_macro_expansion, scanning_macro_expansion)
9123         (finished_macro_expansion): Update.
9124         (scan_macro_cleanup): Remove.
9125         (yylex, c_parse): Update.
9126
9127 2019-01-06  Tom Tromey  <tom@tromey.com>
9128
9129         * c-exp.y (struct c_parse_state) <strings>: New member.
9130         (operator_stoken): Update.
9131
9132 2019-01-06  Tom Tromey  <tom@tromey.com>
9133
9134         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9135         (union type_stack_elt) <typelist_val>: Now a pointer to
9136         std::vector.
9137         (type_stack_cleanup): Don't declare.
9138         (push_typelist): Update.
9139         * parse.c (pop_typelist): Return a std::vector.
9140         (push_typelist): Take a std::vector.
9141         (follow_types): Update.  Do not free args.
9142         (type_stack_cleanup): Remove.
9143         * c-exp.y (struct c_parse_state): New.
9144         (cpstate): New global.
9145         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9146         (nonempty_typelist): Update.
9147         (func_mod): Create a new vector.
9148         (c_parse): Create a c_parse_state.
9149         (check_parameter_typelist): Do not delete params.
9150         (function_method): Update.  Do not delete type_list.
9151
9152 2019-01-06  Tom Tromey  <tom@tromey.com>
9153
9154         PR gdb/28155:
9155         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9156         check_typedef.
9157         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9158         (print_return_value): Likewise.
9159
9160 2019-01-05  Tom Tromey  <tom@tromey.com>
9161
9162         * contrib/cleanup_check.py: Remove.
9163         * contrib/gcc-with-excheck: Remove.
9164         * contrib/exsummary.py: Remove.
9165         * contrib/excheck.py: Remove.
9166
9167 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9168
9169         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9170         NULL. Initialize tpprev to NULL instead of assigning it
9171         to NULL on the next statement.
9172         * windows-nat.c (windows_delete_thread): Remove check for
9173         main_thread_id before printing thread exit notifications.
9174         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9175         Remove thread ID check against main_thread_id.
9176         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9177         windows_delete_thread.
9178         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9179
9180 2019-01-04  Tom Tromey  <tom@tromey.com>
9181
9182         * compile/compile.c (_initialize_compile): Use upper case for
9183         metasyntactic variables.
9184         * symmisc.c (_initialize_symmisc): Use upper case for
9185         metasyntactic variables.
9186         * psymtab.c (_initialize_psymtab): Use upper case for
9187         metasyntactic variables.
9188         * demangle.c (demangle_command): Use upper case for metasyntactic
9189         variables.
9190         (_initialize_demangler): Likewise.
9191         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9192         variables.
9193
9194 2019-01-03  Tom Tromey  <tom@tromey.com>
9195
9196         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9197
9198 2019-01-03  Tom Tromey  <tom@tromey.com>
9199
9200         * python/py-symtab.c (salpy_str): Update.
9201         (struct salpy_sal_object) <symtab>: Now a PyObject.
9202         (salpy_dealloc): Update.
9203         (del_objfile_sal): Use gdbpy_ref.
9204
9205 2019-01-03  Tom Tromey  <tom@tromey.com>
9206
9207         * python/py-type.c (convert_field): Use new_reference.  Return
9208         gdbpy_ref.
9209         (make_fielditem): Return gdbpy_ref.
9210         (typy_fields): Update.
9211         (typy_getitem): Update.
9212         (field_name): Return gdbpy_ref.  Use new_reference.
9213         (typy_iterator_iternext): Update.
9214
9215 2019-01-03  Tom Tromey  <tom@tromey.com>
9216
9217         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9218
9219 2019-01-03  Tom Tromey  <tom@tromey.com>
9220
9221         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9222         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9223         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9224         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9225         (pspy_set_type_printers): Likewise.
9226         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9227         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9228         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9229         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9230         (objfpy_set_type_printers): Likewise.
9231
9232 2019-01-03  Tom Tromey  <tom@tromey.com>
9233
9234         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9235         (gdbpy_print_stack): Use gdbpy_err_fetch.
9236         * python/python-internal.h (class gdbpy_err_fetch): New class.
9237         (class gdbpy_enter) <m_error_type, m_error_value,
9238         m_error_traceback>: Remove.
9239         <m_error>: New member.
9240         (gdbpy_exception_to_string): Don't declare.
9241         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9242         * python/py-value.c (convert_value_from_python): Use
9243         gdbpy_err_fetch.
9244         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9245         gdbpy_exception_to_string.
9246         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9247         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9248         gdbpy_err_fetch.
9249
9250 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9251
9252         * linux-nat.c (delete_lwp_cleanup): Delete.
9253         (struct lwp_deleter): New struct.
9254         (lwp_info_up): New typedef.
9255         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9256         lwp_info_up.
9257
9258 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9259
9260         * linux-fork.c (class scoped_switch_fork_info): New class.
9261         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9262
9263 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9264
9265         * valops.c (find_overload_match): Remove use of null_cleanup, and
9266         calls to do_cleanups.
9267
9268 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9269
9270         * compile/compile-cplus-types.c
9271         (compile_cplus_instance::decl_name): Handle changes to
9272         cp_func_name.
9273         * cp-support.c (cp_func_name): Update header comment, update
9274         return type.
9275         * cp-support.h (cp_func_name): Update return type in declaration.
9276         * valops.c (find_overload_match): Move temp_func local to top
9277         level of function and change its type.  Use temp_func to hold and
9278         delete temporary string obtained from cp_func_name.
9279
9280 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9281
9282         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9283         gdb::char_vector, remove cleanup, and update uses of `msg`.
9284
9285 2019-01-03  Jim Wilson  <jimw@sifive.com>
9286
9287         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9288
9289 2019-01-02  Tom Tromey  <tom@tromey.com>
9290
9291         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9292         (tdesc_parse_xml): Remove cleanups.
9293         * target-descriptions.h (make_cleanup_free_target_description):
9294         Don't declare.
9295         (target_desc_deleter): New struct.
9296         (target_desc_up): New typedef.
9297         * target-descriptions.c (target_desc_deleter::operator()): Rename
9298         from free_target_description.
9299         (make_cleanup_free_target_description): Remove.
9300
9301 2019-01-02  Tom Tromey  <tom@tromey.com>
9302
9303         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9304         constructor, destructor.
9305         (linespec_parser): Remove typedef.
9306         (~linespec_parser): Rename from linespec_parser_delete.
9307         (linespec_lex_to_end, linespec_complete_label)
9308         (linespec_complete): Update.
9309         (decode_line_full): Remove cleanups.
9310         (decode_line_1): Update.
9311
9312 2019-01-02  Tom Tromey  <tom@tromey.com>
9313
9314         * python/python-internal.h (inferior_to_inferior_object): Change
9315         return type.
9316         * python/py-exitedevent.c (create_exited_event_object): Update.
9317         * python/py-inferior.c (inferior_to_inferior_object): Return
9318         gdbpy_ref.
9319         (python_new_inferior, python_inferior_deleted)
9320         (thread_to_thread_object, delete_thread_object)
9321         (build_inferior_list, gdbpy_selected_inferior): Update.
9322         * python/py-infthread.c (create_thread_object): Update.  Also fail
9323         if inferior_to_inferior_object fails.
9324
9325 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9326
9327         * inferior.h (class inferior) <displaced_step_state>: New field.
9328         * infrun.h (struct displaced_step_state): Move here from
9329         infrun.c.  Initialize fields, add constructor.
9330         <inf>: Remove field.
9331         <reset>: New method.
9332         * infrun.c (struct displaced_step_inferior_state): Move to
9333         infrun.h.
9334         (displaced_step_inferior_states): Remove.
9335         (get_displaced_stepping_state): Adust.
9336         (displaced_step_in_progress_any_inferior): Adjust.
9337         (displaced_step_in_progress_thread): Adjust.
9338         (displaced_step_in_progress): Adjust.
9339         (add_displaced_stepping_state): Remove.
9340         (get_displaced_step_closure_by_addr): Adjust.
9341         (remove_displaced_stepping_state): Remove.
9342         (infrun_inferior_exit): Call displaced_step_state.reset.
9343         (use_displaced_stepping): Don't check for NULL.
9344         (displaced_step_prepare_throw): Call
9345         get_displaced_stepping_state.
9346         (displaced_step_fixup): Don't check for NULL.
9347         (prepare_for_detach): Don't check for NULL.
9348
9349 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9350
9351         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9352          in case of call that did not complete.
9353
9354 2019-01-02  Andrey Utkin  <autkin@undo.io>
9355
9356         * symfile.c (find_separate_debug_file): Fix search of debug files for
9357         remote debuggee.
9358
9359 2019-01-02  Tom Tromey  <tom@tromey.com>
9360
9361         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9362         indentation.
9363         * python/py-frame.c (frapy_older): Remove cast.
9364         (frapy_newer): Likewise.
9365         * python/py-breakpoint.c (local_setattro): Remove cast.
9366         * python/py-arch.c (archpy_name): Remove local variable.
9367         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9368
9369 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9370
9371         * unittests/basic_string_view/element_access/char/empty.cc:
9372         Fix year range in copyright header.
9373
9374 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9375
9376         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9377         Delete.
9378         <operator==>: Update with for removed field.
9379         <hash>: Likewise.
9380         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9381         <isa_features>: ...this.
9382         <abi_features>: New field.
9383         (riscv_isa_flen): Update comment.
9384         (riscv_abi_xlen): New declaration.
9385         (riscv_abi_flen): New declaration.
9386         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9387         isa_features.
9388         (riscv_abi_xlen): New function.
9389         (riscv_isa_flen): Update to get answer from isa_features.
9390         (riscv_abi_flen): New function.
9391         (riscv_has_fp_abi): Update to get answer from abi_features.
9392         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9393         xlen and flen.
9394         (riscv_call_info) <xlen, flen>: Update comment.
9395         (riscv_call_arg_struct): Remove invalid assertions
9396         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9397         is removed.
9398         (riscv_gdbarch_init): Gather isa features and abi features
9399         separately, ensure both match on the gdbarch when reusing an old
9400         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9401         a target with 64-bit float hardware.
9402
9403 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9404
9405         * source.c (search_command_helper): Stop reverse search
9406         when line 1 has been searched.
9407
9408 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9409
9410         * record-full.c (record_full_base_target::close): Rewrite
9411         record_full_core_buf_list free logic.
9412
9413 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9414
9415         * break-catch-syscall.c (print_one_catch_syscall): xfree
9416         the last text.
9417
9418 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9419
9420         * top.c (print_gdb_version): Update Copyright year in version
9421         message.
9422
9423 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9424
9425         Update copyright year range in all GDB files.
9426
9427 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9428
9429         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9430
9431 For older changes see ChangeLog-2018.
9432 \f
9433 Local Variables:
9434 mode: change-log
9435 left-margin: 8
9436 fill-column: 74
9437 version-control: never
9438 coding: utf-8
9439 End:
9440