gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (tui_erase_source_content)
   4         (tui_clear_source_content): Remove "display_prompt" parameter.
   5         * tui/tui-winsource.c (tui_update_source_window_as_is)
   6         (tui_update_source_windows_with_addr): Update.
   7         (tui_clear_source_content): Remove "display_prompt" parameter.
   8         (tui_erase_source_content): Likewise.  Simplify.
   9         (tui_show_source_content): Update.
  10         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  11         * tui/tui-stack.c (tui_show_frame_info): Update.
  12         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
  13         Remove defines.
  14
  15 2019-07-17  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  18         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
  19         parameter.
  20         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
  21         parameter.
  22
  23 2019-07-17  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-winsource.c (tui_clear_source_content)
  26         (tui_show_source_content, tui_show_exec_info_content)
  27         (tui_clear_exec_info_content): Update.
  28         * tui/tui-stack.c (tui_show_locator_content): Update.
  29         (tui_show_frame_info): Update.
  30         * tui/tui-source.h (tui_source_window): Don't declare.
  31         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
  32         from tui_source_is_displayed.
  33         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
  34         Remove field.
  35         (struct tui_source_window_base) <content_in_use>: New field.  Now
  36         bool.
  37         (struct tui_source_window) <showing_source_p>: New method.
  38         (TUI_SRC_WIN): Change cast.
  39         * tui/tui-data.c (tui_initialize_static_data): Update.
  40
  41 2019-07-17  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
  44         location_matches_p.
  45         * tui/tui-source.c (tui_source_window::location_matches_p): New
  46         method.
  47         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
  48         method.
  49         * tui/tui-data.h (struct tui_source_window_base)
  50         <location_matches_p>: New method.
  51         (struct tui_source_window, struct tui_disasm_window)
  52         <location_matches_p>: Likewise.
  53
  54 2019-07-17  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-win.c (tui_set_win_height_command): Rename from
  57         tui_set_win_height.
  58         (tui_set_win_height_command): Remove.
  59
  60 2019-07-17  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-source.c (tui_source_window): New constructor.  Add
  63         observer.
  64         (~tui_source_window): New destructor.
  65         (tui_source_window::style_changed): New method.
  66         * tui/tui-hooks.c (tui_redisplay_source): Remove.
  67         (tui_attach_detach_observers): Update.
  68         * tui/tui-data.h (struct tui_source_window): Make constructor not
  69         inline.  Add destructor.
  70         (struct tui_source_window) <style_changed>: New method.
  71         <m_observable>: New member.
  72
  73 2019-07-17  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
  76         * tui/tui-win.c (tui_resize_all): Fix typo.
  77
  78 2019-07-17  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-wingeneral.h (tui_refresh_all): Update.
  81         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
  82         (tui_refresh_all): Remove "list" parameter.  Use foreach.
  83         * tui/tui-win.c (window_name_completer): Use foreach.
  84         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
  85         (update_tab_width): Likewise.
  86         * tui/tui-layout.c (show_layout): Update.
  87         * tui/tui-data.h (class tui_window_iterator): New.
  88         (struct all_tui_windows): New.
  89         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
  90
  91 2019-07-17  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
  94         parameter.  Don't reference globals.
  95         (tui_reg_command): Update.
  96
  97 2019-07-17  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-regs.c (tui_show_registers): Simplify.
 100
 101 2019-07-17  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-regs.c (tui_show_registers): Update.
 104         (tui_show_register_group): Add win_info parameter.
 105
 106 2019-07-17  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 109         Rename from tui_display_reg_element_at_line.
 110         (tui_data_window::display_registers_from_line): Update.
 111         * tui/tui-data.h (struct tui_data_window)
 112         <display_reg_element_at_line>: New method.
 113
 114 2019-07-17  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-regs.h (tui_display_registers_from)
 117         (tui_display_registers_from_line): Don't declare.
 118         * tui/tui-windata.c (tui_data_window::display_all_data)
 119         (tui_data_window::refresh_all)
 120         (tui_data_window::do_scroll_vertical): Update.
 121         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 122         from tui_display_registers_from.
 123         (tui_display_reg_element_at_line): Update.
 124         (tui_data_window::display_registers_from_line): Rename from
 125         tui_display_registers_from_line.
 126         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 127         display_registers_from_line>: New methods.
 128
 129 2019-07-17  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 132         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 133         from tui_erase_data_content.
 134         (tui_data_window::display_all_data)
 135         (tui_data_window::refresh_all)
 136         (tui_data_window::do_scroll_vertical): Update.
 137         * tui/tui-regs.c (tui_show_registers): Update.
 138         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 139         New method.
 140
 141 2019-07-17  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 144         declare.
 145         * tui/tui-windata.c
 146         (tui_data_window::delete_data_content_windows): Rename from
 147         tui_delete_data_content_windows.
 148         (tui_data_window::display_all_data)
 149         (tui_data_window::do_scroll_vertical): Update.
 150         * tui/tui-data.h (struct tui_data_window)
 151         <delete_data_content_windows>: New method.
 152
 153 2019-07-17  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 156         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 157
 158 2019-07-17  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 161         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 162         from tui_display_all_data.
 163         * tui/tui-win.c
 164         (tui_data_window::do_make_visible_with_new_height): Update.
 165         * tui/tui-regs.c (tui_show_registers): Update.
 166         * tui/tui-layout.c (tui_set_layout): Update.
 167         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 168         method.
 169
 170 2019-07-17  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 173         * tui/tui-windata.c (tui_display_data_from): Remove.
 174         (tui_data_window::refresh_all): Update.
 175
 176 2019-07-17  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 179         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 180         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 181         tui_display_registers_from_line.
 182         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 183         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 184         "force_display" parameter.
 185
 186 2019-07-17  Tom Tromey  <tom@tromey.com>
 187
 188         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 189         declare.
 190         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 191         Rename from tui_first_reg_element_no_inline.
 192         (tui_display_reg_element_at_line)
 193         (tui_display_registers_from_line): Update.
 194         * tui/tui-data.h (struct tui_data_window)
 195         <first_reg_element_no_inline>: New method.
 196
 197 2019-07-17  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-windata.c (tui_display_data_from)
 200         (tui_data_window::do_scroll_vertical): Update.
 201         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 202         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 203         Rename from tui_line_from_reg_element_no.
 204         (tui_display_registers_from_line): Update.
 205         * tui/tui-data.h (struct tui_data_window)
 206         <line_from_reg_element_no>: New method.
 207
 208 2019-07-17  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 211         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 212         tui_last_regs_line_no.
 213         (tui_display_reg_element_at_line)
 214         (tui_display_registers_from_line): Update.
 215         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 216         method.
 217
 218 2019-07-17  Tom Tromey  <tom@tromey.com>
 219
 220         PR tui/24722:
 221         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 222         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 223         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 224         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 225         (tui_update_breakpoint_info): Likewise.
 226         * tui/tui-hooks.c (tui_event_create_breakpoint)
 227         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 228         Update.
 229
 230 2019-07-17  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 233
 234 2019-07-17  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-winsource.c (tui_update_source_window_as_is)
 237         (tui_update_source_windows_with_addr): Update.
 238         * tui/tui-source.h (tui_set_source_content)
 239         (tui_show_symtab_source): Add "win_info" parameter.
 240         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 241         parameter.
 242         (tui_show_symtab_source): Likewise.
 243
 244 2019-07-17  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-wingeneral.c
 247         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 248
 249 2019-07-17  Tom Tromey  <tom@tromey.com>
 250
 251         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 252         (struct tui_cmd_window) <can_scroll>: New method.
 253         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 254         method.
 255
 256 2019-07-17  Tom Tromey  <tromey@adacore.com>
 257
 258         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 259         do_field_signed>: Rename.  Change type of "value".
 260         * ui-out.c (ui_out::field_signed): Rename from field_int.
 261         Change type of "value".
 262         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 263         type of "value".
 264         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 265         do_field_int.  Change type of "value".
 266         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 267         do_field_int.  Change type of "value".
 268         * tracepoint.c (trace_status_mi, tfind_1)
 269         (print_one_static_tracepoint_marker): Update.
 270         * thread.c (print_thread_info_1, print_selected_thread_frame):
 271         Update.
 272         * stack.c (print_frame, print_frame_info): Update.
 273         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 274         Update.
 275         * source.c (print_source_lines_base): Update.
 276         * skip.c (info_skip_command): Update.
 277         * record-btrace.c (btrace_ui_out_decode_error)
 278         (btrace_call_history_src_line): Update.
 279         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 280         Update.
 281         * progspace.c (print_program_space): Update.
 282         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 283         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 284         do_field_int.  Change type of "value".
 285         * mi/mi-out.c (mi_ui_out::do_table_begin)
 286         (mi_ui_out::do_table_header): Update.
 287         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 288         type of "value".
 289         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 290         (mi_cmd_data_list_changed_registers, output_register)
 291         (mi_cmd_data_read_memory, mi_load_progress)
 292         (mi_cmd_trace_frame_collected): Update.
 293         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 294         Update.
 295         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 296         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 297         (mi_cmd_var_list_children, varobj_update_one): Update.
 298         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 299         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 300         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 301         * inferior.c (print_inferior): Update.
 302         * gdb_bfd.c (print_one_bfd): Update.
 303         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 304         Update.
 305         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 306         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 307         do_field_int.  Change type of "value".
 308         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 309         do_field_int.  Change type of "value".
 310         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 311         (print_one_breakpoint_location, print_it_catch_fork)
 312         (print_one_catch_fork, print_it_catch_vfork)
 313         (print_one_catch_vfork, print_it_catch_solib)
 314         (print_it_catch_exec, print_it_ranged_breakpoint)
 315         (print_mention_watchpoint, print_mention_masked_watchpoint)
 316         (bkpt_print_it, update_static_tracepoint): Update.
 317         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 318         * break-catch-syscall.c (print_it_catch_syscall): Update.
 319         * ada-tasks.c (print_ada_task_info): Update.
 320         * ada-lang.c (print_it_exception, print_mention_exception):
 321         Update.
 322
 323 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 324
 325         PR breakpoints/24541
 326         * gdbarch.c: Regenerate.
 327         * gdbarch.h: Regenerate.
 328         * gdbarch.sh: Adjust return type and parameter types for
 329         'stap_adjust_register'.
 330         (i386_stap_adjust_register): Adjust signature and return new
 331         register name.
 332         * stap-probe.c (stap_parse_register_operand): Adjust use of
 333         'gdbarch_stap_adjust_register'.
 334
 335 2019-07-17  Tom Tromey  <tromey@adacore.com>
 336
 337         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 338         declare VEC.
 339         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 340         std::vector.
 341         (struct s390_process_info): Add initializers.
 342         (s390_add_process): Use new.
 343         (s390_linux_nat_target::low_forget_process): Use delete.
 344         (s390_linux_nat_target::low_new_fork)
 345         (s390_linux_nat_target::stopped_by_watchpoint)
 346         (s390_linux_nat_target::low_prepare_to_resume)
 347         (s390_linux_nat_target::insert_watchpoint)
 348         (s390_linux_nat_target::insert_hw_breakpoint)
 349         (s390_linux_nat_target::remove_watchpoint)
 350         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 351
 352 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 353
 354         * aarch64-fbsd-nat.c: Include regcache.h.
 355         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 356         argument.
 357         (aarch64_fbsd_nat_target::fetch_registers)
 358         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 359         variable.
 360         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 361
 362 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 363
 364         * fbsd-nat.c: Include gdbarch.h.
 365
 366 2019-07-15  Tom Tromey  <tromey@adacore.com>
 367
 368         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 369
 370 2019-07-15  Tom Tromey  <tromey@adacore.com>
 371
 372         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 373         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 374         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 375         * cli-out.c (cli_ui_out::do_field_int): New method.
 376         * ui-out.c (ui_out::field_unsigned): New method.
 377         * symfile.c (generic_load): Use field_unsigned.
 378         (print_transfer_performance): Likewise.
 379         * record-btrace.c (ui_out_field_uint): Remove.
 380         (btrace_call_history_insn_range, btrace_call_history): Use
 381         field_unsigned.
 382         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 383         field_unsigned.
 384         * ui-out.h (class ui_out) <field_unsigned>: New method.
 385         <do_field_unsigned>: Likewise.
 386
 387 2019-07-15  Tom Tromey  <tromey@adacore.com>
 388
 389         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 390         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 391         * target.c (flash_erase_command): Use field_string.
 392         * infrun.c (print_signal_received_reason): Use field_string.
 393         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 394         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 395         field_string.
 396         * ada-tasks.c (print_ada_task_info): Use field_string.
 397
 398 2019-07-15  Tom Tromey  <tromey@adacore.com>
 399
 400         * target.c (flash_erase_command): Use field_core_addr.
 401         * symfile.c (generic_load): Use field_core_addr.
 402         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 403         Use field_core_addr.
 404         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 405         field_core_addr.
 406
 407 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 408
 409         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 410         value if its desired type is smaller than a CORE_ADDR and signed.
 411
 412 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 413
 414         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 415         of changes to field names, and use new is_reference field to
 416         decide if a property is a reference or not.
 417         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 418         field.
 419         (struct dwarf2_property_baton): Update header comment, rename
 420         'referenced_type' to 'property_type' and update comments.
 421         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 422         default property type, store in property baton, update to take
 423         accound of renamed field.
 424         (read_func_scope): Update call to attr_to_dynamic_prop.
 425         (read_array_type): Likewise.
 426         (dwarf2_per_cu_addr_sized_int_type): New function.
 427         (read_subrange_index_type): Move type finding code to
 428         dwarf2_per_cu_addr_sized_int_type.
 429         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 430         (dwarf2_per_cu_addr_type): New function.
 431         (set_die_type): Update calls to attr_to_dynamic_prop.
 432
 433 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 434
 435         * dwarf2read.c (read_subrange_index_type): New function.
 436         (read_subrange_type): Move code into new function and call it.
 437         * gdbtypes.c (create_range_type): Add some asserts.
 438
 439 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 440
 441         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 442         update return statements.
 443         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 444         declaration, and update comment to match.
 445         * gdbtypes.c (resolve_dynamic_array): Update call to
 446         dwarf2_evaluate_property to match new return type.
 447
 448 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 449
 450         * valarith.c (value_subscripted_rvalue): Change lowerbound
 451         parameter type from int to LONGEST.
 452         * value.h (value_subscripted_rvalue): Likewise in declaration.
 453
 454 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 455
 456         * cli/cli-utils.c (info_print_command_completer): New function.
 457         * cli/cli-utils.h: Add 'completer.h' include, and forward
 458         declaration for 'struct cmd_list_element'.
 459         (info_print_command_completer): Declare.
 460         * stack.c (_initialize_stack): Add completer for 'info locals' and
 461         'info args'.
 462         * symtab.c (_initialize_symtab): Add completer for 'info
 463         variables' and 'info functions'.
 464         * NEWS: Mention completion for additional info commands.
 465
 466 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 467
 468         * cli/cli-utils.c (extract_info_print_args): Delete.
 469         (extract_arg_maybe_quoted): Delete.
 470         (info_print_options_defs): New variable.
 471         (make_info_print_options_def_group): New function.
 472         (extract_info_print_options): Define new function.
 473         * cli/cli-utils.h (extract_info_print_args): Delete.
 474         (struct info_print_options): New structure.
 475         (extract_info_print_options): Declare new function.
 476         * stack.c (info_locals_command): Update to use new
 477         extract_info_print_options, also add a header comment.
 478         (info_args_command): Likewise.
 479         * symtab.c (info_variables_command): Likewise.
 480         (info_functions_command): Likewise.
 481
 482 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 483
 484         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 485         to extract string arguments.
 486         * common/common-utils.c (extract_string_maybe_quoted): New function.
 487         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 488
 489 2019-07-11  Tom Tromey  <tromey@adacore.com>
 490
 491         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 492         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 493         * top.h (gdbinit): Don't declare.
 494         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 495         into...
 496         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 497         * top.c (gdb_init): Don't call init_cli_cmds.
 498         (gdbinit): Remove.
 499         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 500
 501 2019-07-11  Tom Tromey  <tromey@adacore.com>
 502
 503         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 504         after it has been moved.
 505
 506 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 507
 508         * valops.c (value_must_coerce_to_target): Change return type to
 509         bool.
 510         * value.h (value_must_coerce_to_target): Likewise.
 511
 512 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 513
 514         * breakpoint.c (is_hardware_watchpoint): Remove
 515         forward-declaration.
 516         (is_masked_watchpoint): Change return type to bool.
 517         (is_tracepoint): Likewise.
 518         (is_breakpoint): Likewise.
 519         (is_hardware_watchpoint): Likewise.
 520         (is_watchpoint): Likewise.
 521         (is_no_memory_software_watchpoint): Likewise.
 522         (is_catchpoint): Likewise.
 523         (breakpoint_1): Make FILTER parameter's return type bool.
 524         is_masked_watchpoint): Change return type to bool.
 525         (save_breakpoints): Make FILTER parameter's return type bool.
 526         * breakpoint.h (is_breakpoint): Change return type to bool.
 527         (is_watchpoint): Likewise.
 528         (is_catchpoint): Likewise.
 529         (is_tracepoint): Likewise.
 530
 531 2019-07-10  Tom Tromey  <tom@tromey.com>
 532
 533         * defs.h: Don't include gdbarch.h.
 534         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 535         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 536         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 537         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 538         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 539         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 540         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 541         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 542         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 543         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 544         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 545         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 546         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 547         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 548         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 549         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 550         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 551         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 552         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 553         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 554         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 555         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 556         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 557         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 558         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 559         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 560         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 561
 562 2019-07-10  Tom Tromey  <tromey@adacore.com>
 563
 564         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 565         * breakpoint.c (init_ada_exception_breakpoint): Register as
 566         bp_catchpoint.
 567         (print_one_breakpoint_location, print_one_breakpoint): Use
 568         is_ada_exception_catchpoint.
 569         * ada-lang.c (class ada_catchpoint_location): Pass
 570         bp_loc_software_breakpoint to bp_location constructor.
 571         (is_ada_exception_catchpoint): New function.
 572
 573 2019-07-10  Tom Tromey  <tromey@adacore.com>
 574
 575         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 576         VEC.
 577         (struct arm_exidx_entry): New method operator<.
 578         (struct arm_exidx_data) <section_maps>: Change type.
 579         (arm_exidx_data_free): Remove.
 580         (arm_exidx_data_key): Change type.  Move lower.
 581         (arm_exidx_new_objfile): Update.
 582         (arm_compare_exidx_entries): Remove.
 583         (arm_find_exidx_entry, _initialize_arm_tdep)
 584
 585 2019-07-10  Tom Tromey  <tromey@adacore.com>
 586
 587         * solib-spu.c (ocl_program_data_key): Change type.
 588         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 589         Update.
 590
 591 2019-07-10  Tom Tromey  <tromey@adacore.com>
 592
 593         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 594         (struct solib_aix_inferior_data) <library_list>: Change type.
 595         (solib_aix_inferior_data_handle): Change type.
 596         (get_solib_aix_inferior_data): Update.
 597         (solib_aix_free_library_list): Remove.
 598         (library_list_start_library): Update.
 599         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 600         return type.
 601         (solib_aix_get_library_list)
 602         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 603         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 604
 605 2019-07-10  Tom Tromey  <tromey@adacore.com>
 606
 607         * solib-dsbt.c (struct dsbt_info): Add initializers.
 608         (solib_dsbt_pspace_data): Change type.
 609         (dsbt_pspace_data_cleanup): Remove.
 610         (get_dsbt_info, _initialize_dsbt_solib): Update.
 611
 612 2019-07-10  Tom Tromey  <tromey@adacore.com>
 613
 614         * spu-tdep.c (spu_overlay_data): Change type.
 615         (spu_get_overlay_table, spu_overlay_new_objfile)
 616         (_initialize_spu_tdep): Update.
 617
 618 2019-07-10  Tom Tromey  <tromey@adacore.com>
 619
 620         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 621         destructor.
 622         (dbx_objfile_data_key): Change type and declare later.
 623         (DBX_SYMFILE_INFO): Rewrite.
 624         * dbxread.c (dbx_objfile_data_key): Change type.
 625         (dbx_symfile_init): Update.
 626         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 627         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 628         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 629
 630 2019-07-10  Tom Tromey  <tromey@adacore.com>
 631
 632         * jit.c (jit_program_space_key): Change type.  Move lower.
 633         (get_jit_program_space_data): Update.
 634         (jit_program_space_data_cleanup): Remove.
 635         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 636         Update.
 637         (struct jit_program_space_data): Add initializers.
 638
 639 2019-07-10  Tom Tromey  <tromey@adacore.com>
 640
 641         * solib-darwin.c (struct darwin_info): Add initializers.
 642         (solib_darwin_pspace_data): Change type.
 643         (darwin_pspace_data_cleanup): Remove.
 644         (get_darwin_info, _initialize_darwin_solib): Update.
 645
 646 2019-07-10  Tom Tromey  <tromey@adacore.com>
 647
 648         * remote-sim.c (struct sim_inferior_data): Add initializers,
 649         constructor, and destructor.
 650         (sim_inferior_data_key): Change type.  Move lower.
 651         (check_for_duplicate_sim_descriptor): Update.
 652         (get_sim_inferior_data): Use new.  Update.
 653         (~sim_inferior_data_cleanup): Rename from
 654         sim_inferior_data_cleanup.  Simplify.
 655         (gdbsim_close_inferior, simulator_command)
 656         (sim_command_completer, _initialize_remote_sim): Update.
 657         (next_pid, INITIAL_PID): Move earlier.
 658
 659 2019-07-10  Tom Tromey  <tromey@adacore.com>
 660
 661         * python/python-internal.h (create_thread_object): Return
 662         gdbpy_ref.
 663         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 664         * python/py-inferior.c (struct threadlist_entry): Add
 665         constructor.
 666         <thread_obj>: Now a gdbpy_ref.
 667         (thread_to_thread_object): Update.
 668         (add_thread_object): Use new.
 669         (delete_thread_object): Use delete.
 670         (infpy_threads): Update.
 671         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 672         GIL.
 673
 674 2019-07-10  Tom Tromey  <tromey@adacore.com>
 675
 676         * valops.c (value_cast): Specialize error message for Ada.
 677
 678 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 679
 680         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 681
 682 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 683
 684         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 685         bpstat_should_step): Return bool, adjust comments.
 686         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 687         bpstat_should_step): Likewise.
 688
 689 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 690
 691         * features/Makefile: Use feature target descriptions for Arm.
 692         * features/arm/arm-core.c: Generate new file.
 693         * features/arm/arm-fpa.c: Likewise.
 694         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 695         * features/arm/arm-m-profile.c: Likewise.
 696         * features/arm/arm-vfpv2.c: Likewise.
 697         * features/arm/arm-vfpv3.c: Likewise.
 698         * features/arm/xscale-iwmmxt.c: Likewise.
 699         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 700
 701 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 702
 703         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 704         ptrace earlier.
 705
 706 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 707
 708         * features/aarch64-pauth.c: Regenerate.
 709
 710 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 711
 712         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 713         bool.
 714         (bpstat_what): Use false instead of 0.
 715
 716 2019-07-09  Pedro Alves  <palves@redhat.com>
 717
 718         * break-catch-throw.c (is_exception_catchpoint): New.
 719         * breakpoint.c (print_one_breakpoint_location): New parameter
 720         'raw_loc'.  Handle it.  Use
 721         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 722         looking at the breakpoint's type.
 723         (print_one_breakpoint): If handling "maint info breakpoints", also
 724         print locations of exception catchpoints.
 725         * breakpoint.h (is_exception_catchpoint): Declare.
 726
 727 2019-07-09  Pedro Alves  <palves@redhat.com>
 728
 729         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 730         "addr" field.
 731         (allocate_location_exception_catchpoint): New.
 732         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 733         (initialize_throw_catchpoint_ops): Install
 734         allocate_location_exception_catchpoint as allocate_location
 735         method.
 736         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 737         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 738         bp_loc_other.
 739         (breakpoint_address_is_meaningful): Delete.
 740         (bl_address_is_meaningful): New.
 741         (breakpoint_locations_match): Adjust comment.
 742         (bp_location_from_bp_type): New, factored out of...
 743         (bp_location::bp_location(breakpoint *)): ... this.
 744         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 745         factored out of...
 746         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 747         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 748         breakpoint_address_is_meaningful.
 749         (bp_locations_compare): Adjust comment.
 750         (update_global_location_list): Use bl_address_is_meaningful
 751         instead of breakpoint_address_is_meaningful.
 752         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 753         explicit.
 754         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 755         * python/py-breakpoint.c (bppy_get_location): No longer check
 756         whether location is null.
 757
 758 2019-07-09  Pedro Alves  <palves@redhat.com>
 759
 760         PR c++/15468
 761         * breakpoint.c (print_one_breakpoint_location): Remove
 762         single-location assert.
 763
 764 2019-07-09  Tom Tromey  <tom@tromey.com>
 765
 766         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 767         * configure: Rebuild.
 768         * configure.ac: Change common to gdbsupport.
 769         * gdbsupport: Rename from common.
 770         * acinclude.m4: Change common to gdbsupport.
 771         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 772         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 773         gdbsupport.
 774         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 775         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 776         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 777         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 778         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 779         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 780         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 781         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 782         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 783         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 784         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 785         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 786         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 787         coff-pe-read.c, command.h, compile/compile-c-support.c,
 788         compile/compile-c.h, compile/compile-cplus-symbols.c,
 789         compile/compile-cplus-types.c, compile/compile-cplus.h,
 790         compile/compile-loc2c.c, compile/compile.c, completer.c,
 791         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 792         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 793         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 794         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 795         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 796         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 797         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 798         features/aarch64-core.c, features/aarch64-fpu.c,
 799         features/aarch64-pauth.c, features/aarch64-sve.c,
 800         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 801         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 802         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 803         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 804         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 805         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 806         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 807         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 808         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 809         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 810         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 811         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 812         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 813         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 814         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 815         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 816         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 817         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 818         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 819         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 820         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 821         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 822         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 823         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 824         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 825         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 826         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 827         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 828         minsyms.c, mips-linux-tdep.c, namespace.h,
 829         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 830         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 831         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 832         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 833         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 834         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 835         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 836         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 837         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 838         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 839         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 840         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 841         procfs.c, producer.c, progspace.h, psymtab.h,
 842         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 843         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 844         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 845         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 846         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 847         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 848         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 849         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 850         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 851         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 852         target-memory.c, target.c, target.h, target/waitstatus.c,
 853         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 854         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 855         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 856         unittests/array-view-selftests.c,
 857         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 858         unittests/common-utils-selftests.c,
 859         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 860         unittests/format_pieces-selftests.c,
 861         unittests/function-view-selftests.c,
 862         unittests/lookup_name_info-selftests.c,
 863         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 864         unittests/mkdir-recursive-selftests.c,
 865         unittests/observable-selftests.c,
 866         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 867         unittests/parse-connection-spec-selftests.c,
 868         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 869         unittests/scoped_fd-selftests.c,
 870         unittests/scoped_mmap-selftests.c,
 871         unittests/scoped_restore-selftests.c,
 872         unittests/string_view-selftests.c, unittests/style-selftests.c,
 873         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 874         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 875         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 876         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 877         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 878         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 879
 880 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 881
 882         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 883         bool value.
 884         (decode_digits_ordinary): Set explicit_line field in sal.
 885         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 886         symtab_and_line that was set on an explicit line number in
 887         assembler code.  Do always update the recorded symtab and line if
 888         we do skip the prologue.
 889
 890 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 891
 892         * breakpoint.c (set_breakpoint_location_function): Remove
 893         explicit_loc parameter.
 894         (momentary_breakpoint_from_master): Update call to
 895         set_breakpoint_location_function.
 896         (add_location_to_breakpoint): Likewise.
 897
 898 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 899
 900         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 901         required features based on default bfd type when no specific bfd
 902         is present.
 903
 904 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 905
 906         * NEWS: Mention that GDB printf and eval commands can now print
 907         C-style and Ada-style convenience var strings without
 908         calling the inferior.
 909         * printcmd.c (printf_c_string): Locally print GDB internal var
 910         instead of transiting via the inferior.
 911         (printf_wide_c_string): Likewise.
 912
 913 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 914
 915         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 916
 917 2019-07-04  Tom Tromey  <tom@tromey.com>
 918
 919         PR tui/24724:
 920         * tui/tui-winsource.c (tui_clear_source_content): Update.
 921         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 922         (tui_update_breakpoint_info): Update.
 923         (tui_set_exec_info_content): Update.
 924         * tui/tui-source.c (tui_set_source_content_nil): Update.
 925         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 926         has_break.
 927         * tui/tui-data.h (enum tui_bp_flag): New.
 928         (tui_bp_flags): New enum flags type.
 929         (struct tui_source_element) <break_mode>: Change type.  Rename
 930         from has_break.
 931         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 932         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 933         constants.
 934         * tui/tui-winsource.h: Fix comment.
 935
 936 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 937
 938         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 939         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 940         (store_fpregs_to_thread)
 941         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 942         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 943         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 944         (IWMMXT_REGS_SIZE): Add define.
 945         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 946         (fetch_vfp_regs, store_vfp_regs)
 947         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 948         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 949
 950 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 951
 952         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 953         defines.
 954         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 955         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 956         (ARM_INT_REGISTER_SIZE): ...to this.
 957         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 958         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 959         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 960         (arm_linux_collect_gregset, supply_nwfpe_register)
 961         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 962         defines.
 963         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 964         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 965         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 966         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 967         (arm_return_in_memory, arm_store_return_value)
 968         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 969         (arm_record_ld_st_multiple): Likewise.
 970         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 971         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 972
 973 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 974
 975         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 976         AARCH64_DISPLACED_MODIFIED_INSNS.
 977         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 978         (aarch64_displaced_step_copy_insn): Likewise.
 979         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 980         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 981         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 982         ARM_DISPLACED_MODIFIED_INSNS.
 983         * arm-tdep.c (arm_gdbarch_init): Likewise.
 984         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 985         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 986         (struct arm_displaced_step_closure): Use
 987         ARM_DISPLACED_MODIFIED_INSNS.
 988
 989 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 990
 991         * features/Makefile: Remove unused xml files.
 992         * features/aarch64.xml: Remove.
 993         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 994         * features/i386/amd64-avx-avx512.xml: Remove.
 995         * features/i386/amd64-avx-linux.xml: Remove.
 996         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 997         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 998         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 999         * features/i386/amd64-avx-mpx.xml: Remove.
1000         * features/i386/amd64-avx.xml: Remove.
1001         * features/i386/amd64-linux.xml: Remove.
1002         * features/i386/amd64-mpx-linux.xml: Remove.
1003         * features/i386/amd64-mpx.xml: Remove.
1004         * features/i386/amd64.xml: Remove.
1005         * features/i386/i386-avx-avx512-linux.xml: Remove.
1006         * features/i386/i386-avx-avx512.xml: Remove.
1007         * features/i386/i386-avx-linux.xml: Remove.
1008         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1009         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1010         * features/i386/i386-avx-mpx-linux.xml: Remove.
1011         * features/i386/i386-avx-mpx.xml: Remove.
1012         * features/i386/i386-avx.xml: Remove.
1013         * features/i386/i386-linux.xml: Remove.
1014         * features/i386/i386-mmx-linux.xml: Remove.
1015         * features/i386/i386-mmx.xml: Remove.
1016         * features/i386/i386-mpx-linux.xml: Remove.
1017         * features/i386/i386-mpx.xml: Remove.
1018         * features/i386/i386.xml: Remove.
1019         * features/i386/x32-avx-avx512-linux.xml: Remove.
1020         * features/i386/x32-avx-linux.xml: Remove.
1021         * features/i386/x32-linux.xml: Remove.
1022
1023 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1024
1025         * regformats/aarch64.dat: Remove.
1026         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1027         * regformats/i386/amd64-avx-linux.dat: Remove.
1028         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1029         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1030         * regformats/i386/amd64-linux.dat: Remove.
1031         * regformats/i386/amd64-mpx-linux.dat: Remove.
1032         * regformats/i386/amd64.dat: Remove.
1033         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1034         * regformats/i386/i386-avx-linux.dat: Remove.
1035         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1036         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1037         * regformats/i386/i386-linux.dat: Remove.
1038         * regformats/i386/i386-mmx-linux.dat: Remove.
1039         * regformats/i386/i386-mpx-linux.dat: Remove.
1040         * regformats/i386/i386.dat: Remove.
1041         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1042         * regformats/i386/x32-avx-linux.dat: Remove.
1043         * regformats/i386/x32-linux.dat: Remove.
1044
1045 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1046
1047         * aarch64-tdep.c: Remove xml self tests.
1048         * amd64-linux-tdep.c: Likewise.
1049         * amd64-tdep.c: Likewise.
1050         * i386-linux-tdep.c: Likewise.
1051         * i386-tdep.c: Likewise.
1052
1053 2019-07-03  Pedro Alves  <palves@redhat.com>
1054
1055         PR cli/24732
1056         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1057         (pipe_cmd_option_defs): New.
1058         (make_pipe_cmd_options_def_group): New.
1059         (pipe_command): Use gdb::option::process_options.
1060         (pipe_command_completer): New function.
1061         (_initialize_cli_cmds): Install completer for "pipe" command.
1062
1063 2019-07-03  Pedro Alves  <palves@redhat.com>
1064
1065         * cli/cli-option.c (union option_value) <string>: New field.
1066         (struct option_def_and_value): Add ctor, move ctor, dtor and
1067         use DISABLE_COPY_AND_ASSIGN.
1068         (option_def_and_value::clear_value): New.
1069         (parse_option, save_option_value_in_ctx, get_val_type_str)
1070         (add_setshow_cmds_for_options): Handle var_string.
1071         * cli-option.h (union option_def::var_address) <string>: New
1072         field.
1073         (struct string_option_def): New.
1074         * maint-test-options.c (struct test_options_opts): Add default
1075         ctor and use DISABLE_COPY_AND_ASSIGN.
1076         <string_opt>: New field.
1077         (test_options_opts::~test_options_opts): New.
1078         (test_options_opts::dump): Also dump "-string".
1079         (test_options_option_defs): Install "string.
1080
1081 2019-07-03  Pedro Alves  <palves@redhat.com>
1082
1083         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1084         option_value with a null enumeration.
1085         (complete_options): Save the option values in the context.
1086         (save_option_value_in_ctx): New, factored out from ...
1087         (process_options): ... here.
1088         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1089         of the function.
1090         * maint-test-options.c (test_options_opts::dump): New, factored
1091         out from ...
1092         (maintenance_test_options_command_mode): ... here.
1093         (maintenance_test_options_command_completion_result): Delete.
1094         (maintenance_test_options_command_completion_text): Update
1095         comment.
1096         (maintenance_show_test_options_completion_result): Change
1097         prototype.  Just print
1098         maintenance_test_options_command_completion_text.
1099         (save_completion_result): New.
1100         (maintenance_test_options_completer_mode): Pass options context to
1101         complete_options, and then save a dump.
1102         (_initialize_maint_test_options): Use add_cmd to install "maint
1103         show test-options-completion-result".
1104
1105 2019-07-03  Pedro Alves  <palves@redhat.com>
1106
1107         * NEWS (New commands): Mention "with" and "maint with".
1108         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1109         (with_command, with_command_completer): New.
1110         (pipe_command): Adjust to new repeat_previous
1111         interface.
1112         (_initialize_cli_cmds): Install the "with" command and its "w"
1113         alias.
1114         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1115         declarations.
1116         * cli/cli-setshow.c (parse_cli_var_uinteger)
1117         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1118         argument strings for all var_types.
1119         (get_setshow_command_value_string): New, factored out from ...
1120         (do_show_command): ... this.
1121         * cli/cli-setshow.h: Include <string>.
1122         (get_setshow_command_value_string): Declare.
1123         * command.h (repeat_previous): Now returns const char *.  Adjust
1124         comment.
1125         * maint.c: Include "cli/cli-cmds.h".
1126         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1127         (_initialize_maint_cmds): Register the "maintenance with" command.
1128         * top.c (repeat_previous): Move bits from pipe_command here:
1129         Return the saved command line, if any; error out if there's no
1130         command to relaunch.
1131
1132 2019-07-03  Pedro Alves  <palves@redhat.com>
1133
1134         * NEWS (New commands): Mention "maint set/show test-settings"
1135         instead of "maint test-settings".
1136         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1137         (maintenance_test_settings_set_list): Rename to ...
1138         (maintenance_set_test_settings_list): ... this.
1139         (maintenance_test_settings_show_list): Rename to  ...
1140         (maintenance_show_test_settings_list): ... this.
1141         (maintenance_test_settings_cmd): Delete.
1142         (maintenance_test_settings_set_cmd): ...
1143         (maintenance_set_test_settings_cmd): ... this.
1144         (maintenance_test_settings_show_cmd): ...
1145         (maintenance_show_test_settings_cmd): ... this.
1146         (maintenance_test_settings_show_value_cmd):
1147         (maintenance_show_test_settings_value_cmd): ... this.
1148         (_initialize_maint_test_settings): No longer install the "maint
1149         test-settings" prefix command.  Rename "maint test-settings set"
1150         to "maint set test-settings", and "maint test-settings show" to
1151         "maint show test-settings".  Adjust all subcommands.
1152
1153 2019-07-03  Pedro Alves  <palves@redhat.com>
1154
1155         * maint-test-settings.c: Fix file's intro comment.  Replace all
1156         references to "test-options" with references to "test-settings",
1157         in comments.
1158
1159 2019-07-03  Pedro Alves  <palves@redhat.com>
1160
1161         * maint-test-settings.c (maintenance_test_settings_xxx)
1162         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1163         New.
1164         (maintenance_test_settings_enums): Use them.
1165         (maintenance_test_settings_enum): Default to
1166         maintenance_test_settings_xxx.
1167         (_initialize_maint_test_settings): Initialize
1168         MAINTENANCE_TEST_SETTINGS_FILENAME.
1169
1170 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1171
1172         * breakpoint.h (remove_breakpoints_inf): Change return type to
1173         void, move function documentation here.
1174         * breakpoint.c (remove_breakpoints_inf): Change return type to
1175         void, move function documentation to header.
1176
1177 2019-07-02  Pedro Alves  <palves@redhat.com>
1178
1179         * NEWS (Completion improvements): Mention "info threads".
1180         * thread.c (struct info_threads_opts, info_threads_option_defs)
1181         (make_info_threads_options_def_group): New.
1182         (info_threads_command): Use gdb::option::process_options.
1183         (info_threads_command_completer): New.
1184         (_initialize_thread): Use gdb::option::build_help to build the
1185         help text for "info threads".
1186
1187 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1188
1189         * defs.h (generic_load): Move from here...
1190         * symfile.h (generic_load): ... to here.  Rename name parameter
1191         to args.
1192         * symfile.c (generic_load): Add comment.
1193
1194 2019-07-01  Tom Tromey  <tromey@adacore.com>
1195
1196         * dwarf2read.c
1197         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1198         declaration of without_params.  Fix formatting.
1199
1200 2019-07-01  Tom Tromey  <tromey@adacore.com>
1201
1202         * ada-exp.y (find_primitive_type): Update.
1203         * ada-lang.h (ada_lookup_symbol): Update.
1204         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1205         parameter.
1206         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1207
1208 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1209
1210         PR breakpoints/24541
1211         * gdbarch.c: Regenerate.
1212         * gdbarch.h: Regenerate.
1213         * gdbarch.sh: Add 'stap_adjust_register'.
1214         * i386-tdep.c: Include '<unordered_set>'.
1215         (i386_stap_adjust_register): New function.
1216         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1217         * stap-probe.c (stap_parse_register_operand): Call
1218         'gdbarch_stap_adjust_register'.
1219
1220 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1221
1222         PR python/24742
1223         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1224         * python/python.c (do_start_initialization): Use 'xmalloc'
1225         instead of 'PyMem_Malloc'.
1226
1227 2019-06-28  Tom Tromey  <tromey@adacore.com>
1228
1229         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1230         for Ada.
1231
1232 2019-06-27  Tom Tromey  <tromey@adacore.com>
1233
1234         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1235         objfile_key.
1236         (arm_find_mapping_symbol, arm_record_special_symbol)
1237         (_initialize_arm_tdep): Update.
1238         (arm_objfile_data_free): Remove.
1239
1240 2019-06-27  Tom Tromey  <tromey@adacore.com>
1241
1242         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1243         to cp_print_static_field.
1244
1245 2019-06-26  Tom Tromey  <tromey@adacore.com>
1246
1247         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1248         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1249         declare.
1250
1251 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1252
1253         * features/aarch64-core.c (create_feature_aarch64_core):
1254         Regenerate.
1255         * features/aarch64-core.xml: Add cpsr flags.
1256
1257 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1258
1259         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1260         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1261
1262 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1263
1264         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1265         field.
1266         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1267         use.
1268         (arm_record_special_symbol): Don't insert new symbol in sorted
1269         position, push it at the end.
1270
1271 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1272
1273         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1274         (arm_mapping_symbol_s): Remove.
1275         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1276         (arm_mapping_symbol_vec): New typedef.
1277         (struct arm_per_objfile): Add constructor.
1278         <section_maps>: Change type to
1279         std::unique_ptr<arm_mapping_symbol_vec[]>.
1280         (arm_compare_mapping_symbols): Remove.
1281         (arm_find_mapping_symbol): Adjust to section_maps type change.
1282         (arm_objfile_data_free): Call delete on arm_per_objfile.
1283         (arm_record_special_symbol): Adjust to section_maps type change.
1284         Allocate arm_per_objfile with new.
1285
1286 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1287
1288         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1289         with the command prefix.
1290
1291 2019-06-25  Tom Tromey  <tom@tromey.com>
1292
1293         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1294         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1295
1296 2019-06-25  Tom Tromey  <tom@tromey.com>
1297
1298         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1299         type.
1300         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1301         protected.
1302
1303 2019-06-25  Tom Tromey  <tom@tromey.com>
1304
1305         * tui/tui-winsource.c
1306         (tui_source_window_base::set_is_exec_point_at): Add check against
1307         LOA_ADDRESS.
1308
1309 2019-06-25  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-source.c (tui_set_source_content): Don't check before
1312         xfree.
1313         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1314
1315 2019-06-25  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-winsource.h (tui_update_source_window_as_is)
1318         (tui_alloc_source_buffer, tui_line_is_displayed)
1319         (tui_addr_is_displayed): Change type of win_info.
1320         * tui/tui-winsource.c (tui_update_source_window_as_is)
1321         (tui_clear_source_content, tui_show_source_line)
1322         (tui_show_source_content, tui_source_window_base::refill)
1323         (tui_source_window_base::set_is_exec_point_at)
1324         (tui_source_window_base::set_is_exec_point_at)
1325         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1326         (tui_alloc_source_buffer, tui_line_is_displayed)
1327         (tui_addr_is_displayed): Change type of win_info.  Update.
1328         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1329         (tui_source_window_base::do_make_visible_with_new_height):
1330         Update.
1331         * tui/tui-source.c (tui_set_source_content)
1332         (tui_set_source_content_nil)
1333         (tui_source_window::do_scroll_vertical): Update.
1334         * tui/tui-layout.c (show_layout): Update.
1335         * tui/tui-disasm.c (tui_set_disassem_content)
1336         (tui_disasm_window::do_scroll_vertical): Update.
1337         * tui/tui-data.h (tui_win_content): Remove.
1338         (struct tui_gen_win_info) <content, content_size>: Remove.
1339         (struct tui_source_element): Add initializers and destructor.
1340         (union tui_which_element, struct tui_win_element): Remove.
1341         (struct tui_source_window_base) <content>: New field.
1342         (struct tui_data_window): Remove destructor.
1343         (tui_alloc_content, tui_free_win_content)
1344         (tui_free_all_source_wins_content): Don't declare.
1345         * tui/tui-data.c (tui_initialize_static_data): Update.
1346         (init_content_element, tui_alloc_content): Remove.
1347         (~tui_gen_win_info): Update.
1348         (~tui_data_window, tui_free_all_source_wins_content)
1349         (tui_free_win_content, free_content, free_content_elements):
1350         Remove.
1351
1352 2019-06-25  Tom Tromey  <tom@tromey.com>
1353
1354         * tui/tui-winsource.h (tui_clear_source_content)
1355         (tui_erase_source_content, tui_show_source_content): Change type
1356         of win_info.
1357         * tui/tui-winsource.c (tui_clear_source_content)
1358         (tui_erase_source_content, tui_show_source_content): Change type
1359         of win_info.
1360         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1361         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1362         win_info.
1363         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1364         win_info.
1365         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1366
1367 2019-06-25  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-winsource.c (tui_clear_source_content)
1370         (tui_source_window_base::set_is_exec_point_at): Update.
1371         * tui/tui-source.c (tui_set_source_content_nil): Update.
1372         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1373         a bool.
1374         * tui/tui-data.c (init_content_element): Update.
1375
1376 2019-06-25  Tom Tromey  <tom@tromey.com>
1377
1378         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1379         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1380         * tui/tui-layout.c (init_and_make_win): Update.
1381         * tui/tui.h (enum tui_win_type): Update.
1382         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1383         tui_win_is_auxillary.
1384         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1385         tui_win_is_auxillary.
1386
1387 2019-06-25  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1390         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1391         (tui_delete_data_content_windows, tui_display_all_data)
1392         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1393         Update.
1394         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1395         * tui/tui-regs.c (tui_last_regs_line_no)
1396         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1397         (tui_show_registers): Update.
1398         (tui_show_register_group): Return void.  Update.
1399         (tui_display_registers_from, tui_display_reg_element_at_line)
1400         (tui_display_registers_from_line, tui_check_register_values):
1401         Update.
1402         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1403         member.
1404         (struct tui_data_window) <regs_content>: Now a std::vector.
1405         <regs_content_count>: Remove.
1406         (tui_add_content_elements, tui_free_data_content): Don't declare.
1407         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1408         (init_content_element): Remove DATA_WIN case.  Add assert.
1409         (tui_add_content_elements): Remove.
1410         (tui_data_window): Update.
1411         (tui_free_data_content): Remove.
1412         (free_content_elements): Remove DATA_WIN case.
1413
1414 2019-06-25  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-data.c (tui_data_item_window): Update.
1417         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1418         * tui/tui-windata.c (tui_display_all_data)
1419         (tui_display_data_from_line): Update.
1420         (tui_check_data_values): Remove.
1421         * tui/tui-regs.c (tui_show_register_group)
1422         (tui_display_reg_element_at_line): Update.
1423         * tui/tui-hooks.c (tui_register_changed)
1424         (tui_refresh_frame_and_register_information): Call
1425         tui_check_register_values.
1426         * tui/tui-data.h (struct tui_data_window) <data_content,
1427         data_content_count, data_type>: Remove.
1428         (enum tui_data_type): Remove.
1429
1430         * tui/tui-data.c (tui_data_window::clear_detail)
1431         (~tui_data_window): Update.
1432
1433 2019-06-25  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1436         declare.
1437         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1438         Rename from tui_first_data_item_displayed.  Update.
1439         (tui_data_window::refresh_all)
1440         (tui_data_window::do_scroll_vertical): Update.
1441         * tui/tui-data.h (struct tui_data_window)
1442         <first_data_item_displayed>: Declare new method.
1443
1444 2019-06-25  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1447         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1448         contents...
1449         (tui_initialize_static_data): ...here.
1450
1451 2019-06-25  Tom Tromey  <tom@tromey.com>
1452
1453         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1454         (tui_display_registers_from, tui_check_register_values): Update.
1455         (tui_display_register): Remove win_info parameter; update.
1456         (tui_get_register): Change type of parameters.
1457         * tui/tui-data.h (struct tui_data_element): Remove.
1458         (union tui_which_element) <data>: Remove.
1459         <data_window>: Change type.
1460         (struct tui_data_item_window): New.
1461         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1462         case.  Add assert.
1463         (~tui_data_item_window): New destructor.
1464         (free_content_elements): Remove DATA_ITEM_WIN case.
1465
1466 2019-06-25  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1469         Remove.
1470
1471 2019-06-25  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-data.h (struct tui_command_element): Remove.
1474         (union tui_which_element) <command>: Remove.
1475         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1476         assert.
1477         (free_content_elements): Remove CMD_WIN case.
1478
1479 2019-06-25  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui-layout.c (tui_set_layout): Update.
1482         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1483         * tui/tui-data.c (layout_def): Update.
1484
1485 2019-06-25  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1488         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1489         (tui_source_window_base::set_new_height): Update.
1490         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1491         Update.
1492         (tui_set_locator_fullname, tui_set_locator_info)
1493         (tui_show_frame_info): Update.
1494         * tui/tui-source.c (tui_set_source_content)
1495         (tui_source_is_displayed): Update.
1496         * tui/tui-layout.c (show_source_disasm_command, show_data)
1497         (show_source_or_disasm_and_command): Update.
1498         * tui/tui-disasm.c (tui_set_disassem_content)
1499         (tui_get_begin_asm_address): Update.
1500         * tui/tui-data.h (struct tui_locator_element): Remove.
1501         (union tui_which_element) <locator>: Remove.
1502         (struct tui_locator_window): New.
1503         (tui_locator_win_info_ptr): Change return type.
1504         * tui/tui-data.c (_locator): Change type.
1505         (tui_locator_win_info_ptr): Change return type.
1506         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1507         (tui_alloc_content): Add assert.
1508
1509 2019-06-25  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-winsource.c
1512         (tui_exec_info_window::maybe_allocate_content): New method.
1513         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1514         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1515         (make_source_or_disasm_window): Add cast.
1516         * tui/tui-data.h (union tui_which_element) <simple_string>:
1517         Remove.
1518         (struct tui_source_info): New.
1519         (struct tui_source_window_base) <execution_info>: Change type.
1520         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1521         case, and add assert.
1522         (tui_alloc_content): Add assert.
1523
1524 2019-06-25  Tom Tromey  <tom@tromey.com>
1525
1526         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1527         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1528         * tui/tui-data.c (tui_alloc_win_info): Remove.
1529
1530 2019-06-25  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1533         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1534         can_highlight.
1535
1536 2019-06-25  Tom Tromey  <tom@tromey.com>
1537
1538         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1539         make_visible_with_new_height method.
1540         (tui_win_info::make_visible_with_new_height): New method.
1541         (tui_source_window_base::do_make_visible_with_new_height)
1542         (tui_data_window::do_make_visible_with_new_height)
1543         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1544         (make_visible_with_new_height): Remove.
1545         (tui_resize_all, tui_adjust_win_heights): Use
1546         make_visible_with_new_height method.
1547         * tui/tui-data.h (struct tui_win_info)
1548         <do_make_visible_with_new_height, make_visible_with_new_height>:
1549         New methods.
1550         (struct tui_source_window_base, struct tui_data_window)
1551         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1552         methods.
1553
1554 2019-06-25  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1557         method.
1558         (update_tab_width): Call update_tab_width method.
1559         * tui/tui-data.h (struct tui_win_info)
1560         (struct tui_source_window_base) <update_tab_width>: New methods.
1561
1562 2019-06-25  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1565         parameter.
1566         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1567         parameter.
1568         (tui_gen_win_info::make_visible): Update.
1569         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1570         parameter.
1571         * tui/tui-data.h (enum tui_box): New enum.
1572         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1573
1574 2019-06-25  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1577         init_and_make_win for EXEC_INFO_WIN.
1578         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1579         longer inline.
1580         (struct tui_win_info) <~tui_win_info>: Inline.
1581         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1582         Don't declare.
1583         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1584         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1585         Remove.
1586         (tui_initialize_static_data): Update.
1587         (~tui_gen_win_info): Handle more cleanup here.
1588         (~tui_source_window_base): Delete "execution_info".
1589         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1590
1591 2019-06-25  Tom Tromey  <tom@tromey.com>
1592
1593         * tui/tui-layout.c (make_command_window): Don't set
1594         can_highlight.
1595         (show_source_disasm_command): Call the reset method.
1596         (show_data): Don't set can_highlight.  Call the reset method.
1597         (tui_gen_win_info::reset): Rename from init_gen_win_info
1598         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1599         (show_source_or_disasm_and_command): Call the reset method.
1600         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1601         (struct tui_cmd_window): Set can_highlight.
1602
1603 2019-06-25  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1606         from make_visible.
1607         (tui_make_visible, tui_make_invisible): Rewrite.
1608         (tui_win_info::make_visible): Remove.
1609         (tui_source_window_base::make_visible): Update.
1610         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1611         method.  Moved from...
1612         (struct tui_win_info) <make_visible>: ...here.
1613
1614 2019-06-25  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-winsource.c
1617         (tui_source_window_base::do_scroll_horizontal): Remove direction
1618         parameter.
1619         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1620         direction parameter.
1621         * tui/tui-win.c (tui_win_info::forward_scroll)
1622         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1623         (tui_win_info::right_scroll): Update.
1624         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1625         direction parameter.
1626         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1627         direction parameter.
1628         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1629         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1630         Remove direction parameter.
1631         (struct tui_source_window_base, struct tui_source_window)
1632         (struct tui_disasm_window, struct tui_data_window)
1633         (struct tui_cmd_window): Update.
1634
1635 2019-06-25  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui-winsource.h (tui_set_exec_info_content)
1638         (tui_show_exec_info_content, tui_erase_exec_info_content)
1639         (tui_clear_exec_info_content, tui_update_exec_info): Change
1640         argument to tui_source_window_base.
1641         * tui/tui-winsource.c (tui_set_exec_info_content)
1642         (tui_show_exec_info_content, tui_erase_exec_info_content)
1643         (tui_clear_exec_info_content, tui_update_exec_info): Change
1644         argument to tui_source_window_base.
1645
1646 2019-06-25  Tom Tromey  <tom@tromey.com>
1647
1648         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1649         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1650
1651 2019-06-25  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1654         check.
1655
1656 2019-06-25  Tom Tromey  <tom@tromey.com>
1657
1658         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1659         type to void.
1660         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1661         type to void.
1662         * tui/tui-source.c (tui_set_source_content): Update.
1663         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1664
1665 2019-06-25  Tom Tromey  <tom@tromey.com>
1666
1667         * tui/tui-win.c (window_name_completer, tui_set_focus)
1668         (tui_all_windows_info): Use name method.
1669         * tui/tui-data.h (struct tui_gen_win_info)
1670         (struct tui_source_window, struct tui_disasm_window)
1671         (struct tui_data_window, struct tui_cmd_window) <name>: New
1672         method.
1673         (tui_win_name): Don't declare.
1674         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1675         (tui_win_name): Remove.
1676
1677 2019-06-25  Tom Tromey  <tom@tromey.com>
1678
1679         * tui/tui-winsource.h (tui_update_source_window)
1680         (tui_update_source_window_as_is): Change parameter type.
1681         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1682         to be a tui_source_window_base.
1683         (tui_update_source_window_as_is): Likewise.
1684         * tui/tui-win.c (make_visible_with_new_height): Update.
1685
1686 2019-06-25  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-winsource.c (tui_erase_source_content)
1689         (tui_show_source_content, tui_show_exec_info_content)
1690         (tui_erase_exec_info_content): Use refresh_window method.
1691         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1692         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1693         from tui_refresh_win.
1694         (tui_data_window::refresh_window): New method.
1695         (tui_win_info::refresh, tui_source_window_base::refresh)
1696         (tui_refresh_all): Use refresh_window method.
1697         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1698         method.
1699         * tui/tui-regs.c (tui_display_register): Call refresh_window
1700         method.
1701         * tui/tui-layout.c (show_source_disasm_command)
1702         (show_source_or_disasm_and_command): Call refresh_window method.
1703         * tui/tui-data.h (struct tui_gen_win_info)
1704         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1705         New method.
1706
1707 2019-06-25  Tom Tromey  <tom@tromey.com>
1708
1709         * tui/tui.c (tui_rl_other_window, tui_enable)
1710         (tui_is_window_visible, tui_get_command_dimension): Update.
1711         * tui/tui-winsource.c (tui_update_source_window_as_is)
1712         (tui_clear_source_content, tui_erase_source_content)
1713         (tui_show_source_line, tui_source_window_base::refill)
1714         (tui_source_window_base::do_scroll_horizontal)
1715         (tui_source_window_base::set_is_exec_point_at)
1716         (tui_update_breakpoint_info, tui_set_exec_info_content)
1717         (tui_alloc_source_buffer, tui_line_is_displayed)
1718         (tui_addr_is_displayed): Update.
1719         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1720         (tui_check_and_display_highlight_if_needed)
1721         (tui_win_info::make_visible, tui_win_info::refresh)
1722         (tui_refresh_all): Update.
1723         * tui/tui-windata.c (tui_first_data_item_displayed)
1724         (tui_delete_data_content_windows, tui_erase_data_content)
1725         (tui_display_all_data, tui_data_window::refresh_all)
1726         (tui_check_data_values): Update.
1727         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1728         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1729         (tui_win_info::backward_scroll, tui_refresh_all_win)
1730         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1731         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1732         (tui_source_window_base::set_new_height)
1733         (tui_data_window::set_new_height)
1734         (make_invisible_and_set_new_height)
1735         (make_visible_with_new_height, new_height_ok)
1736         (parse_scrolling_args): Update.
1737         * tui/tui-stack.c (tui_show_frame_info): Update.
1738         * tui/tui-source.c (tui_set_source_content)
1739         (tui_set_source_content_nil, tui_source_is_displayed)
1740         (tui_source_window::do_scroll_vertical): Update.
1741         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1742         (tui_display_registers_from, tui_display_reg_element_at_line)
1743         (tui_check_register_values, tui_reg_command): Update.
1744         * tui/tui-layout.c (tui_default_win_height)
1745         (show_source_disasm_command, show_data, init_and_make_win)
1746         (show_source_or_disasm_and_command): Update.
1747         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1748         (tui_redisplay_readline, tui_mld_flush)
1749         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1750         (tui_getc): Update.
1751         * tui/tui-disasm.c (tui_set_disassem_content)
1752         (tui_disasm_window::do_scroll_vertical): Update.
1753         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1754         Now virtual.
1755         (struct tui_win_info): Derive from tui_gen_win_info.
1756         <~tui_win_info>: Mark as override.
1757         <generic>: Remove member.
1758         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1759         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1760         (~tui_data_window, ~tui_win_info)
1761         (tui_free_all_source_wins_content): Update.
1762         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1763
1764 2019-06-25  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui-layout.c (init_and_make_win): Use new.
1767         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1768         destructor, initializers.
1769         (tui_alloc_generic_win_info): Don't declare.
1770         * tui/tui-data.c (_locator): Add argument to constructor.
1771         (source_win, disasm_win): New globals.
1772         (exec_info): Remove.
1773         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1774         Update.
1775         (tui_alloc_generic_win_info): Remove.
1776         (init_content_element): Use new.
1777         (tui_win_info::tui_win_info): Update.
1778         (free_content_elements) <case DATA_WIN>: Use delete.
1779
1780 2019-06-25  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1783         * tui/tui-windata.c (tui_first_data_item_displayed)
1784         (tui_delete_data_content_windows): Update.
1785         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1786         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1787         (tui_display_registers_from, tui_check_register_values): Update.
1788         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1789         pointer.
1790         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1791         window.
1792         (tui_free_data_content): Update.
1793         (free_content_elements) <case DATA_WIN>: Free the window.
1794
1795 2019-06-25  Tom Tromey  <tom@tromey.com>
1796
1797         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1798         Update.
1799         * tui/tui-layout.c (make_command_window)
1800         (show_source_disasm_command, show_data, init_and_make_win)
1801         (show_source_or_disasm_and_command): Update.
1802         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1803         method.
1804         <can_highight, is_highlighted>: Now bool.
1805         (tui_set_win_highlight): Don't declare.
1806         * tui/tui-data.c (tui_set_win_highlight): Remove.
1807
1808 2019-06-25  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-wingeneral.c (make_visible): Remove check of window
1811         type.
1812
1813 2019-06-25  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-win.c (tui_win_info::max_height)
1816         (tui_cmd_window::max_height): New methods.
1817         (new_height_ok): Call max_height.
1818         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1819         <max_height>: New method.
1820
1821 2019-06-25  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-win.c (tui_source_window_base::set_new_height)
1824         (tui_data_window::set_new_height): New methods.
1825         (make_invisible_and_set_new_height): Call set_new_height method.
1826         * tui/tui-data.h (struct tui_win_info)
1827         (struct tui_source_window_base, struct tui_data_window)
1828         <set_new_height>: New method.
1829
1830 2019-06-25  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1833         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1834         tui_refresh_data_win.
1835         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1836         method.
1837         (tui_refresh_all_win): Call the refresh_all method.
1838         (tui_set_focus): Likewise.
1839         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1840         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1841         Likewise.
1842
1843 2019-06-25  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-winsource.h (tui_refill_source_window)
1846         (tui_set_is_exec_point_at): Don't declare.
1847         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1848         (tui_source_window_base::refill): Rename from
1849         tui_refill_source_window.
1850         (tui_source_window_base::do_scroll_horizontal): Update.
1851         (tui_source_window_base::set_is_exec_point_at): Rename from
1852         tui_set_is_exec_point_at.
1853         (tui_update_all_breakpoint_info): Update.
1854         * tui/tui-stack.c (tui_show_frame_info): Update.
1855         * tui/tui-layout.c (show_data): Add cast.
1856         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1857         * tui/tui-data.h (struct tui_source_window_base) <refill,
1858         set_is_exec_point_at>: New methods.
1859         (tui_source_windows, tui_add_to_source_windows): Update types.
1860         (tui_add_to_source_windows): Remove redundant declaration.
1861         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1862         (tui_source_windows): Change return type.
1863         (tui_clear_source_windows_detail): Update.
1864         (tui_add_to_source_windows): Change type of parameter.
1865         (tui_free_all_source_wins_content): Update.
1866
1867 2019-06-25  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui-wingeneral.c (tui_win_info::refresh)
1870         (tui_source_window_base::refresh): New methods.
1871         (tui_refresh_all): Call the refresh method.
1872         * tui/tui-data.h (struct tui_win_info)
1873         (struct tui_source_window_base) <refresh>: New method.
1874
1875 2019-06-25  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui.h (tui_is_window_visible): Return bool.
1878         * tui/tui.c (tui_is_window_visible): Return bool.
1879         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1880         (tui_make_visible, tui_make_invisible)
1881         (tui_win_info::make_visible)
1882         (tui_source_window_base::make_visible, make_all_visible)
1883         (tui_make_all_visible, tui_make_all_invisible): Update.
1884         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1885         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1886         bool.
1887         (struct tui_win_info, struct tui_source_window_base)
1888         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1889         * tui/tui-data.c (tui_init_generic_part): Update.
1890
1891 2019-06-25  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1894         (tui_source_window_base::make_visible): New methods.
1895         (make_all_visible): Make method call.
1896         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1897         (struct tui_source_window_base, struct tui_cmd_window): Override
1898         make_visible.
1899         (tui_win_is_source_type): Don't declare.
1900         * tui/tui-data.c (tui_win_is_source_type): Remove.
1901
1902 2019-06-25  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1905         NULL check.
1906
1907 2019-06-25  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1910         Inline constructor.  Add initializers for members.
1911         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1912         constructors; now inline in class.
1913
1914 2019-06-25  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-regs.c (tui_show_registers): Update.
1917         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1918         bool.
1919         * tui/tui-data.c (tui_data_window::clear_detail)
1920         (tui_data_window): Update.
1921
1922 2019-06-25  Tom Tromey  <tom@tromey.com>
1923
1924         * tui/tui-windata.c (tui_display_all_data)
1925         (tui_display_data_from_line, tui_display_data_from)
1926         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1927         Update.
1928         * tui/tui-regs.c (tui_last_regs_line_no)
1929         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1930         (tui_show_registers, tui_show_register_group)
1931         (tui_display_registers_from, tui_display_reg_element_at_line)
1932         (tui_display_registers_from_line, tui_check_register_values)
1933         (tui_reg_next, tui_reg_prev): Update.
1934         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1935         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1936         tui_data_window.
1937         (struct tui_win_info) <detail>: Remove.  Add new fields from
1938         tui_data_info.
1939         (TUI_DATA_WIN): Add cast.
1940         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1941         (~tui_data_window): Simplify.
1942
1943 2019-06-25  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-layout.c (show_source_disasm_command)
1946         (show_source_or_disasm_and_command): Update.
1947         * tui/tui-io.c (update_cmdwin_start_line)
1948         (tui_redisplay_readline): Update.
1949         * tui/tui-data.h (struct tui_command_info): Remove.
1950         (struct tui_win_info) <detail>: Remove command_info member.
1951         (struct tui_data_window) <start_line>: New member, from
1952         tui_command_info.
1953         (TUI_CMD_WIN): Add casts.
1954
1955 2019-06-25  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-winsource.c (tui_update_source_window)
1958         (tui_refill_source_window)
1959         (tui_source_window_base::do_scroll_horizontal)
1960         (tui_update_breakpoint_info, tui_set_exec_info_content)
1961         (tui_show_exec_info_content, tui_erase_exec_info_content)
1962         (tui_clear_exec_info_content): Update.
1963         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1964         Update.
1965         * tui/tui-win.c (make_invisible_and_set_new_height)
1966         (make_visible_with_new_height): Update.
1967         * tui/tui-source.c (tui_set_source_content)
1968         (tui_show_symtab_source): Update.
1969         * tui/tui-layout.c (extract_display_start_addr)
1970         (show_source_disasm_command, show_data)
1971         (make_source_or_disasm_window)
1972         (show_source_or_disasm_and_command): Update.
1973         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1974         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1975         "gdbarch".
1976         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1977         to tui_source_window_base.
1978         (struct tui_win_info) <detail>: Remove source_info member.
1979         (struct tui_source_window_base) <has_locator>: Inline.
1980         Move contents from tui_source_info; rename has_locator member to
1981         m_has_locator.
1982         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1983         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1984         header file.
1985         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1986         Simplify.
1987         (tui_free_all_source_wins_content): Cast to
1988         tui_source_window_base.
1989
1990 2019-06-25  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-win.c (make_invisible_and_set_new_height)
1993         (make_visible_with_new_height): Call has_locator method.
1994         * tui/tui-layout.c (show_source_disasm_command, show_data)
1995         (show_source_or_disasm_and_command): Update for bool change.
1996         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1997         (tui_win_info) <has_locator>: New method.
1998         (struct tui_source_window_base) <has_locator>: New method.
1999         (tui_win_has_locator): Don't declare.
2000         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2001         from tui_win_has_locator.
2002         (tui_source_window_base): Use false, not FALSE.
2003
2004 2019-06-25  Tom Tromey  <tom@tromey.com>
2005
2006         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2007         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2008         clear_detail method directly.
2009         (tui_clear_win_detail): Remove.
2010
2011 2019-06-25  Tom Tromey  <tom@tromey.com>
2012
2013         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2014         "this", not TUI_DISASM_WIN.
2015
2016 2019-06-25  Tom Tromey  <tom@tromey.com>
2017
2018         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2019         declare.
2020         * tui/tui-winsource.c
2021         (tui_source_window_base::do_scroll_horizontal): Rename from
2022         tui_horizontal_source_scroll.
2023         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2024         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2025         from tui_vertical_data_scroll.
2026         * tui/tui-win.h (tui_scroll): Don't declare.
2027         * tui/tui-win.c (tui_win_info::forward_scroll)
2028         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2029         (tui_win_info::right_scroll): Rename and update.
2030         (tui_scroll_forward_command, tui_scroll_backward_command)
2031         (tui_scroll_left_command, tui_scroll_right_command): Update.
2032         (tui_scroll): Remove.
2033         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2034         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2035         from tui_vertical_source_scroll.
2036         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2037         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2038         from tui_vertical_disassem_scroll.
2039         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2040         do_scroll_horizontal>: New methods.
2041         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2042         Likewise.
2043         (struct tui_source_window_base): Add do_scroll_horizontal.
2044         (struct tui_source_window, struct tui_disasm_window): Add
2045         do_scroll_vertical.
2046         (struct tui_data_window, struct tui_cmd_window): Add
2047         do_scroll_horizontal and do_scroll_vertical.
2048         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2049
2050 2019-06-25  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui-data.h (struct tui_source_window_base): New struct.
2053         (struct tui_source_window): Derive from tui_source_window_base.
2054         (struct tui_disasm_window): New struct.
2055         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2056         from tui_source_window::clear_detail.
2057         (tui_source_window_base): Rename from tui_source_window.
2058         (~tui_source_window_base): Rename from ~tui_source_window.
2059         (tui_alloc_win_info): Create a tui_disasm_window.
2060
2061 2019-06-25  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-data.h (struct tui_source_window)
2064         (struct tui_data_window): Declare destructors.
2065         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2066         destructors.
2067         (tui_win_info): Simplify.
2068
2069 2019-06-25  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-winsource.c (tui_display_main)
2072         (tui_update_source_windows_with_addr)
2073         (tui_update_all_breakpoint_info): Update.
2074         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2075         (new_height_ok, parse_scrolling_args): Update.
2076         * tui/tui-stack.c (tui_show_frame_info): Update.
2077         * tui/tui-data.h (struct tui_list): Remove.
2078         (tui_source_windows): Return a reference to a std::vector.
2079         * tui/tui-data.c (source_windows): Now a std::vector.
2080         (tui_source_windows): Change return type.
2081         (tui_clear_source_windows): Rewrite.
2082         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2083         (tui_free_all_source_wins_content): Rewrite.
2084
2085 2019-06-25  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2088         (struct tui_data_window, struct tui_cmd_window): Declare
2089         clear_detail method.
2090         * tui/tui-data.c (tui_source_window::clear_detail)
2091         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2092         methods.
2093         (tui_clear_win_detail): Simplify.
2094
2095 2019-06-25  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-layout.c (make_source_window, make_disasm_window)
2098         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2099         Return the new window.
2100         (show_source_disasm_command, show_data)
2101         (show_source_or_disasm_and_command): Update.
2102
2103 2019-06-25  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2106         parameter.  Return the new window.
2107         (show_source_disasm_command): Update and remove NULL check.
2108         (show_source_or_disasm_and_command): Update.
2109
2110 2019-06-25  Tom Tromey  <tom@tromey.com>
2111
2112         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2113
2114 2019-06-25  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-data.h (struct tui_win_info): Make constructor
2117         protected.  Make destructor virtual.  Add initializers.
2118         (tui_source_window, tui_data_window, tui_cmd_window): New
2119         classes.
2120         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2121         constructor.  Add "type" parameter.
2122         (tui_source_window, tui_data_window, tui_cmd_window): New
2123         constructors.
2124         (tui_alloc_win_info): Instantiate the appropriate subclass.
2125
2126 2019-06-25  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-win.c (tui_resize_all): Use delete.
2129         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2130         destructor.
2131         (tui_free_window): Don't declare.
2132         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2133         Update.
2134
2135 2019-06-25  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-data.h (struct tui_win_info): Add constructor.
2138         * tui/tui-data.c (tui_alloc_win_info): Use new.
2139         (tui_free_window): Use delete.
2140
2141 2019-06-22  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2144         declare.
2145         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2146
2147 2019-06-22  Tom Tromey  <tom@tromey.com>
2148
2149         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2150         declare.
2151         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2152
2153 2019-06-22  Tom de Vries  <tdevries@suse.de>
2154
2155         * dwarf2read.c (create_addrmap_from_aranges)
2156         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2157         instead of '%zu'.
2158
2159 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2160
2161         * dwarf2read.h (dwarf2_section_info_def): Remove.
2162         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2163         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2164         std::vector<dwarf2_section_info>.
2165         (struct dwo_file) <~dwo_file>: Remove.
2166         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2167         types field.
2168         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2169         (dwarf2_read_debug_names): Likewise.
2170         (create_debug_types_hash_table): Change parameter type to
2171         array_view, adjust code accordingly.
2172         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2173         (partial_die_info::fixup): Likewise.
2174         (determine_prefix): Likewise.
2175         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2176
2177 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2178
2179         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2180         gdb_bfd_ref_ptr.
2181         <~dwo_file>: Remove call to gdb_bfd_unref.
2182         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2183         gdb_bfd_ref_ptr::get.
2184
2185 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2186
2187         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2188         type to htab_up.
2189         * dwarf2read.c (struct dwo_file): Initialize fields.
2190         <~dwo_file>: New.
2191         (free_dwo_file): Remove, move content to ~dwo_file.
2192         (struct dwo_file_deleter): Remove.
2193         (dwo_file_up>: Remove custom deleter.
2194         (free_dwo_files): Remove.
2195         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2196         dwo_files.
2197         (process_skeletonless_type_units): Call unique_ptr::get.
2198         (allocate_dwo_file_hash_table): Add deleter to created hash
2199         table.  Change return type to htab_up.
2200         (lookup_dwo_file_slot): Don't memset dwo_file, call
2201         unique_ptr::get.
2202         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2203         (create_dwo_unit_in_dwp_v2): Likewise.
2204         (open_and_init_dwo_file): Likewise.
2205         (free_dwo_file_from_slot): Remove.
2206
2207 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2208
2209         * dwarf2read.h (struct dwarf2_section_info) <readin,
2210         is_virtual>: Change type to bool.
2211         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2212         true instead of 1.
2213
2214 2019-06-19  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-data.h (tui_init_content_element): Don't declare.
2217
2218 2019-06-19  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-data.h (tui_init_win_info): Don't declare.
2221
2222 2019-06-19  Tom de Vries  <tdevries@suse.de>
2223
2224         * dwarf2read.h (abstract_to_concrete): Change type to
2225         std::unordered_map<sect_offset, std::vector<sect_offset>,
2226         gdb::hash_enum<sect_offset>>.
2227
2228 2019-06-19  Tom Tromey  <tromey@adacore.com>
2229
2230         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2231         EVAL_AVOID_SIDE_EFFECTS specially.
2232
2233 2019-06-19  Tom Tromey  <tromey@adacore.com>
2234
2235         * source-cache.c (highlighter): New global.
2236         (source_cache::get_source_lines): Create a highlighter on demand.
2237
2238 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2239
2240         * defs.h (deprecated_interactive_hook): Delete declaration.
2241         * interps.c (clear_interpreter_hooks): Remove use of
2242         deprecated_interactive_hook.
2243         * top.c (deprecated_interactive_hook): Delete definition.
2244         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2245
2246 2019-06-18  Tom de Vries  <tdevries@suse.de>
2247
2248         PR gdb/24515
2249         * dwarf2read.h (abstract_to_concrete): Change type from
2250         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2251         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2252         * dwarf2read.c (read_variable): Update.
2253         (dwarf2_fetch_die_loc_sect_off): Update.
2254
2255 2019-06-17  Tom de Vries  <tdevries@suse.de>
2256
2257         PR gdb/24617
2258         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2259         accessing parent[parent_len - 1].
2260
2261 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2262
2263         PR gdb/24364
2264         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2265         call dtrace_process_dof with NULL dof.
2266
2267 2019-06-16  Tom de Vries  <tdevries@suse.de>
2268
2269         PR gdb/24445
2270         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2271
2272 2019-06-16  Tom Tromey  <tom@tromey.com>
2273
2274         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2275         (make_all_visible): Use address of member.
2276
2277 2019-06-16  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2280         (tui_free_window, free_content, free_content_elements): Remove
2281         unnecessary cast.
2282         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2283         cast.
2284         * tui/tui-regs.c (tui_show_register_group)
2285         (tui_display_registers_from, tui_display_reg_element_at_line):
2286         Remove unnecessary cast.
2287
2288 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * linux-nat.c (normal_mask): Delete.
2291         (_initialize_linux_nat): Don't initialise normal_mask.
2292
2293 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2294
2295         PR gdb/24445
2296         * dwarf-index-write.h (write_psymtabs_to_index): Add
2297         dwz_basename parameter.
2298         * dwarf-index-write.c (write_gdbindex): Move file writing to
2299         write_gdbindex_1.  Change return type void.
2300         (assert_file_size): Move up, remove filename parameter.
2301         (write_gdbindex_1): New function.
2302         (write_debug_names): Change return type to void, call
2303         assert_file_size.
2304         (struct index_wip_file): New struct.
2305         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2306         file logic to index_wip_file.  Write index for dwz file if
2307         needed.
2308         (save_gdb_index_command): Pass basename of dwz file, if present.
2309         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2310         build-id of dwz file, if present.
2311         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2312         (dwarf2_get_dwz_file): Likewise.
2313         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2314         (dwarf2_get_dwz_file): Likewise.
2315
2316 2019-06-16  Tom Tromey  <tom@tromey.com>
2317
2318         * coffread.c (process_coff_symbol): Use xstrdup.
2319         * value.c (create_internalvar): Use xstrdup.
2320
2321 2019-06-16  Tom Tromey  <tom@tromey.com>
2322
2323         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2324         * breakpoint.c (stopin_command, stopat_command)
2325         (until_break_command, decode_location_default): Remove unnecessary
2326         cast.
2327         * utils.c (subset_compare): Remove unnecessary cast.
2328         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2329         cast.
2330         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2331         cast.
2332         * infcmd.c (path_command): Remove unnecessary cast.
2333         * coffread.c (decode_type): Remove unnecessary cast.
2334         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2335         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2336         * tui/tui-stack.c (tui_show_locator_content)
2337         (tui_show_frame_info): Remove unnecessary cast.
2338         * tui/tui-win.c (tui_scroll_forward_command)
2339         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2340         (parse_scrolling_args): Remove unnecessary cast.
2341         * tui/tui-data.c (init_win_info, tui_del_window)
2342         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2343         (free_content_elements): Remove unnecessary cast.
2344         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2345         unnecessary cast.
2346         * tui/tui-source.c (tui_set_source_content)
2347         (tui_vertical_source_scroll): Remove unnecessary cast.
2348         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2349         cast.
2350         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2351         * tui/tui-regs.c (tui_display_registers_from)
2352         (tui_display_register): Remove unnecessary cast.
2353         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2354         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2355         (make_visible): Remove unnecessary cast.
2356         * tui/tui-winsource.c (tui_erase_source_content)
2357         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2358         unnecessary cast.
2359         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2360         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2361         * stabsread.c (read_type, read_array_type, read_range_type):
2362         Remove unnecessary cast.
2363         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2364         (parse_symbol, parse_type, upgrade_type, parse_external)
2365         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2366         unnecessary cast.
2367         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2368
2369 2019-06-16  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-data.c (tui_alloc_generic_win_info)
2372         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2373         checks.
2374
2375 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2376             Andrew Burgess  <andrew.burgess@embecosm.com>
2377
2378         * f-typeprint.c (f_print_type): Don't return early for not
2379         associated or not allocated types.
2380         (f_type_print_varspec_suffix): Add print_rank parameter and print
2381         ranks of array types in case they dangling.
2382         (f_type_print_base): Add print_rank parameter.
2383
2384 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2385
2386         * NEWS: Mention new MI commands.
2387         * break-catch-throw.c (enum exception_event_kind): Move to
2388         breakpoint.h.
2389         (print_mention_exception_catchpoint): Output text as a single
2390         message.
2391         (catch_exception_command_1): Rename to...
2392         (catch_exception_event): ...this, make non-static, update header
2393         command, and change some parameter types.
2394         (catch_catch_command): Update for changes to
2395         catch_exception_command_1.
2396         (catch_throw_command): Likewise.
2397         (catch_rethrow_command): Likewise.
2398         * breakpoint.c (enum exception_event_kind): Delete.
2399         * breakpoint.h (enum exception_event_kind): Moved here from
2400         break-catch-throw.c.
2401         (catch_exception_event): Declare.
2402         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2403         (mi_cmd_catch_throw): New function.
2404         (mi_cmd_catch_rethrow): New function.
2405         (mi_cmd_catch_catch): New function.
2406         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2407         'catch-catch' entries.
2408         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2409         (mi_cmd_catch_rethrow): Declare.
2410         (mi_cmd_catch_catch): Declare.
2411
2412 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2413
2414         * annotate.c (annotate_source_line): Change return type to void,
2415         update implementation to match.
2416         * annotate.h (annotate_source_line): Change return type to void,
2417         update header comment.
2418         * stack.c (print_frame_info): Don't change what frame information
2419         is printed based on whether annotations are on or not.
2420
2421 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2422
2423         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2424         (annotate_source): Make static.
2425         (annotate_source_line): Moved from source.c and renamed from
2426         identify_source_line.  Update the return type.
2427         * annotate.h (annotate_source): Delete declaration.
2428         (annotate_source_line): Declaration moved from source.h, and
2429         renamed from identify_source_line.  Return type updated.
2430         * source.c (identify_source_line): Moved to annotate.c and renamed
2431         to annotate_source_line.
2432         (info_line_command): Remove check of annotation_level.
2433         * source.h (identify_source_line): Move declaration to annotate.h
2434         and rename to annotate_source_line.
2435         * stack.c: Add 'annotate.h' include.
2436         (print_frame_info): Remove check of annotation_level before
2437         calling annotate_source_line.
2438
2439 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2440
2441         * source-cache.c (source_cache::get_plain_source_lines): Use
2442         open_source_file_with_line_charpos instead of just
2443         open_source_file, remove call to find_source_lines.
2444         (source_cache::get_source_lines): Likewise.
2445         * source.c (find_source_lines): Make static.
2446         (get_filename_and_charpos): Renamed into...
2447         (open_source_file_with_line_charpos): ..this along with changes to
2448         return a scoped_fd, and some other minor clean ups.
2449         (identify_source_line): Use open_source_file_with_line_charpos.
2450         (search_command_helper): Use open_source_file_with_line_charpos
2451         instead of just open_source_file, remove call to
2452         find_source_lines.
2453         * source.h (open_source_file_with_line_charpos): Declare new
2454         function.
2455         (find_source_lines): Delete declaration.
2456
2457 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2458
2459         * source.c (get_filename_and_charpos): Remove fullname
2460         parameter.
2461         (identify_source_line): Update call to get_filename_and_charpos.
2462
2463 2019-06-14  Tom Tromey  <tromey@adacore.com>
2464
2465         PR gdb/24502:
2466         * ui-style.h (skip_ansi_escape): Update comment.
2467         * ui-file.h (class no_terminal_escape_file): New class.
2468         * ui-file.c (no_terminal_escape_file::write)
2469         (no_terminal_escape_file::puts): New methods.
2470         * cli/cli-logging.c (handle_redirections): Use
2471         no_terminal_escape_file.
2472
2473 2019-06-14  Tom Tromey  <tromey@adacore.com>
2474
2475         * NEWS: Move convenience variable news above Python news.
2476
2477 2019-06-14  Tom Tromey  <tom@tromey.com>
2478
2479         * gnulib: Move directory to top-level.
2480         * configure.ac: Don't configure gnulib.
2481         * configure: Rebuild.
2482         * common/common-defs.h: Use new path to gnulib.
2483         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2484         (GNULIB_H): Remove.
2485         (INCGNU): Look in new gnulib location.
2486         (HFILES_NO_SRCDIR): Remove gnulib files.
2487         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2488         (generated_files): Remove GNULIB_H.
2489         ($(LIBGNU), all-lib): Remove targets.
2490         (distclean): Don't mention GNULIB_BUILDDIR.
2491         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2492
2493 2019-06-14  Tom Tromey  <tromey@adacore.com>
2494
2495         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2496         Warn if symbol file does not provide any symbols.
2497
2498 2019-06-14  Tom Tromey  <tromey@adacore.com>
2499
2500         * source.c (find_and_open_source): Respect basenames_may_differ.
2501
2502 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2503
2504         * annotate.c (annotate_breakpoints_invalid): Make use of
2505         scoped_restore_terminal_state.
2506         (annotate_frames_invalid): Likewise.
2507
2508 2019-06-14  Tom Tromey  <tromey@adacore.com>
2509
2510         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2511         allow assignment to an internalvar.
2512
2513 2019-06-14  Tom Tromey  <tromey@adacore.com>
2514
2515         * ada-lex.l: Allow "_" in attribute names.
2516
2517 2019-06-14  Tom Tromey  <tromey@adacore.com>
2518
2519         PR gdb/24653:
2520         * regcache.c (registers_changed): Don't call alloca.
2521         * top.c (execute_command): Don't call alloca.
2522
2523 2019-06-13  Pedro Alves  <palves@redhat.com>
2524
2525         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2526         'expression'.  When parsing an expression, error out if there's
2527         junk after "unlimited".
2528         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2529         (do_set_command): Adjust calls to is_unlimited_literal.
2530
2531 2019-06-13  Pedro Alves  <palves@redhat.com>
2532
2533         * compile/compile.c (make_compile_options_def_group): Add braces
2534         around array_view initializer.
2535         * thread.c (make_thread_apply_all_options_def_group)
2536         (make_thread_apply_all_options_def_group): Likewise.
2537
2538 2019-06-13  Pedro Alves  <palves@redhat.com>
2539
2540         * NEWS (New commands): Mention "maint test-options
2541         require-delimiter", "maint test-options unknown-is-error", "maint
2542         test-options unknown-is-operand" and "maint show
2543         test-options-completion-result".
2544         (New command options, command completion): New section.
2545         (Completion improvements): New section.
2546         Mention that you can abbreviate "unlimited".
2547
2548 2019-06-13  Pedro Alves  <palves@redhat.com>
2549
2550         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2551         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2552         * unittests/cli-utils-selftests.c (test_parse_flags)
2553         (test_parse_flags_qcs): Delete.
2554         (test_cli_utils): Don't call deleted functions.
2555
2556 2019-06-13  Pedro Alves  <palves@redhat.com>
2557
2558         * thread.c: Include "cli/cli-option.h".
2559         (tp_array_compar_ascending): Global.
2560         (tp_array_compar): Delete function.
2561         (tp_array_compar_ascending, tp_array_compar_descending): New
2562         functions.
2563         (ascending_option_def, qcs_flag_option_def)
2564         (thr_qcs_flags_option_defs)
2565         (make_thread_apply_all_options_def_group)
2566         (make_thread_apply_options_def_group): New.
2567         (thread_apply_all_command): Use gdb::option::process_options.
2568         (thread_apply_command_completer)
2569         (thread_apply_all_command_completer): New.
2570         (thread_apply_command): Use gdb::option::process_options.
2571         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2572         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2573         to generate help text of "thread apply".  Adjust "taas"'s help.
2574         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2575         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2576
2577 2019-06-13  Pedro Alves  <palves@redhat.com>
2578
2579         * thread.c (thread_apply_command): Check for invalid TID with
2580         isdigit instead of !isalpha.
2581
2582 2019-06-13  Pedro Alves  <palves@redhat.com>
2583
2584         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2585         (validate_flags_qcs): New.
2586         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2587         (validate_flags_qcs): Declare.
2588         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2589         (make_frame_apply_options_def_group): New.
2590         (frame_apply_command_count): Process options with
2591         gdb::option::process_options.
2592         (frame_apply_completer): New.
2593         (frame_apply_level_completer, frame_apply_all_completer)
2594         (frame_apply_completer): New.
2595         (_initialize_stack): Update help of "frame apply", "frame apply
2596         level", "frame apply all" and "faas" to mention supported options
2597         and install command completers.
2598         * stack.h (frame_apply_all_completer): Declare.
2599         * thread.c: Include "stack.h".
2600         (tfaas_command): Add "--".
2601         (_initialize_thread): Update help "tfaas" to mention supported
2602         options and install command completer.
2603
2604 2019-06-13  Pedro Alves  <palves@redhat.com>
2605
2606         * completer.c (complete_nested_command_line): New.
2607         (gdb_completion_word_break_characters_throw): Add assertion.
2608         * completer.h (complete_nested_command_line): Declare.
2609
2610 2019-06-13  Pedro Alves  <palves@redhat.com>
2611
2612         * stack.c (parse_backtrace_qualifiers): New.
2613         (backtrace_command): Use it.
2614         (backtrace_command_completer): Complete on qualifiers.
2615
2616 2019-06-13  Pedro Alves  <palves@redhat.com>
2617
2618         * frame.c: Include "cli/cli-option.h.
2619         (user_set_backtrace_options): New.
2620         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2621         Delete.
2622         (get_prev_frame): Adjust.
2623         (boolean_option_def, uinteger_option_def)
2624         (set_backtrace_option_defs): New.
2625         (_initialize_frame): Adjust and use
2626         gdb::option::add_setshow_cmds_for_options to install "set
2627         backtrace past-main" and "set backtrace past-entry".
2628         * frame.h: Include "cli/cli-option.h".
2629         (struct frame_print_options): Forward declare.
2630         (print_frame_arguments_all, print_frame_arguments_scalars)
2631         (print_frame_arguments_none): Declare.
2632         (print_entry_values): Delete declaration.
2633         (struct frame_print_options, user_frame_print_options): New.
2634         (struct set_backtrace_options): New.
2635         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2636         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2637         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2638         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2639         (list_args_or_locals): Add frame_print_options parameter.
2640         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2641         * python/py-framefilter.c (enumerate_args): Pass down
2642         USER_FRAME_PRINT_OPTIONS.
2643         * stack.c: Include "cli/cli-option.h".
2644         (print_frame_arguments_all, print_frame_arguments_scalars)
2645         (print_frame_arguments_none): Declare.
2646         (print_raw_frame_arguments, print_entry_values): Delete.
2647         (user_frame_print_options): New.
2648         (boolean_option_def, enum_option_def, frame_print_option_defs):
2649         New.
2650         (struct backtrace_cmd_options): New.
2651         (bt_flag_option_def): New.
2652         (backtrace_command_option_defs): New.
2653         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2654         (print_frame_arg, read_frame_arg, print_frame_args)
2655         (print_frame_info, print_frame): Add frame_print_options parameter
2656         and use it.
2657         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2658         (backtrace_command_1): Add frame_print_options and
2659         backtrace_cmd_options parameters and use them.
2660         (make_backtrace_options_def_group): New.
2661         (backtrace_command): Process command options with
2662         gdb::option::process_options.
2663         (backtrace_command_completer): New.
2664         (_initialize_stack): Extend "backtrace"'s help to mention
2665         supported options.  Install completer for "backtrace".
2666         Install some settings commands with add_setshow_cmds_for_options.
2667
2668 2019-06-13  Pedro Alves  <palves@redhat.com>
2669
2670         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2671         and that "set/show print raw frame-arguments" are now deprecated.
2672
2673         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2674         command.
2675         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2676         * stack.c (_initialize_stack): Install "set/show print
2677         raw-frame-arguments", and deprecate "set/show print raw
2678         frame-arguments".
2679         * valprint.c (_initialize_valprint): Deprecate "set/show print
2680         raw".
2681
2682 2019-06-13  Pedro Alves  <palves@redhat.com>
2683
2684         * compile/compile.c (struct compile_options): New.
2685         (compile_flag_option_def, compile_command_option_defs)
2686         (make_compile_options_def_group): New.
2687         (compile_file_command): Handle options with
2688         gdb::option::process_options.
2689         (compile_file_command_completer): New function.
2690         (compile_code_command): Handle options with
2691         gdb::option::process_options.
2692         (compile_code_command_completer): New function.
2693         (_initialize_compiler): Install completers for "compile code" and
2694         "compile file".  Mention available options in "compile code" and
2695         "compile code"'s help.
2696         * completer.c (advance_to_completion_word): New, factored out from
2697         ...
2698         (advance_to_expression_complete_word_point): ... this.
2699         (advance_to_filename_complete_word_point): New.
2700         * completer.h (advance_to_filename_complete_word_point): New
2701         declaration.
2702
2703 2019-06-13  Pedro Alves  <palves@redhat.com>
2704
2705         * compile/compile.c: Include "cli/cli-option.h".
2706         (compile_print_value): Scope data pointer is now a
2707         value_print_options pointer; adjust.
2708         (compile_print_command): Process options.  Scope data pointer is
2709         now a value_print_options pointer; adjust.
2710         (_initialize_compile): Update "compile print"'s help to include
2711         supported options.  Install a completer for "compile print".
2712         * cp-valprint.c (show_vtblprint, show_objectprint)
2713         (show_static_field_print): Delete.
2714         (_initialize_cp_valprint): Don't install "set print
2715         static-members", "set print vtbl", "set print object" here.
2716         * printcmd.c: Include "cli/cli-option.h" and
2717         "common/gdb_optional.h".
2718         (print_command_parse_format): Rework to fill in a
2719         value_print_options instead of a format_data.
2720         (print_value): Change parameter type from format_data pointer to
2721         value_print_options reference.  Adjust.
2722         (print_command_1): Process options.  Adjust to pass down a
2723         value_print_options.
2724         (print_command_completer): New.
2725         (_initialize_printcmd): Install print_command_completer as
2726         handle_brkchars completer for the "print" command.  Update
2727         "print"'s help to include supported options.
2728         * valprint.c: Include "cli/cli-option.h".
2729         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2730         here from cp-valprint.c.
2731         (boolean_option_def, uinteger_option_def)
2732         (value_print_option_defs, make_value_print_options_def_group):
2733         New.  Use gdb::option::add_setshow_cmds_for_options to install
2734         "set print elements", "set print null-stop", "set print repeats",
2735         "set print pretty", "set print union", "set print array", "set
2736         print address", "set print symbol", "set print array-indexes".
2737         * valprint.h: Include <string> and "cli/cli-option.h".
2738         (make_value_print_options_def_group): Declare.
2739         (print_value): Change parameter type from format_data pointer to
2740         value_print_options reference.
2741         (print_command_completer): Declare.
2742
2743 2019-06-13  Pedro Alves  <palves@redhat.com>
2744
2745         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2746         (COMMON_SFILES): Add maint-test-settings.c.
2747         * cli/cli-decode.c (boolean_enums): New global, factored out from
2748         ...
2749         (add_setshow_boolean_cmd): ... here.
2750         * cli/cli-decode.h (boolean_enums): Declare.
2751         * cli/cli-option.c: New file.
2752         * cli/cli-option.h: New file.
2753         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2754         factored out from ...
2755         (parse_cli_boolean_value(const char *)): ... this.
2756         (is_unlimited_literal): Change parameter type to pointer to
2757         pointer.  Adjust and advance ARG pointer.
2758         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2759         (parse_cli_var_enum): New, factored out from ...
2760         (do_set_command): ... this.  Adjust.
2761         * cli/cli-setshow.h (parse_cli_boolean_value)
2762         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2763         (parse_cli_var_enum): Declare.
2764         * cli/cli-utils.c: Include "cli/cli-option.h".
2765         (get_ulongest): New.
2766         * cli/cli-utils.h (get_ulongest): Declare.
2767         (check_for_argument): New overloads.
2768         * maint-test-options.c: New file.
2769
2770 2019-06-13  Pedro Alves  <palves@redhat.com>
2771
2772         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2773         parse a range if "-" is at the end of the string.
2774
2775 2019-06-13  Pedro Alves  <palves@redhat.com>
2776
2777         * cli/cli-setshow.c (parse_auto_binary_operation)
2778         (parse_cli_boolean_value): Don't allow "o".
2779
2780 2019-06-13  Pedro Alves  <palves@redhat.com>
2781
2782         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2783         * NEWS: Mention maint test-settings KIND.
2784         * maint-test-settings.c: New file.
2785
2786 2019-06-13  Pedro Alves  <palves@redhat.com>
2787
2788         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2789         completer.
2790         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2791         "set" completers.
2792
2793 2019-06-13  Pedro Alves  <palves@redhat.com>
2794
2795         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2796         after item.
2797
2798 2019-06-13  Pedro Alves  <palves@redhat.com>
2799
2800         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2801
2802 2019-06-13  Pedro Alves <palves@redhat.com>
2803
2804         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2805         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2806         call.
2807         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2808         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2809         calls.
2810         (check_for_argument): Skip spaces after argument.
2811
2812 2019-06-13  Pedro Alves  <palves@redhat.com>
2813
2814         * thread.c (thread_apply_command): Adjust TID parsing.
2815         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2816         detected before end of string.
2817         (tid_is_in_list): Error out if LIST is invalid.
2818
2819 2019-06-13  Pedro Alves  <palves@redhat.com>
2820
2821         * completer.c (complete_line_internal_1): Rewind completion word
2822         point.
2823         (completion_tracker::advance_custom_word_point_by): Change
2824         parameter type to int.
2825         * completer.h (completion_tracker::advance_custom_word_point_by):
2826         Likewise.
2827
2828 2019-06-13  Pedro Alves  <palves@redhat.com>
2829
2830         * completer.c (advance_to_completion_word): Handle delimiters.
2831
2832 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2833
2834         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2835
2836 2019-06-11  Tom Tromey  <tom@tromey.com>
2837
2838         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2839         (xmalloc_failed): Move to alloc.c.
2840         * alloc.c: New file.
2841         * Makefile.in (COMMON_SFILES): Add alloc.c.
2842
2843 2019-06-11  Tom Tromey  <tom@tromey.com>
2844
2845         * nat/linux-waitpid.c: Don't include server.h.
2846         (linux_debug): Remove.
2847         (my_waitpid): Update.
2848
2849 2019-06-11  Tom Tromey  <tromey@adacore.com>
2850
2851         * infcall.c (_initialize_infcall): Remove trailing newline from
2852         help.
2853         * user-regs.c (_initialize_user_regs): Remove trailing newline
2854         from help.
2855         * typeprint.c (_initialize_typeprint): Remove trailing newline
2856         from help.
2857         * reverse.c (_initialize_reverse): Remove trailing newlines from
2858         help.
2859         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2860         from help.
2861         * language.c (add_set_language_command): Remove trailing newline
2862         from help.
2863         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2864         help.
2865         * disasm.c (_initialize_disasm): Remove trailing newline from
2866         help.
2867         * top.c (init_main): Remove trailing newline from help.
2868         * interps.c (_initialize_interpreter): Remove trailing newline
2869         from help.
2870         * btrace.c (_initialize_btrace): Remove trailing newlines from
2871         help.
2872         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2873         from help.
2874         * python/python.c (_initialize_python): Remove trailing newline
2875         from help.
2876         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2877         help.
2878         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2879         from help.  Reformat some text.
2880         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2881         from help.
2882         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2883         newline from help.
2884
2885 2019-06-11  Tom Tromey  <tromey@adacore.com>
2886
2887         * darwin-nat.c (darwin_decode_exception_message)
2888         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2889
2890 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2891
2892         * valops.c (value_slice): Check for not allocated or not
2893         associated values.
2894
2895 2019-06-10  Tom de Vries  <tdevries@suse.de>
2896
2897         PR gdb/24618
2898         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2899         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2900         invalid.
2901
2902 2019-06-10  Tom de Vries  <tdevries@suse.de>
2903
2904         PR gdb/24611
2905         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2906         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2907
2908 2019-06-10  Tom de Vries  <tdevries@suse.de>
2909
2910         PR symtab/24545
2911         * symtab.c (struct demangled_name_entry): Add language field.
2912         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2913         static minimal symbol".  Set and use language field.
2914
2915 2019-06-10  Tom Tromey  <tromey@adacore.com>
2916
2917         * ada-lang.c (_initialize_ada_language): Update help text.
2918
2919 2019-06-10  Tom Tromey  <tromey@adacore.com>
2920
2921         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2922         with a newline.
2923         * guile/guile.c (handle_boot_error): Don't end warning with a
2924         newline.
2925         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2926         warning with a newline.
2927         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2928         newline.
2929         (s12z_frame_cache): Likewise.
2930         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2931         a newline.
2932         * solib-svr4.c (disable_probes_interface): Don't end warning with
2933         a newline.
2934         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2935         newline.
2936         * python/python.c (do_finish_initialization): Don't end warning
2937         with a newline.
2938
2939 2019-06-10  Tom Tromey  <tom@tromey.com>
2940
2941         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2942         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2943         gdbpy_enter.
2944
2945 2019-06-10  Tom Tromey  <tromey@adacore.com>
2946
2947         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2948         data.
2949         (elf_new_init): Don't call stabsread_new_init.
2950         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2951         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2952         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2953
2954 2019-06-10  Tom de Vries  <tdevries@suse.de>
2955
2956         PR symtab/16264
2957         PR symtab/24517
2958         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2959
2960 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2961
2962         * source.c (find_and_open_source): Also rewrite relative file
2963         names.
2964
2965 2019-04-26  Amos Bird  <amosbird@gmail.com>
2966
2967         * annotate.c (annotate_thread_exited): Add "thread-exited"
2968         annotation.
2969
2970 2019-06-06  Tom Tromey  <tromey@adacore.com>
2971
2972         * maint.h (class scoped_command_stats): Use
2973         DISABLE_COPY_AND_ASSIGN.
2974         <print_time>: New method.
2975         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2976         print_time.
2977         (scoped_command_stats::print_time): New method.
2978
2979 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2980
2981         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2982         instructions of lengths 6 or 8 bytes.
2983
2984 2019-06-04  Pedro Alves  <palves@redhat.com>
2985
2986         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2987
2988         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2989         * breakpoint.c (condition_completer): Likewise.
2990         * cli/cli-dump.c (scan_expression): Likewise.
2991         * common/filestuff.c (mkdir_recursive): Likewise.
2992         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2993         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2994         (gdb_abspath): Likewise.
2995         * compile/compile-cplus-types.c
2996         (compile_cplus_instance::decl_name): Likewise.
2997         * completer.c (complete_explicit_location):
2998         (signal_completer, reg_or_group_completer_1): Likewise.
2999         * cp-support.c (cp_remove_params_if_any): Likewise.
3000         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3001         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3002         * infcmd.c (strip_bg_char): Likewise.
3003         * linespec.c (copy_token_string): Likewise.
3004         * mi/mi-main.c (output_cores): Likewise.
3005         * psymtab.c (psymtab_search_name):
3006         * symfile.c (test_set_ext_lang_command): Likewise.
3007         * target.c (target_fileio_read_stralloc): Likewise.
3008         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3009         * value.c (complete_internalvar): Likewise.
3010
3011 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3012
3013         Add objfile property to gdb.Type.
3014         * NEWS: Mention Python API addition.
3015         * python/py-type.c (typy_get_objfile): New method.
3016
3017 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3018
3019         * NEWS: Mention the new set|show style [title|highlight].
3020         Mention changes to "show style", "help" and "apropos".
3021
3022 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3023
3024         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3025         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3026         instead of print_help_for_command.
3027         (print_doc_of_command): New function.
3028         (help_list): Add 'apropos -v word' suggestion.
3029         (print_help_for_command): Style the command name using title style.
3030         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3031         (_initialize_cli_cmds): Describe -v in apropos_command help.
3032
3033 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3034
3035         * cli/cli-style.h (cli_style_option): Add name in constructor,
3036         add m_name class member, add constructor with intensity,
3037         add name class function.
3038         (cli_style_option::add_setshow_commands): Remove name argument.
3039         (highlight_style, title_style): New styles.
3040         * cli/cli-style.c (do_show): New function that shows a style
3041         characteristic styling the style name with itself.
3042         (set_style_name): New function.
3043         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3044         Update all callers according to the changes in cli/cli-style.h.
3045         * utils.h (fputs_highlighted): New function.
3046         * utils.c (fputs_highlighted): Likewise.
3047
3048 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3049
3050         * NEWS: Mention new pipe command and new convenience variables.
3051
3052 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3053
3054         * cli/cli-cmds.c (pipe_command): New function.
3055         (_initialize_cli_cmds): Call add_com for pipe_command.
3056         Define | as an alias for pipe.
3057         (exit_status_set_internal_vars): New function.
3058         (shell_escape): Call exit_status_set_internal_vars.
3059         cli/cli-decode.c (find_command_name_length): Recognize | as
3060         a single character command.
3061
3062 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3063
3064         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3065         top.c (execute_command_to_ui_file): New function, mostly a copy
3066         of execute_command_to_string.
3067         (execute_command_to_string): Implement by calling
3068         execute_command_to_ui_file.
3069
3070 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3071
3072         * top.h (saved_command_line): Remove declaration.
3073         * top.c (previous_saved_command_line, previous_repeat_arguments):
3074         New variables.
3075         (saved_command_line): Make static, define together with other
3076         'repeat variables'.
3077         (dont_repeat): Clear repeat_arguments.
3078         (repeat_previous, get_saved_command_line, save_command_line):
3079         New functions.
3080         (gdb_init): Initialize saved_command_line
3081         and previous_saved_command_line.
3082         * main.c (captured_main_1): Remove saved_command_line initialization.
3083         * event-top.c (handle_line_of_input): Update to use
3084         the new 'repeat' related functions instead of direct access to
3085         saved_command_line.
3086         * command.h (repeat_previous, get_saved_command_line,
3087         save_command_line): New declarations.
3088         (dont_repeat): Add comment.
3089
3090 2019-05-30  Tom Tromey  <tromey@adacore.com>
3091
3092         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3093         Fix comment.
3094         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3095
3096 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3097
3098         PR cli/24587
3099         * completer.c (complete): Initialize variable word.
3100
3101 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3102
3103         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3104         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3105         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3106         'body' is NULL to the outter 'if', protecting the '!is_define'
3107         situation as well.
3108
3109 2019-05-29  Tom Tromey  <tromey@adacore.com>
3110
3111         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3112         (dwarf_unknown): New function.
3113         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3114         (dwarf_type_encoding_name): Use dwarf_unknown.
3115
3116 2019-05-29  Tom Tromey  <tromey@adacore.com>
3117
3118         PR c++/20020:
3119         * cp-valprint.c (cp_print_value_fields): Call
3120         cp_print_static_field inside "try".
3121
3122 2019-05-29  Tom Tromey  <tromey@adacore.com>
3123
3124         * inflow.c (struct terminal_info): Add default operator=.
3125         * configure: Rebuild.
3126         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3127         -Wdeprecated-copy-dtor, -Wredundant-move.
3128
3129 2019-05-29  Tom Tromey  <tromey@adacore.com>
3130
3131         * NEWS: Add entry.
3132         * infcmd.c (print_return_value_1): Handle finish_print
3133         option.
3134         (show_print_finish): New function.
3135         (_initialize_infcmd): Add "set/show print finish" commands.
3136         * valprint.c (user_print_options): Initialize new member.
3137         * valprint.h (struct value_print_options) <finish_print>: New
3138         member.
3139
3140 2019-05-28  Tom Tromey  <tromey@adacore.com>
3141
3142         * ada-lang.c (ada_remove_Xbn_suffix)
3143         (find_old_style_renaming_symbol)
3144         (parse_old_style_renaming): Remove.
3145         (ada_find_renaming_symbol): Don't call
3146         find_old_style_renaming_symbol.
3147         (ada_is_renaming_symbol): Rename from
3148         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3149         bool.  Now static.
3150         (ada_read_var_value): Update and simplify.
3151         * ada-exp.y (write_var_or_type): Remove old code.
3152
3153 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3154
3155         * event-top.c: Remove include comment.
3156         * inflow.c (class scoped_ignore_sigttou): Move from here...
3157         * inflow.h (class scoped_ignore_sigttou): ...to here.
3158         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3159         * top.c:  Remove include comment.
3160
3161 2019-05-27  Tom Tromey  <tom@tromey.com>
3162
3163         * NEWS: Fix typo.
3164
3165 2019-05-22  Tom Tromey  <tromey@adacore.com>
3166
3167         * target.c (target_follow_exec): Constify parameter.
3168         * target-delegates.c: Rebuild.
3169         * remote.c (remote_target::follow_exec): Constify parameter.
3170         * infrun.c (follow_exec): Constify parameter.
3171         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3172         (target_follow_exec): Likewise.
3173
3174 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3175
3176         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3177         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3178
3179 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3180
3181         * NEWS: Add debugredirect and testsuite sections.
3182
3183 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3184
3185         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3186         target descriptions using exclusively floating point register name
3187         aliases.
3188
3189 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3190
3191         PR gdb/18644:
3192         * f-lang.c (build_fortran_types): Handle the case where
3193         gdbarch_floatformat_for_type returns a nullptr.
3194
3195 2019-05-21  Tom de Vries  <tdevries@suse.de>
3196
3197         PR cli/24587
3198         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3199
3200 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3201
3202         PR gdb/18644:
3203         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3204         16-byte floats.
3205         * i386-tdep.c (i386_floatformat_for_type): Use
3206         floatformats_ia64_quad for the 16-byte floating point component
3207         within a fortran 32-byte complex number.
3208
3209 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3210
3211         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3212         delete default constructor.
3213         (find_partial_die): Update to return const struct.
3214         (partial_die_parent_scope): Move variable declaration into scope
3215         of its use and change its type to auto.
3216         (guess_partial_die_structure_name): Likewise.
3217         (partial_die_info::fixup): Likewise.
3218
3219 2019-05-17  Tom Tromey  <tromey@adacore.com>
3220
3221         * source.c (find_and_open_source): Remove cast.
3222
3223 2019-05-17  Tom Tromey  <tromey@adacore.com>
3224
3225         * annotate.c (annotate_source): Make "filename" const.
3226         * annotate.h (annotate_source): Use const.
3227
3228 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3229
3230         * disasm.c (set_disassembler_options): Send errors to stderr.
3231
3232 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3233
3234         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3235         (cli_interp_base::set_logging): Check debug_redirect.
3236         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3237         * cli/cli-logging.c (debug_redirect): Add static variable.
3238         (pop_output_files): Add default param.
3239         (handle_redirections): Print debug setting.
3240         (show_logging_command): Likewise.
3241         (_initialize_cli_logging): Add debugredirect command.
3242         * interps.c (current_interp_set_logging): Add debug_redirect
3243         parameter.
3244         * interps.h (set_logging): Add debug_redirect parameter.
3245         (current_interp_set_logging): Likewise.
3246         * mi/mi-common.h: Likewise.
3247         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3248
3249 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3250             Tom Tromey  <tromey@adacore.com>
3251
3252         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3253         directly.
3254         * cli/cli-interp.h (make_logging_output): Remove declaration.
3255         * cli/cli-logging.c (make_logging_output): Remove function.
3256         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3257         directly.
3258         * ui-file.c (tee_file::tee_file): Remove bools.
3259         (tee_file::~tee_file): Remove deletes.
3260         * ui-file.h (tee_file): Remove bools.
3261
3262 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3263
3264         * mi/mi-cmds.h (mi_cmd_complete): New function.
3265         * mi/mi-main.c (mi_cmd_complete): Likewise.
3266         * mi/mi-cmds.c: Define new MI command -complete.
3267         * NEWS: Mention new -complete command.
3268
3269 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3270
3271         * completer.h (complete): New function.
3272         * completer.c (complete): Likewise.
3273         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3274         function defined in completer.h.
3275
3276 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3277
3278         * MAINTAINERS (Write After Approval): Add myself.
3279
3280 2019-05-17  Tom de Vries  <tdevries@suse.de>
3281
3282         PR gdb/24094
3283         * dwarf2read.c (struct cu_partial_die_info): New struct.
3284         (find_partial_die): Return cu_partial_die_info.
3285         (partial_die_parent_scope, guess_partial_die_structure_name)
3286         (partial_die_info::fixup): Handle new return type of find_partial_die.
3287
3288 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3289
3290         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3291         "std::string", simplifying the algorithm.
3292
3293 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3294
3295         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3296         (stap_static_probe_ops::get_probes): Likewise.
3297
3298 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3299
3300         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3301         '-')" and "else if".
3302         (stap_parse_single_operand): Join checks for
3303         "gdbarch_stap_parse_special_token_p" and
3304         "gdbarch_stap_parse_special_token" in the same "if" statement.
3305         Invert check when verifying for operation on register
3306         displacement.
3307
3308 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3309
3310         * stap-probe.c (stap_get_opcode): Update comment.
3311         (stap_get_expected_argument_type): Likewise.
3312         (handle_stap_probe): Likewise.
3313
3314 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3315
3316         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3317         return type to 'bool'.  Adjust comment.  Use 'bool' when
3318         appropriate.
3319         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3320         * stap-probe.c (stap_parse_argument_1): Likewise.
3321         (stap_is_operator): Likewise.
3322         (stap_is_generic_prefix): Likewise.
3323         (stap_is_register_prefix): Likewise.
3324         (stap_is_register_indirection_prefix): Likewise.
3325         (stap_is_integer_prefix): Likewise.
3326         (stap_generic_check_suffix): Likewise.
3327         (stap_check_integer_suffix): Likewise.
3328         (stap_check_register_suffix): Likewise.
3329         (stap_check_register_indirection_suffix): Likewise.
3330         (stap_parse_register_operand): Likewise.
3331         (stap_parse_single_operand): Likewise.
3332         (stap_parse_argument_1): Likewise.
3333         (stap_probe::get_argument_count): Likewise.
3334         (stap_is_operator): Likewise.
3335
3336 2019-05-16  Tom Tromey  <tromey@adacore.com>
3337
3338         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3339         keyword to foreach.
3340
3341 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3342
3343         * linux-thread-db.c (try_thread_db_load_1): Change return type
3344         to bool.
3345         (try_thread_db_load): Likewise.
3346         (try_thread_db_load_from_pdir_1): Likewise.
3347         (try_thread_db_load_from_pdir): Likewise.
3348         (try_thread_db_load_from_sdir): Likewise.
3349         (try_thread_db_load_from_dir): Likewise.
3350         (thread_db_load_search): Likewise.
3351         (has_libpthread): Likewise.
3352         (thread_db_load): Likewise.
3353
3354 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3355
3356         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3357         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3358         NULL, and complain/return if that's the case.
3359
3360 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3361
3362         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3363         (advance, posn, abstract_read_memory): New functions.
3364         [struct mem_read_abstraction]: New struct.
3365         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3366
3367 2019-05-14  Tom Tromey  <tromey@adacore.com>
3368
3369         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3370         value is not lval_memory.
3371
3372 2019-05-14  Tom Tromey  <tromey@adacore.com>
3373
3374         * solib.c (info_sharedlibrary_command): Style the file name.
3375
3376 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3377
3378         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3379         (aarch64_vnv_type): Likewise.
3380         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3381         * common/tdesc.c: Likewise.
3382         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3383         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3384         * features/aarch64-fpu.xml: Add ieee half view.
3385         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3386         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3387         * gdbtypes.h (struct builtin_type): Likewise.
3388         (struct objfile_type): Likewise.
3389
3390 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3391
3392         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3393         typo.
3394         * location.h (string_to_event_location): Likewise.
3395
3396 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3397
3398         GDB 8.3 released.
3399
3400 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3401
3402         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3403         New variable declaration.
3404         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3405         New variable.
3406         (print_one_breakpoint): Use ui_out::test_flags and new global
3407         variable to compute use_fixed_output.
3408         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3409         Remove.
3410         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3411         (mi_multi_location_breakpoint_output_fixed): Remove.
3412         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3413         new variable.
3414         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3415         fix_multi_location_breakpoint_output flag if version >= 3.
3416         * ui-out.h (enum ui_out_flag)
3417         <fix_multi_location_breakpoint_output>: New enumerator.
3418
3419 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3420
3421         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3422
3423 2019-05-10  Tom Tromey  <tromey@adacore.com>
3424
3425         * ada-lang.c (catch_ada_completer): New function.
3426         (_initialize_ada_language): Use it.
3427
3428 2019-05-10  Tom Tromey  <tromey@adacore.com>
3429
3430         * thread.c (print_thread_info): Make "requested_threads" const.
3431         * gdbthread.h (print_thread_info): Make "requested_threads"
3432         const.
3433         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3434         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3435
3436 2019-05-08  Tom Tromey  <tom@tromey.com>
3437
3438         * gdbtypes.c (objfile_type_data): Change type.
3439         (objfile_type, _initialize_gdbtypes): Update.
3440
3441 2019-05-08  Tom Tromey  <tom@tromey.com>
3442
3443         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3444         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3445         (_initialize_dwarf2_frame): Update.
3446
3447 2019-05-08  Tom Tromey  <tom@tromey.com>
3448
3449         * objc-lang.c (objc_objfile_data): Change type.
3450         (find_methods): Update.
3451         (_initialize_objc_lang): Remove.
3452
3453 2019-05-08  Tom Tromey  <tom@tromey.com>
3454
3455         * stabsread.c (rs6000_builtin_type_data): Change type.
3456         (rs6000_builtin_type, _initialize_stabsread): Update.
3457
3458 2019-05-08  Tom Tromey  <tom@tromey.com>
3459
3460         * mips-tdep.c (mips_pdr_data): Remove.
3461         (_initialize_mips_tdep): Update.
3462
3463 2019-05-08  Tom Tromey  <tom@tromey.com>
3464
3465         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3466         (hppa_init_objfile_priv_data, read_unwind_info)
3467         (find_unwind_entry, _initialize_hppa_tdep): Update.
3468
3469 2019-05-08  Tom Tromey  <tom@tromey.com>
3470
3471         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3472         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3473         on obstack.
3474         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3475
3476 2019-05-08  Tom Tromey  <tom@tromey.com>
3477
3478         * mdebugread.c (basic_type_data): Change type.
3479         (basic_type, _initialize_mdebugread): Update.
3480
3481 2019-05-08  Tom Tromey  <tom@tromey.com>
3482
3483         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3484
3485 2019-05-08  Tom Tromey  <tom@tromey.com>
3486
3487         * nto-tdep.c (nto_inferior_data_reg): Change type.
3488         (nto_inferior_data): Update.
3489         (nto_inferior_data_cleanup, nto_new_inferior_data)
3490         (_initialize_nto_tdep): Remove.
3491         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3492
3493 2019-05-08  Tom Tromey  <tom@tromey.com>
3494
3495         * ada-lang.c (struct ada_inferior_data): Add initializers.
3496         (ada_inferior_data): Change type.
3497         (ada_inferior_data_cleanup): Remove.
3498         (get_ada_inferior_data, ada_inferior_exit)
3499         (struct ada_pspace_data): Add initializers, destructor.
3500         (ada_pspace_data_handle): Change type.
3501         (get_ada_pspace_data): Update.
3502         (ada_pspace_data_cleanup): Remove.
3503
3504 2019-05-08  Tom Tromey  <tom@tromey.com>
3505
3506         * coffread.c (struct coff_symfile_info): Add initializers.
3507         (coff_objfile_data_key): Move lower.  Change type.
3508         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3509         Update.
3510         (coff_free_info): Remove.
3511
3512 2019-05-08  Tom Tromey  <tom@tromey.com>
3513
3514         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3515         (fbsd_pspace_data_handle): Move lower.  Change type.
3516         (get_fbsd_pspace_data): Update.
3517         (fbsd_pspace_data_cleanup): Remove.
3518         (_initialize_fbsd_tdep): Update.
3519
3520 2019-05-08  Tom Tromey  <tom@tromey.com>
3521
3522         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3523         (get_ada_tasks_pspace_data): Update.
3524         (ada_tasks_pspace_data_cleanup): Remove.
3525         (_initialize_tasks): Update.
3526         (ada_tasks_inferior_data_handle): Change type.
3527         (get_ada_tasks_inferior_data): Update.
3528         (ada_tasks_inferior_data_cleanup): Remove.
3529         (struct ada_tasks_pspace_data): Add initializers.
3530
3531 2019-05-08  Tom Tromey  <tom@tromey.com>
3532
3533         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3534         * symfile-debug.c (debug_sym_get_probes): Change type.
3535         * stap-probe.c (handle_stap_probe):
3536         (stap_static_probe_ops::get_probes): Change type.
3537         * probe.h (class static_probe_ops) <get_probes>: Change type.
3538         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3539         (parse_probes_in_pspace): Update.
3540         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3541         Update.
3542         (any_static_probe_ops::get_probes): Change type.
3543         * elfread.c (elfread_data): New typedef.
3544         (probe_key): Change type.
3545         (elf_get_probes): Likewise.  Update.
3546         (probe_key_free): Remove.
3547         (_initialize_elfread): Update.
3548         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3549         Change type.
3550         (dtrace_process_dof_probe, dtrace_process_dof)
3551         (dtrace_static_probe_ops::get_probe): Change type.
3552
3553 2019-05-08  Tom Tromey  <tom@tromey.com>
3554
3555         * xcoffread.c (struct xcoff_symfile_info): Rename from
3556         coff_symfile_info.  Add initializers.
3557         (xcoff_objfile_data_key): Move lower.  Change type.
3558         (XCOFF_DATA): Rewrite.
3559         (xcoff_free_info): Remove.
3560         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3561         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3562         (xcoff_initial_scan): Update.
3563
3564 2019-05-08  Tom Tromey  <tom@tromey.com>
3565
3566         * solib-svr4.c (struct svr4_info): Add initializers and
3567         destructor.
3568         <probes_table>: Now an htab_up.
3569         (solib_svr4_pspace_data): Change type.
3570         (free_probes_table): Simplify.
3571         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3572         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3573         (probes_table_remove_objfile_probes, register_solib_event_probe)
3574         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3575         (_initialize_svr4_solib): Update.
3576
3577 2019-05-08  Tom Tromey  <tom@tromey.com>
3578
3579         * remote.c (remote_pspace_data): Change type.
3580         (remote_pspace_data_cleanup): Remove.
3581         (get_remote_exec_file, set_pspace_remote_exec_file)
3582         (_initialize_remote): Update.
3583
3584 2019-05-08  Tom Tromey  <tom@tromey.com>
3585
3586         * breakpoint.c (breakpoint_objfile_key): Change type.
3587         (get_breakpoint_objfile_data): Update.
3588         (free_breakpoint_objfile_data): Remove.
3589         (_initialize_breakpoint): Update.
3590
3591 2019-05-08  Tom Tromey  <tom@tromey.com>
3592
3593         * linux-tdep.c (struct linux_info): Add initializers.
3594         (linux_inferior_data): Move.  Change type.
3595         (invalidate_linux_cache_inf): Update.
3596         (linux_inferior_data_cleanup): Remove.
3597         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3598
3599 2019-05-08  Tom Tromey  <tom@tromey.com>
3600
3601         * auxv.c (auxv_inferior_data): Move.  Change type.
3602         (auxv_inferior_data_cleanup): Remove.
3603         (invalidate_auxv_cache_inf): Rewrite.
3604         (get_auxv_inferior_data, _initialize_auxv): Update.
3605
3606 2019-05-08  Tom Tromey  <tom@tromey.com>
3607
3608         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3609         (symfile_debug_objfile_data_key): Change type.
3610         (symfile_debug_installed, debug_qf_has_symbols)
3611         (debug_qf_find_last_source_symtab)
3612         (debug_qf_forget_cached_source_info)
3613         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3614         (debug_qf_print_stats, debug_qf_dump)
3615         (debug_qf_expand_symtabs_for_function)
3616         (debug_qf_expand_all_symtabs)
3617         (debug_qf_expand_symtabs_with_fullname)
3618         (debug_qf_map_matching_symbols)
3619         (debug_qf_expand_symtabs_matching)
3620         (debug_qf_find_pc_sect_compunit_symtab)
3621         (debug_qf_map_symbol_filenames)
3622         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3623         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3624         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3625         (debug_sym_read_linetable, debug_sym_relocate): Update.
3626         (symfile_debug_free_objfile): Remove.
3627         (install_symfile_debug_logging, _initialize_symfile_debug):
3628         Update.
3629
3630 2019-05-08  Tom Tromey  <tom@tromey.com>
3631
3632         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3633         allocate_on_obstack.
3634         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3635         (get_dwarf2_per_objfile): Update.
3636         (set_dwarf2_per_objfile): Remove.
3637         (dwarf2_has_info, dwarf2_get_section_info): Update.
3638         (dwarf2_free_objfile): Remove.
3639         (_initialize_dwarf2_read): Update.
3640
3641 2019-05-08  Tom Tromey  <tom@tromey.com>
3642
3643         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3644         initializers.
3645         <unsupported_script_warning_printed,
3646         script_not_found_warning_printed>: Now bool.
3647         (auto_load_pspace_data): Change type.
3648         (~auto_load_pspace_info): Rename from
3649         auto_load_pspace_data_cleanup.
3650         (get_auto_load_pspace_data, init_loaded_scripts_info)
3651         (clear_section_scripts, maybe_print_unsupported_script_warning)
3652         (maybe_print_script_not_found_warning, _initialize_auto_load):
3653         Update.
3654
3655 2019-05-08  Tom Tromey  <tom@tromey.com>
3656
3657         * objfiles.c (objfile_pspace_info): Add destructor and
3658         initializers.
3659         (objfiles_pspace_data): Change type.
3660         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3661         (get_objfile_pspace_data): Update.
3662         (objfiles_bfd_data): Change type.
3663         (get_objfile_bfd_data): Update.
3664         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3665
3666 2019-05-08  Tom Tromey  <tom@tromey.com>
3667
3668         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3669         Change type.
3670         (get_catch_syscall_inferior_data): Update.
3671         (catch_syscall_inferior_data_cleanup): Remove.
3672         (_initialize_break_catch_syscall): Update.
3673
3674 2019-05-08  Tom Tromey  <tom@tromey.com>
3675
3676         * inflow.c (struct terminal_info): Add destructor and
3677         initializers.
3678         (inflow_inferior_data): Change type.
3679         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3680         (get_inflow_inferior_data, inflow_inferior_exit)
3681         (swap_terminal_info, _initialize_inflow): Update.
3682
3683 2019-05-08  Tom Tromey  <tom@tromey.com>
3684
3685         * target-dcache.c (target_dcache_cleanup): Remove.
3686         (target_dcache_aspace_key): Change type.
3687         (target_dcache_init_p, target_dcache_invalidate)
3688         (target_dcache_get, target_dcache_get_or_init)
3689         (_initialize_target_dcache): Update.
3690         * dcache.h (struct dcache_deleter): New.
3691
3692 2019-05-08  Tom Tromey  <tom@tromey.com>
3693
3694         * symtab.c (struct symbol_cache): Add destructor and
3695         initializers.
3696         (symbol_cache_key): Move.  Change type.
3697         (make_symbol_cache, free_symbol_cache): Remove.
3698         (get_symbol_cache): Update.
3699         (symbol_cache_cleanup): Remove.
3700         (ALL_PSPACES, symbol_cache_flush)
3701         (maintenance_print_symbol_cache)
3702         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3703         Update.
3704
3705 2019-05-08  Tom Tromey  <tom@tromey.com>
3706
3707         * symtab.c (struct main_info): Add destructor and initializers.
3708         (main_progspace_key): Move.  Change type.
3709         (get_main_info): Update.
3710         (main_info_cleanup): Remove.
3711         (_initialize_symtab): Update.
3712
3713 2019-05-08  Tom Tromey  <tom@tromey.com>
3714
3715         * registry.h (DECLARE_REGISTRY): Define the _key class.
3716
3717 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3718
3719         * NEWS: Merge two 'New commands' sections.
3720
3721 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3722
3723         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3724         parameter and use Ada language definition instead.
3725         (ada_val_print_ptr): Remove unused language parameter.
3726         (ada_val_print_num): Remove language parameter and use Ada language
3727         definition instead.
3728         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3729         parameter.
3730         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3731         parameter and use Ada language definition instead.
3732         (ada_val_print_1): Update all ada_val_print_xxx calls.
3733         Remove language parameter.
3734         (ada_val_print): Update ada_val_print_1 call.
3735
3736 2019-05-08  Tom Tromey  <tromey@adacore.com>
3737
3738         * remote.c (remote_hw_watchpoint_limit)
3739         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3740         Now static.
3741
3742 2019-05-08  Tom Tromey  <tromey@adacore.com>
3743
3744         * maint.c (_initialize_maint_cmds): Move initialization code to
3745         remote.c.
3746         (watchdog, show_watchdog): Move to remote.c.
3747         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3748         "watchdog" static.
3749         (_initialize_remote): Move initialization code from maint.c.
3750         * defs.h (watchdog): Don't declare.
3751
3752 2019-05-08  Tom Tromey  <tromey@adacore.com>
3753
3754         * tui/tui-interp.c: Include main.h.
3755         * interps.c: Include main.h.
3756         * main.h (interpreter_p): Declare.
3757         * defs.h (interpreter_p): Don't declare.
3758
3759 2019-05-08  Tom Tromey  <tromey@adacore.com>
3760
3761         * dwarf2loc.c: Include dwarf2read.h.
3762         * defs.h (read_unsigned_leb128): Don't declare.
3763         * dwarf2read.h (read_unsigned_leb128): Declare.
3764
3765 2019-05-08  Tom Tromey  <tromey@adacore.com>
3766
3767         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3768         method.
3769
3770 2019-05-08  Tom Tromey  <tromey@adacore.com>
3771
3772         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3773         when no wrap column is set.
3774
3775 2019-05-08  Tom Tromey  <tromey@adacore.com>
3776
3777         * c-lang.c (c_get_string): Handle non-C-style arrays.
3778
3779 2019-05-08  Tom Tromey  <tromey@adacore.com>
3780
3781         * typeprint.c (print_offset_data::update): Print the bit offset,
3782         not the number of bits remaining.
3783
3784 2019-05-08  Tom Tromey  <tromey@adacore.com>
3785
3786         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3787         padding at end of comment.
3788
3789 2019-05-08  Tom Tromey  <tromey@adacore.com>
3790
3791         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3792         Compare main types.
3793
3794 2019-05-06  Tom Tromey  <tom@tromey.com>
3795
3796         * common/scoped_mmap.c: Include common-defs.h.
3797         * common/scoped_mmap.h: Don't include config.h.
3798
3799 2019-05-04  Tom Tromey  <tom@tromey.com>
3800
3801         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3802         (struct aarch64_call_info): Add initializers.
3803         <si>: Now a std::vector.
3804         (pass_on_stack, aarch64_push_dummy_call): Update.
3805
3806 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3807             Tom Tromey  <tom@tromey.com>
3808
3809         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3810         (ppc_threads): Now a std::vector.  Now static.
3811         (hwdebug_find_thread_points_by_tid)
3812         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3813         Update.
3814
3815 2019-05-04  Tom Tromey  <tom@tromey.com>
3816
3817         * arc-tdep.c (arc_tdesc_init): Return bool.
3818
3819 2019-05-04  Tom Tromey  <tom@tromey.com>
3820
3821         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3822         Use gdb_assert_not_reached.
3823
3824 2019-05-04  Tom Tromey  <tom@tromey.com>
3825
3826         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3827         "false".
3828
3829 2019-05-04  Tom Tromey  <tom@tromey.com>
3830
3831         * arc-tdep.c (arc_tdesc_init): Use bool.
3832
3833 2019-05-04  Tom Tromey  <tom@tromey.com>
3834
3835         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3836
3837 2019-05-04  Tom Tromey  <tom@tromey.com>
3838
3839         * cli/cli-cmds.c (valid_command_p): Return bool.
3840
3841 2019-05-04  Tom Tromey  <tom@tromey.com>
3842
3843         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3844         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3845
3846 2019-05-04  Raul Tambre  <raul@tambre.ee>
3847
3848         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3849         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3850         operator for comparison.
3851
3852 2019-05-04  Tom Tromey  <tom@tromey.com>
3853
3854         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3855         (lookup_partial_symbol, print_partial_symbols)
3856         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3857         (psymbol_compare): Update.
3858         (add_psymbol_to_bcache): Clear the entire psymbol.
3859         (maintenance_check_psymtabs): Update.
3860         * psympriv.h (struct partial_symbol): Don't derive from
3861         general_symbol_info.
3862         <obj_section, unrelocated_address, address,
3863         set_unrelocated_address>: Update.
3864         <ginfo>: New member.
3865         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3866         (debug_names::write_psymbols): Update.
3867
3868 2019-05-04  Tom de Vries  <tdevries@suse.de>
3869
3870         * contrib/cc-with-tweaks.sh: Support -n arg.
3871
3872 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3873
3874         * corelow.c (core_target::detach): Ensure frame cache and
3875         register caches are cleared.
3876         inferior.c (exit_inferior_1): Likewise.
3877
3878 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3879             Tom Tromey  <tom@tromey.com>
3880
3881         * dictionary.c (collate_pending_symbols_by_language): Remove
3882         "struct" from foreach.
3883         * symtab.c (lookup_global_symbol_from_objfile)
3884         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3885         foreach.
3886         * ser-tcp.c (net_open): Remove "struct" from foreach.
3887         * objfiles.c (objfile_relocate, objfile_rebase)
3888         (objfile_has_symbols): Remove "struct" from foreach.
3889         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3890         from foreach.
3891         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3892         foreach.
3893         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3894         "struct" from foreach.
3895         * ada-lang.c (create_excep_cond_exprs)
3896         (ada_exception_catchpoint_cond_string): Remove "struct" from
3897         foreach.
3898
3899 2019-05-03  Tom Tromey  <tromey@adacore.com>
3900
3901         * ada-exp.y (convert_char_literal): Check suffix of each
3902         enumerator.
3903
3904 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3905
3906         PR ada/21406:
3907         * ada-exp.y (yywrap): Don't define.
3908         * ada-lex.l (%option): Add noyywrap
3909         (yywrap): Remove.
3910
3911 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3912
3913         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3914         _WIN32_WINNT to the XP level, unless already defined to a higher
3915         level.
3916
3917         * unittests/parse-connection-spec-selftests.c:
3918         * ser-tcp.c:
3919         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3920         override.
3921
3922         * symfile.c (find_separate_debug_file): Remove colon from the
3923         drive spec of DOS/Windows file names of the target, so that the
3924         file name produced from DEBUGDIR and the target's directory will
3925         be valid on DOS/Windows systems.
3926
3927 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3928
3929         * rust-lang.c (val_print_struct): Handle printing structures
3930         containing strings.
3931
3932 2019-05-02  Tom Tromey  <tromey@adacore.com>
3933
3934         * valarith.c (_initialize_valarith): Remove.
3935
3936 2019-05-01  Tom Tromey  <tromey@adacore.com>
3937
3938         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3939         bitfields.
3940
3941 2019-05-01  Tom Tromey  <tromey@adacore.com>
3942
3943         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3944         for big-endian copies.
3945
3946 2019-04-30  Ali Tamur  <tamur@google.com>
3947         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3948         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3949         (read_3_bytes): New function.
3950
3951 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3952
3953         * windows-nat.c (main_thread_id): Delete.
3954         (handle_output_debug_string): Replace main_thread_id by
3955         current_event.dwThreadId.
3956         (fake_create_process): Likewise.
3957         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3958         Do not set main_thread_id.
3959         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3960         current_event.dwThreadId.
3961         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3962
3963 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3964
3965         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3966         Use current_event.dwThreadId instead of main_thread_id.
3967
3968 2019-04-30  Tom Tromey  <tromey@adacore.com>
3969
3970         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3971         (create_excep_cond_exprs): Iterate over program spaces.
3972         (ada_exception_catchpoint_cond_string): Examine all minimal
3973         symbols for exception types.
3974
3975 2019-04-30  Tom Tromey  <tromey@adacore.com>
3976
3977         PR c++/24470:
3978         * dwarf2read.c (process_structure_scope): Handle case where type
3979         has template parameters but no symbol was created.
3980
3981 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3982             Chris January  <chris.january@arm.com>
3983
3984         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3985         qualifier.
3986         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3987
3988 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3989
3990         * f-typeprint.c (f_print_type): Update rules for printing
3991         whitespace.
3992         (f_type_print_varspec_suffix): Likewise.
3993
3994 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3995             Chris January  <chris.january@arm.com>
3996
3997         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3998         function arguments.
3999
4000 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4001
4002         * f-lang.c (build_fortran_types): Change name of void type to
4003         lower case.
4004         * f-typeprint.c (f_type_print_base): Print the name of the void
4005         type, rather than a fixed string.
4006         * f-valprint.c (f_decorations): Use lower case void string.
4007
4008 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4009             Chris January  <chris.january@arm.com>
4010
4011         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4012         types for Fortran.
4013
4014 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4015             Chris January  <chris.january@arm.com>
4016             David Lecomber  <david.lecomber@arm.com>
4017
4018         * f-exp.y (BINOP_INTRINSIC): New token.
4019         (exp): New parser rule handling BINOP_INTRINSIC.
4020         (f77_keywords): Add new builtin procedures.
4021         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4022         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4023         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4024         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4025         (print_unop_subexp_f): New function.
4026         (print_binop_subexp_f): New function.
4027         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4028         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4029         (dump_subexp_body_f): Likewise.
4030         (operator_check_f): Likewise.
4031         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4032         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4033
4034 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4035
4036         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4037         UNOP_KIND.
4038         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4039         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4040         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4041         (operator_length_f): New fuction.
4042         (print_subexp_f): New function.
4043         (op_name_f): New function.
4044         (dump_subexp_body_f): New function.
4045         (operator_check_f): New function.
4046         (exp_descriptor_f): Replace standard expression handling functions
4047         with new functions.
4048         * gdb/fortran-operator.def: New file.
4049         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4050         * gdb/std-operator.def: Remove UNOP_KIND.
4051
4052 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4053
4054         * std-operator.def: Remove unbalanced, stray double quote
4055         character.
4056
4057 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4058             Chris January  <chris.january@arm.com>
4059             Daniel Everett  <daniel.everett@arm.com>
4060             Nick Forrington  <nick.forrington@arm.com>
4061             Richard Bunt  <richard.bunt@arm.com>
4062
4063         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4064         of depth when printing anonymous structs or unions.
4065         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4066         Don't print either the top-level value, or the children if the
4067         max-depth is exceeded.
4068         (ppscm_print_children): When printing the key of a map, allow one
4069         extra level of depth.
4070         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4071         print either the top-level value, or the children if the max-depth
4072         is exceeded.
4073         (print_children): When printing the key of a map, allow one extra
4074         level of depth.
4075         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4076         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4077         (user_print_options): Initialise max_depth field.
4078         (val_print_scalar_or_string_type_p): New function.
4079         (val_print): Check to see if the max depth has been reached.
4080         (val_print_check_max_depth): Define new function.
4081         (show_print_max_depth): New function.
4082         (_initialize_valprint): Add 'print max-depth' option.
4083         * valprint.h (struct value_print_options) <max_depth>: New field.
4084         (val_print_check_max_depth): Declare new function.
4085         * NEWS: Document new feature.
4086
4087 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4088
4089         * ada-lang.c (ada_language_defn): Initialise new field.
4090         * c-lang.c (c_is_string_type_p): New function.
4091         (c_language_defn): Initialise new field.
4092         (cplus_language_defn): Initialise new field.
4093         (asm_language_defn): Initialise new field.
4094         (minimal_language_defn): Initialise new field.
4095         * c-lang.h (c_is_string_type_p): Declare new function.
4096         * d-lang.c (d_language_defn): Initialise new field.
4097         * f-lang.c (f_is_string_type_p): New function.
4098         (f_language_defn): Initialise new field.
4099         * go-lang.c (go_is_string_type_p): New function.
4100         (go_language_defn): Initialise new field.
4101         * language.c (default_is_string_type_p): New function.
4102         (unknown_language_defn): Initialise new field.
4103         (auto_language_defn): Initialise new field.
4104         * language.h (struct language_defn) <la_is_string_type_p>: New
4105         member variable.
4106         (default_is_string_type_p): Declare new function.
4107         * m2-lang.c (m2_language_defn): Initialise new field.
4108         * objc-lang.c (objc_language_defn): Initialise new field.
4109         * opencl-lang.c (opencl_language_defn): Initialise new field.
4110         * p-lang.c (pascal_is_string_type_p): New function.
4111         (pascal_language_defn): Initialise new field.
4112         * rust-lang.c (rust_is_string_type_p): New function.
4113         (rust_language_defn): Initialise new field.
4114
4115 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4116
4117         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4118         New field.
4119         * ada-lang.c (ada_language_defn): Initialise new field.
4120         * c-lang.c (c_language_defn): Likewise.
4121         (cplus_language_defn): Likewise.
4122         (asm_language_defn): Likewise.
4123         (minimal_language_defn): Likewise.
4124         * d-lang.c (d_language_defn): Likewise.
4125         * f-lang.c (f_language_defn): Likewise.
4126         * go-lang.c (go_language_defn): Likewise.
4127         * language.c (unknown_language_defn): Likewise.
4128         (auto_language_defn): Likewise.
4129         * m2-lang.c (m2_language_defn): Likewise.
4130         * objc-lang.c (objc_language_defn): Likewise.
4131         * opencl-lang.c (opencl_language_defn): Likewise.
4132         * p-lang.c (pascal_language_defn): Likewise.
4133         * rust-lang.c (rust_language_defn): Likewise.
4134
4135 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4136
4137         * ada-lang.c (ada_is_character_type): Change return type to bool.
4138         (ada_is_string_type): Likewise.
4139         * ada-lang.h (ada_is_character_type): Update declaration
4140         (ada_is_string_type): Likewise.
4141
4142 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4143
4144         Support style in 'frame|thread apply'
4145
4146         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4147         * record.c (record_start, record_stop): Update callers of
4148         execute_command_to_string with false.
4149         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4150         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4151         methods.
4152         (class string_file): New constructor with term_out parameter.
4153         Override methods term_out and can_emit_style_escape.  New member
4154         term_out.
4155         (class stdio_file): Override can_emit_style_escape.
4156         (class tee_file): Override term_out and can_emit_style_escape.
4157         * utils.h (can_emit_style_escape): Remove.
4158         * utils.c (can_emit_style_escape): Likewise.
4159         Update all callers of can_emit_style_escape (SOMESTREAM) to
4160         SOMESTREAM->can_emit_style_escape.
4161         * source-cache.c (source_cache::get_source_lines): Likewise.
4162         * stack.c (frame_apply_command_count): Call execute_command_to_string
4163         passing the term_out characteristic of the current gdb_stdout.
4164         * thread.c (thr_try_catch_cmd): Likewise.
4165         * top.c (execute_command_to_string): pass term_out parameter
4166         to construct the string_file for the command output.
4167         * ui-file.c (term_cli_styling): New function (most code moved
4168         from utils.c can_emit_style_escape).
4169         (string_file::string_file, string_file::can_emit_style_escape,
4170         stdio_file::can_emit_style_escape, tee_file::term_out,
4171         tee_file::can_emit_style_escape): New functions.
4172
4173 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4174
4175         * NEWS: Mention the new set|show may-call-functions.
4176         * infcall.c (may_call_functions_p): New variable.
4177         (show_may_call_functions_p): New function.
4178         (call_function_by_hand_dummy): Throws an error if not
4179         may-call-functions.
4180         (_initialize_infcall): Call add_setshow_boolean_cmd for
4181         may-call-functions.
4182
4183 2019-04-25  Keith Seitz  <keiths@redhat.com>
4184
4185         PR c++/24367
4186         * cp-support.c (inspect_type): Don't attempt substitutions
4187         of symbol with the same name.
4188
4189 2019-04-25  Tom Tromey  <tromey@adacore.com>
4190
4191         PR gdb/24475:
4192         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4193         static.
4194
4195 2019-04-25  Tom Tromey  <tromey@adacore.com>
4196
4197         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4198         rvalue reference.
4199         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4200         (gdb_xml_parser::parse): Use std::move.
4201         * python/python-internal.h (gdbpy_convert_exception): Take a const
4202         reference.
4203         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4204         std::move.
4205         * python/py-utils.c (gdbpy_convert_exception): Take a const
4206         reference.
4207         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4208         Use std::move.
4209         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4210         Use std::move.
4211         * mi/mi-main.c (mi_print_exception): Take a const reference.
4212         * main.c (handle_command_errors): Take a const reference.
4213         * linespec.c (parse_linespec): Use std::move.
4214         * infcall.c (run_inferior_call): Use std::move.
4215         (call_function_by_hand_dummy): Use std::move.
4216         * exec.c (try_open_exec_file): Use std::move.
4217         * exceptions.h (exception_print, exception_fprintf)
4218         (exception_print_same): Update.
4219         * exceptions.c (print_exception, exception_print)
4220         (exception_fprintf, exception_print_same): Change parameters to
4221         const reference.
4222         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4223         * common/new-op.c: Use std::move.
4224         * common/common-exceptions.h (struct gdb_exception): Add move
4225         constructor.
4226         (struct gdb_exception_error, struct gdb_exception_quit, struct
4227         gdb_quit_bad_alloc): Change constructor to move constructor.
4228         (throw_exception): Change parameter to rvalue reference.
4229         * common/common-exceptions.c (throw_exception): Take rvalue
4230         reference.
4231         * cli/cli-interp.c (safe_execute_command): Use std::move.
4232         * breakpoint.c (insert_bp_location, location_to_sals): Use
4233         std::move.
4234
4235 2019-04-25  Tom Tromey  <tromey@adacore.com>
4236
4237         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4238         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4239         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4240         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4241         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4242         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4243         guile/scm-value.c: Use unpack.
4244         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4245         gdbscm_gdb_exception.
4246         (gdbscm_throw_gdb_exception): Likewise.
4247         (struct gdbscm_gdb_exception): New.
4248         (unpack): New function.
4249         (gdbscm_wrap): Use unpack.
4250
4251 2019-04-25  Tom Tromey  <tromey@adacore.com>
4252
4253         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4254         (gdb_rl_callback_handler): Use std::move.
4255         * common/common-exceptions.h (struct gdb_exception): Add move
4256         assignment operator.
4257         (throw_exception_sjlj): Change "exception" to const reference.
4258         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4259         (throw_exception_sjlj): Change "exception" to const reference.
4260
4261 2019-04-25  Tom Tromey  <tromey@adacore.com>
4262
4263         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4264         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4265         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4266         Update.
4267         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4268         Update.
4269         * mi/mi-interp.c (mi_interp::exec): Update.
4270         * linespec.c (parse_linespec): Update.
4271         * infcall.c (run_inferior_call): Update.
4272         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4273         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4274         (gdbscm_lookup_global_symbol): Update.
4275         * guile/scm-param.c (gdbscm_parameter_value): Update.
4276         * guile/scm-frame.c (gdbscm_frame_read_register)
4277         (gdbscm_frame_read_var): Update.
4278         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4279         * exec.c (try_open_exec_file): Update.
4280         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4281         (gdb_rl_callback_handler): Update.
4282         * common/common-exceptions.h (exception_none): Don't declare.
4283         * common/common-exceptions.c (exception_none): Don't define.
4284         (struct catcher) <exception>: Update.
4285         * cli/cli-interp.c (safe_execute_command): Update.
4286         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4287
4288 2019-04-25  Ali Tamur  <tamur@google.com>
4289
4290         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4291         (read_attribute_value): Likewise.
4292         (dwarf2_read_addr_index): Update comment.
4293         (read_str_index): Add DW_FORM_strx.
4294         (dwarf2_string_attr): Likewise.
4295         (dwarf2_const_value_attr): Likewise.
4296         (dump_die_shallow): Likewise.
4297         (dwarf2_fetch_constant_bytes): Likewise.
4298         (skip_form_bytes): Likewise.
4299         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4300
4301 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4302
4303         PR corefiles/11608
4304         PR corefiles/18187
4305         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4306         OFFSET.  Verify if current mapping contains an ELF header.
4307         (linux_find_memory_regions_full): Adjust call to
4308         dump_mapping_p.
4309
4310 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4311             Kang Li <kanglictf@gmail.com>
4312
4313         PR gdb/21600
4314
4315         * dwarf2-frame.c (read_initial_length): Be consistent about using
4316         unsigned representation of length.
4317         (decode_frame_entry_1): Likewise.  Check for wraparound of
4318         end pointer as well as buffer overflow.
4319
4320 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4321
4322         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4323         "vq".
4324
4325 2019-04-24  Tom Tromey  <tromey@adacore.com>
4326
4327         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4328
4329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4330
4331         * s12z-tdep.c (s12z_unwind_pc): Delete.
4332         (s12z_unwind_sp): Delete.
4333         (s12z_gdbarch_init): Don't register deleted functions with
4334         gdbarch.
4335
4336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4337
4338         * rl78-tdep.c (rl78_unwind_sp): Delete.
4339         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4340
4341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4342
4343         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4344         (xstormy16_unwind_pc): Delete.
4345         (xstormy16_dummy_id): Delete.
4346         (xstormy16_gdbarch_init): Don't register deleted functions with
4347         gdbarch.
4348
4349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4350
4351         * vax-tdep.c (vax_unwind_pc): Delete.
4352         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4353
4354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4355
4356         * v850-tdep.c (v850_unwind_sp): Delete.
4357         (v850_unwind_pc): Delete.
4358         (v850_dummy_id): Delete.
4359         (v850_gdbarch_init): Don't register deleted functions with
4360         gdbarch.
4361
4362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4363
4364         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4365         (tilegx_unwind_pc): Delete.
4366         (tilegx_unwind_dummy_id): Delete.
4367         (tilegx_gdbarch_init): Don't register deleted functions with
4368         gdbarch.
4369
4370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4371
4372         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4373         (tic6x_dummy_id): Delete.
4374         (tic6x_gdbarch_init): Don't register deleted functions with
4375         gdbarch.
4376
4377 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4378
4379         * sparc-tdep.c (sparc_unwind_pc): Delete.
4380         (sparc32_gdbarch_init): Don't register deleted function with
4381         gdbarch.
4382
4383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4384
4385         * sh-tdep.c (sh_unwind_sp): Delete.
4386         (sh_unwind_pc): Delete.
4387         (sh_dummy_id): Delete.
4388         (sh_gdbarch_init): Don't register deleted functions with
4389         gdbarch.
4390
4391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * score-tdep.c (score_unwind_sp): Delete.
4394         (score_unwind_pc): Delete.
4395         (score_dummy_id): Delete.
4396         (score_gdbarch_init): Don't register deleted functions with
4397         gdbarch.
4398
4399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4400
4401         * rx-tdep.c (rx_unwind_pc): Delete.
4402         (rx_unwind_sp): Delete.
4403         (rx_dummy_id): Delete.
4404         (rx_gdbarch_init): Don't register deleted functions with
4405         gdbarch.  Update comment.
4406
4407 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4408
4409         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4410         (rs6000_dummy_id): Delete.
4411         (rs6000_gdbarch_init): Don't register deleted functions with
4412         gdbarch.
4413
4414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4415
4416         * or1k-tdep.c (or1k_dummy_id): Delete.
4417         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4418
4419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4420
4421         * nios2-tdep.c (nios2_dummy_id): Delete.
4422         (nios2_unwind_sp): Delete.
4423         (nios2_gdbarch_init): Don't register deleted functions with
4424         gdbarch.
4425
4426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4427
4428         * nds32-tdep.c (nds32_dummy_id): Delete.
4429         (nds32_unwind_pc): Delete.
4430         (nds32_unwind_sp): Delete.
4431         (nds32_gdbarch_init): Don't register deleted functions with
4432         gdbarch.
4433
4434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4435
4436         * msp430-tdep.c (msp430_unwind_pc): Delete.
4437         (msp430_unwind_sp): Delete.
4438         (msp430_dummy_id): Delete.
4439         (msp430_gdbarch_init): Don't register deleted functions with
4440         gdbarch.
4441
4442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4443
4444         * moxie-tdep.c (moxie_unwind_sp): Delete.
4445         (moxie_unwind_pc): Delete.
4446         (moxie_dummy_id): Delete.
4447         (moxie_gdbarch_init): Don't register deleted functions with
4448         gdbarch.
4449
4450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4451
4452         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4453         (mn10300_unwind_pc): Delete.
4454         (mn10300_unwind_sp): Delete.
4455         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4456         mn10300_unwind_sp.
4457         (mn10300_frame_unwind_init): Don't register deleted functions with
4458         gdbarch.
4459
4460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4461
4462         * mep-tdep.c (mep_unwind_pc): Delete.
4463         (mep_unwind_sp): Delete.
4464         (mep_dummy_id): Delete.
4465         (mep_gdbarch_init): Don't register deleted functions with
4466         gdbarch.
4467
4468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4469
4470         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4471         (m68hc11_unwind_sp): Delete.
4472         (m68hc11_gdbarch_init): Don't register deleted functions with
4473         gdbarch.
4474
4475 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4476
4477         * m32r-tdep.c (m32r_unwind_sp): Delete.
4478         (m32r_unwind_pc): Delete.
4479         (m32r_dummy_id): Delete.
4480         (m32r_gdbarch_init): Don't register deleted functions with
4481         gdbarch.
4482
4483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4484
4485         * m32c-tdep.c (m32c_unwind_pc): Delete.
4486         (m32c_unwind_sp): Delete.
4487         (m32c_dummy_id): Delete.
4488         (m32c_gdbarch_init): Don't register deleted functions with
4489         gdbarch.
4490
4491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4492
4493         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4494         (lm32_unwind_pc): Delete.
4495         (lm32_dummy_id): Delete.
4496         (lm32_gdbarch_init): Don't register deleted functions with
4497         gdbarch.
4498
4499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4500
4501         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4502         (iq2000_unwind_pc): Delete.
4503         (iq2000_dummy_id): Delete.
4504         (iq2000_gdbarch_init): Don't register deleted functions with
4505         gdbarch.
4506
4507 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4508
4509         * nds32-tdep.c (nds32_type_align): Delete.
4510         (nds32_push_dummy_call): Use type_align instead.
4511
4512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4513
4514         * arm-tdep.c (arm_type_align): Only handle vector override case.
4515         (arm_push_dummy_call): Use type_align.
4516         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4517
4518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4519
4520         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4521         case.
4522         (pass_on_stack): Use type_align.
4523         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4524         function.
4525
4526 2019-04-23  Tom Tromey  <tromey@adacore.com>
4527
4528         * dwarf2read.c (line_header::file_name_at): Remove unused
4529         overload.
4530
4531 2019-04-23  Tom de Vries  <tdevries@suse.de>
4532
4533         PR gdb/24438
4534         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4535         invocation.
4536
4537
4538 2019-03-27  Ali Tamur  <tamur@google.com>
4539
4540         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4541         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4542         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4543         (dwarf_expr_context::get_addr_index): Likewise
4544         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4545         (symbol_needs_eval_context::get_addr_index): Likewise
4546         (disassemble_dwarf_expression): Add DW_OP_addrx
4547         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4548         (read_cutu_die_from_dwo): Update comment
4549         (skip_one_die): Add DW_FORM_addrx
4550         (read_attribute_value): Likewise
4551         (var_decode_location): Add DW_OP_addrx
4552         (dwarf2_const_value_attr): Add DW_FORM_addrx
4553         (dump_die_shallow): Likewise
4554         (dwarf2_fetch_constant_bytes): Likewise
4555         (decode_locdesc): Add DW_OP_addrx
4556         (skip_form_bytes): Add DW_FORM_addrx
4557
4558 2019-04-22  Ali Tamur  <tamur@google.com>
4559
4560         * MAINTAINERS (Write After Approval): Add self.
4561
4562 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4563
4564         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4565         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4566         (open_symbol_file_object): Likewise.
4567         (svr4_default_sos): Add info parameter.
4568         (svr4_read_so_list): Likewise.
4569         (svr4_current_sos_direct): Adjust functions calls to pass down
4570         info.
4571         (svr4_current_sos_1): Add info parameter.
4572         (svr4_current_sos): Call get_svr4_info, pass info down to
4573         svr4_current_sos_1.
4574         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4575         get_svr4_info.
4576         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4577         get_svr4_info.
4578         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4579         to get_svr4_info.
4580         (probes_table_remove_objfile_probes): Likewise.
4581         (register_solib_event_probe): Add info parameter.
4582         (solist_update_incremental): Pass info parameter down to
4583         svr4_read_so_list.
4584         (disable_probes_interface): Add info parameter.
4585         (svr4_handle_solib_event): Pass current_program_space to
4586         get_svr4_info.  Adjust disable_probes_interface cleanup.
4587         (svr4_create_probe_breakpoints): Add info parameter, pass it
4588         down to register_solib_event_probe.
4589         (svr4_create_solib_event_breakpoints): Add info parameter,
4590         pass it down to svr4_create_probe_breakpoints.
4591         (enable_break): Pass info down to
4592         svr4_create_solib_event_breakpoints.
4593         (svr4_solib_create_inferior_hook): Pass current_program_space to
4594         get_svr4_info.
4595         (svr4_clear_solib): Likewise.
4596
4597 2019-04-22  Pedro Alves  <palves@redhat.com>
4598
4599         * solib-svr4.c (svr4_free_objfile_observer): New.
4600         (probe_and_action::objfile): New field.
4601         (probes_table_htab_remove_objfile_probes)
4602         (probes_table_remove_objfile_probes): New functions.
4603         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4604         in the new probe_and_action.  Don't store the probe in 'lookup'.
4605         (svr4_create_probe_breakpoints): Pass objfile to
4606         register_solib_event_probe.
4607         (_initialize_svr4_solib): Register a free_objfile observer.
4608
4609 2019-04-19  Tom Tromey  <tom@tromey.com>
4610
4611         * common/queue.h: Remove.
4612
4613 2019-04-19  Tom Tromey  <tom@tromey.com>
4614
4615         * event-loop.c: Don't include "common/queue.h".
4616
4617 2019-04-19  Tom Tromey  <tom@tromey.com>
4618
4619         * remote.c (remote_target): Use delete.
4620         * remote-notif.h: Include <list>, not "common/queue.h".
4621         (notif_client_p): Remove typedef.
4622         (remote_notif_state): Add constructor, destructor, initializer.
4623         <notif_queue>: Now a std::list.
4624         (remote_notif_state_xfree): Don't declare.
4625         * remote-notif.c (remote_notif_process, handle_notification)
4626         (remote_notif_state_allocate): Update.
4627         (~remote_notif_state): Rename from remote_notif_state_xfree.
4628
4629 2019-04-19  Tom Tromey  <tom@tromey.com>
4630
4631         * symfile.c (reread_symbols): Update.
4632         * objfiles.c (objfile_register_static_link)
4633         (objfile_lookup_static_link): Update
4634         (~objfile) Don't delete static_links.
4635         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4636
4637 2019-04-19  Tom Tromey  <tom@tromey.com>
4638
4639         * type-stack.h (struct type_stack) <insert>: Constify string.
4640         * type-stack.c (type_stack::insert): Constify string.
4641         * gdbtypes.h (lookup_template_type): Update.
4642         (address_space_name_to_int): Update.
4643         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4644         const.
4645         (lookup_template_type): Make name const.
4646         * c-exp.y: Update rules.
4647         (lex_one_token, classify_name, classify_inner_name)
4648         (c_print_token): Update.
4649         * p-exp.y: Update rules.
4650         (yylex): Update.
4651         * f-exp.y: Update rules.
4652         (yylex): Update.
4653         * d-exp.y: Update rules.
4654         (lex_one_token, classify_name, classify_inner_name): Update.
4655         * parse.c (write_dollar_variable, copy_name): Return std::string.
4656         * parser-defs.h (copy_name): Change return type.
4657         * m2-exp.y: Update rules.
4658         (yylex): Update.
4659         * go-exp.y (lex_one_token): Update.
4660         Update rules.
4661         (classify_unsafe_function, classify_packaged_name)
4662         (classify_name, yylex): Update.
4663
4664 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4665
4666         * configure.ac: add --enable-source-highlight switch.
4667         * configure: Regenerate.
4668         * top.c (print_gdb_version): plumb --enable-source-highlight
4669         status to "show configuration".
4670
4671 2019-04-19  Tom Tromey  <tromey@adacore.com>
4672
4673         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4674         Check ADA_TYPE_P.
4675         (empty_record, ada_template_to_fixed_record_type_1)
4676         (template_to_static_fixed_type)
4677         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4678         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4679         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4680         macros.
4681
4682 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4683
4684         PR symtab/24423:
4685         * source.c (print_source_lines_base): Advance "iter" when a
4686         control character is seen.
4687
4688 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4689
4690         * inferior.h (struct infcall_suspend_state_deleter):
4691         Catch exception in destructor to avoid crash.
4692
4693 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4694
4695         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4696         close to the add_com "shell".
4697
4698 2019-04-18  Tom Tromey  <tromey@adacore.com>
4699
4700         * process-stratum-target.h (class process_stratum_target)
4701         <stratum>: Add "final".
4702
4703 2019-04-17  Tom Tromey  <tromey@adacore.com>
4704
4705         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4706         against nullptr before use.
4707
4708 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4709
4710         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4711
4712 2019-04-17  Jim Wilson  <jimw@sifive.com>
4713             Andrew Burgess  <andrew.burgess@embecosm.com>
4714
4715         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4716         code read might fail, assume 4-byte breakpoint in that case.
4717
4718 2019-04-15  Leszek Swirski  <leszeks@google.com>
4719
4720         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4721         rather than a hand-rolled POD check when checking for forced MEMORY
4722         classification.
4723
4724 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4725
4726         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4727         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4728         function.
4729         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4730         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4731         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4732         declaration.
4733
4734 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4735
4736         * aarch64-linux-nat.c
4737         (aarch64_linux_nat_target::thread_architecture): Add override.
4738         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4739         each VQ.
4740
4741 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4742
4743         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4744
4745 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4746
4747         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4748         target types of size 96-bits, add some additional comments, and
4749         check that the builtin type we found was the correct size.
4750
4751 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4752
4753         * utils.c (prompt_for_continue): Don't restore the styling at the
4754         end, as applied_style has the wrong value.  This fixes styling in
4755         long lists of file names that are interrupted by the "Continue?"
4756         prompt.
4757
4758 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4759
4760         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4761         * c-lang.c (c_language_defn): Likewise.
4762         (cplus_language_defn): Likewise.
4763         (asm_language_defn): Likewise.
4764         (minimal_language_defn): Likewise.
4765         * d-lang.c (d_language_defn): Likewise.
4766         * f-lang.c (f_language_defn): Likewise.
4767         * go-lang.c (go_language_defn): Likewise.
4768         * language.c (unknown_language_defn): Likewise.
4769         (auto_language_defn): Likewise.
4770         * language.h (struct language_defn): Remove la_magic field.
4771         (LANG_MAGIC): Delete.
4772         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4773         * objc-lang.c (objc_language_defn): Likewise.
4774         * opencl-lang.c (opencl_language_defn): Likewise.
4775         * p-lang.c (pascal_language_defn): Likewise.
4776         * rust-lang.c (rust_language_defn): Likewise.
4777
4778 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4779
4780         * riscv-tdep.c (riscv_type_align): New function.
4781         (riscv_type_alignment): Delete.
4782         (riscv_arg_location): Use 'type_align'.
4783         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4784
4785 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4786
4787         * gdbtypes.c (type_align): A struct with no non-static fields also
4788         has alignment of 1.
4789
4790 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4791
4792         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4793         component to 0.
4794         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4795         member.
4796         (riscv_struct_info::analyse): New implementation using new
4797         analyse_inner member function.
4798         (riscv_struct_info::field_offset): New member function.
4799         (riscv_struct_info::m_offsets): New member variable.
4800         (riscv_struct_info::analyse_inner): New private member function,
4801         takes the old implementation of riscv_struct_info::analyse but
4802         extended to track field offsets.
4803         (riscv_call_arg_struct): Update the struct folding special cases
4804         to handle cases where empty C++ structs, which are non-zero
4805         length, are found.
4806         (riscv_arg_location): Initialise the length of each location, a
4807         non-zero length now indicates the location is in use.
4808         (riscv_push_dummy_call): Allow for the first location having a
4809         non-zero offset when setting up arguments.
4810         (riscv_return_value): Likewise, but for return values.
4811
4812 2019-04-11  Tom Tromey  <tromey@adacore.com>
4813
4814         * utils.c (internal_vproblem): Make "msg" const.
4815
4816 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4817
4818         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4819         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4820         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4821         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4822
4823 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4824
4825         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4826         function.
4827         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4828         of amd64_collect_native_gregset.
4829         (amd64_linux_nat_target::store_registers): Likewise.
4830
4831 2019-04-10  Tom Tromey  <tom@tromey.com>
4832
4833         * symtab.c (lookup_global_symbol_from_objfile)
4834         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4835         * objfiles.h (class separate_debug_iterator): New.
4836         (class separate_debug_range): New.
4837         (struct objfile) <separate_debug_objfiles>: New method.
4838         (objfile_separate_debug_iterate): Don't declare.
4839         * objfiles.c (separate_debug_iterator::operator++): Rename from
4840         objfile_separate_debug_iterate.
4841         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4842         iterator.
4843         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4844         iterator.
4845
4846 2019-04-10  Tom Tromey  <tom@tromey.com>
4847
4848         * symfile.c (reread_symbols): Remove old comment.
4849         * objfiles.c (free_all_objfiles): Fix a typo.
4850
4851 2019-04-10  Tom Tromey  <tom@tromey.com>
4852
4853         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4854         * minsyms.c (lookup_minimal_symbol): Use foreach.
4855         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4856         (lookup_minimal_symbol_solib_trampoline): Likewise.
4857         * symfile.c (reread_symbols): Use foreach.
4858
4859 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4860             Tom Tromey  <tromey@adacore.com>
4861
4862         PR rust/24414:
4863         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4864         (rust_lex_int_test): Change "value" to be LONGEST.
4865         (rust_lex_tests): Add test for long integer literal.
4866
4867 2019-04-09  Tom Tromey  <tromey@adacore.com>
4868
4869         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4870         to bool.
4871         (extended_remote_target::attach): Update.
4872         (remote_target::remote_notice_new_inferior): Update.
4873         (remote_target::add_current_inferior_and_thread): Update.
4874         * inferior.c (exit_inferior_1): Use "false".
4875         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4876
4877 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4878
4879         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4880         the "start" command.
4881
4882 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4883
4884         * python/py-inferior.c (infpy_thread_from_thread_handle):
4885         Adjust comments to reflect renaming of thread_from_thread_handle
4886         to thread_from_handle.  Adjust keywords.  Fix type error message.
4887         (inferior_object_methods): Add thread_from_handle.  Retain
4888         thread_from_thread_handle, but mark it as deprecated.
4889
4890 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4891
4892         * gdbthread.h (find_thread_by_handle): Revise declaration.
4893         * thread.c (find_thread_by_handle): Likewise.  Adjust
4894         implementation too.
4895         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4896         support for buffer objects as handles.
4897
4898 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4899
4900         * python/py-infthread.c (thpy_thread_handle): New function.
4901         (thread_object_methods): Register thpy_thread_handle.
4902
4903 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4904
4905         * gdbthread.h (thread_to_thread_handle): Declare.
4906         * thread.c (gdbtypes.h): Include.
4907         (thread_to_thread_handle): New function.
4908
4909         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4910         (target_thread_info_to_thread_handle): Declare.
4911         * target.c (target_thread_info_to_thread_handle): New function.
4912         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4913         * target-delegates.c: Regenerate.
4914
4915         * linux-thread-db.c (class thread_db_target): Add method
4916         thread_info_to_thread_handle.
4917         (thread_db_target::thread_info_to_thread_handle): Define.
4918         * remote.c (class remote_target): Add new method
4919         thread_info_to_thread_handle.
4920         (remote_target::thread_info_to_thread_handle): Define.
4921
4922 2019-04-08  Pedro Alves  <palves@redhat.com>
4923
4924         * common/common-exceptions.c (throw_exception): Don't create
4925         named object to throw; throw directly.
4926         (throw_it): Likewise.  Don't initialize gdb_exception::message
4927         here, with new; pass FMT and AP to the ctor instead.
4928         * common/common-exceptions.h: Include <string>.
4929         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4930         const char *, va_list)): New ctor.  Use std::make_shared.
4931         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4932         errors)): Delete.
4933         (gdb_exception_error::gdb_exception_error(enum errors, const char
4934         *, va_list)): New.
4935         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4936         Add assertion.
4937         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4938         errors)): Delete.
4939         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4940         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4941         Add assertion.
4942
4943 2019-04-08  Tom Tromey  <tom@tromey.com>
4944
4945         * valops.c (value_rtti_indirect_type): Replace throw_exception
4946         with throw.
4947         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4948         with throw.
4949         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4950         throw.
4951         * target.c (target_translate_tls_address): Replace throw_exception
4952         with throw.
4953         * stack.c (frame_apply_command_count): Replace throw_exception
4954         with throw.
4955         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4956         throw.
4957         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4958         with throw.
4959         * rs6000-tdep.c (rs6000_frame_cache)
4960         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4961         * remote.c: Replace throw_exception with throw.
4962         * record-full.c (record_full_message, record_full_wait_1)
4963         (record_full_restore): Replace throw_exception with throw.
4964         * record-btrace.c:
4965         (get_thread_current_frame_id, record_btrace_start_replaying)
4966         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4967         (cmd_record_btrace_start): Replace throw_exception with throw.
4968         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4969         throw.
4970         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4971         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4972         * linespec.c:
4973         (find_linespec_symbols): Replace throw_exception with throw.
4974         * infrun.c (displaced_step_prepare, resume): Replace
4975         throw_exception with throw.
4976         * infcmd.c (post_create_inferior): Replace throw_exception with
4977         throw.
4978         * inf-loop.c (inferior_event_handler): Replace throw_exception
4979         with throw.
4980         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4981         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4982         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4983         (get_prev_frame_always, get_frame_pc_if_available)
4984         (get_frame_address_in_block_if_available, get_frame_language):
4985         Replace throw_exception with throw.
4986         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4987         throw_exception with throw.
4988         * eval.c (fetch_subexp_value, evaluate_var_value)
4989         (evaluate_funcall, evaluate_subexp_standard): Replace
4990         throw_exception with throw.
4991         * dwarf2loc.c (call_site_find_chain)
4992         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4993         Replace throw_exception with throw.
4994         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4995         with throw.
4996         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4997         throw.
4998         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4999         * completer.c (complete_line_internal): Replace throw_exception
5000         with throw.
5001         * compile/compile-object-run.c (compile_object_run): Replace
5002         throw_exception with throw.
5003         * cli/cli-script.c (process_next_line): Replace throw_exception
5004         with throw.
5005         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5006         (btrace_enable, btrace_maint_update_pt_packets): Replace
5007         throw_exception with throw.
5008         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5009         throw_exception with throw.
5010         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5011         throw_exception with throw.
5012         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5013         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5014         * aarch64-tdep.c (aarch64_make_prologue_cache)
5015         (aarch64_make_stub_cache): Replace throw_exception with throw.
5016
5017 2019-04-08  Tom Tromey  <tom@tromey.com>
5018
5019         * common/common-exceptions.c (throw_exception): Rename from
5020         throw_exception_cxx.  Remove old copy.  Make argument const.
5021         (throw_it): Create and throw exception objects directly.
5022         * common/common-exceptions.h (throw_exception): Make argument
5023         const.
5024         (struct gdb_exception_error): Add constructor.
5025         (struct gdb_exception_quit): Add constructor.
5026
5027 2019-04-08  Tom Tromey  <tom@tromey.com>
5028
5029         * common/common-exceptions.h (exception_rethrow): Don't declare.
5030         (TRY_SJLJ): Update comment.
5031         (TRY, CATCH, END_CATCH): Remove.
5032         * common/common-exceptions.c (exception_rethrow): Remove.
5033
5034 2019-04-08  Tom Tromey  <tom@tromey.com>
5035
5036         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5037         Remove.
5038         (gdb_exception_error): Rename from
5039         gdb_exception_RETURN_MASK_ERROR.
5040         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5041         (gdb_quit_bad_alloc): Update.
5042         * aarch64-tdep.c: Update.
5043         * ada-lang.c: Update.
5044         * ada-typeprint.c: Update.
5045         * ada-valprint.c: Update.
5046         * amd64-tdep.c: Update.
5047         * arch-utils.c: Update.
5048         * break-catch-throw.c: Update.
5049         * breakpoint.c: Update.
5050         * btrace.c: Update.
5051         * c-varobj.c: Update.
5052         * cli/cli-cmds.c: Update.
5053         * cli/cli-interp.c: Update.
5054         * cli/cli-script.c: Update.
5055         * common/common-exceptions.c: Update.
5056         * common/new-op.c: Update.
5057         * common/selftest.c: Update.
5058         * compile/compile-c-symbols.c: Update.
5059         * compile/compile-cplus-symbols.c: Update.
5060         * compile/compile-object-load.c: Update.
5061         * compile/compile-object-run.c: Update.
5062         * completer.c: Update.
5063         * corelow.c: Update.
5064         * cp-abi.c: Update.
5065         * cp-support.c: Update.
5066         * cp-valprint.c: Update.
5067         * darwin-nat.c: Update.
5068         * disasm-selftests.c: Update.
5069         * dtrace-probe.c: Update.
5070         * dwarf-index-cache.c: Update.
5071         * dwarf-index-write.c: Update.
5072         * dwarf2-frame-tailcall.c: Update.
5073         * dwarf2-frame.c: Update.
5074         * dwarf2loc.c: Update.
5075         * dwarf2read.c: Update.
5076         * eval.c: Update.
5077         * event-loop.c: Update.
5078         * event-top.c: Update.
5079         * exec.c: Update.
5080         * f-valprint.c: Update.
5081         * fbsd-tdep.c: Update.
5082         * frame-unwind.c: Update.
5083         * frame.c: Update.
5084         * gdbtypes.c: Update.
5085         * gnu-v3-abi.c: Update.
5086         * guile/guile-internal.h: Update.
5087         * guile/scm-block.c: Update.
5088         * guile/scm-breakpoint.c: Update.
5089         * guile/scm-cmd.c: Update.
5090         * guile/scm-disasm.c: Update.
5091         * guile/scm-frame.c: Update.
5092         * guile/scm-lazy-string.c: Update.
5093         * guile/scm-math.c: Update.
5094         * guile/scm-param.c: Update.
5095         * guile/scm-ports.c: Update.
5096         * guile/scm-pretty-print.c: Update.
5097         * guile/scm-symbol.c: Update.
5098         * guile/scm-symtab.c: Update.
5099         * guile/scm-type.c: Update.
5100         * guile/scm-value.c: Update.
5101         * i386-linux-tdep.c: Update.
5102         * i386-tdep.c: Update.
5103         * inf-loop.c: Update.
5104         * infcall.c: Update.
5105         * infcmd.c: Update.
5106         * infrun.c: Update.
5107         * jit.c: Update.
5108         * language.c: Update.
5109         * linespec.c: Update.
5110         * linux-fork.c: Update.
5111         * linux-nat.c: Update.
5112         * linux-tdep.c: Update.
5113         * linux-thread-db.c: Update.
5114         * main.c: Update.
5115         * mi/mi-cmd-break.c: Update.
5116         * mi/mi-cmd-stack.c: Update.
5117         * mi/mi-interp.c: Update.
5118         * mi/mi-main.c: Update.
5119         * objc-lang.c: Update.
5120         * p-valprint.c: Update.
5121         * parse.c: Update.
5122         * ppc-linux-tdep.c: Update.
5123         * printcmd.c: Update.
5124         * python/py-arch.c: Update.
5125         * python/py-breakpoint.c: Update.
5126         * python/py-cmd.c: Update.
5127         * python/py-finishbreakpoint.c: Update.
5128         * python/py-frame.c: Update.
5129         * python/py-framefilter.c: Update.
5130         * python/py-gdb-readline.c: Update.
5131         * python/py-inferior.c: Update.
5132         * python/py-infthread.c: Update.
5133         * python/py-lazy-string.c: Update.
5134         * python/py-linetable.c: Update.
5135         * python/py-objfile.c: Update.
5136         * python/py-param.c: Update.
5137         * python/py-prettyprint.c: Update.
5138         * python/py-progspace.c: Update.
5139         * python/py-record-btrace.c: Update.
5140         * python/py-record.c: Update.
5141         * python/py-symbol.c: Update.
5142         * python/py-type.c: Update.
5143         * python/py-unwind.c: Update.
5144         * python/py-utils.c: Update.
5145         * python/py-value.c: Update.
5146         * python/python.c: Update.
5147         * record-btrace.c: Update.
5148         * record-full.c: Update.
5149         * remote-fileio.c: Update.
5150         * remote.c: Update.
5151         * riscv-tdep.c: Update.
5152         * rs6000-aix-tdep.c: Update.
5153         * rs6000-tdep.c: Update.
5154         * rust-exp.y: Update.
5155         * rust-lang.c: Update.
5156         * s390-tdep.c: Update.
5157         * selftest-arch.c: Update.
5158         * solib-dsbt.c: Update.
5159         * solib-frv.c: Update.
5160         * solib-spu.c: Update.
5161         * solib-svr4.c: Update.
5162         * solib.c: Update.
5163         * sparc64-linux-tdep.c: Update.
5164         * stack.c: Update.
5165         * symfile-mem.c: Update.
5166         * symmisc.c: Update.
5167         * target.c: Update.
5168         * thread.c: Update.
5169         * top.c: Update.
5170         * tracefile-tfile.c: Update.
5171         * tui/tui.c: Update.
5172         * typeprint.c: Update.
5173         * unittests/cli-utils-selftests.c: Update.
5174         * unittests/parse-connection-spec-selftests.c: Update.
5175         * valops.c: Update.
5176         * valprint.c: Update.
5177         * value.c: Update.
5178         * varobj.c: Update.
5179         * windows-nat.c: Update.
5180         * x86-linux-nat.c: Update.
5181         * xml-support.c: Update.
5182
5183 2019-04-08  Tom Tromey  <tom@tromey.com>
5184
5185         * xml-support.c: Use C++ exception handling.
5186         * x86-linux-nat.c: Use C++ exception handling.
5187         * windows-nat.c: Use C++ exception handling.
5188         * varobj.c: Use C++ exception handling.
5189         * value.c: Use C++ exception handling.
5190         * valprint.c: Use C++ exception handling.
5191         * valops.c: Use C++ exception handling.
5192         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5193         handling.
5194         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5195         * typeprint.c: Use C++ exception handling.
5196         * tui/tui.c: Use C++ exception handling.
5197         * tracefile-tfile.c: Use C++ exception handling.
5198         * top.c: Use C++ exception handling.
5199         * thread.c: Use C++ exception handling.
5200         * target.c: Use C++ exception handling.
5201         * symmisc.c: Use C++ exception handling.
5202         * symfile-mem.c: Use C++ exception handling.
5203         * stack.c: Use C++ exception handling.
5204         * sparc64-linux-tdep.c: Use C++ exception handling.
5205         * solib.c: Use C++ exception handling.
5206         * solib-svr4.c: Use C++ exception handling.
5207         * solib-spu.c: Use C++ exception handling.
5208         * solib-frv.c: Use C++ exception handling.
5209         * solib-dsbt.c: Use C++ exception handling.
5210         * selftest-arch.c: Use C++ exception handling.
5211         * s390-tdep.c: Use C++ exception handling.
5212         * rust-lang.c: Use C++ exception handling.
5213         * rust-exp.y: Use C++ exception handling.
5214         * rs6000-tdep.c: Use C++ exception handling.
5215         * rs6000-aix-tdep.c: Use C++ exception handling.
5216         * riscv-tdep.c: Use C++ exception handling.
5217         * remote.c: Use C++ exception handling.
5218         * remote-fileio.c: Use C++ exception handling.
5219         * record-full.c: Use C++ exception handling.
5220         * record-btrace.c: Use C++ exception handling.
5221         * python/python.c: Use C++ exception handling.
5222         * python/py-value.c: Use C++ exception handling.
5223         * python/py-utils.c: Use C++ exception handling.
5224         * python/py-unwind.c: Use C++ exception handling.
5225         * python/py-type.c: Use C++ exception handling.
5226         * python/py-symbol.c: Use C++ exception handling.
5227         * python/py-record.c: Use C++ exception handling.
5228         * python/py-record-btrace.c: Use C++ exception handling.
5229         * python/py-progspace.c: Use C++ exception handling.
5230         * python/py-prettyprint.c: Use C++ exception handling.
5231         * python/py-param.c: Use C++ exception handling.
5232         * python/py-objfile.c: Use C++ exception handling.
5233         * python/py-linetable.c: Use C++ exception handling.
5234         * python/py-lazy-string.c: Use C++ exception handling.
5235         * python/py-infthread.c: Use C++ exception handling.
5236         * python/py-inferior.c: Use C++ exception handling.
5237         * python/py-gdb-readline.c: Use C++ exception handling.
5238         * python/py-framefilter.c: Use C++ exception handling.
5239         * python/py-frame.c: Use C++ exception handling.
5240         * python/py-finishbreakpoint.c: Use C++ exception handling.
5241         * python/py-cmd.c: Use C++ exception handling.
5242         * python/py-breakpoint.c: Use C++ exception handling.
5243         * python/py-arch.c: Use C++ exception handling.
5244         * printcmd.c: Use C++ exception handling.
5245         * ppc-linux-tdep.c: Use C++ exception handling.
5246         * parse.c: Use C++ exception handling.
5247         * p-valprint.c: Use C++ exception handling.
5248         * objc-lang.c: Use C++ exception handling.
5249         * mi/mi-main.c: Use C++ exception handling.
5250         * mi/mi-interp.c: Use C++ exception handling.
5251         * mi/mi-cmd-stack.c: Use C++ exception handling.
5252         * mi/mi-cmd-break.c: Use C++ exception handling.
5253         * main.c: Use C++ exception handling.
5254         * linux-thread-db.c: Use C++ exception handling.
5255         * linux-tdep.c: Use C++ exception handling.
5256         * linux-nat.c: Use C++ exception handling.
5257         * linux-fork.c: Use C++ exception handling.
5258         * linespec.c: Use C++ exception handling.
5259         * language.c: Use C++ exception handling.
5260         * jit.c: Use C++ exception handling.
5261         * infrun.c: Use C++ exception handling.
5262         * infcmd.c: Use C++ exception handling.
5263         * infcall.c: Use C++ exception handling.
5264         * inf-loop.c: Use C++ exception handling.
5265         * i386-tdep.c: Use C++ exception handling.
5266         * i386-linux-tdep.c: Use C++ exception handling.
5267         * guile/scm-value.c: Use C++ exception handling.
5268         * guile/scm-type.c: Use C++ exception handling.
5269         * guile/scm-symtab.c: Use C++ exception handling.
5270         * guile/scm-symbol.c: Use C++ exception handling.
5271         * guile/scm-pretty-print.c: Use C++ exception handling.
5272         * guile/scm-ports.c: Use C++ exception handling.
5273         * guile/scm-param.c: Use C++ exception handling.
5274         * guile/scm-math.c: Use C++ exception handling.
5275         * guile/scm-lazy-string.c: Use C++ exception handling.
5276         * guile/scm-frame.c: Use C++ exception handling.
5277         * guile/scm-disasm.c: Use C++ exception handling.
5278         * guile/scm-cmd.c: Use C++ exception handling.
5279         * guile/scm-breakpoint.c: Use C++ exception handling.
5280         * guile/scm-block.c: Use C++ exception handling.
5281         * guile/guile-internal.h: Use C++ exception handling.
5282         * gnu-v3-abi.c: Use C++ exception handling.
5283         * gdbtypes.c: Use C++ exception handling.
5284         * frame.c: Use C++ exception handling.
5285         * frame-unwind.c: Use C++ exception handling.
5286         * fbsd-tdep.c: Use C++ exception handling.
5287         * f-valprint.c: Use C++ exception handling.
5288         * exec.c: Use C++ exception handling.
5289         * event-top.c: Use C++ exception handling.
5290         * event-loop.c: Use C++ exception handling.
5291         * eval.c: Use C++ exception handling.
5292         * dwarf2read.c: Use C++ exception handling.
5293         * dwarf2loc.c: Use C++ exception handling.
5294         * dwarf2-frame.c: Use C++ exception handling.
5295         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5296         * dwarf-index-write.c: Use C++ exception handling.
5297         * dwarf-index-cache.c: Use C++ exception handling.
5298         * dtrace-probe.c: Use C++ exception handling.
5299         * disasm-selftests.c: Use C++ exception handling.
5300         * darwin-nat.c: Use C++ exception handling.
5301         * cp-valprint.c: Use C++ exception handling.
5302         * cp-support.c: Use C++ exception handling.
5303         * cp-abi.c: Use C++ exception handling.
5304         * corelow.c: Use C++ exception handling.
5305         * completer.c: Use C++ exception handling.
5306         * compile/compile-object-run.c: Use C++ exception handling.
5307         * compile/compile-object-load.c: Use C++ exception handling.
5308         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5309         * compile/compile-c-symbols.c: Use C++ exception handling.
5310         * common/selftest.c: Use C++ exception handling.
5311         * common/new-op.c: Use C++ exception handling.
5312         * cli/cli-script.c: Use C++ exception handling.
5313         * cli/cli-interp.c: Use C++ exception handling.
5314         * cli/cli-cmds.c: Use C++ exception handling.
5315         * c-varobj.c: Use C++ exception handling.
5316         * btrace.c: Use C++ exception handling.
5317         * breakpoint.c: Use C++ exception handling.
5318         * break-catch-throw.c: Use C++ exception handling.
5319         * arch-utils.c: Use C++ exception handling.
5320         * amd64-tdep.c: Use C++ exception handling.
5321         * ada-valprint.c: Use C++ exception handling.
5322         * ada-typeprint.c: Use C++ exception handling.
5323         * ada-lang.c: Use C++ exception handling.
5324         * aarch64-tdep.c: Use C++ exception handling.
5325
5326 2019-04-08  Tom Tromey  <tom@tromey.com>
5327
5328         * xml-support.c (gdb_xml_parser::parse): Update.
5329         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5330         * value.c (show_convenience): Update.
5331         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5332         (test_parse_flags_qcs): Update.
5333         * thread.c (thr_try_catch_cmd): Update.
5334         * target.c (target_translate_tls_address): Update.
5335         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5336         (info_frame_command_core, frame_apply_command_count): Update.
5337         * rust-exp.y (rust_lex_exception_test): Update.
5338         * riscv-tdep.c (riscv_print_one_register_info): Update.
5339         * remote.c (remote_target::enable_btrace): Update.
5340         * record-btrace.c (record_btrace_enable_warn): Update.
5341         * python/py-utils.c (gdbpy_convert_exception): Update.
5342         * printcmd.c (do_one_display, print_variable_and_value): Update.
5343         * mi/mi-main.c (mi_print_exception): Update.
5344         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5345         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5346         * linux-nat.c (linux_nat_target::attach): Update.
5347         * linux-fork.c (class scoped_switch_fork_info): Update.
5348         * infrun.c (displaced_step_prepare): Update.
5349         * infcall.c (call_function_by_hand_dummy): Update.
5350         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5351         * gnu-v3-abi.c (print_one_vtable): Update.
5352         * frame.c (get_prev_frame_always): Update.
5353         * f-valprint.c (info_common_command_for_block): Update.
5354         * exec.c (try_open_exec_file): Update.
5355         * exceptions.c (print_exception, exception_print)
5356         (exception_fprintf, exception_print_same): Update.
5357         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5358         * dwarf-index-cache.c (index_cache::store)
5359         (index_cache::lookup_gdb_index): Update.
5360         * darwin-nat.c (maybe_cache_shell): Update.
5361         * cp-valprint.c (cp_print_value_fields): Update.
5362         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5363         (gcc_cplus_symbol_address): Update.
5364         * compile/compile-c-symbols.c (gcc_convert_symbol)
5365         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5366         * common/selftest.c: Update.
5367         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5368         a std::string.
5369         (exception_try_scope_entry, exception_try_scope_exit): Don't
5370         declare.
5371         (struct exception_try_scope): Remove.
5372         (TRY): Don't use exception_try_scope.
5373         (struct gdb_exception): Add constructor, operator=.
5374         <what>: New method.
5375         (struct gdb_exception_RETURN_MASK_ALL)
5376         (struct gdb_exception_RETURN_MASK_ERROR)
5377         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5378         (struct gdb_quit_bad_alloc): Update.
5379         * common/common-exceptions.c (exception_none): Change
5380         initializer.
5381         (struct catcher) <state, exception>: Initialize inline.
5382         <prev>: Remove member.
5383         (current_catcher): Remove.
5384         (catchers): New global.
5385         (exceptions_state_mc_init): Simplify.
5386         (catcher_pop): Remove.
5387         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5388         (try_scope_depth, exception_try_scope_entry)
5389         (exception_try_scope_exit): Remove.
5390         (throw_exception_sjlj): Update.
5391         (exception_messages, exception_messages_size): Remove.
5392         (throw_it): Simplify.
5393         (gdb_exception_sliced_copy): Remove.
5394         (throw_exception_cxx): Update.
5395         * cli/cli-script.c (script_from_file): Update.
5396         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5397         Update.
5398         * ada-valprint.c (ada_val_print): Update.
5399         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5400         (create_excep_cond_exprs): Update.
5401
5402 2019-04-08  Tom Tromey  <tom@tromey.com>
5403
5404         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5405         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5406         (TRY, CATCH, END_CATCH): Remove some definitions.
5407         * common/common-exceptions.c: Don't use GDB_XCPT.
5408         (catcher_list_size): Remove.
5409         (throw_exception, throw_it): Simplify.
5410
5411 2019-04-05  Tom Tromey  <tom@tromey.com>
5412
5413         Revert the header-sorting patch.
5414         * ft32-tdep.c: Revert.
5415         * frv-tdep.c: Revert.
5416         * frv-linux-tdep.c: Revert.
5417         * frame.c: Revert.
5418         * frame-unwind.c: Revert.
5419         * frame-base.c: Revert.
5420         * fork-child.c: Revert.
5421         * findvar.c: Revert.
5422         * findcmd.c: Revert.
5423         * filesystem.c: Revert.
5424         * filename-seen-cache.h: Revert.
5425         * filename-seen-cache.c: Revert.
5426         * fbsd-tdep.c: Revert.
5427         * fbsd-nat.h: Revert.
5428         * fbsd-nat.c: Revert.
5429         * f-valprint.c: Revert.
5430         * f-typeprint.c: Revert.
5431         * f-lang.c: Revert.
5432         * extension.h: Revert.
5433         * extension.c: Revert.
5434         * extension-priv.h: Revert.
5435         * expprint.c: Revert.
5436         * exec.h: Revert.
5437         * exec.c: Revert.
5438         * exceptions.c: Revert.
5439         * event-top.c: Revert.
5440         * event-loop.c: Revert.
5441         * eval.c: Revert.
5442         * elfread.c: Revert.
5443         * dwarf2read.h: Revert.
5444         * dwarf2read.c: Revert.
5445         * dwarf2loc.c: Revert.
5446         * dwarf2expr.h: Revert.
5447         * dwarf2expr.c: Revert.
5448         * dwarf2-frame.c: Revert.
5449         * dwarf2-frame-tailcall.c: Revert.
5450         * dwarf-index-write.h: Revert.
5451         * dwarf-index-write.c: Revert.
5452         * dwarf-index-common.c: Revert.
5453         * dwarf-index-cache.h: Revert.
5454         * dwarf-index-cache.c: Revert.
5455         * dummy-frame.c: Revert.
5456         * dtrace-probe.c: Revert.
5457         * disasm.h: Revert.
5458         * disasm.c: Revert.
5459         * disasm-selftests.c: Revert.
5460         * dictionary.c: Revert.
5461         * dicos-tdep.c: Revert.
5462         * demangle.c: Revert.
5463         * dcache.h: Revert.
5464         * dcache.c: Revert.
5465         * darwin-nat.h: Revert.
5466         * darwin-nat.c: Revert.
5467         * darwin-nat-info.c: Revert.
5468         * d-valprint.c: Revert.
5469         * d-namespace.c: Revert.
5470         * d-lang.c: Revert.
5471         * ctf.c: Revert.
5472         * csky-tdep.c: Revert.
5473         * csky-linux-tdep.c: Revert.
5474         * cris-tdep.c: Revert.
5475         * cris-linux-tdep.c: Revert.
5476         * cp-valprint.c: Revert.
5477         * cp-support.c: Revert.
5478         * cp-namespace.c: Revert.
5479         * cp-abi.c: Revert.
5480         * corelow.c: Revert.
5481         * corefile.c: Revert.
5482         * continuations.c: Revert.
5483         * completer.h: Revert.
5484         * completer.c: Revert.
5485         * complaints.c: Revert.
5486         * coffread.c: Revert.
5487         * coff-pe-read.c: Revert.
5488         * cli-out.h: Revert.
5489         * cli-out.c: Revert.
5490         * charset.c: Revert.
5491         * c-varobj.c: Revert.
5492         * c-valprint.c: Revert.
5493         * c-typeprint.c: Revert.
5494         * c-lang.c: Revert.
5495         * buildsym.c: Revert.
5496         * buildsym-legacy.c: Revert.
5497         * build-id.h: Revert.
5498         * build-id.c: Revert.
5499         * btrace.c: Revert.
5500         * bsd-uthread.c: Revert.
5501         * breakpoint.h: Revert.
5502         * breakpoint.c: Revert.
5503         * break-catch-throw.c: Revert.
5504         * break-catch-syscall.c: Revert.
5505         * break-catch-sig.c: Revert.
5506         * blockframe.c: Revert.
5507         * block.c: Revert.
5508         * bfin-tdep.c: Revert.
5509         * bfin-linux-tdep.c: Revert.
5510         * bfd-target.c: Revert.
5511         * bcache.c: Revert.
5512         * ax-general.c: Revert.
5513         * ax-gdb.h: Revert.
5514         * ax-gdb.c: Revert.
5515         * avr-tdep.c: Revert.
5516         * auxv.c: Revert.
5517         * auto-load.c: Revert.
5518         * arm-wince-tdep.c: Revert.
5519         * arm-tdep.c: Revert.
5520         * arm-symbian-tdep.c: Revert.
5521         * arm-pikeos-tdep.c: Revert.
5522         * arm-obsd-tdep.c: Revert.
5523         * arm-nbsd-tdep.c: Revert.
5524         * arm-nbsd-nat.c: Revert.
5525         * arm-linux-tdep.c: Revert.
5526         * arm-linux-nat.c: Revert.
5527         * arm-fbsd-tdep.c: Revert.
5528         * arm-fbsd-nat.c: Revert.
5529         * arm-bsd-tdep.c: Revert.
5530         * arch-utils.c: Revert.
5531         * arc-tdep.c: Revert.
5532         * arc-newlib-tdep.c: Revert.
5533         * annotate.h: Revert.
5534         * annotate.c: Revert.
5535         * amd64-windows-tdep.c: Revert.
5536         * amd64-windows-nat.c: Revert.
5537         * amd64-tdep.c: Revert.
5538         * amd64-sol2-tdep.c: Revert.
5539         * amd64-obsd-tdep.c: Revert.
5540         * amd64-obsd-nat.c: Revert.
5541         * amd64-nbsd-tdep.c: Revert.
5542         * amd64-nbsd-nat.c: Revert.
5543         * amd64-nat.c: Revert.
5544         * amd64-linux-tdep.c: Revert.
5545         * amd64-linux-nat.c: Revert.
5546         * amd64-fbsd-tdep.c: Revert.
5547         * amd64-fbsd-nat.c: Revert.
5548         * amd64-dicos-tdep.c: Revert.
5549         * amd64-darwin-tdep.c: Revert.
5550         * amd64-bsd-nat.c: Revert.
5551         * alpha-tdep.c: Revert.
5552         * alpha-obsd-tdep.c: Revert.
5553         * alpha-nbsd-tdep.c: Revert.
5554         * alpha-mdebug-tdep.c: Revert.
5555         * alpha-linux-tdep.c: Revert.
5556         * alpha-linux-nat.c: Revert.
5557         * alpha-bsd-tdep.c: Revert.
5558         * alpha-bsd-nat.c: Revert.
5559         * aix-thread.c: Revert.
5560         * agent.c: Revert.
5561         * addrmap.c: Revert.
5562         * ada-varobj.c: Revert.
5563         * ada-valprint.c: Revert.
5564         * ada-typeprint.c: Revert.
5565         * ada-tasks.c: Revert.
5566         * ada-lang.c: Revert.
5567         * aarch64-tdep.c: Revert.
5568         * aarch64-ravenscar-thread.c: Revert.
5569         * aarch64-newlib-tdep.c: Revert.
5570         * aarch64-linux-tdep.c: Revert.
5571         * aarch64-linux-nat.c: Revert.
5572         * aarch64-fbsd-tdep.c: Revert.
5573         * aarch64-fbsd-nat.c: Revert.
5574         * aarch32-linux-nat.c: Revert.
5575
5576 2019-04-05  Tom Tromey  <tom@tromey.com>
5577
5578         * ft32-tdep.c: Sort headers.
5579         * frv-tdep.c: Sort headers.
5580         * frv-linux-tdep.c: Sort headers.
5581         * frame.c: Sort headers.
5582         * frame-unwind.c: Sort headers.
5583         * frame-base.c: Sort headers.
5584         * fork-child.c: Sort headers.
5585         * findvar.c: Sort headers.
5586         * findcmd.c: Sort headers.
5587         * filesystem.c: Sort headers.
5588         * filename-seen-cache.h: Sort headers.
5589         * filename-seen-cache.c: Sort headers.
5590         * fbsd-tdep.c: Sort headers.
5591         * fbsd-nat.h: Sort headers.
5592         * fbsd-nat.c: Sort headers.
5593         * f-valprint.c: Sort headers.
5594         * f-typeprint.c: Sort headers.
5595         * f-lang.c: Sort headers.
5596         * extension.h: Sort headers.
5597         * extension.c: Sort headers.
5598         * extension-priv.h: Sort headers.
5599         * expprint.c: Sort headers.
5600         * exec.h: Sort headers.
5601         * exec.c: Sort headers.
5602         * exceptions.c: Sort headers.
5603         * event-top.c: Sort headers.
5604         * event-loop.c: Sort headers.
5605         * eval.c: Sort headers.
5606         * elfread.c: Sort headers.
5607         * dwarf2read.h: Sort headers.
5608         * dwarf2read.c: Sort headers.
5609         * dwarf2loc.c: Sort headers.
5610         * dwarf2expr.h: Sort headers.
5611         * dwarf2expr.c: Sort headers.
5612         * dwarf2-frame.c: Sort headers.
5613         * dwarf2-frame-tailcall.c: Sort headers.
5614         * dwarf-index-write.h: Sort headers.
5615         * dwarf-index-write.c: Sort headers.
5616         * dwarf-index-common.c: Sort headers.
5617         * dwarf-index-cache.h: Sort headers.
5618         * dwarf-index-cache.c: Sort headers.
5619         * dummy-frame.c: Sort headers.
5620         * dtrace-probe.c: Sort headers.
5621         * disasm.h: Sort headers.
5622         * disasm.c: Sort headers.
5623         * disasm-selftests.c: Sort headers.
5624         * dictionary.c: Sort headers.
5625         * dicos-tdep.c: Sort headers.
5626         * demangle.c: Sort headers.
5627         * dcache.h: Sort headers.
5628         * dcache.c: Sort headers.
5629         * darwin-nat.h: Sort headers.
5630         * darwin-nat.c: Sort headers.
5631         * darwin-nat-info.c: Sort headers.
5632         * d-valprint.c: Sort headers.
5633         * d-namespace.c: Sort headers.
5634         * d-lang.c: Sort headers.
5635         * ctf.c: Sort headers.
5636         * csky-tdep.c: Sort headers.
5637         * csky-linux-tdep.c: Sort headers.
5638         * cris-tdep.c: Sort headers.
5639         * cris-linux-tdep.c: Sort headers.
5640         * cp-valprint.c: Sort headers.
5641         * cp-support.c: Sort headers.
5642         * cp-namespace.c: Sort headers.
5643         * cp-abi.c: Sort headers.
5644         * corelow.c: Sort headers.
5645         * corefile.c: Sort headers.
5646         * continuations.c: Sort headers.
5647         * completer.h: Sort headers.
5648         * completer.c: Sort headers.
5649         * complaints.c: Sort headers.
5650         * coffread.c: Sort headers.
5651         * coff-pe-read.c: Sort headers.
5652         * cli-out.h: Sort headers.
5653         * cli-out.c: Sort headers.
5654         * charset.c: Sort headers.
5655         * c-varobj.c: Sort headers.
5656         * c-valprint.c: Sort headers.
5657         * c-typeprint.c: Sort headers.
5658         * c-lang.c: Sort headers.
5659         * buildsym.c: Sort headers.
5660         * buildsym-legacy.c: Sort headers.
5661         * build-id.h: Sort headers.
5662         * build-id.c: Sort headers.
5663         * btrace.c: Sort headers.
5664         * bsd-uthread.c: Sort headers.
5665         * breakpoint.h: Sort headers.
5666         * breakpoint.c: Sort headers.
5667         * break-catch-throw.c: Sort headers.
5668         * break-catch-syscall.c: Sort headers.
5669         * break-catch-sig.c: Sort headers.
5670         * blockframe.c: Sort headers.
5671         * block.c: Sort headers.
5672         * bfin-tdep.c: Sort headers.
5673         * bfin-linux-tdep.c: Sort headers.
5674         * bfd-target.c: Sort headers.
5675         * bcache.c: Sort headers.
5676         * ax-general.c: Sort headers.
5677         * ax-gdb.h: Sort headers.
5678         * ax-gdb.c: Sort headers.
5679         * avr-tdep.c: Sort headers.
5680         * auxv.c: Sort headers.
5681         * auto-load.c: Sort headers.
5682         * arm-wince-tdep.c: Sort headers.
5683         * arm-tdep.c: Sort headers.
5684         * arm-symbian-tdep.c: Sort headers.
5685         * arm-pikeos-tdep.c: Sort headers.
5686         * arm-obsd-tdep.c: Sort headers.
5687         * arm-nbsd-tdep.c: Sort headers.
5688         * arm-nbsd-nat.c: Sort headers.
5689         * arm-linux-tdep.c: Sort headers.
5690         * arm-linux-nat.c: Sort headers.
5691         * arm-fbsd-tdep.c: Sort headers.
5692         * arm-fbsd-nat.c: Sort headers.
5693         * arm-bsd-tdep.c: Sort headers.
5694         * arch-utils.c: Sort headers.
5695         * arc-tdep.c: Sort headers.
5696         * arc-newlib-tdep.c: Sort headers.
5697         * annotate.h: Sort headers.
5698         * annotate.c: Sort headers.
5699         * amd64-windows-tdep.c: Sort headers.
5700         * amd64-windows-nat.c: Sort headers.
5701         * amd64-tdep.c: Sort headers.
5702         * amd64-sol2-tdep.c: Sort headers.
5703         * amd64-obsd-tdep.c: Sort headers.
5704         * amd64-obsd-nat.c: Sort headers.
5705         * amd64-nbsd-tdep.c: Sort headers.
5706         * amd64-nbsd-nat.c: Sort headers.
5707         * amd64-nat.c: Sort headers.
5708         * amd64-linux-tdep.c: Sort headers.
5709         * amd64-linux-nat.c: Sort headers.
5710         * amd64-fbsd-tdep.c: Sort headers.
5711         * amd64-fbsd-nat.c: Sort headers.
5712         * amd64-dicos-tdep.c: Sort headers.
5713         * amd64-darwin-tdep.c: Sort headers.
5714         * amd64-bsd-nat.c: Sort headers.
5715         * alpha-tdep.c: Sort headers.
5716         * alpha-obsd-tdep.c: Sort headers.
5717         * alpha-nbsd-tdep.c: Sort headers.
5718         * alpha-mdebug-tdep.c: Sort headers.
5719         * alpha-linux-tdep.c: Sort headers.
5720         * alpha-linux-nat.c: Sort headers.
5721         * alpha-bsd-tdep.c: Sort headers.
5722         * alpha-bsd-nat.c: Sort headers.
5723         * aix-thread.c: Sort headers.
5724         * agent.c: Sort headers.
5725         * addrmap.c: Sort headers.
5726         * ada-varobj.c: Sort headers.
5727         * ada-valprint.c: Sort headers.
5728         * ada-typeprint.c: Sort headers.
5729         * ada-tasks.c: Sort headers.
5730         * ada-lang.c: Sort headers.
5731         * aarch64-tdep.c: Sort headers.
5732         * aarch64-ravenscar-thread.c: Sort headers.
5733         * aarch64-newlib-tdep.c: Sort headers.
5734         * aarch64-linux-tdep.c: Sort headers.
5735         * aarch64-linux-nat.c: Sort headers.
5736         * aarch64-fbsd-tdep.c: Sort headers.
5737         * aarch64-fbsd-nat.c: Sort headers.
5738         * aarch32-linux-nat.c: Sort headers.
5739
5740 2019-04-04  Tom Tromey  <tom@tromey.com>
5741
5742         * varobj.c (varobj_create): Update.
5743         * rust-exp.y (struct rust_parser) <update_innermost_block,
5744         lookup_symbol>: New methods.
5745         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5746         Rename.
5747         (rust_parser::rust_lookup_type)
5748         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5749         * printcmd.c (display_command, do_one_display): Update.
5750         * parser-defs.h (struct parser_state) <parser_state>: Add
5751         "tracker" parameter.
5752         (block_tracker): New member.
5753         (class innermost_block_tracker) <innermost_block_tracker>: Add
5754         "types" parameter.
5755         <reset>: Remove method.
5756         (innermost_block): Don't declare.
5757         (null_post_parser): Update.
5758         * parse.c (innermost_block): Remove global.
5759         (write_dollar_variable): Update.
5760         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5761         Remove "tracker_types" parameter.
5762         (parse_expression): Add "tracker" parameter.
5763         (parse_expression_for_completion): Update.
5764         (null_post_parser): Add "tracker" parameter.
5765         * p-exp.y: Update rules.
5766         * m2-exp.y: Update rules.
5767         * language.h (struct language_defn) <la_post_parser>: Add
5768         "tracker" parameter.
5769         * go-exp.y: Update rules.
5770         * f-exp.y: Update rules.
5771         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5772         parameter.
5773         * d-exp.y: Update rules.
5774         * c-exp.y: Update rules.
5775         * breakpoint.c (set_breakpoint_condition): Create an
5776         innermost_block_tracker.
5777         (watch_command_1): Likewise.
5778         * ada-lang.c (resolve): Add "tracker" parameter.
5779         (resolve_subexp): Likewise.
5780         * ada-exp.y (write_var_from_sym): Update.
5781
5782 2019-04-04  Tom Tromey  <tom@tromey.com>
5783
5784         * type-stack.h: New file.
5785         * type-stack.c: New file.
5786         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5787         type-stack.h.
5788         (insert_into_type_stack, insert_type, push_type, push_type_int)
5789         (insert_type_address_space, pop_type, pop_type_int)
5790         (pop_typelist, pop_type_stack, append_type_stack)
5791         (push_type_stack, get_type_stack, push_typelist)
5792         (follow_type_instance_flags, follow_types): Don't declare.
5793         * parse.c (type_stack): Remove global.
5794         (parse_exp_in_context): Update.
5795         (insert_into_type_stack, insert_type, push_type, push_type_int)
5796         (insert_type_address_space, pop_type, pop_type_int)
5797         (pop_typelist, pop_type_stack, append_type_stack)
5798         (push_type_stack, get_type_stack, push_typelist)
5799         (follow_type_instance_flags, follow_types): Remove (moved to
5800         type-stack.c).
5801         * f-exp.y (type_stack): New global.
5802         Update rules.
5803         (push_kind_type, f_parse): Update.
5804         * d-exp.y (type_stack): New global.
5805         Update rules.
5806         (d_parse): Update.
5807         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5808         Update rules.
5809         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5810         (HFILES_NO_SRCDIR): Add type-stack.h.
5811
5812 2019-04-04  Tom Tromey  <tom@tromey.com>
5813
5814         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5815         (rust_parser::convert_ast_to_expression, rust_parse)
5816         (rust_lex_test_completion, rust_lex_tests): Update.
5817         * parser-defs.h (struct expr_completion_state): New.
5818         (struct parser_state) <parser_state>: Add completion parameter.
5819         <mark_struct_expression, mark_completion_tag>: New methods.
5820         <parse_completion, m_completion_state>: New members.
5821         (prefixify_expression, null_post_parser): Update.
5822         (mark_struct_expression, mark_completion_tag): Don't declare.
5823         * parse.c (parse_completion, expout_last_struct)
5824         (expout_tag_completion_type, expout_completion_name): Remove
5825         globals.
5826         (parser_state::mark_struct_expression)
5827         (parser_state::mark_completion_tag): Now methods.
5828         (prefixify_expression): Add last_struct parameter.
5829         (prefixify_subexp): Likewise.
5830         (parse_exp_1): Update.
5831         (parse_exp_in_context): Add cstate parameter.  Update.
5832         (parse_expression_for_completion): Create an
5833         expr_completion_state.
5834         (null_post_parser): Add "completion" parameter.
5835         * p-exp.y: Update rules.
5836         (yylex): Update.
5837         * language.h (struct language_defn) <la_post_parser>: Add
5838         "completing" parameter.
5839         * go-exp.y: Update rules.
5840         (lex_one_token): Update.
5841         * expression.h (parse_completion): Don't declare.
5842         * d-exp.y: Update rules.
5843         (lex_one_token): Update rules.
5844         * c-exp.y: Update rules.
5845         (lex_one_token): Update.
5846         * ada-lang.c (resolve): Add "parse_completion" parameter.
5847         (resolve_subexp): Likewise.
5848         (ada_resolve_function): Likewise.
5849
5850 2019-04-04  Tom Tromey  <tom@tromey.com>
5851
5852         * parser-defs.h (struct parser_state) <start_arglist,
5853         end_arglist>: New methods.
5854         <arglist_len, m_funcall_chain>: New members.
5855         (arglist_len, start_arglist, end_arglist): Don't declare.
5856         * parse.c (arglist_len, funcall_chain): Remove global.
5857         (start_arglist, end_arglist): Remove functions.
5858         (parse_exp_in_context): Update.
5859         * p-exp.y: Update rules.
5860         * m2-exp.y: Update rules.
5861         * go-exp.y: Update rules.
5862         * f-exp.y: Update rules.
5863         * d-exp.y: Update rules.
5864         * c-exp.y: Update rules.
5865
5866 2019-04-04  Tom Tromey  <tom@tromey.com>
5867
5868         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5869         lex_operator, push_back>: New methods.
5870         Update all rules.
5871         (rust_parser::lex_hex, lex_escape): Rename and update.
5872         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5873         (rust_parser::lex_operator): Rename and update.
5874         (rust_parser::lex_number, rustyylex, rustyyerror)
5875         (rust_lex_test_init, rust_lex_test_sequence)
5876         (rust_lex_test_push_back, rust_lex_tests): Update.
5877         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5878         parameter.
5879         <lexptr, prev_lexptr>: New members.
5880         (lexptr, prev_lexptr): Don't declare.
5881         * parse.c (lexptr, prev_lexptr): Remove globals.
5882         (parse_exp_in_context): Update.
5883         * p-exp.y (yylex, yyerror): Update.
5884         * m2-exp.y (parse_number, yylex, yyerror): Update.
5885         * go-exp.y (lex_one_token, yyerror): Update.
5886         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5887         * d-exp.y (lex_one_token, yyerror): Update.
5888         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5889         (lex_one_token, yyerror): Update.
5890         * ada-lex.l (YY_INPUT): Update.
5891         (rewind_to_char): Update.
5892         * ada-exp.y (yyerror): Update.
5893
5894 2019-04-04  Tom Tromey  <tom@tromey.com>
5895
5896         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5897         * parser-defs.h (struct parser_state) <parser_state>: Add new
5898         parameter.
5899         <comma_terminates>: New member.
5900         (comma_terminates): Don't declare global.
5901         * parse.c (comma_terminates): Remove global.
5902         (parse_exp_in_context): Update.
5903         * p-exp.y (yylex): Update.
5904         * m2-exp.y (yylex): Update.
5905         * go-exp.y (lex_one_token): Update.
5906         * f-exp.y (yylex): Update.
5907         * d-exp.y (lex_one_token): Update.
5908         * c-exp.y (lex_one_token): Update.
5909         * ada-lex.l: Update.
5910
5911 2019-04-04  Tom Tromey  <tom@tromey.com>
5912
5913         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5914         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5915         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5916         * parser-defs.h (paren_depth): Don't declare.
5917         * parse.c (paren_depth): Remove global.
5918         (parse_exp_in_context): Update.
5919         * p-exp.y (paren_depth): New global.
5920         (pascal_parse): Initialize it.
5921         * m2-exp.y (paren_depth): New global.
5922         (m2_parse): Initialize it.
5923         * go-exp.y (paren_depth): New global.
5924         (go_parse): Initialize it.
5925         * f-exp.y (paren_depth): New global.
5926         (f_parse): Initialize it.
5927         * d-exp.y (paren_depth): New global.
5928         (d_parse): Initialize it.
5929         * c-exp.y (paren_depth): New global.
5930         (c_parse): Initialize it.
5931         * ada-lex.l (paren_depth): New global.
5932         (lexer_init): Initialize it.
5933
5934 2019-04-04  Tom Tromey  <tom@tromey.com>
5935
5936         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5937         (rust_parser::convert_ast_to_type)
5938         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5939         * parser-defs.h (struct parser_state) <parser_state>: Add
5940         parameters.  Initialize new members.
5941         <expression_context_block, expression_context_pc>: New members.
5942         * parse.c (expression_context_block, expression_context_pc):
5943         Remove globals.
5944         (parse_exp_in_context): Update.
5945         * p-exp.y: Update all rules.
5946         (yylex): Update.
5947         * m2-exp.y: Update all rules.
5948         (yylex): Update.
5949         * go-exp.y (yylex): Update.
5950         * f-exp.y (yylex): Update.
5951         * d-exp.y: Update all rules.
5952         (yylex): Update.
5953         * c-exp.y: Update all rules.
5954         (lex_one_token, classify_name, yylex, c_parse): Update.
5955         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5956
5957 2019-04-04  Tom Tromey  <tom@tromey.com>
5958
5959         * gdbarch.h, gdbarch.c: Rebuild.
5960         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5961         * stap-probe.h:
5962         (struct stap_parse_info): Replace "parser_state" with
5963         "expr_builder".
5964         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5965         (parser_state): New class.
5966         * parse.c (expr_builder): Rename.
5967         (expr_builder::release): Rename.
5968         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5969         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5970         (write_exp_elt_longcst, write_exp_elt_floatcst)
5971         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5972         (write_exp_string_vector, write_exp_bitstring)
5973         (write_exp_msymbol, mark_struct_expression)
5974         (write_dollar_variable)
5975         (insert_type_address_space, increase_expout_size): Replace
5976         "parser_state" with "expr_builder".
5977         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5978         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5979         "parser_state" with "expr_builder".
5980
5981 2019-04-04  Tom Tromey  <tom@tromey.com>
5982
5983         * rust-exp.y: Replace "parse_language" with method call.
5984         * p-exp.y:
5985         (yylex): Replace "parse_language" with method call.
5986         * m2-exp.y:
5987         (yylex): Replace "parse_language" with method call.
5988         * go-exp.y (classify_name): Replace "parse_language" with method
5989         call.
5990         * f-exp.y (yylex): Replace "parse_language" with method call.
5991         * d-exp.y (lex_one_token): Replace "parse_language" with method
5992         call.
5993         * c-exp.y:
5994         (lex_one_token, classify_name, yylex): Replace "parse_language"
5995         with method call.
5996         * ada-exp.y (find_primitive_type, type_char)
5997         (type_system_address): Replace "parse_language" with method call.
5998
5999 2019-04-04  Tom Tromey  <tom@tromey.com>
6000
6001         * rust-exp.y: Replace "parse_gdbarch" with method call.
6002         * parse.c (write_dollar_variable, insert_type_address_space):
6003         Replace "parse_gdbarch" with method call.
6004         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6005         call.
6006         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6007         call.
6008         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6009         "parse_gdbarch" with method call.
6010         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6011         with method call.
6012         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6013         "parse_gdbarch" with method call.
6014         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6015         "parse_gdbarch" with method call.
6016         * c-exp.y (parse_type, parse_number, classify_name): Replace
6017         "parse_gdbarch" with method call.
6018         * ada-lex.l: Replace "parse_gdbarch" with method call.
6019         * ada-exp.y (parse_type, find_primitive_type, type_char)
6020         (type_system_address): Replace "parse_gdbarch" with method call.
6021
6022 2019-04-04  Tom Tromey  <tom@tromey.com>
6023
6024         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6025         * stap-probe.c (stap_parse_argument): Update.
6026         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6027         initial_size parameter.
6028         * rust-exp.y (rust_lex_tests): Update.
6029         * parse.c (parser_state): Update.
6030         (parse_exp_in_context): Update.
6031         * parser-defs.h (struct parser_state) <parser_state>: Remove
6032         "initial_size" parameter.
6033
6034 2019-04-04  Tom Tromey  <tom@tromey.com>
6035
6036         * parser-defs.h (increase_expout_size): Don't declare.
6037         * parse.c (increase_expout_size): Now static.
6038
6039 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6040
6041         * gnu-nat.c (gnu_nat_target::wait): Fix
6042         target_waitstatus_to_string call.
6043
6044 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6045
6046         * eval.c (evaluate_subexp_standard): Handle internal functions
6047         during Fortran function call handling.
6048
6049 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6050
6051         * NEWS: Mention new internal functions.
6052         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6053         (read_base_type): Use dwarf2_init_complex_target_type.
6054         * value.c (creal_internal_fn): New function.
6055         (cimag_internal_fn): New function.
6056         (_initialize_values): Register new internal functions.
6057
6058 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6059
6060         * infrun.c (stop_all_threads): If debug_infrun, always
6061         trace the wait status after wait_one, using
6062         target_waitstatus_to_string and target_pid_to_str.
6063         (handle_inferior_event): Replace various trace of
6064         wait status kind by a single trace.
6065         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6066         wait status kind image by target_waitstatus_to_string.
6067         * target/waitstatus.c (target_waitstatus_to_string): Fix
6068         obsolete comment.
6069
6070 2019-04-01  Tom Tromey  <tromey@adacore.com>
6071
6072         PR symtab/23331:
6073         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6074
6075 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6076             Pedro Alves  <palves@redhat.com>
6077
6078         * top.c (quit_force): Call 'finalize_values'.
6079         * value.c (finalize_values): New function.
6080         * value.h (finalize_values): Declare.
6081
6082 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6083
6084         * NEWS: Announce $_gdb_major and $_gdb_minor.
6085
6086         * top.c (init_gdb_version_vars): New function.
6087         (gdb_init): Call init_gdb_version_vars.
6088
6089 2019-03-29  Tom Tromey  <tromey@adacore.com>
6090
6091         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6092         help text.  Remove dead code.
6093
6094 2019-03-29  Keith Seitz  <keiths@redhat.com>
6095
6096         From Siddhesh Poyarekar:
6097         * f-lang.h (f77_get_upperbound): Return LONGEST.
6098         (f77_get_lowerbound): Likewise.
6099         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6100         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6101         print them.
6102         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6103         plongest to format print it.
6104         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6105         (f77_get_upperbound): Likewise.
6106         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6107         LOWER_BOUND to LONGEST.
6108         (f77_create_arrayprint_offset_tbl): Likewise.
6109
6110 2019-03-29  Keith Seitz  <keiths@redhat.com>
6111
6112         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6113         %s/pulongest for TYPE_LENGTH instead of %d in format
6114         strings.
6115         * ada-typerint.c (ada_print_type): Likewise.
6116         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6117         * compile/compile-c-support.c (generate_register_struct): Likewise.
6118         * gdbtypes.c (recursive_dump_type): Likewise.
6119         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6120         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6121         instead of %d in format strings.
6122         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6123         to std::min to ULONGEST.
6124         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6125         instead of %d in format strings.
6126         * tracepoint.c (info_scope_command): Likewise.
6127         * typeprint.c (print_offset_data::update)
6128         (print_offset_data::finish): Likewise.
6129         * xtensa-tdep.c (xtensa_store_return_value)
6130         (xtensa_push_dummy_call): Likewise.
6131
6132 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6133
6134         * windows-nat.c (display_selector): Fixed format specifications
6135         for 64-bit Cygwin.
6136
6137 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6138
6139         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6140
6141 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6142
6143         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6144         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6145         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6146         (nios2_linux_init_abi): Install it.
6147
6148 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6149
6150         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6151
6152 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6153
6154         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6155
6156 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6157             Tom Tromey  <tromey@adacore.com>
6158
6159         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6160
6161 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6162
6163         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6164         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6165         method to compute the bounds of range types. Also print "[evaluated]"
6166         if the bounds' values come from a dynamic evaluation.
6167
6168 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6169
6170         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6171         whitespace when pretty printing is on.
6172
6173 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6174
6175         * ppc-linux-nat.c: Add include.
6176
6177 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6178
6179         * NEWS: Mention AArch64 Pointer Authentication.
6180
6181 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6182
6183         * arm-linux-nat.c: Add include.
6184
6185 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6186
6187         * source-cache.c (source_cache::get_source_lines): Re-read
6188         fullname after calling open_source_file.
6189
6190 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6191
6192         * NEWS: Mention TLS support for FreeBSD.
6193
6194 2019-03-25  Tom Tromey  <tromey@adacore.com>
6195
6196         * minsyms.c (BUNCH_SIZE): Update comment.
6197         (~minimal_symbol_reader): Remove old comment.
6198         (compact_minimal_symbols): Update comment.
6199         (minimal_symbol_reader::install): Remove old comment.  Update
6200         other comments.
6201
6202 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6203
6204         * s390-linux-nat.c: Add include.
6205
6206 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6207
6208         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6209         Call linux_get_hwcap.
6210         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6211         Likewise.
6212         (aarch64_linux_get_hwcap): Remove function.
6213         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6214         declaration.
6215         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6216         linux_get_hwcap.
6217         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6218         * linux-tdep.c (linux_get_hwcap): Add function.
6219         (linux_get_hwcap2): Likewise.
6220         * linux-tdep.h (linux_get_hwcap): Add declaration.
6221         (linux_get_hwcap2): Likewise.
6222         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6223         (ppc_linux_get_hwcap2): Likewise.
6224         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6225         linux_get_hwcap.
6226         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6227         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6228         (ppc_linux_nat_target::read_description): Likewise.
6229         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6230         * s390-linux-nat.c: Likewise.
6231         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6232
6233 2019-03-24  Tom Tromey  <tom@tromey.com>
6234
6235         * ada-lang.c (standard_lookup): Simplify initialization.
6236         (ada_lookup_symbol_nonlocal): Simplify return.
6237         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6238         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6239         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6240         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6241         initialization.
6242         * solib.c (solib_global_lookup): Simplify.
6243         * symtab.c (null_block_symbol): Remove.
6244         (symbol_cache_lookup): Simplify returns.
6245         (lookup_language_this): Simplify returns.
6246         (lookup_symbol_aux): Simplify return.
6247         (lookup_local_symbol): Simplify returns.
6248         (lookup_global_symbol_from_objfile): Simplify return.
6249         (lookup_symbol_in_objfile_symtabs)
6250         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6251         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6252         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6253         * cp-namespace.c (cp_lookup_bare_symbol)
6254         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6255         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6256         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6257         (cp_lookup_symbol_via_imports): Simplify initialization.
6258         (find_symbol_in_baseclass): Likewise.
6259         * symtab.h (null_block_symbol): Remove.
6260         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6261         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6262         (d_lookup_symbol_module): Likewise.
6263         (find_symbol_in_baseclass): Simplify initialization.
6264
6265 2019-03-24  Tom Tromey  <tom@tromey.com>
6266
6267         * expression.h: Don't include symtab.h.
6268         (struct block): Forward declare.
6269
6270 2019-03-24  Tom Tromey  <tom@tromey.com>
6271
6272         * c-exp.y (typebase): Remove casts.
6273         * gdbtypes.c (lookup_unsigned_typename, )
6274         (lookup_signed_typename): Remove cast.
6275         * eval.c (parse_to_comma_and_eval): Remove cast.
6276         * parse.c (write_dollar_variable): Remove cast.
6277         * block.h (struct block) <superblock>: Now const.
6278         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6279         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6280         (map_block): Make "block" const.
6281         * symfile.h (struct quick_symbol_functions)
6282         <map_matching_symbols>: Constify block argument to "callback".
6283         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6284         const.
6285         (find_pc_sect_compunit_symtab): Make "b" const.
6286         (find_symbol_at_address): Likewise.
6287         (search_symbols): Likewise.
6288         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6289         (dw2_debug_names_lookup_symbol): Likewise.
6290         (dw2_map_matching_symbols): Update.
6291         * p-valprint.c (pascal_val_print): Remove "block".
6292         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6293         (aux_add_nonlocal_symbols): Make "block" const.
6294         (resolve_subexp): Remove cast.
6295         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6296         const.
6297         (iterate_over_file_blocks): Likewise.
6298         * f-exp.y (%union) <bval>: Remove.
6299         * coffread.c (patch_opaque_types): Make "b" const.
6300         * spu-tdep.c (spu_catch_start): Make "block" const.
6301         * c-valprint.c (print_unpacked_pointer): Remove "block".
6302         * symmisc.c (dump_symtab_1): Make "b" const.
6303         (block_depth): Make "block" const.
6304         * d-exp.y (%union) <bval>: Remove.
6305         * cp-support.h (cp_lookup_rtti_type): Update.
6306         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6307         * psymtab.c (psym_lookup_symbol): Make "block" const.
6308         (maintenance_check_psymtabs): Make "b" const.
6309         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6310         (enumerate_locals, enumerate_args): Update.
6311         * python/py-symtab.c (stpy_global_block): Make "block" const.
6312         (stpy_static_block): Likewise.
6313         * inline-frame.c (block_starting_point_at): Make "new_block"
6314         const.
6315         * block.c (find_block_in_blockvector): Make return type const.
6316         (blockvector_for_pc_sect): Make "b" const.
6317         (find_block_in_blockvector): Make "b" const.
6318
6319 2019-03-23  Tom Tromey  <tom@tromey.com>
6320
6321         * varobj.c (varobj_create): Update.
6322         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6323         * printcmd.c (display_command, do_one_display): Don't reset
6324         innermost_block.
6325         * parser-defs.h (enum innermost_block_tracker_type): Move to
6326         expression.h.
6327         (innermost_block): Update comment.
6328         * parse.c (parse_exp_1): Add tracker_types parameter.
6329         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6330         tracker_types parameter.  Reset innermost_block.
6331         (parse_exp_in_context): Remove.
6332         (parse_expression_for_completion): Update.
6333         * objfiles.c (~objfile): Don't reset expression_context_block or
6334         innermost_block.
6335         * expression.h (enum innermost_block_tracker_type): Move from
6336         parser-defs.h.
6337         (parse_exp_1): Add tracker_types parameter.
6338         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6339         reset innermost_block.
6340
6341 2019-03-23  Tom Tromey  <tom@tromey.com>
6342
6343         * objfiles.h: Include bcache.h.
6344
6345 2019-03-23  Tom Tromey  <tom@tromey.com>
6346
6347         * linespec.c (get_current_search_block): Use
6348         scoped_restore_current_language.
6349         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6350
6351 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6352             Jiong Wang  <jiong.wang@arm.com>
6353
6354         * aarch64-linux-tdep.c
6355         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6356         section.
6357         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6358
6359 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6360             Jiong Wang  <jiong.wang@arm.com>
6361
6362         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6363         instructions.
6364         (aarch64_analyze_prologue_test): Add PACIASP test.
6365         (aarch64_prologue_prev_register): Unmask PC value.
6366
6367 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6368             Jiong Wang  <jiong.wang@arm.com>
6369
6370         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6371         (aarch64_dwarf2_prev_register): Unmask PC value.
6372         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6373         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6374         DW_CFA_AARCH64_negate_ra_state.
6375         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6376
6377 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6378             Jiong Wang  <jiong.wang@arm.com>
6379
6380         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6381         registers.
6382         (aarch64_pseudo_register_name): Likewise.
6383         (aarch64_pseudo_register_type): Likewise.
6384         (aarch64_pseudo_register_reggroup_p): Likewise.
6385         (aarch64_gdbarch_init): Add pauth registers.
6386         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6387         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6388         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6389         (struct gdbarch_tdep): Add regnum for ra_state.
6390
6391 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6392             Jiong Wang  <jiong.wang@arm.com>
6393
6394         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6395
6396 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6397             Jiong Wang  <jiong.wang@arm.com>
6398
6399         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6400         function.
6401         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6402         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6403         (aarch64_gdbarch_init): Add puth registers.
6404         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6405         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6406         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6407
6408 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6409             Jiong Wang  <jiong.wang@arm.com>
6410
6411         * aarch64-linux-nat.c
6412         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6413         * aarch64-linux-tdep.c
6414         (aarch64_linux_core_read_description): Likewise.
6415         (aarch64_linux_get_hwcap): New function.
6416         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6417         (aarch64_linux_get_hwcap): New declaration.
6418
6419 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6420             Jiong Wang  <jiong.wang@arm.com>
6421
6422         * aarch64-linux-nat.c
6423         (aarch64_linux_nat_target::read_description): Add pauth param.
6424         * aarch64-linux-tdep.c
6425         (aarch64_linux_core_read_description): Likewise.
6426         * aarch64-tdep.c (struct target_desc): Add in pauth.
6427         (aarch64_read_description): Add pauth param.
6428         (aarch64_gdbarch_init): Likewise.
6429         * aarch64-tdep.h (aarch64_read_description): Likewise.
6430         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6431         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6432         * features/Makefile: Add new files.
6433         * features/aarch64-pauth.c: New file.
6434         * features/aarch64-pauth.xml: New file.
6435
6436 2019-03-20  Tom Tromey  <tromey@adacore.com>
6437
6438         * infrun.c (handle_inferior_event): Rename from
6439         handle_inferior_event_1.  Create a scoped_value_mark.
6440         (handle_inferior_event): Remove.
6441
6442 2019-03-19  Tom Tromey  <tromey@adacore.com>
6443
6444         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6445         * infrun.h (print_stop_event): Add "displays" parameter.
6446         * infrun.c (print_stop_event): Add "displays" parameter.
6447
6448 2019-03-19  Pedro Alves  <palves@redhat.com>
6449
6450         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6451         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6452         to -1.  Fix TABs vs spaces.
6453         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6454         * tui/tui-out.h (tui_ui_out) Add intro comments.
6455         <m_line, m_start_of_line>: In-class initialize, and add describing
6456         comment.
6457
6458 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6459
6460         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6461         variable names.
6462         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6463
6464 2019-03-18  Pedro Alves  <palves@redhat.com>
6465             Eli Zaretskii <eliz@gnu.org>
6466
6467         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6468         m_line and m_start_of_line.
6469
6470 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6471
6472         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6473         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6474         it returns a newline.  This fixes a regression in TU mode, whereby
6475         the next line is output on the same screen line as the user input.
6476
6477 2019-03-18  Tom Tromey  <tromey@adacore.com>
6478
6479         * minsyms.c (minimal_symbol_reader::install): Remove call to
6480         obstack_blank.
6481
6482 2019-03-18  Pedro Alves  <palves@redhat.com>
6483
6484         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6485         New globals.
6486         (apply_style): New, factored out from ...
6487         (apply_ansi_escape): ... this.  Handle reverse video mode.
6488         (tui_set_reverse_mode): New function.
6489         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6490         * tui/tui-winsource.c (tui_show_source_line): Use
6491         tui_set_reverse_mode instead of setting A_STANDOUT.
6492         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6493         New setter methods.
6494
6495 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6496
6497         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6498         Handle tabs.
6499
6500 2019-03-18  Tom Tromey  <tromey@adacore.com>
6501
6502         * ada-lang.c (empty_array): Add "high" parameter.
6503         (ada_evaluate_subexp): Update.
6504
6505 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6506
6507         * unittests/string_view-selftests.c: Define
6508         _initialize_string_view_selftests unconditionally.
6509
6510 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6511
6512         PR gdb/24350
6513         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6514
6515 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6516
6517         PR gdb/24351
6518         * windows-nat.c (display_selector): Fix format specifiers.
6519
6520 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6521
6522         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6523         tui_refill_source_window instead of tui_refresh_win, to update the
6524         current execution line.  This fixes redisplay of the current line
6525         when stepping through the code with "next" or "step".
6526
6527 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6528
6529         * source-cache.c (source_cache::get_source_lines): Call
6530         find_source_lines to initialize s->nlines.  This fixes vertical
6531         scrolling of TUI source window when the DOWN arrow is pressed.
6532
6533 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6534
6535         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6536         linux-thread-db.c (_initialize_thread_db): Likewise.
6537
6538 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6539
6540         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6541         wclrtoeol in tui_show_source_line".  This reverts changes made in
6542         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6543
6544 2019-03-15  Tom Tromey  <tom@tromey.com>
6545
6546         * symtab.h (struct minimal_symbol): Derive from
6547         general_symbol_info.
6548         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6549         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6550         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6551         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6552         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6553         (MSYMBOL_SEARCH_NAME): Update.
6554         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6555         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6556         * minsyms.c (minimal_symbol_reader::record_full): Update.
6557
6558 2019-03-15  Tom Tromey  <tom@tromey.com>
6559
6560         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6561
6562 2019-03-15  Tom Tromey  <tom@tromey.com>
6563
6564         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6565         unique_xmalloc_ptr.
6566         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6567         Update.
6568         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6569         (build_minimal_symbol_hash_tables)
6570         (minimal_symbol_reader::install): Update.
6571
6572 2019-03-15  Tom Tromey  <tom@tromey.com>
6573
6574         * symtab.c (create_demangled_names_hash): Update.
6575         (symbol_set_names): Update.
6576         * objfiles.h (struct objfile_per_bfd_storage)
6577         <demangled_names_hash>: Now an htab_up.
6578         * objfiles.c (objfile_per_bfd_storage): Simplify.
6579
6580 2019-03-15  Tom Tromey  <tom@tromey.com>
6581
6582         * objfiles.h (struct objfile_per_bfd_storage): Declare
6583         destructor.
6584         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6585         New.
6586         (get_objfile_bfd_data): Use new.  Don't initialize
6587         language_of_main.
6588         (free_objfile_per_bfd_storage): Remove.
6589         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6590
6591 2019-03-15  Tom Tromey  <tom@tromey.com>
6592
6593         * symfile.c (reread_symbols): Update.
6594         * objfiles.c (objfile::objfile): Update.
6595         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6596         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6597         comment.
6598         (minimal_symbol_reader::install): Update.
6599         (terminate_minimal_symbol_table): Remove.
6600         * jit.c (jit_object_close_impl): Update.
6601
6602 2019-03-15  Tom Tromey  <tom@tromey.com>
6603
6604         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6605         initializations.
6606
6607 2019-03-15  Tom Tromey  <tom@tromey.com>
6608
6609         * objfiles.h (struct objfile_per_bfd_storage)
6610         <demangled_hash_languages>: Now a bitset.
6611         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6612         (lookup_minimal_symbol): Update.
6613
6614 2019-03-15  Tom Tromey  <tom@tromey.com>
6615
6616         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6617         Don't return the symbol.
6618         * coffread.c (record_minimal_symbol): Use record_full.
6619
6620 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6621
6622         The MS-Windows port of ncurses fails to switch to a color pair if
6623         one or both of the colors are the implicit default colors.  This
6624         change records the default colors when TUI is initialized, and
6625         then specifies them explicitly when a color pair uses the default
6626         colors.  This allows color styling in TUI mode on MS-Windows.
6627
6628         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6629         ncurses_norm_attr.
6630         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6631         colors in ncurses_norm_attr.
6632         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6633         "none", replace it with the default color recorded in
6634         ncurses_norm_attr.
6635
6636 2019-03-14  Tom Tromey  <tromey@adacore.com>
6637
6638         * source-cache.h (class source_cache) <get_source_lines>: Return
6639         std::string.
6640         * source-cache.c (source_cache::extract_lines): Handle case where
6641         first_pos==npos.  Return std::string.
6642         (source_cache::get_source_lines): Update.
6643
6644 2019-03-14  Tom Tromey  <tromey@adacore.com>
6645
6646         * NEWS: Add item for "style sources" commands.
6647         * source-cache.c (source_cache::get_source_lines): Check
6648         source_styling.
6649         * cli/cli-style.c (source_styling): New global.
6650         (_initialize_cli_style): Add "style sources" commands.
6651         (show_style_sources): New function.
6652         * cli/cli-style.h (source_styling): Declare.
6653
6654 2019-03-14  Pedro Alves  <palves@redhat.com>
6655             Tom Tromey  <tromey@adacore.com>
6656
6657         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6658         * tui/tui-winsource.c (tui_refill_source_window): New function,
6659         from...
6660         (tui_horizontal_source_scroll): ... here.  Move some logic.
6661         * cli/cli-style.c (set_style_enabled): Notify new observable.
6662         * tui/tui-hooks.c (tui_redisplay_source): New function.
6663         (tui_attach_detach_observers): Attach or detach
6664         tui_redisplay_source.
6665         * observable.h (source_styling_changed): New observable.
6666         * observable.c: Define source_styling_changed observable.
6667
6668 2019-03-13  Tom Tromey  <tromey@adacore.com>
6669
6670         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6671         (i386_gnu_nat_target::store_registers): Update.
6672         * target-debug.h (target_debug_print_std_string): New macro.
6673         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6674         * windows-tdep.c (display_one_tib): Update.
6675         * tui/tui-stack.c (tui_make_status_line): Update.
6676         * top.c (print_inferior_quit_action): Update.
6677         * thread.c (thr_try_catch_cmd): Update.
6678         (add_thread_with_info): Update.
6679         (thread_target_id_str): Update.
6680         (thr_try_catch_cmd): Update.
6681         (thread_command): Update.
6682         (thread_find_command): Update.
6683         * record-btrace.c (record_btrace_target::info_record)
6684         (record_btrace_resume_thread, record_btrace_target::resume)
6685         (record_btrace_cancel_resume, record_btrace_step_thread)
6686         (record_btrace_target::wait, record_btrace_target::wait)
6687         (record_btrace_target::wait, record_btrace_target::stop): Update.
6688         * progspace.c (print_program_space): Update.
6689         * process-stratum-target.c
6690         (process_stratum_target::thread_address_space): Update.
6691         * linux-fork.c (linux_fork_mourn_inferior)
6692         (detach_checkpoint_command, info_checkpoints_command)
6693         (linux_fork_context): Update.
6694         (linux_fork_detach): Update.
6695         (class scoped_switch_fork_info): Update.
6696         (delete_checkpoint_command): Update.
6697         * infrun.c (follow_fork_inferior): Update.
6698         (follow_fork_inferior): Update.
6699         (proceed_after_vfork_done): Update.
6700         (handle_vfork_child_exec_or_exit): Update.
6701         (follow_exec): Update.
6702         (displaced_step_prepare_throw): Update.
6703         (displaced_step_restore): Update.
6704         (start_step_over): Update.
6705         (resume_1): Update.
6706         (clear_proceed_status_thread): Update.
6707         (proceed): Update.
6708         (print_target_wait_results): Update.
6709         (do_target_wait): Update.
6710         (context_switch): Update.
6711         (stop_all_threads): Update.
6712         (restart_threads): Update.
6713         (finish_step_over): Update.
6714         (handle_signal_stop): Update.
6715         (switch_back_to_stepped_thread): Update.
6716         (keep_going_pass_signal): Update.
6717         (print_exited_reason): Update.
6718         (normal_stop): Update.
6719         * inferior.c (inferior_pid_to_str): Change return type.
6720         (print_selected_inferior): Update.
6721         (add_inferior): Update.
6722         (detach_inferior): Update.
6723         * dummy-frame.c (fprint_dummy_frames): Update.
6724         * dcache.c (dcache_info_1): Update.
6725         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6726         (btrace_fetch, btrace_clear): Update.
6727         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6728         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6729         type.
6730         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6731         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6732         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6733         * gdbarch.c, gdbarch.h: Rebuild.
6734         * gdbarch.sh (core_pid_to_str): Change return type.
6735         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6736         return type.
6737         (windows_nat_target::pid_to_str): Change return type.
6738         (windows_delete_thread): Update.
6739         (windows_nat_target::attach): Update.
6740         (windows_nat_target::files_info): Update.
6741         * target-delegates.c: Rebuild.
6742         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6743         return type.
6744         (sol_thread_target::pid_to_str): Change return type.
6745         * remote.c (class remote_target) <pid_to_str>: Change return
6746         type.
6747         (remote_target::pid_to_str): Change return type.
6748         (extended_remote_target::attach, remote_target::remote_stop_ns)
6749         (remote_target::remote_notif_remove_queued_reply)
6750         (remote_target::push_stop_reply, remote_target::disable_btrace):
6751         Update.
6752         (extended_remote_target::attach): Update.
6753         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6754         type.
6755         (gdbsim_target::pid_to_str): Change return type.
6756         * ravenscar-thread.c (struct ravenscar_thread_target)
6757         <pid_to_str>: Change return type.
6758         (ravenscar_thread_target::pid_to_str): Change return type.
6759         * procfs.c (class procfs_target) <pid_to_str>: Change return
6760         type.
6761         (procfs_target::pid_to_str): Change return type.
6762         (procfs_target::attach): Update.
6763         (procfs_target::detach): Update.
6764         (procfs_target::fetch_registers): Update.
6765         (procfs_target::store_registers): Update.
6766         (procfs_target::wait): Update.
6767         (procfs_target::files_info): Update.
6768         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6769         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6770         return type.
6771         (nto_procfs_target::pid_to_str): Change return type.
6772         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6773         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6774         return type.
6775         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6776         (exit_lwp): Update.
6777         (attach_proc_task_lwp_callback, get_detach_signal)
6778         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6779         (linux_nat_target::resume, wait_lwp, stop_callback)
6780         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6781         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6782         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6783         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6784         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6785         type.
6786         (inf_ptrace_target::attach): Update.
6787         (inf_ptrace_target::files_info): Update.
6788         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6789         type.
6790         (go32_nat_target::pid_to_str): Change return type.
6791         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6792         (gnu_nat_target::wait): Update.
6793         (gnu_nat_target::wait): Update.
6794         (gnu_nat_target::resume): Update.
6795         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6796         (fbsd_nat_target::wait): Update.
6797         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6798         type.
6799         (darwin_nat_target::attach): Update.
6800         * corelow.c (class core_target) <pid_to_str>: Change return type.
6801         (core_target::pid_to_str): Change return type.
6802         * target.c (normal_pid_to_str): Change return type.
6803         (default_pid_to_str): Likewise.
6804         (target_pid_to_str): Change return type.
6805         (target_translate_tls_address): Update.
6806         (target_announce_detach): Update.
6807         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6808         return type.
6809         (bsd_uthread_target::pid_to_str): Change return type.
6810         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6811         type.
6812         (bsd_kvm_target::pid_to_str): Change return type.
6813         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6814         return type.
6815         (aix_thread_target::pid_to_str): Change return type.
6816         * target.h (struct target_ops) <pid_to_str>: Change return type.
6817         (target_pid_to_str, normal_pid_to_str): Likewise.
6818         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6819         type.
6820         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6821         type.
6822         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6823         return type.
6824         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6825         type.
6826         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6827         type.
6828         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6829         return type.
6830
6831 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6832
6833         * NEWS: Mention that the new default MI version is 3.  Mention
6834         changes to the output of commands and events that deal with
6835         multi-location breakpoints.
6836         * breakpoint.c: Include "mi/mi-out.h".
6837         (print_one_breakpoint): Change output syntax if using MI version
6838         >= 3.
6839         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6840         New.
6841         (mi_multi_location_breakpoint_output_fixed): New.
6842         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6843         (mi_cmd_fix_multi_location_breakpoint_output): New.
6844         (mi_multi_location_breakpoint_output_fixed): New.
6845         * mi/mi-cmds.c (mi_cmds): Register command
6846         -fix-multi-location-breakpoint-output.
6847         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6848         interpreter "mi".
6849
6850 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6851
6852         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6853         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6854         instantiate mi_ui_out based on interpreter name.
6855         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6856         * mi/mi-main.c (mi_load_progress): Likewise.
6857
6858 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6859
6860         * NEWS: Combine separate "New targets" sections for 8.3.
6861
6862 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6863
6864         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6865         (ppcfbsd_init_abi): Install gdbarch
6866         "fetch_tls_load_module_address" and "get_thread_local_address"
6867         methods.
6868
6869 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6870
6871         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6872         (riscv_fbsd_init_abi): Install gdbarch
6873         "fetch_tls_load_module_address" and "get_thread_local_address"
6874         methods.
6875
6876 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6877
6878         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6879         (i386fbsd_init_abi): Install gdbarch
6880         "fetch_tls_load_module_address" and "get_thread_local_address"
6881         methods.
6882
6883 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6884
6885         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6886         (amd64fbsd_init_abi): Install gdbarch
6887         "fetch_tls_load_module_address" and "get_thread_local_address"
6888         methods.
6889
6890 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6891
6892         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6893         (struct fbsd_pspace_data): New type.
6894         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6895         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6896         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6897         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6898         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6899
6900 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6901
6902         * gdbtypes.c (lookup_struct_elt): New function.
6903         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6904         * gdbtypes.h (struct struct_elt): New type.
6905         (lookup_struct_elt): New prototype.
6906
6907 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6908
6909         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6910         remove disabled code block.
6911
6912 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6913
6914         * gdbarch.sh (get_thread_local_address): New method.
6915         * gdbarch.h, gdbarch.c: Regenerate.
6916         * target.c (target_translate_tls_address): Use
6917         gdbarch_get_thread_local_address if present instead of
6918         target::get_thread_local_address.
6919
6920 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6921
6922         * target.h (target::get_thread_local_address): Update comment.
6923
6924 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6925
6926         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6927         objfile->separate_debug_objfile_backlink if not NULL.
6928
6929 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6930
6931         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6932         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6933         (amd64bsd_store_inferior_registers): Likewise.
6934         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6935         Enable segment base registers.
6936         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6937         PT_GETFSBASE and PT_GETGSBASE.
6938         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6939         PT_SETGSBASE.
6940         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6941         segment base registers.
6942         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6943
6944 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6945
6946         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6947         Update calls to i386_target_description to add 'segments'
6948         parameter.
6949         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6950         add segment base registers.
6951         * arch/i386.c (i386_create_target_description): Add 'segments'
6952         parameter to enable segment base registers.
6953         * arch/i386.h (i386_create_target_description): Likewise.
6954         * features/i386/32bit-segments.xml: New file.
6955         * features/i386/32bit-segments.c: Generate.
6956         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6957         call to i386_target_description to add 'segments' parameter.
6958         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6959         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6960         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6961         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6962         if feature is present.
6963         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6964         Add 'segments' parameter to call to i386_target_description.
6965         (i386_target_description): Add 'segments' parameter to enable
6966         segment base registers.
6967         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6968         to call to i386_target_description.
6969         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6970         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6971         Define I386_NUM_REGS.
6972         (i386_target_description): Add 'segments' parameter to enable
6973         segment base registers.
6974
6975 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6976
6977         PR/24325
6978         * source-cache.c: #undef open and close, to avoid unresolved
6979         externals during linking.
6980
6981 2019-03-12  Tom Tromey  <tromey@adacore.com>
6982
6983         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6984         const.  Add initializers.
6985         (_initialize_remote): Don't initialize ptid globals.
6986
6987 2019-03-12  Pedro Alves  <palves@redhat.com>
6988
6989         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6990
6991 2019-03-12  Pedro Alves  <palves@redhat.com>
6992
6993         * cp-name-parser.y (main): Remove unused 'len' variable.
6994
6995 2019-03-12  Tom Tromey  <tromey@adacore.com>
6996
6997         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6998         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6999
7000 2019-03-12  Tom Tromey  <tromey@adacore.com>
7001
7002         * linux-nat.c (iterate_over_lwps): Update.
7003         (stop_callback): Remove parameter.
7004         (stop_wait_callback, detach_callback, resume_set_callback)
7005         (select_singlestep_lwp_callback, set_ignore_sigint)
7006         (status_callback, resumed_callback, resume_clear_callback)
7007         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7008         data parameter.
7009         (linux_nat_target::detach, linux_nat_target::resume)
7010         (linux_stop_and_wait_all_lwps, select_event_lwp)
7011         (linux_nat_filter_event, linux_nat_wait_1)
7012         (linux_nat_target::kill, linux_nat_target::stop)
7013         (linux_nat_target::stop): Update.
7014         (linux_nat_resume_callback): Change type.
7015         (resume_stopped_resumed_lwps, count_events_callback)
7016         (select_event_lwp_callback): Likewise.
7017         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7018         * arm-linux-nat.c (struct update_registers_data): Remove.
7019         (update_registers_callback): Change type.
7020         (arm_linux_insert_hw_breakpoint1): Update.
7021         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7022         parameter.
7023         (x86_linux_dr_set_addr): Update.
7024         (x86_linux_dr_set_control): Update.
7025         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7026         (iterate_over_lwps): Use gdb::function_view.
7027         * nat/aarch64-linux-hw-point.c (struct
7028         aarch64_dr_update_callback_param): Remove.
7029         (debug_reg_change_callback): Change type.
7030         (aarch64_notify_debug_reg_change): Update.
7031         * s390-linux-nat.c (s390_refresh_per_info): Update.
7032
7033 2019-03-11  Tom Tromey  <tromey@adacore.com>
7034
7035         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7036         redundant assignment to "this_cu".
7037
7038 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7039
7040         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7041
7042 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7043
7044         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7045         from...
7046         (rank_one_type): ... this.
7047
7048 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7049
7050         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7051         from...
7052         (rank_one_type): ... this.
7053
7054 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7055
7056         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7057         from...
7058         (rank_one_type): ... this.
7059
7060 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7061
7062         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7063         from...
7064         (rank_one_type): ... this.
7065
7066 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7067
7068         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7069         from...
7070         (rank_one_type): ... this.
7071
7072 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7073
7074         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7075         from...
7076         (rank_one_type): ... this.
7077
7078 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7079
7080         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7081         from...
7082         (rank_one_type): ... this.
7083
7084 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7085
7086         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7087         from...
7088         (rank_one_type): ... this.
7089
7090 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7091
7092         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7093         from...
7094         (rank_one_type): ... this.
7095
7096 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7097
7098         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7099         from...
7100         (rank_one_type): ... this.
7101
7102 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7103
7104         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7105         from...
7106         (rank_one_type): ... this.
7107
7108 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7109
7110         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7111         from...
7112         (rank_one_type): ... this.
7113
7114 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7115
7116         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7117         inferior-events' shows the example events.
7118
7119 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7120
7121         Support styling on native MS-Windows console
7122
7123         PR/24315
7124         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7125         on MS-Windows if $TERM is not defined.
7126
7127         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7128
7129         * posix-hdep.c (gdb_console_fputs):
7130         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7131         functions.
7132         * ui-file.h (gdb_console_fputs): Add prototype.
7133
7134         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7135         back to fputs only if the former returns zero.
7136
7137 2019-03-07  Tom Tromey  <tom@tromey.com>
7138
7139         * symmisc.c (print_symbol_bcache_statistics): Update.
7140         (print_objfile_statistics): Update.
7141         * symfile.c (allocate_symtab): Update.
7142         * stabsread.c: Don't include bcache.h.
7143         * psymtab.h (struct psymbol_bcache): Don't declare.
7144         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7145         (psymbol_bcache_init, psymbol_bcache_free)
7146         (psymbol_bcache_get_bcache): Don't declare.
7147         * psymtab.c (struct psymbol_bcache): Remove.
7148         (psymtab_storage::psymtab_storage): Update.
7149         (psymtab_storage::~psymtab_storage): Update.
7150         (psymbol_bcache_init, psymbol_bcache_free)
7151         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7152         (add_psymbol_to_bcache): Update.
7153         (allocate_psymtab): Update.
7154         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7155         macro_cache>: No longer pointers.
7156         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7157         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7158         * macrotab.c (macro_bcache): Update.
7159         * macroexp.c: Don't include bcache.h.
7160         * gdbtypes.c (check_types_worklist): Update.
7161         (types_deeply_equal): Remove TRY/CATCH.  Update.
7162         * elfread.c (elf_symtab_read): Update.
7163         * dwarf2read.c: Don't include bcache.h.
7164         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7165         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7166         (print_bcache_statistics, bcache_memory_used): Don't declare.
7167         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7168         methods.  Rename all data members.
7169         * bcache.c (struct bcache): Move to bcache.h.
7170         (bcache::expand_hash_table): Rename from expand_hash_table.
7171         (bcache): Remove.
7172         (bcache::insert): Rename from bcache_full.
7173         (bcache::compare): Rename from bcache_compare.
7174         (bcache_xmalloc): Remove.
7175         (bcache::~bcache): Rename from bcache_xfree.
7176         (bcache::print_statistics): Rename from print_bcache_statistics.
7177         (bcache::memory_used): Rename from bcache_memory_used.
7178
7179 2019-03-07  Pedro Alves  <palves@redhat.com>
7180
7181         * infrun.c (normal_stop): Also check for
7182         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7183
7184 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7185
7186         * f-lang.c (value_from_host_double): Moved to...
7187         * value.c (value_from_host_double): ...here.
7188         * value.h (value_from_host_double): Declare.
7189         * guile/scm-math.c (vlscm_convert_typed_number): Use
7190         value_from_host_double.
7191         (vlscm_convert_number): Likewise.
7192         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7193         * python/py-value.c (convert_value_from_python): Likewise.
7194
7195 2019-03-06  Tom Tromey  <tom@tromey.com>
7196
7197         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7198
7199 2019-03-06  Tom Tromey  <tom@tromey.com>
7200
7201         * utils.h (free_current_contents): Don't declare.
7202         * utils.c (free_current_contents): Remove.
7203
7204 2019-03-06  Tom Tromey  <tom@tromey.com>
7205
7206         * top.c (quit_force): Update.
7207         * main.c (captured_command_loop): Update.
7208         * common/new-op.c (operator new): Update.
7209         * common/common-exceptions.c (struct catcher)
7210         <save_cleanup_chain>: Remove member.
7211         (exceptions_state_mc_init): Update.
7212         (exception_try_scope_entry): Return nullptr.
7213         (exception_try_scope_exit, exception_rethrow)
7214         (throw_exception_sjlj, throw_exception_cxx): Update.
7215         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7216         (all_cleanups, do_cleanups, discard_cleanups)
7217         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7218         (restore_cleanups, restore_final_cleanups): Don't declare.
7219         (do_final_cleanups): Remove parameter.
7220         * common/cleanups.c (cleanup_chain, make_cleanup)
7221         (make_cleanup_dtor, all_cleanups, do_cleanups)
7222         (discard_my_cleanups, discard_cleanups)
7223         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7224         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7225         (null_cleanup): Remove.
7226         (do_final_cleanups): Remove parameter.
7227
7228 2019-03-06  Tom Tromey  <tom@tromey.com>
7229
7230         * remote.c (remote_target::remote_parse_stop_reply): Use
7231         unique_xmalloc_ptr.
7232
7233 2019-03-06  Tom Tromey  <tom@tromey.com>
7234
7235         * stabsread.c (struct stabs_field_info): Rename from field_info.
7236         <list, fnlist>: Add initializers.
7237         <obstack>: New member.
7238         (read_member_functions, read_struct_fields, read_baseclasses):
7239         Allocate on obstack.  Don't use cleanups.
7240         (read_one_struct_field, read_member_functions, read_struct_fields)
7241         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7242         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7243         (read_struct_type): Update.
7244
7245 2019-03-06  Tom Tromey  <tom@tromey.com>
7246
7247         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7248         * common/filestuff.h (make_cleanup_close): Don't declare.
7249         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7250         Remove.
7251
7252 2019-03-06  Tom Tromey  <tom@tromey.com>
7253
7254         * solib-aix.c: Use make_scope_exit.
7255
7256 2019-03-06  Tom Tromey  <tom@tromey.com>
7257
7258         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7259         Use make_scope_exit.
7260
7261 2019-03-06  Tom Tromey  <tom@tromey.com>
7262
7263         * solib-svr4.c (disable_probes_interface): Remove parameter.
7264         (svr4_handle_solib_event): Use make_scope_exit.
7265
7266 2019-03-06  Tom Tromey  <tom@tromey.com>
7267
7268         * remote.c (struct stop_reply_deleter): Remove.
7269         (stop_reply_up): Update.
7270         (struct stop_reply): Derive from notif_event.  Don't typedef.
7271         <regcache>: Now a std::vector.
7272         (stop_reply_xfree): Remove.
7273         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7274         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7275         (remote_target::discard_pending_stop_replies): Use delete.
7276         (remote_target::remote_parse_stop_reply): Update.
7277         (remote_target::process_stop_reply): Update.
7278         * remote-notif.h (struct notif_event): Add virtual destructor.
7279         Remove "dtr" member.
7280         (struct notif_client) <alloc_event>: Return a unique_ptr.
7281         (notif_event_xfree): Don't declare.
7282         (notif_event_up): New typedef.
7283         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7284         (notif_event_xfree, do_notif_event_xfree): Remove.
7285         (remote_notif_state_xfree): Update.
7286
7287 2019-03-06  Tom Tromey  <tom@tromey.com>
7288
7289         * infrun.c (displaced_step_clear_cleanup): Now a
7290         forward_scope_exit type.
7291         (displaced_step_prepare_throw): Update.
7292         (displaced_step_fixup): Update.
7293
7294 2019-03-06  Tom Tromey  <tom@tromey.com>
7295
7296         * inferior.h (class inferior): Update comment.
7297         * gdbthread.h (class thread_info): Update comment.
7298
7299 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7300             Tom Tromey  <tom@tromey.com>
7301
7302         * stabsread.h (struct stab_section_list): Remove.
7303         (coffstab_build_psymtabs): Update.
7304         * dbxread.c (symbuf_sections): Now a std::vector.
7305         (sect_idx): New global.
7306         (fill_symbuf): Update.
7307         (coffstab_build_psymtabs): Change type of stabsects parameter.
7308         Update.
7309         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7310         std::vector.
7311         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7312         (coff_locate_sections): Update.
7313         (coff_symfile_read): Remove cleanups.  Update.
7314         (init_stringtab): Add storage parameter.
7315         (free_stringtab, free_stringtab_cleanup): Remove.
7316         (init_lineno): Add storage parameter.
7317         (free_linetab, free_linetab_cleanup): Remove.
7318
7319 2019-03-06  Pedro Alves  <palves@redhat.com>
7320
7321         * linux-fork.c (fork_info::clobber_regs): Delete.
7322         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7323         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7324         comment.  Adjust.
7325         (scoped_switch_fork_info::scoped_switch_fork_info)
7326         (checkpoint_command, linux_fork_context): Adjust
7327         fork_save_infrun_state calls.
7328
7329 2019-03-06  Pedro Alves  <palves@redhat.com>
7330
7331         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7332         (inf_has_multiple_threads): Return 'bool' and rewrite using
7333         inferior_info::threads().
7334
7335 2019-03-06  Pedro Alves  <palves@redhat.com>
7336
7337         * linux-fork.c: Include <list>.
7338         (fork_list): Now a std::list instance.
7339         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7340         (forks_exist_p, find_last_fork): Adjust.
7341         (new_fork): Delete.
7342         (one_fork_p): New.
7343         (add_fork): Adjust.
7344         (free_fork): Delete, folded into fork_info::~fork_info().
7345         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7346         Adjust.
7347         (init_fork_list): Delete.
7348         (linux_fork_killall, linux_fork_mourn_inferior)
7349         (linux_fork_detach, info_checkpoints_command): Adjust.
7350         (_initialize_linux_fork): No longer call init_fork_list.
7351
7352 2019-03-06  Pedro Alves  <palves@redhat.com>
7353
7354         * linux-fork.c (new_fork): New, split out of ...
7355         (add_fork): ... this.  Return void.  Move "first fork" special
7356         case from here, to ...
7357         (checkpoint_command): ... here.
7358         * linux-linux.h (add_fork): Return void.
7359
7360 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7361
7362         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7363
7364 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7365             Chris January  <chris.january@arm.com>
7366             David Lecomber  <david.lecomber@arm.com>
7367
7368         * f-exp.y: New token, UNOP_INTRINSIC.
7369         (exp): New pattern using UNOP_INTRINSIC token.
7370         (f77_keywords): Add 'abs' keyword.
7371         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7372         (value_from_host_double): New function.
7373         (evaluate_subexp_f): Support UNOP_ABS.
7374
7375 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7376
7377         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7378         types.
7379
7380 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7381
7382         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7383         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7384         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7385
7386 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7387
7388         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7389
7390 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7391             Chris January  <chris.january@arm.com>
7392
7393         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7394         * f-exp.y: Define 'KIND' token.
7395         (exp): New pattern for KIND expressions.
7396         (ptype): Handle types with a kind extension.
7397         (direct_abs_decl): Extend to spot kind extensions.
7398         (f77_keywords): Add 'kind' to the list.
7399         (push_kind_type): New function.
7400         (convert_to_kind_type): New function.
7401         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7402         * parse.c (operator_length_standard): Likewise.
7403         * parser-defs.h (enum type_pieces): Add tp_kind.
7404         * std-operator.def: Add UNOP_KIND.
7405
7406 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7407
7408         * f-exp.y (f_parse): Set yydebug.
7409
7410 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7411
7412         * f-lang.c (evaluate_subexp_f): New function.
7413         (exp_descriptor_f): New global.
7414         (f_language_defn): Use exp_descriptor_f instead of
7415         exp_descriptor_standard.
7416
7417 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7418
7419         * f-exp.y (struct token): Add comments.
7420         (dot_ops): Remove uppercase versions and the end marker.
7421         (f77_keywords): Likewise.
7422         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7423         entries in the dot_ops array are case insensitive, and use
7424         strncasecmp to compare strings.  Also some whitespace cleanup in
7425         this area.  Similar for the f77_keywords array, except entries in
7426         this list might be case sensitive.
7427
7428 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7429
7430         * f-exp.y (struct f77_boolean_val): Add comments.
7431         (boolean_values): Remove uppercase versions, and end marker.
7432         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7433         and use strncasecmp to achieve case insensitivity.  Additionally,
7434         perform whitespace cleanup around this code.
7435
7436 2019-03-06  Tom Tromey  <tromey@adacore.com>
7437
7438         * remote-sim.c (gdbsim_target_open): Use result of
7439         gdb_argv::release.
7440
7441 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7442         Dirk Schubert  <dirk.schubert@arm.com>
7443         Chris January  <chris.january@arm.com>
7444
7445         * eval.c (evaluate_subexp_standard): Call Fortran argument
7446         wrapping logic.
7447         * f-lang.c (struct value): A value which can be passed into a
7448         Fortran function call.
7449         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7450         where appropriate.
7451         (struct type): Value ready for a Fortran function call.
7452         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7453         is needed.
7454         * f-lang.h (fortran_argument_convert): Declaration.
7455         (fortran_preserve_arg_pointer): Declaration.
7456         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7457
7458 2019-03-05  Tom Tromey  <tromey@adacore.com>
7459
7460         * python/py-prettyprint.c (print_string_repr): Remove #if.
7461         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7462
7463 2019-03-05  Tom Tromey  <tromey@adacore.com>
7464
7465         * target.c (the_dummy_target): Move later.  Change type to
7466         "dummy_target".
7467         (initialize_targets): Don't initialize the_dummy_target.
7468
7469 2019-03-05  Tom Tromey  <tromey@adacore.com>
7470
7471         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7472         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7473
7474 2019-03-05  Tom Tromey  <tromey@adacore.com>
7475
7476         * windows-nat.c (windows_nat_target::attach)
7477         (windows_nat_target::detach): Don't call gdb_flush.
7478         * valprint.c (generic_val_print, val_print, val_print_string):
7479         Don't call gdb_flush.
7480         * utils.c (defaulted_query): Don't call gdb_flush.
7481         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7482         * target.c (target_announce_detach): Don't call gdb_flush.
7483         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7484         * remote.c (extended_remote_target::attach): Don't call
7485         gdb_flush.
7486         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7487         * printcmd.c (do_examine): Don't call gdb_flush.
7488         (info_display_command): Don't call gdb_flush.
7489         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7490         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7491         * memattr.c (info_mem_command): Don't call gdb_flush.
7492         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7493         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7494         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7495         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7496         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7497         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7498         (gnu_nat_target::detach): Don't call gdb_flush.
7499         * f-valprint.c (f_val_print): Don't call gdb_flush.
7500         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7501         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7502         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7503         gdb_flush.
7504         * c-valprint.c (c_val_print): Don't call gdb_flush.
7505         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7506
7507 2019-03-05  Tom Tromey  <tromey@adacore.com>
7508
7509         * varobj.c (update_dynamic_varobj_children): Update.
7510         (install_default_visualizer): Use reset, not release.
7511         * value.c (set_internalvar): Update.
7512         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7513         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7514         ATTRIBUTE_UNUSED_RESULT.
7515
7516 2019-03-05  Tom Tromey  <tromey@adacore.com>
7517
7518         * remote.c (class scoped_remote_fd) <release>: Add
7519         ATTRIBUTE_UNUSED_RESULT.
7520
7521 2019-03-05  Tom Tromey  <tromey@adacore.com>
7522
7523         * macroexp.c (struct macro_buffer) <release>: Add
7524         ATTRIBUTE_UNUSED_RESULT.
7525
7526 2019-03-05  Tom Tromey  <tromey@adacore.com>
7527
7528         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7529         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7530         ATTRIBUTE_UNUSED_RESULT.
7531
7532 2019-03-05  Tom Tromey  <tromey@adacore.com>
7533
7534         * common/scoped_fd.h (class scoped_fd) <release>: Add
7535         ATTRIBUTE_UNUSED_RESULT.
7536
7537 2019-03-05  Tom Tromey  <tromey@adacore.com>
7538
7539         * parser-defs.h (struct parser_state) <release>: Add
7540         ATTRIBUTE_UNUSED_RESULT.
7541
7542 2019-03-05  Tom Tromey  <tromey@adacore.com>
7543
7544         * utils.h (class gdb_argv) <release>: Add
7545         ATTRIBUTE_UNUSED_RESULT.
7546         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7547
7548 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7549
7550         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7551         for-loop range, to avoid compiler warnings.
7552
7553         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7554         avoid compiler warnings about unused variables.
7555
7556         * NEWS: Mention end of support for native debugging on MS-Windows
7557         before XP.
7558
7559         PR gdb/24292
7560         * common/netstuff.c:
7561         * gdbserver/gdbreplay.c
7562         * gdbserver/remote-utils.c:
7563         * ser-tcp.c:
7564         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7565         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7566         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7567         'getaddrinfo' and 'freeaddrinfo' were not available before
7568         Windows XP, and mingw.org's MinGW headers by default define
7569         _WIN32_WINNT to 0x500.
7570
7571 2019-03-01  Gary Benson <gbenson@redhat.com>
7572
7573         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7574
7575 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7576             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7577
7578         PR gdb/8527
7579         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7580         set_sigint_trap, clear_sigint_trap.
7581
7582 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7583
7584         * target.c (target_detach): Clear the regcache and the
7585         frame cache.
7586
7587 2019-02-27  Pedro Alves  <palves@redhat.com>
7588
7589         * utils.c (set_screen_size): When we cap the height/width sizes,
7590         tweak the corresponding command variable to show "unlimited":
7591
7592 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7593             Pedro Alves  <palves@redhat.com>
7594
7595         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7596         before calling rl_set_screen_size.
7597
7598 2019-02-27  Tom Tromey  <tromey@adacore.com>
7599
7600         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7601         define.
7602         * python/py-value.c: Remove Python 2.4 workaround.
7603         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7604         workaround.
7605         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7606         Python 2.4 workaround.
7607         * python/python-internal.h: Remove Python 2.4 comment.
7608         (Py_ssize_t): Don't define.
7609         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7610         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7611         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7612         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7613         * python/python.c (do_start_initialization): Remove Python 2.4
7614         workaround.
7615         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7616         (print_children): Remove Python 2.4 workaround.
7617         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7618         workaround.
7619         (CHARBUFFERPROC_NAME): Remove.
7620         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7621         Python 2.4 workaround.
7622
7623 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7624
7625         * NEWS: Note minimum Python version.
7626
7627 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7628
7629         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7630         code from these functions.  Remove corresponding ifdefs.  Use
7631         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7632         Remove gotos and target of gotos.
7633         (infpy_search_memory): Likewise.
7634
7635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7636
7637         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7638         (hppa_gdbarch_init): Don't register deleted functions with
7639         gdbarch.
7640
7641 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7642
7643         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7644         (h8300_unwind_sp): Delete.
7645         (h8300_dummy_id): Delete.
7646         (h8300_gdbarch_init): Don't register deleted functions with
7647         gdbarch.
7648
7649 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7650
7651         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7652         (ft32_unwind_pc): Delete.
7653         (ft32_unwind_sp): Delete.
7654         (ft32_gdbarch_init): Don't register deleted functions with
7655         gdbarch.
7656
7657 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7658
7659         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7660         (frv_unwind_pc): Delete.
7661         (frv_unwind_sp): Delete.
7662         (frv_gdbarch_init): Don't register deleted functions with
7663         gdbarch.
7664
7665 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7666
7667         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7668         (riscv_unwind_pc): Delete.
7669         (riscv_unwind_sp): Delete.
7670         (riscv_gdbarch_init): Don't register deleted functions with
7671         gdbarch.
7672
7673 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7674
7675         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7676         (csky_unwind_pc): Delete.
7677         (csky_unwind_sp): Delete.
7678         (csky_gdbarch_init): Don't register deleted functions with
7679         gdbarch.
7680
7681 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7682
7683         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7684         (cris_unwind_pc): Delete.
7685         (cris_unwind_sp): Delete.
7686         (cris_gdbarch_init): Don't register deleted functions with
7687         gdbarch.
7688
7689 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7690
7691         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7692         (bfin_unwind_pc): Delete.
7693         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7694
7695 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7696
7697         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7698         (arm_unwind_pc): Delete.
7699         (arm_unwind_sp): Delete.
7700         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7701
7702 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7703
7704         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7705         (arc_unwind_pc): Delete.
7706         (arc_unwind_sp): Delete.
7707         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7708
7709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7710
7711         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7712         (alpha_unwind_pc): Delete.
7713         (alpha_gdbarch_init): Don't register deleted functions with
7714         gdbarch.
7715
7716 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7717
7718         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7719         (aarch64_unwind_pc): Delete.
7720         (aarch64_unwind_sp): Delete.
7721         (aarch64_gdbarch_init): Don't register deleted functions with
7722         gdbarch.
7723
7724 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7725
7726         * gdbtypes.c (type_align): Don't consider static members when
7727         computing structure alignment.
7728
7729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7730
7731         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7732         return 0 for other types.
7733         * arch-utils.c (default_type_align): Always return 0.
7734         * gdbarch.h: Regenerate.
7735         * gdbarch.sh (type_align): Extend comment.
7736         * gdbtypes.c (type_align): Add additional comments, always call
7737         gdbarch_type_align before applying the default rules.
7738         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7739         generic code will then apply a suitable default.
7740         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7741         types, return 0 for other types.
7742
7743 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7744
7745         * NEWS: Create a new section for the next release branch.
7746         Rename the section of the current branch, now that it has
7747         been cut.
7748
7749 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7750
7751         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7752         * version.in: Bump version to 8.3.50.DATE-git.
7753
7754 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7755
7756         * aix-thread.c (ptid_cmp): Remove unused variable.
7757         (get_signaled_thread): Likewise.
7758         (store_regs_user_thread): Likewise.
7759         (store_regs_kernel_thread): Likewise.
7760         (fetch_regs_kernel_thread): Remove shadowed variable.
7761
7762 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7763
7764         * features/riscv/32bit-cpu.xml: Add register numbers.
7765         * features/riscv/32bit-fpu.c: Regenerate.
7766         * features/riscv/32bit-fpu.xml: Add register numbers.
7767         * features/riscv/64bit-cpu.xml: Add register numbers.
7768         * features/riscv/64bit-fpu.c: Regenerate.
7769         * features/riscv/64bit-fpu.xml: Add register numbers.
7770
7771 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7772
7773         * NEWS: Mention two argument form of gdb.Value constructor.
7774         * python/py-value.c (convert_buffer_and_type_to_value): New
7775         function.
7776         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7777         Add support for handling an optional second argument.  Call
7778         convert_buffer_and_type_to_value as appropriate.
7779         * python/python-internal.h (Py_buffer_deleter): New struct.
7780         (Py_buffer_up): New typedef.
7781
7782 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7783
7784         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7785         instead of releasing ownership.
7786
7787 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7788
7789         * dwarf2read.c (open_and_init_dwp_file): Call
7790         elf_numsections instead of bfd_count_sections to initialize
7791         dwp_file->num_sections.
7792
7793 2019-02-25  Tom Tromey  <tromey@adacore.com>
7794
7795         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7796
7797 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7798
7799         * gcore.in: Add '--readnever' option when invoking GDB.
7800
7801 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7802
7803         * MAINTAINERS: Update my email address.
7804
7805 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7806
7807         * build-id.c (build_id_to_debug_bfd_1): New function.
7808         (build_id_to_debug_bfd): Look for separate debug file in
7809         sysroot.
7810
7811 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7812
7813         * gdbarch.sh: Update the copyright year range that is placed into
7814         generated files.
7815
7816 2019-02-22  Keith Seitz  <keiths@redhat.com>
7817
7818         PR symtab/23853
7819         * linespec.c (create_sals_line_offset): Search for the default
7820         symtab's filename instead of its fullname.
7821
7822 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7823
7824         * NEWS: Update style defaults.
7825
7826 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7827
7828         * main.c (captured_main_1): Disable styling in batch mode.
7829
7830 2019-02-20  Tom Tromey  <tom@tromey.com>
7831
7832         * symtab.c (symtab_symbol_info): Fix typos.
7833
7834 2019-02-20  Tom Tromey  <tromey@adacore.com>
7835
7836         * findcmd.c (_initialize_mem_search): Use upper case for
7837         metasyntactic variables.
7838
7839 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7840
7841         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7842         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7843
7844 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7845
7846         * top.h (source_file_name): Change to std::string.
7847         * top.c (source_file_name): Likewise.
7848         (command_line_input): Adjust.
7849         * cli/cli-script.c (script_from_file): Adjust.
7850
7851 2019-02-19  Tom Tromey  <tromey@adacore.com>
7852
7853         * ravenscar-thread.c
7854         (ravenscar_thread_target::update_thread_list): Don't call
7855         ada_build_task_list.
7856         * ada-lang.h (ada_build_task_list): Don't declare.
7857         * ada-tasks.c (struct ada_tasks_inferior_data)
7858         <task_list_valid_p>: Now bool.
7859         (read_known_tasks, ada_task_list_changed)
7860         (ada_tasks_invalidate_inferior_data): Update.
7861         (read_known_tasks_array): Return bool.
7862         (read_known_tasks_list): Likewise.
7863         (read_known_tasks): Return void.
7864         (ada_build_task_list): Now static.
7865
7866 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7867
7868         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7869         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7870
7871 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7872
7873         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7874         variant for ada_tasks_pspace_data_handle and
7875         ada_tasks_inferior_data_handle.
7876         (ada_tasks_pspace_data_cleanup): New function.
7877         (ada_tasks_inferior_data_cleanup): New function.
7878
7879 2019-02-17  Tom Tromey  <tom@tromey.com>
7880
7881         * macrotab.h (macro_source_fullname): Return a std::string.
7882         * macrotab.c (macro_include, check_for_redefinition)
7883         (macro_undef, macro_lookup_definition, foreach_macro)
7884         (foreach_macro_in_scope): Update.
7885         (macro_source_fullname): Return a std::string.
7886         * macrocmd.c (show_pp_source_pos): Update.
7887
7888 2019-02-17  Tom Tromey  <tom@tromey.com>
7889
7890         * macrocmd.c (show_pp_source_pos): Style the file names.
7891
7892 2019-02-17  Tom Tromey  <tom@tromey.com>
7893
7894         PR tui/24197:
7895         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7896
7897 2019-02-17  Tom Tromey  <tom@tromey.com>
7898
7899         * ada-lang.c (user_select_syms): Use filtered printing.
7900         * utils.c (wrap_style): New global.
7901         (desired_style): Remove.
7902         (emit_style_escape): Add stream parameter.
7903         (set_output_style, reset_terminal_style, prompt_for_continue):
7904         Update.
7905         (flush_wrap_buffer): Only flush gdb_stdout.
7906         (wrap_here): Set wrap_style.
7907         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7908         treat escape sequences as a character.  Change when wrap buffer is
7909         flushed.
7910         (fputs_styled): Do not set the output style when the default is
7911         requested.
7912         * ui-style.h (struct ui_file_style) <is_default>: New method.
7913         * source.c (print_source_lines_base): Emit escape sequences in one
7914         piece.
7915
7916 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7917
7918         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7919         integers and enumeration types.
7920
7921 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7922
7923         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7924         instead of lookup_symbol_in_language
7925         (do_exact_match): New function.
7926         (ada_get_symbol_name_matcher): Return do_exact_match when
7927         doing a verbatim match.
7928
7929 2019-02-15  Tom Tromey  <tromey@adacore.com>
7930
7931         * ravenscar-thread.c (ravenscar_thread_target::resume)
7932         (ravenscar_thread_target::wait): Special case wildcard requests.
7933
7934 2019-02-15  Tom Tromey  <tromey@adacore.com>
7935
7936         * ravenscar-thread.c (base_ptid): Remove.
7937         (struct ravenscar_thread_target) <close>: New method.
7938         <m_base_ptid>: New member.
7939         <update_inferior_ptid, active_task, task_is_currently_active,
7940         runtime_initialized>: Declare methods.
7941         <ravenscar_thread_target>: Add constructor.
7942         (ravenscar_thread_target::task_is_currently_active)
7943         (ravenscar_thread_target::update_inferior_ptid)
7944         (ravenscar_runtime_initialized): Rename.  Now methods.
7945         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7946         (ravenscar_thread_target::update_thread_list): Update.
7947         (ravenscar_thread_target::active_task): Now method.
7948         (ravenscar_thread_target::store_registers)
7949         (ravenscar_thread_target::prepare_to_store)
7950         (ravenscar_thread_target::prepare_to_store)
7951         (ravenscar_thread_target::mourn_inferior): Update.
7952         (ravenscar_inferior_created): Use "new" to create target.
7953         (ravenscar_thread_target::get_ada_task_ptid): Update.
7954         (_initialize_ravenscar): Don't initialize base_ptid.
7955         (ravenscar_ops): Remove global.
7956
7957 2019-02-15  Tom Tromey  <tromey@adacore.com>
7958
7959         * target.h (push_target): Declare new overload.
7960         * target.c (push_target): New overload, taking an rvalue reference.
7961         * remote.c (remote_target::open_1): Use push_target overload.
7962         * corelow.c (core_target_open): Use push_target overload.
7963
7964 2019-02-15  Tom Tromey  <tromey@adacore.com>
7965
7966         * ravenscar-thread.c (is_ravenscar_task)
7967         (ravenscar_task_is_currently_active): Return bool.
7968         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7969         (_initialize_ravenscar): Remove "(void)".
7970         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7971         Return bool.
7972
7973 2019-02-15  Tom Tromey  <tromey@adacore.com>
7974
7975         * ravenscar-thread.c (ravenscar_runtime_initializer)
7976         (has_ravenscar_runtime, get_running_thread_id)
7977         (ravenscar_thread_target::resume): Fix indentation.
7978
7979 2019-02-15  Tom Tromey  <tromey@adacore.com>
7980
7981         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7982         from ravenscar_arch_ops.
7983         (sparc_ravenscar_ops::fetch_registers)
7984         (sparc_ravenscar_ops::store_registers): Now methods.
7985         (sparc_ravenscar_prepare_to_store): Remove.
7986         (sparc_ravenscar_ops): Redefine.
7987         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7988         methods and destructor.  Remove members.
7989         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7990         (ravenscar_thread_target::store_registers)
7991         (ravenscar_thread_target::prepare_to_store): Update.
7992         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7993         Remove.
7994         (struct ppc_ravenscar_powerpc_ops): Derive from
7995         ravenscar_arch_ops.
7996         (ppc_ravenscar_powerpc_ops::fetch_registers)
7997         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7998         (ppc_ravenscar_powerpc_ops): Redefine.
7999         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8000         (ppc_ravenscar_e500_ops::fetch_registers)
8001         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8002         (ppc_ravenscar_e500_ops): Redefine.
8003         * aarch64-ravenscar-thread.c
8004         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8005         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8006         (aarch64_ravenscar_fetch_registers)
8007         (aarch64_ravenscar_store_registers): Now methods.
8008         (aarch64_ravenscar_ops): Redefine.
8009
8010 2019-02-15  Tom Tromey  <tromey@adacore.com>
8011
8012         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8013         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8014         (ravenscar_thread_target::stopped_by_watchpoint)
8015         (ravenscar_thread_target::stopped_data_address)
8016         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8017
8018 2019-02-15  Tom Tromey  <tromey@adacore.com>
8019
8020         * ravenscar-thread.c: Fix some typos.
8021
8022 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8023             Tom Tromey  <tromey@adacore.com>
8024
8025         * ada-lang.c (ada_exception_sal): Change addr_string to a
8026         std::string.
8027         (create_ada_exception_catchpoint): Update.
8028
8029 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8030             Tom Tromey  <tromey@adacore.com>
8031
8032         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8033         (bp_location_ops): Remove.
8034         (base_breakpoint_allocate_location): Update.
8035         (free_bp_location): Update.
8036         * ada-lang.c (class ada_catchpoint_location)
8037         <ada_catchpoint_location>: Remove ops parameter.
8038         (ada_catchpoint_location_dtor): Remove.
8039         (ada_catchpoint_location_ops): Remove.
8040         (allocate_location_exception): Update.
8041         * breakpoint.h (struct bp_location_ops): Remove.
8042         (class bp_location) <bp_location>: Remove bp_location_ops
8043         parameter.
8044         <~bp_location>: Add destructor.
8045         <ops>: Remove.
8046
8047 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8048             Pedro Alves  <palves@redhat.com>
8049
8050         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8051         'PATH_MAX'.
8052
8053 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8054             Samuel Thibault  <samuel.thibault@gnu.org>
8055             Thomas Schwinge  <thomas@codesourcery.com>
8056
8057         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8058         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8059
8060 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8061
8062         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8063         (check_empty): Use "const char *".
8064
8065         * gnu-nat.c (gnu_nat_target::detach): Instead of
8066         'detach_inferior (pid)' call
8067         'detach_inferior (find_inferior_pid (pid))'.
8068
8069         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8070         'nat/fork-inferior.o'.
8071         * gnu-nat.c: #include "nat/fork-inferior.h".
8072
8073         * gnu-nat.c (gnu_nat_target::detach): Instead of
8074         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8075         * gnu-nat.h: #include "inf-child.h".
8076         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8077         'i386_gnu_nat_target::fetch_registers'.
8078         (gnu_store_registers): Rename/move to
8079         'i386_gnu_nat_target::store_registers'.
8080
8081         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8082         * gnu-nat.h (mach_thread_info): New function.
8083         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8084
8085         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8086
8087 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8088
8089         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8090
8091 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8092
8093         * windows-nat.c (windows_add_thread): Add new parameter
8094         "main_thread_p" with default value set to false.  Update
8095         function documentation as well as all callers.
8096         (windows_delete_thread): Likewise.
8097         (fake_create_process): Update call to windows_add_thread.
8098         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8099         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8100         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8101         call to windows_delete_thread.
8102
8103 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8104
8105         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8106
8107 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8108
8109         * symfile.c (find_separate_debug_file): Use canonical path of
8110         sysroot with child_path instead of gdb_sysroot if it is valid.
8111
8112 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8113
8114         * symfile.c (find_separate_debug_file): Use child_path to
8115         determine if an object file is under a sysroot.
8116
8117 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8118
8119         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8120         unittests/child-path-selftests.c.
8121         * common/pathstuff.c (child_path): New function.
8122         * common/pathstuff.h (child_path): New prototype.
8123         * unittests/child-path-selftests.c: New file.
8124
8125 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8126
8127         * symfile.c (find_separate_debug_file): Look for separate debug
8128         files in debug directories under the sysroot.
8129
8130 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8131
8132         * symtab.h (struct minimal_symbol data_p): New const method.
8133         (struct minimal_symbol text_p): Likewise.
8134         * symtab.c (output_source_filename): Use file name style
8135         to print file name.
8136         (print_symbol_info): Likewise.
8137         (print_msymbol_info): Use address style to print addresses.
8138         Use function name style to print executable text symbols.
8139         (expand_symtab_containing_pc): Use data_p.
8140         (find_pc_sect_compunit_symtab): Likewise.
8141
8142 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8143
8144         * breakpoint.c (describe_other_breakpoints): Use address style
8145         to print addresses.
8146         (say_where): Likewise.
8147
8148 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8149
8150         * ada-typeprint.c (print_func_type): Print function name
8151         style to print function name.
8152         * c-typeprint.c (c_print_type_1): Likewise.
8153
8154 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8155
8156         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8157         for execve.
8158
8159 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8160
8161         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8162         type_stack.
8163
8164 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8165
8166         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8167         TYPE_CODE_REF types.
8168
8169 2019-02-08  Jim Wilson  <jimw@sifive.com>
8170
8171         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8172         (riscv_linux_fregset): New.
8173         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8174
8175 2019-02-07  Tom Tromey  <tom@tromey.com>
8176
8177         * thread.c (thread_cancel_execution_command): Update.
8178         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8179         methods.
8180         (struct thread_fsm_ops): Remove.
8181         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8182         (thread_fsm_should_stop, thread_fsm_return_value)
8183         (thread_fsm_set_finished, thread_fsm_finished_p)
8184         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8185         Don't declare.
8186         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8187         * infrun.c (clear_proceed_status_thread)
8188         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8189         (print_stop_event): Update.
8190         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8191         Add constructor.
8192         (step_command_fsm_ops): Remove.
8193         (new_step_command_fsm): Remove.
8194         (step_1): Update.
8195         (step_command_fsm::should_stop): Rename from
8196         step_command_fsm_should_stop.
8197         (step_command_fsm::clean_up): Rename from
8198         step_command_fsm_clean_up.
8199         (step_command_fsm::do_async_reply_reason): Rename from
8200         step_command_fsm_async_reply_reason.
8201         (struct until_next_fsm): Inherit from thread_fsm.  Add
8202         constructor.
8203         (until_next_fsm_ops): Remove.
8204         (new_until_next_fsm): Remove.
8205         (until_next_fsm::should_stop): Rename from
8206         until_next_fsm_should_stop.
8207         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8208         (until_next_fsm::do_async_reply_reason): Rename from
8209         until_next_fsm_async_reply_reason.
8210         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8211         constructor.  Change type of breakpoint.
8212         (finish_command_fsm_ops): Remove.
8213         (new_finish_command_fsm): Remove.
8214         (finish_command_fsm::should_stop): Rename from
8215         finish_command_fsm_should_stop.
8216         (finish_command_fsm::clean_up): Rename from
8217         finish_command_fsm_clean_up.
8218         (finish_command_fsm::return_value): Rename from
8219         finish_command_fsm_return_value.
8220         (finish_command_fsm::do_async_reply_reason): Rename from
8221         finish_command_fsm_async_reply_reason.
8222         (finish_command): Update.
8223         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8224         Add constructor.
8225         (call_thread_fsm_ops): Remove.
8226         (call_thread_fsm::call_thread_fsm): Rename from
8227         new_call_thread_fsm.
8228         (call_thread_fsm::should_stop): Rename from
8229         call_thread_fsm_should_stop.
8230         (call_thread_fsm::should_notify_stop): Rename from
8231         call_thread_fsm_should_notify_stop.
8232         (run_inferior_call, call_function_by_hand_dummy): Update.
8233         * cli/cli-interp.c (should_print_stop_to_console): Update.
8234         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8235         Add constructor.  Change type of location_breakpoint,
8236         caller_breakpoint.
8237         (until_break_fsm_ops): Remove.
8238         (new_until_break_fsm): Remove.
8239         (until_break_fsm::should_stop): Rename from
8240         until_break_fsm_should_stop.
8241         (until_break_fsm::clean_up): Rename from
8242         until_break_fsm_clean_up.
8243         (until_break_fsm::do_async_reply_reason): Rename from
8244         until_break_fsm_async_reply_reason.
8245         (until_break_command): Update.
8246         * thread-fsm.c: Remove.
8247         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8248
8249 2019-02-07  Tom Tromey  <tom@tromey.com>
8250
8251         * yy-remap.h: Add include guard.
8252         * xtensa-tdep.h: Add include guard.
8253         * xcoffread.h: Rename include guard.
8254         * varobj-iter.h: Add include guard.
8255         * tui/tui.h: Rename include guard.
8256         * tui/tui-winsource.h: Rename include guard.
8257         * tui/tui-wingeneral.h: Rename include guard.
8258         * tui/tui-windata.h: Rename include guard.
8259         * tui/tui-win.h: Rename include guard.
8260         * tui/tui-stack.h: Rename include guard.
8261         * tui/tui-source.h: Rename include guard.
8262         * tui/tui-regs.h: Rename include guard.
8263         * tui/tui-out.h: Rename include guard.
8264         * tui/tui-layout.h: Rename include guard.
8265         * tui/tui-io.h: Rename include guard.
8266         * tui/tui-hooks.h: Rename include guard.
8267         * tui/tui-file.h: Rename include guard.
8268         * tui/tui-disasm.h: Rename include guard.
8269         * tui/tui-data.h: Rename include guard.
8270         * tui/tui-command.h: Rename include guard.
8271         * tic6x-tdep.h: Add include guard.
8272         * target/waitstatus.h: Rename include guard.
8273         * target/wait.h: Rename include guard.
8274         * target/target.h: Rename include guard.
8275         * target/resume.h: Rename include guard.
8276         * target-float.h: Rename include guard.
8277         * stabsread.h: Add include guard.
8278         * rs6000-tdep.h: Add include guard.
8279         * riscv-fbsd-tdep.h: Add include guard.
8280         * regformats/regdef.h: Rename include guard.
8281         * record.h: Rename include guard.
8282         * python/python.h: Rename include guard.
8283         * python/python-internal.h: Rename include guard.
8284         * python/py-stopevent.h: Rename include guard.
8285         * python/py-ref.h: Rename include guard.
8286         * python/py-record.h: Rename include guard.
8287         * python/py-record-full.h: Rename include guard.
8288         * python/py-record-btrace.h: Rename include guard.
8289         * python/py-instruction.h: Rename include guard.
8290         * python/py-events.h: Rename include guard.
8291         * python/py-event.h: Rename include guard.
8292         * procfs.h: Add include guard.
8293         * proc-utils.h: Add include guard.
8294         * p-lang.h: Add include guard.
8295         * or1k-tdep.h: Rename include guard.
8296         * observable.h: Rename include guard.
8297         * nto-tdep.h: Rename include guard.
8298         * nat/x86-linux.h: Rename include guard.
8299         * nat/x86-linux-dregs.h: Rename include guard.
8300         * nat/x86-gcc-cpuid.h: Add include guard.
8301         * nat/x86-dregs.h: Rename include guard.
8302         * nat/x86-cpuid.h: Rename include guard.
8303         * nat/ppc-linux.h: Rename include guard.
8304         * nat/mips-linux-watch.h: Rename include guard.
8305         * nat/linux-waitpid.h: Rename include guard.
8306         * nat/linux-ptrace.h: Rename include guard.
8307         * nat/linux-procfs.h: Rename include guard.
8308         * nat/linux-osdata.h: Rename include guard.
8309         * nat/linux-nat.h: Rename include guard.
8310         * nat/linux-namespaces.h: Rename include guard.
8311         * nat/linux-btrace.h: Rename include guard.
8312         * nat/glibc_thread_db.h: Rename include guard.
8313         * nat/gdb_thread_db.h: Rename include guard.
8314         * nat/gdb_ptrace.h: Rename include guard.
8315         * nat/fork-inferior.h: Rename include guard.
8316         * nat/amd64-linux-siginfo.h: Rename include guard.
8317         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8318         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8319         * nat/aarch64-linux.h: Rename include guard.
8320         * nat/aarch64-linux-hw-point.h: Rename include guard.
8321         * mn10300-tdep.h: Add include guard.
8322         * mips-linux-tdep.h: Add include guard.
8323         * mi/mi-parse.h: Rename include guard.
8324         * mi/mi-out.h: Rename include guard.
8325         * mi/mi-main.h: Rename include guard.
8326         * mi/mi-interp.h: Rename include guard.
8327         * mi/mi-getopt.h: Rename include guard.
8328         * mi/mi-console.h: Rename include guard.
8329         * mi/mi-common.h: Rename include guard.
8330         * mi/mi-cmds.h: Rename include guard.
8331         * mi/mi-cmd-break.h: Rename include guard.
8332         * m2-lang.h: Add include guard.
8333         * location.h: Rename include guard.
8334         * linux-record.h: Rename include guard.
8335         * linux-nat.h: Add include guard.
8336         * linux-fork.h: Add include guard.
8337         * i386-darwin-tdep.h: Rename include guard.
8338         * hppa-linux-offsets.h: Add include guard.
8339         * guile/guile.h: Rename include guard.
8340         * guile/guile-internal.h: Rename include guard.
8341         * gnu-nat.h: Rename include guard.
8342         * gdb-stabs.h: Rename include guard.
8343         * frv-tdep.h: Add include guard.
8344         * f-lang.h: Add include guard.
8345         * event-loop.h: Add include guard.
8346         * darwin-nat.h: Rename include guard.
8347         * cp-abi.h: Rename include guard.
8348         * config/sparc/nm-sol2.h: Rename include guard.
8349         * config/nm-nto.h: Rename include guard.
8350         * config/nm-linux.h: Add include guard.
8351         * config/i386/nm-i386gnu.h: Rename include guard.
8352         * config/djgpp/nl_types.h: Rename include guard.
8353         * config/djgpp/langinfo.h: Rename include guard.
8354         * compile/gcc-cp-plugin.h: Add include guard.
8355         * compile/gcc-c-plugin.h: Add include guard.
8356         * compile/compile.h: Rename include guard.
8357         * compile/compile-object-run.h: Rename include guard.
8358         * compile/compile-object-load.h: Rename include guard.
8359         * compile/compile-internal.h: Rename include guard.
8360         * compile/compile-cplus.h: Rename include guard.
8361         * compile/compile-c.h: Rename include guard.
8362         * common/xml-utils.h: Rename include guard.
8363         * common/x86-xstate.h: Rename include guard.
8364         * common/version.h: Rename include guard.
8365         * common/vec.h: Rename include guard.
8366         * common/tdesc.h: Rename include guard.
8367         * common/selftest.h: Rename include guard.
8368         * common/scoped_restore.h: Rename include guard.
8369         * common/scoped_mmap.h: Rename include guard.
8370         * common/scoped_fd.h: Rename include guard.
8371         * common/safe-iterator.h: Rename include guard.
8372         * common/run-time-clock.h: Rename include guard.
8373         * common/refcounted-object.h: Rename include guard.
8374         * common/queue.h: Rename include guard.
8375         * common/ptid.h: Rename include guard.
8376         * common/print-utils.h: Rename include guard.
8377         * common/preprocessor.h: Rename include guard.
8378         * common/pathstuff.h: Rename include guard.
8379         * common/observable.h: Rename include guard.
8380         * common/netstuff.h: Rename include guard.
8381         * common/job-control.h: Rename include guard.
8382         * common/host-defs.h: Rename include guard.
8383         * common/gdb_wait.h: Rename include guard.
8384         * common/gdb_vecs.h: Rename include guard.
8385         * common/gdb_unlinker.h: Rename include guard.
8386         * common/gdb_unique_ptr.h: Rename include guard.
8387         * common/gdb_tilde_expand.h: Rename include guard.
8388         * common/gdb_sys_time.h: Rename include guard.
8389         * common/gdb_string_view.h: Rename include guard.
8390         * common/gdb_splay_tree.h: Rename include guard.
8391         * common/gdb_setjmp.h: Rename include guard.
8392         * common/gdb_ref_ptr.h: Rename include guard.
8393         * common/gdb_optional.h: Rename include guard.
8394         * common/gdb_locale.h: Rename include guard.
8395         * common/gdb_assert.h: Rename include guard.
8396         * common/filtered-iterator.h: Rename include guard.
8397         * common/filestuff.h: Rename include guard.
8398         * common/fileio.h: Rename include guard.
8399         * common/environ.h: Rename include guard.
8400         * common/common-utils.h: Rename include guard.
8401         * common/common-types.h: Rename include guard.
8402         * common/common-regcache.h: Rename include guard.
8403         * common/common-inferior.h: Rename include guard.
8404         * common/common-gdbthread.h: Rename include guard.
8405         * common/common-exceptions.h: Rename include guard.
8406         * common/common-defs.h: Rename include guard.
8407         * common/common-debug.h: Rename include guard.
8408         * common/cleanups.h: Rename include guard.
8409         * common/buffer.h: Rename include guard.
8410         * common/btrace-common.h: Rename include guard.
8411         * common/break-common.h: Rename include guard.
8412         * cli/cli-utils.h: Rename include guard.
8413         * cli/cli-style.h: Rename include guard.
8414         * cli/cli-setshow.h: Rename include guard.
8415         * cli/cli-script.h: Rename include guard.
8416         * cli/cli-interp.h: Rename include guard.
8417         * cli/cli-decode.h: Rename include guard.
8418         * cli/cli-cmds.h: Rename include guard.
8419         * charset-list.h: Add include guard.
8420         * buildsym-legacy.h: Rename include guard.
8421         * bfin-tdep.h: Add include guard.
8422         * ax.h: Rename include guard.
8423         * arm-linux-tdep.h: Add include guard.
8424         * arm-fbsd-tdep.h: Add include guard.
8425         * arch/xtensa.h: Rename include guard.
8426         * arch/tic6x.h: Add include guard.
8427         * arch/i386.h: Add include guard.
8428         * arch/arm.h: Rename include guard.
8429         * arch/arm-linux.h: Rename include guard.
8430         * arch/arm-get-next-pcs.h: Rename include guard.
8431         * arch/amd64.h: Add include guard.
8432         * arch/aarch64-insn.h: Rename include guard.
8433         * arch-utils.h: Rename include guard.
8434         * annotate.h: Add include guard.
8435         * amd64-darwin-tdep.h: Rename include guard.
8436         * aarch64-linux-tdep.h: Add include guard.
8437         * aarch64-fbsd-tdep.h: Add include guard.
8438         * aarch32-linux-nat.h: Add include guard.
8439
8440 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8441
8442         * macrotab.c (macro_define_internal): New function that
8443         factorizes macro_define_object_internal and macro_define_function
8444         code.
8445         (macro_define_object_internal): Use macro_define_internal.
8446         (macro_define_function): Likewise.
8447
8448 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8449
8450         * macrocmd.c (extract_identifier): Return
8451         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8452         callers.
8453
8454 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8455
8456         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8457
8458 2019-02-05  Tom Tromey  <tom@tromey.com>
8459
8460         * target.c (target_stack::unpush): Move assertion earlier.
8461
8462 2019-01-30  Tom Tromey  <tom@tromey.com>
8463
8464         PR python/23615:
8465         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8466         (gdbpy_parse_and_eval): Likewise.
8467         * python/python-internal.h (gdbpy_allow_threads): New class.
8468
8469 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8470
8471         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8472         (aarch64_fbsd_fpregmap): Move earlier.
8473         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8474         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8475         instead of individual calls to trad_frame_set_reg_addr.
8476         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8477         earlier.
8478         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8479         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8480         instead of individual calls to trad_frame_set_reg_addr.
8481
8482 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8483
8484         * CONTRIBUTE: Replace contribution list with wiki link.
8485
8486 2019-01-25  Tom Tromey  <tom@tromey.com>
8487
8488         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8489
8490 2019-01-25  Tom Tromey  <tom@tromey.com>
8491
8492         * xtensa-linux-nat.c: Fix common/ includes.
8493         * xml-support.h: Fix common/ includes.
8494         * xml-support.c: Fix common/ includes.
8495         * x86-linux-nat.c: Fix common/ includes.
8496         * windows-nat.c: Fix common/ includes.
8497         * varobj.h: Fix common/ includes.
8498         * varobj.c: Fix common/ includes.
8499         * value.c: Fix common/ includes.
8500         * valops.c: Fix common/ includes.
8501         * utils.c: Fix common/ includes.
8502         * unittests/xml-utils-selftests.c: Fix common/ includes.
8503         * unittests/utils-selftests.c: Fix common/ includes.
8504         * unittests/unpack-selftests.c: Fix common/ includes.
8505         * unittests/tracepoint-selftests.c: Fix common/ includes.
8506         * unittests/style-selftests.c: Fix common/ includes.
8507         * unittests/string_view-selftests.c: Fix common/ includes.
8508         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8509         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8510         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8511         * unittests/rsp-low-selftests.c: Fix common/ includes.
8512         * unittests/parse-connection-spec-selftests.c: Fix common/
8513         includes.
8514         * unittests/optional-selftests.c: Fix common/ includes.
8515         * unittests/offset-type-selftests.c: Fix common/ includes.
8516         * unittests/observable-selftests.c: Fix common/ includes.
8517         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8518         * unittests/memrange-selftests.c: Fix common/ includes.
8519         * unittests/memory-map-selftests.c: Fix common/ includes.
8520         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8521         * unittests/function-view-selftests.c: Fix common/ includes.
8522         * unittests/environ-selftests.c: Fix common/ includes.
8523         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8524         * unittests/common-utils-selftests.c: Fix common/ includes.
8525         * unittests/cli-utils-selftests.c: Fix common/ includes.
8526         * unittests/array-view-selftests.c: Fix common/ includes.
8527         * ui-file.c: Fix common/ includes.
8528         * tui/tui-io.c: Fix common/ includes.
8529         * tracepoint.h: Fix common/ includes.
8530         * tracepoint.c: Fix common/ includes.
8531         * tracefile-tfile.c: Fix common/ includes.
8532         * top.h: Fix common/ includes.
8533         * top.c: Fix common/ includes.
8534         * thread.c: Fix common/ includes.
8535         * target/waitstatus.h: Fix common/ includes.
8536         * target/waitstatus.c: Fix common/ includes.
8537         * target.h: Fix common/ includes.
8538         * target.c: Fix common/ includes.
8539         * target-memory.c: Fix common/ includes.
8540         * target-descriptions.c: Fix common/ includes.
8541         * symtab.h: Fix common/ includes.
8542         * symfile.c: Fix common/ includes.
8543         * stap-probe.c: Fix common/ includes.
8544         * spu-linux-nat.c: Fix common/ includes.
8545         * sparc-nat.c: Fix common/ includes.
8546         * source.c: Fix common/ includes.
8547         * solib.c: Fix common/ includes.
8548         * solib-target.c: Fix common/ includes.
8549         * ser-unix.c: Fix common/ includes.
8550         * ser-tcp.c: Fix common/ includes.
8551         * ser-pipe.c: Fix common/ includes.
8552         * ser-base.c: Fix common/ includes.
8553         * selftest-arch.c: Fix common/ includes.
8554         * s12z-tdep.c: Fix common/ includes.
8555         * rust-exp.y: Fix common/ includes.
8556         * rs6000-aix-tdep.c: Fix common/ includes.
8557         * riscv-tdep.c: Fix common/ includes.
8558         * remote.c: Fix common/ includes.
8559         * remote-notif.h: Fix common/ includes.
8560         * remote-fileio.h: Fix common/ includes.
8561         * remote-fileio.c: Fix common/ includes.
8562         * regcache.h: Fix common/ includes.
8563         * regcache.c: Fix common/ includes.
8564         * record-btrace.c: Fix common/ includes.
8565         * python/python.c: Fix common/ includes.
8566         * python/py-type.c: Fix common/ includes.
8567         * python/py-inferior.c: Fix common/ includes.
8568         * progspace.h: Fix common/ includes.
8569         * producer.c: Fix common/ includes.
8570         * procfs.c: Fix common/ includes.
8571         * proc-api.c: Fix common/ includes.
8572         * printcmd.c: Fix common/ includes.
8573         * ppc-linux-nat.c: Fix common/ includes.
8574         * parser-defs.h: Fix common/ includes.
8575         * osdata.c: Fix common/ includes.
8576         * obsd-nat.c: Fix common/ includes.
8577         * nat/x86-linux.c: Fix common/ includes.
8578         * nat/x86-linux-dregs.c: Fix common/ includes.
8579         * nat/x86-dregs.h: Fix common/ includes.
8580         * nat/x86-dregs.c: Fix common/ includes.
8581         * nat/ppc-linux.c: Fix common/ includes.
8582         * nat/mips-linux-watch.h: Fix common/ includes.
8583         * nat/mips-linux-watch.c: Fix common/ includes.
8584         * nat/linux-waitpid.c: Fix common/ includes.
8585         * nat/linux-ptrace.h: Fix common/ includes.
8586         * nat/linux-ptrace.c: Fix common/ includes.
8587         * nat/linux-procfs.c: Fix common/ includes.
8588         * nat/linux-personality.c: Fix common/ includes.
8589         * nat/linux-osdata.c: Fix common/ includes.
8590         * nat/linux-namespaces.c: Fix common/ includes.
8591         * nat/linux-btrace.h: Fix common/ includes.
8592         * nat/linux-btrace.c: Fix common/ includes.
8593         * nat/fork-inferior.c: Fix common/ includes.
8594         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8595         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8596         * nat/aarch64-linux.c: Fix common/ includes.
8597         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8598         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8599         * namespace.h: Fix common/ includes.
8600         * mips-linux-tdep.c: Fix common/ includes.
8601         * minsyms.c: Fix common/ includes.
8602         * mi/mi-parse.h: Fix common/ includes.
8603         * mi/mi-main.c: Fix common/ includes.
8604         * mi/mi-cmd-env.c: Fix common/ includes.
8605         * memrange.h: Fix common/ includes.
8606         * memattr.c: Fix common/ includes.
8607         * maint.h: Fix common/ includes.
8608         * maint.c: Fix common/ includes.
8609         * main.c: Fix common/ includes.
8610         * machoread.c: Fix common/ includes.
8611         * location.c: Fix common/ includes.
8612         * linux-thread-db.c: Fix common/ includes.
8613         * linux-nat.c: Fix common/ includes.
8614         * linux-fork.c: Fix common/ includes.
8615         * inline-frame.c: Fix common/ includes.
8616         * infrun.c: Fix common/ includes.
8617         * inflow.c: Fix common/ includes.
8618         * inferior.h: Fix common/ includes.
8619         * inferior.c: Fix common/ includes.
8620         * infcmd.c: Fix common/ includes.
8621         * inf-ptrace.c: Fix common/ includes.
8622         * inf-child.c: Fix common/ includes.
8623         * ia64-linux-nat.c: Fix common/ includes.
8624         * i387-tdep.c: Fix common/ includes.
8625         * i386-tdep.c: Fix common/ includes.
8626         * i386-linux-tdep.c: Fix common/ includes.
8627         * i386-linux-nat.c: Fix common/ includes.
8628         * i386-go32-tdep.c: Fix common/ includes.
8629         * i386-fbsd-tdep.c: Fix common/ includes.
8630         * i386-fbsd-nat.c: Fix common/ includes.
8631         * guile/scm-type.c: Fix common/ includes.
8632         * guile/guile.c: Fix common/ includes.
8633         * go32-nat.c: Fix common/ includes.
8634         * gnu-nat.c: Fix common/ includes.
8635         * gdbthread.h: Fix common/ includes.
8636         * gdbarch-selftests.c: Fix common/ includes.
8637         * gdb_usleep.c: Fix common/ includes.
8638         * gdb_select.h: Fix common/ includes.
8639         * gdb_bfd.c: Fix common/ includes.
8640         * gcore.c: Fix common/ includes.
8641         * fork-child.c: Fix common/ includes.
8642         * findvar.c: Fix common/ includes.
8643         * fbsd-nat.c: Fix common/ includes.
8644         * event-top.c: Fix common/ includes.
8645         * event-loop.c: Fix common/ includes.
8646         * dwarf2read.c: Fix common/ includes.
8647         * dwarf2loc.c: Fix common/ includes.
8648         * dwarf2-frame.c: Fix common/ includes.
8649         * dwarf-index-cache.c: Fix common/ includes.
8650         * dtrace-probe.c: Fix common/ includes.
8651         * disasm-selftests.c: Fix common/ includes.
8652         * defs.h: Fix common/ includes.
8653         * csky-tdep.c: Fix common/ includes.
8654         * cp-valprint.c: Fix common/ includes.
8655         * cp-support.h: Fix common/ includes.
8656         * cp-support.c: Fix common/ includes.
8657         * corelow.c: Fix common/ includes.
8658         * completer.h: Fix common/ includes.
8659         * completer.c: Fix common/ includes.
8660         * compile/compile.c: Fix common/ includes.
8661         * compile/compile-loc2c.c: Fix common/ includes.
8662         * compile/compile-cplus-types.c: Fix common/ includes.
8663         * compile/compile-cplus-symbols.c: Fix common/ includes.
8664         * command.h: Fix common/ includes.
8665         * cli/cli-dump.c: Fix common/ includes.
8666         * cli/cli-cmds.c: Fix common/ includes.
8667         * charset.c: Fix common/ includes.
8668         * build-id.c: Fix common/ includes.
8669         * btrace.h: Fix common/ includes.
8670         * btrace.c: Fix common/ includes.
8671         * breakpoint.h: Fix common/ includes.
8672         * breakpoint.c: Fix common/ includes.
8673         * ax.h:
8674         (enum agent_op): Fix common/ includes.
8675         * ax-general.c (struct aop_map): Fix common/ includes.
8676         * ax-gdb.c: Fix common/ includes.
8677         * auxv.c: Fix common/ includes.
8678         * auto-load.c: Fix common/ includes.
8679         * arm-tdep.c: Fix common/ includes.
8680         * arch/riscv.c: Fix common/ includes.
8681         * arch/ppc-linux-common.c: Fix common/ includes.
8682         * arch/i386.c: Fix common/ includes.
8683         * arch/arm.c: Fix common/ includes.
8684         * arch/arm-linux.c: Fix common/ includes.
8685         * arch/arm-get-next-pcs.c: Fix common/ includes.
8686         * arch/amd64.c: Fix common/ includes.
8687         * arch/aarch64.c: Fix common/ includes.
8688         * arch/aarch64-insn.c: Fix common/ includes.
8689         * arch-utils.c: Fix common/ includes.
8690         * amd64-windows-tdep.c: Fix common/ includes.
8691         * amd64-tdep.c: Fix common/ includes.
8692         * amd64-sol2-tdep.c: Fix common/ includes.
8693         * amd64-obsd-tdep.c: Fix common/ includes.
8694         * amd64-nbsd-tdep.c: Fix common/ includes.
8695         * amd64-linux-tdep.c: Fix common/ includes.
8696         * amd64-linux-nat.c: Fix common/ includes.
8697         * amd64-fbsd-tdep.c: Fix common/ includes.
8698         * amd64-fbsd-nat.c: Fix common/ includes.
8699         * amd64-dicos-tdep.c: Fix common/ includes.
8700         * amd64-darwin-tdep.c: Fix common/ includes.
8701         * agent.c: Fix common/ includes.
8702         * ada-lang.h: Fix common/ includes.
8703         * ada-lang.c: Fix common/ includes.
8704         * aarch64-tdep.c: Fix common/ includes.
8705
8706 2019-01-25  Tom Tromey  <tom@tromey.com>
8707
8708         * common/create-version.sh: Use common/version.h.
8709
8710 2019-01-24  Pedro Alves  <palves@redhat.com>
8711
8712         * infrun.c (signal_stop, signal_print, signal_program)
8713         (signal_catch, signal_pass): Now arrays instead of pointers.
8714         (update_signals_program_target, do_target_resume)
8715         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8716         * linux-nat.c (linux_nat_target::pass_signals)
8717         (linux_nat_target::create_inferior, linux_nat_target::attach):
8718         Adjust.
8719         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8720         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8721         * procfs.c (procfs_target::pass_signals): Adjust.
8722         * record-full.c (record_full_target::resume): Adjust.
8723         * remote.c (remote_target::pass_signals)
8724         (remote_target::program_signals): Adjust.
8725         * target-debug.h (target_debug_print_signals): Now takes a
8726         gdb::array_view as parameter.  Adjust.
8727         * target.h (target_ops) <pass_signals, program_signals>: Replace
8728         pointer and length parameters with gdb::array_view.
8729         (target_pass_signals, target_program_signals): Likewise.
8730         * target-delegates.c: Regenerate.
8731
8732 2019-01-24  Pedro Alves  <palves@redhat.com>
8733
8734         * common/forward-scope-exit.h
8735         (forward_scope_exit::forward_scope_exit): Pass arguments to
8736         m_bind_function directly, instead of creating a std::bind and
8737         copying that.
8738
8739 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8740
8741         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8742         for static members.
8743         (pass_in_v_vfp_candidate): Likewise.
8744
8745 2019-01-23  Tom Tromey  <tom@tromey.com>
8746             Pedro Alves  <palves@redhat.com>
8747
8748         * regcache.c (class regcache_invalidator): Remove.
8749         (regcache::raw_write): Use make_scope_exit.
8750
8751 2019-01-23  Tom Tromey  <tom@tromey.com>
8752
8753         * ui-out.h (class ui_out_emit_type): Update comment.
8754
8755 2019-01-23  Tom Tromey  <tom@tromey.com>
8756
8757         * infrun.c (fetch_inferior_event): Update comment.
8758
8759 2019-01-23  Tom Tromey  <tom@tromey.com>
8760             Pedro Alves  <palves@redhat.com>
8761
8762         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8763         parameter.
8764         (fetch_inferior_event): Use SCOPE_EXIT.
8765
8766
8767 2019-01-23  Tom Tromey  <tom@tromey.com>
8768             Pedro Alves  <palves@redhat.com>
8769
8770         * infrun.c (disable_thread_events): Delete.
8771         (stop_all_threads): Use SCOPE_EXIT.
8772
8773 2019-01-23  Tom Tromey  <tom@tromey.com>
8774             Pedro Alves  <palves@redhat.com>
8775
8776         * symfile.c: Include forward-scope-exit.h.
8777         (clear_symtab_users_cleanup): Replace forward declaration with
8778         a FORWARD_SCOPE_EXIT.
8779         (syms_from_objfile_1): Use the forward_scope_exit and
8780         gdb::optional instead of cleanup_function.
8781         (reread_symbols): Use the forward_scope_exit instead of
8782         cleanup_function.
8783         (clear_symtab_users_cleanup): Remove function.
8784
8785 2019-01-23  Tom Tromey  <tom@tromey.com>
8786             Pedro Alves  <palves@redhat.com>
8787
8788         * linux-nat.c: Include scope-exit.h.
8789         (cleanup_target_stop): Remove.
8790         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8791         SCOPE_EXIT.
8792
8793 2019-01-23  Tom Tromey  <tom@tromey.com>
8794             Pedro Alves  <palves@redhat.com>
8795
8796         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8797         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8798
8799 2019-01-23  Tom Tromey  <tom@tromey.com>
8800             Andrew Burgess  <andrew.burgess@embecosm.com>
8801             Pedro Alves  <palves@redhat.com>
8802
8803         * infrun.c (fetch_inferior_event): Use scope_exit.
8804         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8805         * top.c (execute_command): Use scope_exit.
8806         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8807         * utils.c (do_bpstat_clear_actions_cleanup)
8808         (make_bpstat_clear_actions_cleanup): Remove.
8809
8810 2019-01-23  Tom Tromey  <tom@tromey.com>
8811             Pedro Alves  <palves@redhat.com>
8812
8813         * infrun.c: Include "common/scope-exit.h"
8814         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8815         (wait_for_inferior): Use SCOPE_EXIT.
8816         (fetch_inferior_event): Use scope_exit.
8817
8818 2019-01-23  Tom Tromey  <tom@tromey.com>
8819             Pedro Alves  <palves@redhat.com>
8820
8821         * breakpoint.c (create_breakpoint): Remove cleanup.
8822
8823 2019-01-23  Tom Tromey  <tom@tromey.com>
8824             Andrew Burgess  <andrew.burgess@embecosm.com>
8825             Pedro Alves  <palves@redhat.com>
8826
8827 2019-01-23  Pedro Alves  <palves@redhat.com>
8828
8829         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8830
8831 2019-01-23  Pedro Alves  <palves@redhat.com>
8832             Andrew Burgess  <andrew.burgess@embecosm.com>
8833
8834         * gdbthread.h: Include "common/forward-scope-exit.h".
8835         (scoped_finish_thread_state): Redefine custom class in terms of
8836         forward_scope_exit.
8837
8838 2019-01-23  Pedro Alves  <palves@redhat.com>
8839             Andrew Burgess  <andrew.burgess@embecosm.com>
8840
8841         * common/forward-scope-exit.h: New file.
8842
8843 2019-01-23  Pedro Alves  <palves@redhat.com>
8844             Andrew Burgess  <andrew.burgess@embecosm.com>
8845             Tom Tromey  <tom@tromey.com>
8846
8847         * common/scope-exit.h: New file.
8848
8849 2019-01-23  Pedro Alves  <palves@redhat.com>
8850
8851         * common/preprocessor.h (ESC): Rename to ...
8852         (ESC_PARENS): ... this.
8853         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8854         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8855
8856 2019-01-23  Tom Tromey  <tom@tromey.com>
8857
8858         * language.h (class scoped_switch_to_sym_language_if_auto):
8859         Initialize m_lang in both cases.
8860
8861 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8862
8863         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8864         with XCNEW.
8865
8866 2019-01-22  Tom Tromey  <tom@tromey.com>
8867
8868         * corelow.c: Do not include sys/file.h.
8869
8870 2019-01-22  Tom Tromey  <tom@tromey.com>
8871
8872         * tui/tui-wingeneral.h: Include gdb_curses.h.
8873
8874 2019-01-22  Tom Tromey  <tom@tromey.com>
8875
8876         * source-cache.h (class source_cache) <get_source_lines,
8877         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8878
8879 2019-01-22  Tom Tromey  <tom@tromey.com>
8880
8881         * remote-fileio.h (struct remote_target): Declare.
8882
8883 2019-01-22  Tom Tromey  <tom@tromey.com>
8884
8885         * python/py-arch.c: Do not include py-ref.h.
8886         * python/py-bpevent.c: Do not include py-ref.h.
8887         * python/py-cmd.c: Do not include py-ref.h.
8888         * python/py-continueevent.c: Do not include py-ref.h.
8889         * python/py-event.h: Do not include py-ref.h.
8890         * python/py-evtregistry.c: Do not include py-ref.h.
8891         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8892         * python/py-frame.c: Do not include py-ref.h.
8893         * python/py-framefilter.c: Do not include py-ref.h.
8894         * python/py-function.c: Do not include py-ref.h.
8895         * python/py-infevents.c: Do not include py-ref.h.
8896         * python/py-linetable.c: Do not include py-ref.h.
8897         * python/py-objfile.c: Do not include py-ref.h.
8898         * python/py-param.c: Do not include py-ref.h.
8899         * python/py-prettyprint.c: Do not include py-ref.h.
8900         * python/py-progspace.c: Do not include py-ref.h.
8901         * python/py-symbol.c: Do not include py-ref.h.
8902         * python/py-symtab.c: Do not include py-ref.h.
8903         * python/py-type.c: Do not include py-ref.h.
8904         * python/py-unwind.c: Do not include py-ref.h.
8905         * python/py-utils.c: Do not include py-ref.h.
8906         * python/py-value.c: Do not include py-ref.h.
8907         * python/py-varobj.c: Do not include py-ref.h.
8908         * python/py-xmethods.c: Do not include py-ref.h.
8909         * python/python.c: Do not include py-ref.h.
8910         * varobj.c: Do not include py-ref.h.
8911
8912 2019-01-22  Tom Tromey  <tom@tromey.com>
8913
8914         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8915         keyword for bcache.
8916
8917 2019-01-22  Tom Tromey  <tom@tromey.com>
8918
8919         * compile/compile-cplus-types.c: Remove a comment by #include.
8920
8921 2019-01-22  Tom Tromey  <tom@tromey.com>
8922
8923         * compile/gcc-c-plugin.h: Include compile-internal.h.
8924
8925 2019-01-22  Tom Tromey  <tom@tromey.com>
8926
8927         * stabsread.c (EXTERN): Do not define.
8928         (symnum, next_symbol_text_func, processing_gcc_compilation)
8929         (within_function, global_sym_chain, global_stabs)
8930         (previous_stab_code, this_object_header_files)
8931         (n_this_object_header_files)
8932         (n_allocated_this_object_header_files): Define.
8933         * stabsread.h (EXTERN): Never define.  Use "extern".
8934
8935 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8936
8937         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8938         history_value.
8939
8940 2019-01-21  Tom Tromey  <tom@tromey.com>
8941
8942         * ui-out.c: Fix includes.
8943         * tui/tui-source.c: Fix includes.
8944         * target.c: Fix includes.
8945         * remote.c: Fix includes.
8946         * regcache.c: Fix includes.
8947         * python/py-block.c: Fix includes.
8948         * printcmd.c: Fix includes.
8949         * or1k-tdep.c: Fix includes.
8950         * mi/mi-main.c: Fix includes.
8951         * m32r-tdep.c: Fix includes.
8952         * csky-tdep.c: Fix includes.
8953         * compile/compile-cplus-types.c: Fix includes.
8954         * cli/cli-interp.c: Fix includes.
8955
8956 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8957
8958         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8959         for padding.
8960
8961 2019-01-16  Tom Tromey  <tom@tromey.com>
8962
8963         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8964         earlier.
8965         (struct objfile) <msymbols_range>: Move from top level.
8966         <msymbols>: New method.
8967         (class objfile_msymbols): Remove.
8968         * symtab.c (default_collect_symbol_completion_matches_break_on):
8969         Update.
8970         * symmisc.c (dump_msymbols): Update.
8971         * stabsread.c (scan_file_globals): Update.
8972         * objc-lang.c (info_selectors_command, info_classes_command)
8973         (find_methods): Update.
8974         * minsyms.c (find_solib_trampoline_target): Update.
8975         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8976         * coffread.c (coff_symfile_read): Update.
8977         * ada-lang.c (ada_lookup_simple_minsym)
8978         (ada_collect_symbol_completion_matches): Update.
8979
8980 2019-01-16  Tom Tromey  <tom@tromey.com>
8981
8982         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8983         type.  Remove no-argument constructor.
8984         <iterator::operator++>: Simplify.
8985         <begin>: Update.
8986         <end>: Use minimal_symbol_count.
8987
8988 2019-01-16  Tom Tromey  <tom@tromey.com>
8989
8990         * objfiles.h (struct objfile) <psymtabs>: New method.
8991         (class objfile_psymtabs): Remove.
8992         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8993         typedef.
8994         <range>: New method.
8995         (require_partial_symbols): Change return type.
8996         * psymtab.c (require_partial_symbols)
8997         (psym_expand_symtabs_matching): Update.
8998         * mdebugread.c (parse_partial_symbols): Update.
8999         * dbxread.c (dbx_end_psymtab): Update.
9000
9001 2019-01-15  Tom Tromey  <tom@tromey.com>
9002
9003         * symtab.c (lookup_objfile_from_block)
9004         (lookup_symbol_in_objfile_symtabs)
9005         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9006         (find_line_symtab, info_sources_command)
9007         (default_collect_symbol_completion_matches_break_on)
9008         (make_source_files_completion_list): Update.
9009         * symmisc.c (print_objfile_statistics, dump_objfile)
9010         (maintenance_print_symbols, maintenance_info_symtabs)
9011         (maintenance_check_symtabs, maintenance_info_line_tables):
9012         Update.
9013         * source.c (select_source_symtab)
9014         (forget_cached_source_info_for_objfile): Update.
9015         * objfiles.h (class objfile_compunits): Remove.
9016         (struct objfile) <compunits_range>: New typedef.
9017         (compunits): New method.
9018         * objfiles.c (objfile_relocate1): Update.
9019         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9020         * maint.c (count_symtabs_and_blocks): Update.
9021         * linespec.c (iterate_over_all_matching_symtabs): Update.
9022         * cp-support.c (add_symbol_overload_list_qualified): Update.
9023         * coffread.c (coff_symtab_read): Update.
9024         * ada-lang.c (add_nonlocal_symbols)
9025         (ada_collect_symbol_completion_matches)
9026         (ada_add_global_exceptions): Update.
9027
9028 2019-01-15  Tom Tromey  <tom@tromey.com>
9029
9030         * progspace.h (program_space) <objfiles_safe_range>: New
9031         typedef.
9032         <objfiles_safe>: New method.
9033         * objfiles.h (class all_objfiles_safe): Remove.
9034         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9035         * jit.c (jit_inferior_exit_hook): Update.
9036
9037 2019-01-17  Tom Tromey  <tom@tromey.com>
9038
9039         * progspace.h (program_space) <objfiles_range>: New typedef.
9040         <objfiles>: New method.
9041         <objfiles_head>: Rename from objfiles.
9042         (object_files): Update.
9043         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9044         * guile/scm-pretty-print.c
9045         (ppscm_find_pretty_printer_from_objfiles): Update.
9046         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9047         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9048         Update.
9049         * python/py-progspace.c (pspy_get_objfiles): Update.
9050         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9051         Update.
9052         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9053         (objfpy_lookup_objfile_by_build_id): Update.
9054         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9055         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9056         Update.
9057         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9058         (expand_symtab_containing_pc, lookup_objfile_from_block)
9059         (lookup_static_symbol, basic_lookup_transparent_type)
9060         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9061         (find_line_symtab, info_sources_command)
9062         (default_collect_symbol_completion_matches_break_on)
9063         (make_source_files_completion_list, find_main_name): Update.
9064         * symmisc.c (print_symbol_bcache_statistics)
9065         (print_objfile_statistics, maintenance_print_symbols)
9066         (maintenance_print_msymbols, maintenance_print_objfiles)
9067         (maintenance_info_symtabs, maintenance_check_symtabs)
9068         (maintenance_expand_symtabs, maintenance_info_line_tables):
9069         Update.
9070         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9071         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9072         (map_overlay_command, unmap_overlay_command)
9073         (simple_overlay_update, expand_symtabs_matching)
9074         (map_symbol_filenames): Update.
9075         * symfile-debug.c (set_debug_symfile): Update.
9076         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9077         Update.
9078         * source.c (select_source_symtab, forget_cached_source_info):
9079         Update.
9080         * solib.c (solib_read_symbols): Update.
9081         * solib-spu.c (append_ocl_sos): Update.
9082         * psymtab.c (maintenance_print_psymbols)
9083         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9084         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9085         * printcmd.c (info_symbol_command): Update.
9086         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9087         Update.
9088         * objfiles.h (class all_objfiles): Remove.
9089         * objfiles.c (have_partial_symbols, have_full_symbols)
9090         (have_minimal_symbols, qsort_cmp, update_section_map)
9091         (shared_objfile_contains_address_p)
9092         (default_iterate_over_objfiles_in_search_order): Update.
9093         * objc-lang.c (info_selectors_command, info_classes_command)
9094         (find_methods): Update.
9095         * minsyms.c (find_solib_trampoline_target): Update.
9096         * maint.c (maintenance_info_sections)
9097         (maintenance_translate_address, count_symtabs_and_blocks):
9098         Update.
9099         * main.c (captured_main_1): Update.
9100         * linux-thread-db.c (try_thread_db_load_from_pdir)
9101         (has_libpthread): Update.
9102         * linespec.c (iterate_over_all_matching_symtabs)
9103         (search_minsyms_for_name): Update.
9104         * jit.c (jit_find_objf_with_entry_addr): Update.
9105         * hppa-tdep.c (find_unwind_entry)
9106         (hppa_lookup_stub_minimal_symbol): Update.
9107         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9108         Update.
9109         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9110         (elf_gnu_ifunc_resolve_by_got): Update.
9111         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9112         * dwarf-index-write.c (save_gdb_index_command): Update.
9113         * cp-support.c (add_symbol_overload_list_qualified): Update.
9114         * breakpoint.c (create_overlay_event_breakpoint)
9115         (create_longjmp_master_breakpoint)
9116         (create_std_terminate_master_breakpoint)
9117         (create_exception_master_breakpoint): Update.
9118         * blockframe.c (find_pc_partial_function): Update.
9119         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9120         (ada_collect_symbol_completion_matches)
9121         (ada_add_global_exceptions): Update.
9122
9123 2019-01-17  Tom Tromey  <tom@tromey.com>
9124
9125         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9126         declare VEC.
9127         (solib_target_parse_libraries): Change return type.
9128         (library_list_start_segment, library_list_start_section)
9129         (library_list_end_library, library_list_start_library); Update.
9130         (solib_target_free_library_list): Remove.
9131         (solib_target_parse_libraries): Remove cleanup.  Change return
9132         type.
9133         (solib_target_current_sos): Update.
9134
9135 2019-01-17  Tom Tromey  <tromey@bapiya>
9136
9137         * valprint.c: Replace "the the" with "the".
9138         * symtab.c: Replace "the the" with "the".
9139         * solib.c: Replace "the the" with "the".
9140         * solib-dsbt.c: Replace "the the" with "the".
9141         * linespec.c: Replace "the the" with "the".
9142         * dwarf2loc.h: Replace "the the" with "the".
9143         * amd64-windows-tdep.c: Replace "the the" with "the".
9144         * aarch64-tdep.c: Replace "the the" with "the".
9145
9146 2019-01-16  Keith Seitz  <keiths@redhat.com>
9147
9148         PR gdb/23773
9149         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9150         <builder>: Rename to ..
9151         <m_builder>: ... this and make private.
9152         (dwarf2_cu::get_builder): New method.  Change all users of
9153         `builder' to use this method.
9154         (dwarf2_start_symtab): Move to ...
9155         (dwarf2_cu::start_symtab): ... here.  Update all callers
9156         (setup_type_unit_groups): Move to ...
9157         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9158         callers.
9159         (dwarf2_cu::reset_builder): New method.
9160         (process_full_compunit, process_full_type_unit): Use
9161         dwarf2_cu::reset_builder.
9162         (follow_die_offset): Record the ancestor CU if it is different
9163         from the followed DIE's CU.
9164         (follow_die_sig_1): Likewise.
9165
9166 2019-01-15  Tom Tromey  <tom@tromey.com>
9167
9168         * remote.c (class remote_state) <buf>: Now a char_vector.
9169         <buf_size>: Remove.
9170         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9171         parameter.
9172         (remote_target::getpkt_or_notif_sane_1)
9173         (remote_target::getpkt_sane)
9174         (remote_target::getpkt_or_notif_sane): Likewise.
9175         (class remote_target) <putpkt>: New overload.
9176         (remote_target::read_frame): Change type of "buf_p".  Remove
9177         sizeof_p parameter.
9178         (packet_ok): New overload.
9179         (packet_check_result): New overload.
9180         Update all uses.
9181
9182 2019-01-14  Tom Tromey  <tom@tromey.com>
9183
9184         * remote-notif.c (handle_notification, remote_notif_ack)
9185         (remote_notif_parse): Make "buf" const.
9186         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9187         const.
9188         (remote_notif_parse, remote_notif_ack, handle_notification):
9189         Likewise.
9190         * remote.c (remote_notif_stop_parse): Make "buf" const.
9191         (remote_target::remote_parse_stop_reply): Make "buf" const.
9192         (remote_notif_stop_ack): Make "buf" const.
9193
9194 2019-01-14  Tom Tromey  <tom@tromey.com>
9195
9196         * remote.c (remote_console_output): Make parameter const.
9197
9198 2019-01-14  Tom Tromey  <tom@tromey.com>
9199
9200         * target-debug.h (target_debug_print_signals): Constify.
9201         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9202         * procfs.c (procfs_target::pass_signals): Update.
9203         * linux-nat.c (linux_nat_target::pass_signals): Update.
9204         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9205         * target-delegates.c: Rebuild.
9206         * remote.c (remote_target::program_signals): Update.
9207         (remote_target::pass_signals): Update.
9208         * target.c (target_pass_signals): Constify argument.
9209         (target_program_signals): Likewise.
9210         * target.h (struct target_ops) <pass_signals, program_signals>:
9211         Constify argument.
9212         (target_pass_signals, target_program_signals): Constify argument.
9213
9214 2019-01-14  Tom Tromey  <tom@tromey.com>
9215
9216         PR tui/28819:
9217         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9218
9219 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9220
9221         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9222         field.
9223         * rs6000-tdep.c: Include reggroups.h.
9224         (IS_V_ALIAS_PSEUDOREG): Define.
9225         (rs6000_register_name): Return names for the "vX" aliases.
9226         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9227         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9228         aliases.  Call default_register_reggroup_p for all other
9229         pseudo-registers.
9230         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9231         New functions.
9232         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9233         Handle "vX" aliases.
9234         (v_alias_pseudo_register_collect): New function.
9235         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9236         (rs6000_gdbarch_init): Initialize "vX" aliases as
9237         pseudo-registers.  Restore registration of
9238         rs6000_pseudo_register_reggroup_p with
9239         set_tdesc_pseudo_register_reggroup_p.
9240
9241 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9242
9243         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9244         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9245         set_gdbarch_num_pseudo_regs.
9246
9247 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9248
9249         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9250         Remove arg prefixname, add do_set and do_show.
9251         Add member functions set_list and show_list.
9252         * cli/cli-style.c (class cli_style_option): Update accordingly.
9253         (style_set_list): Move to file scope.
9254         (style_show_list): Likewise.
9255         (set_style): Call help_list.
9256         (show_style): Call cmd_show_list.
9257         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9258         Update to use the new macro.
9259
9260 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9261
9262         * ada-lang.c (_initialize_ada_language): Expand the help text
9263         for the "catch exception" command.
9264
9265 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9266
9267         * symtab.c (matching_obj_sections): Initialize obj,
9268         declare it closer to its usage.
9269
9270 2019-01-10  Tom Tromey  <tom@tromey.com>
9271
9272         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9273         (basic_inf_threads_range): Remove.
9274         (inf_threads_range, inf_non_exited_threads_range)
9275         (safe_inf_threads_range): Use next_adapter.
9276
9277 2019-01-10  Keith Seitz  <keiths@redhat.com>
9278
9279         PR gdb/23712
9280         PR symtab/23010
9281         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9282         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9283
9284 2019-01-10  Keith Seitz  <keiths@redhat.com>
9285
9286         PR gdb/23712
9287         PR symtab/23010
9288         * dictionary.c (pending_to_vector): Remove.
9289         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9290         Remove _1 suffix, replacing functions of the same name.  Update
9291         all callers.
9292         (dict_create_hashed, dict_create_hashed_expandable)
9293         (dict_create_linear, dict_create_linear_expandable, dict_free)
9294         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9295         Make functions static.
9296
9297 2019-01-10  Keith Seitz  <keiths@redhat.com>
9298
9299         PR gdb/23712
9300         PR symtab/23010
9301         * dictionary.h (struct dictionary): Replace declaration with
9302         multidictionary.
9303         (dict_create_hashed, dict_create_hashed_expandable)
9304         (dict_create_linear, dict_create_linear_expandable)
9305         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9306         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9307         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9308         taking multidictionary argument.
9309         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9310         * block.h (struct block) <dict>: Change to multidictionary
9311         and rename `multidict'.
9312         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9313         symmisc.c: Update all dictionary references to multidictionary.
9314
9315 2019-01-10  Keith Seitz  <keiths@redhat.com>
9316
9317         PR gdb/23712
9318         PR symtab/23010
9319         * dictionary.c: Include unordered_map.
9320         (pending_to_vector): New function.
9321         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9322         Rewrite the non-"_1" functions to take vector instead
9323         of linked list.
9324         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9325         "new" _1 versions of the same name.
9326         (multidictionary): Define.
9327         (std::hash<enum language): New definition.
9328         (collate_pending_symbols_by_language, mdict_create_hashed)
9329         (mdict_create_hashed_expandable, mdict_create_linear)
9330         (mdict_create_linear_expandable, mdict_free)
9331         (find_language_dictionary, create_new_language_dictionary)
9332         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9333         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9334         (mdict_size, mdict_empty): New functions.
9335         * dictionary.h (mdict_iterator): Define.
9336
9337 2019-01-10  Pedro Alves  <palves@redhat.com>
9338
9339         * breakpoint.c (read_uploaded_action)
9340         (create_tracepoint_from_upload): Adjust to use
9341         gdb::unique_xmalloc_ptr.
9342         * ctf.c (ctf_write_uploaded_tp):
9343         (SET_ARRAY_FIELD): Use emplace_back.
9344         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9345         * tracefile-tfile.c (tfile_write_uploaded_tp):
9346         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9347         gdb::unique_xmalloc_ptr.
9348         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9349         at_string, cond_string, cmd_strings>: Replace char pointers
9350         with gdb::unique_xmalloc_ptr.
9351
9352 2019-01-10  Pedro Alves  <palves@redhat.com>
9353
9354         * solib-target.c (library_list_start_library): Don't xstrdup name.
9355
9356 2019-01-10  Pedro Alves  <palves@redhat.com>
9357
9358         * mdebugread.c (parse_partial_symbols): Use
9359         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9360
9361 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9362
9363         * linux-fork.c (scoped_switch_fork_info)
9364         <~scoped_switch_fork_info>: Fix incorrect variable name.
9365
9366 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9367
9368         * linux-fork.c (scoped_switch_fork_info)
9369         <scoped_switch_fork_info>: Make explicit.
9370         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9371
9372 2019-01-10  Tom Tromey  <tom@tromey.com>
9373
9374         * objfiles.h (objfile::reset_psymtabs): Update.
9375         * objfiles.c (objfile::objfile): Update.
9376         * psymtab.h (psymtab_storage::obstack): Update.
9377         (psymtab_storage::m_obstack): Use gdb::optional.
9378         (class psymtab_storage): Update comment.  Remove objfile
9379         parameter.
9380         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9381
9382 2019-01-10  Tom Tromey  <tom@tromey.com>
9383
9384         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9385         <free_psymtabs>: Now private.
9386         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9387         (allocate_psymtab): Use new method.
9388
9389 2019-01-10  Tom Tromey  <tom@tromey.com>
9390
9391         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9392         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9393         * mdebugread.c (parse_partial_symbols): Use
9394         allocate_dependencies.
9395         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9396         allocate_dependencies.
9397         (process_psymtab_comp_unit_reader)
9398         (build_type_psymtab_dependencies): Likewise.
9399         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9400
9401 2019-01-10  Tom Tromey  <tom@tromey.com>
9402
9403         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9404         PSYMBOL_SET_LANGUAGE.
9405         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9406
9407 2019-01-10  Tom Tromey  <tom@tromey.com>
9408
9409         * psymtab.h (psymtab_storage::obstack): New method.
9410         <m_obstack>: Rename from obstack; now private.
9411         * psymtab.c (psymtab_storage): Update.
9412         * dwarf2read.c (create_addrmap_from_index)
9413         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9414         Update.
9415
9416 2019-01-10  Tom Tromey  <tom@tromey.com>
9417
9418         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9419         * objfiles.h (objfile::reset_psymtabs): New method.
9420
9421 2019-01-10  Tom Tromey  <tom@tromey.com>
9422
9423         * symmisc.c (print_symbol_bcache_statistics): Update.
9424         (print_objfile_statistics): Update.
9425         * symfile.c (reread_symbols): Update.
9426         * psymtab.h (class psymtab_storage): New.
9427         * psymtab.c (psymtab_storage): New constructor.
9428         (~psymtab_storage): New destructor.
9429         (require_partial_symbols): Update.
9430         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9431         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9432         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9433         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9434         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9435         (start_psymtab_common, end_psymtab_common)
9436         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9437         (allocate_psymtab): Update.
9438         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9439         Update.
9440         (dump_psymtab_addrmap, maintenance_print_psymbols)
9441         (maintenance_check_psymtabs): Update.
9442         (class objfile_psymtabs): Move to objfiles.h.
9443         * psympriv.h (discard_psymtab): Now inline.
9444         (psymtab_discarder::psymtab_discarder): Update.
9445         (psymtab_discarder::~psymtab_discarder): Update.
9446         (ALL_OBJFILE_PSYMTABS): Rewrite.
9447         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9448         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9449         Remove fields.
9450         <partial_symtabs>: New field.
9451         (class objfile_psymtabs): Move from psymtab.h.  Update.
9452         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9453         psymbol_cache.
9454         (objfile::~objfile): Don't destroy psymbol_cache.
9455         * mdebugread.c (parse_partial_symbols): Update.
9456         * dwarf2read.c (create_addrmap_from_index)
9457         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9458         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9459         (add_partial_subprogram, dwarf2_ranges_read): Update.
9460         * dwarf-index-write.c (write_address_map)
9461         (write_one_signatured_type, recursively_write_psymbols)
9462         (class debug_names, class debug_names, write_psymtabs_to_index):
9463         Update.
9464
9465 2019-01-10  Tom Tromey  <tom@tromey.com>
9466
9467         * symtab.h (SYMBOL_SET_NAMES): Update.
9468         (symbol_set_names): Update.
9469         (MSYMBOL_SET_NAMES): Update.
9470         * symtab.c (symbol_set_names): Change argument to be an
9471         objfile_per_bfd_storage.
9472         * psymtab.c (add_psymbol_to_bcache): Update.
9473         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9474
9475 2019-01-10  Tom Tromey  <tom@tromey.com>
9476
9477         * symtab.c (create_demangled_names_hash): Change argument to be an
9478         objfile_per_bfd_storage.
9479         (symbol_set_names): Update.
9480
9481 2019-01-10  Tom Tromey  <tom@tromey.com>
9482
9483         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9484         init_psymbol_list.
9485         * psymtab.c (init_psymbol_list): Do nothing if already called.
9486         * psympriv.h (init_psymbol_list): Add comment.
9487         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9488         init_psymbol_list.
9489         * dbxread.c (dbx_symfile_read): Unconditionally call
9490         init_psymbol_list.
9491
9492 2019-01-10  Tom Tromey  <tom@tromey.com>
9493
9494         * xcoffread.c (scan_xcoff_symtab): Update.
9495         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9496         "where".
9497         * mdebugread.c (parse_partial_symbols)
9498         (handle_psymbol_enumerators): Update.
9499         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9500         * dbxread.c (read_dbx_symtab): Update.
9501         * psympriv.h (psymbol_placement): New enum.
9502         (add_psymbol_to_list): Update.
9503
9504 2019-01-10  Tom Tromey  <tom@tromey.com>
9505
9506         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9507         static_psymbols parameters.
9508         (scan_xcoff_symtab): Update.
9509         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9510         static_psymbols parameters.
9511         * psympriv.h (start_psymtab_common): Update.
9512         * mdebugread.c (parse_partial_symbols): Update.
9513         * dwarf2read.c (create_partial_symtab): Update.
9514         * dbxread.c (read_dbx_symtab): Update.
9515         (start_psymtab): Remove global_psymbols and static_psymbols
9516         parameters.
9517
9518 2019-01-10  Tom Tromey  <tom@tromey.com>
9519
9520         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9521         * psymtab.c (allocate_psymtab): Add comment.
9522         * psympriv.h (allocate_psymtab): Add comment.
9523         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9524         initializations.
9525         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9526
9527 2019-01-10  Tom Tromey  <tom@tromey.com>
9528
9529         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9530         Don't declare.
9531         * mipsread.c: Include mdebugread.h.
9532         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9533         Declare.
9534         * elfread.c: Include mdebugread.h.
9535
9536 2019-01-09  Tom Tromey  <tom@tromey.com>
9537
9538         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9539         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9540         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9541         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9542         (psym_lookup_symbol, psym_find_last_source_symtab)
9543         (psym_forget_cached_source_info, psym_print_stats)
9544         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9545         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9546         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9547         (psym_find_compunit_symtab_by_address)
9548         (maintenance_print_psymbols, maintenance_info_psymtabs)
9549         (maintenance_check_psymtabs): Use ranged for.
9550         * psymtab.h (class objfile_psymtabs): New.
9551         (require_partial_symbols): Return objfile_psymtabs.
9552         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9553
9554 2019-01-09  Tom Tromey  <tom@tromey.com>
9555
9556         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9557         (find_pc_mapped_section, list_overlays_command)
9558         (map_overlay_command, unmap_overlay_command)
9559         (simple_overlay_update): Use all_objfiles.
9560         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9561         * printcmd.c (info_symbol_command): Use all_objfiles.
9562         * objfiles.h (ALL_OBJSECTIONS): Remove.
9563         * maint.c (maintenance_translate_address): Use all_objfiles.
9564         * gcore.c (gcore_create_callback): Use all_objfiles.
9565         (objfile_find_memory_regions): Likewise.
9566
9567 2019-01-09  Tom Tromey  <tom@tromey.com>
9568
9569         * symtab.c (find_line_symtab, info_sources_command)
9570         (make_source_files_completion_list): Use objfile_compunits.
9571         * source.c (select_source_symtab): Use objfile_compunits.
9572         * objfiles.h (struct objfile): Update comment.
9573         (ALL_OBJFILES): Remove.
9574         (ALL_FILETABS): Remove.
9575         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9576         objfile_compunits.
9577
9578 2019-01-09  Tom Tromey  <tom@tromey.com>
9579
9580         * symmisc.c (print_objfile_statistics, dump_objfile)
9581         (maintenance_print_symbols): Use compunit_filetabs.
9582         * source.c (forget_cached_source_info_for_objfile): Use
9583         compunit_filetabs.
9584         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9585         (ALL_FILETABS): Use compunit_filetabs.
9586         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9587         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9588
9589 2019-01-09  Tom Tromey  <tom@tromey.com>
9590
9591         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9592         (compunit_filetabs): New.
9593         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9594         compunit_filetabs.
9595         (info_sources_command, make_source_files_completion_list): Remove
9596         declaration.
9597         * symmisc.c (print_objfile_statistics, dump_objfile)
9598         (maintenance_print_symbols): Remove declaration.
9599         (maintenance_info_symtabs): Use compunit_filetabs.
9600         (maintenance_info_line_tables): Likewise.
9601         * source.c (select_source_symtab): Change local variable name.
9602         (forget_cached_source_info_for_objfile): Remove declaration.
9603         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9604         * objfiles.c (objfile_relocate1): Remove declaration.
9605         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9606         declaration.
9607         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9608         * coffread.c (coff_symtab_read): Remove declaration.
9609         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9610         compunit_filetabs.
9611
9612 2019-01-09  Tom Tromey  <tom@tromey.com>
9613
9614         * symtab.c (lookup_objfile_from_block)
9615         (find_pc_sect_compunit_symtab, search_symbols)
9616         (default_collect_symbol_completion_matches_break_on): Use
9617         objfile_compunits.
9618         * objfiles.h (ALL_COMPUNITS): Remove.
9619         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9620         * cp-support.c (add_symbol_overload_list_qualified): Use
9621         objfile_compunits.
9622         * ada-lang.c (ada_collect_symbol_completion_matches)
9623         (ada_add_global_exceptions): Use objfile_compunits.
9624
9625 2019-01-09  Tom Tromey  <tom@tromey.com>
9626
9627         * source.c (select_source_symtab)
9628         (forget_cached_source_info_for_objfile): Remove declaration.
9629         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9630         declaration.
9631         * maint.c (count_symtabs_and_blocks): Remove declaration.
9632         * cp-support.c (add_symbol_overload_list_qualified): Remove
9633         declaration.
9634         * coffread.c (coff_symtab_read): Remove declaration.
9635         * symtab.c (lookup_symbol_in_objfile_symtabs)
9636         (basic_lookup_transparent_type_1): Use objfile_compunits.
9637         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9638         (info_sources_command, search_symbols)
9639         (default_collect_symbol_completion_matches_break_on)
9640         (make_source_files_completion_list): Remove declaration.
9641         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9642         (ada_collect_symbol_completion_matches)
9643         (ada_add_global_exceptions): Remove declaration.
9644         * linespec.c (iterate_over_all_matching_symtabs): Use
9645         objfile_compunits.
9646         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9647         (class objfile_compunits): New.
9648         (ALL_COMPUNITS): Use objfile_compunits.
9649         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9650         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9651         objfile_compunits.
9652         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9653
9654 2019-01-09  Tom Tromey  <tom@tromey.com>
9655
9656         * symtab.c (search_symbols)
9657         (default_collect_symbol_completion_matches_break_on): Use
9658         objfile_msymbols.
9659         * ada-lang.c (ada_lookup_simple_minsym)
9660         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9661         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9662         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9663         objfile_msymbols.
9664         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9665         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9666         * objc-lang.c (find_methods): Use objfile_msymbols.
9667         (info_selectors_command, info_classes_command): Likewise.
9668         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9669         * objfiles.h (class objfile_msymbols): New.
9670         (ALL_OBJFILE_MSYMBOLS): Remove.
9671         (ALL_MSYMBOLS): Remove.
9672
9673 2019-01-09  Tom Tromey  <tom@tromey.com>
9674
9675         * common/next-iterator.h (next_adapter): Add Iterator template
9676         parameter.
9677         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9678         (class all_objfiles_safe): New.
9679         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9680         * objfiles.c (put_objfile_before): Update comment.
9681         (add_separate_debug_objfile): Likewise.
9682         (free_all_objfiles): Use all_objfiles_safe.
9683         (objfile_purge_solibs): Likewise.
9684
9685 2019-01-09  Tom Tromey  <tom@tromey.com>
9686
9687         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9688         (expand_symtab_containing_pc, lookup_static_symbol)
9689         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9690         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9691         all_objfiles.
9692         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9693         * breakpoint.c (create_overlay_event_breakpoint)
9694         (create_longjmp_master_breakpoint)
9695         (create_std_terminate_master_breakpoint)
9696         (create_exception_master_breakpoint): Use all_objfiles.
9697         * linux-thread-db.c (try_thread_db_load_from_pdir)
9698         (has_libpthread): Use all_objfiles.
9699         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9700         * linespec.c (iterate_over_all_matching_symtabs)
9701         (search_minsyms_for_name): Use all_objfiles.
9702         * maint.c (maintenance_info_sections): Use all_objfiles.
9703         * main.c (captured_main_1): Use all_objfiles.
9704         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9705         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9706         * guile/scm-pretty-print.c
9707         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9708         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9709         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9710         (maintenance_print_msymbols): Use all_objfiles.
9711         * source.c (select_source_symtab): Use all_objfiles.
9712         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9713         * symfile.c (remove_symbol_file_command)
9714         (expand_symtabs_matching, map_symbol_filenames): Use
9715         all_objfiles.
9716         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9717         all_objfiles.
9718         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9719         * objc-lang.c (find_methods): Use all_objfiles.
9720         * objfiles.c (have_partial_symbols, have_full_symbols)
9721         (have_minimal_symbols, qsort_cmp)
9722         (default_iterate_over_objfiles_in_search_order): Use
9723         all_objfiles.
9724         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9725         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9726         (maintenance_check_psymtabs): Use all_objfiles.
9727         (ALL_PSYMTABS): Remove.
9728         * compile/compile-object-run.c (do_module_cleanup): Use
9729         all_objfiles.
9730         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9731         * cp-support.c (add_symbol_overload_list_qualified): Use
9732         all_objfiles.
9733         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9734         Use all_objfiles.
9735         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9736         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9737         all_objfiles.
9738         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9739         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9740         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9741         Uses all_objfiles.
9742         * solib.c (solib_read_symbols): Use all_objfiles
9743
9744 2019-01-09  Tom Tromey  <tom@tromey.com>
9745
9746         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9747         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9748         all_objfiles.
9749         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9750         * symmisc.c (print_symbol_bcache_statistics)
9751         (print_objfile_statistics, maintenance_print_objfiles)
9752         (maintenance_info_symtabs, maintenance_check_symtabs)
9753         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9754         all_objfiles.
9755         * source.c (forget_cached_source_info): Use all_objfiles.
9756         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9757         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9758         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9759         * objfiles.c (update_section_map): Use all_objfiles.
9760         (shared_objfile_contains_address_p): Likewise.
9761         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9762         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9763
9764 2019-01-09  Tom Tromey  <tom@tromey.com>
9765
9766         * common/next-iterator.h: New file.
9767         * objfiles.h (class all_objfiles): New.
9768         (struct objfile_iterator): New.
9769
9770 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9771
9772         * NEWS: Move the description of the changed "frame", "select-frame",
9773          and "info frame" commands to the Changed commands section.
9774
9775 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9776
9777         * gdbtypes.c (check_stub_method_group): Remove handling of old
9778         mangling schemes.
9779         * linespec.c (find_methods): Likewise.
9780         * stabsread.c (read_member_functions): Likewise.
9781         * valops.c (search_struct_method): Likewise.
9782         (value_struct_elt_for_reference): Likewise.
9783         * NEWS: Mention this change.
9784
9785 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9786
9787         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9788         print_source_lines.
9789         * source.c (print_source_lines_base): Update line number check.
9790         (print_source_lines): New function.
9791         (source_lines_range::source_lines_range): New function.
9792         * source.h (class source_lines_range): New class.
9793         (print_source_lines): New declaration.
9794
9795 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9796
9797         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9798
9799 2019-01-08  Tom Tromey  <tom@tromey.com>
9800             Simon Marchi  <simon.marchi@ericsson.com>
9801
9802         PR gdb/24060
9803         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9804         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9805         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9806         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9807         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9808         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9809
9810 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9811
9812         * source.c (select_source_symtab): Move header comment to
9813         declaration in source.h.
9814         (forget_cached_source_info_for_objfile): Likewise.
9815         (forget_cached_source_info): Likewise.
9816         (identify_source_line): Likewise.
9817         * source.h (identify_source_line): Move declaration from symtab.h
9818         and add comment from source.c
9819         (print_source_lines): Likewise.
9820         (forget_cached_source_info_for_objfile): Likewise.
9821         (forget_cached_source_info): Likewise.
9822         (select_source_symtab): Likewise.
9823         (enum print_source_lines_flag): Move definition from symtab.h.
9824         * symtab.h (identify_source_line): Move declaration to source.h.
9825         (print_source_lines): Likewise.
9826         (forget_cached_source_info_for_objfile): Likewise.
9827         (forget_cached_source_info): Likewise.
9828         (select_source_symtab): Likewise.
9829         (enum print_source_lines_flag): Move definition to source.h.
9830         * tui/tui-hooks.c: Add 'source.h' include.
9831
9832 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9833
9834         * source.c (print_source_lines_base): Handle requests to print
9835         reverse line number sequences, and guard against empty lines
9836         string.
9837
9838 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9839
9840         * source.c (print_source_lines_base): Fix skip of '\r' if next
9841         character is '\n'.
9842
9843 2019-01-06  Tom Tromey  <tom@tromey.com>
9844
9845         * c-exp.y (struct c_parse_state) <macro_original_text,
9846         expansion_obstack>: New member.
9847         (macro_original_text, expansion_obstack): Remove globals.
9848         (scan_macro_expansion, scanning_macro_expansion)
9849         (finished_macro_expansion): Update.
9850         (scan_macro_cleanup): Remove.
9851         (yylex, c_parse): Update.
9852
9853 2019-01-06  Tom Tromey  <tom@tromey.com>
9854
9855         * c-exp.y (struct c_parse_state) <strings>: New member.
9856         (operator_stoken): Update.
9857
9858 2019-01-06  Tom Tromey  <tom@tromey.com>
9859
9860         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9861         (union type_stack_elt) <typelist_val>: Now a pointer to
9862         std::vector.
9863         (type_stack_cleanup): Don't declare.
9864         (push_typelist): Update.
9865         * parse.c (pop_typelist): Return a std::vector.
9866         (push_typelist): Take a std::vector.
9867         (follow_types): Update.  Do not free args.
9868         (type_stack_cleanup): Remove.
9869         * c-exp.y (struct c_parse_state): New.
9870         (cpstate): New global.
9871         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9872         (nonempty_typelist): Update.
9873         (func_mod): Create a new vector.
9874         (c_parse): Create a c_parse_state.
9875         (check_parameter_typelist): Do not delete params.
9876         (function_method): Update.  Do not delete type_list.
9877
9878 2019-01-06  Tom Tromey  <tom@tromey.com>
9879
9880         PR gdb/28155:
9881         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9882         check_typedef.
9883         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9884         (print_return_value): Likewise.
9885
9886 2019-01-05  Tom Tromey  <tom@tromey.com>
9887
9888         * contrib/cleanup_check.py: Remove.
9889         * contrib/gcc-with-excheck: Remove.
9890         * contrib/exsummary.py: Remove.
9891         * contrib/excheck.py: Remove.
9892
9893 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9894
9895         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9896         NULL. Initialize tpprev to NULL instead of assigning it
9897         to NULL on the next statement.
9898         * windows-nat.c (windows_delete_thread): Remove check for
9899         main_thread_id before printing thread exit notifications.
9900         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9901         Remove thread ID check against main_thread_id.
9902         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9903         windows_delete_thread.
9904         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9905
9906 2019-01-04  Tom Tromey  <tom@tromey.com>
9907
9908         * compile/compile.c (_initialize_compile): Use upper case for
9909         metasyntactic variables.
9910         * symmisc.c (_initialize_symmisc): Use upper case for
9911         metasyntactic variables.
9912         * psymtab.c (_initialize_psymtab): Use upper case for
9913         metasyntactic variables.
9914         * demangle.c (demangle_command): Use upper case for metasyntactic
9915         variables.
9916         (_initialize_demangler): Likewise.
9917         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9918         variables.
9919
9920 2019-01-03  Tom Tromey  <tom@tromey.com>
9921
9922         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9923
9924 2019-01-03  Tom Tromey  <tom@tromey.com>
9925
9926         * python/py-symtab.c (salpy_str): Update.
9927         (struct salpy_sal_object) <symtab>: Now a PyObject.
9928         (salpy_dealloc): Update.
9929         (del_objfile_sal): Use gdbpy_ref.
9930
9931 2019-01-03  Tom Tromey  <tom@tromey.com>
9932
9933         * python/py-type.c (convert_field): Use new_reference.  Return
9934         gdbpy_ref.
9935         (make_fielditem): Return gdbpy_ref.
9936         (typy_fields): Update.
9937         (typy_getitem): Update.
9938         (field_name): Return gdbpy_ref.  Use new_reference.
9939         (typy_iterator_iternext): Update.
9940
9941 2019-01-03  Tom Tromey  <tom@tromey.com>
9942
9943         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9944
9945 2019-01-03  Tom Tromey  <tom@tromey.com>
9946
9947         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9948         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9949         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9950         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9951         (pspy_set_type_printers): Likewise.
9952         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9953         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9954         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9955         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9956         (objfpy_set_type_printers): Likewise.
9957
9958 2019-01-03  Tom Tromey  <tom@tromey.com>
9959
9960         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9961         (gdbpy_print_stack): Use gdbpy_err_fetch.
9962         * python/python-internal.h (class gdbpy_err_fetch): New class.
9963         (class gdbpy_enter) <m_error_type, m_error_value,
9964         m_error_traceback>: Remove.
9965         <m_error>: New member.
9966         (gdbpy_exception_to_string): Don't declare.
9967         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9968         * python/py-value.c (convert_value_from_python): Use
9969         gdbpy_err_fetch.
9970         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9971         gdbpy_exception_to_string.
9972         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9973         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9974         gdbpy_err_fetch.
9975
9976 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9977
9978         * linux-nat.c (delete_lwp_cleanup): Delete.
9979         (struct lwp_deleter): New struct.
9980         (lwp_info_up): New typedef.
9981         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9982         lwp_info_up.
9983
9984 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9985
9986         * linux-fork.c (class scoped_switch_fork_info): New class.
9987         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9988
9989 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9990
9991         * valops.c (find_overload_match): Remove use of null_cleanup, and
9992         calls to do_cleanups.
9993
9994 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9995
9996         * compile/compile-cplus-types.c
9997         (compile_cplus_instance::decl_name): Handle changes to
9998         cp_func_name.
9999         * cp-support.c (cp_func_name): Update header comment, update
10000         return type.
10001         * cp-support.h (cp_func_name): Update return type in declaration.
10002         * valops.c (find_overload_match): Move temp_func local to top
10003         level of function and change its type.  Use temp_func to hold and
10004         delete temporary string obtained from cp_func_name.
10005
10006 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10007
10008         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10009         gdb::char_vector, remove cleanup, and update uses of `msg`.
10010
10011 2019-01-03  Jim Wilson  <jimw@sifive.com>
10012
10013         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10014
10015 2019-01-02  Tom Tromey  <tom@tromey.com>
10016
10017         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10018         (tdesc_parse_xml): Remove cleanups.
10019         * target-descriptions.h (make_cleanup_free_target_description):
10020         Don't declare.
10021         (target_desc_deleter): New struct.
10022         (target_desc_up): New typedef.
10023         * target-descriptions.c (target_desc_deleter::operator()): Rename
10024         from free_target_description.
10025         (make_cleanup_free_target_description): Remove.
10026
10027 2019-01-02  Tom Tromey  <tom@tromey.com>
10028
10029         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10030         constructor, destructor.
10031         (linespec_parser): Remove typedef.
10032         (~linespec_parser): Rename from linespec_parser_delete.
10033         (linespec_lex_to_end, linespec_complete_label)
10034         (linespec_complete): Update.
10035         (decode_line_full): Remove cleanups.
10036         (decode_line_1): Update.
10037
10038 2019-01-02  Tom Tromey  <tom@tromey.com>
10039
10040         * python/python-internal.h (inferior_to_inferior_object): Change
10041         return type.
10042         * python/py-exitedevent.c (create_exited_event_object): Update.
10043         * python/py-inferior.c (inferior_to_inferior_object): Return
10044         gdbpy_ref.
10045         (python_new_inferior, python_inferior_deleted)
10046         (thread_to_thread_object, delete_thread_object)
10047         (build_inferior_list, gdbpy_selected_inferior): Update.
10048         * python/py-infthread.c (create_thread_object): Update.  Also fail
10049         if inferior_to_inferior_object fails.
10050
10051 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10052
10053         * inferior.h (class inferior) <displaced_step_state>: New field.
10054         * infrun.h (struct displaced_step_state): Move here from
10055         infrun.c.  Initialize fields, add constructor.
10056         <inf>: Remove field.
10057         <reset>: New method.
10058         * infrun.c (struct displaced_step_inferior_state): Move to
10059         infrun.h.
10060         (displaced_step_inferior_states): Remove.
10061         (get_displaced_stepping_state): Adust.
10062         (displaced_step_in_progress_any_inferior): Adjust.
10063         (displaced_step_in_progress_thread): Adjust.
10064         (displaced_step_in_progress): Adjust.
10065         (add_displaced_stepping_state): Remove.
10066         (get_displaced_step_closure_by_addr): Adjust.
10067         (remove_displaced_stepping_state): Remove.
10068         (infrun_inferior_exit): Call displaced_step_state.reset.
10069         (use_displaced_stepping): Don't check for NULL.
10070         (displaced_step_prepare_throw): Call
10071         get_displaced_stepping_state.
10072         (displaced_step_fixup): Don't check for NULL.
10073         (prepare_for_detach): Don't check for NULL.
10074
10075 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10076
10077         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10078          in case of call that did not complete.
10079
10080 2019-01-02  Andrey Utkin  <autkin@undo.io>
10081
10082         * symfile.c (find_separate_debug_file): Fix search of debug files for
10083         remote debuggee.
10084
10085 2019-01-02  Tom Tromey  <tom@tromey.com>
10086
10087         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10088         indentation.
10089         * python/py-frame.c (frapy_older): Remove cast.
10090         (frapy_newer): Likewise.
10091         * python/py-breakpoint.c (local_setattro): Remove cast.
10092         * python/py-arch.c (archpy_name): Remove local variable.
10093         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10094
10095 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10096
10097         * unittests/basic_string_view/element_access/char/empty.cc:
10098         Fix year range in copyright header.
10099
10100 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10101
10102         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10103         Delete.
10104         <operator==>: Update with for removed field.
10105         <hash>: Likewise.
10106         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10107         <isa_features>: ...this.
10108         <abi_features>: New field.
10109         (riscv_isa_flen): Update comment.
10110         (riscv_abi_xlen): New declaration.
10111         (riscv_abi_flen): New declaration.
10112         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10113         isa_features.
10114         (riscv_abi_xlen): New function.
10115         (riscv_isa_flen): Update to get answer from isa_features.
10116         (riscv_abi_flen): New function.
10117         (riscv_has_fp_abi): Update to get answer from abi_features.
10118         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10119         xlen and flen.
10120         (riscv_call_info) <xlen, flen>: Update comment.
10121         (riscv_call_arg_struct): Remove invalid assertions
10122         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10123         is removed.
10124         (riscv_gdbarch_init): Gather isa features and abi features
10125         separately, ensure both match on the gdbarch when reusing an old
10126         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10127         a target with 64-bit float hardware.
10128
10129 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10130
10131         * source.c (search_command_helper): Stop reverse search
10132         when line 1 has been searched.
10133
10134 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10135
10136         * record-full.c (record_full_base_target::close): Rewrite
10137         record_full_core_buf_list free logic.
10138
10139 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10140
10141         * break-catch-syscall.c (print_one_catch_syscall): xfree
10142         the last text.
10143
10144 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10145
10146         * top.c (print_gdb_version): Update Copyright year in version
10147         message.
10148
10149 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10150
10151         Update copyright year range in all GDB files.
10152
10153 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10154
10155         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10156
10157 For older changes see ChangeLog-2018.
10158 \f
10159 Local Variables:
10160 mode: change-log
10161 left-margin: 8
10162 fill-column: 74
10163 version-control: never
10164 coding: utf-8
10165 End:
10166