gdb/ChangeLog

   1 2019-02-20  Tom Tromey  <tromey@adacore.com>
   2
   3         * findcmd.c (_initialize_mem_search): Use upper case for
   4         metasyntactic variables.
   5
   6 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
   7
   8         * aarch64-tdep.c (aarch64_add_reggroups): New function.
   9         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  10
  11 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  12
  13         * top.h (source_file_name): Change to std::string.
  14         * top.c (source_file_name): Likewise.
  15         (command_line_input): Adjust.
  16         * cli/cli-script.c (script_from_file): Adjust.
  17
  18 2019-02-19  Tom Tromey  <tromey@adacore.com>
  19
  20         * ravenscar-thread.c
  21         (ravenscar_thread_target::update_thread_list): Don't call
  22         ada_build_task_list.
  23         * ada-lang.h (ada_build_task_list): Don't declare.
  24         * ada-tasks.c (struct ada_tasks_inferior_data)
  25         <task_list_valid_p>: Now bool.
  26         (read_known_tasks, ada_task_list_changed)
  27         (ada_tasks_invalidate_inferior_data): Update.
  28         (read_known_tasks_array): Return bool.
  29         (read_known_tasks_list): Likewise.
  30         (read_known_tasks): Return void.
  31         (ada_build_task_list): Now static.
  32
  33 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  34
  35         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  36         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
  37
  38 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  39
  40         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
  41         variant for ada_tasks_pspace_data_handle and
  42         ada_tasks_inferior_data_handle.
  43         (ada_tasks_pspace_data_cleanup): New function.
  44         (ada_tasks_inferior_data_cleanup): New function.
  45
  46 2019-02-17  Tom Tromey  <tom@tromey.com>
  47
  48         * macrotab.h (macro_source_fullname): Return a std::string.
  49         * macrotab.c (macro_include, check_for_redefinition)
  50         (macro_undef, macro_lookup_definition, foreach_macro)
  51         (foreach_macro_in_scope): Update.
  52         (macro_source_fullname): Return a std::string.
  53         * macrocmd.c (show_pp_source_pos): Update.
  54
  55 2019-02-17  Tom Tromey  <tom@tromey.com>
  56
  57         * macrocmd.c (show_pp_source_pos): Style the file names.
  58
  59 2019-02-17  Tom Tromey  <tom@tromey.com>
  60
  61         PR tui/24197:
  62         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
  63
  64 2019-02-17  Tom Tromey  <tom@tromey.com>
  65
  66         * ada-lang.c (user_select_syms): Use filtered printing.
  67         * utils.c (wrap_style): New global.
  68         (desired_style): Remove.
  69         (emit_style_escape): Add stream parameter.
  70         (set_output_style, reset_terminal_style, prompt_for_continue):
  71         Update.
  72         (flush_wrap_buffer): Only flush gdb_stdout.
  73         (wrap_here): Set wrap_style.
  74         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  75         treat escape sequences as a character.  Change when wrap buffer is
  76         flushed.
  77         (fputs_styled): Do not set the output style when the default is
  78         requested.
  79         * ui-style.h (struct ui_file_style) <is_default>: New method.
  80         * source.c (print_source_lines_base): Emit escape sequences in one
  81         piece.
  82
  83 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  84
  85         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
  86         integers and enumeration types.
  87
  88 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  89
  90         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
  91         instead of lookup_symbol_in_language
  92         (do_exact_match): New function.
  93         (ada_get_symbol_name_matcher): Return do_exact_match when
  94         doing a verbatim match.
  95
  96 2019-02-15  Tom Tromey  <tromey@adacore.com>
  97
  98         * ravenscar-thread.c (ravenscar_thread_target::resume)
  99         (ravenscar_thread_target::wait): Special case wildcard requests.
 100
 101 2019-02-15  Tom Tromey  <tromey@adacore.com>
 102
 103         * ravenscar-thread.c (base_ptid): Remove.
 104         (struct ravenscar_thread_target) <close>: New method.
 105         <m_base_ptid>: New member.
 106         <update_inferior_ptid, active_task, task_is_currently_active,
 107         runtime_initialized>: Declare methods.
 108         <ravenscar_thread_target>: Add constructor.
 109         (ravenscar_thread_target::task_is_currently_active)
 110         (ravenscar_thread_target::update_inferior_ptid)
 111         (ravenscar_runtime_initialized): Rename.  Now methods.
 112         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 113         (ravenscar_thread_target::update_thread_list): Update.
 114         (ravenscar_thread_target::active_task): Now method.
 115         (ravenscar_thread_target::store_registers)
 116         (ravenscar_thread_target::prepare_to_store)
 117         (ravenscar_thread_target::prepare_to_store)
 118         (ravenscar_thread_target::mourn_inferior): Update.
 119         (ravenscar_inferior_created): Use "new" to create target.
 120         (ravenscar_thread_target::get_ada_task_ptid): Update.
 121         (_initialize_ravenscar): Don't initialize base_ptid.
 122         (ravenscar_ops): Remove global.
 123
 124 2019-02-15  Tom Tromey  <tromey@adacore.com>
 125
 126         * target.h (push_target): Declare new overload.
 127         * target.c (push_target): New overload, taking an rvalue reference.
 128         * remote.c (remote_target::open_1): Use push_target overload.
 129         * corelow.c (core_target_open): Use push_target overload.
 130
 131 2019-02-15  Tom Tromey  <tromey@adacore.com>
 132
 133         * ravenscar-thread.c (is_ravenscar_task)
 134         (ravenscar_task_is_currently_active): Return bool.
 135         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 136         (_initialize_ravenscar): Remove "(void)".
 137         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 138         Return bool.
 139
 140 2019-02-15  Tom Tromey  <tromey@adacore.com>
 141
 142         * ravenscar-thread.c (ravenscar_runtime_initializer)
 143         (has_ravenscar_runtime, get_running_thread_id)
 144         (ravenscar_thread_target::resume): Fix indentation.
 145
 146 2019-02-15  Tom Tromey  <tromey@adacore.com>
 147
 148         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 149         from ravenscar_arch_ops.
 150         (sparc_ravenscar_ops::fetch_registers)
 151         (sparc_ravenscar_ops::store_registers): Now methods.
 152         (sparc_ravenscar_prepare_to_store): Remove.
 153         (sparc_ravenscar_ops): Redefine.
 154         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 155         methods and destructor.  Remove members.
 156         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 157         (ravenscar_thread_target::store_registers)
 158         (ravenscar_thread_target::prepare_to_store): Update.
 159         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 160         Remove.
 161         (struct ppc_ravenscar_powerpc_ops): Derive from
 162         ravenscar_arch_ops.
 163         (ppc_ravenscar_powerpc_ops::fetch_registers)
 164         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 165         (ppc_ravenscar_powerpc_ops): Redefine.
 166         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 167         (ppc_ravenscar_e500_ops::fetch_registers)
 168         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 169         (ppc_ravenscar_e500_ops): Redefine.
 170         * aarch64-ravenscar-thread.c
 171         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 172         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 173         (aarch64_ravenscar_fetch_registers)
 174         (aarch64_ravenscar_store_registers): Now methods.
 175         (aarch64_ravenscar_ops): Redefine.
 176
 177 2019-02-15  Tom Tromey  <tromey@adacore.com>
 178
 179         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 180         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 181         (ravenscar_thread_target::stopped_by_watchpoint)
 182         (ravenscar_thread_target::stopped_data_address)
 183         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 184
 185 2019-02-15  Tom Tromey  <tromey@adacore.com>
 186
 187         * ravenscar-thread.c: Fix some typos.
 188
 189 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 190             Tom Tromey  <tromey@adacore.com>
 191
 192         * ada-lang.c (ada_exception_sal): Change addr_string to a
 193         std::string.
 194         (create_ada_exception_catchpoint): Update.
 195
 196 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 197             Tom Tromey  <tromey@adacore.com>
 198
 199         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 200         (bp_location_ops): Remove.
 201         (base_breakpoint_allocate_location): Update.
 202         (free_bp_location): Update.
 203         * ada-lang.c (class ada_catchpoint_location)
 204         <ada_catchpoint_location>: Remove ops parameter.
 205         (ada_catchpoint_location_dtor): Remove.
 206         (ada_catchpoint_location_ops): Remove.
 207         (allocate_location_exception): Update.
 208         * breakpoint.h (struct bp_location_ops): Remove.
 209         (class bp_location) <bp_location>: Remove bp_location_ops
 210         parameter.
 211         <~bp_location>: Add destructor.
 212         <ops>: Remove.
 213
 214 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 215             Pedro Alves  <palves@redhat.com>
 216
 217         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 218         'PATH_MAX'.
 219
 220 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 221             Samuel Thibault  <samuel.thibault@gnu.org>
 222             Thomas Schwinge  <thomas@codesourcery.com>
 223
 224         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 225         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 226
 227 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 228
 229         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 230         (check_empty): Use "const char *".
 231
 232         * gnu-nat.c (gnu_nat_target::detach): Instead of
 233         'detach_inferior (pid)' call
 234         'detach_inferior (find_inferior_pid (pid))'.
 235
 236         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 237         'nat/fork-inferior.o'.
 238         * gnu-nat.c: #include "nat/fork-inferior.h".
 239
 240         * gnu-nat.c (gnu_nat_target::detach): Instead of
 241         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 242         * gnu-nat.h: #include "inf-child.h".
 243         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 244         'i386_gnu_nat_target::fetch_registers'.
 245         (gnu_store_registers): Rename/move to
 246         'i386_gnu_nat_target::store_registers'.
 247
 248         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 249         * gnu-nat.h (mach_thread_info): New function.
 250         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 251
 252         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 253
 254 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 255
 256         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 257
 258 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 259
 260         * windows-nat.c (windows_add_thread): Add new parameter
 261         "main_thread_p" with default value set to false.  Update
 262         function documentation as well as all callers.
 263         (windows_delete_thread): Likewise.
 264         (fake_create_process): Update call to windows_add_thread.
 265         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 266         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 267         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 268         call to windows_delete_thread.
 269
 270 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 271
 272         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 273
 274 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 275
 276         * symfile.c (find_separate_debug_file): Use canonical path of
 277         sysroot with child_path instead of gdb_sysroot if it is valid.
 278
 279 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 280
 281         * symfile.c (find_separate_debug_file): Use child_path to
 282         determine if an object file is under a sysroot.
 283
 284 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 285
 286         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 287         unittests/child-path-selftests.c.
 288         * common/pathstuff.c (child_path): New function.
 289         * common/pathstuff.h (child_path): New prototype.
 290         * unittests/child-path-selftests.c: New file.
 291
 292 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 293
 294         * symfile.c (find_separate_debug_file): Look for separate debug
 295         files in debug directories under the sysroot.
 296
 297 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 298
 299         * symtab.h (struct minimal_symbol data_p): New const method.
 300         (struct minimal_symbol text_p): Likewise.
 301         * symtab.c (output_source_filename): Use file name style
 302         to print file name.
 303         (print_symbol_info): Likewise.
 304         (print_msymbol_info): Use address style to print addresses.
 305         Use function name style to print executable text symbols.
 306         (expand_symtab_containing_pc): Use data_p.
 307         (find_pc_sect_compunit_symtab): Likewise.
 308
 309 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 310
 311         * breakpoint.c (describe_other_breakpoints): Use address style
 312         to print addresses.
 313         (say_where): Likewise.
 314
 315 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 316
 317         * ada-typeprint.c (print_func_type): Print function name
 318         style to print function name.
 319         * c-typeprint.c (c_print_type_1): Likewise.
 320
 321 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 322
 323         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 324         for execve.
 325
 326 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 327
 328         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 329         type_stack.
 330
 331 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 332
 333         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 334         TYPE_CODE_REF types.
 335
 336 2019-02-08  Jim Wilson  <jimw@sifive.com>
 337
 338         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 339         (riscv_linux_fregset): New.
 340         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 341
 342 2019-02-07  Tom Tromey  <tom@tromey.com>
 343
 344         * thread.c (thread_cancel_execution_command): Update.
 345         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 346         methods.
 347         (struct thread_fsm_ops): Remove.
 348         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 349         (thread_fsm_should_stop, thread_fsm_return_value)
 350         (thread_fsm_set_finished, thread_fsm_finished_p)
 351         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 352         Don't declare.
 353         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 354         * infrun.c (clear_proceed_status_thread)
 355         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 356         (print_stop_event): Update.
 357         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 358         Add constructor.
 359         (step_command_fsm_ops): Remove.
 360         (new_step_command_fsm): Remove.
 361         (step_1): Update.
 362         (step_command_fsm::should_stop): Rename from
 363         step_command_fsm_should_stop.
 364         (step_command_fsm::clean_up): Rename from
 365         step_command_fsm_clean_up.
 366         (step_command_fsm::do_async_reply_reason): Rename from
 367         step_command_fsm_async_reply_reason.
 368         (struct until_next_fsm): Inherit from thread_fsm.  Add
 369         constructor.
 370         (until_next_fsm_ops): Remove.
 371         (new_until_next_fsm): Remove.
 372         (until_next_fsm::should_stop): Rename from
 373         until_next_fsm_should_stop.
 374         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 375         (until_next_fsm::do_async_reply_reason): Rename from
 376         until_next_fsm_async_reply_reason.
 377         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 378         constructor.  Change type of breakpoint.
 379         (finish_command_fsm_ops): Remove.
 380         (new_finish_command_fsm): Remove.
 381         (finish_command_fsm::should_stop): Rename from
 382         finish_command_fsm_should_stop.
 383         (finish_command_fsm::clean_up): Rename from
 384         finish_command_fsm_clean_up.
 385         (finish_command_fsm::return_value): Rename from
 386         finish_command_fsm_return_value.
 387         (finish_command_fsm::do_async_reply_reason): Rename from
 388         finish_command_fsm_async_reply_reason.
 389         (finish_command): Update.
 390         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 391         Add constructor.
 392         (call_thread_fsm_ops): Remove.
 393         (call_thread_fsm::call_thread_fsm): Rename from
 394         new_call_thread_fsm.
 395         (call_thread_fsm::should_stop): Rename from
 396         call_thread_fsm_should_stop.
 397         (call_thread_fsm::should_notify_stop): Rename from
 398         call_thread_fsm_should_notify_stop.
 399         (run_inferior_call, call_function_by_hand_dummy): Update.
 400         * cli/cli-interp.c (should_print_stop_to_console): Update.
 401         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 402         Add constructor.  Change type of location_breakpoint,
 403         caller_breakpoint.
 404         (until_break_fsm_ops): Remove.
 405         (new_until_break_fsm): Remove.
 406         (until_break_fsm::should_stop): Rename from
 407         until_break_fsm_should_stop.
 408         (until_break_fsm::clean_up): Rename from
 409         until_break_fsm_clean_up.
 410         (until_break_fsm::do_async_reply_reason): Rename from
 411         until_break_fsm_async_reply_reason.
 412         (until_break_command): Update.
 413         * thread-fsm.c: Remove.
 414         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 415
 416 2019-02-07  Tom Tromey  <tom@tromey.com>
 417
 418         * yy-remap.h: Add include guard.
 419         * xtensa-tdep.h: Add include guard.
 420         * xcoffread.h: Rename include guard.
 421         * varobj-iter.h: Add include guard.
 422         * tui/tui.h: Rename include guard.
 423         * tui/tui-winsource.h: Rename include guard.
 424         * tui/tui-wingeneral.h: Rename include guard.
 425         * tui/tui-windata.h: Rename include guard.
 426         * tui/tui-win.h: Rename include guard.
 427         * tui/tui-stack.h: Rename include guard.
 428         * tui/tui-source.h: Rename include guard.
 429         * tui/tui-regs.h: Rename include guard.
 430         * tui/tui-out.h: Rename include guard.
 431         * tui/tui-layout.h: Rename include guard.
 432         * tui/tui-io.h: Rename include guard.
 433         * tui/tui-hooks.h: Rename include guard.
 434         * tui/tui-file.h: Rename include guard.
 435         * tui/tui-disasm.h: Rename include guard.
 436         * tui/tui-data.h: Rename include guard.
 437         * tui/tui-command.h: Rename include guard.
 438         * tic6x-tdep.h: Add include guard.
 439         * target/waitstatus.h: Rename include guard.
 440         * target/wait.h: Rename include guard.
 441         * target/target.h: Rename include guard.
 442         * target/resume.h: Rename include guard.
 443         * target-float.h: Rename include guard.
 444         * stabsread.h: Add include guard.
 445         * rs6000-tdep.h: Add include guard.
 446         * riscv-fbsd-tdep.h: Add include guard.
 447         * regformats/regdef.h: Rename include guard.
 448         * record.h: Rename include guard.
 449         * python/python.h: Rename include guard.
 450         * python/python-internal.h: Rename include guard.
 451         * python/py-stopevent.h: Rename include guard.
 452         * python/py-ref.h: Rename include guard.
 453         * python/py-record.h: Rename include guard.
 454         * python/py-record-full.h: Rename include guard.
 455         * python/py-record-btrace.h: Rename include guard.
 456         * python/py-instruction.h: Rename include guard.
 457         * python/py-events.h: Rename include guard.
 458         * python/py-event.h: Rename include guard.
 459         * procfs.h: Add include guard.
 460         * proc-utils.h: Add include guard.
 461         * p-lang.h: Add include guard.
 462         * or1k-tdep.h: Rename include guard.
 463         * observable.h: Rename include guard.
 464         * nto-tdep.h: Rename include guard.
 465         * nat/x86-linux.h: Rename include guard.
 466         * nat/x86-linux-dregs.h: Rename include guard.
 467         * nat/x86-gcc-cpuid.h: Add include guard.
 468         * nat/x86-dregs.h: Rename include guard.
 469         * nat/x86-cpuid.h: Rename include guard.
 470         * nat/ppc-linux.h: Rename include guard.
 471         * nat/mips-linux-watch.h: Rename include guard.
 472         * nat/linux-waitpid.h: Rename include guard.
 473         * nat/linux-ptrace.h: Rename include guard.
 474         * nat/linux-procfs.h: Rename include guard.
 475         * nat/linux-osdata.h: Rename include guard.
 476         * nat/linux-nat.h: Rename include guard.
 477         * nat/linux-namespaces.h: Rename include guard.
 478         * nat/linux-btrace.h: Rename include guard.
 479         * nat/glibc_thread_db.h: Rename include guard.
 480         * nat/gdb_thread_db.h: Rename include guard.
 481         * nat/gdb_ptrace.h: Rename include guard.
 482         * nat/fork-inferior.h: Rename include guard.
 483         * nat/amd64-linux-siginfo.h: Rename include guard.
 484         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 485         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 486         * nat/aarch64-linux.h: Rename include guard.
 487         * nat/aarch64-linux-hw-point.h: Rename include guard.
 488         * mn10300-tdep.h: Add include guard.
 489         * mips-linux-tdep.h: Add include guard.
 490         * mi/mi-parse.h: Rename include guard.
 491         * mi/mi-out.h: Rename include guard.
 492         * mi/mi-main.h: Rename include guard.
 493         * mi/mi-interp.h: Rename include guard.
 494         * mi/mi-getopt.h: Rename include guard.
 495         * mi/mi-console.h: Rename include guard.
 496         * mi/mi-common.h: Rename include guard.
 497         * mi/mi-cmds.h: Rename include guard.
 498         * mi/mi-cmd-break.h: Rename include guard.
 499         * m2-lang.h: Add include guard.
 500         * location.h: Rename include guard.
 501         * linux-record.h: Rename include guard.
 502         * linux-nat.h: Add include guard.
 503         * linux-fork.h: Add include guard.
 504         * i386-darwin-tdep.h: Rename include guard.
 505         * hppa-linux-offsets.h: Add include guard.
 506         * guile/guile.h: Rename include guard.
 507         * guile/guile-internal.h: Rename include guard.
 508         * gnu-nat.h: Rename include guard.
 509         * gdb-stabs.h: Rename include guard.
 510         * frv-tdep.h: Add include guard.
 511         * f-lang.h: Add include guard.
 512         * event-loop.h: Add include guard.
 513         * darwin-nat.h: Rename include guard.
 514         * cp-abi.h: Rename include guard.
 515         * config/sparc/nm-sol2.h: Rename include guard.
 516         * config/nm-nto.h: Rename include guard.
 517         * config/nm-linux.h: Add include guard.
 518         * config/i386/nm-i386gnu.h: Rename include guard.
 519         * config/djgpp/nl_types.h: Rename include guard.
 520         * config/djgpp/langinfo.h: Rename include guard.
 521         * compile/gcc-cp-plugin.h: Add include guard.
 522         * compile/gcc-c-plugin.h: Add include guard.
 523         * compile/compile.h: Rename include guard.
 524         * compile/compile-object-run.h: Rename include guard.
 525         * compile/compile-object-load.h: Rename include guard.
 526         * compile/compile-internal.h: Rename include guard.
 527         * compile/compile-cplus.h: Rename include guard.
 528         * compile/compile-c.h: Rename include guard.
 529         * common/xml-utils.h: Rename include guard.
 530         * common/x86-xstate.h: Rename include guard.
 531         * common/version.h: Rename include guard.
 532         * common/vec.h: Rename include guard.
 533         * common/tdesc.h: Rename include guard.
 534         * common/selftest.h: Rename include guard.
 535         * common/scoped_restore.h: Rename include guard.
 536         * common/scoped_mmap.h: Rename include guard.
 537         * common/scoped_fd.h: Rename include guard.
 538         * common/safe-iterator.h: Rename include guard.
 539         * common/run-time-clock.h: Rename include guard.
 540         * common/refcounted-object.h: Rename include guard.
 541         * common/queue.h: Rename include guard.
 542         * common/ptid.h: Rename include guard.
 543         * common/print-utils.h: Rename include guard.
 544         * common/preprocessor.h: Rename include guard.
 545         * common/pathstuff.h: Rename include guard.
 546         * common/observable.h: Rename include guard.
 547         * common/netstuff.h: Rename include guard.
 548         * common/job-control.h: Rename include guard.
 549         * common/host-defs.h: Rename include guard.
 550         * common/gdb_wait.h: Rename include guard.
 551         * common/gdb_vecs.h: Rename include guard.
 552         * common/gdb_unlinker.h: Rename include guard.
 553         * common/gdb_unique_ptr.h: Rename include guard.
 554         * common/gdb_tilde_expand.h: Rename include guard.
 555         * common/gdb_sys_time.h: Rename include guard.
 556         * common/gdb_string_view.h: Rename include guard.
 557         * common/gdb_splay_tree.h: Rename include guard.
 558         * common/gdb_setjmp.h: Rename include guard.
 559         * common/gdb_ref_ptr.h: Rename include guard.
 560         * common/gdb_optional.h: Rename include guard.
 561         * common/gdb_locale.h: Rename include guard.
 562         * common/gdb_assert.h: Rename include guard.
 563         * common/filtered-iterator.h: Rename include guard.
 564         * common/filestuff.h: Rename include guard.
 565         * common/fileio.h: Rename include guard.
 566         * common/environ.h: Rename include guard.
 567         * common/common-utils.h: Rename include guard.
 568         * common/common-types.h: Rename include guard.
 569         * common/common-regcache.h: Rename include guard.
 570         * common/common-inferior.h: Rename include guard.
 571         * common/common-gdbthread.h: Rename include guard.
 572         * common/common-exceptions.h: Rename include guard.
 573         * common/common-defs.h: Rename include guard.
 574         * common/common-debug.h: Rename include guard.
 575         * common/cleanups.h: Rename include guard.
 576         * common/buffer.h: Rename include guard.
 577         * common/btrace-common.h: Rename include guard.
 578         * common/break-common.h: Rename include guard.
 579         * cli/cli-utils.h: Rename include guard.
 580         * cli/cli-style.h: Rename include guard.
 581         * cli/cli-setshow.h: Rename include guard.
 582         * cli/cli-script.h: Rename include guard.
 583         * cli/cli-interp.h: Rename include guard.
 584         * cli/cli-decode.h: Rename include guard.
 585         * cli/cli-cmds.h: Rename include guard.
 586         * charset-list.h: Add include guard.
 587         * buildsym-legacy.h: Rename include guard.
 588         * bfin-tdep.h: Add include guard.
 589         * ax.h: Rename include guard.
 590         * arm-linux-tdep.h: Add include guard.
 591         * arm-fbsd-tdep.h: Add include guard.
 592         * arch/xtensa.h: Rename include guard.
 593         * arch/tic6x.h: Add include guard.
 594         * arch/i386.h: Add include guard.
 595         * arch/arm.h: Rename include guard.
 596         * arch/arm-linux.h: Rename include guard.
 597         * arch/arm-get-next-pcs.h: Rename include guard.
 598         * arch/amd64.h: Add include guard.
 599         * arch/aarch64-insn.h: Rename include guard.
 600         * arch-utils.h: Rename include guard.
 601         * annotate.h: Add include guard.
 602         * amd64-darwin-tdep.h: Rename include guard.
 603         * aarch64-linux-tdep.h: Add include guard.
 604         * aarch64-fbsd-tdep.h: Add include guard.
 605         * aarch32-linux-nat.h: Add include guard.
 606
 607 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 608
 609         * macrotab.c (macro_define_internal): New function that
 610         factorizes macro_define_object_internal and macro_define_function
 611         code.
 612         (macro_define_object_internal): Use macro_define_internal.
 613         (macro_define_function): Likewise.
 614
 615 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 616
 617         * macrocmd.c (extract_identifier): Return
 618         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 619         callers.
 620
 621 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 622
 623         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 624
 625 2019-02-05  Tom Tromey  <tom@tromey.com>
 626
 627         * target.c (target_stack::unpush): Move assertion earlier.
 628
 629 2019-01-30  Tom Tromey  <tom@tromey.com>
 630
 631         PR python/23615:
 632         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 633         (gdbpy_parse_and_eval): Likewise.
 634         * python/python-internal.h (gdbpy_allow_threads): New class.
 635
 636 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 637
 638         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 639         (aarch64_fbsd_fpregmap): Move earlier.
 640         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 641         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 642         instead of individual calls to trad_frame_set_reg_addr.
 643         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 644         earlier.
 645         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 646         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 647         instead of individual calls to trad_frame_set_reg_addr.
 648
 649 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 650
 651         * CONTRIBUTE: Replace contribution list with wiki link.
 652
 653 2019-01-25  Tom Tromey  <tom@tromey.com>
 654
 655         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 656
 657 2019-01-25  Tom Tromey  <tom@tromey.com>
 658
 659         * xtensa-linux-nat.c: Fix common/ includes.
 660         * xml-support.h: Fix common/ includes.
 661         * xml-support.c: Fix common/ includes.
 662         * x86-linux-nat.c: Fix common/ includes.
 663         * windows-nat.c: Fix common/ includes.
 664         * varobj.h: Fix common/ includes.
 665         * varobj.c: Fix common/ includes.
 666         * value.c: Fix common/ includes.
 667         * valops.c: Fix common/ includes.
 668         * utils.c: Fix common/ includes.
 669         * unittests/xml-utils-selftests.c: Fix common/ includes.
 670         * unittests/utils-selftests.c: Fix common/ includes.
 671         * unittests/unpack-selftests.c: Fix common/ includes.
 672         * unittests/tracepoint-selftests.c: Fix common/ includes.
 673         * unittests/style-selftests.c: Fix common/ includes.
 674         * unittests/string_view-selftests.c: Fix common/ includes.
 675         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 676         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 677         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 678         * unittests/rsp-low-selftests.c: Fix common/ includes.
 679         * unittests/parse-connection-spec-selftests.c: Fix common/
 680         includes.
 681         * unittests/optional-selftests.c: Fix common/ includes.
 682         * unittests/offset-type-selftests.c: Fix common/ includes.
 683         * unittests/observable-selftests.c: Fix common/ includes.
 684         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 685         * unittests/memrange-selftests.c: Fix common/ includes.
 686         * unittests/memory-map-selftests.c: Fix common/ includes.
 687         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 688         * unittests/function-view-selftests.c: Fix common/ includes.
 689         * unittests/environ-selftests.c: Fix common/ includes.
 690         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 691         * unittests/common-utils-selftests.c: Fix common/ includes.
 692         * unittests/cli-utils-selftests.c: Fix common/ includes.
 693         * unittests/array-view-selftests.c: Fix common/ includes.
 694         * ui-file.c: Fix common/ includes.
 695         * tui/tui-io.c: Fix common/ includes.
 696         * tracepoint.h: Fix common/ includes.
 697         * tracepoint.c: Fix common/ includes.
 698         * tracefile-tfile.c: Fix common/ includes.
 699         * top.h: Fix common/ includes.
 700         * top.c: Fix common/ includes.
 701         * thread.c: Fix common/ includes.
 702         * target/waitstatus.h: Fix common/ includes.
 703         * target/waitstatus.c: Fix common/ includes.
 704         * target.h: Fix common/ includes.
 705         * target.c: Fix common/ includes.
 706         * target-memory.c: Fix common/ includes.
 707         * target-descriptions.c: Fix common/ includes.
 708         * symtab.h: Fix common/ includes.
 709         * symfile.c: Fix common/ includes.
 710         * stap-probe.c: Fix common/ includes.
 711         * spu-linux-nat.c: Fix common/ includes.
 712         * sparc-nat.c: Fix common/ includes.
 713         * source.c: Fix common/ includes.
 714         * solib.c: Fix common/ includes.
 715         * solib-target.c: Fix common/ includes.
 716         * ser-unix.c: Fix common/ includes.
 717         * ser-tcp.c: Fix common/ includes.
 718         * ser-pipe.c: Fix common/ includes.
 719         * ser-base.c: Fix common/ includes.
 720         * selftest-arch.c: Fix common/ includes.
 721         * s12z-tdep.c: Fix common/ includes.
 722         * rust-exp.y: Fix common/ includes.
 723         * rs6000-aix-tdep.c: Fix common/ includes.
 724         * riscv-tdep.c: Fix common/ includes.
 725         * remote.c: Fix common/ includes.
 726         * remote-notif.h: Fix common/ includes.
 727         * remote-fileio.h: Fix common/ includes.
 728         * remote-fileio.c: Fix common/ includes.
 729         * regcache.h: Fix common/ includes.
 730         * regcache.c: Fix common/ includes.
 731         * record-btrace.c: Fix common/ includes.
 732         * python/python.c: Fix common/ includes.
 733         * python/py-type.c: Fix common/ includes.
 734         * python/py-inferior.c: Fix common/ includes.
 735         * progspace.h: Fix common/ includes.
 736         * producer.c: Fix common/ includes.
 737         * procfs.c: Fix common/ includes.
 738         * proc-api.c: Fix common/ includes.
 739         * printcmd.c: Fix common/ includes.
 740         * ppc-linux-nat.c: Fix common/ includes.
 741         * parser-defs.h: Fix common/ includes.
 742         * osdata.c: Fix common/ includes.
 743         * obsd-nat.c: Fix common/ includes.
 744         * nat/x86-linux.c: Fix common/ includes.
 745         * nat/x86-linux-dregs.c: Fix common/ includes.
 746         * nat/x86-dregs.h: Fix common/ includes.
 747         * nat/x86-dregs.c: Fix common/ includes.
 748         * nat/ppc-linux.c: Fix common/ includes.
 749         * nat/mips-linux-watch.h: Fix common/ includes.
 750         * nat/mips-linux-watch.c: Fix common/ includes.
 751         * nat/linux-waitpid.c: Fix common/ includes.
 752         * nat/linux-ptrace.h: Fix common/ includes.
 753         * nat/linux-ptrace.c: Fix common/ includes.
 754         * nat/linux-procfs.c: Fix common/ includes.
 755         * nat/linux-personality.c: Fix common/ includes.
 756         * nat/linux-osdata.c: Fix common/ includes.
 757         * nat/linux-namespaces.c: Fix common/ includes.
 758         * nat/linux-btrace.h: Fix common/ includes.
 759         * nat/linux-btrace.c: Fix common/ includes.
 760         * nat/fork-inferior.c: Fix common/ includes.
 761         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 762         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 763         * nat/aarch64-linux.c: Fix common/ includes.
 764         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 765         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 766         * namespace.h: Fix common/ includes.
 767         * mips-linux-tdep.c: Fix common/ includes.
 768         * minsyms.c: Fix common/ includes.
 769         * mi/mi-parse.h: Fix common/ includes.
 770         * mi/mi-main.c: Fix common/ includes.
 771         * mi/mi-cmd-env.c: Fix common/ includes.
 772         * memrange.h: Fix common/ includes.
 773         * memattr.c: Fix common/ includes.
 774         * maint.h: Fix common/ includes.
 775         * maint.c: Fix common/ includes.
 776         * main.c: Fix common/ includes.
 777         * machoread.c: Fix common/ includes.
 778         * location.c: Fix common/ includes.
 779         * linux-thread-db.c: Fix common/ includes.
 780         * linux-nat.c: Fix common/ includes.
 781         * linux-fork.c: Fix common/ includes.
 782         * inline-frame.c: Fix common/ includes.
 783         * infrun.c: Fix common/ includes.
 784         * inflow.c: Fix common/ includes.
 785         * inferior.h: Fix common/ includes.
 786         * inferior.c: Fix common/ includes.
 787         * infcmd.c: Fix common/ includes.
 788         * inf-ptrace.c: Fix common/ includes.
 789         * inf-child.c: Fix common/ includes.
 790         * ia64-linux-nat.c: Fix common/ includes.
 791         * i387-tdep.c: Fix common/ includes.
 792         * i386-tdep.c: Fix common/ includes.
 793         * i386-linux-tdep.c: Fix common/ includes.
 794         * i386-linux-nat.c: Fix common/ includes.
 795         * i386-go32-tdep.c: Fix common/ includes.
 796         * i386-fbsd-tdep.c: Fix common/ includes.
 797         * i386-fbsd-nat.c: Fix common/ includes.
 798         * guile/scm-type.c: Fix common/ includes.
 799         * guile/guile.c: Fix common/ includes.
 800         * go32-nat.c: Fix common/ includes.
 801         * gnu-nat.c: Fix common/ includes.
 802         * gdbthread.h: Fix common/ includes.
 803         * gdbarch-selftests.c: Fix common/ includes.
 804         * gdb_usleep.c: Fix common/ includes.
 805         * gdb_select.h: Fix common/ includes.
 806         * gdb_bfd.c: Fix common/ includes.
 807         * gcore.c: Fix common/ includes.
 808         * fork-child.c: Fix common/ includes.
 809         * findvar.c: Fix common/ includes.
 810         * fbsd-nat.c: Fix common/ includes.
 811         * event-top.c: Fix common/ includes.
 812         * event-loop.c: Fix common/ includes.
 813         * dwarf2read.c: Fix common/ includes.
 814         * dwarf2loc.c: Fix common/ includes.
 815         * dwarf2-frame.c: Fix common/ includes.
 816         * dwarf-index-cache.c: Fix common/ includes.
 817         * dtrace-probe.c: Fix common/ includes.
 818         * disasm-selftests.c: Fix common/ includes.
 819         * defs.h: Fix common/ includes.
 820         * csky-tdep.c: Fix common/ includes.
 821         * cp-valprint.c: Fix common/ includes.
 822         * cp-support.h: Fix common/ includes.
 823         * cp-support.c: Fix common/ includes.
 824         * corelow.c: Fix common/ includes.
 825         * completer.h: Fix common/ includes.
 826         * completer.c: Fix common/ includes.
 827         * compile/compile.c: Fix common/ includes.
 828         * compile/compile-loc2c.c: Fix common/ includes.
 829         * compile/compile-cplus-types.c: Fix common/ includes.
 830         * compile/compile-cplus-symbols.c: Fix common/ includes.
 831         * command.h: Fix common/ includes.
 832         * cli/cli-dump.c: Fix common/ includes.
 833         * cli/cli-cmds.c: Fix common/ includes.
 834         * charset.c: Fix common/ includes.
 835         * build-id.c: Fix common/ includes.
 836         * btrace.h: Fix common/ includes.
 837         * btrace.c: Fix common/ includes.
 838         * breakpoint.h: Fix common/ includes.
 839         * breakpoint.c: Fix common/ includes.
 840         * ax.h:
 841         (enum agent_op): Fix common/ includes.
 842         * ax-general.c (struct aop_map): Fix common/ includes.
 843         * ax-gdb.c: Fix common/ includes.
 844         * auxv.c: Fix common/ includes.
 845         * auto-load.c: Fix common/ includes.
 846         * arm-tdep.c: Fix common/ includes.
 847         * arch/riscv.c: Fix common/ includes.
 848         * arch/ppc-linux-common.c: Fix common/ includes.
 849         * arch/i386.c: Fix common/ includes.
 850         * arch/arm.c: Fix common/ includes.
 851         * arch/arm-linux.c: Fix common/ includes.
 852         * arch/arm-get-next-pcs.c: Fix common/ includes.
 853         * arch/amd64.c: Fix common/ includes.
 854         * arch/aarch64.c: Fix common/ includes.
 855         * arch/aarch64-insn.c: Fix common/ includes.
 856         * arch-utils.c: Fix common/ includes.
 857         * amd64-windows-tdep.c: Fix common/ includes.
 858         * amd64-tdep.c: Fix common/ includes.
 859         * amd64-sol2-tdep.c: Fix common/ includes.
 860         * amd64-obsd-tdep.c: Fix common/ includes.
 861         * amd64-nbsd-tdep.c: Fix common/ includes.
 862         * amd64-linux-tdep.c: Fix common/ includes.
 863         * amd64-linux-nat.c: Fix common/ includes.
 864         * amd64-fbsd-tdep.c: Fix common/ includes.
 865         * amd64-fbsd-nat.c: Fix common/ includes.
 866         * amd64-dicos-tdep.c: Fix common/ includes.
 867         * amd64-darwin-tdep.c: Fix common/ includes.
 868         * agent.c: Fix common/ includes.
 869         * ada-lang.h: Fix common/ includes.
 870         * ada-lang.c: Fix common/ includes.
 871         * aarch64-tdep.c: Fix common/ includes.
 872
 873 2019-01-25  Tom Tromey  <tom@tromey.com>
 874
 875         * common/create-version.sh: Use common/version.h.
 876
 877 2019-01-24  Pedro Alves  <palves@redhat.com>
 878
 879         * infrun.c (signal_stop, signal_print, signal_program)
 880         (signal_catch, signal_pass): Now arrays instead of pointers.
 881         (update_signals_program_target, do_target_resume)
 882         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 883         * linux-nat.c (linux_nat_target::pass_signals)
 884         (linux_nat_target::create_inferior, linux_nat_target::attach):
 885         Adjust.
 886         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 887         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 888         * procfs.c (procfs_target::pass_signals): Adjust.
 889         * record-full.c (record_full_target::resume): Adjust.
 890         * remote.c (remote_target::pass_signals)
 891         (remote_target::program_signals): Adjust.
 892         * target-debug.h (target_debug_print_signals): Now takes a
 893         gdb::array_view as parameter.  Adjust.
 894         * target.h (target_ops) <pass_signals, program_signals>: Replace
 895         pointer and length parameters with gdb::array_view.
 896         (target_pass_signals, target_program_signals): Likewise.
 897         * target-delegates.c: Regenerate.
 898
 899 2019-01-24  Pedro Alves  <palves@redhat.com>
 900
 901         * common/forward-scope-exit.h
 902         (forward_scope_exit::forward_scope_exit): Pass arguments to
 903         m_bind_function directly, instead of creating a std::bind and
 904         copying that.
 905
 906 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 907
 908         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 909         for static members.
 910         (pass_in_v_vfp_candidate): Likewise.
 911
 912 2019-01-23  Tom Tromey  <tom@tromey.com>
 913             Pedro Alves  <palves@redhat.com>
 914
 915         * regcache.c (class regcache_invalidator): Remove.
 916         (regcache::raw_write): Use make_scope_exit.
 917
 918 2019-01-23  Tom Tromey  <tom@tromey.com>
 919
 920         * ui-out.h (class ui_out_emit_type): Update comment.
 921
 922 2019-01-23  Tom Tromey  <tom@tromey.com>
 923
 924         * infrun.c (fetch_inferior_event): Update comment.
 925
 926 2019-01-23  Tom Tromey  <tom@tromey.com>
 927             Pedro Alves  <palves@redhat.com>
 928
 929         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 930         parameter.
 931         (fetch_inferior_event): Use SCOPE_EXIT.
 932
 933
 934 2019-01-23  Tom Tromey  <tom@tromey.com>
 935             Pedro Alves  <palves@redhat.com>
 936
 937         * infrun.c (disable_thread_events): Delete.
 938         (stop_all_threads): Use SCOPE_EXIT.
 939
 940 2019-01-23  Tom Tromey  <tom@tromey.com>
 941             Pedro Alves  <palves@redhat.com>
 942
 943         * symfile.c: Include forward-scope-exit.h.
 944         (clear_symtab_users_cleanup): Replace forward declaration with
 945         a FORWARD_SCOPE_EXIT.
 946         (syms_from_objfile_1): Use the forward_scope_exit and
 947         gdb::optional instead of cleanup_function.
 948         (reread_symbols): Use the forward_scope_exit instead of
 949         cleanup_function.
 950         (clear_symtab_users_cleanup): Remove function.
 951
 952 2019-01-23  Tom Tromey  <tom@tromey.com>
 953             Pedro Alves  <palves@redhat.com>
 954
 955         * linux-nat.c: Include scope-exit.h.
 956         (cleanup_target_stop): Remove.
 957         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 958         SCOPE_EXIT.
 959
 960 2019-01-23  Tom Tromey  <tom@tromey.com>
 961             Pedro Alves  <palves@redhat.com>
 962
 963         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 964         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 965
 966 2019-01-23  Tom Tromey  <tom@tromey.com>
 967             Andrew Burgess  <andrew.burgess@embecosm.com>
 968             Pedro Alves  <palves@redhat.com>
 969
 970         * infrun.c (fetch_inferior_event): Use scope_exit.
 971         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 972         * top.c (execute_command): Use scope_exit.
 973         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 974         * utils.c (do_bpstat_clear_actions_cleanup)
 975         (make_bpstat_clear_actions_cleanup): Remove.
 976
 977 2019-01-23  Tom Tromey  <tom@tromey.com>
 978             Pedro Alves  <palves@redhat.com>
 979
 980         * infrun.c: Include "common/scope-exit.h"
 981         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 982         (wait_for_inferior): Use SCOPE_EXIT.
 983         (fetch_inferior_event): Use scope_exit.
 984
 985 2019-01-23  Tom Tromey  <tom@tromey.com>
 986             Pedro Alves  <palves@redhat.com>
 987
 988         * breakpoint.c (create_breakpoint): Remove cleanup.
 989
 990 2019-01-23  Tom Tromey  <tom@tromey.com>
 991             Andrew Burgess  <andrew.burgess@embecosm.com>
 992             Pedro Alves  <palves@redhat.com>
 993
 994 2019-01-23  Pedro Alves  <palves@redhat.com>
 995
 996         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 997
 998 2019-01-23  Pedro Alves  <palves@redhat.com>
 999             Andrew Burgess  <andrew.burgess@embecosm.com>
1000
1001         * gdbthread.h: Include "common/forward-scope-exit.h".
1002         (scoped_finish_thread_state): Redefine custom class in terms of
1003         forward_scope_exit.
1004
1005 2019-01-23  Pedro Alves  <palves@redhat.com>
1006             Andrew Burgess  <andrew.burgess@embecosm.com>
1007
1008         * common/forward-scope-exit.h: New file.
1009
1010 2019-01-23  Pedro Alves  <palves@redhat.com>
1011             Andrew Burgess  <andrew.burgess@embecosm.com>
1012             Tom Tromey  <tom@tromey.com>
1013
1014         * common/scope-exit.h: New file.
1015
1016 2019-01-23  Pedro Alves  <palves@redhat.com>
1017
1018         * common/preprocessor.h (ESC): Rename to ...
1019         (ESC_PARENS): ... this.
1020         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1021         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1022
1023 2019-01-23  Tom Tromey  <tom@tromey.com>
1024
1025         * language.h (class scoped_switch_to_sym_language_if_auto):
1026         Initialize m_lang in both cases.
1027
1028 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1029
1030         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1031         with XCNEW.
1032
1033 2019-01-22  Tom Tromey  <tom@tromey.com>
1034
1035         * corelow.c: Do not include sys/file.h.
1036
1037 2019-01-22  Tom Tromey  <tom@tromey.com>
1038
1039         * tui/tui-wingeneral.h: Include gdb_curses.h.
1040
1041 2019-01-22  Tom Tromey  <tom@tromey.com>
1042
1043         * source-cache.h (class source_cache) <get_source_lines,
1044         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1045
1046 2019-01-22  Tom Tromey  <tom@tromey.com>
1047
1048         * remote-fileio.h (struct remote_target): Declare.
1049
1050 2019-01-22  Tom Tromey  <tom@tromey.com>
1051
1052         * python/py-arch.c: Do not include py-ref.h.
1053         * python/py-bpevent.c: Do not include py-ref.h.
1054         * python/py-cmd.c: Do not include py-ref.h.
1055         * python/py-continueevent.c: Do not include py-ref.h.
1056         * python/py-event.h: Do not include py-ref.h.
1057         * python/py-evtregistry.c: Do not include py-ref.h.
1058         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1059         * python/py-frame.c: Do not include py-ref.h.
1060         * python/py-framefilter.c: Do not include py-ref.h.
1061         * python/py-function.c: Do not include py-ref.h.
1062         * python/py-infevents.c: Do not include py-ref.h.
1063         * python/py-linetable.c: Do not include py-ref.h.
1064         * python/py-objfile.c: Do not include py-ref.h.
1065         * python/py-param.c: Do not include py-ref.h.
1066         * python/py-prettyprint.c: Do not include py-ref.h.
1067         * python/py-progspace.c: Do not include py-ref.h.
1068         * python/py-symbol.c: Do not include py-ref.h.
1069         * python/py-symtab.c: Do not include py-ref.h.
1070         * python/py-type.c: Do not include py-ref.h.
1071         * python/py-unwind.c: Do not include py-ref.h.
1072         * python/py-utils.c: Do not include py-ref.h.
1073         * python/py-value.c: Do not include py-ref.h.
1074         * python/py-varobj.c: Do not include py-ref.h.
1075         * python/py-xmethods.c: Do not include py-ref.h.
1076         * python/python.c: Do not include py-ref.h.
1077         * varobj.c: Do not include py-ref.h.
1078
1079 2019-01-22  Tom Tromey  <tom@tromey.com>
1080
1081         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1082         keyword for bcache.
1083
1084 2019-01-22  Tom Tromey  <tom@tromey.com>
1085
1086         * compile/compile-cplus-types.c: Remove a comment by #include.
1087
1088 2019-01-22  Tom Tromey  <tom@tromey.com>
1089
1090         * compile/gcc-c-plugin.h: Include compile-internal.h.
1091
1092 2019-01-22  Tom Tromey  <tom@tromey.com>
1093
1094         * stabsread.c (EXTERN): Do not define.
1095         (symnum, next_symbol_text_func, processing_gcc_compilation)
1096         (within_function, global_sym_chain, global_stabs)
1097         (previous_stab_code, this_object_header_files)
1098         (n_this_object_header_files)
1099         (n_allocated_this_object_header_files): Define.
1100         * stabsread.h (EXTERN): Never define.  Use "extern".
1101
1102 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1103
1104         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1105         history_value.
1106
1107 2019-01-21  Tom Tromey  <tom@tromey.com>
1108
1109         * ui-out.c: Fix includes.
1110         * tui/tui-source.c: Fix includes.
1111         * target.c: Fix includes.
1112         * remote.c: Fix includes.
1113         * regcache.c: Fix includes.
1114         * python/py-block.c: Fix includes.
1115         * printcmd.c: Fix includes.
1116         * or1k-tdep.c: Fix includes.
1117         * mi/mi-main.c: Fix includes.
1118         * m32r-tdep.c: Fix includes.
1119         * csky-tdep.c: Fix includes.
1120         * compile/compile-cplus-types.c: Fix includes.
1121         * cli/cli-interp.c: Fix includes.
1122
1123 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1124
1125         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1126         for padding.
1127
1128 2019-01-16  Tom Tromey  <tom@tromey.com>
1129
1130         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1131         earlier.
1132         (struct objfile) <msymbols_range>: Move from top level.
1133         <msymbols>: New method.
1134         (class objfile_msymbols): Remove.
1135         * symtab.c (default_collect_symbol_completion_matches_break_on):
1136         Update.
1137         * symmisc.c (dump_msymbols): Update.
1138         * stabsread.c (scan_file_globals): Update.
1139         * objc-lang.c (info_selectors_command, info_classes_command)
1140         (find_methods): Update.
1141         * minsyms.c (find_solib_trampoline_target): Update.
1142         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1143         * coffread.c (coff_symfile_read): Update.
1144         * ada-lang.c (ada_lookup_simple_minsym)
1145         (ada_collect_symbol_completion_matches): Update.
1146
1147 2019-01-16  Tom Tromey  <tom@tromey.com>
1148
1149         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1150         type.  Remove no-argument constructor.
1151         <iterator::operator++>: Simplify.
1152         <begin>: Update.
1153         <end>: Use minimal_symbol_count.
1154
1155 2019-01-16  Tom Tromey  <tom@tromey.com>
1156
1157         * objfiles.h (struct objfile) <psymtabs>: New method.
1158         (class objfile_psymtabs): Remove.
1159         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1160         typedef.
1161         <range>: New method.
1162         (require_partial_symbols): Change return type.
1163         * psymtab.c (require_partial_symbols)
1164         (psym_expand_symtabs_matching): Update.
1165         * mdebugread.c (parse_partial_symbols): Update.
1166         * dbxread.c (dbx_end_psymtab): Update.
1167
1168 2019-01-15  Tom Tromey  <tom@tromey.com>
1169
1170         * symtab.c (lookup_objfile_from_block)
1171         (lookup_symbol_in_objfile_symtabs)
1172         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1173         (find_line_symtab, info_sources_command)
1174         (default_collect_symbol_completion_matches_break_on)
1175         (make_source_files_completion_list): Update.
1176         * symmisc.c (print_objfile_statistics, dump_objfile)
1177         (maintenance_print_symbols, maintenance_info_symtabs)
1178         (maintenance_check_symtabs, maintenance_info_line_tables):
1179         Update.
1180         * source.c (select_source_symtab)
1181         (forget_cached_source_info_for_objfile): Update.
1182         * objfiles.h (class objfile_compunits): Remove.
1183         (struct objfile) <compunits_range>: New typedef.
1184         (compunits): New method.
1185         * objfiles.c (objfile_relocate1): Update.
1186         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1187         * maint.c (count_symtabs_and_blocks): Update.
1188         * linespec.c (iterate_over_all_matching_symtabs): Update.
1189         * cp-support.c (add_symbol_overload_list_qualified): Update.
1190         * coffread.c (coff_symtab_read): Update.
1191         * ada-lang.c (add_nonlocal_symbols)
1192         (ada_collect_symbol_completion_matches)
1193         (ada_add_global_exceptions): Update.
1194
1195 2019-01-15  Tom Tromey  <tom@tromey.com>
1196
1197         * progspace.h (program_space) <objfiles_safe_range>: New
1198         typedef.
1199         <objfiles_safe>: New method.
1200         * objfiles.h (class all_objfiles_safe): Remove.
1201         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1202         * jit.c (jit_inferior_exit_hook): Update.
1203
1204 2019-01-17  Tom Tromey  <tom@tromey.com>
1205
1206         * progspace.h (program_space) <objfiles_range>: New typedef.
1207         <objfiles>: New method.
1208         <objfiles_head>: Rename from objfiles.
1209         (object_files): Update.
1210         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1211         * guile/scm-pretty-print.c
1212         (ppscm_find_pretty_printer_from_objfiles): Update.
1213         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1214         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1215         Update.
1216         * python/py-progspace.c (pspy_get_objfiles): Update.
1217         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1218         Update.
1219         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1220         (objfpy_lookup_objfile_by_build_id): Update.
1221         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1222         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1223         Update.
1224         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1225         (expand_symtab_containing_pc, lookup_objfile_from_block)
1226         (lookup_static_symbol, basic_lookup_transparent_type)
1227         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1228         (find_line_symtab, info_sources_command)
1229         (default_collect_symbol_completion_matches_break_on)
1230         (make_source_files_completion_list, find_main_name): Update.
1231         * symmisc.c (print_symbol_bcache_statistics)
1232         (print_objfile_statistics, maintenance_print_symbols)
1233         (maintenance_print_msymbols, maintenance_print_objfiles)
1234         (maintenance_info_symtabs, maintenance_check_symtabs)
1235         (maintenance_expand_symtabs, maintenance_info_line_tables):
1236         Update.
1237         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1238         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1239         (map_overlay_command, unmap_overlay_command)
1240         (simple_overlay_update, expand_symtabs_matching)
1241         (map_symbol_filenames): Update.
1242         * symfile-debug.c (set_debug_symfile): Update.
1243         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1244         Update.
1245         * source.c (select_source_symtab, forget_cached_source_info):
1246         Update.
1247         * solib.c (solib_read_symbols): Update.
1248         * solib-spu.c (append_ocl_sos): Update.
1249         * psymtab.c (maintenance_print_psymbols)
1250         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1251         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1252         * printcmd.c (info_symbol_command): Update.
1253         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1254         Update.
1255         * objfiles.h (class all_objfiles): Remove.
1256         * objfiles.c (have_partial_symbols, have_full_symbols)
1257         (have_minimal_symbols, qsort_cmp, update_section_map)
1258         (shared_objfile_contains_address_p)
1259         (default_iterate_over_objfiles_in_search_order): Update.
1260         * objc-lang.c (info_selectors_command, info_classes_command)
1261         (find_methods): Update.
1262         * minsyms.c (find_solib_trampoline_target): Update.
1263         * maint.c (maintenance_info_sections)
1264         (maintenance_translate_address, count_symtabs_and_blocks):
1265         Update.
1266         * main.c (captured_main_1): Update.
1267         * linux-thread-db.c (try_thread_db_load_from_pdir)
1268         (has_libpthread): Update.
1269         * linespec.c (iterate_over_all_matching_symtabs)
1270         (search_minsyms_for_name): Update.
1271         * jit.c (jit_find_objf_with_entry_addr): Update.
1272         * hppa-tdep.c (find_unwind_entry)
1273         (hppa_lookup_stub_minimal_symbol): Update.
1274         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1275         Update.
1276         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1277         (elf_gnu_ifunc_resolve_by_got): Update.
1278         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1279         * dwarf-index-write.c (save_gdb_index_command): Update.
1280         * cp-support.c (add_symbol_overload_list_qualified): Update.
1281         * breakpoint.c (create_overlay_event_breakpoint)
1282         (create_longjmp_master_breakpoint)
1283         (create_std_terminate_master_breakpoint)
1284         (create_exception_master_breakpoint): Update.
1285         * blockframe.c (find_pc_partial_function): Update.
1286         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1287         (ada_collect_symbol_completion_matches)
1288         (ada_add_global_exceptions): Update.
1289
1290 2019-01-17  Tom Tromey  <tom@tromey.com>
1291
1292         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1293         declare VEC.
1294         (solib_target_parse_libraries): Change return type.
1295         (library_list_start_segment, library_list_start_section)
1296         (library_list_end_library, library_list_start_library); Update.
1297         (solib_target_free_library_list): Remove.
1298         (solib_target_parse_libraries): Remove cleanup.  Change return
1299         type.
1300         (solib_target_current_sos): Update.
1301
1302 2019-01-17  Tom Tromey  <tromey@bapiya>
1303
1304         * valprint.c: Replace "the the" with "the".
1305         * symtab.c: Replace "the the" with "the".
1306         * solib.c: Replace "the the" with "the".
1307         * solib-dsbt.c: Replace "the the" with "the".
1308         * linespec.c: Replace "the the" with "the".
1309         * dwarf2loc.h: Replace "the the" with "the".
1310         * amd64-windows-tdep.c: Replace "the the" with "the".
1311         * aarch64-tdep.c: Replace "the the" with "the".
1312
1313 2019-01-16  Keith Seitz  <keiths@redhat.com>
1314
1315         PR gdb/23773
1316         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1317         <builder>: Rename to ..
1318         <m_builder>: ... this and make private.
1319         (dwarf2_cu::get_builder): New method.  Change all users of
1320         `builder' to use this method.
1321         (dwarf2_start_symtab): Move to ...
1322         (dwarf2_cu::start_symtab): ... here.  Update all callers
1323         (setup_type_unit_groups): Move to ...
1324         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1325         callers.
1326         (dwarf2_cu::reset_builder): New method.
1327         (process_full_compunit, process_full_type_unit): Use
1328         dwarf2_cu::reset_builder.
1329         (follow_die_offset): Record the ancestor CU if it is different
1330         from the followed DIE's CU.
1331         (follow_die_sig_1): Likewise.
1332
1333 2019-01-15  Tom Tromey  <tom@tromey.com>
1334
1335         * remote.c (class remote_state) <buf>: Now a char_vector.
1336         <buf_size>: Remove.
1337         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1338         parameter.
1339         (remote_target::getpkt_or_notif_sane_1)
1340         (remote_target::getpkt_sane)
1341         (remote_target::getpkt_or_notif_sane): Likewise.
1342         (class remote_target) <putpkt>: New overload.
1343         (remote_target::read_frame): Change type of "buf_p".  Remove
1344         sizeof_p parameter.
1345         (packet_ok): New overload.
1346         (packet_check_result): New overload.
1347         Update all uses.
1348
1349 2019-01-14  Tom Tromey  <tom@tromey.com>
1350
1351         * remote-notif.c (handle_notification, remote_notif_ack)
1352         (remote_notif_parse): Make "buf" const.
1353         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1354         const.
1355         (remote_notif_parse, remote_notif_ack, handle_notification):
1356         Likewise.
1357         * remote.c (remote_notif_stop_parse): Make "buf" const.
1358         (remote_target::remote_parse_stop_reply): Make "buf" const.
1359         (remote_notif_stop_ack): Make "buf" const.
1360
1361 2019-01-14  Tom Tromey  <tom@tromey.com>
1362
1363         * remote.c (remote_console_output): Make parameter const.
1364
1365 2019-01-14  Tom Tromey  <tom@tromey.com>
1366
1367         * target-debug.h (target_debug_print_signals): Constify.
1368         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1369         * procfs.c (procfs_target::pass_signals): Update.
1370         * linux-nat.c (linux_nat_target::pass_signals): Update.
1371         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1372         * target-delegates.c: Rebuild.
1373         * remote.c (remote_target::program_signals): Update.
1374         (remote_target::pass_signals): Update.
1375         * target.c (target_pass_signals): Constify argument.
1376         (target_program_signals): Likewise.
1377         * target.h (struct target_ops) <pass_signals, program_signals>:
1378         Constify argument.
1379         (target_pass_signals, target_program_signals): Constify argument.
1380
1381 2019-01-14  Tom Tromey  <tom@tromey.com>
1382
1383         PR tui/28819:
1384         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1385
1386 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1387
1388         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1389         field.
1390         * rs6000-tdep.c: Include reggroups.h.
1391         (IS_V_ALIAS_PSEUDOREG): Define.
1392         (rs6000_register_name): Return names for the "vX" aliases.
1393         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1394         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1395         aliases.  Call default_register_reggroup_p for all other
1396         pseudo-registers.
1397         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1398         New functions.
1399         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1400         Handle "vX" aliases.
1401         (v_alias_pseudo_register_collect): New function.
1402         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1403         (rs6000_gdbarch_init): Initialize "vX" aliases as
1404         pseudo-registers.  Restore registration of
1405         rs6000_pseudo_register_reggroup_p with
1406         set_tdesc_pseudo_register_reggroup_p.
1407
1408 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1409
1410         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1411         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1412         set_gdbarch_num_pseudo_regs.
1413
1414 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1415
1416         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1417         Remove arg prefixname, add do_set and do_show.
1418         Add member functions set_list and show_list.
1419         * cli/cli-style.c (class cli_style_option): Update accordingly.
1420         (style_set_list): Move to file scope.
1421         (style_show_list): Likewise.
1422         (set_style): Call help_list.
1423         (show_style): Call cmd_show_list.
1424         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1425         Update to use the new macro.
1426
1427 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1428
1429         * ada-lang.c (_initialize_ada_language): Expand the help text
1430         for the "catch exception" command.
1431
1432 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1433
1434         * symtab.c (matching_obj_sections): Initialize obj,
1435         declare it closer to its usage.
1436
1437 2019-01-10  Tom Tromey  <tom@tromey.com>
1438
1439         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1440         (basic_inf_threads_range): Remove.
1441         (inf_threads_range, inf_non_exited_threads_range)
1442         (safe_inf_threads_range): Use next_adapter.
1443
1444 2019-01-10  Keith Seitz  <keiths@redhat.com>
1445
1446         PR gdb/23712
1447         PR symtab/23010
1448         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1449         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1450
1451 2019-01-10  Keith Seitz  <keiths@redhat.com>
1452
1453         PR gdb/23712
1454         PR symtab/23010
1455         * dictionary.c (pending_to_vector): Remove.
1456         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1457         Remove _1 suffix, replacing functions of the same name.  Update
1458         all callers.
1459         (dict_create_hashed, dict_create_hashed_expandable)
1460         (dict_create_linear, dict_create_linear_expandable, dict_free)
1461         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1462         Make functions static.
1463
1464 2019-01-10  Keith Seitz  <keiths@redhat.com>
1465
1466         PR gdb/23712
1467         PR symtab/23010
1468         * dictionary.h (struct dictionary): Replace declaration with
1469         multidictionary.
1470         (dict_create_hashed, dict_create_hashed_expandable)
1471         (dict_create_linear, dict_create_linear_expandable)
1472         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1473         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1474         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1475         taking multidictionary argument.
1476         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1477         * block.h (struct block) <dict>: Change to multidictionary
1478         and rename `multidict'.
1479         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1480         symmisc.c: Update all dictionary references to multidictionary.
1481
1482 2019-01-10  Keith Seitz  <keiths@redhat.com>
1483
1484         PR gdb/23712
1485         PR symtab/23010
1486         * dictionary.c: Include unordered_map.
1487         (pending_to_vector): New function.
1488         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1489         Rewrite the non-"_1" functions to take vector instead
1490         of linked list.
1491         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1492         "new" _1 versions of the same name.
1493         (multidictionary): Define.
1494         (std::hash<enum language): New definition.
1495         (collate_pending_symbols_by_language, mdict_create_hashed)
1496         (mdict_create_hashed_expandable, mdict_create_linear)
1497         (mdict_create_linear_expandable, mdict_free)
1498         (find_language_dictionary, create_new_language_dictionary)
1499         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1500         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1501         (mdict_size, mdict_empty): New functions.
1502         * dictionary.h (mdict_iterator): Define.
1503
1504 2019-01-10  Pedro Alves  <palves@redhat.com>
1505
1506         * breakpoint.c (read_uploaded_action)
1507         (create_tracepoint_from_upload): Adjust to use
1508         gdb::unique_xmalloc_ptr.
1509         * ctf.c (ctf_write_uploaded_tp):
1510         (SET_ARRAY_FIELD): Use emplace_back.
1511         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1512         * tracefile-tfile.c (tfile_write_uploaded_tp):
1513         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1514         gdb::unique_xmalloc_ptr.
1515         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1516         at_string, cond_string, cmd_strings>: Replace char pointers
1517         with gdb::unique_xmalloc_ptr.
1518
1519 2019-01-10  Pedro Alves  <palves@redhat.com>
1520
1521         * solib-target.c (library_list_start_library): Don't xstrdup name.
1522
1523 2019-01-10  Pedro Alves  <palves@redhat.com>
1524
1525         * mdebugread.c (parse_partial_symbols): Use
1526         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1527
1528 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1529
1530         * linux-fork.c (scoped_switch_fork_info)
1531         <~scoped_switch_fork_info>: Fix incorrect variable name.
1532
1533 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1534
1535         * linux-fork.c (scoped_switch_fork_info)
1536         <scoped_switch_fork_info>: Make explicit.
1537         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1538
1539 2019-01-10  Tom Tromey  <tom@tromey.com>
1540
1541         * objfiles.h (objfile::reset_psymtabs): Update.
1542         * objfiles.c (objfile::objfile): Update.
1543         * psymtab.h (psymtab_storage::obstack): Update.
1544         (psymtab_storage::m_obstack): Use gdb::optional.
1545         (class psymtab_storage): Update comment.  Remove objfile
1546         parameter.
1547         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1548
1549 2019-01-10  Tom Tromey  <tom@tromey.com>
1550
1551         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1552         <free_psymtabs>: Now private.
1553         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1554         (allocate_psymtab): Use new method.
1555
1556 2019-01-10  Tom Tromey  <tom@tromey.com>
1557
1558         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1559         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1560         * mdebugread.c (parse_partial_symbols): Use
1561         allocate_dependencies.
1562         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1563         allocate_dependencies.
1564         (process_psymtab_comp_unit_reader)
1565         (build_type_psymtab_dependencies): Likewise.
1566         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1567
1568 2019-01-10  Tom Tromey  <tom@tromey.com>
1569
1570         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1571         PSYMBOL_SET_LANGUAGE.
1572         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1573
1574 2019-01-10  Tom Tromey  <tom@tromey.com>
1575
1576         * psymtab.h (psymtab_storage::obstack): New method.
1577         <m_obstack>: Rename from obstack; now private.
1578         * psymtab.c (psymtab_storage): Update.
1579         * dwarf2read.c (create_addrmap_from_index)
1580         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1581         Update.
1582
1583 2019-01-10  Tom Tromey  <tom@tromey.com>
1584
1585         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1586         * objfiles.h (objfile::reset_psymtabs): New method.
1587
1588 2019-01-10  Tom Tromey  <tom@tromey.com>
1589
1590         * symmisc.c (print_symbol_bcache_statistics): Update.
1591         (print_objfile_statistics): Update.
1592         * symfile.c (reread_symbols): Update.
1593         * psymtab.h (class psymtab_storage): New.
1594         * psymtab.c (psymtab_storage): New constructor.
1595         (~psymtab_storage): New destructor.
1596         (require_partial_symbols): Update.
1597         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1598         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1599         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1600         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1601         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1602         (start_psymtab_common, end_psymtab_common)
1603         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1604         (allocate_psymtab): Update.
1605         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1606         Update.
1607         (dump_psymtab_addrmap, maintenance_print_psymbols)
1608         (maintenance_check_psymtabs): Update.
1609         (class objfile_psymtabs): Move to objfiles.h.
1610         * psympriv.h (discard_psymtab): Now inline.
1611         (psymtab_discarder::psymtab_discarder): Update.
1612         (psymtab_discarder::~psymtab_discarder): Update.
1613         (ALL_OBJFILE_PSYMTABS): Rewrite.
1614         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1615         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1616         Remove fields.
1617         <partial_symtabs>: New field.
1618         (class objfile_psymtabs): Move from psymtab.h.  Update.
1619         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1620         psymbol_cache.
1621         (objfile::~objfile): Don't destroy psymbol_cache.
1622         * mdebugread.c (parse_partial_symbols): Update.
1623         * dwarf2read.c (create_addrmap_from_index)
1624         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1625         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1626         (add_partial_subprogram, dwarf2_ranges_read): Update.
1627         * dwarf-index-write.c (write_address_map)
1628         (write_one_signatured_type, recursively_write_psymbols)
1629         (class debug_names, class debug_names, write_psymtabs_to_index):
1630         Update.
1631
1632 2019-01-10  Tom Tromey  <tom@tromey.com>
1633
1634         * symtab.h (SYMBOL_SET_NAMES): Update.
1635         (symbol_set_names): Update.
1636         (MSYMBOL_SET_NAMES): Update.
1637         * symtab.c (symbol_set_names): Change argument to be an
1638         objfile_per_bfd_storage.
1639         * psymtab.c (add_psymbol_to_bcache): Update.
1640         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1641
1642 2019-01-10  Tom Tromey  <tom@tromey.com>
1643
1644         * symtab.c (create_demangled_names_hash): Change argument to be an
1645         objfile_per_bfd_storage.
1646         (symbol_set_names): Update.
1647
1648 2019-01-10  Tom Tromey  <tom@tromey.com>
1649
1650         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1651         init_psymbol_list.
1652         * psymtab.c (init_psymbol_list): Do nothing if already called.
1653         * psympriv.h (init_psymbol_list): Add comment.
1654         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1655         init_psymbol_list.
1656         * dbxread.c (dbx_symfile_read): Unconditionally call
1657         init_psymbol_list.
1658
1659 2019-01-10  Tom Tromey  <tom@tromey.com>
1660
1661         * xcoffread.c (scan_xcoff_symtab): Update.
1662         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1663         "where".
1664         * mdebugread.c (parse_partial_symbols)
1665         (handle_psymbol_enumerators): Update.
1666         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1667         * dbxread.c (read_dbx_symtab): Update.
1668         * psympriv.h (psymbol_placement): New enum.
1669         (add_psymbol_to_list): Update.
1670
1671 2019-01-10  Tom Tromey  <tom@tromey.com>
1672
1673         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1674         static_psymbols parameters.
1675         (scan_xcoff_symtab): Update.
1676         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1677         static_psymbols parameters.
1678         * psympriv.h (start_psymtab_common): Update.
1679         * mdebugread.c (parse_partial_symbols): Update.
1680         * dwarf2read.c (create_partial_symtab): Update.
1681         * dbxread.c (read_dbx_symtab): Update.
1682         (start_psymtab): Remove global_psymbols and static_psymbols
1683         parameters.
1684
1685 2019-01-10  Tom Tromey  <tom@tromey.com>
1686
1687         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1688         * psymtab.c (allocate_psymtab): Add comment.
1689         * psympriv.h (allocate_psymtab): Add comment.
1690         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1691         initializations.
1692         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1693
1694 2019-01-10  Tom Tromey  <tom@tromey.com>
1695
1696         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1697         Don't declare.
1698         * mipsread.c: Include mdebugread.h.
1699         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1700         Declare.
1701         * elfread.c: Include mdebugread.h.
1702
1703 2019-01-09  Tom Tromey  <tom@tromey.com>
1704
1705         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1706         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1707         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1708         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1709         (psym_lookup_symbol, psym_find_last_source_symtab)
1710         (psym_forget_cached_source_info, psym_print_stats)
1711         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1712         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1713         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1714         (psym_find_compunit_symtab_by_address)
1715         (maintenance_print_psymbols, maintenance_info_psymtabs)
1716         (maintenance_check_psymtabs): Use ranged for.
1717         * psymtab.h (class objfile_psymtabs): New.
1718         (require_partial_symbols): Return objfile_psymtabs.
1719         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1720
1721 2019-01-09  Tom Tromey  <tom@tromey.com>
1722
1723         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1724         (find_pc_mapped_section, list_overlays_command)
1725         (map_overlay_command, unmap_overlay_command)
1726         (simple_overlay_update): Use all_objfiles.
1727         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1728         * printcmd.c (info_symbol_command): Use all_objfiles.
1729         * objfiles.h (ALL_OBJSECTIONS): Remove.
1730         * maint.c (maintenance_translate_address): Use all_objfiles.
1731         * gcore.c (gcore_create_callback): Use all_objfiles.
1732         (objfile_find_memory_regions): Likewise.
1733
1734 2019-01-09  Tom Tromey  <tom@tromey.com>
1735
1736         * symtab.c (find_line_symtab, info_sources_command)
1737         (make_source_files_completion_list): Use objfile_compunits.
1738         * source.c (select_source_symtab): Use objfile_compunits.
1739         * objfiles.h (struct objfile): Update comment.
1740         (ALL_OBJFILES): Remove.
1741         (ALL_FILETABS): Remove.
1742         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1743         objfile_compunits.
1744
1745 2019-01-09  Tom Tromey  <tom@tromey.com>
1746
1747         * symmisc.c (print_objfile_statistics, dump_objfile)
1748         (maintenance_print_symbols): Use compunit_filetabs.
1749         * source.c (forget_cached_source_info_for_objfile): Use
1750         compunit_filetabs.
1751         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1752         (ALL_FILETABS): Use compunit_filetabs.
1753         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1754         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1755
1756 2019-01-09  Tom Tromey  <tom@tromey.com>
1757
1758         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1759         (compunit_filetabs): New.
1760         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1761         compunit_filetabs.
1762         (info_sources_command, make_source_files_completion_list): Remove
1763         declaration.
1764         * symmisc.c (print_objfile_statistics, dump_objfile)
1765         (maintenance_print_symbols): Remove declaration.
1766         (maintenance_info_symtabs): Use compunit_filetabs.
1767         (maintenance_info_line_tables): Likewise.
1768         * source.c (select_source_symtab): Change local variable name.
1769         (forget_cached_source_info_for_objfile): Remove declaration.
1770         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1771         * objfiles.c (objfile_relocate1): Remove declaration.
1772         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1773         declaration.
1774         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1775         * coffread.c (coff_symtab_read): Remove declaration.
1776         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1777         compunit_filetabs.
1778
1779 2019-01-09  Tom Tromey  <tom@tromey.com>
1780
1781         * symtab.c (lookup_objfile_from_block)
1782         (find_pc_sect_compunit_symtab, search_symbols)
1783         (default_collect_symbol_completion_matches_break_on): Use
1784         objfile_compunits.
1785         * objfiles.h (ALL_COMPUNITS): Remove.
1786         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1787         * cp-support.c (add_symbol_overload_list_qualified): Use
1788         objfile_compunits.
1789         * ada-lang.c (ada_collect_symbol_completion_matches)
1790         (ada_add_global_exceptions): Use objfile_compunits.
1791
1792 2019-01-09  Tom Tromey  <tom@tromey.com>
1793
1794         * source.c (select_source_symtab)
1795         (forget_cached_source_info_for_objfile): Remove declaration.
1796         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1797         declaration.
1798         * maint.c (count_symtabs_and_blocks): Remove declaration.
1799         * cp-support.c (add_symbol_overload_list_qualified): Remove
1800         declaration.
1801         * coffread.c (coff_symtab_read): Remove declaration.
1802         * symtab.c (lookup_symbol_in_objfile_symtabs)
1803         (basic_lookup_transparent_type_1): Use objfile_compunits.
1804         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1805         (info_sources_command, search_symbols)
1806         (default_collect_symbol_completion_matches_break_on)
1807         (make_source_files_completion_list): Remove declaration.
1808         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1809         (ada_collect_symbol_completion_matches)
1810         (ada_add_global_exceptions): Remove declaration.
1811         * linespec.c (iterate_over_all_matching_symtabs): Use
1812         objfile_compunits.
1813         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1814         (class objfile_compunits): New.
1815         (ALL_COMPUNITS): Use objfile_compunits.
1816         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1817         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1818         objfile_compunits.
1819         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1820
1821 2019-01-09  Tom Tromey  <tom@tromey.com>
1822
1823         * symtab.c (search_symbols)
1824         (default_collect_symbol_completion_matches_break_on): Use
1825         objfile_msymbols.
1826         * ada-lang.c (ada_lookup_simple_minsym)
1827         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1828         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1829         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1830         objfile_msymbols.
1831         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1832         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1833         * objc-lang.c (find_methods): Use objfile_msymbols.
1834         (info_selectors_command, info_classes_command): Likewise.
1835         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1836         * objfiles.h (class objfile_msymbols): New.
1837         (ALL_OBJFILE_MSYMBOLS): Remove.
1838         (ALL_MSYMBOLS): Remove.
1839
1840 2019-01-09  Tom Tromey  <tom@tromey.com>
1841
1842         * common/next-iterator.h (next_adapter): Add Iterator template
1843         parameter.
1844         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1845         (class all_objfiles_safe): New.
1846         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1847         * objfiles.c (put_objfile_before): Update comment.
1848         (add_separate_debug_objfile): Likewise.
1849         (free_all_objfiles): Use all_objfiles_safe.
1850         (objfile_purge_solibs): Likewise.
1851
1852 2019-01-09  Tom Tromey  <tom@tromey.com>
1853
1854         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1855         (expand_symtab_containing_pc, lookup_static_symbol)
1856         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1857         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1858         all_objfiles.
1859         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1860         * breakpoint.c (create_overlay_event_breakpoint)
1861         (create_longjmp_master_breakpoint)
1862         (create_std_terminate_master_breakpoint)
1863         (create_exception_master_breakpoint): Use all_objfiles.
1864         * linux-thread-db.c (try_thread_db_load_from_pdir)
1865         (has_libpthread): Use all_objfiles.
1866         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1867         * linespec.c (iterate_over_all_matching_symtabs)
1868         (search_minsyms_for_name): Use all_objfiles.
1869         * maint.c (maintenance_info_sections): Use all_objfiles.
1870         * main.c (captured_main_1): Use all_objfiles.
1871         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1872         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1873         * guile/scm-pretty-print.c
1874         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1875         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1876         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1877         (maintenance_print_msymbols): Use all_objfiles.
1878         * source.c (select_source_symtab): Use all_objfiles.
1879         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1880         * symfile.c (remove_symbol_file_command)
1881         (expand_symtabs_matching, map_symbol_filenames): Use
1882         all_objfiles.
1883         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1884         all_objfiles.
1885         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1886         * objc-lang.c (find_methods): Use all_objfiles.
1887         * objfiles.c (have_partial_symbols, have_full_symbols)
1888         (have_minimal_symbols, qsort_cmp)
1889         (default_iterate_over_objfiles_in_search_order): Use
1890         all_objfiles.
1891         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1892         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1893         (maintenance_check_psymtabs): Use all_objfiles.
1894         (ALL_PSYMTABS): Remove.
1895         * compile/compile-object-run.c (do_module_cleanup): Use
1896         all_objfiles.
1897         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1898         * cp-support.c (add_symbol_overload_list_qualified): Use
1899         all_objfiles.
1900         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1901         Use all_objfiles.
1902         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1903         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1904         all_objfiles.
1905         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1906         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1907         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1908         Uses all_objfiles.
1909         * solib.c (solib_read_symbols): Use all_objfiles
1910
1911 2019-01-09  Tom Tromey  <tom@tromey.com>
1912
1913         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1914         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1915         all_objfiles.
1916         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1917         * symmisc.c (print_symbol_bcache_statistics)
1918         (print_objfile_statistics, maintenance_print_objfiles)
1919         (maintenance_info_symtabs, maintenance_check_symtabs)
1920         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1921         all_objfiles.
1922         * source.c (forget_cached_source_info): Use all_objfiles.
1923         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1924         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1925         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1926         * objfiles.c (update_section_map): Use all_objfiles.
1927         (shared_objfile_contains_address_p): Likewise.
1928         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1929         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1930
1931 2019-01-09  Tom Tromey  <tom@tromey.com>
1932
1933         * common/next-iterator.h: New file.
1934         * objfiles.h (class all_objfiles): New.
1935         (struct objfile_iterator): New.
1936
1937 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1938
1939         * NEWS: Move the description of the changed "frame", "select-frame",
1940          and "info frame" commands to the Changed commands section.
1941
1942 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1943
1944         * gdbtypes.c (check_stub_method_group): Remove handling of old
1945         mangling schemes.
1946         * linespec.c (find_methods): Likewise.
1947         * stabsread.c (read_member_functions): Likewise.
1948         * valops.c (search_struct_method): Likewise.
1949         (value_struct_elt_for_reference): Likewise.
1950         * NEWS: Mention this change.
1951
1952 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1953
1954         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1955         print_source_lines.
1956         * source.c (print_source_lines_base): Update line number check.
1957         (print_source_lines): New function.
1958         (source_lines_range::source_lines_range): New function.
1959         * source.h (class source_lines_range): New class.
1960         (print_source_lines): New declaration.
1961
1962 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1963
1964         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1965
1966 2019-01-08  Tom Tromey  <tom@tromey.com>
1967             Simon Marchi  <simon.marchi@ericsson.com>
1968
1969         PR gdb/24060
1970         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1971         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1972         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1973         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1974         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1975         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1976
1977 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1978
1979         * source.c (select_source_symtab): Move header comment to
1980         declaration in source.h.
1981         (forget_cached_source_info_for_objfile): Likewise.
1982         (forget_cached_source_info): Likewise.
1983         (identify_source_line): Likewise.
1984         * source.h (identify_source_line): Move declaration from symtab.h
1985         and add comment from source.c
1986         (print_source_lines): Likewise.
1987         (forget_cached_source_info_for_objfile): Likewise.
1988         (forget_cached_source_info): Likewise.
1989         (select_source_symtab): Likewise.
1990         (enum print_source_lines_flag): Move definition from symtab.h.
1991         * symtab.h (identify_source_line): Move declaration to source.h.
1992         (print_source_lines): Likewise.
1993         (forget_cached_source_info_for_objfile): Likewise.
1994         (forget_cached_source_info): Likewise.
1995         (select_source_symtab): Likewise.
1996         (enum print_source_lines_flag): Move definition to source.h.
1997         * tui/tui-hooks.c: Add 'source.h' include.
1998
1999 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2000
2001         * source.c (print_source_lines_base): Handle requests to print
2002         reverse line number sequences, and guard against empty lines
2003         string.
2004
2005 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2006
2007         * source.c (print_source_lines_base): Fix skip of '\r' if next
2008         character is '\n'.
2009
2010 2019-01-06  Tom Tromey  <tom@tromey.com>
2011
2012         * c-exp.y (struct c_parse_state) <macro_original_text,
2013         expansion_obstack>: New member.
2014         (macro_original_text, expansion_obstack): Remove globals.
2015         (scan_macro_expansion, scanning_macro_expansion)
2016         (finished_macro_expansion): Update.
2017         (scan_macro_cleanup): Remove.
2018         (yylex, c_parse): Update.
2019
2020 2019-01-06  Tom Tromey  <tom@tromey.com>
2021
2022         * c-exp.y (struct c_parse_state) <strings>: New member.
2023         (operator_stoken): Update.
2024
2025 2019-01-06  Tom Tromey  <tom@tromey.com>
2026
2027         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2028         (union type_stack_elt) <typelist_val>: Now a pointer to
2029         std::vector.
2030         (type_stack_cleanup): Don't declare.
2031         (push_typelist): Update.
2032         * parse.c (pop_typelist): Return a std::vector.
2033         (push_typelist): Take a std::vector.
2034         (follow_types): Update.  Do not free args.
2035         (type_stack_cleanup): Remove.
2036         * c-exp.y (struct c_parse_state): New.
2037         (cpstate): New global.
2038         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2039         (nonempty_typelist): Update.
2040         (func_mod): Create a new vector.
2041         (c_parse): Create a c_parse_state.
2042         (check_parameter_typelist): Do not delete params.
2043         (function_method): Update.  Do not delete type_list.
2044
2045 2019-01-06  Tom Tromey  <tom@tromey.com>
2046
2047         PR gdb/28155:
2048         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2049         check_typedef.
2050         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2051         (print_return_value): Likewise.
2052
2053 2019-01-05  Tom Tromey  <tom@tromey.com>
2054
2055         * contrib/cleanup_check.py: Remove.
2056         * contrib/gcc-with-excheck: Remove.
2057         * contrib/exsummary.py: Remove.
2058         * contrib/excheck.py: Remove.
2059
2060 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2061
2062         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2063         NULL. Initialize tpprev to NULL instead of assigning it
2064         to NULL on the next statement.
2065         * windows-nat.c (windows_delete_thread): Remove check for
2066         main_thread_id before printing thread exit notifications.
2067         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2068         Remove thread ID check against main_thread_id.
2069         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2070         windows_delete_thread.
2071         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2072
2073 2019-01-04  Tom Tromey  <tom@tromey.com>
2074
2075         * compile/compile.c (_initialize_compile): Use upper case for
2076         metasyntactic variables.
2077         * symmisc.c (_initialize_symmisc): Use upper case for
2078         metasyntactic variables.
2079         * psymtab.c (_initialize_psymtab): Use upper case for
2080         metasyntactic variables.
2081         * demangle.c (demangle_command): Use upper case for metasyntactic
2082         variables.
2083         (_initialize_demangler): Likewise.
2084         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2085         variables.
2086
2087 2019-01-03  Tom Tromey  <tom@tromey.com>
2088
2089         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2090
2091 2019-01-03  Tom Tromey  <tom@tromey.com>
2092
2093         * python/py-symtab.c (salpy_str): Update.
2094         (struct salpy_sal_object) <symtab>: Now a PyObject.
2095         (salpy_dealloc): Update.
2096         (del_objfile_sal): Use gdbpy_ref.
2097
2098 2019-01-03  Tom Tromey  <tom@tromey.com>
2099
2100         * python/py-type.c (convert_field): Use new_reference.  Return
2101         gdbpy_ref.
2102         (make_fielditem): Return gdbpy_ref.
2103         (typy_fields): Update.
2104         (typy_getitem): Update.
2105         (field_name): Return gdbpy_ref.  Use new_reference.
2106         (typy_iterator_iternext): Update.
2107
2108 2019-01-03  Tom Tromey  <tom@tromey.com>
2109
2110         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2111
2112 2019-01-03  Tom Tromey  <tom@tromey.com>
2113
2114         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2115         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2116         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2117         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2118         (pspy_set_type_printers): Likewise.
2119         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2120         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2121         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2122         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2123         (objfpy_set_type_printers): Likewise.
2124
2125 2019-01-03  Tom Tromey  <tom@tromey.com>
2126
2127         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2128         (gdbpy_print_stack): Use gdbpy_err_fetch.
2129         * python/python-internal.h (class gdbpy_err_fetch): New class.
2130         (class gdbpy_enter) <m_error_type, m_error_value,
2131         m_error_traceback>: Remove.
2132         <m_error>: New member.
2133         (gdbpy_exception_to_string): Don't declare.
2134         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2135         * python/py-value.c (convert_value_from_python): Use
2136         gdbpy_err_fetch.
2137         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2138         gdbpy_exception_to_string.
2139         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2140         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2141         gdbpy_err_fetch.
2142
2143 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2144
2145         * linux-nat.c (delete_lwp_cleanup): Delete.
2146         (struct lwp_deleter): New struct.
2147         (lwp_info_up): New typedef.
2148         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2149         lwp_info_up.
2150
2151 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2152
2153         * linux-fork.c (class scoped_switch_fork_info): New class.
2154         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2155
2156 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2157
2158         * valops.c (find_overload_match): Remove use of null_cleanup, and
2159         calls to do_cleanups.
2160
2161 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2162
2163         * compile/compile-cplus-types.c
2164         (compile_cplus_instance::decl_name): Handle changes to
2165         cp_func_name.
2166         * cp-support.c (cp_func_name): Update header comment, update
2167         return type.
2168         * cp-support.h (cp_func_name): Update return type in declaration.
2169         * valops.c (find_overload_match): Move temp_func local to top
2170         level of function and change its type.  Use temp_func to hold and
2171         delete temporary string obtained from cp_func_name.
2172
2173 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2174
2175         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2176         gdb::char_vector, remove cleanup, and update uses of `msg`.
2177
2178 2019-01-03  Jim Wilson  <jimw@sifive.com>
2179
2180         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2181
2182 2019-01-02  Tom Tromey  <tom@tromey.com>
2183
2184         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2185         (tdesc_parse_xml): Remove cleanups.
2186         * target-descriptions.h (make_cleanup_free_target_description):
2187         Don't declare.
2188         (target_desc_deleter): New struct.
2189         (target_desc_up): New typedef.
2190         * target-descriptions.c (target_desc_deleter::operator()): Rename
2191         from free_target_description.
2192         (make_cleanup_free_target_description): Remove.
2193
2194 2019-01-02  Tom Tromey  <tom@tromey.com>
2195
2196         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2197         constructor, destructor.
2198         (linespec_parser): Remove typedef.
2199         (~linespec_parser): Rename from linespec_parser_delete.
2200         (linespec_lex_to_end, linespec_complete_label)
2201         (linespec_complete): Update.
2202         (decode_line_full): Remove cleanups.
2203         (decode_line_1): Update.
2204
2205 2019-01-02  Tom Tromey  <tom@tromey.com>
2206
2207         * python/python-internal.h (inferior_to_inferior_object): Change
2208         return type.
2209         * python/py-exitedevent.c (create_exited_event_object): Update.
2210         * python/py-inferior.c (inferior_to_inferior_object): Return
2211         gdbpy_ref.
2212         (python_new_inferior, python_inferior_deleted)
2213         (thread_to_thread_object, delete_thread_object)
2214         (build_inferior_list, gdbpy_selected_inferior): Update.
2215         * python/py-infthread.c (create_thread_object): Update.  Also fail
2216         if inferior_to_inferior_object fails.
2217
2218 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2219
2220         * inferior.h (class inferior) <displaced_step_state>: New field.
2221         * infrun.h (struct displaced_step_state): Move here from
2222         infrun.c.  Initialize fields, add constructor.
2223         <inf>: Remove field.
2224         <reset>: New method.
2225         * infrun.c (struct displaced_step_inferior_state): Move to
2226         infrun.h.
2227         (displaced_step_inferior_states): Remove.
2228         (get_displaced_stepping_state): Adust.
2229         (displaced_step_in_progress_any_inferior): Adjust.
2230         (displaced_step_in_progress_thread): Adjust.
2231         (displaced_step_in_progress): Adjust.
2232         (add_displaced_stepping_state): Remove.
2233         (get_displaced_step_closure_by_addr): Adjust.
2234         (remove_displaced_stepping_state): Remove.
2235         (infrun_inferior_exit): Call displaced_step_state.reset.
2236         (use_displaced_stepping): Don't check for NULL.
2237         (displaced_step_prepare_throw): Call
2238         get_displaced_stepping_state.
2239         (displaced_step_fixup): Don't check for NULL.
2240         (prepare_for_detach): Don't check for NULL.
2241
2242 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2243
2244         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2245          in case of call that did not complete.
2246
2247 2019-01-02  Andrey Utkin  <autkin@undo.io>
2248
2249         * symfile.c (find_separate_debug_file): Fix search of debug files for
2250         remote debuggee.
2251
2252 2019-01-02  Tom Tromey  <tom@tromey.com>
2253
2254         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2255         indentation.
2256         * python/py-frame.c (frapy_older): Remove cast.
2257         (frapy_newer): Likewise.
2258         * python/py-breakpoint.c (local_setattro): Remove cast.
2259         * python/py-arch.c (archpy_name): Remove local variable.
2260         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2261
2262 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2263
2264         * unittests/basic_string_view/element_access/char/empty.cc:
2265         Fix year range in copyright header.
2266
2267 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2268
2269         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2270         Delete.
2271         <operator==>: Update with for removed field.
2272         <hash>: Likewise.
2273         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2274         <isa_features>: ...this.
2275         <abi_features>: New field.
2276         (riscv_isa_flen): Update comment.
2277         (riscv_abi_xlen): New declaration.
2278         (riscv_abi_flen): New declaration.
2279         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2280         isa_features.
2281         (riscv_abi_xlen): New function.
2282         (riscv_isa_flen): Update to get answer from isa_features.
2283         (riscv_abi_flen): New function.
2284         (riscv_has_fp_abi): Update to get answer from abi_features.
2285         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2286         xlen and flen.
2287         (riscv_call_info) <xlen, flen>: Update comment.
2288         (riscv_call_arg_struct): Remove invalid assertions
2289         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2290         is removed.
2291         (riscv_gdbarch_init): Gather isa features and abi features
2292         separately, ensure both match on the gdbarch when reusing an old
2293         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2294         a target with 64-bit float hardware.
2295
2296 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2297
2298         * source.c (search_command_helper): Stop reverse search
2299         when line 1 has been searched.
2300
2301 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2302
2303         * record-full.c (record_full_base_target::close): Rewrite
2304         record_full_core_buf_list free logic.
2305
2306 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2307
2308         * break-catch-syscall.c (print_one_catch_syscall): xfree
2309         the last text.
2310
2311 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2312
2313         * top.c (print_gdb_version): Update Copyright year in version
2314         message.
2315
2316 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2317
2318         Update copyright year range in all GDB files.
2319
2320 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2321
2322         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2323
2324 For older changes see ChangeLog-2018.
2325 \f
2326 Local Variables:
2327 mode: change-log
2328 left-margin: 8
2329 fill-column: 74
2330 version-control: never
2331 coding: utf-8
2332 End:
2333