gdb/ChangeLog

   1 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * gdbarch.sh: Update the copyright year range that is placed into
   4         generated files.
   5
   6 2019-02-22  Keith Seitz  <keiths@redhat.com>
   7
   8         PR symtab/23853
   9         * linespec.c (create_sals_line_offset): Search for the default
  10         symtab's filename instead of its fullname.
  11
  12 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  13
  14         * NEWS: Update style defaults.
  15
  16 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  17
  18         * main.c (captured_main_1): Disable styling in batch mode.
  19
  20 2019-02-20  Tom Tromey  <tom@tromey.com>
  21
  22         * symtab.c (symtab_symbol_info): Fix typos.
  23
  24 2019-02-20  Tom Tromey  <tromey@adacore.com>
  25
  26         * findcmd.c (_initialize_mem_search): Use upper case for
  27         metasyntactic variables.
  28
  29 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  30
  31         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  32         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  33
  34 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  35
  36         * top.h (source_file_name): Change to std::string.
  37         * top.c (source_file_name): Likewise.
  38         (command_line_input): Adjust.
  39         * cli/cli-script.c (script_from_file): Adjust.
  40
  41 2019-02-19  Tom Tromey  <tromey@adacore.com>
  42
  43         * ravenscar-thread.c
  44         (ravenscar_thread_target::update_thread_list): Don't call
  45         ada_build_task_list.
  46         * ada-lang.h (ada_build_task_list): Don't declare.
  47         * ada-tasks.c (struct ada_tasks_inferior_data)
  48         <task_list_valid_p>: Now bool.
  49         (read_known_tasks, ada_task_list_changed)
  50         (ada_tasks_invalidate_inferior_data): Update.
  51         (read_known_tasks_array): Return bool.
  52         (read_known_tasks_list): Likewise.
  53         (read_known_tasks): Return void.
  54         (ada_build_task_list): Now static.
  55
  56 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  57
  58         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  59         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
  60
  61 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  62
  63         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
  64         variant for ada_tasks_pspace_data_handle and
  65         ada_tasks_inferior_data_handle.
  66         (ada_tasks_pspace_data_cleanup): New function.
  67         (ada_tasks_inferior_data_cleanup): New function.
  68
  69 2019-02-17  Tom Tromey  <tom@tromey.com>
  70
  71         * macrotab.h (macro_source_fullname): Return a std::string.
  72         * macrotab.c (macro_include, check_for_redefinition)
  73         (macro_undef, macro_lookup_definition, foreach_macro)
  74         (foreach_macro_in_scope): Update.
  75         (macro_source_fullname): Return a std::string.
  76         * macrocmd.c (show_pp_source_pos): Update.
  77
  78 2019-02-17  Tom Tromey  <tom@tromey.com>
  79
  80         * macrocmd.c (show_pp_source_pos): Style the file names.
  81
  82 2019-02-17  Tom Tromey  <tom@tromey.com>
  83
  84         PR tui/24197:
  85         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
  86
  87 2019-02-17  Tom Tromey  <tom@tromey.com>
  88
  89         * ada-lang.c (user_select_syms): Use filtered printing.
  90         * utils.c (wrap_style): New global.
  91         (desired_style): Remove.
  92         (emit_style_escape): Add stream parameter.
  93         (set_output_style, reset_terminal_style, prompt_for_continue):
  94         Update.
  95         (flush_wrap_buffer): Only flush gdb_stdout.
  96         (wrap_here): Set wrap_style.
  97         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  98         treat escape sequences as a character.  Change when wrap buffer is
  99         flushed.
 100         (fputs_styled): Do not set the output style when the default is
 101         requested.
 102         * ui-style.h (struct ui_file_style) <is_default>: New method.
 103         * source.c (print_source_lines_base): Emit escape sequences in one
 104         piece.
 105
 106 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 107
 108         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 109         integers and enumeration types.
 110
 111 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 112
 113         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 114         instead of lookup_symbol_in_language
 115         (do_exact_match): New function.
 116         (ada_get_symbol_name_matcher): Return do_exact_match when
 117         doing a verbatim match.
 118
 119 2019-02-15  Tom Tromey  <tromey@adacore.com>
 120
 121         * ravenscar-thread.c (ravenscar_thread_target::resume)
 122         (ravenscar_thread_target::wait): Special case wildcard requests.
 123
 124 2019-02-15  Tom Tromey  <tromey@adacore.com>
 125
 126         * ravenscar-thread.c (base_ptid): Remove.
 127         (struct ravenscar_thread_target) <close>: New method.
 128         <m_base_ptid>: New member.
 129         <update_inferior_ptid, active_task, task_is_currently_active,
 130         runtime_initialized>: Declare methods.
 131         <ravenscar_thread_target>: Add constructor.
 132         (ravenscar_thread_target::task_is_currently_active)
 133         (ravenscar_thread_target::update_inferior_ptid)
 134         (ravenscar_runtime_initialized): Rename.  Now methods.
 135         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 136         (ravenscar_thread_target::update_thread_list): Update.
 137         (ravenscar_thread_target::active_task): Now method.
 138         (ravenscar_thread_target::store_registers)
 139         (ravenscar_thread_target::prepare_to_store)
 140         (ravenscar_thread_target::prepare_to_store)
 141         (ravenscar_thread_target::mourn_inferior): Update.
 142         (ravenscar_inferior_created): Use "new" to create target.
 143         (ravenscar_thread_target::get_ada_task_ptid): Update.
 144         (_initialize_ravenscar): Don't initialize base_ptid.
 145         (ravenscar_ops): Remove global.
 146
 147 2019-02-15  Tom Tromey  <tromey@adacore.com>
 148
 149         * target.h (push_target): Declare new overload.
 150         * target.c (push_target): New overload, taking an rvalue reference.
 151         * remote.c (remote_target::open_1): Use push_target overload.
 152         * corelow.c (core_target_open): Use push_target overload.
 153
 154 2019-02-15  Tom Tromey  <tromey@adacore.com>
 155
 156         * ravenscar-thread.c (is_ravenscar_task)
 157         (ravenscar_task_is_currently_active): Return bool.
 158         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 159         (_initialize_ravenscar): Remove "(void)".
 160         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 161         Return bool.
 162
 163 2019-02-15  Tom Tromey  <tromey@adacore.com>
 164
 165         * ravenscar-thread.c (ravenscar_runtime_initializer)
 166         (has_ravenscar_runtime, get_running_thread_id)
 167         (ravenscar_thread_target::resume): Fix indentation.
 168
 169 2019-02-15  Tom Tromey  <tromey@adacore.com>
 170
 171         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 172         from ravenscar_arch_ops.
 173         (sparc_ravenscar_ops::fetch_registers)
 174         (sparc_ravenscar_ops::store_registers): Now methods.
 175         (sparc_ravenscar_prepare_to_store): Remove.
 176         (sparc_ravenscar_ops): Redefine.
 177         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 178         methods and destructor.  Remove members.
 179         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 180         (ravenscar_thread_target::store_registers)
 181         (ravenscar_thread_target::prepare_to_store): Update.
 182         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 183         Remove.
 184         (struct ppc_ravenscar_powerpc_ops): Derive from
 185         ravenscar_arch_ops.
 186         (ppc_ravenscar_powerpc_ops::fetch_registers)
 187         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 188         (ppc_ravenscar_powerpc_ops): Redefine.
 189         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 190         (ppc_ravenscar_e500_ops::fetch_registers)
 191         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 192         (ppc_ravenscar_e500_ops): Redefine.
 193         * aarch64-ravenscar-thread.c
 194         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 195         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 196         (aarch64_ravenscar_fetch_registers)
 197         (aarch64_ravenscar_store_registers): Now methods.
 198         (aarch64_ravenscar_ops): Redefine.
 199
 200 2019-02-15  Tom Tromey  <tromey@adacore.com>
 201
 202         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 203         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 204         (ravenscar_thread_target::stopped_by_watchpoint)
 205         (ravenscar_thread_target::stopped_data_address)
 206         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 207
 208 2019-02-15  Tom Tromey  <tromey@adacore.com>
 209
 210         * ravenscar-thread.c: Fix some typos.
 211
 212 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 213             Tom Tromey  <tromey@adacore.com>
 214
 215         * ada-lang.c (ada_exception_sal): Change addr_string to a
 216         std::string.
 217         (create_ada_exception_catchpoint): Update.
 218
 219 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 220             Tom Tromey  <tromey@adacore.com>
 221
 222         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 223         (bp_location_ops): Remove.
 224         (base_breakpoint_allocate_location): Update.
 225         (free_bp_location): Update.
 226         * ada-lang.c (class ada_catchpoint_location)
 227         <ada_catchpoint_location>: Remove ops parameter.
 228         (ada_catchpoint_location_dtor): Remove.
 229         (ada_catchpoint_location_ops): Remove.
 230         (allocate_location_exception): Update.
 231         * breakpoint.h (struct bp_location_ops): Remove.
 232         (class bp_location) <bp_location>: Remove bp_location_ops
 233         parameter.
 234         <~bp_location>: Add destructor.
 235         <ops>: Remove.
 236
 237 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 238             Pedro Alves  <palves@redhat.com>
 239
 240         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 241         'PATH_MAX'.
 242
 243 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 244             Samuel Thibault  <samuel.thibault@gnu.org>
 245             Thomas Schwinge  <thomas@codesourcery.com>
 246
 247         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 248         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 249
 250 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 251
 252         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 253         (check_empty): Use "const char *".
 254
 255         * gnu-nat.c (gnu_nat_target::detach): Instead of
 256         'detach_inferior (pid)' call
 257         'detach_inferior (find_inferior_pid (pid))'.
 258
 259         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 260         'nat/fork-inferior.o'.
 261         * gnu-nat.c: #include "nat/fork-inferior.h".
 262
 263         * gnu-nat.c (gnu_nat_target::detach): Instead of
 264         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 265         * gnu-nat.h: #include "inf-child.h".
 266         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 267         'i386_gnu_nat_target::fetch_registers'.
 268         (gnu_store_registers): Rename/move to
 269         'i386_gnu_nat_target::store_registers'.
 270
 271         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 272         * gnu-nat.h (mach_thread_info): New function.
 273         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 274
 275         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 276
 277 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 278
 279         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 280
 281 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 282
 283         * windows-nat.c (windows_add_thread): Add new parameter
 284         "main_thread_p" with default value set to false.  Update
 285         function documentation as well as all callers.
 286         (windows_delete_thread): Likewise.
 287         (fake_create_process): Update call to windows_add_thread.
 288         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 289         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 290         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 291         call to windows_delete_thread.
 292
 293 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 294
 295         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 296
 297 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 298
 299         * symfile.c (find_separate_debug_file): Use canonical path of
 300         sysroot with child_path instead of gdb_sysroot if it is valid.
 301
 302 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 303
 304         * symfile.c (find_separate_debug_file): Use child_path to
 305         determine if an object file is under a sysroot.
 306
 307 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 308
 309         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 310         unittests/child-path-selftests.c.
 311         * common/pathstuff.c (child_path): New function.
 312         * common/pathstuff.h (child_path): New prototype.
 313         * unittests/child-path-selftests.c: New file.
 314
 315 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 316
 317         * symfile.c (find_separate_debug_file): Look for separate debug
 318         files in debug directories under the sysroot.
 319
 320 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 321
 322         * symtab.h (struct minimal_symbol data_p): New const method.
 323         (struct minimal_symbol text_p): Likewise.
 324         * symtab.c (output_source_filename): Use file name style
 325         to print file name.
 326         (print_symbol_info): Likewise.
 327         (print_msymbol_info): Use address style to print addresses.
 328         Use function name style to print executable text symbols.
 329         (expand_symtab_containing_pc): Use data_p.
 330         (find_pc_sect_compunit_symtab): Likewise.
 331
 332 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 333
 334         * breakpoint.c (describe_other_breakpoints): Use address style
 335         to print addresses.
 336         (say_where): Likewise.
 337
 338 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 339
 340         * ada-typeprint.c (print_func_type): Print function name
 341         style to print function name.
 342         * c-typeprint.c (c_print_type_1): Likewise.
 343
 344 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 345
 346         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 347         for execve.
 348
 349 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 350
 351         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 352         type_stack.
 353
 354 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 355
 356         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 357         TYPE_CODE_REF types.
 358
 359 2019-02-08  Jim Wilson  <jimw@sifive.com>
 360
 361         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 362         (riscv_linux_fregset): New.
 363         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 364
 365 2019-02-07  Tom Tromey  <tom@tromey.com>
 366
 367         * thread.c (thread_cancel_execution_command): Update.
 368         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 369         methods.
 370         (struct thread_fsm_ops): Remove.
 371         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 372         (thread_fsm_should_stop, thread_fsm_return_value)
 373         (thread_fsm_set_finished, thread_fsm_finished_p)
 374         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 375         Don't declare.
 376         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 377         * infrun.c (clear_proceed_status_thread)
 378         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 379         (print_stop_event): Update.
 380         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 381         Add constructor.
 382         (step_command_fsm_ops): Remove.
 383         (new_step_command_fsm): Remove.
 384         (step_1): Update.
 385         (step_command_fsm::should_stop): Rename from
 386         step_command_fsm_should_stop.
 387         (step_command_fsm::clean_up): Rename from
 388         step_command_fsm_clean_up.
 389         (step_command_fsm::do_async_reply_reason): Rename from
 390         step_command_fsm_async_reply_reason.
 391         (struct until_next_fsm): Inherit from thread_fsm.  Add
 392         constructor.
 393         (until_next_fsm_ops): Remove.
 394         (new_until_next_fsm): Remove.
 395         (until_next_fsm::should_stop): Rename from
 396         until_next_fsm_should_stop.
 397         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 398         (until_next_fsm::do_async_reply_reason): Rename from
 399         until_next_fsm_async_reply_reason.
 400         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 401         constructor.  Change type of breakpoint.
 402         (finish_command_fsm_ops): Remove.
 403         (new_finish_command_fsm): Remove.
 404         (finish_command_fsm::should_stop): Rename from
 405         finish_command_fsm_should_stop.
 406         (finish_command_fsm::clean_up): Rename from
 407         finish_command_fsm_clean_up.
 408         (finish_command_fsm::return_value): Rename from
 409         finish_command_fsm_return_value.
 410         (finish_command_fsm::do_async_reply_reason): Rename from
 411         finish_command_fsm_async_reply_reason.
 412         (finish_command): Update.
 413         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 414         Add constructor.
 415         (call_thread_fsm_ops): Remove.
 416         (call_thread_fsm::call_thread_fsm): Rename from
 417         new_call_thread_fsm.
 418         (call_thread_fsm::should_stop): Rename from
 419         call_thread_fsm_should_stop.
 420         (call_thread_fsm::should_notify_stop): Rename from
 421         call_thread_fsm_should_notify_stop.
 422         (run_inferior_call, call_function_by_hand_dummy): Update.
 423         * cli/cli-interp.c (should_print_stop_to_console): Update.
 424         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 425         Add constructor.  Change type of location_breakpoint,
 426         caller_breakpoint.
 427         (until_break_fsm_ops): Remove.
 428         (new_until_break_fsm): Remove.
 429         (until_break_fsm::should_stop): Rename from
 430         until_break_fsm_should_stop.
 431         (until_break_fsm::clean_up): Rename from
 432         until_break_fsm_clean_up.
 433         (until_break_fsm::do_async_reply_reason): Rename from
 434         until_break_fsm_async_reply_reason.
 435         (until_break_command): Update.
 436         * thread-fsm.c: Remove.
 437         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 438
 439 2019-02-07  Tom Tromey  <tom@tromey.com>
 440
 441         * yy-remap.h: Add include guard.
 442         * xtensa-tdep.h: Add include guard.
 443         * xcoffread.h: Rename include guard.
 444         * varobj-iter.h: Add include guard.
 445         * tui/tui.h: Rename include guard.
 446         * tui/tui-winsource.h: Rename include guard.
 447         * tui/tui-wingeneral.h: Rename include guard.
 448         * tui/tui-windata.h: Rename include guard.
 449         * tui/tui-win.h: Rename include guard.
 450         * tui/tui-stack.h: Rename include guard.
 451         * tui/tui-source.h: Rename include guard.
 452         * tui/tui-regs.h: Rename include guard.
 453         * tui/tui-out.h: Rename include guard.
 454         * tui/tui-layout.h: Rename include guard.
 455         * tui/tui-io.h: Rename include guard.
 456         * tui/tui-hooks.h: Rename include guard.
 457         * tui/tui-file.h: Rename include guard.
 458         * tui/tui-disasm.h: Rename include guard.
 459         * tui/tui-data.h: Rename include guard.
 460         * tui/tui-command.h: Rename include guard.
 461         * tic6x-tdep.h: Add include guard.
 462         * target/waitstatus.h: Rename include guard.
 463         * target/wait.h: Rename include guard.
 464         * target/target.h: Rename include guard.
 465         * target/resume.h: Rename include guard.
 466         * target-float.h: Rename include guard.
 467         * stabsread.h: Add include guard.
 468         * rs6000-tdep.h: Add include guard.
 469         * riscv-fbsd-tdep.h: Add include guard.
 470         * regformats/regdef.h: Rename include guard.
 471         * record.h: Rename include guard.
 472         * python/python.h: Rename include guard.
 473         * python/python-internal.h: Rename include guard.
 474         * python/py-stopevent.h: Rename include guard.
 475         * python/py-ref.h: Rename include guard.
 476         * python/py-record.h: Rename include guard.
 477         * python/py-record-full.h: Rename include guard.
 478         * python/py-record-btrace.h: Rename include guard.
 479         * python/py-instruction.h: Rename include guard.
 480         * python/py-events.h: Rename include guard.
 481         * python/py-event.h: Rename include guard.
 482         * procfs.h: Add include guard.
 483         * proc-utils.h: Add include guard.
 484         * p-lang.h: Add include guard.
 485         * or1k-tdep.h: Rename include guard.
 486         * observable.h: Rename include guard.
 487         * nto-tdep.h: Rename include guard.
 488         * nat/x86-linux.h: Rename include guard.
 489         * nat/x86-linux-dregs.h: Rename include guard.
 490         * nat/x86-gcc-cpuid.h: Add include guard.
 491         * nat/x86-dregs.h: Rename include guard.
 492         * nat/x86-cpuid.h: Rename include guard.
 493         * nat/ppc-linux.h: Rename include guard.
 494         * nat/mips-linux-watch.h: Rename include guard.
 495         * nat/linux-waitpid.h: Rename include guard.
 496         * nat/linux-ptrace.h: Rename include guard.
 497         * nat/linux-procfs.h: Rename include guard.
 498         * nat/linux-osdata.h: Rename include guard.
 499         * nat/linux-nat.h: Rename include guard.
 500         * nat/linux-namespaces.h: Rename include guard.
 501         * nat/linux-btrace.h: Rename include guard.
 502         * nat/glibc_thread_db.h: Rename include guard.
 503         * nat/gdb_thread_db.h: Rename include guard.
 504         * nat/gdb_ptrace.h: Rename include guard.
 505         * nat/fork-inferior.h: Rename include guard.
 506         * nat/amd64-linux-siginfo.h: Rename include guard.
 507         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 508         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 509         * nat/aarch64-linux.h: Rename include guard.
 510         * nat/aarch64-linux-hw-point.h: Rename include guard.
 511         * mn10300-tdep.h: Add include guard.
 512         * mips-linux-tdep.h: Add include guard.
 513         * mi/mi-parse.h: Rename include guard.
 514         * mi/mi-out.h: Rename include guard.
 515         * mi/mi-main.h: Rename include guard.
 516         * mi/mi-interp.h: Rename include guard.
 517         * mi/mi-getopt.h: Rename include guard.
 518         * mi/mi-console.h: Rename include guard.
 519         * mi/mi-common.h: Rename include guard.
 520         * mi/mi-cmds.h: Rename include guard.
 521         * mi/mi-cmd-break.h: Rename include guard.
 522         * m2-lang.h: Add include guard.
 523         * location.h: Rename include guard.
 524         * linux-record.h: Rename include guard.
 525         * linux-nat.h: Add include guard.
 526         * linux-fork.h: Add include guard.
 527         * i386-darwin-tdep.h: Rename include guard.
 528         * hppa-linux-offsets.h: Add include guard.
 529         * guile/guile.h: Rename include guard.
 530         * guile/guile-internal.h: Rename include guard.
 531         * gnu-nat.h: Rename include guard.
 532         * gdb-stabs.h: Rename include guard.
 533         * frv-tdep.h: Add include guard.
 534         * f-lang.h: Add include guard.
 535         * event-loop.h: Add include guard.
 536         * darwin-nat.h: Rename include guard.
 537         * cp-abi.h: Rename include guard.
 538         * config/sparc/nm-sol2.h: Rename include guard.
 539         * config/nm-nto.h: Rename include guard.
 540         * config/nm-linux.h: Add include guard.
 541         * config/i386/nm-i386gnu.h: Rename include guard.
 542         * config/djgpp/nl_types.h: Rename include guard.
 543         * config/djgpp/langinfo.h: Rename include guard.
 544         * compile/gcc-cp-plugin.h: Add include guard.
 545         * compile/gcc-c-plugin.h: Add include guard.
 546         * compile/compile.h: Rename include guard.
 547         * compile/compile-object-run.h: Rename include guard.
 548         * compile/compile-object-load.h: Rename include guard.
 549         * compile/compile-internal.h: Rename include guard.
 550         * compile/compile-cplus.h: Rename include guard.
 551         * compile/compile-c.h: Rename include guard.
 552         * common/xml-utils.h: Rename include guard.
 553         * common/x86-xstate.h: Rename include guard.
 554         * common/version.h: Rename include guard.
 555         * common/vec.h: Rename include guard.
 556         * common/tdesc.h: Rename include guard.
 557         * common/selftest.h: Rename include guard.
 558         * common/scoped_restore.h: Rename include guard.
 559         * common/scoped_mmap.h: Rename include guard.
 560         * common/scoped_fd.h: Rename include guard.
 561         * common/safe-iterator.h: Rename include guard.
 562         * common/run-time-clock.h: Rename include guard.
 563         * common/refcounted-object.h: Rename include guard.
 564         * common/queue.h: Rename include guard.
 565         * common/ptid.h: Rename include guard.
 566         * common/print-utils.h: Rename include guard.
 567         * common/preprocessor.h: Rename include guard.
 568         * common/pathstuff.h: Rename include guard.
 569         * common/observable.h: Rename include guard.
 570         * common/netstuff.h: Rename include guard.
 571         * common/job-control.h: Rename include guard.
 572         * common/host-defs.h: Rename include guard.
 573         * common/gdb_wait.h: Rename include guard.
 574         * common/gdb_vecs.h: Rename include guard.
 575         * common/gdb_unlinker.h: Rename include guard.
 576         * common/gdb_unique_ptr.h: Rename include guard.
 577         * common/gdb_tilde_expand.h: Rename include guard.
 578         * common/gdb_sys_time.h: Rename include guard.
 579         * common/gdb_string_view.h: Rename include guard.
 580         * common/gdb_splay_tree.h: Rename include guard.
 581         * common/gdb_setjmp.h: Rename include guard.
 582         * common/gdb_ref_ptr.h: Rename include guard.
 583         * common/gdb_optional.h: Rename include guard.
 584         * common/gdb_locale.h: Rename include guard.
 585         * common/gdb_assert.h: Rename include guard.
 586         * common/filtered-iterator.h: Rename include guard.
 587         * common/filestuff.h: Rename include guard.
 588         * common/fileio.h: Rename include guard.
 589         * common/environ.h: Rename include guard.
 590         * common/common-utils.h: Rename include guard.
 591         * common/common-types.h: Rename include guard.
 592         * common/common-regcache.h: Rename include guard.
 593         * common/common-inferior.h: Rename include guard.
 594         * common/common-gdbthread.h: Rename include guard.
 595         * common/common-exceptions.h: Rename include guard.
 596         * common/common-defs.h: Rename include guard.
 597         * common/common-debug.h: Rename include guard.
 598         * common/cleanups.h: Rename include guard.
 599         * common/buffer.h: Rename include guard.
 600         * common/btrace-common.h: Rename include guard.
 601         * common/break-common.h: Rename include guard.
 602         * cli/cli-utils.h: Rename include guard.
 603         * cli/cli-style.h: Rename include guard.
 604         * cli/cli-setshow.h: Rename include guard.
 605         * cli/cli-script.h: Rename include guard.
 606         * cli/cli-interp.h: Rename include guard.
 607         * cli/cli-decode.h: Rename include guard.
 608         * cli/cli-cmds.h: Rename include guard.
 609         * charset-list.h: Add include guard.
 610         * buildsym-legacy.h: Rename include guard.
 611         * bfin-tdep.h: Add include guard.
 612         * ax.h: Rename include guard.
 613         * arm-linux-tdep.h: Add include guard.
 614         * arm-fbsd-tdep.h: Add include guard.
 615         * arch/xtensa.h: Rename include guard.
 616         * arch/tic6x.h: Add include guard.
 617         * arch/i386.h: Add include guard.
 618         * arch/arm.h: Rename include guard.
 619         * arch/arm-linux.h: Rename include guard.
 620         * arch/arm-get-next-pcs.h: Rename include guard.
 621         * arch/amd64.h: Add include guard.
 622         * arch/aarch64-insn.h: Rename include guard.
 623         * arch-utils.h: Rename include guard.
 624         * annotate.h: Add include guard.
 625         * amd64-darwin-tdep.h: Rename include guard.
 626         * aarch64-linux-tdep.h: Add include guard.
 627         * aarch64-fbsd-tdep.h: Add include guard.
 628         * aarch32-linux-nat.h: Add include guard.
 629
 630 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 631
 632         * macrotab.c (macro_define_internal): New function that
 633         factorizes macro_define_object_internal and macro_define_function
 634         code.
 635         (macro_define_object_internal): Use macro_define_internal.
 636         (macro_define_function): Likewise.
 637
 638 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 639
 640         * macrocmd.c (extract_identifier): Return
 641         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 642         callers.
 643
 644 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 645
 646         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 647
 648 2019-02-05  Tom Tromey  <tom@tromey.com>
 649
 650         * target.c (target_stack::unpush): Move assertion earlier.
 651
 652 2019-01-30  Tom Tromey  <tom@tromey.com>
 653
 654         PR python/23615:
 655         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 656         (gdbpy_parse_and_eval): Likewise.
 657         * python/python-internal.h (gdbpy_allow_threads): New class.
 658
 659 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 660
 661         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 662         (aarch64_fbsd_fpregmap): Move earlier.
 663         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 664         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 665         instead of individual calls to trad_frame_set_reg_addr.
 666         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 667         earlier.
 668         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 669         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 670         instead of individual calls to trad_frame_set_reg_addr.
 671
 672 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 673
 674         * CONTRIBUTE: Replace contribution list with wiki link.
 675
 676 2019-01-25  Tom Tromey  <tom@tromey.com>
 677
 678         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 679
 680 2019-01-25  Tom Tromey  <tom@tromey.com>
 681
 682         * xtensa-linux-nat.c: Fix common/ includes.
 683         * xml-support.h: Fix common/ includes.
 684         * xml-support.c: Fix common/ includes.
 685         * x86-linux-nat.c: Fix common/ includes.
 686         * windows-nat.c: Fix common/ includes.
 687         * varobj.h: Fix common/ includes.
 688         * varobj.c: Fix common/ includes.
 689         * value.c: Fix common/ includes.
 690         * valops.c: Fix common/ includes.
 691         * utils.c: Fix common/ includes.
 692         * unittests/xml-utils-selftests.c: Fix common/ includes.
 693         * unittests/utils-selftests.c: Fix common/ includes.
 694         * unittests/unpack-selftests.c: Fix common/ includes.
 695         * unittests/tracepoint-selftests.c: Fix common/ includes.
 696         * unittests/style-selftests.c: Fix common/ includes.
 697         * unittests/string_view-selftests.c: Fix common/ includes.
 698         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 699         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 700         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 701         * unittests/rsp-low-selftests.c: Fix common/ includes.
 702         * unittests/parse-connection-spec-selftests.c: Fix common/
 703         includes.
 704         * unittests/optional-selftests.c: Fix common/ includes.
 705         * unittests/offset-type-selftests.c: Fix common/ includes.
 706         * unittests/observable-selftests.c: Fix common/ includes.
 707         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 708         * unittests/memrange-selftests.c: Fix common/ includes.
 709         * unittests/memory-map-selftests.c: Fix common/ includes.
 710         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 711         * unittests/function-view-selftests.c: Fix common/ includes.
 712         * unittests/environ-selftests.c: Fix common/ includes.
 713         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 714         * unittests/common-utils-selftests.c: Fix common/ includes.
 715         * unittests/cli-utils-selftests.c: Fix common/ includes.
 716         * unittests/array-view-selftests.c: Fix common/ includes.
 717         * ui-file.c: Fix common/ includes.
 718         * tui/tui-io.c: Fix common/ includes.
 719         * tracepoint.h: Fix common/ includes.
 720         * tracepoint.c: Fix common/ includes.
 721         * tracefile-tfile.c: Fix common/ includes.
 722         * top.h: Fix common/ includes.
 723         * top.c: Fix common/ includes.
 724         * thread.c: Fix common/ includes.
 725         * target/waitstatus.h: Fix common/ includes.
 726         * target/waitstatus.c: Fix common/ includes.
 727         * target.h: Fix common/ includes.
 728         * target.c: Fix common/ includes.
 729         * target-memory.c: Fix common/ includes.
 730         * target-descriptions.c: Fix common/ includes.
 731         * symtab.h: Fix common/ includes.
 732         * symfile.c: Fix common/ includes.
 733         * stap-probe.c: Fix common/ includes.
 734         * spu-linux-nat.c: Fix common/ includes.
 735         * sparc-nat.c: Fix common/ includes.
 736         * source.c: Fix common/ includes.
 737         * solib.c: Fix common/ includes.
 738         * solib-target.c: Fix common/ includes.
 739         * ser-unix.c: Fix common/ includes.
 740         * ser-tcp.c: Fix common/ includes.
 741         * ser-pipe.c: Fix common/ includes.
 742         * ser-base.c: Fix common/ includes.
 743         * selftest-arch.c: Fix common/ includes.
 744         * s12z-tdep.c: Fix common/ includes.
 745         * rust-exp.y: Fix common/ includes.
 746         * rs6000-aix-tdep.c: Fix common/ includes.
 747         * riscv-tdep.c: Fix common/ includes.
 748         * remote.c: Fix common/ includes.
 749         * remote-notif.h: Fix common/ includes.
 750         * remote-fileio.h: Fix common/ includes.
 751         * remote-fileio.c: Fix common/ includes.
 752         * regcache.h: Fix common/ includes.
 753         * regcache.c: Fix common/ includes.
 754         * record-btrace.c: Fix common/ includes.
 755         * python/python.c: Fix common/ includes.
 756         * python/py-type.c: Fix common/ includes.
 757         * python/py-inferior.c: Fix common/ includes.
 758         * progspace.h: Fix common/ includes.
 759         * producer.c: Fix common/ includes.
 760         * procfs.c: Fix common/ includes.
 761         * proc-api.c: Fix common/ includes.
 762         * printcmd.c: Fix common/ includes.
 763         * ppc-linux-nat.c: Fix common/ includes.
 764         * parser-defs.h: Fix common/ includes.
 765         * osdata.c: Fix common/ includes.
 766         * obsd-nat.c: Fix common/ includes.
 767         * nat/x86-linux.c: Fix common/ includes.
 768         * nat/x86-linux-dregs.c: Fix common/ includes.
 769         * nat/x86-dregs.h: Fix common/ includes.
 770         * nat/x86-dregs.c: Fix common/ includes.
 771         * nat/ppc-linux.c: Fix common/ includes.
 772         * nat/mips-linux-watch.h: Fix common/ includes.
 773         * nat/mips-linux-watch.c: Fix common/ includes.
 774         * nat/linux-waitpid.c: Fix common/ includes.
 775         * nat/linux-ptrace.h: Fix common/ includes.
 776         * nat/linux-ptrace.c: Fix common/ includes.
 777         * nat/linux-procfs.c: Fix common/ includes.
 778         * nat/linux-personality.c: Fix common/ includes.
 779         * nat/linux-osdata.c: Fix common/ includes.
 780         * nat/linux-namespaces.c: Fix common/ includes.
 781         * nat/linux-btrace.h: Fix common/ includes.
 782         * nat/linux-btrace.c: Fix common/ includes.
 783         * nat/fork-inferior.c: Fix common/ includes.
 784         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 785         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 786         * nat/aarch64-linux.c: Fix common/ includes.
 787         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 788         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 789         * namespace.h: Fix common/ includes.
 790         * mips-linux-tdep.c: Fix common/ includes.
 791         * minsyms.c: Fix common/ includes.
 792         * mi/mi-parse.h: Fix common/ includes.
 793         * mi/mi-main.c: Fix common/ includes.
 794         * mi/mi-cmd-env.c: Fix common/ includes.
 795         * memrange.h: Fix common/ includes.
 796         * memattr.c: Fix common/ includes.
 797         * maint.h: Fix common/ includes.
 798         * maint.c: Fix common/ includes.
 799         * main.c: Fix common/ includes.
 800         * machoread.c: Fix common/ includes.
 801         * location.c: Fix common/ includes.
 802         * linux-thread-db.c: Fix common/ includes.
 803         * linux-nat.c: Fix common/ includes.
 804         * linux-fork.c: Fix common/ includes.
 805         * inline-frame.c: Fix common/ includes.
 806         * infrun.c: Fix common/ includes.
 807         * inflow.c: Fix common/ includes.
 808         * inferior.h: Fix common/ includes.
 809         * inferior.c: Fix common/ includes.
 810         * infcmd.c: Fix common/ includes.
 811         * inf-ptrace.c: Fix common/ includes.
 812         * inf-child.c: Fix common/ includes.
 813         * ia64-linux-nat.c: Fix common/ includes.
 814         * i387-tdep.c: Fix common/ includes.
 815         * i386-tdep.c: Fix common/ includes.
 816         * i386-linux-tdep.c: Fix common/ includes.
 817         * i386-linux-nat.c: Fix common/ includes.
 818         * i386-go32-tdep.c: Fix common/ includes.
 819         * i386-fbsd-tdep.c: Fix common/ includes.
 820         * i386-fbsd-nat.c: Fix common/ includes.
 821         * guile/scm-type.c: Fix common/ includes.
 822         * guile/guile.c: Fix common/ includes.
 823         * go32-nat.c: Fix common/ includes.
 824         * gnu-nat.c: Fix common/ includes.
 825         * gdbthread.h: Fix common/ includes.
 826         * gdbarch-selftests.c: Fix common/ includes.
 827         * gdb_usleep.c: Fix common/ includes.
 828         * gdb_select.h: Fix common/ includes.
 829         * gdb_bfd.c: Fix common/ includes.
 830         * gcore.c: Fix common/ includes.
 831         * fork-child.c: Fix common/ includes.
 832         * findvar.c: Fix common/ includes.
 833         * fbsd-nat.c: Fix common/ includes.
 834         * event-top.c: Fix common/ includes.
 835         * event-loop.c: Fix common/ includes.
 836         * dwarf2read.c: Fix common/ includes.
 837         * dwarf2loc.c: Fix common/ includes.
 838         * dwarf2-frame.c: Fix common/ includes.
 839         * dwarf-index-cache.c: Fix common/ includes.
 840         * dtrace-probe.c: Fix common/ includes.
 841         * disasm-selftests.c: Fix common/ includes.
 842         * defs.h: Fix common/ includes.
 843         * csky-tdep.c: Fix common/ includes.
 844         * cp-valprint.c: Fix common/ includes.
 845         * cp-support.h: Fix common/ includes.
 846         * cp-support.c: Fix common/ includes.
 847         * corelow.c: Fix common/ includes.
 848         * completer.h: Fix common/ includes.
 849         * completer.c: Fix common/ includes.
 850         * compile/compile.c: Fix common/ includes.
 851         * compile/compile-loc2c.c: Fix common/ includes.
 852         * compile/compile-cplus-types.c: Fix common/ includes.
 853         * compile/compile-cplus-symbols.c: Fix common/ includes.
 854         * command.h: Fix common/ includes.
 855         * cli/cli-dump.c: Fix common/ includes.
 856         * cli/cli-cmds.c: Fix common/ includes.
 857         * charset.c: Fix common/ includes.
 858         * build-id.c: Fix common/ includes.
 859         * btrace.h: Fix common/ includes.
 860         * btrace.c: Fix common/ includes.
 861         * breakpoint.h: Fix common/ includes.
 862         * breakpoint.c: Fix common/ includes.
 863         * ax.h:
 864         (enum agent_op): Fix common/ includes.
 865         * ax-general.c (struct aop_map): Fix common/ includes.
 866         * ax-gdb.c: Fix common/ includes.
 867         * auxv.c: Fix common/ includes.
 868         * auto-load.c: Fix common/ includes.
 869         * arm-tdep.c: Fix common/ includes.
 870         * arch/riscv.c: Fix common/ includes.
 871         * arch/ppc-linux-common.c: Fix common/ includes.
 872         * arch/i386.c: Fix common/ includes.
 873         * arch/arm.c: Fix common/ includes.
 874         * arch/arm-linux.c: Fix common/ includes.
 875         * arch/arm-get-next-pcs.c: Fix common/ includes.
 876         * arch/amd64.c: Fix common/ includes.
 877         * arch/aarch64.c: Fix common/ includes.
 878         * arch/aarch64-insn.c: Fix common/ includes.
 879         * arch-utils.c: Fix common/ includes.
 880         * amd64-windows-tdep.c: Fix common/ includes.
 881         * amd64-tdep.c: Fix common/ includes.
 882         * amd64-sol2-tdep.c: Fix common/ includes.
 883         * amd64-obsd-tdep.c: Fix common/ includes.
 884         * amd64-nbsd-tdep.c: Fix common/ includes.
 885         * amd64-linux-tdep.c: Fix common/ includes.
 886         * amd64-linux-nat.c: Fix common/ includes.
 887         * amd64-fbsd-tdep.c: Fix common/ includes.
 888         * amd64-fbsd-nat.c: Fix common/ includes.
 889         * amd64-dicos-tdep.c: Fix common/ includes.
 890         * amd64-darwin-tdep.c: Fix common/ includes.
 891         * agent.c: Fix common/ includes.
 892         * ada-lang.h: Fix common/ includes.
 893         * ada-lang.c: Fix common/ includes.
 894         * aarch64-tdep.c: Fix common/ includes.
 895
 896 2019-01-25  Tom Tromey  <tom@tromey.com>
 897
 898         * common/create-version.sh: Use common/version.h.
 899
 900 2019-01-24  Pedro Alves  <palves@redhat.com>
 901
 902         * infrun.c (signal_stop, signal_print, signal_program)
 903         (signal_catch, signal_pass): Now arrays instead of pointers.
 904         (update_signals_program_target, do_target_resume)
 905         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 906         * linux-nat.c (linux_nat_target::pass_signals)
 907         (linux_nat_target::create_inferior, linux_nat_target::attach):
 908         Adjust.
 909         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 910         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 911         * procfs.c (procfs_target::pass_signals): Adjust.
 912         * record-full.c (record_full_target::resume): Adjust.
 913         * remote.c (remote_target::pass_signals)
 914         (remote_target::program_signals): Adjust.
 915         * target-debug.h (target_debug_print_signals): Now takes a
 916         gdb::array_view as parameter.  Adjust.
 917         * target.h (target_ops) <pass_signals, program_signals>: Replace
 918         pointer and length parameters with gdb::array_view.
 919         (target_pass_signals, target_program_signals): Likewise.
 920         * target-delegates.c: Regenerate.
 921
 922 2019-01-24  Pedro Alves  <palves@redhat.com>
 923
 924         * common/forward-scope-exit.h
 925         (forward_scope_exit::forward_scope_exit): Pass arguments to
 926         m_bind_function directly, instead of creating a std::bind and
 927         copying that.
 928
 929 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 930
 931         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 932         for static members.
 933         (pass_in_v_vfp_candidate): Likewise.
 934
 935 2019-01-23  Tom Tromey  <tom@tromey.com>
 936             Pedro Alves  <palves@redhat.com>
 937
 938         * regcache.c (class regcache_invalidator): Remove.
 939         (regcache::raw_write): Use make_scope_exit.
 940
 941 2019-01-23  Tom Tromey  <tom@tromey.com>
 942
 943         * ui-out.h (class ui_out_emit_type): Update comment.
 944
 945 2019-01-23  Tom Tromey  <tom@tromey.com>
 946
 947         * infrun.c (fetch_inferior_event): Update comment.
 948
 949 2019-01-23  Tom Tromey  <tom@tromey.com>
 950             Pedro Alves  <palves@redhat.com>
 951
 952         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 953         parameter.
 954         (fetch_inferior_event): Use SCOPE_EXIT.
 955
 956
 957 2019-01-23  Tom Tromey  <tom@tromey.com>
 958             Pedro Alves  <palves@redhat.com>
 959
 960         * infrun.c (disable_thread_events): Delete.
 961         (stop_all_threads): Use SCOPE_EXIT.
 962
 963 2019-01-23  Tom Tromey  <tom@tromey.com>
 964             Pedro Alves  <palves@redhat.com>
 965
 966         * symfile.c: Include forward-scope-exit.h.
 967         (clear_symtab_users_cleanup): Replace forward declaration with
 968         a FORWARD_SCOPE_EXIT.
 969         (syms_from_objfile_1): Use the forward_scope_exit and
 970         gdb::optional instead of cleanup_function.
 971         (reread_symbols): Use the forward_scope_exit instead of
 972         cleanup_function.
 973         (clear_symtab_users_cleanup): Remove function.
 974
 975 2019-01-23  Tom Tromey  <tom@tromey.com>
 976             Pedro Alves  <palves@redhat.com>
 977
 978         * linux-nat.c: Include scope-exit.h.
 979         (cleanup_target_stop): Remove.
 980         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 981         SCOPE_EXIT.
 982
 983 2019-01-23  Tom Tromey  <tom@tromey.com>
 984             Pedro Alves  <palves@redhat.com>
 985
 986         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 987         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 988
 989 2019-01-23  Tom Tromey  <tom@tromey.com>
 990             Andrew Burgess  <andrew.burgess@embecosm.com>
 991             Pedro Alves  <palves@redhat.com>
 992
 993         * infrun.c (fetch_inferior_event): Use scope_exit.
 994         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 995         * top.c (execute_command): Use scope_exit.
 996         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 997         * utils.c (do_bpstat_clear_actions_cleanup)
 998         (make_bpstat_clear_actions_cleanup): Remove.
 999
1000 2019-01-23  Tom Tromey  <tom@tromey.com>
1001             Pedro Alves  <palves@redhat.com>
1002
1003         * infrun.c: Include "common/scope-exit.h"
1004         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1005         (wait_for_inferior): Use SCOPE_EXIT.
1006         (fetch_inferior_event): Use scope_exit.
1007
1008 2019-01-23  Tom Tromey  <tom@tromey.com>
1009             Pedro Alves  <palves@redhat.com>
1010
1011         * breakpoint.c (create_breakpoint): Remove cleanup.
1012
1013 2019-01-23  Tom Tromey  <tom@tromey.com>
1014             Andrew Burgess  <andrew.burgess@embecosm.com>
1015             Pedro Alves  <palves@redhat.com>
1016
1017 2019-01-23  Pedro Alves  <palves@redhat.com>
1018
1019         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1020
1021 2019-01-23  Pedro Alves  <palves@redhat.com>
1022             Andrew Burgess  <andrew.burgess@embecosm.com>
1023
1024         * gdbthread.h: Include "common/forward-scope-exit.h".
1025         (scoped_finish_thread_state): Redefine custom class in terms of
1026         forward_scope_exit.
1027
1028 2019-01-23  Pedro Alves  <palves@redhat.com>
1029             Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * common/forward-scope-exit.h: New file.
1032
1033 2019-01-23  Pedro Alves  <palves@redhat.com>
1034             Andrew Burgess  <andrew.burgess@embecosm.com>
1035             Tom Tromey  <tom@tromey.com>
1036
1037         * common/scope-exit.h: New file.
1038
1039 2019-01-23  Pedro Alves  <palves@redhat.com>
1040
1041         * common/preprocessor.h (ESC): Rename to ...
1042         (ESC_PARENS): ... this.
1043         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1044         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1045
1046 2019-01-23  Tom Tromey  <tom@tromey.com>
1047
1048         * language.h (class scoped_switch_to_sym_language_if_auto):
1049         Initialize m_lang in both cases.
1050
1051 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1052
1053         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1054         with XCNEW.
1055
1056 2019-01-22  Tom Tromey  <tom@tromey.com>
1057
1058         * corelow.c: Do not include sys/file.h.
1059
1060 2019-01-22  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-wingeneral.h: Include gdb_curses.h.
1063
1064 2019-01-22  Tom Tromey  <tom@tromey.com>
1065
1066         * source-cache.h (class source_cache) <get_source_lines,
1067         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1068
1069 2019-01-22  Tom Tromey  <tom@tromey.com>
1070
1071         * remote-fileio.h (struct remote_target): Declare.
1072
1073 2019-01-22  Tom Tromey  <tom@tromey.com>
1074
1075         * python/py-arch.c: Do not include py-ref.h.
1076         * python/py-bpevent.c: Do not include py-ref.h.
1077         * python/py-cmd.c: Do not include py-ref.h.
1078         * python/py-continueevent.c: Do not include py-ref.h.
1079         * python/py-event.h: Do not include py-ref.h.
1080         * python/py-evtregistry.c: Do not include py-ref.h.
1081         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1082         * python/py-frame.c: Do not include py-ref.h.
1083         * python/py-framefilter.c: Do not include py-ref.h.
1084         * python/py-function.c: Do not include py-ref.h.
1085         * python/py-infevents.c: Do not include py-ref.h.
1086         * python/py-linetable.c: Do not include py-ref.h.
1087         * python/py-objfile.c: Do not include py-ref.h.
1088         * python/py-param.c: Do not include py-ref.h.
1089         * python/py-prettyprint.c: Do not include py-ref.h.
1090         * python/py-progspace.c: Do not include py-ref.h.
1091         * python/py-symbol.c: Do not include py-ref.h.
1092         * python/py-symtab.c: Do not include py-ref.h.
1093         * python/py-type.c: Do not include py-ref.h.
1094         * python/py-unwind.c: Do not include py-ref.h.
1095         * python/py-utils.c: Do not include py-ref.h.
1096         * python/py-value.c: Do not include py-ref.h.
1097         * python/py-varobj.c: Do not include py-ref.h.
1098         * python/py-xmethods.c: Do not include py-ref.h.
1099         * python/python.c: Do not include py-ref.h.
1100         * varobj.c: Do not include py-ref.h.
1101
1102 2019-01-22  Tom Tromey  <tom@tromey.com>
1103
1104         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1105         keyword for bcache.
1106
1107 2019-01-22  Tom Tromey  <tom@tromey.com>
1108
1109         * compile/compile-cplus-types.c: Remove a comment by #include.
1110
1111 2019-01-22  Tom Tromey  <tom@tromey.com>
1112
1113         * compile/gcc-c-plugin.h: Include compile-internal.h.
1114
1115 2019-01-22  Tom Tromey  <tom@tromey.com>
1116
1117         * stabsread.c (EXTERN): Do not define.
1118         (symnum, next_symbol_text_func, processing_gcc_compilation)
1119         (within_function, global_sym_chain, global_stabs)
1120         (previous_stab_code, this_object_header_files)
1121         (n_this_object_header_files)
1122         (n_allocated_this_object_header_files): Define.
1123         * stabsread.h (EXTERN): Never define.  Use "extern".
1124
1125 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1126
1127         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1128         history_value.
1129
1130 2019-01-21  Tom Tromey  <tom@tromey.com>
1131
1132         * ui-out.c: Fix includes.
1133         * tui/tui-source.c: Fix includes.
1134         * target.c: Fix includes.
1135         * remote.c: Fix includes.
1136         * regcache.c: Fix includes.
1137         * python/py-block.c: Fix includes.
1138         * printcmd.c: Fix includes.
1139         * or1k-tdep.c: Fix includes.
1140         * mi/mi-main.c: Fix includes.
1141         * m32r-tdep.c: Fix includes.
1142         * csky-tdep.c: Fix includes.
1143         * compile/compile-cplus-types.c: Fix includes.
1144         * cli/cli-interp.c: Fix includes.
1145
1146 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1147
1148         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1149         for padding.
1150
1151 2019-01-16  Tom Tromey  <tom@tromey.com>
1152
1153         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1154         earlier.
1155         (struct objfile) <msymbols_range>: Move from top level.
1156         <msymbols>: New method.
1157         (class objfile_msymbols): Remove.
1158         * symtab.c (default_collect_symbol_completion_matches_break_on):
1159         Update.
1160         * symmisc.c (dump_msymbols): Update.
1161         * stabsread.c (scan_file_globals): Update.
1162         * objc-lang.c (info_selectors_command, info_classes_command)
1163         (find_methods): Update.
1164         * minsyms.c (find_solib_trampoline_target): Update.
1165         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1166         * coffread.c (coff_symfile_read): Update.
1167         * ada-lang.c (ada_lookup_simple_minsym)
1168         (ada_collect_symbol_completion_matches): Update.
1169
1170 2019-01-16  Tom Tromey  <tom@tromey.com>
1171
1172         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1173         type.  Remove no-argument constructor.
1174         <iterator::operator++>: Simplify.
1175         <begin>: Update.
1176         <end>: Use minimal_symbol_count.
1177
1178 2019-01-16  Tom Tromey  <tom@tromey.com>
1179
1180         * objfiles.h (struct objfile) <psymtabs>: New method.
1181         (class objfile_psymtabs): Remove.
1182         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1183         typedef.
1184         <range>: New method.
1185         (require_partial_symbols): Change return type.
1186         * psymtab.c (require_partial_symbols)
1187         (psym_expand_symtabs_matching): Update.
1188         * mdebugread.c (parse_partial_symbols): Update.
1189         * dbxread.c (dbx_end_psymtab): Update.
1190
1191 2019-01-15  Tom Tromey  <tom@tromey.com>
1192
1193         * symtab.c (lookup_objfile_from_block)
1194         (lookup_symbol_in_objfile_symtabs)
1195         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1196         (find_line_symtab, info_sources_command)
1197         (default_collect_symbol_completion_matches_break_on)
1198         (make_source_files_completion_list): Update.
1199         * symmisc.c (print_objfile_statistics, dump_objfile)
1200         (maintenance_print_symbols, maintenance_info_symtabs)
1201         (maintenance_check_symtabs, maintenance_info_line_tables):
1202         Update.
1203         * source.c (select_source_symtab)
1204         (forget_cached_source_info_for_objfile): Update.
1205         * objfiles.h (class objfile_compunits): Remove.
1206         (struct objfile) <compunits_range>: New typedef.
1207         (compunits): New method.
1208         * objfiles.c (objfile_relocate1): Update.
1209         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1210         * maint.c (count_symtabs_and_blocks): Update.
1211         * linespec.c (iterate_over_all_matching_symtabs): Update.
1212         * cp-support.c (add_symbol_overload_list_qualified): Update.
1213         * coffread.c (coff_symtab_read): Update.
1214         * ada-lang.c (add_nonlocal_symbols)
1215         (ada_collect_symbol_completion_matches)
1216         (ada_add_global_exceptions): Update.
1217
1218 2019-01-15  Tom Tromey  <tom@tromey.com>
1219
1220         * progspace.h (program_space) <objfiles_safe_range>: New
1221         typedef.
1222         <objfiles_safe>: New method.
1223         * objfiles.h (class all_objfiles_safe): Remove.
1224         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1225         * jit.c (jit_inferior_exit_hook): Update.
1226
1227 2019-01-17  Tom Tromey  <tom@tromey.com>
1228
1229         * progspace.h (program_space) <objfiles_range>: New typedef.
1230         <objfiles>: New method.
1231         <objfiles_head>: Rename from objfiles.
1232         (object_files): Update.
1233         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1234         * guile/scm-pretty-print.c
1235         (ppscm_find_pretty_printer_from_objfiles): Update.
1236         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1237         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1238         Update.
1239         * python/py-progspace.c (pspy_get_objfiles): Update.
1240         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1241         Update.
1242         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1243         (objfpy_lookup_objfile_by_build_id): Update.
1244         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1245         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1246         Update.
1247         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1248         (expand_symtab_containing_pc, lookup_objfile_from_block)
1249         (lookup_static_symbol, basic_lookup_transparent_type)
1250         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1251         (find_line_symtab, info_sources_command)
1252         (default_collect_symbol_completion_matches_break_on)
1253         (make_source_files_completion_list, find_main_name): Update.
1254         * symmisc.c (print_symbol_bcache_statistics)
1255         (print_objfile_statistics, maintenance_print_symbols)
1256         (maintenance_print_msymbols, maintenance_print_objfiles)
1257         (maintenance_info_symtabs, maintenance_check_symtabs)
1258         (maintenance_expand_symtabs, maintenance_info_line_tables):
1259         Update.
1260         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1261         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1262         (map_overlay_command, unmap_overlay_command)
1263         (simple_overlay_update, expand_symtabs_matching)
1264         (map_symbol_filenames): Update.
1265         * symfile-debug.c (set_debug_symfile): Update.
1266         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1267         Update.
1268         * source.c (select_source_symtab, forget_cached_source_info):
1269         Update.
1270         * solib.c (solib_read_symbols): Update.
1271         * solib-spu.c (append_ocl_sos): Update.
1272         * psymtab.c (maintenance_print_psymbols)
1273         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1274         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1275         * printcmd.c (info_symbol_command): Update.
1276         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1277         Update.
1278         * objfiles.h (class all_objfiles): Remove.
1279         * objfiles.c (have_partial_symbols, have_full_symbols)
1280         (have_minimal_symbols, qsort_cmp, update_section_map)
1281         (shared_objfile_contains_address_p)
1282         (default_iterate_over_objfiles_in_search_order): Update.
1283         * objc-lang.c (info_selectors_command, info_classes_command)
1284         (find_methods): Update.
1285         * minsyms.c (find_solib_trampoline_target): Update.
1286         * maint.c (maintenance_info_sections)
1287         (maintenance_translate_address, count_symtabs_and_blocks):
1288         Update.
1289         * main.c (captured_main_1): Update.
1290         * linux-thread-db.c (try_thread_db_load_from_pdir)
1291         (has_libpthread): Update.
1292         * linespec.c (iterate_over_all_matching_symtabs)
1293         (search_minsyms_for_name): Update.
1294         * jit.c (jit_find_objf_with_entry_addr): Update.
1295         * hppa-tdep.c (find_unwind_entry)
1296         (hppa_lookup_stub_minimal_symbol): Update.
1297         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1298         Update.
1299         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1300         (elf_gnu_ifunc_resolve_by_got): Update.
1301         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1302         * dwarf-index-write.c (save_gdb_index_command): Update.
1303         * cp-support.c (add_symbol_overload_list_qualified): Update.
1304         * breakpoint.c (create_overlay_event_breakpoint)
1305         (create_longjmp_master_breakpoint)
1306         (create_std_terminate_master_breakpoint)
1307         (create_exception_master_breakpoint): Update.
1308         * blockframe.c (find_pc_partial_function): Update.
1309         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1310         (ada_collect_symbol_completion_matches)
1311         (ada_add_global_exceptions): Update.
1312
1313 2019-01-17  Tom Tromey  <tom@tromey.com>
1314
1315         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1316         declare VEC.
1317         (solib_target_parse_libraries): Change return type.
1318         (library_list_start_segment, library_list_start_section)
1319         (library_list_end_library, library_list_start_library); Update.
1320         (solib_target_free_library_list): Remove.
1321         (solib_target_parse_libraries): Remove cleanup.  Change return
1322         type.
1323         (solib_target_current_sos): Update.
1324
1325 2019-01-17  Tom Tromey  <tromey@bapiya>
1326
1327         * valprint.c: Replace "the the" with "the".
1328         * symtab.c: Replace "the the" with "the".
1329         * solib.c: Replace "the the" with "the".
1330         * solib-dsbt.c: Replace "the the" with "the".
1331         * linespec.c: Replace "the the" with "the".
1332         * dwarf2loc.h: Replace "the the" with "the".
1333         * amd64-windows-tdep.c: Replace "the the" with "the".
1334         * aarch64-tdep.c: Replace "the the" with "the".
1335
1336 2019-01-16  Keith Seitz  <keiths@redhat.com>
1337
1338         PR gdb/23773
1339         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1340         <builder>: Rename to ..
1341         <m_builder>: ... this and make private.
1342         (dwarf2_cu::get_builder): New method.  Change all users of
1343         `builder' to use this method.
1344         (dwarf2_start_symtab): Move to ...
1345         (dwarf2_cu::start_symtab): ... here.  Update all callers
1346         (setup_type_unit_groups): Move to ...
1347         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1348         callers.
1349         (dwarf2_cu::reset_builder): New method.
1350         (process_full_compunit, process_full_type_unit): Use
1351         dwarf2_cu::reset_builder.
1352         (follow_die_offset): Record the ancestor CU if it is different
1353         from the followed DIE's CU.
1354         (follow_die_sig_1): Likewise.
1355
1356 2019-01-15  Tom Tromey  <tom@tromey.com>
1357
1358         * remote.c (class remote_state) <buf>: Now a char_vector.
1359         <buf_size>: Remove.
1360         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1361         parameter.
1362         (remote_target::getpkt_or_notif_sane_1)
1363         (remote_target::getpkt_sane)
1364         (remote_target::getpkt_or_notif_sane): Likewise.
1365         (class remote_target) <putpkt>: New overload.
1366         (remote_target::read_frame): Change type of "buf_p".  Remove
1367         sizeof_p parameter.
1368         (packet_ok): New overload.
1369         (packet_check_result): New overload.
1370         Update all uses.
1371
1372 2019-01-14  Tom Tromey  <tom@tromey.com>
1373
1374         * remote-notif.c (handle_notification, remote_notif_ack)
1375         (remote_notif_parse): Make "buf" const.
1376         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1377         const.
1378         (remote_notif_parse, remote_notif_ack, handle_notification):
1379         Likewise.
1380         * remote.c (remote_notif_stop_parse): Make "buf" const.
1381         (remote_target::remote_parse_stop_reply): Make "buf" const.
1382         (remote_notif_stop_ack): Make "buf" const.
1383
1384 2019-01-14  Tom Tromey  <tom@tromey.com>
1385
1386         * remote.c (remote_console_output): Make parameter const.
1387
1388 2019-01-14  Tom Tromey  <tom@tromey.com>
1389
1390         * target-debug.h (target_debug_print_signals): Constify.
1391         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1392         * procfs.c (procfs_target::pass_signals): Update.
1393         * linux-nat.c (linux_nat_target::pass_signals): Update.
1394         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1395         * target-delegates.c: Rebuild.
1396         * remote.c (remote_target::program_signals): Update.
1397         (remote_target::pass_signals): Update.
1398         * target.c (target_pass_signals): Constify argument.
1399         (target_program_signals): Likewise.
1400         * target.h (struct target_ops) <pass_signals, program_signals>:
1401         Constify argument.
1402         (target_pass_signals, target_program_signals): Constify argument.
1403
1404 2019-01-14  Tom Tromey  <tom@tromey.com>
1405
1406         PR tui/28819:
1407         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1408
1409 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1410
1411         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1412         field.
1413         * rs6000-tdep.c: Include reggroups.h.
1414         (IS_V_ALIAS_PSEUDOREG): Define.
1415         (rs6000_register_name): Return names for the "vX" aliases.
1416         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1417         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1418         aliases.  Call default_register_reggroup_p for all other
1419         pseudo-registers.
1420         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1421         New functions.
1422         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1423         Handle "vX" aliases.
1424         (v_alias_pseudo_register_collect): New function.
1425         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1426         (rs6000_gdbarch_init): Initialize "vX" aliases as
1427         pseudo-registers.  Restore registration of
1428         rs6000_pseudo_register_reggroup_p with
1429         set_tdesc_pseudo_register_reggroup_p.
1430
1431 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1432
1433         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1434         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1435         set_gdbarch_num_pseudo_regs.
1436
1437 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1438
1439         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1440         Remove arg prefixname, add do_set and do_show.
1441         Add member functions set_list and show_list.
1442         * cli/cli-style.c (class cli_style_option): Update accordingly.
1443         (style_set_list): Move to file scope.
1444         (style_show_list): Likewise.
1445         (set_style): Call help_list.
1446         (show_style): Call cmd_show_list.
1447         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1448         Update to use the new macro.
1449
1450 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1451
1452         * ada-lang.c (_initialize_ada_language): Expand the help text
1453         for the "catch exception" command.
1454
1455 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1456
1457         * symtab.c (matching_obj_sections): Initialize obj,
1458         declare it closer to its usage.
1459
1460 2019-01-10  Tom Tromey  <tom@tromey.com>
1461
1462         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1463         (basic_inf_threads_range): Remove.
1464         (inf_threads_range, inf_non_exited_threads_range)
1465         (safe_inf_threads_range): Use next_adapter.
1466
1467 2019-01-10  Keith Seitz  <keiths@redhat.com>
1468
1469         PR gdb/23712
1470         PR symtab/23010
1471         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1472         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1473
1474 2019-01-10  Keith Seitz  <keiths@redhat.com>
1475
1476         PR gdb/23712
1477         PR symtab/23010
1478         * dictionary.c (pending_to_vector): Remove.
1479         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1480         Remove _1 suffix, replacing functions of the same name.  Update
1481         all callers.
1482         (dict_create_hashed, dict_create_hashed_expandable)
1483         (dict_create_linear, dict_create_linear_expandable, dict_free)
1484         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1485         Make functions static.
1486
1487 2019-01-10  Keith Seitz  <keiths@redhat.com>
1488
1489         PR gdb/23712
1490         PR symtab/23010
1491         * dictionary.h (struct dictionary): Replace declaration with
1492         multidictionary.
1493         (dict_create_hashed, dict_create_hashed_expandable)
1494         (dict_create_linear, dict_create_linear_expandable)
1495         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1496         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1497         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1498         taking multidictionary argument.
1499         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1500         * block.h (struct block) <dict>: Change to multidictionary
1501         and rename `multidict'.
1502         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1503         symmisc.c: Update all dictionary references to multidictionary.
1504
1505 2019-01-10  Keith Seitz  <keiths@redhat.com>
1506
1507         PR gdb/23712
1508         PR symtab/23010
1509         * dictionary.c: Include unordered_map.
1510         (pending_to_vector): New function.
1511         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1512         Rewrite the non-"_1" functions to take vector instead
1513         of linked list.
1514         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1515         "new" _1 versions of the same name.
1516         (multidictionary): Define.
1517         (std::hash<enum language): New definition.
1518         (collate_pending_symbols_by_language, mdict_create_hashed)
1519         (mdict_create_hashed_expandable, mdict_create_linear)
1520         (mdict_create_linear_expandable, mdict_free)
1521         (find_language_dictionary, create_new_language_dictionary)
1522         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1523         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1524         (mdict_size, mdict_empty): New functions.
1525         * dictionary.h (mdict_iterator): Define.
1526
1527 2019-01-10  Pedro Alves  <palves@redhat.com>
1528
1529         * breakpoint.c (read_uploaded_action)
1530         (create_tracepoint_from_upload): Adjust to use
1531         gdb::unique_xmalloc_ptr.
1532         * ctf.c (ctf_write_uploaded_tp):
1533         (SET_ARRAY_FIELD): Use emplace_back.
1534         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1535         * tracefile-tfile.c (tfile_write_uploaded_tp):
1536         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1537         gdb::unique_xmalloc_ptr.
1538         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1539         at_string, cond_string, cmd_strings>: Replace char pointers
1540         with gdb::unique_xmalloc_ptr.
1541
1542 2019-01-10  Pedro Alves  <palves@redhat.com>
1543
1544         * solib-target.c (library_list_start_library): Don't xstrdup name.
1545
1546 2019-01-10  Pedro Alves  <palves@redhat.com>
1547
1548         * mdebugread.c (parse_partial_symbols): Use
1549         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1550
1551 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1552
1553         * linux-fork.c (scoped_switch_fork_info)
1554         <~scoped_switch_fork_info>: Fix incorrect variable name.
1555
1556 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1557
1558         * linux-fork.c (scoped_switch_fork_info)
1559         <scoped_switch_fork_info>: Make explicit.
1560         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1561
1562 2019-01-10  Tom Tromey  <tom@tromey.com>
1563
1564         * objfiles.h (objfile::reset_psymtabs): Update.
1565         * objfiles.c (objfile::objfile): Update.
1566         * psymtab.h (psymtab_storage::obstack): Update.
1567         (psymtab_storage::m_obstack): Use gdb::optional.
1568         (class psymtab_storage): Update comment.  Remove objfile
1569         parameter.
1570         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1571
1572 2019-01-10  Tom Tromey  <tom@tromey.com>
1573
1574         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1575         <free_psymtabs>: Now private.
1576         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1577         (allocate_psymtab): Use new method.
1578
1579 2019-01-10  Tom Tromey  <tom@tromey.com>
1580
1581         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1582         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1583         * mdebugread.c (parse_partial_symbols): Use
1584         allocate_dependencies.
1585         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1586         allocate_dependencies.
1587         (process_psymtab_comp_unit_reader)
1588         (build_type_psymtab_dependencies): Likewise.
1589         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1590
1591 2019-01-10  Tom Tromey  <tom@tromey.com>
1592
1593         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1594         PSYMBOL_SET_LANGUAGE.
1595         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1596
1597 2019-01-10  Tom Tromey  <tom@tromey.com>
1598
1599         * psymtab.h (psymtab_storage::obstack): New method.
1600         <m_obstack>: Rename from obstack; now private.
1601         * psymtab.c (psymtab_storage): Update.
1602         * dwarf2read.c (create_addrmap_from_index)
1603         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1604         Update.
1605
1606 2019-01-10  Tom Tromey  <tom@tromey.com>
1607
1608         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1609         * objfiles.h (objfile::reset_psymtabs): New method.
1610
1611 2019-01-10  Tom Tromey  <tom@tromey.com>
1612
1613         * symmisc.c (print_symbol_bcache_statistics): Update.
1614         (print_objfile_statistics): Update.
1615         * symfile.c (reread_symbols): Update.
1616         * psymtab.h (class psymtab_storage): New.
1617         * psymtab.c (psymtab_storage): New constructor.
1618         (~psymtab_storage): New destructor.
1619         (require_partial_symbols): Update.
1620         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1621         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1622         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1623         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1624         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1625         (start_psymtab_common, end_psymtab_common)
1626         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1627         (allocate_psymtab): Update.
1628         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1629         Update.
1630         (dump_psymtab_addrmap, maintenance_print_psymbols)
1631         (maintenance_check_psymtabs): Update.
1632         (class objfile_psymtabs): Move to objfiles.h.
1633         * psympriv.h (discard_psymtab): Now inline.
1634         (psymtab_discarder::psymtab_discarder): Update.
1635         (psymtab_discarder::~psymtab_discarder): Update.
1636         (ALL_OBJFILE_PSYMTABS): Rewrite.
1637         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1638         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1639         Remove fields.
1640         <partial_symtabs>: New field.
1641         (class objfile_psymtabs): Move from psymtab.h.  Update.
1642         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1643         psymbol_cache.
1644         (objfile::~objfile): Don't destroy psymbol_cache.
1645         * mdebugread.c (parse_partial_symbols): Update.
1646         * dwarf2read.c (create_addrmap_from_index)
1647         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1648         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1649         (add_partial_subprogram, dwarf2_ranges_read): Update.
1650         * dwarf-index-write.c (write_address_map)
1651         (write_one_signatured_type, recursively_write_psymbols)
1652         (class debug_names, class debug_names, write_psymtabs_to_index):
1653         Update.
1654
1655 2019-01-10  Tom Tromey  <tom@tromey.com>
1656
1657         * symtab.h (SYMBOL_SET_NAMES): Update.
1658         (symbol_set_names): Update.
1659         (MSYMBOL_SET_NAMES): Update.
1660         * symtab.c (symbol_set_names): Change argument to be an
1661         objfile_per_bfd_storage.
1662         * psymtab.c (add_psymbol_to_bcache): Update.
1663         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1664
1665 2019-01-10  Tom Tromey  <tom@tromey.com>
1666
1667         * symtab.c (create_demangled_names_hash): Change argument to be an
1668         objfile_per_bfd_storage.
1669         (symbol_set_names): Update.
1670
1671 2019-01-10  Tom Tromey  <tom@tromey.com>
1672
1673         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1674         init_psymbol_list.
1675         * psymtab.c (init_psymbol_list): Do nothing if already called.
1676         * psympriv.h (init_psymbol_list): Add comment.
1677         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1678         init_psymbol_list.
1679         * dbxread.c (dbx_symfile_read): Unconditionally call
1680         init_psymbol_list.
1681
1682 2019-01-10  Tom Tromey  <tom@tromey.com>
1683
1684         * xcoffread.c (scan_xcoff_symtab): Update.
1685         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1686         "where".
1687         * mdebugread.c (parse_partial_symbols)
1688         (handle_psymbol_enumerators): Update.
1689         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1690         * dbxread.c (read_dbx_symtab): Update.
1691         * psympriv.h (psymbol_placement): New enum.
1692         (add_psymbol_to_list): Update.
1693
1694 2019-01-10  Tom Tromey  <tom@tromey.com>
1695
1696         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1697         static_psymbols parameters.
1698         (scan_xcoff_symtab): Update.
1699         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1700         static_psymbols parameters.
1701         * psympriv.h (start_psymtab_common): Update.
1702         * mdebugread.c (parse_partial_symbols): Update.
1703         * dwarf2read.c (create_partial_symtab): Update.
1704         * dbxread.c (read_dbx_symtab): Update.
1705         (start_psymtab): Remove global_psymbols and static_psymbols
1706         parameters.
1707
1708 2019-01-10  Tom Tromey  <tom@tromey.com>
1709
1710         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1711         * psymtab.c (allocate_psymtab): Add comment.
1712         * psympriv.h (allocate_psymtab): Add comment.
1713         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1714         initializations.
1715         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1716
1717 2019-01-10  Tom Tromey  <tom@tromey.com>
1718
1719         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1720         Don't declare.
1721         * mipsread.c: Include mdebugread.h.
1722         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1723         Declare.
1724         * elfread.c: Include mdebugread.h.
1725
1726 2019-01-09  Tom Tromey  <tom@tromey.com>
1727
1728         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1729         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1730         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1731         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1732         (psym_lookup_symbol, psym_find_last_source_symtab)
1733         (psym_forget_cached_source_info, psym_print_stats)
1734         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1735         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1736         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1737         (psym_find_compunit_symtab_by_address)
1738         (maintenance_print_psymbols, maintenance_info_psymtabs)
1739         (maintenance_check_psymtabs): Use ranged for.
1740         * psymtab.h (class objfile_psymtabs): New.
1741         (require_partial_symbols): Return objfile_psymtabs.
1742         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1743
1744 2019-01-09  Tom Tromey  <tom@tromey.com>
1745
1746         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1747         (find_pc_mapped_section, list_overlays_command)
1748         (map_overlay_command, unmap_overlay_command)
1749         (simple_overlay_update): Use all_objfiles.
1750         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1751         * printcmd.c (info_symbol_command): Use all_objfiles.
1752         * objfiles.h (ALL_OBJSECTIONS): Remove.
1753         * maint.c (maintenance_translate_address): Use all_objfiles.
1754         * gcore.c (gcore_create_callback): Use all_objfiles.
1755         (objfile_find_memory_regions): Likewise.
1756
1757 2019-01-09  Tom Tromey  <tom@tromey.com>
1758
1759         * symtab.c (find_line_symtab, info_sources_command)
1760         (make_source_files_completion_list): Use objfile_compunits.
1761         * source.c (select_source_symtab): Use objfile_compunits.
1762         * objfiles.h (struct objfile): Update comment.
1763         (ALL_OBJFILES): Remove.
1764         (ALL_FILETABS): Remove.
1765         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1766         objfile_compunits.
1767
1768 2019-01-09  Tom Tromey  <tom@tromey.com>
1769
1770         * symmisc.c (print_objfile_statistics, dump_objfile)
1771         (maintenance_print_symbols): Use compunit_filetabs.
1772         * source.c (forget_cached_source_info_for_objfile): Use
1773         compunit_filetabs.
1774         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1775         (ALL_FILETABS): Use compunit_filetabs.
1776         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1777         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1778
1779 2019-01-09  Tom Tromey  <tom@tromey.com>
1780
1781         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1782         (compunit_filetabs): New.
1783         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1784         compunit_filetabs.
1785         (info_sources_command, make_source_files_completion_list): Remove
1786         declaration.
1787         * symmisc.c (print_objfile_statistics, dump_objfile)
1788         (maintenance_print_symbols): Remove declaration.
1789         (maintenance_info_symtabs): Use compunit_filetabs.
1790         (maintenance_info_line_tables): Likewise.
1791         * source.c (select_source_symtab): Change local variable name.
1792         (forget_cached_source_info_for_objfile): Remove declaration.
1793         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1794         * objfiles.c (objfile_relocate1): Remove declaration.
1795         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1796         declaration.
1797         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1798         * coffread.c (coff_symtab_read): Remove declaration.
1799         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1800         compunit_filetabs.
1801
1802 2019-01-09  Tom Tromey  <tom@tromey.com>
1803
1804         * symtab.c (lookup_objfile_from_block)
1805         (find_pc_sect_compunit_symtab, search_symbols)
1806         (default_collect_symbol_completion_matches_break_on): Use
1807         objfile_compunits.
1808         * objfiles.h (ALL_COMPUNITS): Remove.
1809         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1810         * cp-support.c (add_symbol_overload_list_qualified): Use
1811         objfile_compunits.
1812         * ada-lang.c (ada_collect_symbol_completion_matches)
1813         (ada_add_global_exceptions): Use objfile_compunits.
1814
1815 2019-01-09  Tom Tromey  <tom@tromey.com>
1816
1817         * source.c (select_source_symtab)
1818         (forget_cached_source_info_for_objfile): Remove declaration.
1819         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1820         declaration.
1821         * maint.c (count_symtabs_and_blocks): Remove declaration.
1822         * cp-support.c (add_symbol_overload_list_qualified): Remove
1823         declaration.
1824         * coffread.c (coff_symtab_read): Remove declaration.
1825         * symtab.c (lookup_symbol_in_objfile_symtabs)
1826         (basic_lookup_transparent_type_1): Use objfile_compunits.
1827         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1828         (info_sources_command, search_symbols)
1829         (default_collect_symbol_completion_matches_break_on)
1830         (make_source_files_completion_list): Remove declaration.
1831         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1832         (ada_collect_symbol_completion_matches)
1833         (ada_add_global_exceptions): Remove declaration.
1834         * linespec.c (iterate_over_all_matching_symtabs): Use
1835         objfile_compunits.
1836         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1837         (class objfile_compunits): New.
1838         (ALL_COMPUNITS): Use objfile_compunits.
1839         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1840         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1841         objfile_compunits.
1842         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1843
1844 2019-01-09  Tom Tromey  <tom@tromey.com>
1845
1846         * symtab.c (search_symbols)
1847         (default_collect_symbol_completion_matches_break_on): Use
1848         objfile_msymbols.
1849         * ada-lang.c (ada_lookup_simple_minsym)
1850         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1851         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1852         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1853         objfile_msymbols.
1854         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1855         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1856         * objc-lang.c (find_methods): Use objfile_msymbols.
1857         (info_selectors_command, info_classes_command): Likewise.
1858         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1859         * objfiles.h (class objfile_msymbols): New.
1860         (ALL_OBJFILE_MSYMBOLS): Remove.
1861         (ALL_MSYMBOLS): Remove.
1862
1863 2019-01-09  Tom Tromey  <tom@tromey.com>
1864
1865         * common/next-iterator.h (next_adapter): Add Iterator template
1866         parameter.
1867         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1868         (class all_objfiles_safe): New.
1869         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1870         * objfiles.c (put_objfile_before): Update comment.
1871         (add_separate_debug_objfile): Likewise.
1872         (free_all_objfiles): Use all_objfiles_safe.
1873         (objfile_purge_solibs): Likewise.
1874
1875 2019-01-09  Tom Tromey  <tom@tromey.com>
1876
1877         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1878         (expand_symtab_containing_pc, lookup_static_symbol)
1879         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1880         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1881         all_objfiles.
1882         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1883         * breakpoint.c (create_overlay_event_breakpoint)
1884         (create_longjmp_master_breakpoint)
1885         (create_std_terminate_master_breakpoint)
1886         (create_exception_master_breakpoint): Use all_objfiles.
1887         * linux-thread-db.c (try_thread_db_load_from_pdir)
1888         (has_libpthread): Use all_objfiles.
1889         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1890         * linespec.c (iterate_over_all_matching_symtabs)
1891         (search_minsyms_for_name): Use all_objfiles.
1892         * maint.c (maintenance_info_sections): Use all_objfiles.
1893         * main.c (captured_main_1): Use all_objfiles.
1894         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1895         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1896         * guile/scm-pretty-print.c
1897         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1898         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1899         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1900         (maintenance_print_msymbols): Use all_objfiles.
1901         * source.c (select_source_symtab): Use all_objfiles.
1902         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1903         * symfile.c (remove_symbol_file_command)
1904         (expand_symtabs_matching, map_symbol_filenames): Use
1905         all_objfiles.
1906         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1907         all_objfiles.
1908         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1909         * objc-lang.c (find_methods): Use all_objfiles.
1910         * objfiles.c (have_partial_symbols, have_full_symbols)
1911         (have_minimal_symbols, qsort_cmp)
1912         (default_iterate_over_objfiles_in_search_order): Use
1913         all_objfiles.
1914         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1915         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1916         (maintenance_check_psymtabs): Use all_objfiles.
1917         (ALL_PSYMTABS): Remove.
1918         * compile/compile-object-run.c (do_module_cleanup): Use
1919         all_objfiles.
1920         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1921         * cp-support.c (add_symbol_overload_list_qualified): Use
1922         all_objfiles.
1923         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1924         Use all_objfiles.
1925         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1926         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1927         all_objfiles.
1928         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1929         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1930         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1931         Uses all_objfiles.
1932         * solib.c (solib_read_symbols): Use all_objfiles
1933
1934 2019-01-09  Tom Tromey  <tom@tromey.com>
1935
1936         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1937         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1938         all_objfiles.
1939         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1940         * symmisc.c (print_symbol_bcache_statistics)
1941         (print_objfile_statistics, maintenance_print_objfiles)
1942         (maintenance_info_symtabs, maintenance_check_symtabs)
1943         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1944         all_objfiles.
1945         * source.c (forget_cached_source_info): Use all_objfiles.
1946         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1947         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1948         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1949         * objfiles.c (update_section_map): Use all_objfiles.
1950         (shared_objfile_contains_address_p): Likewise.
1951         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1952         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1953
1954 2019-01-09  Tom Tromey  <tom@tromey.com>
1955
1956         * common/next-iterator.h: New file.
1957         * objfiles.h (class all_objfiles): New.
1958         (struct objfile_iterator): New.
1959
1960 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1961
1962         * NEWS: Move the description of the changed "frame", "select-frame",
1963          and "info frame" commands to the Changed commands section.
1964
1965 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1966
1967         * gdbtypes.c (check_stub_method_group): Remove handling of old
1968         mangling schemes.
1969         * linespec.c (find_methods): Likewise.
1970         * stabsread.c (read_member_functions): Likewise.
1971         * valops.c (search_struct_method): Likewise.
1972         (value_struct_elt_for_reference): Likewise.
1973         * NEWS: Mention this change.
1974
1975 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1976
1977         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1978         print_source_lines.
1979         * source.c (print_source_lines_base): Update line number check.
1980         (print_source_lines): New function.
1981         (source_lines_range::source_lines_range): New function.
1982         * source.h (class source_lines_range): New class.
1983         (print_source_lines): New declaration.
1984
1985 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1986
1987         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1988
1989 2019-01-08  Tom Tromey  <tom@tromey.com>
1990             Simon Marchi  <simon.marchi@ericsson.com>
1991
1992         PR gdb/24060
1993         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1994         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1995         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1996         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1997         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1998         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1999
2000 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2001
2002         * source.c (select_source_symtab): Move header comment to
2003         declaration in source.h.
2004         (forget_cached_source_info_for_objfile): Likewise.
2005         (forget_cached_source_info): Likewise.
2006         (identify_source_line): Likewise.
2007         * source.h (identify_source_line): Move declaration from symtab.h
2008         and add comment from source.c
2009         (print_source_lines): Likewise.
2010         (forget_cached_source_info_for_objfile): Likewise.
2011         (forget_cached_source_info): Likewise.
2012         (select_source_symtab): Likewise.
2013         (enum print_source_lines_flag): Move definition from symtab.h.
2014         * symtab.h (identify_source_line): Move declaration to source.h.
2015         (print_source_lines): Likewise.
2016         (forget_cached_source_info_for_objfile): Likewise.
2017         (forget_cached_source_info): Likewise.
2018         (select_source_symtab): Likewise.
2019         (enum print_source_lines_flag): Move definition to source.h.
2020         * tui/tui-hooks.c: Add 'source.h' include.
2021
2022 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2023
2024         * source.c (print_source_lines_base): Handle requests to print
2025         reverse line number sequences, and guard against empty lines
2026         string.
2027
2028 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2029
2030         * source.c (print_source_lines_base): Fix skip of '\r' if next
2031         character is '\n'.
2032
2033 2019-01-06  Tom Tromey  <tom@tromey.com>
2034
2035         * c-exp.y (struct c_parse_state) <macro_original_text,
2036         expansion_obstack>: New member.
2037         (macro_original_text, expansion_obstack): Remove globals.
2038         (scan_macro_expansion, scanning_macro_expansion)
2039         (finished_macro_expansion): Update.
2040         (scan_macro_cleanup): Remove.
2041         (yylex, c_parse): Update.
2042
2043 2019-01-06  Tom Tromey  <tom@tromey.com>
2044
2045         * c-exp.y (struct c_parse_state) <strings>: New member.
2046         (operator_stoken): Update.
2047
2048 2019-01-06  Tom Tromey  <tom@tromey.com>
2049
2050         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2051         (union type_stack_elt) <typelist_val>: Now a pointer to
2052         std::vector.
2053         (type_stack_cleanup): Don't declare.
2054         (push_typelist): Update.
2055         * parse.c (pop_typelist): Return a std::vector.
2056         (push_typelist): Take a std::vector.
2057         (follow_types): Update.  Do not free args.
2058         (type_stack_cleanup): Remove.
2059         * c-exp.y (struct c_parse_state): New.
2060         (cpstate): New global.
2061         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2062         (nonempty_typelist): Update.
2063         (func_mod): Create a new vector.
2064         (c_parse): Create a c_parse_state.
2065         (check_parameter_typelist): Do not delete params.
2066         (function_method): Update.  Do not delete type_list.
2067
2068 2019-01-06  Tom Tromey  <tom@tromey.com>
2069
2070         PR gdb/28155:
2071         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2072         check_typedef.
2073         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2074         (print_return_value): Likewise.
2075
2076 2019-01-05  Tom Tromey  <tom@tromey.com>
2077
2078         * contrib/cleanup_check.py: Remove.
2079         * contrib/gcc-with-excheck: Remove.
2080         * contrib/exsummary.py: Remove.
2081         * contrib/excheck.py: Remove.
2082
2083 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2084
2085         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2086         NULL. Initialize tpprev to NULL instead of assigning it
2087         to NULL on the next statement.
2088         * windows-nat.c (windows_delete_thread): Remove check for
2089         main_thread_id before printing thread exit notifications.
2090         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2091         Remove thread ID check against main_thread_id.
2092         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2093         windows_delete_thread.
2094         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2095
2096 2019-01-04  Tom Tromey  <tom@tromey.com>
2097
2098         * compile/compile.c (_initialize_compile): Use upper case for
2099         metasyntactic variables.
2100         * symmisc.c (_initialize_symmisc): Use upper case for
2101         metasyntactic variables.
2102         * psymtab.c (_initialize_psymtab): Use upper case for
2103         metasyntactic variables.
2104         * demangle.c (demangle_command): Use upper case for metasyntactic
2105         variables.
2106         (_initialize_demangler): Likewise.
2107         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2108         variables.
2109
2110 2019-01-03  Tom Tromey  <tom@tromey.com>
2111
2112         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2113
2114 2019-01-03  Tom Tromey  <tom@tromey.com>
2115
2116         * python/py-symtab.c (salpy_str): Update.
2117         (struct salpy_sal_object) <symtab>: Now a PyObject.
2118         (salpy_dealloc): Update.
2119         (del_objfile_sal): Use gdbpy_ref.
2120
2121 2019-01-03  Tom Tromey  <tom@tromey.com>
2122
2123         * python/py-type.c (convert_field): Use new_reference.  Return
2124         gdbpy_ref.
2125         (make_fielditem): Return gdbpy_ref.
2126         (typy_fields): Update.
2127         (typy_getitem): Update.
2128         (field_name): Return gdbpy_ref.  Use new_reference.
2129         (typy_iterator_iternext): Update.
2130
2131 2019-01-03  Tom Tromey  <tom@tromey.com>
2132
2133         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2134
2135 2019-01-03  Tom Tromey  <tom@tromey.com>
2136
2137         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2138         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2139         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2140         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2141         (pspy_set_type_printers): Likewise.
2142         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2143         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2144         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2145         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2146         (objfpy_set_type_printers): Likewise.
2147
2148 2019-01-03  Tom Tromey  <tom@tromey.com>
2149
2150         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2151         (gdbpy_print_stack): Use gdbpy_err_fetch.
2152         * python/python-internal.h (class gdbpy_err_fetch): New class.
2153         (class gdbpy_enter) <m_error_type, m_error_value,
2154         m_error_traceback>: Remove.
2155         <m_error>: New member.
2156         (gdbpy_exception_to_string): Don't declare.
2157         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2158         * python/py-value.c (convert_value_from_python): Use
2159         gdbpy_err_fetch.
2160         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2161         gdbpy_exception_to_string.
2162         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2163         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2164         gdbpy_err_fetch.
2165
2166 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2167
2168         * linux-nat.c (delete_lwp_cleanup): Delete.
2169         (struct lwp_deleter): New struct.
2170         (lwp_info_up): New typedef.
2171         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2172         lwp_info_up.
2173
2174 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2175
2176         * linux-fork.c (class scoped_switch_fork_info): New class.
2177         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2178
2179 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2180
2181         * valops.c (find_overload_match): Remove use of null_cleanup, and
2182         calls to do_cleanups.
2183
2184 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2185
2186         * compile/compile-cplus-types.c
2187         (compile_cplus_instance::decl_name): Handle changes to
2188         cp_func_name.
2189         * cp-support.c (cp_func_name): Update header comment, update
2190         return type.
2191         * cp-support.h (cp_func_name): Update return type in declaration.
2192         * valops.c (find_overload_match): Move temp_func local to top
2193         level of function and change its type.  Use temp_func to hold and
2194         delete temporary string obtained from cp_func_name.
2195
2196 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2197
2198         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2199         gdb::char_vector, remove cleanup, and update uses of `msg`.
2200
2201 2019-01-03  Jim Wilson  <jimw@sifive.com>
2202
2203         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2204
2205 2019-01-02  Tom Tromey  <tom@tromey.com>
2206
2207         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2208         (tdesc_parse_xml): Remove cleanups.
2209         * target-descriptions.h (make_cleanup_free_target_description):
2210         Don't declare.
2211         (target_desc_deleter): New struct.
2212         (target_desc_up): New typedef.
2213         * target-descriptions.c (target_desc_deleter::operator()): Rename
2214         from free_target_description.
2215         (make_cleanup_free_target_description): Remove.
2216
2217 2019-01-02  Tom Tromey  <tom@tromey.com>
2218
2219         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2220         constructor, destructor.
2221         (linespec_parser): Remove typedef.
2222         (~linespec_parser): Rename from linespec_parser_delete.
2223         (linespec_lex_to_end, linespec_complete_label)
2224         (linespec_complete): Update.
2225         (decode_line_full): Remove cleanups.
2226         (decode_line_1): Update.
2227
2228 2019-01-02  Tom Tromey  <tom@tromey.com>
2229
2230         * python/python-internal.h (inferior_to_inferior_object): Change
2231         return type.
2232         * python/py-exitedevent.c (create_exited_event_object): Update.
2233         * python/py-inferior.c (inferior_to_inferior_object): Return
2234         gdbpy_ref.
2235         (python_new_inferior, python_inferior_deleted)
2236         (thread_to_thread_object, delete_thread_object)
2237         (build_inferior_list, gdbpy_selected_inferior): Update.
2238         * python/py-infthread.c (create_thread_object): Update.  Also fail
2239         if inferior_to_inferior_object fails.
2240
2241 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2242
2243         * inferior.h (class inferior) <displaced_step_state>: New field.
2244         * infrun.h (struct displaced_step_state): Move here from
2245         infrun.c.  Initialize fields, add constructor.
2246         <inf>: Remove field.
2247         <reset>: New method.
2248         * infrun.c (struct displaced_step_inferior_state): Move to
2249         infrun.h.
2250         (displaced_step_inferior_states): Remove.
2251         (get_displaced_stepping_state): Adust.
2252         (displaced_step_in_progress_any_inferior): Adjust.
2253         (displaced_step_in_progress_thread): Adjust.
2254         (displaced_step_in_progress): Adjust.
2255         (add_displaced_stepping_state): Remove.
2256         (get_displaced_step_closure_by_addr): Adjust.
2257         (remove_displaced_stepping_state): Remove.
2258         (infrun_inferior_exit): Call displaced_step_state.reset.
2259         (use_displaced_stepping): Don't check for NULL.
2260         (displaced_step_prepare_throw): Call
2261         get_displaced_stepping_state.
2262         (displaced_step_fixup): Don't check for NULL.
2263         (prepare_for_detach): Don't check for NULL.
2264
2265 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2266
2267         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2268          in case of call that did not complete.
2269
2270 2019-01-02  Andrey Utkin  <autkin@undo.io>
2271
2272         * symfile.c (find_separate_debug_file): Fix search of debug files for
2273         remote debuggee.
2274
2275 2019-01-02  Tom Tromey  <tom@tromey.com>
2276
2277         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2278         indentation.
2279         * python/py-frame.c (frapy_older): Remove cast.
2280         (frapy_newer): Likewise.
2281         * python/py-breakpoint.c (local_setattro): Remove cast.
2282         * python/py-arch.c (archpy_name): Remove local variable.
2283         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2284
2285 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2286
2287         * unittests/basic_string_view/element_access/char/empty.cc:
2288         Fix year range in copyright header.
2289
2290 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2291
2292         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2293         Delete.
2294         <operator==>: Update with for removed field.
2295         <hash>: Likewise.
2296         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2297         <isa_features>: ...this.
2298         <abi_features>: New field.
2299         (riscv_isa_flen): Update comment.
2300         (riscv_abi_xlen): New declaration.
2301         (riscv_abi_flen): New declaration.
2302         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2303         isa_features.
2304         (riscv_abi_xlen): New function.
2305         (riscv_isa_flen): Update to get answer from isa_features.
2306         (riscv_abi_flen): New function.
2307         (riscv_has_fp_abi): Update to get answer from abi_features.
2308         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2309         xlen and flen.
2310         (riscv_call_info) <xlen, flen>: Update comment.
2311         (riscv_call_arg_struct): Remove invalid assertions
2312         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2313         is removed.
2314         (riscv_gdbarch_init): Gather isa features and abi features
2315         separately, ensure both match on the gdbarch when reusing an old
2316         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2317         a target with 64-bit float hardware.
2318
2319 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2320
2321         * source.c (search_command_helper): Stop reverse search
2322         when line 1 has been searched.
2323
2324 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2325
2326         * record-full.c (record_full_base_target::close): Rewrite
2327         record_full_core_buf_list free logic.
2328
2329 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2330
2331         * break-catch-syscall.c (print_one_catch_syscall): xfree
2332         the last text.
2333
2334 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2335
2336         * top.c (print_gdb_version): Update Copyright year in version
2337         message.
2338
2339 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2340
2341         Update copyright year range in all GDB files.
2342
2343 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2344
2345         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2346
2347 For older changes see ChangeLog-2018.
2348 \f
2349 Local Variables:
2350 mode: change-log
2351 left-margin: 8
2352 fill-column: 74
2353 version-control: never
2354 coding: utf-8
2355 End:
2356