Simplify exception handling
[external/binutils.git] / gdb / ChangeLog
1 2019-04-08  Tom Tromey  <tom@tromey.com>
2
3         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5         (TRY, CATCH, END_CATCH): Remove some definitions.
6         * common/common-exceptions.c: Don't use GDB_XCPT.
7         (catcher_list_size): Remove.
8         (throw_exception, throw_it): Simplify.
9
10 2019-04-05  Tom Tromey  <tom@tromey.com>
11
12         Revert the header-sorting patch.
13         * ft32-tdep.c: Revert.
14         * frv-tdep.c: Revert.
15         * frv-linux-tdep.c: Revert.
16         * frame.c: Revert.
17         * frame-unwind.c: Revert.
18         * frame-base.c: Revert.
19         * fork-child.c: Revert.
20         * findvar.c: Revert.
21         * findcmd.c: Revert.
22         * filesystem.c: Revert.
23         * filename-seen-cache.h: Revert.
24         * filename-seen-cache.c: Revert.
25         * fbsd-tdep.c: Revert.
26         * fbsd-nat.h: Revert.
27         * fbsd-nat.c: Revert.
28         * f-valprint.c: Revert.
29         * f-typeprint.c: Revert.
30         * f-lang.c: Revert.
31         * extension.h: Revert.
32         * extension.c: Revert.
33         * extension-priv.h: Revert.
34         * expprint.c: Revert.
35         * exec.h: Revert.
36         * exec.c: Revert.
37         * exceptions.c: Revert.
38         * event-top.c: Revert.
39         * event-loop.c: Revert.
40         * eval.c: Revert.
41         * elfread.c: Revert.
42         * dwarf2read.h: Revert.
43         * dwarf2read.c: Revert.
44         * dwarf2loc.c: Revert.
45         * dwarf2expr.h: Revert.
46         * dwarf2expr.c: Revert.
47         * dwarf2-frame.c: Revert.
48         * dwarf2-frame-tailcall.c: Revert.
49         * dwarf-index-write.h: Revert.
50         * dwarf-index-write.c: Revert.
51         * dwarf-index-common.c: Revert.
52         * dwarf-index-cache.h: Revert.
53         * dwarf-index-cache.c: Revert.
54         * dummy-frame.c: Revert.
55         * dtrace-probe.c: Revert.
56         * disasm.h: Revert.
57         * disasm.c: Revert.
58         * disasm-selftests.c: Revert.
59         * dictionary.c: Revert.
60         * dicos-tdep.c: Revert.
61         * demangle.c: Revert.
62         * dcache.h: Revert.
63         * dcache.c: Revert.
64         * darwin-nat.h: Revert.
65         * darwin-nat.c: Revert.
66         * darwin-nat-info.c: Revert.
67         * d-valprint.c: Revert.
68         * d-namespace.c: Revert.
69         * d-lang.c: Revert.
70         * ctf.c: Revert.
71         * csky-tdep.c: Revert.
72         * csky-linux-tdep.c: Revert.
73         * cris-tdep.c: Revert.
74         * cris-linux-tdep.c: Revert.
75         * cp-valprint.c: Revert.
76         * cp-support.c: Revert.
77         * cp-namespace.c: Revert.
78         * cp-abi.c: Revert.
79         * corelow.c: Revert.
80         * corefile.c: Revert.
81         * continuations.c: Revert.
82         * completer.h: Revert.
83         * completer.c: Revert.
84         * complaints.c: Revert.
85         * coffread.c: Revert.
86         * coff-pe-read.c: Revert.
87         * cli-out.h: Revert.
88         * cli-out.c: Revert.
89         * charset.c: Revert.
90         * c-varobj.c: Revert.
91         * c-valprint.c: Revert.
92         * c-typeprint.c: Revert.
93         * c-lang.c: Revert.
94         * buildsym.c: Revert.
95         * buildsym-legacy.c: Revert.
96         * build-id.h: Revert.
97         * build-id.c: Revert.
98         * btrace.c: Revert.
99         * bsd-uthread.c: Revert.
100         * breakpoint.h: Revert.
101         * breakpoint.c: Revert.
102         * break-catch-throw.c: Revert.
103         * break-catch-syscall.c: Revert.
104         * break-catch-sig.c: Revert.
105         * blockframe.c: Revert.
106         * block.c: Revert.
107         * bfin-tdep.c: Revert.
108         * bfin-linux-tdep.c: Revert.
109         * bfd-target.c: Revert.
110         * bcache.c: Revert.
111         * ax-general.c: Revert.
112         * ax-gdb.h: Revert.
113         * ax-gdb.c: Revert.
114         * avr-tdep.c: Revert.
115         * auxv.c: Revert.
116         * auto-load.c: Revert.
117         * arm-wince-tdep.c: Revert.
118         * arm-tdep.c: Revert.
119         * arm-symbian-tdep.c: Revert.
120         * arm-pikeos-tdep.c: Revert.
121         * arm-obsd-tdep.c: Revert.
122         * arm-nbsd-tdep.c: Revert.
123         * arm-nbsd-nat.c: Revert.
124         * arm-linux-tdep.c: Revert.
125         * arm-linux-nat.c: Revert.
126         * arm-fbsd-tdep.c: Revert.
127         * arm-fbsd-nat.c: Revert.
128         * arm-bsd-tdep.c: Revert.
129         * arch-utils.c: Revert.
130         * arc-tdep.c: Revert.
131         * arc-newlib-tdep.c: Revert.
132         * annotate.h: Revert.
133         * annotate.c: Revert.
134         * amd64-windows-tdep.c: Revert.
135         * amd64-windows-nat.c: Revert.
136         * amd64-tdep.c: Revert.
137         * amd64-sol2-tdep.c: Revert.
138         * amd64-obsd-tdep.c: Revert.
139         * amd64-obsd-nat.c: Revert.
140         * amd64-nbsd-tdep.c: Revert.
141         * amd64-nbsd-nat.c: Revert.
142         * amd64-nat.c: Revert.
143         * amd64-linux-tdep.c: Revert.
144         * amd64-linux-nat.c: Revert.
145         * amd64-fbsd-tdep.c: Revert.
146         * amd64-fbsd-nat.c: Revert.
147         * amd64-dicos-tdep.c: Revert.
148         * amd64-darwin-tdep.c: Revert.
149         * amd64-bsd-nat.c: Revert.
150         * alpha-tdep.c: Revert.
151         * alpha-obsd-tdep.c: Revert.
152         * alpha-nbsd-tdep.c: Revert.
153         * alpha-mdebug-tdep.c: Revert.
154         * alpha-linux-tdep.c: Revert.
155         * alpha-linux-nat.c: Revert.
156         * alpha-bsd-tdep.c: Revert.
157         * alpha-bsd-nat.c: Revert.
158         * aix-thread.c: Revert.
159         * agent.c: Revert.
160         * addrmap.c: Revert.
161         * ada-varobj.c: Revert.
162         * ada-valprint.c: Revert.
163         * ada-typeprint.c: Revert.
164         * ada-tasks.c: Revert.
165         * ada-lang.c: Revert.
166         * aarch64-tdep.c: Revert.
167         * aarch64-ravenscar-thread.c: Revert.
168         * aarch64-newlib-tdep.c: Revert.
169         * aarch64-linux-tdep.c: Revert.
170         * aarch64-linux-nat.c: Revert.
171         * aarch64-fbsd-tdep.c: Revert.
172         * aarch64-fbsd-nat.c: Revert.
173         * aarch32-linux-nat.c: Revert.
174
175 2019-04-05  Tom Tromey  <tom@tromey.com>
176
177         * ft32-tdep.c: Sort headers.
178         * frv-tdep.c: Sort headers.
179         * frv-linux-tdep.c: Sort headers.
180         * frame.c: Sort headers.
181         * frame-unwind.c: Sort headers.
182         * frame-base.c: Sort headers.
183         * fork-child.c: Sort headers.
184         * findvar.c: Sort headers.
185         * findcmd.c: Sort headers.
186         * filesystem.c: Sort headers.
187         * filename-seen-cache.h: Sort headers.
188         * filename-seen-cache.c: Sort headers.
189         * fbsd-tdep.c: Sort headers.
190         * fbsd-nat.h: Sort headers.
191         * fbsd-nat.c: Sort headers.
192         * f-valprint.c: Sort headers.
193         * f-typeprint.c: Sort headers.
194         * f-lang.c: Sort headers.
195         * extension.h: Sort headers.
196         * extension.c: Sort headers.
197         * extension-priv.h: Sort headers.
198         * expprint.c: Sort headers.
199         * exec.h: Sort headers.
200         * exec.c: Sort headers.
201         * exceptions.c: Sort headers.
202         * event-top.c: Sort headers.
203         * event-loop.c: Sort headers.
204         * eval.c: Sort headers.
205         * elfread.c: Sort headers.
206         * dwarf2read.h: Sort headers.
207         * dwarf2read.c: Sort headers.
208         * dwarf2loc.c: Sort headers.
209         * dwarf2expr.h: Sort headers.
210         * dwarf2expr.c: Sort headers.
211         * dwarf2-frame.c: Sort headers.
212         * dwarf2-frame-tailcall.c: Sort headers.
213         * dwarf-index-write.h: Sort headers.
214         * dwarf-index-write.c: Sort headers.
215         * dwarf-index-common.c: Sort headers.
216         * dwarf-index-cache.h: Sort headers.
217         * dwarf-index-cache.c: Sort headers.
218         * dummy-frame.c: Sort headers.
219         * dtrace-probe.c: Sort headers.
220         * disasm.h: Sort headers.
221         * disasm.c: Sort headers.
222         * disasm-selftests.c: Sort headers.
223         * dictionary.c: Sort headers.
224         * dicos-tdep.c: Sort headers.
225         * demangle.c: Sort headers.
226         * dcache.h: Sort headers.
227         * dcache.c: Sort headers.
228         * darwin-nat.h: Sort headers.
229         * darwin-nat.c: Sort headers.
230         * darwin-nat-info.c: Sort headers.
231         * d-valprint.c: Sort headers.
232         * d-namespace.c: Sort headers.
233         * d-lang.c: Sort headers.
234         * ctf.c: Sort headers.
235         * csky-tdep.c: Sort headers.
236         * csky-linux-tdep.c: Sort headers.
237         * cris-tdep.c: Sort headers.
238         * cris-linux-tdep.c: Sort headers.
239         * cp-valprint.c: Sort headers.
240         * cp-support.c: Sort headers.
241         * cp-namespace.c: Sort headers.
242         * cp-abi.c: Sort headers.
243         * corelow.c: Sort headers.
244         * corefile.c: Sort headers.
245         * continuations.c: Sort headers.
246         * completer.h: Sort headers.
247         * completer.c: Sort headers.
248         * complaints.c: Sort headers.
249         * coffread.c: Sort headers.
250         * coff-pe-read.c: Sort headers.
251         * cli-out.h: Sort headers.
252         * cli-out.c: Sort headers.
253         * charset.c: Sort headers.
254         * c-varobj.c: Sort headers.
255         * c-valprint.c: Sort headers.
256         * c-typeprint.c: Sort headers.
257         * c-lang.c: Sort headers.
258         * buildsym.c: Sort headers.
259         * buildsym-legacy.c: Sort headers.
260         * build-id.h: Sort headers.
261         * build-id.c: Sort headers.
262         * btrace.c: Sort headers.
263         * bsd-uthread.c: Sort headers.
264         * breakpoint.h: Sort headers.
265         * breakpoint.c: Sort headers.
266         * break-catch-throw.c: Sort headers.
267         * break-catch-syscall.c: Sort headers.
268         * break-catch-sig.c: Sort headers.
269         * blockframe.c: Sort headers.
270         * block.c: Sort headers.
271         * bfin-tdep.c: Sort headers.
272         * bfin-linux-tdep.c: Sort headers.
273         * bfd-target.c: Sort headers.
274         * bcache.c: Sort headers.
275         * ax-general.c: Sort headers.
276         * ax-gdb.h: Sort headers.
277         * ax-gdb.c: Sort headers.
278         * avr-tdep.c: Sort headers.
279         * auxv.c: Sort headers.
280         * auto-load.c: Sort headers.
281         * arm-wince-tdep.c: Sort headers.
282         * arm-tdep.c: Sort headers.
283         * arm-symbian-tdep.c: Sort headers.
284         * arm-pikeos-tdep.c: Sort headers.
285         * arm-obsd-tdep.c: Sort headers.
286         * arm-nbsd-tdep.c: Sort headers.
287         * arm-nbsd-nat.c: Sort headers.
288         * arm-linux-tdep.c: Sort headers.
289         * arm-linux-nat.c: Sort headers.
290         * arm-fbsd-tdep.c: Sort headers.
291         * arm-fbsd-nat.c: Sort headers.
292         * arm-bsd-tdep.c: Sort headers.
293         * arch-utils.c: Sort headers.
294         * arc-tdep.c: Sort headers.
295         * arc-newlib-tdep.c: Sort headers.
296         * annotate.h: Sort headers.
297         * annotate.c: Sort headers.
298         * amd64-windows-tdep.c: Sort headers.
299         * amd64-windows-nat.c: Sort headers.
300         * amd64-tdep.c: Sort headers.
301         * amd64-sol2-tdep.c: Sort headers.
302         * amd64-obsd-tdep.c: Sort headers.
303         * amd64-obsd-nat.c: Sort headers.
304         * amd64-nbsd-tdep.c: Sort headers.
305         * amd64-nbsd-nat.c: Sort headers.
306         * amd64-nat.c: Sort headers.
307         * amd64-linux-tdep.c: Sort headers.
308         * amd64-linux-nat.c: Sort headers.
309         * amd64-fbsd-tdep.c: Sort headers.
310         * amd64-fbsd-nat.c: Sort headers.
311         * amd64-dicos-tdep.c: Sort headers.
312         * amd64-darwin-tdep.c: Sort headers.
313         * amd64-bsd-nat.c: Sort headers.
314         * alpha-tdep.c: Sort headers.
315         * alpha-obsd-tdep.c: Sort headers.
316         * alpha-nbsd-tdep.c: Sort headers.
317         * alpha-mdebug-tdep.c: Sort headers.
318         * alpha-linux-tdep.c: Sort headers.
319         * alpha-linux-nat.c: Sort headers.
320         * alpha-bsd-tdep.c: Sort headers.
321         * alpha-bsd-nat.c: Sort headers.
322         * aix-thread.c: Sort headers.
323         * agent.c: Sort headers.
324         * addrmap.c: Sort headers.
325         * ada-varobj.c: Sort headers.
326         * ada-valprint.c: Sort headers.
327         * ada-typeprint.c: Sort headers.
328         * ada-tasks.c: Sort headers.
329         * ada-lang.c: Sort headers.
330         * aarch64-tdep.c: Sort headers.
331         * aarch64-ravenscar-thread.c: Sort headers.
332         * aarch64-newlib-tdep.c: Sort headers.
333         * aarch64-linux-tdep.c: Sort headers.
334         * aarch64-linux-nat.c: Sort headers.
335         * aarch64-fbsd-tdep.c: Sort headers.
336         * aarch64-fbsd-nat.c: Sort headers.
337         * aarch32-linux-nat.c: Sort headers.
338
339 2019-04-04  Tom Tromey  <tom@tromey.com>
340
341         * varobj.c (varobj_create): Update.
342         * rust-exp.y (struct rust_parser) <update_innermost_block,
343         lookup_symbol>: New methods.
344         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
345         Rename.
346         (rust_parser::rust_lookup_type)
347         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
348         * printcmd.c (display_command, do_one_display): Update.
349         * parser-defs.h (struct parser_state) <parser_state>: Add
350         "tracker" parameter.
351         (block_tracker): New member.
352         (class innermost_block_tracker) <innermost_block_tracker>: Add
353         "types" parameter.
354         <reset>: Remove method.
355         (innermost_block): Don't declare.
356         (null_post_parser): Update.
357         * parse.c (innermost_block): Remove global.
358         (write_dollar_variable): Update.
359         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
360         Remove "tracker_types" parameter.
361         (parse_expression): Add "tracker" parameter.
362         (parse_expression_for_completion): Update.
363         (null_post_parser): Add "tracker" parameter.
364         * p-exp.y: Update rules.
365         * m2-exp.y: Update rules.
366         * language.h (struct language_defn) <la_post_parser>: Add
367         "tracker" parameter.
368         * go-exp.y: Update rules.
369         * f-exp.y: Update rules.
370         * expression.h (parse_expression, parse_exp_1): Add "tracker"
371         parameter.
372         * d-exp.y: Update rules.
373         * c-exp.y: Update rules.
374         * breakpoint.c (set_breakpoint_condition): Create an
375         innermost_block_tracker.
376         (watch_command_1): Likewise.
377         * ada-lang.c (resolve): Add "tracker" parameter.
378         (resolve_subexp): Likewise.
379         * ada-exp.y (write_var_from_sym): Update.
380
381 2019-04-04  Tom Tromey  <tom@tromey.com>
382
383         * type-stack.h: New file.
384         * type-stack.c: New file.
385         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
386         type-stack.h.
387         (insert_into_type_stack, insert_type, push_type, push_type_int)
388         (insert_type_address_space, pop_type, pop_type_int)
389         (pop_typelist, pop_type_stack, append_type_stack)
390         (push_type_stack, get_type_stack, push_typelist)
391         (follow_type_instance_flags, follow_types): Don't declare.
392         * parse.c (type_stack): Remove global.
393         (parse_exp_in_context): Update.
394         (insert_into_type_stack, insert_type, push_type, push_type_int)
395         (insert_type_address_space, pop_type, pop_type_int)
396         (pop_typelist, pop_type_stack, append_type_stack)
397         (push_type_stack, get_type_stack, push_typelist)
398         (follow_type_instance_flags, follow_types): Remove (moved to
399         type-stack.c).
400         * f-exp.y (type_stack): New global.
401         Update rules.
402         (push_kind_type, f_parse): Update.
403         * d-exp.y (type_stack): New global.
404         Update rules.
405         (d_parse): Update.
406         * c-exp.y (struct c_parse_state) <type_stack>: New member.
407         Update rules.
408         * Makefile.in (COMMON_SFILES): Add type-stack.c.
409         (HFILES_NO_SRCDIR): Add type-stack.h.
410
411 2019-04-04  Tom Tromey  <tom@tromey.com>
412
413         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
414         (rust_parser::convert_ast_to_expression, rust_parse)
415         (rust_lex_test_completion, rust_lex_tests): Update.
416         * parser-defs.h (struct expr_completion_state): New.
417         (struct parser_state) <parser_state>: Add completion parameter.
418         <mark_struct_expression, mark_completion_tag>: New methods.
419         <parse_completion, m_completion_state>: New members.
420         (prefixify_expression, null_post_parser): Update.
421         (mark_struct_expression, mark_completion_tag): Don't declare.
422         * parse.c (parse_completion, expout_last_struct)
423         (expout_tag_completion_type, expout_completion_name): Remove
424         globals.
425         (parser_state::mark_struct_expression)
426         (parser_state::mark_completion_tag): Now methods.
427         (prefixify_expression): Add last_struct parameter.
428         (prefixify_subexp): Likewise.
429         (parse_exp_1): Update.
430         (parse_exp_in_context): Add cstate parameter.  Update.
431         (parse_expression_for_completion): Create an
432         expr_completion_state.
433         (null_post_parser): Add "completion" parameter.
434         * p-exp.y: Update rules.
435         (yylex): Update.
436         * language.h (struct language_defn) <la_post_parser>: Add
437         "completing" parameter.
438         * go-exp.y: Update rules.
439         (lex_one_token): Update.
440         * expression.h (parse_completion): Don't declare.
441         * d-exp.y: Update rules.
442         (lex_one_token): Update rules.
443         * c-exp.y: Update rules.
444         (lex_one_token): Update.
445         * ada-lang.c (resolve): Add "parse_completion" parameter.
446         (resolve_subexp): Likewise.
447         (ada_resolve_function): Likewise.
448
449 2019-04-04  Tom Tromey  <tom@tromey.com>
450
451         * parser-defs.h (struct parser_state) <start_arglist,
452         end_arglist>: New methods.
453         <arglist_len, m_funcall_chain>: New members.
454         (arglist_len, start_arglist, end_arglist): Don't declare.
455         * parse.c (arglist_len, funcall_chain): Remove global.
456         (start_arglist, end_arglist): Remove functions.
457         (parse_exp_in_context): Update.
458         * p-exp.y: Update rules.
459         * m2-exp.y: Update rules.
460         * go-exp.y: Update rules.
461         * f-exp.y: Update rules.
462         * d-exp.y: Update rules.
463         * c-exp.y: Update rules.
464
465 2019-04-04  Tom Tromey  <tom@tromey.com>
466
467         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
468         lex_operator, push_back>: New methods.
469         Update all rules.
470         (rust_parser::lex_hex, lex_escape): Rename and update.
471         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
472         (rust_parser::lex_operator): Rename and update.
473         (rust_parser::lex_number, rustyylex, rustyyerror)
474         (rust_lex_test_init, rust_lex_test_sequence)
475         (rust_lex_test_push_back, rust_lex_tests): Update.
476         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
477         parameter.
478         <lexptr, prev_lexptr>: New members.
479         (lexptr, prev_lexptr): Don't declare.
480         * parse.c (lexptr, prev_lexptr): Remove globals.
481         (parse_exp_in_context): Update.
482         * p-exp.y (yylex, yyerror): Update.
483         * m2-exp.y (parse_number, yylex, yyerror): Update.
484         * go-exp.y (lex_one_token, yyerror): Update.
485         * f-exp.y (match_string_literal, yylex, yyerror): Update.
486         * d-exp.y (lex_one_token, yyerror): Update.
487         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
488         (lex_one_token, yyerror): Update.
489         * ada-lex.l (YY_INPUT): Update.
490         (rewind_to_char): Update.
491         * ada-exp.y (yyerror): Update.
492
493 2019-04-04  Tom Tromey  <tom@tromey.com>
494
495         * rust-exp.y (rustyylex, rust_lex_tests): Update.
496         * parser-defs.h (struct parser_state) <parser_state>: Add new
497         parameter.
498         <comma_terminates>: New member.
499         (comma_terminates): Don't declare global.
500         * parse.c (comma_terminates): Remove global.
501         (parse_exp_in_context): Update.
502         * p-exp.y (yylex): Update.
503         * m2-exp.y (yylex): Update.
504         * go-exp.y (lex_one_token): Update.
505         * f-exp.y (yylex): Update.
506         * d-exp.y (lex_one_token): Update.
507         * c-exp.y (lex_one_token): Update.
508         * ada-lex.l: Update.
509
510 2019-04-04  Tom Tromey  <tom@tromey.com>
511
512         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
513         (rustyylex, rust_lex_test_init, rust_lex_test_one)
514         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
515         * parser-defs.h (paren_depth): Don't declare.
516         * parse.c (paren_depth): Remove global.
517         (parse_exp_in_context): Update.
518         * p-exp.y (paren_depth): New global.
519         (pascal_parse): Initialize it.
520         * m2-exp.y (paren_depth): New global.
521         (m2_parse): Initialize it.
522         * go-exp.y (paren_depth): New global.
523         (go_parse): Initialize it.
524         * f-exp.y (paren_depth): New global.
525         (f_parse): Initialize it.
526         * d-exp.y (paren_depth): New global.
527         (d_parse): Initialize it.
528         * c-exp.y (paren_depth): New global.
529         (c_parse): Initialize it.
530         * ada-lex.l (paren_depth): New global.
531         (lexer_init): Initialize it.
532
533 2019-04-04  Tom Tromey  <tom@tromey.com>
534
535         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
536         (rust_parser::convert_ast_to_type)
537         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
538         * parser-defs.h (struct parser_state) <parser_state>: Add
539         parameters.  Initialize new members.
540         <expression_context_block, expression_context_pc>: New members.
541         * parse.c (expression_context_block, expression_context_pc):
542         Remove globals.
543         (parse_exp_in_context): Update.
544         * p-exp.y: Update all rules.
545         (yylex): Update.
546         * m2-exp.y: Update all rules.
547         (yylex): Update.
548         * go-exp.y (yylex): Update.
549         * f-exp.y (yylex): Update.
550         * d-exp.y: Update all rules.
551         (yylex): Update.
552         * c-exp.y: Update all rules.
553         (lex_one_token, classify_name, yylex, c_parse): Update.
554         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
555
556 2019-04-04  Tom Tromey  <tom@tromey.com>
557
558         * gdbarch.h, gdbarch.c: Rebuild.
559         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
560         * stap-probe.h: 
561         (struct stap_parse_info): Replace "parser_state" with
562         "expr_builder".
563         * parser-defs.h (struct expr_builder): Rename from "parser_state".
564         (parser_state): New class.
565         * parse.c (expr_builder): Rename.
566         (expr_builder::release): Rename.
567         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
568         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
569         (write_exp_elt_longcst, write_exp_elt_floatcst)
570         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
571         (write_exp_string_vector, write_exp_bitstring)
572         (write_exp_msymbol, mark_struct_expression)
573         (write_dollar_variable)
574         (insert_type_address_space, increase_expout_size): Replace
575         "parser_state" with "expr_builder".
576         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
577         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
578         "parser_state" with "expr_builder".
579
580 2019-04-04  Tom Tromey  <tom@tromey.com>
581
582         * rust-exp.y: Replace "parse_language" with method call.
583         * p-exp.y: 
584         (yylex): Replace "parse_language" with method call.
585         * m2-exp.y: 
586         (yylex): Replace "parse_language" with method call.
587         * go-exp.y (classify_name): Replace "parse_language" with method
588         call.
589         * f-exp.y (yylex): Replace "parse_language" with method call.
590         * d-exp.y (lex_one_token): Replace "parse_language" with method
591         call.
592         * c-exp.y: 
593         (lex_one_token, classify_name, yylex): Replace "parse_language"
594         with method call.
595         * ada-exp.y (find_primitive_type, type_char)
596         (type_system_address): Replace "parse_language" with method call.
597
598 2019-04-04  Tom Tromey  <tom@tromey.com>
599
600         * rust-exp.y: Replace "parse_gdbarch" with method call.
601         * parse.c (write_dollar_variable, insert_type_address_space):
602         Replace "parse_gdbarch" with method call.
603         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
604         call.
605         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
606         call.
607         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
608         "parse_gdbarch" with method call.
609         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
610         with method call.
611         * f-exp.y (parse_type, parse_f_type, yylex): Replace
612         "parse_gdbarch" with method call.
613         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
614         "parse_gdbarch" with method call.
615         * c-exp.y (parse_type, parse_number, classify_name): Replace
616         "parse_gdbarch" with method call.
617         * ada-lex.l: Replace "parse_gdbarch" with method call.
618         * ada-exp.y (parse_type, find_primitive_type, type_char)
619         (type_system_address): Replace "parse_gdbarch" with method call.
620
621 2019-04-04  Tom Tromey  <tom@tromey.com>
622
623         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
624         * stap-probe.c (stap_parse_argument): Update.
625         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
626         initial_size parameter.
627         * rust-exp.y (rust_lex_tests): Update.
628         * parse.c (parser_state): Update.
629         (parse_exp_in_context): Update.
630         * parser-defs.h (struct parser_state) <parser_state>: Remove
631         "initial_size" parameter.
632
633 2019-04-04  Tom Tromey  <tom@tromey.com>
634
635         * parser-defs.h (increase_expout_size): Don't declare.
636         * parse.c (increase_expout_size): Now static.
637
638 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
639
640         * gnu-nat.c (gnu_nat_target::wait): Fix
641         target_waitstatus_to_string call.
642
643 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
644
645         * eval.c (evaluate_subexp_standard): Handle internal functions
646         during Fortran function call handling.
647
648 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
649
650         * NEWS: Mention new internal functions.
651         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
652         (read_base_type): Use dwarf2_init_complex_target_type.
653         * value.c (creal_internal_fn): New function.
654         (cimag_internal_fn): New function.
655         (_initialize_values): Register new internal functions.
656
657 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
658
659         * infrun.c (stop_all_threads): If debug_infrun, always
660         trace the wait status after wait_one, using
661         target_waitstatus_to_string and target_pid_to_str.
662         (handle_inferior_event): Replace various trace of
663         wait status kind by a single trace.
664         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
665         wait status kind image by target_waitstatus_to_string.
666         * target/waitstatus.c (target_waitstatus_to_string): Fix
667         obsolete comment.
668
669 2019-04-01  Tom Tromey  <tromey@adacore.com>
670
671         PR symtab/23331:
672         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
673
674 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
675             Pedro Alves  <palves@redhat.com>
676
677         * top.c (quit_force): Call 'finalize_values'.
678         * value.c (finalize_values): New function.
679         * value.h (finalize_values): Declare.
680
681 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
682
683         * NEWS: Announce $_gdb_major and $_gdb_minor.
684
685         * top.c (init_gdb_version_vars): New function.
686         (gdb_init): Call init_gdb_version_vars.
687
688 2019-03-29  Tom Tromey  <tromey@adacore.com>
689
690         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
691         help text.  Remove dead code.
692
693 2019-03-29  Keith Seitz  <keiths@redhat.com>
694
695         From Siddhesh Poyarekar:
696         * f-lang.h (f77_get_upperbound): Return LONGEST.
697         (f77_get_lowerbound): Likewise.
698         * f-typeprint.c (f_type_print_varspec_suffix): Expand
699         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
700         print them.
701         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
702         plongest to format print it.
703         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
704         (f77_get_upperbound): Likewise.
705         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
706         LOWER_BOUND to LONGEST.
707         (f77_create_arrayprint_offset_tbl): Likewise.
708
709 2019-03-29  Keith Seitz  <keiths@redhat.com>
710
711         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
712         %s/pulongest for TYPE_LENGTH instead of %d in format
713         strings.
714         * ada-typerint.c (ada_print_type): Likewise.
715         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
716         * compile/compile-c-support.c (generate_register_struct): Likewise.
717         * gdbtypes.c (recursive_dump_type): Likewise.
718         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
719         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
720         instead of %d in format strings.
721         * riscv-tdep.c (riscv_type_alignment): Cast second argument
722         to std::min to ULONGEST.
723         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
724         instead of %d in format strings.
725         * tracepoint.c (info_scope_command): Likewise.
726         * typeprint.c (print_offset_data::update)
727         (print_offset_data::finish): Likewise.
728         * xtensa-tdep.c (xtensa_store_return_value)
729         (xtensa_push_dummy_call): Likewise.
730
731 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
732
733         * windows-nat.c (display_selector): Fixed format specifications
734         for 64-bit Cygwin.
735
736 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
737
738         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
739
740 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
741
742         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
743         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
744         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
745         (nios2_linux_init_abi): Install it.
746
747 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
748
749         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
750
751 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
752
753         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
754
755 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
756             Tom Tromey  <tromey@adacore.com>
757
758         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
759
760 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
761
762         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
763         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
764         method to compute the bounds of range types. Also print "[evaluated]"
765         if the bounds' values come from a dynamic evaluation.
766
767 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
768
769         * cp-valprint.c (cp_print_value_fields): Don't print trailing
770         whitespace when pretty printing is on.
771
772 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
773
774         * ppc-linux-nat.c: Add include.
775
776 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
777
778         * NEWS: Mention AArch64 Pointer Authentication.
779
780 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
781
782         * arm-linux-nat.c: Add include.
783
784 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
785
786         * source-cache.c (source_cache::get_source_lines): Re-read
787         fullname after calling open_source_file.
788
789 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
790
791         * NEWS: Mention TLS support for FreeBSD.
792
793 2019-03-25  Tom Tromey  <tromey@adacore.com>
794
795         * minsyms.c (BUNCH_SIZE): Update comment.
796         (~minimal_symbol_reader): Remove old comment.
797         (compact_minimal_symbols): Update comment.
798         (minimal_symbol_reader::install): Remove old comment.  Update
799         other comments.
800
801 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
802
803         * s390-linux-nat.c: Add include.
804
805 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
806
807         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
808         Call linux_get_hwcap.
809         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
810         Likewise.
811         (aarch64_linux_get_hwcap): Remove function.
812         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
813         declaration.
814         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
815         linux_get_hwcap.
816         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
817         * linux-tdep.c (linux_get_hwcap): Add function.
818         (linux_get_hwcap2): Likewise.
819         * linux-tdep.h (linux_get_hwcap): Add declaration.
820         (linux_get_hwcap2): Likewise.
821         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
822         (ppc_linux_get_hwcap2): Likewise.
823         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
824         linux_get_hwcap.
825         (ppc_linux_nat_target::insert_watchpoint): Likewise.
826         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
827         (ppc_linux_nat_target::read_description): Likewise.
828         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
829         * s390-linux-nat.c: Likewise.
830         * s390-linux-tdep.c (s390_core_read_description): Likewise.
831
832 2019-03-24  Tom Tromey  <tom@tromey.com>
833
834         * ada-lang.c (standard_lookup): Simplify initialization.
835         (ada_lookup_symbol_nonlocal): Simplify return.
836         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
837         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
838         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
839         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
840         initialization.
841         * solib.c (solib_global_lookup): Simplify.
842         * symtab.c (null_block_symbol): Remove.
843         (symbol_cache_lookup): Simplify returns.
844         (lookup_language_this): Simplify returns.
845         (lookup_symbol_aux): Simplify return.
846         (lookup_local_symbol): Simplify returns.
847         (lookup_global_symbol_from_objfile): Simplify return.
848         (lookup_symbol_in_objfile_symtabs)
849         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
850         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
851         (lookup_static_symbol, lookup_global_symbol): Simplify return.
852         * cp-namespace.c (cp_lookup_bare_symbol)
853         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
854         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
855         (cp_lookup_nested_symbol): Don't use null_block_symbol.
856         (cp_lookup_symbol_via_imports): Simplify initialization.
857         (find_symbol_in_baseclass): Likewise.
858         * symtab.h (null_block_symbol): Remove.
859         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
860         (d_lookup_nested_symbol, d_lookup_symbol_imports)
861         (d_lookup_symbol_module): Likewise.
862         (find_symbol_in_baseclass): Simplify initialization.
863
864 2019-03-24  Tom Tromey  <tom@tromey.com>
865
866         * expression.h: Don't include symtab.h.
867         (struct block): Forward declare.
868
869 2019-03-24  Tom Tromey  <tom@tromey.com>
870
871         * c-exp.y (typebase): Remove casts.
872         * gdbtypes.c (lookup_unsigned_typename, )
873         (lookup_signed_typename): Remove cast.
874         * eval.c (parse_to_comma_and_eval): Remove cast.
875         * parse.c (write_dollar_variable): Remove cast.
876         * block.h (struct block) <superblock>: Now const.
877         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
878         * psymtab.c (psym_map_matching_symbols): Make "block" const.
879         (map_block): Make "block" const.
880         * symfile.h (struct quick_symbol_functions)
881         <map_matching_symbols>: Constify block argument to "callback".
882         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
883         const.
884         (find_pc_sect_compunit_symtab): Make "b" const.
885         (find_symbol_at_address): Likewise.
886         (search_symbols): Likewise.
887         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
888         (dw2_debug_names_lookup_symbol): Likewise.
889         (dw2_map_matching_symbols): Update.
890         * p-valprint.c (pascal_val_print): Remove "block".
891         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
892         (aux_add_nonlocal_symbols): Make "block" const.
893         (resolve_subexp): Remove cast.
894         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
895         const.
896         (iterate_over_file_blocks): Likewise.
897         * f-exp.y (%union) <bval>: Remove.
898         * coffread.c (patch_opaque_types): Make "b" const.
899         * spu-tdep.c (spu_catch_start): Make "block" const.
900         * c-valprint.c (print_unpacked_pointer): Remove "block".
901         * symmisc.c (dump_symtab_1): Make "b" const.
902         (block_depth): Make "block" const.
903         * d-exp.y (%union) <bval>: Remove.
904         * cp-support.h (cp_lookup_rtti_type): Update.
905         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
906         * psymtab.c (psym_lookup_symbol): Make "block" const.
907         (maintenance_check_psymtabs): Make "b" const.
908         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
909         (enumerate_locals, enumerate_args): Update.
910         * python/py-symtab.c (stpy_global_block): Make "block" const.
911         (stpy_static_block): Likewise.
912         * inline-frame.c (block_starting_point_at): Make "new_block"
913         const.
914         * block.c (find_block_in_blockvector): Make return type const.
915         (blockvector_for_pc_sect): Make "b" const.
916         (find_block_in_blockvector): Make "b" const.
917
918 2019-03-23  Tom Tromey  <tom@tromey.com>
919
920         * varobj.c (varobj_create): Update.
921         * symfile.c (clear_symtab_users): Don't reset innermost_block.
922         * printcmd.c (display_command, do_one_display): Don't reset
923         innermost_block.
924         * parser-defs.h (enum innermost_block_tracker_type): Move to
925         expression.h.
926         (innermost_block): Update comment.
927         * parse.c (parse_exp_1): Add tracker_types parameter.
928         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
929         tracker_types parameter.  Reset innermost_block.
930         (parse_exp_in_context): Remove.
931         (parse_expression_for_completion): Update.
932         * objfiles.c (~objfile): Don't reset expression_context_block or
933         innermost_block.
934         * expression.h (enum innermost_block_tracker_type): Move from
935         parser-defs.h.
936         (parse_exp_1): Add tracker_types parameter.
937         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
938         reset innermost_block.
939
940 2019-03-23  Tom Tromey  <tom@tromey.com>
941
942         * objfiles.h: Include bcache.h.
943
944 2019-03-23  Tom Tromey  <tom@tromey.com>
945
946         * linespec.c (get_current_search_block): Use
947         scoped_restore_current_language.
948         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
949
950 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
951             Jiong Wang  <jiong.wang@arm.com>
952
953         * aarch64-linux-tdep.c
954         (aarch64_linux_iterate_over_regset_sections): Check for pauth
955         section.
956         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
957
958 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
959             Jiong Wang  <jiong.wang@arm.com>
960
961         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
962         instructions.
963         (aarch64_analyze_prologue_test): Add PACIASP test.
964         (aarch64_prologue_prev_register): Unmask PC value.
965
966 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
967             Jiong Wang  <jiong.wang@arm.com>
968
969         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
970         (aarch64_dwarf2_prev_register): Unmask PC value.
971         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
972         (aarch64_execute_dwarf_cfa_vendor_op): Check for
973         DW_CFA_AARCH64_negate_ra_state.
974         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
975
976 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
977             Jiong Wang  <jiong.wang@arm.com>
978
979         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
980         registers.
981         (aarch64_pseudo_register_name): Likewise.
982         (aarch64_pseudo_register_type): Likewise.
983         (aarch64_pseudo_register_reggroup_p): Likewise.
984         (aarch64_gdbarch_init): Add pauth registers.
985         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
986         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
987         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
988         (struct gdbarch_tdep): Add regnum for ra_state.
989
990 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
991             Jiong Wang  <jiong.wang@arm.com>
992
993         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
994
995 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
996             Jiong Wang  <jiong.wang@arm.com>
997
998         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
999         function.
1000         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1001         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1002         (aarch64_gdbarch_init): Add puth registers.
1003         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1004         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1005         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1006
1007 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1008             Jiong Wang  <jiong.wang@arm.com>
1009
1010         * aarch64-linux-nat.c
1011         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1012         * aarch64-linux-tdep.c
1013         (aarch64_linux_core_read_description): Likewise.
1014         (aarch64_linux_get_hwcap): New function.
1015         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1016         (aarch64_linux_get_hwcap): New declaration.
1017
1018 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1019             Jiong Wang  <jiong.wang@arm.com>
1020
1021         * aarch64-linux-nat.c
1022         (aarch64_linux_nat_target::read_description): Add pauth param.
1023         * aarch64-linux-tdep.c
1024         (aarch64_linux_core_read_description): Likewise.
1025         * aarch64-tdep.c (struct target_desc): Add in pauth.
1026         (aarch64_read_description): Add pauth param.
1027         (aarch64_gdbarch_init): Likewise.
1028         * aarch64-tdep.h (aarch64_read_description): Likewise.
1029         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1030         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1031         * features/Makefile: Add new files.
1032         * features/aarch64-pauth.c: New file.
1033         * features/aarch64-pauth.xml: New file.
1034
1035 2019-03-20  Tom Tromey  <tromey@adacore.com>
1036
1037         * infrun.c (handle_inferior_event): Rename from
1038         handle_inferior_event_1.  Create a scoped_value_mark.
1039         (handle_inferior_event): Remove.
1040
1041 2019-03-19  Tom Tromey  <tromey@adacore.com>
1042
1043         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1044         * infrun.h (print_stop_event): Add "displays" parameter.
1045         * infrun.c (print_stop_event): Add "displays" parameter.
1046
1047 2019-03-19  Pedro Alves  <palves@redhat.com>
1048
1049         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1050         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1051         to -1.  Fix TABs vs spaces.
1052         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1053         * tui/tui-out.h (tui_ui_out) Add intro comments.
1054         <m_line, m_start_of_line>: In-class initialize, and add describing
1055         comment.
1056
1057 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1058
1059         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1060         variable names.
1061         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1062
1063 2019-03-18  Pedro Alves  <palves@redhat.com>
1064             Eli Zaretskii <eliz@gnu.org>
1065
1066         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1067         m_line and m_start_of_line.
1068
1069 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1070
1071         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1072         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1073         it returns a newline.  This fixes a regression in TU mode, whereby
1074         the next line is output on the same screen line as the user input.
1075
1076 2019-03-18  Tom Tromey  <tromey@adacore.com>
1077
1078         * minsyms.c (minimal_symbol_reader::install): Remove call to
1079         obstack_blank.
1080
1081 2019-03-18  Pedro Alves  <palves@redhat.com>
1082
1083         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1084         New globals.
1085         (apply_style): New, factored out from ...
1086         (apply_ansi_escape): ... this.  Handle reverse video mode.
1087         (tui_set_reverse_mode): New function.
1088         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1089         * tui/tui-winsource.c (tui_show_source_line): Use
1090         tui_set_reverse_mode instead of setting A_STANDOUT.
1091         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1092         New setter methods.
1093
1094 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1095
1096         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1097         Handle tabs.
1098
1099 2019-03-18  Tom Tromey  <tromey@adacore.com>
1100
1101         * ada-lang.c (empty_array): Add "high" parameter.
1102         (ada_evaluate_subexp): Update.
1103
1104 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1105
1106         * unittests/string_view-selftests.c: Define
1107         _initialize_string_view_selftests unconditionally.
1108
1109 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1110
1111         PR gdb/24350
1112         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1113
1114 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1115
1116         PR gdb/24351
1117         * windows-nat.c (display_selector): Fix format specifiers.
1118
1119 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1120
1121         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1122         tui_refill_source_window instead of tui_refresh_win, to update the
1123         current execution line.  This fixes redisplay of the current line
1124         when stepping through the code with "next" or "step".
1125
1126 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1127
1128         * source-cache.c (source_cache::get_source_lines): Call
1129         find_source_lines to initialize s->nlines.  This fixes vertical
1130         scrolling of TUI source window when the DOWN arrow is pressed.
1131
1132 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1133
1134         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1135         linux-thread-db.c (_initialize_thread_db): Likewise.
1136
1137 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1138
1139         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1140         wclrtoeol in tui_show_source_line".  This reverts changes made in
1141         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1142
1143 2019-03-15  Tom Tromey  <tom@tromey.com>
1144
1145         * symtab.h (struct minimal_symbol): Derive from
1146         general_symbol_info.
1147         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1148         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1149         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1150         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1151         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1152         (MSYMBOL_SEARCH_NAME): Update.
1153         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1154         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1155         * minsyms.c (minimal_symbol_reader::record_full): Update.
1156
1157 2019-03-15  Tom Tromey  <tom@tromey.com>
1158
1159         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1160
1161 2019-03-15  Tom Tromey  <tom@tromey.com>
1162
1163         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1164         unique_xmalloc_ptr.
1165         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1166         Update.
1167         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1168         (build_minimal_symbol_hash_tables)
1169         (minimal_symbol_reader::install): Update.
1170
1171 2019-03-15  Tom Tromey  <tom@tromey.com>
1172
1173         * symtab.c (create_demangled_names_hash): Update.
1174         (symbol_set_names): Update.
1175         * objfiles.h (struct objfile_per_bfd_storage)
1176         <demangled_names_hash>: Now an htab_up.
1177         * objfiles.c (objfile_per_bfd_storage): Simplify.
1178
1179 2019-03-15  Tom Tromey  <tom@tromey.com>
1180
1181         * objfiles.h (struct objfile_per_bfd_storage): Declare
1182         destructor.
1183         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1184         New.
1185         (get_objfile_bfd_data): Use new.  Don't initialize
1186         language_of_main.
1187         (free_objfile_per_bfd_storage): Remove.
1188         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1189
1190 2019-03-15  Tom Tromey  <tom@tromey.com>
1191
1192         * symfile.c (reread_symbols): Update.
1193         * objfiles.c (objfile::objfile): Update.
1194         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1195         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1196         comment.
1197         (minimal_symbol_reader::install): Update.
1198         (terminate_minimal_symbol_table): Remove.
1199         * jit.c (jit_object_close_impl): Update.
1200
1201 2019-03-15  Tom Tromey  <tom@tromey.com>
1202
1203         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1204         initializations.
1205
1206 2019-03-15  Tom Tromey  <tom@tromey.com>
1207
1208         * objfiles.h (struct objfile_per_bfd_storage)
1209         <demangled_hash_languages>: Now a bitset.
1210         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1211         (lookup_minimal_symbol): Update.
1212
1213 2019-03-15  Tom Tromey  <tom@tromey.com>
1214
1215         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1216         Don't return the symbol.
1217         * coffread.c (record_minimal_symbol): Use record_full.
1218
1219 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1220
1221         The MS-Windows port of ncurses fails to switch to a color pair if
1222         one or both of the colors are the implicit default colors.  This
1223         change records the default colors when TUI is initialized, and
1224         then specifies them explicitly when a color pair uses the default
1225         colors.  This allows color styling in TUI mode on MS-Windows.
1226
1227         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1228         ncurses_norm_attr.
1229         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1230         colors in ncurses_norm_attr.
1231         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1232         "none", replace it with the default color recorded in
1233         ncurses_norm_attr.
1234
1235 2019-03-14  Tom Tromey  <tromey@adacore.com>
1236
1237         * source-cache.h (class source_cache) <get_source_lines>: Return
1238         std::string.
1239         * source-cache.c (source_cache::extract_lines): Handle case where
1240         first_pos==npos.  Return std::string.
1241         (source_cache::get_source_lines): Update.
1242
1243 2019-03-14  Tom Tromey  <tromey@adacore.com>
1244
1245         * NEWS: Add item for "style sources" commands.
1246         * source-cache.c (source_cache::get_source_lines): Check
1247         source_styling.
1248         * cli/cli-style.c (source_styling): New global.
1249         (_initialize_cli_style): Add "style sources" commands.
1250         (show_style_sources): New function.
1251         * cli/cli-style.h (source_styling): Declare.
1252
1253 2019-03-14  Pedro Alves  <palves@redhat.com>
1254             Tom Tromey  <tromey@adacore.com>
1255
1256         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1257         * tui/tui-winsource.c (tui_refill_source_window): New function,
1258         from...
1259         (tui_horizontal_source_scroll): ... here.  Move some logic.
1260         * cli/cli-style.c (set_style_enabled): Notify new observable.
1261         * tui/tui-hooks.c (tui_redisplay_source): New function.
1262         (tui_attach_detach_observers): Attach or detach
1263         tui_redisplay_source.
1264         * observable.h (source_styling_changed): New observable.
1265         * observable.c: Define source_styling_changed observable.
1266
1267 2019-03-13  Tom Tromey  <tromey@adacore.com>
1268
1269         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1270         (i386_gnu_nat_target::store_registers): Update.
1271         * target-debug.h (target_debug_print_std_string): New macro.
1272         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1273         * windows-tdep.c (display_one_tib): Update.
1274         * tui/tui-stack.c (tui_make_status_line): Update.
1275         * top.c (print_inferior_quit_action): Update.
1276         * thread.c (thr_try_catch_cmd): Update.
1277         (add_thread_with_info): Update.
1278         (thread_target_id_str): Update.
1279         (thr_try_catch_cmd): Update.
1280         (thread_command): Update.
1281         (thread_find_command): Update.
1282         * record-btrace.c (record_btrace_target::info_record)
1283         (record_btrace_resume_thread, record_btrace_target::resume)
1284         (record_btrace_cancel_resume, record_btrace_step_thread)
1285         (record_btrace_target::wait, record_btrace_target::wait)
1286         (record_btrace_target::wait, record_btrace_target::stop): Update.
1287         * progspace.c (print_program_space): Update.
1288         * process-stratum-target.c
1289         (process_stratum_target::thread_address_space): Update.
1290         * linux-fork.c (linux_fork_mourn_inferior)
1291         (detach_checkpoint_command, info_checkpoints_command)
1292         (linux_fork_context): Update.
1293         (linux_fork_detach): Update.
1294         (class scoped_switch_fork_info): Update.
1295         (delete_checkpoint_command): Update.
1296         * infrun.c (follow_fork_inferior): Update.
1297         (follow_fork_inferior): Update.
1298         (proceed_after_vfork_done): Update.
1299         (handle_vfork_child_exec_or_exit): Update.
1300         (follow_exec): Update.
1301         (displaced_step_prepare_throw): Update.
1302         (displaced_step_restore): Update.
1303         (start_step_over): Update.
1304         (resume_1): Update.
1305         (clear_proceed_status_thread): Update.
1306         (proceed): Update.
1307         (print_target_wait_results): Update.
1308         (do_target_wait): Update.
1309         (context_switch): Update.
1310         (stop_all_threads): Update.
1311         (restart_threads): Update.
1312         (finish_step_over): Update.
1313         (handle_signal_stop): Update.
1314         (switch_back_to_stepped_thread): Update.
1315         (keep_going_pass_signal): Update.
1316         (print_exited_reason): Update.
1317         (normal_stop): Update.
1318         * inferior.c (inferior_pid_to_str): Change return type.
1319         (print_selected_inferior): Update.
1320         (add_inferior): Update.
1321         (detach_inferior): Update.
1322         * dummy-frame.c (fprint_dummy_frames): Update.
1323         * dcache.c (dcache_info_1): Update.
1324         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1325         (btrace_fetch, btrace_clear): Update.
1326         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1327         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1328         type.
1329         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1330         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1331         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1332         * gdbarch.c, gdbarch.h: Rebuild.
1333         * gdbarch.sh (core_pid_to_str): Change return type.
1334         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1335         return type.
1336         (windows_nat_target::pid_to_str): Change return type.
1337         (windows_delete_thread): Update.
1338         (windows_nat_target::attach): Update.
1339         (windows_nat_target::files_info): Update.
1340         * target-delegates.c: Rebuild.
1341         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1342         return type.
1343         (sol_thread_target::pid_to_str): Change return type.
1344         * remote.c (class remote_target) <pid_to_str>: Change return
1345         type.
1346         (remote_target::pid_to_str): Change return type.
1347         (extended_remote_target::attach, remote_target::remote_stop_ns)
1348         (remote_target::remote_notif_remove_queued_reply)
1349         (remote_target::push_stop_reply, remote_target::disable_btrace):
1350         Update.
1351         (extended_remote_target::attach): Update.
1352         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1353         type.
1354         (gdbsim_target::pid_to_str): Change return type.
1355         * ravenscar-thread.c (struct ravenscar_thread_target)
1356         <pid_to_str>: Change return type.
1357         (ravenscar_thread_target::pid_to_str): Change return type.
1358         * procfs.c (class procfs_target) <pid_to_str>: Change return
1359         type.
1360         (procfs_target::pid_to_str): Change return type.
1361         (procfs_target::attach): Update.
1362         (procfs_target::detach): Update.
1363         (procfs_target::fetch_registers): Update.
1364         (procfs_target::store_registers): Update.
1365         (procfs_target::wait): Update.
1366         (procfs_target::files_info): Update.
1367         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1368         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1369         return type.
1370         (nto_procfs_target::pid_to_str): Change return type.
1371         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1372         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1373         return type.
1374         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1375         (exit_lwp): Update.
1376         (attach_proc_task_lwp_callback, get_detach_signal)
1377         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1378         (linux_nat_target::resume, wait_lwp, stop_callback)
1379         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1380         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1381         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1382         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1383         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1384         type.
1385         (inf_ptrace_target::attach): Update.
1386         (inf_ptrace_target::files_info): Update.
1387         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1388         type.
1389         (go32_nat_target::pid_to_str): Change return type.
1390         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1391         (gnu_nat_target::wait): Update.
1392         (gnu_nat_target::wait): Update.
1393         (gnu_nat_target::resume): Update.
1394         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1395         (fbsd_nat_target::wait): Update.
1396         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1397         type.
1398         (darwin_nat_target::attach): Update.
1399         * corelow.c (class core_target) <pid_to_str>: Change return type.
1400         (core_target::pid_to_str): Change return type.
1401         * target.c (normal_pid_to_str): Change return type.
1402         (default_pid_to_str): Likewise.
1403         (target_pid_to_str): Change return type.
1404         (target_translate_tls_address): Update.
1405         (target_announce_detach): Update.
1406         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1407         return type.
1408         (bsd_uthread_target::pid_to_str): Change return type.
1409         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1410         type.
1411         (bsd_kvm_target::pid_to_str): Change return type.
1412         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1413         return type.
1414         (aix_thread_target::pid_to_str): Change return type.
1415         * target.h (struct target_ops) <pid_to_str>: Change return type.
1416         (target_pid_to_str, normal_pid_to_str): Likewise.
1417         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1418         type.
1419         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1420         type.
1421         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1422         return type.
1423         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1424         type.
1425         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1426         type.
1427         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1428         return type.
1429
1430 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1431
1432         * NEWS: Mention that the new default MI version is 3.  Mention
1433         changes to the output of commands and events that deal with
1434         multi-location breakpoints.
1435         * breakpoint.c: Include "mi/mi-out.h".
1436         (print_one_breakpoint): Change output syntax if using MI version
1437         >= 3.
1438         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1439         New.
1440         (mi_multi_location_breakpoint_output_fixed): New.
1441         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1442         (mi_cmd_fix_multi_location_breakpoint_output): New.
1443         (mi_multi_location_breakpoint_output_fixed): New.
1444         * mi/mi-cmds.c (mi_cmds): Register command
1445         -fix-multi-location-breakpoint-output.
1446         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1447         interpreter "mi".
1448
1449 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1450
1451         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1452         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1453         instantiate mi_ui_out based on interpreter name.
1454         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1455         * mi/mi-main.c (mi_load_progress): Likewise.
1456
1457 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1458
1459         * NEWS: Combine separate "New targets" sections for 8.3.
1460
1461 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1462
1463         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1464         (ppcfbsd_init_abi): Install gdbarch
1465         "fetch_tls_load_module_address" and "get_thread_local_address"
1466         methods.
1467
1468 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1469
1470         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1471         (riscv_fbsd_init_abi): Install gdbarch
1472         "fetch_tls_load_module_address" and "get_thread_local_address"
1473         methods.
1474
1475 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1476
1477         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1478         (i386fbsd_init_abi): Install gdbarch
1479         "fetch_tls_load_module_address" and "get_thread_local_address"
1480         methods.
1481
1482 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1483
1484         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1485         (amd64fbsd_init_abi): Install gdbarch
1486         "fetch_tls_load_module_address" and "get_thread_local_address"
1487         methods.
1488
1489 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1490
1491         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1492         (struct fbsd_pspace_data): New type.
1493         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1494         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1495         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1496         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1497         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1498
1499 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1500
1501         * gdbtypes.c (lookup_struct_elt): New function.
1502         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1503         * gdbtypes.h (struct struct_elt): New type.
1504         (lookup_struct_elt): New prototype.
1505
1506 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1507
1508         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1509         remove disabled code block.
1510
1511 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1512
1513         * gdbarch.sh (get_thread_local_address): New method.
1514         * gdbarch.h, gdbarch.c: Regenerate.
1515         * target.c (target_translate_tls_address): Use
1516         gdbarch_get_thread_local_address if present instead of
1517         target::get_thread_local_address.
1518
1519 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1520
1521         * target.h (target::get_thread_local_address): Update comment.
1522
1523 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1524
1525         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1526         objfile->separate_debug_objfile_backlink if not NULL.
1527
1528 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1529
1530         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1531         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1532         (amd64bsd_store_inferior_registers): Likewise.
1533         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1534         Enable segment base registers.
1535         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1536         PT_GETFSBASE and PT_GETGSBASE.
1537         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1538         PT_SETGSBASE.
1539         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1540         segment base registers.
1541         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1542
1543 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1544
1545         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1546         Update calls to i386_target_description to add 'segments'
1547         parameter.
1548         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1549         add segment base registers.
1550         * arch/i386.c (i386_create_target_description): Add 'segments'
1551         parameter to enable segment base registers.
1552         * arch/i386.h (i386_create_target_description): Likewise.
1553         * features/i386/32bit-segments.xml: New file.
1554         * features/i386/32bit-segments.c: Generate.
1555         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1556         call to i386_target_description to add 'segments' parameter.
1557         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1558         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1559         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1560         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1561         if feature is present.
1562         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1563         Add 'segments' parameter to call to i386_target_description.
1564         (i386_target_description): Add 'segments' parameter to enable
1565         segment base registers.
1566         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1567         to call to i386_target_description.
1568         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1569         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1570         Define I386_NUM_REGS.
1571         (i386_target_description): Add 'segments' parameter to enable
1572         segment base registers.
1573
1574 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1575
1576         PR/24325
1577         * source-cache.c: #undef open and close, to avoid unresolved
1578         externals during linking.
1579
1580 2019-03-12  Tom Tromey  <tromey@adacore.com>
1581
1582         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1583         const.  Add initializers.
1584         (_initialize_remote): Don't initialize ptid globals.
1585
1586 2019-03-12  Pedro Alves  <palves@redhat.com>
1587
1588         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1589
1590 2019-03-12  Pedro Alves  <palves@redhat.com>
1591
1592         * cp-name-parser.y (main): Remove unused 'len' variable.
1593
1594 2019-03-12  Tom Tromey  <tromey@adacore.com>
1595
1596         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1597         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1598
1599 2019-03-12  Tom Tromey  <tromey@adacore.com>
1600
1601         * linux-nat.c (iterate_over_lwps): Update.
1602         (stop_callback): Remove parameter.
1603         (stop_wait_callback, detach_callback, resume_set_callback)
1604         (select_singlestep_lwp_callback, set_ignore_sigint)
1605         (status_callback, resumed_callback, resume_clear_callback)
1606         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1607         data parameter.
1608         (linux_nat_target::detach, linux_nat_target::resume)
1609         (linux_stop_and_wait_all_lwps, select_event_lwp)
1610         (linux_nat_filter_event, linux_nat_wait_1)
1611         (linux_nat_target::kill, linux_nat_target::stop)
1612         (linux_nat_target::stop): Update.
1613         (linux_nat_resume_callback): Change type.
1614         (resume_stopped_resumed_lwps, count_events_callback)
1615         (select_event_lwp_callback): Likewise.
1616         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1617         * arm-linux-nat.c (struct update_registers_data): Remove.
1618         (update_registers_callback): Change type.
1619         (arm_linux_insert_hw_breakpoint1): Update.
1620         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1621         parameter.
1622         (x86_linux_dr_set_addr): Update.
1623         (x86_linux_dr_set_control): Update.
1624         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1625         (iterate_over_lwps): Use gdb::function_view.
1626         * nat/aarch64-linux-hw-point.c (struct
1627         aarch64_dr_update_callback_param): Remove.
1628         (debug_reg_change_callback): Change type.
1629         (aarch64_notify_debug_reg_change): Update.
1630         * s390-linux-nat.c (s390_refresh_per_info): Update.
1631
1632 2019-03-11  Tom Tromey  <tromey@adacore.com>
1633
1634         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1635         redundant assignment to "this_cu".
1636
1637 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1638
1639         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1640
1641 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1642
1643         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1644         from...
1645         (rank_one_type): ... this.
1646
1647 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1648
1649         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1650         from...
1651         (rank_one_type): ... this.
1652
1653 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1654
1655         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1656         from...
1657         (rank_one_type): ... this.
1658
1659 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1660
1661         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1662         from...
1663         (rank_one_type): ... this.
1664
1665 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1666
1667         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1668         from...
1669         (rank_one_type): ... this.
1670
1671 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1672
1673         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1674         from...
1675         (rank_one_type): ... this.
1676
1677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1678
1679         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1680         from...
1681         (rank_one_type): ... this.
1682
1683 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1684
1685         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1686         from...
1687         (rank_one_type): ... this.
1688
1689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1690
1691         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1692         from...
1693         (rank_one_type): ... this.
1694
1695 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1696
1697         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1698         from...
1699         (rank_one_type): ... this.
1700
1701 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1702
1703         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1704         from...
1705         (rank_one_type): ... this.
1706
1707 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1708
1709         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1710         from...
1711         (rank_one_type): ... this.
1712
1713 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1714
1715         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1716         inferior-events' shows the example events.
1717
1718 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1719
1720         Support styling on native MS-Windows console
1721
1722         PR/24315
1723         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1724         on MS-Windows if $TERM is not defined.
1725
1726         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1727
1728         * posix-hdep.c (gdb_console_fputs):
1729         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1730         functions.
1731         * ui-file.h (gdb_console_fputs): Add prototype.
1732
1733         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1734         back to fputs only if the former returns zero.
1735
1736 2019-03-07  Tom Tromey  <tom@tromey.com>
1737
1738         * symmisc.c (print_symbol_bcache_statistics): Update.
1739         (print_objfile_statistics): Update.
1740         * symfile.c (allocate_symtab): Update.
1741         * stabsread.c: Don't include bcache.h.
1742         * psymtab.h (struct psymbol_bcache): Don't declare.
1743         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1744         (psymbol_bcache_init, psymbol_bcache_free)
1745         (psymbol_bcache_get_bcache): Don't declare.
1746         * psymtab.c (struct psymbol_bcache): Remove.
1747         (psymtab_storage::psymtab_storage): Update.
1748         (psymtab_storage::~psymtab_storage): Update.
1749         (psymbol_bcache_init, psymbol_bcache_free)
1750         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1751         (add_psymbol_to_bcache): Update.
1752         (allocate_psymtab): Update.
1753         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1754         macro_cache>: No longer pointers.
1755         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1756         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1757         * macrotab.c (macro_bcache): Update.
1758         * macroexp.c: Don't include bcache.h.
1759         * gdbtypes.c (check_types_worklist): Update.
1760         (types_deeply_equal): Remove TRY/CATCH.  Update.
1761         * elfread.c (elf_symtab_read): Update.
1762         * dwarf2read.c: Don't include bcache.h.
1763         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1764         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1765         (print_bcache_statistics, bcache_memory_used): Don't declare.
1766         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1767         methods.  Rename all data members.
1768         * bcache.c (struct bcache): Move to bcache.h.
1769         (bcache::expand_hash_table): Rename from expand_hash_table.
1770         (bcache): Remove.
1771         (bcache::insert): Rename from bcache_full.
1772         (bcache::compare): Rename from bcache_compare.
1773         (bcache_xmalloc): Remove.
1774         (bcache::~bcache): Rename from bcache_xfree.
1775         (bcache::print_statistics): Rename from print_bcache_statistics.
1776         (bcache::memory_used): Rename from bcache_memory_used.
1777
1778 2019-03-07  Pedro Alves  <palves@redhat.com>
1779
1780         * infrun.c (normal_stop): Also check for
1781         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1782
1783 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1784
1785         * f-lang.c (value_from_host_double): Moved to...
1786         * value.c (value_from_host_double): ...here.
1787         * value.h (value_from_host_double): Declare.
1788         * guile/scm-math.c (vlscm_convert_typed_number): Use
1789         value_from_host_double.
1790         (vlscm_convert_number): Likewise.
1791         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1792         * python/py-value.c (convert_value_from_python): Likewise.
1793
1794 2019-03-06  Tom Tromey  <tom@tromey.com>
1795
1796         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1797
1798 2019-03-06  Tom Tromey  <tom@tromey.com>
1799
1800         * utils.h (free_current_contents): Don't declare.
1801         * utils.c (free_current_contents): Remove.
1802
1803 2019-03-06  Tom Tromey  <tom@tromey.com>
1804
1805         * top.c (quit_force): Update.
1806         * main.c (captured_command_loop): Update.
1807         * common/new-op.c (operator new): Update.
1808         * common/common-exceptions.c (struct catcher)
1809         <save_cleanup_chain>: Remove member.
1810         (exceptions_state_mc_init): Update.
1811         (exception_try_scope_entry): Return nullptr.
1812         (exception_try_scope_exit, exception_rethrow)
1813         (throw_exception_sjlj, throw_exception_cxx): Update.
1814         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1815         (all_cleanups, do_cleanups, discard_cleanups)
1816         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1817         (restore_cleanups, restore_final_cleanups): Don't declare.
1818         (do_final_cleanups): Remove parameter.
1819         * common/cleanups.c (cleanup_chain, make_cleanup)
1820         (make_cleanup_dtor, all_cleanups, do_cleanups)
1821         (discard_my_cleanups, discard_cleanups)
1822         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1823         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1824         (null_cleanup): Remove.
1825         (do_final_cleanups): Remove parameter.
1826
1827 2019-03-06  Tom Tromey  <tom@tromey.com>
1828
1829         * remote.c (remote_target::remote_parse_stop_reply): Use
1830         unique_xmalloc_ptr.
1831
1832 2019-03-06  Tom Tromey  <tom@tromey.com>
1833
1834         * stabsread.c (struct stabs_field_info): Rename from field_info.
1835         <list, fnlist>: Add initializers.
1836         <obstack>: New member.
1837         (read_member_functions, read_struct_fields, read_baseclasses):
1838         Allocate on obstack.  Don't use cleanups.
1839         (read_one_struct_field, read_member_functions, read_struct_fields)
1840         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1841         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1842         (read_struct_type): Update.
1843
1844 2019-03-06  Tom Tromey  <tom@tromey.com>
1845
1846         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1847         * common/filestuff.h (make_cleanup_close): Don't declare.
1848         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1849         Remove.
1850
1851 2019-03-06  Tom Tromey  <tom@tromey.com>
1852
1853         * solib-aix.c: Use make_scope_exit.
1854
1855 2019-03-06  Tom Tromey  <tom@tromey.com>
1856
1857         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1858         Use make_scope_exit.
1859
1860 2019-03-06  Tom Tromey  <tom@tromey.com>
1861
1862         * solib-svr4.c (disable_probes_interface): Remove parameter.
1863         (svr4_handle_solib_event): Use make_scope_exit.
1864
1865 2019-03-06  Tom Tromey  <tom@tromey.com>
1866
1867         * remote.c (struct stop_reply_deleter): Remove.
1868         (stop_reply_up): Update.
1869         (struct stop_reply): Derive from notif_event.  Don't typedef.
1870         <regcache>: Now a std::vector.
1871         (stop_reply_xfree): Remove.
1872         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1873         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1874         (remote_target::discard_pending_stop_replies): Use delete.
1875         (remote_target::remote_parse_stop_reply): Update.
1876         (remote_target::process_stop_reply): Update.
1877         * remote-notif.h (struct notif_event): Add virtual destructor.
1878         Remove "dtr" member.
1879         (struct notif_client) <alloc_event>: Return a unique_ptr.
1880         (notif_event_xfree): Don't declare.
1881         (notif_event_up): New typedef.
1882         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1883         (notif_event_xfree, do_notif_event_xfree): Remove.
1884         (remote_notif_state_xfree): Update.
1885
1886 2019-03-06  Tom Tromey  <tom@tromey.com>
1887
1888         * infrun.c (displaced_step_clear_cleanup): Now a
1889         forward_scope_exit type.
1890         (displaced_step_prepare_throw): Update.
1891         (displaced_step_fixup): Update.
1892
1893 2019-03-06  Tom Tromey  <tom@tromey.com>
1894
1895         * inferior.h (class inferior): Update comment.
1896         * gdbthread.h (class thread_info): Update comment.
1897
1898 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1899             Tom Tromey  <tom@tromey.com>
1900
1901         * stabsread.h (struct stab_section_list): Remove.
1902         (coffstab_build_psymtabs): Update.
1903         * dbxread.c (symbuf_sections): Now a std::vector.
1904         (sect_idx): New global.
1905         (fill_symbuf): Update.
1906         (coffstab_build_psymtabs): Change type of stabsects parameter.
1907         Update.
1908         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1909         std::vector.
1910         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1911         (coff_locate_sections): Update.
1912         (coff_symfile_read): Remove cleanups.  Update.
1913         (init_stringtab): Add storage parameter.
1914         (free_stringtab, free_stringtab_cleanup): Remove.
1915         (init_lineno): Add storage parameter.
1916         (free_linetab, free_linetab_cleanup): Remove.
1917
1918 2019-03-06  Pedro Alves  <palves@redhat.com>
1919
1920         * linux-fork.c (fork_info::clobber_regs): Delete.
1921         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1922         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1923         comment.  Adjust.
1924         (scoped_switch_fork_info::scoped_switch_fork_info)
1925         (checkpoint_command, linux_fork_context): Adjust
1926         fork_save_infrun_state calls.
1927
1928 2019-03-06  Pedro Alves  <palves@redhat.com>
1929
1930         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1931         (inf_has_multiple_threads): Return 'bool' and rewrite using
1932         inferior_info::threads().
1933
1934 2019-03-06  Pedro Alves  <palves@redhat.com>
1935
1936         * linux-fork.c: Include <list>.
1937         (fork_list): Now a std::list instance.
1938         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1939         (forks_exist_p, find_last_fork): Adjust.
1940         (new_fork): Delete.
1941         (one_fork_p): New.
1942         (add_fork): Adjust.
1943         (free_fork): Delete, folded into fork_info::~fork_info().
1944         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1945         Adjust.
1946         (init_fork_list): Delete.
1947         (linux_fork_killall, linux_fork_mourn_inferior)
1948         (linux_fork_detach, info_checkpoints_command): Adjust.
1949         (_initialize_linux_fork): No longer call init_fork_list.
1950
1951 2019-03-06  Pedro Alves  <palves@redhat.com>
1952
1953         * linux-fork.c (new_fork): New, split out of ...
1954         (add_fork): ... this.  Return void.  Move "first fork" special
1955         case from here, to ...
1956         (checkpoint_command): ... here.
1957         * linux-linux.h (add_fork): Return void.
1958
1959 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1960
1961         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1962
1963 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1964             Chris January  <chris.january@arm.com>
1965             David Lecomber  <david.lecomber@arm.com>
1966
1967         * f-exp.y: New token, UNOP_INTRINSIC.
1968         (exp): New pattern using UNOP_INTRINSIC token.
1969         (f77_keywords): Add 'abs' keyword.
1970         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1971         (value_from_host_double): New function.
1972         (evaluate_subexp_f): Support UNOP_ABS.
1973
1974 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1975
1976         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1977         types.
1978
1979 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1980
1981         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1982         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1983         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1984
1985 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1986
1987         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1988
1989 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1990             Chris January  <chris.january@arm.com>
1991
1992         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1993         * f-exp.y: Define 'KIND' token.
1994         (exp): New pattern for KIND expressions.
1995         (ptype): Handle types with a kind extension.
1996         (direct_abs_decl): Extend to spot kind extensions.
1997         (f77_keywords): Add 'kind' to the list.
1998         (push_kind_type): New function.
1999         (convert_to_kind_type): New function.
2000         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2001         * parse.c (operator_length_standard): Likewise.
2002         * parser-defs.h (enum type_pieces): Add tp_kind.
2003         * std-operator.def: Add UNOP_KIND.
2004
2005 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2006
2007         * f-exp.y (f_parse): Set yydebug.
2008
2009 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2010
2011         * f-lang.c (evaluate_subexp_f): New function.
2012         (exp_descriptor_f): New global.
2013         (f_language_defn): Use exp_descriptor_f instead of
2014         exp_descriptor_standard.
2015
2016 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2017
2018         * f-exp.y (struct token): Add comments.
2019         (dot_ops): Remove uppercase versions and the end marker.
2020         (f77_keywords): Likewise.
2021         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2022         entries in the dot_ops array are case insensitive, and use
2023         strncasecmp to compare strings.  Also some whitespace cleanup in
2024         this area.  Similar for the f77_keywords array, except entries in
2025         this list might be case sensitive.
2026
2027 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2028
2029         * f-exp.y (struct f77_boolean_val): Add comments.
2030         (boolean_values): Remove uppercase versions, and end marker.
2031         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2032         and use strncasecmp to achieve case insensitivity.  Additionally,
2033         perform whitespace cleanup around this code.
2034
2035 2019-03-06  Tom Tromey  <tromey@adacore.com>
2036
2037         * remote-sim.c (gdbsim_target_open): Use result of
2038         gdb_argv::release.
2039
2040 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2041         Dirk Schubert  <dirk.schubert@arm.com>
2042         Chris January  <chris.january@arm.com>
2043
2044         * eval.c (evaluate_subexp_standard): Call Fortran argument
2045         wrapping logic.
2046         * f-lang.c (struct value): A value which can be passed into a
2047         Fortran function call.
2048         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2049         where appropriate.
2050         (struct type): Value ready for a Fortran function call.
2051         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2052         is needed.
2053         * f-lang.h (fortran_argument_convert): Declaration.
2054         (fortran_preserve_arg_pointer): Declaration.
2055         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2056
2057 2019-03-05  Tom Tromey  <tromey@adacore.com>
2058
2059         * python/py-prettyprint.c (print_string_repr): Remove #if.
2060         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2061
2062 2019-03-05  Tom Tromey  <tromey@adacore.com>
2063
2064         * target.c (the_dummy_target): Move later.  Change type to
2065         "dummy_target".
2066         (initialize_targets): Don't initialize the_dummy_target.
2067
2068 2019-03-05  Tom Tromey  <tromey@adacore.com>
2069
2070         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2071         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2072
2073 2019-03-05  Tom Tromey  <tromey@adacore.com>
2074
2075         * windows-nat.c (windows_nat_target::attach)
2076         (windows_nat_target::detach): Don't call gdb_flush.
2077         * valprint.c (generic_val_print, val_print, val_print_string):
2078         Don't call gdb_flush.
2079         * utils.c (defaulted_query): Don't call gdb_flush.
2080         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2081         * target.c (target_announce_detach): Don't call gdb_flush.
2082         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2083         * remote.c (extended_remote_target::attach): Don't call
2084         gdb_flush.
2085         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2086         * printcmd.c (do_examine): Don't call gdb_flush.
2087         (info_display_command): Don't call gdb_flush.
2088         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2089         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2090         * memattr.c (info_mem_command): Don't call gdb_flush.
2091         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2092         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2093         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2094         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2095         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2096         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2097         (gnu_nat_target::detach): Don't call gdb_flush.
2098         * f-valprint.c (f_val_print): Don't call gdb_flush.
2099         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2100         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2101         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2102         gdb_flush.
2103         * c-valprint.c (c_val_print): Don't call gdb_flush.
2104         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2105
2106 2019-03-05  Tom Tromey  <tromey@adacore.com>
2107
2108         * varobj.c (update_dynamic_varobj_children): Update.
2109         (install_default_visualizer): Use reset, not release.
2110         * value.c (set_internalvar): Update.
2111         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2112         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2113         ATTRIBUTE_UNUSED_RESULT.
2114
2115 2019-03-05  Tom Tromey  <tromey@adacore.com>
2116
2117         * remote.c (class scoped_remote_fd) <release>: Add
2118         ATTRIBUTE_UNUSED_RESULT.
2119
2120 2019-03-05  Tom Tromey  <tromey@adacore.com>
2121
2122         * macroexp.c (struct macro_buffer) <release>: Add
2123         ATTRIBUTE_UNUSED_RESULT.
2124
2125 2019-03-05  Tom Tromey  <tromey@adacore.com>
2126
2127         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2128         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2129         ATTRIBUTE_UNUSED_RESULT.
2130
2131 2019-03-05  Tom Tromey  <tromey@adacore.com>
2132
2133         * common/scoped_fd.h (class scoped_fd) <release>: Add
2134         ATTRIBUTE_UNUSED_RESULT.
2135
2136 2019-03-05  Tom Tromey  <tromey@adacore.com>
2137
2138         * parser-defs.h (struct parser_state) <release>: Add
2139         ATTRIBUTE_UNUSED_RESULT.
2140
2141 2019-03-05  Tom Tromey  <tromey@adacore.com>
2142
2143         * utils.h (class gdb_argv) <release>: Add
2144         ATTRIBUTE_UNUSED_RESULT.
2145         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2146
2147 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2148
2149         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2150         for-loop range, to avoid compiler warnings.
2151
2152         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2153         avoid compiler warnings about unused variables.
2154
2155         * NEWS: Mention end of support for native debugging on MS-Windows
2156         before XP.
2157
2158         PR gdb/24292
2159         * common/netstuff.c:
2160         * gdbserver/gdbreplay.c
2161         * gdbserver/remote-utils.c:
2162         * ser-tcp.c:
2163         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2164         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2165         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2166         'getaddrinfo' and 'freeaddrinfo' were not available before
2167         Windows XP, and mingw.org's MinGW headers by default define
2168         _WIN32_WINNT to 0x500.
2169
2170 2019-03-01  Gary Benson <gbenson@redhat.com>
2171
2172         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2173
2174 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2175             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2176
2177         PR gdb/8527
2178         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2179         set_sigint_trap, clear_sigint_trap.
2180
2181 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2182
2183         * target.c (target_detach): Clear the regcache and the
2184         frame cache.
2185
2186 2019-02-27  Pedro Alves  <palves@redhat.com>
2187
2188         * utils.c (set_screen_size): When we cap the height/width sizes,
2189         tweak the corresponding command variable to show "unlimited":
2190
2191 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2192             Pedro Alves  <palves@redhat.com>
2193
2194         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2195         before calling rl_set_screen_size.
2196
2197 2019-02-27  Tom Tromey  <tromey@adacore.com>
2198
2199         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2200         define.
2201         * python/py-value.c: Remove Python 2.4 workaround.
2202         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2203         workaround.
2204         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2205         Python 2.4 workaround.
2206         * python/python-internal.h: Remove Python 2.4 comment.
2207         (Py_ssize_t): Don't define.
2208         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2209         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2210         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2211         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2212         * python/python.c (do_start_initialization): Remove Python 2.4
2213         workaround.
2214         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2215         (print_children): Remove Python 2.4 workaround.
2216         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2217         workaround.
2218         (CHARBUFFERPROC_NAME): Remove.
2219         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2220         Python 2.4 workaround.
2221
2222 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2223
2224         * NEWS: Note minimum Python version.
2225
2226 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2227
2228         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2229         code from these functions.  Remove corresponding ifdefs.  Use
2230         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2231         Remove gotos and target of gotos.
2232         (infpy_search_memory): Likewise.
2233
2234 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2235
2236         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2237         (hppa_gdbarch_init): Don't register deleted functions with
2238         gdbarch.
2239
2240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2241
2242         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2243         (h8300_unwind_sp): Delete.
2244         (h8300_dummy_id): Delete.
2245         (h8300_gdbarch_init): Don't register deleted functions with
2246         gdbarch.
2247
2248 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2249
2250         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2251         (ft32_unwind_pc): Delete.
2252         (ft32_unwind_sp): Delete.
2253         (ft32_gdbarch_init): Don't register deleted functions with
2254         gdbarch.
2255
2256 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2257
2258         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2259         (frv_unwind_pc): Delete.
2260         (frv_unwind_sp): Delete.
2261         (frv_gdbarch_init): Don't register deleted functions with
2262         gdbarch.
2263
2264 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2265
2266         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2267         (riscv_unwind_pc): Delete.
2268         (riscv_unwind_sp): Delete.
2269         (riscv_gdbarch_init): Don't register deleted functions with
2270         gdbarch.
2271
2272 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2273
2274         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2275         (csky_unwind_pc): Delete.
2276         (csky_unwind_sp): Delete.
2277         (csky_gdbarch_init): Don't register deleted functions with
2278         gdbarch.
2279
2280 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2283         (cris_unwind_pc): Delete.
2284         (cris_unwind_sp): Delete.
2285         (cris_gdbarch_init): Don't register deleted functions with
2286         gdbarch.
2287
2288 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2291         (bfin_unwind_pc): Delete.
2292         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2293
2294 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2295
2296         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2297         (arm_unwind_pc): Delete.
2298         (arm_unwind_sp): Delete.
2299         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2300
2301 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2302
2303         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2304         (arc_unwind_pc): Delete.
2305         (arc_unwind_sp): Delete.
2306         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2307
2308 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2309
2310         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2311         (alpha_unwind_pc): Delete.
2312         (alpha_gdbarch_init): Don't register deleted functions with
2313         gdbarch.
2314
2315 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2318         (aarch64_unwind_pc): Delete.
2319         (aarch64_unwind_sp): Delete.
2320         (aarch64_gdbarch_init): Don't register deleted functions with
2321         gdbarch.
2322
2323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * gdbtypes.c (type_align): Don't consider static members when
2326         computing structure alignment.
2327
2328 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2329
2330         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2331         return 0 for other types.
2332         * arch-utils.c (default_type_align): Always return 0.
2333         * gdbarch.h: Regenerate.
2334         * gdbarch.sh (type_align): Extend comment.
2335         * gdbtypes.c (type_align): Add additional comments, always call
2336         gdbarch_type_align before applying the default rules.
2337         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2338         generic code will then apply a suitable default.
2339         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2340         types, return 0 for other types.
2341
2342 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2343
2344         * NEWS: Create a new section for the next release branch.
2345         Rename the section of the current branch, now that it has
2346         been cut.
2347
2348 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2349
2350         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2351         * version.in: Bump version to 8.3.50.DATE-git.
2352
2353 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2354
2355         * aix-thread.c (ptid_cmp): Remove unused variable.
2356         (get_signaled_thread): Likewise.
2357         (store_regs_user_thread): Likewise.
2358         (store_regs_kernel_thread): Likewise.
2359         (fetch_regs_kernel_thread): Remove shadowed variable.
2360
2361 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2362
2363         * features/riscv/32bit-cpu.xml: Add register numbers.
2364         * features/riscv/32bit-fpu.c: Regenerate.
2365         * features/riscv/32bit-fpu.xml: Add register numbers.
2366         * features/riscv/64bit-cpu.xml: Add register numbers.
2367         * features/riscv/64bit-fpu.c: Regenerate.
2368         * features/riscv/64bit-fpu.xml: Add register numbers.
2369
2370 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2371
2372         * NEWS: Mention two argument form of gdb.Value constructor.
2373         * python/py-value.c (convert_buffer_and_type_to_value): New
2374         function.
2375         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2376         Add support for handling an optional second argument.  Call
2377         convert_buffer_and_type_to_value as appropriate.
2378         * python/python-internal.h (Py_buffer_deleter): New struct.
2379         (Py_buffer_up): New typedef.
2380
2381 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2382
2383         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2384         instead of releasing ownership.
2385
2386 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2387
2388         * dwarf2read.c (open_and_init_dwp_file): Call
2389         elf_numsections instead of bfd_count_sections to initialize
2390         dwp_file->num_sections.
2391
2392 2019-02-25  Tom Tromey  <tromey@adacore.com>
2393
2394         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2395
2396 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2397
2398         * gcore.in: Add '--readnever' option when invoking GDB.
2399
2400 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2401
2402         * MAINTAINERS: Update my email address.
2403
2404 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2405
2406         * build-id.c (build_id_to_debug_bfd_1): New function.
2407         (build_id_to_debug_bfd): Look for separate debug file in
2408         sysroot.
2409
2410 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2411
2412         * gdbarch.sh: Update the copyright year range that is placed into
2413         generated files.
2414
2415 2019-02-22  Keith Seitz  <keiths@redhat.com>
2416
2417         PR symtab/23853
2418         * linespec.c (create_sals_line_offset): Search for the default
2419         symtab's filename instead of its fullname.
2420
2421 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2422
2423         * NEWS: Update style defaults.
2424
2425 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2426
2427         * main.c (captured_main_1): Disable styling in batch mode.
2428
2429 2019-02-20  Tom Tromey  <tom@tromey.com>
2430
2431         * symtab.c (symtab_symbol_info): Fix typos.
2432
2433 2019-02-20  Tom Tromey  <tromey@adacore.com>
2434
2435         * findcmd.c (_initialize_mem_search): Use upper case for
2436         metasyntactic variables.
2437
2438 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2439
2440         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2441         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2442
2443 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2444
2445         * top.h (source_file_name): Change to std::string.
2446         * top.c (source_file_name): Likewise.
2447         (command_line_input): Adjust.
2448         * cli/cli-script.c (script_from_file): Adjust.
2449
2450 2019-02-19  Tom Tromey  <tromey@adacore.com>
2451
2452         * ravenscar-thread.c
2453         (ravenscar_thread_target::update_thread_list): Don't call
2454         ada_build_task_list.
2455         * ada-lang.h (ada_build_task_list): Don't declare.
2456         * ada-tasks.c (struct ada_tasks_inferior_data)
2457         <task_list_valid_p>: Now bool.
2458         (read_known_tasks, ada_task_list_changed)
2459         (ada_tasks_invalidate_inferior_data): Update.
2460         (read_known_tasks_array): Return bool.
2461         (read_known_tasks_list): Likewise.
2462         (read_known_tasks): Return void.
2463         (ada_build_task_list): Now static.
2464
2465 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2466
2467         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2468         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2469
2470 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2471
2472         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2473         variant for ada_tasks_pspace_data_handle and
2474         ada_tasks_inferior_data_handle.
2475         (ada_tasks_pspace_data_cleanup): New function.
2476         (ada_tasks_inferior_data_cleanup): New function.
2477
2478 2019-02-17  Tom Tromey  <tom@tromey.com>
2479
2480         * macrotab.h (macro_source_fullname): Return a std::string.
2481         * macrotab.c (macro_include, check_for_redefinition)
2482         (macro_undef, macro_lookup_definition, foreach_macro)
2483         (foreach_macro_in_scope): Update.
2484         (macro_source_fullname): Return a std::string.
2485         * macrocmd.c (show_pp_source_pos): Update.
2486
2487 2019-02-17  Tom Tromey  <tom@tromey.com>
2488
2489         * macrocmd.c (show_pp_source_pos): Style the file names.
2490
2491 2019-02-17  Tom Tromey  <tom@tromey.com>
2492
2493         PR tui/24197:
2494         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2495
2496 2019-02-17  Tom Tromey  <tom@tromey.com>
2497
2498         * ada-lang.c (user_select_syms): Use filtered printing.
2499         * utils.c (wrap_style): New global.
2500         (desired_style): Remove.
2501         (emit_style_escape): Add stream parameter.
2502         (set_output_style, reset_terminal_style, prompt_for_continue):
2503         Update.
2504         (flush_wrap_buffer): Only flush gdb_stdout.
2505         (wrap_here): Set wrap_style.
2506         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2507         treat escape sequences as a character.  Change when wrap buffer is
2508         flushed.
2509         (fputs_styled): Do not set the output style when the default is
2510         requested.
2511         * ui-style.h (struct ui_file_style) <is_default>: New method.
2512         * source.c (print_source_lines_base): Emit escape sequences in one
2513         piece.
2514
2515 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2516
2517         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2518         integers and enumeration types.
2519
2520 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2521
2522         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2523         instead of lookup_symbol_in_language
2524         (do_exact_match): New function.
2525         (ada_get_symbol_name_matcher): Return do_exact_match when
2526         doing a verbatim match.
2527
2528 2019-02-15  Tom Tromey  <tromey@adacore.com>
2529
2530         * ravenscar-thread.c (ravenscar_thread_target::resume)
2531         (ravenscar_thread_target::wait): Special case wildcard requests.
2532
2533 2019-02-15  Tom Tromey  <tromey@adacore.com>
2534
2535         * ravenscar-thread.c (base_ptid): Remove.
2536         (struct ravenscar_thread_target) <close>: New method.
2537         <m_base_ptid>: New member.
2538         <update_inferior_ptid, active_task, task_is_currently_active,
2539         runtime_initialized>: Declare methods.
2540         <ravenscar_thread_target>: Add constructor.
2541         (ravenscar_thread_target::task_is_currently_active)
2542         (ravenscar_thread_target::update_inferior_ptid)
2543         (ravenscar_runtime_initialized): Rename.  Now methods.
2544         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2545         (ravenscar_thread_target::update_thread_list): Update.
2546         (ravenscar_thread_target::active_task): Now method.
2547         (ravenscar_thread_target::store_registers)
2548         (ravenscar_thread_target::prepare_to_store)
2549         (ravenscar_thread_target::prepare_to_store)
2550         (ravenscar_thread_target::mourn_inferior): Update.
2551         (ravenscar_inferior_created): Use "new" to create target.
2552         (ravenscar_thread_target::get_ada_task_ptid): Update.
2553         (_initialize_ravenscar): Don't initialize base_ptid.
2554         (ravenscar_ops): Remove global.
2555
2556 2019-02-15  Tom Tromey  <tromey@adacore.com>
2557
2558         * target.h (push_target): Declare new overload.
2559         * target.c (push_target): New overload, taking an rvalue reference.
2560         * remote.c (remote_target::open_1): Use push_target overload.
2561         * corelow.c (core_target_open): Use push_target overload.
2562
2563 2019-02-15  Tom Tromey  <tromey@adacore.com>
2564
2565         * ravenscar-thread.c (is_ravenscar_task)
2566         (ravenscar_task_is_currently_active): Return bool.
2567         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2568         (_initialize_ravenscar): Remove "(void)".
2569         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2570         Return bool.
2571
2572 2019-02-15  Tom Tromey  <tromey@adacore.com>
2573
2574         * ravenscar-thread.c (ravenscar_runtime_initializer)
2575         (has_ravenscar_runtime, get_running_thread_id)
2576         (ravenscar_thread_target::resume): Fix indentation.
2577
2578 2019-02-15  Tom Tromey  <tromey@adacore.com>
2579
2580         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2581         from ravenscar_arch_ops.
2582         (sparc_ravenscar_ops::fetch_registers)
2583         (sparc_ravenscar_ops::store_registers): Now methods.
2584         (sparc_ravenscar_prepare_to_store): Remove.
2585         (sparc_ravenscar_ops): Redefine.
2586         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2587         methods and destructor.  Remove members.
2588         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2589         (ravenscar_thread_target::store_registers)
2590         (ravenscar_thread_target::prepare_to_store): Update.
2591         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2592         Remove.
2593         (struct ppc_ravenscar_powerpc_ops): Derive from
2594         ravenscar_arch_ops.
2595         (ppc_ravenscar_powerpc_ops::fetch_registers)
2596         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2597         (ppc_ravenscar_powerpc_ops): Redefine.
2598         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2599         (ppc_ravenscar_e500_ops::fetch_registers)
2600         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2601         (ppc_ravenscar_e500_ops): Redefine.
2602         * aarch64-ravenscar-thread.c
2603         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2604         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2605         (aarch64_ravenscar_fetch_registers)
2606         (aarch64_ravenscar_store_registers): Now methods.
2607         (aarch64_ravenscar_ops): Redefine.
2608
2609 2019-02-15  Tom Tromey  <tromey@adacore.com>
2610
2611         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2612         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2613         (ravenscar_thread_target::stopped_by_watchpoint)
2614         (ravenscar_thread_target::stopped_data_address)
2615         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2616
2617 2019-02-15  Tom Tromey  <tromey@adacore.com>
2618
2619         * ravenscar-thread.c: Fix some typos.
2620
2621 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2622             Tom Tromey  <tromey@adacore.com>
2623
2624         * ada-lang.c (ada_exception_sal): Change addr_string to a
2625         std::string.
2626         (create_ada_exception_catchpoint): Update.
2627
2628 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2629             Tom Tromey  <tromey@adacore.com>
2630
2631         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2632         (bp_location_ops): Remove.
2633         (base_breakpoint_allocate_location): Update.
2634         (free_bp_location): Update.
2635         * ada-lang.c (class ada_catchpoint_location)
2636         <ada_catchpoint_location>: Remove ops parameter.
2637         (ada_catchpoint_location_dtor): Remove.
2638         (ada_catchpoint_location_ops): Remove.
2639         (allocate_location_exception): Update.
2640         * breakpoint.h (struct bp_location_ops): Remove.
2641         (class bp_location) <bp_location>: Remove bp_location_ops
2642         parameter.
2643         <~bp_location>: Add destructor.
2644         <ops>: Remove.
2645
2646 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2647             Pedro Alves  <palves@redhat.com>
2648
2649         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2650         'PATH_MAX'.
2651
2652 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2653             Samuel Thibault  <samuel.thibault@gnu.org>
2654             Thomas Schwinge  <thomas@codesourcery.com>
2655
2656         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2657         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2658
2659 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2660
2661         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2662         (check_empty): Use "const char *".
2663
2664         * gnu-nat.c (gnu_nat_target::detach): Instead of
2665         'detach_inferior (pid)' call
2666         'detach_inferior (find_inferior_pid (pid))'.
2667
2668         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2669         'nat/fork-inferior.o'.
2670         * gnu-nat.c: #include "nat/fork-inferior.h".
2671
2672         * gnu-nat.c (gnu_nat_target::detach): Instead of
2673         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2674         * gnu-nat.h: #include "inf-child.h".
2675         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2676         'i386_gnu_nat_target::fetch_registers'.
2677         (gnu_store_registers): Rename/move to
2678         'i386_gnu_nat_target::store_registers'.
2679
2680         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2681         * gnu-nat.h (mach_thread_info): New function.
2682         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2683
2684         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2685
2686 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2687
2688         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2689
2690 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2691
2692         * windows-nat.c (windows_add_thread): Add new parameter
2693         "main_thread_p" with default value set to false.  Update
2694         function documentation as well as all callers.
2695         (windows_delete_thread): Likewise.
2696         (fake_create_process): Update call to windows_add_thread.
2697         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2698         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2699         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2700         call to windows_delete_thread.
2701
2702 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2703
2704         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2705
2706 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2707
2708         * symfile.c (find_separate_debug_file): Use canonical path of
2709         sysroot with child_path instead of gdb_sysroot if it is valid.
2710
2711 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2712
2713         * symfile.c (find_separate_debug_file): Use child_path to
2714         determine if an object file is under a sysroot.
2715
2716 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2717
2718         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2719         unittests/child-path-selftests.c.
2720         * common/pathstuff.c (child_path): New function.
2721         * common/pathstuff.h (child_path): New prototype.
2722         * unittests/child-path-selftests.c: New file.
2723
2724 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2725
2726         * symfile.c (find_separate_debug_file): Look for separate debug
2727         files in debug directories under the sysroot.
2728
2729 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2730
2731         * symtab.h (struct minimal_symbol data_p): New const method.
2732         (struct minimal_symbol text_p): Likewise.
2733         * symtab.c (output_source_filename): Use file name style
2734         to print file name.
2735         (print_symbol_info): Likewise.
2736         (print_msymbol_info): Use address style to print addresses.
2737         Use function name style to print executable text symbols.
2738         (expand_symtab_containing_pc): Use data_p.
2739         (find_pc_sect_compunit_symtab): Likewise.
2740
2741 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2742
2743         * breakpoint.c (describe_other_breakpoints): Use address style
2744         to print addresses.
2745         (say_where): Likewise.
2746
2747 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2748
2749         * ada-typeprint.c (print_func_type): Print function name
2750         style to print function name.
2751         * c-typeprint.c (c_print_type_1): Likewise.
2752
2753 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2754
2755         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2756         for execve.
2757
2758 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2759
2760         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2761         type_stack.
2762
2763 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2764
2765         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2766         TYPE_CODE_REF types.
2767
2768 2019-02-08  Jim Wilson  <jimw@sifive.com>
2769
2770         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2771         (riscv_linux_fregset): New.
2772         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2773
2774 2019-02-07  Tom Tromey  <tom@tromey.com>
2775
2776         * thread.c (thread_cancel_execution_command): Update.
2777         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2778         methods.
2779         (struct thread_fsm_ops): Remove.
2780         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2781         (thread_fsm_should_stop, thread_fsm_return_value)
2782         (thread_fsm_set_finished, thread_fsm_finished_p)
2783         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2784         Don't declare.
2785         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2786         * infrun.c (clear_proceed_status_thread)
2787         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2788         (print_stop_event): Update.
2789         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2790         Add constructor.
2791         (step_command_fsm_ops): Remove.
2792         (new_step_command_fsm): Remove.
2793         (step_1): Update.
2794         (step_command_fsm::should_stop): Rename from
2795         step_command_fsm_should_stop.
2796         (step_command_fsm::clean_up): Rename from
2797         step_command_fsm_clean_up.
2798         (step_command_fsm::do_async_reply_reason): Rename from
2799         step_command_fsm_async_reply_reason.
2800         (struct until_next_fsm): Inherit from thread_fsm.  Add
2801         constructor.
2802         (until_next_fsm_ops): Remove.
2803         (new_until_next_fsm): Remove.
2804         (until_next_fsm::should_stop): Rename from
2805         until_next_fsm_should_stop.
2806         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2807         (until_next_fsm::do_async_reply_reason): Rename from
2808         until_next_fsm_async_reply_reason.
2809         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2810         constructor.  Change type of breakpoint.
2811         (finish_command_fsm_ops): Remove.
2812         (new_finish_command_fsm): Remove.
2813         (finish_command_fsm::should_stop): Rename from
2814         finish_command_fsm_should_stop.
2815         (finish_command_fsm::clean_up): Rename from
2816         finish_command_fsm_clean_up.
2817         (finish_command_fsm::return_value): Rename from
2818         finish_command_fsm_return_value.
2819         (finish_command_fsm::do_async_reply_reason): Rename from
2820         finish_command_fsm_async_reply_reason.
2821         (finish_command): Update.
2822         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2823         Add constructor.
2824         (call_thread_fsm_ops): Remove.
2825         (call_thread_fsm::call_thread_fsm): Rename from
2826         new_call_thread_fsm.
2827         (call_thread_fsm::should_stop): Rename from
2828         call_thread_fsm_should_stop.
2829         (call_thread_fsm::should_notify_stop): Rename from
2830         call_thread_fsm_should_notify_stop.
2831         (run_inferior_call, call_function_by_hand_dummy): Update.
2832         * cli/cli-interp.c (should_print_stop_to_console): Update.
2833         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2834         Add constructor.  Change type of location_breakpoint,
2835         caller_breakpoint.
2836         (until_break_fsm_ops): Remove.
2837         (new_until_break_fsm): Remove.
2838         (until_break_fsm::should_stop): Rename from
2839         until_break_fsm_should_stop.
2840         (until_break_fsm::clean_up): Rename from
2841         until_break_fsm_clean_up.
2842         (until_break_fsm::do_async_reply_reason): Rename from
2843         until_break_fsm_async_reply_reason.
2844         (until_break_command): Update.
2845         * thread-fsm.c: Remove.
2846         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2847
2848 2019-02-07  Tom Tromey  <tom@tromey.com>
2849
2850         * yy-remap.h: Add include guard.
2851         * xtensa-tdep.h: Add include guard.
2852         * xcoffread.h: Rename include guard.
2853         * varobj-iter.h: Add include guard.
2854         * tui/tui.h: Rename include guard.
2855         * tui/tui-winsource.h: Rename include guard.
2856         * tui/tui-wingeneral.h: Rename include guard.
2857         * tui/tui-windata.h: Rename include guard.
2858         * tui/tui-win.h: Rename include guard.
2859         * tui/tui-stack.h: Rename include guard.
2860         * tui/tui-source.h: Rename include guard.
2861         * tui/tui-regs.h: Rename include guard.
2862         * tui/tui-out.h: Rename include guard.
2863         * tui/tui-layout.h: Rename include guard.
2864         * tui/tui-io.h: Rename include guard.
2865         * tui/tui-hooks.h: Rename include guard.
2866         * tui/tui-file.h: Rename include guard.
2867         * tui/tui-disasm.h: Rename include guard.
2868         * tui/tui-data.h: Rename include guard.
2869         * tui/tui-command.h: Rename include guard.
2870         * tic6x-tdep.h: Add include guard.
2871         * target/waitstatus.h: Rename include guard.
2872         * target/wait.h: Rename include guard.
2873         * target/target.h: Rename include guard.
2874         * target/resume.h: Rename include guard.
2875         * target-float.h: Rename include guard.
2876         * stabsread.h: Add include guard.
2877         * rs6000-tdep.h: Add include guard.
2878         * riscv-fbsd-tdep.h: Add include guard.
2879         * regformats/regdef.h: Rename include guard.
2880         * record.h: Rename include guard.
2881         * python/python.h: Rename include guard.
2882         * python/python-internal.h: Rename include guard.
2883         * python/py-stopevent.h: Rename include guard.
2884         * python/py-ref.h: Rename include guard.
2885         * python/py-record.h: Rename include guard.
2886         * python/py-record-full.h: Rename include guard.
2887         * python/py-record-btrace.h: Rename include guard.
2888         * python/py-instruction.h: Rename include guard.
2889         * python/py-events.h: Rename include guard.
2890         * python/py-event.h: Rename include guard.
2891         * procfs.h: Add include guard.
2892         * proc-utils.h: Add include guard.
2893         * p-lang.h: Add include guard.
2894         * or1k-tdep.h: Rename include guard.
2895         * observable.h: Rename include guard.
2896         * nto-tdep.h: Rename include guard.
2897         * nat/x86-linux.h: Rename include guard.
2898         * nat/x86-linux-dregs.h: Rename include guard.
2899         * nat/x86-gcc-cpuid.h: Add include guard.
2900         * nat/x86-dregs.h: Rename include guard.
2901         * nat/x86-cpuid.h: Rename include guard.
2902         * nat/ppc-linux.h: Rename include guard.
2903         * nat/mips-linux-watch.h: Rename include guard.
2904         * nat/linux-waitpid.h: Rename include guard.
2905         * nat/linux-ptrace.h: Rename include guard.
2906         * nat/linux-procfs.h: Rename include guard.
2907         * nat/linux-osdata.h: Rename include guard.
2908         * nat/linux-nat.h: Rename include guard.
2909         * nat/linux-namespaces.h: Rename include guard.
2910         * nat/linux-btrace.h: Rename include guard.
2911         * nat/glibc_thread_db.h: Rename include guard.
2912         * nat/gdb_thread_db.h: Rename include guard.
2913         * nat/gdb_ptrace.h: Rename include guard.
2914         * nat/fork-inferior.h: Rename include guard.
2915         * nat/amd64-linux-siginfo.h: Rename include guard.
2916         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2917         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2918         * nat/aarch64-linux.h: Rename include guard.
2919         * nat/aarch64-linux-hw-point.h: Rename include guard.
2920         * mn10300-tdep.h: Add include guard.
2921         * mips-linux-tdep.h: Add include guard.
2922         * mi/mi-parse.h: Rename include guard.
2923         * mi/mi-out.h: Rename include guard.
2924         * mi/mi-main.h: Rename include guard.
2925         * mi/mi-interp.h: Rename include guard.
2926         * mi/mi-getopt.h: Rename include guard.
2927         * mi/mi-console.h: Rename include guard.
2928         * mi/mi-common.h: Rename include guard.
2929         * mi/mi-cmds.h: Rename include guard.
2930         * mi/mi-cmd-break.h: Rename include guard.
2931         * m2-lang.h: Add include guard.
2932         * location.h: Rename include guard.
2933         * linux-record.h: Rename include guard.
2934         * linux-nat.h: Add include guard.
2935         * linux-fork.h: Add include guard.
2936         * i386-darwin-tdep.h: Rename include guard.
2937         * hppa-linux-offsets.h: Add include guard.
2938         * guile/guile.h: Rename include guard.
2939         * guile/guile-internal.h: Rename include guard.
2940         * gnu-nat.h: Rename include guard.
2941         * gdb-stabs.h: Rename include guard.
2942         * frv-tdep.h: Add include guard.
2943         * f-lang.h: Add include guard.
2944         * event-loop.h: Add include guard.
2945         * darwin-nat.h: Rename include guard.
2946         * cp-abi.h: Rename include guard.
2947         * config/sparc/nm-sol2.h: Rename include guard.
2948         * config/nm-nto.h: Rename include guard.
2949         * config/nm-linux.h: Add include guard.
2950         * config/i386/nm-i386gnu.h: Rename include guard.
2951         * config/djgpp/nl_types.h: Rename include guard.
2952         * config/djgpp/langinfo.h: Rename include guard.
2953         * compile/gcc-cp-plugin.h: Add include guard.
2954         * compile/gcc-c-plugin.h: Add include guard.
2955         * compile/compile.h: Rename include guard.
2956         * compile/compile-object-run.h: Rename include guard.
2957         * compile/compile-object-load.h: Rename include guard.
2958         * compile/compile-internal.h: Rename include guard.
2959         * compile/compile-cplus.h: Rename include guard.
2960         * compile/compile-c.h: Rename include guard.
2961         * common/xml-utils.h: Rename include guard.
2962         * common/x86-xstate.h: Rename include guard.
2963         * common/version.h: Rename include guard.
2964         * common/vec.h: Rename include guard.
2965         * common/tdesc.h: Rename include guard.
2966         * common/selftest.h: Rename include guard.
2967         * common/scoped_restore.h: Rename include guard.
2968         * common/scoped_mmap.h: Rename include guard.
2969         * common/scoped_fd.h: Rename include guard.
2970         * common/safe-iterator.h: Rename include guard.
2971         * common/run-time-clock.h: Rename include guard.
2972         * common/refcounted-object.h: Rename include guard.
2973         * common/queue.h: Rename include guard.
2974         * common/ptid.h: Rename include guard.
2975         * common/print-utils.h: Rename include guard.
2976         * common/preprocessor.h: Rename include guard.
2977         * common/pathstuff.h: Rename include guard.
2978         * common/observable.h: Rename include guard.
2979         * common/netstuff.h: Rename include guard.
2980         * common/job-control.h: Rename include guard.
2981         * common/host-defs.h: Rename include guard.
2982         * common/gdb_wait.h: Rename include guard.
2983         * common/gdb_vecs.h: Rename include guard.
2984         * common/gdb_unlinker.h: Rename include guard.
2985         * common/gdb_unique_ptr.h: Rename include guard.
2986         * common/gdb_tilde_expand.h: Rename include guard.
2987         * common/gdb_sys_time.h: Rename include guard.
2988         * common/gdb_string_view.h: Rename include guard.
2989         * common/gdb_splay_tree.h: Rename include guard.
2990         * common/gdb_setjmp.h: Rename include guard.
2991         * common/gdb_ref_ptr.h: Rename include guard.
2992         * common/gdb_optional.h: Rename include guard.
2993         * common/gdb_locale.h: Rename include guard.
2994         * common/gdb_assert.h: Rename include guard.
2995         * common/filtered-iterator.h: Rename include guard.
2996         * common/filestuff.h: Rename include guard.
2997         * common/fileio.h: Rename include guard.
2998         * common/environ.h: Rename include guard.
2999         * common/common-utils.h: Rename include guard.
3000         * common/common-types.h: Rename include guard.
3001         * common/common-regcache.h: Rename include guard.
3002         * common/common-inferior.h: Rename include guard.
3003         * common/common-gdbthread.h: Rename include guard.
3004         * common/common-exceptions.h: Rename include guard.
3005         * common/common-defs.h: Rename include guard.
3006         * common/common-debug.h: Rename include guard.
3007         * common/cleanups.h: Rename include guard.
3008         * common/buffer.h: Rename include guard.
3009         * common/btrace-common.h: Rename include guard.
3010         * common/break-common.h: Rename include guard.
3011         * cli/cli-utils.h: Rename include guard.
3012         * cli/cli-style.h: Rename include guard.
3013         * cli/cli-setshow.h: Rename include guard.
3014         * cli/cli-script.h: Rename include guard.
3015         * cli/cli-interp.h: Rename include guard.
3016         * cli/cli-decode.h: Rename include guard.
3017         * cli/cli-cmds.h: Rename include guard.
3018         * charset-list.h: Add include guard.
3019         * buildsym-legacy.h: Rename include guard.
3020         * bfin-tdep.h: Add include guard.
3021         * ax.h: Rename include guard.
3022         * arm-linux-tdep.h: Add include guard.
3023         * arm-fbsd-tdep.h: Add include guard.
3024         * arch/xtensa.h: Rename include guard.
3025         * arch/tic6x.h: Add include guard.
3026         * arch/i386.h: Add include guard.
3027         * arch/arm.h: Rename include guard.
3028         * arch/arm-linux.h: Rename include guard.
3029         * arch/arm-get-next-pcs.h: Rename include guard.
3030         * arch/amd64.h: Add include guard.
3031         * arch/aarch64-insn.h: Rename include guard.
3032         * arch-utils.h: Rename include guard.
3033         * annotate.h: Add include guard.
3034         * amd64-darwin-tdep.h: Rename include guard.
3035         * aarch64-linux-tdep.h: Add include guard.
3036         * aarch64-fbsd-tdep.h: Add include guard.
3037         * aarch32-linux-nat.h: Add include guard.
3038
3039 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3040
3041         * macrotab.c (macro_define_internal): New function that
3042         factorizes macro_define_object_internal and macro_define_function
3043         code.
3044         (macro_define_object_internal): Use macro_define_internal.
3045         (macro_define_function): Likewise.
3046
3047 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3048
3049         * macrocmd.c (extract_identifier): Return
3050         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3051         callers.
3052
3053 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3054
3055         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3056
3057 2019-02-05  Tom Tromey  <tom@tromey.com>
3058
3059         * target.c (target_stack::unpush): Move assertion earlier.
3060
3061 2019-01-30  Tom Tromey  <tom@tromey.com>
3062
3063         PR python/23615:
3064         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3065         (gdbpy_parse_and_eval): Likewise.
3066         * python/python-internal.h (gdbpy_allow_threads): New class.
3067
3068 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3069
3070         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3071         (aarch64_fbsd_fpregmap): Move earlier.
3072         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3073         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3074         instead of individual calls to trad_frame_set_reg_addr.
3075         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3076         earlier.
3077         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3078         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3079         instead of individual calls to trad_frame_set_reg_addr.
3080
3081 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3082
3083         * CONTRIBUTE: Replace contribution list with wiki link.
3084
3085 2019-01-25  Tom Tromey  <tom@tromey.com>
3086
3087         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3088
3089 2019-01-25  Tom Tromey  <tom@tromey.com>
3090
3091         * xtensa-linux-nat.c: Fix common/ includes.
3092         * xml-support.h: Fix common/ includes.
3093         * xml-support.c: Fix common/ includes.
3094         * x86-linux-nat.c: Fix common/ includes.
3095         * windows-nat.c: Fix common/ includes.
3096         * varobj.h: Fix common/ includes.
3097         * varobj.c: Fix common/ includes.
3098         * value.c: Fix common/ includes.
3099         * valops.c: Fix common/ includes.
3100         * utils.c: Fix common/ includes.
3101         * unittests/xml-utils-selftests.c: Fix common/ includes.
3102         * unittests/utils-selftests.c: Fix common/ includes.
3103         * unittests/unpack-selftests.c: Fix common/ includes.
3104         * unittests/tracepoint-selftests.c: Fix common/ includes.
3105         * unittests/style-selftests.c: Fix common/ includes.
3106         * unittests/string_view-selftests.c: Fix common/ includes.
3107         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3108         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3109         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3110         * unittests/rsp-low-selftests.c: Fix common/ includes.
3111         * unittests/parse-connection-spec-selftests.c: Fix common/
3112         includes.
3113         * unittests/optional-selftests.c: Fix common/ includes.
3114         * unittests/offset-type-selftests.c: Fix common/ includes.
3115         * unittests/observable-selftests.c: Fix common/ includes.
3116         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3117         * unittests/memrange-selftests.c: Fix common/ includes.
3118         * unittests/memory-map-selftests.c: Fix common/ includes.
3119         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3120         * unittests/function-view-selftests.c: Fix common/ includes.
3121         * unittests/environ-selftests.c: Fix common/ includes.
3122         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3123         * unittests/common-utils-selftests.c: Fix common/ includes.
3124         * unittests/cli-utils-selftests.c: Fix common/ includes.
3125         * unittests/array-view-selftests.c: Fix common/ includes.
3126         * ui-file.c: Fix common/ includes.
3127         * tui/tui-io.c: Fix common/ includes.
3128         * tracepoint.h: Fix common/ includes.
3129         * tracepoint.c: Fix common/ includes.
3130         * tracefile-tfile.c: Fix common/ includes.
3131         * top.h: Fix common/ includes.
3132         * top.c: Fix common/ includes.
3133         * thread.c: Fix common/ includes.
3134         * target/waitstatus.h: Fix common/ includes.
3135         * target/waitstatus.c: Fix common/ includes.
3136         * target.h: Fix common/ includes.
3137         * target.c: Fix common/ includes.
3138         * target-memory.c: Fix common/ includes.
3139         * target-descriptions.c: Fix common/ includes.
3140         * symtab.h: Fix common/ includes.
3141         * symfile.c: Fix common/ includes.
3142         * stap-probe.c: Fix common/ includes.
3143         * spu-linux-nat.c: Fix common/ includes.
3144         * sparc-nat.c: Fix common/ includes.
3145         * source.c: Fix common/ includes.
3146         * solib.c: Fix common/ includes.
3147         * solib-target.c: Fix common/ includes.
3148         * ser-unix.c: Fix common/ includes.
3149         * ser-tcp.c: Fix common/ includes.
3150         * ser-pipe.c: Fix common/ includes.
3151         * ser-base.c: Fix common/ includes.
3152         * selftest-arch.c: Fix common/ includes.
3153         * s12z-tdep.c: Fix common/ includes.
3154         * rust-exp.y: Fix common/ includes.
3155         * rs6000-aix-tdep.c: Fix common/ includes.
3156         * riscv-tdep.c: Fix common/ includes.
3157         * remote.c: Fix common/ includes.
3158         * remote-notif.h: Fix common/ includes.
3159         * remote-fileio.h: Fix common/ includes.
3160         * remote-fileio.c: Fix common/ includes.
3161         * regcache.h: Fix common/ includes.
3162         * regcache.c: Fix common/ includes.
3163         * record-btrace.c: Fix common/ includes.
3164         * python/python.c: Fix common/ includes.
3165         * python/py-type.c: Fix common/ includes.
3166         * python/py-inferior.c: Fix common/ includes.
3167         * progspace.h: Fix common/ includes.
3168         * producer.c: Fix common/ includes.
3169         * procfs.c: Fix common/ includes.
3170         * proc-api.c: Fix common/ includes.
3171         * printcmd.c: Fix common/ includes.
3172         * ppc-linux-nat.c: Fix common/ includes.
3173         * parser-defs.h: Fix common/ includes.
3174         * osdata.c: Fix common/ includes.
3175         * obsd-nat.c: Fix common/ includes.
3176         * nat/x86-linux.c: Fix common/ includes.
3177         * nat/x86-linux-dregs.c: Fix common/ includes.
3178         * nat/x86-dregs.h: Fix common/ includes.
3179         * nat/x86-dregs.c: Fix common/ includes.
3180         * nat/ppc-linux.c: Fix common/ includes.
3181         * nat/mips-linux-watch.h: Fix common/ includes.
3182         * nat/mips-linux-watch.c: Fix common/ includes.
3183         * nat/linux-waitpid.c: Fix common/ includes.
3184         * nat/linux-ptrace.h: Fix common/ includes.
3185         * nat/linux-ptrace.c: Fix common/ includes.
3186         * nat/linux-procfs.c: Fix common/ includes.
3187         * nat/linux-personality.c: Fix common/ includes.
3188         * nat/linux-osdata.c: Fix common/ includes.
3189         * nat/linux-namespaces.c: Fix common/ includes.
3190         * nat/linux-btrace.h: Fix common/ includes.
3191         * nat/linux-btrace.c: Fix common/ includes.
3192         * nat/fork-inferior.c: Fix common/ includes.
3193         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3194         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3195         * nat/aarch64-linux.c: Fix common/ includes.
3196         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3197         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3198         * namespace.h: Fix common/ includes.
3199         * mips-linux-tdep.c: Fix common/ includes.
3200         * minsyms.c: Fix common/ includes.
3201         * mi/mi-parse.h: Fix common/ includes.
3202         * mi/mi-main.c: Fix common/ includes.
3203         * mi/mi-cmd-env.c: Fix common/ includes.
3204         * memrange.h: Fix common/ includes.
3205         * memattr.c: Fix common/ includes.
3206         * maint.h: Fix common/ includes.
3207         * maint.c: Fix common/ includes.
3208         * main.c: Fix common/ includes.
3209         * machoread.c: Fix common/ includes.
3210         * location.c: Fix common/ includes.
3211         * linux-thread-db.c: Fix common/ includes.
3212         * linux-nat.c: Fix common/ includes.
3213         * linux-fork.c: Fix common/ includes.
3214         * inline-frame.c: Fix common/ includes.
3215         * infrun.c: Fix common/ includes.
3216         * inflow.c: Fix common/ includes.
3217         * inferior.h: Fix common/ includes.
3218         * inferior.c: Fix common/ includes.
3219         * infcmd.c: Fix common/ includes.
3220         * inf-ptrace.c: Fix common/ includes.
3221         * inf-child.c: Fix common/ includes.
3222         * ia64-linux-nat.c: Fix common/ includes.
3223         * i387-tdep.c: Fix common/ includes.
3224         * i386-tdep.c: Fix common/ includes.
3225         * i386-linux-tdep.c: Fix common/ includes.
3226         * i386-linux-nat.c: Fix common/ includes.
3227         * i386-go32-tdep.c: Fix common/ includes.
3228         * i386-fbsd-tdep.c: Fix common/ includes.
3229         * i386-fbsd-nat.c: Fix common/ includes.
3230         * guile/scm-type.c: Fix common/ includes.
3231         * guile/guile.c: Fix common/ includes.
3232         * go32-nat.c: Fix common/ includes.
3233         * gnu-nat.c: Fix common/ includes.
3234         * gdbthread.h: Fix common/ includes.
3235         * gdbarch-selftests.c: Fix common/ includes.
3236         * gdb_usleep.c: Fix common/ includes.
3237         * gdb_select.h: Fix common/ includes.
3238         * gdb_bfd.c: Fix common/ includes.
3239         * gcore.c: Fix common/ includes.
3240         * fork-child.c: Fix common/ includes.
3241         * findvar.c: Fix common/ includes.
3242         * fbsd-nat.c: Fix common/ includes.
3243         * event-top.c: Fix common/ includes.
3244         * event-loop.c: Fix common/ includes.
3245         * dwarf2read.c: Fix common/ includes.
3246         * dwarf2loc.c: Fix common/ includes.
3247         * dwarf2-frame.c: Fix common/ includes.
3248         * dwarf-index-cache.c: Fix common/ includes.
3249         * dtrace-probe.c: Fix common/ includes.
3250         * disasm-selftests.c: Fix common/ includes.
3251         * defs.h: Fix common/ includes.
3252         * csky-tdep.c: Fix common/ includes.
3253         * cp-valprint.c: Fix common/ includes.
3254         * cp-support.h: Fix common/ includes.
3255         * cp-support.c: Fix common/ includes.
3256         * corelow.c: Fix common/ includes.
3257         * completer.h: Fix common/ includes.
3258         * completer.c: Fix common/ includes.
3259         * compile/compile.c: Fix common/ includes.
3260         * compile/compile-loc2c.c: Fix common/ includes.
3261         * compile/compile-cplus-types.c: Fix common/ includes.
3262         * compile/compile-cplus-symbols.c: Fix common/ includes.
3263         * command.h: Fix common/ includes.
3264         * cli/cli-dump.c: Fix common/ includes.
3265         * cli/cli-cmds.c: Fix common/ includes.
3266         * charset.c: Fix common/ includes.
3267         * build-id.c: Fix common/ includes.
3268         * btrace.h: Fix common/ includes.
3269         * btrace.c: Fix common/ includes.
3270         * breakpoint.h: Fix common/ includes.
3271         * breakpoint.c: Fix common/ includes.
3272         * ax.h: 
3273         (enum agent_op): Fix common/ includes.
3274         * ax-general.c (struct aop_map): Fix common/ includes.
3275         * ax-gdb.c: Fix common/ includes.
3276         * auxv.c: Fix common/ includes.
3277         * auto-load.c: Fix common/ includes.
3278         * arm-tdep.c: Fix common/ includes.
3279         * arch/riscv.c: Fix common/ includes.
3280         * arch/ppc-linux-common.c: Fix common/ includes.
3281         * arch/i386.c: Fix common/ includes.
3282         * arch/arm.c: Fix common/ includes.
3283         * arch/arm-linux.c: Fix common/ includes.
3284         * arch/arm-get-next-pcs.c: Fix common/ includes.
3285         * arch/amd64.c: Fix common/ includes.
3286         * arch/aarch64.c: Fix common/ includes.
3287         * arch/aarch64-insn.c: Fix common/ includes.
3288         * arch-utils.c: Fix common/ includes.
3289         * amd64-windows-tdep.c: Fix common/ includes.
3290         * amd64-tdep.c: Fix common/ includes.
3291         * amd64-sol2-tdep.c: Fix common/ includes.
3292         * amd64-obsd-tdep.c: Fix common/ includes.
3293         * amd64-nbsd-tdep.c: Fix common/ includes.
3294         * amd64-linux-tdep.c: Fix common/ includes.
3295         * amd64-linux-nat.c: Fix common/ includes.
3296         * amd64-fbsd-tdep.c: Fix common/ includes.
3297         * amd64-fbsd-nat.c: Fix common/ includes.
3298         * amd64-dicos-tdep.c: Fix common/ includes.
3299         * amd64-darwin-tdep.c: Fix common/ includes.
3300         * agent.c: Fix common/ includes.
3301         * ada-lang.h: Fix common/ includes.
3302         * ada-lang.c: Fix common/ includes.
3303         * aarch64-tdep.c: Fix common/ includes.
3304
3305 2019-01-25  Tom Tromey  <tom@tromey.com>
3306
3307         * common/create-version.sh: Use common/version.h.
3308
3309 2019-01-24  Pedro Alves  <palves@redhat.com>
3310
3311         * infrun.c (signal_stop, signal_print, signal_program)
3312         (signal_catch, signal_pass): Now arrays instead of pointers.
3313         (update_signals_program_target, do_target_resume)
3314         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3315         * linux-nat.c (linux_nat_target::pass_signals)
3316         (linux_nat_target::create_inferior, linux_nat_target::attach):
3317         Adjust.
3318         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3319         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3320         * procfs.c (procfs_target::pass_signals): Adjust.
3321         * record-full.c (record_full_target::resume): Adjust.
3322         * remote.c (remote_target::pass_signals)
3323         (remote_target::program_signals): Adjust.
3324         * target-debug.h (target_debug_print_signals): Now takes a
3325         gdb::array_view as parameter.  Adjust.
3326         * target.h (target_ops) <pass_signals, program_signals>: Replace
3327         pointer and length parameters with gdb::array_view.
3328         (target_pass_signals, target_program_signals): Likewise.
3329         * target-delegates.c: Regenerate.
3330
3331 2019-01-24  Pedro Alves  <palves@redhat.com>
3332
3333         * common/forward-scope-exit.h
3334         (forward_scope_exit::forward_scope_exit): Pass arguments to
3335         m_bind_function directly, instead of creating a std::bind and
3336         copying that.
3337
3338 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3339
3340         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3341         for static members.
3342         (pass_in_v_vfp_candidate): Likewise.
3343
3344 2019-01-23  Tom Tromey  <tom@tromey.com>
3345             Pedro Alves  <palves@redhat.com>
3346
3347         * regcache.c (class regcache_invalidator): Remove.
3348         (regcache::raw_write): Use make_scope_exit.
3349
3350 2019-01-23  Tom Tromey  <tom@tromey.com>
3351
3352         * ui-out.h (class ui_out_emit_type): Update comment.
3353
3354 2019-01-23  Tom Tromey  <tom@tromey.com>
3355
3356         * infrun.c (fetch_inferior_event): Update comment.
3357
3358 2019-01-23  Tom Tromey  <tom@tromey.com>
3359             Pedro Alves  <palves@redhat.com>
3360
3361         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3362         parameter.
3363         (fetch_inferior_event): Use SCOPE_EXIT.
3364
3365
3366 2019-01-23  Tom Tromey  <tom@tromey.com>
3367             Pedro Alves  <palves@redhat.com>
3368
3369         * infrun.c (disable_thread_events): Delete.
3370         (stop_all_threads): Use SCOPE_EXIT.
3371
3372 2019-01-23  Tom Tromey  <tom@tromey.com>
3373             Pedro Alves  <palves@redhat.com>
3374
3375         * symfile.c: Include forward-scope-exit.h.
3376         (clear_symtab_users_cleanup): Replace forward declaration with
3377         a FORWARD_SCOPE_EXIT.
3378         (syms_from_objfile_1): Use the forward_scope_exit and
3379         gdb::optional instead of cleanup_function.
3380         (reread_symbols): Use the forward_scope_exit instead of
3381         cleanup_function.
3382         (clear_symtab_users_cleanup): Remove function.
3383
3384 2019-01-23  Tom Tromey  <tom@tromey.com>
3385             Pedro Alves  <palves@redhat.com>
3386
3387         * linux-nat.c: Include scope-exit.h.
3388         (cleanup_target_stop): Remove.
3389         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3390         SCOPE_EXIT.
3391
3392 2019-01-23  Tom Tromey  <tom@tromey.com>
3393             Pedro Alves  <palves@redhat.com>
3394
3395         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3396         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3397
3398 2019-01-23  Tom Tromey  <tom@tromey.com>
3399             Andrew Burgess  <andrew.burgess@embecosm.com>
3400             Pedro Alves  <palves@redhat.com>
3401
3402         * infrun.c (fetch_inferior_event): Use scope_exit.
3403         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3404         * top.c (execute_command): Use scope_exit.
3405         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3406         * utils.c (do_bpstat_clear_actions_cleanup)
3407         (make_bpstat_clear_actions_cleanup): Remove.
3408
3409 2019-01-23  Tom Tromey  <tom@tromey.com>
3410             Pedro Alves  <palves@redhat.com>
3411
3412         * infrun.c: Include "common/scope-exit.h"
3413         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3414         (wait_for_inferior): Use SCOPE_EXIT.
3415         (fetch_inferior_event): Use scope_exit.
3416
3417 2019-01-23  Tom Tromey  <tom@tromey.com>
3418             Pedro Alves  <palves@redhat.com>
3419
3420         * breakpoint.c (create_breakpoint): Remove cleanup.
3421
3422 2019-01-23  Tom Tromey  <tom@tromey.com>
3423             Andrew Burgess  <andrew.burgess@embecosm.com>
3424             Pedro Alves  <palves@redhat.com>
3425
3426 2019-01-23  Pedro Alves  <palves@redhat.com>
3427
3428         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3429
3430 2019-01-23  Pedro Alves  <palves@redhat.com>
3431             Andrew Burgess  <andrew.burgess@embecosm.com>
3432
3433         * gdbthread.h: Include "common/forward-scope-exit.h".
3434         (scoped_finish_thread_state): Redefine custom class in terms of
3435         forward_scope_exit.
3436
3437 2019-01-23  Pedro Alves  <palves@redhat.com>
3438             Andrew Burgess  <andrew.burgess@embecosm.com>
3439
3440         * common/forward-scope-exit.h: New file.
3441
3442 2019-01-23  Pedro Alves  <palves@redhat.com>
3443             Andrew Burgess  <andrew.burgess@embecosm.com>
3444             Tom Tromey  <tom@tromey.com>
3445
3446         * common/scope-exit.h: New file.
3447
3448 2019-01-23  Pedro Alves  <palves@redhat.com>
3449
3450         * common/preprocessor.h (ESC): Rename to ...
3451         (ESC_PARENS): ... this.
3452         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3453         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3454
3455 2019-01-23  Tom Tromey  <tom@tromey.com>
3456
3457         * language.h (class scoped_switch_to_sym_language_if_auto):
3458         Initialize m_lang in both cases.
3459
3460 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3461
3462         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3463         with XCNEW.
3464
3465 2019-01-22  Tom Tromey  <tom@tromey.com>
3466
3467         * corelow.c: Do not include sys/file.h.
3468
3469 2019-01-22  Tom Tromey  <tom@tromey.com>
3470
3471         * tui/tui-wingeneral.h: Include gdb_curses.h.
3472
3473 2019-01-22  Tom Tromey  <tom@tromey.com>
3474
3475         * source-cache.h (class source_cache) <get_source_lines,
3476         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3477
3478 2019-01-22  Tom Tromey  <tom@tromey.com>
3479
3480         * remote-fileio.h (struct remote_target): Declare.
3481
3482 2019-01-22  Tom Tromey  <tom@tromey.com>
3483
3484         * python/py-arch.c: Do not include py-ref.h.
3485         * python/py-bpevent.c: Do not include py-ref.h.
3486         * python/py-cmd.c: Do not include py-ref.h.
3487         * python/py-continueevent.c: Do not include py-ref.h.
3488         * python/py-event.h: Do not include py-ref.h.
3489         * python/py-evtregistry.c: Do not include py-ref.h.
3490         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3491         * python/py-frame.c: Do not include py-ref.h.
3492         * python/py-framefilter.c: Do not include py-ref.h.
3493         * python/py-function.c: Do not include py-ref.h.
3494         * python/py-infevents.c: Do not include py-ref.h.
3495         * python/py-linetable.c: Do not include py-ref.h.
3496         * python/py-objfile.c: Do not include py-ref.h.
3497         * python/py-param.c: Do not include py-ref.h.
3498         * python/py-prettyprint.c: Do not include py-ref.h.
3499         * python/py-progspace.c: Do not include py-ref.h.
3500         * python/py-symbol.c: Do not include py-ref.h.
3501         * python/py-symtab.c: Do not include py-ref.h.
3502         * python/py-type.c: Do not include py-ref.h.
3503         * python/py-unwind.c: Do not include py-ref.h.
3504         * python/py-utils.c: Do not include py-ref.h.
3505         * python/py-value.c: Do not include py-ref.h.
3506         * python/py-varobj.c: Do not include py-ref.h.
3507         * python/py-xmethods.c: Do not include py-ref.h.
3508         * python/python.c: Do not include py-ref.h.
3509         * varobj.c: Do not include py-ref.h.
3510
3511 2019-01-22  Tom Tromey  <tom@tromey.com>
3512
3513         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3514         keyword for bcache.
3515
3516 2019-01-22  Tom Tromey  <tom@tromey.com>
3517
3518         * compile/compile-cplus-types.c: Remove a comment by #include.
3519
3520 2019-01-22  Tom Tromey  <tom@tromey.com>
3521
3522         * compile/gcc-c-plugin.h: Include compile-internal.h.
3523
3524 2019-01-22  Tom Tromey  <tom@tromey.com>
3525
3526         * stabsread.c (EXTERN): Do not define.
3527         (symnum, next_symbol_text_func, processing_gcc_compilation)
3528         (within_function, global_sym_chain, global_stabs)
3529         (previous_stab_code, this_object_header_files)
3530         (n_this_object_header_files)
3531         (n_allocated_this_object_header_files): Define.
3532         * stabsread.h (EXTERN): Never define.  Use "extern".
3533
3534 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3535
3536         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3537         history_value.
3538
3539 2019-01-21  Tom Tromey  <tom@tromey.com>
3540
3541         * ui-out.c: Fix includes.
3542         * tui/tui-source.c: Fix includes.
3543         * target.c: Fix includes.
3544         * remote.c: Fix includes.
3545         * regcache.c: Fix includes.
3546         * python/py-block.c: Fix includes.
3547         * printcmd.c: Fix includes.
3548         * or1k-tdep.c: Fix includes.
3549         * mi/mi-main.c: Fix includes.
3550         * m32r-tdep.c: Fix includes.
3551         * csky-tdep.c: Fix includes.
3552         * compile/compile-cplus-types.c: Fix includes.
3553         * cli/cli-interp.c: Fix includes.
3554
3555 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3556
3557         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3558         for padding.
3559
3560 2019-01-16  Tom Tromey  <tom@tromey.com>
3561
3562         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3563         earlier.
3564         (struct objfile) <msymbols_range>: Move from top level.
3565         <msymbols>: New method.
3566         (class objfile_msymbols): Remove.
3567         * symtab.c (default_collect_symbol_completion_matches_break_on):
3568         Update.
3569         * symmisc.c (dump_msymbols): Update.
3570         * stabsread.c (scan_file_globals): Update.
3571         * objc-lang.c (info_selectors_command, info_classes_command)
3572         (find_methods): Update.
3573         * minsyms.c (find_solib_trampoline_target): Update.
3574         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3575         * coffread.c (coff_symfile_read): Update.
3576         * ada-lang.c (ada_lookup_simple_minsym)
3577         (ada_collect_symbol_completion_matches): Update.
3578
3579 2019-01-16  Tom Tromey  <tom@tromey.com>
3580
3581         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3582         type.  Remove no-argument constructor.
3583         <iterator::operator++>: Simplify.
3584         <begin>: Update.
3585         <end>: Use minimal_symbol_count.
3586
3587 2019-01-16  Tom Tromey  <tom@tromey.com>
3588
3589         * objfiles.h (struct objfile) <psymtabs>: New method.
3590         (class objfile_psymtabs): Remove.
3591         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3592         typedef.
3593         <range>: New method.
3594         (require_partial_symbols): Change return type.
3595         * psymtab.c (require_partial_symbols)
3596         (psym_expand_symtabs_matching): Update.
3597         * mdebugread.c (parse_partial_symbols): Update.
3598         * dbxread.c (dbx_end_psymtab): Update.
3599
3600 2019-01-15  Tom Tromey  <tom@tromey.com>
3601
3602         * symtab.c (lookup_objfile_from_block)
3603         (lookup_symbol_in_objfile_symtabs)
3604         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3605         (find_line_symtab, info_sources_command)
3606         (default_collect_symbol_completion_matches_break_on)
3607         (make_source_files_completion_list): Update.
3608         * symmisc.c (print_objfile_statistics, dump_objfile)
3609         (maintenance_print_symbols, maintenance_info_symtabs)
3610         (maintenance_check_symtabs, maintenance_info_line_tables):
3611         Update.
3612         * source.c (select_source_symtab)
3613         (forget_cached_source_info_for_objfile): Update.
3614         * objfiles.h (class objfile_compunits): Remove.
3615         (struct objfile) <compunits_range>: New typedef.
3616         (compunits): New method.
3617         * objfiles.c (objfile_relocate1): Update.
3618         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3619         * maint.c (count_symtabs_and_blocks): Update.
3620         * linespec.c (iterate_over_all_matching_symtabs): Update.
3621         * cp-support.c (add_symbol_overload_list_qualified): Update.
3622         * coffread.c (coff_symtab_read): Update.
3623         * ada-lang.c (add_nonlocal_symbols)
3624         (ada_collect_symbol_completion_matches)
3625         (ada_add_global_exceptions): Update.
3626
3627 2019-01-15  Tom Tromey  <tom@tromey.com>
3628
3629         * progspace.h (program_space) <objfiles_safe_range>: New
3630         typedef.
3631         <objfiles_safe>: New method.
3632         * objfiles.h (class all_objfiles_safe): Remove.
3633         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3634         * jit.c (jit_inferior_exit_hook): Update.
3635
3636 2019-01-17  Tom Tromey  <tom@tromey.com>
3637
3638         * progspace.h (program_space) <objfiles_range>: New typedef.
3639         <objfiles>: New method.
3640         <objfiles_head>: Rename from objfiles.
3641         (object_files): Update.
3642         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3643         * guile/scm-pretty-print.c
3644         (ppscm_find_pretty_printer_from_objfiles): Update.
3645         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3646         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3647         Update.
3648         * python/py-progspace.c (pspy_get_objfiles): Update.
3649         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3650         Update.
3651         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3652         (objfpy_lookup_objfile_by_build_id): Update.
3653         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3654         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3655         Update.
3656         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3657         (expand_symtab_containing_pc, lookup_objfile_from_block)
3658         (lookup_static_symbol, basic_lookup_transparent_type)
3659         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3660         (find_line_symtab, info_sources_command)
3661         (default_collect_symbol_completion_matches_break_on)
3662         (make_source_files_completion_list, find_main_name): Update.
3663         * symmisc.c (print_symbol_bcache_statistics)
3664         (print_objfile_statistics, maintenance_print_symbols)
3665         (maintenance_print_msymbols, maintenance_print_objfiles)
3666         (maintenance_info_symtabs, maintenance_check_symtabs)
3667         (maintenance_expand_symtabs, maintenance_info_line_tables):
3668         Update.
3669         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3670         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3671         (map_overlay_command, unmap_overlay_command)
3672         (simple_overlay_update, expand_symtabs_matching)
3673         (map_symbol_filenames): Update.
3674         * symfile-debug.c (set_debug_symfile): Update.
3675         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3676         Update.
3677         * source.c (select_source_symtab, forget_cached_source_info):
3678         Update.
3679         * solib.c (solib_read_symbols): Update.
3680         * solib-spu.c (append_ocl_sos): Update.
3681         * psymtab.c (maintenance_print_psymbols)
3682         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3683         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3684         * printcmd.c (info_symbol_command): Update.
3685         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3686         Update.
3687         * objfiles.h (class all_objfiles): Remove.
3688         * objfiles.c (have_partial_symbols, have_full_symbols)
3689         (have_minimal_symbols, qsort_cmp, update_section_map)
3690         (shared_objfile_contains_address_p)
3691         (default_iterate_over_objfiles_in_search_order): Update.
3692         * objc-lang.c (info_selectors_command, info_classes_command)
3693         (find_methods): Update.
3694         * minsyms.c (find_solib_trampoline_target): Update.
3695         * maint.c (maintenance_info_sections)
3696         (maintenance_translate_address, count_symtabs_and_blocks):
3697         Update.
3698         * main.c (captured_main_1): Update.
3699         * linux-thread-db.c (try_thread_db_load_from_pdir)
3700         (has_libpthread): Update.
3701         * linespec.c (iterate_over_all_matching_symtabs)
3702         (search_minsyms_for_name): Update.
3703         * jit.c (jit_find_objf_with_entry_addr): Update.
3704         * hppa-tdep.c (find_unwind_entry)
3705         (hppa_lookup_stub_minimal_symbol): Update.
3706         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3707         Update.
3708         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3709         (elf_gnu_ifunc_resolve_by_got): Update.
3710         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3711         * dwarf-index-write.c (save_gdb_index_command): Update.
3712         * cp-support.c (add_symbol_overload_list_qualified): Update.
3713         * breakpoint.c (create_overlay_event_breakpoint)
3714         (create_longjmp_master_breakpoint)
3715         (create_std_terminate_master_breakpoint)
3716         (create_exception_master_breakpoint): Update.
3717         * blockframe.c (find_pc_partial_function): Update.
3718         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3719         (ada_collect_symbol_completion_matches)
3720         (ada_add_global_exceptions): Update.
3721
3722 2019-01-17  Tom Tromey  <tom@tromey.com>
3723
3724         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3725         declare VEC.
3726         (solib_target_parse_libraries): Change return type.
3727         (library_list_start_segment, library_list_start_section)
3728         (library_list_end_library, library_list_start_library); Update.
3729         (solib_target_free_library_list): Remove.
3730         (solib_target_parse_libraries): Remove cleanup.  Change return
3731         type.
3732         (solib_target_current_sos): Update.
3733
3734 2019-01-17  Tom Tromey  <tromey@bapiya>
3735
3736         * valprint.c: Replace "the the" with "the".
3737         * symtab.c: Replace "the the" with "the".
3738         * solib.c: Replace "the the" with "the".
3739         * solib-dsbt.c: Replace "the the" with "the".
3740         * linespec.c: Replace "the the" with "the".
3741         * dwarf2loc.h: Replace "the the" with "the".
3742         * amd64-windows-tdep.c: Replace "the the" with "the".
3743         * aarch64-tdep.c: Replace "the the" with "the".
3744
3745 2019-01-16  Keith Seitz  <keiths@redhat.com>
3746
3747         PR gdb/23773
3748         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3749         <builder>: Rename to ..
3750         <m_builder>: ... this and make private.
3751         (dwarf2_cu::get_builder): New method.  Change all users of
3752         `builder' to use this method.
3753         (dwarf2_start_symtab): Move to ...
3754         (dwarf2_cu::start_symtab): ... here.  Update all callers
3755         (setup_type_unit_groups): Move to ...
3756         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3757         callers.
3758         (dwarf2_cu::reset_builder): New method.
3759         (process_full_compunit, process_full_type_unit): Use
3760         dwarf2_cu::reset_builder.
3761         (follow_die_offset): Record the ancestor CU if it is different
3762         from the followed DIE's CU.
3763         (follow_die_sig_1): Likewise.
3764
3765 2019-01-15  Tom Tromey  <tom@tromey.com>
3766
3767         * remote.c (class remote_state) <buf>: Now a char_vector.
3768         <buf_size>: Remove.
3769         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3770         parameter.
3771         (remote_target::getpkt_or_notif_sane_1)
3772         (remote_target::getpkt_sane)
3773         (remote_target::getpkt_or_notif_sane): Likewise.
3774         (class remote_target) <putpkt>: New overload.
3775         (remote_target::read_frame): Change type of "buf_p".  Remove
3776         sizeof_p parameter.
3777         (packet_ok): New overload.
3778         (packet_check_result): New overload.
3779         Update all uses.
3780
3781 2019-01-14  Tom Tromey  <tom@tromey.com>
3782
3783         * remote-notif.c (handle_notification, remote_notif_ack)
3784         (remote_notif_parse): Make "buf" const.
3785         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3786         const.
3787         (remote_notif_parse, remote_notif_ack, handle_notification):
3788         Likewise.
3789         * remote.c (remote_notif_stop_parse): Make "buf" const.
3790         (remote_target::remote_parse_stop_reply): Make "buf" const.
3791         (remote_notif_stop_ack): Make "buf" const.
3792
3793 2019-01-14  Tom Tromey  <tom@tromey.com>
3794
3795         * remote.c (remote_console_output): Make parameter const.
3796
3797 2019-01-14  Tom Tromey  <tom@tromey.com>
3798
3799         * target-debug.h (target_debug_print_signals): Constify.
3800         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3801         * procfs.c (procfs_target::pass_signals): Update.
3802         * linux-nat.c (linux_nat_target::pass_signals): Update.
3803         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3804         * target-delegates.c: Rebuild.
3805         * remote.c (remote_target::program_signals): Update.
3806         (remote_target::pass_signals): Update.
3807         * target.c (target_pass_signals): Constify argument.
3808         (target_program_signals): Likewise.
3809         * target.h (struct target_ops) <pass_signals, program_signals>:
3810         Constify argument.
3811         (target_pass_signals, target_program_signals): Constify argument.
3812
3813 2019-01-14  Tom Tromey  <tom@tromey.com>
3814
3815         PR tui/28819:
3816         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3817
3818 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3819
3820         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3821         field.
3822         * rs6000-tdep.c: Include reggroups.h.
3823         (IS_V_ALIAS_PSEUDOREG): Define.
3824         (rs6000_register_name): Return names for the "vX" aliases.
3825         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3826         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3827         aliases.  Call default_register_reggroup_p for all other
3828         pseudo-registers.
3829         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3830         New functions.
3831         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3832         Handle "vX" aliases.
3833         (v_alias_pseudo_register_collect): New function.
3834         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3835         (rs6000_gdbarch_init): Initialize "vX" aliases as
3836         pseudo-registers.  Restore registration of
3837         rs6000_pseudo_register_reggroup_p with
3838         set_tdesc_pseudo_register_reggroup_p.
3839
3840 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3841
3842         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3843         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3844         set_gdbarch_num_pseudo_regs.
3845
3846 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3847
3848         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3849         Remove arg prefixname, add do_set and do_show.
3850         Add member functions set_list and show_list.
3851         * cli/cli-style.c (class cli_style_option): Update accordingly.
3852         (style_set_list): Move to file scope.
3853         (style_show_list): Likewise.
3854         (set_style): Call help_list.
3855         (show_style): Call cmd_show_list.
3856         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3857         Update to use the new macro.
3858
3859 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3860
3861         * ada-lang.c (_initialize_ada_language): Expand the help text
3862         for the "catch exception" command.
3863
3864 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3865
3866         * symtab.c (matching_obj_sections): Initialize obj,
3867         declare it closer to its usage.
3868
3869 2019-01-10  Tom Tromey  <tom@tromey.com>
3870
3871         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3872         (basic_inf_threads_range): Remove.
3873         (inf_threads_range, inf_non_exited_threads_range)
3874         (safe_inf_threads_range): Use next_adapter.
3875
3876 2019-01-10  Keith Seitz  <keiths@redhat.com>
3877
3878         PR gdb/23712
3879         PR symtab/23010
3880         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3881         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3882
3883 2019-01-10  Keith Seitz  <keiths@redhat.com>
3884
3885         PR gdb/23712
3886         PR symtab/23010
3887         * dictionary.c (pending_to_vector): Remove.
3888         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3889         Remove _1 suffix, replacing functions of the same name.  Update
3890         all callers.
3891         (dict_create_hashed, dict_create_hashed_expandable)
3892         (dict_create_linear, dict_create_linear_expandable, dict_free)
3893         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3894         Make functions static.
3895
3896 2019-01-10  Keith Seitz  <keiths@redhat.com>
3897
3898         PR gdb/23712
3899         PR symtab/23010
3900         * dictionary.h (struct dictionary): Replace declaration with
3901         multidictionary.
3902         (dict_create_hashed, dict_create_hashed_expandable)
3903         (dict_create_linear, dict_create_linear_expandable)
3904         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3905         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3906         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3907         taking multidictionary argument.
3908         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3909         * block.h (struct block) <dict>: Change to multidictionary
3910         and rename `multidict'.
3911         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3912         symmisc.c: Update all dictionary references to multidictionary.
3913
3914 2019-01-10  Keith Seitz  <keiths@redhat.com>
3915
3916         PR gdb/23712
3917         PR symtab/23010
3918         * dictionary.c: Include unordered_map.
3919         (pending_to_vector): New function.
3920         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3921         Rewrite the non-"_1" functions to take vector instead
3922         of linked list.
3923         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3924         "new" _1 versions of the same name.
3925         (multidictionary): Define.
3926         (std::hash<enum language): New definition.
3927         (collate_pending_symbols_by_language, mdict_create_hashed)
3928         (mdict_create_hashed_expandable, mdict_create_linear)
3929         (mdict_create_linear_expandable, mdict_free)
3930         (find_language_dictionary, create_new_language_dictionary)
3931         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3932         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3933         (mdict_size, mdict_empty): New functions.
3934         * dictionary.h (mdict_iterator): Define.
3935
3936 2019-01-10  Pedro Alves  <palves@redhat.com>
3937
3938         * breakpoint.c (read_uploaded_action)
3939         (create_tracepoint_from_upload): Adjust to use
3940         gdb::unique_xmalloc_ptr.
3941         * ctf.c (ctf_write_uploaded_tp):
3942         (SET_ARRAY_FIELD): Use emplace_back.
3943         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3944         * tracefile-tfile.c (tfile_write_uploaded_tp):
3945         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3946         gdb::unique_xmalloc_ptr.
3947         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3948         at_string, cond_string, cmd_strings>: Replace char pointers
3949         with gdb::unique_xmalloc_ptr.
3950
3951 2019-01-10  Pedro Alves  <palves@redhat.com>
3952
3953         * solib-target.c (library_list_start_library): Don't xstrdup name.
3954
3955 2019-01-10  Pedro Alves  <palves@redhat.com>
3956
3957         * mdebugread.c (parse_partial_symbols): Use
3958         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3959
3960 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3961
3962         * linux-fork.c (scoped_switch_fork_info)
3963         <~scoped_switch_fork_info>: Fix incorrect variable name.
3964
3965 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3966
3967         * linux-fork.c (scoped_switch_fork_info)
3968         <scoped_switch_fork_info>: Make explicit.
3969         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3970
3971 2019-01-10  Tom Tromey  <tom@tromey.com>
3972
3973         * objfiles.h (objfile::reset_psymtabs): Update.
3974         * objfiles.c (objfile::objfile): Update.
3975         * psymtab.h (psymtab_storage::obstack): Update.
3976         (psymtab_storage::m_obstack): Use gdb::optional.
3977         (class psymtab_storage): Update comment.  Remove objfile
3978         parameter.
3979         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3980
3981 2019-01-10  Tom Tromey  <tom@tromey.com>
3982
3983         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3984         <free_psymtabs>: Now private.
3985         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3986         (allocate_psymtab): Use new method.
3987
3988 2019-01-10  Tom Tromey  <tom@tromey.com>
3989
3990         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3991         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3992         * mdebugread.c (parse_partial_symbols): Use
3993         allocate_dependencies.
3994         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3995         allocate_dependencies.
3996         (process_psymtab_comp_unit_reader)
3997         (build_type_psymtab_dependencies): Likewise.
3998         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3999
4000 2019-01-10  Tom Tromey  <tom@tromey.com>
4001
4002         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4003         PSYMBOL_SET_LANGUAGE.
4004         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4005
4006 2019-01-10  Tom Tromey  <tom@tromey.com>
4007
4008         * psymtab.h (psymtab_storage::obstack): New method.
4009         <m_obstack>: Rename from obstack; now private.
4010         * psymtab.c (psymtab_storage): Update.
4011         * dwarf2read.c (create_addrmap_from_index)
4012         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4013         Update.
4014
4015 2019-01-10  Tom Tromey  <tom@tromey.com>
4016
4017         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4018         * objfiles.h (objfile::reset_psymtabs): New method.
4019
4020 2019-01-10  Tom Tromey  <tom@tromey.com>
4021
4022         * symmisc.c (print_symbol_bcache_statistics): Update.
4023         (print_objfile_statistics): Update.
4024         * symfile.c (reread_symbols): Update.
4025         * psymtab.h (class psymtab_storage): New.
4026         * psymtab.c (psymtab_storage): New constructor.
4027         (~psymtab_storage): New destructor.
4028         (require_partial_symbols): Update.
4029         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4030         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4031         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4032         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4033         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4034         (start_psymtab_common, end_psymtab_common)
4035         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4036         (allocate_psymtab): Update.
4037         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4038         Update.
4039         (dump_psymtab_addrmap, maintenance_print_psymbols)
4040         (maintenance_check_psymtabs): Update.
4041         (class objfile_psymtabs): Move to objfiles.h.
4042         * psympriv.h (discard_psymtab): Now inline.
4043         (psymtab_discarder::psymtab_discarder): Update.
4044         (psymtab_discarder::~psymtab_discarder): Update.
4045         (ALL_OBJFILE_PSYMTABS): Rewrite.
4046         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4047         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4048         Remove fields.
4049         <partial_symtabs>: New field.
4050         (class objfile_psymtabs): Move from psymtab.h.  Update.
4051         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4052         psymbol_cache.
4053         (objfile::~objfile): Don't destroy psymbol_cache.
4054         * mdebugread.c (parse_partial_symbols): Update.
4055         * dwarf2read.c (create_addrmap_from_index)
4056         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4057         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4058         (add_partial_subprogram, dwarf2_ranges_read): Update.
4059         * dwarf-index-write.c (write_address_map)
4060         (write_one_signatured_type, recursively_write_psymbols)
4061         (class debug_names, class debug_names, write_psymtabs_to_index):
4062         Update.
4063
4064 2019-01-10  Tom Tromey  <tom@tromey.com>
4065
4066         * symtab.h (SYMBOL_SET_NAMES): Update.
4067         (symbol_set_names): Update.
4068         (MSYMBOL_SET_NAMES): Update.
4069         * symtab.c (symbol_set_names): Change argument to be an
4070         objfile_per_bfd_storage.
4071         * psymtab.c (add_psymbol_to_bcache): Update.
4072         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4073
4074 2019-01-10  Tom Tromey  <tom@tromey.com>
4075
4076         * symtab.c (create_demangled_names_hash): Change argument to be an
4077         objfile_per_bfd_storage.
4078         (symbol_set_names): Update.
4079
4080 2019-01-10  Tom Tromey  <tom@tromey.com>
4081
4082         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4083         init_psymbol_list.
4084         * psymtab.c (init_psymbol_list): Do nothing if already called.
4085         * psympriv.h (init_psymbol_list): Add comment.
4086         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4087         init_psymbol_list.
4088         * dbxread.c (dbx_symfile_read): Unconditionally call
4089         init_psymbol_list.
4090
4091 2019-01-10  Tom Tromey  <tom@tromey.com>
4092
4093         * xcoffread.c (scan_xcoff_symtab): Update.
4094         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4095         "where".
4096         * mdebugread.c (parse_partial_symbols)
4097         (handle_psymbol_enumerators): Update.
4098         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4099         * dbxread.c (read_dbx_symtab): Update.
4100         * psympriv.h (psymbol_placement): New enum.
4101         (add_psymbol_to_list): Update.
4102
4103 2019-01-10  Tom Tromey  <tom@tromey.com>
4104
4105         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4106         static_psymbols parameters.
4107         (scan_xcoff_symtab): Update.
4108         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4109         static_psymbols parameters.
4110         * psympriv.h (start_psymtab_common): Update.
4111         * mdebugread.c (parse_partial_symbols): Update.
4112         * dwarf2read.c (create_partial_symtab): Update.
4113         * dbxread.c (read_dbx_symtab): Update.
4114         (start_psymtab): Remove global_psymbols and static_psymbols
4115         parameters.
4116
4117 2019-01-10  Tom Tromey  <tom@tromey.com>
4118
4119         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4120         * psymtab.c (allocate_psymtab): Add comment.
4121         * psympriv.h (allocate_psymtab): Add comment.
4122         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4123         initializations.
4124         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4125
4126 2019-01-10  Tom Tromey  <tom@tromey.com>
4127
4128         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4129         Don't declare.
4130         * mipsread.c: Include mdebugread.h.
4131         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4132         Declare.
4133         * elfread.c: Include mdebugread.h.
4134
4135 2019-01-09  Tom Tromey  <tom@tromey.com>
4136
4137         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4138         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4139         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4140         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4141         (psym_lookup_symbol, psym_find_last_source_symtab)
4142         (psym_forget_cached_source_info, psym_print_stats)
4143         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4144         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4145         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4146         (psym_find_compunit_symtab_by_address)
4147         (maintenance_print_psymbols, maintenance_info_psymtabs)
4148         (maintenance_check_psymtabs): Use ranged for.
4149         * psymtab.h (class objfile_psymtabs): New.
4150         (require_partial_symbols): Return objfile_psymtabs.
4151         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4152
4153 2019-01-09  Tom Tromey  <tom@tromey.com>
4154
4155         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4156         (find_pc_mapped_section, list_overlays_command)
4157         (map_overlay_command, unmap_overlay_command)
4158         (simple_overlay_update): Use all_objfiles.
4159         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4160         * printcmd.c (info_symbol_command): Use all_objfiles.
4161         * objfiles.h (ALL_OBJSECTIONS): Remove.
4162         * maint.c (maintenance_translate_address): Use all_objfiles.
4163         * gcore.c (gcore_create_callback): Use all_objfiles.
4164         (objfile_find_memory_regions): Likewise.
4165
4166 2019-01-09  Tom Tromey  <tom@tromey.com>
4167
4168         * symtab.c (find_line_symtab, info_sources_command)
4169         (make_source_files_completion_list): Use objfile_compunits.
4170         * source.c (select_source_symtab): Use objfile_compunits.
4171         * objfiles.h (struct objfile): Update comment.
4172         (ALL_OBJFILES): Remove.
4173         (ALL_FILETABS): Remove.
4174         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4175         objfile_compunits.
4176
4177 2019-01-09  Tom Tromey  <tom@tromey.com>
4178
4179         * symmisc.c (print_objfile_statistics, dump_objfile)
4180         (maintenance_print_symbols): Use compunit_filetabs.
4181         * source.c (forget_cached_source_info_for_objfile): Use
4182         compunit_filetabs.
4183         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4184         (ALL_FILETABS): Use compunit_filetabs.
4185         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4186         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4187
4188 2019-01-09  Tom Tromey  <tom@tromey.com>
4189
4190         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4191         (compunit_filetabs): New.
4192         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4193         compunit_filetabs.
4194         (info_sources_command, make_source_files_completion_list): Remove
4195         declaration.
4196         * symmisc.c (print_objfile_statistics, dump_objfile)
4197         (maintenance_print_symbols): Remove declaration.
4198         (maintenance_info_symtabs): Use compunit_filetabs.
4199         (maintenance_info_line_tables): Likewise.
4200         * source.c (select_source_symtab): Change local variable name.
4201         (forget_cached_source_info_for_objfile): Remove declaration.
4202         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4203         * objfiles.c (objfile_relocate1): Remove declaration.
4204         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4205         declaration.
4206         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4207         * coffread.c (coff_symtab_read): Remove declaration.
4208         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4209         compunit_filetabs.
4210
4211 2019-01-09  Tom Tromey  <tom@tromey.com>
4212
4213         * symtab.c (lookup_objfile_from_block)
4214         (find_pc_sect_compunit_symtab, search_symbols)
4215         (default_collect_symbol_completion_matches_break_on): Use
4216         objfile_compunits.
4217         * objfiles.h (ALL_COMPUNITS): Remove.
4218         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4219         * cp-support.c (add_symbol_overload_list_qualified): Use
4220         objfile_compunits.
4221         * ada-lang.c (ada_collect_symbol_completion_matches)
4222         (ada_add_global_exceptions): Use objfile_compunits.
4223
4224 2019-01-09  Tom Tromey  <tom@tromey.com>
4225
4226         * source.c (select_source_symtab)
4227         (forget_cached_source_info_for_objfile): Remove declaration.
4228         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4229         declaration.
4230         * maint.c (count_symtabs_and_blocks): Remove declaration.
4231         * cp-support.c (add_symbol_overload_list_qualified): Remove
4232         declaration.
4233         * coffread.c (coff_symtab_read): Remove declaration.
4234         * symtab.c (lookup_symbol_in_objfile_symtabs)
4235         (basic_lookup_transparent_type_1): Use objfile_compunits.
4236         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4237         (info_sources_command, search_symbols)
4238         (default_collect_symbol_completion_matches_break_on)
4239         (make_source_files_completion_list): Remove declaration.
4240         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4241         (ada_collect_symbol_completion_matches)
4242         (ada_add_global_exceptions): Remove declaration.
4243         * linespec.c (iterate_over_all_matching_symtabs): Use
4244         objfile_compunits.
4245         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4246         (class objfile_compunits): New.
4247         (ALL_COMPUNITS): Use objfile_compunits.
4248         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4249         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4250         objfile_compunits.
4251         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4252
4253 2019-01-09  Tom Tromey  <tom@tromey.com>
4254
4255         * symtab.c (search_symbols)
4256         (default_collect_symbol_completion_matches_break_on): Use
4257         objfile_msymbols.
4258         * ada-lang.c (ada_lookup_simple_minsym)
4259         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4260         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4261         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4262         objfile_msymbols.
4263         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4264         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4265         * objc-lang.c (find_methods): Use objfile_msymbols.
4266         (info_selectors_command, info_classes_command): Likewise.
4267         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4268         * objfiles.h (class objfile_msymbols): New.
4269         (ALL_OBJFILE_MSYMBOLS): Remove.
4270         (ALL_MSYMBOLS): Remove.
4271
4272 2019-01-09  Tom Tromey  <tom@tromey.com>
4273
4274         * common/next-iterator.h (next_adapter): Add Iterator template
4275         parameter.
4276         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4277         (class all_objfiles_safe): New.
4278         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4279         * objfiles.c (put_objfile_before): Update comment.
4280         (add_separate_debug_objfile): Likewise.
4281         (free_all_objfiles): Use all_objfiles_safe.
4282         (objfile_purge_solibs): Likewise.
4283
4284 2019-01-09  Tom Tromey  <tom@tromey.com>
4285
4286         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4287         (expand_symtab_containing_pc, lookup_static_symbol)
4288         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4289         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4290         all_objfiles.
4291         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4292         * breakpoint.c (create_overlay_event_breakpoint)
4293         (create_longjmp_master_breakpoint)
4294         (create_std_terminate_master_breakpoint)
4295         (create_exception_master_breakpoint): Use all_objfiles.
4296         * linux-thread-db.c (try_thread_db_load_from_pdir)
4297         (has_libpthread): Use all_objfiles.
4298         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4299         * linespec.c (iterate_over_all_matching_symtabs)
4300         (search_minsyms_for_name): Use all_objfiles.
4301         * maint.c (maintenance_info_sections): Use all_objfiles.
4302         * main.c (captured_main_1): Use all_objfiles.
4303         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4304         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4305         * guile/scm-pretty-print.c
4306         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4307         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4308         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4309         (maintenance_print_msymbols): Use all_objfiles.
4310         * source.c (select_source_symtab): Use all_objfiles.
4311         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4312         * symfile.c (remove_symbol_file_command)
4313         (expand_symtabs_matching, map_symbol_filenames): Use
4314         all_objfiles.
4315         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4316         all_objfiles.
4317         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4318         * objc-lang.c (find_methods): Use all_objfiles.
4319         * objfiles.c (have_partial_symbols, have_full_symbols)
4320         (have_minimal_symbols, qsort_cmp)
4321         (default_iterate_over_objfiles_in_search_order): Use
4322         all_objfiles.
4323         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4324         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4325         (maintenance_check_psymtabs): Use all_objfiles.
4326         (ALL_PSYMTABS): Remove.
4327         * compile/compile-object-run.c (do_module_cleanup): Use
4328         all_objfiles.
4329         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4330         * cp-support.c (add_symbol_overload_list_qualified): Use
4331         all_objfiles.
4332         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4333         Use all_objfiles.
4334         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4335         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4336         all_objfiles.
4337         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4338         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4339         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4340         Uses all_objfiles.
4341         * solib.c (solib_read_symbols): Use all_objfiles
4342
4343 2019-01-09  Tom Tromey  <tom@tromey.com>
4344
4345         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4346         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4347         all_objfiles.
4348         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4349         * symmisc.c (print_symbol_bcache_statistics)
4350         (print_objfile_statistics, maintenance_print_objfiles)
4351         (maintenance_info_symtabs, maintenance_check_symtabs)
4352         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4353         all_objfiles.
4354         * source.c (forget_cached_source_info): Use all_objfiles.
4355         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4356         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4357         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4358         * objfiles.c (update_section_map): Use all_objfiles.
4359         (shared_objfile_contains_address_p): Likewise.
4360         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4361         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4362
4363 2019-01-09  Tom Tromey  <tom@tromey.com>
4364
4365         * common/next-iterator.h: New file.
4366         * objfiles.h (class all_objfiles): New.
4367         (struct objfile_iterator): New.
4368
4369 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4370
4371         * NEWS: Move the description of the changed "frame", "select-frame",
4372          and "info frame" commands to the Changed commands section.
4373
4374 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4375
4376         * gdbtypes.c (check_stub_method_group): Remove handling of old
4377         mangling schemes.
4378         * linespec.c (find_methods): Likewise.
4379         * stabsread.c (read_member_functions): Likewise.
4380         * valops.c (search_struct_method): Likewise.
4381         (value_struct_elt_for_reference): Likewise.
4382         * NEWS: Mention this change.
4383
4384 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4385
4386         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4387         print_source_lines.
4388         * source.c (print_source_lines_base): Update line number check.
4389         (print_source_lines): New function.
4390         (source_lines_range::source_lines_range): New function.
4391         * source.h (class source_lines_range): New class.
4392         (print_source_lines): New declaration.
4393
4394 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4395
4396         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4397
4398 2019-01-08  Tom Tromey  <tom@tromey.com>
4399             Simon Marchi  <simon.marchi@ericsson.com>
4400
4401         PR gdb/24060
4402         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4403         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4404         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4405         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4406         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4407         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4408
4409 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4410
4411         * source.c (select_source_symtab): Move header comment to
4412         declaration in source.h.
4413         (forget_cached_source_info_for_objfile): Likewise.
4414         (forget_cached_source_info): Likewise.
4415         (identify_source_line): Likewise.
4416         * source.h (identify_source_line): Move declaration from symtab.h
4417         and add comment from source.c
4418         (print_source_lines): Likewise.
4419         (forget_cached_source_info_for_objfile): Likewise.
4420         (forget_cached_source_info): Likewise.
4421         (select_source_symtab): Likewise.
4422         (enum print_source_lines_flag): Move definition from symtab.h.
4423         * symtab.h (identify_source_line): Move declaration to source.h.
4424         (print_source_lines): Likewise.
4425         (forget_cached_source_info_for_objfile): Likewise.
4426         (forget_cached_source_info): Likewise.
4427         (select_source_symtab): Likewise.
4428         (enum print_source_lines_flag): Move definition to source.h.
4429         * tui/tui-hooks.c: Add 'source.h' include.
4430
4431 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4432
4433         * source.c (print_source_lines_base): Handle requests to print
4434         reverse line number sequences, and guard against empty lines
4435         string.
4436
4437 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4438
4439         * source.c (print_source_lines_base): Fix skip of '\r' if next
4440         character is '\n'.
4441
4442 2019-01-06  Tom Tromey  <tom@tromey.com>
4443
4444         * c-exp.y (struct c_parse_state) <macro_original_text,
4445         expansion_obstack>: New member.
4446         (macro_original_text, expansion_obstack): Remove globals.
4447         (scan_macro_expansion, scanning_macro_expansion)
4448         (finished_macro_expansion): Update.
4449         (scan_macro_cleanup): Remove.
4450         (yylex, c_parse): Update.
4451
4452 2019-01-06  Tom Tromey  <tom@tromey.com>
4453
4454         * c-exp.y (struct c_parse_state) <strings>: New member.
4455         (operator_stoken): Update.
4456
4457 2019-01-06  Tom Tromey  <tom@tromey.com>
4458
4459         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4460         (union type_stack_elt) <typelist_val>: Now a pointer to
4461         std::vector.
4462         (type_stack_cleanup): Don't declare.
4463         (push_typelist): Update.
4464         * parse.c (pop_typelist): Return a std::vector.
4465         (push_typelist): Take a std::vector.
4466         (follow_types): Update.  Do not free args.
4467         (type_stack_cleanup): Remove.
4468         * c-exp.y (struct c_parse_state): New.
4469         (cpstate): New global.
4470         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4471         (nonempty_typelist): Update.
4472         (func_mod): Create a new vector.
4473         (c_parse): Create a c_parse_state.
4474         (check_parameter_typelist): Do not delete params.
4475         (function_method): Update.  Do not delete type_list.
4476
4477 2019-01-06  Tom Tromey  <tom@tromey.com>
4478
4479         PR gdb/28155:
4480         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4481         check_typedef.
4482         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4483         (print_return_value): Likewise.
4484
4485 2019-01-05  Tom Tromey  <tom@tromey.com>
4486
4487         * contrib/cleanup_check.py: Remove.
4488         * contrib/gcc-with-excheck: Remove.
4489         * contrib/exsummary.py: Remove.
4490         * contrib/excheck.py: Remove.
4491
4492 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4493
4494         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4495         NULL. Initialize tpprev to NULL instead of assigning it
4496         to NULL on the next statement.
4497         * windows-nat.c (windows_delete_thread): Remove check for
4498         main_thread_id before printing thread exit notifications.
4499         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4500         Remove thread ID check against main_thread_id.
4501         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4502         windows_delete_thread.
4503         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4504
4505 2019-01-04  Tom Tromey  <tom@tromey.com>
4506
4507         * compile/compile.c (_initialize_compile): Use upper case for
4508         metasyntactic variables.
4509         * symmisc.c (_initialize_symmisc): Use upper case for
4510         metasyntactic variables.
4511         * psymtab.c (_initialize_psymtab): Use upper case for
4512         metasyntactic variables.
4513         * demangle.c (demangle_command): Use upper case for metasyntactic
4514         variables.
4515         (_initialize_demangler): Likewise.
4516         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4517         variables.
4518
4519 2019-01-03  Tom Tromey  <tom@tromey.com>
4520
4521         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4522
4523 2019-01-03  Tom Tromey  <tom@tromey.com>
4524
4525         * python/py-symtab.c (salpy_str): Update.
4526         (struct salpy_sal_object) <symtab>: Now a PyObject.
4527         (salpy_dealloc): Update.
4528         (del_objfile_sal): Use gdbpy_ref.
4529
4530 2019-01-03  Tom Tromey  <tom@tromey.com>
4531
4532         * python/py-type.c (convert_field): Use new_reference.  Return
4533         gdbpy_ref.
4534         (make_fielditem): Return gdbpy_ref.
4535         (typy_fields): Update.
4536         (typy_getitem): Update.
4537         (field_name): Return gdbpy_ref.  Use new_reference.
4538         (typy_iterator_iternext): Update.
4539
4540 2019-01-03  Tom Tromey  <tom@tromey.com>
4541
4542         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4543
4544 2019-01-03  Tom Tromey  <tom@tromey.com>
4545
4546         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4547         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4548         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4549         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4550         (pspy_set_type_printers): Likewise.
4551         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4552         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4553         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4554         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4555         (objfpy_set_type_printers): Likewise.
4556
4557 2019-01-03  Tom Tromey  <tom@tromey.com>
4558
4559         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4560         (gdbpy_print_stack): Use gdbpy_err_fetch.
4561         * python/python-internal.h (class gdbpy_err_fetch): New class.
4562         (class gdbpy_enter) <m_error_type, m_error_value,
4563         m_error_traceback>: Remove.
4564         <m_error>: New member.
4565         (gdbpy_exception_to_string): Don't declare.
4566         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4567         * python/py-value.c (convert_value_from_python): Use
4568         gdbpy_err_fetch.
4569         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4570         gdbpy_exception_to_string.
4571         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4572         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4573         gdbpy_err_fetch.
4574
4575 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4576
4577         * linux-nat.c (delete_lwp_cleanup): Delete.
4578         (struct lwp_deleter): New struct.
4579         (lwp_info_up): New typedef.
4580         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4581         lwp_info_up.
4582
4583 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4584
4585         * linux-fork.c (class scoped_switch_fork_info): New class.
4586         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4587
4588 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4589
4590         * valops.c (find_overload_match): Remove use of null_cleanup, and
4591         calls to do_cleanups.
4592
4593 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * compile/compile-cplus-types.c
4596         (compile_cplus_instance::decl_name): Handle changes to
4597         cp_func_name.
4598         * cp-support.c (cp_func_name): Update header comment, update
4599         return type.
4600         * cp-support.h (cp_func_name): Update return type in declaration.
4601         * valops.c (find_overload_match): Move temp_func local to top
4602         level of function and change its type.  Use temp_func to hold and
4603         delete temporary string obtained from cp_func_name.
4604
4605 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4606
4607         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4608         gdb::char_vector, remove cleanup, and update uses of `msg`.
4609
4610 2019-01-03  Jim Wilson  <jimw@sifive.com>
4611
4612         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4613
4614 2019-01-02  Tom Tromey  <tom@tromey.com>
4615
4616         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4617         (tdesc_parse_xml): Remove cleanups.
4618         * target-descriptions.h (make_cleanup_free_target_description):
4619         Don't declare.
4620         (target_desc_deleter): New struct.
4621         (target_desc_up): New typedef.
4622         * target-descriptions.c (target_desc_deleter::operator()): Rename
4623         from free_target_description.
4624         (make_cleanup_free_target_description): Remove.
4625
4626 2019-01-02  Tom Tromey  <tom@tromey.com>
4627
4628         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4629         constructor, destructor.
4630         (linespec_parser): Remove typedef.
4631         (~linespec_parser): Rename from linespec_parser_delete.
4632         (linespec_lex_to_end, linespec_complete_label)
4633         (linespec_complete): Update.
4634         (decode_line_full): Remove cleanups.
4635         (decode_line_1): Update.
4636
4637 2019-01-02  Tom Tromey  <tom@tromey.com>
4638
4639         * python/python-internal.h (inferior_to_inferior_object): Change
4640         return type.
4641         * python/py-exitedevent.c (create_exited_event_object): Update.
4642         * python/py-inferior.c (inferior_to_inferior_object): Return
4643         gdbpy_ref.
4644         (python_new_inferior, python_inferior_deleted)
4645         (thread_to_thread_object, delete_thread_object)
4646         (build_inferior_list, gdbpy_selected_inferior): Update.
4647         * python/py-infthread.c (create_thread_object): Update.  Also fail
4648         if inferior_to_inferior_object fails.
4649
4650 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4651
4652         * inferior.h (class inferior) <displaced_step_state>: New field.
4653         * infrun.h (struct displaced_step_state): Move here from
4654         infrun.c.  Initialize fields, add constructor.
4655         <inf>: Remove field.
4656         <reset>: New method.
4657         * infrun.c (struct displaced_step_inferior_state): Move to
4658         infrun.h.
4659         (displaced_step_inferior_states): Remove.
4660         (get_displaced_stepping_state): Adust.
4661         (displaced_step_in_progress_any_inferior): Adjust.
4662         (displaced_step_in_progress_thread): Adjust.
4663         (displaced_step_in_progress): Adjust.
4664         (add_displaced_stepping_state): Remove.
4665         (get_displaced_step_closure_by_addr): Adjust.
4666         (remove_displaced_stepping_state): Remove.
4667         (infrun_inferior_exit): Call displaced_step_state.reset.
4668         (use_displaced_stepping): Don't check for NULL.
4669         (displaced_step_prepare_throw): Call
4670         get_displaced_stepping_state.
4671         (displaced_step_fixup): Don't check for NULL.
4672         (prepare_for_detach): Don't check for NULL.
4673
4674 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4675
4676         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4677          in case of call that did not complete.
4678
4679 2019-01-02  Andrey Utkin  <autkin@undo.io>
4680
4681         * symfile.c (find_separate_debug_file): Fix search of debug files for
4682         remote debuggee.
4683
4684 2019-01-02  Tom Tromey  <tom@tromey.com>
4685
4686         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4687         indentation.
4688         * python/py-frame.c (frapy_older): Remove cast.
4689         (frapy_newer): Likewise.
4690         * python/py-breakpoint.c (local_setattro): Remove cast.
4691         * python/py-arch.c (archpy_name): Remove local variable.
4692         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4693
4694 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4695
4696         * unittests/basic_string_view/element_access/char/empty.cc:
4697         Fix year range in copyright header.
4698
4699 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4700
4701         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4702         Delete.
4703         <operator==>: Update with for removed field.
4704         <hash>: Likewise.
4705         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4706         <isa_features>: ...this.
4707         <abi_features>: New field.
4708         (riscv_isa_flen): Update comment.
4709         (riscv_abi_xlen): New declaration.
4710         (riscv_abi_flen): New declaration.
4711         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4712         isa_features.
4713         (riscv_abi_xlen): New function.
4714         (riscv_isa_flen): Update to get answer from isa_features.
4715         (riscv_abi_flen): New function.
4716         (riscv_has_fp_abi): Update to get answer from abi_features.
4717         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4718         xlen and flen.
4719         (riscv_call_info) <xlen, flen>: Update comment.
4720         (riscv_call_arg_struct): Remove invalid assertions
4721         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4722         is removed.
4723         (riscv_gdbarch_init): Gather isa features and abi features
4724         separately, ensure both match on the gdbarch when reusing an old
4725         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4726         a target with 64-bit float hardware.
4727
4728 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4729
4730         * source.c (search_command_helper): Stop reverse search
4731         when line 1 has been searched.
4732
4733 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4734
4735         * record-full.c (record_full_base_target::close): Rewrite
4736         record_full_core_buf_list free logic.
4737
4738 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4739
4740         * break-catch-syscall.c (print_one_catch_syscall): xfree
4741         the last text.
4742
4743 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4744
4745         * top.c (print_gdb_version): Update Copyright year in version
4746         message.
4747
4748 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4749
4750         Update copyright year range in all GDB files.
4751
4752 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4753
4754         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4755
4756 For older changes see ChangeLog-2018.
4757 \f
4758 Local Variables:
4759 mode: change-log
4760 left-margin: 8
4761 fill-column: 74
4762 version-control: never
4763 coding: utf-8
4764 End:
4765