gdb/ChangeLog

   1 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
   2
   3         * h8300-tdep.c (h8300_register_name_common): New.
   4         h8300_register_name): Use h8300_register_name_common.
   5         (h8300s_register_name): Likewise.
   6         (h8300sx_register_name): Likewise.
   7         (h8300h_register_nam): New.
   8         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
   9
  10
  11 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
  12
  13         * arm-tdep.c (arm_skip_cmse_entry): New function.
  14         (arm_is_sgstubs_section): New function.
  15         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
  16
  17 2019-07-22  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
  20         Don't self-assign.
  21
  22 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  23
  24         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
  25         type_print.
  26
  27 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  28
  29         * symtab.c (search_symbols): Adjust msymbol matching type arrays
  30         so that GDB doesn't match any msymbols when searching in the
  31         TYPES_DOMAIN.
  32         (print_symbol_info): Print using typedef_print or type_print based
  33         on the type of the symbol.  Add updated FIXME comment moved from...
  34         (_initialize_symtab): ... move and update FIXME comment to above.
  35
  36 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  37
  38         * NEWS: Mention adding -q option to "info types".
  39         * symtab.c (struct info_types_options): New struct.
  40         (info_types_options_defs): New variable.
  41         (make_info_types_options_def_group): New function.
  42         (info_types_command): Use gdb::option framework to parse options.
  43         (info_types_command_completer): New function.
  44         (_initialize_symtab): Extend the help text on "info types" and
  45         register command completer.
  46
  47 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
  48
  49         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
  50         (lookup_symbol_in_objfile): Change int to block_enum and add a
  51         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
  52
  53 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
  54
  55         * MAINTAINERS (Write After Approval): Add self.
  56
  57 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
  58
  59         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
  60         instruction to the dummy code region.
  61
  62 2019-07-19  Tom Tromey  <tromey@adacore.com>
  63
  64         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
  65         (ARGSUSED, PARAMS, __func__): Remove rules.
  66
  67 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  68
  69         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
  70         * features/arm/arm-with-iwmmxt.c: Remove.
  71         * features/arm/arm-with-iwmmxt.xml: Remove.
  72         * features/arm/arm-with-m-fpa-layout.c: Remove.
  73         * features/arm/arm-with-m-fpa-layout.xml: Remove.
  74         * features/arm/arm-with-m-vfp-d16.c: Remove.
  75         * features/arm/arm-with-m-vfp-d16.xml: Remove.
  76         * features/arm/arm-with-m.c: Remove.
  77         * features/arm/arm-with-m.xml: Remove.
  78         * features/arm/arm-with-neon.c: Remove.
  79         * features/arm/arm-with-neon.xml: Remove.
  80         * features/arm/arm-with-vfpv2.c: Remove.
  81         * features/arm/arm-with-vfpv2.xml: Remove.
  82         * features/arm/arm-with-vfpv3.c: Remove.
  83         * features/arm/arm-with-vfpv3.xml: Remove.
  84
  85 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  86
  87         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
  88
  89 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  90
  91         * arch/aarch32.c (aarch32_create_target_description): Create
  92         target descriptions using features.
  93         * arch/arm.c (arm_create_target_description)
  94         (arm_create_mprofile_target_description): Likewise.
  95         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
  96
  97 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  98
  99         * Makefile.in: Add new files.
 100         * aarch32-tdep.c: New file.
 101         * aarch32-tdep.h: New file.
 102         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 103         Call aarch32_read_description.
 104         * arch/aarch32.c: New file.
 105         * arch/aarch32.h: New file.
 106         * arch/arm.c (arm_create_target_description)
 107         (arm_create_mprofile_target_description): New function.
 108         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 109         (arm_create_target_description)
 110         (arm_create_mprofile_target_description): New declaration.
 111         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 112         read_description functions.
 113         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 114         Likewise.
 115         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 116         * arm-tdep.c (tdesc_arm_list): New variable.
 117         (arm_register_g_packet_guesses): Call create description functions.
 118         (arm_read_description) (arm_read_mprofile_description): New
 119         function.
 120         * arm-tdep.h (arm_read_description)
 121         (arm_read_mprofile_description): Add declaration.
 122         * configure.tgt: Add new files.
 123
 124 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 125
 126         * top.c (new_ui_command): Open specified terminal just once.
 127
 128 2019-07-18  Tom Tromey  <tromey@adacore.com>
 129
 130         * symtab.c (main_name): Constify return type.
 131         * symfile.c (set_initial_language): Update.
 132         * symtab.h (main_name): Constify return type.
 133
 134 2019-07-17  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-winsource.c (tui_update_source_window)
 137         (tui_update_source_window_as_is)
 138         (tui_update_source_windows_with_line): Remove return.
 139         * tui/tui-disasm.c (tui_show_disassem)
 140         (tui_show_disassem_and_update_source): Remove return.
 141         * tui/tui.c (tui_reset): Remove return.
 142         * tui/tui-wingeneral.c
 143         (tui_check_and_display_highlight_if_needed): Remove return.
 144
 145 2019-07-17  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 148
 149 2019-07-17  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-winsource.h (struct tui_exec_info_window)
 152         (struct tui_source_window_base): Move from tui-data.h.
 153         * tui/tui-winsource.c: Move many method definitions from
 154         elsewhere.  Remove "structuring" comments.
 155         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 156         (tui_source_window_base::refresh_window): Move to
 157         tui-winsource.c.
 158         * tui/tui-win.c (tui_source_window_base::refresh_all)
 159         (tui_source_window_base::update_tab_width)
 160         (tui_source_window_base::set_new_height)
 161         (tui_source_window_base::do_make_visible_with_new_height): Move to
 162         tui-winsource.c.
 163         * tui/tui-source.h: Update.
 164         * tui/tui-source.c (tui_source_window_base::reset): Move to
 165         tui-winsource.c.
 166         * tui/tui-disasm.h: Update.
 167         * tui/tui-data.h (struct tui_exec_info_window): Move to
 168         tui-winsource.h.
 169         (struct tui_source_window_base): Likewise.
 170         * tui/tui-data.c (tui_source_window_base::clear_detail)
 171         (tui_source_window_base, ~tui_source_window_base): Move to
 172         tui-winsource.c.
 173
 174 2019-07-17  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-win.c (tui_resize_all)
 177         (tui_source_window_base::update_tab_width)
 178         (tui_adjust_win_heights): Update.
 179         (tui_win_info::make_invisible_and_set_new_height): Rename from
 180         make_invisible_and_set_new_height.
 181         * tui/tui-data.h (struct tui_win_info)
 182         <make_invisible_and_set_new_height>: New method.
 183
 184 2019-07-17  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui.c: Update.
 187         * tui/tui-source.h (struct tui_source_window): Move from
 188         tui-data.h.
 189         * tui/tui-layout.c: Update.
 190         * tui/tui-disasm.c: Update.
 191         * tui/tui-data.h (struct tui_source_window): Move to
 192         tui-source.h.
 193
 194 2019-07-17  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 197         tui-data.h.
 198         * tui/tui-data.h (struct tui_disasm_window): Move to
 199         tui-disasm.h.
 200
 201 2019-07-17  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-regs.h (struct tui_data_item_window): Move from
 204         tui-data.h.
 205         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 206         * tui/tui-data.h (struct tui_data_item_window): Move to
 207         tui-regs.h.
 208         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 209
 210 2019-07-17  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui.c: Update.
 213         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 214         (tui_cmd_window::max_height): Move to tui-command.c.
 215         * tui/tui-layout.c: Update.
 216         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 217         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 218         tui-command.c.
 219         * tui/tui-command.h (struct tui_cmd_window): Move from
 220         tui-data.h.
 221         * tui/tui-command.c: Remove "structuring" comments.
 222         (tui_cmd_window::clear_detail)
 223         (tui_cmd_window::do_make_visible_with_new_height)
 224         (tui_cmd_window::max_height): Move from elsewhere.
 225
 226 2019-07-17  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 229         Now static.
 230         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 231         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 232
 233 2019-07-17  Tom Tromey  <tom@tromey.com>
 234
 235         * tui/tui.c: Update.
 236         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 237         tui-regs.c.
 238         * tui/tui-windata.h: Remove file.
 239         * tui/tui-windata.c: Remove file.
 240         * tui/tui-win.c (tui_data_window::set_new_height)
 241         (tui_data_window::do_make_visible_with_new_height): Move to
 242         tui-regs.c.
 243         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 244         * tui/tui-regs.c: Remove "structuring" comments.
 245         (tui_data_window::first_data_item_displayed)
 246         (tui_data_window::delete_data_content_windows)
 247         (tui_data_window::erase_data_content)
 248         (tui_data_window::display_all_data)
 249         (tui_data_window::refresh_all)
 250         (tui_data_window::do_scroll_vertical)
 251         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 252         (tui_data_window::do_make_visible_with_new_height)
 253         (tui_data_window::refresh_window): Move from elsewhere.
 254         (_initialize_tui_regs): Move to end of file.
 255         * tui/tui-layout.c: Update.
 256         * tui/tui-hooks.c: Update.
 257         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 258         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 259         tui-regs.c.
 260         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 265         seen.
 266
 267 2019-07-17  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-win.c (tui_source_window_base::set_new_height)
 270         (tui_source_window_base::do_make_visible_with_new_height): Use
 271         m_has_locator field directly.
 272         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 273         method.
 274         (struct tui_source_window_base) <has_locator>: Likewise.
 275
 276 2019-07-17  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 279         Don't declare.
 280         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 281         Remove.
 282         * tui/tui-win.c (tui_source_window_base::set_new_height)
 283         (tui_source_window_base::set_new_height)
 284         (make_invisible_and_set_new_height)
 285         (tui_source_window_base::do_make_visible_with_new_height)
 286         (tui_source_window_base::do_make_visible_with_new_height):
 287         Update.
 288         * tui/tui-layout.c (show_source_disasm_command, show_data)
 289         (show_source_or_disasm_and_command): Update.
 290         * tui/tui-layout.c (show_layout): Update.
 291
 292 2019-07-17  Tom Tromey  <tom@tromey.com>
 293
 294         * tui/tui-layout.c (make_data_window): Remove.
 295         (show_data): Unify creation and re-initialization cases.
 296
 297 2019-07-17  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-layout.c (make_source_window, make_disasm_window):
 300         Remove.
 301         (show_data): Unify creation and re-initialization cases.
 302
 303 2019-07-17  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-layout.c (make_command_window): Remove.
 306         (show_source_disasm_command, show_source_or_disasm_and_command):
 307         Unify creation and re-initialization cases.
 308
 309 2019-07-17  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 312         creation and re-initialization cases.
 313
 314 2019-07-17  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-regs.c (tui_get_register): Return void.
 317
 318 2019-07-17  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 321         Simplify.
 322
 323 2019-07-17  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 326         resetting.
 327
 328 2019-07-17  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 331         * tui/tui-regs.c (tui_reg_layout): New function.
 332         (tui_show_registers, tui_reg_command): Use it.
 333         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 334         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 335         parameters.
 336         (tui_layout_command): Remove.
 337
 338 2019-07-17  Tom Tromey  <tom@tromey.com>
 339
 340         * tui/tui-layout.h (tui/tui-layout): Return void.
 341         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 342
 343 2019-07-17  Tom Tromey  <tom@tromey.com>
 344
 345         * tui/tui-layout.c (show_source_disasm_command, show_data):
 346         Update.
 347         (reset_locator): Remove.
 348         (show_source_or_disasm_and_command): Update.
 349
 350 2019-07-17  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-source.c (tui_source_window_base::reset): Remove
 353         win_type parameter.
 354         * tui/tui-layout.c (make_command_window, make_source_window)
 355         (make_disasm_window, make_data_window)
 356         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 357         (reset_locator, show_source_or_disasm_and_command): Update.
 358         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 359         win_type parameter.
 360         (struct tui_source_window_base) <reset>: Likewise.
 361
 362 2019-07-17  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui-layout.c (show_source_disasm_command): Use
 365         reset_locator.
 366         (reset_locator): New function.
 367         (init_and_make_win): Remove.
 368         (show_source_or_disasm_and_command): Use reset_locator.
 369
 370 2019-07-17  Tom Tromey  <tom@tromey.com>
 371
 372         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 373         condition.
 374         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 375         Remove condition.
 376         * tui/tui-source.c (tui_source_window_base::reset): New method.
 377         * tui/tui-layout.c (make_command_window): Don't call
 378         init_and_make_win.
 379         (make_source_window, make_disasm_window): Don't call
 380         make_source_or_disasm_window.
 381         (make_data_window): Don't call init_and_make_win.  Change calling
 382         convention.
 383         (show_source_disasm_command, show_data): Simplify.
 384         (make_source_or_disasm_window): Remove.
 385         (show_source_or_disasm_and_command): Simplify.
 386         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 387         (struct tui_source_window_base) <reset>: Likewise.
 388         <execution_info>: Remove initializer.
 389         * tui/tui-data.c (tui_source_window_base): Initialize
 390         execution_info.
 391
 392 2019-07-17  Tom Tromey  <tom@tromey.com>
 393
 394         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 395         variable.
 396
 397 2019-07-17  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui.c (tui_rl_other_window): Update.
 400         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 401         superclass method first.  Always iterate over regs_content.
 402         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 403         method.
 404         * tui/tui-win.c (tui_set_focus_command): Update.
 405
 406 2019-07-17  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-win.c (tui_set_focus_command): Rename from
 409         tui_set_focus.  Call tui_enable.
 410         (tui_set_focus_command): Remove.
 411
 412 2019-07-17  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 415         refresh_window.
 416         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 417         touchwin.
 418         (tui_data_window::refresh_window): Call refresh_window on data
 419         items.  Always call superclass refresh_window.
 420         (tui_win_info::refresh): Remove.
 421         (tui_source_window_base::refresh_window): Update.
 422         (tui_refresh_all): Update.
 423         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 424         refresh_window.
 425         (show_source_or_disasm_and_command): Likewise.
 426         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 427         (struct tui_source_window_base) <refresh>: Likewise.
 428
 429 2019-07-17  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-winsource.c (tui_clear_source_content)
 432         (tui_show_source_content): Update.
 433         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 434         whether content is empty.
 435         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 436         Remove.
 437
 438 2019-07-17  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 441         window's contents.
 442         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 443         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 444
 445 2019-07-17  Tom Tromey  <tom@tromey.com>
 446
 447         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 448         (struct tui_data_item_window): Update.
 449
 450 2019-07-17  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 453         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 454         defines.
 455
 456 2019-07-17  Tom Tromey  <tom@tromey.com>
 457
 458         * tui/tui-winsource.h (tui_erase_source_content)
 459         (tui_clear_source_content): Remove "display_prompt" parameter.
 460         * tui/tui-winsource.c (tui_update_source_window_as_is)
 461         (tui_update_source_windows_with_addr): Update.
 462         (tui_clear_source_content): Remove "display_prompt" parameter.
 463         (tui_erase_source_content): Likewise.  Simplify.
 464         (tui_show_source_content): Update.
 465         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 466         * tui/tui-stack.c (tui_show_frame_info): Update.
 467         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 468         Remove defines.
 469
 470 2019-07-17  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 473         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 474         parameter.
 475         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 476         parameter.
 477
 478 2019-07-17  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-winsource.c (tui_clear_source_content)
 481         (tui_show_source_content, tui_show_exec_info_content)
 482         (tui_clear_exec_info_content): Update.
 483         * tui/tui-stack.c (tui_show_locator_content): Update.
 484         (tui_show_frame_info): Update.
 485         * tui/tui-source.h (tui_source_window): Don't declare.
 486         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 487         from tui_source_is_displayed.
 488         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 489         Remove field.
 490         (struct tui_source_window_base) <content_in_use>: New field.  Now
 491         bool.
 492         (struct tui_source_window) <showing_source_p>: New method.
 493         (TUI_SRC_WIN): Change cast.
 494         * tui/tui-data.c (tui_initialize_static_data): Update.
 495
 496 2019-07-17  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 499         location_matches_p.
 500         * tui/tui-source.c (tui_source_window::location_matches_p): New
 501         method.
 502         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 503         method.
 504         * tui/tui-data.h (struct tui_source_window_base)
 505         <location_matches_p>: New method.
 506         (struct tui_source_window, struct tui_disasm_window)
 507         <location_matches_p>: Likewise.
 508
 509 2019-07-17  Tom Tromey  <tom@tromey.com>
 510
 511         * tui/tui-win.c (tui_set_win_height_command): Rename from
 512         tui_set_win_height.
 513         (tui_set_win_height_command): Remove.
 514
 515 2019-07-17  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui-source.c (tui_source_window): New constructor.  Add
 518         observer.
 519         (~tui_source_window): New destructor.
 520         (tui_source_window::style_changed): New method.
 521         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 522         (tui_attach_detach_observers): Update.
 523         * tui/tui-data.h (struct tui_source_window): Make constructor not
 524         inline.  Add destructor.
 525         (struct tui_source_window) <style_changed>: New method.
 526         <m_observable>: New member.
 527
 528 2019-07-17  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 531         * tui/tui-win.c (tui_resize_all): Fix typo.
 532
 533 2019-07-17  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 536         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 537         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 538         * tui/tui-win.c (window_name_completer): Use foreach.
 539         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 540         (update_tab_width): Likewise.
 541         * tui/tui-layout.c (show_layout): Update.
 542         * tui/tui-data.h (class tui_window_iterator): New.
 543         (struct all_tui_windows): New.
 544         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 545
 546 2019-07-17  Tom Tromey  <tom@tromey.com>
 547
 548         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 549         parameter.  Don't reference globals.
 550         (tui_reg_command): Update.
 551
 552 2019-07-17  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-regs.c (tui_show_registers): Simplify.
 555
 556 2019-07-17  Tom Tromey  <tom@tromey.com>
 557
 558         * tui/tui-regs.c (tui_show_registers): Update.
 559         (tui_show_register_group): Add win_info parameter.
 560
 561 2019-07-17  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 564         Rename from tui_display_reg_element_at_line.
 565         (tui_data_window::display_registers_from_line): Update.
 566         * tui/tui-data.h (struct tui_data_window)
 567         <display_reg_element_at_line>: New method.
 568
 569 2019-07-17  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-regs.h (tui_display_registers_from)
 572         (tui_display_registers_from_line): Don't declare.
 573         * tui/tui-windata.c (tui_data_window::display_all_data)
 574         (tui_data_window::refresh_all)
 575         (tui_data_window::do_scroll_vertical): Update.
 576         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 577         from tui_display_registers_from.
 578         (tui_display_reg_element_at_line): Update.
 579         (tui_data_window::display_registers_from_line): Rename from
 580         tui_display_registers_from_line.
 581         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 582         display_registers_from_line>: New methods.
 583
 584 2019-07-17  Tom Tromey  <tom@tromey.com>
 585
 586         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 587         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 588         from tui_erase_data_content.
 589         (tui_data_window::display_all_data)
 590         (tui_data_window::refresh_all)
 591         (tui_data_window::do_scroll_vertical): Update.
 592         * tui/tui-regs.c (tui_show_registers): Update.
 593         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 594         New method.
 595
 596 2019-07-17  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 599         declare.
 600         * tui/tui-windata.c
 601         (tui_data_window::delete_data_content_windows): Rename from
 602         tui_delete_data_content_windows.
 603         (tui_data_window::display_all_data)
 604         (tui_data_window::do_scroll_vertical): Update.
 605         * tui/tui-data.h (struct tui_data_window)
 606         <delete_data_content_windows>: New method.
 607
 608 2019-07-17  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 611         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 612
 613 2019-07-17  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 616         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 617         from tui_display_all_data.
 618         * tui/tui-win.c
 619         (tui_data_window::do_make_visible_with_new_height): Update.
 620         * tui/tui-regs.c (tui_show_registers): Update.
 621         * tui/tui-layout.c (tui_set_layout): Update.
 622         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 623         method.
 624
 625 2019-07-17  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 628         * tui/tui-windata.c (tui_display_data_from): Remove.
 629         (tui_data_window::refresh_all): Update.
 630
 631 2019-07-17  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 634         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 635         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 636         tui_display_registers_from_line.
 637         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 638         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 639         "force_display" parameter.
 640
 641 2019-07-17  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 644         declare.
 645         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 646         Rename from tui_first_reg_element_no_inline.
 647         (tui_display_reg_element_at_line)
 648         (tui_display_registers_from_line): Update.
 649         * tui/tui-data.h (struct tui_data_window)
 650         <first_reg_element_no_inline>: New method.
 651
 652 2019-07-17  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-windata.c (tui_display_data_from)
 655         (tui_data_window::do_scroll_vertical): Update.
 656         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 657         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 658         Rename from tui_line_from_reg_element_no.
 659         (tui_display_registers_from_line): Update.
 660         * tui/tui-data.h (struct tui_data_window)
 661         <line_from_reg_element_no>: New method.
 662
 663 2019-07-17  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 666         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 667         tui_last_regs_line_no.
 668         (tui_display_reg_element_at_line)
 669         (tui_display_registers_from_line): Update.
 670         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 671         method.
 672
 673 2019-07-17  Tom Tromey  <tom@tromey.com>
 674
 675         PR tui/24722:
 676         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 677         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 678         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 679         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 680         (tui_update_breakpoint_info): Likewise.
 681         * tui/tui-hooks.c (tui_event_create_breakpoint)
 682         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 683         Update.
 684
 685 2019-07-17  Tom Tromey  <tom@tromey.com>
 686
 687         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 688
 689 2019-07-17  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-winsource.c (tui_update_source_window_as_is)
 692         (tui_update_source_windows_with_addr): Update.
 693         * tui/tui-source.h (tui_set_source_content)
 694         (tui_show_symtab_source): Add "win_info" parameter.
 695         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 696         parameter.
 697         (tui_show_symtab_source): Likewise.
 698
 699 2019-07-17  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-wingeneral.c
 702         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 703
 704 2019-07-17  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 707         (struct tui_cmd_window) <can_scroll>: New method.
 708         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 709         method.
 710
 711 2019-07-17  Tom Tromey  <tromey@adacore.com>
 712
 713         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 714         do_field_signed>: Rename.  Change type of "value".
 715         * ui-out.c (ui_out::field_signed): Rename from field_int.
 716         Change type of "value".
 717         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 718         type of "value".
 719         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 720         do_field_int.  Change type of "value".
 721         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 722         do_field_int.  Change type of "value".
 723         * tracepoint.c (trace_status_mi, tfind_1)
 724         (print_one_static_tracepoint_marker): Update.
 725         * thread.c (print_thread_info_1, print_selected_thread_frame):
 726         Update.
 727         * stack.c (print_frame, print_frame_info): Update.
 728         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 729         Update.
 730         * source.c (print_source_lines_base): Update.
 731         * skip.c (info_skip_command): Update.
 732         * record-btrace.c (btrace_ui_out_decode_error)
 733         (btrace_call_history_src_line): Update.
 734         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 735         Update.
 736         * progspace.c (print_program_space): Update.
 737         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 738         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 739         do_field_int.  Change type of "value".
 740         * mi/mi-out.c (mi_ui_out::do_table_begin)
 741         (mi_ui_out::do_table_header): Update.
 742         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 743         type of "value".
 744         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 745         (mi_cmd_data_list_changed_registers, output_register)
 746         (mi_cmd_data_read_memory, mi_load_progress)
 747         (mi_cmd_trace_frame_collected): Update.
 748         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 749         Update.
 750         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 751         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 752         (mi_cmd_var_list_children, varobj_update_one): Update.
 753         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 754         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 755         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 756         * inferior.c (print_inferior): Update.
 757         * gdb_bfd.c (print_one_bfd): Update.
 758         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 759         Update.
 760         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 761         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 762         do_field_int.  Change type of "value".
 763         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 764         do_field_int.  Change type of "value".
 765         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 766         (print_one_breakpoint_location, print_it_catch_fork)
 767         (print_one_catch_fork, print_it_catch_vfork)
 768         (print_one_catch_vfork, print_it_catch_solib)
 769         (print_it_catch_exec, print_it_ranged_breakpoint)
 770         (print_mention_watchpoint, print_mention_masked_watchpoint)
 771         (bkpt_print_it, update_static_tracepoint): Update.
 772         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 773         * break-catch-syscall.c (print_it_catch_syscall): Update.
 774         * ada-tasks.c (print_ada_task_info): Update.
 775         * ada-lang.c (print_it_exception, print_mention_exception):
 776         Update.
 777
 778 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         PR breakpoints/24541
 781         * gdbarch.c: Regenerate.
 782         * gdbarch.h: Regenerate.
 783         * gdbarch.sh: Adjust return type and parameter types for
 784         'stap_adjust_register'.
 785         (i386_stap_adjust_register): Adjust signature and return new
 786         register name.
 787         * stap-probe.c (stap_parse_register_operand): Adjust use of
 788         'gdbarch_stap_adjust_register'.
 789
 790 2019-07-17  Tom Tromey  <tromey@adacore.com>
 791
 792         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 793         declare VEC.
 794         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 795         std::vector.
 796         (struct s390_process_info): Add initializers.
 797         (s390_add_process): Use new.
 798         (s390_linux_nat_target::low_forget_process): Use delete.
 799         (s390_linux_nat_target::low_new_fork)
 800         (s390_linux_nat_target::stopped_by_watchpoint)
 801         (s390_linux_nat_target::low_prepare_to_resume)
 802         (s390_linux_nat_target::insert_watchpoint)
 803         (s390_linux_nat_target::insert_hw_breakpoint)
 804         (s390_linux_nat_target::remove_watchpoint)
 805         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 806
 807 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 808
 809         * aarch64-fbsd-nat.c: Include regcache.h.
 810         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 811         argument.
 812         (aarch64_fbsd_nat_target::fetch_registers)
 813         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 814         variable.
 815         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 816
 817 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 818
 819         * fbsd-nat.c: Include gdbarch.h.
 820
 821 2019-07-15  Tom Tromey  <tromey@adacore.com>
 822
 823         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 824
 825 2019-07-15  Tom Tromey  <tromey@adacore.com>
 826
 827         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 828         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 829         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 830         * cli-out.c (cli_ui_out::do_field_int): New method.
 831         * ui-out.c (ui_out::field_unsigned): New method.
 832         * symfile.c (generic_load): Use field_unsigned.
 833         (print_transfer_performance): Likewise.
 834         * record-btrace.c (ui_out_field_uint): Remove.
 835         (btrace_call_history_insn_range, btrace_call_history): Use
 836         field_unsigned.
 837         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 838         field_unsigned.
 839         * ui-out.h (class ui_out) <field_unsigned>: New method.
 840         <do_field_unsigned>: Likewise.
 841
 842 2019-07-15  Tom Tromey  <tromey@adacore.com>
 843
 844         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 845         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 846         * target.c (flash_erase_command): Use field_string.
 847         * infrun.c (print_signal_received_reason): Use field_string.
 848         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 849         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 850         field_string.
 851         * ada-tasks.c (print_ada_task_info): Use field_string.
 852
 853 2019-07-15  Tom Tromey  <tromey@adacore.com>
 854
 855         * target.c (flash_erase_command): Use field_core_addr.
 856         * symfile.c (generic_load): Use field_core_addr.
 857         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 858         Use field_core_addr.
 859         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 860         field_core_addr.
 861
 862 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 863
 864         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 865         value if its desired type is smaller than a CORE_ADDR and signed.
 866
 867 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 870         of changes to field names, and use new is_reference field to
 871         decide if a property is a reference or not.
 872         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 873         field.
 874         (struct dwarf2_property_baton): Update header comment, rename
 875         'referenced_type' to 'property_type' and update comments.
 876         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 877         default property type, store in property baton, update to take
 878         accound of renamed field.
 879         (read_func_scope): Update call to attr_to_dynamic_prop.
 880         (read_array_type): Likewise.
 881         (dwarf2_per_cu_addr_sized_int_type): New function.
 882         (read_subrange_index_type): Move type finding code to
 883         dwarf2_per_cu_addr_sized_int_type.
 884         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 885         (dwarf2_per_cu_addr_type): New function.
 886         (set_die_type): Update calls to attr_to_dynamic_prop.
 887
 888 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 889
 890         * dwarf2read.c (read_subrange_index_type): New function.
 891         (read_subrange_type): Move code into new function and call it.
 892         * gdbtypes.c (create_range_type): Add some asserts.
 893
 894 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 895
 896         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 897         update return statements.
 898         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 899         declaration, and update comment to match.
 900         * gdbtypes.c (resolve_dynamic_array): Update call to
 901         dwarf2_evaluate_property to match new return type.
 902
 903 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 904
 905         * valarith.c (value_subscripted_rvalue): Change lowerbound
 906         parameter type from int to LONGEST.
 907         * value.h (value_subscripted_rvalue): Likewise in declaration.
 908
 909 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 910
 911         * cli/cli-utils.c (info_print_command_completer): New function.
 912         * cli/cli-utils.h: Add 'completer.h' include, and forward
 913         declaration for 'struct cmd_list_element'.
 914         (info_print_command_completer): Declare.
 915         * stack.c (_initialize_stack): Add completer for 'info locals' and
 916         'info args'.
 917         * symtab.c (_initialize_symtab): Add completer for 'info
 918         variables' and 'info functions'.
 919         * NEWS: Mention completion for additional info commands.
 920
 921 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 922
 923         * cli/cli-utils.c (extract_info_print_args): Delete.
 924         (extract_arg_maybe_quoted): Delete.
 925         (info_print_options_defs): New variable.
 926         (make_info_print_options_def_group): New function.
 927         (extract_info_print_options): Define new function.
 928         * cli/cli-utils.h (extract_info_print_args): Delete.
 929         (struct info_print_options): New structure.
 930         (extract_info_print_options): Declare new function.
 931         * stack.c (info_locals_command): Update to use new
 932         extract_info_print_options, also add a header comment.
 933         (info_args_command): Likewise.
 934         * symtab.c (info_variables_command): Likewise.
 935         (info_functions_command): Likewise.
 936
 937 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 938
 939         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 940         to extract string arguments.
 941         * common/common-utils.c (extract_string_maybe_quoted): New function.
 942         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 943
 944 2019-07-11  Tom Tromey  <tromey@adacore.com>
 945
 946         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 947         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 948         * top.h (gdbinit): Don't declare.
 949         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 950         into...
 951         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 952         * top.c (gdb_init): Don't call init_cli_cmds.
 953         (gdbinit): Remove.
 954         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 955
 956 2019-07-11  Tom Tromey  <tromey@adacore.com>
 957
 958         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 959         after it has been moved.
 960
 961 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 962
 963         * valops.c (value_must_coerce_to_target): Change return type to
 964         bool.
 965         * value.h (value_must_coerce_to_target): Likewise.
 966
 967 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 968
 969         * breakpoint.c (is_hardware_watchpoint): Remove
 970         forward-declaration.
 971         (is_masked_watchpoint): Change return type to bool.
 972         (is_tracepoint): Likewise.
 973         (is_breakpoint): Likewise.
 974         (is_hardware_watchpoint): Likewise.
 975         (is_watchpoint): Likewise.
 976         (is_no_memory_software_watchpoint): Likewise.
 977         (is_catchpoint): Likewise.
 978         (breakpoint_1): Make FILTER parameter's return type bool.
 979         is_masked_watchpoint): Change return type to bool.
 980         (save_breakpoints): Make FILTER parameter's return type bool.
 981         * breakpoint.h (is_breakpoint): Change return type to bool.
 982         (is_watchpoint): Likewise.
 983         (is_catchpoint): Likewise.
 984         (is_tracepoint): Likewise.
 985
 986 2019-07-10  Tom Tromey  <tom@tromey.com>
 987
 988         * defs.h: Don't include gdbarch.h.
 989         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 990         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 991         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 992         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 993         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 994         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 995         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 996         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 997         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 998         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 999         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1000         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1001         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1002         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1003         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1004         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1005         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1006         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1007         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1008         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1009         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1010         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1011         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1012         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1013         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1014         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1015         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1016
1017 2019-07-10  Tom Tromey  <tromey@adacore.com>
1018
1019         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1020         * breakpoint.c (init_ada_exception_breakpoint): Register as
1021         bp_catchpoint.
1022         (print_one_breakpoint_location, print_one_breakpoint): Use
1023         is_ada_exception_catchpoint.
1024         * ada-lang.c (class ada_catchpoint_location): Pass
1025         bp_loc_software_breakpoint to bp_location constructor.
1026         (is_ada_exception_catchpoint): New function.
1027
1028 2019-07-10  Tom Tromey  <tromey@adacore.com>
1029
1030         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1031         VEC.
1032         (struct arm_exidx_entry): New method operator<.
1033         (struct arm_exidx_data) <section_maps>: Change type.
1034         (arm_exidx_data_free): Remove.
1035         (arm_exidx_data_key): Change type.  Move lower.
1036         (arm_exidx_new_objfile): Update.
1037         (arm_compare_exidx_entries): Remove.
1038         (arm_find_exidx_entry, _initialize_arm_tdep)
1039
1040 2019-07-10  Tom Tromey  <tromey@adacore.com>
1041
1042         * solib-spu.c (ocl_program_data_key): Change type.
1043         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1044         Update.
1045
1046 2019-07-10  Tom Tromey  <tromey@adacore.com>
1047
1048         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1049         (struct solib_aix_inferior_data) <library_list>: Change type.
1050         (solib_aix_inferior_data_handle): Change type.
1051         (get_solib_aix_inferior_data): Update.
1052         (solib_aix_free_library_list): Remove.
1053         (library_list_start_library): Update.
1054         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1055         return type.
1056         (solib_aix_get_library_list)
1057         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1058         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1059
1060 2019-07-10  Tom Tromey  <tromey@adacore.com>
1061
1062         * solib-dsbt.c (struct dsbt_info): Add initializers.
1063         (solib_dsbt_pspace_data): Change type.
1064         (dsbt_pspace_data_cleanup): Remove.
1065         (get_dsbt_info, _initialize_dsbt_solib): Update.
1066
1067 2019-07-10  Tom Tromey  <tromey@adacore.com>
1068
1069         * spu-tdep.c (spu_overlay_data): Change type.
1070         (spu_get_overlay_table, spu_overlay_new_objfile)
1071         (_initialize_spu_tdep): Update.
1072
1073 2019-07-10  Tom Tromey  <tromey@adacore.com>
1074
1075         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1076         destructor.
1077         (dbx_objfile_data_key): Change type and declare later.
1078         (DBX_SYMFILE_INFO): Rewrite.
1079         * dbxread.c (dbx_objfile_data_key): Change type.
1080         (dbx_symfile_init): Update.
1081         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1082         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1083         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1084
1085 2019-07-10  Tom Tromey  <tromey@adacore.com>
1086
1087         * jit.c (jit_program_space_key): Change type.  Move lower.
1088         (get_jit_program_space_data): Update.
1089         (jit_program_space_data_cleanup): Remove.
1090         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1091         Update.
1092         (struct jit_program_space_data): Add initializers.
1093
1094 2019-07-10  Tom Tromey  <tromey@adacore.com>
1095
1096         * solib-darwin.c (struct darwin_info): Add initializers.
1097         (solib_darwin_pspace_data): Change type.
1098         (darwin_pspace_data_cleanup): Remove.
1099         (get_darwin_info, _initialize_darwin_solib): Update.
1100
1101 2019-07-10  Tom Tromey  <tromey@adacore.com>
1102
1103         * remote-sim.c (struct sim_inferior_data): Add initializers,
1104         constructor, and destructor.
1105         (sim_inferior_data_key): Change type.  Move lower.
1106         (check_for_duplicate_sim_descriptor): Update.
1107         (get_sim_inferior_data): Use new.  Update.
1108         (~sim_inferior_data_cleanup): Rename from
1109         sim_inferior_data_cleanup.  Simplify.
1110         (gdbsim_close_inferior, simulator_command)
1111         (sim_command_completer, _initialize_remote_sim): Update.
1112         (next_pid, INITIAL_PID): Move earlier.
1113
1114 2019-07-10  Tom Tromey  <tromey@adacore.com>
1115
1116         * python/python-internal.h (create_thread_object): Return
1117         gdbpy_ref.
1118         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1119         * python/py-inferior.c (struct threadlist_entry): Add
1120         constructor.
1121         <thread_obj>: Now a gdbpy_ref.
1122         (thread_to_thread_object): Update.
1123         (add_thread_object): Use new.
1124         (delete_thread_object): Use delete.
1125         (infpy_threads): Update.
1126         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1127         GIL.
1128
1129 2019-07-10  Tom Tromey  <tromey@adacore.com>
1130
1131         * valops.c (value_cast): Specialize error message for Ada.
1132
1133 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1134
1135         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1136
1137 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1138
1139         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1140         bpstat_should_step): Return bool, adjust comments.
1141         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1142         bpstat_should_step): Likewise.
1143
1144 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1145
1146         * features/Makefile: Use feature target descriptions for Arm.
1147         * features/arm/arm-core.c: Generate new file.
1148         * features/arm/arm-fpa.c: Likewise.
1149         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1150         * features/arm/arm-m-profile.c: Likewise.
1151         * features/arm/arm-vfpv2.c: Likewise.
1152         * features/arm/arm-vfpv3.c: Likewise.
1153         * features/arm/xscale-iwmmxt.c: Likewise.
1154         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1155
1156 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1157
1158         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1159         ptrace earlier.
1160
1161 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1162
1163         * features/aarch64-pauth.c: Regenerate.
1164
1165 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1166
1167         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1168         bool.
1169         (bpstat_what): Use false instead of 0.
1170
1171 2019-07-09  Pedro Alves  <palves@redhat.com>
1172
1173         * break-catch-throw.c (is_exception_catchpoint): New.
1174         * breakpoint.c (print_one_breakpoint_location): New parameter
1175         'raw_loc'.  Handle it.  Use
1176         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1177         looking at the breakpoint's type.
1178         (print_one_breakpoint): If handling "maint info breakpoints", also
1179         print locations of exception catchpoints.
1180         * breakpoint.h (is_exception_catchpoint): Declare.
1181
1182 2019-07-09  Pedro Alves  <palves@redhat.com>
1183
1184         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1185         "addr" field.
1186         (allocate_location_exception_catchpoint): New.
1187         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1188         (initialize_throw_catchpoint_ops): Install
1189         allocate_location_exception_catchpoint as allocate_location
1190         method.
1191         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1192         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1193         bp_loc_other.
1194         (breakpoint_address_is_meaningful): Delete.
1195         (bl_address_is_meaningful): New.
1196         (breakpoint_locations_match): Adjust comment.
1197         (bp_location_from_bp_type): New, factored out of...
1198         (bp_location::bp_location(breakpoint *)): ... this.
1199         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1200         factored out of...
1201         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1202         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1203         breakpoint_address_is_meaningful.
1204         (bp_locations_compare): Adjust comment.
1205         (update_global_location_list): Use bl_address_is_meaningful
1206         instead of breakpoint_address_is_meaningful.
1207         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1208         explicit.
1209         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1210         * python/py-breakpoint.c (bppy_get_location): No longer check
1211         whether location is null.
1212
1213 2019-07-09  Pedro Alves  <palves@redhat.com>
1214
1215         PR c++/15468
1216         * breakpoint.c (print_one_breakpoint_location): Remove
1217         single-location assert.
1218
1219 2019-07-09  Tom Tromey  <tom@tromey.com>
1220
1221         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1222         * configure: Rebuild.
1223         * configure.ac: Change common to gdbsupport.
1224         * gdbsupport: Rename from common.
1225         * acinclude.m4: Change common to gdbsupport.
1226         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1227         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1228         gdbsupport.
1229         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1230         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1231         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1232         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1233         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1234         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1235         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1236         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1237         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1238         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1239         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1240         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1241         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1242         coff-pe-read.c, command.h, compile/compile-c-support.c,
1243         compile/compile-c.h, compile/compile-cplus-symbols.c,
1244         compile/compile-cplus-types.c, compile/compile-cplus.h,
1245         compile/compile-loc2c.c, compile/compile.c, completer.c,
1246         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1247         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1248         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1249         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1250         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1251         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1252         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1253         features/aarch64-core.c, features/aarch64-fpu.c,
1254         features/aarch64-pauth.c, features/aarch64-sve.c,
1255         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1256         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1257         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1258         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1259         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1260         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1261         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1262         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1263         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1264         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1265         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1266         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1267         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1268         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1269         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1270         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1271         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1272         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1273         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1274         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1275         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1276         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1277         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1278         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1279         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1280         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1281         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1282         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1283         minsyms.c, mips-linux-tdep.c, namespace.h,
1284         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1285         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1286         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1287         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1288         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1289         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1290         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1291         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1292         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1293         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1294         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1295         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1296         procfs.c, producer.c, progspace.h, psymtab.h,
1297         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1298         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1299         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1300         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1301         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1302         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1303         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1304         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1305         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1306         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1307         target-memory.c, target.c, target.h, target/waitstatus.c,
1308         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1309         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1310         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1311         unittests/array-view-selftests.c,
1312         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1313         unittests/common-utils-selftests.c,
1314         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1315         unittests/format_pieces-selftests.c,
1316         unittests/function-view-selftests.c,
1317         unittests/lookup_name_info-selftests.c,
1318         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1319         unittests/mkdir-recursive-selftests.c,
1320         unittests/observable-selftests.c,
1321         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1322         unittests/parse-connection-spec-selftests.c,
1323         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1324         unittests/scoped_fd-selftests.c,
1325         unittests/scoped_mmap-selftests.c,
1326         unittests/scoped_restore-selftests.c,
1327         unittests/string_view-selftests.c, unittests/style-selftests.c,
1328         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1329         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1330         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1331         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1332         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1333         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1334
1335 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1336
1337         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1338         bool value.
1339         (decode_digits_ordinary): Set explicit_line field in sal.
1340         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1341         symtab_and_line that was set on an explicit line number in
1342         assembler code.  Do always update the recorded symtab and line if
1343         we do skip the prologue.
1344
1345 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1346
1347         * breakpoint.c (set_breakpoint_location_function): Remove
1348         explicit_loc parameter.
1349         (momentary_breakpoint_from_master): Update call to
1350         set_breakpoint_location_function.
1351         (add_location_to_breakpoint): Likewise.
1352
1353 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1354
1355         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1356         required features based on default bfd type when no specific bfd
1357         is present.
1358
1359 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1360
1361         * NEWS: Mention that GDB printf and eval commands can now print
1362         C-style and Ada-style convenience var strings without
1363         calling the inferior.
1364         * printcmd.c (printf_c_string): Locally print GDB internal var
1365         instead of transiting via the inferior.
1366         (printf_wide_c_string): Likewise.
1367
1368 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1369
1370         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1371
1372 2019-07-04  Tom Tromey  <tom@tromey.com>
1373
1374         PR tui/24724:
1375         * tui/tui-winsource.c (tui_clear_source_content): Update.
1376         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1377         (tui_update_breakpoint_info): Update.
1378         (tui_set_exec_info_content): Update.
1379         * tui/tui-source.c (tui_set_source_content_nil): Update.
1380         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1381         has_break.
1382         * tui/tui-data.h (enum tui_bp_flag): New.
1383         (tui_bp_flags): New enum flags type.
1384         (struct tui_source_element) <break_mode>: Change type.  Rename
1385         from has_break.
1386         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1387         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1388         constants.
1389         * tui/tui-winsource.h: Fix comment.
1390
1391 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1392
1393         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1394         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1395         (store_fpregs_to_thread)
1396         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1397         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1398         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1399         (IWMMXT_REGS_SIZE): Add define.
1400         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1401         (fetch_vfp_regs, store_vfp_regs)
1402         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1403         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1404
1405 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1406
1407         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1408         defines.
1409         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1410         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1411         (ARM_INT_REGISTER_SIZE): ...to this.
1412         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1413         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1414         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1415         (arm_linux_collect_gregset, supply_nwfpe_register)
1416         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1417         defines.
1418         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1419         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1420         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1421         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1422         (arm_return_in_memory, arm_store_return_value)
1423         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1424         (arm_record_ld_st_multiple): Likewise.
1425         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1426         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1427
1428 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1429
1430         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1431         AARCH64_DISPLACED_MODIFIED_INSNS.
1432         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1433         (aarch64_displaced_step_copy_insn): Likewise.
1434         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1435         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1436         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1437         ARM_DISPLACED_MODIFIED_INSNS.
1438         * arm-tdep.c (arm_gdbarch_init): Likewise.
1439         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1440         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1441         (struct arm_displaced_step_closure): Use
1442         ARM_DISPLACED_MODIFIED_INSNS.
1443
1444 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1445
1446         * features/Makefile: Remove unused xml files.
1447         * features/aarch64.xml: Remove.
1448         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1449         * features/i386/amd64-avx-avx512.xml: Remove.
1450         * features/i386/amd64-avx-linux.xml: Remove.
1451         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1452         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1453         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1454         * features/i386/amd64-avx-mpx.xml: Remove.
1455         * features/i386/amd64-avx.xml: Remove.
1456         * features/i386/amd64-linux.xml: Remove.
1457         * features/i386/amd64-mpx-linux.xml: Remove.
1458         * features/i386/amd64-mpx.xml: Remove.
1459         * features/i386/amd64.xml: Remove.
1460         * features/i386/i386-avx-avx512-linux.xml: Remove.
1461         * features/i386/i386-avx-avx512.xml: Remove.
1462         * features/i386/i386-avx-linux.xml: Remove.
1463         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1464         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1465         * features/i386/i386-avx-mpx-linux.xml: Remove.
1466         * features/i386/i386-avx-mpx.xml: Remove.
1467         * features/i386/i386-avx.xml: Remove.
1468         * features/i386/i386-linux.xml: Remove.
1469         * features/i386/i386-mmx-linux.xml: Remove.
1470         * features/i386/i386-mmx.xml: Remove.
1471         * features/i386/i386-mpx-linux.xml: Remove.
1472         * features/i386/i386-mpx.xml: Remove.
1473         * features/i386/i386.xml: Remove.
1474         * features/i386/x32-avx-avx512-linux.xml: Remove.
1475         * features/i386/x32-avx-linux.xml: Remove.
1476         * features/i386/x32-linux.xml: Remove.
1477
1478 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1479
1480         * regformats/aarch64.dat: Remove.
1481         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1482         * regformats/i386/amd64-avx-linux.dat: Remove.
1483         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1484         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1485         * regformats/i386/amd64-linux.dat: Remove.
1486         * regformats/i386/amd64-mpx-linux.dat: Remove.
1487         * regformats/i386/amd64.dat: Remove.
1488         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1489         * regformats/i386/i386-avx-linux.dat: Remove.
1490         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1491         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1492         * regformats/i386/i386-linux.dat: Remove.
1493         * regformats/i386/i386-mmx-linux.dat: Remove.
1494         * regformats/i386/i386-mpx-linux.dat: Remove.
1495         * regformats/i386/i386.dat: Remove.
1496         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1497         * regformats/i386/x32-avx-linux.dat: Remove.
1498         * regformats/i386/x32-linux.dat: Remove.
1499
1500 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1501
1502         * aarch64-tdep.c: Remove xml self tests.
1503         * amd64-linux-tdep.c: Likewise.
1504         * amd64-tdep.c: Likewise.
1505         * i386-linux-tdep.c: Likewise.
1506         * i386-tdep.c: Likewise.
1507
1508 2019-07-03  Pedro Alves  <palves@redhat.com>
1509
1510         PR cli/24732
1511         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1512         (pipe_cmd_option_defs): New.
1513         (make_pipe_cmd_options_def_group): New.
1514         (pipe_command): Use gdb::option::process_options.
1515         (pipe_command_completer): New function.
1516         (_initialize_cli_cmds): Install completer for "pipe" command.
1517
1518 2019-07-03  Pedro Alves  <palves@redhat.com>
1519
1520         * cli/cli-option.c (union option_value) <string>: New field.
1521         (struct option_def_and_value): Add ctor, move ctor, dtor and
1522         use DISABLE_COPY_AND_ASSIGN.
1523         (option_def_and_value::clear_value): New.
1524         (parse_option, save_option_value_in_ctx, get_val_type_str)
1525         (add_setshow_cmds_for_options): Handle var_string.
1526         * cli-option.h (union option_def::var_address) <string>: New
1527         field.
1528         (struct string_option_def): New.
1529         * maint-test-options.c (struct test_options_opts): Add default
1530         ctor and use DISABLE_COPY_AND_ASSIGN.
1531         <string_opt>: New field.
1532         (test_options_opts::~test_options_opts): New.
1533         (test_options_opts::dump): Also dump "-string".
1534         (test_options_option_defs): Install "string.
1535
1536 2019-07-03  Pedro Alves  <palves@redhat.com>
1537
1538         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1539         option_value with a null enumeration.
1540         (complete_options): Save the option values in the context.
1541         (save_option_value_in_ctx): New, factored out from ...
1542         (process_options): ... here.
1543         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1544         of the function.
1545         * maint-test-options.c (test_options_opts::dump): New, factored
1546         out from ...
1547         (maintenance_test_options_command_mode): ... here.
1548         (maintenance_test_options_command_completion_result): Delete.
1549         (maintenance_test_options_command_completion_text): Update
1550         comment.
1551         (maintenance_show_test_options_completion_result): Change
1552         prototype.  Just print
1553         maintenance_test_options_command_completion_text.
1554         (save_completion_result): New.
1555         (maintenance_test_options_completer_mode): Pass options context to
1556         complete_options, and then save a dump.
1557         (_initialize_maint_test_options): Use add_cmd to install "maint
1558         show test-options-completion-result".
1559
1560 2019-07-03  Pedro Alves  <palves@redhat.com>
1561
1562         * NEWS (New commands): Mention "with" and "maint with".
1563         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1564         (with_command, with_command_completer): New.
1565         (pipe_command): Adjust to new repeat_previous
1566         interface.
1567         (_initialize_cli_cmds): Install the "with" command and its "w"
1568         alias.
1569         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1570         declarations.
1571         * cli/cli-setshow.c (parse_cli_var_uinteger)
1572         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1573         argument strings for all var_types.
1574         (get_setshow_command_value_string): New, factored out from ...
1575         (do_show_command): ... this.
1576         * cli/cli-setshow.h: Include <string>.
1577         (get_setshow_command_value_string): Declare.
1578         * command.h (repeat_previous): Now returns const char *.  Adjust
1579         comment.
1580         * maint.c: Include "cli/cli-cmds.h".
1581         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1582         (_initialize_maint_cmds): Register the "maintenance with" command.
1583         * top.c (repeat_previous): Move bits from pipe_command here:
1584         Return the saved command line, if any; error out if there's no
1585         command to relaunch.
1586
1587 2019-07-03  Pedro Alves  <palves@redhat.com>
1588
1589         * NEWS (New commands): Mention "maint set/show test-settings"
1590         instead of "maint test-settings".
1591         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1592         (maintenance_test_settings_set_list): Rename to ...
1593         (maintenance_set_test_settings_list): ... this.
1594         (maintenance_test_settings_show_list): Rename to  ...
1595         (maintenance_show_test_settings_list): ... this.
1596         (maintenance_test_settings_cmd): Delete.
1597         (maintenance_test_settings_set_cmd): ...
1598         (maintenance_set_test_settings_cmd): ... this.
1599         (maintenance_test_settings_show_cmd): ...
1600         (maintenance_show_test_settings_cmd): ... this.
1601         (maintenance_test_settings_show_value_cmd):
1602         (maintenance_show_test_settings_value_cmd): ... this.
1603         (_initialize_maint_test_settings): No longer install the "maint
1604         test-settings" prefix command.  Rename "maint test-settings set"
1605         to "maint set test-settings", and "maint test-settings show" to
1606         "maint show test-settings".  Adjust all subcommands.
1607
1608 2019-07-03  Pedro Alves  <palves@redhat.com>
1609
1610         * maint-test-settings.c: Fix file's intro comment.  Replace all
1611         references to "test-options" with references to "test-settings",
1612         in comments.
1613
1614 2019-07-03  Pedro Alves  <palves@redhat.com>
1615
1616         * maint-test-settings.c (maintenance_test_settings_xxx)
1617         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1618         New.
1619         (maintenance_test_settings_enums): Use them.
1620         (maintenance_test_settings_enum): Default to
1621         maintenance_test_settings_xxx.
1622         (_initialize_maint_test_settings): Initialize
1623         MAINTENANCE_TEST_SETTINGS_FILENAME.
1624
1625 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1626
1627         * breakpoint.h (remove_breakpoints_inf): Change return type to
1628         void, move function documentation here.
1629         * breakpoint.c (remove_breakpoints_inf): Change return type to
1630         void, move function documentation to header.
1631
1632 2019-07-02  Pedro Alves  <palves@redhat.com>
1633
1634         * NEWS (Completion improvements): Mention "info threads".
1635         * thread.c (struct info_threads_opts, info_threads_option_defs)
1636         (make_info_threads_options_def_group): New.
1637         (info_threads_command): Use gdb::option::process_options.
1638         (info_threads_command_completer): New.
1639         (_initialize_thread): Use gdb::option::build_help to build the
1640         help text for "info threads".
1641
1642 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1643
1644         * defs.h (generic_load): Move from here...
1645         * symfile.h (generic_load): ... to here.  Rename name parameter
1646         to args.
1647         * symfile.c (generic_load): Add comment.
1648
1649 2019-07-01  Tom Tromey  <tromey@adacore.com>
1650
1651         * dwarf2read.c
1652         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1653         declaration of without_params.  Fix formatting.
1654
1655 2019-07-01  Tom Tromey  <tromey@adacore.com>
1656
1657         * ada-exp.y (find_primitive_type): Update.
1658         * ada-lang.h (ada_lookup_symbol): Update.
1659         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1660         parameter.
1661         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1662
1663 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1664
1665         PR breakpoints/24541
1666         * gdbarch.c: Regenerate.
1667         * gdbarch.h: Regenerate.
1668         * gdbarch.sh: Add 'stap_adjust_register'.
1669         * i386-tdep.c: Include '<unordered_set>'.
1670         (i386_stap_adjust_register): New function.
1671         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1672         * stap-probe.c (stap_parse_register_operand): Call
1673         'gdbarch_stap_adjust_register'.
1674
1675 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1676
1677         PR python/24742
1678         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1679         * python/python.c (do_start_initialization): Use 'xmalloc'
1680         instead of 'PyMem_Malloc'.
1681
1682 2019-06-28  Tom Tromey  <tromey@adacore.com>
1683
1684         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1685         for Ada.
1686
1687 2019-06-27  Tom Tromey  <tromey@adacore.com>
1688
1689         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1690         objfile_key.
1691         (arm_find_mapping_symbol, arm_record_special_symbol)
1692         (_initialize_arm_tdep): Update.
1693         (arm_objfile_data_free): Remove.
1694
1695 2019-06-27  Tom Tromey  <tromey@adacore.com>
1696
1697         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1698         to cp_print_static_field.
1699
1700 2019-06-26  Tom Tromey  <tromey@adacore.com>
1701
1702         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1703         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1704         declare.
1705
1706 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1707
1708         * features/aarch64-core.c (create_feature_aarch64_core):
1709         Regenerate.
1710         * features/aarch64-core.xml: Add cpsr flags.
1711
1712 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1713
1714         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1715         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1716
1717 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1718
1719         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1720         field.
1721         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1722         use.
1723         (arm_record_special_symbol): Don't insert new symbol in sorted
1724         position, push it at the end.
1725
1726 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1727
1728         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1729         (arm_mapping_symbol_s): Remove.
1730         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1731         (arm_mapping_symbol_vec): New typedef.
1732         (struct arm_per_objfile): Add constructor.
1733         <section_maps>: Change type to
1734         std::unique_ptr<arm_mapping_symbol_vec[]>.
1735         (arm_compare_mapping_symbols): Remove.
1736         (arm_find_mapping_symbol): Adjust to section_maps type change.
1737         (arm_objfile_data_free): Call delete on arm_per_objfile.
1738         (arm_record_special_symbol): Adjust to section_maps type change.
1739         Allocate arm_per_objfile with new.
1740
1741 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1742
1743         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1744         with the command prefix.
1745
1746 2019-06-25  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1749         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1750
1751 2019-06-25  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1754         type.
1755         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1756         protected.
1757
1758 2019-06-25  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-winsource.c
1761         (tui_source_window_base::set_is_exec_point_at): Add check against
1762         LOA_ADDRESS.
1763
1764 2019-06-25  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui-source.c (tui_set_source_content): Don't check before
1767         xfree.
1768         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1769
1770 2019-06-25  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-winsource.h (tui_update_source_window_as_is)
1773         (tui_alloc_source_buffer, tui_line_is_displayed)
1774         (tui_addr_is_displayed): Change type of win_info.
1775         * tui/tui-winsource.c (tui_update_source_window_as_is)
1776         (tui_clear_source_content, tui_show_source_line)
1777         (tui_show_source_content, tui_source_window_base::refill)
1778         (tui_source_window_base::set_is_exec_point_at)
1779         (tui_source_window_base::set_is_exec_point_at)
1780         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1781         (tui_alloc_source_buffer, tui_line_is_displayed)
1782         (tui_addr_is_displayed): Change type of win_info.  Update.
1783         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1784         (tui_source_window_base::do_make_visible_with_new_height):
1785         Update.
1786         * tui/tui-source.c (tui_set_source_content)
1787         (tui_set_source_content_nil)
1788         (tui_source_window::do_scroll_vertical): Update.
1789         * tui/tui-layout.c (show_layout): Update.
1790         * tui/tui-disasm.c (tui_set_disassem_content)
1791         (tui_disasm_window::do_scroll_vertical): Update.
1792         * tui/tui-data.h (tui_win_content): Remove.
1793         (struct tui_gen_win_info) <content, content_size>: Remove.
1794         (struct tui_source_element): Add initializers and destructor.
1795         (union tui_which_element, struct tui_win_element): Remove.
1796         (struct tui_source_window_base) <content>: New field.
1797         (struct tui_data_window): Remove destructor.
1798         (tui_alloc_content, tui_free_win_content)
1799         (tui_free_all_source_wins_content): Don't declare.
1800         * tui/tui-data.c (tui_initialize_static_data): Update.
1801         (init_content_element, tui_alloc_content): Remove.
1802         (~tui_gen_win_info): Update.
1803         (~tui_data_window, tui_free_all_source_wins_content)
1804         (tui_free_win_content, free_content, free_content_elements):
1805         Remove.
1806
1807 2019-06-25  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-winsource.h (tui_clear_source_content)
1810         (tui_erase_source_content, tui_show_source_content): Change type
1811         of win_info.
1812         * tui/tui-winsource.c (tui_clear_source_content)
1813         (tui_erase_source_content, tui_show_source_content): Change type
1814         of win_info.
1815         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1816         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1817         win_info.
1818         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1819         win_info.
1820         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1821
1822 2019-06-25  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui-winsource.c (tui_clear_source_content)
1825         (tui_source_window_base::set_is_exec_point_at): Update.
1826         * tui/tui-source.c (tui_set_source_content_nil): Update.
1827         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1828         a bool.
1829         * tui/tui-data.c (init_content_element): Update.
1830
1831 2019-06-25  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1834         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1835         * tui/tui-layout.c (init_and_make_win): Update.
1836         * tui/tui.h (enum tui_win_type): Update.
1837         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1838         tui_win_is_auxillary.
1839         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1840         tui_win_is_auxillary.
1841
1842 2019-06-25  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1845         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1846         (tui_delete_data_content_windows, tui_display_all_data)
1847         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1848         Update.
1849         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1850         * tui/tui-regs.c (tui_last_regs_line_no)
1851         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1852         (tui_show_registers): Update.
1853         (tui_show_register_group): Return void.  Update.
1854         (tui_display_registers_from, tui_display_reg_element_at_line)
1855         (tui_display_registers_from_line, tui_check_register_values):
1856         Update.
1857         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1858         member.
1859         (struct tui_data_window) <regs_content>: Now a std::vector.
1860         <regs_content_count>: Remove.
1861         (tui_add_content_elements, tui_free_data_content): Don't declare.
1862         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1863         (init_content_element): Remove DATA_WIN case.  Add assert.
1864         (tui_add_content_elements): Remove.
1865         (tui_data_window): Update.
1866         (tui_free_data_content): Remove.
1867         (free_content_elements): Remove DATA_WIN case.
1868
1869 2019-06-25  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-data.c (tui_data_item_window): Update.
1872         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1873         * tui/tui-windata.c (tui_display_all_data)
1874         (tui_display_data_from_line): Update.
1875         (tui_check_data_values): Remove.
1876         * tui/tui-regs.c (tui_show_register_group)
1877         (tui_display_reg_element_at_line): Update.
1878         * tui/tui-hooks.c (tui_register_changed)
1879         (tui_refresh_frame_and_register_information): Call
1880         tui_check_register_values.
1881         * tui/tui-data.h (struct tui_data_window) <data_content,
1882         data_content_count, data_type>: Remove.
1883         (enum tui_data_type): Remove.
1884
1885         * tui/tui-data.c (tui_data_window::clear_detail)
1886         (~tui_data_window): Update.
1887
1888 2019-06-25  Tom Tromey  <tom@tromey.com>
1889
1890         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1891         declare.
1892         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1893         Rename from tui_first_data_item_displayed.  Update.
1894         (tui_data_window::refresh_all)
1895         (tui_data_window::do_scroll_vertical): Update.
1896         * tui/tui-data.h (struct tui_data_window)
1897         <first_data_item_displayed>: Declare new method.
1898
1899 2019-06-25  Tom Tromey  <tom@tromey.com>
1900
1901         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1902         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1903         contents...
1904         (tui_initialize_static_data): ...here.
1905
1906 2019-06-25  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1909         (tui_display_registers_from, tui_check_register_values): Update.
1910         (tui_display_register): Remove win_info parameter; update.
1911         (tui_get_register): Change type of parameters.
1912         * tui/tui-data.h (struct tui_data_element): Remove.
1913         (union tui_which_element) <data>: Remove.
1914         <data_window>: Change type.
1915         (struct tui_data_item_window): New.
1916         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1917         case.  Add assert.
1918         (~tui_data_item_window): New destructor.
1919         (free_content_elements): Remove DATA_ITEM_WIN case.
1920
1921 2019-06-25  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1924         Remove.
1925
1926 2019-06-25  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-data.h (struct tui_command_element): Remove.
1929         (union tui_which_element) <command>: Remove.
1930         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1931         assert.
1932         (free_content_elements): Remove CMD_WIN case.
1933
1934 2019-06-25  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-layout.c (tui_set_layout): Update.
1937         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1938         * tui/tui-data.c (layout_def): Update.
1939
1940 2019-06-25  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1943         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1944         (tui_source_window_base::set_new_height): Update.
1945         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1946         Update.
1947         (tui_set_locator_fullname, tui_set_locator_info)
1948         (tui_show_frame_info): Update.
1949         * tui/tui-source.c (tui_set_source_content)
1950         (tui_source_is_displayed): Update.
1951         * tui/tui-layout.c (show_source_disasm_command, show_data)
1952         (show_source_or_disasm_and_command): Update.
1953         * tui/tui-disasm.c (tui_set_disassem_content)
1954         (tui_get_begin_asm_address): Update.
1955         * tui/tui-data.h (struct tui_locator_element): Remove.
1956         (union tui_which_element) <locator>: Remove.
1957         (struct tui_locator_window): New.
1958         (tui_locator_win_info_ptr): Change return type.
1959         * tui/tui-data.c (_locator): Change type.
1960         (tui_locator_win_info_ptr): Change return type.
1961         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1962         (tui_alloc_content): Add assert.
1963
1964 2019-06-25  Tom Tromey  <tom@tromey.com>
1965
1966         * tui/tui-winsource.c
1967         (tui_exec_info_window::maybe_allocate_content): New method.
1968         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1969         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1970         (make_source_or_disasm_window): Add cast.
1971         * tui/tui-data.h (union tui_which_element) <simple_string>:
1972         Remove.
1973         (struct tui_source_info): New.
1974         (struct tui_source_window_base) <execution_info>: Change type.
1975         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1976         case, and add assert.
1977         (tui_alloc_content): Add assert.
1978
1979 2019-06-25  Tom Tromey  <tom@tromey.com>
1980
1981         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1982         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1983         * tui/tui-data.c (tui_alloc_win_info): Remove.
1984
1985 2019-06-25  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1988         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1989         can_highlight.
1990
1991 2019-06-25  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1994         make_visible_with_new_height method.
1995         (tui_win_info::make_visible_with_new_height): New method.
1996         (tui_source_window_base::do_make_visible_with_new_height)
1997         (tui_data_window::do_make_visible_with_new_height)
1998         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1999         (make_visible_with_new_height): Remove.
2000         (tui_resize_all, tui_adjust_win_heights): Use
2001         make_visible_with_new_height method.
2002         * tui/tui-data.h (struct tui_win_info)
2003         <do_make_visible_with_new_height, make_visible_with_new_height>:
2004         New methods.
2005         (struct tui_source_window_base, struct tui_data_window)
2006         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2007         methods.
2008
2009 2019-06-25  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2012         method.
2013         (update_tab_width): Call update_tab_width method.
2014         * tui/tui-data.h (struct tui_win_info)
2015         (struct tui_source_window_base) <update_tab_width>: New methods.
2016
2017 2019-06-25  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2020         parameter.
2021         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2022         parameter.
2023         (tui_gen_win_info::make_visible): Update.
2024         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2025         parameter.
2026         * tui/tui-data.h (enum tui_box): New enum.
2027         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2028
2029 2019-06-25  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2032         init_and_make_win for EXEC_INFO_WIN.
2033         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2034         longer inline.
2035         (struct tui_win_info) <~tui_win_info>: Inline.
2036         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2037         Don't declare.
2038         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2039         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2040         Remove.
2041         (tui_initialize_static_data): Update.
2042         (~tui_gen_win_info): Handle more cleanup here.
2043         (~tui_source_window_base): Delete "execution_info".
2044         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2045
2046 2019-06-25  Tom Tromey  <tom@tromey.com>
2047
2048         * tui/tui-layout.c (make_command_window): Don't set
2049         can_highlight.
2050         (show_source_disasm_command): Call the reset method.
2051         (show_data): Don't set can_highlight.  Call the reset method.
2052         (tui_gen_win_info::reset): Rename from init_gen_win_info
2053         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2054         (show_source_or_disasm_and_command): Call the reset method.
2055         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2056         (struct tui_cmd_window): Set can_highlight.
2057
2058 2019-06-25  Tom Tromey  <tom@tromey.com>
2059
2060         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2061         from make_visible.
2062         (tui_make_visible, tui_make_invisible): Rewrite.
2063         (tui_win_info::make_visible): Remove.
2064         (tui_source_window_base::make_visible): Update.
2065         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2066         method.  Moved from...
2067         (struct tui_win_info) <make_visible>: ...here.
2068
2069 2019-06-25  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-winsource.c
2072         (tui_source_window_base::do_scroll_horizontal): Remove direction
2073         parameter.
2074         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2075         direction parameter.
2076         * tui/tui-win.c (tui_win_info::forward_scroll)
2077         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2078         (tui_win_info::right_scroll): Update.
2079         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2080         direction parameter.
2081         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2082         direction parameter.
2083         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2084         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2085         Remove direction parameter.
2086         (struct tui_source_window_base, struct tui_source_window)
2087         (struct tui_disasm_window, struct tui_data_window)
2088         (struct tui_cmd_window): Update.
2089
2090 2019-06-25  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-winsource.h (tui_set_exec_info_content)
2093         (tui_show_exec_info_content, tui_erase_exec_info_content)
2094         (tui_clear_exec_info_content, tui_update_exec_info): Change
2095         argument to tui_source_window_base.
2096         * tui/tui-winsource.c (tui_set_exec_info_content)
2097         (tui_show_exec_info_content, tui_erase_exec_info_content)
2098         (tui_clear_exec_info_content, tui_update_exec_info): Change
2099         argument to tui_source_window_base.
2100
2101 2019-06-25  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2104         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2105
2106 2019-06-25  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2109         check.
2110
2111 2019-06-25  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2114         type to void.
2115         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2116         type to void.
2117         * tui/tui-source.c (tui_set_source_content): Update.
2118         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2119
2120 2019-06-25  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-win.c (window_name_completer, tui_set_focus)
2123         (tui_all_windows_info): Use name method.
2124         * tui/tui-data.h (struct tui_gen_win_info)
2125         (struct tui_source_window, struct tui_disasm_window)
2126         (struct tui_data_window, struct tui_cmd_window) <name>: New
2127         method.
2128         (tui_win_name): Don't declare.
2129         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2130         (tui_win_name): Remove.
2131
2132 2019-06-25  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-winsource.h (tui_update_source_window)
2135         (tui_update_source_window_as_is): Change parameter type.
2136         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2137         to be a tui_source_window_base.
2138         (tui_update_source_window_as_is): Likewise.
2139         * tui/tui-win.c (make_visible_with_new_height): Update.
2140
2141 2019-06-25  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-winsource.c (tui_erase_source_content)
2144         (tui_show_source_content, tui_show_exec_info_content)
2145         (tui_erase_exec_info_content): Use refresh_window method.
2146         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2147         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2148         from tui_refresh_win.
2149         (tui_data_window::refresh_window): New method.
2150         (tui_win_info::refresh, tui_source_window_base::refresh)
2151         (tui_refresh_all): Use refresh_window method.
2152         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2153         method.
2154         * tui/tui-regs.c (tui_display_register): Call refresh_window
2155         method.
2156         * tui/tui-layout.c (show_source_disasm_command)
2157         (show_source_or_disasm_and_command): Call refresh_window method.
2158         * tui/tui-data.h (struct tui_gen_win_info)
2159         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2160         New method.
2161
2162 2019-06-25  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui.c (tui_rl_other_window, tui_enable)
2165         (tui_is_window_visible, tui_get_command_dimension): Update.
2166         * tui/tui-winsource.c (tui_update_source_window_as_is)
2167         (tui_clear_source_content, tui_erase_source_content)
2168         (tui_show_source_line, tui_source_window_base::refill)
2169         (tui_source_window_base::do_scroll_horizontal)
2170         (tui_source_window_base::set_is_exec_point_at)
2171         (tui_update_breakpoint_info, tui_set_exec_info_content)
2172         (tui_alloc_source_buffer, tui_line_is_displayed)
2173         (tui_addr_is_displayed): Update.
2174         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2175         (tui_check_and_display_highlight_if_needed)
2176         (tui_win_info::make_visible, tui_win_info::refresh)
2177         (tui_refresh_all): Update.
2178         * tui/tui-windata.c (tui_first_data_item_displayed)
2179         (tui_delete_data_content_windows, tui_erase_data_content)
2180         (tui_display_all_data, tui_data_window::refresh_all)
2181         (tui_check_data_values): Update.
2182         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2183         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2184         (tui_win_info::backward_scroll, tui_refresh_all_win)
2185         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2186         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2187         (tui_source_window_base::set_new_height)
2188         (tui_data_window::set_new_height)
2189         (make_invisible_and_set_new_height)
2190         (make_visible_with_new_height, new_height_ok)
2191         (parse_scrolling_args): Update.
2192         * tui/tui-stack.c (tui_show_frame_info): Update.
2193         * tui/tui-source.c (tui_set_source_content)
2194         (tui_set_source_content_nil, tui_source_is_displayed)
2195         (tui_source_window::do_scroll_vertical): Update.
2196         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2197         (tui_display_registers_from, tui_display_reg_element_at_line)
2198         (tui_check_register_values, tui_reg_command): Update.
2199         * tui/tui-layout.c (tui_default_win_height)
2200         (show_source_disasm_command, show_data, init_and_make_win)
2201         (show_source_or_disasm_and_command): Update.
2202         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2203         (tui_redisplay_readline, tui_mld_flush)
2204         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2205         (tui_getc): Update.
2206         * tui/tui-disasm.c (tui_set_disassem_content)
2207         (tui_disasm_window::do_scroll_vertical): Update.
2208         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2209         Now virtual.
2210         (struct tui_win_info): Derive from tui_gen_win_info.
2211         <~tui_win_info>: Mark as override.
2212         <generic>: Remove member.
2213         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2214         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2215         (~tui_data_window, ~tui_win_info)
2216         (tui_free_all_source_wins_content): Update.
2217         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2218
2219 2019-06-25  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-layout.c (init_and_make_win): Use new.
2222         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2223         destructor, initializers.
2224         (tui_alloc_generic_win_info): Don't declare.
2225         * tui/tui-data.c (_locator): Add argument to constructor.
2226         (source_win, disasm_win): New globals.
2227         (exec_info): Remove.
2228         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2229         Update.
2230         (tui_alloc_generic_win_info): Remove.
2231         (init_content_element): Use new.
2232         (tui_win_info::tui_win_info): Update.
2233         (free_content_elements) <case DATA_WIN>: Use delete.
2234
2235 2019-06-25  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2238         * tui/tui-windata.c (tui_first_data_item_displayed)
2239         (tui_delete_data_content_windows): Update.
2240         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2241         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2242         (tui_display_registers_from, tui_check_register_values): Update.
2243         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2244         pointer.
2245         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2246         window.
2247         (tui_free_data_content): Update.
2248         (free_content_elements) <case DATA_WIN>: Free the window.
2249
2250 2019-06-25  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2253         Update.
2254         * tui/tui-layout.c (make_command_window)
2255         (show_source_disasm_command, show_data, init_and_make_win)
2256         (show_source_or_disasm_and_command): Update.
2257         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2258         method.
2259         <can_highight, is_highlighted>: Now bool.
2260         (tui_set_win_highlight): Don't declare.
2261         * tui/tui-data.c (tui_set_win_highlight): Remove.
2262
2263 2019-06-25  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-wingeneral.c (make_visible): Remove check of window
2266         type.
2267
2268 2019-06-25  Tom Tromey  <tom@tromey.com>
2269
2270         * tui/tui-win.c (tui_win_info::max_height)
2271         (tui_cmd_window::max_height): New methods.
2272         (new_height_ok): Call max_height.
2273         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2274         <max_height>: New method.
2275
2276 2019-06-25  Tom Tromey  <tom@tromey.com>
2277
2278         * tui/tui-win.c (tui_source_window_base::set_new_height)
2279         (tui_data_window::set_new_height): New methods.
2280         (make_invisible_and_set_new_height): Call set_new_height method.
2281         * tui/tui-data.h (struct tui_win_info)
2282         (struct tui_source_window_base, struct tui_data_window)
2283         <set_new_height>: New method.
2284
2285 2019-06-25  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2288         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2289         tui_refresh_data_win.
2290         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2291         method.
2292         (tui_refresh_all_win): Call the refresh_all method.
2293         (tui_set_focus): Likewise.
2294         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2295         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2296         Likewise.
2297
2298 2019-06-25  Tom Tromey  <tom@tromey.com>
2299
2300         * tui/tui-winsource.h (tui_refill_source_window)
2301         (tui_set_is_exec_point_at): Don't declare.
2302         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2303         (tui_source_window_base::refill): Rename from
2304         tui_refill_source_window.
2305         (tui_source_window_base::do_scroll_horizontal): Update.
2306         (tui_source_window_base::set_is_exec_point_at): Rename from
2307         tui_set_is_exec_point_at.
2308         (tui_update_all_breakpoint_info): Update.
2309         * tui/tui-stack.c (tui_show_frame_info): Update.
2310         * tui/tui-layout.c (show_data): Add cast.
2311         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2312         * tui/tui-data.h (struct tui_source_window_base) <refill,
2313         set_is_exec_point_at>: New methods.
2314         (tui_source_windows, tui_add_to_source_windows): Update types.
2315         (tui_add_to_source_windows): Remove redundant declaration.
2316         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2317         (tui_source_windows): Change return type.
2318         (tui_clear_source_windows_detail): Update.
2319         (tui_add_to_source_windows): Change type of parameter.
2320         (tui_free_all_source_wins_content): Update.
2321
2322 2019-06-25  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui-wingeneral.c (tui_win_info::refresh)
2325         (tui_source_window_base::refresh): New methods.
2326         (tui_refresh_all): Call the refresh method.
2327         * tui/tui-data.h (struct tui_win_info)
2328         (struct tui_source_window_base) <refresh>: New method.
2329
2330 2019-06-25  Tom Tromey  <tom@tromey.com>
2331
2332         * tui/tui.h (tui_is_window_visible): Return bool.
2333         * tui/tui.c (tui_is_window_visible): Return bool.
2334         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2335         (tui_make_visible, tui_make_invisible)
2336         (tui_win_info::make_visible)
2337         (tui_source_window_base::make_visible, make_all_visible)
2338         (tui_make_all_visible, tui_make_all_invisible): Update.
2339         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2340         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2341         bool.
2342         (struct tui_win_info, struct tui_source_window_base)
2343         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2344         * tui/tui-data.c (tui_init_generic_part): Update.
2345
2346 2019-06-25  Tom Tromey  <tom@tromey.com>
2347
2348         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2349         (tui_source_window_base::make_visible): New methods.
2350         (make_all_visible): Make method call.
2351         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2352         (struct tui_source_window_base, struct tui_cmd_window): Override
2353         make_visible.
2354         (tui_win_is_source_type): Don't declare.
2355         * tui/tui-data.c (tui_win_is_source_type): Remove.
2356
2357 2019-06-25  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2360         NULL check.
2361
2362 2019-06-25  Tom Tromey  <tom@tromey.com>
2363
2364         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2365         Inline constructor.  Add initializers for members.
2366         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2367         constructors; now inline in class.
2368
2369 2019-06-25  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-regs.c (tui_show_registers): Update.
2372         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2373         bool.
2374         * tui/tui-data.c (tui_data_window::clear_detail)
2375         (tui_data_window): Update.
2376
2377 2019-06-25  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-windata.c (tui_display_all_data)
2380         (tui_display_data_from_line, tui_display_data_from)
2381         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2382         Update.
2383         * tui/tui-regs.c (tui_last_regs_line_no)
2384         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2385         (tui_show_registers, tui_show_register_group)
2386         (tui_display_registers_from, tui_display_reg_element_at_line)
2387         (tui_display_registers_from_line, tui_check_register_values)
2388         (tui_reg_next, tui_reg_prev): Update.
2389         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2390         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2391         tui_data_window.
2392         (struct tui_win_info) <detail>: Remove.  Add new fields from
2393         tui_data_info.
2394         (TUI_DATA_WIN): Add cast.
2395         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2396         (~tui_data_window): Simplify.
2397
2398 2019-06-25  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-layout.c (show_source_disasm_command)
2401         (show_source_or_disasm_and_command): Update.
2402         * tui/tui-io.c (update_cmdwin_start_line)
2403         (tui_redisplay_readline): Update.
2404         * tui/tui-data.h (struct tui_command_info): Remove.
2405         (struct tui_win_info) <detail>: Remove command_info member.
2406         (struct tui_data_window) <start_line>: New member, from
2407         tui_command_info.
2408         (TUI_CMD_WIN): Add casts.
2409
2410 2019-06-25  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-winsource.c (tui_update_source_window)
2413         (tui_refill_source_window)
2414         (tui_source_window_base::do_scroll_horizontal)
2415         (tui_update_breakpoint_info, tui_set_exec_info_content)
2416         (tui_show_exec_info_content, tui_erase_exec_info_content)
2417         (tui_clear_exec_info_content): Update.
2418         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2419         Update.
2420         * tui/tui-win.c (make_invisible_and_set_new_height)
2421         (make_visible_with_new_height): Update.
2422         * tui/tui-source.c (tui_set_source_content)
2423         (tui_show_symtab_source): Update.
2424         * tui/tui-layout.c (extract_display_start_addr)
2425         (show_source_disasm_command, show_data)
2426         (make_source_or_disasm_window)
2427         (show_source_or_disasm_and_command): Update.
2428         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2429         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2430         "gdbarch".
2431         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2432         to tui_source_window_base.
2433         (struct tui_win_info) <detail>: Remove source_info member.
2434         (struct tui_source_window_base) <has_locator>: Inline.
2435         Move contents from tui_source_info; rename has_locator member to
2436         m_has_locator.
2437         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2438         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2439         header file.
2440         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2441         Simplify.
2442         (tui_free_all_source_wins_content): Cast to
2443         tui_source_window_base.
2444
2445 2019-06-25  Tom Tromey  <tom@tromey.com>
2446
2447         * tui/tui-win.c (make_invisible_and_set_new_height)
2448         (make_visible_with_new_height): Call has_locator method.
2449         * tui/tui-layout.c (show_source_disasm_command, show_data)
2450         (show_source_or_disasm_and_command): Update for bool change.
2451         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2452         (tui_win_info) <has_locator>: New method.
2453         (struct tui_source_window_base) <has_locator>: New method.
2454         (tui_win_has_locator): Don't declare.
2455         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2456         from tui_win_has_locator.
2457         (tui_source_window_base): Use false, not FALSE.
2458
2459 2019-06-25  Tom Tromey  <tom@tromey.com>
2460
2461         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2462         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2463         clear_detail method directly.
2464         (tui_clear_win_detail): Remove.
2465
2466 2019-06-25  Tom Tromey  <tom@tromey.com>
2467
2468         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2469         "this", not TUI_DISASM_WIN.
2470
2471 2019-06-25  Tom Tromey  <tom@tromey.com>
2472
2473         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2474         declare.
2475         * tui/tui-winsource.c
2476         (tui_source_window_base::do_scroll_horizontal): Rename from
2477         tui_horizontal_source_scroll.
2478         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2479         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2480         from tui_vertical_data_scroll.
2481         * tui/tui-win.h (tui_scroll): Don't declare.
2482         * tui/tui-win.c (tui_win_info::forward_scroll)
2483         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2484         (tui_win_info::right_scroll): Rename and update.
2485         (tui_scroll_forward_command, tui_scroll_backward_command)
2486         (tui_scroll_left_command, tui_scroll_right_command): Update.
2487         (tui_scroll): Remove.
2488         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2489         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2490         from tui_vertical_source_scroll.
2491         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2492         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2493         from tui_vertical_disassem_scroll.
2494         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2495         do_scroll_horizontal>: New methods.
2496         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2497         Likewise.
2498         (struct tui_source_window_base): Add do_scroll_horizontal.
2499         (struct tui_source_window, struct tui_disasm_window): Add
2500         do_scroll_vertical.
2501         (struct tui_data_window, struct tui_cmd_window): Add
2502         do_scroll_horizontal and do_scroll_vertical.
2503         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2504
2505 2019-06-25  Tom Tromey  <tom@tromey.com>
2506
2507         * tui/tui-data.h (struct tui_source_window_base): New struct.
2508         (struct tui_source_window): Derive from tui_source_window_base.
2509         (struct tui_disasm_window): New struct.
2510         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2511         from tui_source_window::clear_detail.
2512         (tui_source_window_base): Rename from tui_source_window.
2513         (~tui_source_window_base): Rename from ~tui_source_window.
2514         (tui_alloc_win_info): Create a tui_disasm_window.
2515
2516 2019-06-25  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-data.h (struct tui_source_window)
2519         (struct tui_data_window): Declare destructors.
2520         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2521         destructors.
2522         (tui_win_info): Simplify.
2523
2524 2019-06-25  Tom Tromey  <tom@tromey.com>
2525
2526         * tui/tui-winsource.c (tui_display_main)
2527         (tui_update_source_windows_with_addr)
2528         (tui_update_all_breakpoint_info): Update.
2529         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2530         (new_height_ok, parse_scrolling_args): Update.
2531         * tui/tui-stack.c (tui_show_frame_info): Update.
2532         * tui/tui-data.h (struct tui_list): Remove.
2533         (tui_source_windows): Return a reference to a std::vector.
2534         * tui/tui-data.c (source_windows): Now a std::vector.
2535         (tui_source_windows): Change return type.
2536         (tui_clear_source_windows): Rewrite.
2537         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2538         (tui_free_all_source_wins_content): Rewrite.
2539
2540 2019-06-25  Tom Tromey  <tom@tromey.com>
2541
2542         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2543         (struct tui_data_window, struct tui_cmd_window): Declare
2544         clear_detail method.
2545         * tui/tui-data.c (tui_source_window::clear_detail)
2546         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2547         methods.
2548         (tui_clear_win_detail): Simplify.
2549
2550 2019-06-25  Tom Tromey  <tom@tromey.com>
2551
2552         * tui/tui-layout.c (make_source_window, make_disasm_window)
2553         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2554         Return the new window.
2555         (show_source_disasm_command, show_data)
2556         (show_source_or_disasm_and_command): Update.
2557
2558 2019-06-25  Tom Tromey  <tom@tromey.com>
2559
2560         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2561         parameter.  Return the new window.
2562         (show_source_disasm_command): Update and remove NULL check.
2563         (show_source_or_disasm_and_command): Update.
2564
2565 2019-06-25  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2568
2569 2019-06-25  Tom Tromey  <tom@tromey.com>
2570
2571         * tui/tui-data.h (struct tui_win_info): Make constructor
2572         protected.  Make destructor virtual.  Add initializers.
2573         (tui_source_window, tui_data_window, tui_cmd_window): New
2574         classes.
2575         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2576         constructor.  Add "type" parameter.
2577         (tui_source_window, tui_data_window, tui_cmd_window): New
2578         constructors.
2579         (tui_alloc_win_info): Instantiate the appropriate subclass.
2580
2581 2019-06-25  Tom Tromey  <tom@tromey.com>
2582
2583         * tui/tui-win.c (tui_resize_all): Use delete.
2584         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2585         destructor.
2586         (tui_free_window): Don't declare.
2587         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2588         Update.
2589
2590 2019-06-25  Tom Tromey  <tom@tromey.com>
2591
2592         * tui/tui-data.h (struct tui_win_info): Add constructor.
2593         * tui/tui-data.c (tui_alloc_win_info): Use new.
2594         (tui_free_window): Use delete.
2595
2596 2019-06-22  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2599         declare.
2600         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2601
2602 2019-06-22  Tom Tromey  <tom@tromey.com>
2603
2604         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2605         declare.
2606         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2607
2608 2019-06-22  Tom de Vries  <tdevries@suse.de>
2609
2610         * dwarf2read.c (create_addrmap_from_aranges)
2611         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2612         instead of '%zu'.
2613
2614 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2615
2616         * dwarf2read.h (dwarf2_section_info_def): Remove.
2617         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2618         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2619         std::vector<dwarf2_section_info>.
2620         (struct dwo_file) <~dwo_file>: Remove.
2621         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2622         types field.
2623         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2624         (dwarf2_read_debug_names): Likewise.
2625         (create_debug_types_hash_table): Change parameter type to
2626         array_view, adjust code accordingly.
2627         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2628         (partial_die_info::fixup): Likewise.
2629         (determine_prefix): Likewise.
2630         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2631
2632 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2633
2634         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2635         gdb_bfd_ref_ptr.
2636         <~dwo_file>: Remove call to gdb_bfd_unref.
2637         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2638         gdb_bfd_ref_ptr::get.
2639
2640 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2641
2642         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2643         type to htab_up.
2644         * dwarf2read.c (struct dwo_file): Initialize fields.
2645         <~dwo_file>: New.
2646         (free_dwo_file): Remove, move content to ~dwo_file.
2647         (struct dwo_file_deleter): Remove.
2648         (dwo_file_up>: Remove custom deleter.
2649         (free_dwo_files): Remove.
2650         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2651         dwo_files.
2652         (process_skeletonless_type_units): Call unique_ptr::get.
2653         (allocate_dwo_file_hash_table): Add deleter to created hash
2654         table.  Change return type to htab_up.
2655         (lookup_dwo_file_slot): Don't memset dwo_file, call
2656         unique_ptr::get.
2657         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2658         (create_dwo_unit_in_dwp_v2): Likewise.
2659         (open_and_init_dwo_file): Likewise.
2660         (free_dwo_file_from_slot): Remove.
2661
2662 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2663
2664         * dwarf2read.h (struct dwarf2_section_info) <readin,
2665         is_virtual>: Change type to bool.
2666         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2667         true instead of 1.
2668
2669 2019-06-19  Tom Tromey  <tom@tromey.com>
2670
2671         * tui/tui-data.h (tui_init_content_element): Don't declare.
2672
2673 2019-06-19  Tom Tromey  <tom@tromey.com>
2674
2675         * tui/tui-data.h (tui_init_win_info): Don't declare.
2676
2677 2019-06-19  Tom de Vries  <tdevries@suse.de>
2678
2679         * dwarf2read.h (abstract_to_concrete): Change type to
2680         std::unordered_map<sect_offset, std::vector<sect_offset>,
2681         gdb::hash_enum<sect_offset>>.
2682
2683 2019-06-19  Tom Tromey  <tromey@adacore.com>
2684
2685         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2686         EVAL_AVOID_SIDE_EFFECTS specially.
2687
2688 2019-06-19  Tom Tromey  <tromey@adacore.com>
2689
2690         * source-cache.c (highlighter): New global.
2691         (source_cache::get_source_lines): Create a highlighter on demand.
2692
2693 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2694
2695         * defs.h (deprecated_interactive_hook): Delete declaration.
2696         * interps.c (clear_interpreter_hooks): Remove use of
2697         deprecated_interactive_hook.
2698         * top.c (deprecated_interactive_hook): Delete definition.
2699         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2700
2701 2019-06-18  Tom de Vries  <tdevries@suse.de>
2702
2703         PR gdb/24515
2704         * dwarf2read.h (abstract_to_concrete): Change type from
2705         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2706         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2707         * dwarf2read.c (read_variable): Update.
2708         (dwarf2_fetch_die_loc_sect_off): Update.
2709
2710 2019-06-17  Tom de Vries  <tdevries@suse.de>
2711
2712         PR gdb/24617
2713         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2714         accessing parent[parent_len - 1].
2715
2716 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2717
2718         PR gdb/24364
2719         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2720         call dtrace_process_dof with NULL dof.
2721
2722 2019-06-16  Tom de Vries  <tdevries@suse.de>
2723
2724         PR gdb/24445
2725         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2726
2727 2019-06-16  Tom Tromey  <tom@tromey.com>
2728
2729         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2730         (make_all_visible): Use address of member.
2731
2732 2019-06-16  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2735         (tui_free_window, free_content, free_content_elements): Remove
2736         unnecessary cast.
2737         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2738         cast.
2739         * tui/tui-regs.c (tui_show_register_group)
2740         (tui_display_registers_from, tui_display_reg_element_at_line):
2741         Remove unnecessary cast.
2742
2743 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2744
2745         * linux-nat.c (normal_mask): Delete.
2746         (_initialize_linux_nat): Don't initialise normal_mask.
2747
2748 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2749
2750         PR gdb/24445
2751         * dwarf-index-write.h (write_psymtabs_to_index): Add
2752         dwz_basename parameter.
2753         * dwarf-index-write.c (write_gdbindex): Move file writing to
2754         write_gdbindex_1.  Change return type void.
2755         (assert_file_size): Move up, remove filename parameter.
2756         (write_gdbindex_1): New function.
2757         (write_debug_names): Change return type to void, call
2758         assert_file_size.
2759         (struct index_wip_file): New struct.
2760         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2761         file logic to index_wip_file.  Write index for dwz file if
2762         needed.
2763         (save_gdb_index_command): Pass basename of dwz file, if present.
2764         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2765         build-id of dwz file, if present.
2766         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2767         (dwarf2_get_dwz_file): Likewise.
2768         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2769         (dwarf2_get_dwz_file): Likewise.
2770
2771 2019-06-16  Tom Tromey  <tom@tromey.com>
2772
2773         * coffread.c (process_coff_symbol): Use xstrdup.
2774         * value.c (create_internalvar): Use xstrdup.
2775
2776 2019-06-16  Tom Tromey  <tom@tromey.com>
2777
2778         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2779         * breakpoint.c (stopin_command, stopat_command)
2780         (until_break_command, decode_location_default): Remove unnecessary
2781         cast.
2782         * utils.c (subset_compare): Remove unnecessary cast.
2783         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2784         cast.
2785         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2786         cast.
2787         * infcmd.c (path_command): Remove unnecessary cast.
2788         * coffread.c (decode_type): Remove unnecessary cast.
2789         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2790         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2791         * tui/tui-stack.c (tui_show_locator_content)
2792         (tui_show_frame_info): Remove unnecessary cast.
2793         * tui/tui-win.c (tui_scroll_forward_command)
2794         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2795         (parse_scrolling_args): Remove unnecessary cast.
2796         * tui/tui-data.c (init_win_info, tui_del_window)
2797         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2798         (free_content_elements): Remove unnecessary cast.
2799         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2800         unnecessary cast.
2801         * tui/tui-source.c (tui_set_source_content)
2802         (tui_vertical_source_scroll): Remove unnecessary cast.
2803         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2804         cast.
2805         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2806         * tui/tui-regs.c (tui_display_registers_from)
2807         (tui_display_register): Remove unnecessary cast.
2808         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2809         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2810         (make_visible): Remove unnecessary cast.
2811         * tui/tui-winsource.c (tui_erase_source_content)
2812         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2813         unnecessary cast.
2814         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2815         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2816         * stabsread.c (read_type, read_array_type, read_range_type):
2817         Remove unnecessary cast.
2818         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2819         (parse_symbol, parse_type, upgrade_type, parse_external)
2820         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2821         unnecessary cast.
2822         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2823
2824 2019-06-16  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-data.c (tui_alloc_generic_win_info)
2827         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2828         checks.
2829
2830 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2831             Andrew Burgess  <andrew.burgess@embecosm.com>
2832
2833         * f-typeprint.c (f_print_type): Don't return early for not
2834         associated or not allocated types.
2835         (f_type_print_varspec_suffix): Add print_rank parameter and print
2836         ranks of array types in case they dangling.
2837         (f_type_print_base): Add print_rank parameter.
2838
2839 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2840
2841         * NEWS: Mention new MI commands.
2842         * break-catch-throw.c (enum exception_event_kind): Move to
2843         breakpoint.h.
2844         (print_mention_exception_catchpoint): Output text as a single
2845         message.
2846         (catch_exception_command_1): Rename to...
2847         (catch_exception_event): ...this, make non-static, update header
2848         command, and change some parameter types.
2849         (catch_catch_command): Update for changes to
2850         catch_exception_command_1.
2851         (catch_throw_command): Likewise.
2852         (catch_rethrow_command): Likewise.
2853         * breakpoint.c (enum exception_event_kind): Delete.
2854         * breakpoint.h (enum exception_event_kind): Moved here from
2855         break-catch-throw.c.
2856         (catch_exception_event): Declare.
2857         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2858         (mi_cmd_catch_throw): New function.
2859         (mi_cmd_catch_rethrow): New function.
2860         (mi_cmd_catch_catch): New function.
2861         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2862         'catch-catch' entries.
2863         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2864         (mi_cmd_catch_rethrow): Declare.
2865         (mi_cmd_catch_catch): Declare.
2866
2867 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2868
2869         * annotate.c (annotate_source_line): Change return type to void,
2870         update implementation to match.
2871         * annotate.h (annotate_source_line): Change return type to void,
2872         update header comment.
2873         * stack.c (print_frame_info): Don't change what frame information
2874         is printed based on whether annotations are on or not.
2875
2876 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2877
2878         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2879         (annotate_source): Make static.
2880         (annotate_source_line): Moved from source.c and renamed from
2881         identify_source_line.  Update the return type.
2882         * annotate.h (annotate_source): Delete declaration.
2883         (annotate_source_line): Declaration moved from source.h, and
2884         renamed from identify_source_line.  Return type updated.
2885         * source.c (identify_source_line): Moved to annotate.c and renamed
2886         to annotate_source_line.
2887         (info_line_command): Remove check of annotation_level.
2888         * source.h (identify_source_line): Move declaration to annotate.h
2889         and rename to annotate_source_line.
2890         * stack.c: Add 'annotate.h' include.
2891         (print_frame_info): Remove check of annotation_level before
2892         calling annotate_source_line.
2893
2894 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2895
2896         * source-cache.c (source_cache::get_plain_source_lines): Use
2897         open_source_file_with_line_charpos instead of just
2898         open_source_file, remove call to find_source_lines.
2899         (source_cache::get_source_lines): Likewise.
2900         * source.c (find_source_lines): Make static.
2901         (get_filename_and_charpos): Renamed into...
2902         (open_source_file_with_line_charpos): ..this along with changes to
2903         return a scoped_fd, and some other minor clean ups.
2904         (identify_source_line): Use open_source_file_with_line_charpos.
2905         (search_command_helper): Use open_source_file_with_line_charpos
2906         instead of just open_source_file, remove call to
2907         find_source_lines.
2908         * source.h (open_source_file_with_line_charpos): Declare new
2909         function.
2910         (find_source_lines): Delete declaration.
2911
2912 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2913
2914         * source.c (get_filename_and_charpos): Remove fullname
2915         parameter.
2916         (identify_source_line): Update call to get_filename_and_charpos.
2917
2918 2019-06-14  Tom Tromey  <tromey@adacore.com>
2919
2920         PR gdb/24502:
2921         * ui-style.h (skip_ansi_escape): Update comment.
2922         * ui-file.h (class no_terminal_escape_file): New class.
2923         * ui-file.c (no_terminal_escape_file::write)
2924         (no_terminal_escape_file::puts): New methods.
2925         * cli/cli-logging.c (handle_redirections): Use
2926         no_terminal_escape_file.
2927
2928 2019-06-14  Tom Tromey  <tromey@adacore.com>
2929
2930         * NEWS: Move convenience variable news above Python news.
2931
2932 2019-06-14  Tom Tromey  <tom@tromey.com>
2933
2934         * gnulib: Move directory to top-level.
2935         * configure.ac: Don't configure gnulib.
2936         * configure: Rebuild.
2937         * common/common-defs.h: Use new path to gnulib.
2938         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2939         (GNULIB_H): Remove.
2940         (INCGNU): Look in new gnulib location.
2941         (HFILES_NO_SRCDIR): Remove gnulib files.
2942         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2943         (generated_files): Remove GNULIB_H.
2944         ($(LIBGNU), all-lib): Remove targets.
2945         (distclean): Don't mention GNULIB_BUILDDIR.
2946         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2947
2948 2019-06-14  Tom Tromey  <tromey@adacore.com>
2949
2950         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2951         Warn if symbol file does not provide any symbols.
2952
2953 2019-06-14  Tom Tromey  <tromey@adacore.com>
2954
2955         * source.c (find_and_open_source): Respect basenames_may_differ.
2956
2957 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2958
2959         * annotate.c (annotate_breakpoints_invalid): Make use of
2960         scoped_restore_terminal_state.
2961         (annotate_frames_invalid): Likewise.
2962
2963 2019-06-14  Tom Tromey  <tromey@adacore.com>
2964
2965         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2966         allow assignment to an internalvar.
2967
2968 2019-06-14  Tom Tromey  <tromey@adacore.com>
2969
2970         * ada-lex.l: Allow "_" in attribute names.
2971
2972 2019-06-14  Tom Tromey  <tromey@adacore.com>
2973
2974         PR gdb/24653:
2975         * regcache.c (registers_changed): Don't call alloca.
2976         * top.c (execute_command): Don't call alloca.
2977
2978 2019-06-13  Pedro Alves  <palves@redhat.com>
2979
2980         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2981         'expression'.  When parsing an expression, error out if there's
2982         junk after "unlimited".
2983         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2984         (do_set_command): Adjust calls to is_unlimited_literal.
2985
2986 2019-06-13  Pedro Alves  <palves@redhat.com>
2987
2988         * compile/compile.c (make_compile_options_def_group): Add braces
2989         around array_view initializer.
2990         * thread.c (make_thread_apply_all_options_def_group)
2991         (make_thread_apply_all_options_def_group): Likewise.
2992
2993 2019-06-13  Pedro Alves  <palves@redhat.com>
2994
2995         * NEWS (New commands): Mention "maint test-options
2996         require-delimiter", "maint test-options unknown-is-error", "maint
2997         test-options unknown-is-operand" and "maint show
2998         test-options-completion-result".
2999         (New command options, command completion): New section.
3000         (Completion improvements): New section.
3001         Mention that you can abbreviate "unlimited".
3002
3003 2019-06-13  Pedro Alves  <palves@redhat.com>
3004
3005         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3006         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3007         * unittests/cli-utils-selftests.c (test_parse_flags)
3008         (test_parse_flags_qcs): Delete.
3009         (test_cli_utils): Don't call deleted functions.
3010
3011 2019-06-13  Pedro Alves  <palves@redhat.com>
3012
3013         * thread.c: Include "cli/cli-option.h".
3014         (tp_array_compar_ascending): Global.
3015         (tp_array_compar): Delete function.
3016         (tp_array_compar_ascending, tp_array_compar_descending): New
3017         functions.
3018         (ascending_option_def, qcs_flag_option_def)
3019         (thr_qcs_flags_option_defs)
3020         (make_thread_apply_all_options_def_group)
3021         (make_thread_apply_options_def_group): New.
3022         (thread_apply_all_command): Use gdb::option::process_options.
3023         (thread_apply_command_completer)
3024         (thread_apply_all_command_completer): New.
3025         (thread_apply_command): Use gdb::option::process_options.
3026         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3027         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3028         to generate help text of "thread apply".  Adjust "taas"'s help.
3029         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3030         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3031
3032 2019-06-13  Pedro Alves  <palves@redhat.com>
3033
3034         * thread.c (thread_apply_command): Check for invalid TID with
3035         isdigit instead of !isalpha.
3036
3037 2019-06-13  Pedro Alves  <palves@redhat.com>
3038
3039         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3040         (validate_flags_qcs): New.
3041         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3042         (validate_flags_qcs): Declare.
3043         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3044         (make_frame_apply_options_def_group): New.
3045         (frame_apply_command_count): Process options with
3046         gdb::option::process_options.
3047         (frame_apply_completer): New.
3048         (frame_apply_level_completer, frame_apply_all_completer)
3049         (frame_apply_completer): New.
3050         (_initialize_stack): Update help of "frame apply", "frame apply
3051         level", "frame apply all" and "faas" to mention supported options
3052         and install command completers.
3053         * stack.h (frame_apply_all_completer): Declare.
3054         * thread.c: Include "stack.h".
3055         (tfaas_command): Add "--".
3056         (_initialize_thread): Update help "tfaas" to mention supported
3057         options and install command completer.
3058
3059 2019-06-13  Pedro Alves  <palves@redhat.com>
3060
3061         * completer.c (complete_nested_command_line): New.
3062         (gdb_completion_word_break_characters_throw): Add assertion.
3063         * completer.h (complete_nested_command_line): Declare.
3064
3065 2019-06-13  Pedro Alves  <palves@redhat.com>
3066
3067         * stack.c (parse_backtrace_qualifiers): New.
3068         (backtrace_command): Use it.
3069         (backtrace_command_completer): Complete on qualifiers.
3070
3071 2019-06-13  Pedro Alves  <palves@redhat.com>
3072
3073         * frame.c: Include "cli/cli-option.h.
3074         (user_set_backtrace_options): New.
3075         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3076         Delete.
3077         (get_prev_frame): Adjust.
3078         (boolean_option_def, uinteger_option_def)
3079         (set_backtrace_option_defs): New.
3080         (_initialize_frame): Adjust and use
3081         gdb::option::add_setshow_cmds_for_options to install "set
3082         backtrace past-main" and "set backtrace past-entry".
3083         * frame.h: Include "cli/cli-option.h".
3084         (struct frame_print_options): Forward declare.
3085         (print_frame_arguments_all, print_frame_arguments_scalars)
3086         (print_frame_arguments_none): Declare.
3087         (print_entry_values): Delete declaration.
3088         (struct frame_print_options, user_frame_print_options): New.
3089         (struct set_backtrace_options): New.
3090         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3091         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3092         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3093         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3094         (list_args_or_locals): Add frame_print_options parameter.
3095         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3096         * python/py-framefilter.c (enumerate_args): Pass down
3097         USER_FRAME_PRINT_OPTIONS.
3098         * stack.c: Include "cli/cli-option.h".
3099         (print_frame_arguments_all, print_frame_arguments_scalars)
3100         (print_frame_arguments_none): Declare.
3101         (print_raw_frame_arguments, print_entry_values): Delete.
3102         (user_frame_print_options): New.
3103         (boolean_option_def, enum_option_def, frame_print_option_defs):
3104         New.
3105         (struct backtrace_cmd_options): New.
3106         (bt_flag_option_def): New.
3107         (backtrace_command_option_defs): New.
3108         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3109         (print_frame_arg, read_frame_arg, print_frame_args)
3110         (print_frame_info, print_frame): Add frame_print_options parameter
3111         and use it.
3112         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3113         (backtrace_command_1): Add frame_print_options and
3114         backtrace_cmd_options parameters and use them.
3115         (make_backtrace_options_def_group): New.
3116         (backtrace_command): Process command options with
3117         gdb::option::process_options.
3118         (backtrace_command_completer): New.
3119         (_initialize_stack): Extend "backtrace"'s help to mention
3120         supported options.  Install completer for "backtrace".
3121         Install some settings commands with add_setshow_cmds_for_options.
3122
3123 2019-06-13  Pedro Alves  <palves@redhat.com>
3124
3125         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3126         and that "set/show print raw frame-arguments" are now deprecated.
3127
3128         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3129         command.
3130         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3131         * stack.c (_initialize_stack): Install "set/show print
3132         raw-frame-arguments", and deprecate "set/show print raw
3133         frame-arguments".
3134         * valprint.c (_initialize_valprint): Deprecate "set/show print
3135         raw".
3136
3137 2019-06-13  Pedro Alves  <palves@redhat.com>
3138
3139         * compile/compile.c (struct compile_options): New.
3140         (compile_flag_option_def, compile_command_option_defs)
3141         (make_compile_options_def_group): New.
3142         (compile_file_command): Handle options with
3143         gdb::option::process_options.
3144         (compile_file_command_completer): New function.
3145         (compile_code_command): Handle options with
3146         gdb::option::process_options.
3147         (compile_code_command_completer): New function.
3148         (_initialize_compiler): Install completers for "compile code" and
3149         "compile file".  Mention available options in "compile code" and
3150         "compile code"'s help.
3151         * completer.c (advance_to_completion_word): New, factored out from
3152         ...
3153         (advance_to_expression_complete_word_point): ... this.
3154         (advance_to_filename_complete_word_point): New.
3155         * completer.h (advance_to_filename_complete_word_point): New
3156         declaration.
3157
3158 2019-06-13  Pedro Alves  <palves@redhat.com>
3159
3160         * compile/compile.c: Include "cli/cli-option.h".
3161         (compile_print_value): Scope data pointer is now a
3162         value_print_options pointer; adjust.
3163         (compile_print_command): Process options.  Scope data pointer is
3164         now a value_print_options pointer; adjust.
3165         (_initialize_compile): Update "compile print"'s help to include
3166         supported options.  Install a completer for "compile print".
3167         * cp-valprint.c (show_vtblprint, show_objectprint)
3168         (show_static_field_print): Delete.
3169         (_initialize_cp_valprint): Don't install "set print
3170         static-members", "set print vtbl", "set print object" here.
3171         * printcmd.c: Include "cli/cli-option.h" and
3172         "common/gdb_optional.h".
3173         (print_command_parse_format): Rework to fill in a
3174         value_print_options instead of a format_data.
3175         (print_value): Change parameter type from format_data pointer to
3176         value_print_options reference.  Adjust.
3177         (print_command_1): Process options.  Adjust to pass down a
3178         value_print_options.
3179         (print_command_completer): New.
3180         (_initialize_printcmd): Install print_command_completer as
3181         handle_brkchars completer for the "print" command.  Update
3182         "print"'s help to include supported options.
3183         * valprint.c: Include "cli/cli-option.h".
3184         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3185         here from cp-valprint.c.
3186         (boolean_option_def, uinteger_option_def)
3187         (value_print_option_defs, make_value_print_options_def_group):
3188         New.  Use gdb::option::add_setshow_cmds_for_options to install
3189         "set print elements", "set print null-stop", "set print repeats",
3190         "set print pretty", "set print union", "set print array", "set
3191         print address", "set print symbol", "set print array-indexes".
3192         * valprint.h: Include <string> and "cli/cli-option.h".
3193         (make_value_print_options_def_group): Declare.
3194         (print_value): Change parameter type from format_data pointer to
3195         value_print_options reference.
3196         (print_command_completer): Declare.
3197
3198 2019-06-13  Pedro Alves  <palves@redhat.com>
3199
3200         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3201         (COMMON_SFILES): Add maint-test-settings.c.
3202         * cli/cli-decode.c (boolean_enums): New global, factored out from
3203         ...
3204         (add_setshow_boolean_cmd): ... here.
3205         * cli/cli-decode.h (boolean_enums): Declare.
3206         * cli/cli-option.c: New file.
3207         * cli/cli-option.h: New file.
3208         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3209         factored out from ...
3210         (parse_cli_boolean_value(const char *)): ... this.
3211         (is_unlimited_literal): Change parameter type to pointer to
3212         pointer.  Adjust and advance ARG pointer.
3213         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3214         (parse_cli_var_enum): New, factored out from ...
3215         (do_set_command): ... this.  Adjust.
3216         * cli/cli-setshow.h (parse_cli_boolean_value)
3217         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3218         (parse_cli_var_enum): Declare.
3219         * cli/cli-utils.c: Include "cli/cli-option.h".
3220         (get_ulongest): New.
3221         * cli/cli-utils.h (get_ulongest): Declare.
3222         (check_for_argument): New overloads.
3223         * maint-test-options.c: New file.
3224
3225 2019-06-13  Pedro Alves  <palves@redhat.com>
3226
3227         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3228         parse a range if "-" is at the end of the string.
3229
3230 2019-06-13  Pedro Alves  <palves@redhat.com>
3231
3232         * cli/cli-setshow.c (parse_auto_binary_operation)
3233         (parse_cli_boolean_value): Don't allow "o".
3234
3235 2019-06-13  Pedro Alves  <palves@redhat.com>
3236
3237         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3238         * NEWS: Mention maint test-settings KIND.
3239         * maint-test-settings.c: New file.
3240
3241 2019-06-13  Pedro Alves  <palves@redhat.com>
3242
3243         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3244         completer.
3245         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3246         "set" completers.
3247
3248 2019-06-13  Pedro Alves  <palves@redhat.com>
3249
3250         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3251         after item.
3252
3253 2019-06-13  Pedro Alves  <palves@redhat.com>
3254
3255         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3256
3257 2019-06-13  Pedro Alves <palves@redhat.com>
3258
3259         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3260         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3261         call.
3262         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3263         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3264         calls.
3265         (check_for_argument): Skip spaces after argument.
3266
3267 2019-06-13  Pedro Alves  <palves@redhat.com>
3268
3269         * thread.c (thread_apply_command): Adjust TID parsing.
3270         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3271         detected before end of string.
3272         (tid_is_in_list): Error out if LIST is invalid.
3273
3274 2019-06-13  Pedro Alves  <palves@redhat.com>
3275
3276         * completer.c (complete_line_internal_1): Rewind completion word
3277         point.
3278         (completion_tracker::advance_custom_word_point_by): Change
3279         parameter type to int.
3280         * completer.h (completion_tracker::advance_custom_word_point_by):
3281         Likewise.
3282
3283 2019-06-13  Pedro Alves  <palves@redhat.com>
3284
3285         * completer.c (advance_to_completion_word): Handle delimiters.
3286
3287 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3288
3289         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3290
3291 2019-06-11  Tom Tromey  <tom@tromey.com>
3292
3293         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3294         (xmalloc_failed): Move to alloc.c.
3295         * alloc.c: New file.
3296         * Makefile.in (COMMON_SFILES): Add alloc.c.
3297
3298 2019-06-11  Tom Tromey  <tom@tromey.com>
3299
3300         * nat/linux-waitpid.c: Don't include server.h.
3301         (linux_debug): Remove.
3302         (my_waitpid): Update.
3303
3304 2019-06-11  Tom Tromey  <tromey@adacore.com>
3305
3306         * infcall.c (_initialize_infcall): Remove trailing newline from
3307         help.
3308         * user-regs.c (_initialize_user_regs): Remove trailing newline
3309         from help.
3310         * typeprint.c (_initialize_typeprint): Remove trailing newline
3311         from help.
3312         * reverse.c (_initialize_reverse): Remove trailing newlines from
3313         help.
3314         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3315         from help.
3316         * language.c (add_set_language_command): Remove trailing newline
3317         from help.
3318         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3319         help.
3320         * disasm.c (_initialize_disasm): Remove trailing newline from
3321         help.
3322         * top.c (init_main): Remove trailing newline from help.
3323         * interps.c (_initialize_interpreter): Remove trailing newline
3324         from help.
3325         * btrace.c (_initialize_btrace): Remove trailing newlines from
3326         help.
3327         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3328         from help.
3329         * python/python.c (_initialize_python): Remove trailing newline
3330         from help.
3331         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3332         help.
3333         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3334         from help.  Reformat some text.
3335         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3336         from help.
3337         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3338         newline from help.
3339
3340 2019-06-11  Tom Tromey  <tromey@adacore.com>
3341
3342         * darwin-nat.c (darwin_decode_exception_message)
3343         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3344
3345 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3346
3347         * valops.c (value_slice): Check for not allocated or not
3348         associated values.
3349
3350 2019-06-10  Tom de Vries  <tdevries@suse.de>
3351
3352         PR gdb/24618
3353         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3354         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3355         invalid.
3356
3357 2019-06-10  Tom de Vries  <tdevries@suse.de>
3358
3359         PR gdb/24611
3360         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3361         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3362
3363 2019-06-10  Tom de Vries  <tdevries@suse.de>
3364
3365         PR symtab/24545
3366         * symtab.c (struct demangled_name_entry): Add language field.
3367         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3368         static minimal symbol".  Set and use language field.
3369
3370 2019-06-10  Tom Tromey  <tromey@adacore.com>
3371
3372         * ada-lang.c (_initialize_ada_language): Update help text.
3373
3374 2019-06-10  Tom Tromey  <tromey@adacore.com>
3375
3376         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3377         with a newline.
3378         * guile/guile.c (handle_boot_error): Don't end warning with a
3379         newline.
3380         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3381         warning with a newline.
3382         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3383         newline.
3384         (s12z_frame_cache): Likewise.
3385         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3386         a newline.
3387         * solib-svr4.c (disable_probes_interface): Don't end warning with
3388         a newline.
3389         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3390         newline.
3391         * python/python.c (do_finish_initialization): Don't end warning
3392         with a newline.
3393
3394 2019-06-10  Tom Tromey  <tom@tromey.com>
3395
3396         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3397         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3398         gdbpy_enter.
3399
3400 2019-06-10  Tom Tromey  <tromey@adacore.com>
3401
3402         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3403         data.
3404         (elf_new_init): Don't call stabsread_new_init.
3405         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3406         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3407         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3408
3409 2019-06-10  Tom de Vries  <tdevries@suse.de>
3410
3411         PR symtab/16264
3412         PR symtab/24517
3413         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3414
3415 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3416
3417         * source.c (find_and_open_source): Also rewrite relative file
3418         names.
3419
3420 2019-04-26  Amos Bird  <amosbird@gmail.com>
3421
3422         * annotate.c (annotate_thread_exited): Add "thread-exited"
3423         annotation.
3424
3425 2019-06-06  Tom Tromey  <tromey@adacore.com>
3426
3427         * maint.h (class scoped_command_stats): Use
3428         DISABLE_COPY_AND_ASSIGN.
3429         <print_time>: New method.
3430         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3431         print_time.
3432         (scoped_command_stats::print_time): New method.
3433
3434 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3435
3436         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3437         instructions of lengths 6 or 8 bytes.
3438
3439 2019-06-04  Pedro Alves  <palves@redhat.com>
3440
3441         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3442
3443         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3444         * breakpoint.c (condition_completer): Likewise.
3445         * cli/cli-dump.c (scan_expression): Likewise.
3446         * common/filestuff.c (mkdir_recursive): Likewise.
3447         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3448         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3449         (gdb_abspath): Likewise.
3450         * compile/compile-cplus-types.c
3451         (compile_cplus_instance::decl_name): Likewise.
3452         * completer.c (complete_explicit_location):
3453         (signal_completer, reg_or_group_completer_1): Likewise.
3454         * cp-support.c (cp_remove_params_if_any): Likewise.
3455         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3456         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3457         * infcmd.c (strip_bg_char): Likewise.
3458         * linespec.c (copy_token_string): Likewise.
3459         * mi/mi-main.c (output_cores): Likewise.
3460         * psymtab.c (psymtab_search_name):
3461         * symfile.c (test_set_ext_lang_command): Likewise.
3462         * target.c (target_fileio_read_stralloc): Likewise.
3463         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3464         * value.c (complete_internalvar): Likewise.
3465
3466 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3467
3468         Add objfile property to gdb.Type.
3469         * NEWS: Mention Python API addition.
3470         * python/py-type.c (typy_get_objfile): New method.
3471
3472 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3473
3474         * NEWS: Mention the new set|show style [title|highlight].
3475         Mention changes to "show style", "help" and "apropos".
3476
3477 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3478
3479         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3480         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3481         instead of print_help_for_command.
3482         (print_doc_of_command): New function.
3483         (help_list): Add 'apropos -v word' suggestion.
3484         (print_help_for_command): Style the command name using title style.
3485         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3486         (_initialize_cli_cmds): Describe -v in apropos_command help.
3487
3488 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3489
3490         * cli/cli-style.h (cli_style_option): Add name in constructor,
3491         add m_name class member, add constructor with intensity,
3492         add name class function.
3493         (cli_style_option::add_setshow_commands): Remove name argument.
3494         (highlight_style, title_style): New styles.
3495         * cli/cli-style.c (do_show): New function that shows a style
3496         characteristic styling the style name with itself.
3497         (set_style_name): New function.
3498         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3499         Update all callers according to the changes in cli/cli-style.h.
3500         * utils.h (fputs_highlighted): New function.
3501         * utils.c (fputs_highlighted): Likewise.
3502
3503 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3504
3505         * NEWS: Mention new pipe command and new convenience variables.
3506
3507 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3508
3509         * cli/cli-cmds.c (pipe_command): New function.
3510         (_initialize_cli_cmds): Call add_com for pipe_command.
3511         Define | as an alias for pipe.
3512         (exit_status_set_internal_vars): New function.
3513         (shell_escape): Call exit_status_set_internal_vars.
3514         cli/cli-decode.c (find_command_name_length): Recognize | as
3515         a single character command.
3516
3517 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3518
3519         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3520         top.c (execute_command_to_ui_file): New function, mostly a copy
3521         of execute_command_to_string.
3522         (execute_command_to_string): Implement by calling
3523         execute_command_to_ui_file.
3524
3525 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3526
3527         * top.h (saved_command_line): Remove declaration.
3528         * top.c (previous_saved_command_line, previous_repeat_arguments):
3529         New variables.
3530         (saved_command_line): Make static, define together with other
3531         'repeat variables'.
3532         (dont_repeat): Clear repeat_arguments.
3533         (repeat_previous, get_saved_command_line, save_command_line):
3534         New functions.
3535         (gdb_init): Initialize saved_command_line
3536         and previous_saved_command_line.
3537         * main.c (captured_main_1): Remove saved_command_line initialization.
3538         * event-top.c (handle_line_of_input): Update to use
3539         the new 'repeat' related functions instead of direct access to
3540         saved_command_line.
3541         * command.h (repeat_previous, get_saved_command_line,
3542         save_command_line): New declarations.
3543         (dont_repeat): Add comment.
3544
3545 2019-05-30  Tom Tromey  <tromey@adacore.com>
3546
3547         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3548         Fix comment.
3549         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3550
3551 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3552
3553         PR cli/24587
3554         * completer.c (complete): Initialize variable word.
3555
3556 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3557
3558         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3559         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3560         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3561         'body' is NULL to the outter 'if', protecting the '!is_define'
3562         situation as well.
3563
3564 2019-05-29  Tom Tromey  <tromey@adacore.com>
3565
3566         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3567         (dwarf_unknown): New function.
3568         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3569         (dwarf_type_encoding_name): Use dwarf_unknown.
3570
3571 2019-05-29  Tom Tromey  <tromey@adacore.com>
3572
3573         PR c++/20020:
3574         * cp-valprint.c (cp_print_value_fields): Call
3575         cp_print_static_field inside "try".
3576
3577 2019-05-29  Tom Tromey  <tromey@adacore.com>
3578
3579         * inflow.c (struct terminal_info): Add default operator=.
3580         * configure: Rebuild.
3581         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3582         -Wdeprecated-copy-dtor, -Wredundant-move.
3583
3584 2019-05-29  Tom Tromey  <tromey@adacore.com>
3585
3586         * NEWS: Add entry.
3587         * infcmd.c (print_return_value_1): Handle finish_print
3588         option.
3589         (show_print_finish): New function.
3590         (_initialize_infcmd): Add "set/show print finish" commands.
3591         * valprint.c (user_print_options): Initialize new member.
3592         * valprint.h (struct value_print_options) <finish_print>: New
3593         member.
3594
3595 2019-05-28  Tom Tromey  <tromey@adacore.com>
3596
3597         * ada-lang.c (ada_remove_Xbn_suffix)
3598         (find_old_style_renaming_symbol)
3599         (parse_old_style_renaming): Remove.
3600         (ada_find_renaming_symbol): Don't call
3601         find_old_style_renaming_symbol.
3602         (ada_is_renaming_symbol): Rename from
3603         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3604         bool.  Now static.
3605         (ada_read_var_value): Update and simplify.
3606         * ada-exp.y (write_var_or_type): Remove old code.
3607
3608 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3609
3610         * event-top.c: Remove include comment.
3611         * inflow.c (class scoped_ignore_sigttou): Move from here...
3612         * inflow.h (class scoped_ignore_sigttou): ...to here.
3613         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3614         * top.c:  Remove include comment.
3615
3616 2019-05-27  Tom Tromey  <tom@tromey.com>
3617
3618         * NEWS: Fix typo.
3619
3620 2019-05-22  Tom Tromey  <tromey@adacore.com>
3621
3622         * target.c (target_follow_exec): Constify parameter.
3623         * target-delegates.c: Rebuild.
3624         * remote.c (remote_target::follow_exec): Constify parameter.
3625         * infrun.c (follow_exec): Constify parameter.
3626         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3627         (target_follow_exec): Likewise.
3628
3629 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3630
3631         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3632         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3633
3634 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3635
3636         * NEWS: Add debugredirect and testsuite sections.
3637
3638 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3639
3640         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3641         target descriptions using exclusively floating point register name
3642         aliases.
3643
3644 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3645
3646         PR gdb/18644:
3647         * f-lang.c (build_fortran_types): Handle the case where
3648         gdbarch_floatformat_for_type returns a nullptr.
3649
3650 2019-05-21  Tom de Vries  <tdevries@suse.de>
3651
3652         PR cli/24587
3653         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3654
3655 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3656
3657         PR gdb/18644:
3658         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3659         16-byte floats.
3660         * i386-tdep.c (i386_floatformat_for_type): Use
3661         floatformats_ia64_quad for the 16-byte floating point component
3662         within a fortran 32-byte complex number.
3663
3664 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3665
3666         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3667         delete default constructor.
3668         (find_partial_die): Update to return const struct.
3669         (partial_die_parent_scope): Move variable declaration into scope
3670         of its use and change its type to auto.
3671         (guess_partial_die_structure_name): Likewise.
3672         (partial_die_info::fixup): Likewise.
3673
3674 2019-05-17  Tom Tromey  <tromey@adacore.com>
3675
3676         * source.c (find_and_open_source): Remove cast.
3677
3678 2019-05-17  Tom Tromey  <tromey@adacore.com>
3679
3680         * annotate.c (annotate_source): Make "filename" const.
3681         * annotate.h (annotate_source): Use const.
3682
3683 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3684
3685         * disasm.c (set_disassembler_options): Send errors to stderr.
3686
3687 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3688
3689         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3690         (cli_interp_base::set_logging): Check debug_redirect.
3691         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3692         * cli/cli-logging.c (debug_redirect): Add static variable.
3693         (pop_output_files): Add default param.
3694         (handle_redirections): Print debug setting.
3695         (show_logging_command): Likewise.
3696         (_initialize_cli_logging): Add debugredirect command.
3697         * interps.c (current_interp_set_logging): Add debug_redirect
3698         parameter.
3699         * interps.h (set_logging): Add debug_redirect parameter.
3700         (current_interp_set_logging): Likewise.
3701         * mi/mi-common.h: Likewise.
3702         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3703
3704 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3705             Tom Tromey  <tromey@adacore.com>
3706
3707         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3708         directly.
3709         * cli/cli-interp.h (make_logging_output): Remove declaration.
3710         * cli/cli-logging.c (make_logging_output): Remove function.
3711         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3712         directly.
3713         * ui-file.c (tee_file::tee_file): Remove bools.
3714         (tee_file::~tee_file): Remove deletes.
3715         * ui-file.h (tee_file): Remove bools.
3716
3717 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3718
3719         * mi/mi-cmds.h (mi_cmd_complete): New function.
3720         * mi/mi-main.c (mi_cmd_complete): Likewise.
3721         * mi/mi-cmds.c: Define new MI command -complete.
3722         * NEWS: Mention new -complete command.
3723
3724 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3725
3726         * completer.h (complete): New function.
3727         * completer.c (complete): Likewise.
3728         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3729         function defined in completer.h.
3730
3731 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3732
3733         * MAINTAINERS (Write After Approval): Add myself.
3734
3735 2019-05-17  Tom de Vries  <tdevries@suse.de>
3736
3737         PR gdb/24094
3738         * dwarf2read.c (struct cu_partial_die_info): New struct.
3739         (find_partial_die): Return cu_partial_die_info.
3740         (partial_die_parent_scope, guess_partial_die_structure_name)
3741         (partial_die_info::fixup): Handle new return type of find_partial_die.
3742
3743 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3744
3745         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3746         "std::string", simplifying the algorithm.
3747
3748 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3749
3750         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3751         (stap_static_probe_ops::get_probes): Likewise.
3752
3753 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3754
3755         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3756         '-')" and "else if".
3757         (stap_parse_single_operand): Join checks for
3758         "gdbarch_stap_parse_special_token_p" and
3759         "gdbarch_stap_parse_special_token" in the same "if" statement.
3760         Invert check when verifying for operation on register
3761         displacement.
3762
3763 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3764
3765         * stap-probe.c (stap_get_opcode): Update comment.
3766         (stap_get_expected_argument_type): Likewise.
3767         (handle_stap_probe): Likewise.
3768
3769 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3770
3771         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3772         return type to 'bool'.  Adjust comment.  Use 'bool' when
3773         appropriate.
3774         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3775         * stap-probe.c (stap_parse_argument_1): Likewise.
3776         (stap_is_operator): Likewise.
3777         (stap_is_generic_prefix): Likewise.
3778         (stap_is_register_prefix): Likewise.
3779         (stap_is_register_indirection_prefix): Likewise.
3780         (stap_is_integer_prefix): Likewise.
3781         (stap_generic_check_suffix): Likewise.
3782         (stap_check_integer_suffix): Likewise.
3783         (stap_check_register_suffix): Likewise.
3784         (stap_check_register_indirection_suffix): Likewise.
3785         (stap_parse_register_operand): Likewise.
3786         (stap_parse_single_operand): Likewise.
3787         (stap_parse_argument_1): Likewise.
3788         (stap_probe::get_argument_count): Likewise.
3789         (stap_is_operator): Likewise.
3790
3791 2019-05-16  Tom Tromey  <tromey@adacore.com>
3792
3793         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3794         keyword to foreach.
3795
3796 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3797
3798         * linux-thread-db.c (try_thread_db_load_1): Change return type
3799         to bool.
3800         (try_thread_db_load): Likewise.
3801         (try_thread_db_load_from_pdir_1): Likewise.
3802         (try_thread_db_load_from_pdir): Likewise.
3803         (try_thread_db_load_from_sdir): Likewise.
3804         (try_thread_db_load_from_dir): Likewise.
3805         (thread_db_load_search): Likewise.
3806         (has_libpthread): Likewise.
3807         (thread_db_load): Likewise.
3808
3809 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3810
3811         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3812         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3813         NULL, and complain/return if that's the case.
3814
3815 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3816
3817         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3818         (advance, posn, abstract_read_memory): New functions.
3819         [struct mem_read_abstraction]: New struct.
3820         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3821
3822 2019-05-14  Tom Tromey  <tromey@adacore.com>
3823
3824         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3825         value is not lval_memory.
3826
3827 2019-05-14  Tom Tromey  <tromey@adacore.com>
3828
3829         * solib.c (info_sharedlibrary_command): Style the file name.
3830
3831 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3832
3833         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3834         (aarch64_vnv_type): Likewise.
3835         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3836         * common/tdesc.c: Likewise.
3837         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3838         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3839         * features/aarch64-fpu.xml: Add ieee half view.
3840         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3841         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3842         * gdbtypes.h (struct builtin_type): Likewise.
3843         (struct objfile_type): Likewise.
3844
3845 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3846
3847         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3848         typo.
3849         * location.h (string_to_event_location): Likewise.
3850
3851 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3852
3853         GDB 8.3 released.
3854
3855 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3856
3857         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3858         New variable declaration.
3859         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3860         New variable.
3861         (print_one_breakpoint): Use ui_out::test_flags and new global
3862         variable to compute use_fixed_output.
3863         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3864         Remove.
3865         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3866         (mi_multi_location_breakpoint_output_fixed): Remove.
3867         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3868         new variable.
3869         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3870         fix_multi_location_breakpoint_output flag if version >= 3.
3871         * ui-out.h (enum ui_out_flag)
3872         <fix_multi_location_breakpoint_output>: New enumerator.
3873
3874 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3875
3876         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3877
3878 2019-05-10  Tom Tromey  <tromey@adacore.com>
3879
3880         * ada-lang.c (catch_ada_completer): New function.
3881         (_initialize_ada_language): Use it.
3882
3883 2019-05-10  Tom Tromey  <tromey@adacore.com>
3884
3885         * thread.c (print_thread_info): Make "requested_threads" const.
3886         * gdbthread.h (print_thread_info): Make "requested_threads"
3887         const.
3888         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3889         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3890
3891 2019-05-08  Tom Tromey  <tom@tromey.com>
3892
3893         * gdbtypes.c (objfile_type_data): Change type.
3894         (objfile_type, _initialize_gdbtypes): Update.
3895
3896 2019-05-08  Tom Tromey  <tom@tromey.com>
3897
3898         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3899         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3900         (_initialize_dwarf2_frame): Update.
3901
3902 2019-05-08  Tom Tromey  <tom@tromey.com>
3903
3904         * objc-lang.c (objc_objfile_data): Change type.
3905         (find_methods): Update.
3906         (_initialize_objc_lang): Remove.
3907
3908 2019-05-08  Tom Tromey  <tom@tromey.com>
3909
3910         * stabsread.c (rs6000_builtin_type_data): Change type.
3911         (rs6000_builtin_type, _initialize_stabsread): Update.
3912
3913 2019-05-08  Tom Tromey  <tom@tromey.com>
3914
3915         * mips-tdep.c (mips_pdr_data): Remove.
3916         (_initialize_mips_tdep): Update.
3917
3918 2019-05-08  Tom Tromey  <tom@tromey.com>
3919
3920         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3921         (hppa_init_objfile_priv_data, read_unwind_info)
3922         (find_unwind_entry, _initialize_hppa_tdep): Update.
3923
3924 2019-05-08  Tom Tromey  <tom@tromey.com>
3925
3926         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3927         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3928         on obstack.
3929         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3930
3931 2019-05-08  Tom Tromey  <tom@tromey.com>
3932
3933         * mdebugread.c (basic_type_data): Change type.
3934         (basic_type, _initialize_mdebugread): Update.
3935
3936 2019-05-08  Tom Tromey  <tom@tromey.com>
3937
3938         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3939
3940 2019-05-08  Tom Tromey  <tom@tromey.com>
3941
3942         * nto-tdep.c (nto_inferior_data_reg): Change type.
3943         (nto_inferior_data): Update.
3944         (nto_inferior_data_cleanup, nto_new_inferior_data)
3945         (_initialize_nto_tdep): Remove.
3946         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3947
3948 2019-05-08  Tom Tromey  <tom@tromey.com>
3949
3950         * ada-lang.c (struct ada_inferior_data): Add initializers.
3951         (ada_inferior_data): Change type.
3952         (ada_inferior_data_cleanup): Remove.
3953         (get_ada_inferior_data, ada_inferior_exit)
3954         (struct ada_pspace_data): Add initializers, destructor.
3955         (ada_pspace_data_handle): Change type.
3956         (get_ada_pspace_data): Update.
3957         (ada_pspace_data_cleanup): Remove.
3958
3959 2019-05-08  Tom Tromey  <tom@tromey.com>
3960
3961         * coffread.c (struct coff_symfile_info): Add initializers.
3962         (coff_objfile_data_key): Move lower.  Change type.
3963         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3964         Update.
3965         (coff_free_info): Remove.
3966
3967 2019-05-08  Tom Tromey  <tom@tromey.com>
3968
3969         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3970         (fbsd_pspace_data_handle): Move lower.  Change type.
3971         (get_fbsd_pspace_data): Update.
3972         (fbsd_pspace_data_cleanup): Remove.
3973         (_initialize_fbsd_tdep): Update.
3974
3975 2019-05-08  Tom Tromey  <tom@tromey.com>
3976
3977         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3978         (get_ada_tasks_pspace_data): Update.
3979         (ada_tasks_pspace_data_cleanup): Remove.
3980         (_initialize_tasks): Update.
3981         (ada_tasks_inferior_data_handle): Change type.
3982         (get_ada_tasks_inferior_data): Update.
3983         (ada_tasks_inferior_data_cleanup): Remove.
3984         (struct ada_tasks_pspace_data): Add initializers.
3985
3986 2019-05-08  Tom Tromey  <tom@tromey.com>
3987
3988         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3989         * symfile-debug.c (debug_sym_get_probes): Change type.
3990         * stap-probe.c (handle_stap_probe):
3991         (stap_static_probe_ops::get_probes): Change type.
3992         * probe.h (class static_probe_ops) <get_probes>: Change type.
3993         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3994         (parse_probes_in_pspace): Update.
3995         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3996         Update.
3997         (any_static_probe_ops::get_probes): Change type.
3998         * elfread.c (elfread_data): New typedef.
3999         (probe_key): Change type.
4000         (elf_get_probes): Likewise.  Update.
4001         (probe_key_free): Remove.
4002         (_initialize_elfread): Update.
4003         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4004         Change type.
4005         (dtrace_process_dof_probe, dtrace_process_dof)
4006         (dtrace_static_probe_ops::get_probe): Change type.
4007
4008 2019-05-08  Tom Tromey  <tom@tromey.com>
4009
4010         * xcoffread.c (struct xcoff_symfile_info): Rename from
4011         coff_symfile_info.  Add initializers.
4012         (xcoff_objfile_data_key): Move lower.  Change type.
4013         (XCOFF_DATA): Rewrite.
4014         (xcoff_free_info): Remove.
4015         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4016         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4017         (xcoff_initial_scan): Update.
4018
4019 2019-05-08  Tom Tromey  <tom@tromey.com>
4020
4021         * solib-svr4.c (struct svr4_info): Add initializers and
4022         destructor.
4023         <probes_table>: Now an htab_up.
4024         (solib_svr4_pspace_data): Change type.
4025         (free_probes_table): Simplify.
4026         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4027         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4028         (probes_table_remove_objfile_probes, register_solib_event_probe)
4029         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4030         (_initialize_svr4_solib): Update.
4031
4032 2019-05-08  Tom Tromey  <tom@tromey.com>
4033
4034         * remote.c (remote_pspace_data): Change type.
4035         (remote_pspace_data_cleanup): Remove.
4036         (get_remote_exec_file, set_pspace_remote_exec_file)
4037         (_initialize_remote): Update.
4038
4039 2019-05-08  Tom Tromey  <tom@tromey.com>
4040
4041         * breakpoint.c (breakpoint_objfile_key): Change type.
4042         (get_breakpoint_objfile_data): Update.
4043         (free_breakpoint_objfile_data): Remove.
4044         (_initialize_breakpoint): Update.
4045
4046 2019-05-08  Tom Tromey  <tom@tromey.com>
4047
4048         * linux-tdep.c (struct linux_info): Add initializers.
4049         (linux_inferior_data): Move.  Change type.
4050         (invalidate_linux_cache_inf): Update.
4051         (linux_inferior_data_cleanup): Remove.
4052         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4053
4054 2019-05-08  Tom Tromey  <tom@tromey.com>
4055
4056         * auxv.c (auxv_inferior_data): Move.  Change type.
4057         (auxv_inferior_data_cleanup): Remove.
4058         (invalidate_auxv_cache_inf): Rewrite.
4059         (get_auxv_inferior_data, _initialize_auxv): Update.
4060
4061 2019-05-08  Tom Tromey  <tom@tromey.com>
4062
4063         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4064         (symfile_debug_objfile_data_key): Change type.
4065         (symfile_debug_installed, debug_qf_has_symbols)
4066         (debug_qf_find_last_source_symtab)
4067         (debug_qf_forget_cached_source_info)
4068         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4069         (debug_qf_print_stats, debug_qf_dump)
4070         (debug_qf_expand_symtabs_for_function)
4071         (debug_qf_expand_all_symtabs)
4072         (debug_qf_expand_symtabs_with_fullname)
4073         (debug_qf_map_matching_symbols)
4074         (debug_qf_expand_symtabs_matching)
4075         (debug_qf_find_pc_sect_compunit_symtab)
4076         (debug_qf_map_symbol_filenames)
4077         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4078         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4079         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4080         (debug_sym_read_linetable, debug_sym_relocate): Update.
4081         (symfile_debug_free_objfile): Remove.
4082         (install_symfile_debug_logging, _initialize_symfile_debug):
4083         Update.
4084
4085 2019-05-08  Tom Tromey  <tom@tromey.com>
4086
4087         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4088         allocate_on_obstack.
4089         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4090         (get_dwarf2_per_objfile): Update.
4091         (set_dwarf2_per_objfile): Remove.
4092         (dwarf2_has_info, dwarf2_get_section_info): Update.
4093         (dwarf2_free_objfile): Remove.
4094         (_initialize_dwarf2_read): Update.
4095
4096 2019-05-08  Tom Tromey  <tom@tromey.com>
4097
4098         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4099         initializers.
4100         <unsupported_script_warning_printed,
4101         script_not_found_warning_printed>: Now bool.
4102         (auto_load_pspace_data): Change type.
4103         (~auto_load_pspace_info): Rename from
4104         auto_load_pspace_data_cleanup.
4105         (get_auto_load_pspace_data, init_loaded_scripts_info)
4106         (clear_section_scripts, maybe_print_unsupported_script_warning)
4107         (maybe_print_script_not_found_warning, _initialize_auto_load):
4108         Update.
4109
4110 2019-05-08  Tom Tromey  <tom@tromey.com>
4111
4112         * objfiles.c (objfile_pspace_info): Add destructor and
4113         initializers.
4114         (objfiles_pspace_data): Change type.
4115         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4116         (get_objfile_pspace_data): Update.
4117         (objfiles_bfd_data): Change type.
4118         (get_objfile_bfd_data): Update.
4119         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4120
4121 2019-05-08  Tom Tromey  <tom@tromey.com>
4122
4123         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4124         Change type.
4125         (get_catch_syscall_inferior_data): Update.
4126         (catch_syscall_inferior_data_cleanup): Remove.
4127         (_initialize_break_catch_syscall): Update.
4128
4129 2019-05-08  Tom Tromey  <tom@tromey.com>
4130
4131         * inflow.c (struct terminal_info): Add destructor and
4132         initializers.
4133         (inflow_inferior_data): Change type.
4134         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4135         (get_inflow_inferior_data, inflow_inferior_exit)
4136         (swap_terminal_info, _initialize_inflow): Update.
4137
4138 2019-05-08  Tom Tromey  <tom@tromey.com>
4139
4140         * target-dcache.c (target_dcache_cleanup): Remove.
4141         (target_dcache_aspace_key): Change type.
4142         (target_dcache_init_p, target_dcache_invalidate)
4143         (target_dcache_get, target_dcache_get_or_init)
4144         (_initialize_target_dcache): Update.
4145         * dcache.h (struct dcache_deleter): New.
4146
4147 2019-05-08  Tom Tromey  <tom@tromey.com>
4148
4149         * symtab.c (struct symbol_cache): Add destructor and
4150         initializers.
4151         (symbol_cache_key): Move.  Change type.
4152         (make_symbol_cache, free_symbol_cache): Remove.
4153         (get_symbol_cache): Update.
4154         (symbol_cache_cleanup): Remove.
4155         (ALL_PSPACES, symbol_cache_flush)
4156         (maintenance_print_symbol_cache)
4157         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4158         Update.
4159
4160 2019-05-08  Tom Tromey  <tom@tromey.com>
4161
4162         * symtab.c (struct main_info): Add destructor and initializers.
4163         (main_progspace_key): Move.  Change type.
4164         (get_main_info): Update.
4165         (main_info_cleanup): Remove.
4166         (_initialize_symtab): Update.
4167
4168 2019-05-08  Tom Tromey  <tom@tromey.com>
4169
4170         * registry.h (DECLARE_REGISTRY): Define the _key class.
4171
4172 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4173
4174         * NEWS: Merge two 'New commands' sections.
4175
4176 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4177
4178         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4179         parameter and use Ada language definition instead.
4180         (ada_val_print_ptr): Remove unused language parameter.
4181         (ada_val_print_num): Remove language parameter and use Ada language
4182         definition instead.
4183         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4184         parameter.
4185         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4186         parameter and use Ada language definition instead.
4187         (ada_val_print_1): Update all ada_val_print_xxx calls.
4188         Remove language parameter.
4189         (ada_val_print): Update ada_val_print_1 call.
4190
4191 2019-05-08  Tom Tromey  <tromey@adacore.com>
4192
4193         * remote.c (remote_hw_watchpoint_limit)
4194         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4195         Now static.
4196
4197 2019-05-08  Tom Tromey  <tromey@adacore.com>
4198
4199         * maint.c (_initialize_maint_cmds): Move initialization code to
4200         remote.c.
4201         (watchdog, show_watchdog): Move to remote.c.
4202         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4203         "watchdog" static.
4204         (_initialize_remote): Move initialization code from maint.c.
4205         * defs.h (watchdog): Don't declare.
4206
4207 2019-05-08  Tom Tromey  <tromey@adacore.com>
4208
4209         * tui/tui-interp.c: Include main.h.
4210         * interps.c: Include main.h.
4211         * main.h (interpreter_p): Declare.
4212         * defs.h (interpreter_p): Don't declare.
4213
4214 2019-05-08  Tom Tromey  <tromey@adacore.com>
4215
4216         * dwarf2loc.c: Include dwarf2read.h.
4217         * defs.h (read_unsigned_leb128): Don't declare.
4218         * dwarf2read.h (read_unsigned_leb128): Declare.
4219
4220 2019-05-08  Tom Tromey  <tromey@adacore.com>
4221
4222         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4223         method.
4224
4225 2019-05-08  Tom Tromey  <tromey@adacore.com>
4226
4227         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4228         when no wrap column is set.
4229
4230 2019-05-08  Tom Tromey  <tromey@adacore.com>
4231
4232         * c-lang.c (c_get_string): Handle non-C-style arrays.
4233
4234 2019-05-08  Tom Tromey  <tromey@adacore.com>
4235
4236         * typeprint.c (print_offset_data::update): Print the bit offset,
4237         not the number of bits remaining.
4238
4239 2019-05-08  Tom Tromey  <tromey@adacore.com>
4240
4241         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4242         padding at end of comment.
4243
4244 2019-05-08  Tom Tromey  <tromey@adacore.com>
4245
4246         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4247         Compare main types.
4248
4249 2019-05-06  Tom Tromey  <tom@tromey.com>
4250
4251         * common/scoped_mmap.c: Include common-defs.h.
4252         * common/scoped_mmap.h: Don't include config.h.
4253
4254 2019-05-04  Tom Tromey  <tom@tromey.com>
4255
4256         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4257         (struct aarch64_call_info): Add initializers.
4258         <si>: Now a std::vector.
4259         (pass_on_stack, aarch64_push_dummy_call): Update.
4260
4261 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4262             Tom Tromey  <tom@tromey.com>
4263
4264         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4265         (ppc_threads): Now a std::vector.  Now static.
4266         (hwdebug_find_thread_points_by_tid)
4267         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4268         Update.
4269
4270 2019-05-04  Tom Tromey  <tom@tromey.com>
4271
4272         * arc-tdep.c (arc_tdesc_init): Return bool.
4273
4274 2019-05-04  Tom Tromey  <tom@tromey.com>
4275
4276         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4277         Use gdb_assert_not_reached.
4278
4279 2019-05-04  Tom Tromey  <tom@tromey.com>
4280
4281         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4282         "false".
4283
4284 2019-05-04  Tom Tromey  <tom@tromey.com>
4285
4286         * arc-tdep.c (arc_tdesc_init): Use bool.
4287
4288 2019-05-04  Tom Tromey  <tom@tromey.com>
4289
4290         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4291
4292 2019-05-04  Tom Tromey  <tom@tromey.com>
4293
4294         * cli/cli-cmds.c (valid_command_p): Return bool.
4295
4296 2019-05-04  Tom Tromey  <tom@tromey.com>
4297
4298         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4299         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4300
4301 2019-05-04  Raul Tambre  <raul@tambre.ee>
4302
4303         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4304         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4305         operator for comparison.
4306
4307 2019-05-04  Tom Tromey  <tom@tromey.com>
4308
4309         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4310         (lookup_partial_symbol, print_partial_symbols)
4311         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4312         (psymbol_compare): Update.
4313         (add_psymbol_to_bcache): Clear the entire psymbol.
4314         (maintenance_check_psymtabs): Update.
4315         * psympriv.h (struct partial_symbol): Don't derive from
4316         general_symbol_info.
4317         <obj_section, unrelocated_address, address,
4318         set_unrelocated_address>: Update.
4319         <ginfo>: New member.
4320         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4321         (debug_names::write_psymbols): Update.
4322
4323 2019-05-04  Tom de Vries  <tdevries@suse.de>
4324
4325         * contrib/cc-with-tweaks.sh: Support -n arg.
4326
4327 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4328
4329         * corelow.c (core_target::detach): Ensure frame cache and
4330         register caches are cleared.
4331         inferior.c (exit_inferior_1): Likewise.
4332
4333 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4334             Tom Tromey  <tom@tromey.com>
4335
4336         * dictionary.c (collate_pending_symbols_by_language): Remove
4337         "struct" from foreach.
4338         * symtab.c (lookup_global_symbol_from_objfile)
4339         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4340         foreach.
4341         * ser-tcp.c (net_open): Remove "struct" from foreach.
4342         * objfiles.c (objfile_relocate, objfile_rebase)
4343         (objfile_has_symbols): Remove "struct" from foreach.
4344         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4345         from foreach.
4346         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4347         foreach.
4348         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4349         "struct" from foreach.
4350         * ada-lang.c (create_excep_cond_exprs)
4351         (ada_exception_catchpoint_cond_string): Remove "struct" from
4352         foreach.
4353
4354 2019-05-03  Tom Tromey  <tromey@adacore.com>
4355
4356         * ada-exp.y (convert_char_literal): Check suffix of each
4357         enumerator.
4358
4359 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4360
4361         PR ada/21406:
4362         * ada-exp.y (yywrap): Don't define.
4363         * ada-lex.l (%option): Add noyywrap
4364         (yywrap): Remove.
4365
4366 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4367
4368         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4369         _WIN32_WINNT to the XP level, unless already defined to a higher
4370         level.
4371
4372         * unittests/parse-connection-spec-selftests.c:
4373         * ser-tcp.c:
4374         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4375         override.
4376
4377         * symfile.c (find_separate_debug_file): Remove colon from the
4378         drive spec of DOS/Windows file names of the target, so that the
4379         file name produced from DEBUGDIR and the target's directory will
4380         be valid on DOS/Windows systems.
4381
4382 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4383
4384         * rust-lang.c (val_print_struct): Handle printing structures
4385         containing strings.
4386
4387 2019-05-02  Tom Tromey  <tromey@adacore.com>
4388
4389         * valarith.c (_initialize_valarith): Remove.
4390
4391 2019-05-01  Tom Tromey  <tromey@adacore.com>
4392
4393         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4394         bitfields.
4395
4396 2019-05-01  Tom Tromey  <tromey@adacore.com>
4397
4398         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4399         for big-endian copies.
4400
4401 2019-04-30  Ali Tamur  <tamur@google.com>
4402         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4403         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4404         (read_3_bytes): New function.
4405
4406 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4407
4408         * windows-nat.c (main_thread_id): Delete.
4409         (handle_output_debug_string): Replace main_thread_id by
4410         current_event.dwThreadId.
4411         (fake_create_process): Likewise.
4412         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4413         Do not set main_thread_id.
4414         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4415         current_event.dwThreadId.
4416         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4417
4418 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4419
4420         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4421         Use current_event.dwThreadId instead of main_thread_id.
4422
4423 2019-04-30  Tom Tromey  <tromey@adacore.com>
4424
4425         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4426         (create_excep_cond_exprs): Iterate over program spaces.
4427         (ada_exception_catchpoint_cond_string): Examine all minimal
4428         symbols for exception types.
4429
4430 2019-04-30  Tom Tromey  <tromey@adacore.com>
4431
4432         PR c++/24470:
4433         * dwarf2read.c (process_structure_scope): Handle case where type
4434         has template parameters but no symbol was created.
4435
4436 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4437             Chris January  <chris.january@arm.com>
4438
4439         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4440         qualifier.
4441         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4442
4443 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4444
4445         * f-typeprint.c (f_print_type): Update rules for printing
4446         whitespace.
4447         (f_type_print_varspec_suffix): Likewise.
4448
4449 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4450             Chris January  <chris.january@arm.com>
4451
4452         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4453         function arguments.
4454
4455 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4456
4457         * f-lang.c (build_fortran_types): Change name of void type to
4458         lower case.
4459         * f-typeprint.c (f_type_print_base): Print the name of the void
4460         type, rather than a fixed string.
4461         * f-valprint.c (f_decorations): Use lower case void string.
4462
4463 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4464             Chris January  <chris.january@arm.com>
4465
4466         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4467         types for Fortran.
4468
4469 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4470             Chris January  <chris.january@arm.com>
4471             David Lecomber  <david.lecomber@arm.com>
4472
4473         * f-exp.y (BINOP_INTRINSIC): New token.
4474         (exp): New parser rule handling BINOP_INTRINSIC.
4475         (f77_keywords): Add new builtin procedures.
4476         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4477         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4478         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4479         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4480         (print_unop_subexp_f): New function.
4481         (print_binop_subexp_f): New function.
4482         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4483         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4484         (dump_subexp_body_f): Likewise.
4485         (operator_check_f): Likewise.
4486         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4487         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4488
4489 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4490
4491         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4492         UNOP_KIND.
4493         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4494         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4495         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4496         (operator_length_f): New fuction.
4497         (print_subexp_f): New function.
4498         (op_name_f): New function.
4499         (dump_subexp_body_f): New function.
4500         (operator_check_f): New function.
4501         (exp_descriptor_f): Replace standard expression handling functions
4502         with new functions.
4503         * gdb/fortran-operator.def: New file.
4504         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4505         * gdb/std-operator.def: Remove UNOP_KIND.
4506
4507 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4508
4509         * std-operator.def: Remove unbalanced, stray double quote
4510         character.
4511
4512 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4513             Chris January  <chris.january@arm.com>
4514             Daniel Everett  <daniel.everett@arm.com>
4515             Nick Forrington  <nick.forrington@arm.com>
4516             Richard Bunt  <richard.bunt@arm.com>
4517
4518         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4519         of depth when printing anonymous structs or unions.
4520         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4521         Don't print either the top-level value, or the children if the
4522         max-depth is exceeded.
4523         (ppscm_print_children): When printing the key of a map, allow one
4524         extra level of depth.
4525         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4526         print either the top-level value, or the children if the max-depth
4527         is exceeded.
4528         (print_children): When printing the key of a map, allow one extra
4529         level of depth.
4530         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4531         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4532         (user_print_options): Initialise max_depth field.
4533         (val_print_scalar_or_string_type_p): New function.
4534         (val_print): Check to see if the max depth has been reached.
4535         (val_print_check_max_depth): Define new function.
4536         (show_print_max_depth): New function.
4537         (_initialize_valprint): Add 'print max-depth' option.
4538         * valprint.h (struct value_print_options) <max_depth>: New field.
4539         (val_print_check_max_depth): Declare new function.
4540         * NEWS: Document new feature.
4541
4542 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4543
4544         * ada-lang.c (ada_language_defn): Initialise new field.
4545         * c-lang.c (c_is_string_type_p): New function.
4546         (c_language_defn): Initialise new field.
4547         (cplus_language_defn): Initialise new field.
4548         (asm_language_defn): Initialise new field.
4549         (minimal_language_defn): Initialise new field.
4550         * c-lang.h (c_is_string_type_p): Declare new function.
4551         * d-lang.c (d_language_defn): Initialise new field.
4552         * f-lang.c (f_is_string_type_p): New function.
4553         (f_language_defn): Initialise new field.
4554         * go-lang.c (go_is_string_type_p): New function.
4555         (go_language_defn): Initialise new field.
4556         * language.c (default_is_string_type_p): New function.
4557         (unknown_language_defn): Initialise new field.
4558         (auto_language_defn): Initialise new field.
4559         * language.h (struct language_defn) <la_is_string_type_p>: New
4560         member variable.
4561         (default_is_string_type_p): Declare new function.
4562         * m2-lang.c (m2_language_defn): Initialise new field.
4563         * objc-lang.c (objc_language_defn): Initialise new field.
4564         * opencl-lang.c (opencl_language_defn): Initialise new field.
4565         * p-lang.c (pascal_is_string_type_p): New function.
4566         (pascal_language_defn): Initialise new field.
4567         * rust-lang.c (rust_is_string_type_p): New function.
4568         (rust_language_defn): Initialise new field.
4569
4570 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4571
4572         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4573         New field.
4574         * ada-lang.c (ada_language_defn): Initialise new field.
4575         * c-lang.c (c_language_defn): Likewise.
4576         (cplus_language_defn): Likewise.
4577         (asm_language_defn): Likewise.
4578         (minimal_language_defn): Likewise.
4579         * d-lang.c (d_language_defn): Likewise.
4580         * f-lang.c (f_language_defn): Likewise.
4581         * go-lang.c (go_language_defn): Likewise.
4582         * language.c (unknown_language_defn): Likewise.
4583         (auto_language_defn): Likewise.
4584         * m2-lang.c (m2_language_defn): Likewise.
4585         * objc-lang.c (objc_language_defn): Likewise.
4586         * opencl-lang.c (opencl_language_defn): Likewise.
4587         * p-lang.c (pascal_language_defn): Likewise.
4588         * rust-lang.c (rust_language_defn): Likewise.
4589
4590 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4591
4592         * ada-lang.c (ada_is_character_type): Change return type to bool.
4593         (ada_is_string_type): Likewise.
4594         * ada-lang.h (ada_is_character_type): Update declaration
4595         (ada_is_string_type): Likewise.
4596
4597 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4598
4599         Support style in 'frame|thread apply'
4600
4601         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4602         * record.c (record_start, record_stop): Update callers of
4603         execute_command_to_string with false.
4604         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4605         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4606         methods.
4607         (class string_file): New constructor with term_out parameter.
4608         Override methods term_out and can_emit_style_escape.  New member
4609         term_out.
4610         (class stdio_file): Override can_emit_style_escape.
4611         (class tee_file): Override term_out and can_emit_style_escape.
4612         * utils.h (can_emit_style_escape): Remove.
4613         * utils.c (can_emit_style_escape): Likewise.
4614         Update all callers of can_emit_style_escape (SOMESTREAM) to
4615         SOMESTREAM->can_emit_style_escape.
4616         * source-cache.c (source_cache::get_source_lines): Likewise.
4617         * stack.c (frame_apply_command_count): Call execute_command_to_string
4618         passing the term_out characteristic of the current gdb_stdout.
4619         * thread.c (thr_try_catch_cmd): Likewise.
4620         * top.c (execute_command_to_string): pass term_out parameter
4621         to construct the string_file for the command output.
4622         * ui-file.c (term_cli_styling): New function (most code moved
4623         from utils.c can_emit_style_escape).
4624         (string_file::string_file, string_file::can_emit_style_escape,
4625         stdio_file::can_emit_style_escape, tee_file::term_out,
4626         tee_file::can_emit_style_escape): New functions.
4627
4628 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4629
4630         * NEWS: Mention the new set|show may-call-functions.
4631         * infcall.c (may_call_functions_p): New variable.
4632         (show_may_call_functions_p): New function.
4633         (call_function_by_hand_dummy): Throws an error if not
4634         may-call-functions.
4635         (_initialize_infcall): Call add_setshow_boolean_cmd for
4636         may-call-functions.
4637
4638 2019-04-25  Keith Seitz  <keiths@redhat.com>
4639
4640         PR c++/24367
4641         * cp-support.c (inspect_type): Don't attempt substitutions
4642         of symbol with the same name.
4643
4644 2019-04-25  Tom Tromey  <tromey@adacore.com>
4645
4646         PR gdb/24475:
4647         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4648         static.
4649
4650 2019-04-25  Tom Tromey  <tromey@adacore.com>
4651
4652         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4653         rvalue reference.
4654         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4655         (gdb_xml_parser::parse): Use std::move.
4656         * python/python-internal.h (gdbpy_convert_exception): Take a const
4657         reference.
4658         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4659         std::move.
4660         * python/py-utils.c (gdbpy_convert_exception): Take a const
4661         reference.
4662         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4663         Use std::move.
4664         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4665         Use std::move.
4666         * mi/mi-main.c (mi_print_exception): Take a const reference.
4667         * main.c (handle_command_errors): Take a const reference.
4668         * linespec.c (parse_linespec): Use std::move.
4669         * infcall.c (run_inferior_call): Use std::move.
4670         (call_function_by_hand_dummy): Use std::move.
4671         * exec.c (try_open_exec_file): Use std::move.
4672         * exceptions.h (exception_print, exception_fprintf)
4673         (exception_print_same): Update.
4674         * exceptions.c (print_exception, exception_print)
4675         (exception_fprintf, exception_print_same): Change parameters to
4676         const reference.
4677         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4678         * common/new-op.c: Use std::move.
4679         * common/common-exceptions.h (struct gdb_exception): Add move
4680         constructor.
4681         (struct gdb_exception_error, struct gdb_exception_quit, struct
4682         gdb_quit_bad_alloc): Change constructor to move constructor.
4683         (throw_exception): Change parameter to rvalue reference.
4684         * common/common-exceptions.c (throw_exception): Take rvalue
4685         reference.
4686         * cli/cli-interp.c (safe_execute_command): Use std::move.
4687         * breakpoint.c (insert_bp_location, location_to_sals): Use
4688         std::move.
4689
4690 2019-04-25  Tom Tromey  <tromey@adacore.com>
4691
4692         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4693         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4694         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4695         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4696         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4697         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4698         guile/scm-value.c: Use unpack.
4699         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4700         gdbscm_gdb_exception.
4701         (gdbscm_throw_gdb_exception): Likewise.
4702         (struct gdbscm_gdb_exception): New.
4703         (unpack): New function.
4704         (gdbscm_wrap): Use unpack.
4705
4706 2019-04-25  Tom Tromey  <tromey@adacore.com>
4707
4708         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4709         (gdb_rl_callback_handler): Use std::move.
4710         * common/common-exceptions.h (struct gdb_exception): Add move
4711         assignment operator.
4712         (throw_exception_sjlj): Change "exception" to const reference.
4713         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4714         (throw_exception_sjlj): Change "exception" to const reference.
4715
4716 2019-04-25  Tom Tromey  <tromey@adacore.com>
4717
4718         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4719         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4720         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4721         Update.
4722         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4723         Update.
4724         * mi/mi-interp.c (mi_interp::exec): Update.
4725         * linespec.c (parse_linespec): Update.
4726         * infcall.c (run_inferior_call): Update.
4727         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4728         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4729         (gdbscm_lookup_global_symbol): Update.
4730         * guile/scm-param.c (gdbscm_parameter_value): Update.
4731         * guile/scm-frame.c (gdbscm_frame_read_register)
4732         (gdbscm_frame_read_var): Update.
4733         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4734         * exec.c (try_open_exec_file): Update.
4735         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4736         (gdb_rl_callback_handler): Update.
4737         * common/common-exceptions.h (exception_none): Don't declare.
4738         * common/common-exceptions.c (exception_none): Don't define.
4739         (struct catcher) <exception>: Update.
4740         * cli/cli-interp.c (safe_execute_command): Update.
4741         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4742
4743 2019-04-25  Ali Tamur  <tamur@google.com>
4744
4745         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4746         (read_attribute_value): Likewise.
4747         (dwarf2_read_addr_index): Update comment.
4748         (read_str_index): Add DW_FORM_strx.
4749         (dwarf2_string_attr): Likewise.
4750         (dwarf2_const_value_attr): Likewise.
4751         (dump_die_shallow): Likewise.
4752         (dwarf2_fetch_constant_bytes): Likewise.
4753         (skip_form_bytes): Likewise.
4754         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4755
4756 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4757
4758         PR corefiles/11608
4759         PR corefiles/18187
4760         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4761         OFFSET.  Verify if current mapping contains an ELF header.
4762         (linux_find_memory_regions_full): Adjust call to
4763         dump_mapping_p.
4764
4765 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4766             Kang Li <kanglictf@gmail.com>
4767
4768         PR gdb/21600
4769
4770         * dwarf2-frame.c (read_initial_length): Be consistent about using
4771         unsigned representation of length.
4772         (decode_frame_entry_1): Likewise.  Check for wraparound of
4773         end pointer as well as buffer overflow.
4774
4775 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4776
4777         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4778         "vq".
4779
4780 2019-04-24  Tom Tromey  <tromey@adacore.com>
4781
4782         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4783
4784 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4785
4786         * s12z-tdep.c (s12z_unwind_pc): Delete.
4787         (s12z_unwind_sp): Delete.
4788         (s12z_gdbarch_init): Don't register deleted functions with
4789         gdbarch.
4790
4791 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4792
4793         * rl78-tdep.c (rl78_unwind_sp): Delete.
4794         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4795
4796 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4797
4798         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4799         (xstormy16_unwind_pc): Delete.
4800         (xstormy16_dummy_id): Delete.
4801         (xstormy16_gdbarch_init): Don't register deleted functions with
4802         gdbarch.
4803
4804 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4805
4806         * vax-tdep.c (vax_unwind_pc): Delete.
4807         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4808
4809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4810
4811         * v850-tdep.c (v850_unwind_sp): Delete.
4812         (v850_unwind_pc): Delete.
4813         (v850_dummy_id): Delete.
4814         (v850_gdbarch_init): Don't register deleted functions with
4815         gdbarch.
4816
4817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4820         (tilegx_unwind_pc): Delete.
4821         (tilegx_unwind_dummy_id): Delete.
4822         (tilegx_gdbarch_init): Don't register deleted functions with
4823         gdbarch.
4824
4825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4826
4827         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4828         (tic6x_dummy_id): Delete.
4829         (tic6x_gdbarch_init): Don't register deleted functions with
4830         gdbarch.
4831
4832 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4833
4834         * sparc-tdep.c (sparc_unwind_pc): Delete.
4835         (sparc32_gdbarch_init): Don't register deleted function with
4836         gdbarch.
4837
4838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4839
4840         * sh-tdep.c (sh_unwind_sp): Delete.
4841         (sh_unwind_pc): Delete.
4842         (sh_dummy_id): Delete.
4843         (sh_gdbarch_init): Don't register deleted functions with
4844         gdbarch.
4845
4846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4847
4848         * score-tdep.c (score_unwind_sp): Delete.
4849         (score_unwind_pc): Delete.
4850         (score_dummy_id): Delete.
4851         (score_gdbarch_init): Don't register deleted functions with
4852         gdbarch.
4853
4854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4855
4856         * rx-tdep.c (rx_unwind_pc): Delete.
4857         (rx_unwind_sp): Delete.
4858         (rx_dummy_id): Delete.
4859         (rx_gdbarch_init): Don't register deleted functions with
4860         gdbarch.  Update comment.
4861
4862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4863
4864         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4865         (rs6000_dummy_id): Delete.
4866         (rs6000_gdbarch_init): Don't register deleted functions with
4867         gdbarch.
4868
4869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4870
4871         * or1k-tdep.c (or1k_dummy_id): Delete.
4872         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4873
4874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4875
4876         * nios2-tdep.c (nios2_dummy_id): Delete.
4877         (nios2_unwind_sp): Delete.
4878         (nios2_gdbarch_init): Don't register deleted functions with
4879         gdbarch.
4880
4881 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4882
4883         * nds32-tdep.c (nds32_dummy_id): Delete.
4884         (nds32_unwind_pc): Delete.
4885         (nds32_unwind_sp): Delete.
4886         (nds32_gdbarch_init): Don't register deleted functions with
4887         gdbarch.
4888
4889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4890
4891         * msp430-tdep.c (msp430_unwind_pc): Delete.
4892         (msp430_unwind_sp): Delete.
4893         (msp430_dummy_id): Delete.
4894         (msp430_gdbarch_init): Don't register deleted functions with
4895         gdbarch.
4896
4897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4898
4899         * moxie-tdep.c (moxie_unwind_sp): Delete.
4900         (moxie_unwind_pc): Delete.
4901         (moxie_dummy_id): Delete.
4902         (moxie_gdbarch_init): Don't register deleted functions with
4903         gdbarch.
4904
4905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4906
4907         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4908         (mn10300_unwind_pc): Delete.
4909         (mn10300_unwind_sp): Delete.
4910         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4911         mn10300_unwind_sp.
4912         (mn10300_frame_unwind_init): Don't register deleted functions with
4913         gdbarch.
4914
4915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4916
4917         * mep-tdep.c (mep_unwind_pc): Delete.
4918         (mep_unwind_sp): Delete.
4919         (mep_dummy_id): Delete.
4920         (mep_gdbarch_init): Don't register deleted functions with
4921         gdbarch.
4922
4923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4924
4925         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4926         (m68hc11_unwind_sp): Delete.
4927         (m68hc11_gdbarch_init): Don't register deleted functions with
4928         gdbarch.
4929
4930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4931
4932         * m32r-tdep.c (m32r_unwind_sp): Delete.
4933         (m32r_unwind_pc): Delete.
4934         (m32r_dummy_id): Delete.
4935         (m32r_gdbarch_init): Don't register deleted functions with
4936         gdbarch.
4937
4938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4939
4940         * m32c-tdep.c (m32c_unwind_pc): Delete.
4941         (m32c_unwind_sp): Delete.
4942         (m32c_dummy_id): Delete.
4943         (m32c_gdbarch_init): Don't register deleted functions with
4944         gdbarch.
4945
4946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4947
4948         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4949         (lm32_unwind_pc): Delete.
4950         (lm32_dummy_id): Delete.
4951         (lm32_gdbarch_init): Don't register deleted functions with
4952         gdbarch.
4953
4954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4955
4956         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4957         (iq2000_unwind_pc): Delete.
4958         (iq2000_dummy_id): Delete.
4959         (iq2000_gdbarch_init): Don't register deleted functions with
4960         gdbarch.
4961
4962 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4963
4964         * nds32-tdep.c (nds32_type_align): Delete.
4965         (nds32_push_dummy_call): Use type_align instead.
4966
4967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4968
4969         * arm-tdep.c (arm_type_align): Only handle vector override case.
4970         (arm_push_dummy_call): Use type_align.
4971         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4972
4973 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4974
4975         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4976         case.
4977         (pass_on_stack): Use type_align.
4978         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4979         function.
4980
4981 2019-04-23  Tom Tromey  <tromey@adacore.com>
4982
4983         * dwarf2read.c (line_header::file_name_at): Remove unused
4984         overload.
4985
4986 2019-04-23  Tom de Vries  <tdevries@suse.de>
4987
4988         PR gdb/24438
4989         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4990         invocation.
4991
4992
4993 2019-03-27  Ali Tamur  <tamur@google.com>
4994
4995         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4996         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4997         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4998         (dwarf_expr_context::get_addr_index): Likewise
4999         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5000         (symbol_needs_eval_context::get_addr_index): Likewise
5001         (disassemble_dwarf_expression): Add DW_OP_addrx
5002         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5003         (read_cutu_die_from_dwo): Update comment
5004         (skip_one_die): Add DW_FORM_addrx
5005         (read_attribute_value): Likewise
5006         (var_decode_location): Add DW_OP_addrx
5007         (dwarf2_const_value_attr): Add DW_FORM_addrx
5008         (dump_die_shallow): Likewise
5009         (dwarf2_fetch_constant_bytes): Likewise
5010         (decode_locdesc): Add DW_OP_addrx
5011         (skip_form_bytes): Add DW_FORM_addrx
5012
5013 2019-04-22  Ali Tamur  <tamur@google.com>
5014
5015         * MAINTAINERS (Write After Approval): Add self.
5016
5017 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5018
5019         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5020         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5021         (open_symbol_file_object): Likewise.
5022         (svr4_default_sos): Add info parameter.
5023         (svr4_read_so_list): Likewise.
5024         (svr4_current_sos_direct): Adjust functions calls to pass down
5025         info.
5026         (svr4_current_sos_1): Add info parameter.
5027         (svr4_current_sos): Call get_svr4_info, pass info down to
5028         svr4_current_sos_1.
5029         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5030         get_svr4_info.
5031         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5032         get_svr4_info.
5033         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5034         to get_svr4_info.
5035         (probes_table_remove_objfile_probes): Likewise.
5036         (register_solib_event_probe): Add info parameter.
5037         (solist_update_incremental): Pass info parameter down to
5038         svr4_read_so_list.
5039         (disable_probes_interface): Add info parameter.
5040         (svr4_handle_solib_event): Pass current_program_space to
5041         get_svr4_info.  Adjust disable_probes_interface cleanup.
5042         (svr4_create_probe_breakpoints): Add info parameter, pass it
5043         down to register_solib_event_probe.
5044         (svr4_create_solib_event_breakpoints): Add info parameter,
5045         pass it down to svr4_create_probe_breakpoints.
5046         (enable_break): Pass info down to
5047         svr4_create_solib_event_breakpoints.
5048         (svr4_solib_create_inferior_hook): Pass current_program_space to
5049         get_svr4_info.
5050         (svr4_clear_solib): Likewise.
5051
5052 2019-04-22  Pedro Alves  <palves@redhat.com>
5053
5054         * solib-svr4.c (svr4_free_objfile_observer): New.
5055         (probe_and_action::objfile): New field.
5056         (probes_table_htab_remove_objfile_probes)
5057         (probes_table_remove_objfile_probes): New functions.
5058         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5059         in the new probe_and_action.  Don't store the probe in 'lookup'.
5060         (svr4_create_probe_breakpoints): Pass objfile to
5061         register_solib_event_probe.
5062         (_initialize_svr4_solib): Register a free_objfile observer.
5063
5064 2019-04-19  Tom Tromey  <tom@tromey.com>
5065
5066         * common/queue.h: Remove.
5067
5068 2019-04-19  Tom Tromey  <tom@tromey.com>
5069
5070         * event-loop.c: Don't include "common/queue.h".
5071
5072 2019-04-19  Tom Tromey  <tom@tromey.com>
5073
5074         * remote.c (remote_target): Use delete.
5075         * remote-notif.h: Include <list>, not "common/queue.h".
5076         (notif_client_p): Remove typedef.
5077         (remote_notif_state): Add constructor, destructor, initializer.
5078         <notif_queue>: Now a std::list.
5079         (remote_notif_state_xfree): Don't declare.
5080         * remote-notif.c (remote_notif_process, handle_notification)
5081         (remote_notif_state_allocate): Update.
5082         (~remote_notif_state): Rename from remote_notif_state_xfree.
5083
5084 2019-04-19  Tom Tromey  <tom@tromey.com>
5085
5086         * symfile.c (reread_symbols): Update.
5087         * objfiles.c (objfile_register_static_link)
5088         (objfile_lookup_static_link): Update
5089         (~objfile) Don't delete static_links.
5090         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5091
5092 2019-04-19  Tom Tromey  <tom@tromey.com>
5093
5094         * type-stack.h (struct type_stack) <insert>: Constify string.
5095         * type-stack.c (type_stack::insert): Constify string.
5096         * gdbtypes.h (lookup_template_type): Update.
5097         (address_space_name_to_int): Update.
5098         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5099         const.
5100         (lookup_template_type): Make name const.
5101         * c-exp.y: Update rules.
5102         (lex_one_token, classify_name, classify_inner_name)
5103         (c_print_token): Update.
5104         * p-exp.y: Update rules.
5105         (yylex): Update.
5106         * f-exp.y: Update rules.
5107         (yylex): Update.
5108         * d-exp.y: Update rules.
5109         (lex_one_token, classify_name, classify_inner_name): Update.
5110         * parse.c (write_dollar_variable, copy_name): Return std::string.
5111         * parser-defs.h (copy_name): Change return type.
5112         * m2-exp.y: Update rules.
5113         (yylex): Update.
5114         * go-exp.y (lex_one_token): Update.
5115         Update rules.
5116         (classify_unsafe_function, classify_packaged_name)
5117         (classify_name, yylex): Update.
5118
5119 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5120
5121         * configure.ac: add --enable-source-highlight switch.
5122         * configure: Regenerate.
5123         * top.c (print_gdb_version): plumb --enable-source-highlight
5124         status to "show configuration".
5125
5126 2019-04-19  Tom Tromey  <tromey@adacore.com>
5127
5128         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5129         Check ADA_TYPE_P.
5130         (empty_record, ada_template_to_fixed_record_type_1)
5131         (template_to_static_fixed_type)
5132         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5133         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5134         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5135         macros.
5136
5137 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5138
5139         PR symtab/24423:
5140         * source.c (print_source_lines_base): Advance "iter" when a
5141         control character is seen.
5142
5143 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5144
5145         * inferior.h (struct infcall_suspend_state_deleter):
5146         Catch exception in destructor to avoid crash.
5147
5148 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5149
5150         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5151         close to the add_com "shell".
5152
5153 2019-04-18  Tom Tromey  <tromey@adacore.com>
5154
5155         * process-stratum-target.h (class process_stratum_target)
5156         <stratum>: Add "final".
5157
5158 2019-04-17  Tom Tromey  <tromey@adacore.com>
5159
5160         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5161         against nullptr before use.
5162
5163 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5164
5165         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5166
5167 2019-04-17  Jim Wilson  <jimw@sifive.com>
5168             Andrew Burgess  <andrew.burgess@embecosm.com>
5169
5170         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5171         code read might fail, assume 4-byte breakpoint in that case.
5172
5173 2019-04-15  Leszek Swirski  <leszeks@google.com>
5174
5175         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5176         rather than a hand-rolled POD check when checking for forced MEMORY
5177         classification.
5178
5179 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5180
5181         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5182         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5183         function.
5184         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5185         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5186         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5187         declaration.
5188
5189 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5190
5191         * aarch64-linux-nat.c
5192         (aarch64_linux_nat_target::thread_architecture): Add override.
5193         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5194         each VQ.
5195
5196 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5197
5198         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5199
5200 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5201
5202         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5203         target types of size 96-bits, add some additional comments, and
5204         check that the builtin type we found was the correct size.
5205
5206 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5207
5208         * utils.c (prompt_for_continue): Don't restore the styling at the
5209         end, as applied_style has the wrong value.  This fixes styling in
5210         long lists of file names that are interrupted by the "Continue?"
5211         prompt.
5212
5213 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5214
5215         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5216         * c-lang.c (c_language_defn): Likewise.
5217         (cplus_language_defn): Likewise.
5218         (asm_language_defn): Likewise.
5219         (minimal_language_defn): Likewise.
5220         * d-lang.c (d_language_defn): Likewise.
5221         * f-lang.c (f_language_defn): Likewise.
5222         * go-lang.c (go_language_defn): Likewise.
5223         * language.c (unknown_language_defn): Likewise.
5224         (auto_language_defn): Likewise.
5225         * language.h (struct language_defn): Remove la_magic field.
5226         (LANG_MAGIC): Delete.
5227         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5228         * objc-lang.c (objc_language_defn): Likewise.
5229         * opencl-lang.c (opencl_language_defn): Likewise.
5230         * p-lang.c (pascal_language_defn): Likewise.
5231         * rust-lang.c (rust_language_defn): Likewise.
5232
5233 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5234
5235         * riscv-tdep.c (riscv_type_align): New function.
5236         (riscv_type_alignment): Delete.
5237         (riscv_arg_location): Use 'type_align'.
5238         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5239
5240 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5241
5242         * gdbtypes.c (type_align): A struct with no non-static fields also
5243         has alignment of 1.
5244
5245 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5246
5247         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5248         component to 0.
5249         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5250         member.
5251         (riscv_struct_info::analyse): New implementation using new
5252         analyse_inner member function.
5253         (riscv_struct_info::field_offset): New member function.
5254         (riscv_struct_info::m_offsets): New member variable.
5255         (riscv_struct_info::analyse_inner): New private member function,
5256         takes the old implementation of riscv_struct_info::analyse but
5257         extended to track field offsets.
5258         (riscv_call_arg_struct): Update the struct folding special cases
5259         to handle cases where empty C++ structs, which are non-zero
5260         length, are found.
5261         (riscv_arg_location): Initialise the length of each location, a
5262         non-zero length now indicates the location is in use.
5263         (riscv_push_dummy_call): Allow for the first location having a
5264         non-zero offset when setting up arguments.
5265         (riscv_return_value): Likewise, but for return values.
5266
5267 2019-04-11  Tom Tromey  <tromey@adacore.com>
5268
5269         * utils.c (internal_vproblem): Make "msg" const.
5270
5271 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5272
5273         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5274         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5275         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5276         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5277
5278 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5279
5280         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5281         function.
5282         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5283         of amd64_collect_native_gregset.
5284         (amd64_linux_nat_target::store_registers): Likewise.
5285
5286 2019-04-10  Tom Tromey  <tom@tromey.com>
5287
5288         * symtab.c (lookup_global_symbol_from_objfile)
5289         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5290         * objfiles.h (class separate_debug_iterator): New.
5291         (class separate_debug_range): New.
5292         (struct objfile) <separate_debug_objfiles>: New method.
5293         (objfile_separate_debug_iterate): Don't declare.
5294         * objfiles.c (separate_debug_iterator::operator++): Rename from
5295         objfile_separate_debug_iterate.
5296         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5297         iterator.
5298         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5299         iterator.
5300
5301 2019-04-10  Tom Tromey  <tom@tromey.com>
5302
5303         * symfile.c (reread_symbols): Remove old comment.
5304         * objfiles.c (free_all_objfiles): Fix a typo.
5305
5306 2019-04-10  Tom Tromey  <tom@tromey.com>
5307
5308         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5309         * minsyms.c (lookup_minimal_symbol): Use foreach.
5310         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5311         (lookup_minimal_symbol_solib_trampoline): Likewise.
5312         * symfile.c (reread_symbols): Use foreach.
5313
5314 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5315             Tom Tromey  <tromey@adacore.com>
5316
5317         PR rust/24414:
5318         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5319         (rust_lex_int_test): Change "value" to be LONGEST.
5320         (rust_lex_tests): Add test for long integer literal.
5321
5322 2019-04-09  Tom Tromey  <tromey@adacore.com>
5323
5324         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5325         to bool.
5326         (extended_remote_target::attach): Update.
5327         (remote_target::remote_notice_new_inferior): Update.
5328         (remote_target::add_current_inferior_and_thread): Update.
5329         * inferior.c (exit_inferior_1): Use "false".
5330         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5331
5332 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5333
5334         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5335         the "start" command.
5336
5337 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5338
5339         * python/py-inferior.c (infpy_thread_from_thread_handle):
5340         Adjust comments to reflect renaming of thread_from_thread_handle
5341         to thread_from_handle.  Adjust keywords.  Fix type error message.
5342         (inferior_object_methods): Add thread_from_handle.  Retain
5343         thread_from_thread_handle, but mark it as deprecated.
5344
5345 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5346
5347         * gdbthread.h (find_thread_by_handle): Revise declaration.
5348         * thread.c (find_thread_by_handle): Likewise.  Adjust
5349         implementation too.
5350         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5351         support for buffer objects as handles.
5352
5353 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5354
5355         * python/py-infthread.c (thpy_thread_handle): New function.
5356         (thread_object_methods): Register thpy_thread_handle.
5357
5358 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5359
5360         * gdbthread.h (thread_to_thread_handle): Declare.
5361         * thread.c (gdbtypes.h): Include.
5362         (thread_to_thread_handle): New function.
5363
5364         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5365         (target_thread_info_to_thread_handle): Declare.
5366         * target.c (target_thread_info_to_thread_handle): New function.
5367         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5368         * target-delegates.c: Regenerate.
5369
5370         * linux-thread-db.c (class thread_db_target): Add method
5371         thread_info_to_thread_handle.
5372         (thread_db_target::thread_info_to_thread_handle): Define.
5373         * remote.c (class remote_target): Add new method
5374         thread_info_to_thread_handle.
5375         (remote_target::thread_info_to_thread_handle): Define.
5376
5377 2019-04-08  Pedro Alves  <palves@redhat.com>
5378
5379         * common/common-exceptions.c (throw_exception): Don't create
5380         named object to throw; throw directly.
5381         (throw_it): Likewise.  Don't initialize gdb_exception::message
5382         here, with new; pass FMT and AP to the ctor instead.
5383         * common/common-exceptions.h: Include <string>.
5384         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5385         const char *, va_list)): New ctor.  Use std::make_shared.
5386         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5387         errors)): Delete.
5388         (gdb_exception_error::gdb_exception_error(enum errors, const char
5389         *, va_list)): New.
5390         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5391         Add assertion.
5392         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5393         errors)): Delete.
5394         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5395         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5396         Add assertion.
5397
5398 2019-04-08  Tom Tromey  <tom@tromey.com>
5399
5400         * valops.c (value_rtti_indirect_type): Replace throw_exception
5401         with throw.
5402         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5403         with throw.
5404         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5405         throw.
5406         * target.c (target_translate_tls_address): Replace throw_exception
5407         with throw.
5408         * stack.c (frame_apply_command_count): Replace throw_exception
5409         with throw.
5410         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5411         throw.
5412         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5413         with throw.
5414         * rs6000-tdep.c (rs6000_frame_cache)
5415         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5416         * remote.c: Replace throw_exception with throw.
5417         * record-full.c (record_full_message, record_full_wait_1)
5418         (record_full_restore): Replace throw_exception with throw.
5419         * record-btrace.c:
5420         (get_thread_current_frame_id, record_btrace_start_replaying)
5421         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5422         (cmd_record_btrace_start): Replace throw_exception with throw.
5423         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5424         throw.
5425         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5426         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5427         * linespec.c:
5428         (find_linespec_symbols): Replace throw_exception with throw.
5429         * infrun.c (displaced_step_prepare, resume): Replace
5430         throw_exception with throw.
5431         * infcmd.c (post_create_inferior): Replace throw_exception with
5432         throw.
5433         * inf-loop.c (inferior_event_handler): Replace throw_exception
5434         with throw.
5435         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5436         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5437         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5438         (get_prev_frame_always, get_frame_pc_if_available)
5439         (get_frame_address_in_block_if_available, get_frame_language):
5440         Replace throw_exception with throw.
5441         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5442         throw_exception with throw.
5443         * eval.c (fetch_subexp_value, evaluate_var_value)
5444         (evaluate_funcall, evaluate_subexp_standard): Replace
5445         throw_exception with throw.
5446         * dwarf2loc.c (call_site_find_chain)
5447         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5448         Replace throw_exception with throw.
5449         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5450         with throw.
5451         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5452         throw.
5453         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5454         * completer.c (complete_line_internal): Replace throw_exception
5455         with throw.
5456         * compile/compile-object-run.c (compile_object_run): Replace
5457         throw_exception with throw.
5458         * cli/cli-script.c (process_next_line): Replace throw_exception
5459         with throw.
5460         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5461         (btrace_enable, btrace_maint_update_pt_packets): Replace
5462         throw_exception with throw.
5463         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5464         throw_exception with throw.
5465         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5466         throw_exception with throw.
5467         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5468         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5469         * aarch64-tdep.c (aarch64_make_prologue_cache)
5470         (aarch64_make_stub_cache): Replace throw_exception with throw.
5471
5472 2019-04-08  Tom Tromey  <tom@tromey.com>
5473
5474         * common/common-exceptions.c (throw_exception): Rename from
5475         throw_exception_cxx.  Remove old copy.  Make argument const.
5476         (throw_it): Create and throw exception objects directly.
5477         * common/common-exceptions.h (throw_exception): Make argument
5478         const.
5479         (struct gdb_exception_error): Add constructor.
5480         (struct gdb_exception_quit): Add constructor.
5481
5482 2019-04-08  Tom Tromey  <tom@tromey.com>
5483
5484         * common/common-exceptions.h (exception_rethrow): Don't declare.
5485         (TRY_SJLJ): Update comment.
5486         (TRY, CATCH, END_CATCH): Remove.
5487         * common/common-exceptions.c (exception_rethrow): Remove.
5488
5489 2019-04-08  Tom Tromey  <tom@tromey.com>
5490
5491         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5492         Remove.
5493         (gdb_exception_error): Rename from
5494         gdb_exception_RETURN_MASK_ERROR.
5495         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5496         (gdb_quit_bad_alloc): Update.
5497         * aarch64-tdep.c: Update.
5498         * ada-lang.c: Update.
5499         * ada-typeprint.c: Update.
5500         * ada-valprint.c: Update.
5501         * amd64-tdep.c: Update.
5502         * arch-utils.c: Update.
5503         * break-catch-throw.c: Update.
5504         * breakpoint.c: Update.
5505         * btrace.c: Update.
5506         * c-varobj.c: Update.
5507         * cli/cli-cmds.c: Update.
5508         * cli/cli-interp.c: Update.
5509         * cli/cli-script.c: Update.
5510         * common/common-exceptions.c: Update.
5511         * common/new-op.c: Update.
5512         * common/selftest.c: Update.
5513         * compile/compile-c-symbols.c: Update.
5514         * compile/compile-cplus-symbols.c: Update.
5515         * compile/compile-object-load.c: Update.
5516         * compile/compile-object-run.c: Update.
5517         * completer.c: Update.
5518         * corelow.c: Update.
5519         * cp-abi.c: Update.
5520         * cp-support.c: Update.
5521         * cp-valprint.c: Update.
5522         * darwin-nat.c: Update.
5523         * disasm-selftests.c: Update.
5524         * dtrace-probe.c: Update.
5525         * dwarf-index-cache.c: Update.
5526         * dwarf-index-write.c: Update.
5527         * dwarf2-frame-tailcall.c: Update.
5528         * dwarf2-frame.c: Update.
5529         * dwarf2loc.c: Update.
5530         * dwarf2read.c: Update.
5531         * eval.c: Update.
5532         * event-loop.c: Update.
5533         * event-top.c: Update.
5534         * exec.c: Update.
5535         * f-valprint.c: Update.
5536         * fbsd-tdep.c: Update.
5537         * frame-unwind.c: Update.
5538         * frame.c: Update.
5539         * gdbtypes.c: Update.
5540         * gnu-v3-abi.c: Update.
5541         * guile/guile-internal.h: Update.
5542         * guile/scm-block.c: Update.
5543         * guile/scm-breakpoint.c: Update.
5544         * guile/scm-cmd.c: Update.
5545         * guile/scm-disasm.c: Update.
5546         * guile/scm-frame.c: Update.
5547         * guile/scm-lazy-string.c: Update.
5548         * guile/scm-math.c: Update.
5549         * guile/scm-param.c: Update.
5550         * guile/scm-ports.c: Update.
5551         * guile/scm-pretty-print.c: Update.
5552         * guile/scm-symbol.c: Update.
5553         * guile/scm-symtab.c: Update.
5554         * guile/scm-type.c: Update.
5555         * guile/scm-value.c: Update.
5556         * i386-linux-tdep.c: Update.
5557         * i386-tdep.c: Update.
5558         * inf-loop.c: Update.
5559         * infcall.c: Update.
5560         * infcmd.c: Update.
5561         * infrun.c: Update.
5562         * jit.c: Update.
5563         * language.c: Update.
5564         * linespec.c: Update.
5565         * linux-fork.c: Update.
5566         * linux-nat.c: Update.
5567         * linux-tdep.c: Update.
5568         * linux-thread-db.c: Update.
5569         * main.c: Update.
5570         * mi/mi-cmd-break.c: Update.
5571         * mi/mi-cmd-stack.c: Update.
5572         * mi/mi-interp.c: Update.
5573         * mi/mi-main.c: Update.
5574         * objc-lang.c: Update.
5575         * p-valprint.c: Update.
5576         * parse.c: Update.
5577         * ppc-linux-tdep.c: Update.
5578         * printcmd.c: Update.
5579         * python/py-arch.c: Update.
5580         * python/py-breakpoint.c: Update.
5581         * python/py-cmd.c: Update.
5582         * python/py-finishbreakpoint.c: Update.
5583         * python/py-frame.c: Update.
5584         * python/py-framefilter.c: Update.
5585         * python/py-gdb-readline.c: Update.
5586         * python/py-inferior.c: Update.
5587         * python/py-infthread.c: Update.
5588         * python/py-lazy-string.c: Update.
5589         * python/py-linetable.c: Update.
5590         * python/py-objfile.c: Update.
5591         * python/py-param.c: Update.
5592         * python/py-prettyprint.c: Update.
5593         * python/py-progspace.c: Update.
5594         * python/py-record-btrace.c: Update.
5595         * python/py-record.c: Update.
5596         * python/py-symbol.c: Update.
5597         * python/py-type.c: Update.
5598         * python/py-unwind.c: Update.
5599         * python/py-utils.c: Update.
5600         * python/py-value.c: Update.
5601         * python/python.c: Update.
5602         * record-btrace.c: Update.
5603         * record-full.c: Update.
5604         * remote-fileio.c: Update.
5605         * remote.c: Update.
5606         * riscv-tdep.c: Update.
5607         * rs6000-aix-tdep.c: Update.
5608         * rs6000-tdep.c: Update.
5609         * rust-exp.y: Update.
5610         * rust-lang.c: Update.
5611         * s390-tdep.c: Update.
5612         * selftest-arch.c: Update.
5613         * solib-dsbt.c: Update.
5614         * solib-frv.c: Update.
5615         * solib-spu.c: Update.
5616         * solib-svr4.c: Update.
5617         * solib.c: Update.
5618         * sparc64-linux-tdep.c: Update.
5619         * stack.c: Update.
5620         * symfile-mem.c: Update.
5621         * symmisc.c: Update.
5622         * target.c: Update.
5623         * thread.c: Update.
5624         * top.c: Update.
5625         * tracefile-tfile.c: Update.
5626         * tui/tui.c: Update.
5627         * typeprint.c: Update.
5628         * unittests/cli-utils-selftests.c: Update.
5629         * unittests/parse-connection-spec-selftests.c: Update.
5630         * valops.c: Update.
5631         * valprint.c: Update.
5632         * value.c: Update.
5633         * varobj.c: Update.
5634         * windows-nat.c: Update.
5635         * x86-linux-nat.c: Update.
5636         * xml-support.c: Update.
5637
5638 2019-04-08  Tom Tromey  <tom@tromey.com>
5639
5640         * xml-support.c: Use C++ exception handling.
5641         * x86-linux-nat.c: Use C++ exception handling.
5642         * windows-nat.c: Use C++ exception handling.
5643         * varobj.c: Use C++ exception handling.
5644         * value.c: Use C++ exception handling.
5645         * valprint.c: Use C++ exception handling.
5646         * valops.c: Use C++ exception handling.
5647         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5648         handling.
5649         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5650         * typeprint.c: Use C++ exception handling.
5651         * tui/tui.c: Use C++ exception handling.
5652         * tracefile-tfile.c: Use C++ exception handling.
5653         * top.c: Use C++ exception handling.
5654         * thread.c: Use C++ exception handling.
5655         * target.c: Use C++ exception handling.
5656         * symmisc.c: Use C++ exception handling.
5657         * symfile-mem.c: Use C++ exception handling.
5658         * stack.c: Use C++ exception handling.
5659         * sparc64-linux-tdep.c: Use C++ exception handling.
5660         * solib.c: Use C++ exception handling.
5661         * solib-svr4.c: Use C++ exception handling.
5662         * solib-spu.c: Use C++ exception handling.
5663         * solib-frv.c: Use C++ exception handling.
5664         * solib-dsbt.c: Use C++ exception handling.
5665         * selftest-arch.c: Use C++ exception handling.
5666         * s390-tdep.c: Use C++ exception handling.
5667         * rust-lang.c: Use C++ exception handling.
5668         * rust-exp.y: Use C++ exception handling.
5669         * rs6000-tdep.c: Use C++ exception handling.
5670         * rs6000-aix-tdep.c: Use C++ exception handling.
5671         * riscv-tdep.c: Use C++ exception handling.
5672         * remote.c: Use C++ exception handling.
5673         * remote-fileio.c: Use C++ exception handling.
5674         * record-full.c: Use C++ exception handling.
5675         * record-btrace.c: Use C++ exception handling.
5676         * python/python.c: Use C++ exception handling.
5677         * python/py-value.c: Use C++ exception handling.
5678         * python/py-utils.c: Use C++ exception handling.
5679         * python/py-unwind.c: Use C++ exception handling.
5680         * python/py-type.c: Use C++ exception handling.
5681         * python/py-symbol.c: Use C++ exception handling.
5682         * python/py-record.c: Use C++ exception handling.
5683         * python/py-record-btrace.c: Use C++ exception handling.
5684         * python/py-progspace.c: Use C++ exception handling.
5685         * python/py-prettyprint.c: Use C++ exception handling.
5686         * python/py-param.c: Use C++ exception handling.
5687         * python/py-objfile.c: Use C++ exception handling.
5688         * python/py-linetable.c: Use C++ exception handling.
5689         * python/py-lazy-string.c: Use C++ exception handling.
5690         * python/py-infthread.c: Use C++ exception handling.
5691         * python/py-inferior.c: Use C++ exception handling.
5692         * python/py-gdb-readline.c: Use C++ exception handling.
5693         * python/py-framefilter.c: Use C++ exception handling.
5694         * python/py-frame.c: Use C++ exception handling.
5695         * python/py-finishbreakpoint.c: Use C++ exception handling.
5696         * python/py-cmd.c: Use C++ exception handling.
5697         * python/py-breakpoint.c: Use C++ exception handling.
5698         * python/py-arch.c: Use C++ exception handling.
5699         * printcmd.c: Use C++ exception handling.
5700         * ppc-linux-tdep.c: Use C++ exception handling.
5701         * parse.c: Use C++ exception handling.
5702         * p-valprint.c: Use C++ exception handling.
5703         * objc-lang.c: Use C++ exception handling.
5704         * mi/mi-main.c: Use C++ exception handling.
5705         * mi/mi-interp.c: Use C++ exception handling.
5706         * mi/mi-cmd-stack.c: Use C++ exception handling.
5707         * mi/mi-cmd-break.c: Use C++ exception handling.
5708         * main.c: Use C++ exception handling.
5709         * linux-thread-db.c: Use C++ exception handling.
5710         * linux-tdep.c: Use C++ exception handling.
5711         * linux-nat.c: Use C++ exception handling.
5712         * linux-fork.c: Use C++ exception handling.
5713         * linespec.c: Use C++ exception handling.
5714         * language.c: Use C++ exception handling.
5715         * jit.c: Use C++ exception handling.
5716         * infrun.c: Use C++ exception handling.
5717         * infcmd.c: Use C++ exception handling.
5718         * infcall.c: Use C++ exception handling.
5719         * inf-loop.c: Use C++ exception handling.
5720         * i386-tdep.c: Use C++ exception handling.
5721         * i386-linux-tdep.c: Use C++ exception handling.
5722         * guile/scm-value.c: Use C++ exception handling.
5723         * guile/scm-type.c: Use C++ exception handling.
5724         * guile/scm-symtab.c: Use C++ exception handling.
5725         * guile/scm-symbol.c: Use C++ exception handling.
5726         * guile/scm-pretty-print.c: Use C++ exception handling.
5727         * guile/scm-ports.c: Use C++ exception handling.
5728         * guile/scm-param.c: Use C++ exception handling.
5729         * guile/scm-math.c: Use C++ exception handling.
5730         * guile/scm-lazy-string.c: Use C++ exception handling.
5731         * guile/scm-frame.c: Use C++ exception handling.
5732         * guile/scm-disasm.c: Use C++ exception handling.
5733         * guile/scm-cmd.c: Use C++ exception handling.
5734         * guile/scm-breakpoint.c: Use C++ exception handling.
5735         * guile/scm-block.c: Use C++ exception handling.
5736         * guile/guile-internal.h: Use C++ exception handling.
5737         * gnu-v3-abi.c: Use C++ exception handling.
5738         * gdbtypes.c: Use C++ exception handling.
5739         * frame.c: Use C++ exception handling.
5740         * frame-unwind.c: Use C++ exception handling.
5741         * fbsd-tdep.c: Use C++ exception handling.
5742         * f-valprint.c: Use C++ exception handling.
5743         * exec.c: Use C++ exception handling.
5744         * event-top.c: Use C++ exception handling.
5745         * event-loop.c: Use C++ exception handling.
5746         * eval.c: Use C++ exception handling.
5747         * dwarf2read.c: Use C++ exception handling.
5748         * dwarf2loc.c: Use C++ exception handling.
5749         * dwarf2-frame.c: Use C++ exception handling.
5750         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5751         * dwarf-index-write.c: Use C++ exception handling.
5752         * dwarf-index-cache.c: Use C++ exception handling.
5753         * dtrace-probe.c: Use C++ exception handling.
5754         * disasm-selftests.c: Use C++ exception handling.
5755         * darwin-nat.c: Use C++ exception handling.
5756         * cp-valprint.c: Use C++ exception handling.
5757         * cp-support.c: Use C++ exception handling.
5758         * cp-abi.c: Use C++ exception handling.
5759         * corelow.c: Use C++ exception handling.
5760         * completer.c: Use C++ exception handling.
5761         * compile/compile-object-run.c: Use C++ exception handling.
5762         * compile/compile-object-load.c: Use C++ exception handling.
5763         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5764         * compile/compile-c-symbols.c: Use C++ exception handling.
5765         * common/selftest.c: Use C++ exception handling.
5766         * common/new-op.c: Use C++ exception handling.
5767         * cli/cli-script.c: Use C++ exception handling.
5768         * cli/cli-interp.c: Use C++ exception handling.
5769         * cli/cli-cmds.c: Use C++ exception handling.
5770         * c-varobj.c: Use C++ exception handling.
5771         * btrace.c: Use C++ exception handling.
5772         * breakpoint.c: Use C++ exception handling.
5773         * break-catch-throw.c: Use C++ exception handling.
5774         * arch-utils.c: Use C++ exception handling.
5775         * amd64-tdep.c: Use C++ exception handling.
5776         * ada-valprint.c: Use C++ exception handling.
5777         * ada-typeprint.c: Use C++ exception handling.
5778         * ada-lang.c: Use C++ exception handling.
5779         * aarch64-tdep.c: Use C++ exception handling.
5780
5781 2019-04-08  Tom Tromey  <tom@tromey.com>
5782
5783         * xml-support.c (gdb_xml_parser::parse): Update.
5784         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5785         * value.c (show_convenience): Update.
5786         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5787         (test_parse_flags_qcs): Update.
5788         * thread.c (thr_try_catch_cmd): Update.
5789         * target.c (target_translate_tls_address): Update.
5790         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5791         (info_frame_command_core, frame_apply_command_count): Update.
5792         * rust-exp.y (rust_lex_exception_test): Update.
5793         * riscv-tdep.c (riscv_print_one_register_info): Update.
5794         * remote.c (remote_target::enable_btrace): Update.
5795         * record-btrace.c (record_btrace_enable_warn): Update.
5796         * python/py-utils.c (gdbpy_convert_exception): Update.
5797         * printcmd.c (do_one_display, print_variable_and_value): Update.
5798         * mi/mi-main.c (mi_print_exception): Update.
5799         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5800         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5801         * linux-nat.c (linux_nat_target::attach): Update.
5802         * linux-fork.c (class scoped_switch_fork_info): Update.
5803         * infrun.c (displaced_step_prepare): Update.
5804         * infcall.c (call_function_by_hand_dummy): Update.
5805         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5806         * gnu-v3-abi.c (print_one_vtable): Update.
5807         * frame.c (get_prev_frame_always): Update.
5808         * f-valprint.c (info_common_command_for_block): Update.
5809         * exec.c (try_open_exec_file): Update.
5810         * exceptions.c (print_exception, exception_print)
5811         (exception_fprintf, exception_print_same): Update.
5812         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5813         * dwarf-index-cache.c (index_cache::store)
5814         (index_cache::lookup_gdb_index): Update.
5815         * darwin-nat.c (maybe_cache_shell): Update.
5816         * cp-valprint.c (cp_print_value_fields): Update.
5817         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5818         (gcc_cplus_symbol_address): Update.
5819         * compile/compile-c-symbols.c (gcc_convert_symbol)
5820         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5821         * common/selftest.c: Update.
5822         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5823         a std::string.
5824         (exception_try_scope_entry, exception_try_scope_exit): Don't
5825         declare.
5826         (struct exception_try_scope): Remove.
5827         (TRY): Don't use exception_try_scope.
5828         (struct gdb_exception): Add constructor, operator=.
5829         <what>: New method.
5830         (struct gdb_exception_RETURN_MASK_ALL)
5831         (struct gdb_exception_RETURN_MASK_ERROR)
5832         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5833         (struct gdb_quit_bad_alloc): Update.
5834         * common/common-exceptions.c (exception_none): Change
5835         initializer.
5836         (struct catcher) <state, exception>: Initialize inline.
5837         <prev>: Remove member.
5838         (current_catcher): Remove.
5839         (catchers): New global.
5840         (exceptions_state_mc_init): Simplify.
5841         (catcher_pop): Remove.
5842         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5843         (try_scope_depth, exception_try_scope_entry)
5844         (exception_try_scope_exit): Remove.
5845         (throw_exception_sjlj): Update.
5846         (exception_messages, exception_messages_size): Remove.
5847         (throw_it): Simplify.
5848         (gdb_exception_sliced_copy): Remove.
5849         (throw_exception_cxx): Update.
5850         * cli/cli-script.c (script_from_file): Update.
5851         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5852         Update.
5853         * ada-valprint.c (ada_val_print): Update.
5854         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5855         (create_excep_cond_exprs): Update.
5856
5857 2019-04-08  Tom Tromey  <tom@tromey.com>
5858
5859         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5860         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5861         (TRY, CATCH, END_CATCH): Remove some definitions.
5862         * common/common-exceptions.c: Don't use GDB_XCPT.
5863         (catcher_list_size): Remove.
5864         (throw_exception, throw_it): Simplify.
5865
5866 2019-04-05  Tom Tromey  <tom@tromey.com>
5867
5868         Revert the header-sorting patch.
5869         * ft32-tdep.c: Revert.
5870         * frv-tdep.c: Revert.
5871         * frv-linux-tdep.c: Revert.
5872         * frame.c: Revert.
5873         * frame-unwind.c: Revert.
5874         * frame-base.c: Revert.
5875         * fork-child.c: Revert.
5876         * findvar.c: Revert.
5877         * findcmd.c: Revert.
5878         * filesystem.c: Revert.
5879         * filename-seen-cache.h: Revert.
5880         * filename-seen-cache.c: Revert.
5881         * fbsd-tdep.c: Revert.
5882         * fbsd-nat.h: Revert.
5883         * fbsd-nat.c: Revert.
5884         * f-valprint.c: Revert.
5885         * f-typeprint.c: Revert.
5886         * f-lang.c: Revert.
5887         * extension.h: Revert.
5888         * extension.c: Revert.
5889         * extension-priv.h: Revert.
5890         * expprint.c: Revert.
5891         * exec.h: Revert.
5892         * exec.c: Revert.
5893         * exceptions.c: Revert.
5894         * event-top.c: Revert.
5895         * event-loop.c: Revert.
5896         * eval.c: Revert.
5897         * elfread.c: Revert.
5898         * dwarf2read.h: Revert.
5899         * dwarf2read.c: Revert.
5900         * dwarf2loc.c: Revert.
5901         * dwarf2expr.h: Revert.
5902         * dwarf2expr.c: Revert.
5903         * dwarf2-frame.c: Revert.
5904         * dwarf2-frame-tailcall.c: Revert.
5905         * dwarf-index-write.h: Revert.
5906         * dwarf-index-write.c: Revert.
5907         * dwarf-index-common.c: Revert.
5908         * dwarf-index-cache.h: Revert.
5909         * dwarf-index-cache.c: Revert.
5910         * dummy-frame.c: Revert.
5911         * dtrace-probe.c: Revert.
5912         * disasm.h: Revert.
5913         * disasm.c: Revert.
5914         * disasm-selftests.c: Revert.
5915         * dictionary.c: Revert.
5916         * dicos-tdep.c: Revert.
5917         * demangle.c: Revert.
5918         * dcache.h: Revert.
5919         * dcache.c: Revert.
5920         * darwin-nat.h: Revert.
5921         * darwin-nat.c: Revert.
5922         * darwin-nat-info.c: Revert.
5923         * d-valprint.c: Revert.
5924         * d-namespace.c: Revert.
5925         * d-lang.c: Revert.
5926         * ctf.c: Revert.
5927         * csky-tdep.c: Revert.
5928         * csky-linux-tdep.c: Revert.
5929         * cris-tdep.c: Revert.
5930         * cris-linux-tdep.c: Revert.
5931         * cp-valprint.c: Revert.
5932         * cp-support.c: Revert.
5933         * cp-namespace.c: Revert.
5934         * cp-abi.c: Revert.
5935         * corelow.c: Revert.
5936         * corefile.c: Revert.
5937         * continuations.c: Revert.
5938         * completer.h: Revert.
5939         * completer.c: Revert.
5940         * complaints.c: Revert.
5941         * coffread.c: Revert.
5942         * coff-pe-read.c: Revert.
5943         * cli-out.h: Revert.
5944         * cli-out.c: Revert.
5945         * charset.c: Revert.
5946         * c-varobj.c: Revert.
5947         * c-valprint.c: Revert.
5948         * c-typeprint.c: Revert.
5949         * c-lang.c: Revert.
5950         * buildsym.c: Revert.
5951         * buildsym-legacy.c: Revert.
5952         * build-id.h: Revert.
5953         * build-id.c: Revert.
5954         * btrace.c: Revert.
5955         * bsd-uthread.c: Revert.
5956         * breakpoint.h: Revert.
5957         * breakpoint.c: Revert.
5958         * break-catch-throw.c: Revert.
5959         * break-catch-syscall.c: Revert.
5960         * break-catch-sig.c: Revert.
5961         * blockframe.c: Revert.
5962         * block.c: Revert.
5963         * bfin-tdep.c: Revert.
5964         * bfin-linux-tdep.c: Revert.
5965         * bfd-target.c: Revert.
5966         * bcache.c: Revert.
5967         * ax-general.c: Revert.
5968         * ax-gdb.h: Revert.
5969         * ax-gdb.c: Revert.
5970         * avr-tdep.c: Revert.
5971         * auxv.c: Revert.
5972         * auto-load.c: Revert.
5973         * arm-wince-tdep.c: Revert.
5974         * arm-tdep.c: Revert.
5975         * arm-symbian-tdep.c: Revert.
5976         * arm-pikeos-tdep.c: Revert.
5977         * arm-obsd-tdep.c: Revert.
5978         * arm-nbsd-tdep.c: Revert.
5979         * arm-nbsd-nat.c: Revert.
5980         * arm-linux-tdep.c: Revert.
5981         * arm-linux-nat.c: Revert.
5982         * arm-fbsd-tdep.c: Revert.
5983         * arm-fbsd-nat.c: Revert.
5984         * arm-bsd-tdep.c: Revert.
5985         * arch-utils.c: Revert.
5986         * arc-tdep.c: Revert.
5987         * arc-newlib-tdep.c: Revert.
5988         * annotate.h: Revert.
5989         * annotate.c: Revert.
5990         * amd64-windows-tdep.c: Revert.
5991         * amd64-windows-nat.c: Revert.
5992         * amd64-tdep.c: Revert.
5993         * amd64-sol2-tdep.c: Revert.
5994         * amd64-obsd-tdep.c: Revert.
5995         * amd64-obsd-nat.c: Revert.
5996         * amd64-nbsd-tdep.c: Revert.
5997         * amd64-nbsd-nat.c: Revert.
5998         * amd64-nat.c: Revert.
5999         * amd64-linux-tdep.c: Revert.
6000         * amd64-linux-nat.c: Revert.
6001         * amd64-fbsd-tdep.c: Revert.
6002         * amd64-fbsd-nat.c: Revert.
6003         * amd64-dicos-tdep.c: Revert.
6004         * amd64-darwin-tdep.c: Revert.
6005         * amd64-bsd-nat.c: Revert.
6006         * alpha-tdep.c: Revert.
6007         * alpha-obsd-tdep.c: Revert.
6008         * alpha-nbsd-tdep.c: Revert.
6009         * alpha-mdebug-tdep.c: Revert.
6010         * alpha-linux-tdep.c: Revert.
6011         * alpha-linux-nat.c: Revert.
6012         * alpha-bsd-tdep.c: Revert.
6013         * alpha-bsd-nat.c: Revert.
6014         * aix-thread.c: Revert.
6015         * agent.c: Revert.
6016         * addrmap.c: Revert.
6017         * ada-varobj.c: Revert.
6018         * ada-valprint.c: Revert.
6019         * ada-typeprint.c: Revert.
6020         * ada-tasks.c: Revert.
6021         * ada-lang.c: Revert.
6022         * aarch64-tdep.c: Revert.
6023         * aarch64-ravenscar-thread.c: Revert.
6024         * aarch64-newlib-tdep.c: Revert.
6025         * aarch64-linux-tdep.c: Revert.
6026         * aarch64-linux-nat.c: Revert.
6027         * aarch64-fbsd-tdep.c: Revert.
6028         * aarch64-fbsd-nat.c: Revert.
6029         * aarch32-linux-nat.c: Revert.
6030
6031 2019-04-05  Tom Tromey  <tom@tromey.com>
6032
6033         * ft32-tdep.c: Sort headers.
6034         * frv-tdep.c: Sort headers.
6035         * frv-linux-tdep.c: Sort headers.
6036         * frame.c: Sort headers.
6037         * frame-unwind.c: Sort headers.
6038         * frame-base.c: Sort headers.
6039         * fork-child.c: Sort headers.
6040         * findvar.c: Sort headers.
6041         * findcmd.c: Sort headers.
6042         * filesystem.c: Sort headers.
6043         * filename-seen-cache.h: Sort headers.
6044         * filename-seen-cache.c: Sort headers.
6045         * fbsd-tdep.c: Sort headers.
6046         * fbsd-nat.h: Sort headers.
6047         * fbsd-nat.c: Sort headers.
6048         * f-valprint.c: Sort headers.
6049         * f-typeprint.c: Sort headers.
6050         * f-lang.c: Sort headers.
6051         * extension.h: Sort headers.
6052         * extension.c: Sort headers.
6053         * extension-priv.h: Sort headers.
6054         * expprint.c: Sort headers.
6055         * exec.h: Sort headers.
6056         * exec.c: Sort headers.
6057         * exceptions.c: Sort headers.
6058         * event-top.c: Sort headers.
6059         * event-loop.c: Sort headers.
6060         * eval.c: Sort headers.
6061         * elfread.c: Sort headers.
6062         * dwarf2read.h: Sort headers.
6063         * dwarf2read.c: Sort headers.
6064         * dwarf2loc.c: Sort headers.
6065         * dwarf2expr.h: Sort headers.
6066         * dwarf2expr.c: Sort headers.
6067         * dwarf2-frame.c: Sort headers.
6068         * dwarf2-frame-tailcall.c: Sort headers.
6069         * dwarf-index-write.h: Sort headers.
6070         * dwarf-index-write.c: Sort headers.
6071         * dwarf-index-common.c: Sort headers.
6072         * dwarf-index-cache.h: Sort headers.
6073         * dwarf-index-cache.c: Sort headers.
6074         * dummy-frame.c: Sort headers.
6075         * dtrace-probe.c: Sort headers.
6076         * disasm.h: Sort headers.
6077         * disasm.c: Sort headers.
6078         * disasm-selftests.c: Sort headers.
6079         * dictionary.c: Sort headers.
6080         * dicos-tdep.c: Sort headers.
6081         * demangle.c: Sort headers.
6082         * dcache.h: Sort headers.
6083         * dcache.c: Sort headers.
6084         * darwin-nat.h: Sort headers.
6085         * darwin-nat.c: Sort headers.
6086         * darwin-nat-info.c: Sort headers.
6087         * d-valprint.c: Sort headers.
6088         * d-namespace.c: Sort headers.
6089         * d-lang.c: Sort headers.
6090         * ctf.c: Sort headers.
6091         * csky-tdep.c: Sort headers.
6092         * csky-linux-tdep.c: Sort headers.
6093         * cris-tdep.c: Sort headers.
6094         * cris-linux-tdep.c: Sort headers.
6095         * cp-valprint.c: Sort headers.
6096         * cp-support.c: Sort headers.
6097         * cp-namespace.c: Sort headers.
6098         * cp-abi.c: Sort headers.
6099         * corelow.c: Sort headers.
6100         * corefile.c: Sort headers.
6101         * continuations.c: Sort headers.
6102         * completer.h: Sort headers.
6103         * completer.c: Sort headers.
6104         * complaints.c: Sort headers.
6105         * coffread.c: Sort headers.
6106         * coff-pe-read.c: Sort headers.
6107         * cli-out.h: Sort headers.
6108         * cli-out.c: Sort headers.
6109         * charset.c: Sort headers.
6110         * c-varobj.c: Sort headers.
6111         * c-valprint.c: Sort headers.
6112         * c-typeprint.c: Sort headers.
6113         * c-lang.c: Sort headers.
6114         * buildsym.c: Sort headers.
6115         * buildsym-legacy.c: Sort headers.
6116         * build-id.h: Sort headers.
6117         * build-id.c: Sort headers.
6118         * btrace.c: Sort headers.
6119         * bsd-uthread.c: Sort headers.
6120         * breakpoint.h: Sort headers.
6121         * breakpoint.c: Sort headers.
6122         * break-catch-throw.c: Sort headers.
6123         * break-catch-syscall.c: Sort headers.
6124         * break-catch-sig.c: Sort headers.
6125         * blockframe.c: Sort headers.
6126         * block.c: Sort headers.
6127         * bfin-tdep.c: Sort headers.
6128         * bfin-linux-tdep.c: Sort headers.
6129         * bfd-target.c: Sort headers.
6130         * bcache.c: Sort headers.
6131         * ax-general.c: Sort headers.
6132         * ax-gdb.h: Sort headers.
6133         * ax-gdb.c: Sort headers.
6134         * avr-tdep.c: Sort headers.
6135         * auxv.c: Sort headers.
6136         * auto-load.c: Sort headers.
6137         * arm-wince-tdep.c: Sort headers.
6138         * arm-tdep.c: Sort headers.
6139         * arm-symbian-tdep.c: Sort headers.
6140         * arm-pikeos-tdep.c: Sort headers.
6141         * arm-obsd-tdep.c: Sort headers.
6142         * arm-nbsd-tdep.c: Sort headers.
6143         * arm-nbsd-nat.c: Sort headers.
6144         * arm-linux-tdep.c: Sort headers.
6145         * arm-linux-nat.c: Sort headers.
6146         * arm-fbsd-tdep.c: Sort headers.
6147         * arm-fbsd-nat.c: Sort headers.
6148         * arm-bsd-tdep.c: Sort headers.
6149         * arch-utils.c: Sort headers.
6150         * arc-tdep.c: Sort headers.
6151         * arc-newlib-tdep.c: Sort headers.
6152         * annotate.h: Sort headers.
6153         * annotate.c: Sort headers.
6154         * amd64-windows-tdep.c: Sort headers.
6155         * amd64-windows-nat.c: Sort headers.
6156         * amd64-tdep.c: Sort headers.
6157         * amd64-sol2-tdep.c: Sort headers.
6158         * amd64-obsd-tdep.c: Sort headers.
6159         * amd64-obsd-nat.c: Sort headers.
6160         * amd64-nbsd-tdep.c: Sort headers.
6161         * amd64-nbsd-nat.c: Sort headers.
6162         * amd64-nat.c: Sort headers.
6163         * amd64-linux-tdep.c: Sort headers.
6164         * amd64-linux-nat.c: Sort headers.
6165         * amd64-fbsd-tdep.c: Sort headers.
6166         * amd64-fbsd-nat.c: Sort headers.
6167         * amd64-dicos-tdep.c: Sort headers.
6168         * amd64-darwin-tdep.c: Sort headers.
6169         * amd64-bsd-nat.c: Sort headers.
6170         * alpha-tdep.c: Sort headers.
6171         * alpha-obsd-tdep.c: Sort headers.
6172         * alpha-nbsd-tdep.c: Sort headers.
6173         * alpha-mdebug-tdep.c: Sort headers.
6174         * alpha-linux-tdep.c: Sort headers.
6175         * alpha-linux-nat.c: Sort headers.
6176         * alpha-bsd-tdep.c: Sort headers.
6177         * alpha-bsd-nat.c: Sort headers.
6178         * aix-thread.c: Sort headers.
6179         * agent.c: Sort headers.
6180         * addrmap.c: Sort headers.
6181         * ada-varobj.c: Sort headers.
6182         * ada-valprint.c: Sort headers.
6183         * ada-typeprint.c: Sort headers.
6184         * ada-tasks.c: Sort headers.
6185         * ada-lang.c: Sort headers.
6186         * aarch64-tdep.c: Sort headers.
6187         * aarch64-ravenscar-thread.c: Sort headers.
6188         * aarch64-newlib-tdep.c: Sort headers.
6189         * aarch64-linux-tdep.c: Sort headers.
6190         * aarch64-linux-nat.c: Sort headers.
6191         * aarch64-fbsd-tdep.c: Sort headers.
6192         * aarch64-fbsd-nat.c: Sort headers.
6193         * aarch32-linux-nat.c: Sort headers.
6194
6195 2019-04-04  Tom Tromey  <tom@tromey.com>
6196
6197         * varobj.c (varobj_create): Update.
6198         * rust-exp.y (struct rust_parser) <update_innermost_block,
6199         lookup_symbol>: New methods.
6200         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6201         Rename.
6202         (rust_parser::rust_lookup_type)
6203         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6204         * printcmd.c (display_command, do_one_display): Update.
6205         * parser-defs.h (struct parser_state) <parser_state>: Add
6206         "tracker" parameter.
6207         (block_tracker): New member.
6208         (class innermost_block_tracker) <innermost_block_tracker>: Add
6209         "types" parameter.
6210         <reset>: Remove method.
6211         (innermost_block): Don't declare.
6212         (null_post_parser): Update.
6213         * parse.c (innermost_block): Remove global.
6214         (write_dollar_variable): Update.
6215         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6216         Remove "tracker_types" parameter.
6217         (parse_expression): Add "tracker" parameter.
6218         (parse_expression_for_completion): Update.
6219         (null_post_parser): Add "tracker" parameter.
6220         * p-exp.y: Update rules.
6221         * m2-exp.y: Update rules.
6222         * language.h (struct language_defn) <la_post_parser>: Add
6223         "tracker" parameter.
6224         * go-exp.y: Update rules.
6225         * f-exp.y: Update rules.
6226         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6227         parameter.
6228         * d-exp.y: Update rules.
6229         * c-exp.y: Update rules.
6230         * breakpoint.c (set_breakpoint_condition): Create an
6231         innermost_block_tracker.
6232         (watch_command_1): Likewise.
6233         * ada-lang.c (resolve): Add "tracker" parameter.
6234         (resolve_subexp): Likewise.
6235         * ada-exp.y (write_var_from_sym): Update.
6236
6237 2019-04-04  Tom Tromey  <tom@tromey.com>
6238
6239         * type-stack.h: New file.
6240         * type-stack.c: New file.
6241         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6242         type-stack.h.
6243         (insert_into_type_stack, insert_type, push_type, push_type_int)
6244         (insert_type_address_space, pop_type, pop_type_int)
6245         (pop_typelist, pop_type_stack, append_type_stack)
6246         (push_type_stack, get_type_stack, push_typelist)
6247         (follow_type_instance_flags, follow_types): Don't declare.
6248         * parse.c (type_stack): Remove global.
6249         (parse_exp_in_context): Update.
6250         (insert_into_type_stack, insert_type, push_type, push_type_int)
6251         (insert_type_address_space, pop_type, pop_type_int)
6252         (pop_typelist, pop_type_stack, append_type_stack)
6253         (push_type_stack, get_type_stack, push_typelist)
6254         (follow_type_instance_flags, follow_types): Remove (moved to
6255         type-stack.c).
6256         * f-exp.y (type_stack): New global.
6257         Update rules.
6258         (push_kind_type, f_parse): Update.
6259         * d-exp.y (type_stack): New global.
6260         Update rules.
6261         (d_parse): Update.
6262         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6263         Update rules.
6264         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6265         (HFILES_NO_SRCDIR): Add type-stack.h.
6266
6267 2019-04-04  Tom Tromey  <tom@tromey.com>
6268
6269         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6270         (rust_parser::convert_ast_to_expression, rust_parse)
6271         (rust_lex_test_completion, rust_lex_tests): Update.
6272         * parser-defs.h (struct expr_completion_state): New.
6273         (struct parser_state) <parser_state>: Add completion parameter.
6274         <mark_struct_expression, mark_completion_tag>: New methods.
6275         <parse_completion, m_completion_state>: New members.
6276         (prefixify_expression, null_post_parser): Update.
6277         (mark_struct_expression, mark_completion_tag): Don't declare.
6278         * parse.c (parse_completion, expout_last_struct)
6279         (expout_tag_completion_type, expout_completion_name): Remove
6280         globals.
6281         (parser_state::mark_struct_expression)
6282         (parser_state::mark_completion_tag): Now methods.
6283         (prefixify_expression): Add last_struct parameter.
6284         (prefixify_subexp): Likewise.
6285         (parse_exp_1): Update.
6286         (parse_exp_in_context): Add cstate parameter.  Update.
6287         (parse_expression_for_completion): Create an
6288         expr_completion_state.
6289         (null_post_parser): Add "completion" parameter.
6290         * p-exp.y: Update rules.
6291         (yylex): Update.
6292         * language.h (struct language_defn) <la_post_parser>: Add
6293         "completing" parameter.
6294         * go-exp.y: Update rules.
6295         (lex_one_token): Update.
6296         * expression.h (parse_completion): Don't declare.
6297         * d-exp.y: Update rules.
6298         (lex_one_token): Update rules.
6299         * c-exp.y: Update rules.
6300         (lex_one_token): Update.
6301         * ada-lang.c (resolve): Add "parse_completion" parameter.
6302         (resolve_subexp): Likewise.
6303         (ada_resolve_function): Likewise.
6304
6305 2019-04-04  Tom Tromey  <tom@tromey.com>
6306
6307         * parser-defs.h (struct parser_state) <start_arglist,
6308         end_arglist>: New methods.
6309         <arglist_len, m_funcall_chain>: New members.
6310         (arglist_len, start_arglist, end_arglist): Don't declare.
6311         * parse.c (arglist_len, funcall_chain): Remove global.
6312         (start_arglist, end_arglist): Remove functions.
6313         (parse_exp_in_context): Update.
6314         * p-exp.y: Update rules.
6315         * m2-exp.y: Update rules.
6316         * go-exp.y: Update rules.
6317         * f-exp.y: Update rules.
6318         * d-exp.y: Update rules.
6319         * c-exp.y: Update rules.
6320
6321 2019-04-04  Tom Tromey  <tom@tromey.com>
6322
6323         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6324         lex_operator, push_back>: New methods.
6325         Update all rules.
6326         (rust_parser::lex_hex, lex_escape): Rename and update.
6327         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6328         (rust_parser::lex_operator): Rename and update.
6329         (rust_parser::lex_number, rustyylex, rustyyerror)
6330         (rust_lex_test_init, rust_lex_test_sequence)
6331         (rust_lex_test_push_back, rust_lex_tests): Update.
6332         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6333         parameter.
6334         <lexptr, prev_lexptr>: New members.
6335         (lexptr, prev_lexptr): Don't declare.
6336         * parse.c (lexptr, prev_lexptr): Remove globals.
6337         (parse_exp_in_context): Update.
6338         * p-exp.y (yylex, yyerror): Update.
6339         * m2-exp.y (parse_number, yylex, yyerror): Update.
6340         * go-exp.y (lex_one_token, yyerror): Update.
6341         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6342         * d-exp.y (lex_one_token, yyerror): Update.
6343         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6344         (lex_one_token, yyerror): Update.
6345         * ada-lex.l (YY_INPUT): Update.
6346         (rewind_to_char): Update.
6347         * ada-exp.y (yyerror): Update.
6348
6349 2019-04-04  Tom Tromey  <tom@tromey.com>
6350
6351         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6352         * parser-defs.h (struct parser_state) <parser_state>: Add new
6353         parameter.
6354         <comma_terminates>: New member.
6355         (comma_terminates): Don't declare global.
6356         * parse.c (comma_terminates): Remove global.
6357         (parse_exp_in_context): Update.
6358         * p-exp.y (yylex): Update.
6359         * m2-exp.y (yylex): Update.
6360         * go-exp.y (lex_one_token): Update.
6361         * f-exp.y (yylex): Update.
6362         * d-exp.y (lex_one_token): Update.
6363         * c-exp.y (lex_one_token): Update.
6364         * ada-lex.l: Update.
6365
6366 2019-04-04  Tom Tromey  <tom@tromey.com>
6367
6368         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6369         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6370         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6371         * parser-defs.h (paren_depth): Don't declare.
6372         * parse.c (paren_depth): Remove global.
6373         (parse_exp_in_context): Update.
6374         * p-exp.y (paren_depth): New global.
6375         (pascal_parse): Initialize it.
6376         * m2-exp.y (paren_depth): New global.
6377         (m2_parse): Initialize it.
6378         * go-exp.y (paren_depth): New global.
6379         (go_parse): Initialize it.
6380         * f-exp.y (paren_depth): New global.
6381         (f_parse): Initialize it.
6382         * d-exp.y (paren_depth): New global.
6383         (d_parse): Initialize it.
6384         * c-exp.y (paren_depth): New global.
6385         (c_parse): Initialize it.
6386         * ada-lex.l (paren_depth): New global.
6387         (lexer_init): Initialize it.
6388
6389 2019-04-04  Tom Tromey  <tom@tromey.com>
6390
6391         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6392         (rust_parser::convert_ast_to_type)
6393         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6394         * parser-defs.h (struct parser_state) <parser_state>: Add
6395         parameters.  Initialize new members.
6396         <expression_context_block, expression_context_pc>: New members.
6397         * parse.c (expression_context_block, expression_context_pc):
6398         Remove globals.
6399         (parse_exp_in_context): Update.
6400         * p-exp.y: Update all rules.
6401         (yylex): Update.
6402         * m2-exp.y: Update all rules.
6403         (yylex): Update.
6404         * go-exp.y (yylex): Update.
6405         * f-exp.y (yylex): Update.
6406         * d-exp.y: Update all rules.
6407         (yylex): Update.
6408         * c-exp.y: Update all rules.
6409         (lex_one_token, classify_name, yylex, c_parse): Update.
6410         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6411
6412 2019-04-04  Tom Tromey  <tom@tromey.com>
6413
6414         * gdbarch.h, gdbarch.c: Rebuild.
6415         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6416         * stap-probe.h:
6417         (struct stap_parse_info): Replace "parser_state" with
6418         "expr_builder".
6419         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6420         (parser_state): New class.
6421         * parse.c (expr_builder): Rename.
6422         (expr_builder::release): Rename.
6423         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6424         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6425         (write_exp_elt_longcst, write_exp_elt_floatcst)
6426         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6427         (write_exp_string_vector, write_exp_bitstring)
6428         (write_exp_msymbol, mark_struct_expression)
6429         (write_dollar_variable)
6430         (insert_type_address_space, increase_expout_size): Replace
6431         "parser_state" with "expr_builder".
6432         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6433         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6434         "parser_state" with "expr_builder".
6435
6436 2019-04-04  Tom Tromey  <tom@tromey.com>
6437
6438         * rust-exp.y: Replace "parse_language" with method call.
6439         * p-exp.y:
6440         (yylex): Replace "parse_language" with method call.
6441         * m2-exp.y:
6442         (yylex): Replace "parse_language" with method call.
6443         * go-exp.y (classify_name): Replace "parse_language" with method
6444         call.
6445         * f-exp.y (yylex): Replace "parse_language" with method call.
6446         * d-exp.y (lex_one_token): Replace "parse_language" with method
6447         call.
6448         * c-exp.y:
6449         (lex_one_token, classify_name, yylex): Replace "parse_language"
6450         with method call.
6451         * ada-exp.y (find_primitive_type, type_char)
6452         (type_system_address): Replace "parse_language" with method call.
6453
6454 2019-04-04  Tom Tromey  <tom@tromey.com>
6455
6456         * rust-exp.y: Replace "parse_gdbarch" with method call.
6457         * parse.c (write_dollar_variable, insert_type_address_space):
6458         Replace "parse_gdbarch" with method call.
6459         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6460         call.
6461         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6462         call.
6463         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6464         "parse_gdbarch" with method call.
6465         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6466         with method call.
6467         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6468         "parse_gdbarch" with method call.
6469         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6470         "parse_gdbarch" with method call.
6471         * c-exp.y (parse_type, parse_number, classify_name): Replace
6472         "parse_gdbarch" with method call.
6473         * ada-lex.l: Replace "parse_gdbarch" with method call.
6474         * ada-exp.y (parse_type, find_primitive_type, type_char)
6475         (type_system_address): Replace "parse_gdbarch" with method call.
6476
6477 2019-04-04  Tom Tromey  <tom@tromey.com>
6478
6479         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6480         * stap-probe.c (stap_parse_argument): Update.
6481         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6482         initial_size parameter.
6483         * rust-exp.y (rust_lex_tests): Update.
6484         * parse.c (parser_state): Update.
6485         (parse_exp_in_context): Update.
6486         * parser-defs.h (struct parser_state) <parser_state>: Remove
6487         "initial_size" parameter.
6488
6489 2019-04-04  Tom Tromey  <tom@tromey.com>
6490
6491         * parser-defs.h (increase_expout_size): Don't declare.
6492         * parse.c (increase_expout_size): Now static.
6493
6494 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6495
6496         * gnu-nat.c (gnu_nat_target::wait): Fix
6497         target_waitstatus_to_string call.
6498
6499 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6500
6501         * eval.c (evaluate_subexp_standard): Handle internal functions
6502         during Fortran function call handling.
6503
6504 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6505
6506         * NEWS: Mention new internal functions.
6507         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6508         (read_base_type): Use dwarf2_init_complex_target_type.
6509         * value.c (creal_internal_fn): New function.
6510         (cimag_internal_fn): New function.
6511         (_initialize_values): Register new internal functions.
6512
6513 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6514
6515         * infrun.c (stop_all_threads): If debug_infrun, always
6516         trace the wait status after wait_one, using
6517         target_waitstatus_to_string and target_pid_to_str.
6518         (handle_inferior_event): Replace various trace of
6519         wait status kind by a single trace.
6520         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6521         wait status kind image by target_waitstatus_to_string.
6522         * target/waitstatus.c (target_waitstatus_to_string): Fix
6523         obsolete comment.
6524
6525 2019-04-01  Tom Tromey  <tromey@adacore.com>
6526
6527         PR symtab/23331:
6528         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6529
6530 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6531             Pedro Alves  <palves@redhat.com>
6532
6533         * top.c (quit_force): Call 'finalize_values'.
6534         * value.c (finalize_values): New function.
6535         * value.h (finalize_values): Declare.
6536
6537 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6538
6539         * NEWS: Announce $_gdb_major and $_gdb_minor.
6540
6541         * top.c (init_gdb_version_vars): New function.
6542         (gdb_init): Call init_gdb_version_vars.
6543
6544 2019-03-29  Tom Tromey  <tromey@adacore.com>
6545
6546         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6547         help text.  Remove dead code.
6548
6549 2019-03-29  Keith Seitz  <keiths@redhat.com>
6550
6551         From Siddhesh Poyarekar:
6552         * f-lang.h (f77_get_upperbound): Return LONGEST.
6553         (f77_get_lowerbound): Likewise.
6554         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6555         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6556         print them.
6557         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6558         plongest to format print it.
6559         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6560         (f77_get_upperbound): Likewise.
6561         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6562         LOWER_BOUND to LONGEST.
6563         (f77_create_arrayprint_offset_tbl): Likewise.
6564
6565 2019-03-29  Keith Seitz  <keiths@redhat.com>
6566
6567         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6568         %s/pulongest for TYPE_LENGTH instead of %d in format
6569         strings.
6570         * ada-typerint.c (ada_print_type): Likewise.
6571         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6572         * compile/compile-c-support.c (generate_register_struct): Likewise.
6573         * gdbtypes.c (recursive_dump_type): Likewise.
6574         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6575         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6576         instead of %d in format strings.
6577         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6578         to std::min to ULONGEST.
6579         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6580         instead of %d in format strings.
6581         * tracepoint.c (info_scope_command): Likewise.
6582         * typeprint.c (print_offset_data::update)
6583         (print_offset_data::finish): Likewise.
6584         * xtensa-tdep.c (xtensa_store_return_value)
6585         (xtensa_push_dummy_call): Likewise.
6586
6587 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6588
6589         * windows-nat.c (display_selector): Fixed format specifications
6590         for 64-bit Cygwin.
6591
6592 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6593
6594         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6595
6596 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6597
6598         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6599         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6600         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6601         (nios2_linux_init_abi): Install it.
6602
6603 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6604
6605         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6606
6607 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6608
6609         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6610
6611 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6612             Tom Tromey  <tromey@adacore.com>
6613
6614         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6615
6616 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6617
6618         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6619         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6620         method to compute the bounds of range types. Also print "[evaluated]"
6621         if the bounds' values come from a dynamic evaluation.
6622
6623 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6624
6625         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6626         whitespace when pretty printing is on.
6627
6628 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6629
6630         * ppc-linux-nat.c: Add include.
6631
6632 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6633
6634         * NEWS: Mention AArch64 Pointer Authentication.
6635
6636 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6637
6638         * arm-linux-nat.c: Add include.
6639
6640 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6641
6642         * source-cache.c (source_cache::get_source_lines): Re-read
6643         fullname after calling open_source_file.
6644
6645 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6646
6647         * NEWS: Mention TLS support for FreeBSD.
6648
6649 2019-03-25  Tom Tromey  <tromey@adacore.com>
6650
6651         * minsyms.c (BUNCH_SIZE): Update comment.
6652         (~minimal_symbol_reader): Remove old comment.
6653         (compact_minimal_symbols): Update comment.
6654         (minimal_symbol_reader::install): Remove old comment.  Update
6655         other comments.
6656
6657 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6658
6659         * s390-linux-nat.c: Add include.
6660
6661 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6662
6663         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6664         Call linux_get_hwcap.
6665         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6666         Likewise.
6667         (aarch64_linux_get_hwcap): Remove function.
6668         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6669         declaration.
6670         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6671         linux_get_hwcap.
6672         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6673         * linux-tdep.c (linux_get_hwcap): Add function.
6674         (linux_get_hwcap2): Likewise.
6675         * linux-tdep.h (linux_get_hwcap): Add declaration.
6676         (linux_get_hwcap2): Likewise.
6677         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6678         (ppc_linux_get_hwcap2): Likewise.
6679         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6680         linux_get_hwcap.
6681         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6682         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6683         (ppc_linux_nat_target::read_description): Likewise.
6684         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6685         * s390-linux-nat.c: Likewise.
6686         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6687
6688 2019-03-24  Tom Tromey  <tom@tromey.com>
6689
6690         * ada-lang.c (standard_lookup): Simplify initialization.
6691         (ada_lookup_symbol_nonlocal): Simplify return.
6692         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6693         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6694         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6695         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6696         initialization.
6697         * solib.c (solib_global_lookup): Simplify.
6698         * symtab.c (null_block_symbol): Remove.
6699         (symbol_cache_lookup): Simplify returns.
6700         (lookup_language_this): Simplify returns.
6701         (lookup_symbol_aux): Simplify return.
6702         (lookup_local_symbol): Simplify returns.
6703         (lookup_global_symbol_from_objfile): Simplify return.
6704         (lookup_symbol_in_objfile_symtabs)
6705         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6706         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6707         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6708         * cp-namespace.c (cp_lookup_bare_symbol)
6709         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6710         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6711         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6712         (cp_lookup_symbol_via_imports): Simplify initialization.
6713         (find_symbol_in_baseclass): Likewise.
6714         * symtab.h (null_block_symbol): Remove.
6715         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6716         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6717         (d_lookup_symbol_module): Likewise.
6718         (find_symbol_in_baseclass): Simplify initialization.
6719
6720 2019-03-24  Tom Tromey  <tom@tromey.com>
6721
6722         * expression.h: Don't include symtab.h.
6723         (struct block): Forward declare.
6724
6725 2019-03-24  Tom Tromey  <tom@tromey.com>
6726
6727         * c-exp.y (typebase): Remove casts.
6728         * gdbtypes.c (lookup_unsigned_typename, )
6729         (lookup_signed_typename): Remove cast.
6730         * eval.c (parse_to_comma_and_eval): Remove cast.
6731         * parse.c (write_dollar_variable): Remove cast.
6732         * block.h (struct block) <superblock>: Now const.
6733         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6734         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6735         (map_block): Make "block" const.
6736         * symfile.h (struct quick_symbol_functions)
6737         <map_matching_symbols>: Constify block argument to "callback".
6738         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6739         const.
6740         (find_pc_sect_compunit_symtab): Make "b" const.
6741         (find_symbol_at_address): Likewise.
6742         (search_symbols): Likewise.
6743         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6744         (dw2_debug_names_lookup_symbol): Likewise.
6745         (dw2_map_matching_symbols): Update.
6746         * p-valprint.c (pascal_val_print): Remove "block".
6747         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6748         (aux_add_nonlocal_symbols): Make "block" const.
6749         (resolve_subexp): Remove cast.
6750         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6751         const.
6752         (iterate_over_file_blocks): Likewise.
6753         * f-exp.y (%union) <bval>: Remove.
6754         * coffread.c (patch_opaque_types): Make "b" const.
6755         * spu-tdep.c (spu_catch_start): Make "block" const.
6756         * c-valprint.c (print_unpacked_pointer): Remove "block".
6757         * symmisc.c (dump_symtab_1): Make "b" const.
6758         (block_depth): Make "block" const.
6759         * d-exp.y (%union) <bval>: Remove.
6760         * cp-support.h (cp_lookup_rtti_type): Update.
6761         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6762         * psymtab.c (psym_lookup_symbol): Make "block" const.
6763         (maintenance_check_psymtabs): Make "b" const.
6764         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6765         (enumerate_locals, enumerate_args): Update.
6766         * python/py-symtab.c (stpy_global_block): Make "block" const.
6767         (stpy_static_block): Likewise.
6768         * inline-frame.c (block_starting_point_at): Make "new_block"
6769         const.
6770         * block.c (find_block_in_blockvector): Make return type const.
6771         (blockvector_for_pc_sect): Make "b" const.
6772         (find_block_in_blockvector): Make "b" const.
6773
6774 2019-03-23  Tom Tromey  <tom@tromey.com>
6775
6776         * varobj.c (varobj_create): Update.
6777         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6778         * printcmd.c (display_command, do_one_display): Don't reset
6779         innermost_block.
6780         * parser-defs.h (enum innermost_block_tracker_type): Move to
6781         expression.h.
6782         (innermost_block): Update comment.
6783         * parse.c (parse_exp_1): Add tracker_types parameter.
6784         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6785         tracker_types parameter.  Reset innermost_block.
6786         (parse_exp_in_context): Remove.
6787         (parse_expression_for_completion): Update.
6788         * objfiles.c (~objfile): Don't reset expression_context_block or
6789         innermost_block.
6790         * expression.h (enum innermost_block_tracker_type): Move from
6791         parser-defs.h.
6792         (parse_exp_1): Add tracker_types parameter.
6793         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6794         reset innermost_block.
6795
6796 2019-03-23  Tom Tromey  <tom@tromey.com>
6797
6798         * objfiles.h: Include bcache.h.
6799
6800 2019-03-23  Tom Tromey  <tom@tromey.com>
6801
6802         * linespec.c (get_current_search_block): Use
6803         scoped_restore_current_language.
6804         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6805
6806 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6807             Jiong Wang  <jiong.wang@arm.com>
6808
6809         * aarch64-linux-tdep.c
6810         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6811         section.
6812         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6813
6814 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6815             Jiong Wang  <jiong.wang@arm.com>
6816
6817         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6818         instructions.
6819         (aarch64_analyze_prologue_test): Add PACIASP test.
6820         (aarch64_prologue_prev_register): Unmask PC value.
6821
6822 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6823             Jiong Wang  <jiong.wang@arm.com>
6824
6825         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6826         (aarch64_dwarf2_prev_register): Unmask PC value.
6827         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6828         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6829         DW_CFA_AARCH64_negate_ra_state.
6830         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6831
6832 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6833             Jiong Wang  <jiong.wang@arm.com>
6834
6835         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6836         registers.
6837         (aarch64_pseudo_register_name): Likewise.
6838         (aarch64_pseudo_register_type): Likewise.
6839         (aarch64_pseudo_register_reggroup_p): Likewise.
6840         (aarch64_gdbarch_init): Add pauth registers.
6841         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6842         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6843         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6844         (struct gdbarch_tdep): Add regnum for ra_state.
6845
6846 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6847             Jiong Wang  <jiong.wang@arm.com>
6848
6849         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6850
6851 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6852             Jiong Wang  <jiong.wang@arm.com>
6853
6854         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6855         function.
6856         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6857         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6858         (aarch64_gdbarch_init): Add puth registers.
6859         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6860         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6861         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6862
6863 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6864             Jiong Wang  <jiong.wang@arm.com>
6865
6866         * aarch64-linux-nat.c
6867         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6868         * aarch64-linux-tdep.c
6869         (aarch64_linux_core_read_description): Likewise.
6870         (aarch64_linux_get_hwcap): New function.
6871         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6872         (aarch64_linux_get_hwcap): New declaration.
6873
6874 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6875             Jiong Wang  <jiong.wang@arm.com>
6876
6877         * aarch64-linux-nat.c
6878         (aarch64_linux_nat_target::read_description): Add pauth param.
6879         * aarch64-linux-tdep.c
6880         (aarch64_linux_core_read_description): Likewise.
6881         * aarch64-tdep.c (struct target_desc): Add in pauth.
6882         (aarch64_read_description): Add pauth param.
6883         (aarch64_gdbarch_init): Likewise.
6884         * aarch64-tdep.h (aarch64_read_description): Likewise.
6885         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6886         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6887         * features/Makefile: Add new files.
6888         * features/aarch64-pauth.c: New file.
6889         * features/aarch64-pauth.xml: New file.
6890
6891 2019-03-20  Tom Tromey  <tromey@adacore.com>
6892
6893         * infrun.c (handle_inferior_event): Rename from
6894         handle_inferior_event_1.  Create a scoped_value_mark.
6895         (handle_inferior_event): Remove.
6896
6897 2019-03-19  Tom Tromey  <tromey@adacore.com>
6898
6899         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6900         * infrun.h (print_stop_event): Add "displays" parameter.
6901         * infrun.c (print_stop_event): Add "displays" parameter.
6902
6903 2019-03-19  Pedro Alves  <palves@redhat.com>
6904
6905         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6906         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6907         to -1.  Fix TABs vs spaces.
6908         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6909         * tui/tui-out.h (tui_ui_out) Add intro comments.
6910         <m_line, m_start_of_line>: In-class initialize, and add describing
6911         comment.
6912
6913 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6914
6915         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6916         variable names.
6917         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6918
6919 2019-03-18  Pedro Alves  <palves@redhat.com>
6920             Eli Zaretskii <eliz@gnu.org>
6921
6922         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6923         m_line and m_start_of_line.
6924
6925 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6926
6927         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6928         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6929         it returns a newline.  This fixes a regression in TU mode, whereby
6930         the next line is output on the same screen line as the user input.
6931
6932 2019-03-18  Tom Tromey  <tromey@adacore.com>
6933
6934         * minsyms.c (minimal_symbol_reader::install): Remove call to
6935         obstack_blank.
6936
6937 2019-03-18  Pedro Alves  <palves@redhat.com>
6938
6939         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6940         New globals.
6941         (apply_style): New, factored out from ...
6942         (apply_ansi_escape): ... this.  Handle reverse video mode.
6943         (tui_set_reverse_mode): New function.
6944         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6945         * tui/tui-winsource.c (tui_show_source_line): Use
6946         tui_set_reverse_mode instead of setting A_STANDOUT.
6947         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6948         New setter methods.
6949
6950 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6951
6952         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6953         Handle tabs.
6954
6955 2019-03-18  Tom Tromey  <tromey@adacore.com>
6956
6957         * ada-lang.c (empty_array): Add "high" parameter.
6958         (ada_evaluate_subexp): Update.
6959
6960 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6961
6962         * unittests/string_view-selftests.c: Define
6963         _initialize_string_view_selftests unconditionally.
6964
6965 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6966
6967         PR gdb/24350
6968         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6969
6970 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6971
6972         PR gdb/24351
6973         * windows-nat.c (display_selector): Fix format specifiers.
6974
6975 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6976
6977         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6978         tui_refill_source_window instead of tui_refresh_win, to update the
6979         current execution line.  This fixes redisplay of the current line
6980         when stepping through the code with "next" or "step".
6981
6982 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6983
6984         * source-cache.c (source_cache::get_source_lines): Call
6985         find_source_lines to initialize s->nlines.  This fixes vertical
6986         scrolling of TUI source window when the DOWN arrow is pressed.
6987
6988 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6989
6990         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6991         linux-thread-db.c (_initialize_thread_db): Likewise.
6992
6993 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6994
6995         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6996         wclrtoeol in tui_show_source_line".  This reverts changes made in
6997         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6998
6999 2019-03-15  Tom Tromey  <tom@tromey.com>
7000
7001         * symtab.h (struct minimal_symbol): Derive from
7002         general_symbol_info.
7003         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7004         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7005         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7006         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7007         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7008         (MSYMBOL_SEARCH_NAME): Update.
7009         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7010         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7011         * minsyms.c (minimal_symbol_reader::record_full): Update.
7012
7013 2019-03-15  Tom Tromey  <tom@tromey.com>
7014
7015         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7016
7017 2019-03-15  Tom Tromey  <tom@tromey.com>
7018
7019         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7020         unique_xmalloc_ptr.
7021         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7022         Update.
7023         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7024         (build_minimal_symbol_hash_tables)
7025         (minimal_symbol_reader::install): Update.
7026
7027 2019-03-15  Tom Tromey  <tom@tromey.com>
7028
7029         * symtab.c (create_demangled_names_hash): Update.
7030         (symbol_set_names): Update.
7031         * objfiles.h (struct objfile_per_bfd_storage)
7032         <demangled_names_hash>: Now an htab_up.
7033         * objfiles.c (objfile_per_bfd_storage): Simplify.
7034
7035 2019-03-15  Tom Tromey  <tom@tromey.com>
7036
7037         * objfiles.h (struct objfile_per_bfd_storage): Declare
7038         destructor.
7039         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7040         New.
7041         (get_objfile_bfd_data): Use new.  Don't initialize
7042         language_of_main.
7043         (free_objfile_per_bfd_storage): Remove.
7044         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7045
7046 2019-03-15  Tom Tromey  <tom@tromey.com>
7047
7048         * symfile.c (reread_symbols): Update.
7049         * objfiles.c (objfile::objfile): Update.
7050         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7051         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7052         comment.
7053         (minimal_symbol_reader::install): Update.
7054         (terminate_minimal_symbol_table): Remove.
7055         * jit.c (jit_object_close_impl): Update.
7056
7057 2019-03-15  Tom Tromey  <tom@tromey.com>
7058
7059         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7060         initializations.
7061
7062 2019-03-15  Tom Tromey  <tom@tromey.com>
7063
7064         * objfiles.h (struct objfile_per_bfd_storage)
7065         <demangled_hash_languages>: Now a bitset.
7066         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7067         (lookup_minimal_symbol): Update.
7068
7069 2019-03-15  Tom Tromey  <tom@tromey.com>
7070
7071         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7072         Don't return the symbol.
7073         * coffread.c (record_minimal_symbol): Use record_full.
7074
7075 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7076
7077         The MS-Windows port of ncurses fails to switch to a color pair if
7078         one or both of the colors are the implicit default colors.  This
7079         change records the default colors when TUI is initialized, and
7080         then specifies them explicitly when a color pair uses the default
7081         colors.  This allows color styling in TUI mode on MS-Windows.
7082
7083         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7084         ncurses_norm_attr.
7085         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7086         colors in ncurses_norm_attr.
7087         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7088         "none", replace it with the default color recorded in
7089         ncurses_norm_attr.
7090
7091 2019-03-14  Tom Tromey  <tromey@adacore.com>
7092
7093         * source-cache.h (class source_cache) <get_source_lines>: Return
7094         std::string.
7095         * source-cache.c (source_cache::extract_lines): Handle case where
7096         first_pos==npos.  Return std::string.
7097         (source_cache::get_source_lines): Update.
7098
7099 2019-03-14  Tom Tromey  <tromey@adacore.com>
7100
7101         * NEWS: Add item for "style sources" commands.
7102         * source-cache.c (source_cache::get_source_lines): Check
7103         source_styling.
7104         * cli/cli-style.c (source_styling): New global.
7105         (_initialize_cli_style): Add "style sources" commands.
7106         (show_style_sources): New function.
7107         * cli/cli-style.h (source_styling): Declare.
7108
7109 2019-03-14  Pedro Alves  <palves@redhat.com>
7110             Tom Tromey  <tromey@adacore.com>
7111
7112         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7113         * tui/tui-winsource.c (tui_refill_source_window): New function,
7114         from...
7115         (tui_horizontal_source_scroll): ... here.  Move some logic.
7116         * cli/cli-style.c (set_style_enabled): Notify new observable.
7117         * tui/tui-hooks.c (tui_redisplay_source): New function.
7118         (tui_attach_detach_observers): Attach or detach
7119         tui_redisplay_source.
7120         * observable.h (source_styling_changed): New observable.
7121         * observable.c: Define source_styling_changed observable.
7122
7123 2019-03-13  Tom Tromey  <tromey@adacore.com>
7124
7125         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7126         (i386_gnu_nat_target::store_registers): Update.
7127         * target-debug.h (target_debug_print_std_string): New macro.
7128         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7129         * windows-tdep.c (display_one_tib): Update.
7130         * tui/tui-stack.c (tui_make_status_line): Update.
7131         * top.c (print_inferior_quit_action): Update.
7132         * thread.c (thr_try_catch_cmd): Update.
7133         (add_thread_with_info): Update.
7134         (thread_target_id_str): Update.
7135         (thr_try_catch_cmd): Update.
7136         (thread_command): Update.
7137         (thread_find_command): Update.
7138         * record-btrace.c (record_btrace_target::info_record)
7139         (record_btrace_resume_thread, record_btrace_target::resume)
7140         (record_btrace_cancel_resume, record_btrace_step_thread)
7141         (record_btrace_target::wait, record_btrace_target::wait)
7142         (record_btrace_target::wait, record_btrace_target::stop): Update.
7143         * progspace.c (print_program_space): Update.
7144         * process-stratum-target.c
7145         (process_stratum_target::thread_address_space): Update.
7146         * linux-fork.c (linux_fork_mourn_inferior)
7147         (detach_checkpoint_command, info_checkpoints_command)
7148         (linux_fork_context): Update.
7149         (linux_fork_detach): Update.
7150         (class scoped_switch_fork_info): Update.
7151         (delete_checkpoint_command): Update.
7152         * infrun.c (follow_fork_inferior): Update.
7153         (follow_fork_inferior): Update.
7154         (proceed_after_vfork_done): Update.
7155         (handle_vfork_child_exec_or_exit): Update.
7156         (follow_exec): Update.
7157         (displaced_step_prepare_throw): Update.
7158         (displaced_step_restore): Update.
7159         (start_step_over): Update.
7160         (resume_1): Update.
7161         (clear_proceed_status_thread): Update.
7162         (proceed): Update.
7163         (print_target_wait_results): Update.
7164         (do_target_wait): Update.
7165         (context_switch): Update.
7166         (stop_all_threads): Update.
7167         (restart_threads): Update.
7168         (finish_step_over): Update.
7169         (handle_signal_stop): Update.
7170         (switch_back_to_stepped_thread): Update.
7171         (keep_going_pass_signal): Update.
7172         (print_exited_reason): Update.
7173         (normal_stop): Update.
7174         * inferior.c (inferior_pid_to_str): Change return type.
7175         (print_selected_inferior): Update.
7176         (add_inferior): Update.
7177         (detach_inferior): Update.
7178         * dummy-frame.c (fprint_dummy_frames): Update.
7179         * dcache.c (dcache_info_1): Update.
7180         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7181         (btrace_fetch, btrace_clear): Update.
7182         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7183         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7184         type.
7185         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7186         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7187         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7188         * gdbarch.c, gdbarch.h: Rebuild.
7189         * gdbarch.sh (core_pid_to_str): Change return type.
7190         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7191         return type.
7192         (windows_nat_target::pid_to_str): Change return type.
7193         (windows_delete_thread): Update.
7194         (windows_nat_target::attach): Update.
7195         (windows_nat_target::files_info): Update.
7196         * target-delegates.c: Rebuild.
7197         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7198         return type.
7199         (sol_thread_target::pid_to_str): Change return type.
7200         * remote.c (class remote_target) <pid_to_str>: Change return
7201         type.
7202         (remote_target::pid_to_str): Change return type.
7203         (extended_remote_target::attach, remote_target::remote_stop_ns)
7204         (remote_target::remote_notif_remove_queued_reply)
7205         (remote_target::push_stop_reply, remote_target::disable_btrace):
7206         Update.
7207         (extended_remote_target::attach): Update.
7208         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7209         type.
7210         (gdbsim_target::pid_to_str): Change return type.
7211         * ravenscar-thread.c (struct ravenscar_thread_target)
7212         <pid_to_str>: Change return type.
7213         (ravenscar_thread_target::pid_to_str): Change return type.
7214         * procfs.c (class procfs_target) <pid_to_str>: Change return
7215         type.
7216         (procfs_target::pid_to_str): Change return type.
7217         (procfs_target::attach): Update.
7218         (procfs_target::detach): Update.
7219         (procfs_target::fetch_registers): Update.
7220         (procfs_target::store_registers): Update.
7221         (procfs_target::wait): Update.
7222         (procfs_target::files_info): Update.
7223         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7224         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7225         return type.
7226         (nto_procfs_target::pid_to_str): Change return type.
7227         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7228         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7229         return type.
7230         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7231         (exit_lwp): Update.
7232         (attach_proc_task_lwp_callback, get_detach_signal)
7233         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7234         (linux_nat_target::resume, wait_lwp, stop_callback)
7235         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7236         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7237         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7238         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7239         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7240         type.
7241         (inf_ptrace_target::attach): Update.
7242         (inf_ptrace_target::files_info): Update.
7243         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7244         type.
7245         (go32_nat_target::pid_to_str): Change return type.
7246         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7247         (gnu_nat_target::wait): Update.
7248         (gnu_nat_target::wait): Update.
7249         (gnu_nat_target::resume): Update.
7250         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7251         (fbsd_nat_target::wait): Update.
7252         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7253         type.
7254         (darwin_nat_target::attach): Update.
7255         * corelow.c (class core_target) <pid_to_str>: Change return type.
7256         (core_target::pid_to_str): Change return type.
7257         * target.c (normal_pid_to_str): Change return type.
7258         (default_pid_to_str): Likewise.
7259         (target_pid_to_str): Change return type.
7260         (target_translate_tls_address): Update.
7261         (target_announce_detach): Update.
7262         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7263         return type.
7264         (bsd_uthread_target::pid_to_str): Change return type.
7265         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7266         type.
7267         (bsd_kvm_target::pid_to_str): Change return type.
7268         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7269         return type.
7270         (aix_thread_target::pid_to_str): Change return type.
7271         * target.h (struct target_ops) <pid_to_str>: Change return type.
7272         (target_pid_to_str, normal_pid_to_str): Likewise.
7273         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7274         type.
7275         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7276         type.
7277         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7278         return type.
7279         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7280         type.
7281         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7282         type.
7283         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7284         return type.
7285
7286 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7287
7288         * NEWS: Mention that the new default MI version is 3.  Mention
7289         changes to the output of commands and events that deal with
7290         multi-location breakpoints.
7291         * breakpoint.c: Include "mi/mi-out.h".
7292         (print_one_breakpoint): Change output syntax if using MI version
7293         >= 3.
7294         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7295         New.
7296         (mi_multi_location_breakpoint_output_fixed): New.
7297         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7298         (mi_cmd_fix_multi_location_breakpoint_output): New.
7299         (mi_multi_location_breakpoint_output_fixed): New.
7300         * mi/mi-cmds.c (mi_cmds): Register command
7301         -fix-multi-location-breakpoint-output.
7302         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7303         interpreter "mi".
7304
7305 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7306
7307         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7308         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7309         instantiate mi_ui_out based on interpreter name.
7310         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7311         * mi/mi-main.c (mi_load_progress): Likewise.
7312
7313 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7314
7315         * NEWS: Combine separate "New targets" sections for 8.3.
7316
7317 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7318
7319         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7320         (ppcfbsd_init_abi): Install gdbarch
7321         "fetch_tls_load_module_address" and "get_thread_local_address"
7322         methods.
7323
7324 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7325
7326         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7327         (riscv_fbsd_init_abi): Install gdbarch
7328         "fetch_tls_load_module_address" and "get_thread_local_address"
7329         methods.
7330
7331 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7332
7333         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7334         (i386fbsd_init_abi): Install gdbarch
7335         "fetch_tls_load_module_address" and "get_thread_local_address"
7336         methods.
7337
7338 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7339
7340         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7341         (amd64fbsd_init_abi): Install gdbarch
7342         "fetch_tls_load_module_address" and "get_thread_local_address"
7343         methods.
7344
7345 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7346
7347         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7348         (struct fbsd_pspace_data): New type.
7349         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7350         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7351         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7352         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7353         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7354
7355 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7356
7357         * gdbtypes.c (lookup_struct_elt): New function.
7358         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7359         * gdbtypes.h (struct struct_elt): New type.
7360         (lookup_struct_elt): New prototype.
7361
7362 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7363
7364         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7365         remove disabled code block.
7366
7367 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7368
7369         * gdbarch.sh (get_thread_local_address): New method.
7370         * gdbarch.h, gdbarch.c: Regenerate.
7371         * target.c (target_translate_tls_address): Use
7372         gdbarch_get_thread_local_address if present instead of
7373         target::get_thread_local_address.
7374
7375 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7376
7377         * target.h (target::get_thread_local_address): Update comment.
7378
7379 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7380
7381         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7382         objfile->separate_debug_objfile_backlink if not NULL.
7383
7384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7385
7386         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7387         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7388         (amd64bsd_store_inferior_registers): Likewise.
7389         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7390         Enable segment base registers.
7391         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7392         PT_GETFSBASE and PT_GETGSBASE.
7393         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7394         PT_SETGSBASE.
7395         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7396         segment base registers.
7397         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7398
7399 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7400
7401         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7402         Update calls to i386_target_description to add 'segments'
7403         parameter.
7404         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7405         add segment base registers.
7406         * arch/i386.c (i386_create_target_description): Add 'segments'
7407         parameter to enable segment base registers.
7408         * arch/i386.h (i386_create_target_description): Likewise.
7409         * features/i386/32bit-segments.xml: New file.
7410         * features/i386/32bit-segments.c: Generate.
7411         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7412         call to i386_target_description to add 'segments' parameter.
7413         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7414         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7415         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7416         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7417         if feature is present.
7418         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7419         Add 'segments' parameter to call to i386_target_description.
7420         (i386_target_description): Add 'segments' parameter to enable
7421         segment base registers.
7422         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7423         to call to i386_target_description.
7424         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7425         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7426         Define I386_NUM_REGS.
7427         (i386_target_description): Add 'segments' parameter to enable
7428         segment base registers.
7429
7430 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7431
7432         PR/24325
7433         * source-cache.c: #undef open and close, to avoid unresolved
7434         externals during linking.
7435
7436 2019-03-12  Tom Tromey  <tromey@adacore.com>
7437
7438         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7439         const.  Add initializers.
7440         (_initialize_remote): Don't initialize ptid globals.
7441
7442 2019-03-12  Pedro Alves  <palves@redhat.com>
7443
7444         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7445
7446 2019-03-12  Pedro Alves  <palves@redhat.com>
7447
7448         * cp-name-parser.y (main): Remove unused 'len' variable.
7449
7450 2019-03-12  Tom Tromey  <tromey@adacore.com>
7451
7452         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7453         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7454
7455 2019-03-12  Tom Tromey  <tromey@adacore.com>
7456
7457         * linux-nat.c (iterate_over_lwps): Update.
7458         (stop_callback): Remove parameter.
7459         (stop_wait_callback, detach_callback, resume_set_callback)
7460         (select_singlestep_lwp_callback, set_ignore_sigint)
7461         (status_callback, resumed_callback, resume_clear_callback)
7462         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7463         data parameter.
7464         (linux_nat_target::detach, linux_nat_target::resume)
7465         (linux_stop_and_wait_all_lwps, select_event_lwp)
7466         (linux_nat_filter_event, linux_nat_wait_1)
7467         (linux_nat_target::kill, linux_nat_target::stop)
7468         (linux_nat_target::stop): Update.
7469         (linux_nat_resume_callback): Change type.
7470         (resume_stopped_resumed_lwps, count_events_callback)
7471         (select_event_lwp_callback): Likewise.
7472         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7473         * arm-linux-nat.c (struct update_registers_data): Remove.
7474         (update_registers_callback): Change type.
7475         (arm_linux_insert_hw_breakpoint1): Update.
7476         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7477         parameter.
7478         (x86_linux_dr_set_addr): Update.
7479         (x86_linux_dr_set_control): Update.
7480         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7481         (iterate_over_lwps): Use gdb::function_view.
7482         * nat/aarch64-linux-hw-point.c (struct
7483         aarch64_dr_update_callback_param): Remove.
7484         (debug_reg_change_callback): Change type.
7485         (aarch64_notify_debug_reg_change): Update.
7486         * s390-linux-nat.c (s390_refresh_per_info): Update.
7487
7488 2019-03-11  Tom Tromey  <tromey@adacore.com>
7489
7490         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7491         redundant assignment to "this_cu".
7492
7493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7494
7495         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7496
7497 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7498
7499         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7500         from...
7501         (rank_one_type): ... this.
7502
7503 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7504
7505         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7506         from...
7507         (rank_one_type): ... this.
7508
7509 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7510
7511         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7512         from...
7513         (rank_one_type): ... this.
7514
7515 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7516
7517         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7518         from...
7519         (rank_one_type): ... this.
7520
7521 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7522
7523         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7524         from...
7525         (rank_one_type): ... this.
7526
7527 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7528
7529         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7530         from...
7531         (rank_one_type): ... this.
7532
7533 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7534
7535         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7536         from...
7537         (rank_one_type): ... this.
7538
7539 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7540
7541         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7542         from...
7543         (rank_one_type): ... this.
7544
7545 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7546
7547         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7548         from...
7549         (rank_one_type): ... this.
7550
7551 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7552
7553         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7554         from...
7555         (rank_one_type): ... this.
7556
7557 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7558
7559         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7560         from...
7561         (rank_one_type): ... this.
7562
7563 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7564
7565         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7566         from...
7567         (rank_one_type): ... this.
7568
7569 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7570
7571         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7572         inferior-events' shows the example events.
7573
7574 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7575
7576         Support styling on native MS-Windows console
7577
7578         PR/24315
7579         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7580         on MS-Windows if $TERM is not defined.
7581
7582         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7583
7584         * posix-hdep.c (gdb_console_fputs):
7585         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7586         functions.
7587         * ui-file.h (gdb_console_fputs): Add prototype.
7588
7589         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7590         back to fputs only if the former returns zero.
7591
7592 2019-03-07  Tom Tromey  <tom@tromey.com>
7593
7594         * symmisc.c (print_symbol_bcache_statistics): Update.
7595         (print_objfile_statistics): Update.
7596         * symfile.c (allocate_symtab): Update.
7597         * stabsread.c: Don't include bcache.h.
7598         * psymtab.h (struct psymbol_bcache): Don't declare.
7599         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7600         (psymbol_bcache_init, psymbol_bcache_free)
7601         (psymbol_bcache_get_bcache): Don't declare.
7602         * psymtab.c (struct psymbol_bcache): Remove.
7603         (psymtab_storage::psymtab_storage): Update.
7604         (psymtab_storage::~psymtab_storage): Update.
7605         (psymbol_bcache_init, psymbol_bcache_free)
7606         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7607         (add_psymbol_to_bcache): Update.
7608         (allocate_psymtab): Update.
7609         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7610         macro_cache>: No longer pointers.
7611         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7612         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7613         * macrotab.c (macro_bcache): Update.
7614         * macroexp.c: Don't include bcache.h.
7615         * gdbtypes.c (check_types_worklist): Update.
7616         (types_deeply_equal): Remove TRY/CATCH.  Update.
7617         * elfread.c (elf_symtab_read): Update.
7618         * dwarf2read.c: Don't include bcache.h.
7619         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7620         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7621         (print_bcache_statistics, bcache_memory_used): Don't declare.
7622         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7623         methods.  Rename all data members.
7624         * bcache.c (struct bcache): Move to bcache.h.
7625         (bcache::expand_hash_table): Rename from expand_hash_table.
7626         (bcache): Remove.
7627         (bcache::insert): Rename from bcache_full.
7628         (bcache::compare): Rename from bcache_compare.
7629         (bcache_xmalloc): Remove.
7630         (bcache::~bcache): Rename from bcache_xfree.
7631         (bcache::print_statistics): Rename from print_bcache_statistics.
7632         (bcache::memory_used): Rename from bcache_memory_used.
7633
7634 2019-03-07  Pedro Alves  <palves@redhat.com>
7635
7636         * infrun.c (normal_stop): Also check for
7637         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7638
7639 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7640
7641         * f-lang.c (value_from_host_double): Moved to...
7642         * value.c (value_from_host_double): ...here.
7643         * value.h (value_from_host_double): Declare.
7644         * guile/scm-math.c (vlscm_convert_typed_number): Use
7645         value_from_host_double.
7646         (vlscm_convert_number): Likewise.
7647         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7648         * python/py-value.c (convert_value_from_python): Likewise.
7649
7650 2019-03-06  Tom Tromey  <tom@tromey.com>
7651
7652         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7653
7654 2019-03-06  Tom Tromey  <tom@tromey.com>
7655
7656         * utils.h (free_current_contents): Don't declare.
7657         * utils.c (free_current_contents): Remove.
7658
7659 2019-03-06  Tom Tromey  <tom@tromey.com>
7660
7661         * top.c (quit_force): Update.
7662         * main.c (captured_command_loop): Update.
7663         * common/new-op.c (operator new): Update.
7664         * common/common-exceptions.c (struct catcher)
7665         <save_cleanup_chain>: Remove member.
7666         (exceptions_state_mc_init): Update.
7667         (exception_try_scope_entry): Return nullptr.
7668         (exception_try_scope_exit, exception_rethrow)
7669         (throw_exception_sjlj, throw_exception_cxx): Update.
7670         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7671         (all_cleanups, do_cleanups, discard_cleanups)
7672         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7673         (restore_cleanups, restore_final_cleanups): Don't declare.
7674         (do_final_cleanups): Remove parameter.
7675         * common/cleanups.c (cleanup_chain, make_cleanup)
7676         (make_cleanup_dtor, all_cleanups, do_cleanups)
7677         (discard_my_cleanups, discard_cleanups)
7678         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7679         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7680         (null_cleanup): Remove.
7681         (do_final_cleanups): Remove parameter.
7682
7683 2019-03-06  Tom Tromey  <tom@tromey.com>
7684
7685         * remote.c (remote_target::remote_parse_stop_reply): Use
7686         unique_xmalloc_ptr.
7687
7688 2019-03-06  Tom Tromey  <tom@tromey.com>
7689
7690         * stabsread.c (struct stabs_field_info): Rename from field_info.
7691         <list, fnlist>: Add initializers.
7692         <obstack>: New member.
7693         (read_member_functions, read_struct_fields, read_baseclasses):
7694         Allocate on obstack.  Don't use cleanups.
7695         (read_one_struct_field, read_member_functions, read_struct_fields)
7696         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7697         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7698         (read_struct_type): Update.
7699
7700 2019-03-06  Tom Tromey  <tom@tromey.com>
7701
7702         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7703         * common/filestuff.h (make_cleanup_close): Don't declare.
7704         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7705         Remove.
7706
7707 2019-03-06  Tom Tromey  <tom@tromey.com>
7708
7709         * solib-aix.c: Use make_scope_exit.
7710
7711 2019-03-06  Tom Tromey  <tom@tromey.com>
7712
7713         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7714         Use make_scope_exit.
7715
7716 2019-03-06  Tom Tromey  <tom@tromey.com>
7717
7718         * solib-svr4.c (disable_probes_interface): Remove parameter.
7719         (svr4_handle_solib_event): Use make_scope_exit.
7720
7721 2019-03-06  Tom Tromey  <tom@tromey.com>
7722
7723         * remote.c (struct stop_reply_deleter): Remove.
7724         (stop_reply_up): Update.
7725         (struct stop_reply): Derive from notif_event.  Don't typedef.
7726         <regcache>: Now a std::vector.
7727         (stop_reply_xfree): Remove.
7728         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7729         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7730         (remote_target::discard_pending_stop_replies): Use delete.
7731         (remote_target::remote_parse_stop_reply): Update.
7732         (remote_target::process_stop_reply): Update.
7733         * remote-notif.h (struct notif_event): Add virtual destructor.
7734         Remove "dtr" member.
7735         (struct notif_client) <alloc_event>: Return a unique_ptr.
7736         (notif_event_xfree): Don't declare.
7737         (notif_event_up): New typedef.
7738         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7739         (notif_event_xfree, do_notif_event_xfree): Remove.
7740         (remote_notif_state_xfree): Update.
7741
7742 2019-03-06  Tom Tromey  <tom@tromey.com>
7743
7744         * infrun.c (displaced_step_clear_cleanup): Now a
7745         forward_scope_exit type.
7746         (displaced_step_prepare_throw): Update.
7747         (displaced_step_fixup): Update.
7748
7749 2019-03-06  Tom Tromey  <tom@tromey.com>
7750
7751         * inferior.h (class inferior): Update comment.
7752         * gdbthread.h (class thread_info): Update comment.
7753
7754 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7755             Tom Tromey  <tom@tromey.com>
7756
7757         * stabsread.h (struct stab_section_list): Remove.
7758         (coffstab_build_psymtabs): Update.
7759         * dbxread.c (symbuf_sections): Now a std::vector.
7760         (sect_idx): New global.
7761         (fill_symbuf): Update.
7762         (coffstab_build_psymtabs): Change type of stabsects parameter.
7763         Update.
7764         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7765         std::vector.
7766         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7767         (coff_locate_sections): Update.
7768         (coff_symfile_read): Remove cleanups.  Update.
7769         (init_stringtab): Add storage parameter.
7770         (free_stringtab, free_stringtab_cleanup): Remove.
7771         (init_lineno): Add storage parameter.
7772         (free_linetab, free_linetab_cleanup): Remove.
7773
7774 2019-03-06  Pedro Alves  <palves@redhat.com>
7775
7776         * linux-fork.c (fork_info::clobber_regs): Delete.
7777         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7778         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7779         comment.  Adjust.
7780         (scoped_switch_fork_info::scoped_switch_fork_info)
7781         (checkpoint_command, linux_fork_context): Adjust
7782         fork_save_infrun_state calls.
7783
7784 2019-03-06  Pedro Alves  <palves@redhat.com>
7785
7786         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7787         (inf_has_multiple_threads): Return 'bool' and rewrite using
7788         inferior_info::threads().
7789
7790 2019-03-06  Pedro Alves  <palves@redhat.com>
7791
7792         * linux-fork.c: Include <list>.
7793         (fork_list): Now a std::list instance.
7794         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7795         (forks_exist_p, find_last_fork): Adjust.
7796         (new_fork): Delete.
7797         (one_fork_p): New.
7798         (add_fork): Adjust.
7799         (free_fork): Delete, folded into fork_info::~fork_info().
7800         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7801         Adjust.
7802         (init_fork_list): Delete.
7803         (linux_fork_killall, linux_fork_mourn_inferior)
7804         (linux_fork_detach, info_checkpoints_command): Adjust.
7805         (_initialize_linux_fork): No longer call init_fork_list.
7806
7807 2019-03-06  Pedro Alves  <palves@redhat.com>
7808
7809         * linux-fork.c (new_fork): New, split out of ...
7810         (add_fork): ... this.  Return void.  Move "first fork" special
7811         case from here, to ...
7812         (checkpoint_command): ... here.
7813         * linux-linux.h (add_fork): Return void.
7814
7815 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7816
7817         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7818
7819 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7820             Chris January  <chris.january@arm.com>
7821             David Lecomber  <david.lecomber@arm.com>
7822
7823         * f-exp.y: New token, UNOP_INTRINSIC.
7824         (exp): New pattern using UNOP_INTRINSIC token.
7825         (f77_keywords): Add 'abs' keyword.
7826         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7827         (value_from_host_double): New function.
7828         (evaluate_subexp_f): Support UNOP_ABS.
7829
7830 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7831
7832         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7833         types.
7834
7835 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7836
7837         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7838         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7839         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7840
7841 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7842
7843         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7844
7845 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7846             Chris January  <chris.january@arm.com>
7847
7848         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7849         * f-exp.y: Define 'KIND' token.
7850         (exp): New pattern for KIND expressions.
7851         (ptype): Handle types with a kind extension.
7852         (direct_abs_decl): Extend to spot kind extensions.
7853         (f77_keywords): Add 'kind' to the list.
7854         (push_kind_type): New function.
7855         (convert_to_kind_type): New function.
7856         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7857         * parse.c (operator_length_standard): Likewise.
7858         * parser-defs.h (enum type_pieces): Add tp_kind.
7859         * std-operator.def: Add UNOP_KIND.
7860
7861 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7862
7863         * f-exp.y (f_parse): Set yydebug.
7864
7865 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7866
7867         * f-lang.c (evaluate_subexp_f): New function.
7868         (exp_descriptor_f): New global.
7869         (f_language_defn): Use exp_descriptor_f instead of
7870         exp_descriptor_standard.
7871
7872 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7873
7874         * f-exp.y (struct token): Add comments.
7875         (dot_ops): Remove uppercase versions and the end marker.
7876         (f77_keywords): Likewise.
7877         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7878         entries in the dot_ops array are case insensitive, and use
7879         strncasecmp to compare strings.  Also some whitespace cleanup in
7880         this area.  Similar for the f77_keywords array, except entries in
7881         this list might be case sensitive.
7882
7883 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7884
7885         * f-exp.y (struct f77_boolean_val): Add comments.
7886         (boolean_values): Remove uppercase versions, and end marker.
7887         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7888         and use strncasecmp to achieve case insensitivity.  Additionally,
7889         perform whitespace cleanup around this code.
7890
7891 2019-03-06  Tom Tromey  <tromey@adacore.com>
7892
7893         * remote-sim.c (gdbsim_target_open): Use result of
7894         gdb_argv::release.
7895
7896 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7897         Dirk Schubert  <dirk.schubert@arm.com>
7898         Chris January  <chris.january@arm.com>
7899
7900         * eval.c (evaluate_subexp_standard): Call Fortran argument
7901         wrapping logic.
7902         * f-lang.c (struct value): A value which can be passed into a
7903         Fortran function call.
7904         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7905         where appropriate.
7906         (struct type): Value ready for a Fortran function call.
7907         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7908         is needed.
7909         * f-lang.h (fortran_argument_convert): Declaration.
7910         (fortran_preserve_arg_pointer): Declaration.
7911         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7912
7913 2019-03-05  Tom Tromey  <tromey@adacore.com>
7914
7915         * python/py-prettyprint.c (print_string_repr): Remove #if.
7916         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7917
7918 2019-03-05  Tom Tromey  <tromey@adacore.com>
7919
7920         * target.c (the_dummy_target): Move later.  Change type to
7921         "dummy_target".
7922         (initialize_targets): Don't initialize the_dummy_target.
7923
7924 2019-03-05  Tom Tromey  <tromey@adacore.com>
7925
7926         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7927         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7928
7929 2019-03-05  Tom Tromey  <tromey@adacore.com>
7930
7931         * windows-nat.c (windows_nat_target::attach)
7932         (windows_nat_target::detach): Don't call gdb_flush.
7933         * valprint.c (generic_val_print, val_print, val_print_string):
7934         Don't call gdb_flush.
7935         * utils.c (defaulted_query): Don't call gdb_flush.
7936         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7937         * target.c (target_announce_detach): Don't call gdb_flush.
7938         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7939         * remote.c (extended_remote_target::attach): Don't call
7940         gdb_flush.
7941         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7942         * printcmd.c (do_examine): Don't call gdb_flush.
7943         (info_display_command): Don't call gdb_flush.
7944         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7945         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7946         * memattr.c (info_mem_command): Don't call gdb_flush.
7947         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7948         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7949         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7950         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7951         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7952         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7953         (gnu_nat_target::detach): Don't call gdb_flush.
7954         * f-valprint.c (f_val_print): Don't call gdb_flush.
7955         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7956         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7957         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7958         gdb_flush.
7959         * c-valprint.c (c_val_print): Don't call gdb_flush.
7960         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7961
7962 2019-03-05  Tom Tromey  <tromey@adacore.com>
7963
7964         * varobj.c (update_dynamic_varobj_children): Update.
7965         (install_default_visualizer): Use reset, not release.
7966         * value.c (set_internalvar): Update.
7967         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7968         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7969         ATTRIBUTE_UNUSED_RESULT.
7970
7971 2019-03-05  Tom Tromey  <tromey@adacore.com>
7972
7973         * remote.c (class scoped_remote_fd) <release>: Add
7974         ATTRIBUTE_UNUSED_RESULT.
7975
7976 2019-03-05  Tom Tromey  <tromey@adacore.com>
7977
7978         * macroexp.c (struct macro_buffer) <release>: Add
7979         ATTRIBUTE_UNUSED_RESULT.
7980
7981 2019-03-05  Tom Tromey  <tromey@adacore.com>
7982
7983         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7984         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7985         ATTRIBUTE_UNUSED_RESULT.
7986
7987 2019-03-05  Tom Tromey  <tromey@adacore.com>
7988
7989         * common/scoped_fd.h (class scoped_fd) <release>: Add
7990         ATTRIBUTE_UNUSED_RESULT.
7991
7992 2019-03-05  Tom Tromey  <tromey@adacore.com>
7993
7994         * parser-defs.h (struct parser_state) <release>: Add
7995         ATTRIBUTE_UNUSED_RESULT.
7996
7997 2019-03-05  Tom Tromey  <tromey@adacore.com>
7998
7999         * utils.h (class gdb_argv) <release>: Add
8000         ATTRIBUTE_UNUSED_RESULT.
8001         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8002
8003 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8004
8005         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8006         for-loop range, to avoid compiler warnings.
8007
8008         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8009         avoid compiler warnings about unused variables.
8010
8011         * NEWS: Mention end of support for native debugging on MS-Windows
8012         before XP.
8013
8014         PR gdb/24292
8015         * common/netstuff.c:
8016         * gdbserver/gdbreplay.c
8017         * gdbserver/remote-utils.c:
8018         * ser-tcp.c:
8019         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8020         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8021         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8022         'getaddrinfo' and 'freeaddrinfo' were not available before
8023         Windows XP, and mingw.org's MinGW headers by default define
8024         _WIN32_WINNT to 0x500.
8025
8026 2019-03-01  Gary Benson <gbenson@redhat.com>
8027
8028         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8029
8030 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8031             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8032
8033         PR gdb/8527
8034         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8035         set_sigint_trap, clear_sigint_trap.
8036
8037 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8038
8039         * target.c (target_detach): Clear the regcache and the
8040         frame cache.
8041
8042 2019-02-27  Pedro Alves  <palves@redhat.com>
8043
8044         * utils.c (set_screen_size): When we cap the height/width sizes,
8045         tweak the corresponding command variable to show "unlimited":
8046
8047 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8048             Pedro Alves  <palves@redhat.com>
8049
8050         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8051         before calling rl_set_screen_size.
8052
8053 2019-02-27  Tom Tromey  <tromey@adacore.com>
8054
8055         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8056         define.
8057         * python/py-value.c: Remove Python 2.4 workaround.
8058         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8059         workaround.
8060         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8061         Python 2.4 workaround.
8062         * python/python-internal.h: Remove Python 2.4 comment.
8063         (Py_ssize_t): Don't define.
8064         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8065         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8066         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8067         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8068         * python/python.c (do_start_initialization): Remove Python 2.4
8069         workaround.
8070         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8071         (print_children): Remove Python 2.4 workaround.
8072         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8073         workaround.
8074         (CHARBUFFERPROC_NAME): Remove.
8075         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8076         Python 2.4 workaround.
8077
8078 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8079
8080         * NEWS: Note minimum Python version.
8081
8082 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8083
8084         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8085         code from these functions.  Remove corresponding ifdefs.  Use
8086         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8087         Remove gotos and target of gotos.
8088         (infpy_search_memory): Likewise.
8089
8090 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8091
8092         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8093         (hppa_gdbarch_init): Don't register deleted functions with
8094         gdbarch.
8095
8096 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8097
8098         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8099         (h8300_unwind_sp): Delete.
8100         (h8300_dummy_id): Delete.
8101         (h8300_gdbarch_init): Don't register deleted functions with
8102         gdbarch.
8103
8104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8105
8106         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8107         (ft32_unwind_pc): Delete.
8108         (ft32_unwind_sp): Delete.
8109         (ft32_gdbarch_init): Don't register deleted functions with
8110         gdbarch.
8111
8112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8113
8114         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8115         (frv_unwind_pc): Delete.
8116         (frv_unwind_sp): Delete.
8117         (frv_gdbarch_init): Don't register deleted functions with
8118         gdbarch.
8119
8120 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8121
8122         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8123         (riscv_unwind_pc): Delete.
8124         (riscv_unwind_sp): Delete.
8125         (riscv_gdbarch_init): Don't register deleted functions with
8126         gdbarch.
8127
8128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8129
8130         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8131         (csky_unwind_pc): Delete.
8132         (csky_unwind_sp): Delete.
8133         (csky_gdbarch_init): Don't register deleted functions with
8134         gdbarch.
8135
8136 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8137
8138         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8139         (cris_unwind_pc): Delete.
8140         (cris_unwind_sp): Delete.
8141         (cris_gdbarch_init): Don't register deleted functions with
8142         gdbarch.
8143
8144 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8145
8146         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8147         (bfin_unwind_pc): Delete.
8148         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8149
8150 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8151
8152         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8153         (arm_unwind_pc): Delete.
8154         (arm_unwind_sp): Delete.
8155         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8156
8157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8158
8159         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8160         (arc_unwind_pc): Delete.
8161         (arc_unwind_sp): Delete.
8162         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8163
8164 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8165
8166         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8167         (alpha_unwind_pc): Delete.
8168         (alpha_gdbarch_init): Don't register deleted functions with
8169         gdbarch.
8170
8171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8172
8173         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8174         (aarch64_unwind_pc): Delete.
8175         (aarch64_unwind_sp): Delete.
8176         (aarch64_gdbarch_init): Don't register deleted functions with
8177         gdbarch.
8178
8179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8180
8181         * gdbtypes.c (type_align): Don't consider static members when
8182         computing structure alignment.
8183
8184 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8185
8186         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8187         return 0 for other types.
8188         * arch-utils.c (default_type_align): Always return 0.
8189         * gdbarch.h: Regenerate.
8190         * gdbarch.sh (type_align): Extend comment.
8191         * gdbtypes.c (type_align): Add additional comments, always call
8192         gdbarch_type_align before applying the default rules.
8193         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8194         generic code will then apply a suitable default.
8195         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8196         types, return 0 for other types.
8197
8198 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8199
8200         * NEWS: Create a new section for the next release branch.
8201         Rename the section of the current branch, now that it has
8202         been cut.
8203
8204 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8205
8206         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8207         * version.in: Bump version to 8.3.50.DATE-git.
8208
8209 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8210
8211         * aix-thread.c (ptid_cmp): Remove unused variable.
8212         (get_signaled_thread): Likewise.
8213         (store_regs_user_thread): Likewise.
8214         (store_regs_kernel_thread): Likewise.
8215         (fetch_regs_kernel_thread): Remove shadowed variable.
8216
8217 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8218
8219         * features/riscv/32bit-cpu.xml: Add register numbers.
8220         * features/riscv/32bit-fpu.c: Regenerate.
8221         * features/riscv/32bit-fpu.xml: Add register numbers.
8222         * features/riscv/64bit-cpu.xml: Add register numbers.
8223         * features/riscv/64bit-fpu.c: Regenerate.
8224         * features/riscv/64bit-fpu.xml: Add register numbers.
8225
8226 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8227
8228         * NEWS: Mention two argument form of gdb.Value constructor.
8229         * python/py-value.c (convert_buffer_and_type_to_value): New
8230         function.
8231         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8232         Add support for handling an optional second argument.  Call
8233         convert_buffer_and_type_to_value as appropriate.
8234         * python/python-internal.h (Py_buffer_deleter): New struct.
8235         (Py_buffer_up): New typedef.
8236
8237 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8238
8239         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8240         instead of releasing ownership.
8241
8242 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8243
8244         * dwarf2read.c (open_and_init_dwp_file): Call
8245         elf_numsections instead of bfd_count_sections to initialize
8246         dwp_file->num_sections.
8247
8248 2019-02-25  Tom Tromey  <tromey@adacore.com>
8249
8250         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8251
8252 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8253
8254         * gcore.in: Add '--readnever' option when invoking GDB.
8255
8256 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8257
8258         * MAINTAINERS: Update my email address.
8259
8260 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8261
8262         * build-id.c (build_id_to_debug_bfd_1): New function.
8263         (build_id_to_debug_bfd): Look for separate debug file in
8264         sysroot.
8265
8266 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8267
8268         * gdbarch.sh: Update the copyright year range that is placed into
8269         generated files.
8270
8271 2019-02-22  Keith Seitz  <keiths@redhat.com>
8272
8273         PR symtab/23853
8274         * linespec.c (create_sals_line_offset): Search for the default
8275         symtab's filename instead of its fullname.
8276
8277 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8278
8279         * NEWS: Update style defaults.
8280
8281 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8282
8283         * main.c (captured_main_1): Disable styling in batch mode.
8284
8285 2019-02-20  Tom Tromey  <tom@tromey.com>
8286
8287         * symtab.c (symtab_symbol_info): Fix typos.
8288
8289 2019-02-20  Tom Tromey  <tromey@adacore.com>
8290
8291         * findcmd.c (_initialize_mem_search): Use upper case for
8292         metasyntactic variables.
8293
8294 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8295
8296         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8297         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8298
8299 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8300
8301         * top.h (source_file_name): Change to std::string.
8302         * top.c (source_file_name): Likewise.
8303         (command_line_input): Adjust.
8304         * cli/cli-script.c (script_from_file): Adjust.
8305
8306 2019-02-19  Tom Tromey  <tromey@adacore.com>
8307
8308         * ravenscar-thread.c
8309         (ravenscar_thread_target::update_thread_list): Don't call
8310         ada_build_task_list.
8311         * ada-lang.h (ada_build_task_list): Don't declare.
8312         * ada-tasks.c (struct ada_tasks_inferior_data)
8313         <task_list_valid_p>: Now bool.
8314         (read_known_tasks, ada_task_list_changed)
8315         (ada_tasks_invalidate_inferior_data): Update.
8316         (read_known_tasks_array): Return bool.
8317         (read_known_tasks_list): Likewise.
8318         (read_known_tasks): Return void.
8319         (ada_build_task_list): Now static.
8320
8321 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8322
8323         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8324         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8325
8326 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8327
8328         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8329         variant for ada_tasks_pspace_data_handle and
8330         ada_tasks_inferior_data_handle.
8331         (ada_tasks_pspace_data_cleanup): New function.
8332         (ada_tasks_inferior_data_cleanup): New function.
8333
8334 2019-02-17  Tom Tromey  <tom@tromey.com>
8335
8336         * macrotab.h (macro_source_fullname): Return a std::string.
8337         * macrotab.c (macro_include, check_for_redefinition)
8338         (macro_undef, macro_lookup_definition, foreach_macro)
8339         (foreach_macro_in_scope): Update.
8340         (macro_source_fullname): Return a std::string.
8341         * macrocmd.c (show_pp_source_pos): Update.
8342
8343 2019-02-17  Tom Tromey  <tom@tromey.com>
8344
8345         * macrocmd.c (show_pp_source_pos): Style the file names.
8346
8347 2019-02-17  Tom Tromey  <tom@tromey.com>
8348
8349         PR tui/24197:
8350         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8351
8352 2019-02-17  Tom Tromey  <tom@tromey.com>
8353
8354         * ada-lang.c (user_select_syms): Use filtered printing.
8355         * utils.c (wrap_style): New global.
8356         (desired_style): Remove.
8357         (emit_style_escape): Add stream parameter.
8358         (set_output_style, reset_terminal_style, prompt_for_continue):
8359         Update.
8360         (flush_wrap_buffer): Only flush gdb_stdout.
8361         (wrap_here): Set wrap_style.
8362         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8363         treat escape sequences as a character.  Change when wrap buffer is
8364         flushed.
8365         (fputs_styled): Do not set the output style when the default is
8366         requested.
8367         * ui-style.h (struct ui_file_style) <is_default>: New method.
8368         * source.c (print_source_lines_base): Emit escape sequences in one
8369         piece.
8370
8371 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8372
8373         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8374         integers and enumeration types.
8375
8376 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8377
8378         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8379         instead of lookup_symbol_in_language
8380         (do_exact_match): New function.
8381         (ada_get_symbol_name_matcher): Return do_exact_match when
8382         doing a verbatim match.
8383
8384 2019-02-15  Tom Tromey  <tromey@adacore.com>
8385
8386         * ravenscar-thread.c (ravenscar_thread_target::resume)
8387         (ravenscar_thread_target::wait): Special case wildcard requests.
8388
8389 2019-02-15  Tom Tromey  <tromey@adacore.com>
8390
8391         * ravenscar-thread.c (base_ptid): Remove.
8392         (struct ravenscar_thread_target) <close>: New method.
8393         <m_base_ptid>: New member.
8394         <update_inferior_ptid, active_task, task_is_currently_active,
8395         runtime_initialized>: Declare methods.
8396         <ravenscar_thread_target>: Add constructor.
8397         (ravenscar_thread_target::task_is_currently_active)
8398         (ravenscar_thread_target::update_inferior_ptid)
8399         (ravenscar_runtime_initialized): Rename.  Now methods.
8400         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8401         (ravenscar_thread_target::update_thread_list): Update.
8402         (ravenscar_thread_target::active_task): Now method.
8403         (ravenscar_thread_target::store_registers)
8404         (ravenscar_thread_target::prepare_to_store)
8405         (ravenscar_thread_target::prepare_to_store)
8406         (ravenscar_thread_target::mourn_inferior): Update.
8407         (ravenscar_inferior_created): Use "new" to create target.
8408         (ravenscar_thread_target::get_ada_task_ptid): Update.
8409         (_initialize_ravenscar): Don't initialize base_ptid.
8410         (ravenscar_ops): Remove global.
8411
8412 2019-02-15  Tom Tromey  <tromey@adacore.com>
8413
8414         * target.h (push_target): Declare new overload.
8415         * target.c (push_target): New overload, taking an rvalue reference.
8416         * remote.c (remote_target::open_1): Use push_target overload.
8417         * corelow.c (core_target_open): Use push_target overload.
8418
8419 2019-02-15  Tom Tromey  <tromey@adacore.com>
8420
8421         * ravenscar-thread.c (is_ravenscar_task)
8422         (ravenscar_task_is_currently_active): Return bool.
8423         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8424         (_initialize_ravenscar): Remove "(void)".
8425         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8426         Return bool.
8427
8428 2019-02-15  Tom Tromey  <tromey@adacore.com>
8429
8430         * ravenscar-thread.c (ravenscar_runtime_initializer)
8431         (has_ravenscar_runtime, get_running_thread_id)
8432         (ravenscar_thread_target::resume): Fix indentation.
8433
8434 2019-02-15  Tom Tromey  <tromey@adacore.com>
8435
8436         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8437         from ravenscar_arch_ops.
8438         (sparc_ravenscar_ops::fetch_registers)
8439         (sparc_ravenscar_ops::store_registers): Now methods.
8440         (sparc_ravenscar_prepare_to_store): Remove.
8441         (sparc_ravenscar_ops): Redefine.
8442         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8443         methods and destructor.  Remove members.
8444         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8445         (ravenscar_thread_target::store_registers)
8446         (ravenscar_thread_target::prepare_to_store): Update.
8447         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8448         Remove.
8449         (struct ppc_ravenscar_powerpc_ops): Derive from
8450         ravenscar_arch_ops.
8451         (ppc_ravenscar_powerpc_ops::fetch_registers)
8452         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8453         (ppc_ravenscar_powerpc_ops): Redefine.
8454         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8455         (ppc_ravenscar_e500_ops::fetch_registers)
8456         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8457         (ppc_ravenscar_e500_ops): Redefine.
8458         * aarch64-ravenscar-thread.c
8459         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8460         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8461         (aarch64_ravenscar_fetch_registers)
8462         (aarch64_ravenscar_store_registers): Now methods.
8463         (aarch64_ravenscar_ops): Redefine.
8464
8465 2019-02-15  Tom Tromey  <tromey@adacore.com>
8466
8467         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8468         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8469         (ravenscar_thread_target::stopped_by_watchpoint)
8470         (ravenscar_thread_target::stopped_data_address)
8471         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8472
8473 2019-02-15  Tom Tromey  <tromey@adacore.com>
8474
8475         * ravenscar-thread.c: Fix some typos.
8476
8477 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8478             Tom Tromey  <tromey@adacore.com>
8479
8480         * ada-lang.c (ada_exception_sal): Change addr_string to a
8481         std::string.
8482         (create_ada_exception_catchpoint): Update.
8483
8484 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8485             Tom Tromey  <tromey@adacore.com>
8486
8487         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8488         (bp_location_ops): Remove.
8489         (base_breakpoint_allocate_location): Update.
8490         (free_bp_location): Update.
8491         * ada-lang.c (class ada_catchpoint_location)
8492         <ada_catchpoint_location>: Remove ops parameter.
8493         (ada_catchpoint_location_dtor): Remove.
8494         (ada_catchpoint_location_ops): Remove.
8495         (allocate_location_exception): Update.
8496         * breakpoint.h (struct bp_location_ops): Remove.
8497         (class bp_location) <bp_location>: Remove bp_location_ops
8498         parameter.
8499         <~bp_location>: Add destructor.
8500         <ops>: Remove.
8501
8502 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8503             Pedro Alves  <palves@redhat.com>
8504
8505         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8506         'PATH_MAX'.
8507
8508 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8509             Samuel Thibault  <samuel.thibault@gnu.org>
8510             Thomas Schwinge  <thomas@codesourcery.com>
8511
8512         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8513         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8514
8515 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8516
8517         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8518         (check_empty): Use "const char *".
8519
8520         * gnu-nat.c (gnu_nat_target::detach): Instead of
8521         'detach_inferior (pid)' call
8522         'detach_inferior (find_inferior_pid (pid))'.
8523
8524         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8525         'nat/fork-inferior.o'.
8526         * gnu-nat.c: #include "nat/fork-inferior.h".
8527
8528         * gnu-nat.c (gnu_nat_target::detach): Instead of
8529         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8530         * gnu-nat.h: #include "inf-child.h".
8531         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8532         'i386_gnu_nat_target::fetch_registers'.
8533         (gnu_store_registers): Rename/move to
8534         'i386_gnu_nat_target::store_registers'.
8535
8536         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8537         * gnu-nat.h (mach_thread_info): New function.
8538         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8539
8540         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8541
8542 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8543
8544         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8545
8546 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8547
8548         * windows-nat.c (windows_add_thread): Add new parameter
8549         "main_thread_p" with default value set to false.  Update
8550         function documentation as well as all callers.
8551         (windows_delete_thread): Likewise.
8552         (fake_create_process): Update call to windows_add_thread.
8553         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8554         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8555         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8556         call to windows_delete_thread.
8557
8558 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8559
8560         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8561
8562 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8563
8564         * symfile.c (find_separate_debug_file): Use canonical path of
8565         sysroot with child_path instead of gdb_sysroot if it is valid.
8566
8567 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8568
8569         * symfile.c (find_separate_debug_file): Use child_path to
8570         determine if an object file is under a sysroot.
8571
8572 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8573
8574         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8575         unittests/child-path-selftests.c.
8576         * common/pathstuff.c (child_path): New function.
8577         * common/pathstuff.h (child_path): New prototype.
8578         * unittests/child-path-selftests.c: New file.
8579
8580 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8581
8582         * symfile.c (find_separate_debug_file): Look for separate debug
8583         files in debug directories under the sysroot.
8584
8585 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8586
8587         * symtab.h (struct minimal_symbol data_p): New const method.
8588         (struct minimal_symbol text_p): Likewise.
8589         * symtab.c (output_source_filename): Use file name style
8590         to print file name.
8591         (print_symbol_info): Likewise.
8592         (print_msymbol_info): Use address style to print addresses.
8593         Use function name style to print executable text symbols.
8594         (expand_symtab_containing_pc): Use data_p.
8595         (find_pc_sect_compunit_symtab): Likewise.
8596
8597 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8598
8599         * breakpoint.c (describe_other_breakpoints): Use address style
8600         to print addresses.
8601         (say_where): Likewise.
8602
8603 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8604
8605         * ada-typeprint.c (print_func_type): Print function name
8606         style to print function name.
8607         * c-typeprint.c (c_print_type_1): Likewise.
8608
8609 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8610
8611         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8612         for execve.
8613
8614 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8615
8616         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8617         type_stack.
8618
8619 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8620
8621         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8622         TYPE_CODE_REF types.
8623
8624 2019-02-08  Jim Wilson  <jimw@sifive.com>
8625
8626         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8627         (riscv_linux_fregset): New.
8628         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8629
8630 2019-02-07  Tom Tromey  <tom@tromey.com>
8631
8632         * thread.c (thread_cancel_execution_command): Update.
8633         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8634         methods.
8635         (struct thread_fsm_ops): Remove.
8636         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8637         (thread_fsm_should_stop, thread_fsm_return_value)
8638         (thread_fsm_set_finished, thread_fsm_finished_p)
8639         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8640         Don't declare.
8641         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8642         * infrun.c (clear_proceed_status_thread)
8643         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8644         (print_stop_event): Update.
8645         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8646         Add constructor.
8647         (step_command_fsm_ops): Remove.
8648         (new_step_command_fsm): Remove.
8649         (step_1): Update.
8650         (step_command_fsm::should_stop): Rename from
8651         step_command_fsm_should_stop.
8652         (step_command_fsm::clean_up): Rename from
8653         step_command_fsm_clean_up.
8654         (step_command_fsm::do_async_reply_reason): Rename from
8655         step_command_fsm_async_reply_reason.
8656         (struct until_next_fsm): Inherit from thread_fsm.  Add
8657         constructor.
8658         (until_next_fsm_ops): Remove.
8659         (new_until_next_fsm): Remove.
8660         (until_next_fsm::should_stop): Rename from
8661         until_next_fsm_should_stop.
8662         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8663         (until_next_fsm::do_async_reply_reason): Rename from
8664         until_next_fsm_async_reply_reason.
8665         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8666         constructor.  Change type of breakpoint.
8667         (finish_command_fsm_ops): Remove.
8668         (new_finish_command_fsm): Remove.
8669         (finish_command_fsm::should_stop): Rename from
8670         finish_command_fsm_should_stop.
8671         (finish_command_fsm::clean_up): Rename from
8672         finish_command_fsm_clean_up.
8673         (finish_command_fsm::return_value): Rename from
8674         finish_command_fsm_return_value.
8675         (finish_command_fsm::do_async_reply_reason): Rename from
8676         finish_command_fsm_async_reply_reason.
8677         (finish_command): Update.
8678         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8679         Add constructor.
8680         (call_thread_fsm_ops): Remove.
8681         (call_thread_fsm::call_thread_fsm): Rename from
8682         new_call_thread_fsm.
8683         (call_thread_fsm::should_stop): Rename from
8684         call_thread_fsm_should_stop.
8685         (call_thread_fsm::should_notify_stop): Rename from
8686         call_thread_fsm_should_notify_stop.
8687         (run_inferior_call, call_function_by_hand_dummy): Update.
8688         * cli/cli-interp.c (should_print_stop_to_console): Update.
8689         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8690         Add constructor.  Change type of location_breakpoint,
8691         caller_breakpoint.
8692         (until_break_fsm_ops): Remove.
8693         (new_until_break_fsm): Remove.
8694         (until_break_fsm::should_stop): Rename from
8695         until_break_fsm_should_stop.
8696         (until_break_fsm::clean_up): Rename from
8697         until_break_fsm_clean_up.
8698         (until_break_fsm::do_async_reply_reason): Rename from
8699         until_break_fsm_async_reply_reason.
8700         (until_break_command): Update.
8701         * thread-fsm.c: Remove.
8702         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8703
8704 2019-02-07  Tom Tromey  <tom@tromey.com>
8705
8706         * yy-remap.h: Add include guard.
8707         * xtensa-tdep.h: Add include guard.
8708         * xcoffread.h: Rename include guard.
8709         * varobj-iter.h: Add include guard.
8710         * tui/tui.h: Rename include guard.
8711         * tui/tui-winsource.h: Rename include guard.
8712         * tui/tui-wingeneral.h: Rename include guard.
8713         * tui/tui-windata.h: Rename include guard.
8714         * tui/tui-win.h: Rename include guard.
8715         * tui/tui-stack.h: Rename include guard.
8716         * tui/tui-source.h: Rename include guard.
8717         * tui/tui-regs.h: Rename include guard.
8718         * tui/tui-out.h: Rename include guard.
8719         * tui/tui-layout.h: Rename include guard.
8720         * tui/tui-io.h: Rename include guard.
8721         * tui/tui-hooks.h: Rename include guard.
8722         * tui/tui-file.h: Rename include guard.
8723         * tui/tui-disasm.h: Rename include guard.
8724         * tui/tui-data.h: Rename include guard.
8725         * tui/tui-command.h: Rename include guard.
8726         * tic6x-tdep.h: Add include guard.
8727         * target/waitstatus.h: Rename include guard.
8728         * target/wait.h: Rename include guard.
8729         * target/target.h: Rename include guard.
8730         * target/resume.h: Rename include guard.
8731         * target-float.h: Rename include guard.
8732         * stabsread.h: Add include guard.
8733         * rs6000-tdep.h: Add include guard.
8734         * riscv-fbsd-tdep.h: Add include guard.
8735         * regformats/regdef.h: Rename include guard.
8736         * record.h: Rename include guard.
8737         * python/python.h: Rename include guard.
8738         * python/python-internal.h: Rename include guard.
8739         * python/py-stopevent.h: Rename include guard.
8740         * python/py-ref.h: Rename include guard.
8741         * python/py-record.h: Rename include guard.
8742         * python/py-record-full.h: Rename include guard.
8743         * python/py-record-btrace.h: Rename include guard.
8744         * python/py-instruction.h: Rename include guard.
8745         * python/py-events.h: Rename include guard.
8746         * python/py-event.h: Rename include guard.
8747         * procfs.h: Add include guard.
8748         * proc-utils.h: Add include guard.
8749         * p-lang.h: Add include guard.
8750         * or1k-tdep.h: Rename include guard.
8751         * observable.h: Rename include guard.
8752         * nto-tdep.h: Rename include guard.
8753         * nat/x86-linux.h: Rename include guard.
8754         * nat/x86-linux-dregs.h: Rename include guard.
8755         * nat/x86-gcc-cpuid.h: Add include guard.
8756         * nat/x86-dregs.h: Rename include guard.
8757         * nat/x86-cpuid.h: Rename include guard.
8758         * nat/ppc-linux.h: Rename include guard.
8759         * nat/mips-linux-watch.h: Rename include guard.
8760         * nat/linux-waitpid.h: Rename include guard.
8761         * nat/linux-ptrace.h: Rename include guard.
8762         * nat/linux-procfs.h: Rename include guard.
8763         * nat/linux-osdata.h: Rename include guard.
8764         * nat/linux-nat.h: Rename include guard.
8765         * nat/linux-namespaces.h: Rename include guard.
8766         * nat/linux-btrace.h: Rename include guard.
8767         * nat/glibc_thread_db.h: Rename include guard.
8768         * nat/gdb_thread_db.h: Rename include guard.
8769         * nat/gdb_ptrace.h: Rename include guard.
8770         * nat/fork-inferior.h: Rename include guard.
8771         * nat/amd64-linux-siginfo.h: Rename include guard.
8772         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8773         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8774         * nat/aarch64-linux.h: Rename include guard.
8775         * nat/aarch64-linux-hw-point.h: Rename include guard.
8776         * mn10300-tdep.h: Add include guard.
8777         * mips-linux-tdep.h: Add include guard.
8778         * mi/mi-parse.h: Rename include guard.
8779         * mi/mi-out.h: Rename include guard.
8780         * mi/mi-main.h: Rename include guard.
8781         * mi/mi-interp.h: Rename include guard.
8782         * mi/mi-getopt.h: Rename include guard.
8783         * mi/mi-console.h: Rename include guard.
8784         * mi/mi-common.h: Rename include guard.
8785         * mi/mi-cmds.h: Rename include guard.
8786         * mi/mi-cmd-break.h: Rename include guard.
8787         * m2-lang.h: Add include guard.
8788         * location.h: Rename include guard.
8789         * linux-record.h: Rename include guard.
8790         * linux-nat.h: Add include guard.
8791         * linux-fork.h: Add include guard.
8792         * i386-darwin-tdep.h: Rename include guard.
8793         * hppa-linux-offsets.h: Add include guard.
8794         * guile/guile.h: Rename include guard.
8795         * guile/guile-internal.h: Rename include guard.
8796         * gnu-nat.h: Rename include guard.
8797         * gdb-stabs.h: Rename include guard.
8798         * frv-tdep.h: Add include guard.
8799         * f-lang.h: Add include guard.
8800         * event-loop.h: Add include guard.
8801         * darwin-nat.h: Rename include guard.
8802         * cp-abi.h: Rename include guard.
8803         * config/sparc/nm-sol2.h: Rename include guard.
8804         * config/nm-nto.h: Rename include guard.
8805         * config/nm-linux.h: Add include guard.
8806         * config/i386/nm-i386gnu.h: Rename include guard.
8807         * config/djgpp/nl_types.h: Rename include guard.
8808         * config/djgpp/langinfo.h: Rename include guard.
8809         * compile/gcc-cp-plugin.h: Add include guard.
8810         * compile/gcc-c-plugin.h: Add include guard.
8811         * compile/compile.h: Rename include guard.
8812         * compile/compile-object-run.h: Rename include guard.
8813         * compile/compile-object-load.h: Rename include guard.
8814         * compile/compile-internal.h: Rename include guard.
8815         * compile/compile-cplus.h: Rename include guard.
8816         * compile/compile-c.h: Rename include guard.
8817         * common/xml-utils.h: Rename include guard.
8818         * common/x86-xstate.h: Rename include guard.
8819         * common/version.h: Rename include guard.
8820         * common/vec.h: Rename include guard.
8821         * common/tdesc.h: Rename include guard.
8822         * common/selftest.h: Rename include guard.
8823         * common/scoped_restore.h: Rename include guard.
8824         * common/scoped_mmap.h: Rename include guard.
8825         * common/scoped_fd.h: Rename include guard.
8826         * common/safe-iterator.h: Rename include guard.
8827         * common/run-time-clock.h: Rename include guard.
8828         * common/refcounted-object.h: Rename include guard.
8829         * common/queue.h: Rename include guard.
8830         * common/ptid.h: Rename include guard.
8831         * common/print-utils.h: Rename include guard.
8832         * common/preprocessor.h: Rename include guard.
8833         * common/pathstuff.h: Rename include guard.
8834         * common/observable.h: Rename include guard.
8835         * common/netstuff.h: Rename include guard.
8836         * common/job-control.h: Rename include guard.
8837         * common/host-defs.h: Rename include guard.
8838         * common/gdb_wait.h: Rename include guard.
8839         * common/gdb_vecs.h: Rename include guard.
8840         * common/gdb_unlinker.h: Rename include guard.
8841         * common/gdb_unique_ptr.h: Rename include guard.
8842         * common/gdb_tilde_expand.h: Rename include guard.
8843         * common/gdb_sys_time.h: Rename include guard.
8844         * common/gdb_string_view.h: Rename include guard.
8845         * common/gdb_splay_tree.h: Rename include guard.
8846         * common/gdb_setjmp.h: Rename include guard.
8847         * common/gdb_ref_ptr.h: Rename include guard.
8848         * common/gdb_optional.h: Rename include guard.
8849         * common/gdb_locale.h: Rename include guard.
8850         * common/gdb_assert.h: Rename include guard.
8851         * common/filtered-iterator.h: Rename include guard.
8852         * common/filestuff.h: Rename include guard.
8853         * common/fileio.h: Rename include guard.
8854         * common/environ.h: Rename include guard.
8855         * common/common-utils.h: Rename include guard.
8856         * common/common-types.h: Rename include guard.
8857         * common/common-regcache.h: Rename include guard.
8858         * common/common-inferior.h: Rename include guard.
8859         * common/common-gdbthread.h: Rename include guard.
8860         * common/common-exceptions.h: Rename include guard.
8861         * common/common-defs.h: Rename include guard.
8862         * common/common-debug.h: Rename include guard.
8863         * common/cleanups.h: Rename include guard.
8864         * common/buffer.h: Rename include guard.
8865         * common/btrace-common.h: Rename include guard.
8866         * common/break-common.h: Rename include guard.
8867         * cli/cli-utils.h: Rename include guard.
8868         * cli/cli-style.h: Rename include guard.
8869         * cli/cli-setshow.h: Rename include guard.
8870         * cli/cli-script.h: Rename include guard.
8871         * cli/cli-interp.h: Rename include guard.
8872         * cli/cli-decode.h: Rename include guard.
8873         * cli/cli-cmds.h: Rename include guard.
8874         * charset-list.h: Add include guard.
8875         * buildsym-legacy.h: Rename include guard.
8876         * bfin-tdep.h: Add include guard.
8877         * ax.h: Rename include guard.
8878         * arm-linux-tdep.h: Add include guard.
8879         * arm-fbsd-tdep.h: Add include guard.
8880         * arch/xtensa.h: Rename include guard.
8881         * arch/tic6x.h: Add include guard.
8882         * arch/i386.h: Add include guard.
8883         * arch/arm.h: Rename include guard.
8884         * arch/arm-linux.h: Rename include guard.
8885         * arch/arm-get-next-pcs.h: Rename include guard.
8886         * arch/amd64.h: Add include guard.
8887         * arch/aarch64-insn.h: Rename include guard.
8888         * arch-utils.h: Rename include guard.
8889         * annotate.h: Add include guard.
8890         * amd64-darwin-tdep.h: Rename include guard.
8891         * aarch64-linux-tdep.h: Add include guard.
8892         * aarch64-fbsd-tdep.h: Add include guard.
8893         * aarch32-linux-nat.h: Add include guard.
8894
8895 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8896
8897         * macrotab.c (macro_define_internal): New function that
8898         factorizes macro_define_object_internal and macro_define_function
8899         code.
8900         (macro_define_object_internal): Use macro_define_internal.
8901         (macro_define_function): Likewise.
8902
8903 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8904
8905         * macrocmd.c (extract_identifier): Return
8906         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8907         callers.
8908
8909 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8910
8911         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8912
8913 2019-02-05  Tom Tromey  <tom@tromey.com>
8914
8915         * target.c (target_stack::unpush): Move assertion earlier.
8916
8917 2019-01-30  Tom Tromey  <tom@tromey.com>
8918
8919         PR python/23615:
8920         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8921         (gdbpy_parse_and_eval): Likewise.
8922         * python/python-internal.h (gdbpy_allow_threads): New class.
8923
8924 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8925
8926         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8927         (aarch64_fbsd_fpregmap): Move earlier.
8928         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8929         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8930         instead of individual calls to trad_frame_set_reg_addr.
8931         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8932         earlier.
8933         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8934         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8935         instead of individual calls to trad_frame_set_reg_addr.
8936
8937 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8938
8939         * CONTRIBUTE: Replace contribution list with wiki link.
8940
8941 2019-01-25  Tom Tromey  <tom@tromey.com>
8942
8943         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8944
8945 2019-01-25  Tom Tromey  <tom@tromey.com>
8946
8947         * xtensa-linux-nat.c: Fix common/ includes.
8948         * xml-support.h: Fix common/ includes.
8949         * xml-support.c: Fix common/ includes.
8950         * x86-linux-nat.c: Fix common/ includes.
8951         * windows-nat.c: Fix common/ includes.
8952         * varobj.h: Fix common/ includes.
8953         * varobj.c: Fix common/ includes.
8954         * value.c: Fix common/ includes.
8955         * valops.c: Fix common/ includes.
8956         * utils.c: Fix common/ includes.
8957         * unittests/xml-utils-selftests.c: Fix common/ includes.
8958         * unittests/utils-selftests.c: Fix common/ includes.
8959         * unittests/unpack-selftests.c: Fix common/ includes.
8960         * unittests/tracepoint-selftests.c: Fix common/ includes.
8961         * unittests/style-selftests.c: Fix common/ includes.
8962         * unittests/string_view-selftests.c: Fix common/ includes.
8963         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8964         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8965         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8966         * unittests/rsp-low-selftests.c: Fix common/ includes.
8967         * unittests/parse-connection-spec-selftests.c: Fix common/
8968         includes.
8969         * unittests/optional-selftests.c: Fix common/ includes.
8970         * unittests/offset-type-selftests.c: Fix common/ includes.
8971         * unittests/observable-selftests.c: Fix common/ includes.
8972         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8973         * unittests/memrange-selftests.c: Fix common/ includes.
8974         * unittests/memory-map-selftests.c: Fix common/ includes.
8975         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8976         * unittests/function-view-selftests.c: Fix common/ includes.
8977         * unittests/environ-selftests.c: Fix common/ includes.
8978         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8979         * unittests/common-utils-selftests.c: Fix common/ includes.
8980         * unittests/cli-utils-selftests.c: Fix common/ includes.
8981         * unittests/array-view-selftests.c: Fix common/ includes.
8982         * ui-file.c: Fix common/ includes.
8983         * tui/tui-io.c: Fix common/ includes.
8984         * tracepoint.h: Fix common/ includes.
8985         * tracepoint.c: Fix common/ includes.
8986         * tracefile-tfile.c: Fix common/ includes.
8987         * top.h: Fix common/ includes.
8988         * top.c: Fix common/ includes.
8989         * thread.c: Fix common/ includes.
8990         * target/waitstatus.h: Fix common/ includes.
8991         * target/waitstatus.c: Fix common/ includes.
8992         * target.h: Fix common/ includes.
8993         * target.c: Fix common/ includes.
8994         * target-memory.c: Fix common/ includes.
8995         * target-descriptions.c: Fix common/ includes.
8996         * symtab.h: Fix common/ includes.
8997         * symfile.c: Fix common/ includes.
8998         * stap-probe.c: Fix common/ includes.
8999         * spu-linux-nat.c: Fix common/ includes.
9000         * sparc-nat.c: Fix common/ includes.
9001         * source.c: Fix common/ includes.
9002         * solib.c: Fix common/ includes.
9003         * solib-target.c: Fix common/ includes.
9004         * ser-unix.c: Fix common/ includes.
9005         * ser-tcp.c: Fix common/ includes.
9006         * ser-pipe.c: Fix common/ includes.
9007         * ser-base.c: Fix common/ includes.
9008         * selftest-arch.c: Fix common/ includes.
9009         * s12z-tdep.c: Fix common/ includes.
9010         * rust-exp.y: Fix common/ includes.
9011         * rs6000-aix-tdep.c: Fix common/ includes.
9012         * riscv-tdep.c: Fix common/ includes.
9013         * remote.c: Fix common/ includes.
9014         * remote-notif.h: Fix common/ includes.
9015         * remote-fileio.h: Fix common/ includes.
9016         * remote-fileio.c: Fix common/ includes.
9017         * regcache.h: Fix common/ includes.
9018         * regcache.c: Fix common/ includes.
9019         * record-btrace.c: Fix common/ includes.
9020         * python/python.c: Fix common/ includes.
9021         * python/py-type.c: Fix common/ includes.
9022         * python/py-inferior.c: Fix common/ includes.
9023         * progspace.h: Fix common/ includes.
9024         * producer.c: Fix common/ includes.
9025         * procfs.c: Fix common/ includes.
9026         * proc-api.c: Fix common/ includes.
9027         * printcmd.c: Fix common/ includes.
9028         * ppc-linux-nat.c: Fix common/ includes.
9029         * parser-defs.h: Fix common/ includes.
9030         * osdata.c: Fix common/ includes.
9031         * obsd-nat.c: Fix common/ includes.
9032         * nat/x86-linux.c: Fix common/ includes.
9033         * nat/x86-linux-dregs.c: Fix common/ includes.
9034         * nat/x86-dregs.h: Fix common/ includes.
9035         * nat/x86-dregs.c: Fix common/ includes.
9036         * nat/ppc-linux.c: Fix common/ includes.
9037         * nat/mips-linux-watch.h: Fix common/ includes.
9038         * nat/mips-linux-watch.c: Fix common/ includes.
9039         * nat/linux-waitpid.c: Fix common/ includes.
9040         * nat/linux-ptrace.h: Fix common/ includes.
9041         * nat/linux-ptrace.c: Fix common/ includes.
9042         * nat/linux-procfs.c: Fix common/ includes.
9043         * nat/linux-personality.c: Fix common/ includes.
9044         * nat/linux-osdata.c: Fix common/ includes.
9045         * nat/linux-namespaces.c: Fix common/ includes.
9046         * nat/linux-btrace.h: Fix common/ includes.
9047         * nat/linux-btrace.c: Fix common/ includes.
9048         * nat/fork-inferior.c: Fix common/ includes.
9049         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9050         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9051         * nat/aarch64-linux.c: Fix common/ includes.
9052         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9053         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9054         * namespace.h: Fix common/ includes.
9055         * mips-linux-tdep.c: Fix common/ includes.
9056         * minsyms.c: Fix common/ includes.
9057         * mi/mi-parse.h: Fix common/ includes.
9058         * mi/mi-main.c: Fix common/ includes.
9059         * mi/mi-cmd-env.c: Fix common/ includes.
9060         * memrange.h: Fix common/ includes.
9061         * memattr.c: Fix common/ includes.
9062         * maint.h: Fix common/ includes.
9063         * maint.c: Fix common/ includes.
9064         * main.c: Fix common/ includes.
9065         * machoread.c: Fix common/ includes.
9066         * location.c: Fix common/ includes.
9067         * linux-thread-db.c: Fix common/ includes.
9068         * linux-nat.c: Fix common/ includes.
9069         * linux-fork.c: Fix common/ includes.
9070         * inline-frame.c: Fix common/ includes.
9071         * infrun.c: Fix common/ includes.
9072         * inflow.c: Fix common/ includes.
9073         * inferior.h: Fix common/ includes.
9074         * inferior.c: Fix common/ includes.
9075         * infcmd.c: Fix common/ includes.
9076         * inf-ptrace.c: Fix common/ includes.
9077         * inf-child.c: Fix common/ includes.
9078         * ia64-linux-nat.c: Fix common/ includes.
9079         * i387-tdep.c: Fix common/ includes.
9080         * i386-tdep.c: Fix common/ includes.
9081         * i386-linux-tdep.c: Fix common/ includes.
9082         * i386-linux-nat.c: Fix common/ includes.
9083         * i386-go32-tdep.c: Fix common/ includes.
9084         * i386-fbsd-tdep.c: Fix common/ includes.
9085         * i386-fbsd-nat.c: Fix common/ includes.
9086         * guile/scm-type.c: Fix common/ includes.
9087         * guile/guile.c: Fix common/ includes.
9088         * go32-nat.c: Fix common/ includes.
9089         * gnu-nat.c: Fix common/ includes.
9090         * gdbthread.h: Fix common/ includes.
9091         * gdbarch-selftests.c: Fix common/ includes.
9092         * gdb_usleep.c: Fix common/ includes.
9093         * gdb_select.h: Fix common/ includes.
9094         * gdb_bfd.c: Fix common/ includes.
9095         * gcore.c: Fix common/ includes.
9096         * fork-child.c: Fix common/ includes.
9097         * findvar.c: Fix common/ includes.
9098         * fbsd-nat.c: Fix common/ includes.
9099         * event-top.c: Fix common/ includes.
9100         * event-loop.c: Fix common/ includes.
9101         * dwarf2read.c: Fix common/ includes.
9102         * dwarf2loc.c: Fix common/ includes.
9103         * dwarf2-frame.c: Fix common/ includes.
9104         * dwarf-index-cache.c: Fix common/ includes.
9105         * dtrace-probe.c: Fix common/ includes.
9106         * disasm-selftests.c: Fix common/ includes.
9107         * defs.h: Fix common/ includes.
9108         * csky-tdep.c: Fix common/ includes.
9109         * cp-valprint.c: Fix common/ includes.
9110         * cp-support.h: Fix common/ includes.
9111         * cp-support.c: Fix common/ includes.
9112         * corelow.c: Fix common/ includes.
9113         * completer.h: Fix common/ includes.
9114         * completer.c: Fix common/ includes.
9115         * compile/compile.c: Fix common/ includes.
9116         * compile/compile-loc2c.c: Fix common/ includes.
9117         * compile/compile-cplus-types.c: Fix common/ includes.
9118         * compile/compile-cplus-symbols.c: Fix common/ includes.
9119         * command.h: Fix common/ includes.
9120         * cli/cli-dump.c: Fix common/ includes.
9121         * cli/cli-cmds.c: Fix common/ includes.
9122         * charset.c: Fix common/ includes.
9123         * build-id.c: Fix common/ includes.
9124         * btrace.h: Fix common/ includes.
9125         * btrace.c: Fix common/ includes.
9126         * breakpoint.h: Fix common/ includes.
9127         * breakpoint.c: Fix common/ includes.
9128         * ax.h:
9129         (enum agent_op): Fix common/ includes.
9130         * ax-general.c (struct aop_map): Fix common/ includes.
9131         * ax-gdb.c: Fix common/ includes.
9132         * auxv.c: Fix common/ includes.
9133         * auto-load.c: Fix common/ includes.
9134         * arm-tdep.c: Fix common/ includes.
9135         * arch/riscv.c: Fix common/ includes.
9136         * arch/ppc-linux-common.c: Fix common/ includes.
9137         * arch/i386.c: Fix common/ includes.
9138         * arch/arm.c: Fix common/ includes.
9139         * arch/arm-linux.c: Fix common/ includes.
9140         * arch/arm-get-next-pcs.c: Fix common/ includes.
9141         * arch/amd64.c: Fix common/ includes.
9142         * arch/aarch64.c: Fix common/ includes.
9143         * arch/aarch64-insn.c: Fix common/ includes.
9144         * arch-utils.c: Fix common/ includes.
9145         * amd64-windows-tdep.c: Fix common/ includes.
9146         * amd64-tdep.c: Fix common/ includes.
9147         * amd64-sol2-tdep.c: Fix common/ includes.
9148         * amd64-obsd-tdep.c: Fix common/ includes.
9149         * amd64-nbsd-tdep.c: Fix common/ includes.
9150         * amd64-linux-tdep.c: Fix common/ includes.
9151         * amd64-linux-nat.c: Fix common/ includes.
9152         * amd64-fbsd-tdep.c: Fix common/ includes.
9153         * amd64-fbsd-nat.c: Fix common/ includes.
9154         * amd64-dicos-tdep.c: Fix common/ includes.
9155         * amd64-darwin-tdep.c: Fix common/ includes.
9156         * agent.c: Fix common/ includes.
9157         * ada-lang.h: Fix common/ includes.
9158         * ada-lang.c: Fix common/ includes.
9159         * aarch64-tdep.c: Fix common/ includes.
9160
9161 2019-01-25  Tom Tromey  <tom@tromey.com>
9162
9163         * common/create-version.sh: Use common/version.h.
9164
9165 2019-01-24  Pedro Alves  <palves@redhat.com>
9166
9167         * infrun.c (signal_stop, signal_print, signal_program)
9168         (signal_catch, signal_pass): Now arrays instead of pointers.
9169         (update_signals_program_target, do_target_resume)
9170         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9171         * linux-nat.c (linux_nat_target::pass_signals)
9172         (linux_nat_target::create_inferior, linux_nat_target::attach):
9173         Adjust.
9174         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9175         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9176         * procfs.c (procfs_target::pass_signals): Adjust.
9177         * record-full.c (record_full_target::resume): Adjust.
9178         * remote.c (remote_target::pass_signals)
9179         (remote_target::program_signals): Adjust.
9180         * target-debug.h (target_debug_print_signals): Now takes a
9181         gdb::array_view as parameter.  Adjust.
9182         * target.h (target_ops) <pass_signals, program_signals>: Replace
9183         pointer and length parameters with gdb::array_view.
9184         (target_pass_signals, target_program_signals): Likewise.
9185         * target-delegates.c: Regenerate.
9186
9187 2019-01-24  Pedro Alves  <palves@redhat.com>
9188
9189         * common/forward-scope-exit.h
9190         (forward_scope_exit::forward_scope_exit): Pass arguments to
9191         m_bind_function directly, instead of creating a std::bind and
9192         copying that.
9193
9194 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9195
9196         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9197         for static members.
9198         (pass_in_v_vfp_candidate): Likewise.
9199
9200 2019-01-23  Tom Tromey  <tom@tromey.com>
9201             Pedro Alves  <palves@redhat.com>
9202
9203         * regcache.c (class regcache_invalidator): Remove.
9204         (regcache::raw_write): Use make_scope_exit.
9205
9206 2019-01-23  Tom Tromey  <tom@tromey.com>
9207
9208         * ui-out.h (class ui_out_emit_type): Update comment.
9209
9210 2019-01-23  Tom Tromey  <tom@tromey.com>
9211
9212         * infrun.c (fetch_inferior_event): Update comment.
9213
9214 2019-01-23  Tom Tromey  <tom@tromey.com>
9215             Pedro Alves  <palves@redhat.com>
9216
9217         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9218         parameter.
9219         (fetch_inferior_event): Use SCOPE_EXIT.
9220
9221
9222 2019-01-23  Tom Tromey  <tom@tromey.com>
9223             Pedro Alves  <palves@redhat.com>
9224
9225         * infrun.c (disable_thread_events): Delete.
9226         (stop_all_threads): Use SCOPE_EXIT.
9227
9228 2019-01-23  Tom Tromey  <tom@tromey.com>
9229             Pedro Alves  <palves@redhat.com>
9230
9231         * symfile.c: Include forward-scope-exit.h.
9232         (clear_symtab_users_cleanup): Replace forward declaration with
9233         a FORWARD_SCOPE_EXIT.
9234         (syms_from_objfile_1): Use the forward_scope_exit and
9235         gdb::optional instead of cleanup_function.
9236         (reread_symbols): Use the forward_scope_exit instead of
9237         cleanup_function.
9238         (clear_symtab_users_cleanup): Remove function.
9239
9240 2019-01-23  Tom Tromey  <tom@tromey.com>
9241             Pedro Alves  <palves@redhat.com>
9242
9243         * linux-nat.c: Include scope-exit.h.
9244         (cleanup_target_stop): Remove.
9245         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9246         SCOPE_EXIT.
9247
9248 2019-01-23  Tom Tromey  <tom@tromey.com>
9249             Pedro Alves  <palves@redhat.com>
9250
9251         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9252         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9253
9254 2019-01-23  Tom Tromey  <tom@tromey.com>
9255             Andrew Burgess  <andrew.burgess@embecosm.com>
9256             Pedro Alves  <palves@redhat.com>
9257
9258         * infrun.c (fetch_inferior_event): Use scope_exit.
9259         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9260         * top.c (execute_command): Use scope_exit.
9261         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9262         * utils.c (do_bpstat_clear_actions_cleanup)
9263         (make_bpstat_clear_actions_cleanup): Remove.
9264
9265 2019-01-23  Tom Tromey  <tom@tromey.com>
9266             Pedro Alves  <palves@redhat.com>
9267
9268         * infrun.c: Include "common/scope-exit.h"
9269         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9270         (wait_for_inferior): Use SCOPE_EXIT.
9271         (fetch_inferior_event): Use scope_exit.
9272
9273 2019-01-23  Tom Tromey  <tom@tromey.com>
9274             Pedro Alves  <palves@redhat.com>
9275
9276         * breakpoint.c (create_breakpoint): Remove cleanup.
9277
9278 2019-01-23  Tom Tromey  <tom@tromey.com>
9279             Andrew Burgess  <andrew.burgess@embecosm.com>
9280             Pedro Alves  <palves@redhat.com>
9281
9282 2019-01-23  Pedro Alves  <palves@redhat.com>
9283
9284         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9285
9286 2019-01-23  Pedro Alves  <palves@redhat.com>
9287             Andrew Burgess  <andrew.burgess@embecosm.com>
9288
9289         * gdbthread.h: Include "common/forward-scope-exit.h".
9290         (scoped_finish_thread_state): Redefine custom class in terms of
9291         forward_scope_exit.
9292
9293 2019-01-23  Pedro Alves  <palves@redhat.com>
9294             Andrew Burgess  <andrew.burgess@embecosm.com>
9295
9296         * common/forward-scope-exit.h: New file.
9297
9298 2019-01-23  Pedro Alves  <palves@redhat.com>
9299             Andrew Burgess  <andrew.burgess@embecosm.com>
9300             Tom Tromey  <tom@tromey.com>
9301
9302         * common/scope-exit.h: New file.
9303
9304 2019-01-23  Pedro Alves  <palves@redhat.com>
9305
9306         * common/preprocessor.h (ESC): Rename to ...
9307         (ESC_PARENS): ... this.
9308         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9309         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9310
9311 2019-01-23  Tom Tromey  <tom@tromey.com>
9312
9313         * language.h (class scoped_switch_to_sym_language_if_auto):
9314         Initialize m_lang in both cases.
9315
9316 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9317
9318         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9319         with XCNEW.
9320
9321 2019-01-22  Tom Tromey  <tom@tromey.com>
9322
9323         * corelow.c: Do not include sys/file.h.
9324
9325 2019-01-22  Tom Tromey  <tom@tromey.com>
9326
9327         * tui/tui-wingeneral.h: Include gdb_curses.h.
9328
9329 2019-01-22  Tom Tromey  <tom@tromey.com>
9330
9331         * source-cache.h (class source_cache) <get_source_lines,
9332         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9333
9334 2019-01-22  Tom Tromey  <tom@tromey.com>
9335
9336         * remote-fileio.h (struct remote_target): Declare.
9337
9338 2019-01-22  Tom Tromey  <tom@tromey.com>
9339
9340         * python/py-arch.c: Do not include py-ref.h.
9341         * python/py-bpevent.c: Do not include py-ref.h.
9342         * python/py-cmd.c: Do not include py-ref.h.
9343         * python/py-continueevent.c: Do not include py-ref.h.
9344         * python/py-event.h: Do not include py-ref.h.
9345         * python/py-evtregistry.c: Do not include py-ref.h.
9346         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9347         * python/py-frame.c: Do not include py-ref.h.
9348         * python/py-framefilter.c: Do not include py-ref.h.
9349         * python/py-function.c: Do not include py-ref.h.
9350         * python/py-infevents.c: Do not include py-ref.h.
9351         * python/py-linetable.c: Do not include py-ref.h.
9352         * python/py-objfile.c: Do not include py-ref.h.
9353         * python/py-param.c: Do not include py-ref.h.
9354         * python/py-prettyprint.c: Do not include py-ref.h.
9355         * python/py-progspace.c: Do not include py-ref.h.
9356         * python/py-symbol.c: Do not include py-ref.h.
9357         * python/py-symtab.c: Do not include py-ref.h.
9358         * python/py-type.c: Do not include py-ref.h.
9359         * python/py-unwind.c: Do not include py-ref.h.
9360         * python/py-utils.c: Do not include py-ref.h.
9361         * python/py-value.c: Do not include py-ref.h.
9362         * python/py-varobj.c: Do not include py-ref.h.
9363         * python/py-xmethods.c: Do not include py-ref.h.
9364         * python/python.c: Do not include py-ref.h.
9365         * varobj.c: Do not include py-ref.h.
9366
9367 2019-01-22  Tom Tromey  <tom@tromey.com>
9368
9369         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9370         keyword for bcache.
9371
9372 2019-01-22  Tom Tromey  <tom@tromey.com>
9373
9374         * compile/compile-cplus-types.c: Remove a comment by #include.
9375
9376 2019-01-22  Tom Tromey  <tom@tromey.com>
9377
9378         * compile/gcc-c-plugin.h: Include compile-internal.h.
9379
9380 2019-01-22  Tom Tromey  <tom@tromey.com>
9381
9382         * stabsread.c (EXTERN): Do not define.
9383         (symnum, next_symbol_text_func, processing_gcc_compilation)
9384         (within_function, global_sym_chain, global_stabs)
9385         (previous_stab_code, this_object_header_files)
9386         (n_this_object_header_files)
9387         (n_allocated_this_object_header_files): Define.
9388         * stabsread.h (EXTERN): Never define.  Use "extern".
9389
9390 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9391
9392         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9393         history_value.
9394
9395 2019-01-21  Tom Tromey  <tom@tromey.com>
9396
9397         * ui-out.c: Fix includes.
9398         * tui/tui-source.c: Fix includes.
9399         * target.c: Fix includes.
9400         * remote.c: Fix includes.
9401         * regcache.c: Fix includes.
9402         * python/py-block.c: Fix includes.
9403         * printcmd.c: Fix includes.
9404         * or1k-tdep.c: Fix includes.
9405         * mi/mi-main.c: Fix includes.
9406         * m32r-tdep.c: Fix includes.
9407         * csky-tdep.c: Fix includes.
9408         * compile/compile-cplus-types.c: Fix includes.
9409         * cli/cli-interp.c: Fix includes.
9410
9411 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9412
9413         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9414         for padding.
9415
9416 2019-01-16  Tom Tromey  <tom@tromey.com>
9417
9418         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9419         earlier.
9420         (struct objfile) <msymbols_range>: Move from top level.
9421         <msymbols>: New method.
9422         (class objfile_msymbols): Remove.
9423         * symtab.c (default_collect_symbol_completion_matches_break_on):
9424         Update.
9425         * symmisc.c (dump_msymbols): Update.
9426         * stabsread.c (scan_file_globals): Update.
9427         * objc-lang.c (info_selectors_command, info_classes_command)
9428         (find_methods): Update.
9429         * minsyms.c (find_solib_trampoline_target): Update.
9430         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9431         * coffread.c (coff_symfile_read): Update.
9432         * ada-lang.c (ada_lookup_simple_minsym)
9433         (ada_collect_symbol_completion_matches): Update.
9434
9435 2019-01-16  Tom Tromey  <tom@tromey.com>
9436
9437         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9438         type.  Remove no-argument constructor.
9439         <iterator::operator++>: Simplify.
9440         <begin>: Update.
9441         <end>: Use minimal_symbol_count.
9442
9443 2019-01-16  Tom Tromey  <tom@tromey.com>
9444
9445         * objfiles.h (struct objfile) <psymtabs>: New method.
9446         (class objfile_psymtabs): Remove.
9447         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9448         typedef.
9449         <range>: New method.
9450         (require_partial_symbols): Change return type.
9451         * psymtab.c (require_partial_symbols)
9452         (psym_expand_symtabs_matching): Update.
9453         * mdebugread.c (parse_partial_symbols): Update.
9454         * dbxread.c (dbx_end_psymtab): Update.
9455
9456 2019-01-15  Tom Tromey  <tom@tromey.com>
9457
9458         * symtab.c (lookup_objfile_from_block)
9459         (lookup_symbol_in_objfile_symtabs)
9460         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9461         (find_line_symtab, info_sources_command)
9462         (default_collect_symbol_completion_matches_break_on)
9463         (make_source_files_completion_list): Update.
9464         * symmisc.c (print_objfile_statistics, dump_objfile)
9465         (maintenance_print_symbols, maintenance_info_symtabs)
9466         (maintenance_check_symtabs, maintenance_info_line_tables):
9467         Update.
9468         * source.c (select_source_symtab)
9469         (forget_cached_source_info_for_objfile): Update.
9470         * objfiles.h (class objfile_compunits): Remove.
9471         (struct objfile) <compunits_range>: New typedef.
9472         (compunits): New method.
9473         * objfiles.c (objfile_relocate1): Update.
9474         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9475         * maint.c (count_symtabs_and_blocks): Update.
9476         * linespec.c (iterate_over_all_matching_symtabs): Update.
9477         * cp-support.c (add_symbol_overload_list_qualified): Update.
9478         * coffread.c (coff_symtab_read): Update.
9479         * ada-lang.c (add_nonlocal_symbols)
9480         (ada_collect_symbol_completion_matches)
9481         (ada_add_global_exceptions): Update.
9482
9483 2019-01-15  Tom Tromey  <tom@tromey.com>
9484
9485         * progspace.h (program_space) <objfiles_safe_range>: New
9486         typedef.
9487         <objfiles_safe>: New method.
9488         * objfiles.h (class all_objfiles_safe): Remove.
9489         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9490         * jit.c (jit_inferior_exit_hook): Update.
9491
9492 2019-01-17  Tom Tromey  <tom@tromey.com>
9493
9494         * progspace.h (program_space) <objfiles_range>: New typedef.
9495         <objfiles>: New method.
9496         <objfiles_head>: Rename from objfiles.
9497         (object_files): Update.
9498         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9499         * guile/scm-pretty-print.c
9500         (ppscm_find_pretty_printer_from_objfiles): Update.
9501         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9502         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9503         Update.
9504         * python/py-progspace.c (pspy_get_objfiles): Update.
9505         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9506         Update.
9507         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9508         (objfpy_lookup_objfile_by_build_id): Update.
9509         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9510         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9511         Update.
9512         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9513         (expand_symtab_containing_pc, lookup_objfile_from_block)
9514         (lookup_static_symbol, basic_lookup_transparent_type)
9515         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9516         (find_line_symtab, info_sources_command)
9517         (default_collect_symbol_completion_matches_break_on)
9518         (make_source_files_completion_list, find_main_name): Update.
9519         * symmisc.c (print_symbol_bcache_statistics)
9520         (print_objfile_statistics, maintenance_print_symbols)
9521         (maintenance_print_msymbols, maintenance_print_objfiles)
9522         (maintenance_info_symtabs, maintenance_check_symtabs)
9523         (maintenance_expand_symtabs, maintenance_info_line_tables):
9524         Update.
9525         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9526         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9527         (map_overlay_command, unmap_overlay_command)
9528         (simple_overlay_update, expand_symtabs_matching)
9529         (map_symbol_filenames): Update.
9530         * symfile-debug.c (set_debug_symfile): Update.
9531         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9532         Update.
9533         * source.c (select_source_symtab, forget_cached_source_info):
9534         Update.
9535         * solib.c (solib_read_symbols): Update.
9536         * solib-spu.c (append_ocl_sos): Update.
9537         * psymtab.c (maintenance_print_psymbols)
9538         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9539         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9540         * printcmd.c (info_symbol_command): Update.
9541         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9542         Update.
9543         * objfiles.h (class all_objfiles): Remove.
9544         * objfiles.c (have_partial_symbols, have_full_symbols)
9545         (have_minimal_symbols, qsort_cmp, update_section_map)
9546         (shared_objfile_contains_address_p)
9547         (default_iterate_over_objfiles_in_search_order): Update.
9548         * objc-lang.c (info_selectors_command, info_classes_command)
9549         (find_methods): Update.
9550         * minsyms.c (find_solib_trampoline_target): Update.
9551         * maint.c (maintenance_info_sections)
9552         (maintenance_translate_address, count_symtabs_and_blocks):
9553         Update.
9554         * main.c (captured_main_1): Update.
9555         * linux-thread-db.c (try_thread_db_load_from_pdir)
9556         (has_libpthread): Update.
9557         * linespec.c (iterate_over_all_matching_symtabs)
9558         (search_minsyms_for_name): Update.
9559         * jit.c (jit_find_objf_with_entry_addr): Update.
9560         * hppa-tdep.c (find_unwind_entry)
9561         (hppa_lookup_stub_minimal_symbol): Update.
9562         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9563         Update.
9564         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9565         (elf_gnu_ifunc_resolve_by_got): Update.
9566         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9567         * dwarf-index-write.c (save_gdb_index_command): Update.
9568         * cp-support.c (add_symbol_overload_list_qualified): Update.
9569         * breakpoint.c (create_overlay_event_breakpoint)
9570         (create_longjmp_master_breakpoint)
9571         (create_std_terminate_master_breakpoint)
9572         (create_exception_master_breakpoint): Update.
9573         * blockframe.c (find_pc_partial_function): Update.
9574         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9575         (ada_collect_symbol_completion_matches)
9576         (ada_add_global_exceptions): Update.
9577
9578 2019-01-17  Tom Tromey  <tom@tromey.com>
9579
9580         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9581         declare VEC.
9582         (solib_target_parse_libraries): Change return type.
9583         (library_list_start_segment, library_list_start_section)
9584         (library_list_end_library, library_list_start_library); Update.
9585         (solib_target_free_library_list): Remove.
9586         (solib_target_parse_libraries): Remove cleanup.  Change return
9587         type.
9588         (solib_target_current_sos): Update.
9589
9590 2019-01-17  Tom Tromey  <tromey@bapiya>
9591
9592         * valprint.c: Replace "the the" with "the".
9593         * symtab.c: Replace "the the" with "the".
9594         * solib.c: Replace "the the" with "the".
9595         * solib-dsbt.c: Replace "the the" with "the".
9596         * linespec.c: Replace "the the" with "the".
9597         * dwarf2loc.h: Replace "the the" with "the".
9598         * amd64-windows-tdep.c: Replace "the the" with "the".
9599         * aarch64-tdep.c: Replace "the the" with "the".
9600
9601 2019-01-16  Keith Seitz  <keiths@redhat.com>
9602
9603         PR gdb/23773
9604         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9605         <builder>: Rename to ..
9606         <m_builder>: ... this and make private.
9607         (dwarf2_cu::get_builder): New method.  Change all users of
9608         `builder' to use this method.
9609         (dwarf2_start_symtab): Move to ...
9610         (dwarf2_cu::start_symtab): ... here.  Update all callers
9611         (setup_type_unit_groups): Move to ...
9612         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9613         callers.
9614         (dwarf2_cu::reset_builder): New method.
9615         (process_full_compunit, process_full_type_unit): Use
9616         dwarf2_cu::reset_builder.
9617         (follow_die_offset): Record the ancestor CU if it is different
9618         from the followed DIE's CU.
9619         (follow_die_sig_1): Likewise.
9620
9621 2019-01-15  Tom Tromey  <tom@tromey.com>
9622
9623         * remote.c (class remote_state) <buf>: Now a char_vector.
9624         <buf_size>: Remove.
9625         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9626         parameter.
9627         (remote_target::getpkt_or_notif_sane_1)
9628         (remote_target::getpkt_sane)
9629         (remote_target::getpkt_or_notif_sane): Likewise.
9630         (class remote_target) <putpkt>: New overload.
9631         (remote_target::read_frame): Change type of "buf_p".  Remove
9632         sizeof_p parameter.
9633         (packet_ok): New overload.
9634         (packet_check_result): New overload.
9635         Update all uses.
9636
9637 2019-01-14  Tom Tromey  <tom@tromey.com>
9638
9639         * remote-notif.c (handle_notification, remote_notif_ack)
9640         (remote_notif_parse): Make "buf" const.
9641         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9642         const.
9643         (remote_notif_parse, remote_notif_ack, handle_notification):
9644         Likewise.
9645         * remote.c (remote_notif_stop_parse): Make "buf" const.
9646         (remote_target::remote_parse_stop_reply): Make "buf" const.
9647         (remote_notif_stop_ack): Make "buf" const.
9648
9649 2019-01-14  Tom Tromey  <tom@tromey.com>
9650
9651         * remote.c (remote_console_output): Make parameter const.
9652
9653 2019-01-14  Tom Tromey  <tom@tromey.com>
9654
9655         * target-debug.h (target_debug_print_signals): Constify.
9656         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9657         * procfs.c (procfs_target::pass_signals): Update.
9658         * linux-nat.c (linux_nat_target::pass_signals): Update.
9659         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9660         * target-delegates.c: Rebuild.
9661         * remote.c (remote_target::program_signals): Update.
9662         (remote_target::pass_signals): Update.
9663         * target.c (target_pass_signals): Constify argument.
9664         (target_program_signals): Likewise.
9665         * target.h (struct target_ops) <pass_signals, program_signals>:
9666         Constify argument.
9667         (target_pass_signals, target_program_signals): Constify argument.
9668
9669 2019-01-14  Tom Tromey  <tom@tromey.com>
9670
9671         PR tui/28819:
9672         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9673
9674 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9675
9676         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9677         field.
9678         * rs6000-tdep.c: Include reggroups.h.
9679         (IS_V_ALIAS_PSEUDOREG): Define.
9680         (rs6000_register_name): Return names for the "vX" aliases.
9681         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9682         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9683         aliases.  Call default_register_reggroup_p for all other
9684         pseudo-registers.
9685         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9686         New functions.
9687         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9688         Handle "vX" aliases.
9689         (v_alias_pseudo_register_collect): New function.
9690         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9691         (rs6000_gdbarch_init): Initialize "vX" aliases as
9692         pseudo-registers.  Restore registration of
9693         rs6000_pseudo_register_reggroup_p with
9694         set_tdesc_pseudo_register_reggroup_p.
9695
9696 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9697
9698         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9699         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9700         set_gdbarch_num_pseudo_regs.
9701
9702 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9703
9704         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9705         Remove arg prefixname, add do_set and do_show.
9706         Add member functions set_list and show_list.
9707         * cli/cli-style.c (class cli_style_option): Update accordingly.
9708         (style_set_list): Move to file scope.
9709         (style_show_list): Likewise.
9710         (set_style): Call help_list.
9711         (show_style): Call cmd_show_list.
9712         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9713         Update to use the new macro.
9714
9715 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9716
9717         * ada-lang.c (_initialize_ada_language): Expand the help text
9718         for the "catch exception" command.
9719
9720 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9721
9722         * symtab.c (matching_obj_sections): Initialize obj,
9723         declare it closer to its usage.
9724
9725 2019-01-10  Tom Tromey  <tom@tromey.com>
9726
9727         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9728         (basic_inf_threads_range): Remove.
9729         (inf_threads_range, inf_non_exited_threads_range)
9730         (safe_inf_threads_range): Use next_adapter.
9731
9732 2019-01-10  Keith Seitz  <keiths@redhat.com>
9733
9734         PR gdb/23712
9735         PR symtab/23010
9736         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9737         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9738
9739 2019-01-10  Keith Seitz  <keiths@redhat.com>
9740
9741         PR gdb/23712
9742         PR symtab/23010
9743         * dictionary.c (pending_to_vector): Remove.
9744         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9745         Remove _1 suffix, replacing functions of the same name.  Update
9746         all callers.
9747         (dict_create_hashed, dict_create_hashed_expandable)
9748         (dict_create_linear, dict_create_linear_expandable, dict_free)
9749         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9750         Make functions static.
9751
9752 2019-01-10  Keith Seitz  <keiths@redhat.com>
9753
9754         PR gdb/23712
9755         PR symtab/23010
9756         * dictionary.h (struct dictionary): Replace declaration with
9757         multidictionary.
9758         (dict_create_hashed, dict_create_hashed_expandable)
9759         (dict_create_linear, dict_create_linear_expandable)
9760         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9761         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9762         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9763         taking multidictionary argument.
9764         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9765         * block.h (struct block) <dict>: Change to multidictionary
9766         and rename `multidict'.
9767         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9768         symmisc.c: Update all dictionary references to multidictionary.
9769
9770 2019-01-10  Keith Seitz  <keiths@redhat.com>
9771
9772         PR gdb/23712
9773         PR symtab/23010
9774         * dictionary.c: Include unordered_map.
9775         (pending_to_vector): New function.
9776         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9777         Rewrite the non-"_1" functions to take vector instead
9778         of linked list.
9779         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9780         "new" _1 versions of the same name.
9781         (multidictionary): Define.
9782         (std::hash<enum language): New definition.
9783         (collate_pending_symbols_by_language, mdict_create_hashed)
9784         (mdict_create_hashed_expandable, mdict_create_linear)
9785         (mdict_create_linear_expandable, mdict_free)
9786         (find_language_dictionary, create_new_language_dictionary)
9787         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9788         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9789         (mdict_size, mdict_empty): New functions.
9790         * dictionary.h (mdict_iterator): Define.
9791
9792 2019-01-10  Pedro Alves  <palves@redhat.com>
9793
9794         * breakpoint.c (read_uploaded_action)
9795         (create_tracepoint_from_upload): Adjust to use
9796         gdb::unique_xmalloc_ptr.
9797         * ctf.c (ctf_write_uploaded_tp):
9798         (SET_ARRAY_FIELD): Use emplace_back.
9799         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9800         * tracefile-tfile.c (tfile_write_uploaded_tp):
9801         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9802         gdb::unique_xmalloc_ptr.
9803         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9804         at_string, cond_string, cmd_strings>: Replace char pointers
9805         with gdb::unique_xmalloc_ptr.
9806
9807 2019-01-10  Pedro Alves  <palves@redhat.com>
9808
9809         * solib-target.c (library_list_start_library): Don't xstrdup name.
9810
9811 2019-01-10  Pedro Alves  <palves@redhat.com>
9812
9813         * mdebugread.c (parse_partial_symbols): Use
9814         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9815
9816 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9817
9818         * linux-fork.c (scoped_switch_fork_info)
9819         <~scoped_switch_fork_info>: Fix incorrect variable name.
9820
9821 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9822
9823         * linux-fork.c (scoped_switch_fork_info)
9824         <scoped_switch_fork_info>: Make explicit.
9825         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9826
9827 2019-01-10  Tom Tromey  <tom@tromey.com>
9828
9829         * objfiles.h (objfile::reset_psymtabs): Update.
9830         * objfiles.c (objfile::objfile): Update.
9831         * psymtab.h (psymtab_storage::obstack): Update.
9832         (psymtab_storage::m_obstack): Use gdb::optional.
9833         (class psymtab_storage): Update comment.  Remove objfile
9834         parameter.
9835         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9836
9837 2019-01-10  Tom Tromey  <tom@tromey.com>
9838
9839         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9840         <free_psymtabs>: Now private.
9841         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9842         (allocate_psymtab): Use new method.
9843
9844 2019-01-10  Tom Tromey  <tom@tromey.com>
9845
9846         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9847         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9848         * mdebugread.c (parse_partial_symbols): Use
9849         allocate_dependencies.
9850         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9851         allocate_dependencies.
9852         (process_psymtab_comp_unit_reader)
9853         (build_type_psymtab_dependencies): Likewise.
9854         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9855
9856 2019-01-10  Tom Tromey  <tom@tromey.com>
9857
9858         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9859         PSYMBOL_SET_LANGUAGE.
9860         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9861
9862 2019-01-10  Tom Tromey  <tom@tromey.com>
9863
9864         * psymtab.h (psymtab_storage::obstack): New method.
9865         <m_obstack>: Rename from obstack; now private.
9866         * psymtab.c (psymtab_storage): Update.
9867         * dwarf2read.c (create_addrmap_from_index)
9868         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9869         Update.
9870
9871 2019-01-10  Tom Tromey  <tom@tromey.com>
9872
9873         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9874         * objfiles.h (objfile::reset_psymtabs): New method.
9875
9876 2019-01-10  Tom Tromey  <tom@tromey.com>
9877
9878         * symmisc.c (print_symbol_bcache_statistics): Update.
9879         (print_objfile_statistics): Update.
9880         * symfile.c (reread_symbols): Update.
9881         * psymtab.h (class psymtab_storage): New.
9882         * psymtab.c (psymtab_storage): New constructor.
9883         (~psymtab_storage): New destructor.
9884         (require_partial_symbols): Update.
9885         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9886         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9887         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9888         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9889         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9890         (start_psymtab_common, end_psymtab_common)
9891         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9892         (allocate_psymtab): Update.
9893         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9894         Update.
9895         (dump_psymtab_addrmap, maintenance_print_psymbols)
9896         (maintenance_check_psymtabs): Update.
9897         (class objfile_psymtabs): Move to objfiles.h.
9898         * psympriv.h (discard_psymtab): Now inline.
9899         (psymtab_discarder::psymtab_discarder): Update.
9900         (psymtab_discarder::~psymtab_discarder): Update.
9901         (ALL_OBJFILE_PSYMTABS): Rewrite.
9902         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9903         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9904         Remove fields.
9905         <partial_symtabs>: New field.
9906         (class objfile_psymtabs): Move from psymtab.h.  Update.
9907         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9908         psymbol_cache.
9909         (objfile::~objfile): Don't destroy psymbol_cache.
9910         * mdebugread.c (parse_partial_symbols): Update.
9911         * dwarf2read.c (create_addrmap_from_index)
9912         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9913         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9914         (add_partial_subprogram, dwarf2_ranges_read): Update.
9915         * dwarf-index-write.c (write_address_map)
9916         (write_one_signatured_type, recursively_write_psymbols)
9917         (class debug_names, class debug_names, write_psymtabs_to_index):
9918         Update.
9919
9920 2019-01-10  Tom Tromey  <tom@tromey.com>
9921
9922         * symtab.h (SYMBOL_SET_NAMES): Update.
9923         (symbol_set_names): Update.
9924         (MSYMBOL_SET_NAMES): Update.
9925         * symtab.c (symbol_set_names): Change argument to be an
9926         objfile_per_bfd_storage.
9927         * psymtab.c (add_psymbol_to_bcache): Update.
9928         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9929
9930 2019-01-10  Tom Tromey  <tom@tromey.com>
9931
9932         * symtab.c (create_demangled_names_hash): Change argument to be an
9933         objfile_per_bfd_storage.
9934         (symbol_set_names): Update.
9935
9936 2019-01-10  Tom Tromey  <tom@tromey.com>
9937
9938         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9939         init_psymbol_list.
9940         * psymtab.c (init_psymbol_list): Do nothing if already called.
9941         * psympriv.h (init_psymbol_list): Add comment.
9942         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9943         init_psymbol_list.
9944         * dbxread.c (dbx_symfile_read): Unconditionally call
9945         init_psymbol_list.
9946
9947 2019-01-10  Tom Tromey  <tom@tromey.com>
9948
9949         * xcoffread.c (scan_xcoff_symtab): Update.
9950         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9951         "where".
9952         * mdebugread.c (parse_partial_symbols)
9953         (handle_psymbol_enumerators): Update.
9954         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9955         * dbxread.c (read_dbx_symtab): Update.
9956         * psympriv.h (psymbol_placement): New enum.
9957         (add_psymbol_to_list): Update.
9958
9959 2019-01-10  Tom Tromey  <tom@tromey.com>
9960
9961         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9962         static_psymbols parameters.
9963         (scan_xcoff_symtab): Update.
9964         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9965         static_psymbols parameters.
9966         * psympriv.h (start_psymtab_common): Update.
9967         * mdebugread.c (parse_partial_symbols): Update.
9968         * dwarf2read.c (create_partial_symtab): Update.
9969         * dbxread.c (read_dbx_symtab): Update.
9970         (start_psymtab): Remove global_psymbols and static_psymbols
9971         parameters.
9972
9973 2019-01-10  Tom Tromey  <tom@tromey.com>
9974
9975         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9976         * psymtab.c (allocate_psymtab): Add comment.
9977         * psympriv.h (allocate_psymtab): Add comment.
9978         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9979         initializations.
9980         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9981
9982 2019-01-10  Tom Tromey  <tom@tromey.com>
9983
9984         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9985         Don't declare.
9986         * mipsread.c: Include mdebugread.h.
9987         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9988         Declare.
9989         * elfread.c: Include mdebugread.h.
9990
9991 2019-01-09  Tom Tromey  <tom@tromey.com>
9992
9993         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9994         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9995         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9996         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9997         (psym_lookup_symbol, psym_find_last_source_symtab)
9998         (psym_forget_cached_source_info, psym_print_stats)
9999         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10000         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10001         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10002         (psym_find_compunit_symtab_by_address)
10003         (maintenance_print_psymbols, maintenance_info_psymtabs)
10004         (maintenance_check_psymtabs): Use ranged for.
10005         * psymtab.h (class objfile_psymtabs): New.
10006         (require_partial_symbols): Return objfile_psymtabs.
10007         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10008
10009 2019-01-09  Tom Tromey  <tom@tromey.com>
10010
10011         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10012         (find_pc_mapped_section, list_overlays_command)
10013         (map_overlay_command, unmap_overlay_command)
10014         (simple_overlay_update): Use all_objfiles.
10015         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10016         * printcmd.c (info_symbol_command): Use all_objfiles.
10017         * objfiles.h (ALL_OBJSECTIONS): Remove.
10018         * maint.c (maintenance_translate_address): Use all_objfiles.
10019         * gcore.c (gcore_create_callback): Use all_objfiles.
10020         (objfile_find_memory_regions): Likewise.
10021
10022 2019-01-09  Tom Tromey  <tom@tromey.com>
10023
10024         * symtab.c (find_line_symtab, info_sources_command)
10025         (make_source_files_completion_list): Use objfile_compunits.
10026         * source.c (select_source_symtab): Use objfile_compunits.
10027         * objfiles.h (struct objfile): Update comment.
10028         (ALL_OBJFILES): Remove.
10029         (ALL_FILETABS): Remove.
10030         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10031         objfile_compunits.
10032
10033 2019-01-09  Tom Tromey  <tom@tromey.com>
10034
10035         * symmisc.c (print_objfile_statistics, dump_objfile)
10036         (maintenance_print_symbols): Use compunit_filetabs.
10037         * source.c (forget_cached_source_info_for_objfile): Use
10038         compunit_filetabs.
10039         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10040         (ALL_FILETABS): Use compunit_filetabs.
10041         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10042         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10043
10044 2019-01-09  Tom Tromey  <tom@tromey.com>
10045
10046         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10047         (compunit_filetabs): New.
10048         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10049         compunit_filetabs.
10050         (info_sources_command, make_source_files_completion_list): Remove
10051         declaration.
10052         * symmisc.c (print_objfile_statistics, dump_objfile)
10053         (maintenance_print_symbols): Remove declaration.
10054         (maintenance_info_symtabs): Use compunit_filetabs.
10055         (maintenance_info_line_tables): Likewise.
10056         * source.c (select_source_symtab): Change local variable name.
10057         (forget_cached_source_info_for_objfile): Remove declaration.
10058         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10059         * objfiles.c (objfile_relocate1): Remove declaration.
10060         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10061         declaration.
10062         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10063         * coffread.c (coff_symtab_read): Remove declaration.
10064         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10065         compunit_filetabs.
10066
10067 2019-01-09  Tom Tromey  <tom@tromey.com>
10068
10069         * symtab.c (lookup_objfile_from_block)
10070         (find_pc_sect_compunit_symtab, search_symbols)
10071         (default_collect_symbol_completion_matches_break_on): Use
10072         objfile_compunits.
10073         * objfiles.h (ALL_COMPUNITS): Remove.
10074         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10075         * cp-support.c (add_symbol_overload_list_qualified): Use
10076         objfile_compunits.
10077         * ada-lang.c (ada_collect_symbol_completion_matches)
10078         (ada_add_global_exceptions): Use objfile_compunits.
10079
10080 2019-01-09  Tom Tromey  <tom@tromey.com>
10081
10082         * source.c (select_source_symtab)
10083         (forget_cached_source_info_for_objfile): Remove declaration.
10084         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10085         declaration.
10086         * maint.c (count_symtabs_and_blocks): Remove declaration.
10087         * cp-support.c (add_symbol_overload_list_qualified): Remove
10088         declaration.
10089         * coffread.c (coff_symtab_read): Remove declaration.
10090         * symtab.c (lookup_symbol_in_objfile_symtabs)
10091         (basic_lookup_transparent_type_1): Use objfile_compunits.
10092         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10093         (info_sources_command, search_symbols)
10094         (default_collect_symbol_completion_matches_break_on)
10095         (make_source_files_completion_list): Remove declaration.
10096         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10097         (ada_collect_symbol_completion_matches)
10098         (ada_add_global_exceptions): Remove declaration.
10099         * linespec.c (iterate_over_all_matching_symtabs): Use
10100         objfile_compunits.
10101         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10102         (class objfile_compunits): New.
10103         (ALL_COMPUNITS): Use objfile_compunits.
10104         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10105         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10106         objfile_compunits.
10107         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10108
10109 2019-01-09  Tom Tromey  <tom@tromey.com>
10110
10111         * symtab.c (search_symbols)
10112         (default_collect_symbol_completion_matches_break_on): Use
10113         objfile_msymbols.
10114         * ada-lang.c (ada_lookup_simple_minsym)
10115         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10116         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10117         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10118         objfile_msymbols.
10119         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10120         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10121         * objc-lang.c (find_methods): Use objfile_msymbols.
10122         (info_selectors_command, info_classes_command): Likewise.
10123         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10124         * objfiles.h (class objfile_msymbols): New.
10125         (ALL_OBJFILE_MSYMBOLS): Remove.
10126         (ALL_MSYMBOLS): Remove.
10127
10128 2019-01-09  Tom Tromey  <tom@tromey.com>
10129
10130         * common/next-iterator.h (next_adapter): Add Iterator template
10131         parameter.
10132         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10133         (class all_objfiles_safe): New.
10134         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10135         * objfiles.c (put_objfile_before): Update comment.
10136         (add_separate_debug_objfile): Likewise.
10137         (free_all_objfiles): Use all_objfiles_safe.
10138         (objfile_purge_solibs): Likewise.
10139
10140 2019-01-09  Tom Tromey  <tom@tromey.com>
10141
10142         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10143         (expand_symtab_containing_pc, lookup_static_symbol)
10144         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10145         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10146         all_objfiles.
10147         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10148         * breakpoint.c (create_overlay_event_breakpoint)
10149         (create_longjmp_master_breakpoint)
10150         (create_std_terminate_master_breakpoint)
10151         (create_exception_master_breakpoint): Use all_objfiles.
10152         * linux-thread-db.c (try_thread_db_load_from_pdir)
10153         (has_libpthread): Use all_objfiles.
10154         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10155         * linespec.c (iterate_over_all_matching_symtabs)
10156         (search_minsyms_for_name): Use all_objfiles.
10157         * maint.c (maintenance_info_sections): Use all_objfiles.
10158         * main.c (captured_main_1): Use all_objfiles.
10159         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10160         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10161         * guile/scm-pretty-print.c
10162         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10163         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10164         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10165         (maintenance_print_msymbols): Use all_objfiles.
10166         * source.c (select_source_symtab): Use all_objfiles.
10167         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10168         * symfile.c (remove_symbol_file_command)
10169         (expand_symtabs_matching, map_symbol_filenames): Use
10170         all_objfiles.
10171         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10172         all_objfiles.
10173         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10174         * objc-lang.c (find_methods): Use all_objfiles.
10175         * objfiles.c (have_partial_symbols, have_full_symbols)
10176         (have_minimal_symbols, qsort_cmp)
10177         (default_iterate_over_objfiles_in_search_order): Use
10178         all_objfiles.
10179         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10180         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10181         (maintenance_check_psymtabs): Use all_objfiles.
10182         (ALL_PSYMTABS): Remove.
10183         * compile/compile-object-run.c (do_module_cleanup): Use
10184         all_objfiles.
10185         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10186         * cp-support.c (add_symbol_overload_list_qualified): Use
10187         all_objfiles.
10188         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10189         Use all_objfiles.
10190         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10191         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10192         all_objfiles.
10193         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10194         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10195         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10196         Uses all_objfiles.
10197         * solib.c (solib_read_symbols): Use all_objfiles
10198
10199 2019-01-09  Tom Tromey  <tom@tromey.com>
10200
10201         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10202         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10203         all_objfiles.
10204         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10205         * symmisc.c (print_symbol_bcache_statistics)
10206         (print_objfile_statistics, maintenance_print_objfiles)
10207         (maintenance_info_symtabs, maintenance_check_symtabs)
10208         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10209         all_objfiles.
10210         * source.c (forget_cached_source_info): Use all_objfiles.
10211         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10212         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10213         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10214         * objfiles.c (update_section_map): Use all_objfiles.
10215         (shared_objfile_contains_address_p): Likewise.
10216         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10217         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10218
10219 2019-01-09  Tom Tromey  <tom@tromey.com>
10220
10221         * common/next-iterator.h: New file.
10222         * objfiles.h (class all_objfiles): New.
10223         (struct objfile_iterator): New.
10224
10225 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10226
10227         * NEWS: Move the description of the changed "frame", "select-frame",
10228          and "info frame" commands to the Changed commands section.
10229
10230 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10231
10232         * gdbtypes.c (check_stub_method_group): Remove handling of old
10233         mangling schemes.
10234         * linespec.c (find_methods): Likewise.
10235         * stabsread.c (read_member_functions): Likewise.
10236         * valops.c (search_struct_method): Likewise.
10237         (value_struct_elt_for_reference): Likewise.
10238         * NEWS: Mention this change.
10239
10240 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10241
10242         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10243         print_source_lines.
10244         * source.c (print_source_lines_base): Update line number check.
10245         (print_source_lines): New function.
10246         (source_lines_range::source_lines_range): New function.
10247         * source.h (class source_lines_range): New class.
10248         (print_source_lines): New declaration.
10249
10250 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10251
10252         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10253
10254 2019-01-08  Tom Tromey  <tom@tromey.com>
10255             Simon Marchi  <simon.marchi@ericsson.com>
10256
10257         PR gdb/24060
10258         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10259         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10260         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10261         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10262         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10263         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10264
10265 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10266
10267         * source.c (select_source_symtab): Move header comment to
10268         declaration in source.h.
10269         (forget_cached_source_info_for_objfile): Likewise.
10270         (forget_cached_source_info): Likewise.
10271         (identify_source_line): Likewise.
10272         * source.h (identify_source_line): Move declaration from symtab.h
10273         and add comment from source.c
10274         (print_source_lines): Likewise.
10275         (forget_cached_source_info_for_objfile): Likewise.
10276         (forget_cached_source_info): Likewise.
10277         (select_source_symtab): Likewise.
10278         (enum print_source_lines_flag): Move definition from symtab.h.
10279         * symtab.h (identify_source_line): Move declaration to source.h.
10280         (print_source_lines): Likewise.
10281         (forget_cached_source_info_for_objfile): Likewise.
10282         (forget_cached_source_info): Likewise.
10283         (select_source_symtab): Likewise.
10284         (enum print_source_lines_flag): Move definition to source.h.
10285         * tui/tui-hooks.c: Add 'source.h' include.
10286
10287 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10288
10289         * source.c (print_source_lines_base): Handle requests to print
10290         reverse line number sequences, and guard against empty lines
10291         string.
10292
10293 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10294
10295         * source.c (print_source_lines_base): Fix skip of '\r' if next
10296         character is '\n'.
10297
10298 2019-01-06  Tom Tromey  <tom@tromey.com>
10299
10300         * c-exp.y (struct c_parse_state) <macro_original_text,
10301         expansion_obstack>: New member.
10302         (macro_original_text, expansion_obstack): Remove globals.
10303         (scan_macro_expansion, scanning_macro_expansion)
10304         (finished_macro_expansion): Update.
10305         (scan_macro_cleanup): Remove.
10306         (yylex, c_parse): Update.
10307
10308 2019-01-06  Tom Tromey  <tom@tromey.com>
10309
10310         * c-exp.y (struct c_parse_state) <strings>: New member.
10311         (operator_stoken): Update.
10312
10313 2019-01-06  Tom Tromey  <tom@tromey.com>
10314
10315         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10316         (union type_stack_elt) <typelist_val>: Now a pointer to
10317         std::vector.
10318         (type_stack_cleanup): Don't declare.
10319         (push_typelist): Update.
10320         * parse.c (pop_typelist): Return a std::vector.
10321         (push_typelist): Take a std::vector.
10322         (follow_types): Update.  Do not free args.
10323         (type_stack_cleanup): Remove.
10324         * c-exp.y (struct c_parse_state): New.
10325         (cpstate): New global.
10326         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10327         (nonempty_typelist): Update.
10328         (func_mod): Create a new vector.
10329         (c_parse): Create a c_parse_state.
10330         (check_parameter_typelist): Do not delete params.
10331         (function_method): Update.  Do not delete type_list.
10332
10333 2019-01-06  Tom Tromey  <tom@tromey.com>
10334
10335         PR gdb/28155:
10336         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10337         check_typedef.
10338         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10339         (print_return_value): Likewise.
10340
10341 2019-01-05  Tom Tromey  <tom@tromey.com>
10342
10343         * contrib/cleanup_check.py: Remove.
10344         * contrib/gcc-with-excheck: Remove.
10345         * contrib/exsummary.py: Remove.
10346         * contrib/excheck.py: Remove.
10347
10348 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10349
10350         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10351         NULL. Initialize tpprev to NULL instead of assigning it
10352         to NULL on the next statement.
10353         * windows-nat.c (windows_delete_thread): Remove check for
10354         main_thread_id before printing thread exit notifications.
10355         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10356         Remove thread ID check against main_thread_id.
10357         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10358         windows_delete_thread.
10359         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10360
10361 2019-01-04  Tom Tromey  <tom@tromey.com>
10362
10363         * compile/compile.c (_initialize_compile): Use upper case for
10364         metasyntactic variables.
10365         * symmisc.c (_initialize_symmisc): Use upper case for
10366         metasyntactic variables.
10367         * psymtab.c (_initialize_psymtab): Use upper case for
10368         metasyntactic variables.
10369         * demangle.c (demangle_command): Use upper case for metasyntactic
10370         variables.
10371         (_initialize_demangler): Likewise.
10372         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10373         variables.
10374
10375 2019-01-03  Tom Tromey  <tom@tromey.com>
10376
10377         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10378
10379 2019-01-03  Tom Tromey  <tom@tromey.com>
10380
10381         * python/py-symtab.c (salpy_str): Update.
10382         (struct salpy_sal_object) <symtab>: Now a PyObject.
10383         (salpy_dealloc): Update.
10384         (del_objfile_sal): Use gdbpy_ref.
10385
10386 2019-01-03  Tom Tromey  <tom@tromey.com>
10387
10388         * python/py-type.c (convert_field): Use new_reference.  Return
10389         gdbpy_ref.
10390         (make_fielditem): Return gdbpy_ref.
10391         (typy_fields): Update.
10392         (typy_getitem): Update.
10393         (field_name): Return gdbpy_ref.  Use new_reference.
10394         (typy_iterator_iternext): Update.
10395
10396 2019-01-03  Tom Tromey  <tom@tromey.com>
10397
10398         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10399
10400 2019-01-03  Tom Tromey  <tom@tromey.com>
10401
10402         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10403         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10404         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10405         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10406         (pspy_set_type_printers): Likewise.
10407         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10408         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10409         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10410         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10411         (objfpy_set_type_printers): Likewise.
10412
10413 2019-01-03  Tom Tromey  <tom@tromey.com>
10414
10415         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10416         (gdbpy_print_stack): Use gdbpy_err_fetch.
10417         * python/python-internal.h (class gdbpy_err_fetch): New class.
10418         (class gdbpy_enter) <m_error_type, m_error_value,
10419         m_error_traceback>: Remove.
10420         <m_error>: New member.
10421         (gdbpy_exception_to_string): Don't declare.
10422         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10423         * python/py-value.c (convert_value_from_python): Use
10424         gdbpy_err_fetch.
10425         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10426         gdbpy_exception_to_string.
10427         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10428         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10429         gdbpy_err_fetch.
10430
10431 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10432
10433         * linux-nat.c (delete_lwp_cleanup): Delete.
10434         (struct lwp_deleter): New struct.
10435         (lwp_info_up): New typedef.
10436         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10437         lwp_info_up.
10438
10439 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10440
10441         * linux-fork.c (class scoped_switch_fork_info): New class.
10442         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10443
10444 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10445
10446         * valops.c (find_overload_match): Remove use of null_cleanup, and
10447         calls to do_cleanups.
10448
10449 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10450
10451         * compile/compile-cplus-types.c
10452         (compile_cplus_instance::decl_name): Handle changes to
10453         cp_func_name.
10454         * cp-support.c (cp_func_name): Update header comment, update
10455         return type.
10456         * cp-support.h (cp_func_name): Update return type in declaration.
10457         * valops.c (find_overload_match): Move temp_func local to top
10458         level of function and change its type.  Use temp_func to hold and
10459         delete temporary string obtained from cp_func_name.
10460
10461 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10462
10463         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10464         gdb::char_vector, remove cleanup, and update uses of `msg`.
10465
10466 2019-01-03  Jim Wilson  <jimw@sifive.com>
10467
10468         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10469
10470 2019-01-02  Tom Tromey  <tom@tromey.com>
10471
10472         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10473         (tdesc_parse_xml): Remove cleanups.
10474         * target-descriptions.h (make_cleanup_free_target_description):
10475         Don't declare.
10476         (target_desc_deleter): New struct.
10477         (target_desc_up): New typedef.
10478         * target-descriptions.c (target_desc_deleter::operator()): Rename
10479         from free_target_description.
10480         (make_cleanup_free_target_description): Remove.
10481
10482 2019-01-02  Tom Tromey  <tom@tromey.com>
10483
10484         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10485         constructor, destructor.
10486         (linespec_parser): Remove typedef.
10487         (~linespec_parser): Rename from linespec_parser_delete.
10488         (linespec_lex_to_end, linespec_complete_label)
10489         (linespec_complete): Update.
10490         (decode_line_full): Remove cleanups.
10491         (decode_line_1): Update.
10492
10493 2019-01-02  Tom Tromey  <tom@tromey.com>
10494
10495         * python/python-internal.h (inferior_to_inferior_object): Change
10496         return type.
10497         * python/py-exitedevent.c (create_exited_event_object): Update.
10498         * python/py-inferior.c (inferior_to_inferior_object): Return
10499         gdbpy_ref.
10500         (python_new_inferior, python_inferior_deleted)
10501         (thread_to_thread_object, delete_thread_object)
10502         (build_inferior_list, gdbpy_selected_inferior): Update.
10503         * python/py-infthread.c (create_thread_object): Update.  Also fail
10504         if inferior_to_inferior_object fails.
10505
10506 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10507
10508         * inferior.h (class inferior) <displaced_step_state>: New field.
10509         * infrun.h (struct displaced_step_state): Move here from
10510         infrun.c.  Initialize fields, add constructor.
10511         <inf>: Remove field.
10512         <reset>: New method.
10513         * infrun.c (struct displaced_step_inferior_state): Move to
10514         infrun.h.
10515         (displaced_step_inferior_states): Remove.
10516         (get_displaced_stepping_state): Adust.
10517         (displaced_step_in_progress_any_inferior): Adjust.
10518         (displaced_step_in_progress_thread): Adjust.
10519         (displaced_step_in_progress): Adjust.
10520         (add_displaced_stepping_state): Remove.
10521         (get_displaced_step_closure_by_addr): Adjust.
10522         (remove_displaced_stepping_state): Remove.
10523         (infrun_inferior_exit): Call displaced_step_state.reset.
10524         (use_displaced_stepping): Don't check for NULL.
10525         (displaced_step_prepare_throw): Call
10526         get_displaced_stepping_state.
10527         (displaced_step_fixup): Don't check for NULL.
10528         (prepare_for_detach): Don't check for NULL.
10529
10530 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10531
10532         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10533          in case of call that did not complete.
10534
10535 2019-01-02  Andrey Utkin  <autkin@undo.io>
10536
10537         * symfile.c (find_separate_debug_file): Fix search of debug files for
10538         remote debuggee.
10539
10540 2019-01-02  Tom Tromey  <tom@tromey.com>
10541
10542         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10543         indentation.
10544         * python/py-frame.c (frapy_older): Remove cast.
10545         (frapy_newer): Likewise.
10546         * python/py-breakpoint.c (local_setattro): Remove cast.
10547         * python/py-arch.c (archpy_name): Remove local variable.
10548         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10549
10550 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10551
10552         * unittests/basic_string_view/element_access/char/empty.cc:
10553         Fix year range in copyright header.
10554
10555 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10556
10557         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10558         Delete.
10559         <operator==>: Update with for removed field.
10560         <hash>: Likewise.
10561         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10562         <isa_features>: ...this.
10563         <abi_features>: New field.
10564         (riscv_isa_flen): Update comment.
10565         (riscv_abi_xlen): New declaration.
10566         (riscv_abi_flen): New declaration.
10567         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10568         isa_features.
10569         (riscv_abi_xlen): New function.
10570         (riscv_isa_flen): Update to get answer from isa_features.
10571         (riscv_abi_flen): New function.
10572         (riscv_has_fp_abi): Update to get answer from abi_features.
10573         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10574         xlen and flen.
10575         (riscv_call_info) <xlen, flen>: Update comment.
10576         (riscv_call_arg_struct): Remove invalid assertions
10577         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10578         is removed.
10579         (riscv_gdbarch_init): Gather isa features and abi features
10580         separately, ensure both match on the gdbarch when reusing an old
10581         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10582         a target with 64-bit float hardware.
10583
10584 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10585
10586         * source.c (search_command_helper): Stop reverse search
10587         when line 1 has been searched.
10588
10589 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10590
10591         * record-full.c (record_full_base_target::close): Rewrite
10592         record_full_core_buf_list free logic.
10593
10594 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10595
10596         * break-catch-syscall.c (print_one_catch_syscall): xfree
10597         the last text.
10598
10599 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10600
10601         * top.c (print_gdb_version): Update Copyright year in version
10602         message.
10603
10604 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10605
10606         Update copyright year range in all GDB files.
10607
10608 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10609
10610         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10611
10612 For older changes see ChangeLog-2018.
10613 \f
10614 Local Variables:
10615 mode: change-log
10616 left-margin: 8
10617 fill-column: 74
10618 version-control: never
10619 coding: utf-8
10620 End:
10621