gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
   4         location_matches_p.
   5         * tui/tui-source.c (tui_source_window::location_matches_p): New
   6         method.
   7         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
   8         method.
   9         * tui/tui-data.h (struct tui_source_window_base)
  10         <location_matches_p>: New method.
  11         (struct tui_source_window, struct tui_disasm_window)
  12         <location_matches_p>: Likewise.
  13
  14 2019-07-17  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-win.c (tui_set_win_height_command): Rename from
  17         tui_set_win_height.
  18         (tui_set_win_height_command): Remove.
  19
  20 2019-07-17  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-source.c (tui_source_window): New constructor.  Add
  23         observer.
  24         (~tui_source_window): New destructor.
  25         (tui_source_window::style_changed): New method.
  26         * tui/tui-hooks.c (tui_redisplay_source): Remove.
  27         (tui_attach_detach_observers): Update.
  28         * tui/tui-data.h (struct tui_source_window): Make constructor not
  29         inline.  Add destructor.
  30         (struct tui_source_window) <style_changed>: New method.
  31         <m_observable>: New member.
  32
  33 2019-07-17  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
  36         * tui/tui-win.c (tui_resize_all): Fix typo.
  37
  38 2019-07-17  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-wingeneral.h (tui_refresh_all): Update.
  41         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
  42         (tui_refresh_all): Remove "list" parameter.  Use foreach.
  43         * tui/tui-win.c (window_name_completer): Use foreach.
  44         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
  45         (update_tab_width): Likewise.
  46         * tui/tui-layout.c (show_layout): Update.
  47         * tui/tui-data.h (class tui_window_iterator): New.
  48         (struct all_tui_windows): New.
  49         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
  50
  51 2019-07-17  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
  54         parameter.  Don't reference globals.
  55         (tui_reg_command): Update.
  56
  57 2019-07-17  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-regs.c (tui_show_registers): Simplify.
  60
  61 2019-07-17  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-regs.c (tui_show_registers): Update.
  64         (tui_show_register_group): Add win_info parameter.
  65
  66 2019-07-17  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
  69         Rename from tui_display_reg_element_at_line.
  70         (tui_data_window::display_registers_from_line): Update.
  71         * tui/tui-data.h (struct tui_data_window)
  72         <display_reg_element_at_line>: New method.
  73
  74 2019-07-17  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-regs.h (tui_display_registers_from)
  77         (tui_display_registers_from_line): Don't declare.
  78         * tui/tui-windata.c (tui_data_window::display_all_data)
  79         (tui_data_window::refresh_all)
  80         (tui_data_window::do_scroll_vertical): Update.
  81         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
  82         from tui_display_registers_from.
  83         (tui_display_reg_element_at_line): Update.
  84         (tui_data_window::display_registers_from_line): Rename from
  85         tui_display_registers_from_line.
  86         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
  87         display_registers_from_line>: New methods.
  88
  89 2019-07-17  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
  92         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
  93         from tui_erase_data_content.
  94         (tui_data_window::display_all_data)
  95         (tui_data_window::refresh_all)
  96         (tui_data_window::do_scroll_vertical): Update.
  97         * tui/tui-regs.c (tui_show_registers): Update.
  98         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
  99         New method.
 100
 101 2019-07-17  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 104         declare.
 105         * tui/tui-windata.c
 106         (tui_data_window::delete_data_content_windows): Rename from
 107         tui_delete_data_content_windows.
 108         (tui_data_window::display_all_data)
 109         (tui_data_window::do_scroll_vertical): Update.
 110         * tui/tui-data.h (struct tui_data_window)
 111         <delete_data_content_windows>: New method.
 112
 113 2019-07-17  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 116         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 117
 118 2019-07-17  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 121         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 122         from tui_display_all_data.
 123         * tui/tui-win.c
 124         (tui_data_window::do_make_visible_with_new_height): Update.
 125         * tui/tui-regs.c (tui_show_registers): Update.
 126         * tui/tui-layout.c (tui_set_layout): Update.
 127         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 128         method.
 129
 130 2019-07-17  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 133         * tui/tui-windata.c (tui_display_data_from): Remove.
 134         (tui_data_window::refresh_all): Update.
 135
 136 2019-07-17  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 139         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 140         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 141         tui_display_registers_from_line.
 142         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 143         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 144         "force_display" parameter.
 145
 146 2019-07-17  Tom Tromey  <tom@tromey.com>
 147
 148         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 149         declare.
 150         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 151         Rename from tui_first_reg_element_no_inline.
 152         (tui_display_reg_element_at_line)
 153         (tui_display_registers_from_line): Update.
 154         * tui/tui-data.h (struct tui_data_window)
 155         <first_reg_element_no_inline>: New method.
 156
 157 2019-07-17  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-windata.c (tui_display_data_from)
 160         (tui_data_window::do_scroll_vertical): Update.
 161         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 162         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 163         Rename from tui_line_from_reg_element_no.
 164         (tui_display_registers_from_line): Update.
 165         * tui/tui-data.h (struct tui_data_window)
 166         <line_from_reg_element_no>: New method.
 167
 168 2019-07-17  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 171         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 172         tui_last_regs_line_no.
 173         (tui_display_reg_element_at_line)
 174         (tui_display_registers_from_line): Update.
 175         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 176         method.
 177
 178 2019-07-17  Tom Tromey  <tom@tromey.com>
 179
 180         PR tui/24722:
 181         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 182         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 183         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 184         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 185         (tui_update_breakpoint_info): Likewise.
 186         * tui/tui-hooks.c (tui_event_create_breakpoint)
 187         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 188         Update.
 189
 190 2019-07-17  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 193
 194 2019-07-17  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-winsource.c (tui_update_source_window_as_is)
 197         (tui_update_source_windows_with_addr): Update.
 198         * tui/tui-source.h (tui_set_source_content)
 199         (tui_show_symtab_source): Add "win_info" parameter.
 200         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 201         parameter.
 202         (tui_show_symtab_source): Likewise.
 203
 204 2019-07-17  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-wingeneral.c
 207         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 208
 209 2019-07-17  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 212         (struct tui_cmd_window) <can_scroll>: New method.
 213         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 214         method.
 215
 216 2019-07-17  Tom Tromey  <tromey@adacore.com>
 217
 218         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 219         do_field_signed>: Rename.  Change type of "value".
 220         * ui-out.c (ui_out::field_signed): Rename from field_int.
 221         Change type of "value".
 222         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 223         type of "value".
 224         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 225         do_field_int.  Change type of "value".
 226         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 227         do_field_int.  Change type of "value".
 228         * tracepoint.c (trace_status_mi, tfind_1)
 229         (print_one_static_tracepoint_marker): Update.
 230         * thread.c (print_thread_info_1, print_selected_thread_frame):
 231         Update.
 232         * stack.c (print_frame, print_frame_info): Update.
 233         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 234         Update.
 235         * source.c (print_source_lines_base): Update.
 236         * skip.c (info_skip_command): Update.
 237         * record-btrace.c (btrace_ui_out_decode_error)
 238         (btrace_call_history_src_line): Update.
 239         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 240         Update.
 241         * progspace.c (print_program_space): Update.
 242         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 243         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 244         do_field_int.  Change type of "value".
 245         * mi/mi-out.c (mi_ui_out::do_table_begin)
 246         (mi_ui_out::do_table_header): Update.
 247         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 248         type of "value".
 249         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 250         (mi_cmd_data_list_changed_registers, output_register)
 251         (mi_cmd_data_read_memory, mi_load_progress)
 252         (mi_cmd_trace_frame_collected): Update.
 253         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 254         Update.
 255         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 256         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 257         (mi_cmd_var_list_children, varobj_update_one): Update.
 258         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 259         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 260         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 261         * inferior.c (print_inferior): Update.
 262         * gdb_bfd.c (print_one_bfd): Update.
 263         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 264         Update.
 265         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 266         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 267         do_field_int.  Change type of "value".
 268         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 269         do_field_int.  Change type of "value".
 270         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 271         (print_one_breakpoint_location, print_it_catch_fork)
 272         (print_one_catch_fork, print_it_catch_vfork)
 273         (print_one_catch_vfork, print_it_catch_solib)
 274         (print_it_catch_exec, print_it_ranged_breakpoint)
 275         (print_mention_watchpoint, print_mention_masked_watchpoint)
 276         (bkpt_print_it, update_static_tracepoint): Update.
 277         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 278         * break-catch-syscall.c (print_it_catch_syscall): Update.
 279         * ada-tasks.c (print_ada_task_info): Update.
 280         * ada-lang.c (print_it_exception, print_mention_exception):
 281         Update.
 282
 283 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 284
 285         PR breakpoints/24541
 286         * gdbarch.c: Regenerate.
 287         * gdbarch.h: Regenerate.
 288         * gdbarch.sh: Adjust return type and parameter types for
 289         'stap_adjust_register'.
 290         (i386_stap_adjust_register): Adjust signature and return new
 291         register name.
 292         * stap-probe.c (stap_parse_register_operand): Adjust use of
 293         'gdbarch_stap_adjust_register'.
 294
 295 2019-07-17  Tom Tromey  <tromey@adacore.com>
 296
 297         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 298         declare VEC.
 299         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 300         std::vector.
 301         (struct s390_process_info): Add initializers.
 302         (s390_add_process): Use new.
 303         (s390_linux_nat_target::low_forget_process): Use delete.
 304         (s390_linux_nat_target::low_new_fork)
 305         (s390_linux_nat_target::stopped_by_watchpoint)
 306         (s390_linux_nat_target::low_prepare_to_resume)
 307         (s390_linux_nat_target::insert_watchpoint)
 308         (s390_linux_nat_target::insert_hw_breakpoint)
 309         (s390_linux_nat_target::remove_watchpoint)
 310         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 311
 312 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 313
 314         * aarch64-fbsd-nat.c: Include regcache.h.
 315         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 316         argument.
 317         (aarch64_fbsd_nat_target::fetch_registers)
 318         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 319         variable.
 320         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 321
 322 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 323
 324         * fbsd-nat.c: Include gdbarch.h.
 325
 326 2019-07-15  Tom Tromey  <tromey@adacore.com>
 327
 328         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 329
 330 2019-07-15  Tom Tromey  <tromey@adacore.com>
 331
 332         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 333         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 334         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 335         * cli-out.c (cli_ui_out::do_field_int): New method.
 336         * ui-out.c (ui_out::field_unsigned): New method.
 337         * symfile.c (generic_load): Use field_unsigned.
 338         (print_transfer_performance): Likewise.
 339         * record-btrace.c (ui_out_field_uint): Remove.
 340         (btrace_call_history_insn_range, btrace_call_history): Use
 341         field_unsigned.
 342         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 343         field_unsigned.
 344         * ui-out.h (class ui_out) <field_unsigned>: New method.
 345         <do_field_unsigned>: Likewise.
 346
 347 2019-07-15  Tom Tromey  <tromey@adacore.com>
 348
 349         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 350         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 351         * target.c (flash_erase_command): Use field_string.
 352         * infrun.c (print_signal_received_reason): Use field_string.
 353         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 354         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 355         field_string.
 356         * ada-tasks.c (print_ada_task_info): Use field_string.
 357
 358 2019-07-15  Tom Tromey  <tromey@adacore.com>
 359
 360         * target.c (flash_erase_command): Use field_core_addr.
 361         * symfile.c (generic_load): Use field_core_addr.
 362         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 363         Use field_core_addr.
 364         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 365         field_core_addr.
 366
 367 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 368
 369         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 370         value if its desired type is smaller than a CORE_ADDR and signed.
 371
 372 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 373
 374         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 375         of changes to field names, and use new is_reference field to
 376         decide if a property is a reference or not.
 377         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 378         field.
 379         (struct dwarf2_property_baton): Update header comment, rename
 380         'referenced_type' to 'property_type' and update comments.
 381         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 382         default property type, store in property baton, update to take
 383         accound of renamed field.
 384         (read_func_scope): Update call to attr_to_dynamic_prop.
 385         (read_array_type): Likewise.
 386         (dwarf2_per_cu_addr_sized_int_type): New function.
 387         (read_subrange_index_type): Move type finding code to
 388         dwarf2_per_cu_addr_sized_int_type.
 389         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 390         (dwarf2_per_cu_addr_type): New function.
 391         (set_die_type): Update calls to attr_to_dynamic_prop.
 392
 393 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 394
 395         * dwarf2read.c (read_subrange_index_type): New function.
 396         (read_subrange_type): Move code into new function and call it.
 397         * gdbtypes.c (create_range_type): Add some asserts.
 398
 399 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 400
 401         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 402         update return statements.
 403         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 404         declaration, and update comment to match.
 405         * gdbtypes.c (resolve_dynamic_array): Update call to
 406         dwarf2_evaluate_property to match new return type.
 407
 408 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 409
 410         * valarith.c (value_subscripted_rvalue): Change lowerbound
 411         parameter type from int to LONGEST.
 412         * value.h (value_subscripted_rvalue): Likewise in declaration.
 413
 414 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 415
 416         * cli/cli-utils.c (info_print_command_completer): New function.
 417         * cli/cli-utils.h: Add 'completer.h' include, and forward
 418         declaration for 'struct cmd_list_element'.
 419         (info_print_command_completer): Declare.
 420         * stack.c (_initialize_stack): Add completer for 'info locals' and
 421         'info args'.
 422         * symtab.c (_initialize_symtab): Add completer for 'info
 423         variables' and 'info functions'.
 424         * NEWS: Mention completion for additional info commands.
 425
 426 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 427
 428         * cli/cli-utils.c (extract_info_print_args): Delete.
 429         (extract_arg_maybe_quoted): Delete.
 430         (info_print_options_defs): New variable.
 431         (make_info_print_options_def_group): New function.
 432         (extract_info_print_options): Define new function.
 433         * cli/cli-utils.h (extract_info_print_args): Delete.
 434         (struct info_print_options): New structure.
 435         (extract_info_print_options): Declare new function.
 436         * stack.c (info_locals_command): Update to use new
 437         extract_info_print_options, also add a header comment.
 438         (info_args_command): Likewise.
 439         * symtab.c (info_variables_command): Likewise.
 440         (info_functions_command): Likewise.
 441
 442 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 443
 444         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 445         to extract string arguments.
 446         * common/common-utils.c (extract_string_maybe_quoted): New function.
 447         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 448
 449 2019-07-11  Tom Tromey  <tromey@adacore.com>
 450
 451         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 452         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 453         * top.h (gdbinit): Don't declare.
 454         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 455         into...
 456         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 457         * top.c (gdb_init): Don't call init_cli_cmds.
 458         (gdbinit): Remove.
 459         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 460
 461 2019-07-11  Tom Tromey  <tromey@adacore.com>
 462
 463         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 464         after it has been moved.
 465
 466 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 467
 468         * valops.c (value_must_coerce_to_target): Change return type to
 469         bool.
 470         * value.h (value_must_coerce_to_target): Likewise.
 471
 472 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 473
 474         * breakpoint.c (is_hardware_watchpoint): Remove
 475         forward-declaration.
 476         (is_masked_watchpoint): Change return type to bool.
 477         (is_tracepoint): Likewise.
 478         (is_breakpoint): Likewise.
 479         (is_hardware_watchpoint): Likewise.
 480         (is_watchpoint): Likewise.
 481         (is_no_memory_software_watchpoint): Likewise.
 482         (is_catchpoint): Likewise.
 483         (breakpoint_1): Make FILTER parameter's return type bool.
 484         is_masked_watchpoint): Change return type to bool.
 485         (save_breakpoints): Make FILTER parameter's return type bool.
 486         * breakpoint.h (is_breakpoint): Change return type to bool.
 487         (is_watchpoint): Likewise.
 488         (is_catchpoint): Likewise.
 489         (is_tracepoint): Likewise.
 490
 491 2019-07-10  Tom Tromey  <tom@tromey.com>
 492
 493         * defs.h: Don't include gdbarch.h.
 494         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 495         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 496         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 497         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 498         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 499         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 500         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 501         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 502         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 503         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 504         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 505         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 506         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 507         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 508         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 509         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 510         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 511         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 512         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 513         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 514         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 515         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 516         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 517         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 518         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 519         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 520         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 521
 522 2019-07-10  Tom Tromey  <tromey@adacore.com>
 523
 524         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 525         * breakpoint.c (init_ada_exception_breakpoint): Register as
 526         bp_catchpoint.
 527         (print_one_breakpoint_location, print_one_breakpoint): Use
 528         is_ada_exception_catchpoint.
 529         * ada-lang.c (class ada_catchpoint_location): Pass
 530         bp_loc_software_breakpoint to bp_location constructor.
 531         (is_ada_exception_catchpoint): New function.
 532
 533 2019-07-10  Tom Tromey  <tromey@adacore.com>
 534
 535         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 536         VEC.
 537         (struct arm_exidx_entry): New method operator<.
 538         (struct arm_exidx_data) <section_maps>: Change type.
 539         (arm_exidx_data_free): Remove.
 540         (arm_exidx_data_key): Change type.  Move lower.
 541         (arm_exidx_new_objfile): Update.
 542         (arm_compare_exidx_entries): Remove.
 543         (arm_find_exidx_entry, _initialize_arm_tdep)
 544
 545 2019-07-10  Tom Tromey  <tromey@adacore.com>
 546
 547         * solib-spu.c (ocl_program_data_key): Change type.
 548         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 549         Update.
 550
 551 2019-07-10  Tom Tromey  <tromey@adacore.com>
 552
 553         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 554         (struct solib_aix_inferior_data) <library_list>: Change type.
 555         (solib_aix_inferior_data_handle): Change type.
 556         (get_solib_aix_inferior_data): Update.
 557         (solib_aix_free_library_list): Remove.
 558         (library_list_start_library): Update.
 559         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 560         return type.
 561         (solib_aix_get_library_list)
 562         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 563         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 564
 565 2019-07-10  Tom Tromey  <tromey@adacore.com>
 566
 567         * solib-dsbt.c (struct dsbt_info): Add initializers.
 568         (solib_dsbt_pspace_data): Change type.
 569         (dsbt_pspace_data_cleanup): Remove.
 570         (get_dsbt_info, _initialize_dsbt_solib): Update.
 571
 572 2019-07-10  Tom Tromey  <tromey@adacore.com>
 573
 574         * spu-tdep.c (spu_overlay_data): Change type.
 575         (spu_get_overlay_table, spu_overlay_new_objfile)
 576         (_initialize_spu_tdep): Update.
 577
 578 2019-07-10  Tom Tromey  <tromey@adacore.com>
 579
 580         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 581         destructor.
 582         (dbx_objfile_data_key): Change type and declare later.
 583         (DBX_SYMFILE_INFO): Rewrite.
 584         * dbxread.c (dbx_objfile_data_key): Change type.
 585         (dbx_symfile_init): Update.
 586         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 587         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 588         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 589
 590 2019-07-10  Tom Tromey  <tromey@adacore.com>
 591
 592         * jit.c (jit_program_space_key): Change type.  Move lower.
 593         (get_jit_program_space_data): Update.
 594         (jit_program_space_data_cleanup): Remove.
 595         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 596         Update.
 597         (struct jit_program_space_data): Add initializers.
 598
 599 2019-07-10  Tom Tromey  <tromey@adacore.com>
 600
 601         * solib-darwin.c (struct darwin_info): Add initializers.
 602         (solib_darwin_pspace_data): Change type.
 603         (darwin_pspace_data_cleanup): Remove.
 604         (get_darwin_info, _initialize_darwin_solib): Update.
 605
 606 2019-07-10  Tom Tromey  <tromey@adacore.com>
 607
 608         * remote-sim.c (struct sim_inferior_data): Add initializers,
 609         constructor, and destructor.
 610         (sim_inferior_data_key): Change type.  Move lower.
 611         (check_for_duplicate_sim_descriptor): Update.
 612         (get_sim_inferior_data): Use new.  Update.
 613         (~sim_inferior_data_cleanup): Rename from
 614         sim_inferior_data_cleanup.  Simplify.
 615         (gdbsim_close_inferior, simulator_command)
 616         (sim_command_completer, _initialize_remote_sim): Update.
 617         (next_pid, INITIAL_PID): Move earlier.
 618
 619 2019-07-10  Tom Tromey  <tromey@adacore.com>
 620
 621         * python/python-internal.h (create_thread_object): Return
 622         gdbpy_ref.
 623         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 624         * python/py-inferior.c (struct threadlist_entry): Add
 625         constructor.
 626         <thread_obj>: Now a gdbpy_ref.
 627         (thread_to_thread_object): Update.
 628         (add_thread_object): Use new.
 629         (delete_thread_object): Use delete.
 630         (infpy_threads): Update.
 631         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 632         GIL.
 633
 634 2019-07-10  Tom Tromey  <tromey@adacore.com>
 635
 636         * valops.c (value_cast): Specialize error message for Ada.
 637
 638 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 639
 640         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 641
 642 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 643
 644         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 645         bpstat_should_step): Return bool, adjust comments.
 646         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 647         bpstat_should_step): Likewise.
 648
 649 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 650
 651         * features/Makefile: Use feature target descriptions for Arm.
 652         * features/arm/arm-core.c: Generate new file.
 653         * features/arm/arm-fpa.c: Likewise.
 654         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 655         * features/arm/arm-m-profile.c: Likewise.
 656         * features/arm/arm-vfpv2.c: Likewise.
 657         * features/arm/arm-vfpv3.c: Likewise.
 658         * features/arm/xscale-iwmmxt.c: Likewise.
 659         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 660
 661 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 662
 663         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 664         ptrace earlier.
 665
 666 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 667
 668         * features/aarch64-pauth.c: Regenerate.
 669
 670 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 671
 672         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 673         bool.
 674         (bpstat_what): Use false instead of 0.
 675
 676 2019-07-09  Pedro Alves  <palves@redhat.com>
 677
 678         * break-catch-throw.c (is_exception_catchpoint): New.
 679         * breakpoint.c (print_one_breakpoint_location): New parameter
 680         'raw_loc'.  Handle it.  Use
 681         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 682         looking at the breakpoint's type.
 683         (print_one_breakpoint): If handling "maint info breakpoints", also
 684         print locations of exception catchpoints.
 685         * breakpoint.h (is_exception_catchpoint): Declare.
 686
 687 2019-07-09  Pedro Alves  <palves@redhat.com>
 688
 689         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 690         "addr" field.
 691         (allocate_location_exception_catchpoint): New.
 692         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 693         (initialize_throw_catchpoint_ops): Install
 694         allocate_location_exception_catchpoint as allocate_location
 695         method.
 696         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 697         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 698         bp_loc_other.
 699         (breakpoint_address_is_meaningful): Delete.
 700         (bl_address_is_meaningful): New.
 701         (breakpoint_locations_match): Adjust comment.
 702         (bp_location_from_bp_type): New, factored out of...
 703         (bp_location::bp_location(breakpoint *)): ... this.
 704         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 705         factored out of...
 706         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 707         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 708         breakpoint_address_is_meaningful.
 709         (bp_locations_compare): Adjust comment.
 710         (update_global_location_list): Use bl_address_is_meaningful
 711         instead of breakpoint_address_is_meaningful.
 712         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 713         explicit.
 714         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 715         * python/py-breakpoint.c (bppy_get_location): No longer check
 716         whether location is null.
 717
 718 2019-07-09  Pedro Alves  <palves@redhat.com>
 719
 720         PR c++/15468
 721         * breakpoint.c (print_one_breakpoint_location): Remove
 722         single-location assert.
 723
 724 2019-07-09  Tom Tromey  <tom@tromey.com>
 725
 726         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 727         * configure: Rebuild.
 728         * configure.ac: Change common to gdbsupport.
 729         * gdbsupport: Rename from common.
 730         * acinclude.m4: Change common to gdbsupport.
 731         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 732         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 733         gdbsupport.
 734         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 735         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 736         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 737         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 738         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 739         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 740         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 741         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 742         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 743         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 744         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 745         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 746         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 747         coff-pe-read.c, command.h, compile/compile-c-support.c,
 748         compile/compile-c.h, compile/compile-cplus-symbols.c,
 749         compile/compile-cplus-types.c, compile/compile-cplus.h,
 750         compile/compile-loc2c.c, compile/compile.c, completer.c,
 751         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 752         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 753         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 754         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 755         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 756         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 757         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 758         features/aarch64-core.c, features/aarch64-fpu.c,
 759         features/aarch64-pauth.c, features/aarch64-sve.c,
 760         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 761         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 762         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 763         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 764         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 765         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 766         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 767         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 768         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 769         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 770         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 771         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 772         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 773         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 774         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 775         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 776         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 777         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 778         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 779         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 780         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 781         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 782         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 783         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 784         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 785         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 786         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 787         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 788         minsyms.c, mips-linux-tdep.c, namespace.h,
 789         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 790         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 791         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 792         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 793         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 794         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 795         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 796         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 797         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 798         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 799         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 800         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 801         procfs.c, producer.c, progspace.h, psymtab.h,
 802         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 803         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 804         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 805         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 806         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 807         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 808         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 809         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 810         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 811         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 812         target-memory.c, target.c, target.h, target/waitstatus.c,
 813         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 814         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 815         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 816         unittests/array-view-selftests.c,
 817         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 818         unittests/common-utils-selftests.c,
 819         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 820         unittests/format_pieces-selftests.c,
 821         unittests/function-view-selftests.c,
 822         unittests/lookup_name_info-selftests.c,
 823         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 824         unittests/mkdir-recursive-selftests.c,
 825         unittests/observable-selftests.c,
 826         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 827         unittests/parse-connection-spec-selftests.c,
 828         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 829         unittests/scoped_fd-selftests.c,
 830         unittests/scoped_mmap-selftests.c,
 831         unittests/scoped_restore-selftests.c,
 832         unittests/string_view-selftests.c, unittests/style-selftests.c,
 833         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 834         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 835         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 836         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 837         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 838         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 839
 840 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 841
 842         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 843         bool value.
 844         (decode_digits_ordinary): Set explicit_line field in sal.
 845         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 846         symtab_and_line that was set on an explicit line number in
 847         assembler code.  Do always update the recorded symtab and line if
 848         we do skip the prologue.
 849
 850 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 851
 852         * breakpoint.c (set_breakpoint_location_function): Remove
 853         explicit_loc parameter.
 854         (momentary_breakpoint_from_master): Update call to
 855         set_breakpoint_location_function.
 856         (add_location_to_breakpoint): Likewise.
 857
 858 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 859
 860         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 861         required features based on default bfd type when no specific bfd
 862         is present.
 863
 864 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 865
 866         * NEWS: Mention that GDB printf and eval commands can now print
 867         C-style and Ada-style convenience var strings without
 868         calling the inferior.
 869         * printcmd.c (printf_c_string): Locally print GDB internal var
 870         instead of transiting via the inferior.
 871         (printf_wide_c_string): Likewise.
 872
 873 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 874
 875         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 876
 877 2019-07-04  Tom Tromey  <tom@tromey.com>
 878
 879         PR tui/24724:
 880         * tui/tui-winsource.c (tui_clear_source_content): Update.
 881         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 882         (tui_update_breakpoint_info): Update.
 883         (tui_set_exec_info_content): Update.
 884         * tui/tui-source.c (tui_set_source_content_nil): Update.
 885         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 886         has_break.
 887         * tui/tui-data.h (enum tui_bp_flag): New.
 888         (tui_bp_flags): New enum flags type.
 889         (struct tui_source_element) <break_mode>: Change type.  Rename
 890         from has_break.
 891         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 892         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 893         constants.
 894         * tui/tui-winsource.h: Fix comment.
 895
 896 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 897
 898         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 899         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 900         (store_fpregs_to_thread)
 901         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 902         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 903         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 904         (IWMMXT_REGS_SIZE): Add define.
 905         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 906         (fetch_vfp_regs, store_vfp_regs)
 907         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 908         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 909
 910 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 911
 912         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 913         defines.
 914         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 915         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 916         (ARM_INT_REGISTER_SIZE): ...to this.
 917         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 918         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 919         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 920         (arm_linux_collect_gregset, supply_nwfpe_register)
 921         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 922         defines.
 923         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 924         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 925         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 926         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 927         (arm_return_in_memory, arm_store_return_value)
 928         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 929         (arm_record_ld_st_multiple): Likewise.
 930         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 931         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 932
 933 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 934
 935         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 936         AARCH64_DISPLACED_MODIFIED_INSNS.
 937         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 938         (aarch64_displaced_step_copy_insn): Likewise.
 939         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 940         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 941         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 942         ARM_DISPLACED_MODIFIED_INSNS.
 943         * arm-tdep.c (arm_gdbarch_init): Likewise.
 944         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 945         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 946         (struct arm_displaced_step_closure): Use
 947         ARM_DISPLACED_MODIFIED_INSNS.
 948
 949 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 950
 951         * features/Makefile: Remove unused xml files.
 952         * features/aarch64.xml: Remove.
 953         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 954         * features/i386/amd64-avx-avx512.xml: Remove.
 955         * features/i386/amd64-avx-linux.xml: Remove.
 956         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 957         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 958         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 959         * features/i386/amd64-avx-mpx.xml: Remove.
 960         * features/i386/amd64-avx.xml: Remove.
 961         * features/i386/amd64-linux.xml: Remove.
 962         * features/i386/amd64-mpx-linux.xml: Remove.
 963         * features/i386/amd64-mpx.xml: Remove.
 964         * features/i386/amd64.xml: Remove.
 965         * features/i386/i386-avx-avx512-linux.xml: Remove.
 966         * features/i386/i386-avx-avx512.xml: Remove.
 967         * features/i386/i386-avx-linux.xml: Remove.
 968         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 969         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 970         * features/i386/i386-avx-mpx-linux.xml: Remove.
 971         * features/i386/i386-avx-mpx.xml: Remove.
 972         * features/i386/i386-avx.xml: Remove.
 973         * features/i386/i386-linux.xml: Remove.
 974         * features/i386/i386-mmx-linux.xml: Remove.
 975         * features/i386/i386-mmx.xml: Remove.
 976         * features/i386/i386-mpx-linux.xml: Remove.
 977         * features/i386/i386-mpx.xml: Remove.
 978         * features/i386/i386.xml: Remove.
 979         * features/i386/x32-avx-avx512-linux.xml: Remove.
 980         * features/i386/x32-avx-linux.xml: Remove.
 981         * features/i386/x32-linux.xml: Remove.
 982
 983 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 984
 985         * regformats/aarch64.dat: Remove.
 986         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 987         * regformats/i386/amd64-avx-linux.dat: Remove.
 988         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 989         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 990         * regformats/i386/amd64-linux.dat: Remove.
 991         * regformats/i386/amd64-mpx-linux.dat: Remove.
 992         * regformats/i386/amd64.dat: Remove.
 993         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 994         * regformats/i386/i386-avx-linux.dat: Remove.
 995         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 996         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 997         * regformats/i386/i386-linux.dat: Remove.
 998         * regformats/i386/i386-mmx-linux.dat: Remove.
 999         * regformats/i386/i386-mpx-linux.dat: Remove.
1000         * regformats/i386/i386.dat: Remove.
1001         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1002         * regformats/i386/x32-avx-linux.dat: Remove.
1003         * regformats/i386/x32-linux.dat: Remove.
1004
1005 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1006
1007         * aarch64-tdep.c: Remove xml self tests.
1008         * amd64-linux-tdep.c: Likewise.
1009         * amd64-tdep.c: Likewise.
1010         * i386-linux-tdep.c: Likewise.
1011         * i386-tdep.c: Likewise.
1012
1013 2019-07-03  Pedro Alves  <palves@redhat.com>
1014
1015         PR cli/24732
1016         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1017         (pipe_cmd_option_defs): New.
1018         (make_pipe_cmd_options_def_group): New.
1019         (pipe_command): Use gdb::option::process_options.
1020         (pipe_command_completer): New function.
1021         (_initialize_cli_cmds): Install completer for "pipe" command.
1022
1023 2019-07-03  Pedro Alves  <palves@redhat.com>
1024
1025         * cli/cli-option.c (union option_value) <string>: New field.
1026         (struct option_def_and_value): Add ctor, move ctor, dtor and
1027         use DISABLE_COPY_AND_ASSIGN.
1028         (option_def_and_value::clear_value): New.
1029         (parse_option, save_option_value_in_ctx, get_val_type_str)
1030         (add_setshow_cmds_for_options): Handle var_string.
1031         * cli-option.h (union option_def::var_address) <string>: New
1032         field.
1033         (struct string_option_def): New.
1034         * maint-test-options.c (struct test_options_opts): Add default
1035         ctor and use DISABLE_COPY_AND_ASSIGN.
1036         <string_opt>: New field.
1037         (test_options_opts::~test_options_opts): New.
1038         (test_options_opts::dump): Also dump "-string".
1039         (test_options_option_defs): Install "string.
1040
1041 2019-07-03  Pedro Alves  <palves@redhat.com>
1042
1043         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1044         option_value with a null enumeration.
1045         (complete_options): Save the option values in the context.
1046         (save_option_value_in_ctx): New, factored out from ...
1047         (process_options): ... here.
1048         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1049         of the function.
1050         * maint-test-options.c (test_options_opts::dump): New, factored
1051         out from ...
1052         (maintenance_test_options_command_mode): ... here.
1053         (maintenance_test_options_command_completion_result): Delete.
1054         (maintenance_test_options_command_completion_text): Update
1055         comment.
1056         (maintenance_show_test_options_completion_result): Change
1057         prototype.  Just print
1058         maintenance_test_options_command_completion_text.
1059         (save_completion_result): New.
1060         (maintenance_test_options_completer_mode): Pass options context to
1061         complete_options, and then save a dump.
1062         (_initialize_maint_test_options): Use add_cmd to install "maint
1063         show test-options-completion-result".
1064
1065 2019-07-03  Pedro Alves  <palves@redhat.com>
1066
1067         * NEWS (New commands): Mention "with" and "maint with".
1068         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1069         (with_command, with_command_completer): New.
1070         (pipe_command): Adjust to new repeat_previous
1071         interface.
1072         (_initialize_cli_cmds): Install the "with" command and its "w"
1073         alias.
1074         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1075         declarations.
1076         * cli/cli-setshow.c (parse_cli_var_uinteger)
1077         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1078         argument strings for all var_types.
1079         (get_setshow_command_value_string): New, factored out from ...
1080         (do_show_command): ... this.
1081         * cli/cli-setshow.h: Include <string>.
1082         (get_setshow_command_value_string): Declare.
1083         * command.h (repeat_previous): Now returns const char *.  Adjust
1084         comment.
1085         * maint.c: Include "cli/cli-cmds.h".
1086         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1087         (_initialize_maint_cmds): Register the "maintenance with" command.
1088         * top.c (repeat_previous): Move bits from pipe_command here:
1089         Return the saved command line, if any; error out if there's no
1090         command to relaunch.
1091
1092 2019-07-03  Pedro Alves  <palves@redhat.com>
1093
1094         * NEWS (New commands): Mention "maint set/show test-settings"
1095         instead of "maint test-settings".
1096         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1097         (maintenance_test_settings_set_list): Rename to ...
1098         (maintenance_set_test_settings_list): ... this.
1099         (maintenance_test_settings_show_list): Rename to  ...
1100         (maintenance_show_test_settings_list): ... this.
1101         (maintenance_test_settings_cmd): Delete.
1102         (maintenance_test_settings_set_cmd): ...
1103         (maintenance_set_test_settings_cmd): ... this.
1104         (maintenance_test_settings_show_cmd): ...
1105         (maintenance_show_test_settings_cmd): ... this.
1106         (maintenance_test_settings_show_value_cmd):
1107         (maintenance_show_test_settings_value_cmd): ... this.
1108         (_initialize_maint_test_settings): No longer install the "maint
1109         test-settings" prefix command.  Rename "maint test-settings set"
1110         to "maint set test-settings", and "maint test-settings show" to
1111         "maint show test-settings".  Adjust all subcommands.
1112
1113 2019-07-03  Pedro Alves  <palves@redhat.com>
1114
1115         * maint-test-settings.c: Fix file's intro comment.  Replace all
1116         references to "test-options" with references to "test-settings",
1117         in comments.
1118
1119 2019-07-03  Pedro Alves  <palves@redhat.com>
1120
1121         * maint-test-settings.c (maintenance_test_settings_xxx)
1122         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1123         New.
1124         (maintenance_test_settings_enums): Use them.
1125         (maintenance_test_settings_enum): Default to
1126         maintenance_test_settings_xxx.
1127         (_initialize_maint_test_settings): Initialize
1128         MAINTENANCE_TEST_SETTINGS_FILENAME.
1129
1130 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1131
1132         * breakpoint.h (remove_breakpoints_inf): Change return type to
1133         void, move function documentation here.
1134         * breakpoint.c (remove_breakpoints_inf): Change return type to
1135         void, move function documentation to header.
1136
1137 2019-07-02  Pedro Alves  <palves@redhat.com>
1138
1139         * NEWS (Completion improvements): Mention "info threads".
1140         * thread.c (struct info_threads_opts, info_threads_option_defs)
1141         (make_info_threads_options_def_group): New.
1142         (info_threads_command): Use gdb::option::process_options.
1143         (info_threads_command_completer): New.
1144         (_initialize_thread): Use gdb::option::build_help to build the
1145         help text for "info threads".
1146
1147 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1148
1149         * defs.h (generic_load): Move from here...
1150         * symfile.h (generic_load): ... to here.  Rename name parameter
1151         to args.
1152         * symfile.c (generic_load): Add comment.
1153
1154 2019-07-01  Tom Tromey  <tromey@adacore.com>
1155
1156         * dwarf2read.c
1157         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1158         declaration of without_params.  Fix formatting.
1159
1160 2019-07-01  Tom Tromey  <tromey@adacore.com>
1161
1162         * ada-exp.y (find_primitive_type): Update.
1163         * ada-lang.h (ada_lookup_symbol): Update.
1164         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1165         parameter.
1166         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1167
1168 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1169
1170         PR breakpoints/24541
1171         * gdbarch.c: Regenerate.
1172         * gdbarch.h: Regenerate.
1173         * gdbarch.sh: Add 'stap_adjust_register'.
1174         * i386-tdep.c: Include '<unordered_set>'.
1175         (i386_stap_adjust_register): New function.
1176         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1177         * stap-probe.c (stap_parse_register_operand): Call
1178         'gdbarch_stap_adjust_register'.
1179
1180 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1181
1182         PR python/24742
1183         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1184         * python/python.c (do_start_initialization): Use 'xmalloc'
1185         instead of 'PyMem_Malloc'.
1186
1187 2019-06-28  Tom Tromey  <tromey@adacore.com>
1188
1189         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1190         for Ada.
1191
1192 2019-06-27  Tom Tromey  <tromey@adacore.com>
1193
1194         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1195         objfile_key.
1196         (arm_find_mapping_symbol, arm_record_special_symbol)
1197         (_initialize_arm_tdep): Update.
1198         (arm_objfile_data_free): Remove.
1199
1200 2019-06-27  Tom Tromey  <tromey@adacore.com>
1201
1202         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1203         to cp_print_static_field.
1204
1205 2019-06-26  Tom Tromey  <tromey@adacore.com>
1206
1207         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1208         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1209         declare.
1210
1211 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1212
1213         * features/aarch64-core.c (create_feature_aarch64_core):
1214         Regenerate.
1215         * features/aarch64-core.xml: Add cpsr flags.
1216
1217 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1218
1219         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1220         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1221
1222 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1223
1224         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1225         field.
1226         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1227         use.
1228         (arm_record_special_symbol): Don't insert new symbol in sorted
1229         position, push it at the end.
1230
1231 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1232
1233         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1234         (arm_mapping_symbol_s): Remove.
1235         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1236         (arm_mapping_symbol_vec): New typedef.
1237         (struct arm_per_objfile): Add constructor.
1238         <section_maps>: Change type to
1239         std::unique_ptr<arm_mapping_symbol_vec[]>.
1240         (arm_compare_mapping_symbols): Remove.
1241         (arm_find_mapping_symbol): Adjust to section_maps type change.
1242         (arm_objfile_data_free): Call delete on arm_per_objfile.
1243         (arm_record_special_symbol): Adjust to section_maps type change.
1244         Allocate arm_per_objfile with new.
1245
1246 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1247
1248         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1249         with the command prefix.
1250
1251 2019-06-25  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1254         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1255
1256 2019-06-25  Tom Tromey  <tom@tromey.com>
1257
1258         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1259         type.
1260         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1261         protected.
1262
1263 2019-06-25  Tom Tromey  <tom@tromey.com>
1264
1265         * tui/tui-winsource.c
1266         (tui_source_window_base::set_is_exec_point_at): Add check against
1267         LOA_ADDRESS.
1268
1269 2019-06-25  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-source.c (tui_set_source_content): Don't check before
1272         xfree.
1273         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1274
1275 2019-06-25  Tom Tromey  <tom@tromey.com>
1276
1277         * tui/tui-winsource.h (tui_update_source_window_as_is)
1278         (tui_alloc_source_buffer, tui_line_is_displayed)
1279         (tui_addr_is_displayed): Change type of win_info.
1280         * tui/tui-winsource.c (tui_update_source_window_as_is)
1281         (tui_clear_source_content, tui_show_source_line)
1282         (tui_show_source_content, tui_source_window_base::refill)
1283         (tui_source_window_base::set_is_exec_point_at)
1284         (tui_source_window_base::set_is_exec_point_at)
1285         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1286         (tui_alloc_source_buffer, tui_line_is_displayed)
1287         (tui_addr_is_displayed): Change type of win_info.  Update.
1288         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1289         (tui_source_window_base::do_make_visible_with_new_height):
1290         Update.
1291         * tui/tui-source.c (tui_set_source_content)
1292         (tui_set_source_content_nil)
1293         (tui_source_window::do_scroll_vertical): Update.
1294         * tui/tui-layout.c (show_layout): Update.
1295         * tui/tui-disasm.c (tui_set_disassem_content)
1296         (tui_disasm_window::do_scroll_vertical): Update.
1297         * tui/tui-data.h (tui_win_content): Remove.
1298         (struct tui_gen_win_info) <content, content_size>: Remove.
1299         (struct tui_source_element): Add initializers and destructor.
1300         (union tui_which_element, struct tui_win_element): Remove.
1301         (struct tui_source_window_base) <content>: New field.
1302         (struct tui_data_window): Remove destructor.
1303         (tui_alloc_content, tui_free_win_content)
1304         (tui_free_all_source_wins_content): Don't declare.
1305         * tui/tui-data.c (tui_initialize_static_data): Update.
1306         (init_content_element, tui_alloc_content): Remove.
1307         (~tui_gen_win_info): Update.
1308         (~tui_data_window, tui_free_all_source_wins_content)
1309         (tui_free_win_content, free_content, free_content_elements):
1310         Remove.
1311
1312 2019-06-25  Tom Tromey  <tom@tromey.com>
1313
1314         * tui/tui-winsource.h (tui_clear_source_content)
1315         (tui_erase_source_content, tui_show_source_content): Change type
1316         of win_info.
1317         * tui/tui-winsource.c (tui_clear_source_content)
1318         (tui_erase_source_content, tui_show_source_content): Change type
1319         of win_info.
1320         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1321         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1322         win_info.
1323         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1324         win_info.
1325         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1326
1327 2019-06-25  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-winsource.c (tui_clear_source_content)
1330         (tui_source_window_base::set_is_exec_point_at): Update.
1331         * tui/tui-source.c (tui_set_source_content_nil): Update.
1332         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1333         a bool.
1334         * tui/tui-data.c (init_content_element): Update.
1335
1336 2019-06-25  Tom Tromey  <tom@tromey.com>
1337
1338         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1339         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1340         * tui/tui-layout.c (init_and_make_win): Update.
1341         * tui/tui.h (enum tui_win_type): Update.
1342         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1343         tui_win_is_auxillary.
1344         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1345         tui_win_is_auxillary.
1346
1347 2019-06-25  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1350         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1351         (tui_delete_data_content_windows, tui_display_all_data)
1352         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1353         Update.
1354         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1355         * tui/tui-regs.c (tui_last_regs_line_no)
1356         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1357         (tui_show_registers): Update.
1358         (tui_show_register_group): Return void.  Update.
1359         (tui_display_registers_from, tui_display_reg_element_at_line)
1360         (tui_display_registers_from_line, tui_check_register_values):
1361         Update.
1362         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1363         member.
1364         (struct tui_data_window) <regs_content>: Now a std::vector.
1365         <regs_content_count>: Remove.
1366         (tui_add_content_elements, tui_free_data_content): Don't declare.
1367         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1368         (init_content_element): Remove DATA_WIN case.  Add assert.
1369         (tui_add_content_elements): Remove.
1370         (tui_data_window): Update.
1371         (tui_free_data_content): Remove.
1372         (free_content_elements): Remove DATA_WIN case.
1373
1374 2019-06-25  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-data.c (tui_data_item_window): Update.
1377         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1378         * tui/tui-windata.c (tui_display_all_data)
1379         (tui_display_data_from_line): Update.
1380         (tui_check_data_values): Remove.
1381         * tui/tui-regs.c (tui_show_register_group)
1382         (tui_display_reg_element_at_line): Update.
1383         * tui/tui-hooks.c (tui_register_changed)
1384         (tui_refresh_frame_and_register_information): Call
1385         tui_check_register_values.
1386         * tui/tui-data.h (struct tui_data_window) <data_content,
1387         data_content_count, data_type>: Remove.
1388         (enum tui_data_type): Remove.
1389
1390         * tui/tui-data.c (tui_data_window::clear_detail)
1391         (~tui_data_window): Update.
1392
1393 2019-06-25  Tom Tromey  <tom@tromey.com>
1394
1395         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1396         declare.
1397         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1398         Rename from tui_first_data_item_displayed.  Update.
1399         (tui_data_window::refresh_all)
1400         (tui_data_window::do_scroll_vertical): Update.
1401         * tui/tui-data.h (struct tui_data_window)
1402         <first_data_item_displayed>: Declare new method.
1403
1404 2019-06-25  Tom Tromey  <tom@tromey.com>
1405
1406         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1407         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1408         contents...
1409         (tui_initialize_static_data): ...here.
1410
1411 2019-06-25  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1414         (tui_display_registers_from, tui_check_register_values): Update.
1415         (tui_display_register): Remove win_info parameter; update.
1416         (tui_get_register): Change type of parameters.
1417         * tui/tui-data.h (struct tui_data_element): Remove.
1418         (union tui_which_element) <data>: Remove.
1419         <data_window>: Change type.
1420         (struct tui_data_item_window): New.
1421         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1422         case.  Add assert.
1423         (~tui_data_item_window): New destructor.
1424         (free_content_elements): Remove DATA_ITEM_WIN case.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1429         Remove.
1430
1431 2019-06-25  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-data.h (struct tui_command_element): Remove.
1434         (union tui_which_element) <command>: Remove.
1435         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1436         assert.
1437         (free_content_elements): Remove CMD_WIN case.
1438
1439 2019-06-25  Tom Tromey  <tom@tromey.com>
1440
1441         * tui/tui-layout.c (tui_set_layout): Update.
1442         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1443         * tui/tui-data.c (layout_def): Update.
1444
1445 2019-06-25  Tom Tromey  <tom@tromey.com>
1446
1447         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1448         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1449         (tui_source_window_base::set_new_height): Update.
1450         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1451         Update.
1452         (tui_set_locator_fullname, tui_set_locator_info)
1453         (tui_show_frame_info): Update.
1454         * tui/tui-source.c (tui_set_source_content)
1455         (tui_source_is_displayed): Update.
1456         * tui/tui-layout.c (show_source_disasm_command, show_data)
1457         (show_source_or_disasm_and_command): Update.
1458         * tui/tui-disasm.c (tui_set_disassem_content)
1459         (tui_get_begin_asm_address): Update.
1460         * tui/tui-data.h (struct tui_locator_element): Remove.
1461         (union tui_which_element) <locator>: Remove.
1462         (struct tui_locator_window): New.
1463         (tui_locator_win_info_ptr): Change return type.
1464         * tui/tui-data.c (_locator): Change type.
1465         (tui_locator_win_info_ptr): Change return type.
1466         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1467         (tui_alloc_content): Add assert.
1468
1469 2019-06-25  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-winsource.c
1472         (tui_exec_info_window::maybe_allocate_content): New method.
1473         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1474         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1475         (make_source_or_disasm_window): Add cast.
1476         * tui/tui-data.h (union tui_which_element) <simple_string>:
1477         Remove.
1478         (struct tui_source_info): New.
1479         (struct tui_source_window_base) <execution_info>: Change type.
1480         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1481         case, and add assert.
1482         (tui_alloc_content): Add assert.
1483
1484 2019-06-25  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1487         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1488         * tui/tui-data.c (tui_alloc_win_info): Remove.
1489
1490 2019-06-25  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1493         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1494         can_highlight.
1495
1496 2019-06-25  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1499         make_visible_with_new_height method.
1500         (tui_win_info::make_visible_with_new_height): New method.
1501         (tui_source_window_base::do_make_visible_with_new_height)
1502         (tui_data_window::do_make_visible_with_new_height)
1503         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1504         (make_visible_with_new_height): Remove.
1505         (tui_resize_all, tui_adjust_win_heights): Use
1506         make_visible_with_new_height method.
1507         * tui/tui-data.h (struct tui_win_info)
1508         <do_make_visible_with_new_height, make_visible_with_new_height>:
1509         New methods.
1510         (struct tui_source_window_base, struct tui_data_window)
1511         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1512         methods.
1513
1514 2019-06-25  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1517         method.
1518         (update_tab_width): Call update_tab_width method.
1519         * tui/tui-data.h (struct tui_win_info)
1520         (struct tui_source_window_base) <update_tab_width>: New methods.
1521
1522 2019-06-25  Tom Tromey  <tom@tromey.com>
1523
1524         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1525         parameter.
1526         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1527         parameter.
1528         (tui_gen_win_info::make_visible): Update.
1529         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1530         parameter.
1531         * tui/tui-data.h (enum tui_box): New enum.
1532         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1533
1534 2019-06-25  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1537         init_and_make_win for EXEC_INFO_WIN.
1538         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1539         longer inline.
1540         (struct tui_win_info) <~tui_win_info>: Inline.
1541         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1542         Don't declare.
1543         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1544         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1545         Remove.
1546         (tui_initialize_static_data): Update.
1547         (~tui_gen_win_info): Handle more cleanup here.
1548         (~tui_source_window_base): Delete "execution_info".
1549         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1550
1551 2019-06-25  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-layout.c (make_command_window): Don't set
1554         can_highlight.
1555         (show_source_disasm_command): Call the reset method.
1556         (show_data): Don't set can_highlight.  Call the reset method.
1557         (tui_gen_win_info::reset): Rename from init_gen_win_info
1558         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1559         (show_source_or_disasm_and_command): Call the reset method.
1560         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1561         (struct tui_cmd_window): Set can_highlight.
1562
1563 2019-06-25  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1566         from make_visible.
1567         (tui_make_visible, tui_make_invisible): Rewrite.
1568         (tui_win_info::make_visible): Remove.
1569         (tui_source_window_base::make_visible): Update.
1570         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1571         method.  Moved from...
1572         (struct tui_win_info) <make_visible>: ...here.
1573
1574 2019-06-25  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-winsource.c
1577         (tui_source_window_base::do_scroll_horizontal): Remove direction
1578         parameter.
1579         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1580         direction parameter.
1581         * tui/tui-win.c (tui_win_info::forward_scroll)
1582         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1583         (tui_win_info::right_scroll): Update.
1584         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1585         direction parameter.
1586         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1587         direction parameter.
1588         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1589         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1590         Remove direction parameter.
1591         (struct tui_source_window_base, struct tui_source_window)
1592         (struct tui_disasm_window, struct tui_data_window)
1593         (struct tui_cmd_window): Update.
1594
1595 2019-06-25  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-winsource.h (tui_set_exec_info_content)
1598         (tui_show_exec_info_content, tui_erase_exec_info_content)
1599         (tui_clear_exec_info_content, tui_update_exec_info): Change
1600         argument to tui_source_window_base.
1601         * tui/tui-winsource.c (tui_set_exec_info_content)
1602         (tui_show_exec_info_content, tui_erase_exec_info_content)
1603         (tui_clear_exec_info_content, tui_update_exec_info): Change
1604         argument to tui_source_window_base.
1605
1606 2019-06-25  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1609         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1610
1611 2019-06-25  Tom Tromey  <tom@tromey.com>
1612
1613         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1614         check.
1615
1616 2019-06-25  Tom Tromey  <tom@tromey.com>
1617
1618         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1619         type to void.
1620         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1621         type to void.
1622         * tui/tui-source.c (tui_set_source_content): Update.
1623         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1624
1625 2019-06-25  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui-win.c (window_name_completer, tui_set_focus)
1628         (tui_all_windows_info): Use name method.
1629         * tui/tui-data.h (struct tui_gen_win_info)
1630         (struct tui_source_window, struct tui_disasm_window)
1631         (struct tui_data_window, struct tui_cmd_window) <name>: New
1632         method.
1633         (tui_win_name): Don't declare.
1634         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1635         (tui_win_name): Remove.
1636
1637 2019-06-25  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-winsource.h (tui_update_source_window)
1640         (tui_update_source_window_as_is): Change parameter type.
1641         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1642         to be a tui_source_window_base.
1643         (tui_update_source_window_as_is): Likewise.
1644         * tui/tui-win.c (make_visible_with_new_height): Update.
1645
1646 2019-06-25  Tom Tromey  <tom@tromey.com>
1647
1648         * tui/tui-winsource.c (tui_erase_source_content)
1649         (tui_show_source_content, tui_show_exec_info_content)
1650         (tui_erase_exec_info_content): Use refresh_window method.
1651         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1652         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1653         from tui_refresh_win.
1654         (tui_data_window::refresh_window): New method.
1655         (tui_win_info::refresh, tui_source_window_base::refresh)
1656         (tui_refresh_all): Use refresh_window method.
1657         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1658         method.
1659         * tui/tui-regs.c (tui_display_register): Call refresh_window
1660         method.
1661         * tui/tui-layout.c (show_source_disasm_command)
1662         (show_source_or_disasm_and_command): Call refresh_window method.
1663         * tui/tui-data.h (struct tui_gen_win_info)
1664         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1665         New method.
1666
1667 2019-06-25  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui.c (tui_rl_other_window, tui_enable)
1670         (tui_is_window_visible, tui_get_command_dimension): Update.
1671         * tui/tui-winsource.c (tui_update_source_window_as_is)
1672         (tui_clear_source_content, tui_erase_source_content)
1673         (tui_show_source_line, tui_source_window_base::refill)
1674         (tui_source_window_base::do_scroll_horizontal)
1675         (tui_source_window_base::set_is_exec_point_at)
1676         (tui_update_breakpoint_info, tui_set_exec_info_content)
1677         (tui_alloc_source_buffer, tui_line_is_displayed)
1678         (tui_addr_is_displayed): Update.
1679         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1680         (tui_check_and_display_highlight_if_needed)
1681         (tui_win_info::make_visible, tui_win_info::refresh)
1682         (tui_refresh_all): Update.
1683         * tui/tui-windata.c (tui_first_data_item_displayed)
1684         (tui_delete_data_content_windows, tui_erase_data_content)
1685         (tui_display_all_data, tui_data_window::refresh_all)
1686         (tui_check_data_values): Update.
1687         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1688         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1689         (tui_win_info::backward_scroll, tui_refresh_all_win)
1690         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1691         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1692         (tui_source_window_base::set_new_height)
1693         (tui_data_window::set_new_height)
1694         (make_invisible_and_set_new_height)
1695         (make_visible_with_new_height, new_height_ok)
1696         (parse_scrolling_args): Update.
1697         * tui/tui-stack.c (tui_show_frame_info): Update.
1698         * tui/tui-source.c (tui_set_source_content)
1699         (tui_set_source_content_nil, tui_source_is_displayed)
1700         (tui_source_window::do_scroll_vertical): Update.
1701         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1702         (tui_display_registers_from, tui_display_reg_element_at_line)
1703         (tui_check_register_values, tui_reg_command): Update.
1704         * tui/tui-layout.c (tui_default_win_height)
1705         (show_source_disasm_command, show_data, init_and_make_win)
1706         (show_source_or_disasm_and_command): Update.
1707         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1708         (tui_redisplay_readline, tui_mld_flush)
1709         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1710         (tui_getc): Update.
1711         * tui/tui-disasm.c (tui_set_disassem_content)
1712         (tui_disasm_window::do_scroll_vertical): Update.
1713         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1714         Now virtual.
1715         (struct tui_win_info): Derive from tui_gen_win_info.
1716         <~tui_win_info>: Mark as override.
1717         <generic>: Remove member.
1718         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1719         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1720         (~tui_data_window, ~tui_win_info)
1721         (tui_free_all_source_wins_content): Update.
1722         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1723
1724 2019-06-25  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-layout.c (init_and_make_win): Use new.
1727         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1728         destructor, initializers.
1729         (tui_alloc_generic_win_info): Don't declare.
1730         * tui/tui-data.c (_locator): Add argument to constructor.
1731         (source_win, disasm_win): New globals.
1732         (exec_info): Remove.
1733         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1734         Update.
1735         (tui_alloc_generic_win_info): Remove.
1736         (init_content_element): Use new.
1737         (tui_win_info::tui_win_info): Update.
1738         (free_content_elements) <case DATA_WIN>: Use delete.
1739
1740 2019-06-25  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1743         * tui/tui-windata.c (tui_first_data_item_displayed)
1744         (tui_delete_data_content_windows): Update.
1745         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1746         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1747         (tui_display_registers_from, tui_check_register_values): Update.
1748         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1749         pointer.
1750         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1751         window.
1752         (tui_free_data_content): Update.
1753         (free_content_elements) <case DATA_WIN>: Free the window.
1754
1755 2019-06-25  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1758         Update.
1759         * tui/tui-layout.c (make_command_window)
1760         (show_source_disasm_command, show_data, init_and_make_win)
1761         (show_source_or_disasm_and_command): Update.
1762         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1763         method.
1764         <can_highight, is_highlighted>: Now bool.
1765         (tui_set_win_highlight): Don't declare.
1766         * tui/tui-data.c (tui_set_win_highlight): Remove.
1767
1768 2019-06-25  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-wingeneral.c (make_visible): Remove check of window
1771         type.
1772
1773 2019-06-25  Tom Tromey  <tom@tromey.com>
1774
1775         * tui/tui-win.c (tui_win_info::max_height)
1776         (tui_cmd_window::max_height): New methods.
1777         (new_height_ok): Call max_height.
1778         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1779         <max_height>: New method.
1780
1781 2019-06-25  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-win.c (tui_source_window_base::set_new_height)
1784         (tui_data_window::set_new_height): New methods.
1785         (make_invisible_and_set_new_height): Call set_new_height method.
1786         * tui/tui-data.h (struct tui_win_info)
1787         (struct tui_source_window_base, struct tui_data_window)
1788         <set_new_height>: New method.
1789
1790 2019-06-25  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1793         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1794         tui_refresh_data_win.
1795         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1796         method.
1797         (tui_refresh_all_win): Call the refresh_all method.
1798         (tui_set_focus): Likewise.
1799         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1800         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1801         Likewise.
1802
1803 2019-06-25  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-winsource.h (tui_refill_source_window)
1806         (tui_set_is_exec_point_at): Don't declare.
1807         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1808         (tui_source_window_base::refill): Rename from
1809         tui_refill_source_window.
1810         (tui_source_window_base::do_scroll_horizontal): Update.
1811         (tui_source_window_base::set_is_exec_point_at): Rename from
1812         tui_set_is_exec_point_at.
1813         (tui_update_all_breakpoint_info): Update.
1814         * tui/tui-stack.c (tui_show_frame_info): Update.
1815         * tui/tui-layout.c (show_data): Add cast.
1816         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1817         * tui/tui-data.h (struct tui_source_window_base) <refill,
1818         set_is_exec_point_at>: New methods.
1819         (tui_source_windows, tui_add_to_source_windows): Update types.
1820         (tui_add_to_source_windows): Remove redundant declaration.
1821         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1822         (tui_source_windows): Change return type.
1823         (tui_clear_source_windows_detail): Update.
1824         (tui_add_to_source_windows): Change type of parameter.
1825         (tui_free_all_source_wins_content): Update.
1826
1827 2019-06-25  Tom Tromey  <tom@tromey.com>
1828
1829         * tui/tui-wingeneral.c (tui_win_info::refresh)
1830         (tui_source_window_base::refresh): New methods.
1831         (tui_refresh_all): Call the refresh method.
1832         * tui/tui-data.h (struct tui_win_info)
1833         (struct tui_source_window_base) <refresh>: New method.
1834
1835 2019-06-25  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui.h (tui_is_window_visible): Return bool.
1838         * tui/tui.c (tui_is_window_visible): Return bool.
1839         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1840         (tui_make_visible, tui_make_invisible)
1841         (tui_win_info::make_visible)
1842         (tui_source_window_base::make_visible, make_all_visible)
1843         (tui_make_all_visible, tui_make_all_invisible): Update.
1844         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1845         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1846         bool.
1847         (struct tui_win_info, struct tui_source_window_base)
1848         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1849         * tui/tui-data.c (tui_init_generic_part): Update.
1850
1851 2019-06-25  Tom Tromey  <tom@tromey.com>
1852
1853         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1854         (tui_source_window_base::make_visible): New methods.
1855         (make_all_visible): Make method call.
1856         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1857         (struct tui_source_window_base, struct tui_cmd_window): Override
1858         make_visible.
1859         (tui_win_is_source_type): Don't declare.
1860         * tui/tui-data.c (tui_win_is_source_type): Remove.
1861
1862 2019-06-25  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1865         NULL check.
1866
1867 2019-06-25  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1870         Inline constructor.  Add initializers for members.
1871         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1872         constructors; now inline in class.
1873
1874 2019-06-25  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-regs.c (tui_show_registers): Update.
1877         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1878         bool.
1879         * tui/tui-data.c (tui_data_window::clear_detail)
1880         (tui_data_window): Update.
1881
1882 2019-06-25  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-windata.c (tui_display_all_data)
1885         (tui_display_data_from_line, tui_display_data_from)
1886         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1887         Update.
1888         * tui/tui-regs.c (tui_last_regs_line_no)
1889         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1890         (tui_show_registers, tui_show_register_group)
1891         (tui_display_registers_from, tui_display_reg_element_at_line)
1892         (tui_display_registers_from_line, tui_check_register_values)
1893         (tui_reg_next, tui_reg_prev): Update.
1894         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1895         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1896         tui_data_window.
1897         (struct tui_win_info) <detail>: Remove.  Add new fields from
1898         tui_data_info.
1899         (TUI_DATA_WIN): Add cast.
1900         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1901         (~tui_data_window): Simplify.
1902
1903 2019-06-25  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-layout.c (show_source_disasm_command)
1906         (show_source_or_disasm_and_command): Update.
1907         * tui/tui-io.c (update_cmdwin_start_line)
1908         (tui_redisplay_readline): Update.
1909         * tui/tui-data.h (struct tui_command_info): Remove.
1910         (struct tui_win_info) <detail>: Remove command_info member.
1911         (struct tui_data_window) <start_line>: New member, from
1912         tui_command_info.
1913         (TUI_CMD_WIN): Add casts.
1914
1915 2019-06-25  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-winsource.c (tui_update_source_window)
1918         (tui_refill_source_window)
1919         (tui_source_window_base::do_scroll_horizontal)
1920         (tui_update_breakpoint_info, tui_set_exec_info_content)
1921         (tui_show_exec_info_content, tui_erase_exec_info_content)
1922         (tui_clear_exec_info_content): Update.
1923         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1924         Update.
1925         * tui/tui-win.c (make_invisible_and_set_new_height)
1926         (make_visible_with_new_height): Update.
1927         * tui/tui-source.c (tui_set_source_content)
1928         (tui_show_symtab_source): Update.
1929         * tui/tui-layout.c (extract_display_start_addr)
1930         (show_source_disasm_command, show_data)
1931         (make_source_or_disasm_window)
1932         (show_source_or_disasm_and_command): Update.
1933         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1934         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1935         "gdbarch".
1936         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1937         to tui_source_window_base.
1938         (struct tui_win_info) <detail>: Remove source_info member.
1939         (struct tui_source_window_base) <has_locator>: Inline.
1940         Move contents from tui_source_info; rename has_locator member to
1941         m_has_locator.
1942         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1943         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1944         header file.
1945         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1946         Simplify.
1947         (tui_free_all_source_wins_content): Cast to
1948         tui_source_window_base.
1949
1950 2019-06-25  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-win.c (make_invisible_and_set_new_height)
1953         (make_visible_with_new_height): Call has_locator method.
1954         * tui/tui-layout.c (show_source_disasm_command, show_data)
1955         (show_source_or_disasm_and_command): Update for bool change.
1956         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1957         (tui_win_info) <has_locator>: New method.
1958         (struct tui_source_window_base) <has_locator>: New method.
1959         (tui_win_has_locator): Don't declare.
1960         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1961         from tui_win_has_locator.
1962         (tui_source_window_base): Use false, not FALSE.
1963
1964 2019-06-25  Tom Tromey  <tom@tromey.com>
1965
1966         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1967         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1968         clear_detail method directly.
1969         (tui_clear_win_detail): Remove.
1970
1971 2019-06-25  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1974         "this", not TUI_DISASM_WIN.
1975
1976 2019-06-25  Tom Tromey  <tom@tromey.com>
1977
1978         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1979         declare.
1980         * tui/tui-winsource.c
1981         (tui_source_window_base::do_scroll_horizontal): Rename from
1982         tui_horizontal_source_scroll.
1983         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1984         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1985         from tui_vertical_data_scroll.
1986         * tui/tui-win.h (tui_scroll): Don't declare.
1987         * tui/tui-win.c (tui_win_info::forward_scroll)
1988         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1989         (tui_win_info::right_scroll): Rename and update.
1990         (tui_scroll_forward_command, tui_scroll_backward_command)
1991         (tui_scroll_left_command, tui_scroll_right_command): Update.
1992         (tui_scroll): Remove.
1993         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1994         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1995         from tui_vertical_source_scroll.
1996         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1997         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1998         from tui_vertical_disassem_scroll.
1999         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2000         do_scroll_horizontal>: New methods.
2001         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2002         Likewise.
2003         (struct tui_source_window_base): Add do_scroll_horizontal.
2004         (struct tui_source_window, struct tui_disasm_window): Add
2005         do_scroll_vertical.
2006         (struct tui_data_window, struct tui_cmd_window): Add
2007         do_scroll_horizontal and do_scroll_vertical.
2008         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-data.h (struct tui_source_window_base): New struct.
2013         (struct tui_source_window): Derive from tui_source_window_base.
2014         (struct tui_disasm_window): New struct.
2015         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2016         from tui_source_window::clear_detail.
2017         (tui_source_window_base): Rename from tui_source_window.
2018         (~tui_source_window_base): Rename from ~tui_source_window.
2019         (tui_alloc_win_info): Create a tui_disasm_window.
2020
2021 2019-06-25  Tom Tromey  <tom@tromey.com>
2022
2023         * tui/tui-data.h (struct tui_source_window)
2024         (struct tui_data_window): Declare destructors.
2025         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2026         destructors.
2027         (tui_win_info): Simplify.
2028
2029 2019-06-25  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-winsource.c (tui_display_main)
2032         (tui_update_source_windows_with_addr)
2033         (tui_update_all_breakpoint_info): Update.
2034         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2035         (new_height_ok, parse_scrolling_args): Update.
2036         * tui/tui-stack.c (tui_show_frame_info): Update.
2037         * tui/tui-data.h (struct tui_list): Remove.
2038         (tui_source_windows): Return a reference to a std::vector.
2039         * tui/tui-data.c (source_windows): Now a std::vector.
2040         (tui_source_windows): Change return type.
2041         (tui_clear_source_windows): Rewrite.
2042         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2043         (tui_free_all_source_wins_content): Rewrite.
2044
2045 2019-06-25  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2048         (struct tui_data_window, struct tui_cmd_window): Declare
2049         clear_detail method.
2050         * tui/tui-data.c (tui_source_window::clear_detail)
2051         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2052         methods.
2053         (tui_clear_win_detail): Simplify.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-layout.c (make_source_window, make_disasm_window)
2058         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2059         Return the new window.
2060         (show_source_disasm_command, show_data)
2061         (show_source_or_disasm_and_command): Update.
2062
2063 2019-06-25  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2066         parameter.  Return the new window.
2067         (show_source_disasm_command): Update and remove NULL check.
2068         (show_source_or_disasm_and_command): Update.
2069
2070 2019-06-25  Tom Tromey  <tom@tromey.com>
2071
2072         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2073
2074 2019-06-25  Tom Tromey  <tom@tromey.com>
2075
2076         * tui/tui-data.h (struct tui_win_info): Make constructor
2077         protected.  Make destructor virtual.  Add initializers.
2078         (tui_source_window, tui_data_window, tui_cmd_window): New
2079         classes.
2080         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2081         constructor.  Add "type" parameter.
2082         (tui_source_window, tui_data_window, tui_cmd_window): New
2083         constructors.
2084         (tui_alloc_win_info): Instantiate the appropriate subclass.
2085
2086 2019-06-25  Tom Tromey  <tom@tromey.com>
2087
2088         * tui/tui-win.c (tui_resize_all): Use delete.
2089         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2090         destructor.
2091         (tui_free_window): Don't declare.
2092         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2093         Update.
2094
2095 2019-06-25  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-data.h (struct tui_win_info): Add constructor.
2098         * tui/tui-data.c (tui_alloc_win_info): Use new.
2099         (tui_free_window): Use delete.
2100
2101 2019-06-22  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2104         declare.
2105         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2106
2107 2019-06-22  Tom Tromey  <tom@tromey.com>
2108
2109         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2110         declare.
2111         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2112
2113 2019-06-22  Tom de Vries  <tdevries@suse.de>
2114
2115         * dwarf2read.c (create_addrmap_from_aranges)
2116         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2117         instead of '%zu'.
2118
2119 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2120
2121         * dwarf2read.h (dwarf2_section_info_def): Remove.
2122         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2123         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2124         std::vector<dwarf2_section_info>.
2125         (struct dwo_file) <~dwo_file>: Remove.
2126         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2127         types field.
2128         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2129         (dwarf2_read_debug_names): Likewise.
2130         (create_debug_types_hash_table): Change parameter type to
2131         array_view, adjust code accordingly.
2132         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2133         (partial_die_info::fixup): Likewise.
2134         (determine_prefix): Likewise.
2135         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2136
2137 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2138
2139         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2140         gdb_bfd_ref_ptr.
2141         <~dwo_file>: Remove call to gdb_bfd_unref.
2142         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2143         gdb_bfd_ref_ptr::get.
2144
2145 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2146
2147         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2148         type to htab_up.
2149         * dwarf2read.c (struct dwo_file): Initialize fields.
2150         <~dwo_file>: New.
2151         (free_dwo_file): Remove, move content to ~dwo_file.
2152         (struct dwo_file_deleter): Remove.
2153         (dwo_file_up>: Remove custom deleter.
2154         (free_dwo_files): Remove.
2155         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2156         dwo_files.
2157         (process_skeletonless_type_units): Call unique_ptr::get.
2158         (allocate_dwo_file_hash_table): Add deleter to created hash
2159         table.  Change return type to htab_up.
2160         (lookup_dwo_file_slot): Don't memset dwo_file, call
2161         unique_ptr::get.
2162         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2163         (create_dwo_unit_in_dwp_v2): Likewise.
2164         (open_and_init_dwo_file): Likewise.
2165         (free_dwo_file_from_slot): Remove.
2166
2167 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2168
2169         * dwarf2read.h (struct dwarf2_section_info) <readin,
2170         is_virtual>: Change type to bool.
2171         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2172         true instead of 1.
2173
2174 2019-06-19  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-data.h (tui_init_content_element): Don't declare.
2177
2178 2019-06-19  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-data.h (tui_init_win_info): Don't declare.
2181
2182 2019-06-19  Tom de Vries  <tdevries@suse.de>
2183
2184         * dwarf2read.h (abstract_to_concrete): Change type to
2185         std::unordered_map<sect_offset, std::vector<sect_offset>,
2186         gdb::hash_enum<sect_offset>>.
2187
2188 2019-06-19  Tom Tromey  <tromey@adacore.com>
2189
2190         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2191         EVAL_AVOID_SIDE_EFFECTS specially.
2192
2193 2019-06-19  Tom Tromey  <tromey@adacore.com>
2194
2195         * source-cache.c (highlighter): New global.
2196         (source_cache::get_source_lines): Create a highlighter on demand.
2197
2198 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2199
2200         * defs.h (deprecated_interactive_hook): Delete declaration.
2201         * interps.c (clear_interpreter_hooks): Remove use of
2202         deprecated_interactive_hook.
2203         * top.c (deprecated_interactive_hook): Delete definition.
2204         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2205
2206 2019-06-18  Tom de Vries  <tdevries@suse.de>
2207
2208         PR gdb/24515
2209         * dwarf2read.h (abstract_to_concrete): Change type from
2210         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2211         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2212         * dwarf2read.c (read_variable): Update.
2213         (dwarf2_fetch_die_loc_sect_off): Update.
2214
2215 2019-06-17  Tom de Vries  <tdevries@suse.de>
2216
2217         PR gdb/24617
2218         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2219         accessing parent[parent_len - 1].
2220
2221 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2222
2223         PR gdb/24364
2224         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2225         call dtrace_process_dof with NULL dof.
2226
2227 2019-06-16  Tom de Vries  <tdevries@suse.de>
2228
2229         PR gdb/24445
2230         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2231
2232 2019-06-16  Tom Tromey  <tom@tromey.com>
2233
2234         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2235         (make_all_visible): Use address of member.
2236
2237 2019-06-16  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2240         (tui_free_window, free_content, free_content_elements): Remove
2241         unnecessary cast.
2242         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2243         cast.
2244         * tui/tui-regs.c (tui_show_register_group)
2245         (tui_display_registers_from, tui_display_reg_element_at_line):
2246         Remove unnecessary cast.
2247
2248 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2249
2250         * linux-nat.c (normal_mask): Delete.
2251         (_initialize_linux_nat): Don't initialise normal_mask.
2252
2253 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2254
2255         PR gdb/24445
2256         * dwarf-index-write.h (write_psymtabs_to_index): Add
2257         dwz_basename parameter.
2258         * dwarf-index-write.c (write_gdbindex): Move file writing to
2259         write_gdbindex_1.  Change return type void.
2260         (assert_file_size): Move up, remove filename parameter.
2261         (write_gdbindex_1): New function.
2262         (write_debug_names): Change return type to void, call
2263         assert_file_size.
2264         (struct index_wip_file): New struct.
2265         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2266         file logic to index_wip_file.  Write index for dwz file if
2267         needed.
2268         (save_gdb_index_command): Pass basename of dwz file, if present.
2269         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2270         build-id of dwz file, if present.
2271         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2272         (dwarf2_get_dwz_file): Likewise.
2273         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2274         (dwarf2_get_dwz_file): Likewise.
2275
2276 2019-06-16  Tom Tromey  <tom@tromey.com>
2277
2278         * coffread.c (process_coff_symbol): Use xstrdup.
2279         * value.c (create_internalvar): Use xstrdup.
2280
2281 2019-06-16  Tom Tromey  <tom@tromey.com>
2282
2283         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2284         * breakpoint.c (stopin_command, stopat_command)
2285         (until_break_command, decode_location_default): Remove unnecessary
2286         cast.
2287         * utils.c (subset_compare): Remove unnecessary cast.
2288         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2289         cast.
2290         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2291         cast.
2292         * infcmd.c (path_command): Remove unnecessary cast.
2293         * coffread.c (decode_type): Remove unnecessary cast.
2294         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2295         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2296         * tui/tui-stack.c (tui_show_locator_content)
2297         (tui_show_frame_info): Remove unnecessary cast.
2298         * tui/tui-win.c (tui_scroll_forward_command)
2299         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2300         (parse_scrolling_args): Remove unnecessary cast.
2301         * tui/tui-data.c (init_win_info, tui_del_window)
2302         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2303         (free_content_elements): Remove unnecessary cast.
2304         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2305         unnecessary cast.
2306         * tui/tui-source.c (tui_set_source_content)
2307         (tui_vertical_source_scroll): Remove unnecessary cast.
2308         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2309         cast.
2310         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2311         * tui/tui-regs.c (tui_display_registers_from)
2312         (tui_display_register): Remove unnecessary cast.
2313         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2314         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2315         (make_visible): Remove unnecessary cast.
2316         * tui/tui-winsource.c (tui_erase_source_content)
2317         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2318         unnecessary cast.
2319         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2320         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2321         * stabsread.c (read_type, read_array_type, read_range_type):
2322         Remove unnecessary cast.
2323         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2324         (parse_symbol, parse_type, upgrade_type, parse_external)
2325         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2326         unnecessary cast.
2327         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2328
2329 2019-06-16  Tom Tromey  <tom@tromey.com>
2330
2331         * tui/tui-data.c (tui_alloc_generic_win_info)
2332         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2333         checks.
2334
2335 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2336             Andrew Burgess  <andrew.burgess@embecosm.com>
2337
2338         * f-typeprint.c (f_print_type): Don't return early for not
2339         associated or not allocated types.
2340         (f_type_print_varspec_suffix): Add print_rank parameter and print
2341         ranks of array types in case they dangling.
2342         (f_type_print_base): Add print_rank parameter.
2343
2344 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2345
2346         * NEWS: Mention new MI commands.
2347         * break-catch-throw.c (enum exception_event_kind): Move to
2348         breakpoint.h.
2349         (print_mention_exception_catchpoint): Output text as a single
2350         message.
2351         (catch_exception_command_1): Rename to...
2352         (catch_exception_event): ...this, make non-static, update header
2353         command, and change some parameter types.
2354         (catch_catch_command): Update for changes to
2355         catch_exception_command_1.
2356         (catch_throw_command): Likewise.
2357         (catch_rethrow_command): Likewise.
2358         * breakpoint.c (enum exception_event_kind): Delete.
2359         * breakpoint.h (enum exception_event_kind): Moved here from
2360         break-catch-throw.c.
2361         (catch_exception_event): Declare.
2362         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2363         (mi_cmd_catch_throw): New function.
2364         (mi_cmd_catch_rethrow): New function.
2365         (mi_cmd_catch_catch): New function.
2366         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2367         'catch-catch' entries.
2368         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2369         (mi_cmd_catch_rethrow): Declare.
2370         (mi_cmd_catch_catch): Declare.
2371
2372 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2373
2374         * annotate.c (annotate_source_line): Change return type to void,
2375         update implementation to match.
2376         * annotate.h (annotate_source_line): Change return type to void,
2377         update header comment.
2378         * stack.c (print_frame_info): Don't change what frame information
2379         is printed based on whether annotations are on or not.
2380
2381 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2382
2383         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2384         (annotate_source): Make static.
2385         (annotate_source_line): Moved from source.c and renamed from
2386         identify_source_line.  Update the return type.
2387         * annotate.h (annotate_source): Delete declaration.
2388         (annotate_source_line): Declaration moved from source.h, and
2389         renamed from identify_source_line.  Return type updated.
2390         * source.c (identify_source_line): Moved to annotate.c and renamed
2391         to annotate_source_line.
2392         (info_line_command): Remove check of annotation_level.
2393         * source.h (identify_source_line): Move declaration to annotate.h
2394         and rename to annotate_source_line.
2395         * stack.c: Add 'annotate.h' include.
2396         (print_frame_info): Remove check of annotation_level before
2397         calling annotate_source_line.
2398
2399 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2400
2401         * source-cache.c (source_cache::get_plain_source_lines): Use
2402         open_source_file_with_line_charpos instead of just
2403         open_source_file, remove call to find_source_lines.
2404         (source_cache::get_source_lines): Likewise.
2405         * source.c (find_source_lines): Make static.
2406         (get_filename_and_charpos): Renamed into...
2407         (open_source_file_with_line_charpos): ..this along with changes to
2408         return a scoped_fd, and some other minor clean ups.
2409         (identify_source_line): Use open_source_file_with_line_charpos.
2410         (search_command_helper): Use open_source_file_with_line_charpos
2411         instead of just open_source_file, remove call to
2412         find_source_lines.
2413         * source.h (open_source_file_with_line_charpos): Declare new
2414         function.
2415         (find_source_lines): Delete declaration.
2416
2417 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2418
2419         * source.c (get_filename_and_charpos): Remove fullname
2420         parameter.
2421         (identify_source_line): Update call to get_filename_and_charpos.
2422
2423 2019-06-14  Tom Tromey  <tromey@adacore.com>
2424
2425         PR gdb/24502:
2426         * ui-style.h (skip_ansi_escape): Update comment.
2427         * ui-file.h (class no_terminal_escape_file): New class.
2428         * ui-file.c (no_terminal_escape_file::write)
2429         (no_terminal_escape_file::puts): New methods.
2430         * cli/cli-logging.c (handle_redirections): Use
2431         no_terminal_escape_file.
2432
2433 2019-06-14  Tom Tromey  <tromey@adacore.com>
2434
2435         * NEWS: Move convenience variable news above Python news.
2436
2437 2019-06-14  Tom Tromey  <tom@tromey.com>
2438
2439         * gnulib: Move directory to top-level.
2440         * configure.ac: Don't configure gnulib.
2441         * configure: Rebuild.
2442         * common/common-defs.h: Use new path to gnulib.
2443         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2444         (GNULIB_H): Remove.
2445         (INCGNU): Look in new gnulib location.
2446         (HFILES_NO_SRCDIR): Remove gnulib files.
2447         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2448         (generated_files): Remove GNULIB_H.
2449         ($(LIBGNU), all-lib): Remove targets.
2450         (distclean): Don't mention GNULIB_BUILDDIR.
2451         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2452
2453 2019-06-14  Tom Tromey  <tromey@adacore.com>
2454
2455         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2456         Warn if symbol file does not provide any symbols.
2457
2458 2019-06-14  Tom Tromey  <tromey@adacore.com>
2459
2460         * source.c (find_and_open_source): Respect basenames_may_differ.
2461
2462 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2463
2464         * annotate.c (annotate_breakpoints_invalid): Make use of
2465         scoped_restore_terminal_state.
2466         (annotate_frames_invalid): Likewise.
2467
2468 2019-06-14  Tom Tromey  <tromey@adacore.com>
2469
2470         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2471         allow assignment to an internalvar.
2472
2473 2019-06-14  Tom Tromey  <tromey@adacore.com>
2474
2475         * ada-lex.l: Allow "_" in attribute names.
2476
2477 2019-06-14  Tom Tromey  <tromey@adacore.com>
2478
2479         PR gdb/24653:
2480         * regcache.c (registers_changed): Don't call alloca.
2481         * top.c (execute_command): Don't call alloca.
2482
2483 2019-06-13  Pedro Alves  <palves@redhat.com>
2484
2485         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2486         'expression'.  When parsing an expression, error out if there's
2487         junk after "unlimited".
2488         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2489         (do_set_command): Adjust calls to is_unlimited_literal.
2490
2491 2019-06-13  Pedro Alves  <palves@redhat.com>
2492
2493         * compile/compile.c (make_compile_options_def_group): Add braces
2494         around array_view initializer.
2495         * thread.c (make_thread_apply_all_options_def_group)
2496         (make_thread_apply_all_options_def_group): Likewise.
2497
2498 2019-06-13  Pedro Alves  <palves@redhat.com>
2499
2500         * NEWS (New commands): Mention "maint test-options
2501         require-delimiter", "maint test-options unknown-is-error", "maint
2502         test-options unknown-is-operand" and "maint show
2503         test-options-completion-result".
2504         (New command options, command completion): New section.
2505         (Completion improvements): New section.
2506         Mention that you can abbreviate "unlimited".
2507
2508 2019-06-13  Pedro Alves  <palves@redhat.com>
2509
2510         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2511         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2512         * unittests/cli-utils-selftests.c (test_parse_flags)
2513         (test_parse_flags_qcs): Delete.
2514         (test_cli_utils): Don't call deleted functions.
2515
2516 2019-06-13  Pedro Alves  <palves@redhat.com>
2517
2518         * thread.c: Include "cli/cli-option.h".
2519         (tp_array_compar_ascending): Global.
2520         (tp_array_compar): Delete function.
2521         (tp_array_compar_ascending, tp_array_compar_descending): New
2522         functions.
2523         (ascending_option_def, qcs_flag_option_def)
2524         (thr_qcs_flags_option_defs)
2525         (make_thread_apply_all_options_def_group)
2526         (make_thread_apply_options_def_group): New.
2527         (thread_apply_all_command): Use gdb::option::process_options.
2528         (thread_apply_command_completer)
2529         (thread_apply_all_command_completer): New.
2530         (thread_apply_command): Use gdb::option::process_options.
2531         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2532         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2533         to generate help text of "thread apply".  Adjust "taas"'s help.
2534         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2535         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2536
2537 2019-06-13  Pedro Alves  <palves@redhat.com>
2538
2539         * thread.c (thread_apply_command): Check for invalid TID with
2540         isdigit instead of !isalpha.
2541
2542 2019-06-13  Pedro Alves  <palves@redhat.com>
2543
2544         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2545         (validate_flags_qcs): New.
2546         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2547         (validate_flags_qcs): Declare.
2548         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2549         (make_frame_apply_options_def_group): New.
2550         (frame_apply_command_count): Process options with
2551         gdb::option::process_options.
2552         (frame_apply_completer): New.
2553         (frame_apply_level_completer, frame_apply_all_completer)
2554         (frame_apply_completer): New.
2555         (_initialize_stack): Update help of "frame apply", "frame apply
2556         level", "frame apply all" and "faas" to mention supported options
2557         and install command completers.
2558         * stack.h (frame_apply_all_completer): Declare.
2559         * thread.c: Include "stack.h".
2560         (tfaas_command): Add "--".
2561         (_initialize_thread): Update help "tfaas" to mention supported
2562         options and install command completer.
2563
2564 2019-06-13  Pedro Alves  <palves@redhat.com>
2565
2566         * completer.c (complete_nested_command_line): New.
2567         (gdb_completion_word_break_characters_throw): Add assertion.
2568         * completer.h (complete_nested_command_line): Declare.
2569
2570 2019-06-13  Pedro Alves  <palves@redhat.com>
2571
2572         * stack.c (parse_backtrace_qualifiers): New.
2573         (backtrace_command): Use it.
2574         (backtrace_command_completer): Complete on qualifiers.
2575
2576 2019-06-13  Pedro Alves  <palves@redhat.com>
2577
2578         * frame.c: Include "cli/cli-option.h.
2579         (user_set_backtrace_options): New.
2580         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2581         Delete.
2582         (get_prev_frame): Adjust.
2583         (boolean_option_def, uinteger_option_def)
2584         (set_backtrace_option_defs): New.
2585         (_initialize_frame): Adjust and use
2586         gdb::option::add_setshow_cmds_for_options to install "set
2587         backtrace past-main" and "set backtrace past-entry".
2588         * frame.h: Include "cli/cli-option.h".
2589         (struct frame_print_options): Forward declare.
2590         (print_frame_arguments_all, print_frame_arguments_scalars)
2591         (print_frame_arguments_none): Declare.
2592         (print_entry_values): Delete declaration.
2593         (struct frame_print_options, user_frame_print_options): New.
2594         (struct set_backtrace_options): New.
2595         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2596         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2597         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2598         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2599         (list_args_or_locals): Add frame_print_options parameter.
2600         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2601         * python/py-framefilter.c (enumerate_args): Pass down
2602         USER_FRAME_PRINT_OPTIONS.
2603         * stack.c: Include "cli/cli-option.h".
2604         (print_frame_arguments_all, print_frame_arguments_scalars)
2605         (print_frame_arguments_none): Declare.
2606         (print_raw_frame_arguments, print_entry_values): Delete.
2607         (user_frame_print_options): New.
2608         (boolean_option_def, enum_option_def, frame_print_option_defs):
2609         New.
2610         (struct backtrace_cmd_options): New.
2611         (bt_flag_option_def): New.
2612         (backtrace_command_option_defs): New.
2613         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2614         (print_frame_arg, read_frame_arg, print_frame_args)
2615         (print_frame_info, print_frame): Add frame_print_options parameter
2616         and use it.
2617         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2618         (backtrace_command_1): Add frame_print_options and
2619         backtrace_cmd_options parameters and use them.
2620         (make_backtrace_options_def_group): New.
2621         (backtrace_command): Process command options with
2622         gdb::option::process_options.
2623         (backtrace_command_completer): New.
2624         (_initialize_stack): Extend "backtrace"'s help to mention
2625         supported options.  Install completer for "backtrace".
2626         Install some settings commands with add_setshow_cmds_for_options.
2627
2628 2019-06-13  Pedro Alves  <palves@redhat.com>
2629
2630         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2631         and that "set/show print raw frame-arguments" are now deprecated.
2632
2633         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2634         command.
2635         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2636         * stack.c (_initialize_stack): Install "set/show print
2637         raw-frame-arguments", and deprecate "set/show print raw
2638         frame-arguments".
2639         * valprint.c (_initialize_valprint): Deprecate "set/show print
2640         raw".
2641
2642 2019-06-13  Pedro Alves  <palves@redhat.com>
2643
2644         * compile/compile.c (struct compile_options): New.
2645         (compile_flag_option_def, compile_command_option_defs)
2646         (make_compile_options_def_group): New.
2647         (compile_file_command): Handle options with
2648         gdb::option::process_options.
2649         (compile_file_command_completer): New function.
2650         (compile_code_command): Handle options with
2651         gdb::option::process_options.
2652         (compile_code_command_completer): New function.
2653         (_initialize_compiler): Install completers for "compile code" and
2654         "compile file".  Mention available options in "compile code" and
2655         "compile code"'s help.
2656         * completer.c (advance_to_completion_word): New, factored out from
2657         ...
2658         (advance_to_expression_complete_word_point): ... this.
2659         (advance_to_filename_complete_word_point): New.
2660         * completer.h (advance_to_filename_complete_word_point): New
2661         declaration.
2662
2663 2019-06-13  Pedro Alves  <palves@redhat.com>
2664
2665         * compile/compile.c: Include "cli/cli-option.h".
2666         (compile_print_value): Scope data pointer is now a
2667         value_print_options pointer; adjust.
2668         (compile_print_command): Process options.  Scope data pointer is
2669         now a value_print_options pointer; adjust.
2670         (_initialize_compile): Update "compile print"'s help to include
2671         supported options.  Install a completer for "compile print".
2672         * cp-valprint.c (show_vtblprint, show_objectprint)
2673         (show_static_field_print): Delete.
2674         (_initialize_cp_valprint): Don't install "set print
2675         static-members", "set print vtbl", "set print object" here.
2676         * printcmd.c: Include "cli/cli-option.h" and
2677         "common/gdb_optional.h".
2678         (print_command_parse_format): Rework to fill in a
2679         value_print_options instead of a format_data.
2680         (print_value): Change parameter type from format_data pointer to
2681         value_print_options reference.  Adjust.
2682         (print_command_1): Process options.  Adjust to pass down a
2683         value_print_options.
2684         (print_command_completer): New.
2685         (_initialize_printcmd): Install print_command_completer as
2686         handle_brkchars completer for the "print" command.  Update
2687         "print"'s help to include supported options.
2688         * valprint.c: Include "cli/cli-option.h".
2689         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2690         here from cp-valprint.c.
2691         (boolean_option_def, uinteger_option_def)
2692         (value_print_option_defs, make_value_print_options_def_group):
2693         New.  Use gdb::option::add_setshow_cmds_for_options to install
2694         "set print elements", "set print null-stop", "set print repeats",
2695         "set print pretty", "set print union", "set print array", "set
2696         print address", "set print symbol", "set print array-indexes".
2697         * valprint.h: Include <string> and "cli/cli-option.h".
2698         (make_value_print_options_def_group): Declare.
2699         (print_value): Change parameter type from format_data pointer to
2700         value_print_options reference.
2701         (print_command_completer): Declare.
2702
2703 2019-06-13  Pedro Alves  <palves@redhat.com>
2704
2705         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2706         (COMMON_SFILES): Add maint-test-settings.c.
2707         * cli/cli-decode.c (boolean_enums): New global, factored out from
2708         ...
2709         (add_setshow_boolean_cmd): ... here.
2710         * cli/cli-decode.h (boolean_enums): Declare.
2711         * cli/cli-option.c: New file.
2712         * cli/cli-option.h: New file.
2713         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2714         factored out from ...
2715         (parse_cli_boolean_value(const char *)): ... this.
2716         (is_unlimited_literal): Change parameter type to pointer to
2717         pointer.  Adjust and advance ARG pointer.
2718         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2719         (parse_cli_var_enum): New, factored out from ...
2720         (do_set_command): ... this.  Adjust.
2721         * cli/cli-setshow.h (parse_cli_boolean_value)
2722         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2723         (parse_cli_var_enum): Declare.
2724         * cli/cli-utils.c: Include "cli/cli-option.h".
2725         (get_ulongest): New.
2726         * cli/cli-utils.h (get_ulongest): Declare.
2727         (check_for_argument): New overloads.
2728         * maint-test-options.c: New file.
2729
2730 2019-06-13  Pedro Alves  <palves@redhat.com>
2731
2732         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2733         parse a range if "-" is at the end of the string.
2734
2735 2019-06-13  Pedro Alves  <palves@redhat.com>
2736
2737         * cli/cli-setshow.c (parse_auto_binary_operation)
2738         (parse_cli_boolean_value): Don't allow "o".
2739
2740 2019-06-13  Pedro Alves  <palves@redhat.com>
2741
2742         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2743         * NEWS: Mention maint test-settings KIND.
2744         * maint-test-settings.c: New file.
2745
2746 2019-06-13  Pedro Alves  <palves@redhat.com>
2747
2748         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2749         completer.
2750         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2751         "set" completers.
2752
2753 2019-06-13  Pedro Alves  <palves@redhat.com>
2754
2755         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2756         after item.
2757
2758 2019-06-13  Pedro Alves  <palves@redhat.com>
2759
2760         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2761
2762 2019-06-13  Pedro Alves <palves@redhat.com>
2763
2764         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2765         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2766         call.
2767         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2768         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2769         calls.
2770         (check_for_argument): Skip spaces after argument.
2771
2772 2019-06-13  Pedro Alves  <palves@redhat.com>
2773
2774         * thread.c (thread_apply_command): Adjust TID parsing.
2775         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2776         detected before end of string.
2777         (tid_is_in_list): Error out if LIST is invalid.
2778
2779 2019-06-13  Pedro Alves  <palves@redhat.com>
2780
2781         * completer.c (complete_line_internal_1): Rewind completion word
2782         point.
2783         (completion_tracker::advance_custom_word_point_by): Change
2784         parameter type to int.
2785         * completer.h (completion_tracker::advance_custom_word_point_by):
2786         Likewise.
2787
2788 2019-06-13  Pedro Alves  <palves@redhat.com>
2789
2790         * completer.c (advance_to_completion_word): Handle delimiters.
2791
2792 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2793
2794         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2795
2796 2019-06-11  Tom Tromey  <tom@tromey.com>
2797
2798         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2799         (xmalloc_failed): Move to alloc.c.
2800         * alloc.c: New file.
2801         * Makefile.in (COMMON_SFILES): Add alloc.c.
2802
2803 2019-06-11  Tom Tromey  <tom@tromey.com>
2804
2805         * nat/linux-waitpid.c: Don't include server.h.
2806         (linux_debug): Remove.
2807         (my_waitpid): Update.
2808
2809 2019-06-11  Tom Tromey  <tromey@adacore.com>
2810
2811         * infcall.c (_initialize_infcall): Remove trailing newline from
2812         help.
2813         * user-regs.c (_initialize_user_regs): Remove trailing newline
2814         from help.
2815         * typeprint.c (_initialize_typeprint): Remove trailing newline
2816         from help.
2817         * reverse.c (_initialize_reverse): Remove trailing newlines from
2818         help.
2819         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2820         from help.
2821         * language.c (add_set_language_command): Remove trailing newline
2822         from help.
2823         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2824         help.
2825         * disasm.c (_initialize_disasm): Remove trailing newline from
2826         help.
2827         * top.c (init_main): Remove trailing newline from help.
2828         * interps.c (_initialize_interpreter): Remove trailing newline
2829         from help.
2830         * btrace.c (_initialize_btrace): Remove trailing newlines from
2831         help.
2832         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2833         from help.
2834         * python/python.c (_initialize_python): Remove trailing newline
2835         from help.
2836         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2837         help.
2838         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2839         from help.  Reformat some text.
2840         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2841         from help.
2842         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2843         newline from help.
2844
2845 2019-06-11  Tom Tromey  <tromey@adacore.com>
2846
2847         * darwin-nat.c (darwin_decode_exception_message)
2848         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2849
2850 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2851
2852         * valops.c (value_slice): Check for not allocated or not
2853         associated values.
2854
2855 2019-06-10  Tom de Vries  <tdevries@suse.de>
2856
2857         PR gdb/24618
2858         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2859         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2860         invalid.
2861
2862 2019-06-10  Tom de Vries  <tdevries@suse.de>
2863
2864         PR gdb/24611
2865         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2866         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2867
2868 2019-06-10  Tom de Vries  <tdevries@suse.de>
2869
2870         PR symtab/24545
2871         * symtab.c (struct demangled_name_entry): Add language field.
2872         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2873         static minimal symbol".  Set and use language field.
2874
2875 2019-06-10  Tom Tromey  <tromey@adacore.com>
2876
2877         * ada-lang.c (_initialize_ada_language): Update help text.
2878
2879 2019-06-10  Tom Tromey  <tromey@adacore.com>
2880
2881         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2882         with a newline.
2883         * guile/guile.c (handle_boot_error): Don't end warning with a
2884         newline.
2885         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2886         warning with a newline.
2887         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2888         newline.
2889         (s12z_frame_cache): Likewise.
2890         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2891         a newline.
2892         * solib-svr4.c (disable_probes_interface): Don't end warning with
2893         a newline.
2894         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2895         newline.
2896         * python/python.c (do_finish_initialization): Don't end warning
2897         with a newline.
2898
2899 2019-06-10  Tom Tromey  <tom@tromey.com>
2900
2901         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2902         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2903         gdbpy_enter.
2904
2905 2019-06-10  Tom Tromey  <tromey@adacore.com>
2906
2907         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2908         data.
2909         (elf_new_init): Don't call stabsread_new_init.
2910         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2911         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2912         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2913
2914 2019-06-10  Tom de Vries  <tdevries@suse.de>
2915
2916         PR symtab/16264
2917         PR symtab/24517
2918         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2919
2920 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2921
2922         * source.c (find_and_open_source): Also rewrite relative file
2923         names.
2924
2925 2019-04-26  Amos Bird  <amosbird@gmail.com>
2926
2927         * annotate.c (annotate_thread_exited): Add "thread-exited"
2928         annotation.
2929
2930 2019-06-06  Tom Tromey  <tromey@adacore.com>
2931
2932         * maint.h (class scoped_command_stats): Use
2933         DISABLE_COPY_AND_ASSIGN.
2934         <print_time>: New method.
2935         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2936         print_time.
2937         (scoped_command_stats::print_time): New method.
2938
2939 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2940
2941         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2942         instructions of lengths 6 or 8 bytes.
2943
2944 2019-06-04  Pedro Alves  <palves@redhat.com>
2945
2946         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2947
2948         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2949         * breakpoint.c (condition_completer): Likewise.
2950         * cli/cli-dump.c (scan_expression): Likewise.
2951         * common/filestuff.c (mkdir_recursive): Likewise.
2952         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2953         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2954         (gdb_abspath): Likewise.
2955         * compile/compile-cplus-types.c
2956         (compile_cplus_instance::decl_name): Likewise.
2957         * completer.c (complete_explicit_location):
2958         (signal_completer, reg_or_group_completer_1): Likewise.
2959         * cp-support.c (cp_remove_params_if_any): Likewise.
2960         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2961         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2962         * infcmd.c (strip_bg_char): Likewise.
2963         * linespec.c (copy_token_string): Likewise.
2964         * mi/mi-main.c (output_cores): Likewise.
2965         * psymtab.c (psymtab_search_name):
2966         * symfile.c (test_set_ext_lang_command): Likewise.
2967         * target.c (target_fileio_read_stralloc): Likewise.
2968         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2969         * value.c (complete_internalvar): Likewise.
2970
2971 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2972
2973         Add objfile property to gdb.Type.
2974         * NEWS: Mention Python API addition.
2975         * python/py-type.c (typy_get_objfile): New method.
2976
2977 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2978
2979         * NEWS: Mention the new set|show style [title|highlight].
2980         Mention changes to "show style", "help" and "apropos".
2981
2982 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2983
2984         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2985         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2986         instead of print_help_for_command.
2987         (print_doc_of_command): New function.
2988         (help_list): Add 'apropos -v word' suggestion.
2989         (print_help_for_command): Style the command name using title style.
2990         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2991         (_initialize_cli_cmds): Describe -v in apropos_command help.
2992
2993 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2994
2995         * cli/cli-style.h (cli_style_option): Add name in constructor,
2996         add m_name class member, add constructor with intensity,
2997         add name class function.
2998         (cli_style_option::add_setshow_commands): Remove name argument.
2999         (highlight_style, title_style): New styles.
3000         * cli/cli-style.c (do_show): New function that shows a style
3001         characteristic styling the style name with itself.
3002         (set_style_name): New function.
3003         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3004         Update all callers according to the changes in cli/cli-style.h.
3005         * utils.h (fputs_highlighted): New function.
3006         * utils.c (fputs_highlighted): Likewise.
3007
3008 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3009
3010         * NEWS: Mention new pipe command and new convenience variables.
3011
3012 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3013
3014         * cli/cli-cmds.c (pipe_command): New function.
3015         (_initialize_cli_cmds): Call add_com for pipe_command.
3016         Define | as an alias for pipe.
3017         (exit_status_set_internal_vars): New function.
3018         (shell_escape): Call exit_status_set_internal_vars.
3019         cli/cli-decode.c (find_command_name_length): Recognize | as
3020         a single character command.
3021
3022 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3023
3024         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3025         top.c (execute_command_to_ui_file): New function, mostly a copy
3026         of execute_command_to_string.
3027         (execute_command_to_string): Implement by calling
3028         execute_command_to_ui_file.
3029
3030 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3031
3032         * top.h (saved_command_line): Remove declaration.
3033         * top.c (previous_saved_command_line, previous_repeat_arguments):
3034         New variables.
3035         (saved_command_line): Make static, define together with other
3036         'repeat variables'.
3037         (dont_repeat): Clear repeat_arguments.
3038         (repeat_previous, get_saved_command_line, save_command_line):
3039         New functions.
3040         (gdb_init): Initialize saved_command_line
3041         and previous_saved_command_line.
3042         * main.c (captured_main_1): Remove saved_command_line initialization.
3043         * event-top.c (handle_line_of_input): Update to use
3044         the new 'repeat' related functions instead of direct access to
3045         saved_command_line.
3046         * command.h (repeat_previous, get_saved_command_line,
3047         save_command_line): New declarations.
3048         (dont_repeat): Add comment.
3049
3050 2019-05-30  Tom Tromey  <tromey@adacore.com>
3051
3052         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3053         Fix comment.
3054         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3055
3056 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3057
3058         PR cli/24587
3059         * completer.c (complete): Initialize variable word.
3060
3061 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3062
3063         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3064         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3065         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3066         'body' is NULL to the outter 'if', protecting the '!is_define'
3067         situation as well.
3068
3069 2019-05-29  Tom Tromey  <tromey@adacore.com>
3070
3071         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3072         (dwarf_unknown): New function.
3073         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3074         (dwarf_type_encoding_name): Use dwarf_unknown.
3075
3076 2019-05-29  Tom Tromey  <tromey@adacore.com>
3077
3078         PR c++/20020:
3079         * cp-valprint.c (cp_print_value_fields): Call
3080         cp_print_static_field inside "try".
3081
3082 2019-05-29  Tom Tromey  <tromey@adacore.com>
3083
3084         * inflow.c (struct terminal_info): Add default operator=.
3085         * configure: Rebuild.
3086         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3087         -Wdeprecated-copy-dtor, -Wredundant-move.
3088
3089 2019-05-29  Tom Tromey  <tromey@adacore.com>
3090
3091         * NEWS: Add entry.
3092         * infcmd.c (print_return_value_1): Handle finish_print
3093         option.
3094         (show_print_finish): New function.
3095         (_initialize_infcmd): Add "set/show print finish" commands.
3096         * valprint.c (user_print_options): Initialize new member.
3097         * valprint.h (struct value_print_options) <finish_print>: New
3098         member.
3099
3100 2019-05-28  Tom Tromey  <tromey@adacore.com>
3101
3102         * ada-lang.c (ada_remove_Xbn_suffix)
3103         (find_old_style_renaming_symbol)
3104         (parse_old_style_renaming): Remove.
3105         (ada_find_renaming_symbol): Don't call
3106         find_old_style_renaming_symbol.
3107         (ada_is_renaming_symbol): Rename from
3108         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3109         bool.  Now static.
3110         (ada_read_var_value): Update and simplify.
3111         * ada-exp.y (write_var_or_type): Remove old code.
3112
3113 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3114
3115         * event-top.c: Remove include comment.
3116         * inflow.c (class scoped_ignore_sigttou): Move from here...
3117         * inflow.h (class scoped_ignore_sigttou): ...to here.
3118         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3119         * top.c:  Remove include comment.
3120
3121 2019-05-27  Tom Tromey  <tom@tromey.com>
3122
3123         * NEWS: Fix typo.
3124
3125 2019-05-22  Tom Tromey  <tromey@adacore.com>
3126
3127         * target.c (target_follow_exec): Constify parameter.
3128         * target-delegates.c: Rebuild.
3129         * remote.c (remote_target::follow_exec): Constify parameter.
3130         * infrun.c (follow_exec): Constify parameter.
3131         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3132         (target_follow_exec): Likewise.
3133
3134 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3135
3136         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3137         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3138
3139 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3140
3141         * NEWS: Add debugredirect and testsuite sections.
3142
3143 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3144
3145         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3146         target descriptions using exclusively floating point register name
3147         aliases.
3148
3149 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3150
3151         PR gdb/18644:
3152         * f-lang.c (build_fortran_types): Handle the case where
3153         gdbarch_floatformat_for_type returns a nullptr.
3154
3155 2019-05-21  Tom de Vries  <tdevries@suse.de>
3156
3157         PR cli/24587
3158         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3159
3160 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3161
3162         PR gdb/18644:
3163         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3164         16-byte floats.
3165         * i386-tdep.c (i386_floatformat_for_type): Use
3166         floatformats_ia64_quad for the 16-byte floating point component
3167         within a fortran 32-byte complex number.
3168
3169 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3170
3171         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3172         delete default constructor.
3173         (find_partial_die): Update to return const struct.
3174         (partial_die_parent_scope): Move variable declaration into scope
3175         of its use and change its type to auto.
3176         (guess_partial_die_structure_name): Likewise.
3177         (partial_die_info::fixup): Likewise.
3178
3179 2019-05-17  Tom Tromey  <tromey@adacore.com>
3180
3181         * source.c (find_and_open_source): Remove cast.
3182
3183 2019-05-17  Tom Tromey  <tromey@adacore.com>
3184
3185         * annotate.c (annotate_source): Make "filename" const.
3186         * annotate.h (annotate_source): Use const.
3187
3188 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3189
3190         * disasm.c (set_disassembler_options): Send errors to stderr.
3191
3192 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3193
3194         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3195         (cli_interp_base::set_logging): Check debug_redirect.
3196         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3197         * cli/cli-logging.c (debug_redirect): Add static variable.
3198         (pop_output_files): Add default param.
3199         (handle_redirections): Print debug setting.
3200         (show_logging_command): Likewise.
3201         (_initialize_cli_logging): Add debugredirect command.
3202         * interps.c (current_interp_set_logging): Add debug_redirect
3203         parameter.
3204         * interps.h (set_logging): Add debug_redirect parameter.
3205         (current_interp_set_logging): Likewise.
3206         * mi/mi-common.h: Likewise.
3207         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3208
3209 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3210             Tom Tromey  <tromey@adacore.com>
3211
3212         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3213         directly.
3214         * cli/cli-interp.h (make_logging_output): Remove declaration.
3215         * cli/cli-logging.c (make_logging_output): Remove function.
3216         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3217         directly.
3218         * ui-file.c (tee_file::tee_file): Remove bools.
3219         (tee_file::~tee_file): Remove deletes.
3220         * ui-file.h (tee_file): Remove bools.
3221
3222 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3223
3224         * mi/mi-cmds.h (mi_cmd_complete): New function.
3225         * mi/mi-main.c (mi_cmd_complete): Likewise.
3226         * mi/mi-cmds.c: Define new MI command -complete.
3227         * NEWS: Mention new -complete command.
3228
3229 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3230
3231         * completer.h (complete): New function.
3232         * completer.c (complete): Likewise.
3233         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3234         function defined in completer.h.
3235
3236 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3237
3238         * MAINTAINERS (Write After Approval): Add myself.
3239
3240 2019-05-17  Tom de Vries  <tdevries@suse.de>
3241
3242         PR gdb/24094
3243         * dwarf2read.c (struct cu_partial_die_info): New struct.
3244         (find_partial_die): Return cu_partial_die_info.
3245         (partial_die_parent_scope, guess_partial_die_structure_name)
3246         (partial_die_info::fixup): Handle new return type of find_partial_die.
3247
3248 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3249
3250         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3251         "std::string", simplifying the algorithm.
3252
3253 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3254
3255         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3256         (stap_static_probe_ops::get_probes): Likewise.
3257
3258 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3259
3260         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3261         '-')" and "else if".
3262         (stap_parse_single_operand): Join checks for
3263         "gdbarch_stap_parse_special_token_p" and
3264         "gdbarch_stap_parse_special_token" in the same "if" statement.
3265         Invert check when verifying for operation on register
3266         displacement.
3267
3268 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3269
3270         * stap-probe.c (stap_get_opcode): Update comment.
3271         (stap_get_expected_argument_type): Likewise.
3272         (handle_stap_probe): Likewise.
3273
3274 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3275
3276         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3277         return type to 'bool'.  Adjust comment.  Use 'bool' when
3278         appropriate.
3279         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3280         * stap-probe.c (stap_parse_argument_1): Likewise.
3281         (stap_is_operator): Likewise.
3282         (stap_is_generic_prefix): Likewise.
3283         (stap_is_register_prefix): Likewise.
3284         (stap_is_register_indirection_prefix): Likewise.
3285         (stap_is_integer_prefix): Likewise.
3286         (stap_generic_check_suffix): Likewise.
3287         (stap_check_integer_suffix): Likewise.
3288         (stap_check_register_suffix): Likewise.
3289         (stap_check_register_indirection_suffix): Likewise.
3290         (stap_parse_register_operand): Likewise.
3291         (stap_parse_single_operand): Likewise.
3292         (stap_parse_argument_1): Likewise.
3293         (stap_probe::get_argument_count): Likewise.
3294         (stap_is_operator): Likewise.
3295
3296 2019-05-16  Tom Tromey  <tromey@adacore.com>
3297
3298         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3299         keyword to foreach.
3300
3301 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3302
3303         * linux-thread-db.c (try_thread_db_load_1): Change return type
3304         to bool.
3305         (try_thread_db_load): Likewise.
3306         (try_thread_db_load_from_pdir_1): Likewise.
3307         (try_thread_db_load_from_pdir): Likewise.
3308         (try_thread_db_load_from_sdir): Likewise.
3309         (try_thread_db_load_from_dir): Likewise.
3310         (thread_db_load_search): Likewise.
3311         (has_libpthread): Likewise.
3312         (thread_db_load): Likewise.
3313
3314 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3315
3316         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3317         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3318         NULL, and complain/return if that's the case.
3319
3320 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3321
3322         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3323         (advance, posn, abstract_read_memory): New functions.
3324         [struct mem_read_abstraction]: New struct.
3325         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3326
3327 2019-05-14  Tom Tromey  <tromey@adacore.com>
3328
3329         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3330         value is not lval_memory.
3331
3332 2019-05-14  Tom Tromey  <tromey@adacore.com>
3333
3334         * solib.c (info_sharedlibrary_command): Style the file name.
3335
3336 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3337
3338         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3339         (aarch64_vnv_type): Likewise.
3340         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3341         * common/tdesc.c: Likewise.
3342         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3343         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3344         * features/aarch64-fpu.xml: Add ieee half view.
3345         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3346         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3347         * gdbtypes.h (struct builtin_type): Likewise.
3348         (struct objfile_type): Likewise.
3349
3350 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3351
3352         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3353         typo.
3354         * location.h (string_to_event_location): Likewise.
3355
3356 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3357
3358         GDB 8.3 released.
3359
3360 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3361
3362         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3363         New variable declaration.
3364         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3365         New variable.
3366         (print_one_breakpoint): Use ui_out::test_flags and new global
3367         variable to compute use_fixed_output.
3368         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3369         Remove.
3370         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3371         (mi_multi_location_breakpoint_output_fixed): Remove.
3372         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3373         new variable.
3374         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3375         fix_multi_location_breakpoint_output flag if version >= 3.
3376         * ui-out.h (enum ui_out_flag)
3377         <fix_multi_location_breakpoint_output>: New enumerator.
3378
3379 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3380
3381         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3382
3383 2019-05-10  Tom Tromey  <tromey@adacore.com>
3384
3385         * ada-lang.c (catch_ada_completer): New function.
3386         (_initialize_ada_language): Use it.
3387
3388 2019-05-10  Tom Tromey  <tromey@adacore.com>
3389
3390         * thread.c (print_thread_info): Make "requested_threads" const.
3391         * gdbthread.h (print_thread_info): Make "requested_threads"
3392         const.
3393         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3394         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3395
3396 2019-05-08  Tom Tromey  <tom@tromey.com>
3397
3398         * gdbtypes.c (objfile_type_data): Change type.
3399         (objfile_type, _initialize_gdbtypes): Update.
3400
3401 2019-05-08  Tom Tromey  <tom@tromey.com>
3402
3403         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3404         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3405         (_initialize_dwarf2_frame): Update.
3406
3407 2019-05-08  Tom Tromey  <tom@tromey.com>
3408
3409         * objc-lang.c (objc_objfile_data): Change type.
3410         (find_methods): Update.
3411         (_initialize_objc_lang): Remove.
3412
3413 2019-05-08  Tom Tromey  <tom@tromey.com>
3414
3415         * stabsread.c (rs6000_builtin_type_data): Change type.
3416         (rs6000_builtin_type, _initialize_stabsread): Update.
3417
3418 2019-05-08  Tom Tromey  <tom@tromey.com>
3419
3420         * mips-tdep.c (mips_pdr_data): Remove.
3421         (_initialize_mips_tdep): Update.
3422
3423 2019-05-08  Tom Tromey  <tom@tromey.com>
3424
3425         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3426         (hppa_init_objfile_priv_data, read_unwind_info)
3427         (find_unwind_entry, _initialize_hppa_tdep): Update.
3428
3429 2019-05-08  Tom Tromey  <tom@tromey.com>
3430
3431         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3432         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3433         on obstack.
3434         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3435
3436 2019-05-08  Tom Tromey  <tom@tromey.com>
3437
3438         * mdebugread.c (basic_type_data): Change type.
3439         (basic_type, _initialize_mdebugread): Update.
3440
3441 2019-05-08  Tom Tromey  <tom@tromey.com>
3442
3443         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3444
3445 2019-05-08  Tom Tromey  <tom@tromey.com>
3446
3447         * nto-tdep.c (nto_inferior_data_reg): Change type.
3448         (nto_inferior_data): Update.
3449         (nto_inferior_data_cleanup, nto_new_inferior_data)
3450         (_initialize_nto_tdep): Remove.
3451         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3452
3453 2019-05-08  Tom Tromey  <tom@tromey.com>
3454
3455         * ada-lang.c (struct ada_inferior_data): Add initializers.
3456         (ada_inferior_data): Change type.
3457         (ada_inferior_data_cleanup): Remove.
3458         (get_ada_inferior_data, ada_inferior_exit)
3459         (struct ada_pspace_data): Add initializers, destructor.
3460         (ada_pspace_data_handle): Change type.
3461         (get_ada_pspace_data): Update.
3462         (ada_pspace_data_cleanup): Remove.
3463
3464 2019-05-08  Tom Tromey  <tom@tromey.com>
3465
3466         * coffread.c (struct coff_symfile_info): Add initializers.
3467         (coff_objfile_data_key): Move lower.  Change type.
3468         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3469         Update.
3470         (coff_free_info): Remove.
3471
3472 2019-05-08  Tom Tromey  <tom@tromey.com>
3473
3474         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3475         (fbsd_pspace_data_handle): Move lower.  Change type.
3476         (get_fbsd_pspace_data): Update.
3477         (fbsd_pspace_data_cleanup): Remove.
3478         (_initialize_fbsd_tdep): Update.
3479
3480 2019-05-08  Tom Tromey  <tom@tromey.com>
3481
3482         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3483         (get_ada_tasks_pspace_data): Update.
3484         (ada_tasks_pspace_data_cleanup): Remove.
3485         (_initialize_tasks): Update.
3486         (ada_tasks_inferior_data_handle): Change type.
3487         (get_ada_tasks_inferior_data): Update.
3488         (ada_tasks_inferior_data_cleanup): Remove.
3489         (struct ada_tasks_pspace_data): Add initializers.
3490
3491 2019-05-08  Tom Tromey  <tom@tromey.com>
3492
3493         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3494         * symfile-debug.c (debug_sym_get_probes): Change type.
3495         * stap-probe.c (handle_stap_probe):
3496         (stap_static_probe_ops::get_probes): Change type.
3497         * probe.h (class static_probe_ops) <get_probes>: Change type.
3498         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3499         (parse_probes_in_pspace): Update.
3500         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3501         Update.
3502         (any_static_probe_ops::get_probes): Change type.
3503         * elfread.c (elfread_data): New typedef.
3504         (probe_key): Change type.
3505         (elf_get_probes): Likewise.  Update.
3506         (probe_key_free): Remove.
3507         (_initialize_elfread): Update.
3508         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3509         Change type.
3510         (dtrace_process_dof_probe, dtrace_process_dof)
3511         (dtrace_static_probe_ops::get_probe): Change type.
3512
3513 2019-05-08  Tom Tromey  <tom@tromey.com>
3514
3515         * xcoffread.c (struct xcoff_symfile_info): Rename from
3516         coff_symfile_info.  Add initializers.
3517         (xcoff_objfile_data_key): Move lower.  Change type.
3518         (XCOFF_DATA): Rewrite.
3519         (xcoff_free_info): Remove.
3520         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3521         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3522         (xcoff_initial_scan): Update.
3523
3524 2019-05-08  Tom Tromey  <tom@tromey.com>
3525
3526         * solib-svr4.c (struct svr4_info): Add initializers and
3527         destructor.
3528         <probes_table>: Now an htab_up.
3529         (solib_svr4_pspace_data): Change type.
3530         (free_probes_table): Simplify.
3531         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3532         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3533         (probes_table_remove_objfile_probes, register_solib_event_probe)
3534         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3535         (_initialize_svr4_solib): Update.
3536
3537 2019-05-08  Tom Tromey  <tom@tromey.com>
3538
3539         * remote.c (remote_pspace_data): Change type.
3540         (remote_pspace_data_cleanup): Remove.
3541         (get_remote_exec_file, set_pspace_remote_exec_file)
3542         (_initialize_remote): Update.
3543
3544 2019-05-08  Tom Tromey  <tom@tromey.com>
3545
3546         * breakpoint.c (breakpoint_objfile_key): Change type.
3547         (get_breakpoint_objfile_data): Update.
3548         (free_breakpoint_objfile_data): Remove.
3549         (_initialize_breakpoint): Update.
3550
3551 2019-05-08  Tom Tromey  <tom@tromey.com>
3552
3553         * linux-tdep.c (struct linux_info): Add initializers.
3554         (linux_inferior_data): Move.  Change type.
3555         (invalidate_linux_cache_inf): Update.
3556         (linux_inferior_data_cleanup): Remove.
3557         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3558
3559 2019-05-08  Tom Tromey  <tom@tromey.com>
3560
3561         * auxv.c (auxv_inferior_data): Move.  Change type.
3562         (auxv_inferior_data_cleanup): Remove.
3563         (invalidate_auxv_cache_inf): Rewrite.
3564         (get_auxv_inferior_data, _initialize_auxv): Update.
3565
3566 2019-05-08  Tom Tromey  <tom@tromey.com>
3567
3568         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3569         (symfile_debug_objfile_data_key): Change type.
3570         (symfile_debug_installed, debug_qf_has_symbols)
3571         (debug_qf_find_last_source_symtab)
3572         (debug_qf_forget_cached_source_info)
3573         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3574         (debug_qf_print_stats, debug_qf_dump)
3575         (debug_qf_expand_symtabs_for_function)
3576         (debug_qf_expand_all_symtabs)
3577         (debug_qf_expand_symtabs_with_fullname)
3578         (debug_qf_map_matching_symbols)
3579         (debug_qf_expand_symtabs_matching)
3580         (debug_qf_find_pc_sect_compunit_symtab)
3581         (debug_qf_map_symbol_filenames)
3582         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3583         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3584         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3585         (debug_sym_read_linetable, debug_sym_relocate): Update.
3586         (symfile_debug_free_objfile): Remove.
3587         (install_symfile_debug_logging, _initialize_symfile_debug):
3588         Update.
3589
3590 2019-05-08  Tom Tromey  <tom@tromey.com>
3591
3592         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3593         allocate_on_obstack.
3594         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3595         (get_dwarf2_per_objfile): Update.
3596         (set_dwarf2_per_objfile): Remove.
3597         (dwarf2_has_info, dwarf2_get_section_info): Update.
3598         (dwarf2_free_objfile): Remove.
3599         (_initialize_dwarf2_read): Update.
3600
3601 2019-05-08  Tom Tromey  <tom@tromey.com>
3602
3603         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3604         initializers.
3605         <unsupported_script_warning_printed,
3606         script_not_found_warning_printed>: Now bool.
3607         (auto_load_pspace_data): Change type.
3608         (~auto_load_pspace_info): Rename from
3609         auto_load_pspace_data_cleanup.
3610         (get_auto_load_pspace_data, init_loaded_scripts_info)
3611         (clear_section_scripts, maybe_print_unsupported_script_warning)
3612         (maybe_print_script_not_found_warning, _initialize_auto_load):
3613         Update.
3614
3615 2019-05-08  Tom Tromey  <tom@tromey.com>
3616
3617         * objfiles.c (objfile_pspace_info): Add destructor and
3618         initializers.
3619         (objfiles_pspace_data): Change type.
3620         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3621         (get_objfile_pspace_data): Update.
3622         (objfiles_bfd_data): Change type.
3623         (get_objfile_bfd_data): Update.
3624         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3625
3626 2019-05-08  Tom Tromey  <tom@tromey.com>
3627
3628         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3629         Change type.
3630         (get_catch_syscall_inferior_data): Update.
3631         (catch_syscall_inferior_data_cleanup): Remove.
3632         (_initialize_break_catch_syscall): Update.
3633
3634 2019-05-08  Tom Tromey  <tom@tromey.com>
3635
3636         * inflow.c (struct terminal_info): Add destructor and
3637         initializers.
3638         (inflow_inferior_data): Change type.
3639         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3640         (get_inflow_inferior_data, inflow_inferior_exit)
3641         (swap_terminal_info, _initialize_inflow): Update.
3642
3643 2019-05-08  Tom Tromey  <tom@tromey.com>
3644
3645         * target-dcache.c (target_dcache_cleanup): Remove.
3646         (target_dcache_aspace_key): Change type.
3647         (target_dcache_init_p, target_dcache_invalidate)
3648         (target_dcache_get, target_dcache_get_or_init)
3649         (_initialize_target_dcache): Update.
3650         * dcache.h (struct dcache_deleter): New.
3651
3652 2019-05-08  Tom Tromey  <tom@tromey.com>
3653
3654         * symtab.c (struct symbol_cache): Add destructor and
3655         initializers.
3656         (symbol_cache_key): Move.  Change type.
3657         (make_symbol_cache, free_symbol_cache): Remove.
3658         (get_symbol_cache): Update.
3659         (symbol_cache_cleanup): Remove.
3660         (ALL_PSPACES, symbol_cache_flush)
3661         (maintenance_print_symbol_cache)
3662         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3663         Update.
3664
3665 2019-05-08  Tom Tromey  <tom@tromey.com>
3666
3667         * symtab.c (struct main_info): Add destructor and initializers.
3668         (main_progspace_key): Move.  Change type.
3669         (get_main_info): Update.
3670         (main_info_cleanup): Remove.
3671         (_initialize_symtab): Update.
3672
3673 2019-05-08  Tom Tromey  <tom@tromey.com>
3674
3675         * registry.h (DECLARE_REGISTRY): Define the _key class.
3676
3677 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3678
3679         * NEWS: Merge two 'New commands' sections.
3680
3681 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3682
3683         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3684         parameter and use Ada language definition instead.
3685         (ada_val_print_ptr): Remove unused language parameter.
3686         (ada_val_print_num): Remove language parameter and use Ada language
3687         definition instead.
3688         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3689         parameter.
3690         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3691         parameter and use Ada language definition instead.
3692         (ada_val_print_1): Update all ada_val_print_xxx calls.
3693         Remove language parameter.
3694         (ada_val_print): Update ada_val_print_1 call.
3695
3696 2019-05-08  Tom Tromey  <tromey@adacore.com>
3697
3698         * remote.c (remote_hw_watchpoint_limit)
3699         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3700         Now static.
3701
3702 2019-05-08  Tom Tromey  <tromey@adacore.com>
3703
3704         * maint.c (_initialize_maint_cmds): Move initialization code to
3705         remote.c.
3706         (watchdog, show_watchdog): Move to remote.c.
3707         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3708         "watchdog" static.
3709         (_initialize_remote): Move initialization code from maint.c.
3710         * defs.h (watchdog): Don't declare.
3711
3712 2019-05-08  Tom Tromey  <tromey@adacore.com>
3713
3714         * tui/tui-interp.c: Include main.h.
3715         * interps.c: Include main.h.
3716         * main.h (interpreter_p): Declare.
3717         * defs.h (interpreter_p): Don't declare.
3718
3719 2019-05-08  Tom Tromey  <tromey@adacore.com>
3720
3721         * dwarf2loc.c: Include dwarf2read.h.
3722         * defs.h (read_unsigned_leb128): Don't declare.
3723         * dwarf2read.h (read_unsigned_leb128): Declare.
3724
3725 2019-05-08  Tom Tromey  <tromey@adacore.com>
3726
3727         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3728         method.
3729
3730 2019-05-08  Tom Tromey  <tromey@adacore.com>
3731
3732         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3733         when no wrap column is set.
3734
3735 2019-05-08  Tom Tromey  <tromey@adacore.com>
3736
3737         * c-lang.c (c_get_string): Handle non-C-style arrays.
3738
3739 2019-05-08  Tom Tromey  <tromey@adacore.com>
3740
3741         * typeprint.c (print_offset_data::update): Print the bit offset,
3742         not the number of bits remaining.
3743
3744 2019-05-08  Tom Tromey  <tromey@adacore.com>
3745
3746         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3747         padding at end of comment.
3748
3749 2019-05-08  Tom Tromey  <tromey@adacore.com>
3750
3751         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3752         Compare main types.
3753
3754 2019-05-06  Tom Tromey  <tom@tromey.com>
3755
3756         * common/scoped_mmap.c: Include common-defs.h.
3757         * common/scoped_mmap.h: Don't include config.h.
3758
3759 2019-05-04  Tom Tromey  <tom@tromey.com>
3760
3761         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3762         (struct aarch64_call_info): Add initializers.
3763         <si>: Now a std::vector.
3764         (pass_on_stack, aarch64_push_dummy_call): Update.
3765
3766 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3767             Tom Tromey  <tom@tromey.com>
3768
3769         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3770         (ppc_threads): Now a std::vector.  Now static.
3771         (hwdebug_find_thread_points_by_tid)
3772         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3773         Update.
3774
3775 2019-05-04  Tom Tromey  <tom@tromey.com>
3776
3777         * arc-tdep.c (arc_tdesc_init): Return bool.
3778
3779 2019-05-04  Tom Tromey  <tom@tromey.com>
3780
3781         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3782         Use gdb_assert_not_reached.
3783
3784 2019-05-04  Tom Tromey  <tom@tromey.com>
3785
3786         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3787         "false".
3788
3789 2019-05-04  Tom Tromey  <tom@tromey.com>
3790
3791         * arc-tdep.c (arc_tdesc_init): Use bool.
3792
3793 2019-05-04  Tom Tromey  <tom@tromey.com>
3794
3795         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3796
3797 2019-05-04  Tom Tromey  <tom@tromey.com>
3798
3799         * cli/cli-cmds.c (valid_command_p): Return bool.
3800
3801 2019-05-04  Tom Tromey  <tom@tromey.com>
3802
3803         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3804         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3805
3806 2019-05-04  Raul Tambre  <raul@tambre.ee>
3807
3808         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3809         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3810         operator for comparison.
3811
3812 2019-05-04  Tom Tromey  <tom@tromey.com>
3813
3814         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3815         (lookup_partial_symbol, print_partial_symbols)
3816         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3817         (psymbol_compare): Update.
3818         (add_psymbol_to_bcache): Clear the entire psymbol.
3819         (maintenance_check_psymtabs): Update.
3820         * psympriv.h (struct partial_symbol): Don't derive from
3821         general_symbol_info.
3822         <obj_section, unrelocated_address, address,
3823         set_unrelocated_address>: Update.
3824         <ginfo>: New member.
3825         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3826         (debug_names::write_psymbols): Update.
3827
3828 2019-05-04  Tom de Vries  <tdevries@suse.de>
3829
3830         * contrib/cc-with-tweaks.sh: Support -n arg.
3831
3832 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3833
3834         * corelow.c (core_target::detach): Ensure frame cache and
3835         register caches are cleared.
3836         inferior.c (exit_inferior_1): Likewise.
3837
3838 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3839             Tom Tromey  <tom@tromey.com>
3840
3841         * dictionary.c (collate_pending_symbols_by_language): Remove
3842         "struct" from foreach.
3843         * symtab.c (lookup_global_symbol_from_objfile)
3844         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3845         foreach.
3846         * ser-tcp.c (net_open): Remove "struct" from foreach.
3847         * objfiles.c (objfile_relocate, objfile_rebase)
3848         (objfile_has_symbols): Remove "struct" from foreach.
3849         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3850         from foreach.
3851         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3852         foreach.
3853         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3854         "struct" from foreach.
3855         * ada-lang.c (create_excep_cond_exprs)
3856         (ada_exception_catchpoint_cond_string): Remove "struct" from
3857         foreach.
3858
3859 2019-05-03  Tom Tromey  <tromey@adacore.com>
3860
3861         * ada-exp.y (convert_char_literal): Check suffix of each
3862         enumerator.
3863
3864 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3865
3866         PR ada/21406:
3867         * ada-exp.y (yywrap): Don't define.
3868         * ada-lex.l (%option): Add noyywrap
3869         (yywrap): Remove.
3870
3871 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3872
3873         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3874         _WIN32_WINNT to the XP level, unless already defined to a higher
3875         level.
3876
3877         * unittests/parse-connection-spec-selftests.c:
3878         * ser-tcp.c:
3879         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3880         override.
3881
3882         * symfile.c (find_separate_debug_file): Remove colon from the
3883         drive spec of DOS/Windows file names of the target, so that the
3884         file name produced from DEBUGDIR and the target's directory will
3885         be valid on DOS/Windows systems.
3886
3887 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3888
3889         * rust-lang.c (val_print_struct): Handle printing structures
3890         containing strings.
3891
3892 2019-05-02  Tom Tromey  <tromey@adacore.com>
3893
3894         * valarith.c (_initialize_valarith): Remove.
3895
3896 2019-05-01  Tom Tromey  <tromey@adacore.com>
3897
3898         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3899         bitfields.
3900
3901 2019-05-01  Tom Tromey  <tromey@adacore.com>
3902
3903         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3904         for big-endian copies.
3905
3906 2019-04-30  Ali Tamur  <tamur@google.com>
3907         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3908         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3909         (read_3_bytes): New function.
3910
3911 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3912
3913         * windows-nat.c (main_thread_id): Delete.
3914         (handle_output_debug_string): Replace main_thread_id by
3915         current_event.dwThreadId.
3916         (fake_create_process): Likewise.
3917         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3918         Do not set main_thread_id.
3919         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3920         current_event.dwThreadId.
3921         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3922
3923 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3924
3925         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3926         Use current_event.dwThreadId instead of main_thread_id.
3927
3928 2019-04-30  Tom Tromey  <tromey@adacore.com>
3929
3930         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3931         (create_excep_cond_exprs): Iterate over program spaces.
3932         (ada_exception_catchpoint_cond_string): Examine all minimal
3933         symbols for exception types.
3934
3935 2019-04-30  Tom Tromey  <tromey@adacore.com>
3936
3937         PR c++/24470:
3938         * dwarf2read.c (process_structure_scope): Handle case where type
3939         has template parameters but no symbol was created.
3940
3941 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3942             Chris January  <chris.january@arm.com>
3943
3944         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3945         qualifier.
3946         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3947
3948 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3949
3950         * f-typeprint.c (f_print_type): Update rules for printing
3951         whitespace.
3952         (f_type_print_varspec_suffix): Likewise.
3953
3954 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3955             Chris January  <chris.january@arm.com>
3956
3957         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3958         function arguments.
3959
3960 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3961
3962         * f-lang.c (build_fortran_types): Change name of void type to
3963         lower case.
3964         * f-typeprint.c (f_type_print_base): Print the name of the void
3965         type, rather than a fixed string.
3966         * f-valprint.c (f_decorations): Use lower case void string.
3967
3968 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3969             Chris January  <chris.january@arm.com>
3970
3971         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3972         types for Fortran.
3973
3974 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3975             Chris January  <chris.january@arm.com>
3976             David Lecomber  <david.lecomber@arm.com>
3977
3978         * f-exp.y (BINOP_INTRINSIC): New token.
3979         (exp): New parser rule handling BINOP_INTRINSIC.
3980         (f77_keywords): Add new builtin procedures.
3981         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3982         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3983         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3984         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3985         (print_unop_subexp_f): New function.
3986         (print_binop_subexp_f): New function.
3987         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3988         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3989         (dump_subexp_body_f): Likewise.
3990         (operator_check_f): Likewise.
3991         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3992         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3993
3994 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3995
3996         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3997         UNOP_KIND.
3998         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3999         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4000         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4001         (operator_length_f): New fuction.
4002         (print_subexp_f): New function.
4003         (op_name_f): New function.
4004         (dump_subexp_body_f): New function.
4005         (operator_check_f): New function.
4006         (exp_descriptor_f): Replace standard expression handling functions
4007         with new functions.
4008         * gdb/fortran-operator.def: New file.
4009         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4010         * gdb/std-operator.def: Remove UNOP_KIND.
4011
4012 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4013
4014         * std-operator.def: Remove unbalanced, stray double quote
4015         character.
4016
4017 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4018             Chris January  <chris.january@arm.com>
4019             Daniel Everett  <daniel.everett@arm.com>
4020             Nick Forrington  <nick.forrington@arm.com>
4021             Richard Bunt  <richard.bunt@arm.com>
4022
4023         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4024         of depth when printing anonymous structs or unions.
4025         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4026         Don't print either the top-level value, or the children if the
4027         max-depth is exceeded.
4028         (ppscm_print_children): When printing the key of a map, allow one
4029         extra level of depth.
4030         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4031         print either the top-level value, or the children if the max-depth
4032         is exceeded.
4033         (print_children): When printing the key of a map, allow one extra
4034         level of depth.
4035         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4036         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4037         (user_print_options): Initialise max_depth field.
4038         (val_print_scalar_or_string_type_p): New function.
4039         (val_print): Check to see if the max depth has been reached.
4040         (val_print_check_max_depth): Define new function.
4041         (show_print_max_depth): New function.
4042         (_initialize_valprint): Add 'print max-depth' option.
4043         * valprint.h (struct value_print_options) <max_depth>: New field.
4044         (val_print_check_max_depth): Declare new function.
4045         * NEWS: Document new feature.
4046
4047 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4048
4049         * ada-lang.c (ada_language_defn): Initialise new field.
4050         * c-lang.c (c_is_string_type_p): New function.
4051         (c_language_defn): Initialise new field.
4052         (cplus_language_defn): Initialise new field.
4053         (asm_language_defn): Initialise new field.
4054         (minimal_language_defn): Initialise new field.
4055         * c-lang.h (c_is_string_type_p): Declare new function.
4056         * d-lang.c (d_language_defn): Initialise new field.
4057         * f-lang.c (f_is_string_type_p): New function.
4058         (f_language_defn): Initialise new field.
4059         * go-lang.c (go_is_string_type_p): New function.
4060         (go_language_defn): Initialise new field.
4061         * language.c (default_is_string_type_p): New function.
4062         (unknown_language_defn): Initialise new field.
4063         (auto_language_defn): Initialise new field.
4064         * language.h (struct language_defn) <la_is_string_type_p>: New
4065         member variable.
4066         (default_is_string_type_p): Declare new function.
4067         * m2-lang.c (m2_language_defn): Initialise new field.
4068         * objc-lang.c (objc_language_defn): Initialise new field.
4069         * opencl-lang.c (opencl_language_defn): Initialise new field.
4070         * p-lang.c (pascal_is_string_type_p): New function.
4071         (pascal_language_defn): Initialise new field.
4072         * rust-lang.c (rust_is_string_type_p): New function.
4073         (rust_language_defn): Initialise new field.
4074
4075 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4076
4077         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4078         New field.
4079         * ada-lang.c (ada_language_defn): Initialise new field.
4080         * c-lang.c (c_language_defn): Likewise.
4081         (cplus_language_defn): Likewise.
4082         (asm_language_defn): Likewise.
4083         (minimal_language_defn): Likewise.
4084         * d-lang.c (d_language_defn): Likewise.
4085         * f-lang.c (f_language_defn): Likewise.
4086         * go-lang.c (go_language_defn): Likewise.
4087         * language.c (unknown_language_defn): Likewise.
4088         (auto_language_defn): Likewise.
4089         * m2-lang.c (m2_language_defn): Likewise.
4090         * objc-lang.c (objc_language_defn): Likewise.
4091         * opencl-lang.c (opencl_language_defn): Likewise.
4092         * p-lang.c (pascal_language_defn): Likewise.
4093         * rust-lang.c (rust_language_defn): Likewise.
4094
4095 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4096
4097         * ada-lang.c (ada_is_character_type): Change return type to bool.
4098         (ada_is_string_type): Likewise.
4099         * ada-lang.h (ada_is_character_type): Update declaration
4100         (ada_is_string_type): Likewise.
4101
4102 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4103
4104         Support style in 'frame|thread apply'
4105
4106         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4107         * record.c (record_start, record_stop): Update callers of
4108         execute_command_to_string with false.
4109         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4110         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4111         methods.
4112         (class string_file): New constructor with term_out parameter.
4113         Override methods term_out and can_emit_style_escape.  New member
4114         term_out.
4115         (class stdio_file): Override can_emit_style_escape.
4116         (class tee_file): Override term_out and can_emit_style_escape.
4117         * utils.h (can_emit_style_escape): Remove.
4118         * utils.c (can_emit_style_escape): Likewise.
4119         Update all callers of can_emit_style_escape (SOMESTREAM) to
4120         SOMESTREAM->can_emit_style_escape.
4121         * source-cache.c (source_cache::get_source_lines): Likewise.
4122         * stack.c (frame_apply_command_count): Call execute_command_to_string
4123         passing the term_out characteristic of the current gdb_stdout.
4124         * thread.c (thr_try_catch_cmd): Likewise.
4125         * top.c (execute_command_to_string): pass term_out parameter
4126         to construct the string_file for the command output.
4127         * ui-file.c (term_cli_styling): New function (most code moved
4128         from utils.c can_emit_style_escape).
4129         (string_file::string_file, string_file::can_emit_style_escape,
4130         stdio_file::can_emit_style_escape, tee_file::term_out,
4131         tee_file::can_emit_style_escape): New functions.
4132
4133 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4134
4135         * NEWS: Mention the new set|show may-call-functions.
4136         * infcall.c (may_call_functions_p): New variable.
4137         (show_may_call_functions_p): New function.
4138         (call_function_by_hand_dummy): Throws an error if not
4139         may-call-functions.
4140         (_initialize_infcall): Call add_setshow_boolean_cmd for
4141         may-call-functions.
4142
4143 2019-04-25  Keith Seitz  <keiths@redhat.com>
4144
4145         PR c++/24367
4146         * cp-support.c (inspect_type): Don't attempt substitutions
4147         of symbol with the same name.
4148
4149 2019-04-25  Tom Tromey  <tromey@adacore.com>
4150
4151         PR gdb/24475:
4152         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4153         static.
4154
4155 2019-04-25  Tom Tromey  <tromey@adacore.com>
4156
4157         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4158         rvalue reference.
4159         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4160         (gdb_xml_parser::parse): Use std::move.
4161         * python/python-internal.h (gdbpy_convert_exception): Take a const
4162         reference.
4163         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4164         std::move.
4165         * python/py-utils.c (gdbpy_convert_exception): Take a const
4166         reference.
4167         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4168         Use std::move.
4169         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4170         Use std::move.
4171         * mi/mi-main.c (mi_print_exception): Take a const reference.
4172         * main.c (handle_command_errors): Take a const reference.
4173         * linespec.c (parse_linespec): Use std::move.
4174         * infcall.c (run_inferior_call): Use std::move.
4175         (call_function_by_hand_dummy): Use std::move.
4176         * exec.c (try_open_exec_file): Use std::move.
4177         * exceptions.h (exception_print, exception_fprintf)
4178         (exception_print_same): Update.
4179         * exceptions.c (print_exception, exception_print)
4180         (exception_fprintf, exception_print_same): Change parameters to
4181         const reference.
4182         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4183         * common/new-op.c: Use std::move.
4184         * common/common-exceptions.h (struct gdb_exception): Add move
4185         constructor.
4186         (struct gdb_exception_error, struct gdb_exception_quit, struct
4187         gdb_quit_bad_alloc): Change constructor to move constructor.
4188         (throw_exception): Change parameter to rvalue reference.
4189         * common/common-exceptions.c (throw_exception): Take rvalue
4190         reference.
4191         * cli/cli-interp.c (safe_execute_command): Use std::move.
4192         * breakpoint.c (insert_bp_location, location_to_sals): Use
4193         std::move.
4194
4195 2019-04-25  Tom Tromey  <tromey@adacore.com>
4196
4197         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4198         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4199         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4200         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4201         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4202         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4203         guile/scm-value.c: Use unpack.
4204         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4205         gdbscm_gdb_exception.
4206         (gdbscm_throw_gdb_exception): Likewise.
4207         (struct gdbscm_gdb_exception): New.
4208         (unpack): New function.
4209         (gdbscm_wrap): Use unpack.
4210
4211 2019-04-25  Tom Tromey  <tromey@adacore.com>
4212
4213         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4214         (gdb_rl_callback_handler): Use std::move.
4215         * common/common-exceptions.h (struct gdb_exception): Add move
4216         assignment operator.
4217         (throw_exception_sjlj): Change "exception" to const reference.
4218         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4219         (throw_exception_sjlj): Change "exception" to const reference.
4220
4221 2019-04-25  Tom Tromey  <tromey@adacore.com>
4222
4223         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4224         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4225         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4226         Update.
4227         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4228         Update.
4229         * mi/mi-interp.c (mi_interp::exec): Update.
4230         * linespec.c (parse_linespec): Update.
4231         * infcall.c (run_inferior_call): Update.
4232         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4233         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4234         (gdbscm_lookup_global_symbol): Update.
4235         * guile/scm-param.c (gdbscm_parameter_value): Update.
4236         * guile/scm-frame.c (gdbscm_frame_read_register)
4237         (gdbscm_frame_read_var): Update.
4238         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4239         * exec.c (try_open_exec_file): Update.
4240         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4241         (gdb_rl_callback_handler): Update.
4242         * common/common-exceptions.h (exception_none): Don't declare.
4243         * common/common-exceptions.c (exception_none): Don't define.
4244         (struct catcher) <exception>: Update.
4245         * cli/cli-interp.c (safe_execute_command): Update.
4246         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4247
4248 2019-04-25  Ali Tamur  <tamur@google.com>
4249
4250         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4251         (read_attribute_value): Likewise.
4252         (dwarf2_read_addr_index): Update comment.
4253         (read_str_index): Add DW_FORM_strx.
4254         (dwarf2_string_attr): Likewise.
4255         (dwarf2_const_value_attr): Likewise.
4256         (dump_die_shallow): Likewise.
4257         (dwarf2_fetch_constant_bytes): Likewise.
4258         (skip_form_bytes): Likewise.
4259         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4260
4261 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4262
4263         PR corefiles/11608
4264         PR corefiles/18187
4265         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4266         OFFSET.  Verify if current mapping contains an ELF header.
4267         (linux_find_memory_regions_full): Adjust call to
4268         dump_mapping_p.
4269
4270 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4271             Kang Li <kanglictf@gmail.com>
4272
4273         PR gdb/21600
4274
4275         * dwarf2-frame.c (read_initial_length): Be consistent about using
4276         unsigned representation of length.
4277         (decode_frame_entry_1): Likewise.  Check for wraparound of
4278         end pointer as well as buffer overflow.
4279
4280 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4281
4282         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4283         "vq".
4284
4285 2019-04-24  Tom Tromey  <tromey@adacore.com>
4286
4287         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4288
4289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4290
4291         * s12z-tdep.c (s12z_unwind_pc): Delete.
4292         (s12z_unwind_sp): Delete.
4293         (s12z_gdbarch_init): Don't register deleted functions with
4294         gdbarch.
4295
4296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4297
4298         * rl78-tdep.c (rl78_unwind_sp): Delete.
4299         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4300
4301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4302
4303         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4304         (xstormy16_unwind_pc): Delete.
4305         (xstormy16_dummy_id): Delete.
4306         (xstormy16_gdbarch_init): Don't register deleted functions with
4307         gdbarch.
4308
4309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4310
4311         * vax-tdep.c (vax_unwind_pc): Delete.
4312         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4313
4314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * v850-tdep.c (v850_unwind_sp): Delete.
4317         (v850_unwind_pc): Delete.
4318         (v850_dummy_id): Delete.
4319         (v850_gdbarch_init): Don't register deleted functions with
4320         gdbarch.
4321
4322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4323
4324         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4325         (tilegx_unwind_pc): Delete.
4326         (tilegx_unwind_dummy_id): Delete.
4327         (tilegx_gdbarch_init): Don't register deleted functions with
4328         gdbarch.
4329
4330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4331
4332         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4333         (tic6x_dummy_id): Delete.
4334         (tic6x_gdbarch_init): Don't register deleted functions with
4335         gdbarch.
4336
4337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4338
4339         * sparc-tdep.c (sparc_unwind_pc): Delete.
4340         (sparc32_gdbarch_init): Don't register deleted function with
4341         gdbarch.
4342
4343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4344
4345         * sh-tdep.c (sh_unwind_sp): Delete.
4346         (sh_unwind_pc): Delete.
4347         (sh_dummy_id): Delete.
4348         (sh_gdbarch_init): Don't register deleted functions with
4349         gdbarch.
4350
4351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4352
4353         * score-tdep.c (score_unwind_sp): Delete.
4354         (score_unwind_pc): Delete.
4355         (score_dummy_id): Delete.
4356         (score_gdbarch_init): Don't register deleted functions with
4357         gdbarch.
4358
4359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * rx-tdep.c (rx_unwind_pc): Delete.
4362         (rx_unwind_sp): Delete.
4363         (rx_dummy_id): Delete.
4364         (rx_gdbarch_init): Don't register deleted functions with
4365         gdbarch.  Update comment.
4366
4367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4368
4369         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4370         (rs6000_dummy_id): Delete.
4371         (rs6000_gdbarch_init): Don't register deleted functions with
4372         gdbarch.
4373
4374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4375
4376         * or1k-tdep.c (or1k_dummy_id): Delete.
4377         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4378
4379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4380
4381         * nios2-tdep.c (nios2_dummy_id): Delete.
4382         (nios2_unwind_sp): Delete.
4383         (nios2_gdbarch_init): Don't register deleted functions with
4384         gdbarch.
4385
4386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4387
4388         * nds32-tdep.c (nds32_dummy_id): Delete.
4389         (nds32_unwind_pc): Delete.
4390         (nds32_unwind_sp): Delete.
4391         (nds32_gdbarch_init): Don't register deleted functions with
4392         gdbarch.
4393
4394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4395
4396         * msp430-tdep.c (msp430_unwind_pc): Delete.
4397         (msp430_unwind_sp): Delete.
4398         (msp430_dummy_id): Delete.
4399         (msp430_gdbarch_init): Don't register deleted functions with
4400         gdbarch.
4401
4402 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4403
4404         * moxie-tdep.c (moxie_unwind_sp): Delete.
4405         (moxie_unwind_pc): Delete.
4406         (moxie_dummy_id): Delete.
4407         (moxie_gdbarch_init): Don't register deleted functions with
4408         gdbarch.
4409
4410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4411
4412         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4413         (mn10300_unwind_pc): Delete.
4414         (mn10300_unwind_sp): Delete.
4415         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4416         mn10300_unwind_sp.
4417         (mn10300_frame_unwind_init): Don't register deleted functions with
4418         gdbarch.
4419
4420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4421
4422         * mep-tdep.c (mep_unwind_pc): Delete.
4423         (mep_unwind_sp): Delete.
4424         (mep_dummy_id): Delete.
4425         (mep_gdbarch_init): Don't register deleted functions with
4426         gdbarch.
4427
4428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4429
4430         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4431         (m68hc11_unwind_sp): Delete.
4432         (m68hc11_gdbarch_init): Don't register deleted functions with
4433         gdbarch.
4434
4435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4436
4437         * m32r-tdep.c (m32r_unwind_sp): Delete.
4438         (m32r_unwind_pc): Delete.
4439         (m32r_dummy_id): Delete.
4440         (m32r_gdbarch_init): Don't register deleted functions with
4441         gdbarch.
4442
4443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4444
4445         * m32c-tdep.c (m32c_unwind_pc): Delete.
4446         (m32c_unwind_sp): Delete.
4447         (m32c_dummy_id): Delete.
4448         (m32c_gdbarch_init): Don't register deleted functions with
4449         gdbarch.
4450
4451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4452
4453         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4454         (lm32_unwind_pc): Delete.
4455         (lm32_dummy_id): Delete.
4456         (lm32_gdbarch_init): Don't register deleted functions with
4457         gdbarch.
4458
4459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4462         (iq2000_unwind_pc): Delete.
4463         (iq2000_dummy_id): Delete.
4464         (iq2000_gdbarch_init): Don't register deleted functions with
4465         gdbarch.
4466
4467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4468
4469         * nds32-tdep.c (nds32_type_align): Delete.
4470         (nds32_push_dummy_call): Use type_align instead.
4471
4472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4473
4474         * arm-tdep.c (arm_type_align): Only handle vector override case.
4475         (arm_push_dummy_call): Use type_align.
4476         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4477
4478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4479
4480         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4481         case.
4482         (pass_on_stack): Use type_align.
4483         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4484         function.
4485
4486 2019-04-23  Tom Tromey  <tromey@adacore.com>
4487
4488         * dwarf2read.c (line_header::file_name_at): Remove unused
4489         overload.
4490
4491 2019-04-23  Tom de Vries  <tdevries@suse.de>
4492
4493         PR gdb/24438
4494         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4495         invocation.
4496
4497
4498 2019-03-27  Ali Tamur  <tamur@google.com>
4499
4500         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4501         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4502         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4503         (dwarf_expr_context::get_addr_index): Likewise
4504         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4505         (symbol_needs_eval_context::get_addr_index): Likewise
4506         (disassemble_dwarf_expression): Add DW_OP_addrx
4507         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4508         (read_cutu_die_from_dwo): Update comment
4509         (skip_one_die): Add DW_FORM_addrx
4510         (read_attribute_value): Likewise
4511         (var_decode_location): Add DW_OP_addrx
4512         (dwarf2_const_value_attr): Add DW_FORM_addrx
4513         (dump_die_shallow): Likewise
4514         (dwarf2_fetch_constant_bytes): Likewise
4515         (decode_locdesc): Add DW_OP_addrx
4516         (skip_form_bytes): Add DW_FORM_addrx
4517
4518 2019-04-22  Ali Tamur  <tamur@google.com>
4519
4520         * MAINTAINERS (Write After Approval): Add self.
4521
4522 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4523
4524         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4525         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4526         (open_symbol_file_object): Likewise.
4527         (svr4_default_sos): Add info parameter.
4528         (svr4_read_so_list): Likewise.
4529         (svr4_current_sos_direct): Adjust functions calls to pass down
4530         info.
4531         (svr4_current_sos_1): Add info parameter.
4532         (svr4_current_sos): Call get_svr4_info, pass info down to
4533         svr4_current_sos_1.
4534         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4535         get_svr4_info.
4536         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4537         get_svr4_info.
4538         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4539         to get_svr4_info.
4540         (probes_table_remove_objfile_probes): Likewise.
4541         (register_solib_event_probe): Add info parameter.
4542         (solist_update_incremental): Pass info parameter down to
4543         svr4_read_so_list.
4544         (disable_probes_interface): Add info parameter.
4545         (svr4_handle_solib_event): Pass current_program_space to
4546         get_svr4_info.  Adjust disable_probes_interface cleanup.
4547         (svr4_create_probe_breakpoints): Add info parameter, pass it
4548         down to register_solib_event_probe.
4549         (svr4_create_solib_event_breakpoints): Add info parameter,
4550         pass it down to svr4_create_probe_breakpoints.
4551         (enable_break): Pass info down to
4552         svr4_create_solib_event_breakpoints.
4553         (svr4_solib_create_inferior_hook): Pass current_program_space to
4554         get_svr4_info.
4555         (svr4_clear_solib): Likewise.
4556
4557 2019-04-22  Pedro Alves  <palves@redhat.com>
4558
4559         * solib-svr4.c (svr4_free_objfile_observer): New.
4560         (probe_and_action::objfile): New field.
4561         (probes_table_htab_remove_objfile_probes)
4562         (probes_table_remove_objfile_probes): New functions.
4563         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4564         in the new probe_and_action.  Don't store the probe in 'lookup'.
4565         (svr4_create_probe_breakpoints): Pass objfile to
4566         register_solib_event_probe.
4567         (_initialize_svr4_solib): Register a free_objfile observer.
4568
4569 2019-04-19  Tom Tromey  <tom@tromey.com>
4570
4571         * common/queue.h: Remove.
4572
4573 2019-04-19  Tom Tromey  <tom@tromey.com>
4574
4575         * event-loop.c: Don't include "common/queue.h".
4576
4577 2019-04-19  Tom Tromey  <tom@tromey.com>
4578
4579         * remote.c (remote_target): Use delete.
4580         * remote-notif.h: Include <list>, not "common/queue.h".
4581         (notif_client_p): Remove typedef.
4582         (remote_notif_state): Add constructor, destructor, initializer.
4583         <notif_queue>: Now a std::list.
4584         (remote_notif_state_xfree): Don't declare.
4585         * remote-notif.c (remote_notif_process, handle_notification)
4586         (remote_notif_state_allocate): Update.
4587         (~remote_notif_state): Rename from remote_notif_state_xfree.
4588
4589 2019-04-19  Tom Tromey  <tom@tromey.com>
4590
4591         * symfile.c (reread_symbols): Update.
4592         * objfiles.c (objfile_register_static_link)
4593         (objfile_lookup_static_link): Update
4594         (~objfile) Don't delete static_links.
4595         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4596
4597 2019-04-19  Tom Tromey  <tom@tromey.com>
4598
4599         * type-stack.h (struct type_stack) <insert>: Constify string.
4600         * type-stack.c (type_stack::insert): Constify string.
4601         * gdbtypes.h (lookup_template_type): Update.
4602         (address_space_name_to_int): Update.
4603         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4604         const.
4605         (lookup_template_type): Make name const.
4606         * c-exp.y: Update rules.
4607         (lex_one_token, classify_name, classify_inner_name)
4608         (c_print_token): Update.
4609         * p-exp.y: Update rules.
4610         (yylex): Update.
4611         * f-exp.y: Update rules.
4612         (yylex): Update.
4613         * d-exp.y: Update rules.
4614         (lex_one_token, classify_name, classify_inner_name): Update.
4615         * parse.c (write_dollar_variable, copy_name): Return std::string.
4616         * parser-defs.h (copy_name): Change return type.
4617         * m2-exp.y: Update rules.
4618         (yylex): Update.
4619         * go-exp.y (lex_one_token): Update.
4620         Update rules.
4621         (classify_unsafe_function, classify_packaged_name)
4622         (classify_name, yylex): Update.
4623
4624 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4625
4626         * configure.ac: add --enable-source-highlight switch.
4627         * configure: Regenerate.
4628         * top.c (print_gdb_version): plumb --enable-source-highlight
4629         status to "show configuration".
4630
4631 2019-04-19  Tom Tromey  <tromey@adacore.com>
4632
4633         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4634         Check ADA_TYPE_P.
4635         (empty_record, ada_template_to_fixed_record_type_1)
4636         (template_to_static_fixed_type)
4637         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4638         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4639         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4640         macros.
4641
4642 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4643
4644         PR symtab/24423:
4645         * source.c (print_source_lines_base): Advance "iter" when a
4646         control character is seen.
4647
4648 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4649
4650         * inferior.h (struct infcall_suspend_state_deleter):
4651         Catch exception in destructor to avoid crash.
4652
4653 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4654
4655         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4656         close to the add_com "shell".
4657
4658 2019-04-18  Tom Tromey  <tromey@adacore.com>
4659
4660         * process-stratum-target.h (class process_stratum_target)
4661         <stratum>: Add "final".
4662
4663 2019-04-17  Tom Tromey  <tromey@adacore.com>
4664
4665         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4666         against nullptr before use.
4667
4668 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4669
4670         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4671
4672 2019-04-17  Jim Wilson  <jimw@sifive.com>
4673             Andrew Burgess  <andrew.burgess@embecosm.com>
4674
4675         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4676         code read might fail, assume 4-byte breakpoint in that case.
4677
4678 2019-04-15  Leszek Swirski  <leszeks@google.com>
4679
4680         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4681         rather than a hand-rolled POD check when checking for forced MEMORY
4682         classification.
4683
4684 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4685
4686         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4687         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4688         function.
4689         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4690         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4691         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4692         declaration.
4693
4694 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4695
4696         * aarch64-linux-nat.c
4697         (aarch64_linux_nat_target::thread_architecture): Add override.
4698         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4699         each VQ.
4700
4701 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4702
4703         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4704
4705 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4706
4707         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4708         target types of size 96-bits, add some additional comments, and
4709         check that the builtin type we found was the correct size.
4710
4711 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4712
4713         * utils.c (prompt_for_continue): Don't restore the styling at the
4714         end, as applied_style has the wrong value.  This fixes styling in
4715         long lists of file names that are interrupted by the "Continue?"
4716         prompt.
4717
4718 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4719
4720         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4721         * c-lang.c (c_language_defn): Likewise.
4722         (cplus_language_defn): Likewise.
4723         (asm_language_defn): Likewise.
4724         (minimal_language_defn): Likewise.
4725         * d-lang.c (d_language_defn): Likewise.
4726         * f-lang.c (f_language_defn): Likewise.
4727         * go-lang.c (go_language_defn): Likewise.
4728         * language.c (unknown_language_defn): Likewise.
4729         (auto_language_defn): Likewise.
4730         * language.h (struct language_defn): Remove la_magic field.
4731         (LANG_MAGIC): Delete.
4732         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4733         * objc-lang.c (objc_language_defn): Likewise.
4734         * opencl-lang.c (opencl_language_defn): Likewise.
4735         * p-lang.c (pascal_language_defn): Likewise.
4736         * rust-lang.c (rust_language_defn): Likewise.
4737
4738 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4739
4740         * riscv-tdep.c (riscv_type_align): New function.
4741         (riscv_type_alignment): Delete.
4742         (riscv_arg_location): Use 'type_align'.
4743         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4744
4745 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4746
4747         * gdbtypes.c (type_align): A struct with no non-static fields also
4748         has alignment of 1.
4749
4750 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4751
4752         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4753         component to 0.
4754         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4755         member.
4756         (riscv_struct_info::analyse): New implementation using new
4757         analyse_inner member function.
4758         (riscv_struct_info::field_offset): New member function.
4759         (riscv_struct_info::m_offsets): New member variable.
4760         (riscv_struct_info::analyse_inner): New private member function,
4761         takes the old implementation of riscv_struct_info::analyse but
4762         extended to track field offsets.
4763         (riscv_call_arg_struct): Update the struct folding special cases
4764         to handle cases where empty C++ structs, which are non-zero
4765         length, are found.
4766         (riscv_arg_location): Initialise the length of each location, a
4767         non-zero length now indicates the location is in use.
4768         (riscv_push_dummy_call): Allow for the first location having a
4769         non-zero offset when setting up arguments.
4770         (riscv_return_value): Likewise, but for return values.
4771
4772 2019-04-11  Tom Tromey  <tromey@adacore.com>
4773
4774         * utils.c (internal_vproblem): Make "msg" const.
4775
4776 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4777
4778         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4779         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4780         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4781         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4782
4783 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4784
4785         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4786         function.
4787         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4788         of amd64_collect_native_gregset.
4789         (amd64_linux_nat_target::store_registers): Likewise.
4790
4791 2019-04-10  Tom Tromey  <tom@tromey.com>
4792
4793         * symtab.c (lookup_global_symbol_from_objfile)
4794         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4795         * objfiles.h (class separate_debug_iterator): New.
4796         (class separate_debug_range): New.
4797         (struct objfile) <separate_debug_objfiles>: New method.
4798         (objfile_separate_debug_iterate): Don't declare.
4799         * objfiles.c (separate_debug_iterator::operator++): Rename from
4800         objfile_separate_debug_iterate.
4801         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4802         iterator.
4803         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4804         iterator.
4805
4806 2019-04-10  Tom Tromey  <tom@tromey.com>
4807
4808         * symfile.c (reread_symbols): Remove old comment.
4809         * objfiles.c (free_all_objfiles): Fix a typo.
4810
4811 2019-04-10  Tom Tromey  <tom@tromey.com>
4812
4813         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4814         * minsyms.c (lookup_minimal_symbol): Use foreach.
4815         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4816         (lookup_minimal_symbol_solib_trampoline): Likewise.
4817         * symfile.c (reread_symbols): Use foreach.
4818
4819 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4820             Tom Tromey  <tromey@adacore.com>
4821
4822         PR rust/24414:
4823         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4824         (rust_lex_int_test): Change "value" to be LONGEST.
4825         (rust_lex_tests): Add test for long integer literal.
4826
4827 2019-04-09  Tom Tromey  <tromey@adacore.com>
4828
4829         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4830         to bool.
4831         (extended_remote_target::attach): Update.
4832         (remote_target::remote_notice_new_inferior): Update.
4833         (remote_target::add_current_inferior_and_thread): Update.
4834         * inferior.c (exit_inferior_1): Use "false".
4835         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4836
4837 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4838
4839         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4840         the "start" command.
4841
4842 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4843
4844         * python/py-inferior.c (infpy_thread_from_thread_handle):
4845         Adjust comments to reflect renaming of thread_from_thread_handle
4846         to thread_from_handle.  Adjust keywords.  Fix type error message.
4847         (inferior_object_methods): Add thread_from_handle.  Retain
4848         thread_from_thread_handle, but mark it as deprecated.
4849
4850 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4851
4852         * gdbthread.h (find_thread_by_handle): Revise declaration.
4853         * thread.c (find_thread_by_handle): Likewise.  Adjust
4854         implementation too.
4855         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4856         support for buffer objects as handles.
4857
4858 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4859
4860         * python/py-infthread.c (thpy_thread_handle): New function.
4861         (thread_object_methods): Register thpy_thread_handle.
4862
4863 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4864
4865         * gdbthread.h (thread_to_thread_handle): Declare.
4866         * thread.c (gdbtypes.h): Include.
4867         (thread_to_thread_handle): New function.
4868
4869         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4870         (target_thread_info_to_thread_handle): Declare.
4871         * target.c (target_thread_info_to_thread_handle): New function.
4872         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4873         * target-delegates.c: Regenerate.
4874
4875         * linux-thread-db.c (class thread_db_target): Add method
4876         thread_info_to_thread_handle.
4877         (thread_db_target::thread_info_to_thread_handle): Define.
4878         * remote.c (class remote_target): Add new method
4879         thread_info_to_thread_handle.
4880         (remote_target::thread_info_to_thread_handle): Define.
4881
4882 2019-04-08  Pedro Alves  <palves@redhat.com>
4883
4884         * common/common-exceptions.c (throw_exception): Don't create
4885         named object to throw; throw directly.
4886         (throw_it): Likewise.  Don't initialize gdb_exception::message
4887         here, with new; pass FMT and AP to the ctor instead.
4888         * common/common-exceptions.h: Include <string>.
4889         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4890         const char *, va_list)): New ctor.  Use std::make_shared.
4891         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4892         errors)): Delete.
4893         (gdb_exception_error::gdb_exception_error(enum errors, const char
4894         *, va_list)): New.
4895         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4896         Add assertion.
4897         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4898         errors)): Delete.
4899         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4900         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4901         Add assertion.
4902
4903 2019-04-08  Tom Tromey  <tom@tromey.com>
4904
4905         * valops.c (value_rtti_indirect_type): Replace throw_exception
4906         with throw.
4907         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4908         with throw.
4909         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4910         throw.
4911         * target.c (target_translate_tls_address): Replace throw_exception
4912         with throw.
4913         * stack.c (frame_apply_command_count): Replace throw_exception
4914         with throw.
4915         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4916         throw.
4917         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4918         with throw.
4919         * rs6000-tdep.c (rs6000_frame_cache)
4920         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4921         * remote.c: Replace throw_exception with throw.
4922         * record-full.c (record_full_message, record_full_wait_1)
4923         (record_full_restore): Replace throw_exception with throw.
4924         * record-btrace.c:
4925         (get_thread_current_frame_id, record_btrace_start_replaying)
4926         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4927         (cmd_record_btrace_start): Replace throw_exception with throw.
4928         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4929         throw.
4930         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4931         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4932         * linespec.c:
4933         (find_linespec_symbols): Replace throw_exception with throw.
4934         * infrun.c (displaced_step_prepare, resume): Replace
4935         throw_exception with throw.
4936         * infcmd.c (post_create_inferior): Replace throw_exception with
4937         throw.
4938         * inf-loop.c (inferior_event_handler): Replace throw_exception
4939         with throw.
4940         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4941         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4942         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4943         (get_prev_frame_always, get_frame_pc_if_available)
4944         (get_frame_address_in_block_if_available, get_frame_language):
4945         Replace throw_exception with throw.
4946         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4947         throw_exception with throw.
4948         * eval.c (fetch_subexp_value, evaluate_var_value)
4949         (evaluate_funcall, evaluate_subexp_standard): Replace
4950         throw_exception with throw.
4951         * dwarf2loc.c (call_site_find_chain)
4952         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4953         Replace throw_exception with throw.
4954         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4955         with throw.
4956         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4957         throw.
4958         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4959         * completer.c (complete_line_internal): Replace throw_exception
4960         with throw.
4961         * compile/compile-object-run.c (compile_object_run): Replace
4962         throw_exception with throw.
4963         * cli/cli-script.c (process_next_line): Replace throw_exception
4964         with throw.
4965         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4966         (btrace_enable, btrace_maint_update_pt_packets): Replace
4967         throw_exception with throw.
4968         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4969         throw_exception with throw.
4970         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4971         throw_exception with throw.
4972         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4973         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4974         * aarch64-tdep.c (aarch64_make_prologue_cache)
4975         (aarch64_make_stub_cache): Replace throw_exception with throw.
4976
4977 2019-04-08  Tom Tromey  <tom@tromey.com>
4978
4979         * common/common-exceptions.c (throw_exception): Rename from
4980         throw_exception_cxx.  Remove old copy.  Make argument const.
4981         (throw_it): Create and throw exception objects directly.
4982         * common/common-exceptions.h (throw_exception): Make argument
4983         const.
4984         (struct gdb_exception_error): Add constructor.
4985         (struct gdb_exception_quit): Add constructor.
4986
4987 2019-04-08  Tom Tromey  <tom@tromey.com>
4988
4989         * common/common-exceptions.h (exception_rethrow): Don't declare.
4990         (TRY_SJLJ): Update comment.
4991         (TRY, CATCH, END_CATCH): Remove.
4992         * common/common-exceptions.c (exception_rethrow): Remove.
4993
4994 2019-04-08  Tom Tromey  <tom@tromey.com>
4995
4996         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4997         Remove.
4998         (gdb_exception_error): Rename from
4999         gdb_exception_RETURN_MASK_ERROR.
5000         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5001         (gdb_quit_bad_alloc): Update.
5002         * aarch64-tdep.c: Update.
5003         * ada-lang.c: Update.
5004         * ada-typeprint.c: Update.
5005         * ada-valprint.c: Update.
5006         * amd64-tdep.c: Update.
5007         * arch-utils.c: Update.
5008         * break-catch-throw.c: Update.
5009         * breakpoint.c: Update.
5010         * btrace.c: Update.
5011         * c-varobj.c: Update.
5012         * cli/cli-cmds.c: Update.
5013         * cli/cli-interp.c: Update.
5014         * cli/cli-script.c: Update.
5015         * common/common-exceptions.c: Update.
5016         * common/new-op.c: Update.
5017         * common/selftest.c: Update.
5018         * compile/compile-c-symbols.c: Update.
5019         * compile/compile-cplus-symbols.c: Update.
5020         * compile/compile-object-load.c: Update.
5021         * compile/compile-object-run.c: Update.
5022         * completer.c: Update.
5023         * corelow.c: Update.
5024         * cp-abi.c: Update.
5025         * cp-support.c: Update.
5026         * cp-valprint.c: Update.
5027         * darwin-nat.c: Update.
5028         * disasm-selftests.c: Update.
5029         * dtrace-probe.c: Update.
5030         * dwarf-index-cache.c: Update.
5031         * dwarf-index-write.c: Update.
5032         * dwarf2-frame-tailcall.c: Update.
5033         * dwarf2-frame.c: Update.
5034         * dwarf2loc.c: Update.
5035         * dwarf2read.c: Update.
5036         * eval.c: Update.
5037         * event-loop.c: Update.
5038         * event-top.c: Update.
5039         * exec.c: Update.
5040         * f-valprint.c: Update.
5041         * fbsd-tdep.c: Update.
5042         * frame-unwind.c: Update.
5043         * frame.c: Update.
5044         * gdbtypes.c: Update.
5045         * gnu-v3-abi.c: Update.
5046         * guile/guile-internal.h: Update.
5047         * guile/scm-block.c: Update.
5048         * guile/scm-breakpoint.c: Update.
5049         * guile/scm-cmd.c: Update.
5050         * guile/scm-disasm.c: Update.
5051         * guile/scm-frame.c: Update.
5052         * guile/scm-lazy-string.c: Update.
5053         * guile/scm-math.c: Update.
5054         * guile/scm-param.c: Update.
5055         * guile/scm-ports.c: Update.
5056         * guile/scm-pretty-print.c: Update.
5057         * guile/scm-symbol.c: Update.
5058         * guile/scm-symtab.c: Update.
5059         * guile/scm-type.c: Update.
5060         * guile/scm-value.c: Update.
5061         * i386-linux-tdep.c: Update.
5062         * i386-tdep.c: Update.
5063         * inf-loop.c: Update.
5064         * infcall.c: Update.
5065         * infcmd.c: Update.
5066         * infrun.c: Update.
5067         * jit.c: Update.
5068         * language.c: Update.
5069         * linespec.c: Update.
5070         * linux-fork.c: Update.
5071         * linux-nat.c: Update.
5072         * linux-tdep.c: Update.
5073         * linux-thread-db.c: Update.
5074         * main.c: Update.
5075         * mi/mi-cmd-break.c: Update.
5076         * mi/mi-cmd-stack.c: Update.
5077         * mi/mi-interp.c: Update.
5078         * mi/mi-main.c: Update.
5079         * objc-lang.c: Update.
5080         * p-valprint.c: Update.
5081         * parse.c: Update.
5082         * ppc-linux-tdep.c: Update.
5083         * printcmd.c: Update.
5084         * python/py-arch.c: Update.
5085         * python/py-breakpoint.c: Update.
5086         * python/py-cmd.c: Update.
5087         * python/py-finishbreakpoint.c: Update.
5088         * python/py-frame.c: Update.
5089         * python/py-framefilter.c: Update.
5090         * python/py-gdb-readline.c: Update.
5091         * python/py-inferior.c: Update.
5092         * python/py-infthread.c: Update.
5093         * python/py-lazy-string.c: Update.
5094         * python/py-linetable.c: Update.
5095         * python/py-objfile.c: Update.
5096         * python/py-param.c: Update.
5097         * python/py-prettyprint.c: Update.
5098         * python/py-progspace.c: Update.
5099         * python/py-record-btrace.c: Update.
5100         * python/py-record.c: Update.
5101         * python/py-symbol.c: Update.
5102         * python/py-type.c: Update.
5103         * python/py-unwind.c: Update.
5104         * python/py-utils.c: Update.
5105         * python/py-value.c: Update.
5106         * python/python.c: Update.
5107         * record-btrace.c: Update.
5108         * record-full.c: Update.
5109         * remote-fileio.c: Update.
5110         * remote.c: Update.
5111         * riscv-tdep.c: Update.
5112         * rs6000-aix-tdep.c: Update.
5113         * rs6000-tdep.c: Update.
5114         * rust-exp.y: Update.
5115         * rust-lang.c: Update.
5116         * s390-tdep.c: Update.
5117         * selftest-arch.c: Update.
5118         * solib-dsbt.c: Update.
5119         * solib-frv.c: Update.
5120         * solib-spu.c: Update.
5121         * solib-svr4.c: Update.
5122         * solib.c: Update.
5123         * sparc64-linux-tdep.c: Update.
5124         * stack.c: Update.
5125         * symfile-mem.c: Update.
5126         * symmisc.c: Update.
5127         * target.c: Update.
5128         * thread.c: Update.
5129         * top.c: Update.
5130         * tracefile-tfile.c: Update.
5131         * tui/tui.c: Update.
5132         * typeprint.c: Update.
5133         * unittests/cli-utils-selftests.c: Update.
5134         * unittests/parse-connection-spec-selftests.c: Update.
5135         * valops.c: Update.
5136         * valprint.c: Update.
5137         * value.c: Update.
5138         * varobj.c: Update.
5139         * windows-nat.c: Update.
5140         * x86-linux-nat.c: Update.
5141         * xml-support.c: Update.
5142
5143 2019-04-08  Tom Tromey  <tom@tromey.com>
5144
5145         * xml-support.c: Use C++ exception handling.
5146         * x86-linux-nat.c: Use C++ exception handling.
5147         * windows-nat.c: Use C++ exception handling.
5148         * varobj.c: Use C++ exception handling.
5149         * value.c: Use C++ exception handling.
5150         * valprint.c: Use C++ exception handling.
5151         * valops.c: Use C++ exception handling.
5152         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5153         handling.
5154         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5155         * typeprint.c: Use C++ exception handling.
5156         * tui/tui.c: Use C++ exception handling.
5157         * tracefile-tfile.c: Use C++ exception handling.
5158         * top.c: Use C++ exception handling.
5159         * thread.c: Use C++ exception handling.
5160         * target.c: Use C++ exception handling.
5161         * symmisc.c: Use C++ exception handling.
5162         * symfile-mem.c: Use C++ exception handling.
5163         * stack.c: Use C++ exception handling.
5164         * sparc64-linux-tdep.c: Use C++ exception handling.
5165         * solib.c: Use C++ exception handling.
5166         * solib-svr4.c: Use C++ exception handling.
5167         * solib-spu.c: Use C++ exception handling.
5168         * solib-frv.c: Use C++ exception handling.
5169         * solib-dsbt.c: Use C++ exception handling.
5170         * selftest-arch.c: Use C++ exception handling.
5171         * s390-tdep.c: Use C++ exception handling.
5172         * rust-lang.c: Use C++ exception handling.
5173         * rust-exp.y: Use C++ exception handling.
5174         * rs6000-tdep.c: Use C++ exception handling.
5175         * rs6000-aix-tdep.c: Use C++ exception handling.
5176         * riscv-tdep.c: Use C++ exception handling.
5177         * remote.c: Use C++ exception handling.
5178         * remote-fileio.c: Use C++ exception handling.
5179         * record-full.c: Use C++ exception handling.
5180         * record-btrace.c: Use C++ exception handling.
5181         * python/python.c: Use C++ exception handling.
5182         * python/py-value.c: Use C++ exception handling.
5183         * python/py-utils.c: Use C++ exception handling.
5184         * python/py-unwind.c: Use C++ exception handling.
5185         * python/py-type.c: Use C++ exception handling.
5186         * python/py-symbol.c: Use C++ exception handling.
5187         * python/py-record.c: Use C++ exception handling.
5188         * python/py-record-btrace.c: Use C++ exception handling.
5189         * python/py-progspace.c: Use C++ exception handling.
5190         * python/py-prettyprint.c: Use C++ exception handling.
5191         * python/py-param.c: Use C++ exception handling.
5192         * python/py-objfile.c: Use C++ exception handling.
5193         * python/py-linetable.c: Use C++ exception handling.
5194         * python/py-lazy-string.c: Use C++ exception handling.
5195         * python/py-infthread.c: Use C++ exception handling.
5196         * python/py-inferior.c: Use C++ exception handling.
5197         * python/py-gdb-readline.c: Use C++ exception handling.
5198         * python/py-framefilter.c: Use C++ exception handling.
5199         * python/py-frame.c: Use C++ exception handling.
5200         * python/py-finishbreakpoint.c: Use C++ exception handling.
5201         * python/py-cmd.c: Use C++ exception handling.
5202         * python/py-breakpoint.c: Use C++ exception handling.
5203         * python/py-arch.c: Use C++ exception handling.
5204         * printcmd.c: Use C++ exception handling.
5205         * ppc-linux-tdep.c: Use C++ exception handling.
5206         * parse.c: Use C++ exception handling.
5207         * p-valprint.c: Use C++ exception handling.
5208         * objc-lang.c: Use C++ exception handling.
5209         * mi/mi-main.c: Use C++ exception handling.
5210         * mi/mi-interp.c: Use C++ exception handling.
5211         * mi/mi-cmd-stack.c: Use C++ exception handling.
5212         * mi/mi-cmd-break.c: Use C++ exception handling.
5213         * main.c: Use C++ exception handling.
5214         * linux-thread-db.c: Use C++ exception handling.
5215         * linux-tdep.c: Use C++ exception handling.
5216         * linux-nat.c: Use C++ exception handling.
5217         * linux-fork.c: Use C++ exception handling.
5218         * linespec.c: Use C++ exception handling.
5219         * language.c: Use C++ exception handling.
5220         * jit.c: Use C++ exception handling.
5221         * infrun.c: Use C++ exception handling.
5222         * infcmd.c: Use C++ exception handling.
5223         * infcall.c: Use C++ exception handling.
5224         * inf-loop.c: Use C++ exception handling.
5225         * i386-tdep.c: Use C++ exception handling.
5226         * i386-linux-tdep.c: Use C++ exception handling.
5227         * guile/scm-value.c: Use C++ exception handling.
5228         * guile/scm-type.c: Use C++ exception handling.
5229         * guile/scm-symtab.c: Use C++ exception handling.
5230         * guile/scm-symbol.c: Use C++ exception handling.
5231         * guile/scm-pretty-print.c: Use C++ exception handling.
5232         * guile/scm-ports.c: Use C++ exception handling.
5233         * guile/scm-param.c: Use C++ exception handling.
5234         * guile/scm-math.c: Use C++ exception handling.
5235         * guile/scm-lazy-string.c: Use C++ exception handling.
5236         * guile/scm-frame.c: Use C++ exception handling.
5237         * guile/scm-disasm.c: Use C++ exception handling.
5238         * guile/scm-cmd.c: Use C++ exception handling.
5239         * guile/scm-breakpoint.c: Use C++ exception handling.
5240         * guile/scm-block.c: Use C++ exception handling.
5241         * guile/guile-internal.h: Use C++ exception handling.
5242         * gnu-v3-abi.c: Use C++ exception handling.
5243         * gdbtypes.c: Use C++ exception handling.
5244         * frame.c: Use C++ exception handling.
5245         * frame-unwind.c: Use C++ exception handling.
5246         * fbsd-tdep.c: Use C++ exception handling.
5247         * f-valprint.c: Use C++ exception handling.
5248         * exec.c: Use C++ exception handling.
5249         * event-top.c: Use C++ exception handling.
5250         * event-loop.c: Use C++ exception handling.
5251         * eval.c: Use C++ exception handling.
5252         * dwarf2read.c: Use C++ exception handling.
5253         * dwarf2loc.c: Use C++ exception handling.
5254         * dwarf2-frame.c: Use C++ exception handling.
5255         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5256         * dwarf-index-write.c: Use C++ exception handling.
5257         * dwarf-index-cache.c: Use C++ exception handling.
5258         * dtrace-probe.c: Use C++ exception handling.
5259         * disasm-selftests.c: Use C++ exception handling.
5260         * darwin-nat.c: Use C++ exception handling.
5261         * cp-valprint.c: Use C++ exception handling.
5262         * cp-support.c: Use C++ exception handling.
5263         * cp-abi.c: Use C++ exception handling.
5264         * corelow.c: Use C++ exception handling.
5265         * completer.c: Use C++ exception handling.
5266         * compile/compile-object-run.c: Use C++ exception handling.
5267         * compile/compile-object-load.c: Use C++ exception handling.
5268         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5269         * compile/compile-c-symbols.c: Use C++ exception handling.
5270         * common/selftest.c: Use C++ exception handling.
5271         * common/new-op.c: Use C++ exception handling.
5272         * cli/cli-script.c: Use C++ exception handling.
5273         * cli/cli-interp.c: Use C++ exception handling.
5274         * cli/cli-cmds.c: Use C++ exception handling.
5275         * c-varobj.c: Use C++ exception handling.
5276         * btrace.c: Use C++ exception handling.
5277         * breakpoint.c: Use C++ exception handling.
5278         * break-catch-throw.c: Use C++ exception handling.
5279         * arch-utils.c: Use C++ exception handling.
5280         * amd64-tdep.c: Use C++ exception handling.
5281         * ada-valprint.c: Use C++ exception handling.
5282         * ada-typeprint.c: Use C++ exception handling.
5283         * ada-lang.c: Use C++ exception handling.
5284         * aarch64-tdep.c: Use C++ exception handling.
5285
5286 2019-04-08  Tom Tromey  <tom@tromey.com>
5287
5288         * xml-support.c (gdb_xml_parser::parse): Update.
5289         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5290         * value.c (show_convenience): Update.
5291         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5292         (test_parse_flags_qcs): Update.
5293         * thread.c (thr_try_catch_cmd): Update.
5294         * target.c (target_translate_tls_address): Update.
5295         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5296         (info_frame_command_core, frame_apply_command_count): Update.
5297         * rust-exp.y (rust_lex_exception_test): Update.
5298         * riscv-tdep.c (riscv_print_one_register_info): Update.
5299         * remote.c (remote_target::enable_btrace): Update.
5300         * record-btrace.c (record_btrace_enable_warn): Update.
5301         * python/py-utils.c (gdbpy_convert_exception): Update.
5302         * printcmd.c (do_one_display, print_variable_and_value): Update.
5303         * mi/mi-main.c (mi_print_exception): Update.
5304         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5305         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5306         * linux-nat.c (linux_nat_target::attach): Update.
5307         * linux-fork.c (class scoped_switch_fork_info): Update.
5308         * infrun.c (displaced_step_prepare): Update.
5309         * infcall.c (call_function_by_hand_dummy): Update.
5310         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5311         * gnu-v3-abi.c (print_one_vtable): Update.
5312         * frame.c (get_prev_frame_always): Update.
5313         * f-valprint.c (info_common_command_for_block): Update.
5314         * exec.c (try_open_exec_file): Update.
5315         * exceptions.c (print_exception, exception_print)
5316         (exception_fprintf, exception_print_same): Update.
5317         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5318         * dwarf-index-cache.c (index_cache::store)
5319         (index_cache::lookup_gdb_index): Update.
5320         * darwin-nat.c (maybe_cache_shell): Update.
5321         * cp-valprint.c (cp_print_value_fields): Update.
5322         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5323         (gcc_cplus_symbol_address): Update.
5324         * compile/compile-c-symbols.c (gcc_convert_symbol)
5325         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5326         * common/selftest.c: Update.
5327         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5328         a std::string.
5329         (exception_try_scope_entry, exception_try_scope_exit): Don't
5330         declare.
5331         (struct exception_try_scope): Remove.
5332         (TRY): Don't use exception_try_scope.
5333         (struct gdb_exception): Add constructor, operator=.
5334         <what>: New method.
5335         (struct gdb_exception_RETURN_MASK_ALL)
5336         (struct gdb_exception_RETURN_MASK_ERROR)
5337         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5338         (struct gdb_quit_bad_alloc): Update.
5339         * common/common-exceptions.c (exception_none): Change
5340         initializer.
5341         (struct catcher) <state, exception>: Initialize inline.
5342         <prev>: Remove member.
5343         (current_catcher): Remove.
5344         (catchers): New global.
5345         (exceptions_state_mc_init): Simplify.
5346         (catcher_pop): Remove.
5347         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5348         (try_scope_depth, exception_try_scope_entry)
5349         (exception_try_scope_exit): Remove.
5350         (throw_exception_sjlj): Update.
5351         (exception_messages, exception_messages_size): Remove.
5352         (throw_it): Simplify.
5353         (gdb_exception_sliced_copy): Remove.
5354         (throw_exception_cxx): Update.
5355         * cli/cli-script.c (script_from_file): Update.
5356         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5357         Update.
5358         * ada-valprint.c (ada_val_print): Update.
5359         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5360         (create_excep_cond_exprs): Update.
5361
5362 2019-04-08  Tom Tromey  <tom@tromey.com>
5363
5364         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5365         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5366         (TRY, CATCH, END_CATCH): Remove some definitions.
5367         * common/common-exceptions.c: Don't use GDB_XCPT.
5368         (catcher_list_size): Remove.
5369         (throw_exception, throw_it): Simplify.
5370
5371 2019-04-05  Tom Tromey  <tom@tromey.com>
5372
5373         Revert the header-sorting patch.
5374         * ft32-tdep.c: Revert.
5375         * frv-tdep.c: Revert.
5376         * frv-linux-tdep.c: Revert.
5377         * frame.c: Revert.
5378         * frame-unwind.c: Revert.
5379         * frame-base.c: Revert.
5380         * fork-child.c: Revert.
5381         * findvar.c: Revert.
5382         * findcmd.c: Revert.
5383         * filesystem.c: Revert.
5384         * filename-seen-cache.h: Revert.
5385         * filename-seen-cache.c: Revert.
5386         * fbsd-tdep.c: Revert.
5387         * fbsd-nat.h: Revert.
5388         * fbsd-nat.c: Revert.
5389         * f-valprint.c: Revert.
5390         * f-typeprint.c: Revert.
5391         * f-lang.c: Revert.
5392         * extension.h: Revert.
5393         * extension.c: Revert.
5394         * extension-priv.h: Revert.
5395         * expprint.c: Revert.
5396         * exec.h: Revert.
5397         * exec.c: Revert.
5398         * exceptions.c: Revert.
5399         * event-top.c: Revert.
5400         * event-loop.c: Revert.
5401         * eval.c: Revert.
5402         * elfread.c: Revert.
5403         * dwarf2read.h: Revert.
5404         * dwarf2read.c: Revert.
5405         * dwarf2loc.c: Revert.
5406         * dwarf2expr.h: Revert.
5407         * dwarf2expr.c: Revert.
5408         * dwarf2-frame.c: Revert.
5409         * dwarf2-frame-tailcall.c: Revert.
5410         * dwarf-index-write.h: Revert.
5411         * dwarf-index-write.c: Revert.
5412         * dwarf-index-common.c: Revert.
5413         * dwarf-index-cache.h: Revert.
5414         * dwarf-index-cache.c: Revert.
5415         * dummy-frame.c: Revert.
5416         * dtrace-probe.c: Revert.
5417         * disasm.h: Revert.
5418         * disasm.c: Revert.
5419         * disasm-selftests.c: Revert.
5420         * dictionary.c: Revert.
5421         * dicos-tdep.c: Revert.
5422         * demangle.c: Revert.
5423         * dcache.h: Revert.
5424         * dcache.c: Revert.
5425         * darwin-nat.h: Revert.
5426         * darwin-nat.c: Revert.
5427         * darwin-nat-info.c: Revert.
5428         * d-valprint.c: Revert.
5429         * d-namespace.c: Revert.
5430         * d-lang.c: Revert.
5431         * ctf.c: Revert.
5432         * csky-tdep.c: Revert.
5433         * csky-linux-tdep.c: Revert.
5434         * cris-tdep.c: Revert.
5435         * cris-linux-tdep.c: Revert.
5436         * cp-valprint.c: Revert.
5437         * cp-support.c: Revert.
5438         * cp-namespace.c: Revert.
5439         * cp-abi.c: Revert.
5440         * corelow.c: Revert.
5441         * corefile.c: Revert.
5442         * continuations.c: Revert.
5443         * completer.h: Revert.
5444         * completer.c: Revert.
5445         * complaints.c: Revert.
5446         * coffread.c: Revert.
5447         * coff-pe-read.c: Revert.
5448         * cli-out.h: Revert.
5449         * cli-out.c: Revert.
5450         * charset.c: Revert.
5451         * c-varobj.c: Revert.
5452         * c-valprint.c: Revert.
5453         * c-typeprint.c: Revert.
5454         * c-lang.c: Revert.
5455         * buildsym.c: Revert.
5456         * buildsym-legacy.c: Revert.
5457         * build-id.h: Revert.
5458         * build-id.c: Revert.
5459         * btrace.c: Revert.
5460         * bsd-uthread.c: Revert.
5461         * breakpoint.h: Revert.
5462         * breakpoint.c: Revert.
5463         * break-catch-throw.c: Revert.
5464         * break-catch-syscall.c: Revert.
5465         * break-catch-sig.c: Revert.
5466         * blockframe.c: Revert.
5467         * block.c: Revert.
5468         * bfin-tdep.c: Revert.
5469         * bfin-linux-tdep.c: Revert.
5470         * bfd-target.c: Revert.
5471         * bcache.c: Revert.
5472         * ax-general.c: Revert.
5473         * ax-gdb.h: Revert.
5474         * ax-gdb.c: Revert.
5475         * avr-tdep.c: Revert.
5476         * auxv.c: Revert.
5477         * auto-load.c: Revert.
5478         * arm-wince-tdep.c: Revert.
5479         * arm-tdep.c: Revert.
5480         * arm-symbian-tdep.c: Revert.
5481         * arm-pikeos-tdep.c: Revert.
5482         * arm-obsd-tdep.c: Revert.
5483         * arm-nbsd-tdep.c: Revert.
5484         * arm-nbsd-nat.c: Revert.
5485         * arm-linux-tdep.c: Revert.
5486         * arm-linux-nat.c: Revert.
5487         * arm-fbsd-tdep.c: Revert.
5488         * arm-fbsd-nat.c: Revert.
5489         * arm-bsd-tdep.c: Revert.
5490         * arch-utils.c: Revert.
5491         * arc-tdep.c: Revert.
5492         * arc-newlib-tdep.c: Revert.
5493         * annotate.h: Revert.
5494         * annotate.c: Revert.
5495         * amd64-windows-tdep.c: Revert.
5496         * amd64-windows-nat.c: Revert.
5497         * amd64-tdep.c: Revert.
5498         * amd64-sol2-tdep.c: Revert.
5499         * amd64-obsd-tdep.c: Revert.
5500         * amd64-obsd-nat.c: Revert.
5501         * amd64-nbsd-tdep.c: Revert.
5502         * amd64-nbsd-nat.c: Revert.
5503         * amd64-nat.c: Revert.
5504         * amd64-linux-tdep.c: Revert.
5505         * amd64-linux-nat.c: Revert.
5506         * amd64-fbsd-tdep.c: Revert.
5507         * amd64-fbsd-nat.c: Revert.
5508         * amd64-dicos-tdep.c: Revert.
5509         * amd64-darwin-tdep.c: Revert.
5510         * amd64-bsd-nat.c: Revert.
5511         * alpha-tdep.c: Revert.
5512         * alpha-obsd-tdep.c: Revert.
5513         * alpha-nbsd-tdep.c: Revert.
5514         * alpha-mdebug-tdep.c: Revert.
5515         * alpha-linux-tdep.c: Revert.
5516         * alpha-linux-nat.c: Revert.
5517         * alpha-bsd-tdep.c: Revert.
5518         * alpha-bsd-nat.c: Revert.
5519         * aix-thread.c: Revert.
5520         * agent.c: Revert.
5521         * addrmap.c: Revert.
5522         * ada-varobj.c: Revert.
5523         * ada-valprint.c: Revert.
5524         * ada-typeprint.c: Revert.
5525         * ada-tasks.c: Revert.
5526         * ada-lang.c: Revert.
5527         * aarch64-tdep.c: Revert.
5528         * aarch64-ravenscar-thread.c: Revert.
5529         * aarch64-newlib-tdep.c: Revert.
5530         * aarch64-linux-tdep.c: Revert.
5531         * aarch64-linux-nat.c: Revert.
5532         * aarch64-fbsd-tdep.c: Revert.
5533         * aarch64-fbsd-nat.c: Revert.
5534         * aarch32-linux-nat.c: Revert.
5535
5536 2019-04-05  Tom Tromey  <tom@tromey.com>
5537
5538         * ft32-tdep.c: Sort headers.
5539         * frv-tdep.c: Sort headers.
5540         * frv-linux-tdep.c: Sort headers.
5541         * frame.c: Sort headers.
5542         * frame-unwind.c: Sort headers.
5543         * frame-base.c: Sort headers.
5544         * fork-child.c: Sort headers.
5545         * findvar.c: Sort headers.
5546         * findcmd.c: Sort headers.
5547         * filesystem.c: Sort headers.
5548         * filename-seen-cache.h: Sort headers.
5549         * filename-seen-cache.c: Sort headers.
5550         * fbsd-tdep.c: Sort headers.
5551         * fbsd-nat.h: Sort headers.
5552         * fbsd-nat.c: Sort headers.
5553         * f-valprint.c: Sort headers.
5554         * f-typeprint.c: Sort headers.
5555         * f-lang.c: Sort headers.
5556         * extension.h: Sort headers.
5557         * extension.c: Sort headers.
5558         * extension-priv.h: Sort headers.
5559         * expprint.c: Sort headers.
5560         * exec.h: Sort headers.
5561         * exec.c: Sort headers.
5562         * exceptions.c: Sort headers.
5563         * event-top.c: Sort headers.
5564         * event-loop.c: Sort headers.
5565         * eval.c: Sort headers.
5566         * elfread.c: Sort headers.
5567         * dwarf2read.h: Sort headers.
5568         * dwarf2read.c: Sort headers.
5569         * dwarf2loc.c: Sort headers.
5570         * dwarf2expr.h: Sort headers.
5571         * dwarf2expr.c: Sort headers.
5572         * dwarf2-frame.c: Sort headers.
5573         * dwarf2-frame-tailcall.c: Sort headers.
5574         * dwarf-index-write.h: Sort headers.
5575         * dwarf-index-write.c: Sort headers.
5576         * dwarf-index-common.c: Sort headers.
5577         * dwarf-index-cache.h: Sort headers.
5578         * dwarf-index-cache.c: Sort headers.
5579         * dummy-frame.c: Sort headers.
5580         * dtrace-probe.c: Sort headers.
5581         * disasm.h: Sort headers.
5582         * disasm.c: Sort headers.
5583         * disasm-selftests.c: Sort headers.
5584         * dictionary.c: Sort headers.
5585         * dicos-tdep.c: Sort headers.
5586         * demangle.c: Sort headers.
5587         * dcache.h: Sort headers.
5588         * dcache.c: Sort headers.
5589         * darwin-nat.h: Sort headers.
5590         * darwin-nat.c: Sort headers.
5591         * darwin-nat-info.c: Sort headers.
5592         * d-valprint.c: Sort headers.
5593         * d-namespace.c: Sort headers.
5594         * d-lang.c: Sort headers.
5595         * ctf.c: Sort headers.
5596         * csky-tdep.c: Sort headers.
5597         * csky-linux-tdep.c: Sort headers.
5598         * cris-tdep.c: Sort headers.
5599         * cris-linux-tdep.c: Sort headers.
5600         * cp-valprint.c: Sort headers.
5601         * cp-support.c: Sort headers.
5602         * cp-namespace.c: Sort headers.
5603         * cp-abi.c: Sort headers.
5604         * corelow.c: Sort headers.
5605         * corefile.c: Sort headers.
5606         * continuations.c: Sort headers.
5607         * completer.h: Sort headers.
5608         * completer.c: Sort headers.
5609         * complaints.c: Sort headers.
5610         * coffread.c: Sort headers.
5611         * coff-pe-read.c: Sort headers.
5612         * cli-out.h: Sort headers.
5613         * cli-out.c: Sort headers.
5614         * charset.c: Sort headers.
5615         * c-varobj.c: Sort headers.
5616         * c-valprint.c: Sort headers.
5617         * c-typeprint.c: Sort headers.
5618         * c-lang.c: Sort headers.
5619         * buildsym.c: Sort headers.
5620         * buildsym-legacy.c: Sort headers.
5621         * build-id.h: Sort headers.
5622         * build-id.c: Sort headers.
5623         * btrace.c: Sort headers.
5624         * bsd-uthread.c: Sort headers.
5625         * breakpoint.h: Sort headers.
5626         * breakpoint.c: Sort headers.
5627         * break-catch-throw.c: Sort headers.
5628         * break-catch-syscall.c: Sort headers.
5629         * break-catch-sig.c: Sort headers.
5630         * blockframe.c: Sort headers.
5631         * block.c: Sort headers.
5632         * bfin-tdep.c: Sort headers.
5633         * bfin-linux-tdep.c: Sort headers.
5634         * bfd-target.c: Sort headers.
5635         * bcache.c: Sort headers.
5636         * ax-general.c: Sort headers.
5637         * ax-gdb.h: Sort headers.
5638         * ax-gdb.c: Sort headers.
5639         * avr-tdep.c: Sort headers.
5640         * auxv.c: Sort headers.
5641         * auto-load.c: Sort headers.
5642         * arm-wince-tdep.c: Sort headers.
5643         * arm-tdep.c: Sort headers.
5644         * arm-symbian-tdep.c: Sort headers.
5645         * arm-pikeos-tdep.c: Sort headers.
5646         * arm-obsd-tdep.c: Sort headers.
5647         * arm-nbsd-tdep.c: Sort headers.
5648         * arm-nbsd-nat.c: Sort headers.
5649         * arm-linux-tdep.c: Sort headers.
5650         * arm-linux-nat.c: Sort headers.
5651         * arm-fbsd-tdep.c: Sort headers.
5652         * arm-fbsd-nat.c: Sort headers.
5653         * arm-bsd-tdep.c: Sort headers.
5654         * arch-utils.c: Sort headers.
5655         * arc-tdep.c: Sort headers.
5656         * arc-newlib-tdep.c: Sort headers.
5657         * annotate.h: Sort headers.
5658         * annotate.c: Sort headers.
5659         * amd64-windows-tdep.c: Sort headers.
5660         * amd64-windows-nat.c: Sort headers.
5661         * amd64-tdep.c: Sort headers.
5662         * amd64-sol2-tdep.c: Sort headers.
5663         * amd64-obsd-tdep.c: Sort headers.
5664         * amd64-obsd-nat.c: Sort headers.
5665         * amd64-nbsd-tdep.c: Sort headers.
5666         * amd64-nbsd-nat.c: Sort headers.
5667         * amd64-nat.c: Sort headers.
5668         * amd64-linux-tdep.c: Sort headers.
5669         * amd64-linux-nat.c: Sort headers.
5670         * amd64-fbsd-tdep.c: Sort headers.
5671         * amd64-fbsd-nat.c: Sort headers.
5672         * amd64-dicos-tdep.c: Sort headers.
5673         * amd64-darwin-tdep.c: Sort headers.
5674         * amd64-bsd-nat.c: Sort headers.
5675         * alpha-tdep.c: Sort headers.
5676         * alpha-obsd-tdep.c: Sort headers.
5677         * alpha-nbsd-tdep.c: Sort headers.
5678         * alpha-mdebug-tdep.c: Sort headers.
5679         * alpha-linux-tdep.c: Sort headers.
5680         * alpha-linux-nat.c: Sort headers.
5681         * alpha-bsd-tdep.c: Sort headers.
5682         * alpha-bsd-nat.c: Sort headers.
5683         * aix-thread.c: Sort headers.
5684         * agent.c: Sort headers.
5685         * addrmap.c: Sort headers.
5686         * ada-varobj.c: Sort headers.
5687         * ada-valprint.c: Sort headers.
5688         * ada-typeprint.c: Sort headers.
5689         * ada-tasks.c: Sort headers.
5690         * ada-lang.c: Sort headers.
5691         * aarch64-tdep.c: Sort headers.
5692         * aarch64-ravenscar-thread.c: Sort headers.
5693         * aarch64-newlib-tdep.c: Sort headers.
5694         * aarch64-linux-tdep.c: Sort headers.
5695         * aarch64-linux-nat.c: Sort headers.
5696         * aarch64-fbsd-tdep.c: Sort headers.
5697         * aarch64-fbsd-nat.c: Sort headers.
5698         * aarch32-linux-nat.c: Sort headers.
5699
5700 2019-04-04  Tom Tromey  <tom@tromey.com>
5701
5702         * varobj.c (varobj_create): Update.
5703         * rust-exp.y (struct rust_parser) <update_innermost_block,
5704         lookup_symbol>: New methods.
5705         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5706         Rename.
5707         (rust_parser::rust_lookup_type)
5708         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5709         * printcmd.c (display_command, do_one_display): Update.
5710         * parser-defs.h (struct parser_state) <parser_state>: Add
5711         "tracker" parameter.
5712         (block_tracker): New member.
5713         (class innermost_block_tracker) <innermost_block_tracker>: Add
5714         "types" parameter.
5715         <reset>: Remove method.
5716         (innermost_block): Don't declare.
5717         (null_post_parser): Update.
5718         * parse.c (innermost_block): Remove global.
5719         (write_dollar_variable): Update.
5720         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5721         Remove "tracker_types" parameter.
5722         (parse_expression): Add "tracker" parameter.
5723         (parse_expression_for_completion): Update.
5724         (null_post_parser): Add "tracker" parameter.
5725         * p-exp.y: Update rules.
5726         * m2-exp.y: Update rules.
5727         * language.h (struct language_defn) <la_post_parser>: Add
5728         "tracker" parameter.
5729         * go-exp.y: Update rules.
5730         * f-exp.y: Update rules.
5731         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5732         parameter.
5733         * d-exp.y: Update rules.
5734         * c-exp.y: Update rules.
5735         * breakpoint.c (set_breakpoint_condition): Create an
5736         innermost_block_tracker.
5737         (watch_command_1): Likewise.
5738         * ada-lang.c (resolve): Add "tracker" parameter.
5739         (resolve_subexp): Likewise.
5740         * ada-exp.y (write_var_from_sym): Update.
5741
5742 2019-04-04  Tom Tromey  <tom@tromey.com>
5743
5744         * type-stack.h: New file.
5745         * type-stack.c: New file.
5746         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5747         type-stack.h.
5748         (insert_into_type_stack, insert_type, push_type, push_type_int)
5749         (insert_type_address_space, pop_type, pop_type_int)
5750         (pop_typelist, pop_type_stack, append_type_stack)
5751         (push_type_stack, get_type_stack, push_typelist)
5752         (follow_type_instance_flags, follow_types): Don't declare.
5753         * parse.c (type_stack): Remove global.
5754         (parse_exp_in_context): Update.
5755         (insert_into_type_stack, insert_type, push_type, push_type_int)
5756         (insert_type_address_space, pop_type, pop_type_int)
5757         (pop_typelist, pop_type_stack, append_type_stack)
5758         (push_type_stack, get_type_stack, push_typelist)
5759         (follow_type_instance_flags, follow_types): Remove (moved to
5760         type-stack.c).
5761         * f-exp.y (type_stack): New global.
5762         Update rules.
5763         (push_kind_type, f_parse): Update.
5764         * d-exp.y (type_stack): New global.
5765         Update rules.
5766         (d_parse): Update.
5767         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5768         Update rules.
5769         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5770         (HFILES_NO_SRCDIR): Add type-stack.h.
5771
5772 2019-04-04  Tom Tromey  <tom@tromey.com>
5773
5774         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5775         (rust_parser::convert_ast_to_expression, rust_parse)
5776         (rust_lex_test_completion, rust_lex_tests): Update.
5777         * parser-defs.h (struct expr_completion_state): New.
5778         (struct parser_state) <parser_state>: Add completion parameter.
5779         <mark_struct_expression, mark_completion_tag>: New methods.
5780         <parse_completion, m_completion_state>: New members.
5781         (prefixify_expression, null_post_parser): Update.
5782         (mark_struct_expression, mark_completion_tag): Don't declare.
5783         * parse.c (parse_completion, expout_last_struct)
5784         (expout_tag_completion_type, expout_completion_name): Remove
5785         globals.
5786         (parser_state::mark_struct_expression)
5787         (parser_state::mark_completion_tag): Now methods.
5788         (prefixify_expression): Add last_struct parameter.
5789         (prefixify_subexp): Likewise.
5790         (parse_exp_1): Update.
5791         (parse_exp_in_context): Add cstate parameter.  Update.
5792         (parse_expression_for_completion): Create an
5793         expr_completion_state.
5794         (null_post_parser): Add "completion" parameter.
5795         * p-exp.y: Update rules.
5796         (yylex): Update.
5797         * language.h (struct language_defn) <la_post_parser>: Add
5798         "completing" parameter.
5799         * go-exp.y: Update rules.
5800         (lex_one_token): Update.
5801         * expression.h (parse_completion): Don't declare.
5802         * d-exp.y: Update rules.
5803         (lex_one_token): Update rules.
5804         * c-exp.y: Update rules.
5805         (lex_one_token): Update.
5806         * ada-lang.c (resolve): Add "parse_completion" parameter.
5807         (resolve_subexp): Likewise.
5808         (ada_resolve_function): Likewise.
5809
5810 2019-04-04  Tom Tromey  <tom@tromey.com>
5811
5812         * parser-defs.h (struct parser_state) <start_arglist,
5813         end_arglist>: New methods.
5814         <arglist_len, m_funcall_chain>: New members.
5815         (arglist_len, start_arglist, end_arglist): Don't declare.
5816         * parse.c (arglist_len, funcall_chain): Remove global.
5817         (start_arglist, end_arglist): Remove functions.
5818         (parse_exp_in_context): Update.
5819         * p-exp.y: Update rules.
5820         * m2-exp.y: Update rules.
5821         * go-exp.y: Update rules.
5822         * f-exp.y: Update rules.
5823         * d-exp.y: Update rules.
5824         * c-exp.y: Update rules.
5825
5826 2019-04-04  Tom Tromey  <tom@tromey.com>
5827
5828         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5829         lex_operator, push_back>: New methods.
5830         Update all rules.
5831         (rust_parser::lex_hex, lex_escape): Rename and update.
5832         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5833         (rust_parser::lex_operator): Rename and update.
5834         (rust_parser::lex_number, rustyylex, rustyyerror)
5835         (rust_lex_test_init, rust_lex_test_sequence)
5836         (rust_lex_test_push_back, rust_lex_tests): Update.
5837         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5838         parameter.
5839         <lexptr, prev_lexptr>: New members.
5840         (lexptr, prev_lexptr): Don't declare.
5841         * parse.c (lexptr, prev_lexptr): Remove globals.
5842         (parse_exp_in_context): Update.
5843         * p-exp.y (yylex, yyerror): Update.
5844         * m2-exp.y (parse_number, yylex, yyerror): Update.
5845         * go-exp.y (lex_one_token, yyerror): Update.
5846         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5847         * d-exp.y (lex_one_token, yyerror): Update.
5848         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5849         (lex_one_token, yyerror): Update.
5850         * ada-lex.l (YY_INPUT): Update.
5851         (rewind_to_char): Update.
5852         * ada-exp.y (yyerror): Update.
5853
5854 2019-04-04  Tom Tromey  <tom@tromey.com>
5855
5856         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5857         * parser-defs.h (struct parser_state) <parser_state>: Add new
5858         parameter.
5859         <comma_terminates>: New member.
5860         (comma_terminates): Don't declare global.
5861         * parse.c (comma_terminates): Remove global.
5862         (parse_exp_in_context): Update.
5863         * p-exp.y (yylex): Update.
5864         * m2-exp.y (yylex): Update.
5865         * go-exp.y (lex_one_token): Update.
5866         * f-exp.y (yylex): Update.
5867         * d-exp.y (lex_one_token): Update.
5868         * c-exp.y (lex_one_token): Update.
5869         * ada-lex.l: Update.
5870
5871 2019-04-04  Tom Tromey  <tom@tromey.com>
5872
5873         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5874         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5875         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5876         * parser-defs.h (paren_depth): Don't declare.
5877         * parse.c (paren_depth): Remove global.
5878         (parse_exp_in_context): Update.
5879         * p-exp.y (paren_depth): New global.
5880         (pascal_parse): Initialize it.
5881         * m2-exp.y (paren_depth): New global.
5882         (m2_parse): Initialize it.
5883         * go-exp.y (paren_depth): New global.
5884         (go_parse): Initialize it.
5885         * f-exp.y (paren_depth): New global.
5886         (f_parse): Initialize it.
5887         * d-exp.y (paren_depth): New global.
5888         (d_parse): Initialize it.
5889         * c-exp.y (paren_depth): New global.
5890         (c_parse): Initialize it.
5891         * ada-lex.l (paren_depth): New global.
5892         (lexer_init): Initialize it.
5893
5894 2019-04-04  Tom Tromey  <tom@tromey.com>
5895
5896         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5897         (rust_parser::convert_ast_to_type)
5898         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5899         * parser-defs.h (struct parser_state) <parser_state>: Add
5900         parameters.  Initialize new members.
5901         <expression_context_block, expression_context_pc>: New members.
5902         * parse.c (expression_context_block, expression_context_pc):
5903         Remove globals.
5904         (parse_exp_in_context): Update.
5905         * p-exp.y: Update all rules.
5906         (yylex): Update.
5907         * m2-exp.y: Update all rules.
5908         (yylex): Update.
5909         * go-exp.y (yylex): Update.
5910         * f-exp.y (yylex): Update.
5911         * d-exp.y: Update all rules.
5912         (yylex): Update.
5913         * c-exp.y: Update all rules.
5914         (lex_one_token, classify_name, yylex, c_parse): Update.
5915         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5916
5917 2019-04-04  Tom Tromey  <tom@tromey.com>
5918
5919         * gdbarch.h, gdbarch.c: Rebuild.
5920         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5921         * stap-probe.h:
5922         (struct stap_parse_info): Replace "parser_state" with
5923         "expr_builder".
5924         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5925         (parser_state): New class.
5926         * parse.c (expr_builder): Rename.
5927         (expr_builder::release): Rename.
5928         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5929         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5930         (write_exp_elt_longcst, write_exp_elt_floatcst)
5931         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5932         (write_exp_string_vector, write_exp_bitstring)
5933         (write_exp_msymbol, mark_struct_expression)
5934         (write_dollar_variable)
5935         (insert_type_address_space, increase_expout_size): Replace
5936         "parser_state" with "expr_builder".
5937         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5938         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5939         "parser_state" with "expr_builder".
5940
5941 2019-04-04  Tom Tromey  <tom@tromey.com>
5942
5943         * rust-exp.y: Replace "parse_language" with method call.
5944         * p-exp.y:
5945         (yylex): Replace "parse_language" with method call.
5946         * m2-exp.y:
5947         (yylex): Replace "parse_language" with method call.
5948         * go-exp.y (classify_name): Replace "parse_language" with method
5949         call.
5950         * f-exp.y (yylex): Replace "parse_language" with method call.
5951         * d-exp.y (lex_one_token): Replace "parse_language" with method
5952         call.
5953         * c-exp.y:
5954         (lex_one_token, classify_name, yylex): Replace "parse_language"
5955         with method call.
5956         * ada-exp.y (find_primitive_type, type_char)
5957         (type_system_address): Replace "parse_language" with method call.
5958
5959 2019-04-04  Tom Tromey  <tom@tromey.com>
5960
5961         * rust-exp.y: Replace "parse_gdbarch" with method call.
5962         * parse.c (write_dollar_variable, insert_type_address_space):
5963         Replace "parse_gdbarch" with method call.
5964         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5965         call.
5966         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5967         call.
5968         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5969         "parse_gdbarch" with method call.
5970         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5971         with method call.
5972         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5973         "parse_gdbarch" with method call.
5974         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5975         "parse_gdbarch" with method call.
5976         * c-exp.y (parse_type, parse_number, classify_name): Replace
5977         "parse_gdbarch" with method call.
5978         * ada-lex.l: Replace "parse_gdbarch" with method call.
5979         * ada-exp.y (parse_type, find_primitive_type, type_char)
5980         (type_system_address): Replace "parse_gdbarch" with method call.
5981
5982 2019-04-04  Tom Tromey  <tom@tromey.com>
5983
5984         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5985         * stap-probe.c (stap_parse_argument): Update.
5986         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5987         initial_size parameter.
5988         * rust-exp.y (rust_lex_tests): Update.
5989         * parse.c (parser_state): Update.
5990         (parse_exp_in_context): Update.
5991         * parser-defs.h (struct parser_state) <parser_state>: Remove
5992         "initial_size" parameter.
5993
5994 2019-04-04  Tom Tromey  <tom@tromey.com>
5995
5996         * parser-defs.h (increase_expout_size): Don't declare.
5997         * parse.c (increase_expout_size): Now static.
5998
5999 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6000
6001         * gnu-nat.c (gnu_nat_target::wait): Fix
6002         target_waitstatus_to_string call.
6003
6004 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * eval.c (evaluate_subexp_standard): Handle internal functions
6007         during Fortran function call handling.
6008
6009 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6010
6011         * NEWS: Mention new internal functions.
6012         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6013         (read_base_type): Use dwarf2_init_complex_target_type.
6014         * value.c (creal_internal_fn): New function.
6015         (cimag_internal_fn): New function.
6016         (_initialize_values): Register new internal functions.
6017
6018 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6019
6020         * infrun.c (stop_all_threads): If debug_infrun, always
6021         trace the wait status after wait_one, using
6022         target_waitstatus_to_string and target_pid_to_str.
6023         (handle_inferior_event): Replace various trace of
6024         wait status kind by a single trace.
6025         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6026         wait status kind image by target_waitstatus_to_string.
6027         * target/waitstatus.c (target_waitstatus_to_string): Fix
6028         obsolete comment.
6029
6030 2019-04-01  Tom Tromey  <tromey@adacore.com>
6031
6032         PR symtab/23331:
6033         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6034
6035 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6036             Pedro Alves  <palves@redhat.com>
6037
6038         * top.c (quit_force): Call 'finalize_values'.
6039         * value.c (finalize_values): New function.
6040         * value.h (finalize_values): Declare.
6041
6042 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6043
6044         * NEWS: Announce $_gdb_major and $_gdb_minor.
6045
6046         * top.c (init_gdb_version_vars): New function.
6047         (gdb_init): Call init_gdb_version_vars.
6048
6049 2019-03-29  Tom Tromey  <tromey@adacore.com>
6050
6051         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6052         help text.  Remove dead code.
6053
6054 2019-03-29  Keith Seitz  <keiths@redhat.com>
6055
6056         From Siddhesh Poyarekar:
6057         * f-lang.h (f77_get_upperbound): Return LONGEST.
6058         (f77_get_lowerbound): Likewise.
6059         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6060         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6061         print them.
6062         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6063         plongest to format print it.
6064         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6065         (f77_get_upperbound): Likewise.
6066         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6067         LOWER_BOUND to LONGEST.
6068         (f77_create_arrayprint_offset_tbl): Likewise.
6069
6070 2019-03-29  Keith Seitz  <keiths@redhat.com>
6071
6072         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6073         %s/pulongest for TYPE_LENGTH instead of %d in format
6074         strings.
6075         * ada-typerint.c (ada_print_type): Likewise.
6076         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6077         * compile/compile-c-support.c (generate_register_struct): Likewise.
6078         * gdbtypes.c (recursive_dump_type): Likewise.
6079         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6080         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6081         instead of %d in format strings.
6082         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6083         to std::min to ULONGEST.
6084         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6085         instead of %d in format strings.
6086         * tracepoint.c (info_scope_command): Likewise.
6087         * typeprint.c (print_offset_data::update)
6088         (print_offset_data::finish): Likewise.
6089         * xtensa-tdep.c (xtensa_store_return_value)
6090         (xtensa_push_dummy_call): Likewise.
6091
6092 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6093
6094         * windows-nat.c (display_selector): Fixed format specifications
6095         for 64-bit Cygwin.
6096
6097 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6098
6099         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6100
6101 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6102
6103         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6104         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6105         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6106         (nios2_linux_init_abi): Install it.
6107
6108 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6109
6110         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6111
6112 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6113
6114         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6115
6116 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6117             Tom Tromey  <tromey@adacore.com>
6118
6119         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6120
6121 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6122
6123         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6124         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6125         method to compute the bounds of range types. Also print "[evaluated]"
6126         if the bounds' values come from a dynamic evaluation.
6127
6128 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6129
6130         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6131         whitespace when pretty printing is on.
6132
6133 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6134
6135         * ppc-linux-nat.c: Add include.
6136
6137 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6138
6139         * NEWS: Mention AArch64 Pointer Authentication.
6140
6141 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6142
6143         * arm-linux-nat.c: Add include.
6144
6145 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6146
6147         * source-cache.c (source_cache::get_source_lines): Re-read
6148         fullname after calling open_source_file.
6149
6150 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6151
6152         * NEWS: Mention TLS support for FreeBSD.
6153
6154 2019-03-25  Tom Tromey  <tromey@adacore.com>
6155
6156         * minsyms.c (BUNCH_SIZE): Update comment.
6157         (~minimal_symbol_reader): Remove old comment.
6158         (compact_minimal_symbols): Update comment.
6159         (minimal_symbol_reader::install): Remove old comment.  Update
6160         other comments.
6161
6162 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6163
6164         * s390-linux-nat.c: Add include.
6165
6166 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6167
6168         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6169         Call linux_get_hwcap.
6170         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6171         Likewise.
6172         (aarch64_linux_get_hwcap): Remove function.
6173         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6174         declaration.
6175         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6176         linux_get_hwcap.
6177         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6178         * linux-tdep.c (linux_get_hwcap): Add function.
6179         (linux_get_hwcap2): Likewise.
6180         * linux-tdep.h (linux_get_hwcap): Add declaration.
6181         (linux_get_hwcap2): Likewise.
6182         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6183         (ppc_linux_get_hwcap2): Likewise.
6184         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6185         linux_get_hwcap.
6186         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6187         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6188         (ppc_linux_nat_target::read_description): Likewise.
6189         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6190         * s390-linux-nat.c: Likewise.
6191         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6192
6193 2019-03-24  Tom Tromey  <tom@tromey.com>
6194
6195         * ada-lang.c (standard_lookup): Simplify initialization.
6196         (ada_lookup_symbol_nonlocal): Simplify return.
6197         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6198         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6199         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6200         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6201         initialization.
6202         * solib.c (solib_global_lookup): Simplify.
6203         * symtab.c (null_block_symbol): Remove.
6204         (symbol_cache_lookup): Simplify returns.
6205         (lookup_language_this): Simplify returns.
6206         (lookup_symbol_aux): Simplify return.
6207         (lookup_local_symbol): Simplify returns.
6208         (lookup_global_symbol_from_objfile): Simplify return.
6209         (lookup_symbol_in_objfile_symtabs)
6210         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6211         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6212         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6213         * cp-namespace.c (cp_lookup_bare_symbol)
6214         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6215         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6216         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6217         (cp_lookup_symbol_via_imports): Simplify initialization.
6218         (find_symbol_in_baseclass): Likewise.
6219         * symtab.h (null_block_symbol): Remove.
6220         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6221         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6222         (d_lookup_symbol_module): Likewise.
6223         (find_symbol_in_baseclass): Simplify initialization.
6224
6225 2019-03-24  Tom Tromey  <tom@tromey.com>
6226
6227         * expression.h: Don't include symtab.h.
6228         (struct block): Forward declare.
6229
6230 2019-03-24  Tom Tromey  <tom@tromey.com>
6231
6232         * c-exp.y (typebase): Remove casts.
6233         * gdbtypes.c (lookup_unsigned_typename, )
6234         (lookup_signed_typename): Remove cast.
6235         * eval.c (parse_to_comma_and_eval): Remove cast.
6236         * parse.c (write_dollar_variable): Remove cast.
6237         * block.h (struct block) <superblock>: Now const.
6238         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6239         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6240         (map_block): Make "block" const.
6241         * symfile.h (struct quick_symbol_functions)
6242         <map_matching_symbols>: Constify block argument to "callback".
6243         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6244         const.
6245         (find_pc_sect_compunit_symtab): Make "b" const.
6246         (find_symbol_at_address): Likewise.
6247         (search_symbols): Likewise.
6248         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6249         (dw2_debug_names_lookup_symbol): Likewise.
6250         (dw2_map_matching_symbols): Update.
6251         * p-valprint.c (pascal_val_print): Remove "block".
6252         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6253         (aux_add_nonlocal_symbols): Make "block" const.
6254         (resolve_subexp): Remove cast.
6255         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6256         const.
6257         (iterate_over_file_blocks): Likewise.
6258         * f-exp.y (%union) <bval>: Remove.
6259         * coffread.c (patch_opaque_types): Make "b" const.
6260         * spu-tdep.c (spu_catch_start): Make "block" const.
6261         * c-valprint.c (print_unpacked_pointer): Remove "block".
6262         * symmisc.c (dump_symtab_1): Make "b" const.
6263         (block_depth): Make "block" const.
6264         * d-exp.y (%union) <bval>: Remove.
6265         * cp-support.h (cp_lookup_rtti_type): Update.
6266         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6267         * psymtab.c (psym_lookup_symbol): Make "block" const.
6268         (maintenance_check_psymtabs): Make "b" const.
6269         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6270         (enumerate_locals, enumerate_args): Update.
6271         * python/py-symtab.c (stpy_global_block): Make "block" const.
6272         (stpy_static_block): Likewise.
6273         * inline-frame.c (block_starting_point_at): Make "new_block"
6274         const.
6275         * block.c (find_block_in_blockvector): Make return type const.
6276         (blockvector_for_pc_sect): Make "b" const.
6277         (find_block_in_blockvector): Make "b" const.
6278
6279 2019-03-23  Tom Tromey  <tom@tromey.com>
6280
6281         * varobj.c (varobj_create): Update.
6282         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6283         * printcmd.c (display_command, do_one_display): Don't reset
6284         innermost_block.
6285         * parser-defs.h (enum innermost_block_tracker_type): Move to
6286         expression.h.
6287         (innermost_block): Update comment.
6288         * parse.c (parse_exp_1): Add tracker_types parameter.
6289         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6290         tracker_types parameter.  Reset innermost_block.
6291         (parse_exp_in_context): Remove.
6292         (parse_expression_for_completion): Update.
6293         * objfiles.c (~objfile): Don't reset expression_context_block or
6294         innermost_block.
6295         * expression.h (enum innermost_block_tracker_type): Move from
6296         parser-defs.h.
6297         (parse_exp_1): Add tracker_types parameter.
6298         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6299         reset innermost_block.
6300
6301 2019-03-23  Tom Tromey  <tom@tromey.com>
6302
6303         * objfiles.h: Include bcache.h.
6304
6305 2019-03-23  Tom Tromey  <tom@tromey.com>
6306
6307         * linespec.c (get_current_search_block): Use
6308         scoped_restore_current_language.
6309         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6310
6311 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6312             Jiong Wang  <jiong.wang@arm.com>
6313
6314         * aarch64-linux-tdep.c
6315         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6316         section.
6317         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6318
6319 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6320             Jiong Wang  <jiong.wang@arm.com>
6321
6322         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6323         instructions.
6324         (aarch64_analyze_prologue_test): Add PACIASP test.
6325         (aarch64_prologue_prev_register): Unmask PC value.
6326
6327 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6328             Jiong Wang  <jiong.wang@arm.com>
6329
6330         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6331         (aarch64_dwarf2_prev_register): Unmask PC value.
6332         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6333         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6334         DW_CFA_AARCH64_negate_ra_state.
6335         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6336
6337 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6338             Jiong Wang  <jiong.wang@arm.com>
6339
6340         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6341         registers.
6342         (aarch64_pseudo_register_name): Likewise.
6343         (aarch64_pseudo_register_type): Likewise.
6344         (aarch64_pseudo_register_reggroup_p): Likewise.
6345         (aarch64_gdbarch_init): Add pauth registers.
6346         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6347         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6348         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6349         (struct gdbarch_tdep): Add regnum for ra_state.
6350
6351 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6352             Jiong Wang  <jiong.wang@arm.com>
6353
6354         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6355
6356 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6357             Jiong Wang  <jiong.wang@arm.com>
6358
6359         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6360         function.
6361         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6362         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6363         (aarch64_gdbarch_init): Add puth registers.
6364         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6365         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6366         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6367
6368 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6369             Jiong Wang  <jiong.wang@arm.com>
6370
6371         * aarch64-linux-nat.c
6372         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6373         * aarch64-linux-tdep.c
6374         (aarch64_linux_core_read_description): Likewise.
6375         (aarch64_linux_get_hwcap): New function.
6376         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6377         (aarch64_linux_get_hwcap): New declaration.
6378
6379 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6380             Jiong Wang  <jiong.wang@arm.com>
6381
6382         * aarch64-linux-nat.c
6383         (aarch64_linux_nat_target::read_description): Add pauth param.
6384         * aarch64-linux-tdep.c
6385         (aarch64_linux_core_read_description): Likewise.
6386         * aarch64-tdep.c (struct target_desc): Add in pauth.
6387         (aarch64_read_description): Add pauth param.
6388         (aarch64_gdbarch_init): Likewise.
6389         * aarch64-tdep.h (aarch64_read_description): Likewise.
6390         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6391         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6392         * features/Makefile: Add new files.
6393         * features/aarch64-pauth.c: New file.
6394         * features/aarch64-pauth.xml: New file.
6395
6396 2019-03-20  Tom Tromey  <tromey@adacore.com>
6397
6398         * infrun.c (handle_inferior_event): Rename from
6399         handle_inferior_event_1.  Create a scoped_value_mark.
6400         (handle_inferior_event): Remove.
6401
6402 2019-03-19  Tom Tromey  <tromey@adacore.com>
6403
6404         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6405         * infrun.h (print_stop_event): Add "displays" parameter.
6406         * infrun.c (print_stop_event): Add "displays" parameter.
6407
6408 2019-03-19  Pedro Alves  <palves@redhat.com>
6409
6410         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6411         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6412         to -1.  Fix TABs vs spaces.
6413         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6414         * tui/tui-out.h (tui_ui_out) Add intro comments.
6415         <m_line, m_start_of_line>: In-class initialize, and add describing
6416         comment.
6417
6418 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6419
6420         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6421         variable names.
6422         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6423
6424 2019-03-18  Pedro Alves  <palves@redhat.com>
6425             Eli Zaretskii <eliz@gnu.org>
6426
6427         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6428         m_line and m_start_of_line.
6429
6430 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6431
6432         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6433         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6434         it returns a newline.  This fixes a regression in TU mode, whereby
6435         the next line is output on the same screen line as the user input.
6436
6437 2019-03-18  Tom Tromey  <tromey@adacore.com>
6438
6439         * minsyms.c (minimal_symbol_reader::install): Remove call to
6440         obstack_blank.
6441
6442 2019-03-18  Pedro Alves  <palves@redhat.com>
6443
6444         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6445         New globals.
6446         (apply_style): New, factored out from ...
6447         (apply_ansi_escape): ... this.  Handle reverse video mode.
6448         (tui_set_reverse_mode): New function.
6449         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6450         * tui/tui-winsource.c (tui_show_source_line): Use
6451         tui_set_reverse_mode instead of setting A_STANDOUT.
6452         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6453         New setter methods.
6454
6455 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6456
6457         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6458         Handle tabs.
6459
6460 2019-03-18  Tom Tromey  <tromey@adacore.com>
6461
6462         * ada-lang.c (empty_array): Add "high" parameter.
6463         (ada_evaluate_subexp): Update.
6464
6465 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6466
6467         * unittests/string_view-selftests.c: Define
6468         _initialize_string_view_selftests unconditionally.
6469
6470 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6471
6472         PR gdb/24350
6473         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6474
6475 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6476
6477         PR gdb/24351
6478         * windows-nat.c (display_selector): Fix format specifiers.
6479
6480 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6481
6482         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6483         tui_refill_source_window instead of tui_refresh_win, to update the
6484         current execution line.  This fixes redisplay of the current line
6485         when stepping through the code with "next" or "step".
6486
6487 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6488
6489         * source-cache.c (source_cache::get_source_lines): Call
6490         find_source_lines to initialize s->nlines.  This fixes vertical
6491         scrolling of TUI source window when the DOWN arrow is pressed.
6492
6493 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6494
6495         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6496         linux-thread-db.c (_initialize_thread_db): Likewise.
6497
6498 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6499
6500         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6501         wclrtoeol in tui_show_source_line".  This reverts changes made in
6502         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6503
6504 2019-03-15  Tom Tromey  <tom@tromey.com>
6505
6506         * symtab.h (struct minimal_symbol): Derive from
6507         general_symbol_info.
6508         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6509         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6510         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6511         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6512         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6513         (MSYMBOL_SEARCH_NAME): Update.
6514         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6515         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6516         * minsyms.c (minimal_symbol_reader::record_full): Update.
6517
6518 2019-03-15  Tom Tromey  <tom@tromey.com>
6519
6520         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6521
6522 2019-03-15  Tom Tromey  <tom@tromey.com>
6523
6524         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6525         unique_xmalloc_ptr.
6526         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6527         Update.
6528         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6529         (build_minimal_symbol_hash_tables)
6530         (minimal_symbol_reader::install): Update.
6531
6532 2019-03-15  Tom Tromey  <tom@tromey.com>
6533
6534         * symtab.c (create_demangled_names_hash): Update.
6535         (symbol_set_names): Update.
6536         * objfiles.h (struct objfile_per_bfd_storage)
6537         <demangled_names_hash>: Now an htab_up.
6538         * objfiles.c (objfile_per_bfd_storage): Simplify.
6539
6540 2019-03-15  Tom Tromey  <tom@tromey.com>
6541
6542         * objfiles.h (struct objfile_per_bfd_storage): Declare
6543         destructor.
6544         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6545         New.
6546         (get_objfile_bfd_data): Use new.  Don't initialize
6547         language_of_main.
6548         (free_objfile_per_bfd_storage): Remove.
6549         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6550
6551 2019-03-15  Tom Tromey  <tom@tromey.com>
6552
6553         * symfile.c (reread_symbols): Update.
6554         * objfiles.c (objfile::objfile): Update.
6555         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6556         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6557         comment.
6558         (minimal_symbol_reader::install): Update.
6559         (terminate_minimal_symbol_table): Remove.
6560         * jit.c (jit_object_close_impl): Update.
6561
6562 2019-03-15  Tom Tromey  <tom@tromey.com>
6563
6564         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6565         initializations.
6566
6567 2019-03-15  Tom Tromey  <tom@tromey.com>
6568
6569         * objfiles.h (struct objfile_per_bfd_storage)
6570         <demangled_hash_languages>: Now a bitset.
6571         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6572         (lookup_minimal_symbol): Update.
6573
6574 2019-03-15  Tom Tromey  <tom@tromey.com>
6575
6576         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6577         Don't return the symbol.
6578         * coffread.c (record_minimal_symbol): Use record_full.
6579
6580 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6581
6582         The MS-Windows port of ncurses fails to switch to a color pair if
6583         one or both of the colors are the implicit default colors.  This
6584         change records the default colors when TUI is initialized, and
6585         then specifies them explicitly when a color pair uses the default
6586         colors.  This allows color styling in TUI mode on MS-Windows.
6587
6588         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6589         ncurses_norm_attr.
6590         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6591         colors in ncurses_norm_attr.
6592         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6593         "none", replace it with the default color recorded in
6594         ncurses_norm_attr.
6595
6596 2019-03-14  Tom Tromey  <tromey@adacore.com>
6597
6598         * source-cache.h (class source_cache) <get_source_lines>: Return
6599         std::string.
6600         * source-cache.c (source_cache::extract_lines): Handle case where
6601         first_pos==npos.  Return std::string.
6602         (source_cache::get_source_lines): Update.
6603
6604 2019-03-14  Tom Tromey  <tromey@adacore.com>
6605
6606         * NEWS: Add item for "style sources" commands.
6607         * source-cache.c (source_cache::get_source_lines): Check
6608         source_styling.
6609         * cli/cli-style.c (source_styling): New global.
6610         (_initialize_cli_style): Add "style sources" commands.
6611         (show_style_sources): New function.
6612         * cli/cli-style.h (source_styling): Declare.
6613
6614 2019-03-14  Pedro Alves  <palves@redhat.com>
6615             Tom Tromey  <tromey@adacore.com>
6616
6617         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6618         * tui/tui-winsource.c (tui_refill_source_window): New function,
6619         from...
6620         (tui_horizontal_source_scroll): ... here.  Move some logic.
6621         * cli/cli-style.c (set_style_enabled): Notify new observable.
6622         * tui/tui-hooks.c (tui_redisplay_source): New function.
6623         (tui_attach_detach_observers): Attach or detach
6624         tui_redisplay_source.
6625         * observable.h (source_styling_changed): New observable.
6626         * observable.c: Define source_styling_changed observable.
6627
6628 2019-03-13  Tom Tromey  <tromey@adacore.com>
6629
6630         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6631         (i386_gnu_nat_target::store_registers): Update.
6632         * target-debug.h (target_debug_print_std_string): New macro.
6633         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6634         * windows-tdep.c (display_one_tib): Update.
6635         * tui/tui-stack.c (tui_make_status_line): Update.
6636         * top.c (print_inferior_quit_action): Update.
6637         * thread.c (thr_try_catch_cmd): Update.
6638         (add_thread_with_info): Update.
6639         (thread_target_id_str): Update.
6640         (thr_try_catch_cmd): Update.
6641         (thread_command): Update.
6642         (thread_find_command): Update.
6643         * record-btrace.c (record_btrace_target::info_record)
6644         (record_btrace_resume_thread, record_btrace_target::resume)
6645         (record_btrace_cancel_resume, record_btrace_step_thread)
6646         (record_btrace_target::wait, record_btrace_target::wait)
6647         (record_btrace_target::wait, record_btrace_target::stop): Update.
6648         * progspace.c (print_program_space): Update.
6649         * process-stratum-target.c
6650         (process_stratum_target::thread_address_space): Update.
6651         * linux-fork.c (linux_fork_mourn_inferior)
6652         (detach_checkpoint_command, info_checkpoints_command)
6653         (linux_fork_context): Update.
6654         (linux_fork_detach): Update.
6655         (class scoped_switch_fork_info): Update.
6656         (delete_checkpoint_command): Update.
6657         * infrun.c (follow_fork_inferior): Update.
6658         (follow_fork_inferior): Update.
6659         (proceed_after_vfork_done): Update.
6660         (handle_vfork_child_exec_or_exit): Update.
6661         (follow_exec): Update.
6662         (displaced_step_prepare_throw): Update.
6663         (displaced_step_restore): Update.
6664         (start_step_over): Update.
6665         (resume_1): Update.
6666         (clear_proceed_status_thread): Update.
6667         (proceed): Update.
6668         (print_target_wait_results): Update.
6669         (do_target_wait): Update.
6670         (context_switch): Update.
6671         (stop_all_threads): Update.
6672         (restart_threads): Update.
6673         (finish_step_over): Update.
6674         (handle_signal_stop): Update.
6675         (switch_back_to_stepped_thread): Update.
6676         (keep_going_pass_signal): Update.
6677         (print_exited_reason): Update.
6678         (normal_stop): Update.
6679         * inferior.c (inferior_pid_to_str): Change return type.
6680         (print_selected_inferior): Update.
6681         (add_inferior): Update.
6682         (detach_inferior): Update.
6683         * dummy-frame.c (fprint_dummy_frames): Update.
6684         * dcache.c (dcache_info_1): Update.
6685         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6686         (btrace_fetch, btrace_clear): Update.
6687         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6688         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6689         type.
6690         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6691         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6692         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6693         * gdbarch.c, gdbarch.h: Rebuild.
6694         * gdbarch.sh (core_pid_to_str): Change return type.
6695         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6696         return type.
6697         (windows_nat_target::pid_to_str): Change return type.
6698         (windows_delete_thread): Update.
6699         (windows_nat_target::attach): Update.
6700         (windows_nat_target::files_info): Update.
6701         * target-delegates.c: Rebuild.
6702         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6703         return type.
6704         (sol_thread_target::pid_to_str): Change return type.
6705         * remote.c (class remote_target) <pid_to_str>: Change return
6706         type.
6707         (remote_target::pid_to_str): Change return type.
6708         (extended_remote_target::attach, remote_target::remote_stop_ns)
6709         (remote_target::remote_notif_remove_queued_reply)
6710         (remote_target::push_stop_reply, remote_target::disable_btrace):
6711         Update.
6712         (extended_remote_target::attach): Update.
6713         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6714         type.
6715         (gdbsim_target::pid_to_str): Change return type.
6716         * ravenscar-thread.c (struct ravenscar_thread_target)
6717         <pid_to_str>: Change return type.
6718         (ravenscar_thread_target::pid_to_str): Change return type.
6719         * procfs.c (class procfs_target) <pid_to_str>: Change return
6720         type.
6721         (procfs_target::pid_to_str): Change return type.
6722         (procfs_target::attach): Update.
6723         (procfs_target::detach): Update.
6724         (procfs_target::fetch_registers): Update.
6725         (procfs_target::store_registers): Update.
6726         (procfs_target::wait): Update.
6727         (procfs_target::files_info): Update.
6728         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6729         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6730         return type.
6731         (nto_procfs_target::pid_to_str): Change return type.
6732         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6733         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6734         return type.
6735         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6736         (exit_lwp): Update.
6737         (attach_proc_task_lwp_callback, get_detach_signal)
6738         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6739         (linux_nat_target::resume, wait_lwp, stop_callback)
6740         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6741         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6742         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6743         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6744         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6745         type.
6746         (inf_ptrace_target::attach): Update.
6747         (inf_ptrace_target::files_info): Update.
6748         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6749         type.
6750         (go32_nat_target::pid_to_str): Change return type.
6751         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6752         (gnu_nat_target::wait): Update.
6753         (gnu_nat_target::wait): Update.
6754         (gnu_nat_target::resume): Update.
6755         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6756         (fbsd_nat_target::wait): Update.
6757         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6758         type.
6759         (darwin_nat_target::attach): Update.
6760         * corelow.c (class core_target) <pid_to_str>: Change return type.
6761         (core_target::pid_to_str): Change return type.
6762         * target.c (normal_pid_to_str): Change return type.
6763         (default_pid_to_str): Likewise.
6764         (target_pid_to_str): Change return type.
6765         (target_translate_tls_address): Update.
6766         (target_announce_detach): Update.
6767         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6768         return type.
6769         (bsd_uthread_target::pid_to_str): Change return type.
6770         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6771         type.
6772         (bsd_kvm_target::pid_to_str): Change return type.
6773         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6774         return type.
6775         (aix_thread_target::pid_to_str): Change return type.
6776         * target.h (struct target_ops) <pid_to_str>: Change return type.
6777         (target_pid_to_str, normal_pid_to_str): Likewise.
6778         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6779         type.
6780         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6781         type.
6782         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6783         return type.
6784         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6785         type.
6786         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6787         type.
6788         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6789         return type.
6790
6791 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6792
6793         * NEWS: Mention that the new default MI version is 3.  Mention
6794         changes to the output of commands and events that deal with
6795         multi-location breakpoints.
6796         * breakpoint.c: Include "mi/mi-out.h".
6797         (print_one_breakpoint): Change output syntax if using MI version
6798         >= 3.
6799         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6800         New.
6801         (mi_multi_location_breakpoint_output_fixed): New.
6802         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6803         (mi_cmd_fix_multi_location_breakpoint_output): New.
6804         (mi_multi_location_breakpoint_output_fixed): New.
6805         * mi/mi-cmds.c (mi_cmds): Register command
6806         -fix-multi-location-breakpoint-output.
6807         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6808         interpreter "mi".
6809
6810 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6811
6812         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6813         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6814         instantiate mi_ui_out based on interpreter name.
6815         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6816         * mi/mi-main.c (mi_load_progress): Likewise.
6817
6818 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6819
6820         * NEWS: Combine separate "New targets" sections for 8.3.
6821
6822 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6823
6824         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6825         (ppcfbsd_init_abi): Install gdbarch
6826         "fetch_tls_load_module_address" and "get_thread_local_address"
6827         methods.
6828
6829 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6830
6831         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6832         (riscv_fbsd_init_abi): Install gdbarch
6833         "fetch_tls_load_module_address" and "get_thread_local_address"
6834         methods.
6835
6836 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6837
6838         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6839         (i386fbsd_init_abi): Install gdbarch
6840         "fetch_tls_load_module_address" and "get_thread_local_address"
6841         methods.
6842
6843 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6844
6845         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6846         (amd64fbsd_init_abi): Install gdbarch
6847         "fetch_tls_load_module_address" and "get_thread_local_address"
6848         methods.
6849
6850 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6851
6852         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6853         (struct fbsd_pspace_data): New type.
6854         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6855         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6856         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6857         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6858         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6859
6860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6861
6862         * gdbtypes.c (lookup_struct_elt): New function.
6863         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6864         * gdbtypes.h (struct struct_elt): New type.
6865         (lookup_struct_elt): New prototype.
6866
6867 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6868
6869         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6870         remove disabled code block.
6871
6872 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6873
6874         * gdbarch.sh (get_thread_local_address): New method.
6875         * gdbarch.h, gdbarch.c: Regenerate.
6876         * target.c (target_translate_tls_address): Use
6877         gdbarch_get_thread_local_address if present instead of
6878         target::get_thread_local_address.
6879
6880 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6881
6882         * target.h (target::get_thread_local_address): Update comment.
6883
6884 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6885
6886         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6887         objfile->separate_debug_objfile_backlink if not NULL.
6888
6889 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6890
6891         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6892         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6893         (amd64bsd_store_inferior_registers): Likewise.
6894         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6895         Enable segment base registers.
6896         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6897         PT_GETFSBASE and PT_GETGSBASE.
6898         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6899         PT_SETGSBASE.
6900         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6901         segment base registers.
6902         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6903
6904 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6905
6906         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6907         Update calls to i386_target_description to add 'segments'
6908         parameter.
6909         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6910         add segment base registers.
6911         * arch/i386.c (i386_create_target_description): Add 'segments'
6912         parameter to enable segment base registers.
6913         * arch/i386.h (i386_create_target_description): Likewise.
6914         * features/i386/32bit-segments.xml: New file.
6915         * features/i386/32bit-segments.c: Generate.
6916         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6917         call to i386_target_description to add 'segments' parameter.
6918         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6919         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6920         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6921         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6922         if feature is present.
6923         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6924         Add 'segments' parameter to call to i386_target_description.
6925         (i386_target_description): Add 'segments' parameter to enable
6926         segment base registers.
6927         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6928         to call to i386_target_description.
6929         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6930         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6931         Define I386_NUM_REGS.
6932         (i386_target_description): Add 'segments' parameter to enable
6933         segment base registers.
6934
6935 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6936
6937         PR/24325
6938         * source-cache.c: #undef open and close, to avoid unresolved
6939         externals during linking.
6940
6941 2019-03-12  Tom Tromey  <tromey@adacore.com>
6942
6943         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6944         const.  Add initializers.
6945         (_initialize_remote): Don't initialize ptid globals.
6946
6947 2019-03-12  Pedro Alves  <palves@redhat.com>
6948
6949         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6950
6951 2019-03-12  Pedro Alves  <palves@redhat.com>
6952
6953         * cp-name-parser.y (main): Remove unused 'len' variable.
6954
6955 2019-03-12  Tom Tromey  <tromey@adacore.com>
6956
6957         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6958         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6959
6960 2019-03-12  Tom Tromey  <tromey@adacore.com>
6961
6962         * linux-nat.c (iterate_over_lwps): Update.
6963         (stop_callback): Remove parameter.
6964         (stop_wait_callback, detach_callback, resume_set_callback)
6965         (select_singlestep_lwp_callback, set_ignore_sigint)
6966         (status_callback, resumed_callback, resume_clear_callback)
6967         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6968         data parameter.
6969         (linux_nat_target::detach, linux_nat_target::resume)
6970         (linux_stop_and_wait_all_lwps, select_event_lwp)
6971         (linux_nat_filter_event, linux_nat_wait_1)
6972         (linux_nat_target::kill, linux_nat_target::stop)
6973         (linux_nat_target::stop): Update.
6974         (linux_nat_resume_callback): Change type.
6975         (resume_stopped_resumed_lwps, count_events_callback)
6976         (select_event_lwp_callback): Likewise.
6977         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6978         * arm-linux-nat.c (struct update_registers_data): Remove.
6979         (update_registers_callback): Change type.
6980         (arm_linux_insert_hw_breakpoint1): Update.
6981         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6982         parameter.
6983         (x86_linux_dr_set_addr): Update.
6984         (x86_linux_dr_set_control): Update.
6985         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6986         (iterate_over_lwps): Use gdb::function_view.
6987         * nat/aarch64-linux-hw-point.c (struct
6988         aarch64_dr_update_callback_param): Remove.
6989         (debug_reg_change_callback): Change type.
6990         (aarch64_notify_debug_reg_change): Update.
6991         * s390-linux-nat.c (s390_refresh_per_info): Update.
6992
6993 2019-03-11  Tom Tromey  <tromey@adacore.com>
6994
6995         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6996         redundant assignment to "this_cu".
6997
6998 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6999
7000         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7001
7002 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7003
7004         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7005         from...
7006         (rank_one_type): ... this.
7007
7008 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7009
7010         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7011         from...
7012         (rank_one_type): ... this.
7013
7014 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7015
7016         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7017         from...
7018         (rank_one_type): ... this.
7019
7020 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7021
7022         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7023         from...
7024         (rank_one_type): ... this.
7025
7026 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7027
7028         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7029         from...
7030         (rank_one_type): ... this.
7031
7032 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7033
7034         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7035         from...
7036         (rank_one_type): ... this.
7037
7038 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7039
7040         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7041         from...
7042         (rank_one_type): ... this.
7043
7044 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7045
7046         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7047         from...
7048         (rank_one_type): ... this.
7049
7050 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7051
7052         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7053         from...
7054         (rank_one_type): ... this.
7055
7056 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7057
7058         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7059         from...
7060         (rank_one_type): ... this.
7061
7062 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7063
7064         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7065         from...
7066         (rank_one_type): ... this.
7067
7068 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7069
7070         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7071         from...
7072         (rank_one_type): ... this.
7073
7074 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7075
7076         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7077         inferior-events' shows the example events.
7078
7079 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7080
7081         Support styling on native MS-Windows console
7082
7083         PR/24315
7084         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7085         on MS-Windows if $TERM is not defined.
7086
7087         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7088
7089         * posix-hdep.c (gdb_console_fputs):
7090         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7091         functions.
7092         * ui-file.h (gdb_console_fputs): Add prototype.
7093
7094         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7095         back to fputs only if the former returns zero.
7096
7097 2019-03-07  Tom Tromey  <tom@tromey.com>
7098
7099         * symmisc.c (print_symbol_bcache_statistics): Update.
7100         (print_objfile_statistics): Update.
7101         * symfile.c (allocate_symtab): Update.
7102         * stabsread.c: Don't include bcache.h.
7103         * psymtab.h (struct psymbol_bcache): Don't declare.
7104         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7105         (psymbol_bcache_init, psymbol_bcache_free)
7106         (psymbol_bcache_get_bcache): Don't declare.
7107         * psymtab.c (struct psymbol_bcache): Remove.
7108         (psymtab_storage::psymtab_storage): Update.
7109         (psymtab_storage::~psymtab_storage): Update.
7110         (psymbol_bcache_init, psymbol_bcache_free)
7111         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7112         (add_psymbol_to_bcache): Update.
7113         (allocate_psymtab): Update.
7114         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7115         macro_cache>: No longer pointers.
7116         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7117         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7118         * macrotab.c (macro_bcache): Update.
7119         * macroexp.c: Don't include bcache.h.
7120         * gdbtypes.c (check_types_worklist): Update.
7121         (types_deeply_equal): Remove TRY/CATCH.  Update.
7122         * elfread.c (elf_symtab_read): Update.
7123         * dwarf2read.c: Don't include bcache.h.
7124         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7125         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7126         (print_bcache_statistics, bcache_memory_used): Don't declare.
7127         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7128         methods.  Rename all data members.
7129         * bcache.c (struct bcache): Move to bcache.h.
7130         (bcache::expand_hash_table): Rename from expand_hash_table.
7131         (bcache): Remove.
7132         (bcache::insert): Rename from bcache_full.
7133         (bcache::compare): Rename from bcache_compare.
7134         (bcache_xmalloc): Remove.
7135         (bcache::~bcache): Rename from bcache_xfree.
7136         (bcache::print_statistics): Rename from print_bcache_statistics.
7137         (bcache::memory_used): Rename from bcache_memory_used.
7138
7139 2019-03-07  Pedro Alves  <palves@redhat.com>
7140
7141         * infrun.c (normal_stop): Also check for
7142         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7143
7144 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7145
7146         * f-lang.c (value_from_host_double): Moved to...
7147         * value.c (value_from_host_double): ...here.
7148         * value.h (value_from_host_double): Declare.
7149         * guile/scm-math.c (vlscm_convert_typed_number): Use
7150         value_from_host_double.
7151         (vlscm_convert_number): Likewise.
7152         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7153         * python/py-value.c (convert_value_from_python): Likewise.
7154
7155 2019-03-06  Tom Tromey  <tom@tromey.com>
7156
7157         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7158
7159 2019-03-06  Tom Tromey  <tom@tromey.com>
7160
7161         * utils.h (free_current_contents): Don't declare.
7162         * utils.c (free_current_contents): Remove.
7163
7164 2019-03-06  Tom Tromey  <tom@tromey.com>
7165
7166         * top.c (quit_force): Update.
7167         * main.c (captured_command_loop): Update.
7168         * common/new-op.c (operator new): Update.
7169         * common/common-exceptions.c (struct catcher)
7170         <save_cleanup_chain>: Remove member.
7171         (exceptions_state_mc_init): Update.
7172         (exception_try_scope_entry): Return nullptr.
7173         (exception_try_scope_exit, exception_rethrow)
7174         (throw_exception_sjlj, throw_exception_cxx): Update.
7175         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7176         (all_cleanups, do_cleanups, discard_cleanups)
7177         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7178         (restore_cleanups, restore_final_cleanups): Don't declare.
7179         (do_final_cleanups): Remove parameter.
7180         * common/cleanups.c (cleanup_chain, make_cleanup)
7181         (make_cleanup_dtor, all_cleanups, do_cleanups)
7182         (discard_my_cleanups, discard_cleanups)
7183         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7184         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7185         (null_cleanup): Remove.
7186         (do_final_cleanups): Remove parameter.
7187
7188 2019-03-06  Tom Tromey  <tom@tromey.com>
7189
7190         * remote.c (remote_target::remote_parse_stop_reply): Use
7191         unique_xmalloc_ptr.
7192
7193 2019-03-06  Tom Tromey  <tom@tromey.com>
7194
7195         * stabsread.c (struct stabs_field_info): Rename from field_info.
7196         <list, fnlist>: Add initializers.
7197         <obstack>: New member.
7198         (read_member_functions, read_struct_fields, read_baseclasses):
7199         Allocate on obstack.  Don't use cleanups.
7200         (read_one_struct_field, read_member_functions, read_struct_fields)
7201         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7202         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7203         (read_struct_type): Update.
7204
7205 2019-03-06  Tom Tromey  <tom@tromey.com>
7206
7207         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7208         * common/filestuff.h (make_cleanup_close): Don't declare.
7209         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7210         Remove.
7211
7212 2019-03-06  Tom Tromey  <tom@tromey.com>
7213
7214         * solib-aix.c: Use make_scope_exit.
7215
7216 2019-03-06  Tom Tromey  <tom@tromey.com>
7217
7218         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7219         Use make_scope_exit.
7220
7221 2019-03-06  Tom Tromey  <tom@tromey.com>
7222
7223         * solib-svr4.c (disable_probes_interface): Remove parameter.
7224         (svr4_handle_solib_event): Use make_scope_exit.
7225
7226 2019-03-06  Tom Tromey  <tom@tromey.com>
7227
7228         * remote.c (struct stop_reply_deleter): Remove.
7229         (stop_reply_up): Update.
7230         (struct stop_reply): Derive from notif_event.  Don't typedef.
7231         <regcache>: Now a std::vector.
7232         (stop_reply_xfree): Remove.
7233         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7234         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7235         (remote_target::discard_pending_stop_replies): Use delete.
7236         (remote_target::remote_parse_stop_reply): Update.
7237         (remote_target::process_stop_reply): Update.
7238         * remote-notif.h (struct notif_event): Add virtual destructor.
7239         Remove "dtr" member.
7240         (struct notif_client) <alloc_event>: Return a unique_ptr.
7241         (notif_event_xfree): Don't declare.
7242         (notif_event_up): New typedef.
7243         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7244         (notif_event_xfree, do_notif_event_xfree): Remove.
7245         (remote_notif_state_xfree): Update.
7246
7247 2019-03-06  Tom Tromey  <tom@tromey.com>
7248
7249         * infrun.c (displaced_step_clear_cleanup): Now a
7250         forward_scope_exit type.
7251         (displaced_step_prepare_throw): Update.
7252         (displaced_step_fixup): Update.
7253
7254 2019-03-06  Tom Tromey  <tom@tromey.com>
7255
7256         * inferior.h (class inferior): Update comment.
7257         * gdbthread.h (class thread_info): Update comment.
7258
7259 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7260             Tom Tromey  <tom@tromey.com>
7261
7262         * stabsread.h (struct stab_section_list): Remove.
7263         (coffstab_build_psymtabs): Update.
7264         * dbxread.c (symbuf_sections): Now a std::vector.
7265         (sect_idx): New global.
7266         (fill_symbuf): Update.
7267         (coffstab_build_psymtabs): Change type of stabsects parameter.
7268         Update.
7269         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7270         std::vector.
7271         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7272         (coff_locate_sections): Update.
7273         (coff_symfile_read): Remove cleanups.  Update.
7274         (init_stringtab): Add storage parameter.
7275         (free_stringtab, free_stringtab_cleanup): Remove.
7276         (init_lineno): Add storage parameter.
7277         (free_linetab, free_linetab_cleanup): Remove.
7278
7279 2019-03-06  Pedro Alves  <palves@redhat.com>
7280
7281         * linux-fork.c (fork_info::clobber_regs): Delete.
7282         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7283         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7284         comment.  Adjust.
7285         (scoped_switch_fork_info::scoped_switch_fork_info)
7286         (checkpoint_command, linux_fork_context): Adjust
7287         fork_save_infrun_state calls.
7288
7289 2019-03-06  Pedro Alves  <palves@redhat.com>
7290
7291         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7292         (inf_has_multiple_threads): Return 'bool' and rewrite using
7293         inferior_info::threads().
7294
7295 2019-03-06  Pedro Alves  <palves@redhat.com>
7296
7297         * linux-fork.c: Include <list>.
7298         (fork_list): Now a std::list instance.
7299         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7300         (forks_exist_p, find_last_fork): Adjust.
7301         (new_fork): Delete.
7302         (one_fork_p): New.
7303         (add_fork): Adjust.
7304         (free_fork): Delete, folded into fork_info::~fork_info().
7305         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7306         Adjust.
7307         (init_fork_list): Delete.
7308         (linux_fork_killall, linux_fork_mourn_inferior)
7309         (linux_fork_detach, info_checkpoints_command): Adjust.
7310         (_initialize_linux_fork): No longer call init_fork_list.
7311
7312 2019-03-06  Pedro Alves  <palves@redhat.com>
7313
7314         * linux-fork.c (new_fork): New, split out of ...
7315         (add_fork): ... this.  Return void.  Move "first fork" special
7316         case from here, to ...
7317         (checkpoint_command): ... here.
7318         * linux-linux.h (add_fork): Return void.
7319
7320 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7321
7322         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7323
7324 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7325             Chris January  <chris.january@arm.com>
7326             David Lecomber  <david.lecomber@arm.com>
7327
7328         * f-exp.y: New token, UNOP_INTRINSIC.
7329         (exp): New pattern using UNOP_INTRINSIC token.
7330         (f77_keywords): Add 'abs' keyword.
7331         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7332         (value_from_host_double): New function.
7333         (evaluate_subexp_f): Support UNOP_ABS.
7334
7335 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7336
7337         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7338         types.
7339
7340 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7341
7342         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7343         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7344         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7345
7346 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7347
7348         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7349
7350 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7351             Chris January  <chris.january@arm.com>
7352
7353         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7354         * f-exp.y: Define 'KIND' token.
7355         (exp): New pattern for KIND expressions.
7356         (ptype): Handle types with a kind extension.
7357         (direct_abs_decl): Extend to spot kind extensions.
7358         (f77_keywords): Add 'kind' to the list.
7359         (push_kind_type): New function.
7360         (convert_to_kind_type): New function.
7361         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7362         * parse.c (operator_length_standard): Likewise.
7363         * parser-defs.h (enum type_pieces): Add tp_kind.
7364         * std-operator.def: Add UNOP_KIND.
7365
7366 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7367
7368         * f-exp.y (f_parse): Set yydebug.
7369
7370 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7371
7372         * f-lang.c (evaluate_subexp_f): New function.
7373         (exp_descriptor_f): New global.
7374         (f_language_defn): Use exp_descriptor_f instead of
7375         exp_descriptor_standard.
7376
7377 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7378
7379         * f-exp.y (struct token): Add comments.
7380         (dot_ops): Remove uppercase versions and the end marker.
7381         (f77_keywords): Likewise.
7382         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7383         entries in the dot_ops array are case insensitive, and use
7384         strncasecmp to compare strings.  Also some whitespace cleanup in
7385         this area.  Similar for the f77_keywords array, except entries in
7386         this list might be case sensitive.
7387
7388 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7389
7390         * f-exp.y (struct f77_boolean_val): Add comments.
7391         (boolean_values): Remove uppercase versions, and end marker.
7392         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7393         and use strncasecmp to achieve case insensitivity.  Additionally,
7394         perform whitespace cleanup around this code.
7395
7396 2019-03-06  Tom Tromey  <tromey@adacore.com>
7397
7398         * remote-sim.c (gdbsim_target_open): Use result of
7399         gdb_argv::release.
7400
7401 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7402         Dirk Schubert  <dirk.schubert@arm.com>
7403         Chris January  <chris.january@arm.com>
7404
7405         * eval.c (evaluate_subexp_standard): Call Fortran argument
7406         wrapping logic.
7407         * f-lang.c (struct value): A value which can be passed into a
7408         Fortran function call.
7409         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7410         where appropriate.
7411         (struct type): Value ready for a Fortran function call.
7412         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7413         is needed.
7414         * f-lang.h (fortran_argument_convert): Declaration.
7415         (fortran_preserve_arg_pointer): Declaration.
7416         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7417
7418 2019-03-05  Tom Tromey  <tromey@adacore.com>
7419
7420         * python/py-prettyprint.c (print_string_repr): Remove #if.
7421         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7422
7423 2019-03-05  Tom Tromey  <tromey@adacore.com>
7424
7425         * target.c (the_dummy_target): Move later.  Change type to
7426         "dummy_target".
7427         (initialize_targets): Don't initialize the_dummy_target.
7428
7429 2019-03-05  Tom Tromey  <tromey@adacore.com>
7430
7431         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7432         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7433
7434 2019-03-05  Tom Tromey  <tromey@adacore.com>
7435
7436         * windows-nat.c (windows_nat_target::attach)
7437         (windows_nat_target::detach): Don't call gdb_flush.
7438         * valprint.c (generic_val_print, val_print, val_print_string):
7439         Don't call gdb_flush.
7440         * utils.c (defaulted_query): Don't call gdb_flush.
7441         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7442         * target.c (target_announce_detach): Don't call gdb_flush.
7443         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7444         * remote.c (extended_remote_target::attach): Don't call
7445         gdb_flush.
7446         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7447         * printcmd.c (do_examine): Don't call gdb_flush.
7448         (info_display_command): Don't call gdb_flush.
7449         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7450         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7451         * memattr.c (info_mem_command): Don't call gdb_flush.
7452         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7453         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7454         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7455         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7456         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7457         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7458         (gnu_nat_target::detach): Don't call gdb_flush.
7459         * f-valprint.c (f_val_print): Don't call gdb_flush.
7460         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7461         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7462         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7463         gdb_flush.
7464         * c-valprint.c (c_val_print): Don't call gdb_flush.
7465         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7466
7467 2019-03-05  Tom Tromey  <tromey@adacore.com>
7468
7469         * varobj.c (update_dynamic_varobj_children): Update.
7470         (install_default_visualizer): Use reset, not release.
7471         * value.c (set_internalvar): Update.
7472         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7473         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7474         ATTRIBUTE_UNUSED_RESULT.
7475
7476 2019-03-05  Tom Tromey  <tromey@adacore.com>
7477
7478         * remote.c (class scoped_remote_fd) <release>: Add
7479         ATTRIBUTE_UNUSED_RESULT.
7480
7481 2019-03-05  Tom Tromey  <tromey@adacore.com>
7482
7483         * macroexp.c (struct macro_buffer) <release>: Add
7484         ATTRIBUTE_UNUSED_RESULT.
7485
7486 2019-03-05  Tom Tromey  <tromey@adacore.com>
7487
7488         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7489         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7490         ATTRIBUTE_UNUSED_RESULT.
7491
7492 2019-03-05  Tom Tromey  <tromey@adacore.com>
7493
7494         * common/scoped_fd.h (class scoped_fd) <release>: Add
7495         ATTRIBUTE_UNUSED_RESULT.
7496
7497 2019-03-05  Tom Tromey  <tromey@adacore.com>
7498
7499         * parser-defs.h (struct parser_state) <release>: Add
7500         ATTRIBUTE_UNUSED_RESULT.
7501
7502 2019-03-05  Tom Tromey  <tromey@adacore.com>
7503
7504         * utils.h (class gdb_argv) <release>: Add
7505         ATTRIBUTE_UNUSED_RESULT.
7506         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7507
7508 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7509
7510         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7511         for-loop range, to avoid compiler warnings.
7512
7513         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7514         avoid compiler warnings about unused variables.
7515
7516         * NEWS: Mention end of support for native debugging on MS-Windows
7517         before XP.
7518
7519         PR gdb/24292
7520         * common/netstuff.c:
7521         * gdbserver/gdbreplay.c
7522         * gdbserver/remote-utils.c:
7523         * ser-tcp.c:
7524         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7525         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7526         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7527         'getaddrinfo' and 'freeaddrinfo' were not available before
7528         Windows XP, and mingw.org's MinGW headers by default define
7529         _WIN32_WINNT to 0x500.
7530
7531 2019-03-01  Gary Benson <gbenson@redhat.com>
7532
7533         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7534
7535 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7536             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7537
7538         PR gdb/8527
7539         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7540         set_sigint_trap, clear_sigint_trap.
7541
7542 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7543
7544         * target.c (target_detach): Clear the regcache and the
7545         frame cache.
7546
7547 2019-02-27  Pedro Alves  <palves@redhat.com>
7548
7549         * utils.c (set_screen_size): When we cap the height/width sizes,
7550         tweak the corresponding command variable to show "unlimited":
7551
7552 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7553             Pedro Alves  <palves@redhat.com>
7554
7555         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7556         before calling rl_set_screen_size.
7557
7558 2019-02-27  Tom Tromey  <tromey@adacore.com>
7559
7560         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7561         define.
7562         * python/py-value.c: Remove Python 2.4 workaround.
7563         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7564         workaround.
7565         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7566         Python 2.4 workaround.
7567         * python/python-internal.h: Remove Python 2.4 comment.
7568         (Py_ssize_t): Don't define.
7569         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7570         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7571         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7572         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7573         * python/python.c (do_start_initialization): Remove Python 2.4
7574         workaround.
7575         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7576         (print_children): Remove Python 2.4 workaround.
7577         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7578         workaround.
7579         (CHARBUFFERPROC_NAME): Remove.
7580         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7581         Python 2.4 workaround.
7582
7583 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7584
7585         * NEWS: Note minimum Python version.
7586
7587 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7588
7589         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7590         code from these functions.  Remove corresponding ifdefs.  Use
7591         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7592         Remove gotos and target of gotos.
7593         (infpy_search_memory): Likewise.
7594
7595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7596
7597         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7598         (hppa_gdbarch_init): Don't register deleted functions with
7599         gdbarch.
7600
7601 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7602
7603         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7604         (h8300_unwind_sp): Delete.
7605         (h8300_dummy_id): Delete.
7606         (h8300_gdbarch_init): Don't register deleted functions with
7607         gdbarch.
7608
7609 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7610
7611         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7612         (ft32_unwind_pc): Delete.
7613         (ft32_unwind_sp): Delete.
7614         (ft32_gdbarch_init): Don't register deleted functions with
7615         gdbarch.
7616
7617 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7618
7619         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7620         (frv_unwind_pc): Delete.
7621         (frv_unwind_sp): Delete.
7622         (frv_gdbarch_init): Don't register deleted functions with
7623         gdbarch.
7624
7625 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7626
7627         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7628         (riscv_unwind_pc): Delete.
7629         (riscv_unwind_sp): Delete.
7630         (riscv_gdbarch_init): Don't register deleted functions with
7631         gdbarch.
7632
7633 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7634
7635         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7636         (csky_unwind_pc): Delete.
7637         (csky_unwind_sp): Delete.
7638         (csky_gdbarch_init): Don't register deleted functions with
7639         gdbarch.
7640
7641 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7642
7643         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7644         (cris_unwind_pc): Delete.
7645         (cris_unwind_sp): Delete.
7646         (cris_gdbarch_init): Don't register deleted functions with
7647         gdbarch.
7648
7649 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7650
7651         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7652         (bfin_unwind_pc): Delete.
7653         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7654
7655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7656
7657         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7658         (arm_unwind_pc): Delete.
7659         (arm_unwind_sp): Delete.
7660         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7661
7662 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7663
7664         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7665         (arc_unwind_pc): Delete.
7666         (arc_unwind_sp): Delete.
7667         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7668
7669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7670
7671         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7672         (alpha_unwind_pc): Delete.
7673         (alpha_gdbarch_init): Don't register deleted functions with
7674         gdbarch.
7675
7676 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7677
7678         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7679         (aarch64_unwind_pc): Delete.
7680         (aarch64_unwind_sp): Delete.
7681         (aarch64_gdbarch_init): Don't register deleted functions with
7682         gdbarch.
7683
7684 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7685
7686         * gdbtypes.c (type_align): Don't consider static members when
7687         computing structure alignment.
7688
7689 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7690
7691         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7692         return 0 for other types.
7693         * arch-utils.c (default_type_align): Always return 0.
7694         * gdbarch.h: Regenerate.
7695         * gdbarch.sh (type_align): Extend comment.
7696         * gdbtypes.c (type_align): Add additional comments, always call
7697         gdbarch_type_align before applying the default rules.
7698         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7699         generic code will then apply a suitable default.
7700         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7701         types, return 0 for other types.
7702
7703 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7704
7705         * NEWS: Create a new section for the next release branch.
7706         Rename the section of the current branch, now that it has
7707         been cut.
7708
7709 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7710
7711         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7712         * version.in: Bump version to 8.3.50.DATE-git.
7713
7714 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7715
7716         * aix-thread.c (ptid_cmp): Remove unused variable.
7717         (get_signaled_thread): Likewise.
7718         (store_regs_user_thread): Likewise.
7719         (store_regs_kernel_thread): Likewise.
7720         (fetch_regs_kernel_thread): Remove shadowed variable.
7721
7722 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7723
7724         * features/riscv/32bit-cpu.xml: Add register numbers.
7725         * features/riscv/32bit-fpu.c: Regenerate.
7726         * features/riscv/32bit-fpu.xml: Add register numbers.
7727         * features/riscv/64bit-cpu.xml: Add register numbers.
7728         * features/riscv/64bit-fpu.c: Regenerate.
7729         * features/riscv/64bit-fpu.xml: Add register numbers.
7730
7731 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7732
7733         * NEWS: Mention two argument form of gdb.Value constructor.
7734         * python/py-value.c (convert_buffer_and_type_to_value): New
7735         function.
7736         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7737         Add support for handling an optional second argument.  Call
7738         convert_buffer_and_type_to_value as appropriate.
7739         * python/python-internal.h (Py_buffer_deleter): New struct.
7740         (Py_buffer_up): New typedef.
7741
7742 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7743
7744         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7745         instead of releasing ownership.
7746
7747 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7748
7749         * dwarf2read.c (open_and_init_dwp_file): Call
7750         elf_numsections instead of bfd_count_sections to initialize
7751         dwp_file->num_sections.
7752
7753 2019-02-25  Tom Tromey  <tromey@adacore.com>
7754
7755         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7756
7757 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7758
7759         * gcore.in: Add '--readnever' option when invoking GDB.
7760
7761 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7762
7763         * MAINTAINERS: Update my email address.
7764
7765 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7766
7767         * build-id.c (build_id_to_debug_bfd_1): New function.
7768         (build_id_to_debug_bfd): Look for separate debug file in
7769         sysroot.
7770
7771 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7772
7773         * gdbarch.sh: Update the copyright year range that is placed into
7774         generated files.
7775
7776 2019-02-22  Keith Seitz  <keiths@redhat.com>
7777
7778         PR symtab/23853
7779         * linespec.c (create_sals_line_offset): Search for the default
7780         symtab's filename instead of its fullname.
7781
7782 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7783
7784         * NEWS: Update style defaults.
7785
7786 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7787
7788         * main.c (captured_main_1): Disable styling in batch mode.
7789
7790 2019-02-20  Tom Tromey  <tom@tromey.com>
7791
7792         * symtab.c (symtab_symbol_info): Fix typos.
7793
7794 2019-02-20  Tom Tromey  <tromey@adacore.com>
7795
7796         * findcmd.c (_initialize_mem_search): Use upper case for
7797         metasyntactic variables.
7798
7799 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7800
7801         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7802         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7803
7804 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7805
7806         * top.h (source_file_name): Change to std::string.
7807         * top.c (source_file_name): Likewise.
7808         (command_line_input): Adjust.
7809         * cli/cli-script.c (script_from_file): Adjust.
7810
7811 2019-02-19  Tom Tromey  <tromey@adacore.com>
7812
7813         * ravenscar-thread.c
7814         (ravenscar_thread_target::update_thread_list): Don't call
7815         ada_build_task_list.
7816         * ada-lang.h (ada_build_task_list): Don't declare.
7817         * ada-tasks.c (struct ada_tasks_inferior_data)
7818         <task_list_valid_p>: Now bool.
7819         (read_known_tasks, ada_task_list_changed)
7820         (ada_tasks_invalidate_inferior_data): Update.
7821         (read_known_tasks_array): Return bool.
7822         (read_known_tasks_list): Likewise.
7823         (read_known_tasks): Return void.
7824         (ada_build_task_list): Now static.
7825
7826 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7827
7828         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7829         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7830
7831 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7832
7833         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7834         variant for ada_tasks_pspace_data_handle and
7835         ada_tasks_inferior_data_handle.
7836         (ada_tasks_pspace_data_cleanup): New function.
7837         (ada_tasks_inferior_data_cleanup): New function.
7838
7839 2019-02-17  Tom Tromey  <tom@tromey.com>
7840
7841         * macrotab.h (macro_source_fullname): Return a std::string.
7842         * macrotab.c (macro_include, check_for_redefinition)
7843         (macro_undef, macro_lookup_definition, foreach_macro)
7844         (foreach_macro_in_scope): Update.
7845         (macro_source_fullname): Return a std::string.
7846         * macrocmd.c (show_pp_source_pos): Update.
7847
7848 2019-02-17  Tom Tromey  <tom@tromey.com>
7849
7850         * macrocmd.c (show_pp_source_pos): Style the file names.
7851
7852 2019-02-17  Tom Tromey  <tom@tromey.com>
7853
7854         PR tui/24197:
7855         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7856
7857 2019-02-17  Tom Tromey  <tom@tromey.com>
7858
7859         * ada-lang.c (user_select_syms): Use filtered printing.
7860         * utils.c (wrap_style): New global.
7861         (desired_style): Remove.
7862         (emit_style_escape): Add stream parameter.
7863         (set_output_style, reset_terminal_style, prompt_for_continue):
7864         Update.
7865         (flush_wrap_buffer): Only flush gdb_stdout.
7866         (wrap_here): Set wrap_style.
7867         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7868         treat escape sequences as a character.  Change when wrap buffer is
7869         flushed.
7870         (fputs_styled): Do not set the output style when the default is
7871         requested.
7872         * ui-style.h (struct ui_file_style) <is_default>: New method.
7873         * source.c (print_source_lines_base): Emit escape sequences in one
7874         piece.
7875
7876 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7877
7878         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7879         integers and enumeration types.
7880
7881 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7882
7883         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7884         instead of lookup_symbol_in_language
7885         (do_exact_match): New function.
7886         (ada_get_symbol_name_matcher): Return do_exact_match when
7887         doing a verbatim match.
7888
7889 2019-02-15  Tom Tromey  <tromey@adacore.com>
7890
7891         * ravenscar-thread.c (ravenscar_thread_target::resume)
7892         (ravenscar_thread_target::wait): Special case wildcard requests.
7893
7894 2019-02-15  Tom Tromey  <tromey@adacore.com>
7895
7896         * ravenscar-thread.c (base_ptid): Remove.
7897         (struct ravenscar_thread_target) <close>: New method.
7898         <m_base_ptid>: New member.
7899         <update_inferior_ptid, active_task, task_is_currently_active,
7900         runtime_initialized>: Declare methods.
7901         <ravenscar_thread_target>: Add constructor.
7902         (ravenscar_thread_target::task_is_currently_active)
7903         (ravenscar_thread_target::update_inferior_ptid)
7904         (ravenscar_runtime_initialized): Rename.  Now methods.
7905         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7906         (ravenscar_thread_target::update_thread_list): Update.
7907         (ravenscar_thread_target::active_task): Now method.
7908         (ravenscar_thread_target::store_registers)
7909         (ravenscar_thread_target::prepare_to_store)
7910         (ravenscar_thread_target::prepare_to_store)
7911         (ravenscar_thread_target::mourn_inferior): Update.
7912         (ravenscar_inferior_created): Use "new" to create target.
7913         (ravenscar_thread_target::get_ada_task_ptid): Update.
7914         (_initialize_ravenscar): Don't initialize base_ptid.
7915         (ravenscar_ops): Remove global.
7916
7917 2019-02-15  Tom Tromey  <tromey@adacore.com>
7918
7919         * target.h (push_target): Declare new overload.
7920         * target.c (push_target): New overload, taking an rvalue reference.
7921         * remote.c (remote_target::open_1): Use push_target overload.
7922         * corelow.c (core_target_open): Use push_target overload.
7923
7924 2019-02-15  Tom Tromey  <tromey@adacore.com>
7925
7926         * ravenscar-thread.c (is_ravenscar_task)
7927         (ravenscar_task_is_currently_active): Return bool.
7928         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7929         (_initialize_ravenscar): Remove "(void)".
7930         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7931         Return bool.
7932
7933 2019-02-15  Tom Tromey  <tromey@adacore.com>
7934
7935         * ravenscar-thread.c (ravenscar_runtime_initializer)
7936         (has_ravenscar_runtime, get_running_thread_id)
7937         (ravenscar_thread_target::resume): Fix indentation.
7938
7939 2019-02-15  Tom Tromey  <tromey@adacore.com>
7940
7941         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7942         from ravenscar_arch_ops.
7943         (sparc_ravenscar_ops::fetch_registers)
7944         (sparc_ravenscar_ops::store_registers): Now methods.
7945         (sparc_ravenscar_prepare_to_store): Remove.
7946         (sparc_ravenscar_ops): Redefine.
7947         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7948         methods and destructor.  Remove members.
7949         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7950         (ravenscar_thread_target::store_registers)
7951         (ravenscar_thread_target::prepare_to_store): Update.
7952         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7953         Remove.
7954         (struct ppc_ravenscar_powerpc_ops): Derive from
7955         ravenscar_arch_ops.
7956         (ppc_ravenscar_powerpc_ops::fetch_registers)
7957         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7958         (ppc_ravenscar_powerpc_ops): Redefine.
7959         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7960         (ppc_ravenscar_e500_ops::fetch_registers)
7961         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7962         (ppc_ravenscar_e500_ops): Redefine.
7963         * aarch64-ravenscar-thread.c
7964         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7965         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7966         (aarch64_ravenscar_fetch_registers)
7967         (aarch64_ravenscar_store_registers): Now methods.
7968         (aarch64_ravenscar_ops): Redefine.
7969
7970 2019-02-15  Tom Tromey  <tromey@adacore.com>
7971
7972         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7973         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7974         (ravenscar_thread_target::stopped_by_watchpoint)
7975         (ravenscar_thread_target::stopped_data_address)
7976         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7977
7978 2019-02-15  Tom Tromey  <tromey@adacore.com>
7979
7980         * ravenscar-thread.c: Fix some typos.
7981
7982 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7983             Tom Tromey  <tromey@adacore.com>
7984
7985         * ada-lang.c (ada_exception_sal): Change addr_string to a
7986         std::string.
7987         (create_ada_exception_catchpoint): Update.
7988
7989 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7990             Tom Tromey  <tromey@adacore.com>
7991
7992         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7993         (bp_location_ops): Remove.
7994         (base_breakpoint_allocate_location): Update.
7995         (free_bp_location): Update.
7996         * ada-lang.c (class ada_catchpoint_location)
7997         <ada_catchpoint_location>: Remove ops parameter.
7998         (ada_catchpoint_location_dtor): Remove.
7999         (ada_catchpoint_location_ops): Remove.
8000         (allocate_location_exception): Update.
8001         * breakpoint.h (struct bp_location_ops): Remove.
8002         (class bp_location) <bp_location>: Remove bp_location_ops
8003         parameter.
8004         <~bp_location>: Add destructor.
8005         <ops>: Remove.
8006
8007 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8008             Pedro Alves  <palves@redhat.com>
8009
8010         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8011         'PATH_MAX'.
8012
8013 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8014             Samuel Thibault  <samuel.thibault@gnu.org>
8015             Thomas Schwinge  <thomas@codesourcery.com>
8016
8017         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8018         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8019
8020 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8021
8022         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8023         (check_empty): Use "const char *".
8024
8025         * gnu-nat.c (gnu_nat_target::detach): Instead of
8026         'detach_inferior (pid)' call
8027         'detach_inferior (find_inferior_pid (pid))'.
8028
8029         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8030         'nat/fork-inferior.o'.
8031         * gnu-nat.c: #include "nat/fork-inferior.h".
8032
8033         * gnu-nat.c (gnu_nat_target::detach): Instead of
8034         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8035         * gnu-nat.h: #include "inf-child.h".
8036         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8037         'i386_gnu_nat_target::fetch_registers'.
8038         (gnu_store_registers): Rename/move to
8039         'i386_gnu_nat_target::store_registers'.
8040
8041         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8042         * gnu-nat.h (mach_thread_info): New function.
8043         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8044
8045         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8046
8047 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8048
8049         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8050
8051 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8052
8053         * windows-nat.c (windows_add_thread): Add new parameter
8054         "main_thread_p" with default value set to false.  Update
8055         function documentation as well as all callers.
8056         (windows_delete_thread): Likewise.
8057         (fake_create_process): Update call to windows_add_thread.
8058         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8059         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8060         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8061         call to windows_delete_thread.
8062
8063 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8064
8065         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8066
8067 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8068
8069         * symfile.c (find_separate_debug_file): Use canonical path of
8070         sysroot with child_path instead of gdb_sysroot if it is valid.
8071
8072 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8073
8074         * symfile.c (find_separate_debug_file): Use child_path to
8075         determine if an object file is under a sysroot.
8076
8077 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8078
8079         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8080         unittests/child-path-selftests.c.
8081         * common/pathstuff.c (child_path): New function.
8082         * common/pathstuff.h (child_path): New prototype.
8083         * unittests/child-path-selftests.c: New file.
8084
8085 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8086
8087         * symfile.c (find_separate_debug_file): Look for separate debug
8088         files in debug directories under the sysroot.
8089
8090 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8091
8092         * symtab.h (struct minimal_symbol data_p): New const method.
8093         (struct minimal_symbol text_p): Likewise.
8094         * symtab.c (output_source_filename): Use file name style
8095         to print file name.
8096         (print_symbol_info): Likewise.
8097         (print_msymbol_info): Use address style to print addresses.
8098         Use function name style to print executable text symbols.
8099         (expand_symtab_containing_pc): Use data_p.
8100         (find_pc_sect_compunit_symtab): Likewise.
8101
8102 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8103
8104         * breakpoint.c (describe_other_breakpoints): Use address style
8105         to print addresses.
8106         (say_where): Likewise.
8107
8108 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8109
8110         * ada-typeprint.c (print_func_type): Print function name
8111         style to print function name.
8112         * c-typeprint.c (c_print_type_1): Likewise.
8113
8114 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8115
8116         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8117         for execve.
8118
8119 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8120
8121         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8122         type_stack.
8123
8124 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8125
8126         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8127         TYPE_CODE_REF types.
8128
8129 2019-02-08  Jim Wilson  <jimw@sifive.com>
8130
8131         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8132         (riscv_linux_fregset): New.
8133         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8134
8135 2019-02-07  Tom Tromey  <tom@tromey.com>
8136
8137         * thread.c (thread_cancel_execution_command): Update.
8138         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8139         methods.
8140         (struct thread_fsm_ops): Remove.
8141         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8142         (thread_fsm_should_stop, thread_fsm_return_value)
8143         (thread_fsm_set_finished, thread_fsm_finished_p)
8144         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8145         Don't declare.
8146         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8147         * infrun.c (clear_proceed_status_thread)
8148         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8149         (print_stop_event): Update.
8150         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8151         Add constructor.
8152         (step_command_fsm_ops): Remove.
8153         (new_step_command_fsm): Remove.
8154         (step_1): Update.
8155         (step_command_fsm::should_stop): Rename from
8156         step_command_fsm_should_stop.
8157         (step_command_fsm::clean_up): Rename from
8158         step_command_fsm_clean_up.
8159         (step_command_fsm::do_async_reply_reason): Rename from
8160         step_command_fsm_async_reply_reason.
8161         (struct until_next_fsm): Inherit from thread_fsm.  Add
8162         constructor.
8163         (until_next_fsm_ops): Remove.
8164         (new_until_next_fsm): Remove.
8165         (until_next_fsm::should_stop): Rename from
8166         until_next_fsm_should_stop.
8167         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8168         (until_next_fsm::do_async_reply_reason): Rename from
8169         until_next_fsm_async_reply_reason.
8170         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8171         constructor.  Change type of breakpoint.
8172         (finish_command_fsm_ops): Remove.
8173         (new_finish_command_fsm): Remove.
8174         (finish_command_fsm::should_stop): Rename from
8175         finish_command_fsm_should_stop.
8176         (finish_command_fsm::clean_up): Rename from
8177         finish_command_fsm_clean_up.
8178         (finish_command_fsm::return_value): Rename from
8179         finish_command_fsm_return_value.
8180         (finish_command_fsm::do_async_reply_reason): Rename from
8181         finish_command_fsm_async_reply_reason.
8182         (finish_command): Update.
8183         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8184         Add constructor.
8185         (call_thread_fsm_ops): Remove.
8186         (call_thread_fsm::call_thread_fsm): Rename from
8187         new_call_thread_fsm.
8188         (call_thread_fsm::should_stop): Rename from
8189         call_thread_fsm_should_stop.
8190         (call_thread_fsm::should_notify_stop): Rename from
8191         call_thread_fsm_should_notify_stop.
8192         (run_inferior_call, call_function_by_hand_dummy): Update.
8193         * cli/cli-interp.c (should_print_stop_to_console): Update.
8194         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8195         Add constructor.  Change type of location_breakpoint,
8196         caller_breakpoint.
8197         (until_break_fsm_ops): Remove.
8198         (new_until_break_fsm): Remove.
8199         (until_break_fsm::should_stop): Rename from
8200         until_break_fsm_should_stop.
8201         (until_break_fsm::clean_up): Rename from
8202         until_break_fsm_clean_up.
8203         (until_break_fsm::do_async_reply_reason): Rename from
8204         until_break_fsm_async_reply_reason.
8205         (until_break_command): Update.
8206         * thread-fsm.c: Remove.
8207         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8208
8209 2019-02-07  Tom Tromey  <tom@tromey.com>
8210
8211         * yy-remap.h: Add include guard.
8212         * xtensa-tdep.h: Add include guard.
8213         * xcoffread.h: Rename include guard.
8214         * varobj-iter.h: Add include guard.
8215         * tui/tui.h: Rename include guard.
8216         * tui/tui-winsource.h: Rename include guard.
8217         * tui/tui-wingeneral.h: Rename include guard.
8218         * tui/tui-windata.h: Rename include guard.
8219         * tui/tui-win.h: Rename include guard.
8220         * tui/tui-stack.h: Rename include guard.
8221         * tui/tui-source.h: Rename include guard.
8222         * tui/tui-regs.h: Rename include guard.
8223         * tui/tui-out.h: Rename include guard.
8224         * tui/tui-layout.h: Rename include guard.
8225         * tui/tui-io.h: Rename include guard.
8226         * tui/tui-hooks.h: Rename include guard.
8227         * tui/tui-file.h: Rename include guard.
8228         * tui/tui-disasm.h: Rename include guard.
8229         * tui/tui-data.h: Rename include guard.
8230         * tui/tui-command.h: Rename include guard.
8231         * tic6x-tdep.h: Add include guard.
8232         * target/waitstatus.h: Rename include guard.
8233         * target/wait.h: Rename include guard.
8234         * target/target.h: Rename include guard.
8235         * target/resume.h: Rename include guard.
8236         * target-float.h: Rename include guard.
8237         * stabsread.h: Add include guard.
8238         * rs6000-tdep.h: Add include guard.
8239         * riscv-fbsd-tdep.h: Add include guard.
8240         * regformats/regdef.h: Rename include guard.
8241         * record.h: Rename include guard.
8242         * python/python.h: Rename include guard.
8243         * python/python-internal.h: Rename include guard.
8244         * python/py-stopevent.h: Rename include guard.
8245         * python/py-ref.h: Rename include guard.
8246         * python/py-record.h: Rename include guard.
8247         * python/py-record-full.h: Rename include guard.
8248         * python/py-record-btrace.h: Rename include guard.
8249         * python/py-instruction.h: Rename include guard.
8250         * python/py-events.h: Rename include guard.
8251         * python/py-event.h: Rename include guard.
8252         * procfs.h: Add include guard.
8253         * proc-utils.h: Add include guard.
8254         * p-lang.h: Add include guard.
8255         * or1k-tdep.h: Rename include guard.
8256         * observable.h: Rename include guard.
8257         * nto-tdep.h: Rename include guard.
8258         * nat/x86-linux.h: Rename include guard.
8259         * nat/x86-linux-dregs.h: Rename include guard.
8260         * nat/x86-gcc-cpuid.h: Add include guard.
8261         * nat/x86-dregs.h: Rename include guard.
8262         * nat/x86-cpuid.h: Rename include guard.
8263         * nat/ppc-linux.h: Rename include guard.
8264         * nat/mips-linux-watch.h: Rename include guard.
8265         * nat/linux-waitpid.h: Rename include guard.
8266         * nat/linux-ptrace.h: Rename include guard.
8267         * nat/linux-procfs.h: Rename include guard.
8268         * nat/linux-osdata.h: Rename include guard.
8269         * nat/linux-nat.h: Rename include guard.
8270         * nat/linux-namespaces.h: Rename include guard.
8271         * nat/linux-btrace.h: Rename include guard.
8272         * nat/glibc_thread_db.h: Rename include guard.
8273         * nat/gdb_thread_db.h: Rename include guard.
8274         * nat/gdb_ptrace.h: Rename include guard.
8275         * nat/fork-inferior.h: Rename include guard.
8276         * nat/amd64-linux-siginfo.h: Rename include guard.
8277         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8278         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8279         * nat/aarch64-linux.h: Rename include guard.
8280         * nat/aarch64-linux-hw-point.h: Rename include guard.
8281         * mn10300-tdep.h: Add include guard.
8282         * mips-linux-tdep.h: Add include guard.
8283         * mi/mi-parse.h: Rename include guard.
8284         * mi/mi-out.h: Rename include guard.
8285         * mi/mi-main.h: Rename include guard.
8286         * mi/mi-interp.h: Rename include guard.
8287         * mi/mi-getopt.h: Rename include guard.
8288         * mi/mi-console.h: Rename include guard.
8289         * mi/mi-common.h: Rename include guard.
8290         * mi/mi-cmds.h: Rename include guard.
8291         * mi/mi-cmd-break.h: Rename include guard.
8292         * m2-lang.h: Add include guard.
8293         * location.h: Rename include guard.
8294         * linux-record.h: Rename include guard.
8295         * linux-nat.h: Add include guard.
8296         * linux-fork.h: Add include guard.
8297         * i386-darwin-tdep.h: Rename include guard.
8298         * hppa-linux-offsets.h: Add include guard.
8299         * guile/guile.h: Rename include guard.
8300         * guile/guile-internal.h: Rename include guard.
8301         * gnu-nat.h: Rename include guard.
8302         * gdb-stabs.h: Rename include guard.
8303         * frv-tdep.h: Add include guard.
8304         * f-lang.h: Add include guard.
8305         * event-loop.h: Add include guard.
8306         * darwin-nat.h: Rename include guard.
8307         * cp-abi.h: Rename include guard.
8308         * config/sparc/nm-sol2.h: Rename include guard.
8309         * config/nm-nto.h: Rename include guard.
8310         * config/nm-linux.h: Add include guard.
8311         * config/i386/nm-i386gnu.h: Rename include guard.
8312         * config/djgpp/nl_types.h: Rename include guard.
8313         * config/djgpp/langinfo.h: Rename include guard.
8314         * compile/gcc-cp-plugin.h: Add include guard.
8315         * compile/gcc-c-plugin.h: Add include guard.
8316         * compile/compile.h: Rename include guard.
8317         * compile/compile-object-run.h: Rename include guard.
8318         * compile/compile-object-load.h: Rename include guard.
8319         * compile/compile-internal.h: Rename include guard.
8320         * compile/compile-cplus.h: Rename include guard.
8321         * compile/compile-c.h: Rename include guard.
8322         * common/xml-utils.h: Rename include guard.
8323         * common/x86-xstate.h: Rename include guard.
8324         * common/version.h: Rename include guard.
8325         * common/vec.h: Rename include guard.
8326         * common/tdesc.h: Rename include guard.
8327         * common/selftest.h: Rename include guard.
8328         * common/scoped_restore.h: Rename include guard.
8329         * common/scoped_mmap.h: Rename include guard.
8330         * common/scoped_fd.h: Rename include guard.
8331         * common/safe-iterator.h: Rename include guard.
8332         * common/run-time-clock.h: Rename include guard.
8333         * common/refcounted-object.h: Rename include guard.
8334         * common/queue.h: Rename include guard.
8335         * common/ptid.h: Rename include guard.
8336         * common/print-utils.h: Rename include guard.
8337         * common/preprocessor.h: Rename include guard.
8338         * common/pathstuff.h: Rename include guard.
8339         * common/observable.h: Rename include guard.
8340         * common/netstuff.h: Rename include guard.
8341         * common/job-control.h: Rename include guard.
8342         * common/host-defs.h: Rename include guard.
8343         * common/gdb_wait.h: Rename include guard.
8344         * common/gdb_vecs.h: Rename include guard.
8345         * common/gdb_unlinker.h: Rename include guard.
8346         * common/gdb_unique_ptr.h: Rename include guard.
8347         * common/gdb_tilde_expand.h: Rename include guard.
8348         * common/gdb_sys_time.h: Rename include guard.
8349         * common/gdb_string_view.h: Rename include guard.
8350         * common/gdb_splay_tree.h: Rename include guard.
8351         * common/gdb_setjmp.h: Rename include guard.
8352         * common/gdb_ref_ptr.h: Rename include guard.
8353         * common/gdb_optional.h: Rename include guard.
8354         * common/gdb_locale.h: Rename include guard.
8355         * common/gdb_assert.h: Rename include guard.
8356         * common/filtered-iterator.h: Rename include guard.
8357         * common/filestuff.h: Rename include guard.
8358         * common/fileio.h: Rename include guard.
8359         * common/environ.h: Rename include guard.
8360         * common/common-utils.h: Rename include guard.
8361         * common/common-types.h: Rename include guard.
8362         * common/common-regcache.h: Rename include guard.
8363         * common/common-inferior.h: Rename include guard.
8364         * common/common-gdbthread.h: Rename include guard.
8365         * common/common-exceptions.h: Rename include guard.
8366         * common/common-defs.h: Rename include guard.
8367         * common/common-debug.h: Rename include guard.
8368         * common/cleanups.h: Rename include guard.
8369         * common/buffer.h: Rename include guard.
8370         * common/btrace-common.h: Rename include guard.
8371         * common/break-common.h: Rename include guard.
8372         * cli/cli-utils.h: Rename include guard.
8373         * cli/cli-style.h: Rename include guard.
8374         * cli/cli-setshow.h: Rename include guard.
8375         * cli/cli-script.h: Rename include guard.
8376         * cli/cli-interp.h: Rename include guard.
8377         * cli/cli-decode.h: Rename include guard.
8378         * cli/cli-cmds.h: Rename include guard.
8379         * charset-list.h: Add include guard.
8380         * buildsym-legacy.h: Rename include guard.
8381         * bfin-tdep.h: Add include guard.
8382         * ax.h: Rename include guard.
8383         * arm-linux-tdep.h: Add include guard.
8384         * arm-fbsd-tdep.h: Add include guard.
8385         * arch/xtensa.h: Rename include guard.
8386         * arch/tic6x.h: Add include guard.
8387         * arch/i386.h: Add include guard.
8388         * arch/arm.h: Rename include guard.
8389         * arch/arm-linux.h: Rename include guard.
8390         * arch/arm-get-next-pcs.h: Rename include guard.
8391         * arch/amd64.h: Add include guard.
8392         * arch/aarch64-insn.h: Rename include guard.
8393         * arch-utils.h: Rename include guard.
8394         * annotate.h: Add include guard.
8395         * amd64-darwin-tdep.h: Rename include guard.
8396         * aarch64-linux-tdep.h: Add include guard.
8397         * aarch64-fbsd-tdep.h: Add include guard.
8398         * aarch32-linux-nat.h: Add include guard.
8399
8400 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8401
8402         * macrotab.c (macro_define_internal): New function that
8403         factorizes macro_define_object_internal and macro_define_function
8404         code.
8405         (macro_define_object_internal): Use macro_define_internal.
8406         (macro_define_function): Likewise.
8407
8408 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8409
8410         * macrocmd.c (extract_identifier): Return
8411         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8412         callers.
8413
8414 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8415
8416         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8417
8418 2019-02-05  Tom Tromey  <tom@tromey.com>
8419
8420         * target.c (target_stack::unpush): Move assertion earlier.
8421
8422 2019-01-30  Tom Tromey  <tom@tromey.com>
8423
8424         PR python/23615:
8425         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8426         (gdbpy_parse_and_eval): Likewise.
8427         * python/python-internal.h (gdbpy_allow_threads): New class.
8428
8429 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8430
8431         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8432         (aarch64_fbsd_fpregmap): Move earlier.
8433         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8434         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8435         instead of individual calls to trad_frame_set_reg_addr.
8436         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8437         earlier.
8438         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8439         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8440         instead of individual calls to trad_frame_set_reg_addr.
8441
8442 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8443
8444         * CONTRIBUTE: Replace contribution list with wiki link.
8445
8446 2019-01-25  Tom Tromey  <tom@tromey.com>
8447
8448         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8449
8450 2019-01-25  Tom Tromey  <tom@tromey.com>
8451
8452         * xtensa-linux-nat.c: Fix common/ includes.
8453         * xml-support.h: Fix common/ includes.
8454         * xml-support.c: Fix common/ includes.
8455         * x86-linux-nat.c: Fix common/ includes.
8456         * windows-nat.c: Fix common/ includes.
8457         * varobj.h: Fix common/ includes.
8458         * varobj.c: Fix common/ includes.
8459         * value.c: Fix common/ includes.
8460         * valops.c: Fix common/ includes.
8461         * utils.c: Fix common/ includes.
8462         * unittests/xml-utils-selftests.c: Fix common/ includes.
8463         * unittests/utils-selftests.c: Fix common/ includes.
8464         * unittests/unpack-selftests.c: Fix common/ includes.
8465         * unittests/tracepoint-selftests.c: Fix common/ includes.
8466         * unittests/style-selftests.c: Fix common/ includes.
8467         * unittests/string_view-selftests.c: Fix common/ includes.
8468         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8469         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8470         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8471         * unittests/rsp-low-selftests.c: Fix common/ includes.
8472         * unittests/parse-connection-spec-selftests.c: Fix common/
8473         includes.
8474         * unittests/optional-selftests.c: Fix common/ includes.
8475         * unittests/offset-type-selftests.c: Fix common/ includes.
8476         * unittests/observable-selftests.c: Fix common/ includes.
8477         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8478         * unittests/memrange-selftests.c: Fix common/ includes.
8479         * unittests/memory-map-selftests.c: Fix common/ includes.
8480         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8481         * unittests/function-view-selftests.c: Fix common/ includes.
8482         * unittests/environ-selftests.c: Fix common/ includes.
8483         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8484         * unittests/common-utils-selftests.c: Fix common/ includes.
8485         * unittests/cli-utils-selftests.c: Fix common/ includes.
8486         * unittests/array-view-selftests.c: Fix common/ includes.
8487         * ui-file.c: Fix common/ includes.
8488         * tui/tui-io.c: Fix common/ includes.
8489         * tracepoint.h: Fix common/ includes.
8490         * tracepoint.c: Fix common/ includes.
8491         * tracefile-tfile.c: Fix common/ includes.
8492         * top.h: Fix common/ includes.
8493         * top.c: Fix common/ includes.
8494         * thread.c: Fix common/ includes.
8495         * target/waitstatus.h: Fix common/ includes.
8496         * target/waitstatus.c: Fix common/ includes.
8497         * target.h: Fix common/ includes.
8498         * target.c: Fix common/ includes.
8499         * target-memory.c: Fix common/ includes.
8500         * target-descriptions.c: Fix common/ includes.
8501         * symtab.h: Fix common/ includes.
8502         * symfile.c: Fix common/ includes.
8503         * stap-probe.c: Fix common/ includes.
8504         * spu-linux-nat.c: Fix common/ includes.
8505         * sparc-nat.c: Fix common/ includes.
8506         * source.c: Fix common/ includes.
8507         * solib.c: Fix common/ includes.
8508         * solib-target.c: Fix common/ includes.
8509         * ser-unix.c: Fix common/ includes.
8510         * ser-tcp.c: Fix common/ includes.
8511         * ser-pipe.c: Fix common/ includes.
8512         * ser-base.c: Fix common/ includes.
8513         * selftest-arch.c: Fix common/ includes.
8514         * s12z-tdep.c: Fix common/ includes.
8515         * rust-exp.y: Fix common/ includes.
8516         * rs6000-aix-tdep.c: Fix common/ includes.
8517         * riscv-tdep.c: Fix common/ includes.
8518         * remote.c: Fix common/ includes.
8519         * remote-notif.h: Fix common/ includes.
8520         * remote-fileio.h: Fix common/ includes.
8521         * remote-fileio.c: Fix common/ includes.
8522         * regcache.h: Fix common/ includes.
8523         * regcache.c: Fix common/ includes.
8524         * record-btrace.c: Fix common/ includes.
8525         * python/python.c: Fix common/ includes.
8526         * python/py-type.c: Fix common/ includes.
8527         * python/py-inferior.c: Fix common/ includes.
8528         * progspace.h: Fix common/ includes.
8529         * producer.c: Fix common/ includes.
8530         * procfs.c: Fix common/ includes.
8531         * proc-api.c: Fix common/ includes.
8532         * printcmd.c: Fix common/ includes.
8533         * ppc-linux-nat.c: Fix common/ includes.
8534         * parser-defs.h: Fix common/ includes.
8535         * osdata.c: Fix common/ includes.
8536         * obsd-nat.c: Fix common/ includes.
8537         * nat/x86-linux.c: Fix common/ includes.
8538         * nat/x86-linux-dregs.c: Fix common/ includes.
8539         * nat/x86-dregs.h: Fix common/ includes.
8540         * nat/x86-dregs.c: Fix common/ includes.
8541         * nat/ppc-linux.c: Fix common/ includes.
8542         * nat/mips-linux-watch.h: Fix common/ includes.
8543         * nat/mips-linux-watch.c: Fix common/ includes.
8544         * nat/linux-waitpid.c: Fix common/ includes.
8545         * nat/linux-ptrace.h: Fix common/ includes.
8546         * nat/linux-ptrace.c: Fix common/ includes.
8547         * nat/linux-procfs.c: Fix common/ includes.
8548         * nat/linux-personality.c: Fix common/ includes.
8549         * nat/linux-osdata.c: Fix common/ includes.
8550         * nat/linux-namespaces.c: Fix common/ includes.
8551         * nat/linux-btrace.h: Fix common/ includes.
8552         * nat/linux-btrace.c: Fix common/ includes.
8553         * nat/fork-inferior.c: Fix common/ includes.
8554         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8555         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8556         * nat/aarch64-linux.c: Fix common/ includes.
8557         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8558         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8559         * namespace.h: Fix common/ includes.
8560         * mips-linux-tdep.c: Fix common/ includes.
8561         * minsyms.c: Fix common/ includes.
8562         * mi/mi-parse.h: Fix common/ includes.
8563         * mi/mi-main.c: Fix common/ includes.
8564         * mi/mi-cmd-env.c: Fix common/ includes.
8565         * memrange.h: Fix common/ includes.
8566         * memattr.c: Fix common/ includes.
8567         * maint.h: Fix common/ includes.
8568         * maint.c: Fix common/ includes.
8569         * main.c: Fix common/ includes.
8570         * machoread.c: Fix common/ includes.
8571         * location.c: Fix common/ includes.
8572         * linux-thread-db.c: Fix common/ includes.
8573         * linux-nat.c: Fix common/ includes.
8574         * linux-fork.c: Fix common/ includes.
8575         * inline-frame.c: Fix common/ includes.
8576         * infrun.c: Fix common/ includes.
8577         * inflow.c: Fix common/ includes.
8578         * inferior.h: Fix common/ includes.
8579         * inferior.c: Fix common/ includes.
8580         * infcmd.c: Fix common/ includes.
8581         * inf-ptrace.c: Fix common/ includes.
8582         * inf-child.c: Fix common/ includes.
8583         * ia64-linux-nat.c: Fix common/ includes.
8584         * i387-tdep.c: Fix common/ includes.
8585         * i386-tdep.c: Fix common/ includes.
8586         * i386-linux-tdep.c: Fix common/ includes.
8587         * i386-linux-nat.c: Fix common/ includes.
8588         * i386-go32-tdep.c: Fix common/ includes.
8589         * i386-fbsd-tdep.c: Fix common/ includes.
8590         * i386-fbsd-nat.c: Fix common/ includes.
8591         * guile/scm-type.c: Fix common/ includes.
8592         * guile/guile.c: Fix common/ includes.
8593         * go32-nat.c: Fix common/ includes.
8594         * gnu-nat.c: Fix common/ includes.
8595         * gdbthread.h: Fix common/ includes.
8596         * gdbarch-selftests.c: Fix common/ includes.
8597         * gdb_usleep.c: Fix common/ includes.
8598         * gdb_select.h: Fix common/ includes.
8599         * gdb_bfd.c: Fix common/ includes.
8600         * gcore.c: Fix common/ includes.
8601         * fork-child.c: Fix common/ includes.
8602         * findvar.c: Fix common/ includes.
8603         * fbsd-nat.c: Fix common/ includes.
8604         * event-top.c: Fix common/ includes.
8605         * event-loop.c: Fix common/ includes.
8606         * dwarf2read.c: Fix common/ includes.
8607         * dwarf2loc.c: Fix common/ includes.
8608         * dwarf2-frame.c: Fix common/ includes.
8609         * dwarf-index-cache.c: Fix common/ includes.
8610         * dtrace-probe.c: Fix common/ includes.
8611         * disasm-selftests.c: Fix common/ includes.
8612         * defs.h: Fix common/ includes.
8613         * csky-tdep.c: Fix common/ includes.
8614         * cp-valprint.c: Fix common/ includes.
8615         * cp-support.h: Fix common/ includes.
8616         * cp-support.c: Fix common/ includes.
8617         * corelow.c: Fix common/ includes.
8618         * completer.h: Fix common/ includes.
8619         * completer.c: Fix common/ includes.
8620         * compile/compile.c: Fix common/ includes.
8621         * compile/compile-loc2c.c: Fix common/ includes.
8622         * compile/compile-cplus-types.c: Fix common/ includes.
8623         * compile/compile-cplus-symbols.c: Fix common/ includes.
8624         * command.h: Fix common/ includes.
8625         * cli/cli-dump.c: Fix common/ includes.
8626         * cli/cli-cmds.c: Fix common/ includes.
8627         * charset.c: Fix common/ includes.
8628         * build-id.c: Fix common/ includes.
8629         * btrace.h: Fix common/ includes.
8630         * btrace.c: Fix common/ includes.
8631         * breakpoint.h: Fix common/ includes.
8632         * breakpoint.c: Fix common/ includes.
8633         * ax.h:
8634         (enum agent_op): Fix common/ includes.
8635         * ax-general.c (struct aop_map): Fix common/ includes.
8636         * ax-gdb.c: Fix common/ includes.
8637         * auxv.c: Fix common/ includes.
8638         * auto-load.c: Fix common/ includes.
8639         * arm-tdep.c: Fix common/ includes.
8640         * arch/riscv.c: Fix common/ includes.
8641         * arch/ppc-linux-common.c: Fix common/ includes.
8642         * arch/i386.c: Fix common/ includes.
8643         * arch/arm.c: Fix common/ includes.
8644         * arch/arm-linux.c: Fix common/ includes.
8645         * arch/arm-get-next-pcs.c: Fix common/ includes.
8646         * arch/amd64.c: Fix common/ includes.
8647         * arch/aarch64.c: Fix common/ includes.
8648         * arch/aarch64-insn.c: Fix common/ includes.
8649         * arch-utils.c: Fix common/ includes.
8650         * amd64-windows-tdep.c: Fix common/ includes.
8651         * amd64-tdep.c: Fix common/ includes.
8652         * amd64-sol2-tdep.c: Fix common/ includes.
8653         * amd64-obsd-tdep.c: Fix common/ includes.
8654         * amd64-nbsd-tdep.c: Fix common/ includes.
8655         * amd64-linux-tdep.c: Fix common/ includes.
8656         * amd64-linux-nat.c: Fix common/ includes.
8657         * amd64-fbsd-tdep.c: Fix common/ includes.
8658         * amd64-fbsd-nat.c: Fix common/ includes.
8659         * amd64-dicos-tdep.c: Fix common/ includes.
8660         * amd64-darwin-tdep.c: Fix common/ includes.
8661         * agent.c: Fix common/ includes.
8662         * ada-lang.h: Fix common/ includes.
8663         * ada-lang.c: Fix common/ includes.
8664         * aarch64-tdep.c: Fix common/ includes.
8665
8666 2019-01-25  Tom Tromey  <tom@tromey.com>
8667
8668         * common/create-version.sh: Use common/version.h.
8669
8670 2019-01-24  Pedro Alves  <palves@redhat.com>
8671
8672         * infrun.c (signal_stop, signal_print, signal_program)
8673         (signal_catch, signal_pass): Now arrays instead of pointers.
8674         (update_signals_program_target, do_target_resume)
8675         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8676         * linux-nat.c (linux_nat_target::pass_signals)
8677         (linux_nat_target::create_inferior, linux_nat_target::attach):
8678         Adjust.
8679         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8680         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8681         * procfs.c (procfs_target::pass_signals): Adjust.
8682         * record-full.c (record_full_target::resume): Adjust.
8683         * remote.c (remote_target::pass_signals)
8684         (remote_target::program_signals): Adjust.
8685         * target-debug.h (target_debug_print_signals): Now takes a
8686         gdb::array_view as parameter.  Adjust.
8687         * target.h (target_ops) <pass_signals, program_signals>: Replace
8688         pointer and length parameters with gdb::array_view.
8689         (target_pass_signals, target_program_signals): Likewise.
8690         * target-delegates.c: Regenerate.
8691
8692 2019-01-24  Pedro Alves  <palves@redhat.com>
8693
8694         * common/forward-scope-exit.h
8695         (forward_scope_exit::forward_scope_exit): Pass arguments to
8696         m_bind_function directly, instead of creating a std::bind and
8697         copying that.
8698
8699 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8700
8701         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8702         for static members.
8703         (pass_in_v_vfp_candidate): Likewise.
8704
8705 2019-01-23  Tom Tromey  <tom@tromey.com>
8706             Pedro Alves  <palves@redhat.com>
8707
8708         * regcache.c (class regcache_invalidator): Remove.
8709         (regcache::raw_write): Use make_scope_exit.
8710
8711 2019-01-23  Tom Tromey  <tom@tromey.com>
8712
8713         * ui-out.h (class ui_out_emit_type): Update comment.
8714
8715 2019-01-23  Tom Tromey  <tom@tromey.com>
8716
8717         * infrun.c (fetch_inferior_event): Update comment.
8718
8719 2019-01-23  Tom Tromey  <tom@tromey.com>
8720             Pedro Alves  <palves@redhat.com>
8721
8722         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8723         parameter.
8724         (fetch_inferior_event): Use SCOPE_EXIT.
8725
8726
8727 2019-01-23  Tom Tromey  <tom@tromey.com>
8728             Pedro Alves  <palves@redhat.com>
8729
8730         * infrun.c (disable_thread_events): Delete.
8731         (stop_all_threads): Use SCOPE_EXIT.
8732
8733 2019-01-23  Tom Tromey  <tom@tromey.com>
8734             Pedro Alves  <palves@redhat.com>
8735
8736         * symfile.c: Include forward-scope-exit.h.
8737         (clear_symtab_users_cleanup): Replace forward declaration with
8738         a FORWARD_SCOPE_EXIT.
8739         (syms_from_objfile_1): Use the forward_scope_exit and
8740         gdb::optional instead of cleanup_function.
8741         (reread_symbols): Use the forward_scope_exit instead of
8742         cleanup_function.
8743         (clear_symtab_users_cleanup): Remove function.
8744
8745 2019-01-23  Tom Tromey  <tom@tromey.com>
8746             Pedro Alves  <palves@redhat.com>
8747
8748         * linux-nat.c: Include scope-exit.h.
8749         (cleanup_target_stop): Remove.
8750         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8751         SCOPE_EXIT.
8752
8753 2019-01-23  Tom Tromey  <tom@tromey.com>
8754             Pedro Alves  <palves@redhat.com>
8755
8756         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8757         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8758
8759 2019-01-23  Tom Tromey  <tom@tromey.com>
8760             Andrew Burgess  <andrew.burgess@embecosm.com>
8761             Pedro Alves  <palves@redhat.com>
8762
8763         * infrun.c (fetch_inferior_event): Use scope_exit.
8764         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8765         * top.c (execute_command): Use scope_exit.
8766         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8767         * utils.c (do_bpstat_clear_actions_cleanup)
8768         (make_bpstat_clear_actions_cleanup): Remove.
8769
8770 2019-01-23  Tom Tromey  <tom@tromey.com>
8771             Pedro Alves  <palves@redhat.com>
8772
8773         * infrun.c: Include "common/scope-exit.h"
8774         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8775         (wait_for_inferior): Use SCOPE_EXIT.
8776         (fetch_inferior_event): Use scope_exit.
8777
8778 2019-01-23  Tom Tromey  <tom@tromey.com>
8779             Pedro Alves  <palves@redhat.com>
8780
8781         * breakpoint.c (create_breakpoint): Remove cleanup.
8782
8783 2019-01-23  Tom Tromey  <tom@tromey.com>
8784             Andrew Burgess  <andrew.burgess@embecosm.com>
8785             Pedro Alves  <palves@redhat.com>
8786
8787 2019-01-23  Pedro Alves  <palves@redhat.com>
8788
8789         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8790
8791 2019-01-23  Pedro Alves  <palves@redhat.com>
8792             Andrew Burgess  <andrew.burgess@embecosm.com>
8793
8794         * gdbthread.h: Include "common/forward-scope-exit.h".
8795         (scoped_finish_thread_state): Redefine custom class in terms of
8796         forward_scope_exit.
8797
8798 2019-01-23  Pedro Alves  <palves@redhat.com>
8799             Andrew Burgess  <andrew.burgess@embecosm.com>
8800
8801         * common/forward-scope-exit.h: New file.
8802
8803 2019-01-23  Pedro Alves  <palves@redhat.com>
8804             Andrew Burgess  <andrew.burgess@embecosm.com>
8805             Tom Tromey  <tom@tromey.com>
8806
8807         * common/scope-exit.h: New file.
8808
8809 2019-01-23  Pedro Alves  <palves@redhat.com>
8810
8811         * common/preprocessor.h (ESC): Rename to ...
8812         (ESC_PARENS): ... this.
8813         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8814         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8815
8816 2019-01-23  Tom Tromey  <tom@tromey.com>
8817
8818         * language.h (class scoped_switch_to_sym_language_if_auto):
8819         Initialize m_lang in both cases.
8820
8821 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8822
8823         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8824         with XCNEW.
8825
8826 2019-01-22  Tom Tromey  <tom@tromey.com>
8827
8828         * corelow.c: Do not include sys/file.h.
8829
8830 2019-01-22  Tom Tromey  <tom@tromey.com>
8831
8832         * tui/tui-wingeneral.h: Include gdb_curses.h.
8833
8834 2019-01-22  Tom Tromey  <tom@tromey.com>
8835
8836         * source-cache.h (class source_cache) <get_source_lines,
8837         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8838
8839 2019-01-22  Tom Tromey  <tom@tromey.com>
8840
8841         * remote-fileio.h (struct remote_target): Declare.
8842
8843 2019-01-22  Tom Tromey  <tom@tromey.com>
8844
8845         * python/py-arch.c: Do not include py-ref.h.
8846         * python/py-bpevent.c: Do not include py-ref.h.
8847         * python/py-cmd.c: Do not include py-ref.h.
8848         * python/py-continueevent.c: Do not include py-ref.h.
8849         * python/py-event.h: Do not include py-ref.h.
8850         * python/py-evtregistry.c: Do not include py-ref.h.
8851         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8852         * python/py-frame.c: Do not include py-ref.h.
8853         * python/py-framefilter.c: Do not include py-ref.h.
8854         * python/py-function.c: Do not include py-ref.h.
8855         * python/py-infevents.c: Do not include py-ref.h.
8856         * python/py-linetable.c: Do not include py-ref.h.
8857         * python/py-objfile.c: Do not include py-ref.h.
8858         * python/py-param.c: Do not include py-ref.h.
8859         * python/py-prettyprint.c: Do not include py-ref.h.
8860         * python/py-progspace.c: Do not include py-ref.h.
8861         * python/py-symbol.c: Do not include py-ref.h.
8862         * python/py-symtab.c: Do not include py-ref.h.
8863         * python/py-type.c: Do not include py-ref.h.
8864         * python/py-unwind.c: Do not include py-ref.h.
8865         * python/py-utils.c: Do not include py-ref.h.
8866         * python/py-value.c: Do not include py-ref.h.
8867         * python/py-varobj.c: Do not include py-ref.h.
8868         * python/py-xmethods.c: Do not include py-ref.h.
8869         * python/python.c: Do not include py-ref.h.
8870         * varobj.c: Do not include py-ref.h.
8871
8872 2019-01-22  Tom Tromey  <tom@tromey.com>
8873
8874         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8875         keyword for bcache.
8876
8877 2019-01-22  Tom Tromey  <tom@tromey.com>
8878
8879         * compile/compile-cplus-types.c: Remove a comment by #include.
8880
8881 2019-01-22  Tom Tromey  <tom@tromey.com>
8882
8883         * compile/gcc-c-plugin.h: Include compile-internal.h.
8884
8885 2019-01-22  Tom Tromey  <tom@tromey.com>
8886
8887         * stabsread.c (EXTERN): Do not define.
8888         (symnum, next_symbol_text_func, processing_gcc_compilation)
8889         (within_function, global_sym_chain, global_stabs)
8890         (previous_stab_code, this_object_header_files)
8891         (n_this_object_header_files)
8892         (n_allocated_this_object_header_files): Define.
8893         * stabsread.h (EXTERN): Never define.  Use "extern".
8894
8895 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8896
8897         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8898         history_value.
8899
8900 2019-01-21  Tom Tromey  <tom@tromey.com>
8901
8902         * ui-out.c: Fix includes.
8903         * tui/tui-source.c: Fix includes.
8904         * target.c: Fix includes.
8905         * remote.c: Fix includes.
8906         * regcache.c: Fix includes.
8907         * python/py-block.c: Fix includes.
8908         * printcmd.c: Fix includes.
8909         * or1k-tdep.c: Fix includes.
8910         * mi/mi-main.c: Fix includes.
8911         * m32r-tdep.c: Fix includes.
8912         * csky-tdep.c: Fix includes.
8913         * compile/compile-cplus-types.c: Fix includes.
8914         * cli/cli-interp.c: Fix includes.
8915
8916 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8917
8918         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8919         for padding.
8920
8921 2019-01-16  Tom Tromey  <tom@tromey.com>
8922
8923         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8924         earlier.
8925         (struct objfile) <msymbols_range>: Move from top level.
8926         <msymbols>: New method.
8927         (class objfile_msymbols): Remove.
8928         * symtab.c (default_collect_symbol_completion_matches_break_on):
8929         Update.
8930         * symmisc.c (dump_msymbols): Update.
8931         * stabsread.c (scan_file_globals): Update.
8932         * objc-lang.c (info_selectors_command, info_classes_command)
8933         (find_methods): Update.
8934         * minsyms.c (find_solib_trampoline_target): Update.
8935         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8936         * coffread.c (coff_symfile_read): Update.
8937         * ada-lang.c (ada_lookup_simple_minsym)
8938         (ada_collect_symbol_completion_matches): Update.
8939
8940 2019-01-16  Tom Tromey  <tom@tromey.com>
8941
8942         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8943         type.  Remove no-argument constructor.
8944         <iterator::operator++>: Simplify.
8945         <begin>: Update.
8946         <end>: Use minimal_symbol_count.
8947
8948 2019-01-16  Tom Tromey  <tom@tromey.com>
8949
8950         * objfiles.h (struct objfile) <psymtabs>: New method.
8951         (class objfile_psymtabs): Remove.
8952         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8953         typedef.
8954         <range>: New method.
8955         (require_partial_symbols): Change return type.
8956         * psymtab.c (require_partial_symbols)
8957         (psym_expand_symtabs_matching): Update.
8958         * mdebugread.c (parse_partial_symbols): Update.
8959         * dbxread.c (dbx_end_psymtab): Update.
8960
8961 2019-01-15  Tom Tromey  <tom@tromey.com>
8962
8963         * symtab.c (lookup_objfile_from_block)
8964         (lookup_symbol_in_objfile_symtabs)
8965         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8966         (find_line_symtab, info_sources_command)
8967         (default_collect_symbol_completion_matches_break_on)
8968         (make_source_files_completion_list): Update.
8969         * symmisc.c (print_objfile_statistics, dump_objfile)
8970         (maintenance_print_symbols, maintenance_info_symtabs)
8971         (maintenance_check_symtabs, maintenance_info_line_tables):
8972         Update.
8973         * source.c (select_source_symtab)
8974         (forget_cached_source_info_for_objfile): Update.
8975         * objfiles.h (class objfile_compunits): Remove.
8976         (struct objfile) <compunits_range>: New typedef.
8977         (compunits): New method.
8978         * objfiles.c (objfile_relocate1): Update.
8979         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8980         * maint.c (count_symtabs_and_blocks): Update.
8981         * linespec.c (iterate_over_all_matching_symtabs): Update.
8982         * cp-support.c (add_symbol_overload_list_qualified): Update.
8983         * coffread.c (coff_symtab_read): Update.
8984         * ada-lang.c (add_nonlocal_symbols)
8985         (ada_collect_symbol_completion_matches)
8986         (ada_add_global_exceptions): Update.
8987
8988 2019-01-15  Tom Tromey  <tom@tromey.com>
8989
8990         * progspace.h (program_space) <objfiles_safe_range>: New
8991         typedef.
8992         <objfiles_safe>: New method.
8993         * objfiles.h (class all_objfiles_safe): Remove.
8994         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8995         * jit.c (jit_inferior_exit_hook): Update.
8996
8997 2019-01-17  Tom Tromey  <tom@tromey.com>
8998
8999         * progspace.h (program_space) <objfiles_range>: New typedef.
9000         <objfiles>: New method.
9001         <objfiles_head>: Rename from objfiles.
9002         (object_files): Update.
9003         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9004         * guile/scm-pretty-print.c
9005         (ppscm_find_pretty_printer_from_objfiles): Update.
9006         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9007         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9008         Update.
9009         * python/py-progspace.c (pspy_get_objfiles): Update.
9010         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9011         Update.
9012         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9013         (objfpy_lookup_objfile_by_build_id): Update.
9014         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9015         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9016         Update.
9017         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9018         (expand_symtab_containing_pc, lookup_objfile_from_block)
9019         (lookup_static_symbol, basic_lookup_transparent_type)
9020         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9021         (find_line_symtab, info_sources_command)
9022         (default_collect_symbol_completion_matches_break_on)
9023         (make_source_files_completion_list, find_main_name): Update.
9024         * symmisc.c (print_symbol_bcache_statistics)
9025         (print_objfile_statistics, maintenance_print_symbols)
9026         (maintenance_print_msymbols, maintenance_print_objfiles)
9027         (maintenance_info_symtabs, maintenance_check_symtabs)
9028         (maintenance_expand_symtabs, maintenance_info_line_tables):
9029         Update.
9030         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9031         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9032         (map_overlay_command, unmap_overlay_command)
9033         (simple_overlay_update, expand_symtabs_matching)
9034         (map_symbol_filenames): Update.
9035         * symfile-debug.c (set_debug_symfile): Update.
9036         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9037         Update.
9038         * source.c (select_source_symtab, forget_cached_source_info):
9039         Update.
9040         * solib.c (solib_read_symbols): Update.
9041         * solib-spu.c (append_ocl_sos): Update.
9042         * psymtab.c (maintenance_print_psymbols)
9043         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9044         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9045         * printcmd.c (info_symbol_command): Update.
9046         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9047         Update.
9048         * objfiles.h (class all_objfiles): Remove.
9049         * objfiles.c (have_partial_symbols, have_full_symbols)
9050         (have_minimal_symbols, qsort_cmp, update_section_map)
9051         (shared_objfile_contains_address_p)
9052         (default_iterate_over_objfiles_in_search_order): Update.
9053         * objc-lang.c (info_selectors_command, info_classes_command)
9054         (find_methods): Update.
9055         * minsyms.c (find_solib_trampoline_target): Update.
9056         * maint.c (maintenance_info_sections)
9057         (maintenance_translate_address, count_symtabs_and_blocks):
9058         Update.
9059         * main.c (captured_main_1): Update.
9060         * linux-thread-db.c (try_thread_db_load_from_pdir)
9061         (has_libpthread): Update.
9062         * linespec.c (iterate_over_all_matching_symtabs)
9063         (search_minsyms_for_name): Update.
9064         * jit.c (jit_find_objf_with_entry_addr): Update.
9065         * hppa-tdep.c (find_unwind_entry)
9066         (hppa_lookup_stub_minimal_symbol): Update.
9067         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9068         Update.
9069         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9070         (elf_gnu_ifunc_resolve_by_got): Update.
9071         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9072         * dwarf-index-write.c (save_gdb_index_command): Update.
9073         * cp-support.c (add_symbol_overload_list_qualified): Update.
9074         * breakpoint.c (create_overlay_event_breakpoint)
9075         (create_longjmp_master_breakpoint)
9076         (create_std_terminate_master_breakpoint)
9077         (create_exception_master_breakpoint): Update.
9078         * blockframe.c (find_pc_partial_function): Update.
9079         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9080         (ada_collect_symbol_completion_matches)
9081         (ada_add_global_exceptions): Update.
9082
9083 2019-01-17  Tom Tromey  <tom@tromey.com>
9084
9085         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9086         declare VEC.
9087         (solib_target_parse_libraries): Change return type.
9088         (library_list_start_segment, library_list_start_section)
9089         (library_list_end_library, library_list_start_library); Update.
9090         (solib_target_free_library_list): Remove.
9091         (solib_target_parse_libraries): Remove cleanup.  Change return
9092         type.
9093         (solib_target_current_sos): Update.
9094
9095 2019-01-17  Tom Tromey  <tromey@bapiya>
9096
9097         * valprint.c: Replace "the the" with "the".
9098         * symtab.c: Replace "the the" with "the".
9099         * solib.c: Replace "the the" with "the".
9100         * solib-dsbt.c: Replace "the the" with "the".
9101         * linespec.c: Replace "the the" with "the".
9102         * dwarf2loc.h: Replace "the the" with "the".
9103         * amd64-windows-tdep.c: Replace "the the" with "the".
9104         * aarch64-tdep.c: Replace "the the" with "the".
9105
9106 2019-01-16  Keith Seitz  <keiths@redhat.com>
9107
9108         PR gdb/23773
9109         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9110         <builder>: Rename to ..
9111         <m_builder>: ... this and make private.
9112         (dwarf2_cu::get_builder): New method.  Change all users of
9113         `builder' to use this method.
9114         (dwarf2_start_symtab): Move to ...
9115         (dwarf2_cu::start_symtab): ... here.  Update all callers
9116         (setup_type_unit_groups): Move to ...
9117         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9118         callers.
9119         (dwarf2_cu::reset_builder): New method.
9120         (process_full_compunit, process_full_type_unit): Use
9121         dwarf2_cu::reset_builder.
9122         (follow_die_offset): Record the ancestor CU if it is different
9123         from the followed DIE's CU.
9124         (follow_die_sig_1): Likewise.
9125
9126 2019-01-15  Tom Tromey  <tom@tromey.com>
9127
9128         * remote.c (class remote_state) <buf>: Now a char_vector.
9129         <buf_size>: Remove.
9130         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9131         parameter.
9132         (remote_target::getpkt_or_notif_sane_1)
9133         (remote_target::getpkt_sane)
9134         (remote_target::getpkt_or_notif_sane): Likewise.
9135         (class remote_target) <putpkt>: New overload.
9136         (remote_target::read_frame): Change type of "buf_p".  Remove
9137         sizeof_p parameter.
9138         (packet_ok): New overload.
9139         (packet_check_result): New overload.
9140         Update all uses.
9141
9142 2019-01-14  Tom Tromey  <tom@tromey.com>
9143
9144         * remote-notif.c (handle_notification, remote_notif_ack)
9145         (remote_notif_parse): Make "buf" const.
9146         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9147         const.
9148         (remote_notif_parse, remote_notif_ack, handle_notification):
9149         Likewise.
9150         * remote.c (remote_notif_stop_parse): Make "buf" const.
9151         (remote_target::remote_parse_stop_reply): Make "buf" const.
9152         (remote_notif_stop_ack): Make "buf" const.
9153
9154 2019-01-14  Tom Tromey  <tom@tromey.com>
9155
9156         * remote.c (remote_console_output): Make parameter const.
9157
9158 2019-01-14  Tom Tromey  <tom@tromey.com>
9159
9160         * target-debug.h (target_debug_print_signals): Constify.
9161         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9162         * procfs.c (procfs_target::pass_signals): Update.
9163         * linux-nat.c (linux_nat_target::pass_signals): Update.
9164         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9165         * target-delegates.c: Rebuild.
9166         * remote.c (remote_target::program_signals): Update.
9167         (remote_target::pass_signals): Update.
9168         * target.c (target_pass_signals): Constify argument.
9169         (target_program_signals): Likewise.
9170         * target.h (struct target_ops) <pass_signals, program_signals>:
9171         Constify argument.
9172         (target_pass_signals, target_program_signals): Constify argument.
9173
9174 2019-01-14  Tom Tromey  <tom@tromey.com>
9175
9176         PR tui/28819:
9177         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9178
9179 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9180
9181         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9182         field.
9183         * rs6000-tdep.c: Include reggroups.h.
9184         (IS_V_ALIAS_PSEUDOREG): Define.
9185         (rs6000_register_name): Return names for the "vX" aliases.
9186         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9187         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9188         aliases.  Call default_register_reggroup_p for all other
9189         pseudo-registers.
9190         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9191         New functions.
9192         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9193         Handle "vX" aliases.
9194         (v_alias_pseudo_register_collect): New function.
9195         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9196         (rs6000_gdbarch_init): Initialize "vX" aliases as
9197         pseudo-registers.  Restore registration of
9198         rs6000_pseudo_register_reggroup_p with
9199         set_tdesc_pseudo_register_reggroup_p.
9200
9201 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9202
9203         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9204         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9205         set_gdbarch_num_pseudo_regs.
9206
9207 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9208
9209         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9210         Remove arg prefixname, add do_set and do_show.
9211         Add member functions set_list and show_list.
9212         * cli/cli-style.c (class cli_style_option): Update accordingly.
9213         (style_set_list): Move to file scope.
9214         (style_show_list): Likewise.
9215         (set_style): Call help_list.
9216         (show_style): Call cmd_show_list.
9217         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9218         Update to use the new macro.
9219
9220 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9221
9222         * ada-lang.c (_initialize_ada_language): Expand the help text
9223         for the "catch exception" command.
9224
9225 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9226
9227         * symtab.c (matching_obj_sections): Initialize obj,
9228         declare it closer to its usage.
9229
9230 2019-01-10  Tom Tromey  <tom@tromey.com>
9231
9232         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9233         (basic_inf_threads_range): Remove.
9234         (inf_threads_range, inf_non_exited_threads_range)
9235         (safe_inf_threads_range): Use next_adapter.
9236
9237 2019-01-10  Keith Seitz  <keiths@redhat.com>
9238
9239         PR gdb/23712
9240         PR symtab/23010
9241         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9242         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9243
9244 2019-01-10  Keith Seitz  <keiths@redhat.com>
9245
9246         PR gdb/23712
9247         PR symtab/23010
9248         * dictionary.c (pending_to_vector): Remove.
9249         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9250         Remove _1 suffix, replacing functions of the same name.  Update
9251         all callers.
9252         (dict_create_hashed, dict_create_hashed_expandable)
9253         (dict_create_linear, dict_create_linear_expandable, dict_free)
9254         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9255         Make functions static.
9256
9257 2019-01-10  Keith Seitz  <keiths@redhat.com>
9258
9259         PR gdb/23712
9260         PR symtab/23010
9261         * dictionary.h (struct dictionary): Replace declaration with
9262         multidictionary.
9263         (dict_create_hashed, dict_create_hashed_expandable)
9264         (dict_create_linear, dict_create_linear_expandable)
9265         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9266         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9267         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9268         taking multidictionary argument.
9269         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9270         * block.h (struct block) <dict>: Change to multidictionary
9271         and rename `multidict'.
9272         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9273         symmisc.c: Update all dictionary references to multidictionary.
9274
9275 2019-01-10  Keith Seitz  <keiths@redhat.com>
9276
9277         PR gdb/23712
9278         PR symtab/23010
9279         * dictionary.c: Include unordered_map.
9280         (pending_to_vector): New function.
9281         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9282         Rewrite the non-"_1" functions to take vector instead
9283         of linked list.
9284         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9285         "new" _1 versions of the same name.
9286         (multidictionary): Define.
9287         (std::hash<enum language): New definition.
9288         (collate_pending_symbols_by_language, mdict_create_hashed)
9289         (mdict_create_hashed_expandable, mdict_create_linear)
9290         (mdict_create_linear_expandable, mdict_free)
9291         (find_language_dictionary, create_new_language_dictionary)
9292         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9293         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9294         (mdict_size, mdict_empty): New functions.
9295         * dictionary.h (mdict_iterator): Define.
9296
9297 2019-01-10  Pedro Alves  <palves@redhat.com>
9298
9299         * breakpoint.c (read_uploaded_action)
9300         (create_tracepoint_from_upload): Adjust to use
9301         gdb::unique_xmalloc_ptr.
9302         * ctf.c (ctf_write_uploaded_tp):
9303         (SET_ARRAY_FIELD): Use emplace_back.
9304         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9305         * tracefile-tfile.c (tfile_write_uploaded_tp):
9306         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9307         gdb::unique_xmalloc_ptr.
9308         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9309         at_string, cond_string, cmd_strings>: Replace char pointers
9310         with gdb::unique_xmalloc_ptr.
9311
9312 2019-01-10  Pedro Alves  <palves@redhat.com>
9313
9314         * solib-target.c (library_list_start_library): Don't xstrdup name.
9315
9316 2019-01-10  Pedro Alves  <palves@redhat.com>
9317
9318         * mdebugread.c (parse_partial_symbols): Use
9319         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9320
9321 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9322
9323         * linux-fork.c (scoped_switch_fork_info)
9324         <~scoped_switch_fork_info>: Fix incorrect variable name.
9325
9326 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9327
9328         * linux-fork.c (scoped_switch_fork_info)
9329         <scoped_switch_fork_info>: Make explicit.
9330         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9331
9332 2019-01-10  Tom Tromey  <tom@tromey.com>
9333
9334         * objfiles.h (objfile::reset_psymtabs): Update.
9335         * objfiles.c (objfile::objfile): Update.
9336         * psymtab.h (psymtab_storage::obstack): Update.
9337         (psymtab_storage::m_obstack): Use gdb::optional.
9338         (class psymtab_storage): Update comment.  Remove objfile
9339         parameter.
9340         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9341
9342 2019-01-10  Tom Tromey  <tom@tromey.com>
9343
9344         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9345         <free_psymtabs>: Now private.
9346         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9347         (allocate_psymtab): Use new method.
9348
9349 2019-01-10  Tom Tromey  <tom@tromey.com>
9350
9351         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9352         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9353         * mdebugread.c (parse_partial_symbols): Use
9354         allocate_dependencies.
9355         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9356         allocate_dependencies.
9357         (process_psymtab_comp_unit_reader)
9358         (build_type_psymtab_dependencies): Likewise.
9359         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9360
9361 2019-01-10  Tom Tromey  <tom@tromey.com>
9362
9363         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9364         PSYMBOL_SET_LANGUAGE.
9365         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9366
9367 2019-01-10  Tom Tromey  <tom@tromey.com>
9368
9369         * psymtab.h (psymtab_storage::obstack): New method.
9370         <m_obstack>: Rename from obstack; now private.
9371         * psymtab.c (psymtab_storage): Update.
9372         * dwarf2read.c (create_addrmap_from_index)
9373         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9374         Update.
9375
9376 2019-01-10  Tom Tromey  <tom@tromey.com>
9377
9378         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9379         * objfiles.h (objfile::reset_psymtabs): New method.
9380
9381 2019-01-10  Tom Tromey  <tom@tromey.com>
9382
9383         * symmisc.c (print_symbol_bcache_statistics): Update.
9384         (print_objfile_statistics): Update.
9385         * symfile.c (reread_symbols): Update.
9386         * psymtab.h (class psymtab_storage): New.
9387         * psymtab.c (psymtab_storage): New constructor.
9388         (~psymtab_storage): New destructor.
9389         (require_partial_symbols): Update.
9390         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9391         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9392         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9393         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9394         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9395         (start_psymtab_common, end_psymtab_common)
9396         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9397         (allocate_psymtab): Update.
9398         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9399         Update.
9400         (dump_psymtab_addrmap, maintenance_print_psymbols)
9401         (maintenance_check_psymtabs): Update.
9402         (class objfile_psymtabs): Move to objfiles.h.
9403         * psympriv.h (discard_psymtab): Now inline.
9404         (psymtab_discarder::psymtab_discarder): Update.
9405         (psymtab_discarder::~psymtab_discarder): Update.
9406         (ALL_OBJFILE_PSYMTABS): Rewrite.
9407         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9408         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9409         Remove fields.
9410         <partial_symtabs>: New field.
9411         (class objfile_psymtabs): Move from psymtab.h.  Update.
9412         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9413         psymbol_cache.
9414         (objfile::~objfile): Don't destroy psymbol_cache.
9415         * mdebugread.c (parse_partial_symbols): Update.
9416         * dwarf2read.c (create_addrmap_from_index)
9417         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9418         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9419         (add_partial_subprogram, dwarf2_ranges_read): Update.
9420         * dwarf-index-write.c (write_address_map)
9421         (write_one_signatured_type, recursively_write_psymbols)
9422         (class debug_names, class debug_names, write_psymtabs_to_index):
9423         Update.
9424
9425 2019-01-10  Tom Tromey  <tom@tromey.com>
9426
9427         * symtab.h (SYMBOL_SET_NAMES): Update.
9428         (symbol_set_names): Update.
9429         (MSYMBOL_SET_NAMES): Update.
9430         * symtab.c (symbol_set_names): Change argument to be an
9431         objfile_per_bfd_storage.
9432         * psymtab.c (add_psymbol_to_bcache): Update.
9433         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9434
9435 2019-01-10  Tom Tromey  <tom@tromey.com>
9436
9437         * symtab.c (create_demangled_names_hash): Change argument to be an
9438         objfile_per_bfd_storage.
9439         (symbol_set_names): Update.
9440
9441 2019-01-10  Tom Tromey  <tom@tromey.com>
9442
9443         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9444         init_psymbol_list.
9445         * psymtab.c (init_psymbol_list): Do nothing if already called.
9446         * psympriv.h (init_psymbol_list): Add comment.
9447         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9448         init_psymbol_list.
9449         * dbxread.c (dbx_symfile_read): Unconditionally call
9450         init_psymbol_list.
9451
9452 2019-01-10  Tom Tromey  <tom@tromey.com>
9453
9454         * xcoffread.c (scan_xcoff_symtab): Update.
9455         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9456         "where".
9457         * mdebugread.c (parse_partial_symbols)
9458         (handle_psymbol_enumerators): Update.
9459         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9460         * dbxread.c (read_dbx_symtab): Update.
9461         * psympriv.h (psymbol_placement): New enum.
9462         (add_psymbol_to_list): Update.
9463
9464 2019-01-10  Tom Tromey  <tom@tromey.com>
9465
9466         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9467         static_psymbols parameters.
9468         (scan_xcoff_symtab): Update.
9469         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9470         static_psymbols parameters.
9471         * psympriv.h (start_psymtab_common): Update.
9472         * mdebugread.c (parse_partial_symbols): Update.
9473         * dwarf2read.c (create_partial_symtab): Update.
9474         * dbxread.c (read_dbx_symtab): Update.
9475         (start_psymtab): Remove global_psymbols and static_psymbols
9476         parameters.
9477
9478 2019-01-10  Tom Tromey  <tom@tromey.com>
9479
9480         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9481         * psymtab.c (allocate_psymtab): Add comment.
9482         * psympriv.h (allocate_psymtab): Add comment.
9483         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9484         initializations.
9485         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9486
9487 2019-01-10  Tom Tromey  <tom@tromey.com>
9488
9489         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9490         Don't declare.
9491         * mipsread.c: Include mdebugread.h.
9492         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9493         Declare.
9494         * elfread.c: Include mdebugread.h.
9495
9496 2019-01-09  Tom Tromey  <tom@tromey.com>
9497
9498         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9499         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9500         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9501         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9502         (psym_lookup_symbol, psym_find_last_source_symtab)
9503         (psym_forget_cached_source_info, psym_print_stats)
9504         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9505         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9506         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9507         (psym_find_compunit_symtab_by_address)
9508         (maintenance_print_psymbols, maintenance_info_psymtabs)
9509         (maintenance_check_psymtabs): Use ranged for.
9510         * psymtab.h (class objfile_psymtabs): New.
9511         (require_partial_symbols): Return objfile_psymtabs.
9512         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9513
9514 2019-01-09  Tom Tromey  <tom@tromey.com>
9515
9516         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9517         (find_pc_mapped_section, list_overlays_command)
9518         (map_overlay_command, unmap_overlay_command)
9519         (simple_overlay_update): Use all_objfiles.
9520         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9521         * printcmd.c (info_symbol_command): Use all_objfiles.
9522         * objfiles.h (ALL_OBJSECTIONS): Remove.
9523         * maint.c (maintenance_translate_address): Use all_objfiles.
9524         * gcore.c (gcore_create_callback): Use all_objfiles.
9525         (objfile_find_memory_regions): Likewise.
9526
9527 2019-01-09  Tom Tromey  <tom@tromey.com>
9528
9529         * symtab.c (find_line_symtab, info_sources_command)
9530         (make_source_files_completion_list): Use objfile_compunits.
9531         * source.c (select_source_symtab): Use objfile_compunits.
9532         * objfiles.h (struct objfile): Update comment.
9533         (ALL_OBJFILES): Remove.
9534         (ALL_FILETABS): Remove.
9535         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9536         objfile_compunits.
9537
9538 2019-01-09  Tom Tromey  <tom@tromey.com>
9539
9540         * symmisc.c (print_objfile_statistics, dump_objfile)
9541         (maintenance_print_symbols): Use compunit_filetabs.
9542         * source.c (forget_cached_source_info_for_objfile): Use
9543         compunit_filetabs.
9544         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9545         (ALL_FILETABS): Use compunit_filetabs.
9546         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9547         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9548
9549 2019-01-09  Tom Tromey  <tom@tromey.com>
9550
9551         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9552         (compunit_filetabs): New.
9553         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9554         compunit_filetabs.
9555         (info_sources_command, make_source_files_completion_list): Remove
9556         declaration.
9557         * symmisc.c (print_objfile_statistics, dump_objfile)
9558         (maintenance_print_symbols): Remove declaration.
9559         (maintenance_info_symtabs): Use compunit_filetabs.
9560         (maintenance_info_line_tables): Likewise.
9561         * source.c (select_source_symtab): Change local variable name.
9562         (forget_cached_source_info_for_objfile): Remove declaration.
9563         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9564         * objfiles.c (objfile_relocate1): Remove declaration.
9565         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9566         declaration.
9567         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9568         * coffread.c (coff_symtab_read): Remove declaration.
9569         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9570         compunit_filetabs.
9571
9572 2019-01-09  Tom Tromey  <tom@tromey.com>
9573
9574         * symtab.c (lookup_objfile_from_block)
9575         (find_pc_sect_compunit_symtab, search_symbols)
9576         (default_collect_symbol_completion_matches_break_on): Use
9577         objfile_compunits.
9578         * objfiles.h (ALL_COMPUNITS): Remove.
9579         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9580         * cp-support.c (add_symbol_overload_list_qualified): Use
9581         objfile_compunits.
9582         * ada-lang.c (ada_collect_symbol_completion_matches)
9583         (ada_add_global_exceptions): Use objfile_compunits.
9584
9585 2019-01-09  Tom Tromey  <tom@tromey.com>
9586
9587         * source.c (select_source_symtab)
9588         (forget_cached_source_info_for_objfile): Remove declaration.
9589         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9590         declaration.
9591         * maint.c (count_symtabs_and_blocks): Remove declaration.
9592         * cp-support.c (add_symbol_overload_list_qualified): Remove
9593         declaration.
9594         * coffread.c (coff_symtab_read): Remove declaration.
9595         * symtab.c (lookup_symbol_in_objfile_symtabs)
9596         (basic_lookup_transparent_type_1): Use objfile_compunits.
9597         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9598         (info_sources_command, search_symbols)
9599         (default_collect_symbol_completion_matches_break_on)
9600         (make_source_files_completion_list): Remove declaration.
9601         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9602         (ada_collect_symbol_completion_matches)
9603         (ada_add_global_exceptions): Remove declaration.
9604         * linespec.c (iterate_over_all_matching_symtabs): Use
9605         objfile_compunits.
9606         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9607         (class objfile_compunits): New.
9608         (ALL_COMPUNITS): Use objfile_compunits.
9609         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9610         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9611         objfile_compunits.
9612         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9613
9614 2019-01-09  Tom Tromey  <tom@tromey.com>
9615
9616         * symtab.c (search_symbols)
9617         (default_collect_symbol_completion_matches_break_on): Use
9618         objfile_msymbols.
9619         * ada-lang.c (ada_lookup_simple_minsym)
9620         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9621         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9622         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9623         objfile_msymbols.
9624         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9625         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9626         * objc-lang.c (find_methods): Use objfile_msymbols.
9627         (info_selectors_command, info_classes_command): Likewise.
9628         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9629         * objfiles.h (class objfile_msymbols): New.
9630         (ALL_OBJFILE_MSYMBOLS): Remove.
9631         (ALL_MSYMBOLS): Remove.
9632
9633 2019-01-09  Tom Tromey  <tom@tromey.com>
9634
9635         * common/next-iterator.h (next_adapter): Add Iterator template
9636         parameter.
9637         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9638         (class all_objfiles_safe): New.
9639         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9640         * objfiles.c (put_objfile_before): Update comment.
9641         (add_separate_debug_objfile): Likewise.
9642         (free_all_objfiles): Use all_objfiles_safe.
9643         (objfile_purge_solibs): Likewise.
9644
9645 2019-01-09  Tom Tromey  <tom@tromey.com>
9646
9647         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9648         (expand_symtab_containing_pc, lookup_static_symbol)
9649         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9650         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9651         all_objfiles.
9652         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9653         * breakpoint.c (create_overlay_event_breakpoint)
9654         (create_longjmp_master_breakpoint)
9655         (create_std_terminate_master_breakpoint)
9656         (create_exception_master_breakpoint): Use all_objfiles.
9657         * linux-thread-db.c (try_thread_db_load_from_pdir)
9658         (has_libpthread): Use all_objfiles.
9659         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9660         * linespec.c (iterate_over_all_matching_symtabs)
9661         (search_minsyms_for_name): Use all_objfiles.
9662         * maint.c (maintenance_info_sections): Use all_objfiles.
9663         * main.c (captured_main_1): Use all_objfiles.
9664         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9665         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9666         * guile/scm-pretty-print.c
9667         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9668         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9669         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9670         (maintenance_print_msymbols): Use all_objfiles.
9671         * source.c (select_source_symtab): Use all_objfiles.
9672         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9673         * symfile.c (remove_symbol_file_command)
9674         (expand_symtabs_matching, map_symbol_filenames): Use
9675         all_objfiles.
9676         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9677         all_objfiles.
9678         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9679         * objc-lang.c (find_methods): Use all_objfiles.
9680         * objfiles.c (have_partial_symbols, have_full_symbols)
9681         (have_minimal_symbols, qsort_cmp)
9682         (default_iterate_over_objfiles_in_search_order): Use
9683         all_objfiles.
9684         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9685         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9686         (maintenance_check_psymtabs): Use all_objfiles.
9687         (ALL_PSYMTABS): Remove.
9688         * compile/compile-object-run.c (do_module_cleanup): Use
9689         all_objfiles.
9690         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9691         * cp-support.c (add_symbol_overload_list_qualified): Use
9692         all_objfiles.
9693         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9694         Use all_objfiles.
9695         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9696         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9697         all_objfiles.
9698         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9699         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9700         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9701         Uses all_objfiles.
9702         * solib.c (solib_read_symbols): Use all_objfiles
9703
9704 2019-01-09  Tom Tromey  <tom@tromey.com>
9705
9706         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9707         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9708         all_objfiles.
9709         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9710         * symmisc.c (print_symbol_bcache_statistics)
9711         (print_objfile_statistics, maintenance_print_objfiles)
9712         (maintenance_info_symtabs, maintenance_check_symtabs)
9713         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9714         all_objfiles.
9715         * source.c (forget_cached_source_info): Use all_objfiles.
9716         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9717         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9718         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9719         * objfiles.c (update_section_map): Use all_objfiles.
9720         (shared_objfile_contains_address_p): Likewise.
9721         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9722         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9723
9724 2019-01-09  Tom Tromey  <tom@tromey.com>
9725
9726         * common/next-iterator.h: New file.
9727         * objfiles.h (class all_objfiles): New.
9728         (struct objfile_iterator): New.
9729
9730 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9731
9732         * NEWS: Move the description of the changed "frame", "select-frame",
9733          and "info frame" commands to the Changed commands section.
9734
9735 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9736
9737         * gdbtypes.c (check_stub_method_group): Remove handling of old
9738         mangling schemes.
9739         * linespec.c (find_methods): Likewise.
9740         * stabsread.c (read_member_functions): Likewise.
9741         * valops.c (search_struct_method): Likewise.
9742         (value_struct_elt_for_reference): Likewise.
9743         * NEWS: Mention this change.
9744
9745 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9746
9747         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9748         print_source_lines.
9749         * source.c (print_source_lines_base): Update line number check.
9750         (print_source_lines): New function.
9751         (source_lines_range::source_lines_range): New function.
9752         * source.h (class source_lines_range): New class.
9753         (print_source_lines): New declaration.
9754
9755 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9756
9757         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9758
9759 2019-01-08  Tom Tromey  <tom@tromey.com>
9760             Simon Marchi  <simon.marchi@ericsson.com>
9761
9762         PR gdb/24060
9763         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9764         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9765         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9766         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9767         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9768         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9769
9770 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9771
9772         * source.c (select_source_symtab): Move header comment to
9773         declaration in source.h.
9774         (forget_cached_source_info_for_objfile): Likewise.
9775         (forget_cached_source_info): Likewise.
9776         (identify_source_line): Likewise.
9777         * source.h (identify_source_line): Move declaration from symtab.h
9778         and add comment from source.c
9779         (print_source_lines): Likewise.
9780         (forget_cached_source_info_for_objfile): Likewise.
9781         (forget_cached_source_info): Likewise.
9782         (select_source_symtab): Likewise.
9783         (enum print_source_lines_flag): Move definition from symtab.h.
9784         * symtab.h (identify_source_line): Move declaration to source.h.
9785         (print_source_lines): Likewise.
9786         (forget_cached_source_info_for_objfile): Likewise.
9787         (forget_cached_source_info): Likewise.
9788         (select_source_symtab): Likewise.
9789         (enum print_source_lines_flag): Move definition to source.h.
9790         * tui/tui-hooks.c: Add 'source.h' include.
9791
9792 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9793
9794         * source.c (print_source_lines_base): Handle requests to print
9795         reverse line number sequences, and guard against empty lines
9796         string.
9797
9798 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9799
9800         * source.c (print_source_lines_base): Fix skip of '\r' if next
9801         character is '\n'.
9802
9803 2019-01-06  Tom Tromey  <tom@tromey.com>
9804
9805         * c-exp.y (struct c_parse_state) <macro_original_text,
9806         expansion_obstack>: New member.
9807         (macro_original_text, expansion_obstack): Remove globals.
9808         (scan_macro_expansion, scanning_macro_expansion)
9809         (finished_macro_expansion): Update.
9810         (scan_macro_cleanup): Remove.
9811         (yylex, c_parse): Update.
9812
9813 2019-01-06  Tom Tromey  <tom@tromey.com>
9814
9815         * c-exp.y (struct c_parse_state) <strings>: New member.
9816         (operator_stoken): Update.
9817
9818 2019-01-06  Tom Tromey  <tom@tromey.com>
9819
9820         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9821         (union type_stack_elt) <typelist_val>: Now a pointer to
9822         std::vector.
9823         (type_stack_cleanup): Don't declare.
9824         (push_typelist): Update.
9825         * parse.c (pop_typelist): Return a std::vector.
9826         (push_typelist): Take a std::vector.
9827         (follow_types): Update.  Do not free args.
9828         (type_stack_cleanup): Remove.
9829         * c-exp.y (struct c_parse_state): New.
9830         (cpstate): New global.
9831         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9832         (nonempty_typelist): Update.
9833         (func_mod): Create a new vector.
9834         (c_parse): Create a c_parse_state.
9835         (check_parameter_typelist): Do not delete params.
9836         (function_method): Update.  Do not delete type_list.
9837
9838 2019-01-06  Tom Tromey  <tom@tromey.com>
9839
9840         PR gdb/28155:
9841         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9842         check_typedef.
9843         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9844         (print_return_value): Likewise.
9845
9846 2019-01-05  Tom Tromey  <tom@tromey.com>
9847
9848         * contrib/cleanup_check.py: Remove.
9849         * contrib/gcc-with-excheck: Remove.
9850         * contrib/exsummary.py: Remove.
9851         * contrib/excheck.py: Remove.
9852
9853 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9854
9855         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9856         NULL. Initialize tpprev to NULL instead of assigning it
9857         to NULL on the next statement.
9858         * windows-nat.c (windows_delete_thread): Remove check for
9859         main_thread_id before printing thread exit notifications.
9860         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9861         Remove thread ID check against main_thread_id.
9862         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9863         windows_delete_thread.
9864         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9865
9866 2019-01-04  Tom Tromey  <tom@tromey.com>
9867
9868         * compile/compile.c (_initialize_compile): Use upper case for
9869         metasyntactic variables.
9870         * symmisc.c (_initialize_symmisc): Use upper case for
9871         metasyntactic variables.
9872         * psymtab.c (_initialize_psymtab): Use upper case for
9873         metasyntactic variables.
9874         * demangle.c (demangle_command): Use upper case for metasyntactic
9875         variables.
9876         (_initialize_demangler): Likewise.
9877         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9878         variables.
9879
9880 2019-01-03  Tom Tromey  <tom@tromey.com>
9881
9882         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9883
9884 2019-01-03  Tom Tromey  <tom@tromey.com>
9885
9886         * python/py-symtab.c (salpy_str): Update.
9887         (struct salpy_sal_object) <symtab>: Now a PyObject.
9888         (salpy_dealloc): Update.
9889         (del_objfile_sal): Use gdbpy_ref.
9890
9891 2019-01-03  Tom Tromey  <tom@tromey.com>
9892
9893         * python/py-type.c (convert_field): Use new_reference.  Return
9894         gdbpy_ref.
9895         (make_fielditem): Return gdbpy_ref.
9896         (typy_fields): Update.
9897         (typy_getitem): Update.
9898         (field_name): Return gdbpy_ref.  Use new_reference.
9899         (typy_iterator_iternext): Update.
9900
9901 2019-01-03  Tom Tromey  <tom@tromey.com>
9902
9903         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9904
9905 2019-01-03  Tom Tromey  <tom@tromey.com>
9906
9907         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9908         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9909         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9910         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9911         (pspy_set_type_printers): Likewise.
9912         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9913         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9914         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9915         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9916         (objfpy_set_type_printers): Likewise.
9917
9918 2019-01-03  Tom Tromey  <tom@tromey.com>
9919
9920         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9921         (gdbpy_print_stack): Use gdbpy_err_fetch.
9922         * python/python-internal.h (class gdbpy_err_fetch): New class.
9923         (class gdbpy_enter) <m_error_type, m_error_value,
9924         m_error_traceback>: Remove.
9925         <m_error>: New member.
9926         (gdbpy_exception_to_string): Don't declare.
9927         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9928         * python/py-value.c (convert_value_from_python): Use
9929         gdbpy_err_fetch.
9930         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9931         gdbpy_exception_to_string.
9932         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9933         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9934         gdbpy_err_fetch.
9935
9936 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9937
9938         * linux-nat.c (delete_lwp_cleanup): Delete.
9939         (struct lwp_deleter): New struct.
9940         (lwp_info_up): New typedef.
9941         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9942         lwp_info_up.
9943
9944 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9945
9946         * linux-fork.c (class scoped_switch_fork_info): New class.
9947         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9948
9949 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9950
9951         * valops.c (find_overload_match): Remove use of null_cleanup, and
9952         calls to do_cleanups.
9953
9954 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9955
9956         * compile/compile-cplus-types.c
9957         (compile_cplus_instance::decl_name): Handle changes to
9958         cp_func_name.
9959         * cp-support.c (cp_func_name): Update header comment, update
9960         return type.
9961         * cp-support.h (cp_func_name): Update return type in declaration.
9962         * valops.c (find_overload_match): Move temp_func local to top
9963         level of function and change its type.  Use temp_func to hold and
9964         delete temporary string obtained from cp_func_name.
9965
9966 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9967
9968         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9969         gdb::char_vector, remove cleanup, and update uses of `msg`.
9970
9971 2019-01-03  Jim Wilson  <jimw@sifive.com>
9972
9973         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9974
9975 2019-01-02  Tom Tromey  <tom@tromey.com>
9976
9977         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9978         (tdesc_parse_xml): Remove cleanups.
9979         * target-descriptions.h (make_cleanup_free_target_description):
9980         Don't declare.
9981         (target_desc_deleter): New struct.
9982         (target_desc_up): New typedef.
9983         * target-descriptions.c (target_desc_deleter::operator()): Rename
9984         from free_target_description.
9985         (make_cleanup_free_target_description): Remove.
9986
9987 2019-01-02  Tom Tromey  <tom@tromey.com>
9988
9989         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9990         constructor, destructor.
9991         (linespec_parser): Remove typedef.
9992         (~linespec_parser): Rename from linespec_parser_delete.
9993         (linespec_lex_to_end, linespec_complete_label)
9994         (linespec_complete): Update.
9995         (decode_line_full): Remove cleanups.
9996         (decode_line_1): Update.
9997
9998 2019-01-02  Tom Tromey  <tom@tromey.com>
9999
10000         * python/python-internal.h (inferior_to_inferior_object): Change
10001         return type.
10002         * python/py-exitedevent.c (create_exited_event_object): Update.
10003         * python/py-inferior.c (inferior_to_inferior_object): Return
10004         gdbpy_ref.
10005         (python_new_inferior, python_inferior_deleted)
10006         (thread_to_thread_object, delete_thread_object)
10007         (build_inferior_list, gdbpy_selected_inferior): Update.
10008         * python/py-infthread.c (create_thread_object): Update.  Also fail
10009         if inferior_to_inferior_object fails.
10010
10011 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10012
10013         * inferior.h (class inferior) <displaced_step_state>: New field.
10014         * infrun.h (struct displaced_step_state): Move here from
10015         infrun.c.  Initialize fields, add constructor.
10016         <inf>: Remove field.
10017         <reset>: New method.
10018         * infrun.c (struct displaced_step_inferior_state): Move to
10019         infrun.h.
10020         (displaced_step_inferior_states): Remove.
10021         (get_displaced_stepping_state): Adust.
10022         (displaced_step_in_progress_any_inferior): Adjust.
10023         (displaced_step_in_progress_thread): Adjust.
10024         (displaced_step_in_progress): Adjust.
10025         (add_displaced_stepping_state): Remove.
10026         (get_displaced_step_closure_by_addr): Adjust.
10027         (remove_displaced_stepping_state): Remove.
10028         (infrun_inferior_exit): Call displaced_step_state.reset.
10029         (use_displaced_stepping): Don't check for NULL.
10030         (displaced_step_prepare_throw): Call
10031         get_displaced_stepping_state.
10032         (displaced_step_fixup): Don't check for NULL.
10033         (prepare_for_detach): Don't check for NULL.
10034
10035 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10036
10037         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10038          in case of call that did not complete.
10039
10040 2019-01-02  Andrey Utkin  <autkin@undo.io>
10041
10042         * symfile.c (find_separate_debug_file): Fix search of debug files for
10043         remote debuggee.
10044
10045 2019-01-02  Tom Tromey  <tom@tromey.com>
10046
10047         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10048         indentation.
10049         * python/py-frame.c (frapy_older): Remove cast.
10050         (frapy_newer): Likewise.
10051         * python/py-breakpoint.c (local_setattro): Remove cast.
10052         * python/py-arch.c (archpy_name): Remove local variable.
10053         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10054
10055 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10056
10057         * unittests/basic_string_view/element_access/char/empty.cc:
10058         Fix year range in copyright header.
10059
10060 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10061
10062         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10063         Delete.
10064         <operator==>: Update with for removed field.
10065         <hash>: Likewise.
10066         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10067         <isa_features>: ...this.
10068         <abi_features>: New field.
10069         (riscv_isa_flen): Update comment.
10070         (riscv_abi_xlen): New declaration.
10071         (riscv_abi_flen): New declaration.
10072         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10073         isa_features.
10074         (riscv_abi_xlen): New function.
10075         (riscv_isa_flen): Update to get answer from isa_features.
10076         (riscv_abi_flen): New function.
10077         (riscv_has_fp_abi): Update to get answer from abi_features.
10078         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10079         xlen and flen.
10080         (riscv_call_info) <xlen, flen>: Update comment.
10081         (riscv_call_arg_struct): Remove invalid assertions
10082         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10083         is removed.
10084         (riscv_gdbarch_init): Gather isa features and abi features
10085         separately, ensure both match on the gdbarch when reusing an old
10086         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10087         a target with 64-bit float hardware.
10088
10089 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10090
10091         * source.c (search_command_helper): Stop reverse search
10092         when line 1 has been searched.
10093
10094 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10095
10096         * record-full.c (record_full_base_target::close): Rewrite
10097         record_full_core_buf_list free logic.
10098
10099 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10100
10101         * break-catch-syscall.c (print_one_catch_syscall): xfree
10102         the last text.
10103
10104 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10105
10106         * top.c (print_gdb_version): Update Copyright year in version
10107         message.
10108
10109 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10110
10111         Update copyright year range in all GDB files.
10112
10113 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10114
10115         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10116
10117 For older changes see ChangeLog-2018.
10118 \f
10119 Local Variables:
10120 mode: change-log
10121 left-margin: 8
10122 fill-column: 74
10123 version-control: never
10124 coding: utf-8
10125 End:
10126