gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
   4         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
   5
   6 2019-07-17  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-windata.h (tui_display_all_data): Don't declare.
   9         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
  10         from tui_display_all_data.
  11         * tui/tui-win.c
  12         (tui_data_window::do_make_visible_with_new_height): Update.
  13         * tui/tui-regs.c (tui_show_registers): Update.
  14         * tui/tui-layout.c (tui_set_layout): Update.
  15         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
  16         method.
  17
  18 2019-07-17  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-windata.h (tui_display_data_from): Don't declare.
  21         * tui/tui-windata.c (tui_display_data_from): Remove.
  22         (tui_data_window::refresh_all): Update.
  23
  24 2019-07-17  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
  27         * tui/tui-windata.c (tui_display_data_from_line): Remove.
  28         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
  29         tui_display_registers_from_line.
  30         * tui/tui-regs.h (tui_display_registers_from_line): Update.
  31         * tui/tui-regs.c (tui_display_registers_from_line): Remove
  32         "force_display" parameter.
  33
  34 2019-07-17  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
  37         declare.
  38         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
  39         Rename from tui_first_reg_element_no_inline.
  40         (tui_display_reg_element_at_line)
  41         (tui_display_registers_from_line): Update.
  42         * tui/tui-data.h (struct tui_data_window)
  43         <first_reg_element_no_inline>: New method.
  44
  45 2019-07-17  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-windata.c (tui_display_data_from)
  48         (tui_data_window::do_scroll_vertical): Update.
  49         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
  50         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
  51         Rename from tui_line_from_reg_element_no.
  52         (tui_display_registers_from_line): Update.
  53         * tui/tui-data.h (struct tui_data_window)
  54         <line_from_reg_element_no>: New method.
  55
  56 2019-07-17  Tom Tromey  <tom@tromey.com>
  57
  58         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
  59         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
  60         tui_last_regs_line_no.
  61         (tui_display_reg_element_at_line)
  62         (tui_display_registers_from_line): Update.
  63         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
  64         method.
  65
  66 2019-07-17  Tom Tromey  <tom@tromey.com>
  67
  68         PR tui/24722:
  69         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
  70         (tui_update_breakpoint_info): Add "being_deleted" parameter.
  71         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  72         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
  73         (tui_update_breakpoint_info): Likewise.
  74         * tui/tui-hooks.c (tui_event_create_breakpoint)
  75         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
  76         Update.
  77
  78 2019-07-17  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
  81
  82 2019-07-17  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-winsource.c (tui_update_source_window_as_is)
  85         (tui_update_source_windows_with_addr): Update.
  86         * tui/tui-source.h (tui_set_source_content)
  87         (tui_show_symtab_source): Add "win_info" parameter.
  88         * tui/tui-source.c (tui_set_source_content): Add "win_info"
  89         parameter.
  90         (tui_show_symtab_source): Likewise.
  91
  92 2019-07-17  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-wingeneral.c
  95         (tui_check_and_display_highlight_if_needed): Check can_highlight.
  96
  97 2019-07-17  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 100         (struct tui_cmd_window) <can_scroll>: New method.
 101         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 102         method.
 103
 104 2019-07-17  Tom Tromey  <tromey@adacore.com>
 105
 106         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 107         do_field_signed>: Rename.  Change type of "value".
 108         * ui-out.c (ui_out::field_signed): Rename from field_int.
 109         Change type of "value".
 110         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 111         type of "value".
 112         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 113         do_field_int.  Change type of "value".
 114         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 115         do_field_int.  Change type of "value".
 116         * tracepoint.c (trace_status_mi, tfind_1)
 117         (print_one_static_tracepoint_marker): Update.
 118         * thread.c (print_thread_info_1, print_selected_thread_frame):
 119         Update.
 120         * stack.c (print_frame, print_frame_info): Update.
 121         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 122         Update.
 123         * source.c (print_source_lines_base): Update.
 124         * skip.c (info_skip_command): Update.
 125         * record-btrace.c (btrace_ui_out_decode_error)
 126         (btrace_call_history_src_line): Update.
 127         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 128         Update.
 129         * progspace.c (print_program_space): Update.
 130         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 131         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 132         do_field_int.  Change type of "value".
 133         * mi/mi-out.c (mi_ui_out::do_table_begin)
 134         (mi_ui_out::do_table_header): Update.
 135         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 136         type of "value".
 137         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 138         (mi_cmd_data_list_changed_registers, output_register)
 139         (mi_cmd_data_read_memory, mi_load_progress)
 140         (mi_cmd_trace_frame_collected): Update.
 141         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 142         Update.
 143         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 144         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 145         (mi_cmd_var_list_children, varobj_update_one): Update.
 146         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 147         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 149         * inferior.c (print_inferior): Update.
 150         * gdb_bfd.c (print_one_bfd): Update.
 151         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 152         Update.
 153         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 154         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 155         do_field_int.  Change type of "value".
 156         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 157         do_field_int.  Change type of "value".
 158         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 159         (print_one_breakpoint_location, print_it_catch_fork)
 160         (print_one_catch_fork, print_it_catch_vfork)
 161         (print_one_catch_vfork, print_it_catch_solib)
 162         (print_it_catch_exec, print_it_ranged_breakpoint)
 163         (print_mention_watchpoint, print_mention_masked_watchpoint)
 164         (bkpt_print_it, update_static_tracepoint): Update.
 165         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 166         * break-catch-syscall.c (print_it_catch_syscall): Update.
 167         * ada-tasks.c (print_ada_task_info): Update.
 168         * ada-lang.c (print_it_exception, print_mention_exception):
 169         Update.
 170
 171 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 172
 173         PR breakpoints/24541
 174         * gdbarch.c: Regenerate.
 175         * gdbarch.h: Regenerate.
 176         * gdbarch.sh: Adjust return type and parameter types for
 177         'stap_adjust_register'.
 178         (i386_stap_adjust_register): Adjust signature and return new
 179         register name.
 180         * stap-probe.c (stap_parse_register_operand): Adjust use of
 181         'gdbarch_stap_adjust_register'.
 182
 183 2019-07-17  Tom Tromey  <tromey@adacore.com>
 184
 185         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 186         declare VEC.
 187         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 188         std::vector.
 189         (struct s390_process_info): Add initializers.
 190         (s390_add_process): Use new.
 191         (s390_linux_nat_target::low_forget_process): Use delete.
 192         (s390_linux_nat_target::low_new_fork)
 193         (s390_linux_nat_target::stopped_by_watchpoint)
 194         (s390_linux_nat_target::low_prepare_to_resume)
 195         (s390_linux_nat_target::insert_watchpoint)
 196         (s390_linux_nat_target::insert_hw_breakpoint)
 197         (s390_linux_nat_target::remove_watchpoint)
 198         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 199
 200 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 201
 202         * aarch64-fbsd-nat.c: Include regcache.h.
 203         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 204         argument.
 205         (aarch64_fbsd_nat_target::fetch_registers)
 206         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 207         variable.
 208         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 209
 210 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 211
 212         * fbsd-nat.c: Include gdbarch.h.
 213
 214 2019-07-15  Tom Tromey  <tromey@adacore.com>
 215
 216         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 217
 218 2019-07-15  Tom Tromey  <tromey@adacore.com>
 219
 220         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 221         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 222         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 223         * cli-out.c (cli_ui_out::do_field_int): New method.
 224         * ui-out.c (ui_out::field_unsigned): New method.
 225         * symfile.c (generic_load): Use field_unsigned.
 226         (print_transfer_performance): Likewise.
 227         * record-btrace.c (ui_out_field_uint): Remove.
 228         (btrace_call_history_insn_range, btrace_call_history): Use
 229         field_unsigned.
 230         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 231         field_unsigned.
 232         * ui-out.h (class ui_out) <field_unsigned>: New method.
 233         <do_field_unsigned>: Likewise.
 234
 235 2019-07-15  Tom Tromey  <tromey@adacore.com>
 236
 237         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 238         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 239         * target.c (flash_erase_command): Use field_string.
 240         * infrun.c (print_signal_received_reason): Use field_string.
 241         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 242         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 243         field_string.
 244         * ada-tasks.c (print_ada_task_info): Use field_string.
 245
 246 2019-07-15  Tom Tromey  <tromey@adacore.com>
 247
 248         * target.c (flash_erase_command): Use field_core_addr.
 249         * symfile.c (generic_load): Use field_core_addr.
 250         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 251         Use field_core_addr.
 252         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 253         field_core_addr.
 254
 255 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 256
 257         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 258         value if its desired type is smaller than a CORE_ADDR and signed.
 259
 260 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 261
 262         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 263         of changes to field names, and use new is_reference field to
 264         decide if a property is a reference or not.
 265         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 266         field.
 267         (struct dwarf2_property_baton): Update header comment, rename
 268         'referenced_type' to 'property_type' and update comments.
 269         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 270         default property type, store in property baton, update to take
 271         accound of renamed field.
 272         (read_func_scope): Update call to attr_to_dynamic_prop.
 273         (read_array_type): Likewise.
 274         (dwarf2_per_cu_addr_sized_int_type): New function.
 275         (read_subrange_index_type): Move type finding code to
 276         dwarf2_per_cu_addr_sized_int_type.
 277         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 278         (dwarf2_per_cu_addr_type): New function.
 279         (set_die_type): Update calls to attr_to_dynamic_prop.
 280
 281 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 282
 283         * dwarf2read.c (read_subrange_index_type): New function.
 284         (read_subrange_type): Move code into new function and call it.
 285         * gdbtypes.c (create_range_type): Add some asserts.
 286
 287 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 288
 289         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 290         update return statements.
 291         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 292         declaration, and update comment to match.
 293         * gdbtypes.c (resolve_dynamic_array): Update call to
 294         dwarf2_evaluate_property to match new return type.
 295
 296 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 297
 298         * valarith.c (value_subscripted_rvalue): Change lowerbound
 299         parameter type from int to LONGEST.
 300         * value.h (value_subscripted_rvalue): Likewise in declaration.
 301
 302 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 303
 304         * cli/cli-utils.c (info_print_command_completer): New function.
 305         * cli/cli-utils.h: Add 'completer.h' include, and forward
 306         declaration for 'struct cmd_list_element'.
 307         (info_print_command_completer): Declare.
 308         * stack.c (_initialize_stack): Add completer for 'info locals' and
 309         'info args'.
 310         * symtab.c (_initialize_symtab): Add completer for 'info
 311         variables' and 'info functions'.
 312         * NEWS: Mention completion for additional info commands.
 313
 314 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 315
 316         * cli/cli-utils.c (extract_info_print_args): Delete.
 317         (extract_arg_maybe_quoted): Delete.
 318         (info_print_options_defs): New variable.
 319         (make_info_print_options_def_group): New function.
 320         (extract_info_print_options): Define new function.
 321         * cli/cli-utils.h (extract_info_print_args): Delete.
 322         (struct info_print_options): New structure.
 323         (extract_info_print_options): Declare new function.
 324         * stack.c (info_locals_command): Update to use new
 325         extract_info_print_options, also add a header comment.
 326         (info_args_command): Likewise.
 327         * symtab.c (info_variables_command): Likewise.
 328         (info_functions_command): Likewise.
 329
 330 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 331
 332         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 333         to extract string arguments.
 334         * common/common-utils.c (extract_string_maybe_quoted): New function.
 335         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 336
 337 2019-07-11  Tom Tromey  <tromey@adacore.com>
 338
 339         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 340         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 341         * top.h (gdbinit): Don't declare.
 342         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 343         into...
 344         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 345         * top.c (gdb_init): Don't call init_cli_cmds.
 346         (gdbinit): Remove.
 347         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 348
 349 2019-07-11  Tom Tromey  <tromey@adacore.com>
 350
 351         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 352         after it has been moved.
 353
 354 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 355
 356         * valops.c (value_must_coerce_to_target): Change return type to
 357         bool.
 358         * value.h (value_must_coerce_to_target): Likewise.
 359
 360 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 361
 362         * breakpoint.c (is_hardware_watchpoint): Remove
 363         forward-declaration.
 364         (is_masked_watchpoint): Change return type to bool.
 365         (is_tracepoint): Likewise.
 366         (is_breakpoint): Likewise.
 367         (is_hardware_watchpoint): Likewise.
 368         (is_watchpoint): Likewise.
 369         (is_no_memory_software_watchpoint): Likewise.
 370         (is_catchpoint): Likewise.
 371         (breakpoint_1): Make FILTER parameter's return type bool.
 372         is_masked_watchpoint): Change return type to bool.
 373         (save_breakpoints): Make FILTER parameter's return type bool.
 374         * breakpoint.h (is_breakpoint): Change return type to bool.
 375         (is_watchpoint): Likewise.
 376         (is_catchpoint): Likewise.
 377         (is_tracepoint): Likewise.
 378
 379 2019-07-10  Tom Tromey  <tom@tromey.com>
 380
 381         * defs.h: Don't include gdbarch.h.
 382         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 383         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 384         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 385         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 386         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 387         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 388         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 389         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 390         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 391         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 392         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 393         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 394         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 395         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 396         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 397         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 398         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 399         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 400         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 401         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 402         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 403         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 404         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 405         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 406         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 407         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 408         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 409
 410 2019-07-10  Tom Tromey  <tromey@adacore.com>
 411
 412         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 413         * breakpoint.c (init_ada_exception_breakpoint): Register as
 414         bp_catchpoint.
 415         (print_one_breakpoint_location, print_one_breakpoint): Use
 416         is_ada_exception_catchpoint.
 417         * ada-lang.c (class ada_catchpoint_location): Pass
 418         bp_loc_software_breakpoint to bp_location constructor.
 419         (is_ada_exception_catchpoint): New function.
 420
 421 2019-07-10  Tom Tromey  <tromey@adacore.com>
 422
 423         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 424         VEC.
 425         (struct arm_exidx_entry): New method operator<.
 426         (struct arm_exidx_data) <section_maps>: Change type.
 427         (arm_exidx_data_free): Remove.
 428         (arm_exidx_data_key): Change type.  Move lower.
 429         (arm_exidx_new_objfile): Update.
 430         (arm_compare_exidx_entries): Remove.
 431         (arm_find_exidx_entry, _initialize_arm_tdep)
 432
 433 2019-07-10  Tom Tromey  <tromey@adacore.com>
 434
 435         * solib-spu.c (ocl_program_data_key): Change type.
 436         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 437         Update.
 438
 439 2019-07-10  Tom Tromey  <tromey@adacore.com>
 440
 441         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 442         (struct solib_aix_inferior_data) <library_list>: Change type.
 443         (solib_aix_inferior_data_handle): Change type.
 444         (get_solib_aix_inferior_data): Update.
 445         (solib_aix_free_library_list): Remove.
 446         (library_list_start_library): Update.
 447         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 448         return type.
 449         (solib_aix_get_library_list)
 450         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 451         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 452
 453 2019-07-10  Tom Tromey  <tromey@adacore.com>
 454
 455         * solib-dsbt.c (struct dsbt_info): Add initializers.
 456         (solib_dsbt_pspace_data): Change type.
 457         (dsbt_pspace_data_cleanup): Remove.
 458         (get_dsbt_info, _initialize_dsbt_solib): Update.
 459
 460 2019-07-10  Tom Tromey  <tromey@adacore.com>
 461
 462         * spu-tdep.c (spu_overlay_data): Change type.
 463         (spu_get_overlay_table, spu_overlay_new_objfile)
 464         (_initialize_spu_tdep): Update.
 465
 466 2019-07-10  Tom Tromey  <tromey@adacore.com>
 467
 468         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 469         destructor.
 470         (dbx_objfile_data_key): Change type and declare later.
 471         (DBX_SYMFILE_INFO): Rewrite.
 472         * dbxread.c (dbx_objfile_data_key): Change type.
 473         (dbx_symfile_init): Update.
 474         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 475         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 476         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 477
 478 2019-07-10  Tom Tromey  <tromey@adacore.com>
 479
 480         * jit.c (jit_program_space_key): Change type.  Move lower.
 481         (get_jit_program_space_data): Update.
 482         (jit_program_space_data_cleanup): Remove.
 483         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 484         Update.
 485         (struct jit_program_space_data): Add initializers.
 486
 487 2019-07-10  Tom Tromey  <tromey@adacore.com>
 488
 489         * solib-darwin.c (struct darwin_info): Add initializers.
 490         (solib_darwin_pspace_data): Change type.
 491         (darwin_pspace_data_cleanup): Remove.
 492         (get_darwin_info, _initialize_darwin_solib): Update.
 493
 494 2019-07-10  Tom Tromey  <tromey@adacore.com>
 495
 496         * remote-sim.c (struct sim_inferior_data): Add initializers,
 497         constructor, and destructor.
 498         (sim_inferior_data_key): Change type.  Move lower.
 499         (check_for_duplicate_sim_descriptor): Update.
 500         (get_sim_inferior_data): Use new.  Update.
 501         (~sim_inferior_data_cleanup): Rename from
 502         sim_inferior_data_cleanup.  Simplify.
 503         (gdbsim_close_inferior, simulator_command)
 504         (sim_command_completer, _initialize_remote_sim): Update.
 505         (next_pid, INITIAL_PID): Move earlier.
 506
 507 2019-07-10  Tom Tromey  <tromey@adacore.com>
 508
 509         * python/python-internal.h (create_thread_object): Return
 510         gdbpy_ref.
 511         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 512         * python/py-inferior.c (struct threadlist_entry): Add
 513         constructor.
 514         <thread_obj>: Now a gdbpy_ref.
 515         (thread_to_thread_object): Update.
 516         (add_thread_object): Use new.
 517         (delete_thread_object): Use delete.
 518         (infpy_threads): Update.
 519         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 520         GIL.
 521
 522 2019-07-10  Tom Tromey  <tromey@adacore.com>
 523
 524         * valops.c (value_cast): Specialize error message for Ada.
 525
 526 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 527
 528         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 529
 530 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 531
 532         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 533         bpstat_should_step): Return bool, adjust comments.
 534         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 535         bpstat_should_step): Likewise.
 536
 537 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 538
 539         * features/Makefile: Use feature target descriptions for Arm.
 540         * features/arm/arm-core.c: Generate new file.
 541         * features/arm/arm-fpa.c: Likewise.
 542         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 543         * features/arm/arm-m-profile.c: Likewise.
 544         * features/arm/arm-vfpv2.c: Likewise.
 545         * features/arm/arm-vfpv3.c: Likewise.
 546         * features/arm/xscale-iwmmxt.c: Likewise.
 547         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 548
 549 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 550
 551         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 552         ptrace earlier.
 553
 554 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 555
 556         * features/aarch64-pauth.c: Regenerate.
 557
 558 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 559
 560         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 561         bool.
 562         (bpstat_what): Use false instead of 0.
 563
 564 2019-07-09  Pedro Alves  <palves@redhat.com>
 565
 566         * break-catch-throw.c (is_exception_catchpoint): New.
 567         * breakpoint.c (print_one_breakpoint_location): New parameter
 568         'raw_loc'.  Handle it.  Use
 569         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 570         looking at the breakpoint's type.
 571         (print_one_breakpoint): If handling "maint info breakpoints", also
 572         print locations of exception catchpoints.
 573         * breakpoint.h (is_exception_catchpoint): Declare.
 574
 575 2019-07-09  Pedro Alves  <palves@redhat.com>
 576
 577         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 578         "addr" field.
 579         (allocate_location_exception_catchpoint): New.
 580         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 581         (initialize_throw_catchpoint_ops): Install
 582         allocate_location_exception_catchpoint as allocate_location
 583         method.
 584         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 585         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 586         bp_loc_other.
 587         (breakpoint_address_is_meaningful): Delete.
 588         (bl_address_is_meaningful): New.
 589         (breakpoint_locations_match): Adjust comment.
 590         (bp_location_from_bp_type): New, factored out of...
 591         (bp_location::bp_location(breakpoint *)): ... this.
 592         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 593         factored out of...
 594         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 595         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 596         breakpoint_address_is_meaningful.
 597         (bp_locations_compare): Adjust comment.
 598         (update_global_location_list): Use bl_address_is_meaningful
 599         instead of breakpoint_address_is_meaningful.
 600         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 601         explicit.
 602         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 603         * python/py-breakpoint.c (bppy_get_location): No longer check
 604         whether location is null.
 605
 606 2019-07-09  Pedro Alves  <palves@redhat.com>
 607
 608         PR c++/15468
 609         * breakpoint.c (print_one_breakpoint_location): Remove
 610         single-location assert.
 611
 612 2019-07-09  Tom Tromey  <tom@tromey.com>
 613
 614         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 615         * configure: Rebuild.
 616         * configure.ac: Change common to gdbsupport.
 617         * gdbsupport: Rename from common.
 618         * acinclude.m4: Change common to gdbsupport.
 619         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 620         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 621         gdbsupport.
 622         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 623         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 624         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 625         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 626         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 627         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 628         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 629         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 630         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 631         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 632         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 633         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 634         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 635         coff-pe-read.c, command.h, compile/compile-c-support.c,
 636         compile/compile-c.h, compile/compile-cplus-symbols.c,
 637         compile/compile-cplus-types.c, compile/compile-cplus.h,
 638         compile/compile-loc2c.c, compile/compile.c, completer.c,
 639         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 640         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 641         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 642         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 643         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 644         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 645         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 646         features/aarch64-core.c, features/aarch64-fpu.c,
 647         features/aarch64-pauth.c, features/aarch64-sve.c,
 648         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 649         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 650         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 651         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 652         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 653         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 654         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 655         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 656         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 657         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 658         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 659         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 660         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 661         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 662         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 663         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 664         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 665         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 666         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 667         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 668         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 669         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 670         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 671         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 672         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 673         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 674         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 675         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 676         minsyms.c, mips-linux-tdep.c, namespace.h,
 677         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 678         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 679         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 680         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 681         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 682         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 683         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 684         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 685         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 686         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 687         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 688         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 689         procfs.c, producer.c, progspace.h, psymtab.h,
 690         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 691         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 692         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 693         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 694         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 695         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 696         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 697         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 698         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 699         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 700         target-memory.c, target.c, target.h, target/waitstatus.c,
 701         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 702         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 703         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 704         unittests/array-view-selftests.c,
 705         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 706         unittests/common-utils-selftests.c,
 707         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 708         unittests/format_pieces-selftests.c,
 709         unittests/function-view-selftests.c,
 710         unittests/lookup_name_info-selftests.c,
 711         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 712         unittests/mkdir-recursive-selftests.c,
 713         unittests/observable-selftests.c,
 714         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 715         unittests/parse-connection-spec-selftests.c,
 716         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 717         unittests/scoped_fd-selftests.c,
 718         unittests/scoped_mmap-selftests.c,
 719         unittests/scoped_restore-selftests.c,
 720         unittests/string_view-selftests.c, unittests/style-selftests.c,
 721         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 722         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 723         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 724         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 725         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 726         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 727
 728 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 729
 730         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 731         bool value.
 732         (decode_digits_ordinary): Set explicit_line field in sal.
 733         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 734         symtab_and_line that was set on an explicit line number in
 735         assembler code.  Do always update the recorded symtab and line if
 736         we do skip the prologue.
 737
 738 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 739
 740         * breakpoint.c (set_breakpoint_location_function): Remove
 741         explicit_loc parameter.
 742         (momentary_breakpoint_from_master): Update call to
 743         set_breakpoint_location_function.
 744         (add_location_to_breakpoint): Likewise.
 745
 746 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 747
 748         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 749         required features based on default bfd type when no specific bfd
 750         is present.
 751
 752 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 753
 754         * NEWS: Mention that GDB printf and eval commands can now print
 755         C-style and Ada-style convenience var strings without
 756         calling the inferior.
 757         * printcmd.c (printf_c_string): Locally print GDB internal var
 758         instead of transiting via the inferior.
 759         (printf_wide_c_string): Likewise.
 760
 761 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 762
 763         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 764
 765 2019-07-04  Tom Tromey  <tom@tromey.com>
 766
 767         PR tui/24724:
 768         * tui/tui-winsource.c (tui_clear_source_content): Update.
 769         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 770         (tui_update_breakpoint_info): Update.
 771         (tui_set_exec_info_content): Update.
 772         * tui/tui-source.c (tui_set_source_content_nil): Update.
 773         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 774         has_break.
 775         * tui/tui-data.h (enum tui_bp_flag): New.
 776         (tui_bp_flags): New enum flags type.
 777         (struct tui_source_element) <break_mode>: Change type.  Rename
 778         from has_break.
 779         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 780         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 781         constants.
 782         * tui/tui-winsource.h: Fix comment.
 783
 784 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 785
 786         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 787         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 788         (store_fpregs_to_thread)
 789         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 790         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 791         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 792         (IWMMXT_REGS_SIZE): Add define.
 793         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 794         (fetch_vfp_regs, store_vfp_regs)
 795         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 796         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 797
 798 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 799
 800         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 801         defines.
 802         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 803         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 804         (ARM_INT_REGISTER_SIZE): ...to this.
 805         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 806         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 807         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 808         (arm_linux_collect_gregset, supply_nwfpe_register)
 809         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 810         defines.
 811         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 812         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 813         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 814         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 815         (arm_return_in_memory, arm_store_return_value)
 816         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 817         (arm_record_ld_st_multiple): Likewise.
 818         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 819         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 820
 821 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 822
 823         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 824         AARCH64_DISPLACED_MODIFIED_INSNS.
 825         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 826         (aarch64_displaced_step_copy_insn): Likewise.
 827         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 828         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 829         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 830         ARM_DISPLACED_MODIFIED_INSNS.
 831         * arm-tdep.c (arm_gdbarch_init): Likewise.
 832         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 833         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 834         (struct arm_displaced_step_closure): Use
 835         ARM_DISPLACED_MODIFIED_INSNS.
 836
 837 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 838
 839         * features/Makefile: Remove unused xml files.
 840         * features/aarch64.xml: Remove.
 841         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 842         * features/i386/amd64-avx-avx512.xml: Remove.
 843         * features/i386/amd64-avx-linux.xml: Remove.
 844         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 845         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 846         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 847         * features/i386/amd64-avx-mpx.xml: Remove.
 848         * features/i386/amd64-avx.xml: Remove.
 849         * features/i386/amd64-linux.xml: Remove.
 850         * features/i386/amd64-mpx-linux.xml: Remove.
 851         * features/i386/amd64-mpx.xml: Remove.
 852         * features/i386/amd64.xml: Remove.
 853         * features/i386/i386-avx-avx512-linux.xml: Remove.
 854         * features/i386/i386-avx-avx512.xml: Remove.
 855         * features/i386/i386-avx-linux.xml: Remove.
 856         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 857         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 858         * features/i386/i386-avx-mpx-linux.xml: Remove.
 859         * features/i386/i386-avx-mpx.xml: Remove.
 860         * features/i386/i386-avx.xml: Remove.
 861         * features/i386/i386-linux.xml: Remove.
 862         * features/i386/i386-mmx-linux.xml: Remove.
 863         * features/i386/i386-mmx.xml: Remove.
 864         * features/i386/i386-mpx-linux.xml: Remove.
 865         * features/i386/i386-mpx.xml: Remove.
 866         * features/i386/i386.xml: Remove.
 867         * features/i386/x32-avx-avx512-linux.xml: Remove.
 868         * features/i386/x32-avx-linux.xml: Remove.
 869         * features/i386/x32-linux.xml: Remove.
 870
 871 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 872
 873         * regformats/aarch64.dat: Remove.
 874         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 875         * regformats/i386/amd64-avx-linux.dat: Remove.
 876         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 877         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 878         * regformats/i386/amd64-linux.dat: Remove.
 879         * regformats/i386/amd64-mpx-linux.dat: Remove.
 880         * regformats/i386/amd64.dat: Remove.
 881         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 882         * regformats/i386/i386-avx-linux.dat: Remove.
 883         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 884         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 885         * regformats/i386/i386-linux.dat: Remove.
 886         * regformats/i386/i386-mmx-linux.dat: Remove.
 887         * regformats/i386/i386-mpx-linux.dat: Remove.
 888         * regformats/i386/i386.dat: Remove.
 889         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 890         * regformats/i386/x32-avx-linux.dat: Remove.
 891         * regformats/i386/x32-linux.dat: Remove.
 892
 893 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 894
 895         * aarch64-tdep.c: Remove xml self tests.
 896         * amd64-linux-tdep.c: Likewise.
 897         * amd64-tdep.c: Likewise.
 898         * i386-linux-tdep.c: Likewise.
 899         * i386-tdep.c: Likewise.
 900
 901 2019-07-03  Pedro Alves  <palves@redhat.com>
 902
 903         PR cli/24732
 904         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 905         (pipe_cmd_option_defs): New.
 906         (make_pipe_cmd_options_def_group): New.
 907         (pipe_command): Use gdb::option::process_options.
 908         (pipe_command_completer): New function.
 909         (_initialize_cli_cmds): Install completer for "pipe" command.
 910
 911 2019-07-03  Pedro Alves  <palves@redhat.com>
 912
 913         * cli/cli-option.c (union option_value) <string>: New field.
 914         (struct option_def_and_value): Add ctor, move ctor, dtor and
 915         use DISABLE_COPY_AND_ASSIGN.
 916         (option_def_and_value::clear_value): New.
 917         (parse_option, save_option_value_in_ctx, get_val_type_str)
 918         (add_setshow_cmds_for_options): Handle var_string.
 919         * cli-option.h (union option_def::var_address) <string>: New
 920         field.
 921         (struct string_option_def): New.
 922         * maint-test-options.c (struct test_options_opts): Add default
 923         ctor and use DISABLE_COPY_AND_ASSIGN.
 924         <string_opt>: New field.
 925         (test_options_opts::~test_options_opts): New.
 926         (test_options_opts::dump): Also dump "-string".
 927         (test_options_option_defs): Install "string.
 928
 929 2019-07-03  Pedro Alves  <palves@redhat.com>
 930
 931         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 932         option_value with a null enumeration.
 933         (complete_options): Save the option values in the context.
 934         (save_option_value_in_ctx): New, factored out from ...
 935         (process_options): ... here.
 936         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 937         of the function.
 938         * maint-test-options.c (test_options_opts::dump): New, factored
 939         out from ...
 940         (maintenance_test_options_command_mode): ... here.
 941         (maintenance_test_options_command_completion_result): Delete.
 942         (maintenance_test_options_command_completion_text): Update
 943         comment.
 944         (maintenance_show_test_options_completion_result): Change
 945         prototype.  Just print
 946         maintenance_test_options_command_completion_text.
 947         (save_completion_result): New.
 948         (maintenance_test_options_completer_mode): Pass options context to
 949         complete_options, and then save a dump.
 950         (_initialize_maint_test_options): Use add_cmd to install "maint
 951         show test-options-completion-result".
 952
 953 2019-07-03  Pedro Alves  <palves@redhat.com>
 954
 955         * NEWS (New commands): Mention "with" and "maint with".
 956         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 957         (with_command, with_command_completer): New.
 958         (pipe_command): Adjust to new repeat_previous
 959         interface.
 960         (_initialize_cli_cmds): Install the "with" command and its "w"
 961         alias.
 962         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 963         declarations.
 964         * cli/cli-setshow.c (parse_cli_var_uinteger)
 965         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 966         argument strings for all var_types.
 967         (get_setshow_command_value_string): New, factored out from ...
 968         (do_show_command): ... this.
 969         * cli/cli-setshow.h: Include <string>.
 970         (get_setshow_command_value_string): Declare.
 971         * command.h (repeat_previous): Now returns const char *.  Adjust
 972         comment.
 973         * maint.c: Include "cli/cli-cmds.h".
 974         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 975         (_initialize_maint_cmds): Register the "maintenance with" command.
 976         * top.c (repeat_previous): Move bits from pipe_command here:
 977         Return the saved command line, if any; error out if there's no
 978         command to relaunch.
 979
 980 2019-07-03  Pedro Alves  <palves@redhat.com>
 981
 982         * NEWS (New commands): Mention "maint set/show test-settings"
 983         instead of "maint test-settings".
 984         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 985         (maintenance_test_settings_set_list): Rename to ...
 986         (maintenance_set_test_settings_list): ... this.
 987         (maintenance_test_settings_show_list): Rename to  ...
 988         (maintenance_show_test_settings_list): ... this.
 989         (maintenance_test_settings_cmd): Delete.
 990         (maintenance_test_settings_set_cmd): ...
 991         (maintenance_set_test_settings_cmd): ... this.
 992         (maintenance_test_settings_show_cmd): ...
 993         (maintenance_show_test_settings_cmd): ... this.
 994         (maintenance_test_settings_show_value_cmd):
 995         (maintenance_show_test_settings_value_cmd): ... this.
 996         (_initialize_maint_test_settings): No longer install the "maint
 997         test-settings" prefix command.  Rename "maint test-settings set"
 998         to "maint set test-settings", and "maint test-settings show" to
 999         "maint show test-settings".  Adjust all subcommands.
1000
1001 2019-07-03  Pedro Alves  <palves@redhat.com>
1002
1003         * maint-test-settings.c: Fix file's intro comment.  Replace all
1004         references to "test-options" with references to "test-settings",
1005         in comments.
1006
1007 2019-07-03  Pedro Alves  <palves@redhat.com>
1008
1009         * maint-test-settings.c (maintenance_test_settings_xxx)
1010         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1011         New.
1012         (maintenance_test_settings_enums): Use them.
1013         (maintenance_test_settings_enum): Default to
1014         maintenance_test_settings_xxx.
1015         (_initialize_maint_test_settings): Initialize
1016         MAINTENANCE_TEST_SETTINGS_FILENAME.
1017
1018 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1019
1020         * breakpoint.h (remove_breakpoints_inf): Change return type to
1021         void, move function documentation here.
1022         * breakpoint.c (remove_breakpoints_inf): Change return type to
1023         void, move function documentation to header.
1024
1025 2019-07-02  Pedro Alves  <palves@redhat.com>
1026
1027         * NEWS (Completion improvements): Mention "info threads".
1028         * thread.c (struct info_threads_opts, info_threads_option_defs)
1029         (make_info_threads_options_def_group): New.
1030         (info_threads_command): Use gdb::option::process_options.
1031         (info_threads_command_completer): New.
1032         (_initialize_thread): Use gdb::option::build_help to build the
1033         help text for "info threads".
1034
1035 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1036
1037         * defs.h (generic_load): Move from here...
1038         * symfile.h (generic_load): ... to here.  Rename name parameter
1039         to args.
1040         * symfile.c (generic_load): Add comment.
1041
1042 2019-07-01  Tom Tromey  <tromey@adacore.com>
1043
1044         * dwarf2read.c
1045         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1046         declaration of without_params.  Fix formatting.
1047
1048 2019-07-01  Tom Tromey  <tromey@adacore.com>
1049
1050         * ada-exp.y (find_primitive_type): Update.
1051         * ada-lang.h (ada_lookup_symbol): Update.
1052         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1053         parameter.
1054         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1055
1056 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1057
1058         PR breakpoints/24541
1059         * gdbarch.c: Regenerate.
1060         * gdbarch.h: Regenerate.
1061         * gdbarch.sh: Add 'stap_adjust_register'.
1062         * i386-tdep.c: Include '<unordered_set>'.
1063         (i386_stap_adjust_register): New function.
1064         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1065         * stap-probe.c (stap_parse_register_operand): Call
1066         'gdbarch_stap_adjust_register'.
1067
1068 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1069
1070         PR python/24742
1071         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1072         * python/python.c (do_start_initialization): Use 'xmalloc'
1073         instead of 'PyMem_Malloc'.
1074
1075 2019-06-28  Tom Tromey  <tromey@adacore.com>
1076
1077         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1078         for Ada.
1079
1080 2019-06-27  Tom Tromey  <tromey@adacore.com>
1081
1082         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1083         objfile_key.
1084         (arm_find_mapping_symbol, arm_record_special_symbol)
1085         (_initialize_arm_tdep): Update.
1086         (arm_objfile_data_free): Remove.
1087
1088 2019-06-27  Tom Tromey  <tromey@adacore.com>
1089
1090         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1091         to cp_print_static_field.
1092
1093 2019-06-26  Tom Tromey  <tromey@adacore.com>
1094
1095         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1096         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1097         declare.
1098
1099 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1100
1101         * features/aarch64-core.c (create_feature_aarch64_core):
1102         Regenerate.
1103         * features/aarch64-core.xml: Add cpsr flags.
1104
1105 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1106
1107         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1108         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1109
1110 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1111
1112         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1113         field.
1114         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1115         use.
1116         (arm_record_special_symbol): Don't insert new symbol in sorted
1117         position, push it at the end.
1118
1119 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1120
1121         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1122         (arm_mapping_symbol_s): Remove.
1123         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1124         (arm_mapping_symbol_vec): New typedef.
1125         (struct arm_per_objfile): Add constructor.
1126         <section_maps>: Change type to
1127         std::unique_ptr<arm_mapping_symbol_vec[]>.
1128         (arm_compare_mapping_symbols): Remove.
1129         (arm_find_mapping_symbol): Adjust to section_maps type change.
1130         (arm_objfile_data_free): Call delete on arm_per_objfile.
1131         (arm_record_special_symbol): Adjust to section_maps type change.
1132         Allocate arm_per_objfile with new.
1133
1134 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1135
1136         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1137         with the command prefix.
1138
1139 2019-06-25  Tom Tromey  <tom@tromey.com>
1140
1141         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1142         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1143
1144 2019-06-25  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1147         type.
1148         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1149         protected.
1150
1151 2019-06-25  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-winsource.c
1154         (tui_source_window_base::set_is_exec_point_at): Add check against
1155         LOA_ADDRESS.
1156
1157 2019-06-25  Tom Tromey  <tom@tromey.com>
1158
1159         * tui/tui-source.c (tui_set_source_content): Don't check before
1160         xfree.
1161         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1162
1163 2019-06-25  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-winsource.h (tui_update_source_window_as_is)
1166         (tui_alloc_source_buffer, tui_line_is_displayed)
1167         (tui_addr_is_displayed): Change type of win_info.
1168         * tui/tui-winsource.c (tui_update_source_window_as_is)
1169         (tui_clear_source_content, tui_show_source_line)
1170         (tui_show_source_content, tui_source_window_base::refill)
1171         (tui_source_window_base::set_is_exec_point_at)
1172         (tui_source_window_base::set_is_exec_point_at)
1173         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1174         (tui_alloc_source_buffer, tui_line_is_displayed)
1175         (tui_addr_is_displayed): Change type of win_info.  Update.
1176         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1177         (tui_source_window_base::do_make_visible_with_new_height):
1178         Update.
1179         * tui/tui-source.c (tui_set_source_content)
1180         (tui_set_source_content_nil)
1181         (tui_source_window::do_scroll_vertical): Update.
1182         * tui/tui-layout.c (show_layout): Update.
1183         * tui/tui-disasm.c (tui_set_disassem_content)
1184         (tui_disasm_window::do_scroll_vertical): Update.
1185         * tui/tui-data.h (tui_win_content): Remove.
1186         (struct tui_gen_win_info) <content, content_size>: Remove.
1187         (struct tui_source_element): Add initializers and destructor.
1188         (union tui_which_element, struct tui_win_element): Remove.
1189         (struct tui_source_window_base) <content>: New field.
1190         (struct tui_data_window): Remove destructor.
1191         (tui_alloc_content, tui_free_win_content)
1192         (tui_free_all_source_wins_content): Don't declare.
1193         * tui/tui-data.c (tui_initialize_static_data): Update.
1194         (init_content_element, tui_alloc_content): Remove.
1195         (~tui_gen_win_info): Update.
1196         (~tui_data_window, tui_free_all_source_wins_content)
1197         (tui_free_win_content, free_content, free_content_elements):
1198         Remove.
1199
1200 2019-06-25  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-winsource.h (tui_clear_source_content)
1203         (tui_erase_source_content, tui_show_source_content): Change type
1204         of win_info.
1205         * tui/tui-winsource.c (tui_clear_source_content)
1206         (tui_erase_source_content, tui_show_source_content): Change type
1207         of win_info.
1208         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1209         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1210         win_info.
1211         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1212         win_info.
1213         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1214
1215 2019-06-25  Tom Tromey  <tom@tromey.com>
1216
1217         * tui/tui-winsource.c (tui_clear_source_content)
1218         (tui_source_window_base::set_is_exec_point_at): Update.
1219         * tui/tui-source.c (tui_set_source_content_nil): Update.
1220         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1221         a bool.
1222         * tui/tui-data.c (init_content_element): Update.
1223
1224 2019-06-25  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1227         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1228         * tui/tui-layout.c (init_and_make_win): Update.
1229         * tui/tui.h (enum tui_win_type): Update.
1230         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1231         tui_win_is_auxillary.
1232         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1233         tui_win_is_auxillary.
1234
1235 2019-06-25  Tom Tromey  <tom@tromey.com>
1236
1237         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1238         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1239         (tui_delete_data_content_windows, tui_display_all_data)
1240         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1241         Update.
1242         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1243         * tui/tui-regs.c (tui_last_regs_line_no)
1244         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1245         (tui_show_registers): Update.
1246         (tui_show_register_group): Return void.  Update.
1247         (tui_display_registers_from, tui_display_reg_element_at_line)
1248         (tui_display_registers_from_line, tui_check_register_values):
1249         Update.
1250         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1251         member.
1252         (struct tui_data_window) <regs_content>: Now a std::vector.
1253         <regs_content_count>: Remove.
1254         (tui_add_content_elements, tui_free_data_content): Don't declare.
1255         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1256         (init_content_element): Remove DATA_WIN case.  Add assert.
1257         (tui_add_content_elements): Remove.
1258         (tui_data_window): Update.
1259         (tui_free_data_content): Remove.
1260         (free_content_elements): Remove DATA_WIN case.
1261
1262 2019-06-25  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-data.c (tui_data_item_window): Update.
1265         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1266         * tui/tui-windata.c (tui_display_all_data)
1267         (tui_display_data_from_line): Update.
1268         (tui_check_data_values): Remove.
1269         * tui/tui-regs.c (tui_show_register_group)
1270         (tui_display_reg_element_at_line): Update.
1271         * tui/tui-hooks.c (tui_register_changed)
1272         (tui_refresh_frame_and_register_information): Call
1273         tui_check_register_values.
1274         * tui/tui-data.h (struct tui_data_window) <data_content,
1275         data_content_count, data_type>: Remove.
1276         (enum tui_data_type): Remove.
1277
1278         * tui/tui-data.c (tui_data_window::clear_detail)
1279         (~tui_data_window): Update.
1280
1281 2019-06-25  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1284         declare.
1285         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1286         Rename from tui_first_data_item_displayed.  Update.
1287         (tui_data_window::refresh_all)
1288         (tui_data_window::do_scroll_vertical): Update.
1289         * tui/tui-data.h (struct tui_data_window)
1290         <first_data_item_displayed>: Declare new method.
1291
1292 2019-06-25  Tom Tromey  <tom@tromey.com>
1293
1294         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1295         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1296         contents...
1297         (tui_initialize_static_data): ...here.
1298
1299 2019-06-25  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1302         (tui_display_registers_from, tui_check_register_values): Update.
1303         (tui_display_register): Remove win_info parameter; update.
1304         (tui_get_register): Change type of parameters.
1305         * tui/tui-data.h (struct tui_data_element): Remove.
1306         (union tui_which_element) <data>: Remove.
1307         <data_window>: Change type.
1308         (struct tui_data_item_window): New.
1309         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1310         case.  Add assert.
1311         (~tui_data_item_window): New destructor.
1312         (free_content_elements): Remove DATA_ITEM_WIN case.
1313
1314 2019-06-25  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1317         Remove.
1318
1319 2019-06-25  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui-data.h (struct tui_command_element): Remove.
1322         (union tui_which_element) <command>: Remove.
1323         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1324         assert.
1325         (free_content_elements): Remove CMD_WIN case.
1326
1327 2019-06-25  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-layout.c (tui_set_layout): Update.
1330         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1331         * tui/tui-data.c (layout_def): Update.
1332
1333 2019-06-25  Tom Tromey  <tom@tromey.com>
1334
1335         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1336         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1337         (tui_source_window_base::set_new_height): Update.
1338         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1339         Update.
1340         (tui_set_locator_fullname, tui_set_locator_info)
1341         (tui_show_frame_info): Update.
1342         * tui/tui-source.c (tui_set_source_content)
1343         (tui_source_is_displayed): Update.
1344         * tui/tui-layout.c (show_source_disasm_command, show_data)
1345         (show_source_or_disasm_and_command): Update.
1346         * tui/tui-disasm.c (tui_set_disassem_content)
1347         (tui_get_begin_asm_address): Update.
1348         * tui/tui-data.h (struct tui_locator_element): Remove.
1349         (union tui_which_element) <locator>: Remove.
1350         (struct tui_locator_window): New.
1351         (tui_locator_win_info_ptr): Change return type.
1352         * tui/tui-data.c (_locator): Change type.
1353         (tui_locator_win_info_ptr): Change return type.
1354         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1355         (tui_alloc_content): Add assert.
1356
1357 2019-06-25  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-winsource.c
1360         (tui_exec_info_window::maybe_allocate_content): New method.
1361         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1362         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1363         (make_source_or_disasm_window): Add cast.
1364         * tui/tui-data.h (union tui_which_element) <simple_string>:
1365         Remove.
1366         (struct tui_source_info): New.
1367         (struct tui_source_window_base) <execution_info>: Change type.
1368         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1369         case, and add assert.
1370         (tui_alloc_content): Add assert.
1371
1372 2019-06-25  Tom Tromey  <tom@tromey.com>
1373
1374         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1375         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1376         * tui/tui-data.c (tui_alloc_win_info): Remove.
1377
1378 2019-06-25  Tom Tromey  <tom@tromey.com>
1379
1380         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1381         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1382         can_highlight.
1383
1384 2019-06-25  Tom Tromey  <tom@tromey.com>
1385
1386         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1387         make_visible_with_new_height method.
1388         (tui_win_info::make_visible_with_new_height): New method.
1389         (tui_source_window_base::do_make_visible_with_new_height)
1390         (tui_data_window::do_make_visible_with_new_height)
1391         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1392         (make_visible_with_new_height): Remove.
1393         (tui_resize_all, tui_adjust_win_heights): Use
1394         make_visible_with_new_height method.
1395         * tui/tui-data.h (struct tui_win_info)
1396         <do_make_visible_with_new_height, make_visible_with_new_height>:
1397         New methods.
1398         (struct tui_source_window_base, struct tui_data_window)
1399         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1400         methods.
1401
1402 2019-06-25  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1405         method.
1406         (update_tab_width): Call update_tab_width method.
1407         * tui/tui-data.h (struct tui_win_info)
1408         (struct tui_source_window_base) <update_tab_width>: New methods.
1409
1410 2019-06-25  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1413         parameter.
1414         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1415         parameter.
1416         (tui_gen_win_info::make_visible): Update.
1417         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1418         parameter.
1419         * tui/tui-data.h (enum tui_box): New enum.
1420         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1425         init_and_make_win for EXEC_INFO_WIN.
1426         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1427         longer inline.
1428         (struct tui_win_info) <~tui_win_info>: Inline.
1429         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1430         Don't declare.
1431         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1432         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1433         Remove.
1434         (tui_initialize_static_data): Update.
1435         (~tui_gen_win_info): Handle more cleanup here.
1436         (~tui_source_window_base): Delete "execution_info".
1437         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1438
1439 2019-06-25  Tom Tromey  <tom@tromey.com>
1440
1441         * tui/tui-layout.c (make_command_window): Don't set
1442         can_highlight.
1443         (show_source_disasm_command): Call the reset method.
1444         (show_data): Don't set can_highlight.  Call the reset method.
1445         (tui_gen_win_info::reset): Rename from init_gen_win_info
1446         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1447         (show_source_or_disasm_and_command): Call the reset method.
1448         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1449         (struct tui_cmd_window): Set can_highlight.
1450
1451 2019-06-25  Tom Tromey  <tom@tromey.com>
1452
1453         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1454         from make_visible.
1455         (tui_make_visible, tui_make_invisible): Rewrite.
1456         (tui_win_info::make_visible): Remove.
1457         (tui_source_window_base::make_visible): Update.
1458         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1459         method.  Moved from...
1460         (struct tui_win_info) <make_visible>: ...here.
1461
1462 2019-06-25  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-winsource.c
1465         (tui_source_window_base::do_scroll_horizontal): Remove direction
1466         parameter.
1467         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1468         direction parameter.
1469         * tui/tui-win.c (tui_win_info::forward_scroll)
1470         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1471         (tui_win_info::right_scroll): Update.
1472         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1473         direction parameter.
1474         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1475         direction parameter.
1476         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1477         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1478         Remove direction parameter.
1479         (struct tui_source_window_base, struct tui_source_window)
1480         (struct tui_disasm_window, struct tui_data_window)
1481         (struct tui_cmd_window): Update.
1482
1483 2019-06-25  Tom Tromey  <tom@tromey.com>
1484
1485         * tui/tui-winsource.h (tui_set_exec_info_content)
1486         (tui_show_exec_info_content, tui_erase_exec_info_content)
1487         (tui_clear_exec_info_content, tui_update_exec_info): Change
1488         argument to tui_source_window_base.
1489         * tui/tui-winsource.c (tui_set_exec_info_content)
1490         (tui_show_exec_info_content, tui_erase_exec_info_content)
1491         (tui_clear_exec_info_content, tui_update_exec_info): Change
1492         argument to tui_source_window_base.
1493
1494 2019-06-25  Tom Tromey  <tom@tromey.com>
1495
1496         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1497         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1498
1499 2019-06-25  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1502         check.
1503
1504 2019-06-25  Tom Tromey  <tom@tromey.com>
1505
1506         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1507         type to void.
1508         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1509         type to void.
1510         * tui/tui-source.c (tui_set_source_content): Update.
1511         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1512
1513 2019-06-25  Tom Tromey  <tom@tromey.com>
1514
1515         * tui/tui-win.c (window_name_completer, tui_set_focus)
1516         (tui_all_windows_info): Use name method.
1517         * tui/tui-data.h (struct tui_gen_win_info)
1518         (struct tui_source_window, struct tui_disasm_window)
1519         (struct tui_data_window, struct tui_cmd_window) <name>: New
1520         method.
1521         (tui_win_name): Don't declare.
1522         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1523         (tui_win_name): Remove.
1524
1525 2019-06-25  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-winsource.h (tui_update_source_window)
1528         (tui_update_source_window_as_is): Change parameter type.
1529         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1530         to be a tui_source_window_base.
1531         (tui_update_source_window_as_is): Likewise.
1532         * tui/tui-win.c (make_visible_with_new_height): Update.
1533
1534 2019-06-25  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-winsource.c (tui_erase_source_content)
1537         (tui_show_source_content, tui_show_exec_info_content)
1538         (tui_erase_exec_info_content): Use refresh_window method.
1539         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1540         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1541         from tui_refresh_win.
1542         (tui_data_window::refresh_window): New method.
1543         (tui_win_info::refresh, tui_source_window_base::refresh)
1544         (tui_refresh_all): Use refresh_window method.
1545         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1546         method.
1547         * tui/tui-regs.c (tui_display_register): Call refresh_window
1548         method.
1549         * tui/tui-layout.c (show_source_disasm_command)
1550         (show_source_or_disasm_and_command): Call refresh_window method.
1551         * tui/tui-data.h (struct tui_gen_win_info)
1552         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1553         New method.
1554
1555 2019-06-25  Tom Tromey  <tom@tromey.com>
1556
1557         * tui/tui.c (tui_rl_other_window, tui_enable)
1558         (tui_is_window_visible, tui_get_command_dimension): Update.
1559         * tui/tui-winsource.c (tui_update_source_window_as_is)
1560         (tui_clear_source_content, tui_erase_source_content)
1561         (tui_show_source_line, tui_source_window_base::refill)
1562         (tui_source_window_base::do_scroll_horizontal)
1563         (tui_source_window_base::set_is_exec_point_at)
1564         (tui_update_breakpoint_info, tui_set_exec_info_content)
1565         (tui_alloc_source_buffer, tui_line_is_displayed)
1566         (tui_addr_is_displayed): Update.
1567         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1568         (tui_check_and_display_highlight_if_needed)
1569         (tui_win_info::make_visible, tui_win_info::refresh)
1570         (tui_refresh_all): Update.
1571         * tui/tui-windata.c (tui_first_data_item_displayed)
1572         (tui_delete_data_content_windows, tui_erase_data_content)
1573         (tui_display_all_data, tui_data_window::refresh_all)
1574         (tui_check_data_values): Update.
1575         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1576         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1577         (tui_win_info::backward_scroll, tui_refresh_all_win)
1578         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1579         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1580         (tui_source_window_base::set_new_height)
1581         (tui_data_window::set_new_height)
1582         (make_invisible_and_set_new_height)
1583         (make_visible_with_new_height, new_height_ok)
1584         (parse_scrolling_args): Update.
1585         * tui/tui-stack.c (tui_show_frame_info): Update.
1586         * tui/tui-source.c (tui_set_source_content)
1587         (tui_set_source_content_nil, tui_source_is_displayed)
1588         (tui_source_window::do_scroll_vertical): Update.
1589         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1590         (tui_display_registers_from, tui_display_reg_element_at_line)
1591         (tui_check_register_values, tui_reg_command): Update.
1592         * tui/tui-layout.c (tui_default_win_height)
1593         (show_source_disasm_command, show_data, init_and_make_win)
1594         (show_source_or_disasm_and_command): Update.
1595         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1596         (tui_redisplay_readline, tui_mld_flush)
1597         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1598         (tui_getc): Update.
1599         * tui/tui-disasm.c (tui_set_disassem_content)
1600         (tui_disasm_window::do_scroll_vertical): Update.
1601         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1602         Now virtual.
1603         (struct tui_win_info): Derive from tui_gen_win_info.
1604         <~tui_win_info>: Mark as override.
1605         <generic>: Remove member.
1606         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1607         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1608         (~tui_data_window, ~tui_win_info)
1609         (tui_free_all_source_wins_content): Update.
1610         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1611
1612 2019-06-25  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-layout.c (init_and_make_win): Use new.
1615         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1616         destructor, initializers.
1617         (tui_alloc_generic_win_info): Don't declare.
1618         * tui/tui-data.c (_locator): Add argument to constructor.
1619         (source_win, disasm_win): New globals.
1620         (exec_info): Remove.
1621         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1622         Update.
1623         (tui_alloc_generic_win_info): Remove.
1624         (init_content_element): Use new.
1625         (tui_win_info::tui_win_info): Update.
1626         (free_content_elements) <case DATA_WIN>: Use delete.
1627
1628 2019-06-25  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1631         * tui/tui-windata.c (tui_first_data_item_displayed)
1632         (tui_delete_data_content_windows): Update.
1633         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1634         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1635         (tui_display_registers_from, tui_check_register_values): Update.
1636         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1637         pointer.
1638         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1639         window.
1640         (tui_free_data_content): Update.
1641         (free_content_elements) <case DATA_WIN>: Free the window.
1642
1643 2019-06-25  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1646         Update.
1647         * tui/tui-layout.c (make_command_window)
1648         (show_source_disasm_command, show_data, init_and_make_win)
1649         (show_source_or_disasm_and_command): Update.
1650         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1651         method.
1652         <can_highight, is_highlighted>: Now bool.
1653         (tui_set_win_highlight): Don't declare.
1654         * tui/tui-data.c (tui_set_win_highlight): Remove.
1655
1656 2019-06-25  Tom Tromey  <tom@tromey.com>
1657
1658         * tui/tui-wingeneral.c (make_visible): Remove check of window
1659         type.
1660
1661 2019-06-25  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-win.c (tui_win_info::max_height)
1664         (tui_cmd_window::max_height): New methods.
1665         (new_height_ok): Call max_height.
1666         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1667         <max_height>: New method.
1668
1669 2019-06-25  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-win.c (tui_source_window_base::set_new_height)
1672         (tui_data_window::set_new_height): New methods.
1673         (make_invisible_and_set_new_height): Call set_new_height method.
1674         * tui/tui-data.h (struct tui_win_info)
1675         (struct tui_source_window_base, struct tui_data_window)
1676         <set_new_height>: New method.
1677
1678 2019-06-25  Tom Tromey  <tom@tromey.com>
1679
1680         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1681         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1682         tui_refresh_data_win.
1683         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1684         method.
1685         (tui_refresh_all_win): Call the refresh_all method.
1686         (tui_set_focus): Likewise.
1687         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1688         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1689         Likewise.
1690
1691 2019-06-25  Tom Tromey  <tom@tromey.com>
1692
1693         * tui/tui-winsource.h (tui_refill_source_window)
1694         (tui_set_is_exec_point_at): Don't declare.
1695         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1696         (tui_source_window_base::refill): Rename from
1697         tui_refill_source_window.
1698         (tui_source_window_base::do_scroll_horizontal): Update.
1699         (tui_source_window_base::set_is_exec_point_at): Rename from
1700         tui_set_is_exec_point_at.
1701         (tui_update_all_breakpoint_info): Update.
1702         * tui/tui-stack.c (tui_show_frame_info): Update.
1703         * tui/tui-layout.c (show_data): Add cast.
1704         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1705         * tui/tui-data.h (struct tui_source_window_base) <refill,
1706         set_is_exec_point_at>: New methods.
1707         (tui_source_windows, tui_add_to_source_windows): Update types.
1708         (tui_add_to_source_windows): Remove redundant declaration.
1709         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1710         (tui_source_windows): Change return type.
1711         (tui_clear_source_windows_detail): Update.
1712         (tui_add_to_source_windows): Change type of parameter.
1713         (tui_free_all_source_wins_content): Update.
1714
1715 2019-06-25  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-wingeneral.c (tui_win_info::refresh)
1718         (tui_source_window_base::refresh): New methods.
1719         (tui_refresh_all): Call the refresh method.
1720         * tui/tui-data.h (struct tui_win_info)
1721         (struct tui_source_window_base) <refresh>: New method.
1722
1723 2019-06-25  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui.h (tui_is_window_visible): Return bool.
1726         * tui/tui.c (tui_is_window_visible): Return bool.
1727         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1728         (tui_make_visible, tui_make_invisible)
1729         (tui_win_info::make_visible)
1730         (tui_source_window_base::make_visible, make_all_visible)
1731         (tui_make_all_visible, tui_make_all_invisible): Update.
1732         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1733         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1734         bool.
1735         (struct tui_win_info, struct tui_source_window_base)
1736         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1737         * tui/tui-data.c (tui_init_generic_part): Update.
1738
1739 2019-06-25  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1742         (tui_source_window_base::make_visible): New methods.
1743         (make_all_visible): Make method call.
1744         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1745         (struct tui_source_window_base, struct tui_cmd_window): Override
1746         make_visible.
1747         (tui_win_is_source_type): Don't declare.
1748         * tui/tui-data.c (tui_win_is_source_type): Remove.
1749
1750 2019-06-25  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1753         NULL check.
1754
1755 2019-06-25  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1758         Inline constructor.  Add initializers for members.
1759         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1760         constructors; now inline in class.
1761
1762 2019-06-25  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-regs.c (tui_show_registers): Update.
1765         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1766         bool.
1767         * tui/tui-data.c (tui_data_window::clear_detail)
1768         (tui_data_window): Update.
1769
1770 2019-06-25  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-windata.c (tui_display_all_data)
1773         (tui_display_data_from_line, tui_display_data_from)
1774         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1775         Update.
1776         * tui/tui-regs.c (tui_last_regs_line_no)
1777         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1778         (tui_show_registers, tui_show_register_group)
1779         (tui_display_registers_from, tui_display_reg_element_at_line)
1780         (tui_display_registers_from_line, tui_check_register_values)
1781         (tui_reg_next, tui_reg_prev): Update.
1782         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1783         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1784         tui_data_window.
1785         (struct tui_win_info) <detail>: Remove.  Add new fields from
1786         tui_data_info.
1787         (TUI_DATA_WIN): Add cast.
1788         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1789         (~tui_data_window): Simplify.
1790
1791 2019-06-25  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-layout.c (show_source_disasm_command)
1794         (show_source_or_disasm_and_command): Update.
1795         * tui/tui-io.c (update_cmdwin_start_line)
1796         (tui_redisplay_readline): Update.
1797         * tui/tui-data.h (struct tui_command_info): Remove.
1798         (struct tui_win_info) <detail>: Remove command_info member.
1799         (struct tui_data_window) <start_line>: New member, from
1800         tui_command_info.
1801         (TUI_CMD_WIN): Add casts.
1802
1803 2019-06-25  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-winsource.c (tui_update_source_window)
1806         (tui_refill_source_window)
1807         (tui_source_window_base::do_scroll_horizontal)
1808         (tui_update_breakpoint_info, tui_set_exec_info_content)
1809         (tui_show_exec_info_content, tui_erase_exec_info_content)
1810         (tui_clear_exec_info_content): Update.
1811         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1812         Update.
1813         * tui/tui-win.c (make_invisible_and_set_new_height)
1814         (make_visible_with_new_height): Update.
1815         * tui/tui-source.c (tui_set_source_content)
1816         (tui_show_symtab_source): Update.
1817         * tui/tui-layout.c (extract_display_start_addr)
1818         (show_source_disasm_command, show_data)
1819         (make_source_or_disasm_window)
1820         (show_source_or_disasm_and_command): Update.
1821         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1822         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1823         "gdbarch".
1824         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1825         to tui_source_window_base.
1826         (struct tui_win_info) <detail>: Remove source_info member.
1827         (struct tui_source_window_base) <has_locator>: Inline.
1828         Move contents from tui_source_info; rename has_locator member to
1829         m_has_locator.
1830         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1831         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1832         header file.
1833         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1834         Simplify.
1835         (tui_free_all_source_wins_content): Cast to
1836         tui_source_window_base.
1837
1838 2019-06-25  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui-win.c (make_invisible_and_set_new_height)
1841         (make_visible_with_new_height): Call has_locator method.
1842         * tui/tui-layout.c (show_source_disasm_command, show_data)
1843         (show_source_or_disasm_and_command): Update for bool change.
1844         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1845         (tui_win_info) <has_locator>: New method.
1846         (struct tui_source_window_base) <has_locator>: New method.
1847         (tui_win_has_locator): Don't declare.
1848         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1849         from tui_win_has_locator.
1850         (tui_source_window_base): Use false, not FALSE.
1851
1852 2019-06-25  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1855         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1856         clear_detail method directly.
1857         (tui_clear_win_detail): Remove.
1858
1859 2019-06-25  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1862         "this", not TUI_DISASM_WIN.
1863
1864 2019-06-25  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1867         declare.
1868         * tui/tui-winsource.c
1869         (tui_source_window_base::do_scroll_horizontal): Rename from
1870         tui_horizontal_source_scroll.
1871         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1872         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1873         from tui_vertical_data_scroll.
1874         * tui/tui-win.h (tui_scroll): Don't declare.
1875         * tui/tui-win.c (tui_win_info::forward_scroll)
1876         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1877         (tui_win_info::right_scroll): Rename and update.
1878         (tui_scroll_forward_command, tui_scroll_backward_command)
1879         (tui_scroll_left_command, tui_scroll_right_command): Update.
1880         (tui_scroll): Remove.
1881         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1882         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1883         from tui_vertical_source_scroll.
1884         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1885         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1886         from tui_vertical_disassem_scroll.
1887         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1888         do_scroll_horizontal>: New methods.
1889         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1890         Likewise.
1891         (struct tui_source_window_base): Add do_scroll_horizontal.
1892         (struct tui_source_window, struct tui_disasm_window): Add
1893         do_scroll_vertical.
1894         (struct tui_data_window, struct tui_cmd_window): Add
1895         do_scroll_horizontal and do_scroll_vertical.
1896         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1897
1898 2019-06-25  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-data.h (struct tui_source_window_base): New struct.
1901         (struct tui_source_window): Derive from tui_source_window_base.
1902         (struct tui_disasm_window): New struct.
1903         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1904         from tui_source_window::clear_detail.
1905         (tui_source_window_base): Rename from tui_source_window.
1906         (~tui_source_window_base): Rename from ~tui_source_window.
1907         (tui_alloc_win_info): Create a tui_disasm_window.
1908
1909 2019-06-25  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-data.h (struct tui_source_window)
1912         (struct tui_data_window): Declare destructors.
1913         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1914         destructors.
1915         (tui_win_info): Simplify.
1916
1917 2019-06-25  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-winsource.c (tui_display_main)
1920         (tui_update_source_windows_with_addr)
1921         (tui_update_all_breakpoint_info): Update.
1922         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1923         (new_height_ok, parse_scrolling_args): Update.
1924         * tui/tui-stack.c (tui_show_frame_info): Update.
1925         * tui/tui-data.h (struct tui_list): Remove.
1926         (tui_source_windows): Return a reference to a std::vector.
1927         * tui/tui-data.c (source_windows): Now a std::vector.
1928         (tui_source_windows): Change return type.
1929         (tui_clear_source_windows): Rewrite.
1930         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1931         (tui_free_all_source_wins_content): Rewrite.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1936         (struct tui_data_window, struct tui_cmd_window): Declare
1937         clear_detail method.
1938         * tui/tui-data.c (tui_source_window::clear_detail)
1939         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1940         methods.
1941         (tui_clear_win_detail): Simplify.
1942
1943 2019-06-25  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-layout.c (make_source_window, make_disasm_window)
1946         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1947         Return the new window.
1948         (show_source_disasm_command, show_data)
1949         (show_source_or_disasm_and_command): Update.
1950
1951 2019-06-25  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1954         parameter.  Return the new window.
1955         (show_source_disasm_command): Update and remove NULL check.
1956         (show_source_or_disasm_and_command): Update.
1957
1958 2019-06-25  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1961
1962 2019-06-25  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-data.h (struct tui_win_info): Make constructor
1965         protected.  Make destructor virtual.  Add initializers.
1966         (tui_source_window, tui_data_window, tui_cmd_window): New
1967         classes.
1968         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1969         constructor.  Add "type" parameter.
1970         (tui_source_window, tui_data_window, tui_cmd_window): New
1971         constructors.
1972         (tui_alloc_win_info): Instantiate the appropriate subclass.
1973
1974 2019-06-25  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-win.c (tui_resize_all): Use delete.
1977         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1978         destructor.
1979         (tui_free_window): Don't declare.
1980         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1981         Update.
1982
1983 2019-06-25  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-data.h (struct tui_win_info): Add constructor.
1986         * tui/tui-data.c (tui_alloc_win_info): Use new.
1987         (tui_free_window): Use delete.
1988
1989 2019-06-22  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1992         declare.
1993         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1994
1995 2019-06-22  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1998         declare.
1999         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2000
2001 2019-06-22  Tom de Vries  <tdevries@suse.de>
2002
2003         * dwarf2read.c (create_addrmap_from_aranges)
2004         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2005         instead of '%zu'.
2006
2007 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2008
2009         * dwarf2read.h (dwarf2_section_info_def): Remove.
2010         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2011         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2012         std::vector<dwarf2_section_info>.
2013         (struct dwo_file) <~dwo_file>: Remove.
2014         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2015         types field.
2016         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2017         (dwarf2_read_debug_names): Likewise.
2018         (create_debug_types_hash_table): Change parameter type to
2019         array_view, adjust code accordingly.
2020         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2021         (partial_die_info::fixup): Likewise.
2022         (determine_prefix): Likewise.
2023         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2024
2025 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2026
2027         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2028         gdb_bfd_ref_ptr.
2029         <~dwo_file>: Remove call to gdb_bfd_unref.
2030         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2031         gdb_bfd_ref_ptr::get.
2032
2033 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2034
2035         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2036         type to htab_up.
2037         * dwarf2read.c (struct dwo_file): Initialize fields.
2038         <~dwo_file>: New.
2039         (free_dwo_file): Remove, move content to ~dwo_file.
2040         (struct dwo_file_deleter): Remove.
2041         (dwo_file_up>: Remove custom deleter.
2042         (free_dwo_files): Remove.
2043         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2044         dwo_files.
2045         (process_skeletonless_type_units): Call unique_ptr::get.
2046         (allocate_dwo_file_hash_table): Add deleter to created hash
2047         table.  Change return type to htab_up.
2048         (lookup_dwo_file_slot): Don't memset dwo_file, call
2049         unique_ptr::get.
2050         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2051         (create_dwo_unit_in_dwp_v2): Likewise.
2052         (open_and_init_dwo_file): Likewise.
2053         (free_dwo_file_from_slot): Remove.
2054
2055 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2056
2057         * dwarf2read.h (struct dwarf2_section_info) <readin,
2058         is_virtual>: Change type to bool.
2059         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2060         true instead of 1.
2061
2062 2019-06-19  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-data.h (tui_init_content_element): Don't declare.
2065
2066 2019-06-19  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-data.h (tui_init_win_info): Don't declare.
2069
2070 2019-06-19  Tom de Vries  <tdevries@suse.de>
2071
2072         * dwarf2read.h (abstract_to_concrete): Change type to
2073         std::unordered_map<sect_offset, std::vector<sect_offset>,
2074         gdb::hash_enum<sect_offset>>.
2075
2076 2019-06-19  Tom Tromey  <tromey@adacore.com>
2077
2078         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2079         EVAL_AVOID_SIDE_EFFECTS specially.
2080
2081 2019-06-19  Tom Tromey  <tromey@adacore.com>
2082
2083         * source-cache.c (highlighter): New global.
2084         (source_cache::get_source_lines): Create a highlighter on demand.
2085
2086 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2087
2088         * defs.h (deprecated_interactive_hook): Delete declaration.
2089         * interps.c (clear_interpreter_hooks): Remove use of
2090         deprecated_interactive_hook.
2091         * top.c (deprecated_interactive_hook): Delete definition.
2092         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2093
2094 2019-06-18  Tom de Vries  <tdevries@suse.de>
2095
2096         PR gdb/24515
2097         * dwarf2read.h (abstract_to_concrete): Change type from
2098         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2099         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2100         * dwarf2read.c (read_variable): Update.
2101         (dwarf2_fetch_die_loc_sect_off): Update.
2102
2103 2019-06-17  Tom de Vries  <tdevries@suse.de>
2104
2105         PR gdb/24617
2106         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2107         accessing parent[parent_len - 1].
2108
2109 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2110
2111         PR gdb/24364
2112         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2113         call dtrace_process_dof with NULL dof.
2114
2115 2019-06-16  Tom de Vries  <tdevries@suse.de>
2116
2117         PR gdb/24445
2118         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2119
2120 2019-06-16  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2123         (make_all_visible): Use address of member.
2124
2125 2019-06-16  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2128         (tui_free_window, free_content, free_content_elements): Remove
2129         unnecessary cast.
2130         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2131         cast.
2132         * tui/tui-regs.c (tui_show_register_group)
2133         (tui_display_registers_from, tui_display_reg_element_at_line):
2134         Remove unnecessary cast.
2135
2136 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2137
2138         * linux-nat.c (normal_mask): Delete.
2139         (_initialize_linux_nat): Don't initialise normal_mask.
2140
2141 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2142
2143         PR gdb/24445
2144         * dwarf-index-write.h (write_psymtabs_to_index): Add
2145         dwz_basename parameter.
2146         * dwarf-index-write.c (write_gdbindex): Move file writing to
2147         write_gdbindex_1.  Change return type void.
2148         (assert_file_size): Move up, remove filename parameter.
2149         (write_gdbindex_1): New function.
2150         (write_debug_names): Change return type to void, call
2151         assert_file_size.
2152         (struct index_wip_file): New struct.
2153         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2154         file logic to index_wip_file.  Write index for dwz file if
2155         needed.
2156         (save_gdb_index_command): Pass basename of dwz file, if present.
2157         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2158         build-id of dwz file, if present.
2159         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2160         (dwarf2_get_dwz_file): Likewise.
2161         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2162         (dwarf2_get_dwz_file): Likewise.
2163
2164 2019-06-16  Tom Tromey  <tom@tromey.com>
2165
2166         * coffread.c (process_coff_symbol): Use xstrdup.
2167         * value.c (create_internalvar): Use xstrdup.
2168
2169 2019-06-16  Tom Tromey  <tom@tromey.com>
2170
2171         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2172         * breakpoint.c (stopin_command, stopat_command)
2173         (until_break_command, decode_location_default): Remove unnecessary
2174         cast.
2175         * utils.c (subset_compare): Remove unnecessary cast.
2176         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2177         cast.
2178         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2179         cast.
2180         * infcmd.c (path_command): Remove unnecessary cast.
2181         * coffread.c (decode_type): Remove unnecessary cast.
2182         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2183         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2184         * tui/tui-stack.c (tui_show_locator_content)
2185         (tui_show_frame_info): Remove unnecessary cast.
2186         * tui/tui-win.c (tui_scroll_forward_command)
2187         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2188         (parse_scrolling_args): Remove unnecessary cast.
2189         * tui/tui-data.c (init_win_info, tui_del_window)
2190         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2191         (free_content_elements): Remove unnecessary cast.
2192         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2193         unnecessary cast.
2194         * tui/tui-source.c (tui_set_source_content)
2195         (tui_vertical_source_scroll): Remove unnecessary cast.
2196         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2197         cast.
2198         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2199         * tui/tui-regs.c (tui_display_registers_from)
2200         (tui_display_register): Remove unnecessary cast.
2201         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2202         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2203         (make_visible): Remove unnecessary cast.
2204         * tui/tui-winsource.c (tui_erase_source_content)
2205         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2206         unnecessary cast.
2207         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2208         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2209         * stabsread.c (read_type, read_array_type, read_range_type):
2210         Remove unnecessary cast.
2211         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2212         (parse_symbol, parse_type, upgrade_type, parse_external)
2213         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2214         unnecessary cast.
2215         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2216
2217 2019-06-16  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui-data.c (tui_alloc_generic_win_info)
2220         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2221         checks.
2222
2223 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2224             Andrew Burgess  <andrew.burgess@embecosm.com>
2225
2226         * f-typeprint.c (f_print_type): Don't return early for not
2227         associated or not allocated types.
2228         (f_type_print_varspec_suffix): Add print_rank parameter and print
2229         ranks of array types in case they dangling.
2230         (f_type_print_base): Add print_rank parameter.
2231
2232 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2233
2234         * NEWS: Mention new MI commands.
2235         * break-catch-throw.c (enum exception_event_kind): Move to
2236         breakpoint.h.
2237         (print_mention_exception_catchpoint): Output text as a single
2238         message.
2239         (catch_exception_command_1): Rename to...
2240         (catch_exception_event): ...this, make non-static, update header
2241         command, and change some parameter types.
2242         (catch_catch_command): Update for changes to
2243         catch_exception_command_1.
2244         (catch_throw_command): Likewise.
2245         (catch_rethrow_command): Likewise.
2246         * breakpoint.c (enum exception_event_kind): Delete.
2247         * breakpoint.h (enum exception_event_kind): Moved here from
2248         break-catch-throw.c.
2249         (catch_exception_event): Declare.
2250         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2251         (mi_cmd_catch_throw): New function.
2252         (mi_cmd_catch_rethrow): New function.
2253         (mi_cmd_catch_catch): New function.
2254         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2255         'catch-catch' entries.
2256         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2257         (mi_cmd_catch_rethrow): Declare.
2258         (mi_cmd_catch_catch): Declare.
2259
2260 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2261
2262         * annotate.c (annotate_source_line): Change return type to void,
2263         update implementation to match.
2264         * annotate.h (annotate_source_line): Change return type to void,
2265         update header comment.
2266         * stack.c (print_frame_info): Don't change what frame information
2267         is printed based on whether annotations are on or not.
2268
2269 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2270
2271         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2272         (annotate_source): Make static.
2273         (annotate_source_line): Moved from source.c and renamed from
2274         identify_source_line.  Update the return type.
2275         * annotate.h (annotate_source): Delete declaration.
2276         (annotate_source_line): Declaration moved from source.h, and
2277         renamed from identify_source_line.  Return type updated.
2278         * source.c (identify_source_line): Moved to annotate.c and renamed
2279         to annotate_source_line.
2280         (info_line_command): Remove check of annotation_level.
2281         * source.h (identify_source_line): Move declaration to annotate.h
2282         and rename to annotate_source_line.
2283         * stack.c: Add 'annotate.h' include.
2284         (print_frame_info): Remove check of annotation_level before
2285         calling annotate_source_line.
2286
2287 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2288
2289         * source-cache.c (source_cache::get_plain_source_lines): Use
2290         open_source_file_with_line_charpos instead of just
2291         open_source_file, remove call to find_source_lines.
2292         (source_cache::get_source_lines): Likewise.
2293         * source.c (find_source_lines): Make static.
2294         (get_filename_and_charpos): Renamed into...
2295         (open_source_file_with_line_charpos): ..this along with changes to
2296         return a scoped_fd, and some other minor clean ups.
2297         (identify_source_line): Use open_source_file_with_line_charpos.
2298         (search_command_helper): Use open_source_file_with_line_charpos
2299         instead of just open_source_file, remove call to
2300         find_source_lines.
2301         * source.h (open_source_file_with_line_charpos): Declare new
2302         function.
2303         (find_source_lines): Delete declaration.
2304
2305 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2306
2307         * source.c (get_filename_and_charpos): Remove fullname
2308         parameter.
2309         (identify_source_line): Update call to get_filename_and_charpos.
2310
2311 2019-06-14  Tom Tromey  <tromey@adacore.com>
2312
2313         PR gdb/24502:
2314         * ui-style.h (skip_ansi_escape): Update comment.
2315         * ui-file.h (class no_terminal_escape_file): New class.
2316         * ui-file.c (no_terminal_escape_file::write)
2317         (no_terminal_escape_file::puts): New methods.
2318         * cli/cli-logging.c (handle_redirections): Use
2319         no_terminal_escape_file.
2320
2321 2019-06-14  Tom Tromey  <tromey@adacore.com>
2322
2323         * NEWS: Move convenience variable news above Python news.
2324
2325 2019-06-14  Tom Tromey  <tom@tromey.com>
2326
2327         * gnulib: Move directory to top-level.
2328         * configure.ac: Don't configure gnulib.
2329         * configure: Rebuild.
2330         * common/common-defs.h: Use new path to gnulib.
2331         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2332         (GNULIB_H): Remove.
2333         (INCGNU): Look in new gnulib location.
2334         (HFILES_NO_SRCDIR): Remove gnulib files.
2335         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2336         (generated_files): Remove GNULIB_H.
2337         ($(LIBGNU), all-lib): Remove targets.
2338         (distclean): Don't mention GNULIB_BUILDDIR.
2339         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2340
2341 2019-06-14  Tom Tromey  <tromey@adacore.com>
2342
2343         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2344         Warn if symbol file does not provide any symbols.
2345
2346 2019-06-14  Tom Tromey  <tromey@adacore.com>
2347
2348         * source.c (find_and_open_source): Respect basenames_may_differ.
2349
2350 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2351
2352         * annotate.c (annotate_breakpoints_invalid): Make use of
2353         scoped_restore_terminal_state.
2354         (annotate_frames_invalid): Likewise.
2355
2356 2019-06-14  Tom Tromey  <tromey@adacore.com>
2357
2358         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2359         allow assignment to an internalvar.
2360
2361 2019-06-14  Tom Tromey  <tromey@adacore.com>
2362
2363         * ada-lex.l: Allow "_" in attribute names.
2364
2365 2019-06-14  Tom Tromey  <tromey@adacore.com>
2366
2367         PR gdb/24653:
2368         * regcache.c (registers_changed): Don't call alloca.
2369         * top.c (execute_command): Don't call alloca.
2370
2371 2019-06-13  Pedro Alves  <palves@redhat.com>
2372
2373         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2374         'expression'.  When parsing an expression, error out if there's
2375         junk after "unlimited".
2376         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2377         (do_set_command): Adjust calls to is_unlimited_literal.
2378
2379 2019-06-13  Pedro Alves  <palves@redhat.com>
2380
2381         * compile/compile.c (make_compile_options_def_group): Add braces
2382         around array_view initializer.
2383         * thread.c (make_thread_apply_all_options_def_group)
2384         (make_thread_apply_all_options_def_group): Likewise.
2385
2386 2019-06-13  Pedro Alves  <palves@redhat.com>
2387
2388         * NEWS (New commands): Mention "maint test-options
2389         require-delimiter", "maint test-options unknown-is-error", "maint
2390         test-options unknown-is-operand" and "maint show
2391         test-options-completion-result".
2392         (New command options, command completion): New section.
2393         (Completion improvements): New section.
2394         Mention that you can abbreviate "unlimited".
2395
2396 2019-06-13  Pedro Alves  <palves@redhat.com>
2397
2398         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2399         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2400         * unittests/cli-utils-selftests.c (test_parse_flags)
2401         (test_parse_flags_qcs): Delete.
2402         (test_cli_utils): Don't call deleted functions.
2403
2404 2019-06-13  Pedro Alves  <palves@redhat.com>
2405
2406         * thread.c: Include "cli/cli-option.h".
2407         (tp_array_compar_ascending): Global.
2408         (tp_array_compar): Delete function.
2409         (tp_array_compar_ascending, tp_array_compar_descending): New
2410         functions.
2411         (ascending_option_def, qcs_flag_option_def)
2412         (thr_qcs_flags_option_defs)
2413         (make_thread_apply_all_options_def_group)
2414         (make_thread_apply_options_def_group): New.
2415         (thread_apply_all_command): Use gdb::option::process_options.
2416         (thread_apply_command_completer)
2417         (thread_apply_all_command_completer): New.
2418         (thread_apply_command): Use gdb::option::process_options.
2419         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2420         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2421         to generate help text of "thread apply".  Adjust "taas"'s help.
2422         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2423         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2424
2425 2019-06-13  Pedro Alves  <palves@redhat.com>
2426
2427         * thread.c (thread_apply_command): Check for invalid TID with
2428         isdigit instead of !isalpha.
2429
2430 2019-06-13  Pedro Alves  <palves@redhat.com>
2431
2432         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2433         (validate_flags_qcs): New.
2434         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2435         (validate_flags_qcs): Declare.
2436         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2437         (make_frame_apply_options_def_group): New.
2438         (frame_apply_command_count): Process options with
2439         gdb::option::process_options.
2440         (frame_apply_completer): New.
2441         (frame_apply_level_completer, frame_apply_all_completer)
2442         (frame_apply_completer): New.
2443         (_initialize_stack): Update help of "frame apply", "frame apply
2444         level", "frame apply all" and "faas" to mention supported options
2445         and install command completers.
2446         * stack.h (frame_apply_all_completer): Declare.
2447         * thread.c: Include "stack.h".
2448         (tfaas_command): Add "--".
2449         (_initialize_thread): Update help "tfaas" to mention supported
2450         options and install command completer.
2451
2452 2019-06-13  Pedro Alves  <palves@redhat.com>
2453
2454         * completer.c (complete_nested_command_line): New.
2455         (gdb_completion_word_break_characters_throw): Add assertion.
2456         * completer.h (complete_nested_command_line): Declare.
2457
2458 2019-06-13  Pedro Alves  <palves@redhat.com>
2459
2460         * stack.c (parse_backtrace_qualifiers): New.
2461         (backtrace_command): Use it.
2462         (backtrace_command_completer): Complete on qualifiers.
2463
2464 2019-06-13  Pedro Alves  <palves@redhat.com>
2465
2466         * frame.c: Include "cli/cli-option.h.
2467         (user_set_backtrace_options): New.
2468         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2469         Delete.
2470         (get_prev_frame): Adjust.
2471         (boolean_option_def, uinteger_option_def)
2472         (set_backtrace_option_defs): New.
2473         (_initialize_frame): Adjust and use
2474         gdb::option::add_setshow_cmds_for_options to install "set
2475         backtrace past-main" and "set backtrace past-entry".
2476         * frame.h: Include "cli/cli-option.h".
2477         (struct frame_print_options): Forward declare.
2478         (print_frame_arguments_all, print_frame_arguments_scalars)
2479         (print_frame_arguments_none): Declare.
2480         (print_entry_values): Delete declaration.
2481         (struct frame_print_options, user_frame_print_options): New.
2482         (struct set_backtrace_options): New.
2483         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2484         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2485         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2486         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2487         (list_args_or_locals): Add frame_print_options parameter.
2488         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2489         * python/py-framefilter.c (enumerate_args): Pass down
2490         USER_FRAME_PRINT_OPTIONS.
2491         * stack.c: Include "cli/cli-option.h".
2492         (print_frame_arguments_all, print_frame_arguments_scalars)
2493         (print_frame_arguments_none): Declare.
2494         (print_raw_frame_arguments, print_entry_values): Delete.
2495         (user_frame_print_options): New.
2496         (boolean_option_def, enum_option_def, frame_print_option_defs):
2497         New.
2498         (struct backtrace_cmd_options): New.
2499         (bt_flag_option_def): New.
2500         (backtrace_command_option_defs): New.
2501         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2502         (print_frame_arg, read_frame_arg, print_frame_args)
2503         (print_frame_info, print_frame): Add frame_print_options parameter
2504         and use it.
2505         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2506         (backtrace_command_1): Add frame_print_options and
2507         backtrace_cmd_options parameters and use them.
2508         (make_backtrace_options_def_group): New.
2509         (backtrace_command): Process command options with
2510         gdb::option::process_options.
2511         (backtrace_command_completer): New.
2512         (_initialize_stack): Extend "backtrace"'s help to mention
2513         supported options.  Install completer for "backtrace".
2514         Install some settings commands with add_setshow_cmds_for_options.
2515
2516 2019-06-13  Pedro Alves  <palves@redhat.com>
2517
2518         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2519         and that "set/show print raw frame-arguments" are now deprecated.
2520
2521         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2522         command.
2523         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2524         * stack.c (_initialize_stack): Install "set/show print
2525         raw-frame-arguments", and deprecate "set/show print raw
2526         frame-arguments".
2527         * valprint.c (_initialize_valprint): Deprecate "set/show print
2528         raw".
2529
2530 2019-06-13  Pedro Alves  <palves@redhat.com>
2531
2532         * compile/compile.c (struct compile_options): New.
2533         (compile_flag_option_def, compile_command_option_defs)
2534         (make_compile_options_def_group): New.
2535         (compile_file_command): Handle options with
2536         gdb::option::process_options.
2537         (compile_file_command_completer): New function.
2538         (compile_code_command): Handle options with
2539         gdb::option::process_options.
2540         (compile_code_command_completer): New function.
2541         (_initialize_compiler): Install completers for "compile code" and
2542         "compile file".  Mention available options in "compile code" and
2543         "compile code"'s help.
2544         * completer.c (advance_to_completion_word): New, factored out from
2545         ...
2546         (advance_to_expression_complete_word_point): ... this.
2547         (advance_to_filename_complete_word_point): New.
2548         * completer.h (advance_to_filename_complete_word_point): New
2549         declaration.
2550
2551 2019-06-13  Pedro Alves  <palves@redhat.com>
2552
2553         * compile/compile.c: Include "cli/cli-option.h".
2554         (compile_print_value): Scope data pointer is now a
2555         value_print_options pointer; adjust.
2556         (compile_print_command): Process options.  Scope data pointer is
2557         now a value_print_options pointer; adjust.
2558         (_initialize_compile): Update "compile print"'s help to include
2559         supported options.  Install a completer for "compile print".
2560         * cp-valprint.c (show_vtblprint, show_objectprint)
2561         (show_static_field_print): Delete.
2562         (_initialize_cp_valprint): Don't install "set print
2563         static-members", "set print vtbl", "set print object" here.
2564         * printcmd.c: Include "cli/cli-option.h" and
2565         "common/gdb_optional.h".
2566         (print_command_parse_format): Rework to fill in a
2567         value_print_options instead of a format_data.
2568         (print_value): Change parameter type from format_data pointer to
2569         value_print_options reference.  Adjust.
2570         (print_command_1): Process options.  Adjust to pass down a
2571         value_print_options.
2572         (print_command_completer): New.
2573         (_initialize_printcmd): Install print_command_completer as
2574         handle_brkchars completer for the "print" command.  Update
2575         "print"'s help to include supported options.
2576         * valprint.c: Include "cli/cli-option.h".
2577         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2578         here from cp-valprint.c.
2579         (boolean_option_def, uinteger_option_def)
2580         (value_print_option_defs, make_value_print_options_def_group):
2581         New.  Use gdb::option::add_setshow_cmds_for_options to install
2582         "set print elements", "set print null-stop", "set print repeats",
2583         "set print pretty", "set print union", "set print array", "set
2584         print address", "set print symbol", "set print array-indexes".
2585         * valprint.h: Include <string> and "cli/cli-option.h".
2586         (make_value_print_options_def_group): Declare.
2587         (print_value): Change parameter type from format_data pointer to
2588         value_print_options reference.
2589         (print_command_completer): Declare.
2590
2591 2019-06-13  Pedro Alves  <palves@redhat.com>
2592
2593         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2594         (COMMON_SFILES): Add maint-test-settings.c.
2595         * cli/cli-decode.c (boolean_enums): New global, factored out from
2596         ...
2597         (add_setshow_boolean_cmd): ... here.
2598         * cli/cli-decode.h (boolean_enums): Declare.
2599         * cli/cli-option.c: New file.
2600         * cli/cli-option.h: New file.
2601         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2602         factored out from ...
2603         (parse_cli_boolean_value(const char *)): ... this.
2604         (is_unlimited_literal): Change parameter type to pointer to
2605         pointer.  Adjust and advance ARG pointer.
2606         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2607         (parse_cli_var_enum): New, factored out from ...
2608         (do_set_command): ... this.  Adjust.
2609         * cli/cli-setshow.h (parse_cli_boolean_value)
2610         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2611         (parse_cli_var_enum): Declare.
2612         * cli/cli-utils.c: Include "cli/cli-option.h".
2613         (get_ulongest): New.
2614         * cli/cli-utils.h (get_ulongest): Declare.
2615         (check_for_argument): New overloads.
2616         * maint-test-options.c: New file.
2617
2618 2019-06-13  Pedro Alves  <palves@redhat.com>
2619
2620         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2621         parse a range if "-" is at the end of the string.
2622
2623 2019-06-13  Pedro Alves  <palves@redhat.com>
2624
2625         * cli/cli-setshow.c (parse_auto_binary_operation)
2626         (parse_cli_boolean_value): Don't allow "o".
2627
2628 2019-06-13  Pedro Alves  <palves@redhat.com>
2629
2630         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2631         * NEWS: Mention maint test-settings KIND.
2632         * maint-test-settings.c: New file.
2633
2634 2019-06-13  Pedro Alves  <palves@redhat.com>
2635
2636         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2637         completer.
2638         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2639         "set" completers.
2640
2641 2019-06-13  Pedro Alves  <palves@redhat.com>
2642
2643         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2644         after item.
2645
2646 2019-06-13  Pedro Alves  <palves@redhat.com>
2647
2648         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2649
2650 2019-06-13  Pedro Alves <palves@redhat.com>
2651
2652         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2653         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2654         call.
2655         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2656         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2657         calls.
2658         (check_for_argument): Skip spaces after argument.
2659
2660 2019-06-13  Pedro Alves  <palves@redhat.com>
2661
2662         * thread.c (thread_apply_command): Adjust TID parsing.
2663         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2664         detected before end of string.
2665         (tid_is_in_list): Error out if LIST is invalid.
2666
2667 2019-06-13  Pedro Alves  <palves@redhat.com>
2668
2669         * completer.c (complete_line_internal_1): Rewind completion word
2670         point.
2671         (completion_tracker::advance_custom_word_point_by): Change
2672         parameter type to int.
2673         * completer.h (completion_tracker::advance_custom_word_point_by):
2674         Likewise.
2675
2676 2019-06-13  Pedro Alves  <palves@redhat.com>
2677
2678         * completer.c (advance_to_completion_word): Handle delimiters.
2679
2680 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2681
2682         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2683
2684 2019-06-11  Tom Tromey  <tom@tromey.com>
2685
2686         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2687         (xmalloc_failed): Move to alloc.c.
2688         * alloc.c: New file.
2689         * Makefile.in (COMMON_SFILES): Add alloc.c.
2690
2691 2019-06-11  Tom Tromey  <tom@tromey.com>
2692
2693         * nat/linux-waitpid.c: Don't include server.h.
2694         (linux_debug): Remove.
2695         (my_waitpid): Update.
2696
2697 2019-06-11  Tom Tromey  <tromey@adacore.com>
2698
2699         * infcall.c (_initialize_infcall): Remove trailing newline from
2700         help.
2701         * user-regs.c (_initialize_user_regs): Remove trailing newline
2702         from help.
2703         * typeprint.c (_initialize_typeprint): Remove trailing newline
2704         from help.
2705         * reverse.c (_initialize_reverse): Remove trailing newlines from
2706         help.
2707         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2708         from help.
2709         * language.c (add_set_language_command): Remove trailing newline
2710         from help.
2711         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2712         help.
2713         * disasm.c (_initialize_disasm): Remove trailing newline from
2714         help.
2715         * top.c (init_main): Remove trailing newline from help.
2716         * interps.c (_initialize_interpreter): Remove trailing newline
2717         from help.
2718         * btrace.c (_initialize_btrace): Remove trailing newlines from
2719         help.
2720         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2721         from help.
2722         * python/python.c (_initialize_python): Remove trailing newline
2723         from help.
2724         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2725         help.
2726         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2727         from help.  Reformat some text.
2728         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2729         from help.
2730         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2731         newline from help.
2732
2733 2019-06-11  Tom Tromey  <tromey@adacore.com>
2734
2735         * darwin-nat.c (darwin_decode_exception_message)
2736         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2737
2738 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2739
2740         * valops.c (value_slice): Check for not allocated or not
2741         associated values.
2742
2743 2019-06-10  Tom de Vries  <tdevries@suse.de>
2744
2745         PR gdb/24618
2746         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2747         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2748         invalid.
2749
2750 2019-06-10  Tom de Vries  <tdevries@suse.de>
2751
2752         PR gdb/24611
2753         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2754         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2755
2756 2019-06-10  Tom de Vries  <tdevries@suse.de>
2757
2758         PR symtab/24545
2759         * symtab.c (struct demangled_name_entry): Add language field.
2760         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2761         static minimal symbol".  Set and use language field.
2762
2763 2019-06-10  Tom Tromey  <tromey@adacore.com>
2764
2765         * ada-lang.c (_initialize_ada_language): Update help text.
2766
2767 2019-06-10  Tom Tromey  <tromey@adacore.com>
2768
2769         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2770         with a newline.
2771         * guile/guile.c (handle_boot_error): Don't end warning with a
2772         newline.
2773         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2774         warning with a newline.
2775         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2776         newline.
2777         (s12z_frame_cache): Likewise.
2778         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2779         a newline.
2780         * solib-svr4.c (disable_probes_interface): Don't end warning with
2781         a newline.
2782         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2783         newline.
2784         * python/python.c (do_finish_initialization): Don't end warning
2785         with a newline.
2786
2787 2019-06-10  Tom Tromey  <tom@tromey.com>
2788
2789         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2790         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2791         gdbpy_enter.
2792
2793 2019-06-10  Tom Tromey  <tromey@adacore.com>
2794
2795         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2796         data.
2797         (elf_new_init): Don't call stabsread_new_init.
2798         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2799         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2800         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2801
2802 2019-06-10  Tom de Vries  <tdevries@suse.de>
2803
2804         PR symtab/16264
2805         PR symtab/24517
2806         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2807
2808 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2809
2810         * source.c (find_and_open_source): Also rewrite relative file
2811         names.
2812
2813 2019-04-26  Amos Bird  <amosbird@gmail.com>
2814
2815         * annotate.c (annotate_thread_exited): Add "thread-exited"
2816         annotation.
2817
2818 2019-06-06  Tom Tromey  <tromey@adacore.com>
2819
2820         * maint.h (class scoped_command_stats): Use
2821         DISABLE_COPY_AND_ASSIGN.
2822         <print_time>: New method.
2823         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2824         print_time.
2825         (scoped_command_stats::print_time): New method.
2826
2827 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2828
2829         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2830         instructions of lengths 6 or 8 bytes.
2831
2832 2019-06-04  Pedro Alves  <palves@redhat.com>
2833
2834         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2835
2836         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2837         * breakpoint.c (condition_completer): Likewise.
2838         * cli/cli-dump.c (scan_expression): Likewise.
2839         * common/filestuff.c (mkdir_recursive): Likewise.
2840         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2841         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2842         (gdb_abspath): Likewise.
2843         * compile/compile-cplus-types.c
2844         (compile_cplus_instance::decl_name): Likewise.
2845         * completer.c (complete_explicit_location):
2846         (signal_completer, reg_or_group_completer_1): Likewise.
2847         * cp-support.c (cp_remove_params_if_any): Likewise.
2848         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2849         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2850         * infcmd.c (strip_bg_char): Likewise.
2851         * linespec.c (copy_token_string): Likewise.
2852         * mi/mi-main.c (output_cores): Likewise.
2853         * psymtab.c (psymtab_search_name):
2854         * symfile.c (test_set_ext_lang_command): Likewise.
2855         * target.c (target_fileio_read_stralloc): Likewise.
2856         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2857         * value.c (complete_internalvar): Likewise.
2858
2859 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2860
2861         Add objfile property to gdb.Type.
2862         * NEWS: Mention Python API addition.
2863         * python/py-type.c (typy_get_objfile): New method.
2864
2865 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2866
2867         * NEWS: Mention the new set|show style [title|highlight].
2868         Mention changes to "show style", "help" and "apropos".
2869
2870 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2871
2872         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2873         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2874         instead of print_help_for_command.
2875         (print_doc_of_command): New function.
2876         (help_list): Add 'apropos -v word' suggestion.
2877         (print_help_for_command): Style the command name using title style.
2878         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2879         (_initialize_cli_cmds): Describe -v in apropos_command help.
2880
2881 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2882
2883         * cli/cli-style.h (cli_style_option): Add name in constructor,
2884         add m_name class member, add constructor with intensity,
2885         add name class function.
2886         (cli_style_option::add_setshow_commands): Remove name argument.
2887         (highlight_style, title_style): New styles.
2888         * cli/cli-style.c (do_show): New function that shows a style
2889         characteristic styling the style name with itself.
2890         (set_style_name): New function.
2891         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2892         Update all callers according to the changes in cli/cli-style.h.
2893         * utils.h (fputs_highlighted): New function.
2894         * utils.c (fputs_highlighted): Likewise.
2895
2896 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2897
2898         * NEWS: Mention new pipe command and new convenience variables.
2899
2900 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2901
2902         * cli/cli-cmds.c (pipe_command): New function.
2903         (_initialize_cli_cmds): Call add_com for pipe_command.
2904         Define | as an alias for pipe.
2905         (exit_status_set_internal_vars): New function.
2906         (shell_escape): Call exit_status_set_internal_vars.
2907         cli/cli-decode.c (find_command_name_length): Recognize | as
2908         a single character command.
2909
2910 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2911
2912         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2913         top.c (execute_command_to_ui_file): New function, mostly a copy
2914         of execute_command_to_string.
2915         (execute_command_to_string): Implement by calling
2916         execute_command_to_ui_file.
2917
2918 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2919
2920         * top.h (saved_command_line): Remove declaration.
2921         * top.c (previous_saved_command_line, previous_repeat_arguments):
2922         New variables.
2923         (saved_command_line): Make static, define together with other
2924         'repeat variables'.
2925         (dont_repeat): Clear repeat_arguments.
2926         (repeat_previous, get_saved_command_line, save_command_line):
2927         New functions.
2928         (gdb_init): Initialize saved_command_line
2929         and previous_saved_command_line.
2930         * main.c (captured_main_1): Remove saved_command_line initialization.
2931         * event-top.c (handle_line_of_input): Update to use
2932         the new 'repeat' related functions instead of direct access to
2933         saved_command_line.
2934         * command.h (repeat_previous, get_saved_command_line,
2935         save_command_line): New declarations.
2936         (dont_repeat): Add comment.
2937
2938 2019-05-30  Tom Tromey  <tromey@adacore.com>
2939
2940         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2941         Fix comment.
2942         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2943
2944 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2945
2946         PR cli/24587
2947         * completer.c (complete): Initialize variable word.
2948
2949 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2950
2951         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2952         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2953         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2954         'body' is NULL to the outter 'if', protecting the '!is_define'
2955         situation as well.
2956
2957 2019-05-29  Tom Tromey  <tromey@adacore.com>
2958
2959         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2960         (dwarf_unknown): New function.
2961         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2962         (dwarf_type_encoding_name): Use dwarf_unknown.
2963
2964 2019-05-29  Tom Tromey  <tromey@adacore.com>
2965
2966         PR c++/20020:
2967         * cp-valprint.c (cp_print_value_fields): Call
2968         cp_print_static_field inside "try".
2969
2970 2019-05-29  Tom Tromey  <tromey@adacore.com>
2971
2972         * inflow.c (struct terminal_info): Add default operator=.
2973         * configure: Rebuild.
2974         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2975         -Wdeprecated-copy-dtor, -Wredundant-move.
2976
2977 2019-05-29  Tom Tromey  <tromey@adacore.com>
2978
2979         * NEWS: Add entry.
2980         * infcmd.c (print_return_value_1): Handle finish_print
2981         option.
2982         (show_print_finish): New function.
2983         (_initialize_infcmd): Add "set/show print finish" commands.
2984         * valprint.c (user_print_options): Initialize new member.
2985         * valprint.h (struct value_print_options) <finish_print>: New
2986         member.
2987
2988 2019-05-28  Tom Tromey  <tromey@adacore.com>
2989
2990         * ada-lang.c (ada_remove_Xbn_suffix)
2991         (find_old_style_renaming_symbol)
2992         (parse_old_style_renaming): Remove.
2993         (ada_find_renaming_symbol): Don't call
2994         find_old_style_renaming_symbol.
2995         (ada_is_renaming_symbol): Rename from
2996         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2997         bool.  Now static.
2998         (ada_read_var_value): Update and simplify.
2999         * ada-exp.y (write_var_or_type): Remove old code.
3000
3001 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3002
3003         * event-top.c: Remove include comment.
3004         * inflow.c (class scoped_ignore_sigttou): Move from here...
3005         * inflow.h (class scoped_ignore_sigttou): ...to here.
3006         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3007         * top.c:  Remove include comment.
3008
3009 2019-05-27  Tom Tromey  <tom@tromey.com>
3010
3011         * NEWS: Fix typo.
3012
3013 2019-05-22  Tom Tromey  <tromey@adacore.com>
3014
3015         * target.c (target_follow_exec): Constify parameter.
3016         * target-delegates.c: Rebuild.
3017         * remote.c (remote_target::follow_exec): Constify parameter.
3018         * infrun.c (follow_exec): Constify parameter.
3019         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3020         (target_follow_exec): Likewise.
3021
3022 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3023
3024         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3025         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3026
3027 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3028
3029         * NEWS: Add debugredirect and testsuite sections.
3030
3031 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3032
3033         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3034         target descriptions using exclusively floating point register name
3035         aliases.
3036
3037 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3038
3039         PR gdb/18644:
3040         * f-lang.c (build_fortran_types): Handle the case where
3041         gdbarch_floatformat_for_type returns a nullptr.
3042
3043 2019-05-21  Tom de Vries  <tdevries@suse.de>
3044
3045         PR cli/24587
3046         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3047
3048 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3049
3050         PR gdb/18644:
3051         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3052         16-byte floats.
3053         * i386-tdep.c (i386_floatformat_for_type): Use
3054         floatformats_ia64_quad for the 16-byte floating point component
3055         within a fortran 32-byte complex number.
3056
3057 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3058
3059         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3060         delete default constructor.
3061         (find_partial_die): Update to return const struct.
3062         (partial_die_parent_scope): Move variable declaration into scope
3063         of its use and change its type to auto.
3064         (guess_partial_die_structure_name): Likewise.
3065         (partial_die_info::fixup): Likewise.
3066
3067 2019-05-17  Tom Tromey  <tromey@adacore.com>
3068
3069         * source.c (find_and_open_source): Remove cast.
3070
3071 2019-05-17  Tom Tromey  <tromey@adacore.com>
3072
3073         * annotate.c (annotate_source): Make "filename" const.
3074         * annotate.h (annotate_source): Use const.
3075
3076 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3077
3078         * disasm.c (set_disassembler_options): Send errors to stderr.
3079
3080 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3081
3082         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3083         (cli_interp_base::set_logging): Check debug_redirect.
3084         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3085         * cli/cli-logging.c (debug_redirect): Add static variable.
3086         (pop_output_files): Add default param.
3087         (handle_redirections): Print debug setting.
3088         (show_logging_command): Likewise.
3089         (_initialize_cli_logging): Add debugredirect command.
3090         * interps.c (current_interp_set_logging): Add debug_redirect
3091         parameter.
3092         * interps.h (set_logging): Add debug_redirect parameter.
3093         (current_interp_set_logging): Likewise.
3094         * mi/mi-common.h: Likewise.
3095         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3096
3097 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3098             Tom Tromey  <tromey@adacore.com>
3099
3100         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3101         directly.
3102         * cli/cli-interp.h (make_logging_output): Remove declaration.
3103         * cli/cli-logging.c (make_logging_output): Remove function.
3104         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3105         directly.
3106         * ui-file.c (tee_file::tee_file): Remove bools.
3107         (tee_file::~tee_file): Remove deletes.
3108         * ui-file.h (tee_file): Remove bools.
3109
3110 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3111
3112         * mi/mi-cmds.h (mi_cmd_complete): New function.
3113         * mi/mi-main.c (mi_cmd_complete): Likewise.
3114         * mi/mi-cmds.c: Define new MI command -complete.
3115         * NEWS: Mention new -complete command.
3116
3117 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3118
3119         * completer.h (complete): New function.
3120         * completer.c (complete): Likewise.
3121         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3122         function defined in completer.h.
3123
3124 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3125
3126         * MAINTAINERS (Write After Approval): Add myself.
3127
3128 2019-05-17  Tom de Vries  <tdevries@suse.de>
3129
3130         PR gdb/24094
3131         * dwarf2read.c (struct cu_partial_die_info): New struct.
3132         (find_partial_die): Return cu_partial_die_info.
3133         (partial_die_parent_scope, guess_partial_die_structure_name)
3134         (partial_die_info::fixup): Handle new return type of find_partial_die.
3135
3136 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3137
3138         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3139         "std::string", simplifying the algorithm.
3140
3141 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3142
3143         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3144         (stap_static_probe_ops::get_probes): Likewise.
3145
3146 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3147
3148         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3149         '-')" and "else if".
3150         (stap_parse_single_operand): Join checks for
3151         "gdbarch_stap_parse_special_token_p" and
3152         "gdbarch_stap_parse_special_token" in the same "if" statement.
3153         Invert check when verifying for operation on register
3154         displacement.
3155
3156 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3157
3158         * stap-probe.c (stap_get_opcode): Update comment.
3159         (stap_get_expected_argument_type): Likewise.
3160         (handle_stap_probe): Likewise.
3161
3162 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3163
3164         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3165         return type to 'bool'.  Adjust comment.  Use 'bool' when
3166         appropriate.
3167         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3168         * stap-probe.c (stap_parse_argument_1): Likewise.
3169         (stap_is_operator): Likewise.
3170         (stap_is_generic_prefix): Likewise.
3171         (stap_is_register_prefix): Likewise.
3172         (stap_is_register_indirection_prefix): Likewise.
3173         (stap_is_integer_prefix): Likewise.
3174         (stap_generic_check_suffix): Likewise.
3175         (stap_check_integer_suffix): Likewise.
3176         (stap_check_register_suffix): Likewise.
3177         (stap_check_register_indirection_suffix): Likewise.
3178         (stap_parse_register_operand): Likewise.
3179         (stap_parse_single_operand): Likewise.
3180         (stap_parse_argument_1): Likewise.
3181         (stap_probe::get_argument_count): Likewise.
3182         (stap_is_operator): Likewise.
3183
3184 2019-05-16  Tom Tromey  <tromey@adacore.com>
3185
3186         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3187         keyword to foreach.
3188
3189 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3190
3191         * linux-thread-db.c (try_thread_db_load_1): Change return type
3192         to bool.
3193         (try_thread_db_load): Likewise.
3194         (try_thread_db_load_from_pdir_1): Likewise.
3195         (try_thread_db_load_from_pdir): Likewise.
3196         (try_thread_db_load_from_sdir): Likewise.
3197         (try_thread_db_load_from_dir): Likewise.
3198         (thread_db_load_search): Likewise.
3199         (has_libpthread): Likewise.
3200         (thread_db_load): Likewise.
3201
3202 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3203
3204         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3205         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3206         NULL, and complain/return if that's the case.
3207
3208 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3209
3210         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3211         (advance, posn, abstract_read_memory): New functions.
3212         [struct mem_read_abstraction]: New struct.
3213         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3214
3215 2019-05-14  Tom Tromey  <tromey@adacore.com>
3216
3217         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3218         value is not lval_memory.
3219
3220 2019-05-14  Tom Tromey  <tromey@adacore.com>
3221
3222         * solib.c (info_sharedlibrary_command): Style the file name.
3223
3224 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3225
3226         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3227         (aarch64_vnv_type): Likewise.
3228         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3229         * common/tdesc.c: Likewise.
3230         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3231         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3232         * features/aarch64-fpu.xml: Add ieee half view.
3233         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3234         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3235         * gdbtypes.h (struct builtin_type): Likewise.
3236         (struct objfile_type): Likewise.
3237
3238 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3239
3240         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3241         typo.
3242         * location.h (string_to_event_location): Likewise.
3243
3244 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3245
3246         GDB 8.3 released.
3247
3248 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3249
3250         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3251         New variable declaration.
3252         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3253         New variable.
3254         (print_one_breakpoint): Use ui_out::test_flags and new global
3255         variable to compute use_fixed_output.
3256         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3257         Remove.
3258         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3259         (mi_multi_location_breakpoint_output_fixed): Remove.
3260         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3261         new variable.
3262         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3263         fix_multi_location_breakpoint_output flag if version >= 3.
3264         * ui-out.h (enum ui_out_flag)
3265         <fix_multi_location_breakpoint_output>: New enumerator.
3266
3267 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3268
3269         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3270
3271 2019-05-10  Tom Tromey  <tromey@adacore.com>
3272
3273         * ada-lang.c (catch_ada_completer): New function.
3274         (_initialize_ada_language): Use it.
3275
3276 2019-05-10  Tom Tromey  <tromey@adacore.com>
3277
3278         * thread.c (print_thread_info): Make "requested_threads" const.
3279         * gdbthread.h (print_thread_info): Make "requested_threads"
3280         const.
3281         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3282         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3283
3284 2019-05-08  Tom Tromey  <tom@tromey.com>
3285
3286         * gdbtypes.c (objfile_type_data): Change type.
3287         (objfile_type, _initialize_gdbtypes): Update.
3288
3289 2019-05-08  Tom Tromey  <tom@tromey.com>
3290
3291         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3292         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3293         (_initialize_dwarf2_frame): Update.
3294
3295 2019-05-08  Tom Tromey  <tom@tromey.com>
3296
3297         * objc-lang.c (objc_objfile_data): Change type.
3298         (find_methods): Update.
3299         (_initialize_objc_lang): Remove.
3300
3301 2019-05-08  Tom Tromey  <tom@tromey.com>
3302
3303         * stabsread.c (rs6000_builtin_type_data): Change type.
3304         (rs6000_builtin_type, _initialize_stabsread): Update.
3305
3306 2019-05-08  Tom Tromey  <tom@tromey.com>
3307
3308         * mips-tdep.c (mips_pdr_data): Remove.
3309         (_initialize_mips_tdep): Update.
3310
3311 2019-05-08  Tom Tromey  <tom@tromey.com>
3312
3313         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3314         (hppa_init_objfile_priv_data, read_unwind_info)
3315         (find_unwind_entry, _initialize_hppa_tdep): Update.
3316
3317 2019-05-08  Tom Tromey  <tom@tromey.com>
3318
3319         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3320         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3321         on obstack.
3322         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3323
3324 2019-05-08  Tom Tromey  <tom@tromey.com>
3325
3326         * mdebugread.c (basic_type_data): Change type.
3327         (basic_type, _initialize_mdebugread): Update.
3328
3329 2019-05-08  Tom Tromey  <tom@tromey.com>
3330
3331         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3332
3333 2019-05-08  Tom Tromey  <tom@tromey.com>
3334
3335         * nto-tdep.c (nto_inferior_data_reg): Change type.
3336         (nto_inferior_data): Update.
3337         (nto_inferior_data_cleanup, nto_new_inferior_data)
3338         (_initialize_nto_tdep): Remove.
3339         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3340
3341 2019-05-08  Tom Tromey  <tom@tromey.com>
3342
3343         * ada-lang.c (struct ada_inferior_data): Add initializers.
3344         (ada_inferior_data): Change type.
3345         (ada_inferior_data_cleanup): Remove.
3346         (get_ada_inferior_data, ada_inferior_exit)
3347         (struct ada_pspace_data): Add initializers, destructor.
3348         (ada_pspace_data_handle): Change type.
3349         (get_ada_pspace_data): Update.
3350         (ada_pspace_data_cleanup): Remove.
3351
3352 2019-05-08  Tom Tromey  <tom@tromey.com>
3353
3354         * coffread.c (struct coff_symfile_info): Add initializers.
3355         (coff_objfile_data_key): Move lower.  Change type.
3356         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3357         Update.
3358         (coff_free_info): Remove.
3359
3360 2019-05-08  Tom Tromey  <tom@tromey.com>
3361
3362         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3363         (fbsd_pspace_data_handle): Move lower.  Change type.
3364         (get_fbsd_pspace_data): Update.
3365         (fbsd_pspace_data_cleanup): Remove.
3366         (_initialize_fbsd_tdep): Update.
3367
3368 2019-05-08  Tom Tromey  <tom@tromey.com>
3369
3370         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3371         (get_ada_tasks_pspace_data): Update.
3372         (ada_tasks_pspace_data_cleanup): Remove.
3373         (_initialize_tasks): Update.
3374         (ada_tasks_inferior_data_handle): Change type.
3375         (get_ada_tasks_inferior_data): Update.
3376         (ada_tasks_inferior_data_cleanup): Remove.
3377         (struct ada_tasks_pspace_data): Add initializers.
3378
3379 2019-05-08  Tom Tromey  <tom@tromey.com>
3380
3381         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3382         * symfile-debug.c (debug_sym_get_probes): Change type.
3383         * stap-probe.c (handle_stap_probe):
3384         (stap_static_probe_ops::get_probes): Change type.
3385         * probe.h (class static_probe_ops) <get_probes>: Change type.
3386         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3387         (parse_probes_in_pspace): Update.
3388         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3389         Update.
3390         (any_static_probe_ops::get_probes): Change type.
3391         * elfread.c (elfread_data): New typedef.
3392         (probe_key): Change type.
3393         (elf_get_probes): Likewise.  Update.
3394         (probe_key_free): Remove.
3395         (_initialize_elfread): Update.
3396         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3397         Change type.
3398         (dtrace_process_dof_probe, dtrace_process_dof)
3399         (dtrace_static_probe_ops::get_probe): Change type.
3400
3401 2019-05-08  Tom Tromey  <tom@tromey.com>
3402
3403         * xcoffread.c (struct xcoff_symfile_info): Rename from
3404         coff_symfile_info.  Add initializers.
3405         (xcoff_objfile_data_key): Move lower.  Change type.
3406         (XCOFF_DATA): Rewrite.
3407         (xcoff_free_info): Remove.
3408         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3409         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3410         (xcoff_initial_scan): Update.
3411
3412 2019-05-08  Tom Tromey  <tom@tromey.com>
3413
3414         * solib-svr4.c (struct svr4_info): Add initializers and
3415         destructor.
3416         <probes_table>: Now an htab_up.
3417         (solib_svr4_pspace_data): Change type.
3418         (free_probes_table): Simplify.
3419         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3420         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3421         (probes_table_remove_objfile_probes, register_solib_event_probe)
3422         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3423         (_initialize_svr4_solib): Update.
3424
3425 2019-05-08  Tom Tromey  <tom@tromey.com>
3426
3427         * remote.c (remote_pspace_data): Change type.
3428         (remote_pspace_data_cleanup): Remove.
3429         (get_remote_exec_file, set_pspace_remote_exec_file)
3430         (_initialize_remote): Update.
3431
3432 2019-05-08  Tom Tromey  <tom@tromey.com>
3433
3434         * breakpoint.c (breakpoint_objfile_key): Change type.
3435         (get_breakpoint_objfile_data): Update.
3436         (free_breakpoint_objfile_data): Remove.
3437         (_initialize_breakpoint): Update.
3438
3439 2019-05-08  Tom Tromey  <tom@tromey.com>
3440
3441         * linux-tdep.c (struct linux_info): Add initializers.
3442         (linux_inferior_data): Move.  Change type.
3443         (invalidate_linux_cache_inf): Update.
3444         (linux_inferior_data_cleanup): Remove.
3445         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3446
3447 2019-05-08  Tom Tromey  <tom@tromey.com>
3448
3449         * auxv.c (auxv_inferior_data): Move.  Change type.
3450         (auxv_inferior_data_cleanup): Remove.
3451         (invalidate_auxv_cache_inf): Rewrite.
3452         (get_auxv_inferior_data, _initialize_auxv): Update.
3453
3454 2019-05-08  Tom Tromey  <tom@tromey.com>
3455
3456         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3457         (symfile_debug_objfile_data_key): Change type.
3458         (symfile_debug_installed, debug_qf_has_symbols)
3459         (debug_qf_find_last_source_symtab)
3460         (debug_qf_forget_cached_source_info)
3461         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3462         (debug_qf_print_stats, debug_qf_dump)
3463         (debug_qf_expand_symtabs_for_function)
3464         (debug_qf_expand_all_symtabs)
3465         (debug_qf_expand_symtabs_with_fullname)
3466         (debug_qf_map_matching_symbols)
3467         (debug_qf_expand_symtabs_matching)
3468         (debug_qf_find_pc_sect_compunit_symtab)
3469         (debug_qf_map_symbol_filenames)
3470         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3471         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3472         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3473         (debug_sym_read_linetable, debug_sym_relocate): Update.
3474         (symfile_debug_free_objfile): Remove.
3475         (install_symfile_debug_logging, _initialize_symfile_debug):
3476         Update.
3477
3478 2019-05-08  Tom Tromey  <tom@tromey.com>
3479
3480         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3481         allocate_on_obstack.
3482         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3483         (get_dwarf2_per_objfile): Update.
3484         (set_dwarf2_per_objfile): Remove.
3485         (dwarf2_has_info, dwarf2_get_section_info): Update.
3486         (dwarf2_free_objfile): Remove.
3487         (_initialize_dwarf2_read): Update.
3488
3489 2019-05-08  Tom Tromey  <tom@tromey.com>
3490
3491         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3492         initializers.
3493         <unsupported_script_warning_printed,
3494         script_not_found_warning_printed>: Now bool.
3495         (auto_load_pspace_data): Change type.
3496         (~auto_load_pspace_info): Rename from
3497         auto_load_pspace_data_cleanup.
3498         (get_auto_load_pspace_data, init_loaded_scripts_info)
3499         (clear_section_scripts, maybe_print_unsupported_script_warning)
3500         (maybe_print_script_not_found_warning, _initialize_auto_load):
3501         Update.
3502
3503 2019-05-08  Tom Tromey  <tom@tromey.com>
3504
3505         * objfiles.c (objfile_pspace_info): Add destructor and
3506         initializers.
3507         (objfiles_pspace_data): Change type.
3508         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3509         (get_objfile_pspace_data): Update.
3510         (objfiles_bfd_data): Change type.
3511         (get_objfile_bfd_data): Update.
3512         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3513
3514 2019-05-08  Tom Tromey  <tom@tromey.com>
3515
3516         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3517         Change type.
3518         (get_catch_syscall_inferior_data): Update.
3519         (catch_syscall_inferior_data_cleanup): Remove.
3520         (_initialize_break_catch_syscall): Update.
3521
3522 2019-05-08  Tom Tromey  <tom@tromey.com>
3523
3524         * inflow.c (struct terminal_info): Add destructor and
3525         initializers.
3526         (inflow_inferior_data): Change type.
3527         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3528         (get_inflow_inferior_data, inflow_inferior_exit)
3529         (swap_terminal_info, _initialize_inflow): Update.
3530
3531 2019-05-08  Tom Tromey  <tom@tromey.com>
3532
3533         * target-dcache.c (target_dcache_cleanup): Remove.
3534         (target_dcache_aspace_key): Change type.
3535         (target_dcache_init_p, target_dcache_invalidate)
3536         (target_dcache_get, target_dcache_get_or_init)
3537         (_initialize_target_dcache): Update.
3538         * dcache.h (struct dcache_deleter): New.
3539
3540 2019-05-08  Tom Tromey  <tom@tromey.com>
3541
3542         * symtab.c (struct symbol_cache): Add destructor and
3543         initializers.
3544         (symbol_cache_key): Move.  Change type.
3545         (make_symbol_cache, free_symbol_cache): Remove.
3546         (get_symbol_cache): Update.
3547         (symbol_cache_cleanup): Remove.
3548         (ALL_PSPACES, symbol_cache_flush)
3549         (maintenance_print_symbol_cache)
3550         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3551         Update.
3552
3553 2019-05-08  Tom Tromey  <tom@tromey.com>
3554
3555         * symtab.c (struct main_info): Add destructor and initializers.
3556         (main_progspace_key): Move.  Change type.
3557         (get_main_info): Update.
3558         (main_info_cleanup): Remove.
3559         (_initialize_symtab): Update.
3560
3561 2019-05-08  Tom Tromey  <tom@tromey.com>
3562
3563         * registry.h (DECLARE_REGISTRY): Define the _key class.
3564
3565 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3566
3567         * NEWS: Merge two 'New commands' sections.
3568
3569 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3570
3571         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3572         parameter and use Ada language definition instead.
3573         (ada_val_print_ptr): Remove unused language parameter.
3574         (ada_val_print_num): Remove language parameter and use Ada language
3575         definition instead.
3576         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3577         parameter.
3578         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3579         parameter and use Ada language definition instead.
3580         (ada_val_print_1): Update all ada_val_print_xxx calls.
3581         Remove language parameter.
3582         (ada_val_print): Update ada_val_print_1 call.
3583
3584 2019-05-08  Tom Tromey  <tromey@adacore.com>
3585
3586         * remote.c (remote_hw_watchpoint_limit)
3587         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3588         Now static.
3589
3590 2019-05-08  Tom Tromey  <tromey@adacore.com>
3591
3592         * maint.c (_initialize_maint_cmds): Move initialization code to
3593         remote.c.
3594         (watchdog, show_watchdog): Move to remote.c.
3595         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3596         "watchdog" static.
3597         (_initialize_remote): Move initialization code from maint.c.
3598         * defs.h (watchdog): Don't declare.
3599
3600 2019-05-08  Tom Tromey  <tromey@adacore.com>
3601
3602         * tui/tui-interp.c: Include main.h.
3603         * interps.c: Include main.h.
3604         * main.h (interpreter_p): Declare.
3605         * defs.h (interpreter_p): Don't declare.
3606
3607 2019-05-08  Tom Tromey  <tromey@adacore.com>
3608
3609         * dwarf2loc.c: Include dwarf2read.h.
3610         * defs.h (read_unsigned_leb128): Don't declare.
3611         * dwarf2read.h (read_unsigned_leb128): Declare.
3612
3613 2019-05-08  Tom Tromey  <tromey@adacore.com>
3614
3615         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3616         method.
3617
3618 2019-05-08  Tom Tromey  <tromey@adacore.com>
3619
3620         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3621         when no wrap column is set.
3622
3623 2019-05-08  Tom Tromey  <tromey@adacore.com>
3624
3625         * c-lang.c (c_get_string): Handle non-C-style arrays.
3626
3627 2019-05-08  Tom Tromey  <tromey@adacore.com>
3628
3629         * typeprint.c (print_offset_data::update): Print the bit offset,
3630         not the number of bits remaining.
3631
3632 2019-05-08  Tom Tromey  <tromey@adacore.com>
3633
3634         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3635         padding at end of comment.
3636
3637 2019-05-08  Tom Tromey  <tromey@adacore.com>
3638
3639         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3640         Compare main types.
3641
3642 2019-05-06  Tom Tromey  <tom@tromey.com>
3643
3644         * common/scoped_mmap.c: Include common-defs.h.
3645         * common/scoped_mmap.h: Don't include config.h.
3646
3647 2019-05-04  Tom Tromey  <tom@tromey.com>
3648
3649         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3650         (struct aarch64_call_info): Add initializers.
3651         <si>: Now a std::vector.
3652         (pass_on_stack, aarch64_push_dummy_call): Update.
3653
3654 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3655             Tom Tromey  <tom@tromey.com>
3656
3657         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3658         (ppc_threads): Now a std::vector.  Now static.
3659         (hwdebug_find_thread_points_by_tid)
3660         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3661         Update.
3662
3663 2019-05-04  Tom Tromey  <tom@tromey.com>
3664
3665         * arc-tdep.c (arc_tdesc_init): Return bool.
3666
3667 2019-05-04  Tom Tromey  <tom@tromey.com>
3668
3669         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3670         Use gdb_assert_not_reached.
3671
3672 2019-05-04  Tom Tromey  <tom@tromey.com>
3673
3674         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3675         "false".
3676
3677 2019-05-04  Tom Tromey  <tom@tromey.com>
3678
3679         * arc-tdep.c (arc_tdesc_init): Use bool.
3680
3681 2019-05-04  Tom Tromey  <tom@tromey.com>
3682
3683         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3684
3685 2019-05-04  Tom Tromey  <tom@tromey.com>
3686
3687         * cli/cli-cmds.c (valid_command_p): Return bool.
3688
3689 2019-05-04  Tom Tromey  <tom@tromey.com>
3690
3691         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3692         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3693
3694 2019-05-04  Raul Tambre  <raul@tambre.ee>
3695
3696         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3697         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3698         operator for comparison.
3699
3700 2019-05-04  Tom Tromey  <tom@tromey.com>
3701
3702         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3703         (lookup_partial_symbol, print_partial_symbols)
3704         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3705         (psymbol_compare): Update.
3706         (add_psymbol_to_bcache): Clear the entire psymbol.
3707         (maintenance_check_psymtabs): Update.
3708         * psympriv.h (struct partial_symbol): Don't derive from
3709         general_symbol_info.
3710         <obj_section, unrelocated_address, address,
3711         set_unrelocated_address>: Update.
3712         <ginfo>: New member.
3713         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3714         (debug_names::write_psymbols): Update.
3715
3716 2019-05-04  Tom de Vries  <tdevries@suse.de>
3717
3718         * contrib/cc-with-tweaks.sh: Support -n arg.
3719
3720 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3721
3722         * corelow.c (core_target::detach): Ensure frame cache and
3723         register caches are cleared.
3724         inferior.c (exit_inferior_1): Likewise.
3725
3726 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3727             Tom Tromey  <tom@tromey.com>
3728
3729         * dictionary.c (collate_pending_symbols_by_language): Remove
3730         "struct" from foreach.
3731         * symtab.c (lookup_global_symbol_from_objfile)
3732         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3733         foreach.
3734         * ser-tcp.c (net_open): Remove "struct" from foreach.
3735         * objfiles.c (objfile_relocate, objfile_rebase)
3736         (objfile_has_symbols): Remove "struct" from foreach.
3737         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3738         from foreach.
3739         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3740         foreach.
3741         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3742         "struct" from foreach.
3743         * ada-lang.c (create_excep_cond_exprs)
3744         (ada_exception_catchpoint_cond_string): Remove "struct" from
3745         foreach.
3746
3747 2019-05-03  Tom Tromey  <tromey@adacore.com>
3748
3749         * ada-exp.y (convert_char_literal): Check suffix of each
3750         enumerator.
3751
3752 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3753
3754         PR ada/21406:
3755         * ada-exp.y (yywrap): Don't define.
3756         * ada-lex.l (%option): Add noyywrap
3757         (yywrap): Remove.
3758
3759 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3760
3761         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3762         _WIN32_WINNT to the XP level, unless already defined to a higher
3763         level.
3764
3765         * unittests/parse-connection-spec-selftests.c:
3766         * ser-tcp.c:
3767         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3768         override.
3769
3770         * symfile.c (find_separate_debug_file): Remove colon from the
3771         drive spec of DOS/Windows file names of the target, so that the
3772         file name produced from DEBUGDIR and the target's directory will
3773         be valid on DOS/Windows systems.
3774
3775 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3776
3777         * rust-lang.c (val_print_struct): Handle printing structures
3778         containing strings.
3779
3780 2019-05-02  Tom Tromey  <tromey@adacore.com>
3781
3782         * valarith.c (_initialize_valarith): Remove.
3783
3784 2019-05-01  Tom Tromey  <tromey@adacore.com>
3785
3786         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3787         bitfields.
3788
3789 2019-05-01  Tom Tromey  <tromey@adacore.com>
3790
3791         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3792         for big-endian copies.
3793
3794 2019-04-30  Ali Tamur  <tamur@google.com>
3795         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3796         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3797         (read_3_bytes): New function.
3798
3799 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3800
3801         * windows-nat.c (main_thread_id): Delete.
3802         (handle_output_debug_string): Replace main_thread_id by
3803         current_event.dwThreadId.
3804         (fake_create_process): Likewise.
3805         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3806         Do not set main_thread_id.
3807         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3808         current_event.dwThreadId.
3809         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3810
3811 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3812
3813         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3814         Use current_event.dwThreadId instead of main_thread_id.
3815
3816 2019-04-30  Tom Tromey  <tromey@adacore.com>
3817
3818         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3819         (create_excep_cond_exprs): Iterate over program spaces.
3820         (ada_exception_catchpoint_cond_string): Examine all minimal
3821         symbols for exception types.
3822
3823 2019-04-30  Tom Tromey  <tromey@adacore.com>
3824
3825         PR c++/24470:
3826         * dwarf2read.c (process_structure_scope): Handle case where type
3827         has template parameters but no symbol was created.
3828
3829 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3830             Chris January  <chris.january@arm.com>
3831
3832         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3833         qualifier.
3834         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3835
3836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3837
3838         * f-typeprint.c (f_print_type): Update rules for printing
3839         whitespace.
3840         (f_type_print_varspec_suffix): Likewise.
3841
3842 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3843             Chris January  <chris.january@arm.com>
3844
3845         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3846         function arguments.
3847
3848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3849
3850         * f-lang.c (build_fortran_types): Change name of void type to
3851         lower case.
3852         * f-typeprint.c (f_type_print_base): Print the name of the void
3853         type, rather than a fixed string.
3854         * f-valprint.c (f_decorations): Use lower case void string.
3855
3856 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3857             Chris January  <chris.january@arm.com>
3858
3859         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3860         types for Fortran.
3861
3862 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3863             Chris January  <chris.january@arm.com>
3864             David Lecomber  <david.lecomber@arm.com>
3865
3866         * f-exp.y (BINOP_INTRINSIC): New token.
3867         (exp): New parser rule handling BINOP_INTRINSIC.
3868         (f77_keywords): Add new builtin procedures.
3869         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3870         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3871         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3872         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3873         (print_unop_subexp_f): New function.
3874         (print_binop_subexp_f): New function.
3875         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3876         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3877         (dump_subexp_body_f): Likewise.
3878         (operator_check_f): Likewise.
3879         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3880         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3881
3882 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3883
3884         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3885         UNOP_KIND.
3886         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3887         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3888         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3889         (operator_length_f): New fuction.
3890         (print_subexp_f): New function.
3891         (op_name_f): New function.
3892         (dump_subexp_body_f): New function.
3893         (operator_check_f): New function.
3894         (exp_descriptor_f): Replace standard expression handling functions
3895         with new functions.
3896         * gdb/fortran-operator.def: New file.
3897         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3898         * gdb/std-operator.def: Remove UNOP_KIND.
3899
3900 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3901
3902         * std-operator.def: Remove unbalanced, stray double quote
3903         character.
3904
3905 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3906             Chris January  <chris.january@arm.com>
3907             Daniel Everett  <daniel.everett@arm.com>
3908             Nick Forrington  <nick.forrington@arm.com>
3909             Richard Bunt  <richard.bunt@arm.com>
3910
3911         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3912         of depth when printing anonymous structs or unions.
3913         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3914         Don't print either the top-level value, or the children if the
3915         max-depth is exceeded.
3916         (ppscm_print_children): When printing the key of a map, allow one
3917         extra level of depth.
3918         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3919         print either the top-level value, or the children if the max-depth
3920         is exceeded.
3921         (print_children): When printing the key of a map, allow one extra
3922         level of depth.
3923         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3924         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3925         (user_print_options): Initialise max_depth field.
3926         (val_print_scalar_or_string_type_p): New function.
3927         (val_print): Check to see if the max depth has been reached.
3928         (val_print_check_max_depth): Define new function.
3929         (show_print_max_depth): New function.
3930         (_initialize_valprint): Add 'print max-depth' option.
3931         * valprint.h (struct value_print_options) <max_depth>: New field.
3932         (val_print_check_max_depth): Declare new function.
3933         * NEWS: Document new feature.
3934
3935 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3936
3937         * ada-lang.c (ada_language_defn): Initialise new field.
3938         * c-lang.c (c_is_string_type_p): New function.
3939         (c_language_defn): Initialise new field.
3940         (cplus_language_defn): Initialise new field.
3941         (asm_language_defn): Initialise new field.
3942         (minimal_language_defn): Initialise new field.
3943         * c-lang.h (c_is_string_type_p): Declare new function.
3944         * d-lang.c (d_language_defn): Initialise new field.
3945         * f-lang.c (f_is_string_type_p): New function.
3946         (f_language_defn): Initialise new field.
3947         * go-lang.c (go_is_string_type_p): New function.
3948         (go_language_defn): Initialise new field.
3949         * language.c (default_is_string_type_p): New function.
3950         (unknown_language_defn): Initialise new field.
3951         (auto_language_defn): Initialise new field.
3952         * language.h (struct language_defn) <la_is_string_type_p>: New
3953         member variable.
3954         (default_is_string_type_p): Declare new function.
3955         * m2-lang.c (m2_language_defn): Initialise new field.
3956         * objc-lang.c (objc_language_defn): Initialise new field.
3957         * opencl-lang.c (opencl_language_defn): Initialise new field.
3958         * p-lang.c (pascal_is_string_type_p): New function.
3959         (pascal_language_defn): Initialise new field.
3960         * rust-lang.c (rust_is_string_type_p): New function.
3961         (rust_language_defn): Initialise new field.
3962
3963 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3964
3965         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3966         New field.
3967         * ada-lang.c (ada_language_defn): Initialise new field.
3968         * c-lang.c (c_language_defn): Likewise.
3969         (cplus_language_defn): Likewise.
3970         (asm_language_defn): Likewise.
3971         (minimal_language_defn): Likewise.
3972         * d-lang.c (d_language_defn): Likewise.
3973         * f-lang.c (f_language_defn): Likewise.
3974         * go-lang.c (go_language_defn): Likewise.
3975         * language.c (unknown_language_defn): Likewise.
3976         (auto_language_defn): Likewise.
3977         * m2-lang.c (m2_language_defn): Likewise.
3978         * objc-lang.c (objc_language_defn): Likewise.
3979         * opencl-lang.c (opencl_language_defn): Likewise.
3980         * p-lang.c (pascal_language_defn): Likewise.
3981         * rust-lang.c (rust_language_defn): Likewise.
3982
3983 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3984
3985         * ada-lang.c (ada_is_character_type): Change return type to bool.
3986         (ada_is_string_type): Likewise.
3987         * ada-lang.h (ada_is_character_type): Update declaration
3988         (ada_is_string_type): Likewise.
3989
3990 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3991
3992         Support style in 'frame|thread apply'
3993
3994         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3995         * record.c (record_start, record_stop): Update callers of
3996         execute_command_to_string with false.
3997         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3998         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3999         methods.
4000         (class string_file): New constructor with term_out parameter.
4001         Override methods term_out and can_emit_style_escape.  New member
4002         term_out.
4003         (class stdio_file): Override can_emit_style_escape.
4004         (class tee_file): Override term_out and can_emit_style_escape.
4005         * utils.h (can_emit_style_escape): Remove.
4006         * utils.c (can_emit_style_escape): Likewise.
4007         Update all callers of can_emit_style_escape (SOMESTREAM) to
4008         SOMESTREAM->can_emit_style_escape.
4009         * source-cache.c (source_cache::get_source_lines): Likewise.
4010         * stack.c (frame_apply_command_count): Call execute_command_to_string
4011         passing the term_out characteristic of the current gdb_stdout.
4012         * thread.c (thr_try_catch_cmd): Likewise.
4013         * top.c (execute_command_to_string): pass term_out parameter
4014         to construct the string_file for the command output.
4015         * ui-file.c (term_cli_styling): New function (most code moved
4016         from utils.c can_emit_style_escape).
4017         (string_file::string_file, string_file::can_emit_style_escape,
4018         stdio_file::can_emit_style_escape, tee_file::term_out,
4019         tee_file::can_emit_style_escape): New functions.
4020
4021 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4022
4023         * NEWS: Mention the new set|show may-call-functions.
4024         * infcall.c (may_call_functions_p): New variable.
4025         (show_may_call_functions_p): New function.
4026         (call_function_by_hand_dummy): Throws an error if not
4027         may-call-functions.
4028         (_initialize_infcall): Call add_setshow_boolean_cmd for
4029         may-call-functions.
4030
4031 2019-04-25  Keith Seitz  <keiths@redhat.com>
4032
4033         PR c++/24367
4034         * cp-support.c (inspect_type): Don't attempt substitutions
4035         of symbol with the same name.
4036
4037 2019-04-25  Tom Tromey  <tromey@adacore.com>
4038
4039         PR gdb/24475:
4040         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4041         static.
4042
4043 2019-04-25  Tom Tromey  <tromey@adacore.com>
4044
4045         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4046         rvalue reference.
4047         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4048         (gdb_xml_parser::parse): Use std::move.
4049         * python/python-internal.h (gdbpy_convert_exception): Take a const
4050         reference.
4051         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4052         std::move.
4053         * python/py-utils.c (gdbpy_convert_exception): Take a const
4054         reference.
4055         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4056         Use std::move.
4057         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4058         Use std::move.
4059         * mi/mi-main.c (mi_print_exception): Take a const reference.
4060         * main.c (handle_command_errors): Take a const reference.
4061         * linespec.c (parse_linespec): Use std::move.
4062         * infcall.c (run_inferior_call): Use std::move.
4063         (call_function_by_hand_dummy): Use std::move.
4064         * exec.c (try_open_exec_file): Use std::move.
4065         * exceptions.h (exception_print, exception_fprintf)
4066         (exception_print_same): Update.
4067         * exceptions.c (print_exception, exception_print)
4068         (exception_fprintf, exception_print_same): Change parameters to
4069         const reference.
4070         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4071         * common/new-op.c: Use std::move.
4072         * common/common-exceptions.h (struct gdb_exception): Add move
4073         constructor.
4074         (struct gdb_exception_error, struct gdb_exception_quit, struct
4075         gdb_quit_bad_alloc): Change constructor to move constructor.
4076         (throw_exception): Change parameter to rvalue reference.
4077         * common/common-exceptions.c (throw_exception): Take rvalue
4078         reference.
4079         * cli/cli-interp.c (safe_execute_command): Use std::move.
4080         * breakpoint.c (insert_bp_location, location_to_sals): Use
4081         std::move.
4082
4083 2019-04-25  Tom Tromey  <tromey@adacore.com>
4084
4085         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4086         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4087         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4088         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4089         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4090         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4091         guile/scm-value.c: Use unpack.
4092         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4093         gdbscm_gdb_exception.
4094         (gdbscm_throw_gdb_exception): Likewise.
4095         (struct gdbscm_gdb_exception): New.
4096         (unpack): New function.
4097         (gdbscm_wrap): Use unpack.
4098
4099 2019-04-25  Tom Tromey  <tromey@adacore.com>
4100
4101         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4102         (gdb_rl_callback_handler): Use std::move.
4103         * common/common-exceptions.h (struct gdb_exception): Add move
4104         assignment operator.
4105         (throw_exception_sjlj): Change "exception" to const reference.
4106         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4107         (throw_exception_sjlj): Change "exception" to const reference.
4108
4109 2019-04-25  Tom Tromey  <tromey@adacore.com>
4110
4111         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4112         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4113         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4114         Update.
4115         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4116         Update.
4117         * mi/mi-interp.c (mi_interp::exec): Update.
4118         * linespec.c (parse_linespec): Update.
4119         * infcall.c (run_inferior_call): Update.
4120         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4121         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4122         (gdbscm_lookup_global_symbol): Update.
4123         * guile/scm-param.c (gdbscm_parameter_value): Update.
4124         * guile/scm-frame.c (gdbscm_frame_read_register)
4125         (gdbscm_frame_read_var): Update.
4126         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4127         * exec.c (try_open_exec_file): Update.
4128         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4129         (gdb_rl_callback_handler): Update.
4130         * common/common-exceptions.h (exception_none): Don't declare.
4131         * common/common-exceptions.c (exception_none): Don't define.
4132         (struct catcher) <exception>: Update.
4133         * cli/cli-interp.c (safe_execute_command): Update.
4134         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4135
4136 2019-04-25  Ali Tamur  <tamur@google.com>
4137
4138         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4139         (read_attribute_value): Likewise.
4140         (dwarf2_read_addr_index): Update comment.
4141         (read_str_index): Add DW_FORM_strx.
4142         (dwarf2_string_attr): Likewise.
4143         (dwarf2_const_value_attr): Likewise.
4144         (dump_die_shallow): Likewise.
4145         (dwarf2_fetch_constant_bytes): Likewise.
4146         (skip_form_bytes): Likewise.
4147         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4148
4149 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4150
4151         PR corefiles/11608
4152         PR corefiles/18187
4153         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4154         OFFSET.  Verify if current mapping contains an ELF header.
4155         (linux_find_memory_regions_full): Adjust call to
4156         dump_mapping_p.
4157
4158 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4159             Kang Li <kanglictf@gmail.com>
4160
4161         PR gdb/21600
4162
4163         * dwarf2-frame.c (read_initial_length): Be consistent about using
4164         unsigned representation of length.
4165         (decode_frame_entry_1): Likewise.  Check for wraparound of
4166         end pointer as well as buffer overflow.
4167
4168 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4169
4170         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4171         "vq".
4172
4173 2019-04-24  Tom Tromey  <tromey@adacore.com>
4174
4175         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4176
4177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4178
4179         * s12z-tdep.c (s12z_unwind_pc): Delete.
4180         (s12z_unwind_sp): Delete.
4181         (s12z_gdbarch_init): Don't register deleted functions with
4182         gdbarch.
4183
4184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4185
4186         * rl78-tdep.c (rl78_unwind_sp): Delete.
4187         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4188
4189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4190
4191         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4192         (xstormy16_unwind_pc): Delete.
4193         (xstormy16_dummy_id): Delete.
4194         (xstormy16_gdbarch_init): Don't register deleted functions with
4195         gdbarch.
4196
4197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4198
4199         * vax-tdep.c (vax_unwind_pc): Delete.
4200         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4201
4202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4203
4204         * v850-tdep.c (v850_unwind_sp): Delete.
4205         (v850_unwind_pc): Delete.
4206         (v850_dummy_id): Delete.
4207         (v850_gdbarch_init): Don't register deleted functions with
4208         gdbarch.
4209
4210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4211
4212         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4213         (tilegx_unwind_pc): Delete.
4214         (tilegx_unwind_dummy_id): Delete.
4215         (tilegx_gdbarch_init): Don't register deleted functions with
4216         gdbarch.
4217
4218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4219
4220         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4221         (tic6x_dummy_id): Delete.
4222         (tic6x_gdbarch_init): Don't register deleted functions with
4223         gdbarch.
4224
4225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4226
4227         * sparc-tdep.c (sparc_unwind_pc): Delete.
4228         (sparc32_gdbarch_init): Don't register deleted function with
4229         gdbarch.
4230
4231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4232
4233         * sh-tdep.c (sh_unwind_sp): Delete.
4234         (sh_unwind_pc): Delete.
4235         (sh_dummy_id): Delete.
4236         (sh_gdbarch_init): Don't register deleted functions with
4237         gdbarch.
4238
4239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4240
4241         * score-tdep.c (score_unwind_sp): Delete.
4242         (score_unwind_pc): Delete.
4243         (score_dummy_id): Delete.
4244         (score_gdbarch_init): Don't register deleted functions with
4245         gdbarch.
4246
4247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4248
4249         * rx-tdep.c (rx_unwind_pc): Delete.
4250         (rx_unwind_sp): Delete.
4251         (rx_dummy_id): Delete.
4252         (rx_gdbarch_init): Don't register deleted functions with
4253         gdbarch.  Update comment.
4254
4255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4256
4257         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4258         (rs6000_dummy_id): Delete.
4259         (rs6000_gdbarch_init): Don't register deleted functions with
4260         gdbarch.
4261
4262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4263
4264         * or1k-tdep.c (or1k_dummy_id): Delete.
4265         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4266
4267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4268
4269         * nios2-tdep.c (nios2_dummy_id): Delete.
4270         (nios2_unwind_sp): Delete.
4271         (nios2_gdbarch_init): Don't register deleted functions with
4272         gdbarch.
4273
4274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4275
4276         * nds32-tdep.c (nds32_dummy_id): Delete.
4277         (nds32_unwind_pc): Delete.
4278         (nds32_unwind_sp): Delete.
4279         (nds32_gdbarch_init): Don't register deleted functions with
4280         gdbarch.
4281
4282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4283
4284         * msp430-tdep.c (msp430_unwind_pc): Delete.
4285         (msp430_unwind_sp): Delete.
4286         (msp430_dummy_id): Delete.
4287         (msp430_gdbarch_init): Don't register deleted functions with
4288         gdbarch.
4289
4290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * moxie-tdep.c (moxie_unwind_sp): Delete.
4293         (moxie_unwind_pc): Delete.
4294         (moxie_dummy_id): Delete.
4295         (moxie_gdbarch_init): Don't register deleted functions with
4296         gdbarch.
4297
4298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4299
4300         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4301         (mn10300_unwind_pc): Delete.
4302         (mn10300_unwind_sp): Delete.
4303         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4304         mn10300_unwind_sp.
4305         (mn10300_frame_unwind_init): Don't register deleted functions with
4306         gdbarch.
4307
4308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4309
4310         * mep-tdep.c (mep_unwind_pc): Delete.
4311         (mep_unwind_sp): Delete.
4312         (mep_dummy_id): Delete.
4313         (mep_gdbarch_init): Don't register deleted functions with
4314         gdbarch.
4315
4316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4317
4318         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4319         (m68hc11_unwind_sp): Delete.
4320         (m68hc11_gdbarch_init): Don't register deleted functions with
4321         gdbarch.
4322
4323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4324
4325         * m32r-tdep.c (m32r_unwind_sp): Delete.
4326         (m32r_unwind_pc): Delete.
4327         (m32r_dummy_id): Delete.
4328         (m32r_gdbarch_init): Don't register deleted functions with
4329         gdbarch.
4330
4331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4332
4333         * m32c-tdep.c (m32c_unwind_pc): Delete.
4334         (m32c_unwind_sp): Delete.
4335         (m32c_dummy_id): Delete.
4336         (m32c_gdbarch_init): Don't register deleted functions with
4337         gdbarch.
4338
4339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4340
4341         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4342         (lm32_unwind_pc): Delete.
4343         (lm32_dummy_id): Delete.
4344         (lm32_gdbarch_init): Don't register deleted functions with
4345         gdbarch.
4346
4347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4348
4349         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4350         (iq2000_unwind_pc): Delete.
4351         (iq2000_dummy_id): Delete.
4352         (iq2000_gdbarch_init): Don't register deleted functions with
4353         gdbarch.
4354
4355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * nds32-tdep.c (nds32_type_align): Delete.
4358         (nds32_push_dummy_call): Use type_align instead.
4359
4360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4361
4362         * arm-tdep.c (arm_type_align): Only handle vector override case.
4363         (arm_push_dummy_call): Use type_align.
4364         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4365
4366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4367
4368         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4369         case.
4370         (pass_on_stack): Use type_align.
4371         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4372         function.
4373
4374 2019-04-23  Tom Tromey  <tromey@adacore.com>
4375
4376         * dwarf2read.c (line_header::file_name_at): Remove unused
4377         overload.
4378
4379 2019-04-23  Tom de Vries  <tdevries@suse.de>
4380
4381         PR gdb/24438
4382         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4383         invocation.
4384
4385
4386 2019-03-27  Ali Tamur  <tamur@google.com>
4387
4388         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4389         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4390         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4391         (dwarf_expr_context::get_addr_index): Likewise
4392         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4393         (symbol_needs_eval_context::get_addr_index): Likewise
4394         (disassemble_dwarf_expression): Add DW_OP_addrx
4395         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4396         (read_cutu_die_from_dwo): Update comment
4397         (skip_one_die): Add DW_FORM_addrx
4398         (read_attribute_value): Likewise
4399         (var_decode_location): Add DW_OP_addrx
4400         (dwarf2_const_value_attr): Add DW_FORM_addrx
4401         (dump_die_shallow): Likewise
4402         (dwarf2_fetch_constant_bytes): Likewise
4403         (decode_locdesc): Add DW_OP_addrx
4404         (skip_form_bytes): Add DW_FORM_addrx
4405
4406 2019-04-22  Ali Tamur  <tamur@google.com>
4407
4408         * MAINTAINERS (Write After Approval): Add self.
4409
4410 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4411
4412         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4413         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4414         (open_symbol_file_object): Likewise.
4415         (svr4_default_sos): Add info parameter.
4416         (svr4_read_so_list): Likewise.
4417         (svr4_current_sos_direct): Adjust functions calls to pass down
4418         info.
4419         (svr4_current_sos_1): Add info parameter.
4420         (svr4_current_sos): Call get_svr4_info, pass info down to
4421         svr4_current_sos_1.
4422         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4423         get_svr4_info.
4424         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4425         get_svr4_info.
4426         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4427         to get_svr4_info.
4428         (probes_table_remove_objfile_probes): Likewise.
4429         (register_solib_event_probe): Add info parameter.
4430         (solist_update_incremental): Pass info parameter down to
4431         svr4_read_so_list.
4432         (disable_probes_interface): Add info parameter.
4433         (svr4_handle_solib_event): Pass current_program_space to
4434         get_svr4_info.  Adjust disable_probes_interface cleanup.
4435         (svr4_create_probe_breakpoints): Add info parameter, pass it
4436         down to register_solib_event_probe.
4437         (svr4_create_solib_event_breakpoints): Add info parameter,
4438         pass it down to svr4_create_probe_breakpoints.
4439         (enable_break): Pass info down to
4440         svr4_create_solib_event_breakpoints.
4441         (svr4_solib_create_inferior_hook): Pass current_program_space to
4442         get_svr4_info.
4443         (svr4_clear_solib): Likewise.
4444
4445 2019-04-22  Pedro Alves  <palves@redhat.com>
4446
4447         * solib-svr4.c (svr4_free_objfile_observer): New.
4448         (probe_and_action::objfile): New field.
4449         (probes_table_htab_remove_objfile_probes)
4450         (probes_table_remove_objfile_probes): New functions.
4451         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4452         in the new probe_and_action.  Don't store the probe in 'lookup'.
4453         (svr4_create_probe_breakpoints): Pass objfile to
4454         register_solib_event_probe.
4455         (_initialize_svr4_solib): Register a free_objfile observer.
4456
4457 2019-04-19  Tom Tromey  <tom@tromey.com>
4458
4459         * common/queue.h: Remove.
4460
4461 2019-04-19  Tom Tromey  <tom@tromey.com>
4462
4463         * event-loop.c: Don't include "common/queue.h".
4464
4465 2019-04-19  Tom Tromey  <tom@tromey.com>
4466
4467         * remote.c (remote_target): Use delete.
4468         * remote-notif.h: Include <list>, not "common/queue.h".
4469         (notif_client_p): Remove typedef.
4470         (remote_notif_state): Add constructor, destructor, initializer.
4471         <notif_queue>: Now a std::list.
4472         (remote_notif_state_xfree): Don't declare.
4473         * remote-notif.c (remote_notif_process, handle_notification)
4474         (remote_notif_state_allocate): Update.
4475         (~remote_notif_state): Rename from remote_notif_state_xfree.
4476
4477 2019-04-19  Tom Tromey  <tom@tromey.com>
4478
4479         * symfile.c (reread_symbols): Update.
4480         * objfiles.c (objfile_register_static_link)
4481         (objfile_lookup_static_link): Update
4482         (~objfile) Don't delete static_links.
4483         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4484
4485 2019-04-19  Tom Tromey  <tom@tromey.com>
4486
4487         * type-stack.h (struct type_stack) <insert>: Constify string.
4488         * type-stack.c (type_stack::insert): Constify string.
4489         * gdbtypes.h (lookup_template_type): Update.
4490         (address_space_name_to_int): Update.
4491         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4492         const.
4493         (lookup_template_type): Make name const.
4494         * c-exp.y: Update rules.
4495         (lex_one_token, classify_name, classify_inner_name)
4496         (c_print_token): Update.
4497         * p-exp.y: Update rules.
4498         (yylex): Update.
4499         * f-exp.y: Update rules.
4500         (yylex): Update.
4501         * d-exp.y: Update rules.
4502         (lex_one_token, classify_name, classify_inner_name): Update.
4503         * parse.c (write_dollar_variable, copy_name): Return std::string.
4504         * parser-defs.h (copy_name): Change return type.
4505         * m2-exp.y: Update rules.
4506         (yylex): Update.
4507         * go-exp.y (lex_one_token): Update.
4508         Update rules.
4509         (classify_unsafe_function, classify_packaged_name)
4510         (classify_name, yylex): Update.
4511
4512 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4513
4514         * configure.ac: add --enable-source-highlight switch.
4515         * configure: Regenerate.
4516         * top.c (print_gdb_version): plumb --enable-source-highlight
4517         status to "show configuration".
4518
4519 2019-04-19  Tom Tromey  <tromey@adacore.com>
4520
4521         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4522         Check ADA_TYPE_P.
4523         (empty_record, ada_template_to_fixed_record_type_1)
4524         (template_to_static_fixed_type)
4525         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4526         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4527         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4528         macros.
4529
4530 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4531
4532         PR symtab/24423:
4533         * source.c (print_source_lines_base): Advance "iter" when a
4534         control character is seen.
4535
4536 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4537
4538         * inferior.h (struct infcall_suspend_state_deleter):
4539         Catch exception in destructor to avoid crash.
4540
4541 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4542
4543         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4544         close to the add_com "shell".
4545
4546 2019-04-18  Tom Tromey  <tromey@adacore.com>
4547
4548         * process-stratum-target.h (class process_stratum_target)
4549         <stratum>: Add "final".
4550
4551 2019-04-17  Tom Tromey  <tromey@adacore.com>
4552
4553         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4554         against nullptr before use.
4555
4556 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4557
4558         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4559
4560 2019-04-17  Jim Wilson  <jimw@sifive.com>
4561             Andrew Burgess  <andrew.burgess@embecosm.com>
4562
4563         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4564         code read might fail, assume 4-byte breakpoint in that case.
4565
4566 2019-04-15  Leszek Swirski  <leszeks@google.com>
4567
4568         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4569         rather than a hand-rolled POD check when checking for forced MEMORY
4570         classification.
4571
4572 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4573
4574         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4575         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4576         function.
4577         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4578         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4579         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4580         declaration.
4581
4582 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4583
4584         * aarch64-linux-nat.c
4585         (aarch64_linux_nat_target::thread_architecture): Add override.
4586         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4587         each VQ.
4588
4589 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4590
4591         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4592
4593 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4596         target types of size 96-bits, add some additional comments, and
4597         check that the builtin type we found was the correct size.
4598
4599 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4600
4601         * utils.c (prompt_for_continue): Don't restore the styling at the
4602         end, as applied_style has the wrong value.  This fixes styling in
4603         long lists of file names that are interrupted by the "Continue?"
4604         prompt.
4605
4606 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4607
4608         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4609         * c-lang.c (c_language_defn): Likewise.
4610         (cplus_language_defn): Likewise.
4611         (asm_language_defn): Likewise.
4612         (minimal_language_defn): Likewise.
4613         * d-lang.c (d_language_defn): Likewise.
4614         * f-lang.c (f_language_defn): Likewise.
4615         * go-lang.c (go_language_defn): Likewise.
4616         * language.c (unknown_language_defn): Likewise.
4617         (auto_language_defn): Likewise.
4618         * language.h (struct language_defn): Remove la_magic field.
4619         (LANG_MAGIC): Delete.
4620         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4621         * objc-lang.c (objc_language_defn): Likewise.
4622         * opencl-lang.c (opencl_language_defn): Likewise.
4623         * p-lang.c (pascal_language_defn): Likewise.
4624         * rust-lang.c (rust_language_defn): Likewise.
4625
4626 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4627
4628         * riscv-tdep.c (riscv_type_align): New function.
4629         (riscv_type_alignment): Delete.
4630         (riscv_arg_location): Use 'type_align'.
4631         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4632
4633 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4634
4635         * gdbtypes.c (type_align): A struct with no non-static fields also
4636         has alignment of 1.
4637
4638 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4639
4640         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4641         component to 0.
4642         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4643         member.
4644         (riscv_struct_info::analyse): New implementation using new
4645         analyse_inner member function.
4646         (riscv_struct_info::field_offset): New member function.
4647         (riscv_struct_info::m_offsets): New member variable.
4648         (riscv_struct_info::analyse_inner): New private member function,
4649         takes the old implementation of riscv_struct_info::analyse but
4650         extended to track field offsets.
4651         (riscv_call_arg_struct): Update the struct folding special cases
4652         to handle cases where empty C++ structs, which are non-zero
4653         length, are found.
4654         (riscv_arg_location): Initialise the length of each location, a
4655         non-zero length now indicates the location is in use.
4656         (riscv_push_dummy_call): Allow for the first location having a
4657         non-zero offset when setting up arguments.
4658         (riscv_return_value): Likewise, but for return values.
4659
4660 2019-04-11  Tom Tromey  <tromey@adacore.com>
4661
4662         * utils.c (internal_vproblem): Make "msg" const.
4663
4664 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4665
4666         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4667         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4668         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4669         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4670
4671 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4672
4673         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4674         function.
4675         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4676         of amd64_collect_native_gregset.
4677         (amd64_linux_nat_target::store_registers): Likewise.
4678
4679 2019-04-10  Tom Tromey  <tom@tromey.com>
4680
4681         * symtab.c (lookup_global_symbol_from_objfile)
4682         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4683         * objfiles.h (class separate_debug_iterator): New.
4684         (class separate_debug_range): New.
4685         (struct objfile) <separate_debug_objfiles>: New method.
4686         (objfile_separate_debug_iterate): Don't declare.
4687         * objfiles.c (separate_debug_iterator::operator++): Rename from
4688         objfile_separate_debug_iterate.
4689         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4690         iterator.
4691         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4692         iterator.
4693
4694 2019-04-10  Tom Tromey  <tom@tromey.com>
4695
4696         * symfile.c (reread_symbols): Remove old comment.
4697         * objfiles.c (free_all_objfiles): Fix a typo.
4698
4699 2019-04-10  Tom Tromey  <tom@tromey.com>
4700
4701         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4702         * minsyms.c (lookup_minimal_symbol): Use foreach.
4703         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4704         (lookup_minimal_symbol_solib_trampoline): Likewise.
4705         * symfile.c (reread_symbols): Use foreach.
4706
4707 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4708             Tom Tromey  <tromey@adacore.com>
4709
4710         PR rust/24414:
4711         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4712         (rust_lex_int_test): Change "value" to be LONGEST.
4713         (rust_lex_tests): Add test for long integer literal.
4714
4715 2019-04-09  Tom Tromey  <tromey@adacore.com>
4716
4717         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4718         to bool.
4719         (extended_remote_target::attach): Update.
4720         (remote_target::remote_notice_new_inferior): Update.
4721         (remote_target::add_current_inferior_and_thread): Update.
4722         * inferior.c (exit_inferior_1): Use "false".
4723         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4724
4725 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4726
4727         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4728         the "start" command.
4729
4730 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4731
4732         * python/py-inferior.c (infpy_thread_from_thread_handle):
4733         Adjust comments to reflect renaming of thread_from_thread_handle
4734         to thread_from_handle.  Adjust keywords.  Fix type error message.
4735         (inferior_object_methods): Add thread_from_handle.  Retain
4736         thread_from_thread_handle, but mark it as deprecated.
4737
4738 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4739
4740         * gdbthread.h (find_thread_by_handle): Revise declaration.
4741         * thread.c (find_thread_by_handle): Likewise.  Adjust
4742         implementation too.
4743         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4744         support for buffer objects as handles.
4745
4746 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4747
4748         * python/py-infthread.c (thpy_thread_handle): New function.
4749         (thread_object_methods): Register thpy_thread_handle.
4750
4751 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4752
4753         * gdbthread.h (thread_to_thread_handle): Declare.
4754         * thread.c (gdbtypes.h): Include.
4755         (thread_to_thread_handle): New function.
4756
4757         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4758         (target_thread_info_to_thread_handle): Declare.
4759         * target.c (target_thread_info_to_thread_handle): New function.
4760         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4761         * target-delegates.c: Regenerate.
4762
4763         * linux-thread-db.c (class thread_db_target): Add method
4764         thread_info_to_thread_handle.
4765         (thread_db_target::thread_info_to_thread_handle): Define.
4766         * remote.c (class remote_target): Add new method
4767         thread_info_to_thread_handle.
4768         (remote_target::thread_info_to_thread_handle): Define.
4769
4770 2019-04-08  Pedro Alves  <palves@redhat.com>
4771
4772         * common/common-exceptions.c (throw_exception): Don't create
4773         named object to throw; throw directly.
4774         (throw_it): Likewise.  Don't initialize gdb_exception::message
4775         here, with new; pass FMT and AP to the ctor instead.
4776         * common/common-exceptions.h: Include <string>.
4777         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4778         const char *, va_list)): New ctor.  Use std::make_shared.
4779         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4780         errors)): Delete.
4781         (gdb_exception_error::gdb_exception_error(enum errors, const char
4782         *, va_list)): New.
4783         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4784         Add assertion.
4785         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4786         errors)): Delete.
4787         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4788         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4789         Add assertion.
4790
4791 2019-04-08  Tom Tromey  <tom@tromey.com>
4792
4793         * valops.c (value_rtti_indirect_type): Replace throw_exception
4794         with throw.
4795         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4796         with throw.
4797         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4798         throw.
4799         * target.c (target_translate_tls_address): Replace throw_exception
4800         with throw.
4801         * stack.c (frame_apply_command_count): Replace throw_exception
4802         with throw.
4803         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4804         throw.
4805         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4806         with throw.
4807         * rs6000-tdep.c (rs6000_frame_cache)
4808         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4809         * remote.c: Replace throw_exception with throw.
4810         * record-full.c (record_full_message, record_full_wait_1)
4811         (record_full_restore): Replace throw_exception with throw.
4812         * record-btrace.c:
4813         (get_thread_current_frame_id, record_btrace_start_replaying)
4814         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4815         (cmd_record_btrace_start): Replace throw_exception with throw.
4816         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4817         throw.
4818         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4819         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4820         * linespec.c:
4821         (find_linespec_symbols): Replace throw_exception with throw.
4822         * infrun.c (displaced_step_prepare, resume): Replace
4823         throw_exception with throw.
4824         * infcmd.c (post_create_inferior): Replace throw_exception with
4825         throw.
4826         * inf-loop.c (inferior_event_handler): Replace throw_exception
4827         with throw.
4828         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4829         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4830         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4831         (get_prev_frame_always, get_frame_pc_if_available)
4832         (get_frame_address_in_block_if_available, get_frame_language):
4833         Replace throw_exception with throw.
4834         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4835         throw_exception with throw.
4836         * eval.c (fetch_subexp_value, evaluate_var_value)
4837         (evaluate_funcall, evaluate_subexp_standard): Replace
4838         throw_exception with throw.
4839         * dwarf2loc.c (call_site_find_chain)
4840         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4841         Replace throw_exception with throw.
4842         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4843         with throw.
4844         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4845         throw.
4846         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4847         * completer.c (complete_line_internal): Replace throw_exception
4848         with throw.
4849         * compile/compile-object-run.c (compile_object_run): Replace
4850         throw_exception with throw.
4851         * cli/cli-script.c (process_next_line): Replace throw_exception
4852         with throw.
4853         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4854         (btrace_enable, btrace_maint_update_pt_packets): Replace
4855         throw_exception with throw.
4856         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4857         throw_exception with throw.
4858         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4859         throw_exception with throw.
4860         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4861         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4862         * aarch64-tdep.c (aarch64_make_prologue_cache)
4863         (aarch64_make_stub_cache): Replace throw_exception with throw.
4864
4865 2019-04-08  Tom Tromey  <tom@tromey.com>
4866
4867         * common/common-exceptions.c (throw_exception): Rename from
4868         throw_exception_cxx.  Remove old copy.  Make argument const.
4869         (throw_it): Create and throw exception objects directly.
4870         * common/common-exceptions.h (throw_exception): Make argument
4871         const.
4872         (struct gdb_exception_error): Add constructor.
4873         (struct gdb_exception_quit): Add constructor.
4874
4875 2019-04-08  Tom Tromey  <tom@tromey.com>
4876
4877         * common/common-exceptions.h (exception_rethrow): Don't declare.
4878         (TRY_SJLJ): Update comment.
4879         (TRY, CATCH, END_CATCH): Remove.
4880         * common/common-exceptions.c (exception_rethrow): Remove.
4881
4882 2019-04-08  Tom Tromey  <tom@tromey.com>
4883
4884         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4885         Remove.
4886         (gdb_exception_error): Rename from
4887         gdb_exception_RETURN_MASK_ERROR.
4888         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4889         (gdb_quit_bad_alloc): Update.
4890         * aarch64-tdep.c: Update.
4891         * ada-lang.c: Update.
4892         * ada-typeprint.c: Update.
4893         * ada-valprint.c: Update.
4894         * amd64-tdep.c: Update.
4895         * arch-utils.c: Update.
4896         * break-catch-throw.c: Update.
4897         * breakpoint.c: Update.
4898         * btrace.c: Update.
4899         * c-varobj.c: Update.
4900         * cli/cli-cmds.c: Update.
4901         * cli/cli-interp.c: Update.
4902         * cli/cli-script.c: Update.
4903         * common/common-exceptions.c: Update.
4904         * common/new-op.c: Update.
4905         * common/selftest.c: Update.
4906         * compile/compile-c-symbols.c: Update.
4907         * compile/compile-cplus-symbols.c: Update.
4908         * compile/compile-object-load.c: Update.
4909         * compile/compile-object-run.c: Update.
4910         * completer.c: Update.
4911         * corelow.c: Update.
4912         * cp-abi.c: Update.
4913         * cp-support.c: Update.
4914         * cp-valprint.c: Update.
4915         * darwin-nat.c: Update.
4916         * disasm-selftests.c: Update.
4917         * dtrace-probe.c: Update.
4918         * dwarf-index-cache.c: Update.
4919         * dwarf-index-write.c: Update.
4920         * dwarf2-frame-tailcall.c: Update.
4921         * dwarf2-frame.c: Update.
4922         * dwarf2loc.c: Update.
4923         * dwarf2read.c: Update.
4924         * eval.c: Update.
4925         * event-loop.c: Update.
4926         * event-top.c: Update.
4927         * exec.c: Update.
4928         * f-valprint.c: Update.
4929         * fbsd-tdep.c: Update.
4930         * frame-unwind.c: Update.
4931         * frame.c: Update.
4932         * gdbtypes.c: Update.
4933         * gnu-v3-abi.c: Update.
4934         * guile/guile-internal.h: Update.
4935         * guile/scm-block.c: Update.
4936         * guile/scm-breakpoint.c: Update.
4937         * guile/scm-cmd.c: Update.
4938         * guile/scm-disasm.c: Update.
4939         * guile/scm-frame.c: Update.
4940         * guile/scm-lazy-string.c: Update.
4941         * guile/scm-math.c: Update.
4942         * guile/scm-param.c: Update.
4943         * guile/scm-ports.c: Update.
4944         * guile/scm-pretty-print.c: Update.
4945         * guile/scm-symbol.c: Update.
4946         * guile/scm-symtab.c: Update.
4947         * guile/scm-type.c: Update.
4948         * guile/scm-value.c: Update.
4949         * i386-linux-tdep.c: Update.
4950         * i386-tdep.c: Update.
4951         * inf-loop.c: Update.
4952         * infcall.c: Update.
4953         * infcmd.c: Update.
4954         * infrun.c: Update.
4955         * jit.c: Update.
4956         * language.c: Update.
4957         * linespec.c: Update.
4958         * linux-fork.c: Update.
4959         * linux-nat.c: Update.
4960         * linux-tdep.c: Update.
4961         * linux-thread-db.c: Update.
4962         * main.c: Update.
4963         * mi/mi-cmd-break.c: Update.
4964         * mi/mi-cmd-stack.c: Update.
4965         * mi/mi-interp.c: Update.
4966         * mi/mi-main.c: Update.
4967         * objc-lang.c: Update.
4968         * p-valprint.c: Update.
4969         * parse.c: Update.
4970         * ppc-linux-tdep.c: Update.
4971         * printcmd.c: Update.
4972         * python/py-arch.c: Update.
4973         * python/py-breakpoint.c: Update.
4974         * python/py-cmd.c: Update.
4975         * python/py-finishbreakpoint.c: Update.
4976         * python/py-frame.c: Update.
4977         * python/py-framefilter.c: Update.
4978         * python/py-gdb-readline.c: Update.
4979         * python/py-inferior.c: Update.
4980         * python/py-infthread.c: Update.
4981         * python/py-lazy-string.c: Update.
4982         * python/py-linetable.c: Update.
4983         * python/py-objfile.c: Update.
4984         * python/py-param.c: Update.
4985         * python/py-prettyprint.c: Update.
4986         * python/py-progspace.c: Update.
4987         * python/py-record-btrace.c: Update.
4988         * python/py-record.c: Update.
4989         * python/py-symbol.c: Update.
4990         * python/py-type.c: Update.
4991         * python/py-unwind.c: Update.
4992         * python/py-utils.c: Update.
4993         * python/py-value.c: Update.
4994         * python/python.c: Update.
4995         * record-btrace.c: Update.
4996         * record-full.c: Update.
4997         * remote-fileio.c: Update.
4998         * remote.c: Update.
4999         * riscv-tdep.c: Update.
5000         * rs6000-aix-tdep.c: Update.
5001         * rs6000-tdep.c: Update.
5002         * rust-exp.y: Update.
5003         * rust-lang.c: Update.
5004         * s390-tdep.c: Update.
5005         * selftest-arch.c: Update.
5006         * solib-dsbt.c: Update.
5007         * solib-frv.c: Update.
5008         * solib-spu.c: Update.
5009         * solib-svr4.c: Update.
5010         * solib.c: Update.
5011         * sparc64-linux-tdep.c: Update.
5012         * stack.c: Update.
5013         * symfile-mem.c: Update.
5014         * symmisc.c: Update.
5015         * target.c: Update.
5016         * thread.c: Update.
5017         * top.c: Update.
5018         * tracefile-tfile.c: Update.
5019         * tui/tui.c: Update.
5020         * typeprint.c: Update.
5021         * unittests/cli-utils-selftests.c: Update.
5022         * unittests/parse-connection-spec-selftests.c: Update.
5023         * valops.c: Update.
5024         * valprint.c: Update.
5025         * value.c: Update.
5026         * varobj.c: Update.
5027         * windows-nat.c: Update.
5028         * x86-linux-nat.c: Update.
5029         * xml-support.c: Update.
5030
5031 2019-04-08  Tom Tromey  <tom@tromey.com>
5032
5033         * xml-support.c: Use C++ exception handling.
5034         * x86-linux-nat.c: Use C++ exception handling.
5035         * windows-nat.c: Use C++ exception handling.
5036         * varobj.c: Use C++ exception handling.
5037         * value.c: Use C++ exception handling.
5038         * valprint.c: Use C++ exception handling.
5039         * valops.c: Use C++ exception handling.
5040         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5041         handling.
5042         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5043         * typeprint.c: Use C++ exception handling.
5044         * tui/tui.c: Use C++ exception handling.
5045         * tracefile-tfile.c: Use C++ exception handling.
5046         * top.c: Use C++ exception handling.
5047         * thread.c: Use C++ exception handling.
5048         * target.c: Use C++ exception handling.
5049         * symmisc.c: Use C++ exception handling.
5050         * symfile-mem.c: Use C++ exception handling.
5051         * stack.c: Use C++ exception handling.
5052         * sparc64-linux-tdep.c: Use C++ exception handling.
5053         * solib.c: Use C++ exception handling.
5054         * solib-svr4.c: Use C++ exception handling.
5055         * solib-spu.c: Use C++ exception handling.
5056         * solib-frv.c: Use C++ exception handling.
5057         * solib-dsbt.c: Use C++ exception handling.
5058         * selftest-arch.c: Use C++ exception handling.
5059         * s390-tdep.c: Use C++ exception handling.
5060         * rust-lang.c: Use C++ exception handling.
5061         * rust-exp.y: Use C++ exception handling.
5062         * rs6000-tdep.c: Use C++ exception handling.
5063         * rs6000-aix-tdep.c: Use C++ exception handling.
5064         * riscv-tdep.c: Use C++ exception handling.
5065         * remote.c: Use C++ exception handling.
5066         * remote-fileio.c: Use C++ exception handling.
5067         * record-full.c: Use C++ exception handling.
5068         * record-btrace.c: Use C++ exception handling.
5069         * python/python.c: Use C++ exception handling.
5070         * python/py-value.c: Use C++ exception handling.
5071         * python/py-utils.c: Use C++ exception handling.
5072         * python/py-unwind.c: Use C++ exception handling.
5073         * python/py-type.c: Use C++ exception handling.
5074         * python/py-symbol.c: Use C++ exception handling.
5075         * python/py-record.c: Use C++ exception handling.
5076         * python/py-record-btrace.c: Use C++ exception handling.
5077         * python/py-progspace.c: Use C++ exception handling.
5078         * python/py-prettyprint.c: Use C++ exception handling.
5079         * python/py-param.c: Use C++ exception handling.
5080         * python/py-objfile.c: Use C++ exception handling.
5081         * python/py-linetable.c: Use C++ exception handling.
5082         * python/py-lazy-string.c: Use C++ exception handling.
5083         * python/py-infthread.c: Use C++ exception handling.
5084         * python/py-inferior.c: Use C++ exception handling.
5085         * python/py-gdb-readline.c: Use C++ exception handling.
5086         * python/py-framefilter.c: Use C++ exception handling.
5087         * python/py-frame.c: Use C++ exception handling.
5088         * python/py-finishbreakpoint.c: Use C++ exception handling.
5089         * python/py-cmd.c: Use C++ exception handling.
5090         * python/py-breakpoint.c: Use C++ exception handling.
5091         * python/py-arch.c: Use C++ exception handling.
5092         * printcmd.c: Use C++ exception handling.
5093         * ppc-linux-tdep.c: Use C++ exception handling.
5094         * parse.c: Use C++ exception handling.
5095         * p-valprint.c: Use C++ exception handling.
5096         * objc-lang.c: Use C++ exception handling.
5097         * mi/mi-main.c: Use C++ exception handling.
5098         * mi/mi-interp.c: Use C++ exception handling.
5099         * mi/mi-cmd-stack.c: Use C++ exception handling.
5100         * mi/mi-cmd-break.c: Use C++ exception handling.
5101         * main.c: Use C++ exception handling.
5102         * linux-thread-db.c: Use C++ exception handling.
5103         * linux-tdep.c: Use C++ exception handling.
5104         * linux-nat.c: Use C++ exception handling.
5105         * linux-fork.c: Use C++ exception handling.
5106         * linespec.c: Use C++ exception handling.
5107         * language.c: Use C++ exception handling.
5108         * jit.c: Use C++ exception handling.
5109         * infrun.c: Use C++ exception handling.
5110         * infcmd.c: Use C++ exception handling.
5111         * infcall.c: Use C++ exception handling.
5112         * inf-loop.c: Use C++ exception handling.
5113         * i386-tdep.c: Use C++ exception handling.
5114         * i386-linux-tdep.c: Use C++ exception handling.
5115         * guile/scm-value.c: Use C++ exception handling.
5116         * guile/scm-type.c: Use C++ exception handling.
5117         * guile/scm-symtab.c: Use C++ exception handling.
5118         * guile/scm-symbol.c: Use C++ exception handling.
5119         * guile/scm-pretty-print.c: Use C++ exception handling.
5120         * guile/scm-ports.c: Use C++ exception handling.
5121         * guile/scm-param.c: Use C++ exception handling.
5122         * guile/scm-math.c: Use C++ exception handling.
5123         * guile/scm-lazy-string.c: Use C++ exception handling.
5124         * guile/scm-frame.c: Use C++ exception handling.
5125         * guile/scm-disasm.c: Use C++ exception handling.
5126         * guile/scm-cmd.c: Use C++ exception handling.
5127         * guile/scm-breakpoint.c: Use C++ exception handling.
5128         * guile/scm-block.c: Use C++ exception handling.
5129         * guile/guile-internal.h: Use C++ exception handling.
5130         * gnu-v3-abi.c: Use C++ exception handling.
5131         * gdbtypes.c: Use C++ exception handling.
5132         * frame.c: Use C++ exception handling.
5133         * frame-unwind.c: Use C++ exception handling.
5134         * fbsd-tdep.c: Use C++ exception handling.
5135         * f-valprint.c: Use C++ exception handling.
5136         * exec.c: Use C++ exception handling.
5137         * event-top.c: Use C++ exception handling.
5138         * event-loop.c: Use C++ exception handling.
5139         * eval.c: Use C++ exception handling.
5140         * dwarf2read.c: Use C++ exception handling.
5141         * dwarf2loc.c: Use C++ exception handling.
5142         * dwarf2-frame.c: Use C++ exception handling.
5143         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5144         * dwarf-index-write.c: Use C++ exception handling.
5145         * dwarf-index-cache.c: Use C++ exception handling.
5146         * dtrace-probe.c: Use C++ exception handling.
5147         * disasm-selftests.c: Use C++ exception handling.
5148         * darwin-nat.c: Use C++ exception handling.
5149         * cp-valprint.c: Use C++ exception handling.
5150         * cp-support.c: Use C++ exception handling.
5151         * cp-abi.c: Use C++ exception handling.
5152         * corelow.c: Use C++ exception handling.
5153         * completer.c: Use C++ exception handling.
5154         * compile/compile-object-run.c: Use C++ exception handling.
5155         * compile/compile-object-load.c: Use C++ exception handling.
5156         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5157         * compile/compile-c-symbols.c: Use C++ exception handling.
5158         * common/selftest.c: Use C++ exception handling.
5159         * common/new-op.c: Use C++ exception handling.
5160         * cli/cli-script.c: Use C++ exception handling.
5161         * cli/cli-interp.c: Use C++ exception handling.
5162         * cli/cli-cmds.c: Use C++ exception handling.
5163         * c-varobj.c: Use C++ exception handling.
5164         * btrace.c: Use C++ exception handling.
5165         * breakpoint.c: Use C++ exception handling.
5166         * break-catch-throw.c: Use C++ exception handling.
5167         * arch-utils.c: Use C++ exception handling.
5168         * amd64-tdep.c: Use C++ exception handling.
5169         * ada-valprint.c: Use C++ exception handling.
5170         * ada-typeprint.c: Use C++ exception handling.
5171         * ada-lang.c: Use C++ exception handling.
5172         * aarch64-tdep.c: Use C++ exception handling.
5173
5174 2019-04-08  Tom Tromey  <tom@tromey.com>
5175
5176         * xml-support.c (gdb_xml_parser::parse): Update.
5177         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5178         * value.c (show_convenience): Update.
5179         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5180         (test_parse_flags_qcs): Update.
5181         * thread.c (thr_try_catch_cmd): Update.
5182         * target.c (target_translate_tls_address): Update.
5183         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5184         (info_frame_command_core, frame_apply_command_count): Update.
5185         * rust-exp.y (rust_lex_exception_test): Update.
5186         * riscv-tdep.c (riscv_print_one_register_info): Update.
5187         * remote.c (remote_target::enable_btrace): Update.
5188         * record-btrace.c (record_btrace_enable_warn): Update.
5189         * python/py-utils.c (gdbpy_convert_exception): Update.
5190         * printcmd.c (do_one_display, print_variable_and_value): Update.
5191         * mi/mi-main.c (mi_print_exception): Update.
5192         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5193         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5194         * linux-nat.c (linux_nat_target::attach): Update.
5195         * linux-fork.c (class scoped_switch_fork_info): Update.
5196         * infrun.c (displaced_step_prepare): Update.
5197         * infcall.c (call_function_by_hand_dummy): Update.
5198         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5199         * gnu-v3-abi.c (print_one_vtable): Update.
5200         * frame.c (get_prev_frame_always): Update.
5201         * f-valprint.c (info_common_command_for_block): Update.
5202         * exec.c (try_open_exec_file): Update.
5203         * exceptions.c (print_exception, exception_print)
5204         (exception_fprintf, exception_print_same): Update.
5205         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5206         * dwarf-index-cache.c (index_cache::store)
5207         (index_cache::lookup_gdb_index): Update.
5208         * darwin-nat.c (maybe_cache_shell): Update.
5209         * cp-valprint.c (cp_print_value_fields): Update.
5210         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5211         (gcc_cplus_symbol_address): Update.
5212         * compile/compile-c-symbols.c (gcc_convert_symbol)
5213         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5214         * common/selftest.c: Update.
5215         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5216         a std::string.
5217         (exception_try_scope_entry, exception_try_scope_exit): Don't
5218         declare.
5219         (struct exception_try_scope): Remove.
5220         (TRY): Don't use exception_try_scope.
5221         (struct gdb_exception): Add constructor, operator=.
5222         <what>: New method.
5223         (struct gdb_exception_RETURN_MASK_ALL)
5224         (struct gdb_exception_RETURN_MASK_ERROR)
5225         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5226         (struct gdb_quit_bad_alloc): Update.
5227         * common/common-exceptions.c (exception_none): Change
5228         initializer.
5229         (struct catcher) <state, exception>: Initialize inline.
5230         <prev>: Remove member.
5231         (current_catcher): Remove.
5232         (catchers): New global.
5233         (exceptions_state_mc_init): Simplify.
5234         (catcher_pop): Remove.
5235         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5236         (try_scope_depth, exception_try_scope_entry)
5237         (exception_try_scope_exit): Remove.
5238         (throw_exception_sjlj): Update.
5239         (exception_messages, exception_messages_size): Remove.
5240         (throw_it): Simplify.
5241         (gdb_exception_sliced_copy): Remove.
5242         (throw_exception_cxx): Update.
5243         * cli/cli-script.c (script_from_file): Update.
5244         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5245         Update.
5246         * ada-valprint.c (ada_val_print): Update.
5247         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5248         (create_excep_cond_exprs): Update.
5249
5250 2019-04-08  Tom Tromey  <tom@tromey.com>
5251
5252         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5253         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5254         (TRY, CATCH, END_CATCH): Remove some definitions.
5255         * common/common-exceptions.c: Don't use GDB_XCPT.
5256         (catcher_list_size): Remove.
5257         (throw_exception, throw_it): Simplify.
5258
5259 2019-04-05  Tom Tromey  <tom@tromey.com>
5260
5261         Revert the header-sorting patch.
5262         * ft32-tdep.c: Revert.
5263         * frv-tdep.c: Revert.
5264         * frv-linux-tdep.c: Revert.
5265         * frame.c: Revert.
5266         * frame-unwind.c: Revert.
5267         * frame-base.c: Revert.
5268         * fork-child.c: Revert.
5269         * findvar.c: Revert.
5270         * findcmd.c: Revert.
5271         * filesystem.c: Revert.
5272         * filename-seen-cache.h: Revert.
5273         * filename-seen-cache.c: Revert.
5274         * fbsd-tdep.c: Revert.
5275         * fbsd-nat.h: Revert.
5276         * fbsd-nat.c: Revert.
5277         * f-valprint.c: Revert.
5278         * f-typeprint.c: Revert.
5279         * f-lang.c: Revert.
5280         * extension.h: Revert.
5281         * extension.c: Revert.
5282         * extension-priv.h: Revert.
5283         * expprint.c: Revert.
5284         * exec.h: Revert.
5285         * exec.c: Revert.
5286         * exceptions.c: Revert.
5287         * event-top.c: Revert.
5288         * event-loop.c: Revert.
5289         * eval.c: Revert.
5290         * elfread.c: Revert.
5291         * dwarf2read.h: Revert.
5292         * dwarf2read.c: Revert.
5293         * dwarf2loc.c: Revert.
5294         * dwarf2expr.h: Revert.
5295         * dwarf2expr.c: Revert.
5296         * dwarf2-frame.c: Revert.
5297         * dwarf2-frame-tailcall.c: Revert.
5298         * dwarf-index-write.h: Revert.
5299         * dwarf-index-write.c: Revert.
5300         * dwarf-index-common.c: Revert.
5301         * dwarf-index-cache.h: Revert.
5302         * dwarf-index-cache.c: Revert.
5303         * dummy-frame.c: Revert.
5304         * dtrace-probe.c: Revert.
5305         * disasm.h: Revert.
5306         * disasm.c: Revert.
5307         * disasm-selftests.c: Revert.
5308         * dictionary.c: Revert.
5309         * dicos-tdep.c: Revert.
5310         * demangle.c: Revert.
5311         * dcache.h: Revert.
5312         * dcache.c: Revert.
5313         * darwin-nat.h: Revert.
5314         * darwin-nat.c: Revert.
5315         * darwin-nat-info.c: Revert.
5316         * d-valprint.c: Revert.
5317         * d-namespace.c: Revert.
5318         * d-lang.c: Revert.
5319         * ctf.c: Revert.
5320         * csky-tdep.c: Revert.
5321         * csky-linux-tdep.c: Revert.
5322         * cris-tdep.c: Revert.
5323         * cris-linux-tdep.c: Revert.
5324         * cp-valprint.c: Revert.
5325         * cp-support.c: Revert.
5326         * cp-namespace.c: Revert.
5327         * cp-abi.c: Revert.
5328         * corelow.c: Revert.
5329         * corefile.c: Revert.
5330         * continuations.c: Revert.
5331         * completer.h: Revert.
5332         * completer.c: Revert.
5333         * complaints.c: Revert.
5334         * coffread.c: Revert.
5335         * coff-pe-read.c: Revert.
5336         * cli-out.h: Revert.
5337         * cli-out.c: Revert.
5338         * charset.c: Revert.
5339         * c-varobj.c: Revert.
5340         * c-valprint.c: Revert.
5341         * c-typeprint.c: Revert.
5342         * c-lang.c: Revert.
5343         * buildsym.c: Revert.
5344         * buildsym-legacy.c: Revert.
5345         * build-id.h: Revert.
5346         * build-id.c: Revert.
5347         * btrace.c: Revert.
5348         * bsd-uthread.c: Revert.
5349         * breakpoint.h: Revert.
5350         * breakpoint.c: Revert.
5351         * break-catch-throw.c: Revert.
5352         * break-catch-syscall.c: Revert.
5353         * break-catch-sig.c: Revert.
5354         * blockframe.c: Revert.
5355         * block.c: Revert.
5356         * bfin-tdep.c: Revert.
5357         * bfin-linux-tdep.c: Revert.
5358         * bfd-target.c: Revert.
5359         * bcache.c: Revert.
5360         * ax-general.c: Revert.
5361         * ax-gdb.h: Revert.
5362         * ax-gdb.c: Revert.
5363         * avr-tdep.c: Revert.
5364         * auxv.c: Revert.
5365         * auto-load.c: Revert.
5366         * arm-wince-tdep.c: Revert.
5367         * arm-tdep.c: Revert.
5368         * arm-symbian-tdep.c: Revert.
5369         * arm-pikeos-tdep.c: Revert.
5370         * arm-obsd-tdep.c: Revert.
5371         * arm-nbsd-tdep.c: Revert.
5372         * arm-nbsd-nat.c: Revert.
5373         * arm-linux-tdep.c: Revert.
5374         * arm-linux-nat.c: Revert.
5375         * arm-fbsd-tdep.c: Revert.
5376         * arm-fbsd-nat.c: Revert.
5377         * arm-bsd-tdep.c: Revert.
5378         * arch-utils.c: Revert.
5379         * arc-tdep.c: Revert.
5380         * arc-newlib-tdep.c: Revert.
5381         * annotate.h: Revert.
5382         * annotate.c: Revert.
5383         * amd64-windows-tdep.c: Revert.
5384         * amd64-windows-nat.c: Revert.
5385         * amd64-tdep.c: Revert.
5386         * amd64-sol2-tdep.c: Revert.
5387         * amd64-obsd-tdep.c: Revert.
5388         * amd64-obsd-nat.c: Revert.
5389         * amd64-nbsd-tdep.c: Revert.
5390         * amd64-nbsd-nat.c: Revert.
5391         * amd64-nat.c: Revert.
5392         * amd64-linux-tdep.c: Revert.
5393         * amd64-linux-nat.c: Revert.
5394         * amd64-fbsd-tdep.c: Revert.
5395         * amd64-fbsd-nat.c: Revert.
5396         * amd64-dicos-tdep.c: Revert.
5397         * amd64-darwin-tdep.c: Revert.
5398         * amd64-bsd-nat.c: Revert.
5399         * alpha-tdep.c: Revert.
5400         * alpha-obsd-tdep.c: Revert.
5401         * alpha-nbsd-tdep.c: Revert.
5402         * alpha-mdebug-tdep.c: Revert.
5403         * alpha-linux-tdep.c: Revert.
5404         * alpha-linux-nat.c: Revert.
5405         * alpha-bsd-tdep.c: Revert.
5406         * alpha-bsd-nat.c: Revert.
5407         * aix-thread.c: Revert.
5408         * agent.c: Revert.
5409         * addrmap.c: Revert.
5410         * ada-varobj.c: Revert.
5411         * ada-valprint.c: Revert.
5412         * ada-typeprint.c: Revert.
5413         * ada-tasks.c: Revert.
5414         * ada-lang.c: Revert.
5415         * aarch64-tdep.c: Revert.
5416         * aarch64-ravenscar-thread.c: Revert.
5417         * aarch64-newlib-tdep.c: Revert.
5418         * aarch64-linux-tdep.c: Revert.
5419         * aarch64-linux-nat.c: Revert.
5420         * aarch64-fbsd-tdep.c: Revert.
5421         * aarch64-fbsd-nat.c: Revert.
5422         * aarch32-linux-nat.c: Revert.
5423
5424 2019-04-05  Tom Tromey  <tom@tromey.com>
5425
5426         * ft32-tdep.c: Sort headers.
5427         * frv-tdep.c: Sort headers.
5428         * frv-linux-tdep.c: Sort headers.
5429         * frame.c: Sort headers.
5430         * frame-unwind.c: Sort headers.
5431         * frame-base.c: Sort headers.
5432         * fork-child.c: Sort headers.
5433         * findvar.c: Sort headers.
5434         * findcmd.c: Sort headers.
5435         * filesystem.c: Sort headers.
5436         * filename-seen-cache.h: Sort headers.
5437         * filename-seen-cache.c: Sort headers.
5438         * fbsd-tdep.c: Sort headers.
5439         * fbsd-nat.h: Sort headers.
5440         * fbsd-nat.c: Sort headers.
5441         * f-valprint.c: Sort headers.
5442         * f-typeprint.c: Sort headers.
5443         * f-lang.c: Sort headers.
5444         * extension.h: Sort headers.
5445         * extension.c: Sort headers.
5446         * extension-priv.h: Sort headers.
5447         * expprint.c: Sort headers.
5448         * exec.h: Sort headers.
5449         * exec.c: Sort headers.
5450         * exceptions.c: Sort headers.
5451         * event-top.c: Sort headers.
5452         * event-loop.c: Sort headers.
5453         * eval.c: Sort headers.
5454         * elfread.c: Sort headers.
5455         * dwarf2read.h: Sort headers.
5456         * dwarf2read.c: Sort headers.
5457         * dwarf2loc.c: Sort headers.
5458         * dwarf2expr.h: Sort headers.
5459         * dwarf2expr.c: Sort headers.
5460         * dwarf2-frame.c: Sort headers.
5461         * dwarf2-frame-tailcall.c: Sort headers.
5462         * dwarf-index-write.h: Sort headers.
5463         * dwarf-index-write.c: Sort headers.
5464         * dwarf-index-common.c: Sort headers.
5465         * dwarf-index-cache.h: Sort headers.
5466         * dwarf-index-cache.c: Sort headers.
5467         * dummy-frame.c: Sort headers.
5468         * dtrace-probe.c: Sort headers.
5469         * disasm.h: Sort headers.
5470         * disasm.c: Sort headers.
5471         * disasm-selftests.c: Sort headers.
5472         * dictionary.c: Sort headers.
5473         * dicos-tdep.c: Sort headers.
5474         * demangle.c: Sort headers.
5475         * dcache.h: Sort headers.
5476         * dcache.c: Sort headers.
5477         * darwin-nat.h: Sort headers.
5478         * darwin-nat.c: Sort headers.
5479         * darwin-nat-info.c: Sort headers.
5480         * d-valprint.c: Sort headers.
5481         * d-namespace.c: Sort headers.
5482         * d-lang.c: Sort headers.
5483         * ctf.c: Sort headers.
5484         * csky-tdep.c: Sort headers.
5485         * csky-linux-tdep.c: Sort headers.
5486         * cris-tdep.c: Sort headers.
5487         * cris-linux-tdep.c: Sort headers.
5488         * cp-valprint.c: Sort headers.
5489         * cp-support.c: Sort headers.
5490         * cp-namespace.c: Sort headers.
5491         * cp-abi.c: Sort headers.
5492         * corelow.c: Sort headers.
5493         * corefile.c: Sort headers.
5494         * continuations.c: Sort headers.
5495         * completer.h: Sort headers.
5496         * completer.c: Sort headers.
5497         * complaints.c: Sort headers.
5498         * coffread.c: Sort headers.
5499         * coff-pe-read.c: Sort headers.
5500         * cli-out.h: Sort headers.
5501         * cli-out.c: Sort headers.
5502         * charset.c: Sort headers.
5503         * c-varobj.c: Sort headers.
5504         * c-valprint.c: Sort headers.
5505         * c-typeprint.c: Sort headers.
5506         * c-lang.c: Sort headers.
5507         * buildsym.c: Sort headers.
5508         * buildsym-legacy.c: Sort headers.
5509         * build-id.h: Sort headers.
5510         * build-id.c: Sort headers.
5511         * btrace.c: Sort headers.
5512         * bsd-uthread.c: Sort headers.
5513         * breakpoint.h: Sort headers.
5514         * breakpoint.c: Sort headers.
5515         * break-catch-throw.c: Sort headers.
5516         * break-catch-syscall.c: Sort headers.
5517         * break-catch-sig.c: Sort headers.
5518         * blockframe.c: Sort headers.
5519         * block.c: Sort headers.
5520         * bfin-tdep.c: Sort headers.
5521         * bfin-linux-tdep.c: Sort headers.
5522         * bfd-target.c: Sort headers.
5523         * bcache.c: Sort headers.
5524         * ax-general.c: Sort headers.
5525         * ax-gdb.h: Sort headers.
5526         * ax-gdb.c: Sort headers.
5527         * avr-tdep.c: Sort headers.
5528         * auxv.c: Sort headers.
5529         * auto-load.c: Sort headers.
5530         * arm-wince-tdep.c: Sort headers.
5531         * arm-tdep.c: Sort headers.
5532         * arm-symbian-tdep.c: Sort headers.
5533         * arm-pikeos-tdep.c: Sort headers.
5534         * arm-obsd-tdep.c: Sort headers.
5535         * arm-nbsd-tdep.c: Sort headers.
5536         * arm-nbsd-nat.c: Sort headers.
5537         * arm-linux-tdep.c: Sort headers.
5538         * arm-linux-nat.c: Sort headers.
5539         * arm-fbsd-tdep.c: Sort headers.
5540         * arm-fbsd-nat.c: Sort headers.
5541         * arm-bsd-tdep.c: Sort headers.
5542         * arch-utils.c: Sort headers.
5543         * arc-tdep.c: Sort headers.
5544         * arc-newlib-tdep.c: Sort headers.
5545         * annotate.h: Sort headers.
5546         * annotate.c: Sort headers.
5547         * amd64-windows-tdep.c: Sort headers.
5548         * amd64-windows-nat.c: Sort headers.
5549         * amd64-tdep.c: Sort headers.
5550         * amd64-sol2-tdep.c: Sort headers.
5551         * amd64-obsd-tdep.c: Sort headers.
5552         * amd64-obsd-nat.c: Sort headers.
5553         * amd64-nbsd-tdep.c: Sort headers.
5554         * amd64-nbsd-nat.c: Sort headers.
5555         * amd64-nat.c: Sort headers.
5556         * amd64-linux-tdep.c: Sort headers.
5557         * amd64-linux-nat.c: Sort headers.
5558         * amd64-fbsd-tdep.c: Sort headers.
5559         * amd64-fbsd-nat.c: Sort headers.
5560         * amd64-dicos-tdep.c: Sort headers.
5561         * amd64-darwin-tdep.c: Sort headers.
5562         * amd64-bsd-nat.c: Sort headers.
5563         * alpha-tdep.c: Sort headers.
5564         * alpha-obsd-tdep.c: Sort headers.
5565         * alpha-nbsd-tdep.c: Sort headers.
5566         * alpha-mdebug-tdep.c: Sort headers.
5567         * alpha-linux-tdep.c: Sort headers.
5568         * alpha-linux-nat.c: Sort headers.
5569         * alpha-bsd-tdep.c: Sort headers.
5570         * alpha-bsd-nat.c: Sort headers.
5571         * aix-thread.c: Sort headers.
5572         * agent.c: Sort headers.
5573         * addrmap.c: Sort headers.
5574         * ada-varobj.c: Sort headers.
5575         * ada-valprint.c: Sort headers.
5576         * ada-typeprint.c: Sort headers.
5577         * ada-tasks.c: Sort headers.
5578         * ada-lang.c: Sort headers.
5579         * aarch64-tdep.c: Sort headers.
5580         * aarch64-ravenscar-thread.c: Sort headers.
5581         * aarch64-newlib-tdep.c: Sort headers.
5582         * aarch64-linux-tdep.c: Sort headers.
5583         * aarch64-linux-nat.c: Sort headers.
5584         * aarch64-fbsd-tdep.c: Sort headers.
5585         * aarch64-fbsd-nat.c: Sort headers.
5586         * aarch32-linux-nat.c: Sort headers.
5587
5588 2019-04-04  Tom Tromey  <tom@tromey.com>
5589
5590         * varobj.c (varobj_create): Update.
5591         * rust-exp.y (struct rust_parser) <update_innermost_block,
5592         lookup_symbol>: New methods.
5593         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5594         Rename.
5595         (rust_parser::rust_lookup_type)
5596         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5597         * printcmd.c (display_command, do_one_display): Update.
5598         * parser-defs.h (struct parser_state) <parser_state>: Add
5599         "tracker" parameter.
5600         (block_tracker): New member.
5601         (class innermost_block_tracker) <innermost_block_tracker>: Add
5602         "types" parameter.
5603         <reset>: Remove method.
5604         (innermost_block): Don't declare.
5605         (null_post_parser): Update.
5606         * parse.c (innermost_block): Remove global.
5607         (write_dollar_variable): Update.
5608         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5609         Remove "tracker_types" parameter.
5610         (parse_expression): Add "tracker" parameter.
5611         (parse_expression_for_completion): Update.
5612         (null_post_parser): Add "tracker" parameter.
5613         * p-exp.y: Update rules.
5614         * m2-exp.y: Update rules.
5615         * language.h (struct language_defn) <la_post_parser>: Add
5616         "tracker" parameter.
5617         * go-exp.y: Update rules.
5618         * f-exp.y: Update rules.
5619         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5620         parameter.
5621         * d-exp.y: Update rules.
5622         * c-exp.y: Update rules.
5623         * breakpoint.c (set_breakpoint_condition): Create an
5624         innermost_block_tracker.
5625         (watch_command_1): Likewise.
5626         * ada-lang.c (resolve): Add "tracker" parameter.
5627         (resolve_subexp): Likewise.
5628         * ada-exp.y (write_var_from_sym): Update.
5629
5630 2019-04-04  Tom Tromey  <tom@tromey.com>
5631
5632         * type-stack.h: New file.
5633         * type-stack.c: New file.
5634         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5635         type-stack.h.
5636         (insert_into_type_stack, insert_type, push_type, push_type_int)
5637         (insert_type_address_space, pop_type, pop_type_int)
5638         (pop_typelist, pop_type_stack, append_type_stack)
5639         (push_type_stack, get_type_stack, push_typelist)
5640         (follow_type_instance_flags, follow_types): Don't declare.
5641         * parse.c (type_stack): Remove global.
5642         (parse_exp_in_context): Update.
5643         (insert_into_type_stack, insert_type, push_type, push_type_int)
5644         (insert_type_address_space, pop_type, pop_type_int)
5645         (pop_typelist, pop_type_stack, append_type_stack)
5646         (push_type_stack, get_type_stack, push_typelist)
5647         (follow_type_instance_flags, follow_types): Remove (moved to
5648         type-stack.c).
5649         * f-exp.y (type_stack): New global.
5650         Update rules.
5651         (push_kind_type, f_parse): Update.
5652         * d-exp.y (type_stack): New global.
5653         Update rules.
5654         (d_parse): Update.
5655         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5656         Update rules.
5657         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5658         (HFILES_NO_SRCDIR): Add type-stack.h.
5659
5660 2019-04-04  Tom Tromey  <tom@tromey.com>
5661
5662         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5663         (rust_parser::convert_ast_to_expression, rust_parse)
5664         (rust_lex_test_completion, rust_lex_tests): Update.
5665         * parser-defs.h (struct expr_completion_state): New.
5666         (struct parser_state) <parser_state>: Add completion parameter.
5667         <mark_struct_expression, mark_completion_tag>: New methods.
5668         <parse_completion, m_completion_state>: New members.
5669         (prefixify_expression, null_post_parser): Update.
5670         (mark_struct_expression, mark_completion_tag): Don't declare.
5671         * parse.c (parse_completion, expout_last_struct)
5672         (expout_tag_completion_type, expout_completion_name): Remove
5673         globals.
5674         (parser_state::mark_struct_expression)
5675         (parser_state::mark_completion_tag): Now methods.
5676         (prefixify_expression): Add last_struct parameter.
5677         (prefixify_subexp): Likewise.
5678         (parse_exp_1): Update.
5679         (parse_exp_in_context): Add cstate parameter.  Update.
5680         (parse_expression_for_completion): Create an
5681         expr_completion_state.
5682         (null_post_parser): Add "completion" parameter.
5683         * p-exp.y: Update rules.
5684         (yylex): Update.
5685         * language.h (struct language_defn) <la_post_parser>: Add
5686         "completing" parameter.
5687         * go-exp.y: Update rules.
5688         (lex_one_token): Update.
5689         * expression.h (parse_completion): Don't declare.
5690         * d-exp.y: Update rules.
5691         (lex_one_token): Update rules.
5692         * c-exp.y: Update rules.
5693         (lex_one_token): Update.
5694         * ada-lang.c (resolve): Add "parse_completion" parameter.
5695         (resolve_subexp): Likewise.
5696         (ada_resolve_function): Likewise.
5697
5698 2019-04-04  Tom Tromey  <tom@tromey.com>
5699
5700         * parser-defs.h (struct parser_state) <start_arglist,
5701         end_arglist>: New methods.
5702         <arglist_len, m_funcall_chain>: New members.
5703         (arglist_len, start_arglist, end_arglist): Don't declare.
5704         * parse.c (arglist_len, funcall_chain): Remove global.
5705         (start_arglist, end_arglist): Remove functions.
5706         (parse_exp_in_context): Update.
5707         * p-exp.y: Update rules.
5708         * m2-exp.y: Update rules.
5709         * go-exp.y: Update rules.
5710         * f-exp.y: Update rules.
5711         * d-exp.y: Update rules.
5712         * c-exp.y: Update rules.
5713
5714 2019-04-04  Tom Tromey  <tom@tromey.com>
5715
5716         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5717         lex_operator, push_back>: New methods.
5718         Update all rules.
5719         (rust_parser::lex_hex, lex_escape): Rename and update.
5720         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5721         (rust_parser::lex_operator): Rename and update.
5722         (rust_parser::lex_number, rustyylex, rustyyerror)
5723         (rust_lex_test_init, rust_lex_test_sequence)
5724         (rust_lex_test_push_back, rust_lex_tests): Update.
5725         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5726         parameter.
5727         <lexptr, prev_lexptr>: New members.
5728         (lexptr, prev_lexptr): Don't declare.
5729         * parse.c (lexptr, prev_lexptr): Remove globals.
5730         (parse_exp_in_context): Update.
5731         * p-exp.y (yylex, yyerror): Update.
5732         * m2-exp.y (parse_number, yylex, yyerror): Update.
5733         * go-exp.y (lex_one_token, yyerror): Update.
5734         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5735         * d-exp.y (lex_one_token, yyerror): Update.
5736         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5737         (lex_one_token, yyerror): Update.
5738         * ada-lex.l (YY_INPUT): Update.
5739         (rewind_to_char): Update.
5740         * ada-exp.y (yyerror): Update.
5741
5742 2019-04-04  Tom Tromey  <tom@tromey.com>
5743
5744         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5745         * parser-defs.h (struct parser_state) <parser_state>: Add new
5746         parameter.
5747         <comma_terminates>: New member.
5748         (comma_terminates): Don't declare global.
5749         * parse.c (comma_terminates): Remove global.
5750         (parse_exp_in_context): Update.
5751         * p-exp.y (yylex): Update.
5752         * m2-exp.y (yylex): Update.
5753         * go-exp.y (lex_one_token): Update.
5754         * f-exp.y (yylex): Update.
5755         * d-exp.y (lex_one_token): Update.
5756         * c-exp.y (lex_one_token): Update.
5757         * ada-lex.l: Update.
5758
5759 2019-04-04  Tom Tromey  <tom@tromey.com>
5760
5761         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5762         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5763         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5764         * parser-defs.h (paren_depth): Don't declare.
5765         * parse.c (paren_depth): Remove global.
5766         (parse_exp_in_context): Update.
5767         * p-exp.y (paren_depth): New global.
5768         (pascal_parse): Initialize it.
5769         * m2-exp.y (paren_depth): New global.
5770         (m2_parse): Initialize it.
5771         * go-exp.y (paren_depth): New global.
5772         (go_parse): Initialize it.
5773         * f-exp.y (paren_depth): New global.
5774         (f_parse): Initialize it.
5775         * d-exp.y (paren_depth): New global.
5776         (d_parse): Initialize it.
5777         * c-exp.y (paren_depth): New global.
5778         (c_parse): Initialize it.
5779         * ada-lex.l (paren_depth): New global.
5780         (lexer_init): Initialize it.
5781
5782 2019-04-04  Tom Tromey  <tom@tromey.com>
5783
5784         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5785         (rust_parser::convert_ast_to_type)
5786         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5787         * parser-defs.h (struct parser_state) <parser_state>: Add
5788         parameters.  Initialize new members.
5789         <expression_context_block, expression_context_pc>: New members.
5790         * parse.c (expression_context_block, expression_context_pc):
5791         Remove globals.
5792         (parse_exp_in_context): Update.
5793         * p-exp.y: Update all rules.
5794         (yylex): Update.
5795         * m2-exp.y: Update all rules.
5796         (yylex): Update.
5797         * go-exp.y (yylex): Update.
5798         * f-exp.y (yylex): Update.
5799         * d-exp.y: Update all rules.
5800         (yylex): Update.
5801         * c-exp.y: Update all rules.
5802         (lex_one_token, classify_name, yylex, c_parse): Update.
5803         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5804
5805 2019-04-04  Tom Tromey  <tom@tromey.com>
5806
5807         * gdbarch.h, gdbarch.c: Rebuild.
5808         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5809         * stap-probe.h:
5810         (struct stap_parse_info): Replace "parser_state" with
5811         "expr_builder".
5812         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5813         (parser_state): New class.
5814         * parse.c (expr_builder): Rename.
5815         (expr_builder::release): Rename.
5816         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5817         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5818         (write_exp_elt_longcst, write_exp_elt_floatcst)
5819         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5820         (write_exp_string_vector, write_exp_bitstring)
5821         (write_exp_msymbol, mark_struct_expression)
5822         (write_dollar_variable)
5823         (insert_type_address_space, increase_expout_size): Replace
5824         "parser_state" with "expr_builder".
5825         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5826         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5827         "parser_state" with "expr_builder".
5828
5829 2019-04-04  Tom Tromey  <tom@tromey.com>
5830
5831         * rust-exp.y: Replace "parse_language" with method call.
5832         * p-exp.y:
5833         (yylex): Replace "parse_language" with method call.
5834         * m2-exp.y:
5835         (yylex): Replace "parse_language" with method call.
5836         * go-exp.y (classify_name): Replace "parse_language" with method
5837         call.
5838         * f-exp.y (yylex): Replace "parse_language" with method call.
5839         * d-exp.y (lex_one_token): Replace "parse_language" with method
5840         call.
5841         * c-exp.y:
5842         (lex_one_token, classify_name, yylex): Replace "parse_language"
5843         with method call.
5844         * ada-exp.y (find_primitive_type, type_char)
5845         (type_system_address): Replace "parse_language" with method call.
5846
5847 2019-04-04  Tom Tromey  <tom@tromey.com>
5848
5849         * rust-exp.y: Replace "parse_gdbarch" with method call.
5850         * parse.c (write_dollar_variable, insert_type_address_space):
5851         Replace "parse_gdbarch" with method call.
5852         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5853         call.
5854         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5855         call.
5856         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5857         "parse_gdbarch" with method call.
5858         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5859         with method call.
5860         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5861         "parse_gdbarch" with method call.
5862         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5863         "parse_gdbarch" with method call.
5864         * c-exp.y (parse_type, parse_number, classify_name): Replace
5865         "parse_gdbarch" with method call.
5866         * ada-lex.l: Replace "parse_gdbarch" with method call.
5867         * ada-exp.y (parse_type, find_primitive_type, type_char)
5868         (type_system_address): Replace "parse_gdbarch" with method call.
5869
5870 2019-04-04  Tom Tromey  <tom@tromey.com>
5871
5872         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5873         * stap-probe.c (stap_parse_argument): Update.
5874         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5875         initial_size parameter.
5876         * rust-exp.y (rust_lex_tests): Update.
5877         * parse.c (parser_state): Update.
5878         (parse_exp_in_context): Update.
5879         * parser-defs.h (struct parser_state) <parser_state>: Remove
5880         "initial_size" parameter.
5881
5882 2019-04-04  Tom Tromey  <tom@tromey.com>
5883
5884         * parser-defs.h (increase_expout_size): Don't declare.
5885         * parse.c (increase_expout_size): Now static.
5886
5887 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5888
5889         * gnu-nat.c (gnu_nat_target::wait): Fix
5890         target_waitstatus_to_string call.
5891
5892 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5893
5894         * eval.c (evaluate_subexp_standard): Handle internal functions
5895         during Fortran function call handling.
5896
5897 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5898
5899         * NEWS: Mention new internal functions.
5900         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5901         (read_base_type): Use dwarf2_init_complex_target_type.
5902         * value.c (creal_internal_fn): New function.
5903         (cimag_internal_fn): New function.
5904         (_initialize_values): Register new internal functions.
5905
5906 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5907
5908         * infrun.c (stop_all_threads): If debug_infrun, always
5909         trace the wait status after wait_one, using
5910         target_waitstatus_to_string and target_pid_to_str.
5911         (handle_inferior_event): Replace various trace of
5912         wait status kind by a single trace.
5913         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5914         wait status kind image by target_waitstatus_to_string.
5915         * target/waitstatus.c (target_waitstatus_to_string): Fix
5916         obsolete comment.
5917
5918 2019-04-01  Tom Tromey  <tromey@adacore.com>
5919
5920         PR symtab/23331:
5921         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5922
5923 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5924             Pedro Alves  <palves@redhat.com>
5925
5926         * top.c (quit_force): Call 'finalize_values'.
5927         * value.c (finalize_values): New function.
5928         * value.h (finalize_values): Declare.
5929
5930 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5931
5932         * NEWS: Announce $_gdb_major and $_gdb_minor.
5933
5934         * top.c (init_gdb_version_vars): New function.
5935         (gdb_init): Call init_gdb_version_vars.
5936
5937 2019-03-29  Tom Tromey  <tromey@adacore.com>
5938
5939         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5940         help text.  Remove dead code.
5941
5942 2019-03-29  Keith Seitz  <keiths@redhat.com>
5943
5944         From Siddhesh Poyarekar:
5945         * f-lang.h (f77_get_upperbound): Return LONGEST.
5946         (f77_get_lowerbound): Likewise.
5947         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5948         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5949         print them.
5950         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5951         plongest to format print it.
5952         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5953         (f77_get_upperbound): Likewise.
5954         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5955         LOWER_BOUND to LONGEST.
5956         (f77_create_arrayprint_offset_tbl): Likewise.
5957
5958 2019-03-29  Keith Seitz  <keiths@redhat.com>
5959
5960         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5961         %s/pulongest for TYPE_LENGTH instead of %d in format
5962         strings.
5963         * ada-typerint.c (ada_print_type): Likewise.
5964         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5965         * compile/compile-c-support.c (generate_register_struct): Likewise.
5966         * gdbtypes.c (recursive_dump_type): Likewise.
5967         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5968         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5969         instead of %d in format strings.
5970         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5971         to std::min to ULONGEST.
5972         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5973         instead of %d in format strings.
5974         * tracepoint.c (info_scope_command): Likewise.
5975         * typeprint.c (print_offset_data::update)
5976         (print_offset_data::finish): Likewise.
5977         * xtensa-tdep.c (xtensa_store_return_value)
5978         (xtensa_push_dummy_call): Likewise.
5979
5980 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5981
5982         * windows-nat.c (display_selector): Fixed format specifications
5983         for 64-bit Cygwin.
5984
5985 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5986
5987         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5988
5989 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5990
5991         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5992         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5993         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5994         (nios2_linux_init_abi): Install it.
5995
5996 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5997
5998         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5999
6000 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6001
6002         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6003
6004 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6005             Tom Tromey  <tromey@adacore.com>
6006
6007         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6008
6009 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6010
6011         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6012         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6013         method to compute the bounds of range types. Also print "[evaluated]"
6014         if the bounds' values come from a dynamic evaluation.
6015
6016 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6017
6018         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6019         whitespace when pretty printing is on.
6020
6021 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6022
6023         * ppc-linux-nat.c: Add include.
6024
6025 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6026
6027         * NEWS: Mention AArch64 Pointer Authentication.
6028
6029 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6030
6031         * arm-linux-nat.c: Add include.
6032
6033 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6034
6035         * source-cache.c (source_cache::get_source_lines): Re-read
6036         fullname after calling open_source_file.
6037
6038 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6039
6040         * NEWS: Mention TLS support for FreeBSD.
6041
6042 2019-03-25  Tom Tromey  <tromey@adacore.com>
6043
6044         * minsyms.c (BUNCH_SIZE): Update comment.
6045         (~minimal_symbol_reader): Remove old comment.
6046         (compact_minimal_symbols): Update comment.
6047         (minimal_symbol_reader::install): Remove old comment.  Update
6048         other comments.
6049
6050 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6051
6052         * s390-linux-nat.c: Add include.
6053
6054 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6055
6056         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6057         Call linux_get_hwcap.
6058         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6059         Likewise.
6060         (aarch64_linux_get_hwcap): Remove function.
6061         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6062         declaration.
6063         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6064         linux_get_hwcap.
6065         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6066         * linux-tdep.c (linux_get_hwcap): Add function.
6067         (linux_get_hwcap2): Likewise.
6068         * linux-tdep.h (linux_get_hwcap): Add declaration.
6069         (linux_get_hwcap2): Likewise.
6070         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6071         (ppc_linux_get_hwcap2): Likewise.
6072         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6073         linux_get_hwcap.
6074         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6075         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6076         (ppc_linux_nat_target::read_description): Likewise.
6077         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6078         * s390-linux-nat.c: Likewise.
6079         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6080
6081 2019-03-24  Tom Tromey  <tom@tromey.com>
6082
6083         * ada-lang.c (standard_lookup): Simplify initialization.
6084         (ada_lookup_symbol_nonlocal): Simplify return.
6085         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6086         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6087         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6088         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6089         initialization.
6090         * solib.c (solib_global_lookup): Simplify.
6091         * symtab.c (null_block_symbol): Remove.
6092         (symbol_cache_lookup): Simplify returns.
6093         (lookup_language_this): Simplify returns.
6094         (lookup_symbol_aux): Simplify return.
6095         (lookup_local_symbol): Simplify returns.
6096         (lookup_global_symbol_from_objfile): Simplify return.
6097         (lookup_symbol_in_objfile_symtabs)
6098         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6099         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6100         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6101         * cp-namespace.c (cp_lookup_bare_symbol)
6102         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6103         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6104         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6105         (cp_lookup_symbol_via_imports): Simplify initialization.
6106         (find_symbol_in_baseclass): Likewise.
6107         * symtab.h (null_block_symbol): Remove.
6108         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6109         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6110         (d_lookup_symbol_module): Likewise.
6111         (find_symbol_in_baseclass): Simplify initialization.
6112
6113 2019-03-24  Tom Tromey  <tom@tromey.com>
6114
6115         * expression.h: Don't include symtab.h.
6116         (struct block): Forward declare.
6117
6118 2019-03-24  Tom Tromey  <tom@tromey.com>
6119
6120         * c-exp.y (typebase): Remove casts.
6121         * gdbtypes.c (lookup_unsigned_typename, )
6122         (lookup_signed_typename): Remove cast.
6123         * eval.c (parse_to_comma_and_eval): Remove cast.
6124         * parse.c (write_dollar_variable): Remove cast.
6125         * block.h (struct block) <superblock>: Now const.
6126         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6127         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6128         (map_block): Make "block" const.
6129         * symfile.h (struct quick_symbol_functions)
6130         <map_matching_symbols>: Constify block argument to "callback".
6131         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6132         const.
6133         (find_pc_sect_compunit_symtab): Make "b" const.
6134         (find_symbol_at_address): Likewise.
6135         (search_symbols): Likewise.
6136         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6137         (dw2_debug_names_lookup_symbol): Likewise.
6138         (dw2_map_matching_symbols): Update.
6139         * p-valprint.c (pascal_val_print): Remove "block".
6140         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6141         (aux_add_nonlocal_symbols): Make "block" const.
6142         (resolve_subexp): Remove cast.
6143         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6144         const.
6145         (iterate_over_file_blocks): Likewise.
6146         * f-exp.y (%union) <bval>: Remove.
6147         * coffread.c (patch_opaque_types): Make "b" const.
6148         * spu-tdep.c (spu_catch_start): Make "block" const.
6149         * c-valprint.c (print_unpacked_pointer): Remove "block".
6150         * symmisc.c (dump_symtab_1): Make "b" const.
6151         (block_depth): Make "block" const.
6152         * d-exp.y (%union) <bval>: Remove.
6153         * cp-support.h (cp_lookup_rtti_type): Update.
6154         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6155         * psymtab.c (psym_lookup_symbol): Make "block" const.
6156         (maintenance_check_psymtabs): Make "b" const.
6157         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6158         (enumerate_locals, enumerate_args): Update.
6159         * python/py-symtab.c (stpy_global_block): Make "block" const.
6160         (stpy_static_block): Likewise.
6161         * inline-frame.c (block_starting_point_at): Make "new_block"
6162         const.
6163         * block.c (find_block_in_blockvector): Make return type const.
6164         (blockvector_for_pc_sect): Make "b" const.
6165         (find_block_in_blockvector): Make "b" const.
6166
6167 2019-03-23  Tom Tromey  <tom@tromey.com>
6168
6169         * varobj.c (varobj_create): Update.
6170         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6171         * printcmd.c (display_command, do_one_display): Don't reset
6172         innermost_block.
6173         * parser-defs.h (enum innermost_block_tracker_type): Move to
6174         expression.h.
6175         (innermost_block): Update comment.
6176         * parse.c (parse_exp_1): Add tracker_types parameter.
6177         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6178         tracker_types parameter.  Reset innermost_block.
6179         (parse_exp_in_context): Remove.
6180         (parse_expression_for_completion): Update.
6181         * objfiles.c (~objfile): Don't reset expression_context_block or
6182         innermost_block.
6183         * expression.h (enum innermost_block_tracker_type): Move from
6184         parser-defs.h.
6185         (parse_exp_1): Add tracker_types parameter.
6186         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6187         reset innermost_block.
6188
6189 2019-03-23  Tom Tromey  <tom@tromey.com>
6190
6191         * objfiles.h: Include bcache.h.
6192
6193 2019-03-23  Tom Tromey  <tom@tromey.com>
6194
6195         * linespec.c (get_current_search_block): Use
6196         scoped_restore_current_language.
6197         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6198
6199 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6200             Jiong Wang  <jiong.wang@arm.com>
6201
6202         * aarch64-linux-tdep.c
6203         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6204         section.
6205         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6206
6207 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6208             Jiong Wang  <jiong.wang@arm.com>
6209
6210         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6211         instructions.
6212         (aarch64_analyze_prologue_test): Add PACIASP test.
6213         (aarch64_prologue_prev_register): Unmask PC value.
6214
6215 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6216             Jiong Wang  <jiong.wang@arm.com>
6217
6218         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6219         (aarch64_dwarf2_prev_register): Unmask PC value.
6220         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6221         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6222         DW_CFA_AARCH64_negate_ra_state.
6223         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6224
6225 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6226             Jiong Wang  <jiong.wang@arm.com>
6227
6228         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6229         registers.
6230         (aarch64_pseudo_register_name): Likewise.
6231         (aarch64_pseudo_register_type): Likewise.
6232         (aarch64_pseudo_register_reggroup_p): Likewise.
6233         (aarch64_gdbarch_init): Add pauth registers.
6234         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6235         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6236         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6237         (struct gdbarch_tdep): Add regnum for ra_state.
6238
6239 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6240             Jiong Wang  <jiong.wang@arm.com>
6241
6242         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6243
6244 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6245             Jiong Wang  <jiong.wang@arm.com>
6246
6247         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6248         function.
6249         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6250         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6251         (aarch64_gdbarch_init): Add puth registers.
6252         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6253         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6254         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6255
6256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6257             Jiong Wang  <jiong.wang@arm.com>
6258
6259         * aarch64-linux-nat.c
6260         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6261         * aarch64-linux-tdep.c
6262         (aarch64_linux_core_read_description): Likewise.
6263         (aarch64_linux_get_hwcap): New function.
6264         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6265         (aarch64_linux_get_hwcap): New declaration.
6266
6267 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6268             Jiong Wang  <jiong.wang@arm.com>
6269
6270         * aarch64-linux-nat.c
6271         (aarch64_linux_nat_target::read_description): Add pauth param.
6272         * aarch64-linux-tdep.c
6273         (aarch64_linux_core_read_description): Likewise.
6274         * aarch64-tdep.c (struct target_desc): Add in pauth.
6275         (aarch64_read_description): Add pauth param.
6276         (aarch64_gdbarch_init): Likewise.
6277         * aarch64-tdep.h (aarch64_read_description): Likewise.
6278         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6279         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6280         * features/Makefile: Add new files.
6281         * features/aarch64-pauth.c: New file.
6282         * features/aarch64-pauth.xml: New file.
6283
6284 2019-03-20  Tom Tromey  <tromey@adacore.com>
6285
6286         * infrun.c (handle_inferior_event): Rename from
6287         handle_inferior_event_1.  Create a scoped_value_mark.
6288         (handle_inferior_event): Remove.
6289
6290 2019-03-19  Tom Tromey  <tromey@adacore.com>
6291
6292         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6293         * infrun.h (print_stop_event): Add "displays" parameter.
6294         * infrun.c (print_stop_event): Add "displays" parameter.
6295
6296 2019-03-19  Pedro Alves  <palves@redhat.com>
6297
6298         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6299         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6300         to -1.  Fix TABs vs spaces.
6301         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6302         * tui/tui-out.h (tui_ui_out) Add intro comments.
6303         <m_line, m_start_of_line>: In-class initialize, and add describing
6304         comment.
6305
6306 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6307
6308         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6309         variable names.
6310         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6311
6312 2019-03-18  Pedro Alves  <palves@redhat.com>
6313             Eli Zaretskii <eliz@gnu.org>
6314
6315         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6316         m_line and m_start_of_line.
6317
6318 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6319
6320         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6321         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6322         it returns a newline.  This fixes a regression in TU mode, whereby
6323         the next line is output on the same screen line as the user input.
6324
6325 2019-03-18  Tom Tromey  <tromey@adacore.com>
6326
6327         * minsyms.c (minimal_symbol_reader::install): Remove call to
6328         obstack_blank.
6329
6330 2019-03-18  Pedro Alves  <palves@redhat.com>
6331
6332         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6333         New globals.
6334         (apply_style): New, factored out from ...
6335         (apply_ansi_escape): ... this.  Handle reverse video mode.
6336         (tui_set_reverse_mode): New function.
6337         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6338         * tui/tui-winsource.c (tui_show_source_line): Use
6339         tui_set_reverse_mode instead of setting A_STANDOUT.
6340         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6341         New setter methods.
6342
6343 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6344
6345         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6346         Handle tabs.
6347
6348 2019-03-18  Tom Tromey  <tromey@adacore.com>
6349
6350         * ada-lang.c (empty_array): Add "high" parameter.
6351         (ada_evaluate_subexp): Update.
6352
6353 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6354
6355         * unittests/string_view-selftests.c: Define
6356         _initialize_string_view_selftests unconditionally.
6357
6358 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6359
6360         PR gdb/24350
6361         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6362
6363 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6364
6365         PR gdb/24351
6366         * windows-nat.c (display_selector): Fix format specifiers.
6367
6368 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6369
6370         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6371         tui_refill_source_window instead of tui_refresh_win, to update the
6372         current execution line.  This fixes redisplay of the current line
6373         when stepping through the code with "next" or "step".
6374
6375 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6376
6377         * source-cache.c (source_cache::get_source_lines): Call
6378         find_source_lines to initialize s->nlines.  This fixes vertical
6379         scrolling of TUI source window when the DOWN arrow is pressed.
6380
6381 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6382
6383         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6384         linux-thread-db.c (_initialize_thread_db): Likewise.
6385
6386 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6387
6388         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6389         wclrtoeol in tui_show_source_line".  This reverts changes made in
6390         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6391
6392 2019-03-15  Tom Tromey  <tom@tromey.com>
6393
6394         * symtab.h (struct minimal_symbol): Derive from
6395         general_symbol_info.
6396         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6397         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6398         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6399         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6400         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6401         (MSYMBOL_SEARCH_NAME): Update.
6402         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6403         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6404         * minsyms.c (minimal_symbol_reader::record_full): Update.
6405
6406 2019-03-15  Tom Tromey  <tom@tromey.com>
6407
6408         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6409
6410 2019-03-15  Tom Tromey  <tom@tromey.com>
6411
6412         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6413         unique_xmalloc_ptr.
6414         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6415         Update.
6416         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6417         (build_minimal_symbol_hash_tables)
6418         (minimal_symbol_reader::install): Update.
6419
6420 2019-03-15  Tom Tromey  <tom@tromey.com>
6421
6422         * symtab.c (create_demangled_names_hash): Update.
6423         (symbol_set_names): Update.
6424         * objfiles.h (struct objfile_per_bfd_storage)
6425         <demangled_names_hash>: Now an htab_up.
6426         * objfiles.c (objfile_per_bfd_storage): Simplify.
6427
6428 2019-03-15  Tom Tromey  <tom@tromey.com>
6429
6430         * objfiles.h (struct objfile_per_bfd_storage): Declare
6431         destructor.
6432         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6433         New.
6434         (get_objfile_bfd_data): Use new.  Don't initialize
6435         language_of_main.
6436         (free_objfile_per_bfd_storage): Remove.
6437         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6438
6439 2019-03-15  Tom Tromey  <tom@tromey.com>
6440
6441         * symfile.c (reread_symbols): Update.
6442         * objfiles.c (objfile::objfile): Update.
6443         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6444         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6445         comment.
6446         (minimal_symbol_reader::install): Update.
6447         (terminate_minimal_symbol_table): Remove.
6448         * jit.c (jit_object_close_impl): Update.
6449
6450 2019-03-15  Tom Tromey  <tom@tromey.com>
6451
6452         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6453         initializations.
6454
6455 2019-03-15  Tom Tromey  <tom@tromey.com>
6456
6457         * objfiles.h (struct objfile_per_bfd_storage)
6458         <demangled_hash_languages>: Now a bitset.
6459         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6460         (lookup_minimal_symbol): Update.
6461
6462 2019-03-15  Tom Tromey  <tom@tromey.com>
6463
6464         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6465         Don't return the symbol.
6466         * coffread.c (record_minimal_symbol): Use record_full.
6467
6468 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6469
6470         The MS-Windows port of ncurses fails to switch to a color pair if
6471         one or both of the colors are the implicit default colors.  This
6472         change records the default colors when TUI is initialized, and
6473         then specifies them explicitly when a color pair uses the default
6474         colors.  This allows color styling in TUI mode on MS-Windows.
6475
6476         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6477         ncurses_norm_attr.
6478         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6479         colors in ncurses_norm_attr.
6480         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6481         "none", replace it with the default color recorded in
6482         ncurses_norm_attr.
6483
6484 2019-03-14  Tom Tromey  <tromey@adacore.com>
6485
6486         * source-cache.h (class source_cache) <get_source_lines>: Return
6487         std::string.
6488         * source-cache.c (source_cache::extract_lines): Handle case where
6489         first_pos==npos.  Return std::string.
6490         (source_cache::get_source_lines): Update.
6491
6492 2019-03-14  Tom Tromey  <tromey@adacore.com>
6493
6494         * NEWS: Add item for "style sources" commands.
6495         * source-cache.c (source_cache::get_source_lines): Check
6496         source_styling.
6497         * cli/cli-style.c (source_styling): New global.
6498         (_initialize_cli_style): Add "style sources" commands.
6499         (show_style_sources): New function.
6500         * cli/cli-style.h (source_styling): Declare.
6501
6502 2019-03-14  Pedro Alves  <palves@redhat.com>
6503             Tom Tromey  <tromey@adacore.com>
6504
6505         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6506         * tui/tui-winsource.c (tui_refill_source_window): New function,
6507         from...
6508         (tui_horizontal_source_scroll): ... here.  Move some logic.
6509         * cli/cli-style.c (set_style_enabled): Notify new observable.
6510         * tui/tui-hooks.c (tui_redisplay_source): New function.
6511         (tui_attach_detach_observers): Attach or detach
6512         tui_redisplay_source.
6513         * observable.h (source_styling_changed): New observable.
6514         * observable.c: Define source_styling_changed observable.
6515
6516 2019-03-13  Tom Tromey  <tromey@adacore.com>
6517
6518         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6519         (i386_gnu_nat_target::store_registers): Update.
6520         * target-debug.h (target_debug_print_std_string): New macro.
6521         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6522         * windows-tdep.c (display_one_tib): Update.
6523         * tui/tui-stack.c (tui_make_status_line): Update.
6524         * top.c (print_inferior_quit_action): Update.
6525         * thread.c (thr_try_catch_cmd): Update.
6526         (add_thread_with_info): Update.
6527         (thread_target_id_str): Update.
6528         (thr_try_catch_cmd): Update.
6529         (thread_command): Update.
6530         (thread_find_command): Update.
6531         * record-btrace.c (record_btrace_target::info_record)
6532         (record_btrace_resume_thread, record_btrace_target::resume)
6533         (record_btrace_cancel_resume, record_btrace_step_thread)
6534         (record_btrace_target::wait, record_btrace_target::wait)
6535         (record_btrace_target::wait, record_btrace_target::stop): Update.
6536         * progspace.c (print_program_space): Update.
6537         * process-stratum-target.c
6538         (process_stratum_target::thread_address_space): Update.
6539         * linux-fork.c (linux_fork_mourn_inferior)
6540         (detach_checkpoint_command, info_checkpoints_command)
6541         (linux_fork_context): Update.
6542         (linux_fork_detach): Update.
6543         (class scoped_switch_fork_info): Update.
6544         (delete_checkpoint_command): Update.
6545         * infrun.c (follow_fork_inferior): Update.
6546         (follow_fork_inferior): Update.
6547         (proceed_after_vfork_done): Update.
6548         (handle_vfork_child_exec_or_exit): Update.
6549         (follow_exec): Update.
6550         (displaced_step_prepare_throw): Update.
6551         (displaced_step_restore): Update.
6552         (start_step_over): Update.
6553         (resume_1): Update.
6554         (clear_proceed_status_thread): Update.
6555         (proceed): Update.
6556         (print_target_wait_results): Update.
6557         (do_target_wait): Update.
6558         (context_switch): Update.
6559         (stop_all_threads): Update.
6560         (restart_threads): Update.
6561         (finish_step_over): Update.
6562         (handle_signal_stop): Update.
6563         (switch_back_to_stepped_thread): Update.
6564         (keep_going_pass_signal): Update.
6565         (print_exited_reason): Update.
6566         (normal_stop): Update.
6567         * inferior.c (inferior_pid_to_str): Change return type.
6568         (print_selected_inferior): Update.
6569         (add_inferior): Update.
6570         (detach_inferior): Update.
6571         * dummy-frame.c (fprint_dummy_frames): Update.
6572         * dcache.c (dcache_info_1): Update.
6573         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6574         (btrace_fetch, btrace_clear): Update.
6575         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6576         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6577         type.
6578         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6579         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6580         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6581         * gdbarch.c, gdbarch.h: Rebuild.
6582         * gdbarch.sh (core_pid_to_str): Change return type.
6583         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6584         return type.
6585         (windows_nat_target::pid_to_str): Change return type.
6586         (windows_delete_thread): Update.
6587         (windows_nat_target::attach): Update.
6588         (windows_nat_target::files_info): Update.
6589         * target-delegates.c: Rebuild.
6590         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6591         return type.
6592         (sol_thread_target::pid_to_str): Change return type.
6593         * remote.c (class remote_target) <pid_to_str>: Change return
6594         type.
6595         (remote_target::pid_to_str): Change return type.
6596         (extended_remote_target::attach, remote_target::remote_stop_ns)
6597         (remote_target::remote_notif_remove_queued_reply)
6598         (remote_target::push_stop_reply, remote_target::disable_btrace):
6599         Update.
6600         (extended_remote_target::attach): Update.
6601         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6602         type.
6603         (gdbsim_target::pid_to_str): Change return type.
6604         * ravenscar-thread.c (struct ravenscar_thread_target)
6605         <pid_to_str>: Change return type.
6606         (ravenscar_thread_target::pid_to_str): Change return type.
6607         * procfs.c (class procfs_target) <pid_to_str>: Change return
6608         type.
6609         (procfs_target::pid_to_str): Change return type.
6610         (procfs_target::attach): Update.
6611         (procfs_target::detach): Update.
6612         (procfs_target::fetch_registers): Update.
6613         (procfs_target::store_registers): Update.
6614         (procfs_target::wait): Update.
6615         (procfs_target::files_info): Update.
6616         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6617         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6618         return type.
6619         (nto_procfs_target::pid_to_str): Change return type.
6620         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6621         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6622         return type.
6623         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6624         (exit_lwp): Update.
6625         (attach_proc_task_lwp_callback, get_detach_signal)
6626         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6627         (linux_nat_target::resume, wait_lwp, stop_callback)
6628         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6629         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6630         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6631         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6632         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6633         type.
6634         (inf_ptrace_target::attach): Update.
6635         (inf_ptrace_target::files_info): Update.
6636         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6637         type.
6638         (go32_nat_target::pid_to_str): Change return type.
6639         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6640         (gnu_nat_target::wait): Update.
6641         (gnu_nat_target::wait): Update.
6642         (gnu_nat_target::resume): Update.
6643         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6644         (fbsd_nat_target::wait): Update.
6645         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6646         type.
6647         (darwin_nat_target::attach): Update.
6648         * corelow.c (class core_target) <pid_to_str>: Change return type.
6649         (core_target::pid_to_str): Change return type.
6650         * target.c (normal_pid_to_str): Change return type.
6651         (default_pid_to_str): Likewise.
6652         (target_pid_to_str): Change return type.
6653         (target_translate_tls_address): Update.
6654         (target_announce_detach): Update.
6655         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6656         return type.
6657         (bsd_uthread_target::pid_to_str): Change return type.
6658         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6659         type.
6660         (bsd_kvm_target::pid_to_str): Change return type.
6661         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6662         return type.
6663         (aix_thread_target::pid_to_str): Change return type.
6664         * target.h (struct target_ops) <pid_to_str>: Change return type.
6665         (target_pid_to_str, normal_pid_to_str): Likewise.
6666         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6667         type.
6668         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6669         type.
6670         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6671         return type.
6672         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6673         type.
6674         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6675         type.
6676         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6677         return type.
6678
6679 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6680
6681         * NEWS: Mention that the new default MI version is 3.  Mention
6682         changes to the output of commands and events that deal with
6683         multi-location breakpoints.
6684         * breakpoint.c: Include "mi/mi-out.h".
6685         (print_one_breakpoint): Change output syntax if using MI version
6686         >= 3.
6687         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6688         New.
6689         (mi_multi_location_breakpoint_output_fixed): New.
6690         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6691         (mi_cmd_fix_multi_location_breakpoint_output): New.
6692         (mi_multi_location_breakpoint_output_fixed): New.
6693         * mi/mi-cmds.c (mi_cmds): Register command
6694         -fix-multi-location-breakpoint-output.
6695         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6696         interpreter "mi".
6697
6698 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6699
6700         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6701         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6702         instantiate mi_ui_out based on interpreter name.
6703         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6704         * mi/mi-main.c (mi_load_progress): Likewise.
6705
6706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6707
6708         * NEWS: Combine separate "New targets" sections for 8.3.
6709
6710 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6711
6712         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6713         (ppcfbsd_init_abi): Install gdbarch
6714         "fetch_tls_load_module_address" and "get_thread_local_address"
6715         methods.
6716
6717 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6718
6719         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6720         (riscv_fbsd_init_abi): Install gdbarch
6721         "fetch_tls_load_module_address" and "get_thread_local_address"
6722         methods.
6723
6724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6725
6726         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6727         (i386fbsd_init_abi): Install gdbarch
6728         "fetch_tls_load_module_address" and "get_thread_local_address"
6729         methods.
6730
6731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6732
6733         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6734         (amd64fbsd_init_abi): Install gdbarch
6735         "fetch_tls_load_module_address" and "get_thread_local_address"
6736         methods.
6737
6738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6739
6740         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6741         (struct fbsd_pspace_data): New type.
6742         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6743         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6744         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6745         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6746         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6747
6748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6749
6750         * gdbtypes.c (lookup_struct_elt): New function.
6751         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6752         * gdbtypes.h (struct struct_elt): New type.
6753         (lookup_struct_elt): New prototype.
6754
6755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6756
6757         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6758         remove disabled code block.
6759
6760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6761
6762         * gdbarch.sh (get_thread_local_address): New method.
6763         * gdbarch.h, gdbarch.c: Regenerate.
6764         * target.c (target_translate_tls_address): Use
6765         gdbarch_get_thread_local_address if present instead of
6766         target::get_thread_local_address.
6767
6768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6769
6770         * target.h (target::get_thread_local_address): Update comment.
6771
6772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6773
6774         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6775         objfile->separate_debug_objfile_backlink if not NULL.
6776
6777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6778
6779         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6780         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6781         (amd64bsd_store_inferior_registers): Likewise.
6782         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6783         Enable segment base registers.
6784         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6785         PT_GETFSBASE and PT_GETGSBASE.
6786         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6787         PT_SETGSBASE.
6788         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6789         segment base registers.
6790         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6791
6792 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6793
6794         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6795         Update calls to i386_target_description to add 'segments'
6796         parameter.
6797         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6798         add segment base registers.
6799         * arch/i386.c (i386_create_target_description): Add 'segments'
6800         parameter to enable segment base registers.
6801         * arch/i386.h (i386_create_target_description): Likewise.
6802         * features/i386/32bit-segments.xml: New file.
6803         * features/i386/32bit-segments.c: Generate.
6804         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6805         call to i386_target_description to add 'segments' parameter.
6806         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6807         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6808         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6809         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6810         if feature is present.
6811         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6812         Add 'segments' parameter to call to i386_target_description.
6813         (i386_target_description): Add 'segments' parameter to enable
6814         segment base registers.
6815         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6816         to call to i386_target_description.
6817         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6818         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6819         Define I386_NUM_REGS.
6820         (i386_target_description): Add 'segments' parameter to enable
6821         segment base registers.
6822
6823 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6824
6825         PR/24325
6826         * source-cache.c: #undef open and close, to avoid unresolved
6827         externals during linking.
6828
6829 2019-03-12  Tom Tromey  <tromey@adacore.com>
6830
6831         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6832         const.  Add initializers.
6833         (_initialize_remote): Don't initialize ptid globals.
6834
6835 2019-03-12  Pedro Alves  <palves@redhat.com>
6836
6837         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6838
6839 2019-03-12  Pedro Alves  <palves@redhat.com>
6840
6841         * cp-name-parser.y (main): Remove unused 'len' variable.
6842
6843 2019-03-12  Tom Tromey  <tromey@adacore.com>
6844
6845         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6846         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6847
6848 2019-03-12  Tom Tromey  <tromey@adacore.com>
6849
6850         * linux-nat.c (iterate_over_lwps): Update.
6851         (stop_callback): Remove parameter.
6852         (stop_wait_callback, detach_callback, resume_set_callback)
6853         (select_singlestep_lwp_callback, set_ignore_sigint)
6854         (status_callback, resumed_callback, resume_clear_callback)
6855         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6856         data parameter.
6857         (linux_nat_target::detach, linux_nat_target::resume)
6858         (linux_stop_and_wait_all_lwps, select_event_lwp)
6859         (linux_nat_filter_event, linux_nat_wait_1)
6860         (linux_nat_target::kill, linux_nat_target::stop)
6861         (linux_nat_target::stop): Update.
6862         (linux_nat_resume_callback): Change type.
6863         (resume_stopped_resumed_lwps, count_events_callback)
6864         (select_event_lwp_callback): Likewise.
6865         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6866         * arm-linux-nat.c (struct update_registers_data): Remove.
6867         (update_registers_callback): Change type.
6868         (arm_linux_insert_hw_breakpoint1): Update.
6869         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6870         parameter.
6871         (x86_linux_dr_set_addr): Update.
6872         (x86_linux_dr_set_control): Update.
6873         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6874         (iterate_over_lwps): Use gdb::function_view.
6875         * nat/aarch64-linux-hw-point.c (struct
6876         aarch64_dr_update_callback_param): Remove.
6877         (debug_reg_change_callback): Change type.
6878         (aarch64_notify_debug_reg_change): Update.
6879         * s390-linux-nat.c (s390_refresh_per_info): Update.
6880
6881 2019-03-11  Tom Tromey  <tromey@adacore.com>
6882
6883         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6884         redundant assignment to "this_cu".
6885
6886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6887
6888         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6889
6890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6891
6892         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6893         from...
6894         (rank_one_type): ... this.
6895
6896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6897
6898         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6899         from...
6900         (rank_one_type): ... this.
6901
6902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6903
6904         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6905         from...
6906         (rank_one_type): ... this.
6907
6908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6909
6910         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6911         from...
6912         (rank_one_type): ... this.
6913
6914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6915
6916         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6917         from...
6918         (rank_one_type): ... this.
6919
6920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6921
6922         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6923         from...
6924         (rank_one_type): ... this.
6925
6926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6927
6928         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6929         from...
6930         (rank_one_type): ... this.
6931
6932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6933
6934         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6935         from...
6936         (rank_one_type): ... this.
6937
6938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6939
6940         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6941         from...
6942         (rank_one_type): ... this.
6943
6944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6945
6946         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6947         from...
6948         (rank_one_type): ... this.
6949
6950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6951
6952         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6953         from...
6954         (rank_one_type): ... this.
6955
6956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6957
6958         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6959         from...
6960         (rank_one_type): ... this.
6961
6962 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6963
6964         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6965         inferior-events' shows the example events.
6966
6967 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6968
6969         Support styling on native MS-Windows console
6970
6971         PR/24315
6972         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6973         on MS-Windows if $TERM is not defined.
6974
6975         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6976
6977         * posix-hdep.c (gdb_console_fputs):
6978         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6979         functions.
6980         * ui-file.h (gdb_console_fputs): Add prototype.
6981
6982         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6983         back to fputs only if the former returns zero.
6984
6985 2019-03-07  Tom Tromey  <tom@tromey.com>
6986
6987         * symmisc.c (print_symbol_bcache_statistics): Update.
6988         (print_objfile_statistics): Update.
6989         * symfile.c (allocate_symtab): Update.
6990         * stabsread.c: Don't include bcache.h.
6991         * psymtab.h (struct psymbol_bcache): Don't declare.
6992         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6993         (psymbol_bcache_init, psymbol_bcache_free)
6994         (psymbol_bcache_get_bcache): Don't declare.
6995         * psymtab.c (struct psymbol_bcache): Remove.
6996         (psymtab_storage::psymtab_storage): Update.
6997         (psymtab_storage::~psymtab_storage): Update.
6998         (psymbol_bcache_init, psymbol_bcache_free)
6999         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7000         (add_psymbol_to_bcache): Update.
7001         (allocate_psymtab): Update.
7002         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7003         macro_cache>: No longer pointers.
7004         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7005         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7006         * macrotab.c (macro_bcache): Update.
7007         * macroexp.c: Don't include bcache.h.
7008         * gdbtypes.c (check_types_worklist): Update.
7009         (types_deeply_equal): Remove TRY/CATCH.  Update.
7010         * elfread.c (elf_symtab_read): Update.
7011         * dwarf2read.c: Don't include bcache.h.
7012         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7013         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7014         (print_bcache_statistics, bcache_memory_used): Don't declare.
7015         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7016         methods.  Rename all data members.
7017         * bcache.c (struct bcache): Move to bcache.h.
7018         (bcache::expand_hash_table): Rename from expand_hash_table.
7019         (bcache): Remove.
7020         (bcache::insert): Rename from bcache_full.
7021         (bcache::compare): Rename from bcache_compare.
7022         (bcache_xmalloc): Remove.
7023         (bcache::~bcache): Rename from bcache_xfree.
7024         (bcache::print_statistics): Rename from print_bcache_statistics.
7025         (bcache::memory_used): Rename from bcache_memory_used.
7026
7027 2019-03-07  Pedro Alves  <palves@redhat.com>
7028
7029         * infrun.c (normal_stop): Also check for
7030         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7031
7032 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7033
7034         * f-lang.c (value_from_host_double): Moved to...
7035         * value.c (value_from_host_double): ...here.
7036         * value.h (value_from_host_double): Declare.
7037         * guile/scm-math.c (vlscm_convert_typed_number): Use
7038         value_from_host_double.
7039         (vlscm_convert_number): Likewise.
7040         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7041         * python/py-value.c (convert_value_from_python): Likewise.
7042
7043 2019-03-06  Tom Tromey  <tom@tromey.com>
7044
7045         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7046
7047 2019-03-06  Tom Tromey  <tom@tromey.com>
7048
7049         * utils.h (free_current_contents): Don't declare.
7050         * utils.c (free_current_contents): Remove.
7051
7052 2019-03-06  Tom Tromey  <tom@tromey.com>
7053
7054         * top.c (quit_force): Update.
7055         * main.c (captured_command_loop): Update.
7056         * common/new-op.c (operator new): Update.
7057         * common/common-exceptions.c (struct catcher)
7058         <save_cleanup_chain>: Remove member.
7059         (exceptions_state_mc_init): Update.
7060         (exception_try_scope_entry): Return nullptr.
7061         (exception_try_scope_exit, exception_rethrow)
7062         (throw_exception_sjlj, throw_exception_cxx): Update.
7063         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7064         (all_cleanups, do_cleanups, discard_cleanups)
7065         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7066         (restore_cleanups, restore_final_cleanups): Don't declare.
7067         (do_final_cleanups): Remove parameter.
7068         * common/cleanups.c (cleanup_chain, make_cleanup)
7069         (make_cleanup_dtor, all_cleanups, do_cleanups)
7070         (discard_my_cleanups, discard_cleanups)
7071         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7072         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7073         (null_cleanup): Remove.
7074         (do_final_cleanups): Remove parameter.
7075
7076 2019-03-06  Tom Tromey  <tom@tromey.com>
7077
7078         * remote.c (remote_target::remote_parse_stop_reply): Use
7079         unique_xmalloc_ptr.
7080
7081 2019-03-06  Tom Tromey  <tom@tromey.com>
7082
7083         * stabsread.c (struct stabs_field_info): Rename from field_info.
7084         <list, fnlist>: Add initializers.
7085         <obstack>: New member.
7086         (read_member_functions, read_struct_fields, read_baseclasses):
7087         Allocate on obstack.  Don't use cleanups.
7088         (read_one_struct_field, read_member_functions, read_struct_fields)
7089         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7090         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7091         (read_struct_type): Update.
7092
7093 2019-03-06  Tom Tromey  <tom@tromey.com>
7094
7095         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7096         * common/filestuff.h (make_cleanup_close): Don't declare.
7097         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7098         Remove.
7099
7100 2019-03-06  Tom Tromey  <tom@tromey.com>
7101
7102         * solib-aix.c: Use make_scope_exit.
7103
7104 2019-03-06  Tom Tromey  <tom@tromey.com>
7105
7106         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7107         Use make_scope_exit.
7108
7109 2019-03-06  Tom Tromey  <tom@tromey.com>
7110
7111         * solib-svr4.c (disable_probes_interface): Remove parameter.
7112         (svr4_handle_solib_event): Use make_scope_exit.
7113
7114 2019-03-06  Tom Tromey  <tom@tromey.com>
7115
7116         * remote.c (struct stop_reply_deleter): Remove.
7117         (stop_reply_up): Update.
7118         (struct stop_reply): Derive from notif_event.  Don't typedef.
7119         <regcache>: Now a std::vector.
7120         (stop_reply_xfree): Remove.
7121         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7122         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7123         (remote_target::discard_pending_stop_replies): Use delete.
7124         (remote_target::remote_parse_stop_reply): Update.
7125         (remote_target::process_stop_reply): Update.
7126         * remote-notif.h (struct notif_event): Add virtual destructor.
7127         Remove "dtr" member.
7128         (struct notif_client) <alloc_event>: Return a unique_ptr.
7129         (notif_event_xfree): Don't declare.
7130         (notif_event_up): New typedef.
7131         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7132         (notif_event_xfree, do_notif_event_xfree): Remove.
7133         (remote_notif_state_xfree): Update.
7134
7135 2019-03-06  Tom Tromey  <tom@tromey.com>
7136
7137         * infrun.c (displaced_step_clear_cleanup): Now a
7138         forward_scope_exit type.
7139         (displaced_step_prepare_throw): Update.
7140         (displaced_step_fixup): Update.
7141
7142 2019-03-06  Tom Tromey  <tom@tromey.com>
7143
7144         * inferior.h (class inferior): Update comment.
7145         * gdbthread.h (class thread_info): Update comment.
7146
7147 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7148             Tom Tromey  <tom@tromey.com>
7149
7150         * stabsread.h (struct stab_section_list): Remove.
7151         (coffstab_build_psymtabs): Update.
7152         * dbxread.c (symbuf_sections): Now a std::vector.
7153         (sect_idx): New global.
7154         (fill_symbuf): Update.
7155         (coffstab_build_psymtabs): Change type of stabsects parameter.
7156         Update.
7157         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7158         std::vector.
7159         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7160         (coff_locate_sections): Update.
7161         (coff_symfile_read): Remove cleanups.  Update.
7162         (init_stringtab): Add storage parameter.
7163         (free_stringtab, free_stringtab_cleanup): Remove.
7164         (init_lineno): Add storage parameter.
7165         (free_linetab, free_linetab_cleanup): Remove.
7166
7167 2019-03-06  Pedro Alves  <palves@redhat.com>
7168
7169         * linux-fork.c (fork_info::clobber_regs): Delete.
7170         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7171         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7172         comment.  Adjust.
7173         (scoped_switch_fork_info::scoped_switch_fork_info)
7174         (checkpoint_command, linux_fork_context): Adjust
7175         fork_save_infrun_state calls.
7176
7177 2019-03-06  Pedro Alves  <palves@redhat.com>
7178
7179         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7180         (inf_has_multiple_threads): Return 'bool' and rewrite using
7181         inferior_info::threads().
7182
7183 2019-03-06  Pedro Alves  <palves@redhat.com>
7184
7185         * linux-fork.c: Include <list>.
7186         (fork_list): Now a std::list instance.
7187         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7188         (forks_exist_p, find_last_fork): Adjust.
7189         (new_fork): Delete.
7190         (one_fork_p): New.
7191         (add_fork): Adjust.
7192         (free_fork): Delete, folded into fork_info::~fork_info().
7193         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7194         Adjust.
7195         (init_fork_list): Delete.
7196         (linux_fork_killall, linux_fork_mourn_inferior)
7197         (linux_fork_detach, info_checkpoints_command): Adjust.
7198         (_initialize_linux_fork): No longer call init_fork_list.
7199
7200 2019-03-06  Pedro Alves  <palves@redhat.com>
7201
7202         * linux-fork.c (new_fork): New, split out of ...
7203         (add_fork): ... this.  Return void.  Move "first fork" special
7204         case from here, to ...
7205         (checkpoint_command): ... here.
7206         * linux-linux.h (add_fork): Return void.
7207
7208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7209
7210         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7211
7212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7213             Chris January  <chris.january@arm.com>
7214             David Lecomber  <david.lecomber@arm.com>
7215
7216         * f-exp.y: New token, UNOP_INTRINSIC.
7217         (exp): New pattern using UNOP_INTRINSIC token.
7218         (f77_keywords): Add 'abs' keyword.
7219         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7220         (value_from_host_double): New function.
7221         (evaluate_subexp_f): Support UNOP_ABS.
7222
7223 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7224
7225         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7226         types.
7227
7228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7229
7230         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7231         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7232         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7233
7234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7235
7236         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7237
7238 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7239             Chris January  <chris.january@arm.com>
7240
7241         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7242         * f-exp.y: Define 'KIND' token.
7243         (exp): New pattern for KIND expressions.
7244         (ptype): Handle types with a kind extension.
7245         (direct_abs_decl): Extend to spot kind extensions.
7246         (f77_keywords): Add 'kind' to the list.
7247         (push_kind_type): New function.
7248         (convert_to_kind_type): New function.
7249         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7250         * parse.c (operator_length_standard): Likewise.
7251         * parser-defs.h (enum type_pieces): Add tp_kind.
7252         * std-operator.def: Add UNOP_KIND.
7253
7254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7255
7256         * f-exp.y (f_parse): Set yydebug.
7257
7258 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7259
7260         * f-lang.c (evaluate_subexp_f): New function.
7261         (exp_descriptor_f): New global.
7262         (f_language_defn): Use exp_descriptor_f instead of
7263         exp_descriptor_standard.
7264
7265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7266
7267         * f-exp.y (struct token): Add comments.
7268         (dot_ops): Remove uppercase versions and the end marker.
7269         (f77_keywords): Likewise.
7270         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7271         entries in the dot_ops array are case insensitive, and use
7272         strncasecmp to compare strings.  Also some whitespace cleanup in
7273         this area.  Similar for the f77_keywords array, except entries in
7274         this list might be case sensitive.
7275
7276 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7277
7278         * f-exp.y (struct f77_boolean_val): Add comments.
7279         (boolean_values): Remove uppercase versions, and end marker.
7280         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7281         and use strncasecmp to achieve case insensitivity.  Additionally,
7282         perform whitespace cleanup around this code.
7283
7284 2019-03-06  Tom Tromey  <tromey@adacore.com>
7285
7286         * remote-sim.c (gdbsim_target_open): Use result of
7287         gdb_argv::release.
7288
7289 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7290         Dirk Schubert  <dirk.schubert@arm.com>
7291         Chris January  <chris.january@arm.com>
7292
7293         * eval.c (evaluate_subexp_standard): Call Fortran argument
7294         wrapping logic.
7295         * f-lang.c (struct value): A value which can be passed into a
7296         Fortran function call.
7297         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7298         where appropriate.
7299         (struct type): Value ready for a Fortran function call.
7300         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7301         is needed.
7302         * f-lang.h (fortran_argument_convert): Declaration.
7303         (fortran_preserve_arg_pointer): Declaration.
7304         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7305
7306 2019-03-05  Tom Tromey  <tromey@adacore.com>
7307
7308         * python/py-prettyprint.c (print_string_repr): Remove #if.
7309         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7310
7311 2019-03-05  Tom Tromey  <tromey@adacore.com>
7312
7313         * target.c (the_dummy_target): Move later.  Change type to
7314         "dummy_target".
7315         (initialize_targets): Don't initialize the_dummy_target.
7316
7317 2019-03-05  Tom Tromey  <tromey@adacore.com>
7318
7319         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7320         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7321
7322 2019-03-05  Tom Tromey  <tromey@adacore.com>
7323
7324         * windows-nat.c (windows_nat_target::attach)
7325         (windows_nat_target::detach): Don't call gdb_flush.
7326         * valprint.c (generic_val_print, val_print, val_print_string):
7327         Don't call gdb_flush.
7328         * utils.c (defaulted_query): Don't call gdb_flush.
7329         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7330         * target.c (target_announce_detach): Don't call gdb_flush.
7331         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7332         * remote.c (extended_remote_target::attach): Don't call
7333         gdb_flush.
7334         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7335         * printcmd.c (do_examine): Don't call gdb_flush.
7336         (info_display_command): Don't call gdb_flush.
7337         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7338         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7339         * memattr.c (info_mem_command): Don't call gdb_flush.
7340         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7341         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7342         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7343         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7344         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7345         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7346         (gnu_nat_target::detach): Don't call gdb_flush.
7347         * f-valprint.c (f_val_print): Don't call gdb_flush.
7348         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7349         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7350         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7351         gdb_flush.
7352         * c-valprint.c (c_val_print): Don't call gdb_flush.
7353         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7354
7355 2019-03-05  Tom Tromey  <tromey@adacore.com>
7356
7357         * varobj.c (update_dynamic_varobj_children): Update.
7358         (install_default_visualizer): Use reset, not release.
7359         * value.c (set_internalvar): Update.
7360         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7361         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7362         ATTRIBUTE_UNUSED_RESULT.
7363
7364 2019-03-05  Tom Tromey  <tromey@adacore.com>
7365
7366         * remote.c (class scoped_remote_fd) <release>: Add
7367         ATTRIBUTE_UNUSED_RESULT.
7368
7369 2019-03-05  Tom Tromey  <tromey@adacore.com>
7370
7371         * macroexp.c (struct macro_buffer) <release>: Add
7372         ATTRIBUTE_UNUSED_RESULT.
7373
7374 2019-03-05  Tom Tromey  <tromey@adacore.com>
7375
7376         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7377         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7378         ATTRIBUTE_UNUSED_RESULT.
7379
7380 2019-03-05  Tom Tromey  <tromey@adacore.com>
7381
7382         * common/scoped_fd.h (class scoped_fd) <release>: Add
7383         ATTRIBUTE_UNUSED_RESULT.
7384
7385 2019-03-05  Tom Tromey  <tromey@adacore.com>
7386
7387         * parser-defs.h (struct parser_state) <release>: Add
7388         ATTRIBUTE_UNUSED_RESULT.
7389
7390 2019-03-05  Tom Tromey  <tromey@adacore.com>
7391
7392         * utils.h (class gdb_argv) <release>: Add
7393         ATTRIBUTE_UNUSED_RESULT.
7394         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7395
7396 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7397
7398         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7399         for-loop range, to avoid compiler warnings.
7400
7401         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7402         avoid compiler warnings about unused variables.
7403
7404         * NEWS: Mention end of support for native debugging on MS-Windows
7405         before XP.
7406
7407         PR gdb/24292
7408         * common/netstuff.c:
7409         * gdbserver/gdbreplay.c
7410         * gdbserver/remote-utils.c:
7411         * ser-tcp.c:
7412         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7413         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7414         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7415         'getaddrinfo' and 'freeaddrinfo' were not available before
7416         Windows XP, and mingw.org's MinGW headers by default define
7417         _WIN32_WINNT to 0x500.
7418
7419 2019-03-01  Gary Benson <gbenson@redhat.com>
7420
7421         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7422
7423 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7424             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7425
7426         PR gdb/8527
7427         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7428         set_sigint_trap, clear_sigint_trap.
7429
7430 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7431
7432         * target.c (target_detach): Clear the regcache and the
7433         frame cache.
7434
7435 2019-02-27  Pedro Alves  <palves@redhat.com>
7436
7437         * utils.c (set_screen_size): When we cap the height/width sizes,
7438         tweak the corresponding command variable to show "unlimited":
7439
7440 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7441             Pedro Alves  <palves@redhat.com>
7442
7443         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7444         before calling rl_set_screen_size.
7445
7446 2019-02-27  Tom Tromey  <tromey@adacore.com>
7447
7448         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7449         define.
7450         * python/py-value.c: Remove Python 2.4 workaround.
7451         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7452         workaround.
7453         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7454         Python 2.4 workaround.
7455         * python/python-internal.h: Remove Python 2.4 comment.
7456         (Py_ssize_t): Don't define.
7457         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7458         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7459         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7460         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7461         * python/python.c (do_start_initialization): Remove Python 2.4
7462         workaround.
7463         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7464         (print_children): Remove Python 2.4 workaround.
7465         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7466         workaround.
7467         (CHARBUFFERPROC_NAME): Remove.
7468         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7469         Python 2.4 workaround.
7470
7471 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7472
7473         * NEWS: Note minimum Python version.
7474
7475 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7476
7477         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7478         code from these functions.  Remove corresponding ifdefs.  Use
7479         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7480         Remove gotos and target of gotos.
7481         (infpy_search_memory): Likewise.
7482
7483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7484
7485         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7486         (hppa_gdbarch_init): Don't register deleted functions with
7487         gdbarch.
7488
7489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7490
7491         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7492         (h8300_unwind_sp): Delete.
7493         (h8300_dummy_id): Delete.
7494         (h8300_gdbarch_init): Don't register deleted functions with
7495         gdbarch.
7496
7497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7498
7499         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7500         (ft32_unwind_pc): Delete.
7501         (ft32_unwind_sp): Delete.
7502         (ft32_gdbarch_init): Don't register deleted functions with
7503         gdbarch.
7504
7505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7506
7507         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7508         (frv_unwind_pc): Delete.
7509         (frv_unwind_sp): Delete.
7510         (frv_gdbarch_init): Don't register deleted functions with
7511         gdbarch.
7512
7513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7514
7515         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7516         (riscv_unwind_pc): Delete.
7517         (riscv_unwind_sp): Delete.
7518         (riscv_gdbarch_init): Don't register deleted functions with
7519         gdbarch.
7520
7521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7522
7523         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7524         (csky_unwind_pc): Delete.
7525         (csky_unwind_sp): Delete.
7526         (csky_gdbarch_init): Don't register deleted functions with
7527         gdbarch.
7528
7529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7530
7531         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7532         (cris_unwind_pc): Delete.
7533         (cris_unwind_sp): Delete.
7534         (cris_gdbarch_init): Don't register deleted functions with
7535         gdbarch.
7536
7537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7538
7539         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7540         (bfin_unwind_pc): Delete.
7541         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7542
7543 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7544
7545         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7546         (arm_unwind_pc): Delete.
7547         (arm_unwind_sp): Delete.
7548         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7549
7550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7551
7552         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7553         (arc_unwind_pc): Delete.
7554         (arc_unwind_sp): Delete.
7555         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7556
7557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7558
7559         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7560         (alpha_unwind_pc): Delete.
7561         (alpha_gdbarch_init): Don't register deleted functions with
7562         gdbarch.
7563
7564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7565
7566         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7567         (aarch64_unwind_pc): Delete.
7568         (aarch64_unwind_sp): Delete.
7569         (aarch64_gdbarch_init): Don't register deleted functions with
7570         gdbarch.
7571
7572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7573
7574         * gdbtypes.c (type_align): Don't consider static members when
7575         computing structure alignment.
7576
7577 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7578
7579         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7580         return 0 for other types.
7581         * arch-utils.c (default_type_align): Always return 0.
7582         * gdbarch.h: Regenerate.
7583         * gdbarch.sh (type_align): Extend comment.
7584         * gdbtypes.c (type_align): Add additional comments, always call
7585         gdbarch_type_align before applying the default rules.
7586         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7587         generic code will then apply a suitable default.
7588         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7589         types, return 0 for other types.
7590
7591 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7592
7593         * NEWS: Create a new section for the next release branch.
7594         Rename the section of the current branch, now that it has
7595         been cut.
7596
7597 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7598
7599         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7600         * version.in: Bump version to 8.3.50.DATE-git.
7601
7602 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7603
7604         * aix-thread.c (ptid_cmp): Remove unused variable.
7605         (get_signaled_thread): Likewise.
7606         (store_regs_user_thread): Likewise.
7607         (store_regs_kernel_thread): Likewise.
7608         (fetch_regs_kernel_thread): Remove shadowed variable.
7609
7610 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7611
7612         * features/riscv/32bit-cpu.xml: Add register numbers.
7613         * features/riscv/32bit-fpu.c: Regenerate.
7614         * features/riscv/32bit-fpu.xml: Add register numbers.
7615         * features/riscv/64bit-cpu.xml: Add register numbers.
7616         * features/riscv/64bit-fpu.c: Regenerate.
7617         * features/riscv/64bit-fpu.xml: Add register numbers.
7618
7619 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7620
7621         * NEWS: Mention two argument form of gdb.Value constructor.
7622         * python/py-value.c (convert_buffer_and_type_to_value): New
7623         function.
7624         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7625         Add support for handling an optional second argument.  Call
7626         convert_buffer_and_type_to_value as appropriate.
7627         * python/python-internal.h (Py_buffer_deleter): New struct.
7628         (Py_buffer_up): New typedef.
7629
7630 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7631
7632         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7633         instead of releasing ownership.
7634
7635 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7636
7637         * dwarf2read.c (open_and_init_dwp_file): Call
7638         elf_numsections instead of bfd_count_sections to initialize
7639         dwp_file->num_sections.
7640
7641 2019-02-25  Tom Tromey  <tromey@adacore.com>
7642
7643         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7644
7645 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7646
7647         * gcore.in: Add '--readnever' option when invoking GDB.
7648
7649 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7650
7651         * MAINTAINERS: Update my email address.
7652
7653 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7654
7655         * build-id.c (build_id_to_debug_bfd_1): New function.
7656         (build_id_to_debug_bfd): Look for separate debug file in
7657         sysroot.
7658
7659 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7660
7661         * gdbarch.sh: Update the copyright year range that is placed into
7662         generated files.
7663
7664 2019-02-22  Keith Seitz  <keiths@redhat.com>
7665
7666         PR symtab/23853
7667         * linespec.c (create_sals_line_offset): Search for the default
7668         symtab's filename instead of its fullname.
7669
7670 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7671
7672         * NEWS: Update style defaults.
7673
7674 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7675
7676         * main.c (captured_main_1): Disable styling in batch mode.
7677
7678 2019-02-20  Tom Tromey  <tom@tromey.com>
7679
7680         * symtab.c (symtab_symbol_info): Fix typos.
7681
7682 2019-02-20  Tom Tromey  <tromey@adacore.com>
7683
7684         * findcmd.c (_initialize_mem_search): Use upper case for
7685         metasyntactic variables.
7686
7687 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7688
7689         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7690         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7691
7692 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7693
7694         * top.h (source_file_name): Change to std::string.
7695         * top.c (source_file_name): Likewise.
7696         (command_line_input): Adjust.
7697         * cli/cli-script.c (script_from_file): Adjust.
7698
7699 2019-02-19  Tom Tromey  <tromey@adacore.com>
7700
7701         * ravenscar-thread.c
7702         (ravenscar_thread_target::update_thread_list): Don't call
7703         ada_build_task_list.
7704         * ada-lang.h (ada_build_task_list): Don't declare.
7705         * ada-tasks.c (struct ada_tasks_inferior_data)
7706         <task_list_valid_p>: Now bool.
7707         (read_known_tasks, ada_task_list_changed)
7708         (ada_tasks_invalidate_inferior_data): Update.
7709         (read_known_tasks_array): Return bool.
7710         (read_known_tasks_list): Likewise.
7711         (read_known_tasks): Return void.
7712         (ada_build_task_list): Now static.
7713
7714 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7715
7716         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7717         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7718
7719 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7720
7721         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7722         variant for ada_tasks_pspace_data_handle and
7723         ada_tasks_inferior_data_handle.
7724         (ada_tasks_pspace_data_cleanup): New function.
7725         (ada_tasks_inferior_data_cleanup): New function.
7726
7727 2019-02-17  Tom Tromey  <tom@tromey.com>
7728
7729         * macrotab.h (macro_source_fullname): Return a std::string.
7730         * macrotab.c (macro_include, check_for_redefinition)
7731         (macro_undef, macro_lookup_definition, foreach_macro)
7732         (foreach_macro_in_scope): Update.
7733         (macro_source_fullname): Return a std::string.
7734         * macrocmd.c (show_pp_source_pos): Update.
7735
7736 2019-02-17  Tom Tromey  <tom@tromey.com>
7737
7738         * macrocmd.c (show_pp_source_pos): Style the file names.
7739
7740 2019-02-17  Tom Tromey  <tom@tromey.com>
7741
7742         PR tui/24197:
7743         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7744
7745 2019-02-17  Tom Tromey  <tom@tromey.com>
7746
7747         * ada-lang.c (user_select_syms): Use filtered printing.
7748         * utils.c (wrap_style): New global.
7749         (desired_style): Remove.
7750         (emit_style_escape): Add stream parameter.
7751         (set_output_style, reset_terminal_style, prompt_for_continue):
7752         Update.
7753         (flush_wrap_buffer): Only flush gdb_stdout.
7754         (wrap_here): Set wrap_style.
7755         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7756         treat escape sequences as a character.  Change when wrap buffer is
7757         flushed.
7758         (fputs_styled): Do not set the output style when the default is
7759         requested.
7760         * ui-style.h (struct ui_file_style) <is_default>: New method.
7761         * source.c (print_source_lines_base): Emit escape sequences in one
7762         piece.
7763
7764 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7765
7766         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7767         integers and enumeration types.
7768
7769 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7770
7771         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7772         instead of lookup_symbol_in_language
7773         (do_exact_match): New function.
7774         (ada_get_symbol_name_matcher): Return do_exact_match when
7775         doing a verbatim match.
7776
7777 2019-02-15  Tom Tromey  <tromey@adacore.com>
7778
7779         * ravenscar-thread.c (ravenscar_thread_target::resume)
7780         (ravenscar_thread_target::wait): Special case wildcard requests.
7781
7782 2019-02-15  Tom Tromey  <tromey@adacore.com>
7783
7784         * ravenscar-thread.c (base_ptid): Remove.
7785         (struct ravenscar_thread_target) <close>: New method.
7786         <m_base_ptid>: New member.
7787         <update_inferior_ptid, active_task, task_is_currently_active,
7788         runtime_initialized>: Declare methods.
7789         <ravenscar_thread_target>: Add constructor.
7790         (ravenscar_thread_target::task_is_currently_active)
7791         (ravenscar_thread_target::update_inferior_ptid)
7792         (ravenscar_runtime_initialized): Rename.  Now methods.
7793         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7794         (ravenscar_thread_target::update_thread_list): Update.
7795         (ravenscar_thread_target::active_task): Now method.
7796         (ravenscar_thread_target::store_registers)
7797         (ravenscar_thread_target::prepare_to_store)
7798         (ravenscar_thread_target::prepare_to_store)
7799         (ravenscar_thread_target::mourn_inferior): Update.
7800         (ravenscar_inferior_created): Use "new" to create target.
7801         (ravenscar_thread_target::get_ada_task_ptid): Update.
7802         (_initialize_ravenscar): Don't initialize base_ptid.
7803         (ravenscar_ops): Remove global.
7804
7805 2019-02-15  Tom Tromey  <tromey@adacore.com>
7806
7807         * target.h (push_target): Declare new overload.
7808         * target.c (push_target): New overload, taking an rvalue reference.
7809         * remote.c (remote_target::open_1): Use push_target overload.
7810         * corelow.c (core_target_open): Use push_target overload.
7811
7812 2019-02-15  Tom Tromey  <tromey@adacore.com>
7813
7814         * ravenscar-thread.c (is_ravenscar_task)
7815         (ravenscar_task_is_currently_active): Return bool.
7816         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7817         (_initialize_ravenscar): Remove "(void)".
7818         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7819         Return bool.
7820
7821 2019-02-15  Tom Tromey  <tromey@adacore.com>
7822
7823         * ravenscar-thread.c (ravenscar_runtime_initializer)
7824         (has_ravenscar_runtime, get_running_thread_id)
7825         (ravenscar_thread_target::resume): Fix indentation.
7826
7827 2019-02-15  Tom Tromey  <tromey@adacore.com>
7828
7829         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7830         from ravenscar_arch_ops.
7831         (sparc_ravenscar_ops::fetch_registers)
7832         (sparc_ravenscar_ops::store_registers): Now methods.
7833         (sparc_ravenscar_prepare_to_store): Remove.
7834         (sparc_ravenscar_ops): Redefine.
7835         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7836         methods and destructor.  Remove members.
7837         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7838         (ravenscar_thread_target::store_registers)
7839         (ravenscar_thread_target::prepare_to_store): Update.
7840         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7841         Remove.
7842         (struct ppc_ravenscar_powerpc_ops): Derive from
7843         ravenscar_arch_ops.
7844         (ppc_ravenscar_powerpc_ops::fetch_registers)
7845         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7846         (ppc_ravenscar_powerpc_ops): Redefine.
7847         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7848         (ppc_ravenscar_e500_ops::fetch_registers)
7849         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7850         (ppc_ravenscar_e500_ops): Redefine.
7851         * aarch64-ravenscar-thread.c
7852         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7853         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7854         (aarch64_ravenscar_fetch_registers)
7855         (aarch64_ravenscar_store_registers): Now methods.
7856         (aarch64_ravenscar_ops): Redefine.
7857
7858 2019-02-15  Tom Tromey  <tromey@adacore.com>
7859
7860         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7861         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7862         (ravenscar_thread_target::stopped_by_watchpoint)
7863         (ravenscar_thread_target::stopped_data_address)
7864         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7865
7866 2019-02-15  Tom Tromey  <tromey@adacore.com>
7867
7868         * ravenscar-thread.c: Fix some typos.
7869
7870 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7871             Tom Tromey  <tromey@adacore.com>
7872
7873         * ada-lang.c (ada_exception_sal): Change addr_string to a
7874         std::string.
7875         (create_ada_exception_catchpoint): Update.
7876
7877 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7878             Tom Tromey  <tromey@adacore.com>
7879
7880         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7881         (bp_location_ops): Remove.
7882         (base_breakpoint_allocate_location): Update.
7883         (free_bp_location): Update.
7884         * ada-lang.c (class ada_catchpoint_location)
7885         <ada_catchpoint_location>: Remove ops parameter.
7886         (ada_catchpoint_location_dtor): Remove.
7887         (ada_catchpoint_location_ops): Remove.
7888         (allocate_location_exception): Update.
7889         * breakpoint.h (struct bp_location_ops): Remove.
7890         (class bp_location) <bp_location>: Remove bp_location_ops
7891         parameter.
7892         <~bp_location>: Add destructor.
7893         <ops>: Remove.
7894
7895 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7896             Pedro Alves  <palves@redhat.com>
7897
7898         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7899         'PATH_MAX'.
7900
7901 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7902             Samuel Thibault  <samuel.thibault@gnu.org>
7903             Thomas Schwinge  <thomas@codesourcery.com>
7904
7905         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7906         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7907
7908 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7909
7910         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7911         (check_empty): Use "const char *".
7912
7913         * gnu-nat.c (gnu_nat_target::detach): Instead of
7914         'detach_inferior (pid)' call
7915         'detach_inferior (find_inferior_pid (pid))'.
7916
7917         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7918         'nat/fork-inferior.o'.
7919         * gnu-nat.c: #include "nat/fork-inferior.h".
7920
7921         * gnu-nat.c (gnu_nat_target::detach): Instead of
7922         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7923         * gnu-nat.h: #include "inf-child.h".
7924         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7925         'i386_gnu_nat_target::fetch_registers'.
7926         (gnu_store_registers): Rename/move to
7927         'i386_gnu_nat_target::store_registers'.
7928
7929         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7930         * gnu-nat.h (mach_thread_info): New function.
7931         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7932
7933         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7934
7935 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7936
7937         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7938
7939 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7940
7941         * windows-nat.c (windows_add_thread): Add new parameter
7942         "main_thread_p" with default value set to false.  Update
7943         function documentation as well as all callers.
7944         (windows_delete_thread): Likewise.
7945         (fake_create_process): Update call to windows_add_thread.
7946         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7947         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7948         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7949         call to windows_delete_thread.
7950
7951 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7952
7953         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7954
7955 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7956
7957         * symfile.c (find_separate_debug_file): Use canonical path of
7958         sysroot with child_path instead of gdb_sysroot if it is valid.
7959
7960 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7961
7962         * symfile.c (find_separate_debug_file): Use child_path to
7963         determine if an object file is under a sysroot.
7964
7965 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7966
7967         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7968         unittests/child-path-selftests.c.
7969         * common/pathstuff.c (child_path): New function.
7970         * common/pathstuff.h (child_path): New prototype.
7971         * unittests/child-path-selftests.c: New file.
7972
7973 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7974
7975         * symfile.c (find_separate_debug_file): Look for separate debug
7976         files in debug directories under the sysroot.
7977
7978 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7979
7980         * symtab.h (struct minimal_symbol data_p): New const method.
7981         (struct minimal_symbol text_p): Likewise.
7982         * symtab.c (output_source_filename): Use file name style
7983         to print file name.
7984         (print_symbol_info): Likewise.
7985         (print_msymbol_info): Use address style to print addresses.
7986         Use function name style to print executable text symbols.
7987         (expand_symtab_containing_pc): Use data_p.
7988         (find_pc_sect_compunit_symtab): Likewise.
7989
7990 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7991
7992         * breakpoint.c (describe_other_breakpoints): Use address style
7993         to print addresses.
7994         (say_where): Likewise.
7995
7996 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7997
7998         * ada-typeprint.c (print_func_type): Print function name
7999         style to print function name.
8000         * c-typeprint.c (c_print_type_1): Likewise.
8001
8002 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8003
8004         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8005         for execve.
8006
8007 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8008
8009         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8010         type_stack.
8011
8012 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8013
8014         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8015         TYPE_CODE_REF types.
8016
8017 2019-02-08  Jim Wilson  <jimw@sifive.com>
8018
8019         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8020         (riscv_linux_fregset): New.
8021         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8022
8023 2019-02-07  Tom Tromey  <tom@tromey.com>
8024
8025         * thread.c (thread_cancel_execution_command): Update.
8026         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8027         methods.
8028         (struct thread_fsm_ops): Remove.
8029         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8030         (thread_fsm_should_stop, thread_fsm_return_value)
8031         (thread_fsm_set_finished, thread_fsm_finished_p)
8032         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8033         Don't declare.
8034         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8035         * infrun.c (clear_proceed_status_thread)
8036         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8037         (print_stop_event): Update.
8038         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8039         Add constructor.
8040         (step_command_fsm_ops): Remove.
8041         (new_step_command_fsm): Remove.
8042         (step_1): Update.
8043         (step_command_fsm::should_stop): Rename from
8044         step_command_fsm_should_stop.
8045         (step_command_fsm::clean_up): Rename from
8046         step_command_fsm_clean_up.
8047         (step_command_fsm::do_async_reply_reason): Rename from
8048         step_command_fsm_async_reply_reason.
8049         (struct until_next_fsm): Inherit from thread_fsm.  Add
8050         constructor.
8051         (until_next_fsm_ops): Remove.
8052         (new_until_next_fsm): Remove.
8053         (until_next_fsm::should_stop): Rename from
8054         until_next_fsm_should_stop.
8055         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8056         (until_next_fsm::do_async_reply_reason): Rename from
8057         until_next_fsm_async_reply_reason.
8058         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8059         constructor.  Change type of breakpoint.
8060         (finish_command_fsm_ops): Remove.
8061         (new_finish_command_fsm): Remove.
8062         (finish_command_fsm::should_stop): Rename from
8063         finish_command_fsm_should_stop.
8064         (finish_command_fsm::clean_up): Rename from
8065         finish_command_fsm_clean_up.
8066         (finish_command_fsm::return_value): Rename from
8067         finish_command_fsm_return_value.
8068         (finish_command_fsm::do_async_reply_reason): Rename from
8069         finish_command_fsm_async_reply_reason.
8070         (finish_command): Update.
8071         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8072         Add constructor.
8073         (call_thread_fsm_ops): Remove.
8074         (call_thread_fsm::call_thread_fsm): Rename from
8075         new_call_thread_fsm.
8076         (call_thread_fsm::should_stop): Rename from
8077         call_thread_fsm_should_stop.
8078         (call_thread_fsm::should_notify_stop): Rename from
8079         call_thread_fsm_should_notify_stop.
8080         (run_inferior_call, call_function_by_hand_dummy): Update.
8081         * cli/cli-interp.c (should_print_stop_to_console): Update.
8082         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8083         Add constructor.  Change type of location_breakpoint,
8084         caller_breakpoint.
8085         (until_break_fsm_ops): Remove.
8086         (new_until_break_fsm): Remove.
8087         (until_break_fsm::should_stop): Rename from
8088         until_break_fsm_should_stop.
8089         (until_break_fsm::clean_up): Rename from
8090         until_break_fsm_clean_up.
8091         (until_break_fsm::do_async_reply_reason): Rename from
8092         until_break_fsm_async_reply_reason.
8093         (until_break_command): Update.
8094         * thread-fsm.c: Remove.
8095         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8096
8097 2019-02-07  Tom Tromey  <tom@tromey.com>
8098
8099         * yy-remap.h: Add include guard.
8100         * xtensa-tdep.h: Add include guard.
8101         * xcoffread.h: Rename include guard.
8102         * varobj-iter.h: Add include guard.
8103         * tui/tui.h: Rename include guard.
8104         * tui/tui-winsource.h: Rename include guard.
8105         * tui/tui-wingeneral.h: Rename include guard.
8106         * tui/tui-windata.h: Rename include guard.
8107         * tui/tui-win.h: Rename include guard.
8108         * tui/tui-stack.h: Rename include guard.
8109         * tui/tui-source.h: Rename include guard.
8110         * tui/tui-regs.h: Rename include guard.
8111         * tui/tui-out.h: Rename include guard.
8112         * tui/tui-layout.h: Rename include guard.
8113         * tui/tui-io.h: Rename include guard.
8114         * tui/tui-hooks.h: Rename include guard.
8115         * tui/tui-file.h: Rename include guard.
8116         * tui/tui-disasm.h: Rename include guard.
8117         * tui/tui-data.h: Rename include guard.
8118         * tui/tui-command.h: Rename include guard.
8119         * tic6x-tdep.h: Add include guard.
8120         * target/waitstatus.h: Rename include guard.
8121         * target/wait.h: Rename include guard.
8122         * target/target.h: Rename include guard.
8123         * target/resume.h: Rename include guard.
8124         * target-float.h: Rename include guard.
8125         * stabsread.h: Add include guard.
8126         * rs6000-tdep.h: Add include guard.
8127         * riscv-fbsd-tdep.h: Add include guard.
8128         * regformats/regdef.h: Rename include guard.
8129         * record.h: Rename include guard.
8130         * python/python.h: Rename include guard.
8131         * python/python-internal.h: Rename include guard.
8132         * python/py-stopevent.h: Rename include guard.
8133         * python/py-ref.h: Rename include guard.
8134         * python/py-record.h: Rename include guard.
8135         * python/py-record-full.h: Rename include guard.
8136         * python/py-record-btrace.h: Rename include guard.
8137         * python/py-instruction.h: Rename include guard.
8138         * python/py-events.h: Rename include guard.
8139         * python/py-event.h: Rename include guard.
8140         * procfs.h: Add include guard.
8141         * proc-utils.h: Add include guard.
8142         * p-lang.h: Add include guard.
8143         * or1k-tdep.h: Rename include guard.
8144         * observable.h: Rename include guard.
8145         * nto-tdep.h: Rename include guard.
8146         * nat/x86-linux.h: Rename include guard.
8147         * nat/x86-linux-dregs.h: Rename include guard.
8148         * nat/x86-gcc-cpuid.h: Add include guard.
8149         * nat/x86-dregs.h: Rename include guard.
8150         * nat/x86-cpuid.h: Rename include guard.
8151         * nat/ppc-linux.h: Rename include guard.
8152         * nat/mips-linux-watch.h: Rename include guard.
8153         * nat/linux-waitpid.h: Rename include guard.
8154         * nat/linux-ptrace.h: Rename include guard.
8155         * nat/linux-procfs.h: Rename include guard.
8156         * nat/linux-osdata.h: Rename include guard.
8157         * nat/linux-nat.h: Rename include guard.
8158         * nat/linux-namespaces.h: Rename include guard.
8159         * nat/linux-btrace.h: Rename include guard.
8160         * nat/glibc_thread_db.h: Rename include guard.
8161         * nat/gdb_thread_db.h: Rename include guard.
8162         * nat/gdb_ptrace.h: Rename include guard.
8163         * nat/fork-inferior.h: Rename include guard.
8164         * nat/amd64-linux-siginfo.h: Rename include guard.
8165         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8166         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8167         * nat/aarch64-linux.h: Rename include guard.
8168         * nat/aarch64-linux-hw-point.h: Rename include guard.
8169         * mn10300-tdep.h: Add include guard.
8170         * mips-linux-tdep.h: Add include guard.
8171         * mi/mi-parse.h: Rename include guard.
8172         * mi/mi-out.h: Rename include guard.
8173         * mi/mi-main.h: Rename include guard.
8174         * mi/mi-interp.h: Rename include guard.
8175         * mi/mi-getopt.h: Rename include guard.
8176         * mi/mi-console.h: Rename include guard.
8177         * mi/mi-common.h: Rename include guard.
8178         * mi/mi-cmds.h: Rename include guard.
8179         * mi/mi-cmd-break.h: Rename include guard.
8180         * m2-lang.h: Add include guard.
8181         * location.h: Rename include guard.
8182         * linux-record.h: Rename include guard.
8183         * linux-nat.h: Add include guard.
8184         * linux-fork.h: Add include guard.
8185         * i386-darwin-tdep.h: Rename include guard.
8186         * hppa-linux-offsets.h: Add include guard.
8187         * guile/guile.h: Rename include guard.
8188         * guile/guile-internal.h: Rename include guard.
8189         * gnu-nat.h: Rename include guard.
8190         * gdb-stabs.h: Rename include guard.
8191         * frv-tdep.h: Add include guard.
8192         * f-lang.h: Add include guard.
8193         * event-loop.h: Add include guard.
8194         * darwin-nat.h: Rename include guard.
8195         * cp-abi.h: Rename include guard.
8196         * config/sparc/nm-sol2.h: Rename include guard.
8197         * config/nm-nto.h: Rename include guard.
8198         * config/nm-linux.h: Add include guard.
8199         * config/i386/nm-i386gnu.h: Rename include guard.
8200         * config/djgpp/nl_types.h: Rename include guard.
8201         * config/djgpp/langinfo.h: Rename include guard.
8202         * compile/gcc-cp-plugin.h: Add include guard.
8203         * compile/gcc-c-plugin.h: Add include guard.
8204         * compile/compile.h: Rename include guard.
8205         * compile/compile-object-run.h: Rename include guard.
8206         * compile/compile-object-load.h: Rename include guard.
8207         * compile/compile-internal.h: Rename include guard.
8208         * compile/compile-cplus.h: Rename include guard.
8209         * compile/compile-c.h: Rename include guard.
8210         * common/xml-utils.h: Rename include guard.
8211         * common/x86-xstate.h: Rename include guard.
8212         * common/version.h: Rename include guard.
8213         * common/vec.h: Rename include guard.
8214         * common/tdesc.h: Rename include guard.
8215         * common/selftest.h: Rename include guard.
8216         * common/scoped_restore.h: Rename include guard.
8217         * common/scoped_mmap.h: Rename include guard.
8218         * common/scoped_fd.h: Rename include guard.
8219         * common/safe-iterator.h: Rename include guard.
8220         * common/run-time-clock.h: Rename include guard.
8221         * common/refcounted-object.h: Rename include guard.
8222         * common/queue.h: Rename include guard.
8223         * common/ptid.h: Rename include guard.
8224         * common/print-utils.h: Rename include guard.
8225         * common/preprocessor.h: Rename include guard.
8226         * common/pathstuff.h: Rename include guard.
8227         * common/observable.h: Rename include guard.
8228         * common/netstuff.h: Rename include guard.
8229         * common/job-control.h: Rename include guard.
8230         * common/host-defs.h: Rename include guard.
8231         * common/gdb_wait.h: Rename include guard.
8232         * common/gdb_vecs.h: Rename include guard.
8233         * common/gdb_unlinker.h: Rename include guard.
8234         * common/gdb_unique_ptr.h: Rename include guard.
8235         * common/gdb_tilde_expand.h: Rename include guard.
8236         * common/gdb_sys_time.h: Rename include guard.
8237         * common/gdb_string_view.h: Rename include guard.
8238         * common/gdb_splay_tree.h: Rename include guard.
8239         * common/gdb_setjmp.h: Rename include guard.
8240         * common/gdb_ref_ptr.h: Rename include guard.
8241         * common/gdb_optional.h: Rename include guard.
8242         * common/gdb_locale.h: Rename include guard.
8243         * common/gdb_assert.h: Rename include guard.
8244         * common/filtered-iterator.h: Rename include guard.
8245         * common/filestuff.h: Rename include guard.
8246         * common/fileio.h: Rename include guard.
8247         * common/environ.h: Rename include guard.
8248         * common/common-utils.h: Rename include guard.
8249         * common/common-types.h: Rename include guard.
8250         * common/common-regcache.h: Rename include guard.
8251         * common/common-inferior.h: Rename include guard.
8252         * common/common-gdbthread.h: Rename include guard.
8253         * common/common-exceptions.h: Rename include guard.
8254         * common/common-defs.h: Rename include guard.
8255         * common/common-debug.h: Rename include guard.
8256         * common/cleanups.h: Rename include guard.
8257         * common/buffer.h: Rename include guard.
8258         * common/btrace-common.h: Rename include guard.
8259         * common/break-common.h: Rename include guard.
8260         * cli/cli-utils.h: Rename include guard.
8261         * cli/cli-style.h: Rename include guard.
8262         * cli/cli-setshow.h: Rename include guard.
8263         * cli/cli-script.h: Rename include guard.
8264         * cli/cli-interp.h: Rename include guard.
8265         * cli/cli-decode.h: Rename include guard.
8266         * cli/cli-cmds.h: Rename include guard.
8267         * charset-list.h: Add include guard.
8268         * buildsym-legacy.h: Rename include guard.
8269         * bfin-tdep.h: Add include guard.
8270         * ax.h: Rename include guard.
8271         * arm-linux-tdep.h: Add include guard.
8272         * arm-fbsd-tdep.h: Add include guard.
8273         * arch/xtensa.h: Rename include guard.
8274         * arch/tic6x.h: Add include guard.
8275         * arch/i386.h: Add include guard.
8276         * arch/arm.h: Rename include guard.
8277         * arch/arm-linux.h: Rename include guard.
8278         * arch/arm-get-next-pcs.h: Rename include guard.
8279         * arch/amd64.h: Add include guard.
8280         * arch/aarch64-insn.h: Rename include guard.
8281         * arch-utils.h: Rename include guard.
8282         * annotate.h: Add include guard.
8283         * amd64-darwin-tdep.h: Rename include guard.
8284         * aarch64-linux-tdep.h: Add include guard.
8285         * aarch64-fbsd-tdep.h: Add include guard.
8286         * aarch32-linux-nat.h: Add include guard.
8287
8288 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8289
8290         * macrotab.c (macro_define_internal): New function that
8291         factorizes macro_define_object_internal and macro_define_function
8292         code.
8293         (macro_define_object_internal): Use macro_define_internal.
8294         (macro_define_function): Likewise.
8295
8296 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8297
8298         * macrocmd.c (extract_identifier): Return
8299         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8300         callers.
8301
8302 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8303
8304         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8305
8306 2019-02-05  Tom Tromey  <tom@tromey.com>
8307
8308         * target.c (target_stack::unpush): Move assertion earlier.
8309
8310 2019-01-30  Tom Tromey  <tom@tromey.com>
8311
8312         PR python/23615:
8313         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8314         (gdbpy_parse_and_eval): Likewise.
8315         * python/python-internal.h (gdbpy_allow_threads): New class.
8316
8317 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8318
8319         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8320         (aarch64_fbsd_fpregmap): Move earlier.
8321         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8322         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8323         instead of individual calls to trad_frame_set_reg_addr.
8324         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8325         earlier.
8326         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8327         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8328         instead of individual calls to trad_frame_set_reg_addr.
8329
8330 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8331
8332         * CONTRIBUTE: Replace contribution list with wiki link.
8333
8334 2019-01-25  Tom Tromey  <tom@tromey.com>
8335
8336         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8337
8338 2019-01-25  Tom Tromey  <tom@tromey.com>
8339
8340         * xtensa-linux-nat.c: Fix common/ includes.
8341         * xml-support.h: Fix common/ includes.
8342         * xml-support.c: Fix common/ includes.
8343         * x86-linux-nat.c: Fix common/ includes.
8344         * windows-nat.c: Fix common/ includes.
8345         * varobj.h: Fix common/ includes.
8346         * varobj.c: Fix common/ includes.
8347         * value.c: Fix common/ includes.
8348         * valops.c: Fix common/ includes.
8349         * utils.c: Fix common/ includes.
8350         * unittests/xml-utils-selftests.c: Fix common/ includes.
8351         * unittests/utils-selftests.c: Fix common/ includes.
8352         * unittests/unpack-selftests.c: Fix common/ includes.
8353         * unittests/tracepoint-selftests.c: Fix common/ includes.
8354         * unittests/style-selftests.c: Fix common/ includes.
8355         * unittests/string_view-selftests.c: Fix common/ includes.
8356         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8357         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8358         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8359         * unittests/rsp-low-selftests.c: Fix common/ includes.
8360         * unittests/parse-connection-spec-selftests.c: Fix common/
8361         includes.
8362         * unittests/optional-selftests.c: Fix common/ includes.
8363         * unittests/offset-type-selftests.c: Fix common/ includes.
8364         * unittests/observable-selftests.c: Fix common/ includes.
8365         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8366         * unittests/memrange-selftests.c: Fix common/ includes.
8367         * unittests/memory-map-selftests.c: Fix common/ includes.
8368         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8369         * unittests/function-view-selftests.c: Fix common/ includes.
8370         * unittests/environ-selftests.c: Fix common/ includes.
8371         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8372         * unittests/common-utils-selftests.c: Fix common/ includes.
8373         * unittests/cli-utils-selftests.c: Fix common/ includes.
8374         * unittests/array-view-selftests.c: Fix common/ includes.
8375         * ui-file.c: Fix common/ includes.
8376         * tui/tui-io.c: Fix common/ includes.
8377         * tracepoint.h: Fix common/ includes.
8378         * tracepoint.c: Fix common/ includes.
8379         * tracefile-tfile.c: Fix common/ includes.
8380         * top.h: Fix common/ includes.
8381         * top.c: Fix common/ includes.
8382         * thread.c: Fix common/ includes.
8383         * target/waitstatus.h: Fix common/ includes.
8384         * target/waitstatus.c: Fix common/ includes.
8385         * target.h: Fix common/ includes.
8386         * target.c: Fix common/ includes.
8387         * target-memory.c: Fix common/ includes.
8388         * target-descriptions.c: Fix common/ includes.
8389         * symtab.h: Fix common/ includes.
8390         * symfile.c: Fix common/ includes.
8391         * stap-probe.c: Fix common/ includes.
8392         * spu-linux-nat.c: Fix common/ includes.
8393         * sparc-nat.c: Fix common/ includes.
8394         * source.c: Fix common/ includes.
8395         * solib.c: Fix common/ includes.
8396         * solib-target.c: Fix common/ includes.
8397         * ser-unix.c: Fix common/ includes.
8398         * ser-tcp.c: Fix common/ includes.
8399         * ser-pipe.c: Fix common/ includes.
8400         * ser-base.c: Fix common/ includes.
8401         * selftest-arch.c: Fix common/ includes.
8402         * s12z-tdep.c: Fix common/ includes.
8403         * rust-exp.y: Fix common/ includes.
8404         * rs6000-aix-tdep.c: Fix common/ includes.
8405         * riscv-tdep.c: Fix common/ includes.
8406         * remote.c: Fix common/ includes.
8407         * remote-notif.h: Fix common/ includes.
8408         * remote-fileio.h: Fix common/ includes.
8409         * remote-fileio.c: Fix common/ includes.
8410         * regcache.h: Fix common/ includes.
8411         * regcache.c: Fix common/ includes.
8412         * record-btrace.c: Fix common/ includes.
8413         * python/python.c: Fix common/ includes.
8414         * python/py-type.c: Fix common/ includes.
8415         * python/py-inferior.c: Fix common/ includes.
8416         * progspace.h: Fix common/ includes.
8417         * producer.c: Fix common/ includes.
8418         * procfs.c: Fix common/ includes.
8419         * proc-api.c: Fix common/ includes.
8420         * printcmd.c: Fix common/ includes.
8421         * ppc-linux-nat.c: Fix common/ includes.
8422         * parser-defs.h: Fix common/ includes.
8423         * osdata.c: Fix common/ includes.
8424         * obsd-nat.c: Fix common/ includes.
8425         * nat/x86-linux.c: Fix common/ includes.
8426         * nat/x86-linux-dregs.c: Fix common/ includes.
8427         * nat/x86-dregs.h: Fix common/ includes.
8428         * nat/x86-dregs.c: Fix common/ includes.
8429         * nat/ppc-linux.c: Fix common/ includes.
8430         * nat/mips-linux-watch.h: Fix common/ includes.
8431         * nat/mips-linux-watch.c: Fix common/ includes.
8432         * nat/linux-waitpid.c: Fix common/ includes.
8433         * nat/linux-ptrace.h: Fix common/ includes.
8434         * nat/linux-ptrace.c: Fix common/ includes.
8435         * nat/linux-procfs.c: Fix common/ includes.
8436         * nat/linux-personality.c: Fix common/ includes.
8437         * nat/linux-osdata.c: Fix common/ includes.
8438         * nat/linux-namespaces.c: Fix common/ includes.
8439         * nat/linux-btrace.h: Fix common/ includes.
8440         * nat/linux-btrace.c: Fix common/ includes.
8441         * nat/fork-inferior.c: Fix common/ includes.
8442         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8443         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8444         * nat/aarch64-linux.c: Fix common/ includes.
8445         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8446         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8447         * namespace.h: Fix common/ includes.
8448         * mips-linux-tdep.c: Fix common/ includes.
8449         * minsyms.c: Fix common/ includes.
8450         * mi/mi-parse.h: Fix common/ includes.
8451         * mi/mi-main.c: Fix common/ includes.
8452         * mi/mi-cmd-env.c: Fix common/ includes.
8453         * memrange.h: Fix common/ includes.
8454         * memattr.c: Fix common/ includes.
8455         * maint.h: Fix common/ includes.
8456         * maint.c: Fix common/ includes.
8457         * main.c: Fix common/ includes.
8458         * machoread.c: Fix common/ includes.
8459         * location.c: Fix common/ includes.
8460         * linux-thread-db.c: Fix common/ includes.
8461         * linux-nat.c: Fix common/ includes.
8462         * linux-fork.c: Fix common/ includes.
8463         * inline-frame.c: Fix common/ includes.
8464         * infrun.c: Fix common/ includes.
8465         * inflow.c: Fix common/ includes.
8466         * inferior.h: Fix common/ includes.
8467         * inferior.c: Fix common/ includes.
8468         * infcmd.c: Fix common/ includes.
8469         * inf-ptrace.c: Fix common/ includes.
8470         * inf-child.c: Fix common/ includes.
8471         * ia64-linux-nat.c: Fix common/ includes.
8472         * i387-tdep.c: Fix common/ includes.
8473         * i386-tdep.c: Fix common/ includes.
8474         * i386-linux-tdep.c: Fix common/ includes.
8475         * i386-linux-nat.c: Fix common/ includes.
8476         * i386-go32-tdep.c: Fix common/ includes.
8477         * i386-fbsd-tdep.c: Fix common/ includes.
8478         * i386-fbsd-nat.c: Fix common/ includes.
8479         * guile/scm-type.c: Fix common/ includes.
8480         * guile/guile.c: Fix common/ includes.
8481         * go32-nat.c: Fix common/ includes.
8482         * gnu-nat.c: Fix common/ includes.
8483         * gdbthread.h: Fix common/ includes.
8484         * gdbarch-selftests.c: Fix common/ includes.
8485         * gdb_usleep.c: Fix common/ includes.
8486         * gdb_select.h: Fix common/ includes.
8487         * gdb_bfd.c: Fix common/ includes.
8488         * gcore.c: Fix common/ includes.
8489         * fork-child.c: Fix common/ includes.
8490         * findvar.c: Fix common/ includes.
8491         * fbsd-nat.c: Fix common/ includes.
8492         * event-top.c: Fix common/ includes.
8493         * event-loop.c: Fix common/ includes.
8494         * dwarf2read.c: Fix common/ includes.
8495         * dwarf2loc.c: Fix common/ includes.
8496         * dwarf2-frame.c: Fix common/ includes.
8497         * dwarf-index-cache.c: Fix common/ includes.
8498         * dtrace-probe.c: Fix common/ includes.
8499         * disasm-selftests.c: Fix common/ includes.
8500         * defs.h: Fix common/ includes.
8501         * csky-tdep.c: Fix common/ includes.
8502         * cp-valprint.c: Fix common/ includes.
8503         * cp-support.h: Fix common/ includes.
8504         * cp-support.c: Fix common/ includes.
8505         * corelow.c: Fix common/ includes.
8506         * completer.h: Fix common/ includes.
8507         * completer.c: Fix common/ includes.
8508         * compile/compile.c: Fix common/ includes.
8509         * compile/compile-loc2c.c: Fix common/ includes.
8510         * compile/compile-cplus-types.c: Fix common/ includes.
8511         * compile/compile-cplus-symbols.c: Fix common/ includes.
8512         * command.h: Fix common/ includes.
8513         * cli/cli-dump.c: Fix common/ includes.
8514         * cli/cli-cmds.c: Fix common/ includes.
8515         * charset.c: Fix common/ includes.
8516         * build-id.c: Fix common/ includes.
8517         * btrace.h: Fix common/ includes.
8518         * btrace.c: Fix common/ includes.
8519         * breakpoint.h: Fix common/ includes.
8520         * breakpoint.c: Fix common/ includes.
8521         * ax.h:
8522         (enum agent_op): Fix common/ includes.
8523         * ax-general.c (struct aop_map): Fix common/ includes.
8524         * ax-gdb.c: Fix common/ includes.
8525         * auxv.c: Fix common/ includes.
8526         * auto-load.c: Fix common/ includes.
8527         * arm-tdep.c: Fix common/ includes.
8528         * arch/riscv.c: Fix common/ includes.
8529         * arch/ppc-linux-common.c: Fix common/ includes.
8530         * arch/i386.c: Fix common/ includes.
8531         * arch/arm.c: Fix common/ includes.
8532         * arch/arm-linux.c: Fix common/ includes.
8533         * arch/arm-get-next-pcs.c: Fix common/ includes.
8534         * arch/amd64.c: Fix common/ includes.
8535         * arch/aarch64.c: Fix common/ includes.
8536         * arch/aarch64-insn.c: Fix common/ includes.
8537         * arch-utils.c: Fix common/ includes.
8538         * amd64-windows-tdep.c: Fix common/ includes.
8539         * amd64-tdep.c: Fix common/ includes.
8540         * amd64-sol2-tdep.c: Fix common/ includes.
8541         * amd64-obsd-tdep.c: Fix common/ includes.
8542         * amd64-nbsd-tdep.c: Fix common/ includes.
8543         * amd64-linux-tdep.c: Fix common/ includes.
8544         * amd64-linux-nat.c: Fix common/ includes.
8545         * amd64-fbsd-tdep.c: Fix common/ includes.
8546         * amd64-fbsd-nat.c: Fix common/ includes.
8547         * amd64-dicos-tdep.c: Fix common/ includes.
8548         * amd64-darwin-tdep.c: Fix common/ includes.
8549         * agent.c: Fix common/ includes.
8550         * ada-lang.h: Fix common/ includes.
8551         * ada-lang.c: Fix common/ includes.
8552         * aarch64-tdep.c: Fix common/ includes.
8553
8554 2019-01-25  Tom Tromey  <tom@tromey.com>
8555
8556         * common/create-version.sh: Use common/version.h.
8557
8558 2019-01-24  Pedro Alves  <palves@redhat.com>
8559
8560         * infrun.c (signal_stop, signal_print, signal_program)
8561         (signal_catch, signal_pass): Now arrays instead of pointers.
8562         (update_signals_program_target, do_target_resume)
8563         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8564         * linux-nat.c (linux_nat_target::pass_signals)
8565         (linux_nat_target::create_inferior, linux_nat_target::attach):
8566         Adjust.
8567         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8568         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8569         * procfs.c (procfs_target::pass_signals): Adjust.
8570         * record-full.c (record_full_target::resume): Adjust.
8571         * remote.c (remote_target::pass_signals)
8572         (remote_target::program_signals): Adjust.
8573         * target-debug.h (target_debug_print_signals): Now takes a
8574         gdb::array_view as parameter.  Adjust.
8575         * target.h (target_ops) <pass_signals, program_signals>: Replace
8576         pointer and length parameters with gdb::array_view.
8577         (target_pass_signals, target_program_signals): Likewise.
8578         * target-delegates.c: Regenerate.
8579
8580 2019-01-24  Pedro Alves  <palves@redhat.com>
8581
8582         * common/forward-scope-exit.h
8583         (forward_scope_exit::forward_scope_exit): Pass arguments to
8584         m_bind_function directly, instead of creating a std::bind and
8585         copying that.
8586
8587 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8588
8589         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8590         for static members.
8591         (pass_in_v_vfp_candidate): Likewise.
8592
8593 2019-01-23  Tom Tromey  <tom@tromey.com>
8594             Pedro Alves  <palves@redhat.com>
8595
8596         * regcache.c (class regcache_invalidator): Remove.
8597         (regcache::raw_write): Use make_scope_exit.
8598
8599 2019-01-23  Tom Tromey  <tom@tromey.com>
8600
8601         * ui-out.h (class ui_out_emit_type): Update comment.
8602
8603 2019-01-23  Tom Tromey  <tom@tromey.com>
8604
8605         * infrun.c (fetch_inferior_event): Update comment.
8606
8607 2019-01-23  Tom Tromey  <tom@tromey.com>
8608             Pedro Alves  <palves@redhat.com>
8609
8610         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8611         parameter.
8612         (fetch_inferior_event): Use SCOPE_EXIT.
8613
8614
8615 2019-01-23  Tom Tromey  <tom@tromey.com>
8616             Pedro Alves  <palves@redhat.com>
8617
8618         * infrun.c (disable_thread_events): Delete.
8619         (stop_all_threads): Use SCOPE_EXIT.
8620
8621 2019-01-23  Tom Tromey  <tom@tromey.com>
8622             Pedro Alves  <palves@redhat.com>
8623
8624         * symfile.c: Include forward-scope-exit.h.
8625         (clear_symtab_users_cleanup): Replace forward declaration with
8626         a FORWARD_SCOPE_EXIT.
8627         (syms_from_objfile_1): Use the forward_scope_exit and
8628         gdb::optional instead of cleanup_function.
8629         (reread_symbols): Use the forward_scope_exit instead of
8630         cleanup_function.
8631         (clear_symtab_users_cleanup): Remove function.
8632
8633 2019-01-23  Tom Tromey  <tom@tromey.com>
8634             Pedro Alves  <palves@redhat.com>
8635
8636         * linux-nat.c: Include scope-exit.h.
8637         (cleanup_target_stop): Remove.
8638         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8639         SCOPE_EXIT.
8640
8641 2019-01-23  Tom Tromey  <tom@tromey.com>
8642             Pedro Alves  <palves@redhat.com>
8643
8644         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8645         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8646
8647 2019-01-23  Tom Tromey  <tom@tromey.com>
8648             Andrew Burgess  <andrew.burgess@embecosm.com>
8649             Pedro Alves  <palves@redhat.com>
8650
8651         * infrun.c (fetch_inferior_event): Use scope_exit.
8652         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8653         * top.c (execute_command): Use scope_exit.
8654         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8655         * utils.c (do_bpstat_clear_actions_cleanup)
8656         (make_bpstat_clear_actions_cleanup): Remove.
8657
8658 2019-01-23  Tom Tromey  <tom@tromey.com>
8659             Pedro Alves  <palves@redhat.com>
8660
8661         * infrun.c: Include "common/scope-exit.h"
8662         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8663         (wait_for_inferior): Use SCOPE_EXIT.
8664         (fetch_inferior_event): Use scope_exit.
8665
8666 2019-01-23  Tom Tromey  <tom@tromey.com>
8667             Pedro Alves  <palves@redhat.com>
8668
8669         * breakpoint.c (create_breakpoint): Remove cleanup.
8670
8671 2019-01-23  Tom Tromey  <tom@tromey.com>
8672             Andrew Burgess  <andrew.burgess@embecosm.com>
8673             Pedro Alves  <palves@redhat.com>
8674
8675 2019-01-23  Pedro Alves  <palves@redhat.com>
8676
8677         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8678
8679 2019-01-23  Pedro Alves  <palves@redhat.com>
8680             Andrew Burgess  <andrew.burgess@embecosm.com>
8681
8682         * gdbthread.h: Include "common/forward-scope-exit.h".
8683         (scoped_finish_thread_state): Redefine custom class in terms of
8684         forward_scope_exit.
8685
8686 2019-01-23  Pedro Alves  <palves@redhat.com>
8687             Andrew Burgess  <andrew.burgess@embecosm.com>
8688
8689         * common/forward-scope-exit.h: New file.
8690
8691 2019-01-23  Pedro Alves  <palves@redhat.com>
8692             Andrew Burgess  <andrew.burgess@embecosm.com>
8693             Tom Tromey  <tom@tromey.com>
8694
8695         * common/scope-exit.h: New file.
8696
8697 2019-01-23  Pedro Alves  <palves@redhat.com>
8698
8699         * common/preprocessor.h (ESC): Rename to ...
8700         (ESC_PARENS): ... this.
8701         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8702         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8703
8704 2019-01-23  Tom Tromey  <tom@tromey.com>
8705
8706         * language.h (class scoped_switch_to_sym_language_if_auto):
8707         Initialize m_lang in both cases.
8708
8709 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8710
8711         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8712         with XCNEW.
8713
8714 2019-01-22  Tom Tromey  <tom@tromey.com>
8715
8716         * corelow.c: Do not include sys/file.h.
8717
8718 2019-01-22  Tom Tromey  <tom@tromey.com>
8719
8720         * tui/tui-wingeneral.h: Include gdb_curses.h.
8721
8722 2019-01-22  Tom Tromey  <tom@tromey.com>
8723
8724         * source-cache.h (class source_cache) <get_source_lines,
8725         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8726
8727 2019-01-22  Tom Tromey  <tom@tromey.com>
8728
8729         * remote-fileio.h (struct remote_target): Declare.
8730
8731 2019-01-22  Tom Tromey  <tom@tromey.com>
8732
8733         * python/py-arch.c: Do not include py-ref.h.
8734         * python/py-bpevent.c: Do not include py-ref.h.
8735         * python/py-cmd.c: Do not include py-ref.h.
8736         * python/py-continueevent.c: Do not include py-ref.h.
8737         * python/py-event.h: Do not include py-ref.h.
8738         * python/py-evtregistry.c: Do not include py-ref.h.
8739         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8740         * python/py-frame.c: Do not include py-ref.h.
8741         * python/py-framefilter.c: Do not include py-ref.h.
8742         * python/py-function.c: Do not include py-ref.h.
8743         * python/py-infevents.c: Do not include py-ref.h.
8744         * python/py-linetable.c: Do not include py-ref.h.
8745         * python/py-objfile.c: Do not include py-ref.h.
8746         * python/py-param.c: Do not include py-ref.h.
8747         * python/py-prettyprint.c: Do not include py-ref.h.
8748         * python/py-progspace.c: Do not include py-ref.h.
8749         * python/py-symbol.c: Do not include py-ref.h.
8750         * python/py-symtab.c: Do not include py-ref.h.
8751         * python/py-type.c: Do not include py-ref.h.
8752         * python/py-unwind.c: Do not include py-ref.h.
8753         * python/py-utils.c: Do not include py-ref.h.
8754         * python/py-value.c: Do not include py-ref.h.
8755         * python/py-varobj.c: Do not include py-ref.h.
8756         * python/py-xmethods.c: Do not include py-ref.h.
8757         * python/python.c: Do not include py-ref.h.
8758         * varobj.c: Do not include py-ref.h.
8759
8760 2019-01-22  Tom Tromey  <tom@tromey.com>
8761
8762         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8763         keyword for bcache.
8764
8765 2019-01-22  Tom Tromey  <tom@tromey.com>
8766
8767         * compile/compile-cplus-types.c: Remove a comment by #include.
8768
8769 2019-01-22  Tom Tromey  <tom@tromey.com>
8770
8771         * compile/gcc-c-plugin.h: Include compile-internal.h.
8772
8773 2019-01-22  Tom Tromey  <tom@tromey.com>
8774
8775         * stabsread.c (EXTERN): Do not define.
8776         (symnum, next_symbol_text_func, processing_gcc_compilation)
8777         (within_function, global_sym_chain, global_stabs)
8778         (previous_stab_code, this_object_header_files)
8779         (n_this_object_header_files)
8780         (n_allocated_this_object_header_files): Define.
8781         * stabsread.h (EXTERN): Never define.  Use "extern".
8782
8783 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8784
8785         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8786         history_value.
8787
8788 2019-01-21  Tom Tromey  <tom@tromey.com>
8789
8790         * ui-out.c: Fix includes.
8791         * tui/tui-source.c: Fix includes.
8792         * target.c: Fix includes.
8793         * remote.c: Fix includes.
8794         * regcache.c: Fix includes.
8795         * python/py-block.c: Fix includes.
8796         * printcmd.c: Fix includes.
8797         * or1k-tdep.c: Fix includes.
8798         * mi/mi-main.c: Fix includes.
8799         * m32r-tdep.c: Fix includes.
8800         * csky-tdep.c: Fix includes.
8801         * compile/compile-cplus-types.c: Fix includes.
8802         * cli/cli-interp.c: Fix includes.
8803
8804 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8805
8806         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8807         for padding.
8808
8809 2019-01-16  Tom Tromey  <tom@tromey.com>
8810
8811         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8812         earlier.
8813         (struct objfile) <msymbols_range>: Move from top level.
8814         <msymbols>: New method.
8815         (class objfile_msymbols): Remove.
8816         * symtab.c (default_collect_symbol_completion_matches_break_on):
8817         Update.
8818         * symmisc.c (dump_msymbols): Update.
8819         * stabsread.c (scan_file_globals): Update.
8820         * objc-lang.c (info_selectors_command, info_classes_command)
8821         (find_methods): Update.
8822         * minsyms.c (find_solib_trampoline_target): Update.
8823         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8824         * coffread.c (coff_symfile_read): Update.
8825         * ada-lang.c (ada_lookup_simple_minsym)
8826         (ada_collect_symbol_completion_matches): Update.
8827
8828 2019-01-16  Tom Tromey  <tom@tromey.com>
8829
8830         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8831         type.  Remove no-argument constructor.
8832         <iterator::operator++>: Simplify.
8833         <begin>: Update.
8834         <end>: Use minimal_symbol_count.
8835
8836 2019-01-16  Tom Tromey  <tom@tromey.com>
8837
8838         * objfiles.h (struct objfile) <psymtabs>: New method.
8839         (class objfile_psymtabs): Remove.
8840         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8841         typedef.
8842         <range>: New method.
8843         (require_partial_symbols): Change return type.
8844         * psymtab.c (require_partial_symbols)
8845         (psym_expand_symtabs_matching): Update.
8846         * mdebugread.c (parse_partial_symbols): Update.
8847         * dbxread.c (dbx_end_psymtab): Update.
8848
8849 2019-01-15  Tom Tromey  <tom@tromey.com>
8850
8851         * symtab.c (lookup_objfile_from_block)
8852         (lookup_symbol_in_objfile_symtabs)
8853         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8854         (find_line_symtab, info_sources_command)
8855         (default_collect_symbol_completion_matches_break_on)
8856         (make_source_files_completion_list): Update.
8857         * symmisc.c (print_objfile_statistics, dump_objfile)
8858         (maintenance_print_symbols, maintenance_info_symtabs)
8859         (maintenance_check_symtabs, maintenance_info_line_tables):
8860         Update.
8861         * source.c (select_source_symtab)
8862         (forget_cached_source_info_for_objfile): Update.
8863         * objfiles.h (class objfile_compunits): Remove.
8864         (struct objfile) <compunits_range>: New typedef.
8865         (compunits): New method.
8866         * objfiles.c (objfile_relocate1): Update.
8867         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8868         * maint.c (count_symtabs_and_blocks): Update.
8869         * linespec.c (iterate_over_all_matching_symtabs): Update.
8870         * cp-support.c (add_symbol_overload_list_qualified): Update.
8871         * coffread.c (coff_symtab_read): Update.
8872         * ada-lang.c (add_nonlocal_symbols)
8873         (ada_collect_symbol_completion_matches)
8874         (ada_add_global_exceptions): Update.
8875
8876 2019-01-15  Tom Tromey  <tom@tromey.com>
8877
8878         * progspace.h (program_space) <objfiles_safe_range>: New
8879         typedef.
8880         <objfiles_safe>: New method.
8881         * objfiles.h (class all_objfiles_safe): Remove.
8882         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8883         * jit.c (jit_inferior_exit_hook): Update.
8884
8885 2019-01-17  Tom Tromey  <tom@tromey.com>
8886
8887         * progspace.h (program_space) <objfiles_range>: New typedef.
8888         <objfiles>: New method.
8889         <objfiles_head>: Rename from objfiles.
8890         (object_files): Update.
8891         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8892         * guile/scm-pretty-print.c
8893         (ppscm_find_pretty_printer_from_objfiles): Update.
8894         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8895         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8896         Update.
8897         * python/py-progspace.c (pspy_get_objfiles): Update.
8898         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8899         Update.
8900         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8901         (objfpy_lookup_objfile_by_build_id): Update.
8902         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8903         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8904         Update.
8905         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8906         (expand_symtab_containing_pc, lookup_objfile_from_block)
8907         (lookup_static_symbol, basic_lookup_transparent_type)
8908         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8909         (find_line_symtab, info_sources_command)
8910         (default_collect_symbol_completion_matches_break_on)
8911         (make_source_files_completion_list, find_main_name): Update.
8912         * symmisc.c (print_symbol_bcache_statistics)
8913         (print_objfile_statistics, maintenance_print_symbols)
8914         (maintenance_print_msymbols, maintenance_print_objfiles)
8915         (maintenance_info_symtabs, maintenance_check_symtabs)
8916         (maintenance_expand_symtabs, maintenance_info_line_tables):
8917         Update.
8918         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8919         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8920         (map_overlay_command, unmap_overlay_command)
8921         (simple_overlay_update, expand_symtabs_matching)
8922         (map_symbol_filenames): Update.
8923         * symfile-debug.c (set_debug_symfile): Update.
8924         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8925         Update.
8926         * source.c (select_source_symtab, forget_cached_source_info):
8927         Update.
8928         * solib.c (solib_read_symbols): Update.
8929         * solib-spu.c (append_ocl_sos): Update.
8930         * psymtab.c (maintenance_print_psymbols)
8931         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8932         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8933         * printcmd.c (info_symbol_command): Update.
8934         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8935         Update.
8936         * objfiles.h (class all_objfiles): Remove.
8937         * objfiles.c (have_partial_symbols, have_full_symbols)
8938         (have_minimal_symbols, qsort_cmp, update_section_map)
8939         (shared_objfile_contains_address_p)
8940         (default_iterate_over_objfiles_in_search_order): Update.
8941         * objc-lang.c (info_selectors_command, info_classes_command)
8942         (find_methods): Update.
8943         * minsyms.c (find_solib_trampoline_target): Update.
8944         * maint.c (maintenance_info_sections)
8945         (maintenance_translate_address, count_symtabs_and_blocks):
8946         Update.
8947         * main.c (captured_main_1): Update.
8948         * linux-thread-db.c (try_thread_db_load_from_pdir)
8949         (has_libpthread): Update.
8950         * linespec.c (iterate_over_all_matching_symtabs)
8951         (search_minsyms_for_name): Update.
8952         * jit.c (jit_find_objf_with_entry_addr): Update.
8953         * hppa-tdep.c (find_unwind_entry)
8954         (hppa_lookup_stub_minimal_symbol): Update.
8955         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8956         Update.
8957         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8958         (elf_gnu_ifunc_resolve_by_got): Update.
8959         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8960         * dwarf-index-write.c (save_gdb_index_command): Update.
8961         * cp-support.c (add_symbol_overload_list_qualified): Update.
8962         * breakpoint.c (create_overlay_event_breakpoint)
8963         (create_longjmp_master_breakpoint)
8964         (create_std_terminate_master_breakpoint)
8965         (create_exception_master_breakpoint): Update.
8966         * blockframe.c (find_pc_partial_function): Update.
8967         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8968         (ada_collect_symbol_completion_matches)
8969         (ada_add_global_exceptions): Update.
8970
8971 2019-01-17  Tom Tromey  <tom@tromey.com>
8972
8973         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8974         declare VEC.
8975         (solib_target_parse_libraries): Change return type.
8976         (library_list_start_segment, library_list_start_section)
8977         (library_list_end_library, library_list_start_library); Update.
8978         (solib_target_free_library_list): Remove.
8979         (solib_target_parse_libraries): Remove cleanup.  Change return
8980         type.
8981         (solib_target_current_sos): Update.
8982
8983 2019-01-17  Tom Tromey  <tromey@bapiya>
8984
8985         * valprint.c: Replace "the the" with "the".
8986         * symtab.c: Replace "the the" with "the".
8987         * solib.c: Replace "the the" with "the".
8988         * solib-dsbt.c: Replace "the the" with "the".
8989         * linespec.c: Replace "the the" with "the".
8990         * dwarf2loc.h: Replace "the the" with "the".
8991         * amd64-windows-tdep.c: Replace "the the" with "the".
8992         * aarch64-tdep.c: Replace "the the" with "the".
8993
8994 2019-01-16  Keith Seitz  <keiths@redhat.com>
8995
8996         PR gdb/23773
8997         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8998         <builder>: Rename to ..
8999         <m_builder>: ... this and make private.
9000         (dwarf2_cu::get_builder): New method.  Change all users of
9001         `builder' to use this method.
9002         (dwarf2_start_symtab): Move to ...
9003         (dwarf2_cu::start_symtab): ... here.  Update all callers
9004         (setup_type_unit_groups): Move to ...
9005         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9006         callers.
9007         (dwarf2_cu::reset_builder): New method.
9008         (process_full_compunit, process_full_type_unit): Use
9009         dwarf2_cu::reset_builder.
9010         (follow_die_offset): Record the ancestor CU if it is different
9011         from the followed DIE's CU.
9012         (follow_die_sig_1): Likewise.
9013
9014 2019-01-15  Tom Tromey  <tom@tromey.com>
9015
9016         * remote.c (class remote_state) <buf>: Now a char_vector.
9017         <buf_size>: Remove.
9018         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9019         parameter.
9020         (remote_target::getpkt_or_notif_sane_1)
9021         (remote_target::getpkt_sane)
9022         (remote_target::getpkt_or_notif_sane): Likewise.
9023         (class remote_target) <putpkt>: New overload.
9024         (remote_target::read_frame): Change type of "buf_p".  Remove
9025         sizeof_p parameter.
9026         (packet_ok): New overload.
9027         (packet_check_result): New overload.
9028         Update all uses.
9029
9030 2019-01-14  Tom Tromey  <tom@tromey.com>
9031
9032         * remote-notif.c (handle_notification, remote_notif_ack)
9033         (remote_notif_parse): Make "buf" const.
9034         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9035         const.
9036         (remote_notif_parse, remote_notif_ack, handle_notification):
9037         Likewise.
9038         * remote.c (remote_notif_stop_parse): Make "buf" const.
9039         (remote_target::remote_parse_stop_reply): Make "buf" const.
9040         (remote_notif_stop_ack): Make "buf" const.
9041
9042 2019-01-14  Tom Tromey  <tom@tromey.com>
9043
9044         * remote.c (remote_console_output): Make parameter const.
9045
9046 2019-01-14  Tom Tromey  <tom@tromey.com>
9047
9048         * target-debug.h (target_debug_print_signals): Constify.
9049         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9050         * procfs.c (procfs_target::pass_signals): Update.
9051         * linux-nat.c (linux_nat_target::pass_signals): Update.
9052         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9053         * target-delegates.c: Rebuild.
9054         * remote.c (remote_target::program_signals): Update.
9055         (remote_target::pass_signals): Update.
9056         * target.c (target_pass_signals): Constify argument.
9057         (target_program_signals): Likewise.
9058         * target.h (struct target_ops) <pass_signals, program_signals>:
9059         Constify argument.
9060         (target_pass_signals, target_program_signals): Constify argument.
9061
9062 2019-01-14  Tom Tromey  <tom@tromey.com>
9063
9064         PR tui/28819:
9065         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9066
9067 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9068
9069         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9070         field.
9071         * rs6000-tdep.c: Include reggroups.h.
9072         (IS_V_ALIAS_PSEUDOREG): Define.
9073         (rs6000_register_name): Return names for the "vX" aliases.
9074         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9075         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9076         aliases.  Call default_register_reggroup_p for all other
9077         pseudo-registers.
9078         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9079         New functions.
9080         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9081         Handle "vX" aliases.
9082         (v_alias_pseudo_register_collect): New function.
9083         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9084         (rs6000_gdbarch_init): Initialize "vX" aliases as
9085         pseudo-registers.  Restore registration of
9086         rs6000_pseudo_register_reggroup_p with
9087         set_tdesc_pseudo_register_reggroup_p.
9088
9089 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9090
9091         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9092         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9093         set_gdbarch_num_pseudo_regs.
9094
9095 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9096
9097         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9098         Remove arg prefixname, add do_set and do_show.
9099         Add member functions set_list and show_list.
9100         * cli/cli-style.c (class cli_style_option): Update accordingly.
9101         (style_set_list): Move to file scope.
9102         (style_show_list): Likewise.
9103         (set_style): Call help_list.
9104         (show_style): Call cmd_show_list.
9105         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9106         Update to use the new macro.
9107
9108 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9109
9110         * ada-lang.c (_initialize_ada_language): Expand the help text
9111         for the "catch exception" command.
9112
9113 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9114
9115         * symtab.c (matching_obj_sections): Initialize obj,
9116         declare it closer to its usage.
9117
9118 2019-01-10  Tom Tromey  <tom@tromey.com>
9119
9120         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9121         (basic_inf_threads_range): Remove.
9122         (inf_threads_range, inf_non_exited_threads_range)
9123         (safe_inf_threads_range): Use next_adapter.
9124
9125 2019-01-10  Keith Seitz  <keiths@redhat.com>
9126
9127         PR gdb/23712
9128         PR symtab/23010
9129         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9130         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9131
9132 2019-01-10  Keith Seitz  <keiths@redhat.com>
9133
9134         PR gdb/23712
9135         PR symtab/23010
9136         * dictionary.c (pending_to_vector): Remove.
9137         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9138         Remove _1 suffix, replacing functions of the same name.  Update
9139         all callers.
9140         (dict_create_hashed, dict_create_hashed_expandable)
9141         (dict_create_linear, dict_create_linear_expandable, dict_free)
9142         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9143         Make functions static.
9144
9145 2019-01-10  Keith Seitz  <keiths@redhat.com>
9146
9147         PR gdb/23712
9148         PR symtab/23010
9149         * dictionary.h (struct dictionary): Replace declaration with
9150         multidictionary.
9151         (dict_create_hashed, dict_create_hashed_expandable)
9152         (dict_create_linear, dict_create_linear_expandable)
9153         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9154         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9155         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9156         taking multidictionary argument.
9157         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9158         * block.h (struct block) <dict>: Change to multidictionary
9159         and rename `multidict'.
9160         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9161         symmisc.c: Update all dictionary references to multidictionary.
9162
9163 2019-01-10  Keith Seitz  <keiths@redhat.com>
9164
9165         PR gdb/23712
9166         PR symtab/23010
9167         * dictionary.c: Include unordered_map.
9168         (pending_to_vector): New function.
9169         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9170         Rewrite the non-"_1" functions to take vector instead
9171         of linked list.
9172         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9173         "new" _1 versions of the same name.
9174         (multidictionary): Define.
9175         (std::hash<enum language): New definition.
9176         (collate_pending_symbols_by_language, mdict_create_hashed)
9177         (mdict_create_hashed_expandable, mdict_create_linear)
9178         (mdict_create_linear_expandable, mdict_free)
9179         (find_language_dictionary, create_new_language_dictionary)
9180         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9181         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9182         (mdict_size, mdict_empty): New functions.
9183         * dictionary.h (mdict_iterator): Define.
9184
9185 2019-01-10  Pedro Alves  <palves@redhat.com>
9186
9187         * breakpoint.c (read_uploaded_action)
9188         (create_tracepoint_from_upload): Adjust to use
9189         gdb::unique_xmalloc_ptr.
9190         * ctf.c (ctf_write_uploaded_tp):
9191         (SET_ARRAY_FIELD): Use emplace_back.
9192         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9193         * tracefile-tfile.c (tfile_write_uploaded_tp):
9194         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9195         gdb::unique_xmalloc_ptr.
9196         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9197         at_string, cond_string, cmd_strings>: Replace char pointers
9198         with gdb::unique_xmalloc_ptr.
9199
9200 2019-01-10  Pedro Alves  <palves@redhat.com>
9201
9202         * solib-target.c (library_list_start_library): Don't xstrdup name.
9203
9204 2019-01-10  Pedro Alves  <palves@redhat.com>
9205
9206         * mdebugread.c (parse_partial_symbols): Use
9207         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9208
9209 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9210
9211         * linux-fork.c (scoped_switch_fork_info)
9212         <~scoped_switch_fork_info>: Fix incorrect variable name.
9213
9214 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9215
9216         * linux-fork.c (scoped_switch_fork_info)
9217         <scoped_switch_fork_info>: Make explicit.
9218         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9219
9220 2019-01-10  Tom Tromey  <tom@tromey.com>
9221
9222         * objfiles.h (objfile::reset_psymtabs): Update.
9223         * objfiles.c (objfile::objfile): Update.
9224         * psymtab.h (psymtab_storage::obstack): Update.
9225         (psymtab_storage::m_obstack): Use gdb::optional.
9226         (class psymtab_storage): Update comment.  Remove objfile
9227         parameter.
9228         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9229
9230 2019-01-10  Tom Tromey  <tom@tromey.com>
9231
9232         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9233         <free_psymtabs>: Now private.
9234         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9235         (allocate_psymtab): Use new method.
9236
9237 2019-01-10  Tom Tromey  <tom@tromey.com>
9238
9239         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9240         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9241         * mdebugread.c (parse_partial_symbols): Use
9242         allocate_dependencies.
9243         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9244         allocate_dependencies.
9245         (process_psymtab_comp_unit_reader)
9246         (build_type_psymtab_dependencies): Likewise.
9247         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9248
9249 2019-01-10  Tom Tromey  <tom@tromey.com>
9250
9251         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9252         PSYMBOL_SET_LANGUAGE.
9253         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9254
9255 2019-01-10  Tom Tromey  <tom@tromey.com>
9256
9257         * psymtab.h (psymtab_storage::obstack): New method.
9258         <m_obstack>: Rename from obstack; now private.
9259         * psymtab.c (psymtab_storage): Update.
9260         * dwarf2read.c (create_addrmap_from_index)
9261         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9262         Update.
9263
9264 2019-01-10  Tom Tromey  <tom@tromey.com>
9265
9266         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9267         * objfiles.h (objfile::reset_psymtabs): New method.
9268
9269 2019-01-10  Tom Tromey  <tom@tromey.com>
9270
9271         * symmisc.c (print_symbol_bcache_statistics): Update.
9272         (print_objfile_statistics): Update.
9273         * symfile.c (reread_symbols): Update.
9274         * psymtab.h (class psymtab_storage): New.
9275         * psymtab.c (psymtab_storage): New constructor.
9276         (~psymtab_storage): New destructor.
9277         (require_partial_symbols): Update.
9278         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9279         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9280         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9281         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9282         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9283         (start_psymtab_common, end_psymtab_common)
9284         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9285         (allocate_psymtab): Update.
9286         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9287         Update.
9288         (dump_psymtab_addrmap, maintenance_print_psymbols)
9289         (maintenance_check_psymtabs): Update.
9290         (class objfile_psymtabs): Move to objfiles.h.
9291         * psympriv.h (discard_psymtab): Now inline.
9292         (psymtab_discarder::psymtab_discarder): Update.
9293         (psymtab_discarder::~psymtab_discarder): Update.
9294         (ALL_OBJFILE_PSYMTABS): Rewrite.
9295         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9296         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9297         Remove fields.
9298         <partial_symtabs>: New field.
9299         (class objfile_psymtabs): Move from psymtab.h.  Update.
9300         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9301         psymbol_cache.
9302         (objfile::~objfile): Don't destroy psymbol_cache.
9303         * mdebugread.c (parse_partial_symbols): Update.
9304         * dwarf2read.c (create_addrmap_from_index)
9305         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9306         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9307         (add_partial_subprogram, dwarf2_ranges_read): Update.
9308         * dwarf-index-write.c (write_address_map)
9309         (write_one_signatured_type, recursively_write_psymbols)
9310         (class debug_names, class debug_names, write_psymtabs_to_index):
9311         Update.
9312
9313 2019-01-10  Tom Tromey  <tom@tromey.com>
9314
9315         * symtab.h (SYMBOL_SET_NAMES): Update.
9316         (symbol_set_names): Update.
9317         (MSYMBOL_SET_NAMES): Update.
9318         * symtab.c (symbol_set_names): Change argument to be an
9319         objfile_per_bfd_storage.
9320         * psymtab.c (add_psymbol_to_bcache): Update.
9321         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9322
9323 2019-01-10  Tom Tromey  <tom@tromey.com>
9324
9325         * symtab.c (create_demangled_names_hash): Change argument to be an
9326         objfile_per_bfd_storage.
9327         (symbol_set_names): Update.
9328
9329 2019-01-10  Tom Tromey  <tom@tromey.com>
9330
9331         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9332         init_psymbol_list.
9333         * psymtab.c (init_psymbol_list): Do nothing if already called.
9334         * psympriv.h (init_psymbol_list): Add comment.
9335         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9336         init_psymbol_list.
9337         * dbxread.c (dbx_symfile_read): Unconditionally call
9338         init_psymbol_list.
9339
9340 2019-01-10  Tom Tromey  <tom@tromey.com>
9341
9342         * xcoffread.c (scan_xcoff_symtab): Update.
9343         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9344         "where".
9345         * mdebugread.c (parse_partial_symbols)
9346         (handle_psymbol_enumerators): Update.
9347         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9348         * dbxread.c (read_dbx_symtab): Update.
9349         * psympriv.h (psymbol_placement): New enum.
9350         (add_psymbol_to_list): Update.
9351
9352 2019-01-10  Tom Tromey  <tom@tromey.com>
9353
9354         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9355         static_psymbols parameters.
9356         (scan_xcoff_symtab): Update.
9357         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9358         static_psymbols parameters.
9359         * psympriv.h (start_psymtab_common): Update.
9360         * mdebugread.c (parse_partial_symbols): Update.
9361         * dwarf2read.c (create_partial_symtab): Update.
9362         * dbxread.c (read_dbx_symtab): Update.
9363         (start_psymtab): Remove global_psymbols and static_psymbols
9364         parameters.
9365
9366 2019-01-10  Tom Tromey  <tom@tromey.com>
9367
9368         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9369         * psymtab.c (allocate_psymtab): Add comment.
9370         * psympriv.h (allocate_psymtab): Add comment.
9371         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9372         initializations.
9373         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9374
9375 2019-01-10  Tom Tromey  <tom@tromey.com>
9376
9377         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9378         Don't declare.
9379         * mipsread.c: Include mdebugread.h.
9380         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9381         Declare.
9382         * elfread.c: Include mdebugread.h.
9383
9384 2019-01-09  Tom Tromey  <tom@tromey.com>
9385
9386         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9387         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9388         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9389         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9390         (psym_lookup_symbol, psym_find_last_source_symtab)
9391         (psym_forget_cached_source_info, psym_print_stats)
9392         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9393         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9394         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9395         (psym_find_compunit_symtab_by_address)
9396         (maintenance_print_psymbols, maintenance_info_psymtabs)
9397         (maintenance_check_psymtabs): Use ranged for.
9398         * psymtab.h (class objfile_psymtabs): New.
9399         (require_partial_symbols): Return objfile_psymtabs.
9400         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9401
9402 2019-01-09  Tom Tromey  <tom@tromey.com>
9403
9404         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9405         (find_pc_mapped_section, list_overlays_command)
9406         (map_overlay_command, unmap_overlay_command)
9407         (simple_overlay_update): Use all_objfiles.
9408         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9409         * printcmd.c (info_symbol_command): Use all_objfiles.
9410         * objfiles.h (ALL_OBJSECTIONS): Remove.
9411         * maint.c (maintenance_translate_address): Use all_objfiles.
9412         * gcore.c (gcore_create_callback): Use all_objfiles.
9413         (objfile_find_memory_regions): Likewise.
9414
9415 2019-01-09  Tom Tromey  <tom@tromey.com>
9416
9417         * symtab.c (find_line_symtab, info_sources_command)
9418         (make_source_files_completion_list): Use objfile_compunits.
9419         * source.c (select_source_symtab): Use objfile_compunits.
9420         * objfiles.h (struct objfile): Update comment.
9421         (ALL_OBJFILES): Remove.
9422         (ALL_FILETABS): Remove.
9423         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9424         objfile_compunits.
9425
9426 2019-01-09  Tom Tromey  <tom@tromey.com>
9427
9428         * symmisc.c (print_objfile_statistics, dump_objfile)
9429         (maintenance_print_symbols): Use compunit_filetabs.
9430         * source.c (forget_cached_source_info_for_objfile): Use
9431         compunit_filetabs.
9432         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9433         (ALL_FILETABS): Use compunit_filetabs.
9434         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9435         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9436
9437 2019-01-09  Tom Tromey  <tom@tromey.com>
9438
9439         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9440         (compunit_filetabs): New.
9441         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9442         compunit_filetabs.
9443         (info_sources_command, make_source_files_completion_list): Remove
9444         declaration.
9445         * symmisc.c (print_objfile_statistics, dump_objfile)
9446         (maintenance_print_symbols): Remove declaration.
9447         (maintenance_info_symtabs): Use compunit_filetabs.
9448         (maintenance_info_line_tables): Likewise.
9449         * source.c (select_source_symtab): Change local variable name.
9450         (forget_cached_source_info_for_objfile): Remove declaration.
9451         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9452         * objfiles.c (objfile_relocate1): Remove declaration.
9453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9454         declaration.
9455         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9456         * coffread.c (coff_symtab_read): Remove declaration.
9457         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9458         compunit_filetabs.
9459
9460 2019-01-09  Tom Tromey  <tom@tromey.com>
9461
9462         * symtab.c (lookup_objfile_from_block)
9463         (find_pc_sect_compunit_symtab, search_symbols)
9464         (default_collect_symbol_completion_matches_break_on): Use
9465         objfile_compunits.
9466         * objfiles.h (ALL_COMPUNITS): Remove.
9467         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9468         * cp-support.c (add_symbol_overload_list_qualified): Use
9469         objfile_compunits.
9470         * ada-lang.c (ada_collect_symbol_completion_matches)
9471         (ada_add_global_exceptions): Use objfile_compunits.
9472
9473 2019-01-09  Tom Tromey  <tom@tromey.com>
9474
9475         * source.c (select_source_symtab)
9476         (forget_cached_source_info_for_objfile): Remove declaration.
9477         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9478         declaration.
9479         * maint.c (count_symtabs_and_blocks): Remove declaration.
9480         * cp-support.c (add_symbol_overload_list_qualified): Remove
9481         declaration.
9482         * coffread.c (coff_symtab_read): Remove declaration.
9483         * symtab.c (lookup_symbol_in_objfile_symtabs)
9484         (basic_lookup_transparent_type_1): Use objfile_compunits.
9485         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9486         (info_sources_command, search_symbols)
9487         (default_collect_symbol_completion_matches_break_on)
9488         (make_source_files_completion_list): Remove declaration.
9489         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9490         (ada_collect_symbol_completion_matches)
9491         (ada_add_global_exceptions): Remove declaration.
9492         * linespec.c (iterate_over_all_matching_symtabs): Use
9493         objfile_compunits.
9494         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9495         (class objfile_compunits): New.
9496         (ALL_COMPUNITS): Use objfile_compunits.
9497         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9498         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9499         objfile_compunits.
9500         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9501
9502 2019-01-09  Tom Tromey  <tom@tromey.com>
9503
9504         * symtab.c (search_symbols)
9505         (default_collect_symbol_completion_matches_break_on): Use
9506         objfile_msymbols.
9507         * ada-lang.c (ada_lookup_simple_minsym)
9508         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9509         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9510         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9511         objfile_msymbols.
9512         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9513         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9514         * objc-lang.c (find_methods): Use objfile_msymbols.
9515         (info_selectors_command, info_classes_command): Likewise.
9516         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9517         * objfiles.h (class objfile_msymbols): New.
9518         (ALL_OBJFILE_MSYMBOLS): Remove.
9519         (ALL_MSYMBOLS): Remove.
9520
9521 2019-01-09  Tom Tromey  <tom@tromey.com>
9522
9523         * common/next-iterator.h (next_adapter): Add Iterator template
9524         parameter.
9525         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9526         (class all_objfiles_safe): New.
9527         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9528         * objfiles.c (put_objfile_before): Update comment.
9529         (add_separate_debug_objfile): Likewise.
9530         (free_all_objfiles): Use all_objfiles_safe.
9531         (objfile_purge_solibs): Likewise.
9532
9533 2019-01-09  Tom Tromey  <tom@tromey.com>
9534
9535         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9536         (expand_symtab_containing_pc, lookup_static_symbol)
9537         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9538         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9539         all_objfiles.
9540         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9541         * breakpoint.c (create_overlay_event_breakpoint)
9542         (create_longjmp_master_breakpoint)
9543         (create_std_terminate_master_breakpoint)
9544         (create_exception_master_breakpoint): Use all_objfiles.
9545         * linux-thread-db.c (try_thread_db_load_from_pdir)
9546         (has_libpthread): Use all_objfiles.
9547         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9548         * linespec.c (iterate_over_all_matching_symtabs)
9549         (search_minsyms_for_name): Use all_objfiles.
9550         * maint.c (maintenance_info_sections): Use all_objfiles.
9551         * main.c (captured_main_1): Use all_objfiles.
9552         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9553         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9554         * guile/scm-pretty-print.c
9555         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9556         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9557         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9558         (maintenance_print_msymbols): Use all_objfiles.
9559         * source.c (select_source_symtab): Use all_objfiles.
9560         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9561         * symfile.c (remove_symbol_file_command)
9562         (expand_symtabs_matching, map_symbol_filenames): Use
9563         all_objfiles.
9564         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9565         all_objfiles.
9566         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9567         * objc-lang.c (find_methods): Use all_objfiles.
9568         * objfiles.c (have_partial_symbols, have_full_symbols)
9569         (have_minimal_symbols, qsort_cmp)
9570         (default_iterate_over_objfiles_in_search_order): Use
9571         all_objfiles.
9572         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9573         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9574         (maintenance_check_psymtabs): Use all_objfiles.
9575         (ALL_PSYMTABS): Remove.
9576         * compile/compile-object-run.c (do_module_cleanup): Use
9577         all_objfiles.
9578         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9579         * cp-support.c (add_symbol_overload_list_qualified): Use
9580         all_objfiles.
9581         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9582         Use all_objfiles.
9583         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9584         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9585         all_objfiles.
9586         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9587         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9588         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9589         Uses all_objfiles.
9590         * solib.c (solib_read_symbols): Use all_objfiles
9591
9592 2019-01-09  Tom Tromey  <tom@tromey.com>
9593
9594         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9595         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9596         all_objfiles.
9597         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9598         * symmisc.c (print_symbol_bcache_statistics)
9599         (print_objfile_statistics, maintenance_print_objfiles)
9600         (maintenance_info_symtabs, maintenance_check_symtabs)
9601         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9602         all_objfiles.
9603         * source.c (forget_cached_source_info): Use all_objfiles.
9604         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9605         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9606         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9607         * objfiles.c (update_section_map): Use all_objfiles.
9608         (shared_objfile_contains_address_p): Likewise.
9609         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9610         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9611
9612 2019-01-09  Tom Tromey  <tom@tromey.com>
9613
9614         * common/next-iterator.h: New file.
9615         * objfiles.h (class all_objfiles): New.
9616         (struct objfile_iterator): New.
9617
9618 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9619
9620         * NEWS: Move the description of the changed "frame", "select-frame",
9621          and "info frame" commands to the Changed commands section.
9622
9623 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9624
9625         * gdbtypes.c (check_stub_method_group): Remove handling of old
9626         mangling schemes.
9627         * linespec.c (find_methods): Likewise.
9628         * stabsread.c (read_member_functions): Likewise.
9629         * valops.c (search_struct_method): Likewise.
9630         (value_struct_elt_for_reference): Likewise.
9631         * NEWS: Mention this change.
9632
9633 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9634
9635         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9636         print_source_lines.
9637         * source.c (print_source_lines_base): Update line number check.
9638         (print_source_lines): New function.
9639         (source_lines_range::source_lines_range): New function.
9640         * source.h (class source_lines_range): New class.
9641         (print_source_lines): New declaration.
9642
9643 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9644
9645         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9646
9647 2019-01-08  Tom Tromey  <tom@tromey.com>
9648             Simon Marchi  <simon.marchi@ericsson.com>
9649
9650         PR gdb/24060
9651         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9652         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9653         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9654         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9655         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9656         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9657
9658 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9659
9660         * source.c (select_source_symtab): Move header comment to
9661         declaration in source.h.
9662         (forget_cached_source_info_for_objfile): Likewise.
9663         (forget_cached_source_info): Likewise.
9664         (identify_source_line): Likewise.
9665         * source.h (identify_source_line): Move declaration from symtab.h
9666         and add comment from source.c
9667         (print_source_lines): Likewise.
9668         (forget_cached_source_info_for_objfile): Likewise.
9669         (forget_cached_source_info): Likewise.
9670         (select_source_symtab): Likewise.
9671         (enum print_source_lines_flag): Move definition from symtab.h.
9672         * symtab.h (identify_source_line): Move declaration to source.h.
9673         (print_source_lines): Likewise.
9674         (forget_cached_source_info_for_objfile): Likewise.
9675         (forget_cached_source_info): Likewise.
9676         (select_source_symtab): Likewise.
9677         (enum print_source_lines_flag): Move definition to source.h.
9678         * tui/tui-hooks.c: Add 'source.h' include.
9679
9680 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9681
9682         * source.c (print_source_lines_base): Handle requests to print
9683         reverse line number sequences, and guard against empty lines
9684         string.
9685
9686 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9687
9688         * source.c (print_source_lines_base): Fix skip of '\r' if next
9689         character is '\n'.
9690
9691 2019-01-06  Tom Tromey  <tom@tromey.com>
9692
9693         * c-exp.y (struct c_parse_state) <macro_original_text,
9694         expansion_obstack>: New member.
9695         (macro_original_text, expansion_obstack): Remove globals.
9696         (scan_macro_expansion, scanning_macro_expansion)
9697         (finished_macro_expansion): Update.
9698         (scan_macro_cleanup): Remove.
9699         (yylex, c_parse): Update.
9700
9701 2019-01-06  Tom Tromey  <tom@tromey.com>
9702
9703         * c-exp.y (struct c_parse_state) <strings>: New member.
9704         (operator_stoken): Update.
9705
9706 2019-01-06  Tom Tromey  <tom@tromey.com>
9707
9708         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9709         (union type_stack_elt) <typelist_val>: Now a pointer to
9710         std::vector.
9711         (type_stack_cleanup): Don't declare.
9712         (push_typelist): Update.
9713         * parse.c (pop_typelist): Return a std::vector.
9714         (push_typelist): Take a std::vector.
9715         (follow_types): Update.  Do not free args.
9716         (type_stack_cleanup): Remove.
9717         * c-exp.y (struct c_parse_state): New.
9718         (cpstate): New global.
9719         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9720         (nonempty_typelist): Update.
9721         (func_mod): Create a new vector.
9722         (c_parse): Create a c_parse_state.
9723         (check_parameter_typelist): Do not delete params.
9724         (function_method): Update.  Do not delete type_list.
9725
9726 2019-01-06  Tom Tromey  <tom@tromey.com>
9727
9728         PR gdb/28155:
9729         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9730         check_typedef.
9731         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9732         (print_return_value): Likewise.
9733
9734 2019-01-05  Tom Tromey  <tom@tromey.com>
9735
9736         * contrib/cleanup_check.py: Remove.
9737         * contrib/gcc-with-excheck: Remove.
9738         * contrib/exsummary.py: Remove.
9739         * contrib/excheck.py: Remove.
9740
9741 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9742
9743         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9744         NULL. Initialize tpprev to NULL instead of assigning it
9745         to NULL on the next statement.
9746         * windows-nat.c (windows_delete_thread): Remove check for
9747         main_thread_id before printing thread exit notifications.
9748         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9749         Remove thread ID check against main_thread_id.
9750         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9751         windows_delete_thread.
9752         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9753
9754 2019-01-04  Tom Tromey  <tom@tromey.com>
9755
9756         * compile/compile.c (_initialize_compile): Use upper case for
9757         metasyntactic variables.
9758         * symmisc.c (_initialize_symmisc): Use upper case for
9759         metasyntactic variables.
9760         * psymtab.c (_initialize_psymtab): Use upper case for
9761         metasyntactic variables.
9762         * demangle.c (demangle_command): Use upper case for metasyntactic
9763         variables.
9764         (_initialize_demangler): Likewise.
9765         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9766         variables.
9767
9768 2019-01-03  Tom Tromey  <tom@tromey.com>
9769
9770         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9771
9772 2019-01-03  Tom Tromey  <tom@tromey.com>
9773
9774         * python/py-symtab.c (salpy_str): Update.
9775         (struct salpy_sal_object) <symtab>: Now a PyObject.
9776         (salpy_dealloc): Update.
9777         (del_objfile_sal): Use gdbpy_ref.
9778
9779 2019-01-03  Tom Tromey  <tom@tromey.com>
9780
9781         * python/py-type.c (convert_field): Use new_reference.  Return
9782         gdbpy_ref.
9783         (make_fielditem): Return gdbpy_ref.
9784         (typy_fields): Update.
9785         (typy_getitem): Update.
9786         (field_name): Return gdbpy_ref.  Use new_reference.
9787         (typy_iterator_iternext): Update.
9788
9789 2019-01-03  Tom Tromey  <tom@tromey.com>
9790
9791         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9792
9793 2019-01-03  Tom Tromey  <tom@tromey.com>
9794
9795         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9796         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9797         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9798         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9799         (pspy_set_type_printers): Likewise.
9800         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9801         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9802         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9803         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9804         (objfpy_set_type_printers): Likewise.
9805
9806 2019-01-03  Tom Tromey  <tom@tromey.com>
9807
9808         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9809         (gdbpy_print_stack): Use gdbpy_err_fetch.
9810         * python/python-internal.h (class gdbpy_err_fetch): New class.
9811         (class gdbpy_enter) <m_error_type, m_error_value,
9812         m_error_traceback>: Remove.
9813         <m_error>: New member.
9814         (gdbpy_exception_to_string): Don't declare.
9815         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9816         * python/py-value.c (convert_value_from_python): Use
9817         gdbpy_err_fetch.
9818         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9819         gdbpy_exception_to_string.
9820         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9821         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9822         gdbpy_err_fetch.
9823
9824 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9825
9826         * linux-nat.c (delete_lwp_cleanup): Delete.
9827         (struct lwp_deleter): New struct.
9828         (lwp_info_up): New typedef.
9829         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9830         lwp_info_up.
9831
9832 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9833
9834         * linux-fork.c (class scoped_switch_fork_info): New class.
9835         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9836
9837 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9838
9839         * valops.c (find_overload_match): Remove use of null_cleanup, and
9840         calls to do_cleanups.
9841
9842 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9843
9844         * compile/compile-cplus-types.c
9845         (compile_cplus_instance::decl_name): Handle changes to
9846         cp_func_name.
9847         * cp-support.c (cp_func_name): Update header comment, update
9848         return type.
9849         * cp-support.h (cp_func_name): Update return type in declaration.
9850         * valops.c (find_overload_match): Move temp_func local to top
9851         level of function and change its type.  Use temp_func to hold and
9852         delete temporary string obtained from cp_func_name.
9853
9854 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9855
9856         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9857         gdb::char_vector, remove cleanup, and update uses of `msg`.
9858
9859 2019-01-03  Jim Wilson  <jimw@sifive.com>
9860
9861         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9862
9863 2019-01-02  Tom Tromey  <tom@tromey.com>
9864
9865         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9866         (tdesc_parse_xml): Remove cleanups.
9867         * target-descriptions.h (make_cleanup_free_target_description):
9868         Don't declare.
9869         (target_desc_deleter): New struct.
9870         (target_desc_up): New typedef.
9871         * target-descriptions.c (target_desc_deleter::operator()): Rename
9872         from free_target_description.
9873         (make_cleanup_free_target_description): Remove.
9874
9875 2019-01-02  Tom Tromey  <tom@tromey.com>
9876
9877         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9878         constructor, destructor.
9879         (linespec_parser): Remove typedef.
9880         (~linespec_parser): Rename from linespec_parser_delete.
9881         (linespec_lex_to_end, linespec_complete_label)
9882         (linespec_complete): Update.
9883         (decode_line_full): Remove cleanups.
9884         (decode_line_1): Update.
9885
9886 2019-01-02  Tom Tromey  <tom@tromey.com>
9887
9888         * python/python-internal.h (inferior_to_inferior_object): Change
9889         return type.
9890         * python/py-exitedevent.c (create_exited_event_object): Update.
9891         * python/py-inferior.c (inferior_to_inferior_object): Return
9892         gdbpy_ref.
9893         (python_new_inferior, python_inferior_deleted)
9894         (thread_to_thread_object, delete_thread_object)
9895         (build_inferior_list, gdbpy_selected_inferior): Update.
9896         * python/py-infthread.c (create_thread_object): Update.  Also fail
9897         if inferior_to_inferior_object fails.
9898
9899 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9900
9901         * inferior.h (class inferior) <displaced_step_state>: New field.
9902         * infrun.h (struct displaced_step_state): Move here from
9903         infrun.c.  Initialize fields, add constructor.
9904         <inf>: Remove field.
9905         <reset>: New method.
9906         * infrun.c (struct displaced_step_inferior_state): Move to
9907         infrun.h.
9908         (displaced_step_inferior_states): Remove.
9909         (get_displaced_stepping_state): Adust.
9910         (displaced_step_in_progress_any_inferior): Adjust.
9911         (displaced_step_in_progress_thread): Adjust.
9912         (displaced_step_in_progress): Adjust.
9913         (add_displaced_stepping_state): Remove.
9914         (get_displaced_step_closure_by_addr): Adjust.
9915         (remove_displaced_stepping_state): Remove.
9916         (infrun_inferior_exit): Call displaced_step_state.reset.
9917         (use_displaced_stepping): Don't check for NULL.
9918         (displaced_step_prepare_throw): Call
9919         get_displaced_stepping_state.
9920         (displaced_step_fixup): Don't check for NULL.
9921         (prepare_for_detach): Don't check for NULL.
9922
9923 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9924
9925         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9926          in case of call that did not complete.
9927
9928 2019-01-02  Andrey Utkin  <autkin@undo.io>
9929
9930         * symfile.c (find_separate_debug_file): Fix search of debug files for
9931         remote debuggee.
9932
9933 2019-01-02  Tom Tromey  <tom@tromey.com>
9934
9935         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9936         indentation.
9937         * python/py-frame.c (frapy_older): Remove cast.
9938         (frapy_newer): Likewise.
9939         * python/py-breakpoint.c (local_setattro): Remove cast.
9940         * python/py-arch.c (archpy_name): Remove local variable.
9941         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9942
9943 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9944
9945         * unittests/basic_string_view/element_access/char/empty.cc:
9946         Fix year range in copyright header.
9947
9948 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9949
9950         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9951         Delete.
9952         <operator==>: Update with for removed field.
9953         <hash>: Likewise.
9954         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9955         <isa_features>: ...this.
9956         <abi_features>: New field.
9957         (riscv_isa_flen): Update comment.
9958         (riscv_abi_xlen): New declaration.
9959         (riscv_abi_flen): New declaration.
9960         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9961         isa_features.
9962         (riscv_abi_xlen): New function.
9963         (riscv_isa_flen): Update to get answer from isa_features.
9964         (riscv_abi_flen): New function.
9965         (riscv_has_fp_abi): Update to get answer from abi_features.
9966         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9967         xlen and flen.
9968         (riscv_call_info) <xlen, flen>: Update comment.
9969         (riscv_call_arg_struct): Remove invalid assertions
9970         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9971         is removed.
9972         (riscv_gdbarch_init): Gather isa features and abi features
9973         separately, ensure both match on the gdbarch when reusing an old
9974         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9975         a target with 64-bit float hardware.
9976
9977 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9978
9979         * source.c (search_command_helper): Stop reverse search
9980         when line 1 has been searched.
9981
9982 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9983
9984         * record-full.c (record_full_base_target::close): Rewrite
9985         record_full_core_buf_list free logic.
9986
9987 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9988
9989         * break-catch-syscall.c (print_one_catch_syscall): xfree
9990         the last text.
9991
9992 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9993
9994         * top.c (print_gdb_version): Update Copyright year in version
9995         message.
9996
9997 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9998
9999         Update copyright year range in all GDB files.
10000
10001 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10002
10003         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10004
10005 For older changes see ChangeLog-2018.
10006 \f
10007 Local Variables:
10008 mode: change-log
10009 left-margin: 8
10010 fill-column: 74
10011 version-control: never
10012 coding: utf-8
10013 End:
10014