gdb/ChangeLog

   1 2019-08-06  Tom Tromey  <tromey@adacore.com>
   2
   3         * breakpoint.c (init_breakpoint_sal): Update.
   4         (breakpoint): Update.
   5         * breakpoint.h (struct breakpoint) <filter>: Now a
   6         unique_xmalloc_ptr.
   7
   8 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
   9
  10         * NEWS: Mention dictionary access on blocks.
  11         * python/py-block.c (blpy_getitem): New function.
  12         (block_object_as_mapping): New struct.
  13         (block_object_type): Use new struct for tp_as_mapping field.
  14
  15 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
  16
  17         * objfiles.h (objfile): Add a comment describing partial symbols.
  18
  19 2019-08-05  Tom Tromey  <tromey@adacore.com>
  20
  21         * compile/compile.c (_initialize_compile): Use _(), not N_().
  22         * thread.c (_initialize_thread): Use _(), not N_().
  23         * stack.c (_initialize_stack): Use _(), not N_().
  24         * printcmd.c (_initialize_printcmd): Use _(), not N_().
  25
  26 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
  27
  28         * dwarf2read.c (struct dw2_symtab_iterator):
  29         <want_specific_block>: Remove.
  30         <block_index>: Change type to gdb::optional.
  31         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
  32         change type of BLOCK_INDEX parameter to gdb::optional.
  33         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
  34         (dw2_lookup_symbol): Don't pass argument for
  35         WANT_SPECIFIC_BLOCK.
  36         (dw2_expand_symtabs_for_function): Don't pass argument for
  37         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
  38         (class dw2_debug_names_iterator)
  39         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
  40         parameter, change BLOCK_INDEX type to gdb::optional.
  41         <m_want_specific_block>: Remove.
  42         <m_block_index>: Change type to gdb::optional.
  43         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
  44         gdb::optional.  Re-write in function of gdb::optional.
  45         (dw2_debug_names_lookup_symbol): Don't pass argument for
  46         WANT_SPECIFIC_BLOCK.
  47         (dw2_debug_names_expand_symtabs_for_function): Don't pass
  48         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
  49         BLOCK_INDEX.
  50
  51 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  52
  53         * NEWS: Mention changes to "info sources" command.
  54
  55 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  56
  57         * symtab.c (filename_partial_match_opts): New struct type.
  58         (struct output_source_filename_data): New members
  59         regexp, c_regexp, partial_match.
  60         (output_source_filename): Use new members to decide to print file.
  61         (info_sources_option_defs): New variable.
  62         (make_info_sources_options_def_group, print_info_sources_header,
  63         info_sources_command_completer):
  64         New functions.
  65         (info_sources_command): Read new optional arguments.
  66         (_initialize_symtab): Update info sources help.
  67
  68 2019-08-02  Alexandre Oliva <oliva@adacore.com>
  69
  70         * ada-lang.c (exception_support_info_v0): Renamed from...
  71         (default_exception_support_info): ... this.  Create new
  72         definition for v1.
  73         (ada_has_this_exception_support): Look up catch_handlers_sym.
  74         (ada_exception_support_info_sniffer): Try v0 after default.
  75
  76 2019-08-01  Tom Tromey  <tromey@adacore.com>
  77
  78         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
  79         gdbarch.h.
  80
  81 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
  82
  83         * s12z-tdep.c: Fix include path for s12z-opc.h.
  84
  85 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
  86
  87         * NEWS: Require GNU make 3.82.
  88
  89 2019-07-16  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
  92         declare.
  93
  94 2019-07-30  Tom Tromey  <tromey@adacore.com>
  95
  96         * block.c (contained_in): Remove BLOCK_FUNCTION check.
  97
  98 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
  99
 100         * printcmd.c (print_address_symbolic): Print negative offsets.
 101         (build_address_symbolic): Force signed arithmetic when computing
 102         offset.
 103
 104 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 105
 106         PR/24474: Add a function to lookup static variables.
 107         * NEWS: Mention this new function.
 108         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 109         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 110         * python/python.c (python_GdbMethods): Add new function.
 111
 112 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 113
 114         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 115         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 116         (objfpy_lookup_static_symbol): New function.
 117         (objfile_object_methods): Add new functions.
 118
 119 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 120
 121         * NEWS: Mention 'set|show print frame-info'.  Mention new
 122         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 123         backtrace argument.  Mention that python frame filtering code
 124         is now consistent with what 'backtrace' command prints.
 125
 126 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 127
 128         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 129         comments.
 130         (print_frame_info_auto, print_frame_info_source_line,
 131         print_frame_info_location, print_frame_info_source_and_location,
 132         print_frame_info_location_and_address, print_frame_info_short_location):
 133         New declarations.
 134         (struct frame_print_options): New member print_frame_info.
 135         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 136         * stack.h (get_user_print_what_frame_info): New declaration.
 137         (frame_show_address): New declaration.
 138         * stack.c (print_frame_arguments_choices): New value 'presence'.
 139         (print_frame_info_auto, print_frame_info_source_line,
 140         print_frame_info_location, print_frame_info_source_and_location,
 141         print_frame_info_location_and_address, print_frame_info_short_location,
 142         print_frame_info_choices, print_frame_info_print_what): New definitions.
 143         (print_frame_args): Only print dots for args if print frame-arguments
 144         is 'presence'.
 145         (frame_print_option_defs): New element for "frame-info".
 146         (get_user_print_what_frame_info): New function.
 147         (frame_show_address): Make non static.  Move comment to stack.h.
 148         (print_frame_info_to_print_what): New function.
 149         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 150         to decide what to print.
 151         (backtrace_command_1): Handle the new print_frame_arguments_presence
 152         value.
 153         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 154         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 155         (py_print_frame): In non-mi mode, use LOCATION as default for
 156         print_what, similarly to frame information printed directly by
 157         backtrace command. Handle frame-info user option in non MI mode.
 158
 159 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 160
 161         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 162         Add case for debugging 32-bit target on 64-bit host.  Revise
 163         comment.
 164
 165 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 166
 167         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 168         instead of find_function_entry_range_from_pc.
 169
 170 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 171
 172         * stack.c (find_frame_funname): Remove code which preferred
 173         minsym over symtab sym in "certain pathological cases".
 174
 175         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 176         parameter.  Change type of "do_demangle" to bool.
 177         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 178         Pass suitable "prefer_sym_over_minsym" flag to
 179         build_address_symbolic().  Don't output "+" for negative offsets.
 180         * printcmd.c (print_address_symbolic): Update invocation of
 181         build_address_symbolic to include a "prefer_sym_over_minsym"
 182         flag.
 183         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 184         Restrict cases in which use of minimal symbol is preferred to that
 185         of a found symbol.  Update comments.
 186
 187         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 188         for entry pc when entry pc is out of range for that FDE.
 189
 190 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 191
 192         PR gdb/24839:
 193         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 194         type.
 195
 196 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 197
 198         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 199         this function's Python signature.
 200
 201
 202 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 203
 204         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 205         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 206         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 207         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 208         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 209
 210
 211 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 212
 213         * h8300-tdep.c (h8300_register_name_common): New.
 214         h8300_register_name): Use h8300_register_name_common.
 215         (h8300s_register_name): Likewise.
 216         (h8300sx_register_name): Likewise.
 217         (h8300h_register_nam): New.
 218         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 219
 220
 221 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 222
 223         * arm-tdep.c (arm_skip_cmse_entry): New function.
 224         (arm_is_sgstubs_section): New function.
 225         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 226
 227 2019-07-22  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 230         Don't self-assign.
 231
 232 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 233
 234         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 235         type_print.
 236
 237 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 238
 239         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 240         so that GDB doesn't match any msymbols when searching in the
 241         TYPES_DOMAIN.
 242         (print_symbol_info): Print using typedef_print or type_print based
 243         on the type of the symbol.  Add updated FIXME comment moved from...
 244         (_initialize_symtab): ... move and update FIXME comment to above.
 245
 246 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 247
 248         * NEWS: Mention adding -q option to "info types".
 249         * symtab.c (struct info_types_options): New struct.
 250         (info_types_options_defs): New variable.
 251         (make_info_types_options_def_group): New function.
 252         (info_types_command): Use gdb::option framework to parse options.
 253         (info_types_command_completer): New function.
 254         (_initialize_symtab): Extend the help text on "info types" and
 255         register command completer.
 256
 257 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 258
 259         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 260         (lookup_symbol_in_objfile): Change int to block_enum and add a
 261         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 262
 263 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 264
 265         * MAINTAINERS (Write After Approval): Add self.
 266
 267 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 268
 269         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 270         instruction to the dummy code region.
 271
 272 2019-07-19  Tom Tromey  <tromey@adacore.com>
 273
 274         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 275         (ARGSUSED, PARAMS, __func__): Remove rules.
 276
 277 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 278
 279         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 280         * features/arm/arm-with-iwmmxt.c: Remove.
 281         * features/arm/arm-with-iwmmxt.xml: Remove.
 282         * features/arm/arm-with-m-fpa-layout.c: Remove.
 283         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 284         * features/arm/arm-with-m-vfp-d16.c: Remove.
 285         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 286         * features/arm/arm-with-m.c: Remove.
 287         * features/arm/arm-with-m.xml: Remove.
 288         * features/arm/arm-with-neon.c: Remove.
 289         * features/arm/arm-with-neon.xml: Remove.
 290         * features/arm/arm-with-vfpv2.c: Remove.
 291         * features/arm/arm-with-vfpv2.xml: Remove.
 292         * features/arm/arm-with-vfpv3.c: Remove.
 293         * features/arm/arm-with-vfpv3.xml: Remove.
 294
 295 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 296
 297         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 298
 299 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 300
 301         * arch/aarch32.c (aarch32_create_target_description): Create
 302         target descriptions using features.
 303         * arch/arm.c (arm_create_target_description)
 304         (arm_create_mprofile_target_description): Likewise.
 305         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 306
 307 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 308
 309         * Makefile.in: Add new files.
 310         * aarch32-tdep.c: New file.
 311         * aarch32-tdep.h: New file.
 312         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 313         Call aarch32_read_description.
 314         * arch/aarch32.c: New file.
 315         * arch/aarch32.h: New file.
 316         * arch/arm.c (arm_create_target_description)
 317         (arm_create_mprofile_target_description): New function.
 318         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 319         (arm_create_target_description)
 320         (arm_create_mprofile_target_description): New declaration.
 321         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 322         read_description functions.
 323         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 324         Likewise.
 325         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 326         * arm-tdep.c (tdesc_arm_list): New variable.
 327         (arm_register_g_packet_guesses): Call create description functions.
 328         (arm_read_description) (arm_read_mprofile_description): New
 329         function.
 330         * arm-tdep.h (arm_read_description)
 331         (arm_read_mprofile_description): Add declaration.
 332         * configure.tgt: Add new files.
 333
 334 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 335
 336         * top.c (new_ui_command): Open specified terminal just once.
 337
 338 2019-07-18  Tom Tromey  <tromey@adacore.com>
 339
 340         * symtab.c (main_name): Constify return type.
 341         * symfile.c (set_initial_language): Update.
 342         * symtab.h (main_name): Constify return type.
 343
 344 2019-07-17  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-winsource.c (tui_update_source_window)
 347         (tui_update_source_window_as_is)
 348         (tui_update_source_windows_with_line): Remove return.
 349         * tui/tui-disasm.c (tui_show_disassem)
 350         (tui_show_disassem_and_update_source): Remove return.
 351         * tui/tui.c (tui_reset): Remove return.
 352         * tui/tui-wingeneral.c
 353         (tui_check_and_display_highlight_if_needed): Remove return.
 354
 355 2019-07-17  Tom Tromey  <tom@tromey.com>
 356
 357         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 358
 359 2019-07-17  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-winsource.h (struct tui_exec_info_window)
 362         (struct tui_source_window_base): Move from tui-data.h.
 363         * tui/tui-winsource.c: Move many method definitions from
 364         elsewhere.  Remove "structuring" comments.
 365         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 366         (tui_source_window_base::refresh_window): Move to
 367         tui-winsource.c.
 368         * tui/tui-win.c (tui_source_window_base::refresh_all)
 369         (tui_source_window_base::update_tab_width)
 370         (tui_source_window_base::set_new_height)
 371         (tui_source_window_base::do_make_visible_with_new_height): Move to
 372         tui-winsource.c.
 373         * tui/tui-source.h: Update.
 374         * tui/tui-source.c (tui_source_window_base::reset): Move to
 375         tui-winsource.c.
 376         * tui/tui-disasm.h: Update.
 377         * tui/tui-data.h (struct tui_exec_info_window): Move to
 378         tui-winsource.h.
 379         (struct tui_source_window_base): Likewise.
 380         * tui/tui-data.c (tui_source_window_base::clear_detail)
 381         (tui_source_window_base, ~tui_source_window_base): Move to
 382         tui-winsource.c.
 383
 384 2019-07-17  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-win.c (tui_resize_all)
 387         (tui_source_window_base::update_tab_width)
 388         (tui_adjust_win_heights): Update.
 389         (tui_win_info::make_invisible_and_set_new_height): Rename from
 390         make_invisible_and_set_new_height.
 391         * tui/tui-data.h (struct tui_win_info)
 392         <make_invisible_and_set_new_height>: New method.
 393
 394 2019-07-17  Tom Tromey  <tom@tromey.com>
 395
 396         * tui/tui.c: Update.
 397         * tui/tui-source.h (struct tui_source_window): Move from
 398         tui-data.h.
 399         * tui/tui-layout.c: Update.
 400         * tui/tui-disasm.c: Update.
 401         * tui/tui-data.h (struct tui_source_window): Move to
 402         tui-source.h.
 403
 404 2019-07-17  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 407         tui-data.h.
 408         * tui/tui-data.h (struct tui_disasm_window): Move to
 409         tui-disasm.h.
 410
 411 2019-07-17  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-regs.h (struct tui_data_item_window): Move from
 414         tui-data.h.
 415         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 416         * tui/tui-data.h (struct tui_data_item_window): Move to
 417         tui-regs.h.
 418         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 419
 420 2019-07-17  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui.c: Update.
 423         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 424         (tui_cmd_window::max_height): Move to tui-command.c.
 425         * tui/tui-layout.c: Update.
 426         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 427         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 428         tui-command.c.
 429         * tui/tui-command.h (struct tui_cmd_window): Move from
 430         tui-data.h.
 431         * tui/tui-command.c: Remove "structuring" comments.
 432         (tui_cmd_window::clear_detail)
 433         (tui_cmd_window::do_make_visible_with_new_height)
 434         (tui_cmd_window::max_height): Move from elsewhere.
 435
 436 2019-07-17  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 439         Now static.
 440         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 441         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 442
 443 2019-07-17  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui.c: Update.
 446         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 447         tui-regs.c.
 448         * tui/tui-windata.h: Remove file.
 449         * tui/tui-windata.c: Remove file.
 450         * tui/tui-win.c (tui_data_window::set_new_height)
 451         (tui_data_window::do_make_visible_with_new_height): Move to
 452         tui-regs.c.
 453         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 454         * tui/tui-regs.c: Remove "structuring" comments.
 455         (tui_data_window::first_data_item_displayed)
 456         (tui_data_window::delete_data_content_windows)
 457         (tui_data_window::erase_data_content)
 458         (tui_data_window::display_all_data)
 459         (tui_data_window::refresh_all)
 460         (tui_data_window::do_scroll_vertical)
 461         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 462         (tui_data_window::do_make_visible_with_new_height)
 463         (tui_data_window::refresh_window): Move from elsewhere.
 464         (_initialize_tui_regs): Move to end of file.
 465         * tui/tui-layout.c: Update.
 466         * tui/tui-hooks.c: Update.
 467         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 468         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 469         tui-regs.c.
 470         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 471
 472 2019-07-17  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 475         seen.
 476
 477 2019-07-17  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-win.c (tui_source_window_base::set_new_height)
 480         (tui_source_window_base::do_make_visible_with_new_height): Use
 481         m_has_locator field directly.
 482         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 483         method.
 484         (struct tui_source_window_base) <has_locator>: Likewise.
 485
 486 2019-07-17  Tom Tromey  <tom@tromey.com>
 487
 488         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 489         Don't declare.
 490         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 491         Remove.
 492         * tui/tui-win.c (tui_source_window_base::set_new_height)
 493         (tui_source_window_base::set_new_height)
 494         (make_invisible_and_set_new_height)
 495         (tui_source_window_base::do_make_visible_with_new_height)
 496         (tui_source_window_base::do_make_visible_with_new_height):
 497         Update.
 498         * tui/tui-layout.c (show_source_disasm_command, show_data)
 499         (show_source_or_disasm_and_command): Update.
 500         * tui/tui-layout.c (show_layout): Update.
 501
 502 2019-07-17  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-layout.c (make_data_window): Remove.
 505         (show_data): Unify creation and re-initialization cases.
 506
 507 2019-07-17  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-layout.c (make_source_window, make_disasm_window):
 510         Remove.
 511         (show_data): Unify creation and re-initialization cases.
 512
 513 2019-07-17  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-layout.c (make_command_window): Remove.
 516         (show_source_disasm_command, show_source_or_disasm_and_command):
 517         Unify creation and re-initialization cases.
 518
 519 2019-07-17  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 522         creation and re-initialization cases.
 523
 524 2019-07-17  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui-regs.c (tui_get_register): Return void.
 527
 528 2019-07-17  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 531         Simplify.
 532
 533 2019-07-17  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 536         resetting.
 537
 538 2019-07-17  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 541         * tui/tui-regs.c (tui_reg_layout): New function.
 542         (tui_show_registers, tui_reg_command): Use it.
 543         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 544         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 545         parameters.
 546         (tui_layout_command): Remove.
 547
 548 2019-07-17  Tom Tromey  <tom@tromey.com>
 549
 550         * tui/tui-layout.h (tui/tui-layout): Return void.
 551         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 552
 553 2019-07-17  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-layout.c (show_source_disasm_command, show_data):
 556         Update.
 557         (reset_locator): Remove.
 558         (show_source_or_disasm_and_command): Update.
 559
 560 2019-07-17  Tom Tromey  <tom@tromey.com>
 561
 562         * tui/tui-source.c (tui_source_window_base::reset): Remove
 563         win_type parameter.
 564         * tui/tui-layout.c (make_command_window, make_source_window)
 565         (make_disasm_window, make_data_window)
 566         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 567         (reset_locator, show_source_or_disasm_and_command): Update.
 568         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 569         win_type parameter.
 570         (struct tui_source_window_base) <reset>: Likewise.
 571
 572 2019-07-17  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-layout.c (show_source_disasm_command): Use
 575         reset_locator.
 576         (reset_locator): New function.
 577         (init_and_make_win): Remove.
 578         (show_source_or_disasm_and_command): Use reset_locator.
 579
 580 2019-07-17  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 583         condition.
 584         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 585         Remove condition.
 586         * tui/tui-source.c (tui_source_window_base::reset): New method.
 587         * tui/tui-layout.c (make_command_window): Don't call
 588         init_and_make_win.
 589         (make_source_window, make_disasm_window): Don't call
 590         make_source_or_disasm_window.
 591         (make_data_window): Don't call init_and_make_win.  Change calling
 592         convention.
 593         (show_source_disasm_command, show_data): Simplify.
 594         (make_source_or_disasm_window): Remove.
 595         (show_source_or_disasm_and_command): Simplify.
 596         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 597         (struct tui_source_window_base) <reset>: Likewise.
 598         <execution_info>: Remove initializer.
 599         * tui/tui-data.c (tui_source_window_base): Initialize
 600         execution_info.
 601
 602 2019-07-17  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 605         variable.
 606
 607 2019-07-17  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui.c (tui_rl_other_window): Update.
 610         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 611         superclass method first.  Always iterate over regs_content.
 612         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 613         method.
 614         * tui/tui-win.c (tui_set_focus_command): Update.
 615
 616 2019-07-17  Tom Tromey  <tom@tromey.com>
 617
 618         * tui/tui-win.c (tui_set_focus_command): Rename from
 619         tui_set_focus.  Call tui_enable.
 620         (tui_set_focus_command): Remove.
 621
 622 2019-07-17  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 625         refresh_window.
 626         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 627         touchwin.
 628         (tui_data_window::refresh_window): Call refresh_window on data
 629         items.  Always call superclass refresh_window.
 630         (tui_win_info::refresh): Remove.
 631         (tui_source_window_base::refresh_window): Update.
 632         (tui_refresh_all): Update.
 633         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 634         refresh_window.
 635         (show_source_or_disasm_and_command): Likewise.
 636         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 637         (struct tui_source_window_base) <refresh>: Likewise.
 638
 639 2019-07-17  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-winsource.c (tui_clear_source_content)
 642         (tui_show_source_content): Update.
 643         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 644         whether content is empty.
 645         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 646         Remove.
 647
 648 2019-07-17  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 651         window's contents.
 652         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 653         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 654
 655 2019-07-17  Tom Tromey  <tom@tromey.com>
 656
 657         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 658         (struct tui_data_item_window): Update.
 659
 660 2019-07-17  Tom Tromey  <tom@tromey.com>
 661
 662         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 663         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 664         defines.
 665
 666 2019-07-17  Tom Tromey  <tom@tromey.com>
 667
 668         * tui/tui-winsource.h (tui_erase_source_content)
 669         (tui_clear_source_content): Remove "display_prompt" parameter.
 670         * tui/tui-winsource.c (tui_update_source_window_as_is)
 671         (tui_update_source_windows_with_addr): Update.
 672         (tui_clear_source_content): Remove "display_prompt" parameter.
 673         (tui_erase_source_content): Likewise.  Simplify.
 674         (tui_show_source_content): Update.
 675         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 676         * tui/tui-stack.c (tui_show_frame_info): Update.
 677         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 678         Remove defines.
 679
 680 2019-07-17  Tom Tromey  <tom@tromey.com>
 681
 682         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 683         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 684         parameter.
 685         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 686         parameter.
 687
 688 2019-07-17  Tom Tromey  <tom@tromey.com>
 689
 690         * tui/tui-winsource.c (tui_clear_source_content)
 691         (tui_show_source_content, tui_show_exec_info_content)
 692         (tui_clear_exec_info_content): Update.
 693         * tui/tui-stack.c (tui_show_locator_content): Update.
 694         (tui_show_frame_info): Update.
 695         * tui/tui-source.h (tui_source_window): Don't declare.
 696         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 697         from tui_source_is_displayed.
 698         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 699         Remove field.
 700         (struct tui_source_window_base) <content_in_use>: New field.  Now
 701         bool.
 702         (struct tui_source_window) <showing_source_p>: New method.
 703         (TUI_SRC_WIN): Change cast.
 704         * tui/tui-data.c (tui_initialize_static_data): Update.
 705
 706 2019-07-17  Tom Tromey  <tom@tromey.com>
 707
 708         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 709         location_matches_p.
 710         * tui/tui-source.c (tui_source_window::location_matches_p): New
 711         method.
 712         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 713         method.
 714         * tui/tui-data.h (struct tui_source_window_base)
 715         <location_matches_p>: New method.
 716         (struct tui_source_window, struct tui_disasm_window)
 717         <location_matches_p>: Likewise.
 718
 719 2019-07-17  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-win.c (tui_set_win_height_command): Rename from
 722         tui_set_win_height.
 723         (tui_set_win_height_command): Remove.
 724
 725 2019-07-17  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-source.c (tui_source_window): New constructor.  Add
 728         observer.
 729         (~tui_source_window): New destructor.
 730         (tui_source_window::style_changed): New method.
 731         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 732         (tui_attach_detach_observers): Update.
 733         * tui/tui-data.h (struct tui_source_window): Make constructor not
 734         inline.  Add destructor.
 735         (struct tui_source_window) <style_changed>: New method.
 736         <m_observable>: New member.
 737
 738 2019-07-17  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 741         * tui/tui-win.c (tui_resize_all): Fix typo.
 742
 743 2019-07-17  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 746         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 747         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 748         * tui/tui-win.c (window_name_completer): Use foreach.
 749         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 750         (update_tab_width): Likewise.
 751         * tui/tui-layout.c (show_layout): Update.
 752         * tui/tui-data.h (class tui_window_iterator): New.
 753         (struct all_tui_windows): New.
 754         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 755
 756 2019-07-17  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 759         parameter.  Don't reference globals.
 760         (tui_reg_command): Update.
 761
 762 2019-07-17  Tom Tromey  <tom@tromey.com>
 763
 764         * tui/tui-regs.c (tui_show_registers): Simplify.
 765
 766 2019-07-17  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-regs.c (tui_show_registers): Update.
 769         (tui_show_register_group): Add win_info parameter.
 770
 771 2019-07-17  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 774         Rename from tui_display_reg_element_at_line.
 775         (tui_data_window::display_registers_from_line): Update.
 776         * tui/tui-data.h (struct tui_data_window)
 777         <display_reg_element_at_line>: New method.
 778
 779 2019-07-17  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-regs.h (tui_display_registers_from)
 782         (tui_display_registers_from_line): Don't declare.
 783         * tui/tui-windata.c (tui_data_window::display_all_data)
 784         (tui_data_window::refresh_all)
 785         (tui_data_window::do_scroll_vertical): Update.
 786         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 787         from tui_display_registers_from.
 788         (tui_display_reg_element_at_line): Update.
 789         (tui_data_window::display_registers_from_line): Rename from
 790         tui_display_registers_from_line.
 791         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 792         display_registers_from_line>: New methods.
 793
 794 2019-07-17  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 797         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 798         from tui_erase_data_content.
 799         (tui_data_window::display_all_data)
 800         (tui_data_window::refresh_all)
 801         (tui_data_window::do_scroll_vertical): Update.
 802         * tui/tui-regs.c (tui_show_registers): Update.
 803         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 804         New method.
 805
 806 2019-07-17  Tom Tromey  <tom@tromey.com>
 807
 808         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 809         declare.
 810         * tui/tui-windata.c
 811         (tui_data_window::delete_data_content_windows): Rename from
 812         tui_delete_data_content_windows.
 813         (tui_data_window::display_all_data)
 814         (tui_data_window::do_scroll_vertical): Update.
 815         * tui/tui-data.h (struct tui_data_window)
 816         <delete_data_content_windows>: New method.
 817
 818 2019-07-17  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 821         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 822
 823 2019-07-17  Tom Tromey  <tom@tromey.com>
 824
 825         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 826         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 827         from tui_display_all_data.
 828         * tui/tui-win.c
 829         (tui_data_window::do_make_visible_with_new_height): Update.
 830         * tui/tui-regs.c (tui_show_registers): Update.
 831         * tui/tui-layout.c (tui_set_layout): Update.
 832         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 833         method.
 834
 835 2019-07-17  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 838         * tui/tui-windata.c (tui_display_data_from): Remove.
 839         (tui_data_window::refresh_all): Update.
 840
 841 2019-07-17  Tom Tromey  <tom@tromey.com>
 842
 843         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 844         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 845         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 846         tui_display_registers_from_line.
 847         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 848         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 849         "force_display" parameter.
 850
 851 2019-07-17  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 854         declare.
 855         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 856         Rename from tui_first_reg_element_no_inline.
 857         (tui_display_reg_element_at_line)
 858         (tui_display_registers_from_line): Update.
 859         * tui/tui-data.h (struct tui_data_window)
 860         <first_reg_element_no_inline>: New method.
 861
 862 2019-07-17  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui-windata.c (tui_display_data_from)
 865         (tui_data_window::do_scroll_vertical): Update.
 866         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 867         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 868         Rename from tui_line_from_reg_element_no.
 869         (tui_display_registers_from_line): Update.
 870         * tui/tui-data.h (struct tui_data_window)
 871         <line_from_reg_element_no>: New method.
 872
 873 2019-07-17  Tom Tromey  <tom@tromey.com>
 874
 875         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 876         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 877         tui_last_regs_line_no.
 878         (tui_display_reg_element_at_line)
 879         (tui_display_registers_from_line): Update.
 880         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 881         method.
 882
 883 2019-07-17  Tom Tromey  <tom@tromey.com>
 884
 885         PR tui/24722:
 886         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 887         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 888         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 889         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 890         (tui_update_breakpoint_info): Likewise.
 891         * tui/tui-hooks.c (tui_event_create_breakpoint)
 892         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 893         Update.
 894
 895 2019-07-17  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 898
 899 2019-07-17  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-winsource.c (tui_update_source_window_as_is)
 902         (tui_update_source_windows_with_addr): Update.
 903         * tui/tui-source.h (tui_set_source_content)
 904         (tui_show_symtab_source): Add "win_info" parameter.
 905         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 906         parameter.
 907         (tui_show_symtab_source): Likewise.
 908
 909 2019-07-17  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-wingeneral.c
 912         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 913
 914 2019-07-17  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 917         (struct tui_cmd_window) <can_scroll>: New method.
 918         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 919         method.
 920
 921 2019-07-17  Tom Tromey  <tromey@adacore.com>
 922
 923         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 924         do_field_signed>: Rename.  Change type of "value".
 925         * ui-out.c (ui_out::field_signed): Rename from field_int.
 926         Change type of "value".
 927         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 928         type of "value".
 929         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 930         do_field_int.  Change type of "value".
 931         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 932         do_field_int.  Change type of "value".
 933         * tracepoint.c (trace_status_mi, tfind_1)
 934         (print_one_static_tracepoint_marker): Update.
 935         * thread.c (print_thread_info_1, print_selected_thread_frame):
 936         Update.
 937         * stack.c (print_frame, print_frame_info): Update.
 938         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 939         Update.
 940         * source.c (print_source_lines_base): Update.
 941         * skip.c (info_skip_command): Update.
 942         * record-btrace.c (btrace_ui_out_decode_error)
 943         (btrace_call_history_src_line): Update.
 944         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 945         Update.
 946         * progspace.c (print_program_space): Update.
 947         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 948         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 949         do_field_int.  Change type of "value".
 950         * mi/mi-out.c (mi_ui_out::do_table_begin)
 951         (mi_ui_out::do_table_header): Update.
 952         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 953         type of "value".
 954         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 955         (mi_cmd_data_list_changed_registers, output_register)
 956         (mi_cmd_data_read_memory, mi_load_progress)
 957         (mi_cmd_trace_frame_collected): Update.
 958         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 959         Update.
 960         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 961         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 962         (mi_cmd_var_list_children, varobj_update_one): Update.
 963         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 964         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 965         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 966         * inferior.c (print_inferior): Update.
 967         * gdb_bfd.c (print_one_bfd): Update.
 968         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 969         Update.
 970         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 971         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 972         do_field_int.  Change type of "value".
 973         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 974         do_field_int.  Change type of "value".
 975         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 976         (print_one_breakpoint_location, print_it_catch_fork)
 977         (print_one_catch_fork, print_it_catch_vfork)
 978         (print_one_catch_vfork, print_it_catch_solib)
 979         (print_it_catch_exec, print_it_ranged_breakpoint)
 980         (print_mention_watchpoint, print_mention_masked_watchpoint)
 981         (bkpt_print_it, update_static_tracepoint): Update.
 982         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 983         * break-catch-syscall.c (print_it_catch_syscall): Update.
 984         * ada-tasks.c (print_ada_task_info): Update.
 985         * ada-lang.c (print_it_exception, print_mention_exception):
 986         Update.
 987
 988 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         PR breakpoints/24541
 991         * gdbarch.c: Regenerate.
 992         * gdbarch.h: Regenerate.
 993         * gdbarch.sh: Adjust return type and parameter types for
 994         'stap_adjust_register'.
 995         (i386_stap_adjust_register): Adjust signature and return new
 996         register name.
 997         * stap-probe.c (stap_parse_register_operand): Adjust use of
 998         'gdbarch_stap_adjust_register'.
 999
1000 2019-07-17  Tom Tromey  <tromey@adacore.com>
1001
1002         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1003         declare VEC.
1004         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1005         std::vector.
1006         (struct s390_process_info): Add initializers.
1007         (s390_add_process): Use new.
1008         (s390_linux_nat_target::low_forget_process): Use delete.
1009         (s390_linux_nat_target::low_new_fork)
1010         (s390_linux_nat_target::stopped_by_watchpoint)
1011         (s390_linux_nat_target::low_prepare_to_resume)
1012         (s390_linux_nat_target::insert_watchpoint)
1013         (s390_linux_nat_target::insert_hw_breakpoint)
1014         (s390_linux_nat_target::remove_watchpoint)
1015         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1016
1017 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1018
1019         * aarch64-fbsd-nat.c: Include regcache.h.
1020         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1021         argument.
1022         (aarch64_fbsd_nat_target::fetch_registers)
1023         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1024         variable.
1025         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1026
1027 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1028
1029         * fbsd-nat.c: Include gdbarch.h.
1030
1031 2019-07-15  Tom Tromey  <tromey@adacore.com>
1032
1033         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1034
1035 2019-07-15  Tom Tromey  <tromey@adacore.com>
1036
1037         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1038         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1039         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1040         * cli-out.c (cli_ui_out::do_field_int): New method.
1041         * ui-out.c (ui_out::field_unsigned): New method.
1042         * symfile.c (generic_load): Use field_unsigned.
1043         (print_transfer_performance): Likewise.
1044         * record-btrace.c (ui_out_field_uint): Remove.
1045         (btrace_call_history_insn_range, btrace_call_history): Use
1046         field_unsigned.
1047         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1048         field_unsigned.
1049         * ui-out.h (class ui_out) <field_unsigned>: New method.
1050         <do_field_unsigned>: Likewise.
1051
1052 2019-07-15  Tom Tromey  <tromey@adacore.com>
1053
1054         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1055         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1056         * target.c (flash_erase_command): Use field_string.
1057         * infrun.c (print_signal_received_reason): Use field_string.
1058         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1059         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1060         field_string.
1061         * ada-tasks.c (print_ada_task_info): Use field_string.
1062
1063 2019-07-15  Tom Tromey  <tromey@adacore.com>
1064
1065         * target.c (flash_erase_command): Use field_core_addr.
1066         * symfile.c (generic_load): Use field_core_addr.
1067         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1068         Use field_core_addr.
1069         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1070         field_core_addr.
1071
1072 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1073
1074         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1075         value if its desired type is smaller than a CORE_ADDR and signed.
1076
1077 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1078
1079         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1080         of changes to field names, and use new is_reference field to
1081         decide if a property is a reference or not.
1082         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1083         field.
1084         (struct dwarf2_property_baton): Update header comment, rename
1085         'referenced_type' to 'property_type' and update comments.
1086         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1087         default property type, store in property baton, update to take
1088         accound of renamed field.
1089         (read_func_scope): Update call to attr_to_dynamic_prop.
1090         (read_array_type): Likewise.
1091         (dwarf2_per_cu_addr_sized_int_type): New function.
1092         (read_subrange_index_type): Move type finding code to
1093         dwarf2_per_cu_addr_sized_int_type.
1094         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1095         (dwarf2_per_cu_addr_type): New function.
1096         (set_die_type): Update calls to attr_to_dynamic_prop.
1097
1098 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1099
1100         * dwarf2read.c (read_subrange_index_type): New function.
1101         (read_subrange_type): Move code into new function and call it.
1102         * gdbtypes.c (create_range_type): Add some asserts.
1103
1104 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1105
1106         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1107         update return statements.
1108         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1109         declaration, and update comment to match.
1110         * gdbtypes.c (resolve_dynamic_array): Update call to
1111         dwarf2_evaluate_property to match new return type.
1112
1113 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1114
1115         * valarith.c (value_subscripted_rvalue): Change lowerbound
1116         parameter type from int to LONGEST.
1117         * value.h (value_subscripted_rvalue): Likewise in declaration.
1118
1119 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1120
1121         * cli/cli-utils.c (info_print_command_completer): New function.
1122         * cli/cli-utils.h: Add 'completer.h' include, and forward
1123         declaration for 'struct cmd_list_element'.
1124         (info_print_command_completer): Declare.
1125         * stack.c (_initialize_stack): Add completer for 'info locals' and
1126         'info args'.
1127         * symtab.c (_initialize_symtab): Add completer for 'info
1128         variables' and 'info functions'.
1129         * NEWS: Mention completion for additional info commands.
1130
1131 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * cli/cli-utils.c (extract_info_print_args): Delete.
1134         (extract_arg_maybe_quoted): Delete.
1135         (info_print_options_defs): New variable.
1136         (make_info_print_options_def_group): New function.
1137         (extract_info_print_options): Define new function.
1138         * cli/cli-utils.h (extract_info_print_args): Delete.
1139         (struct info_print_options): New structure.
1140         (extract_info_print_options): Declare new function.
1141         * stack.c (info_locals_command): Update to use new
1142         extract_info_print_options, also add a header comment.
1143         (info_args_command): Likewise.
1144         * symtab.c (info_variables_command): Likewise.
1145         (info_functions_command): Likewise.
1146
1147 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1148
1149         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1150         to extract string arguments.
1151         * common/common-utils.c (extract_string_maybe_quoted): New function.
1152         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1153
1154 2019-07-11  Tom Tromey  <tromey@adacore.com>
1155
1156         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1157         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1158         * top.h (gdbinit): Don't declare.
1159         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1160         into...
1161         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1162         * top.c (gdb_init): Don't call init_cli_cmds.
1163         (gdbinit): Remove.
1164         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1165
1166 2019-07-11  Tom Tromey  <tromey@adacore.com>
1167
1168         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1169         after it has been moved.
1170
1171 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1172
1173         * valops.c (value_must_coerce_to_target): Change return type to
1174         bool.
1175         * value.h (value_must_coerce_to_target): Likewise.
1176
1177 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1178
1179         * breakpoint.c (is_hardware_watchpoint): Remove
1180         forward-declaration.
1181         (is_masked_watchpoint): Change return type to bool.
1182         (is_tracepoint): Likewise.
1183         (is_breakpoint): Likewise.
1184         (is_hardware_watchpoint): Likewise.
1185         (is_watchpoint): Likewise.
1186         (is_no_memory_software_watchpoint): Likewise.
1187         (is_catchpoint): Likewise.
1188         (breakpoint_1): Make FILTER parameter's return type bool.
1189         is_masked_watchpoint): Change return type to bool.
1190         (save_breakpoints): Make FILTER parameter's return type bool.
1191         * breakpoint.h (is_breakpoint): Change return type to bool.
1192         (is_watchpoint): Likewise.
1193         (is_catchpoint): Likewise.
1194         (is_tracepoint): Likewise.
1195
1196 2019-07-10  Tom Tromey  <tom@tromey.com>
1197
1198         * defs.h: Don't include gdbarch.h.
1199         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1200         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1201         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1202         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1203         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1204         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1205         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1206         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1207         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1208         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1209         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1210         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1211         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1212         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1213         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1214         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1215         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1216         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1217         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1218         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1219         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1220         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1221         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1222         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1223         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1224         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1225         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1226
1227 2019-07-10  Tom Tromey  <tromey@adacore.com>
1228
1229         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1230         * breakpoint.c (init_ada_exception_breakpoint): Register as
1231         bp_catchpoint.
1232         (print_one_breakpoint_location, print_one_breakpoint): Use
1233         is_ada_exception_catchpoint.
1234         * ada-lang.c (class ada_catchpoint_location): Pass
1235         bp_loc_software_breakpoint to bp_location constructor.
1236         (is_ada_exception_catchpoint): New function.
1237
1238 2019-07-10  Tom Tromey  <tromey@adacore.com>
1239
1240         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1241         VEC.
1242         (struct arm_exidx_entry): New method operator<.
1243         (struct arm_exidx_data) <section_maps>: Change type.
1244         (arm_exidx_data_free): Remove.
1245         (arm_exidx_data_key): Change type.  Move lower.
1246         (arm_exidx_new_objfile): Update.
1247         (arm_compare_exidx_entries): Remove.
1248         (arm_find_exidx_entry, _initialize_arm_tdep)
1249
1250 2019-07-10  Tom Tromey  <tromey@adacore.com>
1251
1252         * solib-spu.c (ocl_program_data_key): Change type.
1253         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1254         Update.
1255
1256 2019-07-10  Tom Tromey  <tromey@adacore.com>
1257
1258         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1259         (struct solib_aix_inferior_data) <library_list>: Change type.
1260         (solib_aix_inferior_data_handle): Change type.
1261         (get_solib_aix_inferior_data): Update.
1262         (solib_aix_free_library_list): Remove.
1263         (library_list_start_library): Update.
1264         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1265         return type.
1266         (solib_aix_get_library_list)
1267         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1268         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1269
1270 2019-07-10  Tom Tromey  <tromey@adacore.com>
1271
1272         * solib-dsbt.c (struct dsbt_info): Add initializers.
1273         (solib_dsbt_pspace_data): Change type.
1274         (dsbt_pspace_data_cleanup): Remove.
1275         (get_dsbt_info, _initialize_dsbt_solib): Update.
1276
1277 2019-07-10  Tom Tromey  <tromey@adacore.com>
1278
1279         * spu-tdep.c (spu_overlay_data): Change type.
1280         (spu_get_overlay_table, spu_overlay_new_objfile)
1281         (_initialize_spu_tdep): Update.
1282
1283 2019-07-10  Tom Tromey  <tromey@adacore.com>
1284
1285         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1286         destructor.
1287         (dbx_objfile_data_key): Change type and declare later.
1288         (DBX_SYMFILE_INFO): Rewrite.
1289         * dbxread.c (dbx_objfile_data_key): Change type.
1290         (dbx_symfile_init): Update.
1291         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1292         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1293         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1294
1295 2019-07-10  Tom Tromey  <tromey@adacore.com>
1296
1297         * jit.c (jit_program_space_key): Change type.  Move lower.
1298         (get_jit_program_space_data): Update.
1299         (jit_program_space_data_cleanup): Remove.
1300         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1301         Update.
1302         (struct jit_program_space_data): Add initializers.
1303
1304 2019-07-10  Tom Tromey  <tromey@adacore.com>
1305
1306         * solib-darwin.c (struct darwin_info): Add initializers.
1307         (solib_darwin_pspace_data): Change type.
1308         (darwin_pspace_data_cleanup): Remove.
1309         (get_darwin_info, _initialize_darwin_solib): Update.
1310
1311 2019-07-10  Tom Tromey  <tromey@adacore.com>
1312
1313         * remote-sim.c (struct sim_inferior_data): Add initializers,
1314         constructor, and destructor.
1315         (sim_inferior_data_key): Change type.  Move lower.
1316         (check_for_duplicate_sim_descriptor): Update.
1317         (get_sim_inferior_data): Use new.  Update.
1318         (~sim_inferior_data_cleanup): Rename from
1319         sim_inferior_data_cleanup.  Simplify.
1320         (gdbsim_close_inferior, simulator_command)
1321         (sim_command_completer, _initialize_remote_sim): Update.
1322         (next_pid, INITIAL_PID): Move earlier.
1323
1324 2019-07-10  Tom Tromey  <tromey@adacore.com>
1325
1326         * python/python-internal.h (create_thread_object): Return
1327         gdbpy_ref.
1328         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1329         * python/py-inferior.c (struct threadlist_entry): Add
1330         constructor.
1331         <thread_obj>: Now a gdbpy_ref.
1332         (thread_to_thread_object): Update.
1333         (add_thread_object): Use new.
1334         (delete_thread_object): Use delete.
1335         (infpy_threads): Update.
1336         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1337         GIL.
1338
1339 2019-07-10  Tom Tromey  <tromey@adacore.com>
1340
1341         * valops.c (value_cast): Specialize error message for Ada.
1342
1343 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1344
1345         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1346
1347 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1348
1349         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1350         bpstat_should_step): Return bool, adjust comments.
1351         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1352         bpstat_should_step): Likewise.
1353
1354 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1355
1356         * features/Makefile: Use feature target descriptions for Arm.
1357         * features/arm/arm-core.c: Generate new file.
1358         * features/arm/arm-fpa.c: Likewise.
1359         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1360         * features/arm/arm-m-profile.c: Likewise.
1361         * features/arm/arm-vfpv2.c: Likewise.
1362         * features/arm/arm-vfpv3.c: Likewise.
1363         * features/arm/xscale-iwmmxt.c: Likewise.
1364         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1365
1366 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1367
1368         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1369         ptrace earlier.
1370
1371 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1372
1373         * features/aarch64-pauth.c: Regenerate.
1374
1375 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1376
1377         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1378         bool.
1379         (bpstat_what): Use false instead of 0.
1380
1381 2019-07-09  Pedro Alves  <palves@redhat.com>
1382
1383         * break-catch-throw.c (is_exception_catchpoint): New.
1384         * breakpoint.c (print_one_breakpoint_location): New parameter
1385         'raw_loc'.  Handle it.  Use
1386         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1387         looking at the breakpoint's type.
1388         (print_one_breakpoint): If handling "maint info breakpoints", also
1389         print locations of exception catchpoints.
1390         * breakpoint.h (is_exception_catchpoint): Declare.
1391
1392 2019-07-09  Pedro Alves  <palves@redhat.com>
1393
1394         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1395         "addr" field.
1396         (allocate_location_exception_catchpoint): New.
1397         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1398         (initialize_throw_catchpoint_ops): Install
1399         allocate_location_exception_catchpoint as allocate_location
1400         method.
1401         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1402         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1403         bp_loc_other.
1404         (breakpoint_address_is_meaningful): Delete.
1405         (bl_address_is_meaningful): New.
1406         (breakpoint_locations_match): Adjust comment.
1407         (bp_location_from_bp_type): New, factored out of...
1408         (bp_location::bp_location(breakpoint *)): ... this.
1409         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1410         factored out of...
1411         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1412         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1413         breakpoint_address_is_meaningful.
1414         (bp_locations_compare): Adjust comment.
1415         (update_global_location_list): Use bl_address_is_meaningful
1416         instead of breakpoint_address_is_meaningful.
1417         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1418         explicit.
1419         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1420         * python/py-breakpoint.c (bppy_get_location): No longer check
1421         whether location is null.
1422
1423 2019-07-09  Pedro Alves  <palves@redhat.com>
1424
1425         PR c++/15468
1426         * breakpoint.c (print_one_breakpoint_location): Remove
1427         single-location assert.
1428
1429 2019-07-09  Tom Tromey  <tom@tromey.com>
1430
1431         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1432         * configure: Rebuild.
1433         * configure.ac: Change common to gdbsupport.
1434         * gdbsupport: Rename from common.
1435         * acinclude.m4: Change common to gdbsupport.
1436         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1437         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1438         gdbsupport.
1439         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1440         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1441         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1442         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1443         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1444         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1445         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1446         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1447         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1448         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1449         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1450         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1451         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1452         coff-pe-read.c, command.h, compile/compile-c-support.c,
1453         compile/compile-c.h, compile/compile-cplus-symbols.c,
1454         compile/compile-cplus-types.c, compile/compile-cplus.h,
1455         compile/compile-loc2c.c, compile/compile.c, completer.c,
1456         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1457         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1458         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1459         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1460         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1461         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1462         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1463         features/aarch64-core.c, features/aarch64-fpu.c,
1464         features/aarch64-pauth.c, features/aarch64-sve.c,
1465         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1466         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1467         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1468         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1469         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1470         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1471         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1472         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1473         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1474         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1475         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1476         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1477         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1478         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1479         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1480         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1481         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1482         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1483         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1484         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1485         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1486         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1487         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1488         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1489         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1490         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1491         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1492         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1493         minsyms.c, mips-linux-tdep.c, namespace.h,
1494         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1495         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1496         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1497         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1498         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1499         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1500         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1501         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1502         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1503         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1504         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1505         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1506         procfs.c, producer.c, progspace.h, psymtab.h,
1507         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1508         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1509         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1510         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1511         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1512         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1513         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1514         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1515         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1516         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1517         target-memory.c, target.c, target.h, target/waitstatus.c,
1518         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1519         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1520         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1521         unittests/array-view-selftests.c,
1522         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1523         unittests/common-utils-selftests.c,
1524         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1525         unittests/format_pieces-selftests.c,
1526         unittests/function-view-selftests.c,
1527         unittests/lookup_name_info-selftests.c,
1528         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1529         unittests/mkdir-recursive-selftests.c,
1530         unittests/observable-selftests.c,
1531         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1532         unittests/parse-connection-spec-selftests.c,
1533         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1534         unittests/scoped_fd-selftests.c,
1535         unittests/scoped_mmap-selftests.c,
1536         unittests/scoped_restore-selftests.c,
1537         unittests/string_view-selftests.c, unittests/style-selftests.c,
1538         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1539         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1540         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1541         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1542         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1543         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1544
1545 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1546
1547         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1548         bool value.
1549         (decode_digits_ordinary): Set explicit_line field in sal.
1550         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1551         symtab_and_line that was set on an explicit line number in
1552         assembler code.  Do always update the recorded symtab and line if
1553         we do skip the prologue.
1554
1555 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1556
1557         * breakpoint.c (set_breakpoint_location_function): Remove
1558         explicit_loc parameter.
1559         (momentary_breakpoint_from_master): Update call to
1560         set_breakpoint_location_function.
1561         (add_location_to_breakpoint): Likewise.
1562
1563 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1564
1565         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1566         required features based on default bfd type when no specific bfd
1567         is present.
1568
1569 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1570
1571         * NEWS: Mention that GDB printf and eval commands can now print
1572         C-style and Ada-style convenience var strings without
1573         calling the inferior.
1574         * printcmd.c (printf_c_string): Locally print GDB internal var
1575         instead of transiting via the inferior.
1576         (printf_wide_c_string): Likewise.
1577
1578 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1579
1580         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1581
1582 2019-07-04  Tom Tromey  <tom@tromey.com>
1583
1584         PR tui/24724:
1585         * tui/tui-winsource.c (tui_clear_source_content): Update.
1586         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1587         (tui_update_breakpoint_info): Update.
1588         (tui_set_exec_info_content): Update.
1589         * tui/tui-source.c (tui_set_source_content_nil): Update.
1590         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1591         has_break.
1592         * tui/tui-data.h (enum tui_bp_flag): New.
1593         (tui_bp_flags): New enum flags type.
1594         (struct tui_source_element) <break_mode>: Change type.  Rename
1595         from has_break.
1596         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1597         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1598         constants.
1599         * tui/tui-winsource.h: Fix comment.
1600
1601 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1602
1603         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1604         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1605         (store_fpregs_to_thread)
1606         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1607         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1608         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1609         (IWMMXT_REGS_SIZE): Add define.
1610         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1611         (fetch_vfp_regs, store_vfp_regs)
1612         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1613         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1614
1615 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1616
1617         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1618         defines.
1619         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1620         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1621         (ARM_INT_REGISTER_SIZE): ...to this.
1622         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1623         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1624         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1625         (arm_linux_collect_gregset, supply_nwfpe_register)
1626         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1627         defines.
1628         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1629         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1630         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1631         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1632         (arm_return_in_memory, arm_store_return_value)
1633         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1634         (arm_record_ld_st_multiple): Likewise.
1635         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1636         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1637
1638 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1639
1640         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1641         AARCH64_DISPLACED_MODIFIED_INSNS.
1642         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1643         (aarch64_displaced_step_copy_insn): Likewise.
1644         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1645         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1646         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1647         ARM_DISPLACED_MODIFIED_INSNS.
1648         * arm-tdep.c (arm_gdbarch_init): Likewise.
1649         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1650         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1651         (struct arm_displaced_step_closure): Use
1652         ARM_DISPLACED_MODIFIED_INSNS.
1653
1654 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1655
1656         * features/Makefile: Remove unused xml files.
1657         * features/aarch64.xml: Remove.
1658         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1659         * features/i386/amd64-avx-avx512.xml: Remove.
1660         * features/i386/amd64-avx-linux.xml: Remove.
1661         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1662         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1663         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1664         * features/i386/amd64-avx-mpx.xml: Remove.
1665         * features/i386/amd64-avx.xml: Remove.
1666         * features/i386/amd64-linux.xml: Remove.
1667         * features/i386/amd64-mpx-linux.xml: Remove.
1668         * features/i386/amd64-mpx.xml: Remove.
1669         * features/i386/amd64.xml: Remove.
1670         * features/i386/i386-avx-avx512-linux.xml: Remove.
1671         * features/i386/i386-avx-avx512.xml: Remove.
1672         * features/i386/i386-avx-linux.xml: Remove.
1673         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1674         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1675         * features/i386/i386-avx-mpx-linux.xml: Remove.
1676         * features/i386/i386-avx-mpx.xml: Remove.
1677         * features/i386/i386-avx.xml: Remove.
1678         * features/i386/i386-linux.xml: Remove.
1679         * features/i386/i386-mmx-linux.xml: Remove.
1680         * features/i386/i386-mmx.xml: Remove.
1681         * features/i386/i386-mpx-linux.xml: Remove.
1682         * features/i386/i386-mpx.xml: Remove.
1683         * features/i386/i386.xml: Remove.
1684         * features/i386/x32-avx-avx512-linux.xml: Remove.
1685         * features/i386/x32-avx-linux.xml: Remove.
1686         * features/i386/x32-linux.xml: Remove.
1687
1688 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1689
1690         * regformats/aarch64.dat: Remove.
1691         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1692         * regformats/i386/amd64-avx-linux.dat: Remove.
1693         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1694         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1695         * regformats/i386/amd64-linux.dat: Remove.
1696         * regformats/i386/amd64-mpx-linux.dat: Remove.
1697         * regformats/i386/amd64.dat: Remove.
1698         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1699         * regformats/i386/i386-avx-linux.dat: Remove.
1700         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1701         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1702         * regformats/i386/i386-linux.dat: Remove.
1703         * regformats/i386/i386-mmx-linux.dat: Remove.
1704         * regformats/i386/i386-mpx-linux.dat: Remove.
1705         * regformats/i386/i386.dat: Remove.
1706         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1707         * regformats/i386/x32-avx-linux.dat: Remove.
1708         * regformats/i386/x32-linux.dat: Remove.
1709
1710 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1711
1712         * aarch64-tdep.c: Remove xml self tests.
1713         * amd64-linux-tdep.c: Likewise.
1714         * amd64-tdep.c: Likewise.
1715         * i386-linux-tdep.c: Likewise.
1716         * i386-tdep.c: Likewise.
1717
1718 2019-07-03  Pedro Alves  <palves@redhat.com>
1719
1720         PR cli/24732
1721         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1722         (pipe_cmd_option_defs): New.
1723         (make_pipe_cmd_options_def_group): New.
1724         (pipe_command): Use gdb::option::process_options.
1725         (pipe_command_completer): New function.
1726         (_initialize_cli_cmds): Install completer for "pipe" command.
1727
1728 2019-07-03  Pedro Alves  <palves@redhat.com>
1729
1730         * cli/cli-option.c (union option_value) <string>: New field.
1731         (struct option_def_and_value): Add ctor, move ctor, dtor and
1732         use DISABLE_COPY_AND_ASSIGN.
1733         (option_def_and_value::clear_value): New.
1734         (parse_option, save_option_value_in_ctx, get_val_type_str)
1735         (add_setshow_cmds_for_options): Handle var_string.
1736         * cli-option.h (union option_def::var_address) <string>: New
1737         field.
1738         (struct string_option_def): New.
1739         * maint-test-options.c (struct test_options_opts): Add default
1740         ctor and use DISABLE_COPY_AND_ASSIGN.
1741         <string_opt>: New field.
1742         (test_options_opts::~test_options_opts): New.
1743         (test_options_opts::dump): Also dump "-string".
1744         (test_options_option_defs): Install "string.
1745
1746 2019-07-03  Pedro Alves  <palves@redhat.com>
1747
1748         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1749         option_value with a null enumeration.
1750         (complete_options): Save the option values in the context.
1751         (save_option_value_in_ctx): New, factored out from ...
1752         (process_options): ... here.
1753         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1754         of the function.
1755         * maint-test-options.c (test_options_opts::dump): New, factored
1756         out from ...
1757         (maintenance_test_options_command_mode): ... here.
1758         (maintenance_test_options_command_completion_result): Delete.
1759         (maintenance_test_options_command_completion_text): Update
1760         comment.
1761         (maintenance_show_test_options_completion_result): Change
1762         prototype.  Just print
1763         maintenance_test_options_command_completion_text.
1764         (save_completion_result): New.
1765         (maintenance_test_options_completer_mode): Pass options context to
1766         complete_options, and then save a dump.
1767         (_initialize_maint_test_options): Use add_cmd to install "maint
1768         show test-options-completion-result".
1769
1770 2019-07-03  Pedro Alves  <palves@redhat.com>
1771
1772         * NEWS (New commands): Mention "with" and "maint with".
1773         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1774         (with_command, with_command_completer): New.
1775         (pipe_command): Adjust to new repeat_previous
1776         interface.
1777         (_initialize_cli_cmds): Install the "with" command and its "w"
1778         alias.
1779         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1780         declarations.
1781         * cli/cli-setshow.c (parse_cli_var_uinteger)
1782         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1783         argument strings for all var_types.
1784         (get_setshow_command_value_string): New, factored out from ...
1785         (do_show_command): ... this.
1786         * cli/cli-setshow.h: Include <string>.
1787         (get_setshow_command_value_string): Declare.
1788         * command.h (repeat_previous): Now returns const char *.  Adjust
1789         comment.
1790         * maint.c: Include "cli/cli-cmds.h".
1791         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1792         (_initialize_maint_cmds): Register the "maintenance with" command.
1793         * top.c (repeat_previous): Move bits from pipe_command here:
1794         Return the saved command line, if any; error out if there's no
1795         command to relaunch.
1796
1797 2019-07-03  Pedro Alves  <palves@redhat.com>
1798
1799         * NEWS (New commands): Mention "maint set/show test-settings"
1800         instead of "maint test-settings".
1801         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1802         (maintenance_test_settings_set_list): Rename to ...
1803         (maintenance_set_test_settings_list): ... this.
1804         (maintenance_test_settings_show_list): Rename to  ...
1805         (maintenance_show_test_settings_list): ... this.
1806         (maintenance_test_settings_cmd): Delete.
1807         (maintenance_test_settings_set_cmd): ...
1808         (maintenance_set_test_settings_cmd): ... this.
1809         (maintenance_test_settings_show_cmd): ...
1810         (maintenance_show_test_settings_cmd): ... this.
1811         (maintenance_test_settings_show_value_cmd):
1812         (maintenance_show_test_settings_value_cmd): ... this.
1813         (_initialize_maint_test_settings): No longer install the "maint
1814         test-settings" prefix command.  Rename "maint test-settings set"
1815         to "maint set test-settings", and "maint test-settings show" to
1816         "maint show test-settings".  Adjust all subcommands.
1817
1818 2019-07-03  Pedro Alves  <palves@redhat.com>
1819
1820         * maint-test-settings.c: Fix file's intro comment.  Replace all
1821         references to "test-options" with references to "test-settings",
1822         in comments.
1823
1824 2019-07-03  Pedro Alves  <palves@redhat.com>
1825
1826         * maint-test-settings.c (maintenance_test_settings_xxx)
1827         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1828         New.
1829         (maintenance_test_settings_enums): Use them.
1830         (maintenance_test_settings_enum): Default to
1831         maintenance_test_settings_xxx.
1832         (_initialize_maint_test_settings): Initialize
1833         MAINTENANCE_TEST_SETTINGS_FILENAME.
1834
1835 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1836
1837         * breakpoint.h (remove_breakpoints_inf): Change return type to
1838         void, move function documentation here.
1839         * breakpoint.c (remove_breakpoints_inf): Change return type to
1840         void, move function documentation to header.
1841
1842 2019-07-02  Pedro Alves  <palves@redhat.com>
1843
1844         * NEWS (Completion improvements): Mention "info threads".
1845         * thread.c (struct info_threads_opts, info_threads_option_defs)
1846         (make_info_threads_options_def_group): New.
1847         (info_threads_command): Use gdb::option::process_options.
1848         (info_threads_command_completer): New.
1849         (_initialize_thread): Use gdb::option::build_help to build the
1850         help text for "info threads".
1851
1852 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1853
1854         * defs.h (generic_load): Move from here...
1855         * symfile.h (generic_load): ... to here.  Rename name parameter
1856         to args.
1857         * symfile.c (generic_load): Add comment.
1858
1859 2019-07-01  Tom Tromey  <tromey@adacore.com>
1860
1861         * dwarf2read.c
1862         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1863         declaration of without_params.  Fix formatting.
1864
1865 2019-07-01  Tom Tromey  <tromey@adacore.com>
1866
1867         * ada-exp.y (find_primitive_type): Update.
1868         * ada-lang.h (ada_lookup_symbol): Update.
1869         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1870         parameter.
1871         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1872
1873 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1874
1875         PR breakpoints/24541
1876         * gdbarch.c: Regenerate.
1877         * gdbarch.h: Regenerate.
1878         * gdbarch.sh: Add 'stap_adjust_register'.
1879         * i386-tdep.c: Include '<unordered_set>'.
1880         (i386_stap_adjust_register): New function.
1881         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1882         * stap-probe.c (stap_parse_register_operand): Call
1883         'gdbarch_stap_adjust_register'.
1884
1885 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1886
1887         PR python/24742
1888         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1889         * python/python.c (do_start_initialization): Use 'xmalloc'
1890         instead of 'PyMem_Malloc'.
1891
1892 2019-06-28  Tom Tromey  <tromey@adacore.com>
1893
1894         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1895         for Ada.
1896
1897 2019-06-27  Tom Tromey  <tromey@adacore.com>
1898
1899         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1900         objfile_key.
1901         (arm_find_mapping_symbol, arm_record_special_symbol)
1902         (_initialize_arm_tdep): Update.
1903         (arm_objfile_data_free): Remove.
1904
1905 2019-06-27  Tom Tromey  <tromey@adacore.com>
1906
1907         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1908         to cp_print_static_field.
1909
1910 2019-06-26  Tom Tromey  <tromey@adacore.com>
1911
1912         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1913         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1914         declare.
1915
1916 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1917
1918         * features/aarch64-core.c (create_feature_aarch64_core):
1919         Regenerate.
1920         * features/aarch64-core.xml: Add cpsr flags.
1921
1922 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1923
1924         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1925         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1926
1927 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1928
1929         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1930         field.
1931         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1932         use.
1933         (arm_record_special_symbol): Don't insert new symbol in sorted
1934         position, push it at the end.
1935
1936 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1937
1938         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1939         (arm_mapping_symbol_s): Remove.
1940         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1941         (arm_mapping_symbol_vec): New typedef.
1942         (struct arm_per_objfile): Add constructor.
1943         <section_maps>: Change type to
1944         std::unique_ptr<arm_mapping_symbol_vec[]>.
1945         (arm_compare_mapping_symbols): Remove.
1946         (arm_find_mapping_symbol): Adjust to section_maps type change.
1947         (arm_objfile_data_free): Call delete on arm_per_objfile.
1948         (arm_record_special_symbol): Adjust to section_maps type change.
1949         Allocate arm_per_objfile with new.
1950
1951 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1952
1953         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1954         with the command prefix.
1955
1956 2019-06-25  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1959         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1960
1961 2019-06-25  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1964         type.
1965         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1966         protected.
1967
1968 2019-06-25  Tom Tromey  <tom@tromey.com>
1969
1970         * tui/tui-winsource.c
1971         (tui_source_window_base::set_is_exec_point_at): Add check against
1972         LOA_ADDRESS.
1973
1974 2019-06-25  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-source.c (tui_set_source_content): Don't check before
1977         xfree.
1978         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1979
1980 2019-06-25  Tom Tromey  <tom@tromey.com>
1981
1982         * tui/tui-winsource.h (tui_update_source_window_as_is)
1983         (tui_alloc_source_buffer, tui_line_is_displayed)
1984         (tui_addr_is_displayed): Change type of win_info.
1985         * tui/tui-winsource.c (tui_update_source_window_as_is)
1986         (tui_clear_source_content, tui_show_source_line)
1987         (tui_show_source_content, tui_source_window_base::refill)
1988         (tui_source_window_base::set_is_exec_point_at)
1989         (tui_source_window_base::set_is_exec_point_at)
1990         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1991         (tui_alloc_source_buffer, tui_line_is_displayed)
1992         (tui_addr_is_displayed): Change type of win_info.  Update.
1993         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1994         (tui_source_window_base::do_make_visible_with_new_height):
1995         Update.
1996         * tui/tui-source.c (tui_set_source_content)
1997         (tui_set_source_content_nil)
1998         (tui_source_window::do_scroll_vertical): Update.
1999         * tui/tui-layout.c (show_layout): Update.
2000         * tui/tui-disasm.c (tui_set_disassem_content)
2001         (tui_disasm_window::do_scroll_vertical): Update.
2002         * tui/tui-data.h (tui_win_content): Remove.
2003         (struct tui_gen_win_info) <content, content_size>: Remove.
2004         (struct tui_source_element): Add initializers and destructor.
2005         (union tui_which_element, struct tui_win_element): Remove.
2006         (struct tui_source_window_base) <content>: New field.
2007         (struct tui_data_window): Remove destructor.
2008         (tui_alloc_content, tui_free_win_content)
2009         (tui_free_all_source_wins_content): Don't declare.
2010         * tui/tui-data.c (tui_initialize_static_data): Update.
2011         (init_content_element, tui_alloc_content): Remove.
2012         (~tui_gen_win_info): Update.
2013         (~tui_data_window, tui_free_all_source_wins_content)
2014         (tui_free_win_content, free_content, free_content_elements):
2015         Remove.
2016
2017 2019-06-25  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-winsource.h (tui_clear_source_content)
2020         (tui_erase_source_content, tui_show_source_content): Change type
2021         of win_info.
2022         * tui/tui-winsource.c (tui_clear_source_content)
2023         (tui_erase_source_content, tui_show_source_content): Change type
2024         of win_info.
2025         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2026         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2027         win_info.
2028         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2029         win_info.
2030         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2031
2032 2019-06-25  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui-winsource.c (tui_clear_source_content)
2035         (tui_source_window_base::set_is_exec_point_at): Update.
2036         * tui/tui-source.c (tui_set_source_content_nil): Update.
2037         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2038         a bool.
2039         * tui/tui-data.c (init_content_element): Update.
2040
2041 2019-06-25  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2044         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2045         * tui/tui-layout.c (init_and_make_win): Update.
2046         * tui/tui.h (enum tui_win_type): Update.
2047         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2048         tui_win_is_auxillary.
2049         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2050         tui_win_is_auxillary.
2051
2052 2019-06-25  Tom Tromey  <tom@tromey.com>
2053
2054         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2055         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2056         (tui_delete_data_content_windows, tui_display_all_data)
2057         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2058         Update.
2059         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2060         * tui/tui-regs.c (tui_last_regs_line_no)
2061         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2062         (tui_show_registers): Update.
2063         (tui_show_register_group): Return void.  Update.
2064         (tui_display_registers_from, tui_display_reg_element_at_line)
2065         (tui_display_registers_from_line, tui_check_register_values):
2066         Update.
2067         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2068         member.
2069         (struct tui_data_window) <regs_content>: Now a std::vector.
2070         <regs_content_count>: Remove.
2071         (tui_add_content_elements, tui_free_data_content): Don't declare.
2072         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2073         (init_content_element): Remove DATA_WIN case.  Add assert.
2074         (tui_add_content_elements): Remove.
2075         (tui_data_window): Update.
2076         (tui_free_data_content): Remove.
2077         (free_content_elements): Remove DATA_WIN case.
2078
2079 2019-06-25  Tom Tromey  <tom@tromey.com>
2080
2081         * tui/tui-data.c (tui_data_item_window): Update.
2082         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2083         * tui/tui-windata.c (tui_display_all_data)
2084         (tui_display_data_from_line): Update.
2085         (tui_check_data_values): Remove.
2086         * tui/tui-regs.c (tui_show_register_group)
2087         (tui_display_reg_element_at_line): Update.
2088         * tui/tui-hooks.c (tui_register_changed)
2089         (tui_refresh_frame_and_register_information): Call
2090         tui_check_register_values.
2091         * tui/tui-data.h (struct tui_data_window) <data_content,
2092         data_content_count, data_type>: Remove.
2093         (enum tui_data_type): Remove.
2094
2095         * tui/tui-data.c (tui_data_window::clear_detail)
2096         (~tui_data_window): Update.
2097
2098 2019-06-25  Tom Tromey  <tom@tromey.com>
2099
2100         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2101         declare.
2102         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2103         Rename from tui_first_data_item_displayed.  Update.
2104         (tui_data_window::refresh_all)
2105         (tui_data_window::do_scroll_vertical): Update.
2106         * tui/tui-data.h (struct tui_data_window)
2107         <first_data_item_displayed>: Declare new method.
2108
2109 2019-06-25  Tom Tromey  <tom@tromey.com>
2110
2111         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2112         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2113         contents...
2114         (tui_initialize_static_data): ...here.
2115
2116 2019-06-25  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2119         (tui_display_registers_from, tui_check_register_values): Update.
2120         (tui_display_register): Remove win_info parameter; update.
2121         (tui_get_register): Change type of parameters.
2122         * tui/tui-data.h (struct tui_data_element): Remove.
2123         (union tui_which_element) <data>: Remove.
2124         <data_window>: Change type.
2125         (struct tui_data_item_window): New.
2126         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2127         case.  Add assert.
2128         (~tui_data_item_window): New destructor.
2129         (free_content_elements): Remove DATA_ITEM_WIN case.
2130
2131 2019-06-25  Tom Tromey  <tom@tromey.com>
2132
2133         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2134         Remove.
2135
2136 2019-06-25  Tom Tromey  <tom@tromey.com>
2137
2138         * tui/tui-data.h (struct tui_command_element): Remove.
2139         (union tui_which_element) <command>: Remove.
2140         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2141         assert.
2142         (free_content_elements): Remove CMD_WIN case.
2143
2144 2019-06-25  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-layout.c (tui_set_layout): Update.
2147         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2148         * tui/tui-data.c (layout_def): Update.
2149
2150 2019-06-25  Tom Tromey  <tom@tromey.com>
2151
2152         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2153         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2154         (tui_source_window_base::set_new_height): Update.
2155         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2156         Update.
2157         (tui_set_locator_fullname, tui_set_locator_info)
2158         (tui_show_frame_info): Update.
2159         * tui/tui-source.c (tui_set_source_content)
2160         (tui_source_is_displayed): Update.
2161         * tui/tui-layout.c (show_source_disasm_command, show_data)
2162         (show_source_or_disasm_and_command): Update.
2163         * tui/tui-disasm.c (tui_set_disassem_content)
2164         (tui_get_begin_asm_address): Update.
2165         * tui/tui-data.h (struct tui_locator_element): Remove.
2166         (union tui_which_element) <locator>: Remove.
2167         (struct tui_locator_window): New.
2168         (tui_locator_win_info_ptr): Change return type.
2169         * tui/tui-data.c (_locator): Change type.
2170         (tui_locator_win_info_ptr): Change return type.
2171         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2172         (tui_alloc_content): Add assert.
2173
2174 2019-06-25  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-winsource.c
2177         (tui_exec_info_window::maybe_allocate_content): New method.
2178         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2179         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2180         (make_source_or_disasm_window): Add cast.
2181         * tui/tui-data.h (union tui_which_element) <simple_string>:
2182         Remove.
2183         (struct tui_source_info): New.
2184         (struct tui_source_window_base) <execution_info>: Change type.
2185         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2186         case, and add assert.
2187         (tui_alloc_content): Add assert.
2188
2189 2019-06-25  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2192         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2193         * tui/tui-data.c (tui_alloc_win_info): Remove.
2194
2195 2019-06-25  Tom Tromey  <tom@tromey.com>
2196
2197         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2198         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2199         can_highlight.
2200
2201 2019-06-25  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2204         make_visible_with_new_height method.
2205         (tui_win_info::make_visible_with_new_height): New method.
2206         (tui_source_window_base::do_make_visible_with_new_height)
2207         (tui_data_window::do_make_visible_with_new_height)
2208         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2209         (make_visible_with_new_height): Remove.
2210         (tui_resize_all, tui_adjust_win_heights): Use
2211         make_visible_with_new_height method.
2212         * tui/tui-data.h (struct tui_win_info)
2213         <do_make_visible_with_new_height, make_visible_with_new_height>:
2214         New methods.
2215         (struct tui_source_window_base, struct tui_data_window)
2216         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2217         methods.
2218
2219 2019-06-25  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2222         method.
2223         (update_tab_width): Call update_tab_width method.
2224         * tui/tui-data.h (struct tui_win_info)
2225         (struct tui_source_window_base) <update_tab_width>: New methods.
2226
2227 2019-06-25  Tom Tromey  <tom@tromey.com>
2228
2229         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2230         parameter.
2231         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2232         parameter.
2233         (tui_gen_win_info::make_visible): Update.
2234         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2235         parameter.
2236         * tui/tui-data.h (enum tui_box): New enum.
2237         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2238
2239 2019-06-25  Tom Tromey  <tom@tromey.com>
2240
2241         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2242         init_and_make_win for EXEC_INFO_WIN.
2243         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2244         longer inline.
2245         (struct tui_win_info) <~tui_win_info>: Inline.
2246         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2247         Don't declare.
2248         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2249         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2250         Remove.
2251         (tui_initialize_static_data): Update.
2252         (~tui_gen_win_info): Handle more cleanup here.
2253         (~tui_source_window_base): Delete "execution_info".
2254         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2255
2256 2019-06-25  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-layout.c (make_command_window): Don't set
2259         can_highlight.
2260         (show_source_disasm_command): Call the reset method.
2261         (show_data): Don't set can_highlight.  Call the reset method.
2262         (tui_gen_win_info::reset): Rename from init_gen_win_info
2263         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2264         (show_source_or_disasm_and_command): Call the reset method.
2265         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2266         (struct tui_cmd_window): Set can_highlight.
2267
2268 2019-06-25  Tom Tromey  <tom@tromey.com>
2269
2270         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2271         from make_visible.
2272         (tui_make_visible, tui_make_invisible): Rewrite.
2273         (tui_win_info::make_visible): Remove.
2274         (tui_source_window_base::make_visible): Update.
2275         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2276         method.  Moved from...
2277         (struct tui_win_info) <make_visible>: ...here.
2278
2279 2019-06-25  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-winsource.c
2282         (tui_source_window_base::do_scroll_horizontal): Remove direction
2283         parameter.
2284         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2285         direction parameter.
2286         * tui/tui-win.c (tui_win_info::forward_scroll)
2287         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2288         (tui_win_info::right_scroll): Update.
2289         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2290         direction parameter.
2291         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2292         direction parameter.
2293         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2294         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2295         Remove direction parameter.
2296         (struct tui_source_window_base, struct tui_source_window)
2297         (struct tui_disasm_window, struct tui_data_window)
2298         (struct tui_cmd_window): Update.
2299
2300 2019-06-25  Tom Tromey  <tom@tromey.com>
2301
2302         * tui/tui-winsource.h (tui_set_exec_info_content)
2303         (tui_show_exec_info_content, tui_erase_exec_info_content)
2304         (tui_clear_exec_info_content, tui_update_exec_info): Change
2305         argument to tui_source_window_base.
2306         * tui/tui-winsource.c (tui_set_exec_info_content)
2307         (tui_show_exec_info_content, tui_erase_exec_info_content)
2308         (tui_clear_exec_info_content, tui_update_exec_info): Change
2309         argument to tui_source_window_base.
2310
2311 2019-06-25  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2314         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2315
2316 2019-06-25  Tom Tromey  <tom@tromey.com>
2317
2318         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2319         check.
2320
2321 2019-06-25  Tom Tromey  <tom@tromey.com>
2322
2323         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2324         type to void.
2325         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2326         type to void.
2327         * tui/tui-source.c (tui_set_source_content): Update.
2328         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2329
2330 2019-06-25  Tom Tromey  <tom@tromey.com>
2331
2332         * tui/tui-win.c (window_name_completer, tui_set_focus)
2333         (tui_all_windows_info): Use name method.
2334         * tui/tui-data.h (struct tui_gen_win_info)
2335         (struct tui_source_window, struct tui_disasm_window)
2336         (struct tui_data_window, struct tui_cmd_window) <name>: New
2337         method.
2338         (tui_win_name): Don't declare.
2339         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2340         (tui_win_name): Remove.
2341
2342 2019-06-25  Tom Tromey  <tom@tromey.com>
2343
2344         * tui/tui-winsource.h (tui_update_source_window)
2345         (tui_update_source_window_as_is): Change parameter type.
2346         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2347         to be a tui_source_window_base.
2348         (tui_update_source_window_as_is): Likewise.
2349         * tui/tui-win.c (make_visible_with_new_height): Update.
2350
2351 2019-06-25  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-winsource.c (tui_erase_source_content)
2354         (tui_show_source_content, tui_show_exec_info_content)
2355         (tui_erase_exec_info_content): Use refresh_window method.
2356         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2357         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2358         from tui_refresh_win.
2359         (tui_data_window::refresh_window): New method.
2360         (tui_win_info::refresh, tui_source_window_base::refresh)
2361         (tui_refresh_all): Use refresh_window method.
2362         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2363         method.
2364         * tui/tui-regs.c (tui_display_register): Call refresh_window
2365         method.
2366         * tui/tui-layout.c (show_source_disasm_command)
2367         (show_source_or_disasm_and_command): Call refresh_window method.
2368         * tui/tui-data.h (struct tui_gen_win_info)
2369         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2370         New method.
2371
2372 2019-06-25  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui.c (tui_rl_other_window, tui_enable)
2375         (tui_is_window_visible, tui_get_command_dimension): Update.
2376         * tui/tui-winsource.c (tui_update_source_window_as_is)
2377         (tui_clear_source_content, tui_erase_source_content)
2378         (tui_show_source_line, tui_source_window_base::refill)
2379         (tui_source_window_base::do_scroll_horizontal)
2380         (tui_source_window_base::set_is_exec_point_at)
2381         (tui_update_breakpoint_info, tui_set_exec_info_content)
2382         (tui_alloc_source_buffer, tui_line_is_displayed)
2383         (tui_addr_is_displayed): Update.
2384         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2385         (tui_check_and_display_highlight_if_needed)
2386         (tui_win_info::make_visible, tui_win_info::refresh)
2387         (tui_refresh_all): Update.
2388         * tui/tui-windata.c (tui_first_data_item_displayed)
2389         (tui_delete_data_content_windows, tui_erase_data_content)
2390         (tui_display_all_data, tui_data_window::refresh_all)
2391         (tui_check_data_values): Update.
2392         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2393         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2394         (tui_win_info::backward_scroll, tui_refresh_all_win)
2395         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2396         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2397         (tui_source_window_base::set_new_height)
2398         (tui_data_window::set_new_height)
2399         (make_invisible_and_set_new_height)
2400         (make_visible_with_new_height, new_height_ok)
2401         (parse_scrolling_args): Update.
2402         * tui/tui-stack.c (tui_show_frame_info): Update.
2403         * tui/tui-source.c (tui_set_source_content)
2404         (tui_set_source_content_nil, tui_source_is_displayed)
2405         (tui_source_window::do_scroll_vertical): Update.
2406         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2407         (tui_display_registers_from, tui_display_reg_element_at_line)
2408         (tui_check_register_values, tui_reg_command): Update.
2409         * tui/tui-layout.c (tui_default_win_height)
2410         (show_source_disasm_command, show_data, init_and_make_win)
2411         (show_source_or_disasm_and_command): Update.
2412         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2413         (tui_redisplay_readline, tui_mld_flush)
2414         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2415         (tui_getc): Update.
2416         * tui/tui-disasm.c (tui_set_disassem_content)
2417         (tui_disasm_window::do_scroll_vertical): Update.
2418         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2419         Now virtual.
2420         (struct tui_win_info): Derive from tui_gen_win_info.
2421         <~tui_win_info>: Mark as override.
2422         <generic>: Remove member.
2423         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2424         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2425         (~tui_data_window, ~tui_win_info)
2426         (tui_free_all_source_wins_content): Update.
2427         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2428
2429 2019-06-25  Tom Tromey  <tom@tromey.com>
2430
2431         * tui/tui-layout.c (init_and_make_win): Use new.
2432         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2433         destructor, initializers.
2434         (tui_alloc_generic_win_info): Don't declare.
2435         * tui/tui-data.c (_locator): Add argument to constructor.
2436         (source_win, disasm_win): New globals.
2437         (exec_info): Remove.
2438         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2439         Update.
2440         (tui_alloc_generic_win_info): Remove.
2441         (init_content_element): Use new.
2442         (tui_win_info::tui_win_info): Update.
2443         (free_content_elements) <case DATA_WIN>: Use delete.
2444
2445 2019-06-25  Tom Tromey  <tom@tromey.com>
2446
2447         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2448         * tui/tui-windata.c (tui_first_data_item_displayed)
2449         (tui_delete_data_content_windows): Update.
2450         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2451         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2452         (tui_display_registers_from, tui_check_register_values): Update.
2453         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2454         pointer.
2455         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2456         window.
2457         (tui_free_data_content): Update.
2458         (free_content_elements) <case DATA_WIN>: Free the window.
2459
2460 2019-06-25  Tom Tromey  <tom@tromey.com>
2461
2462         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2463         Update.
2464         * tui/tui-layout.c (make_command_window)
2465         (show_source_disasm_command, show_data, init_and_make_win)
2466         (show_source_or_disasm_and_command): Update.
2467         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2468         method.
2469         <can_highight, is_highlighted>: Now bool.
2470         (tui_set_win_highlight): Don't declare.
2471         * tui/tui-data.c (tui_set_win_highlight): Remove.
2472
2473 2019-06-25  Tom Tromey  <tom@tromey.com>
2474
2475         * tui/tui-wingeneral.c (make_visible): Remove check of window
2476         type.
2477
2478 2019-06-25  Tom Tromey  <tom@tromey.com>
2479
2480         * tui/tui-win.c (tui_win_info::max_height)
2481         (tui_cmd_window::max_height): New methods.
2482         (new_height_ok): Call max_height.
2483         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2484         <max_height>: New method.
2485
2486 2019-06-25  Tom Tromey  <tom@tromey.com>
2487
2488         * tui/tui-win.c (tui_source_window_base::set_new_height)
2489         (tui_data_window::set_new_height): New methods.
2490         (make_invisible_and_set_new_height): Call set_new_height method.
2491         * tui/tui-data.h (struct tui_win_info)
2492         (struct tui_source_window_base, struct tui_data_window)
2493         <set_new_height>: New method.
2494
2495 2019-06-25  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2498         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2499         tui_refresh_data_win.
2500         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2501         method.
2502         (tui_refresh_all_win): Call the refresh_all method.
2503         (tui_set_focus): Likewise.
2504         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2505         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2506         Likewise.
2507
2508 2019-06-25  Tom Tromey  <tom@tromey.com>
2509
2510         * tui/tui-winsource.h (tui_refill_source_window)
2511         (tui_set_is_exec_point_at): Don't declare.
2512         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2513         (tui_source_window_base::refill): Rename from
2514         tui_refill_source_window.
2515         (tui_source_window_base::do_scroll_horizontal): Update.
2516         (tui_source_window_base::set_is_exec_point_at): Rename from
2517         tui_set_is_exec_point_at.
2518         (tui_update_all_breakpoint_info): Update.
2519         * tui/tui-stack.c (tui_show_frame_info): Update.
2520         * tui/tui-layout.c (show_data): Add cast.
2521         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2522         * tui/tui-data.h (struct tui_source_window_base) <refill,
2523         set_is_exec_point_at>: New methods.
2524         (tui_source_windows, tui_add_to_source_windows): Update types.
2525         (tui_add_to_source_windows): Remove redundant declaration.
2526         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2527         (tui_source_windows): Change return type.
2528         (tui_clear_source_windows_detail): Update.
2529         (tui_add_to_source_windows): Change type of parameter.
2530         (tui_free_all_source_wins_content): Update.
2531
2532 2019-06-25  Tom Tromey  <tom@tromey.com>
2533
2534         * tui/tui-wingeneral.c (tui_win_info::refresh)
2535         (tui_source_window_base::refresh): New methods.
2536         (tui_refresh_all): Call the refresh method.
2537         * tui/tui-data.h (struct tui_win_info)
2538         (struct tui_source_window_base) <refresh>: New method.
2539
2540 2019-06-25  Tom Tromey  <tom@tromey.com>
2541
2542         * tui/tui.h (tui_is_window_visible): Return bool.
2543         * tui/tui.c (tui_is_window_visible): Return bool.
2544         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2545         (tui_make_visible, tui_make_invisible)
2546         (tui_win_info::make_visible)
2547         (tui_source_window_base::make_visible, make_all_visible)
2548         (tui_make_all_visible, tui_make_all_invisible): Update.
2549         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2550         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2551         bool.
2552         (struct tui_win_info, struct tui_source_window_base)
2553         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2554         * tui/tui-data.c (tui_init_generic_part): Update.
2555
2556 2019-06-25  Tom Tromey  <tom@tromey.com>
2557
2558         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2559         (tui_source_window_base::make_visible): New methods.
2560         (make_all_visible): Make method call.
2561         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2562         (struct tui_source_window_base, struct tui_cmd_window): Override
2563         make_visible.
2564         (tui_win_is_source_type): Don't declare.
2565         * tui/tui-data.c (tui_win_is_source_type): Remove.
2566
2567 2019-06-25  Tom Tromey  <tom@tromey.com>
2568
2569         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2570         NULL check.
2571
2572 2019-06-25  Tom Tromey  <tom@tromey.com>
2573
2574         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2575         Inline constructor.  Add initializers for members.
2576         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2577         constructors; now inline in class.
2578
2579 2019-06-25  Tom Tromey  <tom@tromey.com>
2580
2581         * tui/tui-regs.c (tui_show_registers): Update.
2582         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2583         bool.
2584         * tui/tui-data.c (tui_data_window::clear_detail)
2585         (tui_data_window): Update.
2586
2587 2019-06-25  Tom Tromey  <tom@tromey.com>
2588
2589         * tui/tui-windata.c (tui_display_all_data)
2590         (tui_display_data_from_line, tui_display_data_from)
2591         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2592         Update.
2593         * tui/tui-regs.c (tui_last_regs_line_no)
2594         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2595         (tui_show_registers, tui_show_register_group)
2596         (tui_display_registers_from, tui_display_reg_element_at_line)
2597         (tui_display_registers_from_line, tui_check_register_values)
2598         (tui_reg_next, tui_reg_prev): Update.
2599         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2600         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2601         tui_data_window.
2602         (struct tui_win_info) <detail>: Remove.  Add new fields from
2603         tui_data_info.
2604         (TUI_DATA_WIN): Add cast.
2605         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2606         (~tui_data_window): Simplify.
2607
2608 2019-06-25  Tom Tromey  <tom@tromey.com>
2609
2610         * tui/tui-layout.c (show_source_disasm_command)
2611         (show_source_or_disasm_and_command): Update.
2612         * tui/tui-io.c (update_cmdwin_start_line)
2613         (tui_redisplay_readline): Update.
2614         * tui/tui-data.h (struct tui_command_info): Remove.
2615         (struct tui_win_info) <detail>: Remove command_info member.
2616         (struct tui_data_window) <start_line>: New member, from
2617         tui_command_info.
2618         (TUI_CMD_WIN): Add casts.
2619
2620 2019-06-25  Tom Tromey  <tom@tromey.com>
2621
2622         * tui/tui-winsource.c (tui_update_source_window)
2623         (tui_refill_source_window)
2624         (tui_source_window_base::do_scroll_horizontal)
2625         (tui_update_breakpoint_info, tui_set_exec_info_content)
2626         (tui_show_exec_info_content, tui_erase_exec_info_content)
2627         (tui_clear_exec_info_content): Update.
2628         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2629         Update.
2630         * tui/tui-win.c (make_invisible_and_set_new_height)
2631         (make_visible_with_new_height): Update.
2632         * tui/tui-source.c (tui_set_source_content)
2633         (tui_show_symtab_source): Update.
2634         * tui/tui-layout.c (extract_display_start_addr)
2635         (show_source_disasm_command, show_data)
2636         (make_source_or_disasm_window)
2637         (show_source_or_disasm_and_command): Update.
2638         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2639         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2640         "gdbarch".
2641         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2642         to tui_source_window_base.
2643         (struct tui_win_info) <detail>: Remove source_info member.
2644         (struct tui_source_window_base) <has_locator>: Inline.
2645         Move contents from tui_source_info; rename has_locator member to
2646         m_has_locator.
2647         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2648         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2649         header file.
2650         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2651         Simplify.
2652         (tui_free_all_source_wins_content): Cast to
2653         tui_source_window_base.
2654
2655 2019-06-25  Tom Tromey  <tom@tromey.com>
2656
2657         * tui/tui-win.c (make_invisible_and_set_new_height)
2658         (make_visible_with_new_height): Call has_locator method.
2659         * tui/tui-layout.c (show_source_disasm_command, show_data)
2660         (show_source_or_disasm_and_command): Update for bool change.
2661         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2662         (tui_win_info) <has_locator>: New method.
2663         (struct tui_source_window_base) <has_locator>: New method.
2664         (tui_win_has_locator): Don't declare.
2665         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2666         from tui_win_has_locator.
2667         (tui_source_window_base): Use false, not FALSE.
2668
2669 2019-06-25  Tom Tromey  <tom@tromey.com>
2670
2671         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2672         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2673         clear_detail method directly.
2674         (tui_clear_win_detail): Remove.
2675
2676 2019-06-25  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2679         "this", not TUI_DISASM_WIN.
2680
2681 2019-06-25  Tom Tromey  <tom@tromey.com>
2682
2683         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2684         declare.
2685         * tui/tui-winsource.c
2686         (tui_source_window_base::do_scroll_horizontal): Rename from
2687         tui_horizontal_source_scroll.
2688         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2689         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2690         from tui_vertical_data_scroll.
2691         * tui/tui-win.h (tui_scroll): Don't declare.
2692         * tui/tui-win.c (tui_win_info::forward_scroll)
2693         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2694         (tui_win_info::right_scroll): Rename and update.
2695         (tui_scroll_forward_command, tui_scroll_backward_command)
2696         (tui_scroll_left_command, tui_scroll_right_command): Update.
2697         (tui_scroll): Remove.
2698         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2699         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2700         from tui_vertical_source_scroll.
2701         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2702         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2703         from tui_vertical_disassem_scroll.
2704         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2705         do_scroll_horizontal>: New methods.
2706         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2707         Likewise.
2708         (struct tui_source_window_base): Add do_scroll_horizontal.
2709         (struct tui_source_window, struct tui_disasm_window): Add
2710         do_scroll_vertical.
2711         (struct tui_data_window, struct tui_cmd_window): Add
2712         do_scroll_horizontal and do_scroll_vertical.
2713         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2714
2715 2019-06-25  Tom Tromey  <tom@tromey.com>
2716
2717         * tui/tui-data.h (struct tui_source_window_base): New struct.
2718         (struct tui_source_window): Derive from tui_source_window_base.
2719         (struct tui_disasm_window): New struct.
2720         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2721         from tui_source_window::clear_detail.
2722         (tui_source_window_base): Rename from tui_source_window.
2723         (~tui_source_window_base): Rename from ~tui_source_window.
2724         (tui_alloc_win_info): Create a tui_disasm_window.
2725
2726 2019-06-25  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-data.h (struct tui_source_window)
2729         (struct tui_data_window): Declare destructors.
2730         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2731         destructors.
2732         (tui_win_info): Simplify.
2733
2734 2019-06-25  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-winsource.c (tui_display_main)
2737         (tui_update_source_windows_with_addr)
2738         (tui_update_all_breakpoint_info): Update.
2739         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2740         (new_height_ok, parse_scrolling_args): Update.
2741         * tui/tui-stack.c (tui_show_frame_info): Update.
2742         * tui/tui-data.h (struct tui_list): Remove.
2743         (tui_source_windows): Return a reference to a std::vector.
2744         * tui/tui-data.c (source_windows): Now a std::vector.
2745         (tui_source_windows): Change return type.
2746         (tui_clear_source_windows): Rewrite.
2747         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2748         (tui_free_all_source_wins_content): Rewrite.
2749
2750 2019-06-25  Tom Tromey  <tom@tromey.com>
2751
2752         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2753         (struct tui_data_window, struct tui_cmd_window): Declare
2754         clear_detail method.
2755         * tui/tui-data.c (tui_source_window::clear_detail)
2756         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2757         methods.
2758         (tui_clear_win_detail): Simplify.
2759
2760 2019-06-25  Tom Tromey  <tom@tromey.com>
2761
2762         * tui/tui-layout.c (make_source_window, make_disasm_window)
2763         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2764         Return the new window.
2765         (show_source_disasm_command, show_data)
2766         (show_source_or_disasm_and_command): Update.
2767
2768 2019-06-25  Tom Tromey  <tom@tromey.com>
2769
2770         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2771         parameter.  Return the new window.
2772         (show_source_disasm_command): Update and remove NULL check.
2773         (show_source_or_disasm_and_command): Update.
2774
2775 2019-06-25  Tom Tromey  <tom@tromey.com>
2776
2777         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2778
2779 2019-06-25  Tom Tromey  <tom@tromey.com>
2780
2781         * tui/tui-data.h (struct tui_win_info): Make constructor
2782         protected.  Make destructor virtual.  Add initializers.
2783         (tui_source_window, tui_data_window, tui_cmd_window): New
2784         classes.
2785         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2786         constructor.  Add "type" parameter.
2787         (tui_source_window, tui_data_window, tui_cmd_window): New
2788         constructors.
2789         (tui_alloc_win_info): Instantiate the appropriate subclass.
2790
2791 2019-06-25  Tom Tromey  <tom@tromey.com>
2792
2793         * tui/tui-win.c (tui_resize_all): Use delete.
2794         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2795         destructor.
2796         (tui_free_window): Don't declare.
2797         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2798         Update.
2799
2800 2019-06-25  Tom Tromey  <tom@tromey.com>
2801
2802         * tui/tui-data.h (struct tui_win_info): Add constructor.
2803         * tui/tui-data.c (tui_alloc_win_info): Use new.
2804         (tui_free_window): Use delete.
2805
2806 2019-06-22  Tom Tromey  <tom@tromey.com>
2807
2808         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2809         declare.
2810         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2811
2812 2019-06-22  Tom Tromey  <tom@tromey.com>
2813
2814         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2815         declare.
2816         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2817
2818 2019-06-22  Tom de Vries  <tdevries@suse.de>
2819
2820         * dwarf2read.c (create_addrmap_from_aranges)
2821         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2822         instead of '%zu'.
2823
2824 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2825
2826         * dwarf2read.h (dwarf2_section_info_def): Remove.
2827         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2828         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2829         std::vector<dwarf2_section_info>.
2830         (struct dwo_file) <~dwo_file>: Remove.
2831         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2832         types field.
2833         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2834         (dwarf2_read_debug_names): Likewise.
2835         (create_debug_types_hash_table): Change parameter type to
2836         array_view, adjust code accordingly.
2837         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2838         (partial_die_info::fixup): Likewise.
2839         (determine_prefix): Likewise.
2840         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2841
2842 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2843
2844         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2845         gdb_bfd_ref_ptr.
2846         <~dwo_file>: Remove call to gdb_bfd_unref.
2847         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2848         gdb_bfd_ref_ptr::get.
2849
2850 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2851
2852         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2853         type to htab_up.
2854         * dwarf2read.c (struct dwo_file): Initialize fields.
2855         <~dwo_file>: New.
2856         (free_dwo_file): Remove, move content to ~dwo_file.
2857         (struct dwo_file_deleter): Remove.
2858         (dwo_file_up>: Remove custom deleter.
2859         (free_dwo_files): Remove.
2860         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2861         dwo_files.
2862         (process_skeletonless_type_units): Call unique_ptr::get.
2863         (allocate_dwo_file_hash_table): Add deleter to created hash
2864         table.  Change return type to htab_up.
2865         (lookup_dwo_file_slot): Don't memset dwo_file, call
2866         unique_ptr::get.
2867         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2868         (create_dwo_unit_in_dwp_v2): Likewise.
2869         (open_and_init_dwo_file): Likewise.
2870         (free_dwo_file_from_slot): Remove.
2871
2872 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2873
2874         * dwarf2read.h (struct dwarf2_section_info) <readin,
2875         is_virtual>: Change type to bool.
2876         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2877         true instead of 1.
2878
2879 2019-06-19  Tom Tromey  <tom@tromey.com>
2880
2881         * tui/tui-data.h (tui_init_content_element): Don't declare.
2882
2883 2019-06-19  Tom Tromey  <tom@tromey.com>
2884
2885         * tui/tui-data.h (tui_init_win_info): Don't declare.
2886
2887 2019-06-19  Tom de Vries  <tdevries@suse.de>
2888
2889         * dwarf2read.h (abstract_to_concrete): Change type to
2890         std::unordered_map<sect_offset, std::vector<sect_offset>,
2891         gdb::hash_enum<sect_offset>>.
2892
2893 2019-06-19  Tom Tromey  <tromey@adacore.com>
2894
2895         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2896         EVAL_AVOID_SIDE_EFFECTS specially.
2897
2898 2019-06-19  Tom Tromey  <tromey@adacore.com>
2899
2900         * source-cache.c (highlighter): New global.
2901         (source_cache::get_source_lines): Create a highlighter on demand.
2902
2903 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2904
2905         * defs.h (deprecated_interactive_hook): Delete declaration.
2906         * interps.c (clear_interpreter_hooks): Remove use of
2907         deprecated_interactive_hook.
2908         * top.c (deprecated_interactive_hook): Delete definition.
2909         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2910
2911 2019-06-18  Tom de Vries  <tdevries@suse.de>
2912
2913         PR gdb/24515
2914         * dwarf2read.h (abstract_to_concrete): Change type from
2915         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2916         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2917         * dwarf2read.c (read_variable): Update.
2918         (dwarf2_fetch_die_loc_sect_off): Update.
2919
2920 2019-06-17  Tom de Vries  <tdevries@suse.de>
2921
2922         PR gdb/24617
2923         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2924         accessing parent[parent_len - 1].
2925
2926 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2927
2928         PR gdb/24364
2929         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2930         call dtrace_process_dof with NULL dof.
2931
2932 2019-06-16  Tom de Vries  <tdevries@suse.de>
2933
2934         PR gdb/24445
2935         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2936
2937 2019-06-16  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2940         (make_all_visible): Use address of member.
2941
2942 2019-06-16  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2945         (tui_free_window, free_content, free_content_elements): Remove
2946         unnecessary cast.
2947         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2948         cast.
2949         * tui/tui-regs.c (tui_show_register_group)
2950         (tui_display_registers_from, tui_display_reg_element_at_line):
2951         Remove unnecessary cast.
2952
2953 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2954
2955         * linux-nat.c (normal_mask): Delete.
2956         (_initialize_linux_nat): Don't initialise normal_mask.
2957
2958 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2959
2960         PR gdb/24445
2961         * dwarf-index-write.h (write_psymtabs_to_index): Add
2962         dwz_basename parameter.
2963         * dwarf-index-write.c (write_gdbindex): Move file writing to
2964         write_gdbindex_1.  Change return type void.
2965         (assert_file_size): Move up, remove filename parameter.
2966         (write_gdbindex_1): New function.
2967         (write_debug_names): Change return type to void, call
2968         assert_file_size.
2969         (struct index_wip_file): New struct.
2970         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2971         file logic to index_wip_file.  Write index for dwz file if
2972         needed.
2973         (save_gdb_index_command): Pass basename of dwz file, if present.
2974         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2975         build-id of dwz file, if present.
2976         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2977         (dwarf2_get_dwz_file): Likewise.
2978         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2979         (dwarf2_get_dwz_file): Likewise.
2980
2981 2019-06-16  Tom Tromey  <tom@tromey.com>
2982
2983         * coffread.c (process_coff_symbol): Use xstrdup.
2984         * value.c (create_internalvar): Use xstrdup.
2985
2986 2019-06-16  Tom Tromey  <tom@tromey.com>
2987
2988         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2989         * breakpoint.c (stopin_command, stopat_command)
2990         (until_break_command, decode_location_default): Remove unnecessary
2991         cast.
2992         * utils.c (subset_compare): Remove unnecessary cast.
2993         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2994         cast.
2995         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2996         cast.
2997         * infcmd.c (path_command): Remove unnecessary cast.
2998         * coffread.c (decode_type): Remove unnecessary cast.
2999         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3000         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3001         * tui/tui-stack.c (tui_show_locator_content)
3002         (tui_show_frame_info): Remove unnecessary cast.
3003         * tui/tui-win.c (tui_scroll_forward_command)
3004         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3005         (parse_scrolling_args): Remove unnecessary cast.
3006         * tui/tui-data.c (init_win_info, tui_del_window)
3007         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3008         (free_content_elements): Remove unnecessary cast.
3009         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3010         unnecessary cast.
3011         * tui/tui-source.c (tui_set_source_content)
3012         (tui_vertical_source_scroll): Remove unnecessary cast.
3013         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3014         cast.
3015         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3016         * tui/tui-regs.c (tui_display_registers_from)
3017         (tui_display_register): Remove unnecessary cast.
3018         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3019         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3020         (make_visible): Remove unnecessary cast.
3021         * tui/tui-winsource.c (tui_erase_source_content)
3022         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3023         unnecessary cast.
3024         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3025         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3026         * stabsread.c (read_type, read_array_type, read_range_type):
3027         Remove unnecessary cast.
3028         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3029         (parse_symbol, parse_type, upgrade_type, parse_external)
3030         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3031         unnecessary cast.
3032         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3033
3034 2019-06-16  Tom Tromey  <tom@tromey.com>
3035
3036         * tui/tui-data.c (tui_alloc_generic_win_info)
3037         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3038         checks.
3039
3040 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3041             Andrew Burgess  <andrew.burgess@embecosm.com>
3042
3043         * f-typeprint.c (f_print_type): Don't return early for not
3044         associated or not allocated types.
3045         (f_type_print_varspec_suffix): Add print_rank parameter and print
3046         ranks of array types in case they dangling.
3047         (f_type_print_base): Add print_rank parameter.
3048
3049 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3050
3051         * NEWS: Mention new MI commands.
3052         * break-catch-throw.c (enum exception_event_kind): Move to
3053         breakpoint.h.
3054         (print_mention_exception_catchpoint): Output text as a single
3055         message.
3056         (catch_exception_command_1): Rename to...
3057         (catch_exception_event): ...this, make non-static, update header
3058         command, and change some parameter types.
3059         (catch_catch_command): Update for changes to
3060         catch_exception_command_1.
3061         (catch_throw_command): Likewise.
3062         (catch_rethrow_command): Likewise.
3063         * breakpoint.c (enum exception_event_kind): Delete.
3064         * breakpoint.h (enum exception_event_kind): Moved here from
3065         break-catch-throw.c.
3066         (catch_exception_event): Declare.
3067         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3068         (mi_cmd_catch_throw): New function.
3069         (mi_cmd_catch_rethrow): New function.
3070         (mi_cmd_catch_catch): New function.
3071         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3072         'catch-catch' entries.
3073         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3074         (mi_cmd_catch_rethrow): Declare.
3075         (mi_cmd_catch_catch): Declare.
3076
3077 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3078
3079         * annotate.c (annotate_source_line): Change return type to void,
3080         update implementation to match.
3081         * annotate.h (annotate_source_line): Change return type to void,
3082         update header comment.
3083         * stack.c (print_frame_info): Don't change what frame information
3084         is printed based on whether annotations are on or not.
3085
3086 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3087
3088         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3089         (annotate_source): Make static.
3090         (annotate_source_line): Moved from source.c and renamed from
3091         identify_source_line.  Update the return type.
3092         * annotate.h (annotate_source): Delete declaration.
3093         (annotate_source_line): Declaration moved from source.h, and
3094         renamed from identify_source_line.  Return type updated.
3095         * source.c (identify_source_line): Moved to annotate.c and renamed
3096         to annotate_source_line.
3097         (info_line_command): Remove check of annotation_level.
3098         * source.h (identify_source_line): Move declaration to annotate.h
3099         and rename to annotate_source_line.
3100         * stack.c: Add 'annotate.h' include.
3101         (print_frame_info): Remove check of annotation_level before
3102         calling annotate_source_line.
3103
3104 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3105
3106         * source-cache.c (source_cache::get_plain_source_lines): Use
3107         open_source_file_with_line_charpos instead of just
3108         open_source_file, remove call to find_source_lines.
3109         (source_cache::get_source_lines): Likewise.
3110         * source.c (find_source_lines): Make static.
3111         (get_filename_and_charpos): Renamed into...
3112         (open_source_file_with_line_charpos): ..this along with changes to
3113         return a scoped_fd, and some other minor clean ups.
3114         (identify_source_line): Use open_source_file_with_line_charpos.
3115         (search_command_helper): Use open_source_file_with_line_charpos
3116         instead of just open_source_file, remove call to
3117         find_source_lines.
3118         * source.h (open_source_file_with_line_charpos): Declare new
3119         function.
3120         (find_source_lines): Delete declaration.
3121
3122 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3123
3124         * source.c (get_filename_and_charpos): Remove fullname
3125         parameter.
3126         (identify_source_line): Update call to get_filename_and_charpos.
3127
3128 2019-06-14  Tom Tromey  <tromey@adacore.com>
3129
3130         PR gdb/24502:
3131         * ui-style.h (skip_ansi_escape): Update comment.
3132         * ui-file.h (class no_terminal_escape_file): New class.
3133         * ui-file.c (no_terminal_escape_file::write)
3134         (no_terminal_escape_file::puts): New methods.
3135         * cli/cli-logging.c (handle_redirections): Use
3136         no_terminal_escape_file.
3137
3138 2019-06-14  Tom Tromey  <tromey@adacore.com>
3139
3140         * NEWS: Move convenience variable news above Python news.
3141
3142 2019-06-14  Tom Tromey  <tom@tromey.com>
3143
3144         * gnulib: Move directory to top-level.
3145         * configure.ac: Don't configure gnulib.
3146         * configure: Rebuild.
3147         * common/common-defs.h: Use new path to gnulib.
3148         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3149         (GNULIB_H): Remove.
3150         (INCGNU): Look in new gnulib location.
3151         (HFILES_NO_SRCDIR): Remove gnulib files.
3152         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3153         (generated_files): Remove GNULIB_H.
3154         ($(LIBGNU), all-lib): Remove targets.
3155         (distclean): Don't mention GNULIB_BUILDDIR.
3156         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3157
3158 2019-06-14  Tom Tromey  <tromey@adacore.com>
3159
3160         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3161         Warn if symbol file does not provide any symbols.
3162
3163 2019-06-14  Tom Tromey  <tromey@adacore.com>
3164
3165         * source.c (find_and_open_source): Respect basenames_may_differ.
3166
3167 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3168
3169         * annotate.c (annotate_breakpoints_invalid): Make use of
3170         scoped_restore_terminal_state.
3171         (annotate_frames_invalid): Likewise.
3172
3173 2019-06-14  Tom Tromey  <tromey@adacore.com>
3174
3175         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3176         allow assignment to an internalvar.
3177
3178 2019-06-14  Tom Tromey  <tromey@adacore.com>
3179
3180         * ada-lex.l: Allow "_" in attribute names.
3181
3182 2019-06-14  Tom Tromey  <tromey@adacore.com>
3183
3184         PR gdb/24653:
3185         * regcache.c (registers_changed): Don't call alloca.
3186         * top.c (execute_command): Don't call alloca.
3187
3188 2019-06-13  Pedro Alves  <palves@redhat.com>
3189
3190         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3191         'expression'.  When parsing an expression, error out if there's
3192         junk after "unlimited".
3193         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3194         (do_set_command): Adjust calls to is_unlimited_literal.
3195
3196 2019-06-13  Pedro Alves  <palves@redhat.com>
3197
3198         * compile/compile.c (make_compile_options_def_group): Add braces
3199         around array_view initializer.
3200         * thread.c (make_thread_apply_all_options_def_group)
3201         (make_thread_apply_all_options_def_group): Likewise.
3202
3203 2019-06-13  Pedro Alves  <palves@redhat.com>
3204
3205         * NEWS (New commands): Mention "maint test-options
3206         require-delimiter", "maint test-options unknown-is-error", "maint
3207         test-options unknown-is-operand" and "maint show
3208         test-options-completion-result".
3209         (New command options, command completion): New section.
3210         (Completion improvements): New section.
3211         Mention that you can abbreviate "unlimited".
3212
3213 2019-06-13  Pedro Alves  <palves@redhat.com>
3214
3215         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3216         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3217         * unittests/cli-utils-selftests.c (test_parse_flags)
3218         (test_parse_flags_qcs): Delete.
3219         (test_cli_utils): Don't call deleted functions.
3220
3221 2019-06-13  Pedro Alves  <palves@redhat.com>
3222
3223         * thread.c: Include "cli/cli-option.h".
3224         (tp_array_compar_ascending): Global.
3225         (tp_array_compar): Delete function.
3226         (tp_array_compar_ascending, tp_array_compar_descending): New
3227         functions.
3228         (ascending_option_def, qcs_flag_option_def)
3229         (thr_qcs_flags_option_defs)
3230         (make_thread_apply_all_options_def_group)
3231         (make_thread_apply_options_def_group): New.
3232         (thread_apply_all_command): Use gdb::option::process_options.
3233         (thread_apply_command_completer)
3234         (thread_apply_all_command_completer): New.
3235         (thread_apply_command): Use gdb::option::process_options.
3236         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3237         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3238         to generate help text of "thread apply".  Adjust "taas"'s help.
3239         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3240         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3241
3242 2019-06-13  Pedro Alves  <palves@redhat.com>
3243
3244         * thread.c (thread_apply_command): Check for invalid TID with
3245         isdigit instead of !isalpha.
3246
3247 2019-06-13  Pedro Alves  <palves@redhat.com>
3248
3249         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3250         (validate_flags_qcs): New.
3251         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3252         (validate_flags_qcs): Declare.
3253         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3254         (make_frame_apply_options_def_group): New.
3255         (frame_apply_command_count): Process options with
3256         gdb::option::process_options.
3257         (frame_apply_completer): New.
3258         (frame_apply_level_completer, frame_apply_all_completer)
3259         (frame_apply_completer): New.
3260         (_initialize_stack): Update help of "frame apply", "frame apply
3261         level", "frame apply all" and "faas" to mention supported options
3262         and install command completers.
3263         * stack.h (frame_apply_all_completer): Declare.
3264         * thread.c: Include "stack.h".
3265         (tfaas_command): Add "--".
3266         (_initialize_thread): Update help "tfaas" to mention supported
3267         options and install command completer.
3268
3269 2019-06-13  Pedro Alves  <palves@redhat.com>
3270
3271         * completer.c (complete_nested_command_line): New.
3272         (gdb_completion_word_break_characters_throw): Add assertion.
3273         * completer.h (complete_nested_command_line): Declare.
3274
3275 2019-06-13  Pedro Alves  <palves@redhat.com>
3276
3277         * stack.c (parse_backtrace_qualifiers): New.
3278         (backtrace_command): Use it.
3279         (backtrace_command_completer): Complete on qualifiers.
3280
3281 2019-06-13  Pedro Alves  <palves@redhat.com>
3282
3283         * frame.c: Include "cli/cli-option.h.
3284         (user_set_backtrace_options): New.
3285         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3286         Delete.
3287         (get_prev_frame): Adjust.
3288         (boolean_option_def, uinteger_option_def)
3289         (set_backtrace_option_defs): New.
3290         (_initialize_frame): Adjust and use
3291         gdb::option::add_setshow_cmds_for_options to install "set
3292         backtrace past-main" and "set backtrace past-entry".
3293         * frame.h: Include "cli/cli-option.h".
3294         (struct frame_print_options): Forward declare.
3295         (print_frame_arguments_all, print_frame_arguments_scalars)
3296         (print_frame_arguments_none): Declare.
3297         (print_entry_values): Delete declaration.
3298         (struct frame_print_options, user_frame_print_options): New.
3299         (struct set_backtrace_options): New.
3300         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3301         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3302         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3303         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3304         (list_args_or_locals): Add frame_print_options parameter.
3305         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3306         * python/py-framefilter.c (enumerate_args): Pass down
3307         USER_FRAME_PRINT_OPTIONS.
3308         * stack.c: Include "cli/cli-option.h".
3309         (print_frame_arguments_all, print_frame_arguments_scalars)
3310         (print_frame_arguments_none): Declare.
3311         (print_raw_frame_arguments, print_entry_values): Delete.
3312         (user_frame_print_options): New.
3313         (boolean_option_def, enum_option_def, frame_print_option_defs):
3314         New.
3315         (struct backtrace_cmd_options): New.
3316         (bt_flag_option_def): New.
3317         (backtrace_command_option_defs): New.
3318         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3319         (print_frame_arg, read_frame_arg, print_frame_args)
3320         (print_frame_info, print_frame): Add frame_print_options parameter
3321         and use it.
3322         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3323         (backtrace_command_1): Add frame_print_options and
3324         backtrace_cmd_options parameters and use them.
3325         (make_backtrace_options_def_group): New.
3326         (backtrace_command): Process command options with
3327         gdb::option::process_options.
3328         (backtrace_command_completer): New.
3329         (_initialize_stack): Extend "backtrace"'s help to mention
3330         supported options.  Install completer for "backtrace".
3331         Install some settings commands with add_setshow_cmds_for_options.
3332
3333 2019-06-13  Pedro Alves  <palves@redhat.com>
3334
3335         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3336         and that "set/show print raw frame-arguments" are now deprecated.
3337
3338         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3339         command.
3340         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3341         * stack.c (_initialize_stack): Install "set/show print
3342         raw-frame-arguments", and deprecate "set/show print raw
3343         frame-arguments".
3344         * valprint.c (_initialize_valprint): Deprecate "set/show print
3345         raw".
3346
3347 2019-06-13  Pedro Alves  <palves@redhat.com>
3348
3349         * compile/compile.c (struct compile_options): New.
3350         (compile_flag_option_def, compile_command_option_defs)
3351         (make_compile_options_def_group): New.
3352         (compile_file_command): Handle options with
3353         gdb::option::process_options.
3354         (compile_file_command_completer): New function.
3355         (compile_code_command): Handle options with
3356         gdb::option::process_options.
3357         (compile_code_command_completer): New function.
3358         (_initialize_compiler): Install completers for "compile code" and
3359         "compile file".  Mention available options in "compile code" and
3360         "compile code"'s help.
3361         * completer.c (advance_to_completion_word): New, factored out from
3362         ...
3363         (advance_to_expression_complete_word_point): ... this.
3364         (advance_to_filename_complete_word_point): New.
3365         * completer.h (advance_to_filename_complete_word_point): New
3366         declaration.
3367
3368 2019-06-13  Pedro Alves  <palves@redhat.com>
3369
3370         * compile/compile.c: Include "cli/cli-option.h".
3371         (compile_print_value): Scope data pointer is now a
3372         value_print_options pointer; adjust.
3373         (compile_print_command): Process options.  Scope data pointer is
3374         now a value_print_options pointer; adjust.
3375         (_initialize_compile): Update "compile print"'s help to include
3376         supported options.  Install a completer for "compile print".
3377         * cp-valprint.c (show_vtblprint, show_objectprint)
3378         (show_static_field_print): Delete.
3379         (_initialize_cp_valprint): Don't install "set print
3380         static-members", "set print vtbl", "set print object" here.
3381         * printcmd.c: Include "cli/cli-option.h" and
3382         "common/gdb_optional.h".
3383         (print_command_parse_format): Rework to fill in a
3384         value_print_options instead of a format_data.
3385         (print_value): Change parameter type from format_data pointer to
3386         value_print_options reference.  Adjust.
3387         (print_command_1): Process options.  Adjust to pass down a
3388         value_print_options.
3389         (print_command_completer): New.
3390         (_initialize_printcmd): Install print_command_completer as
3391         handle_brkchars completer for the "print" command.  Update
3392         "print"'s help to include supported options.
3393         * valprint.c: Include "cli/cli-option.h".
3394         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3395         here from cp-valprint.c.
3396         (boolean_option_def, uinteger_option_def)
3397         (value_print_option_defs, make_value_print_options_def_group):
3398         New.  Use gdb::option::add_setshow_cmds_for_options to install
3399         "set print elements", "set print null-stop", "set print repeats",
3400         "set print pretty", "set print union", "set print array", "set
3401         print address", "set print symbol", "set print array-indexes".
3402         * valprint.h: Include <string> and "cli/cli-option.h".
3403         (make_value_print_options_def_group): Declare.
3404         (print_value): Change parameter type from format_data pointer to
3405         value_print_options reference.
3406         (print_command_completer): Declare.
3407
3408 2019-06-13  Pedro Alves  <palves@redhat.com>
3409
3410         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3411         (COMMON_SFILES): Add maint-test-settings.c.
3412         * cli/cli-decode.c (boolean_enums): New global, factored out from
3413         ...
3414         (add_setshow_boolean_cmd): ... here.
3415         * cli/cli-decode.h (boolean_enums): Declare.
3416         * cli/cli-option.c: New file.
3417         * cli/cli-option.h: New file.
3418         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3419         factored out from ...
3420         (parse_cli_boolean_value(const char *)): ... this.
3421         (is_unlimited_literal): Change parameter type to pointer to
3422         pointer.  Adjust and advance ARG pointer.
3423         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3424         (parse_cli_var_enum): New, factored out from ...
3425         (do_set_command): ... this.  Adjust.
3426         * cli/cli-setshow.h (parse_cli_boolean_value)
3427         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3428         (parse_cli_var_enum): Declare.
3429         * cli/cli-utils.c: Include "cli/cli-option.h".
3430         (get_ulongest): New.
3431         * cli/cli-utils.h (get_ulongest): Declare.
3432         (check_for_argument): New overloads.
3433         * maint-test-options.c: New file.
3434
3435 2019-06-13  Pedro Alves  <palves@redhat.com>
3436
3437         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3438         parse a range if "-" is at the end of the string.
3439
3440 2019-06-13  Pedro Alves  <palves@redhat.com>
3441
3442         * cli/cli-setshow.c (parse_auto_binary_operation)
3443         (parse_cli_boolean_value): Don't allow "o".
3444
3445 2019-06-13  Pedro Alves  <palves@redhat.com>
3446
3447         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3448         * NEWS: Mention maint test-settings KIND.
3449         * maint-test-settings.c: New file.
3450
3451 2019-06-13  Pedro Alves  <palves@redhat.com>
3452
3453         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3454         completer.
3455         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3456         "set" completers.
3457
3458 2019-06-13  Pedro Alves  <palves@redhat.com>
3459
3460         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3461         after item.
3462
3463 2019-06-13  Pedro Alves  <palves@redhat.com>
3464
3465         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3466
3467 2019-06-13  Pedro Alves <palves@redhat.com>
3468
3469         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3470         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3471         call.
3472         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3473         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3474         calls.
3475         (check_for_argument): Skip spaces after argument.
3476
3477 2019-06-13  Pedro Alves  <palves@redhat.com>
3478
3479         * thread.c (thread_apply_command): Adjust TID parsing.
3480         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3481         detected before end of string.
3482         (tid_is_in_list): Error out if LIST is invalid.
3483
3484 2019-06-13  Pedro Alves  <palves@redhat.com>
3485
3486         * completer.c (complete_line_internal_1): Rewind completion word
3487         point.
3488         (completion_tracker::advance_custom_word_point_by): Change
3489         parameter type to int.
3490         * completer.h (completion_tracker::advance_custom_word_point_by):
3491         Likewise.
3492
3493 2019-06-13  Pedro Alves  <palves@redhat.com>
3494
3495         * completer.c (advance_to_completion_word): Handle delimiters.
3496
3497 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3498
3499         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3500
3501 2019-06-11  Tom Tromey  <tom@tromey.com>
3502
3503         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3504         (xmalloc_failed): Move to alloc.c.
3505         * alloc.c: New file.
3506         * Makefile.in (COMMON_SFILES): Add alloc.c.
3507
3508 2019-06-11  Tom Tromey  <tom@tromey.com>
3509
3510         * nat/linux-waitpid.c: Don't include server.h.
3511         (linux_debug): Remove.
3512         (my_waitpid): Update.
3513
3514 2019-06-11  Tom Tromey  <tromey@adacore.com>
3515
3516         * infcall.c (_initialize_infcall): Remove trailing newline from
3517         help.
3518         * user-regs.c (_initialize_user_regs): Remove trailing newline
3519         from help.
3520         * typeprint.c (_initialize_typeprint): Remove trailing newline
3521         from help.
3522         * reverse.c (_initialize_reverse): Remove trailing newlines from
3523         help.
3524         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3525         from help.
3526         * language.c (add_set_language_command): Remove trailing newline
3527         from help.
3528         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3529         help.
3530         * disasm.c (_initialize_disasm): Remove trailing newline from
3531         help.
3532         * top.c (init_main): Remove trailing newline from help.
3533         * interps.c (_initialize_interpreter): Remove trailing newline
3534         from help.
3535         * btrace.c (_initialize_btrace): Remove trailing newlines from
3536         help.
3537         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3538         from help.
3539         * python/python.c (_initialize_python): Remove trailing newline
3540         from help.
3541         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3542         help.
3543         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3544         from help.  Reformat some text.
3545         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3546         from help.
3547         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3548         newline from help.
3549
3550 2019-06-11  Tom Tromey  <tromey@adacore.com>
3551
3552         * darwin-nat.c (darwin_decode_exception_message)
3553         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3554
3555 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3556
3557         * valops.c (value_slice): Check for not allocated or not
3558         associated values.
3559
3560 2019-06-10  Tom de Vries  <tdevries@suse.de>
3561
3562         PR gdb/24618
3563         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3564         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3565         invalid.
3566
3567 2019-06-10  Tom de Vries  <tdevries@suse.de>
3568
3569         PR gdb/24611
3570         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3571         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3572
3573 2019-06-10  Tom de Vries  <tdevries@suse.de>
3574
3575         PR symtab/24545
3576         * symtab.c (struct demangled_name_entry): Add language field.
3577         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3578         static minimal symbol".  Set and use language field.
3579
3580 2019-06-10  Tom Tromey  <tromey@adacore.com>
3581
3582         * ada-lang.c (_initialize_ada_language): Update help text.
3583
3584 2019-06-10  Tom Tromey  <tromey@adacore.com>
3585
3586         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3587         with a newline.
3588         * guile/guile.c (handle_boot_error): Don't end warning with a
3589         newline.
3590         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3591         warning with a newline.
3592         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3593         newline.
3594         (s12z_frame_cache): Likewise.
3595         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3596         a newline.
3597         * solib-svr4.c (disable_probes_interface): Don't end warning with
3598         a newline.
3599         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3600         newline.
3601         * python/python.c (do_finish_initialization): Don't end warning
3602         with a newline.
3603
3604 2019-06-10  Tom Tromey  <tom@tromey.com>
3605
3606         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3607         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3608         gdbpy_enter.
3609
3610 2019-06-10  Tom Tromey  <tromey@adacore.com>
3611
3612         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3613         data.
3614         (elf_new_init): Don't call stabsread_new_init.
3615         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3616         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3617         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3618
3619 2019-06-10  Tom de Vries  <tdevries@suse.de>
3620
3621         PR symtab/16264
3622         PR symtab/24517
3623         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3624
3625 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3626
3627         * source.c (find_and_open_source): Also rewrite relative file
3628         names.
3629
3630 2019-04-26  Amos Bird  <amosbird@gmail.com>
3631
3632         * annotate.c (annotate_thread_exited): Add "thread-exited"
3633         annotation.
3634
3635 2019-06-06  Tom Tromey  <tromey@adacore.com>
3636
3637         * maint.h (class scoped_command_stats): Use
3638         DISABLE_COPY_AND_ASSIGN.
3639         <print_time>: New method.
3640         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3641         print_time.
3642         (scoped_command_stats::print_time): New method.
3643
3644 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3645
3646         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3647         instructions of lengths 6 or 8 bytes.
3648
3649 2019-06-04  Pedro Alves  <palves@redhat.com>
3650
3651         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3652
3653         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3654         * breakpoint.c (condition_completer): Likewise.
3655         * cli/cli-dump.c (scan_expression): Likewise.
3656         * common/filestuff.c (mkdir_recursive): Likewise.
3657         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3658         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3659         (gdb_abspath): Likewise.
3660         * compile/compile-cplus-types.c
3661         (compile_cplus_instance::decl_name): Likewise.
3662         * completer.c (complete_explicit_location):
3663         (signal_completer, reg_or_group_completer_1): Likewise.
3664         * cp-support.c (cp_remove_params_if_any): Likewise.
3665         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3666         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3667         * infcmd.c (strip_bg_char): Likewise.
3668         * linespec.c (copy_token_string): Likewise.
3669         * mi/mi-main.c (output_cores): Likewise.
3670         * psymtab.c (psymtab_search_name):
3671         * symfile.c (test_set_ext_lang_command): Likewise.
3672         * target.c (target_fileio_read_stralloc): Likewise.
3673         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3674         * value.c (complete_internalvar): Likewise.
3675
3676 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3677
3678         Add objfile property to gdb.Type.
3679         * NEWS: Mention Python API addition.
3680         * python/py-type.c (typy_get_objfile): New method.
3681
3682 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3683
3684         * NEWS: Mention the new set|show style [title|highlight].
3685         Mention changes to "show style", "help" and "apropos".
3686
3687 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3688
3689         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3690         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3691         instead of print_help_for_command.
3692         (print_doc_of_command): New function.
3693         (help_list): Add 'apropos -v word' suggestion.
3694         (print_help_for_command): Style the command name using title style.
3695         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3696         (_initialize_cli_cmds): Describe -v in apropos_command help.
3697
3698 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3699
3700         * cli/cli-style.h (cli_style_option): Add name in constructor,
3701         add m_name class member, add constructor with intensity,
3702         add name class function.
3703         (cli_style_option::add_setshow_commands): Remove name argument.
3704         (highlight_style, title_style): New styles.
3705         * cli/cli-style.c (do_show): New function that shows a style
3706         characteristic styling the style name with itself.
3707         (set_style_name): New function.
3708         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3709         Update all callers according to the changes in cli/cli-style.h.
3710         * utils.h (fputs_highlighted): New function.
3711         * utils.c (fputs_highlighted): Likewise.
3712
3713 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3714
3715         * NEWS: Mention new pipe command and new convenience variables.
3716
3717 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3718
3719         * cli/cli-cmds.c (pipe_command): New function.
3720         (_initialize_cli_cmds): Call add_com for pipe_command.
3721         Define | as an alias for pipe.
3722         (exit_status_set_internal_vars): New function.
3723         (shell_escape): Call exit_status_set_internal_vars.
3724         cli/cli-decode.c (find_command_name_length): Recognize | as
3725         a single character command.
3726
3727 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3728
3729         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3730         top.c (execute_command_to_ui_file): New function, mostly a copy
3731         of execute_command_to_string.
3732         (execute_command_to_string): Implement by calling
3733         execute_command_to_ui_file.
3734
3735 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3736
3737         * top.h (saved_command_line): Remove declaration.
3738         * top.c (previous_saved_command_line, previous_repeat_arguments):
3739         New variables.
3740         (saved_command_line): Make static, define together with other
3741         'repeat variables'.
3742         (dont_repeat): Clear repeat_arguments.
3743         (repeat_previous, get_saved_command_line, save_command_line):
3744         New functions.
3745         (gdb_init): Initialize saved_command_line
3746         and previous_saved_command_line.
3747         * main.c (captured_main_1): Remove saved_command_line initialization.
3748         * event-top.c (handle_line_of_input): Update to use
3749         the new 'repeat' related functions instead of direct access to
3750         saved_command_line.
3751         * command.h (repeat_previous, get_saved_command_line,
3752         save_command_line): New declarations.
3753         (dont_repeat): Add comment.
3754
3755 2019-05-30  Tom Tromey  <tromey@adacore.com>
3756
3757         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3758         Fix comment.
3759         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3760
3761 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3762
3763         PR cli/24587
3764         * completer.c (complete): Initialize variable word.
3765
3766 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3767
3768         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3769         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3770         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3771         'body' is NULL to the outter 'if', protecting the '!is_define'
3772         situation as well.
3773
3774 2019-05-29  Tom Tromey  <tromey@adacore.com>
3775
3776         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3777         (dwarf_unknown): New function.
3778         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3779         (dwarf_type_encoding_name): Use dwarf_unknown.
3780
3781 2019-05-29  Tom Tromey  <tromey@adacore.com>
3782
3783         PR c++/20020:
3784         * cp-valprint.c (cp_print_value_fields): Call
3785         cp_print_static_field inside "try".
3786
3787 2019-05-29  Tom Tromey  <tromey@adacore.com>
3788
3789         * inflow.c (struct terminal_info): Add default operator=.
3790         * configure: Rebuild.
3791         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3792         -Wdeprecated-copy-dtor, -Wredundant-move.
3793
3794 2019-05-29  Tom Tromey  <tromey@adacore.com>
3795
3796         * NEWS: Add entry.
3797         * infcmd.c (print_return_value_1): Handle finish_print
3798         option.
3799         (show_print_finish): New function.
3800         (_initialize_infcmd): Add "set/show print finish" commands.
3801         * valprint.c (user_print_options): Initialize new member.
3802         * valprint.h (struct value_print_options) <finish_print>: New
3803         member.
3804
3805 2019-05-28  Tom Tromey  <tromey@adacore.com>
3806
3807         * ada-lang.c (ada_remove_Xbn_suffix)
3808         (find_old_style_renaming_symbol)
3809         (parse_old_style_renaming): Remove.
3810         (ada_find_renaming_symbol): Don't call
3811         find_old_style_renaming_symbol.
3812         (ada_is_renaming_symbol): Rename from
3813         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3814         bool.  Now static.
3815         (ada_read_var_value): Update and simplify.
3816         * ada-exp.y (write_var_or_type): Remove old code.
3817
3818 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3819
3820         * event-top.c: Remove include comment.
3821         * inflow.c (class scoped_ignore_sigttou): Move from here...
3822         * inflow.h (class scoped_ignore_sigttou): ...to here.
3823         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3824         * top.c:  Remove include comment.
3825
3826 2019-05-27  Tom Tromey  <tom@tromey.com>
3827
3828         * NEWS: Fix typo.
3829
3830 2019-05-22  Tom Tromey  <tromey@adacore.com>
3831
3832         * target.c (target_follow_exec): Constify parameter.
3833         * target-delegates.c: Rebuild.
3834         * remote.c (remote_target::follow_exec): Constify parameter.
3835         * infrun.c (follow_exec): Constify parameter.
3836         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3837         (target_follow_exec): Likewise.
3838
3839 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3840
3841         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3842         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3843
3844 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3845
3846         * NEWS: Add debugredirect and testsuite sections.
3847
3848 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3849
3850         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3851         target descriptions using exclusively floating point register name
3852         aliases.
3853
3854 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3855
3856         PR gdb/18644:
3857         * f-lang.c (build_fortran_types): Handle the case where
3858         gdbarch_floatformat_for_type returns a nullptr.
3859
3860 2019-05-21  Tom de Vries  <tdevries@suse.de>
3861
3862         PR cli/24587
3863         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3864
3865 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3866
3867         PR gdb/18644:
3868         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3869         16-byte floats.
3870         * i386-tdep.c (i386_floatformat_for_type): Use
3871         floatformats_ia64_quad for the 16-byte floating point component
3872         within a fortran 32-byte complex number.
3873
3874 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3875
3876         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3877         delete default constructor.
3878         (find_partial_die): Update to return const struct.
3879         (partial_die_parent_scope): Move variable declaration into scope
3880         of its use and change its type to auto.
3881         (guess_partial_die_structure_name): Likewise.
3882         (partial_die_info::fixup): Likewise.
3883
3884 2019-05-17  Tom Tromey  <tromey@adacore.com>
3885
3886         * source.c (find_and_open_source): Remove cast.
3887
3888 2019-05-17  Tom Tromey  <tromey@adacore.com>
3889
3890         * annotate.c (annotate_source): Make "filename" const.
3891         * annotate.h (annotate_source): Use const.
3892
3893 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3894
3895         * disasm.c (set_disassembler_options): Send errors to stderr.
3896
3897 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3898
3899         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3900         (cli_interp_base::set_logging): Check debug_redirect.
3901         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3902         * cli/cli-logging.c (debug_redirect): Add static variable.
3903         (pop_output_files): Add default param.
3904         (handle_redirections): Print debug setting.
3905         (show_logging_command): Likewise.
3906         (_initialize_cli_logging): Add debugredirect command.
3907         * interps.c (current_interp_set_logging): Add debug_redirect
3908         parameter.
3909         * interps.h (set_logging): Add debug_redirect parameter.
3910         (current_interp_set_logging): Likewise.
3911         * mi/mi-common.h: Likewise.
3912         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3913
3914 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3915             Tom Tromey  <tromey@adacore.com>
3916
3917         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3918         directly.
3919         * cli/cli-interp.h (make_logging_output): Remove declaration.
3920         * cli/cli-logging.c (make_logging_output): Remove function.
3921         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3922         directly.
3923         * ui-file.c (tee_file::tee_file): Remove bools.
3924         (tee_file::~tee_file): Remove deletes.
3925         * ui-file.h (tee_file): Remove bools.
3926
3927 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3928
3929         * mi/mi-cmds.h (mi_cmd_complete): New function.
3930         * mi/mi-main.c (mi_cmd_complete): Likewise.
3931         * mi/mi-cmds.c: Define new MI command -complete.
3932         * NEWS: Mention new -complete command.
3933
3934 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3935
3936         * completer.h (complete): New function.
3937         * completer.c (complete): Likewise.
3938         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3939         function defined in completer.h.
3940
3941 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3942
3943         * MAINTAINERS (Write After Approval): Add myself.
3944
3945 2019-05-17  Tom de Vries  <tdevries@suse.de>
3946
3947         PR gdb/24094
3948         * dwarf2read.c (struct cu_partial_die_info): New struct.
3949         (find_partial_die): Return cu_partial_die_info.
3950         (partial_die_parent_scope, guess_partial_die_structure_name)
3951         (partial_die_info::fixup): Handle new return type of find_partial_die.
3952
3953 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3954
3955         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3956         "std::string", simplifying the algorithm.
3957
3958 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3959
3960         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3961         (stap_static_probe_ops::get_probes): Likewise.
3962
3963 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3964
3965         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3966         '-')" and "else if".
3967         (stap_parse_single_operand): Join checks for
3968         "gdbarch_stap_parse_special_token_p" and
3969         "gdbarch_stap_parse_special_token" in the same "if" statement.
3970         Invert check when verifying for operation on register
3971         displacement.
3972
3973 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3974
3975         * stap-probe.c (stap_get_opcode): Update comment.
3976         (stap_get_expected_argument_type): Likewise.
3977         (handle_stap_probe): Likewise.
3978
3979 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3980
3981         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3982         return type to 'bool'.  Adjust comment.  Use 'bool' when
3983         appropriate.
3984         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3985         * stap-probe.c (stap_parse_argument_1): Likewise.
3986         (stap_is_operator): Likewise.
3987         (stap_is_generic_prefix): Likewise.
3988         (stap_is_register_prefix): Likewise.
3989         (stap_is_register_indirection_prefix): Likewise.
3990         (stap_is_integer_prefix): Likewise.
3991         (stap_generic_check_suffix): Likewise.
3992         (stap_check_integer_suffix): Likewise.
3993         (stap_check_register_suffix): Likewise.
3994         (stap_check_register_indirection_suffix): Likewise.
3995         (stap_parse_register_operand): Likewise.
3996         (stap_parse_single_operand): Likewise.
3997         (stap_parse_argument_1): Likewise.
3998         (stap_probe::get_argument_count): Likewise.
3999         (stap_is_operator): Likewise.
4000
4001 2019-05-16  Tom Tromey  <tromey@adacore.com>
4002
4003         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4004         keyword to foreach.
4005
4006 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4007
4008         * linux-thread-db.c (try_thread_db_load_1): Change return type
4009         to bool.
4010         (try_thread_db_load): Likewise.
4011         (try_thread_db_load_from_pdir_1): Likewise.
4012         (try_thread_db_load_from_pdir): Likewise.
4013         (try_thread_db_load_from_sdir): Likewise.
4014         (try_thread_db_load_from_dir): Likewise.
4015         (thread_db_load_search): Likewise.
4016         (has_libpthread): Likewise.
4017         (thread_db_load): Likewise.
4018
4019 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4020
4021         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4022         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4023         NULL, and complain/return if that's the case.
4024
4025 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4026
4027         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4028         (advance, posn, abstract_read_memory): New functions.
4029         [struct mem_read_abstraction]: New struct.
4030         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4031
4032 2019-05-14  Tom Tromey  <tromey@adacore.com>
4033
4034         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4035         value is not lval_memory.
4036
4037 2019-05-14  Tom Tromey  <tromey@adacore.com>
4038
4039         * solib.c (info_sharedlibrary_command): Style the file name.
4040
4041 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4042
4043         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4044         (aarch64_vnv_type): Likewise.
4045         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4046         * common/tdesc.c: Likewise.
4047         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4048         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4049         * features/aarch64-fpu.xml: Add ieee half view.
4050         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4051         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4052         * gdbtypes.h (struct builtin_type): Likewise.
4053         (struct objfile_type): Likewise.
4054
4055 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4056
4057         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4058         typo.
4059         * location.h (string_to_event_location): Likewise.
4060
4061 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4062
4063         GDB 8.3 released.
4064
4065 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4066
4067         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4068         New variable declaration.
4069         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4070         New variable.
4071         (print_one_breakpoint): Use ui_out::test_flags and new global
4072         variable to compute use_fixed_output.
4073         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4074         Remove.
4075         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4076         (mi_multi_location_breakpoint_output_fixed): Remove.
4077         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4078         new variable.
4079         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4080         fix_multi_location_breakpoint_output flag if version >= 3.
4081         * ui-out.h (enum ui_out_flag)
4082         <fix_multi_location_breakpoint_output>: New enumerator.
4083
4084 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4085
4086         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4087
4088 2019-05-10  Tom Tromey  <tromey@adacore.com>
4089
4090         * ada-lang.c (catch_ada_completer): New function.
4091         (_initialize_ada_language): Use it.
4092
4093 2019-05-10  Tom Tromey  <tromey@adacore.com>
4094
4095         * thread.c (print_thread_info): Make "requested_threads" const.
4096         * gdbthread.h (print_thread_info): Make "requested_threads"
4097         const.
4098         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4099         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4100
4101 2019-05-08  Tom Tromey  <tom@tromey.com>
4102
4103         * gdbtypes.c (objfile_type_data): Change type.
4104         (objfile_type, _initialize_gdbtypes): Update.
4105
4106 2019-05-08  Tom Tromey  <tom@tromey.com>
4107
4108         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4109         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4110         (_initialize_dwarf2_frame): Update.
4111
4112 2019-05-08  Tom Tromey  <tom@tromey.com>
4113
4114         * objc-lang.c (objc_objfile_data): Change type.
4115         (find_methods): Update.
4116         (_initialize_objc_lang): Remove.
4117
4118 2019-05-08  Tom Tromey  <tom@tromey.com>
4119
4120         * stabsread.c (rs6000_builtin_type_data): Change type.
4121         (rs6000_builtin_type, _initialize_stabsread): Update.
4122
4123 2019-05-08  Tom Tromey  <tom@tromey.com>
4124
4125         * mips-tdep.c (mips_pdr_data): Remove.
4126         (_initialize_mips_tdep): Update.
4127
4128 2019-05-08  Tom Tromey  <tom@tromey.com>
4129
4130         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4131         (hppa_init_objfile_priv_data, read_unwind_info)
4132         (find_unwind_entry, _initialize_hppa_tdep): Update.
4133
4134 2019-05-08  Tom Tromey  <tom@tromey.com>
4135
4136         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4137         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4138         on obstack.
4139         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4140
4141 2019-05-08  Tom Tromey  <tom@tromey.com>
4142
4143         * mdebugread.c (basic_type_data): Change type.
4144         (basic_type, _initialize_mdebugread): Update.
4145
4146 2019-05-08  Tom Tromey  <tom@tromey.com>
4147
4148         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4149
4150 2019-05-08  Tom Tromey  <tom@tromey.com>
4151
4152         * nto-tdep.c (nto_inferior_data_reg): Change type.
4153         (nto_inferior_data): Update.
4154         (nto_inferior_data_cleanup, nto_new_inferior_data)
4155         (_initialize_nto_tdep): Remove.
4156         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4157
4158 2019-05-08  Tom Tromey  <tom@tromey.com>
4159
4160         * ada-lang.c (struct ada_inferior_data): Add initializers.
4161         (ada_inferior_data): Change type.
4162         (ada_inferior_data_cleanup): Remove.
4163         (get_ada_inferior_data, ada_inferior_exit)
4164         (struct ada_pspace_data): Add initializers, destructor.
4165         (ada_pspace_data_handle): Change type.
4166         (get_ada_pspace_data): Update.
4167         (ada_pspace_data_cleanup): Remove.
4168
4169 2019-05-08  Tom Tromey  <tom@tromey.com>
4170
4171         * coffread.c (struct coff_symfile_info): Add initializers.
4172         (coff_objfile_data_key): Move lower.  Change type.
4173         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4174         Update.
4175         (coff_free_info): Remove.
4176
4177 2019-05-08  Tom Tromey  <tom@tromey.com>
4178
4179         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4180         (fbsd_pspace_data_handle): Move lower.  Change type.
4181         (get_fbsd_pspace_data): Update.
4182         (fbsd_pspace_data_cleanup): Remove.
4183         (_initialize_fbsd_tdep): Update.
4184
4185 2019-05-08  Tom Tromey  <tom@tromey.com>
4186
4187         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4188         (get_ada_tasks_pspace_data): Update.
4189         (ada_tasks_pspace_data_cleanup): Remove.
4190         (_initialize_tasks): Update.
4191         (ada_tasks_inferior_data_handle): Change type.
4192         (get_ada_tasks_inferior_data): Update.
4193         (ada_tasks_inferior_data_cleanup): Remove.
4194         (struct ada_tasks_pspace_data): Add initializers.
4195
4196 2019-05-08  Tom Tromey  <tom@tromey.com>
4197
4198         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4199         * symfile-debug.c (debug_sym_get_probes): Change type.
4200         * stap-probe.c (handle_stap_probe):
4201         (stap_static_probe_ops::get_probes): Change type.
4202         * probe.h (class static_probe_ops) <get_probes>: Change type.
4203         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4204         (parse_probes_in_pspace): Update.
4205         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4206         Update.
4207         (any_static_probe_ops::get_probes): Change type.
4208         * elfread.c (elfread_data): New typedef.
4209         (probe_key): Change type.
4210         (elf_get_probes): Likewise.  Update.
4211         (probe_key_free): Remove.
4212         (_initialize_elfread): Update.
4213         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4214         Change type.
4215         (dtrace_process_dof_probe, dtrace_process_dof)
4216         (dtrace_static_probe_ops::get_probe): Change type.
4217
4218 2019-05-08  Tom Tromey  <tom@tromey.com>
4219
4220         * xcoffread.c (struct xcoff_symfile_info): Rename from
4221         coff_symfile_info.  Add initializers.
4222         (xcoff_objfile_data_key): Move lower.  Change type.
4223         (XCOFF_DATA): Rewrite.
4224         (xcoff_free_info): Remove.
4225         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4226         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4227         (xcoff_initial_scan): Update.
4228
4229 2019-05-08  Tom Tromey  <tom@tromey.com>
4230
4231         * solib-svr4.c (struct svr4_info): Add initializers and
4232         destructor.
4233         <probes_table>: Now an htab_up.
4234         (solib_svr4_pspace_data): Change type.
4235         (free_probes_table): Simplify.
4236         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4237         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4238         (probes_table_remove_objfile_probes, register_solib_event_probe)
4239         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4240         (_initialize_svr4_solib): Update.
4241
4242 2019-05-08  Tom Tromey  <tom@tromey.com>
4243
4244         * remote.c (remote_pspace_data): Change type.
4245         (remote_pspace_data_cleanup): Remove.
4246         (get_remote_exec_file, set_pspace_remote_exec_file)
4247         (_initialize_remote): Update.
4248
4249 2019-05-08  Tom Tromey  <tom@tromey.com>
4250
4251         * breakpoint.c (breakpoint_objfile_key): Change type.
4252         (get_breakpoint_objfile_data): Update.
4253         (free_breakpoint_objfile_data): Remove.
4254         (_initialize_breakpoint): Update.
4255
4256 2019-05-08  Tom Tromey  <tom@tromey.com>
4257
4258         * linux-tdep.c (struct linux_info): Add initializers.
4259         (linux_inferior_data): Move.  Change type.
4260         (invalidate_linux_cache_inf): Update.
4261         (linux_inferior_data_cleanup): Remove.
4262         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4263
4264 2019-05-08  Tom Tromey  <tom@tromey.com>
4265
4266         * auxv.c (auxv_inferior_data): Move.  Change type.
4267         (auxv_inferior_data_cleanup): Remove.
4268         (invalidate_auxv_cache_inf): Rewrite.
4269         (get_auxv_inferior_data, _initialize_auxv): Update.
4270
4271 2019-05-08  Tom Tromey  <tom@tromey.com>
4272
4273         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4274         (symfile_debug_objfile_data_key): Change type.
4275         (symfile_debug_installed, debug_qf_has_symbols)
4276         (debug_qf_find_last_source_symtab)
4277         (debug_qf_forget_cached_source_info)
4278         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4279         (debug_qf_print_stats, debug_qf_dump)
4280         (debug_qf_expand_symtabs_for_function)
4281         (debug_qf_expand_all_symtabs)
4282         (debug_qf_expand_symtabs_with_fullname)
4283         (debug_qf_map_matching_symbols)
4284         (debug_qf_expand_symtabs_matching)
4285         (debug_qf_find_pc_sect_compunit_symtab)
4286         (debug_qf_map_symbol_filenames)
4287         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4288         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4289         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4290         (debug_sym_read_linetable, debug_sym_relocate): Update.
4291         (symfile_debug_free_objfile): Remove.
4292         (install_symfile_debug_logging, _initialize_symfile_debug):
4293         Update.
4294
4295 2019-05-08  Tom Tromey  <tom@tromey.com>
4296
4297         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4298         allocate_on_obstack.
4299         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4300         (get_dwarf2_per_objfile): Update.
4301         (set_dwarf2_per_objfile): Remove.
4302         (dwarf2_has_info, dwarf2_get_section_info): Update.
4303         (dwarf2_free_objfile): Remove.
4304         (_initialize_dwarf2_read): Update.
4305
4306 2019-05-08  Tom Tromey  <tom@tromey.com>
4307
4308         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4309         initializers.
4310         <unsupported_script_warning_printed,
4311         script_not_found_warning_printed>: Now bool.
4312         (auto_load_pspace_data): Change type.
4313         (~auto_load_pspace_info): Rename from
4314         auto_load_pspace_data_cleanup.
4315         (get_auto_load_pspace_data, init_loaded_scripts_info)
4316         (clear_section_scripts, maybe_print_unsupported_script_warning)
4317         (maybe_print_script_not_found_warning, _initialize_auto_load):
4318         Update.
4319
4320 2019-05-08  Tom Tromey  <tom@tromey.com>
4321
4322         * objfiles.c (objfile_pspace_info): Add destructor and
4323         initializers.
4324         (objfiles_pspace_data): Change type.
4325         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4326         (get_objfile_pspace_data): Update.
4327         (objfiles_bfd_data): Change type.
4328         (get_objfile_bfd_data): Update.
4329         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4330
4331 2019-05-08  Tom Tromey  <tom@tromey.com>
4332
4333         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4334         Change type.
4335         (get_catch_syscall_inferior_data): Update.
4336         (catch_syscall_inferior_data_cleanup): Remove.
4337         (_initialize_break_catch_syscall): Update.
4338
4339 2019-05-08  Tom Tromey  <tom@tromey.com>
4340
4341         * inflow.c (struct terminal_info): Add destructor and
4342         initializers.
4343         (inflow_inferior_data): Change type.
4344         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4345         (get_inflow_inferior_data, inflow_inferior_exit)
4346         (swap_terminal_info, _initialize_inflow): Update.
4347
4348 2019-05-08  Tom Tromey  <tom@tromey.com>
4349
4350         * target-dcache.c (target_dcache_cleanup): Remove.
4351         (target_dcache_aspace_key): Change type.
4352         (target_dcache_init_p, target_dcache_invalidate)
4353         (target_dcache_get, target_dcache_get_or_init)
4354         (_initialize_target_dcache): Update.
4355         * dcache.h (struct dcache_deleter): New.
4356
4357 2019-05-08  Tom Tromey  <tom@tromey.com>
4358
4359         * symtab.c (struct symbol_cache): Add destructor and
4360         initializers.
4361         (symbol_cache_key): Move.  Change type.
4362         (make_symbol_cache, free_symbol_cache): Remove.
4363         (get_symbol_cache): Update.
4364         (symbol_cache_cleanup): Remove.
4365         (ALL_PSPACES, symbol_cache_flush)
4366         (maintenance_print_symbol_cache)
4367         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4368         Update.
4369
4370 2019-05-08  Tom Tromey  <tom@tromey.com>
4371
4372         * symtab.c (struct main_info): Add destructor and initializers.
4373         (main_progspace_key): Move.  Change type.
4374         (get_main_info): Update.
4375         (main_info_cleanup): Remove.
4376         (_initialize_symtab): Update.
4377
4378 2019-05-08  Tom Tromey  <tom@tromey.com>
4379
4380         * registry.h (DECLARE_REGISTRY): Define the _key class.
4381
4382 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4383
4384         * NEWS: Merge two 'New commands' sections.
4385
4386 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4387
4388         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4389         parameter and use Ada language definition instead.
4390         (ada_val_print_ptr): Remove unused language parameter.
4391         (ada_val_print_num): Remove language parameter and use Ada language
4392         definition instead.
4393         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4394         parameter.
4395         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4396         parameter and use Ada language definition instead.
4397         (ada_val_print_1): Update all ada_val_print_xxx calls.
4398         Remove language parameter.
4399         (ada_val_print): Update ada_val_print_1 call.
4400
4401 2019-05-08  Tom Tromey  <tromey@adacore.com>
4402
4403         * remote.c (remote_hw_watchpoint_limit)
4404         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4405         Now static.
4406
4407 2019-05-08  Tom Tromey  <tromey@adacore.com>
4408
4409         * maint.c (_initialize_maint_cmds): Move initialization code to
4410         remote.c.
4411         (watchdog, show_watchdog): Move to remote.c.
4412         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4413         "watchdog" static.
4414         (_initialize_remote): Move initialization code from maint.c.
4415         * defs.h (watchdog): Don't declare.
4416
4417 2019-05-08  Tom Tromey  <tromey@adacore.com>
4418
4419         * tui/tui-interp.c: Include main.h.
4420         * interps.c: Include main.h.
4421         * main.h (interpreter_p): Declare.
4422         * defs.h (interpreter_p): Don't declare.
4423
4424 2019-05-08  Tom Tromey  <tromey@adacore.com>
4425
4426         * dwarf2loc.c: Include dwarf2read.h.
4427         * defs.h (read_unsigned_leb128): Don't declare.
4428         * dwarf2read.h (read_unsigned_leb128): Declare.
4429
4430 2019-05-08  Tom Tromey  <tromey@adacore.com>
4431
4432         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4433         method.
4434
4435 2019-05-08  Tom Tromey  <tromey@adacore.com>
4436
4437         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4438         when no wrap column is set.
4439
4440 2019-05-08  Tom Tromey  <tromey@adacore.com>
4441
4442         * c-lang.c (c_get_string): Handle non-C-style arrays.
4443
4444 2019-05-08  Tom Tromey  <tromey@adacore.com>
4445
4446         * typeprint.c (print_offset_data::update): Print the bit offset,
4447         not the number of bits remaining.
4448
4449 2019-05-08  Tom Tromey  <tromey@adacore.com>
4450
4451         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4452         padding at end of comment.
4453
4454 2019-05-08  Tom Tromey  <tromey@adacore.com>
4455
4456         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4457         Compare main types.
4458
4459 2019-05-06  Tom Tromey  <tom@tromey.com>
4460
4461         * common/scoped_mmap.c: Include common-defs.h.
4462         * common/scoped_mmap.h: Don't include config.h.
4463
4464 2019-05-04  Tom Tromey  <tom@tromey.com>
4465
4466         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4467         (struct aarch64_call_info): Add initializers.
4468         <si>: Now a std::vector.
4469         (pass_on_stack, aarch64_push_dummy_call): Update.
4470
4471 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4472             Tom Tromey  <tom@tromey.com>
4473
4474         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4475         (ppc_threads): Now a std::vector.  Now static.
4476         (hwdebug_find_thread_points_by_tid)
4477         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4478         Update.
4479
4480 2019-05-04  Tom Tromey  <tom@tromey.com>
4481
4482         * arc-tdep.c (arc_tdesc_init): Return bool.
4483
4484 2019-05-04  Tom Tromey  <tom@tromey.com>
4485
4486         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4487         Use gdb_assert_not_reached.
4488
4489 2019-05-04  Tom Tromey  <tom@tromey.com>
4490
4491         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4492         "false".
4493
4494 2019-05-04  Tom Tromey  <tom@tromey.com>
4495
4496         * arc-tdep.c (arc_tdesc_init): Use bool.
4497
4498 2019-05-04  Tom Tromey  <tom@tromey.com>
4499
4500         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4501
4502 2019-05-04  Tom Tromey  <tom@tromey.com>
4503
4504         * cli/cli-cmds.c (valid_command_p): Return bool.
4505
4506 2019-05-04  Tom Tromey  <tom@tromey.com>
4507
4508         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4509         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4510
4511 2019-05-04  Raul Tambre  <raul@tambre.ee>
4512
4513         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4514         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4515         operator for comparison.
4516
4517 2019-05-04  Tom Tromey  <tom@tromey.com>
4518
4519         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4520         (lookup_partial_symbol, print_partial_symbols)
4521         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4522         (psymbol_compare): Update.
4523         (add_psymbol_to_bcache): Clear the entire psymbol.
4524         (maintenance_check_psymtabs): Update.
4525         * psympriv.h (struct partial_symbol): Don't derive from
4526         general_symbol_info.
4527         <obj_section, unrelocated_address, address,
4528         set_unrelocated_address>: Update.
4529         <ginfo>: New member.
4530         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4531         (debug_names::write_psymbols): Update.
4532
4533 2019-05-04  Tom de Vries  <tdevries@suse.de>
4534
4535         * contrib/cc-with-tweaks.sh: Support -n arg.
4536
4537 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4538
4539         * corelow.c (core_target::detach): Ensure frame cache and
4540         register caches are cleared.
4541         inferior.c (exit_inferior_1): Likewise.
4542
4543 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4544             Tom Tromey  <tom@tromey.com>
4545
4546         * dictionary.c (collate_pending_symbols_by_language): Remove
4547         "struct" from foreach.
4548         * symtab.c (lookup_global_symbol_from_objfile)
4549         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4550         foreach.
4551         * ser-tcp.c (net_open): Remove "struct" from foreach.
4552         * objfiles.c (objfile_relocate, objfile_rebase)
4553         (objfile_has_symbols): Remove "struct" from foreach.
4554         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4555         from foreach.
4556         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4557         foreach.
4558         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4559         "struct" from foreach.
4560         * ada-lang.c (create_excep_cond_exprs)
4561         (ada_exception_catchpoint_cond_string): Remove "struct" from
4562         foreach.
4563
4564 2019-05-03  Tom Tromey  <tromey@adacore.com>
4565
4566         * ada-exp.y (convert_char_literal): Check suffix of each
4567         enumerator.
4568
4569 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4570
4571         PR ada/21406:
4572         * ada-exp.y (yywrap): Don't define.
4573         * ada-lex.l (%option): Add noyywrap
4574         (yywrap): Remove.
4575
4576 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4577
4578         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4579         _WIN32_WINNT to the XP level, unless already defined to a higher
4580         level.
4581
4582         * unittests/parse-connection-spec-selftests.c:
4583         * ser-tcp.c:
4584         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4585         override.
4586
4587         * symfile.c (find_separate_debug_file): Remove colon from the
4588         drive spec of DOS/Windows file names of the target, so that the
4589         file name produced from DEBUGDIR and the target's directory will
4590         be valid on DOS/Windows systems.
4591
4592 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4593
4594         * rust-lang.c (val_print_struct): Handle printing structures
4595         containing strings.
4596
4597 2019-05-02  Tom Tromey  <tromey@adacore.com>
4598
4599         * valarith.c (_initialize_valarith): Remove.
4600
4601 2019-05-01  Tom Tromey  <tromey@adacore.com>
4602
4603         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4604         bitfields.
4605
4606 2019-05-01  Tom Tromey  <tromey@adacore.com>
4607
4608         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4609         for big-endian copies.
4610
4611 2019-04-30  Ali Tamur  <tamur@google.com>
4612         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4613         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4614         (read_3_bytes): New function.
4615
4616 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4617
4618         * windows-nat.c (main_thread_id): Delete.
4619         (handle_output_debug_string): Replace main_thread_id by
4620         current_event.dwThreadId.
4621         (fake_create_process): Likewise.
4622         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4623         Do not set main_thread_id.
4624         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4625         current_event.dwThreadId.
4626         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4627
4628 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4629
4630         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4631         Use current_event.dwThreadId instead of main_thread_id.
4632
4633 2019-04-30  Tom Tromey  <tromey@adacore.com>
4634
4635         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4636         (create_excep_cond_exprs): Iterate over program spaces.
4637         (ada_exception_catchpoint_cond_string): Examine all minimal
4638         symbols for exception types.
4639
4640 2019-04-30  Tom Tromey  <tromey@adacore.com>
4641
4642         PR c++/24470:
4643         * dwarf2read.c (process_structure_scope): Handle case where type
4644         has template parameters but no symbol was created.
4645
4646 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4647             Chris January  <chris.january@arm.com>
4648
4649         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4650         qualifier.
4651         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4652
4653 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4654
4655         * f-typeprint.c (f_print_type): Update rules for printing
4656         whitespace.
4657         (f_type_print_varspec_suffix): Likewise.
4658
4659 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4660             Chris January  <chris.january@arm.com>
4661
4662         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4663         function arguments.
4664
4665 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4666
4667         * f-lang.c (build_fortran_types): Change name of void type to
4668         lower case.
4669         * f-typeprint.c (f_type_print_base): Print the name of the void
4670         type, rather than a fixed string.
4671         * f-valprint.c (f_decorations): Use lower case void string.
4672
4673 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4674             Chris January  <chris.january@arm.com>
4675
4676         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4677         types for Fortran.
4678
4679 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4680             Chris January  <chris.january@arm.com>
4681             David Lecomber  <david.lecomber@arm.com>
4682
4683         * f-exp.y (BINOP_INTRINSIC): New token.
4684         (exp): New parser rule handling BINOP_INTRINSIC.
4685         (f77_keywords): Add new builtin procedures.
4686         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4687         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4688         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4689         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4690         (print_unop_subexp_f): New function.
4691         (print_binop_subexp_f): New function.
4692         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4693         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4694         (dump_subexp_body_f): Likewise.
4695         (operator_check_f): Likewise.
4696         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4697         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4698
4699 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4700
4701         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4702         UNOP_KIND.
4703         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4704         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4705         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4706         (operator_length_f): New fuction.
4707         (print_subexp_f): New function.
4708         (op_name_f): New function.
4709         (dump_subexp_body_f): New function.
4710         (operator_check_f): New function.
4711         (exp_descriptor_f): Replace standard expression handling functions
4712         with new functions.
4713         * gdb/fortran-operator.def: New file.
4714         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4715         * gdb/std-operator.def: Remove UNOP_KIND.
4716
4717 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4718
4719         * std-operator.def: Remove unbalanced, stray double quote
4720         character.
4721
4722 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4723             Chris January  <chris.january@arm.com>
4724             Daniel Everett  <daniel.everett@arm.com>
4725             Nick Forrington  <nick.forrington@arm.com>
4726             Richard Bunt  <richard.bunt@arm.com>
4727
4728         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4729         of depth when printing anonymous structs or unions.
4730         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4731         Don't print either the top-level value, or the children if the
4732         max-depth is exceeded.
4733         (ppscm_print_children): When printing the key of a map, allow one
4734         extra level of depth.
4735         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4736         print either the top-level value, or the children if the max-depth
4737         is exceeded.
4738         (print_children): When printing the key of a map, allow one extra
4739         level of depth.
4740         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4741         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4742         (user_print_options): Initialise max_depth field.
4743         (val_print_scalar_or_string_type_p): New function.
4744         (val_print): Check to see if the max depth has been reached.
4745         (val_print_check_max_depth): Define new function.
4746         (show_print_max_depth): New function.
4747         (_initialize_valprint): Add 'print max-depth' option.
4748         * valprint.h (struct value_print_options) <max_depth>: New field.
4749         (val_print_check_max_depth): Declare new function.
4750         * NEWS: Document new feature.
4751
4752 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4753
4754         * ada-lang.c (ada_language_defn): Initialise new field.
4755         * c-lang.c (c_is_string_type_p): New function.
4756         (c_language_defn): Initialise new field.
4757         (cplus_language_defn): Initialise new field.
4758         (asm_language_defn): Initialise new field.
4759         (minimal_language_defn): Initialise new field.
4760         * c-lang.h (c_is_string_type_p): Declare new function.
4761         * d-lang.c (d_language_defn): Initialise new field.
4762         * f-lang.c (f_is_string_type_p): New function.
4763         (f_language_defn): Initialise new field.
4764         * go-lang.c (go_is_string_type_p): New function.
4765         (go_language_defn): Initialise new field.
4766         * language.c (default_is_string_type_p): New function.
4767         (unknown_language_defn): Initialise new field.
4768         (auto_language_defn): Initialise new field.
4769         * language.h (struct language_defn) <la_is_string_type_p>: New
4770         member variable.
4771         (default_is_string_type_p): Declare new function.
4772         * m2-lang.c (m2_language_defn): Initialise new field.
4773         * objc-lang.c (objc_language_defn): Initialise new field.
4774         * opencl-lang.c (opencl_language_defn): Initialise new field.
4775         * p-lang.c (pascal_is_string_type_p): New function.
4776         (pascal_language_defn): Initialise new field.
4777         * rust-lang.c (rust_is_string_type_p): New function.
4778         (rust_language_defn): Initialise new field.
4779
4780 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4781
4782         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4783         New field.
4784         * ada-lang.c (ada_language_defn): Initialise new field.
4785         * c-lang.c (c_language_defn): Likewise.
4786         (cplus_language_defn): Likewise.
4787         (asm_language_defn): Likewise.
4788         (minimal_language_defn): Likewise.
4789         * d-lang.c (d_language_defn): Likewise.
4790         * f-lang.c (f_language_defn): Likewise.
4791         * go-lang.c (go_language_defn): Likewise.
4792         * language.c (unknown_language_defn): Likewise.
4793         (auto_language_defn): Likewise.
4794         * m2-lang.c (m2_language_defn): Likewise.
4795         * objc-lang.c (objc_language_defn): Likewise.
4796         * opencl-lang.c (opencl_language_defn): Likewise.
4797         * p-lang.c (pascal_language_defn): Likewise.
4798         * rust-lang.c (rust_language_defn): Likewise.
4799
4800 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4801
4802         * ada-lang.c (ada_is_character_type): Change return type to bool.
4803         (ada_is_string_type): Likewise.
4804         * ada-lang.h (ada_is_character_type): Update declaration
4805         (ada_is_string_type): Likewise.
4806
4807 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4808
4809         Support style in 'frame|thread apply'
4810
4811         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4812         * record.c (record_start, record_stop): Update callers of
4813         execute_command_to_string with false.
4814         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4815         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4816         methods.
4817         (class string_file): New constructor with term_out parameter.
4818         Override methods term_out and can_emit_style_escape.  New member
4819         term_out.
4820         (class stdio_file): Override can_emit_style_escape.
4821         (class tee_file): Override term_out and can_emit_style_escape.
4822         * utils.h (can_emit_style_escape): Remove.
4823         * utils.c (can_emit_style_escape): Likewise.
4824         Update all callers of can_emit_style_escape (SOMESTREAM) to
4825         SOMESTREAM->can_emit_style_escape.
4826         * source-cache.c (source_cache::get_source_lines): Likewise.
4827         * stack.c (frame_apply_command_count): Call execute_command_to_string
4828         passing the term_out characteristic of the current gdb_stdout.
4829         * thread.c (thr_try_catch_cmd): Likewise.
4830         * top.c (execute_command_to_string): pass term_out parameter
4831         to construct the string_file for the command output.
4832         * ui-file.c (term_cli_styling): New function (most code moved
4833         from utils.c can_emit_style_escape).
4834         (string_file::string_file, string_file::can_emit_style_escape,
4835         stdio_file::can_emit_style_escape, tee_file::term_out,
4836         tee_file::can_emit_style_escape): New functions.
4837
4838 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4839
4840         * NEWS: Mention the new set|show may-call-functions.
4841         * infcall.c (may_call_functions_p): New variable.
4842         (show_may_call_functions_p): New function.
4843         (call_function_by_hand_dummy): Throws an error if not
4844         may-call-functions.
4845         (_initialize_infcall): Call add_setshow_boolean_cmd for
4846         may-call-functions.
4847
4848 2019-04-25  Keith Seitz  <keiths@redhat.com>
4849
4850         PR c++/24367
4851         * cp-support.c (inspect_type): Don't attempt substitutions
4852         of symbol with the same name.
4853
4854 2019-04-25  Tom Tromey  <tromey@adacore.com>
4855
4856         PR gdb/24475:
4857         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4858         static.
4859
4860 2019-04-25  Tom Tromey  <tromey@adacore.com>
4861
4862         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4863         rvalue reference.
4864         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4865         (gdb_xml_parser::parse): Use std::move.
4866         * python/python-internal.h (gdbpy_convert_exception): Take a const
4867         reference.
4868         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4869         std::move.
4870         * python/py-utils.c (gdbpy_convert_exception): Take a const
4871         reference.
4872         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4873         Use std::move.
4874         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4875         Use std::move.
4876         * mi/mi-main.c (mi_print_exception): Take a const reference.
4877         * main.c (handle_command_errors): Take a const reference.
4878         * linespec.c (parse_linespec): Use std::move.
4879         * infcall.c (run_inferior_call): Use std::move.
4880         (call_function_by_hand_dummy): Use std::move.
4881         * exec.c (try_open_exec_file): Use std::move.
4882         * exceptions.h (exception_print, exception_fprintf)
4883         (exception_print_same): Update.
4884         * exceptions.c (print_exception, exception_print)
4885         (exception_fprintf, exception_print_same): Change parameters to
4886         const reference.
4887         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4888         * common/new-op.c: Use std::move.
4889         * common/common-exceptions.h (struct gdb_exception): Add move
4890         constructor.
4891         (struct gdb_exception_error, struct gdb_exception_quit, struct
4892         gdb_quit_bad_alloc): Change constructor to move constructor.
4893         (throw_exception): Change parameter to rvalue reference.
4894         * common/common-exceptions.c (throw_exception): Take rvalue
4895         reference.
4896         * cli/cli-interp.c (safe_execute_command): Use std::move.
4897         * breakpoint.c (insert_bp_location, location_to_sals): Use
4898         std::move.
4899
4900 2019-04-25  Tom Tromey  <tromey@adacore.com>
4901
4902         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4903         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4904         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4905         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4906         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4907         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4908         guile/scm-value.c: Use unpack.
4909         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4910         gdbscm_gdb_exception.
4911         (gdbscm_throw_gdb_exception): Likewise.
4912         (struct gdbscm_gdb_exception): New.
4913         (unpack): New function.
4914         (gdbscm_wrap): Use unpack.
4915
4916 2019-04-25  Tom Tromey  <tromey@adacore.com>
4917
4918         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4919         (gdb_rl_callback_handler): Use std::move.
4920         * common/common-exceptions.h (struct gdb_exception): Add move
4921         assignment operator.
4922         (throw_exception_sjlj): Change "exception" to const reference.
4923         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4924         (throw_exception_sjlj): Change "exception" to const reference.
4925
4926 2019-04-25  Tom Tromey  <tromey@adacore.com>
4927
4928         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4929         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4930         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4931         Update.
4932         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4933         Update.
4934         * mi/mi-interp.c (mi_interp::exec): Update.
4935         * linespec.c (parse_linespec): Update.
4936         * infcall.c (run_inferior_call): Update.
4937         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4938         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4939         (gdbscm_lookup_global_symbol): Update.
4940         * guile/scm-param.c (gdbscm_parameter_value): Update.
4941         * guile/scm-frame.c (gdbscm_frame_read_register)
4942         (gdbscm_frame_read_var): Update.
4943         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4944         * exec.c (try_open_exec_file): Update.
4945         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4946         (gdb_rl_callback_handler): Update.
4947         * common/common-exceptions.h (exception_none): Don't declare.
4948         * common/common-exceptions.c (exception_none): Don't define.
4949         (struct catcher) <exception>: Update.
4950         * cli/cli-interp.c (safe_execute_command): Update.
4951         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4952
4953 2019-04-25  Ali Tamur  <tamur@google.com>
4954
4955         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4956         (read_attribute_value): Likewise.
4957         (dwarf2_read_addr_index): Update comment.
4958         (read_str_index): Add DW_FORM_strx.
4959         (dwarf2_string_attr): Likewise.
4960         (dwarf2_const_value_attr): Likewise.
4961         (dump_die_shallow): Likewise.
4962         (dwarf2_fetch_constant_bytes): Likewise.
4963         (skip_form_bytes): Likewise.
4964         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4965
4966 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4967
4968         PR corefiles/11608
4969         PR corefiles/18187
4970         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4971         OFFSET.  Verify if current mapping contains an ELF header.
4972         (linux_find_memory_regions_full): Adjust call to
4973         dump_mapping_p.
4974
4975 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4976             Kang Li <kanglictf@gmail.com>
4977
4978         PR gdb/21600
4979
4980         * dwarf2-frame.c (read_initial_length): Be consistent about using
4981         unsigned representation of length.
4982         (decode_frame_entry_1): Likewise.  Check for wraparound of
4983         end pointer as well as buffer overflow.
4984
4985 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4986
4987         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4988         "vq".
4989
4990 2019-04-24  Tom Tromey  <tromey@adacore.com>
4991
4992         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4993
4994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4995
4996         * s12z-tdep.c (s12z_unwind_pc): Delete.
4997         (s12z_unwind_sp): Delete.
4998         (s12z_gdbarch_init): Don't register deleted functions with
4999         gdbarch.
5000
5001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5002
5003         * rl78-tdep.c (rl78_unwind_sp): Delete.
5004         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5005
5006 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5007
5008         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5009         (xstormy16_unwind_pc): Delete.
5010         (xstormy16_dummy_id): Delete.
5011         (xstormy16_gdbarch_init): Don't register deleted functions with
5012         gdbarch.
5013
5014 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5015
5016         * vax-tdep.c (vax_unwind_pc): Delete.
5017         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5018
5019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5020
5021         * v850-tdep.c (v850_unwind_sp): Delete.
5022         (v850_unwind_pc): Delete.
5023         (v850_dummy_id): Delete.
5024         (v850_gdbarch_init): Don't register deleted functions with
5025         gdbarch.
5026
5027 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5028
5029         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5030         (tilegx_unwind_pc): Delete.
5031         (tilegx_unwind_dummy_id): Delete.
5032         (tilegx_gdbarch_init): Don't register deleted functions with
5033         gdbarch.
5034
5035 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5036
5037         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5038         (tic6x_dummy_id): Delete.
5039         (tic6x_gdbarch_init): Don't register deleted functions with
5040         gdbarch.
5041
5042 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5043
5044         * sparc-tdep.c (sparc_unwind_pc): Delete.
5045         (sparc32_gdbarch_init): Don't register deleted function with
5046         gdbarch.
5047
5048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5049
5050         * sh-tdep.c (sh_unwind_sp): Delete.
5051         (sh_unwind_pc): Delete.
5052         (sh_dummy_id): Delete.
5053         (sh_gdbarch_init): Don't register deleted functions with
5054         gdbarch.
5055
5056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5057
5058         * score-tdep.c (score_unwind_sp): Delete.
5059         (score_unwind_pc): Delete.
5060         (score_dummy_id): Delete.
5061         (score_gdbarch_init): Don't register deleted functions with
5062         gdbarch.
5063
5064 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5065
5066         * rx-tdep.c (rx_unwind_pc): Delete.
5067         (rx_unwind_sp): Delete.
5068         (rx_dummy_id): Delete.
5069         (rx_gdbarch_init): Don't register deleted functions with
5070         gdbarch.  Update comment.
5071
5072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5073
5074         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5075         (rs6000_dummy_id): Delete.
5076         (rs6000_gdbarch_init): Don't register deleted functions with
5077         gdbarch.
5078
5079 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5080
5081         * or1k-tdep.c (or1k_dummy_id): Delete.
5082         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5083
5084 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5085
5086         * nios2-tdep.c (nios2_dummy_id): Delete.
5087         (nios2_unwind_sp): Delete.
5088         (nios2_gdbarch_init): Don't register deleted functions with
5089         gdbarch.
5090
5091 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5092
5093         * nds32-tdep.c (nds32_dummy_id): Delete.
5094         (nds32_unwind_pc): Delete.
5095         (nds32_unwind_sp): Delete.
5096         (nds32_gdbarch_init): Don't register deleted functions with
5097         gdbarch.
5098
5099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5100
5101         * msp430-tdep.c (msp430_unwind_pc): Delete.
5102         (msp430_unwind_sp): Delete.
5103         (msp430_dummy_id): Delete.
5104         (msp430_gdbarch_init): Don't register deleted functions with
5105         gdbarch.
5106
5107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5108
5109         * moxie-tdep.c (moxie_unwind_sp): Delete.
5110         (moxie_unwind_pc): Delete.
5111         (moxie_dummy_id): Delete.
5112         (moxie_gdbarch_init): Don't register deleted functions with
5113         gdbarch.
5114
5115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5116
5117         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5118         (mn10300_unwind_pc): Delete.
5119         (mn10300_unwind_sp): Delete.
5120         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5121         mn10300_unwind_sp.
5122         (mn10300_frame_unwind_init): Don't register deleted functions with
5123         gdbarch.
5124
5125 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5126
5127         * mep-tdep.c (mep_unwind_pc): Delete.
5128         (mep_unwind_sp): Delete.
5129         (mep_dummy_id): Delete.
5130         (mep_gdbarch_init): Don't register deleted functions with
5131         gdbarch.
5132
5133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5134
5135         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5136         (m68hc11_unwind_sp): Delete.
5137         (m68hc11_gdbarch_init): Don't register deleted functions with
5138         gdbarch.
5139
5140 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5141
5142         * m32r-tdep.c (m32r_unwind_sp): Delete.
5143         (m32r_unwind_pc): Delete.
5144         (m32r_dummy_id): Delete.
5145         (m32r_gdbarch_init): Don't register deleted functions with
5146         gdbarch.
5147
5148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5149
5150         * m32c-tdep.c (m32c_unwind_pc): Delete.
5151         (m32c_unwind_sp): Delete.
5152         (m32c_dummy_id): Delete.
5153         (m32c_gdbarch_init): Don't register deleted functions with
5154         gdbarch.
5155
5156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5157
5158         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5159         (lm32_unwind_pc): Delete.
5160         (lm32_dummy_id): Delete.
5161         (lm32_gdbarch_init): Don't register deleted functions with
5162         gdbarch.
5163
5164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5165
5166         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5167         (iq2000_unwind_pc): Delete.
5168         (iq2000_dummy_id): Delete.
5169         (iq2000_gdbarch_init): Don't register deleted functions with
5170         gdbarch.
5171
5172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5173
5174         * nds32-tdep.c (nds32_type_align): Delete.
5175         (nds32_push_dummy_call): Use type_align instead.
5176
5177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5178
5179         * arm-tdep.c (arm_type_align): Only handle vector override case.
5180         (arm_push_dummy_call): Use type_align.
5181         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5182
5183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5184
5185         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5186         case.
5187         (pass_on_stack): Use type_align.
5188         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5189         function.
5190
5191 2019-04-23  Tom Tromey  <tromey@adacore.com>
5192
5193         * dwarf2read.c (line_header::file_name_at): Remove unused
5194         overload.
5195
5196 2019-04-23  Tom de Vries  <tdevries@suse.de>
5197
5198         PR gdb/24438
5199         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5200         invocation.
5201
5202
5203 2019-03-27  Ali Tamur  <tamur@google.com>
5204
5205         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5206         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5207         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5208         (dwarf_expr_context::get_addr_index): Likewise
5209         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5210         (symbol_needs_eval_context::get_addr_index): Likewise
5211         (disassemble_dwarf_expression): Add DW_OP_addrx
5212         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5213         (read_cutu_die_from_dwo): Update comment
5214         (skip_one_die): Add DW_FORM_addrx
5215         (read_attribute_value): Likewise
5216         (var_decode_location): Add DW_OP_addrx
5217         (dwarf2_const_value_attr): Add DW_FORM_addrx
5218         (dump_die_shallow): Likewise
5219         (dwarf2_fetch_constant_bytes): Likewise
5220         (decode_locdesc): Add DW_OP_addrx
5221         (skip_form_bytes): Add DW_FORM_addrx
5222
5223 2019-04-22  Ali Tamur  <tamur@google.com>
5224
5225         * MAINTAINERS (Write After Approval): Add self.
5226
5227 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5228
5229         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5230         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5231         (open_symbol_file_object): Likewise.
5232         (svr4_default_sos): Add info parameter.
5233         (svr4_read_so_list): Likewise.
5234         (svr4_current_sos_direct): Adjust functions calls to pass down
5235         info.
5236         (svr4_current_sos_1): Add info parameter.
5237         (svr4_current_sos): Call get_svr4_info, pass info down to
5238         svr4_current_sos_1.
5239         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5240         get_svr4_info.
5241         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5242         get_svr4_info.
5243         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5244         to get_svr4_info.
5245         (probes_table_remove_objfile_probes): Likewise.
5246         (register_solib_event_probe): Add info parameter.
5247         (solist_update_incremental): Pass info parameter down to
5248         svr4_read_so_list.
5249         (disable_probes_interface): Add info parameter.
5250         (svr4_handle_solib_event): Pass current_program_space to
5251         get_svr4_info.  Adjust disable_probes_interface cleanup.
5252         (svr4_create_probe_breakpoints): Add info parameter, pass it
5253         down to register_solib_event_probe.
5254         (svr4_create_solib_event_breakpoints): Add info parameter,
5255         pass it down to svr4_create_probe_breakpoints.
5256         (enable_break): Pass info down to
5257         svr4_create_solib_event_breakpoints.
5258         (svr4_solib_create_inferior_hook): Pass current_program_space to
5259         get_svr4_info.
5260         (svr4_clear_solib): Likewise.
5261
5262 2019-04-22  Pedro Alves  <palves@redhat.com>
5263
5264         * solib-svr4.c (svr4_free_objfile_observer): New.
5265         (probe_and_action::objfile): New field.
5266         (probes_table_htab_remove_objfile_probes)
5267         (probes_table_remove_objfile_probes): New functions.
5268         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5269         in the new probe_and_action.  Don't store the probe in 'lookup'.
5270         (svr4_create_probe_breakpoints): Pass objfile to
5271         register_solib_event_probe.
5272         (_initialize_svr4_solib): Register a free_objfile observer.
5273
5274 2019-04-19  Tom Tromey  <tom@tromey.com>
5275
5276         * common/queue.h: Remove.
5277
5278 2019-04-19  Tom Tromey  <tom@tromey.com>
5279
5280         * event-loop.c: Don't include "common/queue.h".
5281
5282 2019-04-19  Tom Tromey  <tom@tromey.com>
5283
5284         * remote.c (remote_target): Use delete.
5285         * remote-notif.h: Include <list>, not "common/queue.h".
5286         (notif_client_p): Remove typedef.
5287         (remote_notif_state): Add constructor, destructor, initializer.
5288         <notif_queue>: Now a std::list.
5289         (remote_notif_state_xfree): Don't declare.
5290         * remote-notif.c (remote_notif_process, handle_notification)
5291         (remote_notif_state_allocate): Update.
5292         (~remote_notif_state): Rename from remote_notif_state_xfree.
5293
5294 2019-04-19  Tom Tromey  <tom@tromey.com>
5295
5296         * symfile.c (reread_symbols): Update.
5297         * objfiles.c (objfile_register_static_link)
5298         (objfile_lookup_static_link): Update
5299         (~objfile) Don't delete static_links.
5300         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5301
5302 2019-04-19  Tom Tromey  <tom@tromey.com>
5303
5304         * type-stack.h (struct type_stack) <insert>: Constify string.
5305         * type-stack.c (type_stack::insert): Constify string.
5306         * gdbtypes.h (lookup_template_type): Update.
5307         (address_space_name_to_int): Update.
5308         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5309         const.
5310         (lookup_template_type): Make name const.
5311         * c-exp.y: Update rules.
5312         (lex_one_token, classify_name, classify_inner_name)
5313         (c_print_token): Update.
5314         * p-exp.y: Update rules.
5315         (yylex): Update.
5316         * f-exp.y: Update rules.
5317         (yylex): Update.
5318         * d-exp.y: Update rules.
5319         (lex_one_token, classify_name, classify_inner_name): Update.
5320         * parse.c (write_dollar_variable, copy_name): Return std::string.
5321         * parser-defs.h (copy_name): Change return type.
5322         * m2-exp.y: Update rules.
5323         (yylex): Update.
5324         * go-exp.y (lex_one_token): Update.
5325         Update rules.
5326         (classify_unsafe_function, classify_packaged_name)
5327         (classify_name, yylex): Update.
5328
5329 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5330
5331         * configure.ac: add --enable-source-highlight switch.
5332         * configure: Regenerate.
5333         * top.c (print_gdb_version): plumb --enable-source-highlight
5334         status to "show configuration".
5335
5336 2019-04-19  Tom Tromey  <tromey@adacore.com>
5337
5338         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5339         Check ADA_TYPE_P.
5340         (empty_record, ada_template_to_fixed_record_type_1)
5341         (template_to_static_fixed_type)
5342         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5343         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5344         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5345         macros.
5346
5347 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5348
5349         PR symtab/24423:
5350         * source.c (print_source_lines_base): Advance "iter" when a
5351         control character is seen.
5352
5353 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5354
5355         * inferior.h (struct infcall_suspend_state_deleter):
5356         Catch exception in destructor to avoid crash.
5357
5358 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5359
5360         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5361         close to the add_com "shell".
5362
5363 2019-04-18  Tom Tromey  <tromey@adacore.com>
5364
5365         * process-stratum-target.h (class process_stratum_target)
5366         <stratum>: Add "final".
5367
5368 2019-04-17  Tom Tromey  <tromey@adacore.com>
5369
5370         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5371         against nullptr before use.
5372
5373 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5374
5375         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5376
5377 2019-04-17  Jim Wilson  <jimw@sifive.com>
5378             Andrew Burgess  <andrew.burgess@embecosm.com>
5379
5380         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5381         code read might fail, assume 4-byte breakpoint in that case.
5382
5383 2019-04-15  Leszek Swirski  <leszeks@google.com>
5384
5385         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5386         rather than a hand-rolled POD check when checking for forced MEMORY
5387         classification.
5388
5389 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5390
5391         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5392         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5393         function.
5394         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5395         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5396         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5397         declaration.
5398
5399 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5400
5401         * aarch64-linux-nat.c
5402         (aarch64_linux_nat_target::thread_architecture): Add override.
5403         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5404         each VQ.
5405
5406 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5407
5408         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5409
5410 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5411
5412         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5413         target types of size 96-bits, add some additional comments, and
5414         check that the builtin type we found was the correct size.
5415
5416 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5417
5418         * utils.c (prompt_for_continue): Don't restore the styling at the
5419         end, as applied_style has the wrong value.  This fixes styling in
5420         long lists of file names that are interrupted by the "Continue?"
5421         prompt.
5422
5423 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5424
5425         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5426         * c-lang.c (c_language_defn): Likewise.
5427         (cplus_language_defn): Likewise.
5428         (asm_language_defn): Likewise.
5429         (minimal_language_defn): Likewise.
5430         * d-lang.c (d_language_defn): Likewise.
5431         * f-lang.c (f_language_defn): Likewise.
5432         * go-lang.c (go_language_defn): Likewise.
5433         * language.c (unknown_language_defn): Likewise.
5434         (auto_language_defn): Likewise.
5435         * language.h (struct language_defn): Remove la_magic field.
5436         (LANG_MAGIC): Delete.
5437         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5438         * objc-lang.c (objc_language_defn): Likewise.
5439         * opencl-lang.c (opencl_language_defn): Likewise.
5440         * p-lang.c (pascal_language_defn): Likewise.
5441         * rust-lang.c (rust_language_defn): Likewise.
5442
5443 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5444
5445         * riscv-tdep.c (riscv_type_align): New function.
5446         (riscv_type_alignment): Delete.
5447         (riscv_arg_location): Use 'type_align'.
5448         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5449
5450 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5451
5452         * gdbtypes.c (type_align): A struct with no non-static fields also
5453         has alignment of 1.
5454
5455 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5456
5457         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5458         component to 0.
5459         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5460         member.
5461         (riscv_struct_info::analyse): New implementation using new
5462         analyse_inner member function.
5463         (riscv_struct_info::field_offset): New member function.
5464         (riscv_struct_info::m_offsets): New member variable.
5465         (riscv_struct_info::analyse_inner): New private member function,
5466         takes the old implementation of riscv_struct_info::analyse but
5467         extended to track field offsets.
5468         (riscv_call_arg_struct): Update the struct folding special cases
5469         to handle cases where empty C++ structs, which are non-zero
5470         length, are found.
5471         (riscv_arg_location): Initialise the length of each location, a
5472         non-zero length now indicates the location is in use.
5473         (riscv_push_dummy_call): Allow for the first location having a
5474         non-zero offset when setting up arguments.
5475         (riscv_return_value): Likewise, but for return values.
5476
5477 2019-04-11  Tom Tromey  <tromey@adacore.com>
5478
5479         * utils.c (internal_vproblem): Make "msg" const.
5480
5481 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5482
5483         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5484         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5485         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5486         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5487
5488 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5489
5490         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5491         function.
5492         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5493         of amd64_collect_native_gregset.
5494         (amd64_linux_nat_target::store_registers): Likewise.
5495
5496 2019-04-10  Tom Tromey  <tom@tromey.com>
5497
5498         * symtab.c (lookup_global_symbol_from_objfile)
5499         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5500         * objfiles.h (class separate_debug_iterator): New.
5501         (class separate_debug_range): New.
5502         (struct objfile) <separate_debug_objfiles>: New method.
5503         (objfile_separate_debug_iterate): Don't declare.
5504         * objfiles.c (separate_debug_iterator::operator++): Rename from
5505         objfile_separate_debug_iterate.
5506         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5507         iterator.
5508         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5509         iterator.
5510
5511 2019-04-10  Tom Tromey  <tom@tromey.com>
5512
5513         * symfile.c (reread_symbols): Remove old comment.
5514         * objfiles.c (free_all_objfiles): Fix a typo.
5515
5516 2019-04-10  Tom Tromey  <tom@tromey.com>
5517
5518         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5519         * minsyms.c (lookup_minimal_symbol): Use foreach.
5520         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5521         (lookup_minimal_symbol_solib_trampoline): Likewise.
5522         * symfile.c (reread_symbols): Use foreach.
5523
5524 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5525             Tom Tromey  <tromey@adacore.com>
5526
5527         PR rust/24414:
5528         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5529         (rust_lex_int_test): Change "value" to be LONGEST.
5530         (rust_lex_tests): Add test for long integer literal.
5531
5532 2019-04-09  Tom Tromey  <tromey@adacore.com>
5533
5534         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5535         to bool.
5536         (extended_remote_target::attach): Update.
5537         (remote_target::remote_notice_new_inferior): Update.
5538         (remote_target::add_current_inferior_and_thread): Update.
5539         * inferior.c (exit_inferior_1): Use "false".
5540         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5541
5542 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5543
5544         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5545         the "start" command.
5546
5547 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5548
5549         * python/py-inferior.c (infpy_thread_from_thread_handle):
5550         Adjust comments to reflect renaming of thread_from_thread_handle
5551         to thread_from_handle.  Adjust keywords.  Fix type error message.
5552         (inferior_object_methods): Add thread_from_handle.  Retain
5553         thread_from_thread_handle, but mark it as deprecated.
5554
5555 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5556
5557         * gdbthread.h (find_thread_by_handle): Revise declaration.
5558         * thread.c (find_thread_by_handle): Likewise.  Adjust
5559         implementation too.
5560         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5561         support for buffer objects as handles.
5562
5563 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5564
5565         * python/py-infthread.c (thpy_thread_handle): New function.
5566         (thread_object_methods): Register thpy_thread_handle.
5567
5568 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5569
5570         * gdbthread.h (thread_to_thread_handle): Declare.
5571         * thread.c (gdbtypes.h): Include.
5572         (thread_to_thread_handle): New function.
5573
5574         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5575         (target_thread_info_to_thread_handle): Declare.
5576         * target.c (target_thread_info_to_thread_handle): New function.
5577         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5578         * target-delegates.c: Regenerate.
5579
5580         * linux-thread-db.c (class thread_db_target): Add method
5581         thread_info_to_thread_handle.
5582         (thread_db_target::thread_info_to_thread_handle): Define.
5583         * remote.c (class remote_target): Add new method
5584         thread_info_to_thread_handle.
5585         (remote_target::thread_info_to_thread_handle): Define.
5586
5587 2019-04-08  Pedro Alves  <palves@redhat.com>
5588
5589         * common/common-exceptions.c (throw_exception): Don't create
5590         named object to throw; throw directly.
5591         (throw_it): Likewise.  Don't initialize gdb_exception::message
5592         here, with new; pass FMT and AP to the ctor instead.
5593         * common/common-exceptions.h: Include <string>.
5594         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5595         const char *, va_list)): New ctor.  Use std::make_shared.
5596         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5597         errors)): Delete.
5598         (gdb_exception_error::gdb_exception_error(enum errors, const char
5599         *, va_list)): New.
5600         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5601         Add assertion.
5602         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5603         errors)): Delete.
5604         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5605         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5606         Add assertion.
5607
5608 2019-04-08  Tom Tromey  <tom@tromey.com>
5609
5610         * valops.c (value_rtti_indirect_type): Replace throw_exception
5611         with throw.
5612         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5613         with throw.
5614         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5615         throw.
5616         * target.c (target_translate_tls_address): Replace throw_exception
5617         with throw.
5618         * stack.c (frame_apply_command_count): Replace throw_exception
5619         with throw.
5620         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5621         throw.
5622         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5623         with throw.
5624         * rs6000-tdep.c (rs6000_frame_cache)
5625         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5626         * remote.c: Replace throw_exception with throw.
5627         * record-full.c (record_full_message, record_full_wait_1)
5628         (record_full_restore): Replace throw_exception with throw.
5629         * record-btrace.c:
5630         (get_thread_current_frame_id, record_btrace_start_replaying)
5631         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5632         (cmd_record_btrace_start): Replace throw_exception with throw.
5633         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5634         throw.
5635         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5636         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5637         * linespec.c:
5638         (find_linespec_symbols): Replace throw_exception with throw.
5639         * infrun.c (displaced_step_prepare, resume): Replace
5640         throw_exception with throw.
5641         * infcmd.c (post_create_inferior): Replace throw_exception with
5642         throw.
5643         * inf-loop.c (inferior_event_handler): Replace throw_exception
5644         with throw.
5645         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5646         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5647         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5648         (get_prev_frame_always, get_frame_pc_if_available)
5649         (get_frame_address_in_block_if_available, get_frame_language):
5650         Replace throw_exception with throw.
5651         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5652         throw_exception with throw.
5653         * eval.c (fetch_subexp_value, evaluate_var_value)
5654         (evaluate_funcall, evaluate_subexp_standard): Replace
5655         throw_exception with throw.
5656         * dwarf2loc.c (call_site_find_chain)
5657         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5658         Replace throw_exception with throw.
5659         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5660         with throw.
5661         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5662         throw.
5663         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5664         * completer.c (complete_line_internal): Replace throw_exception
5665         with throw.
5666         * compile/compile-object-run.c (compile_object_run): Replace
5667         throw_exception with throw.
5668         * cli/cli-script.c (process_next_line): Replace throw_exception
5669         with throw.
5670         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5671         (btrace_enable, btrace_maint_update_pt_packets): Replace
5672         throw_exception with throw.
5673         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5674         throw_exception with throw.
5675         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5676         throw_exception with throw.
5677         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5678         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5679         * aarch64-tdep.c (aarch64_make_prologue_cache)
5680         (aarch64_make_stub_cache): Replace throw_exception with throw.
5681
5682 2019-04-08  Tom Tromey  <tom@tromey.com>
5683
5684         * common/common-exceptions.c (throw_exception): Rename from
5685         throw_exception_cxx.  Remove old copy.  Make argument const.
5686         (throw_it): Create and throw exception objects directly.
5687         * common/common-exceptions.h (throw_exception): Make argument
5688         const.
5689         (struct gdb_exception_error): Add constructor.
5690         (struct gdb_exception_quit): Add constructor.
5691
5692 2019-04-08  Tom Tromey  <tom@tromey.com>
5693
5694         * common/common-exceptions.h (exception_rethrow): Don't declare.
5695         (TRY_SJLJ): Update comment.
5696         (TRY, CATCH, END_CATCH): Remove.
5697         * common/common-exceptions.c (exception_rethrow): Remove.
5698
5699 2019-04-08  Tom Tromey  <tom@tromey.com>
5700
5701         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5702         Remove.
5703         (gdb_exception_error): Rename from
5704         gdb_exception_RETURN_MASK_ERROR.
5705         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5706         (gdb_quit_bad_alloc): Update.
5707         * aarch64-tdep.c: Update.
5708         * ada-lang.c: Update.
5709         * ada-typeprint.c: Update.
5710         * ada-valprint.c: Update.
5711         * amd64-tdep.c: Update.
5712         * arch-utils.c: Update.
5713         * break-catch-throw.c: Update.
5714         * breakpoint.c: Update.
5715         * btrace.c: Update.
5716         * c-varobj.c: Update.
5717         * cli/cli-cmds.c: Update.
5718         * cli/cli-interp.c: Update.
5719         * cli/cli-script.c: Update.
5720         * common/common-exceptions.c: Update.
5721         * common/new-op.c: Update.
5722         * common/selftest.c: Update.
5723         * compile/compile-c-symbols.c: Update.
5724         * compile/compile-cplus-symbols.c: Update.
5725         * compile/compile-object-load.c: Update.
5726         * compile/compile-object-run.c: Update.
5727         * completer.c: Update.
5728         * corelow.c: Update.
5729         * cp-abi.c: Update.
5730         * cp-support.c: Update.
5731         * cp-valprint.c: Update.
5732         * darwin-nat.c: Update.
5733         * disasm-selftests.c: Update.
5734         * dtrace-probe.c: Update.
5735         * dwarf-index-cache.c: Update.
5736         * dwarf-index-write.c: Update.
5737         * dwarf2-frame-tailcall.c: Update.
5738         * dwarf2-frame.c: Update.
5739         * dwarf2loc.c: Update.
5740         * dwarf2read.c: Update.
5741         * eval.c: Update.
5742         * event-loop.c: Update.
5743         * event-top.c: Update.
5744         * exec.c: Update.
5745         * f-valprint.c: Update.
5746         * fbsd-tdep.c: Update.
5747         * frame-unwind.c: Update.
5748         * frame.c: Update.
5749         * gdbtypes.c: Update.
5750         * gnu-v3-abi.c: Update.
5751         * guile/guile-internal.h: Update.
5752         * guile/scm-block.c: Update.
5753         * guile/scm-breakpoint.c: Update.
5754         * guile/scm-cmd.c: Update.
5755         * guile/scm-disasm.c: Update.
5756         * guile/scm-frame.c: Update.
5757         * guile/scm-lazy-string.c: Update.
5758         * guile/scm-math.c: Update.
5759         * guile/scm-param.c: Update.
5760         * guile/scm-ports.c: Update.
5761         * guile/scm-pretty-print.c: Update.
5762         * guile/scm-symbol.c: Update.
5763         * guile/scm-symtab.c: Update.
5764         * guile/scm-type.c: Update.
5765         * guile/scm-value.c: Update.
5766         * i386-linux-tdep.c: Update.
5767         * i386-tdep.c: Update.
5768         * inf-loop.c: Update.
5769         * infcall.c: Update.
5770         * infcmd.c: Update.
5771         * infrun.c: Update.
5772         * jit.c: Update.
5773         * language.c: Update.
5774         * linespec.c: Update.
5775         * linux-fork.c: Update.
5776         * linux-nat.c: Update.
5777         * linux-tdep.c: Update.
5778         * linux-thread-db.c: Update.
5779         * main.c: Update.
5780         * mi/mi-cmd-break.c: Update.
5781         * mi/mi-cmd-stack.c: Update.
5782         * mi/mi-interp.c: Update.
5783         * mi/mi-main.c: Update.
5784         * objc-lang.c: Update.
5785         * p-valprint.c: Update.
5786         * parse.c: Update.
5787         * ppc-linux-tdep.c: Update.
5788         * printcmd.c: Update.
5789         * python/py-arch.c: Update.
5790         * python/py-breakpoint.c: Update.
5791         * python/py-cmd.c: Update.
5792         * python/py-finishbreakpoint.c: Update.
5793         * python/py-frame.c: Update.
5794         * python/py-framefilter.c: Update.
5795         * python/py-gdb-readline.c: Update.
5796         * python/py-inferior.c: Update.
5797         * python/py-infthread.c: Update.
5798         * python/py-lazy-string.c: Update.
5799         * python/py-linetable.c: Update.
5800         * python/py-objfile.c: Update.
5801         * python/py-param.c: Update.
5802         * python/py-prettyprint.c: Update.
5803         * python/py-progspace.c: Update.
5804         * python/py-record-btrace.c: Update.
5805         * python/py-record.c: Update.
5806         * python/py-symbol.c: Update.
5807         * python/py-type.c: Update.
5808         * python/py-unwind.c: Update.
5809         * python/py-utils.c: Update.
5810         * python/py-value.c: Update.
5811         * python/python.c: Update.
5812         * record-btrace.c: Update.
5813         * record-full.c: Update.
5814         * remote-fileio.c: Update.
5815         * remote.c: Update.
5816         * riscv-tdep.c: Update.
5817         * rs6000-aix-tdep.c: Update.
5818         * rs6000-tdep.c: Update.
5819         * rust-exp.y: Update.
5820         * rust-lang.c: Update.
5821         * s390-tdep.c: Update.
5822         * selftest-arch.c: Update.
5823         * solib-dsbt.c: Update.
5824         * solib-frv.c: Update.
5825         * solib-spu.c: Update.
5826         * solib-svr4.c: Update.
5827         * solib.c: Update.
5828         * sparc64-linux-tdep.c: Update.
5829         * stack.c: Update.
5830         * symfile-mem.c: Update.
5831         * symmisc.c: Update.
5832         * target.c: Update.
5833         * thread.c: Update.
5834         * top.c: Update.
5835         * tracefile-tfile.c: Update.
5836         * tui/tui.c: Update.
5837         * typeprint.c: Update.
5838         * unittests/cli-utils-selftests.c: Update.
5839         * unittests/parse-connection-spec-selftests.c: Update.
5840         * valops.c: Update.
5841         * valprint.c: Update.
5842         * value.c: Update.
5843         * varobj.c: Update.
5844         * windows-nat.c: Update.
5845         * x86-linux-nat.c: Update.
5846         * xml-support.c: Update.
5847
5848 2019-04-08  Tom Tromey  <tom@tromey.com>
5849
5850         * xml-support.c: Use C++ exception handling.
5851         * x86-linux-nat.c: Use C++ exception handling.
5852         * windows-nat.c: Use C++ exception handling.
5853         * varobj.c: Use C++ exception handling.
5854         * value.c: Use C++ exception handling.
5855         * valprint.c: Use C++ exception handling.
5856         * valops.c: Use C++ exception handling.
5857         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5858         handling.
5859         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5860         * typeprint.c: Use C++ exception handling.
5861         * tui/tui.c: Use C++ exception handling.
5862         * tracefile-tfile.c: Use C++ exception handling.
5863         * top.c: Use C++ exception handling.
5864         * thread.c: Use C++ exception handling.
5865         * target.c: Use C++ exception handling.
5866         * symmisc.c: Use C++ exception handling.
5867         * symfile-mem.c: Use C++ exception handling.
5868         * stack.c: Use C++ exception handling.
5869         * sparc64-linux-tdep.c: Use C++ exception handling.
5870         * solib.c: Use C++ exception handling.
5871         * solib-svr4.c: Use C++ exception handling.
5872         * solib-spu.c: Use C++ exception handling.
5873         * solib-frv.c: Use C++ exception handling.
5874         * solib-dsbt.c: Use C++ exception handling.
5875         * selftest-arch.c: Use C++ exception handling.
5876         * s390-tdep.c: Use C++ exception handling.
5877         * rust-lang.c: Use C++ exception handling.
5878         * rust-exp.y: Use C++ exception handling.
5879         * rs6000-tdep.c: Use C++ exception handling.
5880         * rs6000-aix-tdep.c: Use C++ exception handling.
5881         * riscv-tdep.c: Use C++ exception handling.
5882         * remote.c: Use C++ exception handling.
5883         * remote-fileio.c: Use C++ exception handling.
5884         * record-full.c: Use C++ exception handling.
5885         * record-btrace.c: Use C++ exception handling.
5886         * python/python.c: Use C++ exception handling.
5887         * python/py-value.c: Use C++ exception handling.
5888         * python/py-utils.c: Use C++ exception handling.
5889         * python/py-unwind.c: Use C++ exception handling.
5890         * python/py-type.c: Use C++ exception handling.
5891         * python/py-symbol.c: Use C++ exception handling.
5892         * python/py-record.c: Use C++ exception handling.
5893         * python/py-record-btrace.c: Use C++ exception handling.
5894         * python/py-progspace.c: Use C++ exception handling.
5895         * python/py-prettyprint.c: Use C++ exception handling.
5896         * python/py-param.c: Use C++ exception handling.
5897         * python/py-objfile.c: Use C++ exception handling.
5898         * python/py-linetable.c: Use C++ exception handling.
5899         * python/py-lazy-string.c: Use C++ exception handling.
5900         * python/py-infthread.c: Use C++ exception handling.
5901         * python/py-inferior.c: Use C++ exception handling.
5902         * python/py-gdb-readline.c: Use C++ exception handling.
5903         * python/py-framefilter.c: Use C++ exception handling.
5904         * python/py-frame.c: Use C++ exception handling.
5905         * python/py-finishbreakpoint.c: Use C++ exception handling.
5906         * python/py-cmd.c: Use C++ exception handling.
5907         * python/py-breakpoint.c: Use C++ exception handling.
5908         * python/py-arch.c: Use C++ exception handling.
5909         * printcmd.c: Use C++ exception handling.
5910         * ppc-linux-tdep.c: Use C++ exception handling.
5911         * parse.c: Use C++ exception handling.
5912         * p-valprint.c: Use C++ exception handling.
5913         * objc-lang.c: Use C++ exception handling.
5914         * mi/mi-main.c: Use C++ exception handling.
5915         * mi/mi-interp.c: Use C++ exception handling.
5916         * mi/mi-cmd-stack.c: Use C++ exception handling.
5917         * mi/mi-cmd-break.c: Use C++ exception handling.
5918         * main.c: Use C++ exception handling.
5919         * linux-thread-db.c: Use C++ exception handling.
5920         * linux-tdep.c: Use C++ exception handling.
5921         * linux-nat.c: Use C++ exception handling.
5922         * linux-fork.c: Use C++ exception handling.
5923         * linespec.c: Use C++ exception handling.
5924         * language.c: Use C++ exception handling.
5925         * jit.c: Use C++ exception handling.
5926         * infrun.c: Use C++ exception handling.
5927         * infcmd.c: Use C++ exception handling.
5928         * infcall.c: Use C++ exception handling.
5929         * inf-loop.c: Use C++ exception handling.
5930         * i386-tdep.c: Use C++ exception handling.
5931         * i386-linux-tdep.c: Use C++ exception handling.
5932         * guile/scm-value.c: Use C++ exception handling.
5933         * guile/scm-type.c: Use C++ exception handling.
5934         * guile/scm-symtab.c: Use C++ exception handling.
5935         * guile/scm-symbol.c: Use C++ exception handling.
5936         * guile/scm-pretty-print.c: Use C++ exception handling.
5937         * guile/scm-ports.c: Use C++ exception handling.
5938         * guile/scm-param.c: Use C++ exception handling.
5939         * guile/scm-math.c: Use C++ exception handling.
5940         * guile/scm-lazy-string.c: Use C++ exception handling.
5941         * guile/scm-frame.c: Use C++ exception handling.
5942         * guile/scm-disasm.c: Use C++ exception handling.
5943         * guile/scm-cmd.c: Use C++ exception handling.
5944         * guile/scm-breakpoint.c: Use C++ exception handling.
5945         * guile/scm-block.c: Use C++ exception handling.
5946         * guile/guile-internal.h: Use C++ exception handling.
5947         * gnu-v3-abi.c: Use C++ exception handling.
5948         * gdbtypes.c: Use C++ exception handling.
5949         * frame.c: Use C++ exception handling.
5950         * frame-unwind.c: Use C++ exception handling.
5951         * fbsd-tdep.c: Use C++ exception handling.
5952         * f-valprint.c: Use C++ exception handling.
5953         * exec.c: Use C++ exception handling.
5954         * event-top.c: Use C++ exception handling.
5955         * event-loop.c: Use C++ exception handling.
5956         * eval.c: Use C++ exception handling.
5957         * dwarf2read.c: Use C++ exception handling.
5958         * dwarf2loc.c: Use C++ exception handling.
5959         * dwarf2-frame.c: Use C++ exception handling.
5960         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5961         * dwarf-index-write.c: Use C++ exception handling.
5962         * dwarf-index-cache.c: Use C++ exception handling.
5963         * dtrace-probe.c: Use C++ exception handling.
5964         * disasm-selftests.c: Use C++ exception handling.
5965         * darwin-nat.c: Use C++ exception handling.
5966         * cp-valprint.c: Use C++ exception handling.
5967         * cp-support.c: Use C++ exception handling.
5968         * cp-abi.c: Use C++ exception handling.
5969         * corelow.c: Use C++ exception handling.
5970         * completer.c: Use C++ exception handling.
5971         * compile/compile-object-run.c: Use C++ exception handling.
5972         * compile/compile-object-load.c: Use C++ exception handling.
5973         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5974         * compile/compile-c-symbols.c: Use C++ exception handling.
5975         * common/selftest.c: Use C++ exception handling.
5976         * common/new-op.c: Use C++ exception handling.
5977         * cli/cli-script.c: Use C++ exception handling.
5978         * cli/cli-interp.c: Use C++ exception handling.
5979         * cli/cli-cmds.c: Use C++ exception handling.
5980         * c-varobj.c: Use C++ exception handling.
5981         * btrace.c: Use C++ exception handling.
5982         * breakpoint.c: Use C++ exception handling.
5983         * break-catch-throw.c: Use C++ exception handling.
5984         * arch-utils.c: Use C++ exception handling.
5985         * amd64-tdep.c: Use C++ exception handling.
5986         * ada-valprint.c: Use C++ exception handling.
5987         * ada-typeprint.c: Use C++ exception handling.
5988         * ada-lang.c: Use C++ exception handling.
5989         * aarch64-tdep.c: Use C++ exception handling.
5990
5991 2019-04-08  Tom Tromey  <tom@tromey.com>
5992
5993         * xml-support.c (gdb_xml_parser::parse): Update.
5994         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5995         * value.c (show_convenience): Update.
5996         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5997         (test_parse_flags_qcs): Update.
5998         * thread.c (thr_try_catch_cmd): Update.
5999         * target.c (target_translate_tls_address): Update.
6000         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6001         (info_frame_command_core, frame_apply_command_count): Update.
6002         * rust-exp.y (rust_lex_exception_test): Update.
6003         * riscv-tdep.c (riscv_print_one_register_info): Update.
6004         * remote.c (remote_target::enable_btrace): Update.
6005         * record-btrace.c (record_btrace_enable_warn): Update.
6006         * python/py-utils.c (gdbpy_convert_exception): Update.
6007         * printcmd.c (do_one_display, print_variable_and_value): Update.
6008         * mi/mi-main.c (mi_print_exception): Update.
6009         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6010         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6011         * linux-nat.c (linux_nat_target::attach): Update.
6012         * linux-fork.c (class scoped_switch_fork_info): Update.
6013         * infrun.c (displaced_step_prepare): Update.
6014         * infcall.c (call_function_by_hand_dummy): Update.
6015         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6016         * gnu-v3-abi.c (print_one_vtable): Update.
6017         * frame.c (get_prev_frame_always): Update.
6018         * f-valprint.c (info_common_command_for_block): Update.
6019         * exec.c (try_open_exec_file): Update.
6020         * exceptions.c (print_exception, exception_print)
6021         (exception_fprintf, exception_print_same): Update.
6022         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6023         * dwarf-index-cache.c (index_cache::store)
6024         (index_cache::lookup_gdb_index): Update.
6025         * darwin-nat.c (maybe_cache_shell): Update.
6026         * cp-valprint.c (cp_print_value_fields): Update.
6027         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6028         (gcc_cplus_symbol_address): Update.
6029         * compile/compile-c-symbols.c (gcc_convert_symbol)
6030         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6031         * common/selftest.c: Update.
6032         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6033         a std::string.
6034         (exception_try_scope_entry, exception_try_scope_exit): Don't
6035         declare.
6036         (struct exception_try_scope): Remove.
6037         (TRY): Don't use exception_try_scope.
6038         (struct gdb_exception): Add constructor, operator=.
6039         <what>: New method.
6040         (struct gdb_exception_RETURN_MASK_ALL)
6041         (struct gdb_exception_RETURN_MASK_ERROR)
6042         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6043         (struct gdb_quit_bad_alloc): Update.
6044         * common/common-exceptions.c (exception_none): Change
6045         initializer.
6046         (struct catcher) <state, exception>: Initialize inline.
6047         <prev>: Remove member.
6048         (current_catcher): Remove.
6049         (catchers): New global.
6050         (exceptions_state_mc_init): Simplify.
6051         (catcher_pop): Remove.
6052         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6053         (try_scope_depth, exception_try_scope_entry)
6054         (exception_try_scope_exit): Remove.
6055         (throw_exception_sjlj): Update.
6056         (exception_messages, exception_messages_size): Remove.
6057         (throw_it): Simplify.
6058         (gdb_exception_sliced_copy): Remove.
6059         (throw_exception_cxx): Update.
6060         * cli/cli-script.c (script_from_file): Update.
6061         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6062         Update.
6063         * ada-valprint.c (ada_val_print): Update.
6064         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6065         (create_excep_cond_exprs): Update.
6066
6067 2019-04-08  Tom Tromey  <tom@tromey.com>
6068
6069         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6070         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6071         (TRY, CATCH, END_CATCH): Remove some definitions.
6072         * common/common-exceptions.c: Don't use GDB_XCPT.
6073         (catcher_list_size): Remove.
6074         (throw_exception, throw_it): Simplify.
6075
6076 2019-04-05  Tom Tromey  <tom@tromey.com>
6077
6078         Revert the header-sorting patch.
6079         * ft32-tdep.c: Revert.
6080         * frv-tdep.c: Revert.
6081         * frv-linux-tdep.c: Revert.
6082         * frame.c: Revert.
6083         * frame-unwind.c: Revert.
6084         * frame-base.c: Revert.
6085         * fork-child.c: Revert.
6086         * findvar.c: Revert.
6087         * findcmd.c: Revert.
6088         * filesystem.c: Revert.
6089         * filename-seen-cache.h: Revert.
6090         * filename-seen-cache.c: Revert.
6091         * fbsd-tdep.c: Revert.
6092         * fbsd-nat.h: Revert.
6093         * fbsd-nat.c: Revert.
6094         * f-valprint.c: Revert.
6095         * f-typeprint.c: Revert.
6096         * f-lang.c: Revert.
6097         * extension.h: Revert.
6098         * extension.c: Revert.
6099         * extension-priv.h: Revert.
6100         * expprint.c: Revert.
6101         * exec.h: Revert.
6102         * exec.c: Revert.
6103         * exceptions.c: Revert.
6104         * event-top.c: Revert.
6105         * event-loop.c: Revert.
6106         * eval.c: Revert.
6107         * elfread.c: Revert.
6108         * dwarf2read.h: Revert.
6109         * dwarf2read.c: Revert.
6110         * dwarf2loc.c: Revert.
6111         * dwarf2expr.h: Revert.
6112         * dwarf2expr.c: Revert.
6113         * dwarf2-frame.c: Revert.
6114         * dwarf2-frame-tailcall.c: Revert.
6115         * dwarf-index-write.h: Revert.
6116         * dwarf-index-write.c: Revert.
6117         * dwarf-index-common.c: Revert.
6118         * dwarf-index-cache.h: Revert.
6119         * dwarf-index-cache.c: Revert.
6120         * dummy-frame.c: Revert.
6121         * dtrace-probe.c: Revert.
6122         * disasm.h: Revert.
6123         * disasm.c: Revert.
6124         * disasm-selftests.c: Revert.
6125         * dictionary.c: Revert.
6126         * dicos-tdep.c: Revert.
6127         * demangle.c: Revert.
6128         * dcache.h: Revert.
6129         * dcache.c: Revert.
6130         * darwin-nat.h: Revert.
6131         * darwin-nat.c: Revert.
6132         * darwin-nat-info.c: Revert.
6133         * d-valprint.c: Revert.
6134         * d-namespace.c: Revert.
6135         * d-lang.c: Revert.
6136         * ctf.c: Revert.
6137         * csky-tdep.c: Revert.
6138         * csky-linux-tdep.c: Revert.
6139         * cris-tdep.c: Revert.
6140         * cris-linux-tdep.c: Revert.
6141         * cp-valprint.c: Revert.
6142         * cp-support.c: Revert.
6143         * cp-namespace.c: Revert.
6144         * cp-abi.c: Revert.
6145         * corelow.c: Revert.
6146         * corefile.c: Revert.
6147         * continuations.c: Revert.
6148         * completer.h: Revert.
6149         * completer.c: Revert.
6150         * complaints.c: Revert.
6151         * coffread.c: Revert.
6152         * coff-pe-read.c: Revert.
6153         * cli-out.h: Revert.
6154         * cli-out.c: Revert.
6155         * charset.c: Revert.
6156         * c-varobj.c: Revert.
6157         * c-valprint.c: Revert.
6158         * c-typeprint.c: Revert.
6159         * c-lang.c: Revert.
6160         * buildsym.c: Revert.
6161         * buildsym-legacy.c: Revert.
6162         * build-id.h: Revert.
6163         * build-id.c: Revert.
6164         * btrace.c: Revert.
6165         * bsd-uthread.c: Revert.
6166         * breakpoint.h: Revert.
6167         * breakpoint.c: Revert.
6168         * break-catch-throw.c: Revert.
6169         * break-catch-syscall.c: Revert.
6170         * break-catch-sig.c: Revert.
6171         * blockframe.c: Revert.
6172         * block.c: Revert.
6173         * bfin-tdep.c: Revert.
6174         * bfin-linux-tdep.c: Revert.
6175         * bfd-target.c: Revert.
6176         * bcache.c: Revert.
6177         * ax-general.c: Revert.
6178         * ax-gdb.h: Revert.
6179         * ax-gdb.c: Revert.
6180         * avr-tdep.c: Revert.
6181         * auxv.c: Revert.
6182         * auto-load.c: Revert.
6183         * arm-wince-tdep.c: Revert.
6184         * arm-tdep.c: Revert.
6185         * arm-symbian-tdep.c: Revert.
6186         * arm-pikeos-tdep.c: Revert.
6187         * arm-obsd-tdep.c: Revert.
6188         * arm-nbsd-tdep.c: Revert.
6189         * arm-nbsd-nat.c: Revert.
6190         * arm-linux-tdep.c: Revert.
6191         * arm-linux-nat.c: Revert.
6192         * arm-fbsd-tdep.c: Revert.
6193         * arm-fbsd-nat.c: Revert.
6194         * arm-bsd-tdep.c: Revert.
6195         * arch-utils.c: Revert.
6196         * arc-tdep.c: Revert.
6197         * arc-newlib-tdep.c: Revert.
6198         * annotate.h: Revert.
6199         * annotate.c: Revert.
6200         * amd64-windows-tdep.c: Revert.
6201         * amd64-windows-nat.c: Revert.
6202         * amd64-tdep.c: Revert.
6203         * amd64-sol2-tdep.c: Revert.
6204         * amd64-obsd-tdep.c: Revert.
6205         * amd64-obsd-nat.c: Revert.
6206         * amd64-nbsd-tdep.c: Revert.
6207         * amd64-nbsd-nat.c: Revert.
6208         * amd64-nat.c: Revert.
6209         * amd64-linux-tdep.c: Revert.
6210         * amd64-linux-nat.c: Revert.
6211         * amd64-fbsd-tdep.c: Revert.
6212         * amd64-fbsd-nat.c: Revert.
6213         * amd64-dicos-tdep.c: Revert.
6214         * amd64-darwin-tdep.c: Revert.
6215         * amd64-bsd-nat.c: Revert.
6216         * alpha-tdep.c: Revert.
6217         * alpha-obsd-tdep.c: Revert.
6218         * alpha-nbsd-tdep.c: Revert.
6219         * alpha-mdebug-tdep.c: Revert.
6220         * alpha-linux-tdep.c: Revert.
6221         * alpha-linux-nat.c: Revert.
6222         * alpha-bsd-tdep.c: Revert.
6223         * alpha-bsd-nat.c: Revert.
6224         * aix-thread.c: Revert.
6225         * agent.c: Revert.
6226         * addrmap.c: Revert.
6227         * ada-varobj.c: Revert.
6228         * ada-valprint.c: Revert.
6229         * ada-typeprint.c: Revert.
6230         * ada-tasks.c: Revert.
6231         * ada-lang.c: Revert.
6232         * aarch64-tdep.c: Revert.
6233         * aarch64-ravenscar-thread.c: Revert.
6234         * aarch64-newlib-tdep.c: Revert.
6235         * aarch64-linux-tdep.c: Revert.
6236         * aarch64-linux-nat.c: Revert.
6237         * aarch64-fbsd-tdep.c: Revert.
6238         * aarch64-fbsd-nat.c: Revert.
6239         * aarch32-linux-nat.c: Revert.
6240
6241 2019-04-05  Tom Tromey  <tom@tromey.com>
6242
6243         * ft32-tdep.c: Sort headers.
6244         * frv-tdep.c: Sort headers.
6245         * frv-linux-tdep.c: Sort headers.
6246         * frame.c: Sort headers.
6247         * frame-unwind.c: Sort headers.
6248         * frame-base.c: Sort headers.
6249         * fork-child.c: Sort headers.
6250         * findvar.c: Sort headers.
6251         * findcmd.c: Sort headers.
6252         * filesystem.c: Sort headers.
6253         * filename-seen-cache.h: Sort headers.
6254         * filename-seen-cache.c: Sort headers.
6255         * fbsd-tdep.c: Sort headers.
6256         * fbsd-nat.h: Sort headers.
6257         * fbsd-nat.c: Sort headers.
6258         * f-valprint.c: Sort headers.
6259         * f-typeprint.c: Sort headers.
6260         * f-lang.c: Sort headers.
6261         * extension.h: Sort headers.
6262         * extension.c: Sort headers.
6263         * extension-priv.h: Sort headers.
6264         * expprint.c: Sort headers.
6265         * exec.h: Sort headers.
6266         * exec.c: Sort headers.
6267         * exceptions.c: Sort headers.
6268         * event-top.c: Sort headers.
6269         * event-loop.c: Sort headers.
6270         * eval.c: Sort headers.
6271         * elfread.c: Sort headers.
6272         * dwarf2read.h: Sort headers.
6273         * dwarf2read.c: Sort headers.
6274         * dwarf2loc.c: Sort headers.
6275         * dwarf2expr.h: Sort headers.
6276         * dwarf2expr.c: Sort headers.
6277         * dwarf2-frame.c: Sort headers.
6278         * dwarf2-frame-tailcall.c: Sort headers.
6279         * dwarf-index-write.h: Sort headers.
6280         * dwarf-index-write.c: Sort headers.
6281         * dwarf-index-common.c: Sort headers.
6282         * dwarf-index-cache.h: Sort headers.
6283         * dwarf-index-cache.c: Sort headers.
6284         * dummy-frame.c: Sort headers.
6285         * dtrace-probe.c: Sort headers.
6286         * disasm.h: Sort headers.
6287         * disasm.c: Sort headers.
6288         * disasm-selftests.c: Sort headers.
6289         * dictionary.c: Sort headers.
6290         * dicos-tdep.c: Sort headers.
6291         * demangle.c: Sort headers.
6292         * dcache.h: Sort headers.
6293         * dcache.c: Sort headers.
6294         * darwin-nat.h: Sort headers.
6295         * darwin-nat.c: Sort headers.
6296         * darwin-nat-info.c: Sort headers.
6297         * d-valprint.c: Sort headers.
6298         * d-namespace.c: Sort headers.
6299         * d-lang.c: Sort headers.
6300         * ctf.c: Sort headers.
6301         * csky-tdep.c: Sort headers.
6302         * csky-linux-tdep.c: Sort headers.
6303         * cris-tdep.c: Sort headers.
6304         * cris-linux-tdep.c: Sort headers.
6305         * cp-valprint.c: Sort headers.
6306         * cp-support.c: Sort headers.
6307         * cp-namespace.c: Sort headers.
6308         * cp-abi.c: Sort headers.
6309         * corelow.c: Sort headers.
6310         * corefile.c: Sort headers.
6311         * continuations.c: Sort headers.
6312         * completer.h: Sort headers.
6313         * completer.c: Sort headers.
6314         * complaints.c: Sort headers.
6315         * coffread.c: Sort headers.
6316         * coff-pe-read.c: Sort headers.
6317         * cli-out.h: Sort headers.
6318         * cli-out.c: Sort headers.
6319         * charset.c: Sort headers.
6320         * c-varobj.c: Sort headers.
6321         * c-valprint.c: Sort headers.
6322         * c-typeprint.c: Sort headers.
6323         * c-lang.c: Sort headers.
6324         * buildsym.c: Sort headers.
6325         * buildsym-legacy.c: Sort headers.
6326         * build-id.h: Sort headers.
6327         * build-id.c: Sort headers.
6328         * btrace.c: Sort headers.
6329         * bsd-uthread.c: Sort headers.
6330         * breakpoint.h: Sort headers.
6331         * breakpoint.c: Sort headers.
6332         * break-catch-throw.c: Sort headers.
6333         * break-catch-syscall.c: Sort headers.
6334         * break-catch-sig.c: Sort headers.
6335         * blockframe.c: Sort headers.
6336         * block.c: Sort headers.
6337         * bfin-tdep.c: Sort headers.
6338         * bfin-linux-tdep.c: Sort headers.
6339         * bfd-target.c: Sort headers.
6340         * bcache.c: Sort headers.
6341         * ax-general.c: Sort headers.
6342         * ax-gdb.h: Sort headers.
6343         * ax-gdb.c: Sort headers.
6344         * avr-tdep.c: Sort headers.
6345         * auxv.c: Sort headers.
6346         * auto-load.c: Sort headers.
6347         * arm-wince-tdep.c: Sort headers.
6348         * arm-tdep.c: Sort headers.
6349         * arm-symbian-tdep.c: Sort headers.
6350         * arm-pikeos-tdep.c: Sort headers.
6351         * arm-obsd-tdep.c: Sort headers.
6352         * arm-nbsd-tdep.c: Sort headers.
6353         * arm-nbsd-nat.c: Sort headers.
6354         * arm-linux-tdep.c: Sort headers.
6355         * arm-linux-nat.c: Sort headers.
6356         * arm-fbsd-tdep.c: Sort headers.
6357         * arm-fbsd-nat.c: Sort headers.
6358         * arm-bsd-tdep.c: Sort headers.
6359         * arch-utils.c: Sort headers.
6360         * arc-tdep.c: Sort headers.
6361         * arc-newlib-tdep.c: Sort headers.
6362         * annotate.h: Sort headers.
6363         * annotate.c: Sort headers.
6364         * amd64-windows-tdep.c: Sort headers.
6365         * amd64-windows-nat.c: Sort headers.
6366         * amd64-tdep.c: Sort headers.
6367         * amd64-sol2-tdep.c: Sort headers.
6368         * amd64-obsd-tdep.c: Sort headers.
6369         * amd64-obsd-nat.c: Sort headers.
6370         * amd64-nbsd-tdep.c: Sort headers.
6371         * amd64-nbsd-nat.c: Sort headers.
6372         * amd64-nat.c: Sort headers.
6373         * amd64-linux-tdep.c: Sort headers.
6374         * amd64-linux-nat.c: Sort headers.
6375         * amd64-fbsd-tdep.c: Sort headers.
6376         * amd64-fbsd-nat.c: Sort headers.
6377         * amd64-dicos-tdep.c: Sort headers.
6378         * amd64-darwin-tdep.c: Sort headers.
6379         * amd64-bsd-nat.c: Sort headers.
6380         * alpha-tdep.c: Sort headers.
6381         * alpha-obsd-tdep.c: Sort headers.
6382         * alpha-nbsd-tdep.c: Sort headers.
6383         * alpha-mdebug-tdep.c: Sort headers.
6384         * alpha-linux-tdep.c: Sort headers.
6385         * alpha-linux-nat.c: Sort headers.
6386         * alpha-bsd-tdep.c: Sort headers.
6387         * alpha-bsd-nat.c: Sort headers.
6388         * aix-thread.c: Sort headers.
6389         * agent.c: Sort headers.
6390         * addrmap.c: Sort headers.
6391         * ada-varobj.c: Sort headers.
6392         * ada-valprint.c: Sort headers.
6393         * ada-typeprint.c: Sort headers.
6394         * ada-tasks.c: Sort headers.
6395         * ada-lang.c: Sort headers.
6396         * aarch64-tdep.c: Sort headers.
6397         * aarch64-ravenscar-thread.c: Sort headers.
6398         * aarch64-newlib-tdep.c: Sort headers.
6399         * aarch64-linux-tdep.c: Sort headers.
6400         * aarch64-linux-nat.c: Sort headers.
6401         * aarch64-fbsd-tdep.c: Sort headers.
6402         * aarch64-fbsd-nat.c: Sort headers.
6403         * aarch32-linux-nat.c: Sort headers.
6404
6405 2019-04-04  Tom Tromey  <tom@tromey.com>
6406
6407         * varobj.c (varobj_create): Update.
6408         * rust-exp.y (struct rust_parser) <update_innermost_block,
6409         lookup_symbol>: New methods.
6410         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6411         Rename.
6412         (rust_parser::rust_lookup_type)
6413         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6414         * printcmd.c (display_command, do_one_display): Update.
6415         * parser-defs.h (struct parser_state) <parser_state>: Add
6416         "tracker" parameter.
6417         (block_tracker): New member.
6418         (class innermost_block_tracker) <innermost_block_tracker>: Add
6419         "types" parameter.
6420         <reset>: Remove method.
6421         (innermost_block): Don't declare.
6422         (null_post_parser): Update.
6423         * parse.c (innermost_block): Remove global.
6424         (write_dollar_variable): Update.
6425         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6426         Remove "tracker_types" parameter.
6427         (parse_expression): Add "tracker" parameter.
6428         (parse_expression_for_completion): Update.
6429         (null_post_parser): Add "tracker" parameter.
6430         * p-exp.y: Update rules.
6431         * m2-exp.y: Update rules.
6432         * language.h (struct language_defn) <la_post_parser>: Add
6433         "tracker" parameter.
6434         * go-exp.y: Update rules.
6435         * f-exp.y: Update rules.
6436         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6437         parameter.
6438         * d-exp.y: Update rules.
6439         * c-exp.y: Update rules.
6440         * breakpoint.c (set_breakpoint_condition): Create an
6441         innermost_block_tracker.
6442         (watch_command_1): Likewise.
6443         * ada-lang.c (resolve): Add "tracker" parameter.
6444         (resolve_subexp): Likewise.
6445         * ada-exp.y (write_var_from_sym): Update.
6446
6447 2019-04-04  Tom Tromey  <tom@tromey.com>
6448
6449         * type-stack.h: New file.
6450         * type-stack.c: New file.
6451         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6452         type-stack.h.
6453         (insert_into_type_stack, insert_type, push_type, push_type_int)
6454         (insert_type_address_space, pop_type, pop_type_int)
6455         (pop_typelist, pop_type_stack, append_type_stack)
6456         (push_type_stack, get_type_stack, push_typelist)
6457         (follow_type_instance_flags, follow_types): Don't declare.
6458         * parse.c (type_stack): Remove global.
6459         (parse_exp_in_context): Update.
6460         (insert_into_type_stack, insert_type, push_type, push_type_int)
6461         (insert_type_address_space, pop_type, pop_type_int)
6462         (pop_typelist, pop_type_stack, append_type_stack)
6463         (push_type_stack, get_type_stack, push_typelist)
6464         (follow_type_instance_flags, follow_types): Remove (moved to
6465         type-stack.c).
6466         * f-exp.y (type_stack): New global.
6467         Update rules.
6468         (push_kind_type, f_parse): Update.
6469         * d-exp.y (type_stack): New global.
6470         Update rules.
6471         (d_parse): Update.
6472         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6473         Update rules.
6474         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6475         (HFILES_NO_SRCDIR): Add type-stack.h.
6476
6477 2019-04-04  Tom Tromey  <tom@tromey.com>
6478
6479         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6480         (rust_parser::convert_ast_to_expression, rust_parse)
6481         (rust_lex_test_completion, rust_lex_tests): Update.
6482         * parser-defs.h (struct expr_completion_state): New.
6483         (struct parser_state) <parser_state>: Add completion parameter.
6484         <mark_struct_expression, mark_completion_tag>: New methods.
6485         <parse_completion, m_completion_state>: New members.
6486         (prefixify_expression, null_post_parser): Update.
6487         (mark_struct_expression, mark_completion_tag): Don't declare.
6488         * parse.c (parse_completion, expout_last_struct)
6489         (expout_tag_completion_type, expout_completion_name): Remove
6490         globals.
6491         (parser_state::mark_struct_expression)
6492         (parser_state::mark_completion_tag): Now methods.
6493         (prefixify_expression): Add last_struct parameter.
6494         (prefixify_subexp): Likewise.
6495         (parse_exp_1): Update.
6496         (parse_exp_in_context): Add cstate parameter.  Update.
6497         (parse_expression_for_completion): Create an
6498         expr_completion_state.
6499         (null_post_parser): Add "completion" parameter.
6500         * p-exp.y: Update rules.
6501         (yylex): Update.
6502         * language.h (struct language_defn) <la_post_parser>: Add
6503         "completing" parameter.
6504         * go-exp.y: Update rules.
6505         (lex_one_token): Update.
6506         * expression.h (parse_completion): Don't declare.
6507         * d-exp.y: Update rules.
6508         (lex_one_token): Update rules.
6509         * c-exp.y: Update rules.
6510         (lex_one_token): Update.
6511         * ada-lang.c (resolve): Add "parse_completion" parameter.
6512         (resolve_subexp): Likewise.
6513         (ada_resolve_function): Likewise.
6514
6515 2019-04-04  Tom Tromey  <tom@tromey.com>
6516
6517         * parser-defs.h (struct parser_state) <start_arglist,
6518         end_arglist>: New methods.
6519         <arglist_len, m_funcall_chain>: New members.
6520         (arglist_len, start_arglist, end_arglist): Don't declare.
6521         * parse.c (arglist_len, funcall_chain): Remove global.
6522         (start_arglist, end_arglist): Remove functions.
6523         (parse_exp_in_context): Update.
6524         * p-exp.y: Update rules.
6525         * m2-exp.y: Update rules.
6526         * go-exp.y: Update rules.
6527         * f-exp.y: Update rules.
6528         * d-exp.y: Update rules.
6529         * c-exp.y: Update rules.
6530
6531 2019-04-04  Tom Tromey  <tom@tromey.com>
6532
6533         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6534         lex_operator, push_back>: New methods.
6535         Update all rules.
6536         (rust_parser::lex_hex, lex_escape): Rename and update.
6537         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6538         (rust_parser::lex_operator): Rename and update.
6539         (rust_parser::lex_number, rustyylex, rustyyerror)
6540         (rust_lex_test_init, rust_lex_test_sequence)
6541         (rust_lex_test_push_back, rust_lex_tests): Update.
6542         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6543         parameter.
6544         <lexptr, prev_lexptr>: New members.
6545         (lexptr, prev_lexptr): Don't declare.
6546         * parse.c (lexptr, prev_lexptr): Remove globals.
6547         (parse_exp_in_context): Update.
6548         * p-exp.y (yylex, yyerror): Update.
6549         * m2-exp.y (parse_number, yylex, yyerror): Update.
6550         * go-exp.y (lex_one_token, yyerror): Update.
6551         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6552         * d-exp.y (lex_one_token, yyerror): Update.
6553         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6554         (lex_one_token, yyerror): Update.
6555         * ada-lex.l (YY_INPUT): Update.
6556         (rewind_to_char): Update.
6557         * ada-exp.y (yyerror): Update.
6558
6559 2019-04-04  Tom Tromey  <tom@tromey.com>
6560
6561         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6562         * parser-defs.h (struct parser_state) <parser_state>: Add new
6563         parameter.
6564         <comma_terminates>: New member.
6565         (comma_terminates): Don't declare global.
6566         * parse.c (comma_terminates): Remove global.
6567         (parse_exp_in_context): Update.
6568         * p-exp.y (yylex): Update.
6569         * m2-exp.y (yylex): Update.
6570         * go-exp.y (lex_one_token): Update.
6571         * f-exp.y (yylex): Update.
6572         * d-exp.y (lex_one_token): Update.
6573         * c-exp.y (lex_one_token): Update.
6574         * ada-lex.l: Update.
6575
6576 2019-04-04  Tom Tromey  <tom@tromey.com>
6577
6578         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6579         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6580         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6581         * parser-defs.h (paren_depth): Don't declare.
6582         * parse.c (paren_depth): Remove global.
6583         (parse_exp_in_context): Update.
6584         * p-exp.y (paren_depth): New global.
6585         (pascal_parse): Initialize it.
6586         * m2-exp.y (paren_depth): New global.
6587         (m2_parse): Initialize it.
6588         * go-exp.y (paren_depth): New global.
6589         (go_parse): Initialize it.
6590         * f-exp.y (paren_depth): New global.
6591         (f_parse): Initialize it.
6592         * d-exp.y (paren_depth): New global.
6593         (d_parse): Initialize it.
6594         * c-exp.y (paren_depth): New global.
6595         (c_parse): Initialize it.
6596         * ada-lex.l (paren_depth): New global.
6597         (lexer_init): Initialize it.
6598
6599 2019-04-04  Tom Tromey  <tom@tromey.com>
6600
6601         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6602         (rust_parser::convert_ast_to_type)
6603         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6604         * parser-defs.h (struct parser_state) <parser_state>: Add
6605         parameters.  Initialize new members.
6606         <expression_context_block, expression_context_pc>: New members.
6607         * parse.c (expression_context_block, expression_context_pc):
6608         Remove globals.
6609         (parse_exp_in_context): Update.
6610         * p-exp.y: Update all rules.
6611         (yylex): Update.
6612         * m2-exp.y: Update all rules.
6613         (yylex): Update.
6614         * go-exp.y (yylex): Update.
6615         * f-exp.y (yylex): Update.
6616         * d-exp.y: Update all rules.
6617         (yylex): Update.
6618         * c-exp.y: Update all rules.
6619         (lex_one_token, classify_name, yylex, c_parse): Update.
6620         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6621
6622 2019-04-04  Tom Tromey  <tom@tromey.com>
6623
6624         * gdbarch.h, gdbarch.c: Rebuild.
6625         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6626         * stap-probe.h:
6627         (struct stap_parse_info): Replace "parser_state" with
6628         "expr_builder".
6629         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6630         (parser_state): New class.
6631         * parse.c (expr_builder): Rename.
6632         (expr_builder::release): Rename.
6633         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6634         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6635         (write_exp_elt_longcst, write_exp_elt_floatcst)
6636         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6637         (write_exp_string_vector, write_exp_bitstring)
6638         (write_exp_msymbol, mark_struct_expression)
6639         (write_dollar_variable)
6640         (insert_type_address_space, increase_expout_size): Replace
6641         "parser_state" with "expr_builder".
6642         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6643         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6644         "parser_state" with "expr_builder".
6645
6646 2019-04-04  Tom Tromey  <tom@tromey.com>
6647
6648         * rust-exp.y: Replace "parse_language" with method call.
6649         * p-exp.y:
6650         (yylex): Replace "parse_language" with method call.
6651         * m2-exp.y:
6652         (yylex): Replace "parse_language" with method call.
6653         * go-exp.y (classify_name): Replace "parse_language" with method
6654         call.
6655         * f-exp.y (yylex): Replace "parse_language" with method call.
6656         * d-exp.y (lex_one_token): Replace "parse_language" with method
6657         call.
6658         * c-exp.y:
6659         (lex_one_token, classify_name, yylex): Replace "parse_language"
6660         with method call.
6661         * ada-exp.y (find_primitive_type, type_char)
6662         (type_system_address): Replace "parse_language" with method call.
6663
6664 2019-04-04  Tom Tromey  <tom@tromey.com>
6665
6666         * rust-exp.y: Replace "parse_gdbarch" with method call.
6667         * parse.c (write_dollar_variable, insert_type_address_space):
6668         Replace "parse_gdbarch" with method call.
6669         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6670         call.
6671         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6672         call.
6673         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6674         "parse_gdbarch" with method call.
6675         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6676         with method call.
6677         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6678         "parse_gdbarch" with method call.
6679         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6680         "parse_gdbarch" with method call.
6681         * c-exp.y (parse_type, parse_number, classify_name): Replace
6682         "parse_gdbarch" with method call.
6683         * ada-lex.l: Replace "parse_gdbarch" with method call.
6684         * ada-exp.y (parse_type, find_primitive_type, type_char)
6685         (type_system_address): Replace "parse_gdbarch" with method call.
6686
6687 2019-04-04  Tom Tromey  <tom@tromey.com>
6688
6689         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6690         * stap-probe.c (stap_parse_argument): Update.
6691         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6692         initial_size parameter.
6693         * rust-exp.y (rust_lex_tests): Update.
6694         * parse.c (parser_state): Update.
6695         (parse_exp_in_context): Update.
6696         * parser-defs.h (struct parser_state) <parser_state>: Remove
6697         "initial_size" parameter.
6698
6699 2019-04-04  Tom Tromey  <tom@tromey.com>
6700
6701         * parser-defs.h (increase_expout_size): Don't declare.
6702         * parse.c (increase_expout_size): Now static.
6703
6704 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6705
6706         * gnu-nat.c (gnu_nat_target::wait): Fix
6707         target_waitstatus_to_string call.
6708
6709 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6710
6711         * eval.c (evaluate_subexp_standard): Handle internal functions
6712         during Fortran function call handling.
6713
6714 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6715
6716         * NEWS: Mention new internal functions.
6717         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6718         (read_base_type): Use dwarf2_init_complex_target_type.
6719         * value.c (creal_internal_fn): New function.
6720         (cimag_internal_fn): New function.
6721         (_initialize_values): Register new internal functions.
6722
6723 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6724
6725         * infrun.c (stop_all_threads): If debug_infrun, always
6726         trace the wait status after wait_one, using
6727         target_waitstatus_to_string and target_pid_to_str.
6728         (handle_inferior_event): Replace various trace of
6729         wait status kind by a single trace.
6730         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6731         wait status kind image by target_waitstatus_to_string.
6732         * target/waitstatus.c (target_waitstatus_to_string): Fix
6733         obsolete comment.
6734
6735 2019-04-01  Tom Tromey  <tromey@adacore.com>
6736
6737         PR symtab/23331:
6738         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6739
6740 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6741             Pedro Alves  <palves@redhat.com>
6742
6743         * top.c (quit_force): Call 'finalize_values'.
6744         * value.c (finalize_values): New function.
6745         * value.h (finalize_values): Declare.
6746
6747 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6748
6749         * NEWS: Announce $_gdb_major and $_gdb_minor.
6750
6751         * top.c (init_gdb_version_vars): New function.
6752         (gdb_init): Call init_gdb_version_vars.
6753
6754 2019-03-29  Tom Tromey  <tromey@adacore.com>
6755
6756         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6757         help text.  Remove dead code.
6758
6759 2019-03-29  Keith Seitz  <keiths@redhat.com>
6760
6761         From Siddhesh Poyarekar:
6762         * f-lang.h (f77_get_upperbound): Return LONGEST.
6763         (f77_get_lowerbound): Likewise.
6764         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6765         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6766         print them.
6767         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6768         plongest to format print it.
6769         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6770         (f77_get_upperbound): Likewise.
6771         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6772         LOWER_BOUND to LONGEST.
6773         (f77_create_arrayprint_offset_tbl): Likewise.
6774
6775 2019-03-29  Keith Seitz  <keiths@redhat.com>
6776
6777         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6778         %s/pulongest for TYPE_LENGTH instead of %d in format
6779         strings.
6780         * ada-typerint.c (ada_print_type): Likewise.
6781         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6782         * compile/compile-c-support.c (generate_register_struct): Likewise.
6783         * gdbtypes.c (recursive_dump_type): Likewise.
6784         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6785         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6786         instead of %d in format strings.
6787         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6788         to std::min to ULONGEST.
6789         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6790         instead of %d in format strings.
6791         * tracepoint.c (info_scope_command): Likewise.
6792         * typeprint.c (print_offset_data::update)
6793         (print_offset_data::finish): Likewise.
6794         * xtensa-tdep.c (xtensa_store_return_value)
6795         (xtensa_push_dummy_call): Likewise.
6796
6797 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6798
6799         * windows-nat.c (display_selector): Fixed format specifications
6800         for 64-bit Cygwin.
6801
6802 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6803
6804         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6805
6806 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6807
6808         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6809         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6810         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6811         (nios2_linux_init_abi): Install it.
6812
6813 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6814
6815         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6816
6817 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6818
6819         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6820
6821 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6822             Tom Tromey  <tromey@adacore.com>
6823
6824         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6825
6826 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6827
6828         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6829         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6830         method to compute the bounds of range types. Also print "[evaluated]"
6831         if the bounds' values come from a dynamic evaluation.
6832
6833 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6834
6835         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6836         whitespace when pretty printing is on.
6837
6838 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6839
6840         * ppc-linux-nat.c: Add include.
6841
6842 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6843
6844         * NEWS: Mention AArch64 Pointer Authentication.
6845
6846 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6847
6848         * arm-linux-nat.c: Add include.
6849
6850 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6851
6852         * source-cache.c (source_cache::get_source_lines): Re-read
6853         fullname after calling open_source_file.
6854
6855 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6856
6857         * NEWS: Mention TLS support for FreeBSD.
6858
6859 2019-03-25  Tom Tromey  <tromey@adacore.com>
6860
6861         * minsyms.c (BUNCH_SIZE): Update comment.
6862         (~minimal_symbol_reader): Remove old comment.
6863         (compact_minimal_symbols): Update comment.
6864         (minimal_symbol_reader::install): Remove old comment.  Update
6865         other comments.
6866
6867 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6868
6869         * s390-linux-nat.c: Add include.
6870
6871 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6872
6873         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6874         Call linux_get_hwcap.
6875         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6876         Likewise.
6877         (aarch64_linux_get_hwcap): Remove function.
6878         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6879         declaration.
6880         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6881         linux_get_hwcap.
6882         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6883         * linux-tdep.c (linux_get_hwcap): Add function.
6884         (linux_get_hwcap2): Likewise.
6885         * linux-tdep.h (linux_get_hwcap): Add declaration.
6886         (linux_get_hwcap2): Likewise.
6887         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6888         (ppc_linux_get_hwcap2): Likewise.
6889         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6890         linux_get_hwcap.
6891         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6892         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6893         (ppc_linux_nat_target::read_description): Likewise.
6894         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6895         * s390-linux-nat.c: Likewise.
6896         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6897
6898 2019-03-24  Tom Tromey  <tom@tromey.com>
6899
6900         * ada-lang.c (standard_lookup): Simplify initialization.
6901         (ada_lookup_symbol_nonlocal): Simplify return.
6902         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6903         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6904         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6905         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6906         initialization.
6907         * solib.c (solib_global_lookup): Simplify.
6908         * symtab.c (null_block_symbol): Remove.
6909         (symbol_cache_lookup): Simplify returns.
6910         (lookup_language_this): Simplify returns.
6911         (lookup_symbol_aux): Simplify return.
6912         (lookup_local_symbol): Simplify returns.
6913         (lookup_global_symbol_from_objfile): Simplify return.
6914         (lookup_symbol_in_objfile_symtabs)
6915         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6916         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6917         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6918         * cp-namespace.c (cp_lookup_bare_symbol)
6919         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6920         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6921         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6922         (cp_lookup_symbol_via_imports): Simplify initialization.
6923         (find_symbol_in_baseclass): Likewise.
6924         * symtab.h (null_block_symbol): Remove.
6925         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6926         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6927         (d_lookup_symbol_module): Likewise.
6928         (find_symbol_in_baseclass): Simplify initialization.
6929
6930 2019-03-24  Tom Tromey  <tom@tromey.com>
6931
6932         * expression.h: Don't include symtab.h.
6933         (struct block): Forward declare.
6934
6935 2019-03-24  Tom Tromey  <tom@tromey.com>
6936
6937         * c-exp.y (typebase): Remove casts.
6938         * gdbtypes.c (lookup_unsigned_typename, )
6939         (lookup_signed_typename): Remove cast.
6940         * eval.c (parse_to_comma_and_eval): Remove cast.
6941         * parse.c (write_dollar_variable): Remove cast.
6942         * block.h (struct block) <superblock>: Now const.
6943         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6944         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6945         (map_block): Make "block" const.
6946         * symfile.h (struct quick_symbol_functions)
6947         <map_matching_symbols>: Constify block argument to "callback".
6948         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6949         const.
6950         (find_pc_sect_compunit_symtab): Make "b" const.
6951         (find_symbol_at_address): Likewise.
6952         (search_symbols): Likewise.
6953         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6954         (dw2_debug_names_lookup_symbol): Likewise.
6955         (dw2_map_matching_symbols): Update.
6956         * p-valprint.c (pascal_val_print): Remove "block".
6957         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6958         (aux_add_nonlocal_symbols): Make "block" const.
6959         (resolve_subexp): Remove cast.
6960         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6961         const.
6962         (iterate_over_file_blocks): Likewise.
6963         * f-exp.y (%union) <bval>: Remove.
6964         * coffread.c (patch_opaque_types): Make "b" const.
6965         * spu-tdep.c (spu_catch_start): Make "block" const.
6966         * c-valprint.c (print_unpacked_pointer): Remove "block".
6967         * symmisc.c (dump_symtab_1): Make "b" const.
6968         (block_depth): Make "block" const.
6969         * d-exp.y (%union) <bval>: Remove.
6970         * cp-support.h (cp_lookup_rtti_type): Update.
6971         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6972         * psymtab.c (psym_lookup_symbol): Make "block" const.
6973         (maintenance_check_psymtabs): Make "b" const.
6974         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6975         (enumerate_locals, enumerate_args): Update.
6976         * python/py-symtab.c (stpy_global_block): Make "block" const.
6977         (stpy_static_block): Likewise.
6978         * inline-frame.c (block_starting_point_at): Make "new_block"
6979         const.
6980         * block.c (find_block_in_blockvector): Make return type const.
6981         (blockvector_for_pc_sect): Make "b" const.
6982         (find_block_in_blockvector): Make "b" const.
6983
6984 2019-03-23  Tom Tromey  <tom@tromey.com>
6985
6986         * varobj.c (varobj_create): Update.
6987         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6988         * printcmd.c (display_command, do_one_display): Don't reset
6989         innermost_block.
6990         * parser-defs.h (enum innermost_block_tracker_type): Move to
6991         expression.h.
6992         (innermost_block): Update comment.
6993         * parse.c (parse_exp_1): Add tracker_types parameter.
6994         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6995         tracker_types parameter.  Reset innermost_block.
6996         (parse_exp_in_context): Remove.
6997         (parse_expression_for_completion): Update.
6998         * objfiles.c (~objfile): Don't reset expression_context_block or
6999         innermost_block.
7000         * expression.h (enum innermost_block_tracker_type): Move from
7001         parser-defs.h.
7002         (parse_exp_1): Add tracker_types parameter.
7003         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7004         reset innermost_block.
7005
7006 2019-03-23  Tom Tromey  <tom@tromey.com>
7007
7008         * objfiles.h: Include bcache.h.
7009
7010 2019-03-23  Tom Tromey  <tom@tromey.com>
7011
7012         * linespec.c (get_current_search_block): Use
7013         scoped_restore_current_language.
7014         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7015
7016 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7017             Jiong Wang  <jiong.wang@arm.com>
7018
7019         * aarch64-linux-tdep.c
7020         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7021         section.
7022         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7023
7024 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7025             Jiong Wang  <jiong.wang@arm.com>
7026
7027         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7028         instructions.
7029         (aarch64_analyze_prologue_test): Add PACIASP test.
7030         (aarch64_prologue_prev_register): Unmask PC value.
7031
7032 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7033             Jiong Wang  <jiong.wang@arm.com>
7034
7035         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7036         (aarch64_dwarf2_prev_register): Unmask PC value.
7037         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7038         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7039         DW_CFA_AARCH64_negate_ra_state.
7040         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7041
7042 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7043             Jiong Wang  <jiong.wang@arm.com>
7044
7045         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7046         registers.
7047         (aarch64_pseudo_register_name): Likewise.
7048         (aarch64_pseudo_register_type): Likewise.
7049         (aarch64_pseudo_register_reggroup_p): Likewise.
7050         (aarch64_gdbarch_init): Add pauth registers.
7051         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7052         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7053         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7054         (struct gdbarch_tdep): Add regnum for ra_state.
7055
7056 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7057             Jiong Wang  <jiong.wang@arm.com>
7058
7059         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7060
7061 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7062             Jiong Wang  <jiong.wang@arm.com>
7063
7064         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7065         function.
7066         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7067         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7068         (aarch64_gdbarch_init): Add puth registers.
7069         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7070         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7071         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7072
7073 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7074             Jiong Wang  <jiong.wang@arm.com>
7075
7076         * aarch64-linux-nat.c
7077         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7078         * aarch64-linux-tdep.c
7079         (aarch64_linux_core_read_description): Likewise.
7080         (aarch64_linux_get_hwcap): New function.
7081         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7082         (aarch64_linux_get_hwcap): New declaration.
7083
7084 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7085             Jiong Wang  <jiong.wang@arm.com>
7086
7087         * aarch64-linux-nat.c
7088         (aarch64_linux_nat_target::read_description): Add pauth param.
7089         * aarch64-linux-tdep.c
7090         (aarch64_linux_core_read_description): Likewise.
7091         * aarch64-tdep.c (struct target_desc): Add in pauth.
7092         (aarch64_read_description): Add pauth param.
7093         (aarch64_gdbarch_init): Likewise.
7094         * aarch64-tdep.h (aarch64_read_description): Likewise.
7095         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7096         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7097         * features/Makefile: Add new files.
7098         * features/aarch64-pauth.c: New file.
7099         * features/aarch64-pauth.xml: New file.
7100
7101 2019-03-20  Tom Tromey  <tromey@adacore.com>
7102
7103         * infrun.c (handle_inferior_event): Rename from
7104         handle_inferior_event_1.  Create a scoped_value_mark.
7105         (handle_inferior_event): Remove.
7106
7107 2019-03-19  Tom Tromey  <tromey@adacore.com>
7108
7109         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7110         * infrun.h (print_stop_event): Add "displays" parameter.
7111         * infrun.c (print_stop_event): Add "displays" parameter.
7112
7113 2019-03-19  Pedro Alves  <palves@redhat.com>
7114
7115         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7116         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7117         to -1.  Fix TABs vs spaces.
7118         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7119         * tui/tui-out.h (tui_ui_out) Add intro comments.
7120         <m_line, m_start_of_line>: In-class initialize, and add describing
7121         comment.
7122
7123 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7124
7125         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7126         variable names.
7127         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7128
7129 2019-03-18  Pedro Alves  <palves@redhat.com>
7130             Eli Zaretskii <eliz@gnu.org>
7131
7132         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7133         m_line and m_start_of_line.
7134
7135 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7136
7137         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7138         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7139         it returns a newline.  This fixes a regression in TU mode, whereby
7140         the next line is output on the same screen line as the user input.
7141
7142 2019-03-18  Tom Tromey  <tromey@adacore.com>
7143
7144         * minsyms.c (minimal_symbol_reader::install): Remove call to
7145         obstack_blank.
7146
7147 2019-03-18  Pedro Alves  <palves@redhat.com>
7148
7149         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7150         New globals.
7151         (apply_style): New, factored out from ...
7152         (apply_ansi_escape): ... this.  Handle reverse video mode.
7153         (tui_set_reverse_mode): New function.
7154         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7155         * tui/tui-winsource.c (tui_show_source_line): Use
7156         tui_set_reverse_mode instead of setting A_STANDOUT.
7157         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7158         New setter methods.
7159
7160 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7161
7162         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7163         Handle tabs.
7164
7165 2019-03-18  Tom Tromey  <tromey@adacore.com>
7166
7167         * ada-lang.c (empty_array): Add "high" parameter.
7168         (ada_evaluate_subexp): Update.
7169
7170 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7171
7172         * unittests/string_view-selftests.c: Define
7173         _initialize_string_view_selftests unconditionally.
7174
7175 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7176
7177         PR gdb/24350
7178         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7179
7180 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7181
7182         PR gdb/24351
7183         * windows-nat.c (display_selector): Fix format specifiers.
7184
7185 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7186
7187         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7188         tui_refill_source_window instead of tui_refresh_win, to update the
7189         current execution line.  This fixes redisplay of the current line
7190         when stepping through the code with "next" or "step".
7191
7192 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7193
7194         * source-cache.c (source_cache::get_source_lines): Call
7195         find_source_lines to initialize s->nlines.  This fixes vertical
7196         scrolling of TUI source window when the DOWN arrow is pressed.
7197
7198 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7199
7200         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7201         linux-thread-db.c (_initialize_thread_db): Likewise.
7202
7203 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7204
7205         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7206         wclrtoeol in tui_show_source_line".  This reverts changes made in
7207         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7208
7209 2019-03-15  Tom Tromey  <tom@tromey.com>
7210
7211         * symtab.h (struct minimal_symbol): Derive from
7212         general_symbol_info.
7213         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7214         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7215         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7216         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7217         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7218         (MSYMBOL_SEARCH_NAME): Update.
7219         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7220         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7221         * minsyms.c (minimal_symbol_reader::record_full): Update.
7222
7223 2019-03-15  Tom Tromey  <tom@tromey.com>
7224
7225         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7226
7227 2019-03-15  Tom Tromey  <tom@tromey.com>
7228
7229         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7230         unique_xmalloc_ptr.
7231         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7232         Update.
7233         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7234         (build_minimal_symbol_hash_tables)
7235         (minimal_symbol_reader::install): Update.
7236
7237 2019-03-15  Tom Tromey  <tom@tromey.com>
7238
7239         * symtab.c (create_demangled_names_hash): Update.
7240         (symbol_set_names): Update.
7241         * objfiles.h (struct objfile_per_bfd_storage)
7242         <demangled_names_hash>: Now an htab_up.
7243         * objfiles.c (objfile_per_bfd_storage): Simplify.
7244
7245 2019-03-15  Tom Tromey  <tom@tromey.com>
7246
7247         * objfiles.h (struct objfile_per_bfd_storage): Declare
7248         destructor.
7249         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7250         New.
7251         (get_objfile_bfd_data): Use new.  Don't initialize
7252         language_of_main.
7253         (free_objfile_per_bfd_storage): Remove.
7254         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7255
7256 2019-03-15  Tom Tromey  <tom@tromey.com>
7257
7258         * symfile.c (reread_symbols): Update.
7259         * objfiles.c (objfile::objfile): Update.
7260         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7261         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7262         comment.
7263         (minimal_symbol_reader::install): Update.
7264         (terminate_minimal_symbol_table): Remove.
7265         * jit.c (jit_object_close_impl): Update.
7266
7267 2019-03-15  Tom Tromey  <tom@tromey.com>
7268
7269         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7270         initializations.
7271
7272 2019-03-15  Tom Tromey  <tom@tromey.com>
7273
7274         * objfiles.h (struct objfile_per_bfd_storage)
7275         <demangled_hash_languages>: Now a bitset.
7276         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7277         (lookup_minimal_symbol): Update.
7278
7279 2019-03-15  Tom Tromey  <tom@tromey.com>
7280
7281         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7282         Don't return the symbol.
7283         * coffread.c (record_minimal_symbol): Use record_full.
7284
7285 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7286
7287         The MS-Windows port of ncurses fails to switch to a color pair if
7288         one or both of the colors are the implicit default colors.  This
7289         change records the default colors when TUI is initialized, and
7290         then specifies them explicitly when a color pair uses the default
7291         colors.  This allows color styling in TUI mode on MS-Windows.
7292
7293         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7294         ncurses_norm_attr.
7295         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7296         colors in ncurses_norm_attr.
7297         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7298         "none", replace it with the default color recorded in
7299         ncurses_norm_attr.
7300
7301 2019-03-14  Tom Tromey  <tromey@adacore.com>
7302
7303         * source-cache.h (class source_cache) <get_source_lines>: Return
7304         std::string.
7305         * source-cache.c (source_cache::extract_lines): Handle case where
7306         first_pos==npos.  Return std::string.
7307         (source_cache::get_source_lines): Update.
7308
7309 2019-03-14  Tom Tromey  <tromey@adacore.com>
7310
7311         * NEWS: Add item for "style sources" commands.
7312         * source-cache.c (source_cache::get_source_lines): Check
7313         source_styling.
7314         * cli/cli-style.c (source_styling): New global.
7315         (_initialize_cli_style): Add "style sources" commands.
7316         (show_style_sources): New function.
7317         * cli/cli-style.h (source_styling): Declare.
7318
7319 2019-03-14  Pedro Alves  <palves@redhat.com>
7320             Tom Tromey  <tromey@adacore.com>
7321
7322         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7323         * tui/tui-winsource.c (tui_refill_source_window): New function,
7324         from...
7325         (tui_horizontal_source_scroll): ... here.  Move some logic.
7326         * cli/cli-style.c (set_style_enabled): Notify new observable.
7327         * tui/tui-hooks.c (tui_redisplay_source): New function.
7328         (tui_attach_detach_observers): Attach or detach
7329         tui_redisplay_source.
7330         * observable.h (source_styling_changed): New observable.
7331         * observable.c: Define source_styling_changed observable.
7332
7333 2019-03-13  Tom Tromey  <tromey@adacore.com>
7334
7335         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7336         (i386_gnu_nat_target::store_registers): Update.
7337         * target-debug.h (target_debug_print_std_string): New macro.
7338         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7339         * windows-tdep.c (display_one_tib): Update.
7340         * tui/tui-stack.c (tui_make_status_line): Update.
7341         * top.c (print_inferior_quit_action): Update.
7342         * thread.c (thr_try_catch_cmd): Update.
7343         (add_thread_with_info): Update.
7344         (thread_target_id_str): Update.
7345         (thr_try_catch_cmd): Update.
7346         (thread_command): Update.
7347         (thread_find_command): Update.
7348         * record-btrace.c (record_btrace_target::info_record)
7349         (record_btrace_resume_thread, record_btrace_target::resume)
7350         (record_btrace_cancel_resume, record_btrace_step_thread)
7351         (record_btrace_target::wait, record_btrace_target::wait)
7352         (record_btrace_target::wait, record_btrace_target::stop): Update.
7353         * progspace.c (print_program_space): Update.
7354         * process-stratum-target.c
7355         (process_stratum_target::thread_address_space): Update.
7356         * linux-fork.c (linux_fork_mourn_inferior)
7357         (detach_checkpoint_command, info_checkpoints_command)
7358         (linux_fork_context): Update.
7359         (linux_fork_detach): Update.
7360         (class scoped_switch_fork_info): Update.
7361         (delete_checkpoint_command): Update.
7362         * infrun.c (follow_fork_inferior): Update.
7363         (follow_fork_inferior): Update.
7364         (proceed_after_vfork_done): Update.
7365         (handle_vfork_child_exec_or_exit): Update.
7366         (follow_exec): Update.
7367         (displaced_step_prepare_throw): Update.
7368         (displaced_step_restore): Update.
7369         (start_step_over): Update.
7370         (resume_1): Update.
7371         (clear_proceed_status_thread): Update.
7372         (proceed): Update.
7373         (print_target_wait_results): Update.
7374         (do_target_wait): Update.
7375         (context_switch): Update.
7376         (stop_all_threads): Update.
7377         (restart_threads): Update.
7378         (finish_step_over): Update.
7379         (handle_signal_stop): Update.
7380         (switch_back_to_stepped_thread): Update.
7381         (keep_going_pass_signal): Update.
7382         (print_exited_reason): Update.
7383         (normal_stop): Update.
7384         * inferior.c (inferior_pid_to_str): Change return type.
7385         (print_selected_inferior): Update.
7386         (add_inferior): Update.
7387         (detach_inferior): Update.
7388         * dummy-frame.c (fprint_dummy_frames): Update.
7389         * dcache.c (dcache_info_1): Update.
7390         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7391         (btrace_fetch, btrace_clear): Update.
7392         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7393         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7394         type.
7395         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7396         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7397         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7398         * gdbarch.c, gdbarch.h: Rebuild.
7399         * gdbarch.sh (core_pid_to_str): Change return type.
7400         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7401         return type.
7402         (windows_nat_target::pid_to_str): Change return type.
7403         (windows_delete_thread): Update.
7404         (windows_nat_target::attach): Update.
7405         (windows_nat_target::files_info): Update.
7406         * target-delegates.c: Rebuild.
7407         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7408         return type.
7409         (sol_thread_target::pid_to_str): Change return type.
7410         * remote.c (class remote_target) <pid_to_str>: Change return
7411         type.
7412         (remote_target::pid_to_str): Change return type.
7413         (extended_remote_target::attach, remote_target::remote_stop_ns)
7414         (remote_target::remote_notif_remove_queued_reply)
7415         (remote_target::push_stop_reply, remote_target::disable_btrace):
7416         Update.
7417         (extended_remote_target::attach): Update.
7418         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7419         type.
7420         (gdbsim_target::pid_to_str): Change return type.
7421         * ravenscar-thread.c (struct ravenscar_thread_target)
7422         <pid_to_str>: Change return type.
7423         (ravenscar_thread_target::pid_to_str): Change return type.
7424         * procfs.c (class procfs_target) <pid_to_str>: Change return
7425         type.
7426         (procfs_target::pid_to_str): Change return type.
7427         (procfs_target::attach): Update.
7428         (procfs_target::detach): Update.
7429         (procfs_target::fetch_registers): Update.
7430         (procfs_target::store_registers): Update.
7431         (procfs_target::wait): Update.
7432         (procfs_target::files_info): Update.
7433         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7434         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7435         return type.
7436         (nto_procfs_target::pid_to_str): Change return type.
7437         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7438         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7439         return type.
7440         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7441         (exit_lwp): Update.
7442         (attach_proc_task_lwp_callback, get_detach_signal)
7443         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7444         (linux_nat_target::resume, wait_lwp, stop_callback)
7445         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7446         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7447         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7448         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7449         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7450         type.
7451         (inf_ptrace_target::attach): Update.
7452         (inf_ptrace_target::files_info): Update.
7453         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7454         type.
7455         (go32_nat_target::pid_to_str): Change return type.
7456         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7457         (gnu_nat_target::wait): Update.
7458         (gnu_nat_target::wait): Update.
7459         (gnu_nat_target::resume): Update.
7460         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7461         (fbsd_nat_target::wait): Update.
7462         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7463         type.
7464         (darwin_nat_target::attach): Update.
7465         * corelow.c (class core_target) <pid_to_str>: Change return type.
7466         (core_target::pid_to_str): Change return type.
7467         * target.c (normal_pid_to_str): Change return type.
7468         (default_pid_to_str): Likewise.
7469         (target_pid_to_str): Change return type.
7470         (target_translate_tls_address): Update.
7471         (target_announce_detach): Update.
7472         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7473         return type.
7474         (bsd_uthread_target::pid_to_str): Change return type.
7475         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7476         type.
7477         (bsd_kvm_target::pid_to_str): Change return type.
7478         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7479         return type.
7480         (aix_thread_target::pid_to_str): Change return type.
7481         * target.h (struct target_ops) <pid_to_str>: Change return type.
7482         (target_pid_to_str, normal_pid_to_str): Likewise.
7483         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7484         type.
7485         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7486         type.
7487         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7488         return type.
7489         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7490         type.
7491         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7492         type.
7493         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7494         return type.
7495
7496 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7497
7498         * NEWS: Mention that the new default MI version is 3.  Mention
7499         changes to the output of commands and events that deal with
7500         multi-location breakpoints.
7501         * breakpoint.c: Include "mi/mi-out.h".
7502         (print_one_breakpoint): Change output syntax if using MI version
7503         >= 3.
7504         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7505         New.
7506         (mi_multi_location_breakpoint_output_fixed): New.
7507         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7508         (mi_cmd_fix_multi_location_breakpoint_output): New.
7509         (mi_multi_location_breakpoint_output_fixed): New.
7510         * mi/mi-cmds.c (mi_cmds): Register command
7511         -fix-multi-location-breakpoint-output.
7512         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7513         interpreter "mi".
7514
7515 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7516
7517         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7518         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7519         instantiate mi_ui_out based on interpreter name.
7520         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7521         * mi/mi-main.c (mi_load_progress): Likewise.
7522
7523 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7524
7525         * NEWS: Combine separate "New targets" sections for 8.3.
7526
7527 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7528
7529         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7530         (ppcfbsd_init_abi): Install gdbarch
7531         "fetch_tls_load_module_address" and "get_thread_local_address"
7532         methods.
7533
7534 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7535
7536         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7537         (riscv_fbsd_init_abi): Install gdbarch
7538         "fetch_tls_load_module_address" and "get_thread_local_address"
7539         methods.
7540
7541 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7542
7543         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7544         (i386fbsd_init_abi): Install gdbarch
7545         "fetch_tls_load_module_address" and "get_thread_local_address"
7546         methods.
7547
7548 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7549
7550         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7551         (amd64fbsd_init_abi): Install gdbarch
7552         "fetch_tls_load_module_address" and "get_thread_local_address"
7553         methods.
7554
7555 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7556
7557         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7558         (struct fbsd_pspace_data): New type.
7559         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7560         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7561         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7562         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7563         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7564
7565 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7566
7567         * gdbtypes.c (lookup_struct_elt): New function.
7568         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7569         * gdbtypes.h (struct struct_elt): New type.
7570         (lookup_struct_elt): New prototype.
7571
7572 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7573
7574         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7575         remove disabled code block.
7576
7577 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7578
7579         * gdbarch.sh (get_thread_local_address): New method.
7580         * gdbarch.h, gdbarch.c: Regenerate.
7581         * target.c (target_translate_tls_address): Use
7582         gdbarch_get_thread_local_address if present instead of
7583         target::get_thread_local_address.
7584
7585 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7586
7587         * target.h (target::get_thread_local_address): Update comment.
7588
7589 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7590
7591         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7592         objfile->separate_debug_objfile_backlink if not NULL.
7593
7594 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7595
7596         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7597         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7598         (amd64bsd_store_inferior_registers): Likewise.
7599         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7600         Enable segment base registers.
7601         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7602         PT_GETFSBASE and PT_GETGSBASE.
7603         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7604         PT_SETGSBASE.
7605         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7606         segment base registers.
7607         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7608
7609 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7610
7611         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7612         Update calls to i386_target_description to add 'segments'
7613         parameter.
7614         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7615         add segment base registers.
7616         * arch/i386.c (i386_create_target_description): Add 'segments'
7617         parameter to enable segment base registers.
7618         * arch/i386.h (i386_create_target_description): Likewise.
7619         * features/i386/32bit-segments.xml: New file.
7620         * features/i386/32bit-segments.c: Generate.
7621         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7622         call to i386_target_description to add 'segments' parameter.
7623         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7624         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7625         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7626         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7627         if feature is present.
7628         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7629         Add 'segments' parameter to call to i386_target_description.
7630         (i386_target_description): Add 'segments' parameter to enable
7631         segment base registers.
7632         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7633         to call to i386_target_description.
7634         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7635         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7636         Define I386_NUM_REGS.
7637         (i386_target_description): Add 'segments' parameter to enable
7638         segment base registers.
7639
7640 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7641
7642         PR/24325
7643         * source-cache.c: #undef open and close, to avoid unresolved
7644         externals during linking.
7645
7646 2019-03-12  Tom Tromey  <tromey@adacore.com>
7647
7648         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7649         const.  Add initializers.
7650         (_initialize_remote): Don't initialize ptid globals.
7651
7652 2019-03-12  Pedro Alves  <palves@redhat.com>
7653
7654         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7655
7656 2019-03-12  Pedro Alves  <palves@redhat.com>
7657
7658         * cp-name-parser.y (main): Remove unused 'len' variable.
7659
7660 2019-03-12  Tom Tromey  <tromey@adacore.com>
7661
7662         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7663         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7664
7665 2019-03-12  Tom Tromey  <tromey@adacore.com>
7666
7667         * linux-nat.c (iterate_over_lwps): Update.
7668         (stop_callback): Remove parameter.
7669         (stop_wait_callback, detach_callback, resume_set_callback)
7670         (select_singlestep_lwp_callback, set_ignore_sigint)
7671         (status_callback, resumed_callback, resume_clear_callback)
7672         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7673         data parameter.
7674         (linux_nat_target::detach, linux_nat_target::resume)
7675         (linux_stop_and_wait_all_lwps, select_event_lwp)
7676         (linux_nat_filter_event, linux_nat_wait_1)
7677         (linux_nat_target::kill, linux_nat_target::stop)
7678         (linux_nat_target::stop): Update.
7679         (linux_nat_resume_callback): Change type.
7680         (resume_stopped_resumed_lwps, count_events_callback)
7681         (select_event_lwp_callback): Likewise.
7682         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7683         * arm-linux-nat.c (struct update_registers_data): Remove.
7684         (update_registers_callback): Change type.
7685         (arm_linux_insert_hw_breakpoint1): Update.
7686         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7687         parameter.
7688         (x86_linux_dr_set_addr): Update.
7689         (x86_linux_dr_set_control): Update.
7690         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7691         (iterate_over_lwps): Use gdb::function_view.
7692         * nat/aarch64-linux-hw-point.c (struct
7693         aarch64_dr_update_callback_param): Remove.
7694         (debug_reg_change_callback): Change type.
7695         (aarch64_notify_debug_reg_change): Update.
7696         * s390-linux-nat.c (s390_refresh_per_info): Update.
7697
7698 2019-03-11  Tom Tromey  <tromey@adacore.com>
7699
7700         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7701         redundant assignment to "this_cu".
7702
7703 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7704
7705         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7706
7707 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7708
7709         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7710         from...
7711         (rank_one_type): ... this.
7712
7713 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7714
7715         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7716         from...
7717         (rank_one_type): ... this.
7718
7719 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7720
7721         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7722         from...
7723         (rank_one_type): ... this.
7724
7725 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7726
7727         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7728         from...
7729         (rank_one_type): ... this.
7730
7731 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7732
7733         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7734         from...
7735         (rank_one_type): ... this.
7736
7737 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7738
7739         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7740         from...
7741         (rank_one_type): ... this.
7742
7743 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7744
7745         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7746         from...
7747         (rank_one_type): ... this.
7748
7749 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7750
7751         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7752         from...
7753         (rank_one_type): ... this.
7754
7755 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7756
7757         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7758         from...
7759         (rank_one_type): ... this.
7760
7761 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7762
7763         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7764         from...
7765         (rank_one_type): ... this.
7766
7767 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7768
7769         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7770         from...
7771         (rank_one_type): ... this.
7772
7773 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7774
7775         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7776         from...
7777         (rank_one_type): ... this.
7778
7779 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7780
7781         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7782         inferior-events' shows the example events.
7783
7784 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7785
7786         Support styling on native MS-Windows console
7787
7788         PR/24315
7789         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7790         on MS-Windows if $TERM is not defined.
7791
7792         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7793
7794         * posix-hdep.c (gdb_console_fputs):
7795         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7796         functions.
7797         * ui-file.h (gdb_console_fputs): Add prototype.
7798
7799         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7800         back to fputs only if the former returns zero.
7801
7802 2019-03-07  Tom Tromey  <tom@tromey.com>
7803
7804         * symmisc.c (print_symbol_bcache_statistics): Update.
7805         (print_objfile_statistics): Update.
7806         * symfile.c (allocate_symtab): Update.
7807         * stabsread.c: Don't include bcache.h.
7808         * psymtab.h (struct psymbol_bcache): Don't declare.
7809         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7810         (psymbol_bcache_init, psymbol_bcache_free)
7811         (psymbol_bcache_get_bcache): Don't declare.
7812         * psymtab.c (struct psymbol_bcache): Remove.
7813         (psymtab_storage::psymtab_storage): Update.
7814         (psymtab_storage::~psymtab_storage): Update.
7815         (psymbol_bcache_init, psymbol_bcache_free)
7816         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7817         (add_psymbol_to_bcache): Update.
7818         (allocate_psymtab): Update.
7819         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7820         macro_cache>: No longer pointers.
7821         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7822         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7823         * macrotab.c (macro_bcache): Update.
7824         * macroexp.c: Don't include bcache.h.
7825         * gdbtypes.c (check_types_worklist): Update.
7826         (types_deeply_equal): Remove TRY/CATCH.  Update.
7827         * elfread.c (elf_symtab_read): Update.
7828         * dwarf2read.c: Don't include bcache.h.
7829         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7830         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7831         (print_bcache_statistics, bcache_memory_used): Don't declare.
7832         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7833         methods.  Rename all data members.
7834         * bcache.c (struct bcache): Move to bcache.h.
7835         (bcache::expand_hash_table): Rename from expand_hash_table.
7836         (bcache): Remove.
7837         (bcache::insert): Rename from bcache_full.
7838         (bcache::compare): Rename from bcache_compare.
7839         (bcache_xmalloc): Remove.
7840         (bcache::~bcache): Rename from bcache_xfree.
7841         (bcache::print_statistics): Rename from print_bcache_statistics.
7842         (bcache::memory_used): Rename from bcache_memory_used.
7843
7844 2019-03-07  Pedro Alves  <palves@redhat.com>
7845
7846         * infrun.c (normal_stop): Also check for
7847         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7848
7849 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7850
7851         * f-lang.c (value_from_host_double): Moved to...
7852         * value.c (value_from_host_double): ...here.
7853         * value.h (value_from_host_double): Declare.
7854         * guile/scm-math.c (vlscm_convert_typed_number): Use
7855         value_from_host_double.
7856         (vlscm_convert_number): Likewise.
7857         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7858         * python/py-value.c (convert_value_from_python): Likewise.
7859
7860 2019-03-06  Tom Tromey  <tom@tromey.com>
7861
7862         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7863
7864 2019-03-06  Tom Tromey  <tom@tromey.com>
7865
7866         * utils.h (free_current_contents): Don't declare.
7867         * utils.c (free_current_contents): Remove.
7868
7869 2019-03-06  Tom Tromey  <tom@tromey.com>
7870
7871         * top.c (quit_force): Update.
7872         * main.c (captured_command_loop): Update.
7873         * common/new-op.c (operator new): Update.
7874         * common/common-exceptions.c (struct catcher)
7875         <save_cleanup_chain>: Remove member.
7876         (exceptions_state_mc_init): Update.
7877         (exception_try_scope_entry): Return nullptr.
7878         (exception_try_scope_exit, exception_rethrow)
7879         (throw_exception_sjlj, throw_exception_cxx): Update.
7880         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7881         (all_cleanups, do_cleanups, discard_cleanups)
7882         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7883         (restore_cleanups, restore_final_cleanups): Don't declare.
7884         (do_final_cleanups): Remove parameter.
7885         * common/cleanups.c (cleanup_chain, make_cleanup)
7886         (make_cleanup_dtor, all_cleanups, do_cleanups)
7887         (discard_my_cleanups, discard_cleanups)
7888         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7889         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7890         (null_cleanup): Remove.
7891         (do_final_cleanups): Remove parameter.
7892
7893 2019-03-06  Tom Tromey  <tom@tromey.com>
7894
7895         * remote.c (remote_target::remote_parse_stop_reply): Use
7896         unique_xmalloc_ptr.
7897
7898 2019-03-06  Tom Tromey  <tom@tromey.com>
7899
7900         * stabsread.c (struct stabs_field_info): Rename from field_info.
7901         <list, fnlist>: Add initializers.
7902         <obstack>: New member.
7903         (read_member_functions, read_struct_fields, read_baseclasses):
7904         Allocate on obstack.  Don't use cleanups.
7905         (read_one_struct_field, read_member_functions, read_struct_fields)
7906         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7907         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7908         (read_struct_type): Update.
7909
7910 2019-03-06  Tom Tromey  <tom@tromey.com>
7911
7912         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7913         * common/filestuff.h (make_cleanup_close): Don't declare.
7914         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7915         Remove.
7916
7917 2019-03-06  Tom Tromey  <tom@tromey.com>
7918
7919         * solib-aix.c: Use make_scope_exit.
7920
7921 2019-03-06  Tom Tromey  <tom@tromey.com>
7922
7923         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7924         Use make_scope_exit.
7925
7926 2019-03-06  Tom Tromey  <tom@tromey.com>
7927
7928         * solib-svr4.c (disable_probes_interface): Remove parameter.
7929         (svr4_handle_solib_event): Use make_scope_exit.
7930
7931 2019-03-06  Tom Tromey  <tom@tromey.com>
7932
7933         * remote.c (struct stop_reply_deleter): Remove.
7934         (stop_reply_up): Update.
7935         (struct stop_reply): Derive from notif_event.  Don't typedef.
7936         <regcache>: Now a std::vector.
7937         (stop_reply_xfree): Remove.
7938         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7939         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7940         (remote_target::discard_pending_stop_replies): Use delete.
7941         (remote_target::remote_parse_stop_reply): Update.
7942         (remote_target::process_stop_reply): Update.
7943         * remote-notif.h (struct notif_event): Add virtual destructor.
7944         Remove "dtr" member.
7945         (struct notif_client) <alloc_event>: Return a unique_ptr.
7946         (notif_event_xfree): Don't declare.
7947         (notif_event_up): New typedef.
7948         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7949         (notif_event_xfree, do_notif_event_xfree): Remove.
7950         (remote_notif_state_xfree): Update.
7951
7952 2019-03-06  Tom Tromey  <tom@tromey.com>
7953
7954         * infrun.c (displaced_step_clear_cleanup): Now a
7955         forward_scope_exit type.
7956         (displaced_step_prepare_throw): Update.
7957         (displaced_step_fixup): Update.
7958
7959 2019-03-06  Tom Tromey  <tom@tromey.com>
7960
7961         * inferior.h (class inferior): Update comment.
7962         * gdbthread.h (class thread_info): Update comment.
7963
7964 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7965             Tom Tromey  <tom@tromey.com>
7966
7967         * stabsread.h (struct stab_section_list): Remove.
7968         (coffstab_build_psymtabs): Update.
7969         * dbxread.c (symbuf_sections): Now a std::vector.
7970         (sect_idx): New global.
7971         (fill_symbuf): Update.
7972         (coffstab_build_psymtabs): Change type of stabsects parameter.
7973         Update.
7974         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7975         std::vector.
7976         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7977         (coff_locate_sections): Update.
7978         (coff_symfile_read): Remove cleanups.  Update.
7979         (init_stringtab): Add storage parameter.
7980         (free_stringtab, free_stringtab_cleanup): Remove.
7981         (init_lineno): Add storage parameter.
7982         (free_linetab, free_linetab_cleanup): Remove.
7983
7984 2019-03-06  Pedro Alves  <palves@redhat.com>
7985
7986         * linux-fork.c (fork_info::clobber_regs): Delete.
7987         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7988         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7989         comment.  Adjust.
7990         (scoped_switch_fork_info::scoped_switch_fork_info)
7991         (checkpoint_command, linux_fork_context): Adjust
7992         fork_save_infrun_state calls.
7993
7994 2019-03-06  Pedro Alves  <palves@redhat.com>
7995
7996         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7997         (inf_has_multiple_threads): Return 'bool' and rewrite using
7998         inferior_info::threads().
7999
8000 2019-03-06  Pedro Alves  <palves@redhat.com>
8001
8002         * linux-fork.c: Include <list>.
8003         (fork_list): Now a std::list instance.
8004         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8005         (forks_exist_p, find_last_fork): Adjust.
8006         (new_fork): Delete.
8007         (one_fork_p): New.
8008         (add_fork): Adjust.
8009         (free_fork): Delete, folded into fork_info::~fork_info().
8010         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8011         Adjust.
8012         (init_fork_list): Delete.
8013         (linux_fork_killall, linux_fork_mourn_inferior)
8014         (linux_fork_detach, info_checkpoints_command): Adjust.
8015         (_initialize_linux_fork): No longer call init_fork_list.
8016
8017 2019-03-06  Pedro Alves  <palves@redhat.com>
8018
8019         * linux-fork.c (new_fork): New, split out of ...
8020         (add_fork): ... this.  Return void.  Move "first fork" special
8021         case from here, to ...
8022         (checkpoint_command): ... here.
8023         * linux-linux.h (add_fork): Return void.
8024
8025 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8026
8027         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8028
8029 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8030             Chris January  <chris.january@arm.com>
8031             David Lecomber  <david.lecomber@arm.com>
8032
8033         * f-exp.y: New token, UNOP_INTRINSIC.
8034         (exp): New pattern using UNOP_INTRINSIC token.
8035         (f77_keywords): Add 'abs' keyword.
8036         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8037         (value_from_host_double): New function.
8038         (evaluate_subexp_f): Support UNOP_ABS.
8039
8040 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8041
8042         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8043         types.
8044
8045 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8046
8047         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8048         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8049         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8050
8051 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8052
8053         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8054
8055 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8056             Chris January  <chris.january@arm.com>
8057
8058         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8059         * f-exp.y: Define 'KIND' token.
8060         (exp): New pattern for KIND expressions.
8061         (ptype): Handle types with a kind extension.
8062         (direct_abs_decl): Extend to spot kind extensions.
8063         (f77_keywords): Add 'kind' to the list.
8064         (push_kind_type): New function.
8065         (convert_to_kind_type): New function.
8066         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8067         * parse.c (operator_length_standard): Likewise.
8068         * parser-defs.h (enum type_pieces): Add tp_kind.
8069         * std-operator.def: Add UNOP_KIND.
8070
8071 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8072
8073         * f-exp.y (f_parse): Set yydebug.
8074
8075 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8076
8077         * f-lang.c (evaluate_subexp_f): New function.
8078         (exp_descriptor_f): New global.
8079         (f_language_defn): Use exp_descriptor_f instead of
8080         exp_descriptor_standard.
8081
8082 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8083
8084         * f-exp.y (struct token): Add comments.
8085         (dot_ops): Remove uppercase versions and the end marker.
8086         (f77_keywords): Likewise.
8087         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8088         entries in the dot_ops array are case insensitive, and use
8089         strncasecmp to compare strings.  Also some whitespace cleanup in
8090         this area.  Similar for the f77_keywords array, except entries in
8091         this list might be case sensitive.
8092
8093 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8094
8095         * f-exp.y (struct f77_boolean_val): Add comments.
8096         (boolean_values): Remove uppercase versions, and end marker.
8097         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8098         and use strncasecmp to achieve case insensitivity.  Additionally,
8099         perform whitespace cleanup around this code.
8100
8101 2019-03-06  Tom Tromey  <tromey@adacore.com>
8102
8103         * remote-sim.c (gdbsim_target_open): Use result of
8104         gdb_argv::release.
8105
8106 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8107         Dirk Schubert  <dirk.schubert@arm.com>
8108         Chris January  <chris.january@arm.com>
8109
8110         * eval.c (evaluate_subexp_standard): Call Fortran argument
8111         wrapping logic.
8112         * f-lang.c (struct value): A value which can be passed into a
8113         Fortran function call.
8114         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8115         where appropriate.
8116         (struct type): Value ready for a Fortran function call.
8117         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8118         is needed.
8119         * f-lang.h (fortran_argument_convert): Declaration.
8120         (fortran_preserve_arg_pointer): Declaration.
8121         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8122
8123 2019-03-05  Tom Tromey  <tromey@adacore.com>
8124
8125         * python/py-prettyprint.c (print_string_repr): Remove #if.
8126         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8127
8128 2019-03-05  Tom Tromey  <tromey@adacore.com>
8129
8130         * target.c (the_dummy_target): Move later.  Change type to
8131         "dummy_target".
8132         (initialize_targets): Don't initialize the_dummy_target.
8133
8134 2019-03-05  Tom Tromey  <tromey@adacore.com>
8135
8136         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8137         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8138
8139 2019-03-05  Tom Tromey  <tromey@adacore.com>
8140
8141         * windows-nat.c (windows_nat_target::attach)
8142         (windows_nat_target::detach): Don't call gdb_flush.
8143         * valprint.c (generic_val_print, val_print, val_print_string):
8144         Don't call gdb_flush.
8145         * utils.c (defaulted_query): Don't call gdb_flush.
8146         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8147         * target.c (target_announce_detach): Don't call gdb_flush.
8148         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8149         * remote.c (extended_remote_target::attach): Don't call
8150         gdb_flush.
8151         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8152         * printcmd.c (do_examine): Don't call gdb_flush.
8153         (info_display_command): Don't call gdb_flush.
8154         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8155         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8156         * memattr.c (info_mem_command): Don't call gdb_flush.
8157         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8158         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8159         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8160         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8161         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8162         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8163         (gnu_nat_target::detach): Don't call gdb_flush.
8164         * f-valprint.c (f_val_print): Don't call gdb_flush.
8165         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8166         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8167         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8168         gdb_flush.
8169         * c-valprint.c (c_val_print): Don't call gdb_flush.
8170         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8171
8172 2019-03-05  Tom Tromey  <tromey@adacore.com>
8173
8174         * varobj.c (update_dynamic_varobj_children): Update.
8175         (install_default_visualizer): Use reset, not release.
8176         * value.c (set_internalvar): Update.
8177         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8178         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8179         ATTRIBUTE_UNUSED_RESULT.
8180
8181 2019-03-05  Tom Tromey  <tromey@adacore.com>
8182
8183         * remote.c (class scoped_remote_fd) <release>: Add
8184         ATTRIBUTE_UNUSED_RESULT.
8185
8186 2019-03-05  Tom Tromey  <tromey@adacore.com>
8187
8188         * macroexp.c (struct macro_buffer) <release>: Add
8189         ATTRIBUTE_UNUSED_RESULT.
8190
8191 2019-03-05  Tom Tromey  <tromey@adacore.com>
8192
8193         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8194         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8195         ATTRIBUTE_UNUSED_RESULT.
8196
8197 2019-03-05  Tom Tromey  <tromey@adacore.com>
8198
8199         * common/scoped_fd.h (class scoped_fd) <release>: Add
8200         ATTRIBUTE_UNUSED_RESULT.
8201
8202 2019-03-05  Tom Tromey  <tromey@adacore.com>
8203
8204         * parser-defs.h (struct parser_state) <release>: Add
8205         ATTRIBUTE_UNUSED_RESULT.
8206
8207 2019-03-05  Tom Tromey  <tromey@adacore.com>
8208
8209         * utils.h (class gdb_argv) <release>: Add
8210         ATTRIBUTE_UNUSED_RESULT.
8211         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8212
8213 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8214
8215         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8216         for-loop range, to avoid compiler warnings.
8217
8218         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8219         avoid compiler warnings about unused variables.
8220
8221         * NEWS: Mention end of support for native debugging on MS-Windows
8222         before XP.
8223
8224         PR gdb/24292
8225         * common/netstuff.c:
8226         * gdbserver/gdbreplay.c
8227         * gdbserver/remote-utils.c:
8228         * ser-tcp.c:
8229         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8230         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8231         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8232         'getaddrinfo' and 'freeaddrinfo' were not available before
8233         Windows XP, and mingw.org's MinGW headers by default define
8234         _WIN32_WINNT to 0x500.
8235
8236 2019-03-01  Gary Benson <gbenson@redhat.com>
8237
8238         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8239
8240 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8241             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8242
8243         PR gdb/8527
8244         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8245         set_sigint_trap, clear_sigint_trap.
8246
8247 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8248
8249         * target.c (target_detach): Clear the regcache and the
8250         frame cache.
8251
8252 2019-02-27  Pedro Alves  <palves@redhat.com>
8253
8254         * utils.c (set_screen_size): When we cap the height/width sizes,
8255         tweak the corresponding command variable to show "unlimited":
8256
8257 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8258             Pedro Alves  <palves@redhat.com>
8259
8260         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8261         before calling rl_set_screen_size.
8262
8263 2019-02-27  Tom Tromey  <tromey@adacore.com>
8264
8265         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8266         define.
8267         * python/py-value.c: Remove Python 2.4 workaround.
8268         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8269         workaround.
8270         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8271         Python 2.4 workaround.
8272         * python/python-internal.h: Remove Python 2.4 comment.
8273         (Py_ssize_t): Don't define.
8274         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8275         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8276         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8277         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8278         * python/python.c (do_start_initialization): Remove Python 2.4
8279         workaround.
8280         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8281         (print_children): Remove Python 2.4 workaround.
8282         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8283         workaround.
8284         (CHARBUFFERPROC_NAME): Remove.
8285         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8286         Python 2.4 workaround.
8287
8288 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8289
8290         * NEWS: Note minimum Python version.
8291
8292 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8293
8294         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8295         code from these functions.  Remove corresponding ifdefs.  Use
8296         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8297         Remove gotos and target of gotos.
8298         (infpy_search_memory): Likewise.
8299
8300 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8301
8302         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8303         (hppa_gdbarch_init): Don't register deleted functions with
8304         gdbarch.
8305
8306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8307
8308         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8309         (h8300_unwind_sp): Delete.
8310         (h8300_dummy_id): Delete.
8311         (h8300_gdbarch_init): Don't register deleted functions with
8312         gdbarch.
8313
8314 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8315
8316         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8317         (ft32_unwind_pc): Delete.
8318         (ft32_unwind_sp): Delete.
8319         (ft32_gdbarch_init): Don't register deleted functions with
8320         gdbarch.
8321
8322 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8323
8324         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8325         (frv_unwind_pc): Delete.
8326         (frv_unwind_sp): Delete.
8327         (frv_gdbarch_init): Don't register deleted functions with
8328         gdbarch.
8329
8330 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8331
8332         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8333         (riscv_unwind_pc): Delete.
8334         (riscv_unwind_sp): Delete.
8335         (riscv_gdbarch_init): Don't register deleted functions with
8336         gdbarch.
8337
8338 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8339
8340         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8341         (csky_unwind_pc): Delete.
8342         (csky_unwind_sp): Delete.
8343         (csky_gdbarch_init): Don't register deleted functions with
8344         gdbarch.
8345
8346 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8347
8348         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8349         (cris_unwind_pc): Delete.
8350         (cris_unwind_sp): Delete.
8351         (cris_gdbarch_init): Don't register deleted functions with
8352         gdbarch.
8353
8354 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8355
8356         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8357         (bfin_unwind_pc): Delete.
8358         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8359
8360 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8361
8362         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8363         (arm_unwind_pc): Delete.
8364         (arm_unwind_sp): Delete.
8365         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8366
8367 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8368
8369         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8370         (arc_unwind_pc): Delete.
8371         (arc_unwind_sp): Delete.
8372         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8373
8374 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8375
8376         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8377         (alpha_unwind_pc): Delete.
8378         (alpha_gdbarch_init): Don't register deleted functions with
8379         gdbarch.
8380
8381 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8382
8383         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8384         (aarch64_unwind_pc): Delete.
8385         (aarch64_unwind_sp): Delete.
8386         (aarch64_gdbarch_init): Don't register deleted functions with
8387         gdbarch.
8388
8389 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8390
8391         * gdbtypes.c (type_align): Don't consider static members when
8392         computing structure alignment.
8393
8394 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8395
8396         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8397         return 0 for other types.
8398         * arch-utils.c (default_type_align): Always return 0.
8399         * gdbarch.h: Regenerate.
8400         * gdbarch.sh (type_align): Extend comment.
8401         * gdbtypes.c (type_align): Add additional comments, always call
8402         gdbarch_type_align before applying the default rules.
8403         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8404         generic code will then apply a suitable default.
8405         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8406         types, return 0 for other types.
8407
8408 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8409
8410         * NEWS: Create a new section for the next release branch.
8411         Rename the section of the current branch, now that it has
8412         been cut.
8413
8414 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8415
8416         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8417         * version.in: Bump version to 8.3.50.DATE-git.
8418
8419 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8420
8421         * aix-thread.c (ptid_cmp): Remove unused variable.
8422         (get_signaled_thread): Likewise.
8423         (store_regs_user_thread): Likewise.
8424         (store_regs_kernel_thread): Likewise.
8425         (fetch_regs_kernel_thread): Remove shadowed variable.
8426
8427 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8428
8429         * features/riscv/32bit-cpu.xml: Add register numbers.
8430         * features/riscv/32bit-fpu.c: Regenerate.
8431         * features/riscv/32bit-fpu.xml: Add register numbers.
8432         * features/riscv/64bit-cpu.xml: Add register numbers.
8433         * features/riscv/64bit-fpu.c: Regenerate.
8434         * features/riscv/64bit-fpu.xml: Add register numbers.
8435
8436 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8437
8438         * NEWS: Mention two argument form of gdb.Value constructor.
8439         * python/py-value.c (convert_buffer_and_type_to_value): New
8440         function.
8441         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8442         Add support for handling an optional second argument.  Call
8443         convert_buffer_and_type_to_value as appropriate.
8444         * python/python-internal.h (Py_buffer_deleter): New struct.
8445         (Py_buffer_up): New typedef.
8446
8447 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8448
8449         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8450         instead of releasing ownership.
8451
8452 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8453
8454         * dwarf2read.c (open_and_init_dwp_file): Call
8455         elf_numsections instead of bfd_count_sections to initialize
8456         dwp_file->num_sections.
8457
8458 2019-02-25  Tom Tromey  <tromey@adacore.com>
8459
8460         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8461
8462 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8463
8464         * gcore.in: Add '--readnever' option when invoking GDB.
8465
8466 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8467
8468         * MAINTAINERS: Update my email address.
8469
8470 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8471
8472         * build-id.c (build_id_to_debug_bfd_1): New function.
8473         (build_id_to_debug_bfd): Look for separate debug file in
8474         sysroot.
8475
8476 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8477
8478         * gdbarch.sh: Update the copyright year range that is placed into
8479         generated files.
8480
8481 2019-02-22  Keith Seitz  <keiths@redhat.com>
8482
8483         PR symtab/23853
8484         * linespec.c (create_sals_line_offset): Search for the default
8485         symtab's filename instead of its fullname.
8486
8487 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8488
8489         * NEWS: Update style defaults.
8490
8491 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8492
8493         * main.c (captured_main_1): Disable styling in batch mode.
8494
8495 2019-02-20  Tom Tromey  <tom@tromey.com>
8496
8497         * symtab.c (symtab_symbol_info): Fix typos.
8498
8499 2019-02-20  Tom Tromey  <tromey@adacore.com>
8500
8501         * findcmd.c (_initialize_mem_search): Use upper case for
8502         metasyntactic variables.
8503
8504 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8505
8506         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8507         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8508
8509 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8510
8511         * top.h (source_file_name): Change to std::string.
8512         * top.c (source_file_name): Likewise.
8513         (command_line_input): Adjust.
8514         * cli/cli-script.c (script_from_file): Adjust.
8515
8516 2019-02-19  Tom Tromey  <tromey@adacore.com>
8517
8518         * ravenscar-thread.c
8519         (ravenscar_thread_target::update_thread_list): Don't call
8520         ada_build_task_list.
8521         * ada-lang.h (ada_build_task_list): Don't declare.
8522         * ada-tasks.c (struct ada_tasks_inferior_data)
8523         <task_list_valid_p>: Now bool.
8524         (read_known_tasks, ada_task_list_changed)
8525         (ada_tasks_invalidate_inferior_data): Update.
8526         (read_known_tasks_array): Return bool.
8527         (read_known_tasks_list): Likewise.
8528         (read_known_tasks): Return void.
8529         (ada_build_task_list): Now static.
8530
8531 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8532
8533         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8534         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8535
8536 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8537
8538         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8539         variant for ada_tasks_pspace_data_handle and
8540         ada_tasks_inferior_data_handle.
8541         (ada_tasks_pspace_data_cleanup): New function.
8542         (ada_tasks_inferior_data_cleanup): New function.
8543
8544 2019-02-17  Tom Tromey  <tom@tromey.com>
8545
8546         * macrotab.h (macro_source_fullname): Return a std::string.
8547         * macrotab.c (macro_include, check_for_redefinition)
8548         (macro_undef, macro_lookup_definition, foreach_macro)
8549         (foreach_macro_in_scope): Update.
8550         (macro_source_fullname): Return a std::string.
8551         * macrocmd.c (show_pp_source_pos): Update.
8552
8553 2019-02-17  Tom Tromey  <tom@tromey.com>
8554
8555         * macrocmd.c (show_pp_source_pos): Style the file names.
8556
8557 2019-02-17  Tom Tromey  <tom@tromey.com>
8558
8559         PR tui/24197:
8560         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8561
8562 2019-02-17  Tom Tromey  <tom@tromey.com>
8563
8564         * ada-lang.c (user_select_syms): Use filtered printing.
8565         * utils.c (wrap_style): New global.
8566         (desired_style): Remove.
8567         (emit_style_escape): Add stream parameter.
8568         (set_output_style, reset_terminal_style, prompt_for_continue):
8569         Update.
8570         (flush_wrap_buffer): Only flush gdb_stdout.
8571         (wrap_here): Set wrap_style.
8572         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8573         treat escape sequences as a character.  Change when wrap buffer is
8574         flushed.
8575         (fputs_styled): Do not set the output style when the default is
8576         requested.
8577         * ui-style.h (struct ui_file_style) <is_default>: New method.
8578         * source.c (print_source_lines_base): Emit escape sequences in one
8579         piece.
8580
8581 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8582
8583         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8584         integers and enumeration types.
8585
8586 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8587
8588         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8589         instead of lookup_symbol_in_language
8590         (do_exact_match): New function.
8591         (ada_get_symbol_name_matcher): Return do_exact_match when
8592         doing a verbatim match.
8593
8594 2019-02-15  Tom Tromey  <tromey@adacore.com>
8595
8596         * ravenscar-thread.c (ravenscar_thread_target::resume)
8597         (ravenscar_thread_target::wait): Special case wildcard requests.
8598
8599 2019-02-15  Tom Tromey  <tromey@adacore.com>
8600
8601         * ravenscar-thread.c (base_ptid): Remove.
8602         (struct ravenscar_thread_target) <close>: New method.
8603         <m_base_ptid>: New member.
8604         <update_inferior_ptid, active_task, task_is_currently_active,
8605         runtime_initialized>: Declare methods.
8606         <ravenscar_thread_target>: Add constructor.
8607         (ravenscar_thread_target::task_is_currently_active)
8608         (ravenscar_thread_target::update_inferior_ptid)
8609         (ravenscar_runtime_initialized): Rename.  Now methods.
8610         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8611         (ravenscar_thread_target::update_thread_list): Update.
8612         (ravenscar_thread_target::active_task): Now method.
8613         (ravenscar_thread_target::store_registers)
8614         (ravenscar_thread_target::prepare_to_store)
8615         (ravenscar_thread_target::prepare_to_store)
8616         (ravenscar_thread_target::mourn_inferior): Update.
8617         (ravenscar_inferior_created): Use "new" to create target.
8618         (ravenscar_thread_target::get_ada_task_ptid): Update.
8619         (_initialize_ravenscar): Don't initialize base_ptid.
8620         (ravenscar_ops): Remove global.
8621
8622 2019-02-15  Tom Tromey  <tromey@adacore.com>
8623
8624         * target.h (push_target): Declare new overload.
8625         * target.c (push_target): New overload, taking an rvalue reference.
8626         * remote.c (remote_target::open_1): Use push_target overload.
8627         * corelow.c (core_target_open): Use push_target overload.
8628
8629 2019-02-15  Tom Tromey  <tromey@adacore.com>
8630
8631         * ravenscar-thread.c (is_ravenscar_task)
8632         (ravenscar_task_is_currently_active): Return bool.
8633         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8634         (_initialize_ravenscar): Remove "(void)".
8635         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8636         Return bool.
8637
8638 2019-02-15  Tom Tromey  <tromey@adacore.com>
8639
8640         * ravenscar-thread.c (ravenscar_runtime_initializer)
8641         (has_ravenscar_runtime, get_running_thread_id)
8642         (ravenscar_thread_target::resume): Fix indentation.
8643
8644 2019-02-15  Tom Tromey  <tromey@adacore.com>
8645
8646         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8647         from ravenscar_arch_ops.
8648         (sparc_ravenscar_ops::fetch_registers)
8649         (sparc_ravenscar_ops::store_registers): Now methods.
8650         (sparc_ravenscar_prepare_to_store): Remove.
8651         (sparc_ravenscar_ops): Redefine.
8652         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8653         methods and destructor.  Remove members.
8654         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8655         (ravenscar_thread_target::store_registers)
8656         (ravenscar_thread_target::prepare_to_store): Update.
8657         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8658         Remove.
8659         (struct ppc_ravenscar_powerpc_ops): Derive from
8660         ravenscar_arch_ops.
8661         (ppc_ravenscar_powerpc_ops::fetch_registers)
8662         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8663         (ppc_ravenscar_powerpc_ops): Redefine.
8664         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8665         (ppc_ravenscar_e500_ops::fetch_registers)
8666         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8667         (ppc_ravenscar_e500_ops): Redefine.
8668         * aarch64-ravenscar-thread.c
8669         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8670         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8671         (aarch64_ravenscar_fetch_registers)
8672         (aarch64_ravenscar_store_registers): Now methods.
8673         (aarch64_ravenscar_ops): Redefine.
8674
8675 2019-02-15  Tom Tromey  <tromey@adacore.com>
8676
8677         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8678         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8679         (ravenscar_thread_target::stopped_by_watchpoint)
8680         (ravenscar_thread_target::stopped_data_address)
8681         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8682
8683 2019-02-15  Tom Tromey  <tromey@adacore.com>
8684
8685         * ravenscar-thread.c: Fix some typos.
8686
8687 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8688             Tom Tromey  <tromey@adacore.com>
8689
8690         * ada-lang.c (ada_exception_sal): Change addr_string to a
8691         std::string.
8692         (create_ada_exception_catchpoint): Update.
8693
8694 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8695             Tom Tromey  <tromey@adacore.com>
8696
8697         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8698         (bp_location_ops): Remove.
8699         (base_breakpoint_allocate_location): Update.
8700         (free_bp_location): Update.
8701         * ada-lang.c (class ada_catchpoint_location)
8702         <ada_catchpoint_location>: Remove ops parameter.
8703         (ada_catchpoint_location_dtor): Remove.
8704         (ada_catchpoint_location_ops): Remove.
8705         (allocate_location_exception): Update.
8706         * breakpoint.h (struct bp_location_ops): Remove.
8707         (class bp_location) <bp_location>: Remove bp_location_ops
8708         parameter.
8709         <~bp_location>: Add destructor.
8710         <ops>: Remove.
8711
8712 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8713             Pedro Alves  <palves@redhat.com>
8714
8715         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8716         'PATH_MAX'.
8717
8718 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8719             Samuel Thibault  <samuel.thibault@gnu.org>
8720             Thomas Schwinge  <thomas@codesourcery.com>
8721
8722         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8723         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8724
8725 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8726
8727         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8728         (check_empty): Use "const char *".
8729
8730         * gnu-nat.c (gnu_nat_target::detach): Instead of
8731         'detach_inferior (pid)' call
8732         'detach_inferior (find_inferior_pid (pid))'.
8733
8734         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8735         'nat/fork-inferior.o'.
8736         * gnu-nat.c: #include "nat/fork-inferior.h".
8737
8738         * gnu-nat.c (gnu_nat_target::detach): Instead of
8739         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8740         * gnu-nat.h: #include "inf-child.h".
8741         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8742         'i386_gnu_nat_target::fetch_registers'.
8743         (gnu_store_registers): Rename/move to
8744         'i386_gnu_nat_target::store_registers'.
8745
8746         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8747         * gnu-nat.h (mach_thread_info): New function.
8748         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8749
8750         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8751
8752 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8753
8754         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8755
8756 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8757
8758         * windows-nat.c (windows_add_thread): Add new parameter
8759         "main_thread_p" with default value set to false.  Update
8760         function documentation as well as all callers.
8761         (windows_delete_thread): Likewise.
8762         (fake_create_process): Update call to windows_add_thread.
8763         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8764         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8765         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8766         call to windows_delete_thread.
8767
8768 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8769
8770         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8771
8772 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8773
8774         * symfile.c (find_separate_debug_file): Use canonical path of
8775         sysroot with child_path instead of gdb_sysroot if it is valid.
8776
8777 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8778
8779         * symfile.c (find_separate_debug_file): Use child_path to
8780         determine if an object file is under a sysroot.
8781
8782 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8783
8784         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8785         unittests/child-path-selftests.c.
8786         * common/pathstuff.c (child_path): New function.
8787         * common/pathstuff.h (child_path): New prototype.
8788         * unittests/child-path-selftests.c: New file.
8789
8790 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8791
8792         * symfile.c (find_separate_debug_file): Look for separate debug
8793         files in debug directories under the sysroot.
8794
8795 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8796
8797         * symtab.h (struct minimal_symbol data_p): New const method.
8798         (struct minimal_symbol text_p): Likewise.
8799         * symtab.c (output_source_filename): Use file name style
8800         to print file name.
8801         (print_symbol_info): Likewise.
8802         (print_msymbol_info): Use address style to print addresses.
8803         Use function name style to print executable text symbols.
8804         (expand_symtab_containing_pc): Use data_p.
8805         (find_pc_sect_compunit_symtab): Likewise.
8806
8807 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8808
8809         * breakpoint.c (describe_other_breakpoints): Use address style
8810         to print addresses.
8811         (say_where): Likewise.
8812
8813 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8814
8815         * ada-typeprint.c (print_func_type): Print function name
8816         style to print function name.
8817         * c-typeprint.c (c_print_type_1): Likewise.
8818
8819 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8820
8821         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8822         for execve.
8823
8824 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8825
8826         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8827         type_stack.
8828
8829 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8830
8831         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8832         TYPE_CODE_REF types.
8833
8834 2019-02-08  Jim Wilson  <jimw@sifive.com>
8835
8836         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8837         (riscv_linux_fregset): New.
8838         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8839
8840 2019-02-07  Tom Tromey  <tom@tromey.com>
8841
8842         * thread.c (thread_cancel_execution_command): Update.
8843         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8844         methods.
8845         (struct thread_fsm_ops): Remove.
8846         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8847         (thread_fsm_should_stop, thread_fsm_return_value)
8848         (thread_fsm_set_finished, thread_fsm_finished_p)
8849         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8850         Don't declare.
8851         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8852         * infrun.c (clear_proceed_status_thread)
8853         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8854         (print_stop_event): Update.
8855         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8856         Add constructor.
8857         (step_command_fsm_ops): Remove.
8858         (new_step_command_fsm): Remove.
8859         (step_1): Update.
8860         (step_command_fsm::should_stop): Rename from
8861         step_command_fsm_should_stop.
8862         (step_command_fsm::clean_up): Rename from
8863         step_command_fsm_clean_up.
8864         (step_command_fsm::do_async_reply_reason): Rename from
8865         step_command_fsm_async_reply_reason.
8866         (struct until_next_fsm): Inherit from thread_fsm.  Add
8867         constructor.
8868         (until_next_fsm_ops): Remove.
8869         (new_until_next_fsm): Remove.
8870         (until_next_fsm::should_stop): Rename from
8871         until_next_fsm_should_stop.
8872         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8873         (until_next_fsm::do_async_reply_reason): Rename from
8874         until_next_fsm_async_reply_reason.
8875         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8876         constructor.  Change type of breakpoint.
8877         (finish_command_fsm_ops): Remove.
8878         (new_finish_command_fsm): Remove.
8879         (finish_command_fsm::should_stop): Rename from
8880         finish_command_fsm_should_stop.
8881         (finish_command_fsm::clean_up): Rename from
8882         finish_command_fsm_clean_up.
8883         (finish_command_fsm::return_value): Rename from
8884         finish_command_fsm_return_value.
8885         (finish_command_fsm::do_async_reply_reason): Rename from
8886         finish_command_fsm_async_reply_reason.
8887         (finish_command): Update.
8888         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8889         Add constructor.
8890         (call_thread_fsm_ops): Remove.
8891         (call_thread_fsm::call_thread_fsm): Rename from
8892         new_call_thread_fsm.
8893         (call_thread_fsm::should_stop): Rename from
8894         call_thread_fsm_should_stop.
8895         (call_thread_fsm::should_notify_stop): Rename from
8896         call_thread_fsm_should_notify_stop.
8897         (run_inferior_call, call_function_by_hand_dummy): Update.
8898         * cli/cli-interp.c (should_print_stop_to_console): Update.
8899         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8900         Add constructor.  Change type of location_breakpoint,
8901         caller_breakpoint.
8902         (until_break_fsm_ops): Remove.
8903         (new_until_break_fsm): Remove.
8904         (until_break_fsm::should_stop): Rename from
8905         until_break_fsm_should_stop.
8906         (until_break_fsm::clean_up): Rename from
8907         until_break_fsm_clean_up.
8908         (until_break_fsm::do_async_reply_reason): Rename from
8909         until_break_fsm_async_reply_reason.
8910         (until_break_command): Update.
8911         * thread-fsm.c: Remove.
8912         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8913
8914 2019-02-07  Tom Tromey  <tom@tromey.com>
8915
8916         * yy-remap.h: Add include guard.
8917         * xtensa-tdep.h: Add include guard.
8918         * xcoffread.h: Rename include guard.
8919         * varobj-iter.h: Add include guard.
8920         * tui/tui.h: Rename include guard.
8921         * tui/tui-winsource.h: Rename include guard.
8922         * tui/tui-wingeneral.h: Rename include guard.
8923         * tui/tui-windata.h: Rename include guard.
8924         * tui/tui-win.h: Rename include guard.
8925         * tui/tui-stack.h: Rename include guard.
8926         * tui/tui-source.h: Rename include guard.
8927         * tui/tui-regs.h: Rename include guard.
8928         * tui/tui-out.h: Rename include guard.
8929         * tui/tui-layout.h: Rename include guard.
8930         * tui/tui-io.h: Rename include guard.
8931         * tui/tui-hooks.h: Rename include guard.
8932         * tui/tui-file.h: Rename include guard.
8933         * tui/tui-disasm.h: Rename include guard.
8934         * tui/tui-data.h: Rename include guard.
8935         * tui/tui-command.h: Rename include guard.
8936         * tic6x-tdep.h: Add include guard.
8937         * target/waitstatus.h: Rename include guard.
8938         * target/wait.h: Rename include guard.
8939         * target/target.h: Rename include guard.
8940         * target/resume.h: Rename include guard.
8941         * target-float.h: Rename include guard.
8942         * stabsread.h: Add include guard.
8943         * rs6000-tdep.h: Add include guard.
8944         * riscv-fbsd-tdep.h: Add include guard.
8945         * regformats/regdef.h: Rename include guard.
8946         * record.h: Rename include guard.
8947         * python/python.h: Rename include guard.
8948         * python/python-internal.h: Rename include guard.
8949         * python/py-stopevent.h: Rename include guard.
8950         * python/py-ref.h: Rename include guard.
8951         * python/py-record.h: Rename include guard.
8952         * python/py-record-full.h: Rename include guard.
8953         * python/py-record-btrace.h: Rename include guard.
8954         * python/py-instruction.h: Rename include guard.
8955         * python/py-events.h: Rename include guard.
8956         * python/py-event.h: Rename include guard.
8957         * procfs.h: Add include guard.
8958         * proc-utils.h: Add include guard.
8959         * p-lang.h: Add include guard.
8960         * or1k-tdep.h: Rename include guard.
8961         * observable.h: Rename include guard.
8962         * nto-tdep.h: Rename include guard.
8963         * nat/x86-linux.h: Rename include guard.
8964         * nat/x86-linux-dregs.h: Rename include guard.
8965         * nat/x86-gcc-cpuid.h: Add include guard.
8966         * nat/x86-dregs.h: Rename include guard.
8967         * nat/x86-cpuid.h: Rename include guard.
8968         * nat/ppc-linux.h: Rename include guard.
8969         * nat/mips-linux-watch.h: Rename include guard.
8970         * nat/linux-waitpid.h: Rename include guard.
8971         * nat/linux-ptrace.h: Rename include guard.
8972         * nat/linux-procfs.h: Rename include guard.
8973         * nat/linux-osdata.h: Rename include guard.
8974         * nat/linux-nat.h: Rename include guard.
8975         * nat/linux-namespaces.h: Rename include guard.
8976         * nat/linux-btrace.h: Rename include guard.
8977         * nat/glibc_thread_db.h: Rename include guard.
8978         * nat/gdb_thread_db.h: Rename include guard.
8979         * nat/gdb_ptrace.h: Rename include guard.
8980         * nat/fork-inferior.h: Rename include guard.
8981         * nat/amd64-linux-siginfo.h: Rename include guard.
8982         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8983         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8984         * nat/aarch64-linux.h: Rename include guard.
8985         * nat/aarch64-linux-hw-point.h: Rename include guard.
8986         * mn10300-tdep.h: Add include guard.
8987         * mips-linux-tdep.h: Add include guard.
8988         * mi/mi-parse.h: Rename include guard.
8989         * mi/mi-out.h: Rename include guard.
8990         * mi/mi-main.h: Rename include guard.
8991         * mi/mi-interp.h: Rename include guard.
8992         * mi/mi-getopt.h: Rename include guard.
8993         * mi/mi-console.h: Rename include guard.
8994         * mi/mi-common.h: Rename include guard.
8995         * mi/mi-cmds.h: Rename include guard.
8996         * mi/mi-cmd-break.h: Rename include guard.
8997         * m2-lang.h: Add include guard.
8998         * location.h: Rename include guard.
8999         * linux-record.h: Rename include guard.
9000         * linux-nat.h: Add include guard.
9001         * linux-fork.h: Add include guard.
9002         * i386-darwin-tdep.h: Rename include guard.
9003         * hppa-linux-offsets.h: Add include guard.
9004         * guile/guile.h: Rename include guard.
9005         * guile/guile-internal.h: Rename include guard.
9006         * gnu-nat.h: Rename include guard.
9007         * gdb-stabs.h: Rename include guard.
9008         * frv-tdep.h: Add include guard.
9009         * f-lang.h: Add include guard.
9010         * event-loop.h: Add include guard.
9011         * darwin-nat.h: Rename include guard.
9012         * cp-abi.h: Rename include guard.
9013         * config/sparc/nm-sol2.h: Rename include guard.
9014         * config/nm-nto.h: Rename include guard.
9015         * config/nm-linux.h: Add include guard.
9016         * config/i386/nm-i386gnu.h: Rename include guard.
9017         * config/djgpp/nl_types.h: Rename include guard.
9018         * config/djgpp/langinfo.h: Rename include guard.
9019         * compile/gcc-cp-plugin.h: Add include guard.
9020         * compile/gcc-c-plugin.h: Add include guard.
9021         * compile/compile.h: Rename include guard.
9022         * compile/compile-object-run.h: Rename include guard.
9023         * compile/compile-object-load.h: Rename include guard.
9024         * compile/compile-internal.h: Rename include guard.
9025         * compile/compile-cplus.h: Rename include guard.
9026         * compile/compile-c.h: Rename include guard.
9027         * common/xml-utils.h: Rename include guard.
9028         * common/x86-xstate.h: Rename include guard.
9029         * common/version.h: Rename include guard.
9030         * common/vec.h: Rename include guard.
9031         * common/tdesc.h: Rename include guard.
9032         * common/selftest.h: Rename include guard.
9033         * common/scoped_restore.h: Rename include guard.
9034         * common/scoped_mmap.h: Rename include guard.
9035         * common/scoped_fd.h: Rename include guard.
9036         * common/safe-iterator.h: Rename include guard.
9037         * common/run-time-clock.h: Rename include guard.
9038         * common/refcounted-object.h: Rename include guard.
9039         * common/queue.h: Rename include guard.
9040         * common/ptid.h: Rename include guard.
9041         * common/print-utils.h: Rename include guard.
9042         * common/preprocessor.h: Rename include guard.
9043         * common/pathstuff.h: Rename include guard.
9044         * common/observable.h: Rename include guard.
9045         * common/netstuff.h: Rename include guard.
9046         * common/job-control.h: Rename include guard.
9047         * common/host-defs.h: Rename include guard.
9048         * common/gdb_wait.h: Rename include guard.
9049         * common/gdb_vecs.h: Rename include guard.
9050         * common/gdb_unlinker.h: Rename include guard.
9051         * common/gdb_unique_ptr.h: Rename include guard.
9052         * common/gdb_tilde_expand.h: Rename include guard.
9053         * common/gdb_sys_time.h: Rename include guard.
9054         * common/gdb_string_view.h: Rename include guard.
9055         * common/gdb_splay_tree.h: Rename include guard.
9056         * common/gdb_setjmp.h: Rename include guard.
9057         * common/gdb_ref_ptr.h: Rename include guard.
9058         * common/gdb_optional.h: Rename include guard.
9059         * common/gdb_locale.h: Rename include guard.
9060         * common/gdb_assert.h: Rename include guard.
9061         * common/filtered-iterator.h: Rename include guard.
9062         * common/filestuff.h: Rename include guard.
9063         * common/fileio.h: Rename include guard.
9064         * common/environ.h: Rename include guard.
9065         * common/common-utils.h: Rename include guard.
9066         * common/common-types.h: Rename include guard.
9067         * common/common-regcache.h: Rename include guard.
9068         * common/common-inferior.h: Rename include guard.
9069         * common/common-gdbthread.h: Rename include guard.
9070         * common/common-exceptions.h: Rename include guard.
9071         * common/common-defs.h: Rename include guard.
9072         * common/common-debug.h: Rename include guard.
9073         * common/cleanups.h: Rename include guard.
9074         * common/buffer.h: Rename include guard.
9075         * common/btrace-common.h: Rename include guard.
9076         * common/break-common.h: Rename include guard.
9077         * cli/cli-utils.h: Rename include guard.
9078         * cli/cli-style.h: Rename include guard.
9079         * cli/cli-setshow.h: Rename include guard.
9080         * cli/cli-script.h: Rename include guard.
9081         * cli/cli-interp.h: Rename include guard.
9082         * cli/cli-decode.h: Rename include guard.
9083         * cli/cli-cmds.h: Rename include guard.
9084         * charset-list.h: Add include guard.
9085         * buildsym-legacy.h: Rename include guard.
9086         * bfin-tdep.h: Add include guard.
9087         * ax.h: Rename include guard.
9088         * arm-linux-tdep.h: Add include guard.
9089         * arm-fbsd-tdep.h: Add include guard.
9090         * arch/xtensa.h: Rename include guard.
9091         * arch/tic6x.h: Add include guard.
9092         * arch/i386.h: Add include guard.
9093         * arch/arm.h: Rename include guard.
9094         * arch/arm-linux.h: Rename include guard.
9095         * arch/arm-get-next-pcs.h: Rename include guard.
9096         * arch/amd64.h: Add include guard.
9097         * arch/aarch64-insn.h: Rename include guard.
9098         * arch-utils.h: Rename include guard.
9099         * annotate.h: Add include guard.
9100         * amd64-darwin-tdep.h: Rename include guard.
9101         * aarch64-linux-tdep.h: Add include guard.
9102         * aarch64-fbsd-tdep.h: Add include guard.
9103         * aarch32-linux-nat.h: Add include guard.
9104
9105 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9106
9107         * macrotab.c (macro_define_internal): New function that
9108         factorizes macro_define_object_internal and macro_define_function
9109         code.
9110         (macro_define_object_internal): Use macro_define_internal.
9111         (macro_define_function): Likewise.
9112
9113 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9114
9115         * macrocmd.c (extract_identifier): Return
9116         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9117         callers.
9118
9119 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9120
9121         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9122
9123 2019-02-05  Tom Tromey  <tom@tromey.com>
9124
9125         * target.c (target_stack::unpush): Move assertion earlier.
9126
9127 2019-01-30  Tom Tromey  <tom@tromey.com>
9128
9129         PR python/23615:
9130         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9131         (gdbpy_parse_and_eval): Likewise.
9132         * python/python-internal.h (gdbpy_allow_threads): New class.
9133
9134 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9135
9136         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9137         (aarch64_fbsd_fpregmap): Move earlier.
9138         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9139         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9140         instead of individual calls to trad_frame_set_reg_addr.
9141         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9142         earlier.
9143         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9144         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9145         instead of individual calls to trad_frame_set_reg_addr.
9146
9147 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9148
9149         * CONTRIBUTE: Replace contribution list with wiki link.
9150
9151 2019-01-25  Tom Tromey  <tom@tromey.com>
9152
9153         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9154
9155 2019-01-25  Tom Tromey  <tom@tromey.com>
9156
9157         * xtensa-linux-nat.c: Fix common/ includes.
9158         * xml-support.h: Fix common/ includes.
9159         * xml-support.c: Fix common/ includes.
9160         * x86-linux-nat.c: Fix common/ includes.
9161         * windows-nat.c: Fix common/ includes.
9162         * varobj.h: Fix common/ includes.
9163         * varobj.c: Fix common/ includes.
9164         * value.c: Fix common/ includes.
9165         * valops.c: Fix common/ includes.
9166         * utils.c: Fix common/ includes.
9167         * unittests/xml-utils-selftests.c: Fix common/ includes.
9168         * unittests/utils-selftests.c: Fix common/ includes.
9169         * unittests/unpack-selftests.c: Fix common/ includes.
9170         * unittests/tracepoint-selftests.c: Fix common/ includes.
9171         * unittests/style-selftests.c: Fix common/ includes.
9172         * unittests/string_view-selftests.c: Fix common/ includes.
9173         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9174         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9175         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9176         * unittests/rsp-low-selftests.c: Fix common/ includes.
9177         * unittests/parse-connection-spec-selftests.c: Fix common/
9178         includes.
9179         * unittests/optional-selftests.c: Fix common/ includes.
9180         * unittests/offset-type-selftests.c: Fix common/ includes.
9181         * unittests/observable-selftests.c: Fix common/ includes.
9182         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9183         * unittests/memrange-selftests.c: Fix common/ includes.
9184         * unittests/memory-map-selftests.c: Fix common/ includes.
9185         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9186         * unittests/function-view-selftests.c: Fix common/ includes.
9187         * unittests/environ-selftests.c: Fix common/ includes.
9188         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9189         * unittests/common-utils-selftests.c: Fix common/ includes.
9190         * unittests/cli-utils-selftests.c: Fix common/ includes.
9191         * unittests/array-view-selftests.c: Fix common/ includes.
9192         * ui-file.c: Fix common/ includes.
9193         * tui/tui-io.c: Fix common/ includes.
9194         * tracepoint.h: Fix common/ includes.
9195         * tracepoint.c: Fix common/ includes.
9196         * tracefile-tfile.c: Fix common/ includes.
9197         * top.h: Fix common/ includes.
9198         * top.c: Fix common/ includes.
9199         * thread.c: Fix common/ includes.
9200         * target/waitstatus.h: Fix common/ includes.
9201         * target/waitstatus.c: Fix common/ includes.
9202         * target.h: Fix common/ includes.
9203         * target.c: Fix common/ includes.
9204         * target-memory.c: Fix common/ includes.
9205         * target-descriptions.c: Fix common/ includes.
9206         * symtab.h: Fix common/ includes.
9207         * symfile.c: Fix common/ includes.
9208         * stap-probe.c: Fix common/ includes.
9209         * spu-linux-nat.c: Fix common/ includes.
9210         * sparc-nat.c: Fix common/ includes.
9211         * source.c: Fix common/ includes.
9212         * solib.c: Fix common/ includes.
9213         * solib-target.c: Fix common/ includes.
9214         * ser-unix.c: Fix common/ includes.
9215         * ser-tcp.c: Fix common/ includes.
9216         * ser-pipe.c: Fix common/ includes.
9217         * ser-base.c: Fix common/ includes.
9218         * selftest-arch.c: Fix common/ includes.
9219         * s12z-tdep.c: Fix common/ includes.
9220         * rust-exp.y: Fix common/ includes.
9221         * rs6000-aix-tdep.c: Fix common/ includes.
9222         * riscv-tdep.c: Fix common/ includes.
9223         * remote.c: Fix common/ includes.
9224         * remote-notif.h: Fix common/ includes.
9225         * remote-fileio.h: Fix common/ includes.
9226         * remote-fileio.c: Fix common/ includes.
9227         * regcache.h: Fix common/ includes.
9228         * regcache.c: Fix common/ includes.
9229         * record-btrace.c: Fix common/ includes.
9230         * python/python.c: Fix common/ includes.
9231         * python/py-type.c: Fix common/ includes.
9232         * python/py-inferior.c: Fix common/ includes.
9233         * progspace.h: Fix common/ includes.
9234         * producer.c: Fix common/ includes.
9235         * procfs.c: Fix common/ includes.
9236         * proc-api.c: Fix common/ includes.
9237         * printcmd.c: Fix common/ includes.
9238         * ppc-linux-nat.c: Fix common/ includes.
9239         * parser-defs.h: Fix common/ includes.
9240         * osdata.c: Fix common/ includes.
9241         * obsd-nat.c: Fix common/ includes.
9242         * nat/x86-linux.c: Fix common/ includes.
9243         * nat/x86-linux-dregs.c: Fix common/ includes.
9244         * nat/x86-dregs.h: Fix common/ includes.
9245         * nat/x86-dregs.c: Fix common/ includes.
9246         * nat/ppc-linux.c: Fix common/ includes.
9247         * nat/mips-linux-watch.h: Fix common/ includes.
9248         * nat/mips-linux-watch.c: Fix common/ includes.
9249         * nat/linux-waitpid.c: Fix common/ includes.
9250         * nat/linux-ptrace.h: Fix common/ includes.
9251         * nat/linux-ptrace.c: Fix common/ includes.
9252         * nat/linux-procfs.c: Fix common/ includes.
9253         * nat/linux-personality.c: Fix common/ includes.
9254         * nat/linux-osdata.c: Fix common/ includes.
9255         * nat/linux-namespaces.c: Fix common/ includes.
9256         * nat/linux-btrace.h: Fix common/ includes.
9257         * nat/linux-btrace.c: Fix common/ includes.
9258         * nat/fork-inferior.c: Fix common/ includes.
9259         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9260         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9261         * nat/aarch64-linux.c: Fix common/ includes.
9262         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9263         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9264         * namespace.h: Fix common/ includes.
9265         * mips-linux-tdep.c: Fix common/ includes.
9266         * minsyms.c: Fix common/ includes.
9267         * mi/mi-parse.h: Fix common/ includes.
9268         * mi/mi-main.c: Fix common/ includes.
9269         * mi/mi-cmd-env.c: Fix common/ includes.
9270         * memrange.h: Fix common/ includes.
9271         * memattr.c: Fix common/ includes.
9272         * maint.h: Fix common/ includes.
9273         * maint.c: Fix common/ includes.
9274         * main.c: Fix common/ includes.
9275         * machoread.c: Fix common/ includes.
9276         * location.c: Fix common/ includes.
9277         * linux-thread-db.c: Fix common/ includes.
9278         * linux-nat.c: Fix common/ includes.
9279         * linux-fork.c: Fix common/ includes.
9280         * inline-frame.c: Fix common/ includes.
9281         * infrun.c: Fix common/ includes.
9282         * inflow.c: Fix common/ includes.
9283         * inferior.h: Fix common/ includes.
9284         * inferior.c: Fix common/ includes.
9285         * infcmd.c: Fix common/ includes.
9286         * inf-ptrace.c: Fix common/ includes.
9287         * inf-child.c: Fix common/ includes.
9288         * ia64-linux-nat.c: Fix common/ includes.
9289         * i387-tdep.c: Fix common/ includes.
9290         * i386-tdep.c: Fix common/ includes.
9291         * i386-linux-tdep.c: Fix common/ includes.
9292         * i386-linux-nat.c: Fix common/ includes.
9293         * i386-go32-tdep.c: Fix common/ includes.
9294         * i386-fbsd-tdep.c: Fix common/ includes.
9295         * i386-fbsd-nat.c: Fix common/ includes.
9296         * guile/scm-type.c: Fix common/ includes.
9297         * guile/guile.c: Fix common/ includes.
9298         * go32-nat.c: Fix common/ includes.
9299         * gnu-nat.c: Fix common/ includes.
9300         * gdbthread.h: Fix common/ includes.
9301         * gdbarch-selftests.c: Fix common/ includes.
9302         * gdb_usleep.c: Fix common/ includes.
9303         * gdb_select.h: Fix common/ includes.
9304         * gdb_bfd.c: Fix common/ includes.
9305         * gcore.c: Fix common/ includes.
9306         * fork-child.c: Fix common/ includes.
9307         * findvar.c: Fix common/ includes.
9308         * fbsd-nat.c: Fix common/ includes.
9309         * event-top.c: Fix common/ includes.
9310         * event-loop.c: Fix common/ includes.
9311         * dwarf2read.c: Fix common/ includes.
9312         * dwarf2loc.c: Fix common/ includes.
9313         * dwarf2-frame.c: Fix common/ includes.
9314         * dwarf-index-cache.c: Fix common/ includes.
9315         * dtrace-probe.c: Fix common/ includes.
9316         * disasm-selftests.c: Fix common/ includes.
9317         * defs.h: Fix common/ includes.
9318         * csky-tdep.c: Fix common/ includes.
9319         * cp-valprint.c: Fix common/ includes.
9320         * cp-support.h: Fix common/ includes.
9321         * cp-support.c: Fix common/ includes.
9322         * corelow.c: Fix common/ includes.
9323         * completer.h: Fix common/ includes.
9324         * completer.c: Fix common/ includes.
9325         * compile/compile.c: Fix common/ includes.
9326         * compile/compile-loc2c.c: Fix common/ includes.
9327         * compile/compile-cplus-types.c: Fix common/ includes.
9328         * compile/compile-cplus-symbols.c: Fix common/ includes.
9329         * command.h: Fix common/ includes.
9330         * cli/cli-dump.c: Fix common/ includes.
9331         * cli/cli-cmds.c: Fix common/ includes.
9332         * charset.c: Fix common/ includes.
9333         * build-id.c: Fix common/ includes.
9334         * btrace.h: Fix common/ includes.
9335         * btrace.c: Fix common/ includes.
9336         * breakpoint.h: Fix common/ includes.
9337         * breakpoint.c: Fix common/ includes.
9338         * ax.h:
9339         (enum agent_op): Fix common/ includes.
9340         * ax-general.c (struct aop_map): Fix common/ includes.
9341         * ax-gdb.c: Fix common/ includes.
9342         * auxv.c: Fix common/ includes.
9343         * auto-load.c: Fix common/ includes.
9344         * arm-tdep.c: Fix common/ includes.
9345         * arch/riscv.c: Fix common/ includes.
9346         * arch/ppc-linux-common.c: Fix common/ includes.
9347         * arch/i386.c: Fix common/ includes.
9348         * arch/arm.c: Fix common/ includes.
9349         * arch/arm-linux.c: Fix common/ includes.
9350         * arch/arm-get-next-pcs.c: Fix common/ includes.
9351         * arch/amd64.c: Fix common/ includes.
9352         * arch/aarch64.c: Fix common/ includes.
9353         * arch/aarch64-insn.c: Fix common/ includes.
9354         * arch-utils.c: Fix common/ includes.
9355         * amd64-windows-tdep.c: Fix common/ includes.
9356         * amd64-tdep.c: Fix common/ includes.
9357         * amd64-sol2-tdep.c: Fix common/ includes.
9358         * amd64-obsd-tdep.c: Fix common/ includes.
9359         * amd64-nbsd-tdep.c: Fix common/ includes.
9360         * amd64-linux-tdep.c: Fix common/ includes.
9361         * amd64-linux-nat.c: Fix common/ includes.
9362         * amd64-fbsd-tdep.c: Fix common/ includes.
9363         * amd64-fbsd-nat.c: Fix common/ includes.
9364         * amd64-dicos-tdep.c: Fix common/ includes.
9365         * amd64-darwin-tdep.c: Fix common/ includes.
9366         * agent.c: Fix common/ includes.
9367         * ada-lang.h: Fix common/ includes.
9368         * ada-lang.c: Fix common/ includes.
9369         * aarch64-tdep.c: Fix common/ includes.
9370
9371 2019-01-25  Tom Tromey  <tom@tromey.com>
9372
9373         * common/create-version.sh: Use common/version.h.
9374
9375 2019-01-24  Pedro Alves  <palves@redhat.com>
9376
9377         * infrun.c (signal_stop, signal_print, signal_program)
9378         (signal_catch, signal_pass): Now arrays instead of pointers.
9379         (update_signals_program_target, do_target_resume)
9380         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9381         * linux-nat.c (linux_nat_target::pass_signals)
9382         (linux_nat_target::create_inferior, linux_nat_target::attach):
9383         Adjust.
9384         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9385         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9386         * procfs.c (procfs_target::pass_signals): Adjust.
9387         * record-full.c (record_full_target::resume): Adjust.
9388         * remote.c (remote_target::pass_signals)
9389         (remote_target::program_signals): Adjust.
9390         * target-debug.h (target_debug_print_signals): Now takes a
9391         gdb::array_view as parameter.  Adjust.
9392         * target.h (target_ops) <pass_signals, program_signals>: Replace
9393         pointer and length parameters with gdb::array_view.
9394         (target_pass_signals, target_program_signals): Likewise.
9395         * target-delegates.c: Regenerate.
9396
9397 2019-01-24  Pedro Alves  <palves@redhat.com>
9398
9399         * common/forward-scope-exit.h
9400         (forward_scope_exit::forward_scope_exit): Pass arguments to
9401         m_bind_function directly, instead of creating a std::bind and
9402         copying that.
9403
9404 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9405
9406         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9407         for static members.
9408         (pass_in_v_vfp_candidate): Likewise.
9409
9410 2019-01-23  Tom Tromey  <tom@tromey.com>
9411             Pedro Alves  <palves@redhat.com>
9412
9413         * regcache.c (class regcache_invalidator): Remove.
9414         (regcache::raw_write): Use make_scope_exit.
9415
9416 2019-01-23  Tom Tromey  <tom@tromey.com>
9417
9418         * ui-out.h (class ui_out_emit_type): Update comment.
9419
9420 2019-01-23  Tom Tromey  <tom@tromey.com>
9421
9422         * infrun.c (fetch_inferior_event): Update comment.
9423
9424 2019-01-23  Tom Tromey  <tom@tromey.com>
9425             Pedro Alves  <palves@redhat.com>
9426
9427         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9428         parameter.
9429         (fetch_inferior_event): Use SCOPE_EXIT.
9430
9431
9432 2019-01-23  Tom Tromey  <tom@tromey.com>
9433             Pedro Alves  <palves@redhat.com>
9434
9435         * infrun.c (disable_thread_events): Delete.
9436         (stop_all_threads): Use SCOPE_EXIT.
9437
9438 2019-01-23  Tom Tromey  <tom@tromey.com>
9439             Pedro Alves  <palves@redhat.com>
9440
9441         * symfile.c: Include forward-scope-exit.h.
9442         (clear_symtab_users_cleanup): Replace forward declaration with
9443         a FORWARD_SCOPE_EXIT.
9444         (syms_from_objfile_1): Use the forward_scope_exit and
9445         gdb::optional instead of cleanup_function.
9446         (reread_symbols): Use the forward_scope_exit instead of
9447         cleanup_function.
9448         (clear_symtab_users_cleanup): Remove function.
9449
9450 2019-01-23  Tom Tromey  <tom@tromey.com>
9451             Pedro Alves  <palves@redhat.com>
9452
9453         * linux-nat.c: Include scope-exit.h.
9454         (cleanup_target_stop): Remove.
9455         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9456         SCOPE_EXIT.
9457
9458 2019-01-23  Tom Tromey  <tom@tromey.com>
9459             Pedro Alves  <palves@redhat.com>
9460
9461         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9462         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9463
9464 2019-01-23  Tom Tromey  <tom@tromey.com>
9465             Andrew Burgess  <andrew.burgess@embecosm.com>
9466             Pedro Alves  <palves@redhat.com>
9467
9468         * infrun.c (fetch_inferior_event): Use scope_exit.
9469         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9470         * top.c (execute_command): Use scope_exit.
9471         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9472         * utils.c (do_bpstat_clear_actions_cleanup)
9473         (make_bpstat_clear_actions_cleanup): Remove.
9474
9475 2019-01-23  Tom Tromey  <tom@tromey.com>
9476             Pedro Alves  <palves@redhat.com>
9477
9478         * infrun.c: Include "common/scope-exit.h"
9479         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9480         (wait_for_inferior): Use SCOPE_EXIT.
9481         (fetch_inferior_event): Use scope_exit.
9482
9483 2019-01-23  Tom Tromey  <tom@tromey.com>
9484             Pedro Alves  <palves@redhat.com>
9485
9486         * breakpoint.c (create_breakpoint): Remove cleanup.
9487
9488 2019-01-23  Tom Tromey  <tom@tromey.com>
9489             Andrew Burgess  <andrew.burgess@embecosm.com>
9490             Pedro Alves  <palves@redhat.com>
9491
9492 2019-01-23  Pedro Alves  <palves@redhat.com>
9493
9494         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9495
9496 2019-01-23  Pedro Alves  <palves@redhat.com>
9497             Andrew Burgess  <andrew.burgess@embecosm.com>
9498
9499         * gdbthread.h: Include "common/forward-scope-exit.h".
9500         (scoped_finish_thread_state): Redefine custom class in terms of
9501         forward_scope_exit.
9502
9503 2019-01-23  Pedro Alves  <palves@redhat.com>
9504             Andrew Burgess  <andrew.burgess@embecosm.com>
9505
9506         * common/forward-scope-exit.h: New file.
9507
9508 2019-01-23  Pedro Alves  <palves@redhat.com>
9509             Andrew Burgess  <andrew.burgess@embecosm.com>
9510             Tom Tromey  <tom@tromey.com>
9511
9512         * common/scope-exit.h: New file.
9513
9514 2019-01-23  Pedro Alves  <palves@redhat.com>
9515
9516         * common/preprocessor.h (ESC): Rename to ...
9517         (ESC_PARENS): ... this.
9518         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9519         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9520
9521 2019-01-23  Tom Tromey  <tom@tromey.com>
9522
9523         * language.h (class scoped_switch_to_sym_language_if_auto):
9524         Initialize m_lang in both cases.
9525
9526 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9527
9528         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9529         with XCNEW.
9530
9531 2019-01-22  Tom Tromey  <tom@tromey.com>
9532
9533         * corelow.c: Do not include sys/file.h.
9534
9535 2019-01-22  Tom Tromey  <tom@tromey.com>
9536
9537         * tui/tui-wingeneral.h: Include gdb_curses.h.
9538
9539 2019-01-22  Tom Tromey  <tom@tromey.com>
9540
9541         * source-cache.h (class source_cache) <get_source_lines,
9542         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9543
9544 2019-01-22  Tom Tromey  <tom@tromey.com>
9545
9546         * remote-fileio.h (struct remote_target): Declare.
9547
9548 2019-01-22  Tom Tromey  <tom@tromey.com>
9549
9550         * python/py-arch.c: Do not include py-ref.h.
9551         * python/py-bpevent.c: Do not include py-ref.h.
9552         * python/py-cmd.c: Do not include py-ref.h.
9553         * python/py-continueevent.c: Do not include py-ref.h.
9554         * python/py-event.h: Do not include py-ref.h.
9555         * python/py-evtregistry.c: Do not include py-ref.h.
9556         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9557         * python/py-frame.c: Do not include py-ref.h.
9558         * python/py-framefilter.c: Do not include py-ref.h.
9559         * python/py-function.c: Do not include py-ref.h.
9560         * python/py-infevents.c: Do not include py-ref.h.
9561         * python/py-linetable.c: Do not include py-ref.h.
9562         * python/py-objfile.c: Do not include py-ref.h.
9563         * python/py-param.c: Do not include py-ref.h.
9564         * python/py-prettyprint.c: Do not include py-ref.h.
9565         * python/py-progspace.c: Do not include py-ref.h.
9566         * python/py-symbol.c: Do not include py-ref.h.
9567         * python/py-symtab.c: Do not include py-ref.h.
9568         * python/py-type.c: Do not include py-ref.h.
9569         * python/py-unwind.c: Do not include py-ref.h.
9570         * python/py-utils.c: Do not include py-ref.h.
9571         * python/py-value.c: Do not include py-ref.h.
9572         * python/py-varobj.c: Do not include py-ref.h.
9573         * python/py-xmethods.c: Do not include py-ref.h.
9574         * python/python.c: Do not include py-ref.h.
9575         * varobj.c: Do not include py-ref.h.
9576
9577 2019-01-22  Tom Tromey  <tom@tromey.com>
9578
9579         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9580         keyword for bcache.
9581
9582 2019-01-22  Tom Tromey  <tom@tromey.com>
9583
9584         * compile/compile-cplus-types.c: Remove a comment by #include.
9585
9586 2019-01-22  Tom Tromey  <tom@tromey.com>
9587
9588         * compile/gcc-c-plugin.h: Include compile-internal.h.
9589
9590 2019-01-22  Tom Tromey  <tom@tromey.com>
9591
9592         * stabsread.c (EXTERN): Do not define.
9593         (symnum, next_symbol_text_func, processing_gcc_compilation)
9594         (within_function, global_sym_chain, global_stabs)
9595         (previous_stab_code, this_object_header_files)
9596         (n_this_object_header_files)
9597         (n_allocated_this_object_header_files): Define.
9598         * stabsread.h (EXTERN): Never define.  Use "extern".
9599
9600 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9601
9602         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9603         history_value.
9604
9605 2019-01-21  Tom Tromey  <tom@tromey.com>
9606
9607         * ui-out.c: Fix includes.
9608         * tui/tui-source.c: Fix includes.
9609         * target.c: Fix includes.
9610         * remote.c: Fix includes.
9611         * regcache.c: Fix includes.
9612         * python/py-block.c: Fix includes.
9613         * printcmd.c: Fix includes.
9614         * or1k-tdep.c: Fix includes.
9615         * mi/mi-main.c: Fix includes.
9616         * m32r-tdep.c: Fix includes.
9617         * csky-tdep.c: Fix includes.
9618         * compile/compile-cplus-types.c: Fix includes.
9619         * cli/cli-interp.c: Fix includes.
9620
9621 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9622
9623         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9624         for padding.
9625
9626 2019-01-16  Tom Tromey  <tom@tromey.com>
9627
9628         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9629         earlier.
9630         (struct objfile) <msymbols_range>: Move from top level.
9631         <msymbols>: New method.
9632         (class objfile_msymbols): Remove.
9633         * symtab.c (default_collect_symbol_completion_matches_break_on):
9634         Update.
9635         * symmisc.c (dump_msymbols): Update.
9636         * stabsread.c (scan_file_globals): Update.
9637         * objc-lang.c (info_selectors_command, info_classes_command)
9638         (find_methods): Update.
9639         * minsyms.c (find_solib_trampoline_target): Update.
9640         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9641         * coffread.c (coff_symfile_read): Update.
9642         * ada-lang.c (ada_lookup_simple_minsym)
9643         (ada_collect_symbol_completion_matches): Update.
9644
9645 2019-01-16  Tom Tromey  <tom@tromey.com>
9646
9647         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9648         type.  Remove no-argument constructor.
9649         <iterator::operator++>: Simplify.
9650         <begin>: Update.
9651         <end>: Use minimal_symbol_count.
9652
9653 2019-01-16  Tom Tromey  <tom@tromey.com>
9654
9655         * objfiles.h (struct objfile) <psymtabs>: New method.
9656         (class objfile_psymtabs): Remove.
9657         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9658         typedef.
9659         <range>: New method.
9660         (require_partial_symbols): Change return type.
9661         * psymtab.c (require_partial_symbols)
9662         (psym_expand_symtabs_matching): Update.
9663         * mdebugread.c (parse_partial_symbols): Update.
9664         * dbxread.c (dbx_end_psymtab): Update.
9665
9666 2019-01-15  Tom Tromey  <tom@tromey.com>
9667
9668         * symtab.c (lookup_objfile_from_block)
9669         (lookup_symbol_in_objfile_symtabs)
9670         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9671         (find_line_symtab, info_sources_command)
9672         (default_collect_symbol_completion_matches_break_on)
9673         (make_source_files_completion_list): Update.
9674         * symmisc.c (print_objfile_statistics, dump_objfile)
9675         (maintenance_print_symbols, maintenance_info_symtabs)
9676         (maintenance_check_symtabs, maintenance_info_line_tables):
9677         Update.
9678         * source.c (select_source_symtab)
9679         (forget_cached_source_info_for_objfile): Update.
9680         * objfiles.h (class objfile_compunits): Remove.
9681         (struct objfile) <compunits_range>: New typedef.
9682         (compunits): New method.
9683         * objfiles.c (objfile_relocate1): Update.
9684         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9685         * maint.c (count_symtabs_and_blocks): Update.
9686         * linespec.c (iterate_over_all_matching_symtabs): Update.
9687         * cp-support.c (add_symbol_overload_list_qualified): Update.
9688         * coffread.c (coff_symtab_read): Update.
9689         * ada-lang.c (add_nonlocal_symbols)
9690         (ada_collect_symbol_completion_matches)
9691         (ada_add_global_exceptions): Update.
9692
9693 2019-01-15  Tom Tromey  <tom@tromey.com>
9694
9695         * progspace.h (program_space) <objfiles_safe_range>: New
9696         typedef.
9697         <objfiles_safe>: New method.
9698         * objfiles.h (class all_objfiles_safe): Remove.
9699         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9700         * jit.c (jit_inferior_exit_hook): Update.
9701
9702 2019-01-17  Tom Tromey  <tom@tromey.com>
9703
9704         * progspace.h (program_space) <objfiles_range>: New typedef.
9705         <objfiles>: New method.
9706         <objfiles_head>: Rename from objfiles.
9707         (object_files): Update.
9708         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9709         * guile/scm-pretty-print.c
9710         (ppscm_find_pretty_printer_from_objfiles): Update.
9711         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9712         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9713         Update.
9714         * python/py-progspace.c (pspy_get_objfiles): Update.
9715         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9716         Update.
9717         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9718         (objfpy_lookup_objfile_by_build_id): Update.
9719         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9720         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9721         Update.
9722         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9723         (expand_symtab_containing_pc, lookup_objfile_from_block)
9724         (lookup_static_symbol, basic_lookup_transparent_type)
9725         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9726         (find_line_symtab, info_sources_command)
9727         (default_collect_symbol_completion_matches_break_on)
9728         (make_source_files_completion_list, find_main_name): Update.
9729         * symmisc.c (print_symbol_bcache_statistics)
9730         (print_objfile_statistics, maintenance_print_symbols)
9731         (maintenance_print_msymbols, maintenance_print_objfiles)
9732         (maintenance_info_symtabs, maintenance_check_symtabs)
9733         (maintenance_expand_symtabs, maintenance_info_line_tables):
9734         Update.
9735         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9736         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9737         (map_overlay_command, unmap_overlay_command)
9738         (simple_overlay_update, expand_symtabs_matching)
9739         (map_symbol_filenames): Update.
9740         * symfile-debug.c (set_debug_symfile): Update.
9741         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9742         Update.
9743         * source.c (select_source_symtab, forget_cached_source_info):
9744         Update.
9745         * solib.c (solib_read_symbols): Update.
9746         * solib-spu.c (append_ocl_sos): Update.
9747         * psymtab.c (maintenance_print_psymbols)
9748         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9749         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9750         * printcmd.c (info_symbol_command): Update.
9751         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9752         Update.
9753         * objfiles.h (class all_objfiles): Remove.
9754         * objfiles.c (have_partial_symbols, have_full_symbols)
9755         (have_minimal_symbols, qsort_cmp, update_section_map)
9756         (shared_objfile_contains_address_p)
9757         (default_iterate_over_objfiles_in_search_order): Update.
9758         * objc-lang.c (info_selectors_command, info_classes_command)
9759         (find_methods): Update.
9760         * minsyms.c (find_solib_trampoline_target): Update.
9761         * maint.c (maintenance_info_sections)
9762         (maintenance_translate_address, count_symtabs_and_blocks):
9763         Update.
9764         * main.c (captured_main_1): Update.
9765         * linux-thread-db.c (try_thread_db_load_from_pdir)
9766         (has_libpthread): Update.
9767         * linespec.c (iterate_over_all_matching_symtabs)
9768         (search_minsyms_for_name): Update.
9769         * jit.c (jit_find_objf_with_entry_addr): Update.
9770         * hppa-tdep.c (find_unwind_entry)
9771         (hppa_lookup_stub_minimal_symbol): Update.
9772         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9773         Update.
9774         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9775         (elf_gnu_ifunc_resolve_by_got): Update.
9776         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9777         * dwarf-index-write.c (save_gdb_index_command): Update.
9778         * cp-support.c (add_symbol_overload_list_qualified): Update.
9779         * breakpoint.c (create_overlay_event_breakpoint)
9780         (create_longjmp_master_breakpoint)
9781         (create_std_terminate_master_breakpoint)
9782         (create_exception_master_breakpoint): Update.
9783         * blockframe.c (find_pc_partial_function): Update.
9784         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9785         (ada_collect_symbol_completion_matches)
9786         (ada_add_global_exceptions): Update.
9787
9788 2019-01-17  Tom Tromey  <tom@tromey.com>
9789
9790         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9791         declare VEC.
9792         (solib_target_parse_libraries): Change return type.
9793         (library_list_start_segment, library_list_start_section)
9794         (library_list_end_library, library_list_start_library); Update.
9795         (solib_target_free_library_list): Remove.
9796         (solib_target_parse_libraries): Remove cleanup.  Change return
9797         type.
9798         (solib_target_current_sos): Update.
9799
9800 2019-01-17  Tom Tromey  <tromey@bapiya>
9801
9802         * valprint.c: Replace "the the" with "the".
9803         * symtab.c: Replace "the the" with "the".
9804         * solib.c: Replace "the the" with "the".
9805         * solib-dsbt.c: Replace "the the" with "the".
9806         * linespec.c: Replace "the the" with "the".
9807         * dwarf2loc.h: Replace "the the" with "the".
9808         * amd64-windows-tdep.c: Replace "the the" with "the".
9809         * aarch64-tdep.c: Replace "the the" with "the".
9810
9811 2019-01-16  Keith Seitz  <keiths@redhat.com>
9812
9813         PR gdb/23773
9814         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9815         <builder>: Rename to ..
9816         <m_builder>: ... this and make private.
9817         (dwarf2_cu::get_builder): New method.  Change all users of
9818         `builder' to use this method.
9819         (dwarf2_start_symtab): Move to ...
9820         (dwarf2_cu::start_symtab): ... here.  Update all callers
9821         (setup_type_unit_groups): Move to ...
9822         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9823         callers.
9824         (dwarf2_cu::reset_builder): New method.
9825         (process_full_compunit, process_full_type_unit): Use
9826         dwarf2_cu::reset_builder.
9827         (follow_die_offset): Record the ancestor CU if it is different
9828         from the followed DIE's CU.
9829         (follow_die_sig_1): Likewise.
9830
9831 2019-01-15  Tom Tromey  <tom@tromey.com>
9832
9833         * remote.c (class remote_state) <buf>: Now a char_vector.
9834         <buf_size>: Remove.
9835         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9836         parameter.
9837         (remote_target::getpkt_or_notif_sane_1)
9838         (remote_target::getpkt_sane)
9839         (remote_target::getpkt_or_notif_sane): Likewise.
9840         (class remote_target) <putpkt>: New overload.
9841         (remote_target::read_frame): Change type of "buf_p".  Remove
9842         sizeof_p parameter.
9843         (packet_ok): New overload.
9844         (packet_check_result): New overload.
9845         Update all uses.
9846
9847 2019-01-14  Tom Tromey  <tom@tromey.com>
9848
9849         * remote-notif.c (handle_notification, remote_notif_ack)
9850         (remote_notif_parse): Make "buf" const.
9851         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9852         const.
9853         (remote_notif_parse, remote_notif_ack, handle_notification):
9854         Likewise.
9855         * remote.c (remote_notif_stop_parse): Make "buf" const.
9856         (remote_target::remote_parse_stop_reply): Make "buf" const.
9857         (remote_notif_stop_ack): Make "buf" const.
9858
9859 2019-01-14  Tom Tromey  <tom@tromey.com>
9860
9861         * remote.c (remote_console_output): Make parameter const.
9862
9863 2019-01-14  Tom Tromey  <tom@tromey.com>
9864
9865         * target-debug.h (target_debug_print_signals): Constify.
9866         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9867         * procfs.c (procfs_target::pass_signals): Update.
9868         * linux-nat.c (linux_nat_target::pass_signals): Update.
9869         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9870         * target-delegates.c: Rebuild.
9871         * remote.c (remote_target::program_signals): Update.
9872         (remote_target::pass_signals): Update.
9873         * target.c (target_pass_signals): Constify argument.
9874         (target_program_signals): Likewise.
9875         * target.h (struct target_ops) <pass_signals, program_signals>:
9876         Constify argument.
9877         (target_pass_signals, target_program_signals): Constify argument.
9878
9879 2019-01-14  Tom Tromey  <tom@tromey.com>
9880
9881         PR tui/28819:
9882         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9883
9884 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9885
9886         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9887         field.
9888         * rs6000-tdep.c: Include reggroups.h.
9889         (IS_V_ALIAS_PSEUDOREG): Define.
9890         (rs6000_register_name): Return names for the "vX" aliases.
9891         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9892         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9893         aliases.  Call default_register_reggroup_p for all other
9894         pseudo-registers.
9895         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9896         New functions.
9897         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9898         Handle "vX" aliases.
9899         (v_alias_pseudo_register_collect): New function.
9900         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9901         (rs6000_gdbarch_init): Initialize "vX" aliases as
9902         pseudo-registers.  Restore registration of
9903         rs6000_pseudo_register_reggroup_p with
9904         set_tdesc_pseudo_register_reggroup_p.
9905
9906 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9907
9908         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9909         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9910         set_gdbarch_num_pseudo_regs.
9911
9912 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9913
9914         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9915         Remove arg prefixname, add do_set and do_show.
9916         Add member functions set_list and show_list.
9917         * cli/cli-style.c (class cli_style_option): Update accordingly.
9918         (style_set_list): Move to file scope.
9919         (style_show_list): Likewise.
9920         (set_style): Call help_list.
9921         (show_style): Call cmd_show_list.
9922         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9923         Update to use the new macro.
9924
9925 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9926
9927         * ada-lang.c (_initialize_ada_language): Expand the help text
9928         for the "catch exception" command.
9929
9930 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9931
9932         * symtab.c (matching_obj_sections): Initialize obj,
9933         declare it closer to its usage.
9934
9935 2019-01-10  Tom Tromey  <tom@tromey.com>
9936
9937         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9938         (basic_inf_threads_range): Remove.
9939         (inf_threads_range, inf_non_exited_threads_range)
9940         (safe_inf_threads_range): Use next_adapter.
9941
9942 2019-01-10  Keith Seitz  <keiths@redhat.com>
9943
9944         PR gdb/23712
9945         PR symtab/23010
9946         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9947         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9948
9949 2019-01-10  Keith Seitz  <keiths@redhat.com>
9950
9951         PR gdb/23712
9952         PR symtab/23010
9953         * dictionary.c (pending_to_vector): Remove.
9954         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9955         Remove _1 suffix, replacing functions of the same name.  Update
9956         all callers.
9957         (dict_create_hashed, dict_create_hashed_expandable)
9958         (dict_create_linear, dict_create_linear_expandable, dict_free)
9959         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9960         Make functions static.
9961
9962 2019-01-10  Keith Seitz  <keiths@redhat.com>
9963
9964         PR gdb/23712
9965         PR symtab/23010
9966         * dictionary.h (struct dictionary): Replace declaration with
9967         multidictionary.
9968         (dict_create_hashed, dict_create_hashed_expandable)
9969         (dict_create_linear, dict_create_linear_expandable)
9970         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9971         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9972         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9973         taking multidictionary argument.
9974         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9975         * block.h (struct block) <dict>: Change to multidictionary
9976         and rename `multidict'.
9977         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9978         symmisc.c: Update all dictionary references to multidictionary.
9979
9980 2019-01-10  Keith Seitz  <keiths@redhat.com>
9981
9982         PR gdb/23712
9983         PR symtab/23010
9984         * dictionary.c: Include unordered_map.
9985         (pending_to_vector): New function.
9986         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9987         Rewrite the non-"_1" functions to take vector instead
9988         of linked list.
9989         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9990         "new" _1 versions of the same name.
9991         (multidictionary): Define.
9992         (std::hash<enum language): New definition.
9993         (collate_pending_symbols_by_language, mdict_create_hashed)
9994         (mdict_create_hashed_expandable, mdict_create_linear)
9995         (mdict_create_linear_expandable, mdict_free)
9996         (find_language_dictionary, create_new_language_dictionary)
9997         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9998         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9999         (mdict_size, mdict_empty): New functions.
10000         * dictionary.h (mdict_iterator): Define.
10001
10002 2019-01-10  Pedro Alves  <palves@redhat.com>
10003
10004         * breakpoint.c (read_uploaded_action)
10005         (create_tracepoint_from_upload): Adjust to use
10006         gdb::unique_xmalloc_ptr.
10007         * ctf.c (ctf_write_uploaded_tp):
10008         (SET_ARRAY_FIELD): Use emplace_back.
10009         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10010         * tracefile-tfile.c (tfile_write_uploaded_tp):
10011         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10012         gdb::unique_xmalloc_ptr.
10013         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10014         at_string, cond_string, cmd_strings>: Replace char pointers
10015         with gdb::unique_xmalloc_ptr.
10016
10017 2019-01-10  Pedro Alves  <palves@redhat.com>
10018
10019         * solib-target.c (library_list_start_library): Don't xstrdup name.
10020
10021 2019-01-10  Pedro Alves  <palves@redhat.com>
10022
10023         * mdebugread.c (parse_partial_symbols): Use
10024         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10025
10026 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10027
10028         * linux-fork.c (scoped_switch_fork_info)
10029         <~scoped_switch_fork_info>: Fix incorrect variable name.
10030
10031 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10032
10033         * linux-fork.c (scoped_switch_fork_info)
10034         <scoped_switch_fork_info>: Make explicit.
10035         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10036
10037 2019-01-10  Tom Tromey  <tom@tromey.com>
10038
10039         * objfiles.h (objfile::reset_psymtabs): Update.
10040         * objfiles.c (objfile::objfile): Update.
10041         * psymtab.h (psymtab_storage::obstack): Update.
10042         (psymtab_storage::m_obstack): Use gdb::optional.
10043         (class psymtab_storage): Update comment.  Remove objfile
10044         parameter.
10045         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10046
10047 2019-01-10  Tom Tromey  <tom@tromey.com>
10048
10049         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10050         <free_psymtabs>: Now private.
10051         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10052         (allocate_psymtab): Use new method.
10053
10054 2019-01-10  Tom Tromey  <tom@tromey.com>
10055
10056         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10057         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10058         * mdebugread.c (parse_partial_symbols): Use
10059         allocate_dependencies.
10060         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10061         allocate_dependencies.
10062         (process_psymtab_comp_unit_reader)
10063         (build_type_psymtab_dependencies): Likewise.
10064         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10065
10066 2019-01-10  Tom Tromey  <tom@tromey.com>
10067
10068         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10069         PSYMBOL_SET_LANGUAGE.
10070         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10071
10072 2019-01-10  Tom Tromey  <tom@tromey.com>
10073
10074         * psymtab.h (psymtab_storage::obstack): New method.
10075         <m_obstack>: Rename from obstack; now private.
10076         * psymtab.c (psymtab_storage): Update.
10077         * dwarf2read.c (create_addrmap_from_index)
10078         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10079         Update.
10080
10081 2019-01-10  Tom Tromey  <tom@tromey.com>
10082
10083         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10084         * objfiles.h (objfile::reset_psymtabs): New method.
10085
10086 2019-01-10  Tom Tromey  <tom@tromey.com>
10087
10088         * symmisc.c (print_symbol_bcache_statistics): Update.
10089         (print_objfile_statistics): Update.
10090         * symfile.c (reread_symbols): Update.
10091         * psymtab.h (class psymtab_storage): New.
10092         * psymtab.c (psymtab_storage): New constructor.
10093         (~psymtab_storage): New destructor.
10094         (require_partial_symbols): Update.
10095         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10096         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10097         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10098         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10099         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10100         (start_psymtab_common, end_psymtab_common)
10101         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10102         (allocate_psymtab): Update.
10103         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10104         Update.
10105         (dump_psymtab_addrmap, maintenance_print_psymbols)
10106         (maintenance_check_psymtabs): Update.
10107         (class objfile_psymtabs): Move to objfiles.h.
10108         * psympriv.h (discard_psymtab): Now inline.
10109         (psymtab_discarder::psymtab_discarder): Update.
10110         (psymtab_discarder::~psymtab_discarder): Update.
10111         (ALL_OBJFILE_PSYMTABS): Rewrite.
10112         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10113         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10114         Remove fields.
10115         <partial_symtabs>: New field.
10116         (class objfile_psymtabs): Move from psymtab.h.  Update.
10117         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10118         psymbol_cache.
10119         (objfile::~objfile): Don't destroy psymbol_cache.
10120         * mdebugread.c (parse_partial_symbols): Update.
10121         * dwarf2read.c (create_addrmap_from_index)
10122         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10123         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10124         (add_partial_subprogram, dwarf2_ranges_read): Update.
10125         * dwarf-index-write.c (write_address_map)
10126         (write_one_signatured_type, recursively_write_psymbols)
10127         (class debug_names, class debug_names, write_psymtabs_to_index):
10128         Update.
10129
10130 2019-01-10  Tom Tromey  <tom@tromey.com>
10131
10132         * symtab.h (SYMBOL_SET_NAMES): Update.
10133         (symbol_set_names): Update.
10134         (MSYMBOL_SET_NAMES): Update.
10135         * symtab.c (symbol_set_names): Change argument to be an
10136         objfile_per_bfd_storage.
10137         * psymtab.c (add_psymbol_to_bcache): Update.
10138         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10139
10140 2019-01-10  Tom Tromey  <tom@tromey.com>
10141
10142         * symtab.c (create_demangled_names_hash): Change argument to be an
10143         objfile_per_bfd_storage.
10144         (symbol_set_names): Update.
10145
10146 2019-01-10  Tom Tromey  <tom@tromey.com>
10147
10148         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10149         init_psymbol_list.
10150         * psymtab.c (init_psymbol_list): Do nothing if already called.
10151         * psympriv.h (init_psymbol_list): Add comment.
10152         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10153         init_psymbol_list.
10154         * dbxread.c (dbx_symfile_read): Unconditionally call
10155         init_psymbol_list.
10156
10157 2019-01-10  Tom Tromey  <tom@tromey.com>
10158
10159         * xcoffread.c (scan_xcoff_symtab): Update.
10160         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10161         "where".
10162         * mdebugread.c (parse_partial_symbols)
10163         (handle_psymbol_enumerators): Update.
10164         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10165         * dbxread.c (read_dbx_symtab): Update.
10166         * psympriv.h (psymbol_placement): New enum.
10167         (add_psymbol_to_list): Update.
10168
10169 2019-01-10  Tom Tromey  <tom@tromey.com>
10170
10171         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10172         static_psymbols parameters.
10173         (scan_xcoff_symtab): Update.
10174         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10175         static_psymbols parameters.
10176         * psympriv.h (start_psymtab_common): Update.
10177         * mdebugread.c (parse_partial_symbols): Update.
10178         * dwarf2read.c (create_partial_symtab): Update.
10179         * dbxread.c (read_dbx_symtab): Update.
10180         (start_psymtab): Remove global_psymbols and static_psymbols
10181         parameters.
10182
10183 2019-01-10  Tom Tromey  <tom@tromey.com>
10184
10185         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10186         * psymtab.c (allocate_psymtab): Add comment.
10187         * psympriv.h (allocate_psymtab): Add comment.
10188         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10189         initializations.
10190         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10191
10192 2019-01-10  Tom Tromey  <tom@tromey.com>
10193
10194         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10195         Don't declare.
10196         * mipsread.c: Include mdebugread.h.
10197         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10198         Declare.
10199         * elfread.c: Include mdebugread.h.
10200
10201 2019-01-09  Tom Tromey  <tom@tromey.com>
10202
10203         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10204         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10205         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10206         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10207         (psym_lookup_symbol, psym_find_last_source_symtab)
10208         (psym_forget_cached_source_info, psym_print_stats)
10209         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10210         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10211         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10212         (psym_find_compunit_symtab_by_address)
10213         (maintenance_print_psymbols, maintenance_info_psymtabs)
10214         (maintenance_check_psymtabs): Use ranged for.
10215         * psymtab.h (class objfile_psymtabs): New.
10216         (require_partial_symbols): Return objfile_psymtabs.
10217         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10218
10219 2019-01-09  Tom Tromey  <tom@tromey.com>
10220
10221         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10222         (find_pc_mapped_section, list_overlays_command)
10223         (map_overlay_command, unmap_overlay_command)
10224         (simple_overlay_update): Use all_objfiles.
10225         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10226         * printcmd.c (info_symbol_command): Use all_objfiles.
10227         * objfiles.h (ALL_OBJSECTIONS): Remove.
10228         * maint.c (maintenance_translate_address): Use all_objfiles.
10229         * gcore.c (gcore_create_callback): Use all_objfiles.
10230         (objfile_find_memory_regions): Likewise.
10231
10232 2019-01-09  Tom Tromey  <tom@tromey.com>
10233
10234         * symtab.c (find_line_symtab, info_sources_command)
10235         (make_source_files_completion_list): Use objfile_compunits.
10236         * source.c (select_source_symtab): Use objfile_compunits.
10237         * objfiles.h (struct objfile): Update comment.
10238         (ALL_OBJFILES): Remove.
10239         (ALL_FILETABS): Remove.
10240         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10241         objfile_compunits.
10242
10243 2019-01-09  Tom Tromey  <tom@tromey.com>
10244
10245         * symmisc.c (print_objfile_statistics, dump_objfile)
10246         (maintenance_print_symbols): Use compunit_filetabs.
10247         * source.c (forget_cached_source_info_for_objfile): Use
10248         compunit_filetabs.
10249         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10250         (ALL_FILETABS): Use compunit_filetabs.
10251         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10252         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10253
10254 2019-01-09  Tom Tromey  <tom@tromey.com>
10255
10256         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10257         (compunit_filetabs): New.
10258         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10259         compunit_filetabs.
10260         (info_sources_command, make_source_files_completion_list): Remove
10261         declaration.
10262         * symmisc.c (print_objfile_statistics, dump_objfile)
10263         (maintenance_print_symbols): Remove declaration.
10264         (maintenance_info_symtabs): Use compunit_filetabs.
10265         (maintenance_info_line_tables): Likewise.
10266         * source.c (select_source_symtab): Change local variable name.
10267         (forget_cached_source_info_for_objfile): Remove declaration.
10268         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10269         * objfiles.c (objfile_relocate1): Remove declaration.
10270         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10271         declaration.
10272         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10273         * coffread.c (coff_symtab_read): Remove declaration.
10274         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10275         compunit_filetabs.
10276
10277 2019-01-09  Tom Tromey  <tom@tromey.com>
10278
10279         * symtab.c (lookup_objfile_from_block)
10280         (find_pc_sect_compunit_symtab, search_symbols)
10281         (default_collect_symbol_completion_matches_break_on): Use
10282         objfile_compunits.
10283         * objfiles.h (ALL_COMPUNITS): Remove.
10284         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10285         * cp-support.c (add_symbol_overload_list_qualified): Use
10286         objfile_compunits.
10287         * ada-lang.c (ada_collect_symbol_completion_matches)
10288         (ada_add_global_exceptions): Use objfile_compunits.
10289
10290 2019-01-09  Tom Tromey  <tom@tromey.com>
10291
10292         * source.c (select_source_symtab)
10293         (forget_cached_source_info_for_objfile): Remove declaration.
10294         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10295         declaration.
10296         * maint.c (count_symtabs_and_blocks): Remove declaration.
10297         * cp-support.c (add_symbol_overload_list_qualified): Remove
10298         declaration.
10299         * coffread.c (coff_symtab_read): Remove declaration.
10300         * symtab.c (lookup_symbol_in_objfile_symtabs)
10301         (basic_lookup_transparent_type_1): Use objfile_compunits.
10302         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10303         (info_sources_command, search_symbols)
10304         (default_collect_symbol_completion_matches_break_on)
10305         (make_source_files_completion_list): Remove declaration.
10306         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10307         (ada_collect_symbol_completion_matches)
10308         (ada_add_global_exceptions): Remove declaration.
10309         * linespec.c (iterate_over_all_matching_symtabs): Use
10310         objfile_compunits.
10311         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10312         (class objfile_compunits): New.
10313         (ALL_COMPUNITS): Use objfile_compunits.
10314         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10315         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10316         objfile_compunits.
10317         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10318
10319 2019-01-09  Tom Tromey  <tom@tromey.com>
10320
10321         * symtab.c (search_symbols)
10322         (default_collect_symbol_completion_matches_break_on): Use
10323         objfile_msymbols.
10324         * ada-lang.c (ada_lookup_simple_minsym)
10325         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10326         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10327         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10328         objfile_msymbols.
10329         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10330         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10331         * objc-lang.c (find_methods): Use objfile_msymbols.
10332         (info_selectors_command, info_classes_command): Likewise.
10333         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10334         * objfiles.h (class objfile_msymbols): New.
10335         (ALL_OBJFILE_MSYMBOLS): Remove.
10336         (ALL_MSYMBOLS): Remove.
10337
10338 2019-01-09  Tom Tromey  <tom@tromey.com>
10339
10340         * common/next-iterator.h (next_adapter): Add Iterator template
10341         parameter.
10342         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10343         (class all_objfiles_safe): New.
10344         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10345         * objfiles.c (put_objfile_before): Update comment.
10346         (add_separate_debug_objfile): Likewise.
10347         (free_all_objfiles): Use all_objfiles_safe.
10348         (objfile_purge_solibs): Likewise.
10349
10350 2019-01-09  Tom Tromey  <tom@tromey.com>
10351
10352         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10353         (expand_symtab_containing_pc, lookup_static_symbol)
10354         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10355         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10356         all_objfiles.
10357         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10358         * breakpoint.c (create_overlay_event_breakpoint)
10359         (create_longjmp_master_breakpoint)
10360         (create_std_terminate_master_breakpoint)
10361         (create_exception_master_breakpoint): Use all_objfiles.
10362         * linux-thread-db.c (try_thread_db_load_from_pdir)
10363         (has_libpthread): Use all_objfiles.
10364         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10365         * linespec.c (iterate_over_all_matching_symtabs)
10366         (search_minsyms_for_name): Use all_objfiles.
10367         * maint.c (maintenance_info_sections): Use all_objfiles.
10368         * main.c (captured_main_1): Use all_objfiles.
10369         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10370         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10371         * guile/scm-pretty-print.c
10372         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10373         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10374         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10375         (maintenance_print_msymbols): Use all_objfiles.
10376         * source.c (select_source_symtab): Use all_objfiles.
10377         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10378         * symfile.c (remove_symbol_file_command)
10379         (expand_symtabs_matching, map_symbol_filenames): Use
10380         all_objfiles.
10381         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10382         all_objfiles.
10383         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10384         * objc-lang.c (find_methods): Use all_objfiles.
10385         * objfiles.c (have_partial_symbols, have_full_symbols)
10386         (have_minimal_symbols, qsort_cmp)
10387         (default_iterate_over_objfiles_in_search_order): Use
10388         all_objfiles.
10389         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10390         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10391         (maintenance_check_psymtabs): Use all_objfiles.
10392         (ALL_PSYMTABS): Remove.
10393         * compile/compile-object-run.c (do_module_cleanup): Use
10394         all_objfiles.
10395         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10396         * cp-support.c (add_symbol_overload_list_qualified): Use
10397         all_objfiles.
10398         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10399         Use all_objfiles.
10400         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10401         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10402         all_objfiles.
10403         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10404         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10405         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10406         Uses all_objfiles.
10407         * solib.c (solib_read_symbols): Use all_objfiles
10408
10409 2019-01-09  Tom Tromey  <tom@tromey.com>
10410
10411         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10412         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10413         all_objfiles.
10414         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10415         * symmisc.c (print_symbol_bcache_statistics)
10416         (print_objfile_statistics, maintenance_print_objfiles)
10417         (maintenance_info_symtabs, maintenance_check_symtabs)
10418         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10419         all_objfiles.
10420         * source.c (forget_cached_source_info): Use all_objfiles.
10421         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10422         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10423         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10424         * objfiles.c (update_section_map): Use all_objfiles.
10425         (shared_objfile_contains_address_p): Likewise.
10426         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10427         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10428
10429 2019-01-09  Tom Tromey  <tom@tromey.com>
10430
10431         * common/next-iterator.h: New file.
10432         * objfiles.h (class all_objfiles): New.
10433         (struct objfile_iterator): New.
10434
10435 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10436
10437         * NEWS: Move the description of the changed "frame", "select-frame",
10438          and "info frame" commands to the Changed commands section.
10439
10440 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10441
10442         * gdbtypes.c (check_stub_method_group): Remove handling of old
10443         mangling schemes.
10444         * linespec.c (find_methods): Likewise.
10445         * stabsread.c (read_member_functions): Likewise.
10446         * valops.c (search_struct_method): Likewise.
10447         (value_struct_elt_for_reference): Likewise.
10448         * NEWS: Mention this change.
10449
10450 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10451
10452         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10453         print_source_lines.
10454         * source.c (print_source_lines_base): Update line number check.
10455         (print_source_lines): New function.
10456         (source_lines_range::source_lines_range): New function.
10457         * source.h (class source_lines_range): New class.
10458         (print_source_lines): New declaration.
10459
10460 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10461
10462         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10463
10464 2019-01-08  Tom Tromey  <tom@tromey.com>
10465             Simon Marchi  <simon.marchi@ericsson.com>
10466
10467         PR gdb/24060
10468         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10469         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10470         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10471         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10472         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10473         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10474
10475 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10476
10477         * source.c (select_source_symtab): Move header comment to
10478         declaration in source.h.
10479         (forget_cached_source_info_for_objfile): Likewise.
10480         (forget_cached_source_info): Likewise.
10481         (identify_source_line): Likewise.
10482         * source.h (identify_source_line): Move declaration from symtab.h
10483         and add comment from source.c
10484         (print_source_lines): Likewise.
10485         (forget_cached_source_info_for_objfile): Likewise.
10486         (forget_cached_source_info): Likewise.
10487         (select_source_symtab): Likewise.
10488         (enum print_source_lines_flag): Move definition from symtab.h.
10489         * symtab.h (identify_source_line): Move declaration to source.h.
10490         (print_source_lines): Likewise.
10491         (forget_cached_source_info_for_objfile): Likewise.
10492         (forget_cached_source_info): Likewise.
10493         (select_source_symtab): Likewise.
10494         (enum print_source_lines_flag): Move definition to source.h.
10495         * tui/tui-hooks.c: Add 'source.h' include.
10496
10497 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10498
10499         * source.c (print_source_lines_base): Handle requests to print
10500         reverse line number sequences, and guard against empty lines
10501         string.
10502
10503 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10504
10505         * source.c (print_source_lines_base): Fix skip of '\r' if next
10506         character is '\n'.
10507
10508 2019-01-06  Tom Tromey  <tom@tromey.com>
10509
10510         * c-exp.y (struct c_parse_state) <macro_original_text,
10511         expansion_obstack>: New member.
10512         (macro_original_text, expansion_obstack): Remove globals.
10513         (scan_macro_expansion, scanning_macro_expansion)
10514         (finished_macro_expansion): Update.
10515         (scan_macro_cleanup): Remove.
10516         (yylex, c_parse): Update.
10517
10518 2019-01-06  Tom Tromey  <tom@tromey.com>
10519
10520         * c-exp.y (struct c_parse_state) <strings>: New member.
10521         (operator_stoken): Update.
10522
10523 2019-01-06  Tom Tromey  <tom@tromey.com>
10524
10525         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10526         (union type_stack_elt) <typelist_val>: Now a pointer to
10527         std::vector.
10528         (type_stack_cleanup): Don't declare.
10529         (push_typelist): Update.
10530         * parse.c (pop_typelist): Return a std::vector.
10531         (push_typelist): Take a std::vector.
10532         (follow_types): Update.  Do not free args.
10533         (type_stack_cleanup): Remove.
10534         * c-exp.y (struct c_parse_state): New.
10535         (cpstate): New global.
10536         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10537         (nonempty_typelist): Update.
10538         (func_mod): Create a new vector.
10539         (c_parse): Create a c_parse_state.
10540         (check_parameter_typelist): Do not delete params.
10541         (function_method): Update.  Do not delete type_list.
10542
10543 2019-01-06  Tom Tromey  <tom@tromey.com>
10544
10545         PR gdb/28155:
10546         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10547         check_typedef.
10548         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10549         (print_return_value): Likewise.
10550
10551 2019-01-05  Tom Tromey  <tom@tromey.com>
10552
10553         * contrib/cleanup_check.py: Remove.
10554         * contrib/gcc-with-excheck: Remove.
10555         * contrib/exsummary.py: Remove.
10556         * contrib/excheck.py: Remove.
10557
10558 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10559
10560         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10561         NULL. Initialize tpprev to NULL instead of assigning it
10562         to NULL on the next statement.
10563         * windows-nat.c (windows_delete_thread): Remove check for
10564         main_thread_id before printing thread exit notifications.
10565         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10566         Remove thread ID check against main_thread_id.
10567         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10568         windows_delete_thread.
10569         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10570
10571 2019-01-04  Tom Tromey  <tom@tromey.com>
10572
10573         * compile/compile.c (_initialize_compile): Use upper case for
10574         metasyntactic variables.
10575         * symmisc.c (_initialize_symmisc): Use upper case for
10576         metasyntactic variables.
10577         * psymtab.c (_initialize_psymtab): Use upper case for
10578         metasyntactic variables.
10579         * demangle.c (demangle_command): Use upper case for metasyntactic
10580         variables.
10581         (_initialize_demangler): Likewise.
10582         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10583         variables.
10584
10585 2019-01-03  Tom Tromey  <tom@tromey.com>
10586
10587         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10588
10589 2019-01-03  Tom Tromey  <tom@tromey.com>
10590
10591         * python/py-symtab.c (salpy_str): Update.
10592         (struct salpy_sal_object) <symtab>: Now a PyObject.
10593         (salpy_dealloc): Update.
10594         (del_objfile_sal): Use gdbpy_ref.
10595
10596 2019-01-03  Tom Tromey  <tom@tromey.com>
10597
10598         * python/py-type.c (convert_field): Use new_reference.  Return
10599         gdbpy_ref.
10600         (make_fielditem): Return gdbpy_ref.
10601         (typy_fields): Update.
10602         (typy_getitem): Update.
10603         (field_name): Return gdbpy_ref.  Use new_reference.
10604         (typy_iterator_iternext): Update.
10605
10606 2019-01-03  Tom Tromey  <tom@tromey.com>
10607
10608         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10609
10610 2019-01-03  Tom Tromey  <tom@tromey.com>
10611
10612         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10613         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10614         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10615         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10616         (pspy_set_type_printers): Likewise.
10617         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10618         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10619         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10620         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10621         (objfpy_set_type_printers): Likewise.
10622
10623 2019-01-03  Tom Tromey  <tom@tromey.com>
10624
10625         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10626         (gdbpy_print_stack): Use gdbpy_err_fetch.
10627         * python/python-internal.h (class gdbpy_err_fetch): New class.
10628         (class gdbpy_enter) <m_error_type, m_error_value,
10629         m_error_traceback>: Remove.
10630         <m_error>: New member.
10631         (gdbpy_exception_to_string): Don't declare.
10632         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10633         * python/py-value.c (convert_value_from_python): Use
10634         gdbpy_err_fetch.
10635         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10636         gdbpy_exception_to_string.
10637         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10638         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10639         gdbpy_err_fetch.
10640
10641 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10642
10643         * linux-nat.c (delete_lwp_cleanup): Delete.
10644         (struct lwp_deleter): New struct.
10645         (lwp_info_up): New typedef.
10646         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10647         lwp_info_up.
10648
10649 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10650
10651         * linux-fork.c (class scoped_switch_fork_info): New class.
10652         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10653
10654 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10655
10656         * valops.c (find_overload_match): Remove use of null_cleanup, and
10657         calls to do_cleanups.
10658
10659 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10660
10661         * compile/compile-cplus-types.c
10662         (compile_cplus_instance::decl_name): Handle changes to
10663         cp_func_name.
10664         * cp-support.c (cp_func_name): Update header comment, update
10665         return type.
10666         * cp-support.h (cp_func_name): Update return type in declaration.
10667         * valops.c (find_overload_match): Move temp_func local to top
10668         level of function and change its type.  Use temp_func to hold and
10669         delete temporary string obtained from cp_func_name.
10670
10671 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10672
10673         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10674         gdb::char_vector, remove cleanup, and update uses of `msg`.
10675
10676 2019-01-03  Jim Wilson  <jimw@sifive.com>
10677
10678         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10679
10680 2019-01-02  Tom Tromey  <tom@tromey.com>
10681
10682         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10683         (tdesc_parse_xml): Remove cleanups.
10684         * target-descriptions.h (make_cleanup_free_target_description):
10685         Don't declare.
10686         (target_desc_deleter): New struct.
10687         (target_desc_up): New typedef.
10688         * target-descriptions.c (target_desc_deleter::operator()): Rename
10689         from free_target_description.
10690         (make_cleanup_free_target_description): Remove.
10691
10692 2019-01-02  Tom Tromey  <tom@tromey.com>
10693
10694         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10695         constructor, destructor.
10696         (linespec_parser): Remove typedef.
10697         (~linespec_parser): Rename from linespec_parser_delete.
10698         (linespec_lex_to_end, linespec_complete_label)
10699         (linespec_complete): Update.
10700         (decode_line_full): Remove cleanups.
10701         (decode_line_1): Update.
10702
10703 2019-01-02  Tom Tromey  <tom@tromey.com>
10704
10705         * python/python-internal.h (inferior_to_inferior_object): Change
10706         return type.
10707         * python/py-exitedevent.c (create_exited_event_object): Update.
10708         * python/py-inferior.c (inferior_to_inferior_object): Return
10709         gdbpy_ref.
10710         (python_new_inferior, python_inferior_deleted)
10711         (thread_to_thread_object, delete_thread_object)
10712         (build_inferior_list, gdbpy_selected_inferior): Update.
10713         * python/py-infthread.c (create_thread_object): Update.  Also fail
10714         if inferior_to_inferior_object fails.
10715
10716 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10717
10718         * inferior.h (class inferior) <displaced_step_state>: New field.
10719         * infrun.h (struct displaced_step_state): Move here from
10720         infrun.c.  Initialize fields, add constructor.
10721         <inf>: Remove field.
10722         <reset>: New method.
10723         * infrun.c (struct displaced_step_inferior_state): Move to
10724         infrun.h.
10725         (displaced_step_inferior_states): Remove.
10726         (get_displaced_stepping_state): Adust.
10727         (displaced_step_in_progress_any_inferior): Adjust.
10728         (displaced_step_in_progress_thread): Adjust.
10729         (displaced_step_in_progress): Adjust.
10730         (add_displaced_stepping_state): Remove.
10731         (get_displaced_step_closure_by_addr): Adjust.
10732         (remove_displaced_stepping_state): Remove.
10733         (infrun_inferior_exit): Call displaced_step_state.reset.
10734         (use_displaced_stepping): Don't check for NULL.
10735         (displaced_step_prepare_throw): Call
10736         get_displaced_stepping_state.
10737         (displaced_step_fixup): Don't check for NULL.
10738         (prepare_for_detach): Don't check for NULL.
10739
10740 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10741
10742         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10743          in case of call that did not complete.
10744
10745 2019-01-02  Andrey Utkin  <autkin@undo.io>
10746
10747         * symfile.c (find_separate_debug_file): Fix search of debug files for
10748         remote debuggee.
10749
10750 2019-01-02  Tom Tromey  <tom@tromey.com>
10751
10752         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10753         indentation.
10754         * python/py-frame.c (frapy_older): Remove cast.
10755         (frapy_newer): Likewise.
10756         * python/py-breakpoint.c (local_setattro): Remove cast.
10757         * python/py-arch.c (archpy_name): Remove local variable.
10758         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10759
10760 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10761
10762         * unittests/basic_string_view/element_access/char/empty.cc:
10763         Fix year range in copyright header.
10764
10765 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10766
10767         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10768         Delete.
10769         <operator==>: Update with for removed field.
10770         <hash>: Likewise.
10771         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10772         <isa_features>: ...this.
10773         <abi_features>: New field.
10774         (riscv_isa_flen): Update comment.
10775         (riscv_abi_xlen): New declaration.
10776         (riscv_abi_flen): New declaration.
10777         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10778         isa_features.
10779         (riscv_abi_xlen): New function.
10780         (riscv_isa_flen): Update to get answer from isa_features.
10781         (riscv_abi_flen): New function.
10782         (riscv_has_fp_abi): Update to get answer from abi_features.
10783         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10784         xlen and flen.
10785         (riscv_call_info) <xlen, flen>: Update comment.
10786         (riscv_call_arg_struct): Remove invalid assertions
10787         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10788         is removed.
10789         (riscv_gdbarch_init): Gather isa features and abi features
10790         separately, ensure both match on the gdbarch when reusing an old
10791         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10792         a target with 64-bit float hardware.
10793
10794 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10795
10796         * source.c (search_command_helper): Stop reverse search
10797         when line 1 has been searched.
10798
10799 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10800
10801         * record-full.c (record_full_base_target::close): Rewrite
10802         record_full_core_buf_list free logic.
10803
10804 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10805
10806         * break-catch-syscall.c (print_one_catch_syscall): xfree
10807         the last text.
10808
10809 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10810
10811         * top.c (print_gdb_version): Update Copyright year in version
10812         message.
10813
10814 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10815
10816         Update copyright year range in all GDB files.
10817
10818 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10819
10820         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10821
10822 For older changes see ChangeLog-2018.
10823 \f
10824 Local Variables:
10825 mode: change-log
10826 left-margin: 8
10827 fill-column: 74
10828 version-control: never
10829 coding: utf-8
10830 End:
10831